]> git.ipfire.org Git - people/stevee/network.git/commitdiff
inetcalc: Use memcmp to determine which IP address is higher
authorMichael Tremer <michael.tremer@ipfire.org>
Wed, 31 May 2017 22:10:34 +0000 (23:10 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 31 May 2017 22:10:34 +0000 (23:10 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/inetcalc.c

index cdb4a0f639fd227d9a99d78605d783e35ceced52..d08f0f3a69a820a48cf53fe2269382ecb0673299 100644 (file)
@@ -206,10 +206,8 @@ static int ip_address_gt(const ip_address_t* a1, const ip_address_t* a2) {
        if (a1->family != a2->family || a1->prefix != a2->prefix)
                return -1;
 
-       for (unsigned int i = 0; i < 16; i++) {
-               if (a1->addr.s6_addr[i] > a2->addr.s6_addr[i])
-                       return 0;
-       }
+       if (memcmp(&a1->addr.s6_addr, &a2->addr.s6_addr, sizeof(a1->addr.s6_addr)) > 0)
+               return 0;
 
        return 1;
 }