]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Make GDB compile with Python 3 on MinGW
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
27204489
CB
12019-08-22 Christian Biesinger <cbiesinger@google.com>
2
3 * python/lib/gdb/__init__.py (_execute_file): New function.
4 * python/python.c (python_run_simple_file): Call gdb._execute_file
5 on Windows.
6
43771869
AB
72019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
8
9 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
10 all uses as this was never set to anything but a zero value.
11
26c957f1
PA
122019-08-21 Bogdan Harjoc <harjoc@gmail.com>
13
14 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
15
c07aae6e
CB
162019-08-21 Christian Biesinger <cbiesinger@google.com>
17
18 * tui/tui-data.h (tui_gen_win_info): Add an =default
19 move constructor, required by some GCC versions.
20
3960cb7a
JF
212019-08-21 Jinke Fan <fanjinke51@yeah.net>
22
23 * go32-nat.c (go32_sysinfo): Add hygon_p.
24
04c72a68
TT
252019-08-20 Tom Tromey <tom@tromey.com>
26
27 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
28 line_from_reg_element_no, first_reg_element_no_inline,
29 display_all_data, delete_data_content_windows,
30 erase_data_content>: Now private.
31
072272ce
TT
322019-08-20 Tom Tromey <tom@tromey.com>
33
34 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
35 (tui_unhighlight_win, tui_highlight_win)
36 (tui_win_info::make_window): Update.
37 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
38
973961bd
TT
392019-08-20 Tom Tromey <tom@tromey.com>
40
41 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
42 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
43 (MAX_PID_WIDTH): Move to tui-stack.c.
44 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
45 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
46 (MAX_PID_WIDTH): Move from tui-data.h.
47
ab0e1f1a
TT
482019-08-20 Tom Tromey <tom@tromey.com>
49
50 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
51 * tui/tui-wingeneral.c (box_win): Change type of win_info.
52 (box_win): Update.
53 (tui_gen_win_info::make_window): Rename from tui_make_window.
54 (tui_win_info::make_window): New method.
55 (tui_gen_win_info::make_visible): Update.
56 * tui/tui-source.c (tui_source_window::set_contents): Update.
57 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
58 (tui_data_window::display_registers_from): Update.
59 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
60 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
61 Declare.
62 <can_box>: Remove.
63 <title>: Remove.
64 (struct tui_win_info) <make_window>: Declare.
65 <can_box>: Now virtual.
66 <title>: New member.
67 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
68 * tui/tui-command.c (tui_cmd_window::resize): Update.
69
100c2bf3
TT
702019-08-20 Tom Tromey <tom@tromey.com>
71
72 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
73 * tui/tui-regs.c (tui_data_window::show_registers): Update.
74 (tui_data_window::check_register_values): Update.
75
fa4dc567
TT
762019-08-20 Tom Tromey <tom@tromey.com>
77
78 * tui/tui-regs.h (struct tui_data_window): Use
79 DISABLE_COPY_AND_ASSIGN.
80 <regs_content>: Change type, removing unique_ptr.
81 <tui_data_window>: Add move constructor.
82 * tui/tui-regs.c (tui_data_window::show_registers)
83 (tui_data_window::show_register_group)
84 (tui_data_window::display_registers_from)
85 (tui_data_window::display_registers_from)
86 (tui_data_window::first_data_item_displayed)
87 (tui_data_window::delete_data_content_windows)
88 (tui_data_window::rerender, tui_data_window::refresh_window)
89 (tui_data_window::check_register_values): Update.
90
ca02d7c8
TT
912019-08-20 Tom Tromey <tom@tromey.com>
92
93 * tui/tui-regs.h (struct tui_data_window) <show_registers,
94 show_register_group>: Declare.
95 (tui_show_register_group): Don't declare.
96 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
97 tui_show_registers.
98 (tui_data_window::show_register_group): Rename from
99 tui_show_register_group.
100 (tui_data_window::check_register_values, tui_reg_command):
101 Update.
102 * tui/tui-layout.c (tui_set_layout): Update.
103
63356bfd
TT
1042019-08-20 Tom Tromey <tom@tromey.com>
105
106 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
107 Declare.
108 (tui_check_register_values): Don't declare.
109 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
110 from tui_check_register_values.
111 * tui/tui-hooks.c (tui_register_changed): Update.
112
42cc14a7
TT
1132019-08-20 Tom Tromey <tom@tromey.com>
114
115 * tui/tui-regs.c (tui_reg_layout): Move later.
116 (tui_show_registers): Don't enable TUI mode or change layout.
117
b9ad3686
TT
1182019-08-20 Tom Tromey <tom@tromey.com>
119
120 * tui/tui-regs.h (struct tui_data_item_window)
121 <~tui_data_item_window>: Remove.
122 <content>: Now a unique_xmalloc_ptr.
123 * tui/tui-regs.c (tui_register_format): Return a
124 unique_xmalloc_ptr.
125 (tui_get_register): Update.
126 (~tui_data_item_window): Remove.
127 (tui_data_window::display_registers_from, tui_display_register):
128 Update.
129 * tui/tui-io.h (tui_expand_tabs): Update.
130 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
131 Remove "col" parameter.
132
8e114aab
TT
1332019-08-20 Tom Tromey <tom@tromey.com>
134
135 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
136 field.
137 * tui/tui-regs.c (~tui_data_item_window): Update.
138
1a4f81dd
TT
1392019-08-20 Tom Tromey <tom@tromey.com>
140
141 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
142 earlier.
143
0f8d8876
TT
1442019-08-20 Tom Tromey <tom@tromey.com>
145
146 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
147
605dc2c2
TT
1482019-08-20 Tom Tromey <tom@tromey.com>
149
150 * tui/tui-source.h (struct tui_source_window): Update.
151 * tui/tui-regs.c (tui_show_registers): Update.
152 * tui/tui-disasm.h (struct tui_disasm_window): Update.
153 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
154 (NO_REGS_STRING): Remove defines.
155
aedbe3bb
CM
1562019-08-20 Conrad Meyer <cem@FreeBSD.org>
157
158 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
159 unnecessary thread walk if remote doesn't support the packet.
160
7ce8f214
TT
1612019-08-19 Tom Tromey <tromey@adacore.com>
162
163 * python/py-value.c (value_has_field): Fix indentation.
164
f21c2bd7
TT
1652019-08-19 Tom Tromey <tromey@adacore.com>
166
167 * printcmd.c (do_one_display, info_display_command): Update.
168 * block.h (contained_in): Return bool. Add allow_nested
169 parameter.
170 * block.c (contained_in): Return bool. Add allow_nested
171 parameter.
172
d806ea2d
TT
1732019-08-19 Tom Tromey <tom@tromey.com>
174
175 * configure: Rebuild.
176 * configure.ac: Disallow the combination of -static-libstdc++ and
177 source highlight.
178 * source-cache.c (get_language_name): Handle rust.
179 (source_cache::get_source_lines): Ignore highlighting exceptions.
180
398fdd60
TT
1812019-08-16 Tom Tromey <tom@tromey.com>
182
183 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
184 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
185 (struct tui_source_window_base) <make_visible, refresh_window,
186 resize>: Remove methods.
187 <execution_info>: Remove field.
188 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
189 (tui_show_source_line, tui_source_window_base)
190 (~tui_source_window_base): Update.
191 (tui_source_window_base::resize)
192 (tui_source_window_base::make_visible)
193 (tui_source_window_base::refresh_window): Remove.
194 (tui_source_window_base::update_exec_info): Update.
195 * tui/tui-source.c (tui_source_window::set_contents): Update.
196 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
197
e699d331
TT
1982019-08-16 Tom Tromey <tom@tromey.com>
199
200 * tui/tui-hooks.c (tui_remove_hooks): Don't set
201 deprecated_query_hook.
202
bb01dbfc
TT
2032019-08-16 Tom Tromey <tom@tromey.com>
204
205 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
206 (tui_update_source_windows_with_line): Update.
207 * tui/tui-source.h (struct tui_source_window)
208 <show_symtab_source>: Declare.
209 (tui_show_symtab_source): Don't declare.
210 * tui/tui-source.c (tui_show_symtab_source): Rename from
211 tui_show_symtab_source.
212
81c82c4b
TT
2132019-08-16 Tom Tromey <tom@tromey.com>
214
215 * tui/tui-winsource.h (struct tui_source_window_base)
216 <set_contents>: Declare.
217 * tui/tui-winsource.c
218 (tui_source_window_base::update_source_window_as_is): Update.
219 * tui/tui-source.h (struct tui_source_window) <set_contents>:
220 Declare.
221 (tui_set_source_content): Don't declare.
222 * tui/tui-source.c (tui_source_window::set_contents): Rename from
223 tui_set_source_content.
224 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
225 Declare.
226 (tui_set_disassem_content): Don't declare.
227 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
228 tui_set_disassem_content.
229
2ddaf614
TT
2302019-08-16 Tom Tromey <tom@tromey.com>
231
232 * tui/tui-winsource.h (struct tui_source_window_base)
233 <update_breakpoint_info>: Declare.
234 (tui_update_breakpoint_info): Don't declare.
235 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
236 (tui_update_all_breakpoint_info): Update.
237 (tui_source_window_base::update_breakpoint_info): Rename from
238 tui_update_breakpoint_info.
239 (tui_source_window_base::update_exec_info): Update.
240
017f9828
TT
2412019-08-16 Tom Tromey <tom@tromey.com>
242
243 * tui/tui-winsource.h (struct tui_source_window_base)
244 <update_source_window>: Declare.
245 (tui_update_source_window): Don't declare.
246 * tui/tui-winsource.c
247 (tui_source_window_base::update_source_window): Rename from
248 tui_update_source_window.
249 (tui_source_window_base::rerender): Update.
250 * tui/tui-source.c (tui_source_window::maybe_update): Update.
251 * tui/tui-disasm.c (tui_show_disassem)
252 (tui_show_disassem_and_update_source)
253 (tui_disasm_window::maybe_update): Update.
254
ed8358e9
TT
2552019-08-16 Tom Tromey <tom@tromey.com>
256
257 * tui/tui-winsource.h (struct tui_source_window_base)
258 <update_source_window_as_is>: Declare.
259 (tui_update_source_window_as_is): Don't declare.
260 * tui/tui-winsource.c (tui_update_source_window): Update
261 (tui_source_window_base::update_source_window_as_is): Rename from
262 tui_update_source_window_as_is.
263 (tui_source_window_base::refill): Update.
264 * tui/tui-source.c (tui_show_symtab_source): Update.
265 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
266 Update.
267
20149b6b
TT
2682019-08-16 Tom Tromey <tom@tromey.com>
269
270 * tui/tui-winsource.h (tui_update_source_window)
271 (tui_update_source_window_as_is): Remove "noerror" parameter.
272 * tui/tui-winsource.c (tui_update_source_window)
273 (tui_update_source_window_as_is): Remove "noerror" parameter.
274 (tui_update_source_windows_with_addr)
275 (tui_update_source_windows_with_line)
276 (tui_source_window_base::rerender)
277 (tui_source_window_base::refill): Update.
278 * tui/tui-source.h (tui_set_source_content)
279 (tui_show_symtab_source): Remove "noerror" parameter.
280 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
281 parameter.
282 (tui_show_symtab_source): Likewise.
283 (tui_source_window::maybe_update): Update.
284 * tui/tui-disasm.c (tui_show_disassem)
285 (tui_show_disassem_and_update_source)
286 (tui_disasm_window::do_scroll_vertical)
287 (tui_disasm_window::maybe_update): Update.
288
2d83e710
TT
2892019-08-16 Tom Tromey <tom@tromey.com>
290
291 * tui/tui.c (tui_is_window_visible): Update.
292 * tui/tui-wingeneral.c (tui_make_window)
293 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
294 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
295 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
296 (tui_set_win_height_command, parse_scrolling_args): Update.
297 * tui/tui-source.c (tui_source_window::style_changed): Update.
298 * tui/tui-regs.c (tui_show_registers)
299 (tui_data_window::first_data_item_displayed)
300 (tui_data_window::delete_data_content_windows)
301 (tui_check_register_values, tui_reg_command): Update.
302 * tui/tui-disasm.c (tui_show_disassem): Update.
303 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
304 method.
305 <is_visible>: Remove field.
306 * tui/tui-data.c (tui_next_win, tui_prev_win)
307 (tui_delete_invisible_windows): Update.
308
d4ab829a
TT
3092019-08-16 Tom Tromey <tom@tromey.com>
310
311 * tui/tui-winsource.h (struct tui_source_window_base)
312 <m_has_locator>: Remove.
313 * tui/tui-layout.c (show_source_disasm_command, show_data)
314 (show_source_or_disasm_and_command): Update.
315
aa7ca1bb
AH
3162019-08-16 Alan Hayward <alan.hayward@arm.com>
317
318 * NEWS (Other MI changes): New subsection.
319 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
320 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
321 * arch-utils.c (default_get_pc_address_flags): New function.
322 * arch-utils.h (default_get_pc_address_flags): New declaration.
323 * gdbarch.sh: Add get_pc_address_flags.
324 * gdbarch.c: Regenerate.
325 * gdbarch.h: Likewise.
326 * stack.c (print_pc): New function.
327 (print_frame_info) (print_frame): Call print_pc.
328
6eac171f
TV
3292019-08-16 Tom de Vries <tdevries@suse.de>
330
331 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
332 print_objfile_section_info.
333
3df505f6
TT
3342019-08-15 Tom Tromey <tom@tromey.com>
335
336 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
337 calling update_cmdwin_start_line.
338 * tui/tui-winsource.h (struct tui_source_window_base)
339 <do_make_visible_with_new_height, set_new_height>: Don't declare.
340 <rerender>: Declare.
341 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
342 Call rerender.
343 (tui_source_window_base::set_new_height): Remove.
344 (tui_source_window_base::rerender): Rename from
345 do_make_visible_with_new_height.
346 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
347 resize method.
348 (tui_win_info::make_invisible_and_set_new_height)
349 (tui_win_info::make_visible_with_new_height): Remove.
350 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
351 Declare.
352 * tui/tui-stack.c (tui_locator_window::rerender): New method.
353 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
354 do_make_visible_with_new_height>: Don't declare.
355 <rerender>: Declare.
356 * tui/tui-regs.c (tui_data_window::rerender): Rename from
357 set_new_height.
358 (tui_data_window::do_make_visible_with_new_height): Remove.
359 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
360 call tui_show_locator_content.
361 (tui_gen_win_info::resize): Call rerender.
362 (show_source_or_disasm_and_command): Don't call
363 tui_show_locator_content.
364 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
365 method.
366 (struct tui_win_info) <rerender>: Declare.
367 <set_new_height, make_invisible_and_set_new_height,
368 make_visible_with_new_height>: Don't declare.
369 * tui/tui-data.c (tui_win_list::rerender): New method.
370 * tui/tui-command.h (struct tui_cmd_window)
371 <do_make_visible_with_new_height>: Don't declare.
372 * tui/tui-command.c
373 (tui_cmd_window::do_make_visible_with_new_height): Remove.
374
272560b5
TT
3752019-08-15 Tom Tromey <tromey@adacore.com>
376
377 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
378 * ada-lang.c (ada_enum_name): Likewise.
379
08235187
CB
3802019-08-15 Christian Biesinger <cbiesinger@google.com>
381
382 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
383 leading underscore.
384 (GdbOutputErrorFile): Likewise.
385 (global scope): Adjust constructor calls to GdbOutput{,Error}File
386 accordingly.
387 (execute_unwinders): Rename to have a leading underscore.
388 (auto_load_packages): Likewise.
389 (global scope): Adjust call to auto_load_packages accordingly.
390 (GdbSetPythonDirectory): Likewise.
391 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
392 instead of execute_unwinders.
393
db502012
TT
3942019-08-15 Tom Tromey <tom@tromey.com>
395
396 * tui/tui-layout.c (show_layout, show_source_disasm_command)
397 (show_data): Don't change window visibility.
398 (tui_gen_win_info::resize): Remove special case for command
399 window. Use wresize, when available.
400 (show_source_or_disasm_and_command): Don't change window
401 visibility.
402 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
403 <make_visible>: New method.
404 * tui/tui-command.c (tui_cmd_window::resize): New method.
405
3891b65e
TT
4062019-08-15 Tom Tromey <tom@tromey.com>
407
408 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
409 (struct tui_source_windows): New.
410 * tui/tui-winsource.c (tui_display_main): Update.
411 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
412 (new_height_ok, parse_scrolling_args): Update.
413 * tui/tui-layout.c (show_layout, show_data): Update.
414 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
415 (tui_add_to_source_windows): Don't declare.
416 * tui/tui-data.c (source_windows, tui_source_windows)
417 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
418
ee556432
TT
4192019-08-15 Tom Tromey <tom@tromey.com>
420
421 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
422 Rename from reset.
423 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
424 * tui/tui-layout.c (show_source_disasm_command, show_data):
425 Update.
426 (tui_gen_win_info::resize): Rename.
427 (show_source_or_disasm_and_command): Update.
428 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
429 reset.
430
46f438e3
TT
4312019-08-15 Tom Tromey <tom@tromey.com>
432
433 * tui/tui-stack.c (tui_initialize_static_data): Remove.
434 * tui/tui-interp.c (tui_interp::init): Don't call
435 tui_initialize_static_data.
436 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
437
f4ce562c
TT
4382019-08-15 Tom Tromey <tom@tromey.com>
439
440 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
441 examine tui_win_list.
442
c398c3d0
TT
4432019-08-15 Tom Tromey <tom@tromey.com>
444
445 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
446 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
447 tui_clear_source_content.
448 (tui_clear_source_content): Remove.
449 (tui_source_window_base::do_erase_source_content): Hoist call to
450 content.clear().
451 * tui/tui-stack.c (tui_show_frame_info): Don't call
452 tui_clear_source_content.
453
e25d2004
TT
4542019-08-15 Tom Tromey <tom@tromey.com>
455
456 * tui/tui-winsource.h (struct tui_source_window_base)
457 <do_erase_source_content>: New method.
458 <erase_source_content>: New method.
459 (tui_erase_source_content): Don't declare.
460 * tui/tui-winsource.c (tui_clear_source_content): Update.
461 (tui_source_window_base::do_erase_source_content): Rename from
462 tui_erase_source_content.
463 (tui_source_window_base::show_source_content): Update.
464 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
465 * tui/tui-source.h (struct tui_source_window)
466 <erase_source_content>: New method.
467 * tui/tui-disasm.h (struct tui_disasm_window)
468 <erase_source_content>: New method.
469
002f15c2
TT
4702019-08-15 Tom Tromey <tom@tromey.com>
471
472 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
473 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
474 constructor.
475 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
476 * tui/tui-source.c (tui_set_source_content): Update.
477 * tui/tui-disasm.c (tui_set_disassem_content): Update.
478
c9033fe8
TT
4792019-08-15 Tom Tromey <tom@tromey.com>
480
481 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
482 * tui/tui-winsource.c (tui_line_is_displayed): Move to
483 tui-source.c.
484 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
485 Declare.
486 * tui/tui-source.c (tui_source_window::line_is_displayed): New
487 method.
488 (tui_source_window::maybe_update): Update.
489
088f37dd
TT
4902019-08-15 Tom Tromey <tom@tromey.com>
491
492 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
493 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
494 tui-disasm.c.
495 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
496 Declare.
497 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
498 method.
499 (tui_disasm_window::maybe_update): Update.
500
a54700c6
TT
5012019-08-15 Tom Tromey <tom@tromey.com>
502
503 * tui/tui-winsource.h (struct tui_source_window_base)
504 <maybe_update>: Declare.
505 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
506 method.
507 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
508 Declare.
509 * tui/tui-source.c (tui_source_window::maybe_update): New method.
510 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
511 Declare.
512 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
513
e2a678a5
TT
5142019-08-15 Tom Tromey <tom@tromey.com>
515
516 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
517
f2dda477
TT
5182019-08-15 Tom Tromey <tom@tromey.com>
519
520 * tui/tui-wingeneral.c: Include tui-stack.h.
521 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
522 (struct tui_locator_window): Move from tui-data.h.
523 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
524 (tui_initialize_static_data): Move from tui-data.c.
525 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
526 (struct tui_locator_window): Move to tui-stack.c.
527 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
528 (tui_initialize_static_data): Move to tui-stack.c.
529
ed4a1084
TT
5302019-08-15 Tom Tromey <tom@tromey.com>
531
532 * tui/tui-layout.c (show_source_disasm_command)
533 (show_source_or_disasm_and_command): Use make_visible method, not
534 tui_make_window.
535 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
536 Remove.
537
65962b20
TT
5382019-08-15 Tom Tromey <tom@tromey.com>
539
540 * tui/tui-wingeneral.h (tui_make_window): Update.
541 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
542 parameter.
543 (tui_gen_win_info::make_visible): Update.
544 * tui/tui-regs.c (tui_data_window::display_registers_from):
545 Update.
546 * tui/tui-layout.c (show_source_disasm_command)
547 (show_source_or_disasm_and_command): Update.
548 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
549 (enum tui_box): Remove.
550 (struct tui_win_info) <can_box>: New method.
551 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
552 method.
553
2208ee91
TV
5542019-08-15 Tom de Vries <tdevries@suse.de>
555
556 * linux-nat-trad.c: Include gdbarch.h.
557
75faf5c4
AH
5582019-08-14 Alan Hayward <alan.hayward@arm.com>
559
560 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
561 register sizes.
562
b1c896b3
TT
5632019-08-14 Tom Tromey <tromey@adacore.com>
564
565 * darwin-nat.c: Include gdbarch.h.
566 * darwin-nat-info.c: Include gdbarch.h.
567
6405cd73
TT
5682019-08-13 Tom Tromey <tom@tromey.com>
569
570 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
571 Remove.
572 * tui/tui-data.c (tui_initialize_static_data): Update.
573
5216580d
TT
5742019-08-13 Tom Tromey <tom@tromey.com>
575
576 * tui/tui-winsource.h (struct tui_exec_info_window)
577 <~tui_exec_info_window, maybe_allocate_content, get_content,
578 m_content>: Remove.
579 (struct tui_source_window_base) <set_exec_info_content,
580 show_exec_info_content>: Don't declare.
581 * tui/tui-winsource.c
582 (tui_exec_info_window::maybe_allocate_content): Remove.
583 (tui_source_window_base::update_exec_info): Rename from
584 set_exec_info_content.
585 (tui_source_window_base::show_exec_info_content)
586 (tui_source_window_base::update_exec_info): Remove.
587
93858ad3
TT
5882019-08-13 Tom Tromey <tom@tromey.com>
589
590 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
591 declare.
592 * tui/tui-winsource.c (tui_update_source_window_as_is)
593 (tui_update_source_windows_with_addr, tui_erase_source_content):
594 Update.
595 (tui_clear_exec_info_content): Remove.
596
e321e7ce
TT
5972019-08-13 Tom Tromey <tom@tromey.com>
598
599 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
600 declare.
601 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
602 call tui_erase_exec_info_content.
603 (tui_clear_exec_info_content): Rename from
604 tui_erase_exec_info_content.
605 (tui_clear_exec_info_content): Delete.
606
8270ac62
TT
6072019-08-13 Tom Tromey <tom@tromey.com>
608
609 * tui/tui-winsource.h (struct tui_source_window_base)
610 <show_exec_info_content>: Declare.
611 (tui_show_exec_info_content): Don't declare.
612 * tui/tui-winsource.c
613 (tui_source_window_base::show_exec_info_content): Rename from
614 tui_show_exec_info_content.
615 (tui_source_window_base::update_exec_info): Update.
616
7b56485d
TT
6172019-08-13 Tom Tromey <tom@tromey.com>
618
619 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
620 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
621 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
622 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
623 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
624 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
625 ... here.
626
7ba913dc
TT
6272019-08-13 Tom Tromey <tom@tromey.com>
628
629 * tui/tui-winsource.h (struct tui_source_window_base)
630 <update_exec_info>: Declare.
631 (tui_update_exec_info): Don't declare.
632 * tui/tui-winsource.c (tui_update_source_window_as_is)
633 (tui_source_window_base::refresh_all)
634 (tui_update_all_breakpoint_info): Update.
635 (tui_source_window_base::update_exec_info): Rename from
636 tui_update_exec_info.
637 * tui/tui-stack.c (tui_show_frame_info): Update.
638
37a4a131
TT
6392019-08-13 Tom Tromey <tom@tromey.com>
640
641 * tui/tui-winsource.h (struct tui_source_window_base)
642 <set_exec_info_content>: Declare.
643 (tui_set_exec_info_content): Don't declare.
644 * tui/tui-winsource.c
645 (tui_source_window_base::set_exec_info_content): Rename from
646 tui_set_exec_info_content.
647 (tui_update_exec_info): Update.
648
0bd27e07
TT
6492019-08-13 Tom Tromey <tom@tromey.com>
650
651 * tui/tui-winsource.h (struct tui_source_window_base)
652 <show_source_content>: Declare.
653 (tui_show_source_content): Don't declare.
654 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
655 (tui_source_window_base::show_source_content): Rename from
656 tui_show_source_content.
657 (tui_source_window_base::refresh_all): Update.
658 * tui/tui-layout.c (show_source_disasm_command)
659 (show_source_or_disasm_and_command): Update.
660
b4ef5aeb
TT
6612019-08-13 Tom Tromey <tom@tromey.com>
662
663 * tui/tui-winsource.c (tui_erase_source_content)
664 (tui_show_source_content, tui_source_window_base::refresh_all):
665 Update.
666 * tui/tui-wingeneral.h
667 (tui_check_and_display_highlight_if_needed): Don't declare.
668 * tui/tui-wingeneral.c
669 (tui_win_info::check_and_display_highlight_if_needed): Rename from
670 check_and_display_highlight_if_needed.
671 * tui/tui-win.c (tui_rehighlight_all)
672 (tui_win_info::make_visible_with_new_height): Update.
673 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
674 (tui_data_window::erase_data_content)
675 (tui_data_window::display_all_data): Update.
676 * tui/tui-data.h (struct tui_win_info)
677 <check_and_display_highlight_if_needed>: Declare.
678
fede5273
TT
6792019-08-13 Tom Tromey <tom@tromey.com>
680
681 * tui/tui-win.c (tui_resize_all): Call
682 tui_delete_invisible_windows.
683 * tui/tui-layout.c (show_layout): Call
684 tui_delete_invisible_windows.
685 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
686 * tui/tui-data.c (tui_delete_invisible_windows): New function.
687
22c3f490
TT
6882019-08-13 Tom Tromey <tom@tromey.com>
689
690 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
691 tui_add_win_to_layout.
692
16cb7910
TT
6932019-08-13 Tom Tromey <tom@tromey.com>
694
695 * tui/tui-layout.h (tui_default_win_height): Don't declare.
696 * tui/tui-layout.c (tui_default_win_height): Now static.
697
cc0c3ffb
TT
6982019-08-13 Tom Tromey <tom@tromey.com>
699
700 * tui/tui-layout.c (show_layout): Unify all layout cases into a
701 single switch.
702 (show_source_disasm_command, show_source_or_disasm_and_command):
703 Don't check current layout.
704
3f3ffe54
TT
7052019-08-13 Tom Tromey <tom@tromey.com>
706
707 * tui/tui-wingeneral.c (make_all_visible): Remove.
708 (tui_make_all_invisible): Simplify.
709 * tui/tui-layout.c (tui_make_all_invisible): Move from
710 tui-wingeneral.c; simplify.
711 (show_layout): Hoist call to tui_make_all_invisible.
712 (show_data): Don't call tui_make_all_invisible.
713
69258091
TT
7142019-08-13 Tom Tromey <tom@tromey.com>
715
716 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
717 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
718
62cf57fe
TT
7192019-08-13 Tom Tromey <tom@tromey.com>
720
721 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
722 tui-data.c.
723 (show_source_disasm_command, show_data)
724 (show_source_or_disasm_and_command): Don't use
725 tui_set_current_layout_to.
726 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
727 * tui/tui-data.c (current_layout, tui_current_layout): Move to
728 tui-layout.c.
729 (tui_set_current_layout_to): Remove.
730
2afade5d
TT
7312019-08-13 Tom Tromey <tom@tromey.com>
732
733 * tui/tui-layout.c (tui_set_layout): Update.
734 * tui/tui-data.h (struct tui_layout_def): Remove.
735 (tui_layout_def): Don't declare.
736 * tui/tui-data.c (layout_def): Remove.
737 (tui_layout_def): Remove.
738
a3504e96
TT
7392019-08-13 Tom Tromey <tom@tromey.com>
740
741 * tui/tui-winsource.h (struct tui_source_window_base)
742 <clear_detail>: No longer "override".
743 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
744 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
745 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
746 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
747 Remove.
748 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
749
29c92911
TT
7502019-08-13 Tom Tromey <tromey@adacore.com>
751
752 * tracepoint.c: Don't include readline.h or history.h.
753
86c6b807
TT
7542019-08-12 Tom Tromey <tom@tromey.com>
755
756 * configure: Rebuild.
757 * configure.ac: Check for readline 7.
758 * NEWS: Mention readline 7 requirement.
759 * README: Update.
760
5db2718c
TT
7612019-08-12 Tom Tromey <tom@tromey.com>
762
763 * mingw-hdep.c (gdb_select): Remove readline hack.
764
dac36daf
PFC
7652019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
766
767 * blockframe.c (find_pc_partial_function): Set *block to nullptr
768 when the function fails.
769
1022c627
AA
7702019-08-09 Andreas Arnez <arnez@linux.ibm.com>
771
772 * s390-tdep.c (s390_type_align): New function.
773 (s390_gdbarch_init): Set it as type_align gdbarch method.
774
eba4caf2
TV
7752019-08-09 Tom de Vries <tdevries@suse.de>
776
777 PR gdb/24591
778 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
779 pc_low with relocation offset.
780
123cd851
TT
7812019-08-07 Tom Tromey <tromey@adacore.com>
782
783 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
784 (print_frame_args): Update.
785 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
786 Update.
787 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
788 * frame.h (struct frame_arg): Add initializers.
789 <error>: Now a unique_xmalloc_ptr.
790
3d31bc39
AH
7912019-08-07 Alan Hayward <alan.hayward@arm.com>
792
793 * NEWS: Expand the Pointer Authentication entry.
794 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
795 (aarch64_frame_unmask_lr): ... to this.
796 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
797 Call aarch64_frame_unmask_lr.
798 * frame.c (struct frame_info): Add "masked" variable.
799 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
800 (fprint_frame): Check for masked pc.
801 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
802 declarations.
803 * python/py-framefilter.c (py_print_frame): Check for masked pc.
804 * stack.c (print_frame): Check for masked pc.
805
0cf9feb9
TT
8062019-08-06 Tom Tromey <tom@tromey.com>
807
808 * stabsread.c (patch_block_stabs, read_one_struct_field)
809 (read_enum_type): Use obstack_strndup.
810 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
811 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
812 * dwarf2read.c (guess_full_die_structure_name)
813 (anonymous_struct_prefix): Use obstack_strndup.
814 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
815 * c-exp.y (yylex): Use obstack_strndup.
816 * ada-exp.y (write_object_renaming, write_ambiguous_var)
817 (write_var_or_type): Use obstack_strndup.
818
efba19b0
TT
8192019-08-06 Tom Tromey <tom@tromey.com>
820
821 * symfile.c (reread_symbols): Use obstack_strdup.
822 * stabsread.c (read_type): Use obstack_strdup.
823 * gdb_obstack.h (obstack_strdup): New overload.
824 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
825 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
826 (dwarf2_canonicalize_name): Use obstack_strdup.
827 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
828 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
829 Use obstack_strdup.
830
f25102f7
TT
8312019-08-06 Tom Tromey <tom@tromey.com>
832
833 * gdb_obstack.h (obstack_strdup): Define.
834 * gdb_obstack.c (obstack_strdup): Don't define.
835
021887d8
TT
8362019-08-06 Tom Tromey <tom@tromey.com>
837
838 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
839 obstack_strdup.
840 * typeprint.c (typedef_hash_table::find_global_typedef): Use
841 obstack_strdup.
842 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
843 * stabsread.c (common_block_start): Use obstack_strdup.
844 * objfiles.c (set_objfile_main_name, objfile): Use
845 obstack_strdup.
846 * namespace.c (add_using_directive): Use obstack_strdup.
847 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
848 * jit.c (finalize_symtab): Use obstack_strdup.
849 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
850 (guess_partial_die_structure_name, partial_die_info::fixup)
851 (dwarf2_name): Use obstack_strdup.
852 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
853 obstack_strdup.
854 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
855 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
856 obstack_strdup.
857 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
858
d2834edc
PW
8592019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
860
861 * unittests/help-doc-selftests.c: New file.
862 * Makefile.in: Add the new file.
863
590042fc
PW
8642019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
865
866 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
867 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
868 the full first line, except when FOR_VALUE_PREFIX. In this case,
869 the trailing '.' is not output, and the first character is uppercased.
870 (print_help_for_command): Update call to print_doc_line.
871 (print_doc_of_command): Likewise.
872 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
873 * cli/cli-option.c (append_indented_doc): Do not append newline.
874 (build_help_option): Append newline after first appended_indented_doc
875 only if a second call is done.
876 (build_help): Append 2 new lines before each option, except the first
877 one.
878 * compile/compile.c (_initialize_compile): Add new lines after
879 %OPTIONS%, when not at the end of the help.
880 Change help doc or code
881 producing the help doc to respect the invariants.
882 * maint-test-options.c (_initialize_maint_test_options): Likewise.
883 Also removed the new line after 'Options:', as all other commands
884 do not put an empty line between 'Options:' and the first option.
885 * printcmd.c (_initialize_printcmd): Likewise.
886 * stack.c (_initialize_stack): Likewise.
887 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
888 incorrectly telling COMMAND is optional.
889 * ada-lang.c (_initialize_ada_language): Change help doc or code
890 producing the help doc to respect the invariants.
891 * ada-tasks.c (_initialize_ada_tasks): Likewise.
892 * breakpoint.c (_initialize_breakpoint): Likewise.
893 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
894 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
895 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
896 * cli/cli-style.c (cli_style_option::add_setshow_commands,
897 _initialize_cli_style): Likewise.
898 * corelow.c (core_target_info): Likewise.
899 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
900 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
901 * filesystem.c (_initialize_filesystem): Likewise.
902 * frame.c (_initialize_frame): Likewise.
903 * gnu-nat.c (add_task_commands): Likewise.
904 * infcall.c (_initialize_infcall): Likewise.
905 * infcmd.c (_initialize_infcmd): Likewise.
906 * interps.c (_initialize_interpreter): Likewise.
907 * language.c (_initialize_language): Likewise.
908 * linux-fork.c (_initialize_linux_fork): Likewise.
909 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
910 * maint.c (_initialize_maint_cmds): Likewise.
911 * memattr.c (_initialize_mem): Likewise.
912 * printcmd.c (_initialize_printcmd): Likewise.
913 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
914 _RegEx): Likewise.
915 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
916 * record-btrace.c (_initialize_record_btrace): Likewise.
917 * record-full.c (_initialize_record_full): Likewise.
918 * record.c (_initialize_record): Likewise.
919 * regcache-dump.c (_initialize_regcache_dump): Likewise.
920 * regcache.c (_initialize_regcache): Likewise.
921 * remote.c (add_packet_config_cmd, init_remote_threadtests,
922 _initialize_remote): Likewise.
923 * ser-tcp.c (_initialize_ser_tcp): Likewise.
924 * serial.c (_initialize_serial): Likewise.
925 * skip.c (_initialize_step_skip): Likewise.
926 * source.c (_initialize_source): Likewise.
927 * stack.c (_initialize_stack): Likewise.
928 * symfile.c (_initialize_symfile): Likewise.
929 * symtab.c (_initialize_symtab): Likewise.
930 * target-descriptions.c (_initialize_target_descriptions): Likewise.
931 * top.c (init_main): Likewise.
932 * tracefile-tfile.c (tfile_target_info): Likewise.
933 * tracepoint.c (_initialize_tracepoint): Likewise.
934 * tui/tui-win.c (_initialize_tui_win): Likewise.
935 * utils.c (add_internal_problem_command): Likewise.
936 * valprint.c (value_print_option_defs): Likewise.
937
404f2902
FCE
9382019-08-06 Frank Ch. Eigler <fche@redhat.com>
939
940 PR build/24886
941 * configure.ac: Drop enable-libmcheck support.
942 * configure, config.in: Rebuild.
943 * libmcheck.m4: Remove.
944 * acinclude.m4: Don't include it.
945 * Makefile.in: Don't distribute it.
946 * top.c (print_gdb_configuration): Don't mention it.
947
046bebe1
TT
9482019-08-06 Tom Tromey <tom@tromey.com>
949
950 * utils.c (set_output_style): Sometimes pass stream to
951 emit_style_escape.
952 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
953 * record-btrace.c (btrace_insn_history): Update.
954 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
955 method.
956 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
957 Update initializers.
958 <m_uiout>: New field.
959 <m_di>: Move lower.
960 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
961 Remove "uiout" parameter.
962 (dump_insns): Update.
963 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
964 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
965
ddbcedf5
CB
9662019-08-06 Christian Biesinger <cbiesinger@google.com>
967
968 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
969 (error_in_psymtab_expansion): Likewise.
970 (lookup_symbol_via_quick_fns): Likewise.
971 (basic_lookup_transparent_type_quick): Likewise.
972 (basic_lookup_transparent_type_1): Likewise.
973
b08b16c8
TT
9742019-08-06 Tom Tromey <tromey@adacore.com>
975
976 * source.c (last_source_error): Now bool.
977 (print_source_lines_base): Make "noprint" bool. Only open
978 source file when last_source_visited changes.
979
cb44333d
TT
9802019-08-06 Tom Tromey <tromey@adacore.com>
981
982 * annotate.c (annotate_source_line): Use g_source_cache.
983 * source-cache.c (source_cache::get_plain_source_lines): Change
984 parameters. Populate m_offset_cache.
985 (source_cache::ensure): New method.
986 (source_cache::get_line_charpos): New method.
987 (extract_lines): Move lower. Change parameters.
988 (source_cache::get_source_lines): Move lower.
989 * source-cache.h (class source_cache): Update comment.
990 <get_line_charpos>: New method.
991 <get_source_lines>: Update comment.
992 <clear>: Clear m_offset_cache.
993 <get_plain_source_lines>: Change parameters.
994 <ensure>: New method
995 <m_offset_cache>: New member.
996 * source.c (forget_cached_source_info_for_objfile): Update.
997 (info_source_command): Use g_source_cache.
998 (find_source_lines, open_source_file_with_line_charpos): Remove.
999 (print_source_lines_base, search_command_helper): Use g_source_cache.
1000 * source.h (open_source_file_with_line_charpos): Don't declare.
1001 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1002 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1003 Use g_source_cache.
1004
872dceaa
TT
10052019-08-06 Tom Tromey <tromey@adacore.com>
1006
1007 * source-cache.c (source_cache::get_plain_source_lines):
1008 Remove "first_line" and "last_line" parameters.
1009 (source_cache::get_source_lines): Cache plain text.
1010 * source-cache.h (class source_cache)
1011 <get_plain_source_lines>: Update.
1012
269249d9
TT
10132019-08-06 Tom Tromey <tromey@adacore.com>
1014
1015 * source-cache.c (extract_lines): No longer a method.
1016 Changed type of parameter. Include final newline.
1017 (selftests::extract_lines_test): New function.
1018 (_initialize_source_cache): Likewise.
1019 * source-cache.h (class source_cache)
1020 <extract_lines>: Don't declare.
1021
c0e8dcd8
TT
10222019-08-06 Tom Tromey <tromey@adacore.com>
1023
1024 * breakpoint.c (init_breakpoint_sal): Update.
1025 (breakpoint): Update.
1026 * breakpoint.h (struct breakpoint) <filter>: Now a
1027 unique_xmalloc_ptr.
1028
0b27c27d
CB
10292019-08-05 Christian Biesinger <cbiesinger@google.com>
1030
1031 * NEWS: Mention dictionary access on blocks.
1032 * python/py-block.c (blpy_getitem): New function.
1033 (block_object_as_mapping): New struct.
1034 (block_object_type): Use new struct for tp_as_mapping field.
1035
4ee94178
CB
10362019-08-05 Christian Biesinger <cbiesinger@google.com>
1037
1038 * objfiles.h (objfile): Add a comment describing partial symbols.
1039
8abfcabc
TT
10402019-08-05 Tom Tromey <tromey@adacore.com>
1041
1042 * compile/compile.c (_initialize_compile): Use _(), not N_().
1043 * thread.c (_initialize_thread): Use _(), not N_().
1044 * stack.c (_initialize_stack): Use _(), not N_().
1045 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1046
2b79f376
SM
10472019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1048
1049 * dwarf2read.c (struct dw2_symtab_iterator):
1050 <want_specific_block>: Remove.
1051 <block_index>: Change type to gdb::optional.
1052 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1053 change type of BLOCK_INDEX parameter to gdb::optional.
1054 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1055 (dw2_lookup_symbol): Don't pass argument for
1056 WANT_SPECIFIC_BLOCK.
1057 (dw2_expand_symtabs_for_function): Don't pass argument for
1058 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1059 (class dw2_debug_names_iterator)
1060 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1061 parameter, change BLOCK_INDEX type to gdb::optional.
1062 <m_want_specific_block>: Remove.
1063 <m_block_index>: Change type to gdb::optional.
1064 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1065 gdb::optional. Re-write in function of gdb::optional.
1066 (dw2_debug_names_lookup_symbol): Don't pass argument for
1067 WANT_SPECIFIC_BLOCK.
1068 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1069 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1070 BLOCK_INDEX.
1071
ae60f04e
PW
10722019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1073
1074 * NEWS: Mention changes to "info sources" command.
1075
28cd9371
PW
10762019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1077
1078 * symtab.c (filename_partial_match_opts): New struct type.
1079 (struct output_source_filename_data): New members
1080 regexp, c_regexp, partial_match.
1081 (output_source_filename): Use new members to decide to print file.
1082 (info_sources_option_defs): New variable.
1083 (make_info_sources_options_def_group, print_info_sources_header,
1084 info_sources_command_completer):
1085 New functions.
1086 (info_sources_command): Read new optional arguments.
1087 (_initialize_symtab): Update info sources help.
1088
ca683e3a
AO
10892019-08-02 Alexandre Oliva <oliva@adacore.com>
1090
1091 * ada-lang.c (exception_support_info_v0): Renamed from...
1092 (default_exception_support_info): ... this. Create new
1093 definition for v1.
1094 (ada_has_this_exception_support): Look up catch_handlers_sym.
1095 (ada_exception_support_info_sniffer): Try v0 after default.
1096
f1264162
TT
10972019-08-01 Tom Tromey <tromey@adacore.com>
1098
1099 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1100 gdbarch.h.
1101
0a7b2485
CB
11022019-08-01 Christian Biesinger <cbiesinger@google.com>
1103
1104 * s12z-tdep.c: Fix include path for s12z-opc.h.
1105
c6bdbeb7
AH
11062019-08-01 Alan Hayward <alan.hayward@arm.com>
1107
1108 * NEWS: Require GNU make 3.82.
1109
a2bd7b82
TT
11102019-07-16 Tom Tromey <tom@tromey.com>
1111
1112 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1113 declare.
1114
aa3b6533
TT
11152019-07-30 Tom Tromey <tromey@adacore.com>
1116
1117 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1118
a1530dc7
KB
11192019-07-30 Kevin Buettner <kevinb@redhat.com>
1120
1121 * printcmd.c (print_address_symbolic): Print negative offsets.
1122 (build_address_symbolic): Force signed arithmetic when computing
1123 offset.
1124
2906593f
CB
11252019-07-30 Christian Biesinger <cbiesinger@google.com>
1126
1127 PR/24474: Add a function to lookup static variables.
1128 * NEWS: Mention this new function.
1129 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1130 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1131 * python/python.c (python_GdbMethods): Add new function.
1132
c620ed88
CB
11332019-07-29 Christian Biesinger <cbiesinger@google.com>
1134
1135 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1136 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1137 (objfpy_lookup_static_symbol): New function.
1138 (objfile_object_methods): Add new functions.
1139
bc4268a5
PW
11402019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1141
1142 * NEWS: Mention 'set|show print frame-info'. Mention new
1143 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1144 backtrace argument. Mention that python frame filtering code
1145 is now consistent with what 'backtrace' command prints.
1146
4b5e8d19
PW
11472019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1148
1149 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1150 comments.
1151 (print_frame_info_auto, print_frame_info_source_line,
1152 print_frame_info_location, print_frame_info_source_and_location,
1153 print_frame_info_location_and_address, print_frame_info_short_location):
1154 New declarations.
1155 (struct frame_print_options): New member print_frame_info.
1156 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1157 * stack.h (get_user_print_what_frame_info): New declaration.
1158 (frame_show_address): New declaration.
1159 * stack.c (print_frame_arguments_choices): New value 'presence'.
1160 (print_frame_info_auto, print_frame_info_source_line,
1161 print_frame_info_location, print_frame_info_source_and_location,
1162 print_frame_info_location_and_address, print_frame_info_short_location,
1163 print_frame_info_choices, print_frame_info_print_what): New definitions.
1164 (print_frame_args): Only print dots for args if print frame-arguments
1165 is 'presence'.
1166 (frame_print_option_defs): New element for "frame-info".
1167 (get_user_print_what_frame_info): New function.
1168 (frame_show_address): Make non static. Move comment to stack.h.
1169 (print_frame_info_to_print_what): New function.
1170 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1171 to decide what to print.
1172 (backtrace_command_1): Handle the new print_frame_arguments_presence
1173 value.
1174 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1175 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1176 (py_print_frame): In non-mi mode, use LOCATION as default for
1177 print_what, similarly to frame information printed directly by
1178 backtrace command. Handle frame-info user option in non MI mode.
1179
6bdfee81
KB
11802019-07-27 Kevin Buettner <kevinb@redhat.com>
1181
1182 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1183 Add case for debugging 32-bit target on 64-bit host. Revise
1184 comment.
1185
98a617f8
KB
11862019-07-27 Kevin Buettner <kevinb@redhat.com>
1187
1188 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1189 instead of find_function_entry_range_from_pc.
1190
567238c9
KB
11912019-07-27 Kevin Buettner <kevinb@redhat.com>
1192
1193 * stack.c (find_frame_funname): Remove code which preferred
1194 minsym over symtab sym in "certain pathological cases".
1195
2dc80cf8
KB
1196 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1197 parameter. Change type of "do_demangle" to bool.
1198 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1199 Pass suitable "prefer_sym_over_minsym" flag to
1200 build_address_symbolic(). Don't output "+" for negative offsets.
1201 * printcmd.c (print_address_symbolic): Update invocation of
1202 build_address_symbolic to include a "prefer_sym_over_minsym"
1203 flag.
1204 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1205 Restrict cases in which use of minimal symbol is preferred to that
1206 of a found symbol. Update comments.
1207
1aff7173
KB
1208 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1209 for entry pc when entry pc is out of range for that FDE.
1210
89b085ac
BC
12112019-07-26 Brian Callahan <bcallah@openbsd.org>
1212
1213 PR gdb/24839:
1214 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1215 type.
1216
f32feb4a
CB
12172019-07-25 Christian Biesinger <cbiesinger@google.com>
1218
1219 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1220 this function's Python signature.
1221
1222
12232019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1224
1225 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1226 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1227 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1228 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1229 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1230
1231
c54e4253
YS
12322019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1233
1234 * h8300-tdep.c (h8300_register_name_common): New.
1235 h8300_register_name): Use h8300_register_name_common.
1236 (h8300s_register_name): Likewise.
1237 (h8300sx_register_name): Likewise.
1238 (h8300h_register_nam): New.
1239 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1240
1241
40eadf04
SP
12422019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1243
1244 * arm-tdep.c (arm_skip_cmse_entry): New function.
1245 (arm_is_sgstubs_section): New function.
1246 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1247
bfa2a36d
TT
12482019-07-22 Tom Tromey <tom@tromey.com>
1249
1250 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1251 Don't self-assign.
1252
a8e9d247
AB
12532019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1254
1255 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1256 type_print.
1257
eb86c5e2
AB
12582019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1259
1260 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1261 so that GDB doesn't match any msymbols when searching in the
1262 TYPES_DOMAIN.
1263 (print_symbol_info): Print using typedef_print or type_print based
1264 on the type of the symbol. Add updated FIXME comment moved from...
1265 (_initialize_symtab): ... move and update FIXME comment to above.
1266
a8eab7c6
AB
12672019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1268
1269 * NEWS: Mention adding -q option to "info types".
1270 * symtab.c (struct info_types_options): New struct.
1271 (info_types_options_defs): New variable.
1272 (make_info_types_options_def_group): New function.
1273 (info_types_command): Use gdb::option framework to parse options.
1274 (info_types_command_completer): New function.
1275 (_initialize_symtab): Extend the help text on "info types" and
1276 register command completer.
1277
b4603c34
CB
12782019-07-21 Christian Biesinger <cbiesinger@google.com>
1279
1280 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1281 (lookup_symbol_in_objfile): Change int to block_enum and add a
1282 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1283
c8cdc1e0
CB
12842019-07-20 Christian Biesinger <cbiesinger@google.com>
1285
1286 * MAINTAINERS (Write After Approval): Add self.
1287
01e175fe
AB
12882019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1289
1290 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1291 instruction to the dummy code region.
1292
56f79b63
TT
12932019-07-19 Tom Tromey <tromey@adacore.com>
1294
1295 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1296 (ARGSUSED, PARAMS, __func__): Remove rules.
1297
4c5aa8e0
AH
12982019-07-19 Alan Hayward <alan.hayward@arm.com>
1299
1300 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1301 * features/arm/arm-with-iwmmxt.c: Remove.
1302 * features/arm/arm-with-iwmmxt.xml: Remove.
1303 * features/arm/arm-with-m-fpa-layout.c: Remove.
1304 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1305 * features/arm/arm-with-m-vfp-d16.c: Remove.
1306 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1307 * features/arm/arm-with-m.c: Remove.
1308 * features/arm/arm-with-m.xml: Remove.
1309 * features/arm/arm-with-neon.c: Remove.
1310 * features/arm/arm-with-neon.xml: Remove.
1311 * features/arm/arm-with-vfpv2.c: Remove.
1312 * features/arm/arm-with-vfpv2.xml: Remove.
1313 * features/arm/arm-with-vfpv3.c: Remove.
1314 * features/arm/arm-with-vfpv3.xml: Remove.
1315
f42b2617
AH
13162019-07-19 Alan Hayward <alan.hayward@arm.com>
1317
1318 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1319
f29ec966
AH
13202019-07-19 Alan Hayward <alan.hayward@arm.com>
1321
1322 * arch/aarch32.c (aarch32_create_target_description): Create
1323 target descriptions using features.
1324 * arch/arm.c (arm_create_target_description)
1325 (arm_create_mprofile_target_description): Likewise.
1326 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1327
d105cce5
AH
13282019-07-19 Alan Hayward <alan.hayward@arm.com>
1329
1330 * Makefile.in: Add new files.
1331 * aarch32-tdep.c: New file.
1332 * aarch32-tdep.h: New file.
1333 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1334 Call aarch32_read_description.
1335 * arch/aarch32.c: New file.
1336 * arch/aarch32.h: New file.
1337 * arch/arm.c (arm_create_target_description)
1338 (arm_create_mprofile_target_description): New function.
1339 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1340 (arm_create_target_description)
1341 (arm_create_mprofile_target_description): New declaration.
1342 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1343 read_description functions.
1344 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1345 Likewise.
1346 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1347 * arm-tdep.c (tdesc_arm_list): New variable.
1348 (arm_register_g_packet_guesses): Call create description functions.
1349 (arm_read_description) (arm_read_mprofile_description): New
1350 function.
1351 * arm-tdep.h (arm_read_description)
1352 (arm_read_mprofile_description): Add declaration.
1353 * configure.tgt: Add new files.
1354
afe09f0b
GL
13552019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1356
1357 * top.c (new_ui_command): Open specified terminal just once.
1358
cd215b2e
TT
13592019-07-18 Tom Tromey <tromey@adacore.com>
1360
1361 * symtab.c (main_name): Constify return type.
1362 * symfile.c (set_initial_language): Update.
1363 * symtab.h (main_name): Constify return type.
1364
d8f68fcb
TT
13652019-07-17 Tom Tromey <tom@tromey.com>
1366
1367 * tui/tui-winsource.c (tui_update_source_window)
1368 (tui_update_source_window_as_is)
1369 (tui_update_source_windows_with_line): Remove return.
1370 * tui/tui-disasm.c (tui_show_disassem)
1371 (tui_show_disassem_and_update_source): Remove return.
1372 * tui/tui.c (tui_reset): Remove return.
1373 * tui/tui-wingeneral.c
1374 (tui_check_and_display_highlight_if_needed): Remove return.
1375
ca5af91e
TT
13762019-07-17 Tom Tromey <tom@tromey.com>
1377
1378 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1379
5104fe36
TT
13802019-07-17 Tom Tromey <tom@tromey.com>
1381
1382 * tui/tui-winsource.h (struct tui_exec_info_window)
1383 (struct tui_source_window_base): Move from tui-data.h.
1384 * tui/tui-winsource.c: Move many method definitions from
1385 elsewhere. Remove "structuring" comments.
1386 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1387 (tui_source_window_base::refresh_window): Move to
1388 tui-winsource.c.
1389 * tui/tui-win.c (tui_source_window_base::refresh_all)
1390 (tui_source_window_base::update_tab_width)
1391 (tui_source_window_base::set_new_height)
1392 (tui_source_window_base::do_make_visible_with_new_height): Move to
1393 tui-winsource.c.
1394 * tui/tui-source.h: Update.
1395 * tui/tui-source.c (tui_source_window_base::reset): Move to
1396 tui-winsource.c.
1397 * tui/tui-disasm.h: Update.
1398 * tui/tui-data.h (struct tui_exec_info_window): Move to
1399 tui-winsource.h.
1400 (struct tui_source_window_base): Likewise.
1401 * tui/tui-data.c (tui_source_window_base::clear_detail)
1402 (tui_source_window_base, ~tui_source_window_base): Move to
1403 tui-winsource.c.
1404
daa15dde
TT
14052019-07-17 Tom Tromey <tom@tromey.com>
1406
1407 * tui/tui-win.c (tui_resize_all)
1408 (tui_source_window_base::update_tab_width)
1409 (tui_adjust_win_heights): Update.
1410 (tui_win_info::make_invisible_and_set_new_height): Rename from
1411 make_invisible_and_set_new_height.
1412 * tui/tui-data.h (struct tui_win_info)
1413 <make_invisible_and_set_new_height>: New method.
1414
bfad4537
TT
14152019-07-17 Tom Tromey <tom@tromey.com>
1416
1417 * tui/tui.c: Update.
1418 * tui/tui-source.h (struct tui_source_window): Move from
1419 tui-data.h.
1420 * tui/tui-layout.c: Update.
1421 * tui/tui-disasm.c: Update.
1422 * tui/tui-data.h (struct tui_source_window): Move to
1423 tui-source.h.
1424
88f7e873
TT
14252019-07-17 Tom Tromey <tom@tromey.com>
1426
1427 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1428 tui-data.h.
1429 * tui/tui-data.h (struct tui_disasm_window): Move to
1430 tui-disasm.h.
1431
96bd6233
TT
14322019-07-17 Tom Tromey <tom@tromey.com>
1433
1434 * tui/tui-regs.h (struct tui_data_item_window): Move from
1435 tui-data.h.
1436 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1437 * tui/tui-data.h (struct tui_data_item_window): Move to
1438 tui-regs.h.
1439 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1440
ce38393b
TT
14412019-07-17 Tom Tromey <tom@tromey.com>
1442
1443 * tui/tui.c: Update.
1444 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1445 (tui_cmd_window::max_height): Move to tui-command.c.
1446 * tui/tui-layout.c: Update.
1447 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1448 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1449 tui-command.c.
1450 * tui/tui-command.h (struct tui_cmd_window): Move from
1451 tui-data.h.
1452 * tui/tui-command.c: Remove "structuring" comments.
1453 (tui_cmd_window::clear_detail)
1454 (tui_cmd_window::do_make_visible_with_new_height)
1455 (tui_cmd_window::max_height): Move from elsewhere.
1456
2d8b51cb
TT
14572019-07-17 Tom Tromey <tom@tromey.com>
1458
1459 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1460 Now static.
1461 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1462 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1463
18ab23af
TT
14642019-07-17 Tom Tromey <tom@tromey.com>
1465
1466 * tui/tui.c: Update.
1467 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1468 tui-regs.c.
1469 * tui/tui-windata.h: Remove file.
1470 * tui/tui-windata.c: Remove file.
1471 * tui/tui-win.c (tui_data_window::set_new_height)
1472 (tui_data_window::do_make_visible_with_new_height): Move to
1473 tui-regs.c.
1474 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1475 * tui/tui-regs.c: Remove "structuring" comments.
1476 (tui_data_window::first_data_item_displayed)
1477 (tui_data_window::delete_data_content_windows)
1478 (tui_data_window::erase_data_content)
1479 (tui_data_window::display_all_data)
1480 (tui_data_window::refresh_all)
1481 (tui_data_window::do_scroll_vertical)
1482 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1483 (tui_data_window::do_make_visible_with_new_height)
1484 (tui_data_window::refresh_window): Move from elsewhere.
1485 (_initialize_tui_regs): Move to end of file.
1486 * tui/tui-layout.c: Update.
1487 * tui/tui-hooks.c: Update.
1488 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1489 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1490 tui-regs.c.
1491 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1492
88b7e7cc
TT
14932019-07-17 Tom Tromey <tom@tromey.com>
1494
1495 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1496 seen.
1497
0fcd3711
TT
14982019-07-17 Tom Tromey <tom@tromey.com>
1499
1500 * tui/tui-win.c (tui_source_window_base::set_new_height)
1501 (tui_source_window_base::do_make_visible_with_new_height): Use
1502 m_has_locator field directly.
1503 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1504 method.
1505 (struct tui_source_window_base) <has_locator>: Likewise.
1506
4a38112d
TT
15072019-07-17 Tom Tromey <tom@tromey.com>
1508
1509 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1510 Don't declare.
1511 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1512 Remove.
1513 * tui/tui-win.c (tui_source_window_base::set_new_height)
1514 (tui_source_window_base::set_new_height)
1515 (make_invisible_and_set_new_height)
1516 (tui_source_window_base::do_make_visible_with_new_height)
1517 (tui_source_window_base::do_make_visible_with_new_height):
1518 Update.
1519 * tui/tui-layout.c (show_source_disasm_command, show_data)
1520 (show_source_or_disasm_and_command): Update.
1521 * tui/tui-layout.c (show_layout): Update.
1522
09129226
TT
15232019-07-17 Tom Tromey <tom@tromey.com>
1524
1525 * tui/tui-layout.c (make_data_window): Remove.
1526 (show_data): Unify creation and re-initialization cases.
1527
4a8a5e84
TT
15282019-07-17 Tom Tromey <tom@tromey.com>
1529
1530 * tui/tui-layout.c (make_source_window, make_disasm_window):
1531 Remove.
1532 (show_data): Unify creation and re-initialization cases.
1533
76d2be8e
TT
15342019-07-17 Tom Tromey <tom@tromey.com>
1535
1536 * tui/tui-layout.c (make_command_window): Remove.
1537 (show_source_disasm_command, show_source_or_disasm_and_command):
1538 Unify creation and re-initialization cases.
1539
890b8bde
TT
15402019-07-17 Tom Tromey <tom@tromey.com>
1541
1542 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1543 creation and re-initialization cases.
1544
2cdfa113
TT
15452019-07-17 Tom Tromey <tom@tromey.com>
1546
1547 * tui/tui-regs.c (tui_get_register): Return void.
1548
8e3cfd09
TT
15492019-07-17 Tom Tromey <tom@tromey.com>
1550
1551 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1552 Simplify.
1553
f4e04977
TT
15542019-07-17 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1557 resetting.
1558
0379b883
TT
15592019-07-17 Tom Tromey <tom@tromey.com>
1560
1561 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1562 * tui/tui-regs.c (tui_reg_layout): New function.
1563 (tui_show_registers, tui_reg_command): Use it.
1564 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1565 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1566 parameters.
1567 (tui_layout_command): Remove.
1568
b7fbad91
TT
15692019-07-17 Tom Tromey <tom@tromey.com>
1570
1571 * tui/tui-layout.h (tui/tui-layout): Return void.
1572 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1573
4e1e56b9
TT
15742019-07-17 Tom Tromey <tom@tromey.com>
1575
1576 * tui/tui-layout.c (show_source_disasm_command, show_data):
1577 Update.
1578 (reset_locator): Remove.
1579 (show_source_or_disasm_and_command): Update.
1580
1e0c09ba
TT
15812019-07-17 Tom Tromey <tom@tromey.com>
1582
1583 * tui/tui-source.c (tui_source_window_base::reset): Remove
1584 win_type parameter.
1585 * tui/tui-layout.c (make_command_window, make_source_window)
1586 (make_disasm_window, make_data_window)
1587 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1588 (reset_locator, show_source_or_disasm_and_command): Update.
1589 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1590 win_type parameter.
1591 (struct tui_source_window_base) <reset>: Likewise.
1592
1bf605de
TT
15932019-07-17 Tom Tromey <tom@tromey.com>
1594
1595 * tui/tui-layout.c (show_source_disasm_command): Use
1596 reset_locator.
1597 (reset_locator): New function.
1598 (init_and_make_win): Remove.
1599 (show_source_or_disasm_and_command): Use reset_locator.
1600
098f9ed4
TT
16012019-07-17 Tom Tromey <tom@tromey.com>
1602
1603 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1604 condition.
1605 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1606 Remove condition.
1607 * tui/tui-source.c (tui_source_window_base::reset): New method.
1608 * tui/tui-layout.c (make_command_window): Don't call
1609 init_and_make_win.
1610 (make_source_window, make_disasm_window): Don't call
1611 make_source_or_disasm_window.
1612 (make_data_window): Don't call init_and_make_win. Change calling
1613 convention.
1614 (show_source_disasm_command, show_data): Simplify.
1615 (make_source_or_disasm_window): Remove.
1616 (show_source_or_disasm_and_command): Simplify.
1617 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1618 (struct tui_source_window_base) <reset>: Likewise.
1619 <execution_info>: Remove initializer.
1620 * tui/tui-data.c (tui_source_window_base): Initialize
1621 execution_info.
1622
80110957
TT
16232019-07-17 Tom Tromey <tom@tromey.com>
1624
1625 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1626 variable.
1627
cf82af05
TT
16282019-07-17 Tom Tromey <tom@tromey.com>
1629
1630 * tui/tui.c (tui_rl_other_window): Update.
1631 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1632 superclass method first. Always iterate over regs_content.
1633 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1634 method.
1635 * tui/tui-win.c (tui_set_focus_command): Update.
1636
01aeb396
TT
16372019-07-17 Tom Tromey <tom@tromey.com>
1638
1639 * tui/tui-win.c (tui_set_focus_command): Rename from
1640 tui_set_focus. Call tui_enable.
1641 (tui_set_focus_command): Remove.
1642
fd6c75ee
TT
16432019-07-17 Tom Tromey <tom@tromey.com>
1644
1645 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1646 refresh_window.
1647 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1648 touchwin.
1649 (tui_data_window::refresh_window): Call refresh_window on data
1650 items. Always call superclass refresh_window.
1651 (tui_win_info::refresh): Remove.
1652 (tui_source_window_base::refresh_window): Update.
1653 (tui_refresh_all): Update.
1654 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1655 refresh_window.
1656 (show_source_or_disasm_and_command): Likewise.
1657 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1658 (struct tui_source_window_base) <refresh>: Likewise.
1659
f6cc34a9
TT
16602019-07-17 Tom Tromey <tom@tromey.com>
1661
1662 * tui/tui-winsource.c (tui_clear_source_content)
1663 (tui_show_source_content): Update.
1664 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1665 whether content is empty.
1666 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1667 Remove.
1668
f31ec9af
TT
16692019-07-17 Tom Tromey <tom@tromey.com>
1670
1671 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1672 window's contents.
1673 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1674 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1675
d1b6f1e5
TT
16762019-07-17 Tom Tromey <tom@tromey.com>
1677
1678 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1679 (struct tui_data_item_window): Update.
1680
d9743a13
TT
16812019-07-17 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1684 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1685 defines.
1686
caf0bc4e
TT
16872019-07-17 Tom Tromey <tom@tromey.com>
1688
1689 * tui/tui-winsource.h (tui_erase_source_content)
1690 (tui_clear_source_content): Remove "display_prompt" parameter.
1691 * tui/tui-winsource.c (tui_update_source_window_as_is)
1692 (tui_update_source_windows_with_addr): Update.
1693 (tui_clear_source_content): Remove "display_prompt" parameter.
1694 (tui_erase_source_content): Likewise. Simplify.
1695 (tui_show_source_content): Update.
1696 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1697 * tui/tui-stack.c (tui_show_frame_info): Update.
1698 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1699 Remove defines.
1700
9d391078
TT
17012019-07-17 Tom Tromey <tom@tromey.com>
1702
1703 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1704 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1705 parameter.
1706 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1707 parameter.
1708
a38da35d
TT
17092019-07-17 Tom Tromey <tom@tromey.com>
1710
1711 * tui/tui-winsource.c (tui_clear_source_content)
1712 (tui_show_source_content, tui_show_exec_info_content)
1713 (tui_clear_exec_info_content): Update.
1714 * tui/tui-stack.c (tui_show_locator_content): Update.
1715 (tui_show_frame_info): Update.
1716 * tui/tui-source.h (tui_source_window): Don't declare.
1717 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1718 from tui_source_is_displayed.
1719 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1720 Remove field.
1721 (struct tui_source_window_base) <content_in_use>: New field. Now
1722 bool.
1723 (struct tui_source_window) <showing_source_p>: New method.
1724 (TUI_SRC_WIN): Change cast.
1725 * tui/tui-data.c (tui_initialize_static_data): Update.
1726
c2cd8994
TT
17272019-07-17 Tom Tromey <tom@tromey.com>
1728
1729 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1730 location_matches_p.
1731 * tui/tui-source.c (tui_source_window::location_matches_p): New
1732 method.
1733 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1734 method.
1735 * tui/tui-data.h (struct tui_source_window_base)
1736 <location_matches_p>: New method.
1737 (struct tui_source_window, struct tui_disasm_window)
1738 <location_matches_p>: Likewise.
1739
4dde7b34
TT
17402019-07-17 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-win.c (tui_set_win_height_command): Rename from
1743 tui_set_win_height.
1744 (tui_set_win_height_command): Remove.
1745
b73dd877
TT
17462019-07-17 Tom Tromey <tom@tromey.com>
1747
1748 * tui/tui-source.c (tui_source_window): New constructor. Add
1749 observer.
1750 (~tui_source_window): New destructor.
1751 (tui_source_window::style_changed): New method.
1752 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1753 (tui_attach_detach_observers): Update.
1754 * tui/tui-data.h (struct tui_source_window): Make constructor not
1755 inline. Add destructor.
1756 (struct tui_source_window) <style_changed>: New method.
1757 <m_observable>: New member.
1758
ae2b5380
TT
17592019-07-17 Tom Tromey <tom@tromey.com>
1760
1761 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1762 * tui/tui-win.c (tui_resize_all): Fix typo.
1763
1ce3e844
TT
17642019-07-17 Tom Tromey <tom@tromey.com>
1765
1766 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1767 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1768 (tui_refresh_all): Remove "list" parameter. Use foreach.
1769 * tui/tui-win.c (window_name_completer): Use foreach.
1770 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1771 (update_tab_width): Likewise.
1772 * tui/tui-layout.c (show_layout): Update.
1773 * tui/tui-data.h (class tui_window_iterator): New.
1774 (struct all_tui_windows): New.
1775 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1776
fe3eaf1c
TT
17772019-07-17 Tom Tromey <tom@tromey.com>
1778
1779 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1780 parameter. Don't reference globals.
1781 (tui_reg_command): Update.
1782
368c1354
TT
17832019-07-17 Tom Tromey <tom@tromey.com>
1784
1785 * tui/tui-regs.c (tui_show_registers): Simplify.
1786
e80cd204
TT
17872019-07-17 Tom Tromey <tom@tromey.com>
1788
1789 * tui/tui-regs.c (tui_show_registers): Update.
1790 (tui_show_register_group): Add win_info parameter.
1791
aca2dd16
TT
17922019-07-17 Tom Tromey <tom@tromey.com>
1793
1794 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1795 Rename from tui_display_reg_element_at_line.
1796 (tui_data_window::display_registers_from_line): Update.
1797 * tui/tui-data.h (struct tui_data_window)
1798 <display_reg_element_at_line>: New method.
1799
517e9505
TT
18002019-07-17 Tom Tromey <tom@tromey.com>
1801
1802 * tui/tui-regs.h (tui_display_registers_from)
1803 (tui_display_registers_from_line): Don't declare.
1804 * tui/tui-windata.c (tui_data_window::display_all_data)
1805 (tui_data_window::refresh_all)
1806 (tui_data_window::do_scroll_vertical): Update.
1807 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1808 from tui_display_registers_from.
1809 (tui_display_reg_element_at_line): Update.
1810 (tui_data_window::display_registers_from_line): Rename from
1811 tui_display_registers_from_line.
1812 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1813 display_registers_from_line>: New methods.
1814
f76d8b19
TT
18152019-07-17 Tom Tromey <tom@tromey.com>
1816
1817 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1818 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1819 from tui_erase_data_content.
1820 (tui_data_window::display_all_data)
1821 (tui_data_window::refresh_all)
1822 (tui_data_window::do_scroll_vertical): Update.
1823 * tui/tui-regs.c (tui_show_registers): Update.
1824 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1825 New method.
1826
b4094625
TT
18272019-07-17 Tom Tromey <tom@tromey.com>
1828
1829 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1830 declare.
1831 * tui/tui-windata.c
1832 (tui_data_window::delete_data_content_windows): Rename from
1833 tui_delete_data_content_windows.
1834 (tui_data_window::display_all_data)
1835 (tui_data_window::do_scroll_vertical): Update.
1836 * tui/tui-data.h (struct tui_data_window)
1837 <delete_data_content_windows>: New method.
1838
c223a729
TT
18392019-07-17 Tom Tromey <tom@tromey.com>
1840
1841 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1842 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1843
50daf268
TT
18442019-07-17 Tom Tromey <tom@tromey.com>
1845
1846 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1847 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1848 from tui_display_all_data.
1849 * tui/tui-win.c
1850 (tui_data_window::do_make_visible_with_new_height): Update.
1851 * tui/tui-regs.c (tui_show_registers): Update.
1852 * tui/tui-layout.c (tui_set_layout): Update.
1853 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1854 method.
1855
df5f8cab
TT
18562019-07-17 Tom Tromey <tom@tromey.com>
1857
1858 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1859 * tui/tui-windata.c (tui_display_data_from): Remove.
1860 (tui_data_window::refresh_all): Update.
1861
80cb6c27
TT
18622019-07-17 Tom Tromey <tom@tromey.com>
1863
1864 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1865 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1866 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1867 tui_display_registers_from_line.
1868 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1869 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1870 "force_display" parameter.
1871
baff0c28
TT
18722019-07-17 Tom Tromey <tom@tromey.com>
1873
1874 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1875 declare.
1876 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1877 Rename from tui_first_reg_element_no_inline.
1878 (tui_display_reg_element_at_line)
1879 (tui_display_registers_from_line): Update.
1880 * tui/tui-data.h (struct tui_data_window)
1881 <first_reg_element_no_inline>: New method.
1882
3b23c5f2
TT
18832019-07-17 Tom Tromey <tom@tromey.com>
1884
1885 * tui/tui-windata.c (tui_display_data_from)
1886 (tui_data_window::do_scroll_vertical): Update.
1887 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1888 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1889 Rename from tui_line_from_reg_element_no.
1890 (tui_display_registers_from_line): Update.
1891 * tui/tui-data.h (struct tui_data_window)
1892 <line_from_reg_element_no>: New method.
1893
0b5ec218
TT
18942019-07-17 Tom Tromey <tom@tromey.com>
1895
1896 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1897 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1898 tui_last_regs_line_no.
1899 (tui_display_reg_element_at_line)
1900 (tui_display_registers_from_line): Update.
1901 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1902 method.
1903
0807ab7b
TT
19042019-07-17 Tom Tromey <tom@tromey.com>
1905
1906 PR tui/24722:
1907 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1908 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1909 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1910 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1911 (tui_update_breakpoint_info): Likewise.
1912 * tui/tui-hooks.c (tui_event_create_breakpoint)
1913 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1914 Update.
1915
9ad7fdef
TT
19162019-07-17 Tom Tromey <tom@tromey.com>
1917
1918 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1919
5813316f
TT
19202019-07-17 Tom Tromey <tom@tromey.com>
1921
1922 * tui/tui-winsource.c (tui_update_source_window_as_is)
1923 (tui_update_source_windows_with_addr): Update.
1924 * tui/tui-source.h (tui_set_source_content)
1925 (tui_show_symtab_source): Add "win_info" parameter.
1926 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1927 parameter.
1928 (tui_show_symtab_source): Likewise.
1929
00e264e7
TT
19302019-07-17 Tom Tromey <tom@tromey.com>
1931
1932 * tui/tui-wingeneral.c
1933 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1934
06210ce4
TT
19352019-07-17 Tom Tromey <tom@tromey.com>
1936
1937 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1938 (struct tui_cmd_window) <can_scroll>: New method.
1939 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1940 method.
1941
381befee
TT
19422019-07-17 Tom Tromey <tromey@adacore.com>
1943
1944 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1945 do_field_signed>: Rename. Change type of "value".
1946 * ui-out.c (ui_out::field_signed): Rename from field_int.
1947 Change type of "value".
1948 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1949 type of "value".
1950 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1951 do_field_int. Change type of "value".
1952 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1953 do_field_int. Change type of "value".
1954 * tracepoint.c (trace_status_mi, tfind_1)
1955 (print_one_static_tracepoint_marker): Update.
1956 * thread.c (print_thread_info_1, print_selected_thread_frame):
1957 Update.
1958 * stack.c (print_frame, print_frame_info): Update.
1959 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1960 Update.
1961 * source.c (print_source_lines_base): Update.
1962 * skip.c (info_skip_command): Update.
1963 * record-btrace.c (btrace_ui_out_decode_error)
1964 (btrace_call_history_src_line): Update.
1965 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1966 Update.
1967 * progspace.c (print_program_space): Update.
1968 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1969 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1970 do_field_int. Change type of "value".
1971 * mi/mi-out.c (mi_ui_out::do_table_begin)
1972 (mi_ui_out::do_table_header): Update.
1973 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1974 type of "value".
1975 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1976 (mi_cmd_data_list_changed_registers, output_register)
1977 (mi_cmd_data_read_memory, mi_load_progress)
1978 (mi_cmd_trace_frame_collected): Update.
1979 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1980 Update.
1981 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1982 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1983 (mi_cmd_var_list_children, varobj_update_one): Update.
1984 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1985 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1986 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1987 * inferior.c (print_inferior): Update.
1988 * gdb_bfd.c (print_one_bfd): Update.
1989 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1990 Update.
1991 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1992 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1993 do_field_int. Change type of "value".
1994 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1995 do_field_int. Change type of "value".
1996 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1997 (print_one_breakpoint_location, print_it_catch_fork)
1998 (print_one_catch_fork, print_it_catch_vfork)
1999 (print_one_catch_vfork, print_it_catch_solib)
2000 (print_it_catch_exec, print_it_ranged_breakpoint)
2001 (print_mention_watchpoint, print_mention_masked_watchpoint)
2002 (bkpt_print_it, update_static_tracepoint): Update.
2003 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2004 * break-catch-syscall.c (print_it_catch_syscall): Update.
2005 * ada-tasks.c (print_ada_task_info): Update.
2006 * ada-lang.c (print_it_exception, print_mention_exception):
2007 Update.
2008
6b78c3f8
AB
20092019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2010
2011 PR breakpoints/24541
2012 * gdbarch.c: Regenerate.
2013 * gdbarch.h: Regenerate.
2014 * gdbarch.sh: Adjust return type and parameter types for
2015 'stap_adjust_register'.
2016 (i386_stap_adjust_register): Adjust signature and return new
2017 register name.
2018 * stap-probe.c (stap_parse_register_operand): Adjust use of
2019 'gdbarch_stap_adjust_register'.
2020
d72a9b85
TT
20212019-07-17 Tom Tromey <tromey@adacore.com>
2022
2023 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2024 declare VEC.
2025 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2026 std::vector.
2027 (struct s390_process_info): Add initializers.
2028 (s390_add_process): Use new.
2029 (s390_linux_nat_target::low_forget_process): Use delete.
2030 (s390_linux_nat_target::low_new_fork)
2031 (s390_linux_nat_target::stopped_by_watchpoint)
2032 (s390_linux_nat_target::low_prepare_to_resume)
2033 (s390_linux_nat_target::insert_watchpoint)
2034 (s390_linux_nat_target::insert_hw_breakpoint)
2035 (s390_linux_nat_target::remove_watchpoint)
2036 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2037
206e6c58
JB
20382019-07-16 John Baldwin <jhb@FreeBSD.org>
2039
2040 * aarch64-fbsd-nat.c: Include regcache.h.
2041 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2042 argument.
2043 (aarch64_fbsd_nat_target::fetch_registers)
2044 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2045 variable.
2046 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2047
cbde90f2
JB
20482019-07-16 John Baldwin <jhb@FreeBSD.org>
2049
2050 * fbsd-nat.c: Include gdbarch.h.
2051
07128006
TT
20522019-07-15 Tom Tromey <tromey@adacore.com>
2053
2054 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2055
1f77b012
TT
20562019-07-15 Tom Tromey <tromey@adacore.com>
2057
2058 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2059 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2060 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2061 * cli-out.c (cli_ui_out::do_field_int): New method.
2062 * ui-out.c (ui_out::field_unsigned): New method.
2063 * symfile.c (generic_load): Use field_unsigned.
2064 (print_transfer_performance): Likewise.
2065 * record-btrace.c (ui_out_field_uint): Remove.
2066 (btrace_call_history_insn_range, btrace_call_history): Use
2067 field_unsigned.
2068 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2069 field_unsigned.
2070 * ui-out.h (class ui_out) <field_unsigned>: New method.
2071 <do_field_unsigned>: Likewise.
2072
33eca680
TT
20732019-07-15 Tom Tromey <tromey@adacore.com>
2074
2075 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2076 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2077 * target.c (flash_erase_command): Use field_string.
2078 * infrun.c (print_signal_received_reason): Use field_string.
2079 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2080 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2081 field_string.
2082 * ada-tasks.c (print_ada_task_info): Use field_string.
2083
ca8d69be
TT
20842019-07-15 Tom Tromey <tromey@adacore.com>
2085
2086 * target.c (flash_erase_command): Use field_core_addr.
2087 * symfile.c (generic_load): Use field_core_addr.
2088 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2089 Use field_core_addr.
2090 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2091 field_core_addr.
2092
0d4e84ed
AB
20932019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2094
2095 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2096 value if its desired type is smaller than a CORE_ADDR and signed.
2097
9a49df9d
AB
20982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2099
2100 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2101 of changes to field names, and use new is_reference field to
2102 decide if a property is a reference or not.
2103 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2104 field.
2105 (struct dwarf2_property_baton): Update header comment, rename
2106 'referenced_type' to 'property_type' and update comments.
2107 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2108 default property type, store in property baton, update to take
2109 accound of renamed field.
2110 (read_func_scope): Update call to attr_to_dynamic_prop.
2111 (read_array_type): Likewise.
2112 (dwarf2_per_cu_addr_sized_int_type): New function.
2113 (read_subrange_index_type): Move type finding code to
2114 dwarf2_per_cu_addr_sized_int_type.
2115 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2116 (dwarf2_per_cu_addr_type): New function.
2117 (set_die_type): Update calls to attr_to_dynamic_prop.
2118
b86352cf
AB
21192019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2120
2121 * dwarf2read.c (read_subrange_index_type): New function.
2122 (read_subrange_type): Move code into new function and call it.
2123 * gdbtypes.c (create_range_type): Add some asserts.
2124
603490bf
AB
21252019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2126
2127 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2128 update return statements.
2129 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2130 declaration, and update comment to match.
2131 * gdbtypes.c (resolve_dynamic_array): Update call to
2132 dwarf2_evaluate_property to match new return type.
2133
592f9d27
AB
21342019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2135
2136 * valarith.c (value_subscripted_rvalue): Change lowerbound
2137 parameter type from int to LONGEST.
2138 * value.h (value_subscripted_rvalue): Likewise in declaration.
2139
60cfcb20
AB
21402019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2141
2142 * cli/cli-utils.c (info_print_command_completer): New function.
2143 * cli/cli-utils.h: Add 'completer.h' include, and forward
2144 declaration for 'struct cmd_list_element'.
2145 (info_print_command_completer): Declare.
2146 * stack.c (_initialize_stack): Add completer for 'info locals' and
2147 'info args'.
2148 * symtab.c (_initialize_symtab): Add completer for 'info
2149 variables' and 'info functions'.
2150 * NEWS: Mention completion for additional info commands.
2151
b16507e0
AB
21522019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2153
2154 * cli/cli-utils.c (extract_info_print_args): Delete.
2155 (extract_arg_maybe_quoted): Delete.
2156 (info_print_options_defs): New variable.
2157 (make_info_print_options_def_group): New function.
2158 (extract_info_print_options): Define new function.
2159 * cli/cli-utils.h (extract_info_print_args): Delete.
2160 (struct info_print_options): New structure.
2161 (extract_info_print_options): Declare new function.
2162 * stack.c (info_locals_command): Update to use new
2163 extract_info_print_options, also add a header comment.
2164 (info_args_command): Likewise.
2165 * symtab.c (info_variables_command): Likewise.
2166 (info_functions_command): Likewise.
2167
021d8588
AB
21682019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2169
2170 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2171 to extract string arguments.
2172 * common/common-utils.c (extract_string_maybe_quoted): New function.
2173 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2174
b777eb6d
TT
21752019-07-11 Tom Tromey <tromey@adacore.com>
2176
2177 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2178 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2179 * top.h (gdbinit): Don't declare.
2180 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2181 into...
2182 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2183 * top.c (gdb_init): Don't call init_cli_cmds.
2184 (gdbinit): Remove.
2185 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2186
72ee03ff
TT
21872019-07-11 Tom Tromey <tromey@adacore.com>
2188
2189 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2190 after it has been moved.
2191
00db9531
SM
21922019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2193
2194 * valops.c (value_must_coerce_to_target): Change return type to
2195 bool.
2196 * value.h (value_must_coerce_to_target): Likewise.
2197
f2478a7e
SM
21982019-07-10 Simon Marchi <simon.marchi@efficios.com>
2199
2200 * breakpoint.c (is_hardware_watchpoint): Remove
2201 forward-declaration.
2202 (is_masked_watchpoint): Change return type to bool.
2203 (is_tracepoint): Likewise.
2204 (is_breakpoint): Likewise.
2205 (is_hardware_watchpoint): Likewise.
2206 (is_watchpoint): Likewise.
2207 (is_no_memory_software_watchpoint): Likewise.
2208 (is_catchpoint): Likewise.
2209 (breakpoint_1): Make FILTER parameter's return type bool.
2210 is_masked_watchpoint): Change return type to bool.
2211 (save_breakpoints): Make FILTER parameter's return type bool.
2212 * breakpoint.h (is_breakpoint): Change return type to bool.
2213 (is_watchpoint): Likewise.
2214 (is_catchpoint): Likewise.
2215 (is_tracepoint): Likewise.
2216
0d12e84c
TT
22172019-07-10 Tom Tromey <tom@tromey.com>
2218
2219 * defs.h: Don't include gdbarch.h.
2220 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2221 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2222 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2223 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2224 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2225 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2226 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2227 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2228 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2229 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2230 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2231 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2232 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2233 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2234 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2235 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2236 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2237 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2238 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2239 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2240 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2241 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2242 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2243 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2244 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2245 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2246 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2247
f06f1252
TT
22482019-07-10 Tom Tromey <tromey@adacore.com>
2249
2250 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2251 * breakpoint.c (init_ada_exception_breakpoint): Register as
2252 bp_catchpoint.
2253 (print_one_breakpoint_location, print_one_breakpoint): Use
2254 is_ada_exception_catchpoint.
2255 * ada-lang.c (class ada_catchpoint_location): Pass
2256 bp_loc_software_breakpoint to bp_location constructor.
2257 (is_ada_exception_catchpoint): New function.
2258
7a5d944b
TT
22592019-07-10 Tom Tromey <tromey@adacore.com>
2260
2261 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2262 VEC.
2263 (struct arm_exidx_entry): New method operator<.
2264 (struct arm_exidx_data) <section_maps>: Change type.
2265 (arm_exidx_data_free): Remove.
2266 (arm_exidx_data_key): Change type. Move lower.
2267 (arm_exidx_new_objfile): Update.
2268 (arm_compare_exidx_entries): Remove.
2269 (arm_find_exidx_entry, _initialize_arm_tdep)
2270
48c66e1d
TT
22712019-07-10 Tom Tromey <tromey@adacore.com>
2272
2273 * solib-spu.c (ocl_program_data_key): Change type.
2274 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2275 Update.
2276
a269fbf1
TT
22772019-07-10 Tom Tromey <tromey@adacore.com>
2278
2279 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2280 (struct solib_aix_inferior_data) <library_list>: Change type.
2281 (solib_aix_inferior_data_handle): Change type.
2282 (get_solib_aix_inferior_data): Update.
2283 (solib_aix_free_library_list): Remove.
2284 (library_list_start_library): Update.
2285 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2286 return type.
2287 (solib_aix_get_library_list)
2288 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2289 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2290
c294730c
TT
22912019-07-10 Tom Tromey <tromey@adacore.com>
2292
2293 * solib-dsbt.c (struct dsbt_info): Add initializers.
2294 (solib_dsbt_pspace_data): Change type.
2295 (dsbt_pspace_data_cleanup): Remove.
2296 (get_dsbt_info, _initialize_dsbt_solib): Update.
2297
9d52077d
TT
22982019-07-10 Tom Tromey <tromey@adacore.com>
2299
2300 * spu-tdep.c (spu_overlay_data): Change type.
2301 (spu_get_overlay_table, spu_overlay_new_objfile)
2302 (_initialize_spu_tdep): Update.
2303
22a20dca
TT
23042019-07-10 Tom Tromey <tromey@adacore.com>
2305
2306 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2307 destructor.
2308 (dbx_objfile_data_key): Change type and declare later.
2309 (DBX_SYMFILE_INFO): Rewrite.
2310 * dbxread.c (dbx_objfile_data_key): Change type.
2311 (dbx_symfile_init): Update.
2312 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2313 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2314 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2315
cb60f420
TT
23162019-07-10 Tom Tromey <tromey@adacore.com>
2317
2318 * jit.c (jit_program_space_key): Change type. Move lower.
2319 (get_jit_program_space_data): Update.
2320 (jit_program_space_data_cleanup): Remove.
2321 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2322 Update.
2323 (struct jit_program_space_data): Add initializers.
2324
51df2ae3
TT
23252019-07-10 Tom Tromey <tromey@adacore.com>
2326
2327 * solib-darwin.c (struct darwin_info): Add initializers.
2328 (solib_darwin_pspace_data): Change type.
2329 (darwin_pspace_data_cleanup): Remove.
2330 (get_darwin_info, _initialize_darwin_solib): Update.
2331
18101a35
TT
23322019-07-10 Tom Tromey <tromey@adacore.com>
2333
2334 * remote-sim.c (struct sim_inferior_data): Add initializers,
2335 constructor, and destructor.
2336 (sim_inferior_data_key): Change type. Move lower.
2337 (check_for_duplicate_sim_descriptor): Update.
2338 (get_sim_inferior_data): Use new. Update.
2339 (~sim_inferior_data_cleanup): Rename from
2340 sim_inferior_data_cleanup. Simplify.
2341 (gdbsim_close_inferior, simulator_command)
2342 (sim_command_completer, _initialize_remote_sim): Update.
2343 (next_pid, INITIAL_PID): Move earlier.
2344
05b08ac1
TT
23452019-07-10 Tom Tromey <tromey@adacore.com>
2346
2347 * python/python-internal.h (create_thread_object): Return
2348 gdbpy_ref.
2349 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2350 * python/py-inferior.c (struct threadlist_entry): Add
2351 constructor.
2352 <thread_obj>: Now a gdbpy_ref.
2353 (thread_to_thread_object): Update.
2354 (add_thread_object): Use new.
2355 (delete_thread_object): Use delete.
2356 (infpy_threads): Update.
2357 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2358 GIL.
2359
32372d80
TT
23602019-07-10 Tom Tromey <tromey@adacore.com>
2361
2362 * valops.c (value_cast): Specialize error message for Ada.
2363
5c458ae8
SM
23642019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2365
2366 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2367
4c462cb0
SM
23682019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2369
2370 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2371 bpstat_should_step): Return bool, adjust comments.
2372 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2373 bpstat_should_step): Likewise.
2374
89abbcc2
AH
23752019-07-10 Alan Hayward <alan.hayward@arm.com>
2376
2377 * features/Makefile: Use feature target descriptions for Arm.
2378 * features/arm/arm-core.c: Generate new file.
2379 * features/arm/arm-fpa.c: Likewise.
2380 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2381 * features/arm/arm-m-profile.c: Likewise.
2382 * features/arm/arm-vfpv2.c: Likewise.
2383 * features/arm/arm-vfpv3.c: Likewise.
2384 * features/arm/xscale-iwmmxt.c: Likewise.
2385 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2386
166a82be
AH
23872019-07-10 Alan Hayward <alan.hayward@arm.com>
2388
2389 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2390 ptrace earlier.
2391
9fb4c7e9
AH
23922019-07-10 Alan Hayward <alan.hayward@arm.com>
2393
2394 * features/aarch64-pauth.c: Regenerate.
2395
e2d0f980
SM
23962019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2397
2398 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2399 bool.
2400 (bpstat_what): Use false instead of 0.
2401
a38118e5
PA
24022019-07-09 Pedro Alves <palves@redhat.com>
2403
2404 * break-catch-throw.c (is_exception_catchpoint): New.
2405 * breakpoint.c (print_one_breakpoint_location): New parameter
2406 'raw_loc'. Handle it. Use
2407 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2408 looking at the breakpoint's type.
2409 (print_one_breakpoint): If handling "maint info breakpoints", also
2410 print locations of exception catchpoints.
2411 * breakpoint.h (is_exception_catchpoint): Declare.
2412
cb1e4e32
PA
24132019-07-09 Pedro Alves <palves@redhat.com>
2414
2415 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2416 "addr" field.
2417 (allocate_location_exception_catchpoint): New.
2418 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2419 (initialize_throw_catchpoint_ops): Install
2420 allocate_location_exception_catchpoint as allocate_location
2421 method.
2422 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2423 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2424 bp_loc_other.
2425 (breakpoint_address_is_meaningful): Delete.
2426 (bl_address_is_meaningful): New.
2427 (breakpoint_locations_match): Adjust comment.
2428 (bp_location_from_bp_type): New, factored out of...
2429 (bp_location::bp_location(breakpoint *)): ... this.
2430 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2431 factored out of...
2432 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2433 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2434 breakpoint_address_is_meaningful.
2435 (bp_locations_compare): Adjust comment.
2436 (update_global_location_list): Use bl_address_is_meaningful
2437 instead of breakpoint_address_is_meaningful.
2438 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2439 explicit.
2440 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2441 * python/py-breakpoint.c (bppy_get_location): No longer check
2442 whether location is null.
2443
b58a68fe
PA
24442019-07-09 Pedro Alves <palves@redhat.com>
2445
2446 PR c++/15468
2447 * breakpoint.c (print_one_breakpoint_location): Remove
2448 single-location assert.
2449
268a13a5
TT
24502019-07-09 Tom Tromey <tom@tromey.com>
2451
2452 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2453 * configure: Rebuild.
2454 * configure.ac: Change common to gdbsupport.
2455 * gdbsupport: Rename from common.
2456 * acinclude.m4: Change common to gdbsupport.
2457 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2458 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2459 gdbsupport.
2460 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2461 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2462 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2463 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2464 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2465 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2466 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2467 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2468 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2469 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2470 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2471 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2472 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2473 coff-pe-read.c, command.h, compile/compile-c-support.c,
2474 compile/compile-c.h, compile/compile-cplus-symbols.c,
2475 compile/compile-cplus-types.c, compile/compile-cplus.h,
2476 compile/compile-loc2c.c, compile/compile.c, completer.c,
2477 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2478 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2479 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2480 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2481 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2482 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2483 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2484 features/aarch64-core.c, features/aarch64-fpu.c,
2485 features/aarch64-pauth.c, features/aarch64-sve.c,
2486 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2487 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2488 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2489 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2490 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2491 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2492 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2493 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2494 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2495 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2496 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2497 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2498 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2499 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2500 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2501 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2502 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2503 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2504 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2505 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2506 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2507 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2508 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2509 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2510 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2511 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2512 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2513 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2514 minsyms.c, mips-linux-tdep.c, namespace.h,
2515 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2516 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2517 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2518 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2519 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2520 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2521 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2522 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2523 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2524 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2525 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2526 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2527 procfs.c, producer.c, progspace.h, psymtab.h,
2528 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2529 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2530 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2531 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2532 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2533 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2534 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2535 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2536 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2537 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2538 target-memory.c, target.c, target.h, target/waitstatus.c,
2539 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2540 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2541 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2542 unittests/array-view-selftests.c,
2543 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2544 unittests/common-utils-selftests.c,
2545 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2546 unittests/format_pieces-selftests.c,
2547 unittests/function-view-selftests.c,
2548 unittests/lookup_name_info-selftests.c,
2549 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2550 unittests/mkdir-recursive-selftests.c,
2551 unittests/observable-selftests.c,
2552 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2553 unittests/parse-connection-spec-selftests.c,
2554 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2555 unittests/scoped_fd-selftests.c,
2556 unittests/scoped_mmap-selftests.c,
2557 unittests/scoped_restore-selftests.c,
2558 unittests/string_view-selftests.c, unittests/style-selftests.c,
2559 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2560 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2561 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2562 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2563 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2564 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2565
5b0e2db4
AB
25662019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2567
2568 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2569 bool value.
2570 (decode_digits_ordinary): Set explicit_line field in sal.
2571 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2572 symtab_and_line that was set on an explicit line number in
2573 assembler code. Do always update the recorded symtab and line if
2574 we do skip the prologue.
2575
0ba852ab
AB
25762019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2577
2578 * breakpoint.c (set_breakpoint_location_function): Remove
2579 explicit_loc parameter.
2580 (momentary_breakpoint_from_master): Update call to
2581 set_breakpoint_location_function.
2582 (add_location_to_breakpoint): Likewise.
2583
b3a7d171
AB
25842019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2585
2586 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2587 required features based on default bfd type when no specific bfd
2588 is present.
2589
1f6f6e21
PW
25902019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2591
2592 * NEWS: Mention that GDB printf and eval commands can now print
2593 C-style and Ada-style convenience var strings without
2594 calling the inferior.
2595 * printcmd.c (printf_c_string): Locally print GDB internal var
2596 instead of transiting via the inferior.
2597 (printf_wide_c_string): Likewise.
2598
25992019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2600
2601 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2602
0598af48
TT
26032019-07-04 Tom Tromey <tom@tromey.com>
2604
2605 PR tui/24724:
2606 * tui/tui-winsource.c (tui_clear_source_content): Update.
2607 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2608 (tui_update_breakpoint_info): Update.
2609 (tui_set_exec_info_content): Update.
2610 * tui/tui-source.c (tui_set_source_content_nil): Update.
2611 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2612 has_break.
2613 * tui/tui-data.h (enum tui_bp_flag): New.
2614 (tui_bp_flags): New enum flags type.
2615 (struct tui_source_element) <break_mode>: Change type. Rename
2616 from has_break.
2617 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2618 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2619 constants.
2620 * tui/tui-winsource.h: Fix comment.
2621
350fab54
AH
26222019-07-04 Alan Hayward <alan.hayward@arm.com>
2623
2624 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2625 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2626 (store_fpregs_to_thread)
2627 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2628 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2629 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2630 (IWMMXT_REGS_SIZE): Add define.
2631 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2632 (fetch_vfp_regs, store_vfp_regs)
2633 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2634 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2635
f0452268
AH
26362019-07-04 Alan Hayward <alan.hayward@arm.com>
2637
2638 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2639 defines.
2640 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2641 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2642 (ARM_INT_REGISTER_SIZE): ...to this.
2643 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2644 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2645 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2646 (arm_linux_collect_gregset, supply_nwfpe_register)
2647 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2648 defines.
2649 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2650 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2651 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2652 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2653 (arm_return_in_memory, arm_store_return_value)
2654 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2655 (arm_record_ld_st_multiple): Likewise.
2656 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2657 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2658
e935475c
AH
26592019-07-04 Alan Hayward <alan.hayward@arm.com>
2660
2661 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2662 AARCH64_DISPLACED_MODIFIED_INSNS.
2663 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2664 (aarch64_displaced_step_copy_insn): Likewise.
2665 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2666 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2667 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2668 ARM_DISPLACED_MODIFIED_INSNS.
2669 * arm-tdep.c (arm_gdbarch_init): Likewise.
2670 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2671 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2672 (struct arm_displaced_step_closure): Use
2673 ARM_DISPLACED_MODIFIED_INSNS.
2674
df0bb381
AH
26752019-07-04 Alan Hayward <alan.hayward@arm.com>
2676
2677 * features/Makefile: Remove unused xml files.
2678 * features/aarch64.xml: Remove.
2679 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2680 * features/i386/amd64-avx-avx512.xml: Remove.
2681 * features/i386/amd64-avx-linux.xml: Remove.
2682 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2683 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2684 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2685 * features/i386/amd64-avx-mpx.xml: Remove.
2686 * features/i386/amd64-avx.xml: Remove.
2687 * features/i386/amd64-linux.xml: Remove.
2688 * features/i386/amd64-mpx-linux.xml: Remove.
2689 * features/i386/amd64-mpx.xml: Remove.
2690 * features/i386/amd64.xml: Remove.
2691 * features/i386/i386-avx-avx512-linux.xml: Remove.
2692 * features/i386/i386-avx-avx512.xml: Remove.
2693 * features/i386/i386-avx-linux.xml: Remove.
2694 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2695 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2696 * features/i386/i386-avx-mpx-linux.xml: Remove.
2697 * features/i386/i386-avx-mpx.xml: Remove.
2698 * features/i386/i386-avx.xml: Remove.
2699 * features/i386/i386-linux.xml: Remove.
2700 * features/i386/i386-mmx-linux.xml: Remove.
2701 * features/i386/i386-mmx.xml: Remove.
2702 * features/i386/i386-mpx-linux.xml: Remove.
2703 * features/i386/i386-mpx.xml: Remove.
2704 * features/i386/i386.xml: Remove.
2705 * features/i386/x32-avx-avx512-linux.xml: Remove.
2706 * features/i386/x32-avx-linux.xml: Remove.
2707 * features/i386/x32-linux.xml: Remove.
2708
edd6266a
AH
27092019-07-04 Alan Hayward <alan.hayward@arm.com>
2710
2711 * regformats/aarch64.dat: Remove.
2712 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2713 * regformats/i386/amd64-avx-linux.dat: Remove.
2714 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2715 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2716 * regformats/i386/amd64-linux.dat: Remove.
2717 * regformats/i386/amd64-mpx-linux.dat: Remove.
2718 * regformats/i386/amd64.dat: Remove.
2719 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2720 * regformats/i386/i386-avx-linux.dat: Remove.
2721 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2722 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2723 * regformats/i386/i386-linux.dat: Remove.
2724 * regformats/i386/i386-mmx-linux.dat: Remove.
2725 * regformats/i386/i386-mpx-linux.dat: Remove.
2726 * regformats/i386/i386.dat: Remove.
2727 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2728 * regformats/i386/x32-avx-linux.dat: Remove.
2729 * regformats/i386/x32-linux.dat: Remove.
2730
2b40fda7
AH
27312019-07-04 Alan Hayward <alan.hayward@arm.com>
2732
2733 * aarch64-tdep.c: Remove xml self tests.
2734 * amd64-linux-tdep.c: Likewise.
2735 * amd64-tdep.c: Likewise.
2736 * i386-linux-tdep.c: Likewise.
2737 * i386-tdep.c: Likewise.
2738
5f4ba3e7
PA
27392019-07-03 Pedro Alves <palves@redhat.com>
2740
2741 PR cli/24732
2742 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2743 (pipe_cmd_option_defs): New.
2744 (make_pipe_cmd_options_def_group): New.
2745 (pipe_command): Use gdb::option::process_options.
2746 (pipe_command_completer): New function.
2747 (_initialize_cli_cmds): Install completer for "pipe" command.
2748
3d9be6f5
PA
27492019-07-03 Pedro Alves <palves@redhat.com>
2750
2751 * cli/cli-option.c (union option_value) <string>: New field.
2752 (struct option_def_and_value): Add ctor, move ctor, dtor and
2753 use DISABLE_COPY_AND_ASSIGN.
2754 (option_def_and_value::clear_value): New.
2755 (parse_option, save_option_value_in_ctx, get_val_type_str)
2756 (add_setshow_cmds_for_options): Handle var_string.
2757 * cli-option.h (union option_def::var_address) <string>: New
2758 field.
2759 (struct string_option_def): New.
2760 * maint-test-options.c (struct test_options_opts): Add default
2761 ctor and use DISABLE_COPY_AND_ASSIGN.
2762 <string_opt>: New field.
2763 (test_options_opts::~test_options_opts): New.
2764 (test_options_opts::dump): Also dump "-string".
2765 (test_options_option_defs): Install "string.
2766
41fc454c
PA
27672019-07-03 Pedro Alves <palves@redhat.com>
2768
2769 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2770 option_value with a null enumeration.
2771 (complete_options): Save the option values in the context.
2772 (save_option_value_in_ctx): New, factored out from ...
2773 (process_options): ... here.
2774 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2775 of the function.
2776 * maint-test-options.c (test_options_opts::dump): New, factored
2777 out from ...
2778 (maintenance_test_options_command_mode): ... here.
2779 (maintenance_test_options_command_completion_result): Delete.
2780 (maintenance_test_options_command_completion_text): Update
2781 comment.
2782 (maintenance_show_test_options_completion_result): Change
2783 prototype. Just print
2784 maintenance_test_options_command_completion_text.
2785 (save_completion_result): New.
2786 (maintenance_test_options_completer_mode): Pass options context to
2787 complete_options, and then save a dump.
2788 (_initialize_maint_test_options): Use add_cmd to install "maint
2789 show test-options-completion-result".
2790
fdbc9870
PA
27912019-07-03 Pedro Alves <palves@redhat.com>
2792
2793 * NEWS (New commands): Mention "with" and "maint with".
2794 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2795 (with_command, with_command_completer): New.
2796 (pipe_command): Adjust to new repeat_previous
2797 interface.
2798 (_initialize_cli_cmds): Install the "with" command and its "w"
2799 alias.
2800 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2801 declarations.
2802 * cli/cli-setshow.c (parse_cli_var_uinteger)
2803 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2804 argument strings for all var_types.
2805 (get_setshow_command_value_string): New, factored out from ...
2806 (do_show_command): ... this.
2807 * cli/cli-setshow.h: Include <string>.
2808 (get_setshow_command_value_string): Declare.
2809 * command.h (repeat_previous): Now returns const char *. Adjust
2810 comment.
2811 * maint.c: Include "cli/cli-cmds.h".
2812 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2813 (_initialize_maint_cmds): Register the "maintenance with" command.
2814 * top.c (repeat_previous): Move bits from pipe_command here:
2815 Return the saved command line, if any; error out if there's no
2816 command to relaunch.
2817
c6ac8931
PA
28182019-07-03 Pedro Alves <palves@redhat.com>
2819
2820 * NEWS (New commands): Mention "maint set/show test-settings"
2821 instead of "maint test-settings".
2822 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2823 (maintenance_test_settings_set_list): Rename to ...
2824 (maintenance_set_test_settings_list): ... this.
2825 (maintenance_test_settings_show_list): Rename to ...
2826 (maintenance_show_test_settings_list): ... this.
2827 (maintenance_test_settings_cmd): Delete.
2828 (maintenance_test_settings_set_cmd): ...
2829 (maintenance_set_test_settings_cmd): ... this.
2830 (maintenance_test_settings_show_cmd): ...
2831 (maintenance_show_test_settings_cmd): ... this.
2832 (maintenance_test_settings_show_value_cmd):
2833 (maintenance_show_test_settings_value_cmd): ... this.
2834 (_initialize_maint_test_settings): No longer install the "maint
2835 test-settings" prefix command. Rename "maint test-settings set"
2836 to "maint set test-settings", and "maint test-settings show" to
2837 "maint show test-settings". Adjust all subcommands.
2838
d1fcf2fd
PA
28392019-07-03 Pedro Alves <palves@redhat.com>
2840
2841 * maint-test-settings.c: Fix file's intro comment. Replace all
2842 references to "test-options" with references to "test-settings",
2843 in comments.
2844
970f9d09
PA
28452019-07-03 Pedro Alves <palves@redhat.com>
2846
2847 * maint-test-settings.c (maintenance_test_settings_xxx)
2848 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2849 New.
2850 (maintenance_test_settings_enums): Use them.
2851 (maintenance_test_settings_enum): Default to
2852 maintenance_test_settings_xxx.
2853 (_initialize_maint_test_settings): Initialize
2854 MAINTENANCE_TEST_SETTINGS_FILENAME.
2855
f3869b1a
SM
28562019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2857
2858 * breakpoint.h (remove_breakpoints_inf): Change return type to
2859 void, move function documentation here.
2860 * breakpoint.c (remove_breakpoints_inf): Change return type to
2861 void, move function documentation to header.
2862
54d66006
PA
28632019-07-02 Pedro Alves <palves@redhat.com>
2864
2865 * NEWS (Completion improvements): Mention "info threads".
2866 * thread.c (struct info_threads_opts, info_threads_option_defs)
2867 (make_info_threads_options_def_group): New.
2868 (info_threads_command): Use gdb::option::process_options.
2869 (info_threads_command_completer): New.
2870 (_initialize_thread): Use gdb::option::build_help to build the
2871 help text for "info threads".
2872
854f6088
SM
28732019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2874
2875 * defs.h (generic_load): Move from here...
2876 * symfile.h (generic_load): ... to here. Rename name parameter
2877 to args.
2878 * symfile.c (generic_load): Add comment.
2879
54ee4252
TT
28802019-07-01 Tom Tromey <tromey@adacore.com>
2881
2882 * dwarf2read.c
2883 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2884 declaration of without_params. Fix formatting.
2885
65392b3e
TT
28862019-07-01 Tom Tromey <tromey@adacore.com>
2887
2888 * ada-exp.y (find_primitive_type): Update.
2889 * ada-lang.h (ada_lookup_symbol): Update.
2890 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2891 parameter.
2892 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2893
7d7571f0
SDJ
28942019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2895
2896 PR breakpoints/24541
2897 * gdbarch.c: Regenerate.
2898 * gdbarch.h: Regenerate.
2899 * gdbarch.sh: Add 'stap_adjust_register'.
2900 * i386-tdep.c: Include '<unordered_set>'.
2901 (i386_stap_adjust_register): New function.
2902 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2903 * stap-probe.c (stap_parse_register_operand): Call
2904 'gdbarch_stap_adjust_register'.
2905
5af5392a
SDJ
29062019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2907
2908 PR python/24742
2909 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2910 * python/python.c (do_start_initialization): Use 'xmalloc'
2911 instead of 'PyMem_Malloc'.
2912
10d06d82
TT
29132019-06-28 Tom Tromey <tromey@adacore.com>
2914
2915 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2916 for Ada.
2917
1b7f24cd
TT
29182019-06-27 Tom Tromey <tromey@adacore.com>
2919
2920 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2921 objfile_key.
2922 (arm_find_mapping_symbol, arm_record_special_symbol)
2923 (_initialize_arm_tdep): Update.
2924 (arm_objfile_data_free): Remove.
2925
3d507ff2
TT
29262019-06-27 Tom Tromey <tromey@adacore.com>
2927
2928 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2929 to cp_print_static_field.
2930
762c164d
TT
29312019-06-26 Tom Tromey <tromey@adacore.com>
2932
2933 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2934 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2935 declare.
2936
aa2f9bcf
AH
29372019-06-26 Alan Hayward <alan.hayward@arm.com>
2938
2939 * features/aarch64-core.c (create_feature_aarch64_core):
2940 Regenerate.
2941 * features/aarch64-core.xml: Add cpsr flags.
2942
3426ae57
AH
29432019-06-26 Alan Hayward <alan.hayward@arm.com>
2944
2945 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2946 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2947
4838e44c
SM
29482019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2949
2950 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2951 field.
2952 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2953 use.
2954 (arm_record_special_symbol): Don't insert new symbol in sorted
2955 position, push it at the end.
2956
54cc7474
SM
29572019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2958
2959 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2960 (arm_mapping_symbol_s): Remove.
2961 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2962 (arm_mapping_symbol_vec): New typedef.
2963 (struct arm_per_objfile): Add constructor.
2964 <section_maps>: Change type to
2965 std::unique_ptr<arm_mapping_symbol_vec[]>.
2966 (arm_compare_mapping_symbols): Remove.
2967 (arm_find_mapping_symbol): Adjust to section_maps type change.
2968 (arm_objfile_data_free): Call delete on arm_per_objfile.
2969 (arm_record_special_symbol): Adjust to section_maps type change.
2970 Allocate arm_per_objfile with new.
2971
b65b566c
PW
29722019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2973
2974 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2975 with the command prefix.
2976
c2fc64f5
TT
29772019-06-25 Tom Tromey <tom@tromey.com>
2978
2979 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2980 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2981
fb54fa76
TT
29822019-06-25 Tom Tromey <tom@tromey.com>
2983
2984 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2985 type.
2986 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2987 protected.
2988
f7952c57
TT
29892019-06-25 Tom Tromey <tom@tromey.com>
2990
2991 * tui/tui-winsource.c
2992 (tui_source_window_base::set_is_exec_point_at): Add check against
2993 LOA_ADDRESS.
2994
17568d78
TT
29952019-06-25 Tom Tromey <tom@tromey.com>
2996
2997 * tui/tui-source.c (tui_set_source_content): Don't check before
2998 xfree.
2999 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3000
53e7cdba
TT
30012019-06-25 Tom Tromey <tom@tromey.com>
3002
3003 * tui/tui-winsource.h (tui_update_source_window_as_is)
3004 (tui_alloc_source_buffer, tui_line_is_displayed)
3005 (tui_addr_is_displayed): Change type of win_info.
3006 * tui/tui-winsource.c (tui_update_source_window_as_is)
3007 (tui_clear_source_content, tui_show_source_line)
3008 (tui_show_source_content, tui_source_window_base::refill)
3009 (tui_source_window_base::set_is_exec_point_at)
3010 (tui_source_window_base::set_is_exec_point_at)
3011 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3012 (tui_alloc_source_buffer, tui_line_is_displayed)
3013 (tui_addr_is_displayed): Change type of win_info. Update.
3014 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3015 (tui_source_window_base::do_make_visible_with_new_height):
3016 Update.
3017 * tui/tui-source.c (tui_set_source_content)
3018 (tui_set_source_content_nil)
3019 (tui_source_window::do_scroll_vertical): Update.
3020 * tui/tui-layout.c (show_layout): Update.
3021 * tui/tui-disasm.c (tui_set_disassem_content)
3022 (tui_disasm_window::do_scroll_vertical): Update.
3023 * tui/tui-data.h (tui_win_content): Remove.
3024 (struct tui_gen_win_info) <content, content_size>: Remove.
3025 (struct tui_source_element): Add initializers and destructor.
3026 (union tui_which_element, struct tui_win_element): Remove.
3027 (struct tui_source_window_base) <content>: New field.
3028 (struct tui_data_window): Remove destructor.
3029 (tui_alloc_content, tui_free_win_content)
3030 (tui_free_all_source_wins_content): Don't declare.
3031 * tui/tui-data.c (tui_initialize_static_data): Update.
3032 (init_content_element, tui_alloc_content): Remove.
3033 (~tui_gen_win_info): Update.
3034 (~tui_data_window, tui_free_all_source_wins_content)
3035 (tui_free_win_content, free_content, free_content_elements):
3036 Remove.
3037
7908abbf
TT
30382019-06-25 Tom Tromey <tom@tromey.com>
3039
3040 * tui/tui-winsource.h (tui_clear_source_content)
3041 (tui_erase_source_content, tui_show_source_content): Change type
3042 of win_info.
3043 * tui/tui-winsource.c (tui_clear_source_content)
3044 (tui_erase_source_content, tui_show_source_content): Change type
3045 of win_info.
3046 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3047 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3048 win_info.
3049 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3050 win_info.
3051 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3052
02c28df0
TT
30532019-06-25 Tom Tromey <tom@tromey.com>
3054
3055 * tui/tui-winsource.c (tui_clear_source_content)
3056 (tui_source_window_base::set_is_exec_point_at): Update.
3057 * tui/tui-source.c (tui_set_source_content_nil): Update.
3058 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3059 a bool.
3060 * tui/tui-data.c (init_content_element): Update.
3061
6658b1bf
TT
30622019-06-25 Tom Tromey <tom@tromey.com>
3063
3064 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3065 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3066 * tui/tui-layout.c (init_and_make_win): Update.
3067 * tui/tui.h (enum tui_win_type): Update.
3068 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3069 tui_win_is_auxillary.
3070 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3071 tui_win_is_auxillary.
3072
21e1c91e
TT
30732019-06-25 Tom Tromey <tom@tromey.com>
3074
3075 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3076 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3077 (tui_delete_data_content_windows, tui_display_all_data)
3078 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3079 Update.
3080 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3081 * tui/tui-regs.c (tui_last_regs_line_no)
3082 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3083 (tui_show_registers): Update.
3084 (tui_show_register_group): Return void. Update.
3085 (tui_display_registers_from, tui_display_reg_element_at_line)
3086 (tui_display_registers_from_line, tui_check_register_values):
3087 Update.
3088 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3089 member.
3090 (struct tui_data_window) <regs_content>: Now a std::vector.
3091 <regs_content_count>: Remove.
3092 (tui_add_content_elements, tui_free_data_content): Don't declare.
3093 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3094 (init_content_element): Remove DATA_WIN case. Add assert.
3095 (tui_add_content_elements): Remove.
3096 (tui_data_window): Update.
3097 (tui_free_data_content): Remove.
3098 (free_content_elements): Remove DATA_WIN case.
3099
115ac53b
TT
31002019-06-25 Tom Tromey <tom@tromey.com>
3101
3102 * tui/tui-data.c (tui_data_item_window): Update.
3103 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3104 * tui/tui-windata.c (tui_display_all_data)
3105 (tui_display_data_from_line): Update.
3106 (tui_check_data_values): Remove.
3107 * tui/tui-regs.c (tui_show_register_group)
3108 (tui_display_reg_element_at_line): Update.
3109 * tui/tui-hooks.c (tui_register_changed)
3110 (tui_refresh_frame_and_register_information): Call
3111 tui_check_register_values.
3112 * tui/tui-data.h (struct tui_data_window) <data_content,
3113 data_content_count, data_type>: Remove.
3114 (enum tui_data_type): Remove.
3115
3116 * tui/tui-data.c (tui_data_window::clear_detail)
3117 (~tui_data_window): Update.
3118
eaf9738b
TT
31192019-06-25 Tom Tromey <tom@tromey.com>
3120
3121 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3122 declare.
3123 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3124 Rename from tui_first_data_item_displayed. Update.
3125 (tui_data_window::refresh_all)
3126 (tui_data_window::do_scroll_vertical): Update.
3127 * tui/tui-data.h (struct tui_data_window)
3128 <first_data_item_displayed>: Declare new method.
3129
31ca4723
TT
31302019-06-25 Tom Tromey <tom@tromey.com>
3131
3132 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3133 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3134 contents...
3135 (tui_initialize_static_data): ...here.
3136
41bcff7f
TT
31372019-06-25 Tom Tromey <tom@tromey.com>
3138
3139 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3140 (tui_display_registers_from, tui_check_register_values): Update.
3141 (tui_display_register): Remove win_info parameter; update.
3142 (tui_get_register): Change type of parameters.
3143 * tui/tui-data.h (struct tui_data_element): Remove.
3144 (union tui_which_element) <data>: Remove.
3145 <data_window>: Change type.
3146 (struct tui_data_item_window): New.
3147 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3148 case. Add assert.
3149 (~tui_data_item_window): New destructor.
3150 (free_content_elements): Remove DATA_ITEM_WIN case.
3151
d2802c33
TT
31522019-06-25 Tom Tromey <tom@tromey.com>
3153
3154 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3155 Remove.
3156
dd835f8b
TT
31572019-06-25 Tom Tromey <tom@tromey.com>
3158
3159 * tui/tui-data.h (struct tui_command_element): Remove.
3160 (union tui_which_element) <command>: Remove.
3161 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3162 assert.
3163 (free_content_elements): Remove CMD_WIN case.
3164
bd7db367
TT
31652019-06-25 Tom Tromey <tom@tromey.com>
3166
3167 * tui/tui-layout.c (tui_set_layout): Update.
3168 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3169 * tui/tui-data.c (layout_def): Update.
3170
3add462f
TT
31712019-06-25 Tom Tromey <tom@tromey.com>
3172
3173 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3174 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3175 (tui_source_window_base::set_new_height): Update.
3176 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3177 Update.
3178 (tui_set_locator_fullname, tui_set_locator_info)
3179 (tui_show_frame_info): Update.
3180 * tui/tui-source.c (tui_set_source_content)
3181 (tui_source_is_displayed): Update.
3182 * tui/tui-layout.c (show_source_disasm_command, show_data)
3183 (show_source_or_disasm_and_command): Update.
3184 * tui/tui-disasm.c (tui_set_disassem_content)
3185 (tui_get_begin_asm_address): Update.
3186 * tui/tui-data.h (struct tui_locator_element): Remove.
3187 (union tui_which_element) <locator>: Remove.
3188 (struct tui_locator_window): New.
3189 (tui_locator_win_info_ptr): Change return type.
3190 * tui/tui-data.c (_locator): Change type.
3191 (tui_locator_win_info_ptr): Change return type.
3192 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3193 (tui_alloc_content): Add assert.
3194
489e9d8b
TT
31952019-06-25 Tom Tromey <tom@tromey.com>
3196
3197 * tui/tui-winsource.c
3198 (tui_exec_info_window::maybe_allocate_content): New method.
3199 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3200 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3201 (make_source_or_disasm_window): Add cast.
3202 * tui/tui-data.h (union tui_which_element) <simple_string>:
3203 Remove.
3204 (struct tui_source_info): New.
3205 (struct tui_source_window_base) <execution_info>: Change type.
3206 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3207 case, and add assert.
3208 (tui_alloc_content): Add assert.
3209
c3fabb7d
TT
32102019-06-25 Tom Tromey <tom@tromey.com>
3211
3212 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3213 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3214 * tui/tui-data.c (tui_alloc_win_info): Remove.
3215
bbc228ee
TT
32162019-06-25 Tom Tromey <tom@tromey.com>
3217
3218 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3219 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3220 can_highlight.
3221
5fcee43a
TT
32222019-06-25 Tom Tromey <tom@tromey.com>
3223
3224 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3225 make_visible_with_new_height method.
3226 (tui_win_info::make_visible_with_new_height): New method.
3227 (tui_source_window_base::do_make_visible_with_new_height)
3228 (tui_data_window::do_make_visible_with_new_height)
3229 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3230 (make_visible_with_new_height): Remove.
3231 (tui_resize_all, tui_adjust_win_heights): Use
3232 make_visible_with_new_height method.
3233 * tui/tui-data.h (struct tui_win_info)
3234 <do_make_visible_with_new_height, make_visible_with_new_height>:
3235 New methods.
3236 (struct tui_source_window_base, struct tui_data_window)
3237 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3238 methods.
3239
d83f1fe6
TT
32402019-06-25 Tom Tromey <tom@tromey.com>
3241
3242 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3243 method.
3244 (update_tab_width): Call update_tab_width method.
3245 * tui/tui-data.h (struct tui_win_info)
3246 (struct tui_source_window_base) <update_tab_width>: New methods.
3247
17374de4
TT
32482019-06-25 Tom Tromey <tom@tromey.com>
3249
3250 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3251 parameter.
3252 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3253 parameter.
3254 (tui_gen_win_info::make_visible): Update.
3255 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3256 parameter.
3257 * tui/tui-data.h (enum tui_box): New enum.
3258 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3259
f936bca2
TT
32602019-06-25 Tom Tromey <tom@tromey.com>
3261
3262 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3263 init_and_make_win for EXEC_INFO_WIN.
3264 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3265 longer inline.
3266 (struct tui_win_info) <~tui_win_info>: Inline.
3267 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3268 Don't declare.
3269 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3270 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3271 Remove.
3272 (tui_initialize_static_data): Update.
3273 (~tui_gen_win_info): Handle more cleanup here.
3274 (~tui_source_window_base): Delete "execution_info".
3275 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3276
d6ba6a11
TT
32772019-06-25 Tom Tromey <tom@tromey.com>
3278
3279 * tui/tui-layout.c (make_command_window): Don't set
3280 can_highlight.
3281 (show_source_disasm_command): Call the reset method.
3282 (show_data): Don't set can_highlight. Call the reset method.
3283 (tui_gen_win_info::reset): Rename from init_gen_win_info
3284 (init_and_make_win): Simplify. Return tui_gen_win_info.
3285 (show_source_or_disasm_and_command): Call the reset method.
3286 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3287 (struct tui_cmd_window): Set can_highlight.
3288
48a3bd16
TT
32892019-06-25 Tom Tromey <tom@tromey.com>
3290
3291 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3292 from make_visible.
3293 (tui_make_visible, tui_make_invisible): Rewrite.
3294 (tui_win_info::make_visible): Remove.
3295 (tui_source_window_base::make_visible): Update.
3296 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3297 method. Moved from...
3298 (struct tui_win_info) <make_visible>: ...here.
3299
c3bd716f
TT
33002019-06-25 Tom Tromey <tom@tromey.com>
3301
3302 * tui/tui-winsource.c
3303 (tui_source_window_base::do_scroll_horizontal): Remove direction
3304 parameter.
3305 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3306 direction parameter.
3307 * tui/tui-win.c (tui_win_info::forward_scroll)
3308 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3309 (tui_win_info::right_scroll): Update.
3310 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3311 direction parameter.
3312 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3313 direction parameter.
3314 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3315 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3316 Remove direction parameter.
3317 (struct tui_source_window_base, struct tui_source_window)
3318 (struct tui_disasm_window, struct tui_data_window)
3319 (struct tui_cmd_window): Update.
3320
21c32dca
TT
33212019-06-25 Tom Tromey <tom@tromey.com>
3322
3323 * tui/tui-winsource.h (tui_set_exec_info_content)
3324 (tui_show_exec_info_content, tui_erase_exec_info_content)
3325 (tui_clear_exec_info_content, tui_update_exec_info): Change
3326 argument to tui_source_window_base.
3327 * tui/tui-winsource.c (tui_set_exec_info_content)
3328 (tui_show_exec_info_content, tui_erase_exec_info_content)
3329 (tui_clear_exec_info_content, tui_update_exec_info): Change
3330 argument to tui_source_window_base.
3331
73fbdc65
TT
33322019-06-25 Tom Tromey <tom@tromey.com>
3333
3334 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3335 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3336
33325343
TT
33372019-06-25 Tom Tromey <tom@tromey.com>
3338
3339 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3340 check.
3341
29d2c474
TT
33422019-06-25 Tom Tromey <tom@tromey.com>
3343
3344 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3345 type to void.
3346 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3347 type to void.
3348 * tui/tui-source.c (tui_set_source_content): Update.
3349 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3350
152f3f4b
TT
33512019-06-25 Tom Tromey <tom@tromey.com>
3352
3353 * tui/tui-win.c (window_name_completer, tui_set_focus)
3354 (tui_all_windows_info): Use name method.
3355 * tui/tui-data.h (struct tui_gen_win_info)
3356 (struct tui_source_window, struct tui_disasm_window)
3357 (struct tui_data_window, struct tui_cmd_window) <name>: New
3358 method.
3359 (tui_win_name): Don't declare.
3360 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3361 (tui_win_name): Remove.
3362
be4da588
TT
33632019-06-25 Tom Tromey <tom@tromey.com>
3364
3365 * tui/tui-winsource.h (tui_update_source_window)
3366 (tui_update_source_window_as_is): Change parameter type.
3367 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3368 to be a tui_source_window_base.
3369 (tui_update_source_window_as_is): Likewise.
3370 * tui/tui-win.c (make_visible_with_new_height): Update.
3371
5b81daba
TT
33722019-06-25 Tom Tromey <tom@tromey.com>
3373
3374 * tui/tui-winsource.c (tui_erase_source_content)
3375 (tui_show_source_content, tui_show_exec_info_content)
3376 (tui_erase_exec_info_content): Use refresh_window method.
3377 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3378 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3379 from tui_refresh_win.
3380 (tui_data_window::refresh_window): New method.
3381 (tui_win_info::refresh, tui_source_window_base::refresh)
3382 (tui_refresh_all): Use refresh_window method.
3383 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3384 method.
3385 * tui/tui-regs.c (tui_display_register): Call refresh_window
3386 method.
3387 * tui/tui-layout.c (show_source_disasm_command)
3388 (show_source_or_disasm_and_command): Call refresh_window method.
3389 * tui/tui-data.h (struct tui_gen_win_info)
3390 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3391 New method.
3392
cb2ce893
TT
33932019-06-25 Tom Tromey <tom@tromey.com>
3394
3395 * tui/tui.c (tui_rl_other_window, tui_enable)
3396 (tui_is_window_visible, tui_get_command_dimension): Update.
3397 * tui/tui-winsource.c (tui_update_source_window_as_is)
3398 (tui_clear_source_content, tui_erase_source_content)
3399 (tui_show_source_line, tui_source_window_base::refill)
3400 (tui_source_window_base::do_scroll_horizontal)
3401 (tui_source_window_base::set_is_exec_point_at)
3402 (tui_update_breakpoint_info, tui_set_exec_info_content)
3403 (tui_alloc_source_buffer, tui_line_is_displayed)
3404 (tui_addr_is_displayed): Update.
3405 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3406 (tui_check_and_display_highlight_if_needed)
3407 (tui_win_info::make_visible, tui_win_info::refresh)
3408 (tui_refresh_all): Update.
3409 * tui/tui-windata.c (tui_first_data_item_displayed)
3410 (tui_delete_data_content_windows, tui_erase_data_content)
3411 (tui_display_all_data, tui_data_window::refresh_all)
3412 (tui_check_data_values): Update.
3413 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3414 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3415 (tui_win_info::backward_scroll, tui_refresh_all_win)
3416 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3417 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3418 (tui_source_window_base::set_new_height)
3419 (tui_data_window::set_new_height)
3420 (make_invisible_and_set_new_height)
3421 (make_visible_with_new_height, new_height_ok)
3422 (parse_scrolling_args): Update.
3423 * tui/tui-stack.c (tui_show_frame_info): Update.
3424 * tui/tui-source.c (tui_set_source_content)
3425 (tui_set_source_content_nil, tui_source_is_displayed)
3426 (tui_source_window::do_scroll_vertical): Update.
3427 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3428 (tui_display_registers_from, tui_display_reg_element_at_line)
3429 (tui_check_register_values, tui_reg_command): Update.
3430 * tui/tui-layout.c (tui_default_win_height)
3431 (show_source_disasm_command, show_data, init_and_make_win)
3432 (show_source_or_disasm_and_command): Update.
3433 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3434 (tui_redisplay_readline, tui_mld_flush)
3435 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3436 (tui_getc): Update.
3437 * tui/tui-disasm.c (tui_set_disassem_content)
3438 (tui_disasm_window::do_scroll_vertical): Update.
3439 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3440 Now virtual.
3441 (struct tui_win_info): Derive from tui_gen_win_info.
3442 <~tui_win_info>: Mark as override.
3443 <generic>: Remove member.
3444 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3445 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3446 (~tui_data_window, ~tui_win_info)
3447 (tui_free_all_source_wins_content): Update.
3448 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3449
ab313b35
TT
34502019-06-25 Tom Tromey <tom@tromey.com>
3451
3452 * tui/tui-layout.c (init_and_make_win): Use new.
3453 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3454 destructor, initializers.
3455 (tui_alloc_generic_win_info): Don't declare.
3456 * tui/tui-data.c (_locator): Add argument to constructor.
3457 (source_win, disasm_win): New globals.
3458 (exec_info): Remove.
3459 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3460 Update.
3461 (tui_alloc_generic_win_info): Remove.
3462 (init_content_element): Use new.
3463 (tui_win_info::tui_win_info): Update.
3464 (free_content_elements) <case DATA_WIN>: Use delete.
3465
dc2c33e4
TT
34662019-06-25 Tom Tromey <tom@tromey.com>
3467
3468 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3469 * tui/tui-windata.c (tui_first_data_item_displayed)
3470 (tui_delete_data_content_windows): Update.
3471 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3472 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3473 (tui_display_registers_from, tui_check_register_values): Update.
3474 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3475 pointer.
3476 * tui/tui-data.c (init_content_element): Update. Allocate the new
3477 window.
3478 (tui_free_data_content): Update.
3479 (free_content_elements) <case DATA_WIN>: Free the window.
3480
214a5cbe
TT
34812019-06-25 Tom Tromey <tom@tromey.com>
3482
3483 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3484 Update.
3485 * tui/tui-layout.c (make_command_window)
3486 (show_source_disasm_command, show_data, init_and_make_win)
3487 (show_source_or_disasm_and_command): Update.
3488 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3489 method.
3490 <can_highight, is_highlighted>: Now bool.
3491 (tui_set_win_highlight): Don't declare.
3492 * tui/tui-data.c (tui_set_win_highlight): Remove.
3493
8e2daf15
TT
34942019-06-25 Tom Tromey <tom@tromey.com>
3495
3496 * tui/tui-wingeneral.c (make_visible): Remove check of window
3497 type.
3498
8903bd8a
TT
34992019-06-25 Tom Tromey <tom@tromey.com>
3500
3501 * tui/tui-win.c (tui_win_info::max_height)
3502 (tui_cmd_window::max_height): New methods.
3503 (new_height_ok): Call max_height.
3504 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3505 <max_height>: New method.
3506
3f02ce1e
TT
35072019-06-25 Tom Tromey <tom@tromey.com>
3508
3509 * tui/tui-win.c (tui_source_window_base::set_new_height)
3510 (tui_data_window::set_new_height): New methods.
3511 (make_invisible_and_set_new_height): Call set_new_height method.
3512 * tui/tui-data.h (struct tui_win_info)
3513 (struct tui_source_window_base, struct tui_data_window)
3514 <set_new_height>: New method.
3515
1825f487
TT
35162019-06-25 Tom Tromey <tom@tromey.com>
3517
3518 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3519 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3520 tui_refresh_data_win.
3521 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3522 method.
3523 (tui_refresh_all_win): Call the refresh_all method.
3524 (tui_set_focus): Likewise.
3525 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3526 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3527 Likewise.
3528
ad54d15b
TT
35292019-06-25 Tom Tromey <tom@tromey.com>
3530
3531 * tui/tui-winsource.h (tui_refill_source_window)
3532 (tui_set_is_exec_point_at): Don't declare.
3533 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3534 (tui_source_window_base::refill): Rename from
3535 tui_refill_source_window.
3536 (tui_source_window_base::do_scroll_horizontal): Update.
3537 (tui_source_window_base::set_is_exec_point_at): Rename from
3538 tui_set_is_exec_point_at.
3539 (tui_update_all_breakpoint_info): Update.
3540 * tui/tui-stack.c (tui_show_frame_info): Update.
3541 * tui/tui-layout.c (show_data): Add cast.
3542 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3543 * tui/tui-data.h (struct tui_source_window_base) <refill,
3544 set_is_exec_point_at>: New methods.
3545 (tui_source_windows, tui_add_to_source_windows): Update types.
3546 (tui_add_to_source_windows): Remove redundant declaration.
3547 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3548 (tui_source_windows): Change return type.
3549 (tui_clear_source_windows_detail): Update.
3550 (tui_add_to_source_windows): Change type of parameter.
3551 (tui_free_all_source_wins_content): Update.
3552
2042b506
TT
35532019-06-25 Tom Tromey <tom@tromey.com>
3554
3555 * tui/tui-wingeneral.c (tui_win_info::refresh)
3556 (tui_source_window_base::refresh): New methods.
3557 (tui_refresh_all): Call the refresh method.
3558 * tui/tui-data.h (struct tui_win_info)
3559 (struct tui_source_window_base) <refresh>: New method.
3560
56122977
TT
35612019-06-25 Tom Tromey <tom@tromey.com>
3562
3563 * tui/tui.h (tui_is_window_visible): Return bool.
3564 * tui/tui.c (tui_is_window_visible): Return bool.
3565 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3566 (tui_make_visible, tui_make_invisible)
3567 (tui_win_info::make_visible)
3568 (tui_source_window_base::make_visible, make_all_visible)
3569 (tui_make_all_visible, tui_make_all_invisible): Update.
3570 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3571 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3572 bool.
3573 (struct tui_win_info, struct tui_source_window_base)
3574 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3575 * tui/tui-data.c (tui_init_generic_part): Update.
3576
cda37efb
TT
35772019-06-25 Tom Tromey <tom@tromey.com>
3578
3579 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3580 (tui_source_window_base::make_visible): New methods.
3581 (make_all_visible): Make method call.
3582 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3583 (struct tui_source_window_base, struct tui_cmd_window): Override
3584 make_visible.
3585 (tui_win_is_source_type): Don't declare.
3586 * tui/tui-data.c (tui_win_is_source_type): Remove.
3587
6a0ee02c
TT
35882019-06-25 Tom Tromey <tom@tromey.com>
3589
3590 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3591 NULL check.
3592
63901aec
TT
35932019-06-25 Tom Tromey <tom@tromey.com>
3594
3595 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3596 Inline constructor. Add initializers for members.
3597 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3598 constructors; now inline in class.
3599
ceb13a13
TT
36002019-06-25 Tom Tromey <tom@tromey.com>
3601
3602 * tui/tui-regs.c (tui_show_registers): Update.
3603 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3604 bool.
3605 * tui/tui-data.c (tui_data_window::clear_detail)
3606 (tui_data_window): Update.
3607
238eb706
TT
36082019-06-25 Tom Tromey <tom@tromey.com>
3609
3610 * tui/tui-windata.c (tui_display_all_data)
3611 (tui_display_data_from_line, tui_display_data_from)
3612 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3613 Update.
3614 * tui/tui-regs.c (tui_last_regs_line_no)
3615 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3616 (tui_show_registers, tui_show_register_group)
3617 (tui_display_registers_from, tui_display_reg_element_at_line)
3618 (tui_display_registers_from_line, tui_check_register_values)
3619 (tui_reg_next, tui_reg_prev): Update.
3620 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3621 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3622 tui_data_window.
3623 (struct tui_win_info) <detail>: Remove. Add new fields from
3624 tui_data_info.
3625 (TUI_DATA_WIN): Add cast.
3626 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3627 (~tui_data_window): Simplify.
3628
81491aa0
TT
36292019-06-25 Tom Tromey <tom@tromey.com>
3630
3631 * tui/tui-layout.c (show_source_disasm_command)
3632 (show_source_or_disasm_and_command): Update.
3633 * tui/tui-io.c (update_cmdwin_start_line)
3634 (tui_redisplay_readline): Update.
3635 * tui/tui-data.h (struct tui_command_info): Remove.
3636 (struct tui_win_info) <detail>: Remove command_info member.
3637 (struct tui_data_window) <start_line>: New member, from
3638 tui_command_info.
3639 (TUI_CMD_WIN): Add casts.
3640
e6e41501
TT
36412019-06-25 Tom Tromey <tom@tromey.com>
3642
3643 * tui/tui-winsource.c (tui_update_source_window)
3644 (tui_refill_source_window)
3645 (tui_source_window_base::do_scroll_horizontal)
3646 (tui_update_breakpoint_info, tui_set_exec_info_content)
3647 (tui_show_exec_info_content, tui_erase_exec_info_content)
3648 (tui_clear_exec_info_content): Update.
3649 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3650 Update.
3651 * tui/tui-win.c (make_invisible_and_set_new_height)
3652 (make_visible_with_new_height): Update.
3653 * tui/tui-source.c (tui_set_source_content)
3654 (tui_show_symtab_source): Update.
3655 * tui/tui-layout.c (extract_display_start_addr)
3656 (show_source_disasm_command, show_data)
3657 (make_source_or_disasm_window)
3658 (show_source_or_disasm_and_command): Update.
3659 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3660 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3661 "gdbarch".
3662 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3663 to tui_source_window_base.
3664 (struct tui_win_info) <detail>: Remove source_info member.
3665 (struct tui_source_window_base) <has_locator>: Inline.
3666 Move contents from tui_source_info; rename has_locator member to
3667 m_has_locator.
3668 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3669 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3670 header file.
3671 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3672 Simplify.
3673 (tui_free_all_source_wins_content): Cast to
3674 tui_source_window_base.
3675
44f0e208
TT
36762019-06-25 Tom Tromey <tom@tromey.com>
3677
3678 * tui/tui-win.c (make_invisible_and_set_new_height)
3679 (make_visible_with_new_height): Call has_locator method.
3680 * tui/tui-layout.c (show_source_disasm_command, show_data)
3681 (show_source_or_disasm_and_command): Update for bool change.
3682 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3683 (tui_win_info) <has_locator>: New method.
3684 (struct tui_source_window_base) <has_locator>: New method.
3685 (tui_win_has_locator): Don't declare.
3686 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3687 from tui_win_has_locator.
3688 (tui_source_window_base): Use false, not FALSE.
3689
7778b912
TT
36902019-06-25 Tom Tromey <tom@tromey.com>
3691
3692 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3693 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3694 clear_detail method directly.
3695 (tui_clear_win_detail): Remove.
3696
f83d391c
TT
36972019-06-25 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3700 "this", not TUI_DISASM_WIN.
3701
13446e05
TT
37022019-06-25 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3705 declare.
3706 * tui/tui-winsource.c
3707 (tui_source_window_base::do_scroll_horizontal): Rename from
3708 tui_horizontal_source_scroll.
3709 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3710 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3711 from tui_vertical_data_scroll.
3712 * tui/tui-win.h (tui_scroll): Don't declare.
3713 * tui/tui-win.c (tui_win_info::forward_scroll)
3714 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3715 (tui_win_info::right_scroll): Rename and update.
3716 (tui_scroll_forward_command, tui_scroll_backward_command)
3717 (tui_scroll_left_command, tui_scroll_right_command): Update.
3718 (tui_scroll): Remove.
3719 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3720 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3721 from tui_vertical_source_scroll.
3722 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3723 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3724 from tui_vertical_disassem_scroll.
3725 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3726 do_scroll_horizontal>: New methods.
3727 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3728 Likewise.
3729 (struct tui_source_window_base): Add do_scroll_horizontal.
3730 (struct tui_source_window, struct tui_disasm_window): Add
3731 do_scroll_vertical.
3732 (struct tui_data_window, struct tui_cmd_window): Add
3733 do_scroll_horizontal and do_scroll_vertical.
3734 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3735
5cf82909
TT
37362019-06-25 Tom Tromey <tom@tromey.com>
3737
3738 * tui/tui-data.h (struct tui_source_window_base): New struct.
3739 (struct tui_source_window): Derive from tui_source_window_base.
3740 (struct tui_disasm_window): New struct.
3741 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3742 from tui_source_window::clear_detail.
3743 (tui_source_window_base): Rename from tui_source_window.
3744 (~tui_source_window_base): Rename from ~tui_source_window.
3745 (tui_alloc_win_info): Create a tui_disasm_window.
3746
ee1d42d6
TT
37472019-06-25 Tom Tromey <tom@tromey.com>
3748
3749 * tui/tui-data.h (struct tui_source_window)
3750 (struct tui_data_window): Declare destructors.
3751 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3752 destructors.
3753 (tui_win_info): Simplify.
3754
b4eb2452
TT
37552019-06-25 Tom Tromey <tom@tromey.com>
3756
3757 * tui/tui-winsource.c (tui_display_main)
3758 (tui_update_source_windows_with_addr)
3759 (tui_update_all_breakpoint_info): Update.
3760 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3761 (new_height_ok, parse_scrolling_args): Update.
3762 * tui/tui-stack.c (tui_show_frame_info): Update.
3763 * tui/tui-data.h (struct tui_list): Remove.
3764 (tui_source_windows): Return a reference to a std::vector.
3765 * tui/tui-data.c (source_windows): Now a std::vector.
3766 (tui_source_windows): Change return type.
3767 (tui_clear_source_windows): Rewrite.
3768 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3769 (tui_free_all_source_wins_content): Rewrite.
3770
8761a91b
TT
37712019-06-25 Tom Tromey <tom@tromey.com>
3772
3773 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3774 (struct tui_data_window, struct tui_cmd_window): Declare
3775 clear_detail method.
3776 * tui/tui-data.c (tui_source_window::clear_detail)
3777 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3778 methods.
3779 (tui_clear_win_detail): Simplify.
3780
0ed69eda
TT
37812019-06-25 Tom Tromey <tom@tromey.com>
3782
3783 * tui/tui-layout.c (make_source_window, make_disasm_window)
3784 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3785 Return the new window.
3786 (show_source_disasm_command, show_data)
3787 (show_source_or_disasm_and_command): Update.
3788
82432e10
TT
37892019-06-25 Tom Tromey <tom@tromey.com>
3790
3791 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3792 parameter. Return the new window.
3793 (show_source_disasm_command): Update and remove NULL check.
3794 (show_source_or_disasm_and_command): Update.
3795
ec328aa5
TT
37962019-06-25 Tom Tromey <tom@tromey.com>
3797
3798 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3799
33b906ab
TT
38002019-06-25 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui-data.h (struct tui_win_info): Make constructor
3803 protected. Make destructor virtual. Add initializers.
3804 (tui_source_window, tui_data_window, tui_cmd_window): New
3805 classes.
3806 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3807 constructor. Add "type" parameter.
3808 (tui_source_window, tui_data_window, tui_cmd_window): New
3809 constructors.
3810 (tui_alloc_win_info): Instantiate the appropriate subclass.
3811
e7e11af4
TT
38122019-06-25 Tom Tromey <tom@tromey.com>
3813
3814 * tui/tui-win.c (tui_resize_all): Use delete.
3815 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3816 destructor.
3817 (tui_free_window): Don't declare.
3818 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3819 Update.
3820
6792b55e
TT
38212019-06-25 Tom Tromey <tom@tromey.com>
3822
3823 * tui/tui-data.h (struct tui_win_info): Add constructor.
3824 * tui/tui-data.c (tui_alloc_win_info): Use new.
3825 (tui_free_window): Use delete.
3826
f95675e1
TT
38272019-06-22 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3830 declare.
3831 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3832
5bff081c
TT
38332019-06-22 Tom Tromey <tom@tromey.com>
3834
3835 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3836 declare.
3837 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3838
47e3f474
TV
38392019-06-22 Tom de Vries <tdevries@suse.de>
3840
3841 * dwarf2read.c (create_addrmap_from_aranges)
3842 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3843 instead of '%zu'.
3844
fd5866f6
SM
38452019-06-21 Simon Marchi <simon.marchi@efficios.com>
3846
3847 * dwarf2read.h (dwarf2_section_info_def): Remove.
3848 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3849 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3850 std::vector<dwarf2_section_info>.
3851 (struct dwo_file) <~dwo_file>: Remove.
3852 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3853 types field.
3854 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3855 (dwarf2_read_debug_names): Likewise.
3856 (create_debug_types_hash_table): Change parameter type to
3857 array_view, adjust code accordingly.
3858 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3859 (partial_die_info::fixup): Likewise.
3860 (determine_prefix): Likewise.
3861 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3862
fb1eb2f9
SM
38632019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3864
3865 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3866 gdb_bfd_ref_ptr.
3867 <~dwo_file>: Remove call to gdb_bfd_unref.
3868 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3869 gdb_bfd_ref_ptr::get.
3870
51ac9db5
SM
38712019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3872
3873 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3874 type to htab_up.
3875 * dwarf2read.c (struct dwo_file): Initialize fields.
3876 <~dwo_file>: New.
3877 (free_dwo_file): Remove, move content to ~dwo_file.
3878 (struct dwo_file_deleter): Remove.
3879 (dwo_file_up>: Remove custom deleter.
3880 (free_dwo_files): Remove.
3881 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3882 dwo_files.
3883 (process_skeletonless_type_units): Call unique_ptr::get.
3884 (allocate_dwo_file_hash_table): Add deleter to created hash
3885 table. Change return type to htab_up.
3886 (lookup_dwo_file_slot): Don't memset dwo_file, call
3887 unique_ptr::get.
3888 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3889 (create_dwo_unit_in_dwp_v2): Likewise.
3890 (open_and_init_dwo_file): Likewise.
3891 (free_dwo_file_from_slot): Remove.
3892
dc4ccb6f
SM
38932019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3894
3895 * dwarf2read.h (struct dwarf2_section_info) <readin,
3896 is_virtual>: Change type to bool.
3897 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3898 true instead of 1.
3899
e6a1c5cb
TT
39002019-06-19 Tom Tromey <tom@tromey.com>
3901
3902 * tui/tui-data.h (tui_init_content_element): Don't declare.
3903
6f6ffbeb
TT
39042019-06-19 Tom Tromey <tom@tromey.com>
3905
3906 * tui/tui-data.h (tui_init_win_info): Don't declare.
3907
f23f598e
TV
39082019-06-19 Tom de Vries <tdevries@suse.de>
3909
3910 * dwarf2read.h (abstract_to_concrete): Change type to
3911 std::unordered_map<sect_offset, std::vector<sect_offset>,
3912 gdb::hash_enum<sect_offset>>.
3913
680e1bee
TT
39142019-06-19 Tom Tromey <tromey@adacore.com>
3915
3916 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3917 EVAL_AVOID_SIDE_EFFECTS specially.
3918
dcf37923
TT
39192019-06-19 Tom Tromey <tromey@adacore.com>
3920
3921 * source-cache.c (highlighter): New global.
3922 (source_cache::get_source_lines): Create a highlighter on demand.
3923
494986d5
AB
39242019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3925
3926 * defs.h (deprecated_interactive_hook): Delete declaration.
3927 * interps.c (clear_interpreter_hooks): Remove use of
3928 deprecated_interactive_hook.
3929 * top.c (deprecated_interactive_hook): Delete definition.
3930 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3931
3360b6e7
TV
39322019-06-18 Tom de Vries <tdevries@suse.de>
3933
3934 PR gdb/24515
3935 * dwarf2read.h (abstract_to_concrete): Change type from
3936 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3937 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3938 * dwarf2read.c (read_variable): Update.
3939 (dwarf2_fetch_die_loc_sect_off): Update.
3940
310b3441
TV
39412019-06-17 Tom de Vries <tdevries@suse.de>
3942
3943 PR gdb/24617
3944 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3945 accessing parent[parent_len - 1].
3946
ba9777be
PP
39472019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3948
3949 PR gdb/24364
3950 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3951 call dtrace_process_dof with NULL dof.
3952
2b9f6e89
TV
39532019-06-16 Tom de Vries <tdevries@suse.de>
3954
3955 PR gdb/24445
3956 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3957
431b3ead
TT
39582019-06-16 Tom Tromey <tom@tromey.com>
3959
3960 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3961 (make_all_visible): Use address of member.
3962
d04b44a1
TT
39632019-06-16 Tom Tromey <tom@tromey.com>
3964
3965 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3966 (tui_free_window, free_content, free_content_elements): Remove
3967 unnecessary cast.
3968 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3969 cast.
3970 * tui/tui-regs.c (tui_show_register_group)
3971 (tui_display_registers_from, tui_display_reg_element_at_line):
3972 Remove unnecessary cast.
3973
bf5142e7
AB
39742019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3975
3976 * linux-nat.c (normal_mask): Delete.
3977 (_initialize_linux_nat): Don't initialise normal_mask.
3978
c4973306
SM
39792019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3980
3981 PR gdb/24445
3982 * dwarf-index-write.h (write_psymtabs_to_index): Add
3983 dwz_basename parameter.
3984 * dwarf-index-write.c (write_gdbindex): Move file writing to
3985 write_gdbindex_1. Change return type void.
3986 (assert_file_size): Move up, remove filename parameter.
3987 (write_gdbindex_1): New function.
3988 (write_debug_names): Change return type to void, call
3989 assert_file_size.
3990 (struct index_wip_file): New struct.
3991 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3992 file logic to index_wip_file. Write index for dwz file if
3993 needed.
3994 (save_gdb_index_command): Pass basename of dwz file, if present.
3995 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3996 build-id of dwz file, if present.
3997 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3998 (dwarf2_get_dwz_file): Likewise.
3999 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4000 (dwarf2_get_dwz_file): Likewise.
4001
395f9c91
TT
40022019-06-16 Tom Tromey <tom@tromey.com>
4003
4004 * coffread.c (process_coff_symbol): Use xstrdup.
4005 * value.c (create_internalvar): Use xstrdup.
4006
cafb3438
TT
40072019-06-16 Tom Tromey <tom@tromey.com>
4008
4009 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4010 * breakpoint.c (stopin_command, stopat_command)
4011 (until_break_command, decode_location_default): Remove unnecessary
4012 cast.
4013 * utils.c (subset_compare): Remove unnecessary cast.
4014 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4015 cast.
4016 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4017 cast.
4018 * infcmd.c (path_command): Remove unnecessary cast.
4019 * coffread.c (decode_type): Remove unnecessary cast.
4020 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4021 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4022 * tui/tui-stack.c (tui_show_locator_content)
4023 (tui_show_frame_info): Remove unnecessary cast.
4024 * tui/tui-win.c (tui_scroll_forward_command)
4025 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4026 (parse_scrolling_args): Remove unnecessary cast.
4027 * tui/tui-data.c (init_win_info, tui_del_window)
4028 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4029 (free_content_elements): Remove unnecessary cast.
4030 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4031 unnecessary cast.
4032 * tui/tui-source.c (tui_set_source_content)
4033 (tui_vertical_source_scroll): Remove unnecessary cast.
4034 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4035 cast.
4036 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4037 * tui/tui-regs.c (tui_display_registers_from)
4038 (tui_display_register): Remove unnecessary cast.
4039 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4040 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4041 (make_visible): Remove unnecessary cast.
4042 * tui/tui-winsource.c (tui_erase_source_content)
4043 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4044 unnecessary cast.
4045 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4046 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4047 * stabsread.c (read_type, read_array_type, read_range_type):
4048 Remove unnecessary cast.
4049 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4050 (parse_symbol, parse_type, upgrade_type, parse_external)
4051 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4052 unnecessary cast.
4053 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4054
730ead81
TT
40552019-06-16 Tom Tromey <tom@tromey.com>
4056
4057 * tui/tui-data.c (tui_alloc_generic_win_info)
4058 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4059 checks.
4060
584a927c
AB
40612019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4062 Andrew Burgess <andrew.burgess@embecosm.com>
4063
4064 * f-typeprint.c (f_print_type): Don't return early for not
4065 associated or not allocated types.
4066 (f_type_print_varspec_suffix): Add print_rank parameter and print
4067 ranks of array types in case they dangling.
4068 (f_type_print_base): Add print_rank parameter.
4069
30056ea0
AB
40702019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4071
4072 * NEWS: Mention new MI commands.
4073 * break-catch-throw.c (enum exception_event_kind): Move to
4074 breakpoint.h.
4075 (print_mention_exception_catchpoint): Output text as a single
4076 message.
4077 (catch_exception_command_1): Rename to...
4078 (catch_exception_event): ...this, make non-static, update header
4079 command, and change some parameter types.
4080 (catch_catch_command): Update for changes to
4081 catch_exception_command_1.
4082 (catch_throw_command): Likewise.
4083 (catch_rethrow_command): Likewise.
4084 * breakpoint.c (enum exception_event_kind): Delete.
4085 * breakpoint.h (enum exception_event_kind): Moved here from
4086 break-catch-throw.c.
4087 (catch_exception_event): Declare.
4088 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4089 (mi_cmd_catch_throw): New function.
4090 (mi_cmd_catch_rethrow): New function.
4091 (mi_cmd_catch_catch): New function.
4092 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4093 'catch-catch' entries.
4094 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4095 (mi_cmd_catch_rethrow): Declare.
4096 (mi_cmd_catch_catch): Declare.
4097
ec8e2b6d
AB
40982019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4099
4100 * annotate.c (annotate_source_line): Change return type to void,
4101 update implementation to match.
4102 * annotate.h (annotate_source_line): Change return type to void,
4103 update header comment.
4104 * stack.c (print_frame_info): Don't change what frame information
4105 is printed based on whether annotations are on or not.
4106
0d3abd8c
AB
41072019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4108
4109 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4110 (annotate_source): Make static.
4111 (annotate_source_line): Moved from source.c and renamed from
4112 identify_source_line. Update the return type.
4113 * annotate.h (annotate_source): Delete declaration.
4114 (annotate_source_line): Declaration moved from source.h, and
4115 renamed from identify_source_line. Return type updated.
4116 * source.c (identify_source_line): Moved to annotate.c and renamed
4117 to annotate_source_line.
4118 (info_line_command): Remove check of annotation_level.
4119 * source.h (identify_source_line): Move declaration to annotate.h
4120 and rename to annotate_source_line.
4121 * stack.c: Add 'annotate.h' include.
4122 (print_frame_info): Remove check of annotation_level before
4123 calling annotate_source_line.
4124
00df30ae
AB
41252019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4126
4127 * source-cache.c (source_cache::get_plain_source_lines): Use
4128 open_source_file_with_line_charpos instead of just
4129 open_source_file, remove call to find_source_lines.
4130 (source_cache::get_source_lines): Likewise.
4131 * source.c (find_source_lines): Make static.
4132 (get_filename_and_charpos): Renamed into...
4133 (open_source_file_with_line_charpos): ..this along with changes to
4134 return a scoped_fd, and some other minor clean ups.
4135 (identify_source_line): Use open_source_file_with_line_charpos.
4136 (search_command_helper): Use open_source_file_with_line_charpos
4137 instead of just open_source_file, remove call to
4138 find_source_lines.
4139 * source.h (open_source_file_with_line_charpos): Declare new
4140 function.
4141 (find_source_lines): Delete declaration.
4142
afda45a2
AB
41432019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4144
4145 * source.c (get_filename_and_charpos): Remove fullname
4146 parameter.
4147 (identify_source_line): Update call to get_filename_and_charpos.
4148
0735b091
TT
41492019-06-14 Tom Tromey <tromey@adacore.com>
4150
4151 PR gdb/24502:
4152 * ui-style.h (skip_ansi_escape): Update comment.
4153 * ui-file.h (class no_terminal_escape_file): New class.
4154 * ui-file.c (no_terminal_escape_file::write)
4155 (no_terminal_escape_file::puts): New methods.
4156 * cli/cli-logging.c (handle_redirections): Use
4157 no_terminal_escape_file.
4158
52ce35e2
TT
41592019-06-14 Tom Tromey <tromey@adacore.com>
4160
4161 * NEWS: Move convenience variable news above Python news.
4162
73cc7272
TT
41632019-06-14 Tom Tromey <tom@tromey.com>
4164
4165 * gnulib: Move directory to top-level.
4166 * configure.ac: Don't configure gnulib.
4167 * configure: Rebuild.
4168 * common/common-defs.h: Use new path to gnulib.
4169 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4170 (GNULIB_H): Remove.
4171 (INCGNU): Look in new gnulib location.
4172 (HFILES_NO_SRCDIR): Remove gnulib files.
4173 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4174 (generated_files): Remove GNULIB_H.
4175 ($(LIBGNU), all-lib): Remove targets.
4176 (distclean): Don't mention GNULIB_BUILDDIR.
4177 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4178
f5686554
TT
41792019-06-14 Tom Tromey <tromey@adacore.com>
4180
4181 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4182 Warn if symbol file does not provide any symbols.
4183
a0c1ffed
TT
41842019-06-14 Tom Tromey <tromey@adacore.com>
4185
4186 * source.c (find_and_open_source): Respect basenames_may_differ.
4187
7c39e397
AB
41882019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4189
4190 * annotate.c (annotate_breakpoints_invalid): Make use of
4191 scoped_restore_terminal_state.
4192 (annotate_frames_invalid): Likewise.
4193
f411722c
TT
41942019-06-14 Tom Tromey <tromey@adacore.com>
4195
4196 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4197 allow assignment to an internalvar.
4198
4268ec18
TT
41992019-06-14 Tom Tromey <tromey@adacore.com>
4200
4201 * ada-lex.l: Allow "_" in attribute names.
4202
abdb711e
TT
42032019-06-14 Tom Tromey <tromey@adacore.com>
4204
4205 PR gdb/24653:
4206 * regcache.c (registers_changed): Don't call alloca.
4207 * top.c (execute_command): Don't call alloca.
4208
4c048731
PA
42092019-06-13 Pedro Alves <palves@redhat.com>
4210
4211 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4212 'expression'. When parsing an expression, error out if there's
4213 junk after "unlimited".
4214 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4215 (do_set_command): Adjust calls to is_unlimited_literal.
4216
66eb1ed3
PA
42172019-06-13 Pedro Alves <palves@redhat.com>
4218
4219 * compile/compile.c (make_compile_options_def_group): Add braces
4220 around array_view initializer.
4221 * thread.c (make_thread_apply_all_options_def_group)
4222 (make_thread_apply_all_options_def_group): Likewise.
4223
3345721a
PA
42242019-06-13 Pedro Alves <palves@redhat.com>
4225
4226 * NEWS (New commands): Mention "maint test-options
4227 require-delimiter", "maint test-options unknown-is-error", "maint
4228 test-options unknown-is-operand" and "maint show
4229 test-options-completion-result".
4230 (New command options, command completion): New section.
4231 (Completion improvements): New section.
4232 Mention that you can abbreviate "unlimited".
4233
6206060d
PA
42342019-06-13 Pedro Alves <palves@redhat.com>
4235
4236 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4237 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4238 * unittests/cli-utils-selftests.c (test_parse_flags)
4239 (test_parse_flags_qcs): Delete.
4240 (test_cli_utils): Don't call deleted functions.
4241
6665660a
PA
42422019-06-13 Pedro Alves <palves@redhat.com>
4243
4244 * thread.c: Include "cli/cli-option.h".
4245 (tp_array_compar_ascending): Global.
4246 (tp_array_compar): Delete function.
4247 (tp_array_compar_ascending, tp_array_compar_descending): New
4248 functions.
4249 (ascending_option_def, qcs_flag_option_def)
4250 (thr_qcs_flags_option_defs)
4251 (make_thread_apply_all_options_def_group)
4252 (make_thread_apply_options_def_group): New.
4253 (thread_apply_all_command): Use gdb::option::process_options.
4254 (thread_apply_command_completer)
4255 (thread_apply_all_command_completer): New.
4256 (thread_apply_command): Use gdb::option::process_options.
4257 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4258 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4259 to generate help text of "thread apply". Adjust "taas"'s help.
4260 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4261 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4262
f7e13587
PA
42632019-06-13 Pedro Alves <palves@redhat.com>
4264
4265 * thread.c (thread_apply_command): Check for invalid TID with
4266 isdigit instead of !isalpha.
4267
5d707134
PA
42682019-06-13 Pedro Alves <palves@redhat.com>
4269
4270 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4271 (validate_flags_qcs): New.
4272 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4273 (validate_flags_qcs): Declare.
4274 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4275 (make_frame_apply_options_def_group): New.
4276 (frame_apply_command_count): Process options with
4277 gdb::option::process_options.
4278 (frame_apply_completer): New.
4279 (frame_apply_level_completer, frame_apply_all_completer)
4280 (frame_apply_completer): New.
4281 (_initialize_stack): Update help of "frame apply", "frame apply
4282 level", "frame apply all" and "faas" to mention supported options
4283 and install command completers.
4284 * stack.h (frame_apply_all_completer): Declare.
4285 * thread.c: Include "stack.h".
4286 (tfaas_command): Add "--".
4287 (_initialize_thread): Update help "tfaas" to mention supported
4288 options and install command completer.
4289
272d4594
PA
42902019-06-13 Pedro Alves <palves@redhat.com>
4291
4292 * completer.c (complete_nested_command_line): New.
4293 (gdb_completion_word_break_characters_throw): Add assertion.
4294 * completer.h (complete_nested_command_line): Declare.
4295
90a1ef87
PA
42962019-06-13 Pedro Alves <palves@redhat.com>
4297
4298 * stack.c (parse_backtrace_qualifiers): New.
4299 (backtrace_command): Use it.
4300 (backtrace_command_completer): Complete on qualifiers.
4301
d4c16835
PA
43022019-06-13 Pedro Alves <palves@redhat.com>
4303
4304 * frame.c: Include "cli/cli-option.h.
4305 (user_set_backtrace_options): New.
4306 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4307 Delete.
4308 (get_prev_frame): Adjust.
4309 (boolean_option_def, uinteger_option_def)
4310 (set_backtrace_option_defs): New.
4311 (_initialize_frame): Adjust and use
4312 gdb::option::add_setshow_cmds_for_options to install "set
4313 backtrace past-main" and "set backtrace past-entry".
4314 * frame.h: Include "cli/cli-option.h".
4315 (struct frame_print_options): Forward declare.
4316 (print_frame_arguments_all, print_frame_arguments_scalars)
4317 (print_frame_arguments_none): Declare.
4318 (print_entry_values): Delete declaration.
4319 (struct frame_print_options, user_frame_print_options): New.
4320 (struct set_backtrace_options): New.
4321 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4322 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4323 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4324 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4325 (list_args_or_locals): Add frame_print_options parameter.
4326 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4327 * python/py-framefilter.c (enumerate_args): Pass down
4328 USER_FRAME_PRINT_OPTIONS.
4329 * stack.c: Include "cli/cli-option.h".
4330 (print_frame_arguments_all, print_frame_arguments_scalars)
4331 (print_frame_arguments_none): Declare.
4332 (print_raw_frame_arguments, print_entry_values): Delete.
4333 (user_frame_print_options): New.
4334 (boolean_option_def, enum_option_def, frame_print_option_defs):
4335 New.
4336 (struct backtrace_cmd_options): New.
4337 (bt_flag_option_def): New.
4338 (backtrace_command_option_defs): New.
4339 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4340 (print_frame_arg, read_frame_arg, print_frame_args)
4341 (print_frame_info, print_frame): Add frame_print_options parameter
4342 and use it.
4343 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4344 (backtrace_command_1): Add frame_print_options and
4345 backtrace_cmd_options parameters and use them.
4346 (make_backtrace_options_def_group): New.
4347 (backtrace_command): Process command options with
4348 gdb::option::process_options.
4349 (backtrace_command_completer): New.
4350 (_initialize_stack): Extend "backtrace"'s help to mention
4351 supported options. Install completer for "backtrace".
4352 Install some settings commands with add_setshow_cmds_for_options.
4353
2daf894e
PA
43542019-06-13 Pedro Alves <palves@redhat.com>
4355
4356 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4357 and that "set/show print raw frame-arguments" are now deprecated.
4358
4359 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4360 command.
4361 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4362 * stack.c (_initialize_stack): Install "set/show print
4363 raw-frame-arguments", and deprecate "set/show print raw
4364 frame-arguments".
4365 * valprint.c (_initialize_valprint): Deprecate "set/show print
4366 raw".
4367
e6ed716c
PA
43682019-06-13 Pedro Alves <palves@redhat.com>
4369
4370 * compile/compile.c (struct compile_options): New.
4371 (compile_flag_option_def, compile_command_option_defs)
4372 (make_compile_options_def_group): New.
4373 (compile_file_command): Handle options with
4374 gdb::option::process_options.
4375 (compile_file_command_completer): New function.
4376 (compile_code_command): Handle options with
4377 gdb::option::process_options.
4378 (compile_code_command_completer): New function.
4379 (_initialize_compiler): Install completers for "compile code" and
4380 "compile file". Mention available options in "compile code" and
4381 "compile code"'s help.
4382 * completer.c (advance_to_completion_word): New, factored out from
4383 ...
4384 (advance_to_expression_complete_word_point): ... this.
4385 (advance_to_filename_complete_word_point): New.
4386 * completer.h (advance_to_filename_complete_word_point): New
4387 declaration.
4388
7d8062de
PA
43892019-06-13 Pedro Alves <palves@redhat.com>
4390
4391 * compile/compile.c: Include "cli/cli-option.h".
4392 (compile_print_value): Scope data pointer is now a
4393 value_print_options pointer; adjust.
4394 (compile_print_command): Process options. Scope data pointer is
4395 now a value_print_options pointer; adjust.
4396 (_initialize_compile): Update "compile print"'s help to include
4397 supported options. Install a completer for "compile print".
4398 * cp-valprint.c (show_vtblprint, show_objectprint)
4399 (show_static_field_print): Delete.
4400 (_initialize_cp_valprint): Don't install "set print
4401 static-members", "set print vtbl", "set print object" here.
4402 * printcmd.c: Include "cli/cli-option.h" and
4403 "common/gdb_optional.h".
4404 (print_command_parse_format): Rework to fill in a
4405 value_print_options instead of a format_data.
4406 (print_value): Change parameter type from format_data pointer to
4407 value_print_options reference. Adjust.
4408 (print_command_1): Process options. Adjust to pass down a
4409 value_print_options.
4410 (print_command_completer): New.
4411 (_initialize_printcmd): Install print_command_completer as
4412 handle_brkchars completer for the "print" command. Update
4413 "print"'s help to include supported options.
4414 * valprint.c: Include "cli/cli-option.h".
4415 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4416 here from cp-valprint.c.
4417 (boolean_option_def, uinteger_option_def)
4418 (value_print_option_defs, make_value_print_options_def_group):
4419 New. Use gdb::option::add_setshow_cmds_for_options to install
4420 "set print elements", "set print null-stop", "set print repeats",
4421 "set print pretty", "set print union", "set print array", "set
4422 print address", "set print symbol", "set print array-indexes".
4423 * valprint.h: Include <string> and "cli/cli-option.h".
4424 (make_value_print_options_def_group): Declare.
4425 (print_value): Change parameter type from format_data pointer to
4426 value_print_options reference.
4427 (print_command_completer): Declare.
4428
9d0faba9
PA
44292019-06-13 Pedro Alves <palves@redhat.com>
4430
4431 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4432 (COMMON_SFILES): Add maint-test-settings.c.
4433 * cli/cli-decode.c (boolean_enums): New global, factored out from
4434 ...
4435 (add_setshow_boolean_cmd): ... here.
4436 * cli/cli-decode.h (boolean_enums): Declare.
4437 * cli/cli-option.c: New file.
4438 * cli/cli-option.h: New file.
4439 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4440 factored out from ...
4441 (parse_cli_boolean_value(const char *)): ... this.
4442 (is_unlimited_literal): Change parameter type to pointer to
4443 pointer. Adjust and advance ARG pointer.
4444 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4445 (parse_cli_var_enum): New, factored out from ...
4446 (do_set_command): ... this. Adjust.
4447 * cli/cli-setshow.h (parse_cli_boolean_value)
4448 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4449 (parse_cli_var_enum): Declare.
4450 * cli/cli-utils.c: Include "cli/cli-option.h".
4451 (get_ulongest): New.
4452 * cli/cli-utils.h (get_ulongest): Declare.
4453 (check_for_argument): New overloads.
4454 * maint-test-options.c: New file.
4455
2c722807
PA
44562019-06-13 Pedro Alves <palves@redhat.com>
4457
4458 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4459 parse a range if "-" is at the end of the string.
4460
dee7b4c8
PA
44612019-06-13 Pedro Alves <palves@redhat.com>
4462
4463 * cli/cli-setshow.c (parse_auto_binary_operation)
4464 (parse_cli_boolean_value): Don't allow "o".
4465
dca0f6c0
PA
44662019-06-13 Pedro Alves <palves@redhat.com>
4467
4468 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4469 * NEWS: Mention maint test-settings KIND.
4470 * maint-test-settings.c: New file.
4471
597bf39d
PA
44722019-06-13 Pedro Alves <palves@redhat.com>
4473
4474 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4475 completer.
4476 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4477 "set" completers.
4478
48c410fb
PA
44792019-06-13 Pedro Alves <palves@redhat.com>
4480
4481 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4482 after item.
4483
93bcb043
PA
44842019-06-13 Pedro Alves <palves@redhat.com>
4485
4486 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4487
cbba3ecd
PA
44882019-06-13 Pedro Alves <palves@redhat.com>
4489
4490 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4491 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4492 call.
4493 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4494 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4495 calls.
4496 (check_for_argument): Skip spaces after argument.
4497
b9a3f842
PA
44982019-06-13 Pedro Alves <palves@redhat.com>
4499
4500 * thread.c (thread_apply_command): Adjust TID parsing.
4501 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4502 detected before end of string.
4503 (tid_is_in_list): Error out if LIST is invalid.
4504
3844e605
PA
45052019-06-13 Pedro Alves <palves@redhat.com>
4506
4507 * completer.c (complete_line_internal_1): Rewind completion word
4508 point.
4509 (completion_tracker::advance_custom_word_point_by): Change
4510 parameter type to int.
4511 * completer.h (completion_tracker::advance_custom_word_point_by):
4512 Likewise.
4513
00b56dbe
PA
45142019-06-13 Pedro Alves <palves@redhat.com>
4515
4516 * completer.c (advance_to_completion_word): Handle delimiters.
4517
d106773e
PA
45182019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4519
4520 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4521
08f10e02
TT
45222019-06-11 Tom Tromey <tom@tromey.com>
4523
4524 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4525 (xmalloc_failed): Move to alloc.c.
4526 * alloc.c: New file.
4527 * Makefile.in (COMMON_SFILES): Add alloc.c.
4528
1c7fe951
TT
45292019-06-11 Tom Tromey <tom@tromey.com>
4530
4531 * nat/linux-waitpid.c: Don't include server.h.
4532 (linux_debug): Remove.
4533 (my_waitpid): Update.
4534
89549d7f
TT
45352019-06-11 Tom Tromey <tromey@adacore.com>
4536
4537 * infcall.c (_initialize_infcall): Remove trailing newline from
4538 help.
4539 * user-regs.c (_initialize_user_regs): Remove trailing newline
4540 from help.
4541 * typeprint.c (_initialize_typeprint): Remove trailing newline
4542 from help.
4543 * reverse.c (_initialize_reverse): Remove trailing newlines from
4544 help.
4545 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4546 from help.
4547 * language.c (add_set_language_command): Remove trailing newline
4548 from help.
4549 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4550 help.
4551 * disasm.c (_initialize_disasm): Remove trailing newline from
4552 help.
4553 * top.c (init_main): Remove trailing newline from help.
4554 * interps.c (_initialize_interpreter): Remove trailing newline
4555 from help.
4556 * btrace.c (_initialize_btrace): Remove trailing newlines from
4557 help.
4558 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4559 from help.
4560 * python/python.c (_initialize_python): Remove trailing newline
4561 from help.
4562 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4563 help.
4564 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4565 from help. Reformat some text.
4566 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4567 from help.
4568 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4569 newline from help.
4570
86108c13
TT
45712019-06-11 Tom Tromey <tromey@adacore.com>
4572
4573 * darwin-nat.c (darwin_decode_exception_message)
4574 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4575
a7067863
AB
45762019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4577
4578 * valops.c (value_slice): Check for not allocated or not
4579 associated values.
4580
9ab08412
TV
45812019-06-10 Tom de Vries <tdevries@suse.de>
4582
4583 PR gdb/24618
4584 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4585 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4586 invalid.
4587
f19e22e9
TV
45882019-06-10 Tom de Vries <tdevries@suse.de>
4589
4590 PR gdb/24611
4591 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4592 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4593
e99f9db0
TV
45942019-06-10 Tom de Vries <tdevries@suse.de>
4595
4596 PR symtab/24545
4597 * symtab.c (struct demangled_name_entry): Add language field.
4598 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4599 static minimal symbol". Set and use language field.
4600
9bf7038b
TT
46012019-06-10 Tom Tromey <tromey@adacore.com>
4602
4603 * ada-lang.c (_initialize_ada_language): Update help text.
4604
422186a9
TT
46052019-06-10 Tom Tromey <tromey@adacore.com>
4606
4607 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4608 with a newline.
4609 * guile/guile.c (handle_boot_error): Don't end warning with a
4610 newline.
4611 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4612 warning with a newline.
4613 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4614 newline.
4615 (s12z_frame_cache): Likewise.
4616 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4617 a newline.
4618 * solib-svr4.c (disable_probes_interface): Don't end warning with
4619 a newline.
4620 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4621 newline.
4622 * python/python.c (do_finish_initialization): Don't end warning
4623 with a newline.
4624
25ce02ee
TT
46252019-06-10 Tom Tromey <tom@tromey.com>
4626
4627 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4628 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4629 gdbpy_enter.
4630
caa429d8
TT
46312019-06-10 Tom Tromey <tromey@adacore.com>
4632
4633 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4634 data.
4635 (elf_new_init): Don't call stabsread_new_init.
4636 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4637 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4638 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4639
81873cc8
TV
46402019-06-10 Tom de Vries <tdevries@suse.de>
4641
4642 PR symtab/16264
4643 PR symtab/24517
4644 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4645
4fa0265e
РИ
46462019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4647
4648 * source.c (find_and_open_source): Also rewrite relative file
4649 names.
4650
1a3da2cd
AB
46512019-04-26 Amos Bird <amosbird@gmail.com>
4652
4653 * annotate.c (annotate_thread_exited): Add "thread-exited"
4654 annotation.
4655
3847a7bf
TT
46562019-06-06 Tom Tromey <tromey@adacore.com>
4657
4658 * maint.h (class scoped_command_stats): Use
4659 DISABLE_COPY_AND_ASSIGN.
4660 <print_time>: New method.
4661 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4662 print_time.
4663 (scoped_command_stats::print_time): New method.
4664
312617a3
AB
46652019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4666
4667 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4668 instructions of lengths 6 or 8 bytes.
4669
b02f78f9
PA
46702019-06-04 Pedro Alves <palves@redhat.com>
4671
4672 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4673
4674 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4675 * breakpoint.c (condition_completer): Likewise.
4676 * cli/cli-dump.c (scan_expression): Likewise.
4677 * common/filestuff.c (mkdir_recursive): Likewise.
4678 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4679 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4680 (gdb_abspath): Likewise.
4681 * compile/compile-cplus-types.c
4682 (compile_cplus_instance::decl_name): Likewise.
4683 * completer.c (complete_explicit_location):
4684 (signal_completer, reg_or_group_completer_1): Likewise.
4685 * cp-support.c (cp_remove_params_if_any): Likewise.
4686 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4687 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4688 * infcmd.c (strip_bg_char): Likewise.
4689 * linespec.c (copy_token_string): Likewise.
4690 * mi/mi-main.c (output_cores): Likewise.
4691 * psymtab.c (psymtab_search_name):
4692 * symfile.c (test_set_ext_lang_command): Likewise.
4693 * target.c (target_fileio_read_stralloc): Likewise.
4694 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4695 * value.c (complete_internalvar): Likewise.
4696
e1f2e1a2
CB
46972019-06-04 Christian Biesinger <cbiesinger@google.com>
4698
4699 Add objfile property to gdb.Type.
d3238f7d
PA
4700 * NEWS: Mention Python API addition.
4701 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4702
e664d728
PW
47032019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4704
4705 * NEWS: Mention the new set|show style [title|highlight].
4706 Mention changes to "show style", "help" and "apropos".
4707
66d8c862
PW
47082019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4709
4710 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4711 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4712 instead of print_help_for_command.
4713 (print_doc_of_command): New function.
4714 (help_list): Add 'apropos -v word' suggestion.
4715 (print_help_for_command): Style the command name using title style.
4716 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4717 (_initialize_cli_cmds): Describe -v in apropos_command help.
4718
9303eb2f
PW
47192019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4720
4721 * cli/cli-style.h (cli_style_option): Add name in constructor,
4722 add m_name class member, add constructor with intensity,
4723 add name class function.
4724 (cli_style_option::add_setshow_commands): Remove name argument.
4725 (highlight_style, title_style): New styles.
4726 * cli/cli-style.c (do_show): New function that shows a style
4727 characteristic styling the style name with itself.
4728 (set_style_name): New function.
4729 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4730 Update all callers according to the changes in cli/cli-style.h.
4731 * utils.h (fputs_highlighted): New function.
4732 * utils.c (fputs_highlighted): Likewise.
4733
e2c52041
PW
47342019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4735
4736 * NEWS: Mention new pipe command and new convenience variables.
4737
947d3946
PW
47382019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4739
4740 * cli/cli-cmds.c (pipe_command): New function.
4741 (_initialize_cli_cmds): Call add_com for pipe_command.
4742 Define | as an alias for pipe.
4743 (exit_status_set_internal_vars): New function.
4744 (shell_escape): Call exit_status_set_internal_vars.
4745 cli/cli-decode.c (find_command_name_length): Recognize | as
4746 a single character command.
4747
b8fd0918
PW
47482019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4749
4750 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4751 top.c (execute_command_to_ui_file): New function, mostly a copy
4752 of execute_command_to_string.
4753 (execute_command_to_string): Implement by calling
4754 execute_command_to_ui_file.
4755
68bb5386
PW
47562019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4757
4758 * top.h (saved_command_line): Remove declaration.
4759 * top.c (previous_saved_command_line, previous_repeat_arguments):
4760 New variables.
4761 (saved_command_line): Make static, define together with other
4762 'repeat variables'.
4763 (dont_repeat): Clear repeat_arguments.
4764 (repeat_previous, get_saved_command_line, save_command_line):
4765 New functions.
4766 (gdb_init): Initialize saved_command_line
4767 and previous_saved_command_line.
4768 * main.c (captured_main_1): Remove saved_command_line initialization.
4769 * event-top.c (handle_line_of_input): Update to use
4770 the new 'repeat' related functions instead of direct access to
4771 saved_command_line.
4772 * command.h (repeat_previous, get_saved_command_line,
4773 save_command_line): New declarations.
4774 (dont_repeat): Add comment.
4775
bfcdb852
TT
47762019-05-30 Tom Tromey <tromey@adacore.com>
4777
4778 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4779 Fix comment.
4780 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4781
0ef209f2
JV
47822019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4783
4784 PR cli/24587
4785 * completer.c (complete): Initialize variable word.
4786
955b06fa
SDJ
47872019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4788
4789 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4790 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4791 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4792 'body' is NULL to the outter 'if', protecting the '!is_define'
4793 situation as well.
4794
fa9c3fa0
TT
47952019-05-29 Tom Tromey <tromey@adacore.com>
4796
4797 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4798 (dwarf_unknown): New function.
4799 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4800 (dwarf_type_encoding_name): Use dwarf_unknown.
4801
4330d61d
TT
48022019-05-29 Tom Tromey <tromey@adacore.com>
4803
4804 PR c++/20020:
4805 * cp-valprint.c (cp_print_value_fields): Call
4806 cp_print_static_field inside "try".
4807
33a6bc35
TT
48082019-05-29 Tom Tromey <tromey@adacore.com>
4809
4810 * inflow.c (struct terminal_info): Add default operator=.
4811 * configure: Rebuild.
4812 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4813 -Wdeprecated-copy-dtor, -Wredundant-move.
4814
000439d5
TT
48152019-05-29 Tom Tromey <tromey@adacore.com>
4816
4817 * NEWS: Add entry.
4818 * infcmd.c (print_return_value_1): Handle finish_print
4819 option.
4820 (show_print_finish): New function.
4821 (_initialize_infcmd): Add "set/show print finish" commands.
4822 * valprint.c (user_print_options): Initialize new member.
4823 * valprint.h (struct value_print_options) <finish_print>: New
4824 member.
4825
c0e70c62
TT
48262019-05-28 Tom Tromey <tromey@adacore.com>
4827
4828 * ada-lang.c (ada_remove_Xbn_suffix)
4829 (find_old_style_renaming_symbol)
4830 (parse_old_style_renaming): Remove.
4831 (ada_find_renaming_symbol): Don't call
4832 find_old_style_renaming_symbol.
4833 (ada_is_renaming_symbol): Rename from
4834 ada_find_renaming_symbol. Remove "block" parameter. Return
4835 bool. Now static.
4836 (ada_read_var_value): Update and simplify.
4837 * ada-exp.y (write_var_or_type): Remove old code.
4838
766f8836
AH
48392019-05-28 Alan Hayward <alan.hayward@arm.com>
4840
4841 * event-top.c: Remove include comment.
4842 * inflow.c (class scoped_ignore_sigttou): Move from here...
4843 * inflow.h (class scoped_ignore_sigttou): ...to here.
4844 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4845 * top.c: Remove include comment.
4846
eb41253a
TT
48472019-05-27 Tom Tromey <tom@tromey.com>
4848
4849 * NEWS: Fix typo.
4850
4ca51187
TT
48512019-05-22 Tom Tromey <tromey@adacore.com>
4852
4853 * target.c (target_follow_exec): Constify parameter.
4854 * target-delegates.c: Rebuild.
4855 * remote.c (remote_target::follow_exec): Constify parameter.
4856 * infrun.c (follow_exec): Constify parameter.
4857 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4858 (target_follow_exec): Likewise.
4859
8fca4da0
AH
48602019-05-22 Alan Hayward <alan.hayward@arm.com>
4861
4862 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4863 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4864
b7060614
AH
48652019-05-22 Alan Hayward <alan.hayward@arm.com>
4866
4867 * NEWS: Add debugredirect and testsuite sections.
4868
0a5954bd
SC
48692019-05-22 Simon Cook <simon.cook@embecosm.com>
4870
4871 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4872 target descriptions using exclusively floating point register name
4873 aliases.
4874
dc42e902
AB
48752019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4876
4877 PR gdb/18644:
4878 * f-lang.c (build_fortran_types): Handle the case where
4879 gdbarch_floatformat_for_type returns a nullptr.
4880
fb7806c7
TV
48812019-05-21 Tom de Vries <tdevries@suse.de>
4882
4883 PR cli/24587
4884 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4885
34d11c68
AB
48862019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4887
4888 PR gdb/18644:
4889 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4890 16-byte floats.
4891 * i386-tdep.c (i386_floatformat_for_type): Use
4892 floatformats_ia64_quad for the 16-byte floating point component
4893 within a fortran 32-byte complex number.
4894
122cf0f2
AB
48952019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4896
4897 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4898 delete default constructor.
4899 (find_partial_die): Update to return const struct.
4900 (partial_die_parent_scope): Move variable declaration into scope
4901 of its use and change its type to auto.
4902 (guess_partial_die_structure_name): Likewise.
4903 (partial_die_info::fixup): Likewise.
4904
33d0e35a
TT
49052019-05-17 Tom Tromey <tromey@adacore.com>
4906
4907 * source.c (find_and_open_source): Remove cast.
4908
a45575b0
TT
49092019-05-17 Tom Tromey <tromey@adacore.com>
4910
4911 * annotate.c (annotate_source): Make "filename" const.
4912 * annotate.h (annotate_source): Use const.
4913
81f47ac2
AH
49142019-05-17 Alan Hayward <alan.hayward@arm.com>
4915
4916 * disasm.c (set_disassembler_options): Send errors to stderr.
4917
ca1285d1
AH
49182019-05-17 Alan Hayward <alan.hayward@arm.com>
4919
4920 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4921 (cli_interp_base::set_logging): Check debug_redirect.
4922 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4923 * cli/cli-logging.c (debug_redirect): Add static variable.
4924 (pop_output_files): Add default param.
4925 (handle_redirections): Print debug setting.
4926 (show_logging_command): Likewise.
4927 (_initialize_cli_logging): Add debugredirect command.
4928 * interps.c (current_interp_set_logging): Add debug_redirect
4929 parameter.
4930 * interps.h (set_logging): Add debug_redirect parameter.
4931 (current_interp_set_logging): Likewise.
4932 * mi/mi-common.h: Likewise.
4933 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4934
49352019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
4936 Tom Tromey <tromey@adacore.com>
4937
4938 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4939 directly.
4940 * cli/cli-interp.h (make_logging_output): Remove declaration.
4941 * cli/cli-logging.c (make_logging_output): Remove function.
4942 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4943 directly.
4944 * ui-file.c (tee_file::tee_file): Remove bools.
4945 (tee_file::~tee_file): Remove deletes.
4946 * ui-file.h (tee_file): Remove bools.
4947
26648588
JV
49482019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4949
4950 * mi/mi-cmds.h (mi_cmd_complete): New function.
4951 * mi/mi-main.c (mi_cmd_complete): Likewise.
4952 * mi/mi-cmds.c: Define new MI command -complete.
4953 * NEWS: Mention new -complete command.
4954
6e035501
JV
49552019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4956
4957 * completer.h (complete): New function.
4958 * completer.c (complete): Likewise.
4959 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4960 function defined in completer.h.
4961
7d0e2ece
JV
49622019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4963
e79be6e5 4964 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 4965
fb816e8b
TV
49662019-05-17 Tom de Vries <tdevries@suse.de>
4967
4968 PR gdb/24094
4969 * dwarf2read.c (struct cu_partial_die_info): New struct.
4970 (find_partial_die): Return cu_partial_die_info.
4971 (partial_die_parent_scope, guess_partial_die_structure_name)
4972 (partial_die_info::fixup): Handle new return type of find_partial_die.
4973
677052f2
SDJ
49742019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4975
4976 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4977 "std::string", simplifying the algorithm.
4978
f3da9116
SDJ
49792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4980
4981 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4982 (stap_static_probe_ops::get_probes): Likewise.
4983
f1bb75ab
SDJ
49842019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4985
4986 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4987 '-')" and "else if".
4988 (stap_parse_single_operand): Join checks for
4989 "gdbarch_stap_parse_special_token_p" and
4990 "gdbarch_stap_parse_special_token" in the same "if" statement.
4991 Invert check when verifying for operation on register
4992 displacement.
4993
3ca58cde
SDJ
49942019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4995
4996 * stap-probe.c (stap_get_opcode): Update comment.
4997 (stap_get_expected_argument_type): Likewise.
4998 (handle_stap_probe): Likewise.
4999
af2d9bee
SDJ
50002019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5001
5002 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5003 return type to 'bool'. Adjust comment. Use 'bool' when
5004 appropriate.
5005 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5006 * stap-probe.c (stap_parse_argument_1): Likewise.
5007 (stap_is_operator): Likewise.
5008 (stap_is_generic_prefix): Likewise.
5009 (stap_is_register_prefix): Likewise.
5010 (stap_is_register_indirection_prefix): Likewise.
5011 (stap_is_integer_prefix): Likewise.
5012 (stap_generic_check_suffix): Likewise.
5013 (stap_check_integer_suffix): Likewise.
5014 (stap_check_register_suffix): Likewise.
5015 (stap_check_register_indirection_suffix): Likewise.
5016 (stap_parse_register_operand): Likewise.
5017 (stap_parse_single_operand): Likewise.
5018 (stap_parse_argument_1): Likewise.
5019 (stap_probe::get_argument_count): Likewise.
5020 (stap_is_operator): Likewise.
5021
61c9c421
TT
50222019-05-16 Tom Tromey <tromey@adacore.com>
5023
5024 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5025 keyword to foreach.
5026
9ddc1af1
SM
50272019-05-15 Simon Marchi <simon.marchi@efficios.com>
5028
5029 * linux-thread-db.c (try_thread_db_load_1): Change return type
5030 to bool.
5031 (try_thread_db_load): Likewise.
5032 (try_thread_db_load_from_pdir_1): Likewise.
5033 (try_thread_db_load_from_pdir): Likewise.
5034 (try_thread_db_load_from_sdir): Likewise.
5035 (try_thread_db_load_from_dir): Likewise.
5036 (thread_db_load_search): Likewise.
5037 (has_libpthread): Likewise.
5038 (thread_db_load): Likewise.
5039
7bede828
SDJ
50402019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5041
5042 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5043 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5044 NULL, and complain/return if that's the case.
5045
c5358db4
JD
50462019-05-15 John Darrington <john@darrington.wattle.id.au>
5047
5048 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5049 (advance, posn, abstract_read_memory): New functions.
5050 [struct mem_read_abstraction]: New struct.
5051 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5052
c408a94f
TT
50532019-05-14 Tom Tromey <tromey@adacore.com>
5054
5055 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5056 value is not lval_memory.
5057
e7bd7fba
TT
50582019-05-14 Tom Tromey <tromey@adacore.com>
5059
5060 * solib.c (info_sharedlibrary_command): Style the file name.
5061
a6d0f249
AH
50622019-05-14 Alan Hayward <alan.hayward@arm.com>
5063
5064 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5065 (aarch64_vnv_type): Likewise.
5066 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5067 * common/tdesc.c: Likewise.
5068 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5069 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5070 * features/aarch64-fpu.xml: Add ieee half view.
5071 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5072 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5073 * gdbtypes.h (struct builtin_type): Likewise.
5074 (struct objfile_type): Likewise.
5075
66b8bb74
SM
50762019-05-12 Paul Naert <paul.naert@polymtl.ca>
5077
5078 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5079 typo.
5080 * location.h (string_to_event_location): Likewise.
5081
21c219fd
JB
50822019-05-11 Joel Brobecker <brobecker@adacore.com>
5083
5084 GDB 8.3 released.
5085
13674803
SM
50862019-05-10 Simon Marchi <simon.marchi@efficios.com>
5087
5088 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5089 New variable declaration.
5090 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5091 New variable.
5092 (print_one_breakpoint): Use ui_out::test_flags and new global
5093 variable to compute use_fixed_output.
5094 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5095 Remove.
5096 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5097 (mi_multi_location_breakpoint_output_fixed): Remove.
5098 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5099 new variable.
5100 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5101 fix_multi_location_breakpoint_output flag if version >= 3.
5102 * ui-out.h (enum ui_out_flag)
5103 <fix_multi_location_breakpoint_output>: New enumerator.
5104
a9eac7f9
SM
51052019-05-10 Simon Marchi <simon.marchi@efficios.com>
5106
5107 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5108
71bed2db
TT
51092019-05-10 Tom Tromey <tromey@adacore.com>
5110
5111 * ada-lang.c (catch_ada_completer): New function.
5112 (_initialize_ada_language): Use it.
5113
24c54127
TT
51142019-05-10 Tom Tromey <tromey@adacore.com>
5115
5116 * thread.c (print_thread_info): Make "requested_threads" const.
5117 * gdbthread.h (print_thread_info): Make "requested_threads"
5118 const.
5119 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5120 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5121
7a102139
TT
51222019-05-08 Tom Tromey <tom@tromey.com>
5123
5124 * gdbtypes.c (objfile_type_data): Change type.
5125 (objfile_type, _initialize_gdbtypes): Update.
5126
924d79e2
TT
51272019-05-08 Tom Tromey <tom@tromey.com>
5128
5129 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5130 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5131 (_initialize_dwarf2_frame): Update.
5132
4c58e337
TT
51332019-05-08 Tom Tromey <tom@tromey.com>
5134
5135 * objc-lang.c (objc_objfile_data): Change type.
5136 (find_methods): Update.
5137 (_initialize_objc_lang): Remove.
5138
d772d2ab
TT
51392019-05-08 Tom Tromey <tom@tromey.com>
5140
5141 * stabsread.c (rs6000_builtin_type_data): Change type.
5142 (rs6000_builtin_type, _initialize_stabsread): Update.
5143
d11d83f4
TT
51442019-05-08 Tom Tromey <tom@tromey.com>
5145
5146 * mips-tdep.c (mips_pdr_data): Remove.
5147 (_initialize_mips_tdep): Update.
5148
9a73f0ad
TT
51492019-05-08 Tom Tromey <tom@tromey.com>
5150
5151 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5152 (hppa_init_objfile_priv_data, read_unwind_info)
5153 (find_unwind_entry, _initialize_hppa_tdep): Update.
5154
8127a2fa
TT
51552019-05-08 Tom Tromey <tom@tromey.com>
5156
5157 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5158 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5159 on obstack.
5160 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5161
91d3055d
TT
51622019-05-08 Tom Tromey <tom@tromey.com>
5163
5164 * mdebugread.c (basic_type_data): Change type.
5165 (basic_type, _initialize_mdebugread): Update.
5166
31930bd3
TT
51672019-05-08 Tom Tromey <tom@tromey.com>
5168
5169 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5170
bdb3ed9e
TT
51712019-05-08 Tom Tromey <tom@tromey.com>
5172
5173 * nto-tdep.c (nto_inferior_data_reg): Change type.
5174 (nto_inferior_data): Update.
5175 (nto_inferior_data_cleanup, nto_new_inferior_data)
5176 (_initialize_nto_tdep): Remove.
5177 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5178
f37b313d
TT
51792019-05-08 Tom Tromey <tom@tromey.com>
5180
5181 * ada-lang.c (struct ada_inferior_data): Add initializers.
5182 (ada_inferior_data): Change type.
5183 (ada_inferior_data_cleanup): Remove.
5184 (get_ada_inferior_data, ada_inferior_exit)
5185 (struct ada_pspace_data): Add initializers, destructor.
5186 (ada_pspace_data_handle): Change type.
5187 (get_ada_pspace_data): Update.
5188 (ada_pspace_data_cleanup): Remove.
5189
24699405
TT
51902019-05-08 Tom Tromey <tom@tromey.com>
5191
5192 * coffread.c (struct coff_symfile_info): Add initializers.
5193 (coff_objfile_data_key): Move lower. Change type.
5194 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5195 Update.
5196 (coff_free_info): Remove.
5197
d4e05d2f
TT
51982019-05-08 Tom Tromey <tom@tromey.com>
5199
5200 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5201 (fbsd_pspace_data_handle): Move lower. Change type.
5202 (get_fbsd_pspace_data): Update.
5203 (fbsd_pspace_data_cleanup): Remove.
5204 (_initialize_fbsd_tdep): Update.
5205
14ef6690
TT
52062019-05-08 Tom Tromey <tom@tromey.com>
5207
5208 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5209 (get_ada_tasks_pspace_data): Update.
5210 (ada_tasks_pspace_data_cleanup): Remove.
5211 (_initialize_tasks): Update.
5212 (ada_tasks_inferior_data_handle): Change type.
5213 (get_ada_tasks_inferior_data): Update.
5214 (ada_tasks_inferior_data_cleanup): Remove.
5215 (struct ada_tasks_pspace_data): Add initializers.
5216
814cf43a
TT
52172019-05-08 Tom Tromey <tom@tromey.com>
5218
5219 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5220 * symfile-debug.c (debug_sym_get_probes): Change type.
5221 * stap-probe.c (handle_stap_probe):
5222 (stap_static_probe_ops::get_probes): Change type.
5223 * probe.h (class static_probe_ops) <get_probes>: Change type.
5224 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5225 (parse_probes_in_pspace): Update.
5226 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5227 Update.
5228 (any_static_probe_ops::get_probes): Change type.
5229 * elfread.c (elfread_data): New typedef.
5230 (probe_key): Change type.
5231 (elf_get_probes): Likewise. Update.
5232 (probe_key_free): Remove.
5233 (_initialize_elfread): Update.
5234 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5235 Change type.
5236 (dtrace_process_dof_probe, dtrace_process_dof)
5237 (dtrace_static_probe_ops::get_probe): Change type.
5238
02dc647e
TT
52392019-05-08 Tom Tromey <tom@tromey.com>
5240
5241 * xcoffread.c (struct xcoff_symfile_info): Rename from
5242 coff_symfile_info. Add initializers.
5243 (xcoff_objfile_data_key): Move lower. Change type.
5244 (XCOFF_DATA): Rewrite.
5245 (xcoff_free_info): Remove.
5246 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5247 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5248 (xcoff_initial_scan): Update.
5249
09232438
TT
52502019-05-08 Tom Tromey <tom@tromey.com>
5251
5252 * solib-svr4.c (struct svr4_info): Add initializers and
5253 destructor.
5254 <probes_table>: Now an htab_up.
5255 (solib_svr4_pspace_data): Change type.
5256 (free_probes_table): Simplify.
5257 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5258 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5259 (probes_table_remove_objfile_probes, register_solib_event_probe)
5260 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5261 (_initialize_svr4_solib): Update.
5262
7b4a314f
TT
52632019-05-08 Tom Tromey <tom@tromey.com>
5264
5265 * remote.c (remote_pspace_data): Change type.
5266 (remote_pspace_data_cleanup): Remove.
5267 (get_remote_exec_file, set_pspace_remote_exec_file)
5268 (_initialize_remote): Update.
5269
51d3063a
TT
52702019-05-08 Tom Tromey <tom@tromey.com>
5271
5272 * breakpoint.c (breakpoint_objfile_key): Change type.
5273 (get_breakpoint_objfile_data): Update.
5274 (free_breakpoint_objfile_data): Remove.
5275 (_initialize_breakpoint): Update.
5276
89fb8848
TT
52772019-05-08 Tom Tromey <tom@tromey.com>
5278
5279 * linux-tdep.c (struct linux_info): Add initializers.
5280 (linux_inferior_data): Move. Change type.
5281 (invalidate_linux_cache_inf): Update.
5282 (linux_inferior_data_cleanup): Remove.
5283 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5284
e9b89e2d
TT
52852019-05-08 Tom Tromey <tom@tromey.com>
5286
5287 * auxv.c (auxv_inferior_data): Move. Change type.
5288 (auxv_inferior_data_cleanup): Remove.
5289 (invalidate_auxv_cache_inf): Rewrite.
5290 (get_auxv_inferior_data, _initialize_auxv): Update.
5291
8c42777c
TT
52922019-05-08 Tom Tromey <tom@tromey.com>
5293
5294 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5295 (symfile_debug_objfile_data_key): Change type.
5296 (symfile_debug_installed, debug_qf_has_symbols)
5297 (debug_qf_find_last_source_symtab)
5298 (debug_qf_forget_cached_source_info)
5299 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5300 (debug_qf_print_stats, debug_qf_dump)
5301 (debug_qf_expand_symtabs_for_function)
5302 (debug_qf_expand_all_symtabs)
5303 (debug_qf_expand_symtabs_with_fullname)
5304 (debug_qf_map_matching_symbols)
5305 (debug_qf_expand_symtabs_matching)
5306 (debug_qf_find_pc_sect_compunit_symtab)
5307 (debug_qf_map_symbol_filenames)
5308 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5309 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5310 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5311 (debug_sym_read_linetable, debug_sym_relocate): Update.
5312 (symfile_debug_free_objfile): Remove.
5313 (install_symfile_debug_logging, _initialize_symfile_debug):
5314 Update.
5315
5bfd760d
TT
53162019-05-08 Tom Tromey <tom@tromey.com>
5317
5318 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5319 allocate_on_obstack.
5320 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5321 (get_dwarf2_per_objfile): Update.
5322 (set_dwarf2_per_objfile): Remove.
5323 (dwarf2_has_info, dwarf2_get_section_info): Update.
5324 (dwarf2_free_objfile): Remove.
5325 (_initialize_dwarf2_read): Update.
5326
e85e19b4
TT
53272019-05-08 Tom Tromey <tom@tromey.com>
5328
5329 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5330 initializers.
5331 <unsupported_script_warning_printed,
5332 script_not_found_warning_printed>: Now bool.
5333 (auto_load_pspace_data): Change type.
5334 (~auto_load_pspace_info): Rename from
5335 auto_load_pspace_data_cleanup.
5336 (get_auto_load_pspace_data, init_loaded_scripts_info)
5337 (clear_section_scripts, maybe_print_unsupported_script_warning)
5338 (maybe_print_script_not_found_warning, _initialize_auto_load):
5339 Update.
5340
f6aa7436
TT
53412019-05-08 Tom Tromey <tom@tromey.com>
5342
5343 * objfiles.c (objfile_pspace_info): Add destructor and
5344 initializers.
5345 (objfiles_pspace_data): Change type.
5346 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5347 (get_objfile_pspace_data): Update.
5348 (objfiles_bfd_data): Change type.
5349 (get_objfile_bfd_data): Update.
5350 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5351
6ae614f6
TT
53522019-05-08 Tom Tromey <tom@tromey.com>
5353
5354 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5355 Change type.
5356 (get_catch_syscall_inferior_data): Update.
5357 (catch_syscall_inferior_data_cleanup): Remove.
5358 (_initialize_break_catch_syscall): Update.
5359
6509b8eb
TT
53602019-05-08 Tom Tromey <tom@tromey.com>
5361
5362 * inflow.c (struct terminal_info): Add destructor and
5363 initializers.
5364 (inflow_inferior_data): Change type.
5365 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5366 (get_inflow_inferior_data, inflow_inferior_exit)
5367 (swap_terminal_info, _initialize_inflow): Update.
5368
35632941
TT
53692019-05-08 Tom Tromey <tom@tromey.com>
5370
5371 * target-dcache.c (target_dcache_cleanup): Remove.
5372 (target_dcache_aspace_key): Change type.
5373 (target_dcache_init_p, target_dcache_invalidate)
5374 (target_dcache_get, target_dcache_get_or_init)
5375 (_initialize_target_dcache): Update.
5376 * dcache.h (struct dcache_deleter): New.
5377
3017b94d
TT
53782019-05-08 Tom Tromey <tom@tromey.com>
5379
5380 * symtab.c (struct symbol_cache): Add destructor and
5381 initializers.
5382 (symbol_cache_key): Move. Change type.
5383 (make_symbol_cache, free_symbol_cache): Remove.
5384 (get_symbol_cache): Update.
5385 (symbol_cache_cleanup): Remove.
5386 (ALL_PSPACES, symbol_cache_flush)
5387 (maintenance_print_symbol_cache)
5388 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5389 Update.
5390
a32ad8c5
TT
53912019-05-08 Tom Tromey <tom@tromey.com>
5392
5393 * symtab.c (struct main_info): Add destructor and initializers.
5394 (main_progspace_key): Move. Change type.
5395 (get_main_info): Update.
5396 (main_info_cleanup): Remove.
5397 (_initialize_symtab): Update.
5398
5f6e90a0
TT
53992019-05-08 Tom Tromey <tom@tromey.com>
5400
5401 * registry.h (DECLARE_REGISTRY): Define the _key class.
5402
1bd0c6e4
AB
54032019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5404
5405 * NEWS: Merge two 'New commands' sections.
5406
2228ef77
XR
54072019-05-08 Joel Brobecker <brobecker@adacore.com>
5408
5409 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5410 parameter and use Ada language definition instead.
5411 (ada_val_print_ptr): Remove unused language parameter.
5412 (ada_val_print_num): Remove language parameter and use Ada language
5413 definition instead.
5414 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5415 parameter.
5416 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5417 parameter and use Ada language definition instead.
5418 (ada_val_print_1): Update all ada_val_print_xxx calls.
5419 Remove language parameter.
5420 (ada_val_print): Update ada_val_print_1 call.
5421
60fcc1c3
TT
54222019-05-08 Tom Tromey <tromey@adacore.com>
5423
5424 * remote.c (remote_hw_watchpoint_limit)
5425 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5426 Now static.
5427
ed2b7c17
TT
54282019-05-08 Tom Tromey <tromey@adacore.com>
5429
5430 * maint.c (_initialize_maint_cmds): Move initialization code to
5431 remote.c.
5432 (watchdog, show_watchdog): Move to remote.c.
5433 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5434 "watchdog" static.
5435 (_initialize_remote): Move initialization code from maint.c.
5436 * defs.h (watchdog): Don't declare.
5437
b0be6c91
TT
54382019-05-08 Tom Tromey <tromey@adacore.com>
5439
5440 * tui/tui-interp.c: Include main.h.
5441 * interps.c: Include main.h.
5442 * main.h (interpreter_p): Declare.
5443 * defs.h (interpreter_p): Don't declare.
5444
587ee17b
TT
54452019-05-08 Tom Tromey <tromey@adacore.com>
5446
5447 * dwarf2loc.c: Include dwarf2read.h.
5448 * defs.h (read_unsigned_leb128): Don't declare.
5449 * dwarf2read.h (read_unsigned_leb128): Declare.
5450
ca1df239
TT
54512019-05-08 Tom Tromey <tromey@adacore.com>
5452
5453 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5454 method.
5455
99f20f08
TT
54562019-05-08 Tom Tromey <tromey@adacore.com>
5457
5458 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5459 when no wrap column is set.
5460
80e55b13
TT
54612019-05-08 Tom Tromey <tromey@adacore.com>
5462
5463 * c-lang.c (c_get_string): Handle non-C-style arrays.
5464
9d3421af
TT
54652019-05-08 Tom Tromey <tromey@adacore.com>
5466
5467 * typeprint.c (print_offset_data::update): Print the bit offset,
5468 not the number of bits remaining.
5469
844333e2
TT
54702019-05-08 Tom Tromey <tromey@adacore.com>
5471
5472 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5473 padding at end of comment.
5474
988915ee
TT
54752019-05-08 Tom Tromey <tromey@adacore.com>
5476
5477 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5478 Compare main types.
5479
26bfd823
TT
54802019-05-06 Tom Tromey <tom@tromey.com>
5481
5482 * common/scoped_mmap.c: Include common-defs.h.
5483 * common/scoped_mmap.h: Don't include config.h.
5484
89055eaa
TT
54852019-05-04 Tom Tromey <tom@tromey.com>
5486
5487 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5488 (struct aarch64_call_info): Add initializers.
5489 <si>: Now a std::vector.
5490 (pass_on_stack, aarch64_push_dummy_call): Update.
5491
5da01df5
TT
54922019-05-04 Simon Marchi <simon.marchi@efficios.com>
5493 Tom Tromey <tom@tromey.com>
5494
5495 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5496 (ppc_threads): Now a std::vector. Now static.
5497 (hwdebug_find_thread_points_by_tid)
5498 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5499 Update.
5500
fbdf05a1
TT
55012019-05-04 Tom Tromey <tom@tromey.com>
5502
5503 * arc-tdep.c (arc_tdesc_init): Return bool.
5504
06d16ec9
TT
55052019-05-04 Tom Tromey <tom@tromey.com>
5506
5507 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5508 Use gdb_assert_not_reached.
5509
9c056022
TT
55102019-05-04 Tom Tromey <tom@tromey.com>
5511
5512 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5513 "false".
5514
fa9c2a59
TT
55152019-05-04 Tom Tromey <tom@tromey.com>
5516
5517 * arc-tdep.c (arc_tdesc_init): Use bool.
5518
e2eb806a
TT
55192019-05-04 Tom Tromey <tom@tromey.com>
5520
5521 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5522
6fe87677
TT
55232019-05-04 Tom Tromey <tom@tromey.com>
5524
5525 * cli/cli-cmds.c (valid_command_p): Return bool.
5526
7f008c9e
TT
55272019-05-04 Tom Tromey <tom@tromey.com>
5528
5529 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5530 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5531
b6484282
RT
55322019-05-04 Raul Tambre <raul@tambre.ee>
5533
5534 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5535 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5536 operator for comparison.
5537
af97b416
TT
55382019-05-04 Tom Tromey <tom@tromey.com>
5539
5540 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5541 (lookup_partial_symbol, print_partial_symbols)
5542 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5543 (psymbol_compare): Update.
5544 (add_psymbol_to_bcache): Clear the entire psymbol.
5545 (maintenance_check_psymtabs): Update.
5546 * psympriv.h (struct partial_symbol): Don't derive from
5547 general_symbol_info.
5548 <obj_section, unrelocated_address, address,
5549 set_unrelocated_address>: Update.
5550 <ginfo>: New member.
5551 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5552 (debug_names::write_psymbols): Update.
5553
9d6d4be8
TV
55542019-05-04 Tom de Vries <tdevries@suse.de>
5555
5556 * contrib/cc-with-tweaks.sh: Support -n arg.
5557
66452beb
PW
55582019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5559
5560 * corelow.c (core_target::detach): Ensure frame cache and
5561 register caches are cleared.
5562 inferior.c (exit_inferior_1): Likewise.
5563
bde09ab7
TT
55642019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5565 Tom Tromey <tom@tromey.com>
5566
5567 * dictionary.c (collate_pending_symbols_by_language): Remove
5568 "struct" from foreach.
5569 * symtab.c (lookup_global_symbol_from_objfile)
5570 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5571 foreach.
5572 * ser-tcp.c (net_open): Remove "struct" from foreach.
5573 * objfiles.c (objfile_relocate, objfile_rebase)
5574 (objfile_has_symbols): Remove "struct" from foreach.
5575 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5576 from foreach.
5577 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5578 foreach.
5579 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5580 "struct" from foreach.
5581 * ada-lang.c (create_excep_cond_exprs)
5582 (ada_exception_catchpoint_cond_string): Remove "struct" from
5583 foreach.
5584
222a8d25
TT
55852019-05-03 Tom Tromey <tromey@adacore.com>
5586
5587 * ada-exp.y (convert_char_literal): Check suffix of each
5588 enumerator.
5589
fcd60b84
DP
55902019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5591
5592 PR ada/21406:
5593 * ada-exp.y (yywrap): Don't define.
5594 * ada-lex.l (%option): Add noyywrap
5595 (yywrap): Remove.
5596
5f2459c2
EZ
55972019-05-03 Eli Zaretskii <eliz@gnu.org>
5598
353ea2d1
EZ
5599 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5600 _WIN32_WINNT to the XP level, unless already defined to a higher
5601 level.
5602
5603 * unittests/parse-connection-spec-selftests.c:
5604 * ser-tcp.c:
5605 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5606 override.
5607
5f2459c2
EZ
5608 * symfile.c (find_separate_debug_file): Remove colon from the
5609 drive spec of DOS/Windows file names of the target, so that the
5610 file name produced from DEBUGDIR and the target's directory will
5611 be valid on DOS/Windows systems.
5612
80062eb9
AB
56132019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5614
5615 * rust-lang.c (val_print_struct): Handle printing structures
5616 containing strings.
5617
b8c05e85
TT
56182019-05-02 Tom Tromey <tromey@adacore.com>
5619
5620 * valarith.c (_initialize_valarith): Remove.
5621
4504bbde
TT
56222019-05-01 Tom Tromey <tromey@adacore.com>
5623
5624 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5625 bitfields.
5626
d48e62f4
TT
56272019-05-01 Tom Tromey <tromey@adacore.com>
5628
5629 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5630 for big-endian copies.
5631
15f18d14
AT
56322019-04-30 Ali Tamur <tamur@google.com>
5633 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5634 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5635 (read_3_bytes): New function.
5636
ab4ee614
JB
56372019-04-30 Joel Brobecker <brobecker@adacore.com>
5638
5639 * windows-nat.c (main_thread_id): Delete.
5640 (handle_output_debug_string): Replace main_thread_id by
5641 current_event.dwThreadId.
5642 (fake_create_process): Likewise.
5643 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5644 Do not set main_thread_id.
5645 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5646 current_event.dwThreadId.
5647 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5648
8ed5b76e
JB
56492019-04-30 Joel Brobecker <brobecker@adacore.com>
5650
5651 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5652 Use current_event.dwThreadId instead of main_thread_id.
5653
2ff0a947
TT
56542019-04-30 Tom Tromey <tromey@adacore.com>
5655
5656 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5657 (create_excep_cond_exprs): Iterate over program spaces.
5658 (ada_exception_catchpoint_cond_string): Examine all minimal
5659 symbols for exception types.
5660
a776957c
TT
56612019-04-30 Tom Tromey <tromey@adacore.com>
5662
5663 PR c++/24470:
5664 * dwarf2read.c (process_structure_scope): Handle case where type
5665 has template parameters but no symbol was created.
5666
bc68014d
AB
56672019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5668 Chris January <chris.january@arm.com>
5669
5670 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5671 qualifier.
5672 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5673
f1fdc960
AB
56742019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5675
5676 * f-typeprint.c (f_print_type): Update rules for printing
5677 whitespace.
5678 (f_type_print_varspec_suffix): Likewise.
5679
bf7a4de1
AB
56802019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5681 Chris January <chris.january@arm.com>
5682
5683 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5684 function arguments.
5685
bbe75b9d
AB
56862019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5687
5688 * f-lang.c (build_fortran_types): Change name of void type to
5689 lower case.
5690 * f-typeprint.c (f_type_print_base): Print the name of the void
5691 type, rather than a fixed string.
5692 * f-valprint.c (f_decorations): Use lower case void string.
5693
1db455a7
AB
56942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5695 Chris January <chris.january@arm.com>
5696
5697 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5698 types for Fortran.
5699
b6d03bb2
AB
57002019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5701 Chris January <chris.january@arm.com>
5702 David Lecomber <david.lecomber@arm.com>
5703
5704 * f-exp.y (BINOP_INTRINSIC): New token.
5705 (exp): New parser rule handling BINOP_INTRINSIC.
5706 (f77_keywords): Add new builtin procedures.
5707 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5708 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5709 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5710 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5711 (print_unop_subexp_f): New function.
5712 (print_binop_subexp_f): New function.
5713 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5714 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5715 (dump_subexp_body_f): Likewise.
5716 (operator_check_f): Likewise.
5717 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5718 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5719
83228e93
AB
57202019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5721
5722 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5723 UNOP_KIND.
5724 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5725 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5726 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5727 (operator_length_f): New fuction.
5728 (print_subexp_f): New function.
5729 (op_name_f): New function.
5730 (dump_subexp_body_f): New function.
5731 (operator_check_f): New function.
5732 (exp_descriptor_f): Replace standard expression handling functions
5733 with new functions.
5734 * gdb/fortran-operator.def: New file.
5735 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5736 * gdb/std-operator.def: Remove UNOP_KIND.
5737
6fdcd7cc
AB
57382019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5739
5740 * std-operator.def: Remove unbalanced, stray double quote
5741 character.
5742
2e62ab40
AB
57432019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5744 Chris January <chris.january@arm.com>
5745 Daniel Everett <daniel.everett@arm.com>
5746 Nick Forrington <nick.forrington@arm.com>
5747 Richard Bunt <richard.bunt@arm.com>
5748
5749 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5750 of depth when printing anonymous structs or unions.
5751 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5752 Don't print either the top-level value, or the children if the
5753 max-depth is exceeded.
5754 (ppscm_print_children): When printing the key of a map, allow one
5755 extra level of depth.
5756 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5757 print either the top-level value, or the children if the max-depth
5758 is exceeded.
5759 (print_children): When printing the key of a map, allow one extra
5760 level of depth.
5761 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5762 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5763 (user_print_options): Initialise max_depth field.
5764 (val_print_scalar_or_string_type_p): New function.
5765 (val_print): Check to see if the max depth has been reached.
5766 (val_print_check_max_depth): Define new function.
5767 (show_print_max_depth): New function.
5768 (_initialize_valprint): Add 'print max-depth' option.
5769 * valprint.h (struct value_print_options) <max_depth>: New field.
5770 (val_print_check_max_depth): Declare new function.
5771 * NEWS: Document new feature.
5772
4be290b2
AB
57732019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5774
5775 * ada-lang.c (ada_language_defn): Initialise new field.
5776 * c-lang.c (c_is_string_type_p): New function.
5777 (c_language_defn): Initialise new field.
5778 (cplus_language_defn): Initialise new field.
5779 (asm_language_defn): Initialise new field.
5780 (minimal_language_defn): Initialise new field.
5781 * c-lang.h (c_is_string_type_p): Declare new function.
5782 * d-lang.c (d_language_defn): Initialise new field.
5783 * f-lang.c (f_is_string_type_p): New function.
5784 (f_language_defn): Initialise new field.
5785 * go-lang.c (go_is_string_type_p): New function.
5786 (go_language_defn): Initialise new field.
5787 * language.c (default_is_string_type_p): New function.
5788 (unknown_language_defn): Initialise new field.
5789 (auto_language_defn): Initialise new field.
5790 * language.h (struct language_defn) <la_is_string_type_p>: New
5791 member variable.
5792 (default_is_string_type_p): Declare new function.
5793 * m2-lang.c (m2_language_defn): Initialise new field.
5794 * objc-lang.c (objc_language_defn): Initialise new field.
5795 * opencl-lang.c (opencl_language_defn): Initialise new field.
5796 * p-lang.c (pascal_is_string_type_p): New function.
5797 (pascal_language_defn): Initialise new field.
5798 * rust-lang.c (rust_is_string_type_p): New function.
5799 (rust_language_defn): Initialise new field.
5800
721b08c6
AB
58012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5802
5803 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5804 New field.
5805 * ada-lang.c (ada_language_defn): Initialise new field.
5806 * c-lang.c (c_language_defn): Likewise.
5807 (cplus_language_defn): Likewise.
5808 (asm_language_defn): Likewise.
5809 (minimal_language_defn): Likewise.
5810 * d-lang.c (d_language_defn): Likewise.
5811 * f-lang.c (f_language_defn): Likewise.
5812 * go-lang.c (go_language_defn): Likewise.
5813 * language.c (unknown_language_defn): Likewise.
5814 (auto_language_defn): Likewise.
5815 * m2-lang.c (m2_language_defn): Likewise.
5816 * objc-lang.c (objc_language_defn): Likewise.
5817 * opencl-lang.c (opencl_language_defn): Likewise.
5818 * p-lang.c (pascal_language_defn): Likewise.
5819 * rust-lang.c (rust_language_defn): Likewise.
5820
fc913e53
AB
58212019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5822
5823 * ada-lang.c (ada_is_character_type): Change return type to bool.
5824 (ada_is_string_type): Likewise.
5825 * ada-lang.h (ada_is_character_type): Update declaration
5826 (ada_is_string_type): Likewise.
5827
fa731fa0
PW
58282019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5829
5830 Support style in 'frame|thread apply'
5831
5832 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5833 * record.c (record_start, record_stop): Update callers of
5834 execute_command_to_string with false.
5835 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5836 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5837 methods.
5838 (class string_file): New constructor with term_out parameter.
5839 Override methods term_out and can_emit_style_escape. New member
5840 term_out.
5841 (class stdio_file): Override can_emit_style_escape.
5842 (class tee_file): Override term_out and can_emit_style_escape.
5843 * utils.h (can_emit_style_escape): Remove.
5844 * utils.c (can_emit_style_escape): Likewise.
5845 Update all callers of can_emit_style_escape (SOMESTREAM) to
5846 SOMESTREAM->can_emit_style_escape.
5847 * source-cache.c (source_cache::get_source_lines): Likewise.
5848 * stack.c (frame_apply_command_count): Call execute_command_to_string
5849 passing the term_out characteristic of the current gdb_stdout.
5850 * thread.c (thr_try_catch_cmd): Likewise.
5851 * top.c (execute_command_to_string): pass term_out parameter
5852 to construct the string_file for the command output.
5853 * ui-file.c (term_cli_styling): New function (most code moved
5854 from utils.c can_emit_style_escape).
5855 (string_file::string_file, string_file::can_emit_style_escape,
5856 stdio_file::can_emit_style_escape, tee_file::term_out,
5857 tee_file::can_emit_style_escape): New functions.
5858
136afab8
PW
58592019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5860
5861 * NEWS: Mention the new set|show may-call-functions.
5862 * infcall.c (may_call_functions_p): New variable.
5863 (show_may_call_functions_p): New function.
5864 (call_function_by_hand_dummy): Throws an error if not
5865 may-call-functions.
5866 (_initialize_infcall): Call add_setshow_boolean_cmd for
5867 may-call-functions.
5868
725cbb63
KS
58692019-04-25 Keith Seitz <keiths@redhat.com>
5870
5871 PR c++/24367
5872 * cp-support.c (inspect_type): Don't attempt substitutions
5873 of symbol with the same name.
5874
3d1cbb78
TT
58752019-04-25 Tom Tromey <tromey@adacore.com>
5876
5877 PR gdb/24475:
5878 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5879 static.
5880
94aeb44b
TT
58812019-04-25 Tom Tromey <tromey@adacore.com>
5882
5883 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5884 rvalue reference.
5885 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5886 (gdb_xml_parser::parse): Use std::move.
5887 * python/python-internal.h (gdbpy_convert_exception): Take a const
5888 reference.
5889 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5890 std::move.
5891 * python/py-utils.c (gdbpy_convert_exception): Take a const
5892 reference.
5893 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5894 Use std::move.
5895 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5896 Use std::move.
5897 * mi/mi-main.c (mi_print_exception): Take a const reference.
5898 * main.c (handle_command_errors): Take a const reference.
5899 * linespec.c (parse_linespec): Use std::move.
5900 * infcall.c (run_inferior_call): Use std::move.
5901 (call_function_by_hand_dummy): Use std::move.
5902 * exec.c (try_open_exec_file): Use std::move.
5903 * exceptions.h (exception_print, exception_fprintf)
5904 (exception_print_same): Update.
5905 * exceptions.c (print_exception, exception_print)
5906 (exception_fprintf, exception_print_same): Change parameters to
5907 const reference.
5908 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5909 * common/new-op.c: Use std::move.
5910 * common/common-exceptions.h (struct gdb_exception): Add move
5911 constructor.
5912 (struct gdb_exception_error, struct gdb_exception_quit, struct
5913 gdb_quit_bad_alloc): Change constructor to move constructor.
5914 (throw_exception): Change parameter to rvalue reference.
5915 * common/common-exceptions.c (throw_exception): Take rvalue
5916 reference.
5917 * cli/cli-interp.c (safe_execute_command): Use std::move.
5918 * breakpoint.c (insert_bp_location, location_to_sals): Use
5919 std::move.
5920
680d7fd5
TT
59212019-04-25 Tom Tromey <tromey@adacore.com>
5922
5923 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5924 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5925 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5926 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5927 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5928 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5929 guile/scm-value.c: Use unpack.
5930 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5931 gdbscm_gdb_exception.
5932 (gdbscm_throw_gdb_exception): Likewise.
5933 (struct gdbscm_gdb_exception): New.
5934 (unpack): New function.
5935 (gdbscm_wrap): Use unpack.
5936
c6fdd8b2
TT
59372019-04-25 Tom Tromey <tromey@adacore.com>
5938
5939 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5940 (gdb_rl_callback_handler): Use std::move.
5941 * common/common-exceptions.h (struct gdb_exception): Add move
5942 assignment operator.
5943 (throw_exception_sjlj): Change "exception" to const reference.
5944 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5945 (throw_exception_sjlj): Change "exception" to const reference.
5946
cc06b668
TT
59472019-04-25 Tom Tromey <tromey@adacore.com>
5948
5949 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5950 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5951 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5952 Update.
5953 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5954 Update.
5955 * mi/mi-interp.c (mi_interp::exec): Update.
5956 * linespec.c (parse_linespec): Update.
5957 * infcall.c (run_inferior_call): Update.
5958 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5959 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5960 (gdbscm_lookup_global_symbol): Update.
5961 * guile/scm-param.c (gdbscm_parameter_value): Update.
5962 * guile/scm-frame.c (gdbscm_frame_read_register)
5963 (gdbscm_frame_read_var): Update.
5964 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5965 * exec.c (try_open_exec_file): Update.
5966 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5967 (gdb_rl_callback_handler): Update.
5968 * common/common-exceptions.h (exception_none): Don't declare.
5969 * common/common-exceptions.c (exception_none): Don't define.
5970 (struct catcher) <exception>: Update.
5971 * cli/cli-interp.c (safe_execute_command): Update.
5972 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5973
cf532bd1
AT
59742019-04-25 Ali Tamur <tamur@google.com>
5975
5976 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5977 (read_attribute_value): Likewise.
5978 (dwarf2_read_addr_index): Update comment.
5979 (read_str_index): Add DW_FORM_strx.
5980 (dwarf2_string_attr): Likewise.
5981 (dwarf2_const_value_attr): Likewise.
5982 (dump_die_shallow): Likewise.
5983 (dwarf2_fetch_constant_bytes): Likewise.
5984 (skip_form_bytes): Likewise.
5985 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5986
82433e3e
SDJ
59872019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5988
5989 PR corefiles/11608
5990 PR corefiles/18187
5991 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5992 OFFSET. Verify if current mapping contains an ELF header.
5993 (linux_find_memory_regions_full): Adjust call to
5994 dump_mapping_p.
5995
723adb65
SL
59962019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5997 Kang Li <kanglictf@gmail.com>
5998
5999 PR gdb/21600
6000
6001 * dwarf2-frame.c (read_initial_length): Be consistent about using
6002 unsigned representation of length.
6003 (decode_frame_entry_1): Likewise. Check for wraparound of
6004 end pointer as well as buffer overflow.
6005
596179f7
SDJ
60062019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6007
6008 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6009 "vq".
6010
a59240a4
TT
60112019-04-24 Tom Tromey <tromey@adacore.com>
6012
6013 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6014
f872fdbb
AB
60152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6016
6017 * s12z-tdep.c (s12z_unwind_pc): Delete.
6018 (s12z_unwind_sp): Delete.
6019 (s12z_gdbarch_init): Don't register deleted functions with
6020 gdbarch.
6021
b614e6f3
AB
60222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6023
6024 * rl78-tdep.c (rl78_unwind_sp): Delete.
6025 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6026
14faed38
AB
60272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6028
6029 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6030 (xstormy16_unwind_pc): Delete.
6031 (xstormy16_dummy_id): Delete.
6032 (xstormy16_gdbarch_init): Don't register deleted functions with
6033 gdbarch.
6034
541aad8a
AB
60352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6036
6037 * vax-tdep.c (vax_unwind_pc): Delete.
6038 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6039
29222070
AB
60402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6041
6042 * v850-tdep.c (v850_unwind_sp): Delete.
6043 (v850_unwind_pc): Delete.
6044 (v850_dummy_id): Delete.
6045 (v850_gdbarch_init): Don't register deleted functions with
6046 gdbarch.
6047
0f534d76
AB
60482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6049
6050 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6051 (tilegx_unwind_pc): Delete.
6052 (tilegx_unwind_dummy_id): Delete.
6053 (tilegx_gdbarch_init): Don't register deleted functions with
6054 gdbarch.
6055
1ba7b7f9
AB
60562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6057
6058 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6059 (tic6x_dummy_id): Delete.
6060 (tic6x_gdbarch_init): Don't register deleted functions with
6061 gdbarch.
6062
d31f262c
AB
60632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6064
6065 * sparc-tdep.c (sparc_unwind_pc): Delete.
6066 (sparc32_gdbarch_init): Don't register deleted function with
6067 gdbarch.
6068
6d14d64d
AB
60692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6070
6071 * sh-tdep.c (sh_unwind_sp): Delete.
6072 (sh_unwind_pc): Delete.
6073 (sh_dummy_id): Delete.
6074 (sh_gdbarch_init): Don't register deleted functions with
6075 gdbarch.
6076
a40dde9d
AB
60772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6078
6079 * score-tdep.c (score_unwind_sp): Delete.
6080 (score_unwind_pc): Delete.
6081 (score_dummy_id): Delete.
6082 (score_gdbarch_init): Don't register deleted functions with
6083 gdbarch.
6084
47c47d69
AB
60852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6086
6087 * rx-tdep.c (rx_unwind_pc): Delete.
6088 (rx_unwind_sp): Delete.
6089 (rx_dummy_id): Delete.
6090 (rx_gdbarch_init): Don't register deleted functions with
6091 gdbarch. Update comment.
6092
833a4480
AB
60932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6094
6095 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6096 (rs6000_dummy_id): Delete.
6097 (rs6000_gdbarch_init): Don't register deleted functions with
6098 gdbarch.
6099
3f2cef49
AB
61002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6101
6102 * or1k-tdep.c (or1k_dummy_id): Delete.
6103 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6104
96acf884
AB
61052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6106
6107 * nios2-tdep.c (nios2_dummy_id): Delete.
6108 (nios2_unwind_sp): Delete.
6109 (nios2_gdbarch_init): Don't register deleted functions with
6110 gdbarch.
6111
ca0ab0aa
AB
61122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6113
6114 * nds32-tdep.c (nds32_dummy_id): Delete.
6115 (nds32_unwind_pc): Delete.
6116 (nds32_unwind_sp): Delete.
6117 (nds32_gdbarch_init): Don't register deleted functions with
6118 gdbarch.
6119
c8259044
AB
61202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6121
6122 * msp430-tdep.c (msp430_unwind_pc): Delete.
6123 (msp430_unwind_sp): Delete.
6124 (msp430_dummy_id): Delete.
6125 (msp430_gdbarch_init): Don't register deleted functions with
6126 gdbarch.
6127
27f113c8
AB
61282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6129
6130 * moxie-tdep.c (moxie_unwind_sp): Delete.
6131 (moxie_unwind_pc): Delete.
6132 (moxie_dummy_id): Delete.
6133 (moxie_gdbarch_init): Don't register deleted functions with
6134 gdbarch.
6135
aee6c3cd
AB
61362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6137
6138 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6139 (mn10300_unwind_pc): Delete.
6140 (mn10300_unwind_sp): Delete.
6141 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6142 mn10300_unwind_sp.
6143 (mn10300_frame_unwind_init): Don't register deleted functions with
6144 gdbarch.
6145
8e2b5aea
AB
61462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6147
6148 * mep-tdep.c (mep_unwind_pc): Delete.
6149 (mep_unwind_sp): Delete.
6150 (mep_dummy_id): Delete.
6151 (mep_gdbarch_init): Don't register deleted functions with
6152 gdbarch.
6153
43cf3ede
AB
61542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6155
6156 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6157 (m68hc11_unwind_sp): Delete.
6158 (m68hc11_gdbarch_init): Don't register deleted functions with
6159 gdbarch.
6160
5e79b7bb
AB
61612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6162
6163 * m32r-tdep.c (m32r_unwind_sp): Delete.
6164 (m32r_unwind_pc): Delete.
6165 (m32r_dummy_id): Delete.
6166 (m32r_gdbarch_init): Don't register deleted functions with
6167 gdbarch.
6168
89b268d8
AB
61692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6170
6171 * m32c-tdep.c (m32c_unwind_pc): Delete.
6172 (m32c_unwind_sp): Delete.
6173 (m32c_dummy_id): Delete.
6174 (m32c_gdbarch_init): Don't register deleted functions with
6175 gdbarch.
6176
946c28d2
AB
61772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6178
6179 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6180 (lm32_unwind_pc): Delete.
6181 (lm32_dummy_id): Delete.
6182 (lm32_gdbarch_init): Don't register deleted functions with
6183 gdbarch.
6184
bf12844a
AB
61852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6186
6187 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6188 (iq2000_unwind_pc): Delete.
6189 (iq2000_dummy_id): Delete.
6190 (iq2000_gdbarch_init): Don't register deleted functions with
6191 gdbarch.
6192
ecbc06d2
AB
61932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6194
6195 * nds32-tdep.c (nds32_type_align): Delete.
6196 (nds32_push_dummy_call): Use type_align instead.
6197
030197b4
AB
61982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6199
6200 * arm-tdep.c (arm_type_align): Only handle vector override case.
6201 (arm_push_dummy_call): Use type_align.
6202 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6203
b907456c
AB
62042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6205
6206 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6207 case.
6208 (pass_on_stack): Use type_align.
6209 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6210 function.
6211
9e97ba43
TT
62122019-04-23 Tom Tromey <tromey@adacore.com>
6213
6214 * dwarf2read.c (line_header::file_name_at): Remove unused
6215 overload.
6216
6892f601
TV
62172019-04-23 Tom de Vries <tdevries@suse.de>
6218
6219 PR gdb/24438
6220 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6221 invocation.
6222
336d760d
AT
6223
62242019-03-27 Ali Tamur <tamur@google.com>
6225
6226 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6227 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6228 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6229 (dwarf_expr_context::get_addr_index): Likewise
6230 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6231 (symbol_needs_eval_context::get_addr_index): Likewise
6232 (disassemble_dwarf_expression): Add DW_OP_addrx
6233 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6234 (read_cutu_die_from_dwo): Update comment
6235 (skip_one_die): Add DW_FORM_addrx
6236 (read_attribute_value): Likewise
6237 (var_decode_location): Add DW_OP_addrx
6238 (dwarf2_const_value_attr): Add DW_FORM_addrx
6239 (dump_die_shallow): Likewise
6240 (dwarf2_fetch_constant_bytes): Likewise
6241 (decode_locdesc): Add DW_OP_addrx
6242 (skip_form_bytes): Add DW_FORM_addrx
6243
ad9d13f8
AT
62442019-04-22 Ali Tamur <tamur@google.com>
6245
6246 * MAINTAINERS (Write After Approval): Add self.
6247
d70cc3ba
SM
62482019-04-22 Simon Marchi <simon.marchi@efficios.com>
6249
6250 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6251 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6252 (open_symbol_file_object): Likewise.
6253 (svr4_default_sos): Add info parameter.
6254 (svr4_read_so_list): Likewise.
6255 (svr4_current_sos_direct): Adjust functions calls to pass down
6256 info.
6257 (svr4_current_sos_1): Add info parameter.
6258 (svr4_current_sos): Call get_svr4_info, pass info down to
6259 svr4_current_sos_1.
6260 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6261 get_svr4_info.
6262 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6263 get_svr4_info.
6264 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6265 to get_svr4_info.
6266 (probes_table_remove_objfile_probes): Likewise.
6267 (register_solib_event_probe): Add info parameter.
6268 (solist_update_incremental): Pass info parameter down to
6269 svr4_read_so_list.
6270 (disable_probes_interface): Add info parameter.
6271 (svr4_handle_solib_event): Pass current_program_space to
6272 get_svr4_info. Adjust disable_probes_interface cleanup.
6273 (svr4_create_probe_breakpoints): Add info parameter, pass it
6274 down to register_solib_event_probe.
6275 (svr4_create_solib_event_breakpoints): Add info parameter,
6276 pass it down to svr4_create_probe_breakpoints.
6277 (enable_break): Pass info down to
6278 svr4_create_solib_event_breakpoints.
6279 (svr4_solib_create_inferior_hook): Pass current_program_space to
6280 get_svr4_info.
6281 (svr4_clear_solib): Likewise.
6282
7905fc35
PA
62832019-04-22 Pedro Alves <palves@redhat.com>
6284
6285 * solib-svr4.c (svr4_free_objfile_observer): New.
6286 (probe_and_action::objfile): New field.
6287 (probes_table_htab_remove_objfile_probes)
6288 (probes_table_remove_objfile_probes): New functions.
6289 (register_solib_event_probe): Add 'objfile' parameter. Store it
6290 in the new probe_and_action. Don't store the probe in 'lookup'.
6291 (svr4_create_probe_breakpoints): Pass objfile to
6292 register_solib_event_probe.
6293 (_initialize_svr4_solib): Register a free_objfile observer.
6294
fb881986
TT
62952019-04-19 Tom Tromey <tom@tromey.com>
6296
6297 * common/queue.h: Remove.
6298
8732db6c
TT
62992019-04-19 Tom Tromey <tom@tromey.com>
6300
6301 * event-loop.c: Don't include "common/queue.h".
6302
97dfbadd
TT
63032019-04-19 Tom Tromey <tom@tromey.com>
6304
6305 * remote.c (remote_target): Use delete.
6306 * remote-notif.h: Include <list>, not "common/queue.h".
6307 (notif_client_p): Remove typedef.
6308 (remote_notif_state): Add constructor, destructor, initializer.
6309 <notif_queue>: Now a std::list.
6310 (remote_notif_state_xfree): Don't declare.
6311 * remote-notif.c (remote_notif_process, handle_notification)
6312 (remote_notif_state_allocate): Update.
6313 (~remote_notif_state): Rename from remote_notif_state_xfree.
6314
cf250e36
TT
63152019-04-19 Tom Tromey <tom@tromey.com>
6316
6317 * symfile.c (reread_symbols): Update.
6318 * objfiles.c (objfile_register_static_link)
6319 (objfile_lookup_static_link): Update
6320 (~objfile) Don't delete static_links.
6321 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6322
61f4b350
TT
63232019-04-19 Tom Tromey <tom@tromey.com>
6324
6325 * type-stack.h (struct type_stack) <insert>: Constify string.
6326 * type-stack.c (type_stack::insert): Constify string.
6327 * gdbtypes.h (lookup_template_type): Update.
6328 (address_space_name_to_int): Update.
6329 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6330 const.
6331 (lookup_template_type): Make name const.
6332 * c-exp.y: Update rules.
6333 (lex_one_token, classify_name, classify_inner_name)
6334 (c_print_token): Update.
6335 * p-exp.y: Update rules.
6336 (yylex): Update.
6337 * f-exp.y: Update rules.
6338 (yylex): Update.
6339 * d-exp.y: Update rules.
6340 (lex_one_token, classify_name, classify_inner_name): Update.
6341 * parse.c (write_dollar_variable, copy_name): Return std::string.
6342 * parser-defs.h (copy_name): Change return type.
6343 * m2-exp.y: Update rules.
6344 (yylex): Update.
6345 * go-exp.y (lex_one_token): Update.
6346 Update rules.
6347 (classify_unsafe_function, classify_packaged_name)
6348 (classify_name, yylex): Update.
6349
189b8c2e
ST
63502019-04-19 Sergei Trofimovich <siarheit@google.com>
6351
6352 * configure.ac: add --enable-source-highlight switch.
6353 * configure: Regenerate.
6354 * top.c (print_gdb_version): plumb --enable-source-highlight
6355 status to "show configuration".
6356
8ecb59f8
TT
63572019-04-19 Tom Tromey <tromey@adacore.com>
6358
6359 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6360 Check ADA_TYPE_P.
6361 (empty_record, ada_template_to_fixed_record_type_1)
6362 (template_to_static_fixed_type)
6363 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6364 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6365 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6366 macros.
6367
62160ec9
TT
63682019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6369
6370 PR symtab/24423:
6371 * source.c (print_source_lines_base): Advance "iter" when a
6372 control character is seen.
6373
f2ae8bc8
PW
63742019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6375
6376 * inferior.h (struct infcall_suspend_state_deleter):
6377 Catch exception in destructor to avoid crash.
6378
d563b953
PW
63792019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6380
6381 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6382 close to the add_com "shell".
6383
dc34c897
TT
63842019-04-18 Tom Tromey <tromey@adacore.com>
6385
6386 * process-stratum-target.h (class process_stratum_target)
6387 <stratum>: Add "final".
6388
a12e5744
TT
63892019-04-17 Tom Tromey <tromey@adacore.com>
6390
6391 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6392 against nullptr before use.
6393
a7e559cc
AH
63942019-04-17 Alan Hayward <alan.hayward@arm.com>
6395
6396 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6397
c01660c6
AB
63982019-04-17 Jim Wilson <jimw@sifive.com>
6399 Andrew Burgess <andrew.burgess@embecosm.com>
6400
6401 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6402 code read might fail, assume 4-byte breakpoint in that case.
6403
4aa866af
LS
64042019-04-15 Leszek Swirski <leszeks@google.com>
6405
6406 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6407 rather than a hand-rolled POD check when checking for forced MEMORY
6408 classification.
6409
48574d91
AH
64102019-04-15 Alan Hayward <alan.hayward@arm.com>
6411
6412 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6413 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6414 function.
6415 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6416 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6417 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6418 declaration.
6419
4da037ef
AH
64202019-04-15 Alan Hayward <alan.hayward@arm.com>
6421
6422 * aarch64-linux-nat.c
6423 (aarch64_linux_nat_target::thread_architecture): Add override.
6424 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6425 each VQ.
6426
ccb8d7e8
AH
64272019-04-15 Alan Hayward <alan.hayward@arm.com>
6428
6429 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6430
35add35e
AB
64312019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6432
6433 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6434 target types of size 96-bits, add some additional comments, and
6435 check that the builtin type we found was the correct size.
6436
51196bbc
EZ
64372019-04-12 Eli Zaretskii <eliz@gnu.org>
6438
6439 * utils.c (prompt_for_continue): Don't restore the styling at the
6440 end, as applied_style has the wrong value. This fixes styling in
6441 long lists of file names that are interrupted by the "Continue?"
6442 prompt.
6443
62253a61
AB
64442019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6445
6446 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6447 * c-lang.c (c_language_defn): Likewise.
6448 (cplus_language_defn): Likewise.
6449 (asm_language_defn): Likewise.
6450 (minimal_language_defn): Likewise.
6451 * d-lang.c (d_language_defn): Likewise.
6452 * f-lang.c (f_language_defn): Likewise.
6453 * go-lang.c (go_language_defn): Likewise.
6454 * language.c (unknown_language_defn): Likewise.
6455 (auto_language_defn): Likewise.
6456 * language.h (struct language_defn): Remove la_magic field.
6457 (LANG_MAGIC): Delete.
6458 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6459 * objc-lang.c (objc_language_defn): Likewise.
6460 * opencl-lang.c (opencl_language_defn): Likewise.
6461 * p-lang.c (pascal_language_defn): Likewise.
6462 * rust-lang.c (rust_language_defn): Likewise.
6463
a9158a86
AB
64642019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6465
6466 * riscv-tdep.c (riscv_type_align): New function.
6467 (riscv_type_alignment): Delete.
6468 (riscv_arg_location): Use 'type_align'.
6469 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6470
41077b66
AB
64712019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6472
6473 * gdbtypes.c (type_align): A struct with no non-static fields also
6474 has alignment of 1.
6475
9f0272f8
AB
64762019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6477
6478 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6479 component to 0.
6480 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6481 member.
6482 (riscv_struct_info::analyse): New implementation using new
6483 analyse_inner member function.
6484 (riscv_struct_info::field_offset): New member function.
6485 (riscv_struct_info::m_offsets): New member variable.
6486 (riscv_struct_info::analyse_inner): New private member function,
6487 takes the old implementation of riscv_struct_info::analyse but
6488 extended to track field offsets.
6489 (riscv_call_arg_struct): Update the struct folding special cases
6490 to handle cases where empty C++ structs, which are non-zero
6491 length, are found.
6492 (riscv_arg_location): Initialise the length of each location, a
6493 non-zero length now indicates the location is in use.
6494 (riscv_push_dummy_call): Allow for the first location having a
6495 non-zero offset when setting up arguments.
6496 (riscv_return_value): Likewise, but for return values.
6497
02cf60c7
TT
64982019-04-11 Tom Tromey <tromey@adacore.com>
6499
6500 * utils.c (internal_vproblem): Make "msg" const.
6501
68811f8f
AH
65022019-04-11 Alan Hayward <alan.hayward@arm.com>
6503
6504 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6505 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6506 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6507 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6508
3f52fdbc
KB
65092019-04-10 Kevin Buettner <kevinb@redhat.com>
6510
6511 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6512 function.
6513 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6514 of amd64_collect_native_gregset.
6515 (amd64_linux_nat_target::store_registers): Likewise.
6516
e9ad22ee
TT
65172019-04-10 Tom Tromey <tom@tromey.com>
6518
6519 * symtab.c (lookup_global_symbol_from_objfile)
6520 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6521 * objfiles.h (class separate_debug_iterator): New.
6522 (class separate_debug_range): New.
6523 (struct objfile) <separate_debug_objfiles>: New method.
6524 (objfile_separate_debug_iterate): Don't declare.
6525 * objfiles.c (separate_debug_iterator::operator++): Rename from
6526 objfile_separate_debug_iterate.
6527 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6528 iterator.
6529 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6530 iterator.
6531
ee371134
TT
65322019-04-10 Tom Tromey <tom@tromey.com>
6533
6534 * symfile.c (reread_symbols): Remove old comment.
6535 * objfiles.c (free_all_objfiles): Fix a typo.
6536
bf227d61
TT
65372019-04-10 Tom Tromey <tom@tromey.com>
6538
6539 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6540 * minsyms.c (lookup_minimal_symbol): Use foreach.
6541 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6542 (lookup_minimal_symbol_solib_trampoline): Likewise.
6543 * symfile.c (reread_symbols): Use foreach.
6544
8dc433a0
TT
65452019-04-09 Ivan Begert <ivanbegert@gmail.com>
6546 Tom Tromey <tromey@adacore.com>
6547
6548 PR rust/24414:
6549 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6550 (rust_lex_int_test): Change "value" to be LONGEST.
6551 (rust_lex_tests): Add test for long integer literal.
6552
9ab8741a
TT
65532019-04-09 Tom Tromey <tromey@adacore.com>
6554
6555 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6556 to bool.
6557 (extended_remote_target::attach): Update.
6558 (remote_target::remote_notice_new_inferior): Update.
6559 (remote_target::add_current_inferior_and_thread): Update.
6560 * inferior.c (exit_inferior_1): Use "false".
6561 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6562
e242fd12
SM
65632019-04-09 Simon Marchi <simon.marchi@efficios.com>
6564
9ca1957f 6565 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6566 the "start" command.
6567
2b0c8b01
KB
65682019-04-08 Kevin Buettner <kevinb@redhat.com>
6569
6570 * python/py-inferior.c (infpy_thread_from_thread_handle):
6571 Adjust comments to reflect renaming of thread_from_thread_handle
6572 to thread_from_handle. Adjust keywords. Fix type error message.
6573 (inferior_object_methods): Add thread_from_handle. Retain
6574 thread_from_thread_handle, but mark it as deprecated.
6575
50a82723
KB
65762019-04-08 Kevin Buettner <kevinb@redhat.com>
6577
6578 * gdbthread.h (find_thread_by_handle): Revise declaration.
6579 * thread.c (find_thread_by_handle): Likewise. Adjust
6580 implementation too.
6581 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6582 support for buffer objects as handles.
6583
cf63b016
KB
65842019-04-08 Kevin Buettner <kevinb@redhat.com>
6585
6586 * python/py-infthread.c (thpy_thread_handle): New function.
6587 (thread_object_methods): Register thpy_thread_handle.
6588
3d6c6204
KB
65892019-04-08 Kevin Buettner <kevinb@redhat.com>
6590
6591 * gdbthread.h (thread_to_thread_handle): Declare.
6592 * thread.c (gdbtypes.h): Include.
6593 (thread_to_thread_handle): New function.
6594
6595 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6596 (target_thread_info_to_thread_handle): Declare.
6597 * target.c (target_thread_info_to_thread_handle): New function.
6598 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6599 * target-delegates.c: Regenerate.
6600
6601 * linux-thread-db.c (class thread_db_target): Add method
6602 thread_info_to_thread_handle.
6603 (thread_db_target::thread_info_to_thread_handle): Define.
6604 * remote.c (class remote_target): Add new method
6605 thread_info_to_thread_handle.
6606 (remote_target::thread_info_to_thread_handle): Define.
6607
56be6ea8
PA
66082019-04-08 Pedro Alves <palves@redhat.com>
6609
6610 * common/common-exceptions.c (throw_exception): Don't create
6611 named object to throw; throw directly.
6612 (throw_it): Likewise. Don't initialize gdb_exception::message
6613 here, with new; pass FMT and AP to the ctor instead.
6614 * common/common-exceptions.h: Include <string>.
6615 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6616 const char *, va_list)): New ctor. Use std::make_shared.
6617 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6618 errors)): Delete.
6619 (gdb_exception_error::gdb_exception_error(enum errors, const char
6620 *, va_list)): New.
6621 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6622 Add assertion.
6623 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6624 errors)): Delete.
6625 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6626 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6627 Add assertion.
6628
eedc3f4f
TT
66292019-04-08 Tom Tromey <tom@tromey.com>
6630
6631 * valops.c (value_rtti_indirect_type): Replace throw_exception
6632 with throw.
6633 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6634 with throw.
6635 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6636 throw.
6637 * target.c (target_translate_tls_address): Replace throw_exception
6638 with throw.
6639 * stack.c (frame_apply_command_count): Replace throw_exception
6640 with throw.
6641 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6642 throw.
6643 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6644 with throw.
6645 * rs6000-tdep.c (rs6000_frame_cache)
6646 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6647 * remote.c: Replace throw_exception with throw.
6648 * record-full.c (record_full_message, record_full_wait_1)
6649 (record_full_restore): Replace throw_exception with throw.
6650 * record-btrace.c:
6651 (get_thread_current_frame_id, record_btrace_start_replaying)
6652 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6653 (cmd_record_btrace_start): Replace throw_exception with throw.
6654 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6655 throw.
6656 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6657 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6658 * linespec.c:
6659 (find_linespec_symbols): Replace throw_exception with throw.
6660 * infrun.c (displaced_step_prepare, resume): Replace
6661 throw_exception with throw.
6662 * infcmd.c (post_create_inferior): Replace throw_exception with
6663 throw.
6664 * inf-loop.c (inferior_event_handler): Replace throw_exception
6665 with throw.
6666 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6667 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6668 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6669 (get_prev_frame_always, get_frame_pc_if_available)
6670 (get_frame_address_in_block_if_available, get_frame_language):
6671 Replace throw_exception with throw.
6672 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6673 throw_exception with throw.
6674 * eval.c (fetch_subexp_value, evaluate_var_value)
6675 (evaluate_funcall, evaluate_subexp_standard): Replace
6676 throw_exception with throw.
6677 * dwarf2loc.c (call_site_find_chain)
6678 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6679 Replace throw_exception with throw.
6680 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6681 with throw.
6682 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6683 throw.
6684 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6685 * completer.c (complete_line_internal): Replace throw_exception
6686 with throw.
6687 * compile/compile-object-run.c (compile_object_run): Replace
6688 throw_exception with throw.
6689 * cli/cli-script.c (process_next_line): Replace throw_exception
6690 with throw.
6691 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6692 (btrace_enable, btrace_maint_update_pt_packets): Replace
6693 throw_exception with throw.
6694 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6695 throw_exception with throw.
6696 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6697 throw_exception with throw.
6698 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6699 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6700 * aarch64-tdep.c (aarch64_make_prologue_cache)
6701 (aarch64_make_stub_cache): Replace throw_exception with throw.
6702
26003a20
TT
67032019-04-08 Tom Tromey <tom@tromey.com>
6704
6705 * common/common-exceptions.c (throw_exception): Rename from
6706 throw_exception_cxx. Remove old copy. Make argument const.
6707 (throw_it): Create and throw exception objects directly.
6708 * common/common-exceptions.h (throw_exception): Make argument
6709 const.
6710 (struct gdb_exception_error): Add constructor.
6711 (struct gdb_exception_quit): Add constructor.
6712
d272eb37
TT
67132019-04-08 Tom Tromey <tom@tromey.com>
6714
6715 * common/common-exceptions.h (exception_rethrow): Don't declare.
6716 (TRY_SJLJ): Update comment.
6717 (TRY, CATCH, END_CATCH): Remove.
6718 * common/common-exceptions.c (exception_rethrow): Remove.
6719
230d2906
TT
67202019-04-08 Tom Tromey <tom@tromey.com>
6721
6722 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6723 Remove.
6724 (gdb_exception_error): Rename from
6725 gdb_exception_RETURN_MASK_ERROR.
6726 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6727 (gdb_quit_bad_alloc): Update.
6728 * aarch64-tdep.c: Update.
6729 * ada-lang.c: Update.
6730 * ada-typeprint.c: Update.
6731 * ada-valprint.c: Update.
6732 * amd64-tdep.c: Update.
6733 * arch-utils.c: Update.
6734 * break-catch-throw.c: Update.
6735 * breakpoint.c: Update.
6736 * btrace.c: Update.
6737 * c-varobj.c: Update.
6738 * cli/cli-cmds.c: Update.
6739 * cli/cli-interp.c: Update.
6740 * cli/cli-script.c: Update.
6741 * common/common-exceptions.c: Update.
6742 * common/new-op.c: Update.
6743 * common/selftest.c: Update.
6744 * compile/compile-c-symbols.c: Update.
6745 * compile/compile-cplus-symbols.c: Update.
6746 * compile/compile-object-load.c: Update.
6747 * compile/compile-object-run.c: Update.
6748 * completer.c: Update.
6749 * corelow.c: Update.
6750 * cp-abi.c: Update.
6751 * cp-support.c: Update.
6752 * cp-valprint.c: Update.
6753 * darwin-nat.c: Update.
6754 * disasm-selftests.c: Update.
6755 * dtrace-probe.c: Update.
6756 * dwarf-index-cache.c: Update.
6757 * dwarf-index-write.c: Update.
6758 * dwarf2-frame-tailcall.c: Update.
6759 * dwarf2-frame.c: Update.
6760 * dwarf2loc.c: Update.
6761 * dwarf2read.c: Update.
6762 * eval.c: Update.
6763 * event-loop.c: Update.
6764 * event-top.c: Update.
6765 * exec.c: Update.
6766 * f-valprint.c: Update.
6767 * fbsd-tdep.c: Update.
6768 * frame-unwind.c: Update.
6769 * frame.c: Update.
6770 * gdbtypes.c: Update.
6771 * gnu-v3-abi.c: Update.
6772 * guile/guile-internal.h: Update.
6773 * guile/scm-block.c: Update.
6774 * guile/scm-breakpoint.c: Update.
6775 * guile/scm-cmd.c: Update.
6776 * guile/scm-disasm.c: Update.
6777 * guile/scm-frame.c: Update.
6778 * guile/scm-lazy-string.c: Update.
6779 * guile/scm-math.c: Update.
6780 * guile/scm-param.c: Update.
6781 * guile/scm-ports.c: Update.
6782 * guile/scm-pretty-print.c: Update.
6783 * guile/scm-symbol.c: Update.
6784 * guile/scm-symtab.c: Update.
6785 * guile/scm-type.c: Update.
6786 * guile/scm-value.c: Update.
6787 * i386-linux-tdep.c: Update.
6788 * i386-tdep.c: Update.
6789 * inf-loop.c: Update.
6790 * infcall.c: Update.
6791 * infcmd.c: Update.
6792 * infrun.c: Update.
6793 * jit.c: Update.
6794 * language.c: Update.
6795 * linespec.c: Update.
6796 * linux-fork.c: Update.
6797 * linux-nat.c: Update.
6798 * linux-tdep.c: Update.
6799 * linux-thread-db.c: Update.
6800 * main.c: Update.
6801 * mi/mi-cmd-break.c: Update.
6802 * mi/mi-cmd-stack.c: Update.
6803 * mi/mi-interp.c: Update.
6804 * mi/mi-main.c: Update.
6805 * objc-lang.c: Update.
6806 * p-valprint.c: Update.
6807 * parse.c: Update.
6808 * ppc-linux-tdep.c: Update.
6809 * printcmd.c: Update.
6810 * python/py-arch.c: Update.
6811 * python/py-breakpoint.c: Update.
6812 * python/py-cmd.c: Update.
6813 * python/py-finishbreakpoint.c: Update.
6814 * python/py-frame.c: Update.
6815 * python/py-framefilter.c: Update.
6816 * python/py-gdb-readline.c: Update.
6817 * python/py-inferior.c: Update.
6818 * python/py-infthread.c: Update.
6819 * python/py-lazy-string.c: Update.
6820 * python/py-linetable.c: Update.
6821 * python/py-objfile.c: Update.
6822 * python/py-param.c: Update.
6823 * python/py-prettyprint.c: Update.
6824 * python/py-progspace.c: Update.
6825 * python/py-record-btrace.c: Update.
6826 * python/py-record.c: Update.
6827 * python/py-symbol.c: Update.
6828 * python/py-type.c: Update.
6829 * python/py-unwind.c: Update.
6830 * python/py-utils.c: Update.
6831 * python/py-value.c: Update.
6832 * python/python.c: Update.
6833 * record-btrace.c: Update.
6834 * record-full.c: Update.
6835 * remote-fileio.c: Update.
6836 * remote.c: Update.
6837 * riscv-tdep.c: Update.
6838 * rs6000-aix-tdep.c: Update.
6839 * rs6000-tdep.c: Update.
6840 * rust-exp.y: Update.
6841 * rust-lang.c: Update.
6842 * s390-tdep.c: Update.
6843 * selftest-arch.c: Update.
6844 * solib-dsbt.c: Update.
6845 * solib-frv.c: Update.
6846 * solib-spu.c: Update.
6847 * solib-svr4.c: Update.
6848 * solib.c: Update.
6849 * sparc64-linux-tdep.c: Update.
6850 * stack.c: Update.
6851 * symfile-mem.c: Update.
6852 * symmisc.c: Update.
6853 * target.c: Update.
6854 * thread.c: Update.
6855 * top.c: Update.
6856 * tracefile-tfile.c: Update.
6857 * tui/tui.c: Update.
6858 * typeprint.c: Update.
6859 * unittests/cli-utils-selftests.c: Update.
6860 * unittests/parse-connection-spec-selftests.c: Update.
6861 * valops.c: Update.
6862 * valprint.c: Update.
6863 * value.c: Update.
6864 * varobj.c: Update.
6865 * windows-nat.c: Update.
6866 * x86-linux-nat.c: Update.
6867 * xml-support.c: Update.
6868
a70b8144
TT
68692019-04-08 Tom Tromey <tom@tromey.com>
6870
6871 * xml-support.c: Use C++ exception handling.
6872 * x86-linux-nat.c: Use C++ exception handling.
6873 * windows-nat.c: Use C++ exception handling.
6874 * varobj.c: Use C++ exception handling.
6875 * value.c: Use C++ exception handling.
6876 * valprint.c: Use C++ exception handling.
6877 * valops.c: Use C++ exception handling.
6878 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6879 handling.
6880 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6881 * typeprint.c: Use C++ exception handling.
6882 * tui/tui.c: Use C++ exception handling.
6883 * tracefile-tfile.c: Use C++ exception handling.
6884 * top.c: Use C++ exception handling.
6885 * thread.c: Use C++ exception handling.
6886 * target.c: Use C++ exception handling.
6887 * symmisc.c: Use C++ exception handling.
6888 * symfile-mem.c: Use C++ exception handling.
6889 * stack.c: Use C++ exception handling.
6890 * sparc64-linux-tdep.c: Use C++ exception handling.
6891 * solib.c: Use C++ exception handling.
6892 * solib-svr4.c: Use C++ exception handling.
6893 * solib-spu.c: Use C++ exception handling.
6894 * solib-frv.c: Use C++ exception handling.
6895 * solib-dsbt.c: Use C++ exception handling.
6896 * selftest-arch.c: Use C++ exception handling.
6897 * s390-tdep.c: Use C++ exception handling.
6898 * rust-lang.c: Use C++ exception handling.
6899 * rust-exp.y: Use C++ exception handling.
6900 * rs6000-tdep.c: Use C++ exception handling.
6901 * rs6000-aix-tdep.c: Use C++ exception handling.
6902 * riscv-tdep.c: Use C++ exception handling.
6903 * remote.c: Use C++ exception handling.
6904 * remote-fileio.c: Use C++ exception handling.
6905 * record-full.c: Use C++ exception handling.
6906 * record-btrace.c: Use C++ exception handling.
6907 * python/python.c: Use C++ exception handling.
6908 * python/py-value.c: Use C++ exception handling.
6909 * python/py-utils.c: Use C++ exception handling.
6910 * python/py-unwind.c: Use C++ exception handling.
6911 * python/py-type.c: Use C++ exception handling.
6912 * python/py-symbol.c: Use C++ exception handling.
6913 * python/py-record.c: Use C++ exception handling.
6914 * python/py-record-btrace.c: Use C++ exception handling.
6915 * python/py-progspace.c: Use C++ exception handling.
6916 * python/py-prettyprint.c: Use C++ exception handling.
6917 * python/py-param.c: Use C++ exception handling.
6918 * python/py-objfile.c: Use C++ exception handling.
6919 * python/py-linetable.c: Use C++ exception handling.
6920 * python/py-lazy-string.c: Use C++ exception handling.
6921 * python/py-infthread.c: Use C++ exception handling.
6922 * python/py-inferior.c: Use C++ exception handling.
6923 * python/py-gdb-readline.c: Use C++ exception handling.
6924 * python/py-framefilter.c: Use C++ exception handling.
6925 * python/py-frame.c: Use C++ exception handling.
6926 * python/py-finishbreakpoint.c: Use C++ exception handling.
6927 * python/py-cmd.c: Use C++ exception handling.
6928 * python/py-breakpoint.c: Use C++ exception handling.
6929 * python/py-arch.c: Use C++ exception handling.
6930 * printcmd.c: Use C++ exception handling.
6931 * ppc-linux-tdep.c: Use C++ exception handling.
6932 * parse.c: Use C++ exception handling.
6933 * p-valprint.c: Use C++ exception handling.
6934 * objc-lang.c: Use C++ exception handling.
6935 * mi/mi-main.c: Use C++ exception handling.
6936 * mi/mi-interp.c: Use C++ exception handling.
6937 * mi/mi-cmd-stack.c: Use C++ exception handling.
6938 * mi/mi-cmd-break.c: Use C++ exception handling.
6939 * main.c: Use C++ exception handling.
6940 * linux-thread-db.c: Use C++ exception handling.
6941 * linux-tdep.c: Use C++ exception handling.
6942 * linux-nat.c: Use C++ exception handling.
6943 * linux-fork.c: Use C++ exception handling.
6944 * linespec.c: Use C++ exception handling.
6945 * language.c: Use C++ exception handling.
6946 * jit.c: Use C++ exception handling.
6947 * infrun.c: Use C++ exception handling.
6948 * infcmd.c: Use C++ exception handling.
6949 * infcall.c: Use C++ exception handling.
6950 * inf-loop.c: Use C++ exception handling.
6951 * i386-tdep.c: Use C++ exception handling.
6952 * i386-linux-tdep.c: Use C++ exception handling.
6953 * guile/scm-value.c: Use C++ exception handling.
6954 * guile/scm-type.c: Use C++ exception handling.
6955 * guile/scm-symtab.c: Use C++ exception handling.
6956 * guile/scm-symbol.c: Use C++ exception handling.
6957 * guile/scm-pretty-print.c: Use C++ exception handling.
6958 * guile/scm-ports.c: Use C++ exception handling.
6959 * guile/scm-param.c: Use C++ exception handling.
6960 * guile/scm-math.c: Use C++ exception handling.
6961 * guile/scm-lazy-string.c: Use C++ exception handling.
6962 * guile/scm-frame.c: Use C++ exception handling.
6963 * guile/scm-disasm.c: Use C++ exception handling.
6964 * guile/scm-cmd.c: Use C++ exception handling.
6965 * guile/scm-breakpoint.c: Use C++ exception handling.
6966 * guile/scm-block.c: Use C++ exception handling.
6967 * guile/guile-internal.h: Use C++ exception handling.
6968 * gnu-v3-abi.c: Use C++ exception handling.
6969 * gdbtypes.c: Use C++ exception handling.
6970 * frame.c: Use C++ exception handling.
6971 * frame-unwind.c: Use C++ exception handling.
6972 * fbsd-tdep.c: Use C++ exception handling.
6973 * f-valprint.c: Use C++ exception handling.
6974 * exec.c: Use C++ exception handling.
6975 * event-top.c: Use C++ exception handling.
6976 * event-loop.c: Use C++ exception handling.
6977 * eval.c: Use C++ exception handling.
6978 * dwarf2read.c: Use C++ exception handling.
6979 * dwarf2loc.c: Use C++ exception handling.
6980 * dwarf2-frame.c: Use C++ exception handling.
6981 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6982 * dwarf-index-write.c: Use C++ exception handling.
6983 * dwarf-index-cache.c: Use C++ exception handling.
6984 * dtrace-probe.c: Use C++ exception handling.
6985 * disasm-selftests.c: Use C++ exception handling.
6986 * darwin-nat.c: Use C++ exception handling.
6987 * cp-valprint.c: Use C++ exception handling.
6988 * cp-support.c: Use C++ exception handling.
6989 * cp-abi.c: Use C++ exception handling.
6990 * corelow.c: Use C++ exception handling.
6991 * completer.c: Use C++ exception handling.
6992 * compile/compile-object-run.c: Use C++ exception handling.
6993 * compile/compile-object-load.c: Use C++ exception handling.
6994 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6995 * compile/compile-c-symbols.c: Use C++ exception handling.
6996 * common/selftest.c: Use C++ exception handling.
6997 * common/new-op.c: Use C++ exception handling.
6998 * cli/cli-script.c: Use C++ exception handling.
6999 * cli/cli-interp.c: Use C++ exception handling.
7000 * cli/cli-cmds.c: Use C++ exception handling.
7001 * c-varobj.c: Use C++ exception handling.
7002 * btrace.c: Use C++ exception handling.
7003 * breakpoint.c: Use C++ exception handling.
7004 * break-catch-throw.c: Use C++ exception handling.
7005 * arch-utils.c: Use C++ exception handling.
7006 * amd64-tdep.c: Use C++ exception handling.
7007 * ada-valprint.c: Use C++ exception handling.
7008 * ada-typeprint.c: Use C++ exception handling.
7009 * ada-lang.c: Use C++ exception handling.
7010 * aarch64-tdep.c: Use C++ exception handling.
7011
3d6e9d23
TT
70122019-04-08 Tom Tromey <tom@tromey.com>
7013
7014 * xml-support.c (gdb_xml_parser::parse): Update.
7015 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7016 * value.c (show_convenience): Update.
7017 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7018 (test_parse_flags_qcs): Update.
7019 * thread.c (thr_try_catch_cmd): Update.
7020 * target.c (target_translate_tls_address): Update.
7021 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7022 (info_frame_command_core, frame_apply_command_count): Update.
7023 * rust-exp.y (rust_lex_exception_test): Update.
7024 * riscv-tdep.c (riscv_print_one_register_info): Update.
7025 * remote.c (remote_target::enable_btrace): Update.
7026 * record-btrace.c (record_btrace_enable_warn): Update.
7027 * python/py-utils.c (gdbpy_convert_exception): Update.
7028 * printcmd.c (do_one_display, print_variable_and_value): Update.
7029 * mi/mi-main.c (mi_print_exception): Update.
7030 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7031 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7032 * linux-nat.c (linux_nat_target::attach): Update.
7033 * linux-fork.c (class scoped_switch_fork_info): Update.
7034 * infrun.c (displaced_step_prepare): Update.
7035 * infcall.c (call_function_by_hand_dummy): Update.
7036 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7037 * gnu-v3-abi.c (print_one_vtable): Update.
7038 * frame.c (get_prev_frame_always): Update.
7039 * f-valprint.c (info_common_command_for_block): Update.
7040 * exec.c (try_open_exec_file): Update.
7041 * exceptions.c (print_exception, exception_print)
7042 (exception_fprintf, exception_print_same): Update.
7043 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7044 * dwarf-index-cache.c (index_cache::store)
7045 (index_cache::lookup_gdb_index): Update.
7046 * darwin-nat.c (maybe_cache_shell): Update.
7047 * cp-valprint.c (cp_print_value_fields): Update.
7048 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7049 (gcc_cplus_symbol_address): Update.
7050 * compile/compile-c-symbols.c (gcc_convert_symbol)
7051 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7052 * common/selftest.c: Update.
7053 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7054 a std::string.
7055 (exception_try_scope_entry, exception_try_scope_exit): Don't
7056 declare.
7057 (struct exception_try_scope): Remove.
7058 (TRY): Don't use exception_try_scope.
7059 (struct gdb_exception): Add constructor, operator=.
7060 <what>: New method.
7061 (struct gdb_exception_RETURN_MASK_ALL)
7062 (struct gdb_exception_RETURN_MASK_ERROR)
7063 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7064 (struct gdb_quit_bad_alloc): Update.
7065 * common/common-exceptions.c (exception_none): Change
7066 initializer.
7067 (struct catcher) <state, exception>: Initialize inline.
7068 <prev>: Remove member.
7069 (current_catcher): Remove.
7070 (catchers): New global.
7071 (exceptions_state_mc_init): Simplify.
7072 (catcher_pop): Remove.
7073 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7074 (try_scope_depth, exception_try_scope_entry)
7075 (exception_try_scope_exit): Remove.
7076 (throw_exception_sjlj): Update.
7077 (exception_messages, exception_messages_size): Remove.
7078 (throw_it): Simplify.
7079 (gdb_exception_sliced_copy): Remove.
7080 (throw_exception_cxx): Update.
7081 * cli/cli-script.c (script_from_file): Update.
7082 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7083 Update.
7084 * ada-valprint.c (ada_val_print): Update.
7085 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7086 (create_excep_cond_exprs): Update.
7087
c5c10118
TT
70882019-04-08 Tom Tromey <tom@tromey.com>
7089
7090 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7091 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7092 (TRY, CATCH, END_CATCH): Remove some definitions.
7093 * common/common-exceptions.c: Don't use GDB_XCPT.
7094 (catcher_list_size): Remove.
7095 (throw_exception, throw_it): Simplify.
7096
4de283e4
TT
70972019-04-05 Tom Tromey <tom@tromey.com>
7098
7099 Revert the header-sorting patch.
7100 * ft32-tdep.c: Revert.
7101 * frv-tdep.c: Revert.
7102 * frv-linux-tdep.c: Revert.
7103 * frame.c: Revert.
7104 * frame-unwind.c: Revert.
7105 * frame-base.c: Revert.
7106 * fork-child.c: Revert.
7107 * findvar.c: Revert.
7108 * findcmd.c: Revert.
7109 * filesystem.c: Revert.
7110 * filename-seen-cache.h: Revert.
7111 * filename-seen-cache.c: Revert.
7112 * fbsd-tdep.c: Revert.
7113 * fbsd-nat.h: Revert.
7114 * fbsd-nat.c: Revert.
7115 * f-valprint.c: Revert.
7116 * f-typeprint.c: Revert.
7117 * f-lang.c: Revert.
7118 * extension.h: Revert.
7119 * extension.c: Revert.
7120 * extension-priv.h: Revert.
7121 * expprint.c: Revert.
7122 * exec.h: Revert.
7123 * exec.c: Revert.
7124 * exceptions.c: Revert.
7125 * event-top.c: Revert.
7126 * event-loop.c: Revert.
7127 * eval.c: Revert.
7128 * elfread.c: Revert.
7129 * dwarf2read.h: Revert.
7130 * dwarf2read.c: Revert.
7131 * dwarf2loc.c: Revert.
7132 * dwarf2expr.h: Revert.
7133 * dwarf2expr.c: Revert.
7134 * dwarf2-frame.c: Revert.
7135 * dwarf2-frame-tailcall.c: Revert.
7136 * dwarf-index-write.h: Revert.
7137 * dwarf-index-write.c: Revert.
7138 * dwarf-index-common.c: Revert.
7139 * dwarf-index-cache.h: Revert.
7140 * dwarf-index-cache.c: Revert.
7141 * dummy-frame.c: Revert.
7142 * dtrace-probe.c: Revert.
7143 * disasm.h: Revert.
7144 * disasm.c: Revert.
7145 * disasm-selftests.c: Revert.
7146 * dictionary.c: Revert.
7147 * dicos-tdep.c: Revert.
7148 * demangle.c: Revert.
7149 * dcache.h: Revert.
7150 * dcache.c: Revert.
7151 * darwin-nat.h: Revert.
7152 * darwin-nat.c: Revert.
7153 * darwin-nat-info.c: Revert.
7154 * d-valprint.c: Revert.
7155 * d-namespace.c: Revert.
7156 * d-lang.c: Revert.
7157 * ctf.c: Revert.
7158 * csky-tdep.c: Revert.
7159 * csky-linux-tdep.c: Revert.
7160 * cris-tdep.c: Revert.
7161 * cris-linux-tdep.c: Revert.
7162 * cp-valprint.c: Revert.
7163 * cp-support.c: Revert.
7164 * cp-namespace.c: Revert.
7165 * cp-abi.c: Revert.
7166 * corelow.c: Revert.
7167 * corefile.c: Revert.
7168 * continuations.c: Revert.
7169 * completer.h: Revert.
7170 * completer.c: Revert.
7171 * complaints.c: Revert.
7172 * coffread.c: Revert.
7173 * coff-pe-read.c: Revert.
7174 * cli-out.h: Revert.
7175 * cli-out.c: Revert.
7176 * charset.c: Revert.
7177 * c-varobj.c: Revert.
7178 * c-valprint.c: Revert.
7179 * c-typeprint.c: Revert.
7180 * c-lang.c: Revert.
7181 * buildsym.c: Revert.
7182 * buildsym-legacy.c: Revert.
7183 * build-id.h: Revert.
7184 * build-id.c: Revert.
7185 * btrace.c: Revert.
7186 * bsd-uthread.c: Revert.
7187 * breakpoint.h: Revert.
7188 * breakpoint.c: Revert.
7189 * break-catch-throw.c: Revert.
7190 * break-catch-syscall.c: Revert.
7191 * break-catch-sig.c: Revert.
7192 * blockframe.c: Revert.
7193 * block.c: Revert.
7194 * bfin-tdep.c: Revert.
7195 * bfin-linux-tdep.c: Revert.
7196 * bfd-target.c: Revert.
7197 * bcache.c: Revert.
7198 * ax-general.c: Revert.
7199 * ax-gdb.h: Revert.
7200 * ax-gdb.c: Revert.
7201 * avr-tdep.c: Revert.
7202 * auxv.c: Revert.
7203 * auto-load.c: Revert.
7204 * arm-wince-tdep.c: Revert.
7205 * arm-tdep.c: Revert.
7206 * arm-symbian-tdep.c: Revert.
7207 * arm-pikeos-tdep.c: Revert.
7208 * arm-obsd-tdep.c: Revert.
7209 * arm-nbsd-tdep.c: Revert.
7210 * arm-nbsd-nat.c: Revert.
7211 * arm-linux-tdep.c: Revert.
7212 * arm-linux-nat.c: Revert.
7213 * arm-fbsd-tdep.c: Revert.
7214 * arm-fbsd-nat.c: Revert.
7215 * arm-bsd-tdep.c: Revert.
7216 * arch-utils.c: Revert.
7217 * arc-tdep.c: Revert.
7218 * arc-newlib-tdep.c: Revert.
7219 * annotate.h: Revert.
7220 * annotate.c: Revert.
7221 * amd64-windows-tdep.c: Revert.
7222 * amd64-windows-nat.c: Revert.
7223 * amd64-tdep.c: Revert.
7224 * amd64-sol2-tdep.c: Revert.
7225 * amd64-obsd-tdep.c: Revert.
7226 * amd64-obsd-nat.c: Revert.
7227 * amd64-nbsd-tdep.c: Revert.
7228 * amd64-nbsd-nat.c: Revert.
7229 * amd64-nat.c: Revert.
7230 * amd64-linux-tdep.c: Revert.
7231 * amd64-linux-nat.c: Revert.
7232 * amd64-fbsd-tdep.c: Revert.
7233 * amd64-fbsd-nat.c: Revert.
7234 * amd64-dicos-tdep.c: Revert.
7235 * amd64-darwin-tdep.c: Revert.
7236 * amd64-bsd-nat.c: Revert.
7237 * alpha-tdep.c: Revert.
7238 * alpha-obsd-tdep.c: Revert.
7239 * alpha-nbsd-tdep.c: Revert.
7240 * alpha-mdebug-tdep.c: Revert.
7241 * alpha-linux-tdep.c: Revert.
7242 * alpha-linux-nat.c: Revert.
7243 * alpha-bsd-tdep.c: Revert.
7244 * alpha-bsd-nat.c: Revert.
7245 * aix-thread.c: Revert.
7246 * agent.c: Revert.
7247 * addrmap.c: Revert.
7248 * ada-varobj.c: Revert.
7249 * ada-valprint.c: Revert.
7250 * ada-typeprint.c: Revert.
7251 * ada-tasks.c: Revert.
7252 * ada-lang.c: Revert.
7253 * aarch64-tdep.c: Revert.
7254 * aarch64-ravenscar-thread.c: Revert.
7255 * aarch64-newlib-tdep.c: Revert.
7256 * aarch64-linux-tdep.c: Revert.
7257 * aarch64-linux-nat.c: Revert.
7258 * aarch64-fbsd-tdep.c: Revert.
7259 * aarch64-fbsd-nat.c: Revert.
7260 * aarch32-linux-nat.c: Revert.
7261
d55e5aa6
TT
72622019-04-05 Tom Tromey <tom@tromey.com>
7263
7264 * ft32-tdep.c: Sort headers.
7265 * frv-tdep.c: Sort headers.
7266 * frv-linux-tdep.c: Sort headers.
7267 * frame.c: Sort headers.
7268 * frame-unwind.c: Sort headers.
7269 * frame-base.c: Sort headers.
7270 * fork-child.c: Sort headers.
7271 * findvar.c: Sort headers.
7272 * findcmd.c: Sort headers.
7273 * filesystem.c: Sort headers.
7274 * filename-seen-cache.h: Sort headers.
7275 * filename-seen-cache.c: Sort headers.
7276 * fbsd-tdep.c: Sort headers.
7277 * fbsd-nat.h: Sort headers.
7278 * fbsd-nat.c: Sort headers.
7279 * f-valprint.c: Sort headers.
7280 * f-typeprint.c: Sort headers.
7281 * f-lang.c: Sort headers.
7282 * extension.h: Sort headers.
7283 * extension.c: Sort headers.
7284 * extension-priv.h: Sort headers.
7285 * expprint.c: Sort headers.
7286 * exec.h: Sort headers.
7287 * exec.c: Sort headers.
7288 * exceptions.c: Sort headers.
7289 * event-top.c: Sort headers.
7290 * event-loop.c: Sort headers.
7291 * eval.c: Sort headers.
7292 * elfread.c: Sort headers.
7293 * dwarf2read.h: Sort headers.
7294 * dwarf2read.c: Sort headers.
7295 * dwarf2loc.c: Sort headers.
7296 * dwarf2expr.h: Sort headers.
7297 * dwarf2expr.c: Sort headers.
7298 * dwarf2-frame.c: Sort headers.
7299 * dwarf2-frame-tailcall.c: Sort headers.
7300 * dwarf-index-write.h: Sort headers.
7301 * dwarf-index-write.c: Sort headers.
7302 * dwarf-index-common.c: Sort headers.
7303 * dwarf-index-cache.h: Sort headers.
7304 * dwarf-index-cache.c: Sort headers.
7305 * dummy-frame.c: Sort headers.
7306 * dtrace-probe.c: Sort headers.
7307 * disasm.h: Sort headers.
7308 * disasm.c: Sort headers.
7309 * disasm-selftests.c: Sort headers.
7310 * dictionary.c: Sort headers.
7311 * dicos-tdep.c: Sort headers.
7312 * demangle.c: Sort headers.
7313 * dcache.h: Sort headers.
7314 * dcache.c: Sort headers.
7315 * darwin-nat.h: Sort headers.
7316 * darwin-nat.c: Sort headers.
7317 * darwin-nat-info.c: Sort headers.
7318 * d-valprint.c: Sort headers.
7319 * d-namespace.c: Sort headers.
7320 * d-lang.c: Sort headers.
7321 * ctf.c: Sort headers.
7322 * csky-tdep.c: Sort headers.
7323 * csky-linux-tdep.c: Sort headers.
7324 * cris-tdep.c: Sort headers.
7325 * cris-linux-tdep.c: Sort headers.
7326 * cp-valprint.c: Sort headers.
7327 * cp-support.c: Sort headers.
7328 * cp-namespace.c: Sort headers.
7329 * cp-abi.c: Sort headers.
7330 * corelow.c: Sort headers.
7331 * corefile.c: Sort headers.
7332 * continuations.c: Sort headers.
7333 * completer.h: Sort headers.
7334 * completer.c: Sort headers.
7335 * complaints.c: Sort headers.
7336 * coffread.c: Sort headers.
7337 * coff-pe-read.c: Sort headers.
7338 * cli-out.h: Sort headers.
7339 * cli-out.c: Sort headers.
7340 * charset.c: Sort headers.
7341 * c-varobj.c: Sort headers.
7342 * c-valprint.c: Sort headers.
7343 * c-typeprint.c: Sort headers.
7344 * c-lang.c: Sort headers.
7345 * buildsym.c: Sort headers.
7346 * buildsym-legacy.c: Sort headers.
7347 * build-id.h: Sort headers.
7348 * build-id.c: Sort headers.
7349 * btrace.c: Sort headers.
7350 * bsd-uthread.c: Sort headers.
7351 * breakpoint.h: Sort headers.
7352 * breakpoint.c: Sort headers.
7353 * break-catch-throw.c: Sort headers.
7354 * break-catch-syscall.c: Sort headers.
7355 * break-catch-sig.c: Sort headers.
7356 * blockframe.c: Sort headers.
7357 * block.c: Sort headers.
7358 * bfin-tdep.c: Sort headers.
7359 * bfin-linux-tdep.c: Sort headers.
7360 * bfd-target.c: Sort headers.
7361 * bcache.c: Sort headers.
7362 * ax-general.c: Sort headers.
7363 * ax-gdb.h: Sort headers.
7364 * ax-gdb.c: Sort headers.
7365 * avr-tdep.c: Sort headers.
7366 * auxv.c: Sort headers.
7367 * auto-load.c: Sort headers.
7368 * arm-wince-tdep.c: Sort headers.
7369 * arm-tdep.c: Sort headers.
7370 * arm-symbian-tdep.c: Sort headers.
7371 * arm-pikeos-tdep.c: Sort headers.
7372 * arm-obsd-tdep.c: Sort headers.
7373 * arm-nbsd-tdep.c: Sort headers.
7374 * arm-nbsd-nat.c: Sort headers.
7375 * arm-linux-tdep.c: Sort headers.
7376 * arm-linux-nat.c: Sort headers.
7377 * arm-fbsd-tdep.c: Sort headers.
7378 * arm-fbsd-nat.c: Sort headers.
7379 * arm-bsd-tdep.c: Sort headers.
7380 * arch-utils.c: Sort headers.
7381 * arc-tdep.c: Sort headers.
7382 * arc-newlib-tdep.c: Sort headers.
7383 * annotate.h: Sort headers.
7384 * annotate.c: Sort headers.
7385 * amd64-windows-tdep.c: Sort headers.
7386 * amd64-windows-nat.c: Sort headers.
7387 * amd64-tdep.c: Sort headers.
7388 * amd64-sol2-tdep.c: Sort headers.
7389 * amd64-obsd-tdep.c: Sort headers.
7390 * amd64-obsd-nat.c: Sort headers.
7391 * amd64-nbsd-tdep.c: Sort headers.
7392 * amd64-nbsd-nat.c: Sort headers.
7393 * amd64-nat.c: Sort headers.
7394 * amd64-linux-tdep.c: Sort headers.
7395 * amd64-linux-nat.c: Sort headers.
7396 * amd64-fbsd-tdep.c: Sort headers.
7397 * amd64-fbsd-nat.c: Sort headers.
7398 * amd64-dicos-tdep.c: Sort headers.
7399 * amd64-darwin-tdep.c: Sort headers.
7400 * amd64-bsd-nat.c: Sort headers.
7401 * alpha-tdep.c: Sort headers.
7402 * alpha-obsd-tdep.c: Sort headers.
7403 * alpha-nbsd-tdep.c: Sort headers.
7404 * alpha-mdebug-tdep.c: Sort headers.
7405 * alpha-linux-tdep.c: Sort headers.
7406 * alpha-linux-nat.c: Sort headers.
7407 * alpha-bsd-tdep.c: Sort headers.
7408 * alpha-bsd-nat.c: Sort headers.
7409 * aix-thread.c: Sort headers.
7410 * agent.c: Sort headers.
7411 * addrmap.c: Sort headers.
7412 * ada-varobj.c: Sort headers.
7413 * ada-valprint.c: Sort headers.
7414 * ada-typeprint.c: Sort headers.
7415 * ada-tasks.c: Sort headers.
7416 * ada-lang.c: Sort headers.
7417 * aarch64-tdep.c: Sort headers.
7418 * aarch64-ravenscar-thread.c: Sort headers.
7419 * aarch64-newlib-tdep.c: Sort headers.
7420 * aarch64-linux-tdep.c: Sort headers.
7421 * aarch64-linux-nat.c: Sort headers.
7422 * aarch64-fbsd-tdep.c: Sort headers.
7423 * aarch64-fbsd-nat.c: Sort headers.
7424 * aarch32-linux-nat.c: Sort headers.
7425
699bd4cf
TT
74262019-04-04 Tom Tromey <tom@tromey.com>
7427
7428 * varobj.c (varobj_create): Update.
7429 * rust-exp.y (struct rust_parser) <update_innermost_block,
7430 lookup_symbol>: New methods.
7431 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7432 Rename.
7433 (rust_parser::rust_lookup_type)
7434 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7435 * printcmd.c (display_command, do_one_display): Update.
7436 * parser-defs.h (struct parser_state) <parser_state>: Add
7437 "tracker" parameter.
7438 (block_tracker): New member.
7439 (class innermost_block_tracker) <innermost_block_tracker>: Add
7440 "types" parameter.
7441 <reset>: Remove method.
7442 (innermost_block): Don't declare.
7443 (null_post_parser): Update.
7444 * parse.c (innermost_block): Remove global.
7445 (write_dollar_variable): Update.
7446 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7447 Remove "tracker_types" parameter.
7448 (parse_expression): Add "tracker" parameter.
7449 (parse_expression_for_completion): Update.
7450 (null_post_parser): Add "tracker" parameter.
7451 * p-exp.y: Update rules.
7452 * m2-exp.y: Update rules.
7453 * language.h (struct language_defn) <la_post_parser>: Add
7454 "tracker" parameter.
7455 * go-exp.y: Update rules.
7456 * f-exp.y: Update rules.
7457 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7458 parameter.
7459 * d-exp.y: Update rules.
7460 * c-exp.y: Update rules.
7461 * breakpoint.c (set_breakpoint_condition): Create an
7462 innermost_block_tracker.
7463 (watch_command_1): Likewise.
7464 * ada-lang.c (resolve): Add "tracker" parameter.
7465 (resolve_subexp): Likewise.
7466 * ada-exp.y (write_var_from_sym): Update.
7467
dac43e32
TT
74682019-04-04 Tom Tromey <tom@tromey.com>
7469
7470 * type-stack.h: New file.
7471 * type-stack.c: New file.
7472 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7473 type-stack.h.
7474 (insert_into_type_stack, insert_type, push_type, push_type_int)
7475 (insert_type_address_space, pop_type, pop_type_int)
7476 (pop_typelist, pop_type_stack, append_type_stack)
7477 (push_type_stack, get_type_stack, push_typelist)
7478 (follow_type_instance_flags, follow_types): Don't declare.
7479 * parse.c (type_stack): Remove global.
7480 (parse_exp_in_context): Update.
7481 (insert_into_type_stack, insert_type, push_type, push_type_int)
7482 (insert_type_address_space, pop_type, pop_type_int)
7483 (pop_typelist, pop_type_stack, append_type_stack)
7484 (push_type_stack, get_type_stack, push_typelist)
7485 (follow_type_instance_flags, follow_types): Remove (moved to
7486 type-stack.c).
7487 * f-exp.y (type_stack): New global.
7488 Update rules.
7489 (push_kind_type, f_parse): Update.
7490 * d-exp.y (type_stack): New global.
7491 Update rules.
7492 (d_parse): Update.
7493 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7494 Update rules.
7495 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7496 (HFILES_NO_SRCDIR): Add type-stack.h.
7497
2a612529
TT
74982019-04-04 Tom Tromey <tom@tromey.com>
7499
7500 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7501 (rust_parser::convert_ast_to_expression, rust_parse)
7502 (rust_lex_test_completion, rust_lex_tests): Update.
7503 * parser-defs.h (struct expr_completion_state): New.
7504 (struct parser_state) <parser_state>: Add completion parameter.
7505 <mark_struct_expression, mark_completion_tag>: New methods.
7506 <parse_completion, m_completion_state>: New members.
7507 (prefixify_expression, null_post_parser): Update.
7508 (mark_struct_expression, mark_completion_tag): Don't declare.
7509 * parse.c (parse_completion, expout_last_struct)
7510 (expout_tag_completion_type, expout_completion_name): Remove
7511 globals.
7512 (parser_state::mark_struct_expression)
7513 (parser_state::mark_completion_tag): Now methods.
7514 (prefixify_expression): Add last_struct parameter.
7515 (prefixify_subexp): Likewise.
7516 (parse_exp_1): Update.
7517 (parse_exp_in_context): Add cstate parameter. Update.
7518 (parse_expression_for_completion): Create an
7519 expr_completion_state.
7520 (null_post_parser): Add "completion" parameter.
7521 * p-exp.y: Update rules.
7522 (yylex): Update.
7523 * language.h (struct language_defn) <la_post_parser>: Add
7524 "completing" parameter.
7525 * go-exp.y: Update rules.
7526 (lex_one_token): Update.
7527 * expression.h (parse_completion): Don't declare.
7528 * d-exp.y: Update rules.
7529 (lex_one_token): Update rules.
7530 * c-exp.y: Update rules.
7531 (lex_one_token): Update.
7532 * ada-lang.c (resolve): Add "parse_completion" parameter.
7533 (resolve_subexp): Likewise.
7534 (ada_resolve_function): Likewise.
7535
43476f0b
TT
75362019-04-04 Tom Tromey <tom@tromey.com>
7537
7538 * parser-defs.h (struct parser_state) <start_arglist,
7539 end_arglist>: New methods.
7540 <arglist_len, m_funcall_chain>: New members.
7541 (arglist_len, start_arglist, end_arglist): Don't declare.
7542 * parse.c (arglist_len, funcall_chain): Remove global.
7543 (start_arglist, end_arglist): Remove functions.
7544 (parse_exp_in_context): Update.
7545 * p-exp.y: Update rules.
7546 * m2-exp.y: Update rules.
7547 * go-exp.y: Update rules.
7548 * f-exp.y: Update rules.
7549 * d-exp.y: Update rules.
7550 * c-exp.y: Update rules.
7551
5776fca3
TT
75522019-04-04 Tom Tromey <tom@tromey.com>
7553
7554 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7555 lex_operator, push_back>: New methods.
7556 Update all rules.
7557 (rust_parser::lex_hex, lex_escape): Rename and update.
7558 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7559 (rust_parser::lex_operator): Rename and update.
7560 (rust_parser::lex_number, rustyylex, rustyyerror)
7561 (rust_lex_test_init, rust_lex_test_sequence)
7562 (rust_lex_test_push_back, rust_lex_tests): Update.
7563 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7564 parameter.
7565 <lexptr, prev_lexptr>: New members.
7566 (lexptr, prev_lexptr): Don't declare.
7567 * parse.c (lexptr, prev_lexptr): Remove globals.
7568 (parse_exp_in_context): Update.
7569 * p-exp.y (yylex, yyerror): Update.
7570 * m2-exp.y (parse_number, yylex, yyerror): Update.
7571 * go-exp.y (lex_one_token, yyerror): Update.
7572 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7573 * d-exp.y (lex_one_token, yyerror): Update.
7574 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7575 (lex_one_token, yyerror): Update.
7576 * ada-lex.l (YY_INPUT): Update.
7577 (rewind_to_char): Update.
7578 * ada-exp.y (yyerror): Update.
7579
8621b685
TT
75802019-04-04 Tom Tromey <tom@tromey.com>
7581
7582 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7583 * parser-defs.h (struct parser_state) <parser_state>: Add new
7584 parameter.
7585 <comma_terminates>: New member.
7586 (comma_terminates): Don't declare global.
7587 * parse.c (comma_terminates): Remove global.
7588 (parse_exp_in_context): Update.
7589 * p-exp.y (yylex): Update.
7590 * m2-exp.y (yylex): Update.
7591 * go-exp.y (lex_one_token): Update.
7592 * f-exp.y (yylex): Update.
7593 * d-exp.y (lex_one_token): Update.
7594 * c-exp.y (lex_one_token): Update.
7595 * ada-lex.l: Update.
7596
28aaf3fd
TT
75972019-04-04 Tom Tromey <tom@tromey.com>
7598
7599 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7600 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7601 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7602 * parser-defs.h (paren_depth): Don't declare.
7603 * parse.c (paren_depth): Remove global.
7604 (parse_exp_in_context): Update.
7605 * p-exp.y (paren_depth): New global.
7606 (pascal_parse): Initialize it.
7607 * m2-exp.y (paren_depth): New global.
7608 (m2_parse): Initialize it.
7609 * go-exp.y (paren_depth): New global.
7610 (go_parse): Initialize it.
7611 * f-exp.y (paren_depth): New global.
7612 (f_parse): Initialize it.
7613 * d-exp.y (paren_depth): New global.
7614 (d_parse): Initialize it.
7615 * c-exp.y (paren_depth): New global.
7616 (c_parse): Initialize it.
7617 * ada-lex.l (paren_depth): New global.
7618 (lexer_init): Initialize it.
7619
1e58a4a4
TT
76202019-04-04 Tom Tromey <tom@tromey.com>
7621
7622 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7623 (rust_parser::convert_ast_to_type)
7624 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7625 * parser-defs.h (struct parser_state) <parser_state>: Add
7626 parameters. Initialize new members.
7627 <expression_context_block, expression_context_pc>: New members.
7628 * parse.c (expression_context_block, expression_context_pc):
7629 Remove globals.
7630 (parse_exp_in_context): Update.
7631 * p-exp.y: Update all rules.
7632 (yylex): Update.
7633 * m2-exp.y: Update all rules.
7634 (yylex): Update.
7635 * go-exp.y (yylex): Update.
7636 * f-exp.y (yylex): Update.
7637 * d-exp.y: Update all rules.
7638 (yylex): Update.
7639 * c-exp.y: Update all rules.
7640 (lex_one_token, classify_name, yylex, c_parse): Update.
7641 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7642
37eedb39
TT
76432019-04-04 Tom Tromey <tom@tromey.com>
7644
7645 * gdbarch.h, gdbarch.c: Rebuild.
7646 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7647 * stap-probe.h:
7648 (struct stap_parse_info): Replace "parser_state" with
7649 "expr_builder".
7650 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7651 (parser_state): New class.
7652 * parse.c (expr_builder): Rename.
7653 (expr_builder::release): Rename.
7654 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7655 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7656 (write_exp_elt_longcst, write_exp_elt_floatcst)
7657 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7658 (write_exp_string_vector, write_exp_bitstring)
7659 (write_exp_msymbol, mark_struct_expression)
7660 (write_dollar_variable)
7661 (insert_type_address_space, increase_expout_size): Replace
7662 "parser_state" with "expr_builder".
7663 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7664 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7665 "parser_state" with "expr_builder".
7666
73923d7e
TT
76672019-04-04 Tom Tromey <tom@tromey.com>
7668
7669 * rust-exp.y: Replace "parse_language" with method call.
7670 * p-exp.y:
7671 (yylex): Replace "parse_language" with method call.
7672 * m2-exp.y:
7673 (yylex): Replace "parse_language" with method call.
7674 * go-exp.y (classify_name): Replace "parse_language" with method
7675 call.
7676 * f-exp.y (yylex): Replace "parse_language" with method call.
7677 * d-exp.y (lex_one_token): Replace "parse_language" with method
7678 call.
7679 * c-exp.y:
7680 (lex_one_token, classify_name, yylex): Replace "parse_language"
7681 with method call.
7682 * ada-exp.y (find_primitive_type, type_char)
7683 (type_system_address): Replace "parse_language" with method call.
7684
fa9f5be6
TT
76852019-04-04 Tom Tromey <tom@tromey.com>
7686
7687 * rust-exp.y: Replace "parse_gdbarch" with method call.
7688 * parse.c (write_dollar_variable, insert_type_address_space):
7689 Replace "parse_gdbarch" with method call.
7690 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7691 call.
7692 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7693 call.
7694 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7695 "parse_gdbarch" with method call.
7696 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7697 with method call.
7698 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7699 "parse_gdbarch" with method call.
7700 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7701 "parse_gdbarch" with method call.
7702 * c-exp.y (parse_type, parse_number, classify_name): Replace
7703 "parse_gdbarch" with method call.
7704 * ada-lex.l: Replace "parse_gdbarch" with method call.
7705 * ada-exp.y (parse_type, find_primitive_type, type_char)
7706 (type_system_address): Replace "parse_gdbarch" with method call.
7707
1201a264
TT
77082019-04-04 Tom Tromey <tom@tromey.com>
7709
7710 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7711 * stap-probe.c (stap_parse_argument): Update.
7712 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7713 initial_size parameter.
7714 * rust-exp.y (rust_lex_tests): Update.
7715 * parse.c (parser_state): Update.
7716 (parse_exp_in_context): Update.
7717 * parser-defs.h (struct parser_state) <parser_state>: Remove
7718 "initial_size" parameter.
7719
e3980ce2
TT
77202019-04-04 Tom Tromey <tom@tromey.com>
7721
7722 * parser-defs.h (increase_expout_size): Don't declare.
7723 * parse.c (increase_expout_size): Now static.
7724
e9f8e3f1
TS
77252019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7726
7727 * gnu-nat.c (gnu_nat_target::wait): Fix
7728 target_waitstatus_to_string call.
7729
d7df6549
AB
77302019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7731
7732 * eval.c (evaluate_subexp_standard): Handle internal functions
7733 during Fortran function call handling.
7734
8bdc1658
AB
77352019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7736
7737 * NEWS: Mention new internal functions.
7738 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7739 (read_base_type): Use dwarf2_init_complex_target_type.
7740 * value.c (creal_internal_fn): New function.
7741 (cimag_internal_fn): New function.
7742 (_initialize_values): Register new internal functions.
7743
c29705b7
PW
77442019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7745
7746 * infrun.c (stop_all_threads): If debug_infrun, always
7747 trace the wait status after wait_one, using
7748 target_waitstatus_to_string and target_pid_to_str.
7749 (handle_inferior_event): Replace various trace of
7750 wait status kind by a single trace.
7751 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7752 wait status kind image by target_waitstatus_to_string.
7753 * target/waitstatus.c (target_waitstatus_to_string): Fix
7754 obsolete comment.
7755
05caa1d2
TT
77562019-04-01 Tom Tromey <tromey@adacore.com>
7757
7758 PR symtab/23331:
7759 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7760
9d1447e0
SDJ
77612019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7762 Pedro Alves <palves@redhat.com>
7763
7764 * top.c (quit_force): Call 'finalize_values'.
7765 * value.c (finalize_values): New function.
7766 * value.h (finalize_values): Declare.
7767
7734102d
EZ
77682019-03-30 Eli Zaretskii <eliz@gnu.org>
7769
7770 * NEWS: Announce $_gdb_major and $_gdb_minor.
7771
7772 * top.c (init_gdb_version_vars): New function.
7773 (gdb_init): Call init_gdb_version_vars.
7774
188e1fa9
TT
77752019-03-29 Tom Tromey <tromey@adacore.com>
7776
7777 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7778 help text. Remove dead code.
7779
2880242d
KS
77802019-03-29 Keith Seitz <keiths@redhat.com>
7781
7782 From Siddhesh Poyarekar:
7783 * f-lang.h (f77_get_upperbound): Return LONGEST.
7784 (f77_get_lowerbound): Likewise.
7785 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7786 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7787 print them.
7788 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7789 plongest to format print it.
7790 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7791 (f77_get_upperbound): Likewise.
7792 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7793 LOWER_BOUND to LONGEST.
7794 (f77_create_arrayprint_offset_tbl): Likewise.
7795
cc1defb1
KS
77962019-03-29 Keith Seitz <keiths@redhat.com>
7797
7798 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7799 %s/pulongest for TYPE_LENGTH instead of %d in format
7800 strings.
7801 * ada-typerint.c (ada_print_type): Likewise.
7802 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7803 * compile/compile-c-support.c (generate_register_struct): Likewise.
7804 * gdbtypes.c (recursive_dump_type): Likewise.
7805 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7806 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7807 instead of %d in format strings.
7808 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7809 to std::min to ULONGEST.
7810 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7811 instead of %d in format strings.
7812 * tracepoint.c (info_scope_command): Likewise.
7813 * typeprint.c (print_offset_data::update)
7814 (print_offset_data::finish): Likewise.
7815 * xtensa-tdep.c (xtensa_store_return_value)
7816 (xtensa_push_dummy_call): Likewise.
7817
e432ccf1
JT
78182019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7819
7820 * windows-nat.c (display_selector): Fixed format specifications
7821 for 64-bit Cygwin.
7822
65d2b333
PW
78232019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7824
7825 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7826
f489207e
SL
78272019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7828
7829 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7830 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7831 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7832 (nios2_linux_init_abi): Install it.
7833
bffa1015
AH
78342019-03-28 Alan Hayward <alan.hayward@arm.com>
7835
7836 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7837
fc96163a
AH
78382019-03-28 Alan Hayward <alan.hayward@arm.com>
7839
7840 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7841
20dc7e9b
PW
78422019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7843 Tom Tromey <tromey@adacore.com>
7844
7845 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7846
7f5331a8
JB
78472019-03-26 Joel Brobecker <brobecker@adacore.com>
7848
7849 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7850 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7851 method to compute the bounds of range types. Also print "[evaluated]"
7852 if the bounds' values come from a dynamic evaluation.
7853
18c77628
AB
78542019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7855
7856 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7857 whitespace when pretty printing is on.
7858
53c973f2
AH
78592019-03-26 Alan Hayward <alan.hayward@arm.com>
7860
e79be6e5 7861 * ppc-linux-nat.c: Add include.
53c973f2 7862
d851aa71
AH
78632019-03-26 Alan Hayward <alan.hayward@arm.com>
7864
e79be6e5 7865 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7866
2fe7bab7
AH
78672019-03-26 Alan Hayward <alan.hayward@arm.com>
7868
e79be6e5 7869 * arm-linux-nat.c: Add include.
2fe7bab7 7870
068ef30e
SM
78712019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7872
7873 * source-cache.c (source_cache::get_source_lines): Re-read
7874 fullname after calling open_source_file.
7875
81a24d04
JB
78762019-03-25 John Baldwin <jhb@FreeBSD.org>
7877
7878 * NEWS: Mention TLS support for FreeBSD.
7879
79e7ae11
TT
78802019-03-25 Tom Tromey <tromey@adacore.com>
7881
7882 * minsyms.c (BUNCH_SIZE): Update comment.
7883 (~minimal_symbol_reader): Remove old comment.
7884 (compact_minimal_symbols): Update comment.
7885 (minimal_symbol_reader::install): Remove old comment. Update
7886 other comments.
7887
d45963c2
AH
78882019-03-25 Alan Hayward <alan.hayward@arm.com>
7889
7890 * s390-linux-nat.c: Add include.
7891
0f83012e
AH
78922019-03-25 Alan Hayward <alan.hayward@arm.com>
7893
7894 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7895 Call linux_get_hwcap.
7896 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7897 Likewise.
7898 (aarch64_linux_get_hwcap): Remove function.
7899 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7900 declaration.
7901 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7902 linux_get_hwcap.
7903 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7904 * linux-tdep.c (linux_get_hwcap): Add function.
7905 (linux_get_hwcap2): Likewise.
7906 * linux-tdep.h (linux_get_hwcap): Add declaration.
7907 (linux_get_hwcap2): Likewise.
7908 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7909 (ppc_linux_get_hwcap2): Likewise.
7910 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7911 linux_get_hwcap.
7912 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7913 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7914 (ppc_linux_nat_target::read_description): Likewise.
7915 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7916 * s390-linux-nat.c: Likewise.
7917 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7918
6640a367
TT
79192019-03-24 Tom Tromey <tom@tromey.com>
7920
7921 * ada-lang.c (standard_lookup): Simplify initialization.
7922 (ada_lookup_symbol_nonlocal): Simplify return.
7923 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7924 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7925 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7926 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7927 initialization.
7928 * solib.c (solib_global_lookup): Simplify.
7929 * symtab.c (null_block_symbol): Remove.
7930 (symbol_cache_lookup): Simplify returns.
7931 (lookup_language_this): Simplify returns.
7932 (lookup_symbol_aux): Simplify return.
7933 (lookup_local_symbol): Simplify returns.
7934 (lookup_global_symbol_from_objfile): Simplify return.
7935 (lookup_symbol_in_objfile_symtabs)
7936 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7937 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7938 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7939 * cp-namespace.c (cp_lookup_bare_symbol)
7940 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7941 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7942 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7943 (cp_lookup_symbol_via_imports): Simplify initialization.
7944 (find_symbol_in_baseclass): Likewise.
7945 * symtab.h (null_block_symbol): Remove.
7946 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7947 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7948 (d_lookup_symbol_module): Likewise.
7949 (find_symbol_in_baseclass): Simplify initialization.
7950
a930ebcd
TT
79512019-03-24 Tom Tromey <tom@tromey.com>
7952
7953 * expression.h: Don't include symtab.h.
7954 (struct block): Forward declare.
7955
582942f4
TT
79562019-03-24 Tom Tromey <tom@tromey.com>
7957
7958 * c-exp.y (typebase): Remove casts.
7959 * gdbtypes.c (lookup_unsigned_typename, )
7960 (lookup_signed_typename): Remove cast.
7961 * eval.c (parse_to_comma_and_eval): Remove cast.
7962 * parse.c (write_dollar_variable): Remove cast.
7963 * block.h (struct block) <superblock>: Now const.
7964 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7965 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7966 (map_block): Make "block" const.
7967 * symfile.h (struct quick_symbol_functions)
7968 <map_matching_symbols>: Constify block argument to "callback".
7969 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7970 const.
7971 (find_pc_sect_compunit_symtab): Make "b" const.
7972 (find_symbol_at_address): Likewise.
7973 (search_symbols): Likewise.
7974 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7975 (dw2_debug_names_lookup_symbol): Likewise.
7976 (dw2_map_matching_symbols): Update.
7977 * p-valprint.c (pascal_val_print): Remove "block".
7978 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7979 (aux_add_nonlocal_symbols): Make "block" const.
7980 (resolve_subexp): Remove cast.
7981 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7982 const.
7983 (iterate_over_file_blocks): Likewise.
7984 * f-exp.y (%union) <bval>: Remove.
7985 * coffread.c (patch_opaque_types): Make "b" const.
7986 * spu-tdep.c (spu_catch_start): Make "block" const.
7987 * c-valprint.c (print_unpacked_pointer): Remove "block".
7988 * symmisc.c (dump_symtab_1): Make "b" const.
7989 (block_depth): Make "block" const.
7990 * d-exp.y (%union) <bval>: Remove.
7991 * cp-support.h (cp_lookup_rtti_type): Update.
7992 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7993 * psymtab.c (psym_lookup_symbol): Make "block" const.
7994 (maintenance_check_psymtabs): Make "b" const.
7995 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7996 (enumerate_locals, enumerate_args): Update.
7997 * python/py-symtab.c (stpy_global_block): Make "block" const.
7998 (stpy_static_block): Likewise.
7999 * inline-frame.c (block_starting_point_at): Make "new_block"
8000 const.
8001 * block.c (find_block_in_blockvector): Make return type const.
8002 (blockvector_for_pc_sect): Make "b" const.
8003 (find_block_in_blockvector): Make "b" const.
8004
7ad417dd
TT
80052019-03-23 Tom Tromey <tom@tromey.com>
8006
8007 * varobj.c (varobj_create): Update.
8008 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8009 * printcmd.c (display_command, do_one_display): Don't reset
8010 innermost_block.
8011 * parser-defs.h (enum innermost_block_tracker_type): Move to
8012 expression.h.
8013 (innermost_block): Update comment.
8014 * parse.c (parse_exp_1): Add tracker_types parameter.
8015 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8016 tracker_types parameter. Reset innermost_block.
8017 (parse_exp_in_context): Remove.
8018 (parse_expression_for_completion): Update.
8019 * objfiles.c (~objfile): Don't reset expression_context_block or
8020 innermost_block.
8021 * expression.h (enum innermost_block_tracker_type): Move from
8022 parser-defs.h.
8023 (parse_exp_1): Add tracker_types parameter.
8024 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8025 reset innermost_block.
8026
b366c208
TT
80272019-03-23 Tom Tromey <tom@tromey.com>
8028
8029 * objfiles.h: Include bcache.h.
8030
9bb9b2f9
TT
80312019-03-23 Tom Tromey <tom@tromey.com>
8032
8033 * linespec.c (get_current_search_block): Use
8034 scoped_restore_current_language.
8035 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8036
59c28372
AH
80372019-03-22 Alan Hayward <alan.hayward@arm.com>
8038 Jiong Wang <jiong.wang@arm.com>
8039
8040 * aarch64-linux-tdep.c
8041 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8042 section.
8043 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8044
17e116a7
AH
80452019-03-22 Alan Hayward <alan.hayward@arm.com>
8046 Jiong Wang <jiong.wang@arm.com>
8047
8048 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8049 instructions.
8050 (aarch64_analyze_prologue_test): Add PACIASP test.
8051 (aarch64_prologue_prev_register): Unmask PC value.
8052
11e1b75f
AH
80532019-03-22 Alan Hayward <alan.hayward@arm.com>
8054 Jiong Wang <jiong.wang@arm.com>
8055
8056 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8057 (aarch64_dwarf2_prev_register): Unmask PC value.
8058 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8059 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8060 DW_CFA_AARCH64_negate_ra_state.
8061 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8062
34dcc7cf
AH
80632019-03-22 Alan Hayward <alan.hayward@arm.com>
8064 Jiong Wang <jiong.wang@arm.com>
8065
8066 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8067 registers.
8068 (aarch64_pseudo_register_name): Likewise.
8069 (aarch64_pseudo_register_type): Likewise.
8070 (aarch64_pseudo_register_reggroup_p): Likewise.
8071 (aarch64_gdbarch_init): Add pauth registers.
8072 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8073 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8074 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8075 (struct gdbarch_tdep): Add regnum for ra_state.
8076
1ef53e6b
AH
80772019-03-22 Alan Hayward <alan.hayward@arm.com>
8078 Jiong Wang <jiong.wang@arm.com>
8079
8080 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8081
76bed0fd
AH
80822019-03-22 Alan Hayward <alan.hayward@arm.com>
8083 Jiong Wang <jiong.wang@arm.com>
8084
8085 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8086 function.
8087 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8088 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8089 (aarch64_gdbarch_init): Add puth registers.
8090 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8091 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8092 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8093
ee4fbcfa
AH
80942019-03-22 Alan Hayward <alan.hayward@arm.com>
8095 Jiong Wang <jiong.wang@arm.com>
8096
8097 * aarch64-linux-nat.c
8098 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8099 * aarch64-linux-tdep.c
8100 (aarch64_linux_core_read_description): Likewise.
8101 (aarch64_linux_get_hwcap): New function.
8102 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8103 (aarch64_linux_get_hwcap): New declaration.
8104
6dc0ebde
AH
81052019-03-22 Alan Hayward <alan.hayward@arm.com>
8106 Jiong Wang <jiong.wang@arm.com>
8107
8108 * aarch64-linux-nat.c
8109 (aarch64_linux_nat_target::read_description): Add pauth param.
8110 * aarch64-linux-tdep.c
8111 (aarch64_linux_core_read_description): Likewise.
8112 * aarch64-tdep.c (struct target_desc): Add in pauth.
8113 (aarch64_read_description): Add pauth param.
8114 (aarch64_gdbarch_init): Likewise.
8115 * aarch64-tdep.h (aarch64_read_description): Likewise.
8116 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8117 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8118 * features/Makefile: Add new files.
8119 * features/aarch64-pauth.c: New file.
8120 * features/aarch64-pauth.xml: New file.
8121
595915c1
TT
81222019-03-20 Tom Tromey <tromey@adacore.com>
8123
8124 * infrun.c (handle_inferior_event): Rename from
8125 handle_inferior_event_1. Create a scoped_value_mark.
8126 (handle_inferior_event): Remove.
8127
4c7d57e7
TT
81282019-03-19 Tom Tromey <tromey@adacore.com>
8129
8130 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8131 * infrun.h (print_stop_event): Add "displays" parameter.
8132 * infrun.c (print_stop_event): Add "displays" parameter.
8133
cb246234
PA
81342019-03-19 Pedro Alves <palves@redhat.com>
8135
8136 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8137 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8138 to -1. Fix TABs vs spaces.
8139 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8140 * tui/tui-out.h (tui_ui_out) Add intro comments.
8141 <m_line, m_start_of_line>: In-class initialize, and add describing
8142 comment.
8143
3a0e45b2
AH
81442019-03-18 Alan Hayward <alan.hayward@arm.com>
8145
8146 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8147 variable names.
8148 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8149
5371b850
PA
81502019-03-18 Pedro Alves <palves@redhat.com>
8151 Eli Zaretskii <eliz@gnu.org>
8152
8153 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8154 m_line and m_start_of_line.
8155
b17c4cd0
EZ
81562019-03-18 Eli Zaretskii <eliz@gnu.org>
8157
8158 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8159 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8160 it returns a newline. This fixes a regression in TU mode, whereby
8161 the next line is output on the same screen line as the user input.
8162
4bd56d18
TT
81632019-03-18 Tom Tromey <tromey@adacore.com>
8164
8165 * minsyms.c (minimal_symbol_reader::install): Remove call to
8166 obstack_blank.
8167
55c10aca
PA
81682019-03-18 Pedro Alves <palves@redhat.com>
8169
8170 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8171 New globals.
8172 (apply_style): New, factored out from ...
8173 (apply_ansi_escape): ... this. Handle reverse video mode.
8174 (tui_set_reverse_mode): New function.
8175 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8176 * tui/tui-winsource.c (tui_show_source_line): Use
8177 tui_set_reverse_mode instead of setting A_STANDOUT.
8178 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8179 New setter methods.
8180
647bb750
HD
81812019-03-18 Hannes Domani <ssbssa@yahoo.de>
8182
8183 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8184 Handle tabs.
8185
bff8c71f
TT
81862019-03-18 Tom Tromey <tromey@adacore.com>
8187
8188 * ada-lang.c (empty_array): Add "high" parameter.
8189 (ada_evaluate_subexp): Update.
8190
58785d98
ST
81912019-03-17 Sergei Trofimovich <siarheit@google.com>
8192
8193 * unittests/string_view-selftests.c: Define
8194 _initialize_string_view_selftests unconditionally.
8195
d4cbef22
ВМ
81962019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8197
8198 PR gdb/24350
8199 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8200
fce4c071
ВМ
82012019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8202
8203 PR gdb/24351
8204 * windows-nat.c (display_selector): Fix format specifiers.
8205
f7f0a123
EZ
82062019-03-17 Eli Zaretskii <eliz@gnu.org>
8207
8208 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8209 tui_refill_source_window instead of tui_refresh_win, to update the
8210 current execution line. This fixes redisplay of the current line
8211 when stepping through the code with "next" or "step".
8212
ab42892f
EZ
82132019-03-16 Eli Zaretskii <eliz@gnu.org>
8214
8215 * source-cache.c (source_cache::get_source_lines): Call
8216 find_source_lines to initialize s->nlines. This fixes vertical
8217 scrolling of TUI source window when the DOWN arrow is pressed.
8218
8d8c087f
PW
82192019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8220
8221 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8222 linux-thread-db.c (_initialize_thread_db): Likewise.
8223
798e1c30
EZ
82242019-03-16 Eli Zaretskii <eliz@gnu.org>
8225
8226 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8227 wclrtoeol in tui_show_source_line". This reverts changes made in
8228 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8229
eefba3da
TT
82302019-03-15 Tom Tromey <tom@tromey.com>
8231
8232 * symtab.h (struct minimal_symbol): Derive from
8233 general_symbol_info.
8234 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8235 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8236 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8237 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8238 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8239 (MSYMBOL_SEARCH_NAME): Update.
8240 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8241 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8242 * minsyms.c (minimal_symbol_reader::record_full): Update.
8243
0de2420c
TT
82442019-03-15 Tom Tromey <tom@tromey.com>
8245
8246 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8247
042d75e4
TT
82482019-03-15 Tom Tromey <tom@tromey.com>
8249
8250 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8251 unique_xmalloc_ptr.
8252 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8253 Update.
8254 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8255 (build_minimal_symbol_hash_tables)
8256 (minimal_symbol_reader::install): Update.
8257
db92718b
TT
82582019-03-15 Tom Tromey <tom@tromey.com>
8259
8260 * symtab.c (create_demangled_names_hash): Update.
8261 (symbol_set_names): Update.
8262 * objfiles.h (struct objfile_per_bfd_storage)
8263 <demangled_names_hash>: Now an htab_up.
8264 * objfiles.c (objfile_per_bfd_storage): Simplify.
8265
d6797f46
TT
82662019-03-15 Tom Tromey <tom@tromey.com>
8267
8268 * objfiles.h (struct objfile_per_bfd_storage): Declare
8269 destructor.
8270 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8271 New.
8272 (get_objfile_bfd_data): Use new. Don't initialize
8273 language_of_main.
8274 (free_objfile_per_bfd_storage): Remove.
8275 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8276
741d7538
TT
82772019-03-15 Tom Tromey <tom@tromey.com>
8278
8279 * symfile.c (reread_symbols): Update.
8280 * objfiles.c (objfile::objfile): Update.
8281 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8282 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8283 comment.
8284 (minimal_symbol_reader::install): Update.
8285 (terminate_minimal_symbol_table): Remove.
8286 * jit.c (jit_object_close_impl): Update.
8287
788c80d1
TT
82882019-03-15 Tom Tromey <tom@tromey.com>
8289
8290 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8291 initializations.
8292
1b7a07cb
TT
82932019-03-15 Tom Tromey <tom@tromey.com>
8294
8295 * objfiles.h (struct objfile_per_bfd_storage)
8296 <demangled_hash_languages>: Now a bitset.
8297 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8298 (lookup_minimal_symbol): Update.
8299
3db066bc
TT
83002019-03-15 Tom Tromey <tom@tromey.com>
8301
8302 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8303 Don't return the symbol.
8304 * coffread.c (record_minimal_symbol): Use record_full.
8305
3fff2c37
EZ
83062019-03-14 Eli Zaretskii <eliz@gnu.org>
8307
8308 The MS-Windows port of ncurses fails to switch to a color pair if
8309 one or both of the colors are the implicit default colors. This
8310 change records the default colors when TUI is initialized, and
8311 then specifies them explicitly when a color pair uses the default
8312 colors. This allows color styling in TUI mode on MS-Windows.
8313
8314 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8315 ncurses_norm_attr.
8316 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8317 colors in ncurses_norm_attr.
8318 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8319 "none", replace it with the default color recorded in
8320 ncurses_norm_attr.
8321
3b336828
TT
83222019-03-14 Tom Tromey <tromey@adacore.com>
8323
8324 * source-cache.h (class source_cache) <get_source_lines>: Return
8325 std::string.
8326 * source-cache.c (source_cache::extract_lines): Handle case where
8327 first_pos==npos. Return std::string.
8328 (source_cache::get_source_lines): Update.
8329
d085f989
TT
83302019-03-14 Tom Tromey <tromey@adacore.com>
8331
8332 * NEWS: Add item for "style sources" commands.
8333 * source-cache.c (source_cache::get_source_lines): Check
8334 source_styling.
8335 * cli/cli-style.c (source_styling): New global.
8336 (_initialize_cli_style): Add "style sources" commands.
8337 (show_style_sources): New function.
8338 * cli/cli-style.h (source_styling): Declare.
8339
6f11e682
TT
83402019-03-14 Pedro Alves <palves@redhat.com>
8341 Tom Tromey <tromey@adacore.com>
8342
8343 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8344 * tui/tui-winsource.c (tui_refill_source_window): New function,
8345 from...
8346 (tui_horizontal_source_scroll): ... here. Move some logic.
8347 * cli/cli-style.c (set_style_enabled): Notify new observable.
8348 * tui/tui-hooks.c (tui_redisplay_source): New function.
8349 (tui_attach_detach_observers): Attach or detach
8350 tui_redisplay_source.
8351 * observable.h (source_styling_changed): New observable.
8352 * observable.c: Define source_styling_changed observable.
8353
a068643d
TT
83542019-03-13 Tom Tromey <tromey@adacore.com>
8355
8356 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8357 (i386_gnu_nat_target::store_registers): Update.
8358 * target-debug.h (target_debug_print_std_string): New macro.
8359 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8360 * windows-tdep.c (display_one_tib): Update.
8361 * tui/tui-stack.c (tui_make_status_line): Update.
8362 * top.c (print_inferior_quit_action): Update.
8363 * thread.c (thr_try_catch_cmd): Update.
8364 (add_thread_with_info): Update.
8365 (thread_target_id_str): Update.
8366 (thr_try_catch_cmd): Update.
8367 (thread_command): Update.
8368 (thread_find_command): Update.
8369 * record-btrace.c (record_btrace_target::info_record)
8370 (record_btrace_resume_thread, record_btrace_target::resume)
8371 (record_btrace_cancel_resume, record_btrace_step_thread)
8372 (record_btrace_target::wait, record_btrace_target::wait)
8373 (record_btrace_target::wait, record_btrace_target::stop): Update.
8374 * progspace.c (print_program_space): Update.
8375 * process-stratum-target.c
8376 (process_stratum_target::thread_address_space): Update.
8377 * linux-fork.c (linux_fork_mourn_inferior)
8378 (detach_checkpoint_command, info_checkpoints_command)
8379 (linux_fork_context): Update.
8380 (linux_fork_detach): Update.
8381 (class scoped_switch_fork_info): Update.
8382 (delete_checkpoint_command): Update.
8383 * infrun.c (follow_fork_inferior): Update.
8384 (follow_fork_inferior): Update.
8385 (proceed_after_vfork_done): Update.
8386 (handle_vfork_child_exec_or_exit): Update.
8387 (follow_exec): Update.
8388 (displaced_step_prepare_throw): Update.
8389 (displaced_step_restore): Update.
8390 (start_step_over): Update.
8391 (resume_1): Update.
8392 (clear_proceed_status_thread): Update.
8393 (proceed): Update.
8394 (print_target_wait_results): Update.
8395 (do_target_wait): Update.
8396 (context_switch): Update.
8397 (stop_all_threads): Update.
8398 (restart_threads): Update.
8399 (finish_step_over): Update.
8400 (handle_signal_stop): Update.
8401 (switch_back_to_stepped_thread): Update.
8402 (keep_going_pass_signal): Update.
8403 (print_exited_reason): Update.
8404 (normal_stop): Update.
8405 * inferior.c (inferior_pid_to_str): Change return type.
8406 (print_selected_inferior): Update.
8407 (add_inferior): Update.
8408 (detach_inferior): Update.
8409 * dummy-frame.c (fprint_dummy_frames): Update.
8410 * dcache.c (dcache_info_1): Update.
8411 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8412 (btrace_fetch, btrace_clear): Update.
8413 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8414 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8415 type.
8416 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8417 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8418 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8419 * gdbarch.c, gdbarch.h: Rebuild.
8420 * gdbarch.sh (core_pid_to_str): Change return type.
8421 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8422 return type.
8423 (windows_nat_target::pid_to_str): Change return type.
8424 (windows_delete_thread): Update.
8425 (windows_nat_target::attach): Update.
8426 (windows_nat_target::files_info): Update.
8427 * target-delegates.c: Rebuild.
8428 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8429 return type.
8430 (sol_thread_target::pid_to_str): Change return type.
8431 * remote.c (class remote_target) <pid_to_str>: Change return
8432 type.
8433 (remote_target::pid_to_str): Change return type.
8434 (extended_remote_target::attach, remote_target::remote_stop_ns)
8435 (remote_target::remote_notif_remove_queued_reply)
8436 (remote_target::push_stop_reply, remote_target::disable_btrace):
8437 Update.
8438 (extended_remote_target::attach): Update.
8439 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8440 type.
8441 (gdbsim_target::pid_to_str): Change return type.
8442 * ravenscar-thread.c (struct ravenscar_thread_target)
8443 <pid_to_str>: Change return type.
8444 (ravenscar_thread_target::pid_to_str): Change return type.
8445 * procfs.c (class procfs_target) <pid_to_str>: Change return
8446 type.
8447 (procfs_target::pid_to_str): Change return type.
8448 (procfs_target::attach): Update.
8449 (procfs_target::detach): Update.
8450 (procfs_target::fetch_registers): Update.
8451 (procfs_target::store_registers): Update.
8452 (procfs_target::wait): Update.
8453 (procfs_target::files_info): Update.
8454 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8455 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8456 return type.
8457 (nto_procfs_target::pid_to_str): Change return type.
8458 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8459 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8460 return type.
8461 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8462 (exit_lwp): Update.
8463 (attach_proc_task_lwp_callback, get_detach_signal)
8464 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8465 (linux_nat_target::resume, wait_lwp, stop_callback)
8466 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8467 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8468 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8469 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8470 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8471 type.
8472 (inf_ptrace_target::attach): Update.
8473 (inf_ptrace_target::files_info): Update.
8474 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8475 type.
8476 (go32_nat_target::pid_to_str): Change return type.
8477 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8478 (gnu_nat_target::wait): Update.
8479 (gnu_nat_target::wait): Update.
8480 (gnu_nat_target::resume): Update.
8481 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8482 (fbsd_nat_target::wait): Update.
8483 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8484 type.
8485 (darwin_nat_target::attach): Update.
8486 * corelow.c (class core_target) <pid_to_str>: Change return type.
8487 (core_target::pid_to_str): Change return type.
8488 * target.c (normal_pid_to_str): Change return type.
8489 (default_pid_to_str): Likewise.
8490 (target_pid_to_str): Change return type.
8491 (target_translate_tls_address): Update.
8492 (target_announce_detach): Update.
8493 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8494 return type.
8495 (bsd_uthread_target::pid_to_str): Change return type.
8496 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8497 type.
8498 (bsd_kvm_target::pid_to_str): Change return type.
8499 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8500 return type.
8501 (aix_thread_target::pid_to_str): Change return type.
8502 * target.h (struct target_ops) <pid_to_str>: Change return type.
8503 (target_pid_to_str, normal_pid_to_str): Likewise.
8504 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8505 type.
8506 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8507 type.
8508 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8509 return type.
8510 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8511 type.
8512 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8513 type.
8514 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8515 return type.
8516
b4be1b06
SM
85172019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8518
8519 * NEWS: Mention that the new default MI version is 3. Mention
8520 changes to the output of commands and events that deal with
8521 multi-location breakpoints.
8522 * breakpoint.c: Include "mi/mi-out.h".
8523 (print_one_breakpoint): Change output syntax if using MI version
8524 >= 3.
8525 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8526 New.
8527 (mi_multi_location_breakpoint_output_fixed): New.
8528 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8529 (mi_cmd_fix_multi_location_breakpoint_output): New.
8530 (mi_multi_location_breakpoint_output_fixed): New.
8531 * mi/mi-cmds.c (mi_cmds): Register command
8532 -fix-multi-location-breakpoint-output.
8533 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8534 interpreter "mi".
8535
8e5e5494
SM
85362019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8537
8538 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8539 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8540 instantiate mi_ui_out based on interpreter name.
8541 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8542 * mi/mi-main.c (mi_load_progress): Likewise.
8543
197df35e
JB
85442019-03-12 John Baldwin <jhb@FreeBSD.org>
8545
8546 * NEWS: Combine separate "New targets" sections for 8.3.
8547
8399425f
JB
85482019-03-12 John Baldwin <jhb@FreeBSD.org>
8549
8550 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8551 (ppcfbsd_init_abi): Install gdbarch
8552 "fetch_tls_load_module_address" and "get_thread_local_address"
8553 methods.
8554
b0f87ed0
JB
85552019-03-12 John Baldwin <jhb@FreeBSD.org>
8556
8557 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8558 (riscv_fbsd_init_abi): Install gdbarch
8559 "fetch_tls_load_module_address" and "get_thread_local_address"
8560 methods.
8561
ce25aa57
JB
85622019-03-12 John Baldwin <jhb@FreeBSD.org>
8563
8564 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8565 (i386fbsd_init_abi): Install gdbarch
8566 "fetch_tls_load_module_address" and "get_thread_local_address"
8567 methods.
8568
f5424cfa
JB
85692019-03-12 John Baldwin <jhb@FreeBSD.org>
8570
8571 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8572 (amd64fbsd_init_abi): Install gdbarch
8573 "fetch_tls_load_module_address" and "get_thread_local_address"
8574 methods.
8575
945f3901
JB
85762019-03-12 John Baldwin <jhb@FreeBSD.org>
8577
8578 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8579 (struct fbsd_pspace_data): New type.
8580 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8581 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8582 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8583 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8584 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8585
ef0bd204
JB
85862019-03-12 John Baldwin <jhb@FreeBSD.org>
8587
8588 * gdbtypes.c (lookup_struct_elt): New function.
8589 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8590 * gdbtypes.h (struct struct_elt): New type.
8591 (lookup_struct_elt): New prototype.
8592
36c53a02
JB
85932019-03-12 John Baldwin <jhb@FreeBSD.org>
8594
8595 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8596 remove disabled code block.
8597
6e056c81
JB
85982019-03-12 John Baldwin <jhb@FreeBSD.org>
8599
8600 * gdbarch.sh (get_thread_local_address): New method.
8601 * gdbarch.h, gdbarch.c: Regenerate.
8602 * target.c (target_translate_tls_address): Use
8603 gdbarch_get_thread_local_address if present instead of
8604 target::get_thread_local_address.
8605
cd250a18
JB
86062019-03-12 John Baldwin <jhb@FreeBSD.org>
8607
8608 * target.h (target::get_thread_local_address): Update comment.
8609
df22c1e5
JB
86102019-03-12 John Baldwin <jhb@FreeBSD.org>
8611
8612 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8613 objfile->separate_debug_objfile_backlink if not NULL.
8614
dd6876c9
JB
86152019-03-12 John Baldwin <jhb@FreeBSD.org>
8616
8617 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8618 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8619 (amd64bsd_store_inferior_registers): Likewise.
8620 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8621 Enable segment base registers.
8622 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8623 PT_GETFSBASE and PT_GETGSBASE.
8624 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8625 PT_SETGSBASE.
8626 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8627 segment base registers.
8628 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8629
1163a4b7
JB
86302019-03-12 John Baldwin <jhb@FreeBSD.org>
8631
8632 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8633 Update calls to i386_target_description to add 'segments'
8634 parameter.
8635 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8636 add segment base registers.
8637 * arch/i386.c (i386_create_target_description): Add 'segments'
8638 parameter to enable segment base registers.
8639 * arch/i386.h (i386_create_target_description): Likewise.
8640 * features/i386/32bit-segments.xml: New file.
8641 * features/i386/32bit-segments.c: Generate.
8642 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8643 call to i386_target_description to add 'segments' parameter.
8644 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8645 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8646 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8647 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8648 if feature is present.
8649 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8650 Add 'segments' parameter to call to i386_target_description.
8651 (i386_target_description): Add 'segments' parameter to enable
8652 segment base registers.
8653 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8654 to call to i386_target_description.
8655 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8656 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8657 Define I386_NUM_REGS.
8658 (i386_target_description): Add 'segments' parameter to enable
8659 segment base registers.
8660
3a350822
EZ
86612019-03-12 Eli Zaretskii <eliz@gnu.org>
8662
8663 PR/24325
8664 * source-cache.c: #undef open and close, to avoid unresolved
8665 externals during linking.
8666
ffdd69cf
TT
86672019-03-12 Tom Tromey <tromey@adacore.com>
8668
8669 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8670 const. Add initializers.
8671 (_initialize_remote): Don't initialize ptid globals.
8672
ec148c57
PA
86732019-03-12 Pedro Alves <palves@redhat.com>
8674
8675 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8676
32764270
PA
86772019-03-12 Pedro Alves <palves@redhat.com>
8678
8679 * cp-name-parser.y (main): Remove unused 'len' variable.
8680
17547186
TT
86812019-03-12 Tom Tromey <tromey@adacore.com>
8682
8683 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8684 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8685
d3a70e03
TT
86862019-03-12 Tom Tromey <tromey@adacore.com>
8687
8688 * linux-nat.c (iterate_over_lwps): Update.
8689 (stop_callback): Remove parameter.
8690 (stop_wait_callback, detach_callback, resume_set_callback)
8691 (select_singlestep_lwp_callback, set_ignore_sigint)
8692 (status_callback, resumed_callback, resume_clear_callback)
8693 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8694 data parameter.
8695 (linux_nat_target::detach, linux_nat_target::resume)
8696 (linux_stop_and_wait_all_lwps, select_event_lwp)
8697 (linux_nat_filter_event, linux_nat_wait_1)
8698 (linux_nat_target::kill, linux_nat_target::stop)
8699 (linux_nat_target::stop): Update.
8700 (linux_nat_resume_callback): Change type.
8701 (resume_stopped_resumed_lwps, count_events_callback)
8702 (select_event_lwp_callback): Likewise.
8703 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8704 * arm-linux-nat.c (struct update_registers_data): Remove.
8705 (update_registers_callback): Change type.
8706 (arm_linux_insert_hw_breakpoint1): Update.
8707 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8708 parameter.
8709 (x86_linux_dr_set_addr): Update.
8710 (x86_linux_dr_set_control): Update.
8711 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8712 (iterate_over_lwps): Use gdb::function_view.
8713 * nat/aarch64-linux-hw-point.c (struct
8714 aarch64_dr_update_callback_param): Remove.
8715 (debug_reg_change_callback): Change type.
8716 (aarch64_notify_debug_reg_change): Update.
8717 * s390-linux-nat.c (s390_refresh_per_info): Update.
8718
82cb27ff
TT
87192019-03-11 Tom Tromey <tromey@adacore.com>
8720
8721 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8722 redundant assignment to "this_cu".
8723
568c0683
SM
87242019-03-08 Simon Marchi <simon.marchi@efficios.com>
8725
8726 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8727
f09ce22d
SM
87282019-03-08 Simon Marchi <simon.marchi@efficios.com>
8729
8730 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8731 from...
8732 (rank_one_type): ... this.
8733
595f96a9
SM
87342019-03-08 Simon Marchi <simon.marchi@efficios.com>
8735
8736 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8737 from...
8738 (rank_one_type): ... this.
8739
2598a94b
SM
87402019-03-08 Simon Marchi <simon.marchi@efficios.com>
8741
8742 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8743 from...
8744 (rank_one_type): ... this.
8745
7f17b20d
SM
87462019-03-08 Simon Marchi <simon.marchi@efficios.com>
8747
8748 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8749 from...
8750 (rank_one_type): ... this.
8751
2c509035
SM
87522019-03-08 Simon Marchi <simon.marchi@efficios.com>
8753
8754 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8755 from...
8756 (rank_one_type): ... this.
8757
0dd322dc
SM
87582019-03-08 Simon Marchi <simon.marchi@efficios.com>
8759
8760 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8761 from...
8762 (rank_one_type): ... this.
8763
41ea4728
SM
87642019-03-08 Simon Marchi <simon.marchi@efficios.com>
8765
8766 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8767 from...
8768 (rank_one_type): ... this.
8769
793cd1d2
SM
87702019-03-08 Simon Marchi <simon.marchi@efficios.com>
8771
8772 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8773 from...
8774 (rank_one_type): ... this.
8775
34910087
SM
87762019-03-08 Simon Marchi <simon.marchi@efficios.com>
8777
8778 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8779 from...
8780 (rank_one_type): ... this.
8781
f1f832d6
SM
87822019-03-08 Simon Marchi <simon.marchi@efficios.com>
8783
8784 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8785 from...
8786 (rank_one_type): ... this.
8787
b9f4512f
SM
87882019-03-08 Simon Marchi <simon.marchi@efficios.com>
8789
8790 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8791 from...
8792 (rank_one_type): ... this.
8793
9293fc63
SM
87942019-03-08 Simon Marchi <simon.marchi@efficios.com>
8795
8796 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8797 from...
8798 (rank_one_type): ... this.
8799
e3abbe7e
PW
88002019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8801
8802 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8803 inferior-events' shows the example events.
8804
e4adb939
EZ
88052019-03-08 Eli Zaretskii <eliz@gnu.org>
8806
8807 Support styling on native MS-Windows console
8808
8809 PR/24315
8810 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8811 on MS-Windows if $TERM is not defined.
8812
8813 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8814
8815 * posix-hdep.c (gdb_console_fputs):
8816 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8817 functions.
8818 * ui-file.h (gdb_console_fputs): Add prototype.
8819
8820 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8821 back to fputs only if the former returns zero.
8822
25629dfd
TT
88232019-03-07 Tom Tromey <tom@tromey.com>
8824
8825 * symmisc.c (print_symbol_bcache_statistics): Update.
8826 (print_objfile_statistics): Update.
8827 * symfile.c (allocate_symtab): Update.
8828 * stabsread.c: Don't include bcache.h.
8829 * psymtab.h (struct psymbol_bcache): Don't declare.
8830 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8831 (psymbol_bcache_init, psymbol_bcache_free)
8832 (psymbol_bcache_get_bcache): Don't declare.
8833 * psymtab.c (struct psymbol_bcache): Remove.
8834 (psymtab_storage::psymtab_storage): Update.
8835 (psymtab_storage::~psymtab_storage): Update.
8836 (psymbol_bcache_init, psymbol_bcache_free)
8837 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8838 (add_psymbol_to_bcache): Update.
8839 (allocate_psymtab): Update.
8840 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8841 macro_cache>: No longer pointers.
8842 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8843 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8844 * macrotab.c (macro_bcache): Update.
8845 * macroexp.c: Don't include bcache.h.
8846 * gdbtypes.c (check_types_worklist): Update.
8847 (types_deeply_equal): Remove TRY/CATCH. Update.
8848 * elfread.c (elf_symtab_read): Update.
8849 * dwarf2read.c: Don't include bcache.h.
8850 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8851 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8852 (print_bcache_statistics, bcache_memory_used): Don't declare.
8853 (struct bcache): Move from bcache.c. Add constructor, destructor,
8854 methods. Rename all data members.
8855 * bcache.c (struct bcache): Move to bcache.h.
8856 (bcache::expand_hash_table): Rename from expand_hash_table.
8857 (bcache): Remove.
8858 (bcache::insert): Rename from bcache_full.
8859 (bcache::compare): Rename from bcache_compare.
8860 (bcache_xmalloc): Remove.
8861 (bcache::~bcache): Rename from bcache_xfree.
8862 (bcache::print_statistics): Rename from print_bcache_statistics.
8863 (bcache::memory_used): Rename from bcache_memory_used.
8864
fe726667
PA
88652019-03-07 Pedro Alves <palves@redhat.com>
8866
8867 * infrun.c (normal_stop): Also check for
8868 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8869
7584bb30
AB
88702019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8871
8872 * f-lang.c (value_from_host_double): Moved to...
8873 * value.c (value_from_host_double): ...here.
8874 * value.h (value_from_host_double): Declare.
8875 * guile/scm-math.c (vlscm_convert_typed_number): Use
8876 value_from_host_double.
8877 (vlscm_convert_number): Likewise.
8878 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8879 * python/py-value.c (convert_value_from_python): Likewise.
8880
a7b1986e
TT
88812019-03-06 Tom Tromey <tom@tromey.com>
8882
8883 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8884
0ccf4211
TT
88852019-03-06 Tom Tromey <tom@tromey.com>
8886
8887 * utils.h (free_current_contents): Don't declare.
8888 * utils.c (free_current_contents): Remove.
8889
fe7b42e5
TT
88902019-03-06 Tom Tromey <tom@tromey.com>
8891
8892 * top.c (quit_force): Update.
8893 * main.c (captured_command_loop): Update.
8894 * common/new-op.c (operator new): Update.
8895 * common/common-exceptions.c (struct catcher)
8896 <save_cleanup_chain>: Remove member.
8897 (exceptions_state_mc_init): Update.
8898 (exception_try_scope_entry): Return nullptr.
8899 (exception_try_scope_exit, exception_rethrow)
8900 (throw_exception_sjlj, throw_exception_cxx): Update.
8901 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8902 (all_cleanups, do_cleanups, discard_cleanups)
8903 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8904 (restore_cleanups, restore_final_cleanups): Don't declare.
8905 (do_final_cleanups): Remove parameter.
8906 * common/cleanups.c (cleanup_chain, make_cleanup)
8907 (make_cleanup_dtor, all_cleanups, do_cleanups)
8908 (discard_my_cleanups, discard_cleanups)
8909 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8910 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8911 (null_cleanup): Remove.
8912 (do_final_cleanups): Remove parameter.
8913
c6321f19
TT
89142019-03-06 Tom Tromey <tom@tromey.com>
8915
8916 * remote.c (remote_target::remote_parse_stop_reply): Use
8917 unique_xmalloc_ptr.
8918
61b30099
TT
89192019-03-06 Tom Tromey <tom@tromey.com>
8920
8921 * stabsread.c (struct stabs_field_info): Rename from field_info.
8922 <list, fnlist>: Add initializers.
8923 <obstack>: New member.
8924 (read_member_functions, read_struct_fields, read_baseclasses):
8925 Allocate on obstack. Don't use cleanups.
8926 (read_one_struct_field, read_member_functions, read_struct_fields)
8927 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8928 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8929 (read_struct_type): Update.
8930
6cceac94
TT
89312019-03-06 Tom Tromey <tom@tromey.com>
8932
8933 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8934 * common/filestuff.h (make_cleanup_close): Don't declare.
8935 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8936 Remove.
8937
72412762
TT
89382019-03-06 Tom Tromey <tom@tromey.com>
8939
8940 * solib-aix.c: Use make_scope_exit.
8941
2b6ff1c0
TT
89422019-03-06 Tom Tromey <tom@tromey.com>
8943
8944 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8945 Use make_scope_exit.
8946
d01c5877
TT
89472019-03-06 Tom Tromey <tom@tromey.com>
8948
8949 * solib-svr4.c (disable_probes_interface): Remove parameter.
8950 (svr4_handle_solib_event): Use make_scope_exit.
8951
32603266
TT
89522019-03-06 Tom Tromey <tom@tromey.com>
8953
8954 * remote.c (struct stop_reply_deleter): Remove.
8955 (stop_reply_up): Update.
8956 (struct stop_reply): Derive from notif_event. Don't typedef.
8957 <regcache>: Now a std::vector.
8958 (stop_reply_xfree): Remove.
8959 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8960 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8961 (remote_target::discard_pending_stop_replies): Use delete.
8962 (remote_target::remote_parse_stop_reply): Update.
8963 (remote_target::process_stop_reply): Update.
8964 * remote-notif.h (struct notif_event): Add virtual destructor.
8965 Remove "dtr" member.
8966 (struct notif_client) <alloc_event>: Return a unique_ptr.
8967 (notif_event_xfree): Don't declare.
8968 (notif_event_up): New typedef.
8969 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8970 (notif_event_xfree, do_notif_event_xfree): Remove.
8971 (remote_notif_state_xfree): Update.
8972
9799571e
TT
89732019-03-06 Tom Tromey <tom@tromey.com>
8974
8975 * infrun.c (displaced_step_clear_cleanup): Now a
8976 forward_scope_exit type.
8977 (displaced_step_prepare_throw): Update.
8978 (displaced_step_fixup): Update.
8979
09e3c4ca
TT
89802019-03-06 Tom Tromey <tom@tromey.com>
8981
8982 * inferior.h (class inferior): Update comment.
8983 * gdbthread.h (class thread_info): Update comment.
8984
e2a03548
TT
89852019-03-06 Joel Brobecker <brobecker@adacore.com>
8986 Tom Tromey <tom@tromey.com>
8987
8988 * stabsread.h (struct stab_section_list): Remove.
8989 (coffstab_build_psymtabs): Update.
8990 * dbxread.c (symbuf_sections): Now a std::vector.
8991 (sect_idx): New global.
8992 (fill_symbuf): Update.
8993 (coffstab_build_psymtabs): Change type of stabsects parameter.
8994 Update.
8995 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8996 std::vector.
8997 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8998 (coff_locate_sections): Update.
8999 (coff_symfile_read): Remove cleanups. Update.
9000 (init_stringtab): Add storage parameter.
9001 (free_stringtab, free_stringtab_cleanup): Remove.
9002 (init_lineno): Add storage parameter.
9003 (free_linetab, free_linetab_cleanup): Remove.
9004
b7e60d85
PA
90052019-03-06 Pedro Alves <palves@redhat.com>
9006
9007 * linux-fork.c (fork_info::clobber_regs): Delete.
9008 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9009 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9010 comment. Adjust.
9011 (scoped_switch_fork_info::scoped_switch_fork_info)
9012 (checkpoint_command, linux_fork_context): Adjust
9013 fork_save_infrun_state calls.
9014
e52c971f
PA
90152019-03-06 Pedro Alves <palves@redhat.com>
9016
9017 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9018 (inf_has_multiple_threads): Return 'bool' and rewrite using
9019 inferior_info::threads().
9020
06974e6c
PA
90212019-03-06 Pedro Alves <palves@redhat.com>
9022
9023 * linux-fork.c: Include <list>.
9024 (fork_list): Now a std::list instance.
9025 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9026 (forks_exist_p, find_last_fork): Adjust.
9027 (new_fork): Delete.
9028 (one_fork_p): New.
9029 (add_fork): Adjust.
9030 (free_fork): Delete, folded into fork_info::~fork_info().
9031 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9032 Adjust.
9033 (init_fork_list): Delete.
9034 (linux_fork_killall, linux_fork_mourn_inferior)
9035 (linux_fork_detach, info_checkpoints_command): Adjust.
9036 (_initialize_linux_fork): No longer call init_fork_list.
9037
72f31aea
PA
90382019-03-06 Pedro Alves <palves@redhat.com>
9039
9040 * linux-fork.c (new_fork): New, split out of ...
9041 (add_fork): ... this. Return void. Move "first fork" special
9042 case from here, to ...
9043 (checkpoint_command): ... here.
9044 * linux-linux.h (add_fork): Return void.
9045
efbecbc1
AB
90462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9047
9048 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9049
0841c79a
AB
90502019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9051 Chris January <chris.january@arm.com>
9052 David Lecomber <david.lecomber@arm.com>
9053
9054 * f-exp.y: New token, UNOP_INTRINSIC.
9055 (exp): New pattern using UNOP_INTRINSIC token.
9056 (f77_keywords): Add 'abs' keyword.
9057 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9058 (value_from_host_double): New function.
9059 (evaluate_subexp_f): Support UNOP_ABS.
9060
4a270568
AB
90612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9062
9063 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9064 types.
9065
067630bd
AB
90662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9067
9068 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9069 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9070 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9071
3be47f7a
AB
90722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9073
9074 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9075
4d00f5d8
AB
90762019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9077 Chris January <chris.january@arm.com>
9078
9079 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9080 * f-exp.y: Define 'KIND' token.
9081 (exp): New pattern for KIND expressions.
9082 (ptype): Handle types with a kind extension.
9083 (direct_abs_decl): Extend to spot kind extensions.
9084 (f77_keywords): Add 'kind' to the list.
9085 (push_kind_type): New function.
9086 (convert_to_kind_type): New function.
9087 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9088 * parse.c (operator_length_standard): Likewise.
9089 * parser-defs.h (enum type_pieces): Add tp_kind.
9090 * std-operator.def: Add UNOP_KIND.
9091
e454224f
AB
90922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9093
9094 * f-exp.y (f_parse): Set yydebug.
9095
9dad4a58
AB
90962019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9097
9098 * f-lang.c (evaluate_subexp_f): New function.
9099 (exp_descriptor_f): New global.
9100 (f_language_defn): Use exp_descriptor_f instead of
9101 exp_descriptor_standard.
9102
c8f91604
AB
91032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9104
9105 * f-exp.y (struct token): Add comments.
9106 (dot_ops): Remove uppercase versions and the end marker.
9107 (f77_keywords): Likewise.
9108 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9109 entries in the dot_ops array are case insensitive, and use
9110 strncasecmp to compare strings. Also some whitespace cleanup in
9111 this area. Similar for the f77_keywords array, except entries in
9112 this list might be case sensitive.
9113
dd9f2c76
AB
91142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9115
9116 * f-exp.y (struct f77_boolean_val): Add comments.
9117 (boolean_values): Remove uppercase versions, and end marker.
9118 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9119 and use strncasecmp to achieve case insensitivity. Additionally,
9120 perform whitespace cleanup around this code.
9121
67a3048c
TT
91222019-03-06 Tom Tromey <tromey@adacore.com>
9123
9124 * remote-sim.c (gdbsim_target_open): Use result of
9125 gdb_argv::release.
9126
aa3cfbda
RB
91272019-03-06 Richard Bunt <richard.bunt@arm.com>
9128 Dirk Schubert <dirk.schubert@arm.com>
9129 Chris January <chris.january@arm.com>
9130
9131 * eval.c (evaluate_subexp_standard): Call Fortran argument
9132 wrapping logic.
9133 * f-lang.c (struct value): A value which can be passed into a
9134 Fortran function call.
9135 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9136 where appropriate.
9137 (struct type): Value ready for a Fortran function call.
9138 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9139 is needed.
9140 * f-lang.h (fortran_argument_convert): Declaration.
9141 (fortran_preserve_arg_pointer): Declaration.
9142 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9143
ea38e5df
TT
91442019-03-05 Tom Tromey <tromey@adacore.com>
9145
9146 * python/py-prettyprint.c (print_string_repr): Remove #if.
9147 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9148
06b5b831
TT
91492019-03-05 Tom Tromey <tromey@adacore.com>
9150
9151 * target.c (the_dummy_target): Move later. Change type to
9152 "dummy_target".
9153 (initialize_targets): Don't initialize the_dummy_target.
9154
edbd9e45
TT
91552019-03-05 Tom Tromey <tromey@adacore.com>
9156
9157 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9158 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9159
c119e040
TT
91602019-03-05 Tom Tromey <tromey@adacore.com>
9161
9162 * windows-nat.c (windows_nat_target::attach)
9163 (windows_nat_target::detach): Don't call gdb_flush.
9164 * valprint.c (generic_val_print, val_print, val_print_string):
9165 Don't call gdb_flush.
9166 * utils.c (defaulted_query): Don't call gdb_flush.
9167 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9168 * target.c (target_announce_detach): Don't call gdb_flush.
9169 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9170 * remote.c (extended_remote_target::attach): Don't call
9171 gdb_flush.
9172 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9173 * printcmd.c (do_examine): Don't call gdb_flush.
9174 (info_display_command): Don't call gdb_flush.
9175 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9176 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9177 * memattr.c (info_mem_command): Don't call gdb_flush.
9178 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9179 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9180 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9181 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9182 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9183 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9184 (gnu_nat_target::detach): Don't call gdb_flush.
9185 * f-valprint.c (f_val_print): Don't call gdb_flush.
9186 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9187 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9188 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9189 gdb_flush.
9190 * c-valprint.c (c_val_print): Don't call gdb_flush.
9191 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9192
895dafa6
TT
91932019-03-05 Tom Tromey <tromey@adacore.com>
9194
9195 * varobj.c (update_dynamic_varobj_children): Update.
9196 (install_default_visualizer): Use reset, not release.
9197 * value.c (set_internalvar): Update.
9198 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9199 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9200 ATTRIBUTE_UNUSED_RESULT.
9201
88a774b9
TT
92022019-03-05 Tom Tromey <tromey@adacore.com>
9203
9204 * remote.c (class scoped_remote_fd) <release>: Add
9205 ATTRIBUTE_UNUSED_RESULT.
9206
4e4a8b93
TT
92072019-03-05 Tom Tromey <tromey@adacore.com>
9208
9209 * macroexp.c (struct macro_buffer) <release>: Add
9210 ATTRIBUTE_UNUSED_RESULT.
9211
083eef1f
TT
92122019-03-05 Tom Tromey <tromey@adacore.com>
9213
9214 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9215 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9216 ATTRIBUTE_UNUSED_RESULT.
9217
3cabd438
TT
92182019-03-05 Tom Tromey <tromey@adacore.com>
9219
9220 * common/scoped_fd.h (class scoped_fd) <release>: Add
9221 ATTRIBUTE_UNUSED_RESULT.
9222
41e3300a
TT
92232019-03-05 Tom Tromey <tromey@adacore.com>
9224
9225 * parser-defs.h (struct parser_state) <release>: Add
9226 ATTRIBUTE_UNUSED_RESULT.
9227
18cb7c9f
TT
92282019-03-05 Tom Tromey <tromey@adacore.com>
9229
9230 * utils.h (class gdb_argv) <release>: Add
9231 ATTRIBUTE_UNUSED_RESULT.
9232 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9233
41fa577f
EZ
92342019-03-02 Eli Zaretskii <eliz@gnu.org>
9235
a6a4b2c6
EZ
9236 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9237 for-loop range, to avoid compiler warnings.
9238
9239 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9240 avoid compiler warnings about unused variables.
9241
742a7df5
EZ
9242 * NEWS: Mention end of support for native debugging on MS-Windows
9243 before XP.
9244
41fa577f
EZ
9245 PR gdb/24292
9246 * common/netstuff.c:
9247 * gdbserver/gdbreplay.c
9248 * gdbserver/remote-utils.c:
9249 * ser-tcp.c:
9250 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9251 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9252 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9253 'getaddrinfo' and 'freeaddrinfo' were not available before
9254 Windows XP, and mingw.org's MinGW headers by default define
9255 _WIN32_WINNT to 0x500.
9256
827f438f
GB
92572019-03-01 Gary Benson <gbenson@redhat.com>
9258
9259 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9260
92137da0
RO
92612019-02-28 Brian Vandenberg <phantall@gmail.com>
9262 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9263
9264 PR gdb/8527
9265 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9266 set_sigint_trap, clear_sigint_trap.
9267
799efbe8
PW
92682019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9269
9270 * target.c (target_detach): Clear the regcache and the
9271 frame cache.
9272
8ed25214
PA
92732019-02-27 Pedro Alves <palves@redhat.com>
9274
9275 * utils.c (set_screen_size): When we cap the height/width sizes,
9276 tweak the corresponding command variable to show "unlimited":
9277
23031e31
SJ
92782019-02-27 Saagar Jha <saagar@saagarjha.com>
9279 Pedro Alves <palves@redhat.com>
9280
9281 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9282 before calling rl_set_screen_size.
9283
6c28e44a
TT
92842019-02-27 Tom Tromey <tromey@adacore.com>
9285
9286 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9287 define.
9288 * python/py-value.c: Remove Python 2.4 workaround.
9289 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9290 workaround.
9291 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9292 Python 2.4 workaround.
9293 * python/python-internal.h: Remove Python 2.4 comment.
9294 (Py_ssize_t): Don't define.
9295 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9296 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9297 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9298 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9299 * python/python.c (do_start_initialization): Remove Python 2.4
9300 workaround.
9301 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9302 (print_children): Remove Python 2.4 workaround.
9303 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9304 workaround.
9305 (CHARBUFFERPROC_NAME): Remove.
9306 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9307 Python 2.4 workaround.
9308
2c3fc25d 93092019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9310
2c3fc25d
KB
9311 * NEWS: Note minimum Python version.
9312
6ca62222
KB
93132019-02-27 Kevin Buettner <kevinb@redhat.com>
9314
9315 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9316 code from these functions. Remove corresponding ifdefs. Use
9317 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9318 Remove gotos and target of gotos.
9319 (infpy_search_memory): Likewise.
9320
f4bc7d2c
AB
93212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9322
9323 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9324 (hppa_gdbarch_init): Don't register deleted functions with
9325 gdbarch.
9326
9734a586
AB
93272019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9328
9329 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9330 (h8300_unwind_sp): Delete.
9331 (h8300_dummy_id): Delete.
9332 (h8300_gdbarch_init): Don't register deleted functions with
9333 gdbarch.
9334
68b867f3
AB
93352019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9336
9337 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9338 (ft32_unwind_pc): Delete.
9339 (ft32_unwind_sp): Delete.
9340 (ft32_gdbarch_init): Don't register deleted functions with
9341 gdbarch.
9342
2fbe7ad0
AB
93432019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9344
9345 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9346 (frv_unwind_pc): Delete.
9347 (frv_unwind_sp): Delete.
9348 (frv_gdbarch_init): Don't register deleted functions with
9349 gdbarch.
9350
76055cbe
AB
93512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9352
9353 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9354 (riscv_unwind_pc): Delete.
9355 (riscv_unwind_sp): Delete.
9356 (riscv_gdbarch_init): Don't register deleted functions with
9357 gdbarch.
9358
4133e5a1
AB
93592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9360
9361 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9362 (csky_unwind_pc): Delete.
9363 (csky_unwind_sp): Delete.
9364 (csky_gdbarch_init): Don't register deleted functions with
9365 gdbarch.
9366
8010f576
AB
93672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9368
9369 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9370 (cris_unwind_pc): Delete.
9371 (cris_unwind_sp): Delete.
9372 (cris_gdbarch_init): Don't register deleted functions with
9373 gdbarch.
9374
b56bf084
AB
93752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9376
9377 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9378 (bfin_unwind_pc): Delete.
9379 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9380
a19a650f
AB
93812019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9382
9383 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9384 (arm_unwind_pc): Delete.
9385 (arm_unwind_sp): Delete.
9386 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9387
f8278c3c
AB
93882019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9389
9390 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9391 (arc_unwind_pc): Delete.
9392 (arc_unwind_sp): Delete.
9393 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9394
480e46cf
AB
93952019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9396
9397 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9398 (alpha_unwind_pc): Delete.
9399 (alpha_gdbarch_init): Don't register deleted functions with
9400 gdbarch.
9401
7a995095
AB
94022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9403
9404 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9405 (aarch64_unwind_pc): Delete.
9406 (aarch64_unwind_sp): Delete.
9407 (aarch64_gdbarch_init): Don't register deleted functions with
9408 gdbarch.
9409
bf9a735e
AB
94102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9411
9412 * gdbtypes.c (type_align): Don't consider static members when
9413 computing structure alignment.
9414
5561fc30
AB
94152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9416
9417 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9418 return 0 for other types.
9419 * arch-utils.c (default_type_align): Always return 0.
9420 * gdbarch.h: Regenerate.
9421 * gdbarch.sh (type_align): Extend comment.
9422 * gdbtypes.c (type_align): Add additional comments, always call
9423 gdbarch_type_align before applying the default rules.
9424 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9425 generic code will then apply a suitable default.
9426 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9427 types, return 0 for other types.
9428
9335e75a
JB
94292019-02-27 Joel Brobecker <brobecker@adacore.com>
9430
9431 * NEWS: Create a new section for the next release branch.
9432 Rename the section of the current branch, now that it has
9433 been cut.
9434
3d34d8de
JB
94352019-02-27 Joel Brobecker <brobecker@adacore.com>
9436
9437 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9438 * version.in: Bump version to 8.3.50.DATE-git.
9439
143420fb
SM
94402019-02-26 Simon Marchi <simon.marchi@efficios.com>
9441
9442 * aix-thread.c (ptid_cmp): Remove unused variable.
9443 (get_signaled_thread): Likewise.
9444 (store_regs_user_thread): Likewise.
9445 (store_regs_kernel_thread): Likewise.
9446 (fetch_regs_kernel_thread): Remove shadowed variable.
9447
172fb711
AB
94482019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9449
9450 * features/riscv/32bit-cpu.xml: Add register numbers.
9451 * features/riscv/32bit-fpu.c: Regenerate.
9452 * features/riscv/32bit-fpu.xml: Add register numbers.
9453 * features/riscv/64bit-cpu.xml: Add register numbers.
9454 * features/riscv/64bit-fpu.c: Regenerate.
9455 * features/riscv/64bit-fpu.xml: Add register numbers.
9456
26c89782
KB
94572019-02-26 Kevin Buettner <kevinb@redhat.com>
9458
af54ade9 9459 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9460 * python/py-value.c (convert_buffer_and_type_to_value): New
9461 function.
9462 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9463 Add support for handling an optional second argument. Call
9464 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9465 * python/python-internal.h (Py_buffer_deleter): New struct.
9466 (Py_buffer_up): New typedef.
9467
0f58c9e8
JB
94682019-02-25 John Baldwin <jhb@FreeBSD.org>
9469
9470 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9471 instead of releasing ownership.
9472
0a0f4c01
JR
94732019-02-25 Jordan Rupprecht <rupprecht@google.com>
9474
9475 * dwarf2read.c (open_and_init_dwp_file): Call
9476 elf_numsections instead of bfd_count_sections to initialize
9477 dwp_file->num_sections.
9478
cd5a152c
TT
94792019-02-25 Tom Tromey <tromey@adacore.com>
9480
9481 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9482
8a6a8513
SDJ
94832019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9484
9485 * gcore.in: Add '--readnever' option when invoking GDB.
9486
04dcda9c
SM
94872019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9488
9489 * MAINTAINERS: Update my email address.
9490
07bc701d
SM
94912019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9492
9493 * build-id.c (build_id_to_debug_bfd_1): New function.
9494 (build_id_to_debug_bfd): Look for separate debug file in
9495 sysroot.
9496
c6f4a5d0
AB
94972019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9498
9499 * gdbarch.sh: Update the copyright year range that is placed into
9500 generated files.
9501
9600246d
KS
95022019-02-22 Keith Seitz <keiths@redhat.com>
9503
9504 PR symtab/23853
9505 * linespec.c (create_sals_line_offset): Search for the default
9506 symtab's filename instead of its fullname.
9507
7557a514
AH
95082019-02-21 Alan Hayward <alan.hayward@arm.com>
9509
9510 * NEWS: Update style defaults.
9511
ee2bcb0c
AH
95122019-02-21 Alan Hayward <alan.hayward@arm.com>
9513
9514 * main.c (captured_main_1): Disable styling in batch mode.
9515
0c95f9ed
TT
95162019-02-20 Tom Tromey <tom@tromey.com>
9517
9518 * symtab.c (symtab_symbol_info): Fix typos.
9519
c763b894
TT
95202019-02-20 Tom Tromey <tromey@adacore.com>
9521
9522 * findcmd.c (_initialize_mem_search): Use upper case for
9523 metasyntactic variables.
9524
0ef8a082
AH
95252019-02-20 Alan Hayward <alan.hayward@arm.com>
9526
9527 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9528 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9529
6caa91b6
SM
95302019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9531
9532 * top.h (source_file_name): Change to std::string.
9533 * top.c (source_file_name): Likewise.
9534 (command_line_input): Adjust.
9535 * cli/cli-script.c (script_from_file): Adjust.
9536
98814c6c
TT
95372019-02-19 Tom Tromey <tromey@adacore.com>
9538
9539 * ravenscar-thread.c
9540 (ravenscar_thread_target::update_thread_list): Don't call
9541 ada_build_task_list.
9542 * ada-lang.h (ada_build_task_list): Don't declare.
9543 * ada-tasks.c (struct ada_tasks_inferior_data)
9544 <task_list_valid_p>: Now bool.
9545 (read_known_tasks, ada_task_list_changed)
9546 (ada_tasks_invalidate_inferior_data): Update.
9547 (read_known_tasks_array): Return bool.
9548 (read_known_tasks_list): Likewise.
9549 (read_known_tasks): Return void.
9550 (ada_build_task_list): Now static.
9551
70cd633e
AB
95522019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9553
9554 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9555 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9556
040b3e95
PW
95572019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9558
9559 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9560 variant for ada_tasks_pspace_data_handle and
9561 ada_tasks_inferior_data_handle.
9562 (ada_tasks_pspace_data_cleanup): New function.
9563 (ada_tasks_inferior_data_cleanup): New function.
9564
9409233b
TT
95652019-02-17 Tom Tromey <tom@tromey.com>
9566
9567 * macrotab.h (macro_source_fullname): Return a std::string.
9568 * macrotab.c (macro_include, check_for_redefinition)
9569 (macro_undef, macro_lookup_definition, foreach_macro)
9570 (foreach_macro_in_scope): Update.
9571 (macro_source_fullname): Return a std::string.
9572 * macrocmd.c (show_pp_source_pos): Update.
9573
6506371f
TT
95742019-02-17 Tom Tromey <tom@tromey.com>
9575
9576 * macrocmd.c (show_pp_source_pos): Style the file names.
9577
0c820d67
TT
95782019-02-17 Tom Tromey <tom@tromey.com>
9579
9580 PR tui/24197:
9581 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9582
a0087920
TT
95832019-02-17 Tom Tromey <tom@tromey.com>
9584
9585 * ada-lang.c (user_select_syms): Use filtered printing.
9586 * utils.c (wrap_style): New global.
9587 (desired_style): Remove.
9588 (emit_style_escape): Add stream parameter.
9589 (set_output_style, reset_terminal_style, prompt_for_continue):
9590 Update.
9591 (flush_wrap_buffer): Only flush gdb_stdout.
9592 (wrap_here): Set wrap_style.
9593 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9594 treat escape sequences as a character. Change when wrap buffer is
9595 flushed.
9596 (fputs_styled): Do not set the output style when the default is
9597 requested.
9598 * ui-style.h (struct ui_file_style) <is_default>: New method.
9599 * source.c (print_source_lines_base): Emit escape sequences in one
9600 piece.
9601
75ba10dc
JB
96022019-02-17 Joel Brobecker <brobecker@adacore.com>
9603
9604 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9605 integers and enumeration types.
9606
a2cd4f14
JB
96072019-02-17 Joel Brobecker <brobecker@adacore.com>
9608
9609 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9610 instead of lookup_symbol_in_language
9611 (do_exact_match): New function.
9612 (ada_get_symbol_name_matcher): Return do_exact_match when
9613 doing a verbatim match.
9614
485b851b
TT
96152019-02-15 Tom Tromey <tromey@adacore.com>
9616
9617 * ravenscar-thread.c (ravenscar_thread_target::resume)
9618 (ravenscar_thread_target::wait): Special case wildcard requests.
9619
0b790b1e
TT
96202019-02-15 Tom Tromey <tromey@adacore.com>
9621
9622 * ravenscar-thread.c (base_ptid): Remove.
9623 (struct ravenscar_thread_target) <close>: New method.
9624 <m_base_ptid>: New member.
9625 <update_inferior_ptid, active_task, task_is_currently_active,
9626 runtime_initialized>: Declare methods.
9627 <ravenscar_thread_target>: Add constructor.
9628 (ravenscar_thread_target::task_is_currently_active)
9629 (ravenscar_thread_target::update_inferior_ptid)
9630 (ravenscar_runtime_initialized): Rename. Now methods.
9631 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9632 (ravenscar_thread_target::update_thread_list): Update.
9633 (ravenscar_thread_target::active_task): Now method.
9634 (ravenscar_thread_target::store_registers)
9635 (ravenscar_thread_target::prepare_to_store)
9636 (ravenscar_thread_target::prepare_to_store)
9637 (ravenscar_thread_target::mourn_inferior): Update.
9638 (ravenscar_inferior_created): Use "new" to create target.
9639 (ravenscar_thread_target::get_ada_task_ptid): Update.
9640 (_initialize_ravenscar): Don't initialize base_ptid.
9641 (ravenscar_ops): Remove global.
9642
dea57a62
TT
96432019-02-15 Tom Tromey <tromey@adacore.com>
9644
9645 * target.h (push_target): Declare new overload.
9646 * target.c (push_target): New overload, taking an rvalue reference.
9647 * remote.c (remote_target::open_1): Use push_target overload.
9648 * corelow.c (core_target_open): Use push_target overload.
9649
989f3c58
TT
96502019-02-15 Tom Tromey <tromey@adacore.com>
9651
9652 * ravenscar-thread.c (is_ravenscar_task)
9653 (ravenscar_task_is_currently_active): Return bool.
9654 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9655 (_initialize_ravenscar): Remove "(void)".
9656 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9657 Return bool.
9658
6cbcc006
TT
96592019-02-15 Tom Tromey <tromey@adacore.com>
9660
9661 * ravenscar-thread.c (ravenscar_runtime_initializer)
9662 (has_ravenscar_runtime, get_running_thread_id)
9663 (ravenscar_thread_target::resume): Fix indentation.
9664
7657f14d
TT
96652019-02-15 Tom Tromey <tromey@adacore.com>
9666
9667 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9668 from ravenscar_arch_ops.
9669 (sparc_ravenscar_ops::fetch_registers)
9670 (sparc_ravenscar_ops::store_registers): Now methods.
9671 (sparc_ravenscar_prepare_to_store): Remove.
9672 (sparc_ravenscar_ops): Redefine.
9673 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9674 methods and destructor. Remove members.
9675 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9676 (ravenscar_thread_target::store_registers)
9677 (ravenscar_thread_target::prepare_to_store): Update.
9678 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9679 Remove.
9680 (struct ppc_ravenscar_powerpc_ops): Derive from
9681 ravenscar_arch_ops.
9682 (ppc_ravenscar_powerpc_ops::fetch_registers)
9683 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9684 (ppc_ravenscar_powerpc_ops): Redefine.
9685 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9686 (ppc_ravenscar_e500_ops::fetch_registers)
9687 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9688 (ppc_ravenscar_e500_ops): Redefine.
9689 * aarch64-ravenscar-thread.c
9690 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9691 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9692 (aarch64_ravenscar_fetch_registers)
9693 (aarch64_ravenscar_store_registers): Now methods.
9694 (aarch64_ravenscar_ops): Redefine.
9695
5b6ea500
TT
96962019-02-15 Tom Tromey <tromey@adacore.com>
9697
9698 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9699 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9700 (ravenscar_thread_target::stopped_by_watchpoint)
9701 (ravenscar_thread_target::stopped_data_address)
9702 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9703
e397fd39
TT
97042019-02-15 Tom Tromey <tromey@adacore.com>
9705
9706 * ravenscar-thread.c: Fix some typos.
9707
cc12f4a8
TT
97082019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9709 Tom Tromey <tromey@adacore.com>
9710
9711 * ada-lang.c (ada_exception_sal): Change addr_string to a
9712 std::string.
9713 (create_ada_exception_catchpoint): Update.
9714
5f486660
TT
97152019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9716 Tom Tromey <tromey@adacore.com>
9717
9718 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9719 (bp_location_ops): Remove.
9720 (base_breakpoint_allocate_location): Update.
9721 (free_bp_location): Update.
9722 * ada-lang.c (class ada_catchpoint_location)
9723 <ada_catchpoint_location>: Remove ops parameter.
9724 (ada_catchpoint_location_dtor): Remove.
9725 (ada_catchpoint_location_ops): Remove.
9726 (allocate_location_exception): Update.
9727 * breakpoint.h (struct bp_location_ops): Remove.
9728 (class bp_location) <bp_location>: Remove bp_location_ops
9729 parameter.
9730 <~bp_location>: Add destructor.
9731 <ops>: Remove.
9732
b671c7fb
TS
97332019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9734 Pedro Alves <palves@redhat.com>
9735
9736 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9737 'PATH_MAX'.
9738
8071c5ce
DM
97392019-02-14 David Michael <fedora.dm0@gmail.com>
9740 Samuel Thibault <samuel.thibault@gnu.org>
9741 Thomas Schwinge <thomas@codesourcery.com>
9742
9743 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9744 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9745
b1041ae0
TS
97462019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9747
924514e1
TS
9748 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9749 (check_empty): Use "const char *".
9750
c29ee8d4
TS
9751 * gnu-nat.c (gnu_nat_target::detach): Instead of
9752 'detach_inferior (pid)' call
9753 'detach_inferior (find_inferior_pid (pid))'.
9754
6c6ef69f
TS
9755 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9756 'nat/fork-inferior.o'.
9757 * gnu-nat.c: #include "nat/fork-inferior.h".
9758
2d0a338c
TS
9759 * gnu-nat.c (gnu_nat_target::detach): Instead of
9760 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9761 * gnu-nat.h: #include "inf-child.h".
9762 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9763 'i386_gnu_nat_target::fetch_registers'.
9764 (gnu_store_registers): Rename/move to
9765 'i386_gnu_nat_target::store_registers'.
9766
cabb5f06
TS
9767 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9768 * gnu-nat.h (mach_thread_info): New function.
9769 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9770
b1041ae0
TS
9771 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9772
2988d01e
KF
97732019-02-14 Frederic Konrad <konrad@adacore.com>
9774
9775 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9776
c559d709
JB
97772019-02-14 Joel Brobecker <brobecker@adacore.com>
9778
9779 * windows-nat.c (windows_add_thread): Add new parameter
9780 "main_thread_p" with default value set to false. Update
9781 function documentation as well as all callers.
9782 (windows_delete_thread): Likewise.
9783 (fake_create_process): Update call to windows_add_thread.
9784 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9785 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9786 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9787 call to windows_delete_thread.
9788
007024cc
SM
97892019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9790
9791 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9792
f62318e9
JB
97932019-02-12 John Baldwin <jhb@FreeBSD.org>
9794
9795 * symfile.c (find_separate_debug_file): Use canonical path of
9796 sysroot with child_path instead of gdb_sysroot if it is valid.
9797
cd4b7848
JB
97982019-02-12 John Baldwin <jhb@FreeBSD.org>
9799
9800 * symfile.c (find_separate_debug_file): Use child_path to
9801 determine if an object file is under a sysroot.
9802
efac4bfe
JB
98032019-02-12 John Baldwin <jhb@FreeBSD.org>
9804
9805 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9806 unittests/child-path-selftests.c.
9807 * common/pathstuff.c (child_path): New function.
9808 * common/pathstuff.h (child_path): New prototype.
9809 * unittests/child-path-selftests.c: New file.
9810
402d2bfe
JB
98112019-02-12 John Baldwin <jhb@FreeBSD.org>
9812
9813 * symfile.c (find_separate_debug_file): Look for separate debug
9814 files in debug directories under the sysroot.
9815
1ed9f74e
PW
98162019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9817
9818 * symtab.h (struct minimal_symbol data_p): New const method.
9819 (struct minimal_symbol text_p): Likewise.
9820 * symtab.c (output_source_filename): Use file name style
9821 to print file name.
9822 (print_symbol_info): Likewise.
9823 (print_msymbol_info): Use address style to print addresses.
9824 Use function name style to print executable text symbols.
9825 (expand_symtab_containing_pc): Use data_p.
9826 (find_pc_sect_compunit_symtab): Likewise.
9827
2636d81d
PW
98282019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9829
9830 * breakpoint.c (describe_other_breakpoints): Use address style
9831 to print addresses.
9832 (say_where): Likewise.
9833
ac8c53cc
PW
98342019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9835
9836 * ada-typeprint.c (print_func_type): Print function name
9837 style to print function name.
9838 * c-typeprint.c (c_print_type_1): Likewise.
9839
ea638c43
AH
98402019-02-11 Alan Hayward <alan.hayward@arm.com>
9841
9842 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9843 for execve.
9844
ab759ca8
PW
98452019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9846
9847 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9848 type_stack.
9849
aff29d1c
JB
98502019-02-10 Joel Brobecker <brobecker@adacore.com>
9851
9852 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9853 TYPE_CODE_REF types.
9854
617126bc
JW
98552019-02-08 Jim Wilson <jimw@sifive.com>
9856
9857 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9858 (riscv_linux_fregset): New.
9859 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9860
46e3ed7f
TT
98612019-02-07 Tom Tromey <tom@tromey.com>
9862
9863 * thread.c (thread_cancel_execution_command): Update.
9864 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9865 methods.
9866 (struct thread_fsm_ops): Remove.
9867 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9868 (thread_fsm_should_stop, thread_fsm_return_value)
9869 (thread_fsm_set_finished, thread_fsm_finished_p)
9870 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9871 Don't declare.
9872 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9873 * infrun.c (clear_proceed_status_thread)
9874 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9875 (print_stop_event): Update.
9876 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9877 Add constructor.
9878 (step_command_fsm_ops): Remove.
9879 (new_step_command_fsm): Remove.
9880 (step_1): Update.
9881 (step_command_fsm::should_stop): Rename from
9882 step_command_fsm_should_stop.
9883 (step_command_fsm::clean_up): Rename from
9884 step_command_fsm_clean_up.
9885 (step_command_fsm::do_async_reply_reason): Rename from
9886 step_command_fsm_async_reply_reason.
9887 (struct until_next_fsm): Inherit from thread_fsm. Add
9888 constructor.
9889 (until_next_fsm_ops): Remove.
9890 (new_until_next_fsm): Remove.
9891 (until_next_fsm::should_stop): Rename from
9892 until_next_fsm_should_stop.
9893 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9894 (until_next_fsm::do_async_reply_reason): Rename from
9895 until_next_fsm_async_reply_reason.
9896 (struct finish_command_fsm): Inherit from thread_fsm. Add
9897 constructor. Change type of breakpoint.
9898 (finish_command_fsm_ops): Remove.
9899 (new_finish_command_fsm): Remove.
9900 (finish_command_fsm::should_stop): Rename from
9901 finish_command_fsm_should_stop.
9902 (finish_command_fsm::clean_up): Rename from
9903 finish_command_fsm_clean_up.
9904 (finish_command_fsm::return_value): Rename from
9905 finish_command_fsm_return_value.
9906 (finish_command_fsm::do_async_reply_reason): Rename from
9907 finish_command_fsm_async_reply_reason.
9908 (finish_command): Update.
9909 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9910 Add constructor.
9911 (call_thread_fsm_ops): Remove.
9912 (call_thread_fsm::call_thread_fsm): Rename from
9913 new_call_thread_fsm.
9914 (call_thread_fsm::should_stop): Rename from
9915 call_thread_fsm_should_stop.
9916 (call_thread_fsm::should_notify_stop): Rename from
9917 call_thread_fsm_should_notify_stop.
9918 (run_inferior_call, call_function_by_hand_dummy): Update.
9919 * cli/cli-interp.c (should_print_stop_to_console): Update.
9920 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9921 Add constructor. Change type of location_breakpoint,
9922 caller_breakpoint.
9923 (until_break_fsm_ops): Remove.
9924 (new_until_break_fsm): Remove.
9925 (until_break_fsm::should_stop): Rename from
9926 until_break_fsm_should_stop.
9927 (until_break_fsm::clean_up): Rename from
9928 until_break_fsm_clean_up.
9929 (until_break_fsm::do_async_reply_reason): Rename from
9930 until_break_fsm_async_reply_reason.
9931 (until_break_command): Update.
9932 * thread-fsm.c: Remove.
9933 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9934
1a5c2598
TT
99352019-02-07 Tom Tromey <tom@tromey.com>
9936
9937 * yy-remap.h: Add include guard.
9938 * xtensa-tdep.h: Add include guard.
9939 * xcoffread.h: Rename include guard.
9940 * varobj-iter.h: Add include guard.
9941 * tui/tui.h: Rename include guard.
9942 * tui/tui-winsource.h: Rename include guard.
9943 * tui/tui-wingeneral.h: Rename include guard.
9944 * tui/tui-windata.h: Rename include guard.
9945 * tui/tui-win.h: Rename include guard.
9946 * tui/tui-stack.h: Rename include guard.
9947 * tui/tui-source.h: Rename include guard.
9948 * tui/tui-regs.h: Rename include guard.
9949 * tui/tui-out.h: Rename include guard.
9950 * tui/tui-layout.h: Rename include guard.
9951 * tui/tui-io.h: Rename include guard.
9952 * tui/tui-hooks.h: Rename include guard.
9953 * tui/tui-file.h: Rename include guard.
9954 * tui/tui-disasm.h: Rename include guard.
9955 * tui/tui-data.h: Rename include guard.
9956 * tui/tui-command.h: Rename include guard.
9957 * tic6x-tdep.h: Add include guard.
9958 * target/waitstatus.h: Rename include guard.
9959 * target/wait.h: Rename include guard.
9960 * target/target.h: Rename include guard.
9961 * target/resume.h: Rename include guard.
9962 * target-float.h: Rename include guard.
9963 * stabsread.h: Add include guard.
9964 * rs6000-tdep.h: Add include guard.
9965 * riscv-fbsd-tdep.h: Add include guard.
9966 * regformats/regdef.h: Rename include guard.
9967 * record.h: Rename include guard.
9968 * python/python.h: Rename include guard.
9969 * python/python-internal.h: Rename include guard.
9970 * python/py-stopevent.h: Rename include guard.
9971 * python/py-ref.h: Rename include guard.
9972 * python/py-record.h: Rename include guard.
9973 * python/py-record-full.h: Rename include guard.
9974 * python/py-record-btrace.h: Rename include guard.
9975 * python/py-instruction.h: Rename include guard.
9976 * python/py-events.h: Rename include guard.
9977 * python/py-event.h: Rename include guard.
9978 * procfs.h: Add include guard.
9979 * proc-utils.h: Add include guard.
9980 * p-lang.h: Add include guard.
9981 * or1k-tdep.h: Rename include guard.
9982 * observable.h: Rename include guard.
9983 * nto-tdep.h: Rename include guard.
9984 * nat/x86-linux.h: Rename include guard.
9985 * nat/x86-linux-dregs.h: Rename include guard.
9986 * nat/x86-gcc-cpuid.h: Add include guard.
9987 * nat/x86-dregs.h: Rename include guard.
9988 * nat/x86-cpuid.h: Rename include guard.
9989 * nat/ppc-linux.h: Rename include guard.
9990 * nat/mips-linux-watch.h: Rename include guard.
9991 * nat/linux-waitpid.h: Rename include guard.
9992 * nat/linux-ptrace.h: Rename include guard.
9993 * nat/linux-procfs.h: Rename include guard.
9994 * nat/linux-osdata.h: Rename include guard.
9995 * nat/linux-nat.h: Rename include guard.
9996 * nat/linux-namespaces.h: Rename include guard.
9997 * nat/linux-btrace.h: Rename include guard.
9998 * nat/glibc_thread_db.h: Rename include guard.
9999 * nat/gdb_thread_db.h: Rename include guard.
10000 * nat/gdb_ptrace.h: Rename include guard.
10001 * nat/fork-inferior.h: Rename include guard.
10002 * nat/amd64-linux-siginfo.h: Rename include guard.
10003 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10004 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10005 * nat/aarch64-linux.h: Rename include guard.
10006 * nat/aarch64-linux-hw-point.h: Rename include guard.
10007 * mn10300-tdep.h: Add include guard.
10008 * mips-linux-tdep.h: Add include guard.
10009 * mi/mi-parse.h: Rename include guard.
10010 * mi/mi-out.h: Rename include guard.
10011 * mi/mi-main.h: Rename include guard.
10012 * mi/mi-interp.h: Rename include guard.
10013 * mi/mi-getopt.h: Rename include guard.
10014 * mi/mi-console.h: Rename include guard.
10015 * mi/mi-common.h: Rename include guard.
10016 * mi/mi-cmds.h: Rename include guard.
10017 * mi/mi-cmd-break.h: Rename include guard.
10018 * m2-lang.h: Add include guard.
10019 * location.h: Rename include guard.
10020 * linux-record.h: Rename include guard.
10021 * linux-nat.h: Add include guard.
10022 * linux-fork.h: Add include guard.
10023 * i386-darwin-tdep.h: Rename include guard.
10024 * hppa-linux-offsets.h: Add include guard.
10025 * guile/guile.h: Rename include guard.
10026 * guile/guile-internal.h: Rename include guard.
10027 * gnu-nat.h: Rename include guard.
10028 * gdb-stabs.h: Rename include guard.
10029 * frv-tdep.h: Add include guard.
10030 * f-lang.h: Add include guard.
10031 * event-loop.h: Add include guard.
10032 * darwin-nat.h: Rename include guard.
10033 * cp-abi.h: Rename include guard.
10034 * config/sparc/nm-sol2.h: Rename include guard.
10035 * config/nm-nto.h: Rename include guard.
10036 * config/nm-linux.h: Add include guard.
10037 * config/i386/nm-i386gnu.h: Rename include guard.
10038 * config/djgpp/nl_types.h: Rename include guard.
10039 * config/djgpp/langinfo.h: Rename include guard.
10040 * compile/gcc-cp-plugin.h: Add include guard.
10041 * compile/gcc-c-plugin.h: Add include guard.
10042 * compile/compile.h: Rename include guard.
10043 * compile/compile-object-run.h: Rename include guard.
10044 * compile/compile-object-load.h: Rename include guard.
10045 * compile/compile-internal.h: Rename include guard.
10046 * compile/compile-cplus.h: Rename include guard.
10047 * compile/compile-c.h: Rename include guard.
10048 * common/xml-utils.h: Rename include guard.
10049 * common/x86-xstate.h: Rename include guard.
10050 * common/version.h: Rename include guard.
10051 * common/vec.h: Rename include guard.
10052 * common/tdesc.h: Rename include guard.
10053 * common/selftest.h: Rename include guard.
10054 * common/scoped_restore.h: Rename include guard.
10055 * common/scoped_mmap.h: Rename include guard.
10056 * common/scoped_fd.h: Rename include guard.
10057 * common/safe-iterator.h: Rename include guard.
10058 * common/run-time-clock.h: Rename include guard.
10059 * common/refcounted-object.h: Rename include guard.
10060 * common/queue.h: Rename include guard.
10061 * common/ptid.h: Rename include guard.
10062 * common/print-utils.h: Rename include guard.
10063 * common/preprocessor.h: Rename include guard.
10064 * common/pathstuff.h: Rename include guard.
10065 * common/observable.h: Rename include guard.
10066 * common/netstuff.h: Rename include guard.
10067 * common/job-control.h: Rename include guard.
10068 * common/host-defs.h: Rename include guard.
10069 * common/gdb_wait.h: Rename include guard.
10070 * common/gdb_vecs.h: Rename include guard.
10071 * common/gdb_unlinker.h: Rename include guard.
10072 * common/gdb_unique_ptr.h: Rename include guard.
10073 * common/gdb_tilde_expand.h: Rename include guard.
10074 * common/gdb_sys_time.h: Rename include guard.
10075 * common/gdb_string_view.h: Rename include guard.
10076 * common/gdb_splay_tree.h: Rename include guard.
10077 * common/gdb_setjmp.h: Rename include guard.
10078 * common/gdb_ref_ptr.h: Rename include guard.
10079 * common/gdb_optional.h: Rename include guard.
10080 * common/gdb_locale.h: Rename include guard.
10081 * common/gdb_assert.h: Rename include guard.
10082 * common/filtered-iterator.h: Rename include guard.
10083 * common/filestuff.h: Rename include guard.
10084 * common/fileio.h: Rename include guard.
10085 * common/environ.h: Rename include guard.
10086 * common/common-utils.h: Rename include guard.
10087 * common/common-types.h: Rename include guard.
10088 * common/common-regcache.h: Rename include guard.
10089 * common/common-inferior.h: Rename include guard.
10090 * common/common-gdbthread.h: Rename include guard.
10091 * common/common-exceptions.h: Rename include guard.
10092 * common/common-defs.h: Rename include guard.
10093 * common/common-debug.h: Rename include guard.
10094 * common/cleanups.h: Rename include guard.
10095 * common/buffer.h: Rename include guard.
10096 * common/btrace-common.h: Rename include guard.
10097 * common/break-common.h: Rename include guard.
10098 * cli/cli-utils.h: Rename include guard.
10099 * cli/cli-style.h: Rename include guard.
10100 * cli/cli-setshow.h: Rename include guard.
10101 * cli/cli-script.h: Rename include guard.
10102 * cli/cli-interp.h: Rename include guard.
10103 * cli/cli-decode.h: Rename include guard.
10104 * cli/cli-cmds.h: Rename include guard.
10105 * charset-list.h: Add include guard.
10106 * buildsym-legacy.h: Rename include guard.
10107 * bfin-tdep.h: Add include guard.
10108 * ax.h: Rename include guard.
10109 * arm-linux-tdep.h: Add include guard.
10110 * arm-fbsd-tdep.h: Add include guard.
10111 * arch/xtensa.h: Rename include guard.
10112 * arch/tic6x.h: Add include guard.
10113 * arch/i386.h: Add include guard.
10114 * arch/arm.h: Rename include guard.
10115 * arch/arm-linux.h: Rename include guard.
10116 * arch/arm-get-next-pcs.h: Rename include guard.
10117 * arch/amd64.h: Add include guard.
10118 * arch/aarch64-insn.h: Rename include guard.
10119 * arch-utils.h: Rename include guard.
10120 * annotate.h: Add include guard.
10121 * amd64-darwin-tdep.h: Rename include guard.
10122 * aarch64-linux-tdep.h: Add include guard.
10123 * aarch64-fbsd-tdep.h: Add include guard.
10124 * aarch32-linux-nat.h: Add include guard.
10125
ab9268d2
PW
101262019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10127
10128 * macrotab.c (macro_define_internal): New function that
10129 factorizes macro_define_object_internal and macro_define_function
10130 code.
10131 (macro_define_object_internal): Use macro_define_internal.
10132 (macro_define_function): Likewise.
10133
bb0da2b4
PW
101342019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10135
10136 * macrocmd.c (extract_identifier): Return
10137 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10138 callers.
10139
424eb552
JB
101402019-02-06 John Baldwin <jhb@FreeBSD.org>
10141
10142 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10143
1688cb29
TT
101442019-02-05 Tom Tromey <tom@tromey.com>
10145
10146 * target.c (target_stack::unpush): Move assertion earlier.
10147
b5eba2d8
TT
101482019-01-30 Tom Tromey <tom@tromey.com>
10149
10150 PR python/23615:
10151 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10152 (gdbpy_parse_and_eval): Likewise.
10153 * python/python-internal.h (gdbpy_allow_threads): New class.
10154
7054e2ff
JB
101552019-01-28 John Baldwin <jhb@FreeBSD.org>
10156
10157 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10158 (aarch64_fbsd_fpregmap): Move earlier.
10159 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10160 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10161 instead of individual calls to trad_frame_set_reg_addr.
10162 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10163 earlier.
10164 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10165 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10166 instead of individual calls to trad_frame_set_reg_addr.
10167
36c25ffa
AH
101682019-01-28 Alan Hayward <alan.hayward@arm.com>
10169
10170 * CONTRIBUTE: Replace contribution list with wiki link.
10171
a0707f3c
TT
101722019-01-25 Tom Tromey <tom@tromey.com>
10173
10174 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10175
0747795c
TT
101762019-01-25 Tom Tromey <tom@tromey.com>
10177
10178 * xtensa-linux-nat.c: Fix common/ includes.
10179 * xml-support.h: Fix common/ includes.
10180 * xml-support.c: Fix common/ includes.
10181 * x86-linux-nat.c: Fix common/ includes.
10182 * windows-nat.c: Fix common/ includes.
10183 * varobj.h: Fix common/ includes.
10184 * varobj.c: Fix common/ includes.
10185 * value.c: Fix common/ includes.
10186 * valops.c: Fix common/ includes.
10187 * utils.c: Fix common/ includes.
10188 * unittests/xml-utils-selftests.c: Fix common/ includes.
10189 * unittests/utils-selftests.c: Fix common/ includes.
10190 * unittests/unpack-selftests.c: Fix common/ includes.
10191 * unittests/tracepoint-selftests.c: Fix common/ includes.
10192 * unittests/style-selftests.c: Fix common/ includes.
10193 * unittests/string_view-selftests.c: Fix common/ includes.
10194 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10195 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10196 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10197 * unittests/rsp-low-selftests.c: Fix common/ includes.
10198 * unittests/parse-connection-spec-selftests.c: Fix common/
10199 includes.
10200 * unittests/optional-selftests.c: Fix common/ includes.
10201 * unittests/offset-type-selftests.c: Fix common/ includes.
10202 * unittests/observable-selftests.c: Fix common/ includes.
10203 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10204 * unittests/memrange-selftests.c: Fix common/ includes.
10205 * unittests/memory-map-selftests.c: Fix common/ includes.
10206 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10207 * unittests/function-view-selftests.c: Fix common/ includes.
10208 * unittests/environ-selftests.c: Fix common/ includes.
10209 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10210 * unittests/common-utils-selftests.c: Fix common/ includes.
10211 * unittests/cli-utils-selftests.c: Fix common/ includes.
10212 * unittests/array-view-selftests.c: Fix common/ includes.
10213 * ui-file.c: Fix common/ includes.
10214 * tui/tui-io.c: Fix common/ includes.
10215 * tracepoint.h: Fix common/ includes.
10216 * tracepoint.c: Fix common/ includes.
10217 * tracefile-tfile.c: Fix common/ includes.
10218 * top.h: Fix common/ includes.
10219 * top.c: Fix common/ includes.
10220 * thread.c: Fix common/ includes.
10221 * target/waitstatus.h: Fix common/ includes.
10222 * target/waitstatus.c: Fix common/ includes.
10223 * target.h: Fix common/ includes.
10224 * target.c: Fix common/ includes.
10225 * target-memory.c: Fix common/ includes.
10226 * target-descriptions.c: Fix common/ includes.
10227 * symtab.h: Fix common/ includes.
10228 * symfile.c: Fix common/ includes.
10229 * stap-probe.c: Fix common/ includes.
10230 * spu-linux-nat.c: Fix common/ includes.
10231 * sparc-nat.c: Fix common/ includes.
10232 * source.c: Fix common/ includes.
10233 * solib.c: Fix common/ includes.
10234 * solib-target.c: Fix common/ includes.
10235 * ser-unix.c: Fix common/ includes.
10236 * ser-tcp.c: Fix common/ includes.
10237 * ser-pipe.c: Fix common/ includes.
10238 * ser-base.c: Fix common/ includes.
10239 * selftest-arch.c: Fix common/ includes.
10240 * s12z-tdep.c: Fix common/ includes.
10241 * rust-exp.y: Fix common/ includes.
10242 * rs6000-aix-tdep.c: Fix common/ includes.
10243 * riscv-tdep.c: Fix common/ includes.
10244 * remote.c: Fix common/ includes.
10245 * remote-notif.h: Fix common/ includes.
10246 * remote-fileio.h: Fix common/ includes.
10247 * remote-fileio.c: Fix common/ includes.
10248 * regcache.h: Fix common/ includes.
10249 * regcache.c: Fix common/ includes.
10250 * record-btrace.c: Fix common/ includes.
10251 * python/python.c: Fix common/ includes.
10252 * python/py-type.c: Fix common/ includes.
10253 * python/py-inferior.c: Fix common/ includes.
10254 * progspace.h: Fix common/ includes.
10255 * producer.c: Fix common/ includes.
10256 * procfs.c: Fix common/ includes.
10257 * proc-api.c: Fix common/ includes.
10258 * printcmd.c: Fix common/ includes.
10259 * ppc-linux-nat.c: Fix common/ includes.
10260 * parser-defs.h: Fix common/ includes.
10261 * osdata.c: Fix common/ includes.
10262 * obsd-nat.c: Fix common/ includes.
10263 * nat/x86-linux.c: Fix common/ includes.
10264 * nat/x86-linux-dregs.c: Fix common/ includes.
10265 * nat/x86-dregs.h: Fix common/ includes.
10266 * nat/x86-dregs.c: Fix common/ includes.
10267 * nat/ppc-linux.c: Fix common/ includes.
10268 * nat/mips-linux-watch.h: Fix common/ includes.
10269 * nat/mips-linux-watch.c: Fix common/ includes.
10270 * nat/linux-waitpid.c: Fix common/ includes.
10271 * nat/linux-ptrace.h: Fix common/ includes.
10272 * nat/linux-ptrace.c: Fix common/ includes.
10273 * nat/linux-procfs.c: Fix common/ includes.
10274 * nat/linux-personality.c: Fix common/ includes.
10275 * nat/linux-osdata.c: Fix common/ includes.
10276 * nat/linux-namespaces.c: Fix common/ includes.
10277 * nat/linux-btrace.h: Fix common/ includes.
10278 * nat/linux-btrace.c: Fix common/ includes.
10279 * nat/fork-inferior.c: Fix common/ includes.
10280 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10281 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10282 * nat/aarch64-linux.c: Fix common/ includes.
10283 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10284 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10285 * namespace.h: Fix common/ includes.
10286 * mips-linux-tdep.c: Fix common/ includes.
10287 * minsyms.c: Fix common/ includes.
10288 * mi/mi-parse.h: Fix common/ includes.
10289 * mi/mi-main.c: Fix common/ includes.
10290 * mi/mi-cmd-env.c: Fix common/ includes.
10291 * memrange.h: Fix common/ includes.
10292 * memattr.c: Fix common/ includes.
10293 * maint.h: Fix common/ includes.
10294 * maint.c: Fix common/ includes.
10295 * main.c: Fix common/ includes.
10296 * machoread.c: Fix common/ includes.
10297 * location.c: Fix common/ includes.
10298 * linux-thread-db.c: Fix common/ includes.
10299 * linux-nat.c: Fix common/ includes.
10300 * linux-fork.c: Fix common/ includes.
10301 * inline-frame.c: Fix common/ includes.
10302 * infrun.c: Fix common/ includes.
10303 * inflow.c: Fix common/ includes.
10304 * inferior.h: Fix common/ includes.
10305 * inferior.c: Fix common/ includes.
10306 * infcmd.c: Fix common/ includes.
10307 * inf-ptrace.c: Fix common/ includes.
10308 * inf-child.c: Fix common/ includes.
10309 * ia64-linux-nat.c: Fix common/ includes.
10310 * i387-tdep.c: Fix common/ includes.
10311 * i386-tdep.c: Fix common/ includes.
10312 * i386-linux-tdep.c: Fix common/ includes.
10313 * i386-linux-nat.c: Fix common/ includes.
10314 * i386-go32-tdep.c: Fix common/ includes.
10315 * i386-fbsd-tdep.c: Fix common/ includes.
10316 * i386-fbsd-nat.c: Fix common/ includes.
10317 * guile/scm-type.c: Fix common/ includes.
10318 * guile/guile.c: Fix common/ includes.
10319 * go32-nat.c: Fix common/ includes.
10320 * gnu-nat.c: Fix common/ includes.
10321 * gdbthread.h: Fix common/ includes.
10322 * gdbarch-selftests.c: Fix common/ includes.
10323 * gdb_usleep.c: Fix common/ includes.
10324 * gdb_select.h: Fix common/ includes.
10325 * gdb_bfd.c: Fix common/ includes.
10326 * gcore.c: Fix common/ includes.
10327 * fork-child.c: Fix common/ includes.
10328 * findvar.c: Fix common/ includes.
10329 * fbsd-nat.c: Fix common/ includes.
10330 * event-top.c: Fix common/ includes.
10331 * event-loop.c: Fix common/ includes.
10332 * dwarf2read.c: Fix common/ includes.
10333 * dwarf2loc.c: Fix common/ includes.
10334 * dwarf2-frame.c: Fix common/ includes.
10335 * dwarf-index-cache.c: Fix common/ includes.
10336 * dtrace-probe.c: Fix common/ includes.
10337 * disasm-selftests.c: Fix common/ includes.
10338 * defs.h: Fix common/ includes.
10339 * csky-tdep.c: Fix common/ includes.
10340 * cp-valprint.c: Fix common/ includes.
10341 * cp-support.h: Fix common/ includes.
10342 * cp-support.c: Fix common/ includes.
10343 * corelow.c: Fix common/ includes.
10344 * completer.h: Fix common/ includes.
10345 * completer.c: Fix common/ includes.
10346 * compile/compile.c: Fix common/ includes.
10347 * compile/compile-loc2c.c: Fix common/ includes.
10348 * compile/compile-cplus-types.c: Fix common/ includes.
10349 * compile/compile-cplus-symbols.c: Fix common/ includes.
10350 * command.h: Fix common/ includes.
10351 * cli/cli-dump.c: Fix common/ includes.
10352 * cli/cli-cmds.c: Fix common/ includes.
10353 * charset.c: Fix common/ includes.
10354 * build-id.c: Fix common/ includes.
10355 * btrace.h: Fix common/ includes.
10356 * btrace.c: Fix common/ includes.
10357 * breakpoint.h: Fix common/ includes.
10358 * breakpoint.c: Fix common/ includes.
10359 * ax.h:
10360 (enum agent_op): Fix common/ includes.
10361 * ax-general.c (struct aop_map): Fix common/ includes.
10362 * ax-gdb.c: Fix common/ includes.
10363 * auxv.c: Fix common/ includes.
10364 * auto-load.c: Fix common/ includes.
10365 * arm-tdep.c: Fix common/ includes.
10366 * arch/riscv.c: Fix common/ includes.
10367 * arch/ppc-linux-common.c: Fix common/ includes.
10368 * arch/i386.c: Fix common/ includes.
10369 * arch/arm.c: Fix common/ includes.
10370 * arch/arm-linux.c: Fix common/ includes.
10371 * arch/arm-get-next-pcs.c: Fix common/ includes.
10372 * arch/amd64.c: Fix common/ includes.
10373 * arch/aarch64.c: Fix common/ includes.
10374 * arch/aarch64-insn.c: Fix common/ includes.
10375 * arch-utils.c: Fix common/ includes.
10376 * amd64-windows-tdep.c: Fix common/ includes.
10377 * amd64-tdep.c: Fix common/ includes.
10378 * amd64-sol2-tdep.c: Fix common/ includes.
10379 * amd64-obsd-tdep.c: Fix common/ includes.
10380 * amd64-nbsd-tdep.c: Fix common/ includes.
10381 * amd64-linux-tdep.c: Fix common/ includes.
10382 * amd64-linux-nat.c: Fix common/ includes.
10383 * amd64-fbsd-tdep.c: Fix common/ includes.
10384 * amd64-fbsd-nat.c: Fix common/ includes.
10385 * amd64-dicos-tdep.c: Fix common/ includes.
10386 * amd64-darwin-tdep.c: Fix common/ includes.
10387 * agent.c: Fix common/ includes.
10388 * ada-lang.h: Fix common/ includes.
10389 * ada-lang.c: Fix common/ includes.
10390 * aarch64-tdep.c: Fix common/ includes.
10391
2f5c153e
TT
103922019-01-25 Tom Tromey <tom@tromey.com>
10393
10394 * common/create-version.sh: Use common/version.h.
10395
adc6a863
PA
103962019-01-24 Pedro Alves <palves@redhat.com>
10397
10398 * infrun.c (signal_stop, signal_print, signal_program)
10399 (signal_catch, signal_pass): Now arrays instead of pointers.
10400 (update_signals_program_target, do_target_resume)
10401 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10402 * linux-nat.c (linux_nat_target::pass_signals)
10403 (linux_nat_target::create_inferior, linux_nat_target::attach):
10404 Adjust.
10405 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10406 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10407 * procfs.c (procfs_target::pass_signals): Adjust.
10408 * record-full.c (record_full_target::resume): Adjust.
10409 * remote.c (remote_target::pass_signals)
10410 (remote_target::program_signals): Adjust.
10411 * target-debug.h (target_debug_print_signals): Now takes a
10412 gdb::array_view as parameter. Adjust.
10413 * target.h (target_ops) <pass_signals, program_signals>: Replace
10414 pointer and length parameters with gdb::array_view.
10415 (target_pass_signals, target_program_signals): Likewise.
10416 * target-delegates.c: Regenerate.
10417
3046d67a
PA
104182019-01-24 Pedro Alves <palves@redhat.com>
10419
10420 * common/forward-scope-exit.h
10421 (forward_scope_exit::forward_scope_exit): Pass arguments to
10422 m_bind_function directly, instead of creating a std::bind and
10423 copying that.
10424
353229bf
AH
104252019-01-24 Alan Hayward <alan.hayward@arm.com>
10426
10427 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10428 for static members.
10429 (pass_in_v_vfp_candidate): Likewise.
10430
311dc83a
TT
104312019-01-23 Tom Tromey <tom@tromey.com>
10432 Pedro Alves <palves@redhat.com>
10433
10434 * regcache.c (class regcache_invalidator): Remove.
10435 (regcache::raw_write): Use make_scope_exit.
10436
296bd123
TT
104372019-01-23 Tom Tromey <tom@tromey.com>
10438
10439 * ui-out.h (class ui_out_emit_type): Update comment.
10440
979a0d13
TT
104412019-01-23 Tom Tromey <tom@tromey.com>
10442
10443 * infrun.c (fetch_inferior_event): Update comment.
10444
d238133d
TT
104452019-01-23 Tom Tromey <tom@tromey.com>
10446 Pedro Alves <palves@redhat.com>
10447
10448 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10449 parameter.
10450 (fetch_inferior_event): Use SCOPE_EXIT.
10451
10452
9885e6bb
TT
104532019-01-23 Tom Tromey <tom@tromey.com>
10454 Pedro Alves <palves@redhat.com>
10455
10456 * infrun.c (disable_thread_events): Delete.
10457 (stop_all_threads): Use SCOPE_EXIT.
10458
286526c1
TT
104592019-01-23 Tom Tromey <tom@tromey.com>
10460 Pedro Alves <palves@redhat.com>
10461
10462 * symfile.c: Include forward-scope-exit.h.
10463 (clear_symtab_users_cleanup): Replace forward declaration with
10464 a FORWARD_SCOPE_EXIT.
10465 (syms_from_objfile_1): Use the forward_scope_exit and
10466 gdb::optional instead of cleanup_function.
10467 (reread_symbols): Use the forward_scope_exit instead of
10468 cleanup_function.
10469 (clear_symtab_users_cleanup): Remove function.
10470
1db93f14
TT
104712019-01-23 Tom Tromey <tom@tromey.com>
10472 Pedro Alves <palves@redhat.com>
10473
10474 * linux-nat.c: Include scope-exit.h.
10475 (cleanup_target_stop): Remove.
10476 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10477 SCOPE_EXIT.
10478
2cc83d1e
TT
104792019-01-23 Tom Tromey <tom@tromey.com>
10480 Pedro Alves <palves@redhat.com>
10481
10482 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10483 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10484
694c6bf5
TT
104852019-01-23 Tom Tromey <tom@tromey.com>
10486 Andrew Burgess <andrew.burgess@embecosm.com>
10487 Pedro Alves <palves@redhat.com>
10488
10489 * infrun.c (fetch_inferior_event): Use scope_exit.
10490 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10491 * top.c (execute_command): Use scope_exit.
10492 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10493 * utils.c (do_bpstat_clear_actions_cleanup)
10494 (make_bpstat_clear_actions_cleanup): Remove.
10495
4c41382a
TT
104962019-01-23 Tom Tromey <tom@tromey.com>
10497 Pedro Alves <palves@redhat.com>
10498
10499 * infrun.c: Include "common/scope-exit.h"
10500 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10501 (wait_for_inferior): Use SCOPE_EXIT.
10502 (fetch_inferior_event): Use scope_exit.
10503
89f8fb50
TT
105042019-01-23 Tom Tromey <tom@tromey.com>
10505 Pedro Alves <palves@redhat.com>
10506
10507 * breakpoint.c (create_breakpoint): Remove cleanup.
10508
5419bdae
TT
105092019-01-23 Tom Tromey <tom@tromey.com>
10510 Andrew Burgess <andrew.burgess@embecosm.com>
10511 Pedro Alves <palves@redhat.com>
10512
e587ef42
PA
105132019-01-23 Pedro Alves <palves@redhat.com>
10514
10515 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10516
77f0e74c
PA
105172019-01-23 Pedro Alves <palves@redhat.com>
10518 Andrew Burgess <andrew.burgess@embecosm.com>
10519
10520 * gdbthread.h: Include "common/forward-scope-exit.h".
10521 (scoped_finish_thread_state): Redefine custom class in terms of
10522 forward_scope_exit.
10523
5b9b3e53
PA
105242019-01-23 Pedro Alves <palves@redhat.com>
10525 Andrew Burgess <andrew.burgess@embecosm.com>
10526
10527 * common/forward-scope-exit.h: New file.
10528
54b65c9b
PA
105292019-01-23 Pedro Alves <palves@redhat.com>
10530 Andrew Burgess <andrew.burgess@embecosm.com>
10531 Tom Tromey <tom@tromey.com>
10532
10533 * common/scope-exit.h: New file.
10534
cf08fb29
PA
105352019-01-23 Pedro Alves <palves@redhat.com>
10536
10537 * common/preprocessor.h (ESC): Rename to ...
10538 (ESC_PARENS): ... this.
10539 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10540 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10541
ae73e2e2
TT
105422019-01-23 Tom Tromey <tom@tromey.com>
10543
10544 * language.h (class scoped_switch_to_sym_language_if_auto):
10545 Initialize m_lang in both cases.
10546
6594e122
AH
105472019-01-23 Alan Hayward <alan.hayward@arm.com>
10548
10549 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10550 with XCNEW.
10551
a7c9855d
TT
105522019-01-22 Tom Tromey <tom@tromey.com>
10553
10554 * corelow.c: Do not include sys/file.h.
10555
93cc1d53
TT
105562019-01-22 Tom Tromey <tom@tromey.com>
10557
10558 * tui/tui-wingeneral.h: Include gdb_curses.h.
10559
38561778
TT
105602019-01-22 Tom Tromey <tom@tromey.com>
10561
10562 * source-cache.h (class source_cache) <get_source_lines,
10563 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10564
37b3ab5b
TT
105652019-01-22 Tom Tromey <tom@tromey.com>
10566
10567 * remote-fileio.h (struct remote_target): Declare.
10568
3fabc016
TT
105692019-01-22 Tom Tromey <tom@tromey.com>
10570
10571 * python/py-arch.c: Do not include py-ref.h.
10572 * python/py-bpevent.c: Do not include py-ref.h.
10573 * python/py-cmd.c: Do not include py-ref.h.
10574 * python/py-continueevent.c: Do not include py-ref.h.
10575 * python/py-event.h: Do not include py-ref.h.
10576 * python/py-evtregistry.c: Do not include py-ref.h.
10577 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10578 * python/py-frame.c: Do not include py-ref.h.
10579 * python/py-framefilter.c: Do not include py-ref.h.
10580 * python/py-function.c: Do not include py-ref.h.
10581 * python/py-infevents.c: Do not include py-ref.h.
10582 * python/py-linetable.c: Do not include py-ref.h.
10583 * python/py-objfile.c: Do not include py-ref.h.
10584 * python/py-param.c: Do not include py-ref.h.
10585 * python/py-prettyprint.c: Do not include py-ref.h.
10586 * python/py-progspace.c: Do not include py-ref.h.
10587 * python/py-symbol.c: Do not include py-ref.h.
10588 * python/py-symtab.c: Do not include py-ref.h.
10589 * python/py-type.c: Do not include py-ref.h.
10590 * python/py-unwind.c: Do not include py-ref.h.
10591 * python/py-utils.c: Do not include py-ref.h.
10592 * python/py-value.c: Do not include py-ref.h.
10593 * python/py-varobj.c: Do not include py-ref.h.
10594 * python/py-xmethods.c: Do not include py-ref.h.
10595 * python/python.c: Do not include py-ref.h.
10596 * varobj.c: Do not include py-ref.h.
10597
6b4d7774
TT
105982019-01-22 Tom Tromey <tom@tromey.com>
10599
10600 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10601 keyword for bcache.
10602
7af7e9b5
TT
106032019-01-22 Tom Tromey <tom@tromey.com>
10604
10605 * compile/compile-cplus-types.c: Remove a comment by #include.
10606
951d1049
TT
106072019-01-22 Tom Tromey <tom@tromey.com>
10608
10609 * compile/gcc-c-plugin.h: Include compile-internal.h.
10610
d65d5705
TT
106112019-01-22 Tom Tromey <tom@tromey.com>
10612
10613 * stabsread.c (EXTERN): Do not define.
10614 (symnum, next_symbol_text_func, processing_gcc_compilation)
10615 (within_function, global_sym_chain, global_stabs)
10616 (previous_stab_code, this_object_header_files)
10617 (n_this_object_header_files)
10618 (n_allocated_this_object_header_files): Define.
10619 * stabsread.h (EXTERN): Never define. Use "extern".
10620
b6fb1ee5
PW
106212019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10622
10623 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10624 history_value.
10625
be6d4f74
TT
106262019-01-21 Tom Tromey <tom@tromey.com>
10627
10628 * ui-out.c: Fix includes.
10629 * tui/tui-source.c: Fix includes.
10630 * target.c: Fix includes.
10631 * remote.c: Fix includes.
10632 * regcache.c: Fix includes.
10633 * python/py-block.c: Fix includes.
10634 * printcmd.c: Fix includes.
10635 * or1k-tdep.c: Fix includes.
10636 * mi/mi-main.c: Fix includes.
10637 * m32r-tdep.c: Fix includes.
10638 * csky-tdep.c: Fix includes.
10639 * compile/compile-cplus-types.c: Fix includes.
10640 * cli/cli-interp.c: Fix includes.
10641
73021deb
AH
106422019-01-21 Alan Hayward <alan.hayward@arm.com>
10643
10644 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10645 for padding.
10646
7932255d
TT
106472019-01-16 Tom Tromey <tom@tromey.com>
10648
10649 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10650 earlier.
10651 (struct objfile) <msymbols_range>: Move from top level.
10652 <msymbols>: New method.
10653 (class objfile_msymbols): Remove.
10654 * symtab.c (default_collect_symbol_completion_matches_break_on):
10655 Update.
10656 * symmisc.c (dump_msymbols): Update.
10657 * stabsread.c (scan_file_globals): Update.
10658 * objc-lang.c (info_selectors_command, info_classes_command)
10659 (find_methods): Update.
10660 * minsyms.c (find_solib_trampoline_target): Update.
10661 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10662 * coffread.c (coff_symfile_read): Update.
10663 * ada-lang.c (ada_lookup_simple_minsym)
10664 (ada_collect_symbol_completion_matches): Update.
10665
604b1bfb
TT
106662019-01-16 Tom Tromey <tom@tromey.com>
10667
10668 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10669 type. Remove no-argument constructor.
10670 <iterator::operator++>: Simplify.
10671 <begin>: Update.
10672 <end>: Use minimal_symbol_count.
10673
f252c6d5
TT
106742019-01-16 Tom Tromey <tom@tromey.com>
10675
10676 * objfiles.h (struct objfile) <psymtabs>: New method.
10677 (class objfile_psymtabs): Remove.
10678 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10679 typedef.
10680 <range>: New method.
10681 (require_partial_symbols): Change return type.
10682 * psymtab.c (require_partial_symbols)
10683 (psym_expand_symtabs_matching): Update.
10684 * mdebugread.c (parse_partial_symbols): Update.
10685 * dbxread.c (dbx_end_psymtab): Update.
10686
b669c953
TT
106872019-01-15 Tom Tromey <tom@tromey.com>
10688
10689 * symtab.c (lookup_objfile_from_block)
10690 (lookup_symbol_in_objfile_symtabs)
10691 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10692 (find_line_symtab, info_sources_command)
10693 (default_collect_symbol_completion_matches_break_on)
10694 (make_source_files_completion_list): Update.
10695 * symmisc.c (print_objfile_statistics, dump_objfile)
10696 (maintenance_print_symbols, maintenance_info_symtabs)
10697 (maintenance_check_symtabs, maintenance_info_line_tables):
10698 Update.
10699 * source.c (select_source_symtab)
10700 (forget_cached_source_info_for_objfile): Update.
10701 * objfiles.h (class objfile_compunits): Remove.
10702 (struct objfile) <compunits_range>: New typedef.
10703 (compunits): New method.
10704 * objfiles.c (objfile_relocate1): Update.
10705 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10706 * maint.c (count_symtabs_and_blocks): Update.
10707 * linespec.c (iterate_over_all_matching_symtabs): Update.
10708 * cp-support.c (add_symbol_overload_list_qualified): Update.
10709 * coffread.c (coff_symtab_read): Update.
10710 * ada-lang.c (add_nonlocal_symbols)
10711 (ada_collect_symbol_completion_matches)
10712 (ada_add_global_exceptions): Update.
10713
7e955d83
TT
107142019-01-15 Tom Tromey <tom@tromey.com>
10715
10716 * progspace.h (program_space) <objfiles_safe_range>: New
10717 typedef.
10718 <objfiles_safe>: New method.
10719 * objfiles.h (class all_objfiles_safe): Remove.
10720 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10721 * jit.c (jit_inferior_exit_hook): Update.
10722
2030c079
TT
107232019-01-17 Tom Tromey <tom@tromey.com>
10724
10725 * progspace.h (program_space) <objfiles_range>: New typedef.
10726 <objfiles>: New method.
10727 <objfiles_head>: Rename from objfiles.
10728 (object_files): Update.
10729 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10730 * guile/scm-pretty-print.c
10731 (ppscm_find_pretty_printer_from_objfiles): Update.
10732 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10733 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10734 Update.
10735 * python/py-progspace.c (pspy_get_objfiles): Update.
10736 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10737 Update.
10738 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10739 (objfpy_lookup_objfile_by_build_id): Update.
10740 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10741 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10742 Update.
10743 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10744 (expand_symtab_containing_pc, lookup_objfile_from_block)
10745 (lookup_static_symbol, basic_lookup_transparent_type)
10746 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10747 (find_line_symtab, info_sources_command)
10748 (default_collect_symbol_completion_matches_break_on)
10749 (make_source_files_completion_list, find_main_name): Update.
10750 * symmisc.c (print_symbol_bcache_statistics)
10751 (print_objfile_statistics, maintenance_print_symbols)
10752 (maintenance_print_msymbols, maintenance_print_objfiles)
10753 (maintenance_info_symtabs, maintenance_check_symtabs)
10754 (maintenance_expand_symtabs, maintenance_info_line_tables):
10755 Update.
10756 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10757 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10758 (map_overlay_command, unmap_overlay_command)
10759 (simple_overlay_update, expand_symtabs_matching)
10760 (map_symbol_filenames): Update.
10761 * symfile-debug.c (set_debug_symfile): Update.
10762 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10763 Update.
10764 * source.c (select_source_symtab, forget_cached_source_info):
10765 Update.
10766 * solib.c (solib_read_symbols): Update.
10767 * solib-spu.c (append_ocl_sos): Update.
10768 * psymtab.c (maintenance_print_psymbols)
10769 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10770 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10771 * printcmd.c (info_symbol_command): Update.
10772 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10773 Update.
10774 * objfiles.h (class all_objfiles): Remove.
10775 * objfiles.c (have_partial_symbols, have_full_symbols)
10776 (have_minimal_symbols, qsort_cmp, update_section_map)
10777 (shared_objfile_contains_address_p)
10778 (default_iterate_over_objfiles_in_search_order): Update.
10779 * objc-lang.c (info_selectors_command, info_classes_command)
10780 (find_methods): Update.
10781 * minsyms.c (find_solib_trampoline_target): Update.
10782 * maint.c (maintenance_info_sections)
10783 (maintenance_translate_address, count_symtabs_and_blocks):
10784 Update.
10785 * main.c (captured_main_1): Update.
10786 * linux-thread-db.c (try_thread_db_load_from_pdir)
10787 (has_libpthread): Update.
10788 * linespec.c (iterate_over_all_matching_symtabs)
10789 (search_minsyms_for_name): Update.
10790 * jit.c (jit_find_objf_with_entry_addr): Update.
10791 * hppa-tdep.c (find_unwind_entry)
10792 (hppa_lookup_stub_minimal_symbol): Update.
10793 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10794 Update.
10795 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10796 (elf_gnu_ifunc_resolve_by_got): Update.
10797 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10798 * dwarf-index-write.c (save_gdb_index_command): Update.
10799 * cp-support.c (add_symbol_overload_list_qualified): Update.
10800 * breakpoint.c (create_overlay_event_breakpoint)
10801 (create_longjmp_master_breakpoint)
10802 (create_std_terminate_master_breakpoint)
10803 (create_exception_master_breakpoint): Update.
10804 * blockframe.c (find_pc_partial_function): Update.
10805 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10806 (ada_collect_symbol_completion_matches)
10807 (ada_add_global_exceptions): Update.
10808
776489e0
TT
108092019-01-17 Tom Tromey <tom@tromey.com>
10810
10811 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10812 declare VEC.
10813 (solib_target_parse_libraries): Change return type.
10814 (library_list_start_segment, library_list_start_section)
10815 (library_list_end_library, library_list_start_library); Update.
10816 (solib_target_free_library_list): Remove.
10817 (solib_target_parse_libraries): Remove cleanup. Change return
10818 type.
10819 (solib_target_current_sos): Update.
10820
6471e7d2
TT
108212019-01-17 Tom Tromey <tromey@bapiya>
10822
10823 * valprint.c: Replace "the the" with "the".
10824 * symtab.c: Replace "the the" with "the".
10825 * solib.c: Replace "the the" with "the".
10826 * solib-dsbt.c: Replace "the the" with "the".
10827 * linespec.c: Replace "the the" with "the".
10828 * dwarf2loc.h: Replace "the the" with "the".
10829 * amd64-windows-tdep.c: Replace "the the" with "the".
10830 * aarch64-tdep.c: Replace "the the" with "the".
10831
c24bdb02
KS
108322019-01-16 Keith Seitz <keiths@redhat.com>
10833
10834 PR gdb/23773
10835 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10836 <builder>: Rename to ..
10837 <m_builder>: ... this and make private.
10838 (dwarf2_cu::get_builder): New method. Change all users of
10839 `builder' to use this method.
10840 (dwarf2_start_symtab): Move to ...
10841 (dwarf2_cu::start_symtab): ... here. Update all callers
10842 (setup_type_unit_groups): Move to ...
10843 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10844 callers.
10845 (dwarf2_cu::reset_builder): New method.
10846 (process_full_compunit, process_full_type_unit): Use
10847 dwarf2_cu::reset_builder.
10848 (follow_die_offset): Record the ancestor CU if it is different
10849 from the followed DIE's CU.
10850 (follow_die_sig_1): Likewise.
10851
8d64371b
TT
108522019-01-15 Tom Tromey <tom@tromey.com>
10853
10854 * remote.c (class remote_state) <buf>: Now a char_vector.
10855 <buf_size>: Remove.
10856 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10857 parameter.
10858 (remote_target::getpkt_or_notif_sane_1)
10859 (remote_target::getpkt_sane)
10860 (remote_target::getpkt_or_notif_sane): Likewise.
10861 (class remote_target) <putpkt>: New overload.
10862 (remote_target::read_frame): Change type of "buf_p". Remove
10863 sizeof_p parameter.
10864 (packet_ok): New overload.
10865 (packet_check_result): New overload.
10866 Update all uses.
10867
bb277751
TT
108682019-01-14 Tom Tromey <tom@tromey.com>
10869
10870 * remote-notif.c (handle_notification, remote_notif_ack)
10871 (remote_notif_parse): Make "buf" const.
10872 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10873 const.
10874 (remote_notif_parse, remote_notif_ack, handle_notification):
10875 Likewise.
10876 * remote.c (remote_notif_stop_parse): Make "buf" const.
10877 (remote_target::remote_parse_stop_reply): Make "buf" const.
10878 (remote_notif_stop_ack): Make "buf" const.
10879
05be00a8
TT
108802019-01-14 Tom Tromey <tom@tromey.com>
10881
10882 * remote.c (remote_console_output): Make parameter const.
10883
491adeca
TT
108842019-01-14 Tom Tromey <tom@tromey.com>
10885
10886 * target-debug.h (target_debug_print_signals): Constify.
10887 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10888 * procfs.c (procfs_target::pass_signals): Update.
10889 * linux-nat.c (linux_nat_target::pass_signals): Update.
10890 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10891 * target-delegates.c: Rebuild.
10892 * remote.c (remote_target::program_signals): Update.
10893 (remote_target::pass_signals): Update.
10894 * target.c (target_pass_signals): Constify argument.
10895 (target_program_signals): Likewise.
10896 * target.h (struct target_ops) <pass_signals, program_signals>:
10897 Constify argument.
10898 (target_pass_signals, target_program_signals): Constify argument.
10899
bbd94648
TT
109002019-01-14 Tom Tromey <tom@tromey.com>
10901
10902 PR tui/28819:
10903 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10904
6f072a10
PFC
109052019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10906
10907 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10908 field.
10909 * rs6000-tdep.c: Include reggroups.h.
10910 (IS_V_ALIAS_PSEUDOREG): Define.
10911 (rs6000_register_name): Return names for the "vX" aliases.
10912 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10913 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10914 aliases. Call default_register_reggroup_p for all other
10915 pseudo-registers.
10916 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10917 New functions.
10918 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10919 Handle "vX" aliases.
10920 (v_alias_pseudo_register_collect): New function.
10921 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10922 (rs6000_gdbarch_init): Initialize "vX" aliases as
10923 pseudo-registers. Restore registration of
10924 rs6000_pseudo_register_reggroup_p with
10925 set_tdesc_pseudo_register_reggroup_p.
10926
1a782351
MF
109272019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10928
10929 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10930 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10931 set_gdbarch_num_pseudo_regs.
10932
d73cff18
PW
109332019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10934
10935 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10936 Remove arg prefixname, add do_set and do_show.
10937 Add member functions set_list and show_list.
10938 * cli/cli-style.c (class cli_style_option): Update accordingly.
10939 (style_set_list): Move to file scope.
10940 (style_show_list): Likewise.
10941 (set_style): Call help_list.
10942 (show_style): Call cmd_show_list.
10943 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10944 Update to use the new macro.
10945
60a90376
JB
109462019-10-12 Joel Brobecker <brobecker@adacore.com>
10947
10948 * ada-lang.c (_initialize_ada_language): Expand the help text
10949 for the "catch exception" command.
10950
9d7c67bf
PW
109512019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10952
10953 * symtab.c (matching_obj_sections): Initialize obj,
10954 declare it closer to its usage.
10955
7cf47dc4
TT
109562019-01-10 Tom Tromey <tom@tromey.com>
10957
10958 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10959 (basic_inf_threads_range): Remove.
10960 (inf_threads_range, inf_non_exited_threads_range)
10961 (safe_inf_threads_range): Use next_adapter.
10962
d3cb6808
KS
109632019-01-10 Keith Seitz <keiths@redhat.com>
10964
10965 PR gdb/23712
10966 PR symtab/23010
10967 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10968 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10969
63a20375
KS
109702019-01-10 Keith Seitz <keiths@redhat.com>
10971
10972 PR gdb/23712
10973 PR symtab/23010
10974 * dictionary.c (pending_to_vector): Remove.
10975 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10976 Remove _1 suffix, replacing functions of the same name. Update
10977 all callers.
10978 (dict_create_hashed, dict_create_hashed_expandable)
10979 (dict_create_linear, dict_create_linear_expandable, dict_free)
10980 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10981 Make functions static.
10982
b026f593
KS
109832019-01-10 Keith Seitz <keiths@redhat.com>
10984
10985 PR gdb/23712
10986 PR symtab/23010
10987 * dictionary.h (struct dictionary): Replace declaration with
10988 multidictionary.
10989 (dict_create_hashed, dict_create_hashed_expandable)
10990 (dict_create_linear, dict_create_linear_expandable)
10991 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10992 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10993 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10994 taking multidictionary argument.
10995 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10996 * block.h (struct block) <dict>: Change to multidictionary
10997 and rename `multidict'.
10998 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10999 symmisc.c: Update all dictionary references to multidictionary.
11000
c7748ee9
KS
110012019-01-10 Keith Seitz <keiths@redhat.com>
11002
11003 PR gdb/23712
11004 PR symtab/23010
11005 * dictionary.c: Include unordered_map.
11006 (pending_to_vector): New function.
11007 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11008 Rewrite the non-"_1" functions to take vector instead
11009 of linked list.
11010 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11011 "new" _1 versions of the same name.
11012 (multidictionary): Define.
11013 (std::hash<enum language): New definition.
11014 (collate_pending_symbols_by_language, mdict_create_hashed)
11015 (mdict_create_hashed_expandable, mdict_create_linear)
11016 (mdict_create_linear_expandable, mdict_free)
11017 (find_language_dictionary, create_new_language_dictionary)
11018 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11019 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11020 (mdict_size, mdict_empty): New functions.
11021 * dictionary.h (mdict_iterator): Define.
11022
67aa1f3c
PA
110232019-01-10 Pedro Alves <palves@redhat.com>
11024
11025 * breakpoint.c (read_uploaded_action)
11026 (create_tracepoint_from_upload): Adjust to use
11027 gdb::unique_xmalloc_ptr.
11028 * ctf.c (ctf_write_uploaded_tp):
11029 (SET_ARRAY_FIELD): Use emplace_back.
11030 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11031 * tracefile-tfile.c (tfile_write_uploaded_tp):
11032 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11033 gdb::unique_xmalloc_ptr.
11034 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11035 at_string, cond_string, cmd_strings>: Replace char pointers
11036 with gdb::unique_xmalloc_ptr.
11037
2f667667
PA
110382019-01-10 Pedro Alves <palves@redhat.com>
11039
11040 * solib-target.c (library_list_start_library): Don't xstrdup name.
11041
36cb7237
PA
110422019-01-10 Pedro Alves <palves@redhat.com>
11043
11044 * mdebugread.c (parse_partial_symbols): Use
11045 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11046
da584958
AB
110472019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11048
11049 * linux-fork.c (scoped_switch_fork_info)
11050 <~scoped_switch_fork_info>: Fix incorrect variable name.
11051
1ef8573c
AB
110522019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11053
11054 * linux-fork.c (scoped_switch_fork_info)
11055 <scoped_switch_fork_info>: Make explicit.
11056 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11057
8d7bcccb
TT
110582019-01-10 Tom Tromey <tom@tromey.com>
11059
11060 * objfiles.h (objfile::reset_psymtabs): Update.
11061 * objfiles.c (objfile::objfile): Update.
11062 * psymtab.h (psymtab_storage::obstack): Update.
11063 (psymtab_storage::m_obstack): Use gdb::optional.
11064 (class psymtab_storage): Update comment. Remove objfile
11065 parameter.
11066 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11067
b596a3c7
TT
110682019-01-10 Tom Tromey <tom@tromey.com>
11069
11070 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11071 <free_psymtabs>: Now private.
11072 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11073 (allocate_psymtab): Use new method.
11074
a9342b62
TT
110752019-01-10 Tom Tromey <tom@tromey.com>
11076
11077 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11078 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11079 * mdebugread.c (parse_partial_symbols): Use
11080 allocate_dependencies.
11081 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11082 allocate_dependencies.
11083 (process_psymtab_comp_unit_reader)
11084 (build_type_psymtab_dependencies): Likewise.
11085 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11086
5af70966
TT
110872019-01-10 Tom Tromey <tom@tromey.com>
11088
11089 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11090 PSYMBOL_SET_LANGUAGE.
11091 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11092
5923a04c
TT
110932019-01-10 Tom Tromey <tom@tromey.com>
11094
11095 * psymtab.h (psymtab_storage::obstack): New method.
11096 <m_obstack>: Rename from obstack; now private.
11097 * psymtab.c (psymtab_storage): Update.
11098 * dwarf2read.c (create_addrmap_from_index)
11099 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11100 Update.
11101
6d6a12bf
TT
111022019-01-10 Tom Tromey <tom@tromey.com>
11103
11104 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11105 * objfiles.h (objfile::reset_psymtabs): New method.
11106
d320c2b5
TT
111072019-01-10 Tom Tromey <tom@tromey.com>
11108
11109 * symmisc.c (print_symbol_bcache_statistics): Update.
11110 (print_objfile_statistics): Update.
11111 * symfile.c (reread_symbols): Update.
11112 * psymtab.h (class psymtab_storage): New.
11113 * psymtab.c (psymtab_storage): New constructor.
11114 (~psymtab_storage): New destructor.
11115 (require_partial_symbols): Update.
11116 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11117 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11118 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11119 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11120 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11121 (start_psymtab_common, end_psymtab_common)
11122 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11123 (allocate_psymtab): Update.
11124 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11125 Update.
11126 (dump_psymtab_addrmap, maintenance_print_psymbols)
11127 (maintenance_check_psymtabs): Update.
11128 (class objfile_psymtabs): Move to objfiles.h.
11129 * psympriv.h (discard_psymtab): Now inline.
11130 (psymtab_discarder::psymtab_discarder): Update.
11131 (psymtab_discarder::~psymtab_discarder): Update.
11132 (ALL_OBJFILE_PSYMTABS): Rewrite.
11133 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11134 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11135 Remove fields.
11136 <partial_symtabs>: New field.
11137 (class objfile_psymtabs): Move from psymtab.h. Update.
11138 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11139 psymbol_cache.
11140 (objfile::~objfile): Don't destroy psymbol_cache.
11141 * mdebugread.c (parse_partial_symbols): Update.
11142 * dwarf2read.c (create_addrmap_from_index)
11143 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11144 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11145 (add_partial_subprogram, dwarf2_ranges_read): Update.
11146 * dwarf-index-write.c (write_address_map)
11147 (write_one_signatured_type, recursively_write_psymbols)
11148 (class debug_names, class debug_names, write_psymtabs_to_index):
11149 Update.
11150
1d94a5a3
TT
111512019-01-10 Tom Tromey <tom@tromey.com>
11152
11153 * symtab.h (SYMBOL_SET_NAMES): Update.
11154 (symbol_set_names): Update.
11155 (MSYMBOL_SET_NAMES): Update.
11156 * symtab.c (symbol_set_names): Change argument to be an
11157 objfile_per_bfd_storage.
11158 * psymtab.c (add_psymbol_to_bcache): Update.
11159 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11160
0f14768a
TT
111612019-01-10 Tom Tromey <tom@tromey.com>
11162
11163 * symtab.c (create_demangled_names_hash): Change argument to be an
11164 objfile_per_bfd_storage.
11165 (symbol_set_names): Update.
11166
6eee24ce
TT
111672019-01-10 Tom Tromey <tom@tromey.com>
11168
11169 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11170 init_psymbol_list.
11171 * psymtab.c (init_psymbol_list): Do nothing if already called.
11172 * psympriv.h (init_psymbol_list): Add comment.
11173 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11174 init_psymbol_list.
11175 * dbxread.c (dbx_symfile_read): Unconditionally call
11176 init_psymbol_list.
11177
75aedd27
TT
111782019-01-10 Tom Tromey <tom@tromey.com>
11179
11180 * xcoffread.c (scan_xcoff_symtab): Update.
11181 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11182 "where".
11183 * mdebugread.c (parse_partial_symbols)
11184 (handle_psymbol_enumerators): Update.
11185 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11186 * dbxread.c (read_dbx_symtab): Update.
11187 * psympriv.h (psymbol_placement): New enum.
11188 (add_psymbol_to_list): Update.
11189
939652a5
TT
111902019-01-10 Tom Tromey <tom@tromey.com>
11191
11192 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11193 static_psymbols parameters.
11194 (scan_xcoff_symtab): Update.
11195 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11196 static_psymbols parameters.
11197 * psympriv.h (start_psymtab_common): Update.
11198 * mdebugread.c (parse_partial_symbols): Update.
11199 * dwarf2read.c (create_partial_symtab): Update.
11200 * dbxread.c (read_dbx_symtab): Update.
11201 (start_psymtab): Remove global_psymbols and static_psymbols
11202 parameters.
11203
baa62830
TT
112042019-01-10 Tom Tromey <tom@tromey.com>
11205
11206 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11207 * psymtab.c (allocate_psymtab): Add comment.
11208 * psympriv.h (allocate_psymtab): Add comment.
11209 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11210 initializations.
11211 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11212
0e8f53ba
TT
112132019-01-10 Tom Tromey <tom@tromey.com>
11214
11215 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11216 Don't declare.
11217 * mipsread.c: Include mdebugread.h.
11218 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11219 Declare.
11220 * elfread.c: Include mdebugread.h.
11221
b22a7c6a
TT
112222019-01-09 Tom Tromey <tom@tromey.com>
11223
11224 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11225 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11226 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11227 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11228 (psym_lookup_symbol, psym_find_last_source_symtab)
11229 (psym_forget_cached_source_info, psym_print_stats)
11230 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11231 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11232 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11233 (psym_find_compunit_symtab_by_address)
11234 (maintenance_print_psymbols, maintenance_info_psymtabs)
11235 (maintenance_check_psymtabs): Use ranged for.
11236 * psymtab.h (class objfile_psymtabs): New.
11237 (require_partial_symbols): Return objfile_psymtabs.
11238 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11239
3b9d3ac2
TT
112402019-01-09 Tom Tromey <tom@tromey.com>
11241
11242 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11243 (find_pc_mapped_section, list_overlays_command)
11244 (map_overlay_command, unmap_overlay_command)
11245 (simple_overlay_update): Use all_objfiles.
11246 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11247 * printcmd.c (info_symbol_command): Use all_objfiles.
11248 * objfiles.h (ALL_OBJSECTIONS): Remove.
11249 * maint.c (maintenance_translate_address): Use all_objfiles.
11250 * gcore.c (gcore_create_callback): Use all_objfiles.
11251 (objfile_find_memory_regions): Likewise.
11252
8b31193a
TT
112532019-01-09 Tom Tromey <tom@tromey.com>
11254
11255 * symtab.c (find_line_symtab, info_sources_command)
11256 (make_source_files_completion_list): Use objfile_compunits.
11257 * source.c (select_source_symtab): Use objfile_compunits.
11258 * objfiles.h (struct objfile): Update comment.
11259 (ALL_OBJFILES): Remove.
11260 (ALL_FILETABS): Remove.
11261 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11262 objfile_compunits.
11263
d5da8b3c
TT
112642019-01-09 Tom Tromey <tom@tromey.com>
11265
11266 * symmisc.c (print_objfile_statistics, dump_objfile)
11267 (maintenance_print_symbols): Use compunit_filetabs.
11268 * source.c (forget_cached_source_info_for_objfile): Use
11269 compunit_filetabs.
11270 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11271 (ALL_FILETABS): Use compunit_filetabs.
11272 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11273 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11274
5accd1a0
TT
112752019-01-09 Tom Tromey <tom@tromey.com>
11276
11277 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11278 (compunit_filetabs): New.
11279 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11280 compunit_filetabs.
11281 (info_sources_command, make_source_files_completion_list): Remove
11282 declaration.
11283 * symmisc.c (print_objfile_statistics, dump_objfile)
11284 (maintenance_print_symbols): Remove declaration.
11285 (maintenance_info_symtabs): Use compunit_filetabs.
11286 (maintenance_info_line_tables): Likewise.
11287 * source.c (select_source_symtab): Change local variable name.
11288 (forget_cached_source_info_for_objfile): Remove declaration.
11289 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11290 * objfiles.c (objfile_relocate1): Remove declaration.
11291 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11292 declaration.
11293 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11294 * coffread.c (coff_symtab_read): Remove declaration.
11295 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11296 compunit_filetabs.
11297
d8aeb77f
TT
112982019-01-09 Tom Tromey <tom@tromey.com>
11299
11300 * symtab.c (lookup_objfile_from_block)
11301 (find_pc_sect_compunit_symtab, search_symbols)
11302 (default_collect_symbol_completion_matches_break_on): Use
11303 objfile_compunits.
11304 * objfiles.h (ALL_COMPUNITS): Remove.
11305 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11306 * cp-support.c (add_symbol_overload_list_qualified): Use
11307 objfile_compunits.
11308 * ada-lang.c (ada_collect_symbol_completion_matches)
11309 (ada_add_global_exceptions): Use objfile_compunits.
11310
592553c4
TT
113112019-01-09 Tom Tromey <tom@tromey.com>
11312
11313 * source.c (select_source_symtab)
11314 (forget_cached_source_info_for_objfile): Remove declaration.
11315 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11316 declaration.
11317 * maint.c (count_symtabs_and_blocks): Remove declaration.
11318 * cp-support.c (add_symbol_overload_list_qualified): Remove
11319 declaration.
11320 * coffread.c (coff_symtab_read): Remove declaration.
11321 * symtab.c (lookup_symbol_in_objfile_symtabs)
11322 (basic_lookup_transparent_type_1): Use objfile_compunits.
11323 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11324 (info_sources_command, search_symbols)
11325 (default_collect_symbol_completion_matches_break_on)
11326 (make_source_files_completion_list): Remove declaration.
11327 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11328 (ada_collect_symbol_completion_matches)
11329 (ada_add_global_exceptions): Remove declaration.
11330 * linespec.c (iterate_over_all_matching_symtabs): Use
11331 objfile_compunits.
11332 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11333 (class objfile_compunits): New.
11334 (ALL_COMPUNITS): Use objfile_compunits.
11335 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11336 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11337 objfile_compunits.
11338 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11339
5325b9bf
TT
113402019-01-09 Tom Tromey <tom@tromey.com>
11341
11342 * symtab.c (search_symbols)
11343 (default_collect_symbol_completion_matches_break_on): Use
11344 objfile_msymbols.
11345 * ada-lang.c (ada_lookup_simple_minsym)
11346 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11347 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11348 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11349 objfile_msymbols.
11350 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11351 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11352 * objc-lang.c (find_methods): Use objfile_msymbols.
11353 (info_selectors_command, info_classes_command): Likewise.
11354 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11355 * objfiles.h (class objfile_msymbols): New.
11356 (ALL_OBJFILE_MSYMBOLS): Remove.
11357 (ALL_MSYMBOLS): Remove.
11358
cac85af2
TT
113592019-01-09 Tom Tromey <tom@tromey.com>
11360
11361 * common/next-iterator.h (next_adapter): Add Iterator template
11362 parameter.
11363 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11364 (class all_objfiles_safe): New.
11365 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11366 * objfiles.c (put_objfile_before): Update comment.
11367 (add_separate_debug_objfile): Likewise.
11368 (free_all_objfiles): Use all_objfiles_safe.
11369 (objfile_purge_solibs): Likewise.
11370
aed57c53
TT
113712019-01-09 Tom Tromey <tom@tromey.com>
11372
11373 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11374 (expand_symtab_containing_pc, lookup_static_symbol)
11375 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11376 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11377 all_objfiles.
11378 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11379 * breakpoint.c (create_overlay_event_breakpoint)
11380 (create_longjmp_master_breakpoint)
11381 (create_std_terminate_master_breakpoint)
11382 (create_exception_master_breakpoint): Use all_objfiles.
11383 * linux-thread-db.c (try_thread_db_load_from_pdir)
11384 (has_libpthread): Use all_objfiles.
11385 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11386 * linespec.c (iterate_over_all_matching_symtabs)
11387 (search_minsyms_for_name): Use all_objfiles.
11388 * maint.c (maintenance_info_sections): Use all_objfiles.
11389 * main.c (captured_main_1): Use all_objfiles.
11390 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11391 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11392 * guile/scm-pretty-print.c
11393 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11394 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11395 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11396 (maintenance_print_msymbols): Use all_objfiles.
11397 * source.c (select_source_symtab): Use all_objfiles.
11398 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11399 * symfile.c (remove_symbol_file_command)
11400 (expand_symtabs_matching, map_symbol_filenames): Use
11401 all_objfiles.
11402 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11403 all_objfiles.
11404 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11405 * objc-lang.c (find_methods): Use all_objfiles.
11406 * objfiles.c (have_partial_symbols, have_full_symbols)
11407 (have_minimal_symbols, qsort_cmp)
11408 (default_iterate_over_objfiles_in_search_order): Use
11409 all_objfiles.
11410 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11411 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11412 (maintenance_check_psymtabs): Use all_objfiles.
11413 (ALL_PSYMTABS): Remove.
11414 * compile/compile-object-run.c (do_module_cleanup): Use
11415 all_objfiles.
11416 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11417 * cp-support.c (add_symbol_overload_list_qualified): Use
11418 all_objfiles.
11419 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11420 Use all_objfiles.
11421 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11422 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11423 all_objfiles.
11424 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11425 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11426 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11427 Uses all_objfiles.
11428 * solib.c (solib_read_symbols): Use all_objfiles
11429
99d89cde
TT
114302019-01-09 Tom Tromey <tom@tromey.com>
11431
11432 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11433 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11434 all_objfiles.
11435 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11436 * symmisc.c (print_symbol_bcache_statistics)
11437 (print_objfile_statistics, maintenance_print_objfiles)
11438 (maintenance_info_symtabs, maintenance_check_symtabs)
11439 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11440 all_objfiles.
11441 * source.c (forget_cached_source_info): Use all_objfiles.
11442 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11443 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11444 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11445 * objfiles.c (update_section_map): Use all_objfiles.
11446 (shared_objfile_contains_address_p): Likewise.
11447 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11448 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11449
21708325
TT
114502019-01-09 Tom Tromey <tom@tromey.com>
11451
11452 * common/next-iterator.h: New file.
11453 * objfiles.h (class all_objfiles): New.
11454 (struct objfile_iterator): New.
11455
669e09f6
PW
114562019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11457
11458 * NEWS: Move the description of the changed "frame", "select-frame",
11459 and "info frame" commands to the Changed commands section.
11460
041be526
SM
114612019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11462
11463 * gdbtypes.c (check_stub_method_group): Remove handling of old
11464 mangling schemes.
11465 * linespec.c (find_methods): Likewise.
11466 * stabsread.c (read_member_functions): Likewise.
11467 * valops.c (search_struct_method): Likewise.
11468 (value_struct_elt_for_reference): Likewise.
11469 * NEWS: Mention this change.
11470
0e2a2133
AB
114712019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11472
11473 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11474 print_source_lines.
11475 * source.c (print_source_lines_base): Update line number check.
11476 (print_source_lines): New function.
11477 (source_lines_range::source_lines_range): New function.
11478 * source.h (class source_lines_range): New class.
11479 (print_source_lines): New declaration.
11480
1055a3b4
PW
114812019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11482
11483 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11484
cfeadda5
TT
114852019-01-08 Tom Tromey <tom@tromey.com>
11486 Simon Marchi <simon.marchi@ericsson.com>
11487
11488 PR gdb/24060
11489 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11490 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11491 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11492 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11493 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11494 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11495
583068ca
AB
114962019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11497
11498 * source.c (select_source_symtab): Move header comment to
11499 declaration in source.h.
11500 (forget_cached_source_info_for_objfile): Likewise.
11501 (forget_cached_source_info): Likewise.
11502 (identify_source_line): Likewise.
11503 * source.h (identify_source_line): Move declaration from symtab.h
11504 and add comment from source.c
11505 (print_source_lines): Likewise.
11506 (forget_cached_source_info_for_objfile): Likewise.
11507 (forget_cached_source_info): Likewise.
11508 (select_source_symtab): Likewise.
11509 (enum print_source_lines_flag): Move definition from symtab.h.
11510 * symtab.h (identify_source_line): Move declaration to source.h.
11511 (print_source_lines): Likewise.
11512 (forget_cached_source_info_for_objfile): Likewise.
11513 (forget_cached_source_info): Likewise.
11514 (select_source_symtab): Likewise.
11515 (enum print_source_lines_flag): Move definition to source.h.
11516 * tui/tui-hooks.c: Add 'source.h' include.
11517
ec98a4ad
AB
115182019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11519
11520 * source.c (print_source_lines_base): Handle requests to print
11521 reverse line number sequences, and guard against empty lines
11522 string.
11523
62ea19c1
AB
115242019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11525
11526 * source.c (print_source_lines_base): Fix skip of '\r' if next
11527 character is '\n'.
11528
9d30e1fd
TT
115292019-01-06 Tom Tromey <tom@tromey.com>
11530
11531 * c-exp.y (struct c_parse_state) <macro_original_text,
11532 expansion_obstack>: New member.
11533 (macro_original_text, expansion_obstack): Remove globals.
11534 (scan_macro_expansion, scanning_macro_expansion)
11535 (finished_macro_expansion): Update.
11536 (scan_macro_cleanup): Remove.
11537 (yylex, c_parse): Update.
11538
c65bac38
TT
115392019-01-06 Tom Tromey <tom@tromey.com>
11540
11541 * c-exp.y (struct c_parse_state) <strings>: New member.
11542 (operator_stoken): Update.
11543
02e12e38
TT
115442019-01-06 Tom Tromey <tom@tromey.com>
11545
11546 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11547 (union type_stack_elt) <typelist_val>: Now a pointer to
11548 std::vector.
11549 (type_stack_cleanup): Don't declare.
11550 (push_typelist): Update.
11551 * parse.c (pop_typelist): Return a std::vector.
11552 (push_typelist): Take a std::vector.
11553 (follow_types): Update. Do not free args.
11554 (type_stack_cleanup): Remove.
11555 * c-exp.y (struct c_parse_state): New.
11556 (cpstate): New global.
11557 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11558 (nonempty_typelist): Update.
11559 (func_mod): Create a new vector.
11560 (c_parse): Create a c_parse_state.
11561 (check_parameter_typelist): Do not delete params.
11562 (function_method): Update. Do not delete type_list.
11563
f097f5ad
TT
115642019-01-06 Tom Tromey <tom@tromey.com>
11565
11566 PR gdb/28155:
11567 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11568 check_typedef.
11569 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11570 (print_return_value): Likewise.
11571
d2adf9f1
TT
115722019-01-05 Tom Tromey <tom@tromey.com>
11573
11574 * contrib/cleanup_check.py: Remove.
11575 * contrib/gcc-with-excheck: Remove.
11576 * contrib/exsummary.py: Remove.
11577 * contrib/excheck.py: Remove.
11578
2eab46b1
JB
115792019-01-05 Joel Brobecker <brobecker@adacore.com>
11580
11581 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11582 NULL. Initialize tpprev to NULL instead of assigning it
11583 to NULL on the next statement.
11584 * windows-nat.c (windows_delete_thread): Remove check for
11585 main_thread_id before printing thread exit notifications.
11586 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11587 Remove thread ID check against main_thread_id.
11588 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11589 windows_delete_thread.
11590 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11591
48c5e7e2
TT
115922019-01-04 Tom Tromey <tom@tromey.com>
11593
11594 * compile/compile.c (_initialize_compile): Use upper case for
11595 metasyntactic variables.
11596 * symmisc.c (_initialize_symmisc): Use upper case for
11597 metasyntactic variables.
11598 * psymtab.c (_initialize_psymtab): Use upper case for
11599 metasyntactic variables.
11600 * demangle.c (demangle_command): Use upper case for metasyntactic
11601 variables.
11602 (_initialize_demangler): Likewise.
11603 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11604 variables.
11605
986041cd
TT
116062019-01-03 Tom Tromey <tom@tromey.com>
11607
11608 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11609
7c711119
TT
116102019-01-03 Tom Tromey <tom@tromey.com>
11611
11612 * python/py-symtab.c (salpy_str): Update.
11613 (struct salpy_sal_object) <symtab>: Now a PyObject.
11614 (salpy_dealloc): Update.
11615 (del_objfile_sal): Use gdbpy_ref.
11616
1b20edf0
TT
116172019-01-03 Tom Tromey <tom@tromey.com>
11618
11619 * python/py-type.c (convert_field): Use new_reference. Return
11620 gdbpy_ref.
11621 (make_fielditem): Return gdbpy_ref.
11622 (typy_fields): Update.
11623 (typy_getitem): Update.
11624 (field_name): Return gdbpy_ref. Use new_reference.
11625 (typy_iterator_iternext): Update.
11626
ea41325b
TT
116272019-01-03 Tom Tromey <tom@tromey.com>
11628
11629 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11630
2a3c71d6
TT
116312019-01-03 Tom Tromey <tom@tromey.com>
11632
11633 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11634 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11635 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11636 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11637 (pspy_set_type_printers): Likewise.
11638 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11639 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11640 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11641 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11642 (objfpy_set_type_printers): Likewise.
11643
5c329e6a
TT
116442019-01-03 Tom Tromey <tom@tromey.com>
11645
11646 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11647 (gdbpy_print_stack): Use gdbpy_err_fetch.
11648 * python/python-internal.h (class gdbpy_err_fetch): New class.
11649 (class gdbpy_enter) <m_error_type, m_error_value,
11650 m_error_traceback>: Remove.
11651 <m_error>: New member.
11652 (gdbpy_exception_to_string): Don't declare.
11653 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11654 * python/py-value.c (convert_value_from_python): Use
11655 gdbpy_err_fetch.
11656 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11657 gdbpy_exception_to_string.
11658 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11659 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11660 gdbpy_err_fetch.
11661
169bb27b
AB
116622019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11663
11664 * linux-nat.c (delete_lwp_cleanup): Delete.
11665 (struct lwp_deleter): New struct.
11666 (lwp_info_up): New typedef.
11667 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11668 lwp_info_up.
11669
a07c8880
AB
116702019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11671
11672 * linux-fork.c (class scoped_switch_fork_info): New class.
11673 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11674
26089c49
AB
116752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11676
11677 * valops.c (find_overload_match): Remove use of null_cleanup, and
11678 calls to do_cleanups.
11679
06d3e5b0
AB
116802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11681
11682 * compile/compile-cplus-types.c
11683 (compile_cplus_instance::decl_name): Handle changes to
11684 cp_func_name.
11685 * cp-support.c (cp_func_name): Update header comment, update
11686 return type.
11687 * cp-support.h (cp_func_name): Update return type in declaration.
11688 * valops.c (find_overload_match): Move temp_func local to top
11689 level of function and change its type. Use temp_func to hold and
11690 delete temporary string obtained from cp_func_name.
11691
66644cd3
AB
116922019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11693
11694 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11695 gdb::char_vector, remove cleanup, and update uses of `msg`.
11696
592d8c0a
JW
116972019-01-03 Jim Wilson <jimw@sifive.com>
11698
11699 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11700
c55d06ec
TT
117012019-01-02 Tom Tromey <tom@tromey.com>
11702
11703 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11704 (tdesc_parse_xml): Remove cleanups.
11705 * target-descriptions.h (make_cleanup_free_target_description):
11706 Don't declare.
11707 (target_desc_deleter): New struct.
11708 (target_desc_up): New typedef.
11709 * target-descriptions.c (target_desc_deleter::operator()): Rename
11710 from free_target_description.
11711 (make_cleanup_free_target_description): Remove.
11712
3a6ae42d
TT
117132019-01-02 Tom Tromey <tom@tromey.com>
11714
11715 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11716 constructor, destructor.
11717 (linespec_parser): Remove typedef.
11718 (~linespec_parser): Rename from linespec_parser_delete.
11719 (linespec_lex_to_end, linespec_complete_label)
11720 (linespec_complete): Update.
11721 (decode_line_full): Remove cleanups.
11722 (decode_line_1): Update.
11723
61fd3e73
TT
117242019-01-02 Tom Tromey <tom@tromey.com>
11725
11726 * python/python-internal.h (inferior_to_inferior_object): Change
11727 return type.
11728 * python/py-exitedevent.c (create_exited_event_object): Update.
11729 * python/py-inferior.c (inferior_to_inferior_object): Return
11730 gdbpy_ref.
11731 (python_new_inferior, python_inferior_deleted)
11732 (thread_to_thread_object, delete_thread_object)
11733 (build_inferior_list, gdbpy_selected_inferior): Update.
11734 * python/py-infthread.c (create_thread_object): Update. Also fail
11735 if inferior_to_inferior_object fails.
11736
d20172fc
SM
117372019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11738
11739 * inferior.h (class inferior) <displaced_step_state>: New field.
11740 * infrun.h (struct displaced_step_state): Move here from
11741 infrun.c. Initialize fields, add constructor.
11742 <inf>: Remove field.
11743 <reset>: New method.
11744 * infrun.c (struct displaced_step_inferior_state): Move to
11745 infrun.h.
11746 (displaced_step_inferior_states): Remove.
11747 (get_displaced_stepping_state): Adust.
11748 (displaced_step_in_progress_any_inferior): Adjust.
11749 (displaced_step_in_progress_thread): Adjust.
11750 (displaced_step_in_progress): Adjust.
11751 (add_displaced_stepping_state): Remove.
11752 (get_displaced_step_closure_by_addr): Adjust.
11753 (remove_displaced_stepping_state): Remove.
11754 (infrun_inferior_exit): Call displaced_step_state.reset.
11755 (use_displaced_stepping): Don't check for NULL.
11756 (displaced_step_prepare_throw): Call
11757 get_displaced_stepping_state.
11758 (displaced_step_fixup): Don't check for NULL.
11759 (prepare_for_detach): Don't check for NULL.
11760
e3319240
PW
117612019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11762
11763 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11764 in case of call that did not complete.
11765
5d36dfb9
AU
117662019-01-02 Andrey Utkin <autkin@undo.io>
11767
11768 * symfile.c (find_separate_debug_file): Fix search of debug files for
11769 remote debuggee.
11770
8833fbf0
TT
117712019-01-02 Tom Tromey <tom@tromey.com>
11772
11773 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11774 indentation.
11775 * python/py-frame.c (frapy_older): Remove cast.
11776 (frapy_newer): Likewise.
11777 * python/py-breakpoint.c (local_setattro): Remove cast.
11778 * python/py-arch.c (archpy_name): Remove local variable.
11779 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11780
4ada3dfd
JB
117812019-01-02 Joel Brobecker <brobecker@adacore.com>
11782
11783 * unittests/basic_string_view/element_access/char/empty.cc:
11784 Fix year range in copyright header.
11785
113b7b81
AB
117862019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11787
11788 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11789 Delete.
11790 <operator==>: Update with for removed field.
11791 <hash>: Likewise.
11792 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11793 <isa_features>: ...this.
11794 <abi_features>: New field.
11795 (riscv_isa_flen): Update comment.
11796 (riscv_abi_xlen): New declaration.
11797 (riscv_abi_flen): New declaration.
11798 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11799 isa_features.
11800 (riscv_abi_xlen): New function.
11801 (riscv_isa_flen): Update to get answer from isa_features.
11802 (riscv_abi_flen): New function.
11803 (riscv_has_fp_abi): Update to get answer from abi_features.
11804 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11805 xlen and flen.
11806 (riscv_call_info) <xlen, flen>: Update comment.
11807 (riscv_call_arg_struct): Remove invalid assertions
11808 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11809 is removed.
11810 (riscv_gdbarch_init): Gather isa features and abi features
11811 separately, ensure both match on the gdbarch when reusing an old
11812 gdbarch. Relax an error check to allow 32-bit abi float to run on
11813 a target with 64-bit float hardware.
11814
b18ca514
PW
118152019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11816
11817 * source.c (search_command_helper): Stop reverse search
11818 when line 1 has been searched.
11819
ec70d8db
PW
118202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11821
11822 * record-full.c (record_full_base_target::close): Rewrite
11823 record_full_core_buf_list free logic.
11824
5b38f9c1
PW
118252019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11826
11827 * break-catch-syscall.c (print_one_catch_syscall): xfree
11828 the last text.
11829
66d91b39
JB
118302019-01-01 Joel Brobecker <brobecker@adacore.com>
11831
11832 * top.c (print_gdb_version): Update Copyright year in version
11833 message.
11834
42a4f53d
JB
118352019-01-01 Joel Brobecker <brobecker@adacore.com>
11836
11837 Update copyright year range in all GDB files.
11838
7e955d83 118392019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11840
5bbd631d 11841 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11842
5bbd631d 11843For older changes see ChangeLog-2018.
c906108c
SS
11844\f
11845Local Variables:
11846mode: change-log
11847left-margin: 8
11848fill-column: 74
11849version-control: never
57da7796 11850coding: utf-8
c906108c 11851End:
5bbd631d 11852