]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
gdb: Add new -n flag to some info commands
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
4acfdd20
AB
12019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
2
3 * cli/cli-utils.c (info_print_options_defs): Delete.
4 (make_info_print_options_def_group): Delete.
5 (extract_info_print_options): Delete.
6 (info_print_command_completer): Delete.
7 (info_print_args_help): Add extra parameter, and optionally
8 include text about -n flag.
9 * cli/cli-utils.h (struct info_print_options): Delete.
10 (extract_info_print_options): Delete declaration.
11 (info_print_command_completer): Delete declaration.
12 (info_print_args_help): Add extra parameter, extend header
13 comment.
14 * python/python.c (gdbpy_rbreak): Pass additional parameter to
15 search_symbols.
16 * stack.c (struct info_print_options): New type.
17 (info_print_options_defs): New file scoped variable.
18 (make_info_print_options_def_group): New static function.
19 (info_print_command_completer): New static function.
20 (info_locals_command): Update to use new local functions.
21 (info_args_command): Likewise.
22 (_initialize_stack): Add extra parameter to calls to
23 info_print_args_help.
24 * symtab.c (search_symbols): Add extra parameter, use this to
25 possibly excluse non-debug symbols.
26 (symtab_symbol_info): Add extra parameter, which is passed on to
27 search_symbols.
28 (struct info_print_options): New type.
29 (info_print_options_defs): New file scoped variable.
30 (make_info_print_options_def_group): New static function.
31 (info_print_command_completer): New static function.
32 (info_variables_command): Update to use local functions, and pass
33 extra parameter through to symtab_symbol_info.
34 (info_functions_command): Likewise.
35 (info_types_command): Pass additional argument through to
36 symtab_symbol_info.
37 (rbreak_command): Pass extra argument to search_symbols.
38 (_initialize_symtab): Add extra arguments for calls to
39 info_print_args_help, and update help text for 'info variables',
40 'whereis', and 'info functions' commands.
41 * symtab.h (search_symbols): Add extra argument to declaration.
42 * NEWS: Mention new flags.
43
9aa55206
CB
442019-08-26 Christian Biesinger <cbiesinger@google.com>
45
46 * symtab.c (lookup_static_symbol): Call the new function (and move
47 it down to be next to lookup_global_symbol).
48 (struct global_sym_lookup_data): Add block_enum member and rename to...
49 (struct global_or_static_sym_lookup_data): ...this.
50 (lookup_symbol_global_iterator_cb): Pass block_index instead of
51 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
52 (lookup_symbol_global_or_static_iterator_cb): ...this.
53 (lookup_global_or_static_symbol): New function.
54 (lookup_global_symbol): Call new function.
55
5c31b358
TV
562019-08-26 Tom de Vries <tdevries@suse.de>
57
58 PR c++/24852
59 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
60 when pc_probe.prob == NULL.
61
23c13d42
SM
622019-08-25 Simon Marchi <simon.marchi@efficios.com>
63
64 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
65 variable symbol_linkage to symbol_linkage_.
66
beadd3e8
SM
672019-08-25 Simon Marchi <simon.marchi@efficios.com>
68
69 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
70 represent whether the symbol is static, dynamic, or we don't
71 know.
72
e3ec872f
YS
732019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
74
75 * gdb/rx-tdep.c (rx_register_names): New.
76 (rx_register_name): Delete.
77 (rx_psw_type): Delete.
78 (rx_fpsw_type): Delete.
79 (rx_register_type): Delete.
80 (rx_gdbarch_init): Convert target-descriptions.
81 (_initialize_rx_tdep): Add initialize_tdesc_rx.
82 * gdb/features/Makefile: Add rx.xml.
83 * gdb/features/rx.xml: New.
84 * gdb/features/rx.c: Generated.
85 * gdb/NEWS: Mention target description support.
86
d0509ba4
CB
872019-08-22 Christian Biesinger <cbiesinger@google.com>
88
89 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
90 *slot_ptr.
91
2d41fa11
SDJ
922019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
93
94 * configure.ac: Don't check for 'dlfcn.h' (moved to
95 gdbsupport/common.m4).
96 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
97 'gdbsupport/'.
98 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
99 * compile/compile-c-support.c: Include
100 'gdbsupport/gdb-dlfcn.h'.
101 * gdbsupport/common.m4: Check for 'dlfcn.h'.
102 * gdb-dlfcn.c: Move to...
103 * gdbsupport/gdb-dlfcn.c: ... here.
104 * gdb-dlfcn.h: Move to...
105 * gdbsupport/gdb-dlfcn.h: ... here.
106
de8af808
SL
1072019-08-23 Sandra Loosemore <sandra@codesourcery.com>
108
109 * nios2-tdep.c (struct reg_value): Improve comments. Make
110 the offset field signed.
111
27204489
CB
1122019-08-22 Christian Biesinger <cbiesinger@google.com>
113
114 * python/lib/gdb/__init__.py (_execute_file): New function.
115 * python/python.c (python_run_simple_file): Call gdb._execute_file
116 on Windows.
117
43771869
AB
1182019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
119
120 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
121 all uses as this was never set to anything but a zero value.
122
26c957f1
PA
1232019-08-21 Bogdan Harjoc <harjoc@gmail.com>
124
125 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
126
c07aae6e
CB
1272019-08-21 Christian Biesinger <cbiesinger@google.com>
128
129 * tui/tui-data.h (tui_gen_win_info): Add an =default
130 move constructor, required by some GCC versions.
131
3960cb7a
JF
1322019-08-21 Jinke Fan <fanjinke51@yeah.net>
133
134 * go32-nat.c (go32_sysinfo): Add hygon_p.
135
04c72a68
TT
1362019-08-20 Tom Tromey <tom@tromey.com>
137
138 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
139 line_from_reg_element_no, first_reg_element_no_inline,
140 display_all_data, delete_data_content_windows,
141 erase_data_content>: Now private.
142
072272ce
TT
1432019-08-20 Tom Tromey <tom@tromey.com>
144
145 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
146 (tui_unhighlight_win, tui_highlight_win)
147 (tui_win_info::make_window): Update.
148 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
149
973961bd
TT
1502019-08-20 Tom Tromey <tom@tromey.com>
151
152 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
153 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
154 (MAX_PID_WIDTH): Move to tui-stack.c.
155 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
156 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
157 (MAX_PID_WIDTH): Move from tui-data.h.
158
ab0e1f1a
TT
1592019-08-20 Tom Tromey <tom@tromey.com>
160
161 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
162 * tui/tui-wingeneral.c (box_win): Change type of win_info.
163 (box_win): Update.
164 (tui_gen_win_info::make_window): Rename from tui_make_window.
165 (tui_win_info::make_window): New method.
166 (tui_gen_win_info::make_visible): Update.
167 * tui/tui-source.c (tui_source_window::set_contents): Update.
168 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
169 (tui_data_window::display_registers_from): Update.
170 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
171 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
172 Declare.
173 <can_box>: Remove.
174 <title>: Remove.
175 (struct tui_win_info) <make_window>: Declare.
176 <can_box>: Now virtual.
177 <title>: New member.
178 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
179 * tui/tui-command.c (tui_cmd_window::resize): Update.
180
100c2bf3
TT
1812019-08-20 Tom Tromey <tom@tromey.com>
182
183 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
184 * tui/tui-regs.c (tui_data_window::show_registers): Update.
185 (tui_data_window::check_register_values): Update.
186
fa4dc567
TT
1872019-08-20 Tom Tromey <tom@tromey.com>
188
189 * tui/tui-regs.h (struct tui_data_window): Use
190 DISABLE_COPY_AND_ASSIGN.
191 <regs_content>: Change type, removing unique_ptr.
192 <tui_data_window>: Add move constructor.
193 * tui/tui-regs.c (tui_data_window::show_registers)
194 (tui_data_window::show_register_group)
195 (tui_data_window::display_registers_from)
196 (tui_data_window::display_registers_from)
197 (tui_data_window::first_data_item_displayed)
198 (tui_data_window::delete_data_content_windows)
199 (tui_data_window::rerender, tui_data_window::refresh_window)
200 (tui_data_window::check_register_values): Update.
201
ca02d7c8
TT
2022019-08-20 Tom Tromey <tom@tromey.com>
203
204 * tui/tui-regs.h (struct tui_data_window) <show_registers,
205 show_register_group>: Declare.
206 (tui_show_register_group): Don't declare.
207 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
208 tui_show_registers.
209 (tui_data_window::show_register_group): Rename from
210 tui_show_register_group.
211 (tui_data_window::check_register_values, tui_reg_command):
212 Update.
213 * tui/tui-layout.c (tui_set_layout): Update.
214
63356bfd
TT
2152019-08-20 Tom Tromey <tom@tromey.com>
216
217 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
218 Declare.
219 (tui_check_register_values): Don't declare.
220 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
221 from tui_check_register_values.
222 * tui/tui-hooks.c (tui_register_changed): Update.
223
42cc14a7
TT
2242019-08-20 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-regs.c (tui_reg_layout): Move later.
227 (tui_show_registers): Don't enable TUI mode or change layout.
228
b9ad3686
TT
2292019-08-20 Tom Tromey <tom@tromey.com>
230
231 * tui/tui-regs.h (struct tui_data_item_window)
232 <~tui_data_item_window>: Remove.
233 <content>: Now a unique_xmalloc_ptr.
234 * tui/tui-regs.c (tui_register_format): Return a
235 unique_xmalloc_ptr.
236 (tui_get_register): Update.
237 (~tui_data_item_window): Remove.
238 (tui_data_window::display_registers_from, tui_display_register):
239 Update.
240 * tui/tui-io.h (tui_expand_tabs): Update.
241 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
242 Remove "col" parameter.
243
8e114aab
TT
2442019-08-20 Tom Tromey <tom@tromey.com>
245
246 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
247 field.
248 * tui/tui-regs.c (~tui_data_item_window): Update.
249
1a4f81dd
TT
2502019-08-20 Tom Tromey <tom@tromey.com>
251
252 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
253 earlier.
254
0f8d8876
TT
2552019-08-20 Tom Tromey <tom@tromey.com>
256
257 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
258
605dc2c2
TT
2592019-08-20 Tom Tromey <tom@tromey.com>
260
261 * tui/tui-source.h (struct tui_source_window): Update.
262 * tui/tui-regs.c (tui_show_registers): Update.
263 * tui/tui-disasm.h (struct tui_disasm_window): Update.
264 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
265 (NO_REGS_STRING): Remove defines.
266
aedbe3bb
CM
2672019-08-20 Conrad Meyer <cem@FreeBSD.org>
268
269 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
270 unnecessary thread walk if remote doesn't support the packet.
271
7ce8f214
TT
2722019-08-19 Tom Tromey <tromey@adacore.com>
273
274 * python/py-value.c (value_has_field): Fix indentation.
275
f21c2bd7
TT
2762019-08-19 Tom Tromey <tromey@adacore.com>
277
278 * printcmd.c (do_one_display, info_display_command): Update.
279 * block.h (contained_in): Return bool. Add allow_nested
280 parameter.
281 * block.c (contained_in): Return bool. Add allow_nested
282 parameter.
283
d806ea2d
TT
2842019-08-19 Tom Tromey <tom@tromey.com>
285
286 * configure: Rebuild.
287 * configure.ac: Disallow the combination of -static-libstdc++ and
288 source highlight.
289 * source-cache.c (get_language_name): Handle rust.
290 (source_cache::get_source_lines): Ignore highlighting exceptions.
291
398fdd60
TT
2922019-08-16 Tom Tromey <tom@tromey.com>
293
294 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
295 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
296 (struct tui_source_window_base) <make_visible, refresh_window,
297 resize>: Remove methods.
298 <execution_info>: Remove field.
299 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
300 (tui_show_source_line, tui_source_window_base)
301 (~tui_source_window_base): Update.
302 (tui_source_window_base::resize)
303 (tui_source_window_base::make_visible)
304 (tui_source_window_base::refresh_window): Remove.
305 (tui_source_window_base::update_exec_info): Update.
306 * tui/tui-source.c (tui_source_window::set_contents): Update.
307 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
308
e699d331
TT
3092019-08-16 Tom Tromey <tom@tromey.com>
310
311 * tui/tui-hooks.c (tui_remove_hooks): Don't set
312 deprecated_query_hook.
313
bb01dbfc
TT
3142019-08-16 Tom Tromey <tom@tromey.com>
315
316 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
317 (tui_update_source_windows_with_line): Update.
318 * tui/tui-source.h (struct tui_source_window)
319 <show_symtab_source>: Declare.
320 (tui_show_symtab_source): Don't declare.
321 * tui/tui-source.c (tui_show_symtab_source): Rename from
322 tui_show_symtab_source.
323
81c82c4b
TT
3242019-08-16 Tom Tromey <tom@tromey.com>
325
326 * tui/tui-winsource.h (struct tui_source_window_base)
327 <set_contents>: Declare.
328 * tui/tui-winsource.c
329 (tui_source_window_base::update_source_window_as_is): Update.
330 * tui/tui-source.h (struct tui_source_window) <set_contents>:
331 Declare.
332 (tui_set_source_content): Don't declare.
333 * tui/tui-source.c (tui_source_window::set_contents): Rename from
334 tui_set_source_content.
335 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
336 Declare.
337 (tui_set_disassem_content): Don't declare.
338 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
339 tui_set_disassem_content.
340
2ddaf614
TT
3412019-08-16 Tom Tromey <tom@tromey.com>
342
343 * tui/tui-winsource.h (struct tui_source_window_base)
344 <update_breakpoint_info>: Declare.
345 (tui_update_breakpoint_info): Don't declare.
346 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
347 (tui_update_all_breakpoint_info): Update.
348 (tui_source_window_base::update_breakpoint_info): Rename from
349 tui_update_breakpoint_info.
350 (tui_source_window_base::update_exec_info): Update.
351
017f9828
TT
3522019-08-16 Tom Tromey <tom@tromey.com>
353
354 * tui/tui-winsource.h (struct tui_source_window_base)
355 <update_source_window>: Declare.
356 (tui_update_source_window): Don't declare.
357 * tui/tui-winsource.c
358 (tui_source_window_base::update_source_window): Rename from
359 tui_update_source_window.
360 (tui_source_window_base::rerender): Update.
361 * tui/tui-source.c (tui_source_window::maybe_update): Update.
362 * tui/tui-disasm.c (tui_show_disassem)
363 (tui_show_disassem_and_update_source)
364 (tui_disasm_window::maybe_update): Update.
365
ed8358e9
TT
3662019-08-16 Tom Tromey <tom@tromey.com>
367
368 * tui/tui-winsource.h (struct tui_source_window_base)
369 <update_source_window_as_is>: Declare.
370 (tui_update_source_window_as_is): Don't declare.
371 * tui/tui-winsource.c (tui_update_source_window): Update
372 (tui_source_window_base::update_source_window_as_is): Rename from
373 tui_update_source_window_as_is.
374 (tui_source_window_base::refill): Update.
375 * tui/tui-source.c (tui_show_symtab_source): Update.
376 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
377 Update.
378
20149b6b
TT
3792019-08-16 Tom Tromey <tom@tromey.com>
380
381 * tui/tui-winsource.h (tui_update_source_window)
382 (tui_update_source_window_as_is): Remove "noerror" parameter.
383 * tui/tui-winsource.c (tui_update_source_window)
384 (tui_update_source_window_as_is): Remove "noerror" parameter.
385 (tui_update_source_windows_with_addr)
386 (tui_update_source_windows_with_line)
387 (tui_source_window_base::rerender)
388 (tui_source_window_base::refill): Update.
389 * tui/tui-source.h (tui_set_source_content)
390 (tui_show_symtab_source): Remove "noerror" parameter.
391 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
392 parameter.
393 (tui_show_symtab_source): Likewise.
394 (tui_source_window::maybe_update): Update.
395 * tui/tui-disasm.c (tui_show_disassem)
396 (tui_show_disassem_and_update_source)
397 (tui_disasm_window::do_scroll_vertical)
398 (tui_disasm_window::maybe_update): Update.
399
2d83e710
TT
4002019-08-16 Tom Tromey <tom@tromey.com>
401
402 * tui/tui.c (tui_is_window_visible): Update.
403 * tui/tui-wingeneral.c (tui_make_window)
404 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
405 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
406 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
407 (tui_set_win_height_command, parse_scrolling_args): Update.
408 * tui/tui-source.c (tui_source_window::style_changed): Update.
409 * tui/tui-regs.c (tui_show_registers)
410 (tui_data_window::first_data_item_displayed)
411 (tui_data_window::delete_data_content_windows)
412 (tui_check_register_values, tui_reg_command): Update.
413 * tui/tui-disasm.c (tui_show_disassem): Update.
414 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
415 method.
416 <is_visible>: Remove field.
417 * tui/tui-data.c (tui_next_win, tui_prev_win)
418 (tui_delete_invisible_windows): Update.
419
d4ab829a
TT
4202019-08-16 Tom Tromey <tom@tromey.com>
421
422 * tui/tui-winsource.h (struct tui_source_window_base)
423 <m_has_locator>: Remove.
424 * tui/tui-layout.c (show_source_disasm_command, show_data)
425 (show_source_or_disasm_and_command): Update.
426
aa7ca1bb
AH
4272019-08-16 Alan Hayward <alan.hayward@arm.com>
428
429 * NEWS (Other MI changes): New subsection.
430 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
431 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
432 * arch-utils.c (default_get_pc_address_flags): New function.
433 * arch-utils.h (default_get_pc_address_flags): New declaration.
434 * gdbarch.sh: Add get_pc_address_flags.
435 * gdbarch.c: Regenerate.
436 * gdbarch.h: Likewise.
437 * stack.c (print_pc): New function.
438 (print_frame_info) (print_frame): Call print_pc.
439
6eac171f
TV
4402019-08-16 Tom de Vries <tdevries@suse.de>
441
442 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
443 print_objfile_section_info.
444
3df505f6
TT
4452019-08-15 Tom Tromey <tom@tromey.com>
446
447 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
448 calling update_cmdwin_start_line.
449 * tui/tui-winsource.h (struct tui_source_window_base)
450 <do_make_visible_with_new_height, set_new_height>: Don't declare.
451 <rerender>: Declare.
452 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
453 Call rerender.
454 (tui_source_window_base::set_new_height): Remove.
455 (tui_source_window_base::rerender): Rename from
456 do_make_visible_with_new_height.
457 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
458 resize method.
459 (tui_win_info::make_invisible_and_set_new_height)
460 (tui_win_info::make_visible_with_new_height): Remove.
461 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
462 Declare.
463 * tui/tui-stack.c (tui_locator_window::rerender): New method.
464 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
465 do_make_visible_with_new_height>: Don't declare.
466 <rerender>: Declare.
467 * tui/tui-regs.c (tui_data_window::rerender): Rename from
468 set_new_height.
469 (tui_data_window::do_make_visible_with_new_height): Remove.
470 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
471 call tui_show_locator_content.
472 (tui_gen_win_info::resize): Call rerender.
473 (show_source_or_disasm_and_command): Don't call
474 tui_show_locator_content.
475 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
476 method.
477 (struct tui_win_info) <rerender>: Declare.
478 <set_new_height, make_invisible_and_set_new_height,
479 make_visible_with_new_height>: Don't declare.
480 * tui/tui-data.c (tui_win_list::rerender): New method.
481 * tui/tui-command.h (struct tui_cmd_window)
482 <do_make_visible_with_new_height>: Don't declare.
483 * tui/tui-command.c
484 (tui_cmd_window::do_make_visible_with_new_height): Remove.
485
272560b5
TT
4862019-08-15 Tom Tromey <tromey@adacore.com>
487
488 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
489 * ada-lang.c (ada_enum_name): Likewise.
490
08235187
CB
4912019-08-15 Christian Biesinger <cbiesinger@google.com>
492
493 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
494 leading underscore.
495 (GdbOutputErrorFile): Likewise.
496 (global scope): Adjust constructor calls to GdbOutput{,Error}File
497 accordingly.
498 (execute_unwinders): Rename to have a leading underscore.
499 (auto_load_packages): Likewise.
500 (global scope): Adjust call to auto_load_packages accordingly.
501 (GdbSetPythonDirectory): Likewise.
502 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
503 instead of execute_unwinders.
504
db502012
TT
5052019-08-15 Tom Tromey <tom@tromey.com>
506
507 * tui/tui-layout.c (show_layout, show_source_disasm_command)
508 (show_data): Don't change window visibility.
509 (tui_gen_win_info::resize): Remove special case for command
510 window. Use wresize, when available.
511 (show_source_or_disasm_and_command): Don't change window
512 visibility.
513 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
514 <make_visible>: New method.
515 * tui/tui-command.c (tui_cmd_window::resize): New method.
516
3891b65e
TT
5172019-08-15 Tom Tromey <tom@tromey.com>
518
519 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
520 (struct tui_source_windows): New.
521 * tui/tui-winsource.c (tui_display_main): Update.
522 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
523 (new_height_ok, parse_scrolling_args): Update.
524 * tui/tui-layout.c (show_layout, show_data): Update.
525 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
526 (tui_add_to_source_windows): Don't declare.
527 * tui/tui-data.c (source_windows, tui_source_windows)
528 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
529
ee556432
TT
5302019-08-15 Tom Tromey <tom@tromey.com>
531
532 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
533 Rename from reset.
534 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
535 * tui/tui-layout.c (show_source_disasm_command, show_data):
536 Update.
537 (tui_gen_win_info::resize): Rename.
538 (show_source_or_disasm_and_command): Update.
539 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
540 reset.
541
46f438e3
TT
5422019-08-15 Tom Tromey <tom@tromey.com>
543
544 * tui/tui-stack.c (tui_initialize_static_data): Remove.
545 * tui/tui-interp.c (tui_interp::init): Don't call
546 tui_initialize_static_data.
547 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
548
f4ce562c
TT
5492019-08-15 Tom Tromey <tom@tromey.com>
550
551 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
552 examine tui_win_list.
553
c398c3d0
TT
5542019-08-15 Tom Tromey <tom@tromey.com>
555
556 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
557 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
558 tui_clear_source_content.
559 (tui_clear_source_content): Remove.
560 (tui_source_window_base::do_erase_source_content): Hoist call to
561 content.clear().
562 * tui/tui-stack.c (tui_show_frame_info): Don't call
563 tui_clear_source_content.
564
e25d2004
TT
5652019-08-15 Tom Tromey <tom@tromey.com>
566
567 * tui/tui-winsource.h (struct tui_source_window_base)
568 <do_erase_source_content>: New method.
569 <erase_source_content>: New method.
570 (tui_erase_source_content): Don't declare.
571 * tui/tui-winsource.c (tui_clear_source_content): Update.
572 (tui_source_window_base::do_erase_source_content): Rename from
573 tui_erase_source_content.
574 (tui_source_window_base::show_source_content): Update.
575 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
576 * tui/tui-source.h (struct tui_source_window)
577 <erase_source_content>: New method.
578 * tui/tui-disasm.h (struct tui_disasm_window)
579 <erase_source_content>: New method.
580
002f15c2
TT
5812019-08-15 Tom Tromey <tom@tromey.com>
582
583 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
584 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
585 constructor.
586 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
587 * tui/tui-source.c (tui_set_source_content): Update.
588 * tui/tui-disasm.c (tui_set_disassem_content): Update.
589
c9033fe8
TT
5902019-08-15 Tom Tromey <tom@tromey.com>
591
592 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
593 * tui/tui-winsource.c (tui_line_is_displayed): Move to
594 tui-source.c.
595 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
596 Declare.
597 * tui/tui-source.c (tui_source_window::line_is_displayed): New
598 method.
599 (tui_source_window::maybe_update): Update.
600
088f37dd
TT
6012019-08-15 Tom Tromey <tom@tromey.com>
602
603 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
604 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
605 tui-disasm.c.
606 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
607 Declare.
608 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
609 method.
610 (tui_disasm_window::maybe_update): Update.
611
a54700c6
TT
6122019-08-15 Tom Tromey <tom@tromey.com>
613
614 * tui/tui-winsource.h (struct tui_source_window_base)
615 <maybe_update>: Declare.
616 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
617 method.
618 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
619 Declare.
620 * tui/tui-source.c (tui_source_window::maybe_update): New method.
621 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
622 Declare.
623 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
624
e2a678a5
TT
6252019-08-15 Tom Tromey <tom@tromey.com>
626
627 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
628
f2dda477
TT
6292019-08-15 Tom Tromey <tom@tromey.com>
630
631 * tui/tui-wingeneral.c: Include tui-stack.h.
632 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
633 (struct tui_locator_window): Move from tui-data.h.
634 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
635 (tui_initialize_static_data): Move from tui-data.c.
636 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
637 (struct tui_locator_window): Move to tui-stack.c.
638 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
639 (tui_initialize_static_data): Move to tui-stack.c.
640
ed4a1084
TT
6412019-08-15 Tom Tromey <tom@tromey.com>
642
643 * tui/tui-layout.c (show_source_disasm_command)
644 (show_source_or_disasm_and_command): Use make_visible method, not
645 tui_make_window.
646 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
647 Remove.
648
65962b20
TT
6492019-08-15 Tom Tromey <tom@tromey.com>
650
651 * tui/tui-wingeneral.h (tui_make_window): Update.
652 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
653 parameter.
654 (tui_gen_win_info::make_visible): Update.
655 * tui/tui-regs.c (tui_data_window::display_registers_from):
656 Update.
657 * tui/tui-layout.c (show_source_disasm_command)
658 (show_source_or_disasm_and_command): Update.
659 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
660 (enum tui_box): Remove.
661 (struct tui_win_info) <can_box>: New method.
662 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
663 method.
664
2208ee91
TV
6652019-08-15 Tom de Vries <tdevries@suse.de>
666
667 * linux-nat-trad.c: Include gdbarch.h.
668
75faf5c4
AH
6692019-08-14 Alan Hayward <alan.hayward@arm.com>
670
671 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
672 register sizes.
673
b1c896b3
TT
6742019-08-14 Tom Tromey <tromey@adacore.com>
675
676 * darwin-nat.c: Include gdbarch.h.
677 * darwin-nat-info.c: Include gdbarch.h.
678
6405cd73
TT
6792019-08-13 Tom Tromey <tom@tromey.com>
680
681 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
682 Remove.
683 * tui/tui-data.c (tui_initialize_static_data): Update.
684
5216580d
TT
6852019-08-13 Tom Tromey <tom@tromey.com>
686
687 * tui/tui-winsource.h (struct tui_exec_info_window)
688 <~tui_exec_info_window, maybe_allocate_content, get_content,
689 m_content>: Remove.
690 (struct tui_source_window_base) <set_exec_info_content,
691 show_exec_info_content>: Don't declare.
692 * tui/tui-winsource.c
693 (tui_exec_info_window::maybe_allocate_content): Remove.
694 (tui_source_window_base::update_exec_info): Rename from
695 set_exec_info_content.
696 (tui_source_window_base::show_exec_info_content)
697 (tui_source_window_base::update_exec_info): Remove.
698
93858ad3
TT
6992019-08-13 Tom Tromey <tom@tromey.com>
700
701 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
702 declare.
703 * tui/tui-winsource.c (tui_update_source_window_as_is)
704 (tui_update_source_windows_with_addr, tui_erase_source_content):
705 Update.
706 (tui_clear_exec_info_content): Remove.
707
e321e7ce
TT
7082019-08-13 Tom Tromey <tom@tromey.com>
709
710 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
711 declare.
712 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
713 call tui_erase_exec_info_content.
714 (tui_clear_exec_info_content): Rename from
715 tui_erase_exec_info_content.
716 (tui_clear_exec_info_content): Delete.
717
8270ac62
TT
7182019-08-13 Tom Tromey <tom@tromey.com>
719
720 * tui/tui-winsource.h (struct tui_source_window_base)
721 <show_exec_info_content>: Declare.
722 (tui_show_exec_info_content): Don't declare.
723 * tui/tui-winsource.c
724 (tui_source_window_base::show_exec_info_content): Rename from
725 tui_show_exec_info_content.
726 (tui_source_window_base::update_exec_info): Update.
727
7b56485d
TT
7282019-08-13 Tom Tromey <tom@tromey.com>
729
730 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
731 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
732 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
733 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
734 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
735 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
736 ... here.
737
7ba913dc
TT
7382019-08-13 Tom Tromey <tom@tromey.com>
739
740 * tui/tui-winsource.h (struct tui_source_window_base)
741 <update_exec_info>: Declare.
742 (tui_update_exec_info): Don't declare.
743 * tui/tui-winsource.c (tui_update_source_window_as_is)
744 (tui_source_window_base::refresh_all)
745 (tui_update_all_breakpoint_info): Update.
746 (tui_source_window_base::update_exec_info): Rename from
747 tui_update_exec_info.
748 * tui/tui-stack.c (tui_show_frame_info): Update.
749
37a4a131
TT
7502019-08-13 Tom Tromey <tom@tromey.com>
751
752 * tui/tui-winsource.h (struct tui_source_window_base)
753 <set_exec_info_content>: Declare.
754 (tui_set_exec_info_content): Don't declare.
755 * tui/tui-winsource.c
756 (tui_source_window_base::set_exec_info_content): Rename from
757 tui_set_exec_info_content.
758 (tui_update_exec_info): Update.
759
0bd27e07
TT
7602019-08-13 Tom Tromey <tom@tromey.com>
761
762 * tui/tui-winsource.h (struct tui_source_window_base)
763 <show_source_content>: Declare.
764 (tui_show_source_content): Don't declare.
765 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
766 (tui_source_window_base::show_source_content): Rename from
767 tui_show_source_content.
768 (tui_source_window_base::refresh_all): Update.
769 * tui/tui-layout.c (show_source_disasm_command)
770 (show_source_or_disasm_and_command): Update.
771
b4ef5aeb
TT
7722019-08-13 Tom Tromey <tom@tromey.com>
773
774 * tui/tui-winsource.c (tui_erase_source_content)
775 (tui_show_source_content, tui_source_window_base::refresh_all):
776 Update.
777 * tui/tui-wingeneral.h
778 (tui_check_and_display_highlight_if_needed): Don't declare.
779 * tui/tui-wingeneral.c
780 (tui_win_info::check_and_display_highlight_if_needed): Rename from
781 check_and_display_highlight_if_needed.
782 * tui/tui-win.c (tui_rehighlight_all)
783 (tui_win_info::make_visible_with_new_height): Update.
784 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
785 (tui_data_window::erase_data_content)
786 (tui_data_window::display_all_data): Update.
787 * tui/tui-data.h (struct tui_win_info)
788 <check_and_display_highlight_if_needed>: Declare.
789
fede5273
TT
7902019-08-13 Tom Tromey <tom@tromey.com>
791
792 * tui/tui-win.c (tui_resize_all): Call
793 tui_delete_invisible_windows.
794 * tui/tui-layout.c (show_layout): Call
795 tui_delete_invisible_windows.
796 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
797 * tui/tui-data.c (tui_delete_invisible_windows): New function.
798
22c3f490
TT
7992019-08-13 Tom Tromey <tom@tromey.com>
800
801 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
802 tui_add_win_to_layout.
803
16cb7910
TT
8042019-08-13 Tom Tromey <tom@tromey.com>
805
806 * tui/tui-layout.h (tui_default_win_height): Don't declare.
807 * tui/tui-layout.c (tui_default_win_height): Now static.
808
cc0c3ffb
TT
8092019-08-13 Tom Tromey <tom@tromey.com>
810
811 * tui/tui-layout.c (show_layout): Unify all layout cases into a
812 single switch.
813 (show_source_disasm_command, show_source_or_disasm_and_command):
814 Don't check current layout.
815
3f3ffe54
TT
8162019-08-13 Tom Tromey <tom@tromey.com>
817
818 * tui/tui-wingeneral.c (make_all_visible): Remove.
819 (tui_make_all_invisible): Simplify.
820 * tui/tui-layout.c (tui_make_all_invisible): Move from
821 tui-wingeneral.c; simplify.
822 (show_layout): Hoist call to tui_make_all_invisible.
823 (show_data): Don't call tui_make_all_invisible.
824
69258091
TT
8252019-08-13 Tom Tromey <tom@tromey.com>
826
827 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
828 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
829
62cf57fe
TT
8302019-08-13 Tom Tromey <tom@tromey.com>
831
832 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
833 tui-data.c.
834 (show_source_disasm_command, show_data)
835 (show_source_or_disasm_and_command): Don't use
836 tui_set_current_layout_to.
837 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
838 * tui/tui-data.c (current_layout, tui_current_layout): Move to
839 tui-layout.c.
840 (tui_set_current_layout_to): Remove.
841
2afade5d
TT
8422019-08-13 Tom Tromey <tom@tromey.com>
843
844 * tui/tui-layout.c (tui_set_layout): Update.
845 * tui/tui-data.h (struct tui_layout_def): Remove.
846 (tui_layout_def): Don't declare.
847 * tui/tui-data.c (layout_def): Remove.
848 (tui_layout_def): Remove.
849
a3504e96
TT
8502019-08-13 Tom Tromey <tom@tromey.com>
851
852 * tui/tui-winsource.h (struct tui_source_window_base)
853 <clear_detail>: No longer "override".
854 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
855 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
856 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
857 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
858 Remove.
859 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
860
29c92911
TT
8612019-08-13 Tom Tromey <tromey@adacore.com>
862
863 * tracepoint.c: Don't include readline.h or history.h.
864
86c6b807
TT
8652019-08-12 Tom Tromey <tom@tromey.com>
866
867 * configure: Rebuild.
868 * configure.ac: Check for readline 7.
869 * NEWS: Mention readline 7 requirement.
870 * README: Update.
871
5db2718c
TT
8722019-08-12 Tom Tromey <tom@tromey.com>
873
874 * mingw-hdep.c (gdb_select): Remove readline hack.
875
dac36daf
PFC
8762019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
877
878 * blockframe.c (find_pc_partial_function): Set *block to nullptr
879 when the function fails.
880
1022c627
AA
8812019-08-09 Andreas Arnez <arnez@linux.ibm.com>
882
883 * s390-tdep.c (s390_type_align): New function.
884 (s390_gdbarch_init): Set it as type_align gdbarch method.
885
eba4caf2
TV
8862019-08-09 Tom de Vries <tdevries@suse.de>
887
888 PR gdb/24591
889 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
890 pc_low with relocation offset.
891
123cd851
TT
8922019-08-07 Tom Tromey <tromey@adacore.com>
893
894 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
895 (print_frame_args): Update.
896 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
897 Update.
898 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
899 * frame.h (struct frame_arg): Add initializers.
900 <error>: Now a unique_xmalloc_ptr.
901
3d31bc39
AH
9022019-08-07 Alan Hayward <alan.hayward@arm.com>
903
904 * NEWS: Expand the Pointer Authentication entry.
905 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
906 (aarch64_frame_unmask_lr): ... to this.
907 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
908 Call aarch64_frame_unmask_lr.
909 * frame.c (struct frame_info): Add "masked" variable.
910 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
911 (fprint_frame): Check for masked pc.
912 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
913 declarations.
914 * python/py-framefilter.c (py_print_frame): Check for masked pc.
915 * stack.c (print_frame): Check for masked pc.
916
0cf9feb9
TT
9172019-08-06 Tom Tromey <tom@tromey.com>
918
919 * stabsread.c (patch_block_stabs, read_one_struct_field)
920 (read_enum_type): Use obstack_strndup.
921 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
922 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
923 * dwarf2read.c (guess_full_die_structure_name)
924 (anonymous_struct_prefix): Use obstack_strndup.
925 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
926 * c-exp.y (yylex): Use obstack_strndup.
927 * ada-exp.y (write_object_renaming, write_ambiguous_var)
928 (write_var_or_type): Use obstack_strndup.
929
efba19b0
TT
9302019-08-06 Tom Tromey <tom@tromey.com>
931
932 * symfile.c (reread_symbols): Use obstack_strdup.
933 * stabsread.c (read_type): Use obstack_strdup.
934 * gdb_obstack.h (obstack_strdup): New overload.
935 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
936 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
937 (dwarf2_canonicalize_name): Use obstack_strdup.
938 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
939 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
940 Use obstack_strdup.
941
f25102f7
TT
9422019-08-06 Tom Tromey <tom@tromey.com>
943
944 * gdb_obstack.h (obstack_strdup): Define.
945 * gdb_obstack.c (obstack_strdup): Don't define.
946
021887d8
TT
9472019-08-06 Tom Tromey <tom@tromey.com>
948
949 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
950 obstack_strdup.
951 * typeprint.c (typedef_hash_table::find_global_typedef): Use
952 obstack_strdup.
953 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
954 * stabsread.c (common_block_start): Use obstack_strdup.
955 * objfiles.c (set_objfile_main_name, objfile): Use
956 obstack_strdup.
957 * namespace.c (add_using_directive): Use obstack_strdup.
958 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
959 * jit.c (finalize_symtab): Use obstack_strdup.
960 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
961 (guess_partial_die_structure_name, partial_die_info::fixup)
962 (dwarf2_name): Use obstack_strdup.
963 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
964 obstack_strdup.
965 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
966 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
967 obstack_strdup.
968 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
969
d2834edc
PW
9702019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
971
972 * unittests/help-doc-selftests.c: New file.
973 * Makefile.in: Add the new file.
974
590042fc
PW
9752019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
976
977 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
978 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
979 the full first line, except when FOR_VALUE_PREFIX. In this case,
980 the trailing '.' is not output, and the first character is uppercased.
981 (print_help_for_command): Update call to print_doc_line.
982 (print_doc_of_command): Likewise.
983 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
984 * cli/cli-option.c (append_indented_doc): Do not append newline.
985 (build_help_option): Append newline after first appended_indented_doc
986 only if a second call is done.
987 (build_help): Append 2 new lines before each option, except the first
988 one.
989 * compile/compile.c (_initialize_compile): Add new lines after
990 %OPTIONS%, when not at the end of the help.
991 Change help doc or code
992 producing the help doc to respect the invariants.
993 * maint-test-options.c (_initialize_maint_test_options): Likewise.
994 Also removed the new line after 'Options:', as all other commands
995 do not put an empty line between 'Options:' and the first option.
996 * printcmd.c (_initialize_printcmd): Likewise.
997 * stack.c (_initialize_stack): Likewise.
998 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
999 incorrectly telling COMMAND is optional.
1000 * ada-lang.c (_initialize_ada_language): Change help doc or code
1001 producing the help doc to respect the invariants.
1002 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1003 * breakpoint.c (_initialize_breakpoint): Likewise.
1004 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1005 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1006 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1007 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1008 _initialize_cli_style): Likewise.
1009 * corelow.c (core_target_info): Likewise.
1010 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1011 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1012 * filesystem.c (_initialize_filesystem): Likewise.
1013 * frame.c (_initialize_frame): Likewise.
1014 * gnu-nat.c (add_task_commands): Likewise.
1015 * infcall.c (_initialize_infcall): Likewise.
1016 * infcmd.c (_initialize_infcmd): Likewise.
1017 * interps.c (_initialize_interpreter): Likewise.
1018 * language.c (_initialize_language): Likewise.
1019 * linux-fork.c (_initialize_linux_fork): Likewise.
1020 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1021 * maint.c (_initialize_maint_cmds): Likewise.
1022 * memattr.c (_initialize_mem): Likewise.
1023 * printcmd.c (_initialize_printcmd): Likewise.
1024 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1025 _RegEx): Likewise.
1026 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1027 * record-btrace.c (_initialize_record_btrace): Likewise.
1028 * record-full.c (_initialize_record_full): Likewise.
1029 * record.c (_initialize_record): Likewise.
1030 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1031 * regcache.c (_initialize_regcache): Likewise.
1032 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1033 _initialize_remote): Likewise.
1034 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1035 * serial.c (_initialize_serial): Likewise.
1036 * skip.c (_initialize_step_skip): Likewise.
1037 * source.c (_initialize_source): Likewise.
1038 * stack.c (_initialize_stack): Likewise.
1039 * symfile.c (_initialize_symfile): Likewise.
1040 * symtab.c (_initialize_symtab): Likewise.
1041 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1042 * top.c (init_main): Likewise.
1043 * tracefile-tfile.c (tfile_target_info): Likewise.
1044 * tracepoint.c (_initialize_tracepoint): Likewise.
1045 * tui/tui-win.c (_initialize_tui_win): Likewise.
1046 * utils.c (add_internal_problem_command): Likewise.
1047 * valprint.c (value_print_option_defs): Likewise.
1048
404f2902
FCE
10492019-08-06 Frank Ch. Eigler <fche@redhat.com>
1050
1051 PR build/24886
1052 * configure.ac: Drop enable-libmcheck support.
1053 * configure, config.in: Rebuild.
1054 * libmcheck.m4: Remove.
1055 * acinclude.m4: Don't include it.
1056 * Makefile.in: Don't distribute it.
1057 * top.c (print_gdb_configuration): Don't mention it.
1058
046bebe1
TT
10592019-08-06 Tom Tromey <tom@tromey.com>
1060
1061 * utils.c (set_output_style): Sometimes pass stream to
1062 emit_style_escape.
1063 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1064 * record-btrace.c (btrace_insn_history): Update.
1065 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1066 method.
1067 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1068 Update initializers.
1069 <m_uiout>: New field.
1070 <m_di>: Move lower.
1071 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1072 Remove "uiout" parameter.
1073 (dump_insns): Update.
1074 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1075 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1076
ddbcedf5
CB
10772019-08-06 Christian Biesinger <cbiesinger@google.com>
1078
1079 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1080 (error_in_psymtab_expansion): Likewise.
1081 (lookup_symbol_via_quick_fns): Likewise.
1082 (basic_lookup_transparent_type_quick): Likewise.
1083 (basic_lookup_transparent_type_1): Likewise.
1084
b08b16c8
TT
10852019-08-06 Tom Tromey <tromey@adacore.com>
1086
1087 * source.c (last_source_error): Now bool.
1088 (print_source_lines_base): Make "noprint" bool. Only open
1089 source file when last_source_visited changes.
1090
cb44333d
TT
10912019-08-06 Tom Tromey <tromey@adacore.com>
1092
1093 * annotate.c (annotate_source_line): Use g_source_cache.
1094 * source-cache.c (source_cache::get_plain_source_lines): Change
1095 parameters. Populate m_offset_cache.
1096 (source_cache::ensure): New method.
1097 (source_cache::get_line_charpos): New method.
1098 (extract_lines): Move lower. Change parameters.
1099 (source_cache::get_source_lines): Move lower.
1100 * source-cache.h (class source_cache): Update comment.
1101 <get_line_charpos>: New method.
1102 <get_source_lines>: Update comment.
1103 <clear>: Clear m_offset_cache.
1104 <get_plain_source_lines>: Change parameters.
1105 <ensure>: New method
1106 <m_offset_cache>: New member.
1107 * source.c (forget_cached_source_info_for_objfile): Update.
1108 (info_source_command): Use g_source_cache.
1109 (find_source_lines, open_source_file_with_line_charpos): Remove.
1110 (print_source_lines_base, search_command_helper): Use g_source_cache.
1111 * source.h (open_source_file_with_line_charpos): Don't declare.
1112 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1113 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1114 Use g_source_cache.
1115
872dceaa
TT
11162019-08-06 Tom Tromey <tromey@adacore.com>
1117
1118 * source-cache.c (source_cache::get_plain_source_lines):
1119 Remove "first_line" and "last_line" parameters.
1120 (source_cache::get_source_lines): Cache plain text.
1121 * source-cache.h (class source_cache)
1122 <get_plain_source_lines>: Update.
1123
269249d9
TT
11242019-08-06 Tom Tromey <tromey@adacore.com>
1125
1126 * source-cache.c (extract_lines): No longer a method.
1127 Changed type of parameter. Include final newline.
1128 (selftests::extract_lines_test): New function.
1129 (_initialize_source_cache): Likewise.
1130 * source-cache.h (class source_cache)
1131 <extract_lines>: Don't declare.
1132
c0e8dcd8
TT
11332019-08-06 Tom Tromey <tromey@adacore.com>
1134
1135 * breakpoint.c (init_breakpoint_sal): Update.
1136 (breakpoint): Update.
1137 * breakpoint.h (struct breakpoint) <filter>: Now a
1138 unique_xmalloc_ptr.
1139
0b27c27d
CB
11402019-08-05 Christian Biesinger <cbiesinger@google.com>
1141
1142 * NEWS: Mention dictionary access on blocks.
1143 * python/py-block.c (blpy_getitem): New function.
1144 (block_object_as_mapping): New struct.
1145 (block_object_type): Use new struct for tp_as_mapping field.
1146
4ee94178
CB
11472019-08-05 Christian Biesinger <cbiesinger@google.com>
1148
1149 * objfiles.h (objfile): Add a comment describing partial symbols.
1150
8abfcabc
TT
11512019-08-05 Tom Tromey <tromey@adacore.com>
1152
1153 * compile/compile.c (_initialize_compile): Use _(), not N_().
1154 * thread.c (_initialize_thread): Use _(), not N_().
1155 * stack.c (_initialize_stack): Use _(), not N_().
1156 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1157
2b79f376
SM
11582019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1159
1160 * dwarf2read.c (struct dw2_symtab_iterator):
1161 <want_specific_block>: Remove.
1162 <block_index>: Change type to gdb::optional.
1163 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1164 change type of BLOCK_INDEX parameter to gdb::optional.
1165 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1166 (dw2_lookup_symbol): Don't pass argument for
1167 WANT_SPECIFIC_BLOCK.
1168 (dw2_expand_symtabs_for_function): Don't pass argument for
1169 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1170 (class dw2_debug_names_iterator)
1171 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1172 parameter, change BLOCK_INDEX type to gdb::optional.
1173 <m_want_specific_block>: Remove.
1174 <m_block_index>: Change type to gdb::optional.
1175 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1176 gdb::optional. Re-write in function of gdb::optional.
1177 (dw2_debug_names_lookup_symbol): Don't pass argument for
1178 WANT_SPECIFIC_BLOCK.
1179 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1180 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1181 BLOCK_INDEX.
1182
ae60f04e
PW
11832019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1184
1185 * NEWS: Mention changes to "info sources" command.
1186
28cd9371
PW
11872019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1188
1189 * symtab.c (filename_partial_match_opts): New struct type.
1190 (struct output_source_filename_data): New members
1191 regexp, c_regexp, partial_match.
1192 (output_source_filename): Use new members to decide to print file.
1193 (info_sources_option_defs): New variable.
1194 (make_info_sources_options_def_group, print_info_sources_header,
1195 info_sources_command_completer):
1196 New functions.
1197 (info_sources_command): Read new optional arguments.
1198 (_initialize_symtab): Update info sources help.
1199
ca683e3a
AO
12002019-08-02 Alexandre Oliva <oliva@adacore.com>
1201
1202 * ada-lang.c (exception_support_info_v0): Renamed from...
1203 (default_exception_support_info): ... this. Create new
1204 definition for v1.
1205 (ada_has_this_exception_support): Look up catch_handlers_sym.
1206 (ada_exception_support_info_sniffer): Try v0 after default.
1207
f1264162
TT
12082019-08-01 Tom Tromey <tromey@adacore.com>
1209
1210 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1211 gdbarch.h.
1212
0a7b2485
CB
12132019-08-01 Christian Biesinger <cbiesinger@google.com>
1214
1215 * s12z-tdep.c: Fix include path for s12z-opc.h.
1216
c6bdbeb7
AH
12172019-08-01 Alan Hayward <alan.hayward@arm.com>
1218
1219 * NEWS: Require GNU make 3.82.
1220
a2bd7b82
TT
12212019-07-16 Tom Tromey <tom@tromey.com>
1222
1223 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1224 declare.
1225
aa3b6533
TT
12262019-07-30 Tom Tromey <tromey@adacore.com>
1227
1228 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1229
a1530dc7
KB
12302019-07-30 Kevin Buettner <kevinb@redhat.com>
1231
1232 * printcmd.c (print_address_symbolic): Print negative offsets.
1233 (build_address_symbolic): Force signed arithmetic when computing
1234 offset.
1235
2906593f
CB
12362019-07-30 Christian Biesinger <cbiesinger@google.com>
1237
1238 PR/24474: Add a function to lookup static variables.
1239 * NEWS: Mention this new function.
1240 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1241 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1242 * python/python.c (python_GdbMethods): Add new function.
1243
c620ed88
CB
12442019-07-29 Christian Biesinger <cbiesinger@google.com>
1245
1246 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1247 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1248 (objfpy_lookup_static_symbol): New function.
1249 (objfile_object_methods): Add new functions.
1250
bc4268a5
PW
12512019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1252
1253 * NEWS: Mention 'set|show print frame-info'. Mention new
1254 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1255 backtrace argument. Mention that python frame filtering code
1256 is now consistent with what 'backtrace' command prints.
1257
4b5e8d19
PW
12582019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1259
1260 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1261 comments.
1262 (print_frame_info_auto, print_frame_info_source_line,
1263 print_frame_info_location, print_frame_info_source_and_location,
1264 print_frame_info_location_and_address, print_frame_info_short_location):
1265 New declarations.
1266 (struct frame_print_options): New member print_frame_info.
1267 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1268 * stack.h (get_user_print_what_frame_info): New declaration.
1269 (frame_show_address): New declaration.
1270 * stack.c (print_frame_arguments_choices): New value 'presence'.
1271 (print_frame_info_auto, print_frame_info_source_line,
1272 print_frame_info_location, print_frame_info_source_and_location,
1273 print_frame_info_location_and_address, print_frame_info_short_location,
1274 print_frame_info_choices, print_frame_info_print_what): New definitions.
1275 (print_frame_args): Only print dots for args if print frame-arguments
1276 is 'presence'.
1277 (frame_print_option_defs): New element for "frame-info".
1278 (get_user_print_what_frame_info): New function.
1279 (frame_show_address): Make non static. Move comment to stack.h.
1280 (print_frame_info_to_print_what): New function.
1281 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1282 to decide what to print.
1283 (backtrace_command_1): Handle the new print_frame_arguments_presence
1284 value.
1285 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1286 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1287 (py_print_frame): In non-mi mode, use LOCATION as default for
1288 print_what, similarly to frame information printed directly by
1289 backtrace command. Handle frame-info user option in non MI mode.
1290
6bdfee81
KB
12912019-07-27 Kevin Buettner <kevinb@redhat.com>
1292
1293 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1294 Add case for debugging 32-bit target on 64-bit host. Revise
1295 comment.
1296
98a617f8
KB
12972019-07-27 Kevin Buettner <kevinb@redhat.com>
1298
1299 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1300 instead of find_function_entry_range_from_pc.
1301
567238c9
KB
13022019-07-27 Kevin Buettner <kevinb@redhat.com>
1303
1304 * stack.c (find_frame_funname): Remove code which preferred
1305 minsym over symtab sym in "certain pathological cases".
1306
2dc80cf8
KB
1307 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1308 parameter. Change type of "do_demangle" to bool.
1309 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1310 Pass suitable "prefer_sym_over_minsym" flag to
1311 build_address_symbolic(). Don't output "+" for negative offsets.
1312 * printcmd.c (print_address_symbolic): Update invocation of
1313 build_address_symbolic to include a "prefer_sym_over_minsym"
1314 flag.
1315 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1316 Restrict cases in which use of minimal symbol is preferred to that
1317 of a found symbol. Update comments.
1318
1aff7173
KB
1319 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1320 for entry pc when entry pc is out of range for that FDE.
1321
89b085ac
BC
13222019-07-26 Brian Callahan <bcallah@openbsd.org>
1323
1324 PR gdb/24839:
1325 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1326 type.
1327
f32feb4a
CB
13282019-07-25 Christian Biesinger <cbiesinger@google.com>
1329
1330 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1331 this function's Python signature.
1332
1333
13342019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1335
1336 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1337 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1338 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1339 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1340 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1341
1342
c54e4253
YS
13432019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1344
1345 * h8300-tdep.c (h8300_register_name_common): New.
1346 h8300_register_name): Use h8300_register_name_common.
1347 (h8300s_register_name): Likewise.
1348 (h8300sx_register_name): Likewise.
1349 (h8300h_register_nam): New.
1350 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1351
1352
40eadf04
SP
13532019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1354
1355 * arm-tdep.c (arm_skip_cmse_entry): New function.
1356 (arm_is_sgstubs_section): New function.
1357 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1358
bfa2a36d
TT
13592019-07-22 Tom Tromey <tom@tromey.com>
1360
1361 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1362 Don't self-assign.
1363
a8e9d247
AB
13642019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1365
1366 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1367 type_print.
1368
eb86c5e2
AB
13692019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1370
1371 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1372 so that GDB doesn't match any msymbols when searching in the
1373 TYPES_DOMAIN.
1374 (print_symbol_info): Print using typedef_print or type_print based
1375 on the type of the symbol. Add updated FIXME comment moved from...
1376 (_initialize_symtab): ... move and update FIXME comment to above.
1377
a8eab7c6
AB
13782019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1379
1380 * NEWS: Mention adding -q option to "info types".
1381 * symtab.c (struct info_types_options): New struct.
1382 (info_types_options_defs): New variable.
1383 (make_info_types_options_def_group): New function.
1384 (info_types_command): Use gdb::option framework to parse options.
1385 (info_types_command_completer): New function.
1386 (_initialize_symtab): Extend the help text on "info types" and
1387 register command completer.
1388
b4603c34
CB
13892019-07-21 Christian Biesinger <cbiesinger@google.com>
1390
1391 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1392 (lookup_symbol_in_objfile): Change int to block_enum and add a
1393 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1394
c8cdc1e0
CB
13952019-07-20 Christian Biesinger <cbiesinger@google.com>
1396
1397 * MAINTAINERS (Write After Approval): Add self.
1398
01e175fe
AB
13992019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1400
1401 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1402 instruction to the dummy code region.
1403
56f79b63
TT
14042019-07-19 Tom Tromey <tromey@adacore.com>
1405
1406 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1407 (ARGSUSED, PARAMS, __func__): Remove rules.
1408
4c5aa8e0
AH
14092019-07-19 Alan Hayward <alan.hayward@arm.com>
1410
1411 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1412 * features/arm/arm-with-iwmmxt.c: Remove.
1413 * features/arm/arm-with-iwmmxt.xml: Remove.
1414 * features/arm/arm-with-m-fpa-layout.c: Remove.
1415 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1416 * features/arm/arm-with-m-vfp-d16.c: Remove.
1417 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1418 * features/arm/arm-with-m.c: Remove.
1419 * features/arm/arm-with-m.xml: Remove.
1420 * features/arm/arm-with-neon.c: Remove.
1421 * features/arm/arm-with-neon.xml: Remove.
1422 * features/arm/arm-with-vfpv2.c: Remove.
1423 * features/arm/arm-with-vfpv2.xml: Remove.
1424 * features/arm/arm-with-vfpv3.c: Remove.
1425 * features/arm/arm-with-vfpv3.xml: Remove.
1426
f42b2617
AH
14272019-07-19 Alan Hayward <alan.hayward@arm.com>
1428
1429 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1430
f29ec966
AH
14312019-07-19 Alan Hayward <alan.hayward@arm.com>
1432
1433 * arch/aarch32.c (aarch32_create_target_description): Create
1434 target descriptions using features.
1435 * arch/arm.c (arm_create_target_description)
1436 (arm_create_mprofile_target_description): Likewise.
1437 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1438
d105cce5
AH
14392019-07-19 Alan Hayward <alan.hayward@arm.com>
1440
1441 * Makefile.in: Add new files.
1442 * aarch32-tdep.c: New file.
1443 * aarch32-tdep.h: New file.
1444 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1445 Call aarch32_read_description.
1446 * arch/aarch32.c: New file.
1447 * arch/aarch32.h: New file.
1448 * arch/arm.c (arm_create_target_description)
1449 (arm_create_mprofile_target_description): New function.
1450 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1451 (arm_create_target_description)
1452 (arm_create_mprofile_target_description): New declaration.
1453 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1454 read_description functions.
1455 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1456 Likewise.
1457 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1458 * arm-tdep.c (tdesc_arm_list): New variable.
1459 (arm_register_g_packet_guesses): Call create description functions.
1460 (arm_read_description) (arm_read_mprofile_description): New
1461 function.
1462 * arm-tdep.h (arm_read_description)
1463 (arm_read_mprofile_description): Add declaration.
1464 * configure.tgt: Add new files.
1465
afe09f0b
GL
14662019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1467
1468 * top.c (new_ui_command): Open specified terminal just once.
1469
cd215b2e
TT
14702019-07-18 Tom Tromey <tromey@adacore.com>
1471
1472 * symtab.c (main_name): Constify return type.
1473 * symfile.c (set_initial_language): Update.
1474 * symtab.h (main_name): Constify return type.
1475
d8f68fcb
TT
14762019-07-17 Tom Tromey <tom@tromey.com>
1477
1478 * tui/tui-winsource.c (tui_update_source_window)
1479 (tui_update_source_window_as_is)
1480 (tui_update_source_windows_with_line): Remove return.
1481 * tui/tui-disasm.c (tui_show_disassem)
1482 (tui_show_disassem_and_update_source): Remove return.
1483 * tui/tui.c (tui_reset): Remove return.
1484 * tui/tui-wingeneral.c
1485 (tui_check_and_display_highlight_if_needed): Remove return.
1486
ca5af91e
TT
14872019-07-17 Tom Tromey <tom@tromey.com>
1488
1489 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1490
5104fe36
TT
14912019-07-17 Tom Tromey <tom@tromey.com>
1492
1493 * tui/tui-winsource.h (struct tui_exec_info_window)
1494 (struct tui_source_window_base): Move from tui-data.h.
1495 * tui/tui-winsource.c: Move many method definitions from
1496 elsewhere. Remove "structuring" comments.
1497 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1498 (tui_source_window_base::refresh_window): Move to
1499 tui-winsource.c.
1500 * tui/tui-win.c (tui_source_window_base::refresh_all)
1501 (tui_source_window_base::update_tab_width)
1502 (tui_source_window_base::set_new_height)
1503 (tui_source_window_base::do_make_visible_with_new_height): Move to
1504 tui-winsource.c.
1505 * tui/tui-source.h: Update.
1506 * tui/tui-source.c (tui_source_window_base::reset): Move to
1507 tui-winsource.c.
1508 * tui/tui-disasm.h: Update.
1509 * tui/tui-data.h (struct tui_exec_info_window): Move to
1510 tui-winsource.h.
1511 (struct tui_source_window_base): Likewise.
1512 * tui/tui-data.c (tui_source_window_base::clear_detail)
1513 (tui_source_window_base, ~tui_source_window_base): Move to
1514 tui-winsource.c.
1515
daa15dde
TT
15162019-07-17 Tom Tromey <tom@tromey.com>
1517
1518 * tui/tui-win.c (tui_resize_all)
1519 (tui_source_window_base::update_tab_width)
1520 (tui_adjust_win_heights): Update.
1521 (tui_win_info::make_invisible_and_set_new_height): Rename from
1522 make_invisible_and_set_new_height.
1523 * tui/tui-data.h (struct tui_win_info)
1524 <make_invisible_and_set_new_height>: New method.
1525
bfad4537
TT
15262019-07-17 Tom Tromey <tom@tromey.com>
1527
1528 * tui/tui.c: Update.
1529 * tui/tui-source.h (struct tui_source_window): Move from
1530 tui-data.h.
1531 * tui/tui-layout.c: Update.
1532 * tui/tui-disasm.c: Update.
1533 * tui/tui-data.h (struct tui_source_window): Move to
1534 tui-source.h.
1535
88f7e873
TT
15362019-07-17 Tom Tromey <tom@tromey.com>
1537
1538 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1539 tui-data.h.
1540 * tui/tui-data.h (struct tui_disasm_window): Move to
1541 tui-disasm.h.
1542
96bd6233
TT
15432019-07-17 Tom Tromey <tom@tromey.com>
1544
1545 * tui/tui-regs.h (struct tui_data_item_window): Move from
1546 tui-data.h.
1547 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1548 * tui/tui-data.h (struct tui_data_item_window): Move to
1549 tui-regs.h.
1550 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1551
ce38393b
TT
15522019-07-17 Tom Tromey <tom@tromey.com>
1553
1554 * tui/tui.c: Update.
1555 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1556 (tui_cmd_window::max_height): Move to tui-command.c.
1557 * tui/tui-layout.c: Update.
1558 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1559 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1560 tui-command.c.
1561 * tui/tui-command.h (struct tui_cmd_window): Move from
1562 tui-data.h.
1563 * tui/tui-command.c: Remove "structuring" comments.
1564 (tui_cmd_window::clear_detail)
1565 (tui_cmd_window::do_make_visible_with_new_height)
1566 (tui_cmd_window::max_height): Move from elsewhere.
1567
2d8b51cb
TT
15682019-07-17 Tom Tromey <tom@tromey.com>
1569
1570 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1571 Now static.
1572 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1573 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1574
18ab23af
TT
15752019-07-17 Tom Tromey <tom@tromey.com>
1576
1577 * tui/tui.c: Update.
1578 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1579 tui-regs.c.
1580 * tui/tui-windata.h: Remove file.
1581 * tui/tui-windata.c: Remove file.
1582 * tui/tui-win.c (tui_data_window::set_new_height)
1583 (tui_data_window::do_make_visible_with_new_height): Move to
1584 tui-regs.c.
1585 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1586 * tui/tui-regs.c: Remove "structuring" comments.
1587 (tui_data_window::first_data_item_displayed)
1588 (tui_data_window::delete_data_content_windows)
1589 (tui_data_window::erase_data_content)
1590 (tui_data_window::display_all_data)
1591 (tui_data_window::refresh_all)
1592 (tui_data_window::do_scroll_vertical)
1593 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1594 (tui_data_window::do_make_visible_with_new_height)
1595 (tui_data_window::refresh_window): Move from elsewhere.
1596 (_initialize_tui_regs): Move to end of file.
1597 * tui/tui-layout.c: Update.
1598 * tui/tui-hooks.c: Update.
1599 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1600 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1601 tui-regs.c.
1602 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1603
88b7e7cc
TT
16042019-07-17 Tom Tromey <tom@tromey.com>
1605
1606 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1607 seen.
1608
0fcd3711
TT
16092019-07-17 Tom Tromey <tom@tromey.com>
1610
1611 * tui/tui-win.c (tui_source_window_base::set_new_height)
1612 (tui_source_window_base::do_make_visible_with_new_height): Use
1613 m_has_locator field directly.
1614 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1615 method.
1616 (struct tui_source_window_base) <has_locator>: Likewise.
1617
4a38112d
TT
16182019-07-17 Tom Tromey <tom@tromey.com>
1619
1620 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1621 Don't declare.
1622 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1623 Remove.
1624 * tui/tui-win.c (tui_source_window_base::set_new_height)
1625 (tui_source_window_base::set_new_height)
1626 (make_invisible_and_set_new_height)
1627 (tui_source_window_base::do_make_visible_with_new_height)
1628 (tui_source_window_base::do_make_visible_with_new_height):
1629 Update.
1630 * tui/tui-layout.c (show_source_disasm_command, show_data)
1631 (show_source_or_disasm_and_command): Update.
1632 * tui/tui-layout.c (show_layout): Update.
1633
09129226
TT
16342019-07-17 Tom Tromey <tom@tromey.com>
1635
1636 * tui/tui-layout.c (make_data_window): Remove.
1637 (show_data): Unify creation and re-initialization cases.
1638
4a8a5e84
TT
16392019-07-17 Tom Tromey <tom@tromey.com>
1640
1641 * tui/tui-layout.c (make_source_window, make_disasm_window):
1642 Remove.
1643 (show_data): Unify creation and re-initialization cases.
1644
76d2be8e
TT
16452019-07-17 Tom Tromey <tom@tromey.com>
1646
1647 * tui/tui-layout.c (make_command_window): Remove.
1648 (show_source_disasm_command, show_source_or_disasm_and_command):
1649 Unify creation and re-initialization cases.
1650
890b8bde
TT
16512019-07-17 Tom Tromey <tom@tromey.com>
1652
1653 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1654 creation and re-initialization cases.
1655
2cdfa113
TT
16562019-07-17 Tom Tromey <tom@tromey.com>
1657
1658 * tui/tui-regs.c (tui_get_register): Return void.
1659
8e3cfd09
TT
16602019-07-17 Tom Tromey <tom@tromey.com>
1661
1662 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1663 Simplify.
1664
f4e04977
TT
16652019-07-17 Tom Tromey <tom@tromey.com>
1666
1667 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1668 resetting.
1669
0379b883
TT
16702019-07-17 Tom Tromey <tom@tromey.com>
1671
1672 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1673 * tui/tui-regs.c (tui_reg_layout): New function.
1674 (tui_show_registers, tui_reg_command): Use it.
1675 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1676 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1677 parameters.
1678 (tui_layout_command): Remove.
1679
b7fbad91
TT
16802019-07-17 Tom Tromey <tom@tromey.com>
1681
1682 * tui/tui-layout.h (tui/tui-layout): Return void.
1683 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1684
4e1e56b9
TT
16852019-07-17 Tom Tromey <tom@tromey.com>
1686
1687 * tui/tui-layout.c (show_source_disasm_command, show_data):
1688 Update.
1689 (reset_locator): Remove.
1690 (show_source_or_disasm_and_command): Update.
1691
1e0c09ba
TT
16922019-07-17 Tom Tromey <tom@tromey.com>
1693
1694 * tui/tui-source.c (tui_source_window_base::reset): Remove
1695 win_type parameter.
1696 * tui/tui-layout.c (make_command_window, make_source_window)
1697 (make_disasm_window, make_data_window)
1698 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1699 (reset_locator, show_source_or_disasm_and_command): Update.
1700 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1701 win_type parameter.
1702 (struct tui_source_window_base) <reset>: Likewise.
1703
1bf605de
TT
17042019-07-17 Tom Tromey <tom@tromey.com>
1705
1706 * tui/tui-layout.c (show_source_disasm_command): Use
1707 reset_locator.
1708 (reset_locator): New function.
1709 (init_and_make_win): Remove.
1710 (show_source_or_disasm_and_command): Use reset_locator.
1711
098f9ed4
TT
17122019-07-17 Tom Tromey <tom@tromey.com>
1713
1714 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1715 condition.
1716 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1717 Remove condition.
1718 * tui/tui-source.c (tui_source_window_base::reset): New method.
1719 * tui/tui-layout.c (make_command_window): Don't call
1720 init_and_make_win.
1721 (make_source_window, make_disasm_window): Don't call
1722 make_source_or_disasm_window.
1723 (make_data_window): Don't call init_and_make_win. Change calling
1724 convention.
1725 (show_source_disasm_command, show_data): Simplify.
1726 (make_source_or_disasm_window): Remove.
1727 (show_source_or_disasm_and_command): Simplify.
1728 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1729 (struct tui_source_window_base) <reset>: Likewise.
1730 <execution_info>: Remove initializer.
1731 * tui/tui-data.c (tui_source_window_base): Initialize
1732 execution_info.
1733
80110957
TT
17342019-07-17 Tom Tromey <tom@tromey.com>
1735
1736 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1737 variable.
1738
cf82af05
TT
17392019-07-17 Tom Tromey <tom@tromey.com>
1740
1741 * tui/tui.c (tui_rl_other_window): Update.
1742 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1743 superclass method first. Always iterate over regs_content.
1744 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1745 method.
1746 * tui/tui-win.c (tui_set_focus_command): Update.
1747
01aeb396
TT
17482019-07-17 Tom Tromey <tom@tromey.com>
1749
1750 * tui/tui-win.c (tui_set_focus_command): Rename from
1751 tui_set_focus. Call tui_enable.
1752 (tui_set_focus_command): Remove.
1753
fd6c75ee
TT
17542019-07-17 Tom Tromey <tom@tromey.com>
1755
1756 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1757 refresh_window.
1758 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1759 touchwin.
1760 (tui_data_window::refresh_window): Call refresh_window on data
1761 items. Always call superclass refresh_window.
1762 (tui_win_info::refresh): Remove.
1763 (tui_source_window_base::refresh_window): Update.
1764 (tui_refresh_all): Update.
1765 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1766 refresh_window.
1767 (show_source_or_disasm_and_command): Likewise.
1768 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1769 (struct tui_source_window_base) <refresh>: Likewise.
1770
f6cc34a9
TT
17712019-07-17 Tom Tromey <tom@tromey.com>
1772
1773 * tui/tui-winsource.c (tui_clear_source_content)
1774 (tui_show_source_content): Update.
1775 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1776 whether content is empty.
1777 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1778 Remove.
1779
f31ec9af
TT
17802019-07-17 Tom Tromey <tom@tromey.com>
1781
1782 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1783 window's contents.
1784 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1785 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1786
d1b6f1e5
TT
17872019-07-17 Tom Tromey <tom@tromey.com>
1788
1789 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1790 (struct tui_data_item_window): Update.
1791
d9743a13
TT
17922019-07-17 Tom Tromey <tom@tromey.com>
1793
1794 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1795 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1796 defines.
1797
caf0bc4e
TT
17982019-07-17 Tom Tromey <tom@tromey.com>
1799
1800 * tui/tui-winsource.h (tui_erase_source_content)
1801 (tui_clear_source_content): Remove "display_prompt" parameter.
1802 * tui/tui-winsource.c (tui_update_source_window_as_is)
1803 (tui_update_source_windows_with_addr): Update.
1804 (tui_clear_source_content): Remove "display_prompt" parameter.
1805 (tui_erase_source_content): Likewise. Simplify.
1806 (tui_show_source_content): Update.
1807 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1808 * tui/tui-stack.c (tui_show_frame_info): Update.
1809 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1810 Remove defines.
1811
9d391078
TT
18122019-07-17 Tom Tromey <tom@tromey.com>
1813
1814 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1815 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1816 parameter.
1817 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1818 parameter.
1819
a38da35d
TT
18202019-07-17 Tom Tromey <tom@tromey.com>
1821
1822 * tui/tui-winsource.c (tui_clear_source_content)
1823 (tui_show_source_content, tui_show_exec_info_content)
1824 (tui_clear_exec_info_content): Update.
1825 * tui/tui-stack.c (tui_show_locator_content): Update.
1826 (tui_show_frame_info): Update.
1827 * tui/tui-source.h (tui_source_window): Don't declare.
1828 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1829 from tui_source_is_displayed.
1830 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1831 Remove field.
1832 (struct tui_source_window_base) <content_in_use>: New field. Now
1833 bool.
1834 (struct tui_source_window) <showing_source_p>: New method.
1835 (TUI_SRC_WIN): Change cast.
1836 * tui/tui-data.c (tui_initialize_static_data): Update.
1837
c2cd8994
TT
18382019-07-17 Tom Tromey <tom@tromey.com>
1839
1840 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1841 location_matches_p.
1842 * tui/tui-source.c (tui_source_window::location_matches_p): New
1843 method.
1844 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1845 method.
1846 * tui/tui-data.h (struct tui_source_window_base)
1847 <location_matches_p>: New method.
1848 (struct tui_source_window, struct tui_disasm_window)
1849 <location_matches_p>: Likewise.
1850
4dde7b34
TT
18512019-07-17 Tom Tromey <tom@tromey.com>
1852
1853 * tui/tui-win.c (tui_set_win_height_command): Rename from
1854 tui_set_win_height.
1855 (tui_set_win_height_command): Remove.
1856
b73dd877
TT
18572019-07-17 Tom Tromey <tom@tromey.com>
1858
1859 * tui/tui-source.c (tui_source_window): New constructor. Add
1860 observer.
1861 (~tui_source_window): New destructor.
1862 (tui_source_window::style_changed): New method.
1863 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1864 (tui_attach_detach_observers): Update.
1865 * tui/tui-data.h (struct tui_source_window): Make constructor not
1866 inline. Add destructor.
1867 (struct tui_source_window) <style_changed>: New method.
1868 <m_observable>: New member.
1869
ae2b5380
TT
18702019-07-17 Tom Tromey <tom@tromey.com>
1871
1872 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1873 * tui/tui-win.c (tui_resize_all): Fix typo.
1874
1ce3e844
TT
18752019-07-17 Tom Tromey <tom@tromey.com>
1876
1877 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1878 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1879 (tui_refresh_all): Remove "list" parameter. Use foreach.
1880 * tui/tui-win.c (window_name_completer): Use foreach.
1881 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1882 (update_tab_width): Likewise.
1883 * tui/tui-layout.c (show_layout): Update.
1884 * tui/tui-data.h (class tui_window_iterator): New.
1885 (struct all_tui_windows): New.
1886 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1887
fe3eaf1c
TT
18882019-07-17 Tom Tromey <tom@tromey.com>
1889
1890 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1891 parameter. Don't reference globals.
1892 (tui_reg_command): Update.
1893
368c1354
TT
18942019-07-17 Tom Tromey <tom@tromey.com>
1895
1896 * tui/tui-regs.c (tui_show_registers): Simplify.
1897
e80cd204
TT
18982019-07-17 Tom Tromey <tom@tromey.com>
1899
1900 * tui/tui-regs.c (tui_show_registers): Update.
1901 (tui_show_register_group): Add win_info parameter.
1902
aca2dd16
TT
19032019-07-17 Tom Tromey <tom@tromey.com>
1904
1905 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1906 Rename from tui_display_reg_element_at_line.
1907 (tui_data_window::display_registers_from_line): Update.
1908 * tui/tui-data.h (struct tui_data_window)
1909 <display_reg_element_at_line>: New method.
1910
517e9505
TT
19112019-07-17 Tom Tromey <tom@tromey.com>
1912
1913 * tui/tui-regs.h (tui_display_registers_from)
1914 (tui_display_registers_from_line): Don't declare.
1915 * tui/tui-windata.c (tui_data_window::display_all_data)
1916 (tui_data_window::refresh_all)
1917 (tui_data_window::do_scroll_vertical): Update.
1918 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1919 from tui_display_registers_from.
1920 (tui_display_reg_element_at_line): Update.
1921 (tui_data_window::display_registers_from_line): Rename from
1922 tui_display_registers_from_line.
1923 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1924 display_registers_from_line>: New methods.
1925
f76d8b19
TT
19262019-07-17 Tom Tromey <tom@tromey.com>
1927
1928 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1929 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1930 from tui_erase_data_content.
1931 (tui_data_window::display_all_data)
1932 (tui_data_window::refresh_all)
1933 (tui_data_window::do_scroll_vertical): Update.
1934 * tui/tui-regs.c (tui_show_registers): Update.
1935 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1936 New method.
1937
b4094625
TT
19382019-07-17 Tom Tromey <tom@tromey.com>
1939
1940 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1941 declare.
1942 * tui/tui-windata.c
1943 (tui_data_window::delete_data_content_windows): Rename from
1944 tui_delete_data_content_windows.
1945 (tui_data_window::display_all_data)
1946 (tui_data_window::do_scroll_vertical): Update.
1947 * tui/tui-data.h (struct tui_data_window)
1948 <delete_data_content_windows>: New method.
1949
c223a729
TT
19502019-07-17 Tom Tromey <tom@tromey.com>
1951
1952 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1953 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1954
50daf268
TT
19552019-07-17 Tom Tromey <tom@tromey.com>
1956
1957 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1958 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1959 from tui_display_all_data.
1960 * tui/tui-win.c
1961 (tui_data_window::do_make_visible_with_new_height): Update.
1962 * tui/tui-regs.c (tui_show_registers): Update.
1963 * tui/tui-layout.c (tui_set_layout): Update.
1964 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1965 method.
1966
df5f8cab
TT
19672019-07-17 Tom Tromey <tom@tromey.com>
1968
1969 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1970 * tui/tui-windata.c (tui_display_data_from): Remove.
1971 (tui_data_window::refresh_all): Update.
1972
80cb6c27
TT
19732019-07-17 Tom Tromey <tom@tromey.com>
1974
1975 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1976 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1977 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1978 tui_display_registers_from_line.
1979 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1980 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1981 "force_display" parameter.
1982
baff0c28
TT
19832019-07-17 Tom Tromey <tom@tromey.com>
1984
1985 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1986 declare.
1987 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1988 Rename from tui_first_reg_element_no_inline.
1989 (tui_display_reg_element_at_line)
1990 (tui_display_registers_from_line): Update.
1991 * tui/tui-data.h (struct tui_data_window)
1992 <first_reg_element_no_inline>: New method.
1993
3b23c5f2
TT
19942019-07-17 Tom Tromey <tom@tromey.com>
1995
1996 * tui/tui-windata.c (tui_display_data_from)
1997 (tui_data_window::do_scroll_vertical): Update.
1998 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1999 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2000 Rename from tui_line_from_reg_element_no.
2001 (tui_display_registers_from_line): Update.
2002 * tui/tui-data.h (struct tui_data_window)
2003 <line_from_reg_element_no>: New method.
2004
0b5ec218
TT
20052019-07-17 Tom Tromey <tom@tromey.com>
2006
2007 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2008 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2009 tui_last_regs_line_no.
2010 (tui_display_reg_element_at_line)
2011 (tui_display_registers_from_line): Update.
2012 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2013 method.
2014
0807ab7b
TT
20152019-07-17 Tom Tromey <tom@tromey.com>
2016
2017 PR tui/24722:
2018 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2019 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2020 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2021 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2022 (tui_update_breakpoint_info): Likewise.
2023 * tui/tui-hooks.c (tui_event_create_breakpoint)
2024 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2025 Update.
2026
9ad7fdef
TT
20272019-07-17 Tom Tromey <tom@tromey.com>
2028
2029 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2030
5813316f
TT
20312019-07-17 Tom Tromey <tom@tromey.com>
2032
2033 * tui/tui-winsource.c (tui_update_source_window_as_is)
2034 (tui_update_source_windows_with_addr): Update.
2035 * tui/tui-source.h (tui_set_source_content)
2036 (tui_show_symtab_source): Add "win_info" parameter.
2037 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2038 parameter.
2039 (tui_show_symtab_source): Likewise.
2040
00e264e7
TT
20412019-07-17 Tom Tromey <tom@tromey.com>
2042
2043 * tui/tui-wingeneral.c
2044 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2045
06210ce4
TT
20462019-07-17 Tom Tromey <tom@tromey.com>
2047
2048 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2049 (struct tui_cmd_window) <can_scroll>: New method.
2050 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2051 method.
2052
381befee
TT
20532019-07-17 Tom Tromey <tromey@adacore.com>
2054
2055 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2056 do_field_signed>: Rename. Change type of "value".
2057 * ui-out.c (ui_out::field_signed): Rename from field_int.
2058 Change type of "value".
2059 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2060 type of "value".
2061 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2062 do_field_int. Change type of "value".
2063 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2064 do_field_int. Change type of "value".
2065 * tracepoint.c (trace_status_mi, tfind_1)
2066 (print_one_static_tracepoint_marker): Update.
2067 * thread.c (print_thread_info_1, print_selected_thread_frame):
2068 Update.
2069 * stack.c (print_frame, print_frame_info): Update.
2070 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2071 Update.
2072 * source.c (print_source_lines_base): Update.
2073 * skip.c (info_skip_command): Update.
2074 * record-btrace.c (btrace_ui_out_decode_error)
2075 (btrace_call_history_src_line): Update.
2076 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2077 Update.
2078 * progspace.c (print_program_space): Update.
2079 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2080 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2081 do_field_int. Change type of "value".
2082 * mi/mi-out.c (mi_ui_out::do_table_begin)
2083 (mi_ui_out::do_table_header): Update.
2084 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2085 type of "value".
2086 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2087 (mi_cmd_data_list_changed_registers, output_register)
2088 (mi_cmd_data_read_memory, mi_load_progress)
2089 (mi_cmd_trace_frame_collected): Update.
2090 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2091 Update.
2092 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2093 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2094 (mi_cmd_var_list_children, varobj_update_one): Update.
2095 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2096 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2097 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2098 * inferior.c (print_inferior): Update.
2099 * gdb_bfd.c (print_one_bfd): Update.
2100 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2101 Update.
2102 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2103 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2104 do_field_int. Change type of "value".
2105 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2106 do_field_int. Change type of "value".
2107 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2108 (print_one_breakpoint_location, print_it_catch_fork)
2109 (print_one_catch_fork, print_it_catch_vfork)
2110 (print_one_catch_vfork, print_it_catch_solib)
2111 (print_it_catch_exec, print_it_ranged_breakpoint)
2112 (print_mention_watchpoint, print_mention_masked_watchpoint)
2113 (bkpt_print_it, update_static_tracepoint): Update.
2114 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2115 * break-catch-syscall.c (print_it_catch_syscall): Update.
2116 * ada-tasks.c (print_ada_task_info): Update.
2117 * ada-lang.c (print_it_exception, print_mention_exception):
2118 Update.
2119
6b78c3f8
AB
21202019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2121
2122 PR breakpoints/24541
2123 * gdbarch.c: Regenerate.
2124 * gdbarch.h: Regenerate.
2125 * gdbarch.sh: Adjust return type and parameter types for
2126 'stap_adjust_register'.
2127 (i386_stap_adjust_register): Adjust signature and return new
2128 register name.
2129 * stap-probe.c (stap_parse_register_operand): Adjust use of
2130 'gdbarch_stap_adjust_register'.
2131
d72a9b85
TT
21322019-07-17 Tom Tromey <tromey@adacore.com>
2133
2134 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2135 declare VEC.
2136 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2137 std::vector.
2138 (struct s390_process_info): Add initializers.
2139 (s390_add_process): Use new.
2140 (s390_linux_nat_target::low_forget_process): Use delete.
2141 (s390_linux_nat_target::low_new_fork)
2142 (s390_linux_nat_target::stopped_by_watchpoint)
2143 (s390_linux_nat_target::low_prepare_to_resume)
2144 (s390_linux_nat_target::insert_watchpoint)
2145 (s390_linux_nat_target::insert_hw_breakpoint)
2146 (s390_linux_nat_target::remove_watchpoint)
2147 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2148
206e6c58
JB
21492019-07-16 John Baldwin <jhb@FreeBSD.org>
2150
2151 * aarch64-fbsd-nat.c: Include regcache.h.
2152 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2153 argument.
2154 (aarch64_fbsd_nat_target::fetch_registers)
2155 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2156 variable.
2157 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2158
cbde90f2
JB
21592019-07-16 John Baldwin <jhb@FreeBSD.org>
2160
2161 * fbsd-nat.c: Include gdbarch.h.
2162
07128006
TT
21632019-07-15 Tom Tromey <tromey@adacore.com>
2164
2165 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2166
1f77b012
TT
21672019-07-15 Tom Tromey <tromey@adacore.com>
2168
2169 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2170 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2171 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2172 * cli-out.c (cli_ui_out::do_field_int): New method.
2173 * ui-out.c (ui_out::field_unsigned): New method.
2174 * symfile.c (generic_load): Use field_unsigned.
2175 (print_transfer_performance): Likewise.
2176 * record-btrace.c (ui_out_field_uint): Remove.
2177 (btrace_call_history_insn_range, btrace_call_history): Use
2178 field_unsigned.
2179 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2180 field_unsigned.
2181 * ui-out.h (class ui_out) <field_unsigned>: New method.
2182 <do_field_unsigned>: Likewise.
2183
33eca680
TT
21842019-07-15 Tom Tromey <tromey@adacore.com>
2185
2186 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2187 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2188 * target.c (flash_erase_command): Use field_string.
2189 * infrun.c (print_signal_received_reason): Use field_string.
2190 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2191 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2192 field_string.
2193 * ada-tasks.c (print_ada_task_info): Use field_string.
2194
ca8d69be
TT
21952019-07-15 Tom Tromey <tromey@adacore.com>
2196
2197 * target.c (flash_erase_command): Use field_core_addr.
2198 * symfile.c (generic_load): Use field_core_addr.
2199 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2200 Use field_core_addr.
2201 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2202 field_core_addr.
2203
0d4e84ed
AB
22042019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2205
2206 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2207 value if its desired type is smaller than a CORE_ADDR and signed.
2208
9a49df9d
AB
22092019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2210
2211 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2212 of changes to field names, and use new is_reference field to
2213 decide if a property is a reference or not.
2214 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2215 field.
2216 (struct dwarf2_property_baton): Update header comment, rename
2217 'referenced_type' to 'property_type' and update comments.
2218 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2219 default property type, store in property baton, update to take
2220 accound of renamed field.
2221 (read_func_scope): Update call to attr_to_dynamic_prop.
2222 (read_array_type): Likewise.
2223 (dwarf2_per_cu_addr_sized_int_type): New function.
2224 (read_subrange_index_type): Move type finding code to
2225 dwarf2_per_cu_addr_sized_int_type.
2226 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2227 (dwarf2_per_cu_addr_type): New function.
2228 (set_die_type): Update calls to attr_to_dynamic_prop.
2229
b86352cf
AB
22302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2231
2232 * dwarf2read.c (read_subrange_index_type): New function.
2233 (read_subrange_type): Move code into new function and call it.
2234 * gdbtypes.c (create_range_type): Add some asserts.
2235
603490bf
AB
22362019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2237
2238 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2239 update return statements.
2240 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2241 declaration, and update comment to match.
2242 * gdbtypes.c (resolve_dynamic_array): Update call to
2243 dwarf2_evaluate_property to match new return type.
2244
592f9d27
AB
22452019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2246
2247 * valarith.c (value_subscripted_rvalue): Change lowerbound
2248 parameter type from int to LONGEST.
2249 * value.h (value_subscripted_rvalue): Likewise in declaration.
2250
60cfcb20
AB
22512019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2252
2253 * cli/cli-utils.c (info_print_command_completer): New function.
2254 * cli/cli-utils.h: Add 'completer.h' include, and forward
2255 declaration for 'struct cmd_list_element'.
2256 (info_print_command_completer): Declare.
2257 * stack.c (_initialize_stack): Add completer for 'info locals' and
2258 'info args'.
2259 * symtab.c (_initialize_symtab): Add completer for 'info
2260 variables' and 'info functions'.
2261 * NEWS: Mention completion for additional info commands.
2262
b16507e0
AB
22632019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2264
2265 * cli/cli-utils.c (extract_info_print_args): Delete.
2266 (extract_arg_maybe_quoted): Delete.
2267 (info_print_options_defs): New variable.
2268 (make_info_print_options_def_group): New function.
2269 (extract_info_print_options): Define new function.
2270 * cli/cli-utils.h (extract_info_print_args): Delete.
2271 (struct info_print_options): New structure.
2272 (extract_info_print_options): Declare new function.
2273 * stack.c (info_locals_command): Update to use new
2274 extract_info_print_options, also add a header comment.
2275 (info_args_command): Likewise.
2276 * symtab.c (info_variables_command): Likewise.
2277 (info_functions_command): Likewise.
2278
021d8588
AB
22792019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2280
2281 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2282 to extract string arguments.
2283 * common/common-utils.c (extract_string_maybe_quoted): New function.
2284 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2285
b777eb6d
TT
22862019-07-11 Tom Tromey <tromey@adacore.com>
2287
2288 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2289 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2290 * top.h (gdbinit): Don't declare.
2291 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2292 into...
2293 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2294 * top.c (gdb_init): Don't call init_cli_cmds.
2295 (gdbinit): Remove.
2296 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2297
72ee03ff
TT
22982019-07-11 Tom Tromey <tromey@adacore.com>
2299
2300 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2301 after it has been moved.
2302
00db9531
SM
23032019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2304
2305 * valops.c (value_must_coerce_to_target): Change return type to
2306 bool.
2307 * value.h (value_must_coerce_to_target): Likewise.
2308
f2478a7e
SM
23092019-07-10 Simon Marchi <simon.marchi@efficios.com>
2310
2311 * breakpoint.c (is_hardware_watchpoint): Remove
2312 forward-declaration.
2313 (is_masked_watchpoint): Change return type to bool.
2314 (is_tracepoint): Likewise.
2315 (is_breakpoint): Likewise.
2316 (is_hardware_watchpoint): Likewise.
2317 (is_watchpoint): Likewise.
2318 (is_no_memory_software_watchpoint): Likewise.
2319 (is_catchpoint): Likewise.
2320 (breakpoint_1): Make FILTER parameter's return type bool.
2321 is_masked_watchpoint): Change return type to bool.
2322 (save_breakpoints): Make FILTER parameter's return type bool.
2323 * breakpoint.h (is_breakpoint): Change return type to bool.
2324 (is_watchpoint): Likewise.
2325 (is_catchpoint): Likewise.
2326 (is_tracepoint): Likewise.
2327
0d12e84c
TT
23282019-07-10 Tom Tromey <tom@tromey.com>
2329
2330 * defs.h: Don't include gdbarch.h.
2331 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2332 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2333 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2334 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2335 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2336 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2337 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2338 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2339 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2340 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2341 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2342 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2343 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2344 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2345 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2346 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2347 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2348 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2349 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2350 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2351 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2352 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2353 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2354 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2355 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2356 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2357 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2358
f06f1252
TT
23592019-07-10 Tom Tromey <tromey@adacore.com>
2360
2361 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2362 * breakpoint.c (init_ada_exception_breakpoint): Register as
2363 bp_catchpoint.
2364 (print_one_breakpoint_location, print_one_breakpoint): Use
2365 is_ada_exception_catchpoint.
2366 * ada-lang.c (class ada_catchpoint_location): Pass
2367 bp_loc_software_breakpoint to bp_location constructor.
2368 (is_ada_exception_catchpoint): New function.
2369
7a5d944b
TT
23702019-07-10 Tom Tromey <tromey@adacore.com>
2371
2372 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2373 VEC.
2374 (struct arm_exidx_entry): New method operator<.
2375 (struct arm_exidx_data) <section_maps>: Change type.
2376 (arm_exidx_data_free): Remove.
2377 (arm_exidx_data_key): Change type. Move lower.
2378 (arm_exidx_new_objfile): Update.
2379 (arm_compare_exidx_entries): Remove.
2380 (arm_find_exidx_entry, _initialize_arm_tdep)
2381
48c66e1d
TT
23822019-07-10 Tom Tromey <tromey@adacore.com>
2383
2384 * solib-spu.c (ocl_program_data_key): Change type.
2385 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2386 Update.
2387
a269fbf1
TT
23882019-07-10 Tom Tromey <tromey@adacore.com>
2389
2390 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2391 (struct solib_aix_inferior_data) <library_list>: Change type.
2392 (solib_aix_inferior_data_handle): Change type.
2393 (get_solib_aix_inferior_data): Update.
2394 (solib_aix_free_library_list): Remove.
2395 (library_list_start_library): Update.
2396 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2397 return type.
2398 (solib_aix_get_library_list)
2399 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2400 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2401
c294730c
TT
24022019-07-10 Tom Tromey <tromey@adacore.com>
2403
2404 * solib-dsbt.c (struct dsbt_info): Add initializers.
2405 (solib_dsbt_pspace_data): Change type.
2406 (dsbt_pspace_data_cleanup): Remove.
2407 (get_dsbt_info, _initialize_dsbt_solib): Update.
2408
9d52077d
TT
24092019-07-10 Tom Tromey <tromey@adacore.com>
2410
2411 * spu-tdep.c (spu_overlay_data): Change type.
2412 (spu_get_overlay_table, spu_overlay_new_objfile)
2413 (_initialize_spu_tdep): Update.
2414
22a20dca
TT
24152019-07-10 Tom Tromey <tromey@adacore.com>
2416
2417 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2418 destructor.
2419 (dbx_objfile_data_key): Change type and declare later.
2420 (DBX_SYMFILE_INFO): Rewrite.
2421 * dbxread.c (dbx_objfile_data_key): Change type.
2422 (dbx_symfile_init): Update.
2423 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2424 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2425 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2426
cb60f420
TT
24272019-07-10 Tom Tromey <tromey@adacore.com>
2428
2429 * jit.c (jit_program_space_key): Change type. Move lower.
2430 (get_jit_program_space_data): Update.
2431 (jit_program_space_data_cleanup): Remove.
2432 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2433 Update.
2434 (struct jit_program_space_data): Add initializers.
2435
51df2ae3
TT
24362019-07-10 Tom Tromey <tromey@adacore.com>
2437
2438 * solib-darwin.c (struct darwin_info): Add initializers.
2439 (solib_darwin_pspace_data): Change type.
2440 (darwin_pspace_data_cleanup): Remove.
2441 (get_darwin_info, _initialize_darwin_solib): Update.
2442
18101a35
TT
24432019-07-10 Tom Tromey <tromey@adacore.com>
2444
2445 * remote-sim.c (struct sim_inferior_data): Add initializers,
2446 constructor, and destructor.
2447 (sim_inferior_data_key): Change type. Move lower.
2448 (check_for_duplicate_sim_descriptor): Update.
2449 (get_sim_inferior_data): Use new. Update.
2450 (~sim_inferior_data_cleanup): Rename from
2451 sim_inferior_data_cleanup. Simplify.
2452 (gdbsim_close_inferior, simulator_command)
2453 (sim_command_completer, _initialize_remote_sim): Update.
2454 (next_pid, INITIAL_PID): Move earlier.
2455
05b08ac1
TT
24562019-07-10 Tom Tromey <tromey@adacore.com>
2457
2458 * python/python-internal.h (create_thread_object): Return
2459 gdbpy_ref.
2460 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2461 * python/py-inferior.c (struct threadlist_entry): Add
2462 constructor.
2463 <thread_obj>: Now a gdbpy_ref.
2464 (thread_to_thread_object): Update.
2465 (add_thread_object): Use new.
2466 (delete_thread_object): Use delete.
2467 (infpy_threads): Update.
2468 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2469 GIL.
2470
32372d80
TT
24712019-07-10 Tom Tromey <tromey@adacore.com>
2472
2473 * valops.c (value_cast): Specialize error message for Ada.
2474
5c458ae8
SM
24752019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2476
2477 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2478
4c462cb0
SM
24792019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2480
2481 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2482 bpstat_should_step): Return bool, adjust comments.
2483 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2484 bpstat_should_step): Likewise.
2485
89abbcc2
AH
24862019-07-10 Alan Hayward <alan.hayward@arm.com>
2487
2488 * features/Makefile: Use feature target descriptions for Arm.
2489 * features/arm/arm-core.c: Generate new file.
2490 * features/arm/arm-fpa.c: Likewise.
2491 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2492 * features/arm/arm-m-profile.c: Likewise.
2493 * features/arm/arm-vfpv2.c: Likewise.
2494 * features/arm/arm-vfpv3.c: Likewise.
2495 * features/arm/xscale-iwmmxt.c: Likewise.
2496 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2497
166a82be
AH
24982019-07-10 Alan Hayward <alan.hayward@arm.com>
2499
2500 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2501 ptrace earlier.
2502
9fb4c7e9
AH
25032019-07-10 Alan Hayward <alan.hayward@arm.com>
2504
2505 * features/aarch64-pauth.c: Regenerate.
2506
e2d0f980
SM
25072019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2508
2509 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2510 bool.
2511 (bpstat_what): Use false instead of 0.
2512
a38118e5
PA
25132019-07-09 Pedro Alves <palves@redhat.com>
2514
2515 * break-catch-throw.c (is_exception_catchpoint): New.
2516 * breakpoint.c (print_one_breakpoint_location): New parameter
2517 'raw_loc'. Handle it. Use
2518 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2519 looking at the breakpoint's type.
2520 (print_one_breakpoint): If handling "maint info breakpoints", also
2521 print locations of exception catchpoints.
2522 * breakpoint.h (is_exception_catchpoint): Declare.
2523
cb1e4e32
PA
25242019-07-09 Pedro Alves <palves@redhat.com>
2525
2526 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2527 "addr" field.
2528 (allocate_location_exception_catchpoint): New.
2529 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2530 (initialize_throw_catchpoint_ops): Install
2531 allocate_location_exception_catchpoint as allocate_location
2532 method.
2533 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2534 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2535 bp_loc_other.
2536 (breakpoint_address_is_meaningful): Delete.
2537 (bl_address_is_meaningful): New.
2538 (breakpoint_locations_match): Adjust comment.
2539 (bp_location_from_bp_type): New, factored out of...
2540 (bp_location::bp_location(breakpoint *)): ... this.
2541 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2542 factored out of...
2543 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2544 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2545 breakpoint_address_is_meaningful.
2546 (bp_locations_compare): Adjust comment.
2547 (update_global_location_list): Use bl_address_is_meaningful
2548 instead of breakpoint_address_is_meaningful.
2549 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2550 explicit.
2551 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2552 * python/py-breakpoint.c (bppy_get_location): No longer check
2553 whether location is null.
2554
b58a68fe
PA
25552019-07-09 Pedro Alves <palves@redhat.com>
2556
2557 PR c++/15468
2558 * breakpoint.c (print_one_breakpoint_location): Remove
2559 single-location assert.
2560
268a13a5
TT
25612019-07-09 Tom Tromey <tom@tromey.com>
2562
2563 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2564 * configure: Rebuild.
2565 * configure.ac: Change common to gdbsupport.
2566 * gdbsupport: Rename from common.
2567 * acinclude.m4: Change common to gdbsupport.
2568 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2569 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2570 gdbsupport.
2571 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2572 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2573 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2574 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2575 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2576 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2577 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2578 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2579 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2580 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2581 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2582 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2583 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2584 coff-pe-read.c, command.h, compile/compile-c-support.c,
2585 compile/compile-c.h, compile/compile-cplus-symbols.c,
2586 compile/compile-cplus-types.c, compile/compile-cplus.h,
2587 compile/compile-loc2c.c, compile/compile.c, completer.c,
2588 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2589 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2590 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2591 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2592 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2593 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2594 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2595 features/aarch64-core.c, features/aarch64-fpu.c,
2596 features/aarch64-pauth.c, features/aarch64-sve.c,
2597 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2598 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2599 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2600 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2601 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2602 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2603 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2604 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2605 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2606 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2607 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2608 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2609 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2610 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2611 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2612 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2613 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2614 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2615 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2616 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2617 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2618 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2619 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2620 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2621 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2622 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2623 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2624 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2625 minsyms.c, mips-linux-tdep.c, namespace.h,
2626 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2627 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2628 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2629 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2630 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2631 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2632 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2633 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2634 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2635 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2636 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2637 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2638 procfs.c, producer.c, progspace.h, psymtab.h,
2639 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2640 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2641 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2642 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2643 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2644 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2645 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2646 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2647 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2648 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2649 target-memory.c, target.c, target.h, target/waitstatus.c,
2650 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2651 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2652 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2653 unittests/array-view-selftests.c,
2654 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2655 unittests/common-utils-selftests.c,
2656 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2657 unittests/format_pieces-selftests.c,
2658 unittests/function-view-selftests.c,
2659 unittests/lookup_name_info-selftests.c,
2660 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2661 unittests/mkdir-recursive-selftests.c,
2662 unittests/observable-selftests.c,
2663 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2664 unittests/parse-connection-spec-selftests.c,
2665 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2666 unittests/scoped_fd-selftests.c,
2667 unittests/scoped_mmap-selftests.c,
2668 unittests/scoped_restore-selftests.c,
2669 unittests/string_view-selftests.c, unittests/style-selftests.c,
2670 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2671 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2672 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2673 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2674 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2675 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2676
5b0e2db4
AB
26772019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2678
2679 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2680 bool value.
2681 (decode_digits_ordinary): Set explicit_line field in sal.
2682 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2683 symtab_and_line that was set on an explicit line number in
2684 assembler code. Do always update the recorded symtab and line if
2685 we do skip the prologue.
2686
0ba852ab
AB
26872019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2688
2689 * breakpoint.c (set_breakpoint_location_function): Remove
2690 explicit_loc parameter.
2691 (momentary_breakpoint_from_master): Update call to
2692 set_breakpoint_location_function.
2693 (add_location_to_breakpoint): Likewise.
2694
b3a7d171
AB
26952019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2696
2697 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2698 required features based on default bfd type when no specific bfd
2699 is present.
2700
1f6f6e21
PW
27012019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2702
2703 * NEWS: Mention that GDB printf and eval commands can now print
2704 C-style and Ada-style convenience var strings without
2705 calling the inferior.
2706 * printcmd.c (printf_c_string): Locally print GDB internal var
2707 instead of transiting via the inferior.
2708 (printf_wide_c_string): Likewise.
2709
27102019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2711
2712 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2713
0598af48
TT
27142019-07-04 Tom Tromey <tom@tromey.com>
2715
2716 PR tui/24724:
2717 * tui/tui-winsource.c (tui_clear_source_content): Update.
2718 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2719 (tui_update_breakpoint_info): Update.
2720 (tui_set_exec_info_content): Update.
2721 * tui/tui-source.c (tui_set_source_content_nil): Update.
2722 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2723 has_break.
2724 * tui/tui-data.h (enum tui_bp_flag): New.
2725 (tui_bp_flags): New enum flags type.
2726 (struct tui_source_element) <break_mode>: Change type. Rename
2727 from has_break.
2728 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2729 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2730 constants.
2731 * tui/tui-winsource.h: Fix comment.
2732
350fab54
AH
27332019-07-04 Alan Hayward <alan.hayward@arm.com>
2734
2735 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2736 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2737 (store_fpregs_to_thread)
2738 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2739 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2740 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2741 (IWMMXT_REGS_SIZE): Add define.
2742 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2743 (fetch_vfp_regs, store_vfp_regs)
2744 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2745 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2746
f0452268
AH
27472019-07-04 Alan Hayward <alan.hayward@arm.com>
2748
2749 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2750 defines.
2751 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2752 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2753 (ARM_INT_REGISTER_SIZE): ...to this.
2754 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2755 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2756 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2757 (arm_linux_collect_gregset, supply_nwfpe_register)
2758 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2759 defines.
2760 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2761 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2762 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2763 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2764 (arm_return_in_memory, arm_store_return_value)
2765 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2766 (arm_record_ld_st_multiple): Likewise.
2767 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2768 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2769
e935475c
AH
27702019-07-04 Alan Hayward <alan.hayward@arm.com>
2771
2772 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2773 AARCH64_DISPLACED_MODIFIED_INSNS.
2774 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2775 (aarch64_displaced_step_copy_insn): Likewise.
2776 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2777 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2778 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2779 ARM_DISPLACED_MODIFIED_INSNS.
2780 * arm-tdep.c (arm_gdbarch_init): Likewise.
2781 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2782 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2783 (struct arm_displaced_step_closure): Use
2784 ARM_DISPLACED_MODIFIED_INSNS.
2785
df0bb381
AH
27862019-07-04 Alan Hayward <alan.hayward@arm.com>
2787
2788 * features/Makefile: Remove unused xml files.
2789 * features/aarch64.xml: Remove.
2790 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2791 * features/i386/amd64-avx-avx512.xml: Remove.
2792 * features/i386/amd64-avx-linux.xml: Remove.
2793 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2794 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2795 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2796 * features/i386/amd64-avx-mpx.xml: Remove.
2797 * features/i386/amd64-avx.xml: Remove.
2798 * features/i386/amd64-linux.xml: Remove.
2799 * features/i386/amd64-mpx-linux.xml: Remove.
2800 * features/i386/amd64-mpx.xml: Remove.
2801 * features/i386/amd64.xml: Remove.
2802 * features/i386/i386-avx-avx512-linux.xml: Remove.
2803 * features/i386/i386-avx-avx512.xml: Remove.
2804 * features/i386/i386-avx-linux.xml: Remove.
2805 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2806 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2807 * features/i386/i386-avx-mpx-linux.xml: Remove.
2808 * features/i386/i386-avx-mpx.xml: Remove.
2809 * features/i386/i386-avx.xml: Remove.
2810 * features/i386/i386-linux.xml: Remove.
2811 * features/i386/i386-mmx-linux.xml: Remove.
2812 * features/i386/i386-mmx.xml: Remove.
2813 * features/i386/i386-mpx-linux.xml: Remove.
2814 * features/i386/i386-mpx.xml: Remove.
2815 * features/i386/i386.xml: Remove.
2816 * features/i386/x32-avx-avx512-linux.xml: Remove.
2817 * features/i386/x32-avx-linux.xml: Remove.
2818 * features/i386/x32-linux.xml: Remove.
2819
edd6266a
AH
28202019-07-04 Alan Hayward <alan.hayward@arm.com>
2821
2822 * regformats/aarch64.dat: Remove.
2823 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2824 * regformats/i386/amd64-avx-linux.dat: Remove.
2825 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2826 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2827 * regformats/i386/amd64-linux.dat: Remove.
2828 * regformats/i386/amd64-mpx-linux.dat: Remove.
2829 * regformats/i386/amd64.dat: Remove.
2830 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2831 * regformats/i386/i386-avx-linux.dat: Remove.
2832 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2833 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2834 * regformats/i386/i386-linux.dat: Remove.
2835 * regformats/i386/i386-mmx-linux.dat: Remove.
2836 * regformats/i386/i386-mpx-linux.dat: Remove.
2837 * regformats/i386/i386.dat: Remove.
2838 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2839 * regformats/i386/x32-avx-linux.dat: Remove.
2840 * regformats/i386/x32-linux.dat: Remove.
2841
2b40fda7
AH
28422019-07-04 Alan Hayward <alan.hayward@arm.com>
2843
2844 * aarch64-tdep.c: Remove xml self tests.
2845 * amd64-linux-tdep.c: Likewise.
2846 * amd64-tdep.c: Likewise.
2847 * i386-linux-tdep.c: Likewise.
2848 * i386-tdep.c: Likewise.
2849
5f4ba3e7
PA
28502019-07-03 Pedro Alves <palves@redhat.com>
2851
2852 PR cli/24732
2853 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2854 (pipe_cmd_option_defs): New.
2855 (make_pipe_cmd_options_def_group): New.
2856 (pipe_command): Use gdb::option::process_options.
2857 (pipe_command_completer): New function.
2858 (_initialize_cli_cmds): Install completer for "pipe" command.
2859
3d9be6f5
PA
28602019-07-03 Pedro Alves <palves@redhat.com>
2861
2862 * cli/cli-option.c (union option_value) <string>: New field.
2863 (struct option_def_and_value): Add ctor, move ctor, dtor and
2864 use DISABLE_COPY_AND_ASSIGN.
2865 (option_def_and_value::clear_value): New.
2866 (parse_option, save_option_value_in_ctx, get_val_type_str)
2867 (add_setshow_cmds_for_options): Handle var_string.
2868 * cli-option.h (union option_def::var_address) <string>: New
2869 field.
2870 (struct string_option_def): New.
2871 * maint-test-options.c (struct test_options_opts): Add default
2872 ctor and use DISABLE_COPY_AND_ASSIGN.
2873 <string_opt>: New field.
2874 (test_options_opts::~test_options_opts): New.
2875 (test_options_opts::dump): Also dump "-string".
2876 (test_options_option_defs): Install "string.
2877
41fc454c
PA
28782019-07-03 Pedro Alves <palves@redhat.com>
2879
2880 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2881 option_value with a null enumeration.
2882 (complete_options): Save the option values in the context.
2883 (save_option_value_in_ctx): New, factored out from ...
2884 (process_options): ... here.
2885 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2886 of the function.
2887 * maint-test-options.c (test_options_opts::dump): New, factored
2888 out from ...
2889 (maintenance_test_options_command_mode): ... here.
2890 (maintenance_test_options_command_completion_result): Delete.
2891 (maintenance_test_options_command_completion_text): Update
2892 comment.
2893 (maintenance_show_test_options_completion_result): Change
2894 prototype. Just print
2895 maintenance_test_options_command_completion_text.
2896 (save_completion_result): New.
2897 (maintenance_test_options_completer_mode): Pass options context to
2898 complete_options, and then save a dump.
2899 (_initialize_maint_test_options): Use add_cmd to install "maint
2900 show test-options-completion-result".
2901
fdbc9870
PA
29022019-07-03 Pedro Alves <palves@redhat.com>
2903
2904 * NEWS (New commands): Mention "with" and "maint with".
2905 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2906 (with_command, with_command_completer): New.
2907 (pipe_command): Adjust to new repeat_previous
2908 interface.
2909 (_initialize_cli_cmds): Install the "with" command and its "w"
2910 alias.
2911 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2912 declarations.
2913 * cli/cli-setshow.c (parse_cli_var_uinteger)
2914 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2915 argument strings for all var_types.
2916 (get_setshow_command_value_string): New, factored out from ...
2917 (do_show_command): ... this.
2918 * cli/cli-setshow.h: Include <string>.
2919 (get_setshow_command_value_string): Declare.
2920 * command.h (repeat_previous): Now returns const char *. Adjust
2921 comment.
2922 * maint.c: Include "cli/cli-cmds.h".
2923 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2924 (_initialize_maint_cmds): Register the "maintenance with" command.
2925 * top.c (repeat_previous): Move bits from pipe_command here:
2926 Return the saved command line, if any; error out if there's no
2927 command to relaunch.
2928
c6ac8931
PA
29292019-07-03 Pedro Alves <palves@redhat.com>
2930
2931 * NEWS (New commands): Mention "maint set/show test-settings"
2932 instead of "maint test-settings".
2933 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2934 (maintenance_test_settings_set_list): Rename to ...
2935 (maintenance_set_test_settings_list): ... this.
2936 (maintenance_test_settings_show_list): Rename to ...
2937 (maintenance_show_test_settings_list): ... this.
2938 (maintenance_test_settings_cmd): Delete.
2939 (maintenance_test_settings_set_cmd): ...
2940 (maintenance_set_test_settings_cmd): ... this.
2941 (maintenance_test_settings_show_cmd): ...
2942 (maintenance_show_test_settings_cmd): ... this.
2943 (maintenance_test_settings_show_value_cmd):
2944 (maintenance_show_test_settings_value_cmd): ... this.
2945 (_initialize_maint_test_settings): No longer install the "maint
2946 test-settings" prefix command. Rename "maint test-settings set"
2947 to "maint set test-settings", and "maint test-settings show" to
2948 "maint show test-settings". Adjust all subcommands.
2949
d1fcf2fd
PA
29502019-07-03 Pedro Alves <palves@redhat.com>
2951
2952 * maint-test-settings.c: Fix file's intro comment. Replace all
2953 references to "test-options" with references to "test-settings",
2954 in comments.
2955
970f9d09
PA
29562019-07-03 Pedro Alves <palves@redhat.com>
2957
2958 * maint-test-settings.c (maintenance_test_settings_xxx)
2959 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2960 New.
2961 (maintenance_test_settings_enums): Use them.
2962 (maintenance_test_settings_enum): Default to
2963 maintenance_test_settings_xxx.
2964 (_initialize_maint_test_settings): Initialize
2965 MAINTENANCE_TEST_SETTINGS_FILENAME.
2966
f3869b1a
SM
29672019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2968
2969 * breakpoint.h (remove_breakpoints_inf): Change return type to
2970 void, move function documentation here.
2971 * breakpoint.c (remove_breakpoints_inf): Change return type to
2972 void, move function documentation to header.
2973
54d66006
PA
29742019-07-02 Pedro Alves <palves@redhat.com>
2975
2976 * NEWS (Completion improvements): Mention "info threads".
2977 * thread.c (struct info_threads_opts, info_threads_option_defs)
2978 (make_info_threads_options_def_group): New.
2979 (info_threads_command): Use gdb::option::process_options.
2980 (info_threads_command_completer): New.
2981 (_initialize_thread): Use gdb::option::build_help to build the
2982 help text for "info threads".
2983
854f6088
SM
29842019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2985
2986 * defs.h (generic_load): Move from here...
2987 * symfile.h (generic_load): ... to here. Rename name parameter
2988 to args.
2989 * symfile.c (generic_load): Add comment.
2990
54ee4252
TT
29912019-07-01 Tom Tromey <tromey@adacore.com>
2992
2993 * dwarf2read.c
2994 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2995 declaration of without_params. Fix formatting.
2996
65392b3e
TT
29972019-07-01 Tom Tromey <tromey@adacore.com>
2998
2999 * ada-exp.y (find_primitive_type): Update.
3000 * ada-lang.h (ada_lookup_symbol): Update.
3001 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3002 parameter.
3003 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3004
7d7571f0
SDJ
30052019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3006
3007 PR breakpoints/24541
3008 * gdbarch.c: Regenerate.
3009 * gdbarch.h: Regenerate.
3010 * gdbarch.sh: Add 'stap_adjust_register'.
3011 * i386-tdep.c: Include '<unordered_set>'.
3012 (i386_stap_adjust_register): New function.
3013 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3014 * stap-probe.c (stap_parse_register_operand): Call
3015 'gdbarch_stap_adjust_register'.
3016
5af5392a
SDJ
30172019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3018
3019 PR python/24742
3020 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3021 * python/python.c (do_start_initialization): Use 'xmalloc'
3022 instead of 'PyMem_Malloc'.
3023
10d06d82
TT
30242019-06-28 Tom Tromey <tromey@adacore.com>
3025
3026 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3027 for Ada.
3028
1b7f24cd
TT
30292019-06-27 Tom Tromey <tromey@adacore.com>
3030
3031 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3032 objfile_key.
3033 (arm_find_mapping_symbol, arm_record_special_symbol)
3034 (_initialize_arm_tdep): Update.
3035 (arm_objfile_data_free): Remove.
3036
3d507ff2
TT
30372019-06-27 Tom Tromey <tromey@adacore.com>
3038
3039 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3040 to cp_print_static_field.
3041
762c164d
TT
30422019-06-26 Tom Tromey <tromey@adacore.com>
3043
3044 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3045 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3046 declare.
3047
aa2f9bcf
AH
30482019-06-26 Alan Hayward <alan.hayward@arm.com>
3049
3050 * features/aarch64-core.c (create_feature_aarch64_core):
3051 Regenerate.
3052 * features/aarch64-core.xml: Add cpsr flags.
3053
3426ae57
AH
30542019-06-26 Alan Hayward <alan.hayward@arm.com>
3055
3056 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3057 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3058
4838e44c
SM
30592019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3060
3061 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3062 field.
3063 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3064 use.
3065 (arm_record_special_symbol): Don't insert new symbol in sorted
3066 position, push it at the end.
3067
54cc7474
SM
30682019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3069
3070 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3071 (arm_mapping_symbol_s): Remove.
3072 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3073 (arm_mapping_symbol_vec): New typedef.
3074 (struct arm_per_objfile): Add constructor.
3075 <section_maps>: Change type to
3076 std::unique_ptr<arm_mapping_symbol_vec[]>.
3077 (arm_compare_mapping_symbols): Remove.
3078 (arm_find_mapping_symbol): Adjust to section_maps type change.
3079 (arm_objfile_data_free): Call delete on arm_per_objfile.
3080 (arm_record_special_symbol): Adjust to section_maps type change.
3081 Allocate arm_per_objfile with new.
3082
b65b566c
PW
30832019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3084
3085 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3086 with the command prefix.
3087
c2fc64f5
TT
30882019-06-25 Tom Tromey <tom@tromey.com>
3089
3090 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3091 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3092
fb54fa76
TT
30932019-06-25 Tom Tromey <tom@tromey.com>
3094
3095 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3096 type.
3097 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3098 protected.
3099
f7952c57
TT
31002019-06-25 Tom Tromey <tom@tromey.com>
3101
3102 * tui/tui-winsource.c
3103 (tui_source_window_base::set_is_exec_point_at): Add check against
3104 LOA_ADDRESS.
3105
17568d78
TT
31062019-06-25 Tom Tromey <tom@tromey.com>
3107
3108 * tui/tui-source.c (tui_set_source_content): Don't check before
3109 xfree.
3110 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3111
53e7cdba
TT
31122019-06-25 Tom Tromey <tom@tromey.com>
3113
3114 * tui/tui-winsource.h (tui_update_source_window_as_is)
3115 (tui_alloc_source_buffer, tui_line_is_displayed)
3116 (tui_addr_is_displayed): Change type of win_info.
3117 * tui/tui-winsource.c (tui_update_source_window_as_is)
3118 (tui_clear_source_content, tui_show_source_line)
3119 (tui_show_source_content, tui_source_window_base::refill)
3120 (tui_source_window_base::set_is_exec_point_at)
3121 (tui_source_window_base::set_is_exec_point_at)
3122 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3123 (tui_alloc_source_buffer, tui_line_is_displayed)
3124 (tui_addr_is_displayed): Change type of win_info. Update.
3125 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3126 (tui_source_window_base::do_make_visible_with_new_height):
3127 Update.
3128 * tui/tui-source.c (tui_set_source_content)
3129 (tui_set_source_content_nil)
3130 (tui_source_window::do_scroll_vertical): Update.
3131 * tui/tui-layout.c (show_layout): Update.
3132 * tui/tui-disasm.c (tui_set_disassem_content)
3133 (tui_disasm_window::do_scroll_vertical): Update.
3134 * tui/tui-data.h (tui_win_content): Remove.
3135 (struct tui_gen_win_info) <content, content_size>: Remove.
3136 (struct tui_source_element): Add initializers and destructor.
3137 (union tui_which_element, struct tui_win_element): Remove.
3138 (struct tui_source_window_base) <content>: New field.
3139 (struct tui_data_window): Remove destructor.
3140 (tui_alloc_content, tui_free_win_content)
3141 (tui_free_all_source_wins_content): Don't declare.
3142 * tui/tui-data.c (tui_initialize_static_data): Update.
3143 (init_content_element, tui_alloc_content): Remove.
3144 (~tui_gen_win_info): Update.
3145 (~tui_data_window, tui_free_all_source_wins_content)
3146 (tui_free_win_content, free_content, free_content_elements):
3147 Remove.
3148
7908abbf
TT
31492019-06-25 Tom Tromey <tom@tromey.com>
3150
3151 * tui/tui-winsource.h (tui_clear_source_content)
3152 (tui_erase_source_content, tui_show_source_content): Change type
3153 of win_info.
3154 * tui/tui-winsource.c (tui_clear_source_content)
3155 (tui_erase_source_content, tui_show_source_content): Change type
3156 of win_info.
3157 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3158 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3159 win_info.
3160 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3161 win_info.
3162 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3163
02c28df0
TT
31642019-06-25 Tom Tromey <tom@tromey.com>
3165
3166 * tui/tui-winsource.c (tui_clear_source_content)
3167 (tui_source_window_base::set_is_exec_point_at): Update.
3168 * tui/tui-source.c (tui_set_source_content_nil): Update.
3169 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3170 a bool.
3171 * tui/tui-data.c (init_content_element): Update.
3172
6658b1bf
TT
31732019-06-25 Tom Tromey <tom@tromey.com>
3174
3175 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3176 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3177 * tui/tui-layout.c (init_and_make_win): Update.
3178 * tui/tui.h (enum tui_win_type): Update.
3179 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3180 tui_win_is_auxillary.
3181 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3182 tui_win_is_auxillary.
3183
21e1c91e
TT
31842019-06-25 Tom Tromey <tom@tromey.com>
3185
3186 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3187 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3188 (tui_delete_data_content_windows, tui_display_all_data)
3189 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3190 Update.
3191 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3192 * tui/tui-regs.c (tui_last_regs_line_no)
3193 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3194 (tui_show_registers): Update.
3195 (tui_show_register_group): Return void. Update.
3196 (tui_display_registers_from, tui_display_reg_element_at_line)
3197 (tui_display_registers_from_line, tui_check_register_values):
3198 Update.
3199 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3200 member.
3201 (struct tui_data_window) <regs_content>: Now a std::vector.
3202 <regs_content_count>: Remove.
3203 (tui_add_content_elements, tui_free_data_content): Don't declare.
3204 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3205 (init_content_element): Remove DATA_WIN case. Add assert.
3206 (tui_add_content_elements): Remove.
3207 (tui_data_window): Update.
3208 (tui_free_data_content): Remove.
3209 (free_content_elements): Remove DATA_WIN case.
3210
115ac53b
TT
32112019-06-25 Tom Tromey <tom@tromey.com>
3212
3213 * tui/tui-data.c (tui_data_item_window): Update.
3214 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3215 * tui/tui-windata.c (tui_display_all_data)
3216 (tui_display_data_from_line): Update.
3217 (tui_check_data_values): Remove.
3218 * tui/tui-regs.c (tui_show_register_group)
3219 (tui_display_reg_element_at_line): Update.
3220 * tui/tui-hooks.c (tui_register_changed)
3221 (tui_refresh_frame_and_register_information): Call
3222 tui_check_register_values.
3223 * tui/tui-data.h (struct tui_data_window) <data_content,
3224 data_content_count, data_type>: Remove.
3225 (enum tui_data_type): Remove.
3226
3227 * tui/tui-data.c (tui_data_window::clear_detail)
3228 (~tui_data_window): Update.
3229
eaf9738b
TT
32302019-06-25 Tom Tromey <tom@tromey.com>
3231
3232 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3233 declare.
3234 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3235 Rename from tui_first_data_item_displayed. Update.
3236 (tui_data_window::refresh_all)
3237 (tui_data_window::do_scroll_vertical): Update.
3238 * tui/tui-data.h (struct tui_data_window)
3239 <first_data_item_displayed>: Declare new method.
3240
31ca4723
TT
32412019-06-25 Tom Tromey <tom@tromey.com>
3242
3243 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3244 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3245 contents...
3246 (tui_initialize_static_data): ...here.
3247
41bcff7f
TT
32482019-06-25 Tom Tromey <tom@tromey.com>
3249
3250 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3251 (tui_display_registers_from, tui_check_register_values): Update.
3252 (tui_display_register): Remove win_info parameter; update.
3253 (tui_get_register): Change type of parameters.
3254 * tui/tui-data.h (struct tui_data_element): Remove.
3255 (union tui_which_element) <data>: Remove.
3256 <data_window>: Change type.
3257 (struct tui_data_item_window): New.
3258 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3259 case. Add assert.
3260 (~tui_data_item_window): New destructor.
3261 (free_content_elements): Remove DATA_ITEM_WIN case.
3262
d2802c33
TT
32632019-06-25 Tom Tromey <tom@tromey.com>
3264
3265 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3266 Remove.
3267
dd835f8b
TT
32682019-06-25 Tom Tromey <tom@tromey.com>
3269
3270 * tui/tui-data.h (struct tui_command_element): Remove.
3271 (union tui_which_element) <command>: Remove.
3272 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3273 assert.
3274 (free_content_elements): Remove CMD_WIN case.
3275
bd7db367
TT
32762019-06-25 Tom Tromey <tom@tromey.com>
3277
3278 * tui/tui-layout.c (tui_set_layout): Update.
3279 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3280 * tui/tui-data.c (layout_def): Update.
3281
3add462f
TT
32822019-06-25 Tom Tromey <tom@tromey.com>
3283
3284 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3285 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3286 (tui_source_window_base::set_new_height): Update.
3287 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3288 Update.
3289 (tui_set_locator_fullname, tui_set_locator_info)
3290 (tui_show_frame_info): Update.
3291 * tui/tui-source.c (tui_set_source_content)
3292 (tui_source_is_displayed): Update.
3293 * tui/tui-layout.c (show_source_disasm_command, show_data)
3294 (show_source_or_disasm_and_command): Update.
3295 * tui/tui-disasm.c (tui_set_disassem_content)
3296 (tui_get_begin_asm_address): Update.
3297 * tui/tui-data.h (struct tui_locator_element): Remove.
3298 (union tui_which_element) <locator>: Remove.
3299 (struct tui_locator_window): New.
3300 (tui_locator_win_info_ptr): Change return type.
3301 * tui/tui-data.c (_locator): Change type.
3302 (tui_locator_win_info_ptr): Change return type.
3303 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3304 (tui_alloc_content): Add assert.
3305
489e9d8b
TT
33062019-06-25 Tom Tromey <tom@tromey.com>
3307
3308 * tui/tui-winsource.c
3309 (tui_exec_info_window::maybe_allocate_content): New method.
3310 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3311 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3312 (make_source_or_disasm_window): Add cast.
3313 * tui/tui-data.h (union tui_which_element) <simple_string>:
3314 Remove.
3315 (struct tui_source_info): New.
3316 (struct tui_source_window_base) <execution_info>: Change type.
3317 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3318 case, and add assert.
3319 (tui_alloc_content): Add assert.
3320
c3fabb7d
TT
33212019-06-25 Tom Tromey <tom@tromey.com>
3322
3323 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3324 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3325 * tui/tui-data.c (tui_alloc_win_info): Remove.
3326
bbc228ee
TT
33272019-06-25 Tom Tromey <tom@tromey.com>
3328
3329 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3330 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3331 can_highlight.
3332
5fcee43a
TT
33332019-06-25 Tom Tromey <tom@tromey.com>
3334
3335 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3336 make_visible_with_new_height method.
3337 (tui_win_info::make_visible_with_new_height): New method.
3338 (tui_source_window_base::do_make_visible_with_new_height)
3339 (tui_data_window::do_make_visible_with_new_height)
3340 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3341 (make_visible_with_new_height): Remove.
3342 (tui_resize_all, tui_adjust_win_heights): Use
3343 make_visible_with_new_height method.
3344 * tui/tui-data.h (struct tui_win_info)
3345 <do_make_visible_with_new_height, make_visible_with_new_height>:
3346 New methods.
3347 (struct tui_source_window_base, struct tui_data_window)
3348 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3349 methods.
3350
d83f1fe6
TT
33512019-06-25 Tom Tromey <tom@tromey.com>
3352
3353 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3354 method.
3355 (update_tab_width): Call update_tab_width method.
3356 * tui/tui-data.h (struct tui_win_info)
3357 (struct tui_source_window_base) <update_tab_width>: New methods.
3358
17374de4
TT
33592019-06-25 Tom Tromey <tom@tromey.com>
3360
3361 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3362 parameter.
3363 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3364 parameter.
3365 (tui_gen_win_info::make_visible): Update.
3366 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3367 parameter.
3368 * tui/tui-data.h (enum tui_box): New enum.
3369 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3370
f936bca2
TT
33712019-06-25 Tom Tromey <tom@tromey.com>
3372
3373 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3374 init_and_make_win for EXEC_INFO_WIN.
3375 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3376 longer inline.
3377 (struct tui_win_info) <~tui_win_info>: Inline.
3378 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3379 Don't declare.
3380 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3381 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3382 Remove.
3383 (tui_initialize_static_data): Update.
3384 (~tui_gen_win_info): Handle more cleanup here.
3385 (~tui_source_window_base): Delete "execution_info".
3386 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3387
d6ba6a11
TT
33882019-06-25 Tom Tromey <tom@tromey.com>
3389
3390 * tui/tui-layout.c (make_command_window): Don't set
3391 can_highlight.
3392 (show_source_disasm_command): Call the reset method.
3393 (show_data): Don't set can_highlight. Call the reset method.
3394 (tui_gen_win_info::reset): Rename from init_gen_win_info
3395 (init_and_make_win): Simplify. Return tui_gen_win_info.
3396 (show_source_or_disasm_and_command): Call the reset method.
3397 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3398 (struct tui_cmd_window): Set can_highlight.
3399
48a3bd16
TT
34002019-06-25 Tom Tromey <tom@tromey.com>
3401
3402 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3403 from make_visible.
3404 (tui_make_visible, tui_make_invisible): Rewrite.
3405 (tui_win_info::make_visible): Remove.
3406 (tui_source_window_base::make_visible): Update.
3407 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3408 method. Moved from...
3409 (struct tui_win_info) <make_visible>: ...here.
3410
c3bd716f
TT
34112019-06-25 Tom Tromey <tom@tromey.com>
3412
3413 * tui/tui-winsource.c
3414 (tui_source_window_base::do_scroll_horizontal): Remove direction
3415 parameter.
3416 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3417 direction parameter.
3418 * tui/tui-win.c (tui_win_info::forward_scroll)
3419 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3420 (tui_win_info::right_scroll): Update.
3421 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3422 direction parameter.
3423 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3424 direction parameter.
3425 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3426 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3427 Remove direction parameter.
3428 (struct tui_source_window_base, struct tui_source_window)
3429 (struct tui_disasm_window, struct tui_data_window)
3430 (struct tui_cmd_window): Update.
3431
21c32dca
TT
34322019-06-25 Tom Tromey <tom@tromey.com>
3433
3434 * tui/tui-winsource.h (tui_set_exec_info_content)
3435 (tui_show_exec_info_content, tui_erase_exec_info_content)
3436 (tui_clear_exec_info_content, tui_update_exec_info): Change
3437 argument to tui_source_window_base.
3438 * tui/tui-winsource.c (tui_set_exec_info_content)
3439 (tui_show_exec_info_content, tui_erase_exec_info_content)
3440 (tui_clear_exec_info_content, tui_update_exec_info): Change
3441 argument to tui_source_window_base.
3442
73fbdc65
TT
34432019-06-25 Tom Tromey <tom@tromey.com>
3444
3445 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3446 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3447
33325343
TT
34482019-06-25 Tom Tromey <tom@tromey.com>
3449
3450 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3451 check.
3452
29d2c474
TT
34532019-06-25 Tom Tromey <tom@tromey.com>
3454
3455 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3456 type to void.
3457 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3458 type to void.
3459 * tui/tui-source.c (tui_set_source_content): Update.
3460 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3461
152f3f4b
TT
34622019-06-25 Tom Tromey <tom@tromey.com>
3463
3464 * tui/tui-win.c (window_name_completer, tui_set_focus)
3465 (tui_all_windows_info): Use name method.
3466 * tui/tui-data.h (struct tui_gen_win_info)
3467 (struct tui_source_window, struct tui_disasm_window)
3468 (struct tui_data_window, struct tui_cmd_window) <name>: New
3469 method.
3470 (tui_win_name): Don't declare.
3471 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3472 (tui_win_name): Remove.
3473
be4da588
TT
34742019-06-25 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-winsource.h (tui_update_source_window)
3477 (tui_update_source_window_as_is): Change parameter type.
3478 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3479 to be a tui_source_window_base.
3480 (tui_update_source_window_as_is): Likewise.
3481 * tui/tui-win.c (make_visible_with_new_height): Update.
3482
5b81daba
TT
34832019-06-25 Tom Tromey <tom@tromey.com>
3484
3485 * tui/tui-winsource.c (tui_erase_source_content)
3486 (tui_show_source_content, tui_show_exec_info_content)
3487 (tui_erase_exec_info_content): Use refresh_window method.
3488 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3489 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3490 from tui_refresh_win.
3491 (tui_data_window::refresh_window): New method.
3492 (tui_win_info::refresh, tui_source_window_base::refresh)
3493 (tui_refresh_all): Use refresh_window method.
3494 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3495 method.
3496 * tui/tui-regs.c (tui_display_register): Call refresh_window
3497 method.
3498 * tui/tui-layout.c (show_source_disasm_command)
3499 (show_source_or_disasm_and_command): Call refresh_window method.
3500 * tui/tui-data.h (struct tui_gen_win_info)
3501 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3502 New method.
3503
cb2ce893
TT
35042019-06-25 Tom Tromey <tom@tromey.com>
3505
3506 * tui/tui.c (tui_rl_other_window, tui_enable)
3507 (tui_is_window_visible, tui_get_command_dimension): Update.
3508 * tui/tui-winsource.c (tui_update_source_window_as_is)
3509 (tui_clear_source_content, tui_erase_source_content)
3510 (tui_show_source_line, tui_source_window_base::refill)
3511 (tui_source_window_base::do_scroll_horizontal)
3512 (tui_source_window_base::set_is_exec_point_at)
3513 (tui_update_breakpoint_info, tui_set_exec_info_content)
3514 (tui_alloc_source_buffer, tui_line_is_displayed)
3515 (tui_addr_is_displayed): Update.
3516 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3517 (tui_check_and_display_highlight_if_needed)
3518 (tui_win_info::make_visible, tui_win_info::refresh)
3519 (tui_refresh_all): Update.
3520 * tui/tui-windata.c (tui_first_data_item_displayed)
3521 (tui_delete_data_content_windows, tui_erase_data_content)
3522 (tui_display_all_data, tui_data_window::refresh_all)
3523 (tui_check_data_values): Update.
3524 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3525 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3526 (tui_win_info::backward_scroll, tui_refresh_all_win)
3527 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3528 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3529 (tui_source_window_base::set_new_height)
3530 (tui_data_window::set_new_height)
3531 (make_invisible_and_set_new_height)
3532 (make_visible_with_new_height, new_height_ok)
3533 (parse_scrolling_args): Update.
3534 * tui/tui-stack.c (tui_show_frame_info): Update.
3535 * tui/tui-source.c (tui_set_source_content)
3536 (tui_set_source_content_nil, tui_source_is_displayed)
3537 (tui_source_window::do_scroll_vertical): Update.
3538 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3539 (tui_display_registers_from, tui_display_reg_element_at_line)
3540 (tui_check_register_values, tui_reg_command): Update.
3541 * tui/tui-layout.c (tui_default_win_height)
3542 (show_source_disasm_command, show_data, init_and_make_win)
3543 (show_source_or_disasm_and_command): Update.
3544 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3545 (tui_redisplay_readline, tui_mld_flush)
3546 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3547 (tui_getc): Update.
3548 * tui/tui-disasm.c (tui_set_disassem_content)
3549 (tui_disasm_window::do_scroll_vertical): Update.
3550 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3551 Now virtual.
3552 (struct tui_win_info): Derive from tui_gen_win_info.
3553 <~tui_win_info>: Mark as override.
3554 <generic>: Remove member.
3555 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3556 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3557 (~tui_data_window, ~tui_win_info)
3558 (tui_free_all_source_wins_content): Update.
3559 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3560
ab313b35
TT
35612019-06-25 Tom Tromey <tom@tromey.com>
3562
3563 * tui/tui-layout.c (init_and_make_win): Use new.
3564 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3565 destructor, initializers.
3566 (tui_alloc_generic_win_info): Don't declare.
3567 * tui/tui-data.c (_locator): Add argument to constructor.
3568 (source_win, disasm_win): New globals.
3569 (exec_info): Remove.
3570 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3571 Update.
3572 (tui_alloc_generic_win_info): Remove.
3573 (init_content_element): Use new.
3574 (tui_win_info::tui_win_info): Update.
3575 (free_content_elements) <case DATA_WIN>: Use delete.
3576
dc2c33e4
TT
35772019-06-25 Tom Tromey <tom@tromey.com>
3578
3579 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3580 * tui/tui-windata.c (tui_first_data_item_displayed)
3581 (tui_delete_data_content_windows): Update.
3582 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3583 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3584 (tui_display_registers_from, tui_check_register_values): Update.
3585 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3586 pointer.
3587 * tui/tui-data.c (init_content_element): Update. Allocate the new
3588 window.
3589 (tui_free_data_content): Update.
3590 (free_content_elements) <case DATA_WIN>: Free the window.
3591
214a5cbe
TT
35922019-06-25 Tom Tromey <tom@tromey.com>
3593
3594 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3595 Update.
3596 * tui/tui-layout.c (make_command_window)
3597 (show_source_disasm_command, show_data, init_and_make_win)
3598 (show_source_or_disasm_and_command): Update.
3599 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3600 method.
3601 <can_highight, is_highlighted>: Now bool.
3602 (tui_set_win_highlight): Don't declare.
3603 * tui/tui-data.c (tui_set_win_highlight): Remove.
3604
8e2daf15
TT
36052019-06-25 Tom Tromey <tom@tromey.com>
3606
3607 * tui/tui-wingeneral.c (make_visible): Remove check of window
3608 type.
3609
8903bd8a
TT
36102019-06-25 Tom Tromey <tom@tromey.com>
3611
3612 * tui/tui-win.c (tui_win_info::max_height)
3613 (tui_cmd_window::max_height): New methods.
3614 (new_height_ok): Call max_height.
3615 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3616 <max_height>: New method.
3617
3f02ce1e
TT
36182019-06-25 Tom Tromey <tom@tromey.com>
3619
3620 * tui/tui-win.c (tui_source_window_base::set_new_height)
3621 (tui_data_window::set_new_height): New methods.
3622 (make_invisible_and_set_new_height): Call set_new_height method.
3623 * tui/tui-data.h (struct tui_win_info)
3624 (struct tui_source_window_base, struct tui_data_window)
3625 <set_new_height>: New method.
3626
1825f487
TT
36272019-06-25 Tom Tromey <tom@tromey.com>
3628
3629 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3630 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3631 tui_refresh_data_win.
3632 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3633 method.
3634 (tui_refresh_all_win): Call the refresh_all method.
3635 (tui_set_focus): Likewise.
3636 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3637 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3638 Likewise.
3639
ad54d15b
TT
36402019-06-25 Tom Tromey <tom@tromey.com>
3641
3642 * tui/tui-winsource.h (tui_refill_source_window)
3643 (tui_set_is_exec_point_at): Don't declare.
3644 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3645 (tui_source_window_base::refill): Rename from
3646 tui_refill_source_window.
3647 (tui_source_window_base::do_scroll_horizontal): Update.
3648 (tui_source_window_base::set_is_exec_point_at): Rename from
3649 tui_set_is_exec_point_at.
3650 (tui_update_all_breakpoint_info): Update.
3651 * tui/tui-stack.c (tui_show_frame_info): Update.
3652 * tui/tui-layout.c (show_data): Add cast.
3653 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3654 * tui/tui-data.h (struct tui_source_window_base) <refill,
3655 set_is_exec_point_at>: New methods.
3656 (tui_source_windows, tui_add_to_source_windows): Update types.
3657 (tui_add_to_source_windows): Remove redundant declaration.
3658 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3659 (tui_source_windows): Change return type.
3660 (tui_clear_source_windows_detail): Update.
3661 (tui_add_to_source_windows): Change type of parameter.
3662 (tui_free_all_source_wins_content): Update.
3663
2042b506
TT
36642019-06-25 Tom Tromey <tom@tromey.com>
3665
3666 * tui/tui-wingeneral.c (tui_win_info::refresh)
3667 (tui_source_window_base::refresh): New methods.
3668 (tui_refresh_all): Call the refresh method.
3669 * tui/tui-data.h (struct tui_win_info)
3670 (struct tui_source_window_base) <refresh>: New method.
3671
56122977
TT
36722019-06-25 Tom Tromey <tom@tromey.com>
3673
3674 * tui/tui.h (tui_is_window_visible): Return bool.
3675 * tui/tui.c (tui_is_window_visible): Return bool.
3676 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3677 (tui_make_visible, tui_make_invisible)
3678 (tui_win_info::make_visible)
3679 (tui_source_window_base::make_visible, make_all_visible)
3680 (tui_make_all_visible, tui_make_all_invisible): Update.
3681 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3682 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3683 bool.
3684 (struct tui_win_info, struct tui_source_window_base)
3685 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3686 * tui/tui-data.c (tui_init_generic_part): Update.
3687
cda37efb
TT
36882019-06-25 Tom Tromey <tom@tromey.com>
3689
3690 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3691 (tui_source_window_base::make_visible): New methods.
3692 (make_all_visible): Make method call.
3693 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3694 (struct tui_source_window_base, struct tui_cmd_window): Override
3695 make_visible.
3696 (tui_win_is_source_type): Don't declare.
3697 * tui/tui-data.c (tui_win_is_source_type): Remove.
3698
6a0ee02c
TT
36992019-06-25 Tom Tromey <tom@tromey.com>
3700
3701 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3702 NULL check.
3703
63901aec
TT
37042019-06-25 Tom Tromey <tom@tromey.com>
3705
3706 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3707 Inline constructor. Add initializers for members.
3708 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3709 constructors; now inline in class.
3710
ceb13a13
TT
37112019-06-25 Tom Tromey <tom@tromey.com>
3712
3713 * tui/tui-regs.c (tui_show_registers): Update.
3714 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3715 bool.
3716 * tui/tui-data.c (tui_data_window::clear_detail)
3717 (tui_data_window): Update.
3718
238eb706
TT
37192019-06-25 Tom Tromey <tom@tromey.com>
3720
3721 * tui/tui-windata.c (tui_display_all_data)
3722 (tui_display_data_from_line, tui_display_data_from)
3723 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3724 Update.
3725 * tui/tui-regs.c (tui_last_regs_line_no)
3726 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3727 (tui_show_registers, tui_show_register_group)
3728 (tui_display_registers_from, tui_display_reg_element_at_line)
3729 (tui_display_registers_from_line, tui_check_register_values)
3730 (tui_reg_next, tui_reg_prev): Update.
3731 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3732 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3733 tui_data_window.
3734 (struct tui_win_info) <detail>: Remove. Add new fields from
3735 tui_data_info.
3736 (TUI_DATA_WIN): Add cast.
3737 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3738 (~tui_data_window): Simplify.
3739
81491aa0
TT
37402019-06-25 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-layout.c (show_source_disasm_command)
3743 (show_source_or_disasm_and_command): Update.
3744 * tui/tui-io.c (update_cmdwin_start_line)
3745 (tui_redisplay_readline): Update.
3746 * tui/tui-data.h (struct tui_command_info): Remove.
3747 (struct tui_win_info) <detail>: Remove command_info member.
3748 (struct tui_data_window) <start_line>: New member, from
3749 tui_command_info.
3750 (TUI_CMD_WIN): Add casts.
3751
e6e41501
TT
37522019-06-25 Tom Tromey <tom@tromey.com>
3753
3754 * tui/tui-winsource.c (tui_update_source_window)
3755 (tui_refill_source_window)
3756 (tui_source_window_base::do_scroll_horizontal)
3757 (tui_update_breakpoint_info, tui_set_exec_info_content)
3758 (tui_show_exec_info_content, tui_erase_exec_info_content)
3759 (tui_clear_exec_info_content): Update.
3760 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3761 Update.
3762 * tui/tui-win.c (make_invisible_and_set_new_height)
3763 (make_visible_with_new_height): Update.
3764 * tui/tui-source.c (tui_set_source_content)
3765 (tui_show_symtab_source): Update.
3766 * tui/tui-layout.c (extract_display_start_addr)
3767 (show_source_disasm_command, show_data)
3768 (make_source_or_disasm_window)
3769 (show_source_or_disasm_and_command): Update.
3770 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3771 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3772 "gdbarch".
3773 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3774 to tui_source_window_base.
3775 (struct tui_win_info) <detail>: Remove source_info member.
3776 (struct tui_source_window_base) <has_locator>: Inline.
3777 Move contents from tui_source_info; rename has_locator member to
3778 m_has_locator.
3779 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3780 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3781 header file.
3782 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3783 Simplify.
3784 (tui_free_all_source_wins_content): Cast to
3785 tui_source_window_base.
3786
44f0e208
TT
37872019-06-25 Tom Tromey <tom@tromey.com>
3788
3789 * tui/tui-win.c (make_invisible_and_set_new_height)
3790 (make_visible_with_new_height): Call has_locator method.
3791 * tui/tui-layout.c (show_source_disasm_command, show_data)
3792 (show_source_or_disasm_and_command): Update for bool change.
3793 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3794 (tui_win_info) <has_locator>: New method.
3795 (struct tui_source_window_base) <has_locator>: New method.
3796 (tui_win_has_locator): Don't declare.
3797 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3798 from tui_win_has_locator.
3799 (tui_source_window_base): Use false, not FALSE.
3800
7778b912
TT
38012019-06-25 Tom Tromey <tom@tromey.com>
3802
3803 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3804 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3805 clear_detail method directly.
3806 (tui_clear_win_detail): Remove.
3807
f83d391c
TT
38082019-06-25 Tom Tromey <tom@tromey.com>
3809
3810 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3811 "this", not TUI_DISASM_WIN.
3812
13446e05
TT
38132019-06-25 Tom Tromey <tom@tromey.com>
3814
3815 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3816 declare.
3817 * tui/tui-winsource.c
3818 (tui_source_window_base::do_scroll_horizontal): Rename from
3819 tui_horizontal_source_scroll.
3820 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3821 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3822 from tui_vertical_data_scroll.
3823 * tui/tui-win.h (tui_scroll): Don't declare.
3824 * tui/tui-win.c (tui_win_info::forward_scroll)
3825 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3826 (tui_win_info::right_scroll): Rename and update.
3827 (tui_scroll_forward_command, tui_scroll_backward_command)
3828 (tui_scroll_left_command, tui_scroll_right_command): Update.
3829 (tui_scroll): Remove.
3830 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3831 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3832 from tui_vertical_source_scroll.
3833 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3834 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3835 from tui_vertical_disassem_scroll.
3836 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3837 do_scroll_horizontal>: New methods.
3838 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3839 Likewise.
3840 (struct tui_source_window_base): Add do_scroll_horizontal.
3841 (struct tui_source_window, struct tui_disasm_window): Add
3842 do_scroll_vertical.
3843 (struct tui_data_window, struct tui_cmd_window): Add
3844 do_scroll_horizontal and do_scroll_vertical.
3845 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3846
5cf82909
TT
38472019-06-25 Tom Tromey <tom@tromey.com>
3848
3849 * tui/tui-data.h (struct tui_source_window_base): New struct.
3850 (struct tui_source_window): Derive from tui_source_window_base.
3851 (struct tui_disasm_window): New struct.
3852 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3853 from tui_source_window::clear_detail.
3854 (tui_source_window_base): Rename from tui_source_window.
3855 (~tui_source_window_base): Rename from ~tui_source_window.
3856 (tui_alloc_win_info): Create a tui_disasm_window.
3857
ee1d42d6
TT
38582019-06-25 Tom Tromey <tom@tromey.com>
3859
3860 * tui/tui-data.h (struct tui_source_window)
3861 (struct tui_data_window): Declare destructors.
3862 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3863 destructors.
3864 (tui_win_info): Simplify.
3865
b4eb2452
TT
38662019-06-25 Tom Tromey <tom@tromey.com>
3867
3868 * tui/tui-winsource.c (tui_display_main)
3869 (tui_update_source_windows_with_addr)
3870 (tui_update_all_breakpoint_info): Update.
3871 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3872 (new_height_ok, parse_scrolling_args): Update.
3873 * tui/tui-stack.c (tui_show_frame_info): Update.
3874 * tui/tui-data.h (struct tui_list): Remove.
3875 (tui_source_windows): Return a reference to a std::vector.
3876 * tui/tui-data.c (source_windows): Now a std::vector.
3877 (tui_source_windows): Change return type.
3878 (tui_clear_source_windows): Rewrite.
3879 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3880 (tui_free_all_source_wins_content): Rewrite.
3881
8761a91b
TT
38822019-06-25 Tom Tromey <tom@tromey.com>
3883
3884 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3885 (struct tui_data_window, struct tui_cmd_window): Declare
3886 clear_detail method.
3887 * tui/tui-data.c (tui_source_window::clear_detail)
3888 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3889 methods.
3890 (tui_clear_win_detail): Simplify.
3891
0ed69eda
TT
38922019-06-25 Tom Tromey <tom@tromey.com>
3893
3894 * tui/tui-layout.c (make_source_window, make_disasm_window)
3895 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3896 Return the new window.
3897 (show_source_disasm_command, show_data)
3898 (show_source_or_disasm_and_command): Update.
3899
82432e10
TT
39002019-06-25 Tom Tromey <tom@tromey.com>
3901
3902 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3903 parameter. Return the new window.
3904 (show_source_disasm_command): Update and remove NULL check.
3905 (show_source_or_disasm_and_command): Update.
3906
ec328aa5
TT
39072019-06-25 Tom Tromey <tom@tromey.com>
3908
3909 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3910
33b906ab
TT
39112019-06-25 Tom Tromey <tom@tromey.com>
3912
3913 * tui/tui-data.h (struct tui_win_info): Make constructor
3914 protected. Make destructor virtual. Add initializers.
3915 (tui_source_window, tui_data_window, tui_cmd_window): New
3916 classes.
3917 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3918 constructor. Add "type" parameter.
3919 (tui_source_window, tui_data_window, tui_cmd_window): New
3920 constructors.
3921 (tui_alloc_win_info): Instantiate the appropriate subclass.
3922
e7e11af4
TT
39232019-06-25 Tom Tromey <tom@tromey.com>
3924
3925 * tui/tui-win.c (tui_resize_all): Use delete.
3926 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3927 destructor.
3928 (tui_free_window): Don't declare.
3929 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3930 Update.
3931
6792b55e
TT
39322019-06-25 Tom Tromey <tom@tromey.com>
3933
3934 * tui/tui-data.h (struct tui_win_info): Add constructor.
3935 * tui/tui-data.c (tui_alloc_win_info): Use new.
3936 (tui_free_window): Use delete.
3937
f95675e1
TT
39382019-06-22 Tom Tromey <tom@tromey.com>
3939
3940 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3941 declare.
3942 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3943
5bff081c
TT
39442019-06-22 Tom Tromey <tom@tromey.com>
3945
3946 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3947 declare.
3948 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3949
47e3f474
TV
39502019-06-22 Tom de Vries <tdevries@suse.de>
3951
3952 * dwarf2read.c (create_addrmap_from_aranges)
3953 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3954 instead of '%zu'.
3955
fd5866f6
SM
39562019-06-21 Simon Marchi <simon.marchi@efficios.com>
3957
3958 * dwarf2read.h (dwarf2_section_info_def): Remove.
3959 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3960 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3961 std::vector<dwarf2_section_info>.
3962 (struct dwo_file) <~dwo_file>: Remove.
3963 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3964 types field.
3965 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3966 (dwarf2_read_debug_names): Likewise.
3967 (create_debug_types_hash_table): Change parameter type to
3968 array_view, adjust code accordingly.
3969 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3970 (partial_die_info::fixup): Likewise.
3971 (determine_prefix): Likewise.
3972 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3973
fb1eb2f9
SM
39742019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3975
3976 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3977 gdb_bfd_ref_ptr.
3978 <~dwo_file>: Remove call to gdb_bfd_unref.
3979 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3980 gdb_bfd_ref_ptr::get.
3981
51ac9db5
SM
39822019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3983
3984 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3985 type to htab_up.
3986 * dwarf2read.c (struct dwo_file): Initialize fields.
3987 <~dwo_file>: New.
3988 (free_dwo_file): Remove, move content to ~dwo_file.
3989 (struct dwo_file_deleter): Remove.
3990 (dwo_file_up>: Remove custom deleter.
3991 (free_dwo_files): Remove.
3992 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3993 dwo_files.
3994 (process_skeletonless_type_units): Call unique_ptr::get.
3995 (allocate_dwo_file_hash_table): Add deleter to created hash
3996 table. Change return type to htab_up.
3997 (lookup_dwo_file_slot): Don't memset dwo_file, call
3998 unique_ptr::get.
3999 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4000 (create_dwo_unit_in_dwp_v2): Likewise.
4001 (open_and_init_dwo_file): Likewise.
4002 (free_dwo_file_from_slot): Remove.
4003
dc4ccb6f
SM
40042019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4005
4006 * dwarf2read.h (struct dwarf2_section_info) <readin,
4007 is_virtual>: Change type to bool.
4008 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4009 true instead of 1.
4010
e6a1c5cb
TT
40112019-06-19 Tom Tromey <tom@tromey.com>
4012
4013 * tui/tui-data.h (tui_init_content_element): Don't declare.
4014
6f6ffbeb
TT
40152019-06-19 Tom Tromey <tom@tromey.com>
4016
4017 * tui/tui-data.h (tui_init_win_info): Don't declare.
4018
f23f598e
TV
40192019-06-19 Tom de Vries <tdevries@suse.de>
4020
4021 * dwarf2read.h (abstract_to_concrete): Change type to
4022 std::unordered_map<sect_offset, std::vector<sect_offset>,
4023 gdb::hash_enum<sect_offset>>.
4024
680e1bee
TT
40252019-06-19 Tom Tromey <tromey@adacore.com>
4026
4027 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4028 EVAL_AVOID_SIDE_EFFECTS specially.
4029
dcf37923
TT
40302019-06-19 Tom Tromey <tromey@adacore.com>
4031
4032 * source-cache.c (highlighter): New global.
4033 (source_cache::get_source_lines): Create a highlighter on demand.
4034
494986d5
AB
40352019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4036
4037 * defs.h (deprecated_interactive_hook): Delete declaration.
4038 * interps.c (clear_interpreter_hooks): Remove use of
4039 deprecated_interactive_hook.
4040 * top.c (deprecated_interactive_hook): Delete definition.
4041 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4042
3360b6e7
TV
40432019-06-18 Tom de Vries <tdevries@suse.de>
4044
4045 PR gdb/24515
4046 * dwarf2read.h (abstract_to_concrete): Change type from
4047 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4048 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4049 * dwarf2read.c (read_variable): Update.
4050 (dwarf2_fetch_die_loc_sect_off): Update.
4051
310b3441
TV
40522019-06-17 Tom de Vries <tdevries@suse.de>
4053
4054 PR gdb/24617
4055 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4056 accessing parent[parent_len - 1].
4057
ba9777be
PP
40582019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4059
4060 PR gdb/24364
4061 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4062 call dtrace_process_dof with NULL dof.
4063
2b9f6e89
TV
40642019-06-16 Tom de Vries <tdevries@suse.de>
4065
4066 PR gdb/24445
4067 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4068
431b3ead
TT
40692019-06-16 Tom Tromey <tom@tromey.com>
4070
4071 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4072 (make_all_visible): Use address of member.
4073
d04b44a1
TT
40742019-06-16 Tom Tromey <tom@tromey.com>
4075
4076 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4077 (tui_free_window, free_content, free_content_elements): Remove
4078 unnecessary cast.
4079 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4080 cast.
4081 * tui/tui-regs.c (tui_show_register_group)
4082 (tui_display_registers_from, tui_display_reg_element_at_line):
4083 Remove unnecessary cast.
4084
bf5142e7
AB
40852019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4086
4087 * linux-nat.c (normal_mask): Delete.
4088 (_initialize_linux_nat): Don't initialise normal_mask.
4089
c4973306
SM
40902019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4091
4092 PR gdb/24445
4093 * dwarf-index-write.h (write_psymtabs_to_index): Add
4094 dwz_basename parameter.
4095 * dwarf-index-write.c (write_gdbindex): Move file writing to
4096 write_gdbindex_1. Change return type void.
4097 (assert_file_size): Move up, remove filename parameter.
4098 (write_gdbindex_1): New function.
4099 (write_debug_names): Change return type to void, call
4100 assert_file_size.
4101 (struct index_wip_file): New struct.
4102 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4103 file logic to index_wip_file. Write index for dwz file if
4104 needed.
4105 (save_gdb_index_command): Pass basename of dwz file, if present.
4106 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4107 build-id of dwz file, if present.
4108 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4109 (dwarf2_get_dwz_file): Likewise.
4110 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4111 (dwarf2_get_dwz_file): Likewise.
4112
395f9c91
TT
41132019-06-16 Tom Tromey <tom@tromey.com>
4114
4115 * coffread.c (process_coff_symbol): Use xstrdup.
4116 * value.c (create_internalvar): Use xstrdup.
4117
cafb3438
TT
41182019-06-16 Tom Tromey <tom@tromey.com>
4119
4120 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4121 * breakpoint.c (stopin_command, stopat_command)
4122 (until_break_command, decode_location_default): Remove unnecessary
4123 cast.
4124 * utils.c (subset_compare): Remove unnecessary cast.
4125 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4126 cast.
4127 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4128 cast.
4129 * infcmd.c (path_command): Remove unnecessary cast.
4130 * coffread.c (decode_type): Remove unnecessary cast.
4131 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4132 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4133 * tui/tui-stack.c (tui_show_locator_content)
4134 (tui_show_frame_info): Remove unnecessary cast.
4135 * tui/tui-win.c (tui_scroll_forward_command)
4136 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4137 (parse_scrolling_args): Remove unnecessary cast.
4138 * tui/tui-data.c (init_win_info, tui_del_window)
4139 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4140 (free_content_elements): Remove unnecessary cast.
4141 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4142 unnecessary cast.
4143 * tui/tui-source.c (tui_set_source_content)
4144 (tui_vertical_source_scroll): Remove unnecessary cast.
4145 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4146 cast.
4147 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4148 * tui/tui-regs.c (tui_display_registers_from)
4149 (tui_display_register): Remove unnecessary cast.
4150 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4151 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4152 (make_visible): Remove unnecessary cast.
4153 * tui/tui-winsource.c (tui_erase_source_content)
4154 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4155 unnecessary cast.
4156 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4157 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4158 * stabsread.c (read_type, read_array_type, read_range_type):
4159 Remove unnecessary cast.
4160 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4161 (parse_symbol, parse_type, upgrade_type, parse_external)
4162 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4163 unnecessary cast.
4164 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4165
730ead81
TT
41662019-06-16 Tom Tromey <tom@tromey.com>
4167
4168 * tui/tui-data.c (tui_alloc_generic_win_info)
4169 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4170 checks.
4171
584a927c
AB
41722019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4173 Andrew Burgess <andrew.burgess@embecosm.com>
4174
4175 * f-typeprint.c (f_print_type): Don't return early for not
4176 associated or not allocated types.
4177 (f_type_print_varspec_suffix): Add print_rank parameter and print
4178 ranks of array types in case they dangling.
4179 (f_type_print_base): Add print_rank parameter.
4180
30056ea0
AB
41812019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4182
4183 * NEWS: Mention new MI commands.
4184 * break-catch-throw.c (enum exception_event_kind): Move to
4185 breakpoint.h.
4186 (print_mention_exception_catchpoint): Output text as a single
4187 message.
4188 (catch_exception_command_1): Rename to...
4189 (catch_exception_event): ...this, make non-static, update header
4190 command, and change some parameter types.
4191 (catch_catch_command): Update for changes to
4192 catch_exception_command_1.
4193 (catch_throw_command): Likewise.
4194 (catch_rethrow_command): Likewise.
4195 * breakpoint.c (enum exception_event_kind): Delete.
4196 * breakpoint.h (enum exception_event_kind): Moved here from
4197 break-catch-throw.c.
4198 (catch_exception_event): Declare.
4199 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4200 (mi_cmd_catch_throw): New function.
4201 (mi_cmd_catch_rethrow): New function.
4202 (mi_cmd_catch_catch): New function.
4203 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4204 'catch-catch' entries.
4205 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4206 (mi_cmd_catch_rethrow): Declare.
4207 (mi_cmd_catch_catch): Declare.
4208
ec8e2b6d
AB
42092019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4210
4211 * annotate.c (annotate_source_line): Change return type to void,
4212 update implementation to match.
4213 * annotate.h (annotate_source_line): Change return type to void,
4214 update header comment.
4215 * stack.c (print_frame_info): Don't change what frame information
4216 is printed based on whether annotations are on or not.
4217
0d3abd8c
AB
42182019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4219
4220 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4221 (annotate_source): Make static.
4222 (annotate_source_line): Moved from source.c and renamed from
4223 identify_source_line. Update the return type.
4224 * annotate.h (annotate_source): Delete declaration.
4225 (annotate_source_line): Declaration moved from source.h, and
4226 renamed from identify_source_line. Return type updated.
4227 * source.c (identify_source_line): Moved to annotate.c and renamed
4228 to annotate_source_line.
4229 (info_line_command): Remove check of annotation_level.
4230 * source.h (identify_source_line): Move declaration to annotate.h
4231 and rename to annotate_source_line.
4232 * stack.c: Add 'annotate.h' include.
4233 (print_frame_info): Remove check of annotation_level before
4234 calling annotate_source_line.
4235
00df30ae
AB
42362019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4237
4238 * source-cache.c (source_cache::get_plain_source_lines): Use
4239 open_source_file_with_line_charpos instead of just
4240 open_source_file, remove call to find_source_lines.
4241 (source_cache::get_source_lines): Likewise.
4242 * source.c (find_source_lines): Make static.
4243 (get_filename_and_charpos): Renamed into...
4244 (open_source_file_with_line_charpos): ..this along with changes to
4245 return a scoped_fd, and some other minor clean ups.
4246 (identify_source_line): Use open_source_file_with_line_charpos.
4247 (search_command_helper): Use open_source_file_with_line_charpos
4248 instead of just open_source_file, remove call to
4249 find_source_lines.
4250 * source.h (open_source_file_with_line_charpos): Declare new
4251 function.
4252 (find_source_lines): Delete declaration.
4253
afda45a2
AB
42542019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4255
4256 * source.c (get_filename_and_charpos): Remove fullname
4257 parameter.
4258 (identify_source_line): Update call to get_filename_and_charpos.
4259
0735b091
TT
42602019-06-14 Tom Tromey <tromey@adacore.com>
4261
4262 PR gdb/24502:
4263 * ui-style.h (skip_ansi_escape): Update comment.
4264 * ui-file.h (class no_terminal_escape_file): New class.
4265 * ui-file.c (no_terminal_escape_file::write)
4266 (no_terminal_escape_file::puts): New methods.
4267 * cli/cli-logging.c (handle_redirections): Use
4268 no_terminal_escape_file.
4269
52ce35e2
TT
42702019-06-14 Tom Tromey <tromey@adacore.com>
4271
4272 * NEWS: Move convenience variable news above Python news.
4273
73cc7272
TT
42742019-06-14 Tom Tromey <tom@tromey.com>
4275
4276 * gnulib: Move directory to top-level.
4277 * configure.ac: Don't configure gnulib.
4278 * configure: Rebuild.
4279 * common/common-defs.h: Use new path to gnulib.
4280 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4281 (GNULIB_H): Remove.
4282 (INCGNU): Look in new gnulib location.
4283 (HFILES_NO_SRCDIR): Remove gnulib files.
4284 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4285 (generated_files): Remove GNULIB_H.
4286 ($(LIBGNU), all-lib): Remove targets.
4287 (distclean): Don't mention GNULIB_BUILDDIR.
4288 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4289
f5686554
TT
42902019-06-14 Tom Tromey <tromey@adacore.com>
4291
4292 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4293 Warn if symbol file does not provide any symbols.
4294
a0c1ffed
TT
42952019-06-14 Tom Tromey <tromey@adacore.com>
4296
4297 * source.c (find_and_open_source): Respect basenames_may_differ.
4298
7c39e397
AB
42992019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4300
4301 * annotate.c (annotate_breakpoints_invalid): Make use of
4302 scoped_restore_terminal_state.
4303 (annotate_frames_invalid): Likewise.
4304
f411722c
TT
43052019-06-14 Tom Tromey <tromey@adacore.com>
4306
4307 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4308 allow assignment to an internalvar.
4309
4268ec18
TT
43102019-06-14 Tom Tromey <tromey@adacore.com>
4311
4312 * ada-lex.l: Allow "_" in attribute names.
4313
abdb711e
TT
43142019-06-14 Tom Tromey <tromey@adacore.com>
4315
4316 PR gdb/24653:
4317 * regcache.c (registers_changed): Don't call alloca.
4318 * top.c (execute_command): Don't call alloca.
4319
4c048731
PA
43202019-06-13 Pedro Alves <palves@redhat.com>
4321
4322 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4323 'expression'. When parsing an expression, error out if there's
4324 junk after "unlimited".
4325 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4326 (do_set_command): Adjust calls to is_unlimited_literal.
4327
66eb1ed3
PA
43282019-06-13 Pedro Alves <palves@redhat.com>
4329
4330 * compile/compile.c (make_compile_options_def_group): Add braces
4331 around array_view initializer.
4332 * thread.c (make_thread_apply_all_options_def_group)
4333 (make_thread_apply_all_options_def_group): Likewise.
4334
3345721a
PA
43352019-06-13 Pedro Alves <palves@redhat.com>
4336
4337 * NEWS (New commands): Mention "maint test-options
4338 require-delimiter", "maint test-options unknown-is-error", "maint
4339 test-options unknown-is-operand" and "maint show
4340 test-options-completion-result".
4341 (New command options, command completion): New section.
4342 (Completion improvements): New section.
4343 Mention that you can abbreviate "unlimited".
4344
6206060d
PA
43452019-06-13 Pedro Alves <palves@redhat.com>
4346
4347 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4348 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4349 * unittests/cli-utils-selftests.c (test_parse_flags)
4350 (test_parse_flags_qcs): Delete.
4351 (test_cli_utils): Don't call deleted functions.
4352
6665660a
PA
43532019-06-13 Pedro Alves <palves@redhat.com>
4354
4355 * thread.c: Include "cli/cli-option.h".
4356 (tp_array_compar_ascending): Global.
4357 (tp_array_compar): Delete function.
4358 (tp_array_compar_ascending, tp_array_compar_descending): New
4359 functions.
4360 (ascending_option_def, qcs_flag_option_def)
4361 (thr_qcs_flags_option_defs)
4362 (make_thread_apply_all_options_def_group)
4363 (make_thread_apply_options_def_group): New.
4364 (thread_apply_all_command): Use gdb::option::process_options.
4365 (thread_apply_command_completer)
4366 (thread_apply_all_command_completer): New.
4367 (thread_apply_command): Use gdb::option::process_options.
4368 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4369 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4370 to generate help text of "thread apply". Adjust "taas"'s help.
4371 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4372 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4373
f7e13587
PA
43742019-06-13 Pedro Alves <palves@redhat.com>
4375
4376 * thread.c (thread_apply_command): Check for invalid TID with
4377 isdigit instead of !isalpha.
4378
5d707134
PA
43792019-06-13 Pedro Alves <palves@redhat.com>
4380
4381 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4382 (validate_flags_qcs): New.
4383 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4384 (validate_flags_qcs): Declare.
4385 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4386 (make_frame_apply_options_def_group): New.
4387 (frame_apply_command_count): Process options with
4388 gdb::option::process_options.
4389 (frame_apply_completer): New.
4390 (frame_apply_level_completer, frame_apply_all_completer)
4391 (frame_apply_completer): New.
4392 (_initialize_stack): Update help of "frame apply", "frame apply
4393 level", "frame apply all" and "faas" to mention supported options
4394 and install command completers.
4395 * stack.h (frame_apply_all_completer): Declare.
4396 * thread.c: Include "stack.h".
4397 (tfaas_command): Add "--".
4398 (_initialize_thread): Update help "tfaas" to mention supported
4399 options and install command completer.
4400
272d4594
PA
44012019-06-13 Pedro Alves <palves@redhat.com>
4402
4403 * completer.c (complete_nested_command_line): New.
4404 (gdb_completion_word_break_characters_throw): Add assertion.
4405 * completer.h (complete_nested_command_line): Declare.
4406
90a1ef87
PA
44072019-06-13 Pedro Alves <palves@redhat.com>
4408
4409 * stack.c (parse_backtrace_qualifiers): New.
4410 (backtrace_command): Use it.
4411 (backtrace_command_completer): Complete on qualifiers.
4412
d4c16835
PA
44132019-06-13 Pedro Alves <palves@redhat.com>
4414
4415 * frame.c: Include "cli/cli-option.h.
4416 (user_set_backtrace_options): New.
4417 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4418 Delete.
4419 (get_prev_frame): Adjust.
4420 (boolean_option_def, uinteger_option_def)
4421 (set_backtrace_option_defs): New.
4422 (_initialize_frame): Adjust and use
4423 gdb::option::add_setshow_cmds_for_options to install "set
4424 backtrace past-main" and "set backtrace past-entry".
4425 * frame.h: Include "cli/cli-option.h".
4426 (struct frame_print_options): Forward declare.
4427 (print_frame_arguments_all, print_frame_arguments_scalars)
4428 (print_frame_arguments_none): Declare.
4429 (print_entry_values): Delete declaration.
4430 (struct frame_print_options, user_frame_print_options): New.
4431 (struct set_backtrace_options): New.
4432 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4433 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4434 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4435 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4436 (list_args_or_locals): Add frame_print_options parameter.
4437 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4438 * python/py-framefilter.c (enumerate_args): Pass down
4439 USER_FRAME_PRINT_OPTIONS.
4440 * stack.c: Include "cli/cli-option.h".
4441 (print_frame_arguments_all, print_frame_arguments_scalars)
4442 (print_frame_arguments_none): Declare.
4443 (print_raw_frame_arguments, print_entry_values): Delete.
4444 (user_frame_print_options): New.
4445 (boolean_option_def, enum_option_def, frame_print_option_defs):
4446 New.
4447 (struct backtrace_cmd_options): New.
4448 (bt_flag_option_def): New.
4449 (backtrace_command_option_defs): New.
4450 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4451 (print_frame_arg, read_frame_arg, print_frame_args)
4452 (print_frame_info, print_frame): Add frame_print_options parameter
4453 and use it.
4454 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4455 (backtrace_command_1): Add frame_print_options and
4456 backtrace_cmd_options parameters and use them.
4457 (make_backtrace_options_def_group): New.
4458 (backtrace_command): Process command options with
4459 gdb::option::process_options.
4460 (backtrace_command_completer): New.
4461 (_initialize_stack): Extend "backtrace"'s help to mention
4462 supported options. Install completer for "backtrace".
4463 Install some settings commands with add_setshow_cmds_for_options.
4464
2daf894e
PA
44652019-06-13 Pedro Alves <palves@redhat.com>
4466
4467 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4468 and that "set/show print raw frame-arguments" are now deprecated.
4469
4470 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4471 command.
4472 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4473 * stack.c (_initialize_stack): Install "set/show print
4474 raw-frame-arguments", and deprecate "set/show print raw
4475 frame-arguments".
4476 * valprint.c (_initialize_valprint): Deprecate "set/show print
4477 raw".
4478
e6ed716c
PA
44792019-06-13 Pedro Alves <palves@redhat.com>
4480
4481 * compile/compile.c (struct compile_options): New.
4482 (compile_flag_option_def, compile_command_option_defs)
4483 (make_compile_options_def_group): New.
4484 (compile_file_command): Handle options with
4485 gdb::option::process_options.
4486 (compile_file_command_completer): New function.
4487 (compile_code_command): Handle options with
4488 gdb::option::process_options.
4489 (compile_code_command_completer): New function.
4490 (_initialize_compiler): Install completers for "compile code" and
4491 "compile file". Mention available options in "compile code" and
4492 "compile code"'s help.
4493 * completer.c (advance_to_completion_word): New, factored out from
4494 ...
4495 (advance_to_expression_complete_word_point): ... this.
4496 (advance_to_filename_complete_word_point): New.
4497 * completer.h (advance_to_filename_complete_word_point): New
4498 declaration.
4499
7d8062de
PA
45002019-06-13 Pedro Alves <palves@redhat.com>
4501
4502 * compile/compile.c: Include "cli/cli-option.h".
4503 (compile_print_value): Scope data pointer is now a
4504 value_print_options pointer; adjust.
4505 (compile_print_command): Process options. Scope data pointer is
4506 now a value_print_options pointer; adjust.
4507 (_initialize_compile): Update "compile print"'s help to include
4508 supported options. Install a completer for "compile print".
4509 * cp-valprint.c (show_vtblprint, show_objectprint)
4510 (show_static_field_print): Delete.
4511 (_initialize_cp_valprint): Don't install "set print
4512 static-members", "set print vtbl", "set print object" here.
4513 * printcmd.c: Include "cli/cli-option.h" and
4514 "common/gdb_optional.h".
4515 (print_command_parse_format): Rework to fill in a
4516 value_print_options instead of a format_data.
4517 (print_value): Change parameter type from format_data pointer to
4518 value_print_options reference. Adjust.
4519 (print_command_1): Process options. Adjust to pass down a
4520 value_print_options.
4521 (print_command_completer): New.
4522 (_initialize_printcmd): Install print_command_completer as
4523 handle_brkchars completer for the "print" command. Update
4524 "print"'s help to include supported options.
4525 * valprint.c: Include "cli/cli-option.h".
4526 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4527 here from cp-valprint.c.
4528 (boolean_option_def, uinteger_option_def)
4529 (value_print_option_defs, make_value_print_options_def_group):
4530 New. Use gdb::option::add_setshow_cmds_for_options to install
4531 "set print elements", "set print null-stop", "set print repeats",
4532 "set print pretty", "set print union", "set print array", "set
4533 print address", "set print symbol", "set print array-indexes".
4534 * valprint.h: Include <string> and "cli/cli-option.h".
4535 (make_value_print_options_def_group): Declare.
4536 (print_value): Change parameter type from format_data pointer to
4537 value_print_options reference.
4538 (print_command_completer): Declare.
4539
9d0faba9
PA
45402019-06-13 Pedro Alves <palves@redhat.com>
4541
4542 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4543 (COMMON_SFILES): Add maint-test-settings.c.
4544 * cli/cli-decode.c (boolean_enums): New global, factored out from
4545 ...
4546 (add_setshow_boolean_cmd): ... here.
4547 * cli/cli-decode.h (boolean_enums): Declare.
4548 * cli/cli-option.c: New file.
4549 * cli/cli-option.h: New file.
4550 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4551 factored out from ...
4552 (parse_cli_boolean_value(const char *)): ... this.
4553 (is_unlimited_literal): Change parameter type to pointer to
4554 pointer. Adjust and advance ARG pointer.
4555 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4556 (parse_cli_var_enum): New, factored out from ...
4557 (do_set_command): ... this. Adjust.
4558 * cli/cli-setshow.h (parse_cli_boolean_value)
4559 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4560 (parse_cli_var_enum): Declare.
4561 * cli/cli-utils.c: Include "cli/cli-option.h".
4562 (get_ulongest): New.
4563 * cli/cli-utils.h (get_ulongest): Declare.
4564 (check_for_argument): New overloads.
4565 * maint-test-options.c: New file.
4566
2c722807
PA
45672019-06-13 Pedro Alves <palves@redhat.com>
4568
4569 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4570 parse a range if "-" is at the end of the string.
4571
dee7b4c8
PA
45722019-06-13 Pedro Alves <palves@redhat.com>
4573
4574 * cli/cli-setshow.c (parse_auto_binary_operation)
4575 (parse_cli_boolean_value): Don't allow "o".
4576
dca0f6c0
PA
45772019-06-13 Pedro Alves <palves@redhat.com>
4578
4579 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4580 * NEWS: Mention maint test-settings KIND.
4581 * maint-test-settings.c: New file.
4582
597bf39d
PA
45832019-06-13 Pedro Alves <palves@redhat.com>
4584
4585 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4586 completer.
4587 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4588 "set" completers.
4589
48c410fb
PA
45902019-06-13 Pedro Alves <palves@redhat.com>
4591
4592 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4593 after item.
4594
93bcb043
PA
45952019-06-13 Pedro Alves <palves@redhat.com>
4596
4597 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4598
cbba3ecd
PA
45992019-06-13 Pedro Alves <palves@redhat.com>
4600
4601 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4602 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4603 call.
4604 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4605 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4606 calls.
4607 (check_for_argument): Skip spaces after argument.
4608
b9a3f842
PA
46092019-06-13 Pedro Alves <palves@redhat.com>
4610
4611 * thread.c (thread_apply_command): Adjust TID parsing.
4612 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4613 detected before end of string.
4614 (tid_is_in_list): Error out if LIST is invalid.
4615
3844e605
PA
46162019-06-13 Pedro Alves <palves@redhat.com>
4617
4618 * completer.c (complete_line_internal_1): Rewind completion word
4619 point.
4620 (completion_tracker::advance_custom_word_point_by): Change
4621 parameter type to int.
4622 * completer.h (completion_tracker::advance_custom_word_point_by):
4623 Likewise.
4624
00b56dbe
PA
46252019-06-13 Pedro Alves <palves@redhat.com>
4626
4627 * completer.c (advance_to_completion_word): Handle delimiters.
4628
d106773e
PA
46292019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4630
4631 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4632
08f10e02
TT
46332019-06-11 Tom Tromey <tom@tromey.com>
4634
4635 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4636 (xmalloc_failed): Move to alloc.c.
4637 * alloc.c: New file.
4638 * Makefile.in (COMMON_SFILES): Add alloc.c.
4639
1c7fe951
TT
46402019-06-11 Tom Tromey <tom@tromey.com>
4641
4642 * nat/linux-waitpid.c: Don't include server.h.
4643 (linux_debug): Remove.
4644 (my_waitpid): Update.
4645
89549d7f
TT
46462019-06-11 Tom Tromey <tromey@adacore.com>
4647
4648 * infcall.c (_initialize_infcall): Remove trailing newline from
4649 help.
4650 * user-regs.c (_initialize_user_regs): Remove trailing newline
4651 from help.
4652 * typeprint.c (_initialize_typeprint): Remove trailing newline
4653 from help.
4654 * reverse.c (_initialize_reverse): Remove trailing newlines from
4655 help.
4656 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4657 from help.
4658 * language.c (add_set_language_command): Remove trailing newline
4659 from help.
4660 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4661 help.
4662 * disasm.c (_initialize_disasm): Remove trailing newline from
4663 help.
4664 * top.c (init_main): Remove trailing newline from help.
4665 * interps.c (_initialize_interpreter): Remove trailing newline
4666 from help.
4667 * btrace.c (_initialize_btrace): Remove trailing newlines from
4668 help.
4669 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4670 from help.
4671 * python/python.c (_initialize_python): Remove trailing newline
4672 from help.
4673 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4674 help.
4675 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4676 from help. Reformat some text.
4677 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4678 from help.
4679 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4680 newline from help.
4681
86108c13
TT
46822019-06-11 Tom Tromey <tromey@adacore.com>
4683
4684 * darwin-nat.c (darwin_decode_exception_message)
4685 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4686
a7067863
AB
46872019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4688
4689 * valops.c (value_slice): Check for not allocated or not
4690 associated values.
4691
9ab08412
TV
46922019-06-10 Tom de Vries <tdevries@suse.de>
4693
4694 PR gdb/24618
4695 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4696 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4697 invalid.
4698
f19e22e9
TV
46992019-06-10 Tom de Vries <tdevries@suse.de>
4700
4701 PR gdb/24611
4702 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4703 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4704
e99f9db0
TV
47052019-06-10 Tom de Vries <tdevries@suse.de>
4706
4707 PR symtab/24545
4708 * symtab.c (struct demangled_name_entry): Add language field.
4709 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4710 static minimal symbol". Set and use language field.
4711
9bf7038b
TT
47122019-06-10 Tom Tromey <tromey@adacore.com>
4713
4714 * ada-lang.c (_initialize_ada_language): Update help text.
4715
422186a9
TT
47162019-06-10 Tom Tromey <tromey@adacore.com>
4717
4718 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4719 with a newline.
4720 * guile/guile.c (handle_boot_error): Don't end warning with a
4721 newline.
4722 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4723 warning with a newline.
4724 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4725 newline.
4726 (s12z_frame_cache): Likewise.
4727 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4728 a newline.
4729 * solib-svr4.c (disable_probes_interface): Don't end warning with
4730 a newline.
4731 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4732 newline.
4733 * python/python.c (do_finish_initialization): Don't end warning
4734 with a newline.
4735
25ce02ee
TT
47362019-06-10 Tom Tromey <tom@tromey.com>
4737
4738 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4739 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4740 gdbpy_enter.
4741
caa429d8
TT
47422019-06-10 Tom Tromey <tromey@adacore.com>
4743
4744 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4745 data.
4746 (elf_new_init): Don't call stabsread_new_init.
4747 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4748 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4749 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4750
81873cc8
TV
47512019-06-10 Tom de Vries <tdevries@suse.de>
4752
4753 PR symtab/16264
4754 PR symtab/24517
4755 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4756
4fa0265e
РИ
47572019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4758
4759 * source.c (find_and_open_source): Also rewrite relative file
4760 names.
4761
1a3da2cd
AB
47622019-04-26 Amos Bird <amosbird@gmail.com>
4763
4764 * annotate.c (annotate_thread_exited): Add "thread-exited"
4765 annotation.
4766
3847a7bf
TT
47672019-06-06 Tom Tromey <tromey@adacore.com>
4768
4769 * maint.h (class scoped_command_stats): Use
4770 DISABLE_COPY_AND_ASSIGN.
4771 <print_time>: New method.
4772 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4773 print_time.
4774 (scoped_command_stats::print_time): New method.
4775
312617a3
AB
47762019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4777
4778 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4779 instructions of lengths 6 or 8 bytes.
4780
b02f78f9
PA
47812019-06-04 Pedro Alves <palves@redhat.com>
4782
4783 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4784
4785 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4786 * breakpoint.c (condition_completer): Likewise.
4787 * cli/cli-dump.c (scan_expression): Likewise.
4788 * common/filestuff.c (mkdir_recursive): Likewise.
4789 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4790 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4791 (gdb_abspath): Likewise.
4792 * compile/compile-cplus-types.c
4793 (compile_cplus_instance::decl_name): Likewise.
4794 * completer.c (complete_explicit_location):
4795 (signal_completer, reg_or_group_completer_1): Likewise.
4796 * cp-support.c (cp_remove_params_if_any): Likewise.
4797 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4798 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4799 * infcmd.c (strip_bg_char): Likewise.
4800 * linespec.c (copy_token_string): Likewise.
4801 * mi/mi-main.c (output_cores): Likewise.
4802 * psymtab.c (psymtab_search_name):
4803 * symfile.c (test_set_ext_lang_command): Likewise.
4804 * target.c (target_fileio_read_stralloc): Likewise.
4805 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4806 * value.c (complete_internalvar): Likewise.
4807
e1f2e1a2
CB
48082019-06-04 Christian Biesinger <cbiesinger@google.com>
4809
4810 Add objfile property to gdb.Type.
d3238f7d
PA
4811 * NEWS: Mention Python API addition.
4812 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4813
e664d728
PW
48142019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4815
4816 * NEWS: Mention the new set|show style [title|highlight].
4817 Mention changes to "show style", "help" and "apropos".
4818
66d8c862
PW
48192019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4820
4821 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4822 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4823 instead of print_help_for_command.
4824 (print_doc_of_command): New function.
4825 (help_list): Add 'apropos -v word' suggestion.
4826 (print_help_for_command): Style the command name using title style.
4827 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4828 (_initialize_cli_cmds): Describe -v in apropos_command help.
4829
9303eb2f
PW
48302019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4831
4832 * cli/cli-style.h (cli_style_option): Add name in constructor,
4833 add m_name class member, add constructor with intensity,
4834 add name class function.
4835 (cli_style_option::add_setshow_commands): Remove name argument.
4836 (highlight_style, title_style): New styles.
4837 * cli/cli-style.c (do_show): New function that shows a style
4838 characteristic styling the style name with itself.
4839 (set_style_name): New function.
4840 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4841 Update all callers according to the changes in cli/cli-style.h.
4842 * utils.h (fputs_highlighted): New function.
4843 * utils.c (fputs_highlighted): Likewise.
4844
e2c52041
PW
48452019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4846
4847 * NEWS: Mention new pipe command and new convenience variables.
4848
947d3946
PW
48492019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4850
4851 * cli/cli-cmds.c (pipe_command): New function.
4852 (_initialize_cli_cmds): Call add_com for pipe_command.
4853 Define | as an alias for pipe.
4854 (exit_status_set_internal_vars): New function.
4855 (shell_escape): Call exit_status_set_internal_vars.
4856 cli/cli-decode.c (find_command_name_length): Recognize | as
4857 a single character command.
4858
b8fd0918
PW
48592019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4860
4861 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4862 top.c (execute_command_to_ui_file): New function, mostly a copy
4863 of execute_command_to_string.
4864 (execute_command_to_string): Implement by calling
4865 execute_command_to_ui_file.
4866
68bb5386
PW
48672019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4868
4869 * top.h (saved_command_line): Remove declaration.
4870 * top.c (previous_saved_command_line, previous_repeat_arguments):
4871 New variables.
4872 (saved_command_line): Make static, define together with other
4873 'repeat variables'.
4874 (dont_repeat): Clear repeat_arguments.
4875 (repeat_previous, get_saved_command_line, save_command_line):
4876 New functions.
4877 (gdb_init): Initialize saved_command_line
4878 and previous_saved_command_line.
4879 * main.c (captured_main_1): Remove saved_command_line initialization.
4880 * event-top.c (handle_line_of_input): Update to use
4881 the new 'repeat' related functions instead of direct access to
4882 saved_command_line.
4883 * command.h (repeat_previous, get_saved_command_line,
4884 save_command_line): New declarations.
4885 (dont_repeat): Add comment.
4886
bfcdb852
TT
48872019-05-30 Tom Tromey <tromey@adacore.com>
4888
4889 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4890 Fix comment.
4891 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4892
0ef209f2
JV
48932019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4894
4895 PR cli/24587
4896 * completer.c (complete): Initialize variable word.
4897
955b06fa
SDJ
48982019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4899
4900 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4901 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4902 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4903 'body' is NULL to the outter 'if', protecting the '!is_define'
4904 situation as well.
4905
fa9c3fa0
TT
49062019-05-29 Tom Tromey <tromey@adacore.com>
4907
4908 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4909 (dwarf_unknown): New function.
4910 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4911 (dwarf_type_encoding_name): Use dwarf_unknown.
4912
4330d61d
TT
49132019-05-29 Tom Tromey <tromey@adacore.com>
4914
4915 PR c++/20020:
4916 * cp-valprint.c (cp_print_value_fields): Call
4917 cp_print_static_field inside "try".
4918
33a6bc35
TT
49192019-05-29 Tom Tromey <tromey@adacore.com>
4920
4921 * inflow.c (struct terminal_info): Add default operator=.
4922 * configure: Rebuild.
4923 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4924 -Wdeprecated-copy-dtor, -Wredundant-move.
4925
000439d5
TT
49262019-05-29 Tom Tromey <tromey@adacore.com>
4927
4928 * NEWS: Add entry.
4929 * infcmd.c (print_return_value_1): Handle finish_print
4930 option.
4931 (show_print_finish): New function.
4932 (_initialize_infcmd): Add "set/show print finish" commands.
4933 * valprint.c (user_print_options): Initialize new member.
4934 * valprint.h (struct value_print_options) <finish_print>: New
4935 member.
4936
c0e70c62
TT
49372019-05-28 Tom Tromey <tromey@adacore.com>
4938
4939 * ada-lang.c (ada_remove_Xbn_suffix)
4940 (find_old_style_renaming_symbol)
4941 (parse_old_style_renaming): Remove.
4942 (ada_find_renaming_symbol): Don't call
4943 find_old_style_renaming_symbol.
4944 (ada_is_renaming_symbol): Rename from
4945 ada_find_renaming_symbol. Remove "block" parameter. Return
4946 bool. Now static.
4947 (ada_read_var_value): Update and simplify.
4948 * ada-exp.y (write_var_or_type): Remove old code.
4949
766f8836
AH
49502019-05-28 Alan Hayward <alan.hayward@arm.com>
4951
4952 * event-top.c: Remove include comment.
4953 * inflow.c (class scoped_ignore_sigttou): Move from here...
4954 * inflow.h (class scoped_ignore_sigttou): ...to here.
4955 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4956 * top.c: Remove include comment.
4957
eb41253a
TT
49582019-05-27 Tom Tromey <tom@tromey.com>
4959
4960 * NEWS: Fix typo.
4961
4ca51187
TT
49622019-05-22 Tom Tromey <tromey@adacore.com>
4963
4964 * target.c (target_follow_exec): Constify parameter.
4965 * target-delegates.c: Rebuild.
4966 * remote.c (remote_target::follow_exec): Constify parameter.
4967 * infrun.c (follow_exec): Constify parameter.
4968 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4969 (target_follow_exec): Likewise.
4970
8fca4da0
AH
49712019-05-22 Alan Hayward <alan.hayward@arm.com>
4972
4973 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4974 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4975
b7060614
AH
49762019-05-22 Alan Hayward <alan.hayward@arm.com>
4977
4978 * NEWS: Add debugredirect and testsuite sections.
4979
0a5954bd
SC
49802019-05-22 Simon Cook <simon.cook@embecosm.com>
4981
4982 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4983 target descriptions using exclusively floating point register name
4984 aliases.
4985
dc42e902
AB
49862019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4987
4988 PR gdb/18644:
4989 * f-lang.c (build_fortran_types): Handle the case where
4990 gdbarch_floatformat_for_type returns a nullptr.
4991
fb7806c7
TV
49922019-05-21 Tom de Vries <tdevries@suse.de>
4993
4994 PR cli/24587
4995 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4996
34d11c68
AB
49972019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4998
4999 PR gdb/18644:
5000 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5001 16-byte floats.
5002 * i386-tdep.c (i386_floatformat_for_type): Use
5003 floatformats_ia64_quad for the 16-byte floating point component
5004 within a fortran 32-byte complex number.
5005
122cf0f2
AB
50062019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5007
5008 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5009 delete default constructor.
5010 (find_partial_die): Update to return const struct.
5011 (partial_die_parent_scope): Move variable declaration into scope
5012 of its use and change its type to auto.
5013 (guess_partial_die_structure_name): Likewise.
5014 (partial_die_info::fixup): Likewise.
5015
33d0e35a
TT
50162019-05-17 Tom Tromey <tromey@adacore.com>
5017
5018 * source.c (find_and_open_source): Remove cast.
5019
a45575b0
TT
50202019-05-17 Tom Tromey <tromey@adacore.com>
5021
5022 * annotate.c (annotate_source): Make "filename" const.
5023 * annotate.h (annotate_source): Use const.
5024
81f47ac2
AH
50252019-05-17 Alan Hayward <alan.hayward@arm.com>
5026
5027 * disasm.c (set_disassembler_options): Send errors to stderr.
5028
ca1285d1
AH
50292019-05-17 Alan Hayward <alan.hayward@arm.com>
5030
5031 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5032 (cli_interp_base::set_logging): Check debug_redirect.
5033 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5034 * cli/cli-logging.c (debug_redirect): Add static variable.
5035 (pop_output_files): Add default param.
5036 (handle_redirections): Print debug setting.
5037 (show_logging_command): Likewise.
5038 (_initialize_cli_logging): Add debugredirect command.
5039 * interps.c (current_interp_set_logging): Add debug_redirect
5040 parameter.
5041 * interps.h (set_logging): Add debug_redirect parameter.
5042 (current_interp_set_logging): Likewise.
5043 * mi/mi-common.h: Likewise.
5044 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5045
50462019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
5047 Tom Tromey <tromey@adacore.com>
5048
5049 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5050 directly.
5051 * cli/cli-interp.h (make_logging_output): Remove declaration.
5052 * cli/cli-logging.c (make_logging_output): Remove function.
5053 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5054 directly.
5055 * ui-file.c (tee_file::tee_file): Remove bools.
5056 (tee_file::~tee_file): Remove deletes.
5057 * ui-file.h (tee_file): Remove bools.
5058
26648588
JV
50592019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5060
5061 * mi/mi-cmds.h (mi_cmd_complete): New function.
5062 * mi/mi-main.c (mi_cmd_complete): Likewise.
5063 * mi/mi-cmds.c: Define new MI command -complete.
5064 * NEWS: Mention new -complete command.
5065
6e035501
JV
50662019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5067
5068 * completer.h (complete): New function.
5069 * completer.c (complete): Likewise.
5070 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5071 function defined in completer.h.
5072
7d0e2ece
JV
50732019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5074
e79be6e5 5075 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5076
fb816e8b
TV
50772019-05-17 Tom de Vries <tdevries@suse.de>
5078
5079 PR gdb/24094
5080 * dwarf2read.c (struct cu_partial_die_info): New struct.
5081 (find_partial_die): Return cu_partial_die_info.
5082 (partial_die_parent_scope, guess_partial_die_structure_name)
5083 (partial_die_info::fixup): Handle new return type of find_partial_die.
5084
677052f2
SDJ
50852019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5086
5087 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5088 "std::string", simplifying the algorithm.
5089
f3da9116
SDJ
50902019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5091
5092 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5093 (stap_static_probe_ops::get_probes): Likewise.
5094
f1bb75ab
SDJ
50952019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5096
5097 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5098 '-')" and "else if".
5099 (stap_parse_single_operand): Join checks for
5100 "gdbarch_stap_parse_special_token_p" and
5101 "gdbarch_stap_parse_special_token" in the same "if" statement.
5102 Invert check when verifying for operation on register
5103 displacement.
5104
3ca58cde
SDJ
51052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5106
5107 * stap-probe.c (stap_get_opcode): Update comment.
5108 (stap_get_expected_argument_type): Likewise.
5109 (handle_stap_probe): Likewise.
5110
af2d9bee
SDJ
51112019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5112
5113 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5114 return type to 'bool'. Adjust comment. Use 'bool' when
5115 appropriate.
5116 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5117 * stap-probe.c (stap_parse_argument_1): Likewise.
5118 (stap_is_operator): Likewise.
5119 (stap_is_generic_prefix): Likewise.
5120 (stap_is_register_prefix): Likewise.
5121 (stap_is_register_indirection_prefix): Likewise.
5122 (stap_is_integer_prefix): Likewise.
5123 (stap_generic_check_suffix): Likewise.
5124 (stap_check_integer_suffix): Likewise.
5125 (stap_check_register_suffix): Likewise.
5126 (stap_check_register_indirection_suffix): Likewise.
5127 (stap_parse_register_operand): Likewise.
5128 (stap_parse_single_operand): Likewise.
5129 (stap_parse_argument_1): Likewise.
5130 (stap_probe::get_argument_count): Likewise.
5131 (stap_is_operator): Likewise.
5132
61c9c421
TT
51332019-05-16 Tom Tromey <tromey@adacore.com>
5134
5135 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5136 keyword to foreach.
5137
9ddc1af1
SM
51382019-05-15 Simon Marchi <simon.marchi@efficios.com>
5139
5140 * linux-thread-db.c (try_thread_db_load_1): Change return type
5141 to bool.
5142 (try_thread_db_load): Likewise.
5143 (try_thread_db_load_from_pdir_1): Likewise.
5144 (try_thread_db_load_from_pdir): Likewise.
5145 (try_thread_db_load_from_sdir): Likewise.
5146 (try_thread_db_load_from_dir): Likewise.
5147 (thread_db_load_search): Likewise.
5148 (has_libpthread): Likewise.
5149 (thread_db_load): Likewise.
5150
7bede828
SDJ
51512019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5152
5153 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5154 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5155 NULL, and complain/return if that's the case.
5156
c5358db4
JD
51572019-05-15 John Darrington <john@darrington.wattle.id.au>
5158
5159 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5160 (advance, posn, abstract_read_memory): New functions.
5161 [struct mem_read_abstraction]: New struct.
5162 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5163
c408a94f
TT
51642019-05-14 Tom Tromey <tromey@adacore.com>
5165
5166 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5167 value is not lval_memory.
5168
e7bd7fba
TT
51692019-05-14 Tom Tromey <tromey@adacore.com>
5170
5171 * solib.c (info_sharedlibrary_command): Style the file name.
5172
a6d0f249
AH
51732019-05-14 Alan Hayward <alan.hayward@arm.com>
5174
5175 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5176 (aarch64_vnv_type): Likewise.
5177 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5178 * common/tdesc.c: Likewise.
5179 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5180 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5181 * features/aarch64-fpu.xml: Add ieee half view.
5182 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5183 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5184 * gdbtypes.h (struct builtin_type): Likewise.
5185 (struct objfile_type): Likewise.
5186
66b8bb74
SM
51872019-05-12 Paul Naert <paul.naert@polymtl.ca>
5188
5189 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5190 typo.
5191 * location.h (string_to_event_location): Likewise.
5192
21c219fd
JB
51932019-05-11 Joel Brobecker <brobecker@adacore.com>
5194
5195 GDB 8.3 released.
5196
13674803
SM
51972019-05-10 Simon Marchi <simon.marchi@efficios.com>
5198
5199 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5200 New variable declaration.
5201 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5202 New variable.
5203 (print_one_breakpoint): Use ui_out::test_flags and new global
5204 variable to compute use_fixed_output.
5205 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5206 Remove.
5207 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5208 (mi_multi_location_breakpoint_output_fixed): Remove.
5209 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5210 new variable.
5211 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5212 fix_multi_location_breakpoint_output flag if version >= 3.
5213 * ui-out.h (enum ui_out_flag)
5214 <fix_multi_location_breakpoint_output>: New enumerator.
5215
a9eac7f9
SM
52162019-05-10 Simon Marchi <simon.marchi@efficios.com>
5217
5218 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5219
71bed2db
TT
52202019-05-10 Tom Tromey <tromey@adacore.com>
5221
5222 * ada-lang.c (catch_ada_completer): New function.
5223 (_initialize_ada_language): Use it.
5224
24c54127
TT
52252019-05-10 Tom Tromey <tromey@adacore.com>
5226
5227 * thread.c (print_thread_info): Make "requested_threads" const.
5228 * gdbthread.h (print_thread_info): Make "requested_threads"
5229 const.
5230 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5231 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5232
7a102139
TT
52332019-05-08 Tom Tromey <tom@tromey.com>
5234
5235 * gdbtypes.c (objfile_type_data): Change type.
5236 (objfile_type, _initialize_gdbtypes): Update.
5237
924d79e2
TT
52382019-05-08 Tom Tromey <tom@tromey.com>
5239
5240 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5241 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5242 (_initialize_dwarf2_frame): Update.
5243
4c58e337
TT
52442019-05-08 Tom Tromey <tom@tromey.com>
5245
5246 * objc-lang.c (objc_objfile_data): Change type.
5247 (find_methods): Update.
5248 (_initialize_objc_lang): Remove.
5249
d772d2ab
TT
52502019-05-08 Tom Tromey <tom@tromey.com>
5251
5252 * stabsread.c (rs6000_builtin_type_data): Change type.
5253 (rs6000_builtin_type, _initialize_stabsread): Update.
5254
d11d83f4
TT
52552019-05-08 Tom Tromey <tom@tromey.com>
5256
5257 * mips-tdep.c (mips_pdr_data): Remove.
5258 (_initialize_mips_tdep): Update.
5259
9a73f0ad
TT
52602019-05-08 Tom Tromey <tom@tromey.com>
5261
5262 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5263 (hppa_init_objfile_priv_data, read_unwind_info)
5264 (find_unwind_entry, _initialize_hppa_tdep): Update.
5265
8127a2fa
TT
52662019-05-08 Tom Tromey <tom@tromey.com>
5267
5268 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5269 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5270 on obstack.
5271 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5272
91d3055d
TT
52732019-05-08 Tom Tromey <tom@tromey.com>
5274
5275 * mdebugread.c (basic_type_data): Change type.
5276 (basic_type, _initialize_mdebugread): Update.
5277
31930bd3
TT
52782019-05-08 Tom Tromey <tom@tromey.com>
5279
5280 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5281
bdb3ed9e
TT
52822019-05-08 Tom Tromey <tom@tromey.com>
5283
5284 * nto-tdep.c (nto_inferior_data_reg): Change type.
5285 (nto_inferior_data): Update.
5286 (nto_inferior_data_cleanup, nto_new_inferior_data)
5287 (_initialize_nto_tdep): Remove.
5288 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5289
f37b313d
TT
52902019-05-08 Tom Tromey <tom@tromey.com>
5291
5292 * ada-lang.c (struct ada_inferior_data): Add initializers.
5293 (ada_inferior_data): Change type.
5294 (ada_inferior_data_cleanup): Remove.
5295 (get_ada_inferior_data, ada_inferior_exit)
5296 (struct ada_pspace_data): Add initializers, destructor.
5297 (ada_pspace_data_handle): Change type.
5298 (get_ada_pspace_data): Update.
5299 (ada_pspace_data_cleanup): Remove.
5300
24699405
TT
53012019-05-08 Tom Tromey <tom@tromey.com>
5302
5303 * coffread.c (struct coff_symfile_info): Add initializers.
5304 (coff_objfile_data_key): Move lower. Change type.
5305 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5306 Update.
5307 (coff_free_info): Remove.
5308
d4e05d2f
TT
53092019-05-08 Tom Tromey <tom@tromey.com>
5310
5311 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5312 (fbsd_pspace_data_handle): Move lower. Change type.
5313 (get_fbsd_pspace_data): Update.
5314 (fbsd_pspace_data_cleanup): Remove.
5315 (_initialize_fbsd_tdep): Update.
5316
14ef6690
TT
53172019-05-08 Tom Tromey <tom@tromey.com>
5318
5319 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5320 (get_ada_tasks_pspace_data): Update.
5321 (ada_tasks_pspace_data_cleanup): Remove.
5322 (_initialize_tasks): Update.
5323 (ada_tasks_inferior_data_handle): Change type.
5324 (get_ada_tasks_inferior_data): Update.
5325 (ada_tasks_inferior_data_cleanup): Remove.
5326 (struct ada_tasks_pspace_data): Add initializers.
5327
814cf43a
TT
53282019-05-08 Tom Tromey <tom@tromey.com>
5329
5330 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5331 * symfile-debug.c (debug_sym_get_probes): Change type.
5332 * stap-probe.c (handle_stap_probe):
5333 (stap_static_probe_ops::get_probes): Change type.
5334 * probe.h (class static_probe_ops) <get_probes>: Change type.
5335 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5336 (parse_probes_in_pspace): Update.
5337 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5338 Update.
5339 (any_static_probe_ops::get_probes): Change type.
5340 * elfread.c (elfread_data): New typedef.
5341 (probe_key): Change type.
5342 (elf_get_probes): Likewise. Update.
5343 (probe_key_free): Remove.
5344 (_initialize_elfread): Update.
5345 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5346 Change type.
5347 (dtrace_process_dof_probe, dtrace_process_dof)
5348 (dtrace_static_probe_ops::get_probe): Change type.
5349
02dc647e
TT
53502019-05-08 Tom Tromey <tom@tromey.com>
5351
5352 * xcoffread.c (struct xcoff_symfile_info): Rename from
5353 coff_symfile_info. Add initializers.
5354 (xcoff_objfile_data_key): Move lower. Change type.
5355 (XCOFF_DATA): Rewrite.
5356 (xcoff_free_info): Remove.
5357 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5358 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5359 (xcoff_initial_scan): Update.
5360
09232438
TT
53612019-05-08 Tom Tromey <tom@tromey.com>
5362
5363 * solib-svr4.c (struct svr4_info): Add initializers and
5364 destructor.
5365 <probes_table>: Now an htab_up.
5366 (solib_svr4_pspace_data): Change type.
5367 (free_probes_table): Simplify.
5368 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5369 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5370 (probes_table_remove_objfile_probes, register_solib_event_probe)
5371 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5372 (_initialize_svr4_solib): Update.
5373
7b4a314f
TT
53742019-05-08 Tom Tromey <tom@tromey.com>
5375
5376 * remote.c (remote_pspace_data): Change type.
5377 (remote_pspace_data_cleanup): Remove.
5378 (get_remote_exec_file, set_pspace_remote_exec_file)
5379 (_initialize_remote): Update.
5380
51d3063a
TT
53812019-05-08 Tom Tromey <tom@tromey.com>
5382
5383 * breakpoint.c (breakpoint_objfile_key): Change type.
5384 (get_breakpoint_objfile_data): Update.
5385 (free_breakpoint_objfile_data): Remove.
5386 (_initialize_breakpoint): Update.
5387
89fb8848
TT
53882019-05-08 Tom Tromey <tom@tromey.com>
5389
5390 * linux-tdep.c (struct linux_info): Add initializers.
5391 (linux_inferior_data): Move. Change type.
5392 (invalidate_linux_cache_inf): Update.
5393 (linux_inferior_data_cleanup): Remove.
5394 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5395
e9b89e2d
TT
53962019-05-08 Tom Tromey <tom@tromey.com>
5397
5398 * auxv.c (auxv_inferior_data): Move. Change type.
5399 (auxv_inferior_data_cleanup): Remove.
5400 (invalidate_auxv_cache_inf): Rewrite.
5401 (get_auxv_inferior_data, _initialize_auxv): Update.
5402
8c42777c
TT
54032019-05-08 Tom Tromey <tom@tromey.com>
5404
5405 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5406 (symfile_debug_objfile_data_key): Change type.
5407 (symfile_debug_installed, debug_qf_has_symbols)
5408 (debug_qf_find_last_source_symtab)
5409 (debug_qf_forget_cached_source_info)
5410 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5411 (debug_qf_print_stats, debug_qf_dump)
5412 (debug_qf_expand_symtabs_for_function)
5413 (debug_qf_expand_all_symtabs)
5414 (debug_qf_expand_symtabs_with_fullname)
5415 (debug_qf_map_matching_symbols)
5416 (debug_qf_expand_symtabs_matching)
5417 (debug_qf_find_pc_sect_compunit_symtab)
5418 (debug_qf_map_symbol_filenames)
5419 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5420 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5421 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5422 (debug_sym_read_linetable, debug_sym_relocate): Update.
5423 (symfile_debug_free_objfile): Remove.
5424 (install_symfile_debug_logging, _initialize_symfile_debug):
5425 Update.
5426
5bfd760d
TT
54272019-05-08 Tom Tromey <tom@tromey.com>
5428
5429 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5430 allocate_on_obstack.
5431 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5432 (get_dwarf2_per_objfile): Update.
5433 (set_dwarf2_per_objfile): Remove.
5434 (dwarf2_has_info, dwarf2_get_section_info): Update.
5435 (dwarf2_free_objfile): Remove.
5436 (_initialize_dwarf2_read): Update.
5437
e85e19b4
TT
54382019-05-08 Tom Tromey <tom@tromey.com>
5439
5440 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5441 initializers.
5442 <unsupported_script_warning_printed,
5443 script_not_found_warning_printed>: Now bool.
5444 (auto_load_pspace_data): Change type.
5445 (~auto_load_pspace_info): Rename from
5446 auto_load_pspace_data_cleanup.
5447 (get_auto_load_pspace_data, init_loaded_scripts_info)
5448 (clear_section_scripts, maybe_print_unsupported_script_warning)
5449 (maybe_print_script_not_found_warning, _initialize_auto_load):
5450 Update.
5451
f6aa7436
TT
54522019-05-08 Tom Tromey <tom@tromey.com>
5453
5454 * objfiles.c (objfile_pspace_info): Add destructor and
5455 initializers.
5456 (objfiles_pspace_data): Change type.
5457 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5458 (get_objfile_pspace_data): Update.
5459 (objfiles_bfd_data): Change type.
5460 (get_objfile_bfd_data): Update.
5461 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5462
6ae614f6
TT
54632019-05-08 Tom Tromey <tom@tromey.com>
5464
5465 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5466 Change type.
5467 (get_catch_syscall_inferior_data): Update.
5468 (catch_syscall_inferior_data_cleanup): Remove.
5469 (_initialize_break_catch_syscall): Update.
5470
6509b8eb
TT
54712019-05-08 Tom Tromey <tom@tromey.com>
5472
5473 * inflow.c (struct terminal_info): Add destructor and
5474 initializers.
5475 (inflow_inferior_data): Change type.
5476 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5477 (get_inflow_inferior_data, inflow_inferior_exit)
5478 (swap_terminal_info, _initialize_inflow): Update.
5479
35632941
TT
54802019-05-08 Tom Tromey <tom@tromey.com>
5481
5482 * target-dcache.c (target_dcache_cleanup): Remove.
5483 (target_dcache_aspace_key): Change type.
5484 (target_dcache_init_p, target_dcache_invalidate)
5485 (target_dcache_get, target_dcache_get_or_init)
5486 (_initialize_target_dcache): Update.
5487 * dcache.h (struct dcache_deleter): New.
5488
3017b94d
TT
54892019-05-08 Tom Tromey <tom@tromey.com>
5490
5491 * symtab.c (struct symbol_cache): Add destructor and
5492 initializers.
5493 (symbol_cache_key): Move. Change type.
5494 (make_symbol_cache, free_symbol_cache): Remove.
5495 (get_symbol_cache): Update.
5496 (symbol_cache_cleanup): Remove.
5497 (ALL_PSPACES, symbol_cache_flush)
5498 (maintenance_print_symbol_cache)
5499 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5500 Update.
5501
a32ad8c5
TT
55022019-05-08 Tom Tromey <tom@tromey.com>
5503
5504 * symtab.c (struct main_info): Add destructor and initializers.
5505 (main_progspace_key): Move. Change type.
5506 (get_main_info): Update.
5507 (main_info_cleanup): Remove.
5508 (_initialize_symtab): Update.
5509
5f6e90a0
TT
55102019-05-08 Tom Tromey <tom@tromey.com>
5511
5512 * registry.h (DECLARE_REGISTRY): Define the _key class.
5513
1bd0c6e4
AB
55142019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5515
5516 * NEWS: Merge two 'New commands' sections.
5517
2228ef77
XR
55182019-05-08 Joel Brobecker <brobecker@adacore.com>
5519
5520 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5521 parameter and use Ada language definition instead.
5522 (ada_val_print_ptr): Remove unused language parameter.
5523 (ada_val_print_num): Remove language parameter and use Ada language
5524 definition instead.
5525 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5526 parameter.
5527 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5528 parameter and use Ada language definition instead.
5529 (ada_val_print_1): Update all ada_val_print_xxx calls.
5530 Remove language parameter.
5531 (ada_val_print): Update ada_val_print_1 call.
5532
60fcc1c3
TT
55332019-05-08 Tom Tromey <tromey@adacore.com>
5534
5535 * remote.c (remote_hw_watchpoint_limit)
5536 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5537 Now static.
5538
ed2b7c17
TT
55392019-05-08 Tom Tromey <tromey@adacore.com>
5540
5541 * maint.c (_initialize_maint_cmds): Move initialization code to
5542 remote.c.
5543 (watchdog, show_watchdog): Move to remote.c.
5544 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5545 "watchdog" static.
5546 (_initialize_remote): Move initialization code from maint.c.
5547 * defs.h (watchdog): Don't declare.
5548
b0be6c91
TT
55492019-05-08 Tom Tromey <tromey@adacore.com>
5550
5551 * tui/tui-interp.c: Include main.h.
5552 * interps.c: Include main.h.
5553 * main.h (interpreter_p): Declare.
5554 * defs.h (interpreter_p): Don't declare.
5555
587ee17b
TT
55562019-05-08 Tom Tromey <tromey@adacore.com>
5557
5558 * dwarf2loc.c: Include dwarf2read.h.
5559 * defs.h (read_unsigned_leb128): Don't declare.
5560 * dwarf2read.h (read_unsigned_leb128): Declare.
5561
ca1df239
TT
55622019-05-08 Tom Tromey <tromey@adacore.com>
5563
5564 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5565 method.
5566
99f20f08
TT
55672019-05-08 Tom Tromey <tromey@adacore.com>
5568
5569 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5570 when no wrap column is set.
5571
80e55b13
TT
55722019-05-08 Tom Tromey <tromey@adacore.com>
5573
5574 * c-lang.c (c_get_string): Handle non-C-style arrays.
5575
9d3421af
TT
55762019-05-08 Tom Tromey <tromey@adacore.com>
5577
5578 * typeprint.c (print_offset_data::update): Print the bit offset,
5579 not the number of bits remaining.
5580
844333e2
TT
55812019-05-08 Tom Tromey <tromey@adacore.com>
5582
5583 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5584 padding at end of comment.
5585
988915ee
TT
55862019-05-08 Tom Tromey <tromey@adacore.com>
5587
5588 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5589 Compare main types.
5590
26bfd823
TT
55912019-05-06 Tom Tromey <tom@tromey.com>
5592
5593 * common/scoped_mmap.c: Include common-defs.h.
5594 * common/scoped_mmap.h: Don't include config.h.
5595
89055eaa
TT
55962019-05-04 Tom Tromey <tom@tromey.com>
5597
5598 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5599 (struct aarch64_call_info): Add initializers.
5600 <si>: Now a std::vector.
5601 (pass_on_stack, aarch64_push_dummy_call): Update.
5602
5da01df5
TT
56032019-05-04 Simon Marchi <simon.marchi@efficios.com>
5604 Tom Tromey <tom@tromey.com>
5605
5606 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5607 (ppc_threads): Now a std::vector. Now static.
5608 (hwdebug_find_thread_points_by_tid)
5609 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5610 Update.
5611
fbdf05a1
TT
56122019-05-04 Tom Tromey <tom@tromey.com>
5613
5614 * arc-tdep.c (arc_tdesc_init): Return bool.
5615
06d16ec9
TT
56162019-05-04 Tom Tromey <tom@tromey.com>
5617
5618 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5619 Use gdb_assert_not_reached.
5620
9c056022
TT
56212019-05-04 Tom Tromey <tom@tromey.com>
5622
5623 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5624 "false".
5625
fa9c2a59
TT
56262019-05-04 Tom Tromey <tom@tromey.com>
5627
5628 * arc-tdep.c (arc_tdesc_init): Use bool.
5629
e2eb806a
TT
56302019-05-04 Tom Tromey <tom@tromey.com>
5631
5632 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5633
6fe87677
TT
56342019-05-04 Tom Tromey <tom@tromey.com>
5635
5636 * cli/cli-cmds.c (valid_command_p): Return bool.
5637
7f008c9e
TT
56382019-05-04 Tom Tromey <tom@tromey.com>
5639
5640 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5641 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5642
b6484282
RT
56432019-05-04 Raul Tambre <raul@tambre.ee>
5644
5645 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5646 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5647 operator for comparison.
5648
af97b416
TT
56492019-05-04 Tom Tromey <tom@tromey.com>
5650
5651 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5652 (lookup_partial_symbol, print_partial_symbols)
5653 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5654 (psymbol_compare): Update.
5655 (add_psymbol_to_bcache): Clear the entire psymbol.
5656 (maintenance_check_psymtabs): Update.
5657 * psympriv.h (struct partial_symbol): Don't derive from
5658 general_symbol_info.
5659 <obj_section, unrelocated_address, address,
5660 set_unrelocated_address>: Update.
5661 <ginfo>: New member.
5662 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5663 (debug_names::write_psymbols): Update.
5664
9d6d4be8
TV
56652019-05-04 Tom de Vries <tdevries@suse.de>
5666
5667 * contrib/cc-with-tweaks.sh: Support -n arg.
5668
66452beb
PW
56692019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5670
5671 * corelow.c (core_target::detach): Ensure frame cache and
5672 register caches are cleared.
5673 inferior.c (exit_inferior_1): Likewise.
5674
bde09ab7
TT
56752019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5676 Tom Tromey <tom@tromey.com>
5677
5678 * dictionary.c (collate_pending_symbols_by_language): Remove
5679 "struct" from foreach.
5680 * symtab.c (lookup_global_symbol_from_objfile)
5681 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5682 foreach.
5683 * ser-tcp.c (net_open): Remove "struct" from foreach.
5684 * objfiles.c (objfile_relocate, objfile_rebase)
5685 (objfile_has_symbols): Remove "struct" from foreach.
5686 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5687 from foreach.
5688 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5689 foreach.
5690 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5691 "struct" from foreach.
5692 * ada-lang.c (create_excep_cond_exprs)
5693 (ada_exception_catchpoint_cond_string): Remove "struct" from
5694 foreach.
5695
222a8d25
TT
56962019-05-03 Tom Tromey <tromey@adacore.com>
5697
5698 * ada-exp.y (convert_char_literal): Check suffix of each
5699 enumerator.
5700
fcd60b84
DP
57012019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5702
5703 PR ada/21406:
5704 * ada-exp.y (yywrap): Don't define.
5705 * ada-lex.l (%option): Add noyywrap
5706 (yywrap): Remove.
5707
5f2459c2
EZ
57082019-05-03 Eli Zaretskii <eliz@gnu.org>
5709
353ea2d1
EZ
5710 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5711 _WIN32_WINNT to the XP level, unless already defined to a higher
5712 level.
5713
5714 * unittests/parse-connection-spec-selftests.c:
5715 * ser-tcp.c:
5716 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5717 override.
5718
5f2459c2
EZ
5719 * symfile.c (find_separate_debug_file): Remove colon from the
5720 drive spec of DOS/Windows file names of the target, so that the
5721 file name produced from DEBUGDIR and the target's directory will
5722 be valid on DOS/Windows systems.
5723
80062eb9
AB
57242019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5725
5726 * rust-lang.c (val_print_struct): Handle printing structures
5727 containing strings.
5728
b8c05e85
TT
57292019-05-02 Tom Tromey <tromey@adacore.com>
5730
5731 * valarith.c (_initialize_valarith): Remove.
5732
4504bbde
TT
57332019-05-01 Tom Tromey <tromey@adacore.com>
5734
5735 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5736 bitfields.
5737
d48e62f4
TT
57382019-05-01 Tom Tromey <tromey@adacore.com>
5739
5740 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5741 for big-endian copies.
5742
15f18d14
AT
57432019-04-30 Ali Tamur <tamur@google.com>
5744 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5745 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5746 (read_3_bytes): New function.
5747
ab4ee614
JB
57482019-04-30 Joel Brobecker <brobecker@adacore.com>
5749
5750 * windows-nat.c (main_thread_id): Delete.
5751 (handle_output_debug_string): Replace main_thread_id by
5752 current_event.dwThreadId.
5753 (fake_create_process): Likewise.
5754 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5755 Do not set main_thread_id.
5756 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5757 current_event.dwThreadId.
5758 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5759
8ed5b76e
JB
57602019-04-30 Joel Brobecker <brobecker@adacore.com>
5761
5762 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5763 Use current_event.dwThreadId instead of main_thread_id.
5764
2ff0a947
TT
57652019-04-30 Tom Tromey <tromey@adacore.com>
5766
5767 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5768 (create_excep_cond_exprs): Iterate over program spaces.
5769 (ada_exception_catchpoint_cond_string): Examine all minimal
5770 symbols for exception types.
5771
a776957c
TT
57722019-04-30 Tom Tromey <tromey@adacore.com>
5773
5774 PR c++/24470:
5775 * dwarf2read.c (process_structure_scope): Handle case where type
5776 has template parameters but no symbol was created.
5777
bc68014d
AB
57782019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5779 Chris January <chris.january@arm.com>
5780
5781 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5782 qualifier.
5783 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5784
f1fdc960
AB
57852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5786
5787 * f-typeprint.c (f_print_type): Update rules for printing
5788 whitespace.
5789 (f_type_print_varspec_suffix): Likewise.
5790
bf7a4de1
AB
57912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5792 Chris January <chris.january@arm.com>
5793
5794 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5795 function arguments.
5796
bbe75b9d
AB
57972019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5798
5799 * f-lang.c (build_fortran_types): Change name of void type to
5800 lower case.
5801 * f-typeprint.c (f_type_print_base): Print the name of the void
5802 type, rather than a fixed string.
5803 * f-valprint.c (f_decorations): Use lower case void string.
5804
1db455a7
AB
58052019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5806 Chris January <chris.january@arm.com>
5807
5808 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5809 types for Fortran.
5810
b6d03bb2
AB
58112019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5812 Chris January <chris.january@arm.com>
5813 David Lecomber <david.lecomber@arm.com>
5814
5815 * f-exp.y (BINOP_INTRINSIC): New token.
5816 (exp): New parser rule handling BINOP_INTRINSIC.
5817 (f77_keywords): Add new builtin procedures.
5818 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5819 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5820 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5821 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5822 (print_unop_subexp_f): New function.
5823 (print_binop_subexp_f): New function.
5824 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5825 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5826 (dump_subexp_body_f): Likewise.
5827 (operator_check_f): Likewise.
5828 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5829 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5830
83228e93
AB
58312019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5832
5833 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5834 UNOP_KIND.
5835 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5836 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5837 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5838 (operator_length_f): New fuction.
5839 (print_subexp_f): New function.
5840 (op_name_f): New function.
5841 (dump_subexp_body_f): New function.
5842 (operator_check_f): New function.
5843 (exp_descriptor_f): Replace standard expression handling functions
5844 with new functions.
5845 * gdb/fortran-operator.def: New file.
5846 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5847 * gdb/std-operator.def: Remove UNOP_KIND.
5848
6fdcd7cc
AB
58492019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5850
5851 * std-operator.def: Remove unbalanced, stray double quote
5852 character.
5853
2e62ab40
AB
58542019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5855 Chris January <chris.january@arm.com>
5856 Daniel Everett <daniel.everett@arm.com>
5857 Nick Forrington <nick.forrington@arm.com>
5858 Richard Bunt <richard.bunt@arm.com>
5859
5860 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5861 of depth when printing anonymous structs or unions.
5862 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5863 Don't print either the top-level value, or the children if the
5864 max-depth is exceeded.
5865 (ppscm_print_children): When printing the key of a map, allow one
5866 extra level of depth.
5867 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5868 print either the top-level value, or the children if the max-depth
5869 is exceeded.
5870 (print_children): When printing the key of a map, allow one extra
5871 level of depth.
5872 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5873 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5874 (user_print_options): Initialise max_depth field.
5875 (val_print_scalar_or_string_type_p): New function.
5876 (val_print): Check to see if the max depth has been reached.
5877 (val_print_check_max_depth): Define new function.
5878 (show_print_max_depth): New function.
5879 (_initialize_valprint): Add 'print max-depth' option.
5880 * valprint.h (struct value_print_options) <max_depth>: New field.
5881 (val_print_check_max_depth): Declare new function.
5882 * NEWS: Document new feature.
5883
4be290b2
AB
58842019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5885
5886 * ada-lang.c (ada_language_defn): Initialise new field.
5887 * c-lang.c (c_is_string_type_p): New function.
5888 (c_language_defn): Initialise new field.
5889 (cplus_language_defn): Initialise new field.
5890 (asm_language_defn): Initialise new field.
5891 (minimal_language_defn): Initialise new field.
5892 * c-lang.h (c_is_string_type_p): Declare new function.
5893 * d-lang.c (d_language_defn): Initialise new field.
5894 * f-lang.c (f_is_string_type_p): New function.
5895 (f_language_defn): Initialise new field.
5896 * go-lang.c (go_is_string_type_p): New function.
5897 (go_language_defn): Initialise new field.
5898 * language.c (default_is_string_type_p): New function.
5899 (unknown_language_defn): Initialise new field.
5900 (auto_language_defn): Initialise new field.
5901 * language.h (struct language_defn) <la_is_string_type_p>: New
5902 member variable.
5903 (default_is_string_type_p): Declare new function.
5904 * m2-lang.c (m2_language_defn): Initialise new field.
5905 * objc-lang.c (objc_language_defn): Initialise new field.
5906 * opencl-lang.c (opencl_language_defn): Initialise new field.
5907 * p-lang.c (pascal_is_string_type_p): New function.
5908 (pascal_language_defn): Initialise new field.
5909 * rust-lang.c (rust_is_string_type_p): New function.
5910 (rust_language_defn): Initialise new field.
5911
721b08c6
AB
59122019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5913
5914 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5915 New field.
5916 * ada-lang.c (ada_language_defn): Initialise new field.
5917 * c-lang.c (c_language_defn): Likewise.
5918 (cplus_language_defn): Likewise.
5919 (asm_language_defn): Likewise.
5920 (minimal_language_defn): Likewise.
5921 * d-lang.c (d_language_defn): Likewise.
5922 * f-lang.c (f_language_defn): Likewise.
5923 * go-lang.c (go_language_defn): Likewise.
5924 * language.c (unknown_language_defn): Likewise.
5925 (auto_language_defn): Likewise.
5926 * m2-lang.c (m2_language_defn): Likewise.
5927 * objc-lang.c (objc_language_defn): Likewise.
5928 * opencl-lang.c (opencl_language_defn): Likewise.
5929 * p-lang.c (pascal_language_defn): Likewise.
5930 * rust-lang.c (rust_language_defn): Likewise.
5931
fc913e53
AB
59322019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5933
5934 * ada-lang.c (ada_is_character_type): Change return type to bool.
5935 (ada_is_string_type): Likewise.
5936 * ada-lang.h (ada_is_character_type): Update declaration
5937 (ada_is_string_type): Likewise.
5938
fa731fa0
PW
59392019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5940
5941 Support style in 'frame|thread apply'
5942
5943 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5944 * record.c (record_start, record_stop): Update callers of
5945 execute_command_to_string with false.
5946 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5947 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5948 methods.
5949 (class string_file): New constructor with term_out parameter.
5950 Override methods term_out and can_emit_style_escape. New member
5951 term_out.
5952 (class stdio_file): Override can_emit_style_escape.
5953 (class tee_file): Override term_out and can_emit_style_escape.
5954 * utils.h (can_emit_style_escape): Remove.
5955 * utils.c (can_emit_style_escape): Likewise.
5956 Update all callers of can_emit_style_escape (SOMESTREAM) to
5957 SOMESTREAM->can_emit_style_escape.
5958 * source-cache.c (source_cache::get_source_lines): Likewise.
5959 * stack.c (frame_apply_command_count): Call execute_command_to_string
5960 passing the term_out characteristic of the current gdb_stdout.
5961 * thread.c (thr_try_catch_cmd): Likewise.
5962 * top.c (execute_command_to_string): pass term_out parameter
5963 to construct the string_file for the command output.
5964 * ui-file.c (term_cli_styling): New function (most code moved
5965 from utils.c can_emit_style_escape).
5966 (string_file::string_file, string_file::can_emit_style_escape,
5967 stdio_file::can_emit_style_escape, tee_file::term_out,
5968 tee_file::can_emit_style_escape): New functions.
5969
136afab8
PW
59702019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5971
5972 * NEWS: Mention the new set|show may-call-functions.
5973 * infcall.c (may_call_functions_p): New variable.
5974 (show_may_call_functions_p): New function.
5975 (call_function_by_hand_dummy): Throws an error if not
5976 may-call-functions.
5977 (_initialize_infcall): Call add_setshow_boolean_cmd for
5978 may-call-functions.
5979
725cbb63
KS
59802019-04-25 Keith Seitz <keiths@redhat.com>
5981
5982 PR c++/24367
5983 * cp-support.c (inspect_type): Don't attempt substitutions
5984 of symbol with the same name.
5985
3d1cbb78
TT
59862019-04-25 Tom Tromey <tromey@adacore.com>
5987
5988 PR gdb/24475:
5989 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5990 static.
5991
94aeb44b
TT
59922019-04-25 Tom Tromey <tromey@adacore.com>
5993
5994 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5995 rvalue reference.
5996 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5997 (gdb_xml_parser::parse): Use std::move.
5998 * python/python-internal.h (gdbpy_convert_exception): Take a const
5999 reference.
6000 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6001 std::move.
6002 * python/py-utils.c (gdbpy_convert_exception): Take a const
6003 reference.
6004 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6005 Use std::move.
6006 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6007 Use std::move.
6008 * mi/mi-main.c (mi_print_exception): Take a const reference.
6009 * main.c (handle_command_errors): Take a const reference.
6010 * linespec.c (parse_linespec): Use std::move.
6011 * infcall.c (run_inferior_call): Use std::move.
6012 (call_function_by_hand_dummy): Use std::move.
6013 * exec.c (try_open_exec_file): Use std::move.
6014 * exceptions.h (exception_print, exception_fprintf)
6015 (exception_print_same): Update.
6016 * exceptions.c (print_exception, exception_print)
6017 (exception_fprintf, exception_print_same): Change parameters to
6018 const reference.
6019 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6020 * common/new-op.c: Use std::move.
6021 * common/common-exceptions.h (struct gdb_exception): Add move
6022 constructor.
6023 (struct gdb_exception_error, struct gdb_exception_quit, struct
6024 gdb_quit_bad_alloc): Change constructor to move constructor.
6025 (throw_exception): Change parameter to rvalue reference.
6026 * common/common-exceptions.c (throw_exception): Take rvalue
6027 reference.
6028 * cli/cli-interp.c (safe_execute_command): Use std::move.
6029 * breakpoint.c (insert_bp_location, location_to_sals): Use
6030 std::move.
6031
680d7fd5
TT
60322019-04-25 Tom Tromey <tromey@adacore.com>
6033
6034 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6035 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6036 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6037 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6038 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6039 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6040 guile/scm-value.c: Use unpack.
6041 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6042 gdbscm_gdb_exception.
6043 (gdbscm_throw_gdb_exception): Likewise.
6044 (struct gdbscm_gdb_exception): New.
6045 (unpack): New function.
6046 (gdbscm_wrap): Use unpack.
6047
c6fdd8b2
TT
60482019-04-25 Tom Tromey <tromey@adacore.com>
6049
6050 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6051 (gdb_rl_callback_handler): Use std::move.
6052 * common/common-exceptions.h (struct gdb_exception): Add move
6053 assignment operator.
6054 (throw_exception_sjlj): Change "exception" to const reference.
6055 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6056 (throw_exception_sjlj): Change "exception" to const reference.
6057
cc06b668
TT
60582019-04-25 Tom Tromey <tromey@adacore.com>
6059
6060 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6061 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6062 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6063 Update.
6064 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6065 Update.
6066 * mi/mi-interp.c (mi_interp::exec): Update.
6067 * linespec.c (parse_linespec): Update.
6068 * infcall.c (run_inferior_call): Update.
6069 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6070 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6071 (gdbscm_lookup_global_symbol): Update.
6072 * guile/scm-param.c (gdbscm_parameter_value): Update.
6073 * guile/scm-frame.c (gdbscm_frame_read_register)
6074 (gdbscm_frame_read_var): Update.
6075 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6076 * exec.c (try_open_exec_file): Update.
6077 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6078 (gdb_rl_callback_handler): Update.
6079 * common/common-exceptions.h (exception_none): Don't declare.
6080 * common/common-exceptions.c (exception_none): Don't define.
6081 (struct catcher) <exception>: Update.
6082 * cli/cli-interp.c (safe_execute_command): Update.
6083 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6084
cf532bd1
AT
60852019-04-25 Ali Tamur <tamur@google.com>
6086
6087 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6088 (read_attribute_value): Likewise.
6089 (dwarf2_read_addr_index): Update comment.
6090 (read_str_index): Add DW_FORM_strx.
6091 (dwarf2_string_attr): Likewise.
6092 (dwarf2_const_value_attr): Likewise.
6093 (dump_die_shallow): Likewise.
6094 (dwarf2_fetch_constant_bytes): Likewise.
6095 (skip_form_bytes): Likewise.
6096 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6097
82433e3e
SDJ
60982019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6099
6100 PR corefiles/11608
6101 PR corefiles/18187
6102 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6103 OFFSET. Verify if current mapping contains an ELF header.
6104 (linux_find_memory_regions_full): Adjust call to
6105 dump_mapping_p.
6106
723adb65
SL
61072019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6108 Kang Li <kanglictf@gmail.com>
6109
6110 PR gdb/21600
6111
6112 * dwarf2-frame.c (read_initial_length): Be consistent about using
6113 unsigned representation of length.
6114 (decode_frame_entry_1): Likewise. Check for wraparound of
6115 end pointer as well as buffer overflow.
6116
596179f7
SDJ
61172019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6118
6119 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6120 "vq".
6121
a59240a4
TT
61222019-04-24 Tom Tromey <tromey@adacore.com>
6123
6124 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6125
f872fdbb
AB
61262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6127
6128 * s12z-tdep.c (s12z_unwind_pc): Delete.
6129 (s12z_unwind_sp): Delete.
6130 (s12z_gdbarch_init): Don't register deleted functions with
6131 gdbarch.
6132
b614e6f3
AB
61332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6134
6135 * rl78-tdep.c (rl78_unwind_sp): Delete.
6136 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6137
14faed38
AB
61382019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6139
6140 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6141 (xstormy16_unwind_pc): Delete.
6142 (xstormy16_dummy_id): Delete.
6143 (xstormy16_gdbarch_init): Don't register deleted functions with
6144 gdbarch.
6145
541aad8a
AB
61462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6147
6148 * vax-tdep.c (vax_unwind_pc): Delete.
6149 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6150
29222070
AB
61512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6152
6153 * v850-tdep.c (v850_unwind_sp): Delete.
6154 (v850_unwind_pc): Delete.
6155 (v850_dummy_id): Delete.
6156 (v850_gdbarch_init): Don't register deleted functions with
6157 gdbarch.
6158
0f534d76
AB
61592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6160
6161 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6162 (tilegx_unwind_pc): Delete.
6163 (tilegx_unwind_dummy_id): Delete.
6164 (tilegx_gdbarch_init): Don't register deleted functions with
6165 gdbarch.
6166
1ba7b7f9
AB
61672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6168
6169 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6170 (tic6x_dummy_id): Delete.
6171 (tic6x_gdbarch_init): Don't register deleted functions with
6172 gdbarch.
6173
d31f262c
AB
61742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6175
6176 * sparc-tdep.c (sparc_unwind_pc): Delete.
6177 (sparc32_gdbarch_init): Don't register deleted function with
6178 gdbarch.
6179
6d14d64d
AB
61802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6181
6182 * sh-tdep.c (sh_unwind_sp): Delete.
6183 (sh_unwind_pc): Delete.
6184 (sh_dummy_id): Delete.
6185 (sh_gdbarch_init): Don't register deleted functions with
6186 gdbarch.
6187
a40dde9d
AB
61882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6189
6190 * score-tdep.c (score_unwind_sp): Delete.
6191 (score_unwind_pc): Delete.
6192 (score_dummy_id): Delete.
6193 (score_gdbarch_init): Don't register deleted functions with
6194 gdbarch.
6195
47c47d69
AB
61962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6197
6198 * rx-tdep.c (rx_unwind_pc): Delete.
6199 (rx_unwind_sp): Delete.
6200 (rx_dummy_id): Delete.
6201 (rx_gdbarch_init): Don't register deleted functions with
6202 gdbarch. Update comment.
6203
833a4480
AB
62042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6205
6206 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6207 (rs6000_dummy_id): Delete.
6208 (rs6000_gdbarch_init): Don't register deleted functions with
6209 gdbarch.
6210
3f2cef49
AB
62112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6212
6213 * or1k-tdep.c (or1k_dummy_id): Delete.
6214 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6215
96acf884
AB
62162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6217
6218 * nios2-tdep.c (nios2_dummy_id): Delete.
6219 (nios2_unwind_sp): Delete.
6220 (nios2_gdbarch_init): Don't register deleted functions with
6221 gdbarch.
6222
ca0ab0aa
AB
62232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6224
6225 * nds32-tdep.c (nds32_dummy_id): Delete.
6226 (nds32_unwind_pc): Delete.
6227 (nds32_unwind_sp): Delete.
6228 (nds32_gdbarch_init): Don't register deleted functions with
6229 gdbarch.
6230
c8259044
AB
62312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6232
6233 * msp430-tdep.c (msp430_unwind_pc): Delete.
6234 (msp430_unwind_sp): Delete.
6235 (msp430_dummy_id): Delete.
6236 (msp430_gdbarch_init): Don't register deleted functions with
6237 gdbarch.
6238
27f113c8
AB
62392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6240
6241 * moxie-tdep.c (moxie_unwind_sp): Delete.
6242 (moxie_unwind_pc): Delete.
6243 (moxie_dummy_id): Delete.
6244 (moxie_gdbarch_init): Don't register deleted functions with
6245 gdbarch.
6246
aee6c3cd
AB
62472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6248
6249 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6250 (mn10300_unwind_pc): Delete.
6251 (mn10300_unwind_sp): Delete.
6252 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6253 mn10300_unwind_sp.
6254 (mn10300_frame_unwind_init): Don't register deleted functions with
6255 gdbarch.
6256
8e2b5aea
AB
62572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6258
6259 * mep-tdep.c (mep_unwind_pc): Delete.
6260 (mep_unwind_sp): Delete.
6261 (mep_dummy_id): Delete.
6262 (mep_gdbarch_init): Don't register deleted functions with
6263 gdbarch.
6264
43cf3ede
AB
62652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6266
6267 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6268 (m68hc11_unwind_sp): Delete.
6269 (m68hc11_gdbarch_init): Don't register deleted functions with
6270 gdbarch.
6271
5e79b7bb
AB
62722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6273
6274 * m32r-tdep.c (m32r_unwind_sp): Delete.
6275 (m32r_unwind_pc): Delete.
6276 (m32r_dummy_id): Delete.
6277 (m32r_gdbarch_init): Don't register deleted functions with
6278 gdbarch.
6279
89b268d8
AB
62802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6281
6282 * m32c-tdep.c (m32c_unwind_pc): Delete.
6283 (m32c_unwind_sp): Delete.
6284 (m32c_dummy_id): Delete.
6285 (m32c_gdbarch_init): Don't register deleted functions with
6286 gdbarch.
6287
946c28d2
AB
62882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6289
6290 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6291 (lm32_unwind_pc): Delete.
6292 (lm32_dummy_id): Delete.
6293 (lm32_gdbarch_init): Don't register deleted functions with
6294 gdbarch.
6295
bf12844a
AB
62962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6297
6298 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6299 (iq2000_unwind_pc): Delete.
6300 (iq2000_dummy_id): Delete.
6301 (iq2000_gdbarch_init): Don't register deleted functions with
6302 gdbarch.
6303
ecbc06d2
AB
63042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6305
6306 * nds32-tdep.c (nds32_type_align): Delete.
6307 (nds32_push_dummy_call): Use type_align instead.
6308
030197b4
AB
63092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6310
6311 * arm-tdep.c (arm_type_align): Only handle vector override case.
6312 (arm_push_dummy_call): Use type_align.
6313 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6314
b907456c
AB
63152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6316
6317 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6318 case.
6319 (pass_on_stack): Use type_align.
6320 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6321 function.
6322
9e97ba43
TT
63232019-04-23 Tom Tromey <tromey@adacore.com>
6324
6325 * dwarf2read.c (line_header::file_name_at): Remove unused
6326 overload.
6327
6892f601
TV
63282019-04-23 Tom de Vries <tdevries@suse.de>
6329
6330 PR gdb/24438
6331 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6332 invocation.
6333
336d760d
AT
6334
63352019-03-27 Ali Tamur <tamur@google.com>
6336
6337 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6338 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6339 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6340 (dwarf_expr_context::get_addr_index): Likewise
6341 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6342 (symbol_needs_eval_context::get_addr_index): Likewise
6343 (disassemble_dwarf_expression): Add DW_OP_addrx
6344 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6345 (read_cutu_die_from_dwo): Update comment
6346 (skip_one_die): Add DW_FORM_addrx
6347 (read_attribute_value): Likewise
6348 (var_decode_location): Add DW_OP_addrx
6349 (dwarf2_const_value_attr): Add DW_FORM_addrx
6350 (dump_die_shallow): Likewise
6351 (dwarf2_fetch_constant_bytes): Likewise
6352 (decode_locdesc): Add DW_OP_addrx
6353 (skip_form_bytes): Add DW_FORM_addrx
6354
ad9d13f8
AT
63552019-04-22 Ali Tamur <tamur@google.com>
6356
6357 * MAINTAINERS (Write After Approval): Add self.
6358
d70cc3ba
SM
63592019-04-22 Simon Marchi <simon.marchi@efficios.com>
6360
6361 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6362 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6363 (open_symbol_file_object): Likewise.
6364 (svr4_default_sos): Add info parameter.
6365 (svr4_read_so_list): Likewise.
6366 (svr4_current_sos_direct): Adjust functions calls to pass down
6367 info.
6368 (svr4_current_sos_1): Add info parameter.
6369 (svr4_current_sos): Call get_svr4_info, pass info down to
6370 svr4_current_sos_1.
6371 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6372 get_svr4_info.
6373 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6374 get_svr4_info.
6375 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6376 to get_svr4_info.
6377 (probes_table_remove_objfile_probes): Likewise.
6378 (register_solib_event_probe): Add info parameter.
6379 (solist_update_incremental): Pass info parameter down to
6380 svr4_read_so_list.
6381 (disable_probes_interface): Add info parameter.
6382 (svr4_handle_solib_event): Pass current_program_space to
6383 get_svr4_info. Adjust disable_probes_interface cleanup.
6384 (svr4_create_probe_breakpoints): Add info parameter, pass it
6385 down to register_solib_event_probe.
6386 (svr4_create_solib_event_breakpoints): Add info parameter,
6387 pass it down to svr4_create_probe_breakpoints.
6388 (enable_break): Pass info down to
6389 svr4_create_solib_event_breakpoints.
6390 (svr4_solib_create_inferior_hook): Pass current_program_space to
6391 get_svr4_info.
6392 (svr4_clear_solib): Likewise.
6393
7905fc35
PA
63942019-04-22 Pedro Alves <palves@redhat.com>
6395
6396 * solib-svr4.c (svr4_free_objfile_observer): New.
6397 (probe_and_action::objfile): New field.
6398 (probes_table_htab_remove_objfile_probes)
6399 (probes_table_remove_objfile_probes): New functions.
6400 (register_solib_event_probe): Add 'objfile' parameter. Store it
6401 in the new probe_and_action. Don't store the probe in 'lookup'.
6402 (svr4_create_probe_breakpoints): Pass objfile to
6403 register_solib_event_probe.
6404 (_initialize_svr4_solib): Register a free_objfile observer.
6405
fb881986
TT
64062019-04-19 Tom Tromey <tom@tromey.com>
6407
6408 * common/queue.h: Remove.
6409
8732db6c
TT
64102019-04-19 Tom Tromey <tom@tromey.com>
6411
6412 * event-loop.c: Don't include "common/queue.h".
6413
97dfbadd
TT
64142019-04-19 Tom Tromey <tom@tromey.com>
6415
6416 * remote.c (remote_target): Use delete.
6417 * remote-notif.h: Include <list>, not "common/queue.h".
6418 (notif_client_p): Remove typedef.
6419 (remote_notif_state): Add constructor, destructor, initializer.
6420 <notif_queue>: Now a std::list.
6421 (remote_notif_state_xfree): Don't declare.
6422 * remote-notif.c (remote_notif_process, handle_notification)
6423 (remote_notif_state_allocate): Update.
6424 (~remote_notif_state): Rename from remote_notif_state_xfree.
6425
cf250e36
TT
64262019-04-19 Tom Tromey <tom@tromey.com>
6427
6428 * symfile.c (reread_symbols): Update.
6429 * objfiles.c (objfile_register_static_link)
6430 (objfile_lookup_static_link): Update
6431 (~objfile) Don't delete static_links.
6432 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6433
61f4b350
TT
64342019-04-19 Tom Tromey <tom@tromey.com>
6435
6436 * type-stack.h (struct type_stack) <insert>: Constify string.
6437 * type-stack.c (type_stack::insert): Constify string.
6438 * gdbtypes.h (lookup_template_type): Update.
6439 (address_space_name_to_int): Update.
6440 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6441 const.
6442 (lookup_template_type): Make name const.
6443 * c-exp.y: Update rules.
6444 (lex_one_token, classify_name, classify_inner_name)
6445 (c_print_token): Update.
6446 * p-exp.y: Update rules.
6447 (yylex): Update.
6448 * f-exp.y: Update rules.
6449 (yylex): Update.
6450 * d-exp.y: Update rules.
6451 (lex_one_token, classify_name, classify_inner_name): Update.
6452 * parse.c (write_dollar_variable, copy_name): Return std::string.
6453 * parser-defs.h (copy_name): Change return type.
6454 * m2-exp.y: Update rules.
6455 (yylex): Update.
6456 * go-exp.y (lex_one_token): Update.
6457 Update rules.
6458 (classify_unsafe_function, classify_packaged_name)
6459 (classify_name, yylex): Update.
6460
189b8c2e
ST
64612019-04-19 Sergei Trofimovich <siarheit@google.com>
6462
6463 * configure.ac: add --enable-source-highlight switch.
6464 * configure: Regenerate.
6465 * top.c (print_gdb_version): plumb --enable-source-highlight
6466 status to "show configuration".
6467
8ecb59f8
TT
64682019-04-19 Tom Tromey <tromey@adacore.com>
6469
6470 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6471 Check ADA_TYPE_P.
6472 (empty_record, ada_template_to_fixed_record_type_1)
6473 (template_to_static_fixed_type)
6474 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6475 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6476 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6477 macros.
6478
62160ec9
TT
64792019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6480
6481 PR symtab/24423:
6482 * source.c (print_source_lines_base): Advance "iter" when a
6483 control character is seen.
6484
f2ae8bc8
PW
64852019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6486
6487 * inferior.h (struct infcall_suspend_state_deleter):
6488 Catch exception in destructor to avoid crash.
6489
d563b953
PW
64902019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6491
6492 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6493 close to the add_com "shell".
6494
dc34c897
TT
64952019-04-18 Tom Tromey <tromey@adacore.com>
6496
6497 * process-stratum-target.h (class process_stratum_target)
6498 <stratum>: Add "final".
6499
a12e5744
TT
65002019-04-17 Tom Tromey <tromey@adacore.com>
6501
6502 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6503 against nullptr before use.
6504
a7e559cc
AH
65052019-04-17 Alan Hayward <alan.hayward@arm.com>
6506
6507 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6508
c01660c6
AB
65092019-04-17 Jim Wilson <jimw@sifive.com>
6510 Andrew Burgess <andrew.burgess@embecosm.com>
6511
6512 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6513 code read might fail, assume 4-byte breakpoint in that case.
6514
4aa866af
LS
65152019-04-15 Leszek Swirski <leszeks@google.com>
6516
6517 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6518 rather than a hand-rolled POD check when checking for forced MEMORY
6519 classification.
6520
48574d91
AH
65212019-04-15 Alan Hayward <alan.hayward@arm.com>
6522
6523 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6524 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6525 function.
6526 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6527 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6528 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6529 declaration.
6530
4da037ef
AH
65312019-04-15 Alan Hayward <alan.hayward@arm.com>
6532
6533 * aarch64-linux-nat.c
6534 (aarch64_linux_nat_target::thread_architecture): Add override.
6535 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6536 each VQ.
6537
ccb8d7e8
AH
65382019-04-15 Alan Hayward <alan.hayward@arm.com>
6539
6540 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6541
35add35e
AB
65422019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6543
6544 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6545 target types of size 96-bits, add some additional comments, and
6546 check that the builtin type we found was the correct size.
6547
51196bbc
EZ
65482019-04-12 Eli Zaretskii <eliz@gnu.org>
6549
6550 * utils.c (prompt_for_continue): Don't restore the styling at the
6551 end, as applied_style has the wrong value. This fixes styling in
6552 long lists of file names that are interrupted by the "Continue?"
6553 prompt.
6554
62253a61
AB
65552019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6556
6557 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6558 * c-lang.c (c_language_defn): Likewise.
6559 (cplus_language_defn): Likewise.
6560 (asm_language_defn): Likewise.
6561 (minimal_language_defn): Likewise.
6562 * d-lang.c (d_language_defn): Likewise.
6563 * f-lang.c (f_language_defn): Likewise.
6564 * go-lang.c (go_language_defn): Likewise.
6565 * language.c (unknown_language_defn): Likewise.
6566 (auto_language_defn): Likewise.
6567 * language.h (struct language_defn): Remove la_magic field.
6568 (LANG_MAGIC): Delete.
6569 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6570 * objc-lang.c (objc_language_defn): Likewise.
6571 * opencl-lang.c (opencl_language_defn): Likewise.
6572 * p-lang.c (pascal_language_defn): Likewise.
6573 * rust-lang.c (rust_language_defn): Likewise.
6574
a9158a86
AB
65752019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6576
6577 * riscv-tdep.c (riscv_type_align): New function.
6578 (riscv_type_alignment): Delete.
6579 (riscv_arg_location): Use 'type_align'.
6580 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6581
41077b66
AB
65822019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6583
6584 * gdbtypes.c (type_align): A struct with no non-static fields also
6585 has alignment of 1.
6586
9f0272f8
AB
65872019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6588
6589 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6590 component to 0.
6591 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6592 member.
6593 (riscv_struct_info::analyse): New implementation using new
6594 analyse_inner member function.
6595 (riscv_struct_info::field_offset): New member function.
6596 (riscv_struct_info::m_offsets): New member variable.
6597 (riscv_struct_info::analyse_inner): New private member function,
6598 takes the old implementation of riscv_struct_info::analyse but
6599 extended to track field offsets.
6600 (riscv_call_arg_struct): Update the struct folding special cases
6601 to handle cases where empty C++ structs, which are non-zero
6602 length, are found.
6603 (riscv_arg_location): Initialise the length of each location, a
6604 non-zero length now indicates the location is in use.
6605 (riscv_push_dummy_call): Allow for the first location having a
6606 non-zero offset when setting up arguments.
6607 (riscv_return_value): Likewise, but for return values.
6608
02cf60c7
TT
66092019-04-11 Tom Tromey <tromey@adacore.com>
6610
6611 * utils.c (internal_vproblem): Make "msg" const.
6612
68811f8f
AH
66132019-04-11 Alan Hayward <alan.hayward@arm.com>
6614
6615 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6616 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6617 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6618 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6619
3f52fdbc
KB
66202019-04-10 Kevin Buettner <kevinb@redhat.com>
6621
6622 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6623 function.
6624 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6625 of amd64_collect_native_gregset.
6626 (amd64_linux_nat_target::store_registers): Likewise.
6627
e9ad22ee
TT
66282019-04-10 Tom Tromey <tom@tromey.com>
6629
6630 * symtab.c (lookup_global_symbol_from_objfile)
6631 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6632 * objfiles.h (class separate_debug_iterator): New.
6633 (class separate_debug_range): New.
6634 (struct objfile) <separate_debug_objfiles>: New method.
6635 (objfile_separate_debug_iterate): Don't declare.
6636 * objfiles.c (separate_debug_iterator::operator++): Rename from
6637 objfile_separate_debug_iterate.
6638 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6639 iterator.
6640 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6641 iterator.
6642
ee371134
TT
66432019-04-10 Tom Tromey <tom@tromey.com>
6644
6645 * symfile.c (reread_symbols): Remove old comment.
6646 * objfiles.c (free_all_objfiles): Fix a typo.
6647
bf227d61
TT
66482019-04-10 Tom Tromey <tom@tromey.com>
6649
6650 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6651 * minsyms.c (lookup_minimal_symbol): Use foreach.
6652 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6653 (lookup_minimal_symbol_solib_trampoline): Likewise.
6654 * symfile.c (reread_symbols): Use foreach.
6655
8dc433a0
TT
66562019-04-09 Ivan Begert <ivanbegert@gmail.com>
6657 Tom Tromey <tromey@adacore.com>
6658
6659 PR rust/24414:
6660 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6661 (rust_lex_int_test): Change "value" to be LONGEST.
6662 (rust_lex_tests): Add test for long integer literal.
6663
9ab8741a
TT
66642019-04-09 Tom Tromey <tromey@adacore.com>
6665
6666 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6667 to bool.
6668 (extended_remote_target::attach): Update.
6669 (remote_target::remote_notice_new_inferior): Update.
6670 (remote_target::add_current_inferior_and_thread): Update.
6671 * inferior.c (exit_inferior_1): Use "false".
6672 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6673
e242fd12
SM
66742019-04-09 Simon Marchi <simon.marchi@efficios.com>
6675
9ca1957f 6676 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6677 the "start" command.
6678
2b0c8b01
KB
66792019-04-08 Kevin Buettner <kevinb@redhat.com>
6680
6681 * python/py-inferior.c (infpy_thread_from_thread_handle):
6682 Adjust comments to reflect renaming of thread_from_thread_handle
6683 to thread_from_handle. Adjust keywords. Fix type error message.
6684 (inferior_object_methods): Add thread_from_handle. Retain
6685 thread_from_thread_handle, but mark it as deprecated.
6686
50a82723
KB
66872019-04-08 Kevin Buettner <kevinb@redhat.com>
6688
6689 * gdbthread.h (find_thread_by_handle): Revise declaration.
6690 * thread.c (find_thread_by_handle): Likewise. Adjust
6691 implementation too.
6692 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6693 support for buffer objects as handles.
6694
cf63b016
KB
66952019-04-08 Kevin Buettner <kevinb@redhat.com>
6696
6697 * python/py-infthread.c (thpy_thread_handle): New function.
6698 (thread_object_methods): Register thpy_thread_handle.
6699
3d6c6204
KB
67002019-04-08 Kevin Buettner <kevinb@redhat.com>
6701
6702 * gdbthread.h (thread_to_thread_handle): Declare.
6703 * thread.c (gdbtypes.h): Include.
6704 (thread_to_thread_handle): New function.
6705
6706 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6707 (target_thread_info_to_thread_handle): Declare.
6708 * target.c (target_thread_info_to_thread_handle): New function.
6709 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6710 * target-delegates.c: Regenerate.
6711
6712 * linux-thread-db.c (class thread_db_target): Add method
6713 thread_info_to_thread_handle.
6714 (thread_db_target::thread_info_to_thread_handle): Define.
6715 * remote.c (class remote_target): Add new method
6716 thread_info_to_thread_handle.
6717 (remote_target::thread_info_to_thread_handle): Define.
6718
56be6ea8
PA
67192019-04-08 Pedro Alves <palves@redhat.com>
6720
6721 * common/common-exceptions.c (throw_exception): Don't create
6722 named object to throw; throw directly.
6723 (throw_it): Likewise. Don't initialize gdb_exception::message
6724 here, with new; pass FMT and AP to the ctor instead.
6725 * common/common-exceptions.h: Include <string>.
6726 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6727 const char *, va_list)): New ctor. Use std::make_shared.
6728 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6729 errors)): Delete.
6730 (gdb_exception_error::gdb_exception_error(enum errors, const char
6731 *, va_list)): New.
6732 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6733 Add assertion.
6734 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6735 errors)): Delete.
6736 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6737 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6738 Add assertion.
6739
eedc3f4f
TT
67402019-04-08 Tom Tromey <tom@tromey.com>
6741
6742 * valops.c (value_rtti_indirect_type): Replace throw_exception
6743 with throw.
6744 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6745 with throw.
6746 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6747 throw.
6748 * target.c (target_translate_tls_address): Replace throw_exception
6749 with throw.
6750 * stack.c (frame_apply_command_count): Replace throw_exception
6751 with throw.
6752 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6753 throw.
6754 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6755 with throw.
6756 * rs6000-tdep.c (rs6000_frame_cache)
6757 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6758 * remote.c: Replace throw_exception with throw.
6759 * record-full.c (record_full_message, record_full_wait_1)
6760 (record_full_restore): Replace throw_exception with throw.
6761 * record-btrace.c:
6762 (get_thread_current_frame_id, record_btrace_start_replaying)
6763 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6764 (cmd_record_btrace_start): Replace throw_exception with throw.
6765 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6766 throw.
6767 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6768 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6769 * linespec.c:
6770 (find_linespec_symbols): Replace throw_exception with throw.
6771 * infrun.c (displaced_step_prepare, resume): Replace
6772 throw_exception with throw.
6773 * infcmd.c (post_create_inferior): Replace throw_exception with
6774 throw.
6775 * inf-loop.c (inferior_event_handler): Replace throw_exception
6776 with throw.
6777 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6778 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6779 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6780 (get_prev_frame_always, get_frame_pc_if_available)
6781 (get_frame_address_in_block_if_available, get_frame_language):
6782 Replace throw_exception with throw.
6783 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6784 throw_exception with throw.
6785 * eval.c (fetch_subexp_value, evaluate_var_value)
6786 (evaluate_funcall, evaluate_subexp_standard): Replace
6787 throw_exception with throw.
6788 * dwarf2loc.c (call_site_find_chain)
6789 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6790 Replace throw_exception with throw.
6791 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6792 with throw.
6793 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6794 throw.
6795 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6796 * completer.c (complete_line_internal): Replace throw_exception
6797 with throw.
6798 * compile/compile-object-run.c (compile_object_run): Replace
6799 throw_exception with throw.
6800 * cli/cli-script.c (process_next_line): Replace throw_exception
6801 with throw.
6802 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6803 (btrace_enable, btrace_maint_update_pt_packets): Replace
6804 throw_exception with throw.
6805 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6806 throw_exception with throw.
6807 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6808 throw_exception with throw.
6809 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6810 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6811 * aarch64-tdep.c (aarch64_make_prologue_cache)
6812 (aarch64_make_stub_cache): Replace throw_exception with throw.
6813
26003a20
TT
68142019-04-08 Tom Tromey <tom@tromey.com>
6815
6816 * common/common-exceptions.c (throw_exception): Rename from
6817 throw_exception_cxx. Remove old copy. Make argument const.
6818 (throw_it): Create and throw exception objects directly.
6819 * common/common-exceptions.h (throw_exception): Make argument
6820 const.
6821 (struct gdb_exception_error): Add constructor.
6822 (struct gdb_exception_quit): Add constructor.
6823
d272eb37
TT
68242019-04-08 Tom Tromey <tom@tromey.com>
6825
6826 * common/common-exceptions.h (exception_rethrow): Don't declare.
6827 (TRY_SJLJ): Update comment.
6828 (TRY, CATCH, END_CATCH): Remove.
6829 * common/common-exceptions.c (exception_rethrow): Remove.
6830
230d2906
TT
68312019-04-08 Tom Tromey <tom@tromey.com>
6832
6833 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6834 Remove.
6835 (gdb_exception_error): Rename from
6836 gdb_exception_RETURN_MASK_ERROR.
6837 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6838 (gdb_quit_bad_alloc): Update.
6839 * aarch64-tdep.c: Update.
6840 * ada-lang.c: Update.
6841 * ada-typeprint.c: Update.
6842 * ada-valprint.c: Update.
6843 * amd64-tdep.c: Update.
6844 * arch-utils.c: Update.
6845 * break-catch-throw.c: Update.
6846 * breakpoint.c: Update.
6847 * btrace.c: Update.
6848 * c-varobj.c: Update.
6849 * cli/cli-cmds.c: Update.
6850 * cli/cli-interp.c: Update.
6851 * cli/cli-script.c: Update.
6852 * common/common-exceptions.c: Update.
6853 * common/new-op.c: Update.
6854 * common/selftest.c: Update.
6855 * compile/compile-c-symbols.c: Update.
6856 * compile/compile-cplus-symbols.c: Update.
6857 * compile/compile-object-load.c: Update.
6858 * compile/compile-object-run.c: Update.
6859 * completer.c: Update.
6860 * corelow.c: Update.
6861 * cp-abi.c: Update.
6862 * cp-support.c: Update.
6863 * cp-valprint.c: Update.
6864 * darwin-nat.c: Update.
6865 * disasm-selftests.c: Update.
6866 * dtrace-probe.c: Update.
6867 * dwarf-index-cache.c: Update.
6868 * dwarf-index-write.c: Update.
6869 * dwarf2-frame-tailcall.c: Update.
6870 * dwarf2-frame.c: Update.
6871 * dwarf2loc.c: Update.
6872 * dwarf2read.c: Update.
6873 * eval.c: Update.
6874 * event-loop.c: Update.
6875 * event-top.c: Update.
6876 * exec.c: Update.
6877 * f-valprint.c: Update.
6878 * fbsd-tdep.c: Update.
6879 * frame-unwind.c: Update.
6880 * frame.c: Update.
6881 * gdbtypes.c: Update.
6882 * gnu-v3-abi.c: Update.
6883 * guile/guile-internal.h: Update.
6884 * guile/scm-block.c: Update.
6885 * guile/scm-breakpoint.c: Update.
6886 * guile/scm-cmd.c: Update.
6887 * guile/scm-disasm.c: Update.
6888 * guile/scm-frame.c: Update.
6889 * guile/scm-lazy-string.c: Update.
6890 * guile/scm-math.c: Update.
6891 * guile/scm-param.c: Update.
6892 * guile/scm-ports.c: Update.
6893 * guile/scm-pretty-print.c: Update.
6894 * guile/scm-symbol.c: Update.
6895 * guile/scm-symtab.c: Update.
6896 * guile/scm-type.c: Update.
6897 * guile/scm-value.c: Update.
6898 * i386-linux-tdep.c: Update.
6899 * i386-tdep.c: Update.
6900 * inf-loop.c: Update.
6901 * infcall.c: Update.
6902 * infcmd.c: Update.
6903 * infrun.c: Update.
6904 * jit.c: Update.
6905 * language.c: Update.
6906 * linespec.c: Update.
6907 * linux-fork.c: Update.
6908 * linux-nat.c: Update.
6909 * linux-tdep.c: Update.
6910 * linux-thread-db.c: Update.
6911 * main.c: Update.
6912 * mi/mi-cmd-break.c: Update.
6913 * mi/mi-cmd-stack.c: Update.
6914 * mi/mi-interp.c: Update.
6915 * mi/mi-main.c: Update.
6916 * objc-lang.c: Update.
6917 * p-valprint.c: Update.
6918 * parse.c: Update.
6919 * ppc-linux-tdep.c: Update.
6920 * printcmd.c: Update.
6921 * python/py-arch.c: Update.
6922 * python/py-breakpoint.c: Update.
6923 * python/py-cmd.c: Update.
6924 * python/py-finishbreakpoint.c: Update.
6925 * python/py-frame.c: Update.
6926 * python/py-framefilter.c: Update.
6927 * python/py-gdb-readline.c: Update.
6928 * python/py-inferior.c: Update.
6929 * python/py-infthread.c: Update.
6930 * python/py-lazy-string.c: Update.
6931 * python/py-linetable.c: Update.
6932 * python/py-objfile.c: Update.
6933 * python/py-param.c: Update.
6934 * python/py-prettyprint.c: Update.
6935 * python/py-progspace.c: Update.
6936 * python/py-record-btrace.c: Update.
6937 * python/py-record.c: Update.
6938 * python/py-symbol.c: Update.
6939 * python/py-type.c: Update.
6940 * python/py-unwind.c: Update.
6941 * python/py-utils.c: Update.
6942 * python/py-value.c: Update.
6943 * python/python.c: Update.
6944 * record-btrace.c: Update.
6945 * record-full.c: Update.
6946 * remote-fileio.c: Update.
6947 * remote.c: Update.
6948 * riscv-tdep.c: Update.
6949 * rs6000-aix-tdep.c: Update.
6950 * rs6000-tdep.c: Update.
6951 * rust-exp.y: Update.
6952 * rust-lang.c: Update.
6953 * s390-tdep.c: Update.
6954 * selftest-arch.c: Update.
6955 * solib-dsbt.c: Update.
6956 * solib-frv.c: Update.
6957 * solib-spu.c: Update.
6958 * solib-svr4.c: Update.
6959 * solib.c: Update.
6960 * sparc64-linux-tdep.c: Update.
6961 * stack.c: Update.
6962 * symfile-mem.c: Update.
6963 * symmisc.c: Update.
6964 * target.c: Update.
6965 * thread.c: Update.
6966 * top.c: Update.
6967 * tracefile-tfile.c: Update.
6968 * tui/tui.c: Update.
6969 * typeprint.c: Update.
6970 * unittests/cli-utils-selftests.c: Update.
6971 * unittests/parse-connection-spec-selftests.c: Update.
6972 * valops.c: Update.
6973 * valprint.c: Update.
6974 * value.c: Update.
6975 * varobj.c: Update.
6976 * windows-nat.c: Update.
6977 * x86-linux-nat.c: Update.
6978 * xml-support.c: Update.
6979
a70b8144
TT
69802019-04-08 Tom Tromey <tom@tromey.com>
6981
6982 * xml-support.c: Use C++ exception handling.
6983 * x86-linux-nat.c: Use C++ exception handling.
6984 * windows-nat.c: Use C++ exception handling.
6985 * varobj.c: Use C++ exception handling.
6986 * value.c: Use C++ exception handling.
6987 * valprint.c: Use C++ exception handling.
6988 * valops.c: Use C++ exception handling.
6989 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6990 handling.
6991 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6992 * typeprint.c: Use C++ exception handling.
6993 * tui/tui.c: Use C++ exception handling.
6994 * tracefile-tfile.c: Use C++ exception handling.
6995 * top.c: Use C++ exception handling.
6996 * thread.c: Use C++ exception handling.
6997 * target.c: Use C++ exception handling.
6998 * symmisc.c: Use C++ exception handling.
6999 * symfile-mem.c: Use C++ exception handling.
7000 * stack.c: Use C++ exception handling.
7001 * sparc64-linux-tdep.c: Use C++ exception handling.
7002 * solib.c: Use C++ exception handling.
7003 * solib-svr4.c: Use C++ exception handling.
7004 * solib-spu.c: Use C++ exception handling.
7005 * solib-frv.c: Use C++ exception handling.
7006 * solib-dsbt.c: Use C++ exception handling.
7007 * selftest-arch.c: Use C++ exception handling.
7008 * s390-tdep.c: Use C++ exception handling.
7009 * rust-lang.c: Use C++ exception handling.
7010 * rust-exp.y: Use C++ exception handling.
7011 * rs6000-tdep.c: Use C++ exception handling.
7012 * rs6000-aix-tdep.c: Use C++ exception handling.
7013 * riscv-tdep.c: Use C++ exception handling.
7014 * remote.c: Use C++ exception handling.
7015 * remote-fileio.c: Use C++ exception handling.
7016 * record-full.c: Use C++ exception handling.
7017 * record-btrace.c: Use C++ exception handling.
7018 * python/python.c: Use C++ exception handling.
7019 * python/py-value.c: Use C++ exception handling.
7020 * python/py-utils.c: Use C++ exception handling.
7021 * python/py-unwind.c: Use C++ exception handling.
7022 * python/py-type.c: Use C++ exception handling.
7023 * python/py-symbol.c: Use C++ exception handling.
7024 * python/py-record.c: Use C++ exception handling.
7025 * python/py-record-btrace.c: Use C++ exception handling.
7026 * python/py-progspace.c: Use C++ exception handling.
7027 * python/py-prettyprint.c: Use C++ exception handling.
7028 * python/py-param.c: Use C++ exception handling.
7029 * python/py-objfile.c: Use C++ exception handling.
7030 * python/py-linetable.c: Use C++ exception handling.
7031 * python/py-lazy-string.c: Use C++ exception handling.
7032 * python/py-infthread.c: Use C++ exception handling.
7033 * python/py-inferior.c: Use C++ exception handling.
7034 * python/py-gdb-readline.c: Use C++ exception handling.
7035 * python/py-framefilter.c: Use C++ exception handling.
7036 * python/py-frame.c: Use C++ exception handling.
7037 * python/py-finishbreakpoint.c: Use C++ exception handling.
7038 * python/py-cmd.c: Use C++ exception handling.
7039 * python/py-breakpoint.c: Use C++ exception handling.
7040 * python/py-arch.c: Use C++ exception handling.
7041 * printcmd.c: Use C++ exception handling.
7042 * ppc-linux-tdep.c: Use C++ exception handling.
7043 * parse.c: Use C++ exception handling.
7044 * p-valprint.c: Use C++ exception handling.
7045 * objc-lang.c: Use C++ exception handling.
7046 * mi/mi-main.c: Use C++ exception handling.
7047 * mi/mi-interp.c: Use C++ exception handling.
7048 * mi/mi-cmd-stack.c: Use C++ exception handling.
7049 * mi/mi-cmd-break.c: Use C++ exception handling.
7050 * main.c: Use C++ exception handling.
7051 * linux-thread-db.c: Use C++ exception handling.
7052 * linux-tdep.c: Use C++ exception handling.
7053 * linux-nat.c: Use C++ exception handling.
7054 * linux-fork.c: Use C++ exception handling.
7055 * linespec.c: Use C++ exception handling.
7056 * language.c: Use C++ exception handling.
7057 * jit.c: Use C++ exception handling.
7058 * infrun.c: Use C++ exception handling.
7059 * infcmd.c: Use C++ exception handling.
7060 * infcall.c: Use C++ exception handling.
7061 * inf-loop.c: Use C++ exception handling.
7062 * i386-tdep.c: Use C++ exception handling.
7063 * i386-linux-tdep.c: Use C++ exception handling.
7064 * guile/scm-value.c: Use C++ exception handling.
7065 * guile/scm-type.c: Use C++ exception handling.
7066 * guile/scm-symtab.c: Use C++ exception handling.
7067 * guile/scm-symbol.c: Use C++ exception handling.
7068 * guile/scm-pretty-print.c: Use C++ exception handling.
7069 * guile/scm-ports.c: Use C++ exception handling.
7070 * guile/scm-param.c: Use C++ exception handling.
7071 * guile/scm-math.c: Use C++ exception handling.
7072 * guile/scm-lazy-string.c: Use C++ exception handling.
7073 * guile/scm-frame.c: Use C++ exception handling.
7074 * guile/scm-disasm.c: Use C++ exception handling.
7075 * guile/scm-cmd.c: Use C++ exception handling.
7076 * guile/scm-breakpoint.c: Use C++ exception handling.
7077 * guile/scm-block.c: Use C++ exception handling.
7078 * guile/guile-internal.h: Use C++ exception handling.
7079 * gnu-v3-abi.c: Use C++ exception handling.
7080 * gdbtypes.c: Use C++ exception handling.
7081 * frame.c: Use C++ exception handling.
7082 * frame-unwind.c: Use C++ exception handling.
7083 * fbsd-tdep.c: Use C++ exception handling.
7084 * f-valprint.c: Use C++ exception handling.
7085 * exec.c: Use C++ exception handling.
7086 * event-top.c: Use C++ exception handling.
7087 * event-loop.c: Use C++ exception handling.
7088 * eval.c: Use C++ exception handling.
7089 * dwarf2read.c: Use C++ exception handling.
7090 * dwarf2loc.c: Use C++ exception handling.
7091 * dwarf2-frame.c: Use C++ exception handling.
7092 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7093 * dwarf-index-write.c: Use C++ exception handling.
7094 * dwarf-index-cache.c: Use C++ exception handling.
7095 * dtrace-probe.c: Use C++ exception handling.
7096 * disasm-selftests.c: Use C++ exception handling.
7097 * darwin-nat.c: Use C++ exception handling.
7098 * cp-valprint.c: Use C++ exception handling.
7099 * cp-support.c: Use C++ exception handling.
7100 * cp-abi.c: Use C++ exception handling.
7101 * corelow.c: Use C++ exception handling.
7102 * completer.c: Use C++ exception handling.
7103 * compile/compile-object-run.c: Use C++ exception handling.
7104 * compile/compile-object-load.c: Use C++ exception handling.
7105 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7106 * compile/compile-c-symbols.c: Use C++ exception handling.
7107 * common/selftest.c: Use C++ exception handling.
7108 * common/new-op.c: Use C++ exception handling.
7109 * cli/cli-script.c: Use C++ exception handling.
7110 * cli/cli-interp.c: Use C++ exception handling.
7111 * cli/cli-cmds.c: Use C++ exception handling.
7112 * c-varobj.c: Use C++ exception handling.
7113 * btrace.c: Use C++ exception handling.
7114 * breakpoint.c: Use C++ exception handling.
7115 * break-catch-throw.c: Use C++ exception handling.
7116 * arch-utils.c: Use C++ exception handling.
7117 * amd64-tdep.c: Use C++ exception handling.
7118 * ada-valprint.c: Use C++ exception handling.
7119 * ada-typeprint.c: Use C++ exception handling.
7120 * ada-lang.c: Use C++ exception handling.
7121 * aarch64-tdep.c: Use C++ exception handling.
7122
3d6e9d23
TT
71232019-04-08 Tom Tromey <tom@tromey.com>
7124
7125 * xml-support.c (gdb_xml_parser::parse): Update.
7126 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7127 * value.c (show_convenience): Update.
7128 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7129 (test_parse_flags_qcs): Update.
7130 * thread.c (thr_try_catch_cmd): Update.
7131 * target.c (target_translate_tls_address): Update.
7132 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7133 (info_frame_command_core, frame_apply_command_count): Update.
7134 * rust-exp.y (rust_lex_exception_test): Update.
7135 * riscv-tdep.c (riscv_print_one_register_info): Update.
7136 * remote.c (remote_target::enable_btrace): Update.
7137 * record-btrace.c (record_btrace_enable_warn): Update.
7138 * python/py-utils.c (gdbpy_convert_exception): Update.
7139 * printcmd.c (do_one_display, print_variable_and_value): Update.
7140 * mi/mi-main.c (mi_print_exception): Update.
7141 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7142 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7143 * linux-nat.c (linux_nat_target::attach): Update.
7144 * linux-fork.c (class scoped_switch_fork_info): Update.
7145 * infrun.c (displaced_step_prepare): Update.
7146 * infcall.c (call_function_by_hand_dummy): Update.
7147 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7148 * gnu-v3-abi.c (print_one_vtable): Update.
7149 * frame.c (get_prev_frame_always): Update.
7150 * f-valprint.c (info_common_command_for_block): Update.
7151 * exec.c (try_open_exec_file): Update.
7152 * exceptions.c (print_exception, exception_print)
7153 (exception_fprintf, exception_print_same): Update.
7154 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7155 * dwarf-index-cache.c (index_cache::store)
7156 (index_cache::lookup_gdb_index): Update.
7157 * darwin-nat.c (maybe_cache_shell): Update.
7158 * cp-valprint.c (cp_print_value_fields): Update.
7159 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7160 (gcc_cplus_symbol_address): Update.
7161 * compile/compile-c-symbols.c (gcc_convert_symbol)
7162 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7163 * common/selftest.c: Update.
7164 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7165 a std::string.
7166 (exception_try_scope_entry, exception_try_scope_exit): Don't
7167 declare.
7168 (struct exception_try_scope): Remove.
7169 (TRY): Don't use exception_try_scope.
7170 (struct gdb_exception): Add constructor, operator=.
7171 <what>: New method.
7172 (struct gdb_exception_RETURN_MASK_ALL)
7173 (struct gdb_exception_RETURN_MASK_ERROR)
7174 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7175 (struct gdb_quit_bad_alloc): Update.
7176 * common/common-exceptions.c (exception_none): Change
7177 initializer.
7178 (struct catcher) <state, exception>: Initialize inline.
7179 <prev>: Remove member.
7180 (current_catcher): Remove.
7181 (catchers): New global.
7182 (exceptions_state_mc_init): Simplify.
7183 (catcher_pop): Remove.
7184 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7185 (try_scope_depth, exception_try_scope_entry)
7186 (exception_try_scope_exit): Remove.
7187 (throw_exception_sjlj): Update.
7188 (exception_messages, exception_messages_size): Remove.
7189 (throw_it): Simplify.
7190 (gdb_exception_sliced_copy): Remove.
7191 (throw_exception_cxx): Update.
7192 * cli/cli-script.c (script_from_file): Update.
7193 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7194 Update.
7195 * ada-valprint.c (ada_val_print): Update.
7196 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7197 (create_excep_cond_exprs): Update.
7198
c5c10118
TT
71992019-04-08 Tom Tromey <tom@tromey.com>
7200
7201 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7202 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7203 (TRY, CATCH, END_CATCH): Remove some definitions.
7204 * common/common-exceptions.c: Don't use GDB_XCPT.
7205 (catcher_list_size): Remove.
7206 (throw_exception, throw_it): Simplify.
7207
4de283e4
TT
72082019-04-05 Tom Tromey <tom@tromey.com>
7209
7210 Revert the header-sorting patch.
7211 * ft32-tdep.c: Revert.
7212 * frv-tdep.c: Revert.
7213 * frv-linux-tdep.c: Revert.
7214 * frame.c: Revert.
7215 * frame-unwind.c: Revert.
7216 * frame-base.c: Revert.
7217 * fork-child.c: Revert.
7218 * findvar.c: Revert.
7219 * findcmd.c: Revert.
7220 * filesystem.c: Revert.
7221 * filename-seen-cache.h: Revert.
7222 * filename-seen-cache.c: Revert.
7223 * fbsd-tdep.c: Revert.
7224 * fbsd-nat.h: Revert.
7225 * fbsd-nat.c: Revert.
7226 * f-valprint.c: Revert.
7227 * f-typeprint.c: Revert.
7228 * f-lang.c: Revert.
7229 * extension.h: Revert.
7230 * extension.c: Revert.
7231 * extension-priv.h: Revert.
7232 * expprint.c: Revert.
7233 * exec.h: Revert.
7234 * exec.c: Revert.
7235 * exceptions.c: Revert.
7236 * event-top.c: Revert.
7237 * event-loop.c: Revert.
7238 * eval.c: Revert.
7239 * elfread.c: Revert.
7240 * dwarf2read.h: Revert.
7241 * dwarf2read.c: Revert.
7242 * dwarf2loc.c: Revert.
7243 * dwarf2expr.h: Revert.
7244 * dwarf2expr.c: Revert.
7245 * dwarf2-frame.c: Revert.
7246 * dwarf2-frame-tailcall.c: Revert.
7247 * dwarf-index-write.h: Revert.
7248 * dwarf-index-write.c: Revert.
7249 * dwarf-index-common.c: Revert.
7250 * dwarf-index-cache.h: Revert.
7251 * dwarf-index-cache.c: Revert.
7252 * dummy-frame.c: Revert.
7253 * dtrace-probe.c: Revert.
7254 * disasm.h: Revert.
7255 * disasm.c: Revert.
7256 * disasm-selftests.c: Revert.
7257 * dictionary.c: Revert.
7258 * dicos-tdep.c: Revert.
7259 * demangle.c: Revert.
7260 * dcache.h: Revert.
7261 * dcache.c: Revert.
7262 * darwin-nat.h: Revert.
7263 * darwin-nat.c: Revert.
7264 * darwin-nat-info.c: Revert.
7265 * d-valprint.c: Revert.
7266 * d-namespace.c: Revert.
7267 * d-lang.c: Revert.
7268 * ctf.c: Revert.
7269 * csky-tdep.c: Revert.
7270 * csky-linux-tdep.c: Revert.
7271 * cris-tdep.c: Revert.
7272 * cris-linux-tdep.c: Revert.
7273 * cp-valprint.c: Revert.
7274 * cp-support.c: Revert.
7275 * cp-namespace.c: Revert.
7276 * cp-abi.c: Revert.
7277 * corelow.c: Revert.
7278 * corefile.c: Revert.
7279 * continuations.c: Revert.
7280 * completer.h: Revert.
7281 * completer.c: Revert.
7282 * complaints.c: Revert.
7283 * coffread.c: Revert.
7284 * coff-pe-read.c: Revert.
7285 * cli-out.h: Revert.
7286 * cli-out.c: Revert.
7287 * charset.c: Revert.
7288 * c-varobj.c: Revert.
7289 * c-valprint.c: Revert.
7290 * c-typeprint.c: Revert.
7291 * c-lang.c: Revert.
7292 * buildsym.c: Revert.
7293 * buildsym-legacy.c: Revert.
7294 * build-id.h: Revert.
7295 * build-id.c: Revert.
7296 * btrace.c: Revert.
7297 * bsd-uthread.c: Revert.
7298 * breakpoint.h: Revert.
7299 * breakpoint.c: Revert.
7300 * break-catch-throw.c: Revert.
7301 * break-catch-syscall.c: Revert.
7302 * break-catch-sig.c: Revert.
7303 * blockframe.c: Revert.
7304 * block.c: Revert.
7305 * bfin-tdep.c: Revert.
7306 * bfin-linux-tdep.c: Revert.
7307 * bfd-target.c: Revert.
7308 * bcache.c: Revert.
7309 * ax-general.c: Revert.
7310 * ax-gdb.h: Revert.
7311 * ax-gdb.c: Revert.
7312 * avr-tdep.c: Revert.
7313 * auxv.c: Revert.
7314 * auto-load.c: Revert.
7315 * arm-wince-tdep.c: Revert.
7316 * arm-tdep.c: Revert.
7317 * arm-symbian-tdep.c: Revert.
7318 * arm-pikeos-tdep.c: Revert.
7319 * arm-obsd-tdep.c: Revert.
7320 * arm-nbsd-tdep.c: Revert.
7321 * arm-nbsd-nat.c: Revert.
7322 * arm-linux-tdep.c: Revert.
7323 * arm-linux-nat.c: Revert.
7324 * arm-fbsd-tdep.c: Revert.
7325 * arm-fbsd-nat.c: Revert.
7326 * arm-bsd-tdep.c: Revert.
7327 * arch-utils.c: Revert.
7328 * arc-tdep.c: Revert.
7329 * arc-newlib-tdep.c: Revert.
7330 * annotate.h: Revert.
7331 * annotate.c: Revert.
7332 * amd64-windows-tdep.c: Revert.
7333 * amd64-windows-nat.c: Revert.
7334 * amd64-tdep.c: Revert.
7335 * amd64-sol2-tdep.c: Revert.
7336 * amd64-obsd-tdep.c: Revert.
7337 * amd64-obsd-nat.c: Revert.
7338 * amd64-nbsd-tdep.c: Revert.
7339 * amd64-nbsd-nat.c: Revert.
7340 * amd64-nat.c: Revert.
7341 * amd64-linux-tdep.c: Revert.
7342 * amd64-linux-nat.c: Revert.
7343 * amd64-fbsd-tdep.c: Revert.
7344 * amd64-fbsd-nat.c: Revert.
7345 * amd64-dicos-tdep.c: Revert.
7346 * amd64-darwin-tdep.c: Revert.
7347 * amd64-bsd-nat.c: Revert.
7348 * alpha-tdep.c: Revert.
7349 * alpha-obsd-tdep.c: Revert.
7350 * alpha-nbsd-tdep.c: Revert.
7351 * alpha-mdebug-tdep.c: Revert.
7352 * alpha-linux-tdep.c: Revert.
7353 * alpha-linux-nat.c: Revert.
7354 * alpha-bsd-tdep.c: Revert.
7355 * alpha-bsd-nat.c: Revert.
7356 * aix-thread.c: Revert.
7357 * agent.c: Revert.
7358 * addrmap.c: Revert.
7359 * ada-varobj.c: Revert.
7360 * ada-valprint.c: Revert.
7361 * ada-typeprint.c: Revert.
7362 * ada-tasks.c: Revert.
7363 * ada-lang.c: Revert.
7364 * aarch64-tdep.c: Revert.
7365 * aarch64-ravenscar-thread.c: Revert.
7366 * aarch64-newlib-tdep.c: Revert.
7367 * aarch64-linux-tdep.c: Revert.
7368 * aarch64-linux-nat.c: Revert.
7369 * aarch64-fbsd-tdep.c: Revert.
7370 * aarch64-fbsd-nat.c: Revert.
7371 * aarch32-linux-nat.c: Revert.
7372
d55e5aa6
TT
73732019-04-05 Tom Tromey <tom@tromey.com>
7374
7375 * ft32-tdep.c: Sort headers.
7376 * frv-tdep.c: Sort headers.
7377 * frv-linux-tdep.c: Sort headers.
7378 * frame.c: Sort headers.
7379 * frame-unwind.c: Sort headers.
7380 * frame-base.c: Sort headers.
7381 * fork-child.c: Sort headers.
7382 * findvar.c: Sort headers.
7383 * findcmd.c: Sort headers.
7384 * filesystem.c: Sort headers.
7385 * filename-seen-cache.h: Sort headers.
7386 * filename-seen-cache.c: Sort headers.
7387 * fbsd-tdep.c: Sort headers.
7388 * fbsd-nat.h: Sort headers.
7389 * fbsd-nat.c: Sort headers.
7390 * f-valprint.c: Sort headers.
7391 * f-typeprint.c: Sort headers.
7392 * f-lang.c: Sort headers.
7393 * extension.h: Sort headers.
7394 * extension.c: Sort headers.
7395 * extension-priv.h: Sort headers.
7396 * expprint.c: Sort headers.
7397 * exec.h: Sort headers.
7398 * exec.c: Sort headers.
7399 * exceptions.c: Sort headers.
7400 * event-top.c: Sort headers.
7401 * event-loop.c: Sort headers.
7402 * eval.c: Sort headers.
7403 * elfread.c: Sort headers.
7404 * dwarf2read.h: Sort headers.
7405 * dwarf2read.c: Sort headers.
7406 * dwarf2loc.c: Sort headers.
7407 * dwarf2expr.h: Sort headers.
7408 * dwarf2expr.c: Sort headers.
7409 * dwarf2-frame.c: Sort headers.
7410 * dwarf2-frame-tailcall.c: Sort headers.
7411 * dwarf-index-write.h: Sort headers.
7412 * dwarf-index-write.c: Sort headers.
7413 * dwarf-index-common.c: Sort headers.
7414 * dwarf-index-cache.h: Sort headers.
7415 * dwarf-index-cache.c: Sort headers.
7416 * dummy-frame.c: Sort headers.
7417 * dtrace-probe.c: Sort headers.
7418 * disasm.h: Sort headers.
7419 * disasm.c: Sort headers.
7420 * disasm-selftests.c: Sort headers.
7421 * dictionary.c: Sort headers.
7422 * dicos-tdep.c: Sort headers.
7423 * demangle.c: Sort headers.
7424 * dcache.h: Sort headers.
7425 * dcache.c: Sort headers.
7426 * darwin-nat.h: Sort headers.
7427 * darwin-nat.c: Sort headers.
7428 * darwin-nat-info.c: Sort headers.
7429 * d-valprint.c: Sort headers.
7430 * d-namespace.c: Sort headers.
7431 * d-lang.c: Sort headers.
7432 * ctf.c: Sort headers.
7433 * csky-tdep.c: Sort headers.
7434 * csky-linux-tdep.c: Sort headers.
7435 * cris-tdep.c: Sort headers.
7436 * cris-linux-tdep.c: Sort headers.
7437 * cp-valprint.c: Sort headers.
7438 * cp-support.c: Sort headers.
7439 * cp-namespace.c: Sort headers.
7440 * cp-abi.c: Sort headers.
7441 * corelow.c: Sort headers.
7442 * corefile.c: Sort headers.
7443 * continuations.c: Sort headers.
7444 * completer.h: Sort headers.
7445 * completer.c: Sort headers.
7446 * complaints.c: Sort headers.
7447 * coffread.c: Sort headers.
7448 * coff-pe-read.c: Sort headers.
7449 * cli-out.h: Sort headers.
7450 * cli-out.c: Sort headers.
7451 * charset.c: Sort headers.
7452 * c-varobj.c: Sort headers.
7453 * c-valprint.c: Sort headers.
7454 * c-typeprint.c: Sort headers.
7455 * c-lang.c: Sort headers.
7456 * buildsym.c: Sort headers.
7457 * buildsym-legacy.c: Sort headers.
7458 * build-id.h: Sort headers.
7459 * build-id.c: Sort headers.
7460 * btrace.c: Sort headers.
7461 * bsd-uthread.c: Sort headers.
7462 * breakpoint.h: Sort headers.
7463 * breakpoint.c: Sort headers.
7464 * break-catch-throw.c: Sort headers.
7465 * break-catch-syscall.c: Sort headers.
7466 * break-catch-sig.c: Sort headers.
7467 * blockframe.c: Sort headers.
7468 * block.c: Sort headers.
7469 * bfin-tdep.c: Sort headers.
7470 * bfin-linux-tdep.c: Sort headers.
7471 * bfd-target.c: Sort headers.
7472 * bcache.c: Sort headers.
7473 * ax-general.c: Sort headers.
7474 * ax-gdb.h: Sort headers.
7475 * ax-gdb.c: Sort headers.
7476 * avr-tdep.c: Sort headers.
7477 * auxv.c: Sort headers.
7478 * auto-load.c: Sort headers.
7479 * arm-wince-tdep.c: Sort headers.
7480 * arm-tdep.c: Sort headers.
7481 * arm-symbian-tdep.c: Sort headers.
7482 * arm-pikeos-tdep.c: Sort headers.
7483 * arm-obsd-tdep.c: Sort headers.
7484 * arm-nbsd-tdep.c: Sort headers.
7485 * arm-nbsd-nat.c: Sort headers.
7486 * arm-linux-tdep.c: Sort headers.
7487 * arm-linux-nat.c: Sort headers.
7488 * arm-fbsd-tdep.c: Sort headers.
7489 * arm-fbsd-nat.c: Sort headers.
7490 * arm-bsd-tdep.c: Sort headers.
7491 * arch-utils.c: Sort headers.
7492 * arc-tdep.c: Sort headers.
7493 * arc-newlib-tdep.c: Sort headers.
7494 * annotate.h: Sort headers.
7495 * annotate.c: Sort headers.
7496 * amd64-windows-tdep.c: Sort headers.
7497 * amd64-windows-nat.c: Sort headers.
7498 * amd64-tdep.c: Sort headers.
7499 * amd64-sol2-tdep.c: Sort headers.
7500 * amd64-obsd-tdep.c: Sort headers.
7501 * amd64-obsd-nat.c: Sort headers.
7502 * amd64-nbsd-tdep.c: Sort headers.
7503 * amd64-nbsd-nat.c: Sort headers.
7504 * amd64-nat.c: Sort headers.
7505 * amd64-linux-tdep.c: Sort headers.
7506 * amd64-linux-nat.c: Sort headers.
7507 * amd64-fbsd-tdep.c: Sort headers.
7508 * amd64-fbsd-nat.c: Sort headers.
7509 * amd64-dicos-tdep.c: Sort headers.
7510 * amd64-darwin-tdep.c: Sort headers.
7511 * amd64-bsd-nat.c: Sort headers.
7512 * alpha-tdep.c: Sort headers.
7513 * alpha-obsd-tdep.c: Sort headers.
7514 * alpha-nbsd-tdep.c: Sort headers.
7515 * alpha-mdebug-tdep.c: Sort headers.
7516 * alpha-linux-tdep.c: Sort headers.
7517 * alpha-linux-nat.c: Sort headers.
7518 * alpha-bsd-tdep.c: Sort headers.
7519 * alpha-bsd-nat.c: Sort headers.
7520 * aix-thread.c: Sort headers.
7521 * agent.c: Sort headers.
7522 * addrmap.c: Sort headers.
7523 * ada-varobj.c: Sort headers.
7524 * ada-valprint.c: Sort headers.
7525 * ada-typeprint.c: Sort headers.
7526 * ada-tasks.c: Sort headers.
7527 * ada-lang.c: Sort headers.
7528 * aarch64-tdep.c: Sort headers.
7529 * aarch64-ravenscar-thread.c: Sort headers.
7530 * aarch64-newlib-tdep.c: Sort headers.
7531 * aarch64-linux-tdep.c: Sort headers.
7532 * aarch64-linux-nat.c: Sort headers.
7533 * aarch64-fbsd-tdep.c: Sort headers.
7534 * aarch64-fbsd-nat.c: Sort headers.
7535 * aarch32-linux-nat.c: Sort headers.
7536
699bd4cf
TT
75372019-04-04 Tom Tromey <tom@tromey.com>
7538
7539 * varobj.c (varobj_create): Update.
7540 * rust-exp.y (struct rust_parser) <update_innermost_block,
7541 lookup_symbol>: New methods.
7542 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7543 Rename.
7544 (rust_parser::rust_lookup_type)
7545 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7546 * printcmd.c (display_command, do_one_display): Update.
7547 * parser-defs.h (struct parser_state) <parser_state>: Add
7548 "tracker" parameter.
7549 (block_tracker): New member.
7550 (class innermost_block_tracker) <innermost_block_tracker>: Add
7551 "types" parameter.
7552 <reset>: Remove method.
7553 (innermost_block): Don't declare.
7554 (null_post_parser): Update.
7555 * parse.c (innermost_block): Remove global.
7556 (write_dollar_variable): Update.
7557 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7558 Remove "tracker_types" parameter.
7559 (parse_expression): Add "tracker" parameter.
7560 (parse_expression_for_completion): Update.
7561 (null_post_parser): Add "tracker" parameter.
7562 * p-exp.y: Update rules.
7563 * m2-exp.y: Update rules.
7564 * language.h (struct language_defn) <la_post_parser>: Add
7565 "tracker" parameter.
7566 * go-exp.y: Update rules.
7567 * f-exp.y: Update rules.
7568 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7569 parameter.
7570 * d-exp.y: Update rules.
7571 * c-exp.y: Update rules.
7572 * breakpoint.c (set_breakpoint_condition): Create an
7573 innermost_block_tracker.
7574 (watch_command_1): Likewise.
7575 * ada-lang.c (resolve): Add "tracker" parameter.
7576 (resolve_subexp): Likewise.
7577 * ada-exp.y (write_var_from_sym): Update.
7578
dac43e32
TT
75792019-04-04 Tom Tromey <tom@tromey.com>
7580
7581 * type-stack.h: New file.
7582 * type-stack.c: New file.
7583 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7584 type-stack.h.
7585 (insert_into_type_stack, insert_type, push_type, push_type_int)
7586 (insert_type_address_space, pop_type, pop_type_int)
7587 (pop_typelist, pop_type_stack, append_type_stack)
7588 (push_type_stack, get_type_stack, push_typelist)
7589 (follow_type_instance_flags, follow_types): Don't declare.
7590 * parse.c (type_stack): Remove global.
7591 (parse_exp_in_context): Update.
7592 (insert_into_type_stack, insert_type, push_type, push_type_int)
7593 (insert_type_address_space, pop_type, pop_type_int)
7594 (pop_typelist, pop_type_stack, append_type_stack)
7595 (push_type_stack, get_type_stack, push_typelist)
7596 (follow_type_instance_flags, follow_types): Remove (moved to
7597 type-stack.c).
7598 * f-exp.y (type_stack): New global.
7599 Update rules.
7600 (push_kind_type, f_parse): Update.
7601 * d-exp.y (type_stack): New global.
7602 Update rules.
7603 (d_parse): Update.
7604 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7605 Update rules.
7606 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7607 (HFILES_NO_SRCDIR): Add type-stack.h.
7608
2a612529
TT
76092019-04-04 Tom Tromey <tom@tromey.com>
7610
7611 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7612 (rust_parser::convert_ast_to_expression, rust_parse)
7613 (rust_lex_test_completion, rust_lex_tests): Update.
7614 * parser-defs.h (struct expr_completion_state): New.
7615 (struct parser_state) <parser_state>: Add completion parameter.
7616 <mark_struct_expression, mark_completion_tag>: New methods.
7617 <parse_completion, m_completion_state>: New members.
7618 (prefixify_expression, null_post_parser): Update.
7619 (mark_struct_expression, mark_completion_tag): Don't declare.
7620 * parse.c (parse_completion, expout_last_struct)
7621 (expout_tag_completion_type, expout_completion_name): Remove
7622 globals.
7623 (parser_state::mark_struct_expression)
7624 (parser_state::mark_completion_tag): Now methods.
7625 (prefixify_expression): Add last_struct parameter.
7626 (prefixify_subexp): Likewise.
7627 (parse_exp_1): Update.
7628 (parse_exp_in_context): Add cstate parameter. Update.
7629 (parse_expression_for_completion): Create an
7630 expr_completion_state.
7631 (null_post_parser): Add "completion" parameter.
7632 * p-exp.y: Update rules.
7633 (yylex): Update.
7634 * language.h (struct language_defn) <la_post_parser>: Add
7635 "completing" parameter.
7636 * go-exp.y: Update rules.
7637 (lex_one_token): Update.
7638 * expression.h (parse_completion): Don't declare.
7639 * d-exp.y: Update rules.
7640 (lex_one_token): Update rules.
7641 * c-exp.y: Update rules.
7642 (lex_one_token): Update.
7643 * ada-lang.c (resolve): Add "parse_completion" parameter.
7644 (resolve_subexp): Likewise.
7645 (ada_resolve_function): Likewise.
7646
43476f0b
TT
76472019-04-04 Tom Tromey <tom@tromey.com>
7648
7649 * parser-defs.h (struct parser_state) <start_arglist,
7650 end_arglist>: New methods.
7651 <arglist_len, m_funcall_chain>: New members.
7652 (arglist_len, start_arglist, end_arglist): Don't declare.
7653 * parse.c (arglist_len, funcall_chain): Remove global.
7654 (start_arglist, end_arglist): Remove functions.
7655 (parse_exp_in_context): Update.
7656 * p-exp.y: Update rules.
7657 * m2-exp.y: Update rules.
7658 * go-exp.y: Update rules.
7659 * f-exp.y: Update rules.
7660 * d-exp.y: Update rules.
7661 * c-exp.y: Update rules.
7662
5776fca3
TT
76632019-04-04 Tom Tromey <tom@tromey.com>
7664
7665 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7666 lex_operator, push_back>: New methods.
7667 Update all rules.
7668 (rust_parser::lex_hex, lex_escape): Rename and update.
7669 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7670 (rust_parser::lex_operator): Rename and update.
7671 (rust_parser::lex_number, rustyylex, rustyyerror)
7672 (rust_lex_test_init, rust_lex_test_sequence)
7673 (rust_lex_test_push_back, rust_lex_tests): Update.
7674 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7675 parameter.
7676 <lexptr, prev_lexptr>: New members.
7677 (lexptr, prev_lexptr): Don't declare.
7678 * parse.c (lexptr, prev_lexptr): Remove globals.
7679 (parse_exp_in_context): Update.
7680 * p-exp.y (yylex, yyerror): Update.
7681 * m2-exp.y (parse_number, yylex, yyerror): Update.
7682 * go-exp.y (lex_one_token, yyerror): Update.
7683 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7684 * d-exp.y (lex_one_token, yyerror): Update.
7685 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7686 (lex_one_token, yyerror): Update.
7687 * ada-lex.l (YY_INPUT): Update.
7688 (rewind_to_char): Update.
7689 * ada-exp.y (yyerror): Update.
7690
8621b685
TT
76912019-04-04 Tom Tromey <tom@tromey.com>
7692
7693 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7694 * parser-defs.h (struct parser_state) <parser_state>: Add new
7695 parameter.
7696 <comma_terminates>: New member.
7697 (comma_terminates): Don't declare global.
7698 * parse.c (comma_terminates): Remove global.
7699 (parse_exp_in_context): Update.
7700 * p-exp.y (yylex): Update.
7701 * m2-exp.y (yylex): Update.
7702 * go-exp.y (lex_one_token): Update.
7703 * f-exp.y (yylex): Update.
7704 * d-exp.y (lex_one_token): Update.
7705 * c-exp.y (lex_one_token): Update.
7706 * ada-lex.l: Update.
7707
28aaf3fd
TT
77082019-04-04 Tom Tromey <tom@tromey.com>
7709
7710 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7711 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7712 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7713 * parser-defs.h (paren_depth): Don't declare.
7714 * parse.c (paren_depth): Remove global.
7715 (parse_exp_in_context): Update.
7716 * p-exp.y (paren_depth): New global.
7717 (pascal_parse): Initialize it.
7718 * m2-exp.y (paren_depth): New global.
7719 (m2_parse): Initialize it.
7720 * go-exp.y (paren_depth): New global.
7721 (go_parse): Initialize it.
7722 * f-exp.y (paren_depth): New global.
7723 (f_parse): Initialize it.
7724 * d-exp.y (paren_depth): New global.
7725 (d_parse): Initialize it.
7726 * c-exp.y (paren_depth): New global.
7727 (c_parse): Initialize it.
7728 * ada-lex.l (paren_depth): New global.
7729 (lexer_init): Initialize it.
7730
1e58a4a4
TT
77312019-04-04 Tom Tromey <tom@tromey.com>
7732
7733 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7734 (rust_parser::convert_ast_to_type)
7735 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7736 * parser-defs.h (struct parser_state) <parser_state>: Add
7737 parameters. Initialize new members.
7738 <expression_context_block, expression_context_pc>: New members.
7739 * parse.c (expression_context_block, expression_context_pc):
7740 Remove globals.
7741 (parse_exp_in_context): Update.
7742 * p-exp.y: Update all rules.
7743 (yylex): Update.
7744 * m2-exp.y: Update all rules.
7745 (yylex): Update.
7746 * go-exp.y (yylex): Update.
7747 * f-exp.y (yylex): Update.
7748 * d-exp.y: Update all rules.
7749 (yylex): Update.
7750 * c-exp.y: Update all rules.
7751 (lex_one_token, classify_name, yylex, c_parse): Update.
7752 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7753
37eedb39
TT
77542019-04-04 Tom Tromey <tom@tromey.com>
7755
7756 * gdbarch.h, gdbarch.c: Rebuild.
7757 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7758 * stap-probe.h:
7759 (struct stap_parse_info): Replace "parser_state" with
7760 "expr_builder".
7761 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7762 (parser_state): New class.
7763 * parse.c (expr_builder): Rename.
7764 (expr_builder::release): Rename.
7765 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7766 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7767 (write_exp_elt_longcst, write_exp_elt_floatcst)
7768 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7769 (write_exp_string_vector, write_exp_bitstring)
7770 (write_exp_msymbol, mark_struct_expression)
7771 (write_dollar_variable)
7772 (insert_type_address_space, increase_expout_size): Replace
7773 "parser_state" with "expr_builder".
7774 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7775 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7776 "parser_state" with "expr_builder".
7777
73923d7e
TT
77782019-04-04 Tom Tromey <tom@tromey.com>
7779
7780 * rust-exp.y: Replace "parse_language" with method call.
7781 * p-exp.y:
7782 (yylex): Replace "parse_language" with method call.
7783 * m2-exp.y:
7784 (yylex): Replace "parse_language" with method call.
7785 * go-exp.y (classify_name): Replace "parse_language" with method
7786 call.
7787 * f-exp.y (yylex): Replace "parse_language" with method call.
7788 * d-exp.y (lex_one_token): Replace "parse_language" with method
7789 call.
7790 * c-exp.y:
7791 (lex_one_token, classify_name, yylex): Replace "parse_language"
7792 with method call.
7793 * ada-exp.y (find_primitive_type, type_char)
7794 (type_system_address): Replace "parse_language" with method call.
7795
fa9f5be6
TT
77962019-04-04 Tom Tromey <tom@tromey.com>
7797
7798 * rust-exp.y: Replace "parse_gdbarch" with method call.
7799 * parse.c (write_dollar_variable, insert_type_address_space):
7800 Replace "parse_gdbarch" with method call.
7801 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7802 call.
7803 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7804 call.
7805 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7806 "parse_gdbarch" with method call.
7807 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7808 with method call.
7809 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7810 "parse_gdbarch" with method call.
7811 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7812 "parse_gdbarch" with method call.
7813 * c-exp.y (parse_type, parse_number, classify_name): Replace
7814 "parse_gdbarch" with method call.
7815 * ada-lex.l: Replace "parse_gdbarch" with method call.
7816 * ada-exp.y (parse_type, find_primitive_type, type_char)
7817 (type_system_address): Replace "parse_gdbarch" with method call.
7818
1201a264
TT
78192019-04-04 Tom Tromey <tom@tromey.com>
7820
7821 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7822 * stap-probe.c (stap_parse_argument): Update.
7823 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7824 initial_size parameter.
7825 * rust-exp.y (rust_lex_tests): Update.
7826 * parse.c (parser_state): Update.
7827 (parse_exp_in_context): Update.
7828 * parser-defs.h (struct parser_state) <parser_state>: Remove
7829 "initial_size" parameter.
7830
e3980ce2
TT
78312019-04-04 Tom Tromey <tom@tromey.com>
7832
7833 * parser-defs.h (increase_expout_size): Don't declare.
7834 * parse.c (increase_expout_size): Now static.
7835
e9f8e3f1
TS
78362019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7837
7838 * gnu-nat.c (gnu_nat_target::wait): Fix
7839 target_waitstatus_to_string call.
7840
d7df6549
AB
78412019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7842
7843 * eval.c (evaluate_subexp_standard): Handle internal functions
7844 during Fortran function call handling.
7845
8bdc1658
AB
78462019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7847
7848 * NEWS: Mention new internal functions.
7849 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7850 (read_base_type): Use dwarf2_init_complex_target_type.
7851 * value.c (creal_internal_fn): New function.
7852 (cimag_internal_fn): New function.
7853 (_initialize_values): Register new internal functions.
7854
c29705b7
PW
78552019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7856
7857 * infrun.c (stop_all_threads): If debug_infrun, always
7858 trace the wait status after wait_one, using
7859 target_waitstatus_to_string and target_pid_to_str.
7860 (handle_inferior_event): Replace various trace of
7861 wait status kind by a single trace.
7862 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7863 wait status kind image by target_waitstatus_to_string.
7864 * target/waitstatus.c (target_waitstatus_to_string): Fix
7865 obsolete comment.
7866
05caa1d2
TT
78672019-04-01 Tom Tromey <tromey@adacore.com>
7868
7869 PR symtab/23331:
7870 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7871
9d1447e0
SDJ
78722019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7873 Pedro Alves <palves@redhat.com>
7874
7875 * top.c (quit_force): Call 'finalize_values'.
7876 * value.c (finalize_values): New function.
7877 * value.h (finalize_values): Declare.
7878
7734102d
EZ
78792019-03-30 Eli Zaretskii <eliz@gnu.org>
7880
7881 * NEWS: Announce $_gdb_major and $_gdb_minor.
7882
7883 * top.c (init_gdb_version_vars): New function.
7884 (gdb_init): Call init_gdb_version_vars.
7885
188e1fa9
TT
78862019-03-29 Tom Tromey <tromey@adacore.com>
7887
7888 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7889 help text. Remove dead code.
7890
2880242d
KS
78912019-03-29 Keith Seitz <keiths@redhat.com>
7892
7893 From Siddhesh Poyarekar:
7894 * f-lang.h (f77_get_upperbound): Return LONGEST.
7895 (f77_get_lowerbound): Likewise.
7896 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7897 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7898 print them.
7899 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7900 plongest to format print it.
7901 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7902 (f77_get_upperbound): Likewise.
7903 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7904 LOWER_BOUND to LONGEST.
7905 (f77_create_arrayprint_offset_tbl): Likewise.
7906
cc1defb1
KS
79072019-03-29 Keith Seitz <keiths@redhat.com>
7908
7909 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7910 %s/pulongest for TYPE_LENGTH instead of %d in format
7911 strings.
7912 * ada-typerint.c (ada_print_type): Likewise.
7913 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7914 * compile/compile-c-support.c (generate_register_struct): Likewise.
7915 * gdbtypes.c (recursive_dump_type): Likewise.
7916 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7917 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7918 instead of %d in format strings.
7919 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7920 to std::min to ULONGEST.
7921 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7922 instead of %d in format strings.
7923 * tracepoint.c (info_scope_command): Likewise.
7924 * typeprint.c (print_offset_data::update)
7925 (print_offset_data::finish): Likewise.
7926 * xtensa-tdep.c (xtensa_store_return_value)
7927 (xtensa_push_dummy_call): Likewise.
7928
e432ccf1
JT
79292019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7930
7931 * windows-nat.c (display_selector): Fixed format specifications
7932 for 64-bit Cygwin.
7933
65d2b333
PW
79342019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7935
7936 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7937
f489207e
SL
79382019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7939
7940 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7941 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7942 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7943 (nios2_linux_init_abi): Install it.
7944
bffa1015
AH
79452019-03-28 Alan Hayward <alan.hayward@arm.com>
7946
7947 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7948
fc96163a
AH
79492019-03-28 Alan Hayward <alan.hayward@arm.com>
7950
7951 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7952
20dc7e9b
PW
79532019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7954 Tom Tromey <tromey@adacore.com>
7955
7956 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7957
7f5331a8
JB
79582019-03-26 Joel Brobecker <brobecker@adacore.com>
7959
7960 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7961 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7962 method to compute the bounds of range types. Also print "[evaluated]"
7963 if the bounds' values come from a dynamic evaluation.
7964
18c77628
AB
79652019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7966
7967 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7968 whitespace when pretty printing is on.
7969
53c973f2
AH
79702019-03-26 Alan Hayward <alan.hayward@arm.com>
7971
e79be6e5 7972 * ppc-linux-nat.c: Add include.
53c973f2 7973
d851aa71
AH
79742019-03-26 Alan Hayward <alan.hayward@arm.com>
7975
e79be6e5 7976 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7977
2fe7bab7
AH
79782019-03-26 Alan Hayward <alan.hayward@arm.com>
7979
e79be6e5 7980 * arm-linux-nat.c: Add include.
2fe7bab7 7981
068ef30e
SM
79822019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7983
7984 * source-cache.c (source_cache::get_source_lines): Re-read
7985 fullname after calling open_source_file.
7986
81a24d04
JB
79872019-03-25 John Baldwin <jhb@FreeBSD.org>
7988
7989 * NEWS: Mention TLS support for FreeBSD.
7990
79e7ae11
TT
79912019-03-25 Tom Tromey <tromey@adacore.com>
7992
7993 * minsyms.c (BUNCH_SIZE): Update comment.
7994 (~minimal_symbol_reader): Remove old comment.
7995 (compact_minimal_symbols): Update comment.
7996 (minimal_symbol_reader::install): Remove old comment. Update
7997 other comments.
7998
d45963c2
AH
79992019-03-25 Alan Hayward <alan.hayward@arm.com>
8000
8001 * s390-linux-nat.c: Add include.
8002
0f83012e
AH
80032019-03-25 Alan Hayward <alan.hayward@arm.com>
8004
8005 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8006 Call linux_get_hwcap.
8007 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8008 Likewise.
8009 (aarch64_linux_get_hwcap): Remove function.
8010 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8011 declaration.
8012 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8013 linux_get_hwcap.
8014 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8015 * linux-tdep.c (linux_get_hwcap): Add function.
8016 (linux_get_hwcap2): Likewise.
8017 * linux-tdep.h (linux_get_hwcap): Add declaration.
8018 (linux_get_hwcap2): Likewise.
8019 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8020 (ppc_linux_get_hwcap2): Likewise.
8021 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8022 linux_get_hwcap.
8023 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8024 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8025 (ppc_linux_nat_target::read_description): Likewise.
8026 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8027 * s390-linux-nat.c: Likewise.
8028 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8029
6640a367
TT
80302019-03-24 Tom Tromey <tom@tromey.com>
8031
8032 * ada-lang.c (standard_lookup): Simplify initialization.
8033 (ada_lookup_symbol_nonlocal): Simplify return.
8034 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8035 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8036 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8037 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8038 initialization.
8039 * solib.c (solib_global_lookup): Simplify.
8040 * symtab.c (null_block_symbol): Remove.
8041 (symbol_cache_lookup): Simplify returns.
8042 (lookup_language_this): Simplify returns.
8043 (lookup_symbol_aux): Simplify return.
8044 (lookup_local_symbol): Simplify returns.
8045 (lookup_global_symbol_from_objfile): Simplify return.
8046 (lookup_symbol_in_objfile_symtabs)
8047 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8048 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8049 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8050 * cp-namespace.c (cp_lookup_bare_symbol)
8051 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8052 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8053 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8054 (cp_lookup_symbol_via_imports): Simplify initialization.
8055 (find_symbol_in_baseclass): Likewise.
8056 * symtab.h (null_block_symbol): Remove.
8057 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8058 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8059 (d_lookup_symbol_module): Likewise.
8060 (find_symbol_in_baseclass): Simplify initialization.
8061
a930ebcd
TT
80622019-03-24 Tom Tromey <tom@tromey.com>
8063
8064 * expression.h: Don't include symtab.h.
8065 (struct block): Forward declare.
8066
582942f4
TT
80672019-03-24 Tom Tromey <tom@tromey.com>
8068
8069 * c-exp.y (typebase): Remove casts.
8070 * gdbtypes.c (lookup_unsigned_typename, )
8071 (lookup_signed_typename): Remove cast.
8072 * eval.c (parse_to_comma_and_eval): Remove cast.
8073 * parse.c (write_dollar_variable): Remove cast.
8074 * block.h (struct block) <superblock>: Now const.
8075 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8076 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8077 (map_block): Make "block" const.
8078 * symfile.h (struct quick_symbol_functions)
8079 <map_matching_symbols>: Constify block argument to "callback".
8080 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8081 const.
8082 (find_pc_sect_compunit_symtab): Make "b" const.
8083 (find_symbol_at_address): Likewise.
8084 (search_symbols): Likewise.
8085 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8086 (dw2_debug_names_lookup_symbol): Likewise.
8087 (dw2_map_matching_symbols): Update.
8088 * p-valprint.c (pascal_val_print): Remove "block".
8089 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8090 (aux_add_nonlocal_symbols): Make "block" const.
8091 (resolve_subexp): Remove cast.
8092 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8093 const.
8094 (iterate_over_file_blocks): Likewise.
8095 * f-exp.y (%union) <bval>: Remove.
8096 * coffread.c (patch_opaque_types): Make "b" const.
8097 * spu-tdep.c (spu_catch_start): Make "block" const.
8098 * c-valprint.c (print_unpacked_pointer): Remove "block".
8099 * symmisc.c (dump_symtab_1): Make "b" const.
8100 (block_depth): Make "block" const.
8101 * d-exp.y (%union) <bval>: Remove.
8102 * cp-support.h (cp_lookup_rtti_type): Update.
8103 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8104 * psymtab.c (psym_lookup_symbol): Make "block" const.
8105 (maintenance_check_psymtabs): Make "b" const.
8106 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8107 (enumerate_locals, enumerate_args): Update.
8108 * python/py-symtab.c (stpy_global_block): Make "block" const.
8109 (stpy_static_block): Likewise.
8110 * inline-frame.c (block_starting_point_at): Make "new_block"
8111 const.
8112 * block.c (find_block_in_blockvector): Make return type const.
8113 (blockvector_for_pc_sect): Make "b" const.
8114 (find_block_in_blockvector): Make "b" const.
8115
7ad417dd
TT
81162019-03-23 Tom Tromey <tom@tromey.com>
8117
8118 * varobj.c (varobj_create): Update.
8119 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8120 * printcmd.c (display_command, do_one_display): Don't reset
8121 innermost_block.
8122 * parser-defs.h (enum innermost_block_tracker_type): Move to
8123 expression.h.
8124 (innermost_block): Update comment.
8125 * parse.c (parse_exp_1): Add tracker_types parameter.
8126 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8127 tracker_types parameter. Reset innermost_block.
8128 (parse_exp_in_context): Remove.
8129 (parse_expression_for_completion): Update.
8130 * objfiles.c (~objfile): Don't reset expression_context_block or
8131 innermost_block.
8132 * expression.h (enum innermost_block_tracker_type): Move from
8133 parser-defs.h.
8134 (parse_exp_1): Add tracker_types parameter.
8135 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8136 reset innermost_block.
8137
b366c208
TT
81382019-03-23 Tom Tromey <tom@tromey.com>
8139
8140 * objfiles.h: Include bcache.h.
8141
9bb9b2f9
TT
81422019-03-23 Tom Tromey <tom@tromey.com>
8143
8144 * linespec.c (get_current_search_block): Use
8145 scoped_restore_current_language.
8146 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8147
59c28372
AH
81482019-03-22 Alan Hayward <alan.hayward@arm.com>
8149 Jiong Wang <jiong.wang@arm.com>
8150
8151 * aarch64-linux-tdep.c
8152 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8153 section.
8154 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8155
17e116a7
AH
81562019-03-22 Alan Hayward <alan.hayward@arm.com>
8157 Jiong Wang <jiong.wang@arm.com>
8158
8159 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8160 instructions.
8161 (aarch64_analyze_prologue_test): Add PACIASP test.
8162 (aarch64_prologue_prev_register): Unmask PC value.
8163
11e1b75f
AH
81642019-03-22 Alan Hayward <alan.hayward@arm.com>
8165 Jiong Wang <jiong.wang@arm.com>
8166
8167 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8168 (aarch64_dwarf2_prev_register): Unmask PC value.
8169 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8170 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8171 DW_CFA_AARCH64_negate_ra_state.
8172 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8173
34dcc7cf
AH
81742019-03-22 Alan Hayward <alan.hayward@arm.com>
8175 Jiong Wang <jiong.wang@arm.com>
8176
8177 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8178 registers.
8179 (aarch64_pseudo_register_name): Likewise.
8180 (aarch64_pseudo_register_type): Likewise.
8181 (aarch64_pseudo_register_reggroup_p): Likewise.
8182 (aarch64_gdbarch_init): Add pauth registers.
8183 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8184 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8185 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8186 (struct gdbarch_tdep): Add regnum for ra_state.
8187
1ef53e6b
AH
81882019-03-22 Alan Hayward <alan.hayward@arm.com>
8189 Jiong Wang <jiong.wang@arm.com>
8190
8191 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8192
76bed0fd
AH
81932019-03-22 Alan Hayward <alan.hayward@arm.com>
8194 Jiong Wang <jiong.wang@arm.com>
8195
8196 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8197 function.
8198 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8199 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8200 (aarch64_gdbarch_init): Add puth registers.
8201 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8202 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8203 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8204
ee4fbcfa
AH
82052019-03-22 Alan Hayward <alan.hayward@arm.com>
8206 Jiong Wang <jiong.wang@arm.com>
8207
8208 * aarch64-linux-nat.c
8209 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8210 * aarch64-linux-tdep.c
8211 (aarch64_linux_core_read_description): Likewise.
8212 (aarch64_linux_get_hwcap): New function.
8213 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8214 (aarch64_linux_get_hwcap): New declaration.
8215
6dc0ebde
AH
82162019-03-22 Alan Hayward <alan.hayward@arm.com>
8217 Jiong Wang <jiong.wang@arm.com>
8218
8219 * aarch64-linux-nat.c
8220 (aarch64_linux_nat_target::read_description): Add pauth param.
8221 * aarch64-linux-tdep.c
8222 (aarch64_linux_core_read_description): Likewise.
8223 * aarch64-tdep.c (struct target_desc): Add in pauth.
8224 (aarch64_read_description): Add pauth param.
8225 (aarch64_gdbarch_init): Likewise.
8226 * aarch64-tdep.h (aarch64_read_description): Likewise.
8227 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8228 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8229 * features/Makefile: Add new files.
8230 * features/aarch64-pauth.c: New file.
8231 * features/aarch64-pauth.xml: New file.
8232
595915c1
TT
82332019-03-20 Tom Tromey <tromey@adacore.com>
8234
8235 * infrun.c (handle_inferior_event): Rename from
8236 handle_inferior_event_1. Create a scoped_value_mark.
8237 (handle_inferior_event): Remove.
8238
4c7d57e7
TT
82392019-03-19 Tom Tromey <tromey@adacore.com>
8240
8241 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8242 * infrun.h (print_stop_event): Add "displays" parameter.
8243 * infrun.c (print_stop_event): Add "displays" parameter.
8244
cb246234
PA
82452019-03-19 Pedro Alves <palves@redhat.com>
8246
8247 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8248 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8249 to -1. Fix TABs vs spaces.
8250 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8251 * tui/tui-out.h (tui_ui_out) Add intro comments.
8252 <m_line, m_start_of_line>: In-class initialize, and add describing
8253 comment.
8254
3a0e45b2
AH
82552019-03-18 Alan Hayward <alan.hayward@arm.com>
8256
8257 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8258 variable names.
8259 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8260
5371b850
PA
82612019-03-18 Pedro Alves <palves@redhat.com>
8262 Eli Zaretskii <eliz@gnu.org>
8263
8264 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8265 m_line and m_start_of_line.
8266
b17c4cd0
EZ
82672019-03-18 Eli Zaretskii <eliz@gnu.org>
8268
8269 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8270 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8271 it returns a newline. This fixes a regression in TU mode, whereby
8272 the next line is output on the same screen line as the user input.
8273
4bd56d18
TT
82742019-03-18 Tom Tromey <tromey@adacore.com>
8275
8276 * minsyms.c (minimal_symbol_reader::install): Remove call to
8277 obstack_blank.
8278
55c10aca
PA
82792019-03-18 Pedro Alves <palves@redhat.com>
8280
8281 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8282 New globals.
8283 (apply_style): New, factored out from ...
8284 (apply_ansi_escape): ... this. Handle reverse video mode.
8285 (tui_set_reverse_mode): New function.
8286 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8287 * tui/tui-winsource.c (tui_show_source_line): Use
8288 tui_set_reverse_mode instead of setting A_STANDOUT.
8289 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8290 New setter methods.
8291
647bb750
HD
82922019-03-18 Hannes Domani <ssbssa@yahoo.de>
8293
8294 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8295 Handle tabs.
8296
bff8c71f
TT
82972019-03-18 Tom Tromey <tromey@adacore.com>
8298
8299 * ada-lang.c (empty_array): Add "high" parameter.
8300 (ada_evaluate_subexp): Update.
8301
58785d98
ST
83022019-03-17 Sergei Trofimovich <siarheit@google.com>
8303
8304 * unittests/string_view-selftests.c: Define
8305 _initialize_string_view_selftests unconditionally.
8306
d4cbef22
ВМ
83072019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8308
8309 PR gdb/24350
8310 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8311
fce4c071
ВМ
83122019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8313
8314 PR gdb/24351
8315 * windows-nat.c (display_selector): Fix format specifiers.
8316
f7f0a123
EZ
83172019-03-17 Eli Zaretskii <eliz@gnu.org>
8318
8319 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8320 tui_refill_source_window instead of tui_refresh_win, to update the
8321 current execution line. This fixes redisplay of the current line
8322 when stepping through the code with "next" or "step".
8323
ab42892f
EZ
83242019-03-16 Eli Zaretskii <eliz@gnu.org>
8325
8326 * source-cache.c (source_cache::get_source_lines): Call
8327 find_source_lines to initialize s->nlines. This fixes vertical
8328 scrolling of TUI source window when the DOWN arrow is pressed.
8329
8d8c087f
PW
83302019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8331
8332 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8333 linux-thread-db.c (_initialize_thread_db): Likewise.
8334
798e1c30
EZ
83352019-03-16 Eli Zaretskii <eliz@gnu.org>
8336
8337 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8338 wclrtoeol in tui_show_source_line". This reverts changes made in
8339 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8340
eefba3da
TT
83412019-03-15 Tom Tromey <tom@tromey.com>
8342
8343 * symtab.h (struct minimal_symbol): Derive from
8344 general_symbol_info.
8345 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8346 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8347 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8348 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8349 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8350 (MSYMBOL_SEARCH_NAME): Update.
8351 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8352 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8353 * minsyms.c (minimal_symbol_reader::record_full): Update.
8354
0de2420c
TT
83552019-03-15 Tom Tromey <tom@tromey.com>
8356
8357 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8358
042d75e4
TT
83592019-03-15 Tom Tromey <tom@tromey.com>
8360
8361 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8362 unique_xmalloc_ptr.
8363 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8364 Update.
8365 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8366 (build_minimal_symbol_hash_tables)
8367 (minimal_symbol_reader::install): Update.
8368
db92718b
TT
83692019-03-15 Tom Tromey <tom@tromey.com>
8370
8371 * symtab.c (create_demangled_names_hash): Update.
8372 (symbol_set_names): Update.
8373 * objfiles.h (struct objfile_per_bfd_storage)
8374 <demangled_names_hash>: Now an htab_up.
8375 * objfiles.c (objfile_per_bfd_storage): Simplify.
8376
d6797f46
TT
83772019-03-15 Tom Tromey <tom@tromey.com>
8378
8379 * objfiles.h (struct objfile_per_bfd_storage): Declare
8380 destructor.
8381 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8382 New.
8383 (get_objfile_bfd_data): Use new. Don't initialize
8384 language_of_main.
8385 (free_objfile_per_bfd_storage): Remove.
8386 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8387
741d7538
TT
83882019-03-15 Tom Tromey <tom@tromey.com>
8389
8390 * symfile.c (reread_symbols): Update.
8391 * objfiles.c (objfile::objfile): Update.
8392 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8393 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8394 comment.
8395 (minimal_symbol_reader::install): Update.
8396 (terminate_minimal_symbol_table): Remove.
8397 * jit.c (jit_object_close_impl): Update.
8398
788c80d1
TT
83992019-03-15 Tom Tromey <tom@tromey.com>
8400
8401 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8402 initializations.
8403
1b7a07cb
TT
84042019-03-15 Tom Tromey <tom@tromey.com>
8405
8406 * objfiles.h (struct objfile_per_bfd_storage)
8407 <demangled_hash_languages>: Now a bitset.
8408 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8409 (lookup_minimal_symbol): Update.
8410
3db066bc
TT
84112019-03-15 Tom Tromey <tom@tromey.com>
8412
8413 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8414 Don't return the symbol.
8415 * coffread.c (record_minimal_symbol): Use record_full.
8416
3fff2c37
EZ
84172019-03-14 Eli Zaretskii <eliz@gnu.org>
8418
8419 The MS-Windows port of ncurses fails to switch to a color pair if
8420 one or both of the colors are the implicit default colors. This
8421 change records the default colors when TUI is initialized, and
8422 then specifies them explicitly when a color pair uses the default
8423 colors. This allows color styling in TUI mode on MS-Windows.
8424
8425 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8426 ncurses_norm_attr.
8427 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8428 colors in ncurses_norm_attr.
8429 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8430 "none", replace it with the default color recorded in
8431 ncurses_norm_attr.
8432
3b336828
TT
84332019-03-14 Tom Tromey <tromey@adacore.com>
8434
8435 * source-cache.h (class source_cache) <get_source_lines>: Return
8436 std::string.
8437 * source-cache.c (source_cache::extract_lines): Handle case where
8438 first_pos==npos. Return std::string.
8439 (source_cache::get_source_lines): Update.
8440
d085f989
TT
84412019-03-14 Tom Tromey <tromey@adacore.com>
8442
8443 * NEWS: Add item for "style sources" commands.
8444 * source-cache.c (source_cache::get_source_lines): Check
8445 source_styling.
8446 * cli/cli-style.c (source_styling): New global.
8447 (_initialize_cli_style): Add "style sources" commands.
8448 (show_style_sources): New function.
8449 * cli/cli-style.h (source_styling): Declare.
8450
6f11e682
TT
84512019-03-14 Pedro Alves <palves@redhat.com>
8452 Tom Tromey <tromey@adacore.com>
8453
8454 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8455 * tui/tui-winsource.c (tui_refill_source_window): New function,
8456 from...
8457 (tui_horizontal_source_scroll): ... here. Move some logic.
8458 * cli/cli-style.c (set_style_enabled): Notify new observable.
8459 * tui/tui-hooks.c (tui_redisplay_source): New function.
8460 (tui_attach_detach_observers): Attach or detach
8461 tui_redisplay_source.
8462 * observable.h (source_styling_changed): New observable.
8463 * observable.c: Define source_styling_changed observable.
8464
a068643d
TT
84652019-03-13 Tom Tromey <tromey@adacore.com>
8466
8467 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8468 (i386_gnu_nat_target::store_registers): Update.
8469 * target-debug.h (target_debug_print_std_string): New macro.
8470 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8471 * windows-tdep.c (display_one_tib): Update.
8472 * tui/tui-stack.c (tui_make_status_line): Update.
8473 * top.c (print_inferior_quit_action): Update.
8474 * thread.c (thr_try_catch_cmd): Update.
8475 (add_thread_with_info): Update.
8476 (thread_target_id_str): Update.
8477 (thr_try_catch_cmd): Update.
8478 (thread_command): Update.
8479 (thread_find_command): Update.
8480 * record-btrace.c (record_btrace_target::info_record)
8481 (record_btrace_resume_thread, record_btrace_target::resume)
8482 (record_btrace_cancel_resume, record_btrace_step_thread)
8483 (record_btrace_target::wait, record_btrace_target::wait)
8484 (record_btrace_target::wait, record_btrace_target::stop): Update.
8485 * progspace.c (print_program_space): Update.
8486 * process-stratum-target.c
8487 (process_stratum_target::thread_address_space): Update.
8488 * linux-fork.c (linux_fork_mourn_inferior)
8489 (detach_checkpoint_command, info_checkpoints_command)
8490 (linux_fork_context): Update.
8491 (linux_fork_detach): Update.
8492 (class scoped_switch_fork_info): Update.
8493 (delete_checkpoint_command): Update.
8494 * infrun.c (follow_fork_inferior): Update.
8495 (follow_fork_inferior): Update.
8496 (proceed_after_vfork_done): Update.
8497 (handle_vfork_child_exec_or_exit): Update.
8498 (follow_exec): Update.
8499 (displaced_step_prepare_throw): Update.
8500 (displaced_step_restore): Update.
8501 (start_step_over): Update.
8502 (resume_1): Update.
8503 (clear_proceed_status_thread): Update.
8504 (proceed): Update.
8505 (print_target_wait_results): Update.
8506 (do_target_wait): Update.
8507 (context_switch): Update.
8508 (stop_all_threads): Update.
8509 (restart_threads): Update.
8510 (finish_step_over): Update.
8511 (handle_signal_stop): Update.
8512 (switch_back_to_stepped_thread): Update.
8513 (keep_going_pass_signal): Update.
8514 (print_exited_reason): Update.
8515 (normal_stop): Update.
8516 * inferior.c (inferior_pid_to_str): Change return type.
8517 (print_selected_inferior): Update.
8518 (add_inferior): Update.
8519 (detach_inferior): Update.
8520 * dummy-frame.c (fprint_dummy_frames): Update.
8521 * dcache.c (dcache_info_1): Update.
8522 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8523 (btrace_fetch, btrace_clear): Update.
8524 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8525 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8526 type.
8527 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8528 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8529 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8530 * gdbarch.c, gdbarch.h: Rebuild.
8531 * gdbarch.sh (core_pid_to_str): Change return type.
8532 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8533 return type.
8534 (windows_nat_target::pid_to_str): Change return type.
8535 (windows_delete_thread): Update.
8536 (windows_nat_target::attach): Update.
8537 (windows_nat_target::files_info): Update.
8538 * target-delegates.c: Rebuild.
8539 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8540 return type.
8541 (sol_thread_target::pid_to_str): Change return type.
8542 * remote.c (class remote_target) <pid_to_str>: Change return
8543 type.
8544 (remote_target::pid_to_str): Change return type.
8545 (extended_remote_target::attach, remote_target::remote_stop_ns)
8546 (remote_target::remote_notif_remove_queued_reply)
8547 (remote_target::push_stop_reply, remote_target::disable_btrace):
8548 Update.
8549 (extended_remote_target::attach): Update.
8550 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8551 type.
8552 (gdbsim_target::pid_to_str): Change return type.
8553 * ravenscar-thread.c (struct ravenscar_thread_target)
8554 <pid_to_str>: Change return type.
8555 (ravenscar_thread_target::pid_to_str): Change return type.
8556 * procfs.c (class procfs_target) <pid_to_str>: Change return
8557 type.
8558 (procfs_target::pid_to_str): Change return type.
8559 (procfs_target::attach): Update.
8560 (procfs_target::detach): Update.
8561 (procfs_target::fetch_registers): Update.
8562 (procfs_target::store_registers): Update.
8563 (procfs_target::wait): Update.
8564 (procfs_target::files_info): Update.
8565 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8566 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8567 return type.
8568 (nto_procfs_target::pid_to_str): Change return type.
8569 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8570 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8571 return type.
8572 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8573 (exit_lwp): Update.
8574 (attach_proc_task_lwp_callback, get_detach_signal)
8575 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8576 (linux_nat_target::resume, wait_lwp, stop_callback)
8577 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8578 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8579 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8580 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8581 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8582 type.
8583 (inf_ptrace_target::attach): Update.
8584 (inf_ptrace_target::files_info): Update.
8585 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8586 type.
8587 (go32_nat_target::pid_to_str): Change return type.
8588 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8589 (gnu_nat_target::wait): Update.
8590 (gnu_nat_target::wait): Update.
8591 (gnu_nat_target::resume): Update.
8592 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8593 (fbsd_nat_target::wait): Update.
8594 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8595 type.
8596 (darwin_nat_target::attach): Update.
8597 * corelow.c (class core_target) <pid_to_str>: Change return type.
8598 (core_target::pid_to_str): Change return type.
8599 * target.c (normal_pid_to_str): Change return type.
8600 (default_pid_to_str): Likewise.
8601 (target_pid_to_str): Change return type.
8602 (target_translate_tls_address): Update.
8603 (target_announce_detach): Update.
8604 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8605 return type.
8606 (bsd_uthread_target::pid_to_str): Change return type.
8607 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8608 type.
8609 (bsd_kvm_target::pid_to_str): Change return type.
8610 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8611 return type.
8612 (aix_thread_target::pid_to_str): Change return type.
8613 * target.h (struct target_ops) <pid_to_str>: Change return type.
8614 (target_pid_to_str, normal_pid_to_str): Likewise.
8615 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8616 type.
8617 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8618 type.
8619 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8620 return type.
8621 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8622 type.
8623 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8624 type.
8625 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8626 return type.
8627
b4be1b06
SM
86282019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8629
8630 * NEWS: Mention that the new default MI version is 3. Mention
8631 changes to the output of commands and events that deal with
8632 multi-location breakpoints.
8633 * breakpoint.c: Include "mi/mi-out.h".
8634 (print_one_breakpoint): Change output syntax if using MI version
8635 >= 3.
8636 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8637 New.
8638 (mi_multi_location_breakpoint_output_fixed): New.
8639 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8640 (mi_cmd_fix_multi_location_breakpoint_output): New.
8641 (mi_multi_location_breakpoint_output_fixed): New.
8642 * mi/mi-cmds.c (mi_cmds): Register command
8643 -fix-multi-location-breakpoint-output.
8644 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8645 interpreter "mi".
8646
8e5e5494
SM
86472019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8648
8649 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8650 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8651 instantiate mi_ui_out based on interpreter name.
8652 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8653 * mi/mi-main.c (mi_load_progress): Likewise.
8654
197df35e
JB
86552019-03-12 John Baldwin <jhb@FreeBSD.org>
8656
8657 * NEWS: Combine separate "New targets" sections for 8.3.
8658
8399425f
JB
86592019-03-12 John Baldwin <jhb@FreeBSD.org>
8660
8661 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8662 (ppcfbsd_init_abi): Install gdbarch
8663 "fetch_tls_load_module_address" and "get_thread_local_address"
8664 methods.
8665
b0f87ed0
JB
86662019-03-12 John Baldwin <jhb@FreeBSD.org>
8667
8668 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8669 (riscv_fbsd_init_abi): Install gdbarch
8670 "fetch_tls_load_module_address" and "get_thread_local_address"
8671 methods.
8672
ce25aa57
JB
86732019-03-12 John Baldwin <jhb@FreeBSD.org>
8674
8675 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8676 (i386fbsd_init_abi): Install gdbarch
8677 "fetch_tls_load_module_address" and "get_thread_local_address"
8678 methods.
8679
f5424cfa
JB
86802019-03-12 John Baldwin <jhb@FreeBSD.org>
8681
8682 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8683 (amd64fbsd_init_abi): Install gdbarch
8684 "fetch_tls_load_module_address" and "get_thread_local_address"
8685 methods.
8686
945f3901
JB
86872019-03-12 John Baldwin <jhb@FreeBSD.org>
8688
8689 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8690 (struct fbsd_pspace_data): New type.
8691 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8692 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8693 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8694 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8695 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8696
ef0bd204
JB
86972019-03-12 John Baldwin <jhb@FreeBSD.org>
8698
8699 * gdbtypes.c (lookup_struct_elt): New function.
8700 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8701 * gdbtypes.h (struct struct_elt): New type.
8702 (lookup_struct_elt): New prototype.
8703
36c53a02
JB
87042019-03-12 John Baldwin <jhb@FreeBSD.org>
8705
8706 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8707 remove disabled code block.
8708
6e056c81
JB
87092019-03-12 John Baldwin <jhb@FreeBSD.org>
8710
8711 * gdbarch.sh (get_thread_local_address): New method.
8712 * gdbarch.h, gdbarch.c: Regenerate.
8713 * target.c (target_translate_tls_address): Use
8714 gdbarch_get_thread_local_address if present instead of
8715 target::get_thread_local_address.
8716
cd250a18
JB
87172019-03-12 John Baldwin <jhb@FreeBSD.org>
8718
8719 * target.h (target::get_thread_local_address): Update comment.
8720
df22c1e5
JB
87212019-03-12 John Baldwin <jhb@FreeBSD.org>
8722
8723 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8724 objfile->separate_debug_objfile_backlink if not NULL.
8725
dd6876c9
JB
87262019-03-12 John Baldwin <jhb@FreeBSD.org>
8727
8728 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8729 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8730 (amd64bsd_store_inferior_registers): Likewise.
8731 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8732 Enable segment base registers.
8733 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8734 PT_GETFSBASE and PT_GETGSBASE.
8735 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8736 PT_SETGSBASE.
8737 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8738 segment base registers.
8739 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8740
1163a4b7
JB
87412019-03-12 John Baldwin <jhb@FreeBSD.org>
8742
8743 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8744 Update calls to i386_target_description to add 'segments'
8745 parameter.
8746 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8747 add segment base registers.
8748 * arch/i386.c (i386_create_target_description): Add 'segments'
8749 parameter to enable segment base registers.
8750 * arch/i386.h (i386_create_target_description): Likewise.
8751 * features/i386/32bit-segments.xml: New file.
8752 * features/i386/32bit-segments.c: Generate.
8753 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8754 call to i386_target_description to add 'segments' parameter.
8755 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8756 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8757 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8758 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8759 if feature is present.
8760 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8761 Add 'segments' parameter to call to i386_target_description.
8762 (i386_target_description): Add 'segments' parameter to enable
8763 segment base registers.
8764 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8765 to call to i386_target_description.
8766 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8767 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8768 Define I386_NUM_REGS.
8769 (i386_target_description): Add 'segments' parameter to enable
8770 segment base registers.
8771
3a350822
EZ
87722019-03-12 Eli Zaretskii <eliz@gnu.org>
8773
8774 PR/24325
8775 * source-cache.c: #undef open and close, to avoid unresolved
8776 externals during linking.
8777
ffdd69cf
TT
87782019-03-12 Tom Tromey <tromey@adacore.com>
8779
8780 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8781 const. Add initializers.
8782 (_initialize_remote): Don't initialize ptid globals.
8783
ec148c57
PA
87842019-03-12 Pedro Alves <palves@redhat.com>
8785
8786 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8787
32764270
PA
87882019-03-12 Pedro Alves <palves@redhat.com>
8789
8790 * cp-name-parser.y (main): Remove unused 'len' variable.
8791
17547186
TT
87922019-03-12 Tom Tromey <tromey@adacore.com>
8793
8794 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8795 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8796
d3a70e03
TT
87972019-03-12 Tom Tromey <tromey@adacore.com>
8798
8799 * linux-nat.c (iterate_over_lwps): Update.
8800 (stop_callback): Remove parameter.
8801 (stop_wait_callback, detach_callback, resume_set_callback)
8802 (select_singlestep_lwp_callback, set_ignore_sigint)
8803 (status_callback, resumed_callback, resume_clear_callback)
8804 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8805 data parameter.
8806 (linux_nat_target::detach, linux_nat_target::resume)
8807 (linux_stop_and_wait_all_lwps, select_event_lwp)
8808 (linux_nat_filter_event, linux_nat_wait_1)
8809 (linux_nat_target::kill, linux_nat_target::stop)
8810 (linux_nat_target::stop): Update.
8811 (linux_nat_resume_callback): Change type.
8812 (resume_stopped_resumed_lwps, count_events_callback)
8813 (select_event_lwp_callback): Likewise.
8814 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8815 * arm-linux-nat.c (struct update_registers_data): Remove.
8816 (update_registers_callback): Change type.
8817 (arm_linux_insert_hw_breakpoint1): Update.
8818 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8819 parameter.
8820 (x86_linux_dr_set_addr): Update.
8821 (x86_linux_dr_set_control): Update.
8822 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8823 (iterate_over_lwps): Use gdb::function_view.
8824 * nat/aarch64-linux-hw-point.c (struct
8825 aarch64_dr_update_callback_param): Remove.
8826 (debug_reg_change_callback): Change type.
8827 (aarch64_notify_debug_reg_change): Update.
8828 * s390-linux-nat.c (s390_refresh_per_info): Update.
8829
82cb27ff
TT
88302019-03-11 Tom Tromey <tromey@adacore.com>
8831
8832 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8833 redundant assignment to "this_cu".
8834
568c0683
SM
88352019-03-08 Simon Marchi <simon.marchi@efficios.com>
8836
8837 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8838
f09ce22d
SM
88392019-03-08 Simon Marchi <simon.marchi@efficios.com>
8840
8841 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8842 from...
8843 (rank_one_type): ... this.
8844
595f96a9
SM
88452019-03-08 Simon Marchi <simon.marchi@efficios.com>
8846
8847 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8848 from...
8849 (rank_one_type): ... this.
8850
2598a94b
SM
88512019-03-08 Simon Marchi <simon.marchi@efficios.com>
8852
8853 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8854 from...
8855 (rank_one_type): ... this.
8856
7f17b20d
SM
88572019-03-08 Simon Marchi <simon.marchi@efficios.com>
8858
8859 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8860 from...
8861 (rank_one_type): ... this.
8862
2c509035
SM
88632019-03-08 Simon Marchi <simon.marchi@efficios.com>
8864
8865 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8866 from...
8867 (rank_one_type): ... this.
8868
0dd322dc
SM
88692019-03-08 Simon Marchi <simon.marchi@efficios.com>
8870
8871 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8872 from...
8873 (rank_one_type): ... this.
8874
41ea4728
SM
88752019-03-08 Simon Marchi <simon.marchi@efficios.com>
8876
8877 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8878 from...
8879 (rank_one_type): ... this.
8880
793cd1d2
SM
88812019-03-08 Simon Marchi <simon.marchi@efficios.com>
8882
8883 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8884 from...
8885 (rank_one_type): ... this.
8886
34910087
SM
88872019-03-08 Simon Marchi <simon.marchi@efficios.com>
8888
8889 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8890 from...
8891 (rank_one_type): ... this.
8892
f1f832d6
SM
88932019-03-08 Simon Marchi <simon.marchi@efficios.com>
8894
8895 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8896 from...
8897 (rank_one_type): ... this.
8898
b9f4512f
SM
88992019-03-08 Simon Marchi <simon.marchi@efficios.com>
8900
8901 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8902 from...
8903 (rank_one_type): ... this.
8904
9293fc63
SM
89052019-03-08 Simon Marchi <simon.marchi@efficios.com>
8906
8907 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8908 from...
8909 (rank_one_type): ... this.
8910
e3abbe7e
PW
89112019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8912
8913 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8914 inferior-events' shows the example events.
8915
e4adb939
EZ
89162019-03-08 Eli Zaretskii <eliz@gnu.org>
8917
8918 Support styling on native MS-Windows console
8919
8920 PR/24315
8921 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8922 on MS-Windows if $TERM is not defined.
8923
8924 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8925
8926 * posix-hdep.c (gdb_console_fputs):
8927 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8928 functions.
8929 * ui-file.h (gdb_console_fputs): Add prototype.
8930
8931 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8932 back to fputs only if the former returns zero.
8933
25629dfd
TT
89342019-03-07 Tom Tromey <tom@tromey.com>
8935
8936 * symmisc.c (print_symbol_bcache_statistics): Update.
8937 (print_objfile_statistics): Update.
8938 * symfile.c (allocate_symtab): Update.
8939 * stabsread.c: Don't include bcache.h.
8940 * psymtab.h (struct psymbol_bcache): Don't declare.
8941 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8942 (psymbol_bcache_init, psymbol_bcache_free)
8943 (psymbol_bcache_get_bcache): Don't declare.
8944 * psymtab.c (struct psymbol_bcache): Remove.
8945 (psymtab_storage::psymtab_storage): Update.
8946 (psymtab_storage::~psymtab_storage): Update.
8947 (psymbol_bcache_init, psymbol_bcache_free)
8948 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8949 (add_psymbol_to_bcache): Update.
8950 (allocate_psymtab): Update.
8951 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8952 macro_cache>: No longer pointers.
8953 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8954 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8955 * macrotab.c (macro_bcache): Update.
8956 * macroexp.c: Don't include bcache.h.
8957 * gdbtypes.c (check_types_worklist): Update.
8958 (types_deeply_equal): Remove TRY/CATCH. Update.
8959 * elfread.c (elf_symtab_read): Update.
8960 * dwarf2read.c: Don't include bcache.h.
8961 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8962 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8963 (print_bcache_statistics, bcache_memory_used): Don't declare.
8964 (struct bcache): Move from bcache.c. Add constructor, destructor,
8965 methods. Rename all data members.
8966 * bcache.c (struct bcache): Move to bcache.h.
8967 (bcache::expand_hash_table): Rename from expand_hash_table.
8968 (bcache): Remove.
8969 (bcache::insert): Rename from bcache_full.
8970 (bcache::compare): Rename from bcache_compare.
8971 (bcache_xmalloc): Remove.
8972 (bcache::~bcache): Rename from bcache_xfree.
8973 (bcache::print_statistics): Rename from print_bcache_statistics.
8974 (bcache::memory_used): Rename from bcache_memory_used.
8975
fe726667
PA
89762019-03-07 Pedro Alves <palves@redhat.com>
8977
8978 * infrun.c (normal_stop): Also check for
8979 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8980
7584bb30
AB
89812019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8982
8983 * f-lang.c (value_from_host_double): Moved to...
8984 * value.c (value_from_host_double): ...here.
8985 * value.h (value_from_host_double): Declare.
8986 * guile/scm-math.c (vlscm_convert_typed_number): Use
8987 value_from_host_double.
8988 (vlscm_convert_number): Likewise.
8989 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8990 * python/py-value.c (convert_value_from_python): Likewise.
8991
a7b1986e
TT
89922019-03-06 Tom Tromey <tom@tromey.com>
8993
8994 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8995
0ccf4211
TT
89962019-03-06 Tom Tromey <tom@tromey.com>
8997
8998 * utils.h (free_current_contents): Don't declare.
8999 * utils.c (free_current_contents): Remove.
9000
fe7b42e5
TT
90012019-03-06 Tom Tromey <tom@tromey.com>
9002
9003 * top.c (quit_force): Update.
9004 * main.c (captured_command_loop): Update.
9005 * common/new-op.c (operator new): Update.
9006 * common/common-exceptions.c (struct catcher)
9007 <save_cleanup_chain>: Remove member.
9008 (exceptions_state_mc_init): Update.
9009 (exception_try_scope_entry): Return nullptr.
9010 (exception_try_scope_exit, exception_rethrow)
9011 (throw_exception_sjlj, throw_exception_cxx): Update.
9012 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9013 (all_cleanups, do_cleanups, discard_cleanups)
9014 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9015 (restore_cleanups, restore_final_cleanups): Don't declare.
9016 (do_final_cleanups): Remove parameter.
9017 * common/cleanups.c (cleanup_chain, make_cleanup)
9018 (make_cleanup_dtor, all_cleanups, do_cleanups)
9019 (discard_my_cleanups, discard_cleanups)
9020 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9021 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9022 (null_cleanup): Remove.
9023 (do_final_cleanups): Remove parameter.
9024
c6321f19
TT
90252019-03-06 Tom Tromey <tom@tromey.com>
9026
9027 * remote.c (remote_target::remote_parse_stop_reply): Use
9028 unique_xmalloc_ptr.
9029
61b30099
TT
90302019-03-06 Tom Tromey <tom@tromey.com>
9031
9032 * stabsread.c (struct stabs_field_info): Rename from field_info.
9033 <list, fnlist>: Add initializers.
9034 <obstack>: New member.
9035 (read_member_functions, read_struct_fields, read_baseclasses):
9036 Allocate on obstack. Don't use cleanups.
9037 (read_one_struct_field, read_member_functions, read_struct_fields)
9038 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9039 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9040 (read_struct_type): Update.
9041
6cceac94
TT
90422019-03-06 Tom Tromey <tom@tromey.com>
9043
9044 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9045 * common/filestuff.h (make_cleanup_close): Don't declare.
9046 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9047 Remove.
9048
72412762
TT
90492019-03-06 Tom Tromey <tom@tromey.com>
9050
9051 * solib-aix.c: Use make_scope_exit.
9052
2b6ff1c0
TT
90532019-03-06 Tom Tromey <tom@tromey.com>
9054
9055 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9056 Use make_scope_exit.
9057
d01c5877
TT
90582019-03-06 Tom Tromey <tom@tromey.com>
9059
9060 * solib-svr4.c (disable_probes_interface): Remove parameter.
9061 (svr4_handle_solib_event): Use make_scope_exit.
9062
32603266
TT
90632019-03-06 Tom Tromey <tom@tromey.com>
9064
9065 * remote.c (struct stop_reply_deleter): Remove.
9066 (stop_reply_up): Update.
9067 (struct stop_reply): Derive from notif_event. Don't typedef.
9068 <regcache>: Now a std::vector.
9069 (stop_reply_xfree): Remove.
9070 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9071 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9072 (remote_target::discard_pending_stop_replies): Use delete.
9073 (remote_target::remote_parse_stop_reply): Update.
9074 (remote_target::process_stop_reply): Update.
9075 * remote-notif.h (struct notif_event): Add virtual destructor.
9076 Remove "dtr" member.
9077 (struct notif_client) <alloc_event>: Return a unique_ptr.
9078 (notif_event_xfree): Don't declare.
9079 (notif_event_up): New typedef.
9080 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9081 (notif_event_xfree, do_notif_event_xfree): Remove.
9082 (remote_notif_state_xfree): Update.
9083
9799571e
TT
90842019-03-06 Tom Tromey <tom@tromey.com>
9085
9086 * infrun.c (displaced_step_clear_cleanup): Now a
9087 forward_scope_exit type.
9088 (displaced_step_prepare_throw): Update.
9089 (displaced_step_fixup): Update.
9090
09e3c4ca
TT
90912019-03-06 Tom Tromey <tom@tromey.com>
9092
9093 * inferior.h (class inferior): Update comment.
9094 * gdbthread.h (class thread_info): Update comment.
9095
e2a03548
TT
90962019-03-06 Joel Brobecker <brobecker@adacore.com>
9097 Tom Tromey <tom@tromey.com>
9098
9099 * stabsread.h (struct stab_section_list): Remove.
9100 (coffstab_build_psymtabs): Update.
9101 * dbxread.c (symbuf_sections): Now a std::vector.
9102 (sect_idx): New global.
9103 (fill_symbuf): Update.
9104 (coffstab_build_psymtabs): Change type of stabsects parameter.
9105 Update.
9106 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9107 std::vector.
9108 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9109 (coff_locate_sections): Update.
9110 (coff_symfile_read): Remove cleanups. Update.
9111 (init_stringtab): Add storage parameter.
9112 (free_stringtab, free_stringtab_cleanup): Remove.
9113 (init_lineno): Add storage parameter.
9114 (free_linetab, free_linetab_cleanup): Remove.
9115
b7e60d85
PA
91162019-03-06 Pedro Alves <palves@redhat.com>
9117
9118 * linux-fork.c (fork_info::clobber_regs): Delete.
9119 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9120 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9121 comment. Adjust.
9122 (scoped_switch_fork_info::scoped_switch_fork_info)
9123 (checkpoint_command, linux_fork_context): Adjust
9124 fork_save_infrun_state calls.
9125
e52c971f
PA
91262019-03-06 Pedro Alves <palves@redhat.com>
9127
9128 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9129 (inf_has_multiple_threads): Return 'bool' and rewrite using
9130 inferior_info::threads().
9131
06974e6c
PA
91322019-03-06 Pedro Alves <palves@redhat.com>
9133
9134 * linux-fork.c: Include <list>.
9135 (fork_list): Now a std::list instance.
9136 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9137 (forks_exist_p, find_last_fork): Adjust.
9138 (new_fork): Delete.
9139 (one_fork_p): New.
9140 (add_fork): Adjust.
9141 (free_fork): Delete, folded into fork_info::~fork_info().
9142 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9143 Adjust.
9144 (init_fork_list): Delete.
9145 (linux_fork_killall, linux_fork_mourn_inferior)
9146 (linux_fork_detach, info_checkpoints_command): Adjust.
9147 (_initialize_linux_fork): No longer call init_fork_list.
9148
72f31aea
PA
91492019-03-06 Pedro Alves <palves@redhat.com>
9150
9151 * linux-fork.c (new_fork): New, split out of ...
9152 (add_fork): ... this. Return void. Move "first fork" special
9153 case from here, to ...
9154 (checkpoint_command): ... here.
9155 * linux-linux.h (add_fork): Return void.
9156
efbecbc1
AB
91572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9158
9159 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9160
0841c79a
AB
91612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9162 Chris January <chris.january@arm.com>
9163 David Lecomber <david.lecomber@arm.com>
9164
9165 * f-exp.y: New token, UNOP_INTRINSIC.
9166 (exp): New pattern using UNOP_INTRINSIC token.
9167 (f77_keywords): Add 'abs' keyword.
9168 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9169 (value_from_host_double): New function.
9170 (evaluate_subexp_f): Support UNOP_ABS.
9171
4a270568
AB
91722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9173
9174 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9175 types.
9176
067630bd
AB
91772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9178
9179 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9180 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9181 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9182
3be47f7a
AB
91832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9184
9185 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9186
4d00f5d8
AB
91872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9188 Chris January <chris.january@arm.com>
9189
9190 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9191 * f-exp.y: Define 'KIND' token.
9192 (exp): New pattern for KIND expressions.
9193 (ptype): Handle types with a kind extension.
9194 (direct_abs_decl): Extend to spot kind extensions.
9195 (f77_keywords): Add 'kind' to the list.
9196 (push_kind_type): New function.
9197 (convert_to_kind_type): New function.
9198 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9199 * parse.c (operator_length_standard): Likewise.
9200 * parser-defs.h (enum type_pieces): Add tp_kind.
9201 * std-operator.def: Add UNOP_KIND.
9202
e454224f
AB
92032019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9204
9205 * f-exp.y (f_parse): Set yydebug.
9206
9dad4a58
AB
92072019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9208
9209 * f-lang.c (evaluate_subexp_f): New function.
9210 (exp_descriptor_f): New global.
9211 (f_language_defn): Use exp_descriptor_f instead of
9212 exp_descriptor_standard.
9213
c8f91604
AB
92142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9215
9216 * f-exp.y (struct token): Add comments.
9217 (dot_ops): Remove uppercase versions and the end marker.
9218 (f77_keywords): Likewise.
9219 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9220 entries in the dot_ops array are case insensitive, and use
9221 strncasecmp to compare strings. Also some whitespace cleanup in
9222 this area. Similar for the f77_keywords array, except entries in
9223 this list might be case sensitive.
9224
dd9f2c76
AB
92252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9226
9227 * f-exp.y (struct f77_boolean_val): Add comments.
9228 (boolean_values): Remove uppercase versions, and end marker.
9229 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9230 and use strncasecmp to achieve case insensitivity. Additionally,
9231 perform whitespace cleanup around this code.
9232
67a3048c
TT
92332019-03-06 Tom Tromey <tromey@adacore.com>
9234
9235 * remote-sim.c (gdbsim_target_open): Use result of
9236 gdb_argv::release.
9237
aa3cfbda
RB
92382019-03-06 Richard Bunt <richard.bunt@arm.com>
9239 Dirk Schubert <dirk.schubert@arm.com>
9240 Chris January <chris.january@arm.com>
9241
9242 * eval.c (evaluate_subexp_standard): Call Fortran argument
9243 wrapping logic.
9244 * f-lang.c (struct value): A value which can be passed into a
9245 Fortran function call.
9246 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9247 where appropriate.
9248 (struct type): Value ready for a Fortran function call.
9249 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9250 is needed.
9251 * f-lang.h (fortran_argument_convert): Declaration.
9252 (fortran_preserve_arg_pointer): Declaration.
9253 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9254
ea38e5df
TT
92552019-03-05 Tom Tromey <tromey@adacore.com>
9256
9257 * python/py-prettyprint.c (print_string_repr): Remove #if.
9258 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9259
06b5b831
TT
92602019-03-05 Tom Tromey <tromey@adacore.com>
9261
9262 * target.c (the_dummy_target): Move later. Change type to
9263 "dummy_target".
9264 (initialize_targets): Don't initialize the_dummy_target.
9265
edbd9e45
TT
92662019-03-05 Tom Tromey <tromey@adacore.com>
9267
9268 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9269 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9270
c119e040
TT
92712019-03-05 Tom Tromey <tromey@adacore.com>
9272
9273 * windows-nat.c (windows_nat_target::attach)
9274 (windows_nat_target::detach): Don't call gdb_flush.
9275 * valprint.c (generic_val_print, val_print, val_print_string):
9276 Don't call gdb_flush.
9277 * utils.c (defaulted_query): Don't call gdb_flush.
9278 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9279 * target.c (target_announce_detach): Don't call gdb_flush.
9280 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9281 * remote.c (extended_remote_target::attach): Don't call
9282 gdb_flush.
9283 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9284 * printcmd.c (do_examine): Don't call gdb_flush.
9285 (info_display_command): Don't call gdb_flush.
9286 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9287 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9288 * memattr.c (info_mem_command): Don't call gdb_flush.
9289 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9290 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9291 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9292 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9293 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9294 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9295 (gnu_nat_target::detach): Don't call gdb_flush.
9296 * f-valprint.c (f_val_print): Don't call gdb_flush.
9297 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9298 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9299 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9300 gdb_flush.
9301 * c-valprint.c (c_val_print): Don't call gdb_flush.
9302 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9303
895dafa6
TT
93042019-03-05 Tom Tromey <tromey@adacore.com>
9305
9306 * varobj.c (update_dynamic_varobj_children): Update.
9307 (install_default_visualizer): Use reset, not release.
9308 * value.c (set_internalvar): Update.
9309 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9310 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9311 ATTRIBUTE_UNUSED_RESULT.
9312
88a774b9
TT
93132019-03-05 Tom Tromey <tromey@adacore.com>
9314
9315 * remote.c (class scoped_remote_fd) <release>: Add
9316 ATTRIBUTE_UNUSED_RESULT.
9317
4e4a8b93
TT
93182019-03-05 Tom Tromey <tromey@adacore.com>
9319
9320 * macroexp.c (struct macro_buffer) <release>: Add
9321 ATTRIBUTE_UNUSED_RESULT.
9322
083eef1f
TT
93232019-03-05 Tom Tromey <tromey@adacore.com>
9324
9325 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9326 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9327 ATTRIBUTE_UNUSED_RESULT.
9328
3cabd438
TT
93292019-03-05 Tom Tromey <tromey@adacore.com>
9330
9331 * common/scoped_fd.h (class scoped_fd) <release>: Add
9332 ATTRIBUTE_UNUSED_RESULT.
9333
41e3300a
TT
93342019-03-05 Tom Tromey <tromey@adacore.com>
9335
9336 * parser-defs.h (struct parser_state) <release>: Add
9337 ATTRIBUTE_UNUSED_RESULT.
9338
18cb7c9f
TT
93392019-03-05 Tom Tromey <tromey@adacore.com>
9340
9341 * utils.h (class gdb_argv) <release>: Add
9342 ATTRIBUTE_UNUSED_RESULT.
9343 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9344
41fa577f
EZ
93452019-03-02 Eli Zaretskii <eliz@gnu.org>
9346
a6a4b2c6
EZ
9347 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9348 for-loop range, to avoid compiler warnings.
9349
9350 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9351 avoid compiler warnings about unused variables.
9352
742a7df5
EZ
9353 * NEWS: Mention end of support for native debugging on MS-Windows
9354 before XP.
9355
41fa577f
EZ
9356 PR gdb/24292
9357 * common/netstuff.c:
9358 * gdbserver/gdbreplay.c
9359 * gdbserver/remote-utils.c:
9360 * ser-tcp.c:
9361 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9362 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9363 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9364 'getaddrinfo' and 'freeaddrinfo' were not available before
9365 Windows XP, and mingw.org's MinGW headers by default define
9366 _WIN32_WINNT to 0x500.
9367
827f438f
GB
93682019-03-01 Gary Benson <gbenson@redhat.com>
9369
9370 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9371
92137da0
RO
93722019-02-28 Brian Vandenberg <phantall@gmail.com>
9373 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9374
9375 PR gdb/8527
9376 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9377 set_sigint_trap, clear_sigint_trap.
9378
799efbe8
PW
93792019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9380
9381 * target.c (target_detach): Clear the regcache and the
9382 frame cache.
9383
8ed25214
PA
93842019-02-27 Pedro Alves <palves@redhat.com>
9385
9386 * utils.c (set_screen_size): When we cap the height/width sizes,
9387 tweak the corresponding command variable to show "unlimited":
9388
23031e31
SJ
93892019-02-27 Saagar Jha <saagar@saagarjha.com>
9390 Pedro Alves <palves@redhat.com>
9391
9392 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9393 before calling rl_set_screen_size.
9394
6c28e44a
TT
93952019-02-27 Tom Tromey <tromey@adacore.com>
9396
9397 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9398 define.
9399 * python/py-value.c: Remove Python 2.4 workaround.
9400 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9401 workaround.
9402 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9403 Python 2.4 workaround.
9404 * python/python-internal.h: Remove Python 2.4 comment.
9405 (Py_ssize_t): Don't define.
9406 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9407 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9408 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9409 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9410 * python/python.c (do_start_initialization): Remove Python 2.4
9411 workaround.
9412 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9413 (print_children): Remove Python 2.4 workaround.
9414 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9415 workaround.
9416 (CHARBUFFERPROC_NAME): Remove.
9417 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9418 Python 2.4 workaround.
9419
2c3fc25d 94202019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9421
2c3fc25d
KB
9422 * NEWS: Note minimum Python version.
9423
6ca62222
KB
94242019-02-27 Kevin Buettner <kevinb@redhat.com>
9425
9426 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9427 code from these functions. Remove corresponding ifdefs. Use
9428 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9429 Remove gotos and target of gotos.
9430 (infpy_search_memory): Likewise.
9431
f4bc7d2c
AB
94322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9433
9434 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9435 (hppa_gdbarch_init): Don't register deleted functions with
9436 gdbarch.
9437
9734a586
AB
94382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9439
9440 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9441 (h8300_unwind_sp): Delete.
9442 (h8300_dummy_id): Delete.
9443 (h8300_gdbarch_init): Don't register deleted functions with
9444 gdbarch.
9445
68b867f3
AB
94462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9447
9448 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9449 (ft32_unwind_pc): Delete.
9450 (ft32_unwind_sp): Delete.
9451 (ft32_gdbarch_init): Don't register deleted functions with
9452 gdbarch.
9453
2fbe7ad0
AB
94542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9455
9456 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9457 (frv_unwind_pc): Delete.
9458 (frv_unwind_sp): Delete.
9459 (frv_gdbarch_init): Don't register deleted functions with
9460 gdbarch.
9461
76055cbe
AB
94622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9463
9464 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9465 (riscv_unwind_pc): Delete.
9466 (riscv_unwind_sp): Delete.
9467 (riscv_gdbarch_init): Don't register deleted functions with
9468 gdbarch.
9469
4133e5a1
AB
94702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9471
9472 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9473 (csky_unwind_pc): Delete.
9474 (csky_unwind_sp): Delete.
9475 (csky_gdbarch_init): Don't register deleted functions with
9476 gdbarch.
9477
8010f576
AB
94782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9479
9480 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9481 (cris_unwind_pc): Delete.
9482 (cris_unwind_sp): Delete.
9483 (cris_gdbarch_init): Don't register deleted functions with
9484 gdbarch.
9485
b56bf084
AB
94862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9487
9488 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9489 (bfin_unwind_pc): Delete.
9490 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9491
a19a650f
AB
94922019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9493
9494 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9495 (arm_unwind_pc): Delete.
9496 (arm_unwind_sp): Delete.
9497 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9498
f8278c3c
AB
94992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9500
9501 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9502 (arc_unwind_pc): Delete.
9503 (arc_unwind_sp): Delete.
9504 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9505
480e46cf
AB
95062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9507
9508 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9509 (alpha_unwind_pc): Delete.
9510 (alpha_gdbarch_init): Don't register deleted functions with
9511 gdbarch.
9512
7a995095
AB
95132019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9514
9515 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9516 (aarch64_unwind_pc): Delete.
9517 (aarch64_unwind_sp): Delete.
9518 (aarch64_gdbarch_init): Don't register deleted functions with
9519 gdbarch.
9520
bf9a735e
AB
95212019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9522
9523 * gdbtypes.c (type_align): Don't consider static members when
9524 computing structure alignment.
9525
5561fc30
AB
95262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9527
9528 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9529 return 0 for other types.
9530 * arch-utils.c (default_type_align): Always return 0.
9531 * gdbarch.h: Regenerate.
9532 * gdbarch.sh (type_align): Extend comment.
9533 * gdbtypes.c (type_align): Add additional comments, always call
9534 gdbarch_type_align before applying the default rules.
9535 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9536 generic code will then apply a suitable default.
9537 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9538 types, return 0 for other types.
9539
9335e75a
JB
95402019-02-27 Joel Brobecker <brobecker@adacore.com>
9541
9542 * NEWS: Create a new section for the next release branch.
9543 Rename the section of the current branch, now that it has
9544 been cut.
9545
3d34d8de
JB
95462019-02-27 Joel Brobecker <brobecker@adacore.com>
9547
9548 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9549 * version.in: Bump version to 8.3.50.DATE-git.
9550
143420fb
SM
95512019-02-26 Simon Marchi <simon.marchi@efficios.com>
9552
9553 * aix-thread.c (ptid_cmp): Remove unused variable.
9554 (get_signaled_thread): Likewise.
9555 (store_regs_user_thread): Likewise.
9556 (store_regs_kernel_thread): Likewise.
9557 (fetch_regs_kernel_thread): Remove shadowed variable.
9558
172fb711
AB
95592019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9560
9561 * features/riscv/32bit-cpu.xml: Add register numbers.
9562 * features/riscv/32bit-fpu.c: Regenerate.
9563 * features/riscv/32bit-fpu.xml: Add register numbers.
9564 * features/riscv/64bit-cpu.xml: Add register numbers.
9565 * features/riscv/64bit-fpu.c: Regenerate.
9566 * features/riscv/64bit-fpu.xml: Add register numbers.
9567
26c89782
KB
95682019-02-26 Kevin Buettner <kevinb@redhat.com>
9569
af54ade9 9570 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9571 * python/py-value.c (convert_buffer_and_type_to_value): New
9572 function.
9573 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9574 Add support for handling an optional second argument. Call
9575 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9576 * python/python-internal.h (Py_buffer_deleter): New struct.
9577 (Py_buffer_up): New typedef.
9578
0f58c9e8
JB
95792019-02-25 John Baldwin <jhb@FreeBSD.org>
9580
9581 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9582 instead of releasing ownership.
9583
0a0f4c01
JR
95842019-02-25 Jordan Rupprecht <rupprecht@google.com>
9585
9586 * dwarf2read.c (open_and_init_dwp_file): Call
9587 elf_numsections instead of bfd_count_sections to initialize
9588 dwp_file->num_sections.
9589
cd5a152c
TT
95902019-02-25 Tom Tromey <tromey@adacore.com>
9591
9592 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9593
8a6a8513
SDJ
95942019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9595
9596 * gcore.in: Add '--readnever' option when invoking GDB.
9597
04dcda9c
SM
95982019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9599
9600 * MAINTAINERS: Update my email address.
9601
07bc701d
SM
96022019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9603
9604 * build-id.c (build_id_to_debug_bfd_1): New function.
9605 (build_id_to_debug_bfd): Look for separate debug file in
9606 sysroot.
9607
c6f4a5d0
AB
96082019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9609
9610 * gdbarch.sh: Update the copyright year range that is placed into
9611 generated files.
9612
9600246d
KS
96132019-02-22 Keith Seitz <keiths@redhat.com>
9614
9615 PR symtab/23853
9616 * linespec.c (create_sals_line_offset): Search for the default
9617 symtab's filename instead of its fullname.
9618
7557a514
AH
96192019-02-21 Alan Hayward <alan.hayward@arm.com>
9620
9621 * NEWS: Update style defaults.
9622
ee2bcb0c
AH
96232019-02-21 Alan Hayward <alan.hayward@arm.com>
9624
9625 * main.c (captured_main_1): Disable styling in batch mode.
9626
0c95f9ed
TT
96272019-02-20 Tom Tromey <tom@tromey.com>
9628
9629 * symtab.c (symtab_symbol_info): Fix typos.
9630
c763b894
TT
96312019-02-20 Tom Tromey <tromey@adacore.com>
9632
9633 * findcmd.c (_initialize_mem_search): Use upper case for
9634 metasyntactic variables.
9635
0ef8a082
AH
96362019-02-20 Alan Hayward <alan.hayward@arm.com>
9637
9638 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9639 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9640
6caa91b6
SM
96412019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9642
9643 * top.h (source_file_name): Change to std::string.
9644 * top.c (source_file_name): Likewise.
9645 (command_line_input): Adjust.
9646 * cli/cli-script.c (script_from_file): Adjust.
9647
98814c6c
TT
96482019-02-19 Tom Tromey <tromey@adacore.com>
9649
9650 * ravenscar-thread.c
9651 (ravenscar_thread_target::update_thread_list): Don't call
9652 ada_build_task_list.
9653 * ada-lang.h (ada_build_task_list): Don't declare.
9654 * ada-tasks.c (struct ada_tasks_inferior_data)
9655 <task_list_valid_p>: Now bool.
9656 (read_known_tasks, ada_task_list_changed)
9657 (ada_tasks_invalidate_inferior_data): Update.
9658 (read_known_tasks_array): Return bool.
9659 (read_known_tasks_list): Likewise.
9660 (read_known_tasks): Return void.
9661 (ada_build_task_list): Now static.
9662
70cd633e
AB
96632019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9664
9665 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9666 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9667
040b3e95
PW
96682019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9669
9670 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9671 variant for ada_tasks_pspace_data_handle and
9672 ada_tasks_inferior_data_handle.
9673 (ada_tasks_pspace_data_cleanup): New function.
9674 (ada_tasks_inferior_data_cleanup): New function.
9675
9409233b
TT
96762019-02-17 Tom Tromey <tom@tromey.com>
9677
9678 * macrotab.h (macro_source_fullname): Return a std::string.
9679 * macrotab.c (macro_include, check_for_redefinition)
9680 (macro_undef, macro_lookup_definition, foreach_macro)
9681 (foreach_macro_in_scope): Update.
9682 (macro_source_fullname): Return a std::string.
9683 * macrocmd.c (show_pp_source_pos): Update.
9684
6506371f
TT
96852019-02-17 Tom Tromey <tom@tromey.com>
9686
9687 * macrocmd.c (show_pp_source_pos): Style the file names.
9688
0c820d67
TT
96892019-02-17 Tom Tromey <tom@tromey.com>
9690
9691 PR tui/24197:
9692 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9693
a0087920
TT
96942019-02-17 Tom Tromey <tom@tromey.com>
9695
9696 * ada-lang.c (user_select_syms): Use filtered printing.
9697 * utils.c (wrap_style): New global.
9698 (desired_style): Remove.
9699 (emit_style_escape): Add stream parameter.
9700 (set_output_style, reset_terminal_style, prompt_for_continue):
9701 Update.
9702 (flush_wrap_buffer): Only flush gdb_stdout.
9703 (wrap_here): Set wrap_style.
9704 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9705 treat escape sequences as a character. Change when wrap buffer is
9706 flushed.
9707 (fputs_styled): Do not set the output style when the default is
9708 requested.
9709 * ui-style.h (struct ui_file_style) <is_default>: New method.
9710 * source.c (print_source_lines_base): Emit escape sequences in one
9711 piece.
9712
75ba10dc
JB
97132019-02-17 Joel Brobecker <brobecker@adacore.com>
9714
9715 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9716 integers and enumeration types.
9717
a2cd4f14
JB
97182019-02-17 Joel Brobecker <brobecker@adacore.com>
9719
9720 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9721 instead of lookup_symbol_in_language
9722 (do_exact_match): New function.
9723 (ada_get_symbol_name_matcher): Return do_exact_match when
9724 doing a verbatim match.
9725
485b851b
TT
97262019-02-15 Tom Tromey <tromey@adacore.com>
9727
9728 * ravenscar-thread.c (ravenscar_thread_target::resume)
9729 (ravenscar_thread_target::wait): Special case wildcard requests.
9730
0b790b1e
TT
97312019-02-15 Tom Tromey <tromey@adacore.com>
9732
9733 * ravenscar-thread.c (base_ptid): Remove.
9734 (struct ravenscar_thread_target) <close>: New method.
9735 <m_base_ptid>: New member.
9736 <update_inferior_ptid, active_task, task_is_currently_active,
9737 runtime_initialized>: Declare methods.
9738 <ravenscar_thread_target>: Add constructor.
9739 (ravenscar_thread_target::task_is_currently_active)
9740 (ravenscar_thread_target::update_inferior_ptid)
9741 (ravenscar_runtime_initialized): Rename. Now methods.
9742 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9743 (ravenscar_thread_target::update_thread_list): Update.
9744 (ravenscar_thread_target::active_task): Now method.
9745 (ravenscar_thread_target::store_registers)
9746 (ravenscar_thread_target::prepare_to_store)
9747 (ravenscar_thread_target::prepare_to_store)
9748 (ravenscar_thread_target::mourn_inferior): Update.
9749 (ravenscar_inferior_created): Use "new" to create target.
9750 (ravenscar_thread_target::get_ada_task_ptid): Update.
9751 (_initialize_ravenscar): Don't initialize base_ptid.
9752 (ravenscar_ops): Remove global.
9753
dea57a62
TT
97542019-02-15 Tom Tromey <tromey@adacore.com>
9755
9756 * target.h (push_target): Declare new overload.
9757 * target.c (push_target): New overload, taking an rvalue reference.
9758 * remote.c (remote_target::open_1): Use push_target overload.
9759 * corelow.c (core_target_open): Use push_target overload.
9760
989f3c58
TT
97612019-02-15 Tom Tromey <tromey@adacore.com>
9762
9763 * ravenscar-thread.c (is_ravenscar_task)
9764 (ravenscar_task_is_currently_active): Return bool.
9765 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9766 (_initialize_ravenscar): Remove "(void)".
9767 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9768 Return bool.
9769
6cbcc006
TT
97702019-02-15 Tom Tromey <tromey@adacore.com>
9771
9772 * ravenscar-thread.c (ravenscar_runtime_initializer)
9773 (has_ravenscar_runtime, get_running_thread_id)
9774 (ravenscar_thread_target::resume): Fix indentation.
9775
7657f14d
TT
97762019-02-15 Tom Tromey <tromey@adacore.com>
9777
9778 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9779 from ravenscar_arch_ops.
9780 (sparc_ravenscar_ops::fetch_registers)
9781 (sparc_ravenscar_ops::store_registers): Now methods.
9782 (sparc_ravenscar_prepare_to_store): Remove.
9783 (sparc_ravenscar_ops): Redefine.
9784 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9785 methods and destructor. Remove members.
9786 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9787 (ravenscar_thread_target::store_registers)
9788 (ravenscar_thread_target::prepare_to_store): Update.
9789 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9790 Remove.
9791 (struct ppc_ravenscar_powerpc_ops): Derive from
9792 ravenscar_arch_ops.
9793 (ppc_ravenscar_powerpc_ops::fetch_registers)
9794 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9795 (ppc_ravenscar_powerpc_ops): Redefine.
9796 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9797 (ppc_ravenscar_e500_ops::fetch_registers)
9798 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9799 (ppc_ravenscar_e500_ops): Redefine.
9800 * aarch64-ravenscar-thread.c
9801 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9802 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9803 (aarch64_ravenscar_fetch_registers)
9804 (aarch64_ravenscar_store_registers): Now methods.
9805 (aarch64_ravenscar_ops): Redefine.
9806
5b6ea500
TT
98072019-02-15 Tom Tromey <tromey@adacore.com>
9808
9809 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9810 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9811 (ravenscar_thread_target::stopped_by_watchpoint)
9812 (ravenscar_thread_target::stopped_data_address)
9813 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9814
e397fd39
TT
98152019-02-15 Tom Tromey <tromey@adacore.com>
9816
9817 * ravenscar-thread.c: Fix some typos.
9818
cc12f4a8
TT
98192019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9820 Tom Tromey <tromey@adacore.com>
9821
9822 * ada-lang.c (ada_exception_sal): Change addr_string to a
9823 std::string.
9824 (create_ada_exception_catchpoint): Update.
9825
5f486660
TT
98262019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9827 Tom Tromey <tromey@adacore.com>
9828
9829 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9830 (bp_location_ops): Remove.
9831 (base_breakpoint_allocate_location): Update.
9832 (free_bp_location): Update.
9833 * ada-lang.c (class ada_catchpoint_location)
9834 <ada_catchpoint_location>: Remove ops parameter.
9835 (ada_catchpoint_location_dtor): Remove.
9836 (ada_catchpoint_location_ops): Remove.
9837 (allocate_location_exception): Update.
9838 * breakpoint.h (struct bp_location_ops): Remove.
9839 (class bp_location) <bp_location>: Remove bp_location_ops
9840 parameter.
9841 <~bp_location>: Add destructor.
9842 <ops>: Remove.
9843
b671c7fb
TS
98442019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9845 Pedro Alves <palves@redhat.com>
9846
9847 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9848 'PATH_MAX'.
9849
8071c5ce
DM
98502019-02-14 David Michael <fedora.dm0@gmail.com>
9851 Samuel Thibault <samuel.thibault@gnu.org>
9852 Thomas Schwinge <thomas@codesourcery.com>
9853
9854 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9855 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9856
b1041ae0
TS
98572019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9858
924514e1
TS
9859 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9860 (check_empty): Use "const char *".
9861
c29ee8d4
TS
9862 * gnu-nat.c (gnu_nat_target::detach): Instead of
9863 'detach_inferior (pid)' call
9864 'detach_inferior (find_inferior_pid (pid))'.
9865
6c6ef69f
TS
9866 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9867 'nat/fork-inferior.o'.
9868 * gnu-nat.c: #include "nat/fork-inferior.h".
9869
2d0a338c
TS
9870 * gnu-nat.c (gnu_nat_target::detach): Instead of
9871 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9872 * gnu-nat.h: #include "inf-child.h".
9873 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9874 'i386_gnu_nat_target::fetch_registers'.
9875 (gnu_store_registers): Rename/move to
9876 'i386_gnu_nat_target::store_registers'.
9877
cabb5f06
TS
9878 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9879 * gnu-nat.h (mach_thread_info): New function.
9880 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9881
b1041ae0
TS
9882 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9883
2988d01e
KF
98842019-02-14 Frederic Konrad <konrad@adacore.com>
9885
9886 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9887
c559d709
JB
98882019-02-14 Joel Brobecker <brobecker@adacore.com>
9889
9890 * windows-nat.c (windows_add_thread): Add new parameter
9891 "main_thread_p" with default value set to false. Update
9892 function documentation as well as all callers.
9893 (windows_delete_thread): Likewise.
9894 (fake_create_process): Update call to windows_add_thread.
9895 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9896 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9897 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9898 call to windows_delete_thread.
9899
007024cc
SM
99002019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9901
9902 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9903
f62318e9
JB
99042019-02-12 John Baldwin <jhb@FreeBSD.org>
9905
9906 * symfile.c (find_separate_debug_file): Use canonical path of
9907 sysroot with child_path instead of gdb_sysroot if it is valid.
9908
cd4b7848
JB
99092019-02-12 John Baldwin <jhb@FreeBSD.org>
9910
9911 * symfile.c (find_separate_debug_file): Use child_path to
9912 determine if an object file is under a sysroot.
9913
efac4bfe
JB
99142019-02-12 John Baldwin <jhb@FreeBSD.org>
9915
9916 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9917 unittests/child-path-selftests.c.
9918 * common/pathstuff.c (child_path): New function.
9919 * common/pathstuff.h (child_path): New prototype.
9920 * unittests/child-path-selftests.c: New file.
9921
402d2bfe
JB
99222019-02-12 John Baldwin <jhb@FreeBSD.org>
9923
9924 * symfile.c (find_separate_debug_file): Look for separate debug
9925 files in debug directories under the sysroot.
9926
1ed9f74e
PW
99272019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9928
9929 * symtab.h (struct minimal_symbol data_p): New const method.
9930 (struct minimal_symbol text_p): Likewise.
9931 * symtab.c (output_source_filename): Use file name style
9932 to print file name.
9933 (print_symbol_info): Likewise.
9934 (print_msymbol_info): Use address style to print addresses.
9935 Use function name style to print executable text symbols.
9936 (expand_symtab_containing_pc): Use data_p.
9937 (find_pc_sect_compunit_symtab): Likewise.
9938
2636d81d
PW
99392019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9940
9941 * breakpoint.c (describe_other_breakpoints): Use address style
9942 to print addresses.
9943 (say_where): Likewise.
9944
ac8c53cc
PW
99452019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9946
9947 * ada-typeprint.c (print_func_type): Print function name
9948 style to print function name.
9949 * c-typeprint.c (c_print_type_1): Likewise.
9950
ea638c43
AH
99512019-02-11 Alan Hayward <alan.hayward@arm.com>
9952
9953 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9954 for execve.
9955
ab759ca8
PW
99562019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9957
9958 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9959 type_stack.
9960
aff29d1c
JB
99612019-02-10 Joel Brobecker <brobecker@adacore.com>
9962
9963 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9964 TYPE_CODE_REF types.
9965
617126bc
JW
99662019-02-08 Jim Wilson <jimw@sifive.com>
9967
9968 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9969 (riscv_linux_fregset): New.
9970 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9971
46e3ed7f
TT
99722019-02-07 Tom Tromey <tom@tromey.com>
9973
9974 * thread.c (thread_cancel_execution_command): Update.
9975 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9976 methods.
9977 (struct thread_fsm_ops): Remove.
9978 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9979 (thread_fsm_should_stop, thread_fsm_return_value)
9980 (thread_fsm_set_finished, thread_fsm_finished_p)
9981 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9982 Don't declare.
9983 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9984 * infrun.c (clear_proceed_status_thread)
9985 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9986 (print_stop_event): Update.
9987 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9988 Add constructor.
9989 (step_command_fsm_ops): Remove.
9990 (new_step_command_fsm): Remove.
9991 (step_1): Update.
9992 (step_command_fsm::should_stop): Rename from
9993 step_command_fsm_should_stop.
9994 (step_command_fsm::clean_up): Rename from
9995 step_command_fsm_clean_up.
9996 (step_command_fsm::do_async_reply_reason): Rename from
9997 step_command_fsm_async_reply_reason.
9998 (struct until_next_fsm): Inherit from thread_fsm. Add
9999 constructor.
10000 (until_next_fsm_ops): Remove.
10001 (new_until_next_fsm): Remove.
10002 (until_next_fsm::should_stop): Rename from
10003 until_next_fsm_should_stop.
10004 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10005 (until_next_fsm::do_async_reply_reason): Rename from
10006 until_next_fsm_async_reply_reason.
10007 (struct finish_command_fsm): Inherit from thread_fsm. Add
10008 constructor. Change type of breakpoint.
10009 (finish_command_fsm_ops): Remove.
10010 (new_finish_command_fsm): Remove.
10011 (finish_command_fsm::should_stop): Rename from
10012 finish_command_fsm_should_stop.
10013 (finish_command_fsm::clean_up): Rename from
10014 finish_command_fsm_clean_up.
10015 (finish_command_fsm::return_value): Rename from
10016 finish_command_fsm_return_value.
10017 (finish_command_fsm::do_async_reply_reason): Rename from
10018 finish_command_fsm_async_reply_reason.
10019 (finish_command): Update.
10020 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10021 Add constructor.
10022 (call_thread_fsm_ops): Remove.
10023 (call_thread_fsm::call_thread_fsm): Rename from
10024 new_call_thread_fsm.
10025 (call_thread_fsm::should_stop): Rename from
10026 call_thread_fsm_should_stop.
10027 (call_thread_fsm::should_notify_stop): Rename from
10028 call_thread_fsm_should_notify_stop.
10029 (run_inferior_call, call_function_by_hand_dummy): Update.
10030 * cli/cli-interp.c (should_print_stop_to_console): Update.
10031 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10032 Add constructor. Change type of location_breakpoint,
10033 caller_breakpoint.
10034 (until_break_fsm_ops): Remove.
10035 (new_until_break_fsm): Remove.
10036 (until_break_fsm::should_stop): Rename from
10037 until_break_fsm_should_stop.
10038 (until_break_fsm::clean_up): Rename from
10039 until_break_fsm_clean_up.
10040 (until_break_fsm::do_async_reply_reason): Rename from
10041 until_break_fsm_async_reply_reason.
10042 (until_break_command): Update.
10043 * thread-fsm.c: Remove.
10044 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10045
1a5c2598
TT
100462019-02-07 Tom Tromey <tom@tromey.com>
10047
10048 * yy-remap.h: Add include guard.
10049 * xtensa-tdep.h: Add include guard.
10050 * xcoffread.h: Rename include guard.
10051 * varobj-iter.h: Add include guard.
10052 * tui/tui.h: Rename include guard.
10053 * tui/tui-winsource.h: Rename include guard.
10054 * tui/tui-wingeneral.h: Rename include guard.
10055 * tui/tui-windata.h: Rename include guard.
10056 * tui/tui-win.h: Rename include guard.
10057 * tui/tui-stack.h: Rename include guard.
10058 * tui/tui-source.h: Rename include guard.
10059 * tui/tui-regs.h: Rename include guard.
10060 * tui/tui-out.h: Rename include guard.
10061 * tui/tui-layout.h: Rename include guard.
10062 * tui/tui-io.h: Rename include guard.
10063 * tui/tui-hooks.h: Rename include guard.
10064 * tui/tui-file.h: Rename include guard.
10065 * tui/tui-disasm.h: Rename include guard.
10066 * tui/tui-data.h: Rename include guard.
10067 * tui/tui-command.h: Rename include guard.
10068 * tic6x-tdep.h: Add include guard.
10069 * target/waitstatus.h: Rename include guard.
10070 * target/wait.h: Rename include guard.
10071 * target/target.h: Rename include guard.
10072 * target/resume.h: Rename include guard.
10073 * target-float.h: Rename include guard.
10074 * stabsread.h: Add include guard.
10075 * rs6000-tdep.h: Add include guard.
10076 * riscv-fbsd-tdep.h: Add include guard.
10077 * regformats/regdef.h: Rename include guard.
10078 * record.h: Rename include guard.
10079 * python/python.h: Rename include guard.
10080 * python/python-internal.h: Rename include guard.
10081 * python/py-stopevent.h: Rename include guard.
10082 * python/py-ref.h: Rename include guard.
10083 * python/py-record.h: Rename include guard.
10084 * python/py-record-full.h: Rename include guard.
10085 * python/py-record-btrace.h: Rename include guard.
10086 * python/py-instruction.h: Rename include guard.
10087 * python/py-events.h: Rename include guard.
10088 * python/py-event.h: Rename include guard.
10089 * procfs.h: Add include guard.
10090 * proc-utils.h: Add include guard.
10091 * p-lang.h: Add include guard.
10092 * or1k-tdep.h: Rename include guard.
10093 * observable.h: Rename include guard.
10094 * nto-tdep.h: Rename include guard.
10095 * nat/x86-linux.h: Rename include guard.
10096 * nat/x86-linux-dregs.h: Rename include guard.
10097 * nat/x86-gcc-cpuid.h: Add include guard.
10098 * nat/x86-dregs.h: Rename include guard.
10099 * nat/x86-cpuid.h: Rename include guard.
10100 * nat/ppc-linux.h: Rename include guard.
10101 * nat/mips-linux-watch.h: Rename include guard.
10102 * nat/linux-waitpid.h: Rename include guard.
10103 * nat/linux-ptrace.h: Rename include guard.
10104 * nat/linux-procfs.h: Rename include guard.
10105 * nat/linux-osdata.h: Rename include guard.
10106 * nat/linux-nat.h: Rename include guard.
10107 * nat/linux-namespaces.h: Rename include guard.
10108 * nat/linux-btrace.h: Rename include guard.
10109 * nat/glibc_thread_db.h: Rename include guard.
10110 * nat/gdb_thread_db.h: Rename include guard.
10111 * nat/gdb_ptrace.h: Rename include guard.
10112 * nat/fork-inferior.h: Rename include guard.
10113 * nat/amd64-linux-siginfo.h: Rename include guard.
10114 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10115 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10116 * nat/aarch64-linux.h: Rename include guard.
10117 * nat/aarch64-linux-hw-point.h: Rename include guard.
10118 * mn10300-tdep.h: Add include guard.
10119 * mips-linux-tdep.h: Add include guard.
10120 * mi/mi-parse.h: Rename include guard.
10121 * mi/mi-out.h: Rename include guard.
10122 * mi/mi-main.h: Rename include guard.
10123 * mi/mi-interp.h: Rename include guard.
10124 * mi/mi-getopt.h: Rename include guard.
10125 * mi/mi-console.h: Rename include guard.
10126 * mi/mi-common.h: Rename include guard.
10127 * mi/mi-cmds.h: Rename include guard.
10128 * mi/mi-cmd-break.h: Rename include guard.
10129 * m2-lang.h: Add include guard.
10130 * location.h: Rename include guard.
10131 * linux-record.h: Rename include guard.
10132 * linux-nat.h: Add include guard.
10133 * linux-fork.h: Add include guard.
10134 * i386-darwin-tdep.h: Rename include guard.
10135 * hppa-linux-offsets.h: Add include guard.
10136 * guile/guile.h: Rename include guard.
10137 * guile/guile-internal.h: Rename include guard.
10138 * gnu-nat.h: Rename include guard.
10139 * gdb-stabs.h: Rename include guard.
10140 * frv-tdep.h: Add include guard.
10141 * f-lang.h: Add include guard.
10142 * event-loop.h: Add include guard.
10143 * darwin-nat.h: Rename include guard.
10144 * cp-abi.h: Rename include guard.
10145 * config/sparc/nm-sol2.h: Rename include guard.
10146 * config/nm-nto.h: Rename include guard.
10147 * config/nm-linux.h: Add include guard.
10148 * config/i386/nm-i386gnu.h: Rename include guard.
10149 * config/djgpp/nl_types.h: Rename include guard.
10150 * config/djgpp/langinfo.h: Rename include guard.
10151 * compile/gcc-cp-plugin.h: Add include guard.
10152 * compile/gcc-c-plugin.h: Add include guard.
10153 * compile/compile.h: Rename include guard.
10154 * compile/compile-object-run.h: Rename include guard.
10155 * compile/compile-object-load.h: Rename include guard.
10156 * compile/compile-internal.h: Rename include guard.
10157 * compile/compile-cplus.h: Rename include guard.
10158 * compile/compile-c.h: Rename include guard.
10159 * common/xml-utils.h: Rename include guard.
10160 * common/x86-xstate.h: Rename include guard.
10161 * common/version.h: Rename include guard.
10162 * common/vec.h: Rename include guard.
10163 * common/tdesc.h: Rename include guard.
10164 * common/selftest.h: Rename include guard.
10165 * common/scoped_restore.h: Rename include guard.
10166 * common/scoped_mmap.h: Rename include guard.
10167 * common/scoped_fd.h: Rename include guard.
10168 * common/safe-iterator.h: Rename include guard.
10169 * common/run-time-clock.h: Rename include guard.
10170 * common/refcounted-object.h: Rename include guard.
10171 * common/queue.h: Rename include guard.
10172 * common/ptid.h: Rename include guard.
10173 * common/print-utils.h: Rename include guard.
10174 * common/preprocessor.h: Rename include guard.
10175 * common/pathstuff.h: Rename include guard.
10176 * common/observable.h: Rename include guard.
10177 * common/netstuff.h: Rename include guard.
10178 * common/job-control.h: Rename include guard.
10179 * common/host-defs.h: Rename include guard.
10180 * common/gdb_wait.h: Rename include guard.
10181 * common/gdb_vecs.h: Rename include guard.
10182 * common/gdb_unlinker.h: Rename include guard.
10183 * common/gdb_unique_ptr.h: Rename include guard.
10184 * common/gdb_tilde_expand.h: Rename include guard.
10185 * common/gdb_sys_time.h: Rename include guard.
10186 * common/gdb_string_view.h: Rename include guard.
10187 * common/gdb_splay_tree.h: Rename include guard.
10188 * common/gdb_setjmp.h: Rename include guard.
10189 * common/gdb_ref_ptr.h: Rename include guard.
10190 * common/gdb_optional.h: Rename include guard.
10191 * common/gdb_locale.h: Rename include guard.
10192 * common/gdb_assert.h: Rename include guard.
10193 * common/filtered-iterator.h: Rename include guard.
10194 * common/filestuff.h: Rename include guard.
10195 * common/fileio.h: Rename include guard.
10196 * common/environ.h: Rename include guard.
10197 * common/common-utils.h: Rename include guard.
10198 * common/common-types.h: Rename include guard.
10199 * common/common-regcache.h: Rename include guard.
10200 * common/common-inferior.h: Rename include guard.
10201 * common/common-gdbthread.h: Rename include guard.
10202 * common/common-exceptions.h: Rename include guard.
10203 * common/common-defs.h: Rename include guard.
10204 * common/common-debug.h: Rename include guard.
10205 * common/cleanups.h: Rename include guard.
10206 * common/buffer.h: Rename include guard.
10207 * common/btrace-common.h: Rename include guard.
10208 * common/break-common.h: Rename include guard.
10209 * cli/cli-utils.h: Rename include guard.
10210 * cli/cli-style.h: Rename include guard.
10211 * cli/cli-setshow.h: Rename include guard.
10212 * cli/cli-script.h: Rename include guard.
10213 * cli/cli-interp.h: Rename include guard.
10214 * cli/cli-decode.h: Rename include guard.
10215 * cli/cli-cmds.h: Rename include guard.
10216 * charset-list.h: Add include guard.
10217 * buildsym-legacy.h: Rename include guard.
10218 * bfin-tdep.h: Add include guard.
10219 * ax.h: Rename include guard.
10220 * arm-linux-tdep.h: Add include guard.
10221 * arm-fbsd-tdep.h: Add include guard.
10222 * arch/xtensa.h: Rename include guard.
10223 * arch/tic6x.h: Add include guard.
10224 * arch/i386.h: Add include guard.
10225 * arch/arm.h: Rename include guard.
10226 * arch/arm-linux.h: Rename include guard.
10227 * arch/arm-get-next-pcs.h: Rename include guard.
10228 * arch/amd64.h: Add include guard.
10229 * arch/aarch64-insn.h: Rename include guard.
10230 * arch-utils.h: Rename include guard.
10231 * annotate.h: Add include guard.
10232 * amd64-darwin-tdep.h: Rename include guard.
10233 * aarch64-linux-tdep.h: Add include guard.
10234 * aarch64-fbsd-tdep.h: Add include guard.
10235 * aarch32-linux-nat.h: Add include guard.
10236
ab9268d2
PW
102372019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10238
10239 * macrotab.c (macro_define_internal): New function that
10240 factorizes macro_define_object_internal and macro_define_function
10241 code.
10242 (macro_define_object_internal): Use macro_define_internal.
10243 (macro_define_function): Likewise.
10244
bb0da2b4
PW
102452019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10246
10247 * macrocmd.c (extract_identifier): Return
10248 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10249 callers.
10250
424eb552
JB
102512019-02-06 John Baldwin <jhb@FreeBSD.org>
10252
10253 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10254
1688cb29
TT
102552019-02-05 Tom Tromey <tom@tromey.com>
10256
10257 * target.c (target_stack::unpush): Move assertion earlier.
10258
b5eba2d8
TT
102592019-01-30 Tom Tromey <tom@tromey.com>
10260
10261 PR python/23615:
10262 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10263 (gdbpy_parse_and_eval): Likewise.
10264 * python/python-internal.h (gdbpy_allow_threads): New class.
10265
7054e2ff
JB
102662019-01-28 John Baldwin <jhb@FreeBSD.org>
10267
10268 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10269 (aarch64_fbsd_fpregmap): Move earlier.
10270 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10271 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10272 instead of individual calls to trad_frame_set_reg_addr.
10273 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10274 earlier.
10275 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10276 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10277 instead of individual calls to trad_frame_set_reg_addr.
10278
36c25ffa
AH
102792019-01-28 Alan Hayward <alan.hayward@arm.com>
10280
10281 * CONTRIBUTE: Replace contribution list with wiki link.
10282
a0707f3c
TT
102832019-01-25 Tom Tromey <tom@tromey.com>
10284
10285 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10286
0747795c
TT
102872019-01-25 Tom Tromey <tom@tromey.com>
10288
10289 * xtensa-linux-nat.c: Fix common/ includes.
10290 * xml-support.h: Fix common/ includes.
10291 * xml-support.c: Fix common/ includes.
10292 * x86-linux-nat.c: Fix common/ includes.
10293 * windows-nat.c: Fix common/ includes.
10294 * varobj.h: Fix common/ includes.
10295 * varobj.c: Fix common/ includes.
10296 * value.c: Fix common/ includes.
10297 * valops.c: Fix common/ includes.
10298 * utils.c: Fix common/ includes.
10299 * unittests/xml-utils-selftests.c: Fix common/ includes.
10300 * unittests/utils-selftests.c: Fix common/ includes.
10301 * unittests/unpack-selftests.c: Fix common/ includes.
10302 * unittests/tracepoint-selftests.c: Fix common/ includes.
10303 * unittests/style-selftests.c: Fix common/ includes.
10304 * unittests/string_view-selftests.c: Fix common/ includes.
10305 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10306 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10307 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10308 * unittests/rsp-low-selftests.c: Fix common/ includes.
10309 * unittests/parse-connection-spec-selftests.c: Fix common/
10310 includes.
10311 * unittests/optional-selftests.c: Fix common/ includes.
10312 * unittests/offset-type-selftests.c: Fix common/ includes.
10313 * unittests/observable-selftests.c: Fix common/ includes.
10314 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10315 * unittests/memrange-selftests.c: Fix common/ includes.
10316 * unittests/memory-map-selftests.c: Fix common/ includes.
10317 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10318 * unittests/function-view-selftests.c: Fix common/ includes.
10319 * unittests/environ-selftests.c: Fix common/ includes.
10320 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10321 * unittests/common-utils-selftests.c: Fix common/ includes.
10322 * unittests/cli-utils-selftests.c: Fix common/ includes.
10323 * unittests/array-view-selftests.c: Fix common/ includes.
10324 * ui-file.c: Fix common/ includes.
10325 * tui/tui-io.c: Fix common/ includes.
10326 * tracepoint.h: Fix common/ includes.
10327 * tracepoint.c: Fix common/ includes.
10328 * tracefile-tfile.c: Fix common/ includes.
10329 * top.h: Fix common/ includes.
10330 * top.c: Fix common/ includes.
10331 * thread.c: Fix common/ includes.
10332 * target/waitstatus.h: Fix common/ includes.
10333 * target/waitstatus.c: Fix common/ includes.
10334 * target.h: Fix common/ includes.
10335 * target.c: Fix common/ includes.
10336 * target-memory.c: Fix common/ includes.
10337 * target-descriptions.c: Fix common/ includes.
10338 * symtab.h: Fix common/ includes.
10339 * symfile.c: Fix common/ includes.
10340 * stap-probe.c: Fix common/ includes.
10341 * spu-linux-nat.c: Fix common/ includes.
10342 * sparc-nat.c: Fix common/ includes.
10343 * source.c: Fix common/ includes.
10344 * solib.c: Fix common/ includes.
10345 * solib-target.c: Fix common/ includes.
10346 * ser-unix.c: Fix common/ includes.
10347 * ser-tcp.c: Fix common/ includes.
10348 * ser-pipe.c: Fix common/ includes.
10349 * ser-base.c: Fix common/ includes.
10350 * selftest-arch.c: Fix common/ includes.
10351 * s12z-tdep.c: Fix common/ includes.
10352 * rust-exp.y: Fix common/ includes.
10353 * rs6000-aix-tdep.c: Fix common/ includes.
10354 * riscv-tdep.c: Fix common/ includes.
10355 * remote.c: Fix common/ includes.
10356 * remote-notif.h: Fix common/ includes.
10357 * remote-fileio.h: Fix common/ includes.
10358 * remote-fileio.c: Fix common/ includes.
10359 * regcache.h: Fix common/ includes.
10360 * regcache.c: Fix common/ includes.
10361 * record-btrace.c: Fix common/ includes.
10362 * python/python.c: Fix common/ includes.
10363 * python/py-type.c: Fix common/ includes.
10364 * python/py-inferior.c: Fix common/ includes.
10365 * progspace.h: Fix common/ includes.
10366 * producer.c: Fix common/ includes.
10367 * procfs.c: Fix common/ includes.
10368 * proc-api.c: Fix common/ includes.
10369 * printcmd.c: Fix common/ includes.
10370 * ppc-linux-nat.c: Fix common/ includes.
10371 * parser-defs.h: Fix common/ includes.
10372 * osdata.c: Fix common/ includes.
10373 * obsd-nat.c: Fix common/ includes.
10374 * nat/x86-linux.c: Fix common/ includes.
10375 * nat/x86-linux-dregs.c: Fix common/ includes.
10376 * nat/x86-dregs.h: Fix common/ includes.
10377 * nat/x86-dregs.c: Fix common/ includes.
10378 * nat/ppc-linux.c: Fix common/ includes.
10379 * nat/mips-linux-watch.h: Fix common/ includes.
10380 * nat/mips-linux-watch.c: Fix common/ includes.
10381 * nat/linux-waitpid.c: Fix common/ includes.
10382 * nat/linux-ptrace.h: Fix common/ includes.
10383 * nat/linux-ptrace.c: Fix common/ includes.
10384 * nat/linux-procfs.c: Fix common/ includes.
10385 * nat/linux-personality.c: Fix common/ includes.
10386 * nat/linux-osdata.c: Fix common/ includes.
10387 * nat/linux-namespaces.c: Fix common/ includes.
10388 * nat/linux-btrace.h: Fix common/ includes.
10389 * nat/linux-btrace.c: Fix common/ includes.
10390 * nat/fork-inferior.c: Fix common/ includes.
10391 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10392 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10393 * nat/aarch64-linux.c: Fix common/ includes.
10394 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10395 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10396 * namespace.h: Fix common/ includes.
10397 * mips-linux-tdep.c: Fix common/ includes.
10398 * minsyms.c: Fix common/ includes.
10399 * mi/mi-parse.h: Fix common/ includes.
10400 * mi/mi-main.c: Fix common/ includes.
10401 * mi/mi-cmd-env.c: Fix common/ includes.
10402 * memrange.h: Fix common/ includes.
10403 * memattr.c: Fix common/ includes.
10404 * maint.h: Fix common/ includes.
10405 * maint.c: Fix common/ includes.
10406 * main.c: Fix common/ includes.
10407 * machoread.c: Fix common/ includes.
10408 * location.c: Fix common/ includes.
10409 * linux-thread-db.c: Fix common/ includes.
10410 * linux-nat.c: Fix common/ includes.
10411 * linux-fork.c: Fix common/ includes.
10412 * inline-frame.c: Fix common/ includes.
10413 * infrun.c: Fix common/ includes.
10414 * inflow.c: Fix common/ includes.
10415 * inferior.h: Fix common/ includes.
10416 * inferior.c: Fix common/ includes.
10417 * infcmd.c: Fix common/ includes.
10418 * inf-ptrace.c: Fix common/ includes.
10419 * inf-child.c: Fix common/ includes.
10420 * ia64-linux-nat.c: Fix common/ includes.
10421 * i387-tdep.c: Fix common/ includes.
10422 * i386-tdep.c: Fix common/ includes.
10423 * i386-linux-tdep.c: Fix common/ includes.
10424 * i386-linux-nat.c: Fix common/ includes.
10425 * i386-go32-tdep.c: Fix common/ includes.
10426 * i386-fbsd-tdep.c: Fix common/ includes.
10427 * i386-fbsd-nat.c: Fix common/ includes.
10428 * guile/scm-type.c: Fix common/ includes.
10429 * guile/guile.c: Fix common/ includes.
10430 * go32-nat.c: Fix common/ includes.
10431 * gnu-nat.c: Fix common/ includes.
10432 * gdbthread.h: Fix common/ includes.
10433 * gdbarch-selftests.c: Fix common/ includes.
10434 * gdb_usleep.c: Fix common/ includes.
10435 * gdb_select.h: Fix common/ includes.
10436 * gdb_bfd.c: Fix common/ includes.
10437 * gcore.c: Fix common/ includes.
10438 * fork-child.c: Fix common/ includes.
10439 * findvar.c: Fix common/ includes.
10440 * fbsd-nat.c: Fix common/ includes.
10441 * event-top.c: Fix common/ includes.
10442 * event-loop.c: Fix common/ includes.
10443 * dwarf2read.c: Fix common/ includes.
10444 * dwarf2loc.c: Fix common/ includes.
10445 * dwarf2-frame.c: Fix common/ includes.
10446 * dwarf-index-cache.c: Fix common/ includes.
10447 * dtrace-probe.c: Fix common/ includes.
10448 * disasm-selftests.c: Fix common/ includes.
10449 * defs.h: Fix common/ includes.
10450 * csky-tdep.c: Fix common/ includes.
10451 * cp-valprint.c: Fix common/ includes.
10452 * cp-support.h: Fix common/ includes.
10453 * cp-support.c: Fix common/ includes.
10454 * corelow.c: Fix common/ includes.
10455 * completer.h: Fix common/ includes.
10456 * completer.c: Fix common/ includes.
10457 * compile/compile.c: Fix common/ includes.
10458 * compile/compile-loc2c.c: Fix common/ includes.
10459 * compile/compile-cplus-types.c: Fix common/ includes.
10460 * compile/compile-cplus-symbols.c: Fix common/ includes.
10461 * command.h: Fix common/ includes.
10462 * cli/cli-dump.c: Fix common/ includes.
10463 * cli/cli-cmds.c: Fix common/ includes.
10464 * charset.c: Fix common/ includes.
10465 * build-id.c: Fix common/ includes.
10466 * btrace.h: Fix common/ includes.
10467 * btrace.c: Fix common/ includes.
10468 * breakpoint.h: Fix common/ includes.
10469 * breakpoint.c: Fix common/ includes.
10470 * ax.h:
10471 (enum agent_op): Fix common/ includes.
10472 * ax-general.c (struct aop_map): Fix common/ includes.
10473 * ax-gdb.c: Fix common/ includes.
10474 * auxv.c: Fix common/ includes.
10475 * auto-load.c: Fix common/ includes.
10476 * arm-tdep.c: Fix common/ includes.
10477 * arch/riscv.c: Fix common/ includes.
10478 * arch/ppc-linux-common.c: Fix common/ includes.
10479 * arch/i386.c: Fix common/ includes.
10480 * arch/arm.c: Fix common/ includes.
10481 * arch/arm-linux.c: Fix common/ includes.
10482 * arch/arm-get-next-pcs.c: Fix common/ includes.
10483 * arch/amd64.c: Fix common/ includes.
10484 * arch/aarch64.c: Fix common/ includes.
10485 * arch/aarch64-insn.c: Fix common/ includes.
10486 * arch-utils.c: Fix common/ includes.
10487 * amd64-windows-tdep.c: Fix common/ includes.
10488 * amd64-tdep.c: Fix common/ includes.
10489 * amd64-sol2-tdep.c: Fix common/ includes.
10490 * amd64-obsd-tdep.c: Fix common/ includes.
10491 * amd64-nbsd-tdep.c: Fix common/ includes.
10492 * amd64-linux-tdep.c: Fix common/ includes.
10493 * amd64-linux-nat.c: Fix common/ includes.
10494 * amd64-fbsd-tdep.c: Fix common/ includes.
10495 * amd64-fbsd-nat.c: Fix common/ includes.
10496 * amd64-dicos-tdep.c: Fix common/ includes.
10497 * amd64-darwin-tdep.c: Fix common/ includes.
10498 * agent.c: Fix common/ includes.
10499 * ada-lang.h: Fix common/ includes.
10500 * ada-lang.c: Fix common/ includes.
10501 * aarch64-tdep.c: Fix common/ includes.
10502
2f5c153e
TT
105032019-01-25 Tom Tromey <tom@tromey.com>
10504
10505 * common/create-version.sh: Use common/version.h.
10506
adc6a863
PA
105072019-01-24 Pedro Alves <palves@redhat.com>
10508
10509 * infrun.c (signal_stop, signal_print, signal_program)
10510 (signal_catch, signal_pass): Now arrays instead of pointers.
10511 (update_signals_program_target, do_target_resume)
10512 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10513 * linux-nat.c (linux_nat_target::pass_signals)
10514 (linux_nat_target::create_inferior, linux_nat_target::attach):
10515 Adjust.
10516 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10517 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10518 * procfs.c (procfs_target::pass_signals): Adjust.
10519 * record-full.c (record_full_target::resume): Adjust.
10520 * remote.c (remote_target::pass_signals)
10521 (remote_target::program_signals): Adjust.
10522 * target-debug.h (target_debug_print_signals): Now takes a
10523 gdb::array_view as parameter. Adjust.
10524 * target.h (target_ops) <pass_signals, program_signals>: Replace
10525 pointer and length parameters with gdb::array_view.
10526 (target_pass_signals, target_program_signals): Likewise.
10527 * target-delegates.c: Regenerate.
10528
3046d67a
PA
105292019-01-24 Pedro Alves <palves@redhat.com>
10530
10531 * common/forward-scope-exit.h
10532 (forward_scope_exit::forward_scope_exit): Pass arguments to
10533 m_bind_function directly, instead of creating a std::bind and
10534 copying that.
10535
353229bf
AH
105362019-01-24 Alan Hayward <alan.hayward@arm.com>
10537
10538 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10539 for static members.
10540 (pass_in_v_vfp_candidate): Likewise.
10541
311dc83a
TT
105422019-01-23 Tom Tromey <tom@tromey.com>
10543 Pedro Alves <palves@redhat.com>
10544
10545 * regcache.c (class regcache_invalidator): Remove.
10546 (regcache::raw_write): Use make_scope_exit.
10547
296bd123
TT
105482019-01-23 Tom Tromey <tom@tromey.com>
10549
10550 * ui-out.h (class ui_out_emit_type): Update comment.
10551
979a0d13
TT
105522019-01-23 Tom Tromey <tom@tromey.com>
10553
10554 * infrun.c (fetch_inferior_event): Update comment.
10555
d238133d
TT
105562019-01-23 Tom Tromey <tom@tromey.com>
10557 Pedro Alves <palves@redhat.com>
10558
10559 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10560 parameter.
10561 (fetch_inferior_event): Use SCOPE_EXIT.
10562
10563
9885e6bb
TT
105642019-01-23 Tom Tromey <tom@tromey.com>
10565 Pedro Alves <palves@redhat.com>
10566
10567 * infrun.c (disable_thread_events): Delete.
10568 (stop_all_threads): Use SCOPE_EXIT.
10569
286526c1
TT
105702019-01-23 Tom Tromey <tom@tromey.com>
10571 Pedro Alves <palves@redhat.com>
10572
10573 * symfile.c: Include forward-scope-exit.h.
10574 (clear_symtab_users_cleanup): Replace forward declaration with
10575 a FORWARD_SCOPE_EXIT.
10576 (syms_from_objfile_1): Use the forward_scope_exit and
10577 gdb::optional instead of cleanup_function.
10578 (reread_symbols): Use the forward_scope_exit instead of
10579 cleanup_function.
10580 (clear_symtab_users_cleanup): Remove function.
10581
1db93f14
TT
105822019-01-23 Tom Tromey <tom@tromey.com>
10583 Pedro Alves <palves@redhat.com>
10584
10585 * linux-nat.c: Include scope-exit.h.
10586 (cleanup_target_stop): Remove.
10587 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10588 SCOPE_EXIT.
10589
2cc83d1e
TT
105902019-01-23 Tom Tromey <tom@tromey.com>
10591 Pedro Alves <palves@redhat.com>
10592
10593 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10594 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10595
694c6bf5
TT
105962019-01-23 Tom Tromey <tom@tromey.com>
10597 Andrew Burgess <andrew.burgess@embecosm.com>
10598 Pedro Alves <palves@redhat.com>
10599
10600 * infrun.c (fetch_inferior_event): Use scope_exit.
10601 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10602 * top.c (execute_command): Use scope_exit.
10603 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10604 * utils.c (do_bpstat_clear_actions_cleanup)
10605 (make_bpstat_clear_actions_cleanup): Remove.
10606
4c41382a
TT
106072019-01-23 Tom Tromey <tom@tromey.com>
10608 Pedro Alves <palves@redhat.com>
10609
10610 * infrun.c: Include "common/scope-exit.h"
10611 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10612 (wait_for_inferior): Use SCOPE_EXIT.
10613 (fetch_inferior_event): Use scope_exit.
10614
89f8fb50
TT
106152019-01-23 Tom Tromey <tom@tromey.com>
10616 Pedro Alves <palves@redhat.com>
10617
10618 * breakpoint.c (create_breakpoint): Remove cleanup.
10619
5419bdae
TT
106202019-01-23 Tom Tromey <tom@tromey.com>
10621 Andrew Burgess <andrew.burgess@embecosm.com>
10622 Pedro Alves <palves@redhat.com>
10623
e587ef42
PA
106242019-01-23 Pedro Alves <palves@redhat.com>
10625
10626 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10627
77f0e74c
PA
106282019-01-23 Pedro Alves <palves@redhat.com>
10629 Andrew Burgess <andrew.burgess@embecosm.com>
10630
10631 * gdbthread.h: Include "common/forward-scope-exit.h".
10632 (scoped_finish_thread_state): Redefine custom class in terms of
10633 forward_scope_exit.
10634
5b9b3e53
PA
106352019-01-23 Pedro Alves <palves@redhat.com>
10636 Andrew Burgess <andrew.burgess@embecosm.com>
10637
10638 * common/forward-scope-exit.h: New file.
10639
54b65c9b
PA
106402019-01-23 Pedro Alves <palves@redhat.com>
10641 Andrew Burgess <andrew.burgess@embecosm.com>
10642 Tom Tromey <tom@tromey.com>
10643
10644 * common/scope-exit.h: New file.
10645
cf08fb29
PA
106462019-01-23 Pedro Alves <palves@redhat.com>
10647
10648 * common/preprocessor.h (ESC): Rename to ...
10649 (ESC_PARENS): ... this.
10650 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10651 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10652
ae73e2e2
TT
106532019-01-23 Tom Tromey <tom@tromey.com>
10654
10655 * language.h (class scoped_switch_to_sym_language_if_auto):
10656 Initialize m_lang in both cases.
10657
6594e122
AH
106582019-01-23 Alan Hayward <alan.hayward@arm.com>
10659
10660 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10661 with XCNEW.
10662
a7c9855d
TT
106632019-01-22 Tom Tromey <tom@tromey.com>
10664
10665 * corelow.c: Do not include sys/file.h.
10666
93cc1d53
TT
106672019-01-22 Tom Tromey <tom@tromey.com>
10668
10669 * tui/tui-wingeneral.h: Include gdb_curses.h.
10670
38561778
TT
106712019-01-22 Tom Tromey <tom@tromey.com>
10672
10673 * source-cache.h (class source_cache) <get_source_lines,
10674 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10675
37b3ab5b
TT
106762019-01-22 Tom Tromey <tom@tromey.com>
10677
10678 * remote-fileio.h (struct remote_target): Declare.
10679
3fabc016
TT
106802019-01-22 Tom Tromey <tom@tromey.com>
10681
10682 * python/py-arch.c: Do not include py-ref.h.
10683 * python/py-bpevent.c: Do not include py-ref.h.
10684 * python/py-cmd.c: Do not include py-ref.h.
10685 * python/py-continueevent.c: Do not include py-ref.h.
10686 * python/py-event.h: Do not include py-ref.h.
10687 * python/py-evtregistry.c: Do not include py-ref.h.
10688 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10689 * python/py-frame.c: Do not include py-ref.h.
10690 * python/py-framefilter.c: Do not include py-ref.h.
10691 * python/py-function.c: Do not include py-ref.h.
10692 * python/py-infevents.c: Do not include py-ref.h.
10693 * python/py-linetable.c: Do not include py-ref.h.
10694 * python/py-objfile.c: Do not include py-ref.h.
10695 * python/py-param.c: Do not include py-ref.h.
10696 * python/py-prettyprint.c: Do not include py-ref.h.
10697 * python/py-progspace.c: Do not include py-ref.h.
10698 * python/py-symbol.c: Do not include py-ref.h.
10699 * python/py-symtab.c: Do not include py-ref.h.
10700 * python/py-type.c: Do not include py-ref.h.
10701 * python/py-unwind.c: Do not include py-ref.h.
10702 * python/py-utils.c: Do not include py-ref.h.
10703 * python/py-value.c: Do not include py-ref.h.
10704 * python/py-varobj.c: Do not include py-ref.h.
10705 * python/py-xmethods.c: Do not include py-ref.h.
10706 * python/python.c: Do not include py-ref.h.
10707 * varobj.c: Do not include py-ref.h.
10708
6b4d7774
TT
107092019-01-22 Tom Tromey <tom@tromey.com>
10710
10711 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10712 keyword for bcache.
10713
7af7e9b5
TT
107142019-01-22 Tom Tromey <tom@tromey.com>
10715
10716 * compile/compile-cplus-types.c: Remove a comment by #include.
10717
951d1049
TT
107182019-01-22 Tom Tromey <tom@tromey.com>
10719
10720 * compile/gcc-c-plugin.h: Include compile-internal.h.
10721
d65d5705
TT
107222019-01-22 Tom Tromey <tom@tromey.com>
10723
10724 * stabsread.c (EXTERN): Do not define.
10725 (symnum, next_symbol_text_func, processing_gcc_compilation)
10726 (within_function, global_sym_chain, global_stabs)
10727 (previous_stab_code, this_object_header_files)
10728 (n_this_object_header_files)
10729 (n_allocated_this_object_header_files): Define.
10730 * stabsread.h (EXTERN): Never define. Use "extern".
10731
b6fb1ee5
PW
107322019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10733
10734 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10735 history_value.
10736
be6d4f74
TT
107372019-01-21 Tom Tromey <tom@tromey.com>
10738
10739 * ui-out.c: Fix includes.
10740 * tui/tui-source.c: Fix includes.
10741 * target.c: Fix includes.
10742 * remote.c: Fix includes.
10743 * regcache.c: Fix includes.
10744 * python/py-block.c: Fix includes.
10745 * printcmd.c: Fix includes.
10746 * or1k-tdep.c: Fix includes.
10747 * mi/mi-main.c: Fix includes.
10748 * m32r-tdep.c: Fix includes.
10749 * csky-tdep.c: Fix includes.
10750 * compile/compile-cplus-types.c: Fix includes.
10751 * cli/cli-interp.c: Fix includes.
10752
73021deb
AH
107532019-01-21 Alan Hayward <alan.hayward@arm.com>
10754
10755 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10756 for padding.
10757
7932255d
TT
107582019-01-16 Tom Tromey <tom@tromey.com>
10759
10760 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10761 earlier.
10762 (struct objfile) <msymbols_range>: Move from top level.
10763 <msymbols>: New method.
10764 (class objfile_msymbols): Remove.
10765 * symtab.c (default_collect_symbol_completion_matches_break_on):
10766 Update.
10767 * symmisc.c (dump_msymbols): Update.
10768 * stabsread.c (scan_file_globals): Update.
10769 * objc-lang.c (info_selectors_command, info_classes_command)
10770 (find_methods): Update.
10771 * minsyms.c (find_solib_trampoline_target): Update.
10772 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10773 * coffread.c (coff_symfile_read): Update.
10774 * ada-lang.c (ada_lookup_simple_minsym)
10775 (ada_collect_symbol_completion_matches): Update.
10776
604b1bfb
TT
107772019-01-16 Tom Tromey <tom@tromey.com>
10778
10779 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10780 type. Remove no-argument constructor.
10781 <iterator::operator++>: Simplify.
10782 <begin>: Update.
10783 <end>: Use minimal_symbol_count.
10784
f252c6d5
TT
107852019-01-16 Tom Tromey <tom@tromey.com>
10786
10787 * objfiles.h (struct objfile) <psymtabs>: New method.
10788 (class objfile_psymtabs): Remove.
10789 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10790 typedef.
10791 <range>: New method.
10792 (require_partial_symbols): Change return type.
10793 * psymtab.c (require_partial_symbols)
10794 (psym_expand_symtabs_matching): Update.
10795 * mdebugread.c (parse_partial_symbols): Update.
10796 * dbxread.c (dbx_end_psymtab): Update.
10797
b669c953
TT
107982019-01-15 Tom Tromey <tom@tromey.com>
10799
10800 * symtab.c (lookup_objfile_from_block)
10801 (lookup_symbol_in_objfile_symtabs)
10802 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10803 (find_line_symtab, info_sources_command)
10804 (default_collect_symbol_completion_matches_break_on)
10805 (make_source_files_completion_list): Update.
10806 * symmisc.c (print_objfile_statistics, dump_objfile)
10807 (maintenance_print_symbols, maintenance_info_symtabs)
10808 (maintenance_check_symtabs, maintenance_info_line_tables):
10809 Update.
10810 * source.c (select_source_symtab)
10811 (forget_cached_source_info_for_objfile): Update.
10812 * objfiles.h (class objfile_compunits): Remove.
10813 (struct objfile) <compunits_range>: New typedef.
10814 (compunits): New method.
10815 * objfiles.c (objfile_relocate1): Update.
10816 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10817 * maint.c (count_symtabs_and_blocks): Update.
10818 * linespec.c (iterate_over_all_matching_symtabs): Update.
10819 * cp-support.c (add_symbol_overload_list_qualified): Update.
10820 * coffread.c (coff_symtab_read): Update.
10821 * ada-lang.c (add_nonlocal_symbols)
10822 (ada_collect_symbol_completion_matches)
10823 (ada_add_global_exceptions): Update.
10824
7e955d83
TT
108252019-01-15 Tom Tromey <tom@tromey.com>
10826
10827 * progspace.h (program_space) <objfiles_safe_range>: New
10828 typedef.
10829 <objfiles_safe>: New method.
10830 * objfiles.h (class all_objfiles_safe): Remove.
10831 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10832 * jit.c (jit_inferior_exit_hook): Update.
10833
2030c079
TT
108342019-01-17 Tom Tromey <tom@tromey.com>
10835
10836 * progspace.h (program_space) <objfiles_range>: New typedef.
10837 <objfiles>: New method.
10838 <objfiles_head>: Rename from objfiles.
10839 (object_files): Update.
10840 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10841 * guile/scm-pretty-print.c
10842 (ppscm_find_pretty_printer_from_objfiles): Update.
10843 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10844 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10845 Update.
10846 * python/py-progspace.c (pspy_get_objfiles): Update.
10847 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10848 Update.
10849 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10850 (objfpy_lookup_objfile_by_build_id): Update.
10851 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10852 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10853 Update.
10854 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10855 (expand_symtab_containing_pc, lookup_objfile_from_block)
10856 (lookup_static_symbol, basic_lookup_transparent_type)
10857 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10858 (find_line_symtab, info_sources_command)
10859 (default_collect_symbol_completion_matches_break_on)
10860 (make_source_files_completion_list, find_main_name): Update.
10861 * symmisc.c (print_symbol_bcache_statistics)
10862 (print_objfile_statistics, maintenance_print_symbols)
10863 (maintenance_print_msymbols, maintenance_print_objfiles)
10864 (maintenance_info_symtabs, maintenance_check_symtabs)
10865 (maintenance_expand_symtabs, maintenance_info_line_tables):
10866 Update.
10867 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10868 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10869 (map_overlay_command, unmap_overlay_command)
10870 (simple_overlay_update, expand_symtabs_matching)
10871 (map_symbol_filenames): Update.
10872 * symfile-debug.c (set_debug_symfile): Update.
10873 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10874 Update.
10875 * source.c (select_source_symtab, forget_cached_source_info):
10876 Update.
10877 * solib.c (solib_read_symbols): Update.
10878 * solib-spu.c (append_ocl_sos): Update.
10879 * psymtab.c (maintenance_print_psymbols)
10880 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10881 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10882 * printcmd.c (info_symbol_command): Update.
10883 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10884 Update.
10885 * objfiles.h (class all_objfiles): Remove.
10886 * objfiles.c (have_partial_symbols, have_full_symbols)
10887 (have_minimal_symbols, qsort_cmp, update_section_map)
10888 (shared_objfile_contains_address_p)
10889 (default_iterate_over_objfiles_in_search_order): Update.
10890 * objc-lang.c (info_selectors_command, info_classes_command)
10891 (find_methods): Update.
10892 * minsyms.c (find_solib_trampoline_target): Update.
10893 * maint.c (maintenance_info_sections)
10894 (maintenance_translate_address, count_symtabs_and_blocks):
10895 Update.
10896 * main.c (captured_main_1): Update.
10897 * linux-thread-db.c (try_thread_db_load_from_pdir)
10898 (has_libpthread): Update.
10899 * linespec.c (iterate_over_all_matching_symtabs)
10900 (search_minsyms_for_name): Update.
10901 * jit.c (jit_find_objf_with_entry_addr): Update.
10902 * hppa-tdep.c (find_unwind_entry)
10903 (hppa_lookup_stub_minimal_symbol): Update.
10904 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10905 Update.
10906 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10907 (elf_gnu_ifunc_resolve_by_got): Update.
10908 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10909 * dwarf-index-write.c (save_gdb_index_command): Update.
10910 * cp-support.c (add_symbol_overload_list_qualified): Update.
10911 * breakpoint.c (create_overlay_event_breakpoint)
10912 (create_longjmp_master_breakpoint)
10913 (create_std_terminate_master_breakpoint)
10914 (create_exception_master_breakpoint): Update.
10915 * blockframe.c (find_pc_partial_function): Update.
10916 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10917 (ada_collect_symbol_completion_matches)
10918 (ada_add_global_exceptions): Update.
10919
776489e0
TT
109202019-01-17 Tom Tromey <tom@tromey.com>
10921
10922 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10923 declare VEC.
10924 (solib_target_parse_libraries): Change return type.
10925 (library_list_start_segment, library_list_start_section)
10926 (library_list_end_library, library_list_start_library); Update.
10927 (solib_target_free_library_list): Remove.
10928 (solib_target_parse_libraries): Remove cleanup. Change return
10929 type.
10930 (solib_target_current_sos): Update.
10931
6471e7d2
TT
109322019-01-17 Tom Tromey <tromey@bapiya>
10933
10934 * valprint.c: Replace "the the" with "the".
10935 * symtab.c: Replace "the the" with "the".
10936 * solib.c: Replace "the the" with "the".
10937 * solib-dsbt.c: Replace "the the" with "the".
10938 * linespec.c: Replace "the the" with "the".
10939 * dwarf2loc.h: Replace "the the" with "the".
10940 * amd64-windows-tdep.c: Replace "the the" with "the".
10941 * aarch64-tdep.c: Replace "the the" with "the".
10942
c24bdb02
KS
109432019-01-16 Keith Seitz <keiths@redhat.com>
10944
10945 PR gdb/23773
10946 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10947 <builder>: Rename to ..
10948 <m_builder>: ... this and make private.
10949 (dwarf2_cu::get_builder): New method. Change all users of
10950 `builder' to use this method.
10951 (dwarf2_start_symtab): Move to ...
10952 (dwarf2_cu::start_symtab): ... here. Update all callers
10953 (setup_type_unit_groups): Move to ...
10954 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10955 callers.
10956 (dwarf2_cu::reset_builder): New method.
10957 (process_full_compunit, process_full_type_unit): Use
10958 dwarf2_cu::reset_builder.
10959 (follow_die_offset): Record the ancestor CU if it is different
10960 from the followed DIE's CU.
10961 (follow_die_sig_1): Likewise.
10962
8d64371b
TT
109632019-01-15 Tom Tromey <tom@tromey.com>
10964
10965 * remote.c (class remote_state) <buf>: Now a char_vector.
10966 <buf_size>: Remove.
10967 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10968 parameter.
10969 (remote_target::getpkt_or_notif_sane_1)
10970 (remote_target::getpkt_sane)
10971 (remote_target::getpkt_or_notif_sane): Likewise.
10972 (class remote_target) <putpkt>: New overload.
10973 (remote_target::read_frame): Change type of "buf_p". Remove
10974 sizeof_p parameter.
10975 (packet_ok): New overload.
10976 (packet_check_result): New overload.
10977 Update all uses.
10978
bb277751
TT
109792019-01-14 Tom Tromey <tom@tromey.com>
10980
10981 * remote-notif.c (handle_notification, remote_notif_ack)
10982 (remote_notif_parse): Make "buf" const.
10983 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10984 const.
10985 (remote_notif_parse, remote_notif_ack, handle_notification):
10986 Likewise.
10987 * remote.c (remote_notif_stop_parse): Make "buf" const.
10988 (remote_target::remote_parse_stop_reply): Make "buf" const.
10989 (remote_notif_stop_ack): Make "buf" const.
10990
05be00a8
TT
109912019-01-14 Tom Tromey <tom@tromey.com>
10992
10993 * remote.c (remote_console_output): Make parameter const.
10994
491adeca
TT
109952019-01-14 Tom Tromey <tom@tromey.com>
10996
10997 * target-debug.h (target_debug_print_signals): Constify.
10998 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10999 * procfs.c (procfs_target::pass_signals): Update.
11000 * linux-nat.c (linux_nat_target::pass_signals): Update.
11001 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11002 * target-delegates.c: Rebuild.
11003 * remote.c (remote_target::program_signals): Update.
11004 (remote_target::pass_signals): Update.
11005 * target.c (target_pass_signals): Constify argument.
11006 (target_program_signals): Likewise.
11007 * target.h (struct target_ops) <pass_signals, program_signals>:
11008 Constify argument.
11009 (target_pass_signals, target_program_signals): Constify argument.
11010
bbd94648
TT
110112019-01-14 Tom Tromey <tom@tromey.com>
11012
11013 PR tui/28819:
11014 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11015
6f072a10
PFC
110162019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11017
11018 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11019 field.
11020 * rs6000-tdep.c: Include reggroups.h.
11021 (IS_V_ALIAS_PSEUDOREG): Define.
11022 (rs6000_register_name): Return names for the "vX" aliases.
11023 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11024 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11025 aliases. Call default_register_reggroup_p for all other
11026 pseudo-registers.
11027 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11028 New functions.
11029 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11030 Handle "vX" aliases.
11031 (v_alias_pseudo_register_collect): New function.
11032 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11033 (rs6000_gdbarch_init): Initialize "vX" aliases as
11034 pseudo-registers. Restore registration of
11035 rs6000_pseudo_register_reggroup_p with
11036 set_tdesc_pseudo_register_reggroup_p.
11037
1a782351
MF
110382019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11039
11040 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11041 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11042 set_gdbarch_num_pseudo_regs.
11043
d73cff18
PW
110442019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11045
11046 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11047 Remove arg prefixname, add do_set and do_show.
11048 Add member functions set_list and show_list.
11049 * cli/cli-style.c (class cli_style_option): Update accordingly.
11050 (style_set_list): Move to file scope.
11051 (style_show_list): Likewise.
11052 (set_style): Call help_list.
11053 (show_style): Call cmd_show_list.
11054 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11055 Update to use the new macro.
11056
60a90376
JB
110572019-10-12 Joel Brobecker <brobecker@adacore.com>
11058
11059 * ada-lang.c (_initialize_ada_language): Expand the help text
11060 for the "catch exception" command.
11061
9d7c67bf
PW
110622019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11063
11064 * symtab.c (matching_obj_sections): Initialize obj,
11065 declare it closer to its usage.
11066
7cf47dc4
TT
110672019-01-10 Tom Tromey <tom@tromey.com>
11068
11069 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11070 (basic_inf_threads_range): Remove.
11071 (inf_threads_range, inf_non_exited_threads_range)
11072 (safe_inf_threads_range): Use next_adapter.
11073
d3cb6808
KS
110742019-01-10 Keith Seitz <keiths@redhat.com>
11075
11076 PR gdb/23712
11077 PR symtab/23010
11078 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11079 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11080
63a20375
KS
110812019-01-10 Keith Seitz <keiths@redhat.com>
11082
11083 PR gdb/23712
11084 PR symtab/23010
11085 * dictionary.c (pending_to_vector): Remove.
11086 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11087 Remove _1 suffix, replacing functions of the same name. Update
11088 all callers.
11089 (dict_create_hashed, dict_create_hashed_expandable)
11090 (dict_create_linear, dict_create_linear_expandable, dict_free)
11091 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11092 Make functions static.
11093
b026f593
KS
110942019-01-10 Keith Seitz <keiths@redhat.com>
11095
11096 PR gdb/23712
11097 PR symtab/23010
11098 * dictionary.h (struct dictionary): Replace declaration with
11099 multidictionary.
11100 (dict_create_hashed, dict_create_hashed_expandable)
11101 (dict_create_linear, dict_create_linear_expandable)
11102 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11103 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11104 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11105 taking multidictionary argument.
11106 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11107 * block.h (struct block) <dict>: Change to multidictionary
11108 and rename `multidict'.
11109 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11110 symmisc.c: Update all dictionary references to multidictionary.
11111
c7748ee9
KS
111122019-01-10 Keith Seitz <keiths@redhat.com>
11113
11114 PR gdb/23712
11115 PR symtab/23010
11116 * dictionary.c: Include unordered_map.
11117 (pending_to_vector): New function.
11118 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11119 Rewrite the non-"_1" functions to take vector instead
11120 of linked list.
11121 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11122 "new" _1 versions of the same name.
11123 (multidictionary): Define.
11124 (std::hash<enum language): New definition.
11125 (collate_pending_symbols_by_language, mdict_create_hashed)
11126 (mdict_create_hashed_expandable, mdict_create_linear)
11127 (mdict_create_linear_expandable, mdict_free)
11128 (find_language_dictionary, create_new_language_dictionary)
11129 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11130 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11131 (mdict_size, mdict_empty): New functions.
11132 * dictionary.h (mdict_iterator): Define.
11133
67aa1f3c
PA
111342019-01-10 Pedro Alves <palves@redhat.com>
11135
11136 * breakpoint.c (read_uploaded_action)
11137 (create_tracepoint_from_upload): Adjust to use
11138 gdb::unique_xmalloc_ptr.
11139 * ctf.c (ctf_write_uploaded_tp):
11140 (SET_ARRAY_FIELD): Use emplace_back.
11141 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11142 * tracefile-tfile.c (tfile_write_uploaded_tp):
11143 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11144 gdb::unique_xmalloc_ptr.
11145 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11146 at_string, cond_string, cmd_strings>: Replace char pointers
11147 with gdb::unique_xmalloc_ptr.
11148
2f667667
PA
111492019-01-10 Pedro Alves <palves@redhat.com>
11150
11151 * solib-target.c (library_list_start_library): Don't xstrdup name.
11152
36cb7237
PA
111532019-01-10 Pedro Alves <palves@redhat.com>
11154
11155 * mdebugread.c (parse_partial_symbols): Use
11156 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11157
da584958
AB
111582019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11159
11160 * linux-fork.c (scoped_switch_fork_info)
11161 <~scoped_switch_fork_info>: Fix incorrect variable name.
11162
1ef8573c
AB
111632019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11164
11165 * linux-fork.c (scoped_switch_fork_info)
11166 <scoped_switch_fork_info>: Make explicit.
11167 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11168
8d7bcccb
TT
111692019-01-10 Tom Tromey <tom@tromey.com>
11170
11171 * objfiles.h (objfile::reset_psymtabs): Update.
11172 * objfiles.c (objfile::objfile): Update.
11173 * psymtab.h (psymtab_storage::obstack): Update.
11174 (psymtab_storage::m_obstack): Use gdb::optional.
11175 (class psymtab_storage): Update comment. Remove objfile
11176 parameter.
11177 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11178
b596a3c7
TT
111792019-01-10 Tom Tromey <tom@tromey.com>
11180
11181 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11182 <free_psymtabs>: Now private.
11183 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11184 (allocate_psymtab): Use new method.
11185
a9342b62
TT
111862019-01-10 Tom Tromey <tom@tromey.com>
11187
11188 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11189 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11190 * mdebugread.c (parse_partial_symbols): Use
11191 allocate_dependencies.
11192 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11193 allocate_dependencies.
11194 (process_psymtab_comp_unit_reader)
11195 (build_type_psymtab_dependencies): Likewise.
11196 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11197
5af70966
TT
111982019-01-10 Tom Tromey <tom@tromey.com>
11199
11200 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11201 PSYMBOL_SET_LANGUAGE.
11202 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11203
5923a04c
TT
112042019-01-10 Tom Tromey <tom@tromey.com>
11205
11206 * psymtab.h (psymtab_storage::obstack): New method.
11207 <m_obstack>: Rename from obstack; now private.
11208 * psymtab.c (psymtab_storage): Update.
11209 * dwarf2read.c (create_addrmap_from_index)
11210 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11211 Update.
11212
6d6a12bf
TT
112132019-01-10 Tom Tromey <tom@tromey.com>
11214
11215 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11216 * objfiles.h (objfile::reset_psymtabs): New method.
11217
d320c2b5
TT
112182019-01-10 Tom Tromey <tom@tromey.com>
11219
11220 * symmisc.c (print_symbol_bcache_statistics): Update.
11221 (print_objfile_statistics): Update.
11222 * symfile.c (reread_symbols): Update.
11223 * psymtab.h (class psymtab_storage): New.
11224 * psymtab.c (psymtab_storage): New constructor.
11225 (~psymtab_storage): New destructor.
11226 (require_partial_symbols): Update.
11227 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11228 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11229 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11230 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11231 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11232 (start_psymtab_common, end_psymtab_common)
11233 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11234 (allocate_psymtab): Update.
11235 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11236 Update.
11237 (dump_psymtab_addrmap, maintenance_print_psymbols)
11238 (maintenance_check_psymtabs): Update.
11239 (class objfile_psymtabs): Move to objfiles.h.
11240 * psympriv.h (discard_psymtab): Now inline.
11241 (psymtab_discarder::psymtab_discarder): Update.
11242 (psymtab_discarder::~psymtab_discarder): Update.
11243 (ALL_OBJFILE_PSYMTABS): Rewrite.
11244 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11245 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11246 Remove fields.
11247 <partial_symtabs>: New field.
11248 (class objfile_psymtabs): Move from psymtab.h. Update.
11249 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11250 psymbol_cache.
11251 (objfile::~objfile): Don't destroy psymbol_cache.
11252 * mdebugread.c (parse_partial_symbols): Update.
11253 * dwarf2read.c (create_addrmap_from_index)
11254 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11255 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11256 (add_partial_subprogram, dwarf2_ranges_read): Update.
11257 * dwarf-index-write.c (write_address_map)
11258 (write_one_signatured_type, recursively_write_psymbols)
11259 (class debug_names, class debug_names, write_psymtabs_to_index):
11260 Update.
11261
1d94a5a3
TT
112622019-01-10 Tom Tromey <tom@tromey.com>
11263
11264 * symtab.h (SYMBOL_SET_NAMES): Update.
11265 (symbol_set_names): Update.
11266 (MSYMBOL_SET_NAMES): Update.
11267 * symtab.c (symbol_set_names): Change argument to be an
11268 objfile_per_bfd_storage.
11269 * psymtab.c (add_psymbol_to_bcache): Update.
11270 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11271
0f14768a
TT
112722019-01-10 Tom Tromey <tom@tromey.com>
11273
11274 * symtab.c (create_demangled_names_hash): Change argument to be an
11275 objfile_per_bfd_storage.
11276 (symbol_set_names): Update.
11277
6eee24ce
TT
112782019-01-10 Tom Tromey <tom@tromey.com>
11279
11280 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11281 init_psymbol_list.
11282 * psymtab.c (init_psymbol_list): Do nothing if already called.
11283 * psympriv.h (init_psymbol_list): Add comment.
11284 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11285 init_psymbol_list.
11286 * dbxread.c (dbx_symfile_read): Unconditionally call
11287 init_psymbol_list.
11288
75aedd27
TT
112892019-01-10 Tom Tromey <tom@tromey.com>
11290
11291 * xcoffread.c (scan_xcoff_symtab): Update.
11292 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11293 "where".
11294 * mdebugread.c (parse_partial_symbols)
11295 (handle_psymbol_enumerators): Update.
11296 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11297 * dbxread.c (read_dbx_symtab): Update.
11298 * psympriv.h (psymbol_placement): New enum.
11299 (add_psymbol_to_list): Update.
11300
939652a5
TT
113012019-01-10 Tom Tromey <tom@tromey.com>
11302
11303 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11304 static_psymbols parameters.
11305 (scan_xcoff_symtab): Update.
11306 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11307 static_psymbols parameters.
11308 * psympriv.h (start_psymtab_common): Update.
11309 * mdebugread.c (parse_partial_symbols): Update.
11310 * dwarf2read.c (create_partial_symtab): Update.
11311 * dbxread.c (read_dbx_symtab): Update.
11312 (start_psymtab): Remove global_psymbols and static_psymbols
11313 parameters.
11314
baa62830
TT
113152019-01-10 Tom Tromey <tom@tromey.com>
11316
11317 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11318 * psymtab.c (allocate_psymtab): Add comment.
11319 * psympriv.h (allocate_psymtab): Add comment.
11320 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11321 initializations.
11322 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11323
0e8f53ba
TT
113242019-01-10 Tom Tromey <tom@tromey.com>
11325
11326 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11327 Don't declare.
11328 * mipsread.c: Include mdebugread.h.
11329 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11330 Declare.
11331 * elfread.c: Include mdebugread.h.
11332
b22a7c6a
TT
113332019-01-09 Tom Tromey <tom@tromey.com>
11334
11335 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11336 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11337 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11338 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11339 (psym_lookup_symbol, psym_find_last_source_symtab)
11340 (psym_forget_cached_source_info, psym_print_stats)
11341 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11342 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11343 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11344 (psym_find_compunit_symtab_by_address)
11345 (maintenance_print_psymbols, maintenance_info_psymtabs)
11346 (maintenance_check_psymtabs): Use ranged for.
11347 * psymtab.h (class objfile_psymtabs): New.
11348 (require_partial_symbols): Return objfile_psymtabs.
11349 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11350
3b9d3ac2
TT
113512019-01-09 Tom Tromey <tom@tromey.com>
11352
11353 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11354 (find_pc_mapped_section, list_overlays_command)
11355 (map_overlay_command, unmap_overlay_command)
11356 (simple_overlay_update): Use all_objfiles.
11357 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11358 * printcmd.c (info_symbol_command): Use all_objfiles.
11359 * objfiles.h (ALL_OBJSECTIONS): Remove.
11360 * maint.c (maintenance_translate_address): Use all_objfiles.
11361 * gcore.c (gcore_create_callback): Use all_objfiles.
11362 (objfile_find_memory_regions): Likewise.
11363
8b31193a
TT
113642019-01-09 Tom Tromey <tom@tromey.com>
11365
11366 * symtab.c (find_line_symtab, info_sources_command)
11367 (make_source_files_completion_list): Use objfile_compunits.
11368 * source.c (select_source_symtab): Use objfile_compunits.
11369 * objfiles.h (struct objfile): Update comment.
11370 (ALL_OBJFILES): Remove.
11371 (ALL_FILETABS): Remove.
11372 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11373 objfile_compunits.
11374
d5da8b3c
TT
113752019-01-09 Tom Tromey <tom@tromey.com>
11376
11377 * symmisc.c (print_objfile_statistics, dump_objfile)
11378 (maintenance_print_symbols): Use compunit_filetabs.
11379 * source.c (forget_cached_source_info_for_objfile): Use
11380 compunit_filetabs.
11381 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11382 (ALL_FILETABS): Use compunit_filetabs.
11383 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11384 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11385
5accd1a0
TT
113862019-01-09 Tom Tromey <tom@tromey.com>
11387
11388 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11389 (compunit_filetabs): New.
11390 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11391 compunit_filetabs.
11392 (info_sources_command, make_source_files_completion_list): Remove
11393 declaration.
11394 * symmisc.c (print_objfile_statistics, dump_objfile)
11395 (maintenance_print_symbols): Remove declaration.
11396 (maintenance_info_symtabs): Use compunit_filetabs.
11397 (maintenance_info_line_tables): Likewise.
11398 * source.c (select_source_symtab): Change local variable name.
11399 (forget_cached_source_info_for_objfile): Remove declaration.
11400 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11401 * objfiles.c (objfile_relocate1): Remove declaration.
11402 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11403 declaration.
11404 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11405 * coffread.c (coff_symtab_read): Remove declaration.
11406 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11407 compunit_filetabs.
11408
d8aeb77f
TT
114092019-01-09 Tom Tromey <tom@tromey.com>
11410
11411 * symtab.c (lookup_objfile_from_block)
11412 (find_pc_sect_compunit_symtab, search_symbols)
11413 (default_collect_symbol_completion_matches_break_on): Use
11414 objfile_compunits.
11415 * objfiles.h (ALL_COMPUNITS): Remove.
11416 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11417 * cp-support.c (add_symbol_overload_list_qualified): Use
11418 objfile_compunits.
11419 * ada-lang.c (ada_collect_symbol_completion_matches)
11420 (ada_add_global_exceptions): Use objfile_compunits.
11421
592553c4
TT
114222019-01-09 Tom Tromey <tom@tromey.com>
11423
11424 * source.c (select_source_symtab)
11425 (forget_cached_source_info_for_objfile): Remove declaration.
11426 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11427 declaration.
11428 * maint.c (count_symtabs_and_blocks): Remove declaration.
11429 * cp-support.c (add_symbol_overload_list_qualified): Remove
11430 declaration.
11431 * coffread.c (coff_symtab_read): Remove declaration.
11432 * symtab.c (lookup_symbol_in_objfile_symtabs)
11433 (basic_lookup_transparent_type_1): Use objfile_compunits.
11434 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11435 (info_sources_command, search_symbols)
11436 (default_collect_symbol_completion_matches_break_on)
11437 (make_source_files_completion_list): Remove declaration.
11438 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11439 (ada_collect_symbol_completion_matches)
11440 (ada_add_global_exceptions): Remove declaration.
11441 * linespec.c (iterate_over_all_matching_symtabs): Use
11442 objfile_compunits.
11443 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11444 (class objfile_compunits): New.
11445 (ALL_COMPUNITS): Use objfile_compunits.
11446 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11447 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11448 objfile_compunits.
11449 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11450
5325b9bf
TT
114512019-01-09 Tom Tromey <tom@tromey.com>
11452
11453 * symtab.c (search_symbols)
11454 (default_collect_symbol_completion_matches_break_on): Use
11455 objfile_msymbols.
11456 * ada-lang.c (ada_lookup_simple_minsym)
11457 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11458 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11459 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11460 objfile_msymbols.
11461 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11462 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11463 * objc-lang.c (find_methods): Use objfile_msymbols.
11464 (info_selectors_command, info_classes_command): Likewise.
11465 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11466 * objfiles.h (class objfile_msymbols): New.
11467 (ALL_OBJFILE_MSYMBOLS): Remove.
11468 (ALL_MSYMBOLS): Remove.
11469
cac85af2
TT
114702019-01-09 Tom Tromey <tom@tromey.com>
11471
11472 * common/next-iterator.h (next_adapter): Add Iterator template
11473 parameter.
11474 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11475 (class all_objfiles_safe): New.
11476 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11477 * objfiles.c (put_objfile_before): Update comment.
11478 (add_separate_debug_objfile): Likewise.
11479 (free_all_objfiles): Use all_objfiles_safe.
11480 (objfile_purge_solibs): Likewise.
11481
aed57c53
TT
114822019-01-09 Tom Tromey <tom@tromey.com>
11483
11484 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11485 (expand_symtab_containing_pc, lookup_static_symbol)
11486 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11487 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11488 all_objfiles.
11489 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11490 * breakpoint.c (create_overlay_event_breakpoint)
11491 (create_longjmp_master_breakpoint)
11492 (create_std_terminate_master_breakpoint)
11493 (create_exception_master_breakpoint): Use all_objfiles.
11494 * linux-thread-db.c (try_thread_db_load_from_pdir)
11495 (has_libpthread): Use all_objfiles.
11496 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11497 * linespec.c (iterate_over_all_matching_symtabs)
11498 (search_minsyms_for_name): Use all_objfiles.
11499 * maint.c (maintenance_info_sections): Use all_objfiles.
11500 * main.c (captured_main_1): Use all_objfiles.
11501 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11502 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11503 * guile/scm-pretty-print.c
11504 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11505 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11506 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11507 (maintenance_print_msymbols): Use all_objfiles.
11508 * source.c (select_source_symtab): Use all_objfiles.
11509 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11510 * symfile.c (remove_symbol_file_command)
11511 (expand_symtabs_matching, map_symbol_filenames): Use
11512 all_objfiles.
11513 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11514 all_objfiles.
11515 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11516 * objc-lang.c (find_methods): Use all_objfiles.
11517 * objfiles.c (have_partial_symbols, have_full_symbols)
11518 (have_minimal_symbols, qsort_cmp)
11519 (default_iterate_over_objfiles_in_search_order): Use
11520 all_objfiles.
11521 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11522 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11523 (maintenance_check_psymtabs): Use all_objfiles.
11524 (ALL_PSYMTABS): Remove.
11525 * compile/compile-object-run.c (do_module_cleanup): Use
11526 all_objfiles.
11527 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11528 * cp-support.c (add_symbol_overload_list_qualified): Use
11529 all_objfiles.
11530 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11531 Use all_objfiles.
11532 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11533 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11534 all_objfiles.
11535 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11536 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11537 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11538 Uses all_objfiles.
11539 * solib.c (solib_read_symbols): Use all_objfiles
11540
99d89cde
TT
115412019-01-09 Tom Tromey <tom@tromey.com>
11542
11543 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11544 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11545 all_objfiles.
11546 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11547 * symmisc.c (print_symbol_bcache_statistics)
11548 (print_objfile_statistics, maintenance_print_objfiles)
11549 (maintenance_info_symtabs, maintenance_check_symtabs)
11550 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11551 all_objfiles.
11552 * source.c (forget_cached_source_info): Use all_objfiles.
11553 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11554 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11555 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11556 * objfiles.c (update_section_map): Use all_objfiles.
11557 (shared_objfile_contains_address_p): Likewise.
11558 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11559 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11560
21708325
TT
115612019-01-09 Tom Tromey <tom@tromey.com>
11562
11563 * common/next-iterator.h: New file.
11564 * objfiles.h (class all_objfiles): New.
11565 (struct objfile_iterator): New.
11566
669e09f6
PW
115672019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11568
11569 * NEWS: Move the description of the changed "frame", "select-frame",
11570 and "info frame" commands to the Changed commands section.
11571
041be526
SM
115722019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11573
11574 * gdbtypes.c (check_stub_method_group): Remove handling of old
11575 mangling schemes.
11576 * linespec.c (find_methods): Likewise.
11577 * stabsread.c (read_member_functions): Likewise.
11578 * valops.c (search_struct_method): Likewise.
11579 (value_struct_elt_for_reference): Likewise.
11580 * NEWS: Mention this change.
11581
0e2a2133
AB
115822019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11583
11584 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11585 print_source_lines.
11586 * source.c (print_source_lines_base): Update line number check.
11587 (print_source_lines): New function.
11588 (source_lines_range::source_lines_range): New function.
11589 * source.h (class source_lines_range): New class.
11590 (print_source_lines): New declaration.
11591
1055a3b4
PW
115922019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11593
11594 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11595
cfeadda5
TT
115962019-01-08 Tom Tromey <tom@tromey.com>
11597 Simon Marchi <simon.marchi@ericsson.com>
11598
11599 PR gdb/24060
11600 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11601 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11602 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11603 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11604 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11605 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11606
583068ca
AB
116072019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11608
11609 * source.c (select_source_symtab): Move header comment to
11610 declaration in source.h.
11611 (forget_cached_source_info_for_objfile): Likewise.
11612 (forget_cached_source_info): Likewise.
11613 (identify_source_line): Likewise.
11614 * source.h (identify_source_line): Move declaration from symtab.h
11615 and add comment from source.c
11616 (print_source_lines): Likewise.
11617 (forget_cached_source_info_for_objfile): Likewise.
11618 (forget_cached_source_info): Likewise.
11619 (select_source_symtab): Likewise.
11620 (enum print_source_lines_flag): Move definition from symtab.h.
11621 * symtab.h (identify_source_line): Move declaration to source.h.
11622 (print_source_lines): Likewise.
11623 (forget_cached_source_info_for_objfile): Likewise.
11624 (forget_cached_source_info): Likewise.
11625 (select_source_symtab): Likewise.
11626 (enum print_source_lines_flag): Move definition to source.h.
11627 * tui/tui-hooks.c: Add 'source.h' include.
11628
ec98a4ad
AB
116292019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11630
11631 * source.c (print_source_lines_base): Handle requests to print
11632 reverse line number sequences, and guard against empty lines
11633 string.
11634
62ea19c1
AB
116352019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11636
11637 * source.c (print_source_lines_base): Fix skip of '\r' if next
11638 character is '\n'.
11639
9d30e1fd
TT
116402019-01-06 Tom Tromey <tom@tromey.com>
11641
11642 * c-exp.y (struct c_parse_state) <macro_original_text,
11643 expansion_obstack>: New member.
11644 (macro_original_text, expansion_obstack): Remove globals.
11645 (scan_macro_expansion, scanning_macro_expansion)
11646 (finished_macro_expansion): Update.
11647 (scan_macro_cleanup): Remove.
11648 (yylex, c_parse): Update.
11649
c65bac38
TT
116502019-01-06 Tom Tromey <tom@tromey.com>
11651
11652 * c-exp.y (struct c_parse_state) <strings>: New member.
11653 (operator_stoken): Update.
11654
02e12e38
TT
116552019-01-06 Tom Tromey <tom@tromey.com>
11656
11657 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11658 (union type_stack_elt) <typelist_val>: Now a pointer to
11659 std::vector.
11660 (type_stack_cleanup): Don't declare.
11661 (push_typelist): Update.
11662 * parse.c (pop_typelist): Return a std::vector.
11663 (push_typelist): Take a std::vector.
11664 (follow_types): Update. Do not free args.
11665 (type_stack_cleanup): Remove.
11666 * c-exp.y (struct c_parse_state): New.
11667 (cpstate): New global.
11668 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11669 (nonempty_typelist): Update.
11670 (func_mod): Create a new vector.
11671 (c_parse): Create a c_parse_state.
11672 (check_parameter_typelist): Do not delete params.
11673 (function_method): Update. Do not delete type_list.
11674
f097f5ad
TT
116752019-01-06 Tom Tromey <tom@tromey.com>
11676
11677 PR gdb/28155:
11678 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11679 check_typedef.
11680 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11681 (print_return_value): Likewise.
11682
d2adf9f1
TT
116832019-01-05 Tom Tromey <tom@tromey.com>
11684
11685 * contrib/cleanup_check.py: Remove.
11686 * contrib/gcc-with-excheck: Remove.
11687 * contrib/exsummary.py: Remove.
11688 * contrib/excheck.py: Remove.
11689
2eab46b1
JB
116902019-01-05 Joel Brobecker <brobecker@adacore.com>
11691
11692 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11693 NULL. Initialize tpprev to NULL instead of assigning it
11694 to NULL on the next statement.
11695 * windows-nat.c (windows_delete_thread): Remove check for
11696 main_thread_id before printing thread exit notifications.
11697 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11698 Remove thread ID check against main_thread_id.
11699 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11700 windows_delete_thread.
11701 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11702
48c5e7e2
TT
117032019-01-04 Tom Tromey <tom@tromey.com>
11704
11705 * compile/compile.c (_initialize_compile): Use upper case for
11706 metasyntactic variables.
11707 * symmisc.c (_initialize_symmisc): Use upper case for
11708 metasyntactic variables.
11709 * psymtab.c (_initialize_psymtab): Use upper case for
11710 metasyntactic variables.
11711 * demangle.c (demangle_command): Use upper case for metasyntactic
11712 variables.
11713 (_initialize_demangler): Likewise.
11714 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11715 variables.
11716
986041cd
TT
117172019-01-03 Tom Tromey <tom@tromey.com>
11718
11719 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11720
7c711119
TT
117212019-01-03 Tom Tromey <tom@tromey.com>
11722
11723 * python/py-symtab.c (salpy_str): Update.
11724 (struct salpy_sal_object) <symtab>: Now a PyObject.
11725 (salpy_dealloc): Update.
11726 (del_objfile_sal): Use gdbpy_ref.
11727
1b20edf0
TT
117282019-01-03 Tom Tromey <tom@tromey.com>
11729
11730 * python/py-type.c (convert_field): Use new_reference. Return
11731 gdbpy_ref.
11732 (make_fielditem): Return gdbpy_ref.
11733 (typy_fields): Update.
11734 (typy_getitem): Update.
11735 (field_name): Return gdbpy_ref. Use new_reference.
11736 (typy_iterator_iternext): Update.
11737
ea41325b
TT
117382019-01-03 Tom Tromey <tom@tromey.com>
11739
11740 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11741
2a3c71d6
TT
117422019-01-03 Tom Tromey <tom@tromey.com>
11743
11744 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11745 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11746 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11747 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11748 (pspy_set_type_printers): Likewise.
11749 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11750 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11751 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11752 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11753 (objfpy_set_type_printers): Likewise.
11754
5c329e6a
TT
117552019-01-03 Tom Tromey <tom@tromey.com>
11756
11757 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11758 (gdbpy_print_stack): Use gdbpy_err_fetch.
11759 * python/python-internal.h (class gdbpy_err_fetch): New class.
11760 (class gdbpy_enter) <m_error_type, m_error_value,
11761 m_error_traceback>: Remove.
11762 <m_error>: New member.
11763 (gdbpy_exception_to_string): Don't declare.
11764 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11765 * python/py-value.c (convert_value_from_python): Use
11766 gdbpy_err_fetch.
11767 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11768 gdbpy_exception_to_string.
11769 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11770 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11771 gdbpy_err_fetch.
11772
169bb27b
AB
117732019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11774
11775 * linux-nat.c (delete_lwp_cleanup): Delete.
11776 (struct lwp_deleter): New struct.
11777 (lwp_info_up): New typedef.
11778 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11779 lwp_info_up.
11780
a07c8880
AB
117812019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11782
11783 * linux-fork.c (class scoped_switch_fork_info): New class.
11784 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11785
26089c49
AB
117862019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11787
11788 * valops.c (find_overload_match): Remove use of null_cleanup, and
11789 calls to do_cleanups.
11790
06d3e5b0
AB
117912019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11792
11793 * compile/compile-cplus-types.c
11794 (compile_cplus_instance::decl_name): Handle changes to
11795 cp_func_name.
11796 * cp-support.c (cp_func_name): Update header comment, update
11797 return type.
11798 * cp-support.h (cp_func_name): Update return type in declaration.
11799 * valops.c (find_overload_match): Move temp_func local to top
11800 level of function and change its type. Use temp_func to hold and
11801 delete temporary string obtained from cp_func_name.
11802
66644cd3
AB
118032019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11804
11805 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11806 gdb::char_vector, remove cleanup, and update uses of `msg`.
11807
592d8c0a
JW
118082019-01-03 Jim Wilson <jimw@sifive.com>
11809
11810 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11811
c55d06ec
TT
118122019-01-02 Tom Tromey <tom@tromey.com>
11813
11814 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11815 (tdesc_parse_xml): Remove cleanups.
11816 * target-descriptions.h (make_cleanup_free_target_description):
11817 Don't declare.
11818 (target_desc_deleter): New struct.
11819 (target_desc_up): New typedef.
11820 * target-descriptions.c (target_desc_deleter::operator()): Rename
11821 from free_target_description.
11822 (make_cleanup_free_target_description): Remove.
11823
3a6ae42d
TT
118242019-01-02 Tom Tromey <tom@tromey.com>
11825
11826 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11827 constructor, destructor.
11828 (linespec_parser): Remove typedef.
11829 (~linespec_parser): Rename from linespec_parser_delete.
11830 (linespec_lex_to_end, linespec_complete_label)
11831 (linespec_complete): Update.
11832 (decode_line_full): Remove cleanups.
11833 (decode_line_1): Update.
11834
61fd3e73
TT
118352019-01-02 Tom Tromey <tom@tromey.com>
11836
11837 * python/python-internal.h (inferior_to_inferior_object): Change
11838 return type.
11839 * python/py-exitedevent.c (create_exited_event_object): Update.
11840 * python/py-inferior.c (inferior_to_inferior_object): Return
11841 gdbpy_ref.
11842 (python_new_inferior, python_inferior_deleted)
11843 (thread_to_thread_object, delete_thread_object)
11844 (build_inferior_list, gdbpy_selected_inferior): Update.
11845 * python/py-infthread.c (create_thread_object): Update. Also fail
11846 if inferior_to_inferior_object fails.
11847
d20172fc
SM
118482019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11849
11850 * inferior.h (class inferior) <displaced_step_state>: New field.
11851 * infrun.h (struct displaced_step_state): Move here from
11852 infrun.c. Initialize fields, add constructor.
11853 <inf>: Remove field.
11854 <reset>: New method.
11855 * infrun.c (struct displaced_step_inferior_state): Move to
11856 infrun.h.
11857 (displaced_step_inferior_states): Remove.
11858 (get_displaced_stepping_state): Adust.
11859 (displaced_step_in_progress_any_inferior): Adjust.
11860 (displaced_step_in_progress_thread): Adjust.
11861 (displaced_step_in_progress): Adjust.
11862 (add_displaced_stepping_state): Remove.
11863 (get_displaced_step_closure_by_addr): Adjust.
11864 (remove_displaced_stepping_state): Remove.
11865 (infrun_inferior_exit): Call displaced_step_state.reset.
11866 (use_displaced_stepping): Don't check for NULL.
11867 (displaced_step_prepare_throw): Call
11868 get_displaced_stepping_state.
11869 (displaced_step_fixup): Don't check for NULL.
11870 (prepare_for_detach): Don't check for NULL.
11871
e3319240
PW
118722019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11873
11874 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11875 in case of call that did not complete.
11876
5d36dfb9
AU
118772019-01-02 Andrey Utkin <autkin@undo.io>
11878
11879 * symfile.c (find_separate_debug_file): Fix search of debug files for
11880 remote debuggee.
11881
8833fbf0
TT
118822019-01-02 Tom Tromey <tom@tromey.com>
11883
11884 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11885 indentation.
11886 * python/py-frame.c (frapy_older): Remove cast.
11887 (frapy_newer): Likewise.
11888 * python/py-breakpoint.c (local_setattro): Remove cast.
11889 * python/py-arch.c (archpy_name): Remove local variable.
11890 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11891
4ada3dfd
JB
118922019-01-02 Joel Brobecker <brobecker@adacore.com>
11893
11894 * unittests/basic_string_view/element_access/char/empty.cc:
11895 Fix year range in copyright header.
11896
113b7b81
AB
118972019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11898
11899 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11900 Delete.
11901 <operator==>: Update with for removed field.
11902 <hash>: Likewise.
11903 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11904 <isa_features>: ...this.
11905 <abi_features>: New field.
11906 (riscv_isa_flen): Update comment.
11907 (riscv_abi_xlen): New declaration.
11908 (riscv_abi_flen): New declaration.
11909 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11910 isa_features.
11911 (riscv_abi_xlen): New function.
11912 (riscv_isa_flen): Update to get answer from isa_features.
11913 (riscv_abi_flen): New function.
11914 (riscv_has_fp_abi): Update to get answer from abi_features.
11915 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11916 xlen and flen.
11917 (riscv_call_info) <xlen, flen>: Update comment.
11918 (riscv_call_arg_struct): Remove invalid assertions
11919 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11920 is removed.
11921 (riscv_gdbarch_init): Gather isa features and abi features
11922 separately, ensure both match on the gdbarch when reusing an old
11923 gdbarch. Relax an error check to allow 32-bit abi float to run on
11924 a target with 64-bit float hardware.
11925
b18ca514
PW
119262019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11927
11928 * source.c (search_command_helper): Stop reverse search
11929 when line 1 has been searched.
11930
ec70d8db
PW
119312019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11932
11933 * record-full.c (record_full_base_target::close): Rewrite
11934 record_full_core_buf_list free logic.
11935
5b38f9c1
PW
119362019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11937
11938 * break-catch-syscall.c (print_one_catch_syscall): xfree
11939 the last text.
11940
66d91b39
JB
119412019-01-01 Joel Brobecker <brobecker@adacore.com>
11942
11943 * top.c (print_gdb_version): Update Copyright year in version
11944 message.
11945
42a4f53d
JB
119462019-01-01 Joel Brobecker <brobecker@adacore.com>
11947
11948 Update copyright year range in all GDB files.
11949
7e955d83 119502019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11951
5bbd631d 11952 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11953
5bbd631d 11954For older changes see ChangeLog-2018.
c906108c
SS
11955\f
11956Local Variables:
11957mode: change-log
11958left-margin: 8
11959fill-column: 74
11960version-control: never
57da7796 11961coding: utf-8
c906108c 11962End:
5bbd631d 11963