]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Factor out the code to do the datadir-relocation for gdbinit
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
9224a013
CB
12019-09-11 Christian Biesinger <cbiesinger@google.com>
2
3 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4 out of get_init_files.
5 (get_init_files): Update.
6
f48cd836
CB
72019-09-11 Christian Biesinger <cbiesinger@google.com>
8
9 * main.c (get_init_files): Change to use std::string.
10 (captured_main_1): Update.
11 (print_gdb_help): Update.
12
9cab7ecd
AT
132019-09-11 Ali Tamur <tamur@google.com>
14
15 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
16 implementation.
17
67547d89
CB
182019-09-11 Christian Biesinger <cbiesinger@google.com>
19
20 * dbxread.c (read_dbx_symtab): Update.
21 * dwarf2read.c (load_partial_dies): Update.
22 * mdebugread.c (parse_partial_symbols): Update.
23 (handle_psymbol_enumerators): Update.
24 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
25 * psymtab.c (add_psymbol_to_bcache): Likewise.
26 (add_psymbol_to_list): Likewise.
27 * symtab.c (symbol_set_names): Likewise.
28 * symtab.h (symbol_set_names): Likewise.
29 * xcoffread.c (scan_xcoff_symtab): Update.
30
64b2d4a0
TT
312019-09-11 Tom Tromey <tom@tromey.com>
32
33 * symfile-mem.c (symbol_file_add_from_memory): Use
34 bfd_set_filename.
35 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
36 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
37
3b00ef10
TT
382019-09-10 Tom Tromey <tromey@adacore.com>
39
40 * dwarf-index-write.c (write_psymbols): Extend error message.
41 (debug_names::insert): Add Ada code.
42 (debug_names::write_psymbols): Remove Ada check.
43 (debug_names) <m_string_obstack>: New member.
44 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
45 (gdb_index_symbol_name_matcher::matches): Remove.
46 (mapped_index_base::find_name_components_bounds): Add "lang"
47 parameter.
48 (mapped_index_base::build_name_components): Also split names
49 according to Ada syntax.
50 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
51 type of "match_callback".
52 (check_match, check_find_bounds_finds)
53 (dw2_expand_symtabs_matching): Update.
54 (dw2_debug_names_iterator): Add new constructor.
55 (dw2_debug_names_map_matching_symbols): New function.
56 (dw2_debug_names_expand_symtabs_matching): Update.
57 (dwarf2_debug_names_functions): Use
58 dw2_debug_names_map_matching_symbols.
59
aa391654
TT
602019-09-10 Tom Tromey <tromey@adacore.com>
61
62 * dwarf2read.c (dw2_get_file_names_reader): Add the
63 CU's file name to the results.
64
b054970d
TT
652019-09-10 Tom Tromey <tromey@adacore.com>
66
67 * ada-lang.c (add_nonlocal_symbols): Combine calls to
68 map_matching_symbols. Update.
69 * dwarf2read.c (dw2_map_matching_symbols): Update.
70 * psymtab.c (match_partial_symbol): Change type; update.
71 (psym_map_matching_symbols): Likewise.
72 * symfile-debug.c (debug_qf_map_matching_symbols): Change
73 type; update.
74 * symfile.h (struct quick_symbol_functions)
75 <map_matching_symbols>: Change "name" to be a lookup_name_info.
76 Remove "match".
77
6a3dbf1b
TT
782019-09-10 Tom Tromey <tromey@adacore.com>
79
80 * psymtab.c (map_block): Remove.
81 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
82 * symtab.c (iterate_over_symbols_terminated): New function.
83 * symtab.c (iterate_over_symbols_terminated): Declare.
84
6969f124
TT
852019-09-10 Tom Tromey <tromey@adacore.com>
86
87 * ada-lang.c (ada_iterate_over_symbols): Return bool.
88 * language.h (struct language_defn) <la_iterate_over_symbols>:
89 Return bool.
90 * symtab.c (iterate_over_symbols): Return bool.
91 * symtab.h (iterate_over_symbols): Return bool.
92
199b4314
TT
932019-09-10 Tom Tromey <tromey@adacore.com>
94
95 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
96 (add_nonlocal_symbols): Update.
97 * dwarf2read.c (dw2_map_matching_symbols): Change type.
98 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
99 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
100 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
101 Change type of "callback". Remove "data".
102
a084a2a6
AT
103
1042019-09-09 Ali Tamur <tamur@google.com>
105
106 * dwarf2read.c (comp_unit_head): Update comment.
107 (dwarf2_dwo_name): New function declaration.
108 (dwarf_unit_type_name): New function declaration.
109 (read_comp_unit_head): Add support for new compilation units,
110 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
111 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
112 (currently named as "signature") in their header. Also clarify error
113 messages.
114 (lookup_dwo_id): New function. Returns the dwo id of the given
115 compile unit.
116 (lookup_dwo_unit): Use the new lookup_dwo_id function.
117 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
118 functions.
119 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
120 (dwarf2_dwo_name): Get the dwo name if present.
121 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
122 purposes.
123
25a2915e
TT
1242019-09-09 Tom Tromey <tom@tromey.com>
125
126 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
127
e4df0874
PW
1282019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
129
130 * python/python.c (do_start_initialization): Make progname_copy static,
131 to avoid a leak report.
132
8634b462
TT
1332019-09-08 Tom Tromey <tom@tromey.com>
134
135 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
136
c7f839cb
SM
1372019-09-07 Simon Marchi <simon.marchi@efficios.com>
138
139 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
140 Change type to gdb::optional<block_enum>.
141 (dw2_symtab_iter_init): Change block_index parameter type
142 to gdb::optional<block_enum>.
143 (dw2_lookup_symbol): Change block_index parameter
144 type to block_enum.c
145 (dw2_debug_names_lookup_symbol): Likewise.
146 * psymtab.c (psym_lookup_symbol): Likewise.
147 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
148 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
149 Likewise.
150
ead0e69a
CB
1512019-09-06 Christian Biesinger <cbiesinger@google.com>
152
153 * defs.h (relocate_gdb_directory): Change int to bool in
154 signature and rename flag to relocatable.
155 * main.c (relocate_path): Likewise.
156 (relocate_gdb_directory): Likewise.
157
b16c44de
AM
1582019-09-06 Alan Modra <amodra@gmail.com>
159
160 * coffread.c (coff_symfile_read): Constify filename variable.
161 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
162 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
163 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
164 * solib.c (reload_shared_libraries_1): Likewise.
165 * symfile.c (reread_symbols): Likewise.
166 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
167 * solib-darwin.c (darwin_bfd_open): Likewise.
168 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
169
06ff036e
AB
1702019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
171
172 * psymtab.c (print_partial_symbols): Handle missing domain_enum
173 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
174
4e962e74
TT
1752019-09-03 Tom Tromey <tromey@adacore.com>
176
177 * ada-valprint.c (ada_val_print_num): Don't recurse for range
178 types.
179 (has_negatives): Unbias a range type bound.
180 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
181 * gdbtypes.c (operator==): Handle new field.
182 (create_range_type): Add "bias" parameter.
183 (create_static_range_type, resolve_dynamic_range): Update.
184 * gdbtypes.h (struct range_bounds) <bias>: New member.
185 (create_range_type): Add bias parameter.
186 * printcmd.c (print_scalar_formatted): Unbias range types.
187 * value.c (unpack_long): Unbias range types.
188 (pack_long): Bias range types.
189
d90b8f26
AH
1902019-09-02 Alan Hayward <alan.hayward@arm.com>
191
192 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
193 probe arguments.
194
fe01123e
AH
1952019-09-02 Alan Hayward <alan.hayward@arm.com>
196
197 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
198 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
199 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
200 (compile_probe_arg): Likewise.
201 * probe.h (get_argument_count): Likewise.
202 * solib-svr4.c (solib_event_probe_action): Likewise.
203 * stap-probe.c (stap_probe::get_argument_count): Likewise.
204
e661ef01
AH
2052019-09-02 Alan Hayward <alan.hayward@arm.com>
206
207 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
208 code to here...
209 (svr4_create_solib_event_breakpoints): ...from here.
210
47a536d9
SDJ
2112019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
212
213 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
214 suffix from warning message.
215
d6a00eba
TT
2162019-08-30 Tom Tromey <tom@tromey.com>
217
218 * tui/tui-winsource.h (struct tui_source_window_base)
219 <refresh_all>: Don't declare.
220 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
221 Remove.
222 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
223 tui_show_locator_content.
224 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
225 declare.
226 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
227 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
228 declare.
229
55b2657b
TT
2302019-08-30 Tom Tromey <tom@tromey.com>
231
232 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
233
12a8555a
TT
2342019-08-30 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-stack.c (_initialize_tui_stack): Move later.
237 Remove unnecessary forward declarations.
238
900ac242
TT
2392019-08-30 Tom Tromey <tom@tromey.com>
240
241 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
242 rerender.
243 (tui_update_locator_fullname, tui_show_frame_info): Don't call
244 tui_show_locator_content.
245
99ab33fb
TT
2462019-08-30 Tom Tromey <tom@tromey.com>
247
248 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
249 (tui_locator_window::rerender): Rewrite using body of previous
250 tui_show_locator_content.
251
e594a5d1
TT
2522019-08-30 Tom Tromey <tom@tromey.com>
253
254 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
255 set_locator_fullname>: New methods.
256 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
257 Rename from tui_set_locator_fullname.
258 (tui_locator_window::set_locator_info): Rename from
259 tui_set_locator_info. Return bool.
260 (tui_update_locator_fullname, tui_show_frame_info): Update.
261
715bb467
TT
2622019-08-30 Tom Tromey <tom@tromey.com>
263
264 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
265
772f3f03
TT
2662019-08-30 Tom Tromey <tom@tromey.com>
267
268 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
269 call touchwin.
270
108e13ab
TT
2712019-08-30 Tom Tromey <tom@tromey.com>
272
273 * tui/tui-wingeneral.c (box_win): Assume win_info and
274 win_info->handle cannot be NULL.
275
cdaa6eb4
TT
2762019-08-30 Tom Tromey <tom@tromey.com>
277
278 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
279 refresh_window>: Declare.
280 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
281 resize.
282 (tui_data_item_window::rerender): Rename from
283 tui_display_register.
284 (tui_data_item_window::refresh_window): New method.
285 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
286 no-op.
287
89df7f90
TT
2882019-08-30 Tom Tromey <tom@tromey.com>
289
290 * tui/tui-regs.h (struct tui_data_window) <regs_content,
291 regs_column_count, current_group>: Move later. Now private.
292 <get_current_group>: New method.
293 * tui/tui-regs.c (tui_reg_command): Update.
294 * tui/tui-layout.c (tui_set_layout): Update.
295
1bf2866a
TT
2962019-08-30 Tom Tromey <tom@tromey.com>
297
298 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
299 (tui_data_window::rerender): Don't call
300 check_and_display_highlight_if_needed.
301 (tui_data_window::refresh_all): Remove call to
302 erase_data_content.
303
0670413d
TT
3042019-08-30 Tom Tromey <tom@tromey.com>
305
306 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
307 (tui_data_window::display_registers_from)
308 (tui_data_window::display_reg_element_at_line)
309 (tui_data_window::display_registers_from_line): Remove checks of
310 "empty".
311
18bb55c7
TT
3122019-08-30 Tom Tromey <tom@tromey.com>
313
314 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
315 Don't declare.
316 * tui/tui-regs.c (tui_data_window::show_registers): Call
317 rerender.
318 (tui_data_window::rerender): Rename from display_all_data.
319 (tui_data_window::rerender): Remove old implementation.
320
1f6d2f10
TT
3212019-08-30 Tom Tromey <tom@tromey.com>
322
323 * tui/tui-regs.c (tui_data_window::display_all_data): Change
324 text.
325 * tui/tui-data.h (NO_DATA_STRING): Remove define.
326
16d01f9c
BW
3272019-08-29 Bernhard Wodok <barto@gmx.net>
328 Sergio Durigan Junior <sergiodj@redhat.com>
329
330 PR win32/24284
331 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
332
d8f27c60
AB
3332019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
334
335 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
336 when searching for types.
337
1f20c35e
AB
3382019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
339
340 * f-lang.c (f_language_defn): Use f_print_typedef.
341 * f-lang.h (f_print_typedef): Declare.
342 * f-typeprint.c (f_print_typedef): Define.
343
550105b7
CB
3442019-08-27 Christian Biesinger <cbiesinger@google.com>
345
346 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
347
4acfdd20
AB
3482019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
349
350 * cli/cli-utils.c (info_print_options_defs): Delete.
351 (make_info_print_options_def_group): Delete.
352 (extract_info_print_options): Delete.
353 (info_print_command_completer): Delete.
354 (info_print_args_help): Add extra parameter, and optionally
355 include text about -n flag.
356 * cli/cli-utils.h (struct info_print_options): Delete.
357 (extract_info_print_options): Delete declaration.
358 (info_print_command_completer): Delete declaration.
359 (info_print_args_help): Add extra parameter, extend header
360 comment.
361 * python/python.c (gdbpy_rbreak): Pass additional parameter to
362 search_symbols.
363 * stack.c (struct info_print_options): New type.
364 (info_print_options_defs): New file scoped variable.
365 (make_info_print_options_def_group): New static function.
366 (info_print_command_completer): New static function.
367 (info_locals_command): Update to use new local functions.
368 (info_args_command): Likewise.
369 (_initialize_stack): Add extra parameter to calls to
370 info_print_args_help.
371 * symtab.c (search_symbols): Add extra parameter, use this to
372 possibly excluse non-debug symbols.
373 (symtab_symbol_info): Add extra parameter, which is passed on to
374 search_symbols.
375 (struct info_print_options): New type.
376 (info_print_options_defs): New file scoped variable.
377 (make_info_print_options_def_group): New static function.
378 (info_print_command_completer): New static function.
379 (info_variables_command): Update to use local functions, and pass
380 extra parameter through to symtab_symbol_info.
381 (info_functions_command): Likewise.
382 (info_types_command): Pass additional argument through to
383 symtab_symbol_info.
384 (rbreak_command): Pass extra argument to search_symbols.
385 (_initialize_symtab): Add extra arguments for calls to
386 info_print_args_help, and update help text for 'info variables',
387 'whereis', and 'info functions' commands.
388 * symtab.h (search_symbols): Add extra argument to declaration.
389 * NEWS: Mention new flags.
390
9aa55206
CB
3912019-08-26 Christian Biesinger <cbiesinger@google.com>
392
393 * symtab.c (lookup_static_symbol): Call the new function (and move
394 it down to be next to lookup_global_symbol).
395 (struct global_sym_lookup_data): Add block_enum member and rename to...
396 (struct global_or_static_sym_lookup_data): ...this.
397 (lookup_symbol_global_iterator_cb): Pass block_index instead of
398 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
399 (lookup_symbol_global_or_static_iterator_cb): ...this.
400 (lookup_global_or_static_symbol): New function.
401 (lookup_global_symbol): Call new function.
402
5c31b358
TV
4032019-08-26 Tom de Vries <tdevries@suse.de>
404
405 PR c++/24852
406 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
407 when pc_probe.prob == NULL.
408
23c13d42
SM
4092019-08-25 Simon Marchi <simon.marchi@efficios.com>
410
411 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
412 variable symbol_linkage to symbol_linkage_.
413
beadd3e8
SM
4142019-08-25 Simon Marchi <simon.marchi@efficios.com>
415
416 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
417 represent whether the symbol is static, dynamic, or we don't
418 know.
419
e3ec872f
YS
4202019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
421
422 * gdb/rx-tdep.c (rx_register_names): New.
423 (rx_register_name): Delete.
424 (rx_psw_type): Delete.
425 (rx_fpsw_type): Delete.
426 (rx_register_type): Delete.
427 (rx_gdbarch_init): Convert target-descriptions.
428 (_initialize_rx_tdep): Add initialize_tdesc_rx.
429 * gdb/features/Makefile: Add rx.xml.
430 * gdb/features/rx.xml: New.
431 * gdb/features/rx.c: Generated.
432 * gdb/NEWS: Mention target description support.
433
d0509ba4
CB
4342019-08-22 Christian Biesinger <cbiesinger@google.com>
435
436 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
437 *slot_ptr.
438
2d41fa11
SDJ
4392019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
440
441 * configure.ac: Don't check for 'dlfcn.h' (moved to
442 gdbsupport/common.m4).
443 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
444 'gdbsupport/'.
445 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
446 * compile/compile-c-support.c: Include
447 'gdbsupport/gdb-dlfcn.h'.
448 * gdbsupport/common.m4: Check for 'dlfcn.h'.
449 * gdb-dlfcn.c: Move to...
450 * gdbsupport/gdb-dlfcn.c: ... here.
451 * gdb-dlfcn.h: Move to...
452 * gdbsupport/gdb-dlfcn.h: ... here.
453
de8af808
SL
4542019-08-23 Sandra Loosemore <sandra@codesourcery.com>
455
456 * nios2-tdep.c (struct reg_value): Improve comments. Make
457 the offset field signed.
458
27204489
CB
4592019-08-22 Christian Biesinger <cbiesinger@google.com>
460
461 * python/lib/gdb/__init__.py (_execute_file): New function.
462 * python/python.c (python_run_simple_file): Call gdb._execute_file
463 on Windows.
464
43771869
AB
4652019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
466
467 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
468 all uses as this was never set to anything but a zero value.
469
26c957f1
PA
4702019-08-21 Bogdan Harjoc <harjoc@gmail.com>
471
472 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
473
c07aae6e
CB
4742019-08-21 Christian Biesinger <cbiesinger@google.com>
475
476 * tui/tui-data.h (tui_gen_win_info): Add an =default
477 move constructor, required by some GCC versions.
478
3960cb7a
JF
4792019-08-21 Jinke Fan <fanjinke51@yeah.net>
480
481 * go32-nat.c (go32_sysinfo): Add hygon_p.
482
04c72a68
TT
4832019-08-20 Tom Tromey <tom@tromey.com>
484
485 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
486 line_from_reg_element_no, first_reg_element_no_inline,
487 display_all_data, delete_data_content_windows,
488 erase_data_content>: Now private.
489
072272ce
TT
4902019-08-20 Tom Tromey <tom@tromey.com>
491
492 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
493 (tui_unhighlight_win, tui_highlight_win)
494 (tui_win_info::make_window): Update.
495 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
496
973961bd
TT
4972019-08-20 Tom Tromey <tom@tromey.com>
498
499 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
500 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
501 (MAX_PID_WIDTH): Move to tui-stack.c.
502 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
503 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
504 (MAX_PID_WIDTH): Move from tui-data.h.
505
ab0e1f1a
TT
5062019-08-20 Tom Tromey <tom@tromey.com>
507
508 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
509 * tui/tui-wingeneral.c (box_win): Change type of win_info.
510 (box_win): Update.
511 (tui_gen_win_info::make_window): Rename from tui_make_window.
512 (tui_win_info::make_window): New method.
513 (tui_gen_win_info::make_visible): Update.
514 * tui/tui-source.c (tui_source_window::set_contents): Update.
515 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
516 (tui_data_window::display_registers_from): Update.
517 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
518 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
519 Declare.
520 <can_box>: Remove.
521 <title>: Remove.
522 (struct tui_win_info) <make_window>: Declare.
523 <can_box>: Now virtual.
524 <title>: New member.
525 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
526 * tui/tui-command.c (tui_cmd_window::resize): Update.
527
100c2bf3
TT
5282019-08-20 Tom Tromey <tom@tromey.com>
529
530 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
531 * tui/tui-regs.c (tui_data_window::show_registers): Update.
532 (tui_data_window::check_register_values): Update.
533
fa4dc567
TT
5342019-08-20 Tom Tromey <tom@tromey.com>
535
536 * tui/tui-regs.h (struct tui_data_window): Use
537 DISABLE_COPY_AND_ASSIGN.
538 <regs_content>: Change type, removing unique_ptr.
539 <tui_data_window>: Add move constructor.
540 * tui/tui-regs.c (tui_data_window::show_registers)
541 (tui_data_window::show_register_group)
542 (tui_data_window::display_registers_from)
543 (tui_data_window::display_registers_from)
544 (tui_data_window::first_data_item_displayed)
545 (tui_data_window::delete_data_content_windows)
546 (tui_data_window::rerender, tui_data_window::refresh_window)
547 (tui_data_window::check_register_values): Update.
548
ca02d7c8
TT
5492019-08-20 Tom Tromey <tom@tromey.com>
550
551 * tui/tui-regs.h (struct tui_data_window) <show_registers,
552 show_register_group>: Declare.
553 (tui_show_register_group): Don't declare.
554 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
555 tui_show_registers.
556 (tui_data_window::show_register_group): Rename from
557 tui_show_register_group.
558 (tui_data_window::check_register_values, tui_reg_command):
559 Update.
560 * tui/tui-layout.c (tui_set_layout): Update.
561
63356bfd
TT
5622019-08-20 Tom Tromey <tom@tromey.com>
563
564 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
565 Declare.
566 (tui_check_register_values): Don't declare.
567 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
568 from tui_check_register_values.
569 * tui/tui-hooks.c (tui_register_changed): Update.
570
42cc14a7
TT
5712019-08-20 Tom Tromey <tom@tromey.com>
572
573 * tui/tui-regs.c (tui_reg_layout): Move later.
574 (tui_show_registers): Don't enable TUI mode or change layout.
575
b9ad3686
TT
5762019-08-20 Tom Tromey <tom@tromey.com>
577
578 * tui/tui-regs.h (struct tui_data_item_window)
579 <~tui_data_item_window>: Remove.
580 <content>: Now a unique_xmalloc_ptr.
581 * tui/tui-regs.c (tui_register_format): Return a
582 unique_xmalloc_ptr.
583 (tui_get_register): Update.
584 (~tui_data_item_window): Remove.
585 (tui_data_window::display_registers_from, tui_display_register):
586 Update.
587 * tui/tui-io.h (tui_expand_tabs): Update.
588 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
589 Remove "col" parameter.
590
8e114aab
TT
5912019-08-20 Tom Tromey <tom@tromey.com>
592
593 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
594 field.
595 * tui/tui-regs.c (~tui_data_item_window): Update.
596
1a4f81dd
TT
5972019-08-20 Tom Tromey <tom@tromey.com>
598
599 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
600 earlier.
601
0f8d8876
TT
6022019-08-20 Tom Tromey <tom@tromey.com>
603
604 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
605
605dc2c2
TT
6062019-08-20 Tom Tromey <tom@tromey.com>
607
608 * tui/tui-source.h (struct tui_source_window): Update.
609 * tui/tui-regs.c (tui_show_registers): Update.
610 * tui/tui-disasm.h (struct tui_disasm_window): Update.
611 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
612 (NO_REGS_STRING): Remove defines.
613
aedbe3bb
CM
6142019-08-20 Conrad Meyer <cem@FreeBSD.org>
615
616 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
617 unnecessary thread walk if remote doesn't support the packet.
618
7ce8f214
TT
6192019-08-19 Tom Tromey <tromey@adacore.com>
620
621 * python/py-value.c (value_has_field): Fix indentation.
622
f21c2bd7
TT
6232019-08-19 Tom Tromey <tromey@adacore.com>
624
625 * printcmd.c (do_one_display, info_display_command): Update.
626 * block.h (contained_in): Return bool. Add allow_nested
627 parameter.
628 * block.c (contained_in): Return bool. Add allow_nested
629 parameter.
630
d806ea2d
TT
6312019-08-19 Tom Tromey <tom@tromey.com>
632
633 * configure: Rebuild.
634 * configure.ac: Disallow the combination of -static-libstdc++ and
635 source highlight.
636 * source-cache.c (get_language_name): Handle rust.
637 (source_cache::get_source_lines): Ignore highlighting exceptions.
638
398fdd60
TT
6392019-08-16 Tom Tromey <tom@tromey.com>
640
641 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
642 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
643 (struct tui_source_window_base) <make_visible, refresh_window,
644 resize>: Remove methods.
645 <execution_info>: Remove field.
646 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
647 (tui_show_source_line, tui_source_window_base)
648 (~tui_source_window_base): Update.
649 (tui_source_window_base::resize)
650 (tui_source_window_base::make_visible)
651 (tui_source_window_base::refresh_window): Remove.
652 (tui_source_window_base::update_exec_info): Update.
653 * tui/tui-source.c (tui_source_window::set_contents): Update.
654 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
655
e699d331
TT
6562019-08-16 Tom Tromey <tom@tromey.com>
657
658 * tui/tui-hooks.c (tui_remove_hooks): Don't set
659 deprecated_query_hook.
660
bb01dbfc
TT
6612019-08-16 Tom Tromey <tom@tromey.com>
662
663 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
664 (tui_update_source_windows_with_line): Update.
665 * tui/tui-source.h (struct tui_source_window)
666 <show_symtab_source>: Declare.
667 (tui_show_symtab_source): Don't declare.
668 * tui/tui-source.c (tui_show_symtab_source): Rename from
669 tui_show_symtab_source.
670
81c82c4b
TT
6712019-08-16 Tom Tromey <tom@tromey.com>
672
673 * tui/tui-winsource.h (struct tui_source_window_base)
674 <set_contents>: Declare.
675 * tui/tui-winsource.c
676 (tui_source_window_base::update_source_window_as_is): Update.
677 * tui/tui-source.h (struct tui_source_window) <set_contents>:
678 Declare.
679 (tui_set_source_content): Don't declare.
680 * tui/tui-source.c (tui_source_window::set_contents): Rename from
681 tui_set_source_content.
682 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
683 Declare.
684 (tui_set_disassem_content): Don't declare.
685 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
686 tui_set_disassem_content.
687
2ddaf614
TT
6882019-08-16 Tom Tromey <tom@tromey.com>
689
690 * tui/tui-winsource.h (struct tui_source_window_base)
691 <update_breakpoint_info>: Declare.
692 (tui_update_breakpoint_info): Don't declare.
693 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
694 (tui_update_all_breakpoint_info): Update.
695 (tui_source_window_base::update_breakpoint_info): Rename from
696 tui_update_breakpoint_info.
697 (tui_source_window_base::update_exec_info): Update.
698
017f9828
TT
6992019-08-16 Tom Tromey <tom@tromey.com>
700
701 * tui/tui-winsource.h (struct tui_source_window_base)
702 <update_source_window>: Declare.
703 (tui_update_source_window): Don't declare.
704 * tui/tui-winsource.c
705 (tui_source_window_base::update_source_window): Rename from
706 tui_update_source_window.
707 (tui_source_window_base::rerender): Update.
708 * tui/tui-source.c (tui_source_window::maybe_update): Update.
709 * tui/tui-disasm.c (tui_show_disassem)
710 (tui_show_disassem_and_update_source)
711 (tui_disasm_window::maybe_update): Update.
712
ed8358e9
TT
7132019-08-16 Tom Tromey <tom@tromey.com>
714
715 * tui/tui-winsource.h (struct tui_source_window_base)
716 <update_source_window_as_is>: Declare.
717 (tui_update_source_window_as_is): Don't declare.
718 * tui/tui-winsource.c (tui_update_source_window): Update
719 (tui_source_window_base::update_source_window_as_is): Rename from
720 tui_update_source_window_as_is.
721 (tui_source_window_base::refill): Update.
722 * tui/tui-source.c (tui_show_symtab_source): Update.
723 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
724 Update.
725
20149b6b
TT
7262019-08-16 Tom Tromey <tom@tromey.com>
727
728 * tui/tui-winsource.h (tui_update_source_window)
729 (tui_update_source_window_as_is): Remove "noerror" parameter.
730 * tui/tui-winsource.c (tui_update_source_window)
731 (tui_update_source_window_as_is): Remove "noerror" parameter.
732 (tui_update_source_windows_with_addr)
733 (tui_update_source_windows_with_line)
734 (tui_source_window_base::rerender)
735 (tui_source_window_base::refill): Update.
736 * tui/tui-source.h (tui_set_source_content)
737 (tui_show_symtab_source): Remove "noerror" parameter.
738 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
739 parameter.
740 (tui_show_symtab_source): Likewise.
741 (tui_source_window::maybe_update): Update.
742 * tui/tui-disasm.c (tui_show_disassem)
743 (tui_show_disassem_and_update_source)
744 (tui_disasm_window::do_scroll_vertical)
745 (tui_disasm_window::maybe_update): Update.
746
2d83e710
TT
7472019-08-16 Tom Tromey <tom@tromey.com>
748
749 * tui/tui.c (tui_is_window_visible): Update.
750 * tui/tui-wingeneral.c (tui_make_window)
751 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
752 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
753 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
754 (tui_set_win_height_command, parse_scrolling_args): Update.
755 * tui/tui-source.c (tui_source_window::style_changed): Update.
756 * tui/tui-regs.c (tui_show_registers)
757 (tui_data_window::first_data_item_displayed)
758 (tui_data_window::delete_data_content_windows)
759 (tui_check_register_values, tui_reg_command): Update.
760 * tui/tui-disasm.c (tui_show_disassem): Update.
761 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
762 method.
763 <is_visible>: Remove field.
764 * tui/tui-data.c (tui_next_win, tui_prev_win)
765 (tui_delete_invisible_windows): Update.
766
d4ab829a
TT
7672019-08-16 Tom Tromey <tom@tromey.com>
768
769 * tui/tui-winsource.h (struct tui_source_window_base)
770 <m_has_locator>: Remove.
771 * tui/tui-layout.c (show_source_disasm_command, show_data)
772 (show_source_or_disasm_and_command): Update.
773
aa7ca1bb
AH
7742019-08-16 Alan Hayward <alan.hayward@arm.com>
775
776 * NEWS (Other MI changes): New subsection.
777 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
778 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
779 * arch-utils.c (default_get_pc_address_flags): New function.
780 * arch-utils.h (default_get_pc_address_flags): New declaration.
781 * gdbarch.sh: Add get_pc_address_flags.
782 * gdbarch.c: Regenerate.
783 * gdbarch.h: Likewise.
784 * stack.c (print_pc): New function.
785 (print_frame_info) (print_frame): Call print_pc.
786
6eac171f
TV
7872019-08-16 Tom de Vries <tdevries@suse.de>
788
789 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
790 print_objfile_section_info.
791
3df505f6
TT
7922019-08-15 Tom Tromey <tom@tromey.com>
793
794 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
795 calling update_cmdwin_start_line.
796 * tui/tui-winsource.h (struct tui_source_window_base)
797 <do_make_visible_with_new_height, set_new_height>: Don't declare.
798 <rerender>: Declare.
799 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
800 Call rerender.
801 (tui_source_window_base::set_new_height): Remove.
802 (tui_source_window_base::rerender): Rename from
803 do_make_visible_with_new_height.
804 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
805 resize method.
806 (tui_win_info::make_invisible_and_set_new_height)
807 (tui_win_info::make_visible_with_new_height): Remove.
808 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
809 Declare.
810 * tui/tui-stack.c (tui_locator_window::rerender): New method.
811 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
812 do_make_visible_with_new_height>: Don't declare.
813 <rerender>: Declare.
814 * tui/tui-regs.c (tui_data_window::rerender): Rename from
815 set_new_height.
816 (tui_data_window::do_make_visible_with_new_height): Remove.
817 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
818 call tui_show_locator_content.
819 (tui_gen_win_info::resize): Call rerender.
820 (show_source_or_disasm_and_command): Don't call
821 tui_show_locator_content.
822 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
823 method.
824 (struct tui_win_info) <rerender>: Declare.
825 <set_new_height, make_invisible_and_set_new_height,
826 make_visible_with_new_height>: Don't declare.
827 * tui/tui-data.c (tui_win_list::rerender): New method.
828 * tui/tui-command.h (struct tui_cmd_window)
829 <do_make_visible_with_new_height>: Don't declare.
830 * tui/tui-command.c
831 (tui_cmd_window::do_make_visible_with_new_height): Remove.
832
272560b5
TT
8332019-08-15 Tom Tromey <tromey@adacore.com>
834
835 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
836 * ada-lang.c (ada_enum_name): Likewise.
837
08235187
CB
8382019-08-15 Christian Biesinger <cbiesinger@google.com>
839
840 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
841 leading underscore.
842 (GdbOutputErrorFile): Likewise.
843 (global scope): Adjust constructor calls to GdbOutput{,Error}File
844 accordingly.
845 (execute_unwinders): Rename to have a leading underscore.
846 (auto_load_packages): Likewise.
847 (global scope): Adjust call to auto_load_packages accordingly.
848 (GdbSetPythonDirectory): Likewise.
849 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
850 instead of execute_unwinders.
851
db502012
TT
8522019-08-15 Tom Tromey <tom@tromey.com>
853
854 * tui/tui-layout.c (show_layout, show_source_disasm_command)
855 (show_data): Don't change window visibility.
856 (tui_gen_win_info::resize): Remove special case for command
857 window. Use wresize, when available.
858 (show_source_or_disasm_and_command): Don't change window
859 visibility.
860 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
861 <make_visible>: New method.
862 * tui/tui-command.c (tui_cmd_window::resize): New method.
863
3891b65e
TT
8642019-08-15 Tom Tromey <tom@tromey.com>
865
866 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
867 (struct tui_source_windows): New.
868 * tui/tui-winsource.c (tui_display_main): Update.
869 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
870 (new_height_ok, parse_scrolling_args): Update.
871 * tui/tui-layout.c (show_layout, show_data): Update.
872 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
873 (tui_add_to_source_windows): Don't declare.
874 * tui/tui-data.c (source_windows, tui_source_windows)
875 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
876
ee556432
TT
8772019-08-15 Tom Tromey <tom@tromey.com>
878
879 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
880 Rename from reset.
881 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
882 * tui/tui-layout.c (show_source_disasm_command, show_data):
883 Update.
884 (tui_gen_win_info::resize): Rename.
885 (show_source_or_disasm_and_command): Update.
886 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
887 reset.
888
46f438e3
TT
8892019-08-15 Tom Tromey <tom@tromey.com>
890
891 * tui/tui-stack.c (tui_initialize_static_data): Remove.
892 * tui/tui-interp.c (tui_interp::init): Don't call
893 tui_initialize_static_data.
894 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
895
f4ce562c
TT
8962019-08-15 Tom Tromey <tom@tromey.com>
897
898 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
899 examine tui_win_list.
900
c398c3d0
TT
9012019-08-15 Tom Tromey <tom@tromey.com>
902
903 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
904 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
905 tui_clear_source_content.
906 (tui_clear_source_content): Remove.
907 (tui_source_window_base::do_erase_source_content): Hoist call to
908 content.clear().
909 * tui/tui-stack.c (tui_show_frame_info): Don't call
910 tui_clear_source_content.
911
e25d2004
TT
9122019-08-15 Tom Tromey <tom@tromey.com>
913
914 * tui/tui-winsource.h (struct tui_source_window_base)
915 <do_erase_source_content>: New method.
916 <erase_source_content>: New method.
917 (tui_erase_source_content): Don't declare.
918 * tui/tui-winsource.c (tui_clear_source_content): Update.
919 (tui_source_window_base::do_erase_source_content): Rename from
920 tui_erase_source_content.
921 (tui_source_window_base::show_source_content): Update.
922 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
923 * tui/tui-source.h (struct tui_source_window)
924 <erase_source_content>: New method.
925 * tui/tui-disasm.h (struct tui_disasm_window)
926 <erase_source_content>: New method.
927
002f15c2
TT
9282019-08-15 Tom Tromey <tom@tromey.com>
929
930 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
931 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
932 constructor.
933 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
934 * tui/tui-source.c (tui_set_source_content): Update.
935 * tui/tui-disasm.c (tui_set_disassem_content): Update.
936
c9033fe8
TT
9372019-08-15 Tom Tromey <tom@tromey.com>
938
939 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
940 * tui/tui-winsource.c (tui_line_is_displayed): Move to
941 tui-source.c.
942 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
943 Declare.
944 * tui/tui-source.c (tui_source_window::line_is_displayed): New
945 method.
946 (tui_source_window::maybe_update): Update.
947
088f37dd
TT
9482019-08-15 Tom Tromey <tom@tromey.com>
949
950 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
951 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
952 tui-disasm.c.
953 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
954 Declare.
955 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
956 method.
957 (tui_disasm_window::maybe_update): Update.
958
a54700c6
TT
9592019-08-15 Tom Tromey <tom@tromey.com>
960
961 * tui/tui-winsource.h (struct tui_source_window_base)
962 <maybe_update>: Declare.
963 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
964 method.
965 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
966 Declare.
967 * tui/tui-source.c (tui_source_window::maybe_update): New method.
968 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
969 Declare.
970 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
971
e2a678a5
TT
9722019-08-15 Tom Tromey <tom@tromey.com>
973
974 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
975
f2dda477
TT
9762019-08-15 Tom Tromey <tom@tromey.com>
977
978 * tui/tui-wingeneral.c: Include tui-stack.h.
979 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
980 (struct tui_locator_window): Move from tui-data.h.
981 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
982 (tui_initialize_static_data): Move from tui-data.c.
983 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
984 (struct tui_locator_window): Move to tui-stack.c.
985 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
986 (tui_initialize_static_data): Move to tui-stack.c.
987
ed4a1084
TT
9882019-08-15 Tom Tromey <tom@tromey.com>
989
990 * tui/tui-layout.c (show_source_disasm_command)
991 (show_source_or_disasm_and_command): Use make_visible method, not
992 tui_make_window.
993 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
994 Remove.
995
65962b20
TT
9962019-08-15 Tom Tromey <tom@tromey.com>
997
998 * tui/tui-wingeneral.h (tui_make_window): Update.
999 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1000 parameter.
1001 (tui_gen_win_info::make_visible): Update.
1002 * tui/tui-regs.c (tui_data_window::display_registers_from):
1003 Update.
1004 * tui/tui-layout.c (show_source_disasm_command)
1005 (show_source_or_disasm_and_command): Update.
1006 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1007 (enum tui_box): Remove.
1008 (struct tui_win_info) <can_box>: New method.
1009 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1010 method.
1011
2208ee91
TV
10122019-08-15 Tom de Vries <tdevries@suse.de>
1013
1014 * linux-nat-trad.c: Include gdbarch.h.
1015
75faf5c4
AH
10162019-08-14 Alan Hayward <alan.hayward@arm.com>
1017
1018 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1019 register sizes.
1020
b1c896b3
TT
10212019-08-14 Tom Tromey <tromey@adacore.com>
1022
1023 * darwin-nat.c: Include gdbarch.h.
1024 * darwin-nat-info.c: Include gdbarch.h.
1025
6405cd73
TT
10262019-08-13 Tom Tromey <tom@tromey.com>
1027
1028 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1029 Remove.
1030 * tui/tui-data.c (tui_initialize_static_data): Update.
1031
5216580d
TT
10322019-08-13 Tom Tromey <tom@tromey.com>
1033
1034 * tui/tui-winsource.h (struct tui_exec_info_window)
1035 <~tui_exec_info_window, maybe_allocate_content, get_content,
1036 m_content>: Remove.
1037 (struct tui_source_window_base) <set_exec_info_content,
1038 show_exec_info_content>: Don't declare.
1039 * tui/tui-winsource.c
1040 (tui_exec_info_window::maybe_allocate_content): Remove.
1041 (tui_source_window_base::update_exec_info): Rename from
1042 set_exec_info_content.
1043 (tui_source_window_base::show_exec_info_content)
1044 (tui_source_window_base::update_exec_info): Remove.
1045
93858ad3
TT
10462019-08-13 Tom Tromey <tom@tromey.com>
1047
1048 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1049 declare.
1050 * tui/tui-winsource.c (tui_update_source_window_as_is)
1051 (tui_update_source_windows_with_addr, tui_erase_source_content):
1052 Update.
1053 (tui_clear_exec_info_content): Remove.
1054
e321e7ce
TT
10552019-08-13 Tom Tromey <tom@tromey.com>
1056
1057 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1058 declare.
1059 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1060 call tui_erase_exec_info_content.
1061 (tui_clear_exec_info_content): Rename from
1062 tui_erase_exec_info_content.
1063 (tui_clear_exec_info_content): Delete.
1064
8270ac62
TT
10652019-08-13 Tom Tromey <tom@tromey.com>
1066
1067 * tui/tui-winsource.h (struct tui_source_window_base)
1068 <show_exec_info_content>: Declare.
1069 (tui_show_exec_info_content): Don't declare.
1070 * tui/tui-winsource.c
1071 (tui_source_window_base::show_exec_info_content): Rename from
1072 tui_show_exec_info_content.
1073 (tui_source_window_base::update_exec_info): Update.
1074
7b56485d
TT
10752019-08-13 Tom Tromey <tom@tromey.com>
1076
1077 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1078 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1079 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1080 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1081 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1082 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1083 ... here.
1084
7ba913dc
TT
10852019-08-13 Tom Tromey <tom@tromey.com>
1086
1087 * tui/tui-winsource.h (struct tui_source_window_base)
1088 <update_exec_info>: Declare.
1089 (tui_update_exec_info): Don't declare.
1090 * tui/tui-winsource.c (tui_update_source_window_as_is)
1091 (tui_source_window_base::refresh_all)
1092 (tui_update_all_breakpoint_info): Update.
1093 (tui_source_window_base::update_exec_info): Rename from
1094 tui_update_exec_info.
1095 * tui/tui-stack.c (tui_show_frame_info): Update.
1096
37a4a131
TT
10972019-08-13 Tom Tromey <tom@tromey.com>
1098
1099 * tui/tui-winsource.h (struct tui_source_window_base)
1100 <set_exec_info_content>: Declare.
1101 (tui_set_exec_info_content): Don't declare.
1102 * tui/tui-winsource.c
1103 (tui_source_window_base::set_exec_info_content): Rename from
1104 tui_set_exec_info_content.
1105 (tui_update_exec_info): Update.
1106
0bd27e07
TT
11072019-08-13 Tom Tromey <tom@tromey.com>
1108
1109 * tui/tui-winsource.h (struct tui_source_window_base)
1110 <show_source_content>: Declare.
1111 (tui_show_source_content): Don't declare.
1112 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1113 (tui_source_window_base::show_source_content): Rename from
1114 tui_show_source_content.
1115 (tui_source_window_base::refresh_all): Update.
1116 * tui/tui-layout.c (show_source_disasm_command)
1117 (show_source_or_disasm_and_command): Update.
1118
b4ef5aeb
TT
11192019-08-13 Tom Tromey <tom@tromey.com>
1120
1121 * tui/tui-winsource.c (tui_erase_source_content)
1122 (tui_show_source_content, tui_source_window_base::refresh_all):
1123 Update.
1124 * tui/tui-wingeneral.h
1125 (tui_check_and_display_highlight_if_needed): Don't declare.
1126 * tui/tui-wingeneral.c
1127 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1128 check_and_display_highlight_if_needed.
1129 * tui/tui-win.c (tui_rehighlight_all)
1130 (tui_win_info::make_visible_with_new_height): Update.
1131 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1132 (tui_data_window::erase_data_content)
1133 (tui_data_window::display_all_data): Update.
1134 * tui/tui-data.h (struct tui_win_info)
1135 <check_and_display_highlight_if_needed>: Declare.
1136
fede5273
TT
11372019-08-13 Tom Tromey <tom@tromey.com>
1138
1139 * tui/tui-win.c (tui_resize_all): Call
1140 tui_delete_invisible_windows.
1141 * tui/tui-layout.c (show_layout): Call
1142 tui_delete_invisible_windows.
1143 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1144 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1145
22c3f490
TT
11462019-08-13 Tom Tromey <tom@tromey.com>
1147
1148 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1149 tui_add_win_to_layout.
1150
16cb7910
TT
11512019-08-13 Tom Tromey <tom@tromey.com>
1152
1153 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1154 * tui/tui-layout.c (tui_default_win_height): Now static.
1155
cc0c3ffb
TT
11562019-08-13 Tom Tromey <tom@tromey.com>
1157
1158 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1159 single switch.
1160 (show_source_disasm_command, show_source_or_disasm_and_command):
1161 Don't check current layout.
1162
3f3ffe54
TT
11632019-08-13 Tom Tromey <tom@tromey.com>
1164
1165 * tui/tui-wingeneral.c (make_all_visible): Remove.
1166 (tui_make_all_invisible): Simplify.
1167 * tui/tui-layout.c (tui_make_all_invisible): Move from
1168 tui-wingeneral.c; simplify.
1169 (show_layout): Hoist call to tui_make_all_invisible.
1170 (show_data): Don't call tui_make_all_invisible.
1171
69258091
TT
11722019-08-13 Tom Tromey <tom@tromey.com>
1173
1174 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1175 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1176
62cf57fe
TT
11772019-08-13 Tom Tromey <tom@tromey.com>
1178
1179 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1180 tui-data.c.
1181 (show_source_disasm_command, show_data)
1182 (show_source_or_disasm_and_command): Don't use
1183 tui_set_current_layout_to.
1184 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1185 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1186 tui-layout.c.
1187 (tui_set_current_layout_to): Remove.
1188
2afade5d
TT
11892019-08-13 Tom Tromey <tom@tromey.com>
1190
1191 * tui/tui-layout.c (tui_set_layout): Update.
1192 * tui/tui-data.h (struct tui_layout_def): Remove.
1193 (tui_layout_def): Don't declare.
1194 * tui/tui-data.c (layout_def): Remove.
1195 (tui_layout_def): Remove.
1196
a3504e96
TT
11972019-08-13 Tom Tromey <tom@tromey.com>
1198
1199 * tui/tui-winsource.h (struct tui_source_window_base)
1200 <clear_detail>: No longer "override".
1201 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1202 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1203 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1204 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1205 Remove.
1206 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1207
29c92911
TT
12082019-08-13 Tom Tromey <tromey@adacore.com>
1209
1210 * tracepoint.c: Don't include readline.h or history.h.
1211
86c6b807
TT
12122019-08-12 Tom Tromey <tom@tromey.com>
1213
1214 * configure: Rebuild.
1215 * configure.ac: Check for readline 7.
1216 * NEWS: Mention readline 7 requirement.
1217 * README: Update.
1218
5db2718c
TT
12192019-08-12 Tom Tromey <tom@tromey.com>
1220
1221 * mingw-hdep.c (gdb_select): Remove readline hack.
1222
dac36daf
PFC
12232019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1224
1225 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1226 when the function fails.
1227
1022c627
AA
12282019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1229
1230 * s390-tdep.c (s390_type_align): New function.
1231 (s390_gdbarch_init): Set it as type_align gdbarch method.
1232
eba4caf2
TV
12332019-08-09 Tom de Vries <tdevries@suse.de>
1234
1235 PR gdb/24591
1236 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1237 pc_low with relocation offset.
1238
123cd851
TT
12392019-08-07 Tom Tromey <tromey@adacore.com>
1240
1241 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1242 (print_frame_args): Update.
1243 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1244 Update.
1245 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1246 * frame.h (struct frame_arg): Add initializers.
1247 <error>: Now a unique_xmalloc_ptr.
1248
3d31bc39
AH
12492019-08-07 Alan Hayward <alan.hayward@arm.com>
1250
1251 * NEWS: Expand the Pointer Authentication entry.
1252 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1253 (aarch64_frame_unmask_lr): ... to this.
1254 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1255 Call aarch64_frame_unmask_lr.
1256 * frame.c (struct frame_info): Add "masked" variable.
1257 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1258 (fprint_frame): Check for masked pc.
1259 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1260 declarations.
1261 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1262 * stack.c (print_frame): Check for masked pc.
1263
0cf9feb9
TT
12642019-08-06 Tom Tromey <tom@tromey.com>
1265
1266 * stabsread.c (patch_block_stabs, read_one_struct_field)
1267 (read_enum_type): Use obstack_strndup.
1268 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1269 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1270 * dwarf2read.c (guess_full_die_structure_name)
1271 (anonymous_struct_prefix): Use obstack_strndup.
1272 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1273 * c-exp.y (yylex): Use obstack_strndup.
1274 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1275 (write_var_or_type): Use obstack_strndup.
1276
efba19b0
TT
12772019-08-06 Tom Tromey <tom@tromey.com>
1278
1279 * symfile.c (reread_symbols): Use obstack_strdup.
1280 * stabsread.c (read_type): Use obstack_strdup.
1281 * gdb_obstack.h (obstack_strdup): New overload.
1282 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1283 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1284 (dwarf2_canonicalize_name): Use obstack_strdup.
1285 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1286 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1287 Use obstack_strdup.
1288
f25102f7
TT
12892019-08-06 Tom Tromey <tom@tromey.com>
1290
1291 * gdb_obstack.h (obstack_strdup): Define.
1292 * gdb_obstack.c (obstack_strdup): Don't define.
1293
021887d8
TT
12942019-08-06 Tom Tromey <tom@tromey.com>
1295
1296 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1297 obstack_strdup.
1298 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1299 obstack_strdup.
1300 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1301 * stabsread.c (common_block_start): Use obstack_strdup.
1302 * objfiles.c (set_objfile_main_name, objfile): Use
1303 obstack_strdup.
1304 * namespace.c (add_using_directive): Use obstack_strdup.
1305 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1306 * jit.c (finalize_symtab): Use obstack_strdup.
1307 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1308 (guess_partial_die_structure_name, partial_die_info::fixup)
1309 (dwarf2_name): Use obstack_strdup.
1310 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1311 obstack_strdup.
1312 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1313 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1314 obstack_strdup.
1315 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1316
d2834edc
PW
13172019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1318
1319 * unittests/help-doc-selftests.c: New file.
1320 * Makefile.in: Add the new file.
1321
590042fc
PW
13222019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1323
1324 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1325 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1326 the full first line, except when FOR_VALUE_PREFIX. In this case,
1327 the trailing '.' is not output, and the first character is uppercased.
1328 (print_help_for_command): Update call to print_doc_line.
1329 (print_doc_of_command): Likewise.
1330 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1331 * cli/cli-option.c (append_indented_doc): Do not append newline.
1332 (build_help_option): Append newline after first appended_indented_doc
1333 only if a second call is done.
1334 (build_help): Append 2 new lines before each option, except the first
1335 one.
1336 * compile/compile.c (_initialize_compile): Add new lines after
1337 %OPTIONS%, when not at the end of the help.
1338 Change help doc or code
1339 producing the help doc to respect the invariants.
1340 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1341 Also removed the new line after 'Options:', as all other commands
1342 do not put an empty line between 'Options:' and the first option.
1343 * printcmd.c (_initialize_printcmd): Likewise.
1344 * stack.c (_initialize_stack): Likewise.
1345 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1346 incorrectly telling COMMAND is optional.
1347 * ada-lang.c (_initialize_ada_language): Change help doc or code
1348 producing the help doc to respect the invariants.
1349 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1350 * breakpoint.c (_initialize_breakpoint): Likewise.
1351 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1352 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1353 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1354 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1355 _initialize_cli_style): Likewise.
1356 * corelow.c (core_target_info): Likewise.
1357 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1358 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1359 * filesystem.c (_initialize_filesystem): Likewise.
1360 * frame.c (_initialize_frame): Likewise.
1361 * gnu-nat.c (add_task_commands): Likewise.
1362 * infcall.c (_initialize_infcall): Likewise.
1363 * infcmd.c (_initialize_infcmd): Likewise.
1364 * interps.c (_initialize_interpreter): Likewise.
1365 * language.c (_initialize_language): Likewise.
1366 * linux-fork.c (_initialize_linux_fork): Likewise.
1367 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1368 * maint.c (_initialize_maint_cmds): Likewise.
1369 * memattr.c (_initialize_mem): Likewise.
1370 * printcmd.c (_initialize_printcmd): Likewise.
1371 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1372 _RegEx): Likewise.
1373 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1374 * record-btrace.c (_initialize_record_btrace): Likewise.
1375 * record-full.c (_initialize_record_full): Likewise.
1376 * record.c (_initialize_record): Likewise.
1377 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1378 * regcache.c (_initialize_regcache): Likewise.
1379 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1380 _initialize_remote): Likewise.
1381 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1382 * serial.c (_initialize_serial): Likewise.
1383 * skip.c (_initialize_step_skip): Likewise.
1384 * source.c (_initialize_source): Likewise.
1385 * stack.c (_initialize_stack): Likewise.
1386 * symfile.c (_initialize_symfile): Likewise.
1387 * symtab.c (_initialize_symtab): Likewise.
1388 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1389 * top.c (init_main): Likewise.
1390 * tracefile-tfile.c (tfile_target_info): Likewise.
1391 * tracepoint.c (_initialize_tracepoint): Likewise.
1392 * tui/tui-win.c (_initialize_tui_win): Likewise.
1393 * utils.c (add_internal_problem_command): Likewise.
1394 * valprint.c (value_print_option_defs): Likewise.
1395
404f2902
FCE
13962019-08-06 Frank Ch. Eigler <fche@redhat.com>
1397
1398 PR build/24886
1399 * configure.ac: Drop enable-libmcheck support.
1400 * configure, config.in: Rebuild.
1401 * libmcheck.m4: Remove.
1402 * acinclude.m4: Don't include it.
1403 * Makefile.in: Don't distribute it.
1404 * top.c (print_gdb_configuration): Don't mention it.
1405
046bebe1
TT
14062019-08-06 Tom Tromey <tom@tromey.com>
1407
1408 * utils.c (set_output_style): Sometimes pass stream to
1409 emit_style_escape.
1410 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1411 * record-btrace.c (btrace_insn_history): Update.
1412 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1413 method.
1414 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1415 Update initializers.
1416 <m_uiout>: New field.
1417 <m_di>: Move lower.
1418 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1419 Remove "uiout" parameter.
1420 (dump_insns): Update.
1421 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1422 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1423
ddbcedf5
CB
14242019-08-06 Christian Biesinger <cbiesinger@google.com>
1425
1426 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1427 (error_in_psymtab_expansion): Likewise.
1428 (lookup_symbol_via_quick_fns): Likewise.
1429 (basic_lookup_transparent_type_quick): Likewise.
1430 (basic_lookup_transparent_type_1): Likewise.
1431
b08b16c8
TT
14322019-08-06 Tom Tromey <tromey@adacore.com>
1433
1434 * source.c (last_source_error): Now bool.
1435 (print_source_lines_base): Make "noprint" bool. Only open
1436 source file when last_source_visited changes.
1437
cb44333d
TT
14382019-08-06 Tom Tromey <tromey@adacore.com>
1439
1440 * annotate.c (annotate_source_line): Use g_source_cache.
1441 * source-cache.c (source_cache::get_plain_source_lines): Change
1442 parameters. Populate m_offset_cache.
1443 (source_cache::ensure): New method.
1444 (source_cache::get_line_charpos): New method.
1445 (extract_lines): Move lower. Change parameters.
1446 (source_cache::get_source_lines): Move lower.
1447 * source-cache.h (class source_cache): Update comment.
1448 <get_line_charpos>: New method.
1449 <get_source_lines>: Update comment.
1450 <clear>: Clear m_offset_cache.
1451 <get_plain_source_lines>: Change parameters.
1452 <ensure>: New method
1453 <m_offset_cache>: New member.
1454 * source.c (forget_cached_source_info_for_objfile): Update.
1455 (info_source_command): Use g_source_cache.
1456 (find_source_lines, open_source_file_with_line_charpos): Remove.
1457 (print_source_lines_base, search_command_helper): Use g_source_cache.
1458 * source.h (open_source_file_with_line_charpos): Don't declare.
1459 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1460 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1461 Use g_source_cache.
1462
872dceaa
TT
14632019-08-06 Tom Tromey <tromey@adacore.com>
1464
1465 * source-cache.c (source_cache::get_plain_source_lines):
1466 Remove "first_line" and "last_line" parameters.
1467 (source_cache::get_source_lines): Cache plain text.
1468 * source-cache.h (class source_cache)
1469 <get_plain_source_lines>: Update.
1470
269249d9
TT
14712019-08-06 Tom Tromey <tromey@adacore.com>
1472
1473 * source-cache.c (extract_lines): No longer a method.
1474 Changed type of parameter. Include final newline.
1475 (selftests::extract_lines_test): New function.
1476 (_initialize_source_cache): Likewise.
1477 * source-cache.h (class source_cache)
1478 <extract_lines>: Don't declare.
1479
c0e8dcd8
TT
14802019-08-06 Tom Tromey <tromey@adacore.com>
1481
1482 * breakpoint.c (init_breakpoint_sal): Update.
1483 (breakpoint): Update.
1484 * breakpoint.h (struct breakpoint) <filter>: Now a
1485 unique_xmalloc_ptr.
1486
0b27c27d
CB
14872019-08-05 Christian Biesinger <cbiesinger@google.com>
1488
1489 * NEWS: Mention dictionary access on blocks.
1490 * python/py-block.c (blpy_getitem): New function.
1491 (block_object_as_mapping): New struct.
1492 (block_object_type): Use new struct for tp_as_mapping field.
1493
4ee94178
CB
14942019-08-05 Christian Biesinger <cbiesinger@google.com>
1495
1496 * objfiles.h (objfile): Add a comment describing partial symbols.
1497
8abfcabc
TT
14982019-08-05 Tom Tromey <tromey@adacore.com>
1499
1500 * compile/compile.c (_initialize_compile): Use _(), not N_().
1501 * thread.c (_initialize_thread): Use _(), not N_().
1502 * stack.c (_initialize_stack): Use _(), not N_().
1503 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1504
2b79f376
SM
15052019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1506
1507 * dwarf2read.c (struct dw2_symtab_iterator):
1508 <want_specific_block>: Remove.
1509 <block_index>: Change type to gdb::optional.
1510 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1511 change type of BLOCK_INDEX parameter to gdb::optional.
1512 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1513 (dw2_lookup_symbol): Don't pass argument for
1514 WANT_SPECIFIC_BLOCK.
1515 (dw2_expand_symtabs_for_function): Don't pass argument for
1516 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1517 (class dw2_debug_names_iterator)
1518 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1519 parameter, change BLOCK_INDEX type to gdb::optional.
1520 <m_want_specific_block>: Remove.
1521 <m_block_index>: Change type to gdb::optional.
1522 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1523 gdb::optional. Re-write in function of gdb::optional.
1524 (dw2_debug_names_lookup_symbol): Don't pass argument for
1525 WANT_SPECIFIC_BLOCK.
1526 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1527 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1528 BLOCK_INDEX.
1529
ae60f04e
PW
15302019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1531
1532 * NEWS: Mention changes to "info sources" command.
1533
28cd9371
PW
15342019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1535
1536 * symtab.c (filename_partial_match_opts): New struct type.
1537 (struct output_source_filename_data): New members
1538 regexp, c_regexp, partial_match.
1539 (output_source_filename): Use new members to decide to print file.
1540 (info_sources_option_defs): New variable.
1541 (make_info_sources_options_def_group, print_info_sources_header,
1542 info_sources_command_completer):
1543 New functions.
1544 (info_sources_command): Read new optional arguments.
1545 (_initialize_symtab): Update info sources help.
1546
ca683e3a
AO
15472019-08-02 Alexandre Oliva <oliva@adacore.com>
1548
1549 * ada-lang.c (exception_support_info_v0): Renamed from...
1550 (default_exception_support_info): ... this. Create new
1551 definition for v1.
1552 (ada_has_this_exception_support): Look up catch_handlers_sym.
1553 (ada_exception_support_info_sniffer): Try v0 after default.
1554
f1264162
TT
15552019-08-01 Tom Tromey <tromey@adacore.com>
1556
1557 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1558 gdbarch.h.
1559
0a7b2485
CB
15602019-08-01 Christian Biesinger <cbiesinger@google.com>
1561
1562 * s12z-tdep.c: Fix include path for s12z-opc.h.
1563
c6bdbeb7
AH
15642019-08-01 Alan Hayward <alan.hayward@arm.com>
1565
1566 * NEWS: Require GNU make 3.82.
1567
a2bd7b82
TT
15682019-07-16 Tom Tromey <tom@tromey.com>
1569
1570 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1571 declare.
1572
aa3b6533
TT
15732019-07-30 Tom Tromey <tromey@adacore.com>
1574
1575 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1576
a1530dc7
KB
15772019-07-30 Kevin Buettner <kevinb@redhat.com>
1578
1579 * printcmd.c (print_address_symbolic): Print negative offsets.
1580 (build_address_symbolic): Force signed arithmetic when computing
1581 offset.
1582
2906593f
CB
15832019-07-30 Christian Biesinger <cbiesinger@google.com>
1584
1585 PR/24474: Add a function to lookup static variables.
1586 * NEWS: Mention this new function.
1587 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1588 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1589 * python/python.c (python_GdbMethods): Add new function.
1590
c620ed88
CB
15912019-07-29 Christian Biesinger <cbiesinger@google.com>
1592
1593 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1594 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1595 (objfpy_lookup_static_symbol): New function.
1596 (objfile_object_methods): Add new functions.
1597
bc4268a5
PW
15982019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1599
1600 * NEWS: Mention 'set|show print frame-info'. Mention new
1601 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1602 backtrace argument. Mention that python frame filtering code
1603 is now consistent with what 'backtrace' command prints.
1604
4b5e8d19
PW
16052019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1606
1607 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1608 comments.
1609 (print_frame_info_auto, print_frame_info_source_line,
1610 print_frame_info_location, print_frame_info_source_and_location,
1611 print_frame_info_location_and_address, print_frame_info_short_location):
1612 New declarations.
1613 (struct frame_print_options): New member print_frame_info.
1614 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1615 * stack.h (get_user_print_what_frame_info): New declaration.
1616 (frame_show_address): New declaration.
1617 * stack.c (print_frame_arguments_choices): New value 'presence'.
1618 (print_frame_info_auto, print_frame_info_source_line,
1619 print_frame_info_location, print_frame_info_source_and_location,
1620 print_frame_info_location_and_address, print_frame_info_short_location,
1621 print_frame_info_choices, print_frame_info_print_what): New definitions.
1622 (print_frame_args): Only print dots for args if print frame-arguments
1623 is 'presence'.
1624 (frame_print_option_defs): New element for "frame-info".
1625 (get_user_print_what_frame_info): New function.
1626 (frame_show_address): Make non static. Move comment to stack.h.
1627 (print_frame_info_to_print_what): New function.
1628 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1629 to decide what to print.
1630 (backtrace_command_1): Handle the new print_frame_arguments_presence
1631 value.
1632 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1633 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1634 (py_print_frame): In non-mi mode, use LOCATION as default for
1635 print_what, similarly to frame information printed directly by
1636 backtrace command. Handle frame-info user option in non MI mode.
1637
6bdfee81
KB
16382019-07-27 Kevin Buettner <kevinb@redhat.com>
1639
1640 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1641 Add case for debugging 32-bit target on 64-bit host. Revise
1642 comment.
1643
98a617f8
KB
16442019-07-27 Kevin Buettner <kevinb@redhat.com>
1645
1646 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1647 instead of find_function_entry_range_from_pc.
1648
567238c9
KB
16492019-07-27 Kevin Buettner <kevinb@redhat.com>
1650
1651 * stack.c (find_frame_funname): Remove code which preferred
1652 minsym over symtab sym in "certain pathological cases".
1653
2dc80cf8
KB
1654 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1655 parameter. Change type of "do_demangle" to bool.
1656 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1657 Pass suitable "prefer_sym_over_minsym" flag to
1658 build_address_symbolic(). Don't output "+" for negative offsets.
1659 * printcmd.c (print_address_symbolic): Update invocation of
1660 build_address_symbolic to include a "prefer_sym_over_minsym"
1661 flag.
1662 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1663 Restrict cases in which use of minimal symbol is preferred to that
1664 of a found symbol. Update comments.
1665
1aff7173
KB
1666 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1667 for entry pc when entry pc is out of range for that FDE.
1668
89b085ac
BC
16692019-07-26 Brian Callahan <bcallah@openbsd.org>
1670
1671 PR gdb/24839:
1672 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1673 type.
1674
f32feb4a
CB
16752019-07-25 Christian Biesinger <cbiesinger@google.com>
1676
1677 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1678 this function's Python signature.
1679
1680
16812019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1682
1683 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1684 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1685 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1686 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1687 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1688
1689
c54e4253
YS
16902019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1691
1692 * h8300-tdep.c (h8300_register_name_common): New.
1693 h8300_register_name): Use h8300_register_name_common.
1694 (h8300s_register_name): Likewise.
1695 (h8300sx_register_name): Likewise.
1696 (h8300h_register_nam): New.
1697 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1698
1699
40eadf04
SP
17002019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1701
1702 * arm-tdep.c (arm_skip_cmse_entry): New function.
1703 (arm_is_sgstubs_section): New function.
1704 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1705
bfa2a36d
TT
17062019-07-22 Tom Tromey <tom@tromey.com>
1707
1708 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1709 Don't self-assign.
1710
a8e9d247
AB
17112019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1712
1713 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1714 type_print.
1715
eb86c5e2
AB
17162019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1717
1718 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1719 so that GDB doesn't match any msymbols when searching in the
1720 TYPES_DOMAIN.
1721 (print_symbol_info): Print using typedef_print or type_print based
1722 on the type of the symbol. Add updated FIXME comment moved from...
1723 (_initialize_symtab): ... move and update FIXME comment to above.
1724
a8eab7c6
AB
17252019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1726
1727 * NEWS: Mention adding -q option to "info types".
1728 * symtab.c (struct info_types_options): New struct.
1729 (info_types_options_defs): New variable.
1730 (make_info_types_options_def_group): New function.
1731 (info_types_command): Use gdb::option framework to parse options.
1732 (info_types_command_completer): New function.
1733 (_initialize_symtab): Extend the help text on "info types" and
1734 register command completer.
1735
b4603c34
CB
17362019-07-21 Christian Biesinger <cbiesinger@google.com>
1737
1738 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1739 (lookup_symbol_in_objfile): Change int to block_enum and add a
1740 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1741
c8cdc1e0
CB
17422019-07-20 Christian Biesinger <cbiesinger@google.com>
1743
1744 * MAINTAINERS (Write After Approval): Add self.
1745
01e175fe
AB
17462019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1747
1748 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1749 instruction to the dummy code region.
1750
56f79b63
TT
17512019-07-19 Tom Tromey <tromey@adacore.com>
1752
1753 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1754 (ARGSUSED, PARAMS, __func__): Remove rules.
1755
4c5aa8e0
AH
17562019-07-19 Alan Hayward <alan.hayward@arm.com>
1757
1758 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1759 * features/arm/arm-with-iwmmxt.c: Remove.
1760 * features/arm/arm-with-iwmmxt.xml: Remove.
1761 * features/arm/arm-with-m-fpa-layout.c: Remove.
1762 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1763 * features/arm/arm-with-m-vfp-d16.c: Remove.
1764 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1765 * features/arm/arm-with-m.c: Remove.
1766 * features/arm/arm-with-m.xml: Remove.
1767 * features/arm/arm-with-neon.c: Remove.
1768 * features/arm/arm-with-neon.xml: Remove.
1769 * features/arm/arm-with-vfpv2.c: Remove.
1770 * features/arm/arm-with-vfpv2.xml: Remove.
1771 * features/arm/arm-with-vfpv3.c: Remove.
1772 * features/arm/arm-with-vfpv3.xml: Remove.
1773
f42b2617
AH
17742019-07-19 Alan Hayward <alan.hayward@arm.com>
1775
1776 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1777
f29ec966
AH
17782019-07-19 Alan Hayward <alan.hayward@arm.com>
1779
1780 * arch/aarch32.c (aarch32_create_target_description): Create
1781 target descriptions using features.
1782 * arch/arm.c (arm_create_target_description)
1783 (arm_create_mprofile_target_description): Likewise.
1784 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1785
d105cce5
AH
17862019-07-19 Alan Hayward <alan.hayward@arm.com>
1787
1788 * Makefile.in: Add new files.
1789 * aarch32-tdep.c: New file.
1790 * aarch32-tdep.h: New file.
1791 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1792 Call aarch32_read_description.
1793 * arch/aarch32.c: New file.
1794 * arch/aarch32.h: New file.
1795 * arch/arm.c (arm_create_target_description)
1796 (arm_create_mprofile_target_description): New function.
1797 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1798 (arm_create_target_description)
1799 (arm_create_mprofile_target_description): New declaration.
1800 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1801 read_description functions.
1802 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1803 Likewise.
1804 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1805 * arm-tdep.c (tdesc_arm_list): New variable.
1806 (arm_register_g_packet_guesses): Call create description functions.
1807 (arm_read_description) (arm_read_mprofile_description): New
1808 function.
1809 * arm-tdep.h (arm_read_description)
1810 (arm_read_mprofile_description): Add declaration.
1811 * configure.tgt: Add new files.
1812
afe09f0b
GL
18132019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1814
1815 * top.c (new_ui_command): Open specified terminal just once.
1816
cd215b2e
TT
18172019-07-18 Tom Tromey <tromey@adacore.com>
1818
1819 * symtab.c (main_name): Constify return type.
1820 * symfile.c (set_initial_language): Update.
1821 * symtab.h (main_name): Constify return type.
1822
d8f68fcb
TT
18232019-07-17 Tom Tromey <tom@tromey.com>
1824
1825 * tui/tui-winsource.c (tui_update_source_window)
1826 (tui_update_source_window_as_is)
1827 (tui_update_source_windows_with_line): Remove return.
1828 * tui/tui-disasm.c (tui_show_disassem)
1829 (tui_show_disassem_and_update_source): Remove return.
1830 * tui/tui.c (tui_reset): Remove return.
1831 * tui/tui-wingeneral.c
1832 (tui_check_and_display_highlight_if_needed): Remove return.
1833
ca5af91e
TT
18342019-07-17 Tom Tromey <tom@tromey.com>
1835
1836 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1837
5104fe36
TT
18382019-07-17 Tom Tromey <tom@tromey.com>
1839
1840 * tui/tui-winsource.h (struct tui_exec_info_window)
1841 (struct tui_source_window_base): Move from tui-data.h.
1842 * tui/tui-winsource.c: Move many method definitions from
1843 elsewhere. Remove "structuring" comments.
1844 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1845 (tui_source_window_base::refresh_window): Move to
1846 tui-winsource.c.
1847 * tui/tui-win.c (tui_source_window_base::refresh_all)
1848 (tui_source_window_base::update_tab_width)
1849 (tui_source_window_base::set_new_height)
1850 (tui_source_window_base::do_make_visible_with_new_height): Move to
1851 tui-winsource.c.
1852 * tui/tui-source.h: Update.
1853 * tui/tui-source.c (tui_source_window_base::reset): Move to
1854 tui-winsource.c.
1855 * tui/tui-disasm.h: Update.
1856 * tui/tui-data.h (struct tui_exec_info_window): Move to
1857 tui-winsource.h.
1858 (struct tui_source_window_base): Likewise.
1859 * tui/tui-data.c (tui_source_window_base::clear_detail)
1860 (tui_source_window_base, ~tui_source_window_base): Move to
1861 tui-winsource.c.
1862
daa15dde
TT
18632019-07-17 Tom Tromey <tom@tromey.com>
1864
1865 * tui/tui-win.c (tui_resize_all)
1866 (tui_source_window_base::update_tab_width)
1867 (tui_adjust_win_heights): Update.
1868 (tui_win_info::make_invisible_and_set_new_height): Rename from
1869 make_invisible_and_set_new_height.
1870 * tui/tui-data.h (struct tui_win_info)
1871 <make_invisible_and_set_new_height>: New method.
1872
bfad4537
TT
18732019-07-17 Tom Tromey <tom@tromey.com>
1874
1875 * tui/tui.c: Update.
1876 * tui/tui-source.h (struct tui_source_window): Move from
1877 tui-data.h.
1878 * tui/tui-layout.c: Update.
1879 * tui/tui-disasm.c: Update.
1880 * tui/tui-data.h (struct tui_source_window): Move to
1881 tui-source.h.
1882
88f7e873
TT
18832019-07-17 Tom Tromey <tom@tromey.com>
1884
1885 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1886 tui-data.h.
1887 * tui/tui-data.h (struct tui_disasm_window): Move to
1888 tui-disasm.h.
1889
96bd6233
TT
18902019-07-17 Tom Tromey <tom@tromey.com>
1891
1892 * tui/tui-regs.h (struct tui_data_item_window): Move from
1893 tui-data.h.
1894 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1895 * tui/tui-data.h (struct tui_data_item_window): Move to
1896 tui-regs.h.
1897 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1898
ce38393b
TT
18992019-07-17 Tom Tromey <tom@tromey.com>
1900
1901 * tui/tui.c: Update.
1902 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1903 (tui_cmd_window::max_height): Move to tui-command.c.
1904 * tui/tui-layout.c: Update.
1905 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1906 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1907 tui-command.c.
1908 * tui/tui-command.h (struct tui_cmd_window): Move from
1909 tui-data.h.
1910 * tui/tui-command.c: Remove "structuring" comments.
1911 (tui_cmd_window::clear_detail)
1912 (tui_cmd_window::do_make_visible_with_new_height)
1913 (tui_cmd_window::max_height): Move from elsewhere.
1914
2d8b51cb
TT
19152019-07-17 Tom Tromey <tom@tromey.com>
1916
1917 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1918 Now static.
1919 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1920 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1921
18ab23af
TT
19222019-07-17 Tom Tromey <tom@tromey.com>
1923
1924 * tui/tui.c: Update.
1925 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1926 tui-regs.c.
1927 * tui/tui-windata.h: Remove file.
1928 * tui/tui-windata.c: Remove file.
1929 * tui/tui-win.c (tui_data_window::set_new_height)
1930 (tui_data_window::do_make_visible_with_new_height): Move to
1931 tui-regs.c.
1932 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1933 * tui/tui-regs.c: Remove "structuring" comments.
1934 (tui_data_window::first_data_item_displayed)
1935 (tui_data_window::delete_data_content_windows)
1936 (tui_data_window::erase_data_content)
1937 (tui_data_window::display_all_data)
1938 (tui_data_window::refresh_all)
1939 (tui_data_window::do_scroll_vertical)
1940 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1941 (tui_data_window::do_make_visible_with_new_height)
1942 (tui_data_window::refresh_window): Move from elsewhere.
1943 (_initialize_tui_regs): Move to end of file.
1944 * tui/tui-layout.c: Update.
1945 * tui/tui-hooks.c: Update.
1946 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1947 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1948 tui-regs.c.
1949 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1950
88b7e7cc
TT
19512019-07-17 Tom Tromey <tom@tromey.com>
1952
1953 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1954 seen.
1955
0fcd3711
TT
19562019-07-17 Tom Tromey <tom@tromey.com>
1957
1958 * tui/tui-win.c (tui_source_window_base::set_new_height)
1959 (tui_source_window_base::do_make_visible_with_new_height): Use
1960 m_has_locator field directly.
1961 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1962 method.
1963 (struct tui_source_window_base) <has_locator>: Likewise.
1964
4a38112d
TT
19652019-07-17 Tom Tromey <tom@tromey.com>
1966
1967 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1968 Don't declare.
1969 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1970 Remove.
1971 * tui/tui-win.c (tui_source_window_base::set_new_height)
1972 (tui_source_window_base::set_new_height)
1973 (make_invisible_and_set_new_height)
1974 (tui_source_window_base::do_make_visible_with_new_height)
1975 (tui_source_window_base::do_make_visible_with_new_height):
1976 Update.
1977 * tui/tui-layout.c (show_source_disasm_command, show_data)
1978 (show_source_or_disasm_and_command): Update.
1979 * tui/tui-layout.c (show_layout): Update.
1980
09129226
TT
19812019-07-17 Tom Tromey <tom@tromey.com>
1982
1983 * tui/tui-layout.c (make_data_window): Remove.
1984 (show_data): Unify creation and re-initialization cases.
1985
4a8a5e84
TT
19862019-07-17 Tom Tromey <tom@tromey.com>
1987
1988 * tui/tui-layout.c (make_source_window, make_disasm_window):
1989 Remove.
1990 (show_data): Unify creation and re-initialization cases.
1991
76d2be8e
TT
19922019-07-17 Tom Tromey <tom@tromey.com>
1993
1994 * tui/tui-layout.c (make_command_window): Remove.
1995 (show_source_disasm_command, show_source_or_disasm_and_command):
1996 Unify creation and re-initialization cases.
1997
890b8bde
TT
19982019-07-17 Tom Tromey <tom@tromey.com>
1999
2000 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2001 creation and re-initialization cases.
2002
2cdfa113
TT
20032019-07-17 Tom Tromey <tom@tromey.com>
2004
2005 * tui/tui-regs.c (tui_get_register): Return void.
2006
8e3cfd09
TT
20072019-07-17 Tom Tromey <tom@tromey.com>
2008
2009 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2010 Simplify.
2011
f4e04977
TT
20122019-07-17 Tom Tromey <tom@tromey.com>
2013
2014 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2015 resetting.
2016
0379b883
TT
20172019-07-17 Tom Tromey <tom@tromey.com>
2018
2019 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2020 * tui/tui-regs.c (tui_reg_layout): New function.
2021 (tui_show_registers, tui_reg_command): Use it.
2022 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2023 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2024 parameters.
2025 (tui_layout_command): Remove.
2026
b7fbad91
TT
20272019-07-17 Tom Tromey <tom@tromey.com>
2028
2029 * tui/tui-layout.h (tui/tui-layout): Return void.
2030 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2031
4e1e56b9
TT
20322019-07-17 Tom Tromey <tom@tromey.com>
2033
2034 * tui/tui-layout.c (show_source_disasm_command, show_data):
2035 Update.
2036 (reset_locator): Remove.
2037 (show_source_or_disasm_and_command): Update.
2038
1e0c09ba
TT
20392019-07-17 Tom Tromey <tom@tromey.com>
2040
2041 * tui/tui-source.c (tui_source_window_base::reset): Remove
2042 win_type parameter.
2043 * tui/tui-layout.c (make_command_window, make_source_window)
2044 (make_disasm_window, make_data_window)
2045 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2046 (reset_locator, show_source_or_disasm_and_command): Update.
2047 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2048 win_type parameter.
2049 (struct tui_source_window_base) <reset>: Likewise.
2050
1bf605de
TT
20512019-07-17 Tom Tromey <tom@tromey.com>
2052
2053 * tui/tui-layout.c (show_source_disasm_command): Use
2054 reset_locator.
2055 (reset_locator): New function.
2056 (init_and_make_win): Remove.
2057 (show_source_or_disasm_and_command): Use reset_locator.
2058
098f9ed4
TT
20592019-07-17 Tom Tromey <tom@tromey.com>
2060
2061 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2062 condition.
2063 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2064 Remove condition.
2065 * tui/tui-source.c (tui_source_window_base::reset): New method.
2066 * tui/tui-layout.c (make_command_window): Don't call
2067 init_and_make_win.
2068 (make_source_window, make_disasm_window): Don't call
2069 make_source_or_disasm_window.
2070 (make_data_window): Don't call init_and_make_win. Change calling
2071 convention.
2072 (show_source_disasm_command, show_data): Simplify.
2073 (make_source_or_disasm_window): Remove.
2074 (show_source_or_disasm_and_command): Simplify.
2075 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2076 (struct tui_source_window_base) <reset>: Likewise.
2077 <execution_info>: Remove initializer.
2078 * tui/tui-data.c (tui_source_window_base): Initialize
2079 execution_info.
2080
80110957
TT
20812019-07-17 Tom Tromey <tom@tromey.com>
2082
2083 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2084 variable.
2085
cf82af05
TT
20862019-07-17 Tom Tromey <tom@tromey.com>
2087
2088 * tui/tui.c (tui_rl_other_window): Update.
2089 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2090 superclass method first. Always iterate over regs_content.
2091 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2092 method.
2093 * tui/tui-win.c (tui_set_focus_command): Update.
2094
01aeb396
TT
20952019-07-17 Tom Tromey <tom@tromey.com>
2096
2097 * tui/tui-win.c (tui_set_focus_command): Rename from
2098 tui_set_focus. Call tui_enable.
2099 (tui_set_focus_command): Remove.
2100
fd6c75ee
TT
21012019-07-17 Tom Tromey <tom@tromey.com>
2102
2103 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2104 refresh_window.
2105 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2106 touchwin.
2107 (tui_data_window::refresh_window): Call refresh_window on data
2108 items. Always call superclass refresh_window.
2109 (tui_win_info::refresh): Remove.
2110 (tui_source_window_base::refresh_window): Update.
2111 (tui_refresh_all): Update.
2112 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2113 refresh_window.
2114 (show_source_or_disasm_and_command): Likewise.
2115 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2116 (struct tui_source_window_base) <refresh>: Likewise.
2117
f6cc34a9
TT
21182019-07-17 Tom Tromey <tom@tromey.com>
2119
2120 * tui/tui-winsource.c (tui_clear_source_content)
2121 (tui_show_source_content): Update.
2122 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2123 whether content is empty.
2124 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2125 Remove.
2126
f31ec9af
TT
21272019-07-17 Tom Tromey <tom@tromey.com>
2128
2129 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2130 window's contents.
2131 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2132 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2133
d1b6f1e5
TT
21342019-07-17 Tom Tromey <tom@tromey.com>
2135
2136 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2137 (struct tui_data_item_window): Update.
2138
d9743a13
TT
21392019-07-17 Tom Tromey <tom@tromey.com>
2140
2141 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2142 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2143 defines.
2144
caf0bc4e
TT
21452019-07-17 Tom Tromey <tom@tromey.com>
2146
2147 * tui/tui-winsource.h (tui_erase_source_content)
2148 (tui_clear_source_content): Remove "display_prompt" parameter.
2149 * tui/tui-winsource.c (tui_update_source_window_as_is)
2150 (tui_update_source_windows_with_addr): Update.
2151 (tui_clear_source_content): Remove "display_prompt" parameter.
2152 (tui_erase_source_content): Likewise. Simplify.
2153 (tui_show_source_content): Update.
2154 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2155 * tui/tui-stack.c (tui_show_frame_info): Update.
2156 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2157 Remove defines.
2158
9d391078
TT
21592019-07-17 Tom Tromey <tom@tromey.com>
2160
2161 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2162 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2163 parameter.
2164 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2165 parameter.
2166
a38da35d
TT
21672019-07-17 Tom Tromey <tom@tromey.com>
2168
2169 * tui/tui-winsource.c (tui_clear_source_content)
2170 (tui_show_source_content, tui_show_exec_info_content)
2171 (tui_clear_exec_info_content): Update.
2172 * tui/tui-stack.c (tui_show_locator_content): Update.
2173 (tui_show_frame_info): Update.
2174 * tui/tui-source.h (tui_source_window): Don't declare.
2175 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2176 from tui_source_is_displayed.
2177 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2178 Remove field.
2179 (struct tui_source_window_base) <content_in_use>: New field. Now
2180 bool.
2181 (struct tui_source_window) <showing_source_p>: New method.
2182 (TUI_SRC_WIN): Change cast.
2183 * tui/tui-data.c (tui_initialize_static_data): Update.
2184
c2cd8994
TT
21852019-07-17 Tom Tromey <tom@tromey.com>
2186
2187 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2188 location_matches_p.
2189 * tui/tui-source.c (tui_source_window::location_matches_p): New
2190 method.
2191 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2192 method.
2193 * tui/tui-data.h (struct tui_source_window_base)
2194 <location_matches_p>: New method.
2195 (struct tui_source_window, struct tui_disasm_window)
2196 <location_matches_p>: Likewise.
2197
4dde7b34
TT
21982019-07-17 Tom Tromey <tom@tromey.com>
2199
2200 * tui/tui-win.c (tui_set_win_height_command): Rename from
2201 tui_set_win_height.
2202 (tui_set_win_height_command): Remove.
2203
b73dd877
TT
22042019-07-17 Tom Tromey <tom@tromey.com>
2205
2206 * tui/tui-source.c (tui_source_window): New constructor. Add
2207 observer.
2208 (~tui_source_window): New destructor.
2209 (tui_source_window::style_changed): New method.
2210 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2211 (tui_attach_detach_observers): Update.
2212 * tui/tui-data.h (struct tui_source_window): Make constructor not
2213 inline. Add destructor.
2214 (struct tui_source_window) <style_changed>: New method.
2215 <m_observable>: New member.
2216
ae2b5380
TT
22172019-07-17 Tom Tromey <tom@tromey.com>
2218
2219 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2220 * tui/tui-win.c (tui_resize_all): Fix typo.
2221
1ce3e844
TT
22222019-07-17 Tom Tromey <tom@tromey.com>
2223
2224 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2225 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2226 (tui_refresh_all): Remove "list" parameter. Use foreach.
2227 * tui/tui-win.c (window_name_completer): Use foreach.
2228 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2229 (update_tab_width): Likewise.
2230 * tui/tui-layout.c (show_layout): Update.
2231 * tui/tui-data.h (class tui_window_iterator): New.
2232 (struct all_tui_windows): New.
2233 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2234
fe3eaf1c
TT
22352019-07-17 Tom Tromey <tom@tromey.com>
2236
2237 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2238 parameter. Don't reference globals.
2239 (tui_reg_command): Update.
2240
368c1354
TT
22412019-07-17 Tom Tromey <tom@tromey.com>
2242
2243 * tui/tui-regs.c (tui_show_registers): Simplify.
2244
e80cd204
TT
22452019-07-17 Tom Tromey <tom@tromey.com>
2246
2247 * tui/tui-regs.c (tui_show_registers): Update.
2248 (tui_show_register_group): Add win_info parameter.
2249
aca2dd16
TT
22502019-07-17 Tom Tromey <tom@tromey.com>
2251
2252 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2253 Rename from tui_display_reg_element_at_line.
2254 (tui_data_window::display_registers_from_line): Update.
2255 * tui/tui-data.h (struct tui_data_window)
2256 <display_reg_element_at_line>: New method.
2257
517e9505
TT
22582019-07-17 Tom Tromey <tom@tromey.com>
2259
2260 * tui/tui-regs.h (tui_display_registers_from)
2261 (tui_display_registers_from_line): Don't declare.
2262 * tui/tui-windata.c (tui_data_window::display_all_data)
2263 (tui_data_window::refresh_all)
2264 (tui_data_window::do_scroll_vertical): Update.
2265 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2266 from tui_display_registers_from.
2267 (tui_display_reg_element_at_line): Update.
2268 (tui_data_window::display_registers_from_line): Rename from
2269 tui_display_registers_from_line.
2270 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2271 display_registers_from_line>: New methods.
2272
f76d8b19
TT
22732019-07-17 Tom Tromey <tom@tromey.com>
2274
2275 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2276 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2277 from tui_erase_data_content.
2278 (tui_data_window::display_all_data)
2279 (tui_data_window::refresh_all)
2280 (tui_data_window::do_scroll_vertical): Update.
2281 * tui/tui-regs.c (tui_show_registers): Update.
2282 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2283 New method.
2284
b4094625
TT
22852019-07-17 Tom Tromey <tom@tromey.com>
2286
2287 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2288 declare.
2289 * tui/tui-windata.c
2290 (tui_data_window::delete_data_content_windows): Rename from
2291 tui_delete_data_content_windows.
2292 (tui_data_window::display_all_data)
2293 (tui_data_window::do_scroll_vertical): Update.
2294 * tui/tui-data.h (struct tui_data_window)
2295 <delete_data_content_windows>: New method.
2296
c223a729
TT
22972019-07-17 Tom Tromey <tom@tromey.com>
2298
2299 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2300 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2301
50daf268
TT
23022019-07-17 Tom Tromey <tom@tromey.com>
2303
2304 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2305 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2306 from tui_display_all_data.
2307 * tui/tui-win.c
2308 (tui_data_window::do_make_visible_with_new_height): Update.
2309 * tui/tui-regs.c (tui_show_registers): Update.
2310 * tui/tui-layout.c (tui_set_layout): Update.
2311 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2312 method.
2313
df5f8cab
TT
23142019-07-17 Tom Tromey <tom@tromey.com>
2315
2316 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2317 * tui/tui-windata.c (tui_display_data_from): Remove.
2318 (tui_data_window::refresh_all): Update.
2319
80cb6c27
TT
23202019-07-17 Tom Tromey <tom@tromey.com>
2321
2322 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2323 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2324 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2325 tui_display_registers_from_line.
2326 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2327 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2328 "force_display" parameter.
2329
baff0c28
TT
23302019-07-17 Tom Tromey <tom@tromey.com>
2331
2332 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2333 declare.
2334 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2335 Rename from tui_first_reg_element_no_inline.
2336 (tui_display_reg_element_at_line)
2337 (tui_display_registers_from_line): Update.
2338 * tui/tui-data.h (struct tui_data_window)
2339 <first_reg_element_no_inline>: New method.
2340
3b23c5f2
TT
23412019-07-17 Tom Tromey <tom@tromey.com>
2342
2343 * tui/tui-windata.c (tui_display_data_from)
2344 (tui_data_window::do_scroll_vertical): Update.
2345 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2346 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2347 Rename from tui_line_from_reg_element_no.
2348 (tui_display_registers_from_line): Update.
2349 * tui/tui-data.h (struct tui_data_window)
2350 <line_from_reg_element_no>: New method.
2351
0b5ec218
TT
23522019-07-17 Tom Tromey <tom@tromey.com>
2353
2354 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2355 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2356 tui_last_regs_line_no.
2357 (tui_display_reg_element_at_line)
2358 (tui_display_registers_from_line): Update.
2359 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2360 method.
2361
0807ab7b
TT
23622019-07-17 Tom Tromey <tom@tromey.com>
2363
2364 PR tui/24722:
2365 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2366 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2367 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2368 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2369 (tui_update_breakpoint_info): Likewise.
2370 * tui/tui-hooks.c (tui_event_create_breakpoint)
2371 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2372 Update.
2373
9ad7fdef
TT
23742019-07-17 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2377
5813316f
TT
23782019-07-17 Tom Tromey <tom@tromey.com>
2379
2380 * tui/tui-winsource.c (tui_update_source_window_as_is)
2381 (tui_update_source_windows_with_addr): Update.
2382 * tui/tui-source.h (tui_set_source_content)
2383 (tui_show_symtab_source): Add "win_info" parameter.
2384 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2385 parameter.
2386 (tui_show_symtab_source): Likewise.
2387
00e264e7
TT
23882019-07-17 Tom Tromey <tom@tromey.com>
2389
2390 * tui/tui-wingeneral.c
2391 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2392
06210ce4
TT
23932019-07-17 Tom Tromey <tom@tromey.com>
2394
2395 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2396 (struct tui_cmd_window) <can_scroll>: New method.
2397 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2398 method.
2399
381befee
TT
24002019-07-17 Tom Tromey <tromey@adacore.com>
2401
2402 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2403 do_field_signed>: Rename. Change type of "value".
2404 * ui-out.c (ui_out::field_signed): Rename from field_int.
2405 Change type of "value".
2406 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2407 type of "value".
2408 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2409 do_field_int. Change type of "value".
2410 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2411 do_field_int. Change type of "value".
2412 * tracepoint.c (trace_status_mi, tfind_1)
2413 (print_one_static_tracepoint_marker): Update.
2414 * thread.c (print_thread_info_1, print_selected_thread_frame):
2415 Update.
2416 * stack.c (print_frame, print_frame_info): Update.
2417 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2418 Update.
2419 * source.c (print_source_lines_base): Update.
2420 * skip.c (info_skip_command): Update.
2421 * record-btrace.c (btrace_ui_out_decode_error)
2422 (btrace_call_history_src_line): Update.
2423 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2424 Update.
2425 * progspace.c (print_program_space): Update.
2426 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2427 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2428 do_field_int. Change type of "value".
2429 * mi/mi-out.c (mi_ui_out::do_table_begin)
2430 (mi_ui_out::do_table_header): Update.
2431 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2432 type of "value".
2433 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2434 (mi_cmd_data_list_changed_registers, output_register)
2435 (mi_cmd_data_read_memory, mi_load_progress)
2436 (mi_cmd_trace_frame_collected): Update.
2437 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2438 Update.
2439 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2440 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2441 (mi_cmd_var_list_children, varobj_update_one): Update.
2442 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2443 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2444 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2445 * inferior.c (print_inferior): Update.
2446 * gdb_bfd.c (print_one_bfd): Update.
2447 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2448 Update.
2449 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2450 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2451 do_field_int. Change type of "value".
2452 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2453 do_field_int. Change type of "value".
2454 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2455 (print_one_breakpoint_location, print_it_catch_fork)
2456 (print_one_catch_fork, print_it_catch_vfork)
2457 (print_one_catch_vfork, print_it_catch_solib)
2458 (print_it_catch_exec, print_it_ranged_breakpoint)
2459 (print_mention_watchpoint, print_mention_masked_watchpoint)
2460 (bkpt_print_it, update_static_tracepoint): Update.
2461 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2462 * break-catch-syscall.c (print_it_catch_syscall): Update.
2463 * ada-tasks.c (print_ada_task_info): Update.
2464 * ada-lang.c (print_it_exception, print_mention_exception):
2465 Update.
2466
6b78c3f8
AB
24672019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2468
2469 PR breakpoints/24541
2470 * gdbarch.c: Regenerate.
2471 * gdbarch.h: Regenerate.
2472 * gdbarch.sh: Adjust return type and parameter types for
2473 'stap_adjust_register'.
2474 (i386_stap_adjust_register): Adjust signature and return new
2475 register name.
2476 * stap-probe.c (stap_parse_register_operand): Adjust use of
2477 'gdbarch_stap_adjust_register'.
2478
d72a9b85
TT
24792019-07-17 Tom Tromey <tromey@adacore.com>
2480
2481 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2482 declare VEC.
2483 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2484 std::vector.
2485 (struct s390_process_info): Add initializers.
2486 (s390_add_process): Use new.
2487 (s390_linux_nat_target::low_forget_process): Use delete.
2488 (s390_linux_nat_target::low_new_fork)
2489 (s390_linux_nat_target::stopped_by_watchpoint)
2490 (s390_linux_nat_target::low_prepare_to_resume)
2491 (s390_linux_nat_target::insert_watchpoint)
2492 (s390_linux_nat_target::insert_hw_breakpoint)
2493 (s390_linux_nat_target::remove_watchpoint)
2494 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2495
206e6c58
JB
24962019-07-16 John Baldwin <jhb@FreeBSD.org>
2497
2498 * aarch64-fbsd-nat.c: Include regcache.h.
2499 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2500 argument.
2501 (aarch64_fbsd_nat_target::fetch_registers)
2502 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2503 variable.
2504 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2505
cbde90f2
JB
25062019-07-16 John Baldwin <jhb@FreeBSD.org>
2507
2508 * fbsd-nat.c: Include gdbarch.h.
2509
07128006
TT
25102019-07-15 Tom Tromey <tromey@adacore.com>
2511
2512 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2513
1f77b012
TT
25142019-07-15 Tom Tromey <tromey@adacore.com>
2515
2516 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2517 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2518 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2519 * cli-out.c (cli_ui_out::do_field_int): New method.
2520 * ui-out.c (ui_out::field_unsigned): New method.
2521 * symfile.c (generic_load): Use field_unsigned.
2522 (print_transfer_performance): Likewise.
2523 * record-btrace.c (ui_out_field_uint): Remove.
2524 (btrace_call_history_insn_range, btrace_call_history): Use
2525 field_unsigned.
2526 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2527 field_unsigned.
2528 * ui-out.h (class ui_out) <field_unsigned>: New method.
2529 <do_field_unsigned>: Likewise.
2530
33eca680
TT
25312019-07-15 Tom Tromey <tromey@adacore.com>
2532
2533 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2534 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2535 * target.c (flash_erase_command): Use field_string.
2536 * infrun.c (print_signal_received_reason): Use field_string.
2537 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2538 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2539 field_string.
2540 * ada-tasks.c (print_ada_task_info): Use field_string.
2541
ca8d69be
TT
25422019-07-15 Tom Tromey <tromey@adacore.com>
2543
2544 * target.c (flash_erase_command): Use field_core_addr.
2545 * symfile.c (generic_load): Use field_core_addr.
2546 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2547 Use field_core_addr.
2548 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2549 field_core_addr.
2550
0d4e84ed
AB
25512019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2552
2553 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2554 value if its desired type is smaller than a CORE_ADDR and signed.
2555
9a49df9d
AB
25562019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2557
2558 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2559 of changes to field names, and use new is_reference field to
2560 decide if a property is a reference or not.
2561 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2562 field.
2563 (struct dwarf2_property_baton): Update header comment, rename
2564 'referenced_type' to 'property_type' and update comments.
2565 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2566 default property type, store in property baton, update to take
2567 accound of renamed field.
2568 (read_func_scope): Update call to attr_to_dynamic_prop.
2569 (read_array_type): Likewise.
2570 (dwarf2_per_cu_addr_sized_int_type): New function.
2571 (read_subrange_index_type): Move type finding code to
2572 dwarf2_per_cu_addr_sized_int_type.
2573 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2574 (dwarf2_per_cu_addr_type): New function.
2575 (set_die_type): Update calls to attr_to_dynamic_prop.
2576
b86352cf
AB
25772019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2578
2579 * dwarf2read.c (read_subrange_index_type): New function.
2580 (read_subrange_type): Move code into new function and call it.
2581 * gdbtypes.c (create_range_type): Add some asserts.
2582
603490bf
AB
25832019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2584
2585 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2586 update return statements.
2587 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2588 declaration, and update comment to match.
2589 * gdbtypes.c (resolve_dynamic_array): Update call to
2590 dwarf2_evaluate_property to match new return type.
2591
592f9d27
AB
25922019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2593
2594 * valarith.c (value_subscripted_rvalue): Change lowerbound
2595 parameter type from int to LONGEST.
2596 * value.h (value_subscripted_rvalue): Likewise in declaration.
2597
60cfcb20
AB
25982019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2599
2600 * cli/cli-utils.c (info_print_command_completer): New function.
2601 * cli/cli-utils.h: Add 'completer.h' include, and forward
2602 declaration for 'struct cmd_list_element'.
2603 (info_print_command_completer): Declare.
2604 * stack.c (_initialize_stack): Add completer for 'info locals' and
2605 'info args'.
2606 * symtab.c (_initialize_symtab): Add completer for 'info
2607 variables' and 'info functions'.
2608 * NEWS: Mention completion for additional info commands.
2609
b16507e0
AB
26102019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2611
2612 * cli/cli-utils.c (extract_info_print_args): Delete.
2613 (extract_arg_maybe_quoted): Delete.
2614 (info_print_options_defs): New variable.
2615 (make_info_print_options_def_group): New function.
2616 (extract_info_print_options): Define new function.
2617 * cli/cli-utils.h (extract_info_print_args): Delete.
2618 (struct info_print_options): New structure.
2619 (extract_info_print_options): Declare new function.
2620 * stack.c (info_locals_command): Update to use new
2621 extract_info_print_options, also add a header comment.
2622 (info_args_command): Likewise.
2623 * symtab.c (info_variables_command): Likewise.
2624 (info_functions_command): Likewise.
2625
021d8588
AB
26262019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2627
2628 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2629 to extract string arguments.
2630 * common/common-utils.c (extract_string_maybe_quoted): New function.
2631 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2632
b777eb6d
TT
26332019-07-11 Tom Tromey <tromey@adacore.com>
2634
2635 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2636 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2637 * top.h (gdbinit): Don't declare.
2638 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2639 into...
2640 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2641 * top.c (gdb_init): Don't call init_cli_cmds.
2642 (gdbinit): Remove.
2643 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2644
72ee03ff
TT
26452019-07-11 Tom Tromey <tromey@adacore.com>
2646
2647 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2648 after it has been moved.
2649
00db9531
SM
26502019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2651
2652 * valops.c (value_must_coerce_to_target): Change return type to
2653 bool.
2654 * value.h (value_must_coerce_to_target): Likewise.
2655
f2478a7e
SM
26562019-07-10 Simon Marchi <simon.marchi@efficios.com>
2657
2658 * breakpoint.c (is_hardware_watchpoint): Remove
2659 forward-declaration.
2660 (is_masked_watchpoint): Change return type to bool.
2661 (is_tracepoint): Likewise.
2662 (is_breakpoint): Likewise.
2663 (is_hardware_watchpoint): Likewise.
2664 (is_watchpoint): Likewise.
2665 (is_no_memory_software_watchpoint): Likewise.
2666 (is_catchpoint): Likewise.
2667 (breakpoint_1): Make FILTER parameter's return type bool.
2668 is_masked_watchpoint): Change return type to bool.
2669 (save_breakpoints): Make FILTER parameter's return type bool.
2670 * breakpoint.h (is_breakpoint): Change return type to bool.
2671 (is_watchpoint): Likewise.
2672 (is_catchpoint): Likewise.
2673 (is_tracepoint): Likewise.
2674
0d12e84c
TT
26752019-07-10 Tom Tromey <tom@tromey.com>
2676
2677 * defs.h: Don't include gdbarch.h.
2678 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2679 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2680 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2681 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2682 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2683 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2684 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2685 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2686 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2687 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2688 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2689 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2690 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2691 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2692 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2693 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2694 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2695 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2696 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2697 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2698 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2699 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2700 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2701 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2702 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2703 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2704 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2705
f06f1252
TT
27062019-07-10 Tom Tromey <tromey@adacore.com>
2707
2708 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2709 * breakpoint.c (init_ada_exception_breakpoint): Register as
2710 bp_catchpoint.
2711 (print_one_breakpoint_location, print_one_breakpoint): Use
2712 is_ada_exception_catchpoint.
2713 * ada-lang.c (class ada_catchpoint_location): Pass
2714 bp_loc_software_breakpoint to bp_location constructor.
2715 (is_ada_exception_catchpoint): New function.
2716
7a5d944b
TT
27172019-07-10 Tom Tromey <tromey@adacore.com>
2718
2719 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2720 VEC.
2721 (struct arm_exidx_entry): New method operator<.
2722 (struct arm_exidx_data) <section_maps>: Change type.
2723 (arm_exidx_data_free): Remove.
2724 (arm_exidx_data_key): Change type. Move lower.
2725 (arm_exidx_new_objfile): Update.
2726 (arm_compare_exidx_entries): Remove.
2727 (arm_find_exidx_entry, _initialize_arm_tdep)
2728
48c66e1d
TT
27292019-07-10 Tom Tromey <tromey@adacore.com>
2730
2731 * solib-spu.c (ocl_program_data_key): Change type.
2732 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2733 Update.
2734
a269fbf1
TT
27352019-07-10 Tom Tromey <tromey@adacore.com>
2736
2737 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2738 (struct solib_aix_inferior_data) <library_list>: Change type.
2739 (solib_aix_inferior_data_handle): Change type.
2740 (get_solib_aix_inferior_data): Update.
2741 (solib_aix_free_library_list): Remove.
2742 (library_list_start_library): Update.
2743 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2744 return type.
2745 (solib_aix_get_library_list)
2746 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2747 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2748
c294730c
TT
27492019-07-10 Tom Tromey <tromey@adacore.com>
2750
2751 * solib-dsbt.c (struct dsbt_info): Add initializers.
2752 (solib_dsbt_pspace_data): Change type.
2753 (dsbt_pspace_data_cleanup): Remove.
2754 (get_dsbt_info, _initialize_dsbt_solib): Update.
2755
9d52077d
TT
27562019-07-10 Tom Tromey <tromey@adacore.com>
2757
2758 * spu-tdep.c (spu_overlay_data): Change type.
2759 (spu_get_overlay_table, spu_overlay_new_objfile)
2760 (_initialize_spu_tdep): Update.
2761
22a20dca
TT
27622019-07-10 Tom Tromey <tromey@adacore.com>
2763
2764 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2765 destructor.
2766 (dbx_objfile_data_key): Change type and declare later.
2767 (DBX_SYMFILE_INFO): Rewrite.
2768 * dbxread.c (dbx_objfile_data_key): Change type.
2769 (dbx_symfile_init): Update.
2770 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2771 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2772 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2773
cb60f420
TT
27742019-07-10 Tom Tromey <tromey@adacore.com>
2775
2776 * jit.c (jit_program_space_key): Change type. Move lower.
2777 (get_jit_program_space_data): Update.
2778 (jit_program_space_data_cleanup): Remove.
2779 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2780 Update.
2781 (struct jit_program_space_data): Add initializers.
2782
51df2ae3
TT
27832019-07-10 Tom Tromey <tromey@adacore.com>
2784
2785 * solib-darwin.c (struct darwin_info): Add initializers.
2786 (solib_darwin_pspace_data): Change type.
2787 (darwin_pspace_data_cleanup): Remove.
2788 (get_darwin_info, _initialize_darwin_solib): Update.
2789
18101a35
TT
27902019-07-10 Tom Tromey <tromey@adacore.com>
2791
2792 * remote-sim.c (struct sim_inferior_data): Add initializers,
2793 constructor, and destructor.
2794 (sim_inferior_data_key): Change type. Move lower.
2795 (check_for_duplicate_sim_descriptor): Update.
2796 (get_sim_inferior_data): Use new. Update.
2797 (~sim_inferior_data_cleanup): Rename from
2798 sim_inferior_data_cleanup. Simplify.
2799 (gdbsim_close_inferior, simulator_command)
2800 (sim_command_completer, _initialize_remote_sim): Update.
2801 (next_pid, INITIAL_PID): Move earlier.
2802
05b08ac1
TT
28032019-07-10 Tom Tromey <tromey@adacore.com>
2804
2805 * python/python-internal.h (create_thread_object): Return
2806 gdbpy_ref.
2807 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2808 * python/py-inferior.c (struct threadlist_entry): Add
2809 constructor.
2810 <thread_obj>: Now a gdbpy_ref.
2811 (thread_to_thread_object): Update.
2812 (add_thread_object): Use new.
2813 (delete_thread_object): Use delete.
2814 (infpy_threads): Update.
2815 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2816 GIL.
2817
32372d80
TT
28182019-07-10 Tom Tromey <tromey@adacore.com>
2819
2820 * valops.c (value_cast): Specialize error message for Ada.
2821
5c458ae8
SM
28222019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2823
2824 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2825
4c462cb0
SM
28262019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2827
2828 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2829 bpstat_should_step): Return bool, adjust comments.
2830 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2831 bpstat_should_step): Likewise.
2832
89abbcc2
AH
28332019-07-10 Alan Hayward <alan.hayward@arm.com>
2834
2835 * features/Makefile: Use feature target descriptions for Arm.
2836 * features/arm/arm-core.c: Generate new file.
2837 * features/arm/arm-fpa.c: Likewise.
2838 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2839 * features/arm/arm-m-profile.c: Likewise.
2840 * features/arm/arm-vfpv2.c: Likewise.
2841 * features/arm/arm-vfpv3.c: Likewise.
2842 * features/arm/xscale-iwmmxt.c: Likewise.
2843 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2844
166a82be
AH
28452019-07-10 Alan Hayward <alan.hayward@arm.com>
2846
2847 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2848 ptrace earlier.
2849
9fb4c7e9
AH
28502019-07-10 Alan Hayward <alan.hayward@arm.com>
2851
2852 * features/aarch64-pauth.c: Regenerate.
2853
e2d0f980
SM
28542019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2855
2856 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2857 bool.
2858 (bpstat_what): Use false instead of 0.
2859
a38118e5
PA
28602019-07-09 Pedro Alves <palves@redhat.com>
2861
2862 * break-catch-throw.c (is_exception_catchpoint): New.
2863 * breakpoint.c (print_one_breakpoint_location): New parameter
2864 'raw_loc'. Handle it. Use
2865 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2866 looking at the breakpoint's type.
2867 (print_one_breakpoint): If handling "maint info breakpoints", also
2868 print locations of exception catchpoints.
2869 * breakpoint.h (is_exception_catchpoint): Declare.
2870
cb1e4e32
PA
28712019-07-09 Pedro Alves <palves@redhat.com>
2872
2873 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2874 "addr" field.
2875 (allocate_location_exception_catchpoint): New.
2876 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2877 (initialize_throw_catchpoint_ops): Install
2878 allocate_location_exception_catchpoint as allocate_location
2879 method.
2880 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2881 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2882 bp_loc_other.
2883 (breakpoint_address_is_meaningful): Delete.
2884 (bl_address_is_meaningful): New.
2885 (breakpoint_locations_match): Adjust comment.
2886 (bp_location_from_bp_type): New, factored out of...
2887 (bp_location::bp_location(breakpoint *)): ... this.
2888 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2889 factored out of...
2890 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2891 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2892 breakpoint_address_is_meaningful.
2893 (bp_locations_compare): Adjust comment.
2894 (update_global_location_list): Use bl_address_is_meaningful
2895 instead of breakpoint_address_is_meaningful.
2896 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2897 explicit.
2898 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2899 * python/py-breakpoint.c (bppy_get_location): No longer check
2900 whether location is null.
2901
b58a68fe
PA
29022019-07-09 Pedro Alves <palves@redhat.com>
2903
2904 PR c++/15468
2905 * breakpoint.c (print_one_breakpoint_location): Remove
2906 single-location assert.
2907
268a13a5
TT
29082019-07-09 Tom Tromey <tom@tromey.com>
2909
2910 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2911 * configure: Rebuild.
2912 * configure.ac: Change common to gdbsupport.
2913 * gdbsupport: Rename from common.
2914 * acinclude.m4: Change common to gdbsupport.
2915 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2916 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2917 gdbsupport.
2918 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2919 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2920 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2921 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2922 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2923 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2924 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2925 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2926 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2927 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2928 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2929 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2930 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2931 coff-pe-read.c, command.h, compile/compile-c-support.c,
2932 compile/compile-c.h, compile/compile-cplus-symbols.c,
2933 compile/compile-cplus-types.c, compile/compile-cplus.h,
2934 compile/compile-loc2c.c, compile/compile.c, completer.c,
2935 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2936 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2937 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2938 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2939 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2940 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2941 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2942 features/aarch64-core.c, features/aarch64-fpu.c,
2943 features/aarch64-pauth.c, features/aarch64-sve.c,
2944 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2945 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2946 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2947 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2948 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2949 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2950 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2951 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2952 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2953 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2954 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2955 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2956 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2957 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2958 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2959 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2960 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2961 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2962 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2963 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2964 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2965 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2966 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2967 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2968 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2969 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2970 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2971 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2972 minsyms.c, mips-linux-tdep.c, namespace.h,
2973 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2974 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2975 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2976 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2977 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2978 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2979 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2980 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2981 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2982 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2983 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2984 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2985 procfs.c, producer.c, progspace.h, psymtab.h,
2986 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2987 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2988 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2989 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2990 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2991 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2992 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2993 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2994 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2995 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2996 target-memory.c, target.c, target.h, target/waitstatus.c,
2997 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2998 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2999 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3000 unittests/array-view-selftests.c,
3001 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3002 unittests/common-utils-selftests.c,
3003 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3004 unittests/format_pieces-selftests.c,
3005 unittests/function-view-selftests.c,
3006 unittests/lookup_name_info-selftests.c,
3007 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3008 unittests/mkdir-recursive-selftests.c,
3009 unittests/observable-selftests.c,
3010 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3011 unittests/parse-connection-spec-selftests.c,
3012 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3013 unittests/scoped_fd-selftests.c,
3014 unittests/scoped_mmap-selftests.c,
3015 unittests/scoped_restore-selftests.c,
3016 unittests/string_view-selftests.c, unittests/style-selftests.c,
3017 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3018 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3019 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3020 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3021 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3022 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3023
5b0e2db4
AB
30242019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3025
3026 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3027 bool value.
3028 (decode_digits_ordinary): Set explicit_line field in sal.
3029 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3030 symtab_and_line that was set on an explicit line number in
3031 assembler code. Do always update the recorded symtab and line if
3032 we do skip the prologue.
3033
0ba852ab
AB
30342019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3035
3036 * breakpoint.c (set_breakpoint_location_function): Remove
3037 explicit_loc parameter.
3038 (momentary_breakpoint_from_master): Update call to
3039 set_breakpoint_location_function.
3040 (add_location_to_breakpoint): Likewise.
3041
b3a7d171
AB
30422019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3043
3044 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3045 required features based on default bfd type when no specific bfd
3046 is present.
3047
1f6f6e21
PW
30482019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3049
3050 * NEWS: Mention that GDB printf and eval commands can now print
3051 C-style and Ada-style convenience var strings without
3052 calling the inferior.
3053 * printcmd.c (printf_c_string): Locally print GDB internal var
3054 instead of transiting via the inferior.
3055 (printf_wide_c_string): Likewise.
3056
30572019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
3058
3059 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3060
0598af48
TT
30612019-07-04 Tom Tromey <tom@tromey.com>
3062
3063 PR tui/24724:
3064 * tui/tui-winsource.c (tui_clear_source_content): Update.
3065 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3066 (tui_update_breakpoint_info): Update.
3067 (tui_set_exec_info_content): Update.
3068 * tui/tui-source.c (tui_set_source_content_nil): Update.
3069 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3070 has_break.
3071 * tui/tui-data.h (enum tui_bp_flag): New.
3072 (tui_bp_flags): New enum flags type.
3073 (struct tui_source_element) <break_mode>: Change type. Rename
3074 from has_break.
3075 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3076 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3077 constants.
3078 * tui/tui-winsource.h: Fix comment.
3079
350fab54
AH
30802019-07-04 Alan Hayward <alan.hayward@arm.com>
3081
3082 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3083 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3084 (store_fpregs_to_thread)
3085 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3086 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3087 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3088 (IWMMXT_REGS_SIZE): Add define.
3089 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3090 (fetch_vfp_regs, store_vfp_regs)
3091 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3092 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3093
f0452268
AH
30942019-07-04 Alan Hayward <alan.hayward@arm.com>
3095
3096 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3097 defines.
3098 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3099 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3100 (ARM_INT_REGISTER_SIZE): ...to this.
3101 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3102 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3103 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3104 (arm_linux_collect_gregset, supply_nwfpe_register)
3105 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3106 defines.
3107 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3108 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3109 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3110 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3111 (arm_return_in_memory, arm_store_return_value)
3112 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3113 (arm_record_ld_st_multiple): Likewise.
3114 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3115 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3116
e935475c
AH
31172019-07-04 Alan Hayward <alan.hayward@arm.com>
3118
3119 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3120 AARCH64_DISPLACED_MODIFIED_INSNS.
3121 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3122 (aarch64_displaced_step_copy_insn): Likewise.
3123 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3124 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3125 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3126 ARM_DISPLACED_MODIFIED_INSNS.
3127 * arm-tdep.c (arm_gdbarch_init): Likewise.
3128 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3129 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3130 (struct arm_displaced_step_closure): Use
3131 ARM_DISPLACED_MODIFIED_INSNS.
3132
df0bb381
AH
31332019-07-04 Alan Hayward <alan.hayward@arm.com>
3134
3135 * features/Makefile: Remove unused xml files.
3136 * features/aarch64.xml: Remove.
3137 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3138 * features/i386/amd64-avx-avx512.xml: Remove.
3139 * features/i386/amd64-avx-linux.xml: Remove.
3140 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3141 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3142 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3143 * features/i386/amd64-avx-mpx.xml: Remove.
3144 * features/i386/amd64-avx.xml: Remove.
3145 * features/i386/amd64-linux.xml: Remove.
3146 * features/i386/amd64-mpx-linux.xml: Remove.
3147 * features/i386/amd64-mpx.xml: Remove.
3148 * features/i386/amd64.xml: Remove.
3149 * features/i386/i386-avx-avx512-linux.xml: Remove.
3150 * features/i386/i386-avx-avx512.xml: Remove.
3151 * features/i386/i386-avx-linux.xml: Remove.
3152 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3153 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3154 * features/i386/i386-avx-mpx-linux.xml: Remove.
3155 * features/i386/i386-avx-mpx.xml: Remove.
3156 * features/i386/i386-avx.xml: Remove.
3157 * features/i386/i386-linux.xml: Remove.
3158 * features/i386/i386-mmx-linux.xml: Remove.
3159 * features/i386/i386-mmx.xml: Remove.
3160 * features/i386/i386-mpx-linux.xml: Remove.
3161 * features/i386/i386-mpx.xml: Remove.
3162 * features/i386/i386.xml: Remove.
3163 * features/i386/x32-avx-avx512-linux.xml: Remove.
3164 * features/i386/x32-avx-linux.xml: Remove.
3165 * features/i386/x32-linux.xml: Remove.
3166
edd6266a
AH
31672019-07-04 Alan Hayward <alan.hayward@arm.com>
3168
3169 * regformats/aarch64.dat: Remove.
3170 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3171 * regformats/i386/amd64-avx-linux.dat: Remove.
3172 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3173 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3174 * regformats/i386/amd64-linux.dat: Remove.
3175 * regformats/i386/amd64-mpx-linux.dat: Remove.
3176 * regformats/i386/amd64.dat: Remove.
3177 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3178 * regformats/i386/i386-avx-linux.dat: Remove.
3179 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3180 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3181 * regformats/i386/i386-linux.dat: Remove.
3182 * regformats/i386/i386-mmx-linux.dat: Remove.
3183 * regformats/i386/i386-mpx-linux.dat: Remove.
3184 * regformats/i386/i386.dat: Remove.
3185 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3186 * regformats/i386/x32-avx-linux.dat: Remove.
3187 * regformats/i386/x32-linux.dat: Remove.
3188
2b40fda7
AH
31892019-07-04 Alan Hayward <alan.hayward@arm.com>
3190
3191 * aarch64-tdep.c: Remove xml self tests.
3192 * amd64-linux-tdep.c: Likewise.
3193 * amd64-tdep.c: Likewise.
3194 * i386-linux-tdep.c: Likewise.
3195 * i386-tdep.c: Likewise.
3196
5f4ba3e7
PA
31972019-07-03 Pedro Alves <palves@redhat.com>
3198
3199 PR cli/24732
3200 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3201 (pipe_cmd_option_defs): New.
3202 (make_pipe_cmd_options_def_group): New.
3203 (pipe_command): Use gdb::option::process_options.
3204 (pipe_command_completer): New function.
3205 (_initialize_cli_cmds): Install completer for "pipe" command.
3206
3d9be6f5
PA
32072019-07-03 Pedro Alves <palves@redhat.com>
3208
3209 * cli/cli-option.c (union option_value) <string>: New field.
3210 (struct option_def_and_value): Add ctor, move ctor, dtor and
3211 use DISABLE_COPY_AND_ASSIGN.
3212 (option_def_and_value::clear_value): New.
3213 (parse_option, save_option_value_in_ctx, get_val_type_str)
3214 (add_setshow_cmds_for_options): Handle var_string.
3215 * cli-option.h (union option_def::var_address) <string>: New
3216 field.
3217 (struct string_option_def): New.
3218 * maint-test-options.c (struct test_options_opts): Add default
3219 ctor and use DISABLE_COPY_AND_ASSIGN.
3220 <string_opt>: New field.
3221 (test_options_opts::~test_options_opts): New.
3222 (test_options_opts::dump): Also dump "-string".
3223 (test_options_option_defs): Install "string.
3224
41fc454c
PA
32252019-07-03 Pedro Alves <palves@redhat.com>
3226
3227 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3228 option_value with a null enumeration.
3229 (complete_options): Save the option values in the context.
3230 (save_option_value_in_ctx): New, factored out from ...
3231 (process_options): ... here.
3232 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3233 of the function.
3234 * maint-test-options.c (test_options_opts::dump): New, factored
3235 out from ...
3236 (maintenance_test_options_command_mode): ... here.
3237 (maintenance_test_options_command_completion_result): Delete.
3238 (maintenance_test_options_command_completion_text): Update
3239 comment.
3240 (maintenance_show_test_options_completion_result): Change
3241 prototype. Just print
3242 maintenance_test_options_command_completion_text.
3243 (save_completion_result): New.
3244 (maintenance_test_options_completer_mode): Pass options context to
3245 complete_options, and then save a dump.
3246 (_initialize_maint_test_options): Use add_cmd to install "maint
3247 show test-options-completion-result".
3248
fdbc9870
PA
32492019-07-03 Pedro Alves <palves@redhat.com>
3250
3251 * NEWS (New commands): Mention "with" and "maint with".
3252 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3253 (with_command, with_command_completer): New.
3254 (pipe_command): Adjust to new repeat_previous
3255 interface.
3256 (_initialize_cli_cmds): Install the "with" command and its "w"
3257 alias.
3258 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3259 declarations.
3260 * cli/cli-setshow.c (parse_cli_var_uinteger)
3261 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3262 argument strings for all var_types.
3263 (get_setshow_command_value_string): New, factored out from ...
3264 (do_show_command): ... this.
3265 * cli/cli-setshow.h: Include <string>.
3266 (get_setshow_command_value_string): Declare.
3267 * command.h (repeat_previous): Now returns const char *. Adjust
3268 comment.
3269 * maint.c: Include "cli/cli-cmds.h".
3270 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3271 (_initialize_maint_cmds): Register the "maintenance with" command.
3272 * top.c (repeat_previous): Move bits from pipe_command here:
3273 Return the saved command line, if any; error out if there's no
3274 command to relaunch.
3275
c6ac8931
PA
32762019-07-03 Pedro Alves <palves@redhat.com>
3277
3278 * NEWS (New commands): Mention "maint set/show test-settings"
3279 instead of "maint test-settings".
3280 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3281 (maintenance_test_settings_set_list): Rename to ...
3282 (maintenance_set_test_settings_list): ... this.
3283 (maintenance_test_settings_show_list): Rename to ...
3284 (maintenance_show_test_settings_list): ... this.
3285 (maintenance_test_settings_cmd): Delete.
3286 (maintenance_test_settings_set_cmd): ...
3287 (maintenance_set_test_settings_cmd): ... this.
3288 (maintenance_test_settings_show_cmd): ...
3289 (maintenance_show_test_settings_cmd): ... this.
3290 (maintenance_test_settings_show_value_cmd):
3291 (maintenance_show_test_settings_value_cmd): ... this.
3292 (_initialize_maint_test_settings): No longer install the "maint
3293 test-settings" prefix command. Rename "maint test-settings set"
3294 to "maint set test-settings", and "maint test-settings show" to
3295 "maint show test-settings". Adjust all subcommands.
3296
d1fcf2fd
PA
32972019-07-03 Pedro Alves <palves@redhat.com>
3298
3299 * maint-test-settings.c: Fix file's intro comment. Replace all
3300 references to "test-options" with references to "test-settings",
3301 in comments.
3302
970f9d09
PA
33032019-07-03 Pedro Alves <palves@redhat.com>
3304
3305 * maint-test-settings.c (maintenance_test_settings_xxx)
3306 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3307 New.
3308 (maintenance_test_settings_enums): Use them.
3309 (maintenance_test_settings_enum): Default to
3310 maintenance_test_settings_xxx.
3311 (_initialize_maint_test_settings): Initialize
3312 MAINTENANCE_TEST_SETTINGS_FILENAME.
3313
f3869b1a
SM
33142019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3315
3316 * breakpoint.h (remove_breakpoints_inf): Change return type to
3317 void, move function documentation here.
3318 * breakpoint.c (remove_breakpoints_inf): Change return type to
3319 void, move function documentation to header.
3320
54d66006
PA
33212019-07-02 Pedro Alves <palves@redhat.com>
3322
3323 * NEWS (Completion improvements): Mention "info threads".
3324 * thread.c (struct info_threads_opts, info_threads_option_defs)
3325 (make_info_threads_options_def_group): New.
3326 (info_threads_command): Use gdb::option::process_options.
3327 (info_threads_command_completer): New.
3328 (_initialize_thread): Use gdb::option::build_help to build the
3329 help text for "info threads".
3330
854f6088
SM
33312019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3332
3333 * defs.h (generic_load): Move from here...
3334 * symfile.h (generic_load): ... to here. Rename name parameter
3335 to args.
3336 * symfile.c (generic_load): Add comment.
3337
54ee4252
TT
33382019-07-01 Tom Tromey <tromey@adacore.com>
3339
3340 * dwarf2read.c
3341 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3342 declaration of without_params. Fix formatting.
3343
65392b3e
TT
33442019-07-01 Tom Tromey <tromey@adacore.com>
3345
3346 * ada-exp.y (find_primitive_type): Update.
3347 * ada-lang.h (ada_lookup_symbol): Update.
3348 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3349 parameter.
3350 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3351
7d7571f0
SDJ
33522019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3353
3354 PR breakpoints/24541
3355 * gdbarch.c: Regenerate.
3356 * gdbarch.h: Regenerate.
3357 * gdbarch.sh: Add 'stap_adjust_register'.
3358 * i386-tdep.c: Include '<unordered_set>'.
3359 (i386_stap_adjust_register): New function.
3360 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3361 * stap-probe.c (stap_parse_register_operand): Call
3362 'gdbarch_stap_adjust_register'.
3363
5af5392a
SDJ
33642019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3365
3366 PR python/24742
3367 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3368 * python/python.c (do_start_initialization): Use 'xmalloc'
3369 instead of 'PyMem_Malloc'.
3370
10d06d82
TT
33712019-06-28 Tom Tromey <tromey@adacore.com>
3372
3373 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3374 for Ada.
3375
1b7f24cd
TT
33762019-06-27 Tom Tromey <tromey@adacore.com>
3377
3378 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3379 objfile_key.
3380 (arm_find_mapping_symbol, arm_record_special_symbol)
3381 (_initialize_arm_tdep): Update.
3382 (arm_objfile_data_free): Remove.
3383
3d507ff2
TT
33842019-06-27 Tom Tromey <tromey@adacore.com>
3385
3386 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3387 to cp_print_static_field.
3388
762c164d
TT
33892019-06-26 Tom Tromey <tromey@adacore.com>
3390
3391 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3392 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3393 declare.
3394
aa2f9bcf
AH
33952019-06-26 Alan Hayward <alan.hayward@arm.com>
3396
3397 * features/aarch64-core.c (create_feature_aarch64_core):
3398 Regenerate.
3399 * features/aarch64-core.xml: Add cpsr flags.
3400
3426ae57
AH
34012019-06-26 Alan Hayward <alan.hayward@arm.com>
3402
3403 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3404 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3405
4838e44c
SM
34062019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3407
3408 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3409 field.
3410 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3411 use.
3412 (arm_record_special_symbol): Don't insert new symbol in sorted
3413 position, push it at the end.
3414
54cc7474
SM
34152019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3416
3417 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3418 (arm_mapping_symbol_s): Remove.
3419 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3420 (arm_mapping_symbol_vec): New typedef.
3421 (struct arm_per_objfile): Add constructor.
3422 <section_maps>: Change type to
3423 std::unique_ptr<arm_mapping_symbol_vec[]>.
3424 (arm_compare_mapping_symbols): Remove.
3425 (arm_find_mapping_symbol): Adjust to section_maps type change.
3426 (arm_objfile_data_free): Call delete on arm_per_objfile.
3427 (arm_record_special_symbol): Adjust to section_maps type change.
3428 Allocate arm_per_objfile with new.
3429
b65b566c
PW
34302019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3431
3432 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3433 with the command prefix.
3434
c2fc64f5
TT
34352019-06-25 Tom Tromey <tom@tromey.com>
3436
3437 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3438 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3439
fb54fa76
TT
34402019-06-25 Tom Tromey <tom@tromey.com>
3441
3442 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3443 type.
3444 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3445 protected.
3446
f7952c57
TT
34472019-06-25 Tom Tromey <tom@tromey.com>
3448
3449 * tui/tui-winsource.c
3450 (tui_source_window_base::set_is_exec_point_at): Add check against
3451 LOA_ADDRESS.
3452
17568d78
TT
34532019-06-25 Tom Tromey <tom@tromey.com>
3454
3455 * tui/tui-source.c (tui_set_source_content): Don't check before
3456 xfree.
3457 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3458
53e7cdba
TT
34592019-06-25 Tom Tromey <tom@tromey.com>
3460
3461 * tui/tui-winsource.h (tui_update_source_window_as_is)
3462 (tui_alloc_source_buffer, tui_line_is_displayed)
3463 (tui_addr_is_displayed): Change type of win_info.
3464 * tui/tui-winsource.c (tui_update_source_window_as_is)
3465 (tui_clear_source_content, tui_show_source_line)
3466 (tui_show_source_content, tui_source_window_base::refill)
3467 (tui_source_window_base::set_is_exec_point_at)
3468 (tui_source_window_base::set_is_exec_point_at)
3469 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3470 (tui_alloc_source_buffer, tui_line_is_displayed)
3471 (tui_addr_is_displayed): Change type of win_info. Update.
3472 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3473 (tui_source_window_base::do_make_visible_with_new_height):
3474 Update.
3475 * tui/tui-source.c (tui_set_source_content)
3476 (tui_set_source_content_nil)
3477 (tui_source_window::do_scroll_vertical): Update.
3478 * tui/tui-layout.c (show_layout): Update.
3479 * tui/tui-disasm.c (tui_set_disassem_content)
3480 (tui_disasm_window::do_scroll_vertical): Update.
3481 * tui/tui-data.h (tui_win_content): Remove.
3482 (struct tui_gen_win_info) <content, content_size>: Remove.
3483 (struct tui_source_element): Add initializers and destructor.
3484 (union tui_which_element, struct tui_win_element): Remove.
3485 (struct tui_source_window_base) <content>: New field.
3486 (struct tui_data_window): Remove destructor.
3487 (tui_alloc_content, tui_free_win_content)
3488 (tui_free_all_source_wins_content): Don't declare.
3489 * tui/tui-data.c (tui_initialize_static_data): Update.
3490 (init_content_element, tui_alloc_content): Remove.
3491 (~tui_gen_win_info): Update.
3492 (~tui_data_window, tui_free_all_source_wins_content)
3493 (tui_free_win_content, free_content, free_content_elements):
3494 Remove.
3495
7908abbf
TT
34962019-06-25 Tom Tromey <tom@tromey.com>
3497
3498 * tui/tui-winsource.h (tui_clear_source_content)
3499 (tui_erase_source_content, tui_show_source_content): Change type
3500 of win_info.
3501 * tui/tui-winsource.c (tui_clear_source_content)
3502 (tui_erase_source_content, tui_show_source_content): Change type
3503 of win_info.
3504 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3505 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3506 win_info.
3507 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3508 win_info.
3509 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3510
02c28df0
TT
35112019-06-25 Tom Tromey <tom@tromey.com>
3512
3513 * tui/tui-winsource.c (tui_clear_source_content)
3514 (tui_source_window_base::set_is_exec_point_at): Update.
3515 * tui/tui-source.c (tui_set_source_content_nil): Update.
3516 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3517 a bool.
3518 * tui/tui-data.c (init_content_element): Update.
3519
6658b1bf
TT
35202019-06-25 Tom Tromey <tom@tromey.com>
3521
3522 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3523 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3524 * tui/tui-layout.c (init_and_make_win): Update.
3525 * tui/tui.h (enum tui_win_type): Update.
3526 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3527 tui_win_is_auxillary.
3528 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3529 tui_win_is_auxillary.
3530
21e1c91e
TT
35312019-06-25 Tom Tromey <tom@tromey.com>
3532
3533 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3534 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3535 (tui_delete_data_content_windows, tui_display_all_data)
3536 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3537 Update.
3538 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3539 * tui/tui-regs.c (tui_last_regs_line_no)
3540 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3541 (tui_show_registers): Update.
3542 (tui_show_register_group): Return void. Update.
3543 (tui_display_registers_from, tui_display_reg_element_at_line)
3544 (tui_display_registers_from_line, tui_check_register_values):
3545 Update.
3546 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3547 member.
3548 (struct tui_data_window) <regs_content>: Now a std::vector.
3549 <regs_content_count>: Remove.
3550 (tui_add_content_elements, tui_free_data_content): Don't declare.
3551 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3552 (init_content_element): Remove DATA_WIN case. Add assert.
3553 (tui_add_content_elements): Remove.
3554 (tui_data_window): Update.
3555 (tui_free_data_content): Remove.
3556 (free_content_elements): Remove DATA_WIN case.
3557
115ac53b
TT
35582019-06-25 Tom Tromey <tom@tromey.com>
3559
3560 * tui/tui-data.c (tui_data_item_window): Update.
3561 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3562 * tui/tui-windata.c (tui_display_all_data)
3563 (tui_display_data_from_line): Update.
3564 (tui_check_data_values): Remove.
3565 * tui/tui-regs.c (tui_show_register_group)
3566 (tui_display_reg_element_at_line): Update.
3567 * tui/tui-hooks.c (tui_register_changed)
3568 (tui_refresh_frame_and_register_information): Call
3569 tui_check_register_values.
3570 * tui/tui-data.h (struct tui_data_window) <data_content,
3571 data_content_count, data_type>: Remove.
3572 (enum tui_data_type): Remove.
3573
3574 * tui/tui-data.c (tui_data_window::clear_detail)
3575 (~tui_data_window): Update.
3576
eaf9738b
TT
35772019-06-25 Tom Tromey <tom@tromey.com>
3578
3579 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3580 declare.
3581 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3582 Rename from tui_first_data_item_displayed. Update.
3583 (tui_data_window::refresh_all)
3584 (tui_data_window::do_scroll_vertical): Update.
3585 * tui/tui-data.h (struct tui_data_window)
3586 <first_data_item_displayed>: Declare new method.
3587
31ca4723
TT
35882019-06-25 Tom Tromey <tom@tromey.com>
3589
3590 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3591 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3592 contents...
3593 (tui_initialize_static_data): ...here.
3594
41bcff7f
TT
35952019-06-25 Tom Tromey <tom@tromey.com>
3596
3597 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3598 (tui_display_registers_from, tui_check_register_values): Update.
3599 (tui_display_register): Remove win_info parameter; update.
3600 (tui_get_register): Change type of parameters.
3601 * tui/tui-data.h (struct tui_data_element): Remove.
3602 (union tui_which_element) <data>: Remove.
3603 <data_window>: Change type.
3604 (struct tui_data_item_window): New.
3605 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3606 case. Add assert.
3607 (~tui_data_item_window): New destructor.
3608 (free_content_elements): Remove DATA_ITEM_WIN case.
3609
d2802c33
TT
36102019-06-25 Tom Tromey <tom@tromey.com>
3611
3612 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3613 Remove.
3614
dd835f8b
TT
36152019-06-25 Tom Tromey <tom@tromey.com>
3616
3617 * tui/tui-data.h (struct tui_command_element): Remove.
3618 (union tui_which_element) <command>: Remove.
3619 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3620 assert.
3621 (free_content_elements): Remove CMD_WIN case.
3622
bd7db367
TT
36232019-06-25 Tom Tromey <tom@tromey.com>
3624
3625 * tui/tui-layout.c (tui_set_layout): Update.
3626 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3627 * tui/tui-data.c (layout_def): Update.
3628
3add462f
TT
36292019-06-25 Tom Tromey <tom@tromey.com>
3630
3631 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3632 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3633 (tui_source_window_base::set_new_height): Update.
3634 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3635 Update.
3636 (tui_set_locator_fullname, tui_set_locator_info)
3637 (tui_show_frame_info): Update.
3638 * tui/tui-source.c (tui_set_source_content)
3639 (tui_source_is_displayed): Update.
3640 * tui/tui-layout.c (show_source_disasm_command, show_data)
3641 (show_source_or_disasm_and_command): Update.
3642 * tui/tui-disasm.c (tui_set_disassem_content)
3643 (tui_get_begin_asm_address): Update.
3644 * tui/tui-data.h (struct tui_locator_element): Remove.
3645 (union tui_which_element) <locator>: Remove.
3646 (struct tui_locator_window): New.
3647 (tui_locator_win_info_ptr): Change return type.
3648 * tui/tui-data.c (_locator): Change type.
3649 (tui_locator_win_info_ptr): Change return type.
3650 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3651 (tui_alloc_content): Add assert.
3652
489e9d8b
TT
36532019-06-25 Tom Tromey <tom@tromey.com>
3654
3655 * tui/tui-winsource.c
3656 (tui_exec_info_window::maybe_allocate_content): New method.
3657 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3658 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3659 (make_source_or_disasm_window): Add cast.
3660 * tui/tui-data.h (union tui_which_element) <simple_string>:
3661 Remove.
3662 (struct tui_source_info): New.
3663 (struct tui_source_window_base) <execution_info>: Change type.
3664 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3665 case, and add assert.
3666 (tui_alloc_content): Add assert.
3667
c3fabb7d
TT
36682019-06-25 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3671 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3672 * tui/tui-data.c (tui_alloc_win_info): Remove.
3673
bbc228ee
TT
36742019-06-25 Tom Tromey <tom@tromey.com>
3675
3676 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3677 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3678 can_highlight.
3679
5fcee43a
TT
36802019-06-25 Tom Tromey <tom@tromey.com>
3681
3682 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3683 make_visible_with_new_height method.
3684 (tui_win_info::make_visible_with_new_height): New method.
3685 (tui_source_window_base::do_make_visible_with_new_height)
3686 (tui_data_window::do_make_visible_with_new_height)
3687 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3688 (make_visible_with_new_height): Remove.
3689 (tui_resize_all, tui_adjust_win_heights): Use
3690 make_visible_with_new_height method.
3691 * tui/tui-data.h (struct tui_win_info)
3692 <do_make_visible_with_new_height, make_visible_with_new_height>:
3693 New methods.
3694 (struct tui_source_window_base, struct tui_data_window)
3695 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3696 methods.
3697
d83f1fe6
TT
36982019-06-25 Tom Tromey <tom@tromey.com>
3699
3700 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3701 method.
3702 (update_tab_width): Call update_tab_width method.
3703 * tui/tui-data.h (struct tui_win_info)
3704 (struct tui_source_window_base) <update_tab_width>: New methods.
3705
17374de4
TT
37062019-06-25 Tom Tromey <tom@tromey.com>
3707
3708 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3709 parameter.
3710 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3711 parameter.
3712 (tui_gen_win_info::make_visible): Update.
3713 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3714 parameter.
3715 * tui/tui-data.h (enum tui_box): New enum.
3716 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3717
f936bca2
TT
37182019-06-25 Tom Tromey <tom@tromey.com>
3719
3720 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3721 init_and_make_win for EXEC_INFO_WIN.
3722 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3723 longer inline.
3724 (struct tui_win_info) <~tui_win_info>: Inline.
3725 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3726 Don't declare.
3727 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3728 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3729 Remove.
3730 (tui_initialize_static_data): Update.
3731 (~tui_gen_win_info): Handle more cleanup here.
3732 (~tui_source_window_base): Delete "execution_info".
3733 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3734
d6ba6a11
TT
37352019-06-25 Tom Tromey <tom@tromey.com>
3736
3737 * tui/tui-layout.c (make_command_window): Don't set
3738 can_highlight.
3739 (show_source_disasm_command): Call the reset method.
3740 (show_data): Don't set can_highlight. Call the reset method.
3741 (tui_gen_win_info::reset): Rename from init_gen_win_info
3742 (init_and_make_win): Simplify. Return tui_gen_win_info.
3743 (show_source_or_disasm_and_command): Call the reset method.
3744 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3745 (struct tui_cmd_window): Set can_highlight.
3746
48a3bd16
TT
37472019-06-25 Tom Tromey <tom@tromey.com>
3748
3749 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3750 from make_visible.
3751 (tui_make_visible, tui_make_invisible): Rewrite.
3752 (tui_win_info::make_visible): Remove.
3753 (tui_source_window_base::make_visible): Update.
3754 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3755 method. Moved from...
3756 (struct tui_win_info) <make_visible>: ...here.
3757
c3bd716f
TT
37582019-06-25 Tom Tromey <tom@tromey.com>
3759
3760 * tui/tui-winsource.c
3761 (tui_source_window_base::do_scroll_horizontal): Remove direction
3762 parameter.
3763 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3764 direction parameter.
3765 * tui/tui-win.c (tui_win_info::forward_scroll)
3766 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3767 (tui_win_info::right_scroll): Update.
3768 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3769 direction parameter.
3770 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3771 direction parameter.
3772 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3773 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3774 Remove direction parameter.
3775 (struct tui_source_window_base, struct tui_source_window)
3776 (struct tui_disasm_window, struct tui_data_window)
3777 (struct tui_cmd_window): Update.
3778
21c32dca
TT
37792019-06-25 Tom Tromey <tom@tromey.com>
3780
3781 * tui/tui-winsource.h (tui_set_exec_info_content)
3782 (tui_show_exec_info_content, tui_erase_exec_info_content)
3783 (tui_clear_exec_info_content, tui_update_exec_info): Change
3784 argument to tui_source_window_base.
3785 * tui/tui-winsource.c (tui_set_exec_info_content)
3786 (tui_show_exec_info_content, tui_erase_exec_info_content)
3787 (tui_clear_exec_info_content, tui_update_exec_info): Change
3788 argument to tui_source_window_base.
3789
73fbdc65
TT
37902019-06-25 Tom Tromey <tom@tromey.com>
3791
3792 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3793 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3794
33325343
TT
37952019-06-25 Tom Tromey <tom@tromey.com>
3796
3797 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3798 check.
3799
29d2c474
TT
38002019-06-25 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3803 type to void.
3804 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3805 type to void.
3806 * tui/tui-source.c (tui_set_source_content): Update.
3807 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3808
152f3f4b
TT
38092019-06-25 Tom Tromey <tom@tromey.com>
3810
3811 * tui/tui-win.c (window_name_completer, tui_set_focus)
3812 (tui_all_windows_info): Use name method.
3813 * tui/tui-data.h (struct tui_gen_win_info)
3814 (struct tui_source_window, struct tui_disasm_window)
3815 (struct tui_data_window, struct tui_cmd_window) <name>: New
3816 method.
3817 (tui_win_name): Don't declare.
3818 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3819 (tui_win_name): Remove.
3820
be4da588
TT
38212019-06-25 Tom Tromey <tom@tromey.com>
3822
3823 * tui/tui-winsource.h (tui_update_source_window)
3824 (tui_update_source_window_as_is): Change parameter type.
3825 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3826 to be a tui_source_window_base.
3827 (tui_update_source_window_as_is): Likewise.
3828 * tui/tui-win.c (make_visible_with_new_height): Update.
3829
5b81daba
TT
38302019-06-25 Tom Tromey <tom@tromey.com>
3831
3832 * tui/tui-winsource.c (tui_erase_source_content)
3833 (tui_show_source_content, tui_show_exec_info_content)
3834 (tui_erase_exec_info_content): Use refresh_window method.
3835 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3836 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3837 from tui_refresh_win.
3838 (tui_data_window::refresh_window): New method.
3839 (tui_win_info::refresh, tui_source_window_base::refresh)
3840 (tui_refresh_all): Use refresh_window method.
3841 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3842 method.
3843 * tui/tui-regs.c (tui_display_register): Call refresh_window
3844 method.
3845 * tui/tui-layout.c (show_source_disasm_command)
3846 (show_source_or_disasm_and_command): Call refresh_window method.
3847 * tui/tui-data.h (struct tui_gen_win_info)
3848 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3849 New method.
3850
cb2ce893
TT
38512019-06-25 Tom Tromey <tom@tromey.com>
3852
3853 * tui/tui.c (tui_rl_other_window, tui_enable)
3854 (tui_is_window_visible, tui_get_command_dimension): Update.
3855 * tui/tui-winsource.c (tui_update_source_window_as_is)
3856 (tui_clear_source_content, tui_erase_source_content)
3857 (tui_show_source_line, tui_source_window_base::refill)
3858 (tui_source_window_base::do_scroll_horizontal)
3859 (tui_source_window_base::set_is_exec_point_at)
3860 (tui_update_breakpoint_info, tui_set_exec_info_content)
3861 (tui_alloc_source_buffer, tui_line_is_displayed)
3862 (tui_addr_is_displayed): Update.
3863 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3864 (tui_check_and_display_highlight_if_needed)
3865 (tui_win_info::make_visible, tui_win_info::refresh)
3866 (tui_refresh_all): Update.
3867 * tui/tui-windata.c (tui_first_data_item_displayed)
3868 (tui_delete_data_content_windows, tui_erase_data_content)
3869 (tui_display_all_data, tui_data_window::refresh_all)
3870 (tui_check_data_values): Update.
3871 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3872 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3873 (tui_win_info::backward_scroll, tui_refresh_all_win)
3874 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3875 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3876 (tui_source_window_base::set_new_height)
3877 (tui_data_window::set_new_height)
3878 (make_invisible_and_set_new_height)
3879 (make_visible_with_new_height, new_height_ok)
3880 (parse_scrolling_args): Update.
3881 * tui/tui-stack.c (tui_show_frame_info): Update.
3882 * tui/tui-source.c (tui_set_source_content)
3883 (tui_set_source_content_nil, tui_source_is_displayed)
3884 (tui_source_window::do_scroll_vertical): Update.
3885 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3886 (tui_display_registers_from, tui_display_reg_element_at_line)
3887 (tui_check_register_values, tui_reg_command): Update.
3888 * tui/tui-layout.c (tui_default_win_height)
3889 (show_source_disasm_command, show_data, init_and_make_win)
3890 (show_source_or_disasm_and_command): Update.
3891 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3892 (tui_redisplay_readline, tui_mld_flush)
3893 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3894 (tui_getc): Update.
3895 * tui/tui-disasm.c (tui_set_disassem_content)
3896 (tui_disasm_window::do_scroll_vertical): Update.
3897 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3898 Now virtual.
3899 (struct tui_win_info): Derive from tui_gen_win_info.
3900 <~tui_win_info>: Mark as override.
3901 <generic>: Remove member.
3902 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3903 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3904 (~tui_data_window, ~tui_win_info)
3905 (tui_free_all_source_wins_content): Update.
3906 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3907
ab313b35
TT
39082019-06-25 Tom Tromey <tom@tromey.com>
3909
3910 * tui/tui-layout.c (init_and_make_win): Use new.
3911 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3912 destructor, initializers.
3913 (tui_alloc_generic_win_info): Don't declare.
3914 * tui/tui-data.c (_locator): Add argument to constructor.
3915 (source_win, disasm_win): New globals.
3916 (exec_info): Remove.
3917 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3918 Update.
3919 (tui_alloc_generic_win_info): Remove.
3920 (init_content_element): Use new.
3921 (tui_win_info::tui_win_info): Update.
3922 (free_content_elements) <case DATA_WIN>: Use delete.
3923
dc2c33e4
TT
39242019-06-25 Tom Tromey <tom@tromey.com>
3925
3926 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3927 * tui/tui-windata.c (tui_first_data_item_displayed)
3928 (tui_delete_data_content_windows): Update.
3929 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3930 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3931 (tui_display_registers_from, tui_check_register_values): Update.
3932 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3933 pointer.
3934 * tui/tui-data.c (init_content_element): Update. Allocate the new
3935 window.
3936 (tui_free_data_content): Update.
3937 (free_content_elements) <case DATA_WIN>: Free the window.
3938
214a5cbe
TT
39392019-06-25 Tom Tromey <tom@tromey.com>
3940
3941 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3942 Update.
3943 * tui/tui-layout.c (make_command_window)
3944 (show_source_disasm_command, show_data, init_and_make_win)
3945 (show_source_or_disasm_and_command): Update.
3946 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3947 method.
3948 <can_highight, is_highlighted>: Now bool.
3949 (tui_set_win_highlight): Don't declare.
3950 * tui/tui-data.c (tui_set_win_highlight): Remove.
3951
8e2daf15
TT
39522019-06-25 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-wingeneral.c (make_visible): Remove check of window
3955 type.
3956
8903bd8a
TT
39572019-06-25 Tom Tromey <tom@tromey.com>
3958
3959 * tui/tui-win.c (tui_win_info::max_height)
3960 (tui_cmd_window::max_height): New methods.
3961 (new_height_ok): Call max_height.
3962 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3963 <max_height>: New method.
3964
3f02ce1e
TT
39652019-06-25 Tom Tromey <tom@tromey.com>
3966
3967 * tui/tui-win.c (tui_source_window_base::set_new_height)
3968 (tui_data_window::set_new_height): New methods.
3969 (make_invisible_and_set_new_height): Call set_new_height method.
3970 * tui/tui-data.h (struct tui_win_info)
3971 (struct tui_source_window_base, struct tui_data_window)
3972 <set_new_height>: New method.
3973
1825f487
TT
39742019-06-25 Tom Tromey <tom@tromey.com>
3975
3976 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3977 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3978 tui_refresh_data_win.
3979 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3980 method.
3981 (tui_refresh_all_win): Call the refresh_all method.
3982 (tui_set_focus): Likewise.
3983 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3984 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3985 Likewise.
3986
ad54d15b
TT
39872019-06-25 Tom Tromey <tom@tromey.com>
3988
3989 * tui/tui-winsource.h (tui_refill_source_window)
3990 (tui_set_is_exec_point_at): Don't declare.
3991 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3992 (tui_source_window_base::refill): Rename from
3993 tui_refill_source_window.
3994 (tui_source_window_base::do_scroll_horizontal): Update.
3995 (tui_source_window_base::set_is_exec_point_at): Rename from
3996 tui_set_is_exec_point_at.
3997 (tui_update_all_breakpoint_info): Update.
3998 * tui/tui-stack.c (tui_show_frame_info): Update.
3999 * tui/tui-layout.c (show_data): Add cast.
4000 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4001 * tui/tui-data.h (struct tui_source_window_base) <refill,
4002 set_is_exec_point_at>: New methods.
4003 (tui_source_windows, tui_add_to_source_windows): Update types.
4004 (tui_add_to_source_windows): Remove redundant declaration.
4005 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4006 (tui_source_windows): Change return type.
4007 (tui_clear_source_windows_detail): Update.
4008 (tui_add_to_source_windows): Change type of parameter.
4009 (tui_free_all_source_wins_content): Update.
4010
2042b506
TT
40112019-06-25 Tom Tromey <tom@tromey.com>
4012
4013 * tui/tui-wingeneral.c (tui_win_info::refresh)
4014 (tui_source_window_base::refresh): New methods.
4015 (tui_refresh_all): Call the refresh method.
4016 * tui/tui-data.h (struct tui_win_info)
4017 (struct tui_source_window_base) <refresh>: New method.
4018
56122977
TT
40192019-06-25 Tom Tromey <tom@tromey.com>
4020
4021 * tui/tui.h (tui_is_window_visible): Return bool.
4022 * tui/tui.c (tui_is_window_visible): Return bool.
4023 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4024 (tui_make_visible, tui_make_invisible)
4025 (tui_win_info::make_visible)
4026 (tui_source_window_base::make_visible, make_all_visible)
4027 (tui_make_all_visible, tui_make_all_invisible): Update.
4028 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4029 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4030 bool.
4031 (struct tui_win_info, struct tui_source_window_base)
4032 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4033 * tui/tui-data.c (tui_init_generic_part): Update.
4034
cda37efb
TT
40352019-06-25 Tom Tromey <tom@tromey.com>
4036
4037 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4038 (tui_source_window_base::make_visible): New methods.
4039 (make_all_visible): Make method call.
4040 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4041 (struct tui_source_window_base, struct tui_cmd_window): Override
4042 make_visible.
4043 (tui_win_is_source_type): Don't declare.
4044 * tui/tui-data.c (tui_win_is_source_type): Remove.
4045
6a0ee02c
TT
40462019-06-25 Tom Tromey <tom@tromey.com>
4047
4048 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4049 NULL check.
4050
63901aec
TT
40512019-06-25 Tom Tromey <tom@tromey.com>
4052
4053 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4054 Inline constructor. Add initializers for members.
4055 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4056 constructors; now inline in class.
4057
ceb13a13
TT
40582019-06-25 Tom Tromey <tom@tromey.com>
4059
4060 * tui/tui-regs.c (tui_show_registers): Update.
4061 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4062 bool.
4063 * tui/tui-data.c (tui_data_window::clear_detail)
4064 (tui_data_window): Update.
4065
238eb706
TT
40662019-06-25 Tom Tromey <tom@tromey.com>
4067
4068 * tui/tui-windata.c (tui_display_all_data)
4069 (tui_display_data_from_line, tui_display_data_from)
4070 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4071 Update.
4072 * tui/tui-regs.c (tui_last_regs_line_no)
4073 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4074 (tui_show_registers, tui_show_register_group)
4075 (tui_display_registers_from, tui_display_reg_element_at_line)
4076 (tui_display_registers_from_line, tui_check_register_values)
4077 (tui_reg_next, tui_reg_prev): Update.
4078 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4079 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4080 tui_data_window.
4081 (struct tui_win_info) <detail>: Remove. Add new fields from
4082 tui_data_info.
4083 (TUI_DATA_WIN): Add cast.
4084 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4085 (~tui_data_window): Simplify.
4086
81491aa0
TT
40872019-06-25 Tom Tromey <tom@tromey.com>
4088
4089 * tui/tui-layout.c (show_source_disasm_command)
4090 (show_source_or_disasm_and_command): Update.
4091 * tui/tui-io.c (update_cmdwin_start_line)
4092 (tui_redisplay_readline): Update.
4093 * tui/tui-data.h (struct tui_command_info): Remove.
4094 (struct tui_win_info) <detail>: Remove command_info member.
4095 (struct tui_data_window) <start_line>: New member, from
4096 tui_command_info.
4097 (TUI_CMD_WIN): Add casts.
4098
e6e41501
TT
40992019-06-25 Tom Tromey <tom@tromey.com>
4100
4101 * tui/tui-winsource.c (tui_update_source_window)
4102 (tui_refill_source_window)
4103 (tui_source_window_base::do_scroll_horizontal)
4104 (tui_update_breakpoint_info, tui_set_exec_info_content)
4105 (tui_show_exec_info_content, tui_erase_exec_info_content)
4106 (tui_clear_exec_info_content): Update.
4107 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4108 Update.
4109 * tui/tui-win.c (make_invisible_and_set_new_height)
4110 (make_visible_with_new_height): Update.
4111 * tui/tui-source.c (tui_set_source_content)
4112 (tui_show_symtab_source): Update.
4113 * tui/tui-layout.c (extract_display_start_addr)
4114 (show_source_disasm_command, show_data)
4115 (make_source_or_disasm_window)
4116 (show_source_or_disasm_and_command): Update.
4117 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4118 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4119 "gdbarch".
4120 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4121 to tui_source_window_base.
4122 (struct tui_win_info) <detail>: Remove source_info member.
4123 (struct tui_source_window_base) <has_locator>: Inline.
4124 Move contents from tui_source_info; rename has_locator member to
4125 m_has_locator.
4126 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4127 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4128 header file.
4129 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4130 Simplify.
4131 (tui_free_all_source_wins_content): Cast to
4132 tui_source_window_base.
4133
44f0e208
TT
41342019-06-25 Tom Tromey <tom@tromey.com>
4135
4136 * tui/tui-win.c (make_invisible_and_set_new_height)
4137 (make_visible_with_new_height): Call has_locator method.
4138 * tui/tui-layout.c (show_source_disasm_command, show_data)
4139 (show_source_or_disasm_and_command): Update for bool change.
4140 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4141 (tui_win_info) <has_locator>: New method.
4142 (struct tui_source_window_base) <has_locator>: New method.
4143 (tui_win_has_locator): Don't declare.
4144 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4145 from tui_win_has_locator.
4146 (tui_source_window_base): Use false, not FALSE.
4147
7778b912
TT
41482019-06-25 Tom Tromey <tom@tromey.com>
4149
4150 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4151 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4152 clear_detail method directly.
4153 (tui_clear_win_detail): Remove.
4154
f83d391c
TT
41552019-06-25 Tom Tromey <tom@tromey.com>
4156
4157 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4158 "this", not TUI_DISASM_WIN.
4159
13446e05
TT
41602019-06-25 Tom Tromey <tom@tromey.com>
4161
4162 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4163 declare.
4164 * tui/tui-winsource.c
4165 (tui_source_window_base::do_scroll_horizontal): Rename from
4166 tui_horizontal_source_scroll.
4167 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4168 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4169 from tui_vertical_data_scroll.
4170 * tui/tui-win.h (tui_scroll): Don't declare.
4171 * tui/tui-win.c (tui_win_info::forward_scroll)
4172 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4173 (tui_win_info::right_scroll): Rename and update.
4174 (tui_scroll_forward_command, tui_scroll_backward_command)
4175 (tui_scroll_left_command, tui_scroll_right_command): Update.
4176 (tui_scroll): Remove.
4177 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4178 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4179 from tui_vertical_source_scroll.
4180 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4181 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4182 from tui_vertical_disassem_scroll.
4183 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4184 do_scroll_horizontal>: New methods.
4185 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4186 Likewise.
4187 (struct tui_source_window_base): Add do_scroll_horizontal.
4188 (struct tui_source_window, struct tui_disasm_window): Add
4189 do_scroll_vertical.
4190 (struct tui_data_window, struct tui_cmd_window): Add
4191 do_scroll_horizontal and do_scroll_vertical.
4192 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4193
5cf82909
TT
41942019-06-25 Tom Tromey <tom@tromey.com>
4195
4196 * tui/tui-data.h (struct tui_source_window_base): New struct.
4197 (struct tui_source_window): Derive from tui_source_window_base.
4198 (struct tui_disasm_window): New struct.
4199 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4200 from tui_source_window::clear_detail.
4201 (tui_source_window_base): Rename from tui_source_window.
4202 (~tui_source_window_base): Rename from ~tui_source_window.
4203 (tui_alloc_win_info): Create a tui_disasm_window.
4204
ee1d42d6
TT
42052019-06-25 Tom Tromey <tom@tromey.com>
4206
4207 * tui/tui-data.h (struct tui_source_window)
4208 (struct tui_data_window): Declare destructors.
4209 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4210 destructors.
4211 (tui_win_info): Simplify.
4212
b4eb2452
TT
42132019-06-25 Tom Tromey <tom@tromey.com>
4214
4215 * tui/tui-winsource.c (tui_display_main)
4216 (tui_update_source_windows_with_addr)
4217 (tui_update_all_breakpoint_info): Update.
4218 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4219 (new_height_ok, parse_scrolling_args): Update.
4220 * tui/tui-stack.c (tui_show_frame_info): Update.
4221 * tui/tui-data.h (struct tui_list): Remove.
4222 (tui_source_windows): Return a reference to a std::vector.
4223 * tui/tui-data.c (source_windows): Now a std::vector.
4224 (tui_source_windows): Change return type.
4225 (tui_clear_source_windows): Rewrite.
4226 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4227 (tui_free_all_source_wins_content): Rewrite.
4228
8761a91b
TT
42292019-06-25 Tom Tromey <tom@tromey.com>
4230
4231 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4232 (struct tui_data_window, struct tui_cmd_window): Declare
4233 clear_detail method.
4234 * tui/tui-data.c (tui_source_window::clear_detail)
4235 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4236 methods.
4237 (tui_clear_win_detail): Simplify.
4238
0ed69eda
TT
42392019-06-25 Tom Tromey <tom@tromey.com>
4240
4241 * tui/tui-layout.c (make_source_window, make_disasm_window)
4242 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4243 Return the new window.
4244 (show_source_disasm_command, show_data)
4245 (show_source_or_disasm_and_command): Update.
4246
82432e10
TT
42472019-06-25 Tom Tromey <tom@tromey.com>
4248
4249 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4250 parameter. Return the new window.
4251 (show_source_disasm_command): Update and remove NULL check.
4252 (show_source_or_disasm_and_command): Update.
4253
ec328aa5
TT
42542019-06-25 Tom Tromey <tom@tromey.com>
4255
4256 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4257
33b906ab
TT
42582019-06-25 Tom Tromey <tom@tromey.com>
4259
4260 * tui/tui-data.h (struct tui_win_info): Make constructor
4261 protected. Make destructor virtual. Add initializers.
4262 (tui_source_window, tui_data_window, tui_cmd_window): New
4263 classes.
4264 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4265 constructor. Add "type" parameter.
4266 (tui_source_window, tui_data_window, tui_cmd_window): New
4267 constructors.
4268 (tui_alloc_win_info): Instantiate the appropriate subclass.
4269
e7e11af4
TT
42702019-06-25 Tom Tromey <tom@tromey.com>
4271
4272 * tui/tui-win.c (tui_resize_all): Use delete.
4273 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4274 destructor.
4275 (tui_free_window): Don't declare.
4276 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4277 Update.
4278
6792b55e
TT
42792019-06-25 Tom Tromey <tom@tromey.com>
4280
4281 * tui/tui-data.h (struct tui_win_info): Add constructor.
4282 * tui/tui-data.c (tui_alloc_win_info): Use new.
4283 (tui_free_window): Use delete.
4284
f95675e1
TT
42852019-06-22 Tom Tromey <tom@tromey.com>
4286
4287 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4288 declare.
4289 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4290
5bff081c
TT
42912019-06-22 Tom Tromey <tom@tromey.com>
4292
4293 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4294 declare.
4295 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4296
47e3f474
TV
42972019-06-22 Tom de Vries <tdevries@suse.de>
4298
4299 * dwarf2read.c (create_addrmap_from_aranges)
4300 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4301 instead of '%zu'.
4302
fd5866f6
SM
43032019-06-21 Simon Marchi <simon.marchi@efficios.com>
4304
4305 * dwarf2read.h (dwarf2_section_info_def): Remove.
4306 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4307 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4308 std::vector<dwarf2_section_info>.
4309 (struct dwo_file) <~dwo_file>: Remove.
4310 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4311 types field.
4312 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4313 (dwarf2_read_debug_names): Likewise.
4314 (create_debug_types_hash_table): Change parameter type to
4315 array_view, adjust code accordingly.
4316 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4317 (partial_die_info::fixup): Likewise.
4318 (determine_prefix): Likewise.
4319 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4320
fb1eb2f9
SM
43212019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4322
4323 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4324 gdb_bfd_ref_ptr.
4325 <~dwo_file>: Remove call to gdb_bfd_unref.
4326 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4327 gdb_bfd_ref_ptr::get.
4328
51ac9db5
SM
43292019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4330
4331 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4332 type to htab_up.
4333 * dwarf2read.c (struct dwo_file): Initialize fields.
4334 <~dwo_file>: New.
4335 (free_dwo_file): Remove, move content to ~dwo_file.
4336 (struct dwo_file_deleter): Remove.
4337 (dwo_file_up>: Remove custom deleter.
4338 (free_dwo_files): Remove.
4339 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4340 dwo_files.
4341 (process_skeletonless_type_units): Call unique_ptr::get.
4342 (allocate_dwo_file_hash_table): Add deleter to created hash
4343 table. Change return type to htab_up.
4344 (lookup_dwo_file_slot): Don't memset dwo_file, call
4345 unique_ptr::get.
4346 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4347 (create_dwo_unit_in_dwp_v2): Likewise.
4348 (open_and_init_dwo_file): Likewise.
4349 (free_dwo_file_from_slot): Remove.
4350
dc4ccb6f
SM
43512019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4352
4353 * dwarf2read.h (struct dwarf2_section_info) <readin,
4354 is_virtual>: Change type to bool.
4355 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4356 true instead of 1.
4357
e6a1c5cb
TT
43582019-06-19 Tom Tromey <tom@tromey.com>
4359
4360 * tui/tui-data.h (tui_init_content_element): Don't declare.
4361
6f6ffbeb
TT
43622019-06-19 Tom Tromey <tom@tromey.com>
4363
4364 * tui/tui-data.h (tui_init_win_info): Don't declare.
4365
f23f598e
TV
43662019-06-19 Tom de Vries <tdevries@suse.de>
4367
4368 * dwarf2read.h (abstract_to_concrete): Change type to
4369 std::unordered_map<sect_offset, std::vector<sect_offset>,
4370 gdb::hash_enum<sect_offset>>.
4371
680e1bee
TT
43722019-06-19 Tom Tromey <tromey@adacore.com>
4373
4374 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4375 EVAL_AVOID_SIDE_EFFECTS specially.
4376
dcf37923
TT
43772019-06-19 Tom Tromey <tromey@adacore.com>
4378
4379 * source-cache.c (highlighter): New global.
4380 (source_cache::get_source_lines): Create a highlighter on demand.
4381
494986d5
AB
43822019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4383
4384 * defs.h (deprecated_interactive_hook): Delete declaration.
4385 * interps.c (clear_interpreter_hooks): Remove use of
4386 deprecated_interactive_hook.
4387 * top.c (deprecated_interactive_hook): Delete definition.
4388 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4389
3360b6e7
TV
43902019-06-18 Tom de Vries <tdevries@suse.de>
4391
4392 PR gdb/24515
4393 * dwarf2read.h (abstract_to_concrete): Change type from
4394 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4395 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4396 * dwarf2read.c (read_variable): Update.
4397 (dwarf2_fetch_die_loc_sect_off): Update.
4398
310b3441
TV
43992019-06-17 Tom de Vries <tdevries@suse.de>
4400
4401 PR gdb/24617
4402 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4403 accessing parent[parent_len - 1].
4404
ba9777be
PP
44052019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4406
4407 PR gdb/24364
4408 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4409 call dtrace_process_dof with NULL dof.
4410
2b9f6e89
TV
44112019-06-16 Tom de Vries <tdevries@suse.de>
4412
4413 PR gdb/24445
4414 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4415
431b3ead
TT
44162019-06-16 Tom Tromey <tom@tromey.com>
4417
4418 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4419 (make_all_visible): Use address of member.
4420
d04b44a1
TT
44212019-06-16 Tom Tromey <tom@tromey.com>
4422
4423 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4424 (tui_free_window, free_content, free_content_elements): Remove
4425 unnecessary cast.
4426 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4427 cast.
4428 * tui/tui-regs.c (tui_show_register_group)
4429 (tui_display_registers_from, tui_display_reg_element_at_line):
4430 Remove unnecessary cast.
4431
bf5142e7
AB
44322019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4433
4434 * linux-nat.c (normal_mask): Delete.
4435 (_initialize_linux_nat): Don't initialise normal_mask.
4436
c4973306
SM
44372019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4438
4439 PR gdb/24445
4440 * dwarf-index-write.h (write_psymtabs_to_index): Add
4441 dwz_basename parameter.
4442 * dwarf-index-write.c (write_gdbindex): Move file writing to
4443 write_gdbindex_1. Change return type void.
4444 (assert_file_size): Move up, remove filename parameter.
4445 (write_gdbindex_1): New function.
4446 (write_debug_names): Change return type to void, call
4447 assert_file_size.
4448 (struct index_wip_file): New struct.
4449 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4450 file logic to index_wip_file. Write index for dwz file if
4451 needed.
4452 (save_gdb_index_command): Pass basename of dwz file, if present.
4453 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4454 build-id of dwz file, if present.
4455 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4456 (dwarf2_get_dwz_file): Likewise.
4457 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4458 (dwarf2_get_dwz_file): Likewise.
4459
395f9c91
TT
44602019-06-16 Tom Tromey <tom@tromey.com>
4461
4462 * coffread.c (process_coff_symbol): Use xstrdup.
4463 * value.c (create_internalvar): Use xstrdup.
4464
cafb3438
TT
44652019-06-16 Tom Tromey <tom@tromey.com>
4466
4467 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4468 * breakpoint.c (stopin_command, stopat_command)
4469 (until_break_command, decode_location_default): Remove unnecessary
4470 cast.
4471 * utils.c (subset_compare): Remove unnecessary cast.
4472 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4473 cast.
4474 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4475 cast.
4476 * infcmd.c (path_command): Remove unnecessary cast.
4477 * coffread.c (decode_type): Remove unnecessary cast.
4478 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4479 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4480 * tui/tui-stack.c (tui_show_locator_content)
4481 (tui_show_frame_info): Remove unnecessary cast.
4482 * tui/tui-win.c (tui_scroll_forward_command)
4483 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4484 (parse_scrolling_args): Remove unnecessary cast.
4485 * tui/tui-data.c (init_win_info, tui_del_window)
4486 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4487 (free_content_elements): Remove unnecessary cast.
4488 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4489 unnecessary cast.
4490 * tui/tui-source.c (tui_set_source_content)
4491 (tui_vertical_source_scroll): Remove unnecessary cast.
4492 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4493 cast.
4494 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4495 * tui/tui-regs.c (tui_display_registers_from)
4496 (tui_display_register): Remove unnecessary cast.
4497 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4498 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4499 (make_visible): Remove unnecessary cast.
4500 * tui/tui-winsource.c (tui_erase_source_content)
4501 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4502 unnecessary cast.
4503 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4504 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4505 * stabsread.c (read_type, read_array_type, read_range_type):
4506 Remove unnecessary cast.
4507 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4508 (parse_symbol, parse_type, upgrade_type, parse_external)
4509 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4510 unnecessary cast.
4511 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4512
730ead81
TT
45132019-06-16 Tom Tromey <tom@tromey.com>
4514
4515 * tui/tui-data.c (tui_alloc_generic_win_info)
4516 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4517 checks.
4518
584a927c
AB
45192019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4520 Andrew Burgess <andrew.burgess@embecosm.com>
4521
4522 * f-typeprint.c (f_print_type): Don't return early for not
4523 associated or not allocated types.
4524 (f_type_print_varspec_suffix): Add print_rank parameter and print
4525 ranks of array types in case they dangling.
4526 (f_type_print_base): Add print_rank parameter.
4527
30056ea0
AB
45282019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4529
4530 * NEWS: Mention new MI commands.
4531 * break-catch-throw.c (enum exception_event_kind): Move to
4532 breakpoint.h.
4533 (print_mention_exception_catchpoint): Output text as a single
4534 message.
4535 (catch_exception_command_1): Rename to...
4536 (catch_exception_event): ...this, make non-static, update header
4537 command, and change some parameter types.
4538 (catch_catch_command): Update for changes to
4539 catch_exception_command_1.
4540 (catch_throw_command): Likewise.
4541 (catch_rethrow_command): Likewise.
4542 * breakpoint.c (enum exception_event_kind): Delete.
4543 * breakpoint.h (enum exception_event_kind): Moved here from
4544 break-catch-throw.c.
4545 (catch_exception_event): Declare.
4546 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4547 (mi_cmd_catch_throw): New function.
4548 (mi_cmd_catch_rethrow): New function.
4549 (mi_cmd_catch_catch): New function.
4550 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4551 'catch-catch' entries.
4552 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4553 (mi_cmd_catch_rethrow): Declare.
4554 (mi_cmd_catch_catch): Declare.
4555
ec8e2b6d
AB
45562019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4557
4558 * annotate.c (annotate_source_line): Change return type to void,
4559 update implementation to match.
4560 * annotate.h (annotate_source_line): Change return type to void,
4561 update header comment.
4562 * stack.c (print_frame_info): Don't change what frame information
4563 is printed based on whether annotations are on or not.
4564
0d3abd8c
AB
45652019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4566
4567 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4568 (annotate_source): Make static.
4569 (annotate_source_line): Moved from source.c and renamed from
4570 identify_source_line. Update the return type.
4571 * annotate.h (annotate_source): Delete declaration.
4572 (annotate_source_line): Declaration moved from source.h, and
4573 renamed from identify_source_line. Return type updated.
4574 * source.c (identify_source_line): Moved to annotate.c and renamed
4575 to annotate_source_line.
4576 (info_line_command): Remove check of annotation_level.
4577 * source.h (identify_source_line): Move declaration to annotate.h
4578 and rename to annotate_source_line.
4579 * stack.c: Add 'annotate.h' include.
4580 (print_frame_info): Remove check of annotation_level before
4581 calling annotate_source_line.
4582
00df30ae
AB
45832019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4584
4585 * source-cache.c (source_cache::get_plain_source_lines): Use
4586 open_source_file_with_line_charpos instead of just
4587 open_source_file, remove call to find_source_lines.
4588 (source_cache::get_source_lines): Likewise.
4589 * source.c (find_source_lines): Make static.
4590 (get_filename_and_charpos): Renamed into...
4591 (open_source_file_with_line_charpos): ..this along with changes to
4592 return a scoped_fd, and some other minor clean ups.
4593 (identify_source_line): Use open_source_file_with_line_charpos.
4594 (search_command_helper): Use open_source_file_with_line_charpos
4595 instead of just open_source_file, remove call to
4596 find_source_lines.
4597 * source.h (open_source_file_with_line_charpos): Declare new
4598 function.
4599 (find_source_lines): Delete declaration.
4600
afda45a2
AB
46012019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4602
4603 * source.c (get_filename_and_charpos): Remove fullname
4604 parameter.
4605 (identify_source_line): Update call to get_filename_and_charpos.
4606
0735b091
TT
46072019-06-14 Tom Tromey <tromey@adacore.com>
4608
4609 PR gdb/24502:
4610 * ui-style.h (skip_ansi_escape): Update comment.
4611 * ui-file.h (class no_terminal_escape_file): New class.
4612 * ui-file.c (no_terminal_escape_file::write)
4613 (no_terminal_escape_file::puts): New methods.
4614 * cli/cli-logging.c (handle_redirections): Use
4615 no_terminal_escape_file.
4616
52ce35e2
TT
46172019-06-14 Tom Tromey <tromey@adacore.com>
4618
4619 * NEWS: Move convenience variable news above Python news.
4620
73cc7272
TT
46212019-06-14 Tom Tromey <tom@tromey.com>
4622
4623 * gnulib: Move directory to top-level.
4624 * configure.ac: Don't configure gnulib.
4625 * configure: Rebuild.
4626 * common/common-defs.h: Use new path to gnulib.
4627 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4628 (GNULIB_H): Remove.
4629 (INCGNU): Look in new gnulib location.
4630 (HFILES_NO_SRCDIR): Remove gnulib files.
4631 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4632 (generated_files): Remove GNULIB_H.
4633 ($(LIBGNU), all-lib): Remove targets.
4634 (distclean): Don't mention GNULIB_BUILDDIR.
4635 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4636
f5686554
TT
46372019-06-14 Tom Tromey <tromey@adacore.com>
4638
4639 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4640 Warn if symbol file does not provide any symbols.
4641
a0c1ffed
TT
46422019-06-14 Tom Tromey <tromey@adacore.com>
4643
4644 * source.c (find_and_open_source): Respect basenames_may_differ.
4645
7c39e397
AB
46462019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4647
4648 * annotate.c (annotate_breakpoints_invalid): Make use of
4649 scoped_restore_terminal_state.
4650 (annotate_frames_invalid): Likewise.
4651
f411722c
TT
46522019-06-14 Tom Tromey <tromey@adacore.com>
4653
4654 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4655 allow assignment to an internalvar.
4656
4268ec18
TT
46572019-06-14 Tom Tromey <tromey@adacore.com>
4658
4659 * ada-lex.l: Allow "_" in attribute names.
4660
abdb711e
TT
46612019-06-14 Tom Tromey <tromey@adacore.com>
4662
4663 PR gdb/24653:
4664 * regcache.c (registers_changed): Don't call alloca.
4665 * top.c (execute_command): Don't call alloca.
4666
4c048731
PA
46672019-06-13 Pedro Alves <palves@redhat.com>
4668
4669 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4670 'expression'. When parsing an expression, error out if there's
4671 junk after "unlimited".
4672 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4673 (do_set_command): Adjust calls to is_unlimited_literal.
4674
66eb1ed3
PA
46752019-06-13 Pedro Alves <palves@redhat.com>
4676
4677 * compile/compile.c (make_compile_options_def_group): Add braces
4678 around array_view initializer.
4679 * thread.c (make_thread_apply_all_options_def_group)
4680 (make_thread_apply_all_options_def_group): Likewise.
4681
3345721a
PA
46822019-06-13 Pedro Alves <palves@redhat.com>
4683
4684 * NEWS (New commands): Mention "maint test-options
4685 require-delimiter", "maint test-options unknown-is-error", "maint
4686 test-options unknown-is-operand" and "maint show
4687 test-options-completion-result".
4688 (New command options, command completion): New section.
4689 (Completion improvements): New section.
4690 Mention that you can abbreviate "unlimited".
4691
6206060d
PA
46922019-06-13 Pedro Alves <palves@redhat.com>
4693
4694 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4695 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4696 * unittests/cli-utils-selftests.c (test_parse_flags)
4697 (test_parse_flags_qcs): Delete.
4698 (test_cli_utils): Don't call deleted functions.
4699
6665660a
PA
47002019-06-13 Pedro Alves <palves@redhat.com>
4701
4702 * thread.c: Include "cli/cli-option.h".
4703 (tp_array_compar_ascending): Global.
4704 (tp_array_compar): Delete function.
4705 (tp_array_compar_ascending, tp_array_compar_descending): New
4706 functions.
4707 (ascending_option_def, qcs_flag_option_def)
4708 (thr_qcs_flags_option_defs)
4709 (make_thread_apply_all_options_def_group)
4710 (make_thread_apply_options_def_group): New.
4711 (thread_apply_all_command): Use gdb::option::process_options.
4712 (thread_apply_command_completer)
4713 (thread_apply_all_command_completer): New.
4714 (thread_apply_command): Use gdb::option::process_options.
4715 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4716 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4717 to generate help text of "thread apply". Adjust "taas"'s help.
4718 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4719 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4720
f7e13587
PA
47212019-06-13 Pedro Alves <palves@redhat.com>
4722
4723 * thread.c (thread_apply_command): Check for invalid TID with
4724 isdigit instead of !isalpha.
4725
5d707134
PA
47262019-06-13 Pedro Alves <palves@redhat.com>
4727
4728 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4729 (validate_flags_qcs): New.
4730 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4731 (validate_flags_qcs): Declare.
4732 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4733 (make_frame_apply_options_def_group): New.
4734 (frame_apply_command_count): Process options with
4735 gdb::option::process_options.
4736 (frame_apply_completer): New.
4737 (frame_apply_level_completer, frame_apply_all_completer)
4738 (frame_apply_completer): New.
4739 (_initialize_stack): Update help of "frame apply", "frame apply
4740 level", "frame apply all" and "faas" to mention supported options
4741 and install command completers.
4742 * stack.h (frame_apply_all_completer): Declare.
4743 * thread.c: Include "stack.h".
4744 (tfaas_command): Add "--".
4745 (_initialize_thread): Update help "tfaas" to mention supported
4746 options and install command completer.
4747
272d4594
PA
47482019-06-13 Pedro Alves <palves@redhat.com>
4749
4750 * completer.c (complete_nested_command_line): New.
4751 (gdb_completion_word_break_characters_throw): Add assertion.
4752 * completer.h (complete_nested_command_line): Declare.
4753
90a1ef87
PA
47542019-06-13 Pedro Alves <palves@redhat.com>
4755
4756 * stack.c (parse_backtrace_qualifiers): New.
4757 (backtrace_command): Use it.
4758 (backtrace_command_completer): Complete on qualifiers.
4759
d4c16835
PA
47602019-06-13 Pedro Alves <palves@redhat.com>
4761
4762 * frame.c: Include "cli/cli-option.h.
4763 (user_set_backtrace_options): New.
4764 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4765 Delete.
4766 (get_prev_frame): Adjust.
4767 (boolean_option_def, uinteger_option_def)
4768 (set_backtrace_option_defs): New.
4769 (_initialize_frame): Adjust and use
4770 gdb::option::add_setshow_cmds_for_options to install "set
4771 backtrace past-main" and "set backtrace past-entry".
4772 * frame.h: Include "cli/cli-option.h".
4773 (struct frame_print_options): Forward declare.
4774 (print_frame_arguments_all, print_frame_arguments_scalars)
4775 (print_frame_arguments_none): Declare.
4776 (print_entry_values): Delete declaration.
4777 (struct frame_print_options, user_frame_print_options): New.
4778 (struct set_backtrace_options): New.
4779 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4780 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4781 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4782 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4783 (list_args_or_locals): Add frame_print_options parameter.
4784 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4785 * python/py-framefilter.c (enumerate_args): Pass down
4786 USER_FRAME_PRINT_OPTIONS.
4787 * stack.c: Include "cli/cli-option.h".
4788 (print_frame_arguments_all, print_frame_arguments_scalars)
4789 (print_frame_arguments_none): Declare.
4790 (print_raw_frame_arguments, print_entry_values): Delete.
4791 (user_frame_print_options): New.
4792 (boolean_option_def, enum_option_def, frame_print_option_defs):
4793 New.
4794 (struct backtrace_cmd_options): New.
4795 (bt_flag_option_def): New.
4796 (backtrace_command_option_defs): New.
4797 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4798 (print_frame_arg, read_frame_arg, print_frame_args)
4799 (print_frame_info, print_frame): Add frame_print_options parameter
4800 and use it.
4801 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4802 (backtrace_command_1): Add frame_print_options and
4803 backtrace_cmd_options parameters and use them.
4804 (make_backtrace_options_def_group): New.
4805 (backtrace_command): Process command options with
4806 gdb::option::process_options.
4807 (backtrace_command_completer): New.
4808 (_initialize_stack): Extend "backtrace"'s help to mention
4809 supported options. Install completer for "backtrace".
4810 Install some settings commands with add_setshow_cmds_for_options.
4811
2daf894e
PA
48122019-06-13 Pedro Alves <palves@redhat.com>
4813
4814 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4815 and that "set/show print raw frame-arguments" are now deprecated.
4816
4817 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4818 command.
4819 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4820 * stack.c (_initialize_stack): Install "set/show print
4821 raw-frame-arguments", and deprecate "set/show print raw
4822 frame-arguments".
4823 * valprint.c (_initialize_valprint): Deprecate "set/show print
4824 raw".
4825
e6ed716c
PA
48262019-06-13 Pedro Alves <palves@redhat.com>
4827
4828 * compile/compile.c (struct compile_options): New.
4829 (compile_flag_option_def, compile_command_option_defs)
4830 (make_compile_options_def_group): New.
4831 (compile_file_command): Handle options with
4832 gdb::option::process_options.
4833 (compile_file_command_completer): New function.
4834 (compile_code_command): Handle options with
4835 gdb::option::process_options.
4836 (compile_code_command_completer): New function.
4837 (_initialize_compiler): Install completers for "compile code" and
4838 "compile file". Mention available options in "compile code" and
4839 "compile code"'s help.
4840 * completer.c (advance_to_completion_word): New, factored out from
4841 ...
4842 (advance_to_expression_complete_word_point): ... this.
4843 (advance_to_filename_complete_word_point): New.
4844 * completer.h (advance_to_filename_complete_word_point): New
4845 declaration.
4846
7d8062de
PA
48472019-06-13 Pedro Alves <palves@redhat.com>
4848
4849 * compile/compile.c: Include "cli/cli-option.h".
4850 (compile_print_value): Scope data pointer is now a
4851 value_print_options pointer; adjust.
4852 (compile_print_command): Process options. Scope data pointer is
4853 now a value_print_options pointer; adjust.
4854 (_initialize_compile): Update "compile print"'s help to include
4855 supported options. Install a completer for "compile print".
4856 * cp-valprint.c (show_vtblprint, show_objectprint)
4857 (show_static_field_print): Delete.
4858 (_initialize_cp_valprint): Don't install "set print
4859 static-members", "set print vtbl", "set print object" here.
4860 * printcmd.c: Include "cli/cli-option.h" and
4861 "common/gdb_optional.h".
4862 (print_command_parse_format): Rework to fill in a
4863 value_print_options instead of a format_data.
4864 (print_value): Change parameter type from format_data pointer to
4865 value_print_options reference. Adjust.
4866 (print_command_1): Process options. Adjust to pass down a
4867 value_print_options.
4868 (print_command_completer): New.
4869 (_initialize_printcmd): Install print_command_completer as
4870 handle_brkchars completer for the "print" command. Update
4871 "print"'s help to include supported options.
4872 * valprint.c: Include "cli/cli-option.h".
4873 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4874 here from cp-valprint.c.
4875 (boolean_option_def, uinteger_option_def)
4876 (value_print_option_defs, make_value_print_options_def_group):
4877 New. Use gdb::option::add_setshow_cmds_for_options to install
4878 "set print elements", "set print null-stop", "set print repeats",
4879 "set print pretty", "set print union", "set print array", "set
4880 print address", "set print symbol", "set print array-indexes".
4881 * valprint.h: Include <string> and "cli/cli-option.h".
4882 (make_value_print_options_def_group): Declare.
4883 (print_value): Change parameter type from format_data pointer to
4884 value_print_options reference.
4885 (print_command_completer): Declare.
4886
9d0faba9
PA
48872019-06-13 Pedro Alves <palves@redhat.com>
4888
4889 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4890 (COMMON_SFILES): Add maint-test-settings.c.
4891 * cli/cli-decode.c (boolean_enums): New global, factored out from
4892 ...
4893 (add_setshow_boolean_cmd): ... here.
4894 * cli/cli-decode.h (boolean_enums): Declare.
4895 * cli/cli-option.c: New file.
4896 * cli/cli-option.h: New file.
4897 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4898 factored out from ...
4899 (parse_cli_boolean_value(const char *)): ... this.
4900 (is_unlimited_literal): Change parameter type to pointer to
4901 pointer. Adjust and advance ARG pointer.
4902 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4903 (parse_cli_var_enum): New, factored out from ...
4904 (do_set_command): ... this. Adjust.
4905 * cli/cli-setshow.h (parse_cli_boolean_value)
4906 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4907 (parse_cli_var_enum): Declare.
4908 * cli/cli-utils.c: Include "cli/cli-option.h".
4909 (get_ulongest): New.
4910 * cli/cli-utils.h (get_ulongest): Declare.
4911 (check_for_argument): New overloads.
4912 * maint-test-options.c: New file.
4913
2c722807
PA
49142019-06-13 Pedro Alves <palves@redhat.com>
4915
4916 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4917 parse a range if "-" is at the end of the string.
4918
dee7b4c8
PA
49192019-06-13 Pedro Alves <palves@redhat.com>
4920
4921 * cli/cli-setshow.c (parse_auto_binary_operation)
4922 (parse_cli_boolean_value): Don't allow "o".
4923
dca0f6c0
PA
49242019-06-13 Pedro Alves <palves@redhat.com>
4925
4926 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4927 * NEWS: Mention maint test-settings KIND.
4928 * maint-test-settings.c: New file.
4929
597bf39d
PA
49302019-06-13 Pedro Alves <palves@redhat.com>
4931
4932 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4933 completer.
4934 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4935 "set" completers.
4936
48c410fb
PA
49372019-06-13 Pedro Alves <palves@redhat.com>
4938
4939 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4940 after item.
4941
93bcb043
PA
49422019-06-13 Pedro Alves <palves@redhat.com>
4943
4944 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4945
cbba3ecd
PA
49462019-06-13 Pedro Alves <palves@redhat.com>
4947
4948 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4949 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4950 call.
4951 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4952 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4953 calls.
4954 (check_for_argument): Skip spaces after argument.
4955
b9a3f842
PA
49562019-06-13 Pedro Alves <palves@redhat.com>
4957
4958 * thread.c (thread_apply_command): Adjust TID parsing.
4959 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4960 detected before end of string.
4961 (tid_is_in_list): Error out if LIST is invalid.
4962
3844e605
PA
49632019-06-13 Pedro Alves <palves@redhat.com>
4964
4965 * completer.c (complete_line_internal_1): Rewind completion word
4966 point.
4967 (completion_tracker::advance_custom_word_point_by): Change
4968 parameter type to int.
4969 * completer.h (completion_tracker::advance_custom_word_point_by):
4970 Likewise.
4971
00b56dbe
PA
49722019-06-13 Pedro Alves <palves@redhat.com>
4973
4974 * completer.c (advance_to_completion_word): Handle delimiters.
4975
d106773e
PA
49762019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4977
4978 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4979
08f10e02
TT
49802019-06-11 Tom Tromey <tom@tromey.com>
4981
4982 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4983 (xmalloc_failed): Move to alloc.c.
4984 * alloc.c: New file.
4985 * Makefile.in (COMMON_SFILES): Add alloc.c.
4986
1c7fe951
TT
49872019-06-11 Tom Tromey <tom@tromey.com>
4988
4989 * nat/linux-waitpid.c: Don't include server.h.
4990 (linux_debug): Remove.
4991 (my_waitpid): Update.
4992
89549d7f
TT
49932019-06-11 Tom Tromey <tromey@adacore.com>
4994
4995 * infcall.c (_initialize_infcall): Remove trailing newline from
4996 help.
4997 * user-regs.c (_initialize_user_regs): Remove trailing newline
4998 from help.
4999 * typeprint.c (_initialize_typeprint): Remove trailing newline
5000 from help.
5001 * reverse.c (_initialize_reverse): Remove trailing newlines from
5002 help.
5003 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5004 from help.
5005 * language.c (add_set_language_command): Remove trailing newline
5006 from help.
5007 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5008 help.
5009 * disasm.c (_initialize_disasm): Remove trailing newline from
5010 help.
5011 * top.c (init_main): Remove trailing newline from help.
5012 * interps.c (_initialize_interpreter): Remove trailing newline
5013 from help.
5014 * btrace.c (_initialize_btrace): Remove trailing newlines from
5015 help.
5016 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5017 from help.
5018 * python/python.c (_initialize_python): Remove trailing newline
5019 from help.
5020 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5021 help.
5022 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5023 from help. Reformat some text.
5024 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5025 from help.
5026 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5027 newline from help.
5028
86108c13
TT
50292019-06-11 Tom Tromey <tromey@adacore.com>
5030
5031 * darwin-nat.c (darwin_decode_exception_message)
5032 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5033
a7067863
AB
50342019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5035
5036 * valops.c (value_slice): Check for not allocated or not
5037 associated values.
5038
9ab08412
TV
50392019-06-10 Tom de Vries <tdevries@suse.de>
5040
5041 PR gdb/24618
5042 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5043 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5044 invalid.
5045
f19e22e9
TV
50462019-06-10 Tom de Vries <tdevries@suse.de>
5047
5048 PR gdb/24611
5049 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5050 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5051
e99f9db0
TV
50522019-06-10 Tom de Vries <tdevries@suse.de>
5053
5054 PR symtab/24545
5055 * symtab.c (struct demangled_name_entry): Add language field.
5056 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5057 static minimal symbol". Set and use language field.
5058
9bf7038b
TT
50592019-06-10 Tom Tromey <tromey@adacore.com>
5060
5061 * ada-lang.c (_initialize_ada_language): Update help text.
5062
422186a9
TT
50632019-06-10 Tom Tromey <tromey@adacore.com>
5064
5065 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5066 with a newline.
5067 * guile/guile.c (handle_boot_error): Don't end warning with a
5068 newline.
5069 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5070 warning with a newline.
5071 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5072 newline.
5073 (s12z_frame_cache): Likewise.
5074 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5075 a newline.
5076 * solib-svr4.c (disable_probes_interface): Don't end warning with
5077 a newline.
5078 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5079 newline.
5080 * python/python.c (do_finish_initialization): Don't end warning
5081 with a newline.
5082
25ce02ee
TT
50832019-06-10 Tom Tromey <tom@tromey.com>
5084
5085 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5086 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5087 gdbpy_enter.
5088
caa429d8
TT
50892019-06-10 Tom Tromey <tromey@adacore.com>
5090
5091 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5092 data.
5093 (elf_new_init): Don't call stabsread_new_init.
5094 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5095 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5096 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5097
81873cc8
TV
50982019-06-10 Tom de Vries <tdevries@suse.de>
5099
5100 PR symtab/16264
5101 PR symtab/24517
5102 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5103
4fa0265e
РИ
51042019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5105
5106 * source.c (find_and_open_source): Also rewrite relative file
5107 names.
5108
1a3da2cd
AB
51092019-04-26 Amos Bird <amosbird@gmail.com>
5110
5111 * annotate.c (annotate_thread_exited): Add "thread-exited"
5112 annotation.
5113
3847a7bf
TT
51142019-06-06 Tom Tromey <tromey@adacore.com>
5115
5116 * maint.h (class scoped_command_stats): Use
5117 DISABLE_COPY_AND_ASSIGN.
5118 <print_time>: New method.
5119 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5120 print_time.
5121 (scoped_command_stats::print_time): New method.
5122
312617a3
AB
51232019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5124
5125 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5126 instructions of lengths 6 or 8 bytes.
5127
b02f78f9
PA
51282019-06-04 Pedro Alves <palves@redhat.com>
5129
5130 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5131
5132 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5133 * breakpoint.c (condition_completer): Likewise.
5134 * cli/cli-dump.c (scan_expression): Likewise.
5135 * common/filestuff.c (mkdir_recursive): Likewise.
5136 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5137 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5138 (gdb_abspath): Likewise.
5139 * compile/compile-cplus-types.c
5140 (compile_cplus_instance::decl_name): Likewise.
5141 * completer.c (complete_explicit_location):
5142 (signal_completer, reg_or_group_completer_1): Likewise.
5143 * cp-support.c (cp_remove_params_if_any): Likewise.
5144 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5145 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5146 * infcmd.c (strip_bg_char): Likewise.
5147 * linespec.c (copy_token_string): Likewise.
5148 * mi/mi-main.c (output_cores): Likewise.
5149 * psymtab.c (psymtab_search_name):
5150 * symfile.c (test_set_ext_lang_command): Likewise.
5151 * target.c (target_fileio_read_stralloc): Likewise.
5152 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5153 * value.c (complete_internalvar): Likewise.
5154
e1f2e1a2
CB
51552019-06-04 Christian Biesinger <cbiesinger@google.com>
5156
5157 Add objfile property to gdb.Type.
d3238f7d
PA
5158 * NEWS: Mention Python API addition.
5159 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5160
e664d728
PW
51612019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5162
5163 * NEWS: Mention the new set|show style [title|highlight].
5164 Mention changes to "show style", "help" and "apropos".
5165
66d8c862
PW
51662019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5167
5168 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5169 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5170 instead of print_help_for_command.
5171 (print_doc_of_command): New function.
5172 (help_list): Add 'apropos -v word' suggestion.
5173 (print_help_for_command): Style the command name using title style.
5174 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5175 (_initialize_cli_cmds): Describe -v in apropos_command help.
5176
9303eb2f
PW
51772019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5178
5179 * cli/cli-style.h (cli_style_option): Add name in constructor,
5180 add m_name class member, add constructor with intensity,
5181 add name class function.
5182 (cli_style_option::add_setshow_commands): Remove name argument.
5183 (highlight_style, title_style): New styles.
5184 * cli/cli-style.c (do_show): New function that shows a style
5185 characteristic styling the style name with itself.
5186 (set_style_name): New function.
5187 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5188 Update all callers according to the changes in cli/cli-style.h.
5189 * utils.h (fputs_highlighted): New function.
5190 * utils.c (fputs_highlighted): Likewise.
5191
e2c52041
PW
51922019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5193
5194 * NEWS: Mention new pipe command and new convenience variables.
5195
947d3946
PW
51962019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5197
5198 * cli/cli-cmds.c (pipe_command): New function.
5199 (_initialize_cli_cmds): Call add_com for pipe_command.
5200 Define | as an alias for pipe.
5201 (exit_status_set_internal_vars): New function.
5202 (shell_escape): Call exit_status_set_internal_vars.
5203 cli/cli-decode.c (find_command_name_length): Recognize | as
5204 a single character command.
5205
b8fd0918
PW
52062019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5207
5208 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5209 top.c (execute_command_to_ui_file): New function, mostly a copy
5210 of execute_command_to_string.
5211 (execute_command_to_string): Implement by calling
5212 execute_command_to_ui_file.
5213
68bb5386
PW
52142019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5215
5216 * top.h (saved_command_line): Remove declaration.
5217 * top.c (previous_saved_command_line, previous_repeat_arguments):
5218 New variables.
5219 (saved_command_line): Make static, define together with other
5220 'repeat variables'.
5221 (dont_repeat): Clear repeat_arguments.
5222 (repeat_previous, get_saved_command_line, save_command_line):
5223 New functions.
5224 (gdb_init): Initialize saved_command_line
5225 and previous_saved_command_line.
5226 * main.c (captured_main_1): Remove saved_command_line initialization.
5227 * event-top.c (handle_line_of_input): Update to use
5228 the new 'repeat' related functions instead of direct access to
5229 saved_command_line.
5230 * command.h (repeat_previous, get_saved_command_line,
5231 save_command_line): New declarations.
5232 (dont_repeat): Add comment.
5233
bfcdb852
TT
52342019-05-30 Tom Tromey <tromey@adacore.com>
5235
5236 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5237 Fix comment.
5238 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5239
0ef209f2
JV
52402019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5241
5242 PR cli/24587
5243 * completer.c (complete): Initialize variable word.
5244
955b06fa
SDJ
52452019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5246
5247 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5248 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5249 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5250 'body' is NULL to the outter 'if', protecting the '!is_define'
5251 situation as well.
5252
fa9c3fa0
TT
52532019-05-29 Tom Tromey <tromey@adacore.com>
5254
5255 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5256 (dwarf_unknown): New function.
5257 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5258 (dwarf_type_encoding_name): Use dwarf_unknown.
5259
4330d61d
TT
52602019-05-29 Tom Tromey <tromey@adacore.com>
5261
5262 PR c++/20020:
5263 * cp-valprint.c (cp_print_value_fields): Call
5264 cp_print_static_field inside "try".
5265
33a6bc35
TT
52662019-05-29 Tom Tromey <tromey@adacore.com>
5267
5268 * inflow.c (struct terminal_info): Add default operator=.
5269 * configure: Rebuild.
5270 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5271 -Wdeprecated-copy-dtor, -Wredundant-move.
5272
000439d5
TT
52732019-05-29 Tom Tromey <tromey@adacore.com>
5274
5275 * NEWS: Add entry.
5276 * infcmd.c (print_return_value_1): Handle finish_print
5277 option.
5278 (show_print_finish): New function.
5279 (_initialize_infcmd): Add "set/show print finish" commands.
5280 * valprint.c (user_print_options): Initialize new member.
5281 * valprint.h (struct value_print_options) <finish_print>: New
5282 member.
5283
c0e70c62
TT
52842019-05-28 Tom Tromey <tromey@adacore.com>
5285
5286 * ada-lang.c (ada_remove_Xbn_suffix)
5287 (find_old_style_renaming_symbol)
5288 (parse_old_style_renaming): Remove.
5289 (ada_find_renaming_symbol): Don't call
5290 find_old_style_renaming_symbol.
5291 (ada_is_renaming_symbol): Rename from
5292 ada_find_renaming_symbol. Remove "block" parameter. Return
5293 bool. Now static.
5294 (ada_read_var_value): Update and simplify.
5295 * ada-exp.y (write_var_or_type): Remove old code.
5296
766f8836
AH
52972019-05-28 Alan Hayward <alan.hayward@arm.com>
5298
5299 * event-top.c: Remove include comment.
5300 * inflow.c (class scoped_ignore_sigttou): Move from here...
5301 * inflow.h (class scoped_ignore_sigttou): ...to here.
5302 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5303 * top.c: Remove include comment.
5304
eb41253a
TT
53052019-05-27 Tom Tromey <tom@tromey.com>
5306
5307 * NEWS: Fix typo.
5308
4ca51187
TT
53092019-05-22 Tom Tromey <tromey@adacore.com>
5310
5311 * target.c (target_follow_exec): Constify parameter.
5312 * target-delegates.c: Rebuild.
5313 * remote.c (remote_target::follow_exec): Constify parameter.
5314 * infrun.c (follow_exec): Constify parameter.
5315 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5316 (target_follow_exec): Likewise.
5317
8fca4da0
AH
53182019-05-22 Alan Hayward <alan.hayward@arm.com>
5319
5320 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5321 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5322
b7060614
AH
53232019-05-22 Alan Hayward <alan.hayward@arm.com>
5324
5325 * NEWS: Add debugredirect and testsuite sections.
5326
0a5954bd
SC
53272019-05-22 Simon Cook <simon.cook@embecosm.com>
5328
5329 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5330 target descriptions using exclusively floating point register name
5331 aliases.
5332
dc42e902
AB
53332019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5334
5335 PR gdb/18644:
5336 * f-lang.c (build_fortran_types): Handle the case where
5337 gdbarch_floatformat_for_type returns a nullptr.
5338
fb7806c7
TV
53392019-05-21 Tom de Vries <tdevries@suse.de>
5340
5341 PR cli/24587
5342 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5343
34d11c68
AB
53442019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5345
5346 PR gdb/18644:
5347 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5348 16-byte floats.
5349 * i386-tdep.c (i386_floatformat_for_type): Use
5350 floatformats_ia64_quad for the 16-byte floating point component
5351 within a fortran 32-byte complex number.
5352
122cf0f2
AB
53532019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5354
5355 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5356 delete default constructor.
5357 (find_partial_die): Update to return const struct.
5358 (partial_die_parent_scope): Move variable declaration into scope
5359 of its use and change its type to auto.
5360 (guess_partial_die_structure_name): Likewise.
5361 (partial_die_info::fixup): Likewise.
5362
33d0e35a
TT
53632019-05-17 Tom Tromey <tromey@adacore.com>
5364
5365 * source.c (find_and_open_source): Remove cast.
5366
a45575b0
TT
53672019-05-17 Tom Tromey <tromey@adacore.com>
5368
5369 * annotate.c (annotate_source): Make "filename" const.
5370 * annotate.h (annotate_source): Use const.
5371
81f47ac2
AH
53722019-05-17 Alan Hayward <alan.hayward@arm.com>
5373
5374 * disasm.c (set_disassembler_options): Send errors to stderr.
5375
ca1285d1
AH
53762019-05-17 Alan Hayward <alan.hayward@arm.com>
5377
5378 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5379 (cli_interp_base::set_logging): Check debug_redirect.
5380 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5381 * cli/cli-logging.c (debug_redirect): Add static variable.
5382 (pop_output_files): Add default param.
5383 (handle_redirections): Print debug setting.
5384 (show_logging_command): Likewise.
5385 (_initialize_cli_logging): Add debugredirect command.
5386 * interps.c (current_interp_set_logging): Add debug_redirect
5387 parameter.
5388 * interps.h (set_logging): Add debug_redirect parameter.
5389 (current_interp_set_logging): Likewise.
5390 * mi/mi-common.h: Likewise.
5391 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5392
53932019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
5394 Tom Tromey <tromey@adacore.com>
5395
5396 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5397 directly.
5398 * cli/cli-interp.h (make_logging_output): Remove declaration.
5399 * cli/cli-logging.c (make_logging_output): Remove function.
5400 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5401 directly.
5402 * ui-file.c (tee_file::tee_file): Remove bools.
5403 (tee_file::~tee_file): Remove deletes.
5404 * ui-file.h (tee_file): Remove bools.
5405
26648588
JV
54062019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5407
5408 * mi/mi-cmds.h (mi_cmd_complete): New function.
5409 * mi/mi-main.c (mi_cmd_complete): Likewise.
5410 * mi/mi-cmds.c: Define new MI command -complete.
5411 * NEWS: Mention new -complete command.
5412
6e035501
JV
54132019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5414
5415 * completer.h (complete): New function.
5416 * completer.c (complete): Likewise.
5417 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5418 function defined in completer.h.
5419
7d0e2ece
JV
54202019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5421
e79be6e5 5422 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5423
fb816e8b
TV
54242019-05-17 Tom de Vries <tdevries@suse.de>
5425
5426 PR gdb/24094
5427 * dwarf2read.c (struct cu_partial_die_info): New struct.
5428 (find_partial_die): Return cu_partial_die_info.
5429 (partial_die_parent_scope, guess_partial_die_structure_name)
5430 (partial_die_info::fixup): Handle new return type of find_partial_die.
5431
677052f2
SDJ
54322019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5433
5434 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5435 "std::string", simplifying the algorithm.
5436
f3da9116
SDJ
54372019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5438
5439 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5440 (stap_static_probe_ops::get_probes): Likewise.
5441
f1bb75ab
SDJ
54422019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5443
5444 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5445 '-')" and "else if".
5446 (stap_parse_single_operand): Join checks for
5447 "gdbarch_stap_parse_special_token_p" and
5448 "gdbarch_stap_parse_special_token" in the same "if" statement.
5449 Invert check when verifying for operation on register
5450 displacement.
5451
3ca58cde
SDJ
54522019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5453
5454 * stap-probe.c (stap_get_opcode): Update comment.
5455 (stap_get_expected_argument_type): Likewise.
5456 (handle_stap_probe): Likewise.
5457
af2d9bee
SDJ
54582019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5459
5460 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5461 return type to 'bool'. Adjust comment. Use 'bool' when
5462 appropriate.
5463 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5464 * stap-probe.c (stap_parse_argument_1): Likewise.
5465 (stap_is_operator): Likewise.
5466 (stap_is_generic_prefix): Likewise.
5467 (stap_is_register_prefix): Likewise.
5468 (stap_is_register_indirection_prefix): Likewise.
5469 (stap_is_integer_prefix): Likewise.
5470 (stap_generic_check_suffix): Likewise.
5471 (stap_check_integer_suffix): Likewise.
5472 (stap_check_register_suffix): Likewise.
5473 (stap_check_register_indirection_suffix): Likewise.
5474 (stap_parse_register_operand): Likewise.
5475 (stap_parse_single_operand): Likewise.
5476 (stap_parse_argument_1): Likewise.
5477 (stap_probe::get_argument_count): Likewise.
5478 (stap_is_operator): Likewise.
5479
61c9c421
TT
54802019-05-16 Tom Tromey <tromey@adacore.com>
5481
5482 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5483 keyword to foreach.
5484
9ddc1af1
SM
54852019-05-15 Simon Marchi <simon.marchi@efficios.com>
5486
5487 * linux-thread-db.c (try_thread_db_load_1): Change return type
5488 to bool.
5489 (try_thread_db_load): Likewise.
5490 (try_thread_db_load_from_pdir_1): Likewise.
5491 (try_thread_db_load_from_pdir): Likewise.
5492 (try_thread_db_load_from_sdir): Likewise.
5493 (try_thread_db_load_from_dir): Likewise.
5494 (thread_db_load_search): Likewise.
5495 (has_libpthread): Likewise.
5496 (thread_db_load): Likewise.
5497
7bede828
SDJ
54982019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5499
5500 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5501 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5502 NULL, and complain/return if that's the case.
5503
c5358db4
JD
55042019-05-15 John Darrington <john@darrington.wattle.id.au>
5505
5506 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5507 (advance, posn, abstract_read_memory): New functions.
5508 [struct mem_read_abstraction]: New struct.
5509 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5510
c408a94f
TT
55112019-05-14 Tom Tromey <tromey@adacore.com>
5512
5513 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5514 value is not lval_memory.
5515
e7bd7fba
TT
55162019-05-14 Tom Tromey <tromey@adacore.com>
5517
5518 * solib.c (info_sharedlibrary_command): Style the file name.
5519
a6d0f249
AH
55202019-05-14 Alan Hayward <alan.hayward@arm.com>
5521
5522 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5523 (aarch64_vnv_type): Likewise.
5524 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5525 * common/tdesc.c: Likewise.
5526 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5527 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5528 * features/aarch64-fpu.xml: Add ieee half view.
5529 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5530 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5531 * gdbtypes.h (struct builtin_type): Likewise.
5532 (struct objfile_type): Likewise.
5533
66b8bb74
SM
55342019-05-12 Paul Naert <paul.naert@polymtl.ca>
5535
5536 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5537 typo.
5538 * location.h (string_to_event_location): Likewise.
5539
21c219fd
JB
55402019-05-11 Joel Brobecker <brobecker@adacore.com>
5541
5542 GDB 8.3 released.
5543
13674803
SM
55442019-05-10 Simon Marchi <simon.marchi@efficios.com>
5545
5546 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5547 New variable declaration.
5548 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5549 New variable.
5550 (print_one_breakpoint): Use ui_out::test_flags and new global
5551 variable to compute use_fixed_output.
5552 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5553 Remove.
5554 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5555 (mi_multi_location_breakpoint_output_fixed): Remove.
5556 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5557 new variable.
5558 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5559 fix_multi_location_breakpoint_output flag if version >= 3.
5560 * ui-out.h (enum ui_out_flag)
5561 <fix_multi_location_breakpoint_output>: New enumerator.
5562
a9eac7f9
SM
55632019-05-10 Simon Marchi <simon.marchi@efficios.com>
5564
5565 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5566
71bed2db
TT
55672019-05-10 Tom Tromey <tromey@adacore.com>
5568
5569 * ada-lang.c (catch_ada_completer): New function.
5570 (_initialize_ada_language): Use it.
5571
24c54127
TT
55722019-05-10 Tom Tromey <tromey@adacore.com>
5573
5574 * thread.c (print_thread_info): Make "requested_threads" const.
5575 * gdbthread.h (print_thread_info): Make "requested_threads"
5576 const.
5577 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5578 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5579
7a102139
TT
55802019-05-08 Tom Tromey <tom@tromey.com>
5581
5582 * gdbtypes.c (objfile_type_data): Change type.
5583 (objfile_type, _initialize_gdbtypes): Update.
5584
924d79e2
TT
55852019-05-08 Tom Tromey <tom@tromey.com>
5586
5587 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5588 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5589 (_initialize_dwarf2_frame): Update.
5590
4c58e337
TT
55912019-05-08 Tom Tromey <tom@tromey.com>
5592
5593 * objc-lang.c (objc_objfile_data): Change type.
5594 (find_methods): Update.
5595 (_initialize_objc_lang): Remove.
5596
d772d2ab
TT
55972019-05-08 Tom Tromey <tom@tromey.com>
5598
5599 * stabsread.c (rs6000_builtin_type_data): Change type.
5600 (rs6000_builtin_type, _initialize_stabsread): Update.
5601
d11d83f4
TT
56022019-05-08 Tom Tromey <tom@tromey.com>
5603
5604 * mips-tdep.c (mips_pdr_data): Remove.
5605 (_initialize_mips_tdep): Update.
5606
9a73f0ad
TT
56072019-05-08 Tom Tromey <tom@tromey.com>
5608
5609 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5610 (hppa_init_objfile_priv_data, read_unwind_info)
5611 (find_unwind_entry, _initialize_hppa_tdep): Update.
5612
8127a2fa
TT
56132019-05-08 Tom Tromey <tom@tromey.com>
5614
5615 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5616 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5617 on obstack.
5618 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5619
91d3055d
TT
56202019-05-08 Tom Tromey <tom@tromey.com>
5621
5622 * mdebugread.c (basic_type_data): Change type.
5623 (basic_type, _initialize_mdebugread): Update.
5624
31930bd3
TT
56252019-05-08 Tom Tromey <tom@tromey.com>
5626
5627 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5628
bdb3ed9e
TT
56292019-05-08 Tom Tromey <tom@tromey.com>
5630
5631 * nto-tdep.c (nto_inferior_data_reg): Change type.
5632 (nto_inferior_data): Update.
5633 (nto_inferior_data_cleanup, nto_new_inferior_data)
5634 (_initialize_nto_tdep): Remove.
5635 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5636
f37b313d
TT
56372019-05-08 Tom Tromey <tom@tromey.com>
5638
5639 * ada-lang.c (struct ada_inferior_data): Add initializers.
5640 (ada_inferior_data): Change type.
5641 (ada_inferior_data_cleanup): Remove.
5642 (get_ada_inferior_data, ada_inferior_exit)
5643 (struct ada_pspace_data): Add initializers, destructor.
5644 (ada_pspace_data_handle): Change type.
5645 (get_ada_pspace_data): Update.
5646 (ada_pspace_data_cleanup): Remove.
5647
24699405
TT
56482019-05-08 Tom Tromey <tom@tromey.com>
5649
5650 * coffread.c (struct coff_symfile_info): Add initializers.
5651 (coff_objfile_data_key): Move lower. Change type.
5652 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5653 Update.
5654 (coff_free_info): Remove.
5655
d4e05d2f
TT
56562019-05-08 Tom Tromey <tom@tromey.com>
5657
5658 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5659 (fbsd_pspace_data_handle): Move lower. Change type.
5660 (get_fbsd_pspace_data): Update.
5661 (fbsd_pspace_data_cleanup): Remove.
5662 (_initialize_fbsd_tdep): Update.
5663
14ef6690
TT
56642019-05-08 Tom Tromey <tom@tromey.com>
5665
5666 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5667 (get_ada_tasks_pspace_data): Update.
5668 (ada_tasks_pspace_data_cleanup): Remove.
5669 (_initialize_tasks): Update.
5670 (ada_tasks_inferior_data_handle): Change type.
5671 (get_ada_tasks_inferior_data): Update.
5672 (ada_tasks_inferior_data_cleanup): Remove.
5673 (struct ada_tasks_pspace_data): Add initializers.
5674
814cf43a
TT
56752019-05-08 Tom Tromey <tom@tromey.com>
5676
5677 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5678 * symfile-debug.c (debug_sym_get_probes): Change type.
5679 * stap-probe.c (handle_stap_probe):
5680 (stap_static_probe_ops::get_probes): Change type.
5681 * probe.h (class static_probe_ops) <get_probes>: Change type.
5682 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5683 (parse_probes_in_pspace): Update.
5684 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5685 Update.
5686 (any_static_probe_ops::get_probes): Change type.
5687 * elfread.c (elfread_data): New typedef.
5688 (probe_key): Change type.
5689 (elf_get_probes): Likewise. Update.
5690 (probe_key_free): Remove.
5691 (_initialize_elfread): Update.
5692 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5693 Change type.
5694 (dtrace_process_dof_probe, dtrace_process_dof)
5695 (dtrace_static_probe_ops::get_probe): Change type.
5696
02dc647e
TT
56972019-05-08 Tom Tromey <tom@tromey.com>
5698
5699 * xcoffread.c (struct xcoff_symfile_info): Rename from
5700 coff_symfile_info. Add initializers.
5701 (xcoff_objfile_data_key): Move lower. Change type.
5702 (XCOFF_DATA): Rewrite.
5703 (xcoff_free_info): Remove.
5704 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5705 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5706 (xcoff_initial_scan): Update.
5707
09232438
TT
57082019-05-08 Tom Tromey <tom@tromey.com>
5709
5710 * solib-svr4.c (struct svr4_info): Add initializers and
5711 destructor.
5712 <probes_table>: Now an htab_up.
5713 (solib_svr4_pspace_data): Change type.
5714 (free_probes_table): Simplify.
5715 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5716 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5717 (probes_table_remove_objfile_probes, register_solib_event_probe)
5718 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5719 (_initialize_svr4_solib): Update.
5720
7b4a314f
TT
57212019-05-08 Tom Tromey <tom@tromey.com>
5722
5723 * remote.c (remote_pspace_data): Change type.
5724 (remote_pspace_data_cleanup): Remove.
5725 (get_remote_exec_file, set_pspace_remote_exec_file)
5726 (_initialize_remote): Update.
5727
51d3063a
TT
57282019-05-08 Tom Tromey <tom@tromey.com>
5729
5730 * breakpoint.c (breakpoint_objfile_key): Change type.
5731 (get_breakpoint_objfile_data): Update.
5732 (free_breakpoint_objfile_data): Remove.
5733 (_initialize_breakpoint): Update.
5734
89fb8848
TT
57352019-05-08 Tom Tromey <tom@tromey.com>
5736
5737 * linux-tdep.c (struct linux_info): Add initializers.
5738 (linux_inferior_data): Move. Change type.
5739 (invalidate_linux_cache_inf): Update.
5740 (linux_inferior_data_cleanup): Remove.
5741 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5742
e9b89e2d
TT
57432019-05-08 Tom Tromey <tom@tromey.com>
5744
5745 * auxv.c (auxv_inferior_data): Move. Change type.
5746 (auxv_inferior_data_cleanup): Remove.
5747 (invalidate_auxv_cache_inf): Rewrite.
5748 (get_auxv_inferior_data, _initialize_auxv): Update.
5749
8c42777c
TT
57502019-05-08 Tom Tromey <tom@tromey.com>
5751
5752 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5753 (symfile_debug_objfile_data_key): Change type.
5754 (symfile_debug_installed, debug_qf_has_symbols)
5755 (debug_qf_find_last_source_symtab)
5756 (debug_qf_forget_cached_source_info)
5757 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5758 (debug_qf_print_stats, debug_qf_dump)
5759 (debug_qf_expand_symtabs_for_function)
5760 (debug_qf_expand_all_symtabs)
5761 (debug_qf_expand_symtabs_with_fullname)
5762 (debug_qf_map_matching_symbols)
5763 (debug_qf_expand_symtabs_matching)
5764 (debug_qf_find_pc_sect_compunit_symtab)
5765 (debug_qf_map_symbol_filenames)
5766 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5767 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5768 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5769 (debug_sym_read_linetable, debug_sym_relocate): Update.
5770 (symfile_debug_free_objfile): Remove.
5771 (install_symfile_debug_logging, _initialize_symfile_debug):
5772 Update.
5773
5bfd760d
TT
57742019-05-08 Tom Tromey <tom@tromey.com>
5775
5776 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5777 allocate_on_obstack.
5778 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5779 (get_dwarf2_per_objfile): Update.
5780 (set_dwarf2_per_objfile): Remove.
5781 (dwarf2_has_info, dwarf2_get_section_info): Update.
5782 (dwarf2_free_objfile): Remove.
5783 (_initialize_dwarf2_read): Update.
5784
e85e19b4
TT
57852019-05-08 Tom Tromey <tom@tromey.com>
5786
5787 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5788 initializers.
5789 <unsupported_script_warning_printed,
5790 script_not_found_warning_printed>: Now bool.
5791 (auto_load_pspace_data): Change type.
5792 (~auto_load_pspace_info): Rename from
5793 auto_load_pspace_data_cleanup.
5794 (get_auto_load_pspace_data, init_loaded_scripts_info)
5795 (clear_section_scripts, maybe_print_unsupported_script_warning)
5796 (maybe_print_script_not_found_warning, _initialize_auto_load):
5797 Update.
5798
f6aa7436
TT
57992019-05-08 Tom Tromey <tom@tromey.com>
5800
5801 * objfiles.c (objfile_pspace_info): Add destructor and
5802 initializers.
5803 (objfiles_pspace_data): Change type.
5804 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5805 (get_objfile_pspace_data): Update.
5806 (objfiles_bfd_data): Change type.
5807 (get_objfile_bfd_data): Update.
5808 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5809
6ae614f6
TT
58102019-05-08 Tom Tromey <tom@tromey.com>
5811
5812 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5813 Change type.
5814 (get_catch_syscall_inferior_data): Update.
5815 (catch_syscall_inferior_data_cleanup): Remove.
5816 (_initialize_break_catch_syscall): Update.
5817
6509b8eb
TT
58182019-05-08 Tom Tromey <tom@tromey.com>
5819
5820 * inflow.c (struct terminal_info): Add destructor and
5821 initializers.
5822 (inflow_inferior_data): Change type.
5823 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5824 (get_inflow_inferior_data, inflow_inferior_exit)
5825 (swap_terminal_info, _initialize_inflow): Update.
5826
35632941
TT
58272019-05-08 Tom Tromey <tom@tromey.com>
5828
5829 * target-dcache.c (target_dcache_cleanup): Remove.
5830 (target_dcache_aspace_key): Change type.
5831 (target_dcache_init_p, target_dcache_invalidate)
5832 (target_dcache_get, target_dcache_get_or_init)
5833 (_initialize_target_dcache): Update.
5834 * dcache.h (struct dcache_deleter): New.
5835
3017b94d
TT
58362019-05-08 Tom Tromey <tom@tromey.com>
5837
5838 * symtab.c (struct symbol_cache): Add destructor and
5839 initializers.
5840 (symbol_cache_key): Move. Change type.
5841 (make_symbol_cache, free_symbol_cache): Remove.
5842 (get_symbol_cache): Update.
5843 (symbol_cache_cleanup): Remove.
5844 (ALL_PSPACES, symbol_cache_flush)
5845 (maintenance_print_symbol_cache)
5846 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5847 Update.
5848
a32ad8c5
TT
58492019-05-08 Tom Tromey <tom@tromey.com>
5850
5851 * symtab.c (struct main_info): Add destructor and initializers.
5852 (main_progspace_key): Move. Change type.
5853 (get_main_info): Update.
5854 (main_info_cleanup): Remove.
5855 (_initialize_symtab): Update.
5856
5f6e90a0
TT
58572019-05-08 Tom Tromey <tom@tromey.com>
5858
5859 * registry.h (DECLARE_REGISTRY): Define the _key class.
5860
1bd0c6e4
AB
58612019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5862
5863 * NEWS: Merge two 'New commands' sections.
5864
2228ef77
XR
58652019-05-08 Joel Brobecker <brobecker@adacore.com>
5866
5867 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5868 parameter and use Ada language definition instead.
5869 (ada_val_print_ptr): Remove unused language parameter.
5870 (ada_val_print_num): Remove language parameter and use Ada language
5871 definition instead.
5872 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5873 parameter.
5874 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5875 parameter and use Ada language definition instead.
5876 (ada_val_print_1): Update all ada_val_print_xxx calls.
5877 Remove language parameter.
5878 (ada_val_print): Update ada_val_print_1 call.
5879
60fcc1c3
TT
58802019-05-08 Tom Tromey <tromey@adacore.com>
5881
5882 * remote.c (remote_hw_watchpoint_limit)
5883 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5884 Now static.
5885
ed2b7c17
TT
58862019-05-08 Tom Tromey <tromey@adacore.com>
5887
5888 * maint.c (_initialize_maint_cmds): Move initialization code to
5889 remote.c.
5890 (watchdog, show_watchdog): Move to remote.c.
5891 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5892 "watchdog" static.
5893 (_initialize_remote): Move initialization code from maint.c.
5894 * defs.h (watchdog): Don't declare.
5895
b0be6c91
TT
58962019-05-08 Tom Tromey <tromey@adacore.com>
5897
5898 * tui/tui-interp.c: Include main.h.
5899 * interps.c: Include main.h.
5900 * main.h (interpreter_p): Declare.
5901 * defs.h (interpreter_p): Don't declare.
5902
587ee17b
TT
59032019-05-08 Tom Tromey <tromey@adacore.com>
5904
5905 * dwarf2loc.c: Include dwarf2read.h.
5906 * defs.h (read_unsigned_leb128): Don't declare.
5907 * dwarf2read.h (read_unsigned_leb128): Declare.
5908
ca1df239
TT
59092019-05-08 Tom Tromey <tromey@adacore.com>
5910
5911 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5912 method.
5913
99f20f08
TT
59142019-05-08 Tom Tromey <tromey@adacore.com>
5915
5916 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5917 when no wrap column is set.
5918
80e55b13
TT
59192019-05-08 Tom Tromey <tromey@adacore.com>
5920
5921 * c-lang.c (c_get_string): Handle non-C-style arrays.
5922
9d3421af
TT
59232019-05-08 Tom Tromey <tromey@adacore.com>
5924
5925 * typeprint.c (print_offset_data::update): Print the bit offset,
5926 not the number of bits remaining.
5927
844333e2
TT
59282019-05-08 Tom Tromey <tromey@adacore.com>
5929
5930 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5931 padding at end of comment.
5932
988915ee
TT
59332019-05-08 Tom Tromey <tromey@adacore.com>
5934
5935 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5936 Compare main types.
5937
26bfd823
TT
59382019-05-06 Tom Tromey <tom@tromey.com>
5939
5940 * common/scoped_mmap.c: Include common-defs.h.
5941 * common/scoped_mmap.h: Don't include config.h.
5942
89055eaa
TT
59432019-05-04 Tom Tromey <tom@tromey.com>
5944
5945 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5946 (struct aarch64_call_info): Add initializers.
5947 <si>: Now a std::vector.
5948 (pass_on_stack, aarch64_push_dummy_call): Update.
5949
5da01df5
TT
59502019-05-04 Simon Marchi <simon.marchi@efficios.com>
5951 Tom Tromey <tom@tromey.com>
5952
5953 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5954 (ppc_threads): Now a std::vector. Now static.
5955 (hwdebug_find_thread_points_by_tid)
5956 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5957 Update.
5958
fbdf05a1
TT
59592019-05-04 Tom Tromey <tom@tromey.com>
5960
5961 * arc-tdep.c (arc_tdesc_init): Return bool.
5962
06d16ec9
TT
59632019-05-04 Tom Tromey <tom@tromey.com>
5964
5965 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5966 Use gdb_assert_not_reached.
5967
9c056022
TT
59682019-05-04 Tom Tromey <tom@tromey.com>
5969
5970 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5971 "false".
5972
fa9c2a59
TT
59732019-05-04 Tom Tromey <tom@tromey.com>
5974
5975 * arc-tdep.c (arc_tdesc_init): Use bool.
5976
e2eb806a
TT
59772019-05-04 Tom Tromey <tom@tromey.com>
5978
5979 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5980
6fe87677
TT
59812019-05-04 Tom Tromey <tom@tromey.com>
5982
5983 * cli/cli-cmds.c (valid_command_p): Return bool.
5984
7f008c9e
TT
59852019-05-04 Tom Tromey <tom@tromey.com>
5986
5987 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5988 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5989
b6484282
RT
59902019-05-04 Raul Tambre <raul@tambre.ee>
5991
5992 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5993 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5994 operator for comparison.
5995
af97b416
TT
59962019-05-04 Tom Tromey <tom@tromey.com>
5997
5998 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5999 (lookup_partial_symbol, print_partial_symbols)
6000 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6001 (psymbol_compare): Update.
6002 (add_psymbol_to_bcache): Clear the entire psymbol.
6003 (maintenance_check_psymtabs): Update.
6004 * psympriv.h (struct partial_symbol): Don't derive from
6005 general_symbol_info.
6006 <obj_section, unrelocated_address, address,
6007 set_unrelocated_address>: Update.
6008 <ginfo>: New member.
6009 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6010 (debug_names::write_psymbols): Update.
6011
9d6d4be8
TV
60122019-05-04 Tom de Vries <tdevries@suse.de>
6013
6014 * contrib/cc-with-tweaks.sh: Support -n arg.
6015
66452beb
PW
60162019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6017
6018 * corelow.c (core_target::detach): Ensure frame cache and
6019 register caches are cleared.
6020 inferior.c (exit_inferior_1): Likewise.
6021
bde09ab7
TT
60222019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6023 Tom Tromey <tom@tromey.com>
6024
6025 * dictionary.c (collate_pending_symbols_by_language): Remove
6026 "struct" from foreach.
6027 * symtab.c (lookup_global_symbol_from_objfile)
6028 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6029 foreach.
6030 * ser-tcp.c (net_open): Remove "struct" from foreach.
6031 * objfiles.c (objfile_relocate, objfile_rebase)
6032 (objfile_has_symbols): Remove "struct" from foreach.
6033 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6034 from foreach.
6035 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6036 foreach.
6037 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6038 "struct" from foreach.
6039 * ada-lang.c (create_excep_cond_exprs)
6040 (ada_exception_catchpoint_cond_string): Remove "struct" from
6041 foreach.
6042
222a8d25
TT
60432019-05-03 Tom Tromey <tromey@adacore.com>
6044
6045 * ada-exp.y (convert_char_literal): Check suffix of each
6046 enumerator.
6047
fcd60b84
DP
60482019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6049
6050 PR ada/21406:
6051 * ada-exp.y (yywrap): Don't define.
6052 * ada-lex.l (%option): Add noyywrap
6053 (yywrap): Remove.
6054
5f2459c2
EZ
60552019-05-03 Eli Zaretskii <eliz@gnu.org>
6056
353ea2d1
EZ
6057 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6058 _WIN32_WINNT to the XP level, unless already defined to a higher
6059 level.
6060
6061 * unittests/parse-connection-spec-selftests.c:
6062 * ser-tcp.c:
6063 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6064 override.
6065
5f2459c2
EZ
6066 * symfile.c (find_separate_debug_file): Remove colon from the
6067 drive spec of DOS/Windows file names of the target, so that the
6068 file name produced from DEBUGDIR and the target's directory will
6069 be valid on DOS/Windows systems.
6070
80062eb9
AB
60712019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6072
6073 * rust-lang.c (val_print_struct): Handle printing structures
6074 containing strings.
6075
b8c05e85
TT
60762019-05-02 Tom Tromey <tromey@adacore.com>
6077
6078 * valarith.c (_initialize_valarith): Remove.
6079
4504bbde
TT
60802019-05-01 Tom Tromey <tromey@adacore.com>
6081
6082 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6083 bitfields.
6084
d48e62f4
TT
60852019-05-01 Tom Tromey <tromey@adacore.com>
6086
6087 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6088 for big-endian copies.
6089
15f18d14
AT
60902019-04-30 Ali Tamur <tamur@google.com>
6091 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6092 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6093 (read_3_bytes): New function.
6094
ab4ee614
JB
60952019-04-30 Joel Brobecker <brobecker@adacore.com>
6096
6097 * windows-nat.c (main_thread_id): Delete.
6098 (handle_output_debug_string): Replace main_thread_id by
6099 current_event.dwThreadId.
6100 (fake_create_process): Likewise.
6101 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6102 Do not set main_thread_id.
6103 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6104 current_event.dwThreadId.
6105 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6106
8ed5b76e
JB
61072019-04-30 Joel Brobecker <brobecker@adacore.com>
6108
6109 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6110 Use current_event.dwThreadId instead of main_thread_id.
6111
2ff0a947
TT
61122019-04-30 Tom Tromey <tromey@adacore.com>
6113
6114 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6115 (create_excep_cond_exprs): Iterate over program spaces.
6116 (ada_exception_catchpoint_cond_string): Examine all minimal
6117 symbols for exception types.
6118
a776957c
TT
61192019-04-30 Tom Tromey <tromey@adacore.com>
6120
6121 PR c++/24470:
6122 * dwarf2read.c (process_structure_scope): Handle case where type
6123 has template parameters but no symbol was created.
6124
bc68014d
AB
61252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6126 Chris January <chris.january@arm.com>
6127
6128 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6129 qualifier.
6130 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6131
f1fdc960
AB
61322019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6133
6134 * f-typeprint.c (f_print_type): Update rules for printing
6135 whitespace.
6136 (f_type_print_varspec_suffix): Likewise.
6137
bf7a4de1
AB
61382019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6139 Chris January <chris.january@arm.com>
6140
6141 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6142 function arguments.
6143
bbe75b9d
AB
61442019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6145
6146 * f-lang.c (build_fortran_types): Change name of void type to
6147 lower case.
6148 * f-typeprint.c (f_type_print_base): Print the name of the void
6149 type, rather than a fixed string.
6150 * f-valprint.c (f_decorations): Use lower case void string.
6151
1db455a7
AB
61522019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6153 Chris January <chris.january@arm.com>
6154
6155 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6156 types for Fortran.
6157
b6d03bb2
AB
61582019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6159 Chris January <chris.january@arm.com>
6160 David Lecomber <david.lecomber@arm.com>
6161
6162 * f-exp.y (BINOP_INTRINSIC): New token.
6163 (exp): New parser rule handling BINOP_INTRINSIC.
6164 (f77_keywords): Add new builtin procedures.
6165 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6166 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6167 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6168 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6169 (print_unop_subexp_f): New function.
6170 (print_binop_subexp_f): New function.
6171 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6172 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6173 (dump_subexp_body_f): Likewise.
6174 (operator_check_f): Likewise.
6175 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6176 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6177
83228e93
AB
61782019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6179
6180 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6181 UNOP_KIND.
6182 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6183 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6184 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6185 (operator_length_f): New fuction.
6186 (print_subexp_f): New function.
6187 (op_name_f): New function.
6188 (dump_subexp_body_f): New function.
6189 (operator_check_f): New function.
6190 (exp_descriptor_f): Replace standard expression handling functions
6191 with new functions.
6192 * gdb/fortran-operator.def: New file.
6193 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6194 * gdb/std-operator.def: Remove UNOP_KIND.
6195
6fdcd7cc
AB
61962019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6197
6198 * std-operator.def: Remove unbalanced, stray double quote
6199 character.
6200
2e62ab40
AB
62012019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6202 Chris January <chris.january@arm.com>
6203 Daniel Everett <daniel.everett@arm.com>
6204 Nick Forrington <nick.forrington@arm.com>
6205 Richard Bunt <richard.bunt@arm.com>
6206
6207 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6208 of depth when printing anonymous structs or unions.
6209 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6210 Don't print either the top-level value, or the children if the
6211 max-depth is exceeded.
6212 (ppscm_print_children): When printing the key of a map, allow one
6213 extra level of depth.
6214 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6215 print either the top-level value, or the children if the max-depth
6216 is exceeded.
6217 (print_children): When printing the key of a map, allow one extra
6218 level of depth.
6219 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6220 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6221 (user_print_options): Initialise max_depth field.
6222 (val_print_scalar_or_string_type_p): New function.
6223 (val_print): Check to see if the max depth has been reached.
6224 (val_print_check_max_depth): Define new function.
6225 (show_print_max_depth): New function.
6226 (_initialize_valprint): Add 'print max-depth' option.
6227 * valprint.h (struct value_print_options) <max_depth>: New field.
6228 (val_print_check_max_depth): Declare new function.
6229 * NEWS: Document new feature.
6230
4be290b2
AB
62312019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6232
6233 * ada-lang.c (ada_language_defn): Initialise new field.
6234 * c-lang.c (c_is_string_type_p): New function.
6235 (c_language_defn): Initialise new field.
6236 (cplus_language_defn): Initialise new field.
6237 (asm_language_defn): Initialise new field.
6238 (minimal_language_defn): Initialise new field.
6239 * c-lang.h (c_is_string_type_p): Declare new function.
6240 * d-lang.c (d_language_defn): Initialise new field.
6241 * f-lang.c (f_is_string_type_p): New function.
6242 (f_language_defn): Initialise new field.
6243 * go-lang.c (go_is_string_type_p): New function.
6244 (go_language_defn): Initialise new field.
6245 * language.c (default_is_string_type_p): New function.
6246 (unknown_language_defn): Initialise new field.
6247 (auto_language_defn): Initialise new field.
6248 * language.h (struct language_defn) <la_is_string_type_p>: New
6249 member variable.
6250 (default_is_string_type_p): Declare new function.
6251 * m2-lang.c (m2_language_defn): Initialise new field.
6252 * objc-lang.c (objc_language_defn): Initialise new field.
6253 * opencl-lang.c (opencl_language_defn): Initialise new field.
6254 * p-lang.c (pascal_is_string_type_p): New function.
6255 (pascal_language_defn): Initialise new field.
6256 * rust-lang.c (rust_is_string_type_p): New function.
6257 (rust_language_defn): Initialise new field.
6258
721b08c6
AB
62592019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6260
6261 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6262 New field.
6263 * ada-lang.c (ada_language_defn): Initialise new field.
6264 * c-lang.c (c_language_defn): Likewise.
6265 (cplus_language_defn): Likewise.
6266 (asm_language_defn): Likewise.
6267 (minimal_language_defn): Likewise.
6268 * d-lang.c (d_language_defn): Likewise.
6269 * f-lang.c (f_language_defn): Likewise.
6270 * go-lang.c (go_language_defn): Likewise.
6271 * language.c (unknown_language_defn): Likewise.
6272 (auto_language_defn): Likewise.
6273 * m2-lang.c (m2_language_defn): Likewise.
6274 * objc-lang.c (objc_language_defn): Likewise.
6275 * opencl-lang.c (opencl_language_defn): Likewise.
6276 * p-lang.c (pascal_language_defn): Likewise.
6277 * rust-lang.c (rust_language_defn): Likewise.
6278
fc913e53
AB
62792019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6280
6281 * ada-lang.c (ada_is_character_type): Change return type to bool.
6282 (ada_is_string_type): Likewise.
6283 * ada-lang.h (ada_is_character_type): Update declaration
6284 (ada_is_string_type): Likewise.
6285
fa731fa0
PW
62862019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6287
6288 Support style in 'frame|thread apply'
6289
6290 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6291 * record.c (record_start, record_stop): Update callers of
6292 execute_command_to_string with false.
6293 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6294 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6295 methods.
6296 (class string_file): New constructor with term_out parameter.
6297 Override methods term_out and can_emit_style_escape. New member
6298 term_out.
6299 (class stdio_file): Override can_emit_style_escape.
6300 (class tee_file): Override term_out and can_emit_style_escape.
6301 * utils.h (can_emit_style_escape): Remove.
6302 * utils.c (can_emit_style_escape): Likewise.
6303 Update all callers of can_emit_style_escape (SOMESTREAM) to
6304 SOMESTREAM->can_emit_style_escape.
6305 * source-cache.c (source_cache::get_source_lines): Likewise.
6306 * stack.c (frame_apply_command_count): Call execute_command_to_string
6307 passing the term_out characteristic of the current gdb_stdout.
6308 * thread.c (thr_try_catch_cmd): Likewise.
6309 * top.c (execute_command_to_string): pass term_out parameter
6310 to construct the string_file for the command output.
6311 * ui-file.c (term_cli_styling): New function (most code moved
6312 from utils.c can_emit_style_escape).
6313 (string_file::string_file, string_file::can_emit_style_escape,
6314 stdio_file::can_emit_style_escape, tee_file::term_out,
6315 tee_file::can_emit_style_escape): New functions.
6316
136afab8
PW
63172019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6318
6319 * NEWS: Mention the new set|show may-call-functions.
6320 * infcall.c (may_call_functions_p): New variable.
6321 (show_may_call_functions_p): New function.
6322 (call_function_by_hand_dummy): Throws an error if not
6323 may-call-functions.
6324 (_initialize_infcall): Call add_setshow_boolean_cmd for
6325 may-call-functions.
6326
725cbb63
KS
63272019-04-25 Keith Seitz <keiths@redhat.com>
6328
6329 PR c++/24367
6330 * cp-support.c (inspect_type): Don't attempt substitutions
6331 of symbol with the same name.
6332
3d1cbb78
TT
63332019-04-25 Tom Tromey <tromey@adacore.com>
6334
6335 PR gdb/24475:
6336 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6337 static.
6338
94aeb44b
TT
63392019-04-25 Tom Tromey <tromey@adacore.com>
6340
6341 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6342 rvalue reference.
6343 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6344 (gdb_xml_parser::parse): Use std::move.
6345 * python/python-internal.h (gdbpy_convert_exception): Take a const
6346 reference.
6347 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6348 std::move.
6349 * python/py-utils.c (gdbpy_convert_exception): Take a const
6350 reference.
6351 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6352 Use std::move.
6353 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6354 Use std::move.
6355 * mi/mi-main.c (mi_print_exception): Take a const reference.
6356 * main.c (handle_command_errors): Take a const reference.
6357 * linespec.c (parse_linespec): Use std::move.
6358 * infcall.c (run_inferior_call): Use std::move.
6359 (call_function_by_hand_dummy): Use std::move.
6360 * exec.c (try_open_exec_file): Use std::move.
6361 * exceptions.h (exception_print, exception_fprintf)
6362 (exception_print_same): Update.
6363 * exceptions.c (print_exception, exception_print)
6364 (exception_fprintf, exception_print_same): Change parameters to
6365 const reference.
6366 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6367 * common/new-op.c: Use std::move.
6368 * common/common-exceptions.h (struct gdb_exception): Add move
6369 constructor.
6370 (struct gdb_exception_error, struct gdb_exception_quit, struct
6371 gdb_quit_bad_alloc): Change constructor to move constructor.
6372 (throw_exception): Change parameter to rvalue reference.
6373 * common/common-exceptions.c (throw_exception): Take rvalue
6374 reference.
6375 * cli/cli-interp.c (safe_execute_command): Use std::move.
6376 * breakpoint.c (insert_bp_location, location_to_sals): Use
6377 std::move.
6378
680d7fd5
TT
63792019-04-25 Tom Tromey <tromey@adacore.com>
6380
6381 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6382 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6383 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6384 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6385 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6386 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6387 guile/scm-value.c: Use unpack.
6388 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6389 gdbscm_gdb_exception.
6390 (gdbscm_throw_gdb_exception): Likewise.
6391 (struct gdbscm_gdb_exception): New.
6392 (unpack): New function.
6393 (gdbscm_wrap): Use unpack.
6394
c6fdd8b2
TT
63952019-04-25 Tom Tromey <tromey@adacore.com>
6396
6397 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6398 (gdb_rl_callback_handler): Use std::move.
6399 * common/common-exceptions.h (struct gdb_exception): Add move
6400 assignment operator.
6401 (throw_exception_sjlj): Change "exception" to const reference.
6402 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6403 (throw_exception_sjlj): Change "exception" to const reference.
6404
cc06b668
TT
64052019-04-25 Tom Tromey <tromey@adacore.com>
6406
6407 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6408 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6409 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6410 Update.
6411 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6412 Update.
6413 * mi/mi-interp.c (mi_interp::exec): Update.
6414 * linespec.c (parse_linespec): Update.
6415 * infcall.c (run_inferior_call): Update.
6416 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6417 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6418 (gdbscm_lookup_global_symbol): Update.
6419 * guile/scm-param.c (gdbscm_parameter_value): Update.
6420 * guile/scm-frame.c (gdbscm_frame_read_register)
6421 (gdbscm_frame_read_var): Update.
6422 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6423 * exec.c (try_open_exec_file): Update.
6424 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6425 (gdb_rl_callback_handler): Update.
6426 * common/common-exceptions.h (exception_none): Don't declare.
6427 * common/common-exceptions.c (exception_none): Don't define.
6428 (struct catcher) <exception>: Update.
6429 * cli/cli-interp.c (safe_execute_command): Update.
6430 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6431
cf532bd1
AT
64322019-04-25 Ali Tamur <tamur@google.com>
6433
6434 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6435 (read_attribute_value): Likewise.
6436 (dwarf2_read_addr_index): Update comment.
6437 (read_str_index): Add DW_FORM_strx.
6438 (dwarf2_string_attr): Likewise.
6439 (dwarf2_const_value_attr): Likewise.
6440 (dump_die_shallow): Likewise.
6441 (dwarf2_fetch_constant_bytes): Likewise.
6442 (skip_form_bytes): Likewise.
6443 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6444
82433e3e
SDJ
64452019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6446
6447 PR corefiles/11608
6448 PR corefiles/18187
6449 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6450 OFFSET. Verify if current mapping contains an ELF header.
6451 (linux_find_memory_regions_full): Adjust call to
6452 dump_mapping_p.
6453
723adb65
SL
64542019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6455 Kang Li <kanglictf@gmail.com>
6456
6457 PR gdb/21600
6458
6459 * dwarf2-frame.c (read_initial_length): Be consistent about using
6460 unsigned representation of length.
6461 (decode_frame_entry_1): Likewise. Check for wraparound of
6462 end pointer as well as buffer overflow.
6463
596179f7
SDJ
64642019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6465
6466 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6467 "vq".
6468
a59240a4
TT
64692019-04-24 Tom Tromey <tromey@adacore.com>
6470
6471 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6472
f872fdbb
AB
64732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6474
6475 * s12z-tdep.c (s12z_unwind_pc): Delete.
6476 (s12z_unwind_sp): Delete.
6477 (s12z_gdbarch_init): Don't register deleted functions with
6478 gdbarch.
6479
b614e6f3
AB
64802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6481
6482 * rl78-tdep.c (rl78_unwind_sp): Delete.
6483 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6484
14faed38
AB
64852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6486
6487 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6488 (xstormy16_unwind_pc): Delete.
6489 (xstormy16_dummy_id): Delete.
6490 (xstormy16_gdbarch_init): Don't register deleted functions with
6491 gdbarch.
6492
541aad8a
AB
64932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6494
6495 * vax-tdep.c (vax_unwind_pc): Delete.
6496 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6497
29222070
AB
64982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6499
6500 * v850-tdep.c (v850_unwind_sp): Delete.
6501 (v850_unwind_pc): Delete.
6502 (v850_dummy_id): Delete.
6503 (v850_gdbarch_init): Don't register deleted functions with
6504 gdbarch.
6505
0f534d76
AB
65062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6507
6508 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6509 (tilegx_unwind_pc): Delete.
6510 (tilegx_unwind_dummy_id): Delete.
6511 (tilegx_gdbarch_init): Don't register deleted functions with
6512 gdbarch.
6513
1ba7b7f9
AB
65142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6515
6516 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6517 (tic6x_dummy_id): Delete.
6518 (tic6x_gdbarch_init): Don't register deleted functions with
6519 gdbarch.
6520
d31f262c
AB
65212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6522
6523 * sparc-tdep.c (sparc_unwind_pc): Delete.
6524 (sparc32_gdbarch_init): Don't register deleted function with
6525 gdbarch.
6526
6d14d64d
AB
65272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6528
6529 * sh-tdep.c (sh_unwind_sp): Delete.
6530 (sh_unwind_pc): Delete.
6531 (sh_dummy_id): Delete.
6532 (sh_gdbarch_init): Don't register deleted functions with
6533 gdbarch.
6534
a40dde9d
AB
65352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6536
6537 * score-tdep.c (score_unwind_sp): Delete.
6538 (score_unwind_pc): Delete.
6539 (score_dummy_id): Delete.
6540 (score_gdbarch_init): Don't register deleted functions with
6541 gdbarch.
6542
47c47d69
AB
65432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6544
6545 * rx-tdep.c (rx_unwind_pc): Delete.
6546 (rx_unwind_sp): Delete.
6547 (rx_dummy_id): Delete.
6548 (rx_gdbarch_init): Don't register deleted functions with
6549 gdbarch. Update comment.
6550
833a4480
AB
65512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6552
6553 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6554 (rs6000_dummy_id): Delete.
6555 (rs6000_gdbarch_init): Don't register deleted functions with
6556 gdbarch.
6557
3f2cef49
AB
65582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6559
6560 * or1k-tdep.c (or1k_dummy_id): Delete.
6561 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6562
96acf884
AB
65632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6564
6565 * nios2-tdep.c (nios2_dummy_id): Delete.
6566 (nios2_unwind_sp): Delete.
6567 (nios2_gdbarch_init): Don't register deleted functions with
6568 gdbarch.
6569
ca0ab0aa
AB
65702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6571
6572 * nds32-tdep.c (nds32_dummy_id): Delete.
6573 (nds32_unwind_pc): Delete.
6574 (nds32_unwind_sp): Delete.
6575 (nds32_gdbarch_init): Don't register deleted functions with
6576 gdbarch.
6577
c8259044
AB
65782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6579
6580 * msp430-tdep.c (msp430_unwind_pc): Delete.
6581 (msp430_unwind_sp): Delete.
6582 (msp430_dummy_id): Delete.
6583 (msp430_gdbarch_init): Don't register deleted functions with
6584 gdbarch.
6585
27f113c8
AB
65862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6587
6588 * moxie-tdep.c (moxie_unwind_sp): Delete.
6589 (moxie_unwind_pc): Delete.
6590 (moxie_dummy_id): Delete.
6591 (moxie_gdbarch_init): Don't register deleted functions with
6592 gdbarch.
6593
aee6c3cd
AB
65942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6595
6596 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6597 (mn10300_unwind_pc): Delete.
6598 (mn10300_unwind_sp): Delete.
6599 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6600 mn10300_unwind_sp.
6601 (mn10300_frame_unwind_init): Don't register deleted functions with
6602 gdbarch.
6603
8e2b5aea
AB
66042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6605
6606 * mep-tdep.c (mep_unwind_pc): Delete.
6607 (mep_unwind_sp): Delete.
6608 (mep_dummy_id): Delete.
6609 (mep_gdbarch_init): Don't register deleted functions with
6610 gdbarch.
6611
43cf3ede
AB
66122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6613
6614 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6615 (m68hc11_unwind_sp): Delete.
6616 (m68hc11_gdbarch_init): Don't register deleted functions with
6617 gdbarch.
6618
5e79b7bb
AB
66192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6620
6621 * m32r-tdep.c (m32r_unwind_sp): Delete.
6622 (m32r_unwind_pc): Delete.
6623 (m32r_dummy_id): Delete.
6624 (m32r_gdbarch_init): Don't register deleted functions with
6625 gdbarch.
6626
89b268d8
AB
66272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6628
6629 * m32c-tdep.c (m32c_unwind_pc): Delete.
6630 (m32c_unwind_sp): Delete.
6631 (m32c_dummy_id): Delete.
6632 (m32c_gdbarch_init): Don't register deleted functions with
6633 gdbarch.
6634
946c28d2
AB
66352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6636
6637 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6638 (lm32_unwind_pc): Delete.
6639 (lm32_dummy_id): Delete.
6640 (lm32_gdbarch_init): Don't register deleted functions with
6641 gdbarch.
6642
bf12844a
AB
66432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6644
6645 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6646 (iq2000_unwind_pc): Delete.
6647 (iq2000_dummy_id): Delete.
6648 (iq2000_gdbarch_init): Don't register deleted functions with
6649 gdbarch.
6650
ecbc06d2
AB
66512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6652
6653 * nds32-tdep.c (nds32_type_align): Delete.
6654 (nds32_push_dummy_call): Use type_align instead.
6655
030197b4
AB
66562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6657
6658 * arm-tdep.c (arm_type_align): Only handle vector override case.
6659 (arm_push_dummy_call): Use type_align.
6660 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6661
b907456c
AB
66622019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6663
6664 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6665 case.
6666 (pass_on_stack): Use type_align.
6667 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6668 function.
6669
9e97ba43
TT
66702019-04-23 Tom Tromey <tromey@adacore.com>
6671
6672 * dwarf2read.c (line_header::file_name_at): Remove unused
6673 overload.
6674
6892f601
TV
66752019-04-23 Tom de Vries <tdevries@suse.de>
6676
6677 PR gdb/24438
6678 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6679 invocation.
6680
336d760d
AT
6681
66822019-03-27 Ali Tamur <tamur@google.com>
6683
6684 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6685 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6686 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6687 (dwarf_expr_context::get_addr_index): Likewise
6688 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6689 (symbol_needs_eval_context::get_addr_index): Likewise
6690 (disassemble_dwarf_expression): Add DW_OP_addrx
6691 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6692 (read_cutu_die_from_dwo): Update comment
6693 (skip_one_die): Add DW_FORM_addrx
6694 (read_attribute_value): Likewise
6695 (var_decode_location): Add DW_OP_addrx
6696 (dwarf2_const_value_attr): Add DW_FORM_addrx
6697 (dump_die_shallow): Likewise
6698 (dwarf2_fetch_constant_bytes): Likewise
6699 (decode_locdesc): Add DW_OP_addrx
6700 (skip_form_bytes): Add DW_FORM_addrx
6701
ad9d13f8
AT
67022019-04-22 Ali Tamur <tamur@google.com>
6703
6704 * MAINTAINERS (Write After Approval): Add self.
6705
d70cc3ba
SM
67062019-04-22 Simon Marchi <simon.marchi@efficios.com>
6707
6708 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6709 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6710 (open_symbol_file_object): Likewise.
6711 (svr4_default_sos): Add info parameter.
6712 (svr4_read_so_list): Likewise.
6713 (svr4_current_sos_direct): Adjust functions calls to pass down
6714 info.
6715 (svr4_current_sos_1): Add info parameter.
6716 (svr4_current_sos): Call get_svr4_info, pass info down to
6717 svr4_current_sos_1.
6718 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6719 get_svr4_info.
6720 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6721 get_svr4_info.
6722 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6723 to get_svr4_info.
6724 (probes_table_remove_objfile_probes): Likewise.
6725 (register_solib_event_probe): Add info parameter.
6726 (solist_update_incremental): Pass info parameter down to
6727 svr4_read_so_list.
6728 (disable_probes_interface): Add info parameter.
6729 (svr4_handle_solib_event): Pass current_program_space to
6730 get_svr4_info. Adjust disable_probes_interface cleanup.
6731 (svr4_create_probe_breakpoints): Add info parameter, pass it
6732 down to register_solib_event_probe.
6733 (svr4_create_solib_event_breakpoints): Add info parameter,
6734 pass it down to svr4_create_probe_breakpoints.
6735 (enable_break): Pass info down to
6736 svr4_create_solib_event_breakpoints.
6737 (svr4_solib_create_inferior_hook): Pass current_program_space to
6738 get_svr4_info.
6739 (svr4_clear_solib): Likewise.
6740
7905fc35
PA
67412019-04-22 Pedro Alves <palves@redhat.com>
6742
6743 * solib-svr4.c (svr4_free_objfile_observer): New.
6744 (probe_and_action::objfile): New field.
6745 (probes_table_htab_remove_objfile_probes)
6746 (probes_table_remove_objfile_probes): New functions.
6747 (register_solib_event_probe): Add 'objfile' parameter. Store it
6748 in the new probe_and_action. Don't store the probe in 'lookup'.
6749 (svr4_create_probe_breakpoints): Pass objfile to
6750 register_solib_event_probe.
6751 (_initialize_svr4_solib): Register a free_objfile observer.
6752
fb881986
TT
67532019-04-19 Tom Tromey <tom@tromey.com>
6754
6755 * common/queue.h: Remove.
6756
8732db6c
TT
67572019-04-19 Tom Tromey <tom@tromey.com>
6758
6759 * event-loop.c: Don't include "common/queue.h".
6760
97dfbadd
TT
67612019-04-19 Tom Tromey <tom@tromey.com>
6762
6763 * remote.c (remote_target): Use delete.
6764 * remote-notif.h: Include <list>, not "common/queue.h".
6765 (notif_client_p): Remove typedef.
6766 (remote_notif_state): Add constructor, destructor, initializer.
6767 <notif_queue>: Now a std::list.
6768 (remote_notif_state_xfree): Don't declare.
6769 * remote-notif.c (remote_notif_process, handle_notification)
6770 (remote_notif_state_allocate): Update.
6771 (~remote_notif_state): Rename from remote_notif_state_xfree.
6772
cf250e36
TT
67732019-04-19 Tom Tromey <tom@tromey.com>
6774
6775 * symfile.c (reread_symbols): Update.
6776 * objfiles.c (objfile_register_static_link)
6777 (objfile_lookup_static_link): Update
6778 (~objfile) Don't delete static_links.
6779 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6780
61f4b350
TT
67812019-04-19 Tom Tromey <tom@tromey.com>
6782
6783 * type-stack.h (struct type_stack) <insert>: Constify string.
6784 * type-stack.c (type_stack::insert): Constify string.
6785 * gdbtypes.h (lookup_template_type): Update.
6786 (address_space_name_to_int): Update.
6787 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6788 const.
6789 (lookup_template_type): Make name const.
6790 * c-exp.y: Update rules.
6791 (lex_one_token, classify_name, classify_inner_name)
6792 (c_print_token): Update.
6793 * p-exp.y: Update rules.
6794 (yylex): Update.
6795 * f-exp.y: Update rules.
6796 (yylex): Update.
6797 * d-exp.y: Update rules.
6798 (lex_one_token, classify_name, classify_inner_name): Update.
6799 * parse.c (write_dollar_variable, copy_name): Return std::string.
6800 * parser-defs.h (copy_name): Change return type.
6801 * m2-exp.y: Update rules.
6802 (yylex): Update.
6803 * go-exp.y (lex_one_token): Update.
6804 Update rules.
6805 (classify_unsafe_function, classify_packaged_name)
6806 (classify_name, yylex): Update.
6807
189b8c2e
ST
68082019-04-19 Sergei Trofimovich <siarheit@google.com>
6809
6810 * configure.ac: add --enable-source-highlight switch.
6811 * configure: Regenerate.
6812 * top.c (print_gdb_version): plumb --enable-source-highlight
6813 status to "show configuration".
6814
8ecb59f8
TT
68152019-04-19 Tom Tromey <tromey@adacore.com>
6816
6817 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6818 Check ADA_TYPE_P.
6819 (empty_record, ada_template_to_fixed_record_type_1)
6820 (template_to_static_fixed_type)
6821 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6822 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6823 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6824 macros.
6825
62160ec9
TT
68262019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6827
6828 PR symtab/24423:
6829 * source.c (print_source_lines_base): Advance "iter" when a
6830 control character is seen.
6831
f2ae8bc8
PW
68322019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6833
6834 * inferior.h (struct infcall_suspend_state_deleter):
6835 Catch exception in destructor to avoid crash.
6836
d563b953
PW
68372019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6838
6839 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6840 close to the add_com "shell".
6841
dc34c897
TT
68422019-04-18 Tom Tromey <tromey@adacore.com>
6843
6844 * process-stratum-target.h (class process_stratum_target)
6845 <stratum>: Add "final".
6846
a12e5744
TT
68472019-04-17 Tom Tromey <tromey@adacore.com>
6848
6849 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6850 against nullptr before use.
6851
a7e559cc
AH
68522019-04-17 Alan Hayward <alan.hayward@arm.com>
6853
6854 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6855
c01660c6
AB
68562019-04-17 Jim Wilson <jimw@sifive.com>
6857 Andrew Burgess <andrew.burgess@embecosm.com>
6858
6859 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6860 code read might fail, assume 4-byte breakpoint in that case.
6861
4aa866af
LS
68622019-04-15 Leszek Swirski <leszeks@google.com>
6863
6864 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6865 rather than a hand-rolled POD check when checking for forced MEMORY
6866 classification.
6867
48574d91
AH
68682019-04-15 Alan Hayward <alan.hayward@arm.com>
6869
6870 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6871 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6872 function.
6873 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6874 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6875 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6876 declaration.
6877
4da037ef
AH
68782019-04-15 Alan Hayward <alan.hayward@arm.com>
6879
6880 * aarch64-linux-nat.c
6881 (aarch64_linux_nat_target::thread_architecture): Add override.
6882 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6883 each VQ.
6884
ccb8d7e8
AH
68852019-04-15 Alan Hayward <alan.hayward@arm.com>
6886
6887 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6888
35add35e
AB
68892019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6890
6891 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6892 target types of size 96-bits, add some additional comments, and
6893 check that the builtin type we found was the correct size.
6894
51196bbc
EZ
68952019-04-12 Eli Zaretskii <eliz@gnu.org>
6896
6897 * utils.c (prompt_for_continue): Don't restore the styling at the
6898 end, as applied_style has the wrong value. This fixes styling in
6899 long lists of file names that are interrupted by the "Continue?"
6900 prompt.
6901
62253a61
AB
69022019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6903
6904 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6905 * c-lang.c (c_language_defn): Likewise.
6906 (cplus_language_defn): Likewise.
6907 (asm_language_defn): Likewise.
6908 (minimal_language_defn): Likewise.
6909 * d-lang.c (d_language_defn): Likewise.
6910 * f-lang.c (f_language_defn): Likewise.
6911 * go-lang.c (go_language_defn): Likewise.
6912 * language.c (unknown_language_defn): Likewise.
6913 (auto_language_defn): Likewise.
6914 * language.h (struct language_defn): Remove la_magic field.
6915 (LANG_MAGIC): Delete.
6916 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6917 * objc-lang.c (objc_language_defn): Likewise.
6918 * opencl-lang.c (opencl_language_defn): Likewise.
6919 * p-lang.c (pascal_language_defn): Likewise.
6920 * rust-lang.c (rust_language_defn): Likewise.
6921
a9158a86
AB
69222019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6923
6924 * riscv-tdep.c (riscv_type_align): New function.
6925 (riscv_type_alignment): Delete.
6926 (riscv_arg_location): Use 'type_align'.
6927 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6928
41077b66
AB
69292019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6930
6931 * gdbtypes.c (type_align): A struct with no non-static fields also
6932 has alignment of 1.
6933
9f0272f8
AB
69342019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6935
6936 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6937 component to 0.
6938 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6939 member.
6940 (riscv_struct_info::analyse): New implementation using new
6941 analyse_inner member function.
6942 (riscv_struct_info::field_offset): New member function.
6943 (riscv_struct_info::m_offsets): New member variable.
6944 (riscv_struct_info::analyse_inner): New private member function,
6945 takes the old implementation of riscv_struct_info::analyse but
6946 extended to track field offsets.
6947 (riscv_call_arg_struct): Update the struct folding special cases
6948 to handle cases where empty C++ structs, which are non-zero
6949 length, are found.
6950 (riscv_arg_location): Initialise the length of each location, a
6951 non-zero length now indicates the location is in use.
6952 (riscv_push_dummy_call): Allow for the first location having a
6953 non-zero offset when setting up arguments.
6954 (riscv_return_value): Likewise, but for return values.
6955
02cf60c7
TT
69562019-04-11 Tom Tromey <tromey@adacore.com>
6957
6958 * utils.c (internal_vproblem): Make "msg" const.
6959
68811f8f
AH
69602019-04-11 Alan Hayward <alan.hayward@arm.com>
6961
6962 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6963 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6964 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6965 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6966
3f52fdbc
KB
69672019-04-10 Kevin Buettner <kevinb@redhat.com>
6968
6969 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6970 function.
6971 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6972 of amd64_collect_native_gregset.
6973 (amd64_linux_nat_target::store_registers): Likewise.
6974
e9ad22ee
TT
69752019-04-10 Tom Tromey <tom@tromey.com>
6976
6977 * symtab.c (lookup_global_symbol_from_objfile)
6978 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6979 * objfiles.h (class separate_debug_iterator): New.
6980 (class separate_debug_range): New.
6981 (struct objfile) <separate_debug_objfiles>: New method.
6982 (objfile_separate_debug_iterate): Don't declare.
6983 * objfiles.c (separate_debug_iterator::operator++): Rename from
6984 objfile_separate_debug_iterate.
6985 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6986 iterator.
6987 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6988 iterator.
6989
ee371134
TT
69902019-04-10 Tom Tromey <tom@tromey.com>
6991
6992 * symfile.c (reread_symbols): Remove old comment.
6993 * objfiles.c (free_all_objfiles): Fix a typo.
6994
bf227d61
TT
69952019-04-10 Tom Tromey <tom@tromey.com>
6996
6997 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6998 * minsyms.c (lookup_minimal_symbol): Use foreach.
6999 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7000 (lookup_minimal_symbol_solib_trampoline): Likewise.
7001 * symfile.c (reread_symbols): Use foreach.
7002
8dc433a0
TT
70032019-04-09 Ivan Begert <ivanbegert@gmail.com>
7004 Tom Tromey <tromey@adacore.com>
7005
7006 PR rust/24414:
7007 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7008 (rust_lex_int_test): Change "value" to be LONGEST.
7009 (rust_lex_tests): Add test for long integer literal.
7010
9ab8741a
TT
70112019-04-09 Tom Tromey <tromey@adacore.com>
7012
7013 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7014 to bool.
7015 (extended_remote_target::attach): Update.
7016 (remote_target::remote_notice_new_inferior): Update.
7017 (remote_target::add_current_inferior_and_thread): Update.
7018 * inferior.c (exit_inferior_1): Use "false".
7019 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7020
e242fd12
SM
70212019-04-09 Simon Marchi <simon.marchi@efficios.com>
7022
9ca1957f 7023 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7024 the "start" command.
7025
2b0c8b01
KB
70262019-04-08 Kevin Buettner <kevinb@redhat.com>
7027
7028 * python/py-inferior.c (infpy_thread_from_thread_handle):
7029 Adjust comments to reflect renaming of thread_from_thread_handle
7030 to thread_from_handle. Adjust keywords. Fix type error message.
7031 (inferior_object_methods): Add thread_from_handle. Retain
7032 thread_from_thread_handle, but mark it as deprecated.
7033
50a82723
KB
70342019-04-08 Kevin Buettner <kevinb@redhat.com>
7035
7036 * gdbthread.h (find_thread_by_handle): Revise declaration.
7037 * thread.c (find_thread_by_handle): Likewise. Adjust
7038 implementation too.
7039 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7040 support for buffer objects as handles.
7041
cf63b016
KB
70422019-04-08 Kevin Buettner <kevinb@redhat.com>
7043
7044 * python/py-infthread.c (thpy_thread_handle): New function.
7045 (thread_object_methods): Register thpy_thread_handle.
7046
3d6c6204
KB
70472019-04-08 Kevin Buettner <kevinb@redhat.com>
7048
7049 * gdbthread.h (thread_to_thread_handle): Declare.
7050 * thread.c (gdbtypes.h): Include.
7051 (thread_to_thread_handle): New function.
7052
7053 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7054 (target_thread_info_to_thread_handle): Declare.
7055 * target.c (target_thread_info_to_thread_handle): New function.
7056 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7057 * target-delegates.c: Regenerate.
7058
7059 * linux-thread-db.c (class thread_db_target): Add method
7060 thread_info_to_thread_handle.
7061 (thread_db_target::thread_info_to_thread_handle): Define.
7062 * remote.c (class remote_target): Add new method
7063 thread_info_to_thread_handle.
7064 (remote_target::thread_info_to_thread_handle): Define.
7065
56be6ea8
PA
70662019-04-08 Pedro Alves <palves@redhat.com>
7067
7068 * common/common-exceptions.c (throw_exception): Don't create
7069 named object to throw; throw directly.
7070 (throw_it): Likewise. Don't initialize gdb_exception::message
7071 here, with new; pass FMT and AP to the ctor instead.
7072 * common/common-exceptions.h: Include <string>.
7073 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7074 const char *, va_list)): New ctor. Use std::make_shared.
7075 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7076 errors)): Delete.
7077 (gdb_exception_error::gdb_exception_error(enum errors, const char
7078 *, va_list)): New.
7079 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7080 Add assertion.
7081 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7082 errors)): Delete.
7083 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7084 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7085 Add assertion.
7086
eedc3f4f
TT
70872019-04-08 Tom Tromey <tom@tromey.com>
7088
7089 * valops.c (value_rtti_indirect_type): Replace throw_exception
7090 with throw.
7091 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7092 with throw.
7093 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7094 throw.
7095 * target.c (target_translate_tls_address): Replace throw_exception
7096 with throw.
7097 * stack.c (frame_apply_command_count): Replace throw_exception
7098 with throw.
7099 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7100 throw.
7101 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7102 with throw.
7103 * rs6000-tdep.c (rs6000_frame_cache)
7104 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7105 * remote.c: Replace throw_exception with throw.
7106 * record-full.c (record_full_message, record_full_wait_1)
7107 (record_full_restore): Replace throw_exception with throw.
7108 * record-btrace.c:
7109 (get_thread_current_frame_id, record_btrace_start_replaying)
7110 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7111 (cmd_record_btrace_start): Replace throw_exception with throw.
7112 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7113 throw.
7114 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7115 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7116 * linespec.c:
7117 (find_linespec_symbols): Replace throw_exception with throw.
7118 * infrun.c (displaced_step_prepare, resume): Replace
7119 throw_exception with throw.
7120 * infcmd.c (post_create_inferior): Replace throw_exception with
7121 throw.
7122 * inf-loop.c (inferior_event_handler): Replace throw_exception
7123 with throw.
7124 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7125 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7126 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7127 (get_prev_frame_always, get_frame_pc_if_available)
7128 (get_frame_address_in_block_if_available, get_frame_language):
7129 Replace throw_exception with throw.
7130 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7131 throw_exception with throw.
7132 * eval.c (fetch_subexp_value, evaluate_var_value)
7133 (evaluate_funcall, evaluate_subexp_standard): Replace
7134 throw_exception with throw.
7135 * dwarf2loc.c (call_site_find_chain)
7136 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7137 Replace throw_exception with throw.
7138 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7139 with throw.
7140 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7141 throw.
7142 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7143 * completer.c (complete_line_internal): Replace throw_exception
7144 with throw.
7145 * compile/compile-object-run.c (compile_object_run): Replace
7146 throw_exception with throw.
7147 * cli/cli-script.c (process_next_line): Replace throw_exception
7148 with throw.
7149 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7150 (btrace_enable, btrace_maint_update_pt_packets): Replace
7151 throw_exception with throw.
7152 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7153 throw_exception with throw.
7154 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7155 throw_exception with throw.
7156 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7157 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7158 * aarch64-tdep.c (aarch64_make_prologue_cache)
7159 (aarch64_make_stub_cache): Replace throw_exception with throw.
7160
26003a20
TT
71612019-04-08 Tom Tromey <tom@tromey.com>
7162
7163 * common/common-exceptions.c (throw_exception): Rename from
7164 throw_exception_cxx. Remove old copy. Make argument const.
7165 (throw_it): Create and throw exception objects directly.
7166 * common/common-exceptions.h (throw_exception): Make argument
7167 const.
7168 (struct gdb_exception_error): Add constructor.
7169 (struct gdb_exception_quit): Add constructor.
7170
d272eb37
TT
71712019-04-08 Tom Tromey <tom@tromey.com>
7172
7173 * common/common-exceptions.h (exception_rethrow): Don't declare.
7174 (TRY_SJLJ): Update comment.
7175 (TRY, CATCH, END_CATCH): Remove.
7176 * common/common-exceptions.c (exception_rethrow): Remove.
7177
230d2906
TT
71782019-04-08 Tom Tromey <tom@tromey.com>
7179
7180 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7181 Remove.
7182 (gdb_exception_error): Rename from
7183 gdb_exception_RETURN_MASK_ERROR.
7184 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7185 (gdb_quit_bad_alloc): Update.
7186 * aarch64-tdep.c: Update.
7187 * ada-lang.c: Update.
7188 * ada-typeprint.c: Update.
7189 * ada-valprint.c: Update.
7190 * amd64-tdep.c: Update.
7191 * arch-utils.c: Update.
7192 * break-catch-throw.c: Update.
7193 * breakpoint.c: Update.
7194 * btrace.c: Update.
7195 * c-varobj.c: Update.
7196 * cli/cli-cmds.c: Update.
7197 * cli/cli-interp.c: Update.
7198 * cli/cli-script.c: Update.
7199 * common/common-exceptions.c: Update.
7200 * common/new-op.c: Update.
7201 * common/selftest.c: Update.
7202 * compile/compile-c-symbols.c: Update.
7203 * compile/compile-cplus-symbols.c: Update.
7204 * compile/compile-object-load.c: Update.
7205 * compile/compile-object-run.c: Update.
7206 * completer.c: Update.
7207 * corelow.c: Update.
7208 * cp-abi.c: Update.
7209 * cp-support.c: Update.
7210 * cp-valprint.c: Update.
7211 * darwin-nat.c: Update.
7212 * disasm-selftests.c: Update.
7213 * dtrace-probe.c: Update.
7214 * dwarf-index-cache.c: Update.
7215 * dwarf-index-write.c: Update.
7216 * dwarf2-frame-tailcall.c: Update.
7217 * dwarf2-frame.c: Update.
7218 * dwarf2loc.c: Update.
7219 * dwarf2read.c: Update.
7220 * eval.c: Update.
7221 * event-loop.c: Update.
7222 * event-top.c: Update.
7223 * exec.c: Update.
7224 * f-valprint.c: Update.
7225 * fbsd-tdep.c: Update.
7226 * frame-unwind.c: Update.
7227 * frame.c: Update.
7228 * gdbtypes.c: Update.
7229 * gnu-v3-abi.c: Update.
7230 * guile/guile-internal.h: Update.
7231 * guile/scm-block.c: Update.
7232 * guile/scm-breakpoint.c: Update.
7233 * guile/scm-cmd.c: Update.
7234 * guile/scm-disasm.c: Update.
7235 * guile/scm-frame.c: Update.
7236 * guile/scm-lazy-string.c: Update.
7237 * guile/scm-math.c: Update.
7238 * guile/scm-param.c: Update.
7239 * guile/scm-ports.c: Update.
7240 * guile/scm-pretty-print.c: Update.
7241 * guile/scm-symbol.c: Update.
7242 * guile/scm-symtab.c: Update.
7243 * guile/scm-type.c: Update.
7244 * guile/scm-value.c: Update.
7245 * i386-linux-tdep.c: Update.
7246 * i386-tdep.c: Update.
7247 * inf-loop.c: Update.
7248 * infcall.c: Update.
7249 * infcmd.c: Update.
7250 * infrun.c: Update.
7251 * jit.c: Update.
7252 * language.c: Update.
7253 * linespec.c: Update.
7254 * linux-fork.c: Update.
7255 * linux-nat.c: Update.
7256 * linux-tdep.c: Update.
7257 * linux-thread-db.c: Update.
7258 * main.c: Update.
7259 * mi/mi-cmd-break.c: Update.
7260 * mi/mi-cmd-stack.c: Update.
7261 * mi/mi-interp.c: Update.
7262 * mi/mi-main.c: Update.
7263 * objc-lang.c: Update.
7264 * p-valprint.c: Update.
7265 * parse.c: Update.
7266 * ppc-linux-tdep.c: Update.
7267 * printcmd.c: Update.
7268 * python/py-arch.c: Update.
7269 * python/py-breakpoint.c: Update.
7270 * python/py-cmd.c: Update.
7271 * python/py-finishbreakpoint.c: Update.
7272 * python/py-frame.c: Update.
7273 * python/py-framefilter.c: Update.
7274 * python/py-gdb-readline.c: Update.
7275 * python/py-inferior.c: Update.
7276 * python/py-infthread.c: Update.
7277 * python/py-lazy-string.c: Update.
7278 * python/py-linetable.c: Update.
7279 * python/py-objfile.c: Update.
7280 * python/py-param.c: Update.
7281 * python/py-prettyprint.c: Update.
7282 * python/py-progspace.c: Update.
7283 * python/py-record-btrace.c: Update.
7284 * python/py-record.c: Update.
7285 * python/py-symbol.c: Update.
7286 * python/py-type.c: Update.
7287 * python/py-unwind.c: Update.
7288 * python/py-utils.c: Update.
7289 * python/py-value.c: Update.
7290 * python/python.c: Update.
7291 * record-btrace.c: Update.
7292 * record-full.c: Update.
7293 * remote-fileio.c: Update.
7294 * remote.c: Update.
7295 * riscv-tdep.c: Update.
7296 * rs6000-aix-tdep.c: Update.
7297 * rs6000-tdep.c: Update.
7298 * rust-exp.y: Update.
7299 * rust-lang.c: Update.
7300 * s390-tdep.c: Update.
7301 * selftest-arch.c: Update.
7302 * solib-dsbt.c: Update.
7303 * solib-frv.c: Update.
7304 * solib-spu.c: Update.
7305 * solib-svr4.c: Update.
7306 * solib.c: Update.
7307 * sparc64-linux-tdep.c: Update.
7308 * stack.c: Update.
7309 * symfile-mem.c: Update.
7310 * symmisc.c: Update.
7311 * target.c: Update.
7312 * thread.c: Update.
7313 * top.c: Update.
7314 * tracefile-tfile.c: Update.
7315 * tui/tui.c: Update.
7316 * typeprint.c: Update.
7317 * unittests/cli-utils-selftests.c: Update.
7318 * unittests/parse-connection-spec-selftests.c: Update.
7319 * valops.c: Update.
7320 * valprint.c: Update.
7321 * value.c: Update.
7322 * varobj.c: Update.
7323 * windows-nat.c: Update.
7324 * x86-linux-nat.c: Update.
7325 * xml-support.c: Update.
7326
a70b8144
TT
73272019-04-08 Tom Tromey <tom@tromey.com>
7328
7329 * xml-support.c: Use C++ exception handling.
7330 * x86-linux-nat.c: Use C++ exception handling.
7331 * windows-nat.c: Use C++ exception handling.
7332 * varobj.c: Use C++ exception handling.
7333 * value.c: Use C++ exception handling.
7334 * valprint.c: Use C++ exception handling.
7335 * valops.c: Use C++ exception handling.
7336 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7337 handling.
7338 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7339 * typeprint.c: Use C++ exception handling.
7340 * tui/tui.c: Use C++ exception handling.
7341 * tracefile-tfile.c: Use C++ exception handling.
7342 * top.c: Use C++ exception handling.
7343 * thread.c: Use C++ exception handling.
7344 * target.c: Use C++ exception handling.
7345 * symmisc.c: Use C++ exception handling.
7346 * symfile-mem.c: Use C++ exception handling.
7347 * stack.c: Use C++ exception handling.
7348 * sparc64-linux-tdep.c: Use C++ exception handling.
7349 * solib.c: Use C++ exception handling.
7350 * solib-svr4.c: Use C++ exception handling.
7351 * solib-spu.c: Use C++ exception handling.
7352 * solib-frv.c: Use C++ exception handling.
7353 * solib-dsbt.c: Use C++ exception handling.
7354 * selftest-arch.c: Use C++ exception handling.
7355 * s390-tdep.c: Use C++ exception handling.
7356 * rust-lang.c: Use C++ exception handling.
7357 * rust-exp.y: Use C++ exception handling.
7358 * rs6000-tdep.c: Use C++ exception handling.
7359 * rs6000-aix-tdep.c: Use C++ exception handling.
7360 * riscv-tdep.c: Use C++ exception handling.
7361 * remote.c: Use C++ exception handling.
7362 * remote-fileio.c: Use C++ exception handling.
7363 * record-full.c: Use C++ exception handling.
7364 * record-btrace.c: Use C++ exception handling.
7365 * python/python.c: Use C++ exception handling.
7366 * python/py-value.c: Use C++ exception handling.
7367 * python/py-utils.c: Use C++ exception handling.
7368 * python/py-unwind.c: Use C++ exception handling.
7369 * python/py-type.c: Use C++ exception handling.
7370 * python/py-symbol.c: Use C++ exception handling.
7371 * python/py-record.c: Use C++ exception handling.
7372 * python/py-record-btrace.c: Use C++ exception handling.
7373 * python/py-progspace.c: Use C++ exception handling.
7374 * python/py-prettyprint.c: Use C++ exception handling.
7375 * python/py-param.c: Use C++ exception handling.
7376 * python/py-objfile.c: Use C++ exception handling.
7377 * python/py-linetable.c: Use C++ exception handling.
7378 * python/py-lazy-string.c: Use C++ exception handling.
7379 * python/py-infthread.c: Use C++ exception handling.
7380 * python/py-inferior.c: Use C++ exception handling.
7381 * python/py-gdb-readline.c: Use C++ exception handling.
7382 * python/py-framefilter.c: Use C++ exception handling.
7383 * python/py-frame.c: Use C++ exception handling.
7384 * python/py-finishbreakpoint.c: Use C++ exception handling.
7385 * python/py-cmd.c: Use C++ exception handling.
7386 * python/py-breakpoint.c: Use C++ exception handling.
7387 * python/py-arch.c: Use C++ exception handling.
7388 * printcmd.c: Use C++ exception handling.
7389 * ppc-linux-tdep.c: Use C++ exception handling.
7390 * parse.c: Use C++ exception handling.
7391 * p-valprint.c: Use C++ exception handling.
7392 * objc-lang.c: Use C++ exception handling.
7393 * mi/mi-main.c: Use C++ exception handling.
7394 * mi/mi-interp.c: Use C++ exception handling.
7395 * mi/mi-cmd-stack.c: Use C++ exception handling.
7396 * mi/mi-cmd-break.c: Use C++ exception handling.
7397 * main.c: Use C++ exception handling.
7398 * linux-thread-db.c: Use C++ exception handling.
7399 * linux-tdep.c: Use C++ exception handling.
7400 * linux-nat.c: Use C++ exception handling.
7401 * linux-fork.c: Use C++ exception handling.
7402 * linespec.c: Use C++ exception handling.
7403 * language.c: Use C++ exception handling.
7404 * jit.c: Use C++ exception handling.
7405 * infrun.c: Use C++ exception handling.
7406 * infcmd.c: Use C++ exception handling.
7407 * infcall.c: Use C++ exception handling.
7408 * inf-loop.c: Use C++ exception handling.
7409 * i386-tdep.c: Use C++ exception handling.
7410 * i386-linux-tdep.c: Use C++ exception handling.
7411 * guile/scm-value.c: Use C++ exception handling.
7412 * guile/scm-type.c: Use C++ exception handling.
7413 * guile/scm-symtab.c: Use C++ exception handling.
7414 * guile/scm-symbol.c: Use C++ exception handling.
7415 * guile/scm-pretty-print.c: Use C++ exception handling.
7416 * guile/scm-ports.c: Use C++ exception handling.
7417 * guile/scm-param.c: Use C++ exception handling.
7418 * guile/scm-math.c: Use C++ exception handling.
7419 * guile/scm-lazy-string.c: Use C++ exception handling.
7420 * guile/scm-frame.c: Use C++ exception handling.
7421 * guile/scm-disasm.c: Use C++ exception handling.
7422 * guile/scm-cmd.c: Use C++ exception handling.
7423 * guile/scm-breakpoint.c: Use C++ exception handling.
7424 * guile/scm-block.c: Use C++ exception handling.
7425 * guile/guile-internal.h: Use C++ exception handling.
7426 * gnu-v3-abi.c: Use C++ exception handling.
7427 * gdbtypes.c: Use C++ exception handling.
7428 * frame.c: Use C++ exception handling.
7429 * frame-unwind.c: Use C++ exception handling.
7430 * fbsd-tdep.c: Use C++ exception handling.
7431 * f-valprint.c: Use C++ exception handling.
7432 * exec.c: Use C++ exception handling.
7433 * event-top.c: Use C++ exception handling.
7434 * event-loop.c: Use C++ exception handling.
7435 * eval.c: Use C++ exception handling.
7436 * dwarf2read.c: Use C++ exception handling.
7437 * dwarf2loc.c: Use C++ exception handling.
7438 * dwarf2-frame.c: Use C++ exception handling.
7439 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7440 * dwarf-index-write.c: Use C++ exception handling.
7441 * dwarf-index-cache.c: Use C++ exception handling.
7442 * dtrace-probe.c: Use C++ exception handling.
7443 * disasm-selftests.c: Use C++ exception handling.
7444 * darwin-nat.c: Use C++ exception handling.
7445 * cp-valprint.c: Use C++ exception handling.
7446 * cp-support.c: Use C++ exception handling.
7447 * cp-abi.c: Use C++ exception handling.
7448 * corelow.c: Use C++ exception handling.
7449 * completer.c: Use C++ exception handling.
7450 * compile/compile-object-run.c: Use C++ exception handling.
7451 * compile/compile-object-load.c: Use C++ exception handling.
7452 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7453 * compile/compile-c-symbols.c: Use C++ exception handling.
7454 * common/selftest.c: Use C++ exception handling.
7455 * common/new-op.c: Use C++ exception handling.
7456 * cli/cli-script.c: Use C++ exception handling.
7457 * cli/cli-interp.c: Use C++ exception handling.
7458 * cli/cli-cmds.c: Use C++ exception handling.
7459 * c-varobj.c: Use C++ exception handling.
7460 * btrace.c: Use C++ exception handling.
7461 * breakpoint.c: Use C++ exception handling.
7462 * break-catch-throw.c: Use C++ exception handling.
7463 * arch-utils.c: Use C++ exception handling.
7464 * amd64-tdep.c: Use C++ exception handling.
7465 * ada-valprint.c: Use C++ exception handling.
7466 * ada-typeprint.c: Use C++ exception handling.
7467 * ada-lang.c: Use C++ exception handling.
7468 * aarch64-tdep.c: Use C++ exception handling.
7469
3d6e9d23
TT
74702019-04-08 Tom Tromey <tom@tromey.com>
7471
7472 * xml-support.c (gdb_xml_parser::parse): Update.
7473 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7474 * value.c (show_convenience): Update.
7475 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7476 (test_parse_flags_qcs): Update.
7477 * thread.c (thr_try_catch_cmd): Update.
7478 * target.c (target_translate_tls_address): Update.
7479 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7480 (info_frame_command_core, frame_apply_command_count): Update.
7481 * rust-exp.y (rust_lex_exception_test): Update.
7482 * riscv-tdep.c (riscv_print_one_register_info): Update.
7483 * remote.c (remote_target::enable_btrace): Update.
7484 * record-btrace.c (record_btrace_enable_warn): Update.
7485 * python/py-utils.c (gdbpy_convert_exception): Update.
7486 * printcmd.c (do_one_display, print_variable_and_value): Update.
7487 * mi/mi-main.c (mi_print_exception): Update.
7488 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7489 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7490 * linux-nat.c (linux_nat_target::attach): Update.
7491 * linux-fork.c (class scoped_switch_fork_info): Update.
7492 * infrun.c (displaced_step_prepare): Update.
7493 * infcall.c (call_function_by_hand_dummy): Update.
7494 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7495 * gnu-v3-abi.c (print_one_vtable): Update.
7496 * frame.c (get_prev_frame_always): Update.
7497 * f-valprint.c (info_common_command_for_block): Update.
7498 * exec.c (try_open_exec_file): Update.
7499 * exceptions.c (print_exception, exception_print)
7500 (exception_fprintf, exception_print_same): Update.
7501 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7502 * dwarf-index-cache.c (index_cache::store)
7503 (index_cache::lookup_gdb_index): Update.
7504 * darwin-nat.c (maybe_cache_shell): Update.
7505 * cp-valprint.c (cp_print_value_fields): Update.
7506 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7507 (gcc_cplus_symbol_address): Update.
7508 * compile/compile-c-symbols.c (gcc_convert_symbol)
7509 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7510 * common/selftest.c: Update.
7511 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7512 a std::string.
7513 (exception_try_scope_entry, exception_try_scope_exit): Don't
7514 declare.
7515 (struct exception_try_scope): Remove.
7516 (TRY): Don't use exception_try_scope.
7517 (struct gdb_exception): Add constructor, operator=.
7518 <what>: New method.
7519 (struct gdb_exception_RETURN_MASK_ALL)
7520 (struct gdb_exception_RETURN_MASK_ERROR)
7521 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7522 (struct gdb_quit_bad_alloc): Update.
7523 * common/common-exceptions.c (exception_none): Change
7524 initializer.
7525 (struct catcher) <state, exception>: Initialize inline.
7526 <prev>: Remove member.
7527 (current_catcher): Remove.
7528 (catchers): New global.
7529 (exceptions_state_mc_init): Simplify.
7530 (catcher_pop): Remove.
7531 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7532 (try_scope_depth, exception_try_scope_entry)
7533 (exception_try_scope_exit): Remove.
7534 (throw_exception_sjlj): Update.
7535 (exception_messages, exception_messages_size): Remove.
7536 (throw_it): Simplify.
7537 (gdb_exception_sliced_copy): Remove.
7538 (throw_exception_cxx): Update.
7539 * cli/cli-script.c (script_from_file): Update.
7540 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7541 Update.
7542 * ada-valprint.c (ada_val_print): Update.
7543 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7544 (create_excep_cond_exprs): Update.
7545
c5c10118
TT
75462019-04-08 Tom Tromey <tom@tromey.com>
7547
7548 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7549 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7550 (TRY, CATCH, END_CATCH): Remove some definitions.
7551 * common/common-exceptions.c: Don't use GDB_XCPT.
7552 (catcher_list_size): Remove.
7553 (throw_exception, throw_it): Simplify.
7554
4de283e4
TT
75552019-04-05 Tom Tromey <tom@tromey.com>
7556
7557 Revert the header-sorting patch.
7558 * ft32-tdep.c: Revert.
7559 * frv-tdep.c: Revert.
7560 * frv-linux-tdep.c: Revert.
7561 * frame.c: Revert.
7562 * frame-unwind.c: Revert.
7563 * frame-base.c: Revert.
7564 * fork-child.c: Revert.
7565 * findvar.c: Revert.
7566 * findcmd.c: Revert.
7567 * filesystem.c: Revert.
7568 * filename-seen-cache.h: Revert.
7569 * filename-seen-cache.c: Revert.
7570 * fbsd-tdep.c: Revert.
7571 * fbsd-nat.h: Revert.
7572 * fbsd-nat.c: Revert.
7573 * f-valprint.c: Revert.
7574 * f-typeprint.c: Revert.
7575 * f-lang.c: Revert.
7576 * extension.h: Revert.
7577 * extension.c: Revert.
7578 * extension-priv.h: Revert.
7579 * expprint.c: Revert.
7580 * exec.h: Revert.
7581 * exec.c: Revert.
7582 * exceptions.c: Revert.
7583 * event-top.c: Revert.
7584 * event-loop.c: Revert.
7585 * eval.c: Revert.
7586 * elfread.c: Revert.
7587 * dwarf2read.h: Revert.
7588 * dwarf2read.c: Revert.
7589 * dwarf2loc.c: Revert.
7590 * dwarf2expr.h: Revert.
7591 * dwarf2expr.c: Revert.
7592 * dwarf2-frame.c: Revert.
7593 * dwarf2-frame-tailcall.c: Revert.
7594 * dwarf-index-write.h: Revert.
7595 * dwarf-index-write.c: Revert.
7596 * dwarf-index-common.c: Revert.
7597 * dwarf-index-cache.h: Revert.
7598 * dwarf-index-cache.c: Revert.
7599 * dummy-frame.c: Revert.
7600 * dtrace-probe.c: Revert.
7601 * disasm.h: Revert.
7602 * disasm.c: Revert.
7603 * disasm-selftests.c: Revert.
7604 * dictionary.c: Revert.
7605 * dicos-tdep.c: Revert.
7606 * demangle.c: Revert.
7607 * dcache.h: Revert.
7608 * dcache.c: Revert.
7609 * darwin-nat.h: Revert.
7610 * darwin-nat.c: Revert.
7611 * darwin-nat-info.c: Revert.
7612 * d-valprint.c: Revert.
7613 * d-namespace.c: Revert.
7614 * d-lang.c: Revert.
7615 * ctf.c: Revert.
7616 * csky-tdep.c: Revert.
7617 * csky-linux-tdep.c: Revert.
7618 * cris-tdep.c: Revert.
7619 * cris-linux-tdep.c: Revert.
7620 * cp-valprint.c: Revert.
7621 * cp-support.c: Revert.
7622 * cp-namespace.c: Revert.
7623 * cp-abi.c: Revert.
7624 * corelow.c: Revert.
7625 * corefile.c: Revert.
7626 * continuations.c: Revert.
7627 * completer.h: Revert.
7628 * completer.c: Revert.
7629 * complaints.c: Revert.
7630 * coffread.c: Revert.
7631 * coff-pe-read.c: Revert.
7632 * cli-out.h: Revert.
7633 * cli-out.c: Revert.
7634 * charset.c: Revert.
7635 * c-varobj.c: Revert.
7636 * c-valprint.c: Revert.
7637 * c-typeprint.c: Revert.
7638 * c-lang.c: Revert.
7639 * buildsym.c: Revert.
7640 * buildsym-legacy.c: Revert.
7641 * build-id.h: Revert.
7642 * build-id.c: Revert.
7643 * btrace.c: Revert.
7644 * bsd-uthread.c: Revert.
7645 * breakpoint.h: Revert.
7646 * breakpoint.c: Revert.
7647 * break-catch-throw.c: Revert.
7648 * break-catch-syscall.c: Revert.
7649 * break-catch-sig.c: Revert.
7650 * blockframe.c: Revert.
7651 * block.c: Revert.
7652 * bfin-tdep.c: Revert.
7653 * bfin-linux-tdep.c: Revert.
7654 * bfd-target.c: Revert.
7655 * bcache.c: Revert.
7656 * ax-general.c: Revert.
7657 * ax-gdb.h: Revert.
7658 * ax-gdb.c: Revert.
7659 * avr-tdep.c: Revert.
7660 * auxv.c: Revert.
7661 * auto-load.c: Revert.
7662 * arm-wince-tdep.c: Revert.
7663 * arm-tdep.c: Revert.
7664 * arm-symbian-tdep.c: Revert.
7665 * arm-pikeos-tdep.c: Revert.
7666 * arm-obsd-tdep.c: Revert.
7667 * arm-nbsd-tdep.c: Revert.
7668 * arm-nbsd-nat.c: Revert.
7669 * arm-linux-tdep.c: Revert.
7670 * arm-linux-nat.c: Revert.
7671 * arm-fbsd-tdep.c: Revert.
7672 * arm-fbsd-nat.c: Revert.
7673 * arm-bsd-tdep.c: Revert.
7674 * arch-utils.c: Revert.
7675 * arc-tdep.c: Revert.
7676 * arc-newlib-tdep.c: Revert.
7677 * annotate.h: Revert.
7678 * annotate.c: Revert.
7679 * amd64-windows-tdep.c: Revert.
7680 * amd64-windows-nat.c: Revert.
7681 * amd64-tdep.c: Revert.
7682 * amd64-sol2-tdep.c: Revert.
7683 * amd64-obsd-tdep.c: Revert.
7684 * amd64-obsd-nat.c: Revert.
7685 * amd64-nbsd-tdep.c: Revert.
7686 * amd64-nbsd-nat.c: Revert.
7687 * amd64-nat.c: Revert.
7688 * amd64-linux-tdep.c: Revert.
7689 * amd64-linux-nat.c: Revert.
7690 * amd64-fbsd-tdep.c: Revert.
7691 * amd64-fbsd-nat.c: Revert.
7692 * amd64-dicos-tdep.c: Revert.
7693 * amd64-darwin-tdep.c: Revert.
7694 * amd64-bsd-nat.c: Revert.
7695 * alpha-tdep.c: Revert.
7696 * alpha-obsd-tdep.c: Revert.
7697 * alpha-nbsd-tdep.c: Revert.
7698 * alpha-mdebug-tdep.c: Revert.
7699 * alpha-linux-tdep.c: Revert.
7700 * alpha-linux-nat.c: Revert.
7701 * alpha-bsd-tdep.c: Revert.
7702 * alpha-bsd-nat.c: Revert.
7703 * aix-thread.c: Revert.
7704 * agent.c: Revert.
7705 * addrmap.c: Revert.
7706 * ada-varobj.c: Revert.
7707 * ada-valprint.c: Revert.
7708 * ada-typeprint.c: Revert.
7709 * ada-tasks.c: Revert.
7710 * ada-lang.c: Revert.
7711 * aarch64-tdep.c: Revert.
7712 * aarch64-ravenscar-thread.c: Revert.
7713 * aarch64-newlib-tdep.c: Revert.
7714 * aarch64-linux-tdep.c: Revert.
7715 * aarch64-linux-nat.c: Revert.
7716 * aarch64-fbsd-tdep.c: Revert.
7717 * aarch64-fbsd-nat.c: Revert.
7718 * aarch32-linux-nat.c: Revert.
7719
d55e5aa6
TT
77202019-04-05 Tom Tromey <tom@tromey.com>
7721
7722 * ft32-tdep.c: Sort headers.
7723 * frv-tdep.c: Sort headers.
7724 * frv-linux-tdep.c: Sort headers.
7725 * frame.c: Sort headers.
7726 * frame-unwind.c: Sort headers.
7727 * frame-base.c: Sort headers.
7728 * fork-child.c: Sort headers.
7729 * findvar.c: Sort headers.
7730 * findcmd.c: Sort headers.
7731 * filesystem.c: Sort headers.
7732 * filename-seen-cache.h: Sort headers.
7733 * filename-seen-cache.c: Sort headers.
7734 * fbsd-tdep.c: Sort headers.
7735 * fbsd-nat.h: Sort headers.
7736 * fbsd-nat.c: Sort headers.
7737 * f-valprint.c: Sort headers.
7738 * f-typeprint.c: Sort headers.
7739 * f-lang.c: Sort headers.
7740 * extension.h: Sort headers.
7741 * extension.c: Sort headers.
7742 * extension-priv.h: Sort headers.
7743 * expprint.c: Sort headers.
7744 * exec.h: Sort headers.
7745 * exec.c: Sort headers.
7746 * exceptions.c: Sort headers.
7747 * event-top.c: Sort headers.
7748 * event-loop.c: Sort headers.
7749 * eval.c: Sort headers.
7750 * elfread.c: Sort headers.
7751 * dwarf2read.h: Sort headers.
7752 * dwarf2read.c: Sort headers.
7753 * dwarf2loc.c: Sort headers.
7754 * dwarf2expr.h: Sort headers.
7755 * dwarf2expr.c: Sort headers.
7756 * dwarf2-frame.c: Sort headers.
7757 * dwarf2-frame-tailcall.c: Sort headers.
7758 * dwarf-index-write.h: Sort headers.
7759 * dwarf-index-write.c: Sort headers.
7760 * dwarf-index-common.c: Sort headers.
7761 * dwarf-index-cache.h: Sort headers.
7762 * dwarf-index-cache.c: Sort headers.
7763 * dummy-frame.c: Sort headers.
7764 * dtrace-probe.c: Sort headers.
7765 * disasm.h: Sort headers.
7766 * disasm.c: Sort headers.
7767 * disasm-selftests.c: Sort headers.
7768 * dictionary.c: Sort headers.
7769 * dicos-tdep.c: Sort headers.
7770 * demangle.c: Sort headers.
7771 * dcache.h: Sort headers.
7772 * dcache.c: Sort headers.
7773 * darwin-nat.h: Sort headers.
7774 * darwin-nat.c: Sort headers.
7775 * darwin-nat-info.c: Sort headers.
7776 * d-valprint.c: Sort headers.
7777 * d-namespace.c: Sort headers.
7778 * d-lang.c: Sort headers.
7779 * ctf.c: Sort headers.
7780 * csky-tdep.c: Sort headers.
7781 * csky-linux-tdep.c: Sort headers.
7782 * cris-tdep.c: Sort headers.
7783 * cris-linux-tdep.c: Sort headers.
7784 * cp-valprint.c: Sort headers.
7785 * cp-support.c: Sort headers.
7786 * cp-namespace.c: Sort headers.
7787 * cp-abi.c: Sort headers.
7788 * corelow.c: Sort headers.
7789 * corefile.c: Sort headers.
7790 * continuations.c: Sort headers.
7791 * completer.h: Sort headers.
7792 * completer.c: Sort headers.
7793 * complaints.c: Sort headers.
7794 * coffread.c: Sort headers.
7795 * coff-pe-read.c: Sort headers.
7796 * cli-out.h: Sort headers.
7797 * cli-out.c: Sort headers.
7798 * charset.c: Sort headers.
7799 * c-varobj.c: Sort headers.
7800 * c-valprint.c: Sort headers.
7801 * c-typeprint.c: Sort headers.
7802 * c-lang.c: Sort headers.
7803 * buildsym.c: Sort headers.
7804 * buildsym-legacy.c: Sort headers.
7805 * build-id.h: Sort headers.
7806 * build-id.c: Sort headers.
7807 * btrace.c: Sort headers.
7808 * bsd-uthread.c: Sort headers.
7809 * breakpoint.h: Sort headers.
7810 * breakpoint.c: Sort headers.
7811 * break-catch-throw.c: Sort headers.
7812 * break-catch-syscall.c: Sort headers.
7813 * break-catch-sig.c: Sort headers.
7814 * blockframe.c: Sort headers.
7815 * block.c: Sort headers.
7816 * bfin-tdep.c: Sort headers.
7817 * bfin-linux-tdep.c: Sort headers.
7818 * bfd-target.c: Sort headers.
7819 * bcache.c: Sort headers.
7820 * ax-general.c: Sort headers.
7821 * ax-gdb.h: Sort headers.
7822 * ax-gdb.c: Sort headers.
7823 * avr-tdep.c: Sort headers.
7824 * auxv.c: Sort headers.
7825 * auto-load.c: Sort headers.
7826 * arm-wince-tdep.c: Sort headers.
7827 * arm-tdep.c: Sort headers.
7828 * arm-symbian-tdep.c: Sort headers.
7829 * arm-pikeos-tdep.c: Sort headers.
7830 * arm-obsd-tdep.c: Sort headers.
7831 * arm-nbsd-tdep.c: Sort headers.
7832 * arm-nbsd-nat.c: Sort headers.
7833 * arm-linux-tdep.c: Sort headers.
7834 * arm-linux-nat.c: Sort headers.
7835 * arm-fbsd-tdep.c: Sort headers.
7836 * arm-fbsd-nat.c: Sort headers.
7837 * arm-bsd-tdep.c: Sort headers.
7838 * arch-utils.c: Sort headers.
7839 * arc-tdep.c: Sort headers.
7840 * arc-newlib-tdep.c: Sort headers.
7841 * annotate.h: Sort headers.
7842 * annotate.c: Sort headers.
7843 * amd64-windows-tdep.c: Sort headers.
7844 * amd64-windows-nat.c: Sort headers.
7845 * amd64-tdep.c: Sort headers.
7846 * amd64-sol2-tdep.c: Sort headers.
7847 * amd64-obsd-tdep.c: Sort headers.
7848 * amd64-obsd-nat.c: Sort headers.
7849 * amd64-nbsd-tdep.c: Sort headers.
7850 * amd64-nbsd-nat.c: Sort headers.
7851 * amd64-nat.c: Sort headers.
7852 * amd64-linux-tdep.c: Sort headers.
7853 * amd64-linux-nat.c: Sort headers.
7854 * amd64-fbsd-tdep.c: Sort headers.
7855 * amd64-fbsd-nat.c: Sort headers.
7856 * amd64-dicos-tdep.c: Sort headers.
7857 * amd64-darwin-tdep.c: Sort headers.
7858 * amd64-bsd-nat.c: Sort headers.
7859 * alpha-tdep.c: Sort headers.
7860 * alpha-obsd-tdep.c: Sort headers.
7861 * alpha-nbsd-tdep.c: Sort headers.
7862 * alpha-mdebug-tdep.c: Sort headers.
7863 * alpha-linux-tdep.c: Sort headers.
7864 * alpha-linux-nat.c: Sort headers.
7865 * alpha-bsd-tdep.c: Sort headers.
7866 * alpha-bsd-nat.c: Sort headers.
7867 * aix-thread.c: Sort headers.
7868 * agent.c: Sort headers.
7869 * addrmap.c: Sort headers.
7870 * ada-varobj.c: Sort headers.
7871 * ada-valprint.c: Sort headers.
7872 * ada-typeprint.c: Sort headers.
7873 * ada-tasks.c: Sort headers.
7874 * ada-lang.c: Sort headers.
7875 * aarch64-tdep.c: Sort headers.
7876 * aarch64-ravenscar-thread.c: Sort headers.
7877 * aarch64-newlib-tdep.c: Sort headers.
7878 * aarch64-linux-tdep.c: Sort headers.
7879 * aarch64-linux-nat.c: Sort headers.
7880 * aarch64-fbsd-tdep.c: Sort headers.
7881 * aarch64-fbsd-nat.c: Sort headers.
7882 * aarch32-linux-nat.c: Sort headers.
7883
699bd4cf
TT
78842019-04-04 Tom Tromey <tom@tromey.com>
7885
7886 * varobj.c (varobj_create): Update.
7887 * rust-exp.y (struct rust_parser) <update_innermost_block,
7888 lookup_symbol>: New methods.
7889 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7890 Rename.
7891 (rust_parser::rust_lookup_type)
7892 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7893 * printcmd.c (display_command, do_one_display): Update.
7894 * parser-defs.h (struct parser_state) <parser_state>: Add
7895 "tracker" parameter.
7896 (block_tracker): New member.
7897 (class innermost_block_tracker) <innermost_block_tracker>: Add
7898 "types" parameter.
7899 <reset>: Remove method.
7900 (innermost_block): Don't declare.
7901 (null_post_parser): Update.
7902 * parse.c (innermost_block): Remove global.
7903 (write_dollar_variable): Update.
7904 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7905 Remove "tracker_types" parameter.
7906 (parse_expression): Add "tracker" parameter.
7907 (parse_expression_for_completion): Update.
7908 (null_post_parser): Add "tracker" parameter.
7909 * p-exp.y: Update rules.
7910 * m2-exp.y: Update rules.
7911 * language.h (struct language_defn) <la_post_parser>: Add
7912 "tracker" parameter.
7913 * go-exp.y: Update rules.
7914 * f-exp.y: Update rules.
7915 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7916 parameter.
7917 * d-exp.y: Update rules.
7918 * c-exp.y: Update rules.
7919 * breakpoint.c (set_breakpoint_condition): Create an
7920 innermost_block_tracker.
7921 (watch_command_1): Likewise.
7922 * ada-lang.c (resolve): Add "tracker" parameter.
7923 (resolve_subexp): Likewise.
7924 * ada-exp.y (write_var_from_sym): Update.
7925
dac43e32
TT
79262019-04-04 Tom Tromey <tom@tromey.com>
7927
7928 * type-stack.h: New file.
7929 * type-stack.c: New file.
7930 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7931 type-stack.h.
7932 (insert_into_type_stack, insert_type, push_type, push_type_int)
7933 (insert_type_address_space, pop_type, pop_type_int)
7934 (pop_typelist, pop_type_stack, append_type_stack)
7935 (push_type_stack, get_type_stack, push_typelist)
7936 (follow_type_instance_flags, follow_types): Don't declare.
7937 * parse.c (type_stack): Remove global.
7938 (parse_exp_in_context): Update.
7939 (insert_into_type_stack, insert_type, push_type, push_type_int)
7940 (insert_type_address_space, pop_type, pop_type_int)
7941 (pop_typelist, pop_type_stack, append_type_stack)
7942 (push_type_stack, get_type_stack, push_typelist)
7943 (follow_type_instance_flags, follow_types): Remove (moved to
7944 type-stack.c).
7945 * f-exp.y (type_stack): New global.
7946 Update rules.
7947 (push_kind_type, f_parse): Update.
7948 * d-exp.y (type_stack): New global.
7949 Update rules.
7950 (d_parse): Update.
7951 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7952 Update rules.
7953 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7954 (HFILES_NO_SRCDIR): Add type-stack.h.
7955
2a612529
TT
79562019-04-04 Tom Tromey <tom@tromey.com>
7957
7958 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7959 (rust_parser::convert_ast_to_expression, rust_parse)
7960 (rust_lex_test_completion, rust_lex_tests): Update.
7961 * parser-defs.h (struct expr_completion_state): New.
7962 (struct parser_state) <parser_state>: Add completion parameter.
7963 <mark_struct_expression, mark_completion_tag>: New methods.
7964 <parse_completion, m_completion_state>: New members.
7965 (prefixify_expression, null_post_parser): Update.
7966 (mark_struct_expression, mark_completion_tag): Don't declare.
7967 * parse.c (parse_completion, expout_last_struct)
7968 (expout_tag_completion_type, expout_completion_name): Remove
7969 globals.
7970 (parser_state::mark_struct_expression)
7971 (parser_state::mark_completion_tag): Now methods.
7972 (prefixify_expression): Add last_struct parameter.
7973 (prefixify_subexp): Likewise.
7974 (parse_exp_1): Update.
7975 (parse_exp_in_context): Add cstate parameter. Update.
7976 (parse_expression_for_completion): Create an
7977 expr_completion_state.
7978 (null_post_parser): Add "completion" parameter.
7979 * p-exp.y: Update rules.
7980 (yylex): Update.
7981 * language.h (struct language_defn) <la_post_parser>: Add
7982 "completing" parameter.
7983 * go-exp.y: Update rules.
7984 (lex_one_token): Update.
7985 * expression.h (parse_completion): Don't declare.
7986 * d-exp.y: Update rules.
7987 (lex_one_token): Update rules.
7988 * c-exp.y: Update rules.
7989 (lex_one_token): Update.
7990 * ada-lang.c (resolve): Add "parse_completion" parameter.
7991 (resolve_subexp): Likewise.
7992 (ada_resolve_function): Likewise.
7993
43476f0b
TT
79942019-04-04 Tom Tromey <tom@tromey.com>
7995
7996 * parser-defs.h (struct parser_state) <start_arglist,
7997 end_arglist>: New methods.
7998 <arglist_len, m_funcall_chain>: New members.
7999 (arglist_len, start_arglist, end_arglist): Don't declare.
8000 * parse.c (arglist_len, funcall_chain): Remove global.
8001 (start_arglist, end_arglist): Remove functions.
8002 (parse_exp_in_context): Update.
8003 * p-exp.y: Update rules.
8004 * m2-exp.y: Update rules.
8005 * go-exp.y: Update rules.
8006 * f-exp.y: Update rules.
8007 * d-exp.y: Update rules.
8008 * c-exp.y: Update rules.
8009
5776fca3
TT
80102019-04-04 Tom Tromey <tom@tromey.com>
8011
8012 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8013 lex_operator, push_back>: New methods.
8014 Update all rules.
8015 (rust_parser::lex_hex, lex_escape): Rename and update.
8016 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8017 (rust_parser::lex_operator): Rename and update.
8018 (rust_parser::lex_number, rustyylex, rustyyerror)
8019 (rust_lex_test_init, rust_lex_test_sequence)
8020 (rust_lex_test_push_back, rust_lex_tests): Update.
8021 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8022 parameter.
8023 <lexptr, prev_lexptr>: New members.
8024 (lexptr, prev_lexptr): Don't declare.
8025 * parse.c (lexptr, prev_lexptr): Remove globals.
8026 (parse_exp_in_context): Update.
8027 * p-exp.y (yylex, yyerror): Update.
8028 * m2-exp.y (parse_number, yylex, yyerror): Update.
8029 * go-exp.y (lex_one_token, yyerror): Update.
8030 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8031 * d-exp.y (lex_one_token, yyerror): Update.
8032 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8033 (lex_one_token, yyerror): Update.
8034 * ada-lex.l (YY_INPUT): Update.
8035 (rewind_to_char): Update.
8036 * ada-exp.y (yyerror): Update.
8037
8621b685
TT
80382019-04-04 Tom Tromey <tom@tromey.com>
8039
8040 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8041 * parser-defs.h (struct parser_state) <parser_state>: Add new
8042 parameter.
8043 <comma_terminates>: New member.
8044 (comma_terminates): Don't declare global.
8045 * parse.c (comma_terminates): Remove global.
8046 (parse_exp_in_context): Update.
8047 * p-exp.y (yylex): Update.
8048 * m2-exp.y (yylex): Update.
8049 * go-exp.y (lex_one_token): Update.
8050 * f-exp.y (yylex): Update.
8051 * d-exp.y (lex_one_token): Update.
8052 * c-exp.y (lex_one_token): Update.
8053 * ada-lex.l: Update.
8054
28aaf3fd
TT
80552019-04-04 Tom Tromey <tom@tromey.com>
8056
8057 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8058 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8059 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8060 * parser-defs.h (paren_depth): Don't declare.
8061 * parse.c (paren_depth): Remove global.
8062 (parse_exp_in_context): Update.
8063 * p-exp.y (paren_depth): New global.
8064 (pascal_parse): Initialize it.
8065 * m2-exp.y (paren_depth): New global.
8066 (m2_parse): Initialize it.
8067 * go-exp.y (paren_depth): New global.
8068 (go_parse): Initialize it.
8069 * f-exp.y (paren_depth): New global.
8070 (f_parse): Initialize it.
8071 * d-exp.y (paren_depth): New global.
8072 (d_parse): Initialize it.
8073 * c-exp.y (paren_depth): New global.
8074 (c_parse): Initialize it.
8075 * ada-lex.l (paren_depth): New global.
8076 (lexer_init): Initialize it.
8077
1e58a4a4
TT
80782019-04-04 Tom Tromey <tom@tromey.com>
8079
8080 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8081 (rust_parser::convert_ast_to_type)
8082 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8083 * parser-defs.h (struct parser_state) <parser_state>: Add
8084 parameters. Initialize new members.
8085 <expression_context_block, expression_context_pc>: New members.
8086 * parse.c (expression_context_block, expression_context_pc):
8087 Remove globals.
8088 (parse_exp_in_context): Update.
8089 * p-exp.y: Update all rules.
8090 (yylex): Update.
8091 * m2-exp.y: Update all rules.
8092 (yylex): Update.
8093 * go-exp.y (yylex): Update.
8094 * f-exp.y (yylex): Update.
8095 * d-exp.y: Update all rules.
8096 (yylex): Update.
8097 * c-exp.y: Update all rules.
8098 (lex_one_token, classify_name, yylex, c_parse): Update.
8099 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8100
37eedb39
TT
81012019-04-04 Tom Tromey <tom@tromey.com>
8102
8103 * gdbarch.h, gdbarch.c: Rebuild.
8104 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8105 * stap-probe.h:
8106 (struct stap_parse_info): Replace "parser_state" with
8107 "expr_builder".
8108 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8109 (parser_state): New class.
8110 * parse.c (expr_builder): Rename.
8111 (expr_builder::release): Rename.
8112 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8113 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8114 (write_exp_elt_longcst, write_exp_elt_floatcst)
8115 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8116 (write_exp_string_vector, write_exp_bitstring)
8117 (write_exp_msymbol, mark_struct_expression)
8118 (write_dollar_variable)
8119 (insert_type_address_space, increase_expout_size): Replace
8120 "parser_state" with "expr_builder".
8121 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8122 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8123 "parser_state" with "expr_builder".
8124
73923d7e
TT
81252019-04-04 Tom Tromey <tom@tromey.com>
8126
8127 * rust-exp.y: Replace "parse_language" with method call.
8128 * p-exp.y:
8129 (yylex): Replace "parse_language" with method call.
8130 * m2-exp.y:
8131 (yylex): Replace "parse_language" with method call.
8132 * go-exp.y (classify_name): Replace "parse_language" with method
8133 call.
8134 * f-exp.y (yylex): Replace "parse_language" with method call.
8135 * d-exp.y (lex_one_token): Replace "parse_language" with method
8136 call.
8137 * c-exp.y:
8138 (lex_one_token, classify_name, yylex): Replace "parse_language"
8139 with method call.
8140 * ada-exp.y (find_primitive_type, type_char)
8141 (type_system_address): Replace "parse_language" with method call.
8142
fa9f5be6
TT
81432019-04-04 Tom Tromey <tom@tromey.com>
8144
8145 * rust-exp.y: Replace "parse_gdbarch" with method call.
8146 * parse.c (write_dollar_variable, insert_type_address_space):
8147 Replace "parse_gdbarch" with method call.
8148 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8149 call.
8150 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8151 call.
8152 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8153 "parse_gdbarch" with method call.
8154 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8155 with method call.
8156 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8157 "parse_gdbarch" with method call.
8158 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8159 "parse_gdbarch" with method call.
8160 * c-exp.y (parse_type, parse_number, classify_name): Replace
8161 "parse_gdbarch" with method call.
8162 * ada-lex.l: Replace "parse_gdbarch" with method call.
8163 * ada-exp.y (parse_type, find_primitive_type, type_char)
8164 (type_system_address): Replace "parse_gdbarch" with method call.
8165
1201a264
TT
81662019-04-04 Tom Tromey <tom@tromey.com>
8167
8168 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8169 * stap-probe.c (stap_parse_argument): Update.
8170 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8171 initial_size parameter.
8172 * rust-exp.y (rust_lex_tests): Update.
8173 * parse.c (parser_state): Update.
8174 (parse_exp_in_context): Update.
8175 * parser-defs.h (struct parser_state) <parser_state>: Remove
8176 "initial_size" parameter.
8177
e3980ce2
TT
81782019-04-04 Tom Tromey <tom@tromey.com>
8179
8180 * parser-defs.h (increase_expout_size): Don't declare.
8181 * parse.c (increase_expout_size): Now static.
8182
e9f8e3f1
TS
81832019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8184
8185 * gnu-nat.c (gnu_nat_target::wait): Fix
8186 target_waitstatus_to_string call.
8187
d7df6549
AB
81882019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8189
8190 * eval.c (evaluate_subexp_standard): Handle internal functions
8191 during Fortran function call handling.
8192
8bdc1658
AB
81932019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8194
8195 * NEWS: Mention new internal functions.
8196 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8197 (read_base_type): Use dwarf2_init_complex_target_type.
8198 * value.c (creal_internal_fn): New function.
8199 (cimag_internal_fn): New function.
8200 (_initialize_values): Register new internal functions.
8201
c29705b7
PW
82022019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8203
8204 * infrun.c (stop_all_threads): If debug_infrun, always
8205 trace the wait status after wait_one, using
8206 target_waitstatus_to_string and target_pid_to_str.
8207 (handle_inferior_event): Replace various trace of
8208 wait status kind by a single trace.
8209 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8210 wait status kind image by target_waitstatus_to_string.
8211 * target/waitstatus.c (target_waitstatus_to_string): Fix
8212 obsolete comment.
8213
05caa1d2
TT
82142019-04-01 Tom Tromey <tromey@adacore.com>
8215
8216 PR symtab/23331:
8217 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8218
9d1447e0
SDJ
82192019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8220 Pedro Alves <palves@redhat.com>
8221
8222 * top.c (quit_force): Call 'finalize_values'.
8223 * value.c (finalize_values): New function.
8224 * value.h (finalize_values): Declare.
8225
7734102d
EZ
82262019-03-30 Eli Zaretskii <eliz@gnu.org>
8227
8228 * NEWS: Announce $_gdb_major and $_gdb_minor.
8229
8230 * top.c (init_gdb_version_vars): New function.
8231 (gdb_init): Call init_gdb_version_vars.
8232
188e1fa9
TT
82332019-03-29 Tom Tromey <tromey@adacore.com>
8234
8235 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8236 help text. Remove dead code.
8237
2880242d
KS
82382019-03-29 Keith Seitz <keiths@redhat.com>
8239
8240 From Siddhesh Poyarekar:
8241 * f-lang.h (f77_get_upperbound): Return LONGEST.
8242 (f77_get_lowerbound): Likewise.
8243 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8244 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8245 print them.
8246 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8247 plongest to format print it.
8248 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8249 (f77_get_upperbound): Likewise.
8250 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8251 LOWER_BOUND to LONGEST.
8252 (f77_create_arrayprint_offset_tbl): Likewise.
8253
cc1defb1
KS
82542019-03-29 Keith Seitz <keiths@redhat.com>
8255
8256 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8257 %s/pulongest for TYPE_LENGTH instead of %d in format
8258 strings.
8259 * ada-typerint.c (ada_print_type): Likewise.
8260 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8261 * compile/compile-c-support.c (generate_register_struct): Likewise.
8262 * gdbtypes.c (recursive_dump_type): Likewise.
8263 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8264 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8265 instead of %d in format strings.
8266 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8267 to std::min to ULONGEST.
8268 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8269 instead of %d in format strings.
8270 * tracepoint.c (info_scope_command): Likewise.
8271 * typeprint.c (print_offset_data::update)
8272 (print_offset_data::finish): Likewise.
8273 * xtensa-tdep.c (xtensa_store_return_value)
8274 (xtensa_push_dummy_call): Likewise.
8275
e432ccf1
JT
82762019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8277
8278 * windows-nat.c (display_selector): Fixed format specifications
8279 for 64-bit Cygwin.
8280
65d2b333
PW
82812019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8282
8283 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8284
f489207e
SL
82852019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8286
8287 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8288 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8289 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8290 (nios2_linux_init_abi): Install it.
8291
bffa1015
AH
82922019-03-28 Alan Hayward <alan.hayward@arm.com>
8293
8294 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8295
fc96163a
AH
82962019-03-28 Alan Hayward <alan.hayward@arm.com>
8297
8298 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8299
20dc7e9b
PW
83002019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8301 Tom Tromey <tromey@adacore.com>
8302
8303 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8304
7f5331a8
JB
83052019-03-26 Joel Brobecker <brobecker@adacore.com>
8306
8307 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8308 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8309 method to compute the bounds of range types. Also print "[evaluated]"
8310 if the bounds' values come from a dynamic evaluation.
8311
18c77628
AB
83122019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8313
8314 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8315 whitespace when pretty printing is on.
8316
53c973f2
AH
83172019-03-26 Alan Hayward <alan.hayward@arm.com>
8318
e79be6e5 8319 * ppc-linux-nat.c: Add include.
53c973f2 8320
d851aa71
AH
83212019-03-26 Alan Hayward <alan.hayward@arm.com>
8322
e79be6e5 8323 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8324
2fe7bab7
AH
83252019-03-26 Alan Hayward <alan.hayward@arm.com>
8326
e79be6e5 8327 * arm-linux-nat.c: Add include.
2fe7bab7 8328
068ef30e
SM
83292019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8330
8331 * source-cache.c (source_cache::get_source_lines): Re-read
8332 fullname after calling open_source_file.
8333
81a24d04
JB
83342019-03-25 John Baldwin <jhb@FreeBSD.org>
8335
8336 * NEWS: Mention TLS support for FreeBSD.
8337
79e7ae11
TT
83382019-03-25 Tom Tromey <tromey@adacore.com>
8339
8340 * minsyms.c (BUNCH_SIZE): Update comment.
8341 (~minimal_symbol_reader): Remove old comment.
8342 (compact_minimal_symbols): Update comment.
8343 (minimal_symbol_reader::install): Remove old comment. Update
8344 other comments.
8345
d45963c2
AH
83462019-03-25 Alan Hayward <alan.hayward@arm.com>
8347
8348 * s390-linux-nat.c: Add include.
8349
0f83012e
AH
83502019-03-25 Alan Hayward <alan.hayward@arm.com>
8351
8352 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8353 Call linux_get_hwcap.
8354 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8355 Likewise.
8356 (aarch64_linux_get_hwcap): Remove function.
8357 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8358 declaration.
8359 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8360 linux_get_hwcap.
8361 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8362 * linux-tdep.c (linux_get_hwcap): Add function.
8363 (linux_get_hwcap2): Likewise.
8364 * linux-tdep.h (linux_get_hwcap): Add declaration.
8365 (linux_get_hwcap2): Likewise.
8366 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8367 (ppc_linux_get_hwcap2): Likewise.
8368 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8369 linux_get_hwcap.
8370 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8371 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8372 (ppc_linux_nat_target::read_description): Likewise.
8373 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8374 * s390-linux-nat.c: Likewise.
8375 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8376
6640a367
TT
83772019-03-24 Tom Tromey <tom@tromey.com>
8378
8379 * ada-lang.c (standard_lookup): Simplify initialization.
8380 (ada_lookup_symbol_nonlocal): Simplify return.
8381 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8382 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8383 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8384 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8385 initialization.
8386 * solib.c (solib_global_lookup): Simplify.
8387 * symtab.c (null_block_symbol): Remove.
8388 (symbol_cache_lookup): Simplify returns.
8389 (lookup_language_this): Simplify returns.
8390 (lookup_symbol_aux): Simplify return.
8391 (lookup_local_symbol): Simplify returns.
8392 (lookup_global_symbol_from_objfile): Simplify return.
8393 (lookup_symbol_in_objfile_symtabs)
8394 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8395 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8396 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8397 * cp-namespace.c (cp_lookup_bare_symbol)
8398 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8399 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8400 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8401 (cp_lookup_symbol_via_imports): Simplify initialization.
8402 (find_symbol_in_baseclass): Likewise.
8403 * symtab.h (null_block_symbol): Remove.
8404 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8405 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8406 (d_lookup_symbol_module): Likewise.
8407 (find_symbol_in_baseclass): Simplify initialization.
8408
a930ebcd
TT
84092019-03-24 Tom Tromey <tom@tromey.com>
8410
8411 * expression.h: Don't include symtab.h.
8412 (struct block): Forward declare.
8413
582942f4
TT
84142019-03-24 Tom Tromey <tom@tromey.com>
8415
8416 * c-exp.y (typebase): Remove casts.
8417 * gdbtypes.c (lookup_unsigned_typename, )
8418 (lookup_signed_typename): Remove cast.
8419 * eval.c (parse_to_comma_and_eval): Remove cast.
8420 * parse.c (write_dollar_variable): Remove cast.
8421 * block.h (struct block) <superblock>: Now const.
8422 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8423 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8424 (map_block): Make "block" const.
8425 * symfile.h (struct quick_symbol_functions)
8426 <map_matching_symbols>: Constify block argument to "callback".
8427 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8428 const.
8429 (find_pc_sect_compunit_symtab): Make "b" const.
8430 (find_symbol_at_address): Likewise.
8431 (search_symbols): Likewise.
8432 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8433 (dw2_debug_names_lookup_symbol): Likewise.
8434 (dw2_map_matching_symbols): Update.
8435 * p-valprint.c (pascal_val_print): Remove "block".
8436 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8437 (aux_add_nonlocal_symbols): Make "block" const.
8438 (resolve_subexp): Remove cast.
8439 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8440 const.
8441 (iterate_over_file_blocks): Likewise.
8442 * f-exp.y (%union) <bval>: Remove.
8443 * coffread.c (patch_opaque_types): Make "b" const.
8444 * spu-tdep.c (spu_catch_start): Make "block" const.
8445 * c-valprint.c (print_unpacked_pointer): Remove "block".
8446 * symmisc.c (dump_symtab_1): Make "b" const.
8447 (block_depth): Make "block" const.
8448 * d-exp.y (%union) <bval>: Remove.
8449 * cp-support.h (cp_lookup_rtti_type): Update.
8450 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8451 * psymtab.c (psym_lookup_symbol): Make "block" const.
8452 (maintenance_check_psymtabs): Make "b" const.
8453 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8454 (enumerate_locals, enumerate_args): Update.
8455 * python/py-symtab.c (stpy_global_block): Make "block" const.
8456 (stpy_static_block): Likewise.
8457 * inline-frame.c (block_starting_point_at): Make "new_block"
8458 const.
8459 * block.c (find_block_in_blockvector): Make return type const.
8460 (blockvector_for_pc_sect): Make "b" const.
8461 (find_block_in_blockvector): Make "b" const.
8462
7ad417dd
TT
84632019-03-23 Tom Tromey <tom@tromey.com>
8464
8465 * varobj.c (varobj_create): Update.
8466 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8467 * printcmd.c (display_command, do_one_display): Don't reset
8468 innermost_block.
8469 * parser-defs.h (enum innermost_block_tracker_type): Move to
8470 expression.h.
8471 (innermost_block): Update comment.
8472 * parse.c (parse_exp_1): Add tracker_types parameter.
8473 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8474 tracker_types parameter. Reset innermost_block.
8475 (parse_exp_in_context): Remove.
8476 (parse_expression_for_completion): Update.
8477 * objfiles.c (~objfile): Don't reset expression_context_block or
8478 innermost_block.
8479 * expression.h (enum innermost_block_tracker_type): Move from
8480 parser-defs.h.
8481 (parse_exp_1): Add tracker_types parameter.
8482 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8483 reset innermost_block.
8484
b366c208
TT
84852019-03-23 Tom Tromey <tom@tromey.com>
8486
8487 * objfiles.h: Include bcache.h.
8488
9bb9b2f9
TT
84892019-03-23 Tom Tromey <tom@tromey.com>
8490
8491 * linespec.c (get_current_search_block): Use
8492 scoped_restore_current_language.
8493 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8494
59c28372
AH
84952019-03-22 Alan Hayward <alan.hayward@arm.com>
8496 Jiong Wang <jiong.wang@arm.com>
8497
8498 * aarch64-linux-tdep.c
8499 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8500 section.
8501 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8502
17e116a7
AH
85032019-03-22 Alan Hayward <alan.hayward@arm.com>
8504 Jiong Wang <jiong.wang@arm.com>
8505
8506 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8507 instructions.
8508 (aarch64_analyze_prologue_test): Add PACIASP test.
8509 (aarch64_prologue_prev_register): Unmask PC value.
8510
11e1b75f
AH
85112019-03-22 Alan Hayward <alan.hayward@arm.com>
8512 Jiong Wang <jiong.wang@arm.com>
8513
8514 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8515 (aarch64_dwarf2_prev_register): Unmask PC value.
8516 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8517 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8518 DW_CFA_AARCH64_negate_ra_state.
8519 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8520
34dcc7cf
AH
85212019-03-22 Alan Hayward <alan.hayward@arm.com>
8522 Jiong Wang <jiong.wang@arm.com>
8523
8524 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8525 registers.
8526 (aarch64_pseudo_register_name): Likewise.
8527 (aarch64_pseudo_register_type): Likewise.
8528 (aarch64_pseudo_register_reggroup_p): Likewise.
8529 (aarch64_gdbarch_init): Add pauth registers.
8530 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8531 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8532 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8533 (struct gdbarch_tdep): Add regnum for ra_state.
8534
1ef53e6b
AH
85352019-03-22 Alan Hayward <alan.hayward@arm.com>
8536 Jiong Wang <jiong.wang@arm.com>
8537
8538 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8539
76bed0fd
AH
85402019-03-22 Alan Hayward <alan.hayward@arm.com>
8541 Jiong Wang <jiong.wang@arm.com>
8542
8543 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8544 function.
8545 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8546 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8547 (aarch64_gdbarch_init): Add puth registers.
8548 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8549 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8550 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8551
ee4fbcfa
AH
85522019-03-22 Alan Hayward <alan.hayward@arm.com>
8553 Jiong Wang <jiong.wang@arm.com>
8554
8555 * aarch64-linux-nat.c
8556 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8557 * aarch64-linux-tdep.c
8558 (aarch64_linux_core_read_description): Likewise.
8559 (aarch64_linux_get_hwcap): New function.
8560 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8561 (aarch64_linux_get_hwcap): New declaration.
8562
6dc0ebde
AH
85632019-03-22 Alan Hayward <alan.hayward@arm.com>
8564 Jiong Wang <jiong.wang@arm.com>
8565
8566 * aarch64-linux-nat.c
8567 (aarch64_linux_nat_target::read_description): Add pauth param.
8568 * aarch64-linux-tdep.c
8569 (aarch64_linux_core_read_description): Likewise.
8570 * aarch64-tdep.c (struct target_desc): Add in pauth.
8571 (aarch64_read_description): Add pauth param.
8572 (aarch64_gdbarch_init): Likewise.
8573 * aarch64-tdep.h (aarch64_read_description): Likewise.
8574 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8575 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8576 * features/Makefile: Add new files.
8577 * features/aarch64-pauth.c: New file.
8578 * features/aarch64-pauth.xml: New file.
8579
595915c1
TT
85802019-03-20 Tom Tromey <tromey@adacore.com>
8581
8582 * infrun.c (handle_inferior_event): Rename from
8583 handle_inferior_event_1. Create a scoped_value_mark.
8584 (handle_inferior_event): Remove.
8585
4c7d57e7
TT
85862019-03-19 Tom Tromey <tromey@adacore.com>
8587
8588 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8589 * infrun.h (print_stop_event): Add "displays" parameter.
8590 * infrun.c (print_stop_event): Add "displays" parameter.
8591
cb246234
PA
85922019-03-19 Pedro Alves <palves@redhat.com>
8593
8594 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8595 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8596 to -1. Fix TABs vs spaces.
8597 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8598 * tui/tui-out.h (tui_ui_out) Add intro comments.
8599 <m_line, m_start_of_line>: In-class initialize, and add describing
8600 comment.
8601
3a0e45b2
AH
86022019-03-18 Alan Hayward <alan.hayward@arm.com>
8603
8604 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8605 variable names.
8606 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8607
5371b850
PA
86082019-03-18 Pedro Alves <palves@redhat.com>
8609 Eli Zaretskii <eliz@gnu.org>
8610
8611 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8612 m_line and m_start_of_line.
8613
b17c4cd0
EZ
86142019-03-18 Eli Zaretskii <eliz@gnu.org>
8615
8616 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8617 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8618 it returns a newline. This fixes a regression in TU mode, whereby
8619 the next line is output on the same screen line as the user input.
8620
4bd56d18
TT
86212019-03-18 Tom Tromey <tromey@adacore.com>
8622
8623 * minsyms.c (minimal_symbol_reader::install): Remove call to
8624 obstack_blank.
8625
55c10aca
PA
86262019-03-18 Pedro Alves <palves@redhat.com>
8627
8628 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8629 New globals.
8630 (apply_style): New, factored out from ...
8631 (apply_ansi_escape): ... this. Handle reverse video mode.
8632 (tui_set_reverse_mode): New function.
8633 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8634 * tui/tui-winsource.c (tui_show_source_line): Use
8635 tui_set_reverse_mode instead of setting A_STANDOUT.
8636 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8637 New setter methods.
8638
647bb750
HD
86392019-03-18 Hannes Domani <ssbssa@yahoo.de>
8640
8641 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8642 Handle tabs.
8643
bff8c71f
TT
86442019-03-18 Tom Tromey <tromey@adacore.com>
8645
8646 * ada-lang.c (empty_array): Add "high" parameter.
8647 (ada_evaluate_subexp): Update.
8648
58785d98
ST
86492019-03-17 Sergei Trofimovich <siarheit@google.com>
8650
8651 * unittests/string_view-selftests.c: Define
8652 _initialize_string_view_selftests unconditionally.
8653
d4cbef22
ВМ
86542019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8655
8656 PR gdb/24350
8657 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8658
fce4c071
ВМ
86592019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8660
8661 PR gdb/24351
8662 * windows-nat.c (display_selector): Fix format specifiers.
8663
f7f0a123
EZ
86642019-03-17 Eli Zaretskii <eliz@gnu.org>
8665
8666 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8667 tui_refill_source_window instead of tui_refresh_win, to update the
8668 current execution line. This fixes redisplay of the current line
8669 when stepping through the code with "next" or "step".
8670
ab42892f
EZ
86712019-03-16 Eli Zaretskii <eliz@gnu.org>
8672
8673 * source-cache.c (source_cache::get_source_lines): Call
8674 find_source_lines to initialize s->nlines. This fixes vertical
8675 scrolling of TUI source window when the DOWN arrow is pressed.
8676
8d8c087f
PW
86772019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8678
8679 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8680 linux-thread-db.c (_initialize_thread_db): Likewise.
8681
798e1c30
EZ
86822019-03-16 Eli Zaretskii <eliz@gnu.org>
8683
8684 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8685 wclrtoeol in tui_show_source_line". This reverts changes made in
8686 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8687
eefba3da
TT
86882019-03-15 Tom Tromey <tom@tromey.com>
8689
8690 * symtab.h (struct minimal_symbol): Derive from
8691 general_symbol_info.
8692 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8693 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8694 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8695 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8696 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8697 (MSYMBOL_SEARCH_NAME): Update.
8698 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8699 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8700 * minsyms.c (minimal_symbol_reader::record_full): Update.
8701
0de2420c
TT
87022019-03-15 Tom Tromey <tom@tromey.com>
8703
8704 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8705
042d75e4
TT
87062019-03-15 Tom Tromey <tom@tromey.com>
8707
8708 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8709 unique_xmalloc_ptr.
8710 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8711 Update.
8712 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8713 (build_minimal_symbol_hash_tables)
8714 (minimal_symbol_reader::install): Update.
8715
db92718b
TT
87162019-03-15 Tom Tromey <tom@tromey.com>
8717
8718 * symtab.c (create_demangled_names_hash): Update.
8719 (symbol_set_names): Update.
8720 * objfiles.h (struct objfile_per_bfd_storage)
8721 <demangled_names_hash>: Now an htab_up.
8722 * objfiles.c (objfile_per_bfd_storage): Simplify.
8723
d6797f46
TT
87242019-03-15 Tom Tromey <tom@tromey.com>
8725
8726 * objfiles.h (struct objfile_per_bfd_storage): Declare
8727 destructor.
8728 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8729 New.
8730 (get_objfile_bfd_data): Use new. Don't initialize
8731 language_of_main.
8732 (free_objfile_per_bfd_storage): Remove.
8733 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8734
741d7538
TT
87352019-03-15 Tom Tromey <tom@tromey.com>
8736
8737 * symfile.c (reread_symbols): Update.
8738 * objfiles.c (objfile::objfile): Update.
8739 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8740 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8741 comment.
8742 (minimal_symbol_reader::install): Update.
8743 (terminate_minimal_symbol_table): Remove.
8744 * jit.c (jit_object_close_impl): Update.
8745
788c80d1
TT
87462019-03-15 Tom Tromey <tom@tromey.com>
8747
8748 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8749 initializations.
8750
1b7a07cb
TT
87512019-03-15 Tom Tromey <tom@tromey.com>
8752
8753 * objfiles.h (struct objfile_per_bfd_storage)
8754 <demangled_hash_languages>: Now a bitset.
8755 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8756 (lookup_minimal_symbol): Update.
8757
3db066bc
TT
87582019-03-15 Tom Tromey <tom@tromey.com>
8759
8760 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8761 Don't return the symbol.
8762 * coffread.c (record_minimal_symbol): Use record_full.
8763
3fff2c37
EZ
87642019-03-14 Eli Zaretskii <eliz@gnu.org>
8765
8766 The MS-Windows port of ncurses fails to switch to a color pair if
8767 one or both of the colors are the implicit default colors. This
8768 change records the default colors when TUI is initialized, and
8769 then specifies them explicitly when a color pair uses the default
8770 colors. This allows color styling in TUI mode on MS-Windows.
8771
8772 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8773 ncurses_norm_attr.
8774 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8775 colors in ncurses_norm_attr.
8776 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8777 "none", replace it with the default color recorded in
8778 ncurses_norm_attr.
8779
3b336828
TT
87802019-03-14 Tom Tromey <tromey@adacore.com>
8781
8782 * source-cache.h (class source_cache) <get_source_lines>: Return
8783 std::string.
8784 * source-cache.c (source_cache::extract_lines): Handle case where
8785 first_pos==npos. Return std::string.
8786 (source_cache::get_source_lines): Update.
8787
d085f989
TT
87882019-03-14 Tom Tromey <tromey@adacore.com>
8789
8790 * NEWS: Add item for "style sources" commands.
8791 * source-cache.c (source_cache::get_source_lines): Check
8792 source_styling.
8793 * cli/cli-style.c (source_styling): New global.
8794 (_initialize_cli_style): Add "style sources" commands.
8795 (show_style_sources): New function.
8796 * cli/cli-style.h (source_styling): Declare.
8797
6f11e682
TT
87982019-03-14 Pedro Alves <palves@redhat.com>
8799 Tom Tromey <tromey@adacore.com>
8800
8801 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8802 * tui/tui-winsource.c (tui_refill_source_window): New function,
8803 from...
8804 (tui_horizontal_source_scroll): ... here. Move some logic.
8805 * cli/cli-style.c (set_style_enabled): Notify new observable.
8806 * tui/tui-hooks.c (tui_redisplay_source): New function.
8807 (tui_attach_detach_observers): Attach or detach
8808 tui_redisplay_source.
8809 * observable.h (source_styling_changed): New observable.
8810 * observable.c: Define source_styling_changed observable.
8811
a068643d
TT
88122019-03-13 Tom Tromey <tromey@adacore.com>
8813
8814 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8815 (i386_gnu_nat_target::store_registers): Update.
8816 * target-debug.h (target_debug_print_std_string): New macro.
8817 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8818 * windows-tdep.c (display_one_tib): Update.
8819 * tui/tui-stack.c (tui_make_status_line): Update.
8820 * top.c (print_inferior_quit_action): Update.
8821 * thread.c (thr_try_catch_cmd): Update.
8822 (add_thread_with_info): Update.
8823 (thread_target_id_str): Update.
8824 (thr_try_catch_cmd): Update.
8825 (thread_command): Update.
8826 (thread_find_command): Update.
8827 * record-btrace.c (record_btrace_target::info_record)
8828 (record_btrace_resume_thread, record_btrace_target::resume)
8829 (record_btrace_cancel_resume, record_btrace_step_thread)
8830 (record_btrace_target::wait, record_btrace_target::wait)
8831 (record_btrace_target::wait, record_btrace_target::stop): Update.
8832 * progspace.c (print_program_space): Update.
8833 * process-stratum-target.c
8834 (process_stratum_target::thread_address_space): Update.
8835 * linux-fork.c (linux_fork_mourn_inferior)
8836 (detach_checkpoint_command, info_checkpoints_command)
8837 (linux_fork_context): Update.
8838 (linux_fork_detach): Update.
8839 (class scoped_switch_fork_info): Update.
8840 (delete_checkpoint_command): Update.
8841 * infrun.c (follow_fork_inferior): Update.
8842 (follow_fork_inferior): Update.
8843 (proceed_after_vfork_done): Update.
8844 (handle_vfork_child_exec_or_exit): Update.
8845 (follow_exec): Update.
8846 (displaced_step_prepare_throw): Update.
8847 (displaced_step_restore): Update.
8848 (start_step_over): Update.
8849 (resume_1): Update.
8850 (clear_proceed_status_thread): Update.
8851 (proceed): Update.
8852 (print_target_wait_results): Update.
8853 (do_target_wait): Update.
8854 (context_switch): Update.
8855 (stop_all_threads): Update.
8856 (restart_threads): Update.
8857 (finish_step_over): Update.
8858 (handle_signal_stop): Update.
8859 (switch_back_to_stepped_thread): Update.
8860 (keep_going_pass_signal): Update.
8861 (print_exited_reason): Update.
8862 (normal_stop): Update.
8863 * inferior.c (inferior_pid_to_str): Change return type.
8864 (print_selected_inferior): Update.
8865 (add_inferior): Update.
8866 (detach_inferior): Update.
8867 * dummy-frame.c (fprint_dummy_frames): Update.
8868 * dcache.c (dcache_info_1): Update.
8869 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8870 (btrace_fetch, btrace_clear): Update.
8871 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8872 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8873 type.
8874 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8875 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8876 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8877 * gdbarch.c, gdbarch.h: Rebuild.
8878 * gdbarch.sh (core_pid_to_str): Change return type.
8879 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8880 return type.
8881 (windows_nat_target::pid_to_str): Change return type.
8882 (windows_delete_thread): Update.
8883 (windows_nat_target::attach): Update.
8884 (windows_nat_target::files_info): Update.
8885 * target-delegates.c: Rebuild.
8886 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8887 return type.
8888 (sol_thread_target::pid_to_str): Change return type.
8889 * remote.c (class remote_target) <pid_to_str>: Change return
8890 type.
8891 (remote_target::pid_to_str): Change return type.
8892 (extended_remote_target::attach, remote_target::remote_stop_ns)
8893 (remote_target::remote_notif_remove_queued_reply)
8894 (remote_target::push_stop_reply, remote_target::disable_btrace):
8895 Update.
8896 (extended_remote_target::attach): Update.
8897 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8898 type.
8899 (gdbsim_target::pid_to_str): Change return type.
8900 * ravenscar-thread.c (struct ravenscar_thread_target)
8901 <pid_to_str>: Change return type.
8902 (ravenscar_thread_target::pid_to_str): Change return type.
8903 * procfs.c (class procfs_target) <pid_to_str>: Change return
8904 type.
8905 (procfs_target::pid_to_str): Change return type.
8906 (procfs_target::attach): Update.
8907 (procfs_target::detach): Update.
8908 (procfs_target::fetch_registers): Update.
8909 (procfs_target::store_registers): Update.
8910 (procfs_target::wait): Update.
8911 (procfs_target::files_info): Update.
8912 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8913 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8914 return type.
8915 (nto_procfs_target::pid_to_str): Change return type.
8916 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8917 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8918 return type.
8919 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8920 (exit_lwp): Update.
8921 (attach_proc_task_lwp_callback, get_detach_signal)
8922 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8923 (linux_nat_target::resume, wait_lwp, stop_callback)
8924 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8925 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8926 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8927 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8928 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8929 type.
8930 (inf_ptrace_target::attach): Update.
8931 (inf_ptrace_target::files_info): Update.
8932 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8933 type.
8934 (go32_nat_target::pid_to_str): Change return type.
8935 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8936 (gnu_nat_target::wait): Update.
8937 (gnu_nat_target::wait): Update.
8938 (gnu_nat_target::resume): Update.
8939 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8940 (fbsd_nat_target::wait): Update.
8941 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8942 type.
8943 (darwin_nat_target::attach): Update.
8944 * corelow.c (class core_target) <pid_to_str>: Change return type.
8945 (core_target::pid_to_str): Change return type.
8946 * target.c (normal_pid_to_str): Change return type.
8947 (default_pid_to_str): Likewise.
8948 (target_pid_to_str): Change return type.
8949 (target_translate_tls_address): Update.
8950 (target_announce_detach): Update.
8951 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8952 return type.
8953 (bsd_uthread_target::pid_to_str): Change return type.
8954 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8955 type.
8956 (bsd_kvm_target::pid_to_str): Change return type.
8957 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8958 return type.
8959 (aix_thread_target::pid_to_str): Change return type.
8960 * target.h (struct target_ops) <pid_to_str>: Change return type.
8961 (target_pid_to_str, normal_pid_to_str): Likewise.
8962 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8963 type.
8964 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8965 type.
8966 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8967 return type.
8968 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8969 type.
8970 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8971 type.
8972 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8973 return type.
8974
b4be1b06
SM
89752019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8976
8977 * NEWS: Mention that the new default MI version is 3. Mention
8978 changes to the output of commands and events that deal with
8979 multi-location breakpoints.
8980 * breakpoint.c: Include "mi/mi-out.h".
8981 (print_one_breakpoint): Change output syntax if using MI version
8982 >= 3.
8983 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8984 New.
8985 (mi_multi_location_breakpoint_output_fixed): New.
8986 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8987 (mi_cmd_fix_multi_location_breakpoint_output): New.
8988 (mi_multi_location_breakpoint_output_fixed): New.
8989 * mi/mi-cmds.c (mi_cmds): Register command
8990 -fix-multi-location-breakpoint-output.
8991 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8992 interpreter "mi".
8993
8e5e5494
SM
89942019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8995
8996 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8997 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8998 instantiate mi_ui_out based on interpreter name.
8999 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9000 * mi/mi-main.c (mi_load_progress): Likewise.
9001
197df35e
JB
90022019-03-12 John Baldwin <jhb@FreeBSD.org>
9003
9004 * NEWS: Combine separate "New targets" sections for 8.3.
9005
8399425f
JB
90062019-03-12 John Baldwin <jhb@FreeBSD.org>
9007
9008 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9009 (ppcfbsd_init_abi): Install gdbarch
9010 "fetch_tls_load_module_address" and "get_thread_local_address"
9011 methods.
9012
b0f87ed0
JB
90132019-03-12 John Baldwin <jhb@FreeBSD.org>
9014
9015 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9016 (riscv_fbsd_init_abi): Install gdbarch
9017 "fetch_tls_load_module_address" and "get_thread_local_address"
9018 methods.
9019
ce25aa57
JB
90202019-03-12 John Baldwin <jhb@FreeBSD.org>
9021
9022 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9023 (i386fbsd_init_abi): Install gdbarch
9024 "fetch_tls_load_module_address" and "get_thread_local_address"
9025 methods.
9026
f5424cfa
JB
90272019-03-12 John Baldwin <jhb@FreeBSD.org>
9028
9029 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9030 (amd64fbsd_init_abi): Install gdbarch
9031 "fetch_tls_load_module_address" and "get_thread_local_address"
9032 methods.
9033
945f3901
JB
90342019-03-12 John Baldwin <jhb@FreeBSD.org>
9035
9036 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9037 (struct fbsd_pspace_data): New type.
9038 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9039 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9040 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9041 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9042 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9043
ef0bd204
JB
90442019-03-12 John Baldwin <jhb@FreeBSD.org>
9045
9046 * gdbtypes.c (lookup_struct_elt): New function.
9047 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9048 * gdbtypes.h (struct struct_elt): New type.
9049 (lookup_struct_elt): New prototype.
9050
36c53a02
JB
90512019-03-12 John Baldwin <jhb@FreeBSD.org>
9052
9053 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9054 remove disabled code block.
9055
6e056c81
JB
90562019-03-12 John Baldwin <jhb@FreeBSD.org>
9057
9058 * gdbarch.sh (get_thread_local_address): New method.
9059 * gdbarch.h, gdbarch.c: Regenerate.
9060 * target.c (target_translate_tls_address): Use
9061 gdbarch_get_thread_local_address if present instead of
9062 target::get_thread_local_address.
9063
cd250a18
JB
90642019-03-12 John Baldwin <jhb@FreeBSD.org>
9065
9066 * target.h (target::get_thread_local_address): Update comment.
9067
df22c1e5
JB
90682019-03-12 John Baldwin <jhb@FreeBSD.org>
9069
9070 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9071 objfile->separate_debug_objfile_backlink if not NULL.
9072
dd6876c9
JB
90732019-03-12 John Baldwin <jhb@FreeBSD.org>
9074
9075 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9076 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9077 (amd64bsd_store_inferior_registers): Likewise.
9078 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9079 Enable segment base registers.
9080 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9081 PT_GETFSBASE and PT_GETGSBASE.
9082 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9083 PT_SETGSBASE.
9084 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9085 segment base registers.
9086 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9087
1163a4b7
JB
90882019-03-12 John Baldwin <jhb@FreeBSD.org>
9089
9090 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9091 Update calls to i386_target_description to add 'segments'
9092 parameter.
9093 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9094 add segment base registers.
9095 * arch/i386.c (i386_create_target_description): Add 'segments'
9096 parameter to enable segment base registers.
9097 * arch/i386.h (i386_create_target_description): Likewise.
9098 * features/i386/32bit-segments.xml: New file.
9099 * features/i386/32bit-segments.c: Generate.
9100 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9101 call to i386_target_description to add 'segments' parameter.
9102 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9103 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9104 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9105 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9106 if feature is present.
9107 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9108 Add 'segments' parameter to call to i386_target_description.
9109 (i386_target_description): Add 'segments' parameter to enable
9110 segment base registers.
9111 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9112 to call to i386_target_description.
9113 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9114 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9115 Define I386_NUM_REGS.
9116 (i386_target_description): Add 'segments' parameter to enable
9117 segment base registers.
9118
3a350822
EZ
91192019-03-12 Eli Zaretskii <eliz@gnu.org>
9120
9121 PR/24325
9122 * source-cache.c: #undef open and close, to avoid unresolved
9123 externals during linking.
9124
ffdd69cf
TT
91252019-03-12 Tom Tromey <tromey@adacore.com>
9126
9127 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9128 const. Add initializers.
9129 (_initialize_remote): Don't initialize ptid globals.
9130
ec148c57
PA
91312019-03-12 Pedro Alves <palves@redhat.com>
9132
9133 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9134
32764270
PA
91352019-03-12 Pedro Alves <palves@redhat.com>
9136
9137 * cp-name-parser.y (main): Remove unused 'len' variable.
9138
17547186
TT
91392019-03-12 Tom Tromey <tromey@adacore.com>
9140
9141 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9142 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9143
d3a70e03
TT
91442019-03-12 Tom Tromey <tromey@adacore.com>
9145
9146 * linux-nat.c (iterate_over_lwps): Update.
9147 (stop_callback): Remove parameter.
9148 (stop_wait_callback, detach_callback, resume_set_callback)
9149 (select_singlestep_lwp_callback, set_ignore_sigint)
9150 (status_callback, resumed_callback, resume_clear_callback)
9151 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9152 data parameter.
9153 (linux_nat_target::detach, linux_nat_target::resume)
9154 (linux_stop_and_wait_all_lwps, select_event_lwp)
9155 (linux_nat_filter_event, linux_nat_wait_1)
9156 (linux_nat_target::kill, linux_nat_target::stop)
9157 (linux_nat_target::stop): Update.
9158 (linux_nat_resume_callback): Change type.
9159 (resume_stopped_resumed_lwps, count_events_callback)
9160 (select_event_lwp_callback): Likewise.
9161 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9162 * arm-linux-nat.c (struct update_registers_data): Remove.
9163 (update_registers_callback): Change type.
9164 (arm_linux_insert_hw_breakpoint1): Update.
9165 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9166 parameter.
9167 (x86_linux_dr_set_addr): Update.
9168 (x86_linux_dr_set_control): Update.
9169 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9170 (iterate_over_lwps): Use gdb::function_view.
9171 * nat/aarch64-linux-hw-point.c (struct
9172 aarch64_dr_update_callback_param): Remove.
9173 (debug_reg_change_callback): Change type.
9174 (aarch64_notify_debug_reg_change): Update.
9175 * s390-linux-nat.c (s390_refresh_per_info): Update.
9176
82cb27ff
TT
91772019-03-11 Tom Tromey <tromey@adacore.com>
9178
9179 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9180 redundant assignment to "this_cu".
9181
568c0683
SM
91822019-03-08 Simon Marchi <simon.marchi@efficios.com>
9183
9184 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9185
f09ce22d
SM
91862019-03-08 Simon Marchi <simon.marchi@efficios.com>
9187
9188 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9189 from...
9190 (rank_one_type): ... this.
9191
595f96a9
SM
91922019-03-08 Simon Marchi <simon.marchi@efficios.com>
9193
9194 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9195 from...
9196 (rank_one_type): ... this.
9197
2598a94b
SM
91982019-03-08 Simon Marchi <simon.marchi@efficios.com>
9199
9200 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9201 from...
9202 (rank_one_type): ... this.
9203
7f17b20d
SM
92042019-03-08 Simon Marchi <simon.marchi@efficios.com>
9205
9206 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9207 from...
9208 (rank_one_type): ... this.
9209
2c509035
SM
92102019-03-08 Simon Marchi <simon.marchi@efficios.com>
9211
9212 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9213 from...
9214 (rank_one_type): ... this.
9215
0dd322dc
SM
92162019-03-08 Simon Marchi <simon.marchi@efficios.com>
9217
9218 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9219 from...
9220 (rank_one_type): ... this.
9221
41ea4728
SM
92222019-03-08 Simon Marchi <simon.marchi@efficios.com>
9223
9224 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9225 from...
9226 (rank_one_type): ... this.
9227
793cd1d2
SM
92282019-03-08 Simon Marchi <simon.marchi@efficios.com>
9229
9230 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9231 from...
9232 (rank_one_type): ... this.
9233
34910087
SM
92342019-03-08 Simon Marchi <simon.marchi@efficios.com>
9235
9236 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9237 from...
9238 (rank_one_type): ... this.
9239
f1f832d6
SM
92402019-03-08 Simon Marchi <simon.marchi@efficios.com>
9241
9242 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9243 from...
9244 (rank_one_type): ... this.
9245
b9f4512f
SM
92462019-03-08 Simon Marchi <simon.marchi@efficios.com>
9247
9248 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9249 from...
9250 (rank_one_type): ... this.
9251
9293fc63
SM
92522019-03-08 Simon Marchi <simon.marchi@efficios.com>
9253
9254 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9255 from...
9256 (rank_one_type): ... this.
9257
e3abbe7e
PW
92582019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9259
9260 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9261 inferior-events' shows the example events.
9262
e4adb939
EZ
92632019-03-08 Eli Zaretskii <eliz@gnu.org>
9264
9265 Support styling on native MS-Windows console
9266
9267 PR/24315
9268 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9269 on MS-Windows if $TERM is not defined.
9270
9271 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9272
9273 * posix-hdep.c (gdb_console_fputs):
9274 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9275 functions.
9276 * ui-file.h (gdb_console_fputs): Add prototype.
9277
9278 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9279 back to fputs only if the former returns zero.
9280
25629dfd
TT
92812019-03-07 Tom Tromey <tom@tromey.com>
9282
9283 * symmisc.c (print_symbol_bcache_statistics): Update.
9284 (print_objfile_statistics): Update.
9285 * symfile.c (allocate_symtab): Update.
9286 * stabsread.c: Don't include bcache.h.
9287 * psymtab.h (struct psymbol_bcache): Don't declare.
9288 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9289 (psymbol_bcache_init, psymbol_bcache_free)
9290 (psymbol_bcache_get_bcache): Don't declare.
9291 * psymtab.c (struct psymbol_bcache): Remove.
9292 (psymtab_storage::psymtab_storage): Update.
9293 (psymtab_storage::~psymtab_storage): Update.
9294 (psymbol_bcache_init, psymbol_bcache_free)
9295 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9296 (add_psymbol_to_bcache): Update.
9297 (allocate_psymtab): Update.
9298 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9299 macro_cache>: No longer pointers.
9300 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9301 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9302 * macrotab.c (macro_bcache): Update.
9303 * macroexp.c: Don't include bcache.h.
9304 * gdbtypes.c (check_types_worklist): Update.
9305 (types_deeply_equal): Remove TRY/CATCH. Update.
9306 * elfread.c (elf_symtab_read): Update.
9307 * dwarf2read.c: Don't include bcache.h.
9308 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9309 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9310 (print_bcache_statistics, bcache_memory_used): Don't declare.
9311 (struct bcache): Move from bcache.c. Add constructor, destructor,
9312 methods. Rename all data members.
9313 * bcache.c (struct bcache): Move to bcache.h.
9314 (bcache::expand_hash_table): Rename from expand_hash_table.
9315 (bcache): Remove.
9316 (bcache::insert): Rename from bcache_full.
9317 (bcache::compare): Rename from bcache_compare.
9318 (bcache_xmalloc): Remove.
9319 (bcache::~bcache): Rename from bcache_xfree.
9320 (bcache::print_statistics): Rename from print_bcache_statistics.
9321 (bcache::memory_used): Rename from bcache_memory_used.
9322
fe726667
PA
93232019-03-07 Pedro Alves <palves@redhat.com>
9324
9325 * infrun.c (normal_stop): Also check for
9326 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9327
7584bb30
AB
93282019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9329
9330 * f-lang.c (value_from_host_double): Moved to...
9331 * value.c (value_from_host_double): ...here.
9332 * value.h (value_from_host_double): Declare.
9333 * guile/scm-math.c (vlscm_convert_typed_number): Use
9334 value_from_host_double.
9335 (vlscm_convert_number): Likewise.
9336 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9337 * python/py-value.c (convert_value_from_python): Likewise.
9338
a7b1986e
TT
93392019-03-06 Tom Tromey <tom@tromey.com>
9340
9341 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9342
0ccf4211
TT
93432019-03-06 Tom Tromey <tom@tromey.com>
9344
9345 * utils.h (free_current_contents): Don't declare.
9346 * utils.c (free_current_contents): Remove.
9347
fe7b42e5
TT
93482019-03-06 Tom Tromey <tom@tromey.com>
9349
9350 * top.c (quit_force): Update.
9351 * main.c (captured_command_loop): Update.
9352 * common/new-op.c (operator new): Update.
9353 * common/common-exceptions.c (struct catcher)
9354 <save_cleanup_chain>: Remove member.
9355 (exceptions_state_mc_init): Update.
9356 (exception_try_scope_entry): Return nullptr.
9357 (exception_try_scope_exit, exception_rethrow)
9358 (throw_exception_sjlj, throw_exception_cxx): Update.
9359 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9360 (all_cleanups, do_cleanups, discard_cleanups)
9361 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9362 (restore_cleanups, restore_final_cleanups): Don't declare.
9363 (do_final_cleanups): Remove parameter.
9364 * common/cleanups.c (cleanup_chain, make_cleanup)
9365 (make_cleanup_dtor, all_cleanups, do_cleanups)
9366 (discard_my_cleanups, discard_cleanups)
9367 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9368 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9369 (null_cleanup): Remove.
9370 (do_final_cleanups): Remove parameter.
9371
c6321f19
TT
93722019-03-06 Tom Tromey <tom@tromey.com>
9373
9374 * remote.c (remote_target::remote_parse_stop_reply): Use
9375 unique_xmalloc_ptr.
9376
61b30099
TT
93772019-03-06 Tom Tromey <tom@tromey.com>
9378
9379 * stabsread.c (struct stabs_field_info): Rename from field_info.
9380 <list, fnlist>: Add initializers.
9381 <obstack>: New member.
9382 (read_member_functions, read_struct_fields, read_baseclasses):
9383 Allocate on obstack. Don't use cleanups.
9384 (read_one_struct_field, read_member_functions, read_struct_fields)
9385 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9386 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9387 (read_struct_type): Update.
9388
6cceac94
TT
93892019-03-06 Tom Tromey <tom@tromey.com>
9390
9391 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9392 * common/filestuff.h (make_cleanup_close): Don't declare.
9393 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9394 Remove.
9395
72412762
TT
93962019-03-06 Tom Tromey <tom@tromey.com>
9397
9398 * solib-aix.c: Use make_scope_exit.
9399
2b6ff1c0
TT
94002019-03-06 Tom Tromey <tom@tromey.com>
9401
9402 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9403 Use make_scope_exit.
9404
d01c5877
TT
94052019-03-06 Tom Tromey <tom@tromey.com>
9406
9407 * solib-svr4.c (disable_probes_interface): Remove parameter.
9408 (svr4_handle_solib_event): Use make_scope_exit.
9409
32603266
TT
94102019-03-06 Tom Tromey <tom@tromey.com>
9411
9412 * remote.c (struct stop_reply_deleter): Remove.
9413 (stop_reply_up): Update.
9414 (struct stop_reply): Derive from notif_event. Don't typedef.
9415 <regcache>: Now a std::vector.
9416 (stop_reply_xfree): Remove.
9417 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9418 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9419 (remote_target::discard_pending_stop_replies): Use delete.
9420 (remote_target::remote_parse_stop_reply): Update.
9421 (remote_target::process_stop_reply): Update.
9422 * remote-notif.h (struct notif_event): Add virtual destructor.
9423 Remove "dtr" member.
9424 (struct notif_client) <alloc_event>: Return a unique_ptr.
9425 (notif_event_xfree): Don't declare.
9426 (notif_event_up): New typedef.
9427 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9428 (notif_event_xfree, do_notif_event_xfree): Remove.
9429 (remote_notif_state_xfree): Update.
9430
9799571e
TT
94312019-03-06 Tom Tromey <tom@tromey.com>
9432
9433 * infrun.c (displaced_step_clear_cleanup): Now a
9434 forward_scope_exit type.
9435 (displaced_step_prepare_throw): Update.
9436 (displaced_step_fixup): Update.
9437
09e3c4ca
TT
94382019-03-06 Tom Tromey <tom@tromey.com>
9439
9440 * inferior.h (class inferior): Update comment.
9441 * gdbthread.h (class thread_info): Update comment.
9442
e2a03548
TT
94432019-03-06 Joel Brobecker <brobecker@adacore.com>
9444 Tom Tromey <tom@tromey.com>
9445
9446 * stabsread.h (struct stab_section_list): Remove.
9447 (coffstab_build_psymtabs): Update.
9448 * dbxread.c (symbuf_sections): Now a std::vector.
9449 (sect_idx): New global.
9450 (fill_symbuf): Update.
9451 (coffstab_build_psymtabs): Change type of stabsects parameter.
9452 Update.
9453 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9454 std::vector.
9455 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9456 (coff_locate_sections): Update.
9457 (coff_symfile_read): Remove cleanups. Update.
9458 (init_stringtab): Add storage parameter.
9459 (free_stringtab, free_stringtab_cleanup): Remove.
9460 (init_lineno): Add storage parameter.
9461 (free_linetab, free_linetab_cleanup): Remove.
9462
b7e60d85
PA
94632019-03-06 Pedro Alves <palves@redhat.com>
9464
9465 * linux-fork.c (fork_info::clobber_regs): Delete.
9466 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9467 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9468 comment. Adjust.
9469 (scoped_switch_fork_info::scoped_switch_fork_info)
9470 (checkpoint_command, linux_fork_context): Adjust
9471 fork_save_infrun_state calls.
9472
e52c971f
PA
94732019-03-06 Pedro Alves <palves@redhat.com>
9474
9475 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9476 (inf_has_multiple_threads): Return 'bool' and rewrite using
9477 inferior_info::threads().
9478
06974e6c
PA
94792019-03-06 Pedro Alves <palves@redhat.com>
9480
9481 * linux-fork.c: Include <list>.
9482 (fork_list): Now a std::list instance.
9483 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9484 (forks_exist_p, find_last_fork): Adjust.
9485 (new_fork): Delete.
9486 (one_fork_p): New.
9487 (add_fork): Adjust.
9488 (free_fork): Delete, folded into fork_info::~fork_info().
9489 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9490 Adjust.
9491 (init_fork_list): Delete.
9492 (linux_fork_killall, linux_fork_mourn_inferior)
9493 (linux_fork_detach, info_checkpoints_command): Adjust.
9494 (_initialize_linux_fork): No longer call init_fork_list.
9495
72f31aea
PA
94962019-03-06 Pedro Alves <palves@redhat.com>
9497
9498 * linux-fork.c (new_fork): New, split out of ...
9499 (add_fork): ... this. Return void. Move "first fork" special
9500 case from here, to ...
9501 (checkpoint_command): ... here.
9502 * linux-linux.h (add_fork): Return void.
9503
efbecbc1
AB
95042019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9505
9506 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9507
0841c79a
AB
95082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9509 Chris January <chris.january@arm.com>
9510 David Lecomber <david.lecomber@arm.com>
9511
9512 * f-exp.y: New token, UNOP_INTRINSIC.
9513 (exp): New pattern using UNOP_INTRINSIC token.
9514 (f77_keywords): Add 'abs' keyword.
9515 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9516 (value_from_host_double): New function.
9517 (evaluate_subexp_f): Support UNOP_ABS.
9518
4a270568
AB
95192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9520
9521 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9522 types.
9523
067630bd
AB
95242019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9525
9526 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9527 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9528 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9529
3be47f7a
AB
95302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9531
9532 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9533
4d00f5d8
AB
95342019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9535 Chris January <chris.january@arm.com>
9536
9537 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9538 * f-exp.y: Define 'KIND' token.
9539 (exp): New pattern for KIND expressions.
9540 (ptype): Handle types with a kind extension.
9541 (direct_abs_decl): Extend to spot kind extensions.
9542 (f77_keywords): Add 'kind' to the list.
9543 (push_kind_type): New function.
9544 (convert_to_kind_type): New function.
9545 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9546 * parse.c (operator_length_standard): Likewise.
9547 * parser-defs.h (enum type_pieces): Add tp_kind.
9548 * std-operator.def: Add UNOP_KIND.
9549
e454224f
AB
95502019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9551
9552 * f-exp.y (f_parse): Set yydebug.
9553
9dad4a58
AB
95542019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9555
9556 * f-lang.c (evaluate_subexp_f): New function.
9557 (exp_descriptor_f): New global.
9558 (f_language_defn): Use exp_descriptor_f instead of
9559 exp_descriptor_standard.
9560
c8f91604
AB
95612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9562
9563 * f-exp.y (struct token): Add comments.
9564 (dot_ops): Remove uppercase versions and the end marker.
9565 (f77_keywords): Likewise.
9566 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9567 entries in the dot_ops array are case insensitive, and use
9568 strncasecmp to compare strings. Also some whitespace cleanup in
9569 this area. Similar for the f77_keywords array, except entries in
9570 this list might be case sensitive.
9571
dd9f2c76
AB
95722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9573
9574 * f-exp.y (struct f77_boolean_val): Add comments.
9575 (boolean_values): Remove uppercase versions, and end marker.
9576 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9577 and use strncasecmp to achieve case insensitivity. Additionally,
9578 perform whitespace cleanup around this code.
9579
67a3048c
TT
95802019-03-06 Tom Tromey <tromey@adacore.com>
9581
9582 * remote-sim.c (gdbsim_target_open): Use result of
9583 gdb_argv::release.
9584
aa3cfbda
RB
95852019-03-06 Richard Bunt <richard.bunt@arm.com>
9586 Dirk Schubert <dirk.schubert@arm.com>
9587 Chris January <chris.january@arm.com>
9588
9589 * eval.c (evaluate_subexp_standard): Call Fortran argument
9590 wrapping logic.
9591 * f-lang.c (struct value): A value which can be passed into a
9592 Fortran function call.
9593 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9594 where appropriate.
9595 (struct type): Value ready for a Fortran function call.
9596 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9597 is needed.
9598 * f-lang.h (fortran_argument_convert): Declaration.
9599 (fortran_preserve_arg_pointer): Declaration.
9600 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9601
ea38e5df
TT
96022019-03-05 Tom Tromey <tromey@adacore.com>
9603
9604 * python/py-prettyprint.c (print_string_repr): Remove #if.
9605 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9606
06b5b831
TT
96072019-03-05 Tom Tromey <tromey@adacore.com>
9608
9609 * target.c (the_dummy_target): Move later. Change type to
9610 "dummy_target".
9611 (initialize_targets): Don't initialize the_dummy_target.
9612
edbd9e45
TT
96132019-03-05 Tom Tromey <tromey@adacore.com>
9614
9615 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9616 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9617
c119e040
TT
96182019-03-05 Tom Tromey <tromey@adacore.com>
9619
9620 * windows-nat.c (windows_nat_target::attach)
9621 (windows_nat_target::detach): Don't call gdb_flush.
9622 * valprint.c (generic_val_print, val_print, val_print_string):
9623 Don't call gdb_flush.
9624 * utils.c (defaulted_query): Don't call gdb_flush.
9625 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9626 * target.c (target_announce_detach): Don't call gdb_flush.
9627 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9628 * remote.c (extended_remote_target::attach): Don't call
9629 gdb_flush.
9630 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9631 * printcmd.c (do_examine): Don't call gdb_flush.
9632 (info_display_command): Don't call gdb_flush.
9633 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9634 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9635 * memattr.c (info_mem_command): Don't call gdb_flush.
9636 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9637 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9638 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9639 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9640 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9641 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9642 (gnu_nat_target::detach): Don't call gdb_flush.
9643 * f-valprint.c (f_val_print): Don't call gdb_flush.
9644 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9645 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9646 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9647 gdb_flush.
9648 * c-valprint.c (c_val_print): Don't call gdb_flush.
9649 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9650
895dafa6
TT
96512019-03-05 Tom Tromey <tromey@adacore.com>
9652
9653 * varobj.c (update_dynamic_varobj_children): Update.
9654 (install_default_visualizer): Use reset, not release.
9655 * value.c (set_internalvar): Update.
9656 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9657 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9658 ATTRIBUTE_UNUSED_RESULT.
9659
88a774b9
TT
96602019-03-05 Tom Tromey <tromey@adacore.com>
9661
9662 * remote.c (class scoped_remote_fd) <release>: Add
9663 ATTRIBUTE_UNUSED_RESULT.
9664
4e4a8b93
TT
96652019-03-05 Tom Tromey <tromey@adacore.com>
9666
9667 * macroexp.c (struct macro_buffer) <release>: Add
9668 ATTRIBUTE_UNUSED_RESULT.
9669
083eef1f
TT
96702019-03-05 Tom Tromey <tromey@adacore.com>
9671
9672 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9673 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9674 ATTRIBUTE_UNUSED_RESULT.
9675
3cabd438
TT
96762019-03-05 Tom Tromey <tromey@adacore.com>
9677
9678 * common/scoped_fd.h (class scoped_fd) <release>: Add
9679 ATTRIBUTE_UNUSED_RESULT.
9680
41e3300a
TT
96812019-03-05 Tom Tromey <tromey@adacore.com>
9682
9683 * parser-defs.h (struct parser_state) <release>: Add
9684 ATTRIBUTE_UNUSED_RESULT.
9685
18cb7c9f
TT
96862019-03-05 Tom Tromey <tromey@adacore.com>
9687
9688 * utils.h (class gdb_argv) <release>: Add
9689 ATTRIBUTE_UNUSED_RESULT.
9690 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9691
41fa577f
EZ
96922019-03-02 Eli Zaretskii <eliz@gnu.org>
9693
a6a4b2c6
EZ
9694 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9695 for-loop range, to avoid compiler warnings.
9696
9697 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9698 avoid compiler warnings about unused variables.
9699
742a7df5
EZ
9700 * NEWS: Mention end of support for native debugging on MS-Windows
9701 before XP.
9702
41fa577f
EZ
9703 PR gdb/24292
9704 * common/netstuff.c:
9705 * gdbserver/gdbreplay.c
9706 * gdbserver/remote-utils.c:
9707 * ser-tcp.c:
9708 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9709 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9710 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9711 'getaddrinfo' and 'freeaddrinfo' were not available before
9712 Windows XP, and mingw.org's MinGW headers by default define
9713 _WIN32_WINNT to 0x500.
9714
827f438f
GB
97152019-03-01 Gary Benson <gbenson@redhat.com>
9716
9717 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9718
92137da0
RO
97192019-02-28 Brian Vandenberg <phantall@gmail.com>
9720 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9721
9722 PR gdb/8527
9723 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9724 set_sigint_trap, clear_sigint_trap.
9725
799efbe8
PW
97262019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9727
9728 * target.c (target_detach): Clear the regcache and the
9729 frame cache.
9730
8ed25214
PA
97312019-02-27 Pedro Alves <palves@redhat.com>
9732
9733 * utils.c (set_screen_size): When we cap the height/width sizes,
9734 tweak the corresponding command variable to show "unlimited":
9735
23031e31
SJ
97362019-02-27 Saagar Jha <saagar@saagarjha.com>
9737 Pedro Alves <palves@redhat.com>
9738
9739 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9740 before calling rl_set_screen_size.
9741
6c28e44a
TT
97422019-02-27 Tom Tromey <tromey@adacore.com>
9743
9744 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9745 define.
9746 * python/py-value.c: Remove Python 2.4 workaround.
9747 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9748 workaround.
9749 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9750 Python 2.4 workaround.
9751 * python/python-internal.h: Remove Python 2.4 comment.
9752 (Py_ssize_t): Don't define.
9753 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9754 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9755 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9756 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9757 * python/python.c (do_start_initialization): Remove Python 2.4
9758 workaround.
9759 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9760 (print_children): Remove Python 2.4 workaround.
9761 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9762 workaround.
9763 (CHARBUFFERPROC_NAME): Remove.
9764 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9765 Python 2.4 workaround.
9766
2c3fc25d 97672019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9768
2c3fc25d
KB
9769 * NEWS: Note minimum Python version.
9770
6ca62222
KB
97712019-02-27 Kevin Buettner <kevinb@redhat.com>
9772
9773 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9774 code from these functions. Remove corresponding ifdefs. Use
9775 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9776 Remove gotos and target of gotos.
9777 (infpy_search_memory): Likewise.
9778
f4bc7d2c
AB
97792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9780
9781 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9782 (hppa_gdbarch_init): Don't register deleted functions with
9783 gdbarch.
9784
9734a586
AB
97852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9786
9787 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9788 (h8300_unwind_sp): Delete.
9789 (h8300_dummy_id): Delete.
9790 (h8300_gdbarch_init): Don't register deleted functions with
9791 gdbarch.
9792
68b867f3
AB
97932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9794
9795 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9796 (ft32_unwind_pc): Delete.
9797 (ft32_unwind_sp): Delete.
9798 (ft32_gdbarch_init): Don't register deleted functions with
9799 gdbarch.
9800
2fbe7ad0
AB
98012019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9802
9803 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9804 (frv_unwind_pc): Delete.
9805 (frv_unwind_sp): Delete.
9806 (frv_gdbarch_init): Don't register deleted functions with
9807 gdbarch.
9808
76055cbe
AB
98092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9810
9811 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9812 (riscv_unwind_pc): Delete.
9813 (riscv_unwind_sp): Delete.
9814 (riscv_gdbarch_init): Don't register deleted functions with
9815 gdbarch.
9816
4133e5a1
AB
98172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9818
9819 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9820 (csky_unwind_pc): Delete.
9821 (csky_unwind_sp): Delete.
9822 (csky_gdbarch_init): Don't register deleted functions with
9823 gdbarch.
9824
8010f576
AB
98252019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9826
9827 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9828 (cris_unwind_pc): Delete.
9829 (cris_unwind_sp): Delete.
9830 (cris_gdbarch_init): Don't register deleted functions with
9831 gdbarch.
9832
b56bf084
AB
98332019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9834
9835 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9836 (bfin_unwind_pc): Delete.
9837 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9838
a19a650f
AB
98392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9840
9841 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9842 (arm_unwind_pc): Delete.
9843 (arm_unwind_sp): Delete.
9844 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9845
f8278c3c
AB
98462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9847
9848 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9849 (arc_unwind_pc): Delete.
9850 (arc_unwind_sp): Delete.
9851 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9852
480e46cf
AB
98532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9854
9855 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9856 (alpha_unwind_pc): Delete.
9857 (alpha_gdbarch_init): Don't register deleted functions with
9858 gdbarch.
9859
7a995095
AB
98602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9861
9862 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9863 (aarch64_unwind_pc): Delete.
9864 (aarch64_unwind_sp): Delete.
9865 (aarch64_gdbarch_init): Don't register deleted functions with
9866 gdbarch.
9867
bf9a735e
AB
98682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9869
9870 * gdbtypes.c (type_align): Don't consider static members when
9871 computing structure alignment.
9872
5561fc30
AB
98732019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9874
9875 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9876 return 0 for other types.
9877 * arch-utils.c (default_type_align): Always return 0.
9878 * gdbarch.h: Regenerate.
9879 * gdbarch.sh (type_align): Extend comment.
9880 * gdbtypes.c (type_align): Add additional comments, always call
9881 gdbarch_type_align before applying the default rules.
9882 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9883 generic code will then apply a suitable default.
9884 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9885 types, return 0 for other types.
9886
9335e75a
JB
98872019-02-27 Joel Brobecker <brobecker@adacore.com>
9888
9889 * NEWS: Create a new section for the next release branch.
9890 Rename the section of the current branch, now that it has
9891 been cut.
9892
3d34d8de
JB
98932019-02-27 Joel Brobecker <brobecker@adacore.com>
9894
9895 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9896 * version.in: Bump version to 8.3.50.DATE-git.
9897
143420fb
SM
98982019-02-26 Simon Marchi <simon.marchi@efficios.com>
9899
9900 * aix-thread.c (ptid_cmp): Remove unused variable.
9901 (get_signaled_thread): Likewise.
9902 (store_regs_user_thread): Likewise.
9903 (store_regs_kernel_thread): Likewise.
9904 (fetch_regs_kernel_thread): Remove shadowed variable.
9905
172fb711
AB
99062019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9907
9908 * features/riscv/32bit-cpu.xml: Add register numbers.
9909 * features/riscv/32bit-fpu.c: Regenerate.
9910 * features/riscv/32bit-fpu.xml: Add register numbers.
9911 * features/riscv/64bit-cpu.xml: Add register numbers.
9912 * features/riscv/64bit-fpu.c: Regenerate.
9913 * features/riscv/64bit-fpu.xml: Add register numbers.
9914
26c89782
KB
99152019-02-26 Kevin Buettner <kevinb@redhat.com>
9916
af54ade9 9917 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9918 * python/py-value.c (convert_buffer_and_type_to_value): New
9919 function.
9920 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9921 Add support for handling an optional second argument. Call
9922 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9923 * python/python-internal.h (Py_buffer_deleter): New struct.
9924 (Py_buffer_up): New typedef.
9925
0f58c9e8
JB
99262019-02-25 John Baldwin <jhb@FreeBSD.org>
9927
9928 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9929 instead of releasing ownership.
9930
0a0f4c01
JR
99312019-02-25 Jordan Rupprecht <rupprecht@google.com>
9932
9933 * dwarf2read.c (open_and_init_dwp_file): Call
9934 elf_numsections instead of bfd_count_sections to initialize
9935 dwp_file->num_sections.
9936
cd5a152c
TT
99372019-02-25 Tom Tromey <tromey@adacore.com>
9938
9939 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9940
8a6a8513
SDJ
99412019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9942
9943 * gcore.in: Add '--readnever' option when invoking GDB.
9944
04dcda9c
SM
99452019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9946
9947 * MAINTAINERS: Update my email address.
9948
07bc701d
SM
99492019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9950
9951 * build-id.c (build_id_to_debug_bfd_1): New function.
9952 (build_id_to_debug_bfd): Look for separate debug file in
9953 sysroot.
9954
c6f4a5d0
AB
99552019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9956
9957 * gdbarch.sh: Update the copyright year range that is placed into
9958 generated files.
9959
9600246d
KS
99602019-02-22 Keith Seitz <keiths@redhat.com>
9961
9962 PR symtab/23853
9963 * linespec.c (create_sals_line_offset): Search for the default
9964 symtab's filename instead of its fullname.
9965
7557a514
AH
99662019-02-21 Alan Hayward <alan.hayward@arm.com>
9967
9968 * NEWS: Update style defaults.
9969
ee2bcb0c
AH
99702019-02-21 Alan Hayward <alan.hayward@arm.com>
9971
9972 * main.c (captured_main_1): Disable styling in batch mode.
9973
0c95f9ed
TT
99742019-02-20 Tom Tromey <tom@tromey.com>
9975
9976 * symtab.c (symtab_symbol_info): Fix typos.
9977
c763b894
TT
99782019-02-20 Tom Tromey <tromey@adacore.com>
9979
9980 * findcmd.c (_initialize_mem_search): Use upper case for
9981 metasyntactic variables.
9982
0ef8a082
AH
99832019-02-20 Alan Hayward <alan.hayward@arm.com>
9984
9985 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9986 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9987
6caa91b6
SM
99882019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9989
9990 * top.h (source_file_name): Change to std::string.
9991 * top.c (source_file_name): Likewise.
9992 (command_line_input): Adjust.
9993 * cli/cli-script.c (script_from_file): Adjust.
9994
98814c6c
TT
99952019-02-19 Tom Tromey <tromey@adacore.com>
9996
9997 * ravenscar-thread.c
9998 (ravenscar_thread_target::update_thread_list): Don't call
9999 ada_build_task_list.
10000 * ada-lang.h (ada_build_task_list): Don't declare.
10001 * ada-tasks.c (struct ada_tasks_inferior_data)
10002 <task_list_valid_p>: Now bool.
10003 (read_known_tasks, ada_task_list_changed)
10004 (ada_tasks_invalidate_inferior_data): Update.
10005 (read_known_tasks_array): Return bool.
10006 (read_known_tasks_list): Likewise.
10007 (read_known_tasks): Return void.
10008 (ada_build_task_list): Now static.
10009
70cd633e
AB
100102019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10011
10012 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10013 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10014
040b3e95
PW
100152019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10016
10017 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10018 variant for ada_tasks_pspace_data_handle and
10019 ada_tasks_inferior_data_handle.
10020 (ada_tasks_pspace_data_cleanup): New function.
10021 (ada_tasks_inferior_data_cleanup): New function.
10022
9409233b
TT
100232019-02-17 Tom Tromey <tom@tromey.com>
10024
10025 * macrotab.h (macro_source_fullname): Return a std::string.
10026 * macrotab.c (macro_include, check_for_redefinition)
10027 (macro_undef, macro_lookup_definition, foreach_macro)
10028 (foreach_macro_in_scope): Update.
10029 (macro_source_fullname): Return a std::string.
10030 * macrocmd.c (show_pp_source_pos): Update.
10031
6506371f
TT
100322019-02-17 Tom Tromey <tom@tromey.com>
10033
10034 * macrocmd.c (show_pp_source_pos): Style the file names.
10035
0c820d67
TT
100362019-02-17 Tom Tromey <tom@tromey.com>
10037
10038 PR tui/24197:
10039 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10040
a0087920
TT
100412019-02-17 Tom Tromey <tom@tromey.com>
10042
10043 * ada-lang.c (user_select_syms): Use filtered printing.
10044 * utils.c (wrap_style): New global.
10045 (desired_style): Remove.
10046 (emit_style_escape): Add stream parameter.
10047 (set_output_style, reset_terminal_style, prompt_for_continue):
10048 Update.
10049 (flush_wrap_buffer): Only flush gdb_stdout.
10050 (wrap_here): Set wrap_style.
10051 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10052 treat escape sequences as a character. Change when wrap buffer is
10053 flushed.
10054 (fputs_styled): Do not set the output style when the default is
10055 requested.
10056 * ui-style.h (struct ui_file_style) <is_default>: New method.
10057 * source.c (print_source_lines_base): Emit escape sequences in one
10058 piece.
10059
75ba10dc
JB
100602019-02-17 Joel Brobecker <brobecker@adacore.com>
10061
10062 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10063 integers and enumeration types.
10064
a2cd4f14
JB
100652019-02-17 Joel Brobecker <brobecker@adacore.com>
10066
10067 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10068 instead of lookup_symbol_in_language
10069 (do_exact_match): New function.
10070 (ada_get_symbol_name_matcher): Return do_exact_match when
10071 doing a verbatim match.
10072
485b851b
TT
100732019-02-15 Tom Tromey <tromey@adacore.com>
10074
10075 * ravenscar-thread.c (ravenscar_thread_target::resume)
10076 (ravenscar_thread_target::wait): Special case wildcard requests.
10077
0b790b1e
TT
100782019-02-15 Tom Tromey <tromey@adacore.com>
10079
10080 * ravenscar-thread.c (base_ptid): Remove.
10081 (struct ravenscar_thread_target) <close>: New method.
10082 <m_base_ptid>: New member.
10083 <update_inferior_ptid, active_task, task_is_currently_active,
10084 runtime_initialized>: Declare methods.
10085 <ravenscar_thread_target>: Add constructor.
10086 (ravenscar_thread_target::task_is_currently_active)
10087 (ravenscar_thread_target::update_inferior_ptid)
10088 (ravenscar_runtime_initialized): Rename. Now methods.
10089 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10090 (ravenscar_thread_target::update_thread_list): Update.
10091 (ravenscar_thread_target::active_task): Now method.
10092 (ravenscar_thread_target::store_registers)
10093 (ravenscar_thread_target::prepare_to_store)
10094 (ravenscar_thread_target::prepare_to_store)
10095 (ravenscar_thread_target::mourn_inferior): Update.
10096 (ravenscar_inferior_created): Use "new" to create target.
10097 (ravenscar_thread_target::get_ada_task_ptid): Update.
10098 (_initialize_ravenscar): Don't initialize base_ptid.
10099 (ravenscar_ops): Remove global.
10100
dea57a62
TT
101012019-02-15 Tom Tromey <tromey@adacore.com>
10102
10103 * target.h (push_target): Declare new overload.
10104 * target.c (push_target): New overload, taking an rvalue reference.
10105 * remote.c (remote_target::open_1): Use push_target overload.
10106 * corelow.c (core_target_open): Use push_target overload.
10107
989f3c58
TT
101082019-02-15 Tom Tromey <tromey@adacore.com>
10109
10110 * ravenscar-thread.c (is_ravenscar_task)
10111 (ravenscar_task_is_currently_active): Return bool.
10112 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10113 (_initialize_ravenscar): Remove "(void)".
10114 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10115 Return bool.
10116
6cbcc006
TT
101172019-02-15 Tom Tromey <tromey@adacore.com>
10118
10119 * ravenscar-thread.c (ravenscar_runtime_initializer)
10120 (has_ravenscar_runtime, get_running_thread_id)
10121 (ravenscar_thread_target::resume): Fix indentation.
10122
7657f14d
TT
101232019-02-15 Tom Tromey <tromey@adacore.com>
10124
10125 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10126 from ravenscar_arch_ops.
10127 (sparc_ravenscar_ops::fetch_registers)
10128 (sparc_ravenscar_ops::store_registers): Now methods.
10129 (sparc_ravenscar_prepare_to_store): Remove.
10130 (sparc_ravenscar_ops): Redefine.
10131 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10132 methods and destructor. Remove members.
10133 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10134 (ravenscar_thread_target::store_registers)
10135 (ravenscar_thread_target::prepare_to_store): Update.
10136 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10137 Remove.
10138 (struct ppc_ravenscar_powerpc_ops): Derive from
10139 ravenscar_arch_ops.
10140 (ppc_ravenscar_powerpc_ops::fetch_registers)
10141 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10142 (ppc_ravenscar_powerpc_ops): Redefine.
10143 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10144 (ppc_ravenscar_e500_ops::fetch_registers)
10145 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10146 (ppc_ravenscar_e500_ops): Redefine.
10147 * aarch64-ravenscar-thread.c
10148 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10149 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10150 (aarch64_ravenscar_fetch_registers)
10151 (aarch64_ravenscar_store_registers): Now methods.
10152 (aarch64_ravenscar_ops): Redefine.
10153
5b6ea500
TT
101542019-02-15 Tom Tromey <tromey@adacore.com>
10155
10156 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10157 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10158 (ravenscar_thread_target::stopped_by_watchpoint)
10159 (ravenscar_thread_target::stopped_data_address)
10160 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10161
e397fd39
TT
101622019-02-15 Tom Tromey <tromey@adacore.com>
10163
10164 * ravenscar-thread.c: Fix some typos.
10165
cc12f4a8
TT
101662019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10167 Tom Tromey <tromey@adacore.com>
10168
10169 * ada-lang.c (ada_exception_sal): Change addr_string to a
10170 std::string.
10171 (create_ada_exception_catchpoint): Update.
10172
5f486660
TT
101732019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10174 Tom Tromey <tromey@adacore.com>
10175
10176 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10177 (bp_location_ops): Remove.
10178 (base_breakpoint_allocate_location): Update.
10179 (free_bp_location): Update.
10180 * ada-lang.c (class ada_catchpoint_location)
10181 <ada_catchpoint_location>: Remove ops parameter.
10182 (ada_catchpoint_location_dtor): Remove.
10183 (ada_catchpoint_location_ops): Remove.
10184 (allocate_location_exception): Update.
10185 * breakpoint.h (struct bp_location_ops): Remove.
10186 (class bp_location) <bp_location>: Remove bp_location_ops
10187 parameter.
10188 <~bp_location>: Add destructor.
10189 <ops>: Remove.
10190
b671c7fb
TS
101912019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10192 Pedro Alves <palves@redhat.com>
10193
10194 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10195 'PATH_MAX'.
10196
8071c5ce
DM
101972019-02-14 David Michael <fedora.dm0@gmail.com>
10198 Samuel Thibault <samuel.thibault@gnu.org>
10199 Thomas Schwinge <thomas@codesourcery.com>
10200
10201 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10202 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10203
b1041ae0
TS
102042019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10205
924514e1
TS
10206 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10207 (check_empty): Use "const char *".
10208
c29ee8d4
TS
10209 * gnu-nat.c (gnu_nat_target::detach): Instead of
10210 'detach_inferior (pid)' call
10211 'detach_inferior (find_inferior_pid (pid))'.
10212
6c6ef69f
TS
10213 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10214 'nat/fork-inferior.o'.
10215 * gnu-nat.c: #include "nat/fork-inferior.h".
10216
2d0a338c
TS
10217 * gnu-nat.c (gnu_nat_target::detach): Instead of
10218 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10219 * gnu-nat.h: #include "inf-child.h".
10220 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10221 'i386_gnu_nat_target::fetch_registers'.
10222 (gnu_store_registers): Rename/move to
10223 'i386_gnu_nat_target::store_registers'.
10224
cabb5f06
TS
10225 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10226 * gnu-nat.h (mach_thread_info): New function.
10227 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10228
b1041ae0
TS
10229 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10230
2988d01e
KF
102312019-02-14 Frederic Konrad <konrad@adacore.com>
10232
10233 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10234
c559d709
JB
102352019-02-14 Joel Brobecker <brobecker@adacore.com>
10236
10237 * windows-nat.c (windows_add_thread): Add new parameter
10238 "main_thread_p" with default value set to false. Update
10239 function documentation as well as all callers.
10240 (windows_delete_thread): Likewise.
10241 (fake_create_process): Update call to windows_add_thread.
10242 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10243 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10244 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10245 call to windows_delete_thread.
10246
007024cc
SM
102472019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10248
10249 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10250
f62318e9
JB
102512019-02-12 John Baldwin <jhb@FreeBSD.org>
10252
10253 * symfile.c (find_separate_debug_file): Use canonical path of
10254 sysroot with child_path instead of gdb_sysroot if it is valid.
10255
cd4b7848
JB
102562019-02-12 John Baldwin <jhb@FreeBSD.org>
10257
10258 * symfile.c (find_separate_debug_file): Use child_path to
10259 determine if an object file is under a sysroot.
10260
efac4bfe
JB
102612019-02-12 John Baldwin <jhb@FreeBSD.org>
10262
10263 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10264 unittests/child-path-selftests.c.
10265 * common/pathstuff.c (child_path): New function.
10266 * common/pathstuff.h (child_path): New prototype.
10267 * unittests/child-path-selftests.c: New file.
10268
402d2bfe
JB
102692019-02-12 John Baldwin <jhb@FreeBSD.org>
10270
10271 * symfile.c (find_separate_debug_file): Look for separate debug
10272 files in debug directories under the sysroot.
10273
1ed9f74e
PW
102742019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10275
10276 * symtab.h (struct minimal_symbol data_p): New const method.
10277 (struct minimal_symbol text_p): Likewise.
10278 * symtab.c (output_source_filename): Use file name style
10279 to print file name.
10280 (print_symbol_info): Likewise.
10281 (print_msymbol_info): Use address style to print addresses.
10282 Use function name style to print executable text symbols.
10283 (expand_symtab_containing_pc): Use data_p.
10284 (find_pc_sect_compunit_symtab): Likewise.
10285
2636d81d
PW
102862019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10287
10288 * breakpoint.c (describe_other_breakpoints): Use address style
10289 to print addresses.
10290 (say_where): Likewise.
10291
ac8c53cc
PW
102922019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10293
10294 * ada-typeprint.c (print_func_type): Print function name
10295 style to print function name.
10296 * c-typeprint.c (c_print_type_1): Likewise.
10297
ea638c43
AH
102982019-02-11 Alan Hayward <alan.hayward@arm.com>
10299
10300 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10301 for execve.
10302
ab759ca8
PW
103032019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10304
10305 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10306 type_stack.
10307
aff29d1c
JB
103082019-02-10 Joel Brobecker <brobecker@adacore.com>
10309
10310 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10311 TYPE_CODE_REF types.
10312
617126bc
JW
103132019-02-08 Jim Wilson <jimw@sifive.com>
10314
10315 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10316 (riscv_linux_fregset): New.
10317 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10318
46e3ed7f
TT
103192019-02-07 Tom Tromey <tom@tromey.com>
10320
10321 * thread.c (thread_cancel_execution_command): Update.
10322 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10323 methods.
10324 (struct thread_fsm_ops): Remove.
10325 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10326 (thread_fsm_should_stop, thread_fsm_return_value)
10327 (thread_fsm_set_finished, thread_fsm_finished_p)
10328 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10329 Don't declare.
10330 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10331 * infrun.c (clear_proceed_status_thread)
10332 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10333 (print_stop_event): Update.
10334 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10335 Add constructor.
10336 (step_command_fsm_ops): Remove.
10337 (new_step_command_fsm): Remove.
10338 (step_1): Update.
10339 (step_command_fsm::should_stop): Rename from
10340 step_command_fsm_should_stop.
10341 (step_command_fsm::clean_up): Rename from
10342 step_command_fsm_clean_up.
10343 (step_command_fsm::do_async_reply_reason): Rename from
10344 step_command_fsm_async_reply_reason.
10345 (struct until_next_fsm): Inherit from thread_fsm. Add
10346 constructor.
10347 (until_next_fsm_ops): Remove.
10348 (new_until_next_fsm): Remove.
10349 (until_next_fsm::should_stop): Rename from
10350 until_next_fsm_should_stop.
10351 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10352 (until_next_fsm::do_async_reply_reason): Rename from
10353 until_next_fsm_async_reply_reason.
10354 (struct finish_command_fsm): Inherit from thread_fsm. Add
10355 constructor. Change type of breakpoint.
10356 (finish_command_fsm_ops): Remove.
10357 (new_finish_command_fsm): Remove.
10358 (finish_command_fsm::should_stop): Rename from
10359 finish_command_fsm_should_stop.
10360 (finish_command_fsm::clean_up): Rename from
10361 finish_command_fsm_clean_up.
10362 (finish_command_fsm::return_value): Rename from
10363 finish_command_fsm_return_value.
10364 (finish_command_fsm::do_async_reply_reason): Rename from
10365 finish_command_fsm_async_reply_reason.
10366 (finish_command): Update.
10367 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10368 Add constructor.
10369 (call_thread_fsm_ops): Remove.
10370 (call_thread_fsm::call_thread_fsm): Rename from
10371 new_call_thread_fsm.
10372 (call_thread_fsm::should_stop): Rename from
10373 call_thread_fsm_should_stop.
10374 (call_thread_fsm::should_notify_stop): Rename from
10375 call_thread_fsm_should_notify_stop.
10376 (run_inferior_call, call_function_by_hand_dummy): Update.
10377 * cli/cli-interp.c (should_print_stop_to_console): Update.
10378 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10379 Add constructor. Change type of location_breakpoint,
10380 caller_breakpoint.
10381 (until_break_fsm_ops): Remove.
10382 (new_until_break_fsm): Remove.
10383 (until_break_fsm::should_stop): Rename from
10384 until_break_fsm_should_stop.
10385 (until_break_fsm::clean_up): Rename from
10386 until_break_fsm_clean_up.
10387 (until_break_fsm::do_async_reply_reason): Rename from
10388 until_break_fsm_async_reply_reason.
10389 (until_break_command): Update.
10390 * thread-fsm.c: Remove.
10391 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10392
1a5c2598
TT
103932019-02-07 Tom Tromey <tom@tromey.com>
10394
10395 * yy-remap.h: Add include guard.
10396 * xtensa-tdep.h: Add include guard.
10397 * xcoffread.h: Rename include guard.
10398 * varobj-iter.h: Add include guard.
10399 * tui/tui.h: Rename include guard.
10400 * tui/tui-winsource.h: Rename include guard.
10401 * tui/tui-wingeneral.h: Rename include guard.
10402 * tui/tui-windata.h: Rename include guard.
10403 * tui/tui-win.h: Rename include guard.
10404 * tui/tui-stack.h: Rename include guard.
10405 * tui/tui-source.h: Rename include guard.
10406 * tui/tui-regs.h: Rename include guard.
10407 * tui/tui-out.h: Rename include guard.
10408 * tui/tui-layout.h: Rename include guard.
10409 * tui/tui-io.h: Rename include guard.
10410 * tui/tui-hooks.h: Rename include guard.
10411 * tui/tui-file.h: Rename include guard.
10412 * tui/tui-disasm.h: Rename include guard.
10413 * tui/tui-data.h: Rename include guard.
10414 * tui/tui-command.h: Rename include guard.
10415 * tic6x-tdep.h: Add include guard.
10416 * target/waitstatus.h: Rename include guard.
10417 * target/wait.h: Rename include guard.
10418 * target/target.h: Rename include guard.
10419 * target/resume.h: Rename include guard.
10420 * target-float.h: Rename include guard.
10421 * stabsread.h: Add include guard.
10422 * rs6000-tdep.h: Add include guard.
10423 * riscv-fbsd-tdep.h: Add include guard.
10424 * regformats/regdef.h: Rename include guard.
10425 * record.h: Rename include guard.
10426 * python/python.h: Rename include guard.
10427 * python/python-internal.h: Rename include guard.
10428 * python/py-stopevent.h: Rename include guard.
10429 * python/py-ref.h: Rename include guard.
10430 * python/py-record.h: Rename include guard.
10431 * python/py-record-full.h: Rename include guard.
10432 * python/py-record-btrace.h: Rename include guard.
10433 * python/py-instruction.h: Rename include guard.
10434 * python/py-events.h: Rename include guard.
10435 * python/py-event.h: Rename include guard.
10436 * procfs.h: Add include guard.
10437 * proc-utils.h: Add include guard.
10438 * p-lang.h: Add include guard.
10439 * or1k-tdep.h: Rename include guard.
10440 * observable.h: Rename include guard.
10441 * nto-tdep.h: Rename include guard.
10442 * nat/x86-linux.h: Rename include guard.
10443 * nat/x86-linux-dregs.h: Rename include guard.
10444 * nat/x86-gcc-cpuid.h: Add include guard.
10445 * nat/x86-dregs.h: Rename include guard.
10446 * nat/x86-cpuid.h: Rename include guard.
10447 * nat/ppc-linux.h: Rename include guard.
10448 * nat/mips-linux-watch.h: Rename include guard.
10449 * nat/linux-waitpid.h: Rename include guard.
10450 * nat/linux-ptrace.h: Rename include guard.
10451 * nat/linux-procfs.h: Rename include guard.
10452 * nat/linux-osdata.h: Rename include guard.
10453 * nat/linux-nat.h: Rename include guard.
10454 * nat/linux-namespaces.h: Rename include guard.
10455 * nat/linux-btrace.h: Rename include guard.
10456 * nat/glibc_thread_db.h: Rename include guard.
10457 * nat/gdb_thread_db.h: Rename include guard.
10458 * nat/gdb_ptrace.h: Rename include guard.
10459 * nat/fork-inferior.h: Rename include guard.
10460 * nat/amd64-linux-siginfo.h: Rename include guard.
10461 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10462 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10463 * nat/aarch64-linux.h: Rename include guard.
10464 * nat/aarch64-linux-hw-point.h: Rename include guard.
10465 * mn10300-tdep.h: Add include guard.
10466 * mips-linux-tdep.h: Add include guard.
10467 * mi/mi-parse.h: Rename include guard.
10468 * mi/mi-out.h: Rename include guard.
10469 * mi/mi-main.h: Rename include guard.
10470 * mi/mi-interp.h: Rename include guard.
10471 * mi/mi-getopt.h: Rename include guard.
10472 * mi/mi-console.h: Rename include guard.
10473 * mi/mi-common.h: Rename include guard.
10474 * mi/mi-cmds.h: Rename include guard.
10475 * mi/mi-cmd-break.h: Rename include guard.
10476 * m2-lang.h: Add include guard.
10477 * location.h: Rename include guard.
10478 * linux-record.h: Rename include guard.
10479 * linux-nat.h: Add include guard.
10480 * linux-fork.h: Add include guard.
10481 * i386-darwin-tdep.h: Rename include guard.
10482 * hppa-linux-offsets.h: Add include guard.
10483 * guile/guile.h: Rename include guard.
10484 * guile/guile-internal.h: Rename include guard.
10485 * gnu-nat.h: Rename include guard.
10486 * gdb-stabs.h: Rename include guard.
10487 * frv-tdep.h: Add include guard.
10488 * f-lang.h: Add include guard.
10489 * event-loop.h: Add include guard.
10490 * darwin-nat.h: Rename include guard.
10491 * cp-abi.h: Rename include guard.
10492 * config/sparc/nm-sol2.h: Rename include guard.
10493 * config/nm-nto.h: Rename include guard.
10494 * config/nm-linux.h: Add include guard.
10495 * config/i386/nm-i386gnu.h: Rename include guard.
10496 * config/djgpp/nl_types.h: Rename include guard.
10497 * config/djgpp/langinfo.h: Rename include guard.
10498 * compile/gcc-cp-plugin.h: Add include guard.
10499 * compile/gcc-c-plugin.h: Add include guard.
10500 * compile/compile.h: Rename include guard.
10501 * compile/compile-object-run.h: Rename include guard.
10502 * compile/compile-object-load.h: Rename include guard.
10503 * compile/compile-internal.h: Rename include guard.
10504 * compile/compile-cplus.h: Rename include guard.
10505 * compile/compile-c.h: Rename include guard.
10506 * common/xml-utils.h: Rename include guard.
10507 * common/x86-xstate.h: Rename include guard.
10508 * common/version.h: Rename include guard.
10509 * common/vec.h: Rename include guard.
10510 * common/tdesc.h: Rename include guard.
10511 * common/selftest.h: Rename include guard.
10512 * common/scoped_restore.h: Rename include guard.
10513 * common/scoped_mmap.h: Rename include guard.
10514 * common/scoped_fd.h: Rename include guard.
10515 * common/safe-iterator.h: Rename include guard.
10516 * common/run-time-clock.h: Rename include guard.
10517 * common/refcounted-object.h: Rename include guard.
10518 * common/queue.h: Rename include guard.
10519 * common/ptid.h: Rename include guard.
10520 * common/print-utils.h: Rename include guard.
10521 * common/preprocessor.h: Rename include guard.
10522 * common/pathstuff.h: Rename include guard.
10523 * common/observable.h: Rename include guard.
10524 * common/netstuff.h: Rename include guard.
10525 * common/job-control.h: Rename include guard.
10526 * common/host-defs.h: Rename include guard.
10527 * common/gdb_wait.h: Rename include guard.
10528 * common/gdb_vecs.h: Rename include guard.
10529 * common/gdb_unlinker.h: Rename include guard.
10530 * common/gdb_unique_ptr.h: Rename include guard.
10531 * common/gdb_tilde_expand.h: Rename include guard.
10532 * common/gdb_sys_time.h: Rename include guard.
10533 * common/gdb_string_view.h: Rename include guard.
10534 * common/gdb_splay_tree.h: Rename include guard.
10535 * common/gdb_setjmp.h: Rename include guard.
10536 * common/gdb_ref_ptr.h: Rename include guard.
10537 * common/gdb_optional.h: Rename include guard.
10538 * common/gdb_locale.h: Rename include guard.
10539 * common/gdb_assert.h: Rename include guard.
10540 * common/filtered-iterator.h: Rename include guard.
10541 * common/filestuff.h: Rename include guard.
10542 * common/fileio.h: Rename include guard.
10543 * common/environ.h: Rename include guard.
10544 * common/common-utils.h: Rename include guard.
10545 * common/common-types.h: Rename include guard.
10546 * common/common-regcache.h: Rename include guard.
10547 * common/common-inferior.h: Rename include guard.
10548 * common/common-gdbthread.h: Rename include guard.
10549 * common/common-exceptions.h: Rename include guard.
10550 * common/common-defs.h: Rename include guard.
10551 * common/common-debug.h: Rename include guard.
10552 * common/cleanups.h: Rename include guard.
10553 * common/buffer.h: Rename include guard.
10554 * common/btrace-common.h: Rename include guard.
10555 * common/break-common.h: Rename include guard.
10556 * cli/cli-utils.h: Rename include guard.
10557 * cli/cli-style.h: Rename include guard.
10558 * cli/cli-setshow.h: Rename include guard.
10559 * cli/cli-script.h: Rename include guard.
10560 * cli/cli-interp.h: Rename include guard.
10561 * cli/cli-decode.h: Rename include guard.
10562 * cli/cli-cmds.h: Rename include guard.
10563 * charset-list.h: Add include guard.
10564 * buildsym-legacy.h: Rename include guard.
10565 * bfin-tdep.h: Add include guard.
10566 * ax.h: Rename include guard.
10567 * arm-linux-tdep.h: Add include guard.
10568 * arm-fbsd-tdep.h: Add include guard.
10569 * arch/xtensa.h: Rename include guard.
10570 * arch/tic6x.h: Add include guard.
10571 * arch/i386.h: Add include guard.
10572 * arch/arm.h: Rename include guard.
10573 * arch/arm-linux.h: Rename include guard.
10574 * arch/arm-get-next-pcs.h: Rename include guard.
10575 * arch/amd64.h: Add include guard.
10576 * arch/aarch64-insn.h: Rename include guard.
10577 * arch-utils.h: Rename include guard.
10578 * annotate.h: Add include guard.
10579 * amd64-darwin-tdep.h: Rename include guard.
10580 * aarch64-linux-tdep.h: Add include guard.
10581 * aarch64-fbsd-tdep.h: Add include guard.
10582 * aarch32-linux-nat.h: Add include guard.
10583
ab9268d2
PW
105842019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10585
10586 * macrotab.c (macro_define_internal): New function that
10587 factorizes macro_define_object_internal and macro_define_function
10588 code.
10589 (macro_define_object_internal): Use macro_define_internal.
10590 (macro_define_function): Likewise.
10591
bb0da2b4
PW
105922019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10593
10594 * macrocmd.c (extract_identifier): Return
10595 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10596 callers.
10597
424eb552
JB
105982019-02-06 John Baldwin <jhb@FreeBSD.org>
10599
10600 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10601
1688cb29
TT
106022019-02-05 Tom Tromey <tom@tromey.com>
10603
10604 * target.c (target_stack::unpush): Move assertion earlier.
10605
b5eba2d8
TT
106062019-01-30 Tom Tromey <tom@tromey.com>
10607
10608 PR python/23615:
10609 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10610 (gdbpy_parse_and_eval): Likewise.
10611 * python/python-internal.h (gdbpy_allow_threads): New class.
10612
7054e2ff
JB
106132019-01-28 John Baldwin <jhb@FreeBSD.org>
10614
10615 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10616 (aarch64_fbsd_fpregmap): Move earlier.
10617 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10618 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10619 instead of individual calls to trad_frame_set_reg_addr.
10620 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10621 earlier.
10622 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10623 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10624 instead of individual calls to trad_frame_set_reg_addr.
10625
36c25ffa
AH
106262019-01-28 Alan Hayward <alan.hayward@arm.com>
10627
10628 * CONTRIBUTE: Replace contribution list with wiki link.
10629
a0707f3c
TT
106302019-01-25 Tom Tromey <tom@tromey.com>
10631
10632 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10633
0747795c
TT
106342019-01-25 Tom Tromey <tom@tromey.com>
10635
10636 * xtensa-linux-nat.c: Fix common/ includes.
10637 * xml-support.h: Fix common/ includes.
10638 * xml-support.c: Fix common/ includes.
10639 * x86-linux-nat.c: Fix common/ includes.
10640 * windows-nat.c: Fix common/ includes.
10641 * varobj.h: Fix common/ includes.
10642 * varobj.c: Fix common/ includes.
10643 * value.c: Fix common/ includes.
10644 * valops.c: Fix common/ includes.
10645 * utils.c: Fix common/ includes.
10646 * unittests/xml-utils-selftests.c: Fix common/ includes.
10647 * unittests/utils-selftests.c: Fix common/ includes.
10648 * unittests/unpack-selftests.c: Fix common/ includes.
10649 * unittests/tracepoint-selftests.c: Fix common/ includes.
10650 * unittests/style-selftests.c: Fix common/ includes.
10651 * unittests/string_view-selftests.c: Fix common/ includes.
10652 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10653 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10654 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10655 * unittests/rsp-low-selftests.c: Fix common/ includes.
10656 * unittests/parse-connection-spec-selftests.c: Fix common/
10657 includes.
10658 * unittests/optional-selftests.c: Fix common/ includes.
10659 * unittests/offset-type-selftests.c: Fix common/ includes.
10660 * unittests/observable-selftests.c: Fix common/ includes.
10661 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10662 * unittests/memrange-selftests.c: Fix common/ includes.
10663 * unittests/memory-map-selftests.c: Fix common/ includes.
10664 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10665 * unittests/function-view-selftests.c: Fix common/ includes.
10666 * unittests/environ-selftests.c: Fix common/ includes.
10667 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10668 * unittests/common-utils-selftests.c: Fix common/ includes.
10669 * unittests/cli-utils-selftests.c: Fix common/ includes.
10670 * unittests/array-view-selftests.c: Fix common/ includes.
10671 * ui-file.c: Fix common/ includes.
10672 * tui/tui-io.c: Fix common/ includes.
10673 * tracepoint.h: Fix common/ includes.
10674 * tracepoint.c: Fix common/ includes.
10675 * tracefile-tfile.c: Fix common/ includes.
10676 * top.h: Fix common/ includes.
10677 * top.c: Fix common/ includes.
10678 * thread.c: Fix common/ includes.
10679 * target/waitstatus.h: Fix common/ includes.
10680 * target/waitstatus.c: Fix common/ includes.
10681 * target.h: Fix common/ includes.
10682 * target.c: Fix common/ includes.
10683 * target-memory.c: Fix common/ includes.
10684 * target-descriptions.c: Fix common/ includes.
10685 * symtab.h: Fix common/ includes.
10686 * symfile.c: Fix common/ includes.
10687 * stap-probe.c: Fix common/ includes.
10688 * spu-linux-nat.c: Fix common/ includes.
10689 * sparc-nat.c: Fix common/ includes.
10690 * source.c: Fix common/ includes.
10691 * solib.c: Fix common/ includes.
10692 * solib-target.c: Fix common/ includes.
10693 * ser-unix.c: Fix common/ includes.
10694 * ser-tcp.c: Fix common/ includes.
10695 * ser-pipe.c: Fix common/ includes.
10696 * ser-base.c: Fix common/ includes.
10697 * selftest-arch.c: Fix common/ includes.
10698 * s12z-tdep.c: Fix common/ includes.
10699 * rust-exp.y: Fix common/ includes.
10700 * rs6000-aix-tdep.c: Fix common/ includes.
10701 * riscv-tdep.c: Fix common/ includes.
10702 * remote.c: Fix common/ includes.
10703 * remote-notif.h: Fix common/ includes.
10704 * remote-fileio.h: Fix common/ includes.
10705 * remote-fileio.c: Fix common/ includes.
10706 * regcache.h: Fix common/ includes.
10707 * regcache.c: Fix common/ includes.
10708 * record-btrace.c: Fix common/ includes.
10709 * python/python.c: Fix common/ includes.
10710 * python/py-type.c: Fix common/ includes.
10711 * python/py-inferior.c: Fix common/ includes.
10712 * progspace.h: Fix common/ includes.
10713 * producer.c: Fix common/ includes.
10714 * procfs.c: Fix common/ includes.
10715 * proc-api.c: Fix common/ includes.
10716 * printcmd.c: Fix common/ includes.
10717 * ppc-linux-nat.c: Fix common/ includes.
10718 * parser-defs.h: Fix common/ includes.
10719 * osdata.c: Fix common/ includes.
10720 * obsd-nat.c: Fix common/ includes.
10721 * nat/x86-linux.c: Fix common/ includes.
10722 * nat/x86-linux-dregs.c: Fix common/ includes.
10723 * nat/x86-dregs.h: Fix common/ includes.
10724 * nat/x86-dregs.c: Fix common/ includes.
10725 * nat/ppc-linux.c: Fix common/ includes.
10726 * nat/mips-linux-watch.h: Fix common/ includes.
10727 * nat/mips-linux-watch.c: Fix common/ includes.
10728 * nat/linux-waitpid.c: Fix common/ includes.
10729 * nat/linux-ptrace.h: Fix common/ includes.
10730 * nat/linux-ptrace.c: Fix common/ includes.
10731 * nat/linux-procfs.c: Fix common/ includes.
10732 * nat/linux-personality.c: Fix common/ includes.
10733 * nat/linux-osdata.c: Fix common/ includes.
10734 * nat/linux-namespaces.c: Fix common/ includes.
10735 * nat/linux-btrace.h: Fix common/ includes.
10736 * nat/linux-btrace.c: Fix common/ includes.
10737 * nat/fork-inferior.c: Fix common/ includes.
10738 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10739 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10740 * nat/aarch64-linux.c: Fix common/ includes.
10741 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10742 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10743 * namespace.h: Fix common/ includes.
10744 * mips-linux-tdep.c: Fix common/ includes.
10745 * minsyms.c: Fix common/ includes.
10746 * mi/mi-parse.h: Fix common/ includes.
10747 * mi/mi-main.c: Fix common/ includes.
10748 * mi/mi-cmd-env.c: Fix common/ includes.
10749 * memrange.h: Fix common/ includes.
10750 * memattr.c: Fix common/ includes.
10751 * maint.h: Fix common/ includes.
10752 * maint.c: Fix common/ includes.
10753 * main.c: Fix common/ includes.
10754 * machoread.c: Fix common/ includes.
10755 * location.c: Fix common/ includes.
10756 * linux-thread-db.c: Fix common/ includes.
10757 * linux-nat.c: Fix common/ includes.
10758 * linux-fork.c: Fix common/ includes.
10759 * inline-frame.c: Fix common/ includes.
10760 * infrun.c: Fix common/ includes.
10761 * inflow.c: Fix common/ includes.
10762 * inferior.h: Fix common/ includes.
10763 * inferior.c: Fix common/ includes.
10764 * infcmd.c: Fix common/ includes.
10765 * inf-ptrace.c: Fix common/ includes.
10766 * inf-child.c: Fix common/ includes.
10767 * ia64-linux-nat.c: Fix common/ includes.
10768 * i387-tdep.c: Fix common/ includes.
10769 * i386-tdep.c: Fix common/ includes.
10770 * i386-linux-tdep.c: Fix common/ includes.
10771 * i386-linux-nat.c: Fix common/ includes.
10772 * i386-go32-tdep.c: Fix common/ includes.
10773 * i386-fbsd-tdep.c: Fix common/ includes.
10774 * i386-fbsd-nat.c: Fix common/ includes.
10775 * guile/scm-type.c: Fix common/ includes.
10776 * guile/guile.c: Fix common/ includes.
10777 * go32-nat.c: Fix common/ includes.
10778 * gnu-nat.c: Fix common/ includes.
10779 * gdbthread.h: Fix common/ includes.
10780 * gdbarch-selftests.c: Fix common/ includes.
10781 * gdb_usleep.c: Fix common/ includes.
10782 * gdb_select.h: Fix common/ includes.
10783 * gdb_bfd.c: Fix common/ includes.
10784 * gcore.c: Fix common/ includes.
10785 * fork-child.c: Fix common/ includes.
10786 * findvar.c: Fix common/ includes.
10787 * fbsd-nat.c: Fix common/ includes.
10788 * event-top.c: Fix common/ includes.
10789 * event-loop.c: Fix common/ includes.
10790 * dwarf2read.c: Fix common/ includes.
10791 * dwarf2loc.c: Fix common/ includes.
10792 * dwarf2-frame.c: Fix common/ includes.
10793 * dwarf-index-cache.c: Fix common/ includes.
10794 * dtrace-probe.c: Fix common/ includes.
10795 * disasm-selftests.c: Fix common/ includes.
10796 * defs.h: Fix common/ includes.
10797 * csky-tdep.c: Fix common/ includes.
10798 * cp-valprint.c: Fix common/ includes.
10799 * cp-support.h: Fix common/ includes.
10800 * cp-support.c: Fix common/ includes.
10801 * corelow.c: Fix common/ includes.
10802 * completer.h: Fix common/ includes.
10803 * completer.c: Fix common/ includes.
10804 * compile/compile.c: Fix common/ includes.
10805 * compile/compile-loc2c.c: Fix common/ includes.
10806 * compile/compile-cplus-types.c: Fix common/ includes.
10807 * compile/compile-cplus-symbols.c: Fix common/ includes.
10808 * command.h: Fix common/ includes.
10809 * cli/cli-dump.c: Fix common/ includes.
10810 * cli/cli-cmds.c: Fix common/ includes.
10811 * charset.c: Fix common/ includes.
10812 * build-id.c: Fix common/ includes.
10813 * btrace.h: Fix common/ includes.
10814 * btrace.c: Fix common/ includes.
10815 * breakpoint.h: Fix common/ includes.
10816 * breakpoint.c: Fix common/ includes.
10817 * ax.h:
10818 (enum agent_op): Fix common/ includes.
10819 * ax-general.c (struct aop_map): Fix common/ includes.
10820 * ax-gdb.c: Fix common/ includes.
10821 * auxv.c: Fix common/ includes.
10822 * auto-load.c: Fix common/ includes.
10823 * arm-tdep.c: Fix common/ includes.
10824 * arch/riscv.c: Fix common/ includes.
10825 * arch/ppc-linux-common.c: Fix common/ includes.
10826 * arch/i386.c: Fix common/ includes.
10827 * arch/arm.c: Fix common/ includes.
10828 * arch/arm-linux.c: Fix common/ includes.
10829 * arch/arm-get-next-pcs.c: Fix common/ includes.
10830 * arch/amd64.c: Fix common/ includes.
10831 * arch/aarch64.c: Fix common/ includes.
10832 * arch/aarch64-insn.c: Fix common/ includes.
10833 * arch-utils.c: Fix common/ includes.
10834 * amd64-windows-tdep.c: Fix common/ includes.
10835 * amd64-tdep.c: Fix common/ includes.
10836 * amd64-sol2-tdep.c: Fix common/ includes.
10837 * amd64-obsd-tdep.c: Fix common/ includes.
10838 * amd64-nbsd-tdep.c: Fix common/ includes.
10839 * amd64-linux-tdep.c: Fix common/ includes.
10840 * amd64-linux-nat.c: Fix common/ includes.
10841 * amd64-fbsd-tdep.c: Fix common/ includes.
10842 * amd64-fbsd-nat.c: Fix common/ includes.
10843 * amd64-dicos-tdep.c: Fix common/ includes.
10844 * amd64-darwin-tdep.c: Fix common/ includes.
10845 * agent.c: Fix common/ includes.
10846 * ada-lang.h: Fix common/ includes.
10847 * ada-lang.c: Fix common/ includes.
10848 * aarch64-tdep.c: Fix common/ includes.
10849
2f5c153e
TT
108502019-01-25 Tom Tromey <tom@tromey.com>
10851
10852 * common/create-version.sh: Use common/version.h.
10853
adc6a863
PA
108542019-01-24 Pedro Alves <palves@redhat.com>
10855
10856 * infrun.c (signal_stop, signal_print, signal_program)
10857 (signal_catch, signal_pass): Now arrays instead of pointers.
10858 (update_signals_program_target, do_target_resume)
10859 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10860 * linux-nat.c (linux_nat_target::pass_signals)
10861 (linux_nat_target::create_inferior, linux_nat_target::attach):
10862 Adjust.
10863 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10864 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10865 * procfs.c (procfs_target::pass_signals): Adjust.
10866 * record-full.c (record_full_target::resume): Adjust.
10867 * remote.c (remote_target::pass_signals)
10868 (remote_target::program_signals): Adjust.
10869 * target-debug.h (target_debug_print_signals): Now takes a
10870 gdb::array_view as parameter. Adjust.
10871 * target.h (target_ops) <pass_signals, program_signals>: Replace
10872 pointer and length parameters with gdb::array_view.
10873 (target_pass_signals, target_program_signals): Likewise.
10874 * target-delegates.c: Regenerate.
10875
3046d67a
PA
108762019-01-24 Pedro Alves <palves@redhat.com>
10877
10878 * common/forward-scope-exit.h
10879 (forward_scope_exit::forward_scope_exit): Pass arguments to
10880 m_bind_function directly, instead of creating a std::bind and
10881 copying that.
10882
353229bf
AH
108832019-01-24 Alan Hayward <alan.hayward@arm.com>
10884
10885 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10886 for static members.
10887 (pass_in_v_vfp_candidate): Likewise.
10888
311dc83a
TT
108892019-01-23 Tom Tromey <tom@tromey.com>
10890 Pedro Alves <palves@redhat.com>
10891
10892 * regcache.c (class regcache_invalidator): Remove.
10893 (regcache::raw_write): Use make_scope_exit.
10894
296bd123
TT
108952019-01-23 Tom Tromey <tom@tromey.com>
10896
10897 * ui-out.h (class ui_out_emit_type): Update comment.
10898
979a0d13
TT
108992019-01-23 Tom Tromey <tom@tromey.com>
10900
10901 * infrun.c (fetch_inferior_event): Update comment.
10902
d238133d
TT
109032019-01-23 Tom Tromey <tom@tromey.com>
10904 Pedro Alves <palves@redhat.com>
10905
10906 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10907 parameter.
10908 (fetch_inferior_event): Use SCOPE_EXIT.
10909
10910
9885e6bb
TT
109112019-01-23 Tom Tromey <tom@tromey.com>
10912 Pedro Alves <palves@redhat.com>
10913
10914 * infrun.c (disable_thread_events): Delete.
10915 (stop_all_threads): Use SCOPE_EXIT.
10916
286526c1
TT
109172019-01-23 Tom Tromey <tom@tromey.com>
10918 Pedro Alves <palves@redhat.com>
10919
10920 * symfile.c: Include forward-scope-exit.h.
10921 (clear_symtab_users_cleanup): Replace forward declaration with
10922 a FORWARD_SCOPE_EXIT.
10923 (syms_from_objfile_1): Use the forward_scope_exit and
10924 gdb::optional instead of cleanup_function.
10925 (reread_symbols): Use the forward_scope_exit instead of
10926 cleanup_function.
10927 (clear_symtab_users_cleanup): Remove function.
10928
1db93f14
TT
109292019-01-23 Tom Tromey <tom@tromey.com>
10930 Pedro Alves <palves@redhat.com>
10931
10932 * linux-nat.c: Include scope-exit.h.
10933 (cleanup_target_stop): Remove.
10934 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10935 SCOPE_EXIT.
10936
2cc83d1e
TT
109372019-01-23 Tom Tromey <tom@tromey.com>
10938 Pedro Alves <palves@redhat.com>
10939
10940 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10941 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10942
694c6bf5
TT
109432019-01-23 Tom Tromey <tom@tromey.com>
10944 Andrew Burgess <andrew.burgess@embecosm.com>
10945 Pedro Alves <palves@redhat.com>
10946
10947 * infrun.c (fetch_inferior_event): Use scope_exit.
10948 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10949 * top.c (execute_command): Use scope_exit.
10950 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10951 * utils.c (do_bpstat_clear_actions_cleanup)
10952 (make_bpstat_clear_actions_cleanup): Remove.
10953
4c41382a
TT
109542019-01-23 Tom Tromey <tom@tromey.com>
10955 Pedro Alves <palves@redhat.com>
10956
10957 * infrun.c: Include "common/scope-exit.h"
10958 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10959 (wait_for_inferior): Use SCOPE_EXIT.
10960 (fetch_inferior_event): Use scope_exit.
10961
89f8fb50
TT
109622019-01-23 Tom Tromey <tom@tromey.com>
10963 Pedro Alves <palves@redhat.com>
10964
10965 * breakpoint.c (create_breakpoint): Remove cleanup.
10966
5419bdae
TT
109672019-01-23 Tom Tromey <tom@tromey.com>
10968 Andrew Burgess <andrew.burgess@embecosm.com>
10969 Pedro Alves <palves@redhat.com>
10970
e587ef42
PA
109712019-01-23 Pedro Alves <palves@redhat.com>
10972
10973 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10974
77f0e74c
PA
109752019-01-23 Pedro Alves <palves@redhat.com>
10976 Andrew Burgess <andrew.burgess@embecosm.com>
10977
10978 * gdbthread.h: Include "common/forward-scope-exit.h".
10979 (scoped_finish_thread_state): Redefine custom class in terms of
10980 forward_scope_exit.
10981
5b9b3e53
PA
109822019-01-23 Pedro Alves <palves@redhat.com>
10983 Andrew Burgess <andrew.burgess@embecosm.com>
10984
10985 * common/forward-scope-exit.h: New file.
10986
54b65c9b
PA
109872019-01-23 Pedro Alves <palves@redhat.com>
10988 Andrew Burgess <andrew.burgess@embecosm.com>
10989 Tom Tromey <tom@tromey.com>
10990
10991 * common/scope-exit.h: New file.
10992
cf08fb29
PA
109932019-01-23 Pedro Alves <palves@redhat.com>
10994
10995 * common/preprocessor.h (ESC): Rename to ...
10996 (ESC_PARENS): ... this.
10997 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10998 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10999
ae73e2e2
TT
110002019-01-23 Tom Tromey <tom@tromey.com>
11001
11002 * language.h (class scoped_switch_to_sym_language_if_auto):
11003 Initialize m_lang in both cases.
11004
6594e122
AH
110052019-01-23 Alan Hayward <alan.hayward@arm.com>
11006
11007 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11008 with XCNEW.
11009
a7c9855d
TT
110102019-01-22 Tom Tromey <tom@tromey.com>
11011
11012 * corelow.c: Do not include sys/file.h.
11013
93cc1d53
TT
110142019-01-22 Tom Tromey <tom@tromey.com>
11015
11016 * tui/tui-wingeneral.h: Include gdb_curses.h.
11017
38561778
TT
110182019-01-22 Tom Tromey <tom@tromey.com>
11019
11020 * source-cache.h (class source_cache) <get_source_lines,
11021 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11022
37b3ab5b
TT
110232019-01-22 Tom Tromey <tom@tromey.com>
11024
11025 * remote-fileio.h (struct remote_target): Declare.
11026
3fabc016
TT
110272019-01-22 Tom Tromey <tom@tromey.com>
11028
11029 * python/py-arch.c: Do not include py-ref.h.
11030 * python/py-bpevent.c: Do not include py-ref.h.
11031 * python/py-cmd.c: Do not include py-ref.h.
11032 * python/py-continueevent.c: Do not include py-ref.h.
11033 * python/py-event.h: Do not include py-ref.h.
11034 * python/py-evtregistry.c: Do not include py-ref.h.
11035 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11036 * python/py-frame.c: Do not include py-ref.h.
11037 * python/py-framefilter.c: Do not include py-ref.h.
11038 * python/py-function.c: Do not include py-ref.h.
11039 * python/py-infevents.c: Do not include py-ref.h.
11040 * python/py-linetable.c: Do not include py-ref.h.
11041 * python/py-objfile.c: Do not include py-ref.h.
11042 * python/py-param.c: Do not include py-ref.h.
11043 * python/py-prettyprint.c: Do not include py-ref.h.
11044 * python/py-progspace.c: Do not include py-ref.h.
11045 * python/py-symbol.c: Do not include py-ref.h.
11046 * python/py-symtab.c: Do not include py-ref.h.
11047 * python/py-type.c: Do not include py-ref.h.
11048 * python/py-unwind.c: Do not include py-ref.h.
11049 * python/py-utils.c: Do not include py-ref.h.
11050 * python/py-value.c: Do not include py-ref.h.
11051 * python/py-varobj.c: Do not include py-ref.h.
11052 * python/py-xmethods.c: Do not include py-ref.h.
11053 * python/python.c: Do not include py-ref.h.
11054 * varobj.c: Do not include py-ref.h.
11055
6b4d7774
TT
110562019-01-22 Tom Tromey <tom@tromey.com>
11057
11058 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11059 keyword for bcache.
11060
7af7e9b5
TT
110612019-01-22 Tom Tromey <tom@tromey.com>
11062
11063 * compile/compile-cplus-types.c: Remove a comment by #include.
11064
951d1049
TT
110652019-01-22 Tom Tromey <tom@tromey.com>
11066
11067 * compile/gcc-c-plugin.h: Include compile-internal.h.
11068
d65d5705
TT
110692019-01-22 Tom Tromey <tom@tromey.com>
11070
11071 * stabsread.c (EXTERN): Do not define.
11072 (symnum, next_symbol_text_func, processing_gcc_compilation)
11073 (within_function, global_sym_chain, global_stabs)
11074 (previous_stab_code, this_object_header_files)
11075 (n_this_object_header_files)
11076 (n_allocated_this_object_header_files): Define.
11077 * stabsread.h (EXTERN): Never define. Use "extern".
11078
b6fb1ee5
PW
110792019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11080
11081 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11082 history_value.
11083
be6d4f74
TT
110842019-01-21 Tom Tromey <tom@tromey.com>
11085
11086 * ui-out.c: Fix includes.
11087 * tui/tui-source.c: Fix includes.
11088 * target.c: Fix includes.
11089 * remote.c: Fix includes.
11090 * regcache.c: Fix includes.
11091 * python/py-block.c: Fix includes.
11092 * printcmd.c: Fix includes.
11093 * or1k-tdep.c: Fix includes.
11094 * mi/mi-main.c: Fix includes.
11095 * m32r-tdep.c: Fix includes.
11096 * csky-tdep.c: Fix includes.
11097 * compile/compile-cplus-types.c: Fix includes.
11098 * cli/cli-interp.c: Fix includes.
11099
73021deb
AH
111002019-01-21 Alan Hayward <alan.hayward@arm.com>
11101
11102 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11103 for padding.
11104
7932255d
TT
111052019-01-16 Tom Tromey <tom@tromey.com>
11106
11107 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11108 earlier.
11109 (struct objfile) <msymbols_range>: Move from top level.
11110 <msymbols>: New method.
11111 (class objfile_msymbols): Remove.
11112 * symtab.c (default_collect_symbol_completion_matches_break_on):
11113 Update.
11114 * symmisc.c (dump_msymbols): Update.
11115 * stabsread.c (scan_file_globals): Update.
11116 * objc-lang.c (info_selectors_command, info_classes_command)
11117 (find_methods): Update.
11118 * minsyms.c (find_solib_trampoline_target): Update.
11119 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11120 * coffread.c (coff_symfile_read): Update.
11121 * ada-lang.c (ada_lookup_simple_minsym)
11122 (ada_collect_symbol_completion_matches): Update.
11123
604b1bfb
TT
111242019-01-16 Tom Tromey <tom@tromey.com>
11125
11126 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11127 type. Remove no-argument constructor.
11128 <iterator::operator++>: Simplify.
11129 <begin>: Update.
11130 <end>: Use minimal_symbol_count.
11131
f252c6d5
TT
111322019-01-16 Tom Tromey <tom@tromey.com>
11133
11134 * objfiles.h (struct objfile) <psymtabs>: New method.
11135 (class objfile_psymtabs): Remove.
11136 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11137 typedef.
11138 <range>: New method.
11139 (require_partial_symbols): Change return type.
11140 * psymtab.c (require_partial_symbols)
11141 (psym_expand_symtabs_matching): Update.
11142 * mdebugread.c (parse_partial_symbols): Update.
11143 * dbxread.c (dbx_end_psymtab): Update.
11144
b669c953
TT
111452019-01-15 Tom Tromey <tom@tromey.com>
11146
11147 * symtab.c (lookup_objfile_from_block)
11148 (lookup_symbol_in_objfile_symtabs)
11149 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11150 (find_line_symtab, info_sources_command)
11151 (default_collect_symbol_completion_matches_break_on)
11152 (make_source_files_completion_list): Update.
11153 * symmisc.c (print_objfile_statistics, dump_objfile)
11154 (maintenance_print_symbols, maintenance_info_symtabs)
11155 (maintenance_check_symtabs, maintenance_info_line_tables):
11156 Update.
11157 * source.c (select_source_symtab)
11158 (forget_cached_source_info_for_objfile): Update.
11159 * objfiles.h (class objfile_compunits): Remove.
11160 (struct objfile) <compunits_range>: New typedef.
11161 (compunits): New method.
11162 * objfiles.c (objfile_relocate1): Update.
11163 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11164 * maint.c (count_symtabs_and_blocks): Update.
11165 * linespec.c (iterate_over_all_matching_symtabs): Update.
11166 * cp-support.c (add_symbol_overload_list_qualified): Update.
11167 * coffread.c (coff_symtab_read): Update.
11168 * ada-lang.c (add_nonlocal_symbols)
11169 (ada_collect_symbol_completion_matches)
11170 (ada_add_global_exceptions): Update.
11171
7e955d83
TT
111722019-01-15 Tom Tromey <tom@tromey.com>
11173
11174 * progspace.h (program_space) <objfiles_safe_range>: New
11175 typedef.
11176 <objfiles_safe>: New method.
11177 * objfiles.h (class all_objfiles_safe): Remove.
11178 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11179 * jit.c (jit_inferior_exit_hook): Update.
11180
2030c079
TT
111812019-01-17 Tom Tromey <tom@tromey.com>
11182
11183 * progspace.h (program_space) <objfiles_range>: New typedef.
11184 <objfiles>: New method.
11185 <objfiles_head>: Rename from objfiles.
11186 (object_files): Update.
11187 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11188 * guile/scm-pretty-print.c
11189 (ppscm_find_pretty_printer_from_objfiles): Update.
11190 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11191 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11192 Update.
11193 * python/py-progspace.c (pspy_get_objfiles): Update.
11194 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11195 Update.
11196 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11197 (objfpy_lookup_objfile_by_build_id): Update.
11198 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11199 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11200 Update.
11201 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11202 (expand_symtab_containing_pc, lookup_objfile_from_block)
11203 (lookup_static_symbol, basic_lookup_transparent_type)
11204 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11205 (find_line_symtab, info_sources_command)
11206 (default_collect_symbol_completion_matches_break_on)
11207 (make_source_files_completion_list, find_main_name): Update.
11208 * symmisc.c (print_symbol_bcache_statistics)
11209 (print_objfile_statistics, maintenance_print_symbols)
11210 (maintenance_print_msymbols, maintenance_print_objfiles)
11211 (maintenance_info_symtabs, maintenance_check_symtabs)
11212 (maintenance_expand_symtabs, maintenance_info_line_tables):
11213 Update.
11214 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11215 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11216 (map_overlay_command, unmap_overlay_command)
11217 (simple_overlay_update, expand_symtabs_matching)
11218 (map_symbol_filenames): Update.
11219 * symfile-debug.c (set_debug_symfile): Update.
11220 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11221 Update.
11222 * source.c (select_source_symtab, forget_cached_source_info):
11223 Update.
11224 * solib.c (solib_read_symbols): Update.
11225 * solib-spu.c (append_ocl_sos): Update.
11226 * psymtab.c (maintenance_print_psymbols)
11227 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11228 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11229 * printcmd.c (info_symbol_command): Update.
11230 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11231 Update.
11232 * objfiles.h (class all_objfiles): Remove.
11233 * objfiles.c (have_partial_symbols, have_full_symbols)
11234 (have_minimal_symbols, qsort_cmp, update_section_map)
11235 (shared_objfile_contains_address_p)
11236 (default_iterate_over_objfiles_in_search_order): Update.
11237 * objc-lang.c (info_selectors_command, info_classes_command)
11238 (find_methods): Update.
11239 * minsyms.c (find_solib_trampoline_target): Update.
11240 * maint.c (maintenance_info_sections)
11241 (maintenance_translate_address, count_symtabs_and_blocks):
11242 Update.
11243 * main.c (captured_main_1): Update.
11244 * linux-thread-db.c (try_thread_db_load_from_pdir)
11245 (has_libpthread): Update.
11246 * linespec.c (iterate_over_all_matching_symtabs)
11247 (search_minsyms_for_name): Update.
11248 * jit.c (jit_find_objf_with_entry_addr): Update.
11249 * hppa-tdep.c (find_unwind_entry)
11250 (hppa_lookup_stub_minimal_symbol): Update.
11251 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11252 Update.
11253 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11254 (elf_gnu_ifunc_resolve_by_got): Update.
11255 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11256 * dwarf-index-write.c (save_gdb_index_command): Update.
11257 * cp-support.c (add_symbol_overload_list_qualified): Update.
11258 * breakpoint.c (create_overlay_event_breakpoint)
11259 (create_longjmp_master_breakpoint)
11260 (create_std_terminate_master_breakpoint)
11261 (create_exception_master_breakpoint): Update.
11262 * blockframe.c (find_pc_partial_function): Update.
11263 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11264 (ada_collect_symbol_completion_matches)
11265 (ada_add_global_exceptions): Update.
11266
776489e0
TT
112672019-01-17 Tom Tromey <tom@tromey.com>
11268
11269 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11270 declare VEC.
11271 (solib_target_parse_libraries): Change return type.
11272 (library_list_start_segment, library_list_start_section)
11273 (library_list_end_library, library_list_start_library); Update.
11274 (solib_target_free_library_list): Remove.
11275 (solib_target_parse_libraries): Remove cleanup. Change return
11276 type.
11277 (solib_target_current_sos): Update.
11278
6471e7d2
TT
112792019-01-17 Tom Tromey <tromey@bapiya>
11280
11281 * valprint.c: Replace "the the" with "the".
11282 * symtab.c: Replace "the the" with "the".
11283 * solib.c: Replace "the the" with "the".
11284 * solib-dsbt.c: Replace "the the" with "the".
11285 * linespec.c: Replace "the the" with "the".
11286 * dwarf2loc.h: Replace "the the" with "the".
11287 * amd64-windows-tdep.c: Replace "the the" with "the".
11288 * aarch64-tdep.c: Replace "the the" with "the".
11289
c24bdb02
KS
112902019-01-16 Keith Seitz <keiths@redhat.com>
11291
11292 PR gdb/23773
11293 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11294 <builder>: Rename to ..
11295 <m_builder>: ... this and make private.
11296 (dwarf2_cu::get_builder): New method. Change all users of
11297 `builder' to use this method.
11298 (dwarf2_start_symtab): Move to ...
11299 (dwarf2_cu::start_symtab): ... here. Update all callers
11300 (setup_type_unit_groups): Move to ...
11301 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11302 callers.
11303 (dwarf2_cu::reset_builder): New method.
11304 (process_full_compunit, process_full_type_unit): Use
11305 dwarf2_cu::reset_builder.
11306 (follow_die_offset): Record the ancestor CU if it is different
11307 from the followed DIE's CU.
11308 (follow_die_sig_1): Likewise.
11309
8d64371b
TT
113102019-01-15 Tom Tromey <tom@tromey.com>
11311
11312 * remote.c (class remote_state) <buf>: Now a char_vector.
11313 <buf_size>: Remove.
11314 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11315 parameter.
11316 (remote_target::getpkt_or_notif_sane_1)
11317 (remote_target::getpkt_sane)
11318 (remote_target::getpkt_or_notif_sane): Likewise.
11319 (class remote_target) <putpkt>: New overload.
11320 (remote_target::read_frame): Change type of "buf_p". Remove
11321 sizeof_p parameter.
11322 (packet_ok): New overload.
11323 (packet_check_result): New overload.
11324 Update all uses.
11325
bb277751
TT
113262019-01-14 Tom Tromey <tom@tromey.com>
11327
11328 * remote-notif.c (handle_notification, remote_notif_ack)
11329 (remote_notif_parse): Make "buf" const.
11330 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11331 const.
11332 (remote_notif_parse, remote_notif_ack, handle_notification):
11333 Likewise.
11334 * remote.c (remote_notif_stop_parse): Make "buf" const.
11335 (remote_target::remote_parse_stop_reply): Make "buf" const.
11336 (remote_notif_stop_ack): Make "buf" const.
11337
05be00a8
TT
113382019-01-14 Tom Tromey <tom@tromey.com>
11339
11340 * remote.c (remote_console_output): Make parameter const.
11341
491adeca
TT
113422019-01-14 Tom Tromey <tom@tromey.com>
11343
11344 * target-debug.h (target_debug_print_signals): Constify.
11345 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11346 * procfs.c (procfs_target::pass_signals): Update.
11347 * linux-nat.c (linux_nat_target::pass_signals): Update.
11348 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11349 * target-delegates.c: Rebuild.
11350 * remote.c (remote_target::program_signals): Update.
11351 (remote_target::pass_signals): Update.
11352 * target.c (target_pass_signals): Constify argument.
11353 (target_program_signals): Likewise.
11354 * target.h (struct target_ops) <pass_signals, program_signals>:
11355 Constify argument.
11356 (target_pass_signals, target_program_signals): Constify argument.
11357
bbd94648
TT
113582019-01-14 Tom Tromey <tom@tromey.com>
11359
11360 PR tui/28819:
11361 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11362
6f072a10
PFC
113632019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11364
11365 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11366 field.
11367 * rs6000-tdep.c: Include reggroups.h.
11368 (IS_V_ALIAS_PSEUDOREG): Define.
11369 (rs6000_register_name): Return names for the "vX" aliases.
11370 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11371 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11372 aliases. Call default_register_reggroup_p for all other
11373 pseudo-registers.
11374 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11375 New functions.
11376 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11377 Handle "vX" aliases.
11378 (v_alias_pseudo_register_collect): New function.
11379 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11380 (rs6000_gdbarch_init): Initialize "vX" aliases as
11381 pseudo-registers. Restore registration of
11382 rs6000_pseudo_register_reggroup_p with
11383 set_tdesc_pseudo_register_reggroup_p.
11384
1a782351
MF
113852019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11386
11387 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11388 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11389 set_gdbarch_num_pseudo_regs.
11390
d73cff18
PW
113912019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11392
11393 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11394 Remove arg prefixname, add do_set and do_show.
11395 Add member functions set_list and show_list.
11396 * cli/cli-style.c (class cli_style_option): Update accordingly.
11397 (style_set_list): Move to file scope.
11398 (style_show_list): Likewise.
11399 (set_style): Call help_list.
11400 (show_style): Call cmd_show_list.
11401 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11402 Update to use the new macro.
11403
60a90376
JB
114042019-10-12 Joel Brobecker <brobecker@adacore.com>
11405
11406 * ada-lang.c (_initialize_ada_language): Expand the help text
11407 for the "catch exception" command.
11408
9d7c67bf
PW
114092019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11410
11411 * symtab.c (matching_obj_sections): Initialize obj,
11412 declare it closer to its usage.
11413
7cf47dc4
TT
114142019-01-10 Tom Tromey <tom@tromey.com>
11415
11416 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11417 (basic_inf_threads_range): Remove.
11418 (inf_threads_range, inf_non_exited_threads_range)
11419 (safe_inf_threads_range): Use next_adapter.
11420
d3cb6808
KS
114212019-01-10 Keith Seitz <keiths@redhat.com>
11422
11423 PR gdb/23712
11424 PR symtab/23010
11425 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11426 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11427
63a20375
KS
114282019-01-10 Keith Seitz <keiths@redhat.com>
11429
11430 PR gdb/23712
11431 PR symtab/23010
11432 * dictionary.c (pending_to_vector): Remove.
11433 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11434 Remove _1 suffix, replacing functions of the same name. Update
11435 all callers.
11436 (dict_create_hashed, dict_create_hashed_expandable)
11437 (dict_create_linear, dict_create_linear_expandable, dict_free)
11438 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11439 Make functions static.
11440
b026f593
KS
114412019-01-10 Keith Seitz <keiths@redhat.com>
11442
11443 PR gdb/23712
11444 PR symtab/23010
11445 * dictionary.h (struct dictionary): Replace declaration with
11446 multidictionary.
11447 (dict_create_hashed, dict_create_hashed_expandable)
11448 (dict_create_linear, dict_create_linear_expandable)
11449 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11450 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11451 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11452 taking multidictionary argument.
11453 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11454 * block.h (struct block) <dict>: Change to multidictionary
11455 and rename `multidict'.
11456 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11457 symmisc.c: Update all dictionary references to multidictionary.
11458
c7748ee9
KS
114592019-01-10 Keith Seitz <keiths@redhat.com>
11460
11461 PR gdb/23712
11462 PR symtab/23010
11463 * dictionary.c: Include unordered_map.
11464 (pending_to_vector): New function.
11465 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11466 Rewrite the non-"_1" functions to take vector instead
11467 of linked list.
11468 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11469 "new" _1 versions of the same name.
11470 (multidictionary): Define.
11471 (std::hash<enum language): New definition.
11472 (collate_pending_symbols_by_language, mdict_create_hashed)
11473 (mdict_create_hashed_expandable, mdict_create_linear)
11474 (mdict_create_linear_expandable, mdict_free)
11475 (find_language_dictionary, create_new_language_dictionary)
11476 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11477 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11478 (mdict_size, mdict_empty): New functions.
11479 * dictionary.h (mdict_iterator): Define.
11480
67aa1f3c
PA
114812019-01-10 Pedro Alves <palves@redhat.com>
11482
11483 * breakpoint.c (read_uploaded_action)
11484 (create_tracepoint_from_upload): Adjust to use
11485 gdb::unique_xmalloc_ptr.
11486 * ctf.c (ctf_write_uploaded_tp):
11487 (SET_ARRAY_FIELD): Use emplace_back.
11488 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11489 * tracefile-tfile.c (tfile_write_uploaded_tp):
11490 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11491 gdb::unique_xmalloc_ptr.
11492 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11493 at_string, cond_string, cmd_strings>: Replace char pointers
11494 with gdb::unique_xmalloc_ptr.
11495
2f667667
PA
114962019-01-10 Pedro Alves <palves@redhat.com>
11497
11498 * solib-target.c (library_list_start_library): Don't xstrdup name.
11499
36cb7237
PA
115002019-01-10 Pedro Alves <palves@redhat.com>
11501
11502 * mdebugread.c (parse_partial_symbols): Use
11503 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11504
da584958
AB
115052019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11506
11507 * linux-fork.c (scoped_switch_fork_info)
11508 <~scoped_switch_fork_info>: Fix incorrect variable name.
11509
1ef8573c
AB
115102019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11511
11512 * linux-fork.c (scoped_switch_fork_info)
11513 <scoped_switch_fork_info>: Make explicit.
11514 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11515
8d7bcccb
TT
115162019-01-10 Tom Tromey <tom@tromey.com>
11517
11518 * objfiles.h (objfile::reset_psymtabs): Update.
11519 * objfiles.c (objfile::objfile): Update.
11520 * psymtab.h (psymtab_storage::obstack): Update.
11521 (psymtab_storage::m_obstack): Use gdb::optional.
11522 (class psymtab_storage): Update comment. Remove objfile
11523 parameter.
11524 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11525
b596a3c7
TT
115262019-01-10 Tom Tromey <tom@tromey.com>
11527
11528 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11529 <free_psymtabs>: Now private.
11530 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11531 (allocate_psymtab): Use new method.
11532
a9342b62
TT
115332019-01-10 Tom Tromey <tom@tromey.com>
11534
11535 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11536 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11537 * mdebugread.c (parse_partial_symbols): Use
11538 allocate_dependencies.
11539 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11540 allocate_dependencies.
11541 (process_psymtab_comp_unit_reader)
11542 (build_type_psymtab_dependencies): Likewise.
11543 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11544
5af70966
TT
115452019-01-10 Tom Tromey <tom@tromey.com>
11546
11547 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11548 PSYMBOL_SET_LANGUAGE.
11549 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11550
5923a04c
TT
115512019-01-10 Tom Tromey <tom@tromey.com>
11552
11553 * psymtab.h (psymtab_storage::obstack): New method.
11554 <m_obstack>: Rename from obstack; now private.
11555 * psymtab.c (psymtab_storage): Update.
11556 * dwarf2read.c (create_addrmap_from_index)
11557 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11558 Update.
11559
6d6a12bf
TT
115602019-01-10 Tom Tromey <tom@tromey.com>
11561
11562 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11563 * objfiles.h (objfile::reset_psymtabs): New method.
11564
d320c2b5
TT
115652019-01-10 Tom Tromey <tom@tromey.com>
11566
11567 * symmisc.c (print_symbol_bcache_statistics): Update.
11568 (print_objfile_statistics): Update.
11569 * symfile.c (reread_symbols): Update.
11570 * psymtab.h (class psymtab_storage): New.
11571 * psymtab.c (psymtab_storage): New constructor.
11572 (~psymtab_storage): New destructor.
11573 (require_partial_symbols): Update.
11574 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11575 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11576 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11577 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11578 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11579 (start_psymtab_common, end_psymtab_common)
11580 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11581 (allocate_psymtab): Update.
11582 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11583 Update.
11584 (dump_psymtab_addrmap, maintenance_print_psymbols)
11585 (maintenance_check_psymtabs): Update.
11586 (class objfile_psymtabs): Move to objfiles.h.
11587 * psympriv.h (discard_psymtab): Now inline.
11588 (psymtab_discarder::psymtab_discarder): Update.
11589 (psymtab_discarder::~psymtab_discarder): Update.
11590 (ALL_OBJFILE_PSYMTABS): Rewrite.
11591 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11592 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11593 Remove fields.
11594 <partial_symtabs>: New field.
11595 (class objfile_psymtabs): Move from psymtab.h. Update.
11596 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11597 psymbol_cache.
11598 (objfile::~objfile): Don't destroy psymbol_cache.
11599 * mdebugread.c (parse_partial_symbols): Update.
11600 * dwarf2read.c (create_addrmap_from_index)
11601 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11602 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11603 (add_partial_subprogram, dwarf2_ranges_read): Update.
11604 * dwarf-index-write.c (write_address_map)
11605 (write_one_signatured_type, recursively_write_psymbols)
11606 (class debug_names, class debug_names, write_psymtabs_to_index):
11607 Update.
11608
1d94a5a3
TT
116092019-01-10 Tom Tromey <tom@tromey.com>
11610
11611 * symtab.h (SYMBOL_SET_NAMES): Update.
11612 (symbol_set_names): Update.
11613 (MSYMBOL_SET_NAMES): Update.
11614 * symtab.c (symbol_set_names): Change argument to be an
11615 objfile_per_bfd_storage.
11616 * psymtab.c (add_psymbol_to_bcache): Update.
11617 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11618
0f14768a
TT
116192019-01-10 Tom Tromey <tom@tromey.com>
11620
11621 * symtab.c (create_demangled_names_hash): Change argument to be an
11622 objfile_per_bfd_storage.
11623 (symbol_set_names): Update.
11624
6eee24ce
TT
116252019-01-10 Tom Tromey <tom@tromey.com>
11626
11627 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11628 init_psymbol_list.
11629 * psymtab.c (init_psymbol_list): Do nothing if already called.
11630 * psympriv.h (init_psymbol_list): Add comment.
11631 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11632 init_psymbol_list.
11633 * dbxread.c (dbx_symfile_read): Unconditionally call
11634 init_psymbol_list.
11635
75aedd27
TT
116362019-01-10 Tom Tromey <tom@tromey.com>
11637
11638 * xcoffread.c (scan_xcoff_symtab): Update.
11639 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11640 "where".
11641 * mdebugread.c (parse_partial_symbols)
11642 (handle_psymbol_enumerators): Update.
11643 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11644 * dbxread.c (read_dbx_symtab): Update.
11645 * psympriv.h (psymbol_placement): New enum.
11646 (add_psymbol_to_list): Update.
11647
939652a5
TT
116482019-01-10 Tom Tromey <tom@tromey.com>
11649
11650 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11651 static_psymbols parameters.
11652 (scan_xcoff_symtab): Update.
11653 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11654 static_psymbols parameters.
11655 * psympriv.h (start_psymtab_common): Update.
11656 * mdebugread.c (parse_partial_symbols): Update.
11657 * dwarf2read.c (create_partial_symtab): Update.
11658 * dbxread.c (read_dbx_symtab): Update.
11659 (start_psymtab): Remove global_psymbols and static_psymbols
11660 parameters.
11661
baa62830
TT
116622019-01-10 Tom Tromey <tom@tromey.com>
11663
11664 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11665 * psymtab.c (allocate_psymtab): Add comment.
11666 * psympriv.h (allocate_psymtab): Add comment.
11667 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11668 initializations.
11669 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11670
0e8f53ba
TT
116712019-01-10 Tom Tromey <tom@tromey.com>
11672
11673 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11674 Don't declare.
11675 * mipsread.c: Include mdebugread.h.
11676 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11677 Declare.
11678 * elfread.c: Include mdebugread.h.
11679
b22a7c6a
TT
116802019-01-09 Tom Tromey <tom@tromey.com>
11681
11682 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11683 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11684 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11685 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11686 (psym_lookup_symbol, psym_find_last_source_symtab)
11687 (psym_forget_cached_source_info, psym_print_stats)
11688 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11689 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11690 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11691 (psym_find_compunit_symtab_by_address)
11692 (maintenance_print_psymbols, maintenance_info_psymtabs)
11693 (maintenance_check_psymtabs): Use ranged for.
11694 * psymtab.h (class objfile_psymtabs): New.
11695 (require_partial_symbols): Return objfile_psymtabs.
11696 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11697
3b9d3ac2
TT
116982019-01-09 Tom Tromey <tom@tromey.com>
11699
11700 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11701 (find_pc_mapped_section, list_overlays_command)
11702 (map_overlay_command, unmap_overlay_command)
11703 (simple_overlay_update): Use all_objfiles.
11704 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11705 * printcmd.c (info_symbol_command): Use all_objfiles.
11706 * objfiles.h (ALL_OBJSECTIONS): Remove.
11707 * maint.c (maintenance_translate_address): Use all_objfiles.
11708 * gcore.c (gcore_create_callback): Use all_objfiles.
11709 (objfile_find_memory_regions): Likewise.
11710
8b31193a
TT
117112019-01-09 Tom Tromey <tom@tromey.com>
11712
11713 * symtab.c (find_line_symtab, info_sources_command)
11714 (make_source_files_completion_list): Use objfile_compunits.
11715 * source.c (select_source_symtab): Use objfile_compunits.
11716 * objfiles.h (struct objfile): Update comment.
11717 (ALL_OBJFILES): Remove.
11718 (ALL_FILETABS): Remove.
11719 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11720 objfile_compunits.
11721
d5da8b3c
TT
117222019-01-09 Tom Tromey <tom@tromey.com>
11723
11724 * symmisc.c (print_objfile_statistics, dump_objfile)
11725 (maintenance_print_symbols): Use compunit_filetabs.
11726 * source.c (forget_cached_source_info_for_objfile): Use
11727 compunit_filetabs.
11728 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11729 (ALL_FILETABS): Use compunit_filetabs.
11730 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11731 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11732
5accd1a0
TT
117332019-01-09 Tom Tromey <tom@tromey.com>
11734
11735 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11736 (compunit_filetabs): New.
11737 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11738 compunit_filetabs.
11739 (info_sources_command, make_source_files_completion_list): Remove
11740 declaration.
11741 * symmisc.c (print_objfile_statistics, dump_objfile)
11742 (maintenance_print_symbols): Remove declaration.
11743 (maintenance_info_symtabs): Use compunit_filetabs.
11744 (maintenance_info_line_tables): Likewise.
11745 * source.c (select_source_symtab): Change local variable name.
11746 (forget_cached_source_info_for_objfile): Remove declaration.
11747 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11748 * objfiles.c (objfile_relocate1): Remove declaration.
11749 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11750 declaration.
11751 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11752 * coffread.c (coff_symtab_read): Remove declaration.
11753 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11754 compunit_filetabs.
11755
d8aeb77f
TT
117562019-01-09 Tom Tromey <tom@tromey.com>
11757
11758 * symtab.c (lookup_objfile_from_block)
11759 (find_pc_sect_compunit_symtab, search_symbols)
11760 (default_collect_symbol_completion_matches_break_on): Use
11761 objfile_compunits.
11762 * objfiles.h (ALL_COMPUNITS): Remove.
11763 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11764 * cp-support.c (add_symbol_overload_list_qualified): Use
11765 objfile_compunits.
11766 * ada-lang.c (ada_collect_symbol_completion_matches)
11767 (ada_add_global_exceptions): Use objfile_compunits.
11768
592553c4
TT
117692019-01-09 Tom Tromey <tom@tromey.com>
11770
11771 * source.c (select_source_symtab)
11772 (forget_cached_source_info_for_objfile): Remove declaration.
11773 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11774 declaration.
11775 * maint.c (count_symtabs_and_blocks): Remove declaration.
11776 * cp-support.c (add_symbol_overload_list_qualified): Remove
11777 declaration.
11778 * coffread.c (coff_symtab_read): Remove declaration.
11779 * symtab.c (lookup_symbol_in_objfile_symtabs)
11780 (basic_lookup_transparent_type_1): Use objfile_compunits.
11781 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11782 (info_sources_command, search_symbols)
11783 (default_collect_symbol_completion_matches_break_on)
11784 (make_source_files_completion_list): Remove declaration.
11785 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11786 (ada_collect_symbol_completion_matches)
11787 (ada_add_global_exceptions): Remove declaration.
11788 * linespec.c (iterate_over_all_matching_symtabs): Use
11789 objfile_compunits.
11790 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11791 (class objfile_compunits): New.
11792 (ALL_COMPUNITS): Use objfile_compunits.
11793 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11794 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11795 objfile_compunits.
11796 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11797
5325b9bf
TT
117982019-01-09 Tom Tromey <tom@tromey.com>
11799
11800 * symtab.c (search_symbols)
11801 (default_collect_symbol_completion_matches_break_on): Use
11802 objfile_msymbols.
11803 * ada-lang.c (ada_lookup_simple_minsym)
11804 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11805 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11806 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11807 objfile_msymbols.
11808 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11809 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11810 * objc-lang.c (find_methods): Use objfile_msymbols.
11811 (info_selectors_command, info_classes_command): Likewise.
11812 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11813 * objfiles.h (class objfile_msymbols): New.
11814 (ALL_OBJFILE_MSYMBOLS): Remove.
11815 (ALL_MSYMBOLS): Remove.
11816
cac85af2
TT
118172019-01-09 Tom Tromey <tom@tromey.com>
11818
11819 * common/next-iterator.h (next_adapter): Add Iterator template
11820 parameter.
11821 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11822 (class all_objfiles_safe): New.
11823 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11824 * objfiles.c (put_objfile_before): Update comment.
11825 (add_separate_debug_objfile): Likewise.
11826 (free_all_objfiles): Use all_objfiles_safe.
11827 (objfile_purge_solibs): Likewise.
11828
aed57c53
TT
118292019-01-09 Tom Tromey <tom@tromey.com>
11830
11831 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11832 (expand_symtab_containing_pc, lookup_static_symbol)
11833 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11834 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11835 all_objfiles.
11836 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11837 * breakpoint.c (create_overlay_event_breakpoint)
11838 (create_longjmp_master_breakpoint)
11839 (create_std_terminate_master_breakpoint)
11840 (create_exception_master_breakpoint): Use all_objfiles.
11841 * linux-thread-db.c (try_thread_db_load_from_pdir)
11842 (has_libpthread): Use all_objfiles.
11843 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11844 * linespec.c (iterate_over_all_matching_symtabs)
11845 (search_minsyms_for_name): Use all_objfiles.
11846 * maint.c (maintenance_info_sections): Use all_objfiles.
11847 * main.c (captured_main_1): Use all_objfiles.
11848 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11849 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11850 * guile/scm-pretty-print.c
11851 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11852 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11853 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11854 (maintenance_print_msymbols): Use all_objfiles.
11855 * source.c (select_source_symtab): Use all_objfiles.
11856 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11857 * symfile.c (remove_symbol_file_command)
11858 (expand_symtabs_matching, map_symbol_filenames): Use
11859 all_objfiles.
11860 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11861 all_objfiles.
11862 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11863 * objc-lang.c (find_methods): Use all_objfiles.
11864 * objfiles.c (have_partial_symbols, have_full_symbols)
11865 (have_minimal_symbols, qsort_cmp)
11866 (default_iterate_over_objfiles_in_search_order): Use
11867 all_objfiles.
11868 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11869 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11870 (maintenance_check_psymtabs): Use all_objfiles.
11871 (ALL_PSYMTABS): Remove.
11872 * compile/compile-object-run.c (do_module_cleanup): Use
11873 all_objfiles.
11874 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11875 * cp-support.c (add_symbol_overload_list_qualified): Use
11876 all_objfiles.
11877 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11878 Use all_objfiles.
11879 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11880 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11881 all_objfiles.
11882 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11883 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11884 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11885 Uses all_objfiles.
11886 * solib.c (solib_read_symbols): Use all_objfiles
11887
99d89cde
TT
118882019-01-09 Tom Tromey <tom@tromey.com>
11889
11890 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11891 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11892 all_objfiles.
11893 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11894 * symmisc.c (print_symbol_bcache_statistics)
11895 (print_objfile_statistics, maintenance_print_objfiles)
11896 (maintenance_info_symtabs, maintenance_check_symtabs)
11897 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11898 all_objfiles.
11899 * source.c (forget_cached_source_info): Use all_objfiles.
11900 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11901 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11902 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11903 * objfiles.c (update_section_map): Use all_objfiles.
11904 (shared_objfile_contains_address_p): Likewise.
11905 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11906 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11907
21708325
TT
119082019-01-09 Tom Tromey <tom@tromey.com>
11909
11910 * common/next-iterator.h: New file.
11911 * objfiles.h (class all_objfiles): New.
11912 (struct objfile_iterator): New.
11913
669e09f6
PW
119142019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11915
11916 * NEWS: Move the description of the changed "frame", "select-frame",
11917 and "info frame" commands to the Changed commands section.
11918
041be526
SM
119192019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11920
11921 * gdbtypes.c (check_stub_method_group): Remove handling of old
11922 mangling schemes.
11923 * linespec.c (find_methods): Likewise.
11924 * stabsread.c (read_member_functions): Likewise.
11925 * valops.c (search_struct_method): Likewise.
11926 (value_struct_elt_for_reference): Likewise.
11927 * NEWS: Mention this change.
11928
0e2a2133
AB
119292019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11930
11931 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11932 print_source_lines.
11933 * source.c (print_source_lines_base): Update line number check.
11934 (print_source_lines): New function.
11935 (source_lines_range::source_lines_range): New function.
11936 * source.h (class source_lines_range): New class.
11937 (print_source_lines): New declaration.
11938
1055a3b4
PW
119392019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11940
11941 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11942
cfeadda5
TT
119432019-01-08 Tom Tromey <tom@tromey.com>
11944 Simon Marchi <simon.marchi@ericsson.com>
11945
11946 PR gdb/24060
11947 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11948 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11949 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11950 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11951 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11952 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11953
583068ca
AB
119542019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11955
11956 * source.c (select_source_symtab): Move header comment to
11957 declaration in source.h.
11958 (forget_cached_source_info_for_objfile): Likewise.
11959 (forget_cached_source_info): Likewise.
11960 (identify_source_line): Likewise.
11961 * source.h (identify_source_line): Move declaration from symtab.h
11962 and add comment from source.c
11963 (print_source_lines): Likewise.
11964 (forget_cached_source_info_for_objfile): Likewise.
11965 (forget_cached_source_info): Likewise.
11966 (select_source_symtab): Likewise.
11967 (enum print_source_lines_flag): Move definition from symtab.h.
11968 * symtab.h (identify_source_line): Move declaration to source.h.
11969 (print_source_lines): Likewise.
11970 (forget_cached_source_info_for_objfile): Likewise.
11971 (forget_cached_source_info): Likewise.
11972 (select_source_symtab): Likewise.
11973 (enum print_source_lines_flag): Move definition to source.h.
11974 * tui/tui-hooks.c: Add 'source.h' include.
11975
ec98a4ad
AB
119762019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11977
11978 * source.c (print_source_lines_base): Handle requests to print
11979 reverse line number sequences, and guard against empty lines
11980 string.
11981
62ea19c1
AB
119822019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11983
11984 * source.c (print_source_lines_base): Fix skip of '\r' if next
11985 character is '\n'.
11986
9d30e1fd
TT
119872019-01-06 Tom Tromey <tom@tromey.com>
11988
11989 * c-exp.y (struct c_parse_state) <macro_original_text,
11990 expansion_obstack>: New member.
11991 (macro_original_text, expansion_obstack): Remove globals.
11992 (scan_macro_expansion, scanning_macro_expansion)
11993 (finished_macro_expansion): Update.
11994 (scan_macro_cleanup): Remove.
11995 (yylex, c_parse): Update.
11996
c65bac38
TT
119972019-01-06 Tom Tromey <tom@tromey.com>
11998
11999 * c-exp.y (struct c_parse_state) <strings>: New member.
12000 (operator_stoken): Update.
12001
02e12e38
TT
120022019-01-06 Tom Tromey <tom@tromey.com>
12003
12004 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12005 (union type_stack_elt) <typelist_val>: Now a pointer to
12006 std::vector.
12007 (type_stack_cleanup): Don't declare.
12008 (push_typelist): Update.
12009 * parse.c (pop_typelist): Return a std::vector.
12010 (push_typelist): Take a std::vector.
12011 (follow_types): Update. Do not free args.
12012 (type_stack_cleanup): Remove.
12013 * c-exp.y (struct c_parse_state): New.
12014 (cpstate): New global.
12015 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12016 (nonempty_typelist): Update.
12017 (func_mod): Create a new vector.
12018 (c_parse): Create a c_parse_state.
12019 (check_parameter_typelist): Do not delete params.
12020 (function_method): Update. Do not delete type_list.
12021
f097f5ad
TT
120222019-01-06 Tom Tromey <tom@tromey.com>
12023
12024 PR gdb/28155:
12025 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12026 check_typedef.
12027 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12028 (print_return_value): Likewise.
12029
d2adf9f1
TT
120302019-01-05 Tom Tromey <tom@tromey.com>
12031
12032 * contrib/cleanup_check.py: Remove.
12033 * contrib/gcc-with-excheck: Remove.
12034 * contrib/exsummary.py: Remove.
12035 * contrib/excheck.py: Remove.
12036
2eab46b1
JB
120372019-01-05 Joel Brobecker <brobecker@adacore.com>
12038
12039 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12040 NULL. Initialize tpprev to NULL instead of assigning it
12041 to NULL on the next statement.
12042 * windows-nat.c (windows_delete_thread): Remove check for
12043 main_thread_id before printing thread exit notifications.
12044 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12045 Remove thread ID check against main_thread_id.
12046 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12047 windows_delete_thread.
12048 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12049
48c5e7e2
TT
120502019-01-04 Tom Tromey <tom@tromey.com>
12051
12052 * compile/compile.c (_initialize_compile): Use upper case for
12053 metasyntactic variables.
12054 * symmisc.c (_initialize_symmisc): Use upper case for
12055 metasyntactic variables.
12056 * psymtab.c (_initialize_psymtab): Use upper case for
12057 metasyntactic variables.
12058 * demangle.c (demangle_command): Use upper case for metasyntactic
12059 variables.
12060 (_initialize_demangler): Likewise.
12061 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12062 variables.
12063
986041cd
TT
120642019-01-03 Tom Tromey <tom@tromey.com>
12065
12066 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12067
7c711119
TT
120682019-01-03 Tom Tromey <tom@tromey.com>
12069
12070 * python/py-symtab.c (salpy_str): Update.
12071 (struct salpy_sal_object) <symtab>: Now a PyObject.
12072 (salpy_dealloc): Update.
12073 (del_objfile_sal): Use gdbpy_ref.
12074
1b20edf0
TT
120752019-01-03 Tom Tromey <tom@tromey.com>
12076
12077 * python/py-type.c (convert_field): Use new_reference. Return
12078 gdbpy_ref.
12079 (make_fielditem): Return gdbpy_ref.
12080 (typy_fields): Update.
12081 (typy_getitem): Update.
12082 (field_name): Return gdbpy_ref. Use new_reference.
12083 (typy_iterator_iternext): Update.
12084
ea41325b
TT
120852019-01-03 Tom Tromey <tom@tromey.com>
12086
12087 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12088
2a3c71d6
TT
120892019-01-03 Tom Tromey <tom@tromey.com>
12090
12091 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12092 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12093 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12094 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12095 (pspy_set_type_printers): Likewise.
12096 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12097 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12098 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12099 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12100 (objfpy_set_type_printers): Likewise.
12101
5c329e6a
TT
121022019-01-03 Tom Tromey <tom@tromey.com>
12103
12104 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12105 (gdbpy_print_stack): Use gdbpy_err_fetch.
12106 * python/python-internal.h (class gdbpy_err_fetch): New class.
12107 (class gdbpy_enter) <m_error_type, m_error_value,
12108 m_error_traceback>: Remove.
12109 <m_error>: New member.
12110 (gdbpy_exception_to_string): Don't declare.
12111 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12112 * python/py-value.c (convert_value_from_python): Use
12113 gdbpy_err_fetch.
12114 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12115 gdbpy_exception_to_string.
12116 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12117 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12118 gdbpy_err_fetch.
12119
169bb27b
AB
121202019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12121
12122 * linux-nat.c (delete_lwp_cleanup): Delete.
12123 (struct lwp_deleter): New struct.
12124 (lwp_info_up): New typedef.
12125 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12126 lwp_info_up.
12127
a07c8880
AB
121282019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12129
12130 * linux-fork.c (class scoped_switch_fork_info): New class.
12131 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12132
26089c49
AB
121332019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12134
12135 * valops.c (find_overload_match): Remove use of null_cleanup, and
12136 calls to do_cleanups.
12137
06d3e5b0
AB
121382019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12139
12140 * compile/compile-cplus-types.c
12141 (compile_cplus_instance::decl_name): Handle changes to
12142 cp_func_name.
12143 * cp-support.c (cp_func_name): Update header comment, update
12144 return type.
12145 * cp-support.h (cp_func_name): Update return type in declaration.
12146 * valops.c (find_overload_match): Move temp_func local to top
12147 level of function and change its type. Use temp_func to hold and
12148 delete temporary string obtained from cp_func_name.
12149
66644cd3
AB
121502019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12151
12152 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12153 gdb::char_vector, remove cleanup, and update uses of `msg`.
12154
592d8c0a
JW
121552019-01-03 Jim Wilson <jimw@sifive.com>
12156
12157 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12158
c55d06ec
TT
121592019-01-02 Tom Tromey <tom@tromey.com>
12160
12161 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12162 (tdesc_parse_xml): Remove cleanups.
12163 * target-descriptions.h (make_cleanup_free_target_description):
12164 Don't declare.
12165 (target_desc_deleter): New struct.
12166 (target_desc_up): New typedef.
12167 * target-descriptions.c (target_desc_deleter::operator()): Rename
12168 from free_target_description.
12169 (make_cleanup_free_target_description): Remove.
12170
3a6ae42d
TT
121712019-01-02 Tom Tromey <tom@tromey.com>
12172
12173 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12174 constructor, destructor.
12175 (linespec_parser): Remove typedef.
12176 (~linespec_parser): Rename from linespec_parser_delete.
12177 (linespec_lex_to_end, linespec_complete_label)
12178 (linespec_complete): Update.
12179 (decode_line_full): Remove cleanups.
12180 (decode_line_1): Update.
12181
61fd3e73
TT
121822019-01-02 Tom Tromey <tom@tromey.com>
12183
12184 * python/python-internal.h (inferior_to_inferior_object): Change
12185 return type.
12186 * python/py-exitedevent.c (create_exited_event_object): Update.
12187 * python/py-inferior.c (inferior_to_inferior_object): Return
12188 gdbpy_ref.
12189 (python_new_inferior, python_inferior_deleted)
12190 (thread_to_thread_object, delete_thread_object)
12191 (build_inferior_list, gdbpy_selected_inferior): Update.
12192 * python/py-infthread.c (create_thread_object): Update. Also fail
12193 if inferior_to_inferior_object fails.
12194
d20172fc
SM
121952019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12196
12197 * inferior.h (class inferior) <displaced_step_state>: New field.
12198 * infrun.h (struct displaced_step_state): Move here from
12199 infrun.c. Initialize fields, add constructor.
12200 <inf>: Remove field.
12201 <reset>: New method.
12202 * infrun.c (struct displaced_step_inferior_state): Move to
12203 infrun.h.
12204 (displaced_step_inferior_states): Remove.
12205 (get_displaced_stepping_state): Adust.
12206 (displaced_step_in_progress_any_inferior): Adjust.
12207 (displaced_step_in_progress_thread): Adjust.
12208 (displaced_step_in_progress): Adjust.
12209 (add_displaced_stepping_state): Remove.
12210 (get_displaced_step_closure_by_addr): Adjust.
12211 (remove_displaced_stepping_state): Remove.
12212 (infrun_inferior_exit): Call displaced_step_state.reset.
12213 (use_displaced_stepping): Don't check for NULL.
12214 (displaced_step_prepare_throw): Call
12215 get_displaced_stepping_state.
12216 (displaced_step_fixup): Don't check for NULL.
12217 (prepare_for_detach): Don't check for NULL.
12218
e3319240
PW
122192019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12220
12221 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12222 in case of call that did not complete.
12223
5d36dfb9
AU
122242019-01-02 Andrey Utkin <autkin@undo.io>
12225
12226 * symfile.c (find_separate_debug_file): Fix search of debug files for
12227 remote debuggee.
12228
8833fbf0
TT
122292019-01-02 Tom Tromey <tom@tromey.com>
12230
12231 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12232 indentation.
12233 * python/py-frame.c (frapy_older): Remove cast.
12234 (frapy_newer): Likewise.
12235 * python/py-breakpoint.c (local_setattro): Remove cast.
12236 * python/py-arch.c (archpy_name): Remove local variable.
12237 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12238
4ada3dfd
JB
122392019-01-02 Joel Brobecker <brobecker@adacore.com>
12240
12241 * unittests/basic_string_view/element_access/char/empty.cc:
12242 Fix year range in copyright header.
12243
113b7b81
AB
122442019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12245
12246 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12247 Delete.
12248 <operator==>: Update with for removed field.
12249 <hash>: Likewise.
12250 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12251 <isa_features>: ...this.
12252 <abi_features>: New field.
12253 (riscv_isa_flen): Update comment.
12254 (riscv_abi_xlen): New declaration.
12255 (riscv_abi_flen): New declaration.
12256 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12257 isa_features.
12258 (riscv_abi_xlen): New function.
12259 (riscv_isa_flen): Update to get answer from isa_features.
12260 (riscv_abi_flen): New function.
12261 (riscv_has_fp_abi): Update to get answer from abi_features.
12262 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12263 xlen and flen.
12264 (riscv_call_info) <xlen, flen>: Update comment.
12265 (riscv_call_arg_struct): Remove invalid assertions
12266 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12267 is removed.
12268 (riscv_gdbarch_init): Gather isa features and abi features
12269 separately, ensure both match on the gdbarch when reusing an old
12270 gdbarch. Relax an error check to allow 32-bit abi float to run on
12271 a target with 64-bit float hardware.
12272
b18ca514
PW
122732019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12274
12275 * source.c (search_command_helper): Stop reverse search
12276 when line 1 has been searched.
12277
ec70d8db
PW
122782019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12279
12280 * record-full.c (record_full_base_target::close): Rewrite
12281 record_full_core_buf_list free logic.
12282
5b38f9c1
PW
122832019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12284
12285 * break-catch-syscall.c (print_one_catch_syscall): xfree
12286 the last text.
12287
66d91b39
JB
122882019-01-01 Joel Brobecker <brobecker@adacore.com>
12289
12290 * top.c (print_gdb_version): Update Copyright year in version
12291 message.
12292
42a4f53d
JB
122932019-01-01 Joel Brobecker <brobecker@adacore.com>
12294
12295 Update copyright year range in all GDB files.
12296
7e955d83 122972019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12298
5bbd631d 12299 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12300
5bbd631d 12301For older changes see ChangeLog-2018.
c906108c
SS
12302\f
12303Local Variables:
12304mode: change-log
12305left-margin: 8
12306fill-column: 74
12307version-control: never
57da7796 12308coding: utf-8
c906108c 12309End:
5bbd631d 12310