]> git.ipfire.org Git - thirdparty/cups.git/blobdiff - cups/tls-darwin.c
Update "since CUPS 2.0" into to mention OS X 10.10.
[thirdparty/cups.git] / cups / tls-darwin.c
index ec0264ff27409986dcd7a72e257a2a46bc206cb2..fefd6d104cf46e075160b512f76796479c7d5f08 100644 (file)
@@ -3,7 +3,7 @@
  *
  * TLS support code for CUPS on OS X.
  *
- * Copyright 2007-2013 by Apple Inc.
+ * Copyright 2007-2014 by Apple Inc.
  * Copyright 1997-2007 by Easy Software Products, all rights reserved.
  *
  * These coded instructions, statements, and computer programs are the
@@ -30,6 +30,7 @@ extern char **environ;
  * Local globals...
  */
 
+#ifdef HAVE_SECKEYCHAINOPEN
 static int             tls_auto_create = 0;
                                        /* Auto-create self-signed certs? */
 static char            *tls_common_name = NULL;
@@ -40,32 +41,39 @@ static char         *tls_keypath = NULL;
                                        /* Server cert keychain path */
 static _cups_mutex_t   tls_mutex = _CUPS_MUTEX_INITIALIZER;
                                        /* Mutex for keychain/certs */
+#endif /* HAVE_SECKEYCHAINOPEN */
 
 
 /*
  * Local functions...
  */
 
+#ifdef HAVE_SECKEYCHAINOPEN
 static CFArrayRef      http_cdsa_copy_server(const char *common_name);
+#endif /* HAVE_SECKEYCHAINOPEN */
+static SecCertificateRef http_cdsa_create_credential(http_credential_t *credential);
+static const char      *http_cdsa_default_path(char *buffer, size_t bufsize);
 static OSStatus                http_cdsa_read(SSLConnectionRef connection, void *data, size_t *dataLength);
+static int             http_cdsa_set_credentials(http_t *http);
 static OSStatus                http_cdsa_write(SSLConnectionRef connection, const void *data, size_t *dataLength);
 
 
 /*
  * 'cupsMakeServerCredentials()' - Make a self-signed certificate and private key pair.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS 10.10@
  */
 
 int                                    /* O - 1 on success, 0 on failure */
 cupsMakeServerCredentials(
-    const char *path,                  /* I - Path to keychain/directory */
+    const char *path,                  /* I - Keychain path or @code NULL@ for default */
     const char *common_name,           /* I - Common name */
     int        num_alt_names,          /* I - Number of subject alternate names */
     const char **alt_names,            /* I - Subject Alternate Names */
     time_t     expiration_date)                /* I - Expiration date */
 {
-#ifdef HAVE_SECGENERATESELFSIGNEDCERTIFICATE
+#if defined(HAVE_SECGENERATESELFSIGNEDCERTIFICATE) && defined(HAVE_SECKEYCHAINOPEN)
+  char                 filename[1024]; /* Default keychain path */
   int                  status = 0;     /* Return status */
   OSStatus             err;            /* Error code (if any) */
   CFStringRef          cfcommon_name = NULL;
@@ -79,12 +87,16 @@ cupsMakeServerCredentials(
                                        /* Key generation parameters */
 
 
+  DEBUG_printf(("cupsMakeServerCredentials(path=\"%s\", common_name=\"%s\", num_alt_names=%d, alt_names=%p, expiration_date=%d)", path, common_name, num_alt_names, alt_names, (int)expiration_date));
+
   (void)num_alt_names;
   (void)alt_names;
   (void)expiration_date;
 
-  cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, common_name,
-                                           kCFStringEncodingUTF8);
+  if (!path)
+    path = http_cdsa_default_path(filename, sizeof(filename));
+
+  cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, common_name, kCFStringEncodingUTF8);
   if (!cfcommon_name)
     goto cleanup;
 
@@ -92,16 +104,13 @@ cupsMakeServerCredentials(
   * Create a public/private key pair...
   */
 
-  keyParams = CFDictionaryCreateMutable(kCFAllocatorDefault, 0,
-                                       &kCFTypeDictionaryKeyCallBacks,
-                                       &kCFTypeDictionaryValueCallBacks);
+  keyParams = CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks);
   if (!keyParams)
     goto cleanup;
 
   CFDictionaryAddValue(keyParams, kSecAttrKeyType, kSecAttrKeyTypeRSA);
   CFDictionaryAddValue(keyParams, kSecAttrKeySizeInBits, CFSTR("2048"));
-  CFDictionaryAddValue(keyParams, kSecAttrLabel,
-                       CFSTR("CUPS Self-Signed Certificate"));
+  CFDictionaryAddValue(keyParams, kSecAttrLabel, CFSTR("CUPS Self-Signed Certificate"));
 
   err = SecKeyGeneratePair(keyParams, &publicKey, &privateKey);
   if (err != noErr)
@@ -165,19 +174,27 @@ cleanup:
 
   return (status);
 
-#else /* !HAVE_SECGENERATESELFSIGNEDCERTIFICATE */
+#else /* !(HAVE_SECGENERATESELFSIGNEDCERTIFICATE && HAVE_SECKEYCHAINOPEN) */
   int          pid,                    /* Process ID of command */
-               status;                 /* Status of command */
+               status,                 /* Status of command */
+               i;                      /* Looping var */
   char         command[1024],          /* Command */
                *argv[4],               /* Command-line arguments */
+               *envp[1000],            /* Environment variables */
+               days[32],               /* CERTTOOL_EXPIRATION_DAYS env var */
                keychain[1024],         /* Keychain argument */
-               infofile[1024];         /* Type-in information for cert */
+               infofile[1024],         /* Type-in information for cert */
+               filename[1024];         /* Default keychain path */
   cups_file_t  *fp;                    /* Seed/info file */
 
 
+  DEBUG_printf(("cupsMakeServerCredentials(path=\"%s\", common_name=\"%s\", num_alt_names=%d, alt_names=%p, expiration_date=%d)", path, common_name, num_alt_names, alt_names, (int)expiration_date));
+
   (void)num_alt_names;
   (void)alt_names;
-  (void)expiration_date;
+
+  if (!path)
+    path = http_cdsa_default_path(filename, sizeof(filename));
 
  /*
   * Run the "certtool" command to generate a self-signed certificate...
@@ -222,13 +239,23 @@ cleanup:
   argv[2] = keychain;
   argv[3] = NULL;
 
+  snprintf(days, sizeof(days), "CERTTOOL_EXPIRATION_DAYS=%d", (int)((expiration_date - time(NULL) + 86399) / 86400));
+  envp[0] = days;
+  for (i = 0; i < (int)(sizeof(envp) / sizeof(envp[0]) - 2) && environ[i]; i ++)
+    envp[i + 1] = environ[i];
+  envp[i] = NULL;
+
   posix_spawn_file_actions_t actions;  /* File actions */
 
   posix_spawn_file_actions_init(&actions);
   posix_spawn_file_actions_addclose(&actions, 0);
   posix_spawn_file_actions_addopen(&actions, 0, infofile, O_RDONLY, 0);
+  posix_spawn_file_actions_addclose(&actions, 1);
+  posix_spawn_file_actions_addopen(&actions, 1, "/dev/null", O_WRONLY, 0);
+  posix_spawn_file_actions_addclose(&actions, 2);
+  posix_spawn_file_actions_addopen(&actions, 2, "/dev/null", O_WRONLY, 0);
 
-  if (posix_spawn(&pid, command, &actions, NULL, argv, environ))
+  if (posix_spawn(&pid, command, &actions, NULL, argv, envp))
   {
     unlink(infofile);
     return (-1);
@@ -246,7 +273,7 @@ cleanup:
     }
 
   return (!status);
-#endif /* HAVE_SECGENERATESELFSIGNEDCERTIFICATE */
+#endif /* HAVE_SECGENERATESELFSIGNEDCERTIFICATE && HAVE_SECKEYCHAINOPEN */
 }
 
 
@@ -256,21 +283,29 @@ cleanup:
  * Note: The server credentials are used by all threads in the running process.
  * This function is threadsafe.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS X 10.10@
  */
 
 int                                    /* O - 1 on success, 0 on failure */
 cupsSetServerCredentials(
-    const char *path,                  /* I - Path to keychain/directory */
+    const char *path,                  /* I - Keychain path or @code NULL@ for default */
     const char *common_name,           /* I - Default common name for server */
     int        auto_create)            /* I - 1 = automatically create self-signed certificates */
 {
+  DEBUG_printf(("cupsSetServerCredentials(path=\"%s\", common_name=\"%s\", auto_create=%d)", path, common_name, auto_create));
+
+#ifdef HAVE_SECKEYCHAINOPEN
+  char                 filename[1024]; /* Filename for keychain */
   SecKeychainRef       keychain = NULL;/* Temporary keychain */
 
 
+  if (!path)
+    path = http_cdsa_default_path(filename, sizeof(filename));
+
   if (SecKeychainOpen(path, &keychain) != noErr)
   {
     /* TODO: Set cups last error string */
+    DEBUG_puts("1cupsSetServerCredentials: Unable to open keychain, returning 0.");
     return (0);
   }
 
@@ -300,7 +335,13 @@ cupsSetServerCredentials(
 
   _cupsMutexUnlock(&tls_mutex);
 
+  DEBUG_puts("1cupsSetServerCredentials: Opened keychain, returning 1.");
   return (1);
+
+#else
+  DEBUG_puts("1cupsSetServerCredentials: No keychain support compiled in, returning 0.");
+  return (0);
+#endif /* HAVE_SECKEYCHAINOPEN */
 }
 
 
@@ -324,6 +365,8 @@ httpCopyCredentials(
   int                  i;              /* Looping var */
 
 
+  DEBUG_printf(("httpCopyCredentials(http=%p, credentials=%p)", http, credentials));
+
   if (credentials)
     *credentials = NULL;
 
@@ -332,6 +375,8 @@ httpCopyCredentials(
 
   if (!(error = SSLCopyPeerTrust(http->tls, &peerTrust)) && peerTrust)
   {
+    DEBUG_printf(("2httpCopyCredentials: Peer provided %d certificates.", (int)SecTrustGetCertificateCount(peerTrust)));
+
     if ((*credentials = cupsArrayNew(NULL, NULL)) != NULL)
     {
       count = SecTrustGetCertificateCount(peerTrust);
@@ -339,10 +384,23 @@ httpCopyCredentials(
       for (i = 0; i < count; i ++)
       {
        secCert = SecTrustGetCertificateAtIndex(peerTrust, i);
-       if ((data = SecCertificateCopyData(secCert)))
+
+#ifdef DEBUG
+        CFStringRef cf_name = SecCertificateCopySubjectSummary(secCert);
+       char name[1024];
+       if (cf_name)
+         CFStringGetCString(cf_name, name, sizeof(name), kCFStringEncodingUTF8);
+       else
+         strlcpy(name, "unknown", sizeof(name));
+
+       DEBUG_printf(("2httpCopyCredentials: Certificate %d name is \"%s\".", i, name));
+#endif /* DEBUG */
+
+       if ((data = SecCertificateCopyData(secCert)) != NULL)
        {
-         httpAddCredential(*credentials, CFDataGetBytePtr(data),
-                           CFDataGetLength(data));
+         DEBUG_printf(("2httpCopyCredentials: Adding %d byte certificate blob.", (int)CFDataGetLength(data)));
+
+         httpAddCredential(*credentials, CFDataGetBytePtr(data), (size_t)CFDataGetLength(data));
          CFRelease(data);
        }
       }
@@ -365,7 +423,6 @@ _httpCreateCredentials(
 {
   CFMutableArrayRef    peerCerts;      /* Peer credentials reference */
   SecCertificateRef    secCert;        /* Certificate reference */
-  CFDataRef            data;           /* Credential data reference */
   http_credential_t    *credential;    /* Credential data */
 
 
@@ -381,17 +438,10 @@ _httpCreateCredentials(
        credential;
        credential = (http_credential_t *)cupsArrayNext(credentials))
   {
-    if ((data = CFDataCreate(kCFAllocatorDefault, credential->data,
-                            credential->datalen)))
+    if ((secCert = http_cdsa_create_credential(credential)) != NULL)
     {
-      if ((secCert = SecCertificateCreateWithData(kCFAllocatorDefault, data))
-              != NULL)
-      {
-       CFArrayAppendValue(peerCerts, secCert);
-       CFRelease(secCert);
-      }
-
-      CFRelease(data);
+      CFArrayAppendValue(peerCerts, secCert);
+      CFRelease(secCert);
     }
   }
 
@@ -400,59 +450,181 @@ _httpCreateCredentials(
 
 
 /*
- * 'httpCredentialsAreTrusted()' - Return whether the credentials are trusted.
+ * 'httpCredentialsAreValidForName()' - Return whether the credentials are valid for the given name.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS X 10.10@
  */
 
-int                                    /* O - 1 if trusted, 0 if not/unknown */
-httpCredentialsAreTrusted(
-    cups_array_t *credentials)         /* I - Credentials */
+int                                    /* O - 1 if valid, 0 otherwise */
+httpCredentialsAreValidForName(
+    cups_array_t *credentials,         /* I - Credentials */
+    const char   *common_name)         /* I - Name to check */
 {
-  (void)credentials;
+  SecCertificateRef    secCert;        /* Certificate reference */
+  CFStringRef          cfcert_name = NULL;
+                                       /* Certificate's common name (CF string) */
+  char                 cert_name[256]; /* Certificate's common name (C string) */
+  int                  valid = 1;      /* Valid name? */
 
-  return (0);
+
+  if ((secCert = http_cdsa_create_credential((http_credential_t *)cupsArrayFirst(credentials))) == NULL)
+    return (0);
+
+ /*
+  * Compare the common names...
+  */
+
+  if ((cfcert_name = SecCertificateCopySubjectSummary(secCert)) == NULL)
+  {
+   /*
+    * Can't get common name, cannot be valid...
+    */
+
+    valid = 0;
+  }
+  else if (CFStringGetCString(cfcert_name, cert_name, sizeof(cert_name), kCFStringEncodingUTF8) &&
+           _cups_strcasecmp(common_name, cert_name))
+  {
+   /*
+    * Not an exact match for the common name, check for wildcard certs...
+    */
+
+    const char *domain = strchr(common_name, '.');
+                                       /* Domain in common name */
+
+    if (strncmp(cert_name, "*.", 2) || !domain || _cups_strcasecmp(domain, cert_name + 1))
+    {
+     /*
+      * Not a wildcard match.
+      */
+
+      /* TODO: Check subject alternate names */
+      valid = 0;
+    }
+  }
+
+  if (cfcert_name)
+    CFRelease(cfcert_name);
+
+  CFRelease(secCert);
+
+  return (valid);
 }
 
 
 /*
- * 'httpCredentialsGetExpiration()' - Return the expiration date of the credentials.
+ * 'httpCredentialsGetTrust()' - Return the trust of credentials.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS X 10.10@
  */
 
-time_t                                 /* O - Expiration date of credentials */
-httpCredentialsGetExpiration(
-    cups_array_t *credentials)         /* I - Credentials */
+http_trust_t                           /* O - Level of trust */
+httpCredentialsGetTrust(
+    cups_array_t *credentials,         /* I - Credentials */
+    const char   *common_name)         /* I - Common name for trust lookup */
 {
-  (void)credentials;
+  SecCertificateRef    secCert;        /* Certificate reference */
+  http_trust_t         trust = HTTP_TRUST_OK;
+                                       /* Trusted? */
+  cups_array_t         *tcreds = NULL; /* Trusted credentials */
+  _cups_globals_t      *cg = _cupsGlobals();
+                                       /* Per-thread globals */
 
-  return (0);
+
+  if (!common_name)
+    return (HTTP_TRUST_UNKNOWN);
+
+  if ((secCert = http_cdsa_create_credential((http_credential_t *)cupsArrayFirst(credentials))) == NULL)
+    return (HTTP_TRUST_UNKNOWN);
+
+ /*
+  * Look this common name up in the default keychains...
+  */
+
+  httpLoadCredentials(NULL, &tcreds, common_name);
+
+  if (tcreds)
+  {
+    char       credentials_str[1024],  /* String for incoming credentials */
+               tcreds_str[1024];       /* String for saved credentials */
+
+    httpCredentialsString(credentials, credentials_str, sizeof(credentials_str));
+    httpCredentialsString(tcreds, tcreds_str, sizeof(tcreds_str));
+
+    if (strcmp(credentials_str, tcreds_str))
+    {
+     /*
+      * Credentials don't match, let's look at the expiration date of the new
+      * credentials and allow if the new ones have a later expiration...
+      */
+
+      if (httpCredentialsGetExpiration(credentials) <= httpCredentialsGetExpiration(tcreds) ||
+          !httpCredentialsAreValidForName(credentials, common_name))
+      {
+       /*
+        * Either the new credentials are not newly issued, or the common name
+       * does not match the issued certificate...
+       */
+
+        trust = HTTP_TRUST_INVALID;
+      }
+      else if (httpCredentialsGetExpiration(tcreds) < time(NULL))
+      {
+       /*
+        * Save the renewed credentials...
+       */
+
+       trust = HTTP_TRUST_RENEWED;
+
+        httpSaveCredentials(NULL, credentials, common_name);
+      }
+    }
+
+    httpFreeCredentials(tcreds);
+  }
+  else if (cg->validate_certs && !httpCredentialsAreValidForName(credentials, common_name))
+    trust = HTTP_TRUST_INVALID;
+
+  if (!cg->expired_certs && !SecCertificateIsValid(secCert, CFAbsoluteTimeGetCurrent()))
+    trust = HTTP_TRUST_EXPIRED;
+  else if (!cg->any_root && cupsArrayCount(credentials) == 1)
+    trust = HTTP_TRUST_INVALID;
+
+  CFRelease(secCert);
+
+  return (trust);
 }
 
 
 /*
- * 'httpCredentialsIsValidName()' - Return whether the credentials are valid for the given name.
+ * 'httpCredentialsGetExpiration()' - Return the expiration date of the credentials.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS X 10.10@
  */
 
-int                                    /* O - 1 if valid, 0 otherwise */
-httpCredentialsIsValidName(
-    cups_array_t *credentials,         /* I - Credentials */
-    const char   *common_name)         /* I - Name to check */
+time_t                                 /* O - Expiration date of credentials */
+httpCredentialsGetExpiration(
+    cups_array_t *credentials)         /* I - Credentials */
 {
-  (void)credentials;
-  (void)common_name;
+  SecCertificateRef    secCert;        /* Certificate reference */
+  time_t               expiration;     /* Expiration date */
 
-  return (0);
+
+  if ((secCert = http_cdsa_create_credential((http_credential_t *)cupsArrayFirst(credentials))) == NULL)
+    return (0);
+
+  expiration = (time_t)(SecCertificateNotValidAfter(secCert) + kCFAbsoluteTimeIntervalSince1970);
+
+  CFRelease(secCert);
+
+  return (expiration);
 }
 
 
 /*
  * 'httpCredentialsString()' - Return a string representing the credentials.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS X 10.10@
  */
 
 size_t                                 /* O - Total size of credentials string */
@@ -461,12 +633,49 @@ httpCredentialsString(
     char         *buffer,              /* I - Buffer or @code NULL@ */
     size_t       bufsize)              /* I - Size of buffer */
 {
-  (void)credentials;
+  http_credential_t    *first;         /* First certificate */
+  SecCertificateRef    secCert;        /* Certificate reference */
+
+
+  DEBUG_printf(("httpCredentialsString(credentials=%p, buffer=%p, bufsize=" CUPS_LLFMT ")", credentials, buffer, CUPS_LLCAST bufsize));
+
+  if (!buffer)
+    return (0);
 
   if (buffer && bufsize > 0)
     *buffer = '\0';
 
-  return (1);
+  if ((first = (http_credential_t *)cupsArrayFirst(credentials)) != NULL &&
+      (secCert = http_cdsa_create_credential(first)) != NULL)
+  {
+    CFStringRef                cf_name;        /* CF common name string */
+    char               name[256];      /* Common name associated with cert */
+    time_t             expiration;     /* Expiration date of cert */
+    _cups_md5_state_t  md5_state;      /* MD5 state */
+    unsigned char      md5_digest[16]; /* MD5 result */
+
+    if ((cf_name = SecCertificateCopySubjectSummary(secCert)) != NULL)
+    {
+      CFStringGetCString(cf_name, name, (CFIndex)sizeof(name), kCFStringEncodingUTF8);
+      CFRelease(cf_name);
+    }
+    else
+      strlcpy(name, "unknown", sizeof(name));
+
+    expiration = (time_t)(SecCertificateNotValidAfter(secCert) + kCFAbsoluteTimeIntervalSince1970);
+
+    _cupsMD5Init(&md5_state);
+    _cupsMD5Append(&md5_state, first->data, (int)first->datalen);
+    _cupsMD5Finish(&md5_state, md5_digest);
+
+    snprintf(buffer, bufsize, "%s / %s / %02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X%02X", name, httpGetDateString(expiration), md5_digest[0], md5_digest[1], md5_digest[2], md5_digest[3], md5_digest[4], md5_digest[5], md5_digest[6], md5_digest[7], md5_digest[8], md5_digest[9], md5_digest[10], md5_digest[11], md5_digest[12], md5_digest[13], md5_digest[14], md5_digest[15]);
+
+    CFRelease(secCert);
+  }
+
+  DEBUG_printf(("1httpCredentialsString: Returning \"%s\".", buffer));
+
+  return (strlen(buffer));
 }
 
 
@@ -488,28 +697,22 @@ _httpFreeCredentials(
 /*
  * 'httpLoadCredentials()' - Load X.509 credentials from a keychain file.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS 10.10@
  */
 
 int                                    /* O - 0 on success, -1 on error */
 httpLoadCredentials(
-    const char   *path,                        /* I  - Keychain/PKCS#12 path */
+    const char   *path,                        /* I  - Keychain path or @code NULL@ for default */
     cups_array_t **credentials,                /* IO - Credentials */
     const char   *common_name)         /* I  - Common name for credentials */
 {
-  (void)path;
-  (void)credentials;
-  (void)common_name;
-
-  return (-1);
-
-#if 0
+#ifdef HAVE_SECKEYCHAINOPEN
   OSStatus             err;            /* Error info */
+  char                 filename[1024]; /* Filename for keychain */
   SecKeychainRef       keychain = NULL;/* Keychain reference */
   SecIdentitySearchRef search = NULL;  /* Search reference */
-  SecIdentityRef       identity = NULL;/* Identity */
-  CFArrayRef           certificates = NULL;
-                                       /* Certificate array */
+  SecCertificateRef    cert = NULL;    /* Certificate */
+  CFDataRef            data;           /* Certificate data */
   SecPolicyRef         policy = NULL;  /* Policy ref */
   CFStringRef          cfcommon_name = NULL;
                                        /* Server name */
@@ -517,7 +720,17 @@ httpLoadCredentials(
   CFArrayRef           list = NULL;    /* Keychain list */
 
 
-  if ((err = SecKeychainOpen(path, &keychain)))
+  DEBUG_printf(("httpLoadCredentials(path=\"%s\", credentials=%p, common_name=\"%s\")", path, credentials, common_name));
+
+  if (!credentials)
+    return (-1);
+
+  *credentials = NULL;
+
+  if (!path)
+    path = http_cdsa_default_path(filename, sizeof(filename));
+
+  if ((err = SecKeychainOpen(path, &keychain)) != noErr)
     goto cleanup;
 
   cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, common_name, kCFStringEncodingUTF8);
@@ -533,10 +746,9 @@ httpLoadCredentials(
   if (!(query = CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)))
     goto cleanup;
 
-  list = CFArrayCreate(kCFAllocatorDefault, (const void **)&keychain, 1,
-                       &kCFTypeArrayCallBacks);
+  list = CFArrayCreate(kCFAllocatorDefault, (const void **)&keychain, 1, &kCFTypeArrayCallBacks);
 
-  CFDictionaryAddValue(query, kSecClass, kSecClassIdentity);
+  CFDictionaryAddValue(query, kSecClass, kSecClassCertificate);
   CFDictionaryAddValue(query, kSecMatchPolicy, policy);
   CFDictionaryAddValue(query, kSecReturnRef, kCFBooleanTrue);
   CFDictionaryAddValue(query, kSecMatchLimit, kSecMatchLimitOne);
@@ -544,16 +756,22 @@ httpLoadCredentials(
 
   CFRelease(list);
 
-  err = SecItemCopyMatching(query, (CFTypeRef *)&identity);
+  err = SecItemCopyMatching(query, (CFTypeRef *)&cert);
 
   if (err)
     goto cleanup;
 
-  if (CFGetTypeID(identity) != SecIdentityGetTypeID())
+  if (CFGetTypeID(cert) != SecCertificateGetTypeID())
     goto cleanup;
 
-  if ((certificates = CFArrayCreate(NULL, (const void **)&identity, 1, &kCFTypeArrayCallBacks)) == NULL)
-    goto cleanup;
+  if ((data = SecCertificateCopyData(cert)) != NULL)
+  {
+    DEBUG_printf(("1httpLoadCredentials: Adding %d byte certificate blob.", (int)CFDataGetLength(data)));
+
+    *credentials = cupsArrayNew(NULL, NULL);
+    httpAddCredential(*credentials, CFDataGetBytePtr(data), (size_t)CFDataGetLength(data));
+    CFRelease(data);
+  }
 
   cleanup :
 
@@ -561,423 +779,126 @@ httpLoadCredentials(
     CFRelease(keychain);
   if (search)
     CFRelease(search);
-  if (identity)
-    CFRelease(identity);
-
+  if (cert)
+    CFRelease(cert);
   if (policy)
     CFRelease(policy);
   if (query)
     CFRelease(query);
 
-  return (certificates);
-#endif /* 0 */
-}
-
-
-#if 0
-/*
- * 'cupsMakeCredentials()' - Create self-signed credentials for the given
- *                           name.
- *
- * @since CUPS 2.0@
- */
-
-int                                    /* O - 0 on success, -1 on error */
-cupsMakeCredentials(
-    const char   *path,                        /* I - Keychain/PKCS#12 path */
-    cups_array_t **credentials,                /* O - Credentials */
-    const char   *common_name)         /* I - Common name for X.509 cert */
-{
-#    ifdef HAVE_SECGENERATESELFSIGNEDCERTIFICATE
-  int                  status = -1;    /* Return status */
-  OSStatus             err;            /* Error code (if any) */
-  CFStringRef          cfcommon_name = NULL;
-                                       /* CF string for server name */
-  SecIdentityRef       ident = NULL;   /* Identity */
-  SecKeyRef            publicKey = NULL,
-                                       /* Public key */
-                       privateKey = NULL;
-                                       /* Private key */
-  CFMutableDictionaryRef keyParams = NULL;
-                                       /* Key generation parameters */
-
-
-  if (credentials)
-    *credentials = NULL;
-
-  cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, servername,
-                                           kCFStringEncodingUTF8);
-  if (!cfcommon_name)
-    goto cleanup;
-
- /*
-  * Create a public/private key pair...
-  */
-
-  keyParams = CFDictionaryCreateMutable(kCFAllocatorDefault, 0,
-                                       &kCFTypeDictionaryKeyCallBacks,
-                                       &kCFTypeDictionaryValueCallBacks);
-  if (!keyParams)
-    goto cleanup;
-
-  CFDictionaryAddValue(keyParams, kSecAttrKeyType, kSecAttrKeyTypeRSA);
-  CFDictionaryAddValue(keyParams, kSecAttrKeySizeInBits, CFSTR("2048"));
-  CFDictionaryAddValue(keyParams, kSecAttrLabel,
-                       CFSTR("CUPS Self-Signed Certificate"));
-
-  err = SecKeyGeneratePair(keyParams, &publicKey, &privateKey);
-  if (err != noErr)
-    goto cleanup;
-
- /*
-  * Create a self-signed certificate using the public/private key pair...
-  */
-
-  CFIndex      usageInt = kSecKeyUsageAll;
-  CFNumberRef  usage = CFNumberCreate(alloc, kCFNumberCFIndexType, &usageInt);
-  CFDictionaryRef certParams = CFDictionaryCreateMutable(kCFAllocatorDefault,
-kSecCSRBasicContraintsPathLen, CFINT(0), kSecSubjectAltName, cfcommon_name, kSecCertificateKeyUsage, usage, NULL, NULL);
-  CFRelease(usage);
-
-  const void   *ca_o[] = { kSecOidOrganization, CFSTR("") };
-  const void   *ca_cn[] = { kSecOidCommonName, cfcommon_name };
-  CFArrayRef   ca_o_dn = CFArrayCreate(kCFAllocatorDefault, ca_o, 2, NULL);
-  CFArrayRef   ca_cn_dn = CFArrayCreate(kCFAllocatorDefault, ca_cn, 2, NULL);
-  const void   *ca_dn_array[2];
-
-  ca_dn_array[0] = CFArrayCreate(kCFAllocatorDefault, (const void **)&ca_o_dn, 1, NULL);
-  ca_dn_array[1] = CFArrayCreate(kCFAllocatorDefault, (const void **)&ca_cn_dn, 1, NULL);
-
-  CFArrayRef   subject = CFArrayCreate(kCFAllocatorDefault, ca_dn_array, 2, NULL);
-  SecCertificateRef cert = SecGenerateSelfSignedCertificate(subject, certParams, publicKey, privateKey);
-  CFRelease(subject);
-  CFRelease(certParams);
-
-  if (!cert)
-    goto cleanup;
-
-  ident = SecIdentityCreate(kCFAllocatorDefault, cert, privateKey);
-
-  if (ident)
-    status = 0;
-
-  /*
-   * Cleanup and return...
-   */
-
-cleanup:
-
-  if (cfcommon_name)
-    CFRelease(cfcommon_name);
-
-  if (keyParams)
-    CFRelease(keyParams);
-
-  if (ident)
-    CFRelease(ident);
-
-  if (cert)
-    CFRelease(cert);
-
-  if (publicKey)
-    CFRelease(publicKey);
-
-  if (privateKey)
-    CFRelease(publicKey);
-
-  return (status);
-
-#    else /* !HAVE_SECGENERATESELFSIGNEDCERTIFICATE */
-  int          pid,                    /* Process ID of command */
-               status;                 /* Status of command */
-  char         command[1024],          /* Command */
-               *argv[4],               /* Command-line arguments */
-               keychain[1024],         /* Keychain argument */
-               infofile[1024];         /* Type-in information for cert */
-  cups_file_t  *fp;                    /* Seed/info file */
-
-
- /*
-  * Run the "certtool" command to generate a self-signed certificate...
-  */
-
-  if (!cupsFileFind("certtool", getenv("PATH"), 1, command, sizeof(command)))
-    return (-1);
-
- /*
-  * Create a file with the certificate information fields...
-  *
-  * Note: This assumes that the default questions are asked by the certtool
-  * command...
-  */
-
- if ((fp = cupsTempFile2(infofile, sizeof(infofile))) == NULL)
-    return (-1);
+  DEBUG_printf(("1httpLoadCredentials: Returning %d.", *credentials ? 0 : -1));
 
-  cupsFilePrintf(fp,
-                 "%s\n"                        /* Enter key and certificate label */
-                 "r\n"                 /* Generate RSA key pair */
-                 "2048\n"              /* Key size in bits */
-                 "y\n"                 /* OK (y = yes) */
-                 "b\n"                 /* Usage (b=signing/encryption) */
-                 "s\n"                 /* Sign with SHA1 */
-                 "y\n"                 /* OK (y = yes) */
-                 "%s\n"                        /* Common name */
-                 "\n"                  /* Country (default) */
-                 "\n"                  /* Organization (default) */
-                 "\n"                  /* Organizational unit (default) */
-                 "\n"                  /* State/Province (default) */
-                 "%s\n"                        /* Email address */
-                 "y\n",                        /* OK (y = yes) */
-                common_name, common_name, "");
-  cupsFileClose(fp);
-
-  snprintf(keychain, sizeof(keychain), "k=%s", path);
-
-  argv[0] = "certtool";
-  argv[1] = "c";
-  argv[2] = keychain;
-  argv[3] = NULL;
-
-  posix_spawn_file_actions_t actions;  /* File actions */
-
-  posix_spawn_file_actions_init(&actions);
-  posix_spawn_file_actions_addclose(&actions, 0);
-  posix_spawn_file_actions_addopen(&actions, 0, infofile, O_RDONLY, 0);
-
-  if (posix_spawn(&pid, command, &actions, NULL, argv, environ))
-  {
-    unlink(infofile);
-    return (-1);
-  }
-
-  posix_spawn_file_actions_destroy(&actions);
-
-  unlink(infofile);
+  return (*credentials ? 0 : -1);
 
-  while (waitpid(pid, &status, 0) < 0)
-    if (errno != EINTR)
-    {
-      status = -1;
-      break;
-    }
-
-  if (status)
-    return (-1);
-
-#    endif /* HAVE_SECGENERATESELFSIGNEDCERTIFICATE */
+#else
+  (void)path;
+  (void)credentials;
+  (void)common_name;
 
-  return (httpLoadCredentials(path, credentials, common_name));
+  return (-1);
+#endif /* HAVE_SECKEYCHAINOPEN */
 }
-#endif /* 0 */
 
 
 /*
  * 'httpSaveCredentials()' - Save X.509 credentials to a keychain file.
  *
- * @since CUPS 2.0@
+ * @since CUPS 2.0/OS 10.10@
  */
 
 int                                    /* O - -1 on error, 0 on success */
 httpSaveCredentials(
-    const char   *path,                        /* I - Keychain/PKCS#12 path */
+    const char   *path,                        /* I - Keychain path or @code NULL@ for default */
     cups_array_t *credentials,         /* I - Credentials */
     const char   *common_name)         /* I - Common name for credentials */
 {
-  (void)path;
-  (void)credentials;
-  (void)common_name;
-
-  return (-1);
-}
-
-
-/*
- * 'http_cdsa_copy_server()' - Find and copy server credentials from the keychain.
- */
-
-static CFArrayRef                      /* O - Array of certificates or NULL */
-http_cdsa_copy_server(
-    const char *common_name)           /* I - Server's hostname */
-{
+#ifdef HAVE_SECKEYCHAINOPEN
+  int                  ret = -1;       /* Return value */
   OSStatus             err;            /* Error info */
+  char                 filename[1024]; /* Filename for keychain */
+  SecKeychainRef       keychain = NULL;/* Keychain reference */
   SecIdentitySearchRef search = NULL;  /* Search reference */
-  SecIdentityRef       identity = NULL;/* Identity */
-  CFArrayRef           certificates = NULL;
-                                       /* Certificate array */
-  SecPolicyRef         policy = NULL;  /* Policy ref */
-  CFStringRef          cfcommon_name = NULL;
-                                       /* Server name */
-  CFMutableDictionaryRef query = NULL; /* Query qualifiers */
+  SecCertificateRef    cert = NULL;    /* Certificate */
+  CFMutableDictionaryRef attrs = NULL; /* Attributes for add */
   CFArrayRef           list = NULL;    /* Keychain list */
 
 
-  cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, common_name, kCFStringEncodingUTF8);
-
-  policy = SecPolicyCreateSSL(1, cfcommon_name);
-
-  if (cfcommon_name)
-    CFRelease(cfcommon_name);
-
-  if (!policy)
-    goto cleanup;
-
-  if (!(query = CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)))
-    goto cleanup;
-
-  list = CFArrayCreate(kCFAllocatorDefault, (const void **)&tls_keychain, 1, &kCFTypeArrayCallBacks);
-
-  CFDictionaryAddValue(query, kSecClass, kSecClassIdentity);
-  CFDictionaryAddValue(query, kSecMatchPolicy, policy);
-  CFDictionaryAddValue(query, kSecReturnRef, kCFBooleanTrue);
-  CFDictionaryAddValue(query, kSecMatchLimit, kSecMatchLimitOne);
-  CFDictionaryAddValue(query, kSecMatchSearchList, list);
-
-  CFRelease(list);
-
-  err = SecItemCopyMatching(query, (CFTypeRef *)&identity);
-
-  if (err)
-    goto cleanup;
-
-  if (CFGetTypeID(identity) != SecIdentityGetTypeID())
-    goto cleanup;
-
-  if ((certificates = CFArrayCreate(NULL, (const void **)&identity, 1, &kCFTypeArrayCallBacks)) == NULL)
+  DEBUG_printf(("httpSaveCredentials(path=\"%s\", credentials=%p, common_name=\"%s\")", path, credentials, common_name));
+  if (!credentials)
     goto cleanup;
 
-  cleanup :
-
-  if (search)
-    CFRelease(search);
-  if (identity)
-    CFRelease(identity);
-
-  if (policy)
-    CFRelease(policy);
-  if (query)
-    CFRelease(query);
-
-  return (certificates);
-}
-
-
-/*
- * 'http_cdsa_read()' - Read function for the CDSA library.
- */
-
-static OSStatus                                /* O  - -1 on error, 0 on success */
-http_cdsa_read(
-    SSLConnectionRef connection,       /* I  - SSL/TLS connection */
-    void             *data,            /* I  - Data buffer */
-    size_t           *dataLength)      /* IO - Number of bytes */
-{
-  OSStatus     result;                 /* Return value */
-  ssize_t      bytes;                  /* Number of bytes read */
-  http_t       *http;                  /* HTTP connection */
-
-
-  http = (http_t *)connection;
-
-  if (!http->blocking)
+  if (!httpCredentialsAreValidForName(credentials, common_name))
   {
-   /*
-    * Make sure we have data before we read...
-    */
-
-    while (!_httpWait(http, http->wait_value, 0))
-    {
-      if (http->timeout_cb && (*http->timeout_cb)(http, http->timeout_data))
-       continue;
-
-      http->error = ETIMEDOUT;
-      return (-1);
-    }
+    DEBUG_puts("1httpSaveCredentials: Common name does not match.");
+    return (-1);
   }
 
-  do
+  if ((cert = http_cdsa_create_credential((http_credential_t *)cupsArrayFirst(credentials))) == NULL)
   {
-    bytes = recv(http->fd, data, *dataLength, 0);
+    DEBUG_puts("1httpSaveCredentials: Unable to create certificate.");
+    goto cleanup;
   }
-  while (bytes == -1 && (errno == EINTR || errno == EAGAIN));
 
-  if (bytes == *dataLength)
+  if (!path)
+    path = http_cdsa_default_path(filename, sizeof(filename));
+
+  if ((err = SecKeychainOpen(path, &keychain)) != noErr)
   {
-    result = 0;
+    DEBUG_printf(("1httpSaveCredentials: SecKeychainOpen returned %d.", (int)err));
+    goto cleanup;
   }
-  else if (bytes > 0)
+
+  if ((list = CFArrayCreate(kCFAllocatorDefault, (const void **)&keychain, 1, &kCFTypeArrayCallBacks)) == NULL)
   {
-    *dataLength = bytes;
-    result = errSSLWouldBlock;
+    DEBUG_puts("1httpSaveCredentials: Unable to create list of keychains.");
+    goto cleanup;
   }
-  else
-  {
-    *dataLength = 0;
 
-    if (bytes == 0)
-      result = errSSLClosedGraceful;
-    else if (errno == EAGAIN)
-      result = errSSLWouldBlock;
-    else
-      result = errSSLClosedAbort;
+  if ((attrs = CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)) == NULL)
+  {
+    DEBUG_puts("1httpSaveCredentials: Unable to create dictionary.");
+    goto cleanup;
   }
 
-  return (result);
-}
-
-
-/*
- * 'http_cdsa_write()' - Write function for the CDSA library.
- */
-
-static OSStatus                                /* O  - -1 on error, 0 on success */
-http_cdsa_write(
-    SSLConnectionRef connection,       /* I  - SSL/TLS connection */
-    const void       *data,            /* I  - Data buffer */
-    size_t           *dataLength)      /* IO - Number of bytes */
-{
-  OSStatus     result;                 /* Return value */
-  ssize_t      bytes;                  /* Number of bytes read */
-  http_t       *http;                  /* HTTP connection */
-
-
-  http = (http_t *)connection;
+  CFDictionaryAddValue(attrs, kSecClass, kSecClassCertificate);
+  CFDictionaryAddValue(attrs, kSecValueRef, cert);
+  CFDictionaryAddValue(attrs, kSecMatchSearchList, list);
 
-  do
-  {
-    bytes = write(http->fd, data, *dataLength);
-  }
-  while (bytes == -1 && (errno == EINTR || errno == EAGAIN));
+  /* Note: SecItemAdd consumes "attrs"... */
+  err = SecItemAdd(attrs, NULL);
+  DEBUG_printf(("1httpSaveCredentials: SecItemAdd returned %d.", (int)err));
 
-  if (bytes == *dataLength)
-  {
-    result = 0;
-  }
-  else if (bytes >= 0)
-  {
-    *dataLength = bytes;
-    result = errSSLWouldBlock;
-  }
-  else
-  {
-    *dataLength = 0;
+  cleanup :
 
-    if (errno == EAGAIN)
-      result = errSSLWouldBlock;
-    else
-      result = errSSLClosedAbort;
-  }
+  if (list)
+    CFRelease(list);
+  if (keychain)
+    CFRelease(keychain);
+  if (search)
+    CFRelease(search);
+  if (cert)
+    CFRelease(cert);
 
-  return (result);
+  DEBUG_printf(("1httpSaveCredentials: Returning %d.", ret));
+
+  return (ret);
+
+#else
+  (void)path;
+  (void)credentials;
+  (void)common_name;
+
+  return (-1);
+#endif /* HAVE_SECKEYCHAINOPEN */
 }
 
 
 /*
- * 'http_tls_initialize()' - Initialize the TLS stack.
+ * '_httpTLSInitialize()' - Initialize the TLS stack.
  */
 
-static void
-http_tls_initialize(void)
+void
+_httpTLSInitialize(void)
 {
  /*
   * Nothing to do...
@@ -986,11 +907,11 @@ http_tls_initialize(void)
 
 
 /*
- * 'http_tls_pending()' - Return the number of pending TLS-encrypted bytes.
+ * '_httpTLSPending()' - Return the number of pending TLS-encrypted bytes.
  */
 
-static size_t
-http_tls_pending(http_t *http)         /* I - HTTP connection */
+size_t
+_httpTLSPending(http_t *http)          /* I - HTTP connection */
 {
   size_t bytes;                                /* Bytes that are available */
 
@@ -1003,11 +924,11 @@ http_tls_pending(http_t *http)           /* I - HTTP connection */
 
 
 /*
- * 'http_tls_read()' - Read from a SSL/TLS connection.
+ * '_httpTLSRead()' - Read from a SSL/TLS connection.
  */
 
-static int                             /* O - Bytes read */
-http_tls_read(http_t *http,            /* I - HTTP connection */
+int                                    /* O - Bytes read */
+_httpTLSRead(http_t *http,             /* I - HTTP connection */
              char   *buf,              /* I - Buffer to store data */
              int    len)               /* I - Length of buffer */
 {
@@ -1016,8 +937,8 @@ http_tls_read(http_t *http,                /* I - HTTP connection */
   size_t       processed;              /* Number of bytes processed */
 
 
-  error = SSLRead(http->tls, buf, len, &processed);
-  DEBUG_printf(("6http_tls_read: error=%d, processed=%d", (int)error,
+  error = SSLRead(http->tls, buf, (size_t)len, &processed);
+  DEBUG_printf(("6_httpTLSRead: error=%d, processed=%d", (int)error,
                 (int)processed));
   switch (error)
   {
@@ -1052,46 +973,11 @@ http_tls_read(http_t *http,              /* I - HTTP connection */
 
 
 /*
- * 'http_tls_set_credentials()' - Set the TLS credentials.
- */
-
-static int                             /* O - Status of connection */
-http_tls_set_credentials(http_t *http) /* I - HTTP connection */
-{
-  _cups_globals_t *cg = _cupsGlobals();        /* Pointer to library globals */
-  OSStatus             error = 0;      /* Error code */
-  http_tls_credentials_t credentials = NULL;
-                                       /* TLS credentials */
-
-
-  DEBUG_printf(("7http_tls_set_credentials(%p)", http));
-
- /*
-  * Prefer connection specific credentials...
-  */
-
-  if ((credentials = http->tls_credentials) == NULL)
-    credentials = cg->tls_credentials;
-
-  if (credentials)
-  {
-    error = SSLSetCertificate(http->tls, credentials);
-    DEBUG_printf(("4http_tls_set_credentials: SSLSetCertificate, error=%d",
-                 (int)error));
-  }
-  else
-    DEBUG_puts("4http_tls_set_credentials: No credentials to set.");
-
-  return (error);
-}
-
-
-/*
- * 'http_tls_start()' - Set up SSL/TLS support on a connection.
+ * '_httpTLSStart()' - Set up SSL/TLS support on a connection.
  */
 
-static int                             /* O - 0 on success, -1 on failure */
-http_tls_start(http_t *http)           /* I - HTTP connection */
+int                                    /* O - 0 on success, -1 on failure */
+_httpTLSStart(http_t *http)            /* I - HTTP connection */
 {
   char                 hostname[256],  /* Hostname */
                        *hostptr;       /* Pointer into hostname */
@@ -1108,11 +994,15 @@ http_tls_start(http_t *http)             /* I - HTTP connection */
   http_credential_t    *credential;    /* Credential data */
 
 
-  DEBUG_printf(("7http_tls_start(http=%p)", http));
+  DEBUG_printf(("7_httpTLSStart(http=%p)", http));
 
+#ifdef HAVE_SECKEYCHAINOPEN
   if (http->mode == _HTTP_MODE_SERVER && !tls_keychain)
+#else
+  if (http->mode == _HTTP_MODE_SERVER)
+#endif /* HAVE_SECKEYCHAINOPEN */
   {
-    DEBUG_puts("4http_tls_start: cupsSetServerCredentials not called.");
+    DEBUG_puts("4_httpTLSStart: cupsSetServerCredentials not called.");
     http->error  = errno = EINVAL;
     http->status = HTTP_STATUS_ERROR;
     _cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("Server credentials not set."), 1);
@@ -1122,7 +1012,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
 
   if ((http->tls = SSLCreateContext(kCFAllocatorDefault, http->mode == _HTTP_MODE_CLIENT ? kSSLClientSide : kSSLServerSide, kSSLStreamType)) == NULL)
   {
-    DEBUG_puts("4http_tls_start: SSLCreateContext failed.");
+    DEBUG_puts("4_httpTLSStart: SSLCreateContext failed.");
     http->error  = errno = ENOMEM;
     http->status = HTTP_STATUS_ERROR;
     _cupsSetHTTPError(HTTP_STATUS_ERROR);
@@ -1131,19 +1021,19 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
   }
 
   error = SSLSetConnection(http->tls, http);
-  DEBUG_printf(("4http_tls_start: SSLSetConnection, error=%d", (int)error));
+  DEBUG_printf(("4_httpTLSStart: SSLSetConnection, error=%d", (int)error));
 
   if (!error)
   {
     error = SSLSetIOFuncs(http->tls, http_cdsa_read, http_cdsa_write);
-    DEBUG_printf(("4http_tls_start: SSLSetIOFuncs, error=%d", (int)error));
+    DEBUG_printf(("4_httpTLSStart: SSLSetIOFuncs, error=%d", (int)error));
   }
 
   if (!error)
   {
     error = SSLSetSessionOption(http->tls, kSSLSessionOptionBreakOnServerAuth,
                                 true);
-    DEBUG_printf(("4http_tls_start: SSLSetSessionOption, error=%d",
+    DEBUG_printf(("4_httpTLSStart: SSLSetSessionOption, error=%d",
                   (int)error));
   }
 
@@ -1157,13 +1047,13 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
     {
       error = SSLSetSessionOption(http->tls,
                                  kSSLSessionOptionBreakOnCertRequested, true);
-      DEBUG_printf(("4http_tls_start: kSSLSessionOptionBreakOnCertRequested, "
+      DEBUG_printf(("4_httpTLSStart: kSSLSessionOptionBreakOnCertRequested, "
                     "error=%d", (int)error));
     }
     else
     {
-      error = http_tls_set_credentials(http);
-      DEBUG_printf(("4http_tls_start: http_tls_set_credentials, error=%d",
+      error = http_cdsa_set_credentials(http);
+      DEBUG_printf(("4_httpTLSStart: http_cdsa_set_credentials, error=%d",
                     (int)error));
     }
   }
@@ -1193,15 +1083,22 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
       addrlen = sizeof(addr);
       if (getsockname(http->fd, (struct sockaddr *)&addr, &addrlen))
       {
-       DEBUG_printf(("4http_tls_start: Unable to get socket address: %s", strerror(errno)));
+       DEBUG_printf(("4_httpTLSStart: Unable to get socket address: %s", strerror(errno)));
        hostname[0] = '\0';
       }
       else if (httpAddrLocalhost(&addr))
        hostname[0] = '\0';
       else
-       httpAddrString(&addr, hostname, sizeof(hostname));
+      {
+       httpAddrLookup(&addr, hostname, sizeof(hostname));
+        DEBUG_printf(("4_httpTLSStart: Resolved socket address to \"%s\".", hostname));
+      }
     }
 
+#ifdef HAVE_SECKEYCHAINOPEN
+    if (isdigit(hostname[0] & 255) || hostname[0] == '[')
+      hostname[0] = '\0';              /* Don't allow numeric addresses */
+
     if (hostname[0])
       http->tls_credentials = http_cdsa_copy_server(hostname);
     else if (tls_common_name)
@@ -1209,11 +1106,11 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
 
     if (!http->tls_credentials && tls_auto_create && (hostname[0] || tls_common_name))
     {
-      DEBUG_printf(("4http_tls_start: Auto-create credentials for \"%s\".", hostname[0] ? hostname : tls_common_name));
+      DEBUG_printf(("4_httpTLSStart: Auto-create credentials for \"%s\".", hostname[0] ? hostname : tls_common_name));
 
       if (!cupsMakeServerCredentials(tls_keypath, hostname[0] ? hostname : tls_common_name, 0, NULL, time(NULL) + 365 * 86400))
       {
-       DEBUG_puts("4http_tls_start: cupsMakeServerCredentials failed.");
+       DEBUG_puts("4_httpTLSStart: cupsMakeServerCredentials failed.");
        http->error  = errno = EINVAL;
        http->status = HTTP_STATUS_ERROR;
        _cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("Unable to create server credentials."), 1);
@@ -1223,10 +1120,11 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
 
       http->tls_credentials = http_cdsa_copy_server(hostname[0] ? hostname : tls_common_name);
     }
+#endif /* HAVE_SECKEYCHAINOPEN */
 
     if (!http->tls_credentials)
     {
-      DEBUG_puts("4http_tls_start: Unable to find server credentials.");
+      DEBUG_puts("4_httpTLSStart: Unable to find server credentials.");
       http->error  = errno = EINVAL;
       http->status = HTTP_STATUS_ERROR;
       _cupsSetError(IPP_STATUS_ERROR_INTERNAL, _("Unable to find server credentials."), 1);
@@ -1236,10 +1134,10 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
 
     error = SSLSetCertificate(http->tls, http->tls_credentials);
 
-    DEBUG_printf(("4http_tls_start: SSLSetCertificate, error=%d", (int)error));
+    DEBUG_printf(("4_httpTLSStart: SSLSetCertificate, error=%d", (int)error));
   }
 
-  DEBUG_printf(("4http_tls_start: tls_credentials=%p", http->tls_credentials));
+  DEBUG_printf(("4_httpTLSStart: tls_credentials=%p", http->tls_credentials));
 
  /*
   * Let the server know which hostname/domain we are trying to connect to
@@ -1270,7 +1168,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
 
     error = SSLSetPeerDomainName(http->tls, hostname, strlen(hostname));
 
-    DEBUG_printf(("4http_tls_start: SSLSetPeerDomainName, error=%d", (int)error));
+    DEBUG_printf(("4_httpTLSStart: SSLSetPeerDomainName, error=%d", (int)error));
   }
 
   if (!error)
@@ -1281,7 +1179,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
     {
       error = SSLHandshake(http->tls);
 
-      DEBUG_printf(("4http_tls_start: SSLHandshake returned %d.", (int)error));
+      DEBUG_printf(("4_httpTLSStart: SSLHandshake returned %d.", (int)error));
 
       switch (error)
       {
@@ -1306,7 +1204,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
                httpFreeCredentials(credentials);
              }
 
-             DEBUG_printf(("4http_tls_start: Server certificate callback "
+             DEBUG_printf(("4_httpTLSStart: Server certificate callback "
                            "returned %d.", (int)error));
            }
            break;
@@ -1328,7 +1226,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
 
                    if ((credential = malloc(sizeof(*credential))) != NULL)
                    {
-                     credential->datalen = CFDataGetLength(data);
+                     credential->datalen = (size_t)CFDataGetLength(data);
                      if ((credential->data = malloc(credential->datalen)))
                      {
                        memcpy((void *)credential->data, CFDataGetBytePtr(data),
@@ -1349,7 +1247,7 @@ http_tls_start(http_t *http)              /* I - HTTP connection */
                error = (cg->client_cert_cb)(http, http->tls, names,
                                             cg->client_cert_data);
 
-               DEBUG_printf(("4http_tls_start: Client certificate callback "
+               DEBUG_printf(("4_httpTLSStart: Client certificate callback "
                              "returned %d.", (int)error));
              }
 
@@ -1428,11 +1326,11 @@ http_tls_start(http_t *http)            /* I - HTTP connection */
 
 
 /*
- * 'http_tls_stop()' - Shut down SSL/TLS on a connection.
+ * '_httpTLSStop()' - Shut down SSL/TLS on a connection.
  */
 
-static void
-http_tls_stop(http_t *http)            /* I - HTTP connection */
+void
+_httpTLSStop(http_t *http)             /* I - HTTP connection */
 {
   while (SSLClose(http->tls) == errSSLWouldBlock)
     usleep(1000);
@@ -1448,11 +1346,11 @@ http_tls_stop(http_t *http)             /* I - HTTP connection */
 
 
 /*
- * 'http_tls_write()' - Write to a SSL/TLS connection.
+ * '_httpTLSWrite()' - Write to a SSL/TLS connection.
  */
 
-static int                             /* O - Bytes written */
-http_tls_write(http_t     *http,       /* I - HTTP connection */
+int                                    /* O - Bytes written */
+_httpTLSWrite(http_t     *http,                /* I - HTTP connection */
               const char *buf,         /* I - Buffer holding data */
               int        len)          /* I - Length of buffer */
 {
@@ -1461,9 +1359,9 @@ http_tls_write(http_t     *http,  /* I - HTTP connection */
   size_t       processed;              /* Number of bytes processed */
 
 
-  DEBUG_printf(("2http_tls_write(http=%p, buf=%p, len=%d)", http, buf, len));
+  DEBUG_printf(("2_httpTLSWrite(http=%p, buf=%p, len=%d)", http, buf, len));
 
-  error = SSLWrite(http->tls, buf, len, &processed);
+  error = SSLWrite(http->tls, buf, (size_t)len, &processed);
 
   switch (error)
   {
@@ -1497,129 +1395,268 @@ http_tls_write(http_t     *http,      /* I - HTTP connection */
        break;
   }
 
-  DEBUG_printf(("3http_tls_write: Returning %d.", (int)result));
+  DEBUG_printf(("3_httpTLSWrite: Returning %d.", (int)result));
 
   return ((int)result);
 }
 
 
-#if 0
+#ifdef HAVE_SECKEYCHAINOPEN
 /*
- * 'cupsdEndTLS()' - Shutdown a secure session with the client.
+ * 'http_cdsa_copy_server()' - Find and copy server credentials from the keychain.
  */
 
-int                                    /* O - 1 on success, 0 on error */
-cupsdEndTLS(cupsd_client_t *con)       /* I - Client connection */
+static CFArrayRef                      /* O - Array of certificates or NULL */
+http_cdsa_copy_server(
+    const char *common_name)           /* I - Server's hostname */
 {
-  while (SSLClose(con->http.tls) == errSSLWouldBlock)
-    usleep(1000);
+  OSStatus             err;            /* Error info */
+  SecIdentitySearchRef search = NULL;  /* Search reference */
+  SecIdentityRef       identity = NULL;/* Identity */
+  CFArrayRef           certificates = NULL;
+                                       /* Certificate array */
+  SecPolicyRef         policy = NULL;  /* Policy ref */
+  CFStringRef          cfcommon_name = NULL;
+                                       /* Server name */
+  CFMutableDictionaryRef query = NULL; /* Query qualifiers */
+  CFArrayRef           list = NULL;    /* Keychain list */
 
-  CFRelease(con->http.tls);
-  con->http.tls = NULL;
 
-  if (con->http.tls_credentials)
-    CFRelease(con->http.tls_credentials);
+  cfcommon_name = CFStringCreateWithCString(kCFAllocatorDefault, common_name, kCFStringEncodingUTF8);
 
-  return (1);
+  policy = SecPolicyCreateSSL(1, cfcommon_name);
+
+  if (cfcommon_name)
+    CFRelease(cfcommon_name);
+
+  if (!policy)
+    goto cleanup;
+
+  if (!(query = CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)))
+    goto cleanup;
+
+  _cupsMutexLock(&tls_mutex);
+
+  list = CFArrayCreate(kCFAllocatorDefault, (const void **)&tls_keychain, 1, &kCFTypeArrayCallBacks);
+
+  CFDictionaryAddValue(query, kSecClass, kSecClassIdentity);
+  CFDictionaryAddValue(query, kSecMatchPolicy, policy);
+  CFDictionaryAddValue(query, kSecReturnRef, kCFBooleanTrue);
+  CFDictionaryAddValue(query, kSecMatchLimit, kSecMatchLimitOne);
+  CFDictionaryAddValue(query, kSecMatchSearchList, list);
+
+  CFRelease(list);
+
+  err = SecItemCopyMatching(query, (CFTypeRef *)&identity);
+
+  _cupsMutexUnlock(&tls_mutex);
+
+  if (err)
+    goto cleanup;
+
+  if (CFGetTypeID(identity) != SecIdentityGetTypeID())
+    goto cleanup;
+
+  if ((certificates = CFArrayCreate(NULL, (const void **)&identity, 1, &kCFTypeArrayCallBacks)) == NULL)
+    goto cleanup;
+
+  cleanup :
+
+  if (search)
+    CFRelease(search);
+  if (identity)
+    CFRelease(identity);
+
+  if (policy)
+    CFRelease(policy);
+  if (query)
+    CFRelease(query);
+
+  return (certificates);
+}
+#endif /* HAVE_SECKEYCHAINOPEN */
+
+
+/*
+ * 'http_cdsa_create_credential()' - Create a single credential in the internal format.
+ */
+
+static SecCertificateRef                       /* O - Certificate */
+http_cdsa_create_credential(
+    http_credential_t *credential)             /* I - Credential */
+{
+  if (!credential)
+    return (NULL);
+
+  return (SecCertificateCreateWithBytes(kCFAllocatorDefault, credential->data, (CFIndex)credential->datalen));
 }
 
 
 /*
- * 'cupsdStartTLS()' - Start a secure session with the client.
+ * 'http_cdsa_default_path()' - Get the default keychain path.
  */
 
-int                                    /* O - 1 on success, 0 on error */
-cupsdStartTLS(cupsd_client_t *con)     /* I - Client connection */
+static const char *                    /* O - Keychain path */
+http_cdsa_default_path(char   *buffer, /* I - Path buffer */
+                       size_t bufsize) /* I - Size of buffer */
 {
-  OSStatus     error = 0;              /* Error code */
-  SecTrustRef  peerTrust;              /* Peer certificates */
+  const char *home = getenv("HOME");   /* HOME environment variable */
+
+
+  if (getuid() && home)
+    snprintf(buffer, bufsize, "%s/Library/Keychains/login.keychain", home);
+  else
+    strlcpy(buffer, "/Library/Keychains/System.keychain", bufsize);
+
+  DEBUG_printf(("1http_cdsa_default_path: Using default path \"%s\".", buffer));
 
+  return (buffer);
+}
+
+
+/*
+ * 'http_cdsa_read()' - Read function for the CDSA library.
+ */
+
+static OSStatus                                /* O  - -1 on error, 0 on success */
+http_cdsa_read(
+    SSLConnectionRef connection,       /* I  - SSL/TLS connection */
+    void             *data,            /* I  - Data buffer */
+    size_t           *dataLength)      /* IO - Number of bytes */
+{
+  OSStatus     result;                 /* Return value */
+  ssize_t      bytes;                  /* Number of bytes read */
+  http_t       *http;                  /* HTTP connection */
 
-  cupsdLogMessage(CUPSD_LOG_DEBUG, "[Client %d] Encrypting connection.",
-                  con->http.fd);
 
-  con->http.tls_credentials = copy_cdsa_certificate(con);
+  http = (http_t *)connection;
 
-  if (!con->http.tls_credentials)
+  if (!http->blocking)
   {
    /*
-    * No keychain (yet), make a self-signed certificate...
+    * Make sure we have data before we read...
     */
 
-    if (make_certificate(con))
-      con->http.tls_credentials = copy_cdsa_certificate(con);
+    while (!_httpWait(http, http->wait_value, 0))
+    {
+      if (http->timeout_cb && (*http->timeout_cb)(http, http->timeout_data))
+       continue;
+
+      http->error = ETIMEDOUT;
+      return (-1);
+    }
   }
 
-  if (!con->http.tls_credentials)
+  do
   {
-    cupsdLogMessage(CUPSD_LOG_ERROR,
-                   "Could not find signing key in keychain \"%s\"",
-                   ServerCertificate);
-    error = errSSLBadConfiguration;
+    bytes = recv(http->fd, data, *dataLength, 0);
   }
+  while (bytes == -1 && (errno == EINTR || errno == EAGAIN));
 
-  if (!error)
-    con->http.tls = SSLCreateContext(kCFAllocatorDefault, kSSLServerSide,
-                                     kSSLStreamType);
+  if ((size_t)bytes == *dataLength)
+  {
+    result = 0;
+  }
+  else if (bytes > 0)
+  {
+    *dataLength = (size_t)bytes;
+    result = errSSLWouldBlock;
+  }
+  else
+  {
+    *dataLength = 0;
 
-  if (!error)
-    error = SSLSetIOFuncs(con->http.tls, http_cdsa_read, http_cdsa_write);
+    if (bytes == 0)
+      result = errSSLClosedGraceful;
+    else if (errno == EAGAIN)
+      result = errSSLWouldBlock;
+    else
+      result = errSSLClosedAbort;
+  }
 
-  if (!error)
-    error = SSLSetConnection(con->http.tls, HTTP(con));
+  return (result);
+}
 
-  if (!error)
-    error = SSLSetCertificate(con->http.tls, con->http.tls_credentials);
 
-  if (!error)
-  {
-   /*
-    * Perform SSL/TLS handshake
-    */
+/*
+ * 'http_cdsa_set_credentials()' - Set the TLS credentials.
+ */
 
-    while ((error = SSLHandshake(con->http.tls)) == errSSLWouldBlock)
-      usleep(1000);
-  }
+static int                             /* O - Status of connection */
+http_cdsa_set_credentials(http_t *http)        /* I - HTTP connection */
+{
+  _cups_globals_t *cg = _cupsGlobals();        /* Pointer to library globals */
+  OSStatus             error = 0;      /* Error code */
+  http_tls_credentials_t credentials = NULL;
+                                       /* TLS credentials */
 
-  if (error)
-  {
-    cupsdLogMessage(CUPSD_LOG_ERROR,
-                    "Unable to encrypt connection from %s - %s (%d)",
-                    con->http.hostname, cssmErrorString(error), (int)error);
 
-    con->http.error  = error;
-    con->http.status = HTTP_ERROR;
+  DEBUG_printf(("7http_tls_set_credentials(%p)", http));
 
-    if (con->http.tls)
-    {
-      CFRelease(con->http.tls);
-      con->http.tls = NULL;
-    }
+ /*
+  * Prefer connection specific credentials...
+  */
 
-    if (con->http.tls_credentials)
-    {
-      CFRelease(con->http.tls_credentials);
-      con->http.tls_credentials = NULL;
-    }
+  if ((credentials = http->tls_credentials) == NULL)
+    credentials = cg->tls_credentials;
 
-    return (0);
+  if (credentials)
+  {
+    error = SSLSetCertificate(http->tls, credentials);
+    DEBUG_printf(("4http_tls_set_credentials: SSLSetCertificate, error=%d",
+                 (int)error));
   }
+  else
+    DEBUG_puts("4http_tls_set_credentials: No credentials to set.");
+
+  return (error);
+}
+
+
+/*
+ * 'http_cdsa_write()' - Write function for the CDSA library.
+ */
+
+static OSStatus                                /* O  - -1 on error, 0 on success */
+http_cdsa_write(
+    SSLConnectionRef connection,       /* I  - SSL/TLS connection */
+    const void       *data,            /* I  - Data buffer */
+    size_t           *dataLength)      /* IO - Number of bytes */
+{
+  OSStatus     result;                 /* Return value */
+  ssize_t      bytes;                  /* Number of bytes read */
+  http_t       *http;                  /* HTTP connection */
 
-  cupsdLogMessage(CUPSD_LOG_DEBUG, "Connection from %s now encrypted.",
-                  con->http.hostname);
 
-  if (!SSLCopyPeerTrust(con->http.tls, &peerTrust) && peerTrust)
+  http = (http_t *)connection;
+
+  do
   {
-    cupsdLogMessage(CUPSD_LOG_DEBUG, "Received %d peer certificates.",
-                   (int)SecTrustGetCertificateCount(peerTrust));
-    CFRelease(peerTrust);
+    bytes = write(http->fd, data, *dataLength);
+  }
+  while (bytes == -1 && (errno == EINTR || errno == EAGAIN));
+
+  if ((size_t)bytes == *dataLength)
+  {
+    result = 0;
+  }
+  else if (bytes >= 0)
+  {
+    *dataLength = (size_t)bytes;
+    result = errSSLWouldBlock;
   }
   else
-    cupsdLogMessage(CUPSD_LOG_DEBUG, "Received NO peer certificates.");
+  {
+    *dataLength = 0;
 
-  return (1);
+    if (errno == EAGAIN)
+      result = errSSLWouldBlock;
+    else
+      result = errSSLClosedAbort;
+  }
+
+  return (result);
 }
-#endif /* 0 */
 
 
 /*