]> git.ipfire.org Git - thirdparty/cups.git/blobdiff - systemv/lp.c
Full sweep of all Clang warnings, plus some bug fixes for incorrect memcpy usage.
[thirdparty/cups.git] / systemv / lp.c
index 8500f802e55d84d07e1b0c28e391e652b9fac330..9e895d4d6400be9518625da5a37027ae1db91ed7 100644 (file)
@@ -1,69 +1,34 @@
 /*
- * "$Id: lp.c 6356 2007-03-19 13:54:48Z mike $"
+ * "$Id$"
  *
- *   "lp" command for the Common UNIX Printing System (CUPS).
+ * "lp" command for CUPS.
  *
- *   Copyright 1997-2007 by Easy Software Products.
+ * Copyright 2007-2014 by Apple Inc.
+ * Copyright 1997-2007 by Easy Software Products.
  *
- *   These coded instructions, statements, and computer programs are the
- *   property of Easy Software Products and are protected by Federal
- *   copyright law.  Distribution and use rights are outlined in the file
- *   "LICENSE.txt" which should have been included with this file.  If this
- *   file is missing or damaged please contact Easy Software Products
- *   at:
- *
- *       Attn: CUPS Licensing Information
- *       Easy Software Products
- *       44141 Airport View Drive, Suite 204
- *       Hollywood, Maryland 20636 USA
- *
- *       Voice: (301) 373-9600
- *       EMail: cups-info@cups.org
- *         WWW: http://www.cups.org
- *
- * Contents:
- *
- *   main()          - Parse options and send files for printing.
- *   restart_job()   - Restart a job.
- *   set_job_attrs() - Set job attributes.
- *   sighandler()    - Signal catcher for when we print from stdin...
+ * These coded instructions, statements, and computer programs are the
+ * property of Apple Inc. and are protected by Federal copyright
+ * law.  Distribution and use rights are outlined in the file "LICENSE.txt"
+ * which should have been included with this file.  If this file is
+ * file is missing or damaged, see the license at "http://www.cups.org/".
  */
 
 /*
  * Include necessary headers...
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <errno.h>
-#include <cups/string.h>
-#include <cups/cups.h>
-#include <cups/i18n.h>
-
-
-#ifndef WIN32
-#  include <unistd.h>
-#  include <signal.h>
+#include <cups/cups-private.h>
 
 
 /*
  * Local functions.
  */
 
-void   sighandler(int);
-#endif /* !WIN32 */
 int    restart_job(const char *command, int job_id);
 int    set_job_attrs(const char *command, int job_id, int num_options,
                      cups_option_t *options);
 
 
-/*
- * Globals...
- */
-
-char   tempfile[1024];         /* Temporary file for printing from stdin */
-
-
 /*
  * 'main()' - Parse options and send files for printing.
  */
@@ -75,28 +40,19 @@ main(int  argc,                             /* I - Number of command-line arguments */
   int          i, j;                   /* Looping vars */
   int          job_id;                 /* Job ID */
   char         *printer,               /* Printer name */
-               *instance,              /* Instance name */ 
+               *instance,              /* Instance name */
                *val,                   /* Option value */
                *title;                 /* Job title */
   int          priority;               /* Job priority (1-100) */
   int          num_copies;             /* Number of copies per file */
   int          num_files;              /* Number of files to print */
   const char   *files[1000];           /* Files to print */
-  int          num_dests;              /* Number of destinations */
-  cups_dest_t  *dests,                 /* Destinations */
-               *dest;                  /* Selected destination */
+  cups_dest_t  *dest;                  /* Selected destination */
   int          num_options;            /* Number of options */
   cups_option_t        *options;               /* Options */
   int          end_options;            /* No more options? */
   int          silent;                 /* Silent or verbose output? */
   char         buffer[8192];           /* Copy buffer */
-  ssize_t      bytes;                  /* Bytes copied */
-  off_t                filesize;               /* Size of temp file */
-  int          temp;                   /* Temporary file descriptor */
-#if defined(HAVE_SIGACTION) && !defined(HAVE_SIGSET)
-  struct sigaction action;             /* Signal action */
-  struct sigaction oldaction;          /* Old signal action */
-#endif /* HAVE_SIGACTION && !HAVE_SIGSET*/
 
 
 #ifdef __sun
@@ -121,8 +77,7 @@ main(int  argc,                              /* I - Number of command-line arguments */
 
   silent      = 0;
   printer     = NULL;
-  num_dests   = 0;
-  dests       = NULL;
+  dest        = NULL;
   num_options = 0;
   options     = NULL;
   num_files   = 0;
@@ -138,8 +93,7 @@ main(int  argc,                              /* I - Number of command-line arguments */
 #ifdef HAVE_SSL
            cupsSetEncryption(HTTP_ENCRYPT_REQUIRED);
 #else
-            _cupsLangPrintf(stderr,
-                           _("%s: Sorry, no encryption support compiled in!\n"),
+            _cupsLangPrintf(stderr, _("%s: Sorry, no encryption support."),
                            argv[0]);
 #endif /* HAVE_SSL */
            break;
@@ -153,16 +107,15 @@ main(int  argc,                           /* I - Number of command-line arguments */
              if (i >= argc)
              {
                _cupsLangPrintf(stderr,
-                               _("%s: Error - expected username after "
-                                 "\'-U\' option!\n"),
-                               argv[0]);
+                               _("%s: Error - expected username after \"-U\" "
+                                 "option."), argv[0]);
                return (1);
              }
 
               cupsSetUser(argv[i]);
            }
            break;
-           
+
         case 'c' : /* Copy to spool dir (always enabled) */
            break;
 
@@ -177,8 +130,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected destination after "
-                                 "\'-d\' option!\n"),
-                               argv[0]);
+                                 "\"-d\" option."), argv[0]);
                return (1);
               }
 
@@ -188,17 +140,24 @@ main(int  argc,                           /* I - Number of command-line arguments */
             if ((instance = strrchr(printer, '/')) != NULL)
              *instance++ = '\0';
 
-           if (num_dests == 0)
-             num_dests = cupsGetDests(&dests);
-
-            if ((dest = cupsGetDest(printer, instance, num_dests, dests)) != NULL)
+            if ((dest = cupsGetNamedDest(CUPS_HTTP_DEFAULT, printer,
+                                         instance)) != NULL)
            {
              for (j = 0; j < dest->num_options; j ++)
-               if (cupsGetOption(dest->options[j].name, num_options, options) == NULL)
+               if (cupsGetOption(dest->options[j].name, num_options,
+                                 options) == NULL)
                  num_options = cupsAddOption(dest->options[j].name,
                                              dest->options[j].value,
                                              num_options, &options);
            }
+           else if (cupsLastError() == IPP_STATUS_ERROR_BAD_REQUEST ||
+                    cupsLastError() == IPP_STATUS_ERROR_VERSION_NOT_SUPPORTED)
+           {
+             _cupsLangPrintf(stderr,
+                             _("%s: Error - add '/version=1.1' to server "
+                               "name."), argv[0]);
+             return (1);
+           }
            break;
 
         case 'f' : /* Form */
@@ -209,14 +168,14 @@ main(int  argc,                           /* I - Number of command-line arguments */
              if (i >= argc)
              {
                _cupsLangPrintf(stderr,
-                               _("%s: Error - expected form after \'-f\' "
-                                 "option!\n"),
+                               _("%s: Error - expected form after \"-f\" "
+                                 "option."),
                                argv[0]);
                return (1);
               }
            }
 
-           _cupsLangPrintf(stderr, _("%s: Warning - form option ignored!\n"),
+           _cupsLangPrintf(stderr, _("%s: Warning - form option ignored."),
                            argv[0]);
            break;
 
@@ -231,8 +190,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected hostname after "
-                                 "\'-h\' option!\n"),
-                               argv[0]);
+                                 "\"-h\" option."), argv[0]);
                return (1);
               }
 
@@ -250,7 +208,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              if (i >= argc)
              {
                _cupsLangPrintf(stderr,
-                               _("%s: Expected job ID after \'-i\' option!\n"),
+                               _("%s: Expected job ID after \"-i\" option."),
                                argv[0]);
                return (1);
               }
@@ -262,8 +220,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
            {
              _cupsLangPrintf(stderr,
                              _("%s: Error - cannot print files and alter "
-                               "jobs simultaneously!\n"),
-                             argv[0]);
+                               "jobs simultaneously."), argv[0]);
              return (1);
            }
 
@@ -274,7 +231,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
 
             if (job_id < 0)
            {
-             _cupsLangPrintf(stderr, _("%s: Error - bad job ID!\n"), argv[0]);
+             _cupsLangPrintf(stderr, _("%s: Error - bad job ID."), argv[0]);
              break;
            }
            break;
@@ -308,8 +265,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected copies after "
-                                 "\'-n\' option!\n"),
-                               argv[0]);
+                                 "\"-n\" option."), argv[0]);
                return (1);
               }
 
@@ -317,12 +273,14 @@ main(int  argc,                           /* I - Number of command-line arguments */
            }
 
             sprintf(buffer, "%d", num_copies);
-            num_options = cupsAddOption("copies", buffer, num_options, &options);
+            num_options = cupsAddOption("copies", buffer, num_options,
+                                       &options);
            break;
 
        case 'o' : /* Option */
            if (argv[i][2] != '\0')
-             num_options = cupsParseOptions(argv[i] + 2, num_options, &options);
+             num_options = cupsParseOptions(argv[i] + 2, num_options,
+                                            &options);
            else
            {
              i ++;
@@ -330,9 +288,8 @@ main(int  argc,                             /* I - Number of command-line arguments */
              if (i >= argc)
              {
                _cupsLangPrintf(stderr,
-                               _("%s: Error - expected option string after "
-                                 "\'-o\' option!\n"),
-                               argv[0]);
+                               _("%s: Error - expected option=value after "
+                                 "\"-o\" option."), argv[0]);
                return (1);
               }
 
@@ -352,8 +309,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected priority after "
-                                 "\'-%c\' option!\n"),
-                               argv[0], argv[i][1]);
+                                 "\"-%c\" option."), argv[0], argv[i][1]);
                return (1);
               }
 
@@ -375,13 +331,13 @@ main(int  argc,                           /* I - Number of command-line arguments */
            {
              _cupsLangPrintf(stderr,
                              _("%s: Error - priority must be between 1 and "
-                               "100.\n"),
-                             argv[0]);
+                               "100."), argv[0]);
              return (1);
            }
 
             sprintf(buffer, "%d", priority);
-            num_options = cupsAddOption("job-priority", buffer, num_options, &options);
+            num_options = cupsAddOption("job-priority", buffer, num_options,
+                                       &options);
            break;
 
        case 's' : /* Silent */
@@ -399,8 +355,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected title after "
-                                 "\'-t\' option!\n"),
-                               argv[0]);
+                                 "\"-t\" option."), argv[0]);
                return (1);
               }
 
@@ -417,15 +372,13 @@ main(int  argc,                           /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected mode list after "
-                                 "\'-y\' option!\n"),
-                               argv[0]);
+                                 "\"-y\" option."), argv[0]);
                return (1);
               }
            }
 
            _cupsLangPrintf(stderr,
-                           _("%s: Warning - mode option ignored!\n"),
-                           argv[0]);
+                           _("%s: Warning - mode option ignored."), argv[0]);
            break;
 
         case 'H' : /* Hold job */
@@ -439,8 +392,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected hold name after "
-                                 "\'-H\' option!\n"),
-                               argv[0]);
+                                 "\"-H\" option."), argv[0]);
                return (1);
               }
 
@@ -455,16 +407,19 @@ main(int  argc,                           /* I - Number of command-line arguments */
               num_options = cupsAddOption("job-hold-until", "no-hold",
                                          num_options, &options);
            else if (!strcmp(val, "immediate"))
+           {
+              num_options = cupsAddOption("job-hold-until", "no-hold",
+                                         num_options, &options);
               num_options = cupsAddOption("job-priority", "100",
                                          num_options, &options);
+           }
            else if (!strcmp(val, "restart"))
            {
              if (job_id < 1)
              {
                _cupsLangPrintf(stderr,
-                               _("%s: Need job ID (\'-i jobid\') before "
-                                 "\'-H restart\'!\n"),
-                               argv[0]);
+                               _("%s: Need job ID (\"-i jobid\") before "
+                                 "\"-H restart\"."), argv[0]);
                return (1);
              }
 
@@ -487,8 +442,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected page list after "
-                                 "\'-P\' option!\n"),
-                               argv[0]);
+                                 "\"-P\" option."), argv[0]);
                return (1);
               }
 
@@ -508,14 +462,13 @@ main(int  argc,                           /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected character set after "
-                                 "\'-S\' option!\n"),
-                               argv[0]);
+                                 "\"-S\" option."), argv[0]);
                return (1);
               }
            }
 
            _cupsLangPrintf(stderr,
-                           _("%s: Warning - character set option ignored!\n"),
+                           _("%s: Warning - character set option ignored."),
                            argv[0]);
            break;
 
@@ -528,23 +481,29 @@ main(int  argc,                           /* I - Number of command-line arguments */
              {
                _cupsLangPrintf(stderr,
                                _("%s: Error - expected content type after "
-                                 "\'-T\' option!\n"),
-                               argv[0]);
+                                 "\"-T\" option."), argv[0]);
                return (1);
               }
            }
 
            _cupsLangPrintf(stderr,
-                           _("%s: Warning - content type option ignored!\n"),
+                           _("%s: Warning - content type option ignored."),
                            argv[0]);
            break;
 
         case '-' : /* Stop processing options */
+            if (argv[i][2])
+            {
+             _cupsLangPrintf(stderr, _("%s: Error - unknown option \"%s\"."),
+                             argv[0], argv[i]);
+             return (1);
+           }
+
            end_options = 1;
            break;
 
        default :
-           _cupsLangPrintf(stderr, _("%s: Error - unknown option \'%c\'!\n"),
+           _cupsLangPrintf(stderr, _("%s: Error - unknown option \"%c\"."),
                            argv[0], argv[i][1]);
            return (1);
       }
@@ -554,8 +513,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
       {
         _cupsLangPrintf(stderr,
                        _("%s: Error - cannot print from stdin if files or a "
-                         "job ID are provided!\n"),
-                        argv[0]);
+                         "job ID are provided."), argv[0]);
        return (1);
       }
 
@@ -569,7 +527,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
 
       if (access(argv[i], R_OK) != 0)
       {
-        _cupsLangPrintf(stderr, _("%s: Error - unable to access \"%s\" - %s\n"),
+        _cupsLangPrintf(stderr, _("%s: Error - unable to access \"%s\" - %s"),
                        argv[0], argv[i], strerror(errno));
         return (1);
       }
@@ -586,7 +544,7 @@ main(int  argc,                             /* I - Number of command-line arguments */
       }
     }
     else
-      _cupsLangPrintf(stderr, _("%s: Error - too many files - \"%s\"\n"),
+      _cupsLangPrintf(stderr, _("%s: Error - too many files - \"%s\"."),
                       argv[0], argv[i]);
 
  /*
@@ -602,10 +560,7 @@ main(int  argc,                            /* I - Number of command-line arguments */
 
   if (printer == NULL)
   {
-    if (num_dests == 0)
-      num_dests = cupsGetDests(&dests);
-
-    if ((dest = cupsGetDest(NULL, NULL, num_dests, dests)) != NULL)
+    if ((dest = cupsGetNamedDest(NULL, NULL, NULL)) != NULL)
     {
       printer = dest->name;
 
@@ -615,6 +570,14 @@ main(int  argc,                            /* I - Number of command-line arguments */
                                      dest->options[j].value,
                                      num_options, &options);
     }
+    else if (cupsLastError() == IPP_STATUS_ERROR_BAD_REQUEST ||
+            cupsLastError() == IPP_STATUS_ERROR_VERSION_NOT_SUPPORTED)
+    {
+      _cupsLangPrintf(stderr,
+                     _("%s: Error - add '/version=1.1' to server "
+                       "name."), argv[0]);
+      return (1);
+    }
   }
 
   if (printer == NULL)
@@ -634,18 +597,17 @@ main(int  argc,                           /* I - Number of command-line arguments */
     else
       val = "LPDEST";
 
-    if (printer && !cupsGetDest(printer, NULL, num_dests, dests))
+    if (printer && !cupsGetNamedDest(NULL, printer, NULL))
       _cupsLangPrintf(stderr,
                      _("%s: Error - %s environment variable names "
-                       "non-existent destination \"%s\"!\n"),
-                     argv[0], val, printer);
+                       "non-existent destination \"%s\"."), argv[0], val,
+                     printer);
     else if (cupsLastError() == IPP_NOT_FOUND)
       _cupsLangPrintf(stderr,
-                     _("%s: Error - no default destination available.\n"),
+                     _("%s: Error - no default destination available."),
                      argv[0]);
     else
-      _cupsLangPrintf(stderr,
-                     _("%s: Error - scheduler not responding!\n"),
+      _cupsLangPrintf(stderr, _("%s: Error - scheduler not responding."),
                      argv[0]);
 
     return (1);
@@ -653,82 +615,51 @@ main(int  argc,                           /* I - Number of command-line arguments */
 
   if (num_files > 0)
     job_id = cupsPrintFiles(printer, num_files, files, title, num_options, options);
-  else
+  else if ((job_id = cupsCreateJob(CUPS_HTTP_DEFAULT, printer,
+                                   title ? title : "(stdin)",
+                                   num_options, options)) > 0)
   {
-    num_files = 1;
-
-#ifndef WIN32
-#  if defined(HAVE_SIGSET)
-    sigset(SIGHUP, sighandler);
-    if (sigset(SIGINT, sighandler) == SIG_IGN)
-      sigset(SIGINT, SIG_IGN);
-    sigset(SIGTERM, sighandler);
-#  elif defined(HAVE_SIGACTION)
-    memset(&action, 0, sizeof(action));
-    action.sa_handler = sighandler;
-
-    sigaction(SIGHUP, &action, NULL);
-    sigaction(SIGINT, NULL, &oldaction);
-    if (oldaction.sa_handler != SIG_IGN)
-      sigaction(SIGINT, &action, NULL);
-    sigaction(SIGTERM, &action, NULL);
-#  else
-    signal(SIGHUP, sighandler);
-    if (signal(SIGINT, sighandler) == SIG_IGN)
-      signal(SIGINT, SIG_IGN);
-    signal(SIGTERM, sighandler);
-#  endif
-#endif /* !WIN32 */
-
-    temp = cupsTempFd(tempfile, sizeof(tempfile));
-
-    if (temp < 0)
-    {
-      _cupsLangPrintf(stderr,
-                     _("%s: Error - unable to create temporary file \"%s\" - %s\n"),
-                     argv[0], tempfile, strerror(errno));
-      return (1);
-    }
+    http_status_t      status;         /* Write status */
+    const char         *format;        /* Document format */
+    ssize_t            bytes;          /* Bytes read */
 
-    while ((bytes = read(0, buffer, sizeof(buffer))) > 0)
-      if (write(temp, buffer, bytes) < 0)
-      {
-       _cupsLangPrintf(stderr,
-                       _("%s: Error - unable to write to temporary file "
-                         "\"%s\" - %s\n"),
-                       argv[0], tempfile, strerror(errno));
-        close(temp);
-        unlink(tempfile);
-       return (1);
-      }
+    if (cupsGetOption("raw", num_options, options))
+      format = CUPS_FORMAT_RAW;
+    else if ((format = cupsGetOption("document-format", num_options,
+                                     options)) == NULL)
+      format = CUPS_FORMAT_AUTO;
 
-    filesize = lseek(temp, 0, SEEK_CUR);
-    close(temp);
+    status = cupsStartDocument(CUPS_HTTP_DEFAULT, printer, job_id, NULL,
+                               format, 1);
 
-    if (filesize <= 0)
+    while (status == HTTP_CONTINUE &&
+           (bytes = read(0, buffer, sizeof(buffer))) > 0)
+      status = cupsWriteRequestData(CUPS_HTTP_DEFAULT, buffer, (size_t)bytes);
+
+    if (status != HTTP_CONTINUE)
     {
-      _cupsLangPrintf(stderr,
-                     _("%s: Error - stdin is empty, so no job has been sent.\n"),
-                     argv[0]);
-      unlink(tempfile);
+      _cupsLangPrintf(stderr, _("%s: Error - unable to queue from stdin - %s."),
+                     argv[0], httpStatus(status));
+      cupsFinishDocument(CUPS_HTTP_DEFAULT, printer);
+      cupsCancelJob2(CUPS_HTTP_DEFAULT, printer, job_id, 0);
       return (1);
     }
 
-    if (title)
-      job_id = cupsPrintFile(printer, tempfile, title, num_options, options);
-    else
-      job_id = cupsPrintFile(printer, tempfile, "(stdin)", num_options, options);
-
-    unlink(tempfile);
+    if (cupsFinishDocument(CUPS_HTTP_DEFAULT, printer) != IPP_OK)
+    {
+      _cupsLangPrintf(stderr, "%s: %s", argv[0], cupsLastErrorString());
+      cupsCancelJob2(CUPS_HTTP_DEFAULT, printer, job_id, 0);
+      return (1);
+    }
   }
 
   if (job_id < 1)
   {
-    _cupsLangPrintf(stderr, "%s: %s\n", argv[0], cupsLastErrorString());
+    _cupsLangPrintf(stderr, "%s: %s", argv[0], cupsLastErrorString());
     return (1);
   }
   else if (!silent)
-    _cupsLangPrintf(stdout, _("request id is %s-%d (%d file(s))\n"),
+    _cupsLangPrintf(stdout, _("request id is %s-%d (%d file(s))"),
                    printer, job_id, num_files);
 
   return (0);
@@ -743,13 +674,10 @@ int                                       /* O - Exit status */
 restart_job(const char *command,       /* I - Command name */
             int        job_id)         /* I - Job ID */
 {
-  http_t       *http;                  /* HTTP connection to server */
   ipp_t                *request;               /* IPP request */
   char         uri[HTTP_MAX_URI];      /* URI for job */
 
 
-  http = httpConnectEncrypt(cupsServer(), ippPort(), cupsEncryption());
-
   request = ippNewRequest(IPP_RESTART_JOB);
 
   sprintf(uri, "ipp://localhost/jobs/%d", job_id);
@@ -760,11 +688,19 @@ restart_job(const char *command,  /* I - Command name */
   ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                "requesting-user-name", NULL, cupsUser());
 
-  ippDelete(cupsDoRequest(http, request, "/jobs"));
+  ippDelete(cupsDoRequest(CUPS_HTTP_DEFAULT, request, "/jobs"));
 
-  if (cupsLastError() > IPP_OK_CONFLICT)
+  if (cupsLastError() == IPP_STATUS_ERROR_BAD_REQUEST ||
+      cupsLastError() == IPP_STATUS_ERROR_VERSION_NOT_SUPPORTED)
   {
-    _cupsLangPrintf(stderr, "%s: %s\n", command, cupsLastErrorString());
+    _cupsLangPrintf(stderr,
+                   _("%s: Error - add '/version=1.1' to server "
+                     "name."), command);
+    return (1);
+  }
+  else if (cupsLastError() > IPP_OK_CONFLICT)
+  {
+    _cupsLangPrintf(stderr, "%s: %s", command, cupsLastErrorString());
     return (1);
   }
 
@@ -782,7 +718,6 @@ set_job_attrs(const char    *command,       /* I - Command name */
               int           num_options,/* I - Number of options */
              cups_option_t *options)   /* I - Options */
 {
-  http_t       *http;                  /* HTTP connection to server */
   ipp_t                *request;               /* IPP request */
   char         uri[HTTP_MAX_URI];      /* URI for job */
 
@@ -790,8 +725,6 @@ set_job_attrs(const char    *command,       /* I - Command name */
   if (num_options == 0)
     return (0);
 
-  http = httpConnectEncrypt(cupsServer(), ippPort(), cupsEncryption());
-
   request = ippNewRequest(IPP_SET_JOB_ATTRIBUTES);
 
   sprintf(uri, "ipp://localhost/jobs/%d", job_id);
@@ -804,11 +737,19 @@ set_job_attrs(const char    *command,     /* I - Command name */
 
   cupsEncodeOptions(request, num_options, options);
 
-  ippDelete(cupsDoRequest(http, request, "/jobs"));
+  ippDelete(cupsDoRequest(CUPS_HTTP_DEFAULT, request, "/jobs"));
 
-  if (cupsLastError() > IPP_OK_CONFLICT)
+  if (cupsLastError() == IPP_STATUS_ERROR_BAD_REQUEST ||
+      cupsLastError() == IPP_STATUS_ERROR_VERSION_NOT_SUPPORTED)
+  {
+    _cupsLangPrintf(stderr,
+                   _("%s: Error - add '/version=1.1' to server "
+                     "name."), command);
+    return (1);
+  }
+  else if (cupsLastError() > IPP_OK_CONFLICT)
   {
-    _cupsLangPrintf(stderr, "%s: %s\n", command, cupsLastErrorString());
+    _cupsLangPrintf(stderr, "%s: %s", command, cupsLastErrorString());
     return (1);
   }
 
@@ -816,29 +757,6 @@ set_job_attrs(const char    *command,      /* I - Command name */
 }
 
 
-#ifndef WIN32
-/*
- * 'sighandler()' - Signal catcher for when we print from stdin...
- */
-
-void
-sighandler(int s)                      /* I - Signal number */
-{
- /*
-  * Remove the temporary file we're using to print from stdin...
-  */
-
-  unlink(tempfile);
-
- /*
-  * Exit...
-  */
-
-  exit(s);
-}
-#endif /* !WIN32 */
-
-
 /*
- * End of "$Id: lp.c 6356 2007-03-19 13:54:48Z mike $".
+ * End of "$Id$".
  */