]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
libext2fs: fix a broken close() test
authorDarrick J. Wong <darrick.wong@oracle.com>
Thu, 12 Dec 2013 18:17:58 +0000 (13:17 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 12 Dec 2013 18:17:59 +0000 (13:17 -0500)
Zero is a valid file descriptor, so close it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
lib/ext2fs/mkjournal.c

index 09ca4124fcd2b3c8f085d5e56951d42a2c94b04d..69ac1350fd66ca3eccebce3a95bb31d4c01995e0 100644 (file)
@@ -595,7 +595,7 @@ errcode_t ext2fs_add_journal_inode(ext2_filsys fs, blk_t num_blocks, int flags)
        ext2fs_mark_super_dirty(fs);
        return 0;
 errout:
-       if (fd > 0)
+       if (fd >= 0)
                close(fd);
        return retval;
 }