util: avoid off-by-one on long symlinks

readlink does not nul terminate its result, therefore one extra byte
has to be taken into account.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/util/symlinks.c b/util/symlinks.c
index abb33f8b230b3e86689d8ac9691525ca0f199bd9..3acebe7a26e8b49c29d75b49bc720b009a1c4eab 100644 (file)
--- a/util/symlinks.c
+++ b/util/symlinks.c
@@ -166,7 +166,7 @@ static void fix_symlink (char *path, dev_t my_dev)
        struct stat stbuf, lstbuf;
        int c, fix_abs = 0, fix_messy = 0, fix_long = 0;
 
-       if ((c = readlink(path, lpath, sizeof(lpath))) == -1) {
+       if ((c = readlink(path, lpath, sizeof(lpath) - 1)) == -1) {
                perror(path);
                return;
        }