]> git.ipfire.org Git - thirdparty/gcc.git/blob - gcc/ada/ChangeLog
[Ada] Improve placement of warning on formals of generic subprograms
[thirdparty/gcc.git] / gcc / ada / ChangeLog
1 2019-08-19 Ed Schonberg <schonberg@adacore.com>
2
3 * sem_warn.adb (Check_References, Generic_Body_Formal): When a
4 formal parameter of a generic subprogram is not referenced in
5 the body, place the corresponding warning on the corresponding
6 entity in the specification of the generic body, as is done for
7 non-generic subprograms.
8
9 2019-08-19 Bob Duff <duff@adacore.com>
10
11 * errout.ads (Size_Too_Small_Message): New constant.
12 * errout.adb, freeze.adb, sem_ch13.adb: Use it.
13
14 2019-08-19 Eric Botcazou <ebotcazou@adacore.com>
15
16 * exp_dist.adb (Build_Package_Stubs): Do not specifically visit
17 the declarations of an N_Subprogram_Instantiation node.
18
19 2019-08-19 Bob Duff <duff@adacore.com>
20
21 * doc/gnat_ugn/gnat_utility_programs.rst: Document missing
22 metrics switches.
23
24 2019-08-19 Piotr Trojanek <trojanek@adacore.com>
25
26 * sem_ch12.adb (Get_Unit_Instantiation_Node): Simplify Nkind_In
27 membership test.
28 * sem.adb (Depends_On_Main): Whitespace cleanup; only assign a
29 local variable if needed.
30
31 2019-08-19 Claire Dross <dross@adacore.com>
32
33 * sem_spark.ads, sem_spark.adb (Is_Pledge_Function): New
34 parameter of the generic. Function used to decide whether a
35 function is a pledge function.
36 (Check_Not_Borrowed): Disable check inside the second parameter
37 of a pledge function for the path borrowed by the first
38 parameter. Also disable checks for entities inside a Global
39 contract.
40
41 2019-08-19 Joffrey Huguet <huguet@adacore.com>
42
43 * libgnat/a-cfdlli.ads, libgnat/a-cfhama.ads,
44 libgnat/a-cfinve.ads, libgnat/a-cforma.ads,
45 libgnat/a-cofove.ads, libgnat/a-cofuma.ads,
46 libgnat/a-cofuve.ads: Add formal function parameter "=" (L, R :
47 Element_Type) to the generic packages.
48
49 2019-08-19 Eric Botcazou <ebotcazou@adacore.com>
50
51 * opt.ads: Clean up left-overs of earlier implementation in
52 comment:
53
54 2019-08-19 Ed Schonberg <schonberg@adacore.com>
55
56 * sem_ch3.adb (Derived_Enumeration_Type): Do no freeze anonymous
57 base type if the bounds in the derived type declaration are
58 literals of the type.
59
60 2019-08-19 Yannick Moy <moy@adacore.com>
61
62 * sem_res.adb (Resolve_Call): Check non-aliasing rules before
63 GNATprove inlining.
64
65 2019-08-19 Eric Botcazou <ebotcazou@adacore.com>
66
67 * inline.adb (Add_Inlined_Body): Do not add pending
68 instantiations.
69 * sem_ch12.adb (Needs_Body_Instantiated): New predicate.
70 (Analyze_Package_Instantiation): Use it to decide whether to add
71 a pending instantiation for the body of the package.
72
73 2019-08-19 Olivier Hainque <hainque@adacore.com>
74
75 * gcc-interface/trans.c (Acc_Loop_to_gnu): Return the openacc
76 BIND_EXPR node we have constructed on purpose. Remove unused
77 variable.
78
79 2019-08-19 Pierre-Marie de Rodat <derodat@adacore.com>
80
81 * gcc-interface/lang.opt (fdump-scos): Define.
82 * gcc-interface/misc.c (gnat_handle_option): Handle
83 OPT_fdump_scos.
84
85 2019-08-14 Joffrey Huguet <huguet@adacore.com>
86
87 * libgnat/a-cofuba.ads: Add a Length attribute to type
88 Container. Add a type Array_Base which replaces the previous
89 Elements attribute of Container.
90 (Content_Init): New subprogram. It is used to initialize the
91 Base attribute of Container.
92 * libgnat/a-cofuba.adb (Resize): New subprogram. It is used to
93 resize the underlying array of a container if necessary.
94 (=, <=, Find, Get, Intersection, Length, Num_Overlaps, Set,
95 Union): Update to match changes in type declarations.
96 (Add): Modify body to damp the time and space cost in a specific
97 case.
98 (Content_Init): New subprogram. It is used to initialize the
99 Base attribute of Container.
100 (Remove): Modify body to damp the time and space cost in a
101 specific case.
102
103 2019-08-14 Bob Duff <duff@adacore.com>
104
105 * sem_ch13.adb (Get_Alignment_Value): Return 1 for Alignment 0,
106 and do not give an error.
107 * doc/gnat_rm/representation_clauses_and_pragmas.rst: Update the
108 corresponding documentation.
109 * gnat_rm.texi: Regenerate.
110
111 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
112
113 * inline.adb (Add_Pending_Instantiation): Fix off-by-one error
114 in the comparison against the maximum number of instantiations.
115
116 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
117
118 * inline.adb (Add_Pending_Instantiation): Use greater-or-equal
119 in the comparison against the maximum number of instantiations.
120
121 2019-08-14 Ed Schonberg <schonberg@adacore.com>
122
123 * sem_aux.adb (Next_Rep_Item): If a node in the rep chain
124 involves a Ghost aspect it may have been replaced by a null
125 statement; use the original node to find next Rep_Item.
126 * repinfo.adb (List_Entities): Do not list an Ignored
127 Ghost_Entity, for which information may have been deleted.
128
129 2019-08-14 Bob Duff <duff@adacore.com>
130
131 * sem_prag.ads, sem_prag.adb
132 (Process_Compile_Time_Warning_Or_Error): In parameterless
133 version, improve detection of whether we are in a generic unit
134 to cover the case of an instance within a generic unit.
135 (Process_Compile_Time_Warning_Or_Error): Rename the
136 two-parameter version to be
137 Validate_Compile_Time_Warning_Or_Error, and do not export it.
138 Issue a warning if the condition is not known at compile time.
139 The key point is that the warning must be given only for pragmas
140 deferred to the back end, because the back end discovers
141 additional values that are known at compile time. Previous
142 changes in this ticket have enabled this by deferring to the
143 back end without checking for special cases such as 'Size.
144 (Validate_Compile_Time_Warning_Or_Error): Rename to be
145 Defer_Compile_Time_Warning_Error_To_BE.
146 * warnsw.ads, warnsw.adb (Warn_On_Unknown_Compile_Time_Warning):
147 Add new switches -gnatw_c and -gnatw_C to control the above
148 warning.
149 * doc/gnat_ugn/building_executable_programs_with_gnat.rst:
150 Document new switches.
151 * gnat_ugn.texi: Regenerate.
152
153 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
154
155 * sem_ch12.adb (Might_Inline_Subp): Rework comment and restrict
156 the shortcut based on Is_Inlined to the back-end inlining case.
157
158 2019-08-14 Bob Duff <duff@adacore.com>
159
160 * inline.adb (Check_And_Split_Unconstrained_Function): Ignore
161 protected functions to get rid of spurious error. The
162 transformation done by this procedure triggers legality errors
163 in the generated code in this case.
164
165 2019-08-14 Bob Duff <duff@adacore.com>
166
167 * sem_prag.adb (Process_Compile_Time_Warning_Or_Error): Defer
168 processing to the back end in all cases where the pragma's
169 condition is not known at compile time during the front end
170 (except in generics), as opposed to detecting 'Size attributes
171 and the like. This ensures that we take advantage of whatever
172 can be compile-time known after running the back end, as opposed
173 to having the front end guess what the back end can do. Remove
174 a little duplicated code at the call site.
175 * gnat1drv.adb (Post_Compilation_Validation_Checks): Unlock the
176 Elists while in Validate_Compile_Time_Warning_Errors, because it
177 does analysis and name resolution, which sometimes involves
178 adding Elists.
179
180 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
181
182 * einfo.ads (Is_Called): Document new usage on E_Package
183 entities.
184 * einfo.adb (Is_Called): Accept E_Package entities.
185 (Set_Is_Called): Likewise.
186 * exp_ch6.adb (Expand_Call_Helper): Move code dealing with
187 instances for back-end inlining to Add_Inlined_Body.
188 * inline.ads: Remove with clauses for Alloc and Table.
189 (Pending_Instantiations): Move to...
190 * inline.adb: Add with clauses for Alloc, Uintp, Table and
191 GNAT.HTable.
192 (Backend_Instances): New variable.
193 (Pending_Instantiations): ...here.
194 (Called_Pending_Instantiations): New table.
195 (Node_Table_Size): New constant.
196 (Node_Header_Num): New subtype.
197 (Node_Hash): New function.
198 (To_Pending_Instantiations): New hash table.
199 (Add_Inlined_Body): Bail out early for subprograms in the main
200 unit or subunit. Likewise if the Is_Called flag is set. If the
201 subprogram is an instance, invoke Add_Inlined_Instance. Call
202 Set_Is_Called earlier. If the subrogram is within an instance,
203 invoke Add_Inlined_Instance. Also deal with the case where the
204 call itself is within an instance.
205 (Add_Inlined_Instance): New procedure.
206 (Add_Inlined_Subprogram): Remove conditions always fulfilled.
207 (Add_Pending_Instantiation): Move the defence against ludicruous
208 number of instantiations to here. When back-end inlining is
209 enabled, associate an instantiation with its index in table and
210 mark a few selected kinds of instantiations as always needed.
211 (Initialize): Set Backend_Instances to No_Elist.
212 (Instantiate_Body): New procedure doing the work extracted
213 from...
214 (Instantiate_Bodies): ...here. When back-end inlining is
215 enabled, loop over Called_Pending_Instantiations instead of
216 Pending_Instantiations.
217 (Is_Nested): Minor tweak.
218 (List_Inlining_Info): Also list the contents of
219 Backend_Instances.
220 * sem_ch12.adb (Might_Inline_Subp): Return early if Is_Inlined
221 is set and otherwise set it before returning true.
222 (Analyze_Package_Instantiation): Remove the defence against
223 ludicruous number of instantiations. Invoke
224 Remove_Dead_Instance instead of doing the removal manually if
225 there is a guaranteed ABE.
226
227 2019-08-14 Gary Dismukes <dismukes@adacore.com>
228
229 * exp_ch3.adb (Predef_Spec_Or_Body): For an equality operation
230 of an interface type, create an expression function (that
231 returns False) rather than declaring an abstract function.
232 * freeze.adb (Check_Inherited_Conditions): Set Needs_Wrapper to
233 False unconditionally at the start of the loop creating wrappers
234 for inherited operations.
235
236 2019-08-14 Bob Duff <duff@adacore.com>
237
238 * table.adb: Assert that the table is not locked when increasing
239 Last, even if it doesn't cause reallocation. In other words,
240 assert that on operations that MIGHT cause reallocation.
241 * table.ads: Fix comment accordingly.
242
243 2019-08-14 Arnaud Charlet <charlet@adacore.com>
244
245 * doc/gnat_ugn/gnat_and_program_execution.rst: Remove
246 documentation of gnatelim.
247
248 2019-08-14 Bob Duff <duff@adacore.com>
249
250 * sem_prag.adb (Validate_Compile_Time_Warning_Error): Attach the
251 warning to the Sloc of the first pragma argument, rather than to
252 the pragma itself. This is to make pragmas processed after the
253 back end use the same Sloc as pragmas processed earlier, in the
254 front end. There's no reason for this discrepancy, and it
255 hinders further work on this ticket.
256
257 2019-08-14 Bob Duff <duff@adacore.com>
258
259 * sem.ads (Inside_A_Generic): Remove the ??? comment.
260
261 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
262
263 * inline.ads (Pending_Descriptor): Delete.
264 * inline.adb (Initialize): Do not initialize it.
265 * sem_ch12.adb (Delay_Descriptors): Delete.
266 (Analyze_Package_Instantiation): Call
267 Set_Delay_Subprogram_Descriptors instead of Delay_Descriptors
268 throughout.
269
270 2019-08-14 Bob Duff <duff@adacore.com>
271
272 * exp_aggr.adb (Init_Hidden_Discriminants): Avoid processing the
273 wrong discriminant, which could be of the wrong type.
274
275 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
276
277 * sem_ch12.adb (Analyze_Instance_And_Renamings): Do not reset
278 the Is_Generic_Instance flag previously set on the package
279 generated for the instantiation of a generic subprogram.
280
281 2019-08-14 Ed Schonberg <schonberg@adacore.com>
282
283 * exp_ch4.adb (Expand_N_Quantified_Expression): Freeze
284 explicitly the type of the loop parameter.
285
286 2019-08-14 Javier Miranda <miranda@adacore.com>
287
288 * sem_util.adb (New_Copy_Tree.Copy_Node_With_Replacement):
289 Update the Chars attribute of identifiers.
290
291 2019-08-14 Yannick Moy <moy@adacore.com>
292
293 * sem_spark.adb, sem_spark.ads (Is_Legal): New function exposed
294 for use in GNATprove, to test legality rules not related to
295 permissions.
296 (Check_Declaration_Legality): Extract the part of
297 Check_Declaration that checks rules not related to permissions.
298 (Check_Declaration): Call the new Check_Declaration_Legality.
299 (Check_Type_Legality): Rename of Check_Type. Introduce
300 parameters to force or not checking, and update a flag detecting
301 illegalities.
302 (Check_Node): Ignore attribute references in statement position.
303
304 2019-08-14 Yannick Moy <moy@adacore.com>
305
306 * sem_spark.adb (Check_Old_Loop_Entry): New procedure to check
307 correct use of Old and Loop_Entry.
308 (Check_Node): Check subprogram contracts.
309 (Check_Pragma): Check Loop_Variant.
310 (Check_Safe_Pointers): Apply checking to library-level
311 subprogram declarations as well, in order to check their
312 contract.
313
314 2019-08-14 Yannick Moy <moy@adacore.com>
315
316 * sem_spark.adb (Is_Subpath_Expression): Take into account
317 conversion and qualification.
318
319 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
320
321 * sem_ch7.adb (Install_Private_Declarations)
322 <Swap_Private_Dependents>: Do not rely solely on the
323 Is_Child_Unit flag on the unit to recurse.
324 (Uninstall_Declarations) <Swap_Private_Dependents>: New
325 function. Use it to recurse on the private dependent entities
326 for child units.
327
328 2019-08-14 Javier Miranda <miranda@adacore.com>
329
330 * exp_aggr.adb (Is_CCG_Supported_Aggregate): Return False for
331 arrays with bounds not known at compile time.
332
333 2019-08-14 Ed Schonberg <schonberg@adacore.com>
334
335 * sem_util.adb (New_Copy_Tree, Visit_Entity): A quantified
336 expression includes the implicit declaration of the loop
337 parameter. When a quantified expression is copied during
338 expansion, for example when building the precondition code from
339 the generated pragma, a new loop parameter must be created for
340 the new tree, to prevent duplicate declarations for the same
341 symbol.
342
343 2019-08-14 Yannick Moy <moy@adacore.com>
344
345 * sem_disp.adb (Check_Dispatching_Operation): Update assertion
346 for the separate declarations created in GNATprove mode.
347 * sem_disp.ads (Is_Overriding_Subprogram): Update comment.
348 * sem_elab.adb (SPARK_Processor): Fix test for checking of
349 overriding primitives.
350
351 2019-08-14 Eric Botcazou <ebotcazou@adacore.com>
352
353 * inline.adb (Add_Inlined_Body): Tweak comments.
354 (List_Inlining_Info): Also list information about non-main
355 units.
356
357 2019-08-14 Gary Dismukes <dismukes@adacore.com>
358
359 * sem_ch4.adb (Analyze_Selected_Component): In the case where
360 the prefix is of a concurrent type, and the selected entity
361 matching the selector is the first private declaration of the
362 type (such as the first local variable in a task's body), set
363 Is_Private_Op.
364
365 2019-08-14 Piotr Trojanek <trojanek@adacore.com>
366
367 * einfo.adb (Is_Generic_Actual_Subprogram): Replace repeated
368 calls to Ekind with Ekind_In.
369
370 2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
371
372 PR middle-end/91421
373 * gcc-interface/trans.c (gigi): Call set_decl_buillt_in_function.
374 (Call_to_gnu): Use DECL_FE_FUNCTION_CODE instead of DECL_FUNCTION_CODE.
375
376 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
377
378 * ali.ads (Linker_Option_Record): Remove Original_Pos component.
379 * ali.adb (Scan_ALI): Do not set it.
380
381 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
382
383 * sem_ch3.adb (Build_Derived_Concurrent_Type): Add a couple of
384 local variables and use them. When the derived type fully
385 constrains the parent type, rewrite it as a subtype of an
386 implicit (unconstrained) derived type instead of the other way
387 around.
388 (Copy_And_Build): Deal with concurrent types and use predicates.
389 (Build_Derived_Private_Type): Build the full derivation if
390 needed for concurrent types too.
391 (Build_Derived_Record_Type): Add marker comment.
392 (Complete_Private_Subtype): Use predicates.
393
394 2019-08-13 Ed Schonberg <schonberg@adacore.com>
395
396 * sem_ch3.adb (Check_Generic_Ancestor): New subprogram,
397 aubsidiary to Build_Derived_Record_Type. to enforce the rule
398 that a type extension declared in a generic body cznnot have an
399 ancestor that is a generic formal (RM 3.9.1 (4/2)). The rule
400 applies to all ancestors of the type, including interface
401 progenitors.
402
403 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
404
405 * sem_ch3.adb (Build_Underlying_Full_View): Delete.
406 (Complete_Private_Subtype): Do not set the full view on the
407 private subtype here. If the full base is itself derived from
408 private, do not re-derive the parent type but instead constrain
409 an existing underlying full view.
410 (Prepare_Private_Subtype_Completion): Do not get to the
411 underlying full view, if any. Set the full view on the private
412 subtype here.
413 (Process_Full_View): Likewise.
414 * sem_ch12.adb (Check_Generic_Actuals): Also set
415 Is_Generic_Actual_Type on the full view if the type of the
416 actual is private.
417 (Restore_Private_Views): Also reset Is_Generic_Actual_Type on
418 the full view if the type of the actual is private.
419 * sem_eval.adb (Subtypes_Statically_Match): Remove bypass for
420 generic actual types.
421
422 2019-08-13 Javier Miranda <miranda@adacore.com>
423
424 * sem_res.adb (Resolve_Selected_Component): When the type of the
425 component is an access to a class-wide type and the type of the
426 context is an access to a tagged type the relevant type is that
427 of the component (since in such case we may need to generate
428 implicit type conversions or dispatching calls).
429
430 2019-08-13 Ed Schonberg <schonberg@adacore.com>
431
432 * exp_aggr.adb (Aggr_Assignment_OK_For_Backend): Preanalyze
433 expression, rather do a full analysis, to prevent unwanted
434 removal of side effects which mask the intent of the expression.
435
436 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
437
438 * impunit.adb (Non_Imp_File_Names_95): Add
439 GNAT.Branch_Prediction.
440
441 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
442
443 * exp_ch6.adb: Remove with and use clauses for Sem_Ch12.
444 (Expand_Call_Helper): Swap the back-end inlining case and the
445 special front-end expansion case. In back-end inlining mode, do
446 not invoke Add_Inlined_Body unless the call may be inlined.
447 * inline.ads (Add_Pending_Instantiation): New function moved
448 from...
449 * inline.adb (Add_Inlined_Body): Simplify comment. Turn test on
450 the enclosing unit into assertion.
451 (Add_Pending_Instantiation): New function moved from...
452 * sem_ch12.ads (Add_Pending_Instantiation): ...here.
453 * sem_ch12.adb (Add_Pending_Instantiation): ...here.
454
455 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
456
457 * sem.adb (Do_Analyze): Recompute Style_Check_Max_Line_Length
458 after restoring Style_Max_Line_Length.
459
460 2019-08-13 Arnaud Charlet <charlet@adacore.com>
461
462 * sem_ch13.adb (Check_Iterator_Functions): Protect against
463 cascaded errors.
464
465 2019-08-13 Ed Schonberg <schonberg@adacore.com>
466
467 * sem_ch8.adb (Analyze_Subprogram_Renaming): Do no suppress mode
468 conformance checks on child unit instance that is a compilation
469 unit.
470
471 2019-08-13 Gary Dismukes <dismukes@adacore.com>
472
473 * exp_dbug.adb (Fully_Qualify_Name): Add full name qualification
474 for the E_Exception case.
475
476 2019-08-13 Gary Dismukes <dismukes@adacore.com>
477
478 * exp_aggr.adb (Aggr_Size_OK): Compute the aggregate size using
479 universal arithmetic, to avoid situations where the size
480 computation overflows.
481
482 2019-08-13 Justin Squirek <squirek@adacore.com>
483
484 * repinfo.adb (List_Scalar_Storage_Order): Modify conditionals
485 for displaying ordering to always be triggered when -gnatR4 is
486 in effect.
487
488 2019-08-13 Justin Squirek <squirek@adacore.com>
489
490 * aspects.adb, aspects.ads: Register new aspect.
491 * par-prag.adb (Prag): Register new pragma
492 * sem_ch13.adb (Analyze_Aspect_Specifications): Add processing
493 for new aspect similar to Aspect_Max_Entry_Queue_Length.
494 * sem_prag.adb, sem_prag.ads (Analyze_Pragma): Register new
495 pragma and set it to use the same processing as
496 Pragma_Max_Queue_Length.
497 * snames.ads-tmpl: Move definition of
498 Name_Max_Entry_Queue_Length so that it can be processed as a
499 pragma in addition to a restriction and add an entry for the
500 pragma itself.
501
502 2019-08-13 Yannick Moy <moy@adacore.com>
503
504 * sem_ch4.adb (Analyze_Allocator): Do not insert subtype
505 declaration for allocator inside a spec expression.
506
507 2019-08-13 Yannick Moy <moy@adacore.com>
508
509 * sem_res.adb (Resolve_Call): Do not inline calls inside record
510 types.
511
512 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
513
514 * sem_ch4.adb (Analyze_One_Call): Remove bypass for type
515 mismatch in nested instantiations.
516 * sem_ch8.adb (Find_Nearer_Entity): New function.
517 (Find_Renamed_Entity): Use it to disambiguate the candidates for
518 the renaming generated for an instantiation when it is
519 ambiguous.
520
521 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
522
523 * gnat1drv.adb (Adjust_Global_Switches): Do not set
524 Back_End_Inlining in ASIS mode either.
525
526 2019-08-13 Olivier Hainque <hainque@adacore.com>
527
528 * libgnat/s-win32.ads: Define size_t and fix the MapViewOfFile
529 binding to use it instead of DWORD for the dwNumberOfBytesToMap
530 argument.
531 * libgnat/g-sercom__mingw.adb (Read): State which definition of
532 size_t to fetch in call to Last_Index.
533
534 2019-08-13 Arnaud Charlet <charlet@adacore.com>
535
536 * gcc-interface/Make-lang.in: Remove unused TRACE variable. Pass
537 LN_S to relevant gnatlib targets.
538 * gcc-interface/Makefile.in: Systematically pass LN_S to
539 relevant gnatlib targets.
540
541 2019-08-13 Yannick Moy <moy@adacore.com>
542
543 * sem_dim.adb (Analyze_Dimension,
544 Analyze_Dimension_Array_Aggregate, Analyze_Dimension_Call,
545 Analyze_Dimension_Extension_Or_Record_Aggregate): Return
546 immediately when inside an inlined body.
547 * sem_res.adb (Resolve_Call): Remove special checking now done
548 inside Analyze_Dimension_Call.
549
550 2019-08-13 Justin Squirek <squirek@adacore.com>
551
552 * exp_ch4.adb (Expand_N_Allocator): Add condition to detect
553 library-level object declarations
554
555 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
556
557 * doc/gnat_ugn/building_executable_programs_with_gnat.rst
558 (-gnateT): Document Double_Float_Alignment parameter and fix
559 description of Double_Scalar_Alignment parameter.
560 * gnat_ugn.texi: Regenerate.
561
562 2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
563
564 * exp_ch6.adb (Expand_Call_Helper): If back-end inlining is
565 enabled, also instantiate the body of a generic unit containing
566 a subprogram subject to aspect/pragma Inline_Always at
567 optimization level zero.
568 * sem_ch12.adb (Might_Inline_Subp): Minor tweak.
569 (Analyze_Package_Instantiation): Do not instantiate the package
570 body because of inlining considerations if the instantiation is
571 done in a generic unit. Move around similar condition involving
572 the main unit. Add test on Back_End_Inlining to processing for
573 front-end inlining.
574
575 2019-08-13 Javier Miranda <miranda@adacore.com>
576
577 * exp_disp.adb (Make_Secondary_DT): Handle record type
578 derivations that have interface components located at fixed
579 positions and interface components located at variable offset.
580 The offset of components located at fixed positions is computed
581 using the dummy object (similar to the case where all the
582 interface components are located at fixed positions).
583 (Make_DT): Build the dummy object for all tagged types that
584 implement interface types (that is, build it also for types with
585 variable size components), and use the dummy object to compute
586 the offset of all tag components located at fixed positions when
587 initializing the Interface_Table object.
588
589 2019-08-13 Justin Squirek <squirek@adacore.com>
590
591 * gnatcmd.adb (GNATCmd): Add constant for new compiler switch
592 --help-ada, and include usage subprogram. Add line to usage help
593 explaining the new flag.
594 (GNATCmd_Usage): Rename from locally declared Usage so as not to
595 confuse with the newly imported version. Add new argument case
596 for --help-ada and add bug report email to implicit display of
597 help without the --help flag so as to unify output between the
598 two cases.
599
600 2019-08-13 Dmitriy Anisimkov <anisimko@adacore.com>
601
602 * libgnat/g-comlin.adb (Getopt): Quote unrecognized switch in
603 Invalid_Switch exception message.
604
605 2019-08-13 Yannick Moy <moy@adacore.com>
606
607 * sem_util.adb (Traverse_More_Func): Take into account
608 Loop_Actions inside N_Iterated_Component_Association nodes.
609 * sinfo.ads: Document correctly Loop_Actions as a field of nodes
610 of kind N_Iterated_Component_Association.
611
612 2019-08-13 Claire Dross <dross@adacore.com>
613
614 * libgnat/a-cfinve.adb, libgnat/a-cofove.adb (Find_Index,
615 Reverse_Find_Index): Use bigger type to avoid range check
616 failure at the last loop iteration.
617
618 2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
619
620 * libgnat/g-socket.adb (Is_IPv6_Address): Check that no less
621 then 2 colons in IPv6 numeric address.
622
623 2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
624
625 * libgnat/g-comlin.ads, libgnat/g-comlin.adb (Getopt): Add
626 parameter Quiet. Need to do not output error messages to
627 console. Invalid_Switch exception generation surrounded by an
628 error message.
629
630 2019-08-12 Ed Schonberg <schonberg@adacore.com>
631
632 * exp_ch6.adb (Expand_Actuals. Add_Call_By_Copy_Code): Add code
633 to generate proper checks when an actual for an in-out or out
634 parameter has a non-null access type. No constraints are
635 applied to an inbound access parameter, but on exit a not-null
636 check must be performed if the type of the actual requires it.
637
638 2019-08-12 Ed Schonberg <schonberg@adacore.com>
639
640 * sem_util.adb (Is_Expaned_Priority_Attribute): Check whether
641 call comes from a rewritten attribute before comparing name with
642 Get_Ceiling run-time subprogram.
643
644 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
645
646 * exp_util.ads (Component_May_Be_Bit_Aligned): Small comment
647 tweaks.
648 (Possible_Bit_Aligned_Component): Likewise.
649 (Type_May_Have_Bit_Aligned_Components): Likewise.
650 * exp_util.adb (Component_May_Be_Bit_Aligned): Likewise.
651 (Possible_Bit_Aligned_Component): Likewise.
652 (Type_May_Have_Bit_Aligned_Components): Likewise.
653
654 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
655
656 * exp_ch4.adb (Expand_N_Op_Eq): Expand the array equality if
657 either operand is a possibly unaligned slice.
658 * exp_ch6.adb (Expand_Simple_Function_Return): Do not generate a
659 copy for a possibly unaligned object if it is represented as a
660 scalar.
661 * exp_util.adb (Is_Possibly_Unaligned_Slice): Do not always
662 return false if the target doesn't have strict alignment.
663
664 2019-08-12 Bob Duff <duff@adacore.com>
665
666 * sem_ch12.adb (Instantiate_Package_Body): Remove suppression of
667 checks in instances of internal units.
668 * sem_ch6.adb (Analyze_Function_Return): Do not generate a
669 constraint check on an extended_return_statement if the subtype
670 of the return object in the statement is identical to the return
671 subtype of the function.
672
673 2019-08-12 Bob Duff <duff@adacore.com>
674
675 * libgnat/a-cbmutr.adb (Is_Reachable): Declare Idx to be of the
676 base subtype. Clearly it makes no sense to loop "while Idx >=
677 0", if Idx is of a nonnegative subtype.
678
679 2019-08-12 Bob Duff <duff@adacore.com>
680
681 * libgnat/a-tifiio.adb (Put_Scaled): Prevent AA from being
682 negative, since Field is range 0 .. something.
683
684 2019-08-12 Bob Duff <duff@adacore.com>
685
686 * doc/gnat_ugn/gnat_utility_programs.rst (gnatmetric, gnatpp,
687 gnatstub): Remove documentation for Ada language version
688 switches, and note that they are no longer needed.
689
690 2019-08-12 Gary Dismukes <dismukes@adacore.com>
691
692 * sem_ch5.adb (Prepare_Param_Spec_Loop): Set the parents of the
693 copied low and high bounds in the case where the loop range is
694 given by a discrete_subtype_indication, to prevent hanging (or
695 Assert_Failure) in Insert_Actions.
696
697 2019-08-12 Ed Schonberg <schonberg@adacore.com>
698
699 * sem_ch6.adb (heck_Untagged_Equality): Verify that user-defined
700 equality has the same profile as the predefined equality before
701 applying legality rule in RM 4.5.2 (9.8).
702
703 2019-08-12 Bob Duff <duff@adacore.com>
704
705 * libgnat/a-except.ads: Update obsolete comment, still making
706 clear that this is a variant. Add explicit default for Id
707 component of Exception_Occurrence, because that value is used.
708 Define Null_Occurrence less redundantly.
709 * libgnat/a-einuoc.adb: Minor simplification of code.
710
711 2019-08-12 Justin Squirek <squirek@adacore.com>
712
713 * libgnat/a-dhfina.adb, libgnat/a-dhfina.ads (Is_Simple_Name,
714 Is_Root_Directory, Is_Parent_Directory,
715 Is_Current_Directory_Name, Is_Relative_Name, Initial_Directory,
716 Relative_Name, Compose): Add implementation and documentation.
717 * libgnat/a-direct.adb (Containing_Directory): Modify routine to
718 use routines from Ada.Directories.Hierarchical_File_Names and
719 remove incorrect special case for parent directories.
720 (Fetch_Next_Entry): Add check for current directory and parent
721 directory and ignore them under certain circumstances.
722 (Simple_Nmae): Add check for null result from
723 Simple_Name_Internal and raise Name_Error.
724 (Simple_Name_Internal): Add explicit check for root directories,
725 sanitize trailing directory separators, and modify behavior so
726 that current and parent directories are considered valid
727 results.
728 * Makefile.rtl: Add entry to GNATRTL_NONTASKING_OBJS.
729
730 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
731
732 * freeze.adb (Freeze_Entity): Give the same error for an
733 Object_Size clause on a variable-sized type as for a Size
734 clause.
735
736 2019-08-12 Gary Dismukes <dismukes@adacore.com>
737
738 * sem_prag.adb (Analyze_Pragma, Pragma_Suppress_Initialization):
739 For private types, set the Suppress_Initialization flag on the
740 Full_View of the entity rather than the entity's base type.
741
742 2019-08-12 Yannick Moy <moy@adacore.com>
743
744 * aspects.adb, aspects.ads (Aspect_No_Caching): New aspect.
745 * contracts.adb, contracts.ads (Add_Contract_Item): Add handling
746 of No_Caching.
747 (Analyze_Object_Contract): Add handling of No_Caching.
748 * einfo.adb, einfo.ads
749 (Get_Pragma): Add handling of No_Caching.
750 * doc/gnat_rm/implementation_defined_aspects.rst,
751 doc/gnat_rm/implementation_defined_pragmas.rst: Document new
752 aspect/pragma.
753 * gnat_rm.texi: Regenerate.
754 * par-prag.adb (Prag): New pragma Pragma_No_Caching.
755 * sem_ch13.adb (Analyze_Aspect_Specifications,
756 Check_Aspect_At_Freeze_Point): Add handling of No_Caching.
757 * sem_prag.adb (Analyze_Pragma): Deal with pragma No_Caching.
758 * sem_prag.ads (Analyze_External_Property_In_Decl_Part): Now
759 applies to No_Caching.
760 * sem_util.adb, sem_util.ads (Is_Effectively_Volatile): Add
761 handling of No_Caching.
762 (No_Caching_Enabled): New query function.
763 * snames.ads-tmpl: New names for pragma.
764
765 2019-08-12 Yannick Moy <moy@adacore.com>
766
767 * sem_util.adb, sem_util.ads (Traverse_More_Func,
768 Traverse_More_Proc): Add formal parameter for Itypes traversal.
769
770 2019-08-12 Yannick Moy <moy@adacore.com>
771
772 * exp_attr.adb, exp_attr.ads (Expand_Size_Attribute): New
773 procedure to share part of the attribute expansion with
774 GNATprove mode.
775 (Expand_N_Attribute_Reference): Extract part of the
776 Size/Object_Size expansion in the new procedure
777 Expand_Size_Attribute.
778 * exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Expand
779 Size/Object_Size attributes using the new procedure
780 Expand_Size_Attribute.
781
782 2019-08-12 Yannick Moy <moy@adacore.com>
783
784 * exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Only
785 expand Enum_Rep attribute when its parameter is a literal.
786
787 2019-08-12 Justin Squirek <squirek@adacore.com>
788
789 * sem_eval.adb (Check_Non_Static_Context): Add a condition to
790 determine if a range violation constitues a warning or an error.
791 (Out_Of_Range): Add a condition to determine if a range
792 violation constitues a warning or an error.
793
794 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
795
796 * exp_ch4.adb (Real_Range_Check): Do not rewrite the conversion
797 node but its expression instead, after having fetched its
798 current value. Clear the Do_Range_Check flag on entry. Return
799 early for a rewritten float-to-float conversion. Remove
800 redundant local variable. Suppress all checks when inserting
801 the temporary and do not reanalyze the node.
802
803 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
804
805 * sprint.ads: Minor comment tweak.
806
807 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
808
809 * checks.adb (Insert_Valid_Check): Do not retrieve the
810 Do_Range_Check flag from the Original_Node but from the
811 Validated_Object. Remove useless bypass for floating-point
812 types.
813
814 2019-08-12 Yannick Moy <moy@adacore.com>
815
816 * sem_util.adb, sem_util.ads (Traverse_More_Func,
817 Traverse_More_Proc): New traversal subprograms.
818
819 2019-08-12 Jerome Lambourg <lambourg@adacore.com>
820
821 * libgnarl/s-taprop__vxworks.adb (Abort_Handler): Only call
822 s-tpopsp.Self when actually needed.
823
824 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
825
826 * exp_ch4.adb (Discrete_Range_Check): Return if checks are
827 suppressed.
828
829 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
830
831 * sem_res.adb: Add with & use clause for Sem_Mech and
832 alphabetize.
833 (Resolve_Actuals): Do not apply a scalar range check for the
834 source of a conversion whose result is passed by reference to a
835 valued procedure.
836
837 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
838
839 * checks.adb (Insert_Valid_Check): Reset the Do_Range_Check flag
840 on the validated object.
841 * exp_ch6.adb (Add_Call_By_Copy_Code): Reset the Do_Range_Check
842 flag on the actual here, as well as on the Expression if the
843 actual is a N_Type_Conversion node.
844 (Add_Validation_Call_By_Copy_Code): Generate the incoming range
845 check if needed and reset the Do_Range_Check flag on the
846 Expression if the actual is a N_Type_Conversion node.
847 (Expand_Actuals): Do not reset the Do_Range_Check flag here.
848 Generate the incoming range check for In parameters here instead
849 of...
850 (Expand_Call_Helper): ...here. Remove redudant condition.
851 * sem_res.adb (Resolve_Actuals): Use local variable A_Typ and
852 remove obsolete comments.
853 (Resolve_Type_Conversion): Do not force the Do_Range_Check flag
854 on the operand if range checks are suppressed.
855
856 2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
857
858 * checks.adb (Activate_Range_Check): Remove redundant argument.
859 (Generate_Range_Check): Likewise.
860 (Apply_Float_Conversion_Check): Reset the Do_Range_Check flag on
861 entry and remove redundant condition.
862
863 2019-08-02 Alexandre Oliva <oliva@adacore.com>
864
865 * libgnat/a-exexpr.adb (Begin_Handler_v1, End_Handler_v1): New.
866 (Claimed_Cleanup): New.
867 (Begin_Handler, End_Handler): Document.
868 * gcc-interface/trans.c (gigi): Switch to exception handler
869 ABI #1.
870 (Exception_Handler_to_gnu_gcc): Save the original cleanup
871 returned by begin handler, pass it to end handler, and use
872 EH_ELSE_EXPR to pass a propagating exception to end handler.
873 (gnat_to_gnu): Leave the exception pointer alone for reraise.
874 (add_cleanup): Handle EH_ELSE_EXPR, require it by itself.
875
876 2019-07-23 Ed Schonberg <schonberg@adacore.com>
877
878 * sem_ch13.adb (Check_Aspect_At_End_Of_Declarations,
879 Freeze_Entity_Checks): Include Aspect_CPU with other aspects
880 whose expresssion may depend on a discriminant, and thus require
881 that components of the type be made visible.
882
883 2019-07-23 Eric Botcazou <ebotcazou@adacore.com>
884
885 * checks.adb (Convert_And_Check_Range): Add Suppress parameter
886 and pass it in the call to Insert_Actions. Rename local
887 variable.
888 (Generate_Range_Check): Minor comment fixes. Pass Range_Check
889 in the first call to Convert_And_Check_Range and All_Checks in
890 the second call.
891 * exp_ch4.adb (Expand_N_Type_Conversion): Reset the
892 Do_Overflow_Check flag in the float-to-float case too if there
893 is also a range check.
894
895 2019-07-23 Eric Botcazou <ebotcazou@adacore.com>
896
897 * checks.adb (Activate_Overflow_Check): Remove redundant
898 argument.
899 * exp_ch4.adb (Discrete_Range_Check): Reset the overflow flag.
900 (Expand_N_Type_Conversion): Do not reset it here.
901
902 2019-07-23 Eric Botcazou <ebotcazou@adacore.com>
903
904 * repinfo.adb (List_Component_Layout): Pass Decimal to UI_Write.
905 (Write_Val): Likewise.
906
907 2019-07-23 Ed Schonberg <schonberg@adacore.com>
908
909 * aspects.ads: New table Operational_Aspect, used to distinguish
910 between aspects that are view-specific, such as those related to
911 iterators, and representation aspects that apply to all views of
912 a type.
913 * aspects.adb (Find_Aspect): If the aspect being sought is
914 operational, do not ecamine the full view of a private type to
915 retrieve it.
916 * sem_ch5.adb (Analyze_Iterator_Specification): Improve error
917 message when the intended domain of iteration does not implement
918 the required iterator aspects.
919
920 2019-07-23 Yannick Moy <moy@adacore.com>
921
922 * sem_spark.ads (Is_Local_Context): New function.
923 * sem_spark.adb (Check_Declaration): Issue errors on violations
924 of SPARK RM 3.10(4)
925 (Process_Path): Do not issue error on borrow/observe during
926 elaboration, as these are caught by the new rule.
927
928 2019-07-23 Yannick Moy <moy@adacore.com>
929
930 * exp_ch7.adb (Create_Finalizer): Force finalizer not to be
931 Ghost enabled.
932 * exp_dbug.adb (Get_External_Name): Explain special case of
933 Ghost finalizer.
934
935 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
936
937 * repinfo.adb (List_Entities): Also list compiled-generated
938 types present as Etype of objects.
939
940 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
941
942 * sinfo.ads: Update the documentation about the
943 Do_Division_Check, Do_Overflow_Check and Do_Range_Check flags.
944
945 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
946
947 * exp_ch4.adb (Expand_N_Type_Conversion): Beef up comment.
948 (Fixup_Universal_Fixed_Operation): Set the base type instead of
949 the type of the enclosing type conversion on the operation.
950
951 2019-07-22 Ed Schonberg <schonberg@adacore.com>
952
953 * exp_ch4.adb (Expand_N_In): Do not suggest the use of attribute
954 'Valid as a replacement for a range check on a discrete type
955 when the bounds of the range are given by type conversions,
956 because in such a case there are distinct types involved and the
957 subbested attribute replacement would be misplaced.
958
959 2019-07-22 Yannick Moy <moy@adacore.com>
960
961 * sem_spark.adb (Get_Root_Object, Is_Path_Expression,
962 Is_Subpath_Expression): Add parameter Is_Traversal to adapt
963 these functions to the case of paths returned from a traversal
964 function.
965 (Read_Indexes): Handle the case of an if-expression or
966 case-expression.
967 (Check_Statement): Check Emit_Messages only when issuing an
968 error message. This is important as Emit_Messages may store the
969 information that an error was detected.
970
971 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
972
973 * checks.adb (Apply_Type_Conversion_Checks): Do not set
974 Do_Range_Check flag on conversions from fixed-point types
975 either.
976 * exp_attr.adb: Add use and with clause for Expander.
977 (Expand_N_Attribute_Reference) <Fixed_Value, Integer_Value>: Set
978 the Conversion_OK flag and do not generate overflow/range checks
979 manually.
980 * exp_ch4.adb (Expand_N_Qualified_Expression): Remove
981 superfluous clearing of Do_Range_Check flag.
982 (Discrete_Range_Check): New procedure to generate a range check
983 for discrete types.
984 (Real_Range_Check): Remove redundant local variable and adjust.
985 Remove useless shortcut. Clear Do_Range_Check flag on all
986 paths.
987 (Expand_N_Type_Conversion): Remove redundant test on
988 Conversion_OK. Call Discrete_Range_Check to generate range
989 checks on discrete types. Remove obsolete code for
990 float-to-integer conversions. Add code to generate range checks
991 for conversions involving fixed-point types.
992
993 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
994
995 * sprint.ads: Fix pasto in comment.
996
997 2019-07-22 Javier Miranda <miranda@adacore.com>
998
999 * sem_res.adb (Resolve_Actuals): Replace code that displaces the
1000 pointer to an allocated object to reference its secondary
1001 dispatch table by a type conversion (which takes care of
1002 handling all cases).
1003
1004 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1005
1006 * sprint.adb (Sprint_Node_Actual)
1007 <N_Decimal_Fixed_Point_Definition>: Swap a couple of spaces.
1008 (Write_Itype): Minor consistency fixes throughout. Add support
1009 for printing ordinary and decimal fixed-point types and
1010 subtypes.
1011
1012 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1013
1014 * exp_attr.adb (Expand_Loop_Entry_Attribute): Beef up comment.
1015
1016 2019-07-22 Ed Schonberg <schonberg@adacore.com>
1017
1018 * libgnat/s-valboo.ads, libgnat/s-valcha.ads,
1019 libgnat/s-valdec.ads, libgnat/s-valenu.ads,
1020 libgnat/s-valint.ads, libgnat/s-vallld.ads,
1021 libgnat/s-vallli.ads, libgnat/s-valllu.ads,
1022 libgnat/s-valrea.ads, libgnat/s-valuns.ads,
1023 libgnat/s-valwch.ads: Change categorization of packages that
1024 implement attribute 'Value from Pure to Preelaborate, to prevent
1025 undesirable optimizations when the evaluation of the attribute
1026 raises Constraint_Error, but subsequent use of the result of
1027 this evsaluation is removed by a subsequent optimization.
1028
1029 2019-07-22 Ed Schonberg <schonberg@adacore.com>
1030
1031 * sem_warn.adb (Check_References): Do not emit s warning on a
1032 referenced entity with no explicit assignment if the type of the
1033 entity has Preelaborable_Initialixation, such as
1034 Exception_Occurrence.
1035
1036 2019-07-22 Javier Miranda <miranda@adacore.com>
1037
1038 * exp_ch4.adb (Size_In_Storage_Elements): Improve the expansion
1039 to handle array indexes that are modular type.
1040 (Expand_N_Allocator): For 32-bit targets improve the generation
1041 of the runtime check associated with large arrays supporting
1042 arrays initialized with a qualified expression.
1043 * libgnat/s-imenne.adb (Image_Enumeration_8,
1044 Image_Enumeration_16, Image_Enumeration_32): Define the index of
1045 Index_Table with range Natural'First .. Names'Length since in
1046 the worst case all the literals of the enumeration type would be
1047 single letter literals and the Table built by the frontend would
1048 have as many components as the length of the names string. As a
1049 result of this enhancement, the internal tables declared using
1050 Index_Table have a length closer to the real needs, thus
1051 avoiding the declaration of large arrays on 32-bit CCG targets.
1052
1053 2019-07-22 Yannick Moy <moy@adacore.com>
1054
1055 * sem_ch3.adb (Constrain_Access): Issue a message about ignored
1056 constraint.
1057
1058 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1059
1060 * sem_ch8.adb (End_Use_Type): Reset the In_Use flag on the
1061 class-wide type if the type is tagged.
1062 (Use_One_Type): Add commentary on the handling of the class-wide
1063 type.
1064
1065 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1066
1067 * einfo.ads (Is_For_Access_Subtype): Delete.
1068 (Set_Is_For_Access_Subtype): Likewise.
1069 * einfo.adb (Is_For_Access_Subtype): Likewise.
1070 (Set_Is_For_Access_Subtype): Likewise.
1071 (Write_Entity_Flags): Do not write Is_For_Access_Subtype.
1072 * exp_ch4.adb (Expand_N_Selected_Component): Do not deal with
1073 it.
1074 * exp_spark.adb (Expand_SPARK_N_Selected_Component): Likewise.
1075 * sem_ch4.adb (Analyze_Explicit_Dereference): Likewise.
1076 * sem_ch3.adb (Build_Discriminated_Subtype): Do not build a
1077 special private subtype for access-to-record subtypes.
1078
1079 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1080
1081 * sem_ch3.adb (Complete_Private_Subtype): Rework the setting of
1082 the Etype of the full view for full base types that cannot
1083 contain any discriminant. Remove code and comment about it in
1084 the main path.
1085
1086 2019-07-22 Ed Schonberg <schonberg@adacore.com>
1087
1088 * sem_ch3.adb (Convert_Bound): Subsidiary of
1089 Floating_Point_Type_Declaration, to handle properly range
1090 specifications with bounds that may include static constants of
1091 a given type rather than real literals.
1092
1093 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1094
1095 * sem_aggr.adb (Rewrite_Bound): Be prepared for discriminals
1096 too.
1097 (Rewrite_Range;): Minor tweak.
1098 (Resolve_Record_Aggregate): For a component with default
1099 initialization whose expression is an array aggregate, also
1100 rewrite the bounds of the component associations, if any.
1101
1102 2019-07-22 Gary Dismukes <dismukes@adacore.com>
1103
1104 * exp_ch5.adb (Expand_N_Case_Statement): In the case where a
1105 case statement is rewritten as an equivalent if statement,
1106 inherit the From_Condition_Expression flag from the case
1107 statement.
1108
1109 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1110
1111 * sem_ch8.adb (Check_Constrained_Object): Further extend the
1112 special optimization to all limited types.
1113
1114 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1115
1116 * exp_attr.adb (Expand_N_Attribute_Reference)
1117 <Attribute_Enum_Val>: Set No_Truncation on the
1118 N_Unchecked_Type_Conversion built around the argument passed to
1119 the attribute.
1120
1121 2019-07-22 Nicolas Roche <roche@adacore.com>
1122
1123 * libgnat/s-valrea.adb (Scan_Real): Ignore non significative
1124 digits to avoid converging to infinity in some cases.
1125
1126 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1127
1128 * libgnat/g-encstr.adb (Encode_Wide_String): Fix oversight.
1129 (Encode_Wide_Wide_String): Likewise.
1130
1131 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1132
1133 * sem_warn.adb (Find_Var): Bail out for a function call with an
1134 Out or In/Out parameter.
1135
1136 2019-07-22 Nicolas Roche <roche@adacore.com>
1137
1138 * terminals.c (__gnat_tty_waitpid): Support both blocking and
1139 not blocking mode.
1140 * libgnat/g-exptty.ads (Is_Process_Running): New function.
1141 * libgnat/g-exptty.adb (Close): Don't try to interrupt/terminate
1142 a process if it is already dead.
1143
1144 2019-07-22 Ed Schonberg <schonberg@adacore.com>
1145
1146 * freeze.adb (Freeze_Fixed_Point_Type): When freezing a
1147 fixed-point subtype, check whether the parent type declarastion
1148 includes an aspect specification for the 'Small type attribute,
1149 and inherit the specified value.
1150
1151 2019-07-22 Javier Miranda <miranda@adacore.com>
1152
1153 * freeze.adb (Freeze_Subprogram): Check that C++ constructors
1154 must have external or link name.
1155
1156 2019-07-22 Ed Schonberg <schonberg@adacore.com>
1157
1158 * sem_res.adb (Resolve_Selected_Component): If the prefix has a
1159 deferred reference, generate the correct reference now, to
1160 indicate that the previous assignment is used. This prevents
1161 spurious warnings on useless assignments when compiling with all
1162 warnings enabled. when there is a subsequent call in the same
1163 stqtement list, in which the prefix of the selected component is
1164 the actual for an out parameter.
1165
1166 2019-07-22 Eric Botcazou <ebotcazou@adacore.com>
1167
1168 * exp_attr.adb (Expand_Loop_Entry_Attribute): Copy the condition
1169 of a while loop instead of simply relocating it.
1170
1171 2019-07-18 Arnaud Charlet <charlet@adacore.com>
1172
1173 * Makefile.rtl, expect.c, env.c, aux-io.c, mkdir.c, initialize.c,
1174 cstreams.c, raise.c, tracebak.c, adadecode.c, init.c, raise-gcc.c,
1175 argv.c, adaint.c, adaint.h, ctrl_c.c, sysdep.c, rtinit.c, cio.c,
1176 seh_init.c, exit.c, targext.c: Introduce a "STANDALONE" mode where C
1177 runtime files do not have any dependency on GCC include files.
1178 Remove unnecessary includes.
1179 Remove remaining references to VMS in runtime C file.
1180 * runtime.h: new File.
1181
1182 2019-07-13 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 * Makefile.rtl: Use g-sercom__linux.adb for all linuxes.
1185
1186 2019-07-11 Piotr Trojanek <trojanek@adacore.com>
1187
1188 * lib-writ.adb (Ensure_System_Dependency,
1189 Up_To_Date_ALI_File_Exists, Write_ALI): Replace low-level access
1190 to table with a high-level query.
1191
1192 2019-07-11 Piotr Trojanek <trojanek@adacore.com>
1193
1194 * checks.adb: Fix typo in comment.
1195 * sem.adb (Semantics): Avoid repeated calls to
1196 In_Extended_Main_Source_Unit by reusing an already-cached
1197 result.
1198 * sem_util.adb (First_Global): Fix style.
1199
1200 2019-07-11 Yannick Moy <moy@adacore.com>
1201
1202 * sem_res.adb (Resolve_Call): Do not perform dimensionality
1203 checking on inlined bodies.
1204
1205 2019-07-11 Yannick Moy <moy@adacore.com>
1206
1207 * debug.adb: Flip meaning of debug switch -gnatdF.
1208
1209 2019-07-11 Yannick Moy <moy@adacore.com>
1210
1211 * sem_eval.adb (Is_Same_Value): Add special case for rewritten
1212 Loop_Entry attribute.
1213
1214 2019-07-11 Claire Dross <dross@adacore.com>
1215
1216 * gnat1drv.adb: SPARK checking rules for pointer aliasing are
1217 moved to GNATprove backend.
1218 * sem_spark.ads, sem_spark.adb (Sem_SPARK): Is now a generic
1219 unit. Takes as parameters:
1220 - Retysp which is used to query the most underlying type
1221 visible in SPARK. We do not introduce aliasing checks for
1222 types which are not visibly deep.
1223 - Component_Is_Visible_In_SPARK is used to avoid doing pointer
1224 aliasing checks on components which are not visible in SPARK.
1225 - Emit_Messages returns True in the second phase of SPARK
1226 analysis. Error messages for failed aliasing checks are only
1227 output in this case.
1228 Additionally, errors on constructs not supported in SPARK are
1229 removed as duplicates of marking errors. Components are stored
1230 in the permission map using their original component to avoid
1231 inconsistencies between components of different views of the
1232 same type.
1233 (Check_Expression): Handle delta constraints.
1234 (Is_Deep): Exported so that we can check for SPARK restrictions
1235 on deep types inside SPARK semantic checkings.
1236 (Is_Traversal_Function): Exported so that we can check for SPARK
1237 restrictions on traversal functions inside SPARK semantic
1238 checkings.
1239 (Check_Call_Statement, Read_Indexes): Check wether we are
1240 dealing with a subprogram pointer type before querying called
1241 entity.
1242 (Is_Subpath_Expression): Image attribute can appear inside a
1243 path.
1244 (Check_Loop_Statement): Correct order of statements in the loop.
1245 (Check_Node): Ignore raise nodes.
1246 (Check_Statement): Use Last_Non_Pragma to get the object
1247 declaration in an extended return statement.
1248
1249 2019-07-11 Patrick Bernardi <bernardi@adacore.com>
1250
1251 * bindgen.adb (Gen_Main): Do not generate a reference to
1252 Ada_Main_Program_Name when the Minimal_Binder flag is set.
1253 (Gen_Output_File_Ada): Do not output GNAT_Version and
1254 Ada_Main_Program_Name info if Minimal_Binder flag is set.
1255 * bindusg.adb: Add documentation for new -minimal switch.
1256 * gnatbind.adb (Scan_Bind_Arg): Scan -minimal switch.
1257 * opt.ads: Add new global flag Minimal_Binder to indicate if the
1258 binder should not produce global variables.
1259 * doc/gnat_ugn/building_executable_programs_with_gnat.rst:
1260 Update documentation with new binder -minimal switch.
1261 * gnat_ugn.texi: Regenerate.
1262
1263 2019-07-11 Eric Botcazou <ebotcazou@adacore.com>
1264
1265 * Makefile.rtl: Add warning note about compilation flags and
1266 capitalize.
1267
1268 2019-07-11 Ed Schonberg <schonberg@adacore.com>
1269
1270 * exp_ch9.adb (Expand_N_Protected_Type_Declaaration): New
1271 subsidiary routine Replace_Access_Definition, to handle properly
1272 a protected type PT one of whose private components is of type
1273 access PT.
1274
1275 2019-07-11 Dmitriy Anisimkov <anisimko@adacore.com>
1276
1277 * libgnat/g-socket.ads (Level_Type): Add enumerators for
1278 IP_Protocol_For_ICMP, IP_Protocol_For_IGMP,
1279 IP_Protocol_For_RAW_Level.
1280 * libgnat/g-socket.adb (Levels): Handle them.
1281 * s-oscons-tmplt.c: Import socket protocols defined in
1282 netinet/in.h.
1283
1284 2019-07-11 Claire Dross <dross@adacore.com>
1285
1286 * libgnat/a-cfhama.adb, libgnat/a-cfhase.adb (Free): Do not
1287 reset the Has_Element flag if no element is freed.
1288
1289 2019-07-11 Arnaud Charlet <charlet@adacore.com>
1290
1291 * errno.c: Remove obsolete support for MaRTE OS.
1292
1293 2019-07-11 Ed Schonberg <schonberg@adacore.com>
1294
1295 * exp_ch4.adb (Expand_N_Type_Conversion): If a predicate check
1296 is generated, analyze it with range check suppressed, because
1297 that check has been previously applied.
1298 * exp_ch5.adb (Expand_N_Assignment_Statement): If the RHS is a
1299 type conversion to the type of the LHS, do not apply a predicate
1300 check to the RHS because it will have been generated already
1301 during its expansion.
1302 * exp_ch6.adb (Can_Fold_Predicate_Call): Extend processing to
1303 handle a predicate check on a constant entity whose value is
1304 static.
1305
1306 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1307
1308 * bindo.adb: Remove the documentation of switch -d_N because it
1309 is no longer in use.
1310 * bindo-graphs.ads, bindo-graphs.adb (Is_Spec_Before_Body_Edge):
1311 New routine.
1312 * bindo-writers.adb (Write_Dependency_Edge): Add the missing
1313 case of a spec-before-body edge.
1314
1315 2019-07-11 Dmitriy Anisimkov <anisimko@adacore.com>
1316
1317 * libgnat/g-socket.ads (Mode_Type): Add a Socket_Raw enumerator.
1318 * libgnat/g-socket.adb (Modes): Handle Socket_Raw.
1319
1320 2019-07-11 Justin Squirek <squirek@adacore.com>
1321
1322 * exp_ch9.adb (Build_Private_Protected_Declaration): Add
1323 exception for the moving of pragmas to internally generated
1324 specs for pragma Unreferenced.
1325
1326 2019-07-11 Bob Duff <duff@adacore.com>
1327
1328 * doc/gnat_ugn/gnat_utility_programs.rst: Fix inconsistent
1329 documentation for gnatmetric.
1330 * gnat_ugn.texi: Regenerate.
1331
1332 2019-07-11 Bob Duff <duff@adacore.com>
1333
1334 * doc/gnat_ugn/gnat_utility_programs.rst: Document gnatpp's
1335 --spaces-only switch.
1336
1337 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1338
1339 * sem_util.adb (Null_Status): Assume that an erroneous construct
1340 has an undefined null status.
1341
1342 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1343
1344 * checks.adb, exp_ch6.adb, gnat1drv.adb, sem_aux.adb,
1345 sem_ch2.adb, sem_ch8.adb, sem_res.adb: Minor reformatting.
1346
1347 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1348
1349 * sem_ch8.adb (Analyze_Object_Renaming): Obtain the object being
1350 renamed using routine Get_Object_Name which takes care of
1351 various name forms.
1352 (Get_Object_Name): New routine.
1353
1354 2019-07-11 Ed Schonberg <schonberg@adacore.com>
1355
1356 * exp_ch6.adb (Can_Fold_Predicate_Call): New function,
1357 subsidiary of Expand_Call_Helper, to compute statically a
1358 predicate check when the argument is a static integer.
1359
1360 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1361
1362 * sem_res.adb (Resolve_Op_Not): Do not rewrite an equality
1363 operator into a function call when the operator is intrinsic.
1364
1365 2019-07-11 Thomas Quinot <quinot@adacore.com>
1366
1367 * sem_prag.adb (Analyze_Pragma, case pragma Check): Do not call
1368 Set_SCO_Pragma_Enabled for the dynamic predicate case.
1369
1370 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1371
1372 * exp_util.ads, exp_util.adb (Needs_Finalization): Move to
1373 Sem_Util.
1374 * sem_ch9.adb (Analyze_Protected_Definition): Code cleanup. Mark
1375 the protected type as having controlled components when it
1376 contains at least one such component.
1377 * sem_util.ads, sem_util.adb (Needs_Finalization): New
1378 function.
1379
1380 2019-07-11 Eric Botcazou <ebotcazou@adacore.com>
1381
1382 * alloc.ads (Rep_JSON_Table_Initial): New constant.
1383 (Rep_JSON_Table_Increment): Likewise.
1384 * debug.adb: Document -gnatd_j switch.
1385 * gcc-interface/Make-lang.in (GNAT_ADA_OBJS): Add
1386 repinfo-input.o.
1387 * gnat1drv.adb: Add with clause for Repinfo.Input.
1388 Add with and use clauses for Sinput.
1389 (Read_JSON_Files_For_Repinfo): New procedure.
1390 (Gnat1drv1): Deal with -gnatd_j switch.
1391 * repinfo-input.ad[sb]: New unit.
1392 * snames.ads-tmpl (Name_Discriminant): New constant.
1393 (Name_Operands): Likewise.
1394
1395 2019-07-11 Justin Squirek <squirek@adacore.com>
1396
1397 * checks.adb (Apply_Accessibility_Check): Add check for constant
1398 folded conditions on accessibility checks.
1399
1400 2019-07-11 Arnaud Charlet <charlet@adacore.com>
1401
1402 * libgnarl/g-thread.ads, libgnarl/g-thread.adb (Get_Thread):
1403 Update comments. Add new version taking a Task_Id.
1404
1405 2019-07-11 Hristian Kirtchev <kirtchev@adacore.com>
1406
1407 * bindo.adb: Update the section of switches and debugging
1408 elaboration issues.
1409 * bindo.ads: Add type Elaboration_Phase.
1410 * bindo-augmentors.adb: Add use clause for
1411 Bindo.Writers.Phase_Writers.
1412 (Augment_Library_Graph): Signal the start and end of the
1413 aubmentation phase.
1414 * bindo-builders.adb: Add with and use clause for Bindo.Writers.
1415 Add use clause for Bindo.Writers.Phase_Writers.
1416 (Build_Invocation_Graph): Signal the start and end of the
1417 invocation graph construction phase.
1418 (Build_Library_Graph): Signal the start and end of the library
1419 graph construction phase.
1420 * bindo-diagnostics.adb: Add use clause for
1421 Bindo.Writers.Phase_Writers.
1422 (Diagnose_Cycle): Signal the start and end of the cycle
1423 diagnostic phase.
1424 * bindo-elaborators.adb: Add use clause for
1425 Bindo.Writers.Phase_Writers.
1426 (Elaborate_Units): Signal the start and end of the unit
1427 elaboration phase.
1428 * bindo-graphs.adb: Add use clause for
1429 Bindo.Writers.Phase_Writers.
1430 (Find_Components): Signal the start and end of the component
1431 discovery phase.
1432 (Find_Cycles): Signal the start and end of the cycle discovery
1433 phase.
1434 * bindo-units.adb: Add with and use clause for Bindo.Writers.
1435 Add use clause for Bindo.Writers.Phase_Writers.
1436 (Collect_Elaborable_Units): Signal the start and end of the unit
1437 collection phase.
1438 * bindo-validators.adb: Add with and use clause for
1439 Bindo.Writers. Add use clause for Bindo.Writers.Phase_Writers.
1440 (Validate_Cycles, Validate_Elaboration_Order,
1441 Validate_Invocation_Graph, Validate_Library_Graph): Signal the
1442 start and end of the libray graph validation phase.
1443 * bindo-writers.ads, bindo-writers.adb: Add new nested package
1444 Phase_Writers.
1445 * debug.adb: Update the documentation of switch d_S.
1446
1447 2019-07-11 Yannick Moy <moy@adacore.com>
1448
1449 * sem_res.adb (Check_Argument_Order): Special case calls to
1450 operators.
1451
1452 2019-07-10 Dmitriy Anisimkov <anisimko@adacore.com>
1453
1454 * libgnat/s-ststop.adb: Remove System.Strings.Stream_Ops
1455 dependence on System.Streams.Stream_IO.
1456
1457 2019-07-10 Ed Schonberg <schonberg@adacore.com>
1458
1459 * sem_ch2.adb (Analyze_Integer_Literal): Preserve the type of
1460 the literal if prior analysis determined that its type is a
1461 modular integer type.
1462
1463 2019-07-10 Doug Rupp <rupp@adacore.com>
1464
1465 * init.c: Do not attempt to re-arm guard page on x86_64-vx7(r2).
1466
1467 2019-07-10 Ed Schonberg <schonberg@adacore.com>
1468
1469 * sem_ch8.adb (Check_Constrained_Object): A record that is
1470 limited because of the presence of a limited component is
1471 constrained, and no subtype indiciation needs to be created for
1472 it, just as is the case for declared limited records.
1473
1474 2019-07-10 Yannick Moy <moy@adacore.com>
1475
1476 * sem_aux.adb, sem_aux.ads (Is_Protected_Operation): New
1477 function to determine if a subprogram is protected.
1478 * sem_spark.adb (Setup_Protected_Components): New procedure to
1479 add protected components to the environment.
1480 (Check_Callable_Body): Call the new Setup_Protected_Components.
1481 (Check_Package_Spec): Merge local environment with enclosing one
1482 when done.
1483
1484 2019-07-10 Claire Dross <dross@adacore.com>
1485
1486 * sem_spark.adb (Check_Expression): Allow digits constraints as
1487 input.
1488 (Illegal_Global_Usage): Pass in the entity.
1489 (Is_Subpath_Expression): New function to allow different nodes
1490 as inner parts of a path expression.
1491 (Read_Indexes): Allow concatenation and aggregates with box
1492 expressions. Allow attributes Update and Loop_Entry.
1493 (Check_Expression): Allow richer membership test.
1494 (Check_Node): Ignore bodies of generics.
1495 (Get_Root_Object): Allow concatenation and attributes.
1496
1497 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1498
1499 * sem_ch6.adb (Check_Discriminant_Conformance): Use Find_Type to
1500 discover the type of a full view discriminant.
1501
1502 2019-07-10 Arnaud Charlet <charlet@adacore.com>
1503
1504 * doc/gnat_ugn/gnat_and_program_execution.rst: Improve gnatmem's
1505 doc for the depth switch.
1506
1507 2019-07-10 Bob Duff <duff@adacore.com>
1508
1509 * doc/gnat_ugn/gnat_utility_programs.rst: Document gnatpp's
1510 --source-line-breaks switch.
1511
1512 2019-07-10 Justin Squirek <squirek@adacore.com>
1513
1514 * doc/gnat_rm/implementation_defined_attributes.rst: Add mention
1515 of 'Image attribute with 'Img's entry to mention additional
1516 added 2012 usage of Obj'Image.
1517 * doc/gnat_rm/implementation_defined_pragmas.rst: Correct
1518 mispelling of Async_Writers.
1519 * gnat_rm.texi: Regenerate.
1520 * sem_prag.adb (Analyze_Pragma): Correct mispelling of
1521 Async_Writers.
1522 * sem_util.adb (State_Has_Enabled_Property): Correct mispelling
1523 of Async_Writers.
1524
1525 2019-07-10 Simon Buist <buist@adacore.com>
1526
1527 * sem_util.ads (Child_Prefix): New constant.
1528 * sem_util.adb (Unique_Name): Add a special prefix to child
1529 units that have a nested subprogram or package.
1530
1531 2019-07-10 Arnaud Charlet <charlet@adacore.com>
1532
1533 * sfn_scan.adb (Scan_SFN_Pragmas): Add pragma Assert.
1534
1535 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1536
1537 * sem_ch3.adb (Check_Nonoverridable_Aspects): Correct the
1538 spelling in certain error messages.
1539 (Check_Pragma_Implemented): Correct the spelling in certain
1540 error messages.
1541
1542 2019-07-10 Eric Botcazou <ebotcazou@adacore.com>
1543
1544 * Makefile.rtl (GNATRTL_NONTASKING_OBJS): Add g-brapre.
1545 * libgnat/g-brapre.ads: New package specification.
1546 * doc/gnat_rm/the_gnat_library.rst: Document it.
1547 * gnat_rm.texi: Regenerate.
1548
1549 2019-07-10 Yannick Moy <moy@adacore.com>
1550
1551 * osint-c.adb (Set_File_Name): Always add extension for multiple
1552 units per file mode.
1553
1554 2019-07-10 Corentin Gay <gay@adacore.com>
1555
1556 * sysdep.c: Put include directive for 'vxWorks.h' before any
1557 other VxWorks headers.
1558
1559 2019-07-10 Eric Botcazou <ebotcazou@adacore.com>
1560
1561 * doc/gnat_rm/implementation_defined_attributes.rst
1562 (Scalar_Storage_Order): Minor tweaks. Add note about debuggers.
1563 * gnat_rm.texi: Regenerate.
1564
1565 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1566
1567 * exp_ch4.adb (Expand_N_Case_Expression): Mark the generated
1568 assignments to the temporary result as being OK because the
1569 expansion of case expressions is correct by construction.
1570 (Is_Copy_Type): Update the predicate to match the comment
1571 within.
1572
1573 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1574
1575 * bindo-graphs.adb, bindo.adb, debug.adb, exp_ch6.adb,
1576 sem_ch10.adb, sem_ch13.adb, sem_ch3.adb, sem_ch4.adb,
1577 sem_ch6.adb, sem_ch7.adb, sem_res.adb, sem_spark.adb,
1578 sem_util.adb, warnsw.ads: Minor reformatting.
1579
1580 2019-07-10 Joffrey Huguet <huguet@adacore.com>
1581
1582 * libgnat/a-strbou.ads, libgnat/a-strfix.ads,
1583 libgnat/a-strunb.ads, libgnat/a-strunb__shared.ads: Add global
1584 contracts, contract cases, preconditions and postconditions to
1585 procedures and functions.
1586
1587 2019-07-10 Doug Rupp <rupp@adacore.com>
1588
1589 * sysdep.c (__gnat_is_file_not_found_error): Reformulate to also
1590 work for vxworks7r2 SR0610.
1591
1592 2019-07-10 Doug Rupp <rupp@adacore.com>
1593
1594 * env.c (__gnat_environ): Reformulate to also work for
1595 vxworks7r2 SR0610.
1596
1597 2019-07-10 Patrick Bernardi <bernardi@adacore.com>
1598
1599 * Makefile.rtl: Handle vxworks7r2 ppc target
1600
1601 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1602
1603 * bindo.adb: Update the section on switches.
1604 * bindo-graphs.adb
1605 (Add_Cycle, Add_Vertex_And_Complement): Remove.
1606 (Create): The graph no longer needs a set of recorded cycles
1607 because the cycles are not rediscovered in permuted forms.
1608 (Cycle_End_Vertices): New routine.
1609 (Destroy): The graph no longer needs a set of recorded cycles
1610 because the cycles are not rediscovered in permuted forms.
1611 (Destroy_Library_Graph_Vertex): Move to the library level.
1612 (Find_All_Cycles_Through_Vertex, Find_All_Cycles_With_Edge):
1613 Remove.
1614 (Find_Cycles_From_Successor, Find_Cycles_From_Vertex,
1615 Find_Cycles_In_Component, Has_Elaborate_All_Edge): New routines.
1616 (Insert_And_Sort): Remove.
1617 (Is_Elaborate_Body_Edge): Use predicate
1618 Is_Vertex_With_Elaborate_Body.
1619 (Is_Recorded_Cycle): Remove.
1620 (Is_Vertex_With_Elaborate_Body): New routine.
1621 (Normalize_And_Add_Cycle): Remove.
1622 (Precedence): Rename to xxx_Precedence, where xxx relates to the
1623 input. These versions better reflect the desired input
1624 precedence.
1625 (Record_Cycle): New routine.
1626 (Remove_Vertex_And_Complement, Set_Is_Recorded_Cycle): Remove.
1627 (Trace_xxx): Update all versions to use debug switch -d_t.
1628 (Trace_Component): New routine.
1629 (Trace_Eol): Removed.
1630 (Trace_Vertex): Do not output the component as this information
1631 is already available when the component is traced.
1632 (Unvisit, Visit): New routine.
1633 * bindo-graphs.ads: Add new instance LGV_Lists. Remove instance
1634 RC_Sets. Update the structure of type Library_Graph_Attributes
1635 to remove the set of recorded cycles.
1636 (Destroy_Library_Graph_Vertex): Move to the library level.
1637 * bindo-writers.adb (Write_Component_Vertices): Output
1638 information about the number of vertices.
1639 * debug.adb: Document the use of binder switch -d_t. Update the
1640 use of binder switch -d_T.
1641
1642 2019-07-10 Yannick Moy <moy@adacore.com>
1643
1644 * sem_spark.adb (Get_Root_Object): Replace precondition by error
1645 message.
1646 (Read_Indexes): Replace precondition by error message.
1647 (Check_Callable_Body): Check only traversal function returns an
1648 anonymous access type.
1649 (Check_Expression): Issue error on unexpected expression as
1650 path.
1651 * sem_util.adb (First_Global): Fix access to global on
1652 entry/task.
1653
1654 2019-07-10 Javier Miranda <miranda@adacore.com>
1655
1656 * exp_ch6.adb (Is_Class_Wide_Interface_Type): New subprogram.
1657 (Expand_Call_Helper): Handle non-limited views when we check if
1658 any formal is a class-wide interface type.
1659 * exp_disp.adb (Expand_Interface_Actuals): Handle non-limited
1660 views when we look for interface type formals to force "this"
1661 displacement.
1662
1663 2019-07-10 Ed Schonberg <schonberg@adacore.com>
1664
1665 * sem_res.adb (Resolve_Equality_Op): Do not replace the resolved
1666 operator by its alias if expander is not active, because the
1667 operand type may not be frozen yet and its inherited operations
1668 have not yet been created.
1669
1670 2019-07-10 Hristian Kirtchev <kirtchev@adacore.com>
1671
1672 * bindo-elaborators.adb (Elaborate_Units): Set attribute
1673 Elab_Position of all elaborated units.
1674 (Set_Unit_Elaboration_Positions): New routine.
1675
1676 2019-07-10 Gary Dismukes <dismukes@adacore.com>
1677
1678 * exp_util.adb: Reformatting and a typo fix.
1679
1680 2019-07-10 Yannick Moy <moy@adacore.com>
1681
1682 * exp_util.adb (Remove_Side_Effects): Prefer renamings for
1683 objects of possible owning type in GNATprove mode.
1684
1685 2019-07-09 Ed Schonberg <schonberg@adacore.com>
1686
1687 * sem_ch3.adb (Analyze_Object_Declaration): If the object type
1688 is a composite type that has a dynamic predicate and, the
1689 expression in the declaration is an aggregate, the generated
1690 predicate check must appear after the expanded code for the
1691 aggregate, which will appear after the rewritten object
1692 declarastion.
1693
1694 2019-07-09 Justin Squirek <squirek@adacore.com>
1695
1696 * sem_eval.adb (Expr_Value_E): Add conditional to correctly
1697 handle constant enumerated character types.
1698
1699 2019-07-09 Eric Botcazou <ebotcazou@adacore.com>
1700
1701 * libgnarl/s-osinte__mingw.ads (CRITICAL_SECTION): Use proper
1702 type for SpinCount component.
1703
1704 2019-07-09 Justin Squirek <squirek@adacore.com>
1705
1706 * exp_ch4.adb (Expand_N_Allocator): Add conditional to detect
1707 the presence of anoymous access type allocators and issue a
1708 warning if the appropriate warning flag is enabled.
1709 * warnsw.ads: Add new warning flag for anonymous allocators
1710 * warnsw.adb (All_Warnings, Restore_Warnings, Save_Warnings,
1711 Set_Underscore_Warning_Switch): Register new flags.
1712 (WA_Warnings): Register new flag as an "all warnings" switch
1713 * usage.adb,
1714 doc/gnat_ugn/building_executable_programs_with_gnat.rst:
1715 Document new warning switches -gnatw_a and -gnatw_A.
1716 * gnat_ugn.texi: Regenerate.
1717
1718 2019-07-09 Ed Schonberg <schonberg@adacore.com>
1719
1720 * sem_ch4.adb (Diagnose_Call): Improve error recovery when a
1721 local subprogram name hides a possible candidate name declared
1722 in a child package in the context of the current unit.
1723 * sem_ch6.adb (Process_Formals): Protect against malformed
1724 formal types when the parameter type does not denote an entity.
1725
1726 2019-07-09 Hristian Kirtchev <kirtchev@adacore.com>
1727
1728 * bindo-augmentors.adb (Visit_Elaboration_Root): Do not start a
1729 DFS from an elaboration root whose corresponding unit lacks
1730 elaboration code. This behavior mimics that of the old
1731 elaboration order mechanism.
1732 * bindo-graphs.adb (Find_All_Cycles_Through_Vertex): Move the
1733 vertex tracing within the functional branches of the routine.
1734 This prevents spurious trace output.
1735 (Has_No_Elaboration_Code): New routine.
1736 (Trace_Cycle, Trace_Edge): Update the various Ids to use the
1737 "standard" trace format.
1738 * bindo-graphs.ads (Has_No_Elaboration_Code): New routine.
1739 * bindo-units.ads, bindo-units.adb (Has_No_Elaboration_Code):
1740 New routine.
1741
1742 2019-07-09 Piotr Trojanek <trojanek@adacore.com>
1743
1744 * ali.ads, bindo-graphs.adb, bindo-validators.adb, clean.adb,
1745 doc/gnat_ugn/elaboration_order_handling_in_gnat.rst, einfo.ads,
1746 exp_aggr.adb, exp_ch13.adb, exp_ch4.adb, exp_ch5.adb,
1747 exp_ch6.adb, exp_ch7.adb, exp_ch9.adb, exp_pakd.adb,
1748 fname-uf.ads, gnatlink.adb, inline.adb, lib.ads, make.adb,
1749 namet.ads, opt.ads, par-ch4.adb, par-ch6.adb, par-labl.adb,
1750 prep.adb, sem_aggr.adb, sem_ch13.adb, sem_ch4.adb, sem_ch5.adb,
1751 sem_ch6.adb, sem_ch6.ads, sem_ch7.adb, sem_ch8.adb, sem_dim.adb,
1752 sem_disp.adb, sem_prag.adb, sem_res.adb, sem_warn.adb,
1753 sinfo.ads: Replace ". " with ". ". Minor reformatting and typo
1754 corrections.
1755 * gnat_ugn.texi: Generate.
1756
1757 2019-07-09 Hristian Kirtchev <kirtchev@adacore.com>
1758
1759 * bindo.ads: Move type Precedence_Kind from the private to the
1760 visible part of the unit.
1761 * bindo-augmentors.adb: Remove the use of global data as it is
1762 bad practice.
1763 (Augment_Library_Graph): Update the parameter profile.
1764 (Is_Visited, Set_Is_Visited): Remove.
1765 (Visit_Elaboration_Root, Visit_Elaboration_Roots): Update the
1766 parameter profile and comment on usage.
1767 (Visit_Vertex): Likewise. Also keep track of which invocation
1768 edge activates a task.
1769 * bindo-augmentors.ads (Augment_Library_Graph): Update the
1770 parameter profile and comment on usage.
1771 * bindo-builders.adb (Create_Forced_Edge,
1772 Create_Spec_And_Body_Edge, Create_With_Edge): Update the call to
1773 Add_Edge.
1774 * bindo-diagnostics.adb: Add with end use clauses for Restrict
1775 and Rident.
1776 (Output_Dynamic_Model_Suggestions): Remove.
1777 (Output_Invocation_Related_Suggestions): New routine.
1778 (Output_Suggestions): Output all invocation-related suggestions
1779 together.
1780 * bindo-elaborators.adb: Remove types Comparator_Ptr and
1781 Predicate_Ptr.
1782 (Find_Best_Vertex): Update the parameter profile.
1783 * bindo-graphs.adb (Activates_Task): New routine.
1784 (Add_Body_Before_Spec_Edge): Update the call to
1785 Add_Edge_With_Return.
1786 (Add_Edge): Update the parameter profile and the call to
1787 Add_Edge_With_Return.
1788 (Add_Edge_With_Return): Update the parameter profile and comment
1789 on usage.
1790 (At_Least_One_Edge_Satisfies): New routine.
1791 (Contains_Elaborate_All_Edge): Reimplement.
1792 (Contains_Static_Successor_Edge, Contains_Task_Activation): New
1793 routine.
1794 (Contains_Weak_Static_Successor): Remove.
1795 (Is_Static_Successor_Edge): New routine.
1796 * bindo-graphs.ads: Add types LGE_Predicate_Ptr,
1797 LGV_Comparator_Ptr, and LGV_Predicate_Ptr. Update type
1798 Library_Graph_Edge_Attributes to capture whether an invocation
1799 edge activates a task. Update the value of
1800 No_Library_Graph_Edge_Attributes.
1801 (Activates_Task): Update the parameter profile and comment on
1802 usage.
1803 (Contains_Static_Successor_Edge, Contains_Task_Activation): New
1804 routines.
1805 (Contains_Weak_Static_Successor): Remove.
1806 * doc/gnat_ugn/elaboration_order_handling_in_gnat.rst:
1807 Update the documentation to reflect the new task-related advice.
1808 * gnat_ugn.texi: Regenerate.
1809
1810 2019-07-09 Piotr Trojanek <trojanek@adacore.com>
1811
1812 * exp_util.adb (Containing_Package_With_Ext_Axioms): Replace
1813 low-level Ekind test with a high-level wrapper.
1814
1815 2019-07-09 Arnaud Charlet <charlet@adacore.com>
1816
1817 * libgnat/s-memory.adb: Disable calls to Abort defer/undefer
1818 when ZCX_By_Default.
1819
1820 2019-07-09 Javier Miranda <miranda@adacore.com>
1821
1822 * sem_ch13.adb (Rep_Item_Too_Early): Representation clauses are
1823 not allowed for a derivation of a generic type. Extend the
1824 current test to check that none of the parents is a generic
1825 type.
1826
1827 2019-07-09 Hristian Kirtchev <kirtchev@adacore.com>
1828
1829 * exp_ch9.adb, exp_util.adb, repinfo.adb, sem_ch12.adb,
1830 sem_prag.adb, sem_res.adb, sem_spark.adb, sem_util.adb: Minor
1831 reformatting.
1832
1833 2019-07-09 Ed Schonberg <schonberg@adacore.com>
1834
1835 * sem_res.adb (Resolve_Equality_Op): If the node was overloaded,
1836 set properly the entity to which the node has been resolved. The
1837 original entity is the first one found during analysis, and is
1838 not necessarily the resolved one.
1839 (Resolve_Op_Not): If the argument of negation is an overloaded
1840 equality operation, call its resolution directly given that the
1841 context type does not participate in overload resolution.
1842
1843 2019-07-09 Hristian Kirtchev <kirtchev@adacore.com>
1844
1845 * bindo.adb: Remove with and use clauses for Debug. Add with
1846 and use clauses for Opt.
1847 (Find_Elaboration_Order): Enable the v4.0 elaboration order. The
1848 v3.0 mechanism is now available under binder switch -H.
1849 * bindusg.adb (Display): Enable switch -H.
1850 * debug.adb: Free compiler switch -gnatd_G. Free binder switch
1851 -d_N.
1852 * sem_elab.adb: Update the section on switches to remove
1853 -gnatd_G.
1854 (Invocation_Graph_Recording_OK): The invocation graph is now
1855 unconditionally recorded in ALI files.
1856 * switch-b.adb (Scan_Binder_Switches): Scan switch -H.
1857 * doc/gnat_ugn/building_executable_programs_with_gnat.rst:
1858 Update the documentation on compiler switches related to
1859 elaboration. Update the documentation on binder switches to
1860 include switch -H.
1861 * doc/gnat_ugn/elaboration_order_handling_in_gnat.rst: Update
1862 the documentation on elaboration order handling in GNAT.
1863 * gnat_ugn.texi: Regenerate.
1864
1865 2019-07-09 Eric Botcazou <ebotcazou@adacore.com>
1866
1867 * repinfo.adb (List_Entities): Disregard formals altogether.
1868 (List_Name): Properly escape the double quote in the JSON
1869 output.
1870
1871 2019-07-09 Javier Miranda <miranda@adacore.com>
1872
1873 * exp_util.adb (Remove_Side_Effects): Preserve the
1874 Do_Range_Check flag.
1875
1876 2019-07-09 Yannick Moy <moy@adacore.com>
1877
1878 * sinfo.ads: Refine comment for Do_Range_Check.
1879
1880 2019-07-09 Yannick Moy <moy@adacore.com>
1881
1882 * exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Expand
1883 attribute reference on Enum_Rep.
1884
1885 2019-07-09 Ed Schonberg <schonberg@adacore.com>
1886
1887 * sem_ch12.adb (Instantiate_Formal_Package): Handle properly the
1888 case where the actual for a formal package in an instance is the
1889 current instance of an enclosing generic package.
1890 (Check_Formal_Packages): If the formal package declaration is
1891 box-initialized or lacks associations altogether, no internal
1892 instance was created to verify conformance, and there is no
1893 validating package to remove from tree.
1894
1895 2019-07-09 Yannick Moy <moy@adacore.com>
1896
1897 * freeze.adb (Build_Renamed_Body): Do not set body to inline in
1898 GNATprove mode.
1899
1900 2019-07-09 Yannick Moy <moy@adacore.com>
1901
1902 * exp_util.adb (Expand_Subtype_From_Expr): Still expand the type
1903 of static expressions in GNATprove_Mode.
1904 * sem_ch3.adb (Analyze_Object_Declaration): Remove obsolete
1905 special case for GNATprove_Mode.
1906
1907 2019-07-09 Piotr Trojanek <trojanek@adacore.com>
1908
1909 * doc/gnat_rm/the_gnat_library.rst,
1910 doc/gnat_ugn/building_executable_programs_with_gnat.rst,
1911 erroutc.adb, libgnat/g-comlin.adb, libgnat/g-comlin.ads,
1912 libgnat/g-regexp.ads, libgnat/g-regpat.ads,
1913 libgnat/g-spipat.ads, libgnat/s-os_lib.ads,
1914 libgnat/s-regexp.ads: Reword "wild card" to "wildcard".
1915 * gnat_rm.texi, gnat_ugn.texi: Regenerate.
1916
1917 2019-07-09 Yannick Moy <moy@adacore.com>
1918
1919 * sem_spark.adb (Check_Expression): Handle correctly implicit
1920 assignments as part of allocators and (extension) aggregates.
1921 (Get_Root_Object): Adapt for new path expressions.
1922 (Is_Path_Expression): Return True for (extension) aggregate.
1923
1924 2019-07-09 Piotr Trojanek <trojanek@adacore.com>
1925
1926 * einfo.ads: Fix a typo.
1927
1928 2019-07-09 Ed Schonberg <schonberg@adacore.com>
1929
1930 * sem_util.adb (Scope_Within_Or_Same): Handle properly task
1931 bodies and protected bodies, so that local variables within have
1932 their proper scopes after these constructs have been rewritten
1933 during expansion. This patch resembles but is not identical to
1934 the code in Scope_Within.
1935
1936 2019-07-09 Arnaud Charlet <charlet@adacore.com>
1937
1938 * gnat1drv.adb (Adjust_Global_Switches): Set
1939 Dynamic_Elaboration_Checks to True in CodePeer mode.
1940
1941 2019-07-09 Yannick Moy <moy@adacore.com>
1942
1943 * sem_spark.adb (Get_Perm_Or_Tree): Issue an error when
1944 encountering unknown global variable.
1945
1946 2019-07-09 Yannick Moy <moy@adacore.com>
1947
1948 * sem_spark.adb (Check_Expression): Change signature to take an
1949 Extended_Checking_Mode, for handling read permission checking of
1950 sub-expressions in an assignment.
1951 (Check_Parameter_Or_Global): Adapt to new behavior of
1952 Check_Expression for mode Assign.
1953 (Check_Safe_Pointers): Do not analyze generic bodies.
1954 (Check_Assignment): Separate checking of the target of an
1955 assignment.
1956
1957 2019-07-09 Eric Botcazou <ebotcazou@adacore.com>
1958
1959 * repinfo.ads (JSON format): Adjust.
1960 * repinfo.adb (Need_Blank_Line): Rename to...
1961 (Need_Separator): ...this.
1962 (Blank_Line): Rename to...
1963 (Write_Separator): ...this and add JSON specific handling.
1964 (List_Array_Info): Adjust to above renaming.
1965 (List_Object_Info): Likewise.
1966 (List_Record_Info): Likewise.
1967 (List_Subprogram_Info): Likewise.
1968 (List_Type_Info): Likewise.
1969 (List_Entities): Do not set Need_Blank_Line.
1970 (List_Rep_Info): Set Need_Separator and add JSON specific
1971 handling. Output a single JSON stream in the normal case.
1972
1973 2019-07-09 Arnaud Charlet <charlet@adacore.com>
1974
1975 * doc/gnat_ugn/the_gnat_compilation_model.rst: Update doc on
1976 -fdump-ada-spec now that we generate Ada 2012.
1977 * gnat_ugn.texi: Regenerate.
1978
1979 2019-07-08 Eric Botcazou <ebotcazou@adacore.com>
1980
1981 * repinfo.adb (List_Common_Type_Info): New procedure extracted
1982 from...
1983 (List_Type_Info): ...here. Call it for the common information,
1984 start with a blank line and output the linker section at the
1985 end, if any.
1986 (List_Mechanisms): Rename to...
1987 (List_Subprogram_Info): ...this.
1988 (List_Array_Info): Call List_Common_Type_Info.
1989 (List_Entities): Adjust to above change and renaming.
1990 (List_Record_Info): Call List_Common_Type_Info.
1991
1992 2019-07-08 Dmitriy Anisimkov <anisimko@adacore.com>
1993
1994 * libgnat/g-sercom.ads
1995 (Serial_Port_Descriptor): New type.
1996 (Serial_Port): Add a comment, make it hold a
1997 Serial_Port_Descriptor.
1998 (To_Ada, To_C): New procedures.
1999 (Port_Data, Port_Data_Access): Remove types.
2000 * libgnat/g-sercom.adb (To_Ada): New stub.
2001 * libgnat/g-sercom__linux.adb, libgnat/g-sercom__mingw.adb:
2002 Update implementations accordingly.
2003 * s-oscons-tmplt.c: Bind Serial_Port_Descriptor to
2004 System.Win32.HANDLE on Windows, and to Interfaces.C.int on
2005 Linux. Add "Interfaces.C." prefix for other basic integer type
2006 bindings.
2007 * xoscons.adb (Output_Info): Remove the "Interfaces.C." prefix
2008 for subtypes generation.
2009
2010 2019-07-08 Arnaud Charlet <charlet@adacore.com>
2011
2012 * doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
2013 Update documentation on No_Exceptions restriction.
2014 * gnat_rm.texi: Regenerate.
2015
2016 2019-07-08 Dmitriy Anisimkov <anisimko@adacore.com>
2017
2018 * libgnat/s-os_lib.adb: Do not call __gnat_kill for Invalid_Pid.
2019
2020 2019-07-08 Piotr Trojanek <trojanek@adacore.com>
2021
2022 * sem_util.adb (Enclosing_Package_Or_Subprogram): Do not expect
2023 package and subprogram bodies.
2024
2025 2019-07-08 Bob Duff <duff@adacore.com>
2026
2027 * doc/gnat_ugn/gnat_utility_programs.rst: Remove documentation
2028 of ignored GNATpp switch.
2029
2030 2019-07-08 Hristian Kirtchev <kirtchev@adacore.com>
2031
2032 * doc/gnat_rm/implementation_defined_pragmas.rst:
2033 Update the documentation of pragma Initialize_Scalars.
2034 * gnat_rm.texi: Regenerate.
2035
2036 2019-07-08 Javier Miranda <miranda@adacore.com>
2037
2038 * exp_ch4.adb (Tagged_Membership): Fix regression silently
2039 introduced in r260738 that erroneouslusy causes the evaluation
2040 to True of the membership test when the left operand of the
2041 membership test is a class-wide interface object and the right
2042 operand is a type that implements such interface type.
2043
2044 2019-07-08 Hristian Kirtchev <kirtchev@adacore.com>
2045
2046 * sem_ch13.adb (Analyze_Attribute_Definition_Clause): Do not
2047 register an address clause when its prefix denotes a generic
2048 formal object.
2049
2050 2019-07-08 Hristian Kirtchev <kirtchev@adacore.com>
2051
2052 * bindo-diagnostics.adb (Diagnose_Cycle): Capture the presence
2053 of an Elaborate_All edge before iterating over the edges of the
2054 cycle.
2055 (Output_Elaborate_Body_Transition): Update the parameter profile
2056 and the comment on usage. Add a missing case where the edge is
2057 within the context of an Elaborate_All.
2058 (Output_Transition): Update the call to
2059 Output_Elaborate_Body_Transition.
2060 * bindo-graphs.ads, bindo-graphs.adb
2061 (Contains_Elaborate_All_Edge): New routine.
2062
2063 2019-07-08 Piotr Trojanek <trojanek@adacore.com>
2064
2065 * lib-xref-spark_specific.adb (Create_Heap): Set dummy Etype for
2066 the fake __HEAP entity.
2067
2068 2019-07-08 Daniel Mercier <mercier@adacore.com>
2069
2070 * gnat1drv.adb: Suppress warnings on memory representation in
2071 CodePeer compiler mode.
2072
2073 2019-07-08 Nicolas Roche <roche@adacore.com>
2074
2075 * rtinit.c (__gnat_runtime_initialize): Remove dependency on
2076 CommandLineToArgvW.
2077
2078 2019-07-08 Doug Rupp <rupp@adacore.com>
2079
2080 * Makefile.rtl: Handle vxworks7r2 in x86_64 and x86 vxworks7.
2081
2082 2019-07-08 Dmitriy Anisimkov <anisimko@adacore.com>
2083
2084 * Makefile.rtl: Use g-sercom__linux.adb for all linuxes.
2085
2086 2019-07-08 Yannick Moy <moy@adacore.com>
2087
2088 * expander.adb (Expand): Do not reset Analyzed flag always.
2089 * sem_eval.adb (Fold_Ureal): Mark node as analyzed.
2090
2091 2019-07-08 Ed Schonberg <schonberg@adacore.com>
2092
2093 * exp_ch9.adb (Expand_N_Timed_Entry_Call): Do not insert twice
2094 the assignment statement that computes the delay value, to
2095 prevent improper tree sharing when the value is a type
2096 conversion and Float_Overflow checks are enabled.
2097
2098 2019-07-08 Hristian Kirtchev <kirtchev@adacore.com>
2099
2100 * bindo.adb: Update the section on terminology to include new
2101 concepts. Update the section on switches to include new
2102 entries.
2103 * bindo.ads: Add type Precedence_Kind.
2104 * bindo-builders.adb: Add with and use clauses for Debug and
2105 Bindo.Validators. Add use clauses for
2106 Bindo.Validators.Invocation_Graph_Validators and
2107 Bindo.Validators.Library_Graph_Validators.
2108 (Build_Invocation_Graph): Validate the graph immediately after
2109 it was built.
2110 (Build_Library_Graph): Update the parameter profile. The
2111 creation of the graph is now elaboration model-agnostic.
2112 Validate the graph immediately after it was built.
2113 (Create_With_Edge): Create regular with edges for Elaborate and
2114 Elaborate_All edges when the appropriate debug switches are in
2115 effect.
2116 * bindo-builders.ads (Build_Library_Graph): Update the parameter
2117 profile.
2118 * bindo-diagnostics.adb (Diagnose_Cycle): Track the presence of
2119 an Elaborate_All edge throughout the inspection of the cycle's
2120 edges.
2121 (Output_Dynamic_Model_Suggestions): Output the suggestion only
2122 when the cycle contains at least one weak edge where the
2123 successor was statically elaborated.
2124 (Output_Elaborate_Body_Transition, Output_Forced_Transition,
2125 Output_With_Transition): Update the assertions.
2126 * bindo-elaborators.adb: Remove use clauses for
2127 Bindo.Validators.Invocation_Graph_Validators and
2128 Bindo.Validators.Library_Graph_Validators. Remove strings
2129 Add_To_All_Candidates_Msg and Add_To_Comp_Candidates_Msg.
2130 Remove type String_Ptr.
2131 (Add_Vertex, Add_Vertex_If_Elaborable, Create_All_Candidates_Set
2132 Create_Component_Candidates_Set): Remove.
2133 (Create_Component_Vertex_Sets, Create_Vertex_Sets): New routine.
2134 (Elaborate_Component): Update the parameter profile and the
2135 comment on usage. Reimplement the elaboration of a component.
2136 The algorithm will now attempt to elaborate as many vertices
2137 possible. If this is not possible, and a weakly elaborable
2138 vertex is available use unit was compiled using the dynamic
2139 model, the algorithm will elaborate it.
2140 (Elaborate_Library_Graph): Reimplement the elaboration of the
2141 graph. The algorithm will now attempt to elaborate as many
2142 vertices along with their components as possible. If this is not
2143 possible, and a weakly elaborable vertex is available use unit
2144 was compiled using the dynamic model, the algorithm will
2145 elaborate it along with its component.
2146 (Elaborate_Units): Merge with the functionality of
2147 Elaborate_Units_Common.
2148 (Elaborate_Units_Common, Elaborate_Units_Dynamic,
2149 Elaborate_Units_Static): Remove.
2150 (Elaborate_Vertex): Update the parameter profile and the comment
2151 on usage. Reimplemented.
2152 (Find_Best_Candidate): Remove.
2153 (Find_Best_Elaborable_Vertex, Find_Best_Vertex,
2154 Find_Best_Weakly_Elaborable_Vertex, Has_Elaborable_Body,
2155 Insert_Elaborable_Successor, Insert_Vertex): New routines.
2156 (Is_Better_Candidate): Remove.
2157 (Is_Better_Elaborable_Vertex,
2158 Is_Better_Weakly_Elaborable_Vertex,
2159 Is_Suitable_Elaborable_Vertex,
2160 Is_Suitable_Weakly_Elaborable_Vertex): New routines.
2161 (Trace_Candidate_Vertices): Remove.
2162 (Trace_Component): Output the number of strong and weak
2163 predecessors.
2164 (Trace_Unelaborated_Vertices): Remove.
2165 (Trace_Vertex): Output the number of strong and weak
2166 predecessors.
2167 (Trace_Vertices): New routine.
2168 (Update_Successor, Update_Successors): Update the parameter
2169 profile and the comment on usage.
2170 * bindo-graphs.adb: Remove type Precedence_Kind.
2171 (Add_Edge_With_Return): Update the increment of pending
2172 predecessors.
2173 (Add_Vertex): Provide default values for strong and weak
2174 predecessors.
2175 (Complementary_Vertex): Move the initial declaration to the
2176 spec. Update the parameter profile and the comment on usage.
2177 (Contains_Weak_Static_Successor): New routine.
2178 (Create): Update the parameter profile. The creation of the
2179 graph is now elaboration model-agnostic.
2180 (Decrement_Pending_Predecessors): Update the parameter profile
2181 and the comment on usage. Reimplemented.
2182 (Delete_Edge): Update the decrement of pending predecesors.
2183 (Has_Elaborate_Body): Do not treat a vertex as being subject to
2184 Elaborate_Body when a debug switch is in effect.
2185 (Increment_Pending_Predecessors): Update the parameter profile
2186 and the comment on usage. Reimplemented.
2187 (Is_Elaborable_Component): Reimplemented.
2188 (Is_Elaborable_Vertex): Move the initial declaration to the
2189 spec. Reimplemented.
2190 (Is_Elaborate_Body_Pair): New routine.
2191 (Is_Dynamically_Elaborated): Update the parameter profile.
2192 Reimplemented.
2193 (Is_Weakly_Elaborable_Vertex): New routine.
2194 (Pending_Predecessors): Removed.
2195 (Pending_Predecessors_For_Elaboration,
2196 Pending_Strong_Predecessors, Pending_Weak_Predecessors,
2197 Update_Pending_Predecessors): New routines.
2198 (Update_Pending_Predecessors_Of_Components): Update the
2199 increment of pending predecessors.
2200 * bindo-graphs.ads: Update the components of type
2201 Component_Attributes. Update the components of type
2202 Library_Graph_Attributes. Update the components of type
2203 Library_Graph_Vertex_Attributes. Update the initialization of
2204 No_Component_Attributes. Update the initialization of
2205 No_Library_Graph_Vertex_Attributes.
2206 (Complementary_Vertex, Contains_Weak_Static_Successor): New
2207 routines.
2208 (Create): Update the parameter profile and the comment on usage.
2209 (Decrement_Pending_Predecessors, Is_Dynamically_Elaborated):
2210 Update the parameter profile and the comment on usage.
2211 (Is_Elaborate_Body_Pair, Is_Weakly_Elaborable_Vertex): New
2212 routines.
2213 (Pending_Predecessors): Removed.
2214 (Pending_Predecessors_For_Elaboration,
2215 Pending_Strong_Predecessors, Pending_Weak_Predecessors): New
2216 routines.
2217 * bindo-writers.adb (Write_Components): Moved from the spec.
2218 (Write_Component): Output the strong and weak predecessors.
2219 (Write_Library_Graph): Output the components as part of the
2220 graph.
2221 (Write_Library_Graph_Vertex): Output the strong and weak
2222 predecessors.
2223 * bindo-writers.ads (Write_Components): Moved to the body.
2224 * debug.adb: Add and document new GNATbind switches -d_a, -d_b,
2225 -d_e.
2226 * bindo-validators.adb: Minor reformattings.
2227
2228 2019-07-08 Bob Duff <duff@adacore.com>
2229
2230 * libgnat/g-sercom.ads, libgnat/g-sercom__linux.adb (Data_Rate):
2231 Support additional data rates.
2232
2233 2019-07-08 Olivier Hainque <hainque@adacore.com>
2234
2235 * gcc-interface/trans.c (Compilation_Unit_to_gnu): Don't request
2236 DECL_ARTIFICIAL_P on elab proc declarations.
2237
2238 2019-07-08 Eric Botcazou <ebotcazou@adacore.com>
2239
2240 * repinfo.adb (List_Record_Info): Declare Incomplete_Layout and
2241 Not_In_Extended_Main local exceptions.
2242 (List_Structural_Record_Layout): For an extension, raise the
2243 former if the parent subtype has not been built and the latter
2244 if it is not declared in the main source unit. Fall back to the
2245 flat layout if either exception has been raised.
2246
2247 2019-07-08 Ed Schonberg <schonberg@adacore.com>
2248
2249 * libgnat/a-strfix.adb (Delete): The RM describes the semantics
2250 of Delete as equivalent to that of Replace_String with a null
2251 argument. As a result, deleting a null string that starts past
2252 the end of its argument is a noop and must not raise
2253 Index_Error.
2254
2255 2019-07-08 Javier Miranda <miranda@adacore.com>
2256
2257 * exp_disp.adb (Register_Primitive): When registering a
2258 primitive in the secondary dispatch table, handle primitive
2259 inherited through several levels of type derivation (required to
2260 properly handle inherited 'null' primitive).
2261
2262 2019-07-08 Bob Duff <duff@adacore.com>
2263
2264 * doc/gnat_ugn/gnat_utility_programs.rst: Document handling of
2265 preprocessor directives in GNATpp.
2266
2267 2019-07-08 Javier Miranda <miranda@adacore.com>
2268
2269 * gnat1drv.adb (Post_Compilation_Validation_Checks:
2270 Validate_Compile_Time_Warning_Errors is now located in sem_prag
2271 (instead of sem_ch13).
2272 * sem_ch13.ads (Validate_Compile_Time_Warning_Error,
2273 Validate_Compile_Time_Warning_Errors): Move to sem_prag.
2274 * sem_ch13.adb
2275 (Compile_Time_Warnings_Errors): Move to sem_prag.
2276 (Initialize): Remove initialization of table
2277 Compile_Time_Warning_Errors.
2278 (Validate_Compile_Time_Warning_Error,
2279 Validate_Compile_Time_Warning_Errors): Move to sem_prag.
2280 * sem_prag.ads (Validate_Compile_Time_Warning_Errors): New
2281 procedure.
2282 * sem_prag.adb (Initialize): Initialize table
2283 Compile_Time_Warning_Errors.
2284
2285 2019-07-08 Ed Schonberg <schonberg@adacore.com>
2286
2287 * sem_ch13.adb (Analyze_Aspect_Specifications): For a
2288 pre/postcondition of a generic subprogram declaration, do not
2289 use Relocate_Node on the aspect expression to construct the
2290 corresponding attribute specification, to prevent tree anomalies
2291 when the expression is a call with named actual parameters.
2292
2293 2019-07-08 Javier Miranda <miranda@adacore.com>
2294
2295 * sem_attr.adb (Analyze_Attribute [Attribute_Size]): For pragmas
2296 used to report user defined compile time warning or errors
2297 handle 'Size for types with known static RM size.
2298
2299 2019-07-08 Justin Squirek <squirek@adacore.com>
2300
2301 * exp_imgv.adb (Build_Enumeration_Image_Tables): Default SSO for
2302 the building of image tables.
2303 (Expand_Image_Attribute): Minor cleanup.
2304
2305 2019-07-08 Dmitriy Anisimkov <anisimko@adacore.com>
2306
2307 * libgnat/g-socket.ads, libgnat/g-socket.adb: Improve
2308 documentation.
2309 (Get_Socket_Option, Set_Socket_Option): Remove default value for
2310 the Level formal.
2311
2312 2019-07-08 Ed Schonberg <schonberg@adacore.com>
2313
2314 * sem_ch13.adb (Check_Aspect_At_End_Of_Declarations): For an
2315 unanalized aspect in a generic context that has not been
2316 analyzed yet, if the aspect applies to a type, place the type on
2317 the scope stack to make its components visible, before checking
2318 conformance with the version of the expression analyzed at the
2319 freeze point.
2320
2321 2019-07-05 Justin Squirek <squirek@adacore.com>
2322
2323 * checks.adb (Apply_Accessibility_Check): Add logic to fetch the
2324 function result accessibility level if one is required within
2325 the generated check.
2326 * exp_ch6.adb (Needs_Result_Accessibility_Level): Modify
2327 controlling elsif block to handle more cases such as anonymous
2328 access results and disable checking for coextensions.
2329
2330 2019-07-05 Ed Schonberg <schonberg@adacore.com>
2331
2332 * sem_ch9.adb (Analyze_Accept_Statement): If this is an illegal
2333 accept statement for an enclosing entry abandon analysis to
2334 prevent scope mismatches and potential infinite loops in
2335 compiler.
2336
2337 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2338
2339 * ali.adb (For_Each_Invocation_Construct,
2340 For_Each_Invocation_Relation): New version.
2341 (Scan_ALI): Initialize field Invocation_Graph_Encoding.
2342 (Set_Invocation_Graph_Encoding): Update the setting of the
2343 invocation graph encoding.
2344 * ali.ads: Move field Invocation_Graph_Encoding from Unit_Record
2345 to ALI_Record because the encoding applies to the whole ALI,
2346 rather than one of the units (spec or body) for which the ALI
2347 file was created.
2348 (For_Each_Invocation_Construct, For_Each_Invocation_Relation):
2349 New version.
2350 * bindo.adb: Update the section on switches. Complete the
2351 section of debugging elaboration order issues.
2352 (Find_Elaboration_Order): Prepare the routine for the switch
2353 from the old to the new elaboration order mechanism.
2354 * bindo-diagnostics.adb (Find_And_Output_Invocation_Paths):
2355 Manage a visited set used by Visit_Vertex.
2356 (Output_All_Cycles_Suggestions,
2357 Output_Dynamic_Model_Suggestions): Clarify the nature of the
2358 suggested switch.
2359 (Output_Elaborate_Body_Transition): Update the diagnostic to
2360 emit a better message.
2361 (Output_Forced_Suggestions, Output_Full_Encoding_Suggestions):
2362 Clarify the nature of the suggested switch.
2363 (Visit_Vertex): Update the parameter profile to add a set of
2364 invokers visited during the transition. This set prevents
2365 infinite exploration of the graph in case the invocations are
2366 recursive.
2367 * bindo-elaborators.adb: Add a use clause for
2368 Bindo.Writers.Dependency_Writers.
2369 (Elaborate_Units_Common): Output the library graph after it has
2370 been augmented with invocation edges. Output just the components
2371 instead of outputting the whole library graph again.
2372 (Elaborate_Units_Dynamic, Elaborate_Units_Static): Output the
2373 dependencies as expressed in the library graph.
2374 * bindo-units.adb (Invocation_Graph_Encoding): Update the
2375 extraction of the invocation graph encoding.
2376 * bindo-writers.adb: Add with and use clauses for Binderr and
2377 Butil.
2378 (palgc, plgc): New debug routine.
2379 (Write_Components): Moved to the spec. Add a header for the
2380 output.
2381 (Write_Dependencies, Write_Dependencies_Of_Vertex,
2382 Write_Dependency_Edge): New routine.
2383 (Write_Elaboration_Order): Update the logic to follow the format
2384 of Binde's order output.
2385 (Write_Library_Graph): Do not output the components every time
2386 the graph is written.
2387 (Write_Unit): Output the invocation graph encoding of the unit.
2388 Output the invocation constructs and relations for the unit
2389 only.
2390 * bindo-writers.ads (Write_Components): Moved from the body.
2391 (Write_Dependencies): New routine.
2392 * bindusg.adb: Prepare the routine for the switch from the old
2393 to the new elaboration order mechanism.
2394 * debug.adb: Binder switch -d_O is now not associated with any
2395 functionality.
2396 * einfo.adb (Is_Elaboration_Target): The attribute applies to
2397 packages, as specified by the comment on the attribute usage.
2398 * opt.ads: Add a global flag which controls the choice between
2399 the new and the legacy elaboration order mechanism.
2400 * sem_elab.adb: Add Package_Target to type Target_Kind.
2401 (Build_Elaborate_Body_Procedure, Build_Elaborate_Procedure,
2402 Build_Elaborate_Spec_Procedure, Check_Elaboration_Scenarios,
2403 Check_SPARK_Model_In_Effect): Use Main_Unit_Entity to obtain the
2404 entity of the main unit.
2405 (Create_Package_Rep): New routine.
2406 (Create_Target_Rep): Add processing for packages.
2407 (Declaration_Placement_Of_Node, Has_Prior_Elaboration): Use
2408 Main_Unit_Entity to obtain the entity of the main
2409 unit.
2410 (Invocation_Graph_Recording_OK): Prepare the routine for the
2411 switch from the old to the new elaboration order mechanism.
2412 (Main_Unit_Entity): New routine.
2413 (Meet_Elaboration_Requirement,
2414 Process_Conditional_ABE_Variable_Reference): Use
2415 Main_Unit_Entity to obtain the entity of the main unit.
2416 (Process_Invocation_Instantiation): New routine.
2417 (Process_Invocation_Scenario): Add processing for
2418 instantiations.
2419 * switch-b.adb (Scan_Binder_Switches): Prepare the routine for
2420 the switch from the old to the new elaboration order mechanism.
2421
2422 2019-07-05 Joffrey Huguet <huguet@adacore.com>
2423
2424 * libgnat/a-textio.adb: Add abstract state refinment.
2425 * libgnat/a-textio.ads: Add File_System abstract state. Add
2426 global contracts, contract cases, preconditions and
2427 postconditions to procedures and functions.
2428 (Set_Input, Set_Output, Set_Error, Standard_Input,
2429 Standard_Output, Standard_Error, Current_Input, Current_Output,
2430 Current_Error): Turn SPARK_Mode off.
2431 (Get_Line): Turn SPARK_Mode off on Get_Line functions.
2432 * libgnat/a-tideio.ads, libgnat/a-tienio.ads,
2433 libgnat/a-tifiio.ads, libgnat/a-tiflio.ads,
2434 libgnat/a-tiinio.ads, libgnat/a-timoio.ads: Add global
2435 contracts, contract cases, preconditions and postconditions to
2436 procedures and functions.
2437
2438 2019-07-05 Arnaud Charlet <charlet@adacore.com>
2439
2440 * doc/gnat_ugn/platform_specific_information.rst: Refresh doc on
2441 installing from the command line on Windows. Remove obsolete
2442 part.
2443 * gnat_ugn.texi: Regenerate.
2444
2445 2019-07-05 Vasiliy Fofanov <fofanov@adacore.com>
2446
2447 * libgnat/a-wichha.ads (Is_Alphanumeric): Replace comment with
2448 the correct one. Also capitalize references to False
2449 throughout.
2450
2451 2019-07-05 Eric Botcazou <ebotcazou@adacore.com>
2452
2453 * exp_ch4.adb (Expand_N_Indexed_Component): Do not expand actual
2454 parameters of function calls here either.
2455
2456 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2457
2458 * bindo-units.adb, checks.adb, exp_attr.adb, exp_ch3.adb,
2459 exp_ch4.adb, exp_pakd.adb, lib-writ.adb, libgnat/g-traceb.adb,
2460 libgnat/g-traceb.ads, libgnat/s-stratt.ads, sem_aux.ads,
2461 sem_util.adb: Minor reformatting.
2462
2463 2019-07-05 Ed Schonberg <schonberg@adacore.com>
2464
2465 * sem_ch13.adb (Build_Predicate_Functions): If a subtype that
2466 carries a static predicate aspect is frozen immediately after
2467 its declaration, ensure that the generated function body created
2468 for predicate checking is inserted after the corresponding
2469 subprogram declaration, which is created at the point the
2470 declaration is elaborated.
2471
2472 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2473
2474 * exp_ch7.adb (Cleanup_Record): Use the underlying type when
2475 checking for components with tasks.
2476
2477 2019-07-05 Arnaud Charlet <charlet@adacore.com>
2478
2479 * libgnarl/s-osinte__linux.ads: Link with -lrt before -lpthread.
2480
2481 2019-07-05 Ed Schonberg <schonberg@adacore.com>
2482
2483 * exp_pakd.adb (Expand_Bit_Packed_Element_Set): Add explicit
2484 range checks when the index type of the bit-packed array is an
2485 enumeration type with a non-standard representation,
2486
2487 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2488
2489 * sem_res.adb (Is_Control_Flow_Statement): Delay statements
2490 contain an expression, which in turn may have side effects and
2491 affect the infinite recursion. As a result, delay statements
2492 should not be treated specially.
2493
2494 2019-07-05 Arnaud Charlet <charlet@adacore.com>
2495
2496 * libgnarl/s-linux.ads, libgnarl/s-linux__alpha.ads,
2497 libgnarl/s-linux__android.ads, libgnarl/s-linux__hppa.ads,
2498 libgnarl/s-linux__mips.ads, libgnarl/s-linux__riscv.ads,
2499 libgnarl/s-linux__sparc.ads: Fix typos in comments.
2500
2501 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2502
2503 * sem_res.adb (Check_Infinite_Recursion): Reimplemented.
2504 (Enclosing_Declaration_Or_Statement,
2505 Invoked_With_Different_Arguments, Is_Conditional_Statement,
2506 Is_Control_Flow_Statement, Is_Immediately_Within_Body,
2507 Is_Raise_Idiom, Is_Raise_Statement, Is_Sole_Statement,
2508 Preceded_By_Control_Flow_Statement,
2509 Within_Conditional_Statement): New routines.
2510
2511 2019-07-05 Javier Miranda <miranda@adacore.com>
2512
2513 * exp_ch4.adb (Expand_N_Type_Conversion): Do not apply an
2514 accessibility check when the conversion is an access to
2515 class-wide interface type and it is an actual parameter.
2516 * exp_ch6.adb (Expand_Call_Helper): Add documentation on the
2517 accessibility level of an anonymous allocator defining the value
2518 of an access parameter.
2519 * sem_util.ads, sem_util.adb (Dynamic_Accessibility_Level): Add
2520 support for an anonymous allocator whose type is that of a
2521 stand-alone object of an anonymous access to object type.
2522
2523 2019-07-05 Piotr Trojanek <trojanek@adacore.com>
2524
2525 * einfo.ads, sem_res.adb: Typo fixes in comments.
2526
2527 2019-07-05 Bob Duff <duff@adacore.com>
2528
2529 * exp_ch6.adb (Is_Build_In_Place_Function): Narrow the check for
2530 Has_Foreign_Convention to the imported case only. If a
2531 build-in-place function is exported, and called from Ada code,
2532 build-in-place protocols should be used.
2533
2534 2019-07-05 Ed Schonberg <schonberg@adacore.com>
2535
2536 * sem_util.adb (Encloing_Subprogram): If Enclosing_Dynamic_Scope
2537 is a loop, continue climbing the scope stack to find the
2538 enclosing subprogram.
2539 (Gather_Components): Handle properly a choice in a record
2540 aggregate that is given by a subtype with a static predicate.
2541
2542 2019-07-05 Javier Miranda <miranda@adacore.com>
2543
2544 * debug.adb (-gnatd.K): Leave available this switch.
2545 * contracts.adb (Build_And_Analyze_Contract_Only_Subprograms):
2546 Remove.
2547 * scil_ll.ads, scil_ll.adb (Contract_Only_Body_Flag,
2548 Contract_Only_Body_Nodes, Get_Contract_Only_Body,
2549 Is_Contract_Only_Body, Set_Contract_Only_Body): Remove.
2550
2551 2019-07-05 Pierre-Marie de Rodat <derodat@adacore.com>
2552
2553 * libgnat/a-strunb.ads: Import documentation from the RM
2554
2555 2019-07-05 Pierre-Marie de Rodat <derodat@adacore.com>
2556
2557 * libgnat/a-strfix.ads: Import documentation from the RM
2558
2559 2019-07-05 Yannick Moy <moy@adacore.com>
2560
2561 * adabkend.adb (Scan_Back_End_Switches): Accept -Og and -Ofast
2562 switches.
2563
2564 2019-07-05 Hristian Kirtchev <kirtchev@adacore.com>
2565
2566 * ali.adb: Relocate types Invocation_Construct_Record,
2567 Invocation_Relation_Record, and Invocation_Signature_Record to
2568 the body of ALI. Relocate tables Invocation_Constructs,
2569 Invocation_Relations, and Invocation_Signatures to the body of
2570 ALI. Remove type Body_Placement_Codes. Add new types
2571 Declaration_Placement_Codes, and
2572 Invocation_Graph_Encoding_Codes. Update the literals of type
2573 Invocation_Graph_Line_Codes.
2574 (Add_Invocation_Construct): Update the parameter profile. Add an
2575 invocation construct built from all attributes provided.
2576 (Add_Invocation_Relation): Update the parameter profile. Add an
2577 invocation relation built from all attributes provided.
2578 (Body_Placement): New routine.
2579 (Body_Placement_Kind_To_Code, Code_To_Body_Placement_Kind):
2580 Removed.
2581 (Code_To_Declaration_Placement_Kind,
2582 Code_To_Invocation_Graph_Encoding_Kind, Column,
2583 Declaration_Placement_Kind_To_Code, Extra,
2584 For_Each_Invocation_Construct, For_Each_Invocation_Relation,
2585 Invocation_Graph_Encoding,
2586 Invocation_Graph_Encoding_Kind_To_Code, Invoker, Kind, Line,
2587 Locations, Name): New routine.
2588 (Scan_Invocation_Construct_Line): Reimplement the scanning
2589 mechanism.
2590 (Scan_Invocation_Graph_Attributes_Line): New routine.
2591 (Scan_Invocation_Graph_Line): Use a case statement to dispatch.
2592 (Scan_Invocation_Relation_Line): Reimplement the scanning
2593 mechanism.
2594 (Scope): New routine.
2595 (Set_Invocation_Graph_Encoding, Signature, Spec_Placement,
2596 Target): New routine.
2597 * ali.ads: Add new type Invocation_Graph_Encoding_Kind. Add
2598 component Invocation_Graph_Encoding to type Unit_Record.
2599 Relocate various types and data structures to the body of ALI.
2600 (Add_Invocation_Construct, Add_Invocation_Relation): Update the
2601 parameter profile.
2602 (Body_Placement): New routine.
2603 (Body_Placement_Kind_To_Code, Code_To_Body_Placement_Kind):
2604 Removed.
2605 (Code_To_Declaration_Placement_Kind,
2606 Code_To_Invocation_Graph_Encoding_Kind, Column,
2607 Declaration_Placement_Kind_To_Code, Extra,
2608 For_Each_Invocation_Construct, For_Each_Invocation_Relation,
2609 Invocation_Graph_Encoding,
2610 Invocation_Graph_Encoding_Kind_To_Code, Invoker, Kind, Line,
2611 Locations, Name, Scope, Set_Invocation_Graph_Encoding,
2612 Signature, Spec_Placement, Target): New routine.
2613 * bindo.adb: Add with clause for Binde. Add with and use
2614 clauses for Debug. Update the documentation. Add new switches.
2615 (Find_Elaboration_Order): Dispatch to the proper elaboration
2616 mechanism.
2617 * bindo-augmentors.adb:
2618 Remove with and use clauses for GNAT and GNAT.Sets. Remove
2619 membership set VS. Update the parameter profiles of most
2620 routines to use better parameter names. Update the
2621 implementation of most routine to use the new parameter names.
2622 Remove various redundant assertions.
2623 * bindo-builders.adb: Use better names for instantiated data
2624 structures. Update all references to these names. Update the
2625 parameter profiles of most routines to use better parameter
2626 names. Update the implementation of most routine to use the new
2627 parameter names.
2628 (Build_Library_Graph): Update the parameter profile. Update the
2629 call to Create.
2630 (Create_Vertex): Reimplemented.
2631 (Declaration_Placement_Vertex): New routine.
2632 * bindo-builders.ads (Build_Library_Graph): Update the parameter
2633 profile and comment on usage.
2634 * bindo-diagnostics.adb: Almost a new unit.
2635 * bindo-diagnostics.ads: Add a use clause for
2636 Bindo.Graphs.Invocation_Graphs. Remove package
2637 Cycle_Diagnostics.
2638 (Diagnose_Circularities): New routine.
2639 * bindo-elaborators.adb: Remove the with and use clauses for
2640 Binderr and GNAT.Sets. Remove the use clause for
2641 Bindo.Diagnostics.Cycle_Diagnostics. Remove membership set VS.
2642 Update the parameter profiles of most routines to use better
2643 parameter names. Update the implementation of most routine to
2644 use the new parameter names. (Elaborate_Units_Common): Update
2645 the parameter profile. Pass an infication to the library graph
2646 builder whether the dynamic model is in effect.
2647 (Elaborate_Units_Dynamic, Elaborate_Units_Static): Use
2648 Diagnose_Circularities to provide diagnostics.
2649 (Update_Successor): Use routine In_Same_Component to determine
2650 whether the predecessor and successor reside in different
2651 components.
2652 * bindo-graphs.adb: Add with and use clauses for Butil, Debug,
2653 Output, and Bindo.Writers. Remove with and use clauses for
2654 GNAT.Lists. Update the parameter profiles of most routines to
2655 use better parameter names. Update the implementation of most
2656 routine to use the new parameter names. Remove various
2657 redundant assertions. Remove doubly linked list EL. Add new
2658 type Precedence_Kind.
2659 (Add_Cycle): New routine.
2660 (Add_Vertex): Update the parameter profile. Update the creation
2661 of vertex attributes.
2662 (Add_Vertex_And_Complement, Body_Vertex, Column,
2663 Complementary_Vertex, Copy_Cycle_Path, Cycle_Kind_Of): New
2664 routines.
2665 (Destroy_Invocation_Graph_Edge, Destroy_Library_Graph_Cycle,
2666 Destroy_Library_Graph_Edge, Extra, File_Name,
2667 Find_All_Cycles_Through_Vertex, Find_All_Cycles_With_Edge,
2668 Find_Cycles, Find_First_Lower_Precedence_Cycle,
2669 Get_LGC_Attributes, Has_Next, Hash_Library_Graph_Cycle,
2670 Hash_Library_Graph_Cycle_Attributes, Highest_Precedence_Cycle,
2671 Highest_Precedence_Edge, In_Same_Component, Insert_And_Sort,
2672 Invocation_Edge_Count, Invocation_Graph_Encoding,
2673 Is_Cycle_Initiating_Edge, Is_Cyclic_Edge,
2674 Is_Cyclic_Elaborate_All_Edge, Is_Cyclic_Elaborate_Body_Edge,
2675 Is_Cyclic_Elaborate_Edge, Is_Cyclic_Forced_Edge,
2676 Is_Cyclic_Invocation_Edge, Is_Cyclic_With_Edge,
2677 Is_Dynamically_Elaborated, Is_Elaborate_All_Edge,
2678 Is_Elaborate_Body_Edge, Is_Elaborate_Edge: New routines.
2679 (Is_Existing_Predecessor_Successor_Relation): Removed.
2680 (Is_Forced_Edge, Is_Invocation_Edge, Is_Recorded_Cycle,
2681 Is_Recorded_Edge, Is_With_Edge, Iterate_Edges_Of_Cycle, Kind,
2682 Length): New routine.
2683 (Lib_Vertex): Removed.
2684 (Line, Links_Vertices_In_Same_Component,
2685 Maximum_Invocation_Edge_Count, Next, Normalize_And_Add_Cycle,
2686 Normalize_Cycle_Path, Number_Of_Cycles, Path, Precedence,
2687 Remove_Vertex_And_Complement, Sequence_Next_Cycle): New routines.
2688 (Sequence_Next_IGE_Id): Renamed to Sequence_Next_Edge.
2689 (Sequence_Next_IGV_Id): Renamed to Sequence_Next_Vertex.
2690 (Sequence_Next_LGE_Id): Renamed to Sequence_Next_Edge.
2691 (Sequence_Next_LGV_Id): Renamed to Sequence_Next_Vertex.
2692 (Set_Is_Existing_Predecessor_Successor_Relation): Removed.
2693 (Set_Is_Recorded_Cycle, Set_Is_Recorded_Edge,
2694 Set_LGC_Attributes, Spec_Vertex, Trace_Cycle, Trace_Edge,
2695 Trace_Eol, Trace_Vertex): New routines.
2696 * bindo-graphs.ads: Add with and use clauses for Types and
2697 GNAT.Lists. Update the parameter profiles of most routines to
2698 use better parameter names. Update the implementation of most
2699 routine to use the new parameter names. Add the new
2700 instantiated data structures IGE_Lists, IGV_Sets, LGC_Lists,
2701 LGE_Lists, LGE_Sets, LGV_Sets, and RC_Sets. Add new type
2702 Library_Graph_Cycle_Id along with an empty and initial value.
2703 Remove component Lib_Vertex and add new components Body_Vertex
2704 and Spec_Vertex to type Invocation_Graph_Vertex_Attributes. Add
2705 new type Library_Graph_Cycle_Kind. Add new iterators
2706 All_Cycle_Iterator and Edges_Of_Cycle_Iterator. Add new type
2707 Library_Graph_Cycle_Attributes. Add new components
2708 Cycle_Attributes, Cycles, and Dynamically_Elaborated to type
2709 Library_Graph_Attributes.
2710 (Body_Vertex, Column, Destroy_Invocation_Graph_Edge,
2711 Destroy_Library_Graph_Cycle_Attributes,
2712 Destroy_Library_Graph_Edge, Extra, File_Name, Find_Cycles,
2713 Has_Elaborate_All_Cycle, Has_Next, Hash_Library_Graph_Cycle,
2714 Hash_Library_Graph_Cycle_Attributes, Highest_Precedence_Cycle,
2715 In_Same_Component, Invocation_Edge_Count,
2716 Invocation_Graph_Encoding, Is_Dynamically_Elaborated,
2717 Is_Elaborate_All_Edge, Is_Elaborate_Body_Edge,
2718 Is_Elaborate_Edge, Is_Forced_Edge, Is_Invocation_Edge,
2719 Is_With_Edge, Iterate_All_Cycles, Iterate_Edges_Of_Cycle, Kind):
2720 New routines.
2721 (Length, Lib_Vertex, (Line, Next, Number_Of_Cycles, Present,
2722 Same_Library_Graph_Cycle_Attributes, Spec_Vertex): New routines.
2723 * bindo-units.adb (File_Name, Invocation_Graph_Encoding): New
2724 routines.
2725 * bindo-units.ads: Add new instantiated data structure
2726 Unit_Sets.
2727 (File_Name, Invocation_Graph_Encoding): New routine.
2728 * bindo-validators.adb: Remove with and use clauses for GNAT and
2729 GNAT.Sets. Remove membership set US. Update the parameter
2730 profiles of most routines to use better parameter names. Update
2731 the implementation of most routine to use the new parameter
2732 names.
2733 (Validate_Cycle, Validate_Cycle_Path, Validate_Cycles,
2734 Validate_Invocation_Graph_Vertex): Remove the validation of
2735 component Lib_Vertex. Add the validation of components
2736 Body_Vertex and Spec_Vertex.
2737 (Write_Error): New routine.
2738 * bindo-validators.ads (Validate_Cycles): New routine.
2739 * bindo-writers.adb: Update the parameter profiles of most
2740 routines to use better parameter names. Update the
2741 implementation of most routine to use the new parameter names.
2742 (Write_Cycle, Write_Cyclic_Edge, Write_Cycles): New routines.
2743 (Write_Invocation_Graph_Vertex): Remove the output of component
2744 Lib_Vertex. Add the output of components Body_Vertex and
2745 Spec_Vertex.
2746 * bindo-writers.ads (Write_Cycles): New routine.
2747 * debug.adb: Use binder switches -d_C and -d_P, add
2748 documentation on their usage.
2749 * gnatbind.adb: Remove with and use clauses for Binde. Delegate
2750 the choice of elaboration mechanism to Bindo.
2751 * lib-writ.adb (Column, Extra, Invoker, Kind, Line, Locations,
2752 Name, Placement, Scope, Signature, Target): Removed.
2753 (Write_Invocation_Graph): Moved at the top level.
2754 (Write_Invocation_Graph_Attributes): New routine.
2755 (Write_Invocation_Relation, Write_Invocation_Signature): Moved
2756 at the top level.
2757 * lib-writ.ads: Add a documentation section on invocation graph
2758 attributes.
2759 * sem_elab.adb (Body_Placement_Of): New routine.
2760 (Declare_Invocation_Construct): Update the call to
2761 Add_Invocation_Construct.
2762 (Declaration_Placement_Of_Node): New routine.
2763 (Get_Invocation_Attributes): Correct the retrieval of the
2764 enclosing subprogram where the postcondition procedure lives.
2765 (Placement_Of, Placement_Of_Node): Removed.
2766 (Record_Invocation_Graph): Record the encoding format used.
2767 (Record_Invocation_Graph_Encoding): New routine.
2768 (Record_Invocation_Relation): Update the call to
2769 Add_Invocation_Relation.
2770 (Spec_Placement_Of): Removed.
2771 * libgnat/g-lists.ads, libgnat/g-lists.adb (Equal): New routine.
2772
2773 2019-07-05 Ed Schonberg <schonberg@adacore.com>
2774
2775 * checks.adb (Apply_Predicate_Check): Except within the
2776 subprogram body that defines the formal, do not apply predicate
2777 check on a formal IN parameter: such a check is redundant and
2778 its expansion can lead to out-of-scope references when it is
2779 originates in a function call in a precondition,
2780
2781 2019-07-05 Yannick Moy <moy@adacore.com>
2782
2783 * sem_res.adb (Resolve_Call): Cannot inline in quantified
2784 expressions.
2785 * sem_util.adb, sem_util.ads (In_Quantified_Expression): New
2786 function.
2787
2788 2019-07-05 Bob Duff <duff@adacore.com>
2789
2790 * doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
2791 Fix typo.
2792 * gnat_rm.texi: Regenerate.
2793
2794 2019-07-05 Bob Duff <duff@adacore.com>
2795
2796 * exp_attr.adb (Input): Take the No_Stream_Optimizations
2797 restriction into account.
2798
2799 2019-07-05 Claire Dross <dross@adacore.com>
2800
2801 * libgnat/a-cofove.ads, libgnat/a-cofove.adb: Definite formal
2802 vectors are now always bounded so that they do not need to be
2803 limited anymore.
2804
2805 2019-07-05 Dmitriy Anisimkov <anisimko@adacore.com>
2806
2807 * libgnat/g-traceb.ads, libgnat/g-traceb.adb (Call_Chain): New
2808 function.
2809
2810 2019-07-04 James Clarke <jrtc27@debian.org>
2811
2812 * libgnarl/s-osinte__kfreebsd-gnu.ads (clockid_t): Make type
2813 definition public.
2814 (CLOCK_REALTIME): Make value public.
2815
2816 2019-07-04 Javier Miranda <miranda@adacore.com>
2817
2818 * exp_tss.adb (Init_Proc): Adding missing support for access to
2819 subprograms and access to protected subprograms of non-default
2820 C++ constructors.
2821
2822 2019-07-04 Eric Botcazou <ebotcazou@adacore.com>
2823
2824 * gnat1drv.adb (Adjust_Global_Switches): Use proper interface to
2825 set the validity settings in CodePeer mode.
2826 * par-load.adb (Load): Remove all code dealing with validity
2827 settings.
2828 * validsw.ads (Validity_Check_Copies): Alphabetize.
2829 * validsw.adb (Reset_Validity_Check_Options): Set all options to
2830 off.
2831 (Save_Validity_Check_Options): Save all options.
2832
2833 2019-07-04 Hristian Kirtchev <kirtchev@adacore.com>
2834
2835 * exp_ch3.adb, exp_ch4.adb, exp_ch4.ads, exp_ch5.adb,
2836 exp_ch7.adb, exp_ch9.adb, exp_ch11.adb, exp_unst.adb,
2837 rtsfind.ads, sem_attr.adb, sem_ch10.adb, sem_ch12.adb,
2838 sem_ch13.adb, sem_dim.adb, sem_disp.adb, xref_lib.adb: Minor
2839 reformatting.
2840
2841 2019-07-04 Joffrey Huguet <huguet@adacore.com>
2842
2843 * libgnarl/a-taside.ads: Add assertion policy to ignore
2844 preconditions.
2845 (Abort_Task, Is_Terminated, Is_Callable): Add preconditions.
2846
2847 2019-07-04 Eric Botcazou <ebotcazou@adacore.com>
2848
2849 * doc/gnat_rm/implementation_defined_pragmas.rst: Fix
2850 capitalization and parenthesis glitches.
2851 * gnat_rm.texi: Regenerate.
2852
2853 2019-07-04 Ed Schonberg <schonberg@adacore.com>
2854
2855 * sem_ch10.adb (Remove_Context_Clauses): Handle properly the
2856 removal of a limited_with_clause which appears in the library
2857 unit oF the main unit, when some other unit in the context has a
2858 regular with_clause on the same unit, to prevent spurious
2859 visibility errors in the subsequent analysis of pending instance
2860 bodies.
2861
2862 2019-07-04 Hristian Kirtchev <kirtchev@adacore.com>
2863
2864 * sem_elab.adb: Add new type Elaboration_Phase_Status along with
2865 a global to keep track of the elaboration phase status.
2866 Initialize all internal data structures to Nil for services
2867 Elaborated_Units, Internal_Representation, and Scenario_Storage.
2868 (Build_Call_Marker): Do not create a call marker when the
2869 elaboration phase is not active.
2870 (Build_Variable_Reference_Marker): Do not create a call marker
2871 when the elaboration phase is not active.
2872 (Check_Elaboration_Scenarios): Destroy all internal structures
2873 when the elaboration phase does not have to run. Do not execute
2874 when the elaboration phase is not active.
2875 (Elaboration_Phase_Active): New routine.
2876 (Finalize_All_Data_Structures): New routine.
2877 (Initialize): Initialize all internal data structures and signal
2878 that the elaboration phase has started.
2879 (Initialize_All_Data_Structures): New routine.
2880 (Initialize_Elaborated_Units): Initialize all internal data
2881 structures.
2882 (Initialize_Internal_Representation): Initialize all internal
2883 data structures.
2884 (Initialize_Scenario_Storage): Initialize all internal data
2885 structures.
2886 (Kill_Elaboration_Scenario): Do not execute when the elaboration
2887 phase is not active.
2888 (Set_Elaboration_Phase): New routine.
2889 (Update_Elaboration_Scenario): Do not execute when the
2890 elaboration phase is not active.
2891
2892 2019-07-04 Gary Dismukes <dismukes@adacore.com>
2893
2894 * sem_ch6.adb (Analyze_Subprogram_Body_Helper): The special
2895 treatment of calling Mask_Unfrozen_Types must also be done in
2896 the case of an Ignored_Ghost_Entity, because Expander_Active is
2897 False in that case.
2898
2899 2019-07-04 Yannick Moy <moy@adacore.com>
2900
2901 * sem_prag.adb (Check_Library_Level_Entity): Update for new rule
2902 on SPARK_Mode.
2903
2904 2019-07-04 Justin Squirek <squirek@adacore.com>
2905
2906 * sem_disp.adb (Check_Controlling_Formals): Obtain the full view
2907 before type comparison.
2908
2909 2019-07-04 Ed Schonberg <schonberg@adacore.com>
2910
2911 * exp_ch4.ads, exp_ch4.adb (Build_Eq_Call): New visible
2912 subprogram, extracted from Expand_Composite_Equality, to handle
2913 properly the composition of equality for variant record types.
2914 * exp_ch3.adb (MAke_Eq_If): Use Build_Eq_Call for each
2915 component, to handle properly the case of a component with a
2916 user-defined equality. Revert to predefined equality if the
2917 user-defined operation is abstract, to maintain compatibility
2918 with older versions,
2919
2920 2019-07-04 Justin Squirek <squirek@adacore.com>
2921
2922 * exp_ch3.adb (Build_Initialization_Call): Fixup
2923 *_skip_null_excluding_check argument to handle new default.
2924 (Init_Formals): Make *_skip_null_excluding_check formal default
2925 to False
2926 * exp_ch4.adb (Expand_N_Allocator): Add comment to note heavy
2927 code duplication
2928
2929 2019-07-04 Bob Duff <duff@adacore.com>
2930
2931 * sem_ch3.adb (Access_Definition): Do not create a master unless
2932 Tasking_Allowed. Otherwise, this fails on restricted runtimes.
2933
2934 2019-07-04 Hristian Kirtchev <kirtchev@adacore.com>
2935
2936 * sem_util.adb (Propagate_DIC_Attributes): Do not propagate the
2937 Default_Initial_Condition attributes to an incomplete type.
2938
2939 2019-07-04 Ed Schonberg <schonberg@adacore.com>
2940
2941 * sem_attr.adb (Check_Array_Type): An array type attribute such
2942 as 'First can be applied to an unconstrained array tyope when
2943 the attribute reference appears within an aspect specification
2944 and the prefix is a current instance, given that the prefix of
2945 the attribute will become a formal of the subprogram that
2946 implements the aspect (typically a predicate check).
2947
2948 2019-07-04 Piotr Trojanek <trojanek@adacore.com>
2949
2950 * sem_util.adb (Yields_Synchronized_Object): Fix typos in
2951 comments.
2952
2953 2019-07-04 Yannick Moy <moy@adacore.com>
2954
2955 * sem_util.adb (Yields_Synchronized_Object): Adapt to new SPARK
2956 rule.
2957
2958 2019-07-04 Yannick Moy <moy@adacore.com>
2959
2960 * sem_spark.adb (Check_Statement): Only check permission of
2961 object in extended return when it is of a deep type.
2962
2963 2019-07-04 Justin Squirek <squirek@adacore.com>
2964
2965 * sem_ch12.adb (Perform_Appropriate_Analysis): Added for
2966 selecting which type of analysis based on wheither the
2967 instantiation is a generic at the library-level. In which case
2968 expansion during analysis.
2969 (Preanalyze_Actuals): Modify calls to Analyze to use the new
2970 routine.
2971
2972 2019-07-04 Ed Schonberg <schonberg@adacore.com>
2973
2974 * exp_unst.adb: Handle conditional expressions.
2975
2976 2019-07-04 Yannick Moy <moy@adacore.com>
2977
2978 * sem_spark.adb (Check_Package_Spec, Check_Package_Body): Only
2979 analyze parts of the code marked in SPARK.
2980
2981 2019-07-04 Hristian Kirtchev <kirtchev@adacore.com>
2982
2983 * erroutc.adb, exp_aggr.adb, inline.adb, opt.adb, sem_ch3.adb:
2984 Minor reformatting.
2985
2986 2019-07-04 Yannick Moy <moy@adacore.com>
2987
2988 * sem_spark.adb (Explanation, Get_Expl): New functions to get
2989 the explanation for a permission mismatch.
2990 (Perm_Error, Perm_Mismatch, Perm_Error_Loop_Exit): Take
2991 explanation into account for issuing a more precise error
2992 message.
2993 (Set_Perm_Prefixes, Set_Perm_Extensions,
2994 Set_Perm_Extensions_Move): Pass suitable argument for the
2995 explanation node.
2996
2997 2019-07-04 Arnaud Charlet <charlet@adacore.com>
2998
2999 * exp_aggr.adb (In_Place_Assign_OK): Moved to top level and add
3000 support for record aggregates.
3001 (Component_Check): Use Is_CCG_Supported_Aggregate instead of a
3002 similar local predicate.
3003 (Convert_To_Assignments): Take advantage of In_Place_Assign_OK
3004 predicate when possible.
3005 (Is_CCG_Supported_Aggregate): Return False for records with
3006 representation clauses and fix the logic for dealing with nested
3007 aggregates.
3008
3009 2019-07-04 Piotr Trojanek <trojanek@adacore.com>
3010
3011 * opt.adb (Set_Config_Switches): Keep assertions policy as
3012 enabled when analysing internal units in GNATprove mode.
3013
3014 2019-07-04 Arnaud Charlet <charlet@adacore.com>
3015
3016 * exp_ch4.adb (Expand_Short_Circuit_Operator): Strip
3017 N_Variable_Reference_Marker when checking for the presence of
3018 actions.
3019
3020 2019-07-04 Arnaud Charlet <charlet@adacore.com>
3021
3022 * exp_aggr.adb (Check_Component): Take into account type
3023 conversions.
3024
3025 2019-07-04 Dmitriy Anisimkov <anisimko@adacore.com>
3026
3027 * doc/gnat_ugn/platform_specific_information.rst: Document
3028 Windows socket timeout particularity.
3029 * gnat_ugn.texi: Regenerate.
3030 * gsocket.h: Include versionhelpers.h.
3031 * socket.c (__gnat_minus_500ms): New function.
3032 * libgnat/g-sothco.ads (Minus_500ms_Windows_Timeout): New
3033 imported function.
3034 * libgnat/g-socket.adb (Set_Socket_Option): Refactor to remove
3035 500ms from the requested timeout only on old Windows version.
3036
3037 2019-07-04 Thomas Quinot <quinot@adacore.com>
3038
3039 * get_scos.adb: Remove bogus, dead code.
3040
3041 2019-07-04 Ed Schonberg <schonberg@adacore.com>
3042
3043 * sem_dim.adb (Analyze_Dimension_Array_Aggregate): If the
3044 component is an entity name, its dimensions are those of its
3045 type.
3046
3047 2019-07-03 Bob Duff <duff@adacore.com>
3048
3049 * doc/gnat_ugn/gnat_utility_programs.rst: Document new flags in
3050 GNATpp.
3051
3052 2019-07-03 Hristian Kirtchev <kirtchev@adacore.com>
3053
3054 * binde.adb: Remove with clause for System.OS_Lib.
3055 (Force_Elab_Order): Refactor the majority of the code in Butil.
3056 Use the new forced units iterator to obtain unit names.
3057 * bindo-builders.adb: Add with and use clauses for Binderr,
3058 Butil, Opt, Output, Types, GNAT, and GNAT.Dynamic_HTables. Add
3059 a hash table which maps units to line number in the forced
3060 elaboration order file.
3061 (Add_Unit): New routine.
3062 (Build_Library_Graph): Create forced edges between pairs of
3063 units listed in the forced elaboration order file.
3064 (Create_Forced_Edge, Create_Forced_Edges, Destroy_Line_Number,
3065 Duplicate_Unit_Error, Hash_Unit, Internal_Unit_Info,
3066 Is_Duplicate_Unit, Missing_Unit_Info): New routines.
3067 * bindo-graphs.adb (Is_Internal_Unit, Is_Predefined_Unit):
3068 Refactor some of the behavior to Bindo-Units.
3069 * bindo-graphs.ads: Enable the enumeration literal for forced
3070 edges.
3071 * bindo-units.adb, bindo-units.ads (Is_Internal_Unit,
3072 Is_Predefined_Unit): New routines.
3073 * butil.adb: Add with and use clauses for Opt, GNAT, and
3074 System.OS_Lib. Add with clause for Unchecked_Deallocation.
3075 (Has_Next, Iterate_Forced_Units, Next, Parse_Next_Unit_Name,
3076 Read_Forced_Elab_Order_File): New routines.
3077 * butil.ads: Add with and use clauses for Types. Add new
3078 iterator over the units listed in the forced elaboration order
3079 file.
3080 (Has_Next, Iterate_Forced_Units, Next): New routine.
3081 * namet.adb, namet.ads (Present): New routine.
3082
3083 2019-07-03 Bob Duff <duff@adacore.com>
3084
3085 * sem_ch3.adb (Access_Definition): The code was creating a
3086 master in the case where the designated type is a class-wide
3087 interface type. Create a master in the noninterface case as
3088 well. That is, create a master for all limited class-wide types.
3089
3090 2019-07-03 Yannick Moy <moy@adacore.com>
3091
3092 * erroutc.adb (Sloc_In_Range): New function to determine whether
3093 the range of a pragma Warnings covers a location, taking
3094 instantiations into account.
3095
3096 2019-07-03 Johannes Kanig <kanig@adacore.com>
3097
3098 * osint.ads, osint.adb (Get_First_Main_File_Name): New routine
3099 to access the first file provided on the command line.
3100
3101 2019-07-03 Ed Schonberg <schonberg@adacore.com>
3102
3103 * inline.adb (Process_Formals_In_Aspects): New procedure within
3104 Expand_Inlined_Call, to perform a replacement of references to
3105 formals that appear in aspect specifications within the body
3106 being inlined.
3107
3108 2019-07-03 Justin Squirek <squirek@adacore.com>
3109
3110 * sem_ch8.adb (Analyze_Object_Renaming): Add call to search for
3111 the appropriate actual subtype of the object renaming being
3112 analyzed.
3113 (Check_Constrained_Object): Minor cleanup.
3114
3115 2019-07-03 Yannick Moy <moy@adacore.com>
3116
3117 * sem_spark.adb (Get_Observed_Or_Borrowed_Expr): New function to
3118 return go through traversal function call.
3119 (Check_Type): Consistently use underlying type.
3120 (Get_Perm): Adapt for case of elaboration code where variables
3121 are not declared in the environment. Remove incorrect handling
3122 of borrow and observe.
3123
3124 2019-07-03 Hristian Kirtchev <kirtchev@adacore.com>
3125
3126 * inline.adb (Build_Return_Object_Formal): New routine.
3127 (Can_Split_Unconstrained_Function): Code clean up.
3128 (Copy_Formals,Copy_Return_Object): New routines.
3129 (Split_Unconstrained_Function): Code clean up and refactoring.
3130
3131 2019-07-03 Gary Dismukes <dismukes@adacore.com>
3132
3133 * bindo-augmentors.adb, bindo-augmentors.ads,
3134 bindo-builders.ads, bindo-elaborators.adb, sem_ch12.adb,
3135 sem_ch13.adb, sem_spark.adb, sinfo.ads: Minor editorial
3136 corrections and reformatting.
3137
3138 2019-07-03 Bob Duff <duff@adacore.com>
3139
3140 * sem_warn.adb (Check_Infinite_Loop_Warning): Avoid the warning
3141 if an Iterator_Specification is present.
3142
3143 2019-07-03 Bob Duff <duff@adacore.com>
3144
3145 * doc/gnat_ugn/gnat_utility_programs.rst: Document default
3146 new-line behavior.
3147
3148 2019-07-03 Hristian Kirtchev <kirtchev@adacore.com>
3149
3150 * ali.adb: Add with and use clauses for GNAT,
3151 GNAT.Dynamic_HTables, and Snames. Add a map from invocation
3152 signature records to invocation signature ids. Add various
3153 encodings of invocation-related attributes. Sort and update
3154 table Known_ALI_Lines.
3155 (Add_Invocation_Construct, Add_Invocation_Relation,
3156 Body_Placement_Kind_To_Code, Code_To_Body_Placement_Kind,
3157 Code_To_Invocation_Construct_Kind, Code_To_Invocation_Kind,
3158 Code_To_Invocation_Graph_Line_Kind, Destroy, Hash): New
3159 routines.
3160 (Initialize_ALI): Sort the initialization sequence. Add
3161 initialization for all invocation-related tables.
3162 (Invocation_Construct_Kind_To_Code,
3163 Invocation_Graph_Line_Kind_To_Code, Invocation_Kind_To_Code,
3164 Invocation_Signature_Of, Present): New routines.
3165 (Scan_ALI): Add the default values for invocation-related ids.
3166 Scan invocation graph lines.
3167 (Scan_Invocation_Graph_Line): New routine.
3168 * ali.ads: Add with clause for GNAT.Dynamic_Tables. Add types
3169 for invocation constructs, relations, and signatures. Add
3170 tables for invocation constructs, relations, and signatures.
3171 Update Unit_Record to capture invocation-related ids. Relocate
3172 table Unit_Id_Tables and subtypes Unit_Id_Table, Unit_Id_Array
3173 from Binde.
3174 (Add_Invocation_Construct, Add_Invocation_Relation,
3175 Body_Placement_Kind_To_Code, Code_To_Body_Placement_Kind,
3176 Code_To_Invocation_Construct_Kind, Code_To_Invocation_Kind,
3177 Code_To_Invocation_Graph_Line_Kind,
3178 Invocation_Construct_Kind_To_Code,
3179 Invocation_Graph_Line_Kind_To_Code, Invocation_Kind_To_Code,
3180 Invocation_Signature_Of, Present): New routines.
3181 * binde.adb: Add with and use clause for Types. Add use clause
3182 for ALI.Unit_Id_Tables;
3183 * binde.ads: Relocate table Unit_Id_Tables and subtypes
3184 Unit_Id_Table, Unit_Id_Array to ALI.
3185 * bindgen.adb: Remove with and use clause for ALI.
3186 * bindgen.ads: Remove with and use clause for Binde. Add with
3187 and use clause for ALI.
3188 * bindo.adb, bindo.ads, bindo-augmentors.adb,
3189 bindo-augmentors.ads, bindo-builders.adb, bindo-builders.ads,
3190 bindo-diagnostics.adb, bindo-diagnostics.ads,
3191 bindo-elaborators.adb, bindo-elaborators.ads, bindo-graphs.adb,
3192 bindo-graphs.ads, bindo-units.adb, bindo-units.ads,
3193 bindo-validators.adb, bindo-validators.ads, bindo-writers.adb,
3194 bindo-writers.ads: New units.
3195 * debug.adb: Use and describe GNAT debug switches -gnatd_F and
3196 -gnatd_G. Add GNATbind debug switches in the ranges dA .. dZ,
3197 d.a .. d.z, d.A .. d.Z, d.1 .. d.9, d_a .. d_z, d_A .. d_Z, and
3198 d_1 .. d_9. Use and describe GNATbind debug switches -d_A,
3199 -d_I, -d_L, -d_N, -d_O, -d_T, and -d_V.
3200 * exp_util.adb, exp_util.ads (Exceptions_OK): Relocate to
3201 Sem_Util.
3202 * gnatbind.adb: Add with and use clause for Bindo. Use the new
3203 Bindo elaboration order only when -d_N is in effect.
3204 * lib-writ.adb
3205 (Column, Extra, Invoker, Kind, Line, Locations, Name, Placement,
3206 Scope, Signature, Target): New routines.
3207 (Write_ALI): Output all invocation-related data.
3208 (Write_Invocation_Graph): New routine.
3209 * lib-writ.ads: Document the invocation graph ALI line.
3210 * namet.adb, namet.ads (Present): New routines.
3211 * sem_ch8.adb (Find_Direct_Name): Capture the status of
3212 elaboration checks and warnings of an identifier.
3213 (Find_Expanded_Name): Capture the status of elaboration checks
3214 and warnings of an expanded name.
3215 * sem_ch12.adb (Analyze_Generic_Package_Declaration): Ensure
3216 that invocation graph-related data within the body of the main
3217 unit is encoded in the ALI file.
3218 (Analyze_Generic_Subprogram_Declaration): Ensure that invocation
3219 graph-related data within the body of the main unit is encoded
3220 in the ALI file.
3221 (Analyze_Package_Instantiation): Perform minimal decoration of
3222 the instance entity.
3223 (Analyze_Subprogram_Instantiation): Perform minimal decoration
3224 of the instance entity.
3225 * sem_elab.adb: Perform heavy refactoring of all code. The unit
3226 is now split into "services" which specialize in one area of ABE
3227 checks. Add processing in order to capture invocation-graph
3228 related attributes of the main unit, and encode them in the ALI
3229 file. The Processing phase can now operate in multiple modes,
3230 all described by type Processing_Kind. Scenarios and targets
3231 are now distinct at the higher level, and carry their own
3232 representations. This eliminates the need to constantly
3233 recompute their attributes, and offers the various processors a
3234 uniform interface. The various initial states of the Processing
3235 phase are now encoded using type Processing_In_State, and
3236 xxx_State constants.
3237 * sem_elab.ads: Update the literals of type
3238 Enclosing_Level_Kind. Add Inline pragmas on several routines.
3239 * sem_prag.adb (Process_Inline): Ensure that invocation
3240 graph-related data within the body of the main unit is encoded
3241 in the ALI file.
3242 * sem_util.adb (Enclosing_Generic_Body, Enclosing_Generic_Unit):
3243 Code clean up.
3244 (Exceptions_OK): Relocated from Sem_Util.
3245 (Mark_Save_Invocation_Graph_Of_Body): New routine.
3246 * sem_util.ads (Exceptions_OK): Relocated from Sem_Util.
3247 (Mark_Save_Invocation_Graph_Of_Body): New routine.
3248 * sinfo.adb (Is_Elaboration_Checks_OK_Node): Now applicable to
3249 N_Variable_Reference_Marker.
3250 (Is_Elaboration_Warnings_OK_Node): Now applicable to
3251 N_Expanded_Name, N_Identifier, N_Variable_Reference_Marker.
3252 (Is_Read): Use Flag4.
3253 (Is_SPARK_Mode_On_Node): New applicable to
3254 N_Variable_Reference_Marker.
3255 (Is_Write): Use Flag5.
3256 (Save_Invocation_Graph_Of_Body): New routine.
3257 (Set_Is_Elaboration_Checks_OK_Node): Now applicable to
3258 N_Variable_Reference_Marker.
3259 (Set_Is_Elaboration_Warnings_OK_Node): Now applicable to
3260 N_Expanded_Name, N_Identifier, N_Variable_Reference_Marker.
3261 (Set_Is_SPARK_Mode_On_Node): New applicable to
3262 N_Variable_Reference_Marker.
3263 (Set_Save_Invocation_Graph_Of_Body): New routine.
3264 * sinfo.ads: Update the documentation of attributes
3265 Is_Elaboration_Checks_OK_Node, Is_Elaboration_Warnings_OK_Node,
3266 Is_SPARK_Mode_On_Node. Update the flag usage of attributes
3267 Is_Read, Is_Write. Add attribute Save_Invocation_Graph_Of_Body
3268 and update its occurrence in nodes.
3269 (Save_Invocation_Graph_Of_Body): New routine along with pragma
3270 Inline.
3271 (Set_Save_Invocation_Graph_Of_Body): New routine along with
3272 pragma Inline.
3273 * switch-b.adb (Scan_Binder_Switches): Refactor the scanning of
3274 debug switches.
3275 (Scan_Debug_Switches): New routine.
3276 * libgnat/g-dynhta.adb, libgnat/g-dynhta.ads (Contains): New routine.
3277 * libgnat/g-graphs.adb (Associate_Vertices): Update the use of
3278 Component_Vertex_Iterator.
3279 (Contains_Component, Contains_Edge, Contains_Vertex, Has_Next):
3280 Reimplemented.
3281 (Iterate_Component_Vertices): New routine.
3282 (Iterate_Vertices): Removed.
3283 (Next): Update the parameter profile.
3284 (Number_Of_Component_Vertices, Number_Of_Outgoing_Edges): New
3285 routines.
3286 * libgnat/g-graphs.ads: Update the initialization of
3287 No_Component. Add type Component_Vertex_Iterator. Remove type
3288 Vertex_Iterator.
3289 (Has_Next): Add new versions and remove old ones.
3290 (Iterate_Component_Vertices): New routine.
3291 (Iterate_Vertices): Removed.
3292 (Next): Add new versions and remove old ones.
3293 (Number_Of_Component_Vertices, Number_Of_Outgoing_Edges): New
3294 routines.
3295 * libgnat/g-sets.adb (Contains): Reimplemented.
3296 * gcc-interface/Make-lang.in (GNATBIND_OBJS): Add
3297 GNAT.Dynamic_HTables, GNAT.Graphs and Bindo units.
3298 * rtsfind.ads: Remove extra space.
3299
3300 2019-07-03 Yannick Moy <moy@adacore.com>
3301
3302 * sem_spark.adb: Add support for locally borrowing and observing
3303 a path.
3304 (Get_Root_Object): Add parameter Through_Traversal to denote
3305 when we are interesting in getting to the traversed parameter.
3306 (Is_Prefix_Or_Almost): New function to support detection of
3307 illegal access to borrowed or observed paths.
3308 (Check_Pragma): Add analysis of assertion pragmas.
3309
3310 2019-07-03 Ed Schonberg <schonberg@adacore.com>
3311
3312 * sem_ch13.adb (Build_Predicate_Functions): In a generic context
3313 we do not build the bodies of predicate fuctions, but the
3314 expression in a static predicate must be elaborated to allow
3315 case coverage checking within the generic unit.
3316 (Build_Discrete_Static_Predicate): In a generic context, return
3317 without building function body once the
3318 Static_Discrete_Predicate expression for the type has been
3319 constructed.
3320
3321 2019-07-03 Hristian Kirtchev <kirtchev@adacore.com>
3322
3323 * bindgen.adb, inline.adb, layout.adb, sem_ch12.adb,
3324 sem_ch13.adb, sem_ch7.adb, styleg.adb: Minor reformatting.
3325
3326 2019-07-03 Bob Duff <duff@adacore.com>
3327
3328 * par-ch3.adb (P_Defining_Identifier): Call
3329 Check_Defining_Identifier_Casing.
3330 * style.ads, styleg.ads, styleg.adb
3331 (Check_Defining_Identifier_Casing): New procedure to check for
3332 mixed-case defining identifiers.
3333 * stylesw.ads, stylesw.adb (Style_Check_Mixed_Case_Decls): New
3334 flag for checking for mixed-case defining identifiers.
3335 * doc/gnat_ugn/building_executable_programs_with_gnat.rst:
3336 Document new feature.
3337 * gnat_ugn.texi: Regenerate.
3338
3339 2019-07-03 Eric Botcazou <ebotcazou@adacore.com>
3340
3341 * doc/gnat_ugn/building_executable_programs_with_gnat.rst
3342 (Warning message control): Document that -gnatw.z/Z apply to
3343 array types.
3344 * freeze.adb (Freeze_Entity): Give -gnatw.z warning for array
3345 types as well, but not if the specified alignment is the minimum
3346 one.
3347 * gnat_ugn.texi: Regenerate.
3348
3349 2019-07-03 Bob Duff <duff@adacore.com>
3350
3351 * einfo.ads, exp_util.adb, layout.ads, sinfo.ads: Spell "laid"
3352 correctly.
3353
3354 2019-07-03 Ed Schonberg <schonberg@adacore.com>
3355
3356 * sem_ch13.adb (Analyze_Attribute_Definition_Clause): No error
3357 message on attribute applied to a renaming when the renamed
3358 object is an aggregate (from code reading).
3359 (Check_Aspect_At_End_Of_Declarations): In a generic context
3360 where freeze nodes are not generated, the original expression
3361 for an aspect may need to be analyzed to precent spurious
3362 conformance errors when compared with the expression that is
3363 anakyzed at the end of the current declarative list.
3364
3365 2019-07-03 Eric Botcazou <ebotcazou@adacore.com>
3366
3367 * layout.adb (Layout_Type): Do not set the component size of an
3368 array with a scalar component if the component type is
3369 overaligned.
3370
3371 2019-07-03 Ed Schonberg <schonberg@adacore.com>
3372
3373 * inline.adb (Make_Loop_Labels_Unique): New procedure to modify
3374 the source code of subprograms that are inlined by the
3375 front-end, to prevent accidental duplication between loop labels
3376 in the inlined code and the code surrounding the inlined call.
3377
3378 2019-07-03 Hristian Kirtchev <kirtchev@adacore.com>
3379
3380 * doc/gnat_ugn/elaboration_order_handling_in_gnat.rst: Update
3381 the section on resolving elaboration circularities to eliminate
3382 certain combinations of switches which together do not produce
3383 the desired effect and confuse users.
3384 * gnat_ugn.texi: Regenerate.
3385
3386 2019-07-03 Arnaud Charlet <charlet@adacore.com>
3387
3388 * bindgen.adb (Gen_Main): Disable generation of reference to
3389 Ada_Main_Program_Name for CCG.
3390 * bindusg.adb (Display): Add -G to the command-line usage for
3391 gnatbind.
3392 * opt.ads (Generate_C_Code): Update comment.
3393 * switch-b.adb (Scan_Binder_Switches): Add handling for -G.
3394
3395 2019-07-03 Arnaud Charlet <charlet@adacore.com>
3396
3397 * sem_ch7.adb (Has_Referencer): Do not consider inlined
3398 subprograms when generating C code, which allows us to generate
3399 static inline subprograms.
3400
3401 2019-07-03 Justin Squirek <squirek@adacore.com>
3402
3403 * sem_ch6.adb (Check_Conformance): Add expression checking for
3404 constant modifiers in anonymous access types (in addition to
3405 "non-null" types) so that they are considered "matching" for
3406 subsequent conformance tests.
3407
3408 2019-07-03 Arnaud Charlet <charlet@adacore.com>
3409
3410 * doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
3411 Clarify wording on No_Multiple_Elaboration.
3412 * gnat_rm.texi: Regenerate.
3413
3414 2019-07-03 Ed Schonberg <schonberg@adacore.com>
3415
3416 * sem_ch8.adb (Find_Selected_Component): If the prefix is the
3417 current instance of a type or subtype, complete the resolution
3418 of the name by finding the component of the type denoted by the
3419 selector name.
3420
3421 2019-07-03 Eric Botcazou <ebotcazou@adacore.com>
3422
3423 * doc/gnat_rm/interfacing_to_other_languages.rst (Interfacing to C):
3424 Document that boolean types with convention C now map to C99 bool.
3425 * gnat_rm.texi: Regenerate.
3426
3427 2019-07-03 Javier Miranda <miranda@adacore.com>
3428
3429 * exp_attr.adb (Expand_Min_Max_Attribute): Code cleanup:
3430 removing code that it is now never executed in the CCG compiler
3431 (dead code).
3432
3433 2019-07-02 Iain Sandoe <iain@sandoe.co.uk>
3434
3435 * libgnat/system-darwin-ppc.ads: Set Stack_Check_Probes True for
3436 PPC Darwin.
3437
3438 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3439
3440 * sem_ch12.adb (Is_Defaulted): New predicate in
3441 Check_Formal_Package_Intance, to skip the conformance of checks
3442 on parameters of a formal package that are defaulted,
3443
3444 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3445
3446 * checks.adb, exp_ch9.adb, exp_unst.adb, sem_ch4.adb,
3447 sem_prag.adb, sem_spark.adb: Minor reformatting.
3448
3449 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3450
3451 * sem_attr.adb (Analyze_Attribute, case Enum_Rep): Allow prefix
3452 of attribute to be an attribute reference of a discrete type.
3453
3454 2019-07-01 Eric Botcazou <ebotcazou@adacore.com>
3455
3456 * sem_ch12.adb (Analyze_Subprogram_Instantiation): Move up
3457 handling of Has_Pragma_Inline_Always and deal with
3458 Has_Pragma_No_Inline.
3459
3460 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3461
3462 * sem_ch3.adb (Build_Derived_Record_Type): If the parent type is
3463 declared as a subtype of a private type with an inherited
3464 discriminant constraint, its generated full base appears as a
3465 record subtype, so we need to retrieve its oen base type so that
3466 the inherited constraint can be applied to it.
3467
3468 2019-07-01 Yannick Moy <moy@adacore.com>
3469
3470 * sem_spark.adb: Completely rework the algorithm for ownership
3471 checking, as the rules in SPARK RM have changed a lot.
3472 * sem_spark.ads: Update comments.
3473
3474 2019-07-01 Dmitriy Anisimkov <anisimko@adacore.com>
3475
3476 * gsocket.h (Has_Sockaddr_Len): Use the offset of sin_family offset in
3477 the sockaddr_in structure to determine the existence of length field
3478 before the sin_family.
3479
3480 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3481
3482 * sem_prag.adb (Analyze_Pragma, case Weak_External): Pragma only
3483 applies to entities with run-time addresses, not to types.
3484
3485 2019-07-01 Piotr Trojanek <trojanek@adacore.com>
3486
3487 * einfo.adb, sem_ch7.adb, sem_prag.adb, sem_util.adb: Update
3488 references to the SPARK RM after the removal of Rule 7.1.4(5).
3489
3490 2019-07-01 Piotr Trojanek <trojanek@adacore.com>
3491
3492 * sysdep.c: Cleanup references to LynuxWorks in docs and
3493 comments.
3494
3495 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3496
3497 * checks.adb (Insert_Valid_Check): Do not apply validity check
3498 to variable declared within a protected object that uses the
3499 Lock_Free implementation, to prevent unwarranted constant
3500 folding, because entities within such an object msut be treated
3501 as volatile.
3502
3503 2019-07-01 Eric Botcazou <ebotcazou@adacore.com>
3504
3505 * exp_ch9.adb (Check_Inlining): Deal with Has_Pragma_No_Inline.
3506
3507 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3508
3509 * exp_unst.adb (Visit_Node, Check_Static_Type): Improve the
3510 handling of private and incomplete types whose full view is an
3511 access type, to detect additional uplevel references in dynamic
3512 bounds. This is relevant to N_Free_Statement among others that
3513 manipulate types whose full viww may be an access type.
3514
3515 2019-07-01 Pat Rogers <rogers@adacore.com>
3516
3517 * doc/gnat_rm/representation_clauses_and_pragmas.rst: Correct
3518 size indicated for R as a component of an array.
3519 * gnat_rm.texi: Regenerate.
3520
3521 2019-07-01 Justin Squirek <squirek@adacore.com>
3522
3523 * libgnat/s-win32.ads: Add definition for ULONG, modify
3524 OVERLAPPED type, and add appropriate pragmas.
3525
3526 2019-07-01 Bob Duff <duff@adacore.com>
3527
3528 * gnat1drv.adb (gnat1drv): Call Write_ALI if the main unit is
3529 ignored-ghost.
3530
3531 2019-07-01 Yannick Moy <moy@adacore.com>
3532
3533 * sem_ch4.adb (Operator_Check): Refine error message.
3534
3535 2019-07-01 Piotr Trojanek <trojanek@adacore.com>
3536
3537 * libgnat/a-calend.ads: Revert "Global => null" contracts on
3538 non-pure routines.
3539
3540 2019-07-01 Piotr Trojanek <trojanek@adacore.com>
3541
3542 * exp_attr.adb, libgnat/g-graphs.ads: Fix typos in comments:
3543 componant -> component.
3544
3545 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3546
3547 * libgnat/g-graphs.adb: Use type Directed_Graph rather than
3548 Instance in various routines.
3549 * libgnat/g-graphs.ads: Change type Instance to Directed_Graph.
3550 Update various routines that mention the type.
3551
3552 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3553
3554 * libgnat/g-sets.adb: Use type Membership_Set rathern than
3555 Instance in various routines.
3556 * libgnat/g-sets.ads: Change type Instance to Membership_Set.
3557 Update various routines that mention the type.
3558
3559 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3560
3561 * libgnat/g-lists.adb: Use type Doubly_Linked_List rather than
3562 Instance in various routines.
3563 * libgnat/g-lists.ads: Change type Instance to
3564 Doubly_Linked_List. Update various routines that mention the
3565 type.
3566
3567 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3568
3569 * libgnat/g-dynhta.adb: Use type Dynamic_Hash_Table rather than
3570 Instance in various routines.
3571 * libgnat/g-dynhta.ads: Change type Instance to
3572 Dynamic_Hash_Table. Update various routines that mention the
3573 type.
3574
3575 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3576
3577 * exp_attr.adb, exp_ch7.adb, exp_unst.adb, sem_ch3.adb,
3578 sem_util.adb, uintp.adb, uintp.ads: Minor reformatting.
3579
3580 2019-07-01 Javier Miranda <miranda@adacore.com>
3581
3582 * exp_attr.adb (Expand_Min_Max_Attribute): Disable expansion of
3583 'Min/'Max on integer, enumeration, fixed point and floating
3584 point types since the CCG backend now provides in file
3585 standard.h routines to support it.
3586
3587 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3588
3589 * impunit.adb: Add GNAT.Graphs to list Non_Imp_File_Names_95.
3590 * Makefile.rtl, gcc-interface/Make-lang.in: Register unit
3591 GNAT.Graphs.
3592 * libgnat/g-dynhta.adb: Various minor cleanups (use Present
3593 rather than direct comparisons).
3594 (Delete): Reimplement to use Delete_Node.
3595 (Delete_Node): New routine.
3596 (Destroy_Bucket): Invoke the provided destructor.
3597 (Present): New routines.
3598 * libgnat/g-dynhta.ads: Add new generic formal Destroy_Value.
3599 Use better names for the components of iterators.
3600 * libgnat/g-graphs.adb, libgnat/g-graphs.ads: New unit.
3601 * libgnat/g-lists.adb: Various minor cleanups (use Present
3602 rather than direct comparisons).
3603 (Delete_Node): Invoke the provided destructor.
3604 (Present): New routine.
3605 * libgnat/g-lists.ads: Add new generic formal Destroy_Element.
3606 Use better names for the components of iterators.
3607 (Present): New routine.
3608 * libgnat/g-sets.adb, libgnat/g-sets.ads (Destroy, Preset,
3609 Reset): New routines.
3610
3611 2019-07-01 Dmitriy Anisimkov <anisimko@adacore.com>
3612
3613 * libgnat/g-sothco.adb (Get_Address): Fix the case when AF_INET6
3614 is not defined.
3615
3616 2019-07-01 Ed Schonberg <schonberg@adacore.com>
3617
3618 * exp_attr.adb (Expand_Attribute_Reference, case Invalid_Value):
3619 Resolve result of call to Get_Simple_Init_Val, which may be a
3620 conversion of a literal.
3621
3622 2019-07-01 Hristian Kirtchev <kirtchev@adacore.com>
3623
3624 * freeze.adb (Freeze_Expression): Remove the horrible useless
3625 name hiding of N. Insert the freeze nodes generated by the
3626 expression prior to the expression when the nearest enclosing
3627 scope is transient.
3628
3629 2019-07-01 Pierre-Marie de Rodat <derodat@adacore.com>
3630
3631 * doc/gnat_ugn/building_executable_programs_with_gnat.rst: Fix
3632 formatting issues in the -gnatR section.
3633 * gnat_ugn.texi: Regenerate.
3634
3635 2019-06-30 Iain Sandoe <iain@sandoe.co.uk>
3636
3637 * gnatlink.adb (Link_Step): Remove duplicate -static-libgcc switches.
3638 Push -shared-libgcc explicitly, when it is the target default (unless
3639 overidden by the static flag).
3640 When the user has put an instance of shared/static-libgcc do not push
3641 a duplicate of this.
3642
3643 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3644
3645 * gcc-interface/decl.c (gnat_to_gnu_entity): Beep up comment on SAVED,
3646 and tweak comment on the assertion about the scopes of Itypes. Do not
3647 skip the regular processing for Itypes that are E_Record_Subtype with
3648 a Cloned_Subtype. Get the Cloned_Subtype for every E_Record_Subtype
3649 if the type is dummy and hasn't got its own freeze node.
3650 <E_Record_Subtype>: Save again the DECL of the Cloned_Subtype, if any.
3651 <E_Access_Subtype>: Save again the DECL of the equivalent type.
3652 (Gigi_Equivalent_Type) <E_Access_Subtype>: New case.
3653
3654 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3655
3656 * gcc-interface/utils.c (unchecked_convert): Tweak comment. Only skip
3657 dereferences when padding to have the same size on both sides. Do it
3658 for destination types with self-referential size too.
3659
3660 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3661
3662 * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Record_Type>: If the
3663 type requires strict alignment, then set the RM size to the type size.
3664 Rework handling of alignment and sizes of tagged types in ASIS mode.
3665 (validate_size): Rename local variable and remove special handling for
3666 strict-alignment types.
3667 * gcc-interface/utils.c (finish_record_type): Constify local variables
3668 and use properly typed constants.
3669
3670 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3671
3672 * gcc-interface/decl.c (gnat_to_gnu_field): Rework error messages for
3673 fields requiring strict alignment, add explicit test on Storage_Unit
3674 for position and size, and mention type alignment for position.
3675
3676 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3677
3678 * gcc-interface/trans.c (mark_visited_r): Set TYPE_SIZES_GIMPLIFIED on
3679 the main variant of a type, if any.
3680
3681 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3682
3683 * gcc-interface/decl.c (set_nonaliased_component_on_array_type): Add
3684 missing guard for the presence of TYPE_CANONICAL.
3685 (set_reverse_storage_order_on_array_type): Likewise.
3686
3687 2019-06-29 Eric Botcazou <ebotcazou@adacore.com>
3688
3689 * gcc-interface/gigi.h (make_packable_type): Remove default value.
3690 (value_factor_p): Tweak prototype.
3691 * gcc-interface/decl.c (gnat_to_gnu_entity): Add comment.
3692 (gnat_to_gnu_component_type): Likewise.
3693 (gnat_to_gnu_field): Likewise. Fetch the position of the field earlier
3694 and simplify the condition under which the type is packed. Declare
3695 local variable is_bitfield. Pass 1 as max_align to make_packable_type
3696 if it is set to true.
3697 (copy_and_substitute_in_layout): Pass 0 to make_packable_type.
3698 * gcc-interface/utils.c (make_packable_array_type): New function.
3699 (make_packable_type): Use it to rewrite the type of array field.
3700 (maybe_pad_type): Pass align parameter to make_packable_type.
3701 (create_field_decl): Minor tweaks.
3702 (value_factor_p): Assert that FACTOR is a power of 2 and replace the
3703 modulo computation by a masking operation.
3704
3705 2019-06-25 Eric Botcazou <ebotcazou@adacore.com>
3706
3707 * gcc-interface/decl.c (gnat_to_gnu_entity): Remove superfluous test
3708 in previous change.
3709 * gcc-interface/gigi.h (maybe_character_type): Fix formatting.
3710 (maybe_character_value): Likewise.
3711
3712 2019-06-24 Jan Hubicka <jh@suse.cz>
3713
3714 * gcc-interface/decl.c (gnat_to_gnu_entity): Check that
3715 type is array or integer prior checking string flag.
3716 * gcc-interface/gigi.h (maybe_character_type): Likewise.
3717 (maybe_character_value): Likewise.
3718
3719 2019-06-24 Martin Sebor <msebor@redhat.com>
3720
3721 * gcc-interface/utils.c (handle_nonnull_attribute): Quote attribute
3722 name.
3723
3724 2019-06-18 Arnaud Charlet <charlet@adacore.com>
3725
3726 PR ada/80590
3727 * sem_ch5.adb (Analyze_Loop_Statement): Avoid exception propagation
3728 during normal processing.
3729
3730 2019-06-17 Arnaud Charlet <charlet@adacore.com>
3731
3732 PR ada/80590
3733 * exp_ch9.adb (Expand_N_Delay_Relative_Statement): Swap the two
3734 conditions to avoid a unnecessary exception propagation in the default
3735 case.
3736
3737 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3738
3739 * gcc-interface/utils.c (handle_stack_protect_attribute): Move around.
3740
3741 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3742
3743 * doc/gnat_rm/implementation_defined_pragmas.rst (Machine_Attribute):
3744 Document additional optional parameters.
3745 * sem_prag.adb (Analyze_Pragma) <Pragma_Machine_Attribute>: Accept
3746 more than one optional parameter.
3747 * gcc-interface/decl.c (prepend_one_attribute_pragma): Alphabetize
3748 the list of supported pragmas. Simplify the handling of parameters
3749 and add support for more than one optional parameter.
3750 * gcc-interface/utils.c (attr_cold_hot_exclusions): New constant.
3751 (gnat_internal_attribute_table): Add entry for no_icf, noipa, flatten,
3752 used, cold, hot, target and target_clones.
3753 (begin_subprog_body): Do not create the RTL for the subprogram here.
3754 (handle_noicf_attribute): New static function.
3755 (handle_noipa_attribute): Likewise.
3756 (handle_flatten_attribute): Likewise.
3757 (handle_used_attribute): Likewise.
3758 (handle_cold_attribute): Likewise.
3759 (handle_hot_attribute): Likewise.
3760 (handle_target_attribute): Likewise.
3761 (handle_target_clones_attribute): Likewise.
3762
3763 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3764
3765 * gcc-interface/trans.c (lvalue_required_for_attribute_p): Return 0
3766 for 'Size too.
3767 (Identifier_to_gnu): Use the actual subtype for a reference to a
3768 packed array in a return statement.
3769 (Attribute_to_gnu) <Attr_Size>: Do not strip VIEW_CONVERT_EXPRs from
3770 the prefix in every case.
3771
3772 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3773
3774 * gcc-interface/trans.c (gnat_to_gnu): Remove superfluous tests on
3775 Backend_Overflow_Checks_On_Target and rework comments.
3776
3777 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3778
3779 * gcc-interface/trans.c (walk_nesting_tree): New static function.
3780 (finalize_nrv): Use it to walk the entire nesting tree.
3781
3782 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3783
3784 * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Record_Subtype>: Remove
3785 obsolete test on Is_For_Access_Subtype.
3786
3787 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3788
3789 * gcc-interface/decl.c (components_to_record): Set a name on the type
3790 created for the REP part, if any.
3791 * gcc-interface/utils.c (finish_record_type): Only take the maximum
3792 when merging sizes for a variant part at offset 0.
3793 (merge_sizes): Rename has_rep parameter into max.
3794
3795 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3796
3797 * gcc-interface/utils.c (gnat_internal_attribute_table): Add support
3798 for stack_protect attribute.
3799 (handle_stack_protect_attribute): New static function.
3800
3801 2019-05-28 Eric Botcazou <ebotcazou@adacore.com>
3802
3803 * gcc-interface/decl.c (intrin_arglists_compatible_p): Do not return
3804 false if the internal builtin uses a variable list.
3805
3806 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3807
3808 * gcc-interface/trans.c (Call_to_gnu): Do not initialize the temporary
3809 created out of addressability concerns if it's for the _Init parameter
3810 of an initialization procedure.
3811
3812 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3813
3814 * gcc-interface/ada-builtin-types.def: New file.
3815 * gcc-interface/ada-builtins.def: Likewise.
3816 * gcc-interface/ada-tree.h (BUILT_IN_LIKELY): New macro.
3817 (BUILT_IN_UNLIKELY): Likewise.
3818 * gcc-interface/trans.c (independent_iterations_p): Initialize the
3819 auto-vector to 16 elements.
3820 (Call_to_gnu): Remove local variable and change the vector of actual
3821 parameters to an auto-vector. Do not convert actual parameters to
3822 the argument type for front-end built-in functions. Add support for
3823 front-end built-in functions.
3824 (build_noreturn_cond): Use internal instead of built-in function.
3825 * gcc-interface/utils.c (c_builtin_type): Include ada-builtin-types.def
3826 (install_builtin_function_types): Likewise.
3827 (install_builtin_functions): Include ada-builtins.def first.
3828
3829 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3830
3831 * gcc-interface/utils.c (maybe_pad_type): Issue the warning for the
3832 specific case of component types preferably.
3833
3834 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3835
3836 * gcc-interface/trans.c (Identifier_to_gnu): Minor tweaks.
3837 (gnat_to_gnu): Do not convert the result if it is a reference to an
3838 unconstrained array used as the prefix of an attribute reference that
3839 requires an lvalue.
3840
3841 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3842
3843 * gcc-interface/trans.c (Gigi_Types_Compatible): New predicate.
3844 (Identifier_to_gnu): Use it to assert that the type of the identifier
3845 and that of its entity are compatible for gigi. Rename a couple of
3846 local variables and separate the processing of the result type.
3847
3848 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3849
3850 * gcc-interface/trans.c (Call_to_gnu): Use the unpadded type when
3851 putting back an intermediate conversion the type of the actuals.
3852
3853 2019-05-27 Eric Botcazou <ebotcazou@adacore.com>
3854
3855 * gcc-interface/trans.c (gnat_to_gnu) <Shift operations>: Convert the
3856 count to the unsigned version of its base type before proceeding.
3857
3858 2019-05-16 Martin Sebor <msebor@redhat.com>
3859
3860 * gcc-interface/trans.c (check_inlining_for_nested_subprog): Quote
3861 reserved names.
3862
3863 2019-05-08 Arnaud Charlet <charlet@adacore.com>
3864
3865 * standard.ads.h: New file.
3866
3867 2019-05-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
3868
3869 * gcc-interface/Makefile.in (install-gcc-specs): Use foreach.
3870 Honor DESTDIR.
3871
3872 2019-04-29 Michael K. Darling <darlingm@gmail.com>
3873
3874 * gnatvsn.ads: Bump Library_Version to 10.
3875
3876 2019-04-24 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
3877 Bernd Edlinger <bernd.edlinger@hotmail.de>
3878 Jakub Jelinek <jakub@redhat.com>
3879
3880 PR target/89093
3881 * raise-gcc.c (TARGET_ATTRIBUTE): Define.
3882 (continue_unwind, personality_body, PERSONALITY_FUNCTION): Add
3883 TARGET_ATTRIBUTE.
3884
3885 2019-04-07 Eric Botcazou <ebotcazou@adacore.com>
3886
3887 * libgnat/i-cexten.ads (CFloat_128): New type.
3888
3889 2019-03-22 Dmitriy Anisimkov <anisimko@adacore.com>
3890
3891 PR ada/89583
3892 * libgnat/g-socket.adb (Bind_Socket, Connect_Socket,
3893 Send_Socket): Fix the computation of structure lengths passed to
3894 low level routines.
3895 (Is_IPv6_Address): Fix the number of expected colons.
3896
3897 2019-03-11 Martin Liska <mliska@suse.cz>
3898
3899 * gcc-interface/misc.c (gnat_post_options): Wrap option name in string
3900 format message and fix GNU coding style.
3901
3902 2019-02-08 Eric Botcazou <ebotcazou@adacore.com>
3903
3904 * gcc-interface/trans.c (gnat_to_gnu) <N_Aggregate>: Minor tweak.
3905 * gcc-interface/utils.c (convert): Do not pad when doing an unchecked
3906 conversion here. Use TREE_CONSTANT throughout the function.
3907 (unchecked_convert): Also pad if the source is a CONSTRUCTOR and the
3908 destination is a more aligned array type or a larger aggregate type,
3909 but not between original and packable versions of a type.
3910
3911 2019-02-08 Eric Botcazou <ebotcazou@adacore.com>
3912
3913 * gcc-interface/utils.c (max_size) <tcc_unary>: Be prepared for an
3914 operand with VOID_TYPE.
3915
3916 2019-02-08 Eric Botcazou <ebotcazou@adacore.com>
3917
3918 * gcc-interface/trans.c (elaborate_all_entities): Do not elaborate the
3919 entities of a package renaming another one.
3920
3921 2019-02-08 Eric Botcazou <ebotcazou@adacore.com>
3922
3923 * gcc-interface/trans.c (Regular_Loop_to_gnu): Replace tests on
3924 individual flag_unswitch_loops and flag_tree_loop_vectorize switches
3925 with test on global optimize switch.
3926 (Raise_Error_to_gnu): Likewise.
3927
3928 2019-02-07 Eric Botcazou <ebotcazou@adacore.com>
3929
3930 * libgnarl/s-linux__sparc.ads (ETIMEDOUT): Set to correct value.
3931
3932 2019-02-06 Arnaud Charlet <charlet@adacore.com>
3933
3934 * libgnarl/s-linux__x32.ads: Resync list of signals with s-linux.ads
3935
3936 2019-01-27 Eric Botcazou <ebotcazou@adacore.com>
3937
3938 * repinfo.adb (List_Component_Layout): Remove superfluous space for
3939 zero-sized field.
3940 * gcc-interface/ada-tree.h (TYPE_IS_EXTRA_SUBTYPE_P): New macro.
3941 * gcc-interface/gigi.h (create_extra_subtype): Declare.
3942 * gcc-interface/decl.c (TYPE_ARRAY_SIZE_LIMIT): Likewise.
3943 (update_n_elem): New function.
3944 (gnat_to_gnu_entity): Use create_extra_subtype to create extra subtypes
3945 instead of doing it manually.
3946 <E_Array_Type>: Use update_n_elem to compute the maximum size. Use the
3947 index type instead of base type for the bounds. Set TYPE_ARRAY_MAX_SIZE
3948 of the array to the maximum size.
3949 <E_Array_Subtype>: Create an extra subtype using the index type of the
3950 base array type for self-referential bounds. Use update_n_elem to
3951 compute the maximum size. Set TYPE_ARRAY_MAX_SIZE of the array to the
3952 maximum size.
3953 (gnat_to_gnu_field): Clear DECL_NONADDRESSABLE_P on discriminants.
3954 * gcc-interface/misc.c (gnat_get_alias_set): Return the alias set of
3955 the base type for an extra subtype.
3956 (gnat_type_max_size): Remove obsolete code.
3957 * gcc-interface/trans.c (Attribute_to_gnu): Minor tweak.
3958 (can_be_lower_p): Deal with pathological types.
3959 * gcc-interface/utils.c (create_extra_subtype): New function.
3960 (create_field_decl): Minor tweak.
3961 (max_size) <tcc_reference>: Compute a better value by using the extra
3962 subtypes on the self-referential bounds.
3963 <tcc_binary>: Rewrite. Deal with "negative value" in unsigned types.
3964 <tcc_expression>: Likewise.
3965 * gcc-interface/utils2.c (compare_arrays): Retrieve the original bounds
3966 of the arrays upfront. Swap only if the second length is not constant.
3967 Use comparisons on the original bounds consistently for the null tests.
3968 (build_binary_op): Use TYPE_IS_EXTRA_SUBTYPE_P macro.
3969 (build_allocator): Minor tweak.
3970
3971 2019-01-27 Eric Botcazou <ebotcazou@adacore.com>
3972
3973 * gcc-interface/decl.c (array_type_has_nonaliased_component): Return
3974 the same value for every dimension of a multidimensional array type.
3975
3976 2019-01-26 Eric Botcazou <ebotcazou@adacore.com>
3977
3978 * gcc-interface/trans.c (Regular_Loop_to_gnu): Use the SLOC of the
3979 iteration scheme, if present, throughout the translation.
3980
3981 2019-01-26 Eric Botcazou <ebotcazou@adacore.com>
3982
3983 * gcc-interface/trans.c (gnat_to_gnu) <N_Assignment_Statement>: Use
3984 DECL_SIZE_UNIT instead of TYPE_SIZE_UNIT for the size to be assigned
3985 by a call to memset if the LHS is a DECL.
3986
3987 2019-01-26 Eric Botcazou <ebotcazou@adacore.com>
3988
3989 * gcc-interface/trans.c (struct loop_info_d): Remove artificial field.
3990 (Loop_Statement_to_gnu): Do not set it.
3991
3992 2019-01-26 Eric Botcazou <ebotcazou@adacore.com>
3993
3994 * gcc-interface/trans.c (Iterate_Acc_Clause_Arg): Fix formatting.
3995 (Acc_gnat_to_gnu): Likewise.
3996 (Acc_Data_to_gnu): Likewise.
3997 (Acc_Var_to_gnu): Likewise.
3998 (Acc_Reduc_to_gnu): Likewise.
3999 (Acc_Size_List_to_gnu): Likewise.
4000 (Pragma_to_gnu) <Pragma_Acc_Loop>: Likewise.
4001 <Pragma_Acc_Data>): Likewise.
4002 (find_loop_for): Remove default value for parameters.
4003 * gcc-interface/trans.c (gnat_to_gnu) <N_Op_And>: Merge into...
4004 <N_Op_Eq>): ...this.
4005
4006 2019-01-26 Eric Botcazou <ebotcazou@adacore.com>
4007
4008 * gcc-interface/decl.c (annotate_value) <INTEGER_CST>: Use test on
4009 the sign bit instead of on the sign of the value.
4010 <PLUS_EXPR>: Turn addition of negative constant into subtraction.
4011 <MULT_EXPR>: Add test for degenerate case.
4012 <BIT_AND_EXPR>: Simplify.
4013
4014 2019-01-18 Sebastian Huber <sebastian.huber@embedded-brains.de>
4015
4016 * s-oscons-tmplt.c (AF_INET6): Do not undefine for RTEMS.
4017
4018 2019-01-09 Sandra Loosemore <sandra@codesourcery.com>
4019
4020 PR other/16615
4021 * exp_ch11.adb: Change "can not" to "cannot".
4022 * sem_ch4.adb: Likewise.
4023
4024 2019-01-09 Sandra Loosemore <sandra@codesourcery.com>
4025
4026 PR other/16615
4027 * exp_ch9.adb: Mechanically replace "can not" with "cannot".
4028 * libgnat/s-regpat.ads: Likewise.
4029 * par-ch4.adb: Likewise.
4030 * set_targ.adb: Likewise.
4031 * types.ads: Likewise.
4032
4033 2019-01-08 Justin Squirek <squirek@adacore.com>
4034
4035 Revert:
4036 2018-07-31 Justin Squirek <squirek@adacore.com>
4037
4038 * lib-writ.adb (Write_With_Lines): Modfiy the generation
4039 of dependencies within ali files so that source unit
4040 bodies are properly listed even if said bodies are
4041 missing. Perform legacy behavior in GNATprove mode.
4042 * lib-writ.ads: Modify documentation to reflect current
4043 behavior.
4044
4045 and:
4046 2018-09-26 Justin Squirek <squirek@adacore.com>
4047
4048 * lib-writ.adb, lib-writ.ads (Write_With_Lines): Add
4049 documentation and an extra conditional check for RCI
4050 units so that generated ali files will list the spec
4051 only instead of a body when a body is not found.
4052
4053 2019-01-04 Eric Botcazou <ebotcazou@adacore.com>
4054
4055 * gnatvsn.ads: Bump copyright year.
4056
4057 2019-01-01 Jakub Jelinek <jakub@redhat.com>
4058
4059 Update copyright years.
4060
4061 * gnat_ugn.texi: Bump @copying's copyright year.
4062 * gnat_rm.texi: Likewise.
4063 \f
4064 Copyright (C) 2019 Free Software Foundation, Inc.
4065
4066 Copying and distribution of this file, with or without modification,
4067 are permitted in any medium without royalty provided the copyright
4068 notice and this notice are preserved.