]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bnx2x: Prevent load reordering in tx completion processing
authorBrian King <brking@linux.vnet.ibm.com>
Mon, 15 Jul 2019 21:41:50 +0000 (16:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jul 2019 06:28:23 +0000 (08:28 +0200)
commitc73a6485a8aa9fe08ca8d31af3c9925ff59cf9c7
treee203f0ab88ff1c1f653bcdec8aafb8cbc6a5df47
parentaac977a09eca0e62280644a2bdc3403a61892348
bnx2x: Prevent load reordering in tx completion processing

[ Upstream commit ea811b795df24644a8eb760b493c43fba4450677 ]

This patch fixes an issue seen on Power systems with bnx2x which results
in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c