]> git.ipfire.org Git - thirdparty/mdadm.git/blob - ChangeLog
2529fe13db918c0360a776bb7e86f2ba549a2bb2
[thirdparty/mdadm.git] / ChangeLog
1 Changes Prior to this release
2 - Support 'mailfrom' line in mdadm.conf so the From: line in alert
3 emails can be explicitly set.
4
5 Changes Prior to 2.4.1 release
6 - Honour --write-mostly when adding to an array without persistent
7 superblocks.
8 - Fix alignment problem in version-1 superblocks.
9 NOTE: This is an incompatable change affecting raid5 reshape.
10 If you want to reshape a raid5 using version-1 superblocks,
11 use 2.6.17-rc2 or later, and mdadm-2.4.1 or later.
12
13 Changes Prior to 2.4 release
14 - Rewrite 'reshape' support including performing a backup
15 of the critical region for a raid5 growth, and restoring that
16 backup after a crash.
17 - Put a 'canary' at each end of the backup so a corruption
18 can be more easily detected.
19 - Remove useless 'ident' arguement from ->getinfo_super method.
20 - Support --backup-file for backing-up critical section during
21 growth.
22 - Erase old superblocks (of different versions) when creating new
23 array.
24 - Allow --monitor to work with arrays with >28 devices
25 - Report reshape information in --detail
26 - Handle symlinks in /dev better
27 - Fix mess in --detail output which a device is missing.
28 - Manpage tidyup
29 - Support 'bitmap=' in mdadm.conf for auto-assembling arrays with
30 write-intent bitmaps in separate files.
31 - Updates to md.4 man page including section on RESTRIPING and SYSFS
32
33 Changes Prior to 2.3.1 release
34 - Fixed -O2 compile so I could make and RPM.
35 - Type cast number to be printed %llu so it compiles on 64bit
36 machines. (Thanks Luca).
37 - Stop using asm/byteorder.h - to make Redhat happy :-(
38 - Require bitmap files to have a '/' in their name.
39 - Error-check a few syscalls - code from SuSE package.
40
41 Changes Prior to 2.3 release
42 - Try /etc/mdadm/mdadm.conf if /etc/mdadm.conf doesn't exist.
43 This provided compatability for Debian.
44 - Fixed for version-1 superblock:
45 report chunksize for raid6 and raid10
46 make sure device size used is a multiple of chunksize
47 - Fix "--assemble --scan" crash.
48 - Fix completely failure to create array on ppc64
49 - Fix memcmp in place of memcpy
50 - A few minor improvements to online help
51 - Clean up usage of 'long long' for used-size of devices, so
52 that it is possible to create a raid1 of 7TB devices!
53 - Make internal bitmaps work on 7TB raid1 arrays.
54 - Provide error message if --examine doesn't find any superblock.
55 - Report 'reshape' status in --examine - this depends on kernel
56 patches that are not yet finalised.
57 - Report bitmap status in --detail and --examine
58 - Default to v1 superblocks instead of v0.90 if the array
59 is too big for 0.90 to handle.
60 - Sort the output of "mdadm --detail --scan" so that it is
61 in a suitable order for assembling arrays. i.e. components come
62 before an array that they are part of.
63 - Print size of large reiserfs array properly went warning of
64 possible confilcts.
65
66 Changes Prior to 2.2 release
67 - Assorted bug fixes
68 - Support write-intent-bitmaps on raid10
69 - Support little-endian (Rather than hostendian) bitmaps.
70 - Return correct error code from 'mdadm -S'
71 - Remove extra blank line from 'mdadm -Eb' output.
72 - Improve option parsing so that -a and -b do not have
73 optional arguements: the arg is either required or not
74 depending on context.
75 - Allow scanning of devices listed in /proc/partitions even
76 if they don't appear in /dev.
77 - Support --assume-clean in --create mode as well as --build
78 - Add support for --monitor to report to syslog: -y or --syslog.
79 Thanks to Ross Vandegrift
80 - --monitor now reports which device failed in a 'Fail' message
81 This broke with 2.6
82 - Improve chance of array starting properly after a crash.
83 mdadm was insisting the event numbers were identical, but this
84 isn't needed, and is a problem if the crash was while the metadata
85 was being updated.
86 - Support --update==uuid
87 - Added README.initramfs and mkinitramfs to help people use an
88 initram for starting md arrays at boot.
89
90 Changes Prior to 2.1 release
91 - Fix assembling of raid10 array when devices are missing.
92 mdadm now correctly detects if a array is workable or not
93 depending on which devices are present, and so will correctly
94 handle "--assemble --force" if multiple devices have failed.
95 - Report raid10 layout in --examine output.
96 - Fix assembling of arrays that use the version-1 superblock and
97 have spares. Previously the spares would be ignored.
98 - Fix bug so that multiple drives can be re-added at once.
99 - Fix problem with hot-adding a bitmap to version-1-superblock
100 arrays.
101
102 Changes Prior to 2.0
103 - Support assembling from byte-swapped superblocks
104 metadata type "0.swap" and --update=byteorder
105 - write-mostly and write-behind support for raid1.
106 - Support --name= and 'name=' config entry for identifying
107 arrays be name.
108 - RAID10 in man pages.
109 - Lot of minor manpage updates
110
111 Changes Prior to 2.0-devel-3 release
112 - Assorted fixes for multiple bugs...
113 - Add test suite
114
115 Changes Prior to 1.12.0 release
116 Several of these are backported from the Debian package
117 - Don't use 'lstat' to check for blockdevices, use stat.
118 - Document --size=max option for --grow
119 - Document SparesMissing event and DeviceDisappeared/WrongLevel
120 - --stop --scan repeatly cycles until no more progress can be made
121 so that stack devices are stopped properly
122 - Minor type rationalisation for ident->uuid - now always 'int[]'
123 - Fix type in online help for --grow (was -F, now -G)
124 - Allow --auto command line option to set default auto=
125 value when running "--assemble --scan". Previously
126 --auto was ignored if --scan was given
127 - Fix a few type casts
128 - Fix parsing of /dev/md/N in is_standard
129 - Fix rounding errors in human_size()
130 - Fix silly example in mdadm.conf-examples
131 - When finding a /dev name for a device, prefer shorter names
132 - Suppress listing of devices= in --brief output of -D or -E,
133 unless -v is given (-vv gives the old behaviour with -Dsv).
134 This is because the device list can change and so is not a
135 stable aspect of the array
136 - Allow --force with --grow so '-Gfn1' works (on raid1)
137 - Replace sprintf calls with snprintf (to quiet diet-libc)
138 - Add man page for mdassemble
139 - Fix compilation with tinyc
140
141 Changes Prior to 1.11.0 release
142 - Fix embarassing bug which causes --add to always fail.
143
144 Changes Prior to 1.10.0 release
145 - Fix bug with --config=partitions
146 - Open sub-devices with O_EXCL to detect if already in use
147 - Make sure superblock updates are flushed directly to disk.
148
149 Changes Prior to 2.0-devel-1 release
150 - Support for version-1 superblock. See --metadata option.
151 - Support for bitmap based intent logging.
152 - Minor fixes.
153
154 Changes Prior to 1.9.0 release
155 - Fix rpm build problem (stray %)
156 - Minor manpage updates
157 - Change "dirty" status to "active" as it was confusing people.
158 - --assemble --auto recognises 'standard' name and insists on using
159 the appropriate major/minor number for them.
160 - Remove underscore from partition names, so partitions of
161 "foo" are "foo1", "foo2" etc (unchanged) and partitions of
162 "f00" are "f00p1", "f00p2" etc rather than "f00_p1"...
163 - Use "major", "minor", "makedev" macros instead of
164 "MAJOR", "MINOR", "MKDEV" so that large device numbers work
165 on 2.6 (providing you have glibc 2.3.3 or later).
166 - Add some missing closes of open file descriptors.
167 - Reread /proc/partition for every array assembled when using
168 it to find devices, rather than only once.
169 - Make "mdadm -Ss" stop stacked devices properly, by reversing the
170 order in which arrays are stopped.
171 - Improve some error messages.
172 - Allow device name to appear before first option, so e.g.
173 mdadm /dev/md0 -A /dev/sd[ab]
174 works.
175 - Assume '-Q' if just a device is given, rather than being silent.
176 - Change "dirty" status to "active" as it was confusing people.
177
178 Changes Prior to 1.8.0 release
179 - Makefile cleanup from Luca Berra <bluca@comedia.it>
180 - --pid-file (-i) to set a pid file to use with --monitor --daemonise
181 - Fix typo in mdadm man page
182 - Fix coredump when "-s" used with no config file present.
183 - Support new "faulty" personality which can inject synthetic
184 faults. (Not in kernel.org yet at 1Nov2004)
185 - Support raid0/linear on devices > 2 Terabytes
186 - Make sure raid6 resyncs when created with one missing device
187
188 Changes Prior to 1.7.0 release
189 - Support "--grow --add" to add a device to a linear array, if the
190 kernel supports it. Not documented yet.
191 - Restore support for uclibc which was broken recently.
192 - Several improvements to the output of --detail, including
193 reporting "resyncing" or "recovering" in the state.
194 - Close filedescriptor at end of --detail (exit would have closed it
195 anyway, so this isn't abig deal).
196 - Report "Sync checkpoint" in --examine output if appropriate.
197 - Add --update=resync for --assemble mode to for a resync when the
198 array is assembled.
199 - Add support for "raid10", which is under development in 2.6.
200 Not documented yet.
201 - --monitor now reads spare-group and spares info from config file
202 even when names of arrays to scan are given on the command line
203
204 Changes Prior to 1.6.0 release
205 - Device name given in -Eb is determined by examining /dev rather
206 than assuming /dev/md%d
207 - Fix bug in --monitor where an array could be held open an so
208 could not be stopped without killing mdadm.
209 - Add --grow mode. Currently only --size and --raid-disks can be
210 changed. Both require kernel support which, at the time of
211 writing, is not in a release kernel yet.
212 - Don't print out "errors" or "no-errors" in -D and -E, as the bit
213 is never set or used.
214 - Use md event notification in 2.6.??? to make --monitor mode
215 respond instantly to events.
216 - Add --auto= option and auto= configfile entry to tell mdadm to
217 create device files as needed. This is particularly useful
218 with partitioned arrays where the major device number can change.
219 - When generating --brief listing, if the standard name doesn't
220 exist, search /dev for one rather than using a temp name.
221 - Allow --build to build raid1 and multipath arrays.
222 - Add "--assume-clean" for Create and Build, particularly for raid1
223 Note: this is dangerous. Only use it if you are certain.
224 - Fix bug so that Rebuild status monitoring works again.
225 - Add "degraded" and "recovering" options to the "Status:"
226 entry for --detail
227
228 Changes Prior to 1.5.0 release
229 - new commands "mdassemble" which is a stripped-down equivalent of
230 "mdadm -As", that can be compiled with dietlibc.
231 Thanks to Luca Berra <bluca@comedia.it>.
232 It can be using in an initramfs or initrd.
233 - Fix compiling error with BLKGETSIZE64 and some signed/unsigned
234 comparison warnings.
235 - Add Rebuild Status (% complete) to --detail output.
236 - Support "--monitor --test" which will generate a test alert
237 for each array once, to test notification paths.
238 - Generate RebuildFinished event when rebuild finishes.
239 - Support for raid6 as found in 2.6.2 - thanks to
240 H. Peter Anvin <hpa@zytor.com>
241 - Support partitioned md arrays with a different major number and
242 naming scheme (md_dX in /proc/mdstat, /dev/md/dXpY in /dev).
243
244 Changes Prior to 1.4.0 release
245 - Document fact that creating a raid5 array really creates a
246 degraded array with a spare.
247 - Add "spares=" tag to config file and generate it wit --detail and
248 --examine
249 - Add "SparesMissing" event when --monitor first sees an array and
250 it doesn't have the enough spare devices.
251 - Add --update=summaries for --assemble to update summary
252 information in superblock, and correct other inconsistancies in
253 the superblock.
254 - Add --test option to --detail to set a meaningful exit status.
255
256 Changes Prior to 1.3.0 release
257 - Make 'size' and unsigned long in Create to allow creation of
258 larger arrays.
259 - Explicitly flag spare devices as 'spare' in --detail and --examine
260 output. Previously they simply had no flags lists.
261 - Make MailCmd (for monitor) configurable in Makefile, and default
262 to "/usr/sbin/sendmail -t". Also split out the warning related
263 flags into CWFLAGS for easier build configurability.
264 - Minor bugfix in Manage code.
265 - --monitor now notices and reports degraded arrays at startup using
266 "DegradedArray" event, and also has a --oneshot option to only
267 report DegradedArrays, and then exit.
268 - Small man-page clarification w.r.t. raid levels and raid4 in
269 particular.
270 - Disallow creation of arrays with only one device as this is
271 probably a mistake. --force will override this check.
272 - Correct some misleading documentation in the "mdadm --create --help"
273 message.
274 - Ignore chunksize if raid1 or multipath.
275 - Explicit statement in man page that raid-disks cannot be changed
276 after array is created.
277 - Improve message when attempting to start an array with
278 insufficient devices. Instead of required the array to be full,
279 we only require it has as many active devices as last time.
280
281 Changes Prior to 1.2.0 release
282 - Fix bug where --daemonise required an argument.
283 - In --assemble --verbose, print appropriate message if device is
284 not in devices= list
285 - Updated mdadm.conf.5 to reflect fact that device= takes wildcards
286 - Typos: componenet -> component
287 - Reduce size of "--help" message put excess into "--help-options"
288 - Fix bug introduced when MD_SB_DISKS dependancy removed, and which
289 caused spares not be assembled properly.
290 - Print appropriate message if --monitor --scan decides not to
291 monitor anything.
292 Changes Prior to 1.1.0 release
293 - add --deamonise flag for --monitor - forks and prints pid to stdout
294 - Fix bug so we REALLY clear dirty flag with -Af
295 - -Db now prints a 'devices=' word for each array.
296 - "mdadm -A /dev/md0" will get info from configfile, even without scan
297 - When assembling multipath arrays, ignore devices which are flagged
298 as having errors.
299 - take --super-minor=dev to mean "use the minor number of the mddev
300 being assembled.
301 - take --config=none to mean "completely ignore config file"
302 - Make --monitor require --scan or a device list.
303 Changes Prior to 1.0.9 release
304 - Documentation updates including kernel parameters documented
305 in md.4
306 - --assemble --force for raid4/5 will mark clean, needed for 2.5
307 - --detail prints out the events counter as well
308 - flush device before reading superblock to be sure to get
309 current data
310 - added mdadm.static target to makefile for static linking
311 - --monitor was ignoring /dev/md0 due to off-by-one error
312 - Fix assorted typos
313 - Fix printing of Gibibytes - calc was wrong.
314 - Fix printing of Array Size in --detail when very big.
315 - --monitor no longer tries to work for raid0 or linear as these
316 have nothing to be monitored.
317 - The word 'partitions' on a DEVICE line will cause all partitions
318 listed in /proc/partitions to be considered
319 - If the config file is called 'partitions' then it will be treated
320 as though it contained exactly 'device partitions' so e.g.
321 mdadm -Ebsc partitions
322 will find all raid partitions easily.
323 - successfully assemble multipath devices by ignoring raid_disk
324 value from superblock (it is always the same).
325 - --assemble not tied to MD_SB_DISKS limit quite so much
326 - Support compiling with tcc
327 - Support compiling with uclibc - just skip scan of /dev
328 - Add --update= option for Assemble mode. Either sparc2.2
329 or super-minor updates are possible. See mdadm.8
330
331 Changes Prior to 1.0.1 release
332 - Round off MB/GiB etc values instead of round down.
333 - Add --sparc2.2 option to examine to shift superblock around
334 and --sparc2.2update to rewrite the superblock
335 - Fix assorted typos in online help
336
337 Changes Prior to 1.0.0 release
338 - Allow --config with Misc mode (for --examine --scan)
339 - Add $(CXFLAGS) to end of CFLAGS in makefile
340 - When making an N disk raid5 array, the Nth drive
341 is moved to the end of the array as a spare rather than
342 being shifted up one place. This means that when the
343 kernel builds onto the last spare and inserts it,
344 the devices will be in the expected order.
345 - Man page improvements
346 Changes Prior to 0.8.2 release
347 - Correct spelling of persist[ae]nce/persist[ae]nt.
348 - Change "disk" to "device" in options and config file
349 - convert array size to "long long" *before* shift-left in -D and -Q
350
351 Changes Prior to 0.8.1 release
352 - Add "INSTALL" file.
353 - Fix some "i" variables that were not being set properly
354 - Initialise minsize and maxsize so that compilers don't complain.
355 - Tidy up Makefile and mdadm.spec installations
356 - Add "multipath" to documentation of valid levels
357
358 Changes Prior to 0.8 release
359 - Fix another bug in Assemble.c due to confusing 'i' with 'j'
360 - Minimal, untested, support for multipath
361 - re-write of argument parsing to have more coherent modes,
362 - add --query,-Q option
363 - Update mdadm.8 to reflect arg processing change and --query
364 - Change "long" to "unsigned long" for device sizes
365 - Handle "mailaddr" and "program" lines in config file for follow/scan mode.
366 - --follow --scan will exit if no program or mail found
367 - Add MAILADDR and PROGRAM to mdadm.conf-example
368 - Spell check man pages
369 - consistently use "component devices" instead of "subdevices"
370 - Make -Wall -Werror really work and fix lots of errors.
371 - --detail and --stop can have --scan which chooses devices from /proc/mdstat
372 - --monitor detects 20% changes in resync, failed spares,
373 disappearing arrays,
374 - --monitor --scan will automatically add any devices found in /proc/mdstat
375 - --monitor will move spares between arrays with same spare-group if necessary
376 - Documentation for Monitor Mode
377 - --query notes if the array containing the given device is active or not
378 - Finished md.4 man page.
379
380 Changes Prior to 0.7.2 release
381 - mdadm.spec updates and ifdef BLKGETSIZE64 from Luca Berra -- bluca@comedia.it
382 - more mdadm.spec updates from Gregory Leblanc <gleblanc@linuxweasel.com>
383 - make directory for mdadm.conf configurable in Makefile
384 - Finished mdadm.conf.5. Removed details of conf file from
385 mdadm.8 leaving a reference to mdadm.conf.5.
386 - Fix bug in Assemble.c, thanks to Junaid Rizvi <domdev@sat.net.pk>
387 - Get --assemble --force to make sure old major/minor numbers are
388 consistant, as md.c worries about this :-(
389
390
391 Changes Prior to 0.7.1 release
392 - update mdadm.spec
393 - use BLKGETSIZE64 if available for array size
394 - give human readable as GiB/MiB and GB and MB, with 2 decimal point precision
395 - Only warn about size variation for raid1/4/5.
396 - Started md.4 man page
397 - Started mdadm.conf.5 man page
398
399 Changes Prior to 0.7 release
400
401 - Fix makefile to install binary at /sbin and not /sbin/sbin
402 Also install man page.
403 - Add --zero-superblock based on --destroywithextremeprejudice
404 from Dale Stephenson <steph@snapserver.com>
405 - change name to mdadm. It is palandromic, and much nicer to pronouce.
406
407 Changes Prior to 0.6 release
408
409 - Remove the limit on the number of device names that can be
410 given on the command line.
411 - Fix bug in --assemble --force where it would only update a
412 single superblock.
413 - Fix bogus printing of big numbers not being block devices
414 when given names of devices that don't exist.
415 - When --assemble --force, consider superblocks with an event
416 count that is 1 behind as out-of-date. Normally they are
417 considered up-to-date (as the kernel assumes this too).
418 - When marking drives as not-failed in the superblock,
419 we also mark them as ACTIVE and SYNC.
420 - Don't start arrays for which not all drives are available unless:
421 --scan which implies that all drives were found automatically
422 --run which means the user knows what they want
423 --force which means that we are fixing something broken
424 - Make sure all device numbers passed as 3rd arg of ioctl
425 are passed as unsigned lock, so that it works on SPARC
426 - If HOT_ADD_DISK failes for -a, then only try ADD_NEW_DISK
427 if we cannot read from the array, i.e. if the array is
428 not started yet.
429 - man page update
430 - Taught Examine to handle --scan. It examines all devices listed
431 on DEVICE lines in the config file.
432 - Added --brief (-b) flag for Examine and Detail to print out
433 and mdctl.conf compatible description with uuid=, level=,
434 disks= and - for Examine - devices=
435 --examine --brief collects all devices the make the one array and
436 list them as one entry.
437 - Added level= and disks= options to ARRAY lines in config files
438 so --brief output could be used as-is.
439 - Make parity style ({left,right}-{,a}symmetric) consistantly use -,
440 never _.
441 - Add "Array Size" to --detail output
442 - Change "Size" to "Device Size" and exclude from Detail of arrays
443 that do not have a consistent device size.
444 - Add Human readable MiB or GiB value on size lines of Detail and Examine
445 - --assemble --scan doesn't complain about active drives
446 - require number of spares given in -x to be listed.
447 - Made --build actually work.
448 Changes Prior to 0.5 release
449
450 --assemble:
451 spare drives are handled properly.
452
453 --force can be used to recover from 2-drive failures on RAID5
454 If you belive that /dev/hda1 /dev/hdb1 /dev/hdc1 /dev/hdd1 should
455 make a raid5 array, but it has experienced multiple failures and
456 wont start, then
457
458 mdctl --assemble --force /dev/md0 /dev/hd[abcd]1
459
460 Should update the superblock on the newest failed drive and
461 restart the array in degraded mode. You should then remove the
462 remaining failed drive and re-add it (if you are happy that it
463 might work).
464
465 Ofcourse whenever you have a 2-drive failure, you have a risk
466 of corruption in data that hasn't be changed for a long time. So
467 this doesn't give you your array back all nice and happy, but it
468 does allow you to recover data that might not be corrupt.
469
470 More flexibility in identifying a RAID array in the mdctl.conf
471 e.g.
472 array /dev/md4 super-minor=4
473
474 assembles /dev/md4 from all devices found that have a raid
475 superblock that says the minor number of the array is 4.
476 If the blocks with the right minor number do not all have the
477 same UUID, an error is flags and no assembly happens.
478
479 array /dev/md3 devices=/dev/hd[abc]2
480
481 Assembles /dev/md3 drom /dev/hda2 /dev/hdb2 and/dev/hdc2. All
482 devices must exist and have raid superblock with the same uuid.
483
484 If two identity specifiers are used, only devices that match all
485 of them are considered, so
486
487 array /dev/md2 devices=/dev/hd?2 super-minor=2
488
489 will assemble /dev/md2 using all /dev/hd?2 devices which have a
490 raid superblock with minor number 2.
491
492 --create:
493 When listing devices for --create, the word "missing" can be
494 used to indicate that the respective slot does not have a
495 working drive currently. This is similar to the "failed-disk"
496 directive in mkraid/raidtab.
497 e.g.
498 mdctl --create --level=5 -raid-disks=4 --spare-disks=2
499 /dev/md0 /dev/sda /dev/sdb missing /dev/sdc /dev/sdd /dev/sde
500
501 will create a raid5 array with the third slot empty, and two
502 spares.
503
504 By default, raid5 arrays are created with the last slot empty
505 and drive listed for the last slot added as a spare. If a
506 "missing" slot is given, or if --force is given, then --create
507 does exactly what you ask and doesn't try to be clever.
508
509
510 --follow / --monitor:
511
512 This is a new mode. I couldn't stop my self from picking a name
513 starting with F (as current modes start A,B,C,D,E) but I
514 relented and provided an alternate name that is somewhat more
515 meaningful.
516
517 In this mode, mdctl does not exit, but runs continuously and
518 periodically polls all the md devices to see if they have had
519 any interested state change.
520 The changes that it currently notices are:
521 Fail - an active disc fails
522 FailSpare - a spare, that was presumably being build, fails
523 ActiveSpare - a spare becomes active, presumably after a rebuild.
524
525 Options:
526 --mail mailaddress - send Email on any Fail* event
527 --program program - run the program on any event.
528 Args are: eventname mddevice subdevice(if-known)
529 --delay seconds - change from the default 60second pause
530 between polls.
531
532 I plan to add functionality to this mode to allow sharing of
533 spare drives. If an array is marks "spare-group=fred", and it
534 has a failed drive and no spares, and if some other array is
535 also "spare-group=fred" and it has no failed drives, but does
536 have a spare drive that is big enough, the spare will be moved
537 to the first array.
538
539 I also have the idea of adding a --grow mode which will re-organise
540 the data on an N disk raid0/4/5 array to be on an N+M disk array.
541 I have no concrete plans for this though.
542
543 I got rid of the "v" in the archive file name, and include the
544 version number in the directory created by the archive.
545
546 There is now a man page and mdctl.spec (for rpm) thanks to
547 Danilo Godec <danci@agenda.si>.
548
549 Ofcourse, the man page is now out of date and despite being based on
550 the --help output, is not wholy correct. After I get --follow
551 working properly, I plan to revise the various documentation and/or
552 the code to make sure the two match.