]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - Build.c
sysfs: Use the presence of /sys/block/<dev>/md as indicator of valid device
[thirdparty/mdadm.git] / Build.c
diff --git a/Build.c b/Build.c
index 7f3925864731bf63e0c1c1a10357a3476a95a2fe..691dd6f954f5ca6b23df0644780061c60633abf3 100644 (file)
--- a/Build.c
+++ b/Build.c
 
 #include "mdadm.h"
 
-#define REGISTER_DEV           _IO (MD_MAJOR, 1)
-#define START_MD               _IO (MD_MAJOR, 2)
-#define STOP_MD                _IO (MD_MAJOR, 3)
+#define REGISTER_DEV           _IO (MD_MAJOR, 1)
+#define START_MD               _IO (MD_MAJOR, 2)
+#define STOP_MD                        _IO (MD_MAJOR, 3)
 
-int Build(char *mddev, int chunk, int level, int layout,
-         int raiddisks, mddev_dev_t devlist, int assume_clean,
-         char *bitmap_file, int bitmap_chunk, int write_behind,
-         int delay, int verbose, int autof, unsigned long long size)
+int Build(char *mddev, struct mddev_dev *devlist,
+         struct shape *s, struct context *c)
 {
        /* Build a linear or raid0 arrays without superblocks
         * We cannot really do any checks, we just do it.
@@ -50,7 +48,7 @@ int Build(char *mddev, int chunk, int level, int layout,
        int vers;
        struct stat stb;
        int subdevs = 0, missing_disks = 0;
-       mddev_dev_t dv;
+       struct mddev_dev *dv;
        int bitmap_fd;
        unsigned long long bitmapsize;
        int mdfd;
@@ -58,6 +56,10 @@ int Build(char *mddev, int chunk, int level, int layout,
        int uuid[4] = {0,0,0,0};
        struct map_ent *map = NULL;
 
+       if (s->level == UnSet) {
+               pr_err("a RAID level is needed to Build an array.\n");
+               return 1;
+       }
        /* scan all devices, make sure they really are block devices */
        for (dv = devlist; dv; dv=dv->next) {
                subdevs++;
@@ -66,53 +68,50 @@ int Build(char *mddev, int chunk, int level, int layout,
                        continue;
                }
                if (stat(dv->devname, &stb)) {
-                       fprintf(stderr, Name ": Cannot find %s: %s\n",
+                       pr_err("Cannot find %s: %s\n",
                                dv->devname, strerror(errno));
                        return 1;
                }
                if ((stb.st_mode & S_IFMT) != S_IFBLK) {
-                       fprintf(stderr, Name ": %s is not a block device.\n",
+                       pr_err("%s is not a block device.\n",
                                dv->devname);
                        return 1;
                }
        }
 
-       if (raiddisks != subdevs) {
-               fprintf(stderr, Name ": requested %d devices in array but listed %d\n",
-                       raiddisks, subdevs);
+       if (s->raiddisks != subdevs) {
+               pr_err("requested %d devices in array but listed %d\n",
+                       s->raiddisks, subdevs);
                return 1;
        }
 
-       if (layout == UnSet)
-               switch(level) {
+       if (s->layout == UnSet)
+               switch(s->level) {
                default: /* no layout */
-                       layout = 0;
+                       s->layout = 0;
                        break;
                case 10:
-                       layout = 0x102; /* near=2, far=1 */
-                       if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to n1\n");
+                       s->layout = 0x102; /* near=2, far=1 */
+                       if (c->verbose > 0)
+                               pr_err("layout defaults to n1\n");
                        break;
                case 5:
                case 6:
-                       layout = map_name(r5layout, "default");
-                       if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to %s\n", map_num(r5layout, layout));
+                       s->layout = map_name(r5layout, "default");
+                       if (c->verbose > 0)
+                               pr_err("layout defaults to %s\n", map_num(r5layout, s->layout));
                        break;
                case LEVEL_FAULTY:
-                       layout = map_name(faultylayout, "default");
+                       s->layout = map_name(faultylayout, "default");
 
-                       if (verbose > 0)
-                               fprintf(stderr,
-                                       Name ": layout defaults to %s\n", map_num(faultylayout, layout));
+                       if (c->verbose > 0)
+                               pr_err("layout defaults to %s\n", map_num(faultylayout, s->layout));
                        break;
                }
 
        /* We need to create the device.  It can have no name. */
        map_lock(&map);
-       mdfd = create_mddev(mddev, NULL, autof, LOCAL,
+       mdfd = create_mddev(mddev, NULL, c->autof, LOCAL,
                            chosen_name);
        if (mdfd < 0) {
                map_unlock(&map);
@@ -120,7 +119,7 @@ int Build(char *mddev, int chunk, int level, int layout,
        }
        mddev = chosen_name;
 
-       map_update(&map, fd2devnum(mdfd), "none", uuid, chosen_name);
+       map_update(&map, fd2devnm(mdfd), "none", uuid, chosen_name);
        map_unlock(&map);
 
        vers = md_get_version(mdfd);
@@ -128,38 +127,42 @@ int Build(char *mddev, int chunk, int level, int layout,
        /* looks Ok, go for it */
        if (vers >= 9000) {
                mdu_array_info_t array;
-               array.level = level;
-               array.size = size;
-               array.nr_disks = raiddisks;
-               array.raid_disks = raiddisks;
+               array.level = s->level;
+               if (s->size == MAX_SIZE)
+                       s->size = 0;
+               array.size = s->size;
+               array.nr_disks = s->raiddisks;
+               array.raid_disks = s->raiddisks;
                array.md_minor = 0;
                if (fstat(mdfd, &stb)==0)
                        array.md_minor = minor(stb.st_rdev);
                array.not_persistent = 1;
                array.state = 0; /* not clean, but no errors */
-               if (assume_clean)
+               if (s->assume_clean)
                        array.state |= 1;
-               array.active_disks = raiddisks - missing_disks;
-               array.working_disks = raiddisks - missing_disks;
+               array.active_disks = s->raiddisks - missing_disks;
+               array.working_disks = s->raiddisks - missing_disks;
                array.spare_disks = 0;
                array.failed_disks = missing_disks;
-               if (chunk == 0 && (level==0 || level==LEVEL_LINEAR))
-                       chunk = 64;
-               array.chunk_size = chunk*1024;
-               array.layout = layout;
-               if (ioctl(mdfd, SET_ARRAY_INFO, &array)) {
-                       fprintf(stderr, Name ": SET_ARRAY_INFO failed for %s: %s\n",
+               if (s->chunk == 0 && (s->level==0 || s->level==LEVEL_LINEAR))
+                       s->chunk = 64;
+               array.chunk_size = s->chunk*1024;
+               array.layout = s->layout;
+               if (md_set_array_info(mdfd, &array)) {
+                       pr_err("md_set_array_info() failed for %s: %s\n",
                                mddev, strerror(errno));
                        goto abort;
                }
-       } else if (bitmap_file) {
-               fprintf(stderr, Name ": bitmaps not supported with this kernel\n");
+       } else if (s->bitmap_file) {
+               pr_err("bitmaps not supported with this kernel\n");
                goto abort;
        }
 
-       if (bitmap_file && level <= 0) {
-               fprintf(stderr, Name ": bitmaps not meaningful with level %s\n",
-                       map_num(pers, level)?:"given");
+       if (s->bitmap_file && strcmp(s->bitmap_file, "none") == 0)
+               s->bitmap_file = NULL;
+       if (s->bitmap_file && s->level <= 0) {
+               pr_err("bitmaps not meaningful with level %s\n",
+                       map_num(pers, s->level)?:"given");
                goto abort;
        }
        /* now add the devices */
@@ -169,42 +172,42 @@ int Build(char *mddev, int chunk, int level, int layout,
                if (strcmp("missing", dv->devname) == 0)
                        continue;
                if (stat(dv->devname, &stb)) {
-                       fprintf(stderr, Name ": Weird: %s has disappeared.\n",
+                       pr_err("Weird: %s has disappeared.\n",
                                dv->devname);
                        goto abort;
                }
                if ((stb.st_mode & S_IFMT)!= S_IFBLK) {
-                       fprintf(stderr, Name ": Wierd: %s is no longer a block device.\n",
+                       pr_err("Weird: %s is no longer a block device.\n",
                                dv->devname);
                        goto abort;
                }
                fd = open(dv->devname, O_RDONLY|O_EXCL);
                if (fd < 0) {
-                       fprintf(stderr, Name ": Cannot open %s: %s\n",
+                       pr_err("Cannot open %s: %s\n",
                                dv->devname, strerror(errno));
                        goto abort;
                }
                if (get_dev_size(fd, NULL, &dsize) &&
-                   (size == 0 || dsize < size))
-                               size = dsize;
+                   (s->size == 0 || s->size == MAX_SIZE || dsize < s->size))
+                               s->size = dsize;
                close(fd);
                if (vers >= 9000) {
                        mdu_disk_info_t disk;
                        disk.number = i;
                        disk.raid_disk = i;
                        disk.state = (1<<MD_DISK_SYNC) | (1<<MD_DISK_ACTIVE);
-                       if (dv->writemostly == 1)
+                       if (dv->writemostly == FlagSet)
                                disk.state |= 1<<MD_DISK_WRITEMOSTLY;
                        disk.major = major(stb.st_rdev);
                        disk.minor = minor(stb.st_rdev);
                        if (ioctl(mdfd, ADD_NEW_DISK, &disk)) {
-                               fprintf(stderr, Name ": ADD_NEW_DISK failed for %s: %s\n",
+                               pr_err("ADD_NEW_DISK failed for %s: %s\n",
                                        dv->devname, strerror(errno));
                                goto abort;
                        }
                } else {
                        if (ioctl(mdfd, REGISTER_DEV, &stb.st_rdev)) {
-                               fprintf(stderr, Name ": REGISTER_DEV failed for %s: %s.\n",
+                               pr_err("REGISTER_DEV failed for %s: %s.\n",
                                        dv->devname, strerror(errno));
                                goto abort;
                        }
@@ -213,67 +216,71 @@ int Build(char *mddev, int chunk, int level, int layout,
        /* now to start it */
        if (vers >= 9000) {
                mdu_param_t param; /* not used by syscall */
-               if (bitmap_file) {
-                       bitmap_fd = open(bitmap_file, O_RDWR);
+               if (s->bitmap_file) {
+                       bitmap_fd = open(s->bitmap_file, O_RDWR);
                        if (bitmap_fd < 0) {
                                int major = BITMAP_MAJOR_HI;
 #if 0
-                               if (bitmap_chunk == UnSet) {
-                                       fprintf(stderr, Name ": %s cannot be openned.",
-                                               bitmap_file);
+                               if (s->bitmap_chunk == UnSet) {
+                                       pr_err("%s cannot be openned.",
+                                               s->bitmap_file);
                                        goto abort;
                                }
 #endif
                                if (vers < 9003) {
                                        major = BITMAP_MAJOR_HOSTENDIAN;
 #ifdef __BIG_ENDIAN
-                                       fprintf(stderr, Name ": Warning - bitmaps created on this kernel are not portable\n"
+                                       pr_err("Warning - bitmaps created on this kernel are not portable\n"
                                                "  between different architectures.  Consider upgrading the Linux kernel.\n");
 #endif
                                }
-                               bitmapsize = size>>9; /* FIXME wrong for RAID10 */
-                               if (CreateBitmap(bitmap_file, 1, NULL, bitmap_chunk,
-                                                delay, write_behind, bitmapsize, major)) {
+                               bitmapsize = s->size>>9; /* FIXME wrong for RAID10 */
+                               if (CreateBitmap(s->bitmap_file, 1, NULL, s->bitmap_chunk,
+                                                c->delay, s->write_behind, bitmapsize, major)) {
                                        goto abort;
                                }
-                               bitmap_fd = open(bitmap_file, O_RDWR);
+                               bitmap_fd = open(s->bitmap_file, O_RDWR);
                                if (bitmap_fd < 0) {
-                                       fprintf(stderr, Name ": %s cannot be openned.",
-                                               bitmap_file);
+                                       pr_err("%s cannot be openned.",
+                                               s->bitmap_file);
                                        goto abort;
                                }
                        }
                        if (bitmap_fd >= 0) {
                                if (ioctl(mdfd, SET_BITMAP_FILE, bitmap_fd) < 0) {
-                                       fprintf(stderr, Name ": Cannot set bitmap file for %s: %s\n",
+                                       pr_err("Cannot set bitmap file for %s: %s\n",
                                                mddev, strerror(errno));
                                        goto abort;
                                }
                        }
                }
                if (ioctl(mdfd, RUN_ARRAY, &param)) {
-                       fprintf(stderr, Name ": RUN_ARRAY failed: %s\n",
+                       pr_err("RUN_ARRAY failed: %s\n",
                                strerror(errno));
+                       if (s->chunk & (s->chunk-1)) {
+                               cont_err("Problem may be that chunk size is not a power of 2\n");
+                       }
                        goto abort;
                }
        } else {
                unsigned long arg;
                arg=0;
-               while (chunk > 4096) {
+               while (s->chunk > 4096) {
                        arg++;
-                       chunk >>= 1;
+                       s->chunk >>= 1;
                }
-               if (level == 0)
-                       chunk |= 0x20000;
-               else    chunk |= 0x10000;
+               if (s->level == 0)
+                       arg |= 0x20000;
+               else
+                       arg |= 0x10000;
                if (ioctl(mdfd, START_MD, arg)) {
-                       fprintf(stderr, Name ": START_MD failed: %s\n",
+                       pr_err("START_MD failed: %s\n",
                                strerror(errno));
                        goto abort;
                }
        }
-       if (verbose >= 0)
-               fprintf(stderr, Name ": array %s built and started.\n",
+       if (c->verbose >= 0)
+               pr_err("array %s built and started.\n",
                        mddev);
        wait_for(mddev, mdfd);
        close(mdfd);