* Incremental.c - support --incremental. Part of:
* mdadm - manage Linux "md" devices aka RAID arrays.
*
- * Copyright (C) 2006-2009 Neil Brown <neilb@suse.de>
+ * Copyright (C) 2006-2012 Neil Brown <neilb@suse.de>
*
*
* This program is free software; you can redistribute it and/or modify
struct supertype *st, int verbose);
static int Incremental_container(struct supertype *st, char *devname,
- char *homehost,
- int verbose, int runstop, int autof,
- int freeze_reshape);
-
-static struct mddev_ident *search_mdstat(struct supertype *st,
- struct mdinfo *info,
- char *devname,
- int verbose, int *rvp);
-
-int Incremental(char *devname, int verbose, int runstop,
- struct supertype *st, char *homehost, int require_homehost,
- int autof, int freeze_reshape)
+ struct context *c);
+
+int Incremental(char *devname, struct context *c,
+ struct supertype *st)
{
/* Add this device to an array, creating the array if necessary
* and starting the array if sensible or - if runstop>0 - if possible.
struct createinfo *ci = conf_get_create_info();
if (stat(devname, &stb) < 0) {
- if (verbose >= 0)
- fprintf(stderr, Name ": stat failed for %s: %s.\n",
+ if (c->verbose >= 0)
+ pr_err("stat failed for %s: %s.\n",
devname, strerror(errno));
return rv;
}
if ((stb.st_mode & S_IFMT) != S_IFBLK) {
- if (verbose >= 0)
- fprintf(stderr, Name ": %s is not a block device.\n",
+ if (c->verbose >= 0)
+ pr_err("%s is not a block device.\n",
devname);
return rv;
}
- dfd = dev_open(devname, O_RDONLY|O_EXCL);
+ dfd = dev_open(devname, O_RDONLY);
if (dfd < 0) {
- if (verbose >= 0)
- fprintf(stderr, Name ": cannot open %s: %s.\n",
+ if (c->verbose >= 0)
+ pr_err("cannot open %s: %s.\n",
devname, strerror(errno));
return rv;
}
if (must_be_container(dfd)) {
if (!st)
st = super_by_fd(dfd, NULL);
+ if (st)
+ st->ignore_hw_compat = 1;
if (st && st->ss->load_container)
rv = st->ss->load_container(st, dfd, NULL);
close(dfd);
if (!rv && st->ss->container_content) {
if (map_lock(&map))
- fprintf(stderr, Name ": failed to get "
- "exclusive lock on mapfile\n");
- rv = Incremental_container(st, devname, homehost,
- verbose, runstop, autof,
- freeze_reshape);
+ pr_err("failed to get "
+ "exclusive lock on mapfile\n");
+ rv = Incremental_container(st, devname, c);
map_unlock(&map);
return rv;
}
- fprintf(stderr, Name ": %s is not part of an md array.\n",
+ pr_err("%s is not part of an md array.\n",
devname);
return rv;
}
/* 1/ Check if device is permitted by mdadm.conf */
if (!conf_test_dev(devname)) {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": %s not permitted by mdadm.conf.\n",
- devname);
+ if (c->verbose >= 0)
+ pr_err("%s not permitted by mdadm.conf.\n",
+ devname);
goto out;
}
* version/name from args) */
if (fstat(dfd, &stb) < 0) {
- if (verbose >= 0)
- fprintf(stderr, Name ": fstat failed for %s: %s.\n",
+ if (c->verbose >= 0)
+ pr_err("fstat failed for %s: %s.\n",
devname, strerror(errno));
goto out;
}
if ((stb.st_mode & S_IFMT) != S_IFBLK) {
- if (verbose >= 0)
- fprintf(stderr, Name ": %s is not a block device.\n",
+ if (c->verbose >= 0)
+ pr_err("%s is not a block device.\n",
devname);
goto out;
}
have_target = policy_check_path(&dinfo, &target_array);
if (st == NULL && (st = guess_super(dfd)) == NULL) {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": no recognisable superblock on %s.\n",
- devname);
+ if (c->verbose >= 0)
+ pr_err("no recognisable superblock on %s.\n",
+ devname);
rv = try_spare(devname, &dfd, policy,
have_target ? &target_array : NULL,
- st, verbose);
+ st, c->verbose);
goto out;
}
+ st->ignore_hw_compat = 1;
if (st->ss->compare_super == NULL ||
st->ss->load_super(st, dfd, NULL)) {
- if (verbose >= 0)
- fprintf(stderr, Name ": no RAID superblock on %s.\n",
+ if (c->verbose >= 0)
+ pr_err("no RAID superblock on %s.\n",
devname);
rv = try_spare(devname, &dfd, policy,
have_target ? &target_array : NULL,
- st, verbose);
+ st, c->verbose);
free(st);
goto out;
}
st->ss->getinfo_super(st, &info, NULL);
/* 3/ Check if there is a match in mdadm.conf */
- match = search_mdstat(st, &info, devname, verbose, &rv);
+ match = conf_match(st, &info, devname, c->verbose, &rv);
if (!match && rv == 2)
goto out;
if (match && match->devname
&& strcasecmp(match->devname, "<ignore>") == 0) {
- if (verbose >= 0)
- fprintf(stderr, Name ": array containing %s is explicitly"
+ if (c->verbose >= 0)
+ pr_err("array containing %s is explicitly"
" ignored by mdadm.conf\n",
devname);
goto out;
* on that. */
if (match)
trustworthy = LOCAL;
- else if (st->ss->match_home(st, homehost) == 1)
+ else if (st->ss->match_home(st, c->homehost) == 1)
trustworthy = LOCAL;
else if (st->ss->match_home(st, "any") == 1)
trustworthy = LOCAL_ANY;
else
trustworthy = FOREIGN;
-
if (!match && !conf_test_metadata(st->ss->name, policy,
(trustworthy == LOCAL))) {
- if (verbose >= 1)
- fprintf(stderr, Name
- ": %s has metadata type %s for which "
- "auto-assembly is disabled\n",
- devname, st->ss->name);
+ if (c->verbose >= 1)
+ pr_err("%s has metadata type %s for which "
+ "auto-assembly is disabled\n",
+ devname, st->ss->name);
goto out;
}
if (trustworthy == LOCAL_ANY)
* CREATE.
*/
if (match && match->autof)
- autof = match->autof;
- if (autof == 0)
- autof = ci->autof;
+ c->autof = match->autof;
+ if (c->autof == 0)
+ c->autof = ci->autof;
name_to_use = info.name;
if (name_to_use[0] == 0 &&
- info.array.level == LEVEL_CONTAINER &&
- trustworthy == LOCAL) {
+ info.array.level == LEVEL_CONTAINER) {
name_to_use = info.text_version;
trustworthy = METADATA;
}
if (name_to_use[0] && trustworthy != LOCAL &&
- ! require_homehost &&
+ ! c->require_homehost &&
conf_name_is_free(name_to_use))
trustworthy = LOCAL;
/* 4/ Check if array exists.
*/
if (map_lock(&map))
- fprintf(stderr, Name ": failed to get exclusive lock on "
+ pr_err("failed to get exclusive lock on "
"mapfile\n");
+ /* Now check we can get O_EXCL. If not, probably "mdadm -A" has
+ * taken over
+ */
+ dfd = dev_open(devname, O_RDONLY|O_EXCL);
+ if (dfd < 0) {
+ if (c->verbose >= 0)
+ pr_err("cannot reopen %s: %s.\n",
+ devname, strerror(errno));
+ goto out_unlock;
+ }
+ /* Cannot hold it open while we add the device to the array,
+ * so we must release the O_EXCL and depend on the map_lock()
+ */
+ close(dfd);
+ dfd = -1;
+
mp = map_by_uuid(&map, info.uuid);
if (mp)
mdfd = open_dev(mp->devnum);
/* Couldn't find an existing array, maybe make a new one */
mdfd = create_mddev(match ? match->devname : NULL,
- name_to_use, autof, trustworthy, chosen_name);
+ name_to_use, c->autof, trustworthy, chosen_name);
if (mdfd < 0)
- goto out;
+ goto out_unlock;
sysfs_init(&info, mdfd, 0);
if (set_array_info(mdfd, st, &info) != 0) {
- fprintf(stderr, Name ": failed to set array info for %s: %s\n",
+ pr_err("failed to set array info for %s: %s\n",
chosen_name, strerror(errno));
rv = 2;
- goto out;
+ goto out_unlock;
}
dinfo = info;
dinfo.disk.major = major(stb.st_rdev);
dinfo.disk.minor = minor(stb.st_rdev);
if (add_disk(mdfd, st, &info, &dinfo) != 0) {
- fprintf(stderr, Name ": failed to add %s to %s: %s.\n",
+ pr_err("failed to add %s to %s: %s.\n",
devname, chosen_name, strerror(errno));
ioctl(mdfd, STOP_ARRAY, 0);
rv = 2;
- goto out;
+ goto out_unlock;
}
sra = sysfs_read(mdfd, -1, (GET_DEVS | GET_STATE |
GET_OFFSET | GET_SIZE));
-
+
if (!sra || !sra->devs || sra->devs->disk.raid_disk >= 0) {
/* It really should be 'none' - must be old buggy
* kernel, and mdadm -I may not be able to complete.
* So reject it.
*/
ioctl(mdfd, STOP_ARRAY, NULL);
- fprintf(stderr, Name
- ": You have an old buggy kernel which cannot support\n"
- " --incremental reliably. Aborting.\n");
- sysfs_free(sra);
+ pr_err("You have an old buggy kernel which cannot support\n"
+ " --incremental reliably. Aborting.\n");
rv = 2;
- goto out;
+ goto out_unlock;
}
info.array.working_disks = 1;
/* 6/ Make sure /var/run/mdadm.map contains this array. */
sra = sysfs_read(mdfd, -1, (GET_DEVS | GET_STATE |
GET_OFFSET | GET_SIZE));
-
+
if (mp->path)
strcpy(chosen_name, mp->path);
else
&& (info.disk.state & (1<<MD_DISK_SYNC)) != 0
&& ! policy_action_allows(policy, st->ss->name,
act_re_add)
- && runstop < 1) {
+ && c->runstop < 1) {
if (ioctl(mdfd, GET_ARRAY_INFO, &ainf) == 0) {
- fprintf(stderr, Name
- ": not adding %s to active array (without --run) %s\n",
- devname, chosen_name);
+ pr_err("not adding %s to active array (without --run) %s\n",
+ devname, chosen_name);
rv = 2;
- goto out;
+ goto out_unlock;
}
}
if (!sra) {
rv = 2;
- goto out;
+ goto out_unlock;
}
if (sra->devs) {
sprintf(dn, "%d:%d", sra->devs->disk.major,
sra->devs->disk.minor);
dfd2 = dev_open(dn, O_RDONLY);
+ if (dfd2 < 0) {
+ pr_err("unable to open %s\n", devname);
+ rv = 2;
+ goto out_unlock;
+ }
st2 = dup_super(st);
if (st2->ss->load_super(st2, dfd2, NULL) ||
st->ss->compare_super(st, st2) != 0) {
- fprintf(stderr, Name
- ": metadata mismatch between %s and "
- "chosen array %s\n",
- devname, chosen_name);
+ pr_err("metadata mismatch between %s and "
+ "chosen array %s\n",
+ devname, chosen_name);
close(dfd2);
rv = 2;
- goto out;
+ goto out_unlock;
}
close(dfd2);
st2->ss->getinfo_super(st2, &info2, NULL);
if (info.array.level != info2.array.level ||
memcmp(info.uuid, info2.uuid, 16) != 0 ||
info.array.raid_disks != info2.array.raid_disks) {
- fprintf(stderr, Name
- ": unexpected difference between %s and %s.\n",
- chosen_name, devname);
+ pr_err("unexpected difference between %s and %s.\n",
+ chosen_name, devname);
rv = 2;
- goto out;
+ goto out_unlock;
}
}
- info2.disk.major = major(stb.st_rdev);
- info2.disk.minor = minor(stb.st_rdev);
+ info.disk.major = major(stb.st_rdev);
+ info.disk.minor = minor(stb.st_rdev);
/* add disk needs to know about containers */
if (st->ss->external)
sra->array.level = LEVEL_CONTAINER;
- err = add_disk(mdfd, st, sra, &info2);
+ err = add_disk(mdfd, st, sra, &info);
if (err < 0 && errno == EBUSY) {
/* could be another device present with the same
* disk.number. Find and reject any such
*/
find_reject(mdfd, st, sra, info.disk.number,
- info.events, verbose, chosen_name);
- err = add_disk(mdfd, st, sra, &info2);
+ info.events, c->verbose, chosen_name);
+ err = add_disk(mdfd, st, sra, &info);
}
if (err < 0) {
- fprintf(stderr, Name ": failed to add %s to %s: %s.\n",
+ pr_err("failed to add %s to %s: %s.\n",
devname, chosen_name, strerror(errno));
rv = 2;
- goto out;
+ goto out_unlock;
}
info.array.working_disks = 0;
for (d = sra->devs; d; d=d->next)
info.array.working_disks ++;
-
+
}
/* 7/ Is there enough devices to possibly start the array? */
if (info.array.level == LEVEL_CONTAINER) {
int devnum = devnum; /* defined and used iff ->external */
/* Try to assemble within the container */
- if (verbose >= 0)
- fprintf(stderr, Name
- ": container %s now has %d devices\n",
- chosen_name, info.array.working_disks);
+ sysfs_uevent(sra, "change");
+ if (c->verbose >= 0)
+ pr_err("container %s now has %d device%s\n",
+ chosen_name, info.array.working_disks,
+ info.array.working_disks == 1?"":"s");
wait_for(chosen_name, mdfd);
if (st->ss->external)
devnum = fd2devnum(mdfd);
close(mdfd);
sysfs_free(sra);
if (!rv)
- rv = Incremental_container(st, chosen_name, homehost,
- verbose, runstop, autof,
- freeze_reshape);
+ rv = Incremental_container(st, chosen_name, c);
map_unlock(&map);
if (rv == 1)
/* Don't fail the whole -I if a subarray didn't
active_disks = count_active(st, sra, mdfd, &avail, &info);
if (enough(info.array.level, info.array.raid_disks,
info.array.layout, info.array.state & 1,
- avail, active_disks) == 0) {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": %s attached to %s, not enough to start (%d).\n",
- devname, chosen_name, active_disks);
- map_unlock(&map);
+ avail) == 0) {
+ if (c->verbose >= 0)
+ pr_err("%s attached to %s, not enough to start (%d).\n",
+ devname, chosen_name, active_disks);
rv = 0;
- goto out;
+ goto out_unlock;
}
/* 7b/ if yes, */
/* + start the array (auto-readonly). */
if (ioctl(mdfd, GET_ARRAY_INFO, &ainf) == 0) {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": %s attached to %s which is already active.\n",
- devname, chosen_name);
- map_unlock(&map);
+ if (c->verbose >= 0)
+ pr_err("%s attached to %s which is already active.\n",
+ devname, chosen_name);
rv = 0;
- goto out;
+ goto out_unlock;
}
map_unlock(&map);
- if (runstop > 0 || active_disks >= info.array.working_disks) {
+ if (c->runstop > 0 || active_disks >= info.array.working_disks) {
struct mdinfo *dsk;
/* Let's try to start it */
+
+ if (info.reshape_active && !(info.reshape_active & RESHAPE_NO_BACKUP)) {
+ fprintf(stderr, Name
+ ": %s: This array is being reshaped and cannot be started\n"
+ " by --incremental. Please use --assemble\n",
+ chosen_name);
+ goto out;
+ }
if (match && match->bitmap_file) {
int bmfd = open(match->bitmap_file, O_RDWR);
if (bmfd < 0) {
- fprintf(stderr, Name
- ": Could not open bitmap file %s.\n",
- match->bitmap_file);
+ pr_err("Could not open bitmap file %s.\n",
+ match->bitmap_file);
goto out;
}
if (ioctl(mdfd, SET_BITMAP_FILE, bmfd) != 0) {
close(bmfd);
- fprintf(stderr, Name
- ": Failed to set bitmapfile for %s.\n",
- chosen_name);
+ pr_err("Failed to set bitmapfile for %s.\n",
+ chosen_name);
goto out;
}
close(bmfd);
rv = sysfs_set_str(sra, NULL,
"array_state", "read-auto");
if (rv == 0) {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": %s attached to %s, which has been started.\n",
- devname, chosen_name);
+ if (c->verbose >= 0)
+ pr_err("%s attached to %s, which has been started.\n",
+ devname, chosen_name);
rv = 0;
wait_for(chosen_name, mdfd);
/* We just started the array, so some devices
for (dsk = sra->devs; dsk ; dsk = dsk->next) {
if (disk_action_allows(dsk, st->ss->name, act_re_add) &&
add_disk(mdfd, st, sra, dsk) == 0)
- fprintf(stderr, Name
- ": %s re-added to %s\n",
- dsk->sys_name, chosen_name);
+ pr_err("%s re-added to %s\n",
+ dsk->sys_name, chosen_name);
}
} else {
- fprintf(stderr, Name
- ": %s attached to %s, but failed to start: %s.\n",
- devname, chosen_name, strerror(errno));
+ pr_err("%s attached to %s, but failed to start: %s.\n",
+ devname, chosen_name, strerror(errno));
rv = 1;
}
} else {
- if (verbose >= 0)
- fprintf(stderr, Name
- ": %s attached to %s, not enough to start safely.\n",
- devname, chosen_name);
+ if (c->verbose >= 0)
+ pr_err("%s attached to %s, not enough to start safely.\n",
+ devname, chosen_name);
rv = 0;
}
out:
if (sra)
sysfs_free(sra);
return rv;
-}
-
-static struct mddev_ident *search_mdstat(struct supertype *st,
- struct mdinfo *info,
- char *devname,
- int verbose, int *rvp)
-{
- struct mddev_ident *array_list, *match;
- array_list = conf_get_ident(NULL);
- match = NULL;
- for (; array_list; array_list = array_list->next) {
- if (array_list->uuid_set &&
- same_uuid(array_list->uuid, info->uuid, st->ss->swapuuid)
- == 0) {
- if (verbose >= 2 && array_list->devname)
- fprintf(stderr, Name
- ": UUID differs from %s.\n",
- array_list->devname);
- continue;
- }
- if (array_list->name[0] &&
- strcasecmp(array_list->name, info->name) != 0) {
- if (verbose >= 2 && array_list->devname)
- fprintf(stderr, Name
- ": Name differs from %s.\n",
- array_list->devname);
- continue;
- }
- if (array_list->devices &&
- !match_oneof(array_list->devices, devname)) {
- if (verbose >= 2 && array_list->devname)
- fprintf(stderr, Name
- ": Not a listed device for %s.\n",
- array_list->devname);
- continue;
- }
- if (array_list->super_minor != UnSet &&
- array_list->super_minor != info->array.md_minor) {
- if (verbose >= 2 && array_list->devname)
- fprintf(stderr, Name
- ": Different super-minor to %s.\n",
- array_list->devname);
- continue;
- }
- if (!array_list->uuid_set &&
- !array_list->name[0] &&
- !array_list->devices &&
- array_list->super_minor == UnSet) {
- if (verbose >= 2 && array_list->devname)
- fprintf(stderr, Name
- ": %s doesn't have any identifying information.\n",
- array_list->devname);
- continue;
- }
- /* FIXME, should I check raid_disks and level too?? */
-
- if (match) {
- if (verbose >= 0) {
- if (match->devname && array_list->devname)
- fprintf(stderr, Name
- ": we match both %s and %s - cannot decide which to use.\n",
- match->devname, array_list->devname);
- else
- fprintf(stderr, Name
- ": multiple lines in mdadm.conf match\n");
- }
- *rvp = 2;
- match = NULL;
- break;
- }
- match = array_list;
- }
- return match;
+out_unlock:
+ map_unlock(&map);
+ goto out;
}
static void find_reject(int mdfd, struct supertype *st, struct mdinfo *sra,
sysfs_set_str(sra, d, "slot", "none");
if (sysfs_set_str(sra, d, "state", "remove") == 0)
if (verbose >= 0)
- fprintf(stderr, Name
- ": removing old device %s from %s\n",
- d->sys_name+4, array_name);
+ pr_err("removing old device %s from %s\n",
+ d->sys_name+4, array_name);
}
}
/* count how many devices in sra think they are active */
struct mdinfo *d;
int cnt = 0;
+ int replcnt = 0;
__u64 max_events = 0;
char *avail = NULL;
int *best = NULL;
for (d = sra->devs ; d ; d = d->next)
numdevs++;
- for (d = sra->devs, devnum=0 ; d ; d = d->next, devnum++) {
+ for (d = sra->devs, devnum = 0 ; d ; d = d->next, devnum++) {
char dn[30];
int dfd;
int ok;
st->ss->getinfo_super(st, &info, devmap + raid_disks * devnum);
if (!avail) {
raid_disks = info.array.raid_disks;
- avail = calloc(raid_disks, 1);
- if (!avail) {
- fprintf(stderr, Name ": out of memory.\n");
- exit(1);
- }
+ avail = xcalloc(raid_disks, 1);
*availp = avail;
- best = calloc(raid_disks, sizeof(int));
- devmap = calloc(raid_disks * numdevs, 1);
+ best = xcalloc(raid_disks, sizeof(int));
+ devmap = xcalloc(raid_disks, numdevs);
st->ss->getinfo_super(st, &info, devmap);
}
else if (info.events == max_events+1) {
int i;
max_events = info.events;
- for (i=0; i < raid_disks; i++)
+ for (i = 0; i < raid_disks; i++)
if (avail[i])
avail[i]--;
avail[info.disk.raid_disk] = 2;
best[info.disk.raid_disk] = devnum;
st->ss->getinfo_super(st, bestinfo, NULL);
}
- }
+ } else if (info.disk.state & (1<<MD_DISK_REPLACEMENT))
+ replcnt++;
st->ss->free_super(st);
}
if (!avail)
}
free(best);
free(devmap);
- return cnt;
+ return cnt + replcnt;
}
/* test if container has degraded member(s) */
*/
if (map_lock(&map)) {
- fprintf(stderr, Name ": failed to get exclusive lock on "
+ pr_err("failed to get exclusive lock on "
"mapfile\n");
return 1;
}
(st->minor_version >= 0 &&
st->minor_version != st2->minor_version)) {
if (verbose > 1)
- fprintf(stderr, Name ": not adding %s to %s as metadata type doesn't match\n",
+ pr_err("not adding %s to %s as metadata type doesn't match\n",
devname, mp->path);
free(st2);
continue;
if (st == NULL) {
int i;
st2 = NULL;
- for(i=0; !st2 && superlist[i]; i++)
+ for(i = 0; !st2 && superlist[i]; i++)
st2 = superlist[i]->match_metadata_desc(
sra->text_version);
if (!st2) {
if (verbose > 1)
- fprintf(stderr, Name ": not adding %s to %s"
+ pr_err("not adding %s to %s"
" as metadata not recognised.\n",
devname, mp->path);
goto next;
* to obtain minimum spare size */
struct supertype *st3 = dup_super(st2);
int mdfd = open_dev(mp->devnum);
- if (!mdfd)
+ if (mdfd < 0) {
+ free(st3);
goto next;
+ }
if (st3->ss->load_container &&
!st3->ss->load_container(st3, mdfd, mp->path)) {
component_size = st3->ss->min_acceptable_spare_size(st3);
close(mdfd);
}
if ((sra->component_size > 0 &&
- st2->ss->avail_size(st2, devsize) < sra->component_size)
+ st2->ss->avail_size(st2, devsize,
+ sra->devs
+ ? sra->devs->data_offset
+ : INVALID_SECTORS)
+ < sra->component_size)
||
(sra->component_size == 0 && devsize < component_size)) {
if (verbose > 1)
- fprintf(stderr, Name ": not adding %s to %s as it is too small\n",
+ pr_err("not adding %s to %s as it is too small\n",
devname, mp->path);
goto next;
}
if (domain_test(dl, pol, st2->ss->name) != 1) {
/* domain test fails */
if (verbose > 1)
- fprintf(stderr, Name ": not adding %s to %s as"
+ pr_err("not adding %s to %s as"
" it is not in a compatible domain\n",
devname, mp->path);
char devname[20];
devlist.next = NULL;
devlist.used = 0;
- devlist.re_add = 0;
devlist.writemostly = 0;
devlist.devname = devname;
sprintf(devname, "%d:%d", major(stb.st_rdev),
}
if (verbose > 0) {
if (rv == 0)
- fprintf(stderr, Name ": added %s as spare for %s\n",
+ pr_err("added %s as spare for %s\n",
devname, chosen->sys_name);
else
- fprintf(stderr, Name ": failed to add %s as spare for %s\n",
+ pr_err("failed to add %s as spare for %s\n",
devname, chosen->sys_name);
}
sysfs_free(chosen);
close(fd);
}
+ closedir(dir);
+
if (!chosen)
return 1;
!policy_action_allows(pol, st?st->ss->name:NULL,
act_spare_same_slot)) {
if (verbose > 1)
- fprintf(stderr, Name ": %s is not bare, so not "
+ pr_err("%s is not bare, so not "
"considering as a spare\n",
devname);
return 1;
}
if (verbose >= 0) {
if (added == 0)
- fprintf(stderr, Name
- ": Added bitmap %s to %s\n",
- mddev->bitmap_file, me->path);
+ pr_err("Added bitmap %s to %s\n",
+ mddev->bitmap_file, me->path);
else if (errno != EEXIST)
- fprintf(stderr, Name
- ": Failed to add bitmap to %s: %s\n",
- me->path, strerror(errno));
+ pr_err("Failed to add bitmap to %s: %s\n",
+ me->path, strerror(errno));
}
}
+ /* FIXME check for reshape_active and consider not
+ * starting array.
+ */
sra = sysfs_read(mdfd, 0, 0);
if (sra) {
if (sysfs_set_str(sra, NULL,
"array_state", "read-auto") == 0) {
if (verbose >= 0)
- fprintf(stderr, Name
- ": started array %s\n",
- me->path ?: devnum2devname(me->devnum));
+ pr_err("started array %s\n",
+ me->path ?: devnum2devname(me->devnum));
} else {
- fprintf(stderr, Name
- ": failed to start array %s: %s\n",
- me->path ?: devnum2devname(me->devnum),
- strerror(errno));
+ pr_err("failed to start array %s: %s\n",
+ me->path ?: devnum2devname(me->devnum),
+ strerror(errno));
rv = 1;
}
+ sysfs_free(sra);
}
}
return rv;
} else {
int uuid[4];
struct map_ent *mp, *map = NULL;
-
+
if (!parse_uuid(devname, uuid))
return mdname;
mp = map_by_uuid(&map, uuid);
}
static int Incremental_container(struct supertype *st, char *devname,
- char *homehost, int verbose,
- int runstop, int autof, int freeze_reshape)
+ struct context *c)
{
/* Collect the contents of this container and for each
* array, choose a device name and assemble the array.
struct map_ent *smp;
int suuid[4];
int sfd;
+ int ra_blocked = 0;
+ int ra_all = 0;
st->ss->getinfo_super(st, &info, NULL);
- if ((runstop > 0 && info.container_enough >= 0) ||
+ if ((c->runstop > 0 && info.container_enough >= 0) ||
info.container_enough > 0)
/* pass */;
else {
- if (verbose)
- fprintf(stderr, Name ": not enough devices to start the container\n");
+ if (c->verbose)
+ pr_err("not enough devices to start the container\n");
return 0;
}
- match = search_mdstat(st, &info, devname, verbose, &rv);
+ match = conf_match(st, &info, devname, c->verbose, &rv);
if (match == NULL && rv == 2)
return rv;
/* Need to compute 'trustworthy' */
if (match)
trustworthy = LOCAL;
- else if (st->ss->match_home(st, homehost) == 1)
+ else if (st->ss->match_home(st, c->homehost) == 1)
trustworthy = LOCAL;
else if (st->ss->match_home(st, "any") == 1)
trustworthy = LOCAL;
trustworthy = FOREIGN;
list = st->ss->container_content(st, NULL);
- /* do not assemble arrays that might have bad blocks */
- if (list && list->array.state & (1<<MD_SB_BBM_ERRORS)) {
- fprintf(stderr, Name ": BBM log found in metadata. "
- "Cannot activate array(s).\n");
- /* free container data and exit */
- sysfs_free(list);
- return 2;
- }
-
+ /* when nothing to activate - quit */
+ if (list == NULL)
+ return 0;
for (ra = list ; ra ; ra = ra->next) {
int mdfd;
char chosen_name[1024];
struct map_ent *mp;
struct mddev_ident *match = NULL;
+ ra_all++;
+ /* do not activate arrays blocked by metadata handler */
+ if (ra->array.state & (1 << MD_SB_BLOCK_VOLUME)) {
+ pr_err("Cannot activate array %s in %s.\n",
+ ra->text_version, devname);
+ ra_blocked++;
+ continue;
+ }
mp = map_by_uuid(&map, ra->uuid);
if (mp) {
free(dn);
/* we have a match */
match = array_list;
- if (verbose>0)
- fprintf(stderr, Name ": match found for member %s\n",
+ if (c->verbose>0)
+ pr_err("match found for member %s\n",
array_list->member);
break;
}
if (match && match->devname &&
strcasecmp(match->devname, "<ignore>") == 0) {
- if (verbose > 0)
- fprintf(stderr, Name ": array %s/%s is "
- "explicitly ignored by mdadm.conf\n",
- match->container, match->member);
+ if (c->verbose > 0)
+ pr_err("array %s/%s is "
+ "explicitly ignored by mdadm.conf\n",
+ match->container, match->member);
return 2;
}
if (match)
mdfd = create_mddev(match ? match->devname : NULL,
ra->name,
- autof,
+ c->autof,
trustworthy,
chosen_name);
}
if (mdfd < 0) {
- fprintf(stderr, Name ": failed to open %s: %s.\n",
+ pr_err("failed to open %s: %s.\n",
chosen_name, strerror(errno));
return 2;
}
- assemble_container_content(st, mdfd, ra, runstop,
- chosen_name, verbose, NULL,
- freeze_reshape);
+ assemble_container_content(st, mdfd, ra, c,
+ chosen_name);
close(mdfd);
}
+ /* don't move spares to container with volume being activated
+ when all volumes are blocked */
+ if (ra_all == ra_blocked)
+ return 0;
+
/* Now move all suitable spares from spare container */
domains = domain_from_array(list, st->ss->name);
memcpy(suuid, uuid_zero, sizeof(int[4]));
disks = disks->next;
}
if (count)
- fprintf(stderr, Name
- ": Added %d spare%s to %s\n",
- count, count>1?"s":"", devname);
+ pr_err("Added %d spare%s to %s\n",
+ count, count>1?"s":"", devname);
}
sysfs_free(sinfo);
} else
"port\n");
if (strchr(devname, '/')) {
- fprintf(stderr, Name ": incremental removal requires a "
+ pr_err("incremental removal requires a "
"kernel device name, not a file: %s\n", devname);
return 1;
}
ent = mdstat_by_component(devname);
if (!ent) {
- fprintf(stderr, Name ": %s does not appear to be a component "
+ pr_err("%s does not appear to be a component "
"of any array\n", devname);
return 1;
}
mdfd = open_dev(ent->devnum);
if (mdfd < 0) {
- fprintf(stderr, Name ": Cannot open array %s!!\n", ent->dev);
+ pr_err("Cannot open array %s!!\n", ent->dev);
free_mdstat(ent);
return 1;
}
projects / thirdparty / mdadm.git / blobdiff