]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - mdadm.c
Grow: support consistency policy change
[thirdparty/mdadm.git] / mdadm.c
diff --git a/mdadm.c b/mdadm.c
index 8a758eab18d95cc2952b6696785c65d97d96a123..5ebf1175b5781871b17a14ea5ad73f09462e049e 100644 (file)
--- a/mdadm.c
+++ b/mdadm.c
@@ -78,6 +78,7 @@ int main(int argc, char *argv[])
                .level          = UnSet,
                .layout         = UnSet,
                .bitmap_chunk   = UnSet,
+               .consistency_policy     = UnSet,
        };
 
        char sys_hostname[256];
@@ -89,7 +90,8 @@ int main(int argc, char *argv[])
        int oneshot = 0;
        int spare_sharing = 1;
        struct supertype *ss = NULL;
-       int writemostly = 0;
+       enum flag_mode writemostly = FlagDefault;
+       enum flag_mode failfast = FlagDefault;
        char *shortopt = short_options;
        int dosyslog = 0;
        int rebuild_map = 0;
@@ -143,9 +145,9 @@ int main(int argc, char *argv[])
                        continue;
 
                case 'b':
-                       if (mode == ASSEMBLE || mode == BUILD || mode == CREATE
-                           || mode == GROW || mode == INCREMENTAL
-                           || mode == MANAGE)
+                       if (mode == ASSEMBLE || mode == BUILD ||
+                           mode == CREATE || mode == GROW ||
+                           mode == INCREMENTAL || mode == MANAGE)
                                break; /* b means bitmap */
                case Brief:
                        c.brief = 1;
@@ -190,6 +192,7 @@ int main(int argc, char *argv[])
                case 'a':
                case Add:
                case AddSpare:
+               case AddJournal:
                case 'r':
                case Remove:
                case Replace:
@@ -281,8 +284,8 @@ int main(int argc, char *argv[])
                } else {
                        /* special case of -c --help */
                        if ((opt == 'c' || opt == ConfigFile) &&
-                           ( strncmp(optarg, "--h", 3)==0 ||
-                             strncmp(optarg, "-h", 2)==0)) {
+                           (strncmp(optarg, "--h", 3) == 0 ||
+                            strncmp(optarg, "-h", 2) == 0)) {
                                fputs(Help_config, stdout);
                                exit(0);
                        }
@@ -294,6 +297,7 @@ int main(int argc, char *argv[])
                                        dv->devname = optarg;
                                        dv->disposition = devmode;
                                        dv->writemostly = writemostly;
+                                       dv->failfast = failfast;
                                        dv->used = 0;
                                        dv->next = NULL;
                                        *devlistend = dv;
@@ -350,6 +354,7 @@ int main(int argc, char *argv[])
                        dv->devname = optarg;
                        dv->disposition = devmode;
                        dv->writemostly = writemostly;
+                       dv->failfast = failfast;
                        dv->used = 0;
                        dv->next = NULL;
                        *devlistend = dv;
@@ -408,12 +413,20 @@ int main(int argc, char *argv[])
                case O(CREATE,'W'):
                case O(CREATE,WriteMostly):
                        /* set write-mostly for following devices */
-                       writemostly = 1;
+                       writemostly = FlagSet;
                        continue;
 
                case O(MANAGE,'w'):
                        /* clear write-mostly for following devices */
-                       writemostly = 2;
+                       writemostly = FlagClear;
+                       continue;
+
+               case O(MANAGE,FailFast):
+               case O(CREATE,FailFast):
+                       failfast = FlagSet;
+                       continue;
+               case O(MANAGE,NoFailFast):
+                       failfast = FlagClear;
                        continue;
 
                case O(GROW,'z'):
@@ -423,14 +436,12 @@ int main(int argc, char *argv[])
                                pr_err("size may only be specified once. Second value is %s.\n", optarg);
                                exit(2);
                        }
-                       if (strcmp(optarg, "max")==0)
+                       if (strcmp(optarg, "max") == 0)
                                s.size = MAX_SIZE;
                        else {
                                s.size = parse_size(optarg);
-                               if (s.size == INVALID_SECTORS ||
-                                   s.size < 8) {
-                                       pr_err("invalid size: %s\n",
-                                               optarg);
+                               if (s.size == INVALID_SECTORS || s.size < 8) {
+                                       pr_err("invalid size: %s\n", optarg);
                                        exit(2);
                                }
                                /* convert sectors to K */
@@ -462,8 +473,7 @@ int main(int argc, char *argv[])
                                pr_err("data-offset may only be specified one. Second value is %s.\n", optarg);
                                exit(2);
                        }
-                       if (mode == CREATE &&
-                           strcmp(optarg, "variable") == 0)
+                       if (mode == CREATE && strcmp(optarg, "variable") == 0)
                                data_offset = VARIABLE_OFFSET;
                        else
                                data_offset = parse_size(optarg);
@@ -487,9 +497,9 @@ int main(int argc, char *argv[])
                                        optarg);
                                exit(2);
                        }
-                       if (s.level != 0 && s.level != LEVEL_LINEAR && s.level != 1 &&
-                           s.level != LEVEL_MULTIPATH && s.level != LEVEL_FAULTY &&
-                           s.level != 10 &&
+                       if (s.level != 0 && s.level != LEVEL_LINEAR &&
+                           s.level != 1 && s.level != LEVEL_MULTIPATH &&
+                           s.level != LEVEL_FAULTY && s.level != 10 &&
                            mode == BUILD) {
                                pr_err("Raid level %s not permitted with --build.\n",
                                        optarg);
@@ -591,10 +601,11 @@ int main(int argc, char *argv[])
                        ident.raid_disks = s.raiddisks;
                        continue;
                case O(ASSEMBLE, Nodes):
+               case O(GROW, Nodes):
                case O(CREATE, Nodes):
                        c.nodes = parse_num(optarg);
-                       if (c.nodes <= 0) {
-                               pr_err("invalid number for the number of cluster nodes: %s\n",
+                       if (c.nodes < 2) {
+                               pr_err("clustered array needs two nodes at least: %s\n",
                                        optarg);
                                exit(2);
                        }
@@ -701,7 +712,7 @@ int main(int argc, char *argv[])
                                pr_err("super-minor cannot be set twice.  Second value: %s.\n", optarg);
                                exit(2);
                        }
-                       if (strcmp(optarg, "dev")==0)
+                       if (strcmp(optarg, "dev") == 0)
                                ident.super_minor = -2;
                        else {
                                ident.super_minor = parse_num(optarg);
@@ -730,32 +741,38 @@ int main(int argc, char *argv[])
                                exit(2);
                        }
                        c.update = optarg;
-                       if (strcmp(c.update, "sparc2.2")==0)
+                       if (strcmp(c.update, "sparc2.2") == 0)
                                continue;
                        if (strcmp(c.update, "super-minor") == 0)
                                continue;
-                       if (strcmp(c.update, "summaries")==0)
+                       if (strcmp(c.update, "summaries") == 0)
                                continue;
-                       if (strcmp(c.update, "resync")==0)
+                       if (strcmp(c.update, "resync") == 0)
                                continue;
-                       if (strcmp(c.update, "uuid")==0)
+                       if (strcmp(c.update, "uuid") == 0)
                                continue;
-                       if (strcmp(c.update, "name")==0)
+                       if (strcmp(c.update, "name") == 0)
                                continue;
-                       if (strcmp(c.update, "homehost")==0)
+                       if (strcmp(c.update, "homehost") == 0)
                                continue;
-                       if (strcmp(c.update, "home-cluster")==0)
+                       if (strcmp(c.update, "home-cluster") == 0)
                                continue;
-                       if (strcmp(c.update, "nodes")==0)
+                       if (strcmp(c.update, "nodes") == 0)
                                continue;
-                       if (strcmp(c.update, "devicesize")==0)
+                       if (strcmp(c.update, "devicesize") == 0)
                                continue;
-                       if (strcmp(c.update, "no-bitmap")==0)
+                       if (strcmp(c.update, "no-bitmap") == 0)
                                continue;
                        if (strcmp(c.update, "bbl") == 0)
                                continue;
                        if (strcmp(c.update, "no-bbl") == 0)
                                continue;
+                       if (strcmp(c.update, "force-no-bbl") == 0)
+                               continue;
+                       if (strcmp(c.update, "ppl") == 0)
+                               continue;
+                       if (strcmp(c.update, "no-ppl") == 0)
+                               continue;
                        if (strcmp(c.update, "metadata") == 0)
                                continue;
                        if (strcmp(c.update, "revert-reshape") == 0)
@@ -789,7 +806,7 @@ int main(int argc, char *argv[])
                "     'sparc2.2', 'super-minor', 'uuid', 'name', 'nodes', 'resync',\n"
                "     'summaries', 'homehost', 'home-cluster', 'byteorder', 'devicesize',\n"
                "     'no-bitmap', 'metadata', 'revert-reshape'\n"
-               "     'bbl', 'no-bbl'\n"
+               "     'bbl', 'no-bbl', 'force-no-bbl', 'ppl', 'no-ppl'\n"
                                );
                        exit(outf == stdout ? 0 : 2);
 
@@ -807,8 +824,9 @@ int main(int argc, char *argv[])
                        c.update = optarg;
                        if (strcmp(c.update, "devicesize") != 0 &&
                            strcmp(c.update, "bbl") != 0 &&
+                           strcmp(c.update, "force-no-bbl") != 0 &&
                            strcmp(c.update, "no-bbl") != 0) {
-                               pr_err("only 'devicesize', 'bbl' and 'no-bbl' can be updated with --re-add\n");
+                               pr_err("only 'devicesize', 'bbl', 'no-bbl', and 'force-no-bbl' can be updated with --re-add\n");
                                exit(2);
                        }
                        continue;
@@ -925,6 +943,13 @@ int main(int argc, char *argv[])
                case O(MANAGE,AddSpare): /* add drive - never re-add */
                        devmode = 'S';
                        continue;
+               case O(MANAGE,AddJournal): /* add journal */
+                       if (s.journaldisks && (s.level < 4 || s.level > 6)) {
+                               pr_err("--add-journal is only supported for RAID level 4/5/6.\n");
+                               exit(2);
+                       }
+                       devmode = 'j';
+                       continue;
                case O(MANAGE,ReAdd):
                        devmode = 'A';
                        continue;
@@ -1020,7 +1045,8 @@ int main(int argc, char *argv[])
                                }
                        }
                        if (devmode && devmode != opt &&
-                           (devmode == 'E' || (opt == 'E' && devmode != 'Q'))) {
+                           (devmode == 'E' ||
+                            (opt == 'E' && devmode != 'Q'))) {
                                pr_err("--examine/-E cannot be given with ");
                                if (devmode == 'E') {
                                        if (option_index >= 0)
@@ -1074,8 +1100,10 @@ int main(int argc, char *argv[])
                                pr_err("bitmap file needed with -b in --assemble mode\n");
                                exit(2);
                        }
-                       if (strcmp(optarg, "internal")==0) {
-                               pr_err("there is no need to specify --bitmap when assembling arrays with internal bitmaps\n");
+                       if (strcmp(optarg, "internal") == 0 ||
+                           strcmp(optarg, "clustered") == 0) {
+                               pr_err("no need to specify --bitmap when assembling"
+                                       " arrays with internal or clustered bitmap\n");
                                continue;
                        }
                        bitmap_fd = open(optarg, O_RDWR);
@@ -1116,13 +1144,17 @@ int main(int argc, char *argv[])
                case O(CREATE,Bitmap): /* here we create the bitmap */
                case O(GROW,'b'):
                case O(GROW,Bitmap):
-                       if (strcmp(optarg, "internal")== 0 ||
-                           strcmp(optarg, "none")== 0 ||
+                       if (s.bitmap_file) {
+                               pr_err("bitmap cannot be set twice. Second value: %s.\n", optarg);
+                               exit(2);
+                       }
+                       if (strcmp(optarg, "internal") == 0 ||
+                           strcmp(optarg, "none") == 0 ||
                            strchr(optarg, '/') != NULL) {
                                s.bitmap_file = optarg;
                                continue;
                        }
-                       if (strcmp(optarg, "clustered")== 0) {
+                       if (strcmp(optarg, "clustered") == 0) {
                                s.bitmap_file = optarg;
                                /* Set the default number of cluster nodes
                                 * to 4 if not already set by user
@@ -1132,7 +1164,7 @@ int main(int argc, char *argv[])
                                continue;
                        }
                        /* probable typo */
-                       pr_err("bitmap file must contain a '/', or be 'internal', or 'none'\n"
+                       pr_err("bitmap file must contain a '/', or be 'internal', or be 'clustered', or 'none'\n"
                                "       not '%s'\n", optarg);
                        exit(2);
 
@@ -1188,6 +1220,17 @@ int main(int argc, char *argv[])
 
                        s.journaldisks = 1;
                        continue;
+               case O(CREATE, 'k'):
+               case O(GROW, 'k'):
+                       s.consistency_policy = map_name(consistency_policies,
+                                                       optarg);
+                       if (s.consistency_policy == UnSet ||
+                           s.consistency_policy < CONSISTENCY_POLICY_RESYNC) {
+                               pr_err("Invalid consistency policy: %s\n",
+                                      optarg);
+                               exit(2);
+                       }
+                       continue;
                }
                /* We have now processed all the valid options. Anything else is
                 * an error
@@ -1215,9 +1258,47 @@ int main(int argc, char *argv[])
                exit(0);
        }
 
-       if (s.journaldisks && (s.level < 4 || s.level > 6)) {
-               pr_err("--write-journal is only supported for RAID level 4/5/6.\n");
-               exit(2);
+       if (s.journaldisks) {
+               if (s.level < 4 || s.level > 6) {
+                       pr_err("--write-journal is only supported for RAID level 4/5/6.\n");
+                       exit(2);
+               }
+               if (s.consistency_policy != UnSet &&
+                   s.consistency_policy != CONSISTENCY_POLICY_JOURNAL) {
+                       pr_err("--write-journal is not supported with consistency policy: %s\n",
+                              map_num(consistency_policies, s.consistency_policy));
+                       exit(2);
+               }
+       }
+
+       if (mode == CREATE && s.consistency_policy != UnSet) {
+               if (s.level <= 0) {
+                       pr_err("--consistency-policy not meaningful with level %s.\n",
+                              map_num(pers, s.level));
+                       exit(2);
+               } else if (s.consistency_policy == CONSISTENCY_POLICY_JOURNAL &&
+                          !s.journaldisks) {
+                       pr_err("--write-journal is required for consistency policy: %s\n",
+                              map_num(consistency_policies, s.consistency_policy));
+                       exit(2);
+               } else if (s.consistency_policy == CONSISTENCY_POLICY_PPL &&
+                          s.level != 5) {
+                       pr_err("PPL consistency policy is only supported for RAID level 5.\n");
+                       exit(2);
+               } else if (s.consistency_policy == CONSISTENCY_POLICY_BITMAP &&
+                          (!s.bitmap_file ||
+                           strcmp(s.bitmap_file, "none") == 0)) {
+                       pr_err("--bitmap is required for consistency policy: %s\n",
+                              map_num(consistency_policies, s.consistency_policy));
+                       exit(2);
+               } else if (s.bitmap_file &&
+                          strcmp(s.bitmap_file, "none") != 0 &&
+                          s.consistency_policy != CONSISTENCY_POLICY_BITMAP &&
+                          s.consistency_policy != CONSISTENCY_POLICY_JOURNAL) {
+                       pr_err("--bitmap is not compatible with consistency policy: %s\n",
+                              map_num(consistency_policies, s.consistency_policy));
+                       exit(2);
+               }
        }
 
        if (!mode && devs_found) {
@@ -1247,15 +1328,14 @@ int main(int argc, char *argv[])
         * hopefully it's mostly right but there might be some stuff
         * missing
         *
-        * That is mosty checked in the per-mode stuff but...
+        * That is mostly checked in the per-mode stuff but...
         *
         * For @,B,C and A without -s, the first device listed must be
         * an md device.  We check that here and open it.
         */
 
-       if (mode == MANAGE || mode == BUILD || mode == CREATE
-           || mode == GROW
-           || (mode == ASSEMBLE && ! c.scan)) {
+       if (mode == MANAGE || mode == BUILD || mode == CREATE ||
+           mode == GROW || (mode == ASSEMBLE && ! c.scan)) {
                if (devs_found < 1) {
                        pr_err("an md device must be given in this mode\n");
                        exit(2);
@@ -1305,18 +1385,22 @@ int main(int argc, char *argv[])
 
        if (c.homehost == NULL && c.require_homehost)
                c.homehost = conf_get_homehost(&c.require_homehost);
-       if (c.homehost == NULL || strcasecmp(c.homehost, "<system>")==0) {
+       if (c.homehost == NULL || strcasecmp(c.homehost, "<system>") == 0) {
                if (gethostname(sys_hostname, sizeof(sys_hostname)) == 0) {
                        sys_hostname[sizeof(sys_hostname)-1] = 0;
                        c.homehost = sys_hostname;
                }
        }
-       if (c.homehost && (!c.homehost[0] || strcasecmp(c.homehost, "<none>") == 0)) {
+       if (c.homehost &&
+           (!c.homehost[0] || strcasecmp(c.homehost, "<none>") == 0)) {
                c.homehost = NULL;
                c.require_homehost = 0;
        }
 
        rv = 0;
+
+       set_hooks(); /* set hooks from libs */
+
        if (c.homecluster == NULL && (c.nodes > 0)) {
                c.homecluster = conf_get_homecluster();
                if (c.homecluster == NULL)
@@ -1332,8 +1416,8 @@ int main(int argc, char *argv[])
                exit(2);
        }
 
-       if ((mode == MISC && devmode == 'E')
-           || (mode == MONITOR && spare_sharing == 0))
+       if ((mode == MISC && devmode == 'E') ||
+           (mode == MONITOR && spare_sharing == 0))
                /* Anyone may try this */;
        else if (geteuid() != 0) {
                pr_err("must be super-user to perform this action\n");
@@ -1346,8 +1430,6 @@ int main(int argc, char *argv[])
                /* --scan implied --brief unless -vv */
                c.brief = 1;
 
-       set_dlm_hooks(); /* get dlm funcs from libdlm_lt.so.3 */
-
        switch(mode) {
        case MANAGE:
                /* readonly, add/remove, readwrite, runstop */
@@ -1366,7 +1448,8 @@ int main(int argc, char *argv[])
                break;
        case ASSEMBLE:
                if (devs_found == 1 && ident.uuid_set == 0 &&
-                   ident.super_minor == UnSet && ident.name[0] == 0 && !c.scan ) {
+                   ident.super_minor == UnSet && ident.name[0] == 0 &&
+                   !c.scan ) {
                        /* Only a device has been given, so get details from config file */
                        struct mddev_ident *array_ident = conf_get_ident(devlist->devname);
                        if (array_ident == NULL) {
@@ -1434,7 +1517,7 @@ int main(int argc, char *argv[])
                }
 
                if (s.bitmap_file) {
-                       if (strcmp(s.bitmap_file, "internal")==0 ||
+                       if (strcmp(s.bitmap_file, "internal") == 0 ||
                            strcmp(s.bitmap_file, "clustered") == 0) {
                                pr_err("'internal' and 'clustered' bitmaps not supported with --build\n");
                                rv |= 1;
@@ -1448,7 +1531,8 @@ int main(int argc, char *argv[])
                        c.delay = DEFAULT_BITMAP_DELAY;
 
                if (c.nodes) {
-                       if (!s.bitmap_file || strcmp(s.bitmap_file, "clustered") != 0) {
+                       if (!s.bitmap_file ||
+                           strcmp(s.bitmap_file, "clustered") != 0) {
                                pr_err("--nodes argument only compatible with --bitmap=clustered\n");
                                rv = 1;
                                break;
@@ -1497,7 +1581,8 @@ int main(int argc, char *argv[])
                } else if (devlist == NULL) {
                        if (devmode == 'S' && c.scan)
                                rv = stop_scan(c.verbose);
-                       else if ((devmode == 'D' || devmode == Waitclean) && c.scan)
+                       else if ((devmode == 'D' || devmode == Waitclean) &&
+                                c.scan)
                                rv = misc_scan(devmode, &c);
                        else if (devmode == UdevRules)
                                rv = Write_rules(udev_filename);
@@ -1563,7 +1648,8 @@ int main(int argc, char *argv[])
                }
                if (devs_found > 1 && s.raiddisks == 0 && s.level == UnSet) {
                        /* must be '-a'. */
-                       if (s.size > 0 || s.chunk || s.layout_str != NULL || s.bitmap_file) {
+                       if (s.size > 0 || s.chunk ||
+                           s.layout_str || s.bitmap_file) {
                                pr_err("--add cannot be used with other geometry changes in --grow mode\n");
                                rv = 1;
                                break;
@@ -1576,7 +1662,7 @@ int main(int argc, char *argv[])
                        }
                } else if (s.bitmap_file) {
                        if (s.size > 0 || s.raiddisks || s.chunk ||
-                           s.layout_str != NULL || devs_found > 1) {
+                           s.layout_str || devs_found > 1) {
                                pr_err("--bitmap changes cannot be used with other geometry changes in --grow mode\n");
                                rv = 1;
                                break;
@@ -1588,12 +1674,14 @@ int main(int argc, char *argv[])
                        rv = Grow_continue_command(devlist->devname,
                                                   mdfd, c.backup_file,
                                                   c.verbose);
-               else if (s.size > 0 || s.raiddisks || s.layout_str != NULL
-                        || s.chunk != 0 || s.level != UnSet
-                        || data_offset != INVALID_SECTORS) {
+               else if (s.size > 0 || s.raiddisks || s.layout_str ||
+                        s.chunk != 0 || s.level != UnSet ||
+                        data_offset != INVALID_SECTORS) {
                        rv = Grow_reshape(devlist->devname, mdfd,
                                          devlist->next,
                                          data_offset, &c, &s);
+               } else if (s.consistency_policy != UnSet) {
+                       rv = Grow_consistency_policy(devlist->devname, mdfd, &c, &s);
                } else if (array_size == 0)
                        pr_err("no changes to --grow\n");
                break;
@@ -1706,11 +1794,11 @@ static int scan_assemble(struct supertype *ss,
                                rv2 = Assemble(ss, NULL,
                                               ident,
                                               devlist, c);
-                               if (rv2==0) {
+                               if (rv2 == 0) {
                                        cnt++;
                                        acnt++;
                                }
-                       } while (rv2!=2);
+                       } while (rv2 != 2);
                        /* Incase there are stacked devices, we need to go around again */
                } while (acnt);
                if (cnt == 0 && rv == 0) {
@@ -1751,8 +1839,7 @@ static int misc_scan(char devmode, struct context *c)
                        if (me && me->path
                            && strcmp(me->path, "/unknown") != 0)
                                name = me->path;
-                       if (name == NULL ||
-                           stat(name, &stb) != 0)
+                       if (name == NULL || stat(name, &stb) != 0)
                                name = get_md_name(e->devnm);
 
                        if (!name) {
@@ -1874,12 +1961,12 @@ static int misc_list(struct mddev_dev *devlist,
                        rv |= SetAction(dv->devname, c->action);
                        continue;
                }
-               if (dv->devname[0] == '/')
-                       mdfd = open_mddev(dv->devname, 1);
-               else {
-                       mdfd = open_dev(dv->devname);
-                       if (mdfd < 0)
-                               pr_err("Cannot open %s\n", dv->devname);
+               switch(dv->devname[0] == '/') {
+                       case 0:
+                               mdfd = open_dev(dv->devname);
+                               if (mdfd >= 0) break;
+                       case 1:
+                               mdfd = open_mddev(dv->devname, 1);  
                }
                if (mdfd>=0) {
                        switch(dv->disposition) {