]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - super-ddf.c
DDF: fix detection of failed devices during assembly.
[thirdparty/mdadm.git] / super-ddf.c
index b95f4a088dafb2f47a826b9bbbeadac9f7bf5e67..4242af86fea9b6e3a2711caad51c478048f8e936 100644 (file)
@@ -47,6 +47,10 @@ unsigned long crc32(
 #define DDF_NOTFOUND (~0U)
 #define DDF_CONTAINER (DDF_NOTFOUND-1)
 
+/* Default for safe_mode_delay. Same value as for IMSM.
+ */
+static const int DDF_SAFE_MODE_DELAY = 4000;
+
 /* The DDF metadata handling.
  * DDF metadata lives at the end of the device.
  * The last 512 byte block provides an 'anchor' which is used to locate
@@ -58,6 +62,46 @@ unsigned long crc32(
  *
  */
 
+typedef struct __be16 {
+       __u16 _v16;
+} be16;
+#define be16_eq(x, y) ((x)._v16 == (y)._v16)
+#define be16_and(x, y) ((x)._v16 & (y)._v16)
+#define be16_or(x, y) ((x)._v16 | (y)._v16)
+#define be16_clear(x, y) ((x)._v16 &= ~(y)._v16)
+#define be16_set(x, y) ((x)._v16 |= (y)._v16)
+
+typedef struct __be32 {
+       __u32 _v32;
+} be32;
+#define be32_eq(x, y) ((x)._v32 == (y)._v32)
+
+typedef struct __be64 {
+       __u64 _v64;
+} be64;
+#define be64_eq(x, y) ((x)._v64 == (y)._v64)
+
+#define be16_to_cpu(be) __be16_to_cpu((be)._v16)
+static inline be16 cpu_to_be16(__u16 x)
+{
+       be16 be = { ._v16 = __cpu_to_be16(x) };
+       return be;
+}
+
+#define be32_to_cpu(be) __be32_to_cpu((be)._v32)
+static inline be32 cpu_to_be32(__u32 x)
+{
+       be32 be = { ._v32 = __cpu_to_be32(x) };
+       return be;
+}
+
+#define be64_to_cpu(be) __be64_to_cpu((be)._v64)
+static inline be64 cpu_to_be64(__u64 x)
+{
+       be64 be = { ._v64 = __cpu_to_be64(x) };
+       return be;
+}
+
 /* Primary Raid Level (PRL) */
 #define        DDF_RAID0       0x00
 #define        DDF_RAID1       0x01
@@ -95,28 +139,28 @@ unsigned long crc32(
 #define        DDF_2SPANNED    0x03    /* This is also weird - be careful */
 
 /* Magic numbers */
-#define        DDF_HEADER_MAGIC        __cpu_to_be32(0xDE11DE11)
-#define        DDF_CONTROLLER_MAGIC    __cpu_to_be32(0xAD111111)
-#define        DDF_PHYS_RECORDS_MAGIC  __cpu_to_be32(0x22222222)
-#define        DDF_PHYS_DATA_MAGIC     __cpu_to_be32(0x33333333)
-#define        DDF_VIRT_RECORDS_MAGIC  __cpu_to_be32(0xDDDDDDDD)
-#define        DDF_VD_CONF_MAGIC       __cpu_to_be32(0xEEEEEEEE)
-#define        DDF_SPARE_ASSIGN_MAGIC  __cpu_to_be32(0x55555555)
-#define        DDF_VU_CONF_MAGIC       __cpu_to_be32(0x88888888)
-#define        DDF_VENDOR_LOG_MAGIC    __cpu_to_be32(0x01dBEEF0)
-#define        DDF_BBM_LOG_MAGIC       __cpu_to_be32(0xABADB10C)
+#define        DDF_HEADER_MAGIC        cpu_to_be32(0xDE11DE11)
+#define        DDF_CONTROLLER_MAGIC    cpu_to_be32(0xAD111111)
+#define        DDF_PHYS_RECORDS_MAGIC  cpu_to_be32(0x22222222)
+#define        DDF_PHYS_DATA_MAGIC     cpu_to_be32(0x33333333)
+#define        DDF_VIRT_RECORDS_MAGIC  cpu_to_be32(0xDDDDDDDD)
+#define        DDF_VD_CONF_MAGIC       cpu_to_be32(0xEEEEEEEE)
+#define        DDF_SPARE_ASSIGN_MAGIC  cpu_to_be32(0x55555555)
+#define        DDF_VU_CONF_MAGIC       cpu_to_be32(0x88888888)
+#define        DDF_VENDOR_LOG_MAGIC    cpu_to_be32(0x01dBEEF0)
+#define        DDF_BBM_LOG_MAGIC       cpu_to_be32(0xABADB10C)
 
 #define        DDF_GUID_LEN    24
 #define DDF_REVISION_0 "01.00.00"
 #define DDF_REVISION_2 "01.02.00"
 
 struct ddf_header {
-       __u32   magic;          /* DDF_HEADER_MAGIC */
-       __u32   crc;
+       be32    magic;          /* DDF_HEADER_MAGIC */
+       be32    crc;
        char    guid[DDF_GUID_LEN];
        char    revision[8];    /* 01.02.00 */
-       __u32   seq;            /* starts at '1' */
-       __u32   timestamp;
+       be32    seq;            /* starts at '1' */
+       be32    timestamp;
        __u8    openflag;
        __u8    foreignflag;
        __u8    enforcegroups;
@@ -124,38 +168,38 @@ struct ddf_header {
        __u8    pad1[12];       /* 12 * 0xff */
        /* 64 bytes so far */
        __u8    header_ext[32]; /* reserved: fill with 0xff */
-       __u64   primary_lba;
-       __u64   secondary_lba;
+       be64    primary_lba;
+       be64    secondary_lba;
        __u8    type;
        __u8    pad2[3];        /* 0xff */
-       __u32   workspace_len;  /* sectors for vendor space -
+       be32    workspace_len;  /* sectors for vendor space -
                                 * at least 32768(sectors) */
-       __u64   workspace_lba;
-       __u16   max_pd_entries; /* one of 15, 63, 255, 1023, 4095 */
-       __u16   max_vd_entries; /* 2^(4,6,8,10,12)-1 : i.e. as above */
-       __u16   max_partitions; /* i.e. max num of configuration
+       be64    workspace_lba;
+       be16    max_pd_entries; /* one of 15, 63, 255, 1023, 4095 */
+       be16    max_vd_entries; /* 2^(4,6,8,10,12)-1 : i.e. as above */
+       be16    max_partitions; /* i.e. max num of configuration
                                   record entries per disk */
-       __u16   config_record_len; /* 1 +ROUNDUP(max_primary_element_entries
+       be16    config_record_len; /* 1 +ROUNDUP(max_primary_element_entries
                                                 *12/512) */
-       __u16   max_primary_element_entries; /* 16, 64, 256, 1024, or 4096 */
+       be16    max_primary_element_entries; /* 16, 64, 256, 1024, or 4096 */
        __u8    pad3[54];       /* 0xff */
        /* 192 bytes so far */
-       __u32   controller_section_offset;
-       __u32   controller_section_length;
-       __u32   phys_section_offset;
-       __u32   phys_section_length;
-       __u32   virt_section_offset;
-       __u32   virt_section_length;
-       __u32   config_section_offset;
-       __u32   config_section_length;
-       __u32   data_section_offset;
-       __u32   data_section_length;
-       __u32   bbm_section_offset;
-       __u32   bbm_section_length;
-       __u32   diag_space_offset;
-       __u32   diag_space_length;
-       __u32   vendor_offset;
-       __u32   vendor_length;
+       be32    controller_section_offset;
+       be32    controller_section_length;
+       be32    phys_section_offset;
+       be32    phys_section_length;
+       be32    virt_section_offset;
+       be32    virt_section_length;
+       be32    config_section_offset;
+       be32    config_section_length;
+       be32    data_section_offset;
+       be32    data_section_length;
+       be32    bbm_section_offset;
+       be32    bbm_section_length;
+       be32    diag_space_offset;
+       be32    diag_space_length;
+       be32    vendor_offset;
+       be32    vendor_length;
        /* 256 bytes so far */
        __u8    pad4[256];      /* 0xff */
 };
@@ -167,14 +211,14 @@ struct ddf_header {
 
 /* The content of the 'controller section' - global scope */
 struct ddf_controller_data {
-       __u32   magic;                  /* DDF_CONTROLLER_MAGIC */
-       __u32   crc;
+       be32    magic;                  /* DDF_CONTROLLER_MAGIC */
+       be32    crc;
        char    guid[DDF_GUID_LEN];
        struct controller_type {
-               __u16 vendor_id;
-               __u16 device_id;
-               __u16 sub_vendor_id;
-               __u16 sub_device_id;
+               be16 vendor_id;
+               be16 device_id;
+               be16 sub_vendor_id;
+               be16 sub_device_id;
        } type;
        char    product_id[16];
        __u8    pad[8]; /* 0xff */
@@ -183,17 +227,17 @@ struct ddf_controller_data {
 
 /* The content of phys_section - global scope */
 struct phys_disk {
-       __u32   magic;          /* DDF_PHYS_RECORDS_MAGIC */
-       __u32   crc;
-       __u16   used_pdes;
-       __u16   max_pdes;
+       be32    magic;          /* DDF_PHYS_RECORDS_MAGIC */
+       be32    crc;
+       be16    used_pdes;
+       be16    max_pdes;
        __u8    pad[52];
        struct phys_disk_entry {
                char    guid[DDF_GUID_LEN];
-               __u32   refnum;
-               __u16   type;
-               __u16   state;
-               __u64   config_size; /* DDF structures must be after here */
+               be32    refnum;
+               be16    type;
+               be16    state;
+               be64    config_size; /* DDF structures must be after here */
                char    path[18];       /* another horrible structure really */
                __u8    pad[6];
        } entries[0];
@@ -224,17 +268,17 @@ struct phys_disk {
 
 /* The content of the virt_section global scope */
 struct virtual_disk {
-       __u32   magic;          /* DDF_VIRT_RECORDS_MAGIC */
-       __u32   crc;
-       __u16   populated_vdes;
-       __u16   max_vdes;
+       be32    magic;          /* DDF_VIRT_RECORDS_MAGIC */
+       be32    crc;
+       be16    populated_vdes;
+       be16    max_vdes;
        __u8    pad[52];
        struct virtual_entry {
                char    guid[DDF_GUID_LEN];
-               __u16   unit;
+               be16    unit;
                __u16   pad0;   /* 0xffff */
-               __u16   guid_crc;
-               __u16   type;
+               be16    guid_crc;
+               be16    type;
                __u8    state;
                __u8    init_state;
                __u8    pad1[14];
@@ -278,25 +322,25 @@ struct virtual_disk {
  */
 
 struct vd_config {
-       __u32   magic;          /* DDF_VD_CONF_MAGIC */
-       __u32   crc;
+       be32    magic;          /* DDF_VD_CONF_MAGIC */
+       be32    crc;
        char    guid[DDF_GUID_LEN];
-       __u32   timestamp;
-       __u32   seqnum;
+       be32    timestamp;
+       be32    seqnum;
        __u8    pad0[24];
-       __u16   prim_elmnt_count;
+       be16    prim_elmnt_count;
        __u8    chunk_shift;    /* 0 == 512, 1==1024 etc */
        __u8    prl;
        __u8    rlq;
        __u8    sec_elmnt_count;
        __u8    sec_elmnt_seq;
        __u8    srl;
-       __u64   blocks;         /* blocks per component could be different
+       be64    blocks;         /* blocks per component could be different
                                 * on different component devices...(only
                                 * for concat I hope) */
-       __u64   array_blocks;   /* blocks in array */
+       be64    array_blocks;   /* blocks in array */
        __u8    pad1[8];
-       __u32   spare_refs[8];
+       be32    spare_refs[8];
        __u8    cache_pol[8];
        __u8    bg_rate;
        __u8    pad2[3];
@@ -307,10 +351,11 @@ struct vd_config {
        __u8    v2[16]; /* reserved- 0xff */
        __u8    v3[16]; /* reserved- 0xff */
        __u8    vendor[32];
-       __u32   phys_refnum[0]; /* refnum of each disk in sequence */
+       be32    phys_refnum[0]; /* refnum of each disk in sequence */
       /*__u64  lba_offset[0];  LBA offset in each phys.  Note extents in a
                                bvd are always the same size */
 };
+#define LBA_OFFSET(ddf, vd) ((be64 *) &(vd)->phys_refnum[(ddf)->mppe])
 
 /* vd_config.cache_pol[7] is a bitmap */
 #define        DDF_cache_writeback     1       /* else writethrough */
@@ -322,17 +367,17 @@ struct vd_config {
 #define        DDF_cache_rallowed      64      /* enable read caching */
 
 struct spare_assign {
-       __u32   magic;          /* DDF_SPARE_ASSIGN_MAGIC */
-       __u32   crc;
-       __u32   timestamp;
+       be32    magic;          /* DDF_SPARE_ASSIGN_MAGIC */
+       be32    crc;
+       be32    timestamp;
        __u8    reserved[7];
        __u8    type;
-       __u16   populated;      /* SAEs used */
-       __u16   max;            /* max SAEs */
+       be16    populated;      /* SAEs used */
+       be16    max;            /* max SAEs */
        __u8    pad[8];
        struct spare_assign_entry {
                char    guid[DDF_GUID_LEN];
-               __u16   secondary_element;
+               be16    secondary_element;
                __u8    pad[6];
        } spare_ents[0];
 };
@@ -344,10 +389,10 @@ struct spare_assign {
 
 /* The data_section contents - local scope */
 struct disk_data {
-       __u32   magic;          /* DDF_PHYS_DATA_MAGIC */
-       __u32   crc;
+       be32    magic;          /* DDF_PHYS_DATA_MAGIC */
+       be32    crc;
        char    guid[DDF_GUID_LEN];
-       __u32   refnum;         /* crc of some magic drive data ... */
+       be32    refnum;         /* crc of some magic drive data ... */
        __u8    forced_ref;     /* set when above was not result of magic */
        __u8    forced_guid;    /* set if guid was forced rather than magic */
        __u8    vendor[32];
@@ -356,16 +401,16 @@ struct disk_data {
 
 /* bbm_section content */
 struct bad_block_log {
-       __u32   magic;
-       __u32   crc;
-       __u16   entry_count;
-       __u32   spare_count;
+       be32    magic;
+       be32    crc;
+       be16    entry_count;
+       be32    spare_count;
        __u8    pad[10];
-       __u64   first_spare;
+       be64    first_spare;
        struct mapped_block {
-               __u64   defective_start;
-               __u32   replacement_start;
-               __u16   remap_count;
+               be64    defective_start;
+               be32    replacement_start;
+               be16    remap_count;
                __u8    pad[2];
        } entries[0];
 };
@@ -398,6 +443,7 @@ struct ddf_super {
        struct ddf_header *active;
        struct phys_disk        *phys;
        struct virtual_disk     *virt;
+       char                    *conf;
        int pdsize, vdsize;
        unsigned int max_part, mppe, conf_rec_len;
        int currentdev;
@@ -407,8 +453,6 @@ struct ddf_super {
                        char space[512];
                        struct {
                                struct vcl      *next;
-                               __u64           *lba_offset; /* location in 'conf' of
-                                                             * the lba table */
                                unsigned int    vcnum; /* index into ->virt */
                                struct vd_config **other_bvds;
                                __u64           *block_sizes; /* NULL if all the same */
@@ -425,9 +469,9 @@ struct ddf_super {
                                char *devname;
                                int fd;
                                unsigned long long size; /* sectors */
-                               unsigned long long primary_lba; /* sectors */
-                               unsigned long long secondary_lba; /* sectors */
-                               unsigned long long workspace_lba; /* sectors */
+                               be64 primary_lba; /* sectors */
+                               be64 secondary_lba; /* sectors */
+                               be64 workspace_lba; /* sectors */
                                int pdnum;      /* index in ->phys */
                                struct spare_assign *spare;
                                void *mdupdate; /* hold metadata update */
@@ -452,7 +496,7 @@ static void pr_state(struct ddf_super *ddf, const char *msg)
 {
        unsigned int i;
        dprintf("%s/%s: ", __func__, msg);
-       for (i = 0; i < __be16_to_cpu(ddf->active->max_vd_entries); i++) {
+       for (i = 0; i < be16_to_cpu(ddf->active->max_vd_entries); i++) {
                if (all_ff(ddf->virt->entries[i].guid))
                        continue;
                dprintf("%u(s=%02x i=%02x) ", i,
@@ -465,29 +509,144 @@ static void pr_state(struct ddf_super *ddf, const char *msg)
 static void pr_state(const struct ddf_super *ddf, const char *msg) {}
 #endif
 
-#define ddf_set_updates_pending(x) \
-       do { (x)->updates_pending = 1; pr_state(x, __func__); } while (0)
+static void _ddf_set_updates_pending(struct ddf_super *ddf, const char *func)
+{
+       ddf->updates_pending = 1;
+       ddf->active->seq = cpu_to_be32((be32_to_cpu(ddf->active->seq)+1));
+       pr_state(ddf, func);
+}
 
-static unsigned int calc_crc(void *buf, int len)
+#define ddf_set_updates_pending(x) _ddf_set_updates_pending((x), __func__)
+
+static unsigned int get_pd_index_from_refnum(const struct vcl *vc,
+                                            be32 refnum, unsigned int nmax,
+                                            const struct vd_config **bvd,
+                                            unsigned int *idx);
+
+static be32 calc_crc(void *buf, int len)
 {
        /* crcs are always at the same place as in the ddf_header */
        struct ddf_header *ddf = buf;
-       __u32 oldcrc = ddf->crc;
+       be32 oldcrc = ddf->crc;
        __u32 newcrc;
-       ddf->crc = 0xffffffff;
+       ddf->crc = cpu_to_be32(0xffffffff);
 
        newcrc = crc32(0, buf, len);
        ddf->crc = oldcrc;
        /* The crc is store (like everything) bigendian, so convert
         * here for simplicity
         */
-       return __cpu_to_be32(newcrc);
+       return cpu_to_be32(newcrc);
+}
+
+#define DDF_INVALID_LEVEL 0xff
+#define DDF_NO_SECONDARY 0xff
+static int err_bad_md_layout(const mdu_array_info_t *array)
+{
+       pr_err("RAID%d layout %x with %d disks is unsupported for DDF\n",
+              array->level, array->layout, array->raid_disks);
+       return -1;
+}
+
+static int layout_md2ddf(const mdu_array_info_t *array,
+                        struct vd_config *conf)
+{
+       be16 prim_elmnt_count = cpu_to_be16(array->raid_disks);
+       __u8 prl = DDF_INVALID_LEVEL, rlq = 0;
+       __u8 sec_elmnt_count = 1;
+       __u8 srl = DDF_NO_SECONDARY;
+
+       switch (array->level) {
+       case LEVEL_LINEAR:
+               prl = DDF_CONCAT;
+               break;
+       case 0:
+               rlq = DDF_RAID0_SIMPLE;
+               prl = DDF_RAID0;
+               break;
+       case 1:
+               switch (array->raid_disks) {
+               case 2:
+                       rlq = DDF_RAID1_SIMPLE;
+                       break;
+               case 3:
+                       rlq = DDF_RAID1_MULTI;
+                       break;
+               default:
+                       return err_bad_md_layout(array);
+               }
+               prl = DDF_RAID1;
+               break;
+       case 4:
+               if (array->layout != 0)
+                       return err_bad_md_layout(array);
+               rlq = DDF_RAID4_N;
+               prl = DDF_RAID4;
+               break;
+       case 5:
+               switch (array->layout) {
+               case ALGORITHM_LEFT_ASYMMETRIC:
+                       rlq = DDF_RAID5_N_RESTART;
+                       break;
+               case ALGORITHM_RIGHT_ASYMMETRIC:
+                       rlq = DDF_RAID5_0_RESTART;
+                       break;
+               case ALGORITHM_LEFT_SYMMETRIC:
+                       rlq = DDF_RAID5_N_CONTINUE;
+                       break;
+               case ALGORITHM_RIGHT_SYMMETRIC:
+                       /* not mentioned in standard */
+               default:
+                       return err_bad_md_layout(array);
+               }
+               prl = DDF_RAID5;
+               break;
+       case 6:
+               switch (array->layout) {
+               case ALGORITHM_ROTATING_N_RESTART:
+                       rlq = DDF_RAID5_N_RESTART;
+                       break;
+               case ALGORITHM_ROTATING_ZERO_RESTART:
+                       rlq = DDF_RAID6_0_RESTART;
+                       break;
+               case ALGORITHM_ROTATING_N_CONTINUE:
+                       rlq = DDF_RAID5_N_CONTINUE;
+                       break;
+               default:
+                       return err_bad_md_layout(array);
+               }
+               prl = DDF_RAID6;
+               break;
+       case 10:
+               if (array->raid_disks % 2 == 0 && array->layout == 0x102) {
+                       rlq = DDF_RAID1_SIMPLE;
+                       prim_elmnt_count =  cpu_to_be16(2);
+                       sec_elmnt_count = array->raid_disks / 2;
+               } else if (array->raid_disks % 3 == 0
+                          && array->layout == 0x103) {
+                       rlq = DDF_RAID1_MULTI;
+                       prim_elmnt_count =  cpu_to_be16(3);
+                       sec_elmnt_count = array->raid_disks / 3;
+               } else
+                       return err_bad_md_layout(array);
+               srl = DDF_2SPANNED;
+               prl = DDF_RAID1;
+               break;
+       default:
+               return err_bad_md_layout(array);
+       }
+       conf->prl = prl;
+       conf->prim_elmnt_count = prim_elmnt_count;
+       conf->rlq = rlq;
+       conf->srl = srl;
+       conf->sec_elmnt_count = sec_elmnt_count;
+       return 0;
 }
 
 static int err_bad_ddf_layout(const struct vd_config *conf)
 {
        pr_err("DDF RAID %u qualifier %u with %u disks is unsupported\n",
-              conf->prl, conf->rlq, __be16_to_cpu(conf->prim_elmnt_count));
+              conf->prl, conf->rlq, be16_to_cpu(conf->prim_elmnt_count));
        return -1;
 }
 
@@ -496,7 +655,7 @@ static int layout_ddf2md(const struct vd_config *conf,
 {
        int level = LEVEL_UNSUPPORTED;
        int layout = 0;
-       int raiddisks = __be16_to_cpu(conf->prim_elmnt_count);
+       int raiddisks = be16_to_cpu(conf->prim_elmnt_count);
 
        if (conf->sec_elmnt_count > 1) {
                /* see also check_secondary() */
@@ -600,28 +759,34 @@ static int load_ddf_header(int fd, unsigned long long lba,
        if (read(fd, hdr, 512) != 512)
                return 0;
 
-       if (hdr->magic != DDF_HEADER_MAGIC)
+       if (!be32_eq(hdr->magic, DDF_HEADER_MAGIC)) {
+               pr_err("%s: bad header magic\n", __func__);
                return 0;
-       if (calc_crc(hdr, 512) != hdr->crc)
+       }
+       if (!be32_eq(calc_crc(hdr, 512), hdr->crc)) {
+               pr_err("%s: bad CRC\n", __func__);
                return 0;
+       }
        if (memcmp(anchor->guid, hdr->guid, DDF_GUID_LEN) != 0 ||
            memcmp(anchor->revision, hdr->revision, 8) != 0 ||
-           anchor->primary_lba != hdr->primary_lba ||
-           anchor->secondary_lba != hdr->secondary_lba ||
+           !be64_eq(anchor->primary_lba, hdr->primary_lba) ||
+           !be64_eq(anchor->secondary_lba, hdr->secondary_lba) ||
            hdr->type != type ||
            memcmp(anchor->pad2, hdr->pad2, 512 -
-                  offsetof(struct ddf_header, pad2)) != 0)
+                  offsetof(struct ddf_header, pad2)) != 0) {
+               pr_err("%s: header mismatch\n", __func__);
                return 0;
+       }
 
        /* Looks good enough to me... */
        return 1;
 }
 
 static void *load_section(int fd, struct ddf_super *super, void *buf,
-                         __u32 offset_be, __u32 len_be, int check)
+                         be32 offset_be, be32 len_be, int check)
 {
-       unsigned long long offset = __be32_to_cpu(offset_be);
-       unsigned long long len = __be32_to_cpu(len_be);
+       unsigned long long offset = be32_to_cpu(offset_be);
+       unsigned long long len = be32_to_cpu(len_be);
        int dofree = (buf == NULL);
 
        if (check)
@@ -631,20 +796,16 @@ static void *load_section(int fd, struct ddf_super *super, void *buf,
 
        if (len > 1024)
                return NULL;
-       if (buf) {
-               /* All pre-allocated sections are a single block */
-               if (len != 1)
-                       return NULL;
-       } else if (posix_memalign(&buf, 512, len<<9) != 0)
+       if (!buf && posix_memalign(&buf, 512, len<<9) != 0)
                buf = NULL;
 
        if (!buf)
                return NULL;
 
        if (super->active->type == 1)
-               offset += __be64_to_cpu(super->active->primary_lba);
+               offset += be64_to_cpu(super->active->primary_lba);
        else
-               offset += __be64_to_cpu(super->active->secondary_lba);
+               offset += be64_to_cpu(super->active->secondary_lba);
 
        if ((unsigned long long)lseek64(fd, offset<<9, 0) != (offset<<9)) {
                if (dofree)
@@ -677,13 +838,13 @@ static int load_ddf_headers(int fd, struct ddf_super *super, char *devname)
                               devname, strerror(errno));
                return 1;
        }
-       if (super->anchor.magic != DDF_HEADER_MAGIC) {
+       if (!be32_eq(super->anchor.magic, DDF_HEADER_MAGIC)) {
                if (devname)
                        pr_err("no DDF anchor found on %s\n",
                                devname);
                return 2;
        }
-       if (calc_crc(&super->anchor, 512) != super->anchor.crc) {
+       if (!be32_eq(calc_crc(&super->anchor, 512), super->anchor.crc)) {
                if (devname)
                        pr_err("bad CRC on anchor on %s\n",
                                devname);
@@ -698,7 +859,7 @@ static int load_ddf_headers(int fd, struct ddf_super *super, char *devname)
                return 2;
        }
        super->active = NULL;
-       if (load_ddf_header(fd, __be64_to_cpu(super->anchor.primary_lba),
+       if (load_ddf_header(fd, be64_to_cpu(super->anchor.primary_lba),
                            dsize >> 9,  1,
                            &super->primary, &super->anchor) == 0) {
                if (devname)
@@ -706,19 +867,21 @@ static int load_ddf_headers(int fd, struct ddf_super *super, char *devname)
                               "on %s\n", devname);
        } else
                super->active = &super->primary;
-       if (load_ddf_header(fd, __be64_to_cpu(super->anchor.secondary_lba),
+
+       if (load_ddf_header(fd, be64_to_cpu(super->anchor.secondary_lba),
                            dsize >> 9,  2,
                            &super->secondary, &super->anchor)) {
-               if ((__be32_to_cpu(super->primary.seq)
-                    < __be32_to_cpu(super->secondary.seq) &&
-                    !super->secondary.openflag)
-                   || (__be32_to_cpu(super->primary.seq)
-                       == __be32_to_cpu(super->secondary.seq) &&
+               if (super->active == NULL
+                   || (be32_to_cpu(super->primary.seq)
+                       < be32_to_cpu(super->secondary.seq) &&
+                       !super->secondary.openflag)
+                   || (be32_to_cpu(super->primary.seq)
+                       == be32_to_cpu(super->secondary.seq) &&
                        super->primary.openflag && !super->secondary.openflag)
-                   || super->active == NULL
                        )
                        super->active = &super->secondary;
-       } else if (devname)
+       } else if (devname &&
+                  be64_to_cpu(super->anchor.secondary_lba) != ~(__u64)0)
                pr_err("Failed to load secondary DDF header on %s\n",
                       devname);
        if (super->active == NULL)
@@ -737,13 +900,13 @@ static int load_ddf_global(int fd, struct ddf_super *super, char *devname)
                                   super->active->phys_section_offset,
                                   super->active->phys_section_length,
                                   1);
-       super->pdsize = __be32_to_cpu(super->active->phys_section_length) * 512;
+       super->pdsize = be32_to_cpu(super->active->phys_section_length) * 512;
 
        super->virt = load_section(fd, super, NULL,
                                   super->active->virt_section_offset,
                                   super->active->virt_section_length,
                                   1);
-       super->vdsize = __be32_to_cpu(super->active->virt_section_length) * 512;
+       super->vdsize = be32_to_cpu(super->active->virt_section_length) * 512;
        if (!ok ||
            !super->phys ||
            !super->virt) {
@@ -756,9 +919,32 @@ static int load_ddf_global(int fd, struct ddf_super *super, char *devname)
        super->conflist = NULL;
        super->dlist = NULL;
 
-       super->max_part = __be16_to_cpu(super->active->max_partitions);
-       super->mppe = __be16_to_cpu(super->active->max_primary_element_entries);
-       super->conf_rec_len = __be16_to_cpu(super->active->config_record_len);
+       super->max_part = be16_to_cpu(super->active->max_partitions);
+       super->mppe = be16_to_cpu(super->active->max_primary_element_entries);
+       super->conf_rec_len = be16_to_cpu(super->active->config_record_len);
+       return 0;
+}
+
+#define DDF_UNUSED_BVD 0xff
+static int alloc_other_bvds(const struct ddf_super *ddf, struct vcl *vcl)
+{
+       unsigned int n_vds = vcl->conf.sec_elmnt_count - 1;
+       unsigned int i, vdsize;
+       void *p;
+       if (n_vds == 0) {
+               vcl->other_bvds = NULL;
+               return 0;
+       }
+       vdsize = ddf->conf_rec_len * 512;
+       if (posix_memalign(&p, 512, n_vds *
+                          (vdsize +  sizeof(struct vd_config *))) != 0)
+               return -1;
+       vcl->other_bvds = (struct vd_config **) (p + n_vds * vdsize);
+       for (i = 0; i < n_vds; i++) {
+               vcl->other_bvds[i] = p + i * vdsize;
+               memset(vcl->other_bvds[i], 0, vdsize);
+               vcl->other_bvds[i]->sec_elmnt_seq = DDF_UNUSED_BVD;
+       }
        return 0;
 }
 
@@ -767,27 +953,22 @@ static void add_other_bvd(struct vcl *vcl, struct vd_config *vd,
 {
        int i;
        for (i = 0; i < vcl->conf.sec_elmnt_count-1; i++)
-               if (vcl->other_bvds[i] != NULL &&
-                   vcl->other_bvds[i]->sec_elmnt_seq == vd->sec_elmnt_seq)
+               if (vcl->other_bvds[i]->sec_elmnt_seq == vd->sec_elmnt_seq)
                        break;
 
        if (i < vcl->conf.sec_elmnt_count-1) {
-               if (vd->seqnum <= vcl->other_bvds[i]->seqnum)
+               if (be32_to_cpu(vd->seqnum) <=
+                   be32_to_cpu(vcl->other_bvds[i]->seqnum))
                        return;
        } else {
                for (i = 0; i < vcl->conf.sec_elmnt_count-1; i++)
-                       if (vcl->other_bvds[i] == NULL)
+                       if (vcl->other_bvds[i]->sec_elmnt_seq == DDF_UNUSED_BVD)
                                break;
                if (i == vcl->conf.sec_elmnt_count-1) {
                        pr_err("no space for sec level config %u, count is %u\n",
                               vd->sec_elmnt_seq, vcl->conf.sec_elmnt_count);
                        return;
                }
-               if (posix_memalign((void **)&vcl->other_bvds[i], 512, len)
-                   != 0) {
-                       pr_err("%s could not allocate vd buf\n", __func__);
-                       return;
-               }
        }
        memcpy(vcl->other_bvds[i], vd, len);
 }
@@ -801,7 +982,8 @@ static int load_ddf_local(int fd, struct ddf_super *super,
        unsigned int i;
        unsigned int confsec;
        int vnum;
-       unsigned int max_virt_disks = __be16_to_cpu(super->active->max_vd_entries);
+       unsigned int max_virt_disks = be16_to_cpu
+               (super->active->max_vd_entries);
        unsigned long long dsize;
 
        /* First the local disk info */
@@ -840,7 +1022,7 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                dl->vlist[i] = NULL;
        super->dlist = dl;
        dl->pdnum = -1;
-       for (i = 0; i < __be16_to_cpu(super->active->max_pd_entries); i++)
+       for (i = 0; i < be16_to_cpu(super->active->max_pd_entries); i++)
                if (memcmp(super->phys->entries[i].guid,
                           dl->disk.guid, DDF_GUID_LEN) == 0)
                        dl->pdnum = i;
@@ -851,20 +1033,20 @@ static int load_ddf_local(int fd, struct ddf_super *super,
         * the conflist
         */
 
-       conf = load_section(fd, super, NULL,
+       conf = load_section(fd, super, super->conf,
                            super->active->config_section_offset,
                            super->active->config_section_length,
                            0);
-
+       super->conf = conf;
        vnum = 0;
        for (confsec = 0;
-            confsec < __be32_to_cpu(super->active->config_section_length);
+            confsec < be32_to_cpu(super->active->config_section_length);
             confsec += super->conf_rec_len) {
                struct vd_config *vd =
                        (struct vd_config *)((char*)conf + confsec*512);
                struct vcl *vcl;
 
-               if (vd->magic == DDF_SPARE_ASSIGN_MAGIC) {
+               if (be32_eq(vd->magic, DDF_SPARE_ASSIGN_MAGIC)) {
                        if (dl->spare)
                                continue;
                        if (posix_memalign((void**)&dl->spare, 512,
@@ -877,7 +1059,7 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                        memcpy(dl->spare, vd, super->conf_rec_len*512);
                        continue;
                }
-               if (vd->magic != DDF_VD_CONF_MAGIC)
+               if (!be32_eq(vd->magic, DDF_VD_CONF_MAGIC))
                        continue;
                for (vcl = super->conflist; vcl; vcl = vcl->next) {
                        if (memcmp(vcl->conf.guid,
@@ -892,8 +1074,8 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                                add_other_bvd(vcl, vd, super->conf_rec_len*512);
                                continue;
                        }
-                       if (__be32_to_cpu(vd->seqnum) <=
-                           __be32_to_cpu(vcl->conf.seqnum))
+                       if (be32_to_cpu(vd->seqnum) <=
+                           be32_to_cpu(vcl->conf.seqnum))
                                continue;
                } else {
                        if (posix_memalign((void**)&vcl, 512,
@@ -905,19 +1087,17 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                        }
                        vcl->next = super->conflist;
                        vcl->block_sizes = NULL; /* FIXME not for CONCAT */
-                       if (vd->sec_elmnt_count > 1)
-                               vcl->other_bvds =
-                                       xcalloc(vd->sec_elmnt_count - 1,
-                                               sizeof(struct vd_config *));
-                       else
-                               vcl->other_bvds = NULL;
+                       vcl->conf.sec_elmnt_count = vd->sec_elmnt_count;
+                       if (alloc_other_bvds(super, vcl) != 0) {
+                               pr_err("%s could not allocate other bvds\n",
+                                      __func__);
+                               free(vcl);
+                               return 1;
+                       };
                        super->conflist = vcl;
                        dl->vlist[vnum++] = vcl;
                }
                memcpy(&vcl->conf, vd, super->conf_rec_len*512);
-               vcl->lba_offset = (__u64*)
-                       &vcl->conf.phys_refnum[super->mppe];
-
                for (i=0; i < max_virt_disks ; i++)
                        if (memcmp(super->virt->entries[i].guid,
                                   vcl->conf.guid, DDF_GUID_LEN)==0)
@@ -925,7 +1105,6 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                if (i < max_virt_disks)
                        vcl->vcnum = i;
        }
-       free(conf);
 
        return 0;
 }
@@ -947,7 +1126,7 @@ static int load_super_ddf(struct supertype *st, int fd,
        if (get_dev_size(fd, devname, &dsize) == 0)
                return 1;
 
-       if (!st->ignore_hw_compat && test_partition(fd))
+       if (test_partition(fd))
                /* DDF is not allowed on partitions */
                return 1;
 
@@ -1023,18 +1202,18 @@ static void free_super_ddf(struct supertype *st)
                return;
        free(ddf->phys);
        free(ddf->virt);
+       free(ddf->conf);
        while (ddf->conflist) {
                struct vcl *v = ddf->conflist;
                ddf->conflist = v->next;
                if (v->block_sizes)
                        free(v->block_sizes);
-               if (v->other_bvds) {
-                       int i;
-                       for (i = 0; i < v->conf.sec_elmnt_count-1; i++)
-                               if (v->other_bvds[i] != NULL)
-                                       free(v->other_bvds[i]);
-                       free(v->other_bvds);
-               }
+               if (v->other_bvds)
+                       /*
+                          v->other_bvds[0] points to beginning of buffer,
+                          see alloc_other_bvds()
+                       */
+                       free(v->other_bvds[0]);
                free(v);
        }
        while (ddf->dlist) {
@@ -1128,24 +1307,6 @@ static mapping_t ddf_sec_level[] = {
 };
 #endif
 
-struct num_mapping {
-       int num1, num2;
-};
-static struct num_mapping ddf_level_num[] = {
-       { DDF_RAID0, 0 },
-       { DDF_RAID1, 1 },
-       { DDF_RAID3, LEVEL_UNSUPPORTED },
-       { DDF_RAID4, 4 },
-       { DDF_RAID5, 5 },
-       { DDF_RAID1E, LEVEL_UNSUPPORTED },
-       { DDF_JBOD, LEVEL_UNSUPPORTED },
-       { DDF_CONCAT, LEVEL_LINEAR },
-       { DDF_RAID5E, LEVEL_UNSUPPORTED },
-       { DDF_RAID5EE, LEVEL_UNSUPPORTED },
-       { DDF_RAID6, 6},
-       { MAXINT, MAXINT }
-};
-
 static int all_ff(const char *guid)
 {
        int i;
@@ -1155,6 +1316,22 @@ static int all_ff(const char *guid)
        return 1;
 }
 
+static const char *guid_str(const char *guid)
+{
+       static char buf[DDF_GUID_LEN*2+1];
+       int i;
+       char *p = buf;
+       for (i = 0; i < DDF_GUID_LEN; i++) {
+               unsigned char c = guid[i];
+               if (c >= 32 && c < 127)
+                       p += sprintf(p, "%c", c);
+               else
+                       p += sprintf(p, "%02x", c);
+       }
+       *p = '\0';
+       return (const char *) buf;
+}
+
 #ifndef MDASSEMBLE
 static void print_guid(char *guid, int tstamp)
 {
@@ -1201,19 +1378,20 @@ static void examine_vd(int n, struct ddf_super *sb, char *guid)
                unsigned int i;
                struct vd_config *vc = &vcl->conf;
 
-               if (calc_crc(vc, crl*512) != vc->crc)
+               if (!be32_eq(calc_crc(vc, crl*512), vc->crc))
                        continue;
                if (memcmp(vc->guid, guid, DDF_GUID_LEN) != 0)
                        continue;
 
                /* Ok, we know about this VD, let's give more details */
                printf(" Raid Devices[%d] : %d (", n,
-                      __be16_to_cpu(vc->prim_elmnt_count));
-               for (i = 0; i < __be16_to_cpu(vc->prim_elmnt_count); i++) {
+                      be16_to_cpu(vc->prim_elmnt_count));
+               for (i = 0; i < be16_to_cpu(vc->prim_elmnt_count); i++) {
                        int j;
-                       int cnt = __be16_to_cpu(sb->phys->used_pdes);
+                       int cnt = be16_to_cpu(sb->phys->used_pdes);
                        for (j=0; j<cnt; j++)
-                               if (vc->phys_refnum[i] == sb->phys->entries[j].refnum)
+                               if (be32_eq(vc->phys_refnum[i],
+                                           sb->phys->entries[j].refnum))
                                        break;
                        if (i) printf(" ");
                        if (j < cnt)
@@ -1234,34 +1412,34 @@ static void examine_vd(int n, struct ddf_super *sb, char *guid)
                               map_num(ddf_sec_level, vc->srl) ?: "-unknown-");
                }
                printf("  Device Size[%d] : %llu\n", n,
-                      (unsigned long long)__be64_to_cpu(vc->blocks)/2);
+                      be64_to_cpu(vc->blocks)/2);
                printf("   Array Size[%d] : %llu\n", n,
-                      (unsigned long long)__be64_to_cpu(vc->array_blocks)/2);
+                      be64_to_cpu(vc->array_blocks)/2);
        }
 }
 
 static void examine_vds(struct ddf_super *sb)
 {
-       int cnt = __be16_to_cpu(sb->virt->populated_vdes);
+       int cnt = be16_to_cpu(sb->virt->populated_vdes);
        unsigned int i;
        printf("  Virtual Disks : %d\n", cnt);
 
-       for (i = 0; i < __be16_to_cpu(sb->virt->max_vdes); i++) {
+       for (i = 0; i < be16_to_cpu(sb->virt->max_vdes); i++) {
                struct virtual_entry *ve = &sb->virt->entries[i];
                if (all_ff(ve->guid))
                        continue;
                printf("\n");
                printf("      VD GUID[%d] : ", i); print_guid(ve->guid, 1);
                printf("\n");
-               printf("         unit[%d] : %d\n", i, __be16_to_cpu(ve->unit));
+               printf("         unit[%d] : %d\n", i, be16_to_cpu(ve->unit));
                printf("        state[%d] : %s, %s%s\n", i,
                       map_num(ddf_state, ve->state & 7),
-                      (ve->state & 8) ? "Morphing, ": "",
-                      (ve->state & 16)? "Not Consistent" : "Consistent");
+                      (ve->state & DDF_state_morphing) ? "Morphing, ": "",
+                      (ve->state & DDF_state_inconsistent)? "Not Consistent" : "Consistent");
                printf("   init state[%d] : %s\n", i,
-                      map_num(ddf_init_state, ve->init_state&3));
+                      map_num(ddf_init_state, ve->init_state&DDF_initstate_mask));
                printf("       access[%d] : %s\n", i,
-                      map_num(ddf_access, (ve->init_state>>6) & 3));
+                      map_num(ddf_access, (ve->init_state & DDF_access_mask) >> 6));
                printf("         Name[%d] : %.16s\n", i, ve->name);
                examine_vd(i, sb, ve->guid);
        }
@@ -1270,7 +1448,7 @@ static void examine_vds(struct ddf_super *sb)
 
 static void examine_pds(struct ddf_super *sb)
 {
-       int cnt = __be16_to_cpu(sb->phys->used_pdes);
+       int cnt = be16_to_cpu(sb->phys->used_pdes);
        int i;
        struct dl *dl;
        printf(" Physical Disks : %d\n", cnt);
@@ -1278,17 +1456,17 @@ static void examine_pds(struct ddf_super *sb)
 
        for (i=0 ; i<cnt ; i++) {
                struct phys_disk_entry *pd = &sb->phys->entries[i];
-               int type = __be16_to_cpu(pd->type);
-               int state = __be16_to_cpu(pd->state);
+               int type = be16_to_cpu(pd->type);
+               int state = be16_to_cpu(pd->state);
 
                //printf("      PD GUID[%d] : ", i); print_guid(pd->guid, 0);
                //printf("\n");
                printf("       %3d    %08x  ", i,
-                      __be32_to_cpu(pd->refnum));
+                      be32_to_cpu(pd->refnum));
                printf("%8lluK ",
-                      (unsigned long long)__be64_to_cpu(pd->config_size)>>1);
+                      be64_to_cpu(pd->config_size)>>1);
                for (dl = sb->dlist; dl ; dl = dl->next) {
-                       if (dl->disk.refnum == pd->refnum) {
+                       if (be32_eq(dl->disk.refnum, pd->refnum)) {
                                char *dv = map_dev(dl->major, dl->minor, 0);
                                if (dv) {
                                        printf("%-15s", dv);
@@ -1323,14 +1501,15 @@ static void examine_super_ddf(struct supertype *st, char *homehost)
 {
        struct ddf_super *sb = st->sb;
 
-       printf("          Magic : %08x\n", __be32_to_cpu(sb->anchor.magic));
+       printf("          Magic : %08x\n", be32_to_cpu(sb->anchor.magic));
        printf("        Version : %.8s\n", sb->anchor.revision);
        printf("Controller GUID : "); print_guid(sb->controller.guid, 0);
        printf("\n");
        printf(" Container GUID : "); print_guid(sb->anchor.guid, 1);
        printf("\n");
-       printf("            Seq : %08x\n", __be32_to_cpu(sb->active->seq));
-       printf("  Redundant hdr : %s\n", sb->secondary.magic == DDF_HEADER_MAGIC
+       printf("            Seq : %08x\n", be32_to_cpu(sb->active->seq));
+       printf("  Redundant hdr : %s\n", be32_eq(sb->secondary.magic,
+                                                DDF_HEADER_MAGIC)
               ?"yes" : "no");
        examine_vds(sb);
        examine_pds(sb);
@@ -1340,6 +1519,7 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
 
 static void uuid_from_ddf_guid(const char *guid, int uuid[4]);
 static void uuid_from_super_ddf(struct supertype *st, int uuid[4]);
+static void _ddf_array_name(char *name, const struct ddf_super *ddf, int i);
 
 static unsigned int get_vd_num_of_subarray(struct supertype *st)
 {
@@ -1366,7 +1546,7 @@ static unsigned int get_vd_num_of_subarray(struct supertype *st)
        if (sub != NULL)
                vcnum = strtoul(sub + 1, &end, 10);
        if (sub == NULL || *sub == '\0' || *end != '\0' ||
-           vcnum >= __be16_to_cpu(ddf->active->max_vd_entries))
+           vcnum >= be16_to_cpu(ddf->active->max_vd_entries))
                return DDF_NOTFOUND;
 
        return vcnum;
@@ -1395,17 +1575,21 @@ static void brief_examine_subarrays_ddf(struct supertype *st, int verbose)
        getinfo_super_ddf(st, &info, NULL);
        fname_from_uuid(st, &info, nbuf, ':');
 
-       for (i = 0; i < __be16_to_cpu(ddf->virt->max_vdes); i++) {
+       for (i = 0; i < be16_to_cpu(ddf->virt->max_vdes); i++) {
                struct virtual_entry *ve = &ddf->virt->entries[i];
                struct vcl vcl;
                char nbuf1[64];
+               char namebuf[17];
                if (all_ff(ve->guid))
                        continue;
                memcpy(vcl.conf.guid, ve->guid, DDF_GUID_LEN);
                ddf->currentconf =&vcl;
+               vcl.vcnum = i;
                uuid_from_super_ddf(st, info.uuid);
                fname_from_uuid(st, &info, nbuf1, ':');
-               printf("ARRAY container=%s member=%d UUID=%s\n",
+               _ddf_array_name(namebuf, ddf, i);
+               printf("ARRAY%s%s container=%s member=%d UUID=%s\n",
+                      namebuf[0] == '\0' ? "" : " /dev/md/", namebuf,
                       nbuf+5, i, nbuf1+5);
        }
 }
@@ -1419,6 +1603,8 @@ static void export_examine_super_ddf(struct supertype *st)
        printf("MD_METADATA=ddf\n");
        printf("MD_LEVEL=container\n");
        printf("MD_UUID=%s\n", nbuf+5);
+       printf("MD_DEVICES=%u\n",
+               be16_to_cpu(((struct ddf_super *)st->sb)->phys->used_pdes));
 }
 
 static int copy_metadata_ddf(struct supertype *st, int from, int to)
@@ -1449,17 +1635,17 @@ static int copy_metadata_ddf(struct supertype *st, int from, int to)
        if (read(from, buf, 512) != 512)
                goto err;
        ddf = buf;
-       if (ddf->magic != DDF_HEADER_MAGIC ||
-           calc_crc(ddf, 512) != ddf->crc ||
+       if (!be32_eq(ddf->magic, DDF_HEADER_MAGIC) ||
+           !be32_eq(calc_crc(ddf, 512), ddf->crc) ||
            (memcmp(ddf->revision, DDF_REVISION_0, 8) != 0 &&
             memcmp(ddf->revision, DDF_REVISION_2, 8) != 0))
                goto err;
 
        offset = dsize - 512;
-       if ((__be64_to_cpu(ddf->primary_lba) << 9) < offset)
-               offset = __be64_to_cpu(ddf->primary_lba) << 9;
-       if ((__be64_to_cpu(ddf->secondary_lba) << 9) < offset)
-               offset = __be64_to_cpu(ddf->secondary_lba) << 9;
+       if ((be64_to_cpu(ddf->primary_lba) << 9) < offset)
+               offset = be64_to_cpu(ddf->primary_lba) << 9;
+       if ((be64_to_cpu(ddf->secondary_lba) << 9) < offset)
+               offset = be64_to_cpu(ddf->secondary_lba) << 9;
 
        bytes = dsize - offset;
 
@@ -1493,6 +1679,51 @@ static void detail_super_ddf(struct supertype *st, char *homehost)
         */
 }
 
+static const char *vendors_with_variable_volume_UUID[] = {
+       "LSI      ",
+};
+
+static int volume_id_is_reliable(const struct ddf_super *ddf)
+{
+       int n = ARRAY_SIZE(vendors_with_variable_volume_UUID);
+       int i;
+       for (i = 0; i < n; i++)
+               if (!memcmp(ddf->controller.guid,
+                       vendors_with_variable_volume_UUID[i], 8))
+               return 0;
+       return 1;
+}
+
+static void uuid_of_ddf_subarray(const struct ddf_super *ddf,
+                                unsigned int vcnum, int uuid[4])
+{
+       char buf[DDF_GUID_LEN+18], sha[20], *p;
+       struct sha1_ctx ctx;
+       if (volume_id_is_reliable(ddf)) {
+               uuid_from_ddf_guid(ddf->virt->entries[vcnum].guid, uuid);
+               return;
+       }
+       /*
+        * Some fake RAID BIOSes (in particular, LSI ones) change the
+        * VD GUID at every boot. These GUIDs are not suitable for
+        * identifying an array. Luckily the header GUID appears to
+        * remain constant.
+        * We construct a pseudo-UUID from the header GUID and those
+        * properties of the subarray that we expect to remain constant.
+        */
+       memset(buf, 0, sizeof(buf));
+       p = buf;
+       memcpy(p, ddf->anchor.guid, DDF_GUID_LEN);
+       p += DDF_GUID_LEN;
+       memcpy(p, ddf->virt->entries[vcnum].name, 16);
+       p += 16;
+       *((__u16 *) p) = vcnum;
+       sha1_init_ctx(&ctx);
+       sha1_process_bytes(buf, sizeof(buf), &ctx);
+       sha1_finish_ctx(&ctx, sha);
+       memcpy(uuid, sha, 4*4);
+}
+
 static void brief_detail_super_ddf(struct supertype *st)
 {
        struct mdinfo info;
@@ -1504,7 +1735,7 @@ static void brief_detail_super_ddf(struct supertype *st)
        else if (vcnum == DDF_NOTFOUND)
                return;
        else
-               uuid_from_ddf_guid(ddf->virt->entries[vcnum].guid, info.uuid);
+               uuid_of_ddf_subarray(ddf, vcnum, info.uuid);
        fname_from_uuid(st, &info, nbuf,':');
        printf(" UUID=%s", nbuf + 5);
 }
@@ -1539,8 +1770,8 @@ static int find_index_in_bvd(const struct ddf_super *ddf,
         */
        unsigned int i, j;
        for (i = 0, j = 0; i < ddf->mppe &&
-                    j < __be16_to_cpu(conf->prim_elmnt_count); i++) {
-               if (conf->phys_refnum[i] != 0xffffffff) {
+                    j < be16_to_cpu(conf->prim_elmnt_count); i++) {
+               if (be32_to_cpu(conf->phys_refnum[i]) != 0xffffffff) {
                        if (n == j) {
                                *n_bvd = i;
                                return 1;
@@ -1549,7 +1780,7 @@ static int find_index_in_bvd(const struct ddf_super *ddf,
                }
        }
        dprintf("%s: couldn't find BVD member %u (total %u)\n",
-               __func__, n, __be16_to_cpu(conf->prim_elmnt_count));
+               __func__, n, be16_to_cpu(conf->prim_elmnt_count));
        return 0;
 }
 
@@ -1560,7 +1791,7 @@ static struct vd_config *find_vdcr(struct ddf_super *ddf, unsigned int inst,
        struct vcl *v;
 
        for (v = ddf->conflist; v; v = v->next) {
-               unsigned int nsec, ibvd;
+               unsigned int nsec, ibvd = 0;
                struct vd_config *conf;
                if (inst != v->vcnum)
                        continue;
@@ -1577,11 +1808,9 @@ static struct vd_config *find_vdcr(struct ddf_super *ddf, unsigned int inst,
                               __func__, conf->sec_elmnt_count);
                        goto bad;
                }
-               nsec = n / __be16_to_cpu(conf->prim_elmnt_count);
+               nsec = n / be16_to_cpu(conf->prim_elmnt_count);
                if (conf->sec_elmnt_seq != nsec) {
                        for (ibvd = 1; ibvd < conf->sec_elmnt_count; ibvd++) {
-                               if (v->other_bvds[ibvd-1] == NULL)
-                                       continue;
                                if (v->other_bvds[ibvd-1]->sec_elmnt_seq
                                    == nsec)
                                        break;
@@ -1594,7 +1823,7 @@ static struct vd_config *find_vdcr(struct ddf_super *ddf, unsigned int inst,
                                       n - nsec*conf->sec_elmnt_count, n_bvd))
                        goto bad;
                dprintf("%s: found disk %u as member %u in bvd %d of array %u\n"
-                       , __func__, n, *n_bvd, ibvd-1, inst);
+                       , __func__, n, *n_bvd, ibvd, inst);
                *vcl = v;
                return conf;
        }
@@ -1604,14 +1833,14 @@ bad:
 }
 #endif
 
-static int find_phys(const struct ddf_super *ddf, __u32 phys_refnum)
+static int find_phys(const struct ddf_super *ddf, be32 phys_refnum)
 {
        /* Find the entry in phys_disk which has the given refnum
         * and return it's index
         */
        unsigned int i;
-       for (i = 0; i < __be16_to_cpu(ddf->phys->max_pdes); i++)
-               if (ddf->phys->entries[i].refnum == phys_refnum)
+       for (i = 0; i < be16_to_cpu(ddf->phys->max_pdes); i++)
+               if (be32_eq(ddf->phys->entries[i].refnum, phys_refnum))
                        return i;
        return -1;
 }
@@ -1649,13 +1878,11 @@ static void uuid_from_super_ddf(struct supertype *st, int uuid[4])
         */
        struct ddf_super *ddf = st->sb;
        struct vcl *vcl = ddf->currentconf;
-       char *guid;
 
        if (vcl)
-               guid = vcl->conf.guid;
+               uuid_of_ddf_subarray(ddf, vcl->vcnum, uuid);
        else
-               guid = ddf->anchor.guid;
-       uuid_from_ddf_guid(guid, uuid);
+               uuid_from_ddf_guid(ddf->anchor.guid, uuid);
 }
 
 static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, char *map);
@@ -1672,7 +1899,7 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
        }
        memset(info, 0, sizeof(*info));
 
-       info->array.raid_disks    = __be16_to_cpu(ddf->phys->used_pdes);
+       info->array.raid_disks    = be16_to_cpu(ddf->phys->used_pdes);
        info->array.level         = LEVEL_CONTAINER;
        info->array.layout        = 0;
        info->array.md_minor      = -1;
@@ -1686,19 +1913,27 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
        info->disk.major = 0;
        info->disk.minor = 0;
        if (ddf->dlist) {
-               info->disk.number = __be32_to_cpu(ddf->dlist->disk.refnum);
+               struct phys_disk_entry *pde = NULL;
+               info->disk.number = be32_to_cpu(ddf->dlist->disk.refnum);
                info->disk.raid_disk = find_phys(ddf, ddf->dlist->disk.refnum);
 
-               info->data_offset = __be64_to_cpu(ddf->phys->
+               info->data_offset = be64_to_cpu(ddf->phys->
                                                  entries[info->disk.raid_disk].
                                                  config_size);
                info->component_size = ddf->dlist->size - info->data_offset;
+               if (info->disk.raid_disk >= 0)
+                       pde = ddf->phys->entries + info->disk.raid_disk;
+               if (pde &&
+                   !(be16_to_cpu(pde->state) & DDF_Failed))
+                       info->disk.state = (1 << MD_DISK_SYNC) | (1 << MD_DISK_ACTIVE);
+               else
+                       info->disk.state = 1 << MD_DISK_FAULTY;
        } else {
                info->disk.number = -1;
                info->disk.raid_disk = -1;
 //             info->disk.raid_disk = find refnum in the table and use index;
+               info->disk.state = (1 << MD_DISK_SYNC) | (1 << MD_DISK_ACTIVE);
        }
-       info->disk.state = (1 << MD_DISK_SYNC) | (1 << MD_DISK_ACTIVE);
 
        info->recovery_start = MaxSector;
        info->reshape_active = 0;
@@ -1716,8 +1951,8 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
                int i;
                for (i = 0 ; i < map_disks; i++) {
                        if (i < info->array.raid_disks &&
-                           (__be16_to_cpu(ddf->phys->entries[i].state) & DDF_Online) &&
-                           !(__be16_to_cpu(ddf->phys->entries[i].state) & DDF_Failed))
+                           !(be16_to_cpu(ddf->phys->entries[i].state)
+                             & DDF_Failed))
                                map[i] = 1;
                        else
                                map[i] = 0;
@@ -1725,15 +1960,28 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
        }
 }
 
+/* size of name must be at least 17 bytes! */
+static void _ddf_array_name(char *name, const struct ddf_super *ddf, int i)
+{
+       int j;
+       memcpy(name, ddf->virt->entries[i].name, 16);
+       name[16] = 0;
+       for(j = 0; j < 16; j++)
+               if (name[j] == ' ')
+                       name[j] = 0;
+}
+
 static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, char *map)
 {
        struct ddf_super *ddf = st->sb;
        struct vcl *vc = ddf->currentconf;
        int cd = ddf->currentdev;
+       int n_prim;
        int j;
        struct dl *dl;
        int map_disks = info->array.raid_disks;
        __u32 *cptr;
+       struct vd_config *conf;
 
        memset(info, 0, sizeof(*info));
        if (layout_ddf2md(&vc->conf, &info->array) == -1)
@@ -1741,20 +1989,29 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, cha
        info->array.md_minor      = -1;
        cptr = (__u32 *)(vc->conf.guid + 16);
        info->array.ctime         = DECADE + __be32_to_cpu(*cptr);
-       info->array.utime         = DECADE + __be32_to_cpu(vc->conf.timestamp);
+       info->array.utime         = DECADE + be32_to_cpu(vc->conf.timestamp);
        info->array.chunk_size    = 512 << vc->conf.chunk_shift;
        info->custom_array_size   = 0;
 
+       conf = &vc->conf;
+       n_prim = be16_to_cpu(conf->prim_elmnt_count);
+       if (conf->sec_elmnt_count > 1 && cd >= n_prim) {
+               int ibvd = cd / n_prim - 1;
+               cd %= n_prim;
+               conf = vc->other_bvds[ibvd];
+       }
+
        if (cd >= 0 && (unsigned)cd < ddf->mppe) {
-               info->data_offset         = __be64_to_cpu(vc->lba_offset[cd]);
+               info->data_offset =
+                       be64_to_cpu(LBA_OFFSET(ddf, conf)[cd]);
                if (vc->block_sizes)
                        info->component_size = vc->block_sizes[cd];
                else
-                       info->component_size = __be64_to_cpu(vc->conf.blocks);
+                       info->component_size = be64_to_cpu(conf->blocks);
        }
 
        for (dl = ddf->dlist; dl ; dl = dl->next)
-               if (dl->raiddisk == ddf->currentdev)
+               if (be32_eq(dl->disk.refnum, conf->phys_refnum[cd]))
                        break;
 
        info->disk.major = 0;
@@ -1763,9 +2020,14 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, cha
        if (dl) {
                info->disk.major = dl->major;
                info->disk.minor = dl->minor;
-               info->disk.raid_disk = dl->raiddisk;
+               info->disk.raid_disk = cd + conf->sec_elmnt_seq
+                       * be16_to_cpu(conf->prim_elmnt_count);
                info->disk.number = dl->pdnum;
-               info->disk.state = (1<<MD_DISK_SYNC)|(1<<MD_DISK_ACTIVE);
+               info->disk.state = 0;
+               if (info->disk.number >= 0 &&
+                   (be16_to_cpu(ddf->phys->entries[info->disk.number].state) & DDF_Online) &&
+                   !(be16_to_cpu(ddf->phys->entries[info->disk.number].state) & DDF_Failed))
+                       info->disk.state = (1<<MD_DISK_SYNC)|(1<<MD_DISK_ACTIVE);
        }
 
        info->container_member = ddf->currentconf->vcnum;
@@ -1788,13 +2050,9 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, cha
        sprintf(info->text_version, "/%s/%d",
                st->container_devnm,
                info->container_member);
-       info->safe_mode_delay = 200;
+       info->safe_mode_delay = DDF_SAFE_MODE_DELAY;
 
-       memcpy(info->name, ddf->virt->entries[info->container_member].name, 16);
-       info->name[16]=0;
-       for(j=0; j<16; j++)
-               if (info->name[j] == ' ')
-                       info->name[j] = 0;
+       _ddf_array_name(info->name, ddf, info->container_member);
 
        if (map)
                for (j = 0; j < map_disks; j++) {
@@ -1802,8 +2060,10 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info, cha
                        if (j <  info->array.raid_disks) {
                                int i = find_phys(ddf, vc->conf.phys_refnum[j]);
                                if (i >= 0 &&
-                                   (__be16_to_cpu(ddf->phys->entries[i].state) & DDF_Online) &&
-                                   !(__be16_to_cpu(ddf->phys->entries[i].state) & DDF_Failed))
+                                   (be16_to_cpu(ddf->phys->entries[i].state)
+                                    & DDF_Online) &&
+                                   !(be16_to_cpu(ddf->phys->entries[i].state)
+                                     & DDF_Failed))
                                        map[i] = 1;
                        }
                }
@@ -1880,7 +2140,7 @@ static int update_super_ddf(struct supertype *st, struct mdinfo *info,
 
 static void make_header_guid(char *guid)
 {
-       __u32 stamp;
+       be32 stamp;
        /* Create a DDF Header of Virtual Disk GUID */
 
        /* 24 bytes of fiction required.
@@ -1889,20 +2149,20 @@ static void make_header_guid(char *guid)
         * Remaining 8 random number plus timestamp
         */
        memcpy(guid, T10, sizeof(T10));
-       stamp = __cpu_to_be32(0xdeadbeef);
+       stamp = cpu_to_be32(0xdeadbeef);
        memcpy(guid+8, &stamp, 4);
-       stamp = __cpu_to_be32(0);
+       stamp = cpu_to_be32(0);
        memcpy(guid+12, &stamp, 4);
-       stamp = __cpu_to_be32(time(0) - DECADE);
+       stamp = cpu_to_be32(time(0) - DECADE);
        memcpy(guid+16, &stamp, 4);
-       stamp = random32();
+       stamp._v32 = random32();
        memcpy(guid+20, &stamp, 4);
 }
 
 static unsigned int find_unused_vde(const struct ddf_super *ddf)
 {
        unsigned int i;
-       for (i = 0; i < __be16_to_cpu(ddf->virt->max_vdes); i++) {
+       for (i = 0; i < be16_to_cpu(ddf->virt->max_vdes); i++) {
                if (all_ff(ddf->virt->entries[i].guid))
                        return i;
        }
@@ -1915,7 +2175,7 @@ static unsigned int find_vde_by_name(const struct ddf_super *ddf,
        unsigned int i;
        if (name == NULL)
                return DDF_NOTFOUND;
-       for (i = 0; i < __be16_to_cpu(ddf->virt->max_vdes); i++) {
+       for (i = 0; i < be16_to_cpu(ddf->virt->max_vdes); i++) {
                if (all_ff(ddf->virt->entries[i].guid))
                        continue;
                if (!strncmp(name, ddf->virt->entries[i].name,
@@ -1925,17 +2185,19 @@ static unsigned int find_vde_by_name(const struct ddf_super *ddf,
        return DDF_NOTFOUND;
 }
 
+#ifndef MDASSEMBLE
 static unsigned int find_vde_by_guid(const struct ddf_super *ddf,
                                     const char *guid)
 {
        unsigned int i;
        if (guid == NULL || all_ff(guid))
                return DDF_NOTFOUND;
-       for (i = 0; i < __be16_to_cpu(ddf->virt->max_vdes); i++)
+       for (i = 0; i < be16_to_cpu(ddf->virt->max_vdes); i++)
                if (!memcmp(ddf->virt->entries[i].guid, guid, DDF_GUID_LEN))
                        return i;
        return DDF_NOTFOUND;
 }
+#endif
 
 static int init_super_ddf_bvd(struct supertype *st,
                              mdu_array_info_t *info,
@@ -2017,37 +2279,37 @@ static int init_super_ddf(struct supertype *st,
        make_header_guid(ddf->anchor.guid);
 
        memcpy(ddf->anchor.revision, DDF_REVISION_2, 8);
-       ddf->anchor.seq = __cpu_to_be32(1);
-       ddf->anchor.timestamp = __cpu_to_be32(time(0) - DECADE);
+       ddf->anchor.seq = cpu_to_be32(1);
+       ddf->anchor.timestamp = cpu_to_be32(time(0) - DECADE);
        ddf->anchor.openflag = 0xFF;
        ddf->anchor.foreignflag = 0;
        ddf->anchor.enforcegroups = 0; /* Is this best?? */
        ddf->anchor.pad0 = 0xff;
        memset(ddf->anchor.pad1, 0xff, 12);
        memset(ddf->anchor.header_ext, 0xff, 32);
-       ddf->anchor.primary_lba = ~(__u64)0;
-       ddf->anchor.secondary_lba = ~(__u64)0;
+       ddf->anchor.primary_lba = cpu_to_be64(~(__u64)0);
+       ddf->anchor.secondary_lba = cpu_to_be64(~(__u64)0);
        ddf->anchor.type = DDF_HEADER_ANCHOR;
        memset(ddf->anchor.pad2, 0xff, 3);
-       ddf->anchor.workspace_len = __cpu_to_be32(32768); /* Must be reserved */
-       ddf->anchor.workspace_lba = ~(__u64)0; /* Put this at bottom
-                                                 of 32M reserved.. */
+       ddf->anchor.workspace_len = cpu_to_be32(32768); /* Must be reserved */
+       /* Put this at bottom of 32M reserved.. */
+       ddf->anchor.workspace_lba = cpu_to_be64(~(__u64)0);
        max_phys_disks = 1023;   /* Should be enough */
-       ddf->anchor.max_pd_entries = __cpu_to_be16(max_phys_disks);
+       ddf->anchor.max_pd_entries = cpu_to_be16(max_phys_disks);
        max_virt_disks = 255;
-       ddf->anchor.max_vd_entries = __cpu_to_be16(max_virt_disks); /* ?? */
-       ddf->anchor.max_partitions = __cpu_to_be16(64); /* ?? */
+       ddf->anchor.max_vd_entries = cpu_to_be16(max_virt_disks); /* ?? */
+       ddf->anchor.max_partitions = cpu_to_be16(64); /* ?? */
        ddf->max_part = 64;
        ddf->mppe = 256;
        ddf->conf_rec_len = 1 + ROUND_UP(ddf->mppe * (4+8), 512)/512;
-       ddf->anchor.config_record_len = __cpu_to_be16(ddf->conf_rec_len);
-       ddf->anchor.max_primary_element_entries = __cpu_to_be16(ddf->mppe);
+       ddf->anchor.config_record_len = cpu_to_be16(ddf->conf_rec_len);
+       ddf->anchor.max_primary_element_entries = cpu_to_be16(ddf->mppe);
        memset(ddf->anchor.pad3, 0xff, 54);
        /* controller sections is one sector long immediately
         * after the ddf header */
        sector = 1;
-       ddf->anchor.controller_section_offset = __cpu_to_be32(sector);
-       ddf->anchor.controller_section_length = __cpu_to_be32(1);
+       ddf->anchor.controller_section_offset = cpu_to_be32(sector);
+       ddf->anchor.controller_section_length = cpu_to_be32(1);
        sector += 1;
 
        /* phys is 8 sectors after that */
@@ -2058,9 +2320,9 @@ static int init_super_ddf(struct supertype *st,
        case 2: case 8: case 32: case 128: case 512: break;
        default: abort();
        }
-       ddf->anchor.phys_section_offset = __cpu_to_be32(sector);
+       ddf->anchor.phys_section_offset = cpu_to_be32(sector);
        ddf->anchor.phys_section_length =
-               __cpu_to_be32(pdsize/512); /* max_primary_element_entries/8 */
+               cpu_to_be32(pdsize/512); /* max_primary_element_entries/8 */
        sector += pdsize/512;
 
        /* virt is another 32 sectors */
@@ -2071,26 +2333,26 @@ static int init_super_ddf(struct supertype *st,
        case 2: case 8: case 32: case 128: case 512: break;
        default: abort();
        }
-       ddf->anchor.virt_section_offset = __cpu_to_be32(sector);
+       ddf->anchor.virt_section_offset = cpu_to_be32(sector);
        ddf->anchor.virt_section_length =
-               __cpu_to_be32(vdsize/512); /* max_vd_entries/8 */
+               cpu_to_be32(vdsize/512); /* max_vd_entries/8 */
        sector += vdsize/512;
 
        clen = ddf->conf_rec_len * (ddf->max_part+1);
-       ddf->anchor.config_section_offset = __cpu_to_be32(sector);
-       ddf->anchor.config_section_length = __cpu_to_be32(clen);
+       ddf->anchor.config_section_offset = cpu_to_be32(sector);
+       ddf->anchor.config_section_length = cpu_to_be32(clen);
        sector += clen;
 
-       ddf->anchor.data_section_offset = __cpu_to_be32(sector);
-       ddf->anchor.data_section_length = __cpu_to_be32(1);
+       ddf->anchor.data_section_offset = cpu_to_be32(sector);
+       ddf->anchor.data_section_length = cpu_to_be32(1);
        sector += 1;
 
-       ddf->anchor.bbm_section_length = __cpu_to_be32(0);
-       ddf->anchor.bbm_section_offset = __cpu_to_be32(0xFFFFFFFF);
-       ddf->anchor.diag_space_length = __cpu_to_be32(0);
-       ddf->anchor.diag_space_offset = __cpu_to_be32(0xFFFFFFFF);
-       ddf->anchor.vendor_length = __cpu_to_be32(0);
-       ddf->anchor.vendor_offset = __cpu_to_be32(0xFFFFFFFF);
+       ddf->anchor.bbm_section_length = cpu_to_be32(0);
+       ddf->anchor.bbm_section_offset = cpu_to_be32(0xFFFFFFFF);
+       ddf->anchor.diag_space_length = cpu_to_be32(0);
+       ddf->anchor.diag_space_offset = cpu_to_be32(0xFFFFFFFF);
+       ddf->anchor.vendor_length = cpu_to_be32(0);
+       ddf->anchor.vendor_offset = cpu_to_be32(0xFFFFFFFF);
 
        memset(ddf->anchor.pad4, 0xff, 256);
 
@@ -2119,10 +2381,10 @@ static int init_super_ddf(struct supertype *st,
        for (i = strlen(T10) ; i+hostlen < 24; i++)
                ddf->controller.guid[i] = ' ';
 
-       ddf->controller.type.vendor_id = __cpu_to_be16(0xDEAD);
-       ddf->controller.type.device_id = __cpu_to_be16(0xBEEF);
-       ddf->controller.type.sub_vendor_id = 0;
-       ddf->controller.type.sub_device_id = 0;
+       ddf->controller.type.vendor_id = cpu_to_be16(0xDEAD);
+       ddf->controller.type.device_id = cpu_to_be16(0xBEEF);
+       ddf->controller.type.sub_vendor_id = cpu_to_be16(0);
+       ddf->controller.type.sub_device_id = cpu_to_be16(0);
        memcpy(ddf->controller.product_id, "What Is My PID??", 16);
        memset(ddf->controller.pad, 0xff, 8);
        memset(ddf->controller.vendor_data, 0xff, 448);
@@ -2139,9 +2401,11 @@ static int init_super_ddf(struct supertype *st,
        memset(pd, 0xff, pdsize);
        memset(pd, 0, sizeof(*pd));
        pd->magic = DDF_PHYS_RECORDS_MAGIC;
-       pd->used_pdes = __cpu_to_be16(0);
-       pd->max_pdes = __cpu_to_be16(max_phys_disks);
+       pd->used_pdes = cpu_to_be16(0);
+       pd->max_pdes = cpu_to_be16(max_phys_disks);
        memset(pd->pad, 0xff, 52);
+       for (i = 0; i < max_phys_disks; i++)
+               memset(pd->entries[i].guid, 0xff, DDF_GUID_LEN);
 
        if (posix_memalign((void**)&vd, 512, vdsize) != 0) {
                pr_err("%s could not allocate vd\n", __func__);
@@ -2151,8 +2415,8 @@ static int init_super_ddf(struct supertype *st,
        ddf->vdsize = vdsize;
        memset(vd, 0, vdsize);
        vd->magic = DDF_VIRT_RECORDS_MAGIC;
-       vd->populated_vdes = __cpu_to_be16(0);
-       vd->max_vdes = __cpu_to_be16(max_virt_disks);
+       vd->populated_vdes = cpu_to_be16(0);
+       vd->max_vdes = cpu_to_be16(max_virt_disks);
        memset(vd->pad, 0xff, 52);
 
        for (i=0; i<max_virt_disks; i++)
@@ -2168,59 +2432,6 @@ static int chunk_to_shift(int chunksize)
        return ffs(chunksize/512)-1;
 }
 
-static int level_to_prl(int level)
-{
-       switch (level) {
-       case LEVEL_LINEAR: return DDF_CONCAT;
-       case 0: return DDF_RAID0;
-       case 1: return DDF_RAID1;
-       case 4: return DDF_RAID4;
-       case 5: return DDF_RAID5;
-       case 6: return DDF_RAID6;
-       default: return -1;
-       }
-}
-
-static int layout_to_rlq(int level, int layout, int raiddisks)
-{
-       switch(level) {
-       case 0:
-               return DDF_RAID0_SIMPLE;
-       case 1:
-               switch(raiddisks) {
-               case 2: return DDF_RAID1_SIMPLE;
-               case 3: return DDF_RAID1_MULTI;
-               default: return -1;
-               }
-       case 4:
-               switch(layout) {
-               case 0: return DDF_RAID4_N;
-               }
-               break;
-       case 5:
-               switch(layout) {
-               case ALGORITHM_LEFT_ASYMMETRIC:
-                       return DDF_RAID5_N_RESTART;
-               case ALGORITHM_RIGHT_ASYMMETRIC:
-                       return DDF_RAID5_0_RESTART;
-               case ALGORITHM_LEFT_SYMMETRIC:
-                       return DDF_RAID5_N_CONTINUE;
-               case ALGORITHM_RIGHT_SYMMETRIC:
-                       return -1; /* not mentioned in standard */
-               }
-       case 6:
-               switch(layout) {
-               case ALGORITHM_ROTATING_N_RESTART:
-                       return DDF_RAID5_N_RESTART;
-               case ALGORITHM_ROTATING_ZERO_RESTART:
-                       return DDF_RAID6_0_RESTART;
-               case ALGORITHM_ROTATING_N_CONTINUE:
-                       return DDF_RAID5_N_CONTINUE;
-               }
-       }
-       return -1;
-}
-
 #ifndef MDASSEMBLE
 struct extent {
        unsigned long long start, size;
@@ -2247,26 +2458,29 @@ static struct extent *get_extents(struct ddf_super *ddf, struct dl *dl)
         */
        struct extent *rv;
        int n = 0;
-       unsigned int i, j;
+       unsigned int i;
+       __u16 state = be16_to_cpu(ddf->phys->entries[dl->pdnum].state);
+
+       if ((state & (DDF_Online|DDF_Failed|DDF_Missing)) != DDF_Online)
+               return NULL;
 
        rv = xmalloc(sizeof(struct extent) * (ddf->max_part + 2));
 
        for (i = 0; i < ddf->max_part; i++) {
+               const struct vd_config *bvd;
+               unsigned int ibvd;
                struct vcl *v = dl->vlist[i];
-               if (v == NULL)
+               if (v == NULL ||
+                   get_pd_index_from_refnum(v, dl->disk.refnum, ddf->mppe,
+                                            &bvd, &ibvd) == DDF_NOTFOUND)
                        continue;
-               for (j = 0; j < v->conf.prim_elmnt_count; j++)
-                       if (v->conf.phys_refnum[j] == dl->disk.refnum) {
-                               /* This device plays role 'j' in  'v'. */
-                               rv[n].start = __be64_to_cpu(v->lba_offset[j]);
-                               rv[n].size = __be64_to_cpu(v->conf.blocks);
-                               n++;
-                               break;
-                       }
+               rv[n].start = be64_to_cpu(LBA_OFFSET(ddf, bvd)[ibvd]);
+               rv[n].size = be64_to_cpu(bvd->blocks);
+               n++;
        }
        qsort(rv, n, sizeof(*rv), cmp_extent);
 
-       rv[n].start = __be64_to_cpu(ddf->phys->entries[dl->pdnum].config_size);
+       rv[n].start = be64_to_cpu(ddf->phys->entries[dl->pdnum].config_size);
        rv[n].size = 0;
        return rv;
 }
@@ -2283,7 +2497,7 @@ static int init_super_ddf_bvd(struct supertype *st,
         * We need to create a new vd_config and a new virtual_entry
         */
        struct ddf_super *ddf = st->sb;
-       unsigned int venum;
+       unsigned int venum, i;
        struct virtual_entry *ve;
        struct vcl *vcl;
        struct vd_config *vc;
@@ -2303,10 +2517,11 @@ static int init_super_ddf_bvd(struct supertype *st,
         * timestamp, random number
         */
        make_header_guid(ve->guid);
-       ve->unit = __cpu_to_be16(info->md_minor);
+       ve->unit = cpu_to_be16(info->md_minor);
        ve->pad0 = 0xFFFF;
-       ve->guid_crc = crc32(0, (unsigned char*)ddf->anchor.guid, DDF_GUID_LEN);
-       ve->type = 0;
+       ve->guid_crc._v16 = crc32(0, (unsigned char *)ddf->anchor.guid,
+                                 DDF_GUID_LEN);
+       ve->type = cpu_to_be16(0);
        ve->state = DDF_state_degraded; /* Will be modified as devices are added */
        if (info->state & 1) /* clean */
                ve->init_state = DDF_init_full;
@@ -2318,7 +2533,7 @@ static int init_super_ddf_bvd(struct supertype *st,
        if (name)
                strncpy(ve->name, name, 16);
        ddf->virt->populated_vdes =
-               __cpu_to_be16(__be16_to_cpu(ddf->virt->populated_vdes)+1);
+               cpu_to_be16(be16_to_cpu(ddf->virt->populated_vdes)+1);
 
        /* Now create a new vd_config */
        if (posix_memalign((void**)&vcl, 512,
@@ -2326,38 +2541,43 @@ static int init_super_ddf_bvd(struct supertype *st,
                pr_err("%s could not allocate vd_config\n", __func__);
                return 0;
        }
-       vcl->lba_offset = (__u64*) &vcl->conf.phys_refnum[ddf->mppe];
        vcl->vcnum = venum;
        vcl->block_sizes = NULL; /* FIXME not for CONCAT */
-       vcl->other_bvds = NULL;
-
        vc = &vcl->conf;
 
        vc->magic = DDF_VD_CONF_MAGIC;
        memcpy(vc->guid, ve->guid, DDF_GUID_LEN);
-       vc->timestamp = __cpu_to_be32(time(0)-DECADE);
-       vc->seqnum = __cpu_to_be32(1);
+       vc->timestamp = cpu_to_be32(time(0)-DECADE);
+       vc->seqnum = cpu_to_be32(1);
        memset(vc->pad0, 0xff, 24);
-       vc->prim_elmnt_count = __cpu_to_be16(info->raid_disks);
        vc->chunk_shift = chunk_to_shift(info->chunk_size);
-       vc->prl = level_to_prl(info->level);
-       vc->rlq = layout_to_rlq(info->level, info->layout, info->raid_disks);
-       vc->sec_elmnt_count = 1;
+       if (layout_md2ddf(info, vc) == -1 ||
+               be16_to_cpu(vc->prim_elmnt_count) > ddf->mppe) {
+               pr_err("%s: unsupported RAID level/layout %d/%d with %d disks\n",
+                      __func__, info->level, info->layout, info->raid_disks);
+               free(vcl);
+               return 0;
+       }
        vc->sec_elmnt_seq = 0;
-       vc->srl = 0;
-       vc->blocks = __cpu_to_be64(info->size * 2);
-       vc->array_blocks = __cpu_to_be64(
+       if (alloc_other_bvds(ddf, vcl) != 0) {
+               pr_err("%s could not allocate other bvds\n",
+                      __func__);
+               free(vcl);
+               return 0;
+       }
+       vc->blocks = cpu_to_be64(info->size * 2);
+       vc->array_blocks = cpu_to_be64(
                calc_array_size(info->level, info->raid_disks, info->layout,
                                info->chunk_size, info->size*2));
        memset(vc->pad1, 0xff, 8);
-       vc->spare_refs[0] = 0xffffffff;
-       vc->spare_refs[1] = 0xffffffff;
-       vc->spare_refs[2] = 0xffffffff;
-       vc->spare_refs[3] = 0xffffffff;
-       vc->spare_refs[4] = 0xffffffff;
-       vc->spare_refs[5] = 0xffffffff;
-       vc->spare_refs[6] = 0xffffffff;
-       vc->spare_refs[7] = 0xffffffff;
+       vc->spare_refs[0] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[1] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[2] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[3] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[4] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[5] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[6] = cpu_to_be32(0xffffffff);
+       vc->spare_refs[7] = cpu_to_be32(0xffffffff);
        memset(vc->cache_pol, 0, 8);
        vc->bg_rate = 0x80;
        memset(vc->pad2, 0xff, 3);
@@ -2372,6 +2592,11 @@ static int init_super_ddf_bvd(struct supertype *st,
        memset(vc->phys_refnum, 0xff, 4*ddf->mppe);
        memset(vc->phys_refnum+ddf->mppe, 0x00, 8*ddf->mppe);
 
+       for (i = 1; i < vc->sec_elmnt_count; i++) {
+               memcpy(vcl->other_bvds[i-1], vc, ddf->conf_rec_len * 512);
+               vcl->other_bvds[i-1]->sec_elmnt_seq = i;
+       }
+
        vcl->next = ddf->conflist;
        ddf->conflist = vcl;
        ddf->currentconf = vcl;
@@ -2379,7 +2604,10 @@ static int init_super_ddf_bvd(struct supertype *st,
        return 1;
 }
 
+
 #ifndef MDASSEMBLE
+static int get_svd_state(const struct ddf_super *, const struct vcl *);
+
 static void add_to_super_ddf_bvd(struct supertype *st,
                                 mdu_disk_info_t *dk, int fd, char *devname)
 {
@@ -2396,11 +2624,10 @@ static void add_to_super_ddf_bvd(struct supertype *st,
        struct dl *dl;
        struct ddf_super *ddf = st->sb;
        struct vd_config *vc;
-       __u64 *lba_offset;
-       unsigned int working;
        unsigned int i;
        unsigned long long blocks, pos, esize;
        struct extent *ex;
+       unsigned int raid_disk = dk->raid_disk;
 
        if (fd == -1) {
                for (dl = ddf->dlist; dl ; dl = dl->next)
@@ -2416,14 +2643,19 @@ static void add_to_super_ddf_bvd(struct supertype *st,
                return;
 
        vc = &ddf->currentconf->conf;
-       lba_offset = ddf->currentconf->lba_offset;
+       if (vc->sec_elmnt_count > 1) {
+               unsigned int n = be16_to_cpu(vc->prim_elmnt_count);
+               if (raid_disk >= n)
+                       vc = ddf->currentconf->other_bvds[raid_disk / n - 1];
+               raid_disk %= n;
+       }
 
        ex = get_extents(ddf, dl);
        if (!ex)
                return;
 
        i = 0; pos = 0;
-       blocks = __be64_to_cpu(vc->blocks);
+       blocks = be64_to_cpu(vc->blocks);
        if (ddf->currentconf->block_sizes)
                blocks = ddf->currentconf->block_sizes[dk->raid_disk];
 
@@ -2440,8 +2672,8 @@ static void add_to_super_ddf_bvd(struct supertype *st,
                return;
 
        ddf->currentdev = dk->raid_disk;
-       vc->phys_refnum[dk->raid_disk] = dl->disk.refnum;
-       lba_offset[dk->raid_disk] = __cpu_to_be64(pos);
+       vc->phys_refnum[raid_disk] = dl->disk.refnum;
+       LBA_OFFSET(ddf, vc)[raid_disk] = cpu_to_be64(pos);
 
        for (i = 0; i < ddf->max_part ; i++)
                if (dl->vlist[i] == NULL)
@@ -2455,33 +2687,57 @@ static void add_to_super_ddf_bvd(struct supertype *st,
        if (devname)
                dl->devname = devname;
 
-       /* Check how many working raid_disks, and if we can mark
-        * array as optimal yet
-        */
-       working = 0;
-
-       for (i = 0; i < __be16_to_cpu(vc->prim_elmnt_count); i++)
-               if (vc->phys_refnum[i] != 0xffffffff)
-                       working++;
-
-       /* Find which virtual_entry */
+       /* Check if we can mark array as optimal yet */
        i = ddf->currentconf->vcnum;
-       if (working == __be16_to_cpu(vc->prim_elmnt_count))
-               ddf->virt->entries[i].state =
-                       (ddf->virt->entries[i].state & ~DDF_state_mask)
-                       | DDF_state_optimal;
-
-       if (vc->prl == DDF_RAID6 &&
-           working+1 == __be16_to_cpu(vc->prim_elmnt_count))
-               ddf->virt->entries[i].state =
-                       (ddf->virt->entries[i].state & ~DDF_state_mask)
-                       | DDF_state_part_optimal;
-
-       ddf->phys->entries[dl->pdnum].type &= ~__cpu_to_be16(DDF_Global_Spare);
-       ddf->phys->entries[dl->pdnum].type |= __cpu_to_be16(DDF_Active_in_VD);
+       ddf->virt->entries[i].state =
+               (ddf->virt->entries[i].state & ~DDF_state_mask)
+               | get_svd_state(ddf, ddf->currentconf);
+       be16_clear(ddf->phys->entries[dl->pdnum].type,
+                  cpu_to_be16(DDF_Global_Spare));
+       be16_set(ddf->phys->entries[dl->pdnum].type,
+                cpu_to_be16(DDF_Active_in_VD));
+       dprintf("%s: added disk %d/%08x to VD %d/%s as disk %d\n",
+               __func__, dl->pdnum, be32_to_cpu(dl->disk.refnum),
+               ddf->currentconf->vcnum, guid_str(vc->guid),
+               dk->raid_disk);
        ddf_set_updates_pending(ddf);
 }
 
+static unsigned int find_unused_pde(const struct ddf_super *ddf)
+{
+       unsigned int i;
+       for (i = 0; i < be16_to_cpu(ddf->phys->max_pdes); i++) {
+               if (all_ff(ddf->phys->entries[i].guid))
+                       return i;
+       }
+       return DDF_NOTFOUND;
+}
+
+static void _set_config_size(struct phys_disk_entry *pde, const struct dl *dl)
+{
+       __u64 cfs, t;
+       cfs = min(dl->size - 32*1024*2ULL, be64_to_cpu(dl->primary_lba));
+       t = be64_to_cpu(dl->secondary_lba);
+       if (t != ~(__u64)0)
+               cfs = min(cfs, t);
+       /*
+        * Some vendor DDF structures interpret workspace_lba
+        * very differently then us. Make a sanity check on the value.
+        */
+       t = be64_to_cpu(dl->workspace_lba);
+       if (t < cfs) {
+               __u64 wsp = cfs - t;
+               if (wsp > 1024*1024*2ULL && wsp > dl->size / 16) {
+                       pr_err("%s: %x:%x: workspace size 0x%llx too big, ignoring\n",
+                              __func__, dl->major, dl->minor, wsp);
+               } else
+                       cfs = t;
+       }
+       pde->config_size = cpu_to_be64(cfs);
+       dprintf("%s: %x:%x config_size %llx, DDF structure is %llx blocks\n",
+               __func__, dl->major, dl->minor, cfs, dl->size-cfs);
+}
+
 /* add a device to a container, either while creating it or while
  * expanding a pre-existing container
  */
@@ -2508,6 +2764,21 @@ static int add_to_super_ddf(struct supertype *st,
         * a phys_disk entry and a more detailed disk_data entry.
         */
        fstat(fd, &stb);
+       n = find_unused_pde(ddf);
+       if (n == DDF_NOTFOUND) {
+               pr_err("%s: No free slot in array, cannot add disk\n",
+                      __func__);
+               return 1;
+       }
+       pde = &ddf->phys->entries[n];
+       get_dev_size(fd, NULL, &size);
+       if (size <= 32*1024*1024) {
+               pr_err("%s: device size must be at least 32MB\n",
+                      __func__);
+               return 1;
+       }
+       size >>= 9;
+
        if (posix_memalign((void**)&dd, 512,
                           sizeof(*dd) + sizeof(dd->vlist[0]) * ddf->max_part) != 0) {
                pr_err("%s could allocate buffer for new disk, aborting\n",
@@ -2531,10 +2802,11 @@ static int add_to_super_ddf(struct supertype *st,
 
        do {
                /* Cannot be bothered finding a CRC of some irrelevant details*/
-               dd->disk.refnum = random32();
-               for (i = __be16_to_cpu(ddf->active->max_pd_entries);
+               dd->disk.refnum._v32 = random32();
+               for (i = be16_to_cpu(ddf->active->max_pd_entries);
                     i > 0; i--)
-                       if (ddf->phys->entries[i-1].refnum == dd->disk.refnum)
+                       if (be32_eq(ddf->phys->entries[i-1].refnum,
+                                   dd->disk.refnum))
                                break;
        } while (i > 0);
 
@@ -2546,8 +2818,6 @@ static int add_to_super_ddf(struct supertype *st,
        for (i = 0; i < ddf->max_part ; i++)
                dd->vlist[i] = NULL;
 
-       n = __be16_to_cpu(ddf->phys->used_pdes);
-       pde = &ddf->phys->entries[n];
        dd->pdnum = n;
 
        if (st->update_tail) {
@@ -2557,25 +2827,44 @@ static int add_to_super_ddf(struct supertype *st,
 
                pd = xmalloc(len);
                pd->magic = DDF_PHYS_RECORDS_MAGIC;
-               pd->used_pdes = __cpu_to_be16(n);
+               pd->used_pdes = cpu_to_be16(n);
                pde = &pd->entries[0];
                dd->mdupdate = pd;
-       } else {
-               n++;
-               ddf->phys->used_pdes = __cpu_to_be16(n);
-       }
+       } else
+               ddf->phys->used_pdes = cpu_to_be16(
+                       1 + be16_to_cpu(ddf->phys->used_pdes));
 
        memcpy(pde->guid, dd->disk.guid, DDF_GUID_LEN);
        pde->refnum = dd->disk.refnum;
-       pde->type = __cpu_to_be16(DDF_Forced_PD_GUID | DDF_Global_Spare);
-       pde->state = __cpu_to_be16(DDF_Online);
-       get_dev_size(fd, NULL, &size);
-       /* We are required to reserve 32Meg, and record the size in sectors */
-       pde->config_size = __cpu_to_be64( (size - 32*1024*1024) / 512);
+       pde->type = cpu_to_be16(DDF_Forced_PD_GUID | DDF_Global_Spare);
+       pde->state = cpu_to_be16(DDF_Online);
+       dd->size = size;
+       /*
+        * If there is already a device in dlist, try to reserve the same
+        * amount of workspace. Otherwise, use 32MB.
+        * We checked disk size above already.
+        */
+#define __calc_lba(new, old, lba, mb) do { \
+               unsigned long long dif; \
+               if ((old) != NULL) \
+                       dif = (old)->size - be64_to_cpu((old)->lba); \
+               else \
+                       dif = (new)->size; \
+               if ((new)->size > dif) \
+                       (new)->lba = cpu_to_be64((new)->size - dif); \
+               else \
+                       (new)->lba = cpu_to_be64((new)->size - (mb*1024*2)); \
+       } while (0)
+       __calc_lba(dd, ddf->dlist, workspace_lba, 32);
+       __calc_lba(dd, ddf->dlist, primary_lba, 16);
+       if (ddf->dlist == NULL ||
+           be64_to_cpu(ddf->dlist->secondary_lba) != ~(__u64)0)
+               __calc_lba(dd, ddf->dlist, secondary_lba, 32);
+       _set_config_size(pde, dd);
+
        sprintf(pde->path, "%17.17s","Information: nil") ;
        memset(pde->pad, 0xff, 6);
 
-       dd->size = size >> 9;
        if (st->update_tail) {
                dd->next = ddf->add_list;
                ddf->add_list = dd;
@@ -2615,12 +2904,13 @@ static int remove_from_super_ddf(struct supertype *st, mdu_disk_info_t *dk)
 
                pd = xmalloc(len);
                pd->magic = DDF_PHYS_RECORDS_MAGIC;
-               pd->used_pdes = __cpu_to_be16(dl->pdnum);
-               pd->entries[0].state = __cpu_to_be16(DDF_Missing);
+               pd->used_pdes = cpu_to_be16(dl->pdnum);
+               pd->entries[0].state = cpu_to_be16(DDF_Missing);
                append_metadata_update(st, pd, len);
        }
        return 0;
 }
+#endif
 
 /*
  * This is the write_init_super method for a ddf container.  It is
@@ -2629,33 +2919,30 @@ static int remove_from_super_ddf(struct supertype *st, mdu_disk_info_t *dk)
  */
 #define NULL_CONF_SZ   4096
 
-static unsigned int get_pd_index_from_refnum(const struct vcl *vc,
-                                            __u32 refnum, unsigned int nmax,
-                                            const struct vd_config **bvd,
-                                            unsigned int *idx);
-
-static int __write_ddf_structure(struct dl *d, struct ddf_super *ddf, __u8 type,
-                                char *null_aligned)
+static int __write_ddf_structure(struct dl *d, struct ddf_super *ddf, __u8 type)
 {
        unsigned long long sector;
        struct ddf_header *header;
-       int fd, i, n_config, conf_size;
+       int fd, i, n_config, conf_size, buf_size;
        int ret = 0;
+       char *conf;
 
        fd = d->fd;
 
        switch (type) {
        case DDF_HEADER_PRIMARY:
                header = &ddf->primary;
-               sector = __be64_to_cpu(header->primary_lba);
+               sector = be64_to_cpu(header->primary_lba);
                break;
        case DDF_HEADER_SECONDARY:
                header = &ddf->secondary;
-               sector = __be64_to_cpu(header->secondary_lba);
+               sector = be64_to_cpu(header->secondary_lba);
                break;
        default:
                return 0;
        }
+       if (sector == ~(__u64)0)
+               return 0;
 
        header->type = type;
        header->openflag = 1;
@@ -2679,6 +2966,13 @@ static int __write_ddf_structure(struct dl *d, struct ddf_super *ddf, __u8 type,
        /* Now write lots of config records. */
        n_config = ddf->max_part;
        conf_size = ddf->conf_rec_len * 512;
+       conf = ddf->conf;
+       buf_size = conf_size * (n_config + 1);
+       if (!conf) {
+               if (posix_memalign((void**)&conf, 512, buf_size) != 0)
+                       goto out;
+               ddf->conf = conf;
+       }
        for (i = 0 ; i <= n_config ; i++) {
                struct vcl *c;
                struct vd_config *vdc = NULL;
@@ -2697,22 +2991,17 @@ static int __write_ddf_structure(struct dl *d, struct ddf_super *ddf, __u8 type,
                                        &dummy);
                }
                if (c) {
+                       dprintf("writing conf record %i on disk %08x for %s/%u\n",
+                               i, be32_to_cpu(d->disk.refnum),
+                               guid_str(vdc->guid),
+                               vdc->sec_elmnt_seq);
                        vdc->seqnum = header->seq;
                        vdc->crc = calc_crc(vdc, conf_size);
-                       if (write(fd, vdc, conf_size) < 0)
-                               break;
-               } else {
-                       unsigned int togo = conf_size;
-                       while (togo > NULL_CONF_SZ) {
-                               if (write(fd, null_aligned, NULL_CONF_SZ) < 0)
-                                       break;
-                               togo -= NULL_CONF_SZ;
-                       }
-                       if (write(fd, null_aligned, togo) < 0)
-                               break;
-               }
+                       memcpy(conf + i*conf_size, vdc, conf_size);
+               } else
+                       memset(conf + i*conf_size, 0xff, conf_size);
        }
-       if (i <= n_config)
+       if (write(fd, conf, buf_size) != buf_size)
                goto out;
 
        d->disk.crc = calc_crc(&d->disk, 512);
@@ -2731,79 +3020,74 @@ out:
        return ret;
 }
 
+static int _write_super_to_disk(struct ddf_super *ddf, struct dl *d)
+{
+       unsigned long long size;
+       int fd = d->fd;
+       if (fd < 0)
+               return 0;
+
+       /* We need to fill in the primary, (secondary) and workspace
+        * lba's in the headers, set their checksums,
+        * Also checksum phys, virt....
+        *
+        * Then write everything out, finally the anchor is written.
+        */
+       get_dev_size(fd, NULL, &size);
+       size /= 512;
+       if (be64_to_cpu(d->workspace_lba) != 0ULL)
+               ddf->anchor.workspace_lba = d->workspace_lba;
+       else
+               ddf->anchor.workspace_lba =
+                       cpu_to_be64(size - 32*1024*2);
+       if (be64_to_cpu(d->primary_lba) != 0ULL)
+               ddf->anchor.primary_lba = d->primary_lba;
+       else
+               ddf->anchor.primary_lba =
+                       cpu_to_be64(size - 16*1024*2);
+       if (be64_to_cpu(d->secondary_lba) != 0ULL)
+               ddf->anchor.secondary_lba = d->secondary_lba;
+       else
+               ddf->anchor.secondary_lba =
+                       cpu_to_be64(size - 32*1024*2);
+       ddf->anchor.seq = ddf->active->seq;
+       memcpy(&ddf->primary, &ddf->anchor, 512);
+       memcpy(&ddf->secondary, &ddf->anchor, 512);
+
+       ddf->anchor.openflag = 0xFF; /* 'open' means nothing */
+       ddf->anchor.seq = cpu_to_be32(0xFFFFFFFF); /* no sequencing in anchor */
+       ddf->anchor.crc = calc_crc(&ddf->anchor, 512);
+
+       if (!__write_ddf_structure(d, ddf, DDF_HEADER_PRIMARY))
+               return 0;
+
+       if (!__write_ddf_structure(d, ddf, DDF_HEADER_SECONDARY))
+               return 0;
+
+       lseek64(fd, (size-1)*512, SEEK_SET);
+       if (write(fd, &ddf->anchor, 512) < 0)
+               return 0;
+
+       return 1;
+}
+
+#ifndef MDASSEMBLE
 static int __write_init_super_ddf(struct supertype *st)
 {
        struct ddf_super *ddf = st->sb;
        struct dl *d;
        int attempts = 0;
        int successes = 0;
-       unsigned long long size;
-       char *null_aligned;
-       __u32 seq;
 
        pr_state(ddf, __func__);
-       if (posix_memalign((void**)&null_aligned, 4096, NULL_CONF_SZ) != 0) {
-               return -ENOMEM;
-       }
-       memset(null_aligned, 0xff, NULL_CONF_SZ);
-
-       seq = ddf->active->seq + 1;
 
        /* try to write updated metadata,
         * if we catch a failure move on to the next disk
         */
        for (d = ddf->dlist; d; d=d->next) {
-               int fd = d->fd;
-
-               if (fd < 0)
-                       continue;
-
                attempts++;
-               /* We need to fill in the primary, (secondary) and workspace
-                * lba's in the headers, set their checksums,
-                * Also checksum phys, virt....
-                *
-                * Then write everything out, finally the anchor is written.
-                */
-               get_dev_size(fd, NULL, &size);
-               size /= 512;
-               if (d->workspace_lba != 0)
-                       ddf->anchor.workspace_lba = d->workspace_lba;
-               else
-                       ddf->anchor.workspace_lba =
-                               __cpu_to_be64(size - 32*1024*2);
-               if (d->primary_lba != 0)
-                       ddf->anchor.primary_lba = d->primary_lba;
-               else
-                       ddf->anchor.primary_lba =
-                               __cpu_to_be64(size - 16*1024*2);
-               if (d->secondary_lba != 0)
-                       ddf->anchor.secondary_lba = d->secondary_lba;
-               else
-                       ddf->anchor.secondary_lba =
-                               __cpu_to_be64(size - 32*1024*2);
-               ddf->anchor.seq = seq;
-               memcpy(&ddf->primary, &ddf->anchor, 512);
-               memcpy(&ddf->secondary, &ddf->anchor, 512);
-
-               ddf->anchor.openflag = 0xFF; /* 'open' means nothing */
-               ddf->anchor.seq = 0xFFFFFFFF; /* no sequencing in anchor */
-               ddf->anchor.crc = calc_crc(&ddf->anchor, 512);
-
-               if (!__write_ddf_structure(d, ddf, DDF_HEADER_PRIMARY,
-                                          null_aligned))
-                       continue;
-
-               if (!__write_ddf_structure(d, ddf, DDF_HEADER_SECONDARY,
-                                          null_aligned))
-                       continue;
-
-               lseek64(fd, (size-1)*512, SEEK_SET);
-               if (write(fd, &ddf->anchor, 512) < 0)
-                       continue;
-               successes++;
+               successes += _write_super_to_disk(ddf, d);
        }
-       free(null_aligned);
 
        return attempts != successes;
 }
@@ -2820,7 +3104,8 @@ static int write_init_super_ddf(struct supertype *st)
                /* queue the virtual_disk and vd_config as metadata updates */
                struct virtual_disk *vd;
                struct vd_config *vc;
-               int len;
+               int len, tlen;
+               unsigned int i;
 
                if (!currentconf) {
                        int len = (sizeof(struct phys_disk) +
@@ -2842,21 +3127,26 @@ static int write_init_super_ddf(struct supertype *st)
                vd = xmalloc(len);
                *vd = *ddf->virt;
                vd->entries[0] = ddf->virt->entries[currentconf->vcnum];
-               vd->populated_vdes = __cpu_to_be16(currentconf->vcnum);
+               vd->populated_vdes = cpu_to_be16(currentconf->vcnum);
                append_metadata_update(st, vd, len);
 
                /* Then the vd_config */
                len = ddf->conf_rec_len * 512;
-               vc = xmalloc(len);
+               tlen = len * currentconf->conf.sec_elmnt_count;
+               vc = xmalloc(tlen);
                memcpy(vc, &currentconf->conf, len);
-               append_metadata_update(st, vc, len);
+               for (i = 1; i < currentconf->conf.sec_elmnt_count; i++)
+                       memcpy((char *)vc + i*len, currentconf->other_bvds[i-1],
+                              len);
+               append_metadata_update(st, vc, tlen);
 
                /* FIXME I need to close the fds! */
                return 0;
        } else {
                struct dl *d;
-               for (d = ddf->dlist; d; d=d->next)
-                       while (Kill(d->devname, NULL, 0, -1, 1) == 0);
+               if (!currentconf)
+                       for (d = ddf->dlist; d; d=d->next)
+                               while (Kill(d->devname, NULL, 0, -1, 1) == 0);
                return __write_init_super_ddf(st);
        }
 }
@@ -2994,29 +3284,29 @@ static int validate_geometry_ddf(struct supertype *st,
         * If given BVDs, we make an SVD, changing all the GUIDs in the process.
         */
 
-       if (chunk && *chunk == UnSet)
+       if (*chunk == UnSet)
                *chunk = DEFAULT_CHUNK;
 
        if (level == -1000000) level = LEVEL_CONTAINER;
        if (level == LEVEL_CONTAINER) {
                /* Must be a fresh device to add to a container */
                return validate_geometry_ddf_container(st, level, layout,
-                                                      raiddisks, chunk?*chunk:0,
+                                                      raiddisks, *chunk,
                                                       size, data_offset, dev,
                                                       freesize,
                                                       verbose);
        }
 
        if (!dev) {
-               /* Initial sanity check.  Exclude illegal levels. */
-               int i;
-               for (i=0; ddf_level_num[i].num1 != MAXINT; i++)
-                       if (ddf_level_num[i].num2 == level)
-                               break;
-               if (ddf_level_num[i].num1 == MAXINT) {
+               mdu_array_info_t array = {
+                       .level = level, .layout = layout,
+                       .raid_disks = raiddisks
+               };
+               struct vd_config conf;
+               if (layout_md2ddf(&array, &conf) == -1) {
                        if (verbose)
-                               pr_err("DDF does not support level %d arrays\n",
-                                      level);
+                               pr_err("DDF does not support level %d /layout %d arrays with %d disks\n",
+                                      level, layout, raiddisks);
                        return 0;
                }
                /* Should check layout? etc */
@@ -3029,7 +3319,7 @@ static int validate_geometry_ddf(struct supertype *st,
                         * chosen so that add_to_super/getinfo_super
                         * can return them.
                         */
-                       return reserve_space(st, raiddisks, size, chunk?*chunk:0, freesize);
+                       return reserve_space(st, raiddisks, size, *chunk, freesize);
                }
                return 1;
        }
@@ -3274,7 +3564,7 @@ static int load_super_ddf_all(struct supertype *st, int fd,
                rv = load_ddf_headers(dfd, super, NULL);
                close(dfd);
                if (rv == 0) {
-                       seq = __be32_to_cpu(super->active->seq);
+                       seq = be32_to_cpu(super->active->seq);
                        if (super->active->openflag)
                                seq--;
                        if (!best || seq > bestseq) {
@@ -3359,7 +3649,7 @@ static int check_secondary(const struct vcl *vc)
        __set_sec_seen(conf->sec_elmnt_seq);
        for (i = 0; i < conf->sec_elmnt_count-1; i++) {
                const struct vd_config *bvd = vc->other_bvds[i];
-               if (bvd == NULL)
+               if (bvd->sec_elmnt_seq == DDF_UNUSED_BVD)
                        continue;
                if (bvd->srl != conf->srl) {
                        pr_err("Inconsistent secondary RAID level across BVDs\n");
@@ -3369,7 +3659,7 @@ static int check_secondary(const struct vcl *vc)
                        pr_err("Different RAID levels for BVDs are unsupported\n");
                        return -1;
                }
-               if (bvd->prim_elmnt_count != conf->prim_elmnt_count) {
+               if (!be16_eq(bvd->prim_elmnt_count, conf->prim_elmnt_count)) {
                        pr_err("All BVDs must have the same number of primary elements\n");
                        return -1;
                }
@@ -3377,7 +3667,7 @@ static int check_secondary(const struct vcl *vc)
                        pr_err("Different strip sizes for BVDs are unsupported\n");
                        return -1;
                }
-               if (bvd->array_blocks != conf->array_blocks) {
+               if (!be64_eq(bvd->array_blocks, conf->array_blocks)) {
                        pr_err("Different BVD sizes are unsupported\n");
                        return -1;
                }
@@ -3393,20 +3683,20 @@ static int check_secondary(const struct vcl *vc)
 }
 
 static unsigned int get_pd_index_from_refnum(const struct vcl *vc,
-                                            __u32 refnum, unsigned int nmax,
+                                            be32 refnum, unsigned int nmax,
                                             const struct vd_config **bvd,
                                             unsigned int *idx)
 {
        unsigned int i, j, n, sec, cnt;
 
-       cnt = __be16_to_cpu(vc->conf.prim_elmnt_count);
+       cnt = be16_to_cpu(vc->conf.prim_elmnt_count);
        sec = (vc->conf.sec_elmnt_count == 1 ? 0 : vc->conf.sec_elmnt_seq);
 
        for (i = 0, j = 0 ; i < nmax ; i++) {
                /* j counts valid entries for this BVD */
-               if (vc->conf.phys_refnum[i] != 0xffffffff)
+               if (be32_to_cpu(vc->conf.phys_refnum[i]) != 0xffffffff)
                        j++;
-               if (vc->conf.phys_refnum[i] == refnum) {
+               if (be32_eq(vc->conf.phys_refnum[i], refnum)) {
                        *bvd = &vc->conf;
                        *idx = i;
                        return sec * cnt + j - 1;
@@ -3417,13 +3707,13 @@ static unsigned int get_pd_index_from_refnum(const struct vcl *vc,
 
        for (n = 1; n < vc->conf.sec_elmnt_count; n++) {
                struct vd_config *vd = vc->other_bvds[n-1];
-               if (vd == NULL)
-                       continue;
                sec = vd->sec_elmnt_seq;
+               if (sec == DDF_UNUSED_BVD)
+                       continue;
                for (i = 0, j = 0 ; i < nmax ; i++) {
-                       if (vd->phys_refnum[i] != 0xffffffff)
+                       if (be32_to_cpu(vd->phys_refnum[i]) != 0xffffffff)
                                j++;
-                       if (vd->phys_refnum[i] == refnum) {
+                       if (be32_eq(vd->phys_refnum[i], refnum)) {
                                *bvd = vd;
                                *idx = i;
                                return sec * cnt + j - 1;
@@ -3452,7 +3742,6 @@ static struct mdinfo *container_content_ddf(struct supertype *st, char *subarray
        for (vc = ddf->conflist ; vc ; vc=vc->next)
        {
                unsigned int i;
-               unsigned int j;
                struct mdinfo *this;
                char *ep;
                __u32 *cptr;
@@ -3477,10 +3766,11 @@ static struct mdinfo *container_content_ddf(struct supertype *st, char *subarray
                this->array.md_minor      = -1;
                this->array.major_version = -1;
                this->array.minor_version = -2;
+               this->safe_mode_delay = DDF_SAFE_MODE_DELAY;
                cptr = (__u32 *)(vc->conf.guid + 16);
                this->array.ctime         = DECADE + __be32_to_cpu(*cptr);
                this->array.utime         = DECADE +
-                       __be32_to_cpu(vc->conf.timestamp);
+                       be32_to_cpu(vc->conf.timestamp);
                this->array.chunk_size    = 512 << vc->conf.chunk_shift;
 
                i = vc->vcnum;
@@ -3493,36 +3783,32 @@ static struct mdinfo *container_content_ddf(struct supertype *st, char *subarray
                        this->array.state = 1;
                        this->resync_start = MaxSector;
                }
-               memcpy(this->name, ddf->virt->entries[i].name, 16);
-               this->name[16]=0;
-               for(j=0; j<16; j++)
-                       if (this->name[j] == ' ')
-                               this->name[j] = 0;
-
+               _ddf_array_name(this->name, ddf, i);
                memset(this->uuid, 0, sizeof(this->uuid));
-               this->component_size = __be64_to_cpu(vc->conf.blocks);
+               this->component_size = be64_to_cpu(vc->conf.blocks);
                this->array.size = this->component_size / 2;
                this->container_member = i;
 
                ddf->currentconf = vc;
                uuid_from_super_ddf(st, this->uuid);
-               ddf->currentconf = NULL;
+               if (!subarray)
+                       ddf->currentconf = NULL;
 
                sprintf(this->text_version, "/%s/%d",
                        st->container_devnm, this->container_member);
 
-               for (pd = 0; pd < __be16_to_cpu(ddf->phys->used_pdes); pd++) {
+               for (pd = 0; pd < be16_to_cpu(ddf->phys->used_pdes); pd++) {
                        struct mdinfo *dev;
                        struct dl *d;
                        const struct vd_config *bvd;
                        unsigned int iphys;
-                       __u64 *lba_offset;
                        int stt;
 
-                       if (ddf->phys->entries[pd].refnum == 0xFFFFFFFF)
+                       if (be32_to_cpu(ddf->phys->entries[pd].refnum)
+                           == 0xFFFFFFFF)
                                continue;
 
-                       stt = __be16_to_cpu(ddf->phys->entries[pd].state);
+                       stt = be16_to_cpu(ddf->phys->entries[pd].state);
                        if ((stt & (DDF_Online|DDF_Failed|DDF_Rebuilding))
                            != DDF_Online)
                                continue;
@@ -3536,8 +3822,8 @@ static struct mdinfo *container_content_ddf(struct supertype *st, char *subarray
                        this->array.working_disks++;
 
                        for (d = ddf->dlist; d ; d=d->next)
-                               if (d->disk.refnum ==
-                                   ddf->phys->entries[pd].refnum)
+                               if (be32_eq(d->disk.refnum,
+                                           ddf->phys->entries[pd].refnum))
                                        break;
                        if (d == NULL)
                                /* Haven't found that one yet, maybe there are others */
@@ -3547,17 +3833,17 @@ static struct mdinfo *container_content_ddf(struct supertype *st, char *subarray
                        dev->next = this->devs;
                        this->devs = dev;
 
-                       dev->disk.number = __be32_to_cpu(d->disk.refnum);
+                       dev->disk.number = be32_to_cpu(d->disk.refnum);
                        dev->disk.major = d->major;
                        dev->disk.minor = d->minor;
                        dev->disk.raid_disk = i;
                        dev->disk.state = (1<<MD_DISK_SYNC)|(1<<MD_DISK_ACTIVE);
                        dev->recovery_start = MaxSector;
 
-                       dev->events = __be32_to_cpu(ddf->primary.seq);
-                       lba_offset =  (__u64 *)&bvd->phys_refnum[ddf->mppe];
-                       dev->data_offset = __be64_to_cpu(lba_offset[iphys]);
-                       dev->component_size = __be64_to_cpu(bvd->blocks);
+                       dev->events = be32_to_cpu(ddf->primary.seq);
+                       dev->data_offset =
+                               be64_to_cpu(LBA_OFFSET(ddf, bvd)[iphys]);
+                       dev->component_size = be64_to_cpu(bvd->blocks);
                        if (d->devname)
                                strcpy(dev->name, d->devname);
                }
@@ -3598,17 +3884,9 @@ static int store_super_ddf(struct supertype *st, int fd)
                               (int)minor(sta.st_rdev));
                        return 1;
                }
-               /*
-                  For DDF, writing to just one disk makes no sense.
-                  We would run the risk of writing inconsistent meta data
-                  to the devices. So just call __write_init_super_ddf and
-                  write to all devices, including this one.
-                  Use the fd passed to this function, just in case dl->fd
-                  is invalid.
-                */
                ofd = dl->fd;
                dl->fd = fd;
-               ret =  __write_init_super_ddf(st);
+               ret = (_write_super_to_disk(ddf, dl) != 1);
                dl->fd = ofd;
                return ret;
        }
@@ -3649,34 +3927,36 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
        if (memcmp(first->anchor.guid, second->anchor.guid, DDF_GUID_LEN) != 0)
                return 2;
 
-       if (first->anchor.seq != second->anchor.seq) {
-               dprintf("%s: sequence number mismatch %u/%u\n", __func__,
-                       __be32_to_cpu(first->anchor.seq),
-                       __be32_to_cpu(second->anchor.seq));
+       if (!be32_eq(first->active->seq, second->active->seq)) {
+               dprintf("%s: sequence number mismatch %u<->%u\n", __func__,
+                       be32_to_cpu(first->active->seq),
+                       be32_to_cpu(second->active->seq));
                return 3;
        }
        if (first->max_part != second->max_part ||
-           first->phys->used_pdes != second->phys->used_pdes ||
-           first->virt->populated_vdes != second->virt->populated_vdes) {
+           !be16_eq(first->phys->used_pdes, second->phys->used_pdes) ||
+           !be16_eq(first->virt->populated_vdes,
+                    second->virt->populated_vdes)) {
                dprintf("%s: PD/VD number mismatch\n", __func__);
                return 3;
        }
 
-       max_pds =  __be16_to_cpu(first->phys->used_pdes);
+       max_pds =  be16_to_cpu(first->phys->used_pdes);
        for (dl2 = second->dlist; dl2; dl2 = dl2->next) {
                for (pd = 0; pd < max_pds; pd++)
-                       if (first->phys->entries[pd].refnum == dl2->disk.refnum)
+                       if (be32_eq(first->phys->entries[pd].refnum,
+                                   dl2->disk.refnum))
                                break;
                if (pd == max_pds) {
                        dprintf("%s: no match for disk %08x\n", __func__,
-                               __be32_to_cpu(dl2->disk.refnum));
+                               be32_to_cpu(dl2->disk.refnum));
                        return 3;
                }
        }
 
-       max_vds = __be16_to_cpu(first->active->max_vd_entries);
+       max_vds = be16_to_cpu(first->active->max_vd_entries);
        for (vl2 = second->conflist; vl2; vl2 = vl2->next) {
-               if (vl2->conf.magic != DDF_VD_CONF_MAGIC)
+               if (!be32_eq(vl2->conf.magic, DDF_VD_CONF_MAGIC))
                        continue;
                for (vd = 0; vd < max_vds; vd++)
                        if (!memcmp(first->virt->entries[vd].guid,
@@ -3721,14 +4001,13 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
 
                vl1->next = first->conflist;
                vl1->block_sizes = NULL;
-               if (vl2->conf.sec_elmnt_count > 1) {
-                       vl1->other_bvds = xcalloc(vl2->conf.sec_elmnt_count - 1,
-                                                 sizeof(struct vd_config *));
-               } else
-                       vl1->other_bvds = NULL;
                memcpy(&vl1->conf, &vl2->conf, first->conf_rec_len*512);
-               vl1->lba_offset = (__u64 *)
-                       &vl1->conf.phys_refnum[first->mppe];
+               if (alloc_other_bvds(first, vl1) != 0) {
+                       pr_err("%s could not allocate other bvds\n",
+                              __func__);
+                       free(vl1);
+                       return 3;
+               }
                for (vd = 0; vd < max_vds; vd++)
                        if (!memcmp(first->virt->entries[vd].guid,
                                    vl1->conf.guid, DDF_GUID_LEN))
@@ -3740,7 +4019,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
 
        for (dl2 = second->dlist; dl2; dl2 = dl2->next) {
                for (dl1 = first->dlist; dl1; dl1 = dl1->next)
-                       if (dl1->disk.refnum == dl2->disk.refnum)
+                       if (be32_eq(dl1->disk.refnum, dl2->disk.refnum))
                                break;
                if (dl1)
                        continue;
@@ -3757,7 +4036,8 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
                dl1->next = first->dlist;
                dl1->fd = -1;
                for (pd = 0; pd < max_pds; pd++)
-                       if (first->phys->entries[pd].refnum == dl1->disk.refnum)
+                       if (be32_eq(first->phys->entries[pd].refnum,
+                                   dl1->disk.refnum))
                                break;
                dl1->pdnum = pd;
                if (dl2->spare) {
@@ -3784,7 +4064,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
                }
                first->dlist = dl1;
                dprintf("%s: added disk %d: %08x\n", __func__, dl1->pdnum,
-                       dl1->disk.refnum);
+                       be32_to_cpu(dl1->disk.refnum));
        }
 
        return 0;
@@ -3801,11 +4081,38 @@ static int ddf_open_new(struct supertype *c, struct active_array *a, char *inst)
 {
        struct ddf_super *ddf = c->sb;
        int n = atoi(inst);
+       struct mdinfo *dev;
+       struct dl *dl;
+       static const char faulty[] = "faulty";
+
        if (all_ff(ddf->virt->entries[n].guid)) {
                pr_err("%s: subarray %d doesn't exist\n", __func__, n);
                return -ENODEV;
        }
-       dprintf("ddf: open_new %d\n", n);
+       dprintf("%s: new subarray %d, GUID: %s\n", __func__, n,
+               guid_str(ddf->virt->entries[n].guid));
+       for (dev = a->info.devs; dev; dev = dev->next) {
+               for (dl = ddf->dlist; dl; dl = dl->next)
+                       if (dl->major == dev->disk.major &&
+                           dl->minor == dev->disk.minor)
+                               break;
+               if (!dl) {
+                       pr_err("%s: device %d/%d of subarray %d not found in meta data\n",
+                               __func__, dev->disk.major, dev->disk.minor, n);
+                       return -1;
+               }
+               if ((be16_to_cpu(ddf->phys->entries[dl->pdnum].state) &
+                       (DDF_Online|DDF_Missing|DDF_Failed)) != DDF_Online) {
+                       pr_err("%s: new subarray %d contains broken device %d/%d (%02x)\n",
+                               __func__, n, dl->major, dl->minor,
+                               be16_to_cpu(
+                                       ddf->phys->entries[dl->pdnum].state));
+                       if (write(dev->state_fd, faulty, sizeof(faulty)-1) !=
+                           sizeof(faulty) - 1)
+                               pr_err("Write to state_fd failed\n");
+                       dev->curr_state = DS_FAULTY;
+               }
+       }
        a->info.container_member = n;
        return 0;
 }
@@ -3848,7 +4155,9 @@ static int ddf_set_array_state(struct active_array *a, int consistent)
        if (old != ddf->virt->entries[inst].init_state)
                ddf_set_updates_pending(ddf);
 
-       dprintf("ddf mark %d %s %llu\n", inst, consistent?"clean":"dirty",
+       dprintf("ddf mark %d/%s (%d) %s %llu\n", inst,
+               guid_str(ddf->virt->entries[inst].guid), a->curr_state,
+               consistent?"clean":"dirty",
                a->info.resync_start);
        return consistent;
 }
@@ -3857,7 +4166,7 @@ static int get_bvd_state(const struct ddf_super *ddf,
                         const struct vd_config *vc)
 {
        unsigned int i, n_bvd, working = 0;
-       unsigned int n_prim = __be16_to_cpu(vc->prim_elmnt_count);
+       unsigned int n_prim = be16_to_cpu(vc->prim_elmnt_count);
        int pd, st, state;
        for (i = 0; i < n_prim; i++) {
                if (!find_index_in_bvd(ddf, vc, i, &n_bvd))
@@ -3865,7 +4174,7 @@ static int get_bvd_state(const struct ddf_super *ddf,
                pd = find_phys(ddf, vc->phys_refnum[n_bvd]);
                if (pd < 0)
                        continue;
-               st = __be16_to_cpu(ddf->phys->entries[pd].state);
+               st = be16_to_cpu(ddf->phys->entries[pd].state);
                if ((st & (DDF_Online|DDF_Failed|DDF_Rebuilding))
                    == DDF_Online)
                        working++;
@@ -3959,6 +4268,7 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
        struct mdinfo *mdi;
        struct dl *dl;
 
+       dprintf("%s: %d to %x\n", __func__, n, state);
        if (vc == NULL) {
                dprintf("ddf: cannot find instance %d!!\n", inst);
                return;
@@ -3967,8 +4277,11 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
        for (mdi = a->info.devs; mdi; mdi = mdi->next)
                if (mdi->disk.raid_disk == n)
                        break;
-       if (!mdi)
+       if (!mdi) {
+               pr_err("%s: cannot find raid disk %d\n",
+                      __func__, n);
                return;
+       }
 
        /* and find the 'dl' entry corresponding to that. */
        for (dl = ddf->dlist; dl; dl = dl->next)
@@ -3976,8 +4289,12 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
                    mdi->disk.major == dl->major &&
                    mdi->disk.minor == dl->minor)
                        break;
-       if (!dl)
+       if (!dl) {
+               pr_err("%s: cannot find raid disk %d (%d/%d)\n",
+                      __func__, n,
+                      mdi->disk.major, mdi->disk.minor);
                return;
+       }
 
        pd = find_phys(ddf, vc->phys_refnum[n_bvd]);
        if (pd < 0 || pd != dl->pdnum) {
@@ -3985,34 +4302,39 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
                 * If it is now in_sync, insert it. */
                dprintf("%s: phys disk not found for %d: %d/%d ref %08x\n",
                        __func__, dl->pdnum, dl->major, dl->minor,
-                       dl->disk.refnum);
+                       be32_to_cpu(dl->disk.refnum));
                dprintf("%s: array %u disk %u ref %08x pd %d\n",
-                       __func__, inst, n_bvd, vc->phys_refnum[n_bvd], pd);
+                       __func__, inst, n_bvd,
+                       be32_to_cpu(vc->phys_refnum[n_bvd]), pd);
                if ((state & DS_INSYNC) && ! (state & DS_FAULTY)) {
-                       __u64 *lba_offset;
                        pd = dl->pdnum; /* FIXME: is this really correct ? */
                        vc->phys_refnum[n_bvd] = dl->disk.refnum;
-                       lba_offset = (__u64 *)&vc->phys_refnum[ddf->mppe];
-                       lba_offset[n_bvd] = mdi->data_offset;
-                       ddf->phys->entries[pd].type &=
-                               ~__cpu_to_be16(DDF_Global_Spare);
-                       ddf->phys->entries[pd].type |=
-                               __cpu_to_be16(DDF_Active_in_VD);
+                       LBA_OFFSET(ddf, vc)[n_bvd] =
+                               cpu_to_be64(mdi->data_offset);
+                       be16_clear(ddf->phys->entries[pd].type,
+                                  cpu_to_be16(DDF_Global_Spare));
+                       be16_set(ddf->phys->entries[pd].type,
+                                cpu_to_be16(DDF_Active_in_VD));
                        ddf_set_updates_pending(ddf);
                }
        } else {
-               int old = ddf->phys->entries[pd].state;
+               be16 old = ddf->phys->entries[pd].state;
                if (state & DS_FAULTY)
-                       ddf->phys->entries[pd].state  |= __cpu_to_be16(DDF_Failed);
+                       be16_set(ddf->phys->entries[pd].state,
+                                cpu_to_be16(DDF_Failed));
                if (state & DS_INSYNC) {
-                       ddf->phys->entries[pd].state  |= __cpu_to_be16(DDF_Online);
-                       ddf->phys->entries[pd].state  &= __cpu_to_be16(~DDF_Rebuilding);
+                       be16_set(ddf->phys->entries[pd].state,
+                                cpu_to_be16(DDF_Online));
+                       be16_clear(ddf->phys->entries[pd].state,
+                                  cpu_to_be16(DDF_Rebuilding));
                }
-               if (old != ddf->phys->entries[pd].state)
+               if (!be16_eq(old, ddf->phys->entries[pd].state))
                        ddf_set_updates_pending(ddf);
        }
 
-       dprintf("ddf: set_disk %d to %x\n", n, state);
+       dprintf("ddf: set_disk %d (%08x) to %x->%02x\n", n,
+               be32_to_cpu(dl->disk.refnum), state,
+               be16_to_cpu(ddf->phys->entries[pd].state));
 
        /* Now we need to check the state of the array and update
         * virtual_disk.entries[n].state.
@@ -4051,6 +4373,112 @@ static void ddf_sync_metadata(struct supertype *st)
        dprintf("ddf: sync_metadata\n");
 }
 
+static int del_from_conflist(struct vcl **list, const char *guid)
+{
+       struct vcl **p;
+       int found = 0;
+       for (p = list; p && *p; p = &((*p)->next))
+               if (!memcmp((*p)->conf.guid, guid, DDF_GUID_LEN)) {
+                       found = 1;
+                       *p = (*p)->next;
+               }
+       return found;
+}
+
+static int _kill_subarray_ddf(struct ddf_super *ddf, const char *guid)
+{
+       struct dl *dl;
+       unsigned int vdnum, i;
+       vdnum = find_vde_by_guid(ddf, guid);
+       if (vdnum == DDF_NOTFOUND) {
+               pr_err("%s: could not find VD %s\n", __func__,
+                      guid_str(guid));
+               return -1;
+       }
+       if (del_from_conflist(&ddf->conflist, guid) == 0) {
+               pr_err("%s: could not find conf %s\n", __func__,
+                      guid_str(guid));
+               return -1;
+       }
+       for (dl = ddf->dlist; dl; dl = dl->next)
+               for (i = 0; i < ddf->max_part; i++)
+                       if (dl->vlist[i] != NULL &&
+                           !memcmp(dl->vlist[i]->conf.guid, guid,
+                                   DDF_GUID_LEN))
+                               dl->vlist[i] = NULL;
+       memset(ddf->virt->entries[vdnum].guid, 0xff, DDF_GUID_LEN);
+       dprintf("%s: deleted %s\n", __func__, guid_str(guid));
+       return 0;
+}
+
+static int kill_subarray_ddf(struct supertype *st)
+{
+       struct ddf_super *ddf = st->sb;
+       /*
+        *  currentconf is set in container_content_ddf,
+        *  called with subarray arg
+        */
+       struct vcl *victim = ddf->currentconf;
+       struct vd_config *conf;
+       ddf->currentconf = NULL;
+       unsigned int vdnum;
+       if (!victim) {
+               pr_err("%s: nothing to kill\n", __func__);
+               return -1;
+       }
+       conf = &victim->conf;
+       vdnum = find_vde_by_guid(ddf, conf->guid);
+       if (vdnum == DDF_NOTFOUND) {
+               pr_err("%s: could not find VD %s\n", __func__,
+                      guid_str(conf->guid));
+               return -1;
+       }
+       if (st->update_tail) {
+               struct virtual_disk *vd;
+               int len = sizeof(struct virtual_disk)
+                       + sizeof(struct virtual_entry);
+               vd = xmalloc(len);
+               if (vd == NULL) {
+                       pr_err("%s: failed to allocate %d bytes\n", __func__,
+                              len);
+                       return -1;
+               }
+               memset(vd, 0 , len);
+               vd->magic = DDF_VIRT_RECORDS_MAGIC;
+               vd->populated_vdes = cpu_to_be16(0);
+               memcpy(vd->entries[0].guid, conf->guid, DDF_GUID_LEN);
+               /* we use DDF_state_deleted as marker */
+               vd->entries[0].state = DDF_state_deleted;
+               append_metadata_update(st, vd, len);
+       } else {
+               _kill_subarray_ddf(ddf, conf->guid);
+               ddf_set_updates_pending(ddf);
+               ddf_sync_metadata(st);
+       }
+       return 0;
+}
+
+static void copy_matching_bvd(struct ddf_super *ddf,
+                             struct vd_config *conf,
+                             const struct metadata_update *update)
+{
+       unsigned int mppe =
+               be16_to_cpu(ddf->anchor.max_primary_element_entries);
+       unsigned int len = ddf->conf_rec_len * 512;
+       char *p;
+       struct vd_config *vc;
+       for (p = update->buf; p < update->buf + update->len; p += len) {
+               vc = (struct vd_config *) p;
+               if (vc->sec_elmnt_seq == conf->sec_elmnt_seq) {
+                       memcpy(conf->phys_refnum, vc->phys_refnum,
+                              mppe * (sizeof(__u32) + sizeof(__u64)));
+                       return;
+               }
+       }
+       pr_err("%s: no match for BVD %d of %s in update\n", __func__,
+              conf->sec_elmnt_seq, guid_str(conf->guid));
+}
+
 static void ddf_process_update(struct supertype *st,
                               struct metadata_update *update)
 {
@@ -4082,33 +4510,32 @@ static void ddf_process_update(struct supertype *st,
         *    a spare-assignment record.
         */
        struct ddf_super *ddf = st->sb;
-       __u32 *magic = (__u32*)update->buf;
+       be32 *magic = (be32 *)update->buf;
        struct phys_disk *pd;
        struct virtual_disk *vd;
        struct vd_config *vc;
        struct vcl *vcl;
        struct dl *dl;
-       unsigned int mppe;
        unsigned int ent;
-       unsigned int pdnum, pd2;
+       unsigned int pdnum, pd2, len;
 
-       dprintf("Process update %x\n", *magic);
+       dprintf("Process update %x\n", be32_to_cpu(*magic));
 
-       switch (*magic) {
-       case DDF_PHYS_RECORDS_MAGIC:
+       if (be32_eq(*magic, DDF_PHYS_RECORDS_MAGIC)) {
 
                if (update->len != (sizeof(struct phys_disk) +
                                    sizeof(struct phys_disk_entry)))
                        return;
                pd = (struct phys_disk*)update->buf;
 
-               ent = __be16_to_cpu(pd->used_pdes);
-               if (ent >= __be16_to_cpu(ddf->phys->max_pdes))
+               ent = be16_to_cpu(pd->used_pdes);
+               if (ent >= be16_to_cpu(ddf->phys->max_pdes))
                        return;
-               if (pd->entries[0].state & __cpu_to_be16(DDF_Missing)) {
+               if (be16_and(pd->entries[0].state, cpu_to_be16(DDF_Missing))) {
                        struct dl **dlp;
                        /* removing this disk. */
-                       ddf->phys->entries[ent].state |= __cpu_to_be16(DDF_Missing);
+                       be16_set(ddf->phys->entries[ent].state,
+                                cpu_to_be16(DDF_Missing));
                        for (dlp = &ddf->dlist; *dlp; dlp = &(*dlp)->next) {
                                struct dl *dl = *dlp;
                                if (dl->pdnum == (signed)ent) {
@@ -4127,8 +4554,8 @@ static void ddf_process_update(struct supertype *st,
                if (!all_ff(ddf->phys->entries[ent].guid))
                        return;
                ddf->phys->entries[ent] = pd->entries[0];
-               ddf->phys->used_pdes = __cpu_to_be16(1 +
-                                                    __be16_to_cpu(ddf->phys->used_pdes));
+               ddf->phys->used_pdes = cpu_to_be16
+                       (1 + be16_to_cpu(ddf->phys->used_pdes));
                ddf_set_updates_pending(ddf);
                if (ddf->add_list) {
                        struct active_array *a;
@@ -4144,117 +4571,173 @@ static void ddf_process_update(struct supertype *st,
                        for (a = st->arrays ; a; a=a->next)
                                a->check_degraded = 1;
                }
-               break;
-
-       case DDF_VIRT_RECORDS_MAGIC:
+       } else if (be32_eq(*magic, DDF_VIRT_RECORDS_MAGIC)) {
 
                if (update->len != (sizeof(struct virtual_disk) +
                                    sizeof(struct virtual_entry)))
                        return;
                vd = (struct virtual_disk*)update->buf;
 
-               ent = find_unused_vde(ddf);
-               if (ent == DDF_NOTFOUND)
-                       return;
-               ddf->virt->entries[ent] = vd->entries[0];
-               ddf->virt->populated_vdes = __cpu_to_be16(1 +
-                                                         __be16_to_cpu(ddf->virt->populated_vdes));
-               ddf_set_updates_pending(ddf);
-               break;
+               if (vd->entries[0].state == DDF_state_deleted) {
+                       if (_kill_subarray_ddf(ddf, vd->entries[0].guid))
+                               return;
+               } else {
 
-       case DDF_VD_CONF_MAGIC:
-               dprintf("len %d %d\n", update->len, ddf->conf_rec_len);
+                       ent = find_vde_by_guid(ddf, vd->entries[0].guid);
+                       if (ent != DDF_NOTFOUND) {
+                               dprintf("%s: VD %s exists already in slot %d\n",
+                                       __func__, guid_str(vd->entries[0].guid),
+                                       ent);
+                               return;
+                       }
+                       ent = find_unused_vde(ddf);
+                       if (ent == DDF_NOTFOUND)
+                               return;
+                       ddf->virt->entries[ent] = vd->entries[0];
+                       ddf->virt->populated_vdes =
+                               cpu_to_be16(
+                                       1 + be16_to_cpu(
+                                               ddf->virt->populated_vdes));
+                       dprintf("%s: added VD %s in slot %d(s=%02x i=%02x)\n",
+                               __func__, guid_str(vd->entries[0].guid), ent,
+                               ddf->virt->entries[ent].state,
+                               ddf->virt->entries[ent].init_state);
+               }
+               ddf_set_updates_pending(ddf);
+       }
 
-               mppe = __be16_to_cpu(ddf->anchor.max_primary_element_entries);
-               if ((unsigned)update->len != ddf->conf_rec_len * 512)
-                       return;
+       else if (be32_eq(*magic, DDF_VD_CONF_MAGIC)) {
                vc = (struct vd_config*)update->buf;
+               len = ddf->conf_rec_len * 512;
+               if ((unsigned int)update->len != len * vc->sec_elmnt_count) {
+                       pr_err("%s: %s: insufficient data (%d) for %u BVDs\n",
+                              __func__, guid_str(vc->guid), update->len,
+                              vc->sec_elmnt_count);
+                       return;
+               }
                for (vcl = ddf->conflist; vcl ; vcl = vcl->next)
                        if (memcmp(vcl->conf.guid, vc->guid, DDF_GUID_LEN) == 0)
                                break;
-               dprintf("vcl = %p\n", vcl);
+               dprintf("%s: conf update for %s (%s)\n", __func__,
+                       guid_str(vc->guid), (vcl ? "old" : "new"));
                if (vcl) {
                        /* An update, just copy the phys_refnum and lba_offset
                         * fields
                         */
-                       memcpy(vcl->conf.phys_refnum, vc->phys_refnum,
-                              mppe * (sizeof(__u32) + sizeof(__u64)));
+                       unsigned int i;
+                       unsigned int k;
+                       copy_matching_bvd(ddf, &vcl->conf, update);
+                       for (k = 0; k < be16_to_cpu(vc->prim_elmnt_count); k++)
+                               dprintf("BVD %u has %08x at %llu\n", 0,
+                                       be32_to_cpu(vcl->conf.phys_refnum[k]),
+                                       be64_to_cpu(LBA_OFFSET(ddf,
+                                                              &vcl->conf)[k]));
+                       for (i = 1; i < vc->sec_elmnt_count; i++) {
+                               copy_matching_bvd(ddf, vcl->other_bvds[i-1],
+                                                 update);
+                               for (k = 0; k < be16_to_cpu(
+                                            vc->prim_elmnt_count); k++)
+                                       dprintf("BVD %u has %08x at %llu\n", i,
+                                               be32_to_cpu
+                                               (vcl->other_bvds[i-1]->
+                                                phys_refnum[k]),
+                                               be64_to_cpu
+                                               (LBA_OFFSET
+                                                (ddf,
+                                                 vcl->other_bvds[i-1])[k]));
+                       }
                } else {
                        /* A new VD_CONF */
+                       unsigned int i;
                        if (!update->space)
                                return;
                        vcl = update->space;
                        update->space = NULL;
                        vcl->next = ddf->conflist;
-                       memcpy(&vcl->conf, vc, update->len);
-                       vcl->lba_offset = (__u64*)
-                               &vcl->conf.phys_refnum[mppe];
+                       memcpy(&vcl->conf, vc, len);
                        ent = find_vde_by_guid(ddf, vc->guid);
                        if (ent == DDF_NOTFOUND)
                                return;
                        vcl->vcnum = ent;
                        ddf->conflist = vcl;
+                       for (i = 1; i < vc->sec_elmnt_count; i++)
+                               memcpy(vcl->other_bvds[i-1],
+                                      update->buf + len * i, len);
                }
                /* Set DDF_Transition on all Failed devices - to help
                 * us detect those that are no longer in use
                 */
-               for (pdnum = 0; pdnum < __be16_to_cpu(ddf->phys->used_pdes); pdnum++)
-                       if (ddf->phys->entries[pdnum].state
-                           & __be16_to_cpu(DDF_Failed))
-                               ddf->phys->entries[pdnum].state
-                                       |= __be16_to_cpu(DDF_Transition);
+               for (pdnum = 0; pdnum < be16_to_cpu(ddf->phys->used_pdes);
+                    pdnum++)
+                       if (be16_and(ddf->phys->entries[pdnum].state,
+                                    cpu_to_be16(DDF_Failed)))
+                               be16_set(ddf->phys->entries[pdnum].state,
+                                        cpu_to_be16(DDF_Transition));
                /* Now make sure vlist is correct for each dl. */
                for (dl = ddf->dlist; dl; dl = dl->next) {
-                       unsigned int dn;
                        unsigned int vn = 0;
                        int in_degraded = 0;
-                       for (vcl = ddf->conflist; vcl ; vcl = vcl->next)
-                               for (dn=0; dn < ddf->mppe ; dn++)
-                                       if (vcl->conf.phys_refnum[dn] ==
-                                           dl->disk.refnum) {
-                                               int vstate;
-                                               dprintf("dev %d has %p at %d\n",
-                                                       dl->pdnum, vcl, vn);
-                                               /* Clear the Transition flag */
-                                               if (ddf->phys->entries[dl->pdnum].state
-                                                   & __be16_to_cpu(DDF_Failed))
-                                                       ddf->phys->entries[dl->pdnum].state &=
-                                                               ~__be16_to_cpu(DDF_Transition);
-
-                                               dl->vlist[vn++] = vcl;
-                                               vstate = ddf->virt->entries[vcl->vcnum].state
-                                                       & DDF_state_mask;
-                                               if (vstate == DDF_state_degraded ||
-                                                   vstate == DDF_state_part_optimal)
-                                                       in_degraded = 1;
-                                               break;
-                                       }
+                       for (vcl = ddf->conflist; vcl ; vcl = vcl->next) {
+                               unsigned int dn, ibvd;
+                               const struct vd_config *conf;
+                               int vstate;
+                               dn = get_pd_index_from_refnum(vcl,
+                                                             dl->disk.refnum,
+                                                             ddf->mppe,
+                                                             &conf, &ibvd);
+                               if (dn == DDF_NOTFOUND)
+                                       continue;
+                               dprintf("dev %d/%08x has %s (sec=%u) at %d\n",
+                                       dl->pdnum,
+                                       be32_to_cpu(dl->disk.refnum),
+                                       guid_str(conf->guid),
+                                       conf->sec_elmnt_seq, vn);
+                               /* Clear the Transition flag */
+                               if (be16_and
+                                   (ddf->phys->entries[dl->pdnum].state,
+                                    cpu_to_be16(DDF_Failed)))
+                                       be16_clear(ddf->phys
+                                                  ->entries[dl->pdnum].state,
+                                                  cpu_to_be16(DDF_Transition));
+                               dl->vlist[vn++] = vcl;
+                               vstate = ddf->virt->entries[vcl->vcnum].state
+                                       & DDF_state_mask;
+                               if (vstate == DDF_state_degraded ||
+                                       vstate == DDF_state_part_optimal)
+                                       in_degraded = 1;
+                       }
                        while (vn < ddf->max_part)
                                dl->vlist[vn++] = NULL;
                        if (dl->vlist[0]) {
-                               ddf->phys->entries[dl->pdnum].type &=
-                                       ~__cpu_to_be16(DDF_Global_Spare);
-                               if (!(ddf->phys->entries[dl->pdnum].type &
-                                     __cpu_to_be16(DDF_Active_in_VD))) {
-                                       ddf->phys->entries[dl->pdnum].type |=
-                                               __cpu_to_be16(DDF_Active_in_VD);
+                               be16_clear(ddf->phys->entries[dl->pdnum].type,
+                                          cpu_to_be16(DDF_Global_Spare));
+                               if (!be16_and(ddf->phys
+                                             ->entries[dl->pdnum].type,
+                                             cpu_to_be16(DDF_Active_in_VD))) {
+                                       be16_set(ddf->phys
+                                                ->entries[dl->pdnum].type,
+                                                cpu_to_be16(DDF_Active_in_VD));
                                        if (in_degraded)
-                                               ddf->phys->entries[dl->pdnum].state |=
-                                                       __cpu_to_be16(DDF_Rebuilding);
+                                               be16_set(ddf->phys
+                                                        ->entries[dl->pdnum]
+                                                        .state,
+                                                        cpu_to_be16
+                                                        (DDF_Rebuilding));
                                }
                        }
                        if (dl->spare) {
-                               ddf->phys->entries[dl->pdnum].type &=
-                                       ~__cpu_to_be16(DDF_Global_Spare);
-                               ddf->phys->entries[dl->pdnum].type |=
-                                       __cpu_to_be16(DDF_Spare);
+                               be16_clear(ddf->phys->entries[dl->pdnum].type,
+                                          cpu_to_be16(DDF_Global_Spare));
+                               be16_set(ddf->phys->entries[dl->pdnum].type,
+                                        cpu_to_be16(DDF_Spare));
                        }
                        if (!dl->vlist[0] && !dl->spare) {
-                               ddf->phys->entries[dl->pdnum].type |=
-                                       __cpu_to_be16(DDF_Global_Spare);
-                               ddf->phys->entries[dl->pdnum].type &=
-                                       ~__cpu_to_be16(DDF_Spare |
-                                                      DDF_Active_in_VD);
+                               be16_set(ddf->phys->entries[dl->pdnum].type,
+                                        cpu_to_be16(DDF_Global_Spare));
+                               be16_clear(ddf->phys->entries[dl->pdnum].type,
+                                          cpu_to_be16(DDF_Spare));
+                               be16_clear(ddf->phys->entries[dl->pdnum].type,
+                                          cpu_to_be16(DDF_Active_in_VD));
                        }
                }
 
@@ -4263,32 +4746,40 @@ static void ddf_process_update(struct supertype *st,
                 * Once done, we need to update all dl->pdnum numbers.
                 */
                pd2 = 0;
-               for (pdnum = 0; pdnum < __be16_to_cpu(ddf->phys->used_pdes); pdnum++)
-                       if ((ddf->phys->entries[pdnum].state
-                            & __be16_to_cpu(DDF_Failed))
-                           && (ddf->phys->entries[pdnum].state
-                               & __be16_to_cpu(DDF_Transition)))
-                               /* skip this one */;
-                       else if (pdnum == pd2)
+               for (pdnum = 0; pdnum < be16_to_cpu(ddf->phys->used_pdes);
+                    pdnum++) {
+                       if (be16_and(ddf->phys->entries[pdnum].state,
+                                    cpu_to_be16(DDF_Failed))
+                           && be16_and(ddf->phys->entries[pdnum].state,
+                                       cpu_to_be16(DDF_Transition))) {
+                               /* skip this one unless in dlist*/
+                               for (dl = ddf->dlist; dl; dl = dl->next)
+                                       if (dl->pdnum == (int)pdnum)
+                                               break;
+                               if (!dl)
+                                       continue;
+                       }
+                       if (pdnum == pd2)
                                pd2++;
                        else {
-                               ddf->phys->entries[pd2] = ddf->phys->entries[pdnum];
+                               ddf->phys->entries[pd2] =
+                                       ddf->phys->entries[pdnum];
                                for (dl = ddf->dlist; dl; dl = dl->next)
                                        if (dl->pdnum == (int)pdnum)
                                                dl->pdnum = pd2;
                                pd2++;
                        }
-               ddf->phys->used_pdes = __cpu_to_be16(pd2);
+               }
+               ddf->phys->used_pdes = cpu_to_be16(pd2);
                while (pd2 < pdnum) {
-                       memset(ddf->phys->entries[pd2].guid, 0xff, DDF_GUID_LEN);
+                       memset(ddf->phys->entries[pd2].guid, 0xff,
+                              DDF_GUID_LEN);
                        pd2++;
                }
 
                ddf_set_updates_pending(ddf);
-               break;
-       case DDF_SPARE_ASSIGN_MAGIC:
-       default: break;
        }
+       /* case DDF_SPARE_ASSIGN_MAGIC */
 }
 
 static void ddf_prepare_update(struct supertype *st,
@@ -4299,12 +4790,66 @@ static void ddf_prepare_update(struct supertype *st,
         * If a malloc is needed, do it here.
         */
        struct ddf_super *ddf = st->sb;
-       __u32 *magic = (__u32*)update->buf;
-       if (*magic == DDF_VD_CONF_MAGIC)
+       be32 *magic = (be32 *)update->buf;
+       if (be32_eq(*magic, DDF_VD_CONF_MAGIC)) {
+               struct vcl *vcl;
+               struct vd_config *conf = (struct vd_config *) update->buf;
                if (posix_memalign(&update->space, 512,
                                   offsetof(struct vcl, conf)
-                                  + ddf->conf_rec_len * 512) != 0)
+                                  + ddf->conf_rec_len * 512) != 0) {
+                       update->space = NULL;
+                       return;
+               }
+               vcl = update->space;
+               vcl->conf.sec_elmnt_count = conf->sec_elmnt_count;
+               if (alloc_other_bvds(ddf, vcl) != 0) {
+                       free(update->space);
                        update->space = NULL;
+               }
+       }
+}
+
+/*
+ * Check degraded state of a RAID10.
+ * returns 2 for good, 1 for degraded, 0 for failed, and -1 for error
+ */
+static int raid10_degraded(struct mdinfo *info)
+{
+       int n_prim, n_bvds;
+       int i;
+       struct mdinfo *d;
+       char *found;
+       int ret = -1;
+
+       n_prim = info->array.layout & ~0x100;
+       n_bvds = info->array.raid_disks / n_prim;
+       found = xmalloc(n_bvds);
+       if (found == NULL)
+               return ret;
+       memset(found, 0, n_bvds);
+       for (d = info->devs; d; d = d->next) {
+               i = d->disk.raid_disk / n_prim;
+               if (i >= n_bvds) {
+                       pr_err("%s: BUG: invalid raid disk\n", __func__);
+                       goto out;
+               }
+               if (d->state_fd > 0)
+                       found[i]++;
+       }
+       ret = 2;
+       for (i = 0; i < n_bvds; i++)
+               if (!found[i]) {
+                       dprintf("%s: BVD %d/%d failed\n", __func__, i, n_bvds);
+                       ret = 0;
+                       goto out;
+               } else if (found[i] < n_prim) {
+                       dprintf("%s: BVD %d/%d degraded\n", __func__, i,
+                               n_bvds);
+                       ret = 1;
+               }
+out:
+       free(found);
+       return ret;
 }
 
 /*
@@ -4334,9 +4879,9 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
        struct metadata_update *mu;
        struct dl *dl;
        int i;
+       unsigned int j;
        struct vcl *vcl;
        struct vd_config *vc;
-       __u64 *lba;
        unsigned int n_bvd;
 
        for (d = a->info.devs ; d ; d = d->next) {
@@ -4348,7 +4893,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        working ++;
        }
 
-       dprintf("ddf_activate: working=%d (%d) level=%d\n", working, a->info.array.raid_disks,
+       dprintf("%s: working=%d (%d) level=%d\n", __func__, working,
+               a->info.array.raid_disks,
                a->info.array.level);
        if (working == a->info.array.raid_disks)
                return NULL; /* array not degraded */
@@ -4366,6 +4912,10 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                if (working < a->info.array.raid_disks - 2)
                        return NULL; /* failed */
                break;
+       case 10:
+               if (raid10_degraded(&a->info) < 1)
+                       return NULL;
+               break;
        default: /* concat or stripe */
                return NULL; /* failed */
        }
@@ -4390,24 +4940,35 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        int is_dedicated = 0;
                        struct extent *ex;
                        unsigned int j;
+                       be16 state = ddf->phys->entries[dl->pdnum].state;
+                       if (be16_and(state,
+                                    cpu_to_be16(DDF_Failed|DDF_Missing)) ||
+                           !be16_and(state,
+                                     cpu_to_be16(DDF_Online)))
+                               continue;
+
                        /* If in this array, skip */
                        for (d2 = a->info.devs ; d2 ; d2 = d2->next)
                                if (d2->state_fd >= 0 &&
                                    d2->disk.major == dl->major &&
                                    d2->disk.minor == dl->minor) {
-                                       dprintf("%x:%x already in array\n", dl->major, dl->minor);
+                                       dprintf("%x:%x (%08x) already in array\n",
+                                               dl->major, dl->minor,
+                                               be32_to_cpu(dl->disk.refnum));
                                        break;
                                }
                        if (d2)
                                continue;
-                       if (ddf->phys->entries[dl->pdnum].type &
-                           __cpu_to_be16(DDF_Spare)) {
+                       if (be16_and(ddf->phys->entries[dl->pdnum].type,
+                                    cpu_to_be16(DDF_Spare))) {
                                /* Check spare assign record */
                                if (dl->spare) {
                                        if (dl->spare->type & DDF_spare_dedicated) {
                                                /* check spare_ents for guid */
                                                for (j = 0 ;
-                                                    j < __be16_to_cpu(dl->spare->populated);
+                                                    j < be16_to_cpu
+                                                            (dl->spare
+                                                             ->populated);
                                                     j++) {
                                                        if (memcmp(dl->spare->spare_ents[j].guid,
                                                                   ddf->virt->entries[a->info.container_member].guid,
@@ -4417,11 +4978,12 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                                        } else
                                                is_global = 1;
                                }
-                       } else if (ddf->phys->entries[dl->pdnum].type &
-                                  __cpu_to_be16(DDF_Global_Spare)) {
+                       } else if (be16_and(ddf->phys->entries[dl->pdnum].type,
+                                           cpu_to_be16(DDF_Global_Spare))) {
                                is_global = 1;
-                       } else if (!(ddf->phys->entries[dl->pdnum].state &
-                                    __cpu_to_be16(DDF_Failed))) {
+                       } else if (!be16_and(ddf->phys
+                                            ->entries[dl->pdnum].state,
+                                            cpu_to_be16(DDF_Failed))) {
                                /* we can possibly use some of this */
                                is_global = 1;
                        }
@@ -4472,8 +5034,9 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        di->container_member = dl->pdnum;
                        di->next = rv;
                        rv = di;
-                       dprintf("%x:%x to be %d at %llu\n", dl->major, dl->minor,
-                               i, pos);
+                       dprintf("%x:%x (%08x) to be %d at %llu\n",
+                               dl->major, dl->minor,
+                               be32_to_cpu(dl->disk.refnum), i, pos);
 
                        break;
                }
@@ -4492,26 +5055,51 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
         * Create a metadata_update record to update the
         * phys_refnum and lba_offset values
         */
+       vc = find_vdcr(ddf, a->info.container_member, rv->disk.raid_disk,
+                      &n_bvd, &vcl);
+       if (vc == NULL)
+               return NULL;
+
        mu = xmalloc(sizeof(*mu));
        if (posix_memalign(&mu->space, 512, sizeof(struct vcl)) != 0) {
                free(mu);
                mu = NULL;
        }
-       mu->buf = xmalloc(ddf->conf_rec_len * 512);
-       mu->len = ddf->conf_rec_len * 512;
+
+       mu->len = ddf->conf_rec_len * 512 * vcl->conf.sec_elmnt_count;
+       mu->buf = xmalloc(mu->len);
        mu->space = NULL;
        mu->space_list = NULL;
        mu->next = *updates;
-       vc = find_vdcr(ddf, a->info.container_member, di->disk.raid_disk,
-                      &n_bvd, &vcl);
-       memcpy(mu->buf, vc, ddf->conf_rec_len * 512);
+       memcpy(mu->buf, &vcl->conf, ddf->conf_rec_len * 512);
+       for (j = 1; j < vcl->conf.sec_elmnt_count; j++)
+               memcpy(mu->buf + j * ddf->conf_rec_len * 512,
+                      vcl->other_bvds[j-1], ddf->conf_rec_len * 512);
 
        vc = (struct vd_config*)mu->buf;
-       lba = (__u64*)&vc->phys_refnum[ddf->mppe];
        for (di = rv ; di ; di = di->next) {
-               vc->phys_refnum[di->disk.raid_disk] =
-                       ddf->phys->entries[dl->pdnum].refnum;
-               lba[di->disk.raid_disk] = di->data_offset;
+               unsigned int i_sec, i_prim;
+               i_sec = di->disk.raid_disk
+                       / be16_to_cpu(vcl->conf.prim_elmnt_count);
+               i_prim = di->disk.raid_disk
+                       % be16_to_cpu(vcl->conf.prim_elmnt_count);
+               vc = (struct vd_config *)(mu->buf
+                                         + i_sec * ddf->conf_rec_len * 512);
+               for (dl = ddf->dlist; dl; dl = dl->next)
+                       if (dl->major == di->disk.major
+                           && dl->minor == di->disk.minor)
+                               break;
+               if (!dl) {
+                       pr_err("%s: BUG: can't find disk %d (%d/%d)\n",
+                              __func__, di->disk.raid_disk,
+                              di->disk.major, di->disk.minor);
+                       return NULL;
+               }
+               vc->phys_refnum[i_prim] = ddf->phys->entries[dl->pdnum].refnum;
+               LBA_OFFSET(ddf, vc)[i_prim] = cpu_to_be64(di->data_offset);
+               dprintf("BVD %u gets %u: %08x at %llu\n", i_sec, i_prim,
+                       be32_to_cpu(vc->phys_refnum[i_prim]),
+                       be64_to_cpu(LBA_OFFSET(ddf, vc)[i_prim]));
        }
        *updates = mu;
        return rv;
@@ -4558,6 +5146,7 @@ struct superswitch super_ddf = {
        .remove_from_super = remove_from_super_ddf,
        .load_container = load_container_ddf,
        .copy_metadata = copy_metadata_ddf,
+       .kill_subarray  = kill_subarray_ddf,
 #endif
        .match_home     = match_home_ddf,
        .uuid_from_super= uuid_from_super_ddf,