]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - super-ddf.c
introduce --detail-platform to display platform raid capabilities
[thirdparty/mdadm.git] / super-ddf.c
index f3a7904e2770f1307d4ddf5f373d5e7c5170bb61..51f97d3b84ec6cecb38bfadc0e734221af8947fb 100644 (file)
 #include "sha1.h"
 #include <values.h>
 
-static inline int ROUND_UP(int a, int base)
-{
-       return ((a+base-1)/base)*base;
-}
-
 /* a non-official T10 name for creation GUIDs */
 static char T10[] = "Linux-MD";
 
@@ -395,32 +390,45 @@ struct bad_block_log {
  * built in Create or Assemble to describe the whole array.
  */
 struct ddf_super {
-       struct ddf_header anchor, primary, secondary, *active;
+       struct ddf_header anchor, primary, secondary;
        struct ddf_controller_data controller;
+       struct ddf_header *active;
        struct phys_disk        *phys;
        struct virtual_disk     *virt;
        int pdsize, vdsize;
        int max_part, mppe, conf_rec_len;
        int currentdev;
+       int updates_pending;
        struct vcl {
-               struct vcl      *next;
-               __u64           *lba_offset; /* location in 'conf' of
-                                             * the lba table */
-               int     vcnum; /* index into ->virt */
-               __u64           *block_sizes; /* NULL if all the same */
+               union {
+                       char space[512];
+                       struct {
+                               struct vcl      *next;
+                               __u64           *lba_offset; /* location in 'conf' of
+                                                             * the lba table */
+                               int     vcnum; /* index into ->virt */
+                               __u64           *block_sizes; /* NULL if all the same */
+                       };
+               };
                struct vd_config conf;
        } *conflist, *currentconf;
        struct dl {
-               struct dl       *next;
+               union {
+                       char space[512];
+                       struct {
+                               struct dl       *next;
+                               int major, minor;
+                               char *devname;
+                               int fd;
+                               unsigned long long size; /* sectors */
+                               int pdnum;      /* index in ->phys */
+                               struct spare_assign *spare;
+                       };
+               };
                struct disk_data disk;
-               int major, minor;
-               char *devname;
-               int fd;
-               unsigned long long size; /* sectors */
-               int pdnum;      /* index in ->phys */
-               struct spare_assign *spare;
+               void *mdupdate; /* hold metadata update */
                struct vcl *vlist[0]; /* max_part in size */
-       } *dlist;
+       } *dlist, *add_list;
 };
 
 #ifndef offsetof
@@ -438,7 +446,10 @@ static int calc_crc(void *buf, int len)
 
        newcrc = crc32(0, buf, len);
        ddf->crc = oldcrc;
-       return newcrc;
+       /* The crc is store (like everything) bigendian, so convert
+        * here for simplicity
+        */
+       return __cpu_to_be32(newcrc);
 }
 
 static int load_ddf_header(int fd, unsigned long long lba,
@@ -496,8 +507,9 @@ static void *load_section(int fd, struct ddf_super *super, void *buf,
                /* All pre-allocated sections are a single block */
                if (len != 1)
                        return NULL;
-       } else
-               buf = malloc(len<<9);
+       } else if (posix_memalign(&buf, 512, len<<9) != 0)
+               buf = NULL;
+
        if (!buf)
                return NULL;
 
@@ -632,8 +644,13 @@ static int load_ddf_local(int fd, struct ddf_super *super,
        unsigned long long dsize;
 
        /* First the local disk info */
-       dl = malloc(sizeof(*dl) +
-                   (super->max_part) * sizeof(dl->vlist[0]));
+       if (posix_memalign((void**)&dl, 512,
+                      sizeof(*dl) +
+                      (super->max_part) * sizeof(dl->vlist[0])) != 0) {
+               fprintf(stderr, Name ": %s could not allocate disk info buffer\n",
+                       __func__);
+               return 1;
+       }
 
        load_section(fd, super, &dl->disk,
                     super->active->data_section_offset,
@@ -682,7 +699,14 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                if (vd->magic == DDF_SPARE_ASSIGN_MAGIC) {
                        if (dl->spare)
                                continue;
-                       dl->spare = malloc(super->conf_rec_len*512);
+                       if (posix_memalign((void**)&dl->spare, 512,
+                                      super->conf_rec_len*512) != 0) {
+                               fprintf(stderr, Name
+                                       ": %s could not allocate spare info buf\n",
+                                       __func__);
+                               return 1;
+                       }
+                               
                        memcpy(dl->spare, vd, super->conf_rec_len*512);
                        continue;
                }
@@ -700,8 +724,14 @@ static int load_ddf_local(int fd, struct ddf_super *super,
                            __be32_to_cpu(vcl->conf.seqnum))
                                continue;
                } else {
-                       vcl = malloc(super->conf_rec_len*512 +
-                                    offsetof(struct vcl, conf));
+                       if (posix_memalign((void**)&vcl, 512,
+                                      (super->conf_rec_len*512 +
+                                       offsetof(struct vcl, conf))) != 0) {
+                               fprintf(stderr, Name
+                                       ": %s could not allocate vcl buf\n",
+                                       __func__);
+                               return 1;
+                       }
                        vcl->next = super->conflist;
                        vcl->block_sizes = NULL; /* FIXME not for CONCAT */
                        super->conflist = vcl;
@@ -765,8 +795,7 @@ static int load_super_ddf(struct supertype *st, int fd,
                }
        }
 
-       super = malloc(sizeof(*super));
-       if (!super) {
+       if (posix_memalign((void**)&super, 512, sizeof(*super))!= 0) {
                fprintf(stderr, Name ": malloc of %zu failed.\n",
                        sizeof(*super));
                return 1;
@@ -792,7 +821,16 @@ static int load_super_ddf(struct supertype *st, int fd,
                return rv;
        }
 
-       load_ddf_local(fd, super, devname, 0);
+       rv = load_ddf_local(fd, super, devname, 0);
+
+       if (rv) {
+               if (devname)
+                       fprintf(stderr,
+                               Name ": Failed to load all information "
+                               "sections on %s\n", devname);
+               free(super);
+               return rv;
+       }
 
        /* Should possibly check the sections .... */
 
@@ -802,6 +840,7 @@ static int load_super_ddf(struct supertype *st, int fd,
                st->minor_version = 0;
                st->max_devs = 512;
        }
+       st->loaded_container = 0;
        return 0;
 
 }
@@ -931,6 +970,15 @@ static int map_num1(struct num_mapping *map, int num)
        return map[i].num2;
 }
 
+static int all_ff(char *guid)
+{
+       int i;
+       for (i = 0; i < DDF_GUID_LEN; i++)
+               if (guid[i] != (char)0xff)
+                       return 0;
+       return 1;
+}
+
 #ifndef MDASSEMBLE
 static void print_guid(char *guid, int tstamp)
 {
@@ -1087,20 +1135,35 @@ static void examine_super_ddf(struct supertype *st, char *homehost)
        examine_pds(sb);
 }
 
+static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info);
+
+static void uuid_from_super_ddf(struct supertype *st, int uuid[4]);
+
 static void brief_examine_super_ddf(struct supertype *st)
 {
        /* We just write a generic DDF ARRAY entry
-        * The uuid is all hex, 6 groups of 4 bytes
         */
        struct ddf_super *ddf = st->sb;
+       struct mdinfo info;
        int i;
-       printf("ARRAY /dev/ddf metadata=ddf UUID=");
-       for (i = 0; i < DDF_GUID_LEN; i++) {
-               if ((i&3) == 0 && i != 0)
-                       printf(":");
-               printf("%02X", 255&ddf->anchor.guid[i]);
+       char nbuf[64];
+       getinfo_super_ddf(st, &info);
+       fname_from_uuid(st, &info, nbuf, ':');
+       printf("ARRAY metadata=ddf UUID=%s\n", nbuf + 5);
+
+       for (i=0; i<__be16_to_cpu(ddf->virt->max_vdes); i++) {
+               struct virtual_entry *ve = &ddf->virt->entries[i];
+               struct vcl vcl;
+               char nbuf1[64];
+               if (all_ff(ve->guid))
+                       continue;
+               memcpy(vcl.conf.guid, ve->guid, DDF_GUID_LEN);
+               ddf->currentconf =&vcl;
+               uuid_from_super_ddf(st, info.uuid);
+               fname_from_uuid(st, &info, nbuf1, ':');
+               printf("ARRAY container=%s member=%d UUID=%s\n",
+                      nbuf+5, i, nbuf1+5);
        }
-       printf("\n");
 }
 
 static void detail_super_ddf(struct supertype *st, char *homehost)
@@ -1119,6 +1182,11 @@ static void brief_detail_super_ddf(struct supertype *st)
         * Can that be stored in ddf_super??
         */
 //     struct ddf_super *ddf = st->sb;
+       struct mdinfo info;
+       char nbuf[64];
+       getinfo_super_ddf(st, &info);
+       fname_from_uuid(st, &info, nbuf,':');
+       printf(" UUID=%s", nbuf + 5);
 }
 #endif
 
@@ -1137,6 +1205,7 @@ static int match_home_ddf(struct supertype *st, char *homehost)
                ddf->controller.vendor_data[len] == 0);
 }
 
+#ifndef MDASSEMBLE
 static struct vd_config *find_vdcr(struct ddf_super *ddf, int inst)
 {
        struct vcl *v;
@@ -1146,6 +1215,7 @@ static struct vd_config *find_vdcr(struct ddf_super *ddf, int inst)
                        return &v->conf;
        return NULL;
 }
+#endif
 
 static int find_phys(struct ddf_super *ddf, __u32 phys_refnum)
 {
@@ -1165,11 +1235,14 @@ static void uuid_from_super_ddf(struct supertype *st, int uuid[4])
         *  uuid to put into bitmap file (Create, Grow)
         *  uuid for backup header when saving critical section (Grow)
         *  comparing uuids when re-adding a device into an array
+        *    In these cases the uuid required is that of the data-array,
+        *    not the device-set.
+        *  uuid to recognise same set when adding a missing device back
+        *    to an array.   This is a uuid for the device-set.
+        *  
         * For each of these we can make do with a truncated
         * or hashed uuid rather than the original, as long as
         * everyone agrees.
-        * In each case the uuid required is that of the data-array,
-        * not the device-set.
         * In the case of SVD we assume the BVD is of interest,
         * though that might be the case if a bitmap were made for
         * a mirrored SVD - worry about that later.
@@ -1179,19 +1252,19 @@ static void uuid_from_super_ddf(struct supertype *st, int uuid[4])
         */
        struct ddf_super *ddf = st->sb;
        struct vcl *vcl = ddf->currentconf;
+       char *guid;
+       char buf[20];
+       struct sha1_ctx ctx;
 
-       if (!vcl)
-               memset(uuid, 0, sizeof (uuid));
-       else {
-               char buf[20];
-               struct sha1_ctx ctx;
-               sha1_init_ctx(&ctx);
-               sha1_process_bytes(&vcl->conf.guid, DDF_GUID_LEN, &ctx);
-               if (vcl->conf.sec_elmnt_count > 1)
-                       sha1_process_bytes(&vcl->conf.sec_elmnt_seq, 1, &ctx);
-               sha1_finish_ctx(&ctx, buf);
-               memcpy(uuid, buf, sizeof(uuid));
-       }
+       if (vcl)
+               guid = vcl->conf.guid;
+       else
+               guid = ddf->anchor.guid;
+
+       sha1_init_ctx(&ctx);
+       sha1_process_bytes(guid, DDF_GUID_LEN, &ctx);
+       sha1_finish_ctx(&ctx, buf);
+       memcpy(uuid, buf, 4*4);
 }
 
 static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info);
@@ -1233,12 +1306,15 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info)
 
 
        info->reshape_active = 0;
+       info->name[0] = 0;
 
+       info->array.major_version = -1;
+       info->array.minor_version = -2;
        strcpy(info->text_version, "ddf");
+       info->safe_mode_delay = 0;
 
-//     uuid_from_super_ddf(info->uuid, sbv);
+       uuid_from_super_ddf(st, info->uuid);
 
-//     info->name[] ?? ;
 }
 
 static int rlq_to_layout(int rlq, int prl, int raiddisks);
@@ -1248,6 +1324,7 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info)
        struct ddf_super *ddf = st->sb;
        struct vcl *vc = ddf->currentconf;
        int cd = ddf->currentdev;
+       int j;
 
        /* FIXME this returns BVD info - what if we want SVD ?? */
 
@@ -1275,6 +1352,8 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info)
 //     info->disk.raid_disk = find refnum in the table and use index;
 //     info->disk.state = ???;
 
+       info->container_member = ddf->currentconf->vcnum;
+
        info->resync_start = 0;
        if (!(ddf->virt->entries[info->container_member].state
              & DDF_state_inconsistent)  &&
@@ -1285,11 +1364,19 @@ static void getinfo_super_ddf_bvd(struct supertype *st, struct mdinfo *info)
 
        uuid_from_super_ddf(st, info->uuid);
 
-       sprintf(info->text_version, "/%s/%d",
+       info->container_member = atoi(st->subarray);
+       info->array.major_version = -1;
+       info->array.minor_version = -2;
+       sprintf(info->text_version, "/%s/%s",
                devnum2devname(st->container_dev),
-               info->container_member);
-
-//     info->name[] ?? ;
+               st->subarray);
+       info->safe_mode_delay = 200;
+
+       memcpy(info->name, ddf->virt->entries[info->container_member].name, 16);
+       info->name[16]=0;
+       for(j=0; j<16; j++)
+               if (info->name[j] == ' ')
+                       info->name[j] = 0;
 }
 
 
@@ -1441,7 +1528,10 @@ static int init_super_ddf(struct supertype *st,
                return init_super_ddf_bvd(st, info, size, name, homehost,
                                          uuid);
 
-       ddf = malloc(sizeof(*ddf));
+       if (posix_memalign((void**)&ddf, 512, sizeof(*ddf)) != 0) {
+               fprintf(stderr, Name ": %s could not allocate superblock\n", __func__);
+               return 0;
+       }
        memset(ddf, 0, sizeof(*ddf));
        ddf->dlist = NULL; /* no physical disks yet */
        ddf->conflist = NULL; /* No virtual disks yet */
@@ -1567,8 +1657,14 @@ static int init_super_ddf(struct supertype *st,
        memcpy(ddf->controller.product_id, "What Is My PID??", 16);
        memset(ddf->controller.pad, 0xff, 8);
        memset(ddf->controller.vendor_data, 0xff, 448);
+       if (homehost && strlen(homehost) < 440)
+               strcpy((char*)ddf->controller.vendor_data, homehost);
 
-       pd = ddf->phys = malloc(pdsize);
+       if (posix_memalign((void**)&pd, 512, pdsize) != 0) {
+               fprintf(stderr, Name ": %s could not allocate pd\n", __func__);
+               return 0;
+       }
+       ddf->phys = pd;
        ddf->pdsize = pdsize;
 
        memset(pd, 0xff, pdsize);
@@ -1578,7 +1674,11 @@ static int init_super_ddf(struct supertype *st,
        pd->max_pdes = __cpu_to_be16(max_phys_disks);
        memset(pd->pad, 0xff, 52);
 
-       vd = ddf->virt = malloc(vdsize);
+       if (posix_memalign((void**)&vd, 512, vdsize) != 0) {
+               fprintf(stderr, Name ": %s could not allocate vd\n", __func__);
+               return 0;
+       }
+       ddf->virt = vd;
        ddf->vdsize = vdsize;
        memset(vd, 0, vdsize);
        vd->magic = DDF_VIRT_RECORDS_MAGIC;
@@ -1590,17 +1690,10 @@ static int init_super_ddf(struct supertype *st,
                memset(&vd->entries[i], 0xff, sizeof(struct virtual_entry));
 
        st->sb = ddf;
+       ddf->updates_pending = 1;
        return 1;
 }
 
-static int all_ff(char *guid)
-{
-       int i;
-       for (i = 0; i < DDF_GUID_LEN; i++)
-               if (guid[i] != (char)0xff)
-                       return 0;
-       return 1;
-}
 static int chunk_to_shift(int chunksize)
 {
        return ffs(chunksize/512)-1;
@@ -1695,6 +1788,7 @@ static int rlq_to_layout(int rlq, int prl, int raiddisks)
        return -1;
 }
 
+#ifndef MDASSEMBLE
 struct extent {
        unsigned long long start, size;
 };
@@ -1745,6 +1839,7 @@ FIXME ignore DDF_Legacy devices?
        rv[n].size = 0;
        return rv;
 }
+#endif
 
 static int init_super_ddf_bvd(struct supertype *st,
                              mdu_array_info_t *info,
@@ -1802,7 +1897,11 @@ static int init_super_ddf_bvd(struct supertype *st,
                __cpu_to_be16(__be16_to_cpu(ddf->virt->populated_vdes)+1);
 
        /* Now create a new vd_config */
-       vcl = malloc(offsetof(struct vcl, conf) + ddf->conf_rec_len * 512);
+       if (posix_memalign((void**)&vcl, 512,
+                          (offsetof(struct vcl, conf) + ddf->conf_rec_len * 512)) != 0) {
+               fprintf(stderr, Name ": %s could not allocate vd_config\n", __func__);
+               return 0;
+       }
        vcl->lba_offset = (__u64*) &vcl->conf.phys_refnum[ddf->mppe];
        vcl->vcnum = venum;
        sprintf(st->subarray, "%d", venum);
@@ -1852,9 +1951,11 @@ static int init_super_ddf_bvd(struct supertype *st,
        vcl->next = ddf->conflist;
        ddf->conflist = vcl;
        ddf->currentconf = vcl;
+       ddf->updates_pending = 1;
        return 1;
 }
 
+#ifndef MDASSEMBLE
 static void add_to_super_ddf_bvd(struct supertype *st,
                                 mdu_disk_info_t *dk, int fd, char *devname)
 {
@@ -1943,12 +2044,13 @@ static void add_to_super_ddf_bvd(struct supertype *st,
 
        ddf->phys->entries[dl->pdnum].type &= ~__cpu_to_be16(DDF_Global_Spare);
        ddf->phys->entries[dl->pdnum].type |= __cpu_to_be16(DDF_Active_in_VD);
+       ddf->updates_pending = 1;
 }
 
 /* add a device to a container, either while creating it or while
  * expanding a pre-existing container
  */
-static void add_to_super_ddf(struct supertype *st,
+static int add_to_super_ddf(struct supertype *st,
                             mdu_disk_info_t *dk, int fd, char *devname)
 {
        struct ddf_super *ddf = st->sb;
@@ -1962,18 +2064,23 @@ static void add_to_super_ddf(struct supertype *st,
 
        if (ddf->currentconf) {
                add_to_super_ddf_bvd(st, dk, fd, devname);
-               return;
+               return 0;
        }
 
        /* This is device numbered dk->number.  We need to create
         * a phys_disk entry and a more detailed disk_data entry.
         */
        fstat(fd, &stb);
-       dd = malloc(sizeof(*dd) + sizeof(dd->vlist[0]) * ddf->max_part);
+       if (posix_memalign((void**)&dd, 512,
+                          sizeof(*dd) + sizeof(dd->vlist[0]) * ddf->max_part) != 0) {
+               fprintf(stderr, Name
+                       ": %s could allocate buffer for new disk, aborting\n",
+                       __func__);
+               return 1;
+       }
        dd->major = major(stb.st_rdev);
        dd->minor = minor(stb.st_rdev);
        dd->devname = devname;
-       dd->next = ddf->dlist;
        dd->fd = fd;
        dd->spare = NULL;
 
@@ -2006,8 +2113,20 @@ static void add_to_super_ddf(struct supertype *st,
        pde = &ddf->phys->entries[n];
        dd->pdnum = n;
 
-       n++;
-       ddf->phys->used_pdes = __cpu_to_be16(n);
+       if (st->update_tail) {
+               int len = (sizeof(struct phys_disk) +
+                          sizeof(struct phys_disk_entry));
+               struct phys_disk *pd;
+
+               pd = malloc(len);
+               pd->magic = DDF_PHYS_RECORDS_MAGIC;
+               pd->used_pdes = __cpu_to_be16(n);
+               pde = &pd->entries[0];
+               dd->mdupdate = pd;
+       } else {
+               n++;
+               ddf->phys->used_pdes = __cpu_to_be16(n);
+       }
 
        memcpy(pde->guid, dd->disk.guid, DDF_GUID_LEN);
        pde->refnum = dd->disk.refnum;
@@ -2020,7 +2139,16 @@ static void add_to_super_ddf(struct supertype *st,
        memset(pde->pad, 0xff, 6);
 
        dd->size = size >> 9;
-       ddf->dlist = dd;
+       if (st->update_tail) {
+               dd->next = ddf->add_list;
+               ddf->add_list = dd;
+       } else {
+               dd->next = ddf->dlist;
+               ddf->dlist = dd;
+               ddf->updates_pending = 1;
+       }
+
+       return 0;
 }
 
 /*
@@ -2029,7 +2157,8 @@ static void add_to_super_ddf(struct supertype *st,
  * container.
  */
 
-#ifndef MDASSEMBLE
+static unsigned char null_conf[4096+512];
+
 static int __write_init_super_ddf(struct supertype *st, int do_close)
 {
 
@@ -2038,15 +2167,20 @@ static int __write_init_super_ddf(struct supertype *st, int do_close)
        struct dl *d;
        int n_config;
        int conf_size;
-
+       int attempts = 0;
+       int successes = 0;
        unsigned long long size, sector;
 
+       /* try to write updated metadata,
+        * if we catch a failure move on to the next disk
+        */
        for (d = ddf->dlist; d; d=d->next) {
                int fd = d->fd;
 
                if (fd < 0)
                        continue;
 
+               attempts++;
                /* We need to fill in the primary, (secondary) and workspace
                 * lba's in the headers, set their checksums,
                 * Also checksum phys, virt....
@@ -2076,17 +2210,21 @@ static int __write_init_super_ddf(struct supertype *st, int do_close)
 
                sector = size - 16*1024*2;
                lseek64(fd, sector<<9, 0);
-               write(fd, &ddf->primary, 512);
+               if (write(fd, &ddf->primary, 512) < 0)
+                       continue;
 
                ddf->controller.crc = calc_crc(&ddf->controller, 512);
-               write(fd, &ddf->controller, 512);
+               if (write(fd, &ddf->controller, 512) < 0)
+                       continue;
 
                ddf->phys->crc = calc_crc(ddf->phys, ddf->pdsize);
 
-               write(fd, ddf->phys, ddf->pdsize);
+               if (write(fd, ddf->phys, ddf->pdsize) < 0)
+                       continue;
 
                ddf->virt->crc = calc_crc(ddf->virt, ddf->vdsize);
-               write(fd, ddf->virt, ddf->vdsize);
+               if (write(fd, ddf->virt, ddf->vdsize) < 0)
+                       continue;
 
                /* Now write lots of config records. */
                n_config = ddf->max_part;
@@ -2098,31 +2236,88 @@ static int __write_init_super_ddf(struct supertype *st, int do_close)
 
                        if (c) {
                                c->conf.crc = calc_crc(&c->conf, conf_size);
-                               write(fd, &c->conf, conf_size);
+                               if (write(fd, &c->conf, conf_size) < 0)
+                                       break;
                        } else {
-                               __u32 sig = 0xffffffff;
-                               write(fd, &sig, 4);
-                               lseek64(fd, conf_size-4, SEEK_CUR);
+                               char *null_aligned = (char*)((((unsigned long)null_conf)+511)&~511UL);
+                               if (null_conf[0] != 0xff)
+                                       memset(null_conf, 0xff, sizeof(null_conf));
+                               int togo = conf_size;
+                               while (togo > sizeof(null_conf)-512) {
+                                       if (write(fd, null_aligned, sizeof(null_conf)-512) < 0)
+                                               break;
+                                       togo -= sizeof(null_conf)-512;
+                               }
+                               if (write(fd, null_aligned, togo) < 0)
+                                       break;
                        }
                }
+               if (i <= n_config)
+                       continue;
                d->disk.crc = calc_crc(&d->disk, 512);
-               write(fd, &d->disk, 512);
+               if (write(fd, &d->disk, 512) < 0)
+                       continue;
 
                /* Maybe do the same for secondary */
 
                lseek64(fd, (size-1)*512, SEEK_SET);
-               write(fd, &ddf->anchor, 512);
-               if (do_close) {
-                       close(fd);
+               if (write(fd, &ddf->anchor, 512) < 0)
+                       continue;
+               successes++;
+       }
+
+       if (do_close)
+               for (d = ddf->dlist; d; d=d->next) {
+                       close(d->fd);
                        d->fd = -1;
                }
-       }
-       return 1;
+
+       return attempts != successes;
 }
 
 static int write_init_super_ddf(struct supertype *st)
 {
-       return __write_init_super_ddf(st, 1);
+
+       if (st->update_tail) {
+               /* queue the virtual_disk and vd_config as metadata updates */
+               struct virtual_disk *vd;
+               struct vd_config *vc;
+               struct ddf_super *ddf = st->sb;
+               int len;
+
+               if (!ddf->currentconf) {
+                       int len = (sizeof(struct phys_disk) +
+                                  sizeof(struct phys_disk_entry));
+
+                       /* adding a disk to the container. */
+                       if (!ddf->add_list)
+                               return 0;
+
+                       append_metadata_update(st, ddf->add_list->mdupdate, len);
+                       ddf->add_list->mdupdate = NULL;
+                       return 0;
+               }
+
+               /* Newly created VD */
+
+               /* First the virtual disk.  We have a slightly fake header */
+               len = sizeof(struct virtual_disk) + sizeof(struct virtual_entry);
+               vd = malloc(len);
+               *vd = *ddf->virt;
+               vd->entries[0] = ddf->virt->entries[ddf->currentconf->vcnum];
+               vd->populated_vdes = __cpu_to_be16(ddf->currentconf->vcnum);
+               append_metadata_update(st, vd, len);
+
+               /* Then the vd_config */
+               len = ddf->conf_rec_len * 512;
+               vc = malloc(len);
+               memcpy(vc, &ddf->currentconf->conf, len);
+               append_metadata_update(st, vc, len);
+
+               /* FIXME I need to close the fds! */
+               return 0;
+       } else 
+               return __write_init_super_ddf(st, 1);
 }
 
 #endif
@@ -2136,20 +2331,24 @@ static __u64 avail_size_ddf(struct supertype *st, __u64 devsize)
 }
 
 #ifndef MDASSEMBLE
-static int validate_geometry_ddf_container(struct supertype *st,
-                                   int level, int layout, int raiddisks,
-                                   int chunk, unsigned long long size,
-                                   char *dev, unsigned long long *freesize);
+static int
+validate_geometry_ddf_container(struct supertype *st,
+                               int level, int layout, int raiddisks,
+                               int chunk, unsigned long long size,
+                               char *dev, unsigned long long *freesize,
+                               int verbose);
 
 static int validate_geometry_ddf_bvd(struct supertype *st,
                                     int level, int layout, int raiddisks,
                                     int chunk, unsigned long long size,
-                                    char *dev, unsigned long long *freesize);
+                                    char *dev, unsigned long long *freesize,
+                                    int verbose);
 
 static int validate_geometry_ddf(struct supertype *st,
-                         int level, int layout, int raiddisks,
-                         int chunk, unsigned long long size,
-                         char *dev, unsigned long long *freesize)
+                                int level, int layout, int raiddisks,
+                                int chunk, unsigned long long size,
+                                char *dev, unsigned long long *freesize,
+                                int verbose)
 {
        int fd;
        struct mdinfo *sra;
@@ -2165,8 +2364,9 @@ static int validate_geometry_ddf(struct supertype *st,
        if (level == LEVEL_CONTAINER) {
                /* Must be a fresh device to add to a container */
                return validate_geometry_ddf_container(st, level, layout,
-                                              raiddisks,
-                                              chunk, size, dev, freesize);
+                                                      raiddisks, chunk,
+                                                      size, dev, freesize,
+                                                      verbose);
        }
 
        if (st->sb) {
@@ -2175,7 +2375,8 @@ static int validate_geometry_ddf(struct supertype *st,
                 * Should make a distinction one day.
                 */
                return validate_geometry_ddf_bvd(st, level, layout, raiddisks,
-                                                chunk, size, dev, freesize);
+                                                chunk, size, dev, freesize,
+                                                verbose);
        }
        if (!dev) {
                /* Initial sanity check.  Exclude illegal levels. */
@@ -2209,22 +2410,26 @@ static int validate_geometry_ddf(struct supertype *st,
                        /* Somehow return the fact that we have enough */
                }
 
-               fprintf(stderr,
-                       Name ": Cannot create this array on device %s\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr,
+                               Name ": ddf: Cannot create this array "
+                               "on device %s\n",
+                               dev);
                return 0;
        }
        if (errno != EBUSY || (fd = open(dev, O_RDONLY, 0)) < 0) {
-               fprintf(stderr, Name ": Cannot open %s: %s\n",
-                       dev, strerror(errno));
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot open %s: %s\n",
+                               dev, strerror(errno));
                return 0;
        }
        /* Well, it is in use by someone, maybe a 'ddf' container. */
        cfd = open_container(fd);
        if (cfd < 0) {
                close(fd);
-               fprintf(stderr, Name ": Cannot use %s: It is busy\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot use %s: %s\n",
+                               dev, strerror(EBUSY));
                return 0;
        }
        sra = sysfs_read(cfd, 0, GET_VERSION);
@@ -2241,7 +2446,8 @@ static int validate_geometry_ddf(struct supertype *st,
                        close(cfd);
                        return validate_geometry_ddf_bvd(st, level, layout,
                                                         raiddisks, chunk, size,
-                                                        dev, freesize);
+                                                        dev, freesize,
+                                                        verbose);
                }
                close(cfd);
        } else /* device may belong to a different container */
@@ -2250,10 +2456,12 @@ static int validate_geometry_ddf(struct supertype *st,
        return 1;
 }
 
-static int validate_geometry_ddf_container(struct supertype *st,
-                                  int level, int layout, int raiddisks,
-                                  int chunk, unsigned long long size,
-                                  char *dev, unsigned long long *freesize)
+static int
+validate_geometry_ddf_container(struct supertype *st,
+                               int level, int layout, int raiddisks,
+                               int chunk, unsigned long long size,
+                               char *dev, unsigned long long *freesize,
+                               int verbose)
 {
        int fd;
        unsigned long long ldsize;
@@ -2265,8 +2473,9 @@ static int validate_geometry_ddf_container(struct supertype *st,
 
        fd = open(dev, O_RDONLY|O_EXCL, 0);
        if (fd < 0) {
-               fprintf(stderr, Name ": Cannot open %s: %s\n",
-                       dev, strerror(errno));
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: Cannot open %s: %s\n",
+                               dev, strerror(errno));
                return 0;
        }
        if (!get_dev_size(fd, dev, &ldsize)) {
@@ -2283,7 +2492,8 @@ static int validate_geometry_ddf_container(struct supertype *st,
 static int validate_geometry_ddf_bvd(struct supertype *st,
                                     int level, int layout, int raiddisks,
                                     int chunk, unsigned long long size,
-                                    char *dev, unsigned long long *freesize)
+                                    char *dev, unsigned long long *freesize,
+                                    int verbose)
 {
        struct stat stb;
        struct ddf_super *ddf = st->sb;
@@ -2328,9 +2538,11 @@ static int validate_geometry_ddf_bvd(struct supertype *st,
                        free(e);
                }
                if (dcnt < raiddisks) {
-                       fprintf(stderr, Name ": Not enough devices with space "
-                               "for this array (%d < %d)\n",
-                               dcnt, raiddisks);
+                       if (verbose)
+                               fprintf(stderr,
+                                       Name ": ddf: Not enough devices with "
+                                       "space for this array (%d < %d)\n",
+                                       dcnt, raiddisks);
                        return 0;
                }
                return 1;
@@ -2346,8 +2558,10 @@ static int validate_geometry_ddf_bvd(struct supertype *st,
                        break;
        }
        if (!dl) {
-               fprintf(stderr, Name ": %s is not in the same DDF set\n",
-                       dev);
+               if (verbose)
+                       fprintf(stderr, Name ": ddf: %s is not in the "
+                               "same DDF set\n",
+                               dev);
                return 0;
        }
        e = get_extents(ddf, dl);
@@ -2386,8 +2600,7 @@ static int load_super_ddf_all(struct supertype *st, int fd,
            strcmp(sra->text_version, "ddf") != 0)
                return 1;
 
-       super = malloc(sizeof(*super));
-       if (!super)
+       if (posix_memalign((void**)&super, 512, sizeof(*super)) != 0)
                return 1;
        memset(super, 0, sizeof(*super));
 
@@ -2422,12 +2635,18 @@ static int load_super_ddf_all(struct supertype *st, int fd,
        close(dfd);
        /* Now we need the device-local bits */
        for (sd = sra->devs ; sd ; sd = sd->next) {
+               int rv;
+
                sprintf(nm, "%d:%d", sd->disk.major, sd->disk.minor);
                dfd = dev_open(nm, keep_fd? O_RDWR : O_RDONLY);
                if (dfd < 0)
                        return 2;
-               seq = load_ddf_local(dfd, super, NULL, keep_fd);
+               rv = load_ddf_headers(dfd, super, NULL);
+               if (rv == 0)
+                       rv = load_ddf_local(dfd, super, NULL, keep_fd);
                if (!keep_fd) close(dfd);
+               if (rv)
+                       return 1;
        }
        if (st->subarray[0]) {
                struct vcl *v;
@@ -2445,9 +2664,10 @@ static int load_super_ddf_all(struct supertype *st, int fd,
                st->max_devs = 512;
                st->container_dev = fd2devnum(fd);
        }
+       st->loaded_container = 1;
        return 0;
 }
-#endif
+#endif /* MDASSEMBLE */
 
 static struct mdinfo *container_content_ddf(struct supertype *st)
 {
@@ -2466,6 +2686,7 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
        for (vc = ddf->conflist ; vc ; vc=vc->next)
        {
                int i;
+               int j;
                struct mdinfo *this;
                this = malloc(sizeof(*this));
                memset(this, 0, sizeof(*this));
@@ -2478,6 +2699,8 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                this->array.layout = rlq_to_layout(vc->conf.rlq, vc->conf.prl,
                                                   this->array.raid_disks);
                this->array.md_minor      = -1;
+               this->array.major_version = -1;
+               this->array.minor_version = -2;
                this->array.ctime         = DECADE +
                        __be32_to_cpu(*(__u32*)(vc->conf.guid+16));
                this->array.utime         = DECADE +
@@ -2494,14 +2717,21 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                        this->array.state = 1;
                        this->resync_start = ~0ULL;
                }
-               memcpy(this->name, ddf->virt->entries[i].name, 32);
-               this->name[33]=0;
+               memcpy(this->name, ddf->virt->entries[i].name, 16);
+               this->name[16]=0;
+               for(j=0; j<16; j++)
+                       if (this->name[j] == ' ')
+                               this->name[j] = 0;
 
                memset(this->uuid, 0, sizeof(this->uuid));
                this->component_size = __be64_to_cpu(vc->conf.blocks);
                this->array.size = this->component_size / 2;
                this->container_member = i;
 
+               ddf->currentconf = vc;
+               uuid_from_super_ddf(st, this->uuid);
+               ddf->currentconf = NULL;
+
                sprintf(this->text_version, "/%s/%d",
                        devnum2devname(st->container_dev),
                        this->container_member);
@@ -2532,8 +2762,8 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
                        dev->disk.raid_disk = i;
                        dev->disk.state = (1<<MD_DISK_SYNC)|(1<<MD_DISK_ACTIVE);
 
-                       dev->events = __le32_to_cpu(ddf->primary.seq);
-                       dev->data_offset = vc->lba_offset[i];
+                       dev->events = __be32_to_cpu(ddf->primary.seq);
+                       dev->data_offset = __be64_to_cpu(vc->lba_offset[i]);
                        dev->component_size = __be64_to_cpu(vc->conf.blocks);
                        if (d->devname)
                                strcpy(dev->name, d->devname);
@@ -2545,14 +2775,21 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
 static int store_zero_ddf(struct supertype *st, int fd)
 {
        unsigned long long dsize;
-       char buf[512];
-       memset(buf, 0, 512);
+       void *buf;
+       int rc;
 
        if (!get_dev_size(fd, NULL, &dsize))
                return 1;
 
+       if (posix_memalign(&buf, 512, 512) != 0)
+               return 1;
+       memset(buf, 0, 512);
+
        lseek64(fd, dsize-512, 0);
-       write(fd, buf, 512);
+       rc = write(fd, buf, 512);
+       free(buf);
+       if (rc < 0)
+               return 1;
        return 0;
 }
 
@@ -2581,6 +2818,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
        return 0;
 }
 
+#ifndef MDASSEMBLE
 /*
  * A new array 'a' has been started which claims to be instance 'inst'
  * within container 'c'.
@@ -2589,7 +2827,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
  */
 static int ddf_open_new(struct supertype *c, struct active_array *a, char *inst)
 {
-       fprintf(stderr, "ddf: open_new %s\n", inst);
+       dprintf("ddf: open_new %s\n", inst);
        a->info.container_member = atoi(inst);
        return 0;
 }
@@ -2603,24 +2841,38 @@ static int ddf_open_new(struct supertype *c, struct active_array *a, char *inst)
  * For DDF, we need to clear the DDF_state_inconsistent bit in the
  * !global! virtual_disk.virtual_entry structure.
  */
-static void ddf_set_array_state(struct active_array *a, int consistent)
+static int ddf_set_array_state(struct active_array *a, int consistent)
 {
        struct ddf_super *ddf = a->container->sb;
        int inst = a->info.container_member;
+       int old = ddf->virt->entries[inst].state;
+       if (consistent == 2) {
+               /* Should check if a recovery should be started FIXME */
+               consistent = 1;
+               if (!is_resync_complete(a))
+                       consistent = 0;
+       }
        if (consistent)
                ddf->virt->entries[inst].state &= ~DDF_state_inconsistent;
        else
                ddf->virt->entries[inst].state |= DDF_state_inconsistent;
+       if (old != ddf->virt->entries[inst].state)
+               ddf->updates_pending = 1;
+
+       old = ddf->virt->entries[inst].init_state;
        ddf->virt->entries[inst].init_state &= ~DDF_initstate_mask;
-       if (a->resync_start == ~0ULL)
+       if (is_resync_complete(a))
                ddf->virt->entries[inst].init_state |= DDF_init_full;
        else if (a->resync_start == 0)
                ddf->virt->entries[inst].init_state |= DDF_init_not;
        else
                ddf->virt->entries[inst].init_state |= DDF_init_quick;
+       if (old != ddf->virt->entries[inst].init_state)
+               ddf->updates_pending = 1;
 
-       printf("ddf mark %s %llu\n", consistent?"clean":"dirty",
-              a->resync_start);
+       dprintf("ddf mark %d %s %llu\n", inst, consistent?"clean":"dirty",
+               a->resync_start);
+       return consistent;
 }
 
 /*
@@ -2646,7 +2898,7 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
        int i, st, working;
 
        if (vc == NULL) {
-               fprintf(stderr, "ddf: cannot find instance %d!!\n", inst);
+               dprintf("ddf: cannot find instance %d!!\n", inst);
                return;
        }
        if (pd < 0) {
@@ -2660,15 +2912,18 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
                        /* FIXME */
                }
        } else {
+               int old = ddf->phys->entries[pd].state;
                if (state & DS_FAULTY)
                        ddf->phys->entries[pd].state  |= __cpu_to_be16(DDF_Failed);
                if (state & DS_INSYNC) {
                        ddf->phys->entries[pd].state  |= __cpu_to_be16(DDF_Online);
                        ddf->phys->entries[pd].state  &= __cpu_to_be16(~DDF_Rebuilding);
                }
+               if (old != ddf->phys->entries[pd].state)
+                       ddf->updates_pending = 1;
        }
 
-       fprintf(stderr, "ddf: set_disk %d to %x\n", n, state);
+       dprintf("ddf: set_disk %d to %x\n", n, state);
 
        /* Now we need to check the state of the array and update
         * virtual_disk.entries[n].state.
@@ -2711,9 +2966,15 @@ static void ddf_set_disk(struct active_array *a, int n, int state)
                break;
        }
 
-       ddf->virt->entries[inst].state =
-               (ddf->virt->entries[inst].state & ~DDF_state_mask)
-               | state;
+       if (ddf->virt->entries[inst].state !=
+           ((ddf->virt->entries[inst].state & ~DDF_state_mask)
+            | state)) {
+
+               ddf->virt->entries[inst].state =
+                       (ddf->virt->entries[inst].state & ~DDF_state_mask)
+                       | state;
+               ddf->updates_pending = 1;
+       }
 
 }
 
@@ -2727,8 +2988,12 @@ static void ddf_sync_metadata(struct supertype *st)
         * but ddf is sufficiently weird that it probably always
         * changes global data ....
         */
+       struct ddf_super *ddf = st->sb;
+       if (!ddf->updates_pending)
+               return;
+       ddf->updates_pending = 0;
        __write_init_super_ddf(st, 0);
-       fprintf(stderr, "ddf: sync_metadata\n");
+       dprintf("ddf: sync_metadata\n");
 }
 
 static void ddf_process_update(struct supertype *st,
@@ -2771,7 +3036,7 @@ static void ddf_process_update(struct supertype *st,
        int mppe;
        int ent;
 
-       printf("Process update %x\n", *magic);
+       dprintf("Process update %x\n", *magic);
 
        switch (*magic) {
        case DDF_PHYS_RECORDS_MAGIC:
@@ -2789,6 +3054,21 @@ static void ddf_process_update(struct supertype *st,
                ddf->phys->entries[ent] = pd->entries[0];
                ddf->phys->used_pdes = __cpu_to_be16(1 +
                                           __be16_to_cpu(ddf->phys->used_pdes));
+               ddf->updates_pending = 1;
+               if (ddf->add_list) {
+                       struct active_array *a;
+                       struct dl *al = ddf->add_list;
+                       ddf->add_list = al->next;
+
+                       al->next = ddf->dlist;
+                       ddf->dlist = al;
+
+                       /* As a device has been added, we should check
+                        * for any degraded devices that might make
+                        * use of this spare */
+                       for (a = st->arrays ; a; a=a->next)
+                               a->check_degraded = 1;
+               }
                break;
 
        case DDF_VIRT_RECORDS_MAGIC:
@@ -2806,19 +3086,20 @@ static void ddf_process_update(struct supertype *st,
                ddf->virt->entries[ent] = vd->entries[0];
                ddf->virt->populated_vdes = __cpu_to_be16(1 +
                              __be16_to_cpu(ddf->virt->populated_vdes));
+               ddf->updates_pending = 1;
                break;
 
        case DDF_VD_CONF_MAGIC:
-               printf("len %d %d\n", update->len, ddf->conf_rec_len);
+               dprintf("len %d %d\n", update->len, ddf->conf_rec_len);
 
                mppe = __be16_to_cpu(ddf->anchor.max_primary_element_entries);
-               if (update->len != ddf->conf_rec_len)
+               if (update->len != ddf->conf_rec_len * 512)
                        return;
                vc = (struct vd_config*)update->buf;
                for (vcl = ddf->conflist; vcl ; vcl = vcl->next)
                        if (memcmp(vcl->conf.guid, vc->guid, DDF_GUID_LEN) == 0)
                                break;
-               printf("vcl = %p\n", vcl);
+               dprintf("vcl = %p\n", vcl);
                if (vcl) {
                        /* An update, just copy the phys_refnum and lba_offset
                         * fields
@@ -2827,10 +3108,12 @@ static void ddf_process_update(struct supertype *st,
                               mppe * (sizeof(__u32) + sizeof(__u64)));
                } else {
                        /* A new VD_CONF */
+                       if (!update->space)
+                               return;
                        vcl = update->space;
                        update->space = NULL;
                        vcl->next = ddf->conflist;
-                       vcl->conf = *vc;
+                       memcpy(&vcl->conf, vc, update->len);
                        vcl->lba_offset = (__u64*)
                                &vcl->conf.phys_refnum[mppe];
                        ddf->conflist = vcl;
@@ -2843,8 +3126,8 @@ static void ddf_process_update(struct supertype *st,
                                for (dn=0; dn < ddf->mppe ; dn++)
                                        if (vcl->conf.phys_refnum[dn] ==
                                            dl->disk.refnum) {
-                                               printf("dev %d has %p at %d\n",
-                                                      dl->pdnum, vcl, vn);
+                                               dprintf("dev %d has %p at %d\n",
+                                                       dl->pdnum, vcl, vn);
                                                dl->vlist[vn++] = vcl;
                                                break;
                                        }
@@ -2870,12 +3153,29 @@ static void ddf_process_update(struct supertype *st,
                                                       DDF_Active_in_VD);
                        }
                }
+               ddf->updates_pending = 1;
                break;
        case DDF_SPARE_ASSIGN_MAGIC:
        default: break;
        }
 }
 
+static void ddf_prepare_update(struct supertype *st,
+                              struct metadata_update *update)
+{
+       /* This update arrived at managemon.
+        * We are about to pass it to monitor.
+        * If a malloc is needed, do it here.
+        */
+       struct ddf_super *ddf = st->sb;
+       __u32 *magic = (__u32*)update->buf;
+       if (*magic == DDF_VD_CONF_MAGIC)
+               if (posix_memalign(&update->space, 512,
+                              offsetof(struct vcl, conf)
+                              + ddf->conf_rec_len * 512) != 0)
+                       update->space = NULL;
+}
+
 /*
  * Check if the array 'a' is degraded but not failed.
  * If it is, find as many spares as are available and needed and
@@ -2915,8 +3215,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        working ++;
        }
 
-       printf("ddf_activate: working=%d (%d) level=%d\n", working, a->info.array.raid_disks,
-              a->info.array.level);
+       dprintf("ddf_activate: working=%d (%d) level=%d\n", working, a->info.array.raid_disks,
+               a->info.array.level);
        if (working == a->info.array.raid_disks)
                return NULL; /* array not degraded */
        switch (a->info.array.level) {
@@ -2943,7 +3243,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                for (d = a->info.devs ; d ; d = d->next)
                        if (d->disk.raid_disk == i)
                                break;
-               printf("found %d: %p %x\n", i, d, d?d->curr_state:0);
+               dprintf("found %d: %p %x\n", i, d, d?d->curr_state:0);
                if (d && (d->state_fd >= 0))
                        continue;
 
@@ -2961,7 +3261,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        for (d2 = a->info.devs ; d2 ; d2 = d2->next)
                                if (d2->disk.major == dl->major &&
                                    d2->disk.minor == dl->minor) {
-                                       printf("%x:%x already in array\n", dl->major, dl->minor);
+                                       dprintf("%x:%x already in array\n", dl->major, dl->minor);
                                        break;
                                }
                        if (d2)
@@ -2989,7 +3289,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        }
                        if ( ! (is_dedicated ||
                                (is_global && global_ok))) {
-                               printf("%x:%x not suitable: %d %d\n", dl->major, dl->minor,
+                               dprintf("%x:%x not suitable: %d %d\n", dl->major, dl->minor,
                                       is_dedicated, is_global);
                                continue;
                        }
@@ -2998,7 +3298,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                         * We need a->info.component_size sectors */
                        ex = get_extents(ddf, dl);
                        if (!ex) {
-                               printf("cannot get extents\n");
+                               dprintf("cannot get extents\n");
                                continue;
                        }
                        j = 0; pos = 0;
@@ -3014,14 +3314,16 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
 
                        free(ex);
                        if (esize < a->info.component_size) {
-                               printf("%x:%x has no room: %llu %llu\n", dl->major, dl->minor,
-                                      esize, a->info.component_size);
+                               dprintf("%x:%x has no room: %llu %llu\n", dl->major, dl->minor,
+                                       esize, a->info.component_size);
                                /* No room */
                                continue;
                        }
 
                        /* Cool, we have a device with some space at pos */
                        di = malloc(sizeof(*di));
+                       if (!di)
+                               continue;
                        memset(di, 0, sizeof(*di));
                        di->disk.number = i;
                        di->disk.raid_disk = i;
@@ -3033,8 +3335,8 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
                        di->container_member = dl->pdnum;
                        di->next = rv;
                        rv = di;
-                       printf("%x:%x to be %d at %llu\n", dl->major, dl->minor,
-                              i, pos);
+                       dprintf("%x:%x to be %d at %llu\n", dl->major, dl->minor,
+                               i, pos);
 
                        break;
                }
@@ -3054,8 +3356,21 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
         * phys_refnum and lba_offset values
         */
        mu = malloc(sizeof(*mu));
+       if (mu && posix_memalign(&mu->space, 512, sizeof(struct vcl)) != 0) {
+               free(mu);
+               mu = NULL;
+       }
+       if (!mu) {
+               while (rv) {
+                       struct mdinfo *n = rv->next;
+
+                       free(rv);
+                       rv = n;
+               }
+               return NULL;
+       }
+               
        mu->buf = malloc(ddf->conf_rec_len * 512);
-       mu->space = malloc(sizeof(struct vcl));
        mu->len = ddf->conf_rec_len;
        mu->next = *updates;
        vc = find_vdcr(ddf, a->info.container_member);
@@ -3071,6 +3386,7 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
        *updates = mu;
        return rv;
 }
+#endif /* MDASSEMBLE */
 
 struct superswitch super_ddf = {
 #ifndef        MDASSEMBLE
@@ -3080,6 +3396,7 @@ struct superswitch super_ddf = {
        .brief_detail_super = brief_detail_super_ddf,
        .validate_geometry = validate_geometry_ddf,
        .write_init_super = write_init_super_ddf,
+       .add_to_super   = add_to_super_ddf,
 #endif
        .match_home     = match_home_ddf,
        .uuid_from_super= uuid_from_super_ddf,
@@ -3095,17 +3412,19 @@ struct superswitch super_ddf = {
        .store_super    = store_zero_ddf,
        .free_super     = free_super_ddf,
        .match_metadata_desc = match_metadata_desc_ddf,
-       .add_to_super   = add_to_super_ddf,
        .container_content = container_content_ddf,
 
        .external       = 1,
 
+#ifndef MDASSEMBLE
 /* for mdmon */
        .open_new       = ddf_open_new,
        .set_array_state= ddf_set_array_state,
        .set_disk       = ddf_set_disk,
        .sync_metadata  = ddf_sync_metadata,
        .process_update = ddf_process_update,
+       .prepare_update = ddf_prepare_update,
        .activate_spare = ddf_activate_spare,
-
+#endif
+       .name = "ddf",
 };