]> git.ipfire.org Git - thirdparty/mdadm.git/blobdiff - super-intel.c
Teach sysfs_add_disk() callers to use ->recovery_start versus 'insync' parameter
[thirdparty/mdadm.git] / super-intel.c
index 300c7b86f6c261052f393b6b3b2b092e79860eac..9f879c515b3a287d9a70d852f14f4efe63726b23 100644 (file)
@@ -64,7 +64,6 @@ struct imsm_disk {
 #define SPARE_DISK      __cpu_to_le32(0x01)  /* Spare */
 #define CONFIGURED_DISK __cpu_to_le32(0x02)  /* Member of some RaidDev */
 #define FAILED_DISK     __cpu_to_le32(0x04)  /* Permanent failure */
-#define USABLE_DISK     __cpu_to_le32(0x08)  /* Fully usable unless FAILED_DISK is set */
        __u32 status;                    /* 0xF0 - 0xF3 */
        __u32 owner_cfg_num; /* which config 0,1,2... owns this disk */ 
 #define        IMSM_DISK_FILLERS       4
@@ -247,6 +246,7 @@ struct intel_super {
        int creating_imsm; /* flag to indicate container creation */
        int current_vol; /* index of raid device undergoing creation */
        __u32 create_offset; /* common start for 'current_vol' */
+       __u32 random; /* random data for seeding new family numbers */
        struct intel_dev *devlist;
        struct dl {
                struct dl *next;
@@ -265,6 +265,14 @@ struct intel_super {
        struct bbm_log *bbm_log;
        const char *hba; /* device path of the raid controller for this metadata */
        const struct imsm_orom *orom; /* platform firmware support */
+       struct intel_super *next; /* (temp) list for disambiguating family_num */
+};
+
+struct intel_disk {
+       struct imsm_disk disk;
+       #define IMSM_UNKNOWN_OWNER (-1)
+       int owner;
+       struct intel_disk *next;
 };
 
 struct extent {
@@ -611,6 +619,21 @@ static __u32 imsm_reserved_sectors(struct intel_super *super, struct dl *dl)
        return rv;
 }
 
+static int is_spare(struct imsm_disk *disk)
+{
+       return (disk->status & SPARE_DISK) == SPARE_DISK;
+}
+
+static int is_configured(struct imsm_disk *disk)
+{
+       return (disk->status & CONFIGURED_DISK) == CONFIGURED_DISK;
+}
+
+static int is_failed(struct imsm_disk *disk)
+{
+       return (disk->status & FAILED_DISK) == FAILED_DISK;
+}
+
 #ifndef MDASSEMBLE
 static void print_imsm_dev(struct imsm_dev *dev, char *uuid, int disk_idx)
 {
@@ -646,23 +669,24 @@ static void print_imsm_dev(struct imsm_dev *dev, char *uuid, int disk_idx)
        printf("     Chunk Size : %u KiB\n",
                __le16_to_cpu(map->blocks_per_strip) / 2);
        printf("       Reserved : %d\n", __le32_to_cpu(dev->reserved_blocks));
-       printf("  Migrate State : %s", dev->vol.migr_state ? "migrating" : "idle\n");
+       printf("  Migrate State : ");
        if (dev->vol.migr_state) {
                if (migr_type(dev) == MIGR_INIT)
-                       printf(": initializing\n");
+                       printf("initialize\n");
                else if (migr_type(dev) == MIGR_REBUILD)
-                       printf(": rebuilding\n");
+                       printf("rebuild\n");
                else if (migr_type(dev) == MIGR_VERIFY)
-                       printf("check\n");
+                       printf("check\n");
                else if (migr_type(dev) == MIGR_GEN_MIGR)
-                       printf("general migration\n");
+                       printf("general migration\n");
                else if (migr_type(dev) == MIGR_STATE_CHANGE)
-                       printf("state change\n");
+                       printf("state change\n");
                else if (migr_type(dev) == MIGR_REPAIR)
-                       printf("repair\n");
+                       printf("repair\n");
                else
-                       printf(": <unknown:%d>\n", migr_type(dev));
-       }
+                       printf("<unknown:%d>\n", migr_type(dev));
+       } else
+               printf("idle\n");
        printf("      Map State : %s", map_state_str[map->map_state]);
        if (dev->vol.migr_state) {
                struct imsm_map *map = get_imsm_map(dev, 1);
@@ -676,7 +700,6 @@ static void print_imsm_disk(struct imsm_super *mpb, int index, __u32 reserved)
 {
        struct imsm_disk *disk = __get_imsm_disk(mpb, index);
        char str[MAX_RAID_SERIAL_LEN + 1];
-       __u32 s;
        __u64 sz;
 
        if (index < 0)
@@ -685,11 +708,9 @@ static void print_imsm_disk(struct imsm_super *mpb, int index, __u32 reserved)
        printf("\n");
        snprintf(str, MAX_RAID_SERIAL_LEN + 1, "%s", disk->serial);
        printf("  Disk%02d Serial : %s\n", index, str);
-       s = disk->status;
-       printf("          State :%s%s%s%s\n", s&SPARE_DISK ? " spare" : "",
-                                             s&CONFIGURED_DISK ? " active" : "",
-                                             s&FAILED_DISK ? " failed" : "",
-                                             s&USABLE_DISK ? " usable" : "");
+       printf("          State :%s%s%s\n", is_spare(disk) ? " spare" : "",
+                                           is_configured(disk) ? " active" : "",
+                                           is_failed(disk) ? " failed" : "");
        printf("             Id : %08x\n", __le32_to_cpu(disk->scsi_id));
        sz = __le32_to_cpu(disk->total_blocks) - reserved;
        printf("    Usable Size : %llu%s\n", (unsigned long long)sz,
@@ -714,6 +735,7 @@ static void examine_super_imsm(struct supertype *st, char *homehost)
        printf("          Magic : %s\n", str);
        snprintf(str, strlen(MPB_VERSION_RAID0), "%s", get_imsm_version(mpb));
        printf("        Version : %s\n", get_imsm_version(mpb));
+       printf("    Orig Family : %08x\n", __le32_to_cpu(mpb->orig_family_num));
        printf("         Family : %08x\n", __le32_to_cpu(mpb->family_num));
        printf("     Generation : %08x\n", __le32_to_cpu(mpb->generation_num));
        getinfo_super_imsm(st, &info);
@@ -735,7 +757,8 @@ static void examine_super_imsm(struct supertype *st, char *homehost)
                printf("      Signature : %x\n", __le32_to_cpu(log->signature));
                printf("    Entry Count : %d\n", __le32_to_cpu(log->entry_count));
                printf("   Spare Blocks : %d\n",  __le32_to_cpu(log->reserved_spare_block_count));
-               printf("    First Spare : %llx\n", __le64_to_cpu(log->first_spare_lba));
+               printf("    First Spare : %llx\n",
+                      (unsigned long long) __le64_to_cpu(log->first_spare_lba));
        }
        for (i = 0; i < mpb->num_raid_devs; i++) {
                struct mdinfo info;
@@ -753,7 +776,24 @@ static void examine_super_imsm(struct supertype *st, char *homehost)
        }
 }
 
-static void brief_examine_super_imsm(struct supertype *st)
+static void brief_examine_super_imsm(struct supertype *st, int verbose)
+{
+       /* We just write a generic IMSM ARRAY entry */
+       struct mdinfo info;
+       char nbuf[64];
+       struct intel_super *super = st->sb;
+
+       if (!super->anchor->num_raid_devs) {
+               printf("ARRAY metadata=imsm\n");
+               return;
+       }
+
+       getinfo_super_imsm(st, &info);
+       fname_from_uuid(st, &info, nbuf, ':');
+       printf("ARRAY metadata=imsm UUID=%s\n", nbuf + 5);
+}
+
+static void brief_examine_subarrays_imsm(struct supertype *st, int verbose)
 {
        /* We just write a generic IMSM ARRAY entry */
        struct mdinfo info;
@@ -767,15 +807,13 @@ static void brief_examine_super_imsm(struct supertype *st)
 
        getinfo_super_imsm(st, &info);
        fname_from_uuid(st, &info, nbuf, ':');
-       printf("ARRAY metadata=imsm auto=md UUID=%s\n", nbuf + 5);
        for (i = 0; i < super->anchor->num_raid_devs; i++) {
                struct imsm_dev *dev = get_imsm_dev(super, i);
 
                super->current_vol = i;
                getinfo_super_imsm(st, &info);
                fname_from_uuid(st, &info, nbuf1, ':');
-               printf("ARRAY /dev/md/%.16s container=%s\n"
-                      "   member=%d auto=mdp UUID=%s\n",
+               printf("ARRAY /dev/md/%.16s container=%s member=%d UUID=%s\n",
                       dev->volume, nbuf + 5, i, nbuf1 + 5);
        }
 }
@@ -1089,7 +1127,7 @@ static int match_home_imsm(struct supertype *st, char *homehost)
        /* the imsm metadata format does not specify any host
         * identification information.  We return -1 since we can never
         * confirm nor deny whether a given array is "meant" for this
-        * host.  We rely on compare_super and the 'family_num' field to
+        * host.  We rely on compare_super and the 'family_num' fields to
         * exclude member disks that do not belong, and we rely on
         * mdadm.conf to specify the arrays that should be assembled.
         * Auto-assembly may still pick up "foreign" arrays.
@@ -1117,7 +1155,7 @@ static void uuid_from_super_imsm(struct supertype *st, int uuid[4])
         */
        /* imsm does not track uuid's so we synthesis one using sha1 on
         * - The signature (Which is constant for all imsm array, but no matter)
-        * - the family_num of the container
+        * - the orig_family_num of the container
         * - the index number of the volume
         * - the 'serial' number of the volume.
         * Hopefully these are all constant.
@@ -1127,10 +1165,18 @@ static void uuid_from_super_imsm(struct supertype *st, int uuid[4])
        char buf[20];
        struct sha1_ctx ctx;
        struct imsm_dev *dev = NULL;
+       __u32 family_num;
 
+       /* some mdadm versions failed to set ->orig_family_num, in which
+        * case fall back to ->family_num.  orig_family_num will be
+        * fixed up with the first metadata update.
+        */
+       family_num = super->anchor->orig_family_num;
+       if (family_num == 0)
+               family_num = super->anchor->family_num;
        sha1_init_ctx(&ctx);
        sha1_process_bytes(super->anchor->sig, MPB_SIG_LEN, &ctx);
-       sha1_process_bytes(&super->anchor->family_num, sizeof(__u32), &ctx);
+       sha1_process_bytes(&family_num, sizeof(__u32), &ctx);
        if (super->current_vol >= 0)
                dev = get_imsm_dev(super, super->current_vol);
        if (dev) {
@@ -1225,7 +1271,7 @@ static void getinfo_super_imsm_volume(struct supertype *st, struct mdinfo *info)
                /* FIXME add curr_migr_unit to resync_start conversion */
                info->resync_start = 0;
        else
-               info->resync_start = ~0ULL;
+               info->resync_start = MaxSector;
 
        strncpy(info->name, (char *) dev->volume, MAX_RAID_SERIAL_LEN);
        info->name[MAX_RAID_SERIAL_LEN] = 0;
@@ -1256,7 +1302,11 @@ static void fixup_container_spare_uuid(struct mdinfo *inf)
                        struct supertype *_cst; /* container supertype */
 
                        _cst = array_list->st;
-                       _sst = _cst->ss->match_metadata_desc(inf->text_version);
+                       if (_cst)
+                               _sst = _cst->ss->match_metadata_desc(inf->text_version);
+                       else
+                               _sst = NULL;
+
                        if (_sst) {
                                memcpy(inf->uuid, array_list->uuid, sizeof(int[4]));
                                free(_sst);
@@ -1270,7 +1320,6 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info)
 {
        struct intel_super *super = st->sb;
        struct imsm_disk *disk;
-       __u32 s;
 
        if (super->current_vol >= 0) {
                getinfo_super_imsm_volume(st, info);
@@ -1306,14 +1355,13 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info)
                disk = &super->disks->disk;
                info->data_offset = __le32_to_cpu(disk->total_blocks) - reserved;
                info->component_size = reserved;
-               s = disk->status;
-               info->disk.state  = s & CONFIGURED_DISK ? (1 << MD_DISK_ACTIVE) : 0;
+               info->disk.state  = is_configured(disk) ? (1 << MD_DISK_ACTIVE) : 0;
                /* we don't change info->disk.raid_disk here because
                 * this state will be finalized in mdmon after we have
                 * found the 'most fresh' version of the metadata
                 */
-               info->disk.state |= s & FAILED_DISK ? (1 << MD_DISK_FAULTY) : 0;
-               info->disk.state |= s & SPARE_DISK ? 0 : (1 << MD_DISK_SYNC);
+               info->disk.state |= is_failed(disk) ? (1 << MD_DISK_FAULTY) : 0;
+               info->disk.state |= is_spare(disk) ? 0 : (1 << MD_DISK_SYNC);
        }
 
        /* only call uuid_from_super_imsm when this disk is part of a populated container,
@@ -1331,8 +1379,6 @@ static int update_super_imsm(struct supertype *st, struct mdinfo *info,
                             char *update, char *devname, int verbose,
                             int uuid_set, char *homehost)
 {
-       /* FIXME */
-
        /* For 'assemble' and 'force' we need to return non-zero if any
         * change was made.  For others, the return value is ignored.
         * Update options are:
@@ -1348,26 +1394,55 @@ static int update_super_imsm(struct supertype *st, struct mdinfo *info,
         *              linear only
         *  resync: mark as dirty so a resync will happen.
         *  name:  update the name - preserving the homehost
+        *  uuid:  Change the uuid of the array to match watch is given
         *
         * Following are not relevant for this imsm:
         *  sparc2.2 : update from old dodgey metadata
         *  super-minor: change the preferred_minor number
         *  summaries:  update redundant counters.
-        *  uuid:  Change the uuid of the array to match watch is given
         *  homehost:  update the recorded homehost
         *  _reshape_progress: record new reshape_progress position.
         */
-       int rv = 0;
-       //struct intel_super *super = st->sb;
-       //struct imsm_super *mpb = super->mpb;
+       int rv = 1;
+       struct intel_super *super = st->sb;
+       struct imsm_super *mpb;
 
-       if (strcmp(update, "grow") == 0) {
-       }
-       if (strcmp(update, "resync") == 0) {
-               /* dev->vol.dirty = 1; */
-       }
+       /* we can only update container info */
+       if (!super || super->current_vol >= 0 || !super->anchor)
+               return 1;
 
-       /* IMSM has no concept of UUID or homehost */
+       mpb = super->anchor;
+
+       if (strcmp(update, "uuid") == 0 && uuid_set && !info->update_private)
+               fprintf(stderr,
+                       Name ": '--uuid' not supported for imsm metadata\n");
+       else if (strcmp(update, "uuid") == 0 && uuid_set && info->update_private) {
+               mpb->orig_family_num = *((__u32 *) info->update_private);
+               rv = 0;
+       } else if (strcmp(update, "uuid") == 0) {
+               __u32 *new_family = malloc(sizeof(*new_family));
+
+               /* update orig_family_number with the incoming random
+                * data, report the new effective uuid, and store the
+                * new orig_family_num for future updates.
+                */
+               if (new_family) {
+                       memcpy(&mpb->orig_family_num, info->uuid, sizeof(__u32));
+                       uuid_from_super_imsm(st, info->uuid);
+                       *new_family = mpb->orig_family_num;
+                       info->update_private = new_family;
+                       rv = 0;
+               }
+       } else if (strcmp(update, "assemble") == 0)
+               rv = 0;
+       else
+               fprintf(stderr,
+                       Name ": '--update=%s' not supported for imsm metadata\n",
+                       update);
+
+       /* successful update? recompute checksum */
+       if (rv == 0)
+               mpb->check_sum = __le32_to_cpu(__gen_imsm_checksum(mpb));
 
        return rv;
 }
@@ -1430,18 +1505,33 @@ static int compare_super_imsm(struct supertype *st, struct supertype *tst)
                 return 0;
         }
 
-       if (memcmp(first->anchor->sig, sec->anchor->sig, MAX_SIGNATURE_LENGTH) != 0)
-               return 3;
-
        /* if an anchor does not have num_raid_devs set then it is a free
         * floating spare
         */
        if (first->anchor->num_raid_devs > 0 &&
            sec->anchor->num_raid_devs > 0) {
-               if (first->anchor->family_num != sec->anchor->family_num)
+               /* Determine if these disks might ever have been
+                * related.  Further disambiguation can only take place
+                * in load_super_imsm_all
+                */
+               __u32 first_family = first->anchor->orig_family_num;
+               __u32 sec_family = sec->anchor->orig_family_num;
+
+               if (memcmp(first->anchor->sig, sec->anchor->sig,
+                          MAX_SIGNATURE_LENGTH) != 0)
+                       return 3;
+
+               if (first_family == 0)
+                       first_family = first->anchor->family_num;
+               if (sec_family == 0)
+                       sec_family = sec->anchor->family_num;
+
+               if (first_family != sec_family)
                        return 3;
+
        }
 
+
        /* if 'first' is a spare promote it to a populated mpb with sec's
         * family number
         */
@@ -1468,17 +1558,18 @@ static int compare_super_imsm(struct supertype *st, struct supertype *tst)
                        dv->next = first->devlist;
                        first->devlist = dv;
                }
-               if (i <= sec->anchor->num_raid_devs) {
+               if (i < sec->anchor->num_raid_devs) {
                        /* allocation failure */
                        free_devlist(first);
                        fprintf(stderr, "imsm: failed to associate spare\n"); 
                        return 3;
                }
-               for (i = 0; i < sec->anchor->num_raid_devs; i++)
-                       imsm_copy_dev(get_imsm_dev(first, i), get_imsm_dev(sec, i));
-
                first->anchor->num_raid_devs = sec->anchor->num_raid_devs;
+               first->anchor->orig_family_num = sec->anchor->orig_family_num;
                first->anchor->family_num = sec->anchor->family_num;
+               memcpy(first->anchor->sig, sec->anchor->sig, MAX_SIGNATURE_LENGTH);
+               for (i = 0; i < sec->anchor->num_raid_devs; i++)
+                       imsm_copy_dev(get_imsm_dev(first, i), get_imsm_dev(sec, i));
        }
 
        return 0;
@@ -1508,7 +1599,6 @@ static void fd2devname(int fd, char *name)
        snprintf(name, MAX_RAID_SERIAL_LEN, "/dev/%s", nm);
 }
 
-
 extern int scsi_get_serial(int fd, void *buf, size_t buf_len);
 
 static int imsm_read_serial(int fd, char *devname,
@@ -1591,6 +1681,7 @@ static void serialcpy(__u8 *dest, __u8 *src)
        strncpy((char *) dest, (char *) src, MAX_RAID_SERIAL_LEN);
 }
 
+#ifndef MDASSEMBLE
 static struct dl *serial_to_dl(__u8 *serial, struct intel_super *super)
 {
        struct dl *dl;
@@ -1601,15 +1692,34 @@ static struct dl *serial_to_dl(__u8 *serial, struct intel_super *super)
 
        return dl;
 }
+#endif
+
+static struct imsm_disk *
+__serial_to_disk(__u8 *serial, struct imsm_super *mpb, int *idx)
+{
+       int i;
+
+       for (i = 0; i < mpb->num_disks; i++) {
+               struct imsm_disk *disk = __get_imsm_disk(mpb, i);
+
+               if (serialcmp(disk->serial, serial) == 0) {
+                       if (idx)
+                               *idx = i;
+                       return disk;
+               }
+       }
+
+       return NULL;
+}
 
 static int
 load_imsm_disk(int fd, struct intel_super *super, char *devname, int keep_fd)
 {
+       struct imsm_disk *disk;
        struct dl *dl;
        struct stat stb;
        int rv;
-       int i;
-       int alloc = 1;
+       char name[40];
        __u8 serial[MAX_RAID_SERIAL_LEN];
 
        rv = imsm_read_serial(fd, devname, serial);
@@ -1617,16 +1727,7 @@ load_imsm_disk(int fd, struct intel_super *super, char *devname, int keep_fd)
        if (rv != 0)
                return 2;
 
-       /* check if this is a disk we have seen before.  it may be a spare in
-        * super->disks while the current anchor believes it is a raid member,
-        * check if we need to update dl->index
-        */
-       dl = serial_to_dl(serial, super);
-       if (!dl)
-               dl = malloc(sizeof(*dl));
-       else
-               alloc = 0;
-
+       dl = calloc(1, sizeof(*dl));
        if (!dl) {
                if (devname)
                        fprintf(stderr,
@@ -1635,53 +1736,35 @@ load_imsm_disk(int fd, struct intel_super *super, char *devname, int keep_fd)
                return 2;
        }
 
-       if (alloc) {
-               fstat(fd, &stb);
-               dl->major = major(stb.st_rdev);
-               dl->minor = minor(stb.st_rdev);
-               dl->next = super->disks;
-               dl->fd = keep_fd ? fd : -1;
-               dl->devname = devname ? strdup(devname) : NULL;
-               serialcpy(dl->serial, serial);
-               dl->index = -2;
-               dl->e = NULL;
-       } else if (keep_fd) {
-               close(dl->fd);
-               dl->fd = fd;
-       }
+       fstat(fd, &stb);
+       dl->major = major(stb.st_rdev);
+       dl->minor = minor(stb.st_rdev);
+       dl->next = super->disks;
+       dl->fd = keep_fd ? fd : -1;
+       assert(super->disks == NULL);
+       super->disks = dl;
+       serialcpy(dl->serial, serial);
+       dl->index = -2;
+       dl->e = NULL;
+       fd2devname(fd, name);
+       if (devname)
+               dl->devname = strdup(devname);
+       else
+               dl->devname = strdup(name);
 
        /* look up this disk's index in the current anchor */
-       for (i = 0; i < super->anchor->num_disks; i++) {
-               struct imsm_disk *disk_iter;
-
-               disk_iter = __get_imsm_disk(super->anchor, i);
-
-               if (serialcmp(disk_iter->serial, dl->serial) == 0) {
-                       dl->disk = *disk_iter;
-                       /* only set index on disks that are a member of a
-                        * populated contianer, i.e. one with raid_devs
-                        */
-                       if (dl->disk.status & FAILED_DISK)
-                               dl->index = -2;
-                       else if (dl->disk.status & SPARE_DISK)
-                               dl->index = -1;
-                       else
-                               dl->index = i;
-
-                       break;
-               }
-       }
-
-       /* no match, maybe a stale failed drive */
-       if (i == super->anchor->num_disks && dl->index >= 0) {
-               dl->disk = *__get_imsm_disk(super->anchor, dl->index);
-               if (dl->disk.status & FAILED_DISK)
+       disk = __serial_to_disk(dl->serial, super->anchor, &dl->index);
+       if (disk) {
+               dl->disk = *disk;
+               /* only set index on disks that are a member of a
+                * populated contianer, i.e. one with raid_devs
+                */
+               if (is_failed(&dl->disk))
                        dl->index = -2;
+               else if (is_spare(&dl->disk))
+                       dl->index = -1;
        }
 
-       if (alloc)
-               super->disks = dl;
-
        return 0;
 }
 
@@ -1823,7 +1906,6 @@ static int load_imsm_mpb(int fd, struct intel_super *super, char *devname)
        struct stat;
        struct imsm_super *anchor;
        __u32 check_sum;
-       int rc;
 
        get_dev_size(fd, NULL, &dsize);
 
@@ -1885,10 +1967,7 @@ static int load_imsm_mpb(int fd, struct intel_super *super, char *devname)
                        return 2;
                }
 
-               rc = load_imsm_disk(fd, super, devname, 0);
-               if (rc == 0)
-                       rc = parse_raid_devices(super);
-               return rc;
+               return 0;
        }
 
        /* read the extended mpb */
@@ -1924,11 +2003,23 @@ static int load_imsm_mpb(int fd, struct intel_super *super, char *devname)
         */
        super->bbm_log = __get_imsm_bbm_log(super->anchor);
 
-       rc = load_imsm_disk(fd, super, devname, 0);
-       if (rc == 0)
-               rc = parse_raid_devices(super);
+       return 0;
+}
+
+static int
+load_and_parse_mpb(int fd, struct intel_super *super, char *devname, int keep_fd)
+{
+       int err;
+
+       err = load_imsm_mpb(fd, super, devname);
+       if (err)
+               return err;
+       err = load_imsm_disk(fd, super, devname, keep_fd);
+       if (err)
+               return err;
+       err = parse_raid_devices(super);
 
-       return rc;
+       return err;
 }
 
 static void __free_imsm_disk(struct dl *d)
@@ -2058,19 +2149,333 @@ static int find_missing(struct intel_super *super)
        return 0;
 }
 
+static struct intel_disk *disk_list_get(__u8 *serial, struct intel_disk *disk_list)
+{
+       struct intel_disk *idisk = disk_list;
+
+       while (idisk) {
+               if (serialcmp(idisk->disk.serial, serial) == 0)
+                       break;
+               idisk = idisk->next;
+       }
+
+       return idisk;
+}
+
+static int __prep_thunderdome(struct intel_super **table, int tbl_size,
+                             struct intel_super *super,
+                             struct intel_disk **disk_list)
+{
+       struct imsm_disk *d = &super->disks->disk;
+       struct imsm_super *mpb = super->anchor;
+       int i, j;
+
+       for (i = 0; i < tbl_size; i++) {
+               struct imsm_super *tbl_mpb = table[i]->anchor;
+               struct imsm_disk *tbl_d = &table[i]->disks->disk;
+
+               if (tbl_mpb->family_num == mpb->family_num) {
+                       if (tbl_mpb->check_sum == mpb->check_sum) {
+                               dprintf("%s: mpb from %d:%d matches %d:%d\n",
+                                       __func__, super->disks->major,
+                                       super->disks->minor,
+                                       table[i]->disks->major,
+                                       table[i]->disks->minor);
+                               break;
+                       }
+
+                       if (((is_configured(d) && !is_configured(tbl_d)) ||
+                            is_configured(d) == is_configured(tbl_d)) &&
+                           tbl_mpb->generation_num < mpb->generation_num) {
+                               /* current version of the mpb is a
+                                * better candidate than the one in
+                                * super_table, but copy over "cross
+                                * generational" status
+                                */
+                               struct intel_disk *idisk;
+
+                               dprintf("%s: mpb from %d:%d replaces %d:%d\n",
+                                       __func__, super->disks->major,
+                                       super->disks->minor,
+                                       table[i]->disks->major,
+                                       table[i]->disks->minor);
+
+                               idisk = disk_list_get(tbl_d->serial, *disk_list);
+                               if (idisk && is_failed(&idisk->disk))
+                                       tbl_d->status |= FAILED_DISK;
+                               break;
+                       } else {
+                               struct intel_disk *idisk;
+                               struct imsm_disk *disk;
+
+                               /* tbl_mpb is more up to date, but copy
+                                * over cross generational status before
+                                * returning
+                                */
+                               disk = __serial_to_disk(d->serial, mpb, NULL);
+                               if (disk && is_failed(disk))
+                                       d->status |= FAILED_DISK;
+
+                               idisk = disk_list_get(d->serial, *disk_list);
+                               if (idisk) {
+                                       idisk->owner = i;
+                                       if (disk && is_configured(disk))
+                                               idisk->disk.status |= CONFIGURED_DISK;
+                               }
+
+                               dprintf("%s: mpb from %d:%d prefer %d:%d\n",
+                                       __func__, super->disks->major,
+                                       super->disks->minor,
+                                       table[i]->disks->major,
+                                       table[i]->disks->minor);
+
+                               return tbl_size;
+                       }
+               }
+       }
+
+       if (i >= tbl_size)
+               table[tbl_size++] = super;
+       else
+               table[i] = super;
+
+       /* update/extend the merged list of imsm_disk records */
+       for (j = 0; j < mpb->num_disks; j++) {
+               struct imsm_disk *disk = __get_imsm_disk(mpb, j);
+               struct intel_disk *idisk;
+
+               idisk = disk_list_get(disk->serial, *disk_list);
+               if (idisk) {
+                       idisk->disk.status |= disk->status;
+                       if (is_configured(&idisk->disk) ||
+                           is_failed(&idisk->disk))
+                               idisk->disk.status &= ~(SPARE_DISK);
+               } else {
+                       idisk = calloc(1, sizeof(*idisk));
+                       if (!idisk)
+                               return -1;
+                       idisk->owner = IMSM_UNKNOWN_OWNER;
+                       idisk->disk = *disk;
+                       idisk->next = *disk_list;
+                       *disk_list = idisk;
+               }
+
+               if (serialcmp(idisk->disk.serial, d->serial) == 0)
+                       idisk->owner = i;
+       }
+
+       return tbl_size;
+}
+
+static struct intel_super *
+validate_members(struct intel_super *super, struct intel_disk *disk_list,
+                const int owner)
+{
+       struct imsm_super *mpb = super->anchor;
+       int ok_count = 0;
+       int i;
+
+       for (i = 0; i < mpb->num_disks; i++) {
+               struct imsm_disk *disk = __get_imsm_disk(mpb, i);
+               struct intel_disk *idisk;
+
+               idisk = disk_list_get(disk->serial, disk_list);
+               if (idisk) {
+                       if (idisk->owner == owner ||
+                           idisk->owner == IMSM_UNKNOWN_OWNER)
+                               ok_count++;
+                       else
+                               dprintf("%s: '%.16s' owner %d != %d\n",
+                                       __func__, disk->serial, idisk->owner,
+                                       owner);
+               } else {
+                       dprintf("%s: unknown disk %x [%d]: %.16s\n",
+                               __func__, __le32_to_cpu(mpb->family_num), i,
+                               disk->serial);
+                       break;
+               }
+       }
+
+       if (ok_count == mpb->num_disks)
+               return super;
+       return NULL;
+}
+
+static void show_conflicts(__u32 family_num, struct intel_super *super_list)
+{
+       struct intel_super *s;
+
+       for (s = super_list; s; s = s->next) {
+               if (family_num != s->anchor->family_num)
+                       continue;
+               fprintf(stderr, "Conflict, offlining family %#x on '%s'\n",
+                       __le32_to_cpu(family_num), s->disks->devname);
+       }
+}
+
+static struct intel_super *
+imsm_thunderdome(struct intel_super **super_list, int len)
+{
+       struct intel_super *super_table[len];
+       struct intel_disk *disk_list = NULL;
+       struct intel_super *champion, *spare;
+       struct intel_super *s, **del;
+       int tbl_size = 0;
+       int conflict;
+       int i;
+
+       memset(super_table, 0, sizeof(super_table));
+       for (s = *super_list; s; s = s->next)
+               tbl_size = __prep_thunderdome(super_table, tbl_size, s, &disk_list);
+
+       for (i = 0; i < tbl_size; i++) {
+               struct imsm_disk *d;
+               struct intel_disk *idisk;
+               struct imsm_super *mpb = super_table[i]->anchor;
+
+               s = super_table[i];
+               d = &s->disks->disk;
+
+               /* 'd' must appear in merged disk list for its
+                * configuration to be valid
+                */
+               idisk = disk_list_get(d->serial, disk_list);
+               if (idisk && idisk->owner == i)
+                       s = validate_members(s, disk_list, i);
+               else
+                       s = NULL;
+
+               if (!s)
+                       dprintf("%s: marking family: %#x from %d:%d offline\n",
+                               __func__, mpb->family_num,
+                               super_table[i]->disks->major,
+                               super_table[i]->disks->minor);
+               super_table[i] = s;
+       }
+
+       /* This is where the mdadm implementation differs from the Windows
+        * driver which has no strict concept of a container.  We can only
+        * assemble one family from a container, so when returning a prodigal
+        * array member to this system the code will not be able to disambiguate
+        * the container contents that should be assembled ("foreign" versus
+        * "local").  It requires user intervention to set the orig_family_num
+        * to a new value to establish a new container.  The Windows driver in
+        * this situation fixes up the volume name in place and manages the
+        * foreign array as an independent entity.
+        */
+       s = NULL;
+       spare = NULL;
+       conflict = 0;
+       for (i = 0; i < tbl_size; i++) {
+               struct intel_super *tbl_ent = super_table[i];
+               int is_spare = 0;
+
+               if (!tbl_ent)
+                       continue;
+
+               if (tbl_ent->anchor->num_raid_devs == 0) {
+                       spare = tbl_ent;
+                       is_spare = 1;
+               }
+
+               if (s && !is_spare) {
+                       show_conflicts(tbl_ent->anchor->family_num, *super_list);
+                       conflict++;
+               } else if (!s && !is_spare)
+                       s = tbl_ent;
+       }
+
+       if (!s)
+               s = spare;
+       if (!s) {
+               champion = NULL;
+               goto out;
+       }
+       champion = s;
+
+       if (conflict)
+               fprintf(stderr, "Chose family %#x on '%s', "
+                       "assemble conflicts to new container with '--update=uuid'\n",
+                       __le32_to_cpu(s->anchor->family_num), s->disks->devname);
+
+       /* collect all dl's onto 'champion', and update them to
+        * champion's version of the status
+        */
+       for (s = *super_list; s; s = s->next) {
+               struct imsm_super *mpb = champion->anchor;
+               struct dl *dl = s->disks;
+
+               if (s == champion)
+                       continue;
+
+               for (i = 0; i < mpb->num_disks; i++) {
+                       struct imsm_disk *disk;
+
+                       disk = __serial_to_disk(dl->serial, mpb, &dl->index);
+                       if (disk) {
+                               dl->disk = *disk;
+                               /* only set index on disks that are a member of
+                                * a populated contianer, i.e. one with
+                                * raid_devs
+                                */
+                               if (is_failed(&dl->disk))
+                                       dl->index = -2;
+                               else if (is_spare(&dl->disk))
+                                       dl->index = -1;
+                               break;
+                       }
+               }
+
+               if (i >= mpb->num_disks) {
+                       struct intel_disk *idisk;
+
+                       idisk = disk_list_get(dl->serial, disk_list);
+                       if (idisk && is_spare(&idisk->disk) &&
+                           !is_failed(&idisk->disk) && !is_configured(&idisk->disk))
+                               dl->index = -1;
+                       else {
+                               dl->index = -2;
+                               continue;
+                       }
+               }
+
+               dl->next = champion->disks;
+               champion->disks = dl;
+               s->disks = NULL;
+       }
+
+       /* delete 'champion' from super_list */
+       for (del = super_list; *del; ) {
+               if (*del == champion) {
+                       *del = (*del)->next;
+                       break;
+               } else
+                       del = &(*del)->next;
+       }
+       champion->next = NULL;
+
+ out:
+       while (disk_list) {
+               struct intel_disk *idisk = disk_list;
+
+               disk_list = disk_list->next;
+               free(idisk);
+       }
+
+       return champion;
+}
+
 static int load_super_imsm_all(struct supertype *st, int fd, void **sbp,
                               char *devname, int keep_fd)
 {
        struct mdinfo *sra;
-       struct intel_super *super;
-       struct mdinfo *sd, *best = NULL;
-       __u32 bestgen = 0;
-       __u32 gen;
-       char nm[20];
-       int dfd;
-       int rv;
+       struct intel_super *super_list = NULL;
+       struct intel_super *super = NULL;
        int devnum = fd2devnum(fd);
+       struct mdinfo *sd;
        int retry;
+       int err = 0;
+       int i;
        enum sysfs_read_flags flags;
 
        flags = GET_LEVEL|GET_VERSION|GET_DEVS|GET_STATE;
@@ -2087,93 +2492,78 @@ static int load_super_imsm_all(struct supertype *st, int fd, void **sbp,
            strcmp(sra->text_version, "imsm") != 0)
                return 1;
 
-       super = alloc_super(0);
-       if (!super)
-               return 1;
+       /* load all mpbs */
+       for (sd = sra->devs, i = 0; sd; sd = sd->next, i++) {
+               struct intel_super *s = alloc_super(0);
+               char nm[20];
+               int dfd;
+
+               err = 1;
+               if (!s)
+                       goto error;
+               s->next = super_list;
+               super_list = s;
 
-       /* find the most up to date disk in this array, skipping spares */
-       for (sd = sra->devs; sd; sd = sd->next) {
+               err = 2;
                sprintf(nm, "%d:%d", sd->disk.major, sd->disk.minor);
                dfd = dev_open(nm, keep_fd ? O_RDWR : O_RDONLY);
-               if (dfd < 0) {
-                       free_imsm(super);
-                       return 2;
-               }
-               rv = load_imsm_mpb(dfd, super, NULL);
+               if (dfd < 0)
+                       goto error;
+
+               err = load_and_parse_mpb(dfd, s, NULL, keep_fd);
 
                /* retry the load if we might have raced against mdmon */
-               if (rv == 3 && mdmon_running(devnum))
+               if (err == 3 && mdmon_running(devnum))
                        for (retry = 0; retry < 3; retry++) {
                                usleep(3000);
-                               rv = load_imsm_mpb(dfd, super, NULL);
-                               if (rv != 3)
+                               err = load_and_parse_mpb(dfd, s, NULL, keep_fd);
+                               if (err != 3)
                                        break;
                        }
                if (!keep_fd)
                        close(dfd);
-               if (rv == 0) {
-                       if (super->anchor->num_raid_devs == 0)
-                               gen = 0;
-                       else
-                               gen = __le32_to_cpu(super->anchor->generation_num);
-                       if (!best || gen > bestgen) {
-                               bestgen = gen;
-                               best = sd;
-                       }
-               } else {
-                       free_imsm(super);
-                       return rv;
-               }
+               if (err)
+                       goto error;
        }
 
-       if (!best) {
-               free_imsm(super);
-               return 1;
+       /* all mpbs enter, maybe one leaves */
+       super = imsm_thunderdome(&super_list, i);
+       if (!super) {
+               err = 1;
+               goto error;
        }
 
-       /* load the most up to date anchor */
-       sprintf(nm, "%d:%d", best->disk.major, best->disk.minor);
-       dfd = dev_open(nm, O_RDONLY);
-       if (dfd < 0) {
-               free_imsm(super);
-               return 1;
-       }
-       rv = load_imsm_mpb(dfd, super, NULL);
-       close(dfd);
-       if (rv != 0) {
+       if (find_missing(super) != 0) {
                free_imsm(super);
-               return 2;
+               err = 2;
+               goto error;
        }
 
-       /* re-parse the disk list with the current anchor */
-       for (sd = sra->devs ; sd ; sd = sd->next) {
-               sprintf(nm, "%d:%d", sd->disk.major, sd->disk.minor);
-               dfd = dev_open(nm, keep_fd? O_RDWR : O_RDONLY);
-               if (dfd < 0) {
+       if (st->subarray[0]) {
+               if (atoi(st->subarray) <= super->anchor->num_raid_devs)
+                       super->current_vol = atoi(st->subarray);
+               else {
                        free_imsm(super);
-                       return 2;
+                       err = 1;
+                       goto error;
                }
-               load_imsm_disk(dfd, super, NULL, keep_fd);
-               if (!keep_fd)
-                       close(dfd);
        }
+       err = 0;
 
+ error:
+       while (super_list) {
+               struct intel_super *s = super_list;
 
-       if (find_missing(super) != 0) {
-               free_imsm(super);
-               return 2;
+               super_list = super_list->next;
+               free_imsm(s);
        }
 
-       if (st->subarray[0]) {
-               if (atoi(st->subarray) <= super->anchor->num_raid_devs)
-                       super->current_vol = atoi(st->subarray);
-               else
-                       return 1;
-       }
+       if (err)
+               return err;
 
        *sbp = super;
        st->container_dev = devnum;
-       if (st->ss == NULL) {
+       if (err == 0 && st->ss == NULL) {
                st->ss = &super_imsm;
                st->minor_version = 0;
                st->max_devs = IMSM_MAX_DEVICES;
@@ -2193,8 +2583,8 @@ static int load_super_imsm(struct supertype *st, int fd, char *devname)
        if (load_super_imsm_all(st, fd, &st->sb, devname, 1) == 0)
                return 0;
 #endif
-       if (st->subarray[0])
-               return 1; /* FIXME */
+
+       free_super_imsm(st);
 
        super = alloc_super(0);
        if (!super) {
@@ -2204,7 +2594,7 @@ static int load_super_imsm(struct supertype *st, int fd, char *devname)
                return 1;
        }
 
-       rv = load_imsm_mpb(fd, super, devname);
+       rv = load_and_parse_mpb(fd, super, devname, 0);
 
        if (rv) {
                if (devname)
@@ -2215,6 +2605,15 @@ static int load_super_imsm(struct supertype *st, int fd, char *devname)
                return rv;
        }
 
+       if (st->subarray[0]) {
+               if (atoi(st->subarray) <= super->anchor->num_raid_devs)
+                       super->current_vol = atoi(st->subarray);
+               else {
+                       free_imsm(super);
+                       return 1;
+               }
+       }
+
        st->sb = super;
        if (st->ss == NULL) {
                st->ss = &super_imsm;
@@ -2404,13 +2803,16 @@ static int init_super_imsm_volume(struct supertype *st, mdu_array_info_t *info,
                                "in a raid1 volume\n");
                return 0;
        }
+
+       map->raid_level = info->level;
        if (info->level == 10) {
                map->raid_level = 1;
                map->num_domains = info->raid_disks / 2;
-       } else {
-               map->raid_level = info->level;
+       } else if (info->level == 1)
+               map->num_domains = info->raid_disks;
+       else
                map->num_domains = 1;
-       }
+
        num_data_stripes = info_to_num_data_stripes(info, map->num_domains);
        map->num_data_stripes = __cpu_to_le32(num_data_stripes);
 
@@ -2448,24 +2850,33 @@ static int init_super_imsm(struct supertype *st, mdu_array_info_t *info,
        size_t mpb_size;
        char *version;
 
-       if (!info) {
-               st->sb = NULL;
-               return 0;
-       }
        if (st->sb)
-               return init_super_imsm_volume(st, info, size, name, homehost,
-                                             uuid);
+               return init_super_imsm_volume(st, info, size, name, homehost, uuid);
+
+       if (info)
+               mpb_size = disks_to_mpb_size(info->nr_disks);
+       else
+               mpb_size = 512;
 
        super = alloc_super(1);
-       if (!super)
-               return 0;
-       mpb_size = disks_to_mpb_size(info->nr_disks);
-       if (posix_memalign(&super->buf, 512, mpb_size) != 0) {
+       if (super && posix_memalign(&super->buf, 512, mpb_size) != 0) {
                free(super);
+               super = NULL;
+       }
+       if (!super) {
+               fprintf(stderr, Name
+                       ": %s could not allocate superblock\n", __func__);
                return 0;
        }
+       memset(super->buf, 0, mpb_size);
        mpb = super->buf;
-       memset(mpb, 0, mpb_size); 
+       mpb->mpb_size = __cpu_to_le32(mpb_size);
+       st->sb = super;
+
+       if (info == NULL) {
+               /* zeroing superblock */
+               return 0;
+       }
 
        mpb->attributes = MPB_ATTRIB_CHECKSUM_VERIFY;
 
@@ -2473,9 +2884,7 @@ static int init_super_imsm(struct supertype *st, mdu_array_info_t *info,
        strcpy(version, MPB_SIGNATURE);
        version += strlen(MPB_SIGNATURE);
        strcpy(version, MPB_VERSION_RAID0);
-       mpb->mpb_size = mpb_size;
 
-       st->sb = super;
        return 1;
 }
 
@@ -2523,7 +2932,7 @@ static int add_to_super_imsm_volume(struct supertype *st, mdu_disk_info_t *dk,
                super->anchor->num_disks++;
        }
        set_imsm_ord_tbl_ent(map, dk->number, dl->index);
-       dl->disk.status = CONFIGURED_DISK | USABLE_DISK;
+       dl->disk.status = CONFIGURED_DISK;
 
        /* if we are creating the first raid device update the family number */
        if (super->current_vol == 0) {
@@ -2533,8 +2942,10 @@ static int add_to_super_imsm_volume(struct supertype *st, mdu_disk_info_t *dk,
 
                *_dev = *dev;
                *_disk = dl->disk;
-               sum = __gen_imsm_checksum(mpb);
+               sum = random32();
+               sum += __gen_imsm_checksum(mpb);
                mpb->family_num = __cpu_to_le32(sum);
+               mpb->orig_family_num = mpb->family_num;
        }
 
        return 0;
@@ -2589,7 +3000,7 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk,
        size /= 512;
        serialcpy(dd->disk.serial, dd->serial);
        dd->disk.total_blocks = __cpu_to_le32(size);
-       dd->disk.status = USABLE_DISK | SPARE_DISK;
+       dd->disk.status = SPARE_DISK;
        if (sysfs_disk_to_scsi_id(fd, &id) == 0)
                dd->disk.scsi_id = __cpu_to_le32(id);
        else
@@ -2606,38 +3017,48 @@ static int add_to_super_imsm(struct supertype *st, mdu_disk_info_t *dk,
        return 0;
 }
 
-static int store_imsm_mpb(int fd, struct intel_super *super);
+static int store_imsm_mpb(int fd, struct imsm_super *mpb);
+
+static union {
+       char buf[512];
+       struct imsm_super anchor;
+} spare_record __attribute__ ((aligned(512)));
 
 /* spare records have their own family number and do not have any defined raid
  * devices
  */
 static int write_super_imsm_spares(struct intel_super *super, int doclose)
 {
-       struct imsm_super mpb_save;
        struct imsm_super *mpb = super->anchor;
+       struct imsm_super *spare = &spare_record.anchor;
        __u32 sum;
        struct dl *d;
 
-       mpb_save = *mpb;
-       mpb->num_raid_devs = 0;
-       mpb->num_disks = 1;
-       mpb->mpb_size = sizeof(struct imsm_super);
-       mpb->generation_num = __cpu_to_le32(1UL);
+       spare->mpb_size = __cpu_to_le32(sizeof(struct imsm_super)),
+       spare->generation_num = __cpu_to_le32(1UL),
+       spare->attributes = MPB_ATTRIB_CHECKSUM_VERIFY;
+       spare->num_disks = 1,
+       spare->num_raid_devs = 0,
+       spare->cache_size = mpb->cache_size,
+       spare->pwr_cycle_count = __cpu_to_le32(1),
+
+       snprintf((char *) spare->sig, MAX_SIGNATURE_LENGTH,
+                MPB_SIGNATURE MPB_VERSION_RAID0);
 
        for (d = super->disks; d; d = d->next) {
                if (d->index != -1)
                        continue;
 
-               mpb->disk[0] = d->disk;
-               sum = __gen_imsm_checksum(mpb);
-               mpb->family_num = __cpu_to_le32(sum);
-               sum = __gen_imsm_checksum(mpb);
-               mpb->check_sum = __cpu_to_le32(sum);
+               spare->disk[0] = d->disk;
+               sum = __gen_imsm_checksum(spare);
+               spare->family_num = __cpu_to_le32(sum);
+               spare->orig_family_num = 0;
+               sum = __gen_imsm_checksum(spare);
+               spare->check_sum = __cpu_to_le32(sum);
 
-               if (store_imsm_mpb(d->fd, super)) {
+               if (store_imsm_mpb(d->fd, spare)) {
                        fprintf(stderr, "%s: failed for device %d:%d %s\n",
                                __func__, d->major, d->minor, strerror(errno));
-                       *mpb = mpb_save;
                        return 1;
                }
                if (doclose) {
@@ -2646,7 +3067,6 @@ static int write_super_imsm_spares(struct intel_super *super, int doclose)
                }
        }
 
-       *mpb = mpb_save;
        return 0;
 }
 
@@ -2665,6 +3085,12 @@ static int write_super_imsm(struct intel_super *super, int doclose)
        generation++;
        mpb->generation_num = __cpu_to_le32(generation);
 
+       /* fix up cases where previous mdadm releases failed to set
+        * orig_family_num
+        */
+       if (mpb->orig_family_num == 0)
+               mpb->orig_family_num = mpb->family_num;
+
        mpb_size += sizeof(struct imsm_disk) * mpb->num_disks;
        for (d = super->disks; d; d = d->next) {
                if (d->index == -1)
@@ -2692,7 +3118,7 @@ static int write_super_imsm(struct intel_super *super, int doclose)
        for (d = super->disks; d ; d = d->next) {
                if (d->index < 0)
                        continue;
-               if (store_imsm_mpb(d->fd, super))
+               if (store_imsm_mpb(d->fd, mpb))
                        fprintf(stderr, "%s: failed for device %d:%d %s\n",
                                __func__, d->major, d->minor, strerror(errno));
                if (doclose) {
@@ -2708,17 +3134,16 @@ static int write_super_imsm(struct intel_super *super, int doclose)
 }
 
 
-static int create_array(struct supertype *st)
+static int create_array(struct supertype *st, int dev_idx)
 {
        size_t len;
        struct imsm_update_create_array *u;
        struct intel_super *super = st->sb;
-       struct imsm_dev *dev = get_imsm_dev(super, super->current_vol);
+       struct imsm_dev *dev = get_imsm_dev(super, dev_idx);
        struct imsm_map *map = get_imsm_map(dev, 0);
        struct disk_info *inf;
        struct imsm_disk *disk;
        int i;
-       int idx;
 
        len = sizeof(*u) - sizeof(*dev) + sizeof_imsm_dev(dev, 0) +
              sizeof(*inf) * map->num_members;
@@ -2730,11 +3155,12 @@ static int create_array(struct supertype *st)
        }
 
        u->type = update_create_array;
-       u->dev_idx = super->current_vol;
+       u->dev_idx = dev_idx;
        imsm_copy_dev(&u->dev, dev);
        inf = get_disk_info(u);
        for (i = 0; i < map->num_members; i++) {
-               idx = get_imsm_disk_idx(dev, i);
+               int idx = get_imsm_disk_idx(dev, i);
+
                disk = get_imsm_disk(super, idx);
                serialcpy(inf[i].serial, disk->serial);
        }
@@ -2768,21 +3194,26 @@ static int _add_disk(struct supertype *st)
 
 static int write_init_super_imsm(struct supertype *st)
 {
+       struct intel_super *super = st->sb;
+       int current_vol = super->current_vol;
+
+       /* we are done with current_vol reset it to point st at the container */
+       super->current_vol = -1;
+
        if (st->update_tail) {
                /* queue the recently created array / added disk
                 * as a metadata update */
-               struct intel_super *super = st->sb;
                struct dl *d;
                int rv;
 
                /* determine if we are creating a volume or adding a disk */
-               if (super->current_vol < 0) {
+               if (current_vol < 0) {
                        /* in the add disk case we are running in mdmon
                         * context, so don't close fd's
                         */
                        return _add_disk(st);
                } else
-                       rv = create_array(st);
+                       rv = create_array(st, current_vol);
 
                for (d = super->disks; d ; d = d->next) {
                        close(d->fd);
@@ -2795,24 +3226,19 @@ static int write_init_super_imsm(struct supertype *st)
 }
 #endif
 
-static int store_zero_imsm(struct supertype *st, int fd)
+static int store_super_imsm(struct supertype *st, int fd)
 {
-       unsigned long long dsize;
-       void *buf;
-
-       get_dev_size(fd, NULL, &dsize);
-
-       /* first block is stored on second to last sector of the disk */
-       if (lseek64(fd, dsize - (512 * 2), SEEK_SET) < 0)
-               return 1;
+       struct intel_super *super = st->sb;
+       struct imsm_super *mpb = super ? super->anchor : NULL;
 
-       if (posix_memalign(&buf, 512, 512) != 0)
+       if (!mpb)
                return 1;
 
-       memset(buf, 0, 512);
-       if (write(fd, buf, 512) != 512)
-               return 1;
-       return 0;
+#ifndef MDASSEMBLE
+       return store_imsm_mpb(fd, mpb);
+#else
+       return 1;
+#endif
 }
 
 static int imsm_bbm_log_size(struct imsm_super *mpb)
@@ -2909,7 +3335,7 @@ static unsigned long long merge_extents(struct intel_super *super, int sum_exten
        unsigned long reserve;
 
        if (!e)
-               return ~0ULL; /* error */
+               return 0;
 
        /* coalesce and sort all extents. also, check to see if we need to
         * reserve space between member arrays
@@ -2952,17 +3378,23 @@ static unsigned long long merge_extents(struct intel_super *super, int sum_exten
        } while (e[i-1].size);
        free(e);
 
+       if (maxsize == 0)
+               return 0;
+
+       /* FIXME assumes volume at offset 0 is the first volume in a
+        * container
+        */
        if (start_extent > 0)
                reserve = IMSM_RESERVED_SECTORS; /* gap between raid regions */
        else
                reserve = 0;
 
        if (maxsize < reserve)
-               return ~0ULL;
+               return 0;
 
        super->create_offset = ~((__u32) 0);
        if (start + reserve > super->create_offset)
-               return ~0ULL; /* start overflows create_offset */
+               return 0; /* start overflows create_offset */
        super->create_offset = start + reserve;
 
        return maxsize - reserve;
@@ -2991,6 +3423,34 @@ static int is_raid_level_supported(const struct imsm_orom *orom, int level, int
 }
 
 #define pr_vrb(fmt, arg...) (void) (verbose && fprintf(stderr, Name fmt, ##arg))
+static int
+validate_geometry_imsm_orom(struct intel_super *super, int level, int layout,
+                           int raiddisks, int chunk, int verbose)
+{
+       if (!is_raid_level_supported(super->orom, level, raiddisks)) {
+               pr_vrb(": platform does not support raid%d with %d disk%s\n",
+                       level, raiddisks, raiddisks > 1 ? "s" : "");
+               return 0;
+       }
+       if (super->orom && level != 1 &&
+           !imsm_orom_has_chunk(super->orom, chunk)) {
+               pr_vrb(": platform does not support a chunk size of: %d\n", chunk);
+               return 0;
+       }
+       if (layout != imsm_level_to_layout(level)) {
+               if (level == 5)
+                       pr_vrb(": imsm raid 5 only supports the left-asymmetric layout\n");
+               else if (level == 10)
+                       pr_vrb(": imsm raid 10 only supports the n2 layout\n");
+               else
+                       pr_vrb(": imsm unknown layout %#x for this raid level %d\n",
+                               layout, level);
+               return 0;
+       }
+
+       return 1;
+}
+
 /* validate_geometry_imsm_volume - lifted from validate_geometry_ddf_bvd 
  * FIX ME add ahci details
  */
@@ -3013,26 +3473,8 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
        if (!super)
                return 0;
 
-       if (!is_raid_level_supported(super->orom, level, raiddisks)) {
-               pr_vrb(": platform does not support raid%d with %d disk%s\n",
-                       level, raiddisks, raiddisks > 1 ? "s" : "");
-               return 0;
-       }
-       if (super->orom && level != 1 &&
-           !imsm_orom_has_chunk(super->orom, chunk)) {
-               pr_vrb(": platform does not support a chunk size of: %d\n", chunk);
-               return 0;
-       }
-       if (layout != imsm_level_to_layout(level)) {
-               if (level == 5)
-                       pr_vrb(": imsm raid 5 only supports the left-asymmetric layout\n");
-               else if (level == 10)
-                       pr_vrb(": imsm raid 10 only supports the n2 layout\n");
-               else
-                       pr_vrb(": imsm unknown layout %#x for this raid level %d\n",
-                               layout, level);
+       if (!validate_geometry_imsm_orom(super, level, layout, raiddisks, chunk, verbose))
                return 0;
-       }
 
        if (!dev) {
                /* General test:  make sure there is space for
@@ -3040,7 +3482,7 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
                 * offset
                 */
                unsigned long long minsize = size;
-               unsigned long long start_offset = ~0ULL;
+               unsigned long long start_offset = MaxSector;
                int dcnt = 0;
                if (minsize == 0)
                        minsize = MPB_SECTOR_CNT + IMSM_RESERVED_SECTORS;
@@ -3056,7 +3498,7 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
                                esize = e[i].start - pos;
                                if (esize >= minsize)
                                        found = 1;
-                               if (found && start_offset == ~0ULL) {
+                               if (found && start_offset == MaxSector) {
                                        start_offset = pos;
                                        break;
                                } else if (found && pos != start_offset) {
@@ -3145,15 +3587,11 @@ static int validate_geometry_imsm_volume(struct supertype *st, int level,
                        i += dl->extent_cnt;
 
        maxsize = merge_extents(super, i);
-       if (maxsize < size) {
+       if (maxsize < size || maxsize == 0) {
                if (verbose)
                        fprintf(stderr, Name ": not enough space after merge (%llu < %llu)\n",
                                maxsize, size);
                return 0;
-       } else if (maxsize == ~0ULL) {
-               if (verbose)
-                       fprintf(stderr, Name ": failed to merge %d extents\n", i);
-               return 0;
        }
 
        *freesize = maxsize;
@@ -3210,7 +3648,8 @@ static int reserve_space(struct supertype *st, int raiddisks,
 
        if (cnt < raiddisks ||
            (super->orom && used && used != raiddisks) ||
-           maxsize < minsize) {
+           maxsize < minsize ||
+           maxsize == 0) {
                fprintf(stderr, Name ": not enough devices with space to create array.\n");
                return 0; /* No enough free spaces large enough */
        }
@@ -3262,6 +3701,10 @@ static int validate_geometry_imsm(struct supertype *st, int level, int layout,
                         * created.  add_to_super and getinfo_super
                         * detect when autolayout is in progress.
                         */
+                       if (!validate_geometry_imsm_orom(st->sb, level, layout,
+                                                        raiddisks, chunk,
+                                                        verbose))
+                               return 0;
                        return reserve_space(st, raiddisks, size, chunk, freesize);
                }
                return 1;
@@ -3280,8 +3723,11 @@ static int validate_geometry_imsm(struct supertype *st, int level, int layout,
                case 1:
                case 10:
                case 5:
-                       break;
+                       return 0;
                default:
+                       if (verbose)
+                               fprintf(stderr, Name
+                                       ": IMSM only supports levels 0,1,5,10\n");
                        return 1;
                }
 
@@ -3387,7 +3833,6 @@ static struct mdinfo *container_content_imsm(struct supertype *st)
                        struct dl *d;
                        int idx;
                        int skip;
-                       __u32 s;
                        __u32 ord;
 
                        skip = 0;
@@ -3399,11 +3844,7 @@ static struct mdinfo *container_content_imsm(struct supertype *st)
 
                        if (d == NULL)
                                skip = 1;
-
-                       s = d ? d->disk.status : 0;
-                       if (s & FAILED_DISK)
-                               skip = 1;
-                       if (!(s & USABLE_DISK))
+                       if (d && is_failed(&d->disk))
                                skip = 1;
                        if (ord & IMSM_ORD_REBUILD)
                                skip = 1;
@@ -3415,7 +3856,7 @@ static struct mdinfo *container_content_imsm(struct supertype *st)
                         * FIXME handle dirty degraded
                         */
                        if (skip && !dev->vol.dirty)
-                               this->resync_start = ~0ULL;
+                               this->resync_start = MaxSector;
                        if (skip)
                                continue;
 
@@ -3435,6 +3876,7 @@ static struct mdinfo *container_content_imsm(struct supertype *st)
                        info_d->disk.major = d->major;
                        info_d->disk.minor = d->minor;
                        info_d->disk.raid_disk = slot;
+                       info_d->recovery_start = MaxSector;
 
                        this->array.working_disks++;
 
@@ -3510,8 +3952,7 @@ static __u8 imsm_check_degraded(struct intel_super *super, struct imsm_dev *dev,
                                insync = 2;
 
                        disk = get_imsm_disk(super, idx);
-                       if (!disk || disk->status & FAILED_DISK ||
-                           ord & IMSM_ORD_REBUILD)
+                       if (!disk || is_failed(disk) || ord & IMSM_ORD_REBUILD)
                                insync--;
 
                        /* no in-sync disks left in this mirror the
@@ -3561,8 +4002,7 @@ static int imsm_count_failed(struct intel_super *super, struct imsm_dev *dev)
                idx = ord_to_idx(ord);
 
                disk = get_imsm_disk(super, idx);
-               if (!disk || disk->status & FAILED_DISK ||
-                   ord & IMSM_ORD_REBUILD)
+               if (!disk || is_failed(disk) || ord & IMSM_ORD_REBUILD)
                        failed++;
        }
 
@@ -3621,12 +4061,13 @@ static int mark_failure(struct imsm_dev *dev, struct imsm_disk *disk, int idx)
                return 0;
 
        ord = __le32_to_cpu(map->disk_ord_tbl[slot]);
-       if ((disk->status & FAILED_DISK) && (ord & IMSM_ORD_REBUILD))
+       if (is_failed(disk) && (ord & IMSM_ORD_REBUILD))
                return 0;
 
        disk->status |= FAILED_DISK;
+       disk->status &= ~CONFIGURED_DISK;
        set_imsm_ord_tbl_ent(map, slot, idx | IMSM_ORD_REBUILD);
-       if (map->failed_disk_num == ~0)
+       if (~map->failed_disk_num == 0)
                map->failed_disk_num = slot;
        return 1;
 }
@@ -3668,12 +4109,12 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
        }
                
        if (consistent == 2 &&
-           (!is_resync_complete(a) ||
+           (!is_resync_complete(&a->info) ||
             map_state != IMSM_T_STATE_NORMAL ||
             dev->vol.migr_state))
                consistent = 0;
 
-       if (is_resync_complete(a)) {
+       if (is_resync_complete(&a->info)) {
                /* complete intialization / resync,
                 * recovery and interrupted recovery is completed in
                 * ->set_disk
@@ -3685,7 +4126,7 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
                }
        } else if (!is_resyncing(dev) && !failed) {
                /* mark the start of the init process if nothing is failed */
-               dprintf("imsm: mark resync start (%llu)\n", a->resync_start);
+               dprintf("imsm: mark resync start\n");
                if (map->map_state == IMSM_T_STATE_UNINITIALIZED)
                        migrate(dev, IMSM_T_STATE_NORMAL, MIGR_INIT);
                else
@@ -3697,8 +4138,7 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
 
        /* mark dirty / clean */
        if (dev->vol.dirty != !consistent) {
-               dprintf("imsm: mark '%s' (%llu)\n",
-                       consistent ? "clean" : "dirty", a->resync_start);
+               dprintf("imsm: mark '%s'\n", consistent ? "clean" : "dirty");
                if (consistent)
                        dev->vol.dirty = 0;
                else
@@ -3768,9 +4208,9 @@ static void imsm_set_disk(struct active_array *a, int n, int state)
        }
 }
 
-static int store_imsm_mpb(int fd, struct intel_super *super)
+static int store_imsm_mpb(int fd, struct imsm_super *mpb)
 {
-       struct imsm_super *mpb = super->anchor;
+       void *buf = mpb;
        __u32 mpb_size = __le32_to_cpu(mpb->mpb_size);
        unsigned long long dsize;
        unsigned long long sectors;
@@ -3785,7 +4225,7 @@ static int store_imsm_mpb(int fd, struct intel_super *super)
                if (lseek64(fd, dsize - (512 * (2 + sectors)), SEEK_SET) < 0)
                        return 1;
 
-               if (write(fd, super->buf + 512, 512 * sectors) != 512 * sectors)
+               if (write(fd, buf + 512, 512 * sectors) != 512 * sectors)
                        return 1;
        }
 
@@ -3793,7 +4233,7 @@ static int store_imsm_mpb(int fd, struct intel_super *super)
        if (lseek64(fd, dsize - (512 * 2), SEEK_SET) < 0)
                return 1;
 
-       if (write(fd, super->buf, 512) != 512)
+       if (write(fd, buf, 512) != 512)
                return 1;
 
        return 0;
@@ -3821,7 +4261,7 @@ static struct dl *imsm_readd(struct intel_super *super, int idx, struct active_a
                if (dl->index == i)
                        break;
 
-       if (dl && dl->disk.status & FAILED_DISK)
+       if (dl && is_failed(&dl->disk))
                dl = NULL;
 
        if (dl)
@@ -3837,14 +4277,13 @@ static struct dl *imsm_add_spare(struct intel_super *super, int slot,
        int idx = get_imsm_disk_idx(dev, slot);
        struct imsm_super *mpb = super->anchor;
        struct imsm_map *map;
-       unsigned long long esize;
        unsigned long long pos;
        struct mdinfo *d;
        struct extent *ex;
        int i, j;
        int found;
        __u32 array_start;
-       __u32 blocks;
+       __u32 array_end;
        struct dl *dl;
 
        for (dl = super->disks; dl; dl = dl->next) {
@@ -3860,11 +4299,10 @@ static struct dl *imsm_add_spare(struct intel_super *super, int slot,
                        continue;
 
                /* skip in use or failed drives */
-               if (dl->disk.status & FAILED_DISK || idx == dl->index ||
+               if (is_failed(&dl->disk) || idx == dl->index ||
                    dl->index == -2) {
                        dprintf("%x:%x status (failed: %d index: %d)\n",
-                               dl->major, dl->minor,
-                               (dl->disk.status & FAILED_DISK) == FAILED_DISK, idx);
+                               dl->major, dl->minor, is_failed(&dl->disk), idx);
                        continue;
                }
 
@@ -3896,15 +4334,14 @@ static struct dl *imsm_add_spare(struct intel_super *super, int slot,
                        j = 0;
                        pos = 0;
                        array_start = __le32_to_cpu(map->pba_of_lba0);
-                       blocks = __le32_to_cpu(map->blocks_per_member);
+                       array_end = array_start +
+                                   __le32_to_cpu(map->blocks_per_member) - 1;
 
                        do {
                                /* check that we can start at pba_of_lba0 with
                                 * blocks_per_member of space
                                 */
-                               esize = ex[j].start - pos;
-                               if (array_start >= pos &&
-                                   array_start + blocks < ex[j].start) {
+                               if (array_start >= pos && array_end < ex[j].start) {
                                        found = 1;
                                        break;
                                }
@@ -3918,9 +4355,8 @@ static struct dl *imsm_add_spare(struct intel_super *super, int slot,
 
                free(ex);
                if (i < mpb->num_raid_devs) {
-                       dprintf("%x:%x does not have %u at %u\n",
-                               dl->major, dl->minor,
-                               blocks, array_start);
+                       dprintf("%x:%x does not have %u to %u available\n",
+                               dl->major, dl->minor, array_start, array_end);
                        /* No room */
                        continue;
                }
@@ -4019,9 +4455,11 @@ static struct mdinfo *imsm_activate_spare(struct active_array *a,
                di->disk.major = dl->major;
                di->disk.minor = dl->minor;
                di->disk.state = 0;
+               di->recovery_start = 0;
                di->data_offset = __le32_to_cpu(map->pba_of_lba0);
                di->component_size = a->info.component_size;
                di->container_member = inst;
+               super->random = random32();
                di->next = rv;
                rv = di;
                num_spares++;
@@ -4167,7 +4605,7 @@ static void imsm_process_update(struct supertype *st,
                        if (i == u->slot)
                                continue;
                        disk = get_imsm_disk(super, get_imsm_disk_idx(dev, i));
-                       if (!disk || disk->status & FAILED_DISK)
+                       if (!disk || is_failed(disk))
                                failed++;
                }
 
@@ -4188,6 +4626,15 @@ static void imsm_process_update(struct supertype *st,
                set_imsm_ord_tbl_ent(map, u->slot, dl->index);
                set_imsm_ord_tbl_ent(migr_map, u->slot, dl->index | IMSM_ORD_REBUILD);
 
+               /* update the family_num to mark a new container
+                * generation, being careful to record the existing
+                * family_num in orig_family_num to clean up after
+                * earlier mdadm versions that neglected to set it.
+                */
+               if (mpb->orig_family_num == 0)
+                       mpb->orig_family_num = mpb->family_num;
+               mpb->family_num += super->random;
+
                /* count arrays using the victim in the metadata */
                found = 0;
                for (a = st->arrays; a ; a = a->next) {
@@ -4501,6 +4948,7 @@ struct superswitch super_imsm = {
 #ifndef        MDASSEMBLE
        .examine_super  = examine_super_imsm,
        .brief_examine_super = brief_examine_super_imsm,
+       .brief_examine_subarrays = brief_examine_subarrays_imsm,
        .export_examine_super = export_examine_super_imsm,
        .detail_super   = detail_super_imsm,
        .brief_detail_super = brief_detail_super_imsm,
@@ -4520,7 +4968,7 @@ struct superswitch super_imsm = {
 
        .load_super     = load_super_imsm,
        .init_super     = init_super_imsm,
-       .store_super    = store_zero_imsm,
+       .store_super    = store_super_imsm,
        .free_super     = free_super_imsm,
        .match_metadata_desc = match_metadata_desc_imsm,
        .container_content = container_content_imsm,