if (n <0 || n >= 1024)
return -1;
buf[n] = 0;
- if (buf[n-1] == '\n')
+ if (n && buf[n-1] == '\n')
buf[n-1] = 0;
return 0;
}
int sysfs_open(int devnum, char *devname, char *attr)
{
char fname[50];
- char sys_name[16];
int fd;
- if (devnum >= 0)
- sprintf(sys_name, "md%d", devnum);
- else
- sprintf(sys_name, "md_d%d",
- -1-devnum);
- sprintf(fname, "/sys/block/%s/md/", sys_name);
+ sprintf(fname, "/sys/block/%s/md/", devnum2devname(devnum));
if (devname) {
strcat(fname, devname);
strcat(fname, "/");
memset(nm, 0, sizeof(nm));
sprintf(dv, "/sys/dev/block/%d:%d", sd->disk.major, sd->disk.minor);
- if (readlink(dv, nm, sizeof(nm)) < 0)
+ rv = readlink(dv, nm, sizeof(nm));
+ if (rv <= 0)
return -1;
+ nm[rv] = '\0';
dname = strrchr(nm, '/');
if (dname) dname++;
strcpy(sd->sys_name, "dev-");
strcpy(sd->sys_name+4, dname);
- rv |= sysfs_set_num(sra, sd, "offset", sd->data_offset);
+ rv = sysfs_set_num(sra, sd, "offset", sd->data_offset);
rv |= sysfs_set_num(sra, sd, "size", (sd->component_size+1) / 2);
if (sra->array.level != LEVEL_CONTAINER) {
rv |= sysfs_set_num(sra, sd, "slot", sd->disk.raid_disk);