]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Grow: Fix wrong 'goto' in set_new_data_offset
authorPawel Baldysiak <pawel.baldysiak@intel.com>
Thu, 27 Nov 2014 11:35:24 +0000 (12:35 +0100)
committerNeilBrown <neilb@suse.de>
Mon, 1 Dec 2014 22:52:34 +0000 (09:52 +1100)
Commit a821c95f114724b38df1ea99b2858178e0ed28ce
besides introducing additional message, also changed
direct return to "goto" instruction.
'goto release' will cause routine to return with '-1',
when previously '1' was returned.
Described behaviour breaks e.g. IMSM reshape process.
This patch fixes this issue by changing 'goto' to proper one -
the one that returns '1'.

Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Grow.c

diff --git a/Grow.c b/Grow.c
index a0f7526e93f588540be311d2290ac1ac7c051efc..6ff225a95b1be081c5e4948b662dacc3d590cce4 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -2257,7 +2257,7 @@ static int set_new_data_offset(struct mdinfo *sra, struct supertype *st,
                        /* Metadata doesn't support data_offset changes */
                        pr_err("%s: Metadata version doesn't support"
                               " data_offset changes\n", devname);
-                       goto release;
+                       goto fallback;
                }
                if (before > info2.space_before)
                        before = info2.space_before;