]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
mdadm: output info more precisely when change bitmap to none
authorGuoqing Jiang <gqjiang@suse.com>
Tue, 1 Dec 2015 16:30:10 +0000 (00:30 +0800)
committerNeilBrown <neilb@suse.com>
Wed, 16 Dec 2015 02:23:58 +0000 (13:23 +1100)
WHen change bitmap to none, the infos could be more accurate
based on existed bitmap type.

And s->bitmap_file is passed from cmd "--bitmap=TYPE", so
remove s->bitmap_file from err info since it should means
change the bitmap to one type failed rather than the type is
already presented.

Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Grow.c

diff --git a/Grow.c b/Grow.c
index ee48c3613cac0baf98fb5f2a4de6da5e46b9f112..6dfb9c9cf11a1f97d8507e38cbf7b9a7d1edd20f 100755 (executable)
--- a/Grow.c
+++ b/Grow.c
@@ -328,12 +328,15 @@ int Grow_addbitmap(char *devname, int fd, struct context *c, struct shape *s)
                if (strcmp(s->bitmap_file, "none")==0) {
                        array.state &= ~(1<<MD_SB_BITMAP_PRESENT);
                        if (ioctl(fd, SET_ARRAY_INFO, &array)!= 0) {
-                               pr_err("failed to remove internal bitmap.\n");
+                               if (array.state & (1<<MD_SB_CLUSTERED))
+                                       pr_err("failed to remove clustered bitmap.\n");
+                               else
+                                       pr_err("failed to remove internal bitmap.\n");
                                return 1;
                        }
                        return 0;
                }
-               pr_err("%s bitmap already present on %s\n", s->bitmap_file, devname);
+               pr_err("bitmap already present on %s\n", devname);
                return 1;
        }