]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
main: remove use of uninitialized 'rv'.
authorNeilBrown <neilb@suse.com>
Wed, 5 Aug 2015 04:53:33 +0000 (14:53 +1000)
committerNeilBrown <neilb@suse.com>
Wed, 5 Aug 2015 04:53:33 +0000 (14:53 +1000)
If c.homecluster was not NULL, might get an
error anyway.

Signed-off-by: NeilBrown <neilb@suse.com>
mdadm.c

diff --git a/mdadm.c b/mdadm.c
index dcb49d0abffb27c0749a5cd63636f6cfed2e193e..5d5a1b886750497e0bded1d4f139d8e994463645 100644 (file)
--- a/mdadm.c
+++ b/mdadm.c
@@ -1293,11 +1293,12 @@ int main(int argc, char *argv[])
                c.require_homehost = 0;
        }
 
+       rv = 0;
        if (c.homecluster == NULL && (c.nodes > 0)) {
                c.homecluster = conf_get_homecluster();
                if (c.homecluster == NULL)
                        rv = get_cluster_name(&c.homecluster);
-               if (rv != 0) {
+               if (rv) {
                        pr_err("The md can't get cluster name\n");
                        exit(1);
                }
@@ -1322,7 +1323,6 @@ int main(int argc, char *argv[])
                /* --scan implied --brief unless -vv */
                c.brief = 1;
 
-       rv = 0;
        switch(mode) {
        case MANAGE:
                /* readonly, add/remove, readwrite, runstop */