]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
mdadm/grow: Component size must be larger than chunk size
authorZhilong Liu <zlliu@suse.com>
Tue, 5 Sep 2017 09:41:36 +0000 (17:41 +0800)
committerJes Sorensen <jsorensen@fb.com>
Mon, 2 Oct 2017 19:59:24 +0000 (15:59 -0400)
Grow: Changing component size must be larger than current
chunk size against stripe raids, otherwise Grow_reshape()
would set s->size to '0'.

Signed-off-by: Zhilong Liu <zlliu@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
Grow.c

diff --git a/Grow.c b/Grow.c
index 267b06f749f6d26b4aaf967ffa25d41bca052f2e..bab1eec1f705d30ccff4ead0d4f1e0e83d8384ef 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -1816,6 +1816,12 @@ int Grow_reshape(char *devname, int fd,
                return 1;
        }
 
+       if (array.level > 1 &&
+          (array.chunk_size / 1024) > (int)s->size) {
+               pr_err("component size must be larger than chunk size.\n");
+               return 1;
+       }
+
        st = super_by_fd(fd, &subarray);
        if (!st) {
                pr_err("Unable to determine metadata format for %s\n", devname);