Assemble(): don't dup_super() before we need it.

Avoid resource leak in case we bail loop early

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/Assemble.c b/Assemble.c
index 05710f5364ccdac286d6d4fa8dc7dbbb73d85bd8..3c8e74dcaff978f205e0c41b40c09b0ecb019178 100644 (file)
--- a/Assemble.c
+++ b/Assemble.c
@@ -293,7 +293,7 @@ int Assemble(struct supertype *st, char *mddev,
                char *devname = tmpdev->devname;
                int dfd;
                struct stat stb;
-               struct supertype *tst = dup_super(st);
+               struct supertype *tst;
                struct dev_policy *pol = NULL;
                int found_container = 0;
 
@@ -306,6 +306,8 @@ int Assemble(struct supertype *st, char *mddev,
                        continue;
                }
 
+               tst = dup_super(st);
+
                dfd = dev_open(devname, O_RDONLY|O_EXCL);
                if (dfd < 0) {
                        if (report_missmatch)