FIX: Seg Fault in incremental if BBM log detected

Bug  detected for imsm metadata.
Assembling of array using Incremental switch generate segmentation
fault if BBM log is detected.
Reason: missing return from Incremental_container if BBM is detected
and unnecessary list=NULL assignment.
This patch fix the problem and memory leak in this area.

Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/Incremental.c b/Incremental.c
index 889184fe8e8ebd5bc29efd9bd96ff634bfca97e0..4c4b0c7ec21ce66d2d29e159de991352de6136c7 100644 (file)
--- a/Incremental.c
+++ b/Incremental.c
@@ -1471,7 +1471,9 @@ static int Incremental_container(struct supertype *st, char *devname,
        if (list->array.state & (1<<MD_SB_BBM_ERRORS)) {
                fprintf(stderr, Name ": BBM log found in metadata. "
                                        "Cannot activate array(s).\n");
-               list = NULL;
+               /* free container data and exit */
+               sysfs_free(list);
+               return 2;
        }
 
        for (ra = list ; ra ; ra = ra->next) {