]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
fix: memory leak in Create
authorCzarnowska, Anna <anna.czarnowska@intel.com>
Thu, 17 Feb 2011 22:46:00 +0000 (22:46 +0000)
committerNeilBrown <neilb@suse.de>
Mon, 21 Feb 2011 05:44:20 +0000 (16:44 +1100)
match_metadata_desc allocates memory for st
which is not needed after validate_geometry fails

Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Create.c

index a0669fe0075dfdd013d99c6bc03ae11ca78a7c39..ccda07b8db028bb4fe1ab94ed8e33e1d2cbace00 100644 (file)
--- a/Create.c
+++ b/Create.c
@@ -309,8 +309,10 @@ int Create(struct supertype *st, char *mddev,
                                if (st && !st->ss->validate_geometry
                                                (st, level, layout, raiddisks,
                                                 chunk, size*2, dname, &freesize,
-                                                verbose > 0))
+                                                verbose > 0)) {
+                                       free(st);
                                        st = NULL;
+                               }
                        }
 
                        if (!st) {