]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
tests: save failure logs to logdir
authorNeilBrown <neilb@suse.de>
Fri, 10 Jul 2015 04:44:58 +0000 (14:44 +1000)
committerNeilBrown <neilb@suse.de>
Fri, 10 Jul 2015 04:44:58 +0000 (14:44 +1000)
If --save-logs is given we already save all logs to --logdir
If not, we should still save erroneous logs to --logdir.

Signed-off-by: NeilBrown <neilb@suse.com>
test

diff --git a/test b/test
index d268433eb73db166b6af634ce12ac6e472b2e961..342177afdd0d09ea1d030bec98ff4fb192c4a69e 100755 (executable)
--- a/test
+++ b/test
@@ -308,9 +308,9 @@ do_test() {
       dmesg | tail -n 200 >> $targetdir/log
       if [ $exitonerror == 0 ]; then
          log=log-`basename $_script`
-         mv $targetdir/log $targetdir/$log
+         mv $targetdir/log $logdir/$log
       fi
-      echo "FAILED - see $targetdir/$log for details"
+      echo "FAILED - see $logdir/$log for details"
       _fail=1
     fi
     if [ "$savelogs" == "1" ]; then
@@ -362,12 +362,6 @@ parse_args() {
       ;;
     --save-logs)
       savelogs=1
-      if [ ! -d $logdir ] ; then
-        mkdir $logdir
-        if [ $? -ne 0 ] ; then
-         exit 1;
-       fi
-      fi
       ;;
     --keep-going | --no-error)
       exitonerror=0
@@ -403,9 +397,11 @@ parse_args() {
 done
 }
 
+logdir=$targetdir
 parse_args $@
 
 do_setup
+mkdir -p $logdir
 
 if [ "$savelogs" == "1" ]; then
   echo "Saving logs to $logdir"