DDF: ddf_activate_spare: only activate good drives

Do not try to activate drives marked missing or failed.

Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/super-ddf.c b/super-ddf.c
index 13a2e61a84105e6c3c6abcbf8691d900b5abc0ee..ae1222c4ad9a8aa58b448ce80e1378c3df1a357e 100644 (file)
--- a/super-ddf.c
+++ b/super-ddf.c
@@ -4773,6 +4773,13 @@ static struct mdinfo *ddf_activate_spare(struct active_array *a,
        /* For each slot, if it is not working, find a spare */
        dl = ddf->dlist;
        for (i = 0; i < a->info.array.raid_disks; i++) {
+               be16 state = ddf->phys->entries[dl->pdnum].state;
+               if (be16_and(state,
+                            cpu_to_be16(DDF_Failed|DDF_Missing)) ||
+                   !be16_and(state,
+                             cpu_to_be16(DDF_Online)))
+                       continue;
+
                for (d = a->info.devs ; d ; d = d->next)
                        if (d->disk.raid_disk == i)
                                break;