]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
Monitor: don't set arrays dirty after transition to read-only
authormwilck@arcor.de <mwilck@arcor.de>
Sat, 14 Sep 2013 21:24:07 +0000 (23:24 +0200)
committerNeilBrown <neilb@suse.de>
Wed, 16 Oct 2013 04:29:43 +0000 (15:29 +1100)
This patch reverts commit 4867e068. Setting arrays dirty after
transition from inactive to anything else causes unnecessary
meta data writes and may wreak trouble unnecessarily when
a disk was missing during assembly but the array was never
written to.

The reason for 4867e068 was a special situation during reshape
from RAID0 to RAID4. I ran all IMSM test cases with it reverted
and found no regressions, so I believe the reshape logic for
IMSM works fine in mdadm 3.3 also without this.

Signed-off-by: Martin Wilck <mwilck@arcor.de>
Signed-off-by: NeilBrown <neilb@suse.de>
monitor.c

index 742aa196fb3b2214a89a15ccb9124b832e2c587d..3b57ed05ec9b801a8c3ef97c2f3f3d0bd93cd540 100644 (file)
--- a/monitor.c
+++ b/monitor.c
@@ -270,13 +270,6 @@ static int read_and_act(struct active_array *a)
                a->info.resync_start
                );
 
-       if (a->curr_state > inactive &&
-           a->prev_state == inactive) {
-               /* array has been started
-                * possible that container operation has to be completed
-                */
-               a->container->ss->set_array_state(a, 0);
-       }
        if ((a->curr_state == bad_word || a->curr_state <= inactive) &&
            a->prev_state > inactive) {
                /* array has been stopped */