]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
super1: check fd before passing to get_dev_size() in add_to_super1()
authorMateusz Kusiak <mateusz.kusiak@intel.com>
Tue, 20 Feb 2024 10:56:11 +0000 (11:56 +0100)
committerMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Fri, 23 Feb 2024 11:44:12 +0000 (12:44 +0100)
Check if file descriptor is valid before passing it to get_dev_size() in
add_to_super().

Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com>
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
super1.c

index 871d19f0398c2492f8598064c716cb7db44faef0..5439b7bb1240a6dde9122bff1b0033eb75fe374e 100644 (file)
--- a/super1.c
+++ b/super1.c
@@ -1752,7 +1752,10 @@ static int add_to_super1(struct supertype *st, mdu_disk_info_t *dk,
        di->devname = devname;
        di->disk = *dk;
        di->data_offset = data_offset;
-       get_dev_size(fd, NULL, &di->dev_size);
+
+       if (is_fd_valid(fd))
+               get_dev_size(fd, NULL, &di->dev_size);
+
        di->next = NULL;
        *dip = di;