Grow.c: Fix classic readlink() buffer overflow

The buffer passed on to readlink() needs to contain space for the
terminating \0. See 'man 3 readlink' for details.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/Grow.c b/Grow.c
index b78d063820934ba08ab33172d415016237e0d451..a8bbf2bf19a5c58610145bff0e0e5e2aafcc6fa3 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -3319,7 +3319,7 @@ started:
                bul = make_backup(sra->sys_name);
                if (bul) {
                        char buf[1024];
-                       int l = readlink(bul, buf, sizeof(buf));
+                       int l = readlink(bul, buf, sizeof(buf) - 1);
                        if (l > 0) {
                                buf[l]=0;
                                unlink(buf);