raid6check: Fix off-by-one in argument check

In repair mode, specifying a failed slot that is equal to the number of
devices in the raid could cause a segfault.

Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/raid6check.c b/raid6check.c
index aba8160f6e5c51058bc6a4248d223da5e5ae92a2..dffadbe3235a04338bc1d2e1e192e284686cd9bf 100644 (file)
--- a/raid6check.c
+++ b/raid6check.c
@@ -416,12 +416,12 @@ int main(int argc, char *argv[])
                failed_disk1 = getnum(argv[4], &err);
                failed_disk2 = getnum(argv[5], &err);
 
-               if(failed_disk1 > info->array.raid_disks) {
+               if(failed_disk1 >= info->array.raid_disks) {
                        fprintf(stderr, "%s: failed_slot_1 index is higher than number of devices in raid\n", prg);
                        exit_err = 4;
                        goto exitHere;
                }
-               if(failed_disk2 > info->array.raid_disks) {
+               if(failed_disk2 >= info->array.raid_disks) {
                        fprintf(stderr, "%s: failed_slot_2 index is higher than number of devices in raid\n", prg);
                        exit_err = 4;
                        goto exitHere;