test/verify_extra_test.c

   1 /*
   2  * Copyright 2015-2018 The OpenSSL Project Authors. All Rights Reserved.
   3  *
   4  * Licensed under the Apache License 2.0 (the "License").  You may not use
   5  * this file except in compliance with the License.  You can obtain a copy
   6  * in the file LICENSE in the source distribution or at
   7  * https://www.openssl.org/source/license.html
   8  */
   9
  10 #include <stdio.h>
  11 #include <string.h>
  12 #include <openssl/crypto.h>
  13 #include <openssl/bio.h>
  14 #include <openssl/x509.h>
  15 #include <openssl/pem.h>
  16 #include <openssl/err.h>
  17 #include "testutil.h"
  18
  19 static const char *roots_f;
  20 static const char *untrusted_f;
  21 static const char *bad_f;
  22 static const char *req_f;
  23
  24 static STACK_OF(X509) *load_certs_from_file(const char *filename)
  25 {
  26     STACK_OF(X509) *certs;
  27     BIO *bio;
  28     X509 *x;
  29
  30     bio = BIO_new_file(filename, "r");
  31
  32     if (bio == NULL) {
  33         return NULL;
  34     }
  35
  36     certs = sk_X509_new_null();
  37     if (certs == NULL) {
  38         BIO_free(bio);
  39         return NULL;
  40     }
  41
  42     ERR_set_mark();
  43     do {
  44         x = PEM_read_bio_X509(bio, NULL, 0, NULL);
  45         if (x != NULL && !sk_X509_push(certs, x)) {
  46             sk_X509_pop_free(certs, X509_free);
  47             BIO_free(bio);
  48             return NULL;
  49         } else if (x == NULL) {
  50             /*
  51              * We probably just ran out of certs, so ignore any errors
  52              * generated
  53              */
  54             ERR_pop_to_mark();
  55         }
  56     } while (x != NULL);
  57
  58     BIO_free(bio);
  59
  60     return certs;
  61 }
  62
  63 /*
  64  * Test for CVE-2015-1793 (Alternate Chains Certificate Forgery)
  65  *
  66  * Chain is as follows:
  67  *
  68  * rootCA (self-signed)
  69  *   |
  70  * interCA
  71  *   |
  72  * subinterCA       subinterCA (self-signed)
  73  *   |                   |
  74  * leaf ------------------
  75  *   |
  76  * bad
  77  *
  78  * rootCA, interCA, subinterCA, subinterCA (ss) all have CA=TRUE
  79  * leaf and bad have CA=FALSE
  80  *
  81  * subinterCA and subinterCA (ss) have the same subject name and keys
  82  *
  83  * interCA (but not rootCA) and subinterCA (ss) are in the trusted store
  84  * (roots.pem)
  85  * leaf and subinterCA are in the untrusted list (untrusted.pem)
  86  * bad is the certificate being verified (bad.pem)
  87  *
  88  * Versions vulnerable to CVE-2015-1793 will fail to detect that leaf has
  89  * CA=FALSE, and will therefore incorrectly verify bad
  90  *
  91  */
  92 static int test_alt_chains_cert_forgery(void)
  93 {
  94     int ret = 0;
  95     int i;
  96     X509 *x = NULL;
  97     STACK_OF(X509) *untrusted = NULL;
  98     BIO *bio = NULL;
  99     X509_STORE_CTX *sctx = NULL;
 100     X509_STORE *store = NULL;
 101     X509_LOOKUP *lookup = NULL;
 102
 103     store = X509_STORE_new();
 104     if (store == NULL)
 105         goto err;
 106
 107     lookup = X509_STORE_add_lookup(store, X509_LOOKUP_file());
 108     if (lookup == NULL)
 109         goto err;
 110     if (!X509_LOOKUP_load_file(lookup, roots_f, X509_FILETYPE_PEM))
 111         goto err;
 112
 113     untrusted = load_certs_from_file(untrusted_f);
 114
 115     if ((bio = BIO_new_file(bad_f, "r")) == NULL)
 116         goto err;
 117
 118     if ((x = PEM_read_bio_X509(bio, NULL, 0, NULL)) == NULL)
 119         goto err;
 120
 121     sctx = X509_STORE_CTX_new();
 122     if (sctx == NULL)
 123         goto err;
 124
 125     if (!X509_STORE_CTX_init(sctx, store, x, untrusted))
 126         goto err;
 127
 128     i = X509_verify_cert(sctx);
 129
 130     if (i == 0 && X509_STORE_CTX_get_error(sctx) == X509_V_ERR_INVALID_CA) {
 131         /* This is the result we were expecting: Test passed */
 132         ret = 1;
 133     }
 134  err:
 135     X509_STORE_CTX_free(sctx);
 136     X509_free(x);
 137     BIO_free(bio);
 138     sk_X509_pop_free(untrusted, X509_free);
 139     X509_STORE_free(store);
 140     return ret;
 141 }
 142
 143 static int test_store_ctx(void)
 144 {
 145     X509_STORE_CTX *sctx = NULL;
 146     X509 *x = NULL;
 147     BIO *bio = NULL;
 148     int testresult = 0, ret;
 149
 150     bio = BIO_new_file(bad_f, "r");
 151     if (bio == NULL)
 152         goto err;
 153
 154     x = PEM_read_bio_X509(bio, NULL, 0, NULL);
 155     if (x == NULL)
 156         goto err;
 157
 158     sctx = X509_STORE_CTX_new();
 159     if (sctx == NULL)
 160         goto err;
 161
 162     if (!X509_STORE_CTX_init(sctx, NULL, x, NULL))
 163         goto err;
 164
 165     /* Verifying a cert where we have no trusted certs should fail */
 166     ret = X509_verify_cert(sctx);
 167
 168     if (ret == 0) {
 169         /* This is the result we were expecting: Test passed */
 170         testresult = 1;
 171     }
 172
 173  err:
 174     X509_STORE_CTX_free(sctx);
 175     X509_free(x);
 176     BIO_free(bio);
 177     return testresult;
 178 }
 179
 180 OPT_TEST_DECLARE_USAGE("roots.pem untrusted.pem bad.pem\n")
 181
 182 #ifndef OPENSSL_NO_SM2
 183 static int test_sm2_id(void)
 184 {
 185     /* we only need an X509 structure, no matter if it's a real SM2 cert */
 186     X509 *x = NULL;
 187     BIO *bio = NULL;
 188     int ret = 0;
 189     ASN1_OCTET_STRING *v = NULL, *v2 = NULL;
 190     char *sm2id = "this is an ID";
 191
 192     bio = BIO_new_file(bad_f, "r");
 193     if (bio == NULL)
 194         goto err;
 195
 196     x = PEM_read_bio_X509(bio, NULL, 0, NULL);
 197     if (x == NULL)
 198         goto err;
 199
 200     v = ASN1_OCTET_STRING_new();
 201     if (v == NULL)
 202         goto err;
 203
 204     if (!ASN1_OCTET_STRING_set(v, (unsigned char *)sm2id, (int)strlen(sm2id))) {
 205         ASN1_OCTET_STRING_free(v);
 206         goto err;
 207     }
 208
 209     X509_set0_sm2_id(x, v);
 210
 211     v2 = X509_get0_sm2_id(x);
 212     if (!TEST_ptr(v2)
 213             || !TEST_int_eq(ASN1_OCTET_STRING_cmp(v, v2), 0))
 214         goto err;
 215
 216     ret = 1;
 217  err:
 218     X509_free(x);
 219     BIO_free(bio);
 220     return ret;
 221 }
 222
 223 static int test_req_sm2_id(void)
 224 {
 225     /* we only need an X509_REQ structure, no matter if it's a real SM2 cert */
 226     X509_REQ *x = NULL;
 227     BIO *bio = NULL;
 228     int ret = 0;
 229     ASN1_OCTET_STRING *v = NULL, *v2 = NULL;
 230     char *sm2id = "this is an ID";
 231
 232     bio = BIO_new_file(req_f, "r");
 233     if (bio == NULL)
 234         goto err;
 235
 236     x = PEM_read_bio_X509_REQ(bio, NULL, 0, NULL);
 237     if (x == NULL)
 238         goto err;
 239
 240     v = ASN1_OCTET_STRING_new();
 241     if (v == NULL)
 242         goto err;
 243
 244     if (!ASN1_OCTET_STRING_set(v, (unsigned char *)sm2id, (int)strlen(sm2id))) {
 245         ASN1_OCTET_STRING_free(v);
 246         goto err;
 247     }
 248
 249     X509_REQ_set0_sm2_id(x, v);
 250
 251     v2 = X509_REQ_get0_sm2_id(x);
 252     if (!TEST_ptr(v2)
 253             || !TEST_int_eq(ASN1_OCTET_STRING_cmp(v, v2), 0))
 254         goto err;
 255
 256     ret = 1;
 257  err:
 258     X509_REQ_free(x);
 259     BIO_free(bio);
 260     return ret;
 261 }
 262 #endif
 263
 264 int setup_tests(void)
 265 {
 266     if (!TEST_ptr(roots_f = test_get_argument(0))
 267             || !TEST_ptr(untrusted_f = test_get_argument(1))
 268             || !TEST_ptr(bad_f = test_get_argument(2))
 269             || !TEST_ptr(req_f = test_get_argument(3)))
 270         return 0;
 271
 272     ADD_TEST(test_alt_chains_cert_forgery);
 273     ADD_TEST(test_store_ctx);
 274 #ifndef OPENSSL_NO_SM2
 275     ADD_TEST(test_sm2_id);
 276     ADD_TEST(test_req_sm2_id);
 277 #endif
 278     return 1;
 279 }