login: simplify string handling

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/login-utils/login.c b/login-utils/login.c
index ce112b54ebcae9482ed056d2e471bab1ad103781..6b9d27e3ef45e316b9d98823a2ee707295e80773 100644 (file)
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -1355,10 +1355,7 @@ int main(int argc, char **argv)
 
        /* if the shell field has a space: treat it like a shell script */
        if (strchr(pwd->pw_shell, ' ')) {
-               buff = xmalloc(strlen(pwd->pw_shell) + 6);
-
-               strcpy(buff, "exec ");
-               strcat(buff, pwd->pw_shell);
+               xasprintf(&buff, "exec %s", pwd->pw_shell);
                childArgv[childArgc++] = "/bin/sh";
                childArgv[childArgc++] = "-sh";
                childArgv[childArgc++] = "-c";