]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
lsns: fix clang compiler warning
authorRuediger Meier <ruediger.meier@ga-group.nl>
Sun, 21 Jan 2018 23:04:38 +0000 (00:04 +0100)
committerRuediger Meier <ruediger.meier@ga-group.nl>
Fri, 16 Feb 2018 10:12:44 +0000 (11:12 +0100)
../sys-utils/lsns.c:360:8: warning: comparison of integers of different signs: '__u32' (aka 'unsigned int') and 'int' [-Wsign-compare]
        if (!(NLMSG_OK(nlh, reslen)
              ^~~~~~~~~~~~~~~~~~~~~
/usr/include/linux/netlink.h:90:24: note: expanded from macro 'NLMSG_OK'
                           (nlh)->nlmsg_len <= (len))
                           ~~~~~~~~~~~~~~~~ ^   ~~~

Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
sys-utils/lsns.c

index d36269df54b9d2fd6ed8aeef60bfeaf94c8b0867..9f99152a490035157d3a725cdd1ec4e55ba95213 100644 (file)
@@ -347,7 +347,8 @@ static int get_netnsid_via_netlink_recv_response(int *netnsid)
                              < RTA_SPACE(sizeof(struct nlmsgerr)))
                             ? RTA_SPACE(sizeof(struct nlmsgerr))
                             : RTA_SPACE(sizeof(int32_t)))];
-       int reslen, rtalen;
+       int rtalen;
+       ssize_t reslen;
 
        struct nlmsghdr *nlh;
        struct rtattr *rta;
@@ -357,7 +358,7 @@ static int get_netnsid_via_netlink_recv_response(int *netnsid)
                return -1;
 
        nlh = (struct nlmsghdr *)res;
-       if (!(NLMSG_OK(nlh, reslen)
+       if (!(NLMSG_OK(nlh, (size_t)reslen)
              && nlh->nlmsg_type == RTM_NEWNSID))
                return -1;