umount: be more strict about --all

If you by accident execute

	umount ls -al /mnt/

then umount --all is executed and another arguments silently ignored.
It seems better to be more strict in this case.

Reported-by: Harald Dunkel <harald.dunkel@aixigo.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/sys-utils/umount.c b/sys-utils/umount.c
index e3734b0ec20cd7b16adaf5c36bcc81a500e122d4..397e0ebfc5df554b9471969a7fab967d2b29548c 100644 (file)
--- a/sys-utils/umount.c
+++ b/sys-utils/umount.c
@@ -573,6 +573,10 @@ int main(int argc, char **argv)
        argv += optind;
 
        if (all) {
+               if (argc) {
+                       warnx(_("unexpected number of arguments"));
+                       errtryhelp(MNT_EX_USAGE);
+               }
                if (!types)
                        types = "noproc,nodevfs,nodevpts,nosysfs,norpc_pipefs,nonfsd,noselinuxfs";