login: ensure getutxid() does not use uninitialized variable [coverity scan]

Field ut.ut_pid is uninitialized when calling getutxline().  The safest
option is to ensure all struct data is initialized in the function.

CID: 360793
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

diff --git a/login-utils/login.c b/login-utils/login.c
index 5cd77acf4ba4e20b097adb6e0defa3021a47ad86..e2eb108024e1ea627b6b3a04a0c2802040de4a84 100644 (file)
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -698,9 +698,9 @@ done:
  */
 static void log_utmp(struct login_context *cxt)
 {
-       struct utmpx ut;
-       struct utmpx *utp;
-       struct timeval tv;
+       struct utmpx ut = {0};
+       struct utmpx *utp = NULL;
+       struct timeval tv = {0};
 
        utmpxname(_PATH_UTMP);
        setutxent();