]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blame - gdb/ChangeLog
Move declaration of max_user_call_depth to header
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
cc8dee1f
CB
12019-10-12 Christian Biesinger <cbiesinger@google.com>
2
3 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
4 (show_user): Remove declaration of cmdlist.
5 * cli/cli-cmds.h (max_user_call_depth): Declare.
6 * cli/cli-script.c (execute_user_command): Remove declaration
7 of max_user_call_depth.
8
a83d4ef6
JW
92019-10-11 Jim Wilson <jimw@sifive.com>
10
5f93c5a6
JW
11 * gdbsupport/print-utils.h (pulongest): Fix comment.
12 (plongest): Likewise.
13 (phex): Add missing comment, mention leading zeros.
14 (phex_nz): Add mention of no leading zeros to comment.
15
a83d4ef6
JW
16 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
17 plongest instead of unsigned long long cast.
18
26344e0c
CB
192019-10-10 Christian Biesinger <cbiesinger@google.com>
20
21 * main.c (captured_main_1): Include gdbtk.h and remove declarations
22 for external_editor_command and gdbtk_test.
23
c2c440a9
CB
242019-10-10 Christian Biesinger <cbiesinger@google.com>
25
26 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
27 * varobj.c (varobjdebug): Move comment to...
28 * varobj.h (varobjdebug): ...here, and declare.
29
a31bff9d
TT
302019-10-09 Tom Tromey <tom@tromey.com>
31
32 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
33 erase_data_content.
34
7523da63
TT
352019-10-09 Tom Tromey <tom@tromey.com>
36
37 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
38 * tui/tui-stack.c (tui_locator_window::rerender): Update.
39 * tui/tui-command.c (tui_cmd_window::resize)
40 (tui_refresh_cmd_win): Update.
41 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
42 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
43 * tui/tui-data.c (~tui_gen_win_info): Remove.
44 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
45 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
46 (tui_redisplay_readline, tui_mld_flush)
47 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
48 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
49 (tui_data_window::erase_data_content)
50 (tui_data_item_window::rerender)
51 (tui_data_item_window::refresh_window): Update.
52 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
53 (box_win, tui_gen_win_info::make_window)
54 (tui_gen_win_info::make_visible): Update.
55 (tui_delete_win): Remove.
56 * tui/tui-winsource.c
57 (tui_source_window_base::do_erase_source_content): Update.
58 (tui_show_source_line, tui_source_window_base::update_tab_width)
59 (tui_source_window_base::update_exec_info): Update.
60 * tui/tui-data.h (struct curses_deleter): New.
61 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
62 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
63
a7798e7f
TT
642019-10-09 Tom Tromey <tom@tromey.com>
65
66 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
67
5c45899e
TT
682019-10-09 Tom Tromey <tom@tromey.com>
69
70 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
71 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
72
6d7fd9aa
TT
732019-10-09 Tom Tromey <tom@tromey.com>
74
75 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
76 window height directly.
77 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
78 declare.
79 * tui/tui-layout.c (tui_default_win_height): Remove.
80 (tui_default_win_viewport_height): Remove.
81
d2dd1084
TT
822019-10-09 Tom Tromey <tom@tromey.com>
83
84 * tui/tui.h: Remove comments.
85
cff32449
TV
862019-10-09 Tom de Vries <tdevries@suse.de>
87
88 * python/lib/gdb/printer/bound_registers.py: Use
89 '^builtin_type_bound128' as regexp argument for
90 add_builtin_pretty_printer.
91
6a25e8a2
CB
922019-10-09 Christian Biesinger <cbiesinger@google.com>
93
94 * guile/guile.c (guile_extension_script_ops): Remove forward
95 declaration and mark as static.
96 (guile_script_ops): Likewise.
97 (extension_language_guile): Move further down in the file so
98 it can reference the definitions for guile_{extension_,}script_ops.
99
6d9d6da4
AA
1002019-10-09 Andreas Arnez <arnez@linux.ibm.com>
101
102 * s390-tdep.c (390_process_record): Handle new arch13 instructions
103 except SORTL, DFLTCC, and KDSA.
104
3abea05d
TT
1052019-10-08 Tom Tromey <tromey@adacore.com>
106
107 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
108 (struct safe_symbol_file_add_args): Remove.
109
dde996e2
TT
1102019-10-08 Tom Tromey <tromey@adacore.com>
111
112 * windows-nat.c: Don't include buildsym-legacy.h.
113
cd6fdaa1
TT
1142019-10-08 Tom Tromey <tromey@adacore.com>
115
116 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
117
79bb1944
CB
1182019-10-08 Christian Biesinger <cbiesinger@google.com>
119
120 * gdbtypes.c (overload_debug): Move comment to header.
121 * gdbtypes.h (overload_debug): Declare.
122 * valops.c: Remove declaration of overload_debug, instead
123 include gdbtypes.h.
124
34916edc
CB
1252019-10-08 Christian Biesinger <cbiesinger@google.com>
126
127 * language.c (show_language_command): Pass lang_frame_mismatch_warn
128 through _().
129 (lang_frame_mismatch_warn): Make const, mark with N_(), and
130 move comment...
131 * language.h (lang_frame_mismatch_warn): ... here. Also add
132 declaration.
133 * top.c (lang_frame_mismatch_warn): Remove declaration.
134 (check_frame_language_change): Pass lang_frame_mismatch_warn
135 through _().
136
bad5c026
CB
1372019-10-07 Christian Biesinger <cbiesinger@google.com>
138
139 * c-lang.h (vtbl_ptr_name): Declare.
140 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
141 it from the header.
142 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
143
51f1fdc3
CB
1442019-10-07 Christian Biesinger <cbiesinger@google.com>
145
146 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
147 gdb_static_assert.
148
30d1f018
WP
1492019-10-07 Weimin Pan <weimin.pan@oracle.com>
150
606813d5
WP
151 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
152 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
153 * ctfread.c: New file.
154 * ctfread.h: New file.
155 * elfread.c: Include ctfread.h.
156 (struct elfinfo text_p): New member ctfsect.
157 (elf_locate_sections): Mark CTF section.
158 (elf_symfile_read): Call elfctf_build_psymtabs.
159 * Makefile.in (LIBCTF): Add.
160 (CLIBS): Use it.
161 (CDEPS): Likewise.
162 (DIST): Add ctfread.c.
606813d5
WP
163
1642019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
165
166 * ctfread.c (struct nextfield): Renamed to ...
167 (struct ctf_nextfield): ... this.
168 (struct field_info): Renamed to ...
169 (strut ctf_field_info): ... this.
170 (attach_fields_to_type): Update for renamed structures.
171 (ctf_add_member_cb): Likewise.
172 (ctf_add_enum_member_cb): Likewise.
173 (process_struct_members): Likewise.
174 (process_enum_type): Likewise.
30d1f018 175
518fe38c
WP
1762019-10-07 Weimin Pan <weimin.pan@oracle.com>
177
178 * tracectf.h: Rename, was ctf.h.
179 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
180 * tracefile.c: Likewise.
181 * tracepoint.c: Remove unused include ctf.h.
182 * mi/mi-main.c: Likewise.
183 * Makefile.in Replace ctf.c with tracectf.c.
184
225f296a
JB
1852019-10-06 Joel Brobecker <brobecker@adacore.com>
186
187 * version.in: Change version number to "9.0.50.DATE-git".
188
77c2dba3
TT
1892019-10-03 Tom Tromey <tom@tromey.com>
190
191 PR rust/24976:
192 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
193
179aed7f
AB
1942019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
195
196 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
197 cp_search_name_hash.
198 * NEWS: Add entry about nested function support.
199
0a4b0913
AB
2002019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
201 Andrew Burgess <andrew.burgess@embecosm.com>
202
203 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
204 for nested static variables when searchin VAR_DOMAIN.
205 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
206 global scope, update comment.
207 (add_partial_subprogram): Call add_partial_subprogram recursively
208 for nested subroutines when processinng Fortran.
209 (load_partial_dies): Process the child entities of a subprogram
210 when processing Fortran.
211 (partial_die_parent_scope): Handle building scope
212 for Fortran nested functions.
213 (process_die): Record that nested functions have a scope.
214 (new_symbol): Always record Fortran subprograms on the global
215 symbol list.
216 (determine_prefix): How to build the prefix for Fortran
217 subprograms.
218
d8c06f22
AB
2192019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
220
221 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
222 have just sent the thread a SIGSTOP and are waiting for it to
223 arrive.
224
a8b3b8e9
AB
2252019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
226
227 * btrace.c (btrace_add_pc): Remove whitespace before the template
228 parameter in 'std::vector <...>'.
229 (parse_xml_btrace_block): Likewise.
230 (btrace_maint_decode_pt): Likewise.
231 (btrace_maint_update_packets): Likewise.
232 (btrace_maint_print_packets): Likewise.
233 * btrace.h (struct btrace_maint_info): Likewise.
234 * dwarf2read.c (struct type_unit_group): Likewise.
235 (build_type_psymtabs_reader): Likewise.
236 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
237 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
238 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
239
4d825eab
TV
2402019-10-03 Tom de Vries <tdevries@suse.de>
241
242 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
243 the first line of the help text for set/show style metadata.
244
80fd2826
TT
2452019-10-02 Tom Tromey <tromey@adacore.com>
246
247 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
248 * gdbsupport/common-inferior.c: New file.
249 * infcmd.c (startup_with_shell): Don't define.
250 * nat/fork-inferior.h (startup_with_shell): Don't declare.
251 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
252 * inferior.h (startup_with_shell): Don't declare.
253
70054538
CB
2542019-10-02 Christian Biesinger <cbiesinger@google.com>
255
256 * gdbsupport/gdb_assert.h: Include errors.h.
257 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
258
37f6a7f4
TT
2592019-10-02 Tom Tromey <tromey@adacore.com>
260
261 * NEWS: Add $_ada_exception entry.
262 * ada-lang.c (struct ada_catchpoint): Add constructor.
263 <m_kind>: New member.
264 (allocate_location_exception, re_set_exception): Remove
265 "ex" parameter.
266 (should_stop_exception): Compute $_ada_exception.
267 (check_status_exception, print_it_exception)
268 (print_one_exception, print_mention_exception): Remove
269 "ex" parameter.
270 (allocate_location_catch_exception, re_set_catch_exception)
271 (check_status_exception, print_it_catch_exception)
272 (print_one_catch_exception, print_mention_catch_exception)
273 (print_recreate_catch_exception)
274 (allocate_location_catch_exception_unhandled)
275 (re_set_catch_exception_unhandled)
276 (check_status_exception, print_it_catch_exception_unhandled)
277 (print_one_catch_exception_unhandled)
278 (print_mention_catch_exception_unhandled)
279 (print_recreate_catch_exception_unhandled)
280 (allocate_location_catch_assert, re_set_catch_assert)
281 (check_status_assert, print_it_catch_assert)
282 (print_one_catch_assert, print_mention_catch_assert)
283 (print_recreate_catch_assert)
284 (allocate_location_catch_handlers, re_set_catch_handlers)
285 (check_status_handlers, print_it_catch_handlers)
286 (print_one_catch_handlers, print_mention_catch_handlers)
287 (print_recreate_catch_handlers): Remove.
288 (create_ada_exception_catchpoint): Update.
289 (initialize_ada_catchpoint_ops): Update.
290
fccf9de1
TT
2912019-10-02 Tom Tromey <tromey@adacore.com>
292
293 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
294 (create_excep_cond_exprs): Simplify exception string computation.
295 (ada_exception_catchpoint_cond_string): Likewise.
296
4b610737
TT
2972019-10-02 Tom Tromey <tromey@adacore.com>
298
299 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
300 * ada-lang.c (lesseq_defined_than): Handle
301 LOC_STATIC.
302 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
303 parameter.
304 (dwarf2_has_info): Likewise.
305 (new_symbol): Set maybe_copied on symbol when
306 appropriate.
307 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
308 parameter.
309 <can_copy>: New member.
310 * elfread.c (record_minimal_symbol): Set maybe_copied
311 on symbol when appropriate.
312 (elf_symfile_read): Update call to dwarf2_has_info.
313 * minsyms.c (lookup_minimal_symbol_linkage): New
314 function.
315 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
316 * symtab.c (get_symbol_address, get_msymbol_address):
317 New functions.
318 * symtab.h (get_symbol_address, get_msymbol_address):
319 Declare.
320 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
321 maybe_copied.
322 (struct symbol, struct minimal_symbol) <maybe_copied>:
323 New member.
324
1dd58850
TT
3252019-10-02 Tom Tromey <tromey@adacore.com>
326
327 * source.c (struct current_source_location): New.
328 (current_source_key): New global.
329 (current_source_symtab, current_source_line)
330 (current_source_pspace): Remove.
331 (get_source_location): New function.
332 (get_current_source_symtab_and_line)
333 (set_default_source_symtab_and_line)
334 (set_current_source_symtab_and_line)
335 (clear_current_source_symtab_and_line, select_source_symtab)
336 (info_source_command, print_source_lines_base)
337 (info_line_command, search_command_helper, _initialize_source):
338 Update.
339
5c281dbb
TT
3402019-10-02 Tom Tromey <tromey@adacore.com>
341
342 * source.c (select_source_symtab): Don't call
343 decode_line_with_current_source.
344
d3d32391
AB
3452019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
346
347 * symtab.c (lookup_global_symbol): Search global block.
348
38583298
TT
3492019-10-02 Tom Tromey <tromey@adacore.com>
350
351 * coffread.c (process_coff_symbol): Update.
352 * dwarf2read.c (var_decode_location, new_symbol): Update.
353 * mdebugread.c (parse_symbol): Update.
354 * objfiles.c (relocate_one_symbol): Update.
355 * stabsread.c (define_symbol, fix_common_block)
356 (scan_file_globals): Update.
357 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
358 (SET_SYMBOL_VALUE_ADDRESS): New macro.
359 * xcoffread.c (process_xcoff_symbol): Update.
360
9344c18f
AA
3612019-10-02 Andreas Arnez <arnez@linux.ibm.com>
362
363 * MAINTAINERS: Update my email address.
364
df07e2c7
AB
3652019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
366
367 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
368 std::vector.
369 (build_type_psymtabs_reader): Update for std::vector.
370 (build_type_psymtab_dependencies): Likewise.
371 * dwarf2read.h: Remove use of DEF_VEC_P.
372 (typedef sig_type_ptr): Delete.
373
554ac434
AB
3742019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
375
376 * btrace.c (btrace_maint_clear): Update to handle change from VEC
377 to std::vector.
378 (btrace_maint_decode_pt): Likewise, and move allocation of the
379 vector outside of the loop.
380 (btrace_maint_update_packets): Update to handle change from VEC to
381 std::vector.
382 (btrace_maint_print_packets): Likewise.
383 (maint_info_btrace_cmd): Likewise.
384 * btrace.h: Remove use of DEF_VEC_O.
385 (typedef btrace_pt_packet_s): Delete.
386 (struct btrace_maint_info) <packets>: Change fromm VEC to
387 std::vector.
388 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
389
46f29a9a
AB
3902019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
391
392 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
393 make accesses into the vector constant references.
394 (btrace_add_pc): Update for std::vector.
395 (btrace_stitch_bts): Likewise.
396 (parse_xml_btrace_block): Likewise.
397 (btrace_maint_update_packets): Likewise.
398 (btrace_maint_print_packets): Likewise.
399 (maint_info_btrace_cmd): Likewise.
400 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
401 std::vector.
402 (btrace_data::empty): Likewise.
403 (btrace_data_append): Likewise.
404 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
405 (typedef btrace_block_s): Delete.
406 (struct btrace_block): Add constructor.
407 (struct btrace_data_bts) <blocks>: Change to std::vector.
408 * nat/linux-btrace.c (perf_event_read_bts): Update for
409 std::vector.
410 (linux_read_bts): Likewise.
411
d770d56f
TT
4122019-10-01 Tom Tromey <tom@tromey.com>
413
414 * cli/cli-logging.c (show_logging_filename): Use styled_string.
415
9d636d67
TT
4162019-10-01 Tom Tromey <tom@tromey.com>
417
418 * stack.c (print_frame, info_frame_command_core): Use
419 styled_string.
420 * linux-thread-db.c (try_thread_db_load_1)
421 (try_thread_db_load_from_pdir_1): Use styled_string.
422 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
423 (auto_load_section_scripts, info_auto_load_local_gdbinit)
424 (maybe_print_unsupported_script_warning)
425 (maybe_print_script_not_found_warning): Use styled_string.
426 * ada-lang.c (user_select_syms): Use styled_string.
427
7f6aba03
TT
4282019-10-01 Tom Tromey <tom@tromey.com>
429
430 * p-lang.c (pascal_printstr): Use metadata style.
431 * value.c (show_convenience): Use metadata style.
432 * valprint.c (valprint_check_validity, val_print_optimized_out)
433 (val_print_not_saved, val_print_unavailable)
434 (val_print_invalid_address, generic_val_print, val_print)
435 (value_check_printable, val_print_array_elements): Use metadata
436 style.
437 * ui-out.h (class ui_out) <field_fmt>: New overload.
438 <do_field_fmt>: Add style parameter.
439 * ui-out.c (ui_out::field_fmt): New overload.
440 * typeprint.c (type_print_unknown_return_type)
441 (val_print_not_allocated, val_print_not_associated): Use metadata
442 style.
443 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
444 parameter.
445 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
446 * tracepoint.c (tvariables_info_1): Use metadata style.
447 * stack.c (print_frame_arg, print_frame_info, print_frame)
448 (info_frame_command_core): Use metadata style.
449 * skip.c (info_skip_command): Use metadata style.
450 * rust-lang.c (rust_print_enum): Use metadata style.
451 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
452 metadata style.
453 * python/py-framefilter.c (py_print_single_arg): Use metadata
454 style.
455 * printcmd.c (do_one_display, print_variable_and_value): Use
456 metadata style.
457 * p-valprint.c (pascal_val_print)
458 (pascal_object_print_value_fields): Use metadata style.
459 * p-typeprint.c (pascal_type_print_base): Use metadata style.
460 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
461 parameter.
462 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
463 * m2-valprint.c (m2_print_long_set): Use metadata style.
464 * m2-typeprint.c (m2_print_type): Use metadata style.
465 * infcmd.c (print_return_value_1): Use metadata style.
466 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
467 * f-valprint.c (info_common_command_for_block): Use metadata
468 style.
469 * f-typeprint.c (f_type_print_base): Use metadata style.
470 * expprint.c (print_subexp_standard): Use metadata style.
471 * cp-valprint.c (cp_print_value_fields): Use metadata style.
472 * cli/cli-style.h (class cli_style_option): Add constructor.
473 (metadata_style): Declare.
474 * cli/cli-style.c (metadata_style): New global.
475 (_initialize_cli_style): Register metadata style.
476 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
477 parameter.
478 * cli-out.c (cli_ui_out::do_field_fmt): Update.
479 * c-typeprint.c (c_type_print_base_struct_union)
480 (c_type_print_base_1): Use metadata style.
481 * breakpoint.c (watchpoint_value_print)
482 (print_one_breakpoint_location): Use metadata style.
483 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
484 style.
485 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
486 style.
487 * ada-valprint.c (val_print_packed_array_elements, printstr)
488 (print_field_values, ada_val_print_ref, ada_val_print): Use
489 metadata style.
490 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
491 style.
492 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
493 style.
494 * ada-lang.c (user_select_syms): Use metadata style.
495
14309bb6
TT
4962019-10-01 Tom Tromey <tom@tromey.com>
497
498 * cli/cli-cmds.c (pwd_command): Style output.
499
6a831f06
PA
5002019-10-01 Pedro Alves <palves@redhat.com>
501 Tom Tromey <tom@tromey.com>
502
503 * symtab.c (print_symbol_info): Use %ps.
504 (print_msymbol_info): Use %ps.
505 * symfile.c (symbol_file_add_with_addrs): Use %ps.
506 * printcmd.c (print_variable_and_value): Use %ps.
507 * macrocmd.c (show_pp_source_pos): Use %ps.
508 * infrun.c (print_exited_reason): Use ui_out::message.
509 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
510 (describe_other_breakpoints): Use ui_out::message and new
511 formats.
512 (say_where): Use new formats.
513 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
514 and new formats.
515
2a3c1174
PA
5162019-10-01 Pedro Alves <palves@redhat.com>
517 Tom Tromey <tom@tromey.com>
518
519 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
520 (test_gdb_formats): New function.
521 (run_tests): Call it.
522 (test_format_specifier): Update.
523 * utils.h (fputs_filtered): Update comment.
524 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
525 (fputs_styled_unfiltered): Declare.
526 * utils.c (fputs_styled_unfiltered): New function.
527 (vfprintf_maybe_filtered): Add gdbfmt parameter.
528 (vfprintf_filtered): Update.
529 (vfprintf_unfiltered, vprintf_filtered): Update.
530 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
531 * ui-out.h (enum ui_out_flag) <unfiltered_output,
532 disallow_ui_out_field>: New constants.
533 (enum class field_kind): New.
534 (struct base_field_s, struct signed_field_s): New.
535 (signed_field): New function.
536 (struct string_field_s): New.
537 (string_field): New function.
538 (struct styled_string_s): New.
539 (styled_string): New function.
540 (class ui_out) <message>: Add comment.
541 <vmessage, call_do_message>: New methods.
542 <do_message>: Add style parameter.
543 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
544 methods.
545 (ui_out::message): Rewrite.
546 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
547 parameter.
548 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
549 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
550 gdb_extensions parameter.
551 (class format_piece): Add parameter to constructor.
552 (n_int_args): New field.
553 * gdbsupport/format.c (format_pieces::format_pieces): Add
554 gdb_extensions parameter. Handle '*'.
555 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
556 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
557 vfprintf_styled_no_gdbfmt.
558 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
559 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
560 unfiltered output.
561 * ui-style.h (struct ui_file_style) <ptr>: New method.
562
0dfe5bfb
TT
5632019-10-01 Tom Tromey <tom@tromey.com>
564
565 * unittests/format_pieces-selftests.c: Update. Add final format.
566 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
567 empty literal pieces.
568
e43b10e1
TT
5692019-10-01 Tom Tromey <tom@tromey.com>
570
571 * ui-out.h (enum class ui_out_style_kind): Remove.
572 (class ui_out) <field_string, field_stsream, do_field_string>:
573 Change type of "style".
574 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
575 (ui_out::field_string): Update.
576 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
577 of "style".
578 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
579 * tracepoint.c (print_one_static_tracepoint_marker): Update.
580 * stack.c (print_frame_arg, print_frame_info, print_frame):
581 Update.
582 * source.c (print_source_lines_base): Update.
583 * solib.c (info_sharedlibrary_command): Update.
584 * skip.c (info_skip_command): Update.
585 * record-btrace.c (btrace_call_history_src_line)
586 (btrace_call_history): Update.
587 * python/py-framefilter.c (py_print_frame): Update.
588 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
589 "style".
590 * mi/mi-out.c (mi_ui_out::do_table_header)
591 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
592 (mi_ui_out::do_field_string): Update.
593 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
594 Update.
595 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
596 "style".
597 * cli-out.c (cli_ui_out::do_table_header)
598 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
599 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
600 (cli_ui_out::do_field_fmt): Update.
601 * breakpoint.c (print_breakpoint_location): Update.
602 (update_static_tracepoint): Update.
603
cd7c32c3
PW
6042019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
605
606 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
607 conversion of gdb_datadir.
608 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
609 remove not needed c_str ().
610
8fe0f950
AT
6112019-09-30 Ali Tamur <tamur@google.com>
612
613 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
614 (dwarf2_string_attr): Likewise.
615
5f48f8f3
AT
6162019-09-30 Ali Tamur <tamur@google.com>
617
618 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
619 (process_full_type_unit): Likewise.
620 (dump_die_shallow): Likewise.
621 (cu_debug_loc_section): Likewise.
622
6fb08628
CB
6232019-09-28 Christian Biesinger <cbiesinger@google.com>
624
625 * minsyms.c (compare_minimal_symbols): Rename to...
626 (minimal_symbol_is_less_than): ...this, and adjust to STL
627 conventions (return bool, take arguments as references)
628 (minimal_symbol_reader::install): Call std::sort instead
629 of qsort.
630
c7ee338a
CB
6312019-09-29 Christian Biesinger <cbiesinger@google.com>
632
633 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
634 hash and why.
635 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
636 msymbol_hash, msymbol_demangled_hash>: Improve comments.
637
703a86c2
SM
6382019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
639
640 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
641 * psympriv.h (add_psymbol_to_list): Move comment here and update
642 it.
643
0df0352a
TV
6442019-09-29 Tom de Vries <tdevries@suse.de>
645
646 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
647 Use $tmpdir/$(basename "$output_file").dwz instead of
648 "${output_file}.dwz".
649
ad75efa6
SM
6502019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
651
652 PR gdb/25045
653 * hppa-linux-nat.c: Include gdbarch.h.
654
ececd218
CB
6552019-09-26 Christian Biesinger <cbiesinger@google.com>
656
657 * blockframe.c (find_pc_partial_function): Change return type to bool.
658 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
659 * minsyms.c (in_gnu_ifunc_stub): Likewise.
660 (stub_gnu_ifunc_resolve_name): Likewise.
661 * symtab.c (compare_filenames_for_search): Likewise.
662 (compare_glob_filenames_for_search): Likewise.
663 (matching_obj_sections): Likewise.
664 (symbol_matches_domain): Likewise.
665 (find_line_symtab): Change out param EXACT_MATCH to bool *.
666 (find_line_pc): Change return type to bool.
667 (find_line_pc_range): Likewise.
668 (producer_is_realview): Likewise.
669 * symtab.h (symbol_matches_domain): Likewise.
670 (find_pc_partial_function): Likewise.
671 (find_pc_line_pc_range): Likewise.
672 (in_gnu_ifunc_stub): Likewise.
673 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
674 (find_line_pc): Likewise.
675 (find_line_pc_range): Likewise.
676 (matching_obj_sections): Likewise.
677 (find_line_symtab): Change out parameter to bool.
678 (producer_is_realview): Change return type to bool.
679 (compare_filenames_for_search): Likewise.
680 (compare_glob_filenames_for_search): Likewise.
681
27a900b8
TT
6822019-09-26 Tom Tromey <tom@tromey.com>
683
684 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
685 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
686 * gdb_usleep.h: Remove.
687 * gdb_usleep.c: Remove.
688 * utils.c: Don't include gdb_usleep.h.
689
5d63b30a
TT
6902019-09-26 Tom Tromey <tromey@adacore.com>
691
692 * python/py-type.c (type_to_type_object): Call check_typedef
693 for stub types.
694
12904d37
TT
6952019-09-26 Tom Tromey <tom@tromey.com>
696
697 * utils.h (initialize_utils): Don't declare.
698 * top.c (gdb_init): Don't call initialize_utils.
699 * utils.c (initialize_utils): Remove. Move contents...
700 (_initialize_utils): ... here.
701
858f25f0
TT
7022019-09-25 Tom Tromey <tom@tromey.com>
703
704 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
705 * utils.h (make_hex_string): Don't declare.
706 * utils.c (make_hex_string): Remove.
707
3d435220
TV
7082019-09-24 Tom de Vries <tdevries@suse.de>
709
710 PR gdb/23815
711 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
712 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
713
ddd44b70
DD
7142019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
715
716 * NEWS: Mention new simulator port for PRU.
717
f945dedf
CB
7182019-09-23 Christian Biesinger <cbiesinger@google.com>
719
720 * ada-exp.y (write_object_remaining): Update.
721 * ada-lang.c (ada_decode): Return a std::string instead of a char*
722 and eliminate the static buffer.
723 (ada_decode_symbol): Update.
724 (ada_la_decode): Update.
725 (ada_sniff_from_mangled_name): Update.
726 (is_valid_name_for_wild_match): Update.
727 (ada_lookup_name_info::matches): Update and simplify.
728 (name_matches_regex): Update.
729 (ada_add_global_exceptions): Update.
730 * ada-lang.h (ada_decode): Update signature.
731 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
732 * dwarf-index-write.c (debug_names::insert): Update.
733
7ab78ccb
SM
7342019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
735
736 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
737 formatting.
738
9252448b
SM
7392019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
740
741 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
742 Change "nonzero" to "true" in documentation.
743
626ca2c0
CB
7442019-09-20 Christian Biesinger <cbiesinger@google.com>
745
746 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
747 (_initialize_darwin_solib): Don't set
748 darwin_so_ops.lookup_lib_global_symbol.
749 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
750 set_gdbarch_iterate_over_objfiles_in_search_order.
751 (elf_lookup_lib_symbol): Rename to...
752 (svr4_iterate_over_objfiles_in_search_order): this, and update
753 to iterate semantics.
754 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
755 * solib.c (solib_global_lookup): Remove.
756 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
757 (solib_global_lookup): Remove.
758 * symtab.c (lookup_global_or_static_symbol): Remove call to
759 solib_global_lookup.
760
5a3a0d63
JB
7612019-09-20 Joel Brobecker <brobecker@adacore.com>
762
763 * NEWS: Move entries about default MI version now being
764 version 3, and about the GDB/MI fix for multi-location
765 breakpoints to the "since GDB 8.3" section.
766
ffea1427
JB
7672019-09-20 Joel Brobecker <brobecker@adacore.com>
768
769 GDB 8.3.1 released.
770
abf516c6
UW
7712019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
772
773 * NEWS: Mention that Cell/B.E. debugging support was removed.
774 * MAINTAINERS: Remove spu target.
775
776 * config/djgpp/fnchange.lst: Remove entries for removed files.
777
778 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
779 spu-multiarch.o, and spu-tdep.o.
780 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
781 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
782 spu-multiarch.c, and spu-tdep.c.
783 * spu-linux-nat.c: Remove file.
784 * spu-multiarch.c: Remove file.
785 * spu-tdep.c: Remove file.
786 * spu-tdep.h: Remove file.
787 * solib-spu.c: Remove file.
788 * solib-spu.h: Remove file.
789
790 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
791 * configure.nat (spu-linux): Remove.
792 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
793 solib-multiarch.o from gdb_target_obs.
794 (spu*-*-*): Remove.
795
796 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
797 feature flag.
798 (ppc_linux_no_features): Update.
799 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
800 Cell/B.E. support.
801 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
802 (tdesc_powerpc_cell64l): Likewise.
803 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
804 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
805 Cell/B.E. support.
806 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
807 Do not include "features/rs6000/powerpc-cell32l.c" or
808 "features/rs6000/powerpc-cell64l.c".
809 (ppc_linux_spu_section): Remove.
810 (ppc_linux_core_read_description): Remove Cell/B.E. support.
811 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
812 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
813 (ppc_linux_spe_context_lookup): Remove.
814 (ppc_linux_spe_context_inferior_created): Remove.
815 (ppc_linux_spe_context_solib_loaded): Remove.
816 (ppc_linux_spe_context_solib_unloaded): Remove.
817 (ppc_linux_spe_context): Remove.
818 (struct ppu2spu_cache): Remove.
819 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
820 (struct ppu2spu_data): Remove.
821 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
822 ppu2spu_unwind): Remove.
823 (ppc_linux_init_abi): Remove Cell/B.E. support.
824 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
825
826 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
827 (rs6000/powerpc-cell64l-expedite): Likewise
828 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
829 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
830 rs6000/powerpc-cell64l.xml.
831 * features/rs6000/powerpc-cell32l.xml: Remove.
832 * features/rs6000/powerpc-cell64l.xml: Likewise.
833 * features/rs6000/powerpc-cell32l.c: Remove generated file.
834 * features/rs6000/powerpc-cell64l.c: Likewise.
835 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
836 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
837 * regformats/reg-spu.dat: Remove.
838
839 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
840 * corelow.c (struct spuid_list): Remove.
841 (add_to_spuid_list): Remove.
842 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
843 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
844 (remote_protocol_features): Remove associated entries.
845 (_initialize_remote): No longer initialize them.
846 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
847 * linux-nat.c (SPUFS_MAGIC): Remove.
848 (linux_proc_xfer_spu): Remove.
849 (spu_enumerate_spu_ids): Remove.
850 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
851 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
852 (linux_make_corefile_notes): No longer call it.
853
854 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
855 (cooked_write_test): Likewise.
856
78e8cb91
TT
8572019-09-20 Tom Tromey <tom@tromey.com>
858
859 * NEWS: Mention case-sensitivity of TUI commands.
860 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
861 (tui_set_win_height_command, parse_scrolling_args): Likewise.
862 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
863
f074b67e
TT
8642019-09-20 Tom Tromey <tom@tromey.com>
865
866 * tui/tui-source.c (tui_source_window::set_contents): Use
867 make_unique_xstrdup.
868 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
869 make_unique_xstrdup.
870
63c4bf19
TT
8712019-09-20 Tom Tromey <tom@tromey.com>
872
873 * tui/tui-data.c: Remove separator comments.
874 * tui/tui-layout.c: Remove separator comments.
875 * tui/tui-win.c: Remove separator comments.
876 * tui/tui-wingeneral.c: Remove separator comments.
877
43df9b2f
TT
8782019-09-20 Tom Tromey <tom@tromey.com>
879
880 * tui/tui.h (strcat_to_buf): Don't declare.
881 * tui/tui.c (strcat_to_buf): Remove.
882
7226433c
TT
8832019-09-20 Tom Tromey <tom@tromey.com>
884
885 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
886 from "fullname".
887 * tui/tui-source.c (tui_source_window::set_contents)
888 (tui_source_window::location_matches_p)
889 (tui_source_window::maybe_update): Update.
890
80df3337
TT
8912019-09-20 Tom Tromey <tom@tromey.com>
892
893 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
894 Update.
895 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
896 prefix.
897 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
898 (tui_data_window::line_from_reg_element_no)
899 (tui_data_window::first_reg_element_no_inline)
900 (tui_data_window::show_registers)
901 (tui_data_window::show_register_group)
902 (tui_data_window::display_registers_from)
903 (tui_data_window::display_registers_from_line)
904 (tui_data_window::first_data_item_displayed)
905 (tui_data_window::delete_data_content_windows)
906 (tui_data_window::erase_data_content)
907 (tui_data_window::do_scroll_vertical)
908 (tui_data_window::refresh_window)
909 (tui_data_window::check_register_values): Update.
910
9923f347
TT
9112019-09-20 Tom Tromey <tom@tromey.com>
912
913 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
914 (struct tui_locator_window) <full_name, proc_name>: Now
915 std::string.
916 * tui/tui-stack.c (tui_locator_window::make_status_line)
917 (tui_locator_window::set_locator_fullname)
918 (tui_locator_window::set_locator_info): Update.
919 * tui/tui-source.c (tui_source_window::set_contents)
920 (tui_source_window::showing_source_p): Update.
921
b76251ab
TT
9222019-09-20 Tom Tromey <tom@tromey.com>
923
924 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
925 Don't call tui_locator_win_info_ptr.
926
0891be08
TT
9272019-09-20 Tom Tromey <tom@tromey.com>
928
929 * tui/tui-win.c (tui_resize_all): Don't call refresh.
930
1b935acf
TT
9312019-09-20 Tom Tromey <tom@tromey.com>
932
933 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
934 height for locator.
935 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
936 * tui/tui-layout.c (show_source_disasm_command, show_data)
937 (show_source_or_disasm_and_command): Use 1 as height for locator.
938
9abd8a65
TT
9392019-09-20 Tom Tromey <tom@tromey.com>
940
941 * tui/tui.c (tui_enable): Update.
942 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
943 Update.
944 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
945 Update.
946 * tui/tui-data.c (win_resized): Now bool.
947 (tui_win_resized): Return bool.
948 (tui_set_win_resized_to): Accept a bool.
949
b5457826
TT
9502019-09-20 Tom Tromey <tom@tromey.com>
951
952 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
953 Change type of "refresh_values_only".
954 * tui/tui-regs.c (tui_data_window::show_register_group): Change
955 type of "refresh_values_only".
956
6b915f7d
TT
9572019-09-20 Tom Tromey <tom@tromey.com>
958
959 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
960 std::string.
961 (tui_disassemble): Add "pos" parameter.
962 (tui_disasm_window::set_contents): Simplify.
963
2ad52f6f
TT
9642019-09-20 Tom Tromey <tom@tromey.com>
965
966 * tui/tui-winsource.h (struct tui_source_window_base)
967 <show_source_content>: Now private.
968 * tui/tui-winsource.c
969 (tui_source_window_base::show_source_content): Don't handle empty
970 content case.
971
b3b1bde6
TT
9722019-09-20 Tom Tromey <tom@tromey.com>
973
974 * tui/tui-layout.c (show_source_disasm_command)
975 (show_source_or_disasm_and_command): Don't call
976 show_source_content.
977
71a25ed2
TT
9782019-09-20 Tom Tromey <tom@tromey.com>
979
980 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
981 Declare.
982 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
983 from tui_make_status_line.
984 (tui_locator_window::rerender): Update.
985
f8532154
TT
9862019-09-20 Tom Tromey <tom@tromey.com>
987
988 * tui/tui-stack.c (tui_make_status_line): Return std::string.
989 (tui_locator_window::rerender): Update.
990
2d81b349
TT
9912019-09-20 Tom Tromey <tom@tromey.com>
992
993 * tui/tui-winsource.h (struct tui_source_window_base)
994 <~tui_source_window_base>: Don't declare.
995 <fullname>: Remove.
996 * tui/tui-winsource.c (~tui_source_window_base): Remove.
997 * tui/tui-source.h (struct tui_source_window) <fullname>: New
998 member.
999 * tui/tui-source.c (tui_source_window::set_contents): Update.
1000 (tui_source_window::location_matches_p)
1001 (tui_source_window::maybe_update): Update.
1002
f14bec58
TT
10032019-09-20 Tom Tromey <tom@tromey.com>
1004
1005 * tui/tui-winsource.h (~tui_source_element): Remove.
1006 (tui_source_element): Update.
1007 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1008 * tui/tui-winsource.c (tui_show_source_line): Update.
1009 * tui/tui-source.c (tui_source_window::set_contents): Update.
1010 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1011
78d5933a
TT
10122019-09-20 Tom Tromey <tom@tromey.com>
1013
1014 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1015 declare.
1016 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1017 tui_clear_source_windows_detail.
1018 * tui/tui-winsource.h (struct tui_source_window_base)
1019 <clear_detail>: Don't declare.
1020 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1021 Remove.
1022 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1023
d4207696
TT
10242019-09-20 Tom Tromey <tromey@adacore.com>
1025
1026 PR ada/24919:
1027 * block.c (contained_in): Fix final return value.
1028
00f93c44
AM
10292019-09-20 Alan Modra <amodra@gmail.com>
1030
1031 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1032 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1033 (read_indirect_string_from_dwz): Use bfd accessor.
1034 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1035 * machoread.c (macho_symfile_read_all_oso): Likewise.
1036 * solib.c (solib_bfd_open): Likewise.
1037
e4153ae6
CB
10382019-09-19 Christian Biesinger <cbiesinger@google.com>
1039
1040 * eval.c: Move declaration of overload_resolution to...
1041 * value.h: ...here.
1042
c7ae7675
CB
10432019-09-19 Christian Biesinger <cbiesinger@google.com>
1044
1045 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1046 * arm-linux-tdep.c: Likewise.
1047 * arm-nbsd-nat.c: Likewise.
1048 * arm-tdep.h: Declare arm_apcs_32.
1049 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1050
e86f08d2
CB
10512019-09-19 Christian Biesinger <cbiesinger@google.com>
1052
1053 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1054 * dwarf2read.h: Declare dwarf_always_disassemble.
1055
f64e2f40
TV
10562019-09-19 Tom de Vries <tdevries@suse.de>
1057
1058 PR gdb/25009
1059 * source-cache.c (source_cache::ensure): Catch exception thrown during
1060 construction of the highlighter.
1061
fd361982
AM
10622019-09-18 Alan Modra <amodra@gmail.com>
1063
1064 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1065 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1066 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1067 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1068 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1069 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1070 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1071 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1072 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1073 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1074 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1075 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1076 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1077 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1078 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1079 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1080 * mi/mi-interp.c: Update throughout for bfd section macro and
1081 function changes.
1082 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1083 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1084
11061048
TT
10852019-09-18 Tom Tromey <tom@tromey.com>
1086
1087 * NEWS: Add entry.
1088 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1089 call rl_initialize.
1090 (tui_enable): Do not call rl_initialize.
1091
7a27b85f
CG
10922019-09-18 Christian Groessler <chris@groessler.org>
1093
1094 * alpha-linux-nat.c: Include gdbarch.h.
1095
f64eea3a
SM
10962019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1097
1098 * ui-file.c: Include cli/cli-style.h.
1099 (term_cli_styling): Remove cli_styling declaration.
1100
e6f7f6d1
AM
11012019-09-18 Alan Modra <amodra@gmail.com>
1102
1103 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1104 to bfd_asymbol_section.
1105
1d38e9d1
AM
11062019-09-18 Alan Modra <amodra@gmail.com>
1107
1108 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1109 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1110 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1111
90d92a63
AM
11122019-09-18 Alan Modra <amodra@gmail.com>
1113
1114 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1115 * spu-linux-nat.c (spu_bfd_open): Likewise.
1116
a3d181d2
CB
11172019-09-18 Christian Biesinger <cbiesinger@google.com>
1118
1119 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1120 to bool to match definition in dwarf2read.c.
1121
491144b5
CB
11222019-09-17 Christian Biesinger <cbiesinger@google.com>
1123
1124 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1125 (print_signatures): Likewise.
1126 (trust_pad_over_xvs): Likewise.
1127 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1128 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1129 * arm-linux-nat.c (arm_apcs_32): Likewise.
1130 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1131 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1132 * arm-tdep.c (arm_debug): Likewise.
1133 (arm_apcs_32): Likewise.
1134 * auto-load.c (debug_auto_load): Likewise.
1135 (auto_load_gdb_scripts): Likewise.
1136 (global_auto_load): Likewise.
1137 (auto_load_local_gdbinit): Likewise.
1138 (auto_load_local_gdbinit_loaded): Likewise.
1139 * auto-load.h (global_auto_load): Likewise.
1140 (auto_load_local_gdbinit): Likewise.
1141 (auto_load_local_gdbinit_loaded): Likewise.
1142 * breakpoint.c (disconnected_dprintf): Likewise.
1143 (breakpoint_proceeded): Likewise.
1144 (automatic_hardware_breakpoints): Likewise.
1145 (always_inserted_mode): Likewise.
1146 (target_exact_watchpoints): Likewise.
1147 (_initialize_breakpoint): Update.
1148 * breakpoint.h (target_exact_watchpoints): Change to bool.
1149 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1150 * cli/cli-cmds.c (trace_commands): Likewise.
1151 * cli/cli-cmds.h (trace_commands): Likewise.
1152 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1153 to bool*.
1154 * cli/cli-logging.c (logging_overwrite): Change to bool.
1155 (logging_redirect): Likewise.
1156 (debug_redirect): Likewise.
1157 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1158 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1159 to bool.
1160 <boolean_option_def>: Update.
1161 (struct flag_option_def): Change default type of Context to bool
1162 from int.
1163 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1164 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1165 (get_setshow_command_value_string): Likewise.
1166 * cli/cli-style.c (cli_styling): Change to bool.
1167 (source_styling): Likewise.
1168 * cli/cli-style.h (source_styling): Likewise.
1169 (cli_styling): Likewise.
1170 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1171 to bool.
1172 * command.h (var_types): Update comment.
1173 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1174 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1175 bool.
1176 (debug_compile_cplus_scopes): Likewise.
1177 * compile/compile-internal.h (compile_debug): Likewise.
1178 * compile/compile.c (compile_debug): Likewise.
1179 (struct compile_options) <raw>: Likewise.
1180 * cp-support.c (catch_demangler_crashes): Likewise.
1181 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1182 (usr_cmd_cris_dwarf2_cfi): Likewise.
1183 * csky-tdep.c (csky_debug): Likewise.
1184 * darwin-nat.c (enable_mach_exceptions): Likewise.
1185 * dcache.c (dcache_enabled_p): Likewise.
1186 * defs.h (info_verbose): Likewise.
1187 * demangle.c (demangle): Likewise.
1188 (asm_demangle): Likewise.
1189 * dwarf-index-cache.c (debug_index_cache): Likewise.
1190 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1191 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1192 * dwarf2read.c (check_physname): Likewise.
1193 (use_deprecated_index_sections): Likewise.
1194 (dwarf_always_disassemble): Likewise.
1195 * eval.c (overload_resolution): Likewise.
1196 * event-top.c (set_editing_cmd_var): Likewise.
1197 (exec_done_display_p): Likewise.
1198 * event-top.h (set_editing_cmd_var): Likewise.
1199 (exec_done_display_p): Likewise.
1200 * exec.c (write_files): Likewise.
1201 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1202 (debug_fbsd_nat): Likewise.
1203 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1204 Likewise.
1205 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1206 <backtrace_past_entry> Likewise.
1207 * gdb-demangle.h (demangle): Likewise.
1208 (asm_demangle): Likewise.
1209 * gdb_bfd.c (bfd_sharing): Likewise.
1210 * gdbcore.h (write_files): Likewise.
1211 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1212 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1213 * gdbthread.h (print_thread_events): Likewise.
1214 * gdbtypes.c (opaque_type_resolution): Likewise.
1215 (strict_type_checking): Likewise.
1216 * gnu-nat.c (gnu_debug_flag): Likewise.
1217 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1218 * guile/scm-param.c (pascm_variable): Add boolval.
1219 (add_setshow_generic): Update.
1220 (pascm_param_value): Update.
1221 (pascm_set_param_value_x): Update.
1222 * hppa-tdep.c (hppa_debug): Change to bool..
1223 * infcall.c (may_call_functions_p): Likewise.
1224 (coerce_float_to_double_p): Likewise.
1225 (unwind_on_signal_p): Likewise.
1226 (unwind_on_terminating_exception_p): Likewise.
1227 * infcmd.c (startup_with_shell): Likewise.
1228 * inferior.c (print_inferior_events): Likewise.
1229 * inferior.h (startup_with_shell): Likewise.
1230 (print_inferior_events): Likewise.
1231 * infrun.c (step_stop_if_no_debug): Likewise.
1232 (detach_fork): Likewise.
1233 (debug_displaced): Likewise.
1234 (disable_randomization): Likewise.
1235 (non_stop): Likewise.
1236 (non_stop_1): Likewise.
1237 (observer_mode): Likewise.
1238 (observer_mode_1): Likewise.
1239 (set_observer_mode): Update.
1240 (sched_multi): Change to bool.
1241 * infrun.h (debug_displaced): Likewise.
1242 (sched_multi): Likewise.
1243 (step_stop_if_no_debug): Likewise.
1244 (non_stop): Likewise.
1245 (disable_randomization): Likewise.
1246 * linux-tdep.c (use_coredump_filter): Likewise.
1247 (dump_excluded_mappings): Likewise.
1248 * linux-thread-db.c (auto_load_thread_db): Likewise.
1249 (check_thread_db_on_load): Likewise.
1250 * main.c (captured_main_1): Update.
1251 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1252 xx2_opt, boolean_opt>: Change to bool.
1253 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1254 * maint.c (maintenance_profile_p): Likewise.
1255 (per_command_time): Likewise.
1256 (per_command_space): Likewise.
1257 (per_command_symtab): Likewise.
1258 * memattr.c (inaccessible_by_default): Likewise.
1259 * mi/mi-main.c (mi_async): Likewise.
1260 (mi_async_1): Likewise.
1261 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1262 * nat/fork-inferior.h (startup_with_shell): Likewise.
1263 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1264 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1265 * nios2-tdep.c (nios2_debug): Likewise.
1266 * or1k-tdep.c (or1k_debug): Likewise.
1267 * parse.c (parser_debug): Likewise.
1268 * parser-defs.h (parser_debug): Likewise.
1269 * printcmd.c (print_symbol_filename): Likewise.
1270 * proc-api.c (procfs_trace): Likewise.
1271 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1272 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1273 (set_parameter_value): Update.
1274 (add_setshow_generic): Update.
1275 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1276 to bool*.
1277 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1278 int*.
1279 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1280 * record-btrace.c (record_btrace_target::store_registers): Update.
1281 * record-full.c (record_full_memory_query): Change to bool.
1282 (record_full_stop_at_limit): Likewise.
1283 * record-full.h (record_full_memory_query): Likewise.
1284 * remote-notif.c (notif_debug): Likewise.
1285 * remote-notif.h (notif_debug): Likewise.
1286 * remote.c (use_range_stepping): Likewise.
1287 (interrupt_on_connect): Likewise.
1288 (remote_break): Likewise.
1289 * ser-tcp.c (tcp_auto_retry): Likewise.
1290 * ser-unix.c (serial_hwflow): Likewise.
1291 * skip.c (debug_skip): Likewise.
1292 * solib-aix.c (solib_aix_debug): Likewise.
1293 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1294 (spu_auto_flush_cache_p): Likewise.
1295 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1296 Likewise.
1297 (struct info_print_options) <quiet>: Likewise.
1298 * symfile-debug.c (debug_symfile): Likewise.
1299 * symfile.c (auto_solib_add): Likewise.
1300 (separate_debug_file_debug): Likewise.
1301 * symfile.h (auto_solib_add): Likewise.
1302 (separate_debug_file_debug): Likewise.
1303 * symtab.c (basenames_may_differ): Likewise.
1304 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1305 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1306 (struct info_types_options) <quiet>: Likewise.
1307 * symtab.h (demangle): Likewise.
1308 (basenames_may_differ): Likewise.
1309 * target-dcache.c (stack_cache_enabled_1): Likewise.
1310 (code_cache_enabled_1): Likewise.
1311 * target.c (trust_readonly): Likewise.
1312 (may_write_registers): Likewise.
1313 (may_write_memory): Likewise.
1314 (may_insert_breakpoints): Likewise.
1315 (may_insert_tracepoints): Likewise.
1316 (may_insert_fast_tracepoints): Likewise.
1317 (may_stop): Likewise.
1318 (auto_connect_native_target): Likewise.
1319 (target_stop_and_wait): Update.
1320 (target_async_permitted): Change to bool.
1321 (target_async_permitted_1): Likewise.
1322 (may_write_registers_1): Likewise.
1323 (may_write_memory_1): Likewise.
1324 (may_insert_breakpoints_1): Likewise.
1325 (may_insert_tracepoints_1): Likewise.
1326 (may_insert_fast_tracepoints_1): Likewise.
1327 (may_stop_1): Likewise.
1328 * target.h (target_async_permitted): Likewise.
1329 (may_write_registers): Likewise.
1330 (may_write_memory): Likewise.
1331 (may_insert_breakpoints): Likewise.
1332 (may_insert_tracepoints): Likewise.
1333 (may_insert_fast_tracepoints): Likewise.
1334 (may_stop): Likewise.
1335 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1336 (make_thread_apply_all_options_def_group): Change argument from int*
1337 to bool*.
1338 (thread_apply_all_command): Update.
1339 (print_thread_events): Change to bool.
1340 * top.c (confirm): Likewise.
1341 (command_editing_p): Likewise.
1342 (history_expansion_p): Likewise.
1343 (write_history_p): Likewise.
1344 (info_verbose): Likewise.
1345 * top.h (confirm): Likewise.
1346 (history_expansion_p): Likewise.
1347 * tracepoint.c (disconnected_tracing): Likewise.
1348 (circular_trace_buffer): Likewise.
1349 * typeprint.c (print_methods): Likewise.
1350 (print_typedefs): Likewise.
1351 * utils.c (debug_timestamp): Likewise.
1352 (sevenbit_strings): Likewise.
1353 (pagination_enabled): Likewise.
1354 * utils.h (sevenbit_strings): Likewise.
1355 (pagination_enabled): Likewise.
1356 * valops.c (overload_resolution): Likewise.
1357 * valprint.h (struct value_print_options) <prettyformat_arrays,
1358 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1359 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1360 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1361 Likewise.
1362 * windows-nat.c (new_console): Likewise.
1363 (cygwin_exceptions): Likewise.
1364 (new_group): Likewise.
1365 (debug_exec): Likewise.
1366 (debug_events): Likewise.
1367 (debug_memory): Likewise.
1368 (debug_exceptions): Likewise.
1369 (useshell): Likewise.
1370 * windows-tdep.c (maint_display_all_tib): Likewise.
1371 * xml-support.c (debug_xml): Likewise.
1372
f1b620e9
MG
13732019-09-17 Mike Gulick <mgulick@mathworks.com>
1374
1375 * source.c (prepare_path_for_appending): New function.
1376 (openp): Make use of new function.
1377 (find_and_open_source): Search for the compilation directory and
1378 source file as a relative path beneath the directory search path.
1379
67f3ed6a
AB
13802019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1381
1382 * source-cache.c (source_cache::get_line_charpos): Catch
1383 exceptions and return false, this matches the behaviour documented
1384 in the header file.
1385
74332189
JB
13862019-09-17 Joel Brobecker <brobecker@adacore.com>
1387
1388 * ada-tasks.c (info_task): Remove quoting of the task's name.
1389
f2f24aa9
CB
13902019-09-16 Christian Biesinger <cbiesinger@google.com>
1391
1392 * symfile.c (auto_solib_add): Replace comment with a reference
1393 to the header file.
1394
6a062a93
CB
13952019-09-14 Christian Biesinger <cbiesinger@google.com>
1396
1397 * NEWS: Mention that gdb can now be compiled with Python 3
1398 on Windows.
1399
ec6c8338
AB
14002019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1401
1402 * maint.c (maint_print_section_data::maint_print_section_data):
1403 Force use of 'float log10 (float)' by casting the argument to
1404 float.
1405
aa17805f
AB
14062019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1407
1408 * maint.c: Add 'cmath' include.
1409 (struct maint_print_section_data): New structure.
1410 (print_section_index): New function.
1411 (print_bfd_section_info): Add header comment, small whitespace
1412 cleanup, and update to call new print_section_index function.
1413 (print_objfile_section_info): Likewise.
1414 (maint_obj_section_from_bfd_section): New function.
1415 (print_bfd_section_info_maybe_relocated): New function.
1416 (maintenance_info_sections): Add header comment, always use
1417 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1418
3dd9bb46
AB
14192019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1420
1421 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1422 inner scope, add check that the objfile has psymtabs before
1423 checking psymtabs_addrmap.
1424 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1425
4993045d
PW
14262019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1427
1428 * NEWS: Announce that Ada task names are now shown at more places,
1429 and between quotes (except in info task output).
1430 * gdb/ada-tasks.c (task_to_str): New function.
1431 (display_current_task_id): Call task_to_str.
1432 (task_command_1): Likewise.
1433 (print_ada_task_info): In non-mi mode, Properly align headers and data
1434 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1435
7a289707
RO
14362019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1437
1438 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1439 prstatus.pr_lwp.pr_info instead of making it up.
1440
f2aec7f6
CB
14412019-09-11 Christian Biesinger <cbiesinger@google.com>
1442
1443 * auto-load.c (auto_load_expand_dir_vars): Update.
1444 * defs.h (gdb_datadir): Change to std::string.
1445 (python_libdir): Likewise.
1446 (relocate_gdb_directory): Change return type to std::string.
1447 * guile/guile.c (gdbscm_data_directory): Update.
1448 (initialize_scheme_side): Update.
1449 * jit.c (jit_reader_dir): Change to std::string.
1450 (jit_reader_load_command): Update.
1451 * main.c (gdb_datadir): Change to std::string.
1452 (python_libdir): Likewise.
1453 (set_gdb_data_directory): Update.
1454 (relocate_path): Change to return std::string.
1455 (relocate_gdb_directory): Change to return std::string.
1456 (relocate_gdbinit_path_maybe_in_datadir): Update.
1457 (captured_main_1): Update.
1458 * python/python.c (do_start_initialization): Update.
1459 * top.c (show_gdb_datadir): Update.
1460 * xml-syscall.c (xml_init_syscalls_info): Update.
1461 (init_syscalls_info): Update.
1462
9224a013
CB
14632019-09-11 Christian Biesinger <cbiesinger@google.com>
1464
1465 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1466 out of get_init_files.
1467 (get_init_files): Update.
1468
f48cd836
CB
14692019-09-11 Christian Biesinger <cbiesinger@google.com>
1470
1471 * main.c (get_init_files): Change to use std::string.
1472 (captured_main_1): Update.
1473 (print_gdb_help): Update.
1474
9cab7ecd
AT
14752019-09-11 Ali Tamur <tamur@google.com>
1476
1477 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1478 implementation.
1479
67547d89
CB
14802019-09-11 Christian Biesinger <cbiesinger@google.com>
1481
1482 * dbxread.c (read_dbx_symtab): Update.
1483 * dwarf2read.c (load_partial_dies): Update.
1484 * mdebugread.c (parse_partial_symbols): Update.
1485 (handle_psymbol_enumerators): Update.
1486 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1487 * psymtab.c (add_psymbol_to_bcache): Likewise.
1488 (add_psymbol_to_list): Likewise.
1489 * symtab.c (symbol_set_names): Likewise.
1490 * symtab.h (symbol_set_names): Likewise.
1491 * xcoffread.c (scan_xcoff_symtab): Update.
1492
64b2d4a0
TT
14932019-09-11 Tom Tromey <tom@tromey.com>
1494
1495 * symfile-mem.c (symbol_file_add_from_memory): Use
1496 bfd_set_filename.
1497 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1498 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1499
3b00ef10
TT
15002019-09-10 Tom Tromey <tromey@adacore.com>
1501
1502 * dwarf-index-write.c (write_psymbols): Extend error message.
1503 (debug_names::insert): Add Ada code.
1504 (debug_names::write_psymbols): Remove Ada check.
1505 (debug_names) <m_string_obstack>: New member.
1506 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1507 (gdb_index_symbol_name_matcher::matches): Remove.
1508 (mapped_index_base::find_name_components_bounds): Add "lang"
1509 parameter.
1510 (mapped_index_base::build_name_components): Also split names
1511 according to Ada syntax.
1512 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1513 type of "match_callback".
1514 (check_match, check_find_bounds_finds)
1515 (dw2_expand_symtabs_matching): Update.
1516 (dw2_debug_names_iterator): Add new constructor.
1517 (dw2_debug_names_map_matching_symbols): New function.
1518 (dw2_debug_names_expand_symtabs_matching): Update.
1519 (dwarf2_debug_names_functions): Use
1520 dw2_debug_names_map_matching_symbols.
1521
aa391654
TT
15222019-09-10 Tom Tromey <tromey@adacore.com>
1523
1524 * dwarf2read.c (dw2_get_file_names_reader): Add the
1525 CU's file name to the results.
1526
b054970d
TT
15272019-09-10 Tom Tromey <tromey@adacore.com>
1528
1529 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1530 map_matching_symbols. Update.
1531 * dwarf2read.c (dw2_map_matching_symbols): Update.
1532 * psymtab.c (match_partial_symbol): Change type; update.
1533 (psym_map_matching_symbols): Likewise.
1534 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1535 type; update.
1536 * symfile.h (struct quick_symbol_functions)
1537 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1538 Remove "match".
1539
6a3dbf1b
TT
15402019-09-10 Tom Tromey <tromey@adacore.com>
1541
1542 * psymtab.c (map_block): Remove.
1543 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1544 * symtab.c (iterate_over_symbols_terminated): New function.
1545 * symtab.c (iterate_over_symbols_terminated): Declare.
1546
6969f124
TT
15472019-09-10 Tom Tromey <tromey@adacore.com>
1548
1549 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1550 * language.h (struct language_defn) <la_iterate_over_symbols>:
1551 Return bool.
1552 * symtab.c (iterate_over_symbols): Return bool.
1553 * symtab.h (iterate_over_symbols): Return bool.
1554
199b4314
TT
15552019-09-10 Tom Tromey <tromey@adacore.com>
1556
1557 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1558 (add_nonlocal_symbols): Update.
1559 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1560 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1561 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1562 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1563 Change type of "callback". Remove "data".
1564
a084a2a6
AT
1565
15662019-09-09 Ali Tamur <tamur@google.com>
1567
1568 * dwarf2read.c (comp_unit_head): Update comment.
1569 (dwarf2_dwo_name): New function declaration.
1570 (dwarf_unit_type_name): New function declaration.
1571 (read_comp_unit_head): Add support for new compilation units,
1572 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1573 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1574 (currently named as "signature") in their header. Also clarify error
1575 messages.
1576 (lookup_dwo_id): New function. Returns the dwo id of the given
1577 compile unit.
1578 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1579 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1580 functions.
1581 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1582 (dwarf2_dwo_name): Get the dwo name if present.
1583 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1584 purposes.
1585
25a2915e
TT
15862019-09-09 Tom Tromey <tom@tromey.com>
1587
1588 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1589
e4df0874
PW
15902019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1591
1592 * python/python.c (do_start_initialization): Make progname_copy static,
1593 to avoid a leak report.
1594
8634b462
TT
15952019-09-08 Tom Tromey <tom@tromey.com>
1596
1597 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1598
c7f839cb
SM
15992019-09-07 Simon Marchi <simon.marchi@efficios.com>
1600
1601 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1602 Change type to gdb::optional<block_enum>.
1603 (dw2_symtab_iter_init): Change block_index parameter type
1604 to gdb::optional<block_enum>.
1605 (dw2_lookup_symbol): Change block_index parameter
1606 type to block_enum.c
1607 (dw2_debug_names_lookup_symbol): Likewise.
1608 * psymtab.c (psym_lookup_symbol): Likewise.
1609 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1610 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1611 Likewise.
1612
ead0e69a
CB
16132019-09-06 Christian Biesinger <cbiesinger@google.com>
1614
1615 * defs.h (relocate_gdb_directory): Change int to bool in
1616 signature and rename flag to relocatable.
1617 * main.c (relocate_path): Likewise.
1618 (relocate_gdb_directory): Likewise.
1619
b16c44de
AM
16202019-09-06 Alan Modra <amodra@gmail.com>
1621
1622 * coffread.c (coff_symfile_read): Constify filename variable.
1623 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1624 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1625 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1626 * solib.c (reload_shared_libraries_1): Likewise.
1627 * symfile.c (reread_symbols): Likewise.
1628 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1629 * solib-darwin.c (darwin_bfd_open): Likewise.
1630 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1631
06ff036e
AB
16322019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1633
1634 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1635 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1636
4e962e74
TT
16372019-09-03 Tom Tromey <tromey@adacore.com>
1638
1639 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1640 types.
1641 (has_negatives): Unbias a range type bound.
1642 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1643 * gdbtypes.c (operator==): Handle new field.
1644 (create_range_type): Add "bias" parameter.
1645 (create_static_range_type, resolve_dynamic_range): Update.
1646 * gdbtypes.h (struct range_bounds) <bias>: New member.
1647 (create_range_type): Add bias parameter.
1648 * printcmd.c (print_scalar_formatted): Unbias range types.
1649 * value.c (unpack_long): Unbias range types.
1650 (pack_long): Bias range types.
1651
d90b8f26
AH
16522019-09-02 Alan Hayward <alan.hayward@arm.com>
1653
1654 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1655 probe arguments.
1656
fe01123e
AH
16572019-09-02 Alan Hayward <alan.hayward@arm.com>
1658
1659 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1660 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1661 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1662 (compile_probe_arg): Likewise.
1663 * probe.h (get_argument_count): Likewise.
1664 * solib-svr4.c (solib_event_probe_action): Likewise.
1665 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1666
e661ef01
AH
16672019-09-02 Alan Hayward <alan.hayward@arm.com>
1668
1669 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1670 code to here...
1671 (svr4_create_solib_event_breakpoints): ...from here.
1672
47a536d9
SDJ
16732019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1674
1675 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1676 suffix from warning message.
1677
d6a00eba
TT
16782019-08-30 Tom Tromey <tom@tromey.com>
1679
1680 * tui/tui-winsource.h (struct tui_source_window_base)
1681 <refresh_all>: Don't declare.
1682 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1683 Remove.
1684 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1685 tui_show_locator_content.
1686 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1687 declare.
1688 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1689 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1690 declare.
1691
55b2657b
TT
16922019-08-30 Tom Tromey <tom@tromey.com>
1693
1694 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1695
12a8555a
TT
16962019-08-30 Tom Tromey <tom@tromey.com>
1697
1698 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1699 Remove unnecessary forward declarations.
1700
900ac242
TT
17012019-08-30 Tom Tromey <tom@tromey.com>
1702
1703 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1704 rerender.
1705 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1706 tui_show_locator_content.
1707
99ab33fb
TT
17082019-08-30 Tom Tromey <tom@tromey.com>
1709
1710 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1711 (tui_locator_window::rerender): Rewrite using body of previous
1712 tui_show_locator_content.
1713
e594a5d1
TT
17142019-08-30 Tom Tromey <tom@tromey.com>
1715
1716 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1717 set_locator_fullname>: New methods.
1718 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1719 Rename from tui_set_locator_fullname.
1720 (tui_locator_window::set_locator_info): Rename from
1721 tui_set_locator_info. Return bool.
1722 (tui_update_locator_fullname, tui_show_frame_info): Update.
1723
715bb467
TT
17242019-08-30 Tom Tromey <tom@tromey.com>
1725
1726 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1727
772f3f03
TT
17282019-08-30 Tom Tromey <tom@tromey.com>
1729
1730 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1731 call touchwin.
1732
108e13ab
TT
17332019-08-30 Tom Tromey <tom@tromey.com>
1734
1735 * tui/tui-wingeneral.c (box_win): Assume win_info and
1736 win_info->handle cannot be NULL.
1737
cdaa6eb4
TT
17382019-08-30 Tom Tromey <tom@tromey.com>
1739
1740 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1741 refresh_window>: Declare.
1742 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1743 resize.
1744 (tui_data_item_window::rerender): Rename from
1745 tui_display_register.
1746 (tui_data_item_window::refresh_window): New method.
1747 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1748 no-op.
1749
89df7f90
TT
17502019-08-30 Tom Tromey <tom@tromey.com>
1751
1752 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1753 regs_column_count, current_group>: Move later. Now private.
1754 <get_current_group>: New method.
1755 * tui/tui-regs.c (tui_reg_command): Update.
1756 * tui/tui-layout.c (tui_set_layout): Update.
1757
1bf2866a
TT
17582019-08-30 Tom Tromey <tom@tromey.com>
1759
1760 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1761 (tui_data_window::rerender): Don't call
1762 check_and_display_highlight_if_needed.
1763 (tui_data_window::refresh_all): Remove call to
1764 erase_data_content.
1765
0670413d
TT
17662019-08-30 Tom Tromey <tom@tromey.com>
1767
1768 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1769 (tui_data_window::display_registers_from)
1770 (tui_data_window::display_reg_element_at_line)
1771 (tui_data_window::display_registers_from_line): Remove checks of
1772 "empty".
1773
18bb55c7
TT
17742019-08-30 Tom Tromey <tom@tromey.com>
1775
1776 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1777 Don't declare.
1778 * tui/tui-regs.c (tui_data_window::show_registers): Call
1779 rerender.
1780 (tui_data_window::rerender): Rename from display_all_data.
1781 (tui_data_window::rerender): Remove old implementation.
1782
1f6d2f10
TT
17832019-08-30 Tom Tromey <tom@tromey.com>
1784
1785 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1786 text.
1787 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1788
16d01f9c
BW
17892019-08-29 Bernhard Wodok <barto@gmx.net>
1790 Sergio Durigan Junior <sergiodj@redhat.com>
1791
1792 PR win32/24284
1793 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1794
d8f27c60
AB
17952019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1796
1797 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1798 when searching for types.
1799
1f20c35e
AB
18002019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1801
1802 * f-lang.c (f_language_defn): Use f_print_typedef.
1803 * f-lang.h (f_print_typedef): Declare.
1804 * f-typeprint.c (f_print_typedef): Define.
1805
550105b7
CB
18062019-08-27 Christian Biesinger <cbiesinger@google.com>
1807
1808 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1809
4acfdd20
AB
18102019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1811
1812 * cli/cli-utils.c (info_print_options_defs): Delete.
1813 (make_info_print_options_def_group): Delete.
1814 (extract_info_print_options): Delete.
1815 (info_print_command_completer): Delete.
1816 (info_print_args_help): Add extra parameter, and optionally
1817 include text about -n flag.
1818 * cli/cli-utils.h (struct info_print_options): Delete.
1819 (extract_info_print_options): Delete declaration.
1820 (info_print_command_completer): Delete declaration.
1821 (info_print_args_help): Add extra parameter, extend header
1822 comment.
1823 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1824 search_symbols.
1825 * stack.c (struct info_print_options): New type.
1826 (info_print_options_defs): New file scoped variable.
1827 (make_info_print_options_def_group): New static function.
1828 (info_print_command_completer): New static function.
1829 (info_locals_command): Update to use new local functions.
1830 (info_args_command): Likewise.
1831 (_initialize_stack): Add extra parameter to calls to
1832 info_print_args_help.
1833 * symtab.c (search_symbols): Add extra parameter, use this to
1834 possibly excluse non-debug symbols.
1835 (symtab_symbol_info): Add extra parameter, which is passed on to
1836 search_symbols.
1837 (struct info_print_options): New type.
1838 (info_print_options_defs): New file scoped variable.
1839 (make_info_print_options_def_group): New static function.
1840 (info_print_command_completer): New static function.
1841 (info_variables_command): Update to use local functions, and pass
1842 extra parameter through to symtab_symbol_info.
1843 (info_functions_command): Likewise.
1844 (info_types_command): Pass additional argument through to
1845 symtab_symbol_info.
1846 (rbreak_command): Pass extra argument to search_symbols.
1847 (_initialize_symtab): Add extra arguments for calls to
1848 info_print_args_help, and update help text for 'info variables',
1849 'whereis', and 'info functions' commands.
1850 * symtab.h (search_symbols): Add extra argument to declaration.
1851 * NEWS: Mention new flags.
1852
9aa55206
CB
18532019-08-26 Christian Biesinger <cbiesinger@google.com>
1854
1855 * symtab.c (lookup_static_symbol): Call the new function (and move
1856 it down to be next to lookup_global_symbol).
1857 (struct global_sym_lookup_data): Add block_enum member and rename to...
1858 (struct global_or_static_sym_lookup_data): ...this.
1859 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1860 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1861 (lookup_symbol_global_or_static_iterator_cb): ...this.
1862 (lookup_global_or_static_symbol): New function.
1863 (lookup_global_symbol): Call new function.
1864
5c31b358
TV
18652019-08-26 Tom de Vries <tdevries@suse.de>
1866
1867 PR c++/24852
1868 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1869 when pc_probe.prob == NULL.
1870
23c13d42
SM
18712019-08-25 Simon Marchi <simon.marchi@efficios.com>
1872
1873 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1874 variable symbol_linkage to symbol_linkage_.
1875
beadd3e8
SM
18762019-08-25 Simon Marchi <simon.marchi@efficios.com>
1877
1878 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1879 represent whether the symbol is static, dynamic, or we don't
1880 know.
1881
e3ec872f
YS
18822019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1883
1884 * gdb/rx-tdep.c (rx_register_names): New.
1885 (rx_register_name): Delete.
1886 (rx_psw_type): Delete.
1887 (rx_fpsw_type): Delete.
1888 (rx_register_type): Delete.
1889 (rx_gdbarch_init): Convert target-descriptions.
1890 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1891 * gdb/features/Makefile: Add rx.xml.
1892 * gdb/features/rx.xml: New.
1893 * gdb/features/rx.c: Generated.
1894 * gdb/NEWS: Mention target description support.
1895
d0509ba4
CB
18962019-08-22 Christian Biesinger <cbiesinger@google.com>
1897
1898 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1899 *slot_ptr.
1900
2d41fa11
SDJ
19012019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1902
1903 * configure.ac: Don't check for 'dlfcn.h' (moved to
1904 gdbsupport/common.m4).
1905 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1906 'gdbsupport/'.
1907 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1908 * compile/compile-c-support.c: Include
1909 'gdbsupport/gdb-dlfcn.h'.
1910 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1911 * gdb-dlfcn.c: Move to...
1912 * gdbsupport/gdb-dlfcn.c: ... here.
1913 * gdb-dlfcn.h: Move to...
1914 * gdbsupport/gdb-dlfcn.h: ... here.
1915
de8af808
SL
19162019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1917
1918 * nios2-tdep.c (struct reg_value): Improve comments. Make
1919 the offset field signed.
1920
27204489
CB
19212019-08-22 Christian Biesinger <cbiesinger@google.com>
1922
1923 * python/lib/gdb/__init__.py (_execute_file): New function.
1924 * python/python.c (python_run_simple_file): Call gdb._execute_file
1925 on Windows.
1926
43771869
AB
19272019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1928
1929 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1930 all uses as this was never set to anything but a zero value.
1931
26c957f1
PA
19322019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1933
1934 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1935
c07aae6e
CB
19362019-08-21 Christian Biesinger <cbiesinger@google.com>
1937
1938 * tui/tui-data.h (tui_gen_win_info): Add an =default
1939 move constructor, required by some GCC versions.
1940
3960cb7a
JF
19412019-08-21 Jinke Fan <fanjinke51@yeah.net>
1942
1943 * go32-nat.c (go32_sysinfo): Add hygon_p.
1944
04c72a68
TT
19452019-08-20 Tom Tromey <tom@tromey.com>
1946
1947 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1948 line_from_reg_element_no, first_reg_element_no_inline,
1949 display_all_data, delete_data_content_windows,
1950 erase_data_content>: Now private.
1951
072272ce
TT
19522019-08-20 Tom Tromey <tom@tromey.com>
1953
1954 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1955 (tui_unhighlight_win, tui_highlight_win)
1956 (tui_win_info::make_window): Update.
1957 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1958
973961bd
TT
19592019-08-20 Tom Tromey <tom@tromey.com>
1960
1961 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1962 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1963 (MAX_PID_WIDTH): Move to tui-stack.c.
1964 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1965 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1966 (MAX_PID_WIDTH): Move from tui-data.h.
1967
ab0e1f1a
TT
19682019-08-20 Tom Tromey <tom@tromey.com>
1969
1970 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1971 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1972 (box_win): Update.
1973 (tui_gen_win_info::make_window): Rename from tui_make_window.
1974 (tui_win_info::make_window): New method.
1975 (tui_gen_win_info::make_visible): Update.
1976 * tui/tui-source.c (tui_source_window::set_contents): Update.
1977 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1978 (tui_data_window::display_registers_from): Update.
1979 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1980 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1981 Declare.
1982 <can_box>: Remove.
1983 <title>: Remove.
1984 (struct tui_win_info) <make_window>: Declare.
1985 <can_box>: Now virtual.
1986 <title>: New member.
1987 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1988 * tui/tui-command.c (tui_cmd_window::resize): Update.
1989
100c2bf3
TT
19902019-08-20 Tom Tromey <tom@tromey.com>
1991
1992 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1993 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1994 (tui_data_window::check_register_values): Update.
1995
fa4dc567
TT
19962019-08-20 Tom Tromey <tom@tromey.com>
1997
1998 * tui/tui-regs.h (struct tui_data_window): Use
1999 DISABLE_COPY_AND_ASSIGN.
2000 <regs_content>: Change type, removing unique_ptr.
2001 <tui_data_window>: Add move constructor.
2002 * tui/tui-regs.c (tui_data_window::show_registers)
2003 (tui_data_window::show_register_group)
2004 (tui_data_window::display_registers_from)
2005 (tui_data_window::display_registers_from)
2006 (tui_data_window::first_data_item_displayed)
2007 (tui_data_window::delete_data_content_windows)
2008 (tui_data_window::rerender, tui_data_window::refresh_window)
2009 (tui_data_window::check_register_values): Update.
2010
ca02d7c8
TT
20112019-08-20 Tom Tromey <tom@tromey.com>
2012
2013 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2014 show_register_group>: Declare.
2015 (tui_show_register_group): Don't declare.
2016 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2017 tui_show_registers.
2018 (tui_data_window::show_register_group): Rename from
2019 tui_show_register_group.
2020 (tui_data_window::check_register_values, tui_reg_command):
2021 Update.
2022 * tui/tui-layout.c (tui_set_layout): Update.
2023
63356bfd
TT
20242019-08-20 Tom Tromey <tom@tromey.com>
2025
2026 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2027 Declare.
2028 (tui_check_register_values): Don't declare.
2029 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2030 from tui_check_register_values.
2031 * tui/tui-hooks.c (tui_register_changed): Update.
2032
42cc14a7
TT
20332019-08-20 Tom Tromey <tom@tromey.com>
2034
2035 * tui/tui-regs.c (tui_reg_layout): Move later.
2036 (tui_show_registers): Don't enable TUI mode or change layout.
2037
b9ad3686
TT
20382019-08-20 Tom Tromey <tom@tromey.com>
2039
2040 * tui/tui-regs.h (struct tui_data_item_window)
2041 <~tui_data_item_window>: Remove.
2042 <content>: Now a unique_xmalloc_ptr.
2043 * tui/tui-regs.c (tui_register_format): Return a
2044 unique_xmalloc_ptr.
2045 (tui_get_register): Update.
2046 (~tui_data_item_window): Remove.
2047 (tui_data_window::display_registers_from, tui_display_register):
2048 Update.
2049 * tui/tui-io.h (tui_expand_tabs): Update.
2050 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2051 Remove "col" parameter.
2052
8e114aab
TT
20532019-08-20 Tom Tromey <tom@tromey.com>
2054
2055 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2056 field.
2057 * tui/tui-regs.c (~tui_data_item_window): Update.
2058
1a4f81dd
TT
20592019-08-20 Tom Tromey <tom@tromey.com>
2060
2061 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2062 earlier.
2063
0f8d8876
TT
20642019-08-20 Tom Tromey <tom@tromey.com>
2065
2066 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2067
605dc2c2
TT
20682019-08-20 Tom Tromey <tom@tromey.com>
2069
2070 * tui/tui-source.h (struct tui_source_window): Update.
2071 * tui/tui-regs.c (tui_show_registers): Update.
2072 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2073 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2074 (NO_REGS_STRING): Remove defines.
2075
aedbe3bb
CM
20762019-08-20 Conrad Meyer <cem@FreeBSD.org>
2077
2078 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2079 unnecessary thread walk if remote doesn't support the packet.
2080
7ce8f214
TT
20812019-08-19 Tom Tromey <tromey@adacore.com>
2082
2083 * python/py-value.c (value_has_field): Fix indentation.
2084
f21c2bd7
TT
20852019-08-19 Tom Tromey <tromey@adacore.com>
2086
2087 * printcmd.c (do_one_display, info_display_command): Update.
2088 * block.h (contained_in): Return bool. Add allow_nested
2089 parameter.
2090 * block.c (contained_in): Return bool. Add allow_nested
2091 parameter.
2092
d806ea2d
TT
20932019-08-19 Tom Tromey <tom@tromey.com>
2094
2095 * configure: Rebuild.
2096 * configure.ac: Disallow the combination of -static-libstdc++ and
2097 source highlight.
2098 * source-cache.c (get_language_name): Handle rust.
2099 (source_cache::get_source_lines): Ignore highlighting exceptions.
2100
398fdd60
TT
21012019-08-16 Tom Tromey <tom@tromey.com>
2102
2103 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2104 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2105 (struct tui_source_window_base) <make_visible, refresh_window,
2106 resize>: Remove methods.
2107 <execution_info>: Remove field.
2108 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2109 (tui_show_source_line, tui_source_window_base)
2110 (~tui_source_window_base): Update.
2111 (tui_source_window_base::resize)
2112 (tui_source_window_base::make_visible)
2113 (tui_source_window_base::refresh_window): Remove.
2114 (tui_source_window_base::update_exec_info): Update.
2115 * tui/tui-source.c (tui_source_window::set_contents): Update.
2116 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2117
e699d331
TT
21182019-08-16 Tom Tromey <tom@tromey.com>
2119
2120 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2121 deprecated_query_hook.
2122
bb01dbfc
TT
21232019-08-16 Tom Tromey <tom@tromey.com>
2124
2125 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2126 (tui_update_source_windows_with_line): Update.
2127 * tui/tui-source.h (struct tui_source_window)
2128 <show_symtab_source>: Declare.
2129 (tui_show_symtab_source): Don't declare.
2130 * tui/tui-source.c (tui_show_symtab_source): Rename from
2131 tui_show_symtab_source.
2132
81c82c4b
TT
21332019-08-16 Tom Tromey <tom@tromey.com>
2134
2135 * tui/tui-winsource.h (struct tui_source_window_base)
2136 <set_contents>: Declare.
2137 * tui/tui-winsource.c
2138 (tui_source_window_base::update_source_window_as_is): Update.
2139 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2140 Declare.
2141 (tui_set_source_content): Don't declare.
2142 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2143 tui_set_source_content.
2144 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2145 Declare.
2146 (tui_set_disassem_content): Don't declare.
2147 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2148 tui_set_disassem_content.
2149
2ddaf614
TT
21502019-08-16 Tom Tromey <tom@tromey.com>
2151
2152 * tui/tui-winsource.h (struct tui_source_window_base)
2153 <update_breakpoint_info>: Declare.
2154 (tui_update_breakpoint_info): Don't declare.
2155 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2156 (tui_update_all_breakpoint_info): Update.
2157 (tui_source_window_base::update_breakpoint_info): Rename from
2158 tui_update_breakpoint_info.
2159 (tui_source_window_base::update_exec_info): Update.
2160
017f9828
TT
21612019-08-16 Tom Tromey <tom@tromey.com>
2162
2163 * tui/tui-winsource.h (struct tui_source_window_base)
2164 <update_source_window>: Declare.
2165 (tui_update_source_window): Don't declare.
2166 * tui/tui-winsource.c
2167 (tui_source_window_base::update_source_window): Rename from
2168 tui_update_source_window.
2169 (tui_source_window_base::rerender): Update.
2170 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2171 * tui/tui-disasm.c (tui_show_disassem)
2172 (tui_show_disassem_and_update_source)
2173 (tui_disasm_window::maybe_update): Update.
2174
ed8358e9
TT
21752019-08-16 Tom Tromey <tom@tromey.com>
2176
2177 * tui/tui-winsource.h (struct tui_source_window_base)
2178 <update_source_window_as_is>: Declare.
2179 (tui_update_source_window_as_is): Don't declare.
2180 * tui/tui-winsource.c (tui_update_source_window): Update
2181 (tui_source_window_base::update_source_window_as_is): Rename from
2182 tui_update_source_window_as_is.
2183 (tui_source_window_base::refill): Update.
2184 * tui/tui-source.c (tui_show_symtab_source): Update.
2185 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2186 Update.
2187
20149b6b
TT
21882019-08-16 Tom Tromey <tom@tromey.com>
2189
2190 * tui/tui-winsource.h (tui_update_source_window)
2191 (tui_update_source_window_as_is): Remove "noerror" parameter.
2192 * tui/tui-winsource.c (tui_update_source_window)
2193 (tui_update_source_window_as_is): Remove "noerror" parameter.
2194 (tui_update_source_windows_with_addr)
2195 (tui_update_source_windows_with_line)
2196 (tui_source_window_base::rerender)
2197 (tui_source_window_base::refill): Update.
2198 * tui/tui-source.h (tui_set_source_content)
2199 (tui_show_symtab_source): Remove "noerror" parameter.
2200 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2201 parameter.
2202 (tui_show_symtab_source): Likewise.
2203 (tui_source_window::maybe_update): Update.
2204 * tui/tui-disasm.c (tui_show_disassem)
2205 (tui_show_disassem_and_update_source)
2206 (tui_disasm_window::do_scroll_vertical)
2207 (tui_disasm_window::maybe_update): Update.
2208
2d83e710
TT
22092019-08-16 Tom Tromey <tom@tromey.com>
2210
2211 * tui/tui.c (tui_is_window_visible): Update.
2212 * tui/tui-wingeneral.c (tui_make_window)
2213 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2214 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2215 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2216 (tui_set_win_height_command, parse_scrolling_args): Update.
2217 * tui/tui-source.c (tui_source_window::style_changed): Update.
2218 * tui/tui-regs.c (tui_show_registers)
2219 (tui_data_window::first_data_item_displayed)
2220 (tui_data_window::delete_data_content_windows)
2221 (tui_check_register_values, tui_reg_command): Update.
2222 * tui/tui-disasm.c (tui_show_disassem): Update.
2223 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2224 method.
2225 <is_visible>: Remove field.
2226 * tui/tui-data.c (tui_next_win, tui_prev_win)
2227 (tui_delete_invisible_windows): Update.
2228
d4ab829a
TT
22292019-08-16 Tom Tromey <tom@tromey.com>
2230
2231 * tui/tui-winsource.h (struct tui_source_window_base)
2232 <m_has_locator>: Remove.
2233 * tui/tui-layout.c (show_source_disasm_command, show_data)
2234 (show_source_or_disasm_and_command): Update.
2235
aa7ca1bb
AH
22362019-08-16 Alan Hayward <alan.hayward@arm.com>
2237
2238 * NEWS (Other MI changes): New subsection.
2239 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2240 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2241 * arch-utils.c (default_get_pc_address_flags): New function.
2242 * arch-utils.h (default_get_pc_address_flags): New declaration.
2243 * gdbarch.sh: Add get_pc_address_flags.
2244 * gdbarch.c: Regenerate.
2245 * gdbarch.h: Likewise.
2246 * stack.c (print_pc): New function.
2247 (print_frame_info) (print_frame): Call print_pc.
2248
6eac171f
TV
22492019-08-16 Tom de Vries <tdevries@suse.de>
2250
2251 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2252 print_objfile_section_info.
2253
3df505f6
TT
22542019-08-15 Tom Tromey <tom@tromey.com>
2255
2256 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2257 calling update_cmdwin_start_line.
2258 * tui/tui-winsource.h (struct tui_source_window_base)
2259 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2260 <rerender>: Declare.
2261 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2262 Call rerender.
2263 (tui_source_window_base::set_new_height): Remove.
2264 (tui_source_window_base::rerender): Rename from
2265 do_make_visible_with_new_height.
2266 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2267 resize method.
2268 (tui_win_info::make_invisible_and_set_new_height)
2269 (tui_win_info::make_visible_with_new_height): Remove.
2270 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2271 Declare.
2272 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2273 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2274 do_make_visible_with_new_height>: Don't declare.
2275 <rerender>: Declare.
2276 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2277 set_new_height.
2278 (tui_data_window::do_make_visible_with_new_height): Remove.
2279 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2280 call tui_show_locator_content.
2281 (tui_gen_win_info::resize): Call rerender.
2282 (show_source_or_disasm_and_command): Don't call
2283 tui_show_locator_content.
2284 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2285 method.
2286 (struct tui_win_info) <rerender>: Declare.
2287 <set_new_height, make_invisible_and_set_new_height,
2288 make_visible_with_new_height>: Don't declare.
2289 * tui/tui-data.c (tui_win_list::rerender): New method.
2290 * tui/tui-command.h (struct tui_cmd_window)
2291 <do_make_visible_with_new_height>: Don't declare.
2292 * tui/tui-command.c
2293 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2294
272560b5
TT
22952019-08-15 Tom Tromey <tromey@adacore.com>
2296
2297 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2298 * ada-lang.c (ada_enum_name): Likewise.
2299
08235187
CB
23002019-08-15 Christian Biesinger <cbiesinger@google.com>
2301
2302 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2303 leading underscore.
2304 (GdbOutputErrorFile): Likewise.
2305 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2306 accordingly.
2307 (execute_unwinders): Rename to have a leading underscore.
2308 (auto_load_packages): Likewise.
2309 (global scope): Adjust call to auto_load_packages accordingly.
2310 (GdbSetPythonDirectory): Likewise.
2311 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2312 instead of execute_unwinders.
2313
db502012
TT
23142019-08-15 Tom Tromey <tom@tromey.com>
2315
2316 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2317 (show_data): Don't change window visibility.
2318 (tui_gen_win_info::resize): Remove special case for command
2319 window. Use wresize, when available.
2320 (show_source_or_disasm_and_command): Don't change window
2321 visibility.
2322 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2323 <make_visible>: New method.
2324 * tui/tui-command.c (tui_cmd_window::resize): New method.
2325
3891b65e
TT
23262019-08-15 Tom Tromey <tom@tromey.com>
2327
2328 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2329 (struct tui_source_windows): New.
2330 * tui/tui-winsource.c (tui_display_main): Update.
2331 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2332 (new_height_ok, parse_scrolling_args): Update.
2333 * tui/tui-layout.c (show_layout, show_data): Update.
2334 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2335 (tui_add_to_source_windows): Don't declare.
2336 * tui/tui-data.c (source_windows, tui_source_windows)
2337 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2338
ee556432
TT
23392019-08-15 Tom Tromey <tom@tromey.com>
2340
2341 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2342 Rename from reset.
2343 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2344 * tui/tui-layout.c (show_source_disasm_command, show_data):
2345 Update.
2346 (tui_gen_win_info::resize): Rename.
2347 (show_source_or_disasm_and_command): Update.
2348 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2349 reset.
2350
46f438e3
TT
23512019-08-15 Tom Tromey <tom@tromey.com>
2352
2353 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2354 * tui/tui-interp.c (tui_interp::init): Don't call
2355 tui_initialize_static_data.
2356 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2357
f4ce562c
TT
23582019-08-15 Tom Tromey <tom@tromey.com>
2359
2360 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2361 examine tui_win_list.
2362
c398c3d0
TT
23632019-08-15 Tom Tromey <tom@tromey.com>
2364
2365 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2366 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2367 tui_clear_source_content.
2368 (tui_clear_source_content): Remove.
2369 (tui_source_window_base::do_erase_source_content): Hoist call to
2370 content.clear().
2371 * tui/tui-stack.c (tui_show_frame_info): Don't call
2372 tui_clear_source_content.
2373
e25d2004
TT
23742019-08-15 Tom Tromey <tom@tromey.com>
2375
2376 * tui/tui-winsource.h (struct tui_source_window_base)
2377 <do_erase_source_content>: New method.
2378 <erase_source_content>: New method.
2379 (tui_erase_source_content): Don't declare.
2380 * tui/tui-winsource.c (tui_clear_source_content): Update.
2381 (tui_source_window_base::do_erase_source_content): Rename from
2382 tui_erase_source_content.
2383 (tui_source_window_base::show_source_content): Update.
2384 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2385 * tui/tui-source.h (struct tui_source_window)
2386 <erase_source_content>: New method.
2387 * tui/tui-disasm.h (struct tui_disasm_window)
2388 <erase_source_content>: New method.
2389
002f15c2
TT
23902019-08-15 Tom Tromey <tom@tromey.com>
2391
2392 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2393 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2394 constructor.
2395 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2396 * tui/tui-source.c (tui_set_source_content): Update.
2397 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2398
c9033fe8
TT
23992019-08-15 Tom Tromey <tom@tromey.com>
2400
2401 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2402 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2403 tui-source.c.
2404 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2405 Declare.
2406 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2407 method.
2408 (tui_source_window::maybe_update): Update.
2409
088f37dd
TT
24102019-08-15 Tom Tromey <tom@tromey.com>
2411
2412 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2413 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2414 tui-disasm.c.
2415 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2416 Declare.
2417 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2418 method.
2419 (tui_disasm_window::maybe_update): Update.
2420
a54700c6
TT
24212019-08-15 Tom Tromey <tom@tromey.com>
2422
2423 * tui/tui-winsource.h (struct tui_source_window_base)
2424 <maybe_update>: Declare.
2425 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2426 method.
2427 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2428 Declare.
2429 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2430 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2431 Declare.
2432 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2433
e2a678a5
TT
24342019-08-15 Tom Tromey <tom@tromey.com>
2435
2436 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2437
f2dda477
TT
24382019-08-15 Tom Tromey <tom@tromey.com>
2439
2440 * tui/tui-wingeneral.c: Include tui-stack.h.
2441 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2442 (struct tui_locator_window): Move from tui-data.h.
2443 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2444 (tui_initialize_static_data): Move from tui-data.c.
2445 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2446 (struct tui_locator_window): Move to tui-stack.c.
2447 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2448 (tui_initialize_static_data): Move to tui-stack.c.
2449
ed4a1084
TT
24502019-08-15 Tom Tromey <tom@tromey.com>
2451
2452 * tui/tui-layout.c (show_source_disasm_command)
2453 (show_source_or_disasm_and_command): Use make_visible method, not
2454 tui_make_window.
2455 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2456 Remove.
2457
65962b20
TT
24582019-08-15 Tom Tromey <tom@tromey.com>
2459
2460 * tui/tui-wingeneral.h (tui_make_window): Update.
2461 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2462 parameter.
2463 (tui_gen_win_info::make_visible): Update.
2464 * tui/tui-regs.c (tui_data_window::display_registers_from):
2465 Update.
2466 * tui/tui-layout.c (show_source_disasm_command)
2467 (show_source_or_disasm_and_command): Update.
2468 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2469 (enum tui_box): Remove.
2470 (struct tui_win_info) <can_box>: New method.
2471 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2472 method.
2473
2208ee91
TV
24742019-08-15 Tom de Vries <tdevries@suse.de>
2475
2476 * linux-nat-trad.c: Include gdbarch.h.
2477
75faf5c4
AH
24782019-08-14 Alan Hayward <alan.hayward@arm.com>
2479
2480 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2481 register sizes.
2482
b1c896b3
TT
24832019-08-14 Tom Tromey <tromey@adacore.com>
2484
2485 * darwin-nat.c: Include gdbarch.h.
2486 * darwin-nat-info.c: Include gdbarch.h.
2487
6405cd73
TT
24882019-08-13 Tom Tromey <tom@tromey.com>
2489
2490 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2491 Remove.
2492 * tui/tui-data.c (tui_initialize_static_data): Update.
2493
5216580d
TT
24942019-08-13 Tom Tromey <tom@tromey.com>
2495
2496 * tui/tui-winsource.h (struct tui_exec_info_window)
2497 <~tui_exec_info_window, maybe_allocate_content, get_content,
2498 m_content>: Remove.
2499 (struct tui_source_window_base) <set_exec_info_content,
2500 show_exec_info_content>: Don't declare.
2501 * tui/tui-winsource.c
2502 (tui_exec_info_window::maybe_allocate_content): Remove.
2503 (tui_source_window_base::update_exec_info): Rename from
2504 set_exec_info_content.
2505 (tui_source_window_base::show_exec_info_content)
2506 (tui_source_window_base::update_exec_info): Remove.
2507
93858ad3
TT
25082019-08-13 Tom Tromey <tom@tromey.com>
2509
2510 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2511 declare.
2512 * tui/tui-winsource.c (tui_update_source_window_as_is)
2513 (tui_update_source_windows_with_addr, tui_erase_source_content):
2514 Update.
2515 (tui_clear_exec_info_content): Remove.
2516
e321e7ce
TT
25172019-08-13 Tom Tromey <tom@tromey.com>
2518
2519 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2520 declare.
2521 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2522 call tui_erase_exec_info_content.
2523 (tui_clear_exec_info_content): Rename from
2524 tui_erase_exec_info_content.
2525 (tui_clear_exec_info_content): Delete.
2526
8270ac62
TT
25272019-08-13 Tom Tromey <tom@tromey.com>
2528
2529 * tui/tui-winsource.h (struct tui_source_window_base)
2530 <show_exec_info_content>: Declare.
2531 (tui_show_exec_info_content): Don't declare.
2532 * tui/tui-winsource.c
2533 (tui_source_window_base::show_exec_info_content): Rename from
2534 tui_show_exec_info_content.
2535 (tui_source_window_base::update_exec_info): Update.
2536
7b56485d
TT
25372019-08-13 Tom Tromey <tom@tromey.com>
2538
2539 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2540 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2541 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2542 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2543 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2544 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2545 ... here.
2546
7ba913dc
TT
25472019-08-13 Tom Tromey <tom@tromey.com>
2548
2549 * tui/tui-winsource.h (struct tui_source_window_base)
2550 <update_exec_info>: Declare.
2551 (tui_update_exec_info): Don't declare.
2552 * tui/tui-winsource.c (tui_update_source_window_as_is)
2553 (tui_source_window_base::refresh_all)
2554 (tui_update_all_breakpoint_info): Update.
2555 (tui_source_window_base::update_exec_info): Rename from
2556 tui_update_exec_info.
2557 * tui/tui-stack.c (tui_show_frame_info): Update.
2558
37a4a131
TT
25592019-08-13 Tom Tromey <tom@tromey.com>
2560
2561 * tui/tui-winsource.h (struct tui_source_window_base)
2562 <set_exec_info_content>: Declare.
2563 (tui_set_exec_info_content): Don't declare.
2564 * tui/tui-winsource.c
2565 (tui_source_window_base::set_exec_info_content): Rename from
2566 tui_set_exec_info_content.
2567 (tui_update_exec_info): Update.
2568
0bd27e07
TT
25692019-08-13 Tom Tromey <tom@tromey.com>
2570
2571 * tui/tui-winsource.h (struct tui_source_window_base)
2572 <show_source_content>: Declare.
2573 (tui_show_source_content): Don't declare.
2574 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2575 (tui_source_window_base::show_source_content): Rename from
2576 tui_show_source_content.
2577 (tui_source_window_base::refresh_all): Update.
2578 * tui/tui-layout.c (show_source_disasm_command)
2579 (show_source_or_disasm_and_command): Update.
2580
b4ef5aeb
TT
25812019-08-13 Tom Tromey <tom@tromey.com>
2582
2583 * tui/tui-winsource.c (tui_erase_source_content)
2584 (tui_show_source_content, tui_source_window_base::refresh_all):
2585 Update.
2586 * tui/tui-wingeneral.h
2587 (tui_check_and_display_highlight_if_needed): Don't declare.
2588 * tui/tui-wingeneral.c
2589 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2590 check_and_display_highlight_if_needed.
2591 * tui/tui-win.c (tui_rehighlight_all)
2592 (tui_win_info::make_visible_with_new_height): Update.
2593 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2594 (tui_data_window::erase_data_content)
2595 (tui_data_window::display_all_data): Update.
2596 * tui/tui-data.h (struct tui_win_info)
2597 <check_and_display_highlight_if_needed>: Declare.
2598
fede5273
TT
25992019-08-13 Tom Tromey <tom@tromey.com>
2600
2601 * tui/tui-win.c (tui_resize_all): Call
2602 tui_delete_invisible_windows.
2603 * tui/tui-layout.c (show_layout): Call
2604 tui_delete_invisible_windows.
2605 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2606 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2607
22c3f490
TT
26082019-08-13 Tom Tromey <tom@tromey.com>
2609
2610 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2611 tui_add_win_to_layout.
2612
16cb7910
TT
26132019-08-13 Tom Tromey <tom@tromey.com>
2614
2615 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2616 * tui/tui-layout.c (tui_default_win_height): Now static.
2617
cc0c3ffb
TT
26182019-08-13 Tom Tromey <tom@tromey.com>
2619
2620 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2621 single switch.
2622 (show_source_disasm_command, show_source_or_disasm_and_command):
2623 Don't check current layout.
2624
3f3ffe54
TT
26252019-08-13 Tom Tromey <tom@tromey.com>
2626
2627 * tui/tui-wingeneral.c (make_all_visible): Remove.
2628 (tui_make_all_invisible): Simplify.
2629 * tui/tui-layout.c (tui_make_all_invisible): Move from
2630 tui-wingeneral.c; simplify.
2631 (show_layout): Hoist call to tui_make_all_invisible.
2632 (show_data): Don't call tui_make_all_invisible.
2633
69258091
TT
26342019-08-13 Tom Tromey <tom@tromey.com>
2635
2636 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2637 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2638
62cf57fe
TT
26392019-08-13 Tom Tromey <tom@tromey.com>
2640
2641 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2642 tui-data.c.
2643 (show_source_disasm_command, show_data)
2644 (show_source_or_disasm_and_command): Don't use
2645 tui_set_current_layout_to.
2646 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2647 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2648 tui-layout.c.
2649 (tui_set_current_layout_to): Remove.
2650
2afade5d
TT
26512019-08-13 Tom Tromey <tom@tromey.com>
2652
2653 * tui/tui-layout.c (tui_set_layout): Update.
2654 * tui/tui-data.h (struct tui_layout_def): Remove.
2655 (tui_layout_def): Don't declare.
2656 * tui/tui-data.c (layout_def): Remove.
2657 (tui_layout_def): Remove.
2658
a3504e96
TT
26592019-08-13 Tom Tromey <tom@tromey.com>
2660
2661 * tui/tui-winsource.h (struct tui_source_window_base)
2662 <clear_detail>: No longer "override".
2663 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2664 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2665 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2666 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2667 Remove.
2668 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2669
29c92911
TT
26702019-08-13 Tom Tromey <tromey@adacore.com>
2671
2672 * tracepoint.c: Don't include readline.h or history.h.
2673
86c6b807
TT
26742019-08-12 Tom Tromey <tom@tromey.com>
2675
2676 * configure: Rebuild.
2677 * configure.ac: Check for readline 7.
2678 * NEWS: Mention readline 7 requirement.
2679 * README: Update.
2680
5db2718c
TT
26812019-08-12 Tom Tromey <tom@tromey.com>
2682
2683 * mingw-hdep.c (gdb_select): Remove readline hack.
2684
dac36daf
PFC
26852019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2686
2687 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2688 when the function fails.
2689
1022c627
AA
26902019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2691
2692 * s390-tdep.c (s390_type_align): New function.
2693 (s390_gdbarch_init): Set it as type_align gdbarch method.
2694
eba4caf2
TV
26952019-08-09 Tom de Vries <tdevries@suse.de>
2696
2697 PR gdb/24591
2698 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2699 pc_low with relocation offset.
2700
123cd851
TT
27012019-08-07 Tom Tromey <tromey@adacore.com>
2702
2703 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2704 (print_frame_args): Update.
2705 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2706 Update.
2707 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2708 * frame.h (struct frame_arg): Add initializers.
2709 <error>: Now a unique_xmalloc_ptr.
2710
3d31bc39
AH
27112019-08-07 Alan Hayward <alan.hayward@arm.com>
2712
2713 * NEWS: Expand the Pointer Authentication entry.
2714 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2715 (aarch64_frame_unmask_lr): ... to this.
2716 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2717 Call aarch64_frame_unmask_lr.
2718 * frame.c (struct frame_info): Add "masked" variable.
2719 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2720 (fprint_frame): Check for masked pc.
2721 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2722 declarations.
2723 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2724 * stack.c (print_frame): Check for masked pc.
2725
0cf9feb9
TT
27262019-08-06 Tom Tromey <tom@tromey.com>
2727
2728 * stabsread.c (patch_block_stabs, read_one_struct_field)
2729 (read_enum_type): Use obstack_strndup.
2730 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2731 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2732 * dwarf2read.c (guess_full_die_structure_name)
2733 (anonymous_struct_prefix): Use obstack_strndup.
2734 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2735 * c-exp.y (yylex): Use obstack_strndup.
2736 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2737 (write_var_or_type): Use obstack_strndup.
2738
efba19b0
TT
27392019-08-06 Tom Tromey <tom@tromey.com>
2740
2741 * symfile.c (reread_symbols): Use obstack_strdup.
2742 * stabsread.c (read_type): Use obstack_strdup.
2743 * gdb_obstack.h (obstack_strdup): New overload.
2744 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2745 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2746 (dwarf2_canonicalize_name): Use obstack_strdup.
2747 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2748 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2749 Use obstack_strdup.
2750
f25102f7
TT
27512019-08-06 Tom Tromey <tom@tromey.com>
2752
2753 * gdb_obstack.h (obstack_strdup): Define.
2754 * gdb_obstack.c (obstack_strdup): Don't define.
2755
021887d8
TT
27562019-08-06 Tom Tromey <tom@tromey.com>
2757
2758 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2759 obstack_strdup.
2760 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2761 obstack_strdup.
2762 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2763 * stabsread.c (common_block_start): Use obstack_strdup.
2764 * objfiles.c (set_objfile_main_name, objfile): Use
2765 obstack_strdup.
2766 * namespace.c (add_using_directive): Use obstack_strdup.
2767 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2768 * jit.c (finalize_symtab): Use obstack_strdup.
2769 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2770 (guess_partial_die_structure_name, partial_die_info::fixup)
2771 (dwarf2_name): Use obstack_strdup.
2772 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2773 obstack_strdup.
2774 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2775 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2776 obstack_strdup.
2777 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2778
d2834edc
PW
27792019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2780
2781 * unittests/help-doc-selftests.c: New file.
2782 * Makefile.in: Add the new file.
2783
590042fc
PW
27842019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2785
2786 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2787 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2788 the full first line, except when FOR_VALUE_PREFIX. In this case,
2789 the trailing '.' is not output, and the first character is uppercased.
2790 (print_help_for_command): Update call to print_doc_line.
2791 (print_doc_of_command): Likewise.
2792 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2793 * cli/cli-option.c (append_indented_doc): Do not append newline.
2794 (build_help_option): Append newline after first appended_indented_doc
2795 only if a second call is done.
2796 (build_help): Append 2 new lines before each option, except the first
2797 one.
2798 * compile/compile.c (_initialize_compile): Add new lines after
2799 %OPTIONS%, when not at the end of the help.
2800 Change help doc or code
2801 producing the help doc to respect the invariants.
2802 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2803 Also removed the new line after 'Options:', as all other commands
2804 do not put an empty line between 'Options:' and the first option.
2805 * printcmd.c (_initialize_printcmd): Likewise.
2806 * stack.c (_initialize_stack): Likewise.
2807 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2808 incorrectly telling COMMAND is optional.
2809 * ada-lang.c (_initialize_ada_language): Change help doc or code
2810 producing the help doc to respect the invariants.
2811 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2812 * breakpoint.c (_initialize_breakpoint): Likewise.
2813 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2814 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2815 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2816 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2817 _initialize_cli_style): Likewise.
2818 * corelow.c (core_target_info): Likewise.
2819 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2820 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2821 * filesystem.c (_initialize_filesystem): Likewise.
2822 * frame.c (_initialize_frame): Likewise.
2823 * gnu-nat.c (add_task_commands): Likewise.
2824 * infcall.c (_initialize_infcall): Likewise.
2825 * infcmd.c (_initialize_infcmd): Likewise.
2826 * interps.c (_initialize_interpreter): Likewise.
2827 * language.c (_initialize_language): Likewise.
2828 * linux-fork.c (_initialize_linux_fork): Likewise.
2829 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2830 * maint.c (_initialize_maint_cmds): Likewise.
2831 * memattr.c (_initialize_mem): Likewise.
2832 * printcmd.c (_initialize_printcmd): Likewise.
2833 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2834 _RegEx): Likewise.
2835 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2836 * record-btrace.c (_initialize_record_btrace): Likewise.
2837 * record-full.c (_initialize_record_full): Likewise.
2838 * record.c (_initialize_record): Likewise.
2839 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2840 * regcache.c (_initialize_regcache): Likewise.
2841 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2842 _initialize_remote): Likewise.
2843 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2844 * serial.c (_initialize_serial): Likewise.
2845 * skip.c (_initialize_step_skip): Likewise.
2846 * source.c (_initialize_source): Likewise.
2847 * stack.c (_initialize_stack): Likewise.
2848 * symfile.c (_initialize_symfile): Likewise.
2849 * symtab.c (_initialize_symtab): Likewise.
2850 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2851 * top.c (init_main): Likewise.
2852 * tracefile-tfile.c (tfile_target_info): Likewise.
2853 * tracepoint.c (_initialize_tracepoint): Likewise.
2854 * tui/tui-win.c (_initialize_tui_win): Likewise.
2855 * utils.c (add_internal_problem_command): Likewise.
2856 * valprint.c (value_print_option_defs): Likewise.
2857
404f2902
FCE
28582019-08-06 Frank Ch. Eigler <fche@redhat.com>
2859
2860 PR build/24886
2861 * configure.ac: Drop enable-libmcheck support.
2862 * configure, config.in: Rebuild.
2863 * libmcheck.m4: Remove.
2864 * acinclude.m4: Don't include it.
2865 * Makefile.in: Don't distribute it.
2866 * top.c (print_gdb_configuration): Don't mention it.
2867
046bebe1
TT
28682019-08-06 Tom Tromey <tom@tromey.com>
2869
2870 * utils.c (set_output_style): Sometimes pass stream to
2871 emit_style_escape.
2872 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2873 * record-btrace.c (btrace_insn_history): Update.
2874 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2875 method.
2876 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2877 Update initializers.
2878 <m_uiout>: New field.
2879 <m_di>: Move lower.
2880 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2881 Remove "uiout" parameter.
2882 (dump_insns): Update.
2883 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2884 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2885
ddbcedf5
CB
28862019-08-06 Christian Biesinger <cbiesinger@google.com>
2887
2888 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2889 (error_in_psymtab_expansion): Likewise.
2890 (lookup_symbol_via_quick_fns): Likewise.
2891 (basic_lookup_transparent_type_quick): Likewise.
2892 (basic_lookup_transparent_type_1): Likewise.
2893
b08b16c8
TT
28942019-08-06 Tom Tromey <tromey@adacore.com>
2895
2896 * source.c (last_source_error): Now bool.
2897 (print_source_lines_base): Make "noprint" bool. Only open
2898 source file when last_source_visited changes.
2899
cb44333d
TT
29002019-08-06 Tom Tromey <tromey@adacore.com>
2901
2902 * annotate.c (annotate_source_line): Use g_source_cache.
2903 * source-cache.c (source_cache::get_plain_source_lines): Change
2904 parameters. Populate m_offset_cache.
2905 (source_cache::ensure): New method.
2906 (source_cache::get_line_charpos): New method.
2907 (extract_lines): Move lower. Change parameters.
2908 (source_cache::get_source_lines): Move lower.
2909 * source-cache.h (class source_cache): Update comment.
2910 <get_line_charpos>: New method.
2911 <get_source_lines>: Update comment.
2912 <clear>: Clear m_offset_cache.
2913 <get_plain_source_lines>: Change parameters.
2914 <ensure>: New method
2915 <m_offset_cache>: New member.
2916 * source.c (forget_cached_source_info_for_objfile): Update.
2917 (info_source_command): Use g_source_cache.
2918 (find_source_lines, open_source_file_with_line_charpos): Remove.
2919 (print_source_lines_base, search_command_helper): Use g_source_cache.
2920 * source.h (open_source_file_with_line_charpos): Don't declare.
2921 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2922 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2923 Use g_source_cache.
2924
872dceaa
TT
29252019-08-06 Tom Tromey <tromey@adacore.com>
2926
2927 * source-cache.c (source_cache::get_plain_source_lines):
2928 Remove "first_line" and "last_line" parameters.
2929 (source_cache::get_source_lines): Cache plain text.
2930 * source-cache.h (class source_cache)
2931 <get_plain_source_lines>: Update.
2932
269249d9
TT
29332019-08-06 Tom Tromey <tromey@adacore.com>
2934
2935 * source-cache.c (extract_lines): No longer a method.
2936 Changed type of parameter. Include final newline.
2937 (selftests::extract_lines_test): New function.
2938 (_initialize_source_cache): Likewise.
2939 * source-cache.h (class source_cache)
2940 <extract_lines>: Don't declare.
2941
c0e8dcd8
TT
29422019-08-06 Tom Tromey <tromey@adacore.com>
2943
2944 * breakpoint.c (init_breakpoint_sal): Update.
2945 (breakpoint): Update.
2946 * breakpoint.h (struct breakpoint) <filter>: Now a
2947 unique_xmalloc_ptr.
2948
0b27c27d
CB
29492019-08-05 Christian Biesinger <cbiesinger@google.com>
2950
2951 * NEWS: Mention dictionary access on blocks.
2952 * python/py-block.c (blpy_getitem): New function.
2953 (block_object_as_mapping): New struct.
2954 (block_object_type): Use new struct for tp_as_mapping field.
2955
4ee94178
CB
29562019-08-05 Christian Biesinger <cbiesinger@google.com>
2957
2958 * objfiles.h (objfile): Add a comment describing partial symbols.
2959
8abfcabc
TT
29602019-08-05 Tom Tromey <tromey@adacore.com>
2961
2962 * compile/compile.c (_initialize_compile): Use _(), not N_().
2963 * thread.c (_initialize_thread): Use _(), not N_().
2964 * stack.c (_initialize_stack): Use _(), not N_().
2965 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2966
2b79f376
SM
29672019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2968
2969 * dwarf2read.c (struct dw2_symtab_iterator):
2970 <want_specific_block>: Remove.
2971 <block_index>: Change type to gdb::optional.
2972 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2973 change type of BLOCK_INDEX parameter to gdb::optional.
2974 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2975 (dw2_lookup_symbol): Don't pass argument for
2976 WANT_SPECIFIC_BLOCK.
2977 (dw2_expand_symtabs_for_function): Don't pass argument for
2978 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2979 (class dw2_debug_names_iterator)
2980 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2981 parameter, change BLOCK_INDEX type to gdb::optional.
2982 <m_want_specific_block>: Remove.
2983 <m_block_index>: Change type to gdb::optional.
2984 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2985 gdb::optional. Re-write in function of gdb::optional.
2986 (dw2_debug_names_lookup_symbol): Don't pass argument for
2987 WANT_SPECIFIC_BLOCK.
2988 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2989 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2990 BLOCK_INDEX.
2991
ae60f04e
PW
29922019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2993
2994 * NEWS: Mention changes to "info sources" command.
2995
28cd9371
PW
29962019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2997
2998 * symtab.c (filename_partial_match_opts): New struct type.
2999 (struct output_source_filename_data): New members
3000 regexp, c_regexp, partial_match.
3001 (output_source_filename): Use new members to decide to print file.
3002 (info_sources_option_defs): New variable.
3003 (make_info_sources_options_def_group, print_info_sources_header,
3004 info_sources_command_completer):
3005 New functions.
3006 (info_sources_command): Read new optional arguments.
3007 (_initialize_symtab): Update info sources help.
3008
ca683e3a
AO
30092019-08-02 Alexandre Oliva <oliva@adacore.com>
3010
3011 * ada-lang.c (exception_support_info_v0): Renamed from...
3012 (default_exception_support_info): ... this. Create new
3013 definition for v1.
3014 (ada_has_this_exception_support): Look up catch_handlers_sym.
3015 (ada_exception_support_info_sniffer): Try v0 after default.
3016
f1264162
TT
30172019-08-01 Tom Tromey <tromey@adacore.com>
3018
3019 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3020 gdbarch.h.
3021
0a7b2485
CB
30222019-08-01 Christian Biesinger <cbiesinger@google.com>
3023
3024 * s12z-tdep.c: Fix include path for s12z-opc.h.
3025
c6bdbeb7
AH
30262019-08-01 Alan Hayward <alan.hayward@arm.com>
3027
3028 * NEWS: Require GNU make 3.82.
3029
a2bd7b82
TT
30302019-07-16 Tom Tromey <tom@tromey.com>
3031
3032 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3033 declare.
3034
aa3b6533
TT
30352019-07-30 Tom Tromey <tromey@adacore.com>
3036
3037 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3038
a1530dc7
KB
30392019-07-30 Kevin Buettner <kevinb@redhat.com>
3040
3041 * printcmd.c (print_address_symbolic): Print negative offsets.
3042 (build_address_symbolic): Force signed arithmetic when computing
3043 offset.
3044
2906593f
CB
30452019-07-30 Christian Biesinger <cbiesinger@google.com>
3046
3047 PR/24474: Add a function to lookup static variables.
3048 * NEWS: Mention this new function.
3049 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3050 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3051 * python/python.c (python_GdbMethods): Add new function.
3052
c620ed88
CB
30532019-07-29 Christian Biesinger <cbiesinger@google.com>
3054
3055 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3056 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3057 (objfpy_lookup_static_symbol): New function.
3058 (objfile_object_methods): Add new functions.
3059
bc4268a5
PW
30602019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3061
3062 * NEWS: Mention 'set|show print frame-info'. Mention new
3063 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3064 backtrace argument. Mention that python frame filtering code
3065 is now consistent with what 'backtrace' command prints.
3066
4b5e8d19
PW
30672019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3068
3069 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3070 comments.
3071 (print_frame_info_auto, print_frame_info_source_line,
3072 print_frame_info_location, print_frame_info_source_and_location,
3073 print_frame_info_location_and_address, print_frame_info_short_location):
3074 New declarations.
3075 (struct frame_print_options): New member print_frame_info.
3076 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3077 * stack.h (get_user_print_what_frame_info): New declaration.
3078 (frame_show_address): New declaration.
3079 * stack.c (print_frame_arguments_choices): New value 'presence'.
3080 (print_frame_info_auto, print_frame_info_source_line,
3081 print_frame_info_location, print_frame_info_source_and_location,
3082 print_frame_info_location_and_address, print_frame_info_short_location,
3083 print_frame_info_choices, print_frame_info_print_what): New definitions.
3084 (print_frame_args): Only print dots for args if print frame-arguments
3085 is 'presence'.
3086 (frame_print_option_defs): New element for "frame-info".
3087 (get_user_print_what_frame_info): New function.
3088 (frame_show_address): Make non static. Move comment to stack.h.
3089 (print_frame_info_to_print_what): New function.
3090 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3091 to decide what to print.
3092 (backtrace_command_1): Handle the new print_frame_arguments_presence
3093 value.
3094 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3095 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3096 (py_print_frame): In non-mi mode, use LOCATION as default for
3097 print_what, similarly to frame information printed directly by
3098 backtrace command. Handle frame-info user option in non MI mode.
3099
6bdfee81
KB
31002019-07-27 Kevin Buettner <kevinb@redhat.com>
3101
3102 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3103 Add case for debugging 32-bit target on 64-bit host. Revise
3104 comment.
3105
98a617f8
KB
31062019-07-27 Kevin Buettner <kevinb@redhat.com>
3107
3108 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3109 instead of find_function_entry_range_from_pc.
3110
567238c9
KB
31112019-07-27 Kevin Buettner <kevinb@redhat.com>
3112
3113 * stack.c (find_frame_funname): Remove code which preferred
3114 minsym over symtab sym in "certain pathological cases".
3115
2dc80cf8
KB
3116 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3117 parameter. Change type of "do_demangle" to bool.
3118 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3119 Pass suitable "prefer_sym_over_minsym" flag to
3120 build_address_symbolic(). Don't output "+" for negative offsets.
3121 * printcmd.c (print_address_symbolic): Update invocation of
3122 build_address_symbolic to include a "prefer_sym_over_minsym"
3123 flag.
3124 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3125 Restrict cases in which use of minimal symbol is preferred to that
3126 of a found symbol. Update comments.
3127
1aff7173
KB
3128 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3129 for entry pc when entry pc is out of range for that FDE.
3130
89b085ac
BC
31312019-07-26 Brian Callahan <bcallah@openbsd.org>
3132
3133 PR gdb/24839:
3134 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3135 type.
3136
f32feb4a
CB
31372019-07-25 Christian Biesinger <cbiesinger@google.com>
3138
3139 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3140 this function's Python signature.
3141
3142
31432019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
3144
3145 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3146 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3147 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3148 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3149 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3150
3151
c54e4253
YS
31522019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3153
3154 * h8300-tdep.c (h8300_register_name_common): New.
3155 h8300_register_name): Use h8300_register_name_common.
3156 (h8300s_register_name): Likewise.
3157 (h8300sx_register_name): Likewise.
3158 (h8300h_register_nam): New.
3159 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3160
3161
40eadf04
SP
31622019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3163
3164 * arm-tdep.c (arm_skip_cmse_entry): New function.
3165 (arm_is_sgstubs_section): New function.
3166 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3167
bfa2a36d
TT
31682019-07-22 Tom Tromey <tom@tromey.com>
3169
3170 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3171 Don't self-assign.
3172
a8e9d247
AB
31732019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3174
3175 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3176 type_print.
3177
eb86c5e2
AB
31782019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3179
3180 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3181 so that GDB doesn't match any msymbols when searching in the
3182 TYPES_DOMAIN.
3183 (print_symbol_info): Print using typedef_print or type_print based
3184 on the type of the symbol. Add updated FIXME comment moved from...
3185 (_initialize_symtab): ... move and update FIXME comment to above.
3186
a8eab7c6
AB
31872019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3188
3189 * NEWS: Mention adding -q option to "info types".
3190 * symtab.c (struct info_types_options): New struct.
3191 (info_types_options_defs): New variable.
3192 (make_info_types_options_def_group): New function.
3193 (info_types_command): Use gdb::option framework to parse options.
3194 (info_types_command_completer): New function.
3195 (_initialize_symtab): Extend the help text on "info types" and
3196 register command completer.
3197
b4603c34
CB
31982019-07-21 Christian Biesinger <cbiesinger@google.com>
3199
3200 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3201 (lookup_symbol_in_objfile): Change int to block_enum and add a
3202 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3203
c8cdc1e0
CB
32042019-07-20 Christian Biesinger <cbiesinger@google.com>
3205
3206 * MAINTAINERS (Write After Approval): Add self.
3207
01e175fe
AB
32082019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3209
3210 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3211 instruction to the dummy code region.
3212
56f79b63
TT
32132019-07-19 Tom Tromey <tromey@adacore.com>
3214
3215 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3216 (ARGSUSED, PARAMS, __func__): Remove rules.
3217
4c5aa8e0
AH
32182019-07-19 Alan Hayward <alan.hayward@arm.com>
3219
3220 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3221 * features/arm/arm-with-iwmmxt.c: Remove.
3222 * features/arm/arm-with-iwmmxt.xml: Remove.
3223 * features/arm/arm-with-m-fpa-layout.c: Remove.
3224 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3225 * features/arm/arm-with-m-vfp-d16.c: Remove.
3226 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3227 * features/arm/arm-with-m.c: Remove.
3228 * features/arm/arm-with-m.xml: Remove.
3229 * features/arm/arm-with-neon.c: Remove.
3230 * features/arm/arm-with-neon.xml: Remove.
3231 * features/arm/arm-with-vfpv2.c: Remove.
3232 * features/arm/arm-with-vfpv2.xml: Remove.
3233 * features/arm/arm-with-vfpv3.c: Remove.
3234 * features/arm/arm-with-vfpv3.xml: Remove.
3235
f42b2617
AH
32362019-07-19 Alan Hayward <alan.hayward@arm.com>
3237
3238 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3239
f29ec966
AH
32402019-07-19 Alan Hayward <alan.hayward@arm.com>
3241
3242 * arch/aarch32.c (aarch32_create_target_description): Create
3243 target descriptions using features.
3244 * arch/arm.c (arm_create_target_description)
3245 (arm_create_mprofile_target_description): Likewise.
3246 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3247
d105cce5
AH
32482019-07-19 Alan Hayward <alan.hayward@arm.com>
3249
3250 * Makefile.in: Add new files.
3251 * aarch32-tdep.c: New file.
3252 * aarch32-tdep.h: New file.
3253 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3254 Call aarch32_read_description.
3255 * arch/aarch32.c: New file.
3256 * arch/aarch32.h: New file.
3257 * arch/arm.c (arm_create_target_description)
3258 (arm_create_mprofile_target_description): New function.
3259 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3260 (arm_create_target_description)
3261 (arm_create_mprofile_target_description): New declaration.
3262 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3263 read_description functions.
3264 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3265 Likewise.
3266 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3267 * arm-tdep.c (tdesc_arm_list): New variable.
3268 (arm_register_g_packet_guesses): Call create description functions.
3269 (arm_read_description) (arm_read_mprofile_description): New
3270 function.
3271 * arm-tdep.h (arm_read_description)
3272 (arm_read_mprofile_description): Add declaration.
3273 * configure.tgt: Add new files.
3274
afe09f0b
GL
32752019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3276
3277 * top.c (new_ui_command): Open specified terminal just once.
3278
cd215b2e
TT
32792019-07-18 Tom Tromey <tromey@adacore.com>
3280
3281 * symtab.c (main_name): Constify return type.
3282 * symfile.c (set_initial_language): Update.
3283 * symtab.h (main_name): Constify return type.
3284
d8f68fcb
TT
32852019-07-17 Tom Tromey <tom@tromey.com>
3286
3287 * tui/tui-winsource.c (tui_update_source_window)
3288 (tui_update_source_window_as_is)
3289 (tui_update_source_windows_with_line): Remove return.
3290 * tui/tui-disasm.c (tui_show_disassem)
3291 (tui_show_disassem_and_update_source): Remove return.
3292 * tui/tui.c (tui_reset): Remove return.
3293 * tui/tui-wingeneral.c
3294 (tui_check_and_display_highlight_if_needed): Remove return.
3295
ca5af91e
TT
32962019-07-17 Tom Tromey <tom@tromey.com>
3297
3298 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3299
5104fe36
TT
33002019-07-17 Tom Tromey <tom@tromey.com>
3301
3302 * tui/tui-winsource.h (struct tui_exec_info_window)
3303 (struct tui_source_window_base): Move from tui-data.h.
3304 * tui/tui-winsource.c: Move many method definitions from
3305 elsewhere. Remove "structuring" comments.
3306 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3307 (tui_source_window_base::refresh_window): Move to
3308 tui-winsource.c.
3309 * tui/tui-win.c (tui_source_window_base::refresh_all)
3310 (tui_source_window_base::update_tab_width)
3311 (tui_source_window_base::set_new_height)
3312 (tui_source_window_base::do_make_visible_with_new_height): Move to
3313 tui-winsource.c.
3314 * tui/tui-source.h: Update.
3315 * tui/tui-source.c (tui_source_window_base::reset): Move to
3316 tui-winsource.c.
3317 * tui/tui-disasm.h: Update.
3318 * tui/tui-data.h (struct tui_exec_info_window): Move to
3319 tui-winsource.h.
3320 (struct tui_source_window_base): Likewise.
3321 * tui/tui-data.c (tui_source_window_base::clear_detail)
3322 (tui_source_window_base, ~tui_source_window_base): Move to
3323 tui-winsource.c.
3324
daa15dde
TT
33252019-07-17 Tom Tromey <tom@tromey.com>
3326
3327 * tui/tui-win.c (tui_resize_all)
3328 (tui_source_window_base::update_tab_width)
3329 (tui_adjust_win_heights): Update.
3330 (tui_win_info::make_invisible_and_set_new_height): Rename from
3331 make_invisible_and_set_new_height.
3332 * tui/tui-data.h (struct tui_win_info)
3333 <make_invisible_and_set_new_height>: New method.
3334
bfad4537
TT
33352019-07-17 Tom Tromey <tom@tromey.com>
3336
3337 * tui/tui.c: Update.
3338 * tui/tui-source.h (struct tui_source_window): Move from
3339 tui-data.h.
3340 * tui/tui-layout.c: Update.
3341 * tui/tui-disasm.c: Update.
3342 * tui/tui-data.h (struct tui_source_window): Move to
3343 tui-source.h.
3344
88f7e873
TT
33452019-07-17 Tom Tromey <tom@tromey.com>
3346
3347 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3348 tui-data.h.
3349 * tui/tui-data.h (struct tui_disasm_window): Move to
3350 tui-disasm.h.
3351
96bd6233
TT
33522019-07-17 Tom Tromey <tom@tromey.com>
3353
3354 * tui/tui-regs.h (struct tui_data_item_window): Move from
3355 tui-data.h.
3356 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3357 * tui/tui-data.h (struct tui_data_item_window): Move to
3358 tui-regs.h.
3359 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3360
ce38393b
TT
33612019-07-17 Tom Tromey <tom@tromey.com>
3362
3363 * tui/tui.c: Update.
3364 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3365 (tui_cmd_window::max_height): Move to tui-command.c.
3366 * tui/tui-layout.c: Update.
3367 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3368 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3369 tui-command.c.
3370 * tui/tui-command.h (struct tui_cmd_window): Move from
3371 tui-data.h.
3372 * tui/tui-command.c: Remove "structuring" comments.
3373 (tui_cmd_window::clear_detail)
3374 (tui_cmd_window::do_make_visible_with_new_height)
3375 (tui_cmd_window::max_height): Move from elsewhere.
3376
2d8b51cb
TT
33772019-07-17 Tom Tromey <tom@tromey.com>
3378
3379 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3380 Now static.
3381 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3382 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3383
18ab23af
TT
33842019-07-17 Tom Tromey <tom@tromey.com>
3385
3386 * tui/tui.c: Update.
3387 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3388 tui-regs.c.
3389 * tui/tui-windata.h: Remove file.
3390 * tui/tui-windata.c: Remove file.
3391 * tui/tui-win.c (tui_data_window::set_new_height)
3392 (tui_data_window::do_make_visible_with_new_height): Move to
3393 tui-regs.c.
3394 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3395 * tui/tui-regs.c: Remove "structuring" comments.
3396 (tui_data_window::first_data_item_displayed)
3397 (tui_data_window::delete_data_content_windows)
3398 (tui_data_window::erase_data_content)
3399 (tui_data_window::display_all_data)
3400 (tui_data_window::refresh_all)
3401 (tui_data_window::do_scroll_vertical)
3402 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3403 (tui_data_window::do_make_visible_with_new_height)
3404 (tui_data_window::refresh_window): Move from elsewhere.
3405 (_initialize_tui_regs): Move to end of file.
3406 * tui/tui-layout.c: Update.
3407 * tui/tui-hooks.c: Update.
3408 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3409 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3410 tui-regs.c.
3411 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3412
88b7e7cc
TT
34132019-07-17 Tom Tromey <tom@tromey.com>
3414
3415 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3416 seen.
3417
0fcd3711
TT
34182019-07-17 Tom Tromey <tom@tromey.com>
3419
3420 * tui/tui-win.c (tui_source_window_base::set_new_height)
3421 (tui_source_window_base::do_make_visible_with_new_height): Use
3422 m_has_locator field directly.
3423 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3424 method.
3425 (struct tui_source_window_base) <has_locator>: Likewise.
3426
4a38112d
TT
34272019-07-17 Tom Tromey <tom@tromey.com>
3428
3429 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3430 Don't declare.
3431 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3432 Remove.
3433 * tui/tui-win.c (tui_source_window_base::set_new_height)
3434 (tui_source_window_base::set_new_height)
3435 (make_invisible_and_set_new_height)
3436 (tui_source_window_base::do_make_visible_with_new_height)
3437 (tui_source_window_base::do_make_visible_with_new_height):
3438 Update.
3439 * tui/tui-layout.c (show_source_disasm_command, show_data)
3440 (show_source_or_disasm_and_command): Update.
3441 * tui/tui-layout.c (show_layout): Update.
3442
09129226
TT
34432019-07-17 Tom Tromey <tom@tromey.com>
3444
3445 * tui/tui-layout.c (make_data_window): Remove.
3446 (show_data): Unify creation and re-initialization cases.
3447
4a8a5e84
TT
34482019-07-17 Tom Tromey <tom@tromey.com>
3449
3450 * tui/tui-layout.c (make_source_window, make_disasm_window):
3451 Remove.
3452 (show_data): Unify creation and re-initialization cases.
3453
76d2be8e
TT
34542019-07-17 Tom Tromey <tom@tromey.com>
3455
3456 * tui/tui-layout.c (make_command_window): Remove.
3457 (show_source_disasm_command, show_source_or_disasm_and_command):
3458 Unify creation and re-initialization cases.
3459
890b8bde
TT
34602019-07-17 Tom Tromey <tom@tromey.com>
3461
3462 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3463 creation and re-initialization cases.
3464
2cdfa113
TT
34652019-07-17 Tom Tromey <tom@tromey.com>
3466
3467 * tui/tui-regs.c (tui_get_register): Return void.
3468
8e3cfd09
TT
34692019-07-17 Tom Tromey <tom@tromey.com>
3470
3471 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3472 Simplify.
3473
f4e04977
TT
34742019-07-17 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3477 resetting.
3478
0379b883
TT
34792019-07-17 Tom Tromey <tom@tromey.com>
3480
3481 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3482 * tui/tui-regs.c (tui_reg_layout): New function.
3483 (tui_show_registers, tui_reg_command): Use it.
3484 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3485 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3486 parameters.
3487 (tui_layout_command): Remove.
3488
b7fbad91
TT
34892019-07-17 Tom Tromey <tom@tromey.com>
3490
3491 * tui/tui-layout.h (tui/tui-layout): Return void.
3492 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3493
4e1e56b9
TT
34942019-07-17 Tom Tromey <tom@tromey.com>
3495
3496 * tui/tui-layout.c (show_source_disasm_command, show_data):
3497 Update.
3498 (reset_locator): Remove.
3499 (show_source_or_disasm_and_command): Update.
3500
1e0c09ba
TT
35012019-07-17 Tom Tromey <tom@tromey.com>
3502
3503 * tui/tui-source.c (tui_source_window_base::reset): Remove
3504 win_type parameter.
3505 * tui/tui-layout.c (make_command_window, make_source_window)
3506 (make_disasm_window, make_data_window)
3507 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3508 (reset_locator, show_source_or_disasm_and_command): Update.
3509 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3510 win_type parameter.
3511 (struct tui_source_window_base) <reset>: Likewise.
3512
1bf605de
TT
35132019-07-17 Tom Tromey <tom@tromey.com>
3514
3515 * tui/tui-layout.c (show_source_disasm_command): Use
3516 reset_locator.
3517 (reset_locator): New function.
3518 (init_and_make_win): Remove.
3519 (show_source_or_disasm_and_command): Use reset_locator.
3520
098f9ed4
TT
35212019-07-17 Tom Tromey <tom@tromey.com>
3522
3523 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3524 condition.
3525 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3526 Remove condition.
3527 * tui/tui-source.c (tui_source_window_base::reset): New method.
3528 * tui/tui-layout.c (make_command_window): Don't call
3529 init_and_make_win.
3530 (make_source_window, make_disasm_window): Don't call
3531 make_source_or_disasm_window.
3532 (make_data_window): Don't call init_and_make_win. Change calling
3533 convention.
3534 (show_source_disasm_command, show_data): Simplify.
3535 (make_source_or_disasm_window): Remove.
3536 (show_source_or_disasm_and_command): Simplify.
3537 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3538 (struct tui_source_window_base) <reset>: Likewise.
3539 <execution_info>: Remove initializer.
3540 * tui/tui-data.c (tui_source_window_base): Initialize
3541 execution_info.
3542
80110957
TT
35432019-07-17 Tom Tromey <tom@tromey.com>
3544
3545 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3546 variable.
3547
cf82af05
TT
35482019-07-17 Tom Tromey <tom@tromey.com>
3549
3550 * tui/tui.c (tui_rl_other_window): Update.
3551 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3552 superclass method first. Always iterate over regs_content.
3553 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3554 method.
3555 * tui/tui-win.c (tui_set_focus_command): Update.
3556
01aeb396
TT
35572019-07-17 Tom Tromey <tom@tromey.com>
3558
3559 * tui/tui-win.c (tui_set_focus_command): Rename from
3560 tui_set_focus. Call tui_enable.
3561 (tui_set_focus_command): Remove.
3562
fd6c75ee
TT
35632019-07-17 Tom Tromey <tom@tromey.com>
3564
3565 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3566 refresh_window.
3567 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3568 touchwin.
3569 (tui_data_window::refresh_window): Call refresh_window on data
3570 items. Always call superclass refresh_window.
3571 (tui_win_info::refresh): Remove.
3572 (tui_source_window_base::refresh_window): Update.
3573 (tui_refresh_all): Update.
3574 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3575 refresh_window.
3576 (show_source_or_disasm_and_command): Likewise.
3577 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3578 (struct tui_source_window_base) <refresh>: Likewise.
3579
f6cc34a9
TT
35802019-07-17 Tom Tromey <tom@tromey.com>
3581
3582 * tui/tui-winsource.c (tui_clear_source_content)
3583 (tui_show_source_content): Update.
3584 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3585 whether content is empty.
3586 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3587 Remove.
3588
f31ec9af
TT
35892019-07-17 Tom Tromey <tom@tromey.com>
3590
3591 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3592 window's contents.
3593 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3594 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3595
d1b6f1e5
TT
35962019-07-17 Tom Tromey <tom@tromey.com>
3597
3598 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3599 (struct tui_data_item_window): Update.
3600
d9743a13
TT
36012019-07-17 Tom Tromey <tom@tromey.com>
3602
3603 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3604 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3605 defines.
3606
caf0bc4e
TT
36072019-07-17 Tom Tromey <tom@tromey.com>
3608
3609 * tui/tui-winsource.h (tui_erase_source_content)
3610 (tui_clear_source_content): Remove "display_prompt" parameter.
3611 * tui/tui-winsource.c (tui_update_source_window_as_is)
3612 (tui_update_source_windows_with_addr): Update.
3613 (tui_clear_source_content): Remove "display_prompt" parameter.
3614 (tui_erase_source_content): Likewise. Simplify.
3615 (tui_show_source_content): Update.
3616 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3617 * tui/tui-stack.c (tui_show_frame_info): Update.
3618 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3619 Remove defines.
3620
9d391078
TT
36212019-07-17 Tom Tromey <tom@tromey.com>
3622
3623 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3624 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3625 parameter.
3626 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3627 parameter.
3628
a38da35d
TT
36292019-07-17 Tom Tromey <tom@tromey.com>
3630
3631 * tui/tui-winsource.c (tui_clear_source_content)
3632 (tui_show_source_content, tui_show_exec_info_content)
3633 (tui_clear_exec_info_content): Update.
3634 * tui/tui-stack.c (tui_show_locator_content): Update.
3635 (tui_show_frame_info): Update.
3636 * tui/tui-source.h (tui_source_window): Don't declare.
3637 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3638 from tui_source_is_displayed.
3639 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3640 Remove field.
3641 (struct tui_source_window_base) <content_in_use>: New field. Now
3642 bool.
3643 (struct tui_source_window) <showing_source_p>: New method.
3644 (TUI_SRC_WIN): Change cast.
3645 * tui/tui-data.c (tui_initialize_static_data): Update.
3646
c2cd8994
TT
36472019-07-17 Tom Tromey <tom@tromey.com>
3648
3649 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3650 location_matches_p.
3651 * tui/tui-source.c (tui_source_window::location_matches_p): New
3652 method.
3653 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3654 method.
3655 * tui/tui-data.h (struct tui_source_window_base)
3656 <location_matches_p>: New method.
3657 (struct tui_source_window, struct tui_disasm_window)
3658 <location_matches_p>: Likewise.
3659
4dde7b34
TT
36602019-07-17 Tom Tromey <tom@tromey.com>
3661
3662 * tui/tui-win.c (tui_set_win_height_command): Rename from
3663 tui_set_win_height.
3664 (tui_set_win_height_command): Remove.
3665
b73dd877
TT
36662019-07-17 Tom Tromey <tom@tromey.com>
3667
3668 * tui/tui-source.c (tui_source_window): New constructor. Add
3669 observer.
3670 (~tui_source_window): New destructor.
3671 (tui_source_window::style_changed): New method.
3672 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3673 (tui_attach_detach_observers): Update.
3674 * tui/tui-data.h (struct tui_source_window): Make constructor not
3675 inline. Add destructor.
3676 (struct tui_source_window) <style_changed>: New method.
3677 <m_observable>: New member.
3678
ae2b5380
TT
36792019-07-17 Tom Tromey <tom@tromey.com>
3680
3681 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3682 * tui/tui-win.c (tui_resize_all): Fix typo.
3683
1ce3e844
TT
36842019-07-17 Tom Tromey <tom@tromey.com>
3685
3686 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3687 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3688 (tui_refresh_all): Remove "list" parameter. Use foreach.
3689 * tui/tui-win.c (window_name_completer): Use foreach.
3690 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3691 (update_tab_width): Likewise.
3692 * tui/tui-layout.c (show_layout): Update.
3693 * tui/tui-data.h (class tui_window_iterator): New.
3694 (struct all_tui_windows): New.
3695 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3696
fe3eaf1c
TT
36972019-07-17 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3700 parameter. Don't reference globals.
3701 (tui_reg_command): Update.
3702
368c1354
TT
37032019-07-17 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui-regs.c (tui_show_registers): Simplify.
3706
e80cd204
TT
37072019-07-17 Tom Tromey <tom@tromey.com>
3708
3709 * tui/tui-regs.c (tui_show_registers): Update.
3710 (tui_show_register_group): Add win_info parameter.
3711
aca2dd16
TT
37122019-07-17 Tom Tromey <tom@tromey.com>
3713
3714 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3715 Rename from tui_display_reg_element_at_line.
3716 (tui_data_window::display_registers_from_line): Update.
3717 * tui/tui-data.h (struct tui_data_window)
3718 <display_reg_element_at_line>: New method.
3719
517e9505
TT
37202019-07-17 Tom Tromey <tom@tromey.com>
3721
3722 * tui/tui-regs.h (tui_display_registers_from)
3723 (tui_display_registers_from_line): Don't declare.
3724 * tui/tui-windata.c (tui_data_window::display_all_data)
3725 (tui_data_window::refresh_all)
3726 (tui_data_window::do_scroll_vertical): Update.
3727 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3728 from tui_display_registers_from.
3729 (tui_display_reg_element_at_line): Update.
3730 (tui_data_window::display_registers_from_line): Rename from
3731 tui_display_registers_from_line.
3732 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3733 display_registers_from_line>: New methods.
3734
f76d8b19
TT
37352019-07-17 Tom Tromey <tom@tromey.com>
3736
3737 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3738 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3739 from tui_erase_data_content.
3740 (tui_data_window::display_all_data)
3741 (tui_data_window::refresh_all)
3742 (tui_data_window::do_scroll_vertical): Update.
3743 * tui/tui-regs.c (tui_show_registers): Update.
3744 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3745 New method.
3746
b4094625
TT
37472019-07-17 Tom Tromey <tom@tromey.com>
3748
3749 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3750 declare.
3751 * tui/tui-windata.c
3752 (tui_data_window::delete_data_content_windows): Rename from
3753 tui_delete_data_content_windows.
3754 (tui_data_window::display_all_data)
3755 (tui_data_window::do_scroll_vertical): Update.
3756 * tui/tui-data.h (struct tui_data_window)
3757 <delete_data_content_windows>: New method.
3758
c223a729
TT
37592019-07-17 Tom Tromey <tom@tromey.com>
3760
3761 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3762 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3763
50daf268
TT
37642019-07-17 Tom Tromey <tom@tromey.com>
3765
3766 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3767 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3768 from tui_display_all_data.
3769 * tui/tui-win.c
3770 (tui_data_window::do_make_visible_with_new_height): Update.
3771 * tui/tui-regs.c (tui_show_registers): Update.
3772 * tui/tui-layout.c (tui_set_layout): Update.
3773 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3774 method.
3775
df5f8cab
TT
37762019-07-17 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3779 * tui/tui-windata.c (tui_display_data_from): Remove.
3780 (tui_data_window::refresh_all): Update.
3781
80cb6c27
TT
37822019-07-17 Tom Tromey <tom@tromey.com>
3783
3784 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3785 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3786 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3787 tui_display_registers_from_line.
3788 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3789 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3790 "force_display" parameter.
3791
baff0c28
TT
37922019-07-17 Tom Tromey <tom@tromey.com>
3793
3794 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3795 declare.
3796 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3797 Rename from tui_first_reg_element_no_inline.
3798 (tui_display_reg_element_at_line)
3799 (tui_display_registers_from_line): Update.
3800 * tui/tui-data.h (struct tui_data_window)
3801 <first_reg_element_no_inline>: New method.
3802
3b23c5f2
TT
38032019-07-17 Tom Tromey <tom@tromey.com>
3804
3805 * tui/tui-windata.c (tui_display_data_from)
3806 (tui_data_window::do_scroll_vertical): Update.
3807 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3808 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3809 Rename from tui_line_from_reg_element_no.
3810 (tui_display_registers_from_line): Update.
3811 * tui/tui-data.h (struct tui_data_window)
3812 <line_from_reg_element_no>: New method.
3813
0b5ec218
TT
38142019-07-17 Tom Tromey <tom@tromey.com>
3815
3816 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3817 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3818 tui_last_regs_line_no.
3819 (tui_display_reg_element_at_line)
3820 (tui_display_registers_from_line): Update.
3821 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3822 method.
3823
0807ab7b
TT
38242019-07-17 Tom Tromey <tom@tromey.com>
3825
3826 PR tui/24722:
3827 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3828 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3829 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3830 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3831 (tui_update_breakpoint_info): Likewise.
3832 * tui/tui-hooks.c (tui_event_create_breakpoint)
3833 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3834 Update.
3835
9ad7fdef
TT
38362019-07-17 Tom Tromey <tom@tromey.com>
3837
3838 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3839
5813316f
TT
38402019-07-17 Tom Tromey <tom@tromey.com>
3841
3842 * tui/tui-winsource.c (tui_update_source_window_as_is)
3843 (tui_update_source_windows_with_addr): Update.
3844 * tui/tui-source.h (tui_set_source_content)
3845 (tui_show_symtab_source): Add "win_info" parameter.
3846 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3847 parameter.
3848 (tui_show_symtab_source): Likewise.
3849
00e264e7
TT
38502019-07-17 Tom Tromey <tom@tromey.com>
3851
3852 * tui/tui-wingeneral.c
3853 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3854
06210ce4
TT
38552019-07-17 Tom Tromey <tom@tromey.com>
3856
3857 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3858 (struct tui_cmd_window) <can_scroll>: New method.
3859 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3860 method.
3861
381befee
TT
38622019-07-17 Tom Tromey <tromey@adacore.com>
3863
3864 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3865 do_field_signed>: Rename. Change type of "value".
3866 * ui-out.c (ui_out::field_signed): Rename from field_int.
3867 Change type of "value".
3868 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3869 type of "value".
3870 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3871 do_field_int. Change type of "value".
3872 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3873 do_field_int. Change type of "value".
3874 * tracepoint.c (trace_status_mi, tfind_1)
3875 (print_one_static_tracepoint_marker): Update.
3876 * thread.c (print_thread_info_1, print_selected_thread_frame):
3877 Update.
3878 * stack.c (print_frame, print_frame_info): Update.
3879 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3880 Update.
3881 * source.c (print_source_lines_base): Update.
3882 * skip.c (info_skip_command): Update.
3883 * record-btrace.c (btrace_ui_out_decode_error)
3884 (btrace_call_history_src_line): Update.
3885 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3886 Update.
3887 * progspace.c (print_program_space): Update.
3888 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3889 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3890 do_field_int. Change type of "value".
3891 * mi/mi-out.c (mi_ui_out::do_table_begin)
3892 (mi_ui_out::do_table_header): Update.
3893 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3894 type of "value".
3895 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3896 (mi_cmd_data_list_changed_registers, output_register)
3897 (mi_cmd_data_read_memory, mi_load_progress)
3898 (mi_cmd_trace_frame_collected): Update.
3899 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3900 Update.
3901 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3902 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3903 (mi_cmd_var_list_children, varobj_update_one): Update.
3904 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3905 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3906 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3907 * inferior.c (print_inferior): Update.
3908 * gdb_bfd.c (print_one_bfd): Update.
3909 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3910 Update.
3911 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3912 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3913 do_field_int. Change type of "value".
3914 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3915 do_field_int. Change type of "value".
3916 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3917 (print_one_breakpoint_location, print_it_catch_fork)
3918 (print_one_catch_fork, print_it_catch_vfork)
3919 (print_one_catch_vfork, print_it_catch_solib)
3920 (print_it_catch_exec, print_it_ranged_breakpoint)
3921 (print_mention_watchpoint, print_mention_masked_watchpoint)
3922 (bkpt_print_it, update_static_tracepoint): Update.
3923 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3924 * break-catch-syscall.c (print_it_catch_syscall): Update.
3925 * ada-tasks.c (print_ada_task_info): Update.
3926 * ada-lang.c (print_it_exception, print_mention_exception):
3927 Update.
3928
6b78c3f8
AB
39292019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3930
3931 PR breakpoints/24541
3932 * gdbarch.c: Regenerate.
3933 * gdbarch.h: Regenerate.
3934 * gdbarch.sh: Adjust return type and parameter types for
3935 'stap_adjust_register'.
3936 (i386_stap_adjust_register): Adjust signature and return new
3937 register name.
3938 * stap-probe.c (stap_parse_register_operand): Adjust use of
3939 'gdbarch_stap_adjust_register'.
3940
d72a9b85
TT
39412019-07-17 Tom Tromey <tromey@adacore.com>
3942
3943 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3944 declare VEC.
3945 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3946 std::vector.
3947 (struct s390_process_info): Add initializers.
3948 (s390_add_process): Use new.
3949 (s390_linux_nat_target::low_forget_process): Use delete.
3950 (s390_linux_nat_target::low_new_fork)
3951 (s390_linux_nat_target::stopped_by_watchpoint)
3952 (s390_linux_nat_target::low_prepare_to_resume)
3953 (s390_linux_nat_target::insert_watchpoint)
3954 (s390_linux_nat_target::insert_hw_breakpoint)
3955 (s390_linux_nat_target::remove_watchpoint)
3956 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3957
206e6c58
JB
39582019-07-16 John Baldwin <jhb@FreeBSD.org>
3959
3960 * aarch64-fbsd-nat.c: Include regcache.h.
3961 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3962 argument.
3963 (aarch64_fbsd_nat_target::fetch_registers)
3964 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3965 variable.
3966 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3967
cbde90f2
JB
39682019-07-16 John Baldwin <jhb@FreeBSD.org>
3969
3970 * fbsd-nat.c: Include gdbarch.h.
3971
07128006
TT
39722019-07-15 Tom Tromey <tromey@adacore.com>
3973
3974 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3975
1f77b012
TT
39762019-07-15 Tom Tromey <tromey@adacore.com>
3977
3978 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3979 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3980 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3981 * cli-out.c (cli_ui_out::do_field_int): New method.
3982 * ui-out.c (ui_out::field_unsigned): New method.
3983 * symfile.c (generic_load): Use field_unsigned.
3984 (print_transfer_performance): Likewise.
3985 * record-btrace.c (ui_out_field_uint): Remove.
3986 (btrace_call_history_insn_range, btrace_call_history): Use
3987 field_unsigned.
3988 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3989 field_unsigned.
3990 * ui-out.h (class ui_out) <field_unsigned>: New method.
3991 <do_field_unsigned>: Likewise.
3992
33eca680
TT
39932019-07-15 Tom Tromey <tromey@adacore.com>
3994
3995 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3996 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3997 * target.c (flash_erase_command): Use field_string.
3998 * infrun.c (print_signal_received_reason): Use field_string.
3999 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4000 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4001 field_string.
4002 * ada-tasks.c (print_ada_task_info): Use field_string.
4003
ca8d69be
TT
40042019-07-15 Tom Tromey <tromey@adacore.com>
4005
4006 * target.c (flash_erase_command): Use field_core_addr.
4007 * symfile.c (generic_load): Use field_core_addr.
4008 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4009 Use field_core_addr.
4010 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4011 field_core_addr.
4012
0d4e84ed
AB
40132019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4014
4015 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4016 value if its desired type is smaller than a CORE_ADDR and signed.
4017
9a49df9d
AB
40182019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4019
4020 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4021 of changes to field names, and use new is_reference field to
4022 decide if a property is a reference or not.
4023 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4024 field.
4025 (struct dwarf2_property_baton): Update header comment, rename
4026 'referenced_type' to 'property_type' and update comments.
4027 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4028 default property type, store in property baton, update to take
4029 accound of renamed field.
4030 (read_func_scope): Update call to attr_to_dynamic_prop.
4031 (read_array_type): Likewise.
4032 (dwarf2_per_cu_addr_sized_int_type): New function.
4033 (read_subrange_index_type): Move type finding code to
4034 dwarf2_per_cu_addr_sized_int_type.
4035 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4036 (dwarf2_per_cu_addr_type): New function.
4037 (set_die_type): Update calls to attr_to_dynamic_prop.
4038
b86352cf
AB
40392019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4040
4041 * dwarf2read.c (read_subrange_index_type): New function.
4042 (read_subrange_type): Move code into new function and call it.
4043 * gdbtypes.c (create_range_type): Add some asserts.
4044
603490bf
AB
40452019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4046
4047 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4048 update return statements.
4049 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4050 declaration, and update comment to match.
4051 * gdbtypes.c (resolve_dynamic_array): Update call to
4052 dwarf2_evaluate_property to match new return type.
4053
592f9d27
AB
40542019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4055
4056 * valarith.c (value_subscripted_rvalue): Change lowerbound
4057 parameter type from int to LONGEST.
4058 * value.h (value_subscripted_rvalue): Likewise in declaration.
4059
60cfcb20
AB
40602019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4061
4062 * cli/cli-utils.c (info_print_command_completer): New function.
4063 * cli/cli-utils.h: Add 'completer.h' include, and forward
4064 declaration for 'struct cmd_list_element'.
4065 (info_print_command_completer): Declare.
4066 * stack.c (_initialize_stack): Add completer for 'info locals' and
4067 'info args'.
4068 * symtab.c (_initialize_symtab): Add completer for 'info
4069 variables' and 'info functions'.
4070 * NEWS: Mention completion for additional info commands.
4071
b16507e0
AB
40722019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4073
4074 * cli/cli-utils.c (extract_info_print_args): Delete.
4075 (extract_arg_maybe_quoted): Delete.
4076 (info_print_options_defs): New variable.
4077 (make_info_print_options_def_group): New function.
4078 (extract_info_print_options): Define new function.
4079 * cli/cli-utils.h (extract_info_print_args): Delete.
4080 (struct info_print_options): New structure.
4081 (extract_info_print_options): Declare new function.
4082 * stack.c (info_locals_command): Update to use new
4083 extract_info_print_options, also add a header comment.
4084 (info_args_command): Likewise.
4085 * symtab.c (info_variables_command): Likewise.
4086 (info_functions_command): Likewise.
4087
021d8588
AB
40882019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4089
4090 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4091 to extract string arguments.
4092 * common/common-utils.c (extract_string_maybe_quoted): New function.
4093 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4094
b777eb6d
TT
40952019-07-11 Tom Tromey <tromey@adacore.com>
4096
4097 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4098 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4099 * top.h (gdbinit): Don't declare.
4100 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4101 into...
4102 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4103 * top.c (gdb_init): Don't call init_cli_cmds.
4104 (gdbinit): Remove.
4105 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4106
72ee03ff
TT
41072019-07-11 Tom Tromey <tromey@adacore.com>
4108
4109 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4110 after it has been moved.
4111
00db9531
SM
41122019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4113
4114 * valops.c (value_must_coerce_to_target): Change return type to
4115 bool.
4116 * value.h (value_must_coerce_to_target): Likewise.
4117
f2478a7e
SM
41182019-07-10 Simon Marchi <simon.marchi@efficios.com>
4119
4120 * breakpoint.c (is_hardware_watchpoint): Remove
4121 forward-declaration.
4122 (is_masked_watchpoint): Change return type to bool.
4123 (is_tracepoint): Likewise.
4124 (is_breakpoint): Likewise.
4125 (is_hardware_watchpoint): Likewise.
4126 (is_watchpoint): Likewise.
4127 (is_no_memory_software_watchpoint): Likewise.
4128 (is_catchpoint): Likewise.
4129 (breakpoint_1): Make FILTER parameter's return type bool.
4130 is_masked_watchpoint): Change return type to bool.
4131 (save_breakpoints): Make FILTER parameter's return type bool.
4132 * breakpoint.h (is_breakpoint): Change return type to bool.
4133 (is_watchpoint): Likewise.
4134 (is_catchpoint): Likewise.
4135 (is_tracepoint): Likewise.
4136
0d12e84c
TT
41372019-07-10 Tom Tromey <tom@tromey.com>
4138
4139 * defs.h: Don't include gdbarch.h.
4140 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4141 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4142 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4143 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4144 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4145 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4146 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4147 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4148 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4149 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4150 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4151 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4152 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4153 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4154 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4155 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4156 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4157 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4158 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4159 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4160 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4161 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4162 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4163 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4164 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4165 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4166 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4167
f06f1252
TT
41682019-07-10 Tom Tromey <tromey@adacore.com>
4169
4170 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4171 * breakpoint.c (init_ada_exception_breakpoint): Register as
4172 bp_catchpoint.
4173 (print_one_breakpoint_location, print_one_breakpoint): Use
4174 is_ada_exception_catchpoint.
4175 * ada-lang.c (class ada_catchpoint_location): Pass
4176 bp_loc_software_breakpoint to bp_location constructor.
4177 (is_ada_exception_catchpoint): New function.
4178
7a5d944b
TT
41792019-07-10 Tom Tromey <tromey@adacore.com>
4180
4181 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4182 VEC.
4183 (struct arm_exidx_entry): New method operator<.
4184 (struct arm_exidx_data) <section_maps>: Change type.
4185 (arm_exidx_data_free): Remove.
4186 (arm_exidx_data_key): Change type. Move lower.
4187 (arm_exidx_new_objfile): Update.
4188 (arm_compare_exidx_entries): Remove.
4189 (arm_find_exidx_entry, _initialize_arm_tdep)
4190
48c66e1d
TT
41912019-07-10 Tom Tromey <tromey@adacore.com>
4192
4193 * solib-spu.c (ocl_program_data_key): Change type.
4194 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4195 Update.
4196
a269fbf1
TT
41972019-07-10 Tom Tromey <tromey@adacore.com>
4198
4199 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4200 (struct solib_aix_inferior_data) <library_list>: Change type.
4201 (solib_aix_inferior_data_handle): Change type.
4202 (get_solib_aix_inferior_data): Update.
4203 (solib_aix_free_library_list): Remove.
4204 (library_list_start_library): Update.
4205 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4206 return type.
4207 (solib_aix_get_library_list)
4208 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4209 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4210
c294730c
TT
42112019-07-10 Tom Tromey <tromey@adacore.com>
4212
4213 * solib-dsbt.c (struct dsbt_info): Add initializers.
4214 (solib_dsbt_pspace_data): Change type.
4215 (dsbt_pspace_data_cleanup): Remove.
4216 (get_dsbt_info, _initialize_dsbt_solib): Update.
4217
9d52077d
TT
42182019-07-10 Tom Tromey <tromey@adacore.com>
4219
4220 * spu-tdep.c (spu_overlay_data): Change type.
4221 (spu_get_overlay_table, spu_overlay_new_objfile)
4222 (_initialize_spu_tdep): Update.
4223
22a20dca
TT
42242019-07-10 Tom Tromey <tromey@adacore.com>
4225
4226 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4227 destructor.
4228 (dbx_objfile_data_key): Change type and declare later.
4229 (DBX_SYMFILE_INFO): Rewrite.
4230 * dbxread.c (dbx_objfile_data_key): Change type.
4231 (dbx_symfile_init): Update.
4232 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4233 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4234 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4235
cb60f420
TT
42362019-07-10 Tom Tromey <tromey@adacore.com>
4237
4238 * jit.c (jit_program_space_key): Change type. Move lower.
4239 (get_jit_program_space_data): Update.
4240 (jit_program_space_data_cleanup): Remove.
4241 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4242 Update.
4243 (struct jit_program_space_data): Add initializers.
4244
51df2ae3
TT
42452019-07-10 Tom Tromey <tromey@adacore.com>
4246
4247 * solib-darwin.c (struct darwin_info): Add initializers.
4248 (solib_darwin_pspace_data): Change type.
4249 (darwin_pspace_data_cleanup): Remove.
4250 (get_darwin_info, _initialize_darwin_solib): Update.
4251
18101a35
TT
42522019-07-10 Tom Tromey <tromey@adacore.com>
4253
4254 * remote-sim.c (struct sim_inferior_data): Add initializers,
4255 constructor, and destructor.
4256 (sim_inferior_data_key): Change type. Move lower.
4257 (check_for_duplicate_sim_descriptor): Update.
4258 (get_sim_inferior_data): Use new. Update.
4259 (~sim_inferior_data_cleanup): Rename from
4260 sim_inferior_data_cleanup. Simplify.
4261 (gdbsim_close_inferior, simulator_command)
4262 (sim_command_completer, _initialize_remote_sim): Update.
4263 (next_pid, INITIAL_PID): Move earlier.
4264
05b08ac1
TT
42652019-07-10 Tom Tromey <tromey@adacore.com>
4266
4267 * python/python-internal.h (create_thread_object): Return
4268 gdbpy_ref.
4269 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4270 * python/py-inferior.c (struct threadlist_entry): Add
4271 constructor.
4272 <thread_obj>: Now a gdbpy_ref.
4273 (thread_to_thread_object): Update.
4274 (add_thread_object): Use new.
4275 (delete_thread_object): Use delete.
4276 (infpy_threads): Update.
4277 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4278 GIL.
4279
32372d80
TT
42802019-07-10 Tom Tromey <tromey@adacore.com>
4281
4282 * valops.c (value_cast): Specialize error message for Ada.
4283
5c458ae8
SM
42842019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4285
4286 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4287
4c462cb0
SM
42882019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4289
4290 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4291 bpstat_should_step): Return bool, adjust comments.
4292 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4293 bpstat_should_step): Likewise.
4294
89abbcc2
AH
42952019-07-10 Alan Hayward <alan.hayward@arm.com>
4296
4297 * features/Makefile: Use feature target descriptions for Arm.
4298 * features/arm/arm-core.c: Generate new file.
4299 * features/arm/arm-fpa.c: Likewise.
4300 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4301 * features/arm/arm-m-profile.c: Likewise.
4302 * features/arm/arm-vfpv2.c: Likewise.
4303 * features/arm/arm-vfpv3.c: Likewise.
4304 * features/arm/xscale-iwmmxt.c: Likewise.
4305 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4306
166a82be
AH
43072019-07-10 Alan Hayward <alan.hayward@arm.com>
4308
4309 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4310 ptrace earlier.
4311
9fb4c7e9
AH
43122019-07-10 Alan Hayward <alan.hayward@arm.com>
4313
4314 * features/aarch64-pauth.c: Regenerate.
4315
e2d0f980
SM
43162019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4317
4318 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4319 bool.
4320 (bpstat_what): Use false instead of 0.
4321
a38118e5
PA
43222019-07-09 Pedro Alves <palves@redhat.com>
4323
4324 * break-catch-throw.c (is_exception_catchpoint): New.
4325 * breakpoint.c (print_one_breakpoint_location): New parameter
4326 'raw_loc'. Handle it. Use
4327 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4328 looking at the breakpoint's type.
4329 (print_one_breakpoint): If handling "maint info breakpoints", also
4330 print locations of exception catchpoints.
4331 * breakpoint.h (is_exception_catchpoint): Declare.
4332
cb1e4e32
PA
43332019-07-09 Pedro Alves <palves@redhat.com>
4334
4335 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4336 "addr" field.
4337 (allocate_location_exception_catchpoint): New.
4338 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4339 (initialize_throw_catchpoint_ops): Install
4340 allocate_location_exception_catchpoint as allocate_location
4341 method.
4342 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4343 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4344 bp_loc_other.
4345 (breakpoint_address_is_meaningful): Delete.
4346 (bl_address_is_meaningful): New.
4347 (breakpoint_locations_match): Adjust comment.
4348 (bp_location_from_bp_type): New, factored out of...
4349 (bp_location::bp_location(breakpoint *)): ... this.
4350 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4351 factored out of...
4352 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4353 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4354 breakpoint_address_is_meaningful.
4355 (bp_locations_compare): Adjust comment.
4356 (update_global_location_list): Use bl_address_is_meaningful
4357 instead of breakpoint_address_is_meaningful.
4358 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4359 explicit.
4360 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4361 * python/py-breakpoint.c (bppy_get_location): No longer check
4362 whether location is null.
4363
b58a68fe
PA
43642019-07-09 Pedro Alves <palves@redhat.com>
4365
4366 PR c++/15468
4367 * breakpoint.c (print_one_breakpoint_location): Remove
4368 single-location assert.
4369
268a13a5
TT
43702019-07-09 Tom Tromey <tom@tromey.com>
4371
4372 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4373 * configure: Rebuild.
4374 * configure.ac: Change common to gdbsupport.
4375 * gdbsupport: Rename from common.
4376 * acinclude.m4: Change common to gdbsupport.
4377 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4378 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4379 gdbsupport.
4380 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4381 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4382 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4383 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4384 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4385 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4386 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4387 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4388 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4389 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4390 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4391 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4392 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4393 coff-pe-read.c, command.h, compile/compile-c-support.c,
4394 compile/compile-c.h, compile/compile-cplus-symbols.c,
4395 compile/compile-cplus-types.c, compile/compile-cplus.h,
4396 compile/compile-loc2c.c, compile/compile.c, completer.c,
4397 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4398 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4399 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4400 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4401 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4402 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4403 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4404 features/aarch64-core.c, features/aarch64-fpu.c,
4405 features/aarch64-pauth.c, features/aarch64-sve.c,
4406 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4407 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4408 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4409 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4410 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4411 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4412 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4413 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4414 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4415 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4416 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4417 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4418 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4419 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4420 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4421 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4422 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4423 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4424 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4425 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4426 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4427 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4428 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4429 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4430 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4431 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4432 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4433 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4434 minsyms.c, mips-linux-tdep.c, namespace.h,
4435 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4436 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4437 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4438 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4439 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4440 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4441 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4442 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4443 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4444 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4445 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4446 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4447 procfs.c, producer.c, progspace.h, psymtab.h,
4448 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4449 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4450 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4451 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4452 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4453 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4454 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4455 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4456 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4457 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4458 target-memory.c, target.c, target.h, target/waitstatus.c,
4459 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4460 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4461 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4462 unittests/array-view-selftests.c,
4463 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4464 unittests/common-utils-selftests.c,
4465 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4466 unittests/format_pieces-selftests.c,
4467 unittests/function-view-selftests.c,
4468 unittests/lookup_name_info-selftests.c,
4469 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4470 unittests/mkdir-recursive-selftests.c,
4471 unittests/observable-selftests.c,
4472 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4473 unittests/parse-connection-spec-selftests.c,
4474 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4475 unittests/scoped_fd-selftests.c,
4476 unittests/scoped_mmap-selftests.c,
4477 unittests/scoped_restore-selftests.c,
4478 unittests/string_view-selftests.c, unittests/style-selftests.c,
4479 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4480 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4481 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4482 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4483 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4484 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4485
5b0e2db4
AB
44862019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4487
4488 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4489 bool value.
4490 (decode_digits_ordinary): Set explicit_line field in sal.
4491 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4492 symtab_and_line that was set on an explicit line number in
4493 assembler code. Do always update the recorded symtab and line if
4494 we do skip the prologue.
4495
0ba852ab
AB
44962019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4497
4498 * breakpoint.c (set_breakpoint_location_function): Remove
4499 explicit_loc parameter.
4500 (momentary_breakpoint_from_master): Update call to
4501 set_breakpoint_location_function.
4502 (add_location_to_breakpoint): Likewise.
4503
b3a7d171
AB
45042019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4505
4506 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4507 required features based on default bfd type when no specific bfd
4508 is present.
4509
1f6f6e21
PW
45102019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4511
4512 * NEWS: Mention that GDB printf and eval commands can now print
4513 C-style and Ada-style convenience var strings without
4514 calling the inferior.
4515 * printcmd.c (printf_c_string): Locally print GDB internal var
4516 instead of transiting via the inferior.
4517 (printf_wide_c_string): Likewise.
4518
45192019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
4520
4521 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4522
0598af48
TT
45232019-07-04 Tom Tromey <tom@tromey.com>
4524
4525 PR tui/24724:
4526 * tui/tui-winsource.c (tui_clear_source_content): Update.
4527 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4528 (tui_update_breakpoint_info): Update.
4529 (tui_set_exec_info_content): Update.
4530 * tui/tui-source.c (tui_set_source_content_nil): Update.
4531 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4532 has_break.
4533 * tui/tui-data.h (enum tui_bp_flag): New.
4534 (tui_bp_flags): New enum flags type.
4535 (struct tui_source_element) <break_mode>: Change type. Rename
4536 from has_break.
4537 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4538 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4539 constants.
4540 * tui/tui-winsource.h: Fix comment.
4541
350fab54
AH
45422019-07-04 Alan Hayward <alan.hayward@arm.com>
4543
4544 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4545 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4546 (store_fpregs_to_thread)
4547 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4548 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4549 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4550 (IWMMXT_REGS_SIZE): Add define.
4551 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4552 (fetch_vfp_regs, store_vfp_regs)
4553 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4554 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4555
f0452268
AH
45562019-07-04 Alan Hayward <alan.hayward@arm.com>
4557
4558 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4559 defines.
4560 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4561 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4562 (ARM_INT_REGISTER_SIZE): ...to this.
4563 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4564 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4565 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4566 (arm_linux_collect_gregset, supply_nwfpe_register)
4567 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4568 defines.
4569 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4570 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4571 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4572 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4573 (arm_return_in_memory, arm_store_return_value)
4574 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4575 (arm_record_ld_st_multiple): Likewise.
4576 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4577 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4578
e935475c
AH
45792019-07-04 Alan Hayward <alan.hayward@arm.com>
4580
4581 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4582 AARCH64_DISPLACED_MODIFIED_INSNS.
4583 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4584 (aarch64_displaced_step_copy_insn): Likewise.
4585 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4586 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4587 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4588 ARM_DISPLACED_MODIFIED_INSNS.
4589 * arm-tdep.c (arm_gdbarch_init): Likewise.
4590 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4591 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4592 (struct arm_displaced_step_closure): Use
4593 ARM_DISPLACED_MODIFIED_INSNS.
4594
df0bb381
AH
45952019-07-04 Alan Hayward <alan.hayward@arm.com>
4596
4597 * features/Makefile: Remove unused xml files.
4598 * features/aarch64.xml: Remove.
4599 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4600 * features/i386/amd64-avx-avx512.xml: Remove.
4601 * features/i386/amd64-avx-linux.xml: Remove.
4602 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4603 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4604 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4605 * features/i386/amd64-avx-mpx.xml: Remove.
4606 * features/i386/amd64-avx.xml: Remove.
4607 * features/i386/amd64-linux.xml: Remove.
4608 * features/i386/amd64-mpx-linux.xml: Remove.
4609 * features/i386/amd64-mpx.xml: Remove.
4610 * features/i386/amd64.xml: Remove.
4611 * features/i386/i386-avx-avx512-linux.xml: Remove.
4612 * features/i386/i386-avx-avx512.xml: Remove.
4613 * features/i386/i386-avx-linux.xml: Remove.
4614 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4615 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4616 * features/i386/i386-avx-mpx-linux.xml: Remove.
4617 * features/i386/i386-avx-mpx.xml: Remove.
4618 * features/i386/i386-avx.xml: Remove.
4619 * features/i386/i386-linux.xml: Remove.
4620 * features/i386/i386-mmx-linux.xml: Remove.
4621 * features/i386/i386-mmx.xml: Remove.
4622 * features/i386/i386-mpx-linux.xml: Remove.
4623 * features/i386/i386-mpx.xml: Remove.
4624 * features/i386/i386.xml: Remove.
4625 * features/i386/x32-avx-avx512-linux.xml: Remove.
4626 * features/i386/x32-avx-linux.xml: Remove.
4627 * features/i386/x32-linux.xml: Remove.
4628
edd6266a
AH
46292019-07-04 Alan Hayward <alan.hayward@arm.com>
4630
4631 * regformats/aarch64.dat: Remove.
4632 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4633 * regformats/i386/amd64-avx-linux.dat: Remove.
4634 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4635 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4636 * regformats/i386/amd64-linux.dat: Remove.
4637 * regformats/i386/amd64-mpx-linux.dat: Remove.
4638 * regformats/i386/amd64.dat: Remove.
4639 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4640 * regformats/i386/i386-avx-linux.dat: Remove.
4641 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4642 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4643 * regformats/i386/i386-linux.dat: Remove.
4644 * regformats/i386/i386-mmx-linux.dat: Remove.
4645 * regformats/i386/i386-mpx-linux.dat: Remove.
4646 * regformats/i386/i386.dat: Remove.
4647 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4648 * regformats/i386/x32-avx-linux.dat: Remove.
4649 * regformats/i386/x32-linux.dat: Remove.
4650
2b40fda7
AH
46512019-07-04 Alan Hayward <alan.hayward@arm.com>
4652
4653 * aarch64-tdep.c: Remove xml self tests.
4654 * amd64-linux-tdep.c: Likewise.
4655 * amd64-tdep.c: Likewise.
4656 * i386-linux-tdep.c: Likewise.
4657 * i386-tdep.c: Likewise.
4658
5f4ba3e7
PA
46592019-07-03 Pedro Alves <palves@redhat.com>
4660
4661 PR cli/24732
4662 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4663 (pipe_cmd_option_defs): New.
4664 (make_pipe_cmd_options_def_group): New.
4665 (pipe_command): Use gdb::option::process_options.
4666 (pipe_command_completer): New function.
4667 (_initialize_cli_cmds): Install completer for "pipe" command.
4668
3d9be6f5
PA
46692019-07-03 Pedro Alves <palves@redhat.com>
4670
4671 * cli/cli-option.c (union option_value) <string>: New field.
4672 (struct option_def_and_value): Add ctor, move ctor, dtor and
4673 use DISABLE_COPY_AND_ASSIGN.
4674 (option_def_and_value::clear_value): New.
4675 (parse_option, save_option_value_in_ctx, get_val_type_str)
4676 (add_setshow_cmds_for_options): Handle var_string.
4677 * cli-option.h (union option_def::var_address) <string>: New
4678 field.
4679 (struct string_option_def): New.
4680 * maint-test-options.c (struct test_options_opts): Add default
4681 ctor and use DISABLE_COPY_AND_ASSIGN.
4682 <string_opt>: New field.
4683 (test_options_opts::~test_options_opts): New.
4684 (test_options_opts::dump): Also dump "-string".
4685 (test_options_option_defs): Install "string.
4686
41fc454c
PA
46872019-07-03 Pedro Alves <palves@redhat.com>
4688
4689 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4690 option_value with a null enumeration.
4691 (complete_options): Save the option values in the context.
4692 (save_option_value_in_ctx): New, factored out from ...
4693 (process_options): ... here.
4694 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4695 of the function.
4696 * maint-test-options.c (test_options_opts::dump): New, factored
4697 out from ...
4698 (maintenance_test_options_command_mode): ... here.
4699 (maintenance_test_options_command_completion_result): Delete.
4700 (maintenance_test_options_command_completion_text): Update
4701 comment.
4702 (maintenance_show_test_options_completion_result): Change
4703 prototype. Just print
4704 maintenance_test_options_command_completion_text.
4705 (save_completion_result): New.
4706 (maintenance_test_options_completer_mode): Pass options context to
4707 complete_options, and then save a dump.
4708 (_initialize_maint_test_options): Use add_cmd to install "maint
4709 show test-options-completion-result".
4710
fdbc9870
PA
47112019-07-03 Pedro Alves <palves@redhat.com>
4712
4713 * NEWS (New commands): Mention "with" and "maint with".
4714 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4715 (with_command, with_command_completer): New.
4716 (pipe_command): Adjust to new repeat_previous
4717 interface.
4718 (_initialize_cli_cmds): Install the "with" command and its "w"
4719 alias.
4720 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4721 declarations.
4722 * cli/cli-setshow.c (parse_cli_var_uinteger)
4723 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4724 argument strings for all var_types.
4725 (get_setshow_command_value_string): New, factored out from ...
4726 (do_show_command): ... this.
4727 * cli/cli-setshow.h: Include <string>.
4728 (get_setshow_command_value_string): Declare.
4729 * command.h (repeat_previous): Now returns const char *. Adjust
4730 comment.
4731 * maint.c: Include "cli/cli-cmds.h".
4732 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4733 (_initialize_maint_cmds): Register the "maintenance with" command.
4734 * top.c (repeat_previous): Move bits from pipe_command here:
4735 Return the saved command line, if any; error out if there's no
4736 command to relaunch.
4737
c6ac8931
PA
47382019-07-03 Pedro Alves <palves@redhat.com>
4739
4740 * NEWS (New commands): Mention "maint set/show test-settings"
4741 instead of "maint test-settings".
4742 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4743 (maintenance_test_settings_set_list): Rename to ...
4744 (maintenance_set_test_settings_list): ... this.
4745 (maintenance_test_settings_show_list): Rename to ...
4746 (maintenance_show_test_settings_list): ... this.
4747 (maintenance_test_settings_cmd): Delete.
4748 (maintenance_test_settings_set_cmd): ...
4749 (maintenance_set_test_settings_cmd): ... this.
4750 (maintenance_test_settings_show_cmd): ...
4751 (maintenance_show_test_settings_cmd): ... this.
4752 (maintenance_test_settings_show_value_cmd):
4753 (maintenance_show_test_settings_value_cmd): ... this.
4754 (_initialize_maint_test_settings): No longer install the "maint
4755 test-settings" prefix command. Rename "maint test-settings set"
4756 to "maint set test-settings", and "maint test-settings show" to
4757 "maint show test-settings". Adjust all subcommands.
4758
d1fcf2fd
PA
47592019-07-03 Pedro Alves <palves@redhat.com>
4760
4761 * maint-test-settings.c: Fix file's intro comment. Replace all
4762 references to "test-options" with references to "test-settings",
4763 in comments.
4764
970f9d09
PA
47652019-07-03 Pedro Alves <palves@redhat.com>
4766
4767 * maint-test-settings.c (maintenance_test_settings_xxx)
4768 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4769 New.
4770 (maintenance_test_settings_enums): Use them.
4771 (maintenance_test_settings_enum): Default to
4772 maintenance_test_settings_xxx.
4773 (_initialize_maint_test_settings): Initialize
4774 MAINTENANCE_TEST_SETTINGS_FILENAME.
4775
f3869b1a
SM
47762019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4777
4778 * breakpoint.h (remove_breakpoints_inf): Change return type to
4779 void, move function documentation here.
4780 * breakpoint.c (remove_breakpoints_inf): Change return type to
4781 void, move function documentation to header.
4782
54d66006
PA
47832019-07-02 Pedro Alves <palves@redhat.com>
4784
4785 * NEWS (Completion improvements): Mention "info threads".
4786 * thread.c (struct info_threads_opts, info_threads_option_defs)
4787 (make_info_threads_options_def_group): New.
4788 (info_threads_command): Use gdb::option::process_options.
4789 (info_threads_command_completer): New.
4790 (_initialize_thread): Use gdb::option::build_help to build the
4791 help text for "info threads".
4792
854f6088
SM
47932019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4794
4795 * defs.h (generic_load): Move from here...
4796 * symfile.h (generic_load): ... to here. Rename name parameter
4797 to args.
4798 * symfile.c (generic_load): Add comment.
4799
54ee4252
TT
48002019-07-01 Tom Tromey <tromey@adacore.com>
4801
4802 * dwarf2read.c
4803 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4804 declaration of without_params. Fix formatting.
4805
65392b3e
TT
48062019-07-01 Tom Tromey <tromey@adacore.com>
4807
4808 * ada-exp.y (find_primitive_type): Update.
4809 * ada-lang.h (ada_lookup_symbol): Update.
4810 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4811 parameter.
4812 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4813
7d7571f0
SDJ
48142019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4815
4816 PR breakpoints/24541
4817 * gdbarch.c: Regenerate.
4818 * gdbarch.h: Regenerate.
4819 * gdbarch.sh: Add 'stap_adjust_register'.
4820 * i386-tdep.c: Include '<unordered_set>'.
4821 (i386_stap_adjust_register): New function.
4822 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4823 * stap-probe.c (stap_parse_register_operand): Call
4824 'gdbarch_stap_adjust_register'.
4825
5af5392a
SDJ
48262019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4827
4828 PR python/24742
4829 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4830 * python/python.c (do_start_initialization): Use 'xmalloc'
4831 instead of 'PyMem_Malloc'.
4832
10d06d82
TT
48332019-06-28 Tom Tromey <tromey@adacore.com>
4834
4835 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4836 for Ada.
4837
1b7f24cd
TT
48382019-06-27 Tom Tromey <tromey@adacore.com>
4839
4840 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4841 objfile_key.
4842 (arm_find_mapping_symbol, arm_record_special_symbol)
4843 (_initialize_arm_tdep): Update.
4844 (arm_objfile_data_free): Remove.
4845
3d507ff2
TT
48462019-06-27 Tom Tromey <tromey@adacore.com>
4847
4848 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4849 to cp_print_static_field.
4850
762c164d
TT
48512019-06-26 Tom Tromey <tromey@adacore.com>
4852
4853 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4854 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4855 declare.
4856
aa2f9bcf
AH
48572019-06-26 Alan Hayward <alan.hayward@arm.com>
4858
4859 * features/aarch64-core.c (create_feature_aarch64_core):
4860 Regenerate.
4861 * features/aarch64-core.xml: Add cpsr flags.
4862
3426ae57
AH
48632019-06-26 Alan Hayward <alan.hayward@arm.com>
4864
4865 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4866 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4867
4838e44c
SM
48682019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4869
4870 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4871 field.
4872 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4873 use.
4874 (arm_record_special_symbol): Don't insert new symbol in sorted
4875 position, push it at the end.
4876
54cc7474
SM
48772019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4878
4879 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4880 (arm_mapping_symbol_s): Remove.
4881 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4882 (arm_mapping_symbol_vec): New typedef.
4883 (struct arm_per_objfile): Add constructor.
4884 <section_maps>: Change type to
4885 std::unique_ptr<arm_mapping_symbol_vec[]>.
4886 (arm_compare_mapping_symbols): Remove.
4887 (arm_find_mapping_symbol): Adjust to section_maps type change.
4888 (arm_objfile_data_free): Call delete on arm_per_objfile.
4889 (arm_record_special_symbol): Adjust to section_maps type change.
4890 Allocate arm_per_objfile with new.
4891
b65b566c
PW
48922019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4893
4894 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4895 with the command prefix.
4896
c2fc64f5
TT
48972019-06-25 Tom Tromey <tom@tromey.com>
4898
4899 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4900 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4901
fb54fa76
TT
49022019-06-25 Tom Tromey <tom@tromey.com>
4903
4904 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4905 type.
4906 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4907 protected.
4908
f7952c57
TT
49092019-06-25 Tom Tromey <tom@tromey.com>
4910
4911 * tui/tui-winsource.c
4912 (tui_source_window_base::set_is_exec_point_at): Add check against
4913 LOA_ADDRESS.
4914
17568d78
TT
49152019-06-25 Tom Tromey <tom@tromey.com>
4916
4917 * tui/tui-source.c (tui_set_source_content): Don't check before
4918 xfree.
4919 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4920
53e7cdba
TT
49212019-06-25 Tom Tromey <tom@tromey.com>
4922
4923 * tui/tui-winsource.h (tui_update_source_window_as_is)
4924 (tui_alloc_source_buffer, tui_line_is_displayed)
4925 (tui_addr_is_displayed): Change type of win_info.
4926 * tui/tui-winsource.c (tui_update_source_window_as_is)
4927 (tui_clear_source_content, tui_show_source_line)
4928 (tui_show_source_content, tui_source_window_base::refill)
4929 (tui_source_window_base::set_is_exec_point_at)
4930 (tui_source_window_base::set_is_exec_point_at)
4931 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4932 (tui_alloc_source_buffer, tui_line_is_displayed)
4933 (tui_addr_is_displayed): Change type of win_info. Update.
4934 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4935 (tui_source_window_base::do_make_visible_with_new_height):
4936 Update.
4937 * tui/tui-source.c (tui_set_source_content)
4938 (tui_set_source_content_nil)
4939 (tui_source_window::do_scroll_vertical): Update.
4940 * tui/tui-layout.c (show_layout): Update.
4941 * tui/tui-disasm.c (tui_set_disassem_content)
4942 (tui_disasm_window::do_scroll_vertical): Update.
4943 * tui/tui-data.h (tui_win_content): Remove.
4944 (struct tui_gen_win_info) <content, content_size>: Remove.
4945 (struct tui_source_element): Add initializers and destructor.
4946 (union tui_which_element, struct tui_win_element): Remove.
4947 (struct tui_source_window_base) <content>: New field.
4948 (struct tui_data_window): Remove destructor.
4949 (tui_alloc_content, tui_free_win_content)
4950 (tui_free_all_source_wins_content): Don't declare.
4951 * tui/tui-data.c (tui_initialize_static_data): Update.
4952 (init_content_element, tui_alloc_content): Remove.
4953 (~tui_gen_win_info): Update.
4954 (~tui_data_window, tui_free_all_source_wins_content)
4955 (tui_free_win_content, free_content, free_content_elements):
4956 Remove.
4957
7908abbf
TT
49582019-06-25 Tom Tromey <tom@tromey.com>
4959
4960 * tui/tui-winsource.h (tui_clear_source_content)
4961 (tui_erase_source_content, tui_show_source_content): Change type
4962 of win_info.
4963 * tui/tui-winsource.c (tui_clear_source_content)
4964 (tui_erase_source_content, tui_show_source_content): Change type
4965 of win_info.
4966 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4967 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4968 win_info.
4969 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4970 win_info.
4971 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4972
02c28df0
TT
49732019-06-25 Tom Tromey <tom@tromey.com>
4974
4975 * tui/tui-winsource.c (tui_clear_source_content)
4976 (tui_source_window_base::set_is_exec_point_at): Update.
4977 * tui/tui-source.c (tui_set_source_content_nil): Update.
4978 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4979 a bool.
4980 * tui/tui-data.c (init_content_element): Update.
4981
6658b1bf
TT
49822019-06-25 Tom Tromey <tom@tromey.com>
4983
4984 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4985 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4986 * tui/tui-layout.c (init_and_make_win): Update.
4987 * tui/tui.h (enum tui_win_type): Update.
4988 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4989 tui_win_is_auxillary.
4990 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4991 tui_win_is_auxillary.
4992
21e1c91e
TT
49932019-06-25 Tom Tromey <tom@tromey.com>
4994
4995 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4996 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4997 (tui_delete_data_content_windows, tui_display_all_data)
4998 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4999 Update.
5000 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5001 * tui/tui-regs.c (tui_last_regs_line_no)
5002 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5003 (tui_show_registers): Update.
5004 (tui_show_register_group): Return void. Update.
5005 (tui_display_registers_from, tui_display_reg_element_at_line)
5006 (tui_display_registers_from_line, tui_check_register_values):
5007 Update.
5008 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5009 member.
5010 (struct tui_data_window) <regs_content>: Now a std::vector.
5011 <regs_content_count>: Remove.
5012 (tui_add_content_elements, tui_free_data_content): Don't declare.
5013 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5014 (init_content_element): Remove DATA_WIN case. Add assert.
5015 (tui_add_content_elements): Remove.
5016 (tui_data_window): Update.
5017 (tui_free_data_content): Remove.
5018 (free_content_elements): Remove DATA_WIN case.
5019
115ac53b
TT
50202019-06-25 Tom Tromey <tom@tromey.com>
5021
5022 * tui/tui-data.c (tui_data_item_window): Update.
5023 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5024 * tui/tui-windata.c (tui_display_all_data)
5025 (tui_display_data_from_line): Update.
5026 (tui_check_data_values): Remove.
5027 * tui/tui-regs.c (tui_show_register_group)
5028 (tui_display_reg_element_at_line): Update.
5029 * tui/tui-hooks.c (tui_register_changed)
5030 (tui_refresh_frame_and_register_information): Call
5031 tui_check_register_values.
5032 * tui/tui-data.h (struct tui_data_window) <data_content,
5033 data_content_count, data_type>: Remove.
5034 (enum tui_data_type): Remove.
5035
5036 * tui/tui-data.c (tui_data_window::clear_detail)
5037 (~tui_data_window): Update.
5038
eaf9738b
TT
50392019-06-25 Tom Tromey <tom@tromey.com>
5040
5041 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5042 declare.
5043 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5044 Rename from tui_first_data_item_displayed. Update.
5045 (tui_data_window::refresh_all)
5046 (tui_data_window::do_scroll_vertical): Update.
5047 * tui/tui-data.h (struct tui_data_window)
5048 <first_data_item_displayed>: Declare new method.
5049
31ca4723
TT
50502019-06-25 Tom Tromey <tom@tromey.com>
5051
5052 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5053 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5054 contents...
5055 (tui_initialize_static_data): ...here.
5056
41bcff7f
TT
50572019-06-25 Tom Tromey <tom@tromey.com>
5058
5059 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5060 (tui_display_registers_from, tui_check_register_values): Update.
5061 (tui_display_register): Remove win_info parameter; update.
5062 (tui_get_register): Change type of parameters.
5063 * tui/tui-data.h (struct tui_data_element): Remove.
5064 (union tui_which_element) <data>: Remove.
5065 <data_window>: Change type.
5066 (struct tui_data_item_window): New.
5067 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5068 case. Add assert.
5069 (~tui_data_item_window): New destructor.
5070 (free_content_elements): Remove DATA_ITEM_WIN case.
5071
d2802c33
TT
50722019-06-25 Tom Tromey <tom@tromey.com>
5073
5074 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5075 Remove.
5076
dd835f8b
TT
50772019-06-25 Tom Tromey <tom@tromey.com>
5078
5079 * tui/tui-data.h (struct tui_command_element): Remove.
5080 (union tui_which_element) <command>: Remove.
5081 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5082 assert.
5083 (free_content_elements): Remove CMD_WIN case.
5084
bd7db367
TT
50852019-06-25 Tom Tromey <tom@tromey.com>
5086
5087 * tui/tui-layout.c (tui_set_layout): Update.
5088 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5089 * tui/tui-data.c (layout_def): Update.
5090
3add462f
TT
50912019-06-25 Tom Tromey <tom@tromey.com>
5092
5093 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5094 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5095 (tui_source_window_base::set_new_height): Update.
5096 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5097 Update.
5098 (tui_set_locator_fullname, tui_set_locator_info)
5099 (tui_show_frame_info): Update.
5100 * tui/tui-source.c (tui_set_source_content)
5101 (tui_source_is_displayed): Update.
5102 * tui/tui-layout.c (show_source_disasm_command, show_data)
5103 (show_source_or_disasm_and_command): Update.
5104 * tui/tui-disasm.c (tui_set_disassem_content)
5105 (tui_get_begin_asm_address): Update.
5106 * tui/tui-data.h (struct tui_locator_element): Remove.
5107 (union tui_which_element) <locator>: Remove.
5108 (struct tui_locator_window): New.
5109 (tui_locator_win_info_ptr): Change return type.
5110 * tui/tui-data.c (_locator): Change type.
5111 (tui_locator_win_info_ptr): Change return type.
5112 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5113 (tui_alloc_content): Add assert.
5114
489e9d8b
TT
51152019-06-25 Tom Tromey <tom@tromey.com>
5116
5117 * tui/tui-winsource.c
5118 (tui_exec_info_window::maybe_allocate_content): New method.
5119 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5120 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5121 (make_source_or_disasm_window): Add cast.
5122 * tui/tui-data.h (union tui_which_element) <simple_string>:
5123 Remove.
5124 (struct tui_source_info): New.
5125 (struct tui_source_window_base) <execution_info>: Change type.
5126 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5127 case, and add assert.
5128 (tui_alloc_content): Add assert.
5129
c3fabb7d
TT
51302019-06-25 Tom Tromey <tom@tromey.com>
5131
5132 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5133 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5134 * tui/tui-data.c (tui_alloc_win_info): Remove.
5135
bbc228ee
TT
51362019-06-25 Tom Tromey <tom@tromey.com>
5137
5138 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5139 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5140 can_highlight.
5141
5fcee43a
TT
51422019-06-25 Tom Tromey <tom@tromey.com>
5143
5144 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5145 make_visible_with_new_height method.
5146 (tui_win_info::make_visible_with_new_height): New method.
5147 (tui_source_window_base::do_make_visible_with_new_height)
5148 (tui_data_window::do_make_visible_with_new_height)
5149 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5150 (make_visible_with_new_height): Remove.
5151 (tui_resize_all, tui_adjust_win_heights): Use
5152 make_visible_with_new_height method.
5153 * tui/tui-data.h (struct tui_win_info)
5154 <do_make_visible_with_new_height, make_visible_with_new_height>:
5155 New methods.
5156 (struct tui_source_window_base, struct tui_data_window)
5157 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5158 methods.
5159
d83f1fe6
TT
51602019-06-25 Tom Tromey <tom@tromey.com>
5161
5162 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5163 method.
5164 (update_tab_width): Call update_tab_width method.
5165 * tui/tui-data.h (struct tui_win_info)
5166 (struct tui_source_window_base) <update_tab_width>: New methods.
5167
17374de4
TT
51682019-06-25 Tom Tromey <tom@tromey.com>
5169
5170 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5171 parameter.
5172 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5173 parameter.
5174 (tui_gen_win_info::make_visible): Update.
5175 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5176 parameter.
5177 * tui/tui-data.h (enum tui_box): New enum.
5178 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5179
f936bca2
TT
51802019-06-25 Tom Tromey <tom@tromey.com>
5181
5182 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5183 init_and_make_win for EXEC_INFO_WIN.
5184 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5185 longer inline.
5186 (struct tui_win_info) <~tui_win_info>: Inline.
5187 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5188 Don't declare.
5189 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5190 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5191 Remove.
5192 (tui_initialize_static_data): Update.
5193 (~tui_gen_win_info): Handle more cleanup here.
5194 (~tui_source_window_base): Delete "execution_info".
5195 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5196
d6ba6a11
TT
51972019-06-25 Tom Tromey <tom@tromey.com>
5198
5199 * tui/tui-layout.c (make_command_window): Don't set
5200 can_highlight.
5201 (show_source_disasm_command): Call the reset method.
5202 (show_data): Don't set can_highlight. Call the reset method.
5203 (tui_gen_win_info::reset): Rename from init_gen_win_info
5204 (init_and_make_win): Simplify. Return tui_gen_win_info.
5205 (show_source_or_disasm_and_command): Call the reset method.
5206 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5207 (struct tui_cmd_window): Set can_highlight.
5208
48a3bd16
TT
52092019-06-25 Tom Tromey <tom@tromey.com>
5210
5211 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5212 from make_visible.
5213 (tui_make_visible, tui_make_invisible): Rewrite.
5214 (tui_win_info::make_visible): Remove.
5215 (tui_source_window_base::make_visible): Update.
5216 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5217 method. Moved from...
5218 (struct tui_win_info) <make_visible>: ...here.
5219
c3bd716f
TT
52202019-06-25 Tom Tromey <tom@tromey.com>
5221
5222 * tui/tui-winsource.c
5223 (tui_source_window_base::do_scroll_horizontal): Remove direction
5224 parameter.
5225 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5226 direction parameter.
5227 * tui/tui-win.c (tui_win_info::forward_scroll)
5228 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5229 (tui_win_info::right_scroll): Update.
5230 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5231 direction parameter.
5232 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5233 direction parameter.
5234 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5235 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5236 Remove direction parameter.
5237 (struct tui_source_window_base, struct tui_source_window)
5238 (struct tui_disasm_window, struct tui_data_window)
5239 (struct tui_cmd_window): Update.
5240
21c32dca
TT
52412019-06-25 Tom Tromey <tom@tromey.com>
5242
5243 * tui/tui-winsource.h (tui_set_exec_info_content)
5244 (tui_show_exec_info_content, tui_erase_exec_info_content)
5245 (tui_clear_exec_info_content, tui_update_exec_info): Change
5246 argument to tui_source_window_base.
5247 * tui/tui-winsource.c (tui_set_exec_info_content)
5248 (tui_show_exec_info_content, tui_erase_exec_info_content)
5249 (tui_clear_exec_info_content, tui_update_exec_info): Change
5250 argument to tui_source_window_base.
5251
73fbdc65
TT
52522019-06-25 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5255 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5256
33325343
TT
52572019-06-25 Tom Tromey <tom@tromey.com>
5258
5259 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5260 check.
5261
29d2c474
TT
52622019-06-25 Tom Tromey <tom@tromey.com>
5263
5264 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5265 type to void.
5266 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5267 type to void.
5268 * tui/tui-source.c (tui_set_source_content): Update.
5269 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5270
152f3f4b
TT
52712019-06-25 Tom Tromey <tom@tromey.com>
5272
5273 * tui/tui-win.c (window_name_completer, tui_set_focus)
5274 (tui_all_windows_info): Use name method.
5275 * tui/tui-data.h (struct tui_gen_win_info)
5276 (struct tui_source_window, struct tui_disasm_window)
5277 (struct tui_data_window, struct tui_cmd_window) <name>: New
5278 method.
5279 (tui_win_name): Don't declare.
5280 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5281 (tui_win_name): Remove.
5282
be4da588
TT
52832019-06-25 Tom Tromey <tom@tromey.com>
5284
5285 * tui/tui-winsource.h (tui_update_source_window)
5286 (tui_update_source_window_as_is): Change parameter type.
5287 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5288 to be a tui_source_window_base.
5289 (tui_update_source_window_as_is): Likewise.
5290 * tui/tui-win.c (make_visible_with_new_height): Update.
5291
5b81daba
TT
52922019-06-25 Tom Tromey <tom@tromey.com>
5293
5294 * tui/tui-winsource.c (tui_erase_source_content)
5295 (tui_show_source_content, tui_show_exec_info_content)
5296 (tui_erase_exec_info_content): Use refresh_window method.
5297 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5298 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5299 from tui_refresh_win.
5300 (tui_data_window::refresh_window): New method.
5301 (tui_win_info::refresh, tui_source_window_base::refresh)
5302 (tui_refresh_all): Use refresh_window method.
5303 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5304 method.
5305 * tui/tui-regs.c (tui_display_register): Call refresh_window
5306 method.
5307 * tui/tui-layout.c (show_source_disasm_command)
5308 (show_source_or_disasm_and_command): Call refresh_window method.
5309 * tui/tui-data.h (struct tui_gen_win_info)
5310 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5311 New method.
5312
cb2ce893
TT
53132019-06-25 Tom Tromey <tom@tromey.com>
5314
5315 * tui/tui.c (tui_rl_other_window, tui_enable)
5316 (tui_is_window_visible, tui_get_command_dimension): Update.
5317 * tui/tui-winsource.c (tui_update_source_window_as_is)
5318 (tui_clear_source_content, tui_erase_source_content)
5319 (tui_show_source_line, tui_source_window_base::refill)
5320 (tui_source_window_base::do_scroll_horizontal)
5321 (tui_source_window_base::set_is_exec_point_at)
5322 (tui_update_breakpoint_info, tui_set_exec_info_content)
5323 (tui_alloc_source_buffer, tui_line_is_displayed)
5324 (tui_addr_is_displayed): Update.
5325 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5326 (tui_check_and_display_highlight_if_needed)
5327 (tui_win_info::make_visible, tui_win_info::refresh)
5328 (tui_refresh_all): Update.
5329 * tui/tui-windata.c (tui_first_data_item_displayed)
5330 (tui_delete_data_content_windows, tui_erase_data_content)
5331 (tui_display_all_data, tui_data_window::refresh_all)
5332 (tui_check_data_values): Update.
5333 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5334 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5335 (tui_win_info::backward_scroll, tui_refresh_all_win)
5336 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5337 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5338 (tui_source_window_base::set_new_height)
5339 (tui_data_window::set_new_height)
5340 (make_invisible_and_set_new_height)
5341 (make_visible_with_new_height, new_height_ok)
5342 (parse_scrolling_args): Update.
5343 * tui/tui-stack.c (tui_show_frame_info): Update.
5344 * tui/tui-source.c (tui_set_source_content)
5345 (tui_set_source_content_nil, tui_source_is_displayed)
5346 (tui_source_window::do_scroll_vertical): Update.
5347 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5348 (tui_display_registers_from, tui_display_reg_element_at_line)
5349 (tui_check_register_values, tui_reg_command): Update.
5350 * tui/tui-layout.c (tui_default_win_height)
5351 (show_source_disasm_command, show_data, init_and_make_win)
5352 (show_source_or_disasm_and_command): Update.
5353 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5354 (tui_redisplay_readline, tui_mld_flush)
5355 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5356 (tui_getc): Update.
5357 * tui/tui-disasm.c (tui_set_disassem_content)
5358 (tui_disasm_window::do_scroll_vertical): Update.
5359 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5360 Now virtual.
5361 (struct tui_win_info): Derive from tui_gen_win_info.
5362 <~tui_win_info>: Mark as override.
5363 <generic>: Remove member.
5364 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5365 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5366 (~tui_data_window, ~tui_win_info)
5367 (tui_free_all_source_wins_content): Update.
5368 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5369
ab313b35
TT
53702019-06-25 Tom Tromey <tom@tromey.com>
5371
5372 * tui/tui-layout.c (init_and_make_win): Use new.
5373 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5374 destructor, initializers.
5375 (tui_alloc_generic_win_info): Don't declare.
5376 * tui/tui-data.c (_locator): Add argument to constructor.
5377 (source_win, disasm_win): New globals.
5378 (exec_info): Remove.
5379 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5380 Update.
5381 (tui_alloc_generic_win_info): Remove.
5382 (init_content_element): Use new.
5383 (tui_win_info::tui_win_info): Update.
5384 (free_content_elements) <case DATA_WIN>: Use delete.
5385
dc2c33e4
TT
53862019-06-25 Tom Tromey <tom@tromey.com>
5387
5388 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5389 * tui/tui-windata.c (tui_first_data_item_displayed)
5390 (tui_delete_data_content_windows): Update.
5391 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5392 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5393 (tui_display_registers_from, tui_check_register_values): Update.
5394 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5395 pointer.
5396 * tui/tui-data.c (init_content_element): Update. Allocate the new
5397 window.
5398 (tui_free_data_content): Update.
5399 (free_content_elements) <case DATA_WIN>: Free the window.
5400
214a5cbe
TT
54012019-06-25 Tom Tromey <tom@tromey.com>
5402
5403 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5404 Update.
5405 * tui/tui-layout.c (make_command_window)
5406 (show_source_disasm_command, show_data, init_and_make_win)
5407 (show_source_or_disasm_and_command): Update.
5408 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5409 method.
5410 <can_highight, is_highlighted>: Now bool.
5411 (tui_set_win_highlight): Don't declare.
5412 * tui/tui-data.c (tui_set_win_highlight): Remove.
5413
8e2daf15
TT
54142019-06-25 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-wingeneral.c (make_visible): Remove check of window
5417 type.
5418
8903bd8a
TT
54192019-06-25 Tom Tromey <tom@tromey.com>
5420
5421 * tui/tui-win.c (tui_win_info::max_height)
5422 (tui_cmd_window::max_height): New methods.
5423 (new_height_ok): Call max_height.
5424 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5425 <max_height>: New method.
5426
3f02ce1e
TT
54272019-06-25 Tom Tromey <tom@tromey.com>
5428
5429 * tui/tui-win.c (tui_source_window_base::set_new_height)
5430 (tui_data_window::set_new_height): New methods.
5431 (make_invisible_and_set_new_height): Call set_new_height method.
5432 * tui/tui-data.h (struct tui_win_info)
5433 (struct tui_source_window_base, struct tui_data_window)
5434 <set_new_height>: New method.
5435
1825f487
TT
54362019-06-25 Tom Tromey <tom@tromey.com>
5437
5438 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5439 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5440 tui_refresh_data_win.
5441 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5442 method.
5443 (tui_refresh_all_win): Call the refresh_all method.
5444 (tui_set_focus): Likewise.
5445 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5446 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5447 Likewise.
5448
ad54d15b
TT
54492019-06-25 Tom Tromey <tom@tromey.com>
5450
5451 * tui/tui-winsource.h (tui_refill_source_window)
5452 (tui_set_is_exec_point_at): Don't declare.
5453 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5454 (tui_source_window_base::refill): Rename from
5455 tui_refill_source_window.
5456 (tui_source_window_base::do_scroll_horizontal): Update.
5457 (tui_source_window_base::set_is_exec_point_at): Rename from
5458 tui_set_is_exec_point_at.
5459 (tui_update_all_breakpoint_info): Update.
5460 * tui/tui-stack.c (tui_show_frame_info): Update.
5461 * tui/tui-layout.c (show_data): Add cast.
5462 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5463 * tui/tui-data.h (struct tui_source_window_base) <refill,
5464 set_is_exec_point_at>: New methods.
5465 (tui_source_windows, tui_add_to_source_windows): Update types.
5466 (tui_add_to_source_windows): Remove redundant declaration.
5467 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5468 (tui_source_windows): Change return type.
5469 (tui_clear_source_windows_detail): Update.
5470 (tui_add_to_source_windows): Change type of parameter.
5471 (tui_free_all_source_wins_content): Update.
5472
2042b506
TT
54732019-06-25 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-wingeneral.c (tui_win_info::refresh)
5476 (tui_source_window_base::refresh): New methods.
5477 (tui_refresh_all): Call the refresh method.
5478 * tui/tui-data.h (struct tui_win_info)
5479 (struct tui_source_window_base) <refresh>: New method.
5480
56122977
TT
54812019-06-25 Tom Tromey <tom@tromey.com>
5482
5483 * tui/tui.h (tui_is_window_visible): Return bool.
5484 * tui/tui.c (tui_is_window_visible): Return bool.
5485 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5486 (tui_make_visible, tui_make_invisible)
5487 (tui_win_info::make_visible)
5488 (tui_source_window_base::make_visible, make_all_visible)
5489 (tui_make_all_visible, tui_make_all_invisible): Update.
5490 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5491 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5492 bool.
5493 (struct tui_win_info, struct tui_source_window_base)
5494 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5495 * tui/tui-data.c (tui_init_generic_part): Update.
5496
cda37efb
TT
54972019-06-25 Tom Tromey <tom@tromey.com>
5498
5499 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5500 (tui_source_window_base::make_visible): New methods.
5501 (make_all_visible): Make method call.
5502 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5503 (struct tui_source_window_base, struct tui_cmd_window): Override
5504 make_visible.
5505 (tui_win_is_source_type): Don't declare.
5506 * tui/tui-data.c (tui_win_is_source_type): Remove.
5507
6a0ee02c
TT
55082019-06-25 Tom Tromey <tom@tromey.com>
5509
5510 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5511 NULL check.
5512
63901aec
TT
55132019-06-25 Tom Tromey <tom@tromey.com>
5514
5515 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5516 Inline constructor. Add initializers for members.
5517 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5518 constructors; now inline in class.
5519
ceb13a13
TT
55202019-06-25 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui-regs.c (tui_show_registers): Update.
5523 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5524 bool.
5525 * tui/tui-data.c (tui_data_window::clear_detail)
5526 (tui_data_window): Update.
5527
238eb706
TT
55282019-06-25 Tom Tromey <tom@tromey.com>
5529
5530 * tui/tui-windata.c (tui_display_all_data)
5531 (tui_display_data_from_line, tui_display_data_from)
5532 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5533 Update.
5534 * tui/tui-regs.c (tui_last_regs_line_no)
5535 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5536 (tui_show_registers, tui_show_register_group)
5537 (tui_display_registers_from, tui_display_reg_element_at_line)
5538 (tui_display_registers_from_line, tui_check_register_values)
5539 (tui_reg_next, tui_reg_prev): Update.
5540 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5541 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5542 tui_data_window.
5543 (struct tui_win_info) <detail>: Remove. Add new fields from
5544 tui_data_info.
5545 (TUI_DATA_WIN): Add cast.
5546 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5547 (~tui_data_window): Simplify.
5548
81491aa0
TT
55492019-06-25 Tom Tromey <tom@tromey.com>
5550
5551 * tui/tui-layout.c (show_source_disasm_command)
5552 (show_source_or_disasm_and_command): Update.
5553 * tui/tui-io.c (update_cmdwin_start_line)
5554 (tui_redisplay_readline): Update.
5555 * tui/tui-data.h (struct tui_command_info): Remove.
5556 (struct tui_win_info) <detail>: Remove command_info member.
5557 (struct tui_data_window) <start_line>: New member, from
5558 tui_command_info.
5559 (TUI_CMD_WIN): Add casts.
5560
e6e41501
TT
55612019-06-25 Tom Tromey <tom@tromey.com>
5562
5563 * tui/tui-winsource.c (tui_update_source_window)
5564 (tui_refill_source_window)
5565 (tui_source_window_base::do_scroll_horizontal)
5566 (tui_update_breakpoint_info, tui_set_exec_info_content)
5567 (tui_show_exec_info_content, tui_erase_exec_info_content)
5568 (tui_clear_exec_info_content): Update.
5569 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5570 Update.
5571 * tui/tui-win.c (make_invisible_and_set_new_height)
5572 (make_visible_with_new_height): Update.
5573 * tui/tui-source.c (tui_set_source_content)
5574 (tui_show_symtab_source): Update.
5575 * tui/tui-layout.c (extract_display_start_addr)
5576 (show_source_disasm_command, show_data)
5577 (make_source_or_disasm_window)
5578 (show_source_or_disasm_and_command): Update.
5579 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5580 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5581 "gdbarch".
5582 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5583 to tui_source_window_base.
5584 (struct tui_win_info) <detail>: Remove source_info member.
5585 (struct tui_source_window_base) <has_locator>: Inline.
5586 Move contents from tui_source_info; rename has_locator member to
5587 m_has_locator.
5588 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5589 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5590 header file.
5591 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5592 Simplify.
5593 (tui_free_all_source_wins_content): Cast to
5594 tui_source_window_base.
5595
44f0e208
TT
55962019-06-25 Tom Tromey <tom@tromey.com>
5597
5598 * tui/tui-win.c (make_invisible_and_set_new_height)
5599 (make_visible_with_new_height): Call has_locator method.
5600 * tui/tui-layout.c (show_source_disasm_command, show_data)
5601 (show_source_or_disasm_and_command): Update for bool change.
5602 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5603 (tui_win_info) <has_locator>: New method.
5604 (struct tui_source_window_base) <has_locator>: New method.
5605 (tui_win_has_locator): Don't declare.
5606 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5607 from tui_win_has_locator.
5608 (tui_source_window_base): Use false, not FALSE.
5609
7778b912
TT
56102019-06-25 Tom Tromey <tom@tromey.com>
5611
5612 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5613 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5614 clear_detail method directly.
5615 (tui_clear_win_detail): Remove.
5616
f83d391c
TT
56172019-06-25 Tom Tromey <tom@tromey.com>
5618
5619 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5620 "this", not TUI_DISASM_WIN.
5621
13446e05
TT
56222019-06-25 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5625 declare.
5626 * tui/tui-winsource.c
5627 (tui_source_window_base::do_scroll_horizontal): Rename from
5628 tui_horizontal_source_scroll.
5629 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5630 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5631 from tui_vertical_data_scroll.
5632 * tui/tui-win.h (tui_scroll): Don't declare.
5633 * tui/tui-win.c (tui_win_info::forward_scroll)
5634 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5635 (tui_win_info::right_scroll): Rename and update.
5636 (tui_scroll_forward_command, tui_scroll_backward_command)
5637 (tui_scroll_left_command, tui_scroll_right_command): Update.
5638 (tui_scroll): Remove.
5639 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5640 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5641 from tui_vertical_source_scroll.
5642 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5643 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5644 from tui_vertical_disassem_scroll.
5645 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5646 do_scroll_horizontal>: New methods.
5647 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5648 Likewise.
5649 (struct tui_source_window_base): Add do_scroll_horizontal.
5650 (struct tui_source_window, struct tui_disasm_window): Add
5651 do_scroll_vertical.
5652 (struct tui_data_window, struct tui_cmd_window): Add
5653 do_scroll_horizontal and do_scroll_vertical.
5654 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5655
5cf82909
TT
56562019-06-25 Tom Tromey <tom@tromey.com>
5657
5658 * tui/tui-data.h (struct tui_source_window_base): New struct.
5659 (struct tui_source_window): Derive from tui_source_window_base.
5660 (struct tui_disasm_window): New struct.
5661 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5662 from tui_source_window::clear_detail.
5663 (tui_source_window_base): Rename from tui_source_window.
5664 (~tui_source_window_base): Rename from ~tui_source_window.
5665 (tui_alloc_win_info): Create a tui_disasm_window.
5666
ee1d42d6
TT
56672019-06-25 Tom Tromey <tom@tromey.com>
5668
5669 * tui/tui-data.h (struct tui_source_window)
5670 (struct tui_data_window): Declare destructors.
5671 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5672 destructors.
5673 (tui_win_info): Simplify.
5674
b4eb2452
TT
56752019-06-25 Tom Tromey <tom@tromey.com>
5676
5677 * tui/tui-winsource.c (tui_display_main)
5678 (tui_update_source_windows_with_addr)
5679 (tui_update_all_breakpoint_info): Update.
5680 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5681 (new_height_ok, parse_scrolling_args): Update.
5682 * tui/tui-stack.c (tui_show_frame_info): Update.
5683 * tui/tui-data.h (struct tui_list): Remove.
5684 (tui_source_windows): Return a reference to a std::vector.
5685 * tui/tui-data.c (source_windows): Now a std::vector.
5686 (tui_source_windows): Change return type.
5687 (tui_clear_source_windows): Rewrite.
5688 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5689 (tui_free_all_source_wins_content): Rewrite.
5690
8761a91b
TT
56912019-06-25 Tom Tromey <tom@tromey.com>
5692
5693 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5694 (struct tui_data_window, struct tui_cmd_window): Declare
5695 clear_detail method.
5696 * tui/tui-data.c (tui_source_window::clear_detail)
5697 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5698 methods.
5699 (tui_clear_win_detail): Simplify.
5700
0ed69eda
TT
57012019-06-25 Tom Tromey <tom@tromey.com>
5702
5703 * tui/tui-layout.c (make_source_window, make_disasm_window)
5704 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5705 Return the new window.
5706 (show_source_disasm_command, show_data)
5707 (show_source_or_disasm_and_command): Update.
5708
82432e10
TT
57092019-06-25 Tom Tromey <tom@tromey.com>
5710
5711 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5712 parameter. Return the new window.
5713 (show_source_disasm_command): Update and remove NULL check.
5714 (show_source_or_disasm_and_command): Update.
5715
ec328aa5
TT
57162019-06-25 Tom Tromey <tom@tromey.com>
5717
5718 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5719
33b906ab
TT
57202019-06-25 Tom Tromey <tom@tromey.com>
5721
5722 * tui/tui-data.h (struct tui_win_info): Make constructor
5723 protected. Make destructor virtual. Add initializers.
5724 (tui_source_window, tui_data_window, tui_cmd_window): New
5725 classes.
5726 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5727 constructor. Add "type" parameter.
5728 (tui_source_window, tui_data_window, tui_cmd_window): New
5729 constructors.
5730 (tui_alloc_win_info): Instantiate the appropriate subclass.
5731
e7e11af4
TT
57322019-06-25 Tom Tromey <tom@tromey.com>
5733
5734 * tui/tui-win.c (tui_resize_all): Use delete.
5735 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5736 destructor.
5737 (tui_free_window): Don't declare.
5738 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5739 Update.
5740
6792b55e
TT
57412019-06-25 Tom Tromey <tom@tromey.com>
5742
5743 * tui/tui-data.h (struct tui_win_info): Add constructor.
5744 * tui/tui-data.c (tui_alloc_win_info): Use new.
5745 (tui_free_window): Use delete.
5746
f95675e1
TT
57472019-06-22 Tom Tromey <tom@tromey.com>
5748
5749 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5750 declare.
5751 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5752
5bff081c
TT
57532019-06-22 Tom Tromey <tom@tromey.com>
5754
5755 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5756 declare.
5757 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5758
47e3f474
TV
57592019-06-22 Tom de Vries <tdevries@suse.de>
5760
5761 * dwarf2read.c (create_addrmap_from_aranges)
5762 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5763 instead of '%zu'.
5764
fd5866f6
SM
57652019-06-21 Simon Marchi <simon.marchi@efficios.com>
5766
5767 * dwarf2read.h (dwarf2_section_info_def): Remove.
5768 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5769 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5770 std::vector<dwarf2_section_info>.
5771 (struct dwo_file) <~dwo_file>: Remove.
5772 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5773 types field.
5774 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5775 (dwarf2_read_debug_names): Likewise.
5776 (create_debug_types_hash_table): Change parameter type to
5777 array_view, adjust code accordingly.
5778 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5779 (partial_die_info::fixup): Likewise.
5780 (determine_prefix): Likewise.
5781 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5782
fb1eb2f9
SM
57832019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5784
5785 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5786 gdb_bfd_ref_ptr.
5787 <~dwo_file>: Remove call to gdb_bfd_unref.
5788 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5789 gdb_bfd_ref_ptr::get.
5790
51ac9db5
SM
57912019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5792
5793 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5794 type to htab_up.
5795 * dwarf2read.c (struct dwo_file): Initialize fields.
5796 <~dwo_file>: New.
5797 (free_dwo_file): Remove, move content to ~dwo_file.
5798 (struct dwo_file_deleter): Remove.
5799 (dwo_file_up>: Remove custom deleter.
5800 (free_dwo_files): Remove.
5801 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5802 dwo_files.
5803 (process_skeletonless_type_units): Call unique_ptr::get.
5804 (allocate_dwo_file_hash_table): Add deleter to created hash
5805 table. Change return type to htab_up.
5806 (lookup_dwo_file_slot): Don't memset dwo_file, call
5807 unique_ptr::get.
5808 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5809 (create_dwo_unit_in_dwp_v2): Likewise.
5810 (open_and_init_dwo_file): Likewise.
5811 (free_dwo_file_from_slot): Remove.
5812
dc4ccb6f
SM
58132019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5814
5815 * dwarf2read.h (struct dwarf2_section_info) <readin,
5816 is_virtual>: Change type to bool.
5817 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5818 true instead of 1.
5819
e6a1c5cb
TT
58202019-06-19 Tom Tromey <tom@tromey.com>
5821
5822 * tui/tui-data.h (tui_init_content_element): Don't declare.
5823
6f6ffbeb
TT
58242019-06-19 Tom Tromey <tom@tromey.com>
5825
5826 * tui/tui-data.h (tui_init_win_info): Don't declare.
5827
f23f598e
TV
58282019-06-19 Tom de Vries <tdevries@suse.de>
5829
5830 * dwarf2read.h (abstract_to_concrete): Change type to
5831 std::unordered_map<sect_offset, std::vector<sect_offset>,
5832 gdb::hash_enum<sect_offset>>.
5833
680e1bee
TT
58342019-06-19 Tom Tromey <tromey@adacore.com>
5835
5836 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5837 EVAL_AVOID_SIDE_EFFECTS specially.
5838
dcf37923
TT
58392019-06-19 Tom Tromey <tromey@adacore.com>
5840
5841 * source-cache.c (highlighter): New global.
5842 (source_cache::get_source_lines): Create a highlighter on demand.
5843
494986d5
AB
58442019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5845
5846 * defs.h (deprecated_interactive_hook): Delete declaration.
5847 * interps.c (clear_interpreter_hooks): Remove use of
5848 deprecated_interactive_hook.
5849 * top.c (deprecated_interactive_hook): Delete definition.
5850 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5851
3360b6e7
TV
58522019-06-18 Tom de Vries <tdevries@suse.de>
5853
5854 PR gdb/24515
5855 * dwarf2read.h (abstract_to_concrete): Change type from
5856 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5857 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5858 * dwarf2read.c (read_variable): Update.
5859 (dwarf2_fetch_die_loc_sect_off): Update.
5860
310b3441
TV
58612019-06-17 Tom de Vries <tdevries@suse.de>
5862
5863 PR gdb/24617
5864 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5865 accessing parent[parent_len - 1].
5866
ba9777be
PP
58672019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5868
5869 PR gdb/24364
5870 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5871 call dtrace_process_dof with NULL dof.
5872
2b9f6e89
TV
58732019-06-16 Tom de Vries <tdevries@suse.de>
5874
5875 PR gdb/24445
5876 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5877
431b3ead
TT
58782019-06-16 Tom Tromey <tom@tromey.com>
5879
5880 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5881 (make_all_visible): Use address of member.
5882
d04b44a1
TT
58832019-06-16 Tom Tromey <tom@tromey.com>
5884
5885 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5886 (tui_free_window, free_content, free_content_elements): Remove
5887 unnecessary cast.
5888 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5889 cast.
5890 * tui/tui-regs.c (tui_show_register_group)
5891 (tui_display_registers_from, tui_display_reg_element_at_line):
5892 Remove unnecessary cast.
5893
bf5142e7
AB
58942019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5895
5896 * linux-nat.c (normal_mask): Delete.
5897 (_initialize_linux_nat): Don't initialise normal_mask.
5898
c4973306
SM
58992019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5900
5901 PR gdb/24445
5902 * dwarf-index-write.h (write_psymtabs_to_index): Add
5903 dwz_basename parameter.
5904 * dwarf-index-write.c (write_gdbindex): Move file writing to
5905 write_gdbindex_1. Change return type void.
5906 (assert_file_size): Move up, remove filename parameter.
5907 (write_gdbindex_1): New function.
5908 (write_debug_names): Change return type to void, call
5909 assert_file_size.
5910 (struct index_wip_file): New struct.
5911 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5912 file logic to index_wip_file. Write index for dwz file if
5913 needed.
5914 (save_gdb_index_command): Pass basename of dwz file, if present.
5915 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5916 build-id of dwz file, if present.
5917 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5918 (dwarf2_get_dwz_file): Likewise.
5919 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5920 (dwarf2_get_dwz_file): Likewise.
5921
395f9c91
TT
59222019-06-16 Tom Tromey <tom@tromey.com>
5923
5924 * coffread.c (process_coff_symbol): Use xstrdup.
5925 * value.c (create_internalvar): Use xstrdup.
5926
cafb3438
TT
59272019-06-16 Tom Tromey <tom@tromey.com>
5928
5929 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5930 * breakpoint.c (stopin_command, stopat_command)
5931 (until_break_command, decode_location_default): Remove unnecessary
5932 cast.
5933 * utils.c (subset_compare): Remove unnecessary cast.
5934 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5935 cast.
5936 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5937 cast.
5938 * infcmd.c (path_command): Remove unnecessary cast.
5939 * coffread.c (decode_type): Remove unnecessary cast.
5940 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5941 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5942 * tui/tui-stack.c (tui_show_locator_content)
5943 (tui_show_frame_info): Remove unnecessary cast.
5944 * tui/tui-win.c (tui_scroll_forward_command)
5945 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5946 (parse_scrolling_args): Remove unnecessary cast.
5947 * tui/tui-data.c (init_win_info, tui_del_window)
5948 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5949 (free_content_elements): Remove unnecessary cast.
5950 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5951 unnecessary cast.
5952 * tui/tui-source.c (tui_set_source_content)
5953 (tui_vertical_source_scroll): Remove unnecessary cast.
5954 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5955 cast.
5956 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5957 * tui/tui-regs.c (tui_display_registers_from)
5958 (tui_display_register): Remove unnecessary cast.
5959 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5960 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5961 (make_visible): Remove unnecessary cast.
5962 * tui/tui-winsource.c (tui_erase_source_content)
5963 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5964 unnecessary cast.
5965 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5966 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5967 * stabsread.c (read_type, read_array_type, read_range_type):
5968 Remove unnecessary cast.
5969 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5970 (parse_symbol, parse_type, upgrade_type, parse_external)
5971 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5972 unnecessary cast.
5973 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5974
730ead81
TT
59752019-06-16 Tom Tromey <tom@tromey.com>
5976
5977 * tui/tui-data.c (tui_alloc_generic_win_info)
5978 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5979 checks.
5980
584a927c
AB
59812019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5982 Andrew Burgess <andrew.burgess@embecosm.com>
5983
5984 * f-typeprint.c (f_print_type): Don't return early for not
5985 associated or not allocated types.
5986 (f_type_print_varspec_suffix): Add print_rank parameter and print
5987 ranks of array types in case they dangling.
5988 (f_type_print_base): Add print_rank parameter.
5989
30056ea0
AB
59902019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5991
5992 * NEWS: Mention new MI commands.
5993 * break-catch-throw.c (enum exception_event_kind): Move to
5994 breakpoint.h.
5995 (print_mention_exception_catchpoint): Output text as a single
5996 message.
5997 (catch_exception_command_1): Rename to...
5998 (catch_exception_event): ...this, make non-static, update header
5999 command, and change some parameter types.
6000 (catch_catch_command): Update for changes to
6001 catch_exception_command_1.
6002 (catch_throw_command): Likewise.
6003 (catch_rethrow_command): Likewise.
6004 * breakpoint.c (enum exception_event_kind): Delete.
6005 * breakpoint.h (enum exception_event_kind): Moved here from
6006 break-catch-throw.c.
6007 (catch_exception_event): Declare.
6008 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6009 (mi_cmd_catch_throw): New function.
6010 (mi_cmd_catch_rethrow): New function.
6011 (mi_cmd_catch_catch): New function.
6012 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6013 'catch-catch' entries.
6014 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6015 (mi_cmd_catch_rethrow): Declare.
6016 (mi_cmd_catch_catch): Declare.
6017
ec8e2b6d
AB
60182019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6019
6020 * annotate.c (annotate_source_line): Change return type to void,
6021 update implementation to match.
6022 * annotate.h (annotate_source_line): Change return type to void,
6023 update header comment.
6024 * stack.c (print_frame_info): Don't change what frame information
6025 is printed based on whether annotations are on or not.
6026
0d3abd8c
AB
60272019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6028
6029 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6030 (annotate_source): Make static.
6031 (annotate_source_line): Moved from source.c and renamed from
6032 identify_source_line. Update the return type.
6033 * annotate.h (annotate_source): Delete declaration.
6034 (annotate_source_line): Declaration moved from source.h, and
6035 renamed from identify_source_line. Return type updated.
6036 * source.c (identify_source_line): Moved to annotate.c and renamed
6037 to annotate_source_line.
6038 (info_line_command): Remove check of annotation_level.
6039 * source.h (identify_source_line): Move declaration to annotate.h
6040 and rename to annotate_source_line.
6041 * stack.c: Add 'annotate.h' include.
6042 (print_frame_info): Remove check of annotation_level before
6043 calling annotate_source_line.
6044
00df30ae
AB
60452019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6046
6047 * source-cache.c (source_cache::get_plain_source_lines): Use
6048 open_source_file_with_line_charpos instead of just
6049 open_source_file, remove call to find_source_lines.
6050 (source_cache::get_source_lines): Likewise.
6051 * source.c (find_source_lines): Make static.
6052 (get_filename_and_charpos): Renamed into...
6053 (open_source_file_with_line_charpos): ..this along with changes to
6054 return a scoped_fd, and some other minor clean ups.
6055 (identify_source_line): Use open_source_file_with_line_charpos.
6056 (search_command_helper): Use open_source_file_with_line_charpos
6057 instead of just open_source_file, remove call to
6058 find_source_lines.
6059 * source.h (open_source_file_with_line_charpos): Declare new
6060 function.
6061 (find_source_lines): Delete declaration.
6062
afda45a2
AB
60632019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6064
6065 * source.c (get_filename_and_charpos): Remove fullname
6066 parameter.
6067 (identify_source_line): Update call to get_filename_and_charpos.
6068
0735b091
TT
60692019-06-14 Tom Tromey <tromey@adacore.com>
6070
6071 PR gdb/24502:
6072 * ui-style.h (skip_ansi_escape): Update comment.
6073 * ui-file.h (class no_terminal_escape_file): New class.
6074 * ui-file.c (no_terminal_escape_file::write)
6075 (no_terminal_escape_file::puts): New methods.
6076 * cli/cli-logging.c (handle_redirections): Use
6077 no_terminal_escape_file.
6078
52ce35e2
TT
60792019-06-14 Tom Tromey <tromey@adacore.com>
6080
6081 * NEWS: Move convenience variable news above Python news.
6082
73cc7272
TT
60832019-06-14 Tom Tromey <tom@tromey.com>
6084
6085 * gnulib: Move directory to top-level.
6086 * configure.ac: Don't configure gnulib.
6087 * configure: Rebuild.
6088 * common/common-defs.h: Use new path to gnulib.
6089 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6090 (GNULIB_H): Remove.
6091 (INCGNU): Look in new gnulib location.
6092 (HFILES_NO_SRCDIR): Remove gnulib files.
6093 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6094 (generated_files): Remove GNULIB_H.
6095 ($(LIBGNU), all-lib): Remove targets.
6096 (distclean): Don't mention GNULIB_BUILDDIR.
6097 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6098
f5686554
TT
60992019-06-14 Tom Tromey <tromey@adacore.com>
6100
6101 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6102 Warn if symbol file does not provide any symbols.
6103
a0c1ffed
TT
61042019-06-14 Tom Tromey <tromey@adacore.com>
6105
6106 * source.c (find_and_open_source): Respect basenames_may_differ.
6107
7c39e397
AB
61082019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6109
6110 * annotate.c (annotate_breakpoints_invalid): Make use of
6111 scoped_restore_terminal_state.
6112 (annotate_frames_invalid): Likewise.
6113
f411722c
TT
61142019-06-14 Tom Tromey <tromey@adacore.com>
6115
6116 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6117 allow assignment to an internalvar.
6118
4268ec18
TT
61192019-06-14 Tom Tromey <tromey@adacore.com>
6120
6121 * ada-lex.l: Allow "_" in attribute names.
6122
abdb711e
TT
61232019-06-14 Tom Tromey <tromey@adacore.com>
6124
6125 PR gdb/24653:
6126 * regcache.c (registers_changed): Don't call alloca.
6127 * top.c (execute_command): Don't call alloca.
6128
4c048731
PA
61292019-06-13 Pedro Alves <palves@redhat.com>
6130
6131 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6132 'expression'. When parsing an expression, error out if there's
6133 junk after "unlimited".
6134 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6135 (do_set_command): Adjust calls to is_unlimited_literal.
6136
66eb1ed3
PA
61372019-06-13 Pedro Alves <palves@redhat.com>
6138
6139 * compile/compile.c (make_compile_options_def_group): Add braces
6140 around array_view initializer.
6141 * thread.c (make_thread_apply_all_options_def_group)
6142 (make_thread_apply_all_options_def_group): Likewise.
6143
3345721a
PA
61442019-06-13 Pedro Alves <palves@redhat.com>
6145
6146 * NEWS (New commands): Mention "maint test-options
6147 require-delimiter", "maint test-options unknown-is-error", "maint
6148 test-options unknown-is-operand" and "maint show
6149 test-options-completion-result".
6150 (New command options, command completion): New section.
6151 (Completion improvements): New section.
6152 Mention that you can abbreviate "unlimited".
6153
6206060d
PA
61542019-06-13 Pedro Alves <palves@redhat.com>
6155
6156 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6157 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6158 * unittests/cli-utils-selftests.c (test_parse_flags)
6159 (test_parse_flags_qcs): Delete.
6160 (test_cli_utils): Don't call deleted functions.
6161
6665660a
PA
61622019-06-13 Pedro Alves <palves@redhat.com>
6163
6164 * thread.c: Include "cli/cli-option.h".
6165 (tp_array_compar_ascending): Global.
6166 (tp_array_compar): Delete function.
6167 (tp_array_compar_ascending, tp_array_compar_descending): New
6168 functions.
6169 (ascending_option_def, qcs_flag_option_def)
6170 (thr_qcs_flags_option_defs)
6171 (make_thread_apply_all_options_def_group)
6172 (make_thread_apply_options_def_group): New.
6173 (thread_apply_all_command): Use gdb::option::process_options.
6174 (thread_apply_command_completer)
6175 (thread_apply_all_command_completer): New.
6176 (thread_apply_command): Use gdb::option::process_options.
6177 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6178 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6179 to generate help text of "thread apply". Adjust "taas"'s help.
6180 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6181 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6182
f7e13587
PA
61832019-06-13 Pedro Alves <palves@redhat.com>
6184
6185 * thread.c (thread_apply_command): Check for invalid TID with
6186 isdigit instead of !isalpha.
6187
5d707134
PA
61882019-06-13 Pedro Alves <palves@redhat.com>
6189
6190 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6191 (validate_flags_qcs): New.
6192 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6193 (validate_flags_qcs): Declare.
6194 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6195 (make_frame_apply_options_def_group): New.
6196 (frame_apply_command_count): Process options with
6197 gdb::option::process_options.
6198 (frame_apply_completer): New.
6199 (frame_apply_level_completer, frame_apply_all_completer)
6200 (frame_apply_completer): New.
6201 (_initialize_stack): Update help of "frame apply", "frame apply
6202 level", "frame apply all" and "faas" to mention supported options
6203 and install command completers.
6204 * stack.h (frame_apply_all_completer): Declare.
6205 * thread.c: Include "stack.h".
6206 (tfaas_command): Add "--".
6207 (_initialize_thread): Update help "tfaas" to mention supported
6208 options and install command completer.
6209
272d4594
PA
62102019-06-13 Pedro Alves <palves@redhat.com>
6211
6212 * completer.c (complete_nested_command_line): New.
6213 (gdb_completion_word_break_characters_throw): Add assertion.
6214 * completer.h (complete_nested_command_line): Declare.
6215
90a1ef87
PA
62162019-06-13 Pedro Alves <palves@redhat.com>
6217
6218 * stack.c (parse_backtrace_qualifiers): New.
6219 (backtrace_command): Use it.
6220 (backtrace_command_completer): Complete on qualifiers.
6221
d4c16835
PA
62222019-06-13 Pedro Alves <palves@redhat.com>
6223
6224 * frame.c: Include "cli/cli-option.h.
6225 (user_set_backtrace_options): New.
6226 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6227 Delete.
6228 (get_prev_frame): Adjust.
6229 (boolean_option_def, uinteger_option_def)
6230 (set_backtrace_option_defs): New.
6231 (_initialize_frame): Adjust and use
6232 gdb::option::add_setshow_cmds_for_options to install "set
6233 backtrace past-main" and "set backtrace past-entry".
6234 * frame.h: Include "cli/cli-option.h".
6235 (struct frame_print_options): Forward declare.
6236 (print_frame_arguments_all, print_frame_arguments_scalars)
6237 (print_frame_arguments_none): Declare.
6238 (print_entry_values): Delete declaration.
6239 (struct frame_print_options, user_frame_print_options): New.
6240 (struct set_backtrace_options): New.
6241 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6242 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6243 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6244 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6245 (list_args_or_locals): Add frame_print_options parameter.
6246 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6247 * python/py-framefilter.c (enumerate_args): Pass down
6248 USER_FRAME_PRINT_OPTIONS.
6249 * stack.c: Include "cli/cli-option.h".
6250 (print_frame_arguments_all, print_frame_arguments_scalars)
6251 (print_frame_arguments_none): Declare.
6252 (print_raw_frame_arguments, print_entry_values): Delete.
6253 (user_frame_print_options): New.
6254 (boolean_option_def, enum_option_def, frame_print_option_defs):
6255 New.
6256 (struct backtrace_cmd_options): New.
6257 (bt_flag_option_def): New.
6258 (backtrace_command_option_defs): New.
6259 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6260 (print_frame_arg, read_frame_arg, print_frame_args)
6261 (print_frame_info, print_frame): Add frame_print_options parameter
6262 and use it.
6263 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6264 (backtrace_command_1): Add frame_print_options and
6265 backtrace_cmd_options parameters and use them.
6266 (make_backtrace_options_def_group): New.
6267 (backtrace_command): Process command options with
6268 gdb::option::process_options.
6269 (backtrace_command_completer): New.
6270 (_initialize_stack): Extend "backtrace"'s help to mention
6271 supported options. Install completer for "backtrace".
6272 Install some settings commands with add_setshow_cmds_for_options.
6273
2daf894e
PA
62742019-06-13 Pedro Alves <palves@redhat.com>
6275
6276 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6277 and that "set/show print raw frame-arguments" are now deprecated.
6278
6279 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6280 command.
6281 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6282 * stack.c (_initialize_stack): Install "set/show print
6283 raw-frame-arguments", and deprecate "set/show print raw
6284 frame-arguments".
6285 * valprint.c (_initialize_valprint): Deprecate "set/show print
6286 raw".
6287
e6ed716c
PA
62882019-06-13 Pedro Alves <palves@redhat.com>
6289
6290 * compile/compile.c (struct compile_options): New.
6291 (compile_flag_option_def, compile_command_option_defs)
6292 (make_compile_options_def_group): New.
6293 (compile_file_command): Handle options with
6294 gdb::option::process_options.
6295 (compile_file_command_completer): New function.
6296 (compile_code_command): Handle options with
6297 gdb::option::process_options.
6298 (compile_code_command_completer): New function.
6299 (_initialize_compiler): Install completers for "compile code" and
6300 "compile file". Mention available options in "compile code" and
6301 "compile code"'s help.
6302 * completer.c (advance_to_completion_word): New, factored out from
6303 ...
6304 (advance_to_expression_complete_word_point): ... this.
6305 (advance_to_filename_complete_word_point): New.
6306 * completer.h (advance_to_filename_complete_word_point): New
6307 declaration.
6308
7d8062de
PA
63092019-06-13 Pedro Alves <palves@redhat.com>
6310
6311 * compile/compile.c: Include "cli/cli-option.h".
6312 (compile_print_value): Scope data pointer is now a
6313 value_print_options pointer; adjust.
6314 (compile_print_command): Process options. Scope data pointer is
6315 now a value_print_options pointer; adjust.
6316 (_initialize_compile): Update "compile print"'s help to include
6317 supported options. Install a completer for "compile print".
6318 * cp-valprint.c (show_vtblprint, show_objectprint)
6319 (show_static_field_print): Delete.
6320 (_initialize_cp_valprint): Don't install "set print
6321 static-members", "set print vtbl", "set print object" here.
6322 * printcmd.c: Include "cli/cli-option.h" and
6323 "common/gdb_optional.h".
6324 (print_command_parse_format): Rework to fill in a
6325 value_print_options instead of a format_data.
6326 (print_value): Change parameter type from format_data pointer to
6327 value_print_options reference. Adjust.
6328 (print_command_1): Process options. Adjust to pass down a
6329 value_print_options.
6330 (print_command_completer): New.
6331 (_initialize_printcmd): Install print_command_completer as
6332 handle_brkchars completer for the "print" command. Update
6333 "print"'s help to include supported options.
6334 * valprint.c: Include "cli/cli-option.h".
6335 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6336 here from cp-valprint.c.
6337 (boolean_option_def, uinteger_option_def)
6338 (value_print_option_defs, make_value_print_options_def_group):
6339 New. Use gdb::option::add_setshow_cmds_for_options to install
6340 "set print elements", "set print null-stop", "set print repeats",
6341 "set print pretty", "set print union", "set print array", "set
6342 print address", "set print symbol", "set print array-indexes".
6343 * valprint.h: Include <string> and "cli/cli-option.h".
6344 (make_value_print_options_def_group): Declare.
6345 (print_value): Change parameter type from format_data pointer to
6346 value_print_options reference.
6347 (print_command_completer): Declare.
6348
9d0faba9
PA
63492019-06-13 Pedro Alves <palves@redhat.com>
6350
6351 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6352 (COMMON_SFILES): Add maint-test-settings.c.
6353 * cli/cli-decode.c (boolean_enums): New global, factored out from
6354 ...
6355 (add_setshow_boolean_cmd): ... here.
6356 * cli/cli-decode.h (boolean_enums): Declare.
6357 * cli/cli-option.c: New file.
6358 * cli/cli-option.h: New file.
6359 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6360 factored out from ...
6361 (parse_cli_boolean_value(const char *)): ... this.
6362 (is_unlimited_literal): Change parameter type to pointer to
6363 pointer. Adjust and advance ARG pointer.
6364 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6365 (parse_cli_var_enum): New, factored out from ...
6366 (do_set_command): ... this. Adjust.
6367 * cli/cli-setshow.h (parse_cli_boolean_value)
6368 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6369 (parse_cli_var_enum): Declare.
6370 * cli/cli-utils.c: Include "cli/cli-option.h".
6371 (get_ulongest): New.
6372 * cli/cli-utils.h (get_ulongest): Declare.
6373 (check_for_argument): New overloads.
6374 * maint-test-options.c: New file.
6375
2c722807
PA
63762019-06-13 Pedro Alves <palves@redhat.com>
6377
6378 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6379 parse a range if "-" is at the end of the string.
6380
dee7b4c8
PA
63812019-06-13 Pedro Alves <palves@redhat.com>
6382
6383 * cli/cli-setshow.c (parse_auto_binary_operation)
6384 (parse_cli_boolean_value): Don't allow "o".
6385
dca0f6c0
PA
63862019-06-13 Pedro Alves <palves@redhat.com>
6387
6388 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6389 * NEWS: Mention maint test-settings KIND.
6390 * maint-test-settings.c: New file.
6391
597bf39d
PA
63922019-06-13 Pedro Alves <palves@redhat.com>
6393
6394 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6395 completer.
6396 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6397 "set" completers.
6398
48c410fb
PA
63992019-06-13 Pedro Alves <palves@redhat.com>
6400
6401 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6402 after item.
6403
93bcb043
PA
64042019-06-13 Pedro Alves <palves@redhat.com>
6405
6406 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6407
cbba3ecd
PA
64082019-06-13 Pedro Alves <palves@redhat.com>
6409
6410 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6411 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6412 call.
6413 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6414 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6415 calls.
6416 (check_for_argument): Skip spaces after argument.
6417
b9a3f842
PA
64182019-06-13 Pedro Alves <palves@redhat.com>
6419
6420 * thread.c (thread_apply_command): Adjust TID parsing.
6421 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6422 detected before end of string.
6423 (tid_is_in_list): Error out if LIST is invalid.
6424
3844e605
PA
64252019-06-13 Pedro Alves <palves@redhat.com>
6426
6427 * completer.c (complete_line_internal_1): Rewind completion word
6428 point.
6429 (completion_tracker::advance_custom_word_point_by): Change
6430 parameter type to int.
6431 * completer.h (completion_tracker::advance_custom_word_point_by):
6432 Likewise.
6433
00b56dbe
PA
64342019-06-13 Pedro Alves <palves@redhat.com>
6435
6436 * completer.c (advance_to_completion_word): Handle delimiters.
6437
d106773e
PA
64382019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6439
6440 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6441
08f10e02
TT
64422019-06-11 Tom Tromey <tom@tromey.com>
6443
6444 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6445 (xmalloc_failed): Move to alloc.c.
6446 * alloc.c: New file.
6447 * Makefile.in (COMMON_SFILES): Add alloc.c.
6448
1c7fe951
TT
64492019-06-11 Tom Tromey <tom@tromey.com>
6450
6451 * nat/linux-waitpid.c: Don't include server.h.
6452 (linux_debug): Remove.
6453 (my_waitpid): Update.
6454
89549d7f
TT
64552019-06-11 Tom Tromey <tromey@adacore.com>
6456
6457 * infcall.c (_initialize_infcall): Remove trailing newline from
6458 help.
6459 * user-regs.c (_initialize_user_regs): Remove trailing newline
6460 from help.
6461 * typeprint.c (_initialize_typeprint): Remove trailing newline
6462 from help.
6463 * reverse.c (_initialize_reverse): Remove trailing newlines from
6464 help.
6465 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6466 from help.
6467 * language.c (add_set_language_command): Remove trailing newline
6468 from help.
6469 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6470 help.
6471 * disasm.c (_initialize_disasm): Remove trailing newline from
6472 help.
6473 * top.c (init_main): Remove trailing newline from help.
6474 * interps.c (_initialize_interpreter): Remove trailing newline
6475 from help.
6476 * btrace.c (_initialize_btrace): Remove trailing newlines from
6477 help.
6478 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6479 from help.
6480 * python/python.c (_initialize_python): Remove trailing newline
6481 from help.
6482 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6483 help.
6484 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6485 from help. Reformat some text.
6486 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6487 from help.
6488 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6489 newline from help.
6490
86108c13
TT
64912019-06-11 Tom Tromey <tromey@adacore.com>
6492
6493 * darwin-nat.c (darwin_decode_exception_message)
6494 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6495
a7067863
AB
64962019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6497
6498 * valops.c (value_slice): Check for not allocated or not
6499 associated values.
6500
9ab08412
TV
65012019-06-10 Tom de Vries <tdevries@suse.de>
6502
6503 PR gdb/24618
6504 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6505 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6506 invalid.
6507
f19e22e9
TV
65082019-06-10 Tom de Vries <tdevries@suse.de>
6509
6510 PR gdb/24611
6511 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6512 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6513
e99f9db0
TV
65142019-06-10 Tom de Vries <tdevries@suse.de>
6515
6516 PR symtab/24545
6517 * symtab.c (struct demangled_name_entry): Add language field.
6518 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6519 static minimal symbol". Set and use language field.
6520
9bf7038b
TT
65212019-06-10 Tom Tromey <tromey@adacore.com>
6522
6523 * ada-lang.c (_initialize_ada_language): Update help text.
6524
422186a9
TT
65252019-06-10 Tom Tromey <tromey@adacore.com>
6526
6527 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6528 with a newline.
6529 * guile/guile.c (handle_boot_error): Don't end warning with a
6530 newline.
6531 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6532 warning with a newline.
6533 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6534 newline.
6535 (s12z_frame_cache): Likewise.
6536 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6537 a newline.
6538 * solib-svr4.c (disable_probes_interface): Don't end warning with
6539 a newline.
6540 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6541 newline.
6542 * python/python.c (do_finish_initialization): Don't end warning
6543 with a newline.
6544
25ce02ee
TT
65452019-06-10 Tom Tromey <tom@tromey.com>
6546
6547 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6548 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6549 gdbpy_enter.
6550
caa429d8
TT
65512019-06-10 Tom Tromey <tromey@adacore.com>
6552
6553 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6554 data.
6555 (elf_new_init): Don't call stabsread_new_init.
6556 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6557 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6558 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6559
81873cc8
TV
65602019-06-10 Tom de Vries <tdevries@suse.de>
6561
6562 PR symtab/16264
6563 PR symtab/24517
6564 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6565
4fa0265e
РИ
65662019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6567
6568 * source.c (find_and_open_source): Also rewrite relative file
6569 names.
6570
1a3da2cd
AB
65712019-04-26 Amos Bird <amosbird@gmail.com>
6572
6573 * annotate.c (annotate_thread_exited): Add "thread-exited"
6574 annotation.
6575
3847a7bf
TT
65762019-06-06 Tom Tromey <tromey@adacore.com>
6577
6578 * maint.h (class scoped_command_stats): Use
6579 DISABLE_COPY_AND_ASSIGN.
6580 <print_time>: New method.
6581 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6582 print_time.
6583 (scoped_command_stats::print_time): New method.
6584
312617a3
AB
65852019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6586
6587 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6588 instructions of lengths 6 or 8 bytes.
6589
b02f78f9
PA
65902019-06-04 Pedro Alves <palves@redhat.com>
6591
6592 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6593
6594 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6595 * breakpoint.c (condition_completer): Likewise.
6596 * cli/cli-dump.c (scan_expression): Likewise.
6597 * common/filestuff.c (mkdir_recursive): Likewise.
6598 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6599 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6600 (gdb_abspath): Likewise.
6601 * compile/compile-cplus-types.c
6602 (compile_cplus_instance::decl_name): Likewise.
6603 * completer.c (complete_explicit_location):
6604 (signal_completer, reg_or_group_completer_1): Likewise.
6605 * cp-support.c (cp_remove_params_if_any): Likewise.
6606 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6607 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6608 * infcmd.c (strip_bg_char): Likewise.
6609 * linespec.c (copy_token_string): Likewise.
6610 * mi/mi-main.c (output_cores): Likewise.
6611 * psymtab.c (psymtab_search_name):
6612 * symfile.c (test_set_ext_lang_command): Likewise.
6613 * target.c (target_fileio_read_stralloc): Likewise.
6614 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6615 * value.c (complete_internalvar): Likewise.
6616
e1f2e1a2
CB
66172019-06-04 Christian Biesinger <cbiesinger@google.com>
6618
6619 Add objfile property to gdb.Type.
d3238f7d
PA
6620 * NEWS: Mention Python API addition.
6621 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6622
e664d728
PW
66232019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6624
6625 * NEWS: Mention the new set|show style [title|highlight].
6626 Mention changes to "show style", "help" and "apropos".
6627
66d8c862
PW
66282019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6629
6630 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6631 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6632 instead of print_help_for_command.
6633 (print_doc_of_command): New function.
6634 (help_list): Add 'apropos -v word' suggestion.
6635 (print_help_for_command): Style the command name using title style.
6636 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6637 (_initialize_cli_cmds): Describe -v in apropos_command help.
6638
9303eb2f
PW
66392019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6640
6641 * cli/cli-style.h (cli_style_option): Add name in constructor,
6642 add m_name class member, add constructor with intensity,
6643 add name class function.
6644 (cli_style_option::add_setshow_commands): Remove name argument.
6645 (highlight_style, title_style): New styles.
6646 * cli/cli-style.c (do_show): New function that shows a style
6647 characteristic styling the style name with itself.
6648 (set_style_name): New function.
6649 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6650 Update all callers according to the changes in cli/cli-style.h.
6651 * utils.h (fputs_highlighted): New function.
6652 * utils.c (fputs_highlighted): Likewise.
6653
e2c52041
PW
66542019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6655
6656 * NEWS: Mention new pipe command and new convenience variables.
6657
947d3946
PW
66582019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6659
6660 * cli/cli-cmds.c (pipe_command): New function.
6661 (_initialize_cli_cmds): Call add_com for pipe_command.
6662 Define | as an alias for pipe.
6663 (exit_status_set_internal_vars): New function.
6664 (shell_escape): Call exit_status_set_internal_vars.
6665 cli/cli-decode.c (find_command_name_length): Recognize | as
6666 a single character command.
6667
b8fd0918
PW
66682019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6669
6670 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6671 top.c (execute_command_to_ui_file): New function, mostly a copy
6672 of execute_command_to_string.
6673 (execute_command_to_string): Implement by calling
6674 execute_command_to_ui_file.
6675
68bb5386
PW
66762019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6677
6678 * top.h (saved_command_line): Remove declaration.
6679 * top.c (previous_saved_command_line, previous_repeat_arguments):
6680 New variables.
6681 (saved_command_line): Make static, define together with other
6682 'repeat variables'.
6683 (dont_repeat): Clear repeat_arguments.
6684 (repeat_previous, get_saved_command_line, save_command_line):
6685 New functions.
6686 (gdb_init): Initialize saved_command_line
6687 and previous_saved_command_line.
6688 * main.c (captured_main_1): Remove saved_command_line initialization.
6689 * event-top.c (handle_line_of_input): Update to use
6690 the new 'repeat' related functions instead of direct access to
6691 saved_command_line.
6692 * command.h (repeat_previous, get_saved_command_line,
6693 save_command_line): New declarations.
6694 (dont_repeat): Add comment.
6695
bfcdb852
TT
66962019-05-30 Tom Tromey <tromey@adacore.com>
6697
6698 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6699 Fix comment.
6700 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6701
0ef209f2
JV
67022019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6703
6704 PR cli/24587
6705 * completer.c (complete): Initialize variable word.
6706
955b06fa
SDJ
67072019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6708
6709 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6710 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6711 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6712 'body' is NULL to the outter 'if', protecting the '!is_define'
6713 situation as well.
6714
fa9c3fa0
TT
67152019-05-29 Tom Tromey <tromey@adacore.com>
6716
6717 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6718 (dwarf_unknown): New function.
6719 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6720 (dwarf_type_encoding_name): Use dwarf_unknown.
6721
4330d61d
TT
67222019-05-29 Tom Tromey <tromey@adacore.com>
6723
6724 PR c++/20020:
6725 * cp-valprint.c (cp_print_value_fields): Call
6726 cp_print_static_field inside "try".
6727
33a6bc35
TT
67282019-05-29 Tom Tromey <tromey@adacore.com>
6729
6730 * inflow.c (struct terminal_info): Add default operator=.
6731 * configure: Rebuild.
6732 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6733 -Wdeprecated-copy-dtor, -Wredundant-move.
6734
000439d5
TT
67352019-05-29 Tom Tromey <tromey@adacore.com>
6736
6737 * NEWS: Add entry.
6738 * infcmd.c (print_return_value_1): Handle finish_print
6739 option.
6740 (show_print_finish): New function.
6741 (_initialize_infcmd): Add "set/show print finish" commands.
6742 * valprint.c (user_print_options): Initialize new member.
6743 * valprint.h (struct value_print_options) <finish_print>: New
6744 member.
6745
c0e70c62
TT
67462019-05-28 Tom Tromey <tromey@adacore.com>
6747
6748 * ada-lang.c (ada_remove_Xbn_suffix)
6749 (find_old_style_renaming_symbol)
6750 (parse_old_style_renaming): Remove.
6751 (ada_find_renaming_symbol): Don't call
6752 find_old_style_renaming_symbol.
6753 (ada_is_renaming_symbol): Rename from
6754 ada_find_renaming_symbol. Remove "block" parameter. Return
6755 bool. Now static.
6756 (ada_read_var_value): Update and simplify.
6757 * ada-exp.y (write_var_or_type): Remove old code.
6758
766f8836
AH
67592019-05-28 Alan Hayward <alan.hayward@arm.com>
6760
6761 * event-top.c: Remove include comment.
6762 * inflow.c (class scoped_ignore_sigttou): Move from here...
6763 * inflow.h (class scoped_ignore_sigttou): ...to here.
6764 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6765 * top.c: Remove include comment.
6766
eb41253a
TT
67672019-05-27 Tom Tromey <tom@tromey.com>
6768
6769 * NEWS: Fix typo.
6770
4ca51187
TT
67712019-05-22 Tom Tromey <tromey@adacore.com>
6772
6773 * target.c (target_follow_exec): Constify parameter.
6774 * target-delegates.c: Rebuild.
6775 * remote.c (remote_target::follow_exec): Constify parameter.
6776 * infrun.c (follow_exec): Constify parameter.
6777 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6778 (target_follow_exec): Likewise.
6779
8fca4da0
AH
67802019-05-22 Alan Hayward <alan.hayward@arm.com>
6781
6782 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6783 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6784
b7060614
AH
67852019-05-22 Alan Hayward <alan.hayward@arm.com>
6786
6787 * NEWS: Add debugredirect and testsuite sections.
6788
0a5954bd
SC
67892019-05-22 Simon Cook <simon.cook@embecosm.com>
6790
6791 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6792 target descriptions using exclusively floating point register name
6793 aliases.
6794
dc42e902
AB
67952019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6796
6797 PR gdb/18644:
6798 * f-lang.c (build_fortran_types): Handle the case where
6799 gdbarch_floatformat_for_type returns a nullptr.
6800
fb7806c7
TV
68012019-05-21 Tom de Vries <tdevries@suse.de>
6802
6803 PR cli/24587
6804 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6805
34d11c68
AB
68062019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6807
6808 PR gdb/18644:
6809 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6810 16-byte floats.
6811 * i386-tdep.c (i386_floatformat_for_type): Use
6812 floatformats_ia64_quad for the 16-byte floating point component
6813 within a fortran 32-byte complex number.
6814
122cf0f2
AB
68152019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6816
6817 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6818 delete default constructor.
6819 (find_partial_die): Update to return const struct.
6820 (partial_die_parent_scope): Move variable declaration into scope
6821 of its use and change its type to auto.
6822 (guess_partial_die_structure_name): Likewise.
6823 (partial_die_info::fixup): Likewise.
6824
33d0e35a
TT
68252019-05-17 Tom Tromey <tromey@adacore.com>
6826
6827 * source.c (find_and_open_source): Remove cast.
6828
a45575b0
TT
68292019-05-17 Tom Tromey <tromey@adacore.com>
6830
6831 * annotate.c (annotate_source): Make "filename" const.
6832 * annotate.h (annotate_source): Use const.
6833
81f47ac2
AH
68342019-05-17 Alan Hayward <alan.hayward@arm.com>
6835
6836 * disasm.c (set_disassembler_options): Send errors to stderr.
6837
ca1285d1
AH
68382019-05-17 Alan Hayward <alan.hayward@arm.com>
6839
6840 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6841 (cli_interp_base::set_logging): Check debug_redirect.
6842 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6843 * cli/cli-logging.c (debug_redirect): Add static variable.
6844 (pop_output_files): Add default param.
6845 (handle_redirections): Print debug setting.
6846 (show_logging_command): Likewise.
6847 (_initialize_cli_logging): Add debugredirect command.
6848 * interps.c (current_interp_set_logging): Add debug_redirect
6849 parameter.
6850 * interps.h (set_logging): Add debug_redirect parameter.
6851 (current_interp_set_logging): Likewise.
6852 * mi/mi-common.h: Likewise.
6853 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6854
68552019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6856 Tom Tromey <tromey@adacore.com>
6857
6858 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6859 directly.
6860 * cli/cli-interp.h (make_logging_output): Remove declaration.
6861 * cli/cli-logging.c (make_logging_output): Remove function.
6862 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6863 directly.
6864 * ui-file.c (tee_file::tee_file): Remove bools.
6865 (tee_file::~tee_file): Remove deletes.
6866 * ui-file.h (tee_file): Remove bools.
6867
26648588
JV
68682019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6869
6870 * mi/mi-cmds.h (mi_cmd_complete): New function.
6871 * mi/mi-main.c (mi_cmd_complete): Likewise.
6872 * mi/mi-cmds.c: Define new MI command -complete.
6873 * NEWS: Mention new -complete command.
6874
6e035501
JV
68752019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6876
6877 * completer.h (complete): New function.
6878 * completer.c (complete): Likewise.
6879 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6880 function defined in completer.h.
6881
7d0e2ece
JV
68822019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6883
e79be6e5 6884 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6885
fb816e8b
TV
68862019-05-17 Tom de Vries <tdevries@suse.de>
6887
6888 PR gdb/24094
6889 * dwarf2read.c (struct cu_partial_die_info): New struct.
6890 (find_partial_die): Return cu_partial_die_info.
6891 (partial_die_parent_scope, guess_partial_die_structure_name)
6892 (partial_die_info::fixup): Handle new return type of find_partial_die.
6893
677052f2
SDJ
68942019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6895
a1726c38 6896 PR breakpoints/24541
677052f2
SDJ
6897 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6898 "std::string", simplifying the algorithm.
6899
f3da9116
SDJ
69002019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6901
6902 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6903 (stap_static_probe_ops::get_probes): Likewise.
6904
f1bb75ab
SDJ
69052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6906
6907 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6908 '-')" and "else if".
6909 (stap_parse_single_operand): Join checks for
6910 "gdbarch_stap_parse_special_token_p" and
6911 "gdbarch_stap_parse_special_token" in the same "if" statement.
6912 Invert check when verifying for operation on register
6913 displacement.
6914
3ca58cde
SDJ
69152019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6916
6917 * stap-probe.c (stap_get_opcode): Update comment.
6918 (stap_get_expected_argument_type): Likewise.
6919 (handle_stap_probe): Likewise.
6920
af2d9bee
SDJ
69212019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6922
6923 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6924 return type to 'bool'. Adjust comment. Use 'bool' when
6925 appropriate.
6926 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6927 * stap-probe.c (stap_parse_argument_1): Likewise.
6928 (stap_is_operator): Likewise.
6929 (stap_is_generic_prefix): Likewise.
6930 (stap_is_register_prefix): Likewise.
6931 (stap_is_register_indirection_prefix): Likewise.
6932 (stap_is_integer_prefix): Likewise.
6933 (stap_generic_check_suffix): Likewise.
6934 (stap_check_integer_suffix): Likewise.
6935 (stap_check_register_suffix): Likewise.
6936 (stap_check_register_indirection_suffix): Likewise.
6937 (stap_parse_register_operand): Likewise.
6938 (stap_parse_single_operand): Likewise.
6939 (stap_parse_argument_1): Likewise.
6940 (stap_probe::get_argument_count): Likewise.
6941 (stap_is_operator): Likewise.
6942
61c9c421
TT
69432019-05-16 Tom Tromey <tromey@adacore.com>
6944
6945 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6946 keyword to foreach.
6947
9ddc1af1
SM
69482019-05-15 Simon Marchi <simon.marchi@efficios.com>
6949
6950 * linux-thread-db.c (try_thread_db_load_1): Change return type
6951 to bool.
6952 (try_thread_db_load): Likewise.
6953 (try_thread_db_load_from_pdir_1): Likewise.
6954 (try_thread_db_load_from_pdir): Likewise.
6955 (try_thread_db_load_from_sdir): Likewise.
6956 (try_thread_db_load_from_dir): Likewise.
6957 (thread_db_load_search): Likewise.
6958 (has_libpthread): Likewise.
6959 (thread_db_load): Likewise.
6960
7bede828
SDJ
69612019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6962
6963 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6964 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6965 NULL, and complain/return if that's the case.
6966
c5358db4
JD
69672019-05-15 John Darrington <john@darrington.wattle.id.au>
6968
6969 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6970 (advance, posn, abstract_read_memory): New functions.
6971 [struct mem_read_abstraction]: New struct.
6972 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6973
c408a94f
TT
69742019-05-14 Tom Tromey <tromey@adacore.com>
6975
6976 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6977 value is not lval_memory.
6978
e7bd7fba
TT
69792019-05-14 Tom Tromey <tromey@adacore.com>
6980
6981 * solib.c (info_sharedlibrary_command): Style the file name.
6982
a6d0f249
AH
69832019-05-14 Alan Hayward <alan.hayward@arm.com>
6984
6985 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6986 (aarch64_vnv_type): Likewise.
6987 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6988 * common/tdesc.c: Likewise.
6989 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6990 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6991 * features/aarch64-fpu.xml: Add ieee half view.
6992 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6993 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6994 * gdbtypes.h (struct builtin_type): Likewise.
6995 (struct objfile_type): Likewise.
6996
66b8bb74
SM
69972019-05-12 Paul Naert <paul.naert@polymtl.ca>
6998
6999 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7000 typo.
7001 * location.h (string_to_event_location): Likewise.
7002
21c219fd
JB
70032019-05-11 Joel Brobecker <brobecker@adacore.com>
7004
7005 GDB 8.3 released.
7006
13674803
SM
70072019-05-10 Simon Marchi <simon.marchi@efficios.com>
7008
7009 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7010 New variable declaration.
7011 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7012 New variable.
7013 (print_one_breakpoint): Use ui_out::test_flags and new global
7014 variable to compute use_fixed_output.
7015 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7016 Remove.
7017 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7018 (mi_multi_location_breakpoint_output_fixed): Remove.
7019 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7020 new variable.
7021 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7022 fix_multi_location_breakpoint_output flag if version >= 3.
7023 * ui-out.h (enum ui_out_flag)
7024 <fix_multi_location_breakpoint_output>: New enumerator.
7025
a9eac7f9
SM
70262019-05-10 Simon Marchi <simon.marchi@efficios.com>
7027
7028 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7029
71bed2db
TT
70302019-05-10 Tom Tromey <tromey@adacore.com>
7031
7032 * ada-lang.c (catch_ada_completer): New function.
7033 (_initialize_ada_language): Use it.
7034
24c54127
TT
70352019-05-10 Tom Tromey <tromey@adacore.com>
7036
7037 * thread.c (print_thread_info): Make "requested_threads" const.
7038 * gdbthread.h (print_thread_info): Make "requested_threads"
7039 const.
7040 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7041 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7042
7a102139
TT
70432019-05-08 Tom Tromey <tom@tromey.com>
7044
7045 * gdbtypes.c (objfile_type_data): Change type.
7046 (objfile_type, _initialize_gdbtypes): Update.
7047
924d79e2
TT
70482019-05-08 Tom Tromey <tom@tromey.com>
7049
7050 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7051 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7052 (_initialize_dwarf2_frame): Update.
7053
4c58e337
TT
70542019-05-08 Tom Tromey <tom@tromey.com>
7055
7056 * objc-lang.c (objc_objfile_data): Change type.
7057 (find_methods): Update.
7058 (_initialize_objc_lang): Remove.
7059
d772d2ab
TT
70602019-05-08 Tom Tromey <tom@tromey.com>
7061
7062 * stabsread.c (rs6000_builtin_type_data): Change type.
7063 (rs6000_builtin_type, _initialize_stabsread): Update.
7064
d11d83f4
TT
70652019-05-08 Tom Tromey <tom@tromey.com>
7066
7067 * mips-tdep.c (mips_pdr_data): Remove.
7068 (_initialize_mips_tdep): Update.
7069
9a73f0ad
TT
70702019-05-08 Tom Tromey <tom@tromey.com>
7071
7072 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7073 (hppa_init_objfile_priv_data, read_unwind_info)
7074 (find_unwind_entry, _initialize_hppa_tdep): Update.
7075
8127a2fa
TT
70762019-05-08 Tom Tromey <tom@tromey.com>
7077
7078 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7079 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7080 on obstack.
7081 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7082
91d3055d
TT
70832019-05-08 Tom Tromey <tom@tromey.com>
7084
7085 * mdebugread.c (basic_type_data): Change type.
7086 (basic_type, _initialize_mdebugread): Update.
7087
31930bd3
TT
70882019-05-08 Tom Tromey <tom@tromey.com>
7089
7090 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7091
bdb3ed9e
TT
70922019-05-08 Tom Tromey <tom@tromey.com>
7093
7094 * nto-tdep.c (nto_inferior_data_reg): Change type.
7095 (nto_inferior_data): Update.
7096 (nto_inferior_data_cleanup, nto_new_inferior_data)
7097 (_initialize_nto_tdep): Remove.
7098 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7099
f37b313d
TT
71002019-05-08 Tom Tromey <tom@tromey.com>
7101
7102 * ada-lang.c (struct ada_inferior_data): Add initializers.
7103 (ada_inferior_data): Change type.
7104 (ada_inferior_data_cleanup): Remove.
7105 (get_ada_inferior_data, ada_inferior_exit)
7106 (struct ada_pspace_data): Add initializers, destructor.
7107 (ada_pspace_data_handle): Change type.
7108 (get_ada_pspace_data): Update.
7109 (ada_pspace_data_cleanup): Remove.
7110
24699405
TT
71112019-05-08 Tom Tromey <tom@tromey.com>
7112
7113 * coffread.c (struct coff_symfile_info): Add initializers.
7114 (coff_objfile_data_key): Move lower. Change type.
7115 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7116 Update.
7117 (coff_free_info): Remove.
7118
d4e05d2f
TT
71192019-05-08 Tom Tromey <tom@tromey.com>
7120
7121 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7122 (fbsd_pspace_data_handle): Move lower. Change type.
7123 (get_fbsd_pspace_data): Update.
7124 (fbsd_pspace_data_cleanup): Remove.
7125 (_initialize_fbsd_tdep): Update.
7126
14ef6690
TT
71272019-05-08 Tom Tromey <tom@tromey.com>
7128
7129 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7130 (get_ada_tasks_pspace_data): Update.
7131 (ada_tasks_pspace_data_cleanup): Remove.
7132 (_initialize_tasks): Update.
7133 (ada_tasks_inferior_data_handle): Change type.
7134 (get_ada_tasks_inferior_data): Update.
7135 (ada_tasks_inferior_data_cleanup): Remove.
7136 (struct ada_tasks_pspace_data): Add initializers.
7137
814cf43a
TT
71382019-05-08 Tom Tromey <tom@tromey.com>
7139
7140 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7141 * symfile-debug.c (debug_sym_get_probes): Change type.
7142 * stap-probe.c (handle_stap_probe):
7143 (stap_static_probe_ops::get_probes): Change type.
7144 * probe.h (class static_probe_ops) <get_probes>: Change type.
7145 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7146 (parse_probes_in_pspace): Update.
7147 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7148 Update.
7149 (any_static_probe_ops::get_probes): Change type.
7150 * elfread.c (elfread_data): New typedef.
7151 (probe_key): Change type.
7152 (elf_get_probes): Likewise. Update.
7153 (probe_key_free): Remove.
7154 (_initialize_elfread): Update.
7155 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7156 Change type.
7157 (dtrace_process_dof_probe, dtrace_process_dof)
7158 (dtrace_static_probe_ops::get_probe): Change type.
7159
02dc647e
TT
71602019-05-08 Tom Tromey <tom@tromey.com>
7161
7162 * xcoffread.c (struct xcoff_symfile_info): Rename from
7163 coff_symfile_info. Add initializers.
7164 (xcoff_objfile_data_key): Move lower. Change type.
7165 (XCOFF_DATA): Rewrite.
7166 (xcoff_free_info): Remove.
7167 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7168 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7169 (xcoff_initial_scan): Update.
7170
09232438
TT
71712019-05-08 Tom Tromey <tom@tromey.com>
7172
7173 * solib-svr4.c (struct svr4_info): Add initializers and
7174 destructor.
7175 <probes_table>: Now an htab_up.
7176 (solib_svr4_pspace_data): Change type.
7177 (free_probes_table): Simplify.
7178 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7179 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7180 (probes_table_remove_objfile_probes, register_solib_event_probe)
7181 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7182 (_initialize_svr4_solib): Update.
7183
7b4a314f
TT
71842019-05-08 Tom Tromey <tom@tromey.com>
7185
7186 * remote.c (remote_pspace_data): Change type.
7187 (remote_pspace_data_cleanup): Remove.
7188 (get_remote_exec_file, set_pspace_remote_exec_file)
7189 (_initialize_remote): Update.
7190
51d3063a
TT
71912019-05-08 Tom Tromey <tom@tromey.com>
7192
7193 * breakpoint.c (breakpoint_objfile_key): Change type.
7194 (get_breakpoint_objfile_data): Update.
7195 (free_breakpoint_objfile_data): Remove.
7196 (_initialize_breakpoint): Update.
7197
89fb8848
TT
71982019-05-08 Tom Tromey <tom@tromey.com>
7199
7200 * linux-tdep.c (struct linux_info): Add initializers.
7201 (linux_inferior_data): Move. Change type.
7202 (invalidate_linux_cache_inf): Update.
7203 (linux_inferior_data_cleanup): Remove.
7204 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7205
e9b89e2d
TT
72062019-05-08 Tom Tromey <tom@tromey.com>
7207
7208 * auxv.c (auxv_inferior_data): Move. Change type.
7209 (auxv_inferior_data_cleanup): Remove.
7210 (invalidate_auxv_cache_inf): Rewrite.
7211 (get_auxv_inferior_data, _initialize_auxv): Update.
7212
8c42777c
TT
72132019-05-08 Tom Tromey <tom@tromey.com>
7214
7215 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7216 (symfile_debug_objfile_data_key): Change type.
7217 (symfile_debug_installed, debug_qf_has_symbols)
7218 (debug_qf_find_last_source_symtab)
7219 (debug_qf_forget_cached_source_info)
7220 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7221 (debug_qf_print_stats, debug_qf_dump)
7222 (debug_qf_expand_symtabs_for_function)
7223 (debug_qf_expand_all_symtabs)
7224 (debug_qf_expand_symtabs_with_fullname)
7225 (debug_qf_map_matching_symbols)
7226 (debug_qf_expand_symtabs_matching)
7227 (debug_qf_find_pc_sect_compunit_symtab)
7228 (debug_qf_map_symbol_filenames)
7229 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7230 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7231 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7232 (debug_sym_read_linetable, debug_sym_relocate): Update.
7233 (symfile_debug_free_objfile): Remove.
7234 (install_symfile_debug_logging, _initialize_symfile_debug):
7235 Update.
7236
5bfd760d
TT
72372019-05-08 Tom Tromey <tom@tromey.com>
7238
7239 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7240 allocate_on_obstack.
7241 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7242 (get_dwarf2_per_objfile): Update.
7243 (set_dwarf2_per_objfile): Remove.
7244 (dwarf2_has_info, dwarf2_get_section_info): Update.
7245 (dwarf2_free_objfile): Remove.
7246 (_initialize_dwarf2_read): Update.
7247
e85e19b4
TT
72482019-05-08 Tom Tromey <tom@tromey.com>
7249
7250 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7251 initializers.
7252 <unsupported_script_warning_printed,
7253 script_not_found_warning_printed>: Now bool.
7254 (auto_load_pspace_data): Change type.
7255 (~auto_load_pspace_info): Rename from
7256 auto_load_pspace_data_cleanup.
7257 (get_auto_load_pspace_data, init_loaded_scripts_info)
7258 (clear_section_scripts, maybe_print_unsupported_script_warning)
7259 (maybe_print_script_not_found_warning, _initialize_auto_load):
7260 Update.
7261
f6aa7436
TT
72622019-05-08 Tom Tromey <tom@tromey.com>
7263
7264 * objfiles.c (objfile_pspace_info): Add destructor and
7265 initializers.
7266 (objfiles_pspace_data): Change type.
7267 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7268 (get_objfile_pspace_data): Update.
7269 (objfiles_bfd_data): Change type.
7270 (get_objfile_bfd_data): Update.
7271 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7272
6ae614f6
TT
72732019-05-08 Tom Tromey <tom@tromey.com>
7274
7275 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7276 Change type.
7277 (get_catch_syscall_inferior_data): Update.
7278 (catch_syscall_inferior_data_cleanup): Remove.
7279 (_initialize_break_catch_syscall): Update.
7280
6509b8eb
TT
72812019-05-08 Tom Tromey <tom@tromey.com>
7282
7283 * inflow.c (struct terminal_info): Add destructor and
7284 initializers.
7285 (inflow_inferior_data): Change type.
7286 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7287 (get_inflow_inferior_data, inflow_inferior_exit)
7288 (swap_terminal_info, _initialize_inflow): Update.
7289
35632941
TT
72902019-05-08 Tom Tromey <tom@tromey.com>
7291
7292 * target-dcache.c (target_dcache_cleanup): Remove.
7293 (target_dcache_aspace_key): Change type.
7294 (target_dcache_init_p, target_dcache_invalidate)
7295 (target_dcache_get, target_dcache_get_or_init)
7296 (_initialize_target_dcache): Update.
7297 * dcache.h (struct dcache_deleter): New.
7298
3017b94d
TT
72992019-05-08 Tom Tromey <tom@tromey.com>
7300
7301 * symtab.c (struct symbol_cache): Add destructor and
7302 initializers.
7303 (symbol_cache_key): Move. Change type.
7304 (make_symbol_cache, free_symbol_cache): Remove.
7305 (get_symbol_cache): Update.
7306 (symbol_cache_cleanup): Remove.
7307 (ALL_PSPACES, symbol_cache_flush)
7308 (maintenance_print_symbol_cache)
7309 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7310 Update.
7311
a32ad8c5
TT
73122019-05-08 Tom Tromey <tom@tromey.com>
7313
7314 * symtab.c (struct main_info): Add destructor and initializers.
7315 (main_progspace_key): Move. Change type.
7316 (get_main_info): Update.
7317 (main_info_cleanup): Remove.
7318 (_initialize_symtab): Update.
7319
5f6e90a0
TT
73202019-05-08 Tom Tromey <tom@tromey.com>
7321
7322 * registry.h (DECLARE_REGISTRY): Define the _key class.
7323
1bd0c6e4
AB
73242019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7325
7326 * NEWS: Merge two 'New commands' sections.
7327
2228ef77
XR
73282019-05-08 Joel Brobecker <brobecker@adacore.com>
7329
7330 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7331 parameter and use Ada language definition instead.
7332 (ada_val_print_ptr): Remove unused language parameter.
7333 (ada_val_print_num): Remove language parameter and use Ada language
7334 definition instead.
7335 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7336 parameter.
7337 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7338 parameter and use Ada language definition instead.
7339 (ada_val_print_1): Update all ada_val_print_xxx calls.
7340 Remove language parameter.
7341 (ada_val_print): Update ada_val_print_1 call.
7342
60fcc1c3
TT
73432019-05-08 Tom Tromey <tromey@adacore.com>
7344
7345 * remote.c (remote_hw_watchpoint_limit)
7346 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7347 Now static.
7348
ed2b7c17
TT
73492019-05-08 Tom Tromey <tromey@adacore.com>
7350
7351 * maint.c (_initialize_maint_cmds): Move initialization code to
7352 remote.c.
7353 (watchdog, show_watchdog): Move to remote.c.
7354 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7355 "watchdog" static.
7356 (_initialize_remote): Move initialization code from maint.c.
7357 * defs.h (watchdog): Don't declare.
7358
b0be6c91
TT
73592019-05-08 Tom Tromey <tromey@adacore.com>
7360
7361 * tui/tui-interp.c: Include main.h.
7362 * interps.c: Include main.h.
7363 * main.h (interpreter_p): Declare.
7364 * defs.h (interpreter_p): Don't declare.
7365
587ee17b
TT
73662019-05-08 Tom Tromey <tromey@adacore.com>
7367
7368 * dwarf2loc.c: Include dwarf2read.h.
7369 * defs.h (read_unsigned_leb128): Don't declare.
7370 * dwarf2read.h (read_unsigned_leb128): Declare.
7371
ca1df239
TT
73722019-05-08 Tom Tromey <tromey@adacore.com>
7373
7374 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7375 method.
7376
99f20f08
TT
73772019-05-08 Tom Tromey <tromey@adacore.com>
7378
7379 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7380 when no wrap column is set.
7381
80e55b13
TT
73822019-05-08 Tom Tromey <tromey@adacore.com>
7383
7384 * c-lang.c (c_get_string): Handle non-C-style arrays.
7385
9d3421af
TT
73862019-05-08 Tom Tromey <tromey@adacore.com>
7387
7388 * typeprint.c (print_offset_data::update): Print the bit offset,
7389 not the number of bits remaining.
7390
844333e2
TT
73912019-05-08 Tom Tromey <tromey@adacore.com>
7392
7393 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7394 padding at end of comment.
7395
988915ee
TT
73962019-05-08 Tom Tromey <tromey@adacore.com>
7397
7398 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7399 Compare main types.
7400
26bfd823
TT
74012019-05-06 Tom Tromey <tom@tromey.com>
7402
7403 * common/scoped_mmap.c: Include common-defs.h.
7404 * common/scoped_mmap.h: Don't include config.h.
7405
89055eaa
TT
74062019-05-04 Tom Tromey <tom@tromey.com>
7407
7408 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7409 (struct aarch64_call_info): Add initializers.
7410 <si>: Now a std::vector.
7411 (pass_on_stack, aarch64_push_dummy_call): Update.
7412
5da01df5
TT
74132019-05-04 Simon Marchi <simon.marchi@efficios.com>
7414 Tom Tromey <tom@tromey.com>
7415
7416 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7417 (ppc_threads): Now a std::vector. Now static.
7418 (hwdebug_find_thread_points_by_tid)
7419 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7420 Update.
7421
fbdf05a1
TT
74222019-05-04 Tom Tromey <tom@tromey.com>
7423
7424 * arc-tdep.c (arc_tdesc_init): Return bool.
7425
06d16ec9
TT
74262019-05-04 Tom Tromey <tom@tromey.com>
7427
7428 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7429 Use gdb_assert_not_reached.
7430
9c056022
TT
74312019-05-04 Tom Tromey <tom@tromey.com>
7432
7433 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7434 "false".
7435
fa9c2a59
TT
74362019-05-04 Tom Tromey <tom@tromey.com>
7437
7438 * arc-tdep.c (arc_tdesc_init): Use bool.
7439
e2eb806a
TT
74402019-05-04 Tom Tromey <tom@tromey.com>
7441
7442 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7443
6fe87677
TT
74442019-05-04 Tom Tromey <tom@tromey.com>
7445
7446 * cli/cli-cmds.c (valid_command_p): Return bool.
7447
7f008c9e
TT
74482019-05-04 Tom Tromey <tom@tromey.com>
7449
7450 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7451 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7452
b6484282
RT
74532019-05-04 Raul Tambre <raul@tambre.ee>
7454
7455 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7456 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7457 operator for comparison.
7458
af97b416
TT
74592019-05-04 Tom Tromey <tom@tromey.com>
7460
7461 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7462 (lookup_partial_symbol, print_partial_symbols)
7463 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7464 (psymbol_compare): Update.
7465 (add_psymbol_to_bcache): Clear the entire psymbol.
7466 (maintenance_check_psymtabs): Update.
7467 * psympriv.h (struct partial_symbol): Don't derive from
7468 general_symbol_info.
7469 <obj_section, unrelocated_address, address,
7470 set_unrelocated_address>: Update.
7471 <ginfo>: New member.
7472 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7473 (debug_names::write_psymbols): Update.
7474
9d6d4be8
TV
74752019-05-04 Tom de Vries <tdevries@suse.de>
7476
7477 * contrib/cc-with-tweaks.sh: Support -n arg.
7478
66452beb
PW
74792019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7480
7481 * corelow.c (core_target::detach): Ensure frame cache and
7482 register caches are cleared.
7483 inferior.c (exit_inferior_1): Likewise.
7484
bde09ab7
TT
74852019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7486 Tom Tromey <tom@tromey.com>
7487
7488 * dictionary.c (collate_pending_symbols_by_language): Remove
7489 "struct" from foreach.
7490 * symtab.c (lookup_global_symbol_from_objfile)
7491 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7492 foreach.
7493 * ser-tcp.c (net_open): Remove "struct" from foreach.
7494 * objfiles.c (objfile_relocate, objfile_rebase)
7495 (objfile_has_symbols): Remove "struct" from foreach.
7496 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7497 from foreach.
7498 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7499 foreach.
7500 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7501 "struct" from foreach.
7502 * ada-lang.c (create_excep_cond_exprs)
7503 (ada_exception_catchpoint_cond_string): Remove "struct" from
7504 foreach.
7505
222a8d25
TT
75062019-05-03 Tom Tromey <tromey@adacore.com>
7507
7508 * ada-exp.y (convert_char_literal): Check suffix of each
7509 enumerator.
7510
fcd60b84
DP
75112019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7512
7513 PR ada/21406:
7514 * ada-exp.y (yywrap): Don't define.
7515 * ada-lex.l (%option): Add noyywrap
7516 (yywrap): Remove.
7517
5f2459c2
EZ
75182019-05-03 Eli Zaretskii <eliz@gnu.org>
7519
353ea2d1
EZ
7520 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7521 _WIN32_WINNT to the XP level, unless already defined to a higher
7522 level.
7523
7524 * unittests/parse-connection-spec-selftests.c:
7525 * ser-tcp.c:
7526 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7527 override.
7528
5f2459c2
EZ
7529 * symfile.c (find_separate_debug_file): Remove colon from the
7530 drive spec of DOS/Windows file names of the target, so that the
7531 file name produced from DEBUGDIR and the target's directory will
7532 be valid on DOS/Windows systems.
7533
80062eb9
AB
75342019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7535
7536 * rust-lang.c (val_print_struct): Handle printing structures
7537 containing strings.
7538
b8c05e85
TT
75392019-05-02 Tom Tromey <tromey@adacore.com>
7540
7541 * valarith.c (_initialize_valarith): Remove.
7542
4504bbde
TT
75432019-05-01 Tom Tromey <tromey@adacore.com>
7544
7545 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7546 bitfields.
7547
d48e62f4
TT
75482019-05-01 Tom Tromey <tromey@adacore.com>
7549
7550 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7551 for big-endian copies.
7552
15f18d14
AT
75532019-04-30 Ali Tamur <tamur@google.com>
7554 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7555 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7556 (read_3_bytes): New function.
7557
ab4ee614
JB
75582019-04-30 Joel Brobecker <brobecker@adacore.com>
7559
7560 * windows-nat.c (main_thread_id): Delete.
7561 (handle_output_debug_string): Replace main_thread_id by
7562 current_event.dwThreadId.
7563 (fake_create_process): Likewise.
7564 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7565 Do not set main_thread_id.
7566 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7567 current_event.dwThreadId.
7568 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7569
8ed5b76e
JB
75702019-04-30 Joel Brobecker <brobecker@adacore.com>
7571
7572 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7573 Use current_event.dwThreadId instead of main_thread_id.
7574
2ff0a947
TT
75752019-04-30 Tom Tromey <tromey@adacore.com>
7576
7577 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7578 (create_excep_cond_exprs): Iterate over program spaces.
7579 (ada_exception_catchpoint_cond_string): Examine all minimal
7580 symbols for exception types.
7581
a776957c
TT
75822019-04-30 Tom Tromey <tromey@adacore.com>
7583
7584 PR c++/24470:
7585 * dwarf2read.c (process_structure_scope): Handle case where type
7586 has template parameters but no symbol was created.
7587
bc68014d
AB
75882019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7589 Chris January <chris.january@arm.com>
7590
7591 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7592 qualifier.
7593 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7594
f1fdc960
AB
75952019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7596
7597 * f-typeprint.c (f_print_type): Update rules for printing
7598 whitespace.
7599 (f_type_print_varspec_suffix): Likewise.
7600
bf7a4de1
AB
76012019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7602 Chris January <chris.january@arm.com>
7603
7604 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7605 function arguments.
7606
bbe75b9d
AB
76072019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7608
7609 * f-lang.c (build_fortran_types): Change name of void type to
7610 lower case.
7611 * f-typeprint.c (f_type_print_base): Print the name of the void
7612 type, rather than a fixed string.
7613 * f-valprint.c (f_decorations): Use lower case void string.
7614
1db455a7
AB
76152019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7616 Chris January <chris.january@arm.com>
7617
7618 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7619 types for Fortran.
7620
b6d03bb2
AB
76212019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7622 Chris January <chris.january@arm.com>
7623 David Lecomber <david.lecomber@arm.com>
7624
7625 * f-exp.y (BINOP_INTRINSIC): New token.
7626 (exp): New parser rule handling BINOP_INTRINSIC.
7627 (f77_keywords): Add new builtin procedures.
7628 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7629 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7630 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7631 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7632 (print_unop_subexp_f): New function.
7633 (print_binop_subexp_f): New function.
7634 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7635 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7636 (dump_subexp_body_f): Likewise.
7637 (operator_check_f): Likewise.
7638 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7639 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7640
83228e93
AB
76412019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7642
7643 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7644 UNOP_KIND.
7645 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7646 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7647 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7648 (operator_length_f): New fuction.
7649 (print_subexp_f): New function.
7650 (op_name_f): New function.
7651 (dump_subexp_body_f): New function.
7652 (operator_check_f): New function.
7653 (exp_descriptor_f): Replace standard expression handling functions
7654 with new functions.
7655 * gdb/fortran-operator.def: New file.
7656 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7657 * gdb/std-operator.def: Remove UNOP_KIND.
7658
6fdcd7cc
AB
76592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7660
7661 * std-operator.def: Remove unbalanced, stray double quote
7662 character.
7663
2e62ab40
AB
76642019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7665 Chris January <chris.january@arm.com>
7666 Daniel Everett <daniel.everett@arm.com>
7667 Nick Forrington <nick.forrington@arm.com>
7668 Richard Bunt <richard.bunt@arm.com>
7669
7670 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7671 of depth when printing anonymous structs or unions.
7672 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7673 Don't print either the top-level value, or the children if the
7674 max-depth is exceeded.
7675 (ppscm_print_children): When printing the key of a map, allow one
7676 extra level of depth.
7677 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7678 print either the top-level value, or the children if the max-depth
7679 is exceeded.
7680 (print_children): When printing the key of a map, allow one extra
7681 level of depth.
7682 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7683 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7684 (user_print_options): Initialise max_depth field.
7685 (val_print_scalar_or_string_type_p): New function.
7686 (val_print): Check to see if the max depth has been reached.
7687 (val_print_check_max_depth): Define new function.
7688 (show_print_max_depth): New function.
7689 (_initialize_valprint): Add 'print max-depth' option.
7690 * valprint.h (struct value_print_options) <max_depth>: New field.
7691 (val_print_check_max_depth): Declare new function.
7692 * NEWS: Document new feature.
7693
4be290b2
AB
76942019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7695
7696 * ada-lang.c (ada_language_defn): Initialise new field.
7697 * c-lang.c (c_is_string_type_p): New function.
7698 (c_language_defn): Initialise new field.
7699 (cplus_language_defn): Initialise new field.
7700 (asm_language_defn): Initialise new field.
7701 (minimal_language_defn): Initialise new field.
7702 * c-lang.h (c_is_string_type_p): Declare new function.
7703 * d-lang.c (d_language_defn): Initialise new field.
7704 * f-lang.c (f_is_string_type_p): New function.
7705 (f_language_defn): Initialise new field.
7706 * go-lang.c (go_is_string_type_p): New function.
7707 (go_language_defn): Initialise new field.
7708 * language.c (default_is_string_type_p): New function.
7709 (unknown_language_defn): Initialise new field.
7710 (auto_language_defn): Initialise new field.
7711 * language.h (struct language_defn) <la_is_string_type_p>: New
7712 member variable.
7713 (default_is_string_type_p): Declare new function.
7714 * m2-lang.c (m2_language_defn): Initialise new field.
7715 * objc-lang.c (objc_language_defn): Initialise new field.
7716 * opencl-lang.c (opencl_language_defn): Initialise new field.
7717 * p-lang.c (pascal_is_string_type_p): New function.
7718 (pascal_language_defn): Initialise new field.
7719 * rust-lang.c (rust_is_string_type_p): New function.
7720 (rust_language_defn): Initialise new field.
7721
721b08c6
AB
77222019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7723
7724 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7725 New field.
7726 * ada-lang.c (ada_language_defn): Initialise new field.
7727 * c-lang.c (c_language_defn): Likewise.
7728 (cplus_language_defn): Likewise.
7729 (asm_language_defn): Likewise.
7730 (minimal_language_defn): Likewise.
7731 * d-lang.c (d_language_defn): Likewise.
7732 * f-lang.c (f_language_defn): Likewise.
7733 * go-lang.c (go_language_defn): Likewise.
7734 * language.c (unknown_language_defn): Likewise.
7735 (auto_language_defn): Likewise.
7736 * m2-lang.c (m2_language_defn): Likewise.
7737 * objc-lang.c (objc_language_defn): Likewise.
7738 * opencl-lang.c (opencl_language_defn): Likewise.
7739 * p-lang.c (pascal_language_defn): Likewise.
7740 * rust-lang.c (rust_language_defn): Likewise.
7741
fc913e53
AB
77422019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7743
7744 * ada-lang.c (ada_is_character_type): Change return type to bool.
7745 (ada_is_string_type): Likewise.
7746 * ada-lang.h (ada_is_character_type): Update declaration
7747 (ada_is_string_type): Likewise.
7748
fa731fa0
PW
77492019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7750
7751 Support style in 'frame|thread apply'
7752
7753 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7754 * record.c (record_start, record_stop): Update callers of
7755 execute_command_to_string with false.
7756 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7757 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7758 methods.
7759 (class string_file): New constructor with term_out parameter.
7760 Override methods term_out and can_emit_style_escape. New member
7761 term_out.
7762 (class stdio_file): Override can_emit_style_escape.
7763 (class tee_file): Override term_out and can_emit_style_escape.
7764 * utils.h (can_emit_style_escape): Remove.
7765 * utils.c (can_emit_style_escape): Likewise.
7766 Update all callers of can_emit_style_escape (SOMESTREAM) to
7767 SOMESTREAM->can_emit_style_escape.
7768 * source-cache.c (source_cache::get_source_lines): Likewise.
7769 * stack.c (frame_apply_command_count): Call execute_command_to_string
7770 passing the term_out characteristic of the current gdb_stdout.
7771 * thread.c (thr_try_catch_cmd): Likewise.
7772 * top.c (execute_command_to_string): pass term_out parameter
7773 to construct the string_file for the command output.
7774 * ui-file.c (term_cli_styling): New function (most code moved
7775 from utils.c can_emit_style_escape).
7776 (string_file::string_file, string_file::can_emit_style_escape,
7777 stdio_file::can_emit_style_escape, tee_file::term_out,
7778 tee_file::can_emit_style_escape): New functions.
7779
136afab8
PW
77802019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7781
7782 * NEWS: Mention the new set|show may-call-functions.
7783 * infcall.c (may_call_functions_p): New variable.
7784 (show_may_call_functions_p): New function.
7785 (call_function_by_hand_dummy): Throws an error if not
7786 may-call-functions.
7787 (_initialize_infcall): Call add_setshow_boolean_cmd for
7788 may-call-functions.
7789
725cbb63
KS
77902019-04-25 Keith Seitz <keiths@redhat.com>
7791
7792 PR c++/24367
7793 * cp-support.c (inspect_type): Don't attempt substitutions
7794 of symbol with the same name.
7795
3d1cbb78
TT
77962019-04-25 Tom Tromey <tromey@adacore.com>
7797
7798 PR gdb/24475:
7799 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7800 static.
7801
94aeb44b
TT
78022019-04-25 Tom Tromey <tromey@adacore.com>
7803
7804 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7805 rvalue reference.
7806 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7807 (gdb_xml_parser::parse): Use std::move.
7808 * python/python-internal.h (gdbpy_convert_exception): Take a const
7809 reference.
7810 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7811 std::move.
7812 * python/py-utils.c (gdbpy_convert_exception): Take a const
7813 reference.
7814 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7815 Use std::move.
7816 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7817 Use std::move.
7818 * mi/mi-main.c (mi_print_exception): Take a const reference.
7819 * main.c (handle_command_errors): Take a const reference.
7820 * linespec.c (parse_linespec): Use std::move.
7821 * infcall.c (run_inferior_call): Use std::move.
7822 (call_function_by_hand_dummy): Use std::move.
7823 * exec.c (try_open_exec_file): Use std::move.
7824 * exceptions.h (exception_print, exception_fprintf)
7825 (exception_print_same): Update.
7826 * exceptions.c (print_exception, exception_print)
7827 (exception_fprintf, exception_print_same): Change parameters to
7828 const reference.
7829 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7830 * common/new-op.c: Use std::move.
7831 * common/common-exceptions.h (struct gdb_exception): Add move
7832 constructor.
7833 (struct gdb_exception_error, struct gdb_exception_quit, struct
7834 gdb_quit_bad_alloc): Change constructor to move constructor.
7835 (throw_exception): Change parameter to rvalue reference.
7836 * common/common-exceptions.c (throw_exception): Take rvalue
7837 reference.
7838 * cli/cli-interp.c (safe_execute_command): Use std::move.
7839 * breakpoint.c (insert_bp_location, location_to_sals): Use
7840 std::move.
7841
680d7fd5
TT
78422019-04-25 Tom Tromey <tromey@adacore.com>
7843
7844 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7845 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7846 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7847 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7848 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7849 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7850 guile/scm-value.c: Use unpack.
7851 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7852 gdbscm_gdb_exception.
7853 (gdbscm_throw_gdb_exception): Likewise.
7854 (struct gdbscm_gdb_exception): New.
7855 (unpack): New function.
7856 (gdbscm_wrap): Use unpack.
7857
c6fdd8b2
TT
78582019-04-25 Tom Tromey <tromey@adacore.com>
7859
7860 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7861 (gdb_rl_callback_handler): Use std::move.
7862 * common/common-exceptions.h (struct gdb_exception): Add move
7863 assignment operator.
7864 (throw_exception_sjlj): Change "exception" to const reference.
7865 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7866 (throw_exception_sjlj): Change "exception" to const reference.
7867
cc06b668
TT
78682019-04-25 Tom Tromey <tromey@adacore.com>
7869
7870 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7871 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7872 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7873 Update.
7874 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7875 Update.
7876 * mi/mi-interp.c (mi_interp::exec): Update.
7877 * linespec.c (parse_linespec): Update.
7878 * infcall.c (run_inferior_call): Update.
7879 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7880 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7881 (gdbscm_lookup_global_symbol): Update.
7882 * guile/scm-param.c (gdbscm_parameter_value): Update.
7883 * guile/scm-frame.c (gdbscm_frame_read_register)
7884 (gdbscm_frame_read_var): Update.
7885 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7886 * exec.c (try_open_exec_file): Update.
7887 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7888 (gdb_rl_callback_handler): Update.
7889 * common/common-exceptions.h (exception_none): Don't declare.
7890 * common/common-exceptions.c (exception_none): Don't define.
7891 (struct catcher) <exception>: Update.
7892 * cli/cli-interp.c (safe_execute_command): Update.
7893 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7894
cf532bd1
AT
78952019-04-25 Ali Tamur <tamur@google.com>
7896
7897 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7898 (read_attribute_value): Likewise.
7899 (dwarf2_read_addr_index): Update comment.
7900 (read_str_index): Add DW_FORM_strx.
7901 (dwarf2_string_attr): Likewise.
7902 (dwarf2_const_value_attr): Likewise.
7903 (dump_die_shallow): Likewise.
7904 (dwarf2_fetch_constant_bytes): Likewise.
7905 (skip_form_bytes): Likewise.
7906 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7907
82433e3e
SDJ
79082019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7909
7910 PR corefiles/11608
7911 PR corefiles/18187
7912 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7913 OFFSET. Verify if current mapping contains an ELF header.
7914 (linux_find_memory_regions_full): Adjust call to
7915 dump_mapping_p.
7916
723adb65
SL
79172019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7918 Kang Li <kanglictf@gmail.com>
7919
7920 PR gdb/21600
7921
7922 * dwarf2-frame.c (read_initial_length): Be consistent about using
7923 unsigned representation of length.
7924 (decode_frame_entry_1): Likewise. Check for wraparound of
7925 end pointer as well as buffer overflow.
7926
596179f7
SDJ
79272019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7928
7929 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7930 "vq".
7931
a59240a4
TT
79322019-04-24 Tom Tromey <tromey@adacore.com>
7933
7934 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7935
f872fdbb
AB
79362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7937
7938 * s12z-tdep.c (s12z_unwind_pc): Delete.
7939 (s12z_unwind_sp): Delete.
7940 (s12z_gdbarch_init): Don't register deleted functions with
7941 gdbarch.
7942
b614e6f3
AB
79432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7944
7945 * rl78-tdep.c (rl78_unwind_sp): Delete.
7946 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7947
14faed38
AB
79482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7949
7950 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7951 (xstormy16_unwind_pc): Delete.
7952 (xstormy16_dummy_id): Delete.
7953 (xstormy16_gdbarch_init): Don't register deleted functions with
7954 gdbarch.
7955
541aad8a
AB
79562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7957
7958 * vax-tdep.c (vax_unwind_pc): Delete.
7959 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7960
29222070
AB
79612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7962
7963 * v850-tdep.c (v850_unwind_sp): Delete.
7964 (v850_unwind_pc): Delete.
7965 (v850_dummy_id): Delete.
7966 (v850_gdbarch_init): Don't register deleted functions with
7967 gdbarch.
7968
0f534d76
AB
79692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7970
7971 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7972 (tilegx_unwind_pc): Delete.
7973 (tilegx_unwind_dummy_id): Delete.
7974 (tilegx_gdbarch_init): Don't register deleted functions with
7975 gdbarch.
7976
1ba7b7f9
AB
79772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7978
7979 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7980 (tic6x_dummy_id): Delete.
7981 (tic6x_gdbarch_init): Don't register deleted functions with
7982 gdbarch.
7983
d31f262c
AB
79842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7985
7986 * sparc-tdep.c (sparc_unwind_pc): Delete.
7987 (sparc32_gdbarch_init): Don't register deleted function with
7988 gdbarch.
7989
6d14d64d
AB
79902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7991
7992 * sh-tdep.c (sh_unwind_sp): Delete.
7993 (sh_unwind_pc): Delete.
7994 (sh_dummy_id): Delete.
7995 (sh_gdbarch_init): Don't register deleted functions with
7996 gdbarch.
7997
a40dde9d
AB
79982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7999
8000 * score-tdep.c (score_unwind_sp): Delete.
8001 (score_unwind_pc): Delete.
8002 (score_dummy_id): Delete.
8003 (score_gdbarch_init): Don't register deleted functions with
8004 gdbarch.
8005
47c47d69
AB
80062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8007
8008 * rx-tdep.c (rx_unwind_pc): Delete.
8009 (rx_unwind_sp): Delete.
8010 (rx_dummy_id): Delete.
8011 (rx_gdbarch_init): Don't register deleted functions with
8012 gdbarch. Update comment.
8013
833a4480
AB
80142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8015
8016 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8017 (rs6000_dummy_id): Delete.
8018 (rs6000_gdbarch_init): Don't register deleted functions with
8019 gdbarch.
8020
3f2cef49
AB
80212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8022
8023 * or1k-tdep.c (or1k_dummy_id): Delete.
8024 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8025
96acf884
AB
80262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8027
8028 * nios2-tdep.c (nios2_dummy_id): Delete.
8029 (nios2_unwind_sp): Delete.
8030 (nios2_gdbarch_init): Don't register deleted functions with
8031 gdbarch.
8032
ca0ab0aa
AB
80332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8034
8035 * nds32-tdep.c (nds32_dummy_id): Delete.
8036 (nds32_unwind_pc): Delete.
8037 (nds32_unwind_sp): Delete.
8038 (nds32_gdbarch_init): Don't register deleted functions with
8039 gdbarch.
8040
c8259044
AB
80412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8042
8043 * msp430-tdep.c (msp430_unwind_pc): Delete.
8044 (msp430_unwind_sp): Delete.
8045 (msp430_dummy_id): Delete.
8046 (msp430_gdbarch_init): Don't register deleted functions with
8047 gdbarch.
8048
27f113c8
AB
80492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8050
8051 * moxie-tdep.c (moxie_unwind_sp): Delete.
8052 (moxie_unwind_pc): Delete.
8053 (moxie_dummy_id): Delete.
8054 (moxie_gdbarch_init): Don't register deleted functions with
8055 gdbarch.
8056
aee6c3cd
AB
80572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8058
8059 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8060 (mn10300_unwind_pc): Delete.
8061 (mn10300_unwind_sp): Delete.
8062 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8063 mn10300_unwind_sp.
8064 (mn10300_frame_unwind_init): Don't register deleted functions with
8065 gdbarch.
8066
8e2b5aea
AB
80672019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8068
8069 * mep-tdep.c (mep_unwind_pc): Delete.
8070 (mep_unwind_sp): Delete.
8071 (mep_dummy_id): Delete.
8072 (mep_gdbarch_init): Don't register deleted functions with
8073 gdbarch.
8074
43cf3ede
AB
80752019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8076
8077 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8078 (m68hc11_unwind_sp): Delete.
8079 (m68hc11_gdbarch_init): Don't register deleted functions with
8080 gdbarch.
8081
5e79b7bb
AB
80822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8083
8084 * m32r-tdep.c (m32r_unwind_sp): Delete.
8085 (m32r_unwind_pc): Delete.
8086 (m32r_dummy_id): Delete.
8087 (m32r_gdbarch_init): Don't register deleted functions with
8088 gdbarch.
8089
89b268d8
AB
80902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8091
8092 * m32c-tdep.c (m32c_unwind_pc): Delete.
8093 (m32c_unwind_sp): Delete.
8094 (m32c_dummy_id): Delete.
8095 (m32c_gdbarch_init): Don't register deleted functions with
8096 gdbarch.
8097
946c28d2
AB
80982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8099
8100 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8101 (lm32_unwind_pc): Delete.
8102 (lm32_dummy_id): Delete.
8103 (lm32_gdbarch_init): Don't register deleted functions with
8104 gdbarch.
8105
bf12844a
AB
81062019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8107
8108 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8109 (iq2000_unwind_pc): Delete.
8110 (iq2000_dummy_id): Delete.
8111 (iq2000_gdbarch_init): Don't register deleted functions with
8112 gdbarch.
8113
ecbc06d2
AB
81142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8115
8116 * nds32-tdep.c (nds32_type_align): Delete.
8117 (nds32_push_dummy_call): Use type_align instead.
8118
030197b4
AB
81192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8120
8121 * arm-tdep.c (arm_type_align): Only handle vector override case.
8122 (arm_push_dummy_call): Use type_align.
8123 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8124
b907456c
AB
81252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8126
8127 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8128 case.
8129 (pass_on_stack): Use type_align.
8130 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8131 function.
8132
9e97ba43
TT
81332019-04-23 Tom Tromey <tromey@adacore.com>
8134
8135 * dwarf2read.c (line_header::file_name_at): Remove unused
8136 overload.
8137
6892f601
TV
81382019-04-23 Tom de Vries <tdevries@suse.de>
8139
8140 PR gdb/24438
8141 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8142 invocation.
8143
336d760d
AT
8144
81452019-03-27 Ali Tamur <tamur@google.com>
8146
8147 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8148 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8149 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8150 (dwarf_expr_context::get_addr_index): Likewise
8151 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8152 (symbol_needs_eval_context::get_addr_index): Likewise
8153 (disassemble_dwarf_expression): Add DW_OP_addrx
8154 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8155 (read_cutu_die_from_dwo): Update comment
8156 (skip_one_die): Add DW_FORM_addrx
8157 (read_attribute_value): Likewise
8158 (var_decode_location): Add DW_OP_addrx
8159 (dwarf2_const_value_attr): Add DW_FORM_addrx
8160 (dump_die_shallow): Likewise
8161 (dwarf2_fetch_constant_bytes): Likewise
8162 (decode_locdesc): Add DW_OP_addrx
8163 (skip_form_bytes): Add DW_FORM_addrx
8164
ad9d13f8
AT
81652019-04-22 Ali Tamur <tamur@google.com>
8166
8167 * MAINTAINERS (Write After Approval): Add self.
8168
d70cc3ba
SM
81692019-04-22 Simon Marchi <simon.marchi@efficios.com>
8170
8171 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8172 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8173 (open_symbol_file_object): Likewise.
8174 (svr4_default_sos): Add info parameter.
8175 (svr4_read_so_list): Likewise.
8176 (svr4_current_sos_direct): Adjust functions calls to pass down
8177 info.
8178 (svr4_current_sos_1): Add info parameter.
8179 (svr4_current_sos): Call get_svr4_info, pass info down to
8180 svr4_current_sos_1.
8181 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8182 get_svr4_info.
8183 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8184 get_svr4_info.
8185 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8186 to get_svr4_info.
8187 (probes_table_remove_objfile_probes): Likewise.
8188 (register_solib_event_probe): Add info parameter.
8189 (solist_update_incremental): Pass info parameter down to
8190 svr4_read_so_list.
8191 (disable_probes_interface): Add info parameter.
8192 (svr4_handle_solib_event): Pass current_program_space to
8193 get_svr4_info. Adjust disable_probes_interface cleanup.
8194 (svr4_create_probe_breakpoints): Add info parameter, pass it
8195 down to register_solib_event_probe.
8196 (svr4_create_solib_event_breakpoints): Add info parameter,
8197 pass it down to svr4_create_probe_breakpoints.
8198 (enable_break): Pass info down to
8199 svr4_create_solib_event_breakpoints.
8200 (svr4_solib_create_inferior_hook): Pass current_program_space to
8201 get_svr4_info.
8202 (svr4_clear_solib): Likewise.
8203
7905fc35
PA
82042019-04-22 Pedro Alves <palves@redhat.com>
8205
8206 * solib-svr4.c (svr4_free_objfile_observer): New.
8207 (probe_and_action::objfile): New field.
8208 (probes_table_htab_remove_objfile_probes)
8209 (probes_table_remove_objfile_probes): New functions.
8210 (register_solib_event_probe): Add 'objfile' parameter. Store it
8211 in the new probe_and_action. Don't store the probe in 'lookup'.
8212 (svr4_create_probe_breakpoints): Pass objfile to
8213 register_solib_event_probe.
8214 (_initialize_svr4_solib): Register a free_objfile observer.
8215
fb881986
TT
82162019-04-19 Tom Tromey <tom@tromey.com>
8217
8218 * common/queue.h: Remove.
8219
8732db6c
TT
82202019-04-19 Tom Tromey <tom@tromey.com>
8221
8222 * event-loop.c: Don't include "common/queue.h".
8223
97dfbadd
TT
82242019-04-19 Tom Tromey <tom@tromey.com>
8225
8226 * remote.c (remote_target): Use delete.
8227 * remote-notif.h: Include <list>, not "common/queue.h".
8228 (notif_client_p): Remove typedef.
8229 (remote_notif_state): Add constructor, destructor, initializer.
8230 <notif_queue>: Now a std::list.
8231 (remote_notif_state_xfree): Don't declare.
8232 * remote-notif.c (remote_notif_process, handle_notification)
8233 (remote_notif_state_allocate): Update.
8234 (~remote_notif_state): Rename from remote_notif_state_xfree.
8235
cf250e36
TT
82362019-04-19 Tom Tromey <tom@tromey.com>
8237
8238 * symfile.c (reread_symbols): Update.
8239 * objfiles.c (objfile_register_static_link)
8240 (objfile_lookup_static_link): Update
8241 (~objfile) Don't delete static_links.
8242 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8243
61f4b350
TT
82442019-04-19 Tom Tromey <tom@tromey.com>
8245
8246 * type-stack.h (struct type_stack) <insert>: Constify string.
8247 * type-stack.c (type_stack::insert): Constify string.
8248 * gdbtypes.h (lookup_template_type): Update.
8249 (address_space_name_to_int): Update.
8250 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8251 const.
8252 (lookup_template_type): Make name const.
8253 * c-exp.y: Update rules.
8254 (lex_one_token, classify_name, classify_inner_name)
8255 (c_print_token): Update.
8256 * p-exp.y: Update rules.
8257 (yylex): Update.
8258 * f-exp.y: Update rules.
8259 (yylex): Update.
8260 * d-exp.y: Update rules.
8261 (lex_one_token, classify_name, classify_inner_name): Update.
8262 * parse.c (write_dollar_variable, copy_name): Return std::string.
8263 * parser-defs.h (copy_name): Change return type.
8264 * m2-exp.y: Update rules.
8265 (yylex): Update.
8266 * go-exp.y (lex_one_token): Update.
8267 Update rules.
8268 (classify_unsafe_function, classify_packaged_name)
8269 (classify_name, yylex): Update.
8270
189b8c2e
ST
82712019-04-19 Sergei Trofimovich <siarheit@google.com>
8272
8273 * configure.ac: add --enable-source-highlight switch.
8274 * configure: Regenerate.
8275 * top.c (print_gdb_version): plumb --enable-source-highlight
8276 status to "show configuration".
8277
8ecb59f8
TT
82782019-04-19 Tom Tromey <tromey@adacore.com>
8279
8280 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8281 Check ADA_TYPE_P.
8282 (empty_record, ada_template_to_fixed_record_type_1)
8283 (template_to_static_fixed_type)
8284 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8285 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8286 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8287 macros.
8288
62160ec9
TT
82892019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8290
8291 PR symtab/24423:
8292 * source.c (print_source_lines_base): Advance "iter" when a
8293 control character is seen.
8294
f2ae8bc8
PW
82952019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8296
8297 * inferior.h (struct infcall_suspend_state_deleter):
8298 Catch exception in destructor to avoid crash.
8299
d563b953
PW
83002019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8301
8302 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8303 close to the add_com "shell".
8304
dc34c897
TT
83052019-04-18 Tom Tromey <tromey@adacore.com>
8306
8307 * process-stratum-target.h (class process_stratum_target)
8308 <stratum>: Add "final".
8309
a12e5744
TT
83102019-04-17 Tom Tromey <tromey@adacore.com>
8311
8312 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8313 against nullptr before use.
8314
a7e559cc
AH
83152019-04-17 Alan Hayward <alan.hayward@arm.com>
8316
8317 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8318
c01660c6
AB
83192019-04-17 Jim Wilson <jimw@sifive.com>
8320 Andrew Burgess <andrew.burgess@embecosm.com>
8321
8322 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8323 code read might fail, assume 4-byte breakpoint in that case.
8324
4aa866af
LS
83252019-04-15 Leszek Swirski <leszeks@google.com>
8326
8327 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8328 rather than a hand-rolled POD check when checking for forced MEMORY
8329 classification.
8330
48574d91
AH
83312019-04-15 Alan Hayward <alan.hayward@arm.com>
8332
8333 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8334 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8335 function.
8336 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8337 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8338 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8339 declaration.
8340
4da037ef
AH
83412019-04-15 Alan Hayward <alan.hayward@arm.com>
8342
8343 * aarch64-linux-nat.c
8344 (aarch64_linux_nat_target::thread_architecture): Add override.
8345 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8346 each VQ.
8347
ccb8d7e8
AH
83482019-04-15 Alan Hayward <alan.hayward@arm.com>
8349
8350 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8351
35add35e
AB
83522019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8353
8354 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8355 target types of size 96-bits, add some additional comments, and
8356 check that the builtin type we found was the correct size.
8357
51196bbc
EZ
83582019-04-12 Eli Zaretskii <eliz@gnu.org>
8359
8360 * utils.c (prompt_for_continue): Don't restore the styling at the
8361 end, as applied_style has the wrong value. This fixes styling in
8362 long lists of file names that are interrupted by the "Continue?"
8363 prompt.
8364
62253a61
AB
83652019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8366
8367 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8368 * c-lang.c (c_language_defn): Likewise.
8369 (cplus_language_defn): Likewise.
8370 (asm_language_defn): Likewise.
8371 (minimal_language_defn): Likewise.
8372 * d-lang.c (d_language_defn): Likewise.
8373 * f-lang.c (f_language_defn): Likewise.
8374 * go-lang.c (go_language_defn): Likewise.
8375 * language.c (unknown_language_defn): Likewise.
8376 (auto_language_defn): Likewise.
8377 * language.h (struct language_defn): Remove la_magic field.
8378 (LANG_MAGIC): Delete.
8379 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8380 * objc-lang.c (objc_language_defn): Likewise.
8381 * opencl-lang.c (opencl_language_defn): Likewise.
8382 * p-lang.c (pascal_language_defn): Likewise.
8383 * rust-lang.c (rust_language_defn): Likewise.
8384
a9158a86
AB
83852019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8386
8387 * riscv-tdep.c (riscv_type_align): New function.
8388 (riscv_type_alignment): Delete.
8389 (riscv_arg_location): Use 'type_align'.
8390 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8391
41077b66
AB
83922019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8393
8394 * gdbtypes.c (type_align): A struct with no non-static fields also
8395 has alignment of 1.
8396
9f0272f8
AB
83972019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8398
8399 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8400 component to 0.
8401 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8402 member.
8403 (riscv_struct_info::analyse): New implementation using new
8404 analyse_inner member function.
8405 (riscv_struct_info::field_offset): New member function.
8406 (riscv_struct_info::m_offsets): New member variable.
8407 (riscv_struct_info::analyse_inner): New private member function,
8408 takes the old implementation of riscv_struct_info::analyse but
8409 extended to track field offsets.
8410 (riscv_call_arg_struct): Update the struct folding special cases
8411 to handle cases where empty C++ structs, which are non-zero
8412 length, are found.
8413 (riscv_arg_location): Initialise the length of each location, a
8414 non-zero length now indicates the location is in use.
8415 (riscv_push_dummy_call): Allow for the first location having a
8416 non-zero offset when setting up arguments.
8417 (riscv_return_value): Likewise, but for return values.
8418
02cf60c7
TT
84192019-04-11 Tom Tromey <tromey@adacore.com>
8420
8421 * utils.c (internal_vproblem): Make "msg" const.
8422
68811f8f
AH
84232019-04-11 Alan Hayward <alan.hayward@arm.com>
8424
8425 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8426 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8427 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8428 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8429
3f52fdbc
KB
84302019-04-10 Kevin Buettner <kevinb@redhat.com>
8431
8432 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8433 function.
8434 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8435 of amd64_collect_native_gregset.
8436 (amd64_linux_nat_target::store_registers): Likewise.
8437
e9ad22ee
TT
84382019-04-10 Tom Tromey <tom@tromey.com>
8439
8440 * symtab.c (lookup_global_symbol_from_objfile)
8441 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8442 * objfiles.h (class separate_debug_iterator): New.
8443 (class separate_debug_range): New.
8444 (struct objfile) <separate_debug_objfiles>: New method.
8445 (objfile_separate_debug_iterate): Don't declare.
8446 * objfiles.c (separate_debug_iterator::operator++): Rename from
8447 objfile_separate_debug_iterate.
8448 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8449 iterator.
8450 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8451 iterator.
8452
ee371134
TT
84532019-04-10 Tom Tromey <tom@tromey.com>
8454
8455 * symfile.c (reread_symbols): Remove old comment.
8456 * objfiles.c (free_all_objfiles): Fix a typo.
8457
bf227d61
TT
84582019-04-10 Tom Tromey <tom@tromey.com>
8459
8460 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8461 * minsyms.c (lookup_minimal_symbol): Use foreach.
8462 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8463 (lookup_minimal_symbol_solib_trampoline): Likewise.
8464 * symfile.c (reread_symbols): Use foreach.
8465
8dc433a0
TT
84662019-04-09 Ivan Begert <ivanbegert@gmail.com>
8467 Tom Tromey <tromey@adacore.com>
8468
8469 PR rust/24414:
8470 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8471 (rust_lex_int_test): Change "value" to be LONGEST.
8472 (rust_lex_tests): Add test for long integer literal.
8473
9ab8741a
TT
84742019-04-09 Tom Tromey <tromey@adacore.com>
8475
8476 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8477 to bool.
8478 (extended_remote_target::attach): Update.
8479 (remote_target::remote_notice_new_inferior): Update.
8480 (remote_target::add_current_inferior_and_thread): Update.
8481 * inferior.c (exit_inferior_1): Use "false".
8482 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8483
e242fd12
SM
84842019-04-09 Simon Marchi <simon.marchi@efficios.com>
8485
9ca1957f 8486 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
8487 the "start" command.
8488
2b0c8b01
KB
84892019-04-08 Kevin Buettner <kevinb@redhat.com>
8490
8491 * python/py-inferior.c (infpy_thread_from_thread_handle):
8492 Adjust comments to reflect renaming of thread_from_thread_handle
8493 to thread_from_handle. Adjust keywords. Fix type error message.
8494 (inferior_object_methods): Add thread_from_handle. Retain
8495 thread_from_thread_handle, but mark it as deprecated.
8496
50a82723
KB
84972019-04-08 Kevin Buettner <kevinb@redhat.com>
8498
8499 * gdbthread.h (find_thread_by_handle): Revise declaration.
8500 * thread.c (find_thread_by_handle): Likewise. Adjust
8501 implementation too.
8502 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8503 support for buffer objects as handles.
8504
cf63b016
KB
85052019-04-08 Kevin Buettner <kevinb@redhat.com>
8506
8507 * python/py-infthread.c (thpy_thread_handle): New function.
8508 (thread_object_methods): Register thpy_thread_handle.
8509
3d6c6204
KB
85102019-04-08 Kevin Buettner <kevinb@redhat.com>
8511
8512 * gdbthread.h (thread_to_thread_handle): Declare.
8513 * thread.c (gdbtypes.h): Include.
8514 (thread_to_thread_handle): New function.
8515
8516 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8517 (target_thread_info_to_thread_handle): Declare.
8518 * target.c (target_thread_info_to_thread_handle): New function.
8519 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8520 * target-delegates.c: Regenerate.
8521
8522 * linux-thread-db.c (class thread_db_target): Add method
8523 thread_info_to_thread_handle.
8524 (thread_db_target::thread_info_to_thread_handle): Define.
8525 * remote.c (class remote_target): Add new method
8526 thread_info_to_thread_handle.
8527 (remote_target::thread_info_to_thread_handle): Define.
8528
56be6ea8
PA
85292019-04-08 Pedro Alves <palves@redhat.com>
8530
8531 * common/common-exceptions.c (throw_exception): Don't create
8532 named object to throw; throw directly.
8533 (throw_it): Likewise. Don't initialize gdb_exception::message
8534 here, with new; pass FMT and AP to the ctor instead.
8535 * common/common-exceptions.h: Include <string>.
8536 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8537 const char *, va_list)): New ctor. Use std::make_shared.
8538 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8539 errors)): Delete.
8540 (gdb_exception_error::gdb_exception_error(enum errors, const char
8541 *, va_list)): New.
8542 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8543 Add assertion.
8544 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8545 errors)): Delete.
8546 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8547 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8548 Add assertion.
8549
eedc3f4f
TT
85502019-04-08 Tom Tromey <tom@tromey.com>
8551
8552 * valops.c (value_rtti_indirect_type): Replace throw_exception
8553 with throw.
8554 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8555 with throw.
8556 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8557 throw.
8558 * target.c (target_translate_tls_address): Replace throw_exception
8559 with throw.
8560 * stack.c (frame_apply_command_count): Replace throw_exception
8561 with throw.
8562 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8563 throw.
8564 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8565 with throw.
8566 * rs6000-tdep.c (rs6000_frame_cache)
8567 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8568 * remote.c: Replace throw_exception with throw.
8569 * record-full.c (record_full_message, record_full_wait_1)
8570 (record_full_restore): Replace throw_exception with throw.
8571 * record-btrace.c:
8572 (get_thread_current_frame_id, record_btrace_start_replaying)
8573 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8574 (cmd_record_btrace_start): Replace throw_exception with throw.
8575 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8576 throw.
8577 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8578 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8579 * linespec.c:
8580 (find_linespec_symbols): Replace throw_exception with throw.
8581 * infrun.c (displaced_step_prepare, resume): Replace
8582 throw_exception with throw.
8583 * infcmd.c (post_create_inferior): Replace throw_exception with
8584 throw.
8585 * inf-loop.c (inferior_event_handler): Replace throw_exception
8586 with throw.
8587 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8588 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8589 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8590 (get_prev_frame_always, get_frame_pc_if_available)
8591 (get_frame_address_in_block_if_available, get_frame_language):
8592 Replace throw_exception with throw.
8593 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8594 throw_exception with throw.
8595 * eval.c (fetch_subexp_value, evaluate_var_value)
8596 (evaluate_funcall, evaluate_subexp_standard): Replace
8597 throw_exception with throw.
8598 * dwarf2loc.c (call_site_find_chain)
8599 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8600 Replace throw_exception with throw.
8601 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8602 with throw.
8603 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8604 throw.
8605 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8606 * completer.c (complete_line_internal): Replace throw_exception
8607 with throw.
8608 * compile/compile-object-run.c (compile_object_run): Replace
8609 throw_exception with throw.
8610 * cli/cli-script.c (process_next_line): Replace throw_exception
8611 with throw.
8612 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8613 (btrace_enable, btrace_maint_update_pt_packets): Replace
8614 throw_exception with throw.
8615 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8616 throw_exception with throw.
8617 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8618 throw_exception with throw.
8619 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8620 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8621 * aarch64-tdep.c (aarch64_make_prologue_cache)
8622 (aarch64_make_stub_cache): Replace throw_exception with throw.
8623
26003a20
TT
86242019-04-08 Tom Tromey <tom@tromey.com>
8625
8626 * common/common-exceptions.c (throw_exception): Rename from
8627 throw_exception_cxx. Remove old copy. Make argument const.
8628 (throw_it): Create and throw exception objects directly.
8629 * common/common-exceptions.h (throw_exception): Make argument
8630 const.
8631 (struct gdb_exception_error): Add constructor.
8632 (struct gdb_exception_quit): Add constructor.
8633
d272eb37
TT
86342019-04-08 Tom Tromey <tom@tromey.com>
8635
8636 * common/common-exceptions.h (exception_rethrow): Don't declare.
8637 (TRY_SJLJ): Update comment.
8638 (TRY, CATCH, END_CATCH): Remove.
8639 * common/common-exceptions.c (exception_rethrow): Remove.
8640
230d2906
TT
86412019-04-08 Tom Tromey <tom@tromey.com>
8642
8643 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8644 Remove.
8645 (gdb_exception_error): Rename from
8646 gdb_exception_RETURN_MASK_ERROR.
8647 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8648 (gdb_quit_bad_alloc): Update.
8649 * aarch64-tdep.c: Update.
8650 * ada-lang.c: Update.
8651 * ada-typeprint.c: Update.
8652 * ada-valprint.c: Update.
8653 * amd64-tdep.c: Update.
8654 * arch-utils.c: Update.
8655 * break-catch-throw.c: Update.
8656 * breakpoint.c: Update.
8657 * btrace.c: Update.
8658 * c-varobj.c: Update.
8659 * cli/cli-cmds.c: Update.
8660 * cli/cli-interp.c: Update.
8661 * cli/cli-script.c: Update.
8662 * common/common-exceptions.c: Update.
8663 * common/new-op.c: Update.
8664 * common/selftest.c: Update.
8665 * compile/compile-c-symbols.c: Update.
8666 * compile/compile-cplus-symbols.c: Update.
8667 * compile/compile-object-load.c: Update.
8668 * compile/compile-object-run.c: Update.
8669 * completer.c: Update.
8670 * corelow.c: Update.
8671 * cp-abi.c: Update.
8672 * cp-support.c: Update.
8673 * cp-valprint.c: Update.
8674 * darwin-nat.c: Update.
8675 * disasm-selftests.c: Update.
8676 * dtrace-probe.c: Update.
8677 * dwarf-index-cache.c: Update.
8678 * dwarf-index-write.c: Update.
8679 * dwarf2-frame-tailcall.c: Update.
8680 * dwarf2-frame.c: Update.
8681 * dwarf2loc.c: Update.
8682 * dwarf2read.c: Update.
8683 * eval.c: Update.
8684 * event-loop.c: Update.
8685 * event-top.c: Update.
8686 * exec.c: Update.
8687 * f-valprint.c: Update.
8688 * fbsd-tdep.c: Update.
8689 * frame-unwind.c: Update.
8690 * frame.c: Update.
8691 * gdbtypes.c: Update.
8692 * gnu-v3-abi.c: Update.
8693 * guile/guile-internal.h: Update.
8694 * guile/scm-block.c: Update.
8695 * guile/scm-breakpoint.c: Update.
8696 * guile/scm-cmd.c: Update.
8697 * guile/scm-disasm.c: Update.
8698 * guile/scm-frame.c: Update.
8699 * guile/scm-lazy-string.c: Update.
8700 * guile/scm-math.c: Update.
8701 * guile/scm-param.c: Update.
8702 * guile/scm-ports.c: Update.
8703 * guile/scm-pretty-print.c: Update.
8704 * guile/scm-symbol.c: Update.
8705 * guile/scm-symtab.c: Update.
8706 * guile/scm-type.c: Update.
8707 * guile/scm-value.c: Update.
8708 * i386-linux-tdep.c: Update.
8709 * i386-tdep.c: Update.
8710 * inf-loop.c: Update.
8711 * infcall.c: Update.
8712 * infcmd.c: Update.
8713 * infrun.c: Update.
8714 * jit.c: Update.
8715 * language.c: Update.
8716 * linespec.c: Update.
8717 * linux-fork.c: Update.
8718 * linux-nat.c: Update.
8719 * linux-tdep.c: Update.
8720 * linux-thread-db.c: Update.
8721 * main.c: Update.
8722 * mi/mi-cmd-break.c: Update.
8723 * mi/mi-cmd-stack.c: Update.
8724 * mi/mi-interp.c: Update.
8725 * mi/mi-main.c: Update.
8726 * objc-lang.c: Update.
8727 * p-valprint.c: Update.
8728 * parse.c: Update.
8729 * ppc-linux-tdep.c: Update.
8730 * printcmd.c: Update.
8731 * python/py-arch.c: Update.
8732 * python/py-breakpoint.c: Update.
8733 * python/py-cmd.c: Update.
8734 * python/py-finishbreakpoint.c: Update.
8735 * python/py-frame.c: Update.
8736 * python/py-framefilter.c: Update.
8737 * python/py-gdb-readline.c: Update.
8738 * python/py-inferior.c: Update.
8739 * python/py-infthread.c: Update.
8740 * python/py-lazy-string.c: Update.
8741 * python/py-linetable.c: Update.
8742 * python/py-objfile.c: Update.
8743 * python/py-param.c: Update.
8744 * python/py-prettyprint.c: Update.
8745 * python/py-progspace.c: Update.
8746 * python/py-record-btrace.c: Update.
8747 * python/py-record.c: Update.
8748 * python/py-symbol.c: Update.
8749 * python/py-type.c: Update.
8750 * python/py-unwind.c: Update.
8751 * python/py-utils.c: Update.
8752 * python/py-value.c: Update.
8753 * python/python.c: Update.
8754 * record-btrace.c: Update.
8755 * record-full.c: Update.
8756 * remote-fileio.c: Update.
8757 * remote.c: Update.
8758 * riscv-tdep.c: Update.
8759 * rs6000-aix-tdep.c: Update.
8760 * rs6000-tdep.c: Update.
8761 * rust-exp.y: Update.
8762 * rust-lang.c: Update.
8763 * s390-tdep.c: Update.
8764 * selftest-arch.c: Update.
8765 * solib-dsbt.c: Update.
8766 * solib-frv.c: Update.
8767 * solib-spu.c: Update.
8768 * solib-svr4.c: Update.
8769 * solib.c: Update.
8770 * sparc64-linux-tdep.c: Update.
8771 * stack.c: Update.
8772 * symfile-mem.c: Update.
8773 * symmisc.c: Update.
8774 * target.c: Update.
8775 * thread.c: Update.
8776 * top.c: Update.
8777 * tracefile-tfile.c: Update.
8778 * tui/tui.c: Update.
8779 * typeprint.c: Update.
8780 * unittests/cli-utils-selftests.c: Update.
8781 * unittests/parse-connection-spec-selftests.c: Update.
8782 * valops.c: Update.
8783 * valprint.c: Update.
8784 * value.c: Update.
8785 * varobj.c: Update.
8786 * windows-nat.c: Update.
8787 * x86-linux-nat.c: Update.
8788 * xml-support.c: Update.
8789
a70b8144
TT
87902019-04-08 Tom Tromey <tom@tromey.com>
8791
8792 * xml-support.c: Use C++ exception handling.
8793 * x86-linux-nat.c: Use C++ exception handling.
8794 * windows-nat.c: Use C++ exception handling.
8795 * varobj.c: Use C++ exception handling.
8796 * value.c: Use C++ exception handling.
8797 * valprint.c: Use C++ exception handling.
8798 * valops.c: Use C++ exception handling.
8799 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8800 handling.
8801 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8802 * typeprint.c: Use C++ exception handling.
8803 * tui/tui.c: Use C++ exception handling.
8804 * tracefile-tfile.c: Use C++ exception handling.
8805 * top.c: Use C++ exception handling.
8806 * thread.c: Use C++ exception handling.
8807 * target.c: Use C++ exception handling.
8808 * symmisc.c: Use C++ exception handling.
8809 * symfile-mem.c: Use C++ exception handling.
8810 * stack.c: Use C++ exception handling.
8811 * sparc64-linux-tdep.c: Use C++ exception handling.
8812 * solib.c: Use C++ exception handling.
8813 * solib-svr4.c: Use C++ exception handling.
8814 * solib-spu.c: Use C++ exception handling.
8815 * solib-frv.c: Use C++ exception handling.
8816 * solib-dsbt.c: Use C++ exception handling.
8817 * selftest-arch.c: Use C++ exception handling.
8818 * s390-tdep.c: Use C++ exception handling.
8819 * rust-lang.c: Use C++ exception handling.
8820 * rust-exp.y: Use C++ exception handling.
8821 * rs6000-tdep.c: Use C++ exception handling.
8822 * rs6000-aix-tdep.c: Use C++ exception handling.
8823 * riscv-tdep.c: Use C++ exception handling.
8824 * remote.c: Use C++ exception handling.
8825 * remote-fileio.c: Use C++ exception handling.
8826 * record-full.c: Use C++ exception handling.
8827 * record-btrace.c: Use C++ exception handling.
8828 * python/python.c: Use C++ exception handling.
8829 * python/py-value.c: Use C++ exception handling.
8830 * python/py-utils.c: Use C++ exception handling.
8831 * python/py-unwind.c: Use C++ exception handling.
8832 * python/py-type.c: Use C++ exception handling.
8833 * python/py-symbol.c: Use C++ exception handling.
8834 * python/py-record.c: Use C++ exception handling.
8835 * python/py-record-btrace.c: Use C++ exception handling.
8836 * python/py-progspace.c: Use C++ exception handling.
8837 * python/py-prettyprint.c: Use C++ exception handling.
8838 * python/py-param.c: Use C++ exception handling.
8839 * python/py-objfile.c: Use C++ exception handling.
8840 * python/py-linetable.c: Use C++ exception handling.
8841 * python/py-lazy-string.c: Use C++ exception handling.
8842 * python/py-infthread.c: Use C++ exception handling.
8843 * python/py-inferior.c: Use C++ exception handling.
8844 * python/py-gdb-readline.c: Use C++ exception handling.
8845 * python/py-framefilter.c: Use C++ exception handling.
8846 * python/py-frame.c: Use C++ exception handling.
8847 * python/py-finishbreakpoint.c: Use C++ exception handling.
8848 * python/py-cmd.c: Use C++ exception handling.
8849 * python/py-breakpoint.c: Use C++ exception handling.
8850 * python/py-arch.c: Use C++ exception handling.
8851 * printcmd.c: Use C++ exception handling.
8852 * ppc-linux-tdep.c: Use C++ exception handling.
8853 * parse.c: Use C++ exception handling.
8854 * p-valprint.c: Use C++ exception handling.
8855 * objc-lang.c: Use C++ exception handling.
8856 * mi/mi-main.c: Use C++ exception handling.
8857 * mi/mi-interp.c: Use C++ exception handling.
8858 * mi/mi-cmd-stack.c: Use C++ exception handling.
8859 * mi/mi-cmd-break.c: Use C++ exception handling.
8860 * main.c: Use C++ exception handling.
8861 * linux-thread-db.c: Use C++ exception handling.
8862 * linux-tdep.c: Use C++ exception handling.
8863 * linux-nat.c: Use C++ exception handling.
8864 * linux-fork.c: Use C++ exception handling.
8865 * linespec.c: Use C++ exception handling.
8866 * language.c: Use C++ exception handling.
8867 * jit.c: Use C++ exception handling.
8868 * infrun.c: Use C++ exception handling.
8869 * infcmd.c: Use C++ exception handling.
8870 * infcall.c: Use C++ exception handling.
8871 * inf-loop.c: Use C++ exception handling.
8872 * i386-tdep.c: Use C++ exception handling.
8873 * i386-linux-tdep.c: Use C++ exception handling.
8874 * guile/scm-value.c: Use C++ exception handling.
8875 * guile/scm-type.c: Use C++ exception handling.
8876 * guile/scm-symtab.c: Use C++ exception handling.
8877 * guile/scm-symbol.c: Use C++ exception handling.
8878 * guile/scm-pretty-print.c: Use C++ exception handling.
8879 * guile/scm-ports.c: Use C++ exception handling.
8880 * guile/scm-param.c: Use C++ exception handling.
8881 * guile/scm-math.c: Use C++ exception handling.
8882 * guile/scm-lazy-string.c: Use C++ exception handling.
8883 * guile/scm-frame.c: Use C++ exception handling.
8884 * guile/scm-disasm.c: Use C++ exception handling.
8885 * guile/scm-cmd.c: Use C++ exception handling.
8886 * guile/scm-breakpoint.c: Use C++ exception handling.
8887 * guile/scm-block.c: Use C++ exception handling.
8888 * guile/guile-internal.h: Use C++ exception handling.
8889 * gnu-v3-abi.c: Use C++ exception handling.
8890 * gdbtypes.c: Use C++ exception handling.
8891 * frame.c: Use C++ exception handling.
8892 * frame-unwind.c: Use C++ exception handling.
8893 * fbsd-tdep.c: Use C++ exception handling.
8894 * f-valprint.c: Use C++ exception handling.
8895 * exec.c: Use C++ exception handling.
8896 * event-top.c: Use C++ exception handling.
8897 * event-loop.c: Use C++ exception handling.
8898 * eval.c: Use C++ exception handling.
8899 * dwarf2read.c: Use C++ exception handling.
8900 * dwarf2loc.c: Use C++ exception handling.
8901 * dwarf2-frame.c: Use C++ exception handling.
8902 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8903 * dwarf-index-write.c: Use C++ exception handling.
8904 * dwarf-index-cache.c: Use C++ exception handling.
8905 * dtrace-probe.c: Use C++ exception handling.
8906 * disasm-selftests.c: Use C++ exception handling.
8907 * darwin-nat.c: Use C++ exception handling.
8908 * cp-valprint.c: Use C++ exception handling.
8909 * cp-support.c: Use C++ exception handling.
8910 * cp-abi.c: Use C++ exception handling.
8911 * corelow.c: Use C++ exception handling.
8912 * completer.c: Use C++ exception handling.
8913 * compile/compile-object-run.c: Use C++ exception handling.
8914 * compile/compile-object-load.c: Use C++ exception handling.
8915 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8916 * compile/compile-c-symbols.c: Use C++ exception handling.
8917 * common/selftest.c: Use C++ exception handling.
8918 * common/new-op.c: Use C++ exception handling.
8919 * cli/cli-script.c: Use C++ exception handling.
8920 * cli/cli-interp.c: Use C++ exception handling.
8921 * cli/cli-cmds.c: Use C++ exception handling.
8922 * c-varobj.c: Use C++ exception handling.
8923 * btrace.c: Use C++ exception handling.
8924 * breakpoint.c: Use C++ exception handling.
8925 * break-catch-throw.c: Use C++ exception handling.
8926 * arch-utils.c: Use C++ exception handling.
8927 * amd64-tdep.c: Use C++ exception handling.
8928 * ada-valprint.c: Use C++ exception handling.
8929 * ada-typeprint.c: Use C++ exception handling.
8930 * ada-lang.c: Use C++ exception handling.
8931 * aarch64-tdep.c: Use C++ exception handling.
8932
3d6e9d23
TT
89332019-04-08 Tom Tromey <tom@tromey.com>
8934
8935 * xml-support.c (gdb_xml_parser::parse): Update.
8936 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8937 * value.c (show_convenience): Update.
8938 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8939 (test_parse_flags_qcs): Update.
8940 * thread.c (thr_try_catch_cmd): Update.
8941 * target.c (target_translate_tls_address): Update.
8942 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8943 (info_frame_command_core, frame_apply_command_count): Update.
8944 * rust-exp.y (rust_lex_exception_test): Update.
8945 * riscv-tdep.c (riscv_print_one_register_info): Update.
8946 * remote.c (remote_target::enable_btrace): Update.
8947 * record-btrace.c (record_btrace_enable_warn): Update.
8948 * python/py-utils.c (gdbpy_convert_exception): Update.
8949 * printcmd.c (do_one_display, print_variable_and_value): Update.
8950 * mi/mi-main.c (mi_print_exception): Update.
8951 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8952 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8953 * linux-nat.c (linux_nat_target::attach): Update.
8954 * linux-fork.c (class scoped_switch_fork_info): Update.
8955 * infrun.c (displaced_step_prepare): Update.
8956 * infcall.c (call_function_by_hand_dummy): Update.
8957 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8958 * gnu-v3-abi.c (print_one_vtable): Update.
8959 * frame.c (get_prev_frame_always): Update.
8960 * f-valprint.c (info_common_command_for_block): Update.
8961 * exec.c (try_open_exec_file): Update.
8962 * exceptions.c (print_exception, exception_print)
8963 (exception_fprintf, exception_print_same): Update.
8964 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8965 * dwarf-index-cache.c (index_cache::store)
8966 (index_cache::lookup_gdb_index): Update.
8967 * darwin-nat.c (maybe_cache_shell): Update.
8968 * cp-valprint.c (cp_print_value_fields): Update.
8969 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8970 (gcc_cplus_symbol_address): Update.
8971 * compile/compile-c-symbols.c (gcc_convert_symbol)
8972 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8973 * common/selftest.c: Update.
8974 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8975 a std::string.
8976 (exception_try_scope_entry, exception_try_scope_exit): Don't
8977 declare.
8978 (struct exception_try_scope): Remove.
8979 (TRY): Don't use exception_try_scope.
8980 (struct gdb_exception): Add constructor, operator=.
8981 <what>: New method.
8982 (struct gdb_exception_RETURN_MASK_ALL)
8983 (struct gdb_exception_RETURN_MASK_ERROR)
8984 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8985 (struct gdb_quit_bad_alloc): Update.
8986 * common/common-exceptions.c (exception_none): Change
8987 initializer.
8988 (struct catcher) <state, exception>: Initialize inline.
8989 <prev>: Remove member.
8990 (current_catcher): Remove.
8991 (catchers): New global.
8992 (exceptions_state_mc_init): Simplify.
8993 (catcher_pop): Remove.
8994 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8995 (try_scope_depth, exception_try_scope_entry)
8996 (exception_try_scope_exit): Remove.
8997 (throw_exception_sjlj): Update.
8998 (exception_messages, exception_messages_size): Remove.
8999 (throw_it): Simplify.
9000 (gdb_exception_sliced_copy): Remove.
9001 (throw_exception_cxx): Update.
9002 * cli/cli-script.c (script_from_file): Update.
9003 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9004 Update.
9005 * ada-valprint.c (ada_val_print): Update.
9006 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9007 (create_excep_cond_exprs): Update.
9008
c5c10118
TT
90092019-04-08 Tom Tromey <tom@tromey.com>
9010
9011 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9012 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9013 (TRY, CATCH, END_CATCH): Remove some definitions.
9014 * common/common-exceptions.c: Don't use GDB_XCPT.
9015 (catcher_list_size): Remove.
9016 (throw_exception, throw_it): Simplify.
9017
4de283e4
TT
90182019-04-05 Tom Tromey <tom@tromey.com>
9019
9020 Revert the header-sorting patch.
9021 * ft32-tdep.c: Revert.
9022 * frv-tdep.c: Revert.
9023 * frv-linux-tdep.c: Revert.
9024 * frame.c: Revert.
9025 * frame-unwind.c: Revert.
9026 * frame-base.c: Revert.
9027 * fork-child.c: Revert.
9028 * findvar.c: Revert.
9029 * findcmd.c: Revert.
9030 * filesystem.c: Revert.
9031 * filename-seen-cache.h: Revert.
9032 * filename-seen-cache.c: Revert.
9033 * fbsd-tdep.c: Revert.
9034 * fbsd-nat.h: Revert.
9035 * fbsd-nat.c: Revert.
9036 * f-valprint.c: Revert.
9037 * f-typeprint.c: Revert.
9038 * f-lang.c: Revert.
9039 * extension.h: Revert.
9040 * extension.c: Revert.
9041 * extension-priv.h: Revert.
9042 * expprint.c: Revert.
9043 * exec.h: Revert.
9044 * exec.c: Revert.
9045 * exceptions.c: Revert.
9046 * event-top.c: Revert.
9047 * event-loop.c: Revert.
9048 * eval.c: Revert.
9049 * elfread.c: Revert.
9050 * dwarf2read.h: Revert.
9051 * dwarf2read.c: Revert.
9052 * dwarf2loc.c: Revert.
9053 * dwarf2expr.h: Revert.
9054 * dwarf2expr.c: Revert.
9055 * dwarf2-frame.c: Revert.
9056 * dwarf2-frame-tailcall.c: Revert.
9057 * dwarf-index-write.h: Revert.
9058 * dwarf-index-write.c: Revert.
9059 * dwarf-index-common.c: Revert.
9060 * dwarf-index-cache.h: Revert.
9061 * dwarf-index-cache.c: Revert.
9062 * dummy-frame.c: Revert.
9063 * dtrace-probe.c: Revert.
9064 * disasm.h: Revert.
9065 * disasm.c: Revert.
9066 * disasm-selftests.c: Revert.
9067 * dictionary.c: Revert.
9068 * dicos-tdep.c: Revert.
9069 * demangle.c: Revert.
9070 * dcache.h: Revert.
9071 * dcache.c: Revert.
9072 * darwin-nat.h: Revert.
9073 * darwin-nat.c: Revert.
9074 * darwin-nat-info.c: Revert.
9075 * d-valprint.c: Revert.
9076 * d-namespace.c: Revert.
9077 * d-lang.c: Revert.
9078 * ctf.c: Revert.
9079 * csky-tdep.c: Revert.
9080 * csky-linux-tdep.c: Revert.
9081 * cris-tdep.c: Revert.
9082 * cris-linux-tdep.c: Revert.
9083 * cp-valprint.c: Revert.
9084 * cp-support.c: Revert.
9085 * cp-namespace.c: Revert.
9086 * cp-abi.c: Revert.
9087 * corelow.c: Revert.
9088 * corefile.c: Revert.
9089 * continuations.c: Revert.
9090 * completer.h: Revert.
9091 * completer.c: Revert.
9092 * complaints.c: Revert.
9093 * coffread.c: Revert.
9094 * coff-pe-read.c: Revert.
9095 * cli-out.h: Revert.
9096 * cli-out.c: Revert.
9097 * charset.c: Revert.
9098 * c-varobj.c: Revert.
9099 * c-valprint.c: Revert.
9100 * c-typeprint.c: Revert.
9101 * c-lang.c: Revert.
9102 * buildsym.c: Revert.
9103 * buildsym-legacy.c: Revert.
9104 * build-id.h: Revert.
9105 * build-id.c: Revert.
9106 * btrace.c: Revert.
9107 * bsd-uthread.c: Revert.
9108 * breakpoint.h: Revert.
9109 * breakpoint.c: Revert.
9110 * break-catch-throw.c: Revert.
9111 * break-catch-syscall.c: Revert.
9112 * break-catch-sig.c: Revert.
9113 * blockframe.c: Revert.
9114 * block.c: Revert.
9115 * bfin-tdep.c: Revert.
9116 * bfin-linux-tdep.c: Revert.
9117 * bfd-target.c: Revert.
9118 * bcache.c: Revert.
9119 * ax-general.c: Revert.
9120 * ax-gdb.h: Revert.
9121 * ax-gdb.c: Revert.
9122 * avr-tdep.c: Revert.
9123 * auxv.c: Revert.
9124 * auto-load.c: Revert.
9125 * arm-wince-tdep.c: Revert.
9126 * arm-tdep.c: Revert.
9127 * arm-symbian-tdep.c: Revert.
9128 * arm-pikeos-tdep.c: Revert.
9129 * arm-obsd-tdep.c: Revert.
9130 * arm-nbsd-tdep.c: Revert.
9131 * arm-nbsd-nat.c: Revert.
9132 * arm-linux-tdep.c: Revert.
9133 * arm-linux-nat.c: Revert.
9134 * arm-fbsd-tdep.c: Revert.
9135 * arm-fbsd-nat.c: Revert.
9136 * arm-bsd-tdep.c: Revert.
9137 * arch-utils.c: Revert.
9138 * arc-tdep.c: Revert.
9139 * arc-newlib-tdep.c: Revert.
9140 * annotate.h: Revert.
9141 * annotate.c: Revert.
9142 * amd64-windows-tdep.c: Revert.
9143 * amd64-windows-nat.c: Revert.
9144 * amd64-tdep.c: Revert.
9145 * amd64-sol2-tdep.c: Revert.
9146 * amd64-obsd-tdep.c: Revert.
9147 * amd64-obsd-nat.c: Revert.
9148 * amd64-nbsd-tdep.c: Revert.
9149 * amd64-nbsd-nat.c: Revert.
9150 * amd64-nat.c: Revert.
9151 * amd64-linux-tdep.c: Revert.
9152 * amd64-linux-nat.c: Revert.
9153 * amd64-fbsd-tdep.c: Revert.
9154 * amd64-fbsd-nat.c: Revert.
9155 * amd64-dicos-tdep.c: Revert.
9156 * amd64-darwin-tdep.c: Revert.
9157 * amd64-bsd-nat.c: Revert.
9158 * alpha-tdep.c: Revert.
9159 * alpha-obsd-tdep.c: Revert.
9160 * alpha-nbsd-tdep.c: Revert.
9161 * alpha-mdebug-tdep.c: Revert.
9162 * alpha-linux-tdep.c: Revert.
9163 * alpha-linux-nat.c: Revert.
9164 * alpha-bsd-tdep.c: Revert.
9165 * alpha-bsd-nat.c: Revert.
9166 * aix-thread.c: Revert.
9167 * agent.c: Revert.
9168 * addrmap.c: Revert.
9169 * ada-varobj.c: Revert.
9170 * ada-valprint.c: Revert.
9171 * ada-typeprint.c: Revert.
9172 * ada-tasks.c: Revert.
9173 * ada-lang.c: Revert.
9174 * aarch64-tdep.c: Revert.
9175 * aarch64-ravenscar-thread.c: Revert.
9176 * aarch64-newlib-tdep.c: Revert.
9177 * aarch64-linux-tdep.c: Revert.
9178 * aarch64-linux-nat.c: Revert.
9179 * aarch64-fbsd-tdep.c: Revert.
9180 * aarch64-fbsd-nat.c: Revert.
9181 * aarch32-linux-nat.c: Revert.
9182
d55e5aa6
TT
91832019-04-05 Tom Tromey <tom@tromey.com>
9184
9185 * ft32-tdep.c: Sort headers.
9186 * frv-tdep.c: Sort headers.
9187 * frv-linux-tdep.c: Sort headers.
9188 * frame.c: Sort headers.
9189 * frame-unwind.c: Sort headers.
9190 * frame-base.c: Sort headers.
9191 * fork-child.c: Sort headers.
9192 * findvar.c: Sort headers.
9193 * findcmd.c: Sort headers.
9194 * filesystem.c: Sort headers.
9195 * filename-seen-cache.h: Sort headers.
9196 * filename-seen-cache.c: Sort headers.
9197 * fbsd-tdep.c: Sort headers.
9198 * fbsd-nat.h: Sort headers.
9199 * fbsd-nat.c: Sort headers.
9200 * f-valprint.c: Sort headers.
9201 * f-typeprint.c: Sort headers.
9202 * f-lang.c: Sort headers.
9203 * extension.h: Sort headers.
9204 * extension.c: Sort headers.
9205 * extension-priv.h: Sort headers.
9206 * expprint.c: Sort headers.
9207 * exec.h: Sort headers.
9208 * exec.c: Sort headers.
9209 * exceptions.c: Sort headers.
9210 * event-top.c: Sort headers.
9211 * event-loop.c: Sort headers.
9212 * eval.c: Sort headers.
9213 * elfread.c: Sort headers.
9214 * dwarf2read.h: Sort headers.
9215 * dwarf2read.c: Sort headers.
9216 * dwarf2loc.c: Sort headers.
9217 * dwarf2expr.h: Sort headers.
9218 * dwarf2expr.c: Sort headers.
9219 * dwarf2-frame.c: Sort headers.
9220 * dwarf2-frame-tailcall.c: Sort headers.
9221 * dwarf-index-write.h: Sort headers.
9222 * dwarf-index-write.c: Sort headers.
9223 * dwarf-index-common.c: Sort headers.
9224 * dwarf-index-cache.h: Sort headers.
9225 * dwarf-index-cache.c: Sort headers.
9226 * dummy-frame.c: Sort headers.
9227 * dtrace-probe.c: Sort headers.
9228 * disasm.h: Sort headers.
9229 * disasm.c: Sort headers.
9230 * disasm-selftests.c: Sort headers.
9231 * dictionary.c: Sort headers.
9232 * dicos-tdep.c: Sort headers.
9233 * demangle.c: Sort headers.
9234 * dcache.h: Sort headers.
9235 * dcache.c: Sort headers.
9236 * darwin-nat.h: Sort headers.
9237 * darwin-nat.c: Sort headers.
9238 * darwin-nat-info.c: Sort headers.
9239 * d-valprint.c: Sort headers.
9240 * d-namespace.c: Sort headers.
9241 * d-lang.c: Sort headers.
9242 * ctf.c: Sort headers.
9243 * csky-tdep.c: Sort headers.
9244 * csky-linux-tdep.c: Sort headers.
9245 * cris-tdep.c: Sort headers.
9246 * cris-linux-tdep.c: Sort headers.
9247 * cp-valprint.c: Sort headers.
9248 * cp-support.c: Sort headers.
9249 * cp-namespace.c: Sort headers.
9250 * cp-abi.c: Sort headers.
9251 * corelow.c: Sort headers.
9252 * corefile.c: Sort headers.
9253 * continuations.c: Sort headers.
9254 * completer.h: Sort headers.
9255 * completer.c: Sort headers.
9256 * complaints.c: Sort headers.
9257 * coffread.c: Sort headers.
9258 * coff-pe-read.c: Sort headers.
9259 * cli-out.h: Sort headers.
9260 * cli-out.c: Sort headers.
9261 * charset.c: Sort headers.
9262 * c-varobj.c: Sort headers.
9263 * c-valprint.c: Sort headers.
9264 * c-typeprint.c: Sort headers.
9265 * c-lang.c: Sort headers.
9266 * buildsym.c: Sort headers.
9267 * buildsym-legacy.c: Sort headers.
9268 * build-id.h: Sort headers.
9269 * build-id.c: Sort headers.
9270 * btrace.c: Sort headers.
9271 * bsd-uthread.c: Sort headers.
9272 * breakpoint.h: Sort headers.
9273 * breakpoint.c: Sort headers.
9274 * break-catch-throw.c: Sort headers.
9275 * break-catch-syscall.c: Sort headers.
9276 * break-catch-sig.c: Sort headers.
9277 * blockframe.c: Sort headers.
9278 * block.c: Sort headers.
9279 * bfin-tdep.c: Sort headers.
9280 * bfin-linux-tdep.c: Sort headers.
9281 * bfd-target.c: Sort headers.
9282 * bcache.c: Sort headers.
9283 * ax-general.c: Sort headers.
9284 * ax-gdb.h: Sort headers.
9285 * ax-gdb.c: Sort headers.
9286 * avr-tdep.c: Sort headers.
9287 * auxv.c: Sort headers.
9288 * auto-load.c: Sort headers.
9289 * arm-wince-tdep.c: Sort headers.
9290 * arm-tdep.c: Sort headers.
9291 * arm-symbian-tdep.c: Sort headers.
9292 * arm-pikeos-tdep.c: Sort headers.
9293 * arm-obsd-tdep.c: Sort headers.
9294 * arm-nbsd-tdep.c: Sort headers.
9295 * arm-nbsd-nat.c: Sort headers.
9296 * arm-linux-tdep.c: Sort headers.
9297 * arm-linux-nat.c: Sort headers.
9298 * arm-fbsd-tdep.c: Sort headers.
9299 * arm-fbsd-nat.c: Sort headers.
9300 * arm-bsd-tdep.c: Sort headers.
9301 * arch-utils.c: Sort headers.
9302 * arc-tdep.c: Sort headers.
9303 * arc-newlib-tdep.c: Sort headers.
9304 * annotate.h: Sort headers.
9305 * annotate.c: Sort headers.
9306 * amd64-windows-tdep.c: Sort headers.
9307 * amd64-windows-nat.c: Sort headers.
9308 * amd64-tdep.c: Sort headers.
9309 * amd64-sol2-tdep.c: Sort headers.
9310 * amd64-obsd-tdep.c: Sort headers.
9311 * amd64-obsd-nat.c: Sort headers.
9312 * amd64-nbsd-tdep.c: Sort headers.
9313 * amd64-nbsd-nat.c: Sort headers.
9314 * amd64-nat.c: Sort headers.
9315 * amd64-linux-tdep.c: Sort headers.
9316 * amd64-linux-nat.c: Sort headers.
9317 * amd64-fbsd-tdep.c: Sort headers.
9318 * amd64-fbsd-nat.c: Sort headers.
9319 * amd64-dicos-tdep.c: Sort headers.
9320 * amd64-darwin-tdep.c: Sort headers.
9321 * amd64-bsd-nat.c: Sort headers.
9322 * alpha-tdep.c: Sort headers.
9323 * alpha-obsd-tdep.c: Sort headers.
9324 * alpha-nbsd-tdep.c: Sort headers.
9325 * alpha-mdebug-tdep.c: Sort headers.
9326 * alpha-linux-tdep.c: Sort headers.
9327 * alpha-linux-nat.c: Sort headers.
9328 * alpha-bsd-tdep.c: Sort headers.
9329 * alpha-bsd-nat.c: Sort headers.
9330 * aix-thread.c: Sort headers.
9331 * agent.c: Sort headers.
9332 * addrmap.c: Sort headers.
9333 * ada-varobj.c: Sort headers.
9334 * ada-valprint.c: Sort headers.
9335 * ada-typeprint.c: Sort headers.
9336 * ada-tasks.c: Sort headers.
9337 * ada-lang.c: Sort headers.
9338 * aarch64-tdep.c: Sort headers.
9339 * aarch64-ravenscar-thread.c: Sort headers.
9340 * aarch64-newlib-tdep.c: Sort headers.
9341 * aarch64-linux-tdep.c: Sort headers.
9342 * aarch64-linux-nat.c: Sort headers.
9343 * aarch64-fbsd-tdep.c: Sort headers.
9344 * aarch64-fbsd-nat.c: Sort headers.
9345 * aarch32-linux-nat.c: Sort headers.
9346
699bd4cf
TT
93472019-04-04 Tom Tromey <tom@tromey.com>
9348
9349 * varobj.c (varobj_create): Update.
9350 * rust-exp.y (struct rust_parser) <update_innermost_block,
9351 lookup_symbol>: New methods.
9352 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9353 Rename.
9354 (rust_parser::rust_lookup_type)
9355 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9356 * printcmd.c (display_command, do_one_display): Update.
9357 * parser-defs.h (struct parser_state) <parser_state>: Add
9358 "tracker" parameter.
9359 (block_tracker): New member.
9360 (class innermost_block_tracker) <innermost_block_tracker>: Add
9361 "types" parameter.
9362 <reset>: Remove method.
9363 (innermost_block): Don't declare.
9364 (null_post_parser): Update.
9365 * parse.c (innermost_block): Remove global.
9366 (write_dollar_variable): Update.
9367 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9368 Remove "tracker_types" parameter.
9369 (parse_expression): Add "tracker" parameter.
9370 (parse_expression_for_completion): Update.
9371 (null_post_parser): Add "tracker" parameter.
9372 * p-exp.y: Update rules.
9373 * m2-exp.y: Update rules.
9374 * language.h (struct language_defn) <la_post_parser>: Add
9375 "tracker" parameter.
9376 * go-exp.y: Update rules.
9377 * f-exp.y: Update rules.
9378 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9379 parameter.
9380 * d-exp.y: Update rules.
9381 * c-exp.y: Update rules.
9382 * breakpoint.c (set_breakpoint_condition): Create an
9383 innermost_block_tracker.
9384 (watch_command_1): Likewise.
9385 * ada-lang.c (resolve): Add "tracker" parameter.
9386 (resolve_subexp): Likewise.
9387 * ada-exp.y (write_var_from_sym): Update.
9388
dac43e32
TT
93892019-04-04 Tom Tromey <tom@tromey.com>
9390
9391 * type-stack.h: New file.
9392 * type-stack.c: New file.
9393 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9394 type-stack.h.
9395 (insert_into_type_stack, insert_type, push_type, push_type_int)
9396 (insert_type_address_space, pop_type, pop_type_int)
9397 (pop_typelist, pop_type_stack, append_type_stack)
9398 (push_type_stack, get_type_stack, push_typelist)
9399 (follow_type_instance_flags, follow_types): Don't declare.
9400 * parse.c (type_stack): Remove global.
9401 (parse_exp_in_context): Update.
9402 (insert_into_type_stack, insert_type, push_type, push_type_int)
9403 (insert_type_address_space, pop_type, pop_type_int)
9404 (pop_typelist, pop_type_stack, append_type_stack)
9405 (push_type_stack, get_type_stack, push_typelist)
9406 (follow_type_instance_flags, follow_types): Remove (moved to
9407 type-stack.c).
9408 * f-exp.y (type_stack): New global.
9409 Update rules.
9410 (push_kind_type, f_parse): Update.
9411 * d-exp.y (type_stack): New global.
9412 Update rules.
9413 (d_parse): Update.
9414 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9415 Update rules.
9416 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9417 (HFILES_NO_SRCDIR): Add type-stack.h.
9418
2a612529
TT
94192019-04-04 Tom Tromey <tom@tromey.com>
9420
9421 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9422 (rust_parser::convert_ast_to_expression, rust_parse)
9423 (rust_lex_test_completion, rust_lex_tests): Update.
9424 * parser-defs.h (struct expr_completion_state): New.
9425 (struct parser_state) <parser_state>: Add completion parameter.
9426 <mark_struct_expression, mark_completion_tag>: New methods.
9427 <parse_completion, m_completion_state>: New members.
9428 (prefixify_expression, null_post_parser): Update.
9429 (mark_struct_expression, mark_completion_tag): Don't declare.
9430 * parse.c (parse_completion, expout_last_struct)
9431 (expout_tag_completion_type, expout_completion_name): Remove
9432 globals.
9433 (parser_state::mark_struct_expression)
9434 (parser_state::mark_completion_tag): Now methods.
9435 (prefixify_expression): Add last_struct parameter.
9436 (prefixify_subexp): Likewise.
9437 (parse_exp_1): Update.
9438 (parse_exp_in_context): Add cstate parameter. Update.
9439 (parse_expression_for_completion): Create an
9440 expr_completion_state.
9441 (null_post_parser): Add "completion" parameter.
9442 * p-exp.y: Update rules.
9443 (yylex): Update.
9444 * language.h (struct language_defn) <la_post_parser>: Add
9445 "completing" parameter.
9446 * go-exp.y: Update rules.
9447 (lex_one_token): Update.
9448 * expression.h (parse_completion): Don't declare.
9449 * d-exp.y: Update rules.
9450 (lex_one_token): Update rules.
9451 * c-exp.y: Update rules.
9452 (lex_one_token): Update.
9453 * ada-lang.c (resolve): Add "parse_completion" parameter.
9454 (resolve_subexp): Likewise.
9455 (ada_resolve_function): Likewise.
9456
43476f0b
TT
94572019-04-04 Tom Tromey <tom@tromey.com>
9458
9459 * parser-defs.h (struct parser_state) <start_arglist,
9460 end_arglist>: New methods.
9461 <arglist_len, m_funcall_chain>: New members.
9462 (arglist_len, start_arglist, end_arglist): Don't declare.
9463 * parse.c (arglist_len, funcall_chain): Remove global.
9464 (start_arglist, end_arglist): Remove functions.
9465 (parse_exp_in_context): Update.
9466 * p-exp.y: Update rules.
9467 * m2-exp.y: Update rules.
9468 * go-exp.y: Update rules.
9469 * f-exp.y: Update rules.
9470 * d-exp.y: Update rules.
9471 * c-exp.y: Update rules.
9472
5776fca3
TT
94732019-04-04 Tom Tromey <tom@tromey.com>
9474
9475 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9476 lex_operator, push_back>: New methods.
9477 Update all rules.
9478 (rust_parser::lex_hex, lex_escape): Rename and update.
9479 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9480 (rust_parser::lex_operator): Rename and update.
9481 (rust_parser::lex_number, rustyylex, rustyyerror)
9482 (rust_lex_test_init, rust_lex_test_sequence)
9483 (rust_lex_test_push_back, rust_lex_tests): Update.
9484 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9485 parameter.
9486 <lexptr, prev_lexptr>: New members.
9487 (lexptr, prev_lexptr): Don't declare.
9488 * parse.c (lexptr, prev_lexptr): Remove globals.
9489 (parse_exp_in_context): Update.
9490 * p-exp.y (yylex, yyerror): Update.
9491 * m2-exp.y (parse_number, yylex, yyerror): Update.
9492 * go-exp.y (lex_one_token, yyerror): Update.
9493 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9494 * d-exp.y (lex_one_token, yyerror): Update.
9495 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9496 (lex_one_token, yyerror): Update.
9497 * ada-lex.l (YY_INPUT): Update.
9498 (rewind_to_char): Update.
9499 * ada-exp.y (yyerror): Update.
9500
8621b685
TT
95012019-04-04 Tom Tromey <tom@tromey.com>
9502
9503 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9504 * parser-defs.h (struct parser_state) <parser_state>: Add new
9505 parameter.
9506 <comma_terminates>: New member.
9507 (comma_terminates): Don't declare global.
9508 * parse.c (comma_terminates): Remove global.
9509 (parse_exp_in_context): Update.
9510 * p-exp.y (yylex): Update.
9511 * m2-exp.y (yylex): Update.
9512 * go-exp.y (lex_one_token): Update.
9513 * f-exp.y (yylex): Update.
9514 * d-exp.y (lex_one_token): Update.
9515 * c-exp.y (lex_one_token): Update.
9516 * ada-lex.l: Update.
9517
28aaf3fd
TT
95182019-04-04 Tom Tromey <tom@tromey.com>
9519
9520 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9521 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9522 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9523 * parser-defs.h (paren_depth): Don't declare.
9524 * parse.c (paren_depth): Remove global.
9525 (parse_exp_in_context): Update.
9526 * p-exp.y (paren_depth): New global.
9527 (pascal_parse): Initialize it.
9528 * m2-exp.y (paren_depth): New global.
9529 (m2_parse): Initialize it.
9530 * go-exp.y (paren_depth): New global.
9531 (go_parse): Initialize it.
9532 * f-exp.y (paren_depth): New global.
9533 (f_parse): Initialize it.
9534 * d-exp.y (paren_depth): New global.
9535 (d_parse): Initialize it.
9536 * c-exp.y (paren_depth): New global.
9537 (c_parse): Initialize it.
9538 * ada-lex.l (paren_depth): New global.
9539 (lexer_init): Initialize it.
9540
1e58a4a4
TT
95412019-04-04 Tom Tromey <tom@tromey.com>
9542
9543 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9544 (rust_parser::convert_ast_to_type)
9545 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9546 * parser-defs.h (struct parser_state) <parser_state>: Add
9547 parameters. Initialize new members.
9548 <expression_context_block, expression_context_pc>: New members.
9549 * parse.c (expression_context_block, expression_context_pc):
9550 Remove globals.
9551 (parse_exp_in_context): Update.
9552 * p-exp.y: Update all rules.
9553 (yylex): Update.
9554 * m2-exp.y: Update all rules.
9555 (yylex): Update.
9556 * go-exp.y (yylex): Update.
9557 * f-exp.y (yylex): Update.
9558 * d-exp.y: Update all rules.
9559 (yylex): Update.
9560 * c-exp.y: Update all rules.
9561 (lex_one_token, classify_name, yylex, c_parse): Update.
9562 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9563
37eedb39
TT
95642019-04-04 Tom Tromey <tom@tromey.com>
9565
9566 * gdbarch.h, gdbarch.c: Rebuild.
9567 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9568 * stap-probe.h:
9569 (struct stap_parse_info): Replace "parser_state" with
9570 "expr_builder".
9571 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9572 (parser_state): New class.
9573 * parse.c (expr_builder): Rename.
9574 (expr_builder::release): Rename.
9575 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9576 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9577 (write_exp_elt_longcst, write_exp_elt_floatcst)
9578 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9579 (write_exp_string_vector, write_exp_bitstring)
9580 (write_exp_msymbol, mark_struct_expression)
9581 (write_dollar_variable)
9582 (insert_type_address_space, increase_expout_size): Replace
9583 "parser_state" with "expr_builder".
9584 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9585 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9586 "parser_state" with "expr_builder".
9587
73923d7e
TT
95882019-04-04 Tom Tromey <tom@tromey.com>
9589
9590 * rust-exp.y: Replace "parse_language" with method call.
9591 * p-exp.y:
9592 (yylex): Replace "parse_language" with method call.
9593 * m2-exp.y:
9594 (yylex): Replace "parse_language" with method call.
9595 * go-exp.y (classify_name): Replace "parse_language" with method
9596 call.
9597 * f-exp.y (yylex): Replace "parse_language" with method call.
9598 * d-exp.y (lex_one_token): Replace "parse_language" with method
9599 call.
9600 * c-exp.y:
9601 (lex_one_token, classify_name, yylex): Replace "parse_language"
9602 with method call.
9603 * ada-exp.y (find_primitive_type, type_char)
9604 (type_system_address): Replace "parse_language" with method call.
9605
fa9f5be6
TT
96062019-04-04 Tom Tromey <tom@tromey.com>
9607
9608 * rust-exp.y: Replace "parse_gdbarch" with method call.
9609 * parse.c (write_dollar_variable, insert_type_address_space):
9610 Replace "parse_gdbarch" with method call.
9611 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9612 call.
9613 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9614 call.
9615 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9616 "parse_gdbarch" with method call.
9617 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9618 with method call.
9619 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9620 "parse_gdbarch" with method call.
9621 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9622 "parse_gdbarch" with method call.
9623 * c-exp.y (parse_type, parse_number, classify_name): Replace
9624 "parse_gdbarch" with method call.
9625 * ada-lex.l: Replace "parse_gdbarch" with method call.
9626 * ada-exp.y (parse_type, find_primitive_type, type_char)
9627 (type_system_address): Replace "parse_gdbarch" with method call.
9628
1201a264
TT
96292019-04-04 Tom Tromey <tom@tromey.com>
9630
9631 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9632 * stap-probe.c (stap_parse_argument): Update.
9633 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9634 initial_size parameter.
9635 * rust-exp.y (rust_lex_tests): Update.
9636 * parse.c (parser_state): Update.
9637 (parse_exp_in_context): Update.
9638 * parser-defs.h (struct parser_state) <parser_state>: Remove
9639 "initial_size" parameter.
9640
e3980ce2
TT
96412019-04-04 Tom Tromey <tom@tromey.com>
9642
9643 * parser-defs.h (increase_expout_size): Don't declare.
9644 * parse.c (increase_expout_size): Now static.
9645
e9f8e3f1
TS
96462019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9647
9648 * gnu-nat.c (gnu_nat_target::wait): Fix
9649 target_waitstatus_to_string call.
9650
d7df6549
AB
96512019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9652
9653 * eval.c (evaluate_subexp_standard): Handle internal functions
9654 during Fortran function call handling.
9655
8bdc1658
AB
96562019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9657
9658 * NEWS: Mention new internal functions.
9659 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9660 (read_base_type): Use dwarf2_init_complex_target_type.
9661 * value.c (creal_internal_fn): New function.
9662 (cimag_internal_fn): New function.
9663 (_initialize_values): Register new internal functions.
9664
c29705b7
PW
96652019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9666
9667 * infrun.c (stop_all_threads): If debug_infrun, always
9668 trace the wait status after wait_one, using
9669 target_waitstatus_to_string and target_pid_to_str.
9670 (handle_inferior_event): Replace various trace of
9671 wait status kind by a single trace.
9672 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9673 wait status kind image by target_waitstatus_to_string.
9674 * target/waitstatus.c (target_waitstatus_to_string): Fix
9675 obsolete comment.
9676
05caa1d2
TT
96772019-04-01 Tom Tromey <tromey@adacore.com>
9678
9679 PR symtab/23331:
9680 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9681
9d1447e0
SDJ
96822019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9683 Pedro Alves <palves@redhat.com>
9684
9685 * top.c (quit_force): Call 'finalize_values'.
9686 * value.c (finalize_values): New function.
9687 * value.h (finalize_values): Declare.
9688
7734102d
EZ
96892019-03-30 Eli Zaretskii <eliz@gnu.org>
9690
9691 * NEWS: Announce $_gdb_major and $_gdb_minor.
9692
9693 * top.c (init_gdb_version_vars): New function.
9694 (gdb_init): Call init_gdb_version_vars.
9695
188e1fa9
TT
96962019-03-29 Tom Tromey <tromey@adacore.com>
9697
9698 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9699 help text. Remove dead code.
9700
2880242d
KS
97012019-03-29 Keith Seitz <keiths@redhat.com>
9702
9703 From Siddhesh Poyarekar:
9704 * f-lang.h (f77_get_upperbound): Return LONGEST.
9705 (f77_get_lowerbound): Likewise.
9706 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9707 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9708 print them.
9709 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9710 plongest to format print it.
9711 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9712 (f77_get_upperbound): Likewise.
9713 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9714 LOWER_BOUND to LONGEST.
9715 (f77_create_arrayprint_offset_tbl): Likewise.
9716
cc1defb1
KS
97172019-03-29 Keith Seitz <keiths@redhat.com>
9718
9719 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9720 %s/pulongest for TYPE_LENGTH instead of %d in format
9721 strings.
9722 * ada-typerint.c (ada_print_type): Likewise.
9723 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9724 * compile/compile-c-support.c (generate_register_struct): Likewise.
9725 * gdbtypes.c (recursive_dump_type): Likewise.
9726 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9727 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9728 instead of %d in format strings.
9729 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9730 to std::min to ULONGEST.
9731 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9732 instead of %d in format strings.
9733 * tracepoint.c (info_scope_command): Likewise.
9734 * typeprint.c (print_offset_data::update)
9735 (print_offset_data::finish): Likewise.
9736 * xtensa-tdep.c (xtensa_store_return_value)
9737 (xtensa_push_dummy_call): Likewise.
9738
e432ccf1
JT
97392019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9740
9741 * windows-nat.c (display_selector): Fixed format specifications
9742 for 64-bit Cygwin.
9743
65d2b333
PW
97442019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9745
9746 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9747
f489207e
SL
97482019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9749
9750 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9751 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9752 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9753 (nios2_linux_init_abi): Install it.
9754
bffa1015
AH
97552019-03-28 Alan Hayward <alan.hayward@arm.com>
9756
9757 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9758
fc96163a
AH
97592019-03-28 Alan Hayward <alan.hayward@arm.com>
9760
9761 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9762
20dc7e9b
PW
97632019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9764 Tom Tromey <tromey@adacore.com>
9765
9766 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9767
7f5331a8
JB
97682019-03-26 Joel Brobecker <brobecker@adacore.com>
9769
9770 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9771 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9772 method to compute the bounds of range types. Also print "[evaluated]"
9773 if the bounds' values come from a dynamic evaluation.
9774
18c77628
AB
97752019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9776
9777 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9778 whitespace when pretty printing is on.
9779
53c973f2
AH
97802019-03-26 Alan Hayward <alan.hayward@arm.com>
9781
e79be6e5 9782 * ppc-linux-nat.c: Add include.
53c973f2 9783
d851aa71
AH
97842019-03-26 Alan Hayward <alan.hayward@arm.com>
9785
e79be6e5 9786 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9787
2fe7bab7
AH
97882019-03-26 Alan Hayward <alan.hayward@arm.com>
9789
e79be6e5 9790 * arm-linux-nat.c: Add include.
2fe7bab7 9791
068ef30e
SM
97922019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9793
9794 * source-cache.c (source_cache::get_source_lines): Re-read
9795 fullname after calling open_source_file.
9796
81a24d04
JB
97972019-03-25 John Baldwin <jhb@FreeBSD.org>
9798
9799 * NEWS: Mention TLS support for FreeBSD.
9800
79e7ae11
TT
98012019-03-25 Tom Tromey <tromey@adacore.com>
9802
9803 * minsyms.c (BUNCH_SIZE): Update comment.
9804 (~minimal_symbol_reader): Remove old comment.
9805 (compact_minimal_symbols): Update comment.
9806 (minimal_symbol_reader::install): Remove old comment. Update
9807 other comments.
9808
d45963c2
AH
98092019-03-25 Alan Hayward <alan.hayward@arm.com>
9810
9811 * s390-linux-nat.c: Add include.
9812
0f83012e
AH
98132019-03-25 Alan Hayward <alan.hayward@arm.com>
9814
9815 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9816 Call linux_get_hwcap.
9817 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9818 Likewise.
9819 (aarch64_linux_get_hwcap): Remove function.
9820 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9821 declaration.
9822 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9823 linux_get_hwcap.
9824 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9825 * linux-tdep.c (linux_get_hwcap): Add function.
9826 (linux_get_hwcap2): Likewise.
9827 * linux-tdep.h (linux_get_hwcap): Add declaration.
9828 (linux_get_hwcap2): Likewise.
9829 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9830 (ppc_linux_get_hwcap2): Likewise.
9831 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9832 linux_get_hwcap.
9833 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9834 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9835 (ppc_linux_nat_target::read_description): Likewise.
9836 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9837 * s390-linux-nat.c: Likewise.
9838 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9839
6640a367
TT
98402019-03-24 Tom Tromey <tom@tromey.com>
9841
9842 * ada-lang.c (standard_lookup): Simplify initialization.
9843 (ada_lookup_symbol_nonlocal): Simplify return.
9844 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9845 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9846 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9847 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9848 initialization.
9849 * solib.c (solib_global_lookup): Simplify.
9850 * symtab.c (null_block_symbol): Remove.
9851 (symbol_cache_lookup): Simplify returns.
9852 (lookup_language_this): Simplify returns.
9853 (lookup_symbol_aux): Simplify return.
9854 (lookup_local_symbol): Simplify returns.
9855 (lookup_global_symbol_from_objfile): Simplify return.
9856 (lookup_symbol_in_objfile_symtabs)
9857 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9858 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9859 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9860 * cp-namespace.c (cp_lookup_bare_symbol)
9861 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9862 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9863 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9864 (cp_lookup_symbol_via_imports): Simplify initialization.
9865 (find_symbol_in_baseclass): Likewise.
9866 * symtab.h (null_block_symbol): Remove.
9867 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9868 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9869 (d_lookup_symbol_module): Likewise.
9870 (find_symbol_in_baseclass): Simplify initialization.
9871
a930ebcd
TT
98722019-03-24 Tom Tromey <tom@tromey.com>
9873
9874 * expression.h: Don't include symtab.h.
9875 (struct block): Forward declare.
9876
582942f4
TT
98772019-03-24 Tom Tromey <tom@tromey.com>
9878
9879 * c-exp.y (typebase): Remove casts.
9880 * gdbtypes.c (lookup_unsigned_typename, )
9881 (lookup_signed_typename): Remove cast.
9882 * eval.c (parse_to_comma_and_eval): Remove cast.
9883 * parse.c (write_dollar_variable): Remove cast.
9884 * block.h (struct block) <superblock>: Now const.
9885 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9886 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9887 (map_block): Make "block" const.
9888 * symfile.h (struct quick_symbol_functions)
9889 <map_matching_symbols>: Constify block argument to "callback".
9890 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9891 const.
9892 (find_pc_sect_compunit_symtab): Make "b" const.
9893 (find_symbol_at_address): Likewise.
9894 (search_symbols): Likewise.
9895 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9896 (dw2_debug_names_lookup_symbol): Likewise.
9897 (dw2_map_matching_symbols): Update.
9898 * p-valprint.c (pascal_val_print): Remove "block".
9899 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9900 (aux_add_nonlocal_symbols): Make "block" const.
9901 (resolve_subexp): Remove cast.
9902 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9903 const.
9904 (iterate_over_file_blocks): Likewise.
9905 * f-exp.y (%union) <bval>: Remove.
9906 * coffread.c (patch_opaque_types): Make "b" const.
9907 * spu-tdep.c (spu_catch_start): Make "block" const.
9908 * c-valprint.c (print_unpacked_pointer): Remove "block".
9909 * symmisc.c (dump_symtab_1): Make "b" const.
9910 (block_depth): Make "block" const.
9911 * d-exp.y (%union) <bval>: Remove.
9912 * cp-support.h (cp_lookup_rtti_type): Update.
9913 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9914 * psymtab.c (psym_lookup_symbol): Make "block" const.
9915 (maintenance_check_psymtabs): Make "b" const.
9916 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9917 (enumerate_locals, enumerate_args): Update.
9918 * python/py-symtab.c (stpy_global_block): Make "block" const.
9919 (stpy_static_block): Likewise.
9920 * inline-frame.c (block_starting_point_at): Make "new_block"
9921 const.
9922 * block.c (find_block_in_blockvector): Make return type const.
9923 (blockvector_for_pc_sect): Make "b" const.
9924 (find_block_in_blockvector): Make "b" const.
9925
7ad417dd
TT
99262019-03-23 Tom Tromey <tom@tromey.com>
9927
9928 * varobj.c (varobj_create): Update.
9929 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9930 * printcmd.c (display_command, do_one_display): Don't reset
9931 innermost_block.
9932 * parser-defs.h (enum innermost_block_tracker_type): Move to
9933 expression.h.
9934 (innermost_block): Update comment.
9935 * parse.c (parse_exp_1): Add tracker_types parameter.
9936 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9937 tracker_types parameter. Reset innermost_block.
9938 (parse_exp_in_context): Remove.
9939 (parse_expression_for_completion): Update.
9940 * objfiles.c (~objfile): Don't reset expression_context_block or
9941 innermost_block.
9942 * expression.h (enum innermost_block_tracker_type): Move from
9943 parser-defs.h.
9944 (parse_exp_1): Add tracker_types parameter.
9945 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9946 reset innermost_block.
9947
b366c208
TT
99482019-03-23 Tom Tromey <tom@tromey.com>
9949
9950 * objfiles.h: Include bcache.h.
9951
9bb9b2f9
TT
99522019-03-23 Tom Tromey <tom@tromey.com>
9953
9954 * linespec.c (get_current_search_block): Use
9955 scoped_restore_current_language.
9956 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9957
59c28372
AH
99582019-03-22 Alan Hayward <alan.hayward@arm.com>
9959 Jiong Wang <jiong.wang@arm.com>
9960
9961 * aarch64-linux-tdep.c
9962 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9963 section.
9964 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9965
17e116a7
AH
99662019-03-22 Alan Hayward <alan.hayward@arm.com>
9967 Jiong Wang <jiong.wang@arm.com>
9968
9969 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9970 instructions.
9971 (aarch64_analyze_prologue_test): Add PACIASP test.
9972 (aarch64_prologue_prev_register): Unmask PC value.
9973
11e1b75f
AH
99742019-03-22 Alan Hayward <alan.hayward@arm.com>
9975 Jiong Wang <jiong.wang@arm.com>
9976
9977 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9978 (aarch64_dwarf2_prev_register): Unmask PC value.
9979 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9980 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9981 DW_CFA_AARCH64_negate_ra_state.
9982 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9983
34dcc7cf
AH
99842019-03-22 Alan Hayward <alan.hayward@arm.com>
9985 Jiong Wang <jiong.wang@arm.com>
9986
9987 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9988 registers.
9989 (aarch64_pseudo_register_name): Likewise.
9990 (aarch64_pseudo_register_type): Likewise.
9991 (aarch64_pseudo_register_reggroup_p): Likewise.
9992 (aarch64_gdbarch_init): Add pauth registers.
9993 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9994 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9995 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9996 (struct gdbarch_tdep): Add regnum for ra_state.
9997
1ef53e6b
AH
99982019-03-22 Alan Hayward <alan.hayward@arm.com>
9999 Jiong Wang <jiong.wang@arm.com>
10000
10001 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10002
76bed0fd
AH
100032019-03-22 Alan Hayward <alan.hayward@arm.com>
10004 Jiong Wang <jiong.wang@arm.com>
10005
10006 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10007 function.
10008 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10009 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10010 (aarch64_gdbarch_init): Add puth registers.
10011 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10012 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10013 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10014
ee4fbcfa
AH
100152019-03-22 Alan Hayward <alan.hayward@arm.com>
10016 Jiong Wang <jiong.wang@arm.com>
10017
10018 * aarch64-linux-nat.c
10019 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10020 * aarch64-linux-tdep.c
10021 (aarch64_linux_core_read_description): Likewise.
10022 (aarch64_linux_get_hwcap): New function.
10023 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10024 (aarch64_linux_get_hwcap): New declaration.
10025
6dc0ebde
AH
100262019-03-22 Alan Hayward <alan.hayward@arm.com>
10027 Jiong Wang <jiong.wang@arm.com>
10028
10029 * aarch64-linux-nat.c
10030 (aarch64_linux_nat_target::read_description): Add pauth param.
10031 * aarch64-linux-tdep.c
10032 (aarch64_linux_core_read_description): Likewise.
10033 * aarch64-tdep.c (struct target_desc): Add in pauth.
10034 (aarch64_read_description): Add pauth param.
10035 (aarch64_gdbarch_init): Likewise.
10036 * aarch64-tdep.h (aarch64_read_description): Likewise.
10037 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10038 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10039 * features/Makefile: Add new files.
10040 * features/aarch64-pauth.c: New file.
10041 * features/aarch64-pauth.xml: New file.
10042
595915c1
TT
100432019-03-20 Tom Tromey <tromey@adacore.com>
10044
10045 * infrun.c (handle_inferior_event): Rename from
10046 handle_inferior_event_1. Create a scoped_value_mark.
10047 (handle_inferior_event): Remove.
10048
4c7d57e7
TT
100492019-03-19 Tom Tromey <tromey@adacore.com>
10050
10051 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10052 * infrun.h (print_stop_event): Add "displays" parameter.
10053 * infrun.c (print_stop_event): Add "displays" parameter.
10054
cb246234
PA
100552019-03-19 Pedro Alves <palves@redhat.com>
10056
10057 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10058 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10059 to -1. Fix TABs vs spaces.
10060 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10061 * tui/tui-out.h (tui_ui_out) Add intro comments.
10062 <m_line, m_start_of_line>: In-class initialize, and add describing
10063 comment.
10064
3a0e45b2
AH
100652019-03-18 Alan Hayward <alan.hayward@arm.com>
10066
10067 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10068 variable names.
10069 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10070
5371b850
PA
100712019-03-18 Pedro Alves <palves@redhat.com>
10072 Eli Zaretskii <eliz@gnu.org>
10073
10074 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10075 m_line and m_start_of_line.
10076
b17c4cd0
EZ
100772019-03-18 Eli Zaretskii <eliz@gnu.org>
10078
10079 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10080 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10081 it returns a newline. This fixes a regression in TU mode, whereby
10082 the next line is output on the same screen line as the user input.
10083
4bd56d18
TT
100842019-03-18 Tom Tromey <tromey@adacore.com>
10085
10086 * minsyms.c (minimal_symbol_reader::install): Remove call to
10087 obstack_blank.
10088
55c10aca
PA
100892019-03-18 Pedro Alves <palves@redhat.com>
10090
10091 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10092 New globals.
10093 (apply_style): New, factored out from ...
10094 (apply_ansi_escape): ... this. Handle reverse video mode.
10095 (tui_set_reverse_mode): New function.
10096 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10097 * tui/tui-winsource.c (tui_show_source_line): Use
10098 tui_set_reverse_mode instead of setting A_STANDOUT.
10099 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10100 New setter methods.
10101
647bb750
HD
101022019-03-18 Hannes Domani <ssbssa@yahoo.de>
10103
10104 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10105 Handle tabs.
10106
bff8c71f
TT
101072019-03-18 Tom Tromey <tromey@adacore.com>
10108
10109 * ada-lang.c (empty_array): Add "high" parameter.
10110 (ada_evaluate_subexp): Update.
10111
58785d98
ST
101122019-03-17 Sergei Trofimovich <siarheit@google.com>
10113
10114 * unittests/string_view-selftests.c: Define
10115 _initialize_string_view_selftests unconditionally.
10116
d4cbef22
ВМ
101172019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10118
10119 PR gdb/24350
10120 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10121
fce4c071
ВМ
101222019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10123
10124 PR gdb/24351
10125 * windows-nat.c (display_selector): Fix format specifiers.
10126
f7f0a123
EZ
101272019-03-17 Eli Zaretskii <eliz@gnu.org>
10128
10129 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10130 tui_refill_source_window instead of tui_refresh_win, to update the
10131 current execution line. This fixes redisplay of the current line
10132 when stepping through the code with "next" or "step".
10133
ab42892f
EZ
101342019-03-16 Eli Zaretskii <eliz@gnu.org>
10135
10136 * source-cache.c (source_cache::get_source_lines): Call
10137 find_source_lines to initialize s->nlines. This fixes vertical
10138 scrolling of TUI source window when the DOWN arrow is pressed.
10139
8d8c087f
PW
101402019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10141
10142 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10143 linux-thread-db.c (_initialize_thread_db): Likewise.
10144
798e1c30
EZ
101452019-03-16 Eli Zaretskii <eliz@gnu.org>
10146
10147 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10148 wclrtoeol in tui_show_source_line". This reverts changes made in
10149 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10150
eefba3da
TT
101512019-03-15 Tom Tromey <tom@tromey.com>
10152
10153 * symtab.h (struct minimal_symbol): Derive from
10154 general_symbol_info.
10155 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10156 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10157 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10158 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10159 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10160 (MSYMBOL_SEARCH_NAME): Update.
10161 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10162 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10163 * minsyms.c (minimal_symbol_reader::record_full): Update.
10164
0de2420c
TT
101652019-03-15 Tom Tromey <tom@tromey.com>
10166
10167 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10168
042d75e4
TT
101692019-03-15 Tom Tromey <tom@tromey.com>
10170
10171 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10172 unique_xmalloc_ptr.
10173 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10174 Update.
10175 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10176 (build_minimal_symbol_hash_tables)
10177 (minimal_symbol_reader::install): Update.
10178
db92718b
TT
101792019-03-15 Tom Tromey <tom@tromey.com>
10180
10181 * symtab.c (create_demangled_names_hash): Update.
10182 (symbol_set_names): Update.
10183 * objfiles.h (struct objfile_per_bfd_storage)
10184 <demangled_names_hash>: Now an htab_up.
10185 * objfiles.c (objfile_per_bfd_storage): Simplify.
10186
d6797f46
TT
101872019-03-15 Tom Tromey <tom@tromey.com>
10188
10189 * objfiles.h (struct objfile_per_bfd_storage): Declare
10190 destructor.
10191 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10192 New.
10193 (get_objfile_bfd_data): Use new. Don't initialize
10194 language_of_main.
10195 (free_objfile_per_bfd_storage): Remove.
10196 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10197
741d7538
TT
101982019-03-15 Tom Tromey <tom@tromey.com>
10199
10200 * symfile.c (reread_symbols): Update.
10201 * objfiles.c (objfile::objfile): Update.
10202 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10203 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10204 comment.
10205 (minimal_symbol_reader::install): Update.
10206 (terminate_minimal_symbol_table): Remove.
10207 * jit.c (jit_object_close_impl): Update.
10208
788c80d1
TT
102092019-03-15 Tom Tromey <tom@tromey.com>
10210
10211 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10212 initializations.
10213
1b7a07cb
TT
102142019-03-15 Tom Tromey <tom@tromey.com>
10215
10216 * objfiles.h (struct objfile_per_bfd_storage)
10217 <demangled_hash_languages>: Now a bitset.
10218 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10219 (lookup_minimal_symbol): Update.
10220
3db066bc
TT
102212019-03-15 Tom Tromey <tom@tromey.com>
10222
10223 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10224 Don't return the symbol.
10225 * coffread.c (record_minimal_symbol): Use record_full.
10226
3fff2c37
EZ
102272019-03-14 Eli Zaretskii <eliz@gnu.org>
10228
10229 The MS-Windows port of ncurses fails to switch to a color pair if
10230 one or both of the colors are the implicit default colors. This
10231 change records the default colors when TUI is initialized, and
10232 then specifies them explicitly when a color pair uses the default
10233 colors. This allows color styling in TUI mode on MS-Windows.
10234
10235 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10236 ncurses_norm_attr.
10237 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10238 colors in ncurses_norm_attr.
10239 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10240 "none", replace it with the default color recorded in
10241 ncurses_norm_attr.
10242
3b336828
TT
102432019-03-14 Tom Tromey <tromey@adacore.com>
10244
10245 * source-cache.h (class source_cache) <get_source_lines>: Return
10246 std::string.
10247 * source-cache.c (source_cache::extract_lines): Handle case where
10248 first_pos==npos. Return std::string.
10249 (source_cache::get_source_lines): Update.
10250
d085f989
TT
102512019-03-14 Tom Tromey <tromey@adacore.com>
10252
10253 * NEWS: Add item for "style sources" commands.
10254 * source-cache.c (source_cache::get_source_lines): Check
10255 source_styling.
10256 * cli/cli-style.c (source_styling): New global.
10257 (_initialize_cli_style): Add "style sources" commands.
10258 (show_style_sources): New function.
10259 * cli/cli-style.h (source_styling): Declare.
10260
6f11e682
TT
102612019-03-14 Pedro Alves <palves@redhat.com>
10262 Tom Tromey <tromey@adacore.com>
10263
10264 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10265 * tui/tui-winsource.c (tui_refill_source_window): New function,
10266 from...
10267 (tui_horizontal_source_scroll): ... here. Move some logic.
10268 * cli/cli-style.c (set_style_enabled): Notify new observable.
10269 * tui/tui-hooks.c (tui_redisplay_source): New function.
10270 (tui_attach_detach_observers): Attach or detach
10271 tui_redisplay_source.
10272 * observable.h (source_styling_changed): New observable.
10273 * observable.c: Define source_styling_changed observable.
10274
a068643d
TT
102752019-03-13 Tom Tromey <tromey@adacore.com>
10276
10277 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10278 (i386_gnu_nat_target::store_registers): Update.
10279 * target-debug.h (target_debug_print_std_string): New macro.
10280 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10281 * windows-tdep.c (display_one_tib): Update.
10282 * tui/tui-stack.c (tui_make_status_line): Update.
10283 * top.c (print_inferior_quit_action): Update.
10284 * thread.c (thr_try_catch_cmd): Update.
10285 (add_thread_with_info): Update.
10286 (thread_target_id_str): Update.
10287 (thr_try_catch_cmd): Update.
10288 (thread_command): Update.
10289 (thread_find_command): Update.
10290 * record-btrace.c (record_btrace_target::info_record)
10291 (record_btrace_resume_thread, record_btrace_target::resume)
10292 (record_btrace_cancel_resume, record_btrace_step_thread)
10293 (record_btrace_target::wait, record_btrace_target::wait)
10294 (record_btrace_target::wait, record_btrace_target::stop): Update.
10295 * progspace.c (print_program_space): Update.
10296 * process-stratum-target.c
10297 (process_stratum_target::thread_address_space): Update.
10298 * linux-fork.c (linux_fork_mourn_inferior)
10299 (detach_checkpoint_command, info_checkpoints_command)
10300 (linux_fork_context): Update.
10301 (linux_fork_detach): Update.
10302 (class scoped_switch_fork_info): Update.
10303 (delete_checkpoint_command): Update.
10304 * infrun.c (follow_fork_inferior): Update.
10305 (follow_fork_inferior): Update.
10306 (proceed_after_vfork_done): Update.
10307 (handle_vfork_child_exec_or_exit): Update.
10308 (follow_exec): Update.
10309 (displaced_step_prepare_throw): Update.
10310 (displaced_step_restore): Update.
10311 (start_step_over): Update.
10312 (resume_1): Update.
10313 (clear_proceed_status_thread): Update.
10314 (proceed): Update.
10315 (print_target_wait_results): Update.
10316 (do_target_wait): Update.
10317 (context_switch): Update.
10318 (stop_all_threads): Update.
10319 (restart_threads): Update.
10320 (finish_step_over): Update.
10321 (handle_signal_stop): Update.
10322 (switch_back_to_stepped_thread): Update.
10323 (keep_going_pass_signal): Update.
10324 (print_exited_reason): Update.
10325 (normal_stop): Update.
10326 * inferior.c (inferior_pid_to_str): Change return type.
10327 (print_selected_inferior): Update.
10328 (add_inferior): Update.
10329 (detach_inferior): Update.
10330 * dummy-frame.c (fprint_dummy_frames): Update.
10331 * dcache.c (dcache_info_1): Update.
10332 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10333 (btrace_fetch, btrace_clear): Update.
10334 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10335 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10336 type.
10337 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10338 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10339 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10340 * gdbarch.c, gdbarch.h: Rebuild.
10341 * gdbarch.sh (core_pid_to_str): Change return type.
10342 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10343 return type.
10344 (windows_nat_target::pid_to_str): Change return type.
10345 (windows_delete_thread): Update.
10346 (windows_nat_target::attach): Update.
10347 (windows_nat_target::files_info): Update.
10348 * target-delegates.c: Rebuild.
10349 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10350 return type.
10351 (sol_thread_target::pid_to_str): Change return type.
10352 * remote.c (class remote_target) <pid_to_str>: Change return
10353 type.
10354 (remote_target::pid_to_str): Change return type.
10355 (extended_remote_target::attach, remote_target::remote_stop_ns)
10356 (remote_target::remote_notif_remove_queued_reply)
10357 (remote_target::push_stop_reply, remote_target::disable_btrace):
10358 Update.
10359 (extended_remote_target::attach): Update.
10360 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10361 type.
10362 (gdbsim_target::pid_to_str): Change return type.
10363 * ravenscar-thread.c (struct ravenscar_thread_target)
10364 <pid_to_str>: Change return type.
10365 (ravenscar_thread_target::pid_to_str): Change return type.
10366 * procfs.c (class procfs_target) <pid_to_str>: Change return
10367 type.
10368 (procfs_target::pid_to_str): Change return type.
10369 (procfs_target::attach): Update.
10370 (procfs_target::detach): Update.
10371 (procfs_target::fetch_registers): Update.
10372 (procfs_target::store_registers): Update.
10373 (procfs_target::wait): Update.
10374 (procfs_target::files_info): Update.
10375 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10376 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10377 return type.
10378 (nto_procfs_target::pid_to_str): Change return type.
10379 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10380 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10381 return type.
10382 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10383 (exit_lwp): Update.
10384 (attach_proc_task_lwp_callback, get_detach_signal)
10385 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10386 (linux_nat_target::resume, wait_lwp, stop_callback)
10387 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10388 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10389 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10390 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10391 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10392 type.
10393 (inf_ptrace_target::attach): Update.
10394 (inf_ptrace_target::files_info): Update.
10395 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10396 type.
10397 (go32_nat_target::pid_to_str): Change return type.
10398 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10399 (gnu_nat_target::wait): Update.
10400 (gnu_nat_target::wait): Update.
10401 (gnu_nat_target::resume): Update.
10402 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10403 (fbsd_nat_target::wait): Update.
10404 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10405 type.
10406 (darwin_nat_target::attach): Update.
10407 * corelow.c (class core_target) <pid_to_str>: Change return type.
10408 (core_target::pid_to_str): Change return type.
10409 * target.c (normal_pid_to_str): Change return type.
10410 (default_pid_to_str): Likewise.
10411 (target_pid_to_str): Change return type.
10412 (target_translate_tls_address): Update.
10413 (target_announce_detach): Update.
10414 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10415 return type.
10416 (bsd_uthread_target::pid_to_str): Change return type.
10417 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10418 type.
10419 (bsd_kvm_target::pid_to_str): Change return type.
10420 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10421 return type.
10422 (aix_thread_target::pid_to_str): Change return type.
10423 * target.h (struct target_ops) <pid_to_str>: Change return type.
10424 (target_pid_to_str, normal_pid_to_str): Likewise.
10425 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10426 type.
10427 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10428 type.
10429 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10430 return type.
10431 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10432 type.
10433 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10434 type.
10435 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10436 return type.
10437
b4be1b06
SM
104382019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10439
10440 * NEWS: Mention that the new default MI version is 3. Mention
10441 changes to the output of commands and events that deal with
10442 multi-location breakpoints.
10443 * breakpoint.c: Include "mi/mi-out.h".
10444 (print_one_breakpoint): Change output syntax if using MI version
10445 >= 3.
10446 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10447 New.
10448 (mi_multi_location_breakpoint_output_fixed): New.
10449 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10450 (mi_cmd_fix_multi_location_breakpoint_output): New.
10451 (mi_multi_location_breakpoint_output_fixed): New.
10452 * mi/mi-cmds.c (mi_cmds): Register command
10453 -fix-multi-location-breakpoint-output.
10454 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10455 interpreter "mi".
10456
8e5e5494
SM
104572019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10458
10459 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10460 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10461 instantiate mi_ui_out based on interpreter name.
10462 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10463 * mi/mi-main.c (mi_load_progress): Likewise.
10464
197df35e
JB
104652019-03-12 John Baldwin <jhb@FreeBSD.org>
10466
10467 * NEWS: Combine separate "New targets" sections for 8.3.
10468
8399425f
JB
104692019-03-12 John Baldwin <jhb@FreeBSD.org>
10470
10471 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10472 (ppcfbsd_init_abi): Install gdbarch
10473 "fetch_tls_load_module_address" and "get_thread_local_address"
10474 methods.
10475
b0f87ed0
JB
104762019-03-12 John Baldwin <jhb@FreeBSD.org>
10477
10478 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10479 (riscv_fbsd_init_abi): Install gdbarch
10480 "fetch_tls_load_module_address" and "get_thread_local_address"
10481 methods.
10482
ce25aa57
JB
104832019-03-12 John Baldwin <jhb@FreeBSD.org>
10484
10485 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10486 (i386fbsd_init_abi): Install gdbarch
10487 "fetch_tls_load_module_address" and "get_thread_local_address"
10488 methods.
10489
f5424cfa
JB
104902019-03-12 John Baldwin <jhb@FreeBSD.org>
10491
10492 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10493 (amd64fbsd_init_abi): Install gdbarch
10494 "fetch_tls_load_module_address" and "get_thread_local_address"
10495 methods.
10496
945f3901
JB
104972019-03-12 John Baldwin <jhb@FreeBSD.org>
10498
10499 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10500 (struct fbsd_pspace_data): New type.
10501 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10502 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10503 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10504 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10505 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10506
ef0bd204
JB
105072019-03-12 John Baldwin <jhb@FreeBSD.org>
10508
10509 * gdbtypes.c (lookup_struct_elt): New function.
10510 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10511 * gdbtypes.h (struct struct_elt): New type.
10512 (lookup_struct_elt): New prototype.
10513
36c53a02
JB
105142019-03-12 John Baldwin <jhb@FreeBSD.org>
10515
10516 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10517 remove disabled code block.
10518
6e056c81
JB
105192019-03-12 John Baldwin <jhb@FreeBSD.org>
10520
10521 * gdbarch.sh (get_thread_local_address): New method.
10522 * gdbarch.h, gdbarch.c: Regenerate.
10523 * target.c (target_translate_tls_address): Use
10524 gdbarch_get_thread_local_address if present instead of
10525 target::get_thread_local_address.
10526
cd250a18
JB
105272019-03-12 John Baldwin <jhb@FreeBSD.org>
10528
10529 * target.h (target::get_thread_local_address): Update comment.
10530
df22c1e5
JB
105312019-03-12 John Baldwin <jhb@FreeBSD.org>
10532
10533 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10534 objfile->separate_debug_objfile_backlink if not NULL.
10535
dd6876c9
JB
105362019-03-12 John Baldwin <jhb@FreeBSD.org>
10537
10538 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10539 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10540 (amd64bsd_store_inferior_registers): Likewise.
10541 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10542 Enable segment base registers.
10543 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10544 PT_GETFSBASE and PT_GETGSBASE.
10545 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10546 PT_SETGSBASE.
10547 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10548 segment base registers.
10549 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10550
1163a4b7
JB
105512019-03-12 John Baldwin <jhb@FreeBSD.org>
10552
10553 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10554 Update calls to i386_target_description to add 'segments'
10555 parameter.
10556 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10557 add segment base registers.
10558 * arch/i386.c (i386_create_target_description): Add 'segments'
10559 parameter to enable segment base registers.
10560 * arch/i386.h (i386_create_target_description): Likewise.
10561 * features/i386/32bit-segments.xml: New file.
10562 * features/i386/32bit-segments.c: Generate.
10563 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10564 call to i386_target_description to add 'segments' parameter.
10565 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10566 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10567 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10568 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10569 if feature is present.
10570 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10571 Add 'segments' parameter to call to i386_target_description.
10572 (i386_target_description): Add 'segments' parameter to enable
10573 segment base registers.
10574 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10575 to call to i386_target_description.
10576 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10577 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10578 Define I386_NUM_REGS.
10579 (i386_target_description): Add 'segments' parameter to enable
10580 segment base registers.
10581
3a350822
EZ
105822019-03-12 Eli Zaretskii <eliz@gnu.org>
10583
10584 PR/24325
10585 * source-cache.c: #undef open and close, to avoid unresolved
10586 externals during linking.
10587
ffdd69cf
TT
105882019-03-12 Tom Tromey <tromey@adacore.com>
10589
10590 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10591 const. Add initializers.
10592 (_initialize_remote): Don't initialize ptid globals.
10593
ec148c57
PA
105942019-03-12 Pedro Alves <palves@redhat.com>
10595
10596 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10597
32764270
PA
105982019-03-12 Pedro Alves <palves@redhat.com>
10599
10600 * cp-name-parser.y (main): Remove unused 'len' variable.
10601
17547186
TT
106022019-03-12 Tom Tromey <tromey@adacore.com>
10603
10604 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10605 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10606
d3a70e03
TT
106072019-03-12 Tom Tromey <tromey@adacore.com>
10608
10609 * linux-nat.c (iterate_over_lwps): Update.
10610 (stop_callback): Remove parameter.
10611 (stop_wait_callback, detach_callback, resume_set_callback)
10612 (select_singlestep_lwp_callback, set_ignore_sigint)
10613 (status_callback, resumed_callback, resume_clear_callback)
10614 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10615 data parameter.
10616 (linux_nat_target::detach, linux_nat_target::resume)
10617 (linux_stop_and_wait_all_lwps, select_event_lwp)
10618 (linux_nat_filter_event, linux_nat_wait_1)
10619 (linux_nat_target::kill, linux_nat_target::stop)
10620 (linux_nat_target::stop): Update.
10621 (linux_nat_resume_callback): Change type.
10622 (resume_stopped_resumed_lwps, count_events_callback)
10623 (select_event_lwp_callback): Likewise.
10624 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10625 * arm-linux-nat.c (struct update_registers_data): Remove.
10626 (update_registers_callback): Change type.
10627 (arm_linux_insert_hw_breakpoint1): Update.
10628 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10629 parameter.
10630 (x86_linux_dr_set_addr): Update.
10631 (x86_linux_dr_set_control): Update.
10632 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10633 (iterate_over_lwps): Use gdb::function_view.
10634 * nat/aarch64-linux-hw-point.c (struct
10635 aarch64_dr_update_callback_param): Remove.
10636 (debug_reg_change_callback): Change type.
10637 (aarch64_notify_debug_reg_change): Update.
10638 * s390-linux-nat.c (s390_refresh_per_info): Update.
10639
82cb27ff
TT
106402019-03-11 Tom Tromey <tromey@adacore.com>
10641
10642 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10643 redundant assignment to "this_cu".
10644
568c0683
SM
106452019-03-08 Simon Marchi <simon.marchi@efficios.com>
10646
10647 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10648
f09ce22d
SM
106492019-03-08 Simon Marchi <simon.marchi@efficios.com>
10650
10651 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10652 from...
10653 (rank_one_type): ... this.
10654
595f96a9
SM
106552019-03-08 Simon Marchi <simon.marchi@efficios.com>
10656
10657 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10658 from...
10659 (rank_one_type): ... this.
10660
2598a94b
SM
106612019-03-08 Simon Marchi <simon.marchi@efficios.com>
10662
10663 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10664 from...
10665 (rank_one_type): ... this.
10666
7f17b20d
SM
106672019-03-08 Simon Marchi <simon.marchi@efficios.com>
10668
10669 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10670 from...
10671 (rank_one_type): ... this.
10672
2c509035
SM
106732019-03-08 Simon Marchi <simon.marchi@efficios.com>
10674
10675 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10676 from...
10677 (rank_one_type): ... this.
10678
0dd322dc
SM
106792019-03-08 Simon Marchi <simon.marchi@efficios.com>
10680
10681 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10682 from...
10683 (rank_one_type): ... this.
10684
41ea4728
SM
106852019-03-08 Simon Marchi <simon.marchi@efficios.com>
10686
10687 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10688 from...
10689 (rank_one_type): ... this.
10690
793cd1d2
SM
106912019-03-08 Simon Marchi <simon.marchi@efficios.com>
10692
10693 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10694 from...
10695 (rank_one_type): ... this.
10696
34910087
SM
106972019-03-08 Simon Marchi <simon.marchi@efficios.com>
10698
10699 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10700 from...
10701 (rank_one_type): ... this.
10702
f1f832d6
SM
107032019-03-08 Simon Marchi <simon.marchi@efficios.com>
10704
10705 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10706 from...
10707 (rank_one_type): ... this.
10708
b9f4512f
SM
107092019-03-08 Simon Marchi <simon.marchi@efficios.com>
10710
10711 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10712 from...
10713 (rank_one_type): ... this.
10714
9293fc63
SM
107152019-03-08 Simon Marchi <simon.marchi@efficios.com>
10716
10717 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10718 from...
10719 (rank_one_type): ... this.
10720
e3abbe7e
PW
107212019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10722
10723 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10724 inferior-events' shows the example events.
10725
e4adb939
EZ
107262019-03-08 Eli Zaretskii <eliz@gnu.org>
10727
10728 Support styling on native MS-Windows console
10729
10730 PR/24315
10731 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10732 on MS-Windows if $TERM is not defined.
10733
10734 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10735
10736 * posix-hdep.c (gdb_console_fputs):
10737 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10738 functions.
10739 * ui-file.h (gdb_console_fputs): Add prototype.
10740
10741 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10742 back to fputs only if the former returns zero.
10743
25629dfd
TT
107442019-03-07 Tom Tromey <tom@tromey.com>
10745
10746 * symmisc.c (print_symbol_bcache_statistics): Update.
10747 (print_objfile_statistics): Update.
10748 * symfile.c (allocate_symtab): Update.
10749 * stabsread.c: Don't include bcache.h.
10750 * psymtab.h (struct psymbol_bcache): Don't declare.
10751 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10752 (psymbol_bcache_init, psymbol_bcache_free)
10753 (psymbol_bcache_get_bcache): Don't declare.
10754 * psymtab.c (struct psymbol_bcache): Remove.
10755 (psymtab_storage::psymtab_storage): Update.
10756 (psymtab_storage::~psymtab_storage): Update.
10757 (psymbol_bcache_init, psymbol_bcache_free)
10758 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10759 (add_psymbol_to_bcache): Update.
10760 (allocate_psymtab): Update.
10761 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10762 macro_cache>: No longer pointers.
10763 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10764 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10765 * macrotab.c (macro_bcache): Update.
10766 * macroexp.c: Don't include bcache.h.
10767 * gdbtypes.c (check_types_worklist): Update.
10768 (types_deeply_equal): Remove TRY/CATCH. Update.
10769 * elfread.c (elf_symtab_read): Update.
10770 * dwarf2read.c: Don't include bcache.h.
10771 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10772 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10773 (print_bcache_statistics, bcache_memory_used): Don't declare.
10774 (struct bcache): Move from bcache.c. Add constructor, destructor,
10775 methods. Rename all data members.
10776 * bcache.c (struct bcache): Move to bcache.h.
10777 (bcache::expand_hash_table): Rename from expand_hash_table.
10778 (bcache): Remove.
10779 (bcache::insert): Rename from bcache_full.
10780 (bcache::compare): Rename from bcache_compare.
10781 (bcache_xmalloc): Remove.
10782 (bcache::~bcache): Rename from bcache_xfree.
10783 (bcache::print_statistics): Rename from print_bcache_statistics.
10784 (bcache::memory_used): Rename from bcache_memory_used.
10785
fe726667
PA
107862019-03-07 Pedro Alves <palves@redhat.com>
10787
10788 * infrun.c (normal_stop): Also check for
10789 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10790
7584bb30
AB
107912019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10792
10793 * f-lang.c (value_from_host_double): Moved to...
10794 * value.c (value_from_host_double): ...here.
10795 * value.h (value_from_host_double): Declare.
10796 * guile/scm-math.c (vlscm_convert_typed_number): Use
10797 value_from_host_double.
10798 (vlscm_convert_number): Likewise.
10799 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10800 * python/py-value.c (convert_value_from_python): Likewise.
10801
a7b1986e
TT
108022019-03-06 Tom Tromey <tom@tromey.com>
10803
10804 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10805
0ccf4211
TT
108062019-03-06 Tom Tromey <tom@tromey.com>
10807
10808 * utils.h (free_current_contents): Don't declare.
10809 * utils.c (free_current_contents): Remove.
10810
fe7b42e5
TT
108112019-03-06 Tom Tromey <tom@tromey.com>
10812
10813 * top.c (quit_force): Update.
10814 * main.c (captured_command_loop): Update.
10815 * common/new-op.c (operator new): Update.
10816 * common/common-exceptions.c (struct catcher)
10817 <save_cleanup_chain>: Remove member.
10818 (exceptions_state_mc_init): Update.
10819 (exception_try_scope_entry): Return nullptr.
10820 (exception_try_scope_exit, exception_rethrow)
10821 (throw_exception_sjlj, throw_exception_cxx): Update.
10822 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10823 (all_cleanups, do_cleanups, discard_cleanups)
10824 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10825 (restore_cleanups, restore_final_cleanups): Don't declare.
10826 (do_final_cleanups): Remove parameter.
10827 * common/cleanups.c (cleanup_chain, make_cleanup)
10828 (make_cleanup_dtor, all_cleanups, do_cleanups)
10829 (discard_my_cleanups, discard_cleanups)
10830 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10831 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10832 (null_cleanup): Remove.
10833 (do_final_cleanups): Remove parameter.
10834
c6321f19
TT
108352019-03-06 Tom Tromey <tom@tromey.com>
10836
10837 * remote.c (remote_target::remote_parse_stop_reply): Use
10838 unique_xmalloc_ptr.
10839
61b30099
TT
108402019-03-06 Tom Tromey <tom@tromey.com>
10841
10842 * stabsread.c (struct stabs_field_info): Rename from field_info.
10843 <list, fnlist>: Add initializers.
10844 <obstack>: New member.
10845 (read_member_functions, read_struct_fields, read_baseclasses):
10846 Allocate on obstack. Don't use cleanups.
10847 (read_one_struct_field, read_member_functions, read_struct_fields)
10848 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10849 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10850 (read_struct_type): Update.
10851
6cceac94
TT
108522019-03-06 Tom Tromey <tom@tromey.com>
10853
10854 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10855 * common/filestuff.h (make_cleanup_close): Don't declare.
10856 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10857 Remove.
10858
72412762
TT
108592019-03-06 Tom Tromey <tom@tromey.com>
10860
10861 * solib-aix.c: Use make_scope_exit.
10862
2b6ff1c0
TT
108632019-03-06 Tom Tromey <tom@tromey.com>
10864
10865 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10866 Use make_scope_exit.
10867
d01c5877
TT
108682019-03-06 Tom Tromey <tom@tromey.com>
10869
10870 * solib-svr4.c (disable_probes_interface): Remove parameter.
10871 (svr4_handle_solib_event): Use make_scope_exit.
10872
32603266
TT
108732019-03-06 Tom Tromey <tom@tromey.com>
10874
10875 * remote.c (struct stop_reply_deleter): Remove.
10876 (stop_reply_up): Update.
10877 (struct stop_reply): Derive from notif_event. Don't typedef.
10878 <regcache>: Now a std::vector.
10879 (stop_reply_xfree): Remove.
10880 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10881 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10882 (remote_target::discard_pending_stop_replies): Use delete.
10883 (remote_target::remote_parse_stop_reply): Update.
10884 (remote_target::process_stop_reply): Update.
10885 * remote-notif.h (struct notif_event): Add virtual destructor.
10886 Remove "dtr" member.
10887 (struct notif_client) <alloc_event>: Return a unique_ptr.
10888 (notif_event_xfree): Don't declare.
10889 (notif_event_up): New typedef.
10890 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10891 (notif_event_xfree, do_notif_event_xfree): Remove.
10892 (remote_notif_state_xfree): Update.
10893
9799571e
TT
108942019-03-06 Tom Tromey <tom@tromey.com>
10895
10896 * infrun.c (displaced_step_clear_cleanup): Now a
10897 forward_scope_exit type.
10898 (displaced_step_prepare_throw): Update.
10899 (displaced_step_fixup): Update.
10900
09e3c4ca
TT
109012019-03-06 Tom Tromey <tom@tromey.com>
10902
10903 * inferior.h (class inferior): Update comment.
10904 * gdbthread.h (class thread_info): Update comment.
10905
e2a03548
TT
109062019-03-06 Joel Brobecker <brobecker@adacore.com>
10907 Tom Tromey <tom@tromey.com>
10908
10909 * stabsread.h (struct stab_section_list): Remove.
10910 (coffstab_build_psymtabs): Update.
10911 * dbxread.c (symbuf_sections): Now a std::vector.
10912 (sect_idx): New global.
10913 (fill_symbuf): Update.
10914 (coffstab_build_psymtabs): Change type of stabsects parameter.
10915 Update.
10916 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10917 std::vector.
10918 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10919 (coff_locate_sections): Update.
10920 (coff_symfile_read): Remove cleanups. Update.
10921 (init_stringtab): Add storage parameter.
10922 (free_stringtab, free_stringtab_cleanup): Remove.
10923 (init_lineno): Add storage parameter.
10924 (free_linetab, free_linetab_cleanup): Remove.
10925
b7e60d85
PA
109262019-03-06 Pedro Alves <palves@redhat.com>
10927
10928 * linux-fork.c (fork_info::clobber_regs): Delete.
10929 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10930 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10931 comment. Adjust.
10932 (scoped_switch_fork_info::scoped_switch_fork_info)
10933 (checkpoint_command, linux_fork_context): Adjust
10934 fork_save_infrun_state calls.
10935
e52c971f
PA
109362019-03-06 Pedro Alves <palves@redhat.com>
10937
10938 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10939 (inf_has_multiple_threads): Return 'bool' and rewrite using
10940 inferior_info::threads().
10941
06974e6c
PA
109422019-03-06 Pedro Alves <palves@redhat.com>
10943
10944 * linux-fork.c: Include <list>.
10945 (fork_list): Now a std::list instance.
10946 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10947 (forks_exist_p, find_last_fork): Adjust.
10948 (new_fork): Delete.
10949 (one_fork_p): New.
10950 (add_fork): Adjust.
10951 (free_fork): Delete, folded into fork_info::~fork_info().
10952 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10953 Adjust.
10954 (init_fork_list): Delete.
10955 (linux_fork_killall, linux_fork_mourn_inferior)
10956 (linux_fork_detach, info_checkpoints_command): Adjust.
10957 (_initialize_linux_fork): No longer call init_fork_list.
10958
72f31aea
PA
109592019-03-06 Pedro Alves <palves@redhat.com>
10960
10961 * linux-fork.c (new_fork): New, split out of ...
10962 (add_fork): ... this. Return void. Move "first fork" special
10963 case from here, to ...
10964 (checkpoint_command): ... here.
10965 * linux-linux.h (add_fork): Return void.
10966
efbecbc1
AB
109672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10968
10969 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10970
0841c79a
AB
109712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10972 Chris January <chris.january@arm.com>
10973 David Lecomber <david.lecomber@arm.com>
10974
10975 * f-exp.y: New token, UNOP_INTRINSIC.
10976 (exp): New pattern using UNOP_INTRINSIC token.
10977 (f77_keywords): Add 'abs' keyword.
10978 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10979 (value_from_host_double): New function.
10980 (evaluate_subexp_f): Support UNOP_ABS.
10981
4a270568
AB
109822019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10983
10984 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10985 types.
10986
067630bd
AB
109872019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10988
10989 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10990 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10991 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10992
3be47f7a
AB
109932019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10994
10995 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10996
4d00f5d8
AB
109972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10998 Chris January <chris.january@arm.com>
10999
11000 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11001 * f-exp.y: Define 'KIND' token.
11002 (exp): New pattern for KIND expressions.
11003 (ptype): Handle types with a kind extension.
11004 (direct_abs_decl): Extend to spot kind extensions.
11005 (f77_keywords): Add 'kind' to the list.
11006 (push_kind_type): New function.
11007 (convert_to_kind_type): New function.
11008 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11009 * parse.c (operator_length_standard): Likewise.
11010 * parser-defs.h (enum type_pieces): Add tp_kind.
11011 * std-operator.def: Add UNOP_KIND.
11012
e454224f
AB
110132019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11014
11015 * f-exp.y (f_parse): Set yydebug.
11016
9dad4a58
AB
110172019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11018
11019 * f-lang.c (evaluate_subexp_f): New function.
11020 (exp_descriptor_f): New global.
11021 (f_language_defn): Use exp_descriptor_f instead of
11022 exp_descriptor_standard.
11023
c8f91604
AB
110242019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11025
11026 * f-exp.y (struct token): Add comments.
11027 (dot_ops): Remove uppercase versions and the end marker.
11028 (f77_keywords): Likewise.
11029 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11030 entries in the dot_ops array are case insensitive, and use
11031 strncasecmp to compare strings. Also some whitespace cleanup in
11032 this area. Similar for the f77_keywords array, except entries in
11033 this list might be case sensitive.
11034
dd9f2c76
AB
110352019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11036
11037 * f-exp.y (struct f77_boolean_val): Add comments.
11038 (boolean_values): Remove uppercase versions, and end marker.
11039 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11040 and use strncasecmp to achieve case insensitivity. Additionally,
11041 perform whitespace cleanup around this code.
11042
67a3048c
TT
110432019-03-06 Tom Tromey <tromey@adacore.com>
11044
11045 * remote-sim.c (gdbsim_target_open): Use result of
11046 gdb_argv::release.
11047
aa3cfbda
RB
110482019-03-06 Richard Bunt <richard.bunt@arm.com>
11049 Dirk Schubert <dirk.schubert@arm.com>
11050 Chris January <chris.january@arm.com>
11051
11052 * eval.c (evaluate_subexp_standard): Call Fortran argument
11053 wrapping logic.
11054 * f-lang.c (struct value): A value which can be passed into a
11055 Fortran function call.
11056 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11057 where appropriate.
11058 (struct type): Value ready for a Fortran function call.
11059 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11060 is needed.
11061 * f-lang.h (fortran_argument_convert): Declaration.
11062 (fortran_preserve_arg_pointer): Declaration.
11063 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11064
ea38e5df
TT
110652019-03-05 Tom Tromey <tromey@adacore.com>
11066
11067 * python/py-prettyprint.c (print_string_repr): Remove #if.
11068 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11069
06b5b831
TT
110702019-03-05 Tom Tromey <tromey@adacore.com>
11071
11072 * target.c (the_dummy_target): Move later. Change type to
11073 "dummy_target".
11074 (initialize_targets): Don't initialize the_dummy_target.
11075
edbd9e45
TT
110762019-03-05 Tom Tromey <tromey@adacore.com>
11077
11078 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11079 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11080
c119e040
TT
110812019-03-05 Tom Tromey <tromey@adacore.com>
11082
11083 * windows-nat.c (windows_nat_target::attach)
11084 (windows_nat_target::detach): Don't call gdb_flush.
11085 * valprint.c (generic_val_print, val_print, val_print_string):
11086 Don't call gdb_flush.
11087 * utils.c (defaulted_query): Don't call gdb_flush.
11088 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11089 * target.c (target_announce_detach): Don't call gdb_flush.
11090 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11091 * remote.c (extended_remote_target::attach): Don't call
11092 gdb_flush.
11093 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11094 * printcmd.c (do_examine): Don't call gdb_flush.
11095 (info_display_command): Don't call gdb_flush.
11096 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11097 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11098 * memattr.c (info_mem_command): Don't call gdb_flush.
11099 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11100 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11101 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11102 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11103 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11104 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11105 (gnu_nat_target::detach): Don't call gdb_flush.
11106 * f-valprint.c (f_val_print): Don't call gdb_flush.
11107 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11108 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11109 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11110 gdb_flush.
11111 * c-valprint.c (c_val_print): Don't call gdb_flush.
11112 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11113
895dafa6
TT
111142019-03-05 Tom Tromey <tromey@adacore.com>
11115
11116 * varobj.c (update_dynamic_varobj_children): Update.
11117 (install_default_visualizer): Use reset, not release.
11118 * value.c (set_internalvar): Update.
11119 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11120 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11121 ATTRIBUTE_UNUSED_RESULT.
11122
88a774b9
TT
111232019-03-05 Tom Tromey <tromey@adacore.com>
11124
11125 * remote.c (class scoped_remote_fd) <release>: Add
11126 ATTRIBUTE_UNUSED_RESULT.
11127
4e4a8b93
TT
111282019-03-05 Tom Tromey <tromey@adacore.com>
11129
11130 * macroexp.c (struct macro_buffer) <release>: Add
11131 ATTRIBUTE_UNUSED_RESULT.
11132
083eef1f
TT
111332019-03-05 Tom Tromey <tromey@adacore.com>
11134
11135 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11136 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11137 ATTRIBUTE_UNUSED_RESULT.
11138
3cabd438
TT
111392019-03-05 Tom Tromey <tromey@adacore.com>
11140
11141 * common/scoped_fd.h (class scoped_fd) <release>: Add
11142 ATTRIBUTE_UNUSED_RESULT.
11143
41e3300a
TT
111442019-03-05 Tom Tromey <tromey@adacore.com>
11145
11146 * parser-defs.h (struct parser_state) <release>: Add
11147 ATTRIBUTE_UNUSED_RESULT.
11148
18cb7c9f
TT
111492019-03-05 Tom Tromey <tromey@adacore.com>
11150
11151 * utils.h (class gdb_argv) <release>: Add
11152 ATTRIBUTE_UNUSED_RESULT.
11153 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11154
41fa577f
EZ
111552019-03-02 Eli Zaretskii <eliz@gnu.org>
11156
a6a4b2c6
EZ
11157 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11158 for-loop range, to avoid compiler warnings.
11159
11160 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11161 avoid compiler warnings about unused variables.
11162
742a7df5
EZ
11163 * NEWS: Mention end of support for native debugging on MS-Windows
11164 before XP.
11165
41fa577f
EZ
11166 PR gdb/24292
11167 * common/netstuff.c:
11168 * gdbserver/gdbreplay.c
11169 * gdbserver/remote-utils.c:
11170 * ser-tcp.c:
11171 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11172 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11173 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11174 'getaddrinfo' and 'freeaddrinfo' were not available before
11175 Windows XP, and mingw.org's MinGW headers by default define
11176 _WIN32_WINNT to 0x500.
11177
827f438f
GB
111782019-03-01 Gary Benson <gbenson@redhat.com>
11179
11180 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11181
92137da0
RO
111822019-02-28 Brian Vandenberg <phantall@gmail.com>
11183 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11184
11185 PR gdb/8527
11186 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11187 set_sigint_trap, clear_sigint_trap.
11188
799efbe8
PW
111892019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11190
11191 * target.c (target_detach): Clear the regcache and the
11192 frame cache.
11193
8ed25214
PA
111942019-02-27 Pedro Alves <palves@redhat.com>
11195
11196 * utils.c (set_screen_size): When we cap the height/width sizes,
11197 tweak the corresponding command variable to show "unlimited":
11198
23031e31
SJ
111992019-02-27 Saagar Jha <saagar@saagarjha.com>
11200 Pedro Alves <palves@redhat.com>
11201
11202 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11203 before calling rl_set_screen_size.
11204
6c28e44a
TT
112052019-02-27 Tom Tromey <tromey@adacore.com>
11206
11207 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11208 define.
11209 * python/py-value.c: Remove Python 2.4 workaround.
11210 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11211 workaround.
11212 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11213 Python 2.4 workaround.
11214 * python/python-internal.h: Remove Python 2.4 comment.
11215 (Py_ssize_t): Don't define.
11216 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11217 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11218 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11219 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11220 * python/python.c (do_start_initialization): Remove Python 2.4
11221 workaround.
11222 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11223 (print_children): Remove Python 2.4 workaround.
11224 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11225 workaround.
11226 (CHARBUFFERPROC_NAME): Remove.
11227 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11228 Python 2.4 workaround.
11229
2c3fc25d 112302019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 11231
2c3fc25d
KB
11232 * NEWS: Note minimum Python version.
11233
6ca62222
KB
112342019-02-27 Kevin Buettner <kevinb@redhat.com>
11235
11236 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11237 code from these functions. Remove corresponding ifdefs. Use
11238 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11239 Remove gotos and target of gotos.
11240 (infpy_search_memory): Likewise.
11241
f4bc7d2c
AB
112422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11243
11244 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11245 (hppa_gdbarch_init): Don't register deleted functions with
11246 gdbarch.
11247
9734a586
AB
112482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11249
11250 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11251 (h8300_unwind_sp): Delete.
11252 (h8300_dummy_id): Delete.
11253 (h8300_gdbarch_init): Don't register deleted functions with
11254 gdbarch.
11255
68b867f3
AB
112562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11257
11258 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11259 (ft32_unwind_pc): Delete.
11260 (ft32_unwind_sp): Delete.
11261 (ft32_gdbarch_init): Don't register deleted functions with
11262 gdbarch.
11263
2fbe7ad0
AB
112642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11265
11266 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11267 (frv_unwind_pc): Delete.
11268 (frv_unwind_sp): Delete.
11269 (frv_gdbarch_init): Don't register deleted functions with
11270 gdbarch.
11271
76055cbe
AB
112722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11273
11274 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11275 (riscv_unwind_pc): Delete.
11276 (riscv_unwind_sp): Delete.
11277 (riscv_gdbarch_init): Don't register deleted functions with
11278 gdbarch.
11279
4133e5a1
AB
112802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11281
11282 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11283 (csky_unwind_pc): Delete.
11284 (csky_unwind_sp): Delete.
11285 (csky_gdbarch_init): Don't register deleted functions with
11286 gdbarch.
11287
8010f576
AB
112882019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11289
11290 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11291 (cris_unwind_pc): Delete.
11292 (cris_unwind_sp): Delete.
11293 (cris_gdbarch_init): Don't register deleted functions with
11294 gdbarch.
11295
b56bf084
AB
112962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11297
11298 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11299 (bfin_unwind_pc): Delete.
11300 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11301
a19a650f
AB
113022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11305 (arm_unwind_pc): Delete.
11306 (arm_unwind_sp): Delete.
11307 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11308
f8278c3c
AB
113092019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11310
11311 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11312 (arc_unwind_pc): Delete.
11313 (arc_unwind_sp): Delete.
11314 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11315
480e46cf
AB
113162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11317
11318 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11319 (alpha_unwind_pc): Delete.
11320 (alpha_gdbarch_init): Don't register deleted functions with
11321 gdbarch.
11322
7a995095
AB
113232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11324
11325 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11326 (aarch64_unwind_pc): Delete.
11327 (aarch64_unwind_sp): Delete.
11328 (aarch64_gdbarch_init): Don't register deleted functions with
11329 gdbarch.
11330
bf9a735e
AB
113312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11332
11333 * gdbtypes.c (type_align): Don't consider static members when
11334 computing structure alignment.
11335
5561fc30
AB
113362019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11337
11338 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11339 return 0 for other types.
11340 * arch-utils.c (default_type_align): Always return 0.
11341 * gdbarch.h: Regenerate.
11342 * gdbarch.sh (type_align): Extend comment.
11343 * gdbtypes.c (type_align): Add additional comments, always call
11344 gdbarch_type_align before applying the default rules.
11345 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11346 generic code will then apply a suitable default.
11347 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11348 types, return 0 for other types.
11349
9335e75a
JB
113502019-02-27 Joel Brobecker <brobecker@adacore.com>
11351
11352 * NEWS: Create a new section for the next release branch.
11353 Rename the section of the current branch, now that it has
11354 been cut.
11355
3d34d8de
JB
113562019-02-27 Joel Brobecker <brobecker@adacore.com>
11357
11358 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11359 * version.in: Bump version to 8.3.50.DATE-git.
11360
143420fb
SM
113612019-02-26 Simon Marchi <simon.marchi@efficios.com>
11362
11363 * aix-thread.c (ptid_cmp): Remove unused variable.
11364 (get_signaled_thread): Likewise.
11365 (store_regs_user_thread): Likewise.
11366 (store_regs_kernel_thread): Likewise.
11367 (fetch_regs_kernel_thread): Remove shadowed variable.
11368
172fb711
AB
113692019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11370
11371 * features/riscv/32bit-cpu.xml: Add register numbers.
11372 * features/riscv/32bit-fpu.c: Regenerate.
11373 * features/riscv/32bit-fpu.xml: Add register numbers.
11374 * features/riscv/64bit-cpu.xml: Add register numbers.
11375 * features/riscv/64bit-fpu.c: Regenerate.
11376 * features/riscv/64bit-fpu.xml: Add register numbers.
11377
26c89782
KB
113782019-02-26 Kevin Buettner <kevinb@redhat.com>
11379
af54ade9 11380 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
11381 * python/py-value.c (convert_buffer_and_type_to_value): New
11382 function.
11383 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11384 Add support for handling an optional second argument. Call
11385 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
11386 * python/python-internal.h (Py_buffer_deleter): New struct.
11387 (Py_buffer_up): New typedef.
11388
0f58c9e8
JB
113892019-02-25 John Baldwin <jhb@FreeBSD.org>
11390
11391 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11392 instead of releasing ownership.
11393
0a0f4c01
JR
113942019-02-25 Jordan Rupprecht <rupprecht@google.com>
11395
11396 * dwarf2read.c (open_and_init_dwp_file): Call
11397 elf_numsections instead of bfd_count_sections to initialize
11398 dwp_file->num_sections.
11399
cd5a152c
TT
114002019-02-25 Tom Tromey <tromey@adacore.com>
11401
11402 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11403
8a6a8513
SDJ
114042019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11405
11406 * gcore.in: Add '--readnever' option when invoking GDB.
11407
04dcda9c
SM
114082019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11409
11410 * MAINTAINERS: Update my email address.
11411
07bc701d
SM
114122019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11413
11414 * build-id.c (build_id_to_debug_bfd_1): New function.
11415 (build_id_to_debug_bfd): Look for separate debug file in
11416 sysroot.
11417
c6f4a5d0
AB
114182019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11419
11420 * gdbarch.sh: Update the copyright year range that is placed into
11421 generated files.
11422
9600246d
KS
114232019-02-22 Keith Seitz <keiths@redhat.com>
11424
11425 PR symtab/23853
11426 * linespec.c (create_sals_line_offset): Search for the default
11427 symtab's filename instead of its fullname.
11428
7557a514
AH
114292019-02-21 Alan Hayward <alan.hayward@arm.com>
11430
11431 * NEWS: Update style defaults.
11432
ee2bcb0c
AH
114332019-02-21 Alan Hayward <alan.hayward@arm.com>
11434
11435 * main.c (captured_main_1): Disable styling in batch mode.
11436
0c95f9ed
TT
114372019-02-20 Tom Tromey <tom@tromey.com>
11438
11439 * symtab.c (symtab_symbol_info): Fix typos.
11440
c763b894
TT
114412019-02-20 Tom Tromey <tromey@adacore.com>
11442
11443 * findcmd.c (_initialize_mem_search): Use upper case for
11444 metasyntactic variables.
11445
0ef8a082
AH
114462019-02-20 Alan Hayward <alan.hayward@arm.com>
11447
11448 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11449 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11450
6caa91b6
SM
114512019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11452
11453 * top.h (source_file_name): Change to std::string.
11454 * top.c (source_file_name): Likewise.
11455 (command_line_input): Adjust.
11456 * cli/cli-script.c (script_from_file): Adjust.
11457
98814c6c
TT
114582019-02-19 Tom Tromey <tromey@adacore.com>
11459
11460 * ravenscar-thread.c
11461 (ravenscar_thread_target::update_thread_list): Don't call
11462 ada_build_task_list.
11463 * ada-lang.h (ada_build_task_list): Don't declare.
11464 * ada-tasks.c (struct ada_tasks_inferior_data)
11465 <task_list_valid_p>: Now bool.
11466 (read_known_tasks, ada_task_list_changed)
11467 (ada_tasks_invalidate_inferior_data): Update.
11468 (read_known_tasks_array): Return bool.
11469 (read_known_tasks_list): Likewise.
11470 (read_known_tasks): Return void.
11471 (ada_build_task_list): Now static.
11472
70cd633e
AB
114732019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11474
11475 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11476 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11477
040b3e95
PW
114782019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11479
11480 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11481 variant for ada_tasks_pspace_data_handle and
11482 ada_tasks_inferior_data_handle.
11483 (ada_tasks_pspace_data_cleanup): New function.
11484 (ada_tasks_inferior_data_cleanup): New function.
11485
9409233b
TT
114862019-02-17 Tom Tromey <tom@tromey.com>
11487
11488 * macrotab.h (macro_source_fullname): Return a std::string.
11489 * macrotab.c (macro_include, check_for_redefinition)
11490 (macro_undef, macro_lookup_definition, foreach_macro)
11491 (foreach_macro_in_scope): Update.
11492 (macro_source_fullname): Return a std::string.
11493 * macrocmd.c (show_pp_source_pos): Update.
11494
6506371f
TT
114952019-02-17 Tom Tromey <tom@tromey.com>
11496
11497 * macrocmd.c (show_pp_source_pos): Style the file names.
11498
0c820d67
TT
114992019-02-17 Tom Tromey <tom@tromey.com>
11500
11501 PR tui/24197:
11502 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11503
a0087920
TT
115042019-02-17 Tom Tromey <tom@tromey.com>
11505
11506 * ada-lang.c (user_select_syms): Use filtered printing.
11507 * utils.c (wrap_style): New global.
11508 (desired_style): Remove.
11509 (emit_style_escape): Add stream parameter.
11510 (set_output_style, reset_terminal_style, prompt_for_continue):
11511 Update.
11512 (flush_wrap_buffer): Only flush gdb_stdout.
11513 (wrap_here): Set wrap_style.
11514 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11515 treat escape sequences as a character. Change when wrap buffer is
11516 flushed.
11517 (fputs_styled): Do not set the output style when the default is
11518 requested.
11519 * ui-style.h (struct ui_file_style) <is_default>: New method.
11520 * source.c (print_source_lines_base): Emit escape sequences in one
11521 piece.
11522
75ba10dc
JB
115232019-02-17 Joel Brobecker <brobecker@adacore.com>
11524
11525 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11526 integers and enumeration types.
11527
a2cd4f14
JB
115282019-02-17 Joel Brobecker <brobecker@adacore.com>
11529
11530 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11531 instead of lookup_symbol_in_language
11532 (do_exact_match): New function.
11533 (ada_get_symbol_name_matcher): Return do_exact_match when
11534 doing a verbatim match.
11535
485b851b
TT
115362019-02-15 Tom Tromey <tromey@adacore.com>
11537
11538 * ravenscar-thread.c (ravenscar_thread_target::resume)
11539 (ravenscar_thread_target::wait): Special case wildcard requests.
11540
0b790b1e
TT
115412019-02-15 Tom Tromey <tromey@adacore.com>
11542
11543 * ravenscar-thread.c (base_ptid): Remove.
11544 (struct ravenscar_thread_target) <close>: New method.
11545 <m_base_ptid>: New member.
11546 <update_inferior_ptid, active_task, task_is_currently_active,
11547 runtime_initialized>: Declare methods.
11548 <ravenscar_thread_target>: Add constructor.
11549 (ravenscar_thread_target::task_is_currently_active)
11550 (ravenscar_thread_target::update_inferior_ptid)
11551 (ravenscar_runtime_initialized): Rename. Now methods.
11552 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11553 (ravenscar_thread_target::update_thread_list): Update.
11554 (ravenscar_thread_target::active_task): Now method.
11555 (ravenscar_thread_target::store_registers)
11556 (ravenscar_thread_target::prepare_to_store)
11557 (ravenscar_thread_target::prepare_to_store)
11558 (ravenscar_thread_target::mourn_inferior): Update.
11559 (ravenscar_inferior_created): Use "new" to create target.
11560 (ravenscar_thread_target::get_ada_task_ptid): Update.
11561 (_initialize_ravenscar): Don't initialize base_ptid.
11562 (ravenscar_ops): Remove global.
11563
dea57a62
TT
115642019-02-15 Tom Tromey <tromey@adacore.com>
11565
11566 * target.h (push_target): Declare new overload.
11567 * target.c (push_target): New overload, taking an rvalue reference.
11568 * remote.c (remote_target::open_1): Use push_target overload.
11569 * corelow.c (core_target_open): Use push_target overload.
11570
989f3c58
TT
115712019-02-15 Tom Tromey <tromey@adacore.com>
11572
11573 * ravenscar-thread.c (is_ravenscar_task)
11574 (ravenscar_task_is_currently_active): Return bool.
11575 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11576 (_initialize_ravenscar): Remove "(void)".
11577 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11578 Return bool.
11579
6cbcc006
TT
115802019-02-15 Tom Tromey <tromey@adacore.com>
11581
11582 * ravenscar-thread.c (ravenscar_runtime_initializer)
11583 (has_ravenscar_runtime, get_running_thread_id)
11584 (ravenscar_thread_target::resume): Fix indentation.
11585
7657f14d
TT
115862019-02-15 Tom Tromey <tromey@adacore.com>
11587
11588 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11589 from ravenscar_arch_ops.
11590 (sparc_ravenscar_ops::fetch_registers)
11591 (sparc_ravenscar_ops::store_registers): Now methods.
11592 (sparc_ravenscar_prepare_to_store): Remove.
11593 (sparc_ravenscar_ops): Redefine.
11594 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11595 methods and destructor. Remove members.
11596 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11597 (ravenscar_thread_target::store_registers)
11598 (ravenscar_thread_target::prepare_to_store): Update.
11599 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11600 Remove.
11601 (struct ppc_ravenscar_powerpc_ops): Derive from
11602 ravenscar_arch_ops.
11603 (ppc_ravenscar_powerpc_ops::fetch_registers)
11604 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11605 (ppc_ravenscar_powerpc_ops): Redefine.
11606 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11607 (ppc_ravenscar_e500_ops::fetch_registers)
11608 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11609 (ppc_ravenscar_e500_ops): Redefine.
11610 * aarch64-ravenscar-thread.c
11611 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11612 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11613 (aarch64_ravenscar_fetch_registers)
11614 (aarch64_ravenscar_store_registers): Now methods.
11615 (aarch64_ravenscar_ops): Redefine.
11616
5b6ea500
TT
116172019-02-15 Tom Tromey <tromey@adacore.com>
11618
11619 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11620 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11621 (ravenscar_thread_target::stopped_by_watchpoint)
11622 (ravenscar_thread_target::stopped_data_address)
11623 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11624
e397fd39
TT
116252019-02-15 Tom Tromey <tromey@adacore.com>
11626
11627 * ravenscar-thread.c: Fix some typos.
11628
cc12f4a8
TT
116292019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11630 Tom Tromey <tromey@adacore.com>
11631
11632 * ada-lang.c (ada_exception_sal): Change addr_string to a
11633 std::string.
11634 (create_ada_exception_catchpoint): Update.
11635
5f486660
TT
116362019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11637 Tom Tromey <tromey@adacore.com>
11638
11639 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11640 (bp_location_ops): Remove.
11641 (base_breakpoint_allocate_location): Update.
11642 (free_bp_location): Update.
11643 * ada-lang.c (class ada_catchpoint_location)
11644 <ada_catchpoint_location>: Remove ops parameter.
11645 (ada_catchpoint_location_dtor): Remove.
11646 (ada_catchpoint_location_ops): Remove.
11647 (allocate_location_exception): Update.
11648 * breakpoint.h (struct bp_location_ops): Remove.
11649 (class bp_location) <bp_location>: Remove bp_location_ops
11650 parameter.
11651 <~bp_location>: Add destructor.
11652 <ops>: Remove.
11653
b671c7fb
TS
116542019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11655 Pedro Alves <palves@redhat.com>
11656
11657 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11658 'PATH_MAX'.
11659
8071c5ce
DM
116602019-02-14 David Michael <fedora.dm0@gmail.com>
11661 Samuel Thibault <samuel.thibault@gnu.org>
11662 Thomas Schwinge <thomas@codesourcery.com>
11663
11664 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11665 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11666
b1041ae0
TS
116672019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11668
924514e1
TS
11669 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11670 (check_empty): Use "const char *".
11671
c29ee8d4
TS
11672 * gnu-nat.c (gnu_nat_target::detach): Instead of
11673 'detach_inferior (pid)' call
11674 'detach_inferior (find_inferior_pid (pid))'.
11675
6c6ef69f
TS
11676 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11677 'nat/fork-inferior.o'.
11678 * gnu-nat.c: #include "nat/fork-inferior.h".
11679
2d0a338c
TS
11680 * gnu-nat.c (gnu_nat_target::detach): Instead of
11681 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11682 * gnu-nat.h: #include "inf-child.h".
11683 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11684 'i386_gnu_nat_target::fetch_registers'.
11685 (gnu_store_registers): Rename/move to
11686 'i386_gnu_nat_target::store_registers'.
11687
cabb5f06
TS
11688 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11689 * gnu-nat.h (mach_thread_info): New function.
11690 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11691
b1041ae0
TS
11692 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11693
2988d01e
KF
116942019-02-14 Frederic Konrad <konrad@adacore.com>
11695
11696 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11697
c559d709
JB
116982019-02-14 Joel Brobecker <brobecker@adacore.com>
11699
11700 * windows-nat.c (windows_add_thread): Add new parameter
11701 "main_thread_p" with default value set to false. Update
11702 function documentation as well as all callers.
11703 (windows_delete_thread): Likewise.
11704 (fake_create_process): Update call to windows_add_thread.
11705 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11706 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11707 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11708 call to windows_delete_thread.
11709
007024cc
SM
117102019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11711
11712 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11713
f62318e9
JB
117142019-02-12 John Baldwin <jhb@FreeBSD.org>
11715
11716 * symfile.c (find_separate_debug_file): Use canonical path of
11717 sysroot with child_path instead of gdb_sysroot if it is valid.
11718
cd4b7848
JB
117192019-02-12 John Baldwin <jhb@FreeBSD.org>
11720
11721 * symfile.c (find_separate_debug_file): Use child_path to
11722 determine if an object file is under a sysroot.
11723
efac4bfe
JB
117242019-02-12 John Baldwin <jhb@FreeBSD.org>
11725
11726 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11727 unittests/child-path-selftests.c.
11728 * common/pathstuff.c (child_path): New function.
11729 * common/pathstuff.h (child_path): New prototype.
11730 * unittests/child-path-selftests.c: New file.
11731
402d2bfe
JB
117322019-02-12 John Baldwin <jhb@FreeBSD.org>
11733
11734 * symfile.c (find_separate_debug_file): Look for separate debug
11735 files in debug directories under the sysroot.
11736
1ed9f74e
PW
117372019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11738
11739 * symtab.h (struct minimal_symbol data_p): New const method.
11740 (struct minimal_symbol text_p): Likewise.
11741 * symtab.c (output_source_filename): Use file name style
11742 to print file name.
11743 (print_symbol_info): Likewise.
11744 (print_msymbol_info): Use address style to print addresses.
11745 Use function name style to print executable text symbols.
11746 (expand_symtab_containing_pc): Use data_p.
11747 (find_pc_sect_compunit_symtab): Likewise.
11748
2636d81d
PW
117492019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11750
11751 * breakpoint.c (describe_other_breakpoints): Use address style
11752 to print addresses.
11753 (say_where): Likewise.
11754
ac8c53cc
PW
117552019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11756
11757 * ada-typeprint.c (print_func_type): Print function name
11758 style to print function name.
11759 * c-typeprint.c (c_print_type_1): Likewise.
11760
ea638c43
AH
117612019-02-11 Alan Hayward <alan.hayward@arm.com>
11762
11763 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11764 for execve.
11765
ab759ca8
PW
117662019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11767
11768 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11769 type_stack.
11770
aff29d1c
JB
117712019-02-10 Joel Brobecker <brobecker@adacore.com>
11772
11773 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11774 TYPE_CODE_REF types.
11775
617126bc
JW
117762019-02-08 Jim Wilson <jimw@sifive.com>
11777
11778 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11779 (riscv_linux_fregset): New.
11780 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11781
46e3ed7f
TT
117822019-02-07 Tom Tromey <tom@tromey.com>
11783
11784 * thread.c (thread_cancel_execution_command): Update.
11785 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11786 methods.
11787 (struct thread_fsm_ops): Remove.
11788 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11789 (thread_fsm_should_stop, thread_fsm_return_value)
11790 (thread_fsm_set_finished, thread_fsm_finished_p)
11791 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11792 Don't declare.
11793 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11794 * infrun.c (clear_proceed_status_thread)
11795 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11796 (print_stop_event): Update.
11797 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11798 Add constructor.
11799 (step_command_fsm_ops): Remove.
11800 (new_step_command_fsm): Remove.
11801 (step_1): Update.
11802 (step_command_fsm::should_stop): Rename from
11803 step_command_fsm_should_stop.
11804 (step_command_fsm::clean_up): Rename from
11805 step_command_fsm_clean_up.
11806 (step_command_fsm::do_async_reply_reason): Rename from
11807 step_command_fsm_async_reply_reason.
11808 (struct until_next_fsm): Inherit from thread_fsm. Add
11809 constructor.
11810 (until_next_fsm_ops): Remove.
11811 (new_until_next_fsm): Remove.
11812 (until_next_fsm::should_stop): Rename from
11813 until_next_fsm_should_stop.
11814 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11815 (until_next_fsm::do_async_reply_reason): Rename from
11816 until_next_fsm_async_reply_reason.
11817 (struct finish_command_fsm): Inherit from thread_fsm. Add
11818 constructor. Change type of breakpoint.
11819 (finish_command_fsm_ops): Remove.
11820 (new_finish_command_fsm): Remove.
11821 (finish_command_fsm::should_stop): Rename from
11822 finish_command_fsm_should_stop.
11823 (finish_command_fsm::clean_up): Rename from
11824 finish_command_fsm_clean_up.
11825 (finish_command_fsm::return_value): Rename from
11826 finish_command_fsm_return_value.
11827 (finish_command_fsm::do_async_reply_reason): Rename from
11828 finish_command_fsm_async_reply_reason.
11829 (finish_command): Update.
11830 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11831 Add constructor.
11832 (call_thread_fsm_ops): Remove.
11833 (call_thread_fsm::call_thread_fsm): Rename from
11834 new_call_thread_fsm.
11835 (call_thread_fsm::should_stop): Rename from
11836 call_thread_fsm_should_stop.
11837 (call_thread_fsm::should_notify_stop): Rename from
11838 call_thread_fsm_should_notify_stop.
11839 (run_inferior_call, call_function_by_hand_dummy): Update.
11840 * cli/cli-interp.c (should_print_stop_to_console): Update.
11841 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11842 Add constructor. Change type of location_breakpoint,
11843 caller_breakpoint.
11844 (until_break_fsm_ops): Remove.
11845 (new_until_break_fsm): Remove.
11846 (until_break_fsm::should_stop): Rename from
11847 until_break_fsm_should_stop.
11848 (until_break_fsm::clean_up): Rename from
11849 until_break_fsm_clean_up.
11850 (until_break_fsm::do_async_reply_reason): Rename from
11851 until_break_fsm_async_reply_reason.
11852 (until_break_command): Update.
11853 * thread-fsm.c: Remove.
11854 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11855
1a5c2598
TT
118562019-02-07 Tom Tromey <tom@tromey.com>
11857
11858 * yy-remap.h: Add include guard.
11859 * xtensa-tdep.h: Add include guard.
11860 * xcoffread.h: Rename include guard.
11861 * varobj-iter.h: Add include guard.
11862 * tui/tui.h: Rename include guard.
11863 * tui/tui-winsource.h: Rename include guard.
11864 * tui/tui-wingeneral.h: Rename include guard.
11865 * tui/tui-windata.h: Rename include guard.
11866 * tui/tui-win.h: Rename include guard.
11867 * tui/tui-stack.h: Rename include guard.
11868 * tui/tui-source.h: Rename include guard.
11869 * tui/tui-regs.h: Rename include guard.
11870 * tui/tui-out.h: Rename include guard.
11871 * tui/tui-layout.h: Rename include guard.
11872 * tui/tui-io.h: Rename include guard.
11873 * tui/tui-hooks.h: Rename include guard.
11874 * tui/tui-file.h: Rename include guard.
11875 * tui/tui-disasm.h: Rename include guard.
11876 * tui/tui-data.h: Rename include guard.
11877 * tui/tui-command.h: Rename include guard.
11878 * tic6x-tdep.h: Add include guard.
11879 * target/waitstatus.h: Rename include guard.
11880 * target/wait.h: Rename include guard.
11881 * target/target.h: Rename include guard.
11882 * target/resume.h: Rename include guard.
11883 * target-float.h: Rename include guard.
11884 * stabsread.h: Add include guard.
11885 * rs6000-tdep.h: Add include guard.
11886 * riscv-fbsd-tdep.h: Add include guard.
11887 * regformats/regdef.h: Rename include guard.
11888 * record.h: Rename include guard.
11889 * python/python.h: Rename include guard.
11890 * python/python-internal.h: Rename include guard.
11891 * python/py-stopevent.h: Rename include guard.
11892 * python/py-ref.h: Rename include guard.
11893 * python/py-record.h: Rename include guard.
11894 * python/py-record-full.h: Rename include guard.
11895 * python/py-record-btrace.h: Rename include guard.
11896 * python/py-instruction.h: Rename include guard.
11897 * python/py-events.h: Rename include guard.
11898 * python/py-event.h: Rename include guard.
11899 * procfs.h: Add include guard.
11900 * proc-utils.h: Add include guard.
11901 * p-lang.h: Add include guard.
11902 * or1k-tdep.h: Rename include guard.
11903 * observable.h: Rename include guard.
11904 * nto-tdep.h: Rename include guard.
11905 * nat/x86-linux.h: Rename include guard.
11906 * nat/x86-linux-dregs.h: Rename include guard.
11907 * nat/x86-gcc-cpuid.h: Add include guard.
11908 * nat/x86-dregs.h: Rename include guard.
11909 * nat/x86-cpuid.h: Rename include guard.
11910 * nat/ppc-linux.h: Rename include guard.
11911 * nat/mips-linux-watch.h: Rename include guard.
11912 * nat/linux-waitpid.h: Rename include guard.
11913 * nat/linux-ptrace.h: Rename include guard.
11914 * nat/linux-procfs.h: Rename include guard.
11915 * nat/linux-osdata.h: Rename include guard.
11916 * nat/linux-nat.h: Rename include guard.
11917 * nat/linux-namespaces.h: Rename include guard.
11918 * nat/linux-btrace.h: Rename include guard.
11919 * nat/glibc_thread_db.h: Rename include guard.
11920 * nat/gdb_thread_db.h: Rename include guard.
11921 * nat/gdb_ptrace.h: Rename include guard.
11922 * nat/fork-inferior.h: Rename include guard.
11923 * nat/amd64-linux-siginfo.h: Rename include guard.
11924 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11925 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11926 * nat/aarch64-linux.h: Rename include guard.
11927 * nat/aarch64-linux-hw-point.h: Rename include guard.
11928 * mn10300-tdep.h: Add include guard.
11929 * mips-linux-tdep.h: Add include guard.
11930 * mi/mi-parse.h: Rename include guard.
11931 * mi/mi-out.h: Rename include guard.
11932 * mi/mi-main.h: Rename include guard.
11933 * mi/mi-interp.h: Rename include guard.
11934 * mi/mi-getopt.h: Rename include guard.
11935 * mi/mi-console.h: Rename include guard.
11936 * mi/mi-common.h: Rename include guard.
11937 * mi/mi-cmds.h: Rename include guard.
11938 * mi/mi-cmd-break.h: Rename include guard.
11939 * m2-lang.h: Add include guard.
11940 * location.h: Rename include guard.
11941 * linux-record.h: Rename include guard.
11942 * linux-nat.h: Add include guard.
11943 * linux-fork.h: Add include guard.
11944 * i386-darwin-tdep.h: Rename include guard.
11945 * hppa-linux-offsets.h: Add include guard.
11946 * guile/guile.h: Rename include guard.
11947 * guile/guile-internal.h: Rename include guard.
11948 * gnu-nat.h: Rename include guard.
11949 * gdb-stabs.h: Rename include guard.
11950 * frv-tdep.h: Add include guard.
11951 * f-lang.h: Add include guard.
11952 * event-loop.h: Add include guard.
11953 * darwin-nat.h: Rename include guard.
11954 * cp-abi.h: Rename include guard.
11955 * config/sparc/nm-sol2.h: Rename include guard.
11956 * config/nm-nto.h: Rename include guard.
11957 * config/nm-linux.h: Add include guard.
11958 * config/i386/nm-i386gnu.h: Rename include guard.
11959 * config/djgpp/nl_types.h: Rename include guard.
11960 * config/djgpp/langinfo.h: Rename include guard.
11961 * compile/gcc-cp-plugin.h: Add include guard.
11962 * compile/gcc-c-plugin.h: Add include guard.
11963 * compile/compile.h: Rename include guard.
11964 * compile/compile-object-run.h: Rename include guard.
11965 * compile/compile-object-load.h: Rename include guard.
11966 * compile/compile-internal.h: Rename include guard.
11967 * compile/compile-cplus.h: Rename include guard.
11968 * compile/compile-c.h: Rename include guard.
11969 * common/xml-utils.h: Rename include guard.
11970 * common/x86-xstate.h: Rename include guard.
11971 * common/version.h: Rename include guard.
11972 * common/vec.h: Rename include guard.
11973 * common/tdesc.h: Rename include guard.
11974 * common/selftest.h: Rename include guard.
11975 * common/scoped_restore.h: Rename include guard.
11976 * common/scoped_mmap.h: Rename include guard.
11977 * common/scoped_fd.h: Rename include guard.
11978 * common/safe-iterator.h: Rename include guard.
11979 * common/run-time-clock.h: Rename include guard.
11980 * common/refcounted-object.h: Rename include guard.
11981 * common/queue.h: Rename include guard.
11982 * common/ptid.h: Rename include guard.
11983 * common/print-utils.h: Rename include guard.
11984 * common/preprocessor.h: Rename include guard.
11985 * common/pathstuff.h: Rename include guard.
11986 * common/observable.h: Rename include guard.
11987 * common/netstuff.h: Rename include guard.
11988 * common/job-control.h: Rename include guard.
11989 * common/host-defs.h: Rename include guard.
11990 * common/gdb_wait.h: Rename include guard.
11991 * common/gdb_vecs.h: Rename include guard.
11992 * common/gdb_unlinker.h: Rename include guard.
11993 * common/gdb_unique_ptr.h: Rename include guard.
11994 * common/gdb_tilde_expand.h: Rename include guard.
11995 * common/gdb_sys_time.h: Rename include guard.
11996 * common/gdb_string_view.h: Rename include guard.
11997 * common/gdb_splay_tree.h: Rename include guard.
11998 * common/gdb_setjmp.h: Rename include guard.
11999 * common/gdb_ref_ptr.h: Rename include guard.
12000 * common/gdb_optional.h: Rename include guard.
12001 * common/gdb_locale.h: Rename include guard.
12002 * common/gdb_assert.h: Rename include guard.
12003 * common/filtered-iterator.h: Rename include guard.
12004 * common/filestuff.h: Rename include guard.
12005 * common/fileio.h: Rename include guard.
12006 * common/environ.h: Rename include guard.
12007 * common/common-utils.h: Rename include guard.
12008 * common/common-types.h: Rename include guard.
12009 * common/common-regcache.h: Rename include guard.
12010 * common/common-inferior.h: Rename include guard.
12011 * common/common-gdbthread.h: Rename include guard.
12012 * common/common-exceptions.h: Rename include guard.
12013 * common/common-defs.h: Rename include guard.
12014 * common/common-debug.h: Rename include guard.
12015 * common/cleanups.h: Rename include guard.
12016 * common/buffer.h: Rename include guard.
12017 * common/btrace-common.h: Rename include guard.
12018 * common/break-common.h: Rename include guard.
12019 * cli/cli-utils.h: Rename include guard.
12020 * cli/cli-style.h: Rename include guard.
12021 * cli/cli-setshow.h: Rename include guard.
12022 * cli/cli-script.h: Rename include guard.
12023 * cli/cli-interp.h: Rename include guard.
12024 * cli/cli-decode.h: Rename include guard.
12025 * cli/cli-cmds.h: Rename include guard.
12026 * charset-list.h: Add include guard.
12027 * buildsym-legacy.h: Rename include guard.
12028 * bfin-tdep.h: Add include guard.
12029 * ax.h: Rename include guard.
12030 * arm-linux-tdep.h: Add include guard.
12031 * arm-fbsd-tdep.h: Add include guard.
12032 * arch/xtensa.h: Rename include guard.
12033 * arch/tic6x.h: Add include guard.
12034 * arch/i386.h: Add include guard.
12035 * arch/arm.h: Rename include guard.
12036 * arch/arm-linux.h: Rename include guard.
12037 * arch/arm-get-next-pcs.h: Rename include guard.
12038 * arch/amd64.h: Add include guard.
12039 * arch/aarch64-insn.h: Rename include guard.
12040 * arch-utils.h: Rename include guard.
12041 * annotate.h: Add include guard.
12042 * amd64-darwin-tdep.h: Rename include guard.
12043 * aarch64-linux-tdep.h: Add include guard.
12044 * aarch64-fbsd-tdep.h: Add include guard.
12045 * aarch32-linux-nat.h: Add include guard.
12046
ab9268d2
PW
120472019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12048
12049 * macrotab.c (macro_define_internal): New function that
12050 factorizes macro_define_object_internal and macro_define_function
12051 code.
12052 (macro_define_object_internal): Use macro_define_internal.
12053 (macro_define_function): Likewise.
12054
bb0da2b4
PW
120552019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12056
12057 * macrocmd.c (extract_identifier): Return
12058 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12059 callers.
12060
424eb552
JB
120612019-02-06 John Baldwin <jhb@FreeBSD.org>
12062
12063 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12064
1688cb29
TT
120652019-02-05 Tom Tromey <tom@tromey.com>
12066
12067 * target.c (target_stack::unpush): Move assertion earlier.
12068
b5eba2d8
TT
120692019-01-30 Tom Tromey <tom@tromey.com>
12070
12071 PR python/23615:
12072 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12073 (gdbpy_parse_and_eval): Likewise.
12074 * python/python-internal.h (gdbpy_allow_threads): New class.
12075
7054e2ff
JB
120762019-01-28 John Baldwin <jhb@FreeBSD.org>
12077
12078 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12079 (aarch64_fbsd_fpregmap): Move earlier.
12080 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12081 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12082 instead of individual calls to trad_frame_set_reg_addr.
12083 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12084 earlier.
12085 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12086 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12087 instead of individual calls to trad_frame_set_reg_addr.
12088
36c25ffa
AH
120892019-01-28 Alan Hayward <alan.hayward@arm.com>
12090
12091 * CONTRIBUTE: Replace contribution list with wiki link.
12092
a0707f3c
TT
120932019-01-25 Tom Tromey <tom@tromey.com>
12094
12095 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12096
0747795c
TT
120972019-01-25 Tom Tromey <tom@tromey.com>
12098
12099 * xtensa-linux-nat.c: Fix common/ includes.
12100 * xml-support.h: Fix common/ includes.
12101 * xml-support.c: Fix common/ includes.
12102 * x86-linux-nat.c: Fix common/ includes.
12103 * windows-nat.c: Fix common/ includes.
12104 * varobj.h: Fix common/ includes.
12105 * varobj.c: Fix common/ includes.
12106 * value.c: Fix common/ includes.
12107 * valops.c: Fix common/ includes.
12108 * utils.c: Fix common/ includes.
12109 * unittests/xml-utils-selftests.c: Fix common/ includes.
12110 * unittests/utils-selftests.c: Fix common/ includes.
12111 * unittests/unpack-selftests.c: Fix common/ includes.
12112 * unittests/tracepoint-selftests.c: Fix common/ includes.
12113 * unittests/style-selftests.c: Fix common/ includes.
12114 * unittests/string_view-selftests.c: Fix common/ includes.
12115 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12116 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12117 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12118 * unittests/rsp-low-selftests.c: Fix common/ includes.
12119 * unittests/parse-connection-spec-selftests.c: Fix common/
12120 includes.
12121 * unittests/optional-selftests.c: Fix common/ includes.
12122 * unittests/offset-type-selftests.c: Fix common/ includes.
12123 * unittests/observable-selftests.c: Fix common/ includes.
12124 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12125 * unittests/memrange-selftests.c: Fix common/ includes.
12126 * unittests/memory-map-selftests.c: Fix common/ includes.
12127 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12128 * unittests/function-view-selftests.c: Fix common/ includes.
12129 * unittests/environ-selftests.c: Fix common/ includes.
12130 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12131 * unittests/common-utils-selftests.c: Fix common/ includes.
12132 * unittests/cli-utils-selftests.c: Fix common/ includes.
12133 * unittests/array-view-selftests.c: Fix common/ includes.
12134 * ui-file.c: Fix common/ includes.
12135 * tui/tui-io.c: Fix common/ includes.
12136 * tracepoint.h: Fix common/ includes.
12137 * tracepoint.c: Fix common/ includes.
12138 * tracefile-tfile.c: Fix common/ includes.
12139 * top.h: Fix common/ includes.
12140 * top.c: Fix common/ includes.
12141 * thread.c: Fix common/ includes.
12142 * target/waitstatus.h: Fix common/ includes.
12143 * target/waitstatus.c: Fix common/ includes.
12144 * target.h: Fix common/ includes.
12145 * target.c: Fix common/ includes.
12146 * target-memory.c: Fix common/ includes.
12147 * target-descriptions.c: Fix common/ includes.
12148 * symtab.h: Fix common/ includes.
12149 * symfile.c: Fix common/ includes.
12150 * stap-probe.c: Fix common/ includes.
12151 * spu-linux-nat.c: Fix common/ includes.
12152 * sparc-nat.c: Fix common/ includes.
12153 * source.c: Fix common/ includes.
12154 * solib.c: Fix common/ includes.
12155 * solib-target.c: Fix common/ includes.
12156 * ser-unix.c: Fix common/ includes.
12157 * ser-tcp.c: Fix common/ includes.
12158 * ser-pipe.c: Fix common/ includes.
12159 * ser-base.c: Fix common/ includes.
12160 * selftest-arch.c: Fix common/ includes.
12161 * s12z-tdep.c: Fix common/ includes.
12162 * rust-exp.y: Fix common/ includes.
12163 * rs6000-aix-tdep.c: Fix common/ includes.
12164 * riscv-tdep.c: Fix common/ includes.
12165 * remote.c: Fix common/ includes.
12166 * remote-notif.h: Fix common/ includes.
12167 * remote-fileio.h: Fix common/ includes.
12168 * remote-fileio.c: Fix common/ includes.
12169 * regcache.h: Fix common/ includes.
12170 * regcache.c: Fix common/ includes.
12171 * record-btrace.c: Fix common/ includes.
12172 * python/python.c: Fix common/ includes.
12173 * python/py-type.c: Fix common/ includes.
12174 * python/py-inferior.c: Fix common/ includes.
12175 * progspace.h: Fix common/ includes.
12176 * producer.c: Fix common/ includes.
12177 * procfs.c: Fix common/ includes.
12178 * proc-api.c: Fix common/ includes.
12179 * printcmd.c: Fix common/ includes.
12180 * ppc-linux-nat.c: Fix common/ includes.
12181 * parser-defs.h: Fix common/ includes.
12182 * osdata.c: Fix common/ includes.
12183 * obsd-nat.c: Fix common/ includes.
12184 * nat/x86-linux.c: Fix common/ includes.
12185 * nat/x86-linux-dregs.c: Fix common/ includes.
12186 * nat/x86-dregs.h: Fix common/ includes.
12187 * nat/x86-dregs.c: Fix common/ includes.
12188 * nat/ppc-linux.c: Fix common/ includes.
12189 * nat/mips-linux-watch.h: Fix common/ includes.
12190 * nat/mips-linux-watch.c: Fix common/ includes.
12191 * nat/linux-waitpid.c: Fix common/ includes.
12192 * nat/linux-ptrace.h: Fix common/ includes.
12193 * nat/linux-ptrace.c: Fix common/ includes.
12194 * nat/linux-procfs.c: Fix common/ includes.
12195 * nat/linux-personality.c: Fix common/ includes.
12196 * nat/linux-osdata.c: Fix common/ includes.
12197 * nat/linux-namespaces.c: Fix common/ includes.
12198 * nat/linux-btrace.h: Fix common/ includes.
12199 * nat/linux-btrace.c: Fix common/ includes.
12200 * nat/fork-inferior.c: Fix common/ includes.
12201 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12202 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12203 * nat/aarch64-linux.c: Fix common/ includes.
12204 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12205 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12206 * namespace.h: Fix common/ includes.
12207 * mips-linux-tdep.c: Fix common/ includes.
12208 * minsyms.c: Fix common/ includes.
12209 * mi/mi-parse.h: Fix common/ includes.
12210 * mi/mi-main.c: Fix common/ includes.
12211 * mi/mi-cmd-env.c: Fix common/ includes.
12212 * memrange.h: Fix common/ includes.
12213 * memattr.c: Fix common/ includes.
12214 * maint.h: Fix common/ includes.
12215 * maint.c: Fix common/ includes.
12216 * main.c: Fix common/ includes.
12217 * machoread.c: Fix common/ includes.
12218 * location.c: Fix common/ includes.
12219 * linux-thread-db.c: Fix common/ includes.
12220 * linux-nat.c: Fix common/ includes.
12221 * linux-fork.c: Fix common/ includes.
12222 * inline-frame.c: Fix common/ includes.
12223 * infrun.c: Fix common/ includes.
12224 * inflow.c: Fix common/ includes.
12225 * inferior.h: Fix common/ includes.
12226 * inferior.c: Fix common/ includes.
12227 * infcmd.c: Fix common/ includes.
12228 * inf-ptrace.c: Fix common/ includes.
12229 * inf-child.c: Fix common/ includes.
12230 * ia64-linux-nat.c: Fix common/ includes.
12231 * i387-tdep.c: Fix common/ includes.
12232 * i386-tdep.c: Fix common/ includes.
12233 * i386-linux-tdep.c: Fix common/ includes.
12234 * i386-linux-nat.c: Fix common/ includes.
12235 * i386-go32-tdep.c: Fix common/ includes.
12236 * i386-fbsd-tdep.c: Fix common/ includes.
12237 * i386-fbsd-nat.c: Fix common/ includes.
12238 * guile/scm-type.c: Fix common/ includes.
12239 * guile/guile.c: Fix common/ includes.
12240 * go32-nat.c: Fix common/ includes.
12241 * gnu-nat.c: Fix common/ includes.
12242 * gdbthread.h: Fix common/ includes.
12243 * gdbarch-selftests.c: Fix common/ includes.
12244 * gdb_usleep.c: Fix common/ includes.
12245 * gdb_select.h: Fix common/ includes.
12246 * gdb_bfd.c: Fix common/ includes.
12247 * gcore.c: Fix common/ includes.
12248 * fork-child.c: Fix common/ includes.
12249 * findvar.c: Fix common/ includes.
12250 * fbsd-nat.c: Fix common/ includes.
12251 * event-top.c: Fix common/ includes.
12252 * event-loop.c: Fix common/ includes.
12253 * dwarf2read.c: Fix common/ includes.
12254 * dwarf2loc.c: Fix common/ includes.
12255 * dwarf2-frame.c: Fix common/ includes.
12256 * dwarf-index-cache.c: Fix common/ includes.
12257 * dtrace-probe.c: Fix common/ includes.
12258 * disasm-selftests.c: Fix common/ includes.
12259 * defs.h: Fix common/ includes.
12260 * csky-tdep.c: Fix common/ includes.
12261 * cp-valprint.c: Fix common/ includes.
12262 * cp-support.h: Fix common/ includes.
12263 * cp-support.c: Fix common/ includes.
12264 * corelow.c: Fix common/ includes.
12265 * completer.h: Fix common/ includes.
12266 * completer.c: Fix common/ includes.
12267 * compile/compile.c: Fix common/ includes.
12268 * compile/compile-loc2c.c: Fix common/ includes.
12269 * compile/compile-cplus-types.c: Fix common/ includes.
12270 * compile/compile-cplus-symbols.c: Fix common/ includes.
12271 * command.h: Fix common/ includes.
12272 * cli/cli-dump.c: Fix common/ includes.
12273 * cli/cli-cmds.c: Fix common/ includes.
12274 * charset.c: Fix common/ includes.
12275 * build-id.c: Fix common/ includes.
12276 * btrace.h: Fix common/ includes.
12277 * btrace.c: Fix common/ includes.
12278 * breakpoint.h: Fix common/ includes.
12279 * breakpoint.c: Fix common/ includes.
12280 * ax.h:
12281 (enum agent_op): Fix common/ includes.
12282 * ax-general.c (struct aop_map): Fix common/ includes.
12283 * ax-gdb.c: Fix common/ includes.
12284 * auxv.c: Fix common/ includes.
12285 * auto-load.c: Fix common/ includes.
12286 * arm-tdep.c: Fix common/ includes.
12287 * arch/riscv.c: Fix common/ includes.
12288 * arch/ppc-linux-common.c: Fix common/ includes.
12289 * arch/i386.c: Fix common/ includes.
12290 * arch/arm.c: Fix common/ includes.
12291 * arch/arm-linux.c: Fix common/ includes.
12292 * arch/arm-get-next-pcs.c: Fix common/ includes.
12293 * arch/amd64.c: Fix common/ includes.
12294 * arch/aarch64.c: Fix common/ includes.
12295 * arch/aarch64-insn.c: Fix common/ includes.
12296 * arch-utils.c: Fix common/ includes.
12297 * amd64-windows-tdep.c: Fix common/ includes.
12298 * amd64-tdep.c: Fix common/ includes.
12299 * amd64-sol2-tdep.c: Fix common/ includes.
12300 * amd64-obsd-tdep.c: Fix common/ includes.
12301 * amd64-nbsd-tdep.c: Fix common/ includes.
12302 * amd64-linux-tdep.c: Fix common/ includes.
12303 * amd64-linux-nat.c: Fix common/ includes.
12304 * amd64-fbsd-tdep.c: Fix common/ includes.
12305 * amd64-fbsd-nat.c: Fix common/ includes.
12306 * amd64-dicos-tdep.c: Fix common/ includes.
12307 * amd64-darwin-tdep.c: Fix common/ includes.
12308 * agent.c: Fix common/ includes.
12309 * ada-lang.h: Fix common/ includes.
12310 * ada-lang.c: Fix common/ includes.
12311 * aarch64-tdep.c: Fix common/ includes.
12312
2f5c153e
TT
123132019-01-25 Tom Tromey <tom@tromey.com>
12314
12315 * common/create-version.sh: Use common/version.h.
12316
adc6a863
PA
123172019-01-24 Pedro Alves <palves@redhat.com>
12318
12319 * infrun.c (signal_stop, signal_print, signal_program)
12320 (signal_catch, signal_pass): Now arrays instead of pointers.
12321 (update_signals_program_target, do_target_resume)
12322 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12323 * linux-nat.c (linux_nat_target::pass_signals)
12324 (linux_nat_target::create_inferior, linux_nat_target::attach):
12325 Adjust.
12326 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12327 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12328 * procfs.c (procfs_target::pass_signals): Adjust.
12329 * record-full.c (record_full_target::resume): Adjust.
12330 * remote.c (remote_target::pass_signals)
12331 (remote_target::program_signals): Adjust.
12332 * target-debug.h (target_debug_print_signals): Now takes a
12333 gdb::array_view as parameter. Adjust.
12334 * target.h (target_ops) <pass_signals, program_signals>: Replace
12335 pointer and length parameters with gdb::array_view.
12336 (target_pass_signals, target_program_signals): Likewise.
12337 * target-delegates.c: Regenerate.
12338
3046d67a
PA
123392019-01-24 Pedro Alves <palves@redhat.com>
12340
12341 * common/forward-scope-exit.h
12342 (forward_scope_exit::forward_scope_exit): Pass arguments to
12343 m_bind_function directly, instead of creating a std::bind and
12344 copying that.
12345
353229bf
AH
123462019-01-24 Alan Hayward <alan.hayward@arm.com>
12347
12348 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12349 for static members.
12350 (pass_in_v_vfp_candidate): Likewise.
12351
311dc83a
TT
123522019-01-23 Tom Tromey <tom@tromey.com>
12353 Pedro Alves <palves@redhat.com>
12354
12355 * regcache.c (class regcache_invalidator): Remove.
12356 (regcache::raw_write): Use make_scope_exit.
12357
296bd123
TT
123582019-01-23 Tom Tromey <tom@tromey.com>
12359
12360 * ui-out.h (class ui_out_emit_type): Update comment.
12361
979a0d13
TT
123622019-01-23 Tom Tromey <tom@tromey.com>
12363
12364 * infrun.c (fetch_inferior_event): Update comment.
12365
d238133d
TT
123662019-01-23 Tom Tromey <tom@tromey.com>
12367 Pedro Alves <palves@redhat.com>
12368
12369 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12370 parameter.
12371 (fetch_inferior_event): Use SCOPE_EXIT.
12372
12373
9885e6bb
TT
123742019-01-23 Tom Tromey <tom@tromey.com>
12375 Pedro Alves <palves@redhat.com>
12376
12377 * infrun.c (disable_thread_events): Delete.
12378 (stop_all_threads): Use SCOPE_EXIT.
12379
286526c1
TT
123802019-01-23 Tom Tromey <tom@tromey.com>
12381 Pedro Alves <palves@redhat.com>
12382
12383 * symfile.c: Include forward-scope-exit.h.
12384 (clear_symtab_users_cleanup): Replace forward declaration with
12385 a FORWARD_SCOPE_EXIT.
12386 (syms_from_objfile_1): Use the forward_scope_exit and
12387 gdb::optional instead of cleanup_function.
12388 (reread_symbols): Use the forward_scope_exit instead of
12389 cleanup_function.
12390 (clear_symtab_users_cleanup): Remove function.
12391
1db93f14
TT
123922019-01-23 Tom Tromey <tom@tromey.com>
12393 Pedro Alves <palves@redhat.com>
12394
12395 * linux-nat.c: Include scope-exit.h.
12396 (cleanup_target_stop): Remove.
12397 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12398 SCOPE_EXIT.
12399
2cc83d1e
TT
124002019-01-23 Tom Tromey <tom@tromey.com>
12401 Pedro Alves <palves@redhat.com>
12402
12403 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12404 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12405
694c6bf5
TT
124062019-01-23 Tom Tromey <tom@tromey.com>
12407 Andrew Burgess <andrew.burgess@embecosm.com>
12408 Pedro Alves <palves@redhat.com>
12409
12410 * infrun.c (fetch_inferior_event): Use scope_exit.
12411 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12412 * top.c (execute_command): Use scope_exit.
12413 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12414 * utils.c (do_bpstat_clear_actions_cleanup)
12415 (make_bpstat_clear_actions_cleanup): Remove.
12416
4c41382a
TT
124172019-01-23 Tom Tromey <tom@tromey.com>
12418 Pedro Alves <palves@redhat.com>
12419
12420 * infrun.c: Include "common/scope-exit.h"
12421 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12422 (wait_for_inferior): Use SCOPE_EXIT.
12423 (fetch_inferior_event): Use scope_exit.
12424
89f8fb50
TT
124252019-01-23 Tom Tromey <tom@tromey.com>
12426 Pedro Alves <palves@redhat.com>
12427
12428 * breakpoint.c (create_breakpoint): Remove cleanup.
12429
5419bdae
TT
124302019-01-23 Tom Tromey <tom@tromey.com>
12431 Andrew Burgess <andrew.burgess@embecosm.com>
12432 Pedro Alves <palves@redhat.com>
12433
e587ef42
PA
124342019-01-23 Pedro Alves <palves@redhat.com>
12435
12436 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12437
77f0e74c
PA
124382019-01-23 Pedro Alves <palves@redhat.com>
12439 Andrew Burgess <andrew.burgess@embecosm.com>
12440
12441 * gdbthread.h: Include "common/forward-scope-exit.h".
12442 (scoped_finish_thread_state): Redefine custom class in terms of
12443 forward_scope_exit.
12444
5b9b3e53
PA
124452019-01-23 Pedro Alves <palves@redhat.com>
12446 Andrew Burgess <andrew.burgess@embecosm.com>
12447
12448 * common/forward-scope-exit.h: New file.
12449
54b65c9b
PA
124502019-01-23 Pedro Alves <palves@redhat.com>
12451 Andrew Burgess <andrew.burgess@embecosm.com>
12452 Tom Tromey <tom@tromey.com>
12453
12454 * common/scope-exit.h: New file.
12455
cf08fb29
PA
124562019-01-23 Pedro Alves <palves@redhat.com>
12457
12458 * common/preprocessor.h (ESC): Rename to ...
12459 (ESC_PARENS): ... this.
12460 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12461 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12462
ae73e2e2
TT
124632019-01-23 Tom Tromey <tom@tromey.com>
12464
12465 * language.h (class scoped_switch_to_sym_language_if_auto):
12466 Initialize m_lang in both cases.
12467
6594e122
AH
124682019-01-23 Alan Hayward <alan.hayward@arm.com>
12469
12470 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12471 with XCNEW.
12472
a7c9855d
TT
124732019-01-22 Tom Tromey <tom@tromey.com>
12474
12475 * corelow.c: Do not include sys/file.h.
12476
93cc1d53
TT
124772019-01-22 Tom Tromey <tom@tromey.com>
12478
12479 * tui/tui-wingeneral.h: Include gdb_curses.h.
12480
38561778
TT
124812019-01-22 Tom Tromey <tom@tromey.com>
12482
12483 * source-cache.h (class source_cache) <get_source_lines,
12484 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12485
37b3ab5b
TT
124862019-01-22 Tom Tromey <tom@tromey.com>
12487
12488 * remote-fileio.h (struct remote_target): Declare.
12489
3fabc016
TT
124902019-01-22 Tom Tromey <tom@tromey.com>
12491
12492 * python/py-arch.c: Do not include py-ref.h.
12493 * python/py-bpevent.c: Do not include py-ref.h.
12494 * python/py-cmd.c: Do not include py-ref.h.
12495 * python/py-continueevent.c: Do not include py-ref.h.
12496 * python/py-event.h: Do not include py-ref.h.
12497 * python/py-evtregistry.c: Do not include py-ref.h.
12498 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12499 * python/py-frame.c: Do not include py-ref.h.
12500 * python/py-framefilter.c: Do not include py-ref.h.
12501 * python/py-function.c: Do not include py-ref.h.
12502 * python/py-infevents.c: Do not include py-ref.h.
12503 * python/py-linetable.c: Do not include py-ref.h.
12504 * python/py-objfile.c: Do not include py-ref.h.
12505 * python/py-param.c: Do not include py-ref.h.
12506 * python/py-prettyprint.c: Do not include py-ref.h.
12507 * python/py-progspace.c: Do not include py-ref.h.
12508 * python/py-symbol.c: Do not include py-ref.h.
12509 * python/py-symtab.c: Do not include py-ref.h.
12510 * python/py-type.c: Do not include py-ref.h.
12511 * python/py-unwind.c: Do not include py-ref.h.
12512 * python/py-utils.c: Do not include py-ref.h.
12513 * python/py-value.c: Do not include py-ref.h.
12514 * python/py-varobj.c: Do not include py-ref.h.
12515 * python/py-xmethods.c: Do not include py-ref.h.
12516 * python/python.c: Do not include py-ref.h.
12517 * varobj.c: Do not include py-ref.h.
12518
6b4d7774
TT
125192019-01-22 Tom Tromey <tom@tromey.com>
12520
12521 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12522 keyword for bcache.
12523
7af7e9b5
TT
125242019-01-22 Tom Tromey <tom@tromey.com>
12525
12526 * compile/compile-cplus-types.c: Remove a comment by #include.
12527
951d1049
TT
125282019-01-22 Tom Tromey <tom@tromey.com>
12529
12530 * compile/gcc-c-plugin.h: Include compile-internal.h.
12531
d65d5705
TT
125322019-01-22 Tom Tromey <tom@tromey.com>
12533
12534 * stabsread.c (EXTERN): Do not define.
12535 (symnum, next_symbol_text_func, processing_gcc_compilation)
12536 (within_function, global_sym_chain, global_stabs)
12537 (previous_stab_code, this_object_header_files)
12538 (n_this_object_header_files)
12539 (n_allocated_this_object_header_files): Define.
12540 * stabsread.h (EXTERN): Never define. Use "extern".
12541
b6fb1ee5
PW
125422019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12543
12544 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12545 history_value.
12546
be6d4f74
TT
125472019-01-21 Tom Tromey <tom@tromey.com>
12548
12549 * ui-out.c: Fix includes.
12550 * tui/tui-source.c: Fix includes.
12551 * target.c: Fix includes.
12552 * remote.c: Fix includes.
12553 * regcache.c: Fix includes.
12554 * python/py-block.c: Fix includes.
12555 * printcmd.c: Fix includes.
12556 * or1k-tdep.c: Fix includes.
12557 * mi/mi-main.c: Fix includes.
12558 * m32r-tdep.c: Fix includes.
12559 * csky-tdep.c: Fix includes.
12560 * compile/compile-cplus-types.c: Fix includes.
12561 * cli/cli-interp.c: Fix includes.
12562
73021deb
AH
125632019-01-21 Alan Hayward <alan.hayward@arm.com>
12564
12565 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12566 for padding.
12567
7932255d
TT
125682019-01-16 Tom Tromey <tom@tromey.com>
12569
12570 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12571 earlier.
12572 (struct objfile) <msymbols_range>: Move from top level.
12573 <msymbols>: New method.
12574 (class objfile_msymbols): Remove.
12575 * symtab.c (default_collect_symbol_completion_matches_break_on):
12576 Update.
12577 * symmisc.c (dump_msymbols): Update.
12578 * stabsread.c (scan_file_globals): Update.
12579 * objc-lang.c (info_selectors_command, info_classes_command)
12580 (find_methods): Update.
12581 * minsyms.c (find_solib_trampoline_target): Update.
12582 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12583 * coffread.c (coff_symfile_read): Update.
12584 * ada-lang.c (ada_lookup_simple_minsym)
12585 (ada_collect_symbol_completion_matches): Update.
12586
604b1bfb
TT
125872019-01-16 Tom Tromey <tom@tromey.com>
12588
12589 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12590 type. Remove no-argument constructor.
12591 <iterator::operator++>: Simplify.
12592 <begin>: Update.
12593 <end>: Use minimal_symbol_count.
12594
f252c6d5
TT
125952019-01-16 Tom Tromey <tom@tromey.com>
12596
12597 * objfiles.h (struct objfile) <psymtabs>: New method.
12598 (class objfile_psymtabs): Remove.
12599 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12600 typedef.
12601 <range>: New method.
12602 (require_partial_symbols): Change return type.
12603 * psymtab.c (require_partial_symbols)
12604 (psym_expand_symtabs_matching): Update.
12605 * mdebugread.c (parse_partial_symbols): Update.
12606 * dbxread.c (dbx_end_psymtab): Update.
12607
b669c953
TT
126082019-01-15 Tom Tromey <tom@tromey.com>
12609
12610 * symtab.c (lookup_objfile_from_block)
12611 (lookup_symbol_in_objfile_symtabs)
12612 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12613 (find_line_symtab, info_sources_command)
12614 (default_collect_symbol_completion_matches_break_on)
12615 (make_source_files_completion_list): Update.
12616 * symmisc.c (print_objfile_statistics, dump_objfile)
12617 (maintenance_print_symbols, maintenance_info_symtabs)
12618 (maintenance_check_symtabs, maintenance_info_line_tables):
12619 Update.
12620 * source.c (select_source_symtab)
12621 (forget_cached_source_info_for_objfile): Update.
12622 * objfiles.h (class objfile_compunits): Remove.
12623 (struct objfile) <compunits_range>: New typedef.
12624 (compunits): New method.
12625 * objfiles.c (objfile_relocate1): Update.
12626 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12627 * maint.c (count_symtabs_and_blocks): Update.
12628 * linespec.c (iterate_over_all_matching_symtabs): Update.
12629 * cp-support.c (add_symbol_overload_list_qualified): Update.
12630 * coffread.c (coff_symtab_read): Update.
12631 * ada-lang.c (add_nonlocal_symbols)
12632 (ada_collect_symbol_completion_matches)
12633 (ada_add_global_exceptions): Update.
12634
7e955d83
TT
126352019-01-15 Tom Tromey <tom@tromey.com>
12636
12637 * progspace.h (program_space) <objfiles_safe_range>: New
12638 typedef.
12639 <objfiles_safe>: New method.
12640 * objfiles.h (class all_objfiles_safe): Remove.
12641 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12642 * jit.c (jit_inferior_exit_hook): Update.
12643
2030c079
TT
126442019-01-17 Tom Tromey <tom@tromey.com>
12645
12646 * progspace.h (program_space) <objfiles_range>: New typedef.
12647 <objfiles>: New method.
12648 <objfiles_head>: Rename from objfiles.
12649 (object_files): Update.
12650 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12651 * guile/scm-pretty-print.c
12652 (ppscm_find_pretty_printer_from_objfiles): Update.
12653 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12654 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12655 Update.
12656 * python/py-progspace.c (pspy_get_objfiles): Update.
12657 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12658 Update.
12659 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12660 (objfpy_lookup_objfile_by_build_id): Update.
12661 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12662 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12663 Update.
12664 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12665 (expand_symtab_containing_pc, lookup_objfile_from_block)
12666 (lookup_static_symbol, basic_lookup_transparent_type)
12667 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12668 (find_line_symtab, info_sources_command)
12669 (default_collect_symbol_completion_matches_break_on)
12670 (make_source_files_completion_list, find_main_name): Update.
12671 * symmisc.c (print_symbol_bcache_statistics)
12672 (print_objfile_statistics, maintenance_print_symbols)
12673 (maintenance_print_msymbols, maintenance_print_objfiles)
12674 (maintenance_info_symtabs, maintenance_check_symtabs)
12675 (maintenance_expand_symtabs, maintenance_info_line_tables):
12676 Update.
12677 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12678 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12679 (map_overlay_command, unmap_overlay_command)
12680 (simple_overlay_update, expand_symtabs_matching)
12681 (map_symbol_filenames): Update.
12682 * symfile-debug.c (set_debug_symfile): Update.
12683 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12684 Update.
12685 * source.c (select_source_symtab, forget_cached_source_info):
12686 Update.
12687 * solib.c (solib_read_symbols): Update.
12688 * solib-spu.c (append_ocl_sos): Update.
12689 * psymtab.c (maintenance_print_psymbols)
12690 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12691 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12692 * printcmd.c (info_symbol_command): Update.
12693 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12694 Update.
12695 * objfiles.h (class all_objfiles): Remove.
12696 * objfiles.c (have_partial_symbols, have_full_symbols)
12697 (have_minimal_symbols, qsort_cmp, update_section_map)
12698 (shared_objfile_contains_address_p)
12699 (default_iterate_over_objfiles_in_search_order): Update.
12700 * objc-lang.c (info_selectors_command, info_classes_command)
12701 (find_methods): Update.
12702 * minsyms.c (find_solib_trampoline_target): Update.
12703 * maint.c (maintenance_info_sections)
12704 (maintenance_translate_address, count_symtabs_and_blocks):
12705 Update.
12706 * main.c (captured_main_1): Update.
12707 * linux-thread-db.c (try_thread_db_load_from_pdir)
12708 (has_libpthread): Update.
12709 * linespec.c (iterate_over_all_matching_symtabs)
12710 (search_minsyms_for_name): Update.
12711 * jit.c (jit_find_objf_with_entry_addr): Update.
12712 * hppa-tdep.c (find_unwind_entry)
12713 (hppa_lookup_stub_minimal_symbol): Update.
12714 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12715 Update.
12716 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12717 (elf_gnu_ifunc_resolve_by_got): Update.
12718 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12719 * dwarf-index-write.c (save_gdb_index_command): Update.
12720 * cp-support.c (add_symbol_overload_list_qualified): Update.
12721 * breakpoint.c (create_overlay_event_breakpoint)
12722 (create_longjmp_master_breakpoint)
12723 (create_std_terminate_master_breakpoint)
12724 (create_exception_master_breakpoint): Update.
12725 * blockframe.c (find_pc_partial_function): Update.
12726 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12727 (ada_collect_symbol_completion_matches)
12728 (ada_add_global_exceptions): Update.
12729
776489e0
TT
127302019-01-17 Tom Tromey <tom@tromey.com>
12731
12732 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12733 declare VEC.
12734 (solib_target_parse_libraries): Change return type.
12735 (library_list_start_segment, library_list_start_section)
12736 (library_list_end_library, library_list_start_library); Update.
12737 (solib_target_free_library_list): Remove.
12738 (solib_target_parse_libraries): Remove cleanup. Change return
12739 type.
12740 (solib_target_current_sos): Update.
12741
6471e7d2
TT
127422019-01-17 Tom Tromey <tromey@bapiya>
12743
12744 * valprint.c: Replace "the the" with "the".
12745 * symtab.c: Replace "the the" with "the".
12746 * solib.c: Replace "the the" with "the".
12747 * solib-dsbt.c: Replace "the the" with "the".
12748 * linespec.c: Replace "the the" with "the".
12749 * dwarf2loc.h: Replace "the the" with "the".
12750 * amd64-windows-tdep.c: Replace "the the" with "the".
12751 * aarch64-tdep.c: Replace "the the" with "the".
12752
c24bdb02
KS
127532019-01-16 Keith Seitz <keiths@redhat.com>
12754
12755 PR gdb/23773
12756 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12757 <builder>: Rename to ..
12758 <m_builder>: ... this and make private.
12759 (dwarf2_cu::get_builder): New method. Change all users of
12760 `builder' to use this method.
12761 (dwarf2_start_symtab): Move to ...
12762 (dwarf2_cu::start_symtab): ... here. Update all callers
12763 (setup_type_unit_groups): Move to ...
12764 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12765 callers.
12766 (dwarf2_cu::reset_builder): New method.
12767 (process_full_compunit, process_full_type_unit): Use
12768 dwarf2_cu::reset_builder.
12769 (follow_die_offset): Record the ancestor CU if it is different
12770 from the followed DIE's CU.
12771 (follow_die_sig_1): Likewise.
12772
8d64371b
TT
127732019-01-15 Tom Tromey <tom@tromey.com>
12774
12775 * remote.c (class remote_state) <buf>: Now a char_vector.
12776 <buf_size>: Remove.
12777 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12778 parameter.
12779 (remote_target::getpkt_or_notif_sane_1)
12780 (remote_target::getpkt_sane)
12781 (remote_target::getpkt_or_notif_sane): Likewise.
12782 (class remote_target) <putpkt>: New overload.
12783 (remote_target::read_frame): Change type of "buf_p". Remove
12784 sizeof_p parameter.
12785 (packet_ok): New overload.
12786 (packet_check_result): New overload.
12787 Update all uses.
12788
bb277751
TT
127892019-01-14 Tom Tromey <tom@tromey.com>
12790
12791 * remote-notif.c (handle_notification, remote_notif_ack)
12792 (remote_notif_parse): Make "buf" const.
12793 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12794 const.
12795 (remote_notif_parse, remote_notif_ack, handle_notification):
12796 Likewise.
12797 * remote.c (remote_notif_stop_parse): Make "buf" const.
12798 (remote_target::remote_parse_stop_reply): Make "buf" const.
12799 (remote_notif_stop_ack): Make "buf" const.
12800
05be00a8
TT
128012019-01-14 Tom Tromey <tom@tromey.com>
12802
12803 * remote.c (remote_console_output): Make parameter const.
12804
491adeca
TT
128052019-01-14 Tom Tromey <tom@tromey.com>
12806
12807 * target-debug.h (target_debug_print_signals): Constify.
12808 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12809 * procfs.c (procfs_target::pass_signals): Update.
12810 * linux-nat.c (linux_nat_target::pass_signals): Update.
12811 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12812 * target-delegates.c: Rebuild.
12813 * remote.c (remote_target::program_signals): Update.
12814 (remote_target::pass_signals): Update.
12815 * target.c (target_pass_signals): Constify argument.
12816 (target_program_signals): Likewise.
12817 * target.h (struct target_ops) <pass_signals, program_signals>:
12818 Constify argument.
12819 (target_pass_signals, target_program_signals): Constify argument.
12820
bbd94648
TT
128212019-01-14 Tom Tromey <tom@tromey.com>
12822
12823 PR tui/28819:
12824 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12825
6f072a10
PFC
128262019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12827
12828 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12829 field.
12830 * rs6000-tdep.c: Include reggroups.h.
12831 (IS_V_ALIAS_PSEUDOREG): Define.
12832 (rs6000_register_name): Return names for the "vX" aliases.
12833 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12834 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12835 aliases. Call default_register_reggroup_p for all other
12836 pseudo-registers.
12837 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12838 New functions.
12839 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12840 Handle "vX" aliases.
12841 (v_alias_pseudo_register_collect): New function.
12842 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12843 (rs6000_gdbarch_init): Initialize "vX" aliases as
12844 pseudo-registers. Restore registration of
12845 rs6000_pseudo_register_reggroup_p with
12846 set_tdesc_pseudo_register_reggroup_p.
12847
1a782351
MF
128482019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12849
12850 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12851 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12852 set_gdbarch_num_pseudo_regs.
12853
d73cff18
PW
128542019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12855
12856 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12857 Remove arg prefixname, add do_set and do_show.
12858 Add member functions set_list and show_list.
12859 * cli/cli-style.c (class cli_style_option): Update accordingly.
12860 (style_set_list): Move to file scope.
12861 (style_show_list): Likewise.
12862 (set_style): Call help_list.
12863 (show_style): Call cmd_show_list.
12864 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12865 Update to use the new macro.
12866
60a90376
JB
128672019-10-12 Joel Brobecker <brobecker@adacore.com>
12868
12869 * ada-lang.c (_initialize_ada_language): Expand the help text
12870 for the "catch exception" command.
12871
9d7c67bf
PW
128722019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12873
12874 * symtab.c (matching_obj_sections): Initialize obj,
12875 declare it closer to its usage.
12876
7cf47dc4
TT
128772019-01-10 Tom Tromey <tom@tromey.com>
12878
12879 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12880 (basic_inf_threads_range): Remove.
12881 (inf_threads_range, inf_non_exited_threads_range)
12882 (safe_inf_threads_range): Use next_adapter.
12883
d3cb6808
KS
128842019-01-10 Keith Seitz <keiths@redhat.com>
12885
12886 PR gdb/23712
12887 PR symtab/23010
12888 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12889 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12890
63a20375
KS
128912019-01-10 Keith Seitz <keiths@redhat.com>
12892
12893 PR gdb/23712
12894 PR symtab/23010
12895 * dictionary.c (pending_to_vector): Remove.
12896 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12897 Remove _1 suffix, replacing functions of the same name. Update
12898 all callers.
12899 (dict_create_hashed, dict_create_hashed_expandable)
12900 (dict_create_linear, dict_create_linear_expandable, dict_free)
12901 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12902 Make functions static.
12903
b026f593
KS
129042019-01-10 Keith Seitz <keiths@redhat.com>
12905
12906 PR gdb/23712
12907 PR symtab/23010
12908 * dictionary.h (struct dictionary): Replace declaration with
12909 multidictionary.
12910 (dict_create_hashed, dict_create_hashed_expandable)
12911 (dict_create_linear, dict_create_linear_expandable)
12912 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12913 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12914 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12915 taking multidictionary argument.
12916 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12917 * block.h (struct block) <dict>: Change to multidictionary
12918 and rename `multidict'.
12919 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12920 symmisc.c: Update all dictionary references to multidictionary.
12921
c7748ee9
KS
129222019-01-10 Keith Seitz <keiths@redhat.com>
12923
12924 PR gdb/23712
12925 PR symtab/23010
12926 * dictionary.c: Include unordered_map.
12927 (pending_to_vector): New function.
12928 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12929 Rewrite the non-"_1" functions to take vector instead
12930 of linked list.
12931 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12932 "new" _1 versions of the same name.
12933 (multidictionary): Define.
12934 (std::hash<enum language): New definition.
12935 (collate_pending_symbols_by_language, mdict_create_hashed)
12936 (mdict_create_hashed_expandable, mdict_create_linear)
12937 (mdict_create_linear_expandable, mdict_free)
12938 (find_language_dictionary, create_new_language_dictionary)
12939 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12940 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12941 (mdict_size, mdict_empty): New functions.
12942 * dictionary.h (mdict_iterator): Define.
12943
67aa1f3c
PA
129442019-01-10 Pedro Alves <palves@redhat.com>
12945
12946 * breakpoint.c (read_uploaded_action)
12947 (create_tracepoint_from_upload): Adjust to use
12948 gdb::unique_xmalloc_ptr.
12949 * ctf.c (ctf_write_uploaded_tp):
12950 (SET_ARRAY_FIELD): Use emplace_back.
12951 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12952 * tracefile-tfile.c (tfile_write_uploaded_tp):
12953 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12954 gdb::unique_xmalloc_ptr.
12955 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12956 at_string, cond_string, cmd_strings>: Replace char pointers
12957 with gdb::unique_xmalloc_ptr.
12958
2f667667
PA
129592019-01-10 Pedro Alves <palves@redhat.com>
12960
12961 * solib-target.c (library_list_start_library): Don't xstrdup name.
12962
36cb7237
PA
129632019-01-10 Pedro Alves <palves@redhat.com>
12964
12965 * mdebugread.c (parse_partial_symbols): Use
12966 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12967
da584958
AB
129682019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12969
12970 * linux-fork.c (scoped_switch_fork_info)
12971 <~scoped_switch_fork_info>: Fix incorrect variable name.
12972
1ef8573c
AB
129732019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12974
12975 * linux-fork.c (scoped_switch_fork_info)
12976 <scoped_switch_fork_info>: Make explicit.
12977 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12978
8d7bcccb
TT
129792019-01-10 Tom Tromey <tom@tromey.com>
12980
12981 * objfiles.h (objfile::reset_psymtabs): Update.
12982 * objfiles.c (objfile::objfile): Update.
12983 * psymtab.h (psymtab_storage::obstack): Update.
12984 (psymtab_storage::m_obstack): Use gdb::optional.
12985 (class psymtab_storage): Update comment. Remove objfile
12986 parameter.
12987 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12988
b596a3c7
TT
129892019-01-10 Tom Tromey <tom@tromey.com>
12990
12991 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12992 <free_psymtabs>: Now private.
12993 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12994 (allocate_psymtab): Use new method.
12995
a9342b62
TT
129962019-01-10 Tom Tromey <tom@tromey.com>
12997
12998 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12999 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13000 * mdebugread.c (parse_partial_symbols): Use
13001 allocate_dependencies.
13002 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13003 allocate_dependencies.
13004 (process_psymtab_comp_unit_reader)
13005 (build_type_psymtab_dependencies): Likewise.
13006 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13007
5af70966
TT
130082019-01-10 Tom Tromey <tom@tromey.com>
13009
13010 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13011 PSYMBOL_SET_LANGUAGE.
13012 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13013
5923a04c
TT
130142019-01-10 Tom Tromey <tom@tromey.com>
13015
13016 * psymtab.h (psymtab_storage::obstack): New method.
13017 <m_obstack>: Rename from obstack; now private.
13018 * psymtab.c (psymtab_storage): Update.
13019 * dwarf2read.c (create_addrmap_from_index)
13020 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13021 Update.
13022
6d6a12bf
TT
130232019-01-10 Tom Tromey <tom@tromey.com>
13024
13025 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13026 * objfiles.h (objfile::reset_psymtabs): New method.
13027
d320c2b5
TT
130282019-01-10 Tom Tromey <tom@tromey.com>
13029
13030 * symmisc.c (print_symbol_bcache_statistics): Update.
13031 (print_objfile_statistics): Update.
13032 * symfile.c (reread_symbols): Update.
13033 * psymtab.h (class psymtab_storage): New.
13034 * psymtab.c (psymtab_storage): New constructor.
13035 (~psymtab_storage): New destructor.
13036 (require_partial_symbols): Update.
13037 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13038 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13039 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13040 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13041 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13042 (start_psymtab_common, end_psymtab_common)
13043 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13044 (allocate_psymtab): Update.
13045 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13046 Update.
13047 (dump_psymtab_addrmap, maintenance_print_psymbols)
13048 (maintenance_check_psymtabs): Update.
13049 (class objfile_psymtabs): Move to objfiles.h.
13050 * psympriv.h (discard_psymtab): Now inline.
13051 (psymtab_discarder::psymtab_discarder): Update.
13052 (psymtab_discarder::~psymtab_discarder): Update.
13053 (ALL_OBJFILE_PSYMTABS): Rewrite.
13054 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13055 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13056 Remove fields.
13057 <partial_symtabs>: New field.
13058 (class objfile_psymtabs): Move from psymtab.h. Update.
13059 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13060 psymbol_cache.
13061 (objfile::~objfile): Don't destroy psymbol_cache.
13062 * mdebugread.c (parse_partial_symbols): Update.
13063 * dwarf2read.c (create_addrmap_from_index)
13064 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13065 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13066 (add_partial_subprogram, dwarf2_ranges_read): Update.
13067 * dwarf-index-write.c (write_address_map)
13068 (write_one_signatured_type, recursively_write_psymbols)
13069 (class debug_names, class debug_names, write_psymtabs_to_index):
13070 Update.
13071
1d94a5a3
TT
130722019-01-10 Tom Tromey <tom@tromey.com>
13073
13074 * symtab.h (SYMBOL_SET_NAMES): Update.
13075 (symbol_set_names): Update.
13076 (MSYMBOL_SET_NAMES): Update.
13077 * symtab.c (symbol_set_names): Change argument to be an
13078 objfile_per_bfd_storage.
13079 * psymtab.c (add_psymbol_to_bcache): Update.
13080 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13081
0f14768a
TT
130822019-01-10 Tom Tromey <tom@tromey.com>
13083
13084 * symtab.c (create_demangled_names_hash): Change argument to be an
13085 objfile_per_bfd_storage.
13086 (symbol_set_names): Update.
13087
6eee24ce
TT
130882019-01-10 Tom Tromey <tom@tromey.com>
13089
13090 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13091 init_psymbol_list.
13092 * psymtab.c (init_psymbol_list): Do nothing if already called.
13093 * psympriv.h (init_psymbol_list): Add comment.
13094 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13095 init_psymbol_list.
13096 * dbxread.c (dbx_symfile_read): Unconditionally call
13097 init_psymbol_list.
13098
75aedd27
TT
130992019-01-10 Tom Tromey <tom@tromey.com>
13100
13101 * xcoffread.c (scan_xcoff_symtab): Update.
13102 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13103 "where".
13104 * mdebugread.c (parse_partial_symbols)
13105 (handle_psymbol_enumerators): Update.
13106 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13107 * dbxread.c (read_dbx_symtab): Update.
13108 * psympriv.h (psymbol_placement): New enum.
13109 (add_psymbol_to_list): Update.
13110
939652a5
TT
131112019-01-10 Tom Tromey <tom@tromey.com>
13112
13113 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13114 static_psymbols parameters.
13115 (scan_xcoff_symtab): Update.
13116 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13117 static_psymbols parameters.
13118 * psympriv.h (start_psymtab_common): Update.
13119 * mdebugread.c (parse_partial_symbols): Update.
13120 * dwarf2read.c (create_partial_symtab): Update.
13121 * dbxread.c (read_dbx_symtab): Update.
13122 (start_psymtab): Remove global_psymbols and static_psymbols
13123 parameters.
13124
baa62830
TT
131252019-01-10 Tom Tromey <tom@tromey.com>
13126
13127 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13128 * psymtab.c (allocate_psymtab): Add comment.
13129 * psympriv.h (allocate_psymtab): Add comment.
13130 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13131 initializations.
13132 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13133
0e8f53ba
TT
131342019-01-10 Tom Tromey <tom@tromey.com>
13135
13136 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13137 Don't declare.
13138 * mipsread.c: Include mdebugread.h.
13139 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13140 Declare.
13141 * elfread.c: Include mdebugread.h.
13142
b22a7c6a
TT
131432019-01-09 Tom Tromey <tom@tromey.com>
13144
13145 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13146 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13147 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13148 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13149 (psym_lookup_symbol, psym_find_last_source_symtab)
13150 (psym_forget_cached_source_info, psym_print_stats)
13151 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13152 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13153 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13154 (psym_find_compunit_symtab_by_address)
13155 (maintenance_print_psymbols, maintenance_info_psymtabs)
13156 (maintenance_check_psymtabs): Use ranged for.
13157 * psymtab.h (class objfile_psymtabs): New.
13158 (require_partial_symbols): Return objfile_psymtabs.
13159 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13160
3b9d3ac2
TT
131612019-01-09 Tom Tromey <tom@tromey.com>
13162
13163 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13164 (find_pc_mapped_section, list_overlays_command)
13165 (map_overlay_command, unmap_overlay_command)
13166 (simple_overlay_update): Use all_objfiles.
13167 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13168 * printcmd.c (info_symbol_command): Use all_objfiles.
13169 * objfiles.h (ALL_OBJSECTIONS): Remove.
13170 * maint.c (maintenance_translate_address): Use all_objfiles.
13171 * gcore.c (gcore_create_callback): Use all_objfiles.
13172 (objfile_find_memory_regions): Likewise.
13173
8b31193a
TT
131742019-01-09 Tom Tromey <tom@tromey.com>
13175
13176 * symtab.c (find_line_symtab, info_sources_command)
13177 (make_source_files_completion_list): Use objfile_compunits.
13178 * source.c (select_source_symtab): Use objfile_compunits.
13179 * objfiles.h (struct objfile): Update comment.
13180 (ALL_OBJFILES): Remove.
13181 (ALL_FILETABS): Remove.
13182 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13183 objfile_compunits.
13184
d5da8b3c
TT
131852019-01-09 Tom Tromey <tom@tromey.com>
13186
13187 * symmisc.c (print_objfile_statistics, dump_objfile)
13188 (maintenance_print_symbols): Use compunit_filetabs.
13189 * source.c (forget_cached_source_info_for_objfile): Use
13190 compunit_filetabs.
13191 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13192 (ALL_FILETABS): Use compunit_filetabs.
13193 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13194 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13195
5accd1a0
TT
131962019-01-09 Tom Tromey <tom@tromey.com>
13197
13198 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13199 (compunit_filetabs): New.
13200 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13201 compunit_filetabs.
13202 (info_sources_command, make_source_files_completion_list): Remove
13203 declaration.
13204 * symmisc.c (print_objfile_statistics, dump_objfile)
13205 (maintenance_print_symbols): Remove declaration.
13206 (maintenance_info_symtabs): Use compunit_filetabs.
13207 (maintenance_info_line_tables): Likewise.
13208 * source.c (select_source_symtab): Change local variable name.
13209 (forget_cached_source_info_for_objfile): Remove declaration.
13210 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13211 * objfiles.c (objfile_relocate1): Remove declaration.
13212 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13213 declaration.
13214 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13215 * coffread.c (coff_symtab_read): Remove declaration.
13216 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13217 compunit_filetabs.
13218
d8aeb77f
TT
132192019-01-09 Tom Tromey <tom@tromey.com>
13220
13221 * symtab.c (lookup_objfile_from_block)
13222 (find_pc_sect_compunit_symtab, search_symbols)
13223 (default_collect_symbol_completion_matches_break_on): Use
13224 objfile_compunits.
13225 * objfiles.h (ALL_COMPUNITS): Remove.
13226 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13227 * cp-support.c (add_symbol_overload_list_qualified): Use
13228 objfile_compunits.
13229 * ada-lang.c (ada_collect_symbol_completion_matches)
13230 (ada_add_global_exceptions): Use objfile_compunits.
13231
592553c4
TT
132322019-01-09 Tom Tromey <tom@tromey.com>
13233
13234 * source.c (select_source_symtab)
13235 (forget_cached_source_info_for_objfile): Remove declaration.
13236 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13237 declaration.
13238 * maint.c (count_symtabs_and_blocks): Remove declaration.
13239 * cp-support.c (add_symbol_overload_list_qualified): Remove
13240 declaration.
13241 * coffread.c (coff_symtab_read): Remove declaration.
13242 * symtab.c (lookup_symbol_in_objfile_symtabs)
13243 (basic_lookup_transparent_type_1): Use objfile_compunits.
13244 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13245 (info_sources_command, search_symbols)
13246 (default_collect_symbol_completion_matches_break_on)
13247 (make_source_files_completion_list): Remove declaration.
13248 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13249 (ada_collect_symbol_completion_matches)
13250 (ada_add_global_exceptions): Remove declaration.
13251 * linespec.c (iterate_over_all_matching_symtabs): Use
13252 objfile_compunits.
13253 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13254 (class objfile_compunits): New.
13255 (ALL_COMPUNITS): Use objfile_compunits.
13256 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13257 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13258 objfile_compunits.
13259 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13260
5325b9bf
TT
132612019-01-09 Tom Tromey <tom@tromey.com>
13262
13263 * symtab.c (search_symbols)
13264 (default_collect_symbol_completion_matches_break_on): Use
13265 objfile_msymbols.
13266 * ada-lang.c (ada_lookup_simple_minsym)
13267 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13268 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13269 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13270 objfile_msymbols.
13271 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13272 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13273 * objc-lang.c (find_methods): Use objfile_msymbols.
13274 (info_selectors_command, info_classes_command): Likewise.
13275 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13276 * objfiles.h (class objfile_msymbols): New.
13277 (ALL_OBJFILE_MSYMBOLS): Remove.
13278 (ALL_MSYMBOLS): Remove.
13279
cac85af2
TT
132802019-01-09 Tom Tromey <tom@tromey.com>
13281
13282 * common/next-iterator.h (next_adapter): Add Iterator template
13283 parameter.
13284 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13285 (class all_objfiles_safe): New.
13286 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13287 * objfiles.c (put_objfile_before): Update comment.
13288 (add_separate_debug_objfile): Likewise.
13289 (free_all_objfiles): Use all_objfiles_safe.
13290 (objfile_purge_solibs): Likewise.
13291
aed57c53
TT
132922019-01-09 Tom Tromey <tom@tromey.com>
13293
13294 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13295 (expand_symtab_containing_pc, lookup_static_symbol)
13296 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13297 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13298 all_objfiles.
13299 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13300 * breakpoint.c (create_overlay_event_breakpoint)
13301 (create_longjmp_master_breakpoint)
13302 (create_std_terminate_master_breakpoint)
13303 (create_exception_master_breakpoint): Use all_objfiles.
13304 * linux-thread-db.c (try_thread_db_load_from_pdir)
13305 (has_libpthread): Use all_objfiles.
13306 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13307 * linespec.c (iterate_over_all_matching_symtabs)
13308 (search_minsyms_for_name): Use all_objfiles.
13309 * maint.c (maintenance_info_sections): Use all_objfiles.
13310 * main.c (captured_main_1): Use all_objfiles.
13311 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13312 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13313 * guile/scm-pretty-print.c
13314 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13315 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13316 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13317 (maintenance_print_msymbols): Use all_objfiles.
13318 * source.c (select_source_symtab): Use all_objfiles.
13319 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13320 * symfile.c (remove_symbol_file_command)
13321 (expand_symtabs_matching, map_symbol_filenames): Use
13322 all_objfiles.
13323 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13324 all_objfiles.
13325 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13326 * objc-lang.c (find_methods): Use all_objfiles.
13327 * objfiles.c (have_partial_symbols, have_full_symbols)
13328 (have_minimal_symbols, qsort_cmp)
13329 (default_iterate_over_objfiles_in_search_order): Use
13330 all_objfiles.
13331 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13332 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13333 (maintenance_check_psymtabs): Use all_objfiles.
13334 (ALL_PSYMTABS): Remove.
13335 * compile/compile-object-run.c (do_module_cleanup): Use
13336 all_objfiles.
13337 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13338 * cp-support.c (add_symbol_overload_list_qualified): Use
13339 all_objfiles.
13340 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13341 Use all_objfiles.
13342 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13343 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13344 all_objfiles.
13345 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13346 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13347 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13348 Uses all_objfiles.
13349 * solib.c (solib_read_symbols): Use all_objfiles
13350
99d89cde
TT
133512019-01-09 Tom Tromey <tom@tromey.com>
13352
13353 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13354 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13355 all_objfiles.
13356 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13357 * symmisc.c (print_symbol_bcache_statistics)
13358 (print_objfile_statistics, maintenance_print_objfiles)
13359 (maintenance_info_symtabs, maintenance_check_symtabs)
13360 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13361 all_objfiles.
13362 * source.c (forget_cached_source_info): Use all_objfiles.
13363 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13364 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13365 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13366 * objfiles.c (update_section_map): Use all_objfiles.
13367 (shared_objfile_contains_address_p): Likewise.
13368 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13369 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13370
21708325
TT
133712019-01-09 Tom Tromey <tom@tromey.com>
13372
13373 * common/next-iterator.h: New file.
13374 * objfiles.h (class all_objfiles): New.
13375 (struct objfile_iterator): New.
13376
669e09f6
PW
133772019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13378
13379 * NEWS: Move the description of the changed "frame", "select-frame",
13380 and "info frame" commands to the Changed commands section.
13381
041be526
SM
133822019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13383
13384 * gdbtypes.c (check_stub_method_group): Remove handling of old
13385 mangling schemes.
13386 * linespec.c (find_methods): Likewise.
13387 * stabsread.c (read_member_functions): Likewise.
13388 * valops.c (search_struct_method): Likewise.
13389 (value_struct_elt_for_reference): Likewise.
13390 * NEWS: Mention this change.
13391
0e2a2133
AB
133922019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13393
13394 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13395 print_source_lines.
13396 * source.c (print_source_lines_base): Update line number check.
13397 (print_source_lines): New function.
13398 (source_lines_range::source_lines_range): New function.
13399 * source.h (class source_lines_range): New class.
13400 (print_source_lines): New declaration.
13401
1055a3b4
PW
134022019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13403
13404 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13405
cfeadda5
TT
134062019-01-08 Tom Tromey <tom@tromey.com>
13407 Simon Marchi <simon.marchi@ericsson.com>
13408
13409 PR gdb/24060
13410 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13411 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13412 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13413 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13414 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13415 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13416
583068ca
AB
134172019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13418
13419 * source.c (select_source_symtab): Move header comment to
13420 declaration in source.h.
13421 (forget_cached_source_info_for_objfile): Likewise.
13422 (forget_cached_source_info): Likewise.
13423 (identify_source_line): Likewise.
13424 * source.h (identify_source_line): Move declaration from symtab.h
13425 and add comment from source.c
13426 (print_source_lines): Likewise.
13427 (forget_cached_source_info_for_objfile): Likewise.
13428 (forget_cached_source_info): Likewise.
13429 (select_source_symtab): Likewise.
13430 (enum print_source_lines_flag): Move definition from symtab.h.
13431 * symtab.h (identify_source_line): Move declaration to source.h.
13432 (print_source_lines): Likewise.
13433 (forget_cached_source_info_for_objfile): Likewise.
13434 (forget_cached_source_info): Likewise.
13435 (select_source_symtab): Likewise.
13436 (enum print_source_lines_flag): Move definition to source.h.
13437 * tui/tui-hooks.c: Add 'source.h' include.
13438
ec98a4ad
AB
134392019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13440
13441 * source.c (print_source_lines_base): Handle requests to print
13442 reverse line number sequences, and guard against empty lines
13443 string.
13444
62ea19c1
AB
134452019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13446
13447 * source.c (print_source_lines_base): Fix skip of '\r' if next
13448 character is '\n'.
13449
9d30e1fd
TT
134502019-01-06 Tom Tromey <tom@tromey.com>
13451
13452 * c-exp.y (struct c_parse_state) <macro_original_text,
13453 expansion_obstack>: New member.
13454 (macro_original_text, expansion_obstack): Remove globals.
13455 (scan_macro_expansion, scanning_macro_expansion)
13456 (finished_macro_expansion): Update.
13457 (scan_macro_cleanup): Remove.
13458 (yylex, c_parse): Update.
13459
c65bac38
TT
134602019-01-06 Tom Tromey <tom@tromey.com>
13461
13462 * c-exp.y (struct c_parse_state) <strings>: New member.
13463 (operator_stoken): Update.
13464
02e12e38
TT
134652019-01-06 Tom Tromey <tom@tromey.com>
13466
13467 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13468 (union type_stack_elt) <typelist_val>: Now a pointer to
13469 std::vector.
13470 (type_stack_cleanup): Don't declare.
13471 (push_typelist): Update.
13472 * parse.c (pop_typelist): Return a std::vector.
13473 (push_typelist): Take a std::vector.
13474 (follow_types): Update. Do not free args.
13475 (type_stack_cleanup): Remove.
13476 * c-exp.y (struct c_parse_state): New.
13477 (cpstate): New global.
13478 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13479 (nonempty_typelist): Update.
13480 (func_mod): Create a new vector.
13481 (c_parse): Create a c_parse_state.
13482 (check_parameter_typelist): Do not delete params.
13483 (function_method): Update. Do not delete type_list.
13484
f097f5ad
TT
134852019-01-06 Tom Tromey <tom@tromey.com>
13486
13487 PR gdb/28155:
13488 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13489 check_typedef.
13490 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13491 (print_return_value): Likewise.
13492
d2adf9f1
TT
134932019-01-05 Tom Tromey <tom@tromey.com>
13494
13495 * contrib/cleanup_check.py: Remove.
13496 * contrib/gcc-with-excheck: Remove.
13497 * contrib/exsummary.py: Remove.
13498 * contrib/excheck.py: Remove.
13499
2eab46b1
JB
135002019-01-05 Joel Brobecker <brobecker@adacore.com>
13501
13502 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13503 NULL. Initialize tpprev to NULL instead of assigning it
13504 to NULL on the next statement.
13505 * windows-nat.c (windows_delete_thread): Remove check for
13506 main_thread_id before printing thread exit notifications.
13507 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13508 Remove thread ID check against main_thread_id.
13509 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13510 windows_delete_thread.
13511 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13512
48c5e7e2
TT
135132019-01-04 Tom Tromey <tom@tromey.com>
13514
13515 * compile/compile.c (_initialize_compile): Use upper case for
13516 metasyntactic variables.
13517 * symmisc.c (_initialize_symmisc): Use upper case for
13518 metasyntactic variables.
13519 * psymtab.c (_initialize_psymtab): Use upper case for
13520 metasyntactic variables.
13521 * demangle.c (demangle_command): Use upper case for metasyntactic
13522 variables.
13523 (_initialize_demangler): Likewise.
13524 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13525 variables.
13526
986041cd
TT
135272019-01-03 Tom Tromey <tom@tromey.com>
13528
13529 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13530
7c711119
TT
135312019-01-03 Tom Tromey <tom@tromey.com>
13532
13533 * python/py-symtab.c (salpy_str): Update.
13534 (struct salpy_sal_object) <symtab>: Now a PyObject.
13535 (salpy_dealloc): Update.
13536 (del_objfile_sal): Use gdbpy_ref.
13537
1b20edf0
TT
135382019-01-03 Tom Tromey <tom@tromey.com>
13539
13540 * python/py-type.c (convert_field): Use new_reference. Return
13541 gdbpy_ref.
13542 (make_fielditem): Return gdbpy_ref.
13543 (typy_fields): Update.
13544 (typy_getitem): Update.
13545 (field_name): Return gdbpy_ref. Use new_reference.
13546 (typy_iterator_iternext): Update.
13547
ea41325b
TT
135482019-01-03 Tom Tromey <tom@tromey.com>
13549
13550 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13551
2a3c71d6
TT
135522019-01-03 Tom Tromey <tom@tromey.com>
13553
13554 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13555 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13556 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13557 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13558 (pspy_set_type_printers): Likewise.
13559 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13560 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13561 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13562 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13563 (objfpy_set_type_printers): Likewise.
13564
5c329e6a
TT
135652019-01-03 Tom Tromey <tom@tromey.com>
13566
13567 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13568 (gdbpy_print_stack): Use gdbpy_err_fetch.
13569 * python/python-internal.h (class gdbpy_err_fetch): New class.
13570 (class gdbpy_enter) <m_error_type, m_error_value,
13571 m_error_traceback>: Remove.
13572 <m_error>: New member.
13573 (gdbpy_exception_to_string): Don't declare.
13574 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13575 * python/py-value.c (convert_value_from_python): Use
13576 gdbpy_err_fetch.
13577 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13578 gdbpy_exception_to_string.
13579 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13580 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13581 gdbpy_err_fetch.
13582
169bb27b
AB
135832019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13584
13585 * linux-nat.c (delete_lwp_cleanup): Delete.
13586 (struct lwp_deleter): New struct.
13587 (lwp_info_up): New typedef.
13588 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13589 lwp_info_up.
13590
a07c8880
AB
135912019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13592
13593 * linux-fork.c (class scoped_switch_fork_info): New class.
13594 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13595
26089c49
AB
135962019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13597
13598 * valops.c (find_overload_match): Remove use of null_cleanup, and
13599 calls to do_cleanups.
13600
06d3e5b0
AB
136012019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13602
13603 * compile/compile-cplus-types.c
13604 (compile_cplus_instance::decl_name): Handle changes to
13605 cp_func_name.
13606 * cp-support.c (cp_func_name): Update header comment, update
13607 return type.
13608 * cp-support.h (cp_func_name): Update return type in declaration.
13609 * valops.c (find_overload_match): Move temp_func local to top
13610 level of function and change its type. Use temp_func to hold and
13611 delete temporary string obtained from cp_func_name.
13612
66644cd3
AB
136132019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13614
13615 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13616 gdb::char_vector, remove cleanup, and update uses of `msg`.
13617
592d8c0a
JW
136182019-01-03 Jim Wilson <jimw@sifive.com>
13619
13620 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13621
c55d06ec
TT
136222019-01-02 Tom Tromey <tom@tromey.com>
13623
13624 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13625 (tdesc_parse_xml): Remove cleanups.
13626 * target-descriptions.h (make_cleanup_free_target_description):
13627 Don't declare.
13628 (target_desc_deleter): New struct.
13629 (target_desc_up): New typedef.
13630 * target-descriptions.c (target_desc_deleter::operator()): Rename
13631 from free_target_description.
13632 (make_cleanup_free_target_description): Remove.
13633
3a6ae42d
TT
136342019-01-02 Tom Tromey <tom@tromey.com>
13635
13636 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13637 constructor, destructor.
13638 (linespec_parser): Remove typedef.
13639 (~linespec_parser): Rename from linespec_parser_delete.
13640 (linespec_lex_to_end, linespec_complete_label)
13641 (linespec_complete): Update.
13642 (decode_line_full): Remove cleanups.
13643 (decode_line_1): Update.
13644
61fd3e73
TT
136452019-01-02 Tom Tromey <tom@tromey.com>
13646
13647 * python/python-internal.h (inferior_to_inferior_object): Change
13648 return type.
13649 * python/py-exitedevent.c (create_exited_event_object): Update.
13650 * python/py-inferior.c (inferior_to_inferior_object): Return
13651 gdbpy_ref.
13652 (python_new_inferior, python_inferior_deleted)
13653 (thread_to_thread_object, delete_thread_object)
13654 (build_inferior_list, gdbpy_selected_inferior): Update.
13655 * python/py-infthread.c (create_thread_object): Update. Also fail
13656 if inferior_to_inferior_object fails.
13657
d20172fc
SM
136582019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13659
13660 * inferior.h (class inferior) <displaced_step_state>: New field.
13661 * infrun.h (struct displaced_step_state): Move here from
13662 infrun.c. Initialize fields, add constructor.
13663 <inf>: Remove field.
13664 <reset>: New method.
13665 * infrun.c (struct displaced_step_inferior_state): Move to
13666 infrun.h.
13667 (displaced_step_inferior_states): Remove.
13668 (get_displaced_stepping_state): Adust.
13669 (displaced_step_in_progress_any_inferior): Adjust.
13670 (displaced_step_in_progress_thread): Adjust.
13671 (displaced_step_in_progress): Adjust.
13672 (add_displaced_stepping_state): Remove.
13673 (get_displaced_step_closure_by_addr): Adjust.
13674 (remove_displaced_stepping_state): Remove.
13675 (infrun_inferior_exit): Call displaced_step_state.reset.
13676 (use_displaced_stepping): Don't check for NULL.
13677 (displaced_step_prepare_throw): Call
13678 get_displaced_stepping_state.
13679 (displaced_step_fixup): Don't check for NULL.
13680 (prepare_for_detach): Don't check for NULL.
13681
e3319240
PW
136822019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13683
13684 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13685 in case of call that did not complete.
13686
5d36dfb9
AU
136872019-01-02 Andrey Utkin <autkin@undo.io>
13688
13689 * symfile.c (find_separate_debug_file): Fix search of debug files for
13690 remote debuggee.
13691
8833fbf0
TT
136922019-01-02 Tom Tromey <tom@tromey.com>
13693
13694 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13695 indentation.
13696 * python/py-frame.c (frapy_older): Remove cast.
13697 (frapy_newer): Likewise.
13698 * python/py-breakpoint.c (local_setattro): Remove cast.
13699 * python/py-arch.c (archpy_name): Remove local variable.
13700 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13701
4ada3dfd
JB
137022019-01-02 Joel Brobecker <brobecker@adacore.com>
13703
13704 * unittests/basic_string_view/element_access/char/empty.cc:
13705 Fix year range in copyright header.
13706
113b7b81
AB
137072019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13708
13709 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13710 Delete.
13711 <operator==>: Update with for removed field.
13712 <hash>: Likewise.
13713 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13714 <isa_features>: ...this.
13715 <abi_features>: New field.
13716 (riscv_isa_flen): Update comment.
13717 (riscv_abi_xlen): New declaration.
13718 (riscv_abi_flen): New declaration.
13719 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13720 isa_features.
13721 (riscv_abi_xlen): New function.
13722 (riscv_isa_flen): Update to get answer from isa_features.
13723 (riscv_abi_flen): New function.
13724 (riscv_has_fp_abi): Update to get answer from abi_features.
13725 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13726 xlen and flen.
13727 (riscv_call_info) <xlen, flen>: Update comment.
13728 (riscv_call_arg_struct): Remove invalid assertions
13729 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13730 is removed.
13731 (riscv_gdbarch_init): Gather isa features and abi features
13732 separately, ensure both match on the gdbarch when reusing an old
13733 gdbarch. Relax an error check to allow 32-bit abi float to run on
13734 a target with 64-bit float hardware.
13735
b18ca514
PW
137362019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13737
13738 * source.c (search_command_helper): Stop reverse search
13739 when line 1 has been searched.
13740
ec70d8db
PW
137412019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13742
13743 * record-full.c (record_full_base_target::close): Rewrite
13744 record_full_core_buf_list free logic.
13745
5b38f9c1
PW
137462019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13747
13748 * break-catch-syscall.c (print_one_catch_syscall): xfree
13749 the last text.
13750
66d91b39
JB
137512019-01-01 Joel Brobecker <brobecker@adacore.com>
13752
13753 * top.c (print_gdb_version): Update Copyright year in version
13754 message.
13755
42a4f53d
JB
137562019-01-01 Joel Brobecker <brobecker@adacore.com>
13757
13758 Update copyright year range in all GDB files.
13759
7e955d83 137602019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13761
5bbd631d 13762 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13763
5bbd631d 13764For older changes see ChangeLog-2018.
c906108c
SS
13765\f
13766Local Variables:
13767mode: change-log
13768left-margin: 8
13769fill-column: 74
13770version-control: never
57da7796 13771coding: utf-8
c906108c 13772End:
5bbd631d 13773