gdb/ChangeLog

   1 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * tui/tui-data.h (tui_gen_win_info): Add an =default
   4         move constructor, required by some GCC versions.
   5
   6 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
   7
   8         * go32-nat.c (go32_sysinfo): Add hygon_p.
   9
  10 2019-08-20  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
  13         line_from_reg_element_no, first_reg_element_no_inline,
  14         display_all_data, delete_data_content_windows,
  15         erase_data_content>: Now private.
  16
  17 2019-08-20  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
  20         (tui_unhighlight_win, tui_highlight_win)
  21         (tui_win_info::make_window): Update.
  22         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
  23
  24 2019-08-20  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  27         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  28         (MAX_PID_WIDTH): Move to tui-stack.c.
  29         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
  30         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
  31         (MAX_PID_WIDTH): Move from tui-data.h.
  32
  33 2019-08-20  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
  36         * tui/tui-wingeneral.c (box_win): Change type of win_info.
  37         (box_win): Update.
  38         (tui_gen_win_info::make_window): Rename from tui_make_window.
  39         (tui_win_info::make_window): New method.
  40         (tui_gen_win_info::make_visible): Update.
  41         * tui/tui-source.c (tui_source_window::set_contents): Update.
  42         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  43         (tui_data_window::display_registers_from): Update.
  44         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  45         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  46         Declare.
  47         <can_box>: Remove.
  48         <title>: Remove.
  49         (struct tui_win_info) <make_window>: Declare.
  50         <can_box>: Now virtual.
  51         <title>: New member.
  52         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  53         * tui/tui-command.c (tui_cmd_window::resize): Update.
  54
  55 2019-08-20  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  58         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  59         (tui_data_window::check_register_values): Update.
  60
  61 2019-08-20  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-regs.h (struct tui_data_window): Use
  64         DISABLE_COPY_AND_ASSIGN.
  65         <regs_content>: Change type, removing unique_ptr.
  66         <tui_data_window>: Add move constructor.
  67         * tui/tui-regs.c (tui_data_window::show_registers)
  68         (tui_data_window::show_register_group)
  69         (tui_data_window::display_registers_from)
  70         (tui_data_window::display_registers_from)
  71         (tui_data_window::first_data_item_displayed)
  72         (tui_data_window::delete_data_content_windows)
  73         (tui_data_window::rerender, tui_data_window::refresh_window)
  74         (tui_data_window::check_register_values): Update.
  75
  76 2019-08-20  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  79         show_register_group>: Declare.
  80         (tui_show_register_group): Don't declare.
  81         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  82         tui_show_registers.
  83         (tui_data_window::show_register_group): Rename from
  84         tui_show_register_group.
  85         (tui_data_window::check_register_values, tui_reg_command):
  86         Update.
  87         * tui/tui-layout.c (tui_set_layout): Update.
  88
  89 2019-08-20  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  92         Declare.
  93         (tui_check_register_values): Don't declare.
  94         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  95         from tui_check_register_values.
  96         * tui/tui-hooks.c (tui_register_changed): Update.
  97
  98 2019-08-20  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-regs.c (tui_reg_layout): Move later.
 101         (tui_show_registers): Don't enable TUI mode or change layout.
 102
 103 2019-08-20  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-regs.h (struct tui_data_item_window)
 106         <~tui_data_item_window>: Remove.
 107         <content>: Now a unique_xmalloc_ptr.
 108         * tui/tui-regs.c (tui_register_format): Return a
 109         unique_xmalloc_ptr.
 110         (tui_get_register): Update.
 111         (~tui_data_item_window): Remove.
 112         (tui_data_window::display_registers_from, tui_display_register):
 113         Update.
 114         * tui/tui-io.h (tui_expand_tabs): Update.
 115         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 116         Remove "col" parameter.
 117
 118 2019-08-20  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 121         field.
 122         * tui/tui-regs.c (~tui_data_item_window): Update.
 123
 124 2019-08-20  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 127         earlier.
 128
 129 2019-08-20  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 132
 133 2019-08-20  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-source.h (struct tui_source_window): Update.
 136         * tui/tui-regs.c (tui_show_registers): Update.
 137         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 138         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 139         (NO_REGS_STRING): Remove defines.
 140
 141 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 142
 143         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 144         unnecessary thread walk if remote doesn't support the packet.
 145
 146 2019-08-19  Tom Tromey  <tromey@adacore.com>
 147
 148         * python/py-value.c (value_has_field): Fix indentation.
 149
 150 2019-08-19  Tom Tromey  <tromey@adacore.com>
 151
 152         * printcmd.c (do_one_display, info_display_command): Update.
 153         * block.h (contained_in): Return bool.  Add allow_nested
 154         parameter.
 155         * block.c (contained_in): Return bool.  Add allow_nested
 156         parameter.
 157
 158 2019-08-19  Tom Tromey  <tom@tromey.com>
 159
 160         * configure: Rebuild.
 161         * configure.ac: Disallow the combination of -static-libstdc++ and
 162         source highlight.
 163         * source-cache.c (get_language_name): Handle rust.
 164         (source_cache::get_source_lines): Ignore highlighting exceptions.
 165
 166 2019-08-16  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 169         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 170         (struct tui_source_window_base) <make_visible, refresh_window,
 171         resize>: Remove methods.
 172         <execution_info>: Remove field.
 173         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 174         (tui_show_source_line, tui_source_window_base)
 175         (~tui_source_window_base): Update.
 176         (tui_source_window_base::resize)
 177         (tui_source_window_base::make_visible)
 178         (tui_source_window_base::refresh_window): Remove.
 179         (tui_source_window_base::update_exec_info): Update.
 180         * tui/tui-source.c (tui_source_window::set_contents): Update.
 181         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 182
 183 2019-08-16  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 186         deprecated_query_hook.
 187
 188 2019-08-16  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 191         (tui_update_source_windows_with_line): Update.
 192         * tui/tui-source.h (struct tui_source_window)
 193         <show_symtab_source>: Declare.
 194         (tui_show_symtab_source): Don't declare.
 195         * tui/tui-source.c (tui_show_symtab_source): Rename from
 196         tui_show_symtab_source.
 197
 198 2019-08-16  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-winsource.h (struct tui_source_window_base)
 201         <set_contents>: Declare.
 202         * tui/tui-winsource.c
 203         (tui_source_window_base::update_source_window_as_is): Update.
 204         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 205         Declare.
 206         (tui_set_source_content): Don't declare.
 207         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 208         tui_set_source_content.
 209         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 210         Declare.
 211         (tui_set_disassem_content): Don't declare.
 212         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 213         tui_set_disassem_content.
 214
 215 2019-08-16  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-winsource.h (struct tui_source_window_base)
 218         <update_breakpoint_info>: Declare.
 219         (tui_update_breakpoint_info): Don't declare.
 220         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 221         (tui_update_all_breakpoint_info): Update.
 222         (tui_source_window_base::update_breakpoint_info): Rename from
 223         tui_update_breakpoint_info.
 224         (tui_source_window_base::update_exec_info): Update.
 225
 226 2019-08-16  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-winsource.h (struct tui_source_window_base)
 229         <update_source_window>: Declare.
 230         (tui_update_source_window): Don't declare.
 231         * tui/tui-winsource.c
 232         (tui_source_window_base::update_source_window): Rename from
 233         tui_update_source_window.
 234         (tui_source_window_base::rerender): Update.
 235         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 236         * tui/tui-disasm.c (tui_show_disassem)
 237         (tui_show_disassem_and_update_source)
 238         (tui_disasm_window::maybe_update): Update.
 239
 240 2019-08-16  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-winsource.h (struct tui_source_window_base)
 243         <update_source_window_as_is>: Declare.
 244         (tui_update_source_window_as_is): Don't declare.
 245         * tui/tui-winsource.c (tui_update_source_window): Update
 246         (tui_source_window_base::update_source_window_as_is): Rename from
 247         tui_update_source_window_as_is.
 248         (tui_source_window_base::refill): Update.
 249         * tui/tui-source.c (tui_show_symtab_source): Update.
 250         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 251         Update.
 252
 253 2019-08-16  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.h (tui_update_source_window)
 256         (tui_update_source_window_as_is): Remove "noerror" parameter.
 257         * tui/tui-winsource.c (tui_update_source_window)
 258         (tui_update_source_window_as_is): Remove "noerror" parameter.
 259         (tui_update_source_windows_with_addr)
 260         (tui_update_source_windows_with_line)
 261         (tui_source_window_base::rerender)
 262         (tui_source_window_base::refill): Update.
 263         * tui/tui-source.h (tui_set_source_content)
 264         (tui_show_symtab_source): Remove "noerror" parameter.
 265         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 266         parameter.
 267         (tui_show_symtab_source): Likewise.
 268         (tui_source_window::maybe_update): Update.
 269         * tui/tui-disasm.c (tui_show_disassem)
 270         (tui_show_disassem_and_update_source)
 271         (tui_disasm_window::do_scroll_vertical)
 272         (tui_disasm_window::maybe_update): Update.
 273
 274 2019-08-16  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui.c (tui_is_window_visible): Update.
 277         * tui/tui-wingeneral.c (tui_make_window)
 278         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 279         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 280         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 281         (tui_set_win_height_command, parse_scrolling_args): Update.
 282         * tui/tui-source.c (tui_source_window::style_changed): Update.
 283         * tui/tui-regs.c (tui_show_registers)
 284         (tui_data_window::first_data_item_displayed)
 285         (tui_data_window::delete_data_content_windows)
 286         (tui_check_register_values, tui_reg_command): Update.
 287         * tui/tui-disasm.c (tui_show_disassem): Update.
 288         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 289         method.
 290         <is_visible>: Remove field.
 291         * tui/tui-data.c (tui_next_win, tui_prev_win)
 292         (tui_delete_invisible_windows): Update.
 293
 294 2019-08-16  Tom Tromey  <tom@tromey.com>
 295
 296         * tui/tui-winsource.h (struct tui_source_window_base)
 297         <m_has_locator>: Remove.
 298         * tui/tui-layout.c (show_source_disasm_command, show_data)
 299         (show_source_or_disasm_and_command): Update.
 300
 301 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 302
 303         * NEWS (Other MI changes): New subsection.
 304         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 305         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 306         * arch-utils.c (default_get_pc_address_flags): New function.
 307         * arch-utils.h (default_get_pc_address_flags): New declaration.
 308         * gdbarch.sh: Add get_pc_address_flags.
 309         * gdbarch.c: Regenerate.
 310         * gdbarch.h: Likewise.
 311         * stack.c (print_pc): New function.
 312         (print_frame_info) (print_frame): Call print_pc.
 313
 314 2019-08-16  Tom de Vries  <tdevries@suse.de>
 315
 316         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 317         print_objfile_section_info.
 318
 319 2019-08-15  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 322         calling update_cmdwin_start_line.
 323         * tui/tui-winsource.h (struct tui_source_window_base)
 324         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 325         <rerender>: Declare.
 326         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 327         Call rerender.
 328         (tui_source_window_base::set_new_height): Remove.
 329         (tui_source_window_base::rerender): Rename from
 330         do_make_visible_with_new_height.
 331         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 332         resize method.
 333         (tui_win_info::make_invisible_and_set_new_height)
 334         (tui_win_info::make_visible_with_new_height): Remove.
 335         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 336         Declare.
 337         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 338         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 339         do_make_visible_with_new_height>: Don't declare.
 340         <rerender>: Declare.
 341         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 342         set_new_height.
 343         (tui_data_window::do_make_visible_with_new_height): Remove.
 344         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 345         call tui_show_locator_content.
 346         (tui_gen_win_info::resize): Call rerender.
 347         (show_source_or_disasm_and_command): Don't call
 348         tui_show_locator_content.
 349         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 350         method.
 351         (struct tui_win_info) <rerender>: Declare.
 352         <set_new_height, make_invisible_and_set_new_height,
 353         make_visible_with_new_height>: Don't declare.
 354         * tui/tui-data.c (tui_win_list::rerender): New method.
 355         * tui/tui-command.h (struct tui_cmd_window)
 356         <do_make_visible_with_new_height>: Don't declare.
 357         * tui/tui-command.c
 358         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 359
 360 2019-08-15  Tom Tromey  <tromey@adacore.com>
 361
 362         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 363         * ada-lang.c (ada_enum_name): Likewise.
 364
 365 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 368         leading underscore.
 369         (GdbOutputErrorFile): Likewise.
 370         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 371         accordingly.
 372         (execute_unwinders): Rename to have a leading underscore.
 373         (auto_load_packages): Likewise.
 374         (global scope): Adjust call to auto_load_packages accordingly.
 375         (GdbSetPythonDirectory): Likewise.
 376         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 377         instead of execute_unwinders.
 378
 379 2019-08-15  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 382         (show_data): Don't change window visibility.
 383         (tui_gen_win_info::resize): Remove special case for command
 384         window.  Use wresize, when available.
 385         (show_source_or_disasm_and_command): Don't change window
 386         visibility.
 387         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 388         <make_visible>: New method.
 389         * tui/tui-command.c (tui_cmd_window::resize): New method.
 390
 391 2019-08-15  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 394         (struct tui_source_windows): New.
 395         * tui/tui-winsource.c (tui_display_main): Update.
 396         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 397         (new_height_ok, parse_scrolling_args): Update.
 398         * tui/tui-layout.c (show_layout, show_data): Update.
 399         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 400         (tui_add_to_source_windows): Don't declare.
 401         * tui/tui-data.c (source_windows, tui_source_windows)
 402         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 403
 404 2019-08-15  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 407         Rename from reset.
 408         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 409         * tui/tui-layout.c (show_source_disasm_command, show_data):
 410         Update.
 411         (tui_gen_win_info::resize): Rename.
 412         (show_source_or_disasm_and_command): Update.
 413         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 414         reset.
 415
 416 2019-08-15  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 419         * tui/tui-interp.c (tui_interp::init): Don't call
 420         tui_initialize_static_data.
 421         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 422
 423 2019-08-15  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 426         examine tui_win_list.
 427
 428 2019-08-15  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 431         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 432         tui_clear_source_content.
 433         (tui_clear_source_content): Remove.
 434         (tui_source_window_base::do_erase_source_content): Hoist call to
 435         content.clear().
 436         * tui/tui-stack.c (tui_show_frame_info): Don't call
 437         tui_clear_source_content.
 438
 439 2019-08-15  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-winsource.h (struct tui_source_window_base)
 442         <do_erase_source_content>: New method.
 443         <erase_source_content>: New method.
 444         (tui_erase_source_content): Don't declare.
 445         * tui/tui-winsource.c (tui_clear_source_content): Update.
 446         (tui_source_window_base::do_erase_source_content): Rename from
 447         tui_erase_source_content.
 448         (tui_source_window_base::show_source_content): Update.
 449         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 450         * tui/tui-source.h (struct tui_source_window)
 451         <erase_source_content>: New method.
 452         * tui/tui-disasm.h (struct tui_disasm_window)
 453         <erase_source_content>: New method.
 454
 455 2019-08-15  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 458         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 459         constructor.
 460         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 461         * tui/tui-source.c (tui_set_source_content): Update.
 462         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 463
 464 2019-08-15  Tom Tromey  <tom@tromey.com>
 465
 466         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 467         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 468         tui-source.c.
 469         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 470         Declare.
 471         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 472         method.
 473         (tui_source_window::maybe_update): Update.
 474
 475 2019-08-15  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 478         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 479         tui-disasm.c.
 480         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 481         Declare.
 482         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 483         method.
 484         (tui_disasm_window::maybe_update): Update.
 485
 486 2019-08-15  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-winsource.h (struct tui_source_window_base)
 489         <maybe_update>: Declare.
 490         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 491         method.
 492         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 493         Declare.
 494         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 495         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 496         Declare.
 497         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 498
 499 2019-08-15  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 502
 503 2019-08-15  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-wingeneral.c: Include tui-stack.h.
 506         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 507         (struct tui_locator_window): Move from tui-data.h.
 508         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 509         (tui_initialize_static_data): Move from tui-data.c.
 510         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 511         (struct tui_locator_window): Move to tui-stack.c.
 512         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 513         (tui_initialize_static_data): Move to tui-stack.c.
 514
 515 2019-08-15  Tom Tromey  <tom@tromey.com>
 516
 517         * tui/tui-layout.c (show_source_disasm_command)
 518         (show_source_or_disasm_and_command): Use make_visible method, not
 519         tui_make_window.
 520         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 521         Remove.
 522
 523 2019-08-15  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-wingeneral.h (tui_make_window): Update.
 526         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 527         parameter.
 528         (tui_gen_win_info::make_visible): Update.
 529         * tui/tui-regs.c (tui_data_window::display_registers_from):
 530         Update.
 531         * tui/tui-layout.c (show_source_disasm_command)
 532         (show_source_or_disasm_and_command): Update.
 533         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 534         (enum tui_box): Remove.
 535         (struct tui_win_info) <can_box>: New method.
 536         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 537         method.
 538
 539 2019-08-15  Tom de Vries  <tdevries@suse.de>
 540
 541         * linux-nat-trad.c: Include gdbarch.h.
 542
 543 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 544
 545         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 546         register sizes.
 547
 548 2019-08-14  Tom Tromey  <tromey@adacore.com>
 549
 550         * darwin-nat.c: Include gdbarch.h.
 551         * darwin-nat-info.c: Include gdbarch.h.
 552
 553 2019-08-13  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 556         Remove.
 557         * tui/tui-data.c (tui_initialize_static_data): Update.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-winsource.h (struct tui_exec_info_window)
 562         <~tui_exec_info_window, maybe_allocate_content, get_content,
 563         m_content>: Remove.
 564         (struct tui_source_window_base) <set_exec_info_content,
 565         show_exec_info_content>: Don't declare.
 566         * tui/tui-winsource.c
 567         (tui_exec_info_window::maybe_allocate_content): Remove.
 568         (tui_source_window_base::update_exec_info): Rename from
 569         set_exec_info_content.
 570         (tui_source_window_base::show_exec_info_content)
 571         (tui_source_window_base::update_exec_info): Remove.
 572
 573 2019-08-13  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 576         declare.
 577         * tui/tui-winsource.c (tui_update_source_window_as_is)
 578         (tui_update_source_windows_with_addr, tui_erase_source_content):
 579         Update.
 580         (tui_clear_exec_info_content): Remove.
 581
 582 2019-08-13  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 585         declare.
 586         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 587         call tui_erase_exec_info_content.
 588         (tui_clear_exec_info_content): Rename from
 589         tui_erase_exec_info_content.
 590         (tui_clear_exec_info_content): Delete.
 591
 592 2019-08-13  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.h (struct tui_source_window_base)
 595         <show_exec_info_content>: Declare.
 596         (tui_show_exec_info_content): Don't declare.
 597         * tui/tui-winsource.c
 598         (tui_source_window_base::show_exec_info_content): Rename from
 599         tui_show_exec_info_content.
 600         (tui_source_window_base::update_exec_info): Update.
 601
 602 2019-08-13  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 605         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 606         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 607         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 608         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 609         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 610         ... here.
 611
 612 2019-08-13  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-winsource.h (struct tui_source_window_base)
 615         <update_exec_info>: Declare.
 616         (tui_update_exec_info): Don't declare.
 617         * tui/tui-winsource.c (tui_update_source_window_as_is)
 618         (tui_source_window_base::refresh_all)
 619         (tui_update_all_breakpoint_info): Update.
 620         (tui_source_window_base::update_exec_info): Rename from
 621         tui_update_exec_info.
 622         * tui/tui-stack.c (tui_show_frame_info): Update.
 623
 624 2019-08-13  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.h (struct tui_source_window_base)
 627         <set_exec_info_content>: Declare.
 628         (tui_set_exec_info_content): Don't declare.
 629         * tui/tui-winsource.c
 630         (tui_source_window_base::set_exec_info_content): Rename from
 631         tui_set_exec_info_content.
 632         (tui_update_exec_info): Update.
 633
 634 2019-08-13  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.h (struct tui_source_window_base)
 637         <show_source_content>: Declare.
 638         (tui_show_source_content): Don't declare.
 639         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 640         (tui_source_window_base::show_source_content): Rename from
 641         tui_show_source_content.
 642         (tui_source_window_base::refresh_all): Update.
 643         * tui/tui-layout.c (show_source_disasm_command)
 644         (show_source_or_disasm_and_command): Update.
 645
 646 2019-08-13  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-winsource.c (tui_erase_source_content)
 649         (tui_show_source_content, tui_source_window_base::refresh_all):
 650         Update.
 651         * tui/tui-wingeneral.h
 652         (tui_check_and_display_highlight_if_needed): Don't declare.
 653         * tui/tui-wingeneral.c
 654         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 655         check_and_display_highlight_if_needed.
 656         * tui/tui-win.c (tui_rehighlight_all)
 657         (tui_win_info::make_visible_with_new_height): Update.
 658         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 659         (tui_data_window::erase_data_content)
 660         (tui_data_window::display_all_data): Update.
 661         * tui/tui-data.h (struct tui_win_info)
 662         <check_and_display_highlight_if_needed>: Declare.
 663
 664 2019-08-13  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-win.c (tui_resize_all): Call
 667         tui_delete_invisible_windows.
 668         * tui/tui-layout.c (show_layout): Call
 669         tui_delete_invisible_windows.
 670         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 671         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 672
 673 2019-08-13  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 676         tui_add_win_to_layout.
 677
 678 2019-08-13  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 681         * tui/tui-layout.c (tui_default_win_height): Now static.
 682
 683 2019-08-13  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 686         single switch.
 687         (show_source_disasm_command, show_source_or_disasm_and_command):
 688         Don't check current layout.
 689
 690 2019-08-13  Tom Tromey  <tom@tromey.com>
 691
 692         * tui/tui-wingeneral.c (make_all_visible): Remove.
 693         (tui_make_all_invisible): Simplify.
 694         * tui/tui-layout.c (tui_make_all_invisible): Move from
 695         tui-wingeneral.c; simplify.
 696         (show_layout): Hoist call to tui_make_all_invisible.
 697         (show_data): Don't call tui_make_all_invisible.
 698
 699 2019-08-13  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 702         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 703
 704 2019-08-13  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 707         tui-data.c.
 708         (show_source_disasm_command, show_data)
 709         (show_source_or_disasm_and_command): Don't use
 710         tui_set_current_layout_to.
 711         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 712         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 713         tui-layout.c.
 714         (tui_set_current_layout_to): Remove.
 715
 716 2019-08-13  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-layout.c (tui_set_layout): Update.
 719         * tui/tui-data.h (struct tui_layout_def): Remove.
 720         (tui_layout_def): Don't declare.
 721         * tui/tui-data.c (layout_def): Remove.
 722         (tui_layout_def): Remove.
 723
 724 2019-08-13  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-winsource.h (struct tui_source_window_base)
 727         <clear_detail>: No longer "override".
 728         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 729         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 730         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 731         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 732         Remove.
 733         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 734
 735 2019-08-13  Tom Tromey  <tromey@adacore.com>
 736
 737         * tracepoint.c: Don't include readline.h or history.h.
 738
 739 2019-08-12  Tom Tromey  <tom@tromey.com>
 740
 741         * configure: Rebuild.
 742         * configure.ac: Check for readline 7.
 743         * NEWS: Mention readline 7 requirement.
 744         * README: Update.
 745
 746 2019-08-12  Tom Tromey  <tom@tromey.com>
 747
 748         * mingw-hdep.c (gdb_select): Remove readline hack.
 749
 750 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 751
 752         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 753         when the function fails.
 754
 755 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 756
 757         * s390-tdep.c (s390_type_align): New function.
 758         (s390_gdbarch_init): Set it as type_align gdbarch method.
 759
 760 2019-08-09  Tom de Vries  <tdevries@suse.de>
 761
 762         PR gdb/24591
 763         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 764         pc_low with relocation offset.
 765
 766 2019-08-07  Tom Tromey  <tromey@adacore.com>
 767
 768         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 769         (print_frame_args): Update.
 770         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 771         Update.
 772         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 773         * frame.h (struct frame_arg): Add initializers.
 774         <error>: Now a unique_xmalloc_ptr.
 775
 776 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 777
 778         * NEWS: Expand the Pointer Authentication entry.
 779         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 780         (aarch64_frame_unmask_lr): ... to this.
 781         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 782         Call aarch64_frame_unmask_lr.
 783         * frame.c (struct frame_info): Add "masked" variable.
 784         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 785         (fprint_frame): Check for masked pc.
 786         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 787         declarations.
 788         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 789         * stack.c (print_frame): Check for masked pc.
 790
 791 2019-08-06  Tom Tromey  <tom@tromey.com>
 792
 793         * stabsread.c (patch_block_stabs, read_one_struct_field)
 794         (read_enum_type): Use obstack_strndup.
 795         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 796         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 797         * dwarf2read.c (guess_full_die_structure_name)
 798         (anonymous_struct_prefix): Use obstack_strndup.
 799         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 800         * c-exp.y (yylex): Use obstack_strndup.
 801         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 802         (write_var_or_type): Use obstack_strndup.
 803
 804 2019-08-06  Tom Tromey  <tom@tromey.com>
 805
 806         * symfile.c (reread_symbols): Use obstack_strdup.
 807         * stabsread.c (read_type): Use obstack_strdup.
 808         * gdb_obstack.h (obstack_strdup): New overload.
 809         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 810         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 811         (dwarf2_canonicalize_name): Use obstack_strdup.
 812         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 813         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 814         Use obstack_strdup.
 815
 816 2019-08-06  Tom Tromey  <tom@tromey.com>
 817
 818         * gdb_obstack.h (obstack_strdup): Define.
 819         * gdb_obstack.c (obstack_strdup): Don't define.
 820
 821 2019-08-06  Tom Tromey  <tom@tromey.com>
 822
 823         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 824         obstack_strdup.
 825         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 826         obstack_strdup.
 827         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 828         * stabsread.c (common_block_start): Use obstack_strdup.
 829         * objfiles.c (set_objfile_main_name, objfile): Use
 830         obstack_strdup.
 831         * namespace.c (add_using_directive): Use obstack_strdup.
 832         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 833         * jit.c (finalize_symtab): Use obstack_strdup.
 834         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 835         (guess_partial_die_structure_name, partial_die_info::fixup)
 836         (dwarf2_name): Use obstack_strdup.
 837         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 838         obstack_strdup.
 839         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 840         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 841         obstack_strdup.
 842         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 843
 844 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 845
 846         * unittests/help-doc-selftests.c: New file.
 847         * Makefile.in: Add the new file.
 848
 849 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 852         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 853         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 854         the trailing '.' is not output, and the first character is uppercased.
 855         (print_help_for_command): Update call to print_doc_line.
 856         (print_doc_of_command): Likewise.
 857         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 858         * cli/cli-option.c (append_indented_doc): Do not append newline.
 859         (build_help_option): Append newline after first appended_indented_doc
 860         only if a second call is done.
 861         (build_help): Append 2 new lines before each option, except the first
 862         one.
 863         * compile/compile.c (_initialize_compile): Add new lines after
 864         %OPTIONS%, when not at the end of the help.
 865         Change help doc or code
 866         producing the help doc to respect the invariants.
 867         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 868         Also removed the new line after 'Options:', as all other commands
 869         do not put an empty line between 'Options:' and the first option.
 870         * printcmd.c (_initialize_printcmd): Likewise.
 871         * stack.c (_initialize_stack): Likewise.
 872         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 873         incorrectly telling COMMAND is optional.
 874         * ada-lang.c (_initialize_ada_language): Change help doc or code
 875         producing the help doc to respect the invariants.
 876         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 877         * breakpoint.c (_initialize_breakpoint): Likewise.
 878         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 879         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 880         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 881         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 882         _initialize_cli_style): Likewise.
 883         * corelow.c (core_target_info): Likewise.
 884         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 885         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 886         * filesystem.c (_initialize_filesystem): Likewise.
 887         * frame.c (_initialize_frame): Likewise.
 888         * gnu-nat.c (add_task_commands): Likewise.
 889         * infcall.c (_initialize_infcall): Likewise.
 890         * infcmd.c (_initialize_infcmd): Likewise.
 891         * interps.c (_initialize_interpreter): Likewise.
 892         * language.c (_initialize_language): Likewise.
 893         * linux-fork.c (_initialize_linux_fork): Likewise.
 894         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 895         * maint.c (_initialize_maint_cmds): Likewise.
 896         * memattr.c (_initialize_mem): Likewise.
 897         * printcmd.c (_initialize_printcmd): Likewise.
 898         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 899         _RegEx): Likewise.
 900         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 901         * record-btrace.c (_initialize_record_btrace): Likewise.
 902         * record-full.c (_initialize_record_full): Likewise.
 903         * record.c (_initialize_record): Likewise.
 904         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 905         * regcache.c (_initialize_regcache): Likewise.
 906         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 907         _initialize_remote): Likewise.
 908         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 909         * serial.c (_initialize_serial): Likewise.
 910         * skip.c (_initialize_step_skip): Likewise.
 911         * source.c (_initialize_source): Likewise.
 912         * stack.c (_initialize_stack): Likewise.
 913         * symfile.c (_initialize_symfile): Likewise.
 914         * symtab.c (_initialize_symtab): Likewise.
 915         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 916         * top.c (init_main): Likewise.
 917         * tracefile-tfile.c (tfile_target_info): Likewise.
 918         * tracepoint.c (_initialize_tracepoint): Likewise.
 919         * tui/tui-win.c (_initialize_tui_win): Likewise.
 920         * utils.c (add_internal_problem_command): Likewise.
 921         * valprint.c (value_print_option_defs): Likewise.
 922
 923 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 924
 925         PR build/24886
 926         * configure.ac: Drop enable-libmcheck support.
 927         * configure, config.in: Rebuild.
 928         * libmcheck.m4: Remove.
 929         * acinclude.m4: Don't include it.
 930         * Makefile.in: Don't distribute it.
 931         * top.c (print_gdb_configuration): Don't mention it.
 932
 933 2019-08-06  Tom Tromey  <tom@tromey.com>
 934
 935         * utils.c (set_output_style): Sometimes pass stream to
 936         emit_style_escape.
 937         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 938         * record-btrace.c (btrace_insn_history): Update.
 939         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 940         method.
 941         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 942         Update initializers.
 943         <m_uiout>: New field.
 944         <m_di>: Move lower.
 945         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 946         Remove "uiout" parameter.
 947         (dump_insns): Update.
 948         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 949         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 950
 951 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 952
 953         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 954         (error_in_psymtab_expansion): Likewise.
 955         (lookup_symbol_via_quick_fns): Likewise.
 956         (basic_lookup_transparent_type_quick): Likewise.
 957         (basic_lookup_transparent_type_1): Likewise.
 958
 959 2019-08-06  Tom Tromey  <tromey@adacore.com>
 960
 961         * source.c (last_source_error): Now bool.
 962         (print_source_lines_base): Make "noprint" bool.  Only open
 963         source file when last_source_visited changes.
 964
 965 2019-08-06  Tom Tromey  <tromey@adacore.com>
 966
 967         * annotate.c (annotate_source_line): Use g_source_cache.
 968         * source-cache.c (source_cache::get_plain_source_lines): Change
 969         parameters.  Populate m_offset_cache.
 970         (source_cache::ensure): New method.
 971         (source_cache::get_line_charpos): New method.
 972         (extract_lines): Move lower.  Change parameters.
 973         (source_cache::get_source_lines): Move lower.
 974         * source-cache.h (class source_cache): Update comment.
 975         <get_line_charpos>: New method.
 976         <get_source_lines>: Update comment.
 977         <clear>: Clear m_offset_cache.
 978         <get_plain_source_lines>: Change parameters.
 979         <ensure>: New method
 980         <m_offset_cache>: New member.
 981         * source.c (forget_cached_source_info_for_objfile): Update.
 982         (info_source_command): Use g_source_cache.
 983         (find_source_lines, open_source_file_with_line_charpos): Remove.
 984         (print_source_lines_base, search_command_helper): Use g_source_cache.
 985         * source.h (open_source_file_with_line_charpos): Don't declare.
 986         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 987         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 988         Use g_source_cache.
 989
 990 2019-08-06  Tom Tromey  <tromey@adacore.com>
 991
 992         * source-cache.c (source_cache::get_plain_source_lines):
 993         Remove "first_line" and "last_line" parameters.
 994         (source_cache::get_source_lines): Cache plain text.
 995         * source-cache.h (class source_cache)
 996         <get_plain_source_lines>: Update.
 997
 998 2019-08-06  Tom Tromey  <tromey@adacore.com>
 999
1000         * source-cache.c (extract_lines): No longer a method.
1001         Changed type of parameter.  Include final newline.
1002         (selftests::extract_lines_test): New function.
1003         (_initialize_source_cache): Likewise.
1004         * source-cache.h (class source_cache)
1005         <extract_lines>: Don't declare.
1006
1007 2019-08-06  Tom Tromey  <tromey@adacore.com>
1008
1009         * breakpoint.c (init_breakpoint_sal): Update.
1010         (breakpoint): Update.
1011         * breakpoint.h (struct breakpoint) <filter>: Now a
1012         unique_xmalloc_ptr.
1013
1014 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1015
1016         * NEWS: Mention dictionary access on blocks.
1017         * python/py-block.c (blpy_getitem): New function.
1018         (block_object_as_mapping): New struct.
1019         (block_object_type): Use new struct for tp_as_mapping field.
1020
1021 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1022
1023         * objfiles.h (objfile): Add a comment describing partial symbols.
1024
1025 2019-08-05  Tom Tromey  <tromey@adacore.com>
1026
1027         * compile/compile.c (_initialize_compile): Use _(), not N_().
1028         * thread.c (_initialize_thread): Use _(), not N_().
1029         * stack.c (_initialize_stack): Use _(), not N_().
1030         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1031
1032 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1033
1034         * dwarf2read.c (struct dw2_symtab_iterator):
1035         <want_specific_block>: Remove.
1036         <block_index>: Change type to gdb::optional.
1037         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1038         change type of BLOCK_INDEX parameter to gdb::optional.
1039         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1040         (dw2_lookup_symbol): Don't pass argument for
1041         WANT_SPECIFIC_BLOCK.
1042         (dw2_expand_symtabs_for_function): Don't pass argument for
1043         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1044         (class dw2_debug_names_iterator)
1045         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1046         parameter, change BLOCK_INDEX type to gdb::optional.
1047         <m_want_specific_block>: Remove.
1048         <m_block_index>: Change type to gdb::optional.
1049         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1050         gdb::optional.  Re-write in function of gdb::optional.
1051         (dw2_debug_names_lookup_symbol): Don't pass argument for
1052         WANT_SPECIFIC_BLOCK.
1053         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1054         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1055         BLOCK_INDEX.
1056
1057 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1058
1059         * NEWS: Mention changes to "info sources" command.
1060
1061 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1062
1063         * symtab.c (filename_partial_match_opts): New struct type.
1064         (struct output_source_filename_data): New members
1065         regexp, c_regexp, partial_match.
1066         (output_source_filename): Use new members to decide to print file.
1067         (info_sources_option_defs): New variable.
1068         (make_info_sources_options_def_group, print_info_sources_header,
1069         info_sources_command_completer):
1070         New functions.
1071         (info_sources_command): Read new optional arguments.
1072         (_initialize_symtab): Update info sources help.
1073
1074 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1075
1076         * ada-lang.c (exception_support_info_v0): Renamed from...
1077         (default_exception_support_info): ... this.  Create new
1078         definition for v1.
1079         (ada_has_this_exception_support): Look up catch_handlers_sym.
1080         (ada_exception_support_info_sniffer): Try v0 after default.
1081
1082 2019-08-01  Tom Tromey  <tromey@adacore.com>
1083
1084         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1085         gdbarch.h.
1086
1087 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1088
1089         * s12z-tdep.c: Fix include path for s12z-opc.h.
1090
1091 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1092
1093         * NEWS: Require GNU make 3.82.
1094
1095 2019-07-16  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1098         declare.
1099
1100 2019-07-30  Tom Tromey  <tromey@adacore.com>
1101
1102         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1103
1104 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1105
1106         * printcmd.c (print_address_symbolic): Print negative offsets.
1107         (build_address_symbolic): Force signed arithmetic when computing
1108         offset.
1109
1110 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1111
1112         PR/24474: Add a function to lookup static variables.
1113         * NEWS: Mention this new function.
1114         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1115         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1116         * python/python.c (python_GdbMethods): Add new function.
1117
1118 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1119
1120         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1121         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1122         (objfpy_lookup_static_symbol): New function.
1123         (objfile_object_methods): Add new functions.
1124
1125 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1126
1127         * NEWS: Mention 'set|show print frame-info'.  Mention new
1128         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1129         backtrace argument.  Mention that python frame filtering code
1130         is now consistent with what 'backtrace' command prints.
1131
1132 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1133
1134         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1135         comments.
1136         (print_frame_info_auto, print_frame_info_source_line,
1137         print_frame_info_location, print_frame_info_source_and_location,
1138         print_frame_info_location_and_address, print_frame_info_short_location):
1139         New declarations.
1140         (struct frame_print_options): New member print_frame_info.
1141         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1142         * stack.h (get_user_print_what_frame_info): New declaration.
1143         (frame_show_address): New declaration.
1144         * stack.c (print_frame_arguments_choices): New value 'presence'.
1145         (print_frame_info_auto, print_frame_info_source_line,
1146         print_frame_info_location, print_frame_info_source_and_location,
1147         print_frame_info_location_and_address, print_frame_info_short_location,
1148         print_frame_info_choices, print_frame_info_print_what): New definitions.
1149         (print_frame_args): Only print dots for args if print frame-arguments
1150         is 'presence'.
1151         (frame_print_option_defs): New element for "frame-info".
1152         (get_user_print_what_frame_info): New function.
1153         (frame_show_address): Make non static.  Move comment to stack.h.
1154         (print_frame_info_to_print_what): New function.
1155         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1156         to decide what to print.
1157         (backtrace_command_1): Handle the new print_frame_arguments_presence
1158         value.
1159         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1160         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1161         (py_print_frame): In non-mi mode, use LOCATION as default for
1162         print_what, similarly to frame information printed directly by
1163         backtrace command. Handle frame-info user option in non MI mode.
1164
1165 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1166
1167         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1168         Add case for debugging 32-bit target on 64-bit host.  Revise
1169         comment.
1170
1171 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1172
1173         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1174         instead of find_function_entry_range_from_pc.
1175
1176 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1177
1178         * stack.c (find_frame_funname): Remove code which preferred
1179         minsym over symtab sym in "certain pathological cases".
1180
1181         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1182         parameter.  Change type of "do_demangle" to bool.
1183         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1184         Pass suitable "prefer_sym_over_minsym" flag to
1185         build_address_symbolic().  Don't output "+" for negative offsets.
1186         * printcmd.c (print_address_symbolic): Update invocation of
1187         build_address_symbolic to include a "prefer_sym_over_minsym"
1188         flag.
1189         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1190         Restrict cases in which use of minimal symbol is preferred to that
1191         of a found symbol.  Update comments.
1192
1193         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1194         for entry pc when entry pc is out of range for that FDE.
1195
1196 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1197
1198         PR gdb/24839:
1199         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1200         type.
1201
1202 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1203
1204         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1205         this function's Python signature.
1206
1207
1208 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1209
1210         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1211         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1212         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1213         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1214         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1215
1216
1217 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1218
1219         * h8300-tdep.c (h8300_register_name_common): New.
1220         h8300_register_name): Use h8300_register_name_common.
1221         (h8300s_register_name): Likewise.
1222         (h8300sx_register_name): Likewise.
1223         (h8300h_register_nam): New.
1224         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1225
1226
1227 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1228
1229         * arm-tdep.c (arm_skip_cmse_entry): New function.
1230         (arm_is_sgstubs_section): New function.
1231         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1232
1233 2019-07-22  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1236         Don't self-assign.
1237
1238 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1241         type_print.
1242
1243 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1246         so that GDB doesn't match any msymbols when searching in the
1247         TYPES_DOMAIN.
1248         (print_symbol_info): Print using typedef_print or type_print based
1249         on the type of the symbol.  Add updated FIXME comment moved from...
1250         (_initialize_symtab): ... move and update FIXME comment to above.
1251
1252 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1253
1254         * NEWS: Mention adding -q option to "info types".
1255         * symtab.c (struct info_types_options): New struct.
1256         (info_types_options_defs): New variable.
1257         (make_info_types_options_def_group): New function.
1258         (info_types_command): Use gdb::option framework to parse options.
1259         (info_types_command_completer): New function.
1260         (_initialize_symtab): Extend the help text on "info types" and
1261         register command completer.
1262
1263 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1264
1265         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1266         (lookup_symbol_in_objfile): Change int to block_enum and add a
1267         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1268
1269 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1270
1271         * MAINTAINERS (Write After Approval): Add self.
1272
1273 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1276         instruction to the dummy code region.
1277
1278 2019-07-19  Tom Tromey  <tromey@adacore.com>
1279
1280         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1281         (ARGSUSED, PARAMS, __func__): Remove rules.
1282
1283 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1284
1285         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1286         * features/arm/arm-with-iwmmxt.c: Remove.
1287         * features/arm/arm-with-iwmmxt.xml: Remove.
1288         * features/arm/arm-with-m-fpa-layout.c: Remove.
1289         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1290         * features/arm/arm-with-m-vfp-d16.c: Remove.
1291         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1292         * features/arm/arm-with-m.c: Remove.
1293         * features/arm/arm-with-m.xml: Remove.
1294         * features/arm/arm-with-neon.c: Remove.
1295         * features/arm/arm-with-neon.xml: Remove.
1296         * features/arm/arm-with-vfpv2.c: Remove.
1297         * features/arm/arm-with-vfpv2.xml: Remove.
1298         * features/arm/arm-with-vfpv3.c: Remove.
1299         * features/arm/arm-with-vfpv3.xml: Remove.
1300
1301 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1304
1305 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1306
1307         * arch/aarch32.c (aarch32_create_target_description): Create
1308         target descriptions using features.
1309         * arch/arm.c (arm_create_target_description)
1310         (arm_create_mprofile_target_description): Likewise.
1311         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1312
1313 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * Makefile.in: Add new files.
1316         * aarch32-tdep.c: New file.
1317         * aarch32-tdep.h: New file.
1318         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1319         Call aarch32_read_description.
1320         * arch/aarch32.c: New file.
1321         * arch/aarch32.h: New file.
1322         * arch/arm.c (arm_create_target_description)
1323         (arm_create_mprofile_target_description): New function.
1324         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1325         (arm_create_target_description)
1326         (arm_create_mprofile_target_description): New declaration.
1327         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1328         read_description functions.
1329         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1330         Likewise.
1331         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1332         * arm-tdep.c (tdesc_arm_list): New variable.
1333         (arm_register_g_packet_guesses): Call create description functions.
1334         (arm_read_description) (arm_read_mprofile_description): New
1335         function.
1336         * arm-tdep.h (arm_read_description)
1337         (arm_read_mprofile_description): Add declaration.
1338         * configure.tgt: Add new files.
1339
1340 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1341
1342         * top.c (new_ui_command): Open specified terminal just once.
1343
1344 2019-07-18  Tom Tromey  <tromey@adacore.com>
1345
1346         * symtab.c (main_name): Constify return type.
1347         * symfile.c (set_initial_language): Update.
1348         * symtab.h (main_name): Constify return type.
1349
1350 2019-07-17  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-winsource.c (tui_update_source_window)
1353         (tui_update_source_window_as_is)
1354         (tui_update_source_windows_with_line): Remove return.
1355         * tui/tui-disasm.c (tui_show_disassem)
1356         (tui_show_disassem_and_update_source): Remove return.
1357         * tui/tui.c (tui_reset): Remove return.
1358         * tui/tui-wingeneral.c
1359         (tui_check_and_display_highlight_if_needed): Remove return.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1364
1365 2019-07-17  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-winsource.h (struct tui_exec_info_window)
1368         (struct tui_source_window_base): Move from tui-data.h.
1369         * tui/tui-winsource.c: Move many method definitions from
1370         elsewhere.  Remove "structuring" comments.
1371         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1372         (tui_source_window_base::refresh_window): Move to
1373         tui-winsource.c.
1374         * tui/tui-win.c (tui_source_window_base::refresh_all)
1375         (tui_source_window_base::update_tab_width)
1376         (tui_source_window_base::set_new_height)
1377         (tui_source_window_base::do_make_visible_with_new_height): Move to
1378         tui-winsource.c.
1379         * tui/tui-source.h: Update.
1380         * tui/tui-source.c (tui_source_window_base::reset): Move to
1381         tui-winsource.c.
1382         * tui/tui-disasm.h: Update.
1383         * tui/tui-data.h (struct tui_exec_info_window): Move to
1384         tui-winsource.h.
1385         (struct tui_source_window_base): Likewise.
1386         * tui/tui-data.c (tui_source_window_base::clear_detail)
1387         (tui_source_window_base, ~tui_source_window_base): Move to
1388         tui-winsource.c.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-win.c (tui_resize_all)
1393         (tui_source_window_base::update_tab_width)
1394         (tui_adjust_win_heights): Update.
1395         (tui_win_info::make_invisible_and_set_new_height): Rename from
1396         make_invisible_and_set_new_height.
1397         * tui/tui-data.h (struct tui_win_info)
1398         <make_invisible_and_set_new_height>: New method.
1399
1400 2019-07-17  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui.c: Update.
1403         * tui/tui-source.h (struct tui_source_window): Move from
1404         tui-data.h.
1405         * tui/tui-layout.c: Update.
1406         * tui/tui-disasm.c: Update.
1407         * tui/tui-data.h (struct tui_source_window): Move to
1408         tui-source.h.
1409
1410 2019-07-17  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1413         tui-data.h.
1414         * tui/tui-data.h (struct tui_disasm_window): Move to
1415         tui-disasm.h.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-regs.h (struct tui_data_item_window): Move from
1420         tui-data.h.
1421         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1422         * tui/tui-data.h (struct tui_data_item_window): Move to
1423         tui-regs.h.
1424         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui.c: Update.
1429         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1430         (tui_cmd_window::max_height): Move to tui-command.c.
1431         * tui/tui-layout.c: Update.
1432         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1433         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1434         tui-command.c.
1435         * tui/tui-command.h (struct tui_cmd_window): Move from
1436         tui-data.h.
1437         * tui/tui-command.c: Remove "structuring" comments.
1438         (tui_cmd_window::clear_detail)
1439         (tui_cmd_window::do_make_visible_with_new_height)
1440         (tui_cmd_window::max_height): Move from elsewhere.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1445         Now static.
1446         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1447         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1448
1449 2019-07-17  Tom Tromey  <tom@tromey.com>
1450
1451         * tui/tui.c: Update.
1452         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1453         tui-regs.c.
1454         * tui/tui-windata.h: Remove file.
1455         * tui/tui-windata.c: Remove file.
1456         * tui/tui-win.c (tui_data_window::set_new_height)
1457         (tui_data_window::do_make_visible_with_new_height): Move to
1458         tui-regs.c.
1459         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1460         * tui/tui-regs.c: Remove "structuring" comments.
1461         (tui_data_window::first_data_item_displayed)
1462         (tui_data_window::delete_data_content_windows)
1463         (tui_data_window::erase_data_content)
1464         (tui_data_window::display_all_data)
1465         (tui_data_window::refresh_all)
1466         (tui_data_window::do_scroll_vertical)
1467         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1468         (tui_data_window::do_make_visible_with_new_height)
1469         (tui_data_window::refresh_window): Move from elsewhere.
1470         (_initialize_tui_regs): Move to end of file.
1471         * tui/tui-layout.c: Update.
1472         * tui/tui-hooks.c: Update.
1473         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1474         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1475         tui-regs.c.
1476         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1477
1478 2019-07-17  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1481         seen.
1482
1483 2019-07-17  Tom Tromey  <tom@tromey.com>
1484
1485         * tui/tui-win.c (tui_source_window_base::set_new_height)
1486         (tui_source_window_base::do_make_visible_with_new_height): Use
1487         m_has_locator field directly.
1488         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1489         method.
1490         (struct tui_source_window_base) <has_locator>: Likewise.
1491
1492 2019-07-17  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1495         Don't declare.
1496         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1497         Remove.
1498         * tui/tui-win.c (tui_source_window_base::set_new_height)
1499         (tui_source_window_base::set_new_height)
1500         (make_invisible_and_set_new_height)
1501         (tui_source_window_base::do_make_visible_with_new_height)
1502         (tui_source_window_base::do_make_visible_with_new_height):
1503         Update.
1504         * tui/tui-layout.c (show_source_disasm_command, show_data)
1505         (show_source_or_disasm_and_command): Update.
1506         * tui/tui-layout.c (show_layout): Update.
1507
1508 2019-07-17  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-layout.c (make_data_window): Remove.
1511         (show_data): Unify creation and re-initialization cases.
1512
1513 2019-07-17  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-layout.c (make_source_window, make_disasm_window):
1516         Remove.
1517         (show_data): Unify creation and re-initialization cases.
1518
1519 2019-07-17  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-layout.c (make_command_window): Remove.
1522         (show_source_disasm_command, show_source_or_disasm_and_command):
1523         Unify creation and re-initialization cases.
1524
1525 2019-07-17  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1528         creation and re-initialization cases.
1529
1530 2019-07-17  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-regs.c (tui_get_register): Return void.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1537         Simplify.
1538
1539 2019-07-17  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1542         resetting.
1543
1544 2019-07-17  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1547         * tui/tui-regs.c (tui_reg_layout): New function.
1548         (tui_show_registers, tui_reg_command): Use it.
1549         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1550         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1551         parameters.
1552         (tui_layout_command): Remove.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-layout.h (tui/tui-layout): Return void.
1557         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1558
1559 2019-07-17  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-layout.c (show_source_disasm_command, show_data):
1562         Update.
1563         (reset_locator): Remove.
1564         (show_source_or_disasm_and_command): Update.
1565
1566 2019-07-17  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui-source.c (tui_source_window_base::reset): Remove
1569         win_type parameter.
1570         * tui/tui-layout.c (make_command_window, make_source_window)
1571         (make_disasm_window, make_data_window)
1572         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1573         (reset_locator, show_source_or_disasm_and_command): Update.
1574         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1575         win_type parameter.
1576         (struct tui_source_window_base) <reset>: Likewise.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-layout.c (show_source_disasm_command): Use
1581         reset_locator.
1582         (reset_locator): New function.
1583         (init_and_make_win): Remove.
1584         (show_source_or_disasm_and_command): Use reset_locator.
1585
1586 2019-07-17  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1589         condition.
1590         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1591         Remove condition.
1592         * tui/tui-source.c (tui_source_window_base::reset): New method.
1593         * tui/tui-layout.c (make_command_window): Don't call
1594         init_and_make_win.
1595         (make_source_window, make_disasm_window): Don't call
1596         make_source_or_disasm_window.
1597         (make_data_window): Don't call init_and_make_win.  Change calling
1598         convention.
1599         (show_source_disasm_command, show_data): Simplify.
1600         (make_source_or_disasm_window): Remove.
1601         (show_source_or_disasm_and_command): Simplify.
1602         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1603         (struct tui_source_window_base) <reset>: Likewise.
1604         <execution_info>: Remove initializer.
1605         * tui/tui-data.c (tui_source_window_base): Initialize
1606         execution_info.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1611         variable.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui.c (tui_rl_other_window): Update.
1616         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1617         superclass method first.  Always iterate over regs_content.
1618         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1619         method.
1620         * tui/tui-win.c (tui_set_focus_command): Update.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-win.c (tui_set_focus_command): Rename from
1625         tui_set_focus.  Call tui_enable.
1626         (tui_set_focus_command): Remove.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1631         refresh_window.
1632         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1633         touchwin.
1634         (tui_data_window::refresh_window): Call refresh_window on data
1635         items.  Always call superclass refresh_window.
1636         (tui_win_info::refresh): Remove.
1637         (tui_source_window_base::refresh_window): Update.
1638         (tui_refresh_all): Update.
1639         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1640         refresh_window.
1641         (show_source_or_disasm_and_command): Likewise.
1642         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1643         (struct tui_source_window_base) <refresh>: Likewise.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-winsource.c (tui_clear_source_content)
1648         (tui_show_source_content): Update.
1649         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1650         whether content is empty.
1651         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1652         Remove.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1657         window's contents.
1658         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1659         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1664         (struct tui_data_item_window): Update.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1669         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1670         defines.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-winsource.h (tui_erase_source_content)
1675         (tui_clear_source_content): Remove "display_prompt" parameter.
1676         * tui/tui-winsource.c (tui_update_source_window_as_is)
1677         (tui_update_source_windows_with_addr): Update.
1678         (tui_clear_source_content): Remove "display_prompt" parameter.
1679         (tui_erase_source_content): Likewise.  Simplify.
1680         (tui_show_source_content): Update.
1681         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1682         * tui/tui-stack.c (tui_show_frame_info): Update.
1683         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1684         Remove defines.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1689         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1690         parameter.
1691         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1692         parameter.
1693
1694 2019-07-17  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-winsource.c (tui_clear_source_content)
1697         (tui_show_source_content, tui_show_exec_info_content)
1698         (tui_clear_exec_info_content): Update.
1699         * tui/tui-stack.c (tui_show_locator_content): Update.
1700         (tui_show_frame_info): Update.
1701         * tui/tui-source.h (tui_source_window): Don't declare.
1702         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1703         from tui_source_is_displayed.
1704         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1705         Remove field.
1706         (struct tui_source_window_base) <content_in_use>: New field.  Now
1707         bool.
1708         (struct tui_source_window) <showing_source_p>: New method.
1709         (TUI_SRC_WIN): Change cast.
1710         * tui/tui-data.c (tui_initialize_static_data): Update.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1715         location_matches_p.
1716         * tui/tui-source.c (tui_source_window::location_matches_p): New
1717         method.
1718         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1719         method.
1720         * tui/tui-data.h (struct tui_source_window_base)
1721         <location_matches_p>: New method.
1722         (struct tui_source_window, struct tui_disasm_window)
1723         <location_matches_p>: Likewise.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-win.c (tui_set_win_height_command): Rename from
1728         tui_set_win_height.
1729         (tui_set_win_height_command): Remove.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-source.c (tui_source_window): New constructor.  Add
1734         observer.
1735         (~tui_source_window): New destructor.
1736         (tui_source_window::style_changed): New method.
1737         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1738         (tui_attach_detach_observers): Update.
1739         * tui/tui-data.h (struct tui_source_window): Make constructor not
1740         inline.  Add destructor.
1741         (struct tui_source_window) <style_changed>: New method.
1742         <m_observable>: New member.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1747         * tui/tui-win.c (tui_resize_all): Fix typo.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1752         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1753         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1754         * tui/tui-win.c (window_name_completer): Use foreach.
1755         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1756         (update_tab_width): Likewise.
1757         * tui/tui-layout.c (show_layout): Update.
1758         * tui/tui-data.h (class tui_window_iterator): New.
1759         (struct all_tui_windows): New.
1760         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1761
1762 2019-07-17  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1765         parameter.  Don't reference globals.
1766         (tui_reg_command): Update.
1767
1768 2019-07-17  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-regs.c (tui_show_registers): Simplify.
1771
1772 2019-07-17  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-regs.c (tui_show_registers): Update.
1775         (tui_show_register_group): Add win_info parameter.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1780         Rename from tui_display_reg_element_at_line.
1781         (tui_data_window::display_registers_from_line): Update.
1782         * tui/tui-data.h (struct tui_data_window)
1783         <display_reg_element_at_line>: New method.
1784
1785 2019-07-17  Tom Tromey  <tom@tromey.com>
1786
1787         * tui/tui-regs.h (tui_display_registers_from)
1788         (tui_display_registers_from_line): Don't declare.
1789         * tui/tui-windata.c (tui_data_window::display_all_data)
1790         (tui_data_window::refresh_all)
1791         (tui_data_window::do_scroll_vertical): Update.
1792         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1793         from tui_display_registers_from.
1794         (tui_display_reg_element_at_line): Update.
1795         (tui_data_window::display_registers_from_line): Rename from
1796         tui_display_registers_from_line.
1797         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1798         display_registers_from_line>: New methods.
1799
1800 2019-07-17  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1803         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1804         from tui_erase_data_content.
1805         (tui_data_window::display_all_data)
1806         (tui_data_window::refresh_all)
1807         (tui_data_window::do_scroll_vertical): Update.
1808         * tui/tui-regs.c (tui_show_registers): Update.
1809         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1810         New method.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1815         declare.
1816         * tui/tui-windata.c
1817         (tui_data_window::delete_data_content_windows): Rename from
1818         tui_delete_data_content_windows.
1819         (tui_data_window::display_all_data)
1820         (tui_data_window::do_scroll_vertical): Update.
1821         * tui/tui-data.h (struct tui_data_window)
1822         <delete_data_content_windows>: New method.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1827         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1828
1829 2019-07-17  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1832         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1833         from tui_display_all_data.
1834         * tui/tui-win.c
1835         (tui_data_window::do_make_visible_with_new_height): Update.
1836         * tui/tui-regs.c (tui_show_registers): Update.
1837         * tui/tui-layout.c (tui_set_layout): Update.
1838         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1839         method.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1844         * tui/tui-windata.c (tui_display_data_from): Remove.
1845         (tui_data_window::refresh_all): Update.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1850         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1851         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1852         tui_display_registers_from_line.
1853         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1854         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1855         "force_display" parameter.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1860         declare.
1861         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1862         Rename from tui_first_reg_element_no_inline.
1863         (tui_display_reg_element_at_line)
1864         (tui_display_registers_from_line): Update.
1865         * tui/tui-data.h (struct tui_data_window)
1866         <first_reg_element_no_inline>: New method.
1867
1868 2019-07-17  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-windata.c (tui_display_data_from)
1871         (tui_data_window::do_scroll_vertical): Update.
1872         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1873         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1874         Rename from tui_line_from_reg_element_no.
1875         (tui_display_registers_from_line): Update.
1876         * tui/tui-data.h (struct tui_data_window)
1877         <line_from_reg_element_no>: New method.
1878
1879 2019-07-17  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1882         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1883         tui_last_regs_line_no.
1884         (tui_display_reg_element_at_line)
1885         (tui_display_registers_from_line): Update.
1886         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1887         method.
1888
1889 2019-07-17  Tom Tromey  <tom@tromey.com>
1890
1891         PR tui/24722:
1892         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1893         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1894         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1895         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1896         (tui_update_breakpoint_info): Likewise.
1897         * tui/tui-hooks.c (tui_event_create_breakpoint)
1898         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1899         Update.
1900
1901 2019-07-17  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1904
1905 2019-07-17  Tom Tromey  <tom@tromey.com>
1906
1907         * tui/tui-winsource.c (tui_update_source_window_as_is)
1908         (tui_update_source_windows_with_addr): Update.
1909         * tui/tui-source.h (tui_set_source_content)
1910         (tui_show_symtab_source): Add "win_info" parameter.
1911         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1912         parameter.
1913         (tui_show_symtab_source): Likewise.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-wingeneral.c
1918         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1919
1920 2019-07-17  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1923         (struct tui_cmd_window) <can_scroll>: New method.
1924         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1925         method.
1926
1927 2019-07-17  Tom Tromey  <tromey@adacore.com>
1928
1929         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1930         do_field_signed>: Rename.  Change type of "value".
1931         * ui-out.c (ui_out::field_signed): Rename from field_int.
1932         Change type of "value".
1933         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1934         type of "value".
1935         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1936         do_field_int.  Change type of "value".
1937         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1938         do_field_int.  Change type of "value".
1939         * tracepoint.c (trace_status_mi, tfind_1)
1940         (print_one_static_tracepoint_marker): Update.
1941         * thread.c (print_thread_info_1, print_selected_thread_frame):
1942         Update.
1943         * stack.c (print_frame, print_frame_info): Update.
1944         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1945         Update.
1946         * source.c (print_source_lines_base): Update.
1947         * skip.c (info_skip_command): Update.
1948         * record-btrace.c (btrace_ui_out_decode_error)
1949         (btrace_call_history_src_line): Update.
1950         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1951         Update.
1952         * progspace.c (print_program_space): Update.
1953         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1954         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1955         do_field_int.  Change type of "value".
1956         * mi/mi-out.c (mi_ui_out::do_table_begin)
1957         (mi_ui_out::do_table_header): Update.
1958         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1959         type of "value".
1960         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1961         (mi_cmd_data_list_changed_registers, output_register)
1962         (mi_cmd_data_read_memory, mi_load_progress)
1963         (mi_cmd_trace_frame_collected): Update.
1964         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1965         Update.
1966         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1967         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1968         (mi_cmd_var_list_children, varobj_update_one): Update.
1969         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1970         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1972         * inferior.c (print_inferior): Update.
1973         * gdb_bfd.c (print_one_bfd): Update.
1974         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1975         Update.
1976         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1977         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1978         do_field_int.  Change type of "value".
1979         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1980         do_field_int.  Change type of "value".
1981         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1982         (print_one_breakpoint_location, print_it_catch_fork)
1983         (print_one_catch_fork, print_it_catch_vfork)
1984         (print_one_catch_vfork, print_it_catch_solib)
1985         (print_it_catch_exec, print_it_ranged_breakpoint)
1986         (print_mention_watchpoint, print_mention_masked_watchpoint)
1987         (bkpt_print_it, update_static_tracepoint): Update.
1988         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1989         * break-catch-syscall.c (print_it_catch_syscall): Update.
1990         * ada-tasks.c (print_ada_task_info): Update.
1991         * ada-lang.c (print_it_exception, print_mention_exception):
1992         Update.
1993
1994 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1995
1996         PR breakpoints/24541
1997         * gdbarch.c: Regenerate.
1998         * gdbarch.h: Regenerate.
1999         * gdbarch.sh: Adjust return type and parameter types for
2000         'stap_adjust_register'.
2001         (i386_stap_adjust_register): Adjust signature and return new
2002         register name.
2003         * stap-probe.c (stap_parse_register_operand): Adjust use of
2004         'gdbarch_stap_adjust_register'.
2005
2006 2019-07-17  Tom Tromey  <tromey@adacore.com>
2007
2008         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2009         declare VEC.
2010         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2011         std::vector.
2012         (struct s390_process_info): Add initializers.
2013         (s390_add_process): Use new.
2014         (s390_linux_nat_target::low_forget_process): Use delete.
2015         (s390_linux_nat_target::low_new_fork)
2016         (s390_linux_nat_target::stopped_by_watchpoint)
2017         (s390_linux_nat_target::low_prepare_to_resume)
2018         (s390_linux_nat_target::insert_watchpoint)
2019         (s390_linux_nat_target::insert_hw_breakpoint)
2020         (s390_linux_nat_target::remove_watchpoint)
2021         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2022
2023 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2024
2025         * aarch64-fbsd-nat.c: Include regcache.h.
2026         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2027         argument.
2028         (aarch64_fbsd_nat_target::fetch_registers)
2029         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2030         variable.
2031         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2032
2033 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2034
2035         * fbsd-nat.c: Include gdbarch.h.
2036
2037 2019-07-15  Tom Tromey  <tromey@adacore.com>
2038
2039         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2040
2041 2019-07-15  Tom Tromey  <tromey@adacore.com>
2042
2043         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2044         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2045         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2046         * cli-out.c (cli_ui_out::do_field_int): New method.
2047         * ui-out.c (ui_out::field_unsigned): New method.
2048         * symfile.c (generic_load): Use field_unsigned.
2049         (print_transfer_performance): Likewise.
2050         * record-btrace.c (ui_out_field_uint): Remove.
2051         (btrace_call_history_insn_range, btrace_call_history): Use
2052         field_unsigned.
2053         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2054         field_unsigned.
2055         * ui-out.h (class ui_out) <field_unsigned>: New method.
2056         <do_field_unsigned>: Likewise.
2057
2058 2019-07-15  Tom Tromey  <tromey@adacore.com>
2059
2060         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2061         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2062         * target.c (flash_erase_command): Use field_string.
2063         * infrun.c (print_signal_received_reason): Use field_string.
2064         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2065         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2066         field_string.
2067         * ada-tasks.c (print_ada_task_info): Use field_string.
2068
2069 2019-07-15  Tom Tromey  <tromey@adacore.com>
2070
2071         * target.c (flash_erase_command): Use field_core_addr.
2072         * symfile.c (generic_load): Use field_core_addr.
2073         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2074         Use field_core_addr.
2075         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2076         field_core_addr.
2077
2078 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2081         value if its desired type is smaller than a CORE_ADDR and signed.
2082
2083 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2086         of changes to field names, and use new is_reference field to
2087         decide if a property is a reference or not.
2088         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2089         field.
2090         (struct dwarf2_property_baton): Update header comment, rename
2091         'referenced_type' to 'property_type' and update comments.
2092         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2093         default property type, store in property baton, update to take
2094         accound of renamed field.
2095         (read_func_scope): Update call to attr_to_dynamic_prop.
2096         (read_array_type): Likewise.
2097         (dwarf2_per_cu_addr_sized_int_type): New function.
2098         (read_subrange_index_type): Move type finding code to
2099         dwarf2_per_cu_addr_sized_int_type.
2100         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2101         (dwarf2_per_cu_addr_type): New function.
2102         (set_die_type): Update calls to attr_to_dynamic_prop.
2103
2104 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * dwarf2read.c (read_subrange_index_type): New function.
2107         (read_subrange_type): Move code into new function and call it.
2108         * gdbtypes.c (create_range_type): Add some asserts.
2109
2110 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2113         update return statements.
2114         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2115         declaration, and update comment to match.
2116         * gdbtypes.c (resolve_dynamic_array): Update call to
2117         dwarf2_evaluate_property to match new return type.
2118
2119 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * valarith.c (value_subscripted_rvalue): Change lowerbound
2122         parameter type from int to LONGEST.
2123         * value.h (value_subscripted_rvalue): Likewise in declaration.
2124
2125 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2126
2127         * cli/cli-utils.c (info_print_command_completer): New function.
2128         * cli/cli-utils.h: Add 'completer.h' include, and forward
2129         declaration for 'struct cmd_list_element'.
2130         (info_print_command_completer): Declare.
2131         * stack.c (_initialize_stack): Add completer for 'info locals' and
2132         'info args'.
2133         * symtab.c (_initialize_symtab): Add completer for 'info
2134         variables' and 'info functions'.
2135         * NEWS: Mention completion for additional info commands.
2136
2137 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * cli/cli-utils.c (extract_info_print_args): Delete.
2140         (extract_arg_maybe_quoted): Delete.
2141         (info_print_options_defs): New variable.
2142         (make_info_print_options_def_group): New function.
2143         (extract_info_print_options): Define new function.
2144         * cli/cli-utils.h (extract_info_print_args): Delete.
2145         (struct info_print_options): New structure.
2146         (extract_info_print_options): Declare new function.
2147         * stack.c (info_locals_command): Update to use new
2148         extract_info_print_options, also add a header comment.
2149         (info_args_command): Likewise.
2150         * symtab.c (info_variables_command): Likewise.
2151         (info_functions_command): Likewise.
2152
2153 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2154
2155         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2156         to extract string arguments.
2157         * common/common-utils.c (extract_string_maybe_quoted): New function.
2158         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2159
2160 2019-07-11  Tom Tromey  <tromey@adacore.com>
2161
2162         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2163         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2164         * top.h (gdbinit): Don't declare.
2165         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2166         into...
2167         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2168         * top.c (gdb_init): Don't call init_cli_cmds.
2169         (gdbinit): Remove.
2170         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2171
2172 2019-07-11  Tom Tromey  <tromey@adacore.com>
2173
2174         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2175         after it has been moved.
2176
2177 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2178
2179         * valops.c (value_must_coerce_to_target): Change return type to
2180         bool.
2181         * value.h (value_must_coerce_to_target): Likewise.
2182
2183 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2184
2185         * breakpoint.c (is_hardware_watchpoint): Remove
2186         forward-declaration.
2187         (is_masked_watchpoint): Change return type to bool.
2188         (is_tracepoint): Likewise.
2189         (is_breakpoint): Likewise.
2190         (is_hardware_watchpoint): Likewise.
2191         (is_watchpoint): Likewise.
2192         (is_no_memory_software_watchpoint): Likewise.
2193         (is_catchpoint): Likewise.
2194         (breakpoint_1): Make FILTER parameter's return type bool.
2195         is_masked_watchpoint): Change return type to bool.
2196         (save_breakpoints): Make FILTER parameter's return type bool.
2197         * breakpoint.h (is_breakpoint): Change return type to bool.
2198         (is_watchpoint): Likewise.
2199         (is_catchpoint): Likewise.
2200         (is_tracepoint): Likewise.
2201
2202 2019-07-10  Tom Tromey  <tom@tromey.com>
2203
2204         * defs.h: Don't include gdbarch.h.
2205         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2206         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2207         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2208         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2209         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2210         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2211         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2212         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2213         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2214         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2215         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2216         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2217         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2218         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2219         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2220         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2221         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2222         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2223         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2224         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2225         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2226         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2227         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2228         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2229         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2230         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2231         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2232
2233 2019-07-10  Tom Tromey  <tromey@adacore.com>
2234
2235         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2236         * breakpoint.c (init_ada_exception_breakpoint): Register as
2237         bp_catchpoint.
2238         (print_one_breakpoint_location, print_one_breakpoint): Use
2239         is_ada_exception_catchpoint.
2240         * ada-lang.c (class ada_catchpoint_location): Pass
2241         bp_loc_software_breakpoint to bp_location constructor.
2242         (is_ada_exception_catchpoint): New function.
2243
2244 2019-07-10  Tom Tromey  <tromey@adacore.com>
2245
2246         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2247         VEC.
2248         (struct arm_exidx_entry): New method operator<.
2249         (struct arm_exidx_data) <section_maps>: Change type.
2250         (arm_exidx_data_free): Remove.
2251         (arm_exidx_data_key): Change type.  Move lower.
2252         (arm_exidx_new_objfile): Update.
2253         (arm_compare_exidx_entries): Remove.
2254         (arm_find_exidx_entry, _initialize_arm_tdep)
2255
2256 2019-07-10  Tom Tromey  <tromey@adacore.com>
2257
2258         * solib-spu.c (ocl_program_data_key): Change type.
2259         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2260         Update.
2261
2262 2019-07-10  Tom Tromey  <tromey@adacore.com>
2263
2264         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2265         (struct solib_aix_inferior_data) <library_list>: Change type.
2266         (solib_aix_inferior_data_handle): Change type.
2267         (get_solib_aix_inferior_data): Update.
2268         (solib_aix_free_library_list): Remove.
2269         (library_list_start_library): Update.
2270         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2271         return type.
2272         (solib_aix_get_library_list)
2273         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2274         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2275
2276 2019-07-10  Tom Tromey  <tromey@adacore.com>
2277
2278         * solib-dsbt.c (struct dsbt_info): Add initializers.
2279         (solib_dsbt_pspace_data): Change type.
2280         (dsbt_pspace_data_cleanup): Remove.
2281         (get_dsbt_info, _initialize_dsbt_solib): Update.
2282
2283 2019-07-10  Tom Tromey  <tromey@adacore.com>
2284
2285         * spu-tdep.c (spu_overlay_data): Change type.
2286         (spu_get_overlay_table, spu_overlay_new_objfile)
2287         (_initialize_spu_tdep): Update.
2288
2289 2019-07-10  Tom Tromey  <tromey@adacore.com>
2290
2291         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2292         destructor.
2293         (dbx_objfile_data_key): Change type and declare later.
2294         (DBX_SYMFILE_INFO): Rewrite.
2295         * dbxread.c (dbx_objfile_data_key): Change type.
2296         (dbx_symfile_init): Update.
2297         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2298         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2299         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2300
2301 2019-07-10  Tom Tromey  <tromey@adacore.com>
2302
2303         * jit.c (jit_program_space_key): Change type.  Move lower.
2304         (get_jit_program_space_data): Update.
2305         (jit_program_space_data_cleanup): Remove.
2306         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2307         Update.
2308         (struct jit_program_space_data): Add initializers.
2309
2310 2019-07-10  Tom Tromey  <tromey@adacore.com>
2311
2312         * solib-darwin.c (struct darwin_info): Add initializers.
2313         (solib_darwin_pspace_data): Change type.
2314         (darwin_pspace_data_cleanup): Remove.
2315         (get_darwin_info, _initialize_darwin_solib): Update.
2316
2317 2019-07-10  Tom Tromey  <tromey@adacore.com>
2318
2319         * remote-sim.c (struct sim_inferior_data): Add initializers,
2320         constructor, and destructor.
2321         (sim_inferior_data_key): Change type.  Move lower.
2322         (check_for_duplicate_sim_descriptor): Update.
2323         (get_sim_inferior_data): Use new.  Update.
2324         (~sim_inferior_data_cleanup): Rename from
2325         sim_inferior_data_cleanup.  Simplify.
2326         (gdbsim_close_inferior, simulator_command)
2327         (sim_command_completer, _initialize_remote_sim): Update.
2328         (next_pid, INITIAL_PID): Move earlier.
2329
2330 2019-07-10  Tom Tromey  <tromey@adacore.com>
2331
2332         * python/python-internal.h (create_thread_object): Return
2333         gdbpy_ref.
2334         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2335         * python/py-inferior.c (struct threadlist_entry): Add
2336         constructor.
2337         <thread_obj>: Now a gdbpy_ref.
2338         (thread_to_thread_object): Update.
2339         (add_thread_object): Use new.
2340         (delete_thread_object): Use delete.
2341         (infpy_threads): Update.
2342         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2343         GIL.
2344
2345 2019-07-10  Tom Tromey  <tromey@adacore.com>
2346
2347         * valops.c (value_cast): Specialize error message for Ada.
2348
2349 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2350
2351         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2352
2353 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2354
2355         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2356         bpstat_should_step): Return bool, adjust comments.
2357         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2358         bpstat_should_step): Likewise.
2359
2360 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2361
2362         * features/Makefile: Use feature target descriptions for Arm.
2363         * features/arm/arm-core.c: Generate new file.
2364         * features/arm/arm-fpa.c: Likewise.
2365         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2366         * features/arm/arm-m-profile.c: Likewise.
2367         * features/arm/arm-vfpv2.c: Likewise.
2368         * features/arm/arm-vfpv3.c: Likewise.
2369         * features/arm/xscale-iwmmxt.c: Likewise.
2370         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2371
2372 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2373
2374         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2375         ptrace earlier.
2376
2377 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2378
2379         * features/aarch64-pauth.c: Regenerate.
2380
2381 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2382
2383         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2384         bool.
2385         (bpstat_what): Use false instead of 0.
2386
2387 2019-07-09  Pedro Alves  <palves@redhat.com>
2388
2389         * break-catch-throw.c (is_exception_catchpoint): New.
2390         * breakpoint.c (print_one_breakpoint_location): New parameter
2391         'raw_loc'.  Handle it.  Use
2392         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2393         looking at the breakpoint's type.
2394         (print_one_breakpoint): If handling "maint info breakpoints", also
2395         print locations of exception catchpoints.
2396         * breakpoint.h (is_exception_catchpoint): Declare.
2397
2398 2019-07-09  Pedro Alves  <palves@redhat.com>
2399
2400         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2401         "addr" field.
2402         (allocate_location_exception_catchpoint): New.
2403         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2404         (initialize_throw_catchpoint_ops): Install
2405         allocate_location_exception_catchpoint as allocate_location
2406         method.
2407         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2408         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2409         bp_loc_other.
2410         (breakpoint_address_is_meaningful): Delete.
2411         (bl_address_is_meaningful): New.
2412         (breakpoint_locations_match): Adjust comment.
2413         (bp_location_from_bp_type): New, factored out of...
2414         (bp_location::bp_location(breakpoint *)): ... this.
2415         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2416         factored out of...
2417         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2418         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2419         breakpoint_address_is_meaningful.
2420         (bp_locations_compare): Adjust comment.
2421         (update_global_location_list): Use bl_address_is_meaningful
2422         instead of breakpoint_address_is_meaningful.
2423         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2424         explicit.
2425         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2426         * python/py-breakpoint.c (bppy_get_location): No longer check
2427         whether location is null.
2428
2429 2019-07-09  Pedro Alves  <palves@redhat.com>
2430
2431         PR c++/15468
2432         * breakpoint.c (print_one_breakpoint_location): Remove
2433         single-location assert.
2434
2435 2019-07-09  Tom Tromey  <tom@tromey.com>
2436
2437         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2438         * configure: Rebuild.
2439         * configure.ac: Change common to gdbsupport.
2440         * gdbsupport: Rename from common.
2441         * acinclude.m4: Change common to gdbsupport.
2442         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2443         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2444         gdbsupport.
2445         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2446         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2447         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2448         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2449         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2450         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2451         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2452         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2453         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2454         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2455         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2456         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2457         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2458         coff-pe-read.c, command.h, compile/compile-c-support.c,
2459         compile/compile-c.h, compile/compile-cplus-symbols.c,
2460         compile/compile-cplus-types.c, compile/compile-cplus.h,
2461         compile/compile-loc2c.c, compile/compile.c, completer.c,
2462         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2463         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2464         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2465         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2466         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2467         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2468         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2469         features/aarch64-core.c, features/aarch64-fpu.c,
2470         features/aarch64-pauth.c, features/aarch64-sve.c,
2471         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2472         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2473         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2474         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2475         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2476         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2477         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2478         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2479         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2480         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2481         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2482         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2483         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2484         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2485         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2486         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2487         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2488         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2489         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2490         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2491         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2492         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2493         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2494         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2495         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2496         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2497         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2498         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2499         minsyms.c, mips-linux-tdep.c, namespace.h,
2500         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2501         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2502         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2503         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2504         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2505         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2506         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2507         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2508         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2509         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2510         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2511         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2512         procfs.c, producer.c, progspace.h, psymtab.h,
2513         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2514         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2515         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2516         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2517         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2518         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2519         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2520         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2521         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2522         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2523         target-memory.c, target.c, target.h, target/waitstatus.c,
2524         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2525         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2526         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2527         unittests/array-view-selftests.c,
2528         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2529         unittests/common-utils-selftests.c,
2530         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2531         unittests/format_pieces-selftests.c,
2532         unittests/function-view-selftests.c,
2533         unittests/lookup_name_info-selftests.c,
2534         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2535         unittests/mkdir-recursive-selftests.c,
2536         unittests/observable-selftests.c,
2537         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2538         unittests/parse-connection-spec-selftests.c,
2539         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2540         unittests/scoped_fd-selftests.c,
2541         unittests/scoped_mmap-selftests.c,
2542         unittests/scoped_restore-selftests.c,
2543         unittests/string_view-selftests.c, unittests/style-selftests.c,
2544         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2545         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2546         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2547         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2548         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2549         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2550
2551 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2554         bool value.
2555         (decode_digits_ordinary): Set explicit_line field in sal.
2556         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2557         symtab_and_line that was set on an explicit line number in
2558         assembler code.  Do always update the recorded symtab and line if
2559         we do skip the prologue.
2560
2561 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * breakpoint.c (set_breakpoint_location_function): Remove
2564         explicit_loc parameter.
2565         (momentary_breakpoint_from_master): Update call to
2566         set_breakpoint_location_function.
2567         (add_location_to_breakpoint): Likewise.
2568
2569 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2570
2571         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2572         required features based on default bfd type when no specific bfd
2573         is present.
2574
2575 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2576
2577         * NEWS: Mention that GDB printf and eval commands can now print
2578         C-style and Ada-style convenience var strings without
2579         calling the inferior.
2580         * printcmd.c (printf_c_string): Locally print GDB internal var
2581         instead of transiting via the inferior.
2582         (printf_wide_c_string): Likewise.
2583
2584 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2587
2588 2019-07-04  Tom Tromey  <tom@tromey.com>
2589
2590         PR tui/24724:
2591         * tui/tui-winsource.c (tui_clear_source_content): Update.
2592         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2593         (tui_update_breakpoint_info): Update.
2594         (tui_set_exec_info_content): Update.
2595         * tui/tui-source.c (tui_set_source_content_nil): Update.
2596         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2597         has_break.
2598         * tui/tui-data.h (enum tui_bp_flag): New.
2599         (tui_bp_flags): New enum flags type.
2600         (struct tui_source_element) <break_mode>: Change type.  Rename
2601         from has_break.
2602         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2603         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2604         constants.
2605         * tui/tui-winsource.h: Fix comment.
2606
2607 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2610         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2611         (store_fpregs_to_thread)
2612         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2613         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2614         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2615         (IWMMXT_REGS_SIZE): Add define.
2616         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2617         (fetch_vfp_regs, store_vfp_regs)
2618         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2619         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2620
2621 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2624         defines.
2625         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2626         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2627         (ARM_INT_REGISTER_SIZE): ...to this.
2628         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2629         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2630         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2631         (arm_linux_collect_gregset, supply_nwfpe_register)
2632         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2633         defines.
2634         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2635         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2636         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2637         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2638         (arm_return_in_memory, arm_store_return_value)
2639         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2640         (arm_record_ld_st_multiple): Likewise.
2641         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2642         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2643
2644 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2645
2646         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2647         AARCH64_DISPLACED_MODIFIED_INSNS.
2648         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2649         (aarch64_displaced_step_copy_insn): Likewise.
2650         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2651         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2652         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2653         ARM_DISPLACED_MODIFIED_INSNS.
2654         * arm-tdep.c (arm_gdbarch_init): Likewise.
2655         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2656         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2657         (struct arm_displaced_step_closure): Use
2658         ARM_DISPLACED_MODIFIED_INSNS.
2659
2660 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * features/Makefile: Remove unused xml files.
2663         * features/aarch64.xml: Remove.
2664         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2665         * features/i386/amd64-avx-avx512.xml: Remove.
2666         * features/i386/amd64-avx-linux.xml: Remove.
2667         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2668         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2669         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2670         * features/i386/amd64-avx-mpx.xml: Remove.
2671         * features/i386/amd64-avx.xml: Remove.
2672         * features/i386/amd64-linux.xml: Remove.
2673         * features/i386/amd64-mpx-linux.xml: Remove.
2674         * features/i386/amd64-mpx.xml: Remove.
2675         * features/i386/amd64.xml: Remove.
2676         * features/i386/i386-avx-avx512-linux.xml: Remove.
2677         * features/i386/i386-avx-avx512.xml: Remove.
2678         * features/i386/i386-avx-linux.xml: Remove.
2679         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2680         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2681         * features/i386/i386-avx-mpx-linux.xml: Remove.
2682         * features/i386/i386-avx-mpx.xml: Remove.
2683         * features/i386/i386-avx.xml: Remove.
2684         * features/i386/i386-linux.xml: Remove.
2685         * features/i386/i386-mmx-linux.xml: Remove.
2686         * features/i386/i386-mmx.xml: Remove.
2687         * features/i386/i386-mpx-linux.xml: Remove.
2688         * features/i386/i386-mpx.xml: Remove.
2689         * features/i386/i386.xml: Remove.
2690         * features/i386/x32-avx-avx512-linux.xml: Remove.
2691         * features/i386/x32-avx-linux.xml: Remove.
2692         * features/i386/x32-linux.xml: Remove.
2693
2694 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2695
2696         * regformats/aarch64.dat: Remove.
2697         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2698         * regformats/i386/amd64-avx-linux.dat: Remove.
2699         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2700         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2701         * regformats/i386/amd64-linux.dat: Remove.
2702         * regformats/i386/amd64-mpx-linux.dat: Remove.
2703         * regformats/i386/amd64.dat: Remove.
2704         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2705         * regformats/i386/i386-avx-linux.dat: Remove.
2706         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2707         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2708         * regformats/i386/i386-linux.dat: Remove.
2709         * regformats/i386/i386-mmx-linux.dat: Remove.
2710         * regformats/i386/i386-mpx-linux.dat: Remove.
2711         * regformats/i386/i386.dat: Remove.
2712         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2713         * regformats/i386/x32-avx-linux.dat: Remove.
2714         * regformats/i386/x32-linux.dat: Remove.
2715
2716 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2717
2718         * aarch64-tdep.c: Remove xml self tests.
2719         * amd64-linux-tdep.c: Likewise.
2720         * amd64-tdep.c: Likewise.
2721         * i386-linux-tdep.c: Likewise.
2722         * i386-tdep.c: Likewise.
2723
2724 2019-07-03  Pedro Alves  <palves@redhat.com>
2725
2726         PR cli/24732
2727         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2728         (pipe_cmd_option_defs): New.
2729         (make_pipe_cmd_options_def_group): New.
2730         (pipe_command): Use gdb::option::process_options.
2731         (pipe_command_completer): New function.
2732         (_initialize_cli_cmds): Install completer for "pipe" command.
2733
2734 2019-07-03  Pedro Alves  <palves@redhat.com>
2735
2736         * cli/cli-option.c (union option_value) <string>: New field.
2737         (struct option_def_and_value): Add ctor, move ctor, dtor and
2738         use DISABLE_COPY_AND_ASSIGN.
2739         (option_def_and_value::clear_value): New.
2740         (parse_option, save_option_value_in_ctx, get_val_type_str)
2741         (add_setshow_cmds_for_options): Handle var_string.
2742         * cli-option.h (union option_def::var_address) <string>: New
2743         field.
2744         (struct string_option_def): New.
2745         * maint-test-options.c (struct test_options_opts): Add default
2746         ctor and use DISABLE_COPY_AND_ASSIGN.
2747         <string_opt>: New field.
2748         (test_options_opts::~test_options_opts): New.
2749         (test_options_opts::dump): Also dump "-string".
2750         (test_options_option_defs): Install "string.
2751
2752 2019-07-03  Pedro Alves  <palves@redhat.com>
2753
2754         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2755         option_value with a null enumeration.
2756         (complete_options): Save the option values in the context.
2757         (save_option_value_in_ctx): New, factored out from ...
2758         (process_options): ... here.
2759         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2760         of the function.
2761         * maint-test-options.c (test_options_opts::dump): New, factored
2762         out from ...
2763         (maintenance_test_options_command_mode): ... here.
2764         (maintenance_test_options_command_completion_result): Delete.
2765         (maintenance_test_options_command_completion_text): Update
2766         comment.
2767         (maintenance_show_test_options_completion_result): Change
2768         prototype.  Just print
2769         maintenance_test_options_command_completion_text.
2770         (save_completion_result): New.
2771         (maintenance_test_options_completer_mode): Pass options context to
2772         complete_options, and then save a dump.
2773         (_initialize_maint_test_options): Use add_cmd to install "maint
2774         show test-options-completion-result".
2775
2776 2019-07-03  Pedro Alves  <palves@redhat.com>
2777
2778         * NEWS (New commands): Mention "with" and "maint with".
2779         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2780         (with_command, with_command_completer): New.
2781         (pipe_command): Adjust to new repeat_previous
2782         interface.
2783         (_initialize_cli_cmds): Install the "with" command and its "w"
2784         alias.
2785         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2786         declarations.
2787         * cli/cli-setshow.c (parse_cli_var_uinteger)
2788         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2789         argument strings for all var_types.
2790         (get_setshow_command_value_string): New, factored out from ...
2791         (do_show_command): ... this.
2792         * cli/cli-setshow.h: Include <string>.
2793         (get_setshow_command_value_string): Declare.
2794         * command.h (repeat_previous): Now returns const char *.  Adjust
2795         comment.
2796         * maint.c: Include "cli/cli-cmds.h".
2797         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2798         (_initialize_maint_cmds): Register the "maintenance with" command.
2799         * top.c (repeat_previous): Move bits from pipe_command here:
2800         Return the saved command line, if any; error out if there's no
2801         command to relaunch.
2802
2803 2019-07-03  Pedro Alves  <palves@redhat.com>
2804
2805         * NEWS (New commands): Mention "maint set/show test-settings"
2806         instead of "maint test-settings".
2807         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2808         (maintenance_test_settings_set_list): Rename to ...
2809         (maintenance_set_test_settings_list): ... this.
2810         (maintenance_test_settings_show_list): Rename to  ...
2811         (maintenance_show_test_settings_list): ... this.
2812         (maintenance_test_settings_cmd): Delete.
2813         (maintenance_test_settings_set_cmd): ...
2814         (maintenance_set_test_settings_cmd): ... this.
2815         (maintenance_test_settings_show_cmd): ...
2816         (maintenance_show_test_settings_cmd): ... this.
2817         (maintenance_test_settings_show_value_cmd):
2818         (maintenance_show_test_settings_value_cmd): ... this.
2819         (_initialize_maint_test_settings): No longer install the "maint
2820         test-settings" prefix command.  Rename "maint test-settings set"
2821         to "maint set test-settings", and "maint test-settings show" to
2822         "maint show test-settings".  Adjust all subcommands.
2823
2824 2019-07-03  Pedro Alves  <palves@redhat.com>
2825
2826         * maint-test-settings.c: Fix file's intro comment.  Replace all
2827         references to "test-options" with references to "test-settings",
2828         in comments.
2829
2830 2019-07-03  Pedro Alves  <palves@redhat.com>
2831
2832         * maint-test-settings.c (maintenance_test_settings_xxx)
2833         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2834         New.
2835         (maintenance_test_settings_enums): Use them.
2836         (maintenance_test_settings_enum): Default to
2837         maintenance_test_settings_xxx.
2838         (_initialize_maint_test_settings): Initialize
2839         MAINTENANCE_TEST_SETTINGS_FILENAME.
2840
2841 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2842
2843         * breakpoint.h (remove_breakpoints_inf): Change return type to
2844         void, move function documentation here.
2845         * breakpoint.c (remove_breakpoints_inf): Change return type to
2846         void, move function documentation to header.
2847
2848 2019-07-02  Pedro Alves  <palves@redhat.com>
2849
2850         * NEWS (Completion improvements): Mention "info threads".
2851         * thread.c (struct info_threads_opts, info_threads_option_defs)
2852         (make_info_threads_options_def_group): New.
2853         (info_threads_command): Use gdb::option::process_options.
2854         (info_threads_command_completer): New.
2855         (_initialize_thread): Use gdb::option::build_help to build the
2856         help text for "info threads".
2857
2858 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2859
2860         * defs.h (generic_load): Move from here...
2861         * symfile.h (generic_load): ... to here.  Rename name parameter
2862         to args.
2863         * symfile.c (generic_load): Add comment.
2864
2865 2019-07-01  Tom Tromey  <tromey@adacore.com>
2866
2867         * dwarf2read.c
2868         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2869         declaration of without_params.  Fix formatting.
2870
2871 2019-07-01  Tom Tromey  <tromey@adacore.com>
2872
2873         * ada-exp.y (find_primitive_type): Update.
2874         * ada-lang.h (ada_lookup_symbol): Update.
2875         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2876         parameter.
2877         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2878
2879 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2880
2881         PR breakpoints/24541
2882         * gdbarch.c: Regenerate.
2883         * gdbarch.h: Regenerate.
2884         * gdbarch.sh: Add 'stap_adjust_register'.
2885         * i386-tdep.c: Include '<unordered_set>'.
2886         (i386_stap_adjust_register): New function.
2887         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2888         * stap-probe.c (stap_parse_register_operand): Call
2889         'gdbarch_stap_adjust_register'.
2890
2891 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2892
2893         PR python/24742
2894         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2895         * python/python.c (do_start_initialization): Use 'xmalloc'
2896         instead of 'PyMem_Malloc'.
2897
2898 2019-06-28  Tom Tromey  <tromey@adacore.com>
2899
2900         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2901         for Ada.
2902
2903 2019-06-27  Tom Tromey  <tromey@adacore.com>
2904
2905         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2906         objfile_key.
2907         (arm_find_mapping_symbol, arm_record_special_symbol)
2908         (_initialize_arm_tdep): Update.
2909         (arm_objfile_data_free): Remove.
2910
2911 2019-06-27  Tom Tromey  <tromey@adacore.com>
2912
2913         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2914         to cp_print_static_field.
2915
2916 2019-06-26  Tom Tromey  <tromey@adacore.com>
2917
2918         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2919         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2920         declare.
2921
2922 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2923
2924         * features/aarch64-core.c (create_feature_aarch64_core):
2925         Regenerate.
2926         * features/aarch64-core.xml: Add cpsr flags.
2927
2928 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2931         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2932
2933 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2934
2935         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2936         field.
2937         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2938         use.
2939         (arm_record_special_symbol): Don't insert new symbol in sorted
2940         position, push it at the end.
2941
2942 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2943
2944         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2945         (arm_mapping_symbol_s): Remove.
2946         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2947         (arm_mapping_symbol_vec): New typedef.
2948         (struct arm_per_objfile): Add constructor.
2949         <section_maps>: Change type to
2950         std::unique_ptr<arm_mapping_symbol_vec[]>.
2951         (arm_compare_mapping_symbols): Remove.
2952         (arm_find_mapping_symbol): Adjust to section_maps type change.
2953         (arm_objfile_data_free): Call delete on arm_per_objfile.
2954         (arm_record_special_symbol): Adjust to section_maps type change.
2955         Allocate arm_per_objfile with new.
2956
2957 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2958
2959         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2960         with the command prefix.
2961
2962 2019-06-25  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2965         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2966
2967 2019-06-25  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2970         type.
2971         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2972         protected.
2973
2974 2019-06-25  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-winsource.c
2977         (tui_source_window_base::set_is_exec_point_at): Add check against
2978         LOA_ADDRESS.
2979
2980 2019-06-25  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-source.c (tui_set_source_content): Don't check before
2983         xfree.
2984         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2985
2986 2019-06-25  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.h (tui_update_source_window_as_is)
2989         (tui_alloc_source_buffer, tui_line_is_displayed)
2990         (tui_addr_is_displayed): Change type of win_info.
2991         * tui/tui-winsource.c (tui_update_source_window_as_is)
2992         (tui_clear_source_content, tui_show_source_line)
2993         (tui_show_source_content, tui_source_window_base::refill)
2994         (tui_source_window_base::set_is_exec_point_at)
2995         (tui_source_window_base::set_is_exec_point_at)
2996         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2997         (tui_alloc_source_buffer, tui_line_is_displayed)
2998         (tui_addr_is_displayed): Change type of win_info.  Update.
2999         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3000         (tui_source_window_base::do_make_visible_with_new_height):
3001         Update.
3002         * tui/tui-source.c (tui_set_source_content)
3003         (tui_set_source_content_nil)
3004         (tui_source_window::do_scroll_vertical): Update.
3005         * tui/tui-layout.c (show_layout): Update.
3006         * tui/tui-disasm.c (tui_set_disassem_content)
3007         (tui_disasm_window::do_scroll_vertical): Update.
3008         * tui/tui-data.h (tui_win_content): Remove.
3009         (struct tui_gen_win_info) <content, content_size>: Remove.
3010         (struct tui_source_element): Add initializers and destructor.
3011         (union tui_which_element, struct tui_win_element): Remove.
3012         (struct tui_source_window_base) <content>: New field.
3013         (struct tui_data_window): Remove destructor.
3014         (tui_alloc_content, tui_free_win_content)
3015         (tui_free_all_source_wins_content): Don't declare.
3016         * tui/tui-data.c (tui_initialize_static_data): Update.
3017         (init_content_element, tui_alloc_content): Remove.
3018         (~tui_gen_win_info): Update.
3019         (~tui_data_window, tui_free_all_source_wins_content)
3020         (tui_free_win_content, free_content, free_content_elements):
3021         Remove.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-winsource.h (tui_clear_source_content)
3026         (tui_erase_source_content, tui_show_source_content): Change type
3027         of win_info.
3028         * tui/tui-winsource.c (tui_clear_source_content)
3029         (tui_erase_source_content, tui_show_source_content): Change type
3030         of win_info.
3031         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3032         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3033         win_info.
3034         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3035         win_info.
3036         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-winsource.c (tui_clear_source_content)
3041         (tui_source_window_base::set_is_exec_point_at): Update.
3042         * tui/tui-source.c (tui_set_source_content_nil): Update.
3043         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3044         a bool.
3045         * tui/tui-data.c (init_content_element): Update.
3046
3047 2019-06-25  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3050         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3051         * tui/tui-layout.c (init_and_make_win): Update.
3052         * tui/tui.h (enum tui_win_type): Update.
3053         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3054         tui_win_is_auxillary.
3055         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3056         tui_win_is_auxillary.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3061         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3062         (tui_delete_data_content_windows, tui_display_all_data)
3063         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3064         Update.
3065         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3066         * tui/tui-regs.c (tui_last_regs_line_no)
3067         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3068         (tui_show_registers): Update.
3069         (tui_show_register_group): Return void.  Update.
3070         (tui_display_registers_from, tui_display_reg_element_at_line)
3071         (tui_display_registers_from_line, tui_check_register_values):
3072         Update.
3073         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3074         member.
3075         (struct tui_data_window) <regs_content>: Now a std::vector.
3076         <regs_content_count>: Remove.
3077         (tui_add_content_elements, tui_free_data_content): Don't declare.
3078         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3079         (init_content_element): Remove DATA_WIN case.  Add assert.
3080         (tui_add_content_elements): Remove.
3081         (tui_data_window): Update.
3082         (tui_free_data_content): Remove.
3083         (free_content_elements): Remove DATA_WIN case.
3084
3085 2019-06-25  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-data.c (tui_data_item_window): Update.
3088         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3089         * tui/tui-windata.c (tui_display_all_data)
3090         (tui_display_data_from_line): Update.
3091         (tui_check_data_values): Remove.
3092         * tui/tui-regs.c (tui_show_register_group)
3093         (tui_display_reg_element_at_line): Update.
3094         * tui/tui-hooks.c (tui_register_changed)
3095         (tui_refresh_frame_and_register_information): Call
3096         tui_check_register_values.
3097         * tui/tui-data.h (struct tui_data_window) <data_content,
3098         data_content_count, data_type>: Remove.
3099         (enum tui_data_type): Remove.
3100
3101         * tui/tui-data.c (tui_data_window::clear_detail)
3102         (~tui_data_window): Update.
3103
3104 2019-06-25  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3107         declare.
3108         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3109         Rename from tui_first_data_item_displayed.  Update.
3110         (tui_data_window::refresh_all)
3111         (tui_data_window::do_scroll_vertical): Update.
3112         * tui/tui-data.h (struct tui_data_window)
3113         <first_data_item_displayed>: Declare new method.
3114
3115 2019-06-25  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3118         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3119         contents...
3120         (tui_initialize_static_data): ...here.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3125         (tui_display_registers_from, tui_check_register_values): Update.
3126         (tui_display_register): Remove win_info parameter; update.
3127         (tui_get_register): Change type of parameters.
3128         * tui/tui-data.h (struct tui_data_element): Remove.
3129         (union tui_which_element) <data>: Remove.
3130         <data_window>: Change type.
3131         (struct tui_data_item_window): New.
3132         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3133         case.  Add assert.
3134         (~tui_data_item_window): New destructor.
3135         (free_content_elements): Remove DATA_ITEM_WIN case.
3136
3137 2019-06-25  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3140         Remove.
3141
3142 2019-06-25  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-data.h (struct tui_command_element): Remove.
3145         (union tui_which_element) <command>: Remove.
3146         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3147         assert.
3148         (free_content_elements): Remove CMD_WIN case.
3149
3150 2019-06-25  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-layout.c (tui_set_layout): Update.
3153         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3154         * tui/tui-data.c (layout_def): Update.
3155
3156 2019-06-25  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3159         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3160         (tui_source_window_base::set_new_height): Update.
3161         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3162         Update.
3163         (tui_set_locator_fullname, tui_set_locator_info)
3164         (tui_show_frame_info): Update.
3165         * tui/tui-source.c (tui_set_source_content)
3166         (tui_source_is_displayed): Update.
3167         * tui/tui-layout.c (show_source_disasm_command, show_data)
3168         (show_source_or_disasm_and_command): Update.
3169         * tui/tui-disasm.c (tui_set_disassem_content)
3170         (tui_get_begin_asm_address): Update.
3171         * tui/tui-data.h (struct tui_locator_element): Remove.
3172         (union tui_which_element) <locator>: Remove.
3173         (struct tui_locator_window): New.
3174         (tui_locator_win_info_ptr): Change return type.
3175         * tui/tui-data.c (_locator): Change type.
3176         (tui_locator_win_info_ptr): Change return type.
3177         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3178         (tui_alloc_content): Add assert.
3179
3180 2019-06-25  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-winsource.c
3183         (tui_exec_info_window::maybe_allocate_content): New method.
3184         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3185         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3186         (make_source_or_disasm_window): Add cast.
3187         * tui/tui-data.h (union tui_which_element) <simple_string>:
3188         Remove.
3189         (struct tui_source_info): New.
3190         (struct tui_source_window_base) <execution_info>: Change type.
3191         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3192         case, and add assert.
3193         (tui_alloc_content): Add assert.
3194
3195 2019-06-25  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3198         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3199         * tui/tui-data.c (tui_alloc_win_info): Remove.
3200
3201 2019-06-25  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3204         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3205         can_highlight.
3206
3207 2019-06-25  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3210         make_visible_with_new_height method.
3211         (tui_win_info::make_visible_with_new_height): New method.
3212         (tui_source_window_base::do_make_visible_with_new_height)
3213         (tui_data_window::do_make_visible_with_new_height)
3214         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3215         (make_visible_with_new_height): Remove.
3216         (tui_resize_all, tui_adjust_win_heights): Use
3217         make_visible_with_new_height method.
3218         * tui/tui-data.h (struct tui_win_info)
3219         <do_make_visible_with_new_height, make_visible_with_new_height>:
3220         New methods.
3221         (struct tui_source_window_base, struct tui_data_window)
3222         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3223         methods.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3228         method.
3229         (update_tab_width): Call update_tab_width method.
3230         * tui/tui-data.h (struct tui_win_info)
3231         (struct tui_source_window_base) <update_tab_width>: New methods.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3236         parameter.
3237         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3238         parameter.
3239         (tui_gen_win_info::make_visible): Update.
3240         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3241         parameter.
3242         * tui/tui-data.h (enum tui_box): New enum.
3243         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3244
3245 2019-06-25  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3248         init_and_make_win for EXEC_INFO_WIN.
3249         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3250         longer inline.
3251         (struct tui_win_info) <~tui_win_info>: Inline.
3252         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3253         Don't declare.
3254         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3255         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3256         Remove.
3257         (tui_initialize_static_data): Update.
3258         (~tui_gen_win_info): Handle more cleanup here.
3259         (~tui_source_window_base): Delete "execution_info".
3260         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-layout.c (make_command_window): Don't set
3265         can_highlight.
3266         (show_source_disasm_command): Call the reset method.
3267         (show_data): Don't set can_highlight.  Call the reset method.
3268         (tui_gen_win_info::reset): Rename from init_gen_win_info
3269         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3270         (show_source_or_disasm_and_command): Call the reset method.
3271         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3272         (struct tui_cmd_window): Set can_highlight.
3273
3274 2019-06-25  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3277         from make_visible.
3278         (tui_make_visible, tui_make_invisible): Rewrite.
3279         (tui_win_info::make_visible): Remove.
3280         (tui_source_window_base::make_visible): Update.
3281         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3282         method.  Moved from...
3283         (struct tui_win_info) <make_visible>: ...here.
3284
3285 2019-06-25  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-winsource.c
3288         (tui_source_window_base::do_scroll_horizontal): Remove direction
3289         parameter.
3290         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3291         direction parameter.
3292         * tui/tui-win.c (tui_win_info::forward_scroll)
3293         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3294         (tui_win_info::right_scroll): Update.
3295         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3296         direction parameter.
3297         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3298         direction parameter.
3299         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3300         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3301         Remove direction parameter.
3302         (struct tui_source_window_base, struct tui_source_window)
3303         (struct tui_disasm_window, struct tui_data_window)
3304         (struct tui_cmd_window): Update.
3305
3306 2019-06-25  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-winsource.h (tui_set_exec_info_content)
3309         (tui_show_exec_info_content, tui_erase_exec_info_content)
3310         (tui_clear_exec_info_content, tui_update_exec_info): Change
3311         argument to tui_source_window_base.
3312         * tui/tui-winsource.c (tui_set_exec_info_content)
3313         (tui_show_exec_info_content, tui_erase_exec_info_content)
3314         (tui_clear_exec_info_content, tui_update_exec_info): Change
3315         argument to tui_source_window_base.
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3320         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3321
3322 2019-06-25  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3325         check.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3330         type to void.
3331         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3332         type to void.
3333         * tui/tui-source.c (tui_set_source_content): Update.
3334         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3335
3336 2019-06-25  Tom Tromey  <tom@tromey.com>
3337
3338         * tui/tui-win.c (window_name_completer, tui_set_focus)
3339         (tui_all_windows_info): Use name method.
3340         * tui/tui-data.h (struct tui_gen_win_info)
3341         (struct tui_source_window, struct tui_disasm_window)
3342         (struct tui_data_window, struct tui_cmd_window) <name>: New
3343         method.
3344         (tui_win_name): Don't declare.
3345         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3346         (tui_win_name): Remove.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-winsource.h (tui_update_source_window)
3351         (tui_update_source_window_as_is): Change parameter type.
3352         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3353         to be a tui_source_window_base.
3354         (tui_update_source_window_as_is): Likewise.
3355         * tui/tui-win.c (make_visible_with_new_height): Update.
3356
3357 2019-06-25  Tom Tromey  <tom@tromey.com>
3358
3359         * tui/tui-winsource.c (tui_erase_source_content)
3360         (tui_show_source_content, tui_show_exec_info_content)
3361         (tui_erase_exec_info_content): Use refresh_window method.
3362         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3363         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3364         from tui_refresh_win.
3365         (tui_data_window::refresh_window): New method.
3366         (tui_win_info::refresh, tui_source_window_base::refresh)
3367         (tui_refresh_all): Use refresh_window method.
3368         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3369         method.
3370         * tui/tui-regs.c (tui_display_register): Call refresh_window
3371         method.
3372         * tui/tui-layout.c (show_source_disasm_command)
3373         (show_source_or_disasm_and_command): Call refresh_window method.
3374         * tui/tui-data.h (struct tui_gen_win_info)
3375         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3376         New method.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui.c (tui_rl_other_window, tui_enable)
3381         (tui_is_window_visible, tui_get_command_dimension): Update.
3382         * tui/tui-winsource.c (tui_update_source_window_as_is)
3383         (tui_clear_source_content, tui_erase_source_content)
3384         (tui_show_source_line, tui_source_window_base::refill)
3385         (tui_source_window_base::do_scroll_horizontal)
3386         (tui_source_window_base::set_is_exec_point_at)
3387         (tui_update_breakpoint_info, tui_set_exec_info_content)
3388         (tui_alloc_source_buffer, tui_line_is_displayed)
3389         (tui_addr_is_displayed): Update.
3390         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3391         (tui_check_and_display_highlight_if_needed)
3392         (tui_win_info::make_visible, tui_win_info::refresh)
3393         (tui_refresh_all): Update.
3394         * tui/tui-windata.c (tui_first_data_item_displayed)
3395         (tui_delete_data_content_windows, tui_erase_data_content)
3396         (tui_display_all_data, tui_data_window::refresh_all)
3397         (tui_check_data_values): Update.
3398         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3399         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3400         (tui_win_info::backward_scroll, tui_refresh_all_win)
3401         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3402         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3403         (tui_source_window_base::set_new_height)
3404         (tui_data_window::set_new_height)
3405         (make_invisible_and_set_new_height)
3406         (make_visible_with_new_height, new_height_ok)
3407         (parse_scrolling_args): Update.
3408         * tui/tui-stack.c (tui_show_frame_info): Update.
3409         * tui/tui-source.c (tui_set_source_content)
3410         (tui_set_source_content_nil, tui_source_is_displayed)
3411         (tui_source_window::do_scroll_vertical): Update.
3412         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3413         (tui_display_registers_from, tui_display_reg_element_at_line)
3414         (tui_check_register_values, tui_reg_command): Update.
3415         * tui/tui-layout.c (tui_default_win_height)
3416         (show_source_disasm_command, show_data, init_and_make_win)
3417         (show_source_or_disasm_and_command): Update.
3418         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3419         (tui_redisplay_readline, tui_mld_flush)
3420         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3421         (tui_getc): Update.
3422         * tui/tui-disasm.c (tui_set_disassem_content)
3423         (tui_disasm_window::do_scroll_vertical): Update.
3424         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3425         Now virtual.
3426         (struct tui_win_info): Derive from tui_gen_win_info.
3427         <~tui_win_info>: Mark as override.
3428         <generic>: Remove member.
3429         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3430         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3431         (~tui_data_window, ~tui_win_info)
3432         (tui_free_all_source_wins_content): Update.
3433         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3434
3435 2019-06-25  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-layout.c (init_and_make_win): Use new.
3438         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3439         destructor, initializers.
3440         (tui_alloc_generic_win_info): Don't declare.
3441         * tui/tui-data.c (_locator): Add argument to constructor.
3442         (source_win, disasm_win): New globals.
3443         (exec_info): Remove.
3444         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3445         Update.
3446         (tui_alloc_generic_win_info): Remove.
3447         (init_content_element): Use new.
3448         (tui_win_info::tui_win_info): Update.
3449         (free_content_elements) <case DATA_WIN>: Use delete.
3450
3451 2019-06-25  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3454         * tui/tui-windata.c (tui_first_data_item_displayed)
3455         (tui_delete_data_content_windows): Update.
3456         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3457         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3458         (tui_display_registers_from, tui_check_register_values): Update.
3459         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3460         pointer.
3461         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3462         window.
3463         (tui_free_data_content): Update.
3464         (free_content_elements) <case DATA_WIN>: Free the window.
3465
3466 2019-06-25  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3469         Update.
3470         * tui/tui-layout.c (make_command_window)
3471         (show_source_disasm_command, show_data, init_and_make_win)
3472         (show_source_or_disasm_and_command): Update.
3473         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3474         method.
3475         <can_highight, is_highlighted>: Now bool.
3476         (tui_set_win_highlight): Don't declare.
3477         * tui/tui-data.c (tui_set_win_highlight): Remove.
3478
3479 2019-06-25  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-wingeneral.c (make_visible): Remove check of window
3482         type.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-win.c (tui_win_info::max_height)
3487         (tui_cmd_window::max_height): New methods.
3488         (new_height_ok): Call max_height.
3489         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3490         <max_height>: New method.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-win.c (tui_source_window_base::set_new_height)
3495         (tui_data_window::set_new_height): New methods.
3496         (make_invisible_and_set_new_height): Call set_new_height method.
3497         * tui/tui-data.h (struct tui_win_info)
3498         (struct tui_source_window_base, struct tui_data_window)
3499         <set_new_height>: New method.
3500
3501 2019-06-25  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3504         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3505         tui_refresh_data_win.
3506         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3507         method.
3508         (tui_refresh_all_win): Call the refresh_all method.
3509         (tui_set_focus): Likewise.
3510         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3511         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3512         Likewise.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-winsource.h (tui_refill_source_window)
3517         (tui_set_is_exec_point_at): Don't declare.
3518         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3519         (tui_source_window_base::refill): Rename from
3520         tui_refill_source_window.
3521         (tui_source_window_base::do_scroll_horizontal): Update.
3522         (tui_source_window_base::set_is_exec_point_at): Rename from
3523         tui_set_is_exec_point_at.
3524         (tui_update_all_breakpoint_info): Update.
3525         * tui/tui-stack.c (tui_show_frame_info): Update.
3526         * tui/tui-layout.c (show_data): Add cast.
3527         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3528         * tui/tui-data.h (struct tui_source_window_base) <refill,
3529         set_is_exec_point_at>: New methods.
3530         (tui_source_windows, tui_add_to_source_windows): Update types.
3531         (tui_add_to_source_windows): Remove redundant declaration.
3532         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3533         (tui_source_windows): Change return type.
3534         (tui_clear_source_windows_detail): Update.
3535         (tui_add_to_source_windows): Change type of parameter.
3536         (tui_free_all_source_wins_content): Update.
3537
3538 2019-06-25  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-wingeneral.c (tui_win_info::refresh)
3541         (tui_source_window_base::refresh): New methods.
3542         (tui_refresh_all): Call the refresh method.
3543         * tui/tui-data.h (struct tui_win_info)
3544         (struct tui_source_window_base) <refresh>: New method.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui.h (tui_is_window_visible): Return bool.
3549         * tui/tui.c (tui_is_window_visible): Return bool.
3550         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3551         (tui_make_visible, tui_make_invisible)
3552         (tui_win_info::make_visible)
3553         (tui_source_window_base::make_visible, make_all_visible)
3554         (tui_make_all_visible, tui_make_all_invisible): Update.
3555         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3556         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3557         bool.
3558         (struct tui_win_info, struct tui_source_window_base)
3559         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3560         * tui/tui-data.c (tui_init_generic_part): Update.
3561
3562 2019-06-25  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3565         (tui_source_window_base::make_visible): New methods.
3566         (make_all_visible): Make method call.
3567         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3568         (struct tui_source_window_base, struct tui_cmd_window): Override
3569         make_visible.
3570         (tui_win_is_source_type): Don't declare.
3571         * tui/tui-data.c (tui_win_is_source_type): Remove.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3576         NULL check.
3577
3578 2019-06-25  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3581         Inline constructor.  Add initializers for members.
3582         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3583         constructors; now inline in class.
3584
3585 2019-06-25  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-regs.c (tui_show_registers): Update.
3588         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3589         bool.
3590         * tui/tui-data.c (tui_data_window::clear_detail)
3591         (tui_data_window): Update.
3592
3593 2019-06-25  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-windata.c (tui_display_all_data)
3596         (tui_display_data_from_line, tui_display_data_from)
3597         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3598         Update.
3599         * tui/tui-regs.c (tui_last_regs_line_no)
3600         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3601         (tui_show_registers, tui_show_register_group)
3602         (tui_display_registers_from, tui_display_reg_element_at_line)
3603         (tui_display_registers_from_line, tui_check_register_values)
3604         (tui_reg_next, tui_reg_prev): Update.
3605         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3606         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3607         tui_data_window.
3608         (struct tui_win_info) <detail>: Remove.  Add new fields from
3609         tui_data_info.
3610         (TUI_DATA_WIN): Add cast.
3611         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3612         (~tui_data_window): Simplify.
3613
3614 2019-06-25  Tom Tromey  <tom@tromey.com>
3615
3616         * tui/tui-layout.c (show_source_disasm_command)
3617         (show_source_or_disasm_and_command): Update.
3618         * tui/tui-io.c (update_cmdwin_start_line)
3619         (tui_redisplay_readline): Update.
3620         * tui/tui-data.h (struct tui_command_info): Remove.
3621         (struct tui_win_info) <detail>: Remove command_info member.
3622         (struct tui_data_window) <start_line>: New member, from
3623         tui_command_info.
3624         (TUI_CMD_WIN): Add casts.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-winsource.c (tui_update_source_window)
3629         (tui_refill_source_window)
3630         (tui_source_window_base::do_scroll_horizontal)
3631         (tui_update_breakpoint_info, tui_set_exec_info_content)
3632         (tui_show_exec_info_content, tui_erase_exec_info_content)
3633         (tui_clear_exec_info_content): Update.
3634         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3635         Update.
3636         * tui/tui-win.c (make_invisible_and_set_new_height)
3637         (make_visible_with_new_height): Update.
3638         * tui/tui-source.c (tui_set_source_content)
3639         (tui_show_symtab_source): Update.
3640         * tui/tui-layout.c (extract_display_start_addr)
3641         (show_source_disasm_command, show_data)
3642         (make_source_or_disasm_window)
3643         (show_source_or_disasm_and_command): Update.
3644         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3645         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3646         "gdbarch".
3647         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3648         to tui_source_window_base.
3649         (struct tui_win_info) <detail>: Remove source_info member.
3650         (struct tui_source_window_base) <has_locator>: Inline.
3651         Move contents from tui_source_info; rename has_locator member to
3652         m_has_locator.
3653         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3654         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3655         header file.
3656         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3657         Simplify.
3658         (tui_free_all_source_wins_content): Cast to
3659         tui_source_window_base.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-win.c (make_invisible_and_set_new_height)
3664         (make_visible_with_new_height): Call has_locator method.
3665         * tui/tui-layout.c (show_source_disasm_command, show_data)
3666         (show_source_or_disasm_and_command): Update for bool change.
3667         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3668         (tui_win_info) <has_locator>: New method.
3669         (struct tui_source_window_base) <has_locator>: New method.
3670         (tui_win_has_locator): Don't declare.
3671         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3672         from tui_win_has_locator.
3673         (tui_source_window_base): Use false, not FALSE.
3674
3675 2019-06-25  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3678         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3679         clear_detail method directly.
3680         (tui_clear_win_detail): Remove.
3681
3682 2019-06-25  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3685         "this", not TUI_DISASM_WIN.
3686
3687 2019-06-25  Tom Tromey  <tom@tromey.com>
3688
3689         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3690         declare.
3691         * tui/tui-winsource.c
3692         (tui_source_window_base::do_scroll_horizontal): Rename from
3693         tui_horizontal_source_scroll.
3694         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3695         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3696         from tui_vertical_data_scroll.
3697         * tui/tui-win.h (tui_scroll): Don't declare.
3698         * tui/tui-win.c (tui_win_info::forward_scroll)
3699         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3700         (tui_win_info::right_scroll): Rename and update.
3701         (tui_scroll_forward_command, tui_scroll_backward_command)
3702         (tui_scroll_left_command, tui_scroll_right_command): Update.
3703         (tui_scroll): Remove.
3704         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3705         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3706         from tui_vertical_source_scroll.
3707         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3708         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3709         from tui_vertical_disassem_scroll.
3710         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3711         do_scroll_horizontal>: New methods.
3712         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3713         Likewise.
3714         (struct tui_source_window_base): Add do_scroll_horizontal.
3715         (struct tui_source_window, struct tui_disasm_window): Add
3716         do_scroll_vertical.
3717         (struct tui_data_window, struct tui_cmd_window): Add
3718         do_scroll_horizontal and do_scroll_vertical.
3719         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3720
3721 2019-06-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-data.h (struct tui_source_window_base): New struct.
3724         (struct tui_source_window): Derive from tui_source_window_base.
3725         (struct tui_disasm_window): New struct.
3726         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3727         from tui_source_window::clear_detail.
3728         (tui_source_window_base): Rename from tui_source_window.
3729         (~tui_source_window_base): Rename from ~tui_source_window.
3730         (tui_alloc_win_info): Create a tui_disasm_window.
3731
3732 2019-06-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-data.h (struct tui_source_window)
3735         (struct tui_data_window): Declare destructors.
3736         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3737         destructors.
3738         (tui_win_info): Simplify.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-winsource.c (tui_display_main)
3743         (tui_update_source_windows_with_addr)
3744         (tui_update_all_breakpoint_info): Update.
3745         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3746         (new_height_ok, parse_scrolling_args): Update.
3747         * tui/tui-stack.c (tui_show_frame_info): Update.
3748         * tui/tui-data.h (struct tui_list): Remove.
3749         (tui_source_windows): Return a reference to a std::vector.
3750         * tui/tui-data.c (source_windows): Now a std::vector.
3751         (tui_source_windows): Change return type.
3752         (tui_clear_source_windows): Rewrite.
3753         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3754         (tui_free_all_source_wins_content): Rewrite.
3755
3756 2019-06-25  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3759         (struct tui_data_window, struct tui_cmd_window): Declare
3760         clear_detail method.
3761         * tui/tui-data.c (tui_source_window::clear_detail)
3762         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3763         methods.
3764         (tui_clear_win_detail): Simplify.
3765
3766 2019-06-25  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-layout.c (make_source_window, make_disasm_window)
3769         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3770         Return the new window.
3771         (show_source_disasm_command, show_data)
3772         (show_source_or_disasm_and_command): Update.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3777         parameter.  Return the new window.
3778         (show_source_disasm_command): Update and remove NULL check.
3779         (show_source_or_disasm_and_command): Update.
3780
3781 2019-06-25  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3784
3785 2019-06-25  Tom Tromey  <tom@tromey.com>
3786
3787         * tui/tui-data.h (struct tui_win_info): Make constructor
3788         protected.  Make destructor virtual.  Add initializers.
3789         (tui_source_window, tui_data_window, tui_cmd_window): New
3790         classes.
3791         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3792         constructor.  Add "type" parameter.
3793         (tui_source_window, tui_data_window, tui_cmd_window): New
3794         constructors.
3795         (tui_alloc_win_info): Instantiate the appropriate subclass.
3796
3797 2019-06-25  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-win.c (tui_resize_all): Use delete.
3800         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3801         destructor.
3802         (tui_free_window): Don't declare.
3803         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3804         Update.
3805
3806 2019-06-25  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-data.h (struct tui_win_info): Add constructor.
3809         * tui/tui-data.c (tui_alloc_win_info): Use new.
3810         (tui_free_window): Use delete.
3811
3812 2019-06-22  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3815         declare.
3816         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3817
3818 2019-06-22  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3821         declare.
3822         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3823
3824 2019-06-22  Tom de Vries  <tdevries@suse.de>
3825
3826         * dwarf2read.c (create_addrmap_from_aranges)
3827         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3828         instead of '%zu'.
3829
3830 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3831
3832         * dwarf2read.h (dwarf2_section_info_def): Remove.
3833         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3834         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3835         std::vector<dwarf2_section_info>.
3836         (struct dwo_file) <~dwo_file>: Remove.
3837         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3838         types field.
3839         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3840         (dwarf2_read_debug_names): Likewise.
3841         (create_debug_types_hash_table): Change parameter type to
3842         array_view, adjust code accordingly.
3843         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3844         (partial_die_info::fixup): Likewise.
3845         (determine_prefix): Likewise.
3846         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3847
3848 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3849
3850         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3851         gdb_bfd_ref_ptr.
3852         <~dwo_file>: Remove call to gdb_bfd_unref.
3853         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3854         gdb_bfd_ref_ptr::get.
3855
3856 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3857
3858         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3859         type to htab_up.
3860         * dwarf2read.c (struct dwo_file): Initialize fields.
3861         <~dwo_file>: New.
3862         (free_dwo_file): Remove, move content to ~dwo_file.
3863         (struct dwo_file_deleter): Remove.
3864         (dwo_file_up>: Remove custom deleter.
3865         (free_dwo_files): Remove.
3866         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3867         dwo_files.
3868         (process_skeletonless_type_units): Call unique_ptr::get.
3869         (allocate_dwo_file_hash_table): Add deleter to created hash
3870         table.  Change return type to htab_up.
3871         (lookup_dwo_file_slot): Don't memset dwo_file, call
3872         unique_ptr::get.
3873         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3874         (create_dwo_unit_in_dwp_v2): Likewise.
3875         (open_and_init_dwo_file): Likewise.
3876         (free_dwo_file_from_slot): Remove.
3877
3878 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3879
3880         * dwarf2read.h (struct dwarf2_section_info) <readin,
3881         is_virtual>: Change type to bool.
3882         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3883         true instead of 1.
3884
3885 2019-06-19  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-data.h (tui_init_content_element): Don't declare.
3888
3889 2019-06-19  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-data.h (tui_init_win_info): Don't declare.
3892
3893 2019-06-19  Tom de Vries  <tdevries@suse.de>
3894
3895         * dwarf2read.h (abstract_to_concrete): Change type to
3896         std::unordered_map<sect_offset, std::vector<sect_offset>,
3897         gdb::hash_enum<sect_offset>>.
3898
3899 2019-06-19  Tom Tromey  <tromey@adacore.com>
3900
3901         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3902         EVAL_AVOID_SIDE_EFFECTS specially.
3903
3904 2019-06-19  Tom Tromey  <tromey@adacore.com>
3905
3906         * source-cache.c (highlighter): New global.
3907         (source_cache::get_source_lines): Create a highlighter on demand.
3908
3909 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * defs.h (deprecated_interactive_hook): Delete declaration.
3912         * interps.c (clear_interpreter_hooks): Remove use of
3913         deprecated_interactive_hook.
3914         * top.c (deprecated_interactive_hook): Delete definition.
3915         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3916
3917 2019-06-18  Tom de Vries  <tdevries@suse.de>
3918
3919         PR gdb/24515
3920         * dwarf2read.h (abstract_to_concrete): Change type from
3921         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3922         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3923         * dwarf2read.c (read_variable): Update.
3924         (dwarf2_fetch_die_loc_sect_off): Update.
3925
3926 2019-06-17  Tom de Vries  <tdevries@suse.de>
3927
3928         PR gdb/24617
3929         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3930         accessing parent[parent_len - 1].
3931
3932 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3933
3934         PR gdb/24364
3935         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3936         call dtrace_process_dof with NULL dof.
3937
3938 2019-06-16  Tom de Vries  <tdevries@suse.de>
3939
3940         PR gdb/24445
3941         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3942
3943 2019-06-16  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3946         (make_all_visible): Use address of member.
3947
3948 2019-06-16  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3951         (tui_free_window, free_content, free_content_elements): Remove
3952         unnecessary cast.
3953         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3954         cast.
3955         * tui/tui-regs.c (tui_show_register_group)
3956         (tui_display_registers_from, tui_display_reg_element_at_line):
3957         Remove unnecessary cast.
3958
3959 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3960
3961         * linux-nat.c (normal_mask): Delete.
3962         (_initialize_linux_nat): Don't initialise normal_mask.
3963
3964 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3965
3966         PR gdb/24445
3967         * dwarf-index-write.h (write_psymtabs_to_index): Add
3968         dwz_basename parameter.
3969         * dwarf-index-write.c (write_gdbindex): Move file writing to
3970         write_gdbindex_1.  Change return type void.
3971         (assert_file_size): Move up, remove filename parameter.
3972         (write_gdbindex_1): New function.
3973         (write_debug_names): Change return type to void, call
3974         assert_file_size.
3975         (struct index_wip_file): New struct.
3976         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3977         file logic to index_wip_file.  Write index for dwz file if
3978         needed.
3979         (save_gdb_index_command): Pass basename of dwz file, if present.
3980         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3981         build-id of dwz file, if present.
3982         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3983         (dwarf2_get_dwz_file): Likewise.
3984         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3985         (dwarf2_get_dwz_file): Likewise.
3986
3987 2019-06-16  Tom Tromey  <tom@tromey.com>
3988
3989         * coffread.c (process_coff_symbol): Use xstrdup.
3990         * value.c (create_internalvar): Use xstrdup.
3991
3992 2019-06-16  Tom Tromey  <tom@tromey.com>
3993
3994         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3995         * breakpoint.c (stopin_command, stopat_command)
3996         (until_break_command, decode_location_default): Remove unnecessary
3997         cast.
3998         * utils.c (subset_compare): Remove unnecessary cast.
3999         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4000         cast.
4001         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4002         cast.
4003         * infcmd.c (path_command): Remove unnecessary cast.
4004         * coffread.c (decode_type): Remove unnecessary cast.
4005         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4006         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4007         * tui/tui-stack.c (tui_show_locator_content)
4008         (tui_show_frame_info): Remove unnecessary cast.
4009         * tui/tui-win.c (tui_scroll_forward_command)
4010         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4011         (parse_scrolling_args): Remove unnecessary cast.
4012         * tui/tui-data.c (init_win_info, tui_del_window)
4013         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4014         (free_content_elements): Remove unnecessary cast.
4015         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4016         unnecessary cast.
4017         * tui/tui-source.c (tui_set_source_content)
4018         (tui_vertical_source_scroll): Remove unnecessary cast.
4019         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4020         cast.
4021         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4022         * tui/tui-regs.c (tui_display_registers_from)
4023         (tui_display_register): Remove unnecessary cast.
4024         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4025         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4026         (make_visible): Remove unnecessary cast.
4027         * tui/tui-winsource.c (tui_erase_source_content)
4028         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4029         unnecessary cast.
4030         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4031         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4032         * stabsread.c (read_type, read_array_type, read_range_type):
4033         Remove unnecessary cast.
4034         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4035         (parse_symbol, parse_type, upgrade_type, parse_external)
4036         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4037         unnecessary cast.
4038         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4039
4040 2019-06-16  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-data.c (tui_alloc_generic_win_info)
4043         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4044         checks.
4045
4046 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4047             Andrew Burgess  <andrew.burgess@embecosm.com>
4048
4049         * f-typeprint.c (f_print_type): Don't return early for not
4050         associated or not allocated types.
4051         (f_type_print_varspec_suffix): Add print_rank parameter and print
4052         ranks of array types in case they dangling.
4053         (f_type_print_base): Add print_rank parameter.
4054
4055 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4056
4057         * NEWS: Mention new MI commands.
4058         * break-catch-throw.c (enum exception_event_kind): Move to
4059         breakpoint.h.
4060         (print_mention_exception_catchpoint): Output text as a single
4061         message.
4062         (catch_exception_command_1): Rename to...
4063         (catch_exception_event): ...this, make non-static, update header
4064         command, and change some parameter types.
4065         (catch_catch_command): Update for changes to
4066         catch_exception_command_1.
4067         (catch_throw_command): Likewise.
4068         (catch_rethrow_command): Likewise.
4069         * breakpoint.c (enum exception_event_kind): Delete.
4070         * breakpoint.h (enum exception_event_kind): Moved here from
4071         break-catch-throw.c.
4072         (catch_exception_event): Declare.
4073         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4074         (mi_cmd_catch_throw): New function.
4075         (mi_cmd_catch_rethrow): New function.
4076         (mi_cmd_catch_catch): New function.
4077         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4078         'catch-catch' entries.
4079         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4080         (mi_cmd_catch_rethrow): Declare.
4081         (mi_cmd_catch_catch): Declare.
4082
4083 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * annotate.c (annotate_source_line): Change return type to void,
4086         update implementation to match.
4087         * annotate.h (annotate_source_line): Change return type to void,
4088         update header comment.
4089         * stack.c (print_frame_info): Don't change what frame information
4090         is printed based on whether annotations are on or not.
4091
4092 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4095         (annotate_source): Make static.
4096         (annotate_source_line): Moved from source.c and renamed from
4097         identify_source_line.  Update the return type.
4098         * annotate.h (annotate_source): Delete declaration.
4099         (annotate_source_line): Declaration moved from source.h, and
4100         renamed from identify_source_line.  Return type updated.
4101         * source.c (identify_source_line): Moved to annotate.c and renamed
4102         to annotate_source_line.
4103         (info_line_command): Remove check of annotation_level.
4104         * source.h (identify_source_line): Move declaration to annotate.h
4105         and rename to annotate_source_line.
4106         * stack.c: Add 'annotate.h' include.
4107         (print_frame_info): Remove check of annotation_level before
4108         calling annotate_source_line.
4109
4110 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4111
4112         * source-cache.c (source_cache::get_plain_source_lines): Use
4113         open_source_file_with_line_charpos instead of just
4114         open_source_file, remove call to find_source_lines.
4115         (source_cache::get_source_lines): Likewise.
4116         * source.c (find_source_lines): Make static.
4117         (get_filename_and_charpos): Renamed into...
4118         (open_source_file_with_line_charpos): ..this along with changes to
4119         return a scoped_fd, and some other minor clean ups.
4120         (identify_source_line): Use open_source_file_with_line_charpos.
4121         (search_command_helper): Use open_source_file_with_line_charpos
4122         instead of just open_source_file, remove call to
4123         find_source_lines.
4124         * source.h (open_source_file_with_line_charpos): Declare new
4125         function.
4126         (find_source_lines): Delete declaration.
4127
4128 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * source.c (get_filename_and_charpos): Remove fullname
4131         parameter.
4132         (identify_source_line): Update call to get_filename_and_charpos.
4133
4134 2019-06-14  Tom Tromey  <tromey@adacore.com>
4135
4136         PR gdb/24502:
4137         * ui-style.h (skip_ansi_escape): Update comment.
4138         * ui-file.h (class no_terminal_escape_file): New class.
4139         * ui-file.c (no_terminal_escape_file::write)
4140         (no_terminal_escape_file::puts): New methods.
4141         * cli/cli-logging.c (handle_redirections): Use
4142         no_terminal_escape_file.
4143
4144 2019-06-14  Tom Tromey  <tromey@adacore.com>
4145
4146         * NEWS: Move convenience variable news above Python news.
4147
4148 2019-06-14  Tom Tromey  <tom@tromey.com>
4149
4150         * gnulib: Move directory to top-level.
4151         * configure.ac: Don't configure gnulib.
4152         * configure: Rebuild.
4153         * common/common-defs.h: Use new path to gnulib.
4154         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4155         (GNULIB_H): Remove.
4156         (INCGNU): Look in new gnulib location.
4157         (HFILES_NO_SRCDIR): Remove gnulib files.
4158         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4159         (generated_files): Remove GNULIB_H.
4160         ($(LIBGNU), all-lib): Remove targets.
4161         (distclean): Don't mention GNULIB_BUILDDIR.
4162         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4163
4164 2019-06-14  Tom Tromey  <tromey@adacore.com>
4165
4166         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4167         Warn if symbol file does not provide any symbols.
4168
4169 2019-06-14  Tom Tromey  <tromey@adacore.com>
4170
4171         * source.c (find_and_open_source): Respect basenames_may_differ.
4172
4173 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * annotate.c (annotate_breakpoints_invalid): Make use of
4176         scoped_restore_terminal_state.
4177         (annotate_frames_invalid): Likewise.
4178
4179 2019-06-14  Tom Tromey  <tromey@adacore.com>
4180
4181         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4182         allow assignment to an internalvar.
4183
4184 2019-06-14  Tom Tromey  <tromey@adacore.com>
4185
4186         * ada-lex.l: Allow "_" in attribute names.
4187
4188 2019-06-14  Tom Tromey  <tromey@adacore.com>
4189
4190         PR gdb/24653:
4191         * regcache.c (registers_changed): Don't call alloca.
4192         * top.c (execute_command): Don't call alloca.
4193
4194 2019-06-13  Pedro Alves  <palves@redhat.com>
4195
4196         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4197         'expression'.  When parsing an expression, error out if there's
4198         junk after "unlimited".
4199         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4200         (do_set_command): Adjust calls to is_unlimited_literal.
4201
4202 2019-06-13  Pedro Alves  <palves@redhat.com>
4203
4204         * compile/compile.c (make_compile_options_def_group): Add braces
4205         around array_view initializer.
4206         * thread.c (make_thread_apply_all_options_def_group)
4207         (make_thread_apply_all_options_def_group): Likewise.
4208
4209 2019-06-13  Pedro Alves  <palves@redhat.com>
4210
4211         * NEWS (New commands): Mention "maint test-options
4212         require-delimiter", "maint test-options unknown-is-error", "maint
4213         test-options unknown-is-operand" and "maint show
4214         test-options-completion-result".
4215         (New command options, command completion): New section.
4216         (Completion improvements): New section.
4217         Mention that you can abbreviate "unlimited".
4218
4219 2019-06-13  Pedro Alves  <palves@redhat.com>
4220
4221         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4222         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4223         * unittests/cli-utils-selftests.c (test_parse_flags)
4224         (test_parse_flags_qcs): Delete.
4225         (test_cli_utils): Don't call deleted functions.
4226
4227 2019-06-13  Pedro Alves  <palves@redhat.com>
4228
4229         * thread.c: Include "cli/cli-option.h".
4230         (tp_array_compar_ascending): Global.
4231         (tp_array_compar): Delete function.
4232         (tp_array_compar_ascending, tp_array_compar_descending): New
4233         functions.
4234         (ascending_option_def, qcs_flag_option_def)
4235         (thr_qcs_flags_option_defs)
4236         (make_thread_apply_all_options_def_group)
4237         (make_thread_apply_options_def_group): New.
4238         (thread_apply_all_command): Use gdb::option::process_options.
4239         (thread_apply_command_completer)
4240         (thread_apply_all_command_completer): New.
4241         (thread_apply_command): Use gdb::option::process_options.
4242         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4243         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4244         to generate help text of "thread apply".  Adjust "taas"'s help.
4245         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4246         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4247
4248 2019-06-13  Pedro Alves  <palves@redhat.com>
4249
4250         * thread.c (thread_apply_command): Check for invalid TID with
4251         isdigit instead of !isalpha.
4252
4253 2019-06-13  Pedro Alves  <palves@redhat.com>
4254
4255         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4256         (validate_flags_qcs): New.
4257         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4258         (validate_flags_qcs): Declare.
4259         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4260         (make_frame_apply_options_def_group): New.
4261         (frame_apply_command_count): Process options with
4262         gdb::option::process_options.
4263         (frame_apply_completer): New.
4264         (frame_apply_level_completer, frame_apply_all_completer)
4265         (frame_apply_completer): New.
4266         (_initialize_stack): Update help of "frame apply", "frame apply
4267         level", "frame apply all" and "faas" to mention supported options
4268         and install command completers.
4269         * stack.h (frame_apply_all_completer): Declare.
4270         * thread.c: Include "stack.h".
4271         (tfaas_command): Add "--".
4272         (_initialize_thread): Update help "tfaas" to mention supported
4273         options and install command completer.
4274
4275 2019-06-13  Pedro Alves  <palves@redhat.com>
4276
4277         * completer.c (complete_nested_command_line): New.
4278         (gdb_completion_word_break_characters_throw): Add assertion.
4279         * completer.h (complete_nested_command_line): Declare.
4280
4281 2019-06-13  Pedro Alves  <palves@redhat.com>
4282
4283         * stack.c (parse_backtrace_qualifiers): New.
4284         (backtrace_command): Use it.
4285         (backtrace_command_completer): Complete on qualifiers.
4286
4287 2019-06-13  Pedro Alves  <palves@redhat.com>
4288
4289         * frame.c: Include "cli/cli-option.h.
4290         (user_set_backtrace_options): New.
4291         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4292         Delete.
4293         (get_prev_frame): Adjust.
4294         (boolean_option_def, uinteger_option_def)
4295         (set_backtrace_option_defs): New.
4296         (_initialize_frame): Adjust and use
4297         gdb::option::add_setshow_cmds_for_options to install "set
4298         backtrace past-main" and "set backtrace past-entry".
4299         * frame.h: Include "cli/cli-option.h".
4300         (struct frame_print_options): Forward declare.
4301         (print_frame_arguments_all, print_frame_arguments_scalars)
4302         (print_frame_arguments_none): Declare.
4303         (print_entry_values): Delete declaration.
4304         (struct frame_print_options, user_frame_print_options): New.
4305         (struct set_backtrace_options): New.
4306         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4307         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4308         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4309         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4310         (list_args_or_locals): Add frame_print_options parameter.
4311         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4312         * python/py-framefilter.c (enumerate_args): Pass down
4313         USER_FRAME_PRINT_OPTIONS.
4314         * stack.c: Include "cli/cli-option.h".
4315         (print_frame_arguments_all, print_frame_arguments_scalars)
4316         (print_frame_arguments_none): Declare.
4317         (print_raw_frame_arguments, print_entry_values): Delete.
4318         (user_frame_print_options): New.
4319         (boolean_option_def, enum_option_def, frame_print_option_defs):
4320         New.
4321         (struct backtrace_cmd_options): New.
4322         (bt_flag_option_def): New.
4323         (backtrace_command_option_defs): New.
4324         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4325         (print_frame_arg, read_frame_arg, print_frame_args)
4326         (print_frame_info, print_frame): Add frame_print_options parameter
4327         and use it.
4328         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4329         (backtrace_command_1): Add frame_print_options and
4330         backtrace_cmd_options parameters and use them.
4331         (make_backtrace_options_def_group): New.
4332         (backtrace_command): Process command options with
4333         gdb::option::process_options.
4334         (backtrace_command_completer): New.
4335         (_initialize_stack): Extend "backtrace"'s help to mention
4336         supported options.  Install completer for "backtrace".
4337         Install some settings commands with add_setshow_cmds_for_options.
4338
4339 2019-06-13  Pedro Alves  <palves@redhat.com>
4340
4341         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4342         and that "set/show print raw frame-arguments" are now deprecated.
4343
4344         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4345         command.
4346         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4347         * stack.c (_initialize_stack): Install "set/show print
4348         raw-frame-arguments", and deprecate "set/show print raw
4349         frame-arguments".
4350         * valprint.c (_initialize_valprint): Deprecate "set/show print
4351         raw".
4352
4353 2019-06-13  Pedro Alves  <palves@redhat.com>
4354
4355         * compile/compile.c (struct compile_options): New.
4356         (compile_flag_option_def, compile_command_option_defs)
4357         (make_compile_options_def_group): New.
4358         (compile_file_command): Handle options with
4359         gdb::option::process_options.
4360         (compile_file_command_completer): New function.
4361         (compile_code_command): Handle options with
4362         gdb::option::process_options.
4363         (compile_code_command_completer): New function.
4364         (_initialize_compiler): Install completers for "compile code" and
4365         "compile file".  Mention available options in "compile code" and
4366         "compile code"'s help.
4367         * completer.c (advance_to_completion_word): New, factored out from
4368         ...
4369         (advance_to_expression_complete_word_point): ... this.
4370         (advance_to_filename_complete_word_point): New.
4371         * completer.h (advance_to_filename_complete_word_point): New
4372         declaration.
4373
4374 2019-06-13  Pedro Alves  <palves@redhat.com>
4375
4376         * compile/compile.c: Include "cli/cli-option.h".
4377         (compile_print_value): Scope data pointer is now a
4378         value_print_options pointer; adjust.
4379         (compile_print_command): Process options.  Scope data pointer is
4380         now a value_print_options pointer; adjust.
4381         (_initialize_compile): Update "compile print"'s help to include
4382         supported options.  Install a completer for "compile print".
4383         * cp-valprint.c (show_vtblprint, show_objectprint)
4384         (show_static_field_print): Delete.
4385         (_initialize_cp_valprint): Don't install "set print
4386         static-members", "set print vtbl", "set print object" here.
4387         * printcmd.c: Include "cli/cli-option.h" and
4388         "common/gdb_optional.h".
4389         (print_command_parse_format): Rework to fill in a
4390         value_print_options instead of a format_data.
4391         (print_value): Change parameter type from format_data pointer to
4392         value_print_options reference.  Adjust.
4393         (print_command_1): Process options.  Adjust to pass down a
4394         value_print_options.
4395         (print_command_completer): New.
4396         (_initialize_printcmd): Install print_command_completer as
4397         handle_brkchars completer for the "print" command.  Update
4398         "print"'s help to include supported options.
4399         * valprint.c: Include "cli/cli-option.h".
4400         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4401         here from cp-valprint.c.
4402         (boolean_option_def, uinteger_option_def)
4403         (value_print_option_defs, make_value_print_options_def_group):
4404         New.  Use gdb::option::add_setshow_cmds_for_options to install
4405         "set print elements", "set print null-stop", "set print repeats",
4406         "set print pretty", "set print union", "set print array", "set
4407         print address", "set print symbol", "set print array-indexes".
4408         * valprint.h: Include <string> and "cli/cli-option.h".
4409         (make_value_print_options_def_group): Declare.
4410         (print_value): Change parameter type from format_data pointer to
4411         value_print_options reference.
4412         (print_command_completer): Declare.
4413
4414 2019-06-13  Pedro Alves  <palves@redhat.com>
4415
4416         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4417         (COMMON_SFILES): Add maint-test-settings.c.
4418         * cli/cli-decode.c (boolean_enums): New global, factored out from
4419         ...
4420         (add_setshow_boolean_cmd): ... here.
4421         * cli/cli-decode.h (boolean_enums): Declare.
4422         * cli/cli-option.c: New file.
4423         * cli/cli-option.h: New file.
4424         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4425         factored out from ...
4426         (parse_cli_boolean_value(const char *)): ... this.
4427         (is_unlimited_literal): Change parameter type to pointer to
4428         pointer.  Adjust and advance ARG pointer.
4429         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4430         (parse_cli_var_enum): New, factored out from ...
4431         (do_set_command): ... this.  Adjust.
4432         * cli/cli-setshow.h (parse_cli_boolean_value)
4433         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4434         (parse_cli_var_enum): Declare.
4435         * cli/cli-utils.c: Include "cli/cli-option.h".
4436         (get_ulongest): New.
4437         * cli/cli-utils.h (get_ulongest): Declare.
4438         (check_for_argument): New overloads.
4439         * maint-test-options.c: New file.
4440
4441 2019-06-13  Pedro Alves  <palves@redhat.com>
4442
4443         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4444         parse a range if "-" is at the end of the string.
4445
4446 2019-06-13  Pedro Alves  <palves@redhat.com>
4447
4448         * cli/cli-setshow.c (parse_auto_binary_operation)
4449         (parse_cli_boolean_value): Don't allow "o".
4450
4451 2019-06-13  Pedro Alves  <palves@redhat.com>
4452
4453         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4454         * NEWS: Mention maint test-settings KIND.
4455         * maint-test-settings.c: New file.
4456
4457 2019-06-13  Pedro Alves  <palves@redhat.com>
4458
4459         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4460         completer.
4461         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4462         "set" completers.
4463
4464 2019-06-13  Pedro Alves  <palves@redhat.com>
4465
4466         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4467         after item.
4468
4469 2019-06-13  Pedro Alves  <palves@redhat.com>
4470
4471         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4472
4473 2019-06-13  Pedro Alves <palves@redhat.com>
4474
4475         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4476         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4477         call.
4478         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4479         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4480         calls.
4481         (check_for_argument): Skip spaces after argument.
4482
4483 2019-06-13  Pedro Alves  <palves@redhat.com>
4484
4485         * thread.c (thread_apply_command): Adjust TID parsing.
4486         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4487         detected before end of string.
4488         (tid_is_in_list): Error out if LIST is invalid.
4489
4490 2019-06-13  Pedro Alves  <palves@redhat.com>
4491
4492         * completer.c (complete_line_internal_1): Rewind completion word
4493         point.
4494         (completion_tracker::advance_custom_word_point_by): Change
4495         parameter type to int.
4496         * completer.h (completion_tracker::advance_custom_word_point_by):
4497         Likewise.
4498
4499 2019-06-13  Pedro Alves  <palves@redhat.com>
4500
4501         * completer.c (advance_to_completion_word): Handle delimiters.
4502
4503 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4504
4505         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4506
4507 2019-06-11  Tom Tromey  <tom@tromey.com>
4508
4509         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4510         (xmalloc_failed): Move to alloc.c.
4511         * alloc.c: New file.
4512         * Makefile.in (COMMON_SFILES): Add alloc.c.
4513
4514 2019-06-11  Tom Tromey  <tom@tromey.com>
4515
4516         * nat/linux-waitpid.c: Don't include server.h.
4517         (linux_debug): Remove.
4518         (my_waitpid): Update.
4519
4520 2019-06-11  Tom Tromey  <tromey@adacore.com>
4521
4522         * infcall.c (_initialize_infcall): Remove trailing newline from
4523         help.
4524         * user-regs.c (_initialize_user_regs): Remove trailing newline
4525         from help.
4526         * typeprint.c (_initialize_typeprint): Remove trailing newline
4527         from help.
4528         * reverse.c (_initialize_reverse): Remove trailing newlines from
4529         help.
4530         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4531         from help.
4532         * language.c (add_set_language_command): Remove trailing newline
4533         from help.
4534         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4535         help.
4536         * disasm.c (_initialize_disasm): Remove trailing newline from
4537         help.
4538         * top.c (init_main): Remove trailing newline from help.
4539         * interps.c (_initialize_interpreter): Remove trailing newline
4540         from help.
4541         * btrace.c (_initialize_btrace): Remove trailing newlines from
4542         help.
4543         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4544         from help.
4545         * python/python.c (_initialize_python): Remove trailing newline
4546         from help.
4547         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4548         help.
4549         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4550         from help.  Reformat some text.
4551         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4552         from help.
4553         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4554         newline from help.
4555
4556 2019-06-11  Tom Tromey  <tromey@adacore.com>
4557
4558         * darwin-nat.c (darwin_decode_exception_message)
4559         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4560
4561 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * valops.c (value_slice): Check for not allocated or not
4564         associated values.
4565
4566 2019-06-10  Tom de Vries  <tdevries@suse.de>
4567
4568         PR gdb/24618
4569         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4570         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4571         invalid.
4572
4573 2019-06-10  Tom de Vries  <tdevries@suse.de>
4574
4575         PR gdb/24611
4576         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4577         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4578
4579 2019-06-10  Tom de Vries  <tdevries@suse.de>
4580
4581         PR symtab/24545
4582         * symtab.c (struct demangled_name_entry): Add language field.
4583         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4584         static minimal symbol".  Set and use language field.
4585
4586 2019-06-10  Tom Tromey  <tromey@adacore.com>
4587
4588         * ada-lang.c (_initialize_ada_language): Update help text.
4589
4590 2019-06-10  Tom Tromey  <tromey@adacore.com>
4591
4592         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4593         with a newline.
4594         * guile/guile.c (handle_boot_error): Don't end warning with a
4595         newline.
4596         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4597         warning with a newline.
4598         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4599         newline.
4600         (s12z_frame_cache): Likewise.
4601         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4602         a newline.
4603         * solib-svr4.c (disable_probes_interface): Don't end warning with
4604         a newline.
4605         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4606         newline.
4607         * python/python.c (do_finish_initialization): Don't end warning
4608         with a newline.
4609
4610 2019-06-10  Tom Tromey  <tom@tromey.com>
4611
4612         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4613         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4614         gdbpy_enter.
4615
4616 2019-06-10  Tom Tromey  <tromey@adacore.com>
4617
4618         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4619         data.
4620         (elf_new_init): Don't call stabsread_new_init.
4621         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4622         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4623         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4624
4625 2019-06-10  Tom de Vries  <tdevries@suse.de>
4626
4627         PR symtab/16264
4628         PR symtab/24517
4629         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4630
4631 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4632
4633         * source.c (find_and_open_source): Also rewrite relative file
4634         names.
4635
4636 2019-04-26  Amos Bird  <amosbird@gmail.com>
4637
4638         * annotate.c (annotate_thread_exited): Add "thread-exited"
4639         annotation.
4640
4641 2019-06-06  Tom Tromey  <tromey@adacore.com>
4642
4643         * maint.h (class scoped_command_stats): Use
4644         DISABLE_COPY_AND_ASSIGN.
4645         <print_time>: New method.
4646         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4647         print_time.
4648         (scoped_command_stats::print_time): New method.
4649
4650 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4653         instructions of lengths 6 or 8 bytes.
4654
4655 2019-06-04  Pedro Alves  <palves@redhat.com>
4656
4657         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4658
4659         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4660         * breakpoint.c (condition_completer): Likewise.
4661         * cli/cli-dump.c (scan_expression): Likewise.
4662         * common/filestuff.c (mkdir_recursive): Likewise.
4663         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4664         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4665         (gdb_abspath): Likewise.
4666         * compile/compile-cplus-types.c
4667         (compile_cplus_instance::decl_name): Likewise.
4668         * completer.c (complete_explicit_location):
4669         (signal_completer, reg_or_group_completer_1): Likewise.
4670         * cp-support.c (cp_remove_params_if_any): Likewise.
4671         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4672         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4673         * infcmd.c (strip_bg_char): Likewise.
4674         * linespec.c (copy_token_string): Likewise.
4675         * mi/mi-main.c (output_cores): Likewise.
4676         * psymtab.c (psymtab_search_name):
4677         * symfile.c (test_set_ext_lang_command): Likewise.
4678         * target.c (target_fileio_read_stralloc): Likewise.
4679         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4680         * value.c (complete_internalvar): Likewise.
4681
4682 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4683
4684         Add objfile property to gdb.Type.
4685         * NEWS: Mention Python API addition.
4686         * python/py-type.c (typy_get_objfile): New method.
4687
4688 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4689
4690         * NEWS: Mention the new set|show style [title|highlight].
4691         Mention changes to "show style", "help" and "apropos".
4692
4693 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4694
4695         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4696         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4697         instead of print_help_for_command.
4698         (print_doc_of_command): New function.
4699         (help_list): Add 'apropos -v word' suggestion.
4700         (print_help_for_command): Style the command name using title style.
4701         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4702         (_initialize_cli_cmds): Describe -v in apropos_command help.
4703
4704 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4705
4706         * cli/cli-style.h (cli_style_option): Add name in constructor,
4707         add m_name class member, add constructor with intensity,
4708         add name class function.
4709         (cli_style_option::add_setshow_commands): Remove name argument.
4710         (highlight_style, title_style): New styles.
4711         * cli/cli-style.c (do_show): New function that shows a style
4712         characteristic styling the style name with itself.
4713         (set_style_name): New function.
4714         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4715         Update all callers according to the changes in cli/cli-style.h.
4716         * utils.h (fputs_highlighted): New function.
4717         * utils.c (fputs_highlighted): Likewise.
4718
4719 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4720
4721         * NEWS: Mention new pipe command and new convenience variables.
4722
4723 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4724
4725         * cli/cli-cmds.c (pipe_command): New function.
4726         (_initialize_cli_cmds): Call add_com for pipe_command.
4727         Define | as an alias for pipe.
4728         (exit_status_set_internal_vars): New function.
4729         (shell_escape): Call exit_status_set_internal_vars.
4730         cli/cli-decode.c (find_command_name_length): Recognize | as
4731         a single character command.
4732
4733 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4734
4735         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4736         top.c (execute_command_to_ui_file): New function, mostly a copy
4737         of execute_command_to_string.
4738         (execute_command_to_string): Implement by calling
4739         execute_command_to_ui_file.
4740
4741 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4742
4743         * top.h (saved_command_line): Remove declaration.
4744         * top.c (previous_saved_command_line, previous_repeat_arguments):
4745         New variables.
4746         (saved_command_line): Make static, define together with other
4747         'repeat variables'.
4748         (dont_repeat): Clear repeat_arguments.
4749         (repeat_previous, get_saved_command_line, save_command_line):
4750         New functions.
4751         (gdb_init): Initialize saved_command_line
4752         and previous_saved_command_line.
4753         * main.c (captured_main_1): Remove saved_command_line initialization.
4754         * event-top.c (handle_line_of_input): Update to use
4755         the new 'repeat' related functions instead of direct access to
4756         saved_command_line.
4757         * command.h (repeat_previous, get_saved_command_line,
4758         save_command_line): New declarations.
4759         (dont_repeat): Add comment.
4760
4761 2019-05-30  Tom Tromey  <tromey@adacore.com>
4762
4763         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4764         Fix comment.
4765         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4766
4767 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4768
4769         PR cli/24587
4770         * completer.c (complete): Initialize variable word.
4771
4772 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4773
4774         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4775         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4776         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4777         'body' is NULL to the outter 'if', protecting the '!is_define'
4778         situation as well.
4779
4780 2019-05-29  Tom Tromey  <tromey@adacore.com>
4781
4782         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4783         (dwarf_unknown): New function.
4784         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4785         (dwarf_type_encoding_name): Use dwarf_unknown.
4786
4787 2019-05-29  Tom Tromey  <tromey@adacore.com>
4788
4789         PR c++/20020:
4790         * cp-valprint.c (cp_print_value_fields): Call
4791         cp_print_static_field inside "try".
4792
4793 2019-05-29  Tom Tromey  <tromey@adacore.com>
4794
4795         * inflow.c (struct terminal_info): Add default operator=.
4796         * configure: Rebuild.
4797         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4798         -Wdeprecated-copy-dtor, -Wredundant-move.
4799
4800 2019-05-29  Tom Tromey  <tromey@adacore.com>
4801
4802         * NEWS: Add entry.
4803         * infcmd.c (print_return_value_1): Handle finish_print
4804         option.
4805         (show_print_finish): New function.
4806         (_initialize_infcmd): Add "set/show print finish" commands.
4807         * valprint.c (user_print_options): Initialize new member.
4808         * valprint.h (struct value_print_options) <finish_print>: New
4809         member.
4810
4811 2019-05-28  Tom Tromey  <tromey@adacore.com>
4812
4813         * ada-lang.c (ada_remove_Xbn_suffix)
4814         (find_old_style_renaming_symbol)
4815         (parse_old_style_renaming): Remove.
4816         (ada_find_renaming_symbol): Don't call
4817         find_old_style_renaming_symbol.
4818         (ada_is_renaming_symbol): Rename from
4819         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4820         bool.  Now static.
4821         (ada_read_var_value): Update and simplify.
4822         * ada-exp.y (write_var_or_type): Remove old code.
4823
4824 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4825
4826         * event-top.c: Remove include comment.
4827         * inflow.c (class scoped_ignore_sigttou): Move from here...
4828         * inflow.h (class scoped_ignore_sigttou): ...to here.
4829         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4830         * top.c:  Remove include comment.
4831
4832 2019-05-27  Tom Tromey  <tom@tromey.com>
4833
4834         * NEWS: Fix typo.
4835
4836 2019-05-22  Tom Tromey  <tromey@adacore.com>
4837
4838         * target.c (target_follow_exec): Constify parameter.
4839         * target-delegates.c: Rebuild.
4840         * remote.c (remote_target::follow_exec): Constify parameter.
4841         * infrun.c (follow_exec): Constify parameter.
4842         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4843         (target_follow_exec): Likewise.
4844
4845 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4846
4847         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4848         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4849
4850 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4851
4852         * NEWS: Add debugredirect and testsuite sections.
4853
4854 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4855
4856         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4857         target descriptions using exclusively floating point register name
4858         aliases.
4859
4860 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4861
4862         PR gdb/18644:
4863         * f-lang.c (build_fortran_types): Handle the case where
4864         gdbarch_floatformat_for_type returns a nullptr.
4865
4866 2019-05-21  Tom de Vries  <tdevries@suse.de>
4867
4868         PR cli/24587
4869         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4870
4871 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         PR gdb/18644:
4874         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4875         16-byte floats.
4876         * i386-tdep.c (i386_floatformat_for_type): Use
4877         floatformats_ia64_quad for the 16-byte floating point component
4878         within a fortran 32-byte complex number.
4879
4880 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4883         delete default constructor.
4884         (find_partial_die): Update to return const struct.
4885         (partial_die_parent_scope): Move variable declaration into scope
4886         of its use and change its type to auto.
4887         (guess_partial_die_structure_name): Likewise.
4888         (partial_die_info::fixup): Likewise.
4889
4890 2019-05-17  Tom Tromey  <tromey@adacore.com>
4891
4892         * source.c (find_and_open_source): Remove cast.
4893
4894 2019-05-17  Tom Tromey  <tromey@adacore.com>
4895
4896         * annotate.c (annotate_source): Make "filename" const.
4897         * annotate.h (annotate_source): Use const.
4898
4899 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4900
4901         * disasm.c (set_disassembler_options): Send errors to stderr.
4902
4903 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4904
4905         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4906         (cli_interp_base::set_logging): Check debug_redirect.
4907         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4908         * cli/cli-logging.c (debug_redirect): Add static variable.
4909         (pop_output_files): Add default param.
4910         (handle_redirections): Print debug setting.
4911         (show_logging_command): Likewise.
4912         (_initialize_cli_logging): Add debugredirect command.
4913         * interps.c (current_interp_set_logging): Add debug_redirect
4914         parameter.
4915         * interps.h (set_logging): Add debug_redirect parameter.
4916         (current_interp_set_logging): Likewise.
4917         * mi/mi-common.h: Likewise.
4918         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4919
4920 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4921             Tom Tromey  <tromey@adacore.com>
4922
4923         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4924         directly.
4925         * cli/cli-interp.h (make_logging_output): Remove declaration.
4926         * cli/cli-logging.c (make_logging_output): Remove function.
4927         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4928         directly.
4929         * ui-file.c (tee_file::tee_file): Remove bools.
4930         (tee_file::~tee_file): Remove deletes.
4931         * ui-file.h (tee_file): Remove bools.
4932
4933 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4934
4935         * mi/mi-cmds.h (mi_cmd_complete): New function.
4936         * mi/mi-main.c (mi_cmd_complete): Likewise.
4937         * mi/mi-cmds.c: Define new MI command -complete.
4938         * NEWS: Mention new -complete command.
4939
4940 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4941
4942         * completer.h (complete): New function.
4943         * completer.c (complete): Likewise.
4944         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4945         function defined in completer.h.
4946
4947 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4948
4949         * MAINTAINERS (Write After Approval): Add myself.
4950
4951 2019-05-17  Tom de Vries  <tdevries@suse.de>
4952
4953         PR gdb/24094
4954         * dwarf2read.c (struct cu_partial_die_info): New struct.
4955         (find_partial_die): Return cu_partial_die_info.
4956         (partial_die_parent_scope, guess_partial_die_structure_name)
4957         (partial_die_info::fixup): Handle new return type of find_partial_die.
4958
4959 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4960
4961         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4962         "std::string", simplifying the algorithm.
4963
4964 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4965
4966         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4967         (stap_static_probe_ops::get_probes): Likewise.
4968
4969 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4970
4971         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4972         '-')" and "else if".
4973         (stap_parse_single_operand): Join checks for
4974         "gdbarch_stap_parse_special_token_p" and
4975         "gdbarch_stap_parse_special_token" in the same "if" statement.
4976         Invert check when verifying for operation on register
4977         displacement.
4978
4979 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4980
4981         * stap-probe.c (stap_get_opcode): Update comment.
4982         (stap_get_expected_argument_type): Likewise.
4983         (handle_stap_probe): Likewise.
4984
4985 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4986
4987         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4988         return type to 'bool'.  Adjust comment.  Use 'bool' when
4989         appropriate.
4990         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4991         * stap-probe.c (stap_parse_argument_1): Likewise.
4992         (stap_is_operator): Likewise.
4993         (stap_is_generic_prefix): Likewise.
4994         (stap_is_register_prefix): Likewise.
4995         (stap_is_register_indirection_prefix): Likewise.
4996         (stap_is_integer_prefix): Likewise.
4997         (stap_generic_check_suffix): Likewise.
4998         (stap_check_integer_suffix): Likewise.
4999         (stap_check_register_suffix): Likewise.
5000         (stap_check_register_indirection_suffix): Likewise.
5001         (stap_parse_register_operand): Likewise.
5002         (stap_parse_single_operand): Likewise.
5003         (stap_parse_argument_1): Likewise.
5004         (stap_probe::get_argument_count): Likewise.
5005         (stap_is_operator): Likewise.
5006
5007 2019-05-16  Tom Tromey  <tromey@adacore.com>
5008
5009         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5010         keyword to foreach.
5011
5012 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5013
5014         * linux-thread-db.c (try_thread_db_load_1): Change return type
5015         to bool.
5016         (try_thread_db_load): Likewise.
5017         (try_thread_db_load_from_pdir_1): Likewise.
5018         (try_thread_db_load_from_pdir): Likewise.
5019         (try_thread_db_load_from_sdir): Likewise.
5020         (try_thread_db_load_from_dir): Likewise.
5021         (thread_db_load_search): Likewise.
5022         (has_libpthread): Likewise.
5023         (thread_db_load): Likewise.
5024
5025 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5026
5027         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5028         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5029         NULL, and complain/return if that's the case.
5030
5031 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5032
5033         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5034         (advance, posn, abstract_read_memory): New functions.
5035         [struct mem_read_abstraction]: New struct.
5036         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5037
5038 2019-05-14  Tom Tromey  <tromey@adacore.com>
5039
5040         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5041         value is not lval_memory.
5042
5043 2019-05-14  Tom Tromey  <tromey@adacore.com>
5044
5045         * solib.c (info_sharedlibrary_command): Style the file name.
5046
5047 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5048
5049         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5050         (aarch64_vnv_type): Likewise.
5051         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5052         * common/tdesc.c: Likewise.
5053         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5054         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5055         * features/aarch64-fpu.xml: Add ieee half view.
5056         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5057         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5058         * gdbtypes.h (struct builtin_type): Likewise.
5059         (struct objfile_type): Likewise.
5060
5061 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5062
5063         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5064         typo.
5065         * location.h (string_to_event_location): Likewise.
5066
5067 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5068
5069         GDB 8.3 released.
5070
5071 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5072
5073         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5074         New variable declaration.
5075         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5076         New variable.
5077         (print_one_breakpoint): Use ui_out::test_flags and new global
5078         variable to compute use_fixed_output.
5079         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5080         Remove.
5081         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5082         (mi_multi_location_breakpoint_output_fixed): Remove.
5083         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5084         new variable.
5085         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5086         fix_multi_location_breakpoint_output flag if version >= 3.
5087         * ui-out.h (enum ui_out_flag)
5088         <fix_multi_location_breakpoint_output>: New enumerator.
5089
5090 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5091
5092         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5093
5094 2019-05-10  Tom Tromey  <tromey@adacore.com>
5095
5096         * ada-lang.c (catch_ada_completer): New function.
5097         (_initialize_ada_language): Use it.
5098
5099 2019-05-10  Tom Tromey  <tromey@adacore.com>
5100
5101         * thread.c (print_thread_info): Make "requested_threads" const.
5102         * gdbthread.h (print_thread_info): Make "requested_threads"
5103         const.
5104         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5105         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5106
5107 2019-05-08  Tom Tromey  <tom@tromey.com>
5108
5109         * gdbtypes.c (objfile_type_data): Change type.
5110         (objfile_type, _initialize_gdbtypes): Update.
5111
5112 2019-05-08  Tom Tromey  <tom@tromey.com>
5113
5114         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5115         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5116         (_initialize_dwarf2_frame): Update.
5117
5118 2019-05-08  Tom Tromey  <tom@tromey.com>
5119
5120         * objc-lang.c (objc_objfile_data): Change type.
5121         (find_methods): Update.
5122         (_initialize_objc_lang): Remove.
5123
5124 2019-05-08  Tom Tromey  <tom@tromey.com>
5125
5126         * stabsread.c (rs6000_builtin_type_data): Change type.
5127         (rs6000_builtin_type, _initialize_stabsread): Update.
5128
5129 2019-05-08  Tom Tromey  <tom@tromey.com>
5130
5131         * mips-tdep.c (mips_pdr_data): Remove.
5132         (_initialize_mips_tdep): Update.
5133
5134 2019-05-08  Tom Tromey  <tom@tromey.com>
5135
5136         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5137         (hppa_init_objfile_priv_data, read_unwind_info)
5138         (find_unwind_entry, _initialize_hppa_tdep): Update.
5139
5140 2019-05-08  Tom Tromey  <tom@tromey.com>
5141
5142         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5143         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5144         on obstack.
5145         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5146
5147 2019-05-08  Tom Tromey  <tom@tromey.com>
5148
5149         * mdebugread.c (basic_type_data): Change type.
5150         (basic_type, _initialize_mdebugread): Update.
5151
5152 2019-05-08  Tom Tromey  <tom@tromey.com>
5153
5154         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5155
5156 2019-05-08  Tom Tromey  <tom@tromey.com>
5157
5158         * nto-tdep.c (nto_inferior_data_reg): Change type.
5159         (nto_inferior_data): Update.
5160         (nto_inferior_data_cleanup, nto_new_inferior_data)
5161         (_initialize_nto_tdep): Remove.
5162         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5163
5164 2019-05-08  Tom Tromey  <tom@tromey.com>
5165
5166         * ada-lang.c (struct ada_inferior_data): Add initializers.
5167         (ada_inferior_data): Change type.
5168         (ada_inferior_data_cleanup): Remove.
5169         (get_ada_inferior_data, ada_inferior_exit)
5170         (struct ada_pspace_data): Add initializers, destructor.
5171         (ada_pspace_data_handle): Change type.
5172         (get_ada_pspace_data): Update.
5173         (ada_pspace_data_cleanup): Remove.
5174
5175 2019-05-08  Tom Tromey  <tom@tromey.com>
5176
5177         * coffread.c (struct coff_symfile_info): Add initializers.
5178         (coff_objfile_data_key): Move lower.  Change type.
5179         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5180         Update.
5181         (coff_free_info): Remove.
5182
5183 2019-05-08  Tom Tromey  <tom@tromey.com>
5184
5185         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5186         (fbsd_pspace_data_handle): Move lower.  Change type.
5187         (get_fbsd_pspace_data): Update.
5188         (fbsd_pspace_data_cleanup): Remove.
5189         (_initialize_fbsd_tdep): Update.
5190
5191 2019-05-08  Tom Tromey  <tom@tromey.com>
5192
5193         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5194         (get_ada_tasks_pspace_data): Update.
5195         (ada_tasks_pspace_data_cleanup): Remove.
5196         (_initialize_tasks): Update.
5197         (ada_tasks_inferior_data_handle): Change type.
5198         (get_ada_tasks_inferior_data): Update.
5199         (ada_tasks_inferior_data_cleanup): Remove.
5200         (struct ada_tasks_pspace_data): Add initializers.
5201
5202 2019-05-08  Tom Tromey  <tom@tromey.com>
5203
5204         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5205         * symfile-debug.c (debug_sym_get_probes): Change type.
5206         * stap-probe.c (handle_stap_probe):
5207         (stap_static_probe_ops::get_probes): Change type.
5208         * probe.h (class static_probe_ops) <get_probes>: Change type.
5209         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5210         (parse_probes_in_pspace): Update.
5211         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5212         Update.
5213         (any_static_probe_ops::get_probes): Change type.
5214         * elfread.c (elfread_data): New typedef.
5215         (probe_key): Change type.
5216         (elf_get_probes): Likewise.  Update.
5217         (probe_key_free): Remove.
5218         (_initialize_elfread): Update.
5219         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5220         Change type.
5221         (dtrace_process_dof_probe, dtrace_process_dof)
5222         (dtrace_static_probe_ops::get_probe): Change type.
5223
5224 2019-05-08  Tom Tromey  <tom@tromey.com>
5225
5226         * xcoffread.c (struct xcoff_symfile_info): Rename from
5227         coff_symfile_info.  Add initializers.
5228         (xcoff_objfile_data_key): Move lower.  Change type.
5229         (XCOFF_DATA): Rewrite.
5230         (xcoff_free_info): Remove.
5231         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5232         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5233         (xcoff_initial_scan): Update.
5234
5235 2019-05-08  Tom Tromey  <tom@tromey.com>
5236
5237         * solib-svr4.c (struct svr4_info): Add initializers and
5238         destructor.
5239         <probes_table>: Now an htab_up.
5240         (solib_svr4_pspace_data): Change type.
5241         (free_probes_table): Simplify.
5242         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5243         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5244         (probes_table_remove_objfile_probes, register_solib_event_probe)
5245         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5246         (_initialize_svr4_solib): Update.
5247
5248 2019-05-08  Tom Tromey  <tom@tromey.com>
5249
5250         * remote.c (remote_pspace_data): Change type.
5251         (remote_pspace_data_cleanup): Remove.
5252         (get_remote_exec_file, set_pspace_remote_exec_file)
5253         (_initialize_remote): Update.
5254
5255 2019-05-08  Tom Tromey  <tom@tromey.com>
5256
5257         * breakpoint.c (breakpoint_objfile_key): Change type.
5258         (get_breakpoint_objfile_data): Update.
5259         (free_breakpoint_objfile_data): Remove.
5260         (_initialize_breakpoint): Update.
5261
5262 2019-05-08  Tom Tromey  <tom@tromey.com>
5263
5264         * linux-tdep.c (struct linux_info): Add initializers.
5265         (linux_inferior_data): Move.  Change type.
5266         (invalidate_linux_cache_inf): Update.
5267         (linux_inferior_data_cleanup): Remove.
5268         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5269
5270 2019-05-08  Tom Tromey  <tom@tromey.com>
5271
5272         * auxv.c (auxv_inferior_data): Move.  Change type.
5273         (auxv_inferior_data_cleanup): Remove.
5274         (invalidate_auxv_cache_inf): Rewrite.
5275         (get_auxv_inferior_data, _initialize_auxv): Update.
5276
5277 2019-05-08  Tom Tromey  <tom@tromey.com>
5278
5279         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5280         (symfile_debug_objfile_data_key): Change type.
5281         (symfile_debug_installed, debug_qf_has_symbols)
5282         (debug_qf_find_last_source_symtab)
5283         (debug_qf_forget_cached_source_info)
5284         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5285         (debug_qf_print_stats, debug_qf_dump)
5286         (debug_qf_expand_symtabs_for_function)
5287         (debug_qf_expand_all_symtabs)
5288         (debug_qf_expand_symtabs_with_fullname)
5289         (debug_qf_map_matching_symbols)
5290         (debug_qf_expand_symtabs_matching)
5291         (debug_qf_find_pc_sect_compunit_symtab)
5292         (debug_qf_map_symbol_filenames)
5293         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5294         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5295         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5296         (debug_sym_read_linetable, debug_sym_relocate): Update.
5297         (symfile_debug_free_objfile): Remove.
5298         (install_symfile_debug_logging, _initialize_symfile_debug):
5299         Update.
5300
5301 2019-05-08  Tom Tromey  <tom@tromey.com>
5302
5303         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5304         allocate_on_obstack.
5305         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5306         (get_dwarf2_per_objfile): Update.
5307         (set_dwarf2_per_objfile): Remove.
5308         (dwarf2_has_info, dwarf2_get_section_info): Update.
5309         (dwarf2_free_objfile): Remove.
5310         (_initialize_dwarf2_read): Update.
5311
5312 2019-05-08  Tom Tromey  <tom@tromey.com>
5313
5314         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5315         initializers.
5316         <unsupported_script_warning_printed,
5317         script_not_found_warning_printed>: Now bool.
5318         (auto_load_pspace_data): Change type.
5319         (~auto_load_pspace_info): Rename from
5320         auto_load_pspace_data_cleanup.
5321         (get_auto_load_pspace_data, init_loaded_scripts_info)
5322         (clear_section_scripts, maybe_print_unsupported_script_warning)
5323         (maybe_print_script_not_found_warning, _initialize_auto_load):
5324         Update.
5325
5326 2019-05-08  Tom Tromey  <tom@tromey.com>
5327
5328         * objfiles.c (objfile_pspace_info): Add destructor and
5329         initializers.
5330         (objfiles_pspace_data): Change type.
5331         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5332         (get_objfile_pspace_data): Update.
5333         (objfiles_bfd_data): Change type.
5334         (get_objfile_bfd_data): Update.
5335         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5336
5337 2019-05-08  Tom Tromey  <tom@tromey.com>
5338
5339         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5340         Change type.
5341         (get_catch_syscall_inferior_data): Update.
5342         (catch_syscall_inferior_data_cleanup): Remove.
5343         (_initialize_break_catch_syscall): Update.
5344
5345 2019-05-08  Tom Tromey  <tom@tromey.com>
5346
5347         * inflow.c (struct terminal_info): Add destructor and
5348         initializers.
5349         (inflow_inferior_data): Change type.
5350         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5351         (get_inflow_inferior_data, inflow_inferior_exit)
5352         (swap_terminal_info, _initialize_inflow): Update.
5353
5354 2019-05-08  Tom Tromey  <tom@tromey.com>
5355
5356         * target-dcache.c (target_dcache_cleanup): Remove.
5357         (target_dcache_aspace_key): Change type.
5358         (target_dcache_init_p, target_dcache_invalidate)
5359         (target_dcache_get, target_dcache_get_or_init)
5360         (_initialize_target_dcache): Update.
5361         * dcache.h (struct dcache_deleter): New.
5362
5363 2019-05-08  Tom Tromey  <tom@tromey.com>
5364
5365         * symtab.c (struct symbol_cache): Add destructor and
5366         initializers.
5367         (symbol_cache_key): Move.  Change type.
5368         (make_symbol_cache, free_symbol_cache): Remove.
5369         (get_symbol_cache): Update.
5370         (symbol_cache_cleanup): Remove.
5371         (ALL_PSPACES, symbol_cache_flush)
5372         (maintenance_print_symbol_cache)
5373         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5374         Update.
5375
5376 2019-05-08  Tom Tromey  <tom@tromey.com>
5377
5378         * symtab.c (struct main_info): Add destructor and initializers.
5379         (main_progspace_key): Move.  Change type.
5380         (get_main_info): Update.
5381         (main_info_cleanup): Remove.
5382         (_initialize_symtab): Update.
5383
5384 2019-05-08  Tom Tromey  <tom@tromey.com>
5385
5386         * registry.h (DECLARE_REGISTRY): Define the _key class.
5387
5388 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * NEWS: Merge two 'New commands' sections.
5391
5392 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5393
5394         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5395         parameter and use Ada language definition instead.
5396         (ada_val_print_ptr): Remove unused language parameter.
5397         (ada_val_print_num): Remove language parameter and use Ada language
5398         definition instead.
5399         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5400         parameter.
5401         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5402         parameter and use Ada language definition instead.
5403         (ada_val_print_1): Update all ada_val_print_xxx calls.
5404         Remove language parameter.
5405         (ada_val_print): Update ada_val_print_1 call.
5406
5407 2019-05-08  Tom Tromey  <tromey@adacore.com>
5408
5409         * remote.c (remote_hw_watchpoint_limit)
5410         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5411         Now static.
5412
5413 2019-05-08  Tom Tromey  <tromey@adacore.com>
5414
5415         * maint.c (_initialize_maint_cmds): Move initialization code to
5416         remote.c.
5417         (watchdog, show_watchdog): Move to remote.c.
5418         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5419         "watchdog" static.
5420         (_initialize_remote): Move initialization code from maint.c.
5421         * defs.h (watchdog): Don't declare.
5422
5423 2019-05-08  Tom Tromey  <tromey@adacore.com>
5424
5425         * tui/tui-interp.c: Include main.h.
5426         * interps.c: Include main.h.
5427         * main.h (interpreter_p): Declare.
5428         * defs.h (interpreter_p): Don't declare.
5429
5430 2019-05-08  Tom Tromey  <tromey@adacore.com>
5431
5432         * dwarf2loc.c: Include dwarf2read.h.
5433         * defs.h (read_unsigned_leb128): Don't declare.
5434         * dwarf2read.h (read_unsigned_leb128): Declare.
5435
5436 2019-05-08  Tom Tromey  <tromey@adacore.com>
5437
5438         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5439         method.
5440
5441 2019-05-08  Tom Tromey  <tromey@adacore.com>
5442
5443         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5444         when no wrap column is set.
5445
5446 2019-05-08  Tom Tromey  <tromey@adacore.com>
5447
5448         * c-lang.c (c_get_string): Handle non-C-style arrays.
5449
5450 2019-05-08  Tom Tromey  <tromey@adacore.com>
5451
5452         * typeprint.c (print_offset_data::update): Print the bit offset,
5453         not the number of bits remaining.
5454
5455 2019-05-08  Tom Tromey  <tromey@adacore.com>
5456
5457         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5458         padding at end of comment.
5459
5460 2019-05-08  Tom Tromey  <tromey@adacore.com>
5461
5462         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5463         Compare main types.
5464
5465 2019-05-06  Tom Tromey  <tom@tromey.com>
5466
5467         * common/scoped_mmap.c: Include common-defs.h.
5468         * common/scoped_mmap.h: Don't include config.h.
5469
5470 2019-05-04  Tom Tromey  <tom@tromey.com>
5471
5472         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5473         (struct aarch64_call_info): Add initializers.
5474         <si>: Now a std::vector.
5475         (pass_on_stack, aarch64_push_dummy_call): Update.
5476
5477 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5478             Tom Tromey  <tom@tromey.com>
5479
5480         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5481         (ppc_threads): Now a std::vector.  Now static.
5482         (hwdebug_find_thread_points_by_tid)
5483         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5484         Update.
5485
5486 2019-05-04  Tom Tromey  <tom@tromey.com>
5487
5488         * arc-tdep.c (arc_tdesc_init): Return bool.
5489
5490 2019-05-04  Tom Tromey  <tom@tromey.com>
5491
5492         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5493         Use gdb_assert_not_reached.
5494
5495 2019-05-04  Tom Tromey  <tom@tromey.com>
5496
5497         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5498         "false".
5499
5500 2019-05-04  Tom Tromey  <tom@tromey.com>
5501
5502         * arc-tdep.c (arc_tdesc_init): Use bool.
5503
5504 2019-05-04  Tom Tromey  <tom@tromey.com>
5505
5506         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5507
5508 2019-05-04  Tom Tromey  <tom@tromey.com>
5509
5510         * cli/cli-cmds.c (valid_command_p): Return bool.
5511
5512 2019-05-04  Tom Tromey  <tom@tromey.com>
5513
5514         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5515         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5516
5517 2019-05-04  Raul Tambre  <raul@tambre.ee>
5518
5519         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5520         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5521         operator for comparison.
5522
5523 2019-05-04  Tom Tromey  <tom@tromey.com>
5524
5525         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5526         (lookup_partial_symbol, print_partial_symbols)
5527         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5528         (psymbol_compare): Update.
5529         (add_psymbol_to_bcache): Clear the entire psymbol.
5530         (maintenance_check_psymtabs): Update.
5531         * psympriv.h (struct partial_symbol): Don't derive from
5532         general_symbol_info.
5533         <obj_section, unrelocated_address, address,
5534         set_unrelocated_address>: Update.
5535         <ginfo>: New member.
5536         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5537         (debug_names::write_psymbols): Update.
5538
5539 2019-05-04  Tom de Vries  <tdevries@suse.de>
5540
5541         * contrib/cc-with-tweaks.sh: Support -n arg.
5542
5543 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5544
5545         * corelow.c (core_target::detach): Ensure frame cache and
5546         register caches are cleared.
5547         inferior.c (exit_inferior_1): Likewise.
5548
5549 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5550             Tom Tromey  <tom@tromey.com>
5551
5552         * dictionary.c (collate_pending_symbols_by_language): Remove
5553         "struct" from foreach.
5554         * symtab.c (lookup_global_symbol_from_objfile)
5555         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5556         foreach.
5557         * ser-tcp.c (net_open): Remove "struct" from foreach.
5558         * objfiles.c (objfile_relocate, objfile_rebase)
5559         (objfile_has_symbols): Remove "struct" from foreach.
5560         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5561         from foreach.
5562         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5563         foreach.
5564         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5565         "struct" from foreach.
5566         * ada-lang.c (create_excep_cond_exprs)
5567         (ada_exception_catchpoint_cond_string): Remove "struct" from
5568         foreach.
5569
5570 2019-05-03  Tom Tromey  <tromey@adacore.com>
5571
5572         * ada-exp.y (convert_char_literal): Check suffix of each
5573         enumerator.
5574
5575 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5576
5577         PR ada/21406:
5578         * ada-exp.y (yywrap): Don't define.
5579         * ada-lex.l (%option): Add noyywrap
5580         (yywrap): Remove.
5581
5582 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5583
5584         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5585         _WIN32_WINNT to the XP level, unless already defined to a higher
5586         level.
5587
5588         * unittests/parse-connection-spec-selftests.c:
5589         * ser-tcp.c:
5590         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5591         override.
5592
5593         * symfile.c (find_separate_debug_file): Remove colon from the
5594         drive spec of DOS/Windows file names of the target, so that the
5595         file name produced from DEBUGDIR and the target's directory will
5596         be valid on DOS/Windows systems.
5597
5598 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5599
5600         * rust-lang.c (val_print_struct): Handle printing structures
5601         containing strings.
5602
5603 2019-05-02  Tom Tromey  <tromey@adacore.com>
5604
5605         * valarith.c (_initialize_valarith): Remove.
5606
5607 2019-05-01  Tom Tromey  <tromey@adacore.com>
5608
5609         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5610         bitfields.
5611
5612 2019-05-01  Tom Tromey  <tromey@adacore.com>
5613
5614         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5615         for big-endian copies.
5616
5617 2019-04-30  Ali Tamur  <tamur@google.com>
5618         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5619         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5620         (read_3_bytes): New function.
5621
5622 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5623
5624         * windows-nat.c (main_thread_id): Delete.
5625         (handle_output_debug_string): Replace main_thread_id by
5626         current_event.dwThreadId.
5627         (fake_create_process): Likewise.
5628         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5629         Do not set main_thread_id.
5630         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5631         current_event.dwThreadId.
5632         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5633
5634 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5635
5636         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5637         Use current_event.dwThreadId instead of main_thread_id.
5638
5639 2019-04-30  Tom Tromey  <tromey@adacore.com>
5640
5641         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5642         (create_excep_cond_exprs): Iterate over program spaces.
5643         (ada_exception_catchpoint_cond_string): Examine all minimal
5644         symbols for exception types.
5645
5646 2019-04-30  Tom Tromey  <tromey@adacore.com>
5647
5648         PR c++/24470:
5649         * dwarf2read.c (process_structure_scope): Handle case where type
5650         has template parameters but no symbol was created.
5651
5652 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5653             Chris January  <chris.january@arm.com>
5654
5655         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5656         qualifier.
5657         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5658
5659 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5660
5661         * f-typeprint.c (f_print_type): Update rules for printing
5662         whitespace.
5663         (f_type_print_varspec_suffix): Likewise.
5664
5665 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5666             Chris January  <chris.january@arm.com>
5667
5668         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5669         function arguments.
5670
5671 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5672
5673         * f-lang.c (build_fortran_types): Change name of void type to
5674         lower case.
5675         * f-typeprint.c (f_type_print_base): Print the name of the void
5676         type, rather than a fixed string.
5677         * f-valprint.c (f_decorations): Use lower case void string.
5678
5679 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5680             Chris January  <chris.january@arm.com>
5681
5682         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5683         types for Fortran.
5684
5685 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5686             Chris January  <chris.january@arm.com>
5687             David Lecomber  <david.lecomber@arm.com>
5688
5689         * f-exp.y (BINOP_INTRINSIC): New token.
5690         (exp): New parser rule handling BINOP_INTRINSIC.
5691         (f77_keywords): Add new builtin procedures.
5692         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5693         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5694         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5695         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5696         (print_unop_subexp_f): New function.
5697         (print_binop_subexp_f): New function.
5698         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5699         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5700         (dump_subexp_body_f): Likewise.
5701         (operator_check_f): Likewise.
5702         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5703         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5704
5705 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5706
5707         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5708         UNOP_KIND.
5709         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5710         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5711         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5712         (operator_length_f): New fuction.
5713         (print_subexp_f): New function.
5714         (op_name_f): New function.
5715         (dump_subexp_body_f): New function.
5716         (operator_check_f): New function.
5717         (exp_descriptor_f): Replace standard expression handling functions
5718         with new functions.
5719         * gdb/fortran-operator.def: New file.
5720         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5721         * gdb/std-operator.def: Remove UNOP_KIND.
5722
5723 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5724
5725         * std-operator.def: Remove unbalanced, stray double quote
5726         character.
5727
5728 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5729             Chris January  <chris.january@arm.com>
5730             Daniel Everett  <daniel.everett@arm.com>
5731             Nick Forrington  <nick.forrington@arm.com>
5732             Richard Bunt  <richard.bunt@arm.com>
5733
5734         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5735         of depth when printing anonymous structs or unions.
5736         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5737         Don't print either the top-level value, or the children if the
5738         max-depth is exceeded.
5739         (ppscm_print_children): When printing the key of a map, allow one
5740         extra level of depth.
5741         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5742         print either the top-level value, or the children if the max-depth
5743         is exceeded.
5744         (print_children): When printing the key of a map, allow one extra
5745         level of depth.
5746         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5747         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5748         (user_print_options): Initialise max_depth field.
5749         (val_print_scalar_or_string_type_p): New function.
5750         (val_print): Check to see if the max depth has been reached.
5751         (val_print_check_max_depth): Define new function.
5752         (show_print_max_depth): New function.
5753         (_initialize_valprint): Add 'print max-depth' option.
5754         * valprint.h (struct value_print_options) <max_depth>: New field.
5755         (val_print_check_max_depth): Declare new function.
5756         * NEWS: Document new feature.
5757
5758 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         * ada-lang.c (ada_language_defn): Initialise new field.
5761         * c-lang.c (c_is_string_type_p): New function.
5762         (c_language_defn): Initialise new field.
5763         (cplus_language_defn): Initialise new field.
5764         (asm_language_defn): Initialise new field.
5765         (minimal_language_defn): Initialise new field.
5766         * c-lang.h (c_is_string_type_p): Declare new function.
5767         * d-lang.c (d_language_defn): Initialise new field.
5768         * f-lang.c (f_is_string_type_p): New function.
5769         (f_language_defn): Initialise new field.
5770         * go-lang.c (go_is_string_type_p): New function.
5771         (go_language_defn): Initialise new field.
5772         * language.c (default_is_string_type_p): New function.
5773         (unknown_language_defn): Initialise new field.
5774         (auto_language_defn): Initialise new field.
5775         * language.h (struct language_defn) <la_is_string_type_p>: New
5776         member variable.
5777         (default_is_string_type_p): Declare new function.
5778         * m2-lang.c (m2_language_defn): Initialise new field.
5779         * objc-lang.c (objc_language_defn): Initialise new field.
5780         * opencl-lang.c (opencl_language_defn): Initialise new field.
5781         * p-lang.c (pascal_is_string_type_p): New function.
5782         (pascal_language_defn): Initialise new field.
5783         * rust-lang.c (rust_is_string_type_p): New function.
5784         (rust_language_defn): Initialise new field.
5785
5786 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5787
5788         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5789         New field.
5790         * ada-lang.c (ada_language_defn): Initialise new field.
5791         * c-lang.c (c_language_defn): Likewise.
5792         (cplus_language_defn): Likewise.
5793         (asm_language_defn): Likewise.
5794         (minimal_language_defn): Likewise.
5795         * d-lang.c (d_language_defn): Likewise.
5796         * f-lang.c (f_language_defn): Likewise.
5797         * go-lang.c (go_language_defn): Likewise.
5798         * language.c (unknown_language_defn): Likewise.
5799         (auto_language_defn): Likewise.
5800         * m2-lang.c (m2_language_defn): Likewise.
5801         * objc-lang.c (objc_language_defn): Likewise.
5802         * opencl-lang.c (opencl_language_defn): Likewise.
5803         * p-lang.c (pascal_language_defn): Likewise.
5804         * rust-lang.c (rust_language_defn): Likewise.
5805
5806 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * ada-lang.c (ada_is_character_type): Change return type to bool.
5809         (ada_is_string_type): Likewise.
5810         * ada-lang.h (ada_is_character_type): Update declaration
5811         (ada_is_string_type): Likewise.
5812
5813 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5814
5815         Support style in 'frame|thread apply'
5816
5817         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5818         * record.c (record_start, record_stop): Update callers of
5819         execute_command_to_string with false.
5820         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5821         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5822         methods.
5823         (class string_file): New constructor with term_out parameter.
5824         Override methods term_out and can_emit_style_escape.  New member
5825         term_out.
5826         (class stdio_file): Override can_emit_style_escape.
5827         (class tee_file): Override term_out and can_emit_style_escape.
5828         * utils.h (can_emit_style_escape): Remove.
5829         * utils.c (can_emit_style_escape): Likewise.
5830         Update all callers of can_emit_style_escape (SOMESTREAM) to
5831         SOMESTREAM->can_emit_style_escape.
5832         * source-cache.c (source_cache::get_source_lines): Likewise.
5833         * stack.c (frame_apply_command_count): Call execute_command_to_string
5834         passing the term_out characteristic of the current gdb_stdout.
5835         * thread.c (thr_try_catch_cmd): Likewise.
5836         * top.c (execute_command_to_string): pass term_out parameter
5837         to construct the string_file for the command output.
5838         * ui-file.c (term_cli_styling): New function (most code moved
5839         from utils.c can_emit_style_escape).
5840         (string_file::string_file, string_file::can_emit_style_escape,
5841         stdio_file::can_emit_style_escape, tee_file::term_out,
5842         tee_file::can_emit_style_escape): New functions.
5843
5844 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5845
5846         * NEWS: Mention the new set|show may-call-functions.
5847         * infcall.c (may_call_functions_p): New variable.
5848         (show_may_call_functions_p): New function.
5849         (call_function_by_hand_dummy): Throws an error if not
5850         may-call-functions.
5851         (_initialize_infcall): Call add_setshow_boolean_cmd for
5852         may-call-functions.
5853
5854 2019-04-25  Keith Seitz  <keiths@redhat.com>
5855
5856         PR c++/24367
5857         * cp-support.c (inspect_type): Don't attempt substitutions
5858         of symbol with the same name.
5859
5860 2019-04-25  Tom Tromey  <tromey@adacore.com>
5861
5862         PR gdb/24475:
5863         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5864         static.
5865
5866 2019-04-25  Tom Tromey  <tromey@adacore.com>
5867
5868         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5869         rvalue reference.
5870         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5871         (gdb_xml_parser::parse): Use std::move.
5872         * python/python-internal.h (gdbpy_convert_exception): Take a const
5873         reference.
5874         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5875         std::move.
5876         * python/py-utils.c (gdbpy_convert_exception): Take a const
5877         reference.
5878         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5879         Use std::move.
5880         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5881         Use std::move.
5882         * mi/mi-main.c (mi_print_exception): Take a const reference.
5883         * main.c (handle_command_errors): Take a const reference.
5884         * linespec.c (parse_linespec): Use std::move.
5885         * infcall.c (run_inferior_call): Use std::move.
5886         (call_function_by_hand_dummy): Use std::move.
5887         * exec.c (try_open_exec_file): Use std::move.
5888         * exceptions.h (exception_print, exception_fprintf)
5889         (exception_print_same): Update.
5890         * exceptions.c (print_exception, exception_print)
5891         (exception_fprintf, exception_print_same): Change parameters to
5892         const reference.
5893         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5894         * common/new-op.c: Use std::move.
5895         * common/common-exceptions.h (struct gdb_exception): Add move
5896         constructor.
5897         (struct gdb_exception_error, struct gdb_exception_quit, struct
5898         gdb_quit_bad_alloc): Change constructor to move constructor.
5899         (throw_exception): Change parameter to rvalue reference.
5900         * common/common-exceptions.c (throw_exception): Take rvalue
5901         reference.
5902         * cli/cli-interp.c (safe_execute_command): Use std::move.
5903         * breakpoint.c (insert_bp_location, location_to_sals): Use
5904         std::move.
5905
5906 2019-04-25  Tom Tromey  <tromey@adacore.com>
5907
5908         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5909         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5910         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5911         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5912         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5913         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5914         guile/scm-value.c: Use unpack.
5915         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5916         gdbscm_gdb_exception.
5917         (gdbscm_throw_gdb_exception): Likewise.
5918         (struct gdbscm_gdb_exception): New.
5919         (unpack): New function.
5920         (gdbscm_wrap): Use unpack.
5921
5922 2019-04-25  Tom Tromey  <tromey@adacore.com>
5923
5924         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5925         (gdb_rl_callback_handler): Use std::move.
5926         * common/common-exceptions.h (struct gdb_exception): Add move
5927         assignment operator.
5928         (throw_exception_sjlj): Change "exception" to const reference.
5929         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5930         (throw_exception_sjlj): Change "exception" to const reference.
5931
5932 2019-04-25  Tom Tromey  <tromey@adacore.com>
5933
5934         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5935         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5936         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5937         Update.
5938         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5939         Update.
5940         * mi/mi-interp.c (mi_interp::exec): Update.
5941         * linespec.c (parse_linespec): Update.
5942         * infcall.c (run_inferior_call): Update.
5943         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5944         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5945         (gdbscm_lookup_global_symbol): Update.
5946         * guile/scm-param.c (gdbscm_parameter_value): Update.
5947         * guile/scm-frame.c (gdbscm_frame_read_register)
5948         (gdbscm_frame_read_var): Update.
5949         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5950         * exec.c (try_open_exec_file): Update.
5951         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5952         (gdb_rl_callback_handler): Update.
5953         * common/common-exceptions.h (exception_none): Don't declare.
5954         * common/common-exceptions.c (exception_none): Don't define.
5955         (struct catcher) <exception>: Update.
5956         * cli/cli-interp.c (safe_execute_command): Update.
5957         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5958
5959 2019-04-25  Ali Tamur  <tamur@google.com>
5960
5961         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5962         (read_attribute_value): Likewise.
5963         (dwarf2_read_addr_index): Update comment.
5964         (read_str_index): Add DW_FORM_strx.
5965         (dwarf2_string_attr): Likewise.
5966         (dwarf2_const_value_attr): Likewise.
5967         (dump_die_shallow): Likewise.
5968         (dwarf2_fetch_constant_bytes): Likewise.
5969         (skip_form_bytes): Likewise.
5970         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5971
5972 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5973
5974         PR corefiles/11608
5975         PR corefiles/18187
5976         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5977         OFFSET.  Verify if current mapping contains an ELF header.
5978         (linux_find_memory_regions_full): Adjust call to
5979         dump_mapping_p.
5980
5981 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5982             Kang Li <kanglictf@gmail.com>
5983
5984         PR gdb/21600
5985
5986         * dwarf2-frame.c (read_initial_length): Be consistent about using
5987         unsigned representation of length.
5988         (decode_frame_entry_1): Likewise.  Check for wraparound of
5989         end pointer as well as buffer overflow.
5990
5991 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5992
5993         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5994         "vq".
5995
5996 2019-04-24  Tom Tromey  <tromey@adacore.com>
5997
5998         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5999
6000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * s12z-tdep.c (s12z_unwind_pc): Delete.
6003         (s12z_unwind_sp): Delete.
6004         (s12z_gdbarch_init): Don't register deleted functions with
6005         gdbarch.
6006
6007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * rl78-tdep.c (rl78_unwind_sp): Delete.
6010         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6011
6012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6013
6014         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6015         (xstormy16_unwind_pc): Delete.
6016         (xstormy16_dummy_id): Delete.
6017         (xstormy16_gdbarch_init): Don't register deleted functions with
6018         gdbarch.
6019
6020 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6021
6022         * vax-tdep.c (vax_unwind_pc): Delete.
6023         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6024
6025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * v850-tdep.c (v850_unwind_sp): Delete.
6028         (v850_unwind_pc): Delete.
6029         (v850_dummy_id): Delete.
6030         (v850_gdbarch_init): Don't register deleted functions with
6031         gdbarch.
6032
6033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6036         (tilegx_unwind_pc): Delete.
6037         (tilegx_unwind_dummy_id): Delete.
6038         (tilegx_gdbarch_init): Don't register deleted functions with
6039         gdbarch.
6040
6041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6042
6043         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6044         (tic6x_dummy_id): Delete.
6045         (tic6x_gdbarch_init): Don't register deleted functions with
6046         gdbarch.
6047
6048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6049
6050         * sparc-tdep.c (sparc_unwind_pc): Delete.
6051         (sparc32_gdbarch_init): Don't register deleted function with
6052         gdbarch.
6053
6054 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6055
6056         * sh-tdep.c (sh_unwind_sp): Delete.
6057         (sh_unwind_pc): Delete.
6058         (sh_dummy_id): Delete.
6059         (sh_gdbarch_init): Don't register deleted functions with
6060         gdbarch.
6061
6062 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6063
6064         * score-tdep.c (score_unwind_sp): Delete.
6065         (score_unwind_pc): Delete.
6066         (score_dummy_id): Delete.
6067         (score_gdbarch_init): Don't register deleted functions with
6068         gdbarch.
6069
6070 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * rx-tdep.c (rx_unwind_pc): Delete.
6073         (rx_unwind_sp): Delete.
6074         (rx_dummy_id): Delete.
6075         (rx_gdbarch_init): Don't register deleted functions with
6076         gdbarch.  Update comment.
6077
6078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6081         (rs6000_dummy_id): Delete.
6082         (rs6000_gdbarch_init): Don't register deleted functions with
6083         gdbarch.
6084
6085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * or1k-tdep.c (or1k_dummy_id): Delete.
6088         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6089
6090 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * nios2-tdep.c (nios2_dummy_id): Delete.
6093         (nios2_unwind_sp): Delete.
6094         (nios2_gdbarch_init): Don't register deleted functions with
6095         gdbarch.
6096
6097 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * nds32-tdep.c (nds32_dummy_id): Delete.
6100         (nds32_unwind_pc): Delete.
6101         (nds32_unwind_sp): Delete.
6102         (nds32_gdbarch_init): Don't register deleted functions with
6103         gdbarch.
6104
6105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * msp430-tdep.c (msp430_unwind_pc): Delete.
6108         (msp430_unwind_sp): Delete.
6109         (msp430_dummy_id): Delete.
6110         (msp430_gdbarch_init): Don't register deleted functions with
6111         gdbarch.
6112
6113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6114
6115         * moxie-tdep.c (moxie_unwind_sp): Delete.
6116         (moxie_unwind_pc): Delete.
6117         (moxie_dummy_id): Delete.
6118         (moxie_gdbarch_init): Don't register deleted functions with
6119         gdbarch.
6120
6121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6122
6123         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6124         (mn10300_unwind_pc): Delete.
6125         (mn10300_unwind_sp): Delete.
6126         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6127         mn10300_unwind_sp.
6128         (mn10300_frame_unwind_init): Don't register deleted functions with
6129         gdbarch.
6130
6131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6132
6133         * mep-tdep.c (mep_unwind_pc): Delete.
6134         (mep_unwind_sp): Delete.
6135         (mep_dummy_id): Delete.
6136         (mep_gdbarch_init): Don't register deleted functions with
6137         gdbarch.
6138
6139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6142         (m68hc11_unwind_sp): Delete.
6143         (m68hc11_gdbarch_init): Don't register deleted functions with
6144         gdbarch.
6145
6146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * m32r-tdep.c (m32r_unwind_sp): Delete.
6149         (m32r_unwind_pc): Delete.
6150         (m32r_dummy_id): Delete.
6151         (m32r_gdbarch_init): Don't register deleted functions with
6152         gdbarch.
6153
6154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * m32c-tdep.c (m32c_unwind_pc): Delete.
6157         (m32c_unwind_sp): Delete.
6158         (m32c_dummy_id): Delete.
6159         (m32c_gdbarch_init): Don't register deleted functions with
6160         gdbarch.
6161
6162 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6163
6164         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6165         (lm32_unwind_pc): Delete.
6166         (lm32_dummy_id): Delete.
6167         (lm32_gdbarch_init): Don't register deleted functions with
6168         gdbarch.
6169
6170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6171
6172         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6173         (iq2000_unwind_pc): Delete.
6174         (iq2000_dummy_id): Delete.
6175         (iq2000_gdbarch_init): Don't register deleted functions with
6176         gdbarch.
6177
6178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * nds32-tdep.c (nds32_type_align): Delete.
6181         (nds32_push_dummy_call): Use type_align instead.
6182
6183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * arm-tdep.c (arm_type_align): Only handle vector override case.
6186         (arm_push_dummy_call): Use type_align.
6187         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6188
6189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6192         case.
6193         (pass_on_stack): Use type_align.
6194         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6195         function.
6196
6197 2019-04-23  Tom Tromey  <tromey@adacore.com>
6198
6199         * dwarf2read.c (line_header::file_name_at): Remove unused
6200         overload.
6201
6202 2019-04-23  Tom de Vries  <tdevries@suse.de>
6203
6204         PR gdb/24438
6205         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6206         invocation.
6207
6208
6209 2019-03-27  Ali Tamur  <tamur@google.com>
6210
6211         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6212         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6213         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6214         (dwarf_expr_context::get_addr_index): Likewise
6215         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6216         (symbol_needs_eval_context::get_addr_index): Likewise
6217         (disassemble_dwarf_expression): Add DW_OP_addrx
6218         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6219         (read_cutu_die_from_dwo): Update comment
6220         (skip_one_die): Add DW_FORM_addrx
6221         (read_attribute_value): Likewise
6222         (var_decode_location): Add DW_OP_addrx
6223         (dwarf2_const_value_attr): Add DW_FORM_addrx
6224         (dump_die_shallow): Likewise
6225         (dwarf2_fetch_constant_bytes): Likewise
6226         (decode_locdesc): Add DW_OP_addrx
6227         (skip_form_bytes): Add DW_FORM_addrx
6228
6229 2019-04-22  Ali Tamur  <tamur@google.com>
6230
6231         * MAINTAINERS (Write After Approval): Add self.
6232
6233 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6234
6235         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6236         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6237         (open_symbol_file_object): Likewise.
6238         (svr4_default_sos): Add info parameter.
6239         (svr4_read_so_list): Likewise.
6240         (svr4_current_sos_direct): Adjust functions calls to pass down
6241         info.
6242         (svr4_current_sos_1): Add info parameter.
6243         (svr4_current_sos): Call get_svr4_info, pass info down to
6244         svr4_current_sos_1.
6245         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6246         get_svr4_info.
6247         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6248         get_svr4_info.
6249         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6250         to get_svr4_info.
6251         (probes_table_remove_objfile_probes): Likewise.
6252         (register_solib_event_probe): Add info parameter.
6253         (solist_update_incremental): Pass info parameter down to
6254         svr4_read_so_list.
6255         (disable_probes_interface): Add info parameter.
6256         (svr4_handle_solib_event): Pass current_program_space to
6257         get_svr4_info.  Adjust disable_probes_interface cleanup.
6258         (svr4_create_probe_breakpoints): Add info parameter, pass it
6259         down to register_solib_event_probe.
6260         (svr4_create_solib_event_breakpoints): Add info parameter,
6261         pass it down to svr4_create_probe_breakpoints.
6262         (enable_break): Pass info down to
6263         svr4_create_solib_event_breakpoints.
6264         (svr4_solib_create_inferior_hook): Pass current_program_space to
6265         get_svr4_info.
6266         (svr4_clear_solib): Likewise.
6267
6268 2019-04-22  Pedro Alves  <palves@redhat.com>
6269
6270         * solib-svr4.c (svr4_free_objfile_observer): New.
6271         (probe_and_action::objfile): New field.
6272         (probes_table_htab_remove_objfile_probes)
6273         (probes_table_remove_objfile_probes): New functions.
6274         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6275         in the new probe_and_action.  Don't store the probe in 'lookup'.
6276         (svr4_create_probe_breakpoints): Pass objfile to
6277         register_solib_event_probe.
6278         (_initialize_svr4_solib): Register a free_objfile observer.
6279
6280 2019-04-19  Tom Tromey  <tom@tromey.com>
6281
6282         * common/queue.h: Remove.
6283
6284 2019-04-19  Tom Tromey  <tom@tromey.com>
6285
6286         * event-loop.c: Don't include "common/queue.h".
6287
6288 2019-04-19  Tom Tromey  <tom@tromey.com>
6289
6290         * remote.c (remote_target): Use delete.
6291         * remote-notif.h: Include <list>, not "common/queue.h".
6292         (notif_client_p): Remove typedef.
6293         (remote_notif_state): Add constructor, destructor, initializer.
6294         <notif_queue>: Now a std::list.
6295         (remote_notif_state_xfree): Don't declare.
6296         * remote-notif.c (remote_notif_process, handle_notification)
6297         (remote_notif_state_allocate): Update.
6298         (~remote_notif_state): Rename from remote_notif_state_xfree.
6299
6300 2019-04-19  Tom Tromey  <tom@tromey.com>
6301
6302         * symfile.c (reread_symbols): Update.
6303         * objfiles.c (objfile_register_static_link)
6304         (objfile_lookup_static_link): Update
6305         (~objfile) Don't delete static_links.
6306         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6307
6308 2019-04-19  Tom Tromey  <tom@tromey.com>
6309
6310         * type-stack.h (struct type_stack) <insert>: Constify string.
6311         * type-stack.c (type_stack::insert): Constify string.
6312         * gdbtypes.h (lookup_template_type): Update.
6313         (address_space_name_to_int): Update.
6314         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6315         const.
6316         (lookup_template_type): Make name const.
6317         * c-exp.y: Update rules.
6318         (lex_one_token, classify_name, classify_inner_name)
6319         (c_print_token): Update.
6320         * p-exp.y: Update rules.
6321         (yylex): Update.
6322         * f-exp.y: Update rules.
6323         (yylex): Update.
6324         * d-exp.y: Update rules.
6325         (lex_one_token, classify_name, classify_inner_name): Update.
6326         * parse.c (write_dollar_variable, copy_name): Return std::string.
6327         * parser-defs.h (copy_name): Change return type.
6328         * m2-exp.y: Update rules.
6329         (yylex): Update.
6330         * go-exp.y (lex_one_token): Update.
6331         Update rules.
6332         (classify_unsafe_function, classify_packaged_name)
6333         (classify_name, yylex): Update.
6334
6335 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6336
6337         * configure.ac: add --enable-source-highlight switch.
6338         * configure: Regenerate.
6339         * top.c (print_gdb_version): plumb --enable-source-highlight
6340         status to "show configuration".
6341
6342 2019-04-19  Tom Tromey  <tromey@adacore.com>
6343
6344         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6345         Check ADA_TYPE_P.
6346         (empty_record, ada_template_to_fixed_record_type_1)
6347         (template_to_static_fixed_type)
6348         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6349         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6350         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6351         macros.
6352
6353 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6354
6355         PR symtab/24423:
6356         * source.c (print_source_lines_base): Advance "iter" when a
6357         control character is seen.
6358
6359 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6360
6361         * inferior.h (struct infcall_suspend_state_deleter):
6362         Catch exception in destructor to avoid crash.
6363
6364 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6365
6366         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6367         close to the add_com "shell".
6368
6369 2019-04-18  Tom Tromey  <tromey@adacore.com>
6370
6371         * process-stratum-target.h (class process_stratum_target)
6372         <stratum>: Add "final".
6373
6374 2019-04-17  Tom Tromey  <tromey@adacore.com>
6375
6376         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6377         against nullptr before use.
6378
6379 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6380
6381         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6382
6383 2019-04-17  Jim Wilson  <jimw@sifive.com>
6384             Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6387         code read might fail, assume 4-byte breakpoint in that case.
6388
6389 2019-04-15  Leszek Swirski  <leszeks@google.com>
6390
6391         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6392         rather than a hand-rolled POD check when checking for forced MEMORY
6393         classification.
6394
6395 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6396
6397         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6398         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6399         function.
6400         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6401         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6402         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6403         declaration.
6404
6405 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6406
6407         * aarch64-linux-nat.c
6408         (aarch64_linux_nat_target::thread_architecture): Add override.
6409         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6410         each VQ.
6411
6412 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6413
6414         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6415
6416 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6417
6418         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6419         target types of size 96-bits, add some additional comments, and
6420         check that the builtin type we found was the correct size.
6421
6422 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6423
6424         * utils.c (prompt_for_continue): Don't restore the styling at the
6425         end, as applied_style has the wrong value.  This fixes styling in
6426         long lists of file names that are interrupted by the "Continue?"
6427         prompt.
6428
6429 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6432         * c-lang.c (c_language_defn): Likewise.
6433         (cplus_language_defn): Likewise.
6434         (asm_language_defn): Likewise.
6435         (minimal_language_defn): Likewise.
6436         * d-lang.c (d_language_defn): Likewise.
6437         * f-lang.c (f_language_defn): Likewise.
6438         * go-lang.c (go_language_defn): Likewise.
6439         * language.c (unknown_language_defn): Likewise.
6440         (auto_language_defn): Likewise.
6441         * language.h (struct language_defn): Remove la_magic field.
6442         (LANG_MAGIC): Delete.
6443         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6444         * objc-lang.c (objc_language_defn): Likewise.
6445         * opencl-lang.c (opencl_language_defn): Likewise.
6446         * p-lang.c (pascal_language_defn): Likewise.
6447         * rust-lang.c (rust_language_defn): Likewise.
6448
6449 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6450
6451         * riscv-tdep.c (riscv_type_align): New function.
6452         (riscv_type_alignment): Delete.
6453         (riscv_arg_location): Use 'type_align'.
6454         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6455
6456 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         * gdbtypes.c (type_align): A struct with no non-static fields also
6459         has alignment of 1.
6460
6461 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6464         component to 0.
6465         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6466         member.
6467         (riscv_struct_info::analyse): New implementation using new
6468         analyse_inner member function.
6469         (riscv_struct_info::field_offset): New member function.
6470         (riscv_struct_info::m_offsets): New member variable.
6471         (riscv_struct_info::analyse_inner): New private member function,
6472         takes the old implementation of riscv_struct_info::analyse but
6473         extended to track field offsets.
6474         (riscv_call_arg_struct): Update the struct folding special cases
6475         to handle cases where empty C++ structs, which are non-zero
6476         length, are found.
6477         (riscv_arg_location): Initialise the length of each location, a
6478         non-zero length now indicates the location is in use.
6479         (riscv_push_dummy_call): Allow for the first location having a
6480         non-zero offset when setting up arguments.
6481         (riscv_return_value): Likewise, but for return values.
6482
6483 2019-04-11  Tom Tromey  <tromey@adacore.com>
6484
6485         * utils.c (internal_vproblem): Make "msg" const.
6486
6487 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6488
6489         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6490         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6491         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6492         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6493
6494 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6495
6496         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6497         function.
6498         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6499         of amd64_collect_native_gregset.
6500         (amd64_linux_nat_target::store_registers): Likewise.
6501
6502 2019-04-10  Tom Tromey  <tom@tromey.com>
6503
6504         * symtab.c (lookup_global_symbol_from_objfile)
6505         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6506         * objfiles.h (class separate_debug_iterator): New.
6507         (class separate_debug_range): New.
6508         (struct objfile) <separate_debug_objfiles>: New method.
6509         (objfile_separate_debug_iterate): Don't declare.
6510         * objfiles.c (separate_debug_iterator::operator++): Rename from
6511         objfile_separate_debug_iterate.
6512         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6513         iterator.
6514         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6515         iterator.
6516
6517 2019-04-10  Tom Tromey  <tom@tromey.com>
6518
6519         * symfile.c (reread_symbols): Remove old comment.
6520         * objfiles.c (free_all_objfiles): Fix a typo.
6521
6522 2019-04-10  Tom Tromey  <tom@tromey.com>
6523
6524         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6525         * minsyms.c (lookup_minimal_symbol): Use foreach.
6526         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6527         (lookup_minimal_symbol_solib_trampoline): Likewise.
6528         * symfile.c (reread_symbols): Use foreach.
6529
6530 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6531             Tom Tromey  <tromey@adacore.com>
6532
6533         PR rust/24414:
6534         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6535         (rust_lex_int_test): Change "value" to be LONGEST.
6536         (rust_lex_tests): Add test for long integer literal.
6537
6538 2019-04-09  Tom Tromey  <tromey@adacore.com>
6539
6540         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6541         to bool.
6542         (extended_remote_target::attach): Update.
6543         (remote_target::remote_notice_new_inferior): Update.
6544         (remote_target::add_current_inferior_and_thread): Update.
6545         * inferior.c (exit_inferior_1): Use "false".
6546         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6547
6548 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6549
6550         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6551         the "start" command.
6552
6553 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6554
6555         * python/py-inferior.c (infpy_thread_from_thread_handle):
6556         Adjust comments to reflect renaming of thread_from_thread_handle
6557         to thread_from_handle.  Adjust keywords.  Fix type error message.
6558         (inferior_object_methods): Add thread_from_handle.  Retain
6559         thread_from_thread_handle, but mark it as deprecated.
6560
6561 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6562
6563         * gdbthread.h (find_thread_by_handle): Revise declaration.
6564         * thread.c (find_thread_by_handle): Likewise.  Adjust
6565         implementation too.
6566         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6567         support for buffer objects as handles.
6568
6569 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6570
6571         * python/py-infthread.c (thpy_thread_handle): New function.
6572         (thread_object_methods): Register thpy_thread_handle.
6573
6574 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6575
6576         * gdbthread.h (thread_to_thread_handle): Declare.
6577         * thread.c (gdbtypes.h): Include.
6578         (thread_to_thread_handle): New function.
6579
6580         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6581         (target_thread_info_to_thread_handle): Declare.
6582         * target.c (target_thread_info_to_thread_handle): New function.
6583         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6584         * target-delegates.c: Regenerate.
6585
6586         * linux-thread-db.c (class thread_db_target): Add method
6587         thread_info_to_thread_handle.
6588         (thread_db_target::thread_info_to_thread_handle): Define.
6589         * remote.c (class remote_target): Add new method
6590         thread_info_to_thread_handle.
6591         (remote_target::thread_info_to_thread_handle): Define.
6592
6593 2019-04-08  Pedro Alves  <palves@redhat.com>
6594
6595         * common/common-exceptions.c (throw_exception): Don't create
6596         named object to throw; throw directly.
6597         (throw_it): Likewise.  Don't initialize gdb_exception::message
6598         here, with new; pass FMT and AP to the ctor instead.
6599         * common/common-exceptions.h: Include <string>.
6600         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6601         const char *, va_list)): New ctor.  Use std::make_shared.
6602         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6603         errors)): Delete.
6604         (gdb_exception_error::gdb_exception_error(enum errors, const char
6605         *, va_list)): New.
6606         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6607         Add assertion.
6608         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6609         errors)): Delete.
6610         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6611         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6612         Add assertion.
6613
6614 2019-04-08  Tom Tromey  <tom@tromey.com>
6615
6616         * valops.c (value_rtti_indirect_type): Replace throw_exception
6617         with throw.
6618         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6619         with throw.
6620         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6621         throw.
6622         * target.c (target_translate_tls_address): Replace throw_exception
6623         with throw.
6624         * stack.c (frame_apply_command_count): Replace throw_exception
6625         with throw.
6626         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6627         throw.
6628         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6629         with throw.
6630         * rs6000-tdep.c (rs6000_frame_cache)
6631         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6632         * remote.c: Replace throw_exception with throw.
6633         * record-full.c (record_full_message, record_full_wait_1)
6634         (record_full_restore): Replace throw_exception with throw.
6635         * record-btrace.c:
6636         (get_thread_current_frame_id, record_btrace_start_replaying)
6637         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6638         (cmd_record_btrace_start): Replace throw_exception with throw.
6639         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6640         throw.
6641         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6642         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6643         * linespec.c:
6644         (find_linespec_symbols): Replace throw_exception with throw.
6645         * infrun.c (displaced_step_prepare, resume): Replace
6646         throw_exception with throw.
6647         * infcmd.c (post_create_inferior): Replace throw_exception with
6648         throw.
6649         * inf-loop.c (inferior_event_handler): Replace throw_exception
6650         with throw.
6651         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6652         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6653         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6654         (get_prev_frame_always, get_frame_pc_if_available)
6655         (get_frame_address_in_block_if_available, get_frame_language):
6656         Replace throw_exception with throw.
6657         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6658         throw_exception with throw.
6659         * eval.c (fetch_subexp_value, evaluate_var_value)
6660         (evaluate_funcall, evaluate_subexp_standard): Replace
6661         throw_exception with throw.
6662         * dwarf2loc.c (call_site_find_chain)
6663         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6664         Replace throw_exception with throw.
6665         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6666         with throw.
6667         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6668         throw.
6669         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6670         * completer.c (complete_line_internal): Replace throw_exception
6671         with throw.
6672         * compile/compile-object-run.c (compile_object_run): Replace
6673         throw_exception with throw.
6674         * cli/cli-script.c (process_next_line): Replace throw_exception
6675         with throw.
6676         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6677         (btrace_enable, btrace_maint_update_pt_packets): Replace
6678         throw_exception with throw.
6679         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6680         throw_exception with throw.
6681         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6682         throw_exception with throw.
6683         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6684         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6685         * aarch64-tdep.c (aarch64_make_prologue_cache)
6686         (aarch64_make_stub_cache): Replace throw_exception with throw.
6687
6688 2019-04-08  Tom Tromey  <tom@tromey.com>
6689
6690         * common/common-exceptions.c (throw_exception): Rename from
6691         throw_exception_cxx.  Remove old copy.  Make argument const.
6692         (throw_it): Create and throw exception objects directly.
6693         * common/common-exceptions.h (throw_exception): Make argument
6694         const.
6695         (struct gdb_exception_error): Add constructor.
6696         (struct gdb_exception_quit): Add constructor.
6697
6698 2019-04-08  Tom Tromey  <tom@tromey.com>
6699
6700         * common/common-exceptions.h (exception_rethrow): Don't declare.
6701         (TRY_SJLJ): Update comment.
6702         (TRY, CATCH, END_CATCH): Remove.
6703         * common/common-exceptions.c (exception_rethrow): Remove.
6704
6705 2019-04-08  Tom Tromey  <tom@tromey.com>
6706
6707         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6708         Remove.
6709         (gdb_exception_error): Rename from
6710         gdb_exception_RETURN_MASK_ERROR.
6711         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6712         (gdb_quit_bad_alloc): Update.
6713         * aarch64-tdep.c: Update.
6714         * ada-lang.c: Update.
6715         * ada-typeprint.c: Update.
6716         * ada-valprint.c: Update.
6717         * amd64-tdep.c: Update.
6718         * arch-utils.c: Update.
6719         * break-catch-throw.c: Update.
6720         * breakpoint.c: Update.
6721         * btrace.c: Update.
6722         * c-varobj.c: Update.
6723         * cli/cli-cmds.c: Update.
6724         * cli/cli-interp.c: Update.
6725         * cli/cli-script.c: Update.
6726         * common/common-exceptions.c: Update.
6727         * common/new-op.c: Update.
6728         * common/selftest.c: Update.
6729         * compile/compile-c-symbols.c: Update.
6730         * compile/compile-cplus-symbols.c: Update.
6731         * compile/compile-object-load.c: Update.
6732         * compile/compile-object-run.c: Update.
6733         * completer.c: Update.
6734         * corelow.c: Update.
6735         * cp-abi.c: Update.
6736         * cp-support.c: Update.
6737         * cp-valprint.c: Update.
6738         * darwin-nat.c: Update.
6739         * disasm-selftests.c: Update.
6740         * dtrace-probe.c: Update.
6741         * dwarf-index-cache.c: Update.
6742         * dwarf-index-write.c: Update.
6743         * dwarf2-frame-tailcall.c: Update.
6744         * dwarf2-frame.c: Update.
6745         * dwarf2loc.c: Update.
6746         * dwarf2read.c: Update.
6747         * eval.c: Update.
6748         * event-loop.c: Update.
6749         * event-top.c: Update.
6750         * exec.c: Update.
6751         * f-valprint.c: Update.
6752         * fbsd-tdep.c: Update.
6753         * frame-unwind.c: Update.
6754         * frame.c: Update.
6755         * gdbtypes.c: Update.
6756         * gnu-v3-abi.c: Update.
6757         * guile/guile-internal.h: Update.
6758         * guile/scm-block.c: Update.
6759         * guile/scm-breakpoint.c: Update.
6760         * guile/scm-cmd.c: Update.
6761         * guile/scm-disasm.c: Update.
6762         * guile/scm-frame.c: Update.
6763         * guile/scm-lazy-string.c: Update.
6764         * guile/scm-math.c: Update.
6765         * guile/scm-param.c: Update.
6766         * guile/scm-ports.c: Update.
6767         * guile/scm-pretty-print.c: Update.
6768         * guile/scm-symbol.c: Update.
6769         * guile/scm-symtab.c: Update.
6770         * guile/scm-type.c: Update.
6771         * guile/scm-value.c: Update.
6772         * i386-linux-tdep.c: Update.
6773         * i386-tdep.c: Update.
6774         * inf-loop.c: Update.
6775         * infcall.c: Update.
6776         * infcmd.c: Update.
6777         * infrun.c: Update.
6778         * jit.c: Update.
6779         * language.c: Update.
6780         * linespec.c: Update.
6781         * linux-fork.c: Update.
6782         * linux-nat.c: Update.
6783         * linux-tdep.c: Update.
6784         * linux-thread-db.c: Update.
6785         * main.c: Update.
6786         * mi/mi-cmd-break.c: Update.
6787         * mi/mi-cmd-stack.c: Update.
6788         * mi/mi-interp.c: Update.
6789         * mi/mi-main.c: Update.
6790         * objc-lang.c: Update.
6791         * p-valprint.c: Update.
6792         * parse.c: Update.
6793         * ppc-linux-tdep.c: Update.
6794         * printcmd.c: Update.
6795         * python/py-arch.c: Update.
6796         * python/py-breakpoint.c: Update.
6797         * python/py-cmd.c: Update.
6798         * python/py-finishbreakpoint.c: Update.
6799         * python/py-frame.c: Update.
6800         * python/py-framefilter.c: Update.
6801         * python/py-gdb-readline.c: Update.
6802         * python/py-inferior.c: Update.
6803         * python/py-infthread.c: Update.
6804         * python/py-lazy-string.c: Update.
6805         * python/py-linetable.c: Update.
6806         * python/py-objfile.c: Update.
6807         * python/py-param.c: Update.
6808         * python/py-prettyprint.c: Update.
6809         * python/py-progspace.c: Update.
6810         * python/py-record-btrace.c: Update.
6811         * python/py-record.c: Update.
6812         * python/py-symbol.c: Update.
6813         * python/py-type.c: Update.
6814         * python/py-unwind.c: Update.
6815         * python/py-utils.c: Update.
6816         * python/py-value.c: Update.
6817         * python/python.c: Update.
6818         * record-btrace.c: Update.
6819         * record-full.c: Update.
6820         * remote-fileio.c: Update.
6821         * remote.c: Update.
6822         * riscv-tdep.c: Update.
6823         * rs6000-aix-tdep.c: Update.
6824         * rs6000-tdep.c: Update.
6825         * rust-exp.y: Update.
6826         * rust-lang.c: Update.
6827         * s390-tdep.c: Update.
6828         * selftest-arch.c: Update.
6829         * solib-dsbt.c: Update.
6830         * solib-frv.c: Update.
6831         * solib-spu.c: Update.
6832         * solib-svr4.c: Update.
6833         * solib.c: Update.
6834         * sparc64-linux-tdep.c: Update.
6835         * stack.c: Update.
6836         * symfile-mem.c: Update.
6837         * symmisc.c: Update.
6838         * target.c: Update.
6839         * thread.c: Update.
6840         * top.c: Update.
6841         * tracefile-tfile.c: Update.
6842         * tui/tui.c: Update.
6843         * typeprint.c: Update.
6844         * unittests/cli-utils-selftests.c: Update.
6845         * unittests/parse-connection-spec-selftests.c: Update.
6846         * valops.c: Update.
6847         * valprint.c: Update.
6848         * value.c: Update.
6849         * varobj.c: Update.
6850         * windows-nat.c: Update.
6851         * x86-linux-nat.c: Update.
6852         * xml-support.c: Update.
6853
6854 2019-04-08  Tom Tromey  <tom@tromey.com>
6855
6856         * xml-support.c: Use C++ exception handling.
6857         * x86-linux-nat.c: Use C++ exception handling.
6858         * windows-nat.c: Use C++ exception handling.
6859         * varobj.c: Use C++ exception handling.
6860         * value.c: Use C++ exception handling.
6861         * valprint.c: Use C++ exception handling.
6862         * valops.c: Use C++ exception handling.
6863         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6864         handling.
6865         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6866         * typeprint.c: Use C++ exception handling.
6867         * tui/tui.c: Use C++ exception handling.
6868         * tracefile-tfile.c: Use C++ exception handling.
6869         * top.c: Use C++ exception handling.
6870         * thread.c: Use C++ exception handling.
6871         * target.c: Use C++ exception handling.
6872         * symmisc.c: Use C++ exception handling.
6873         * symfile-mem.c: Use C++ exception handling.
6874         * stack.c: Use C++ exception handling.
6875         * sparc64-linux-tdep.c: Use C++ exception handling.
6876         * solib.c: Use C++ exception handling.
6877         * solib-svr4.c: Use C++ exception handling.
6878         * solib-spu.c: Use C++ exception handling.
6879         * solib-frv.c: Use C++ exception handling.
6880         * solib-dsbt.c: Use C++ exception handling.
6881         * selftest-arch.c: Use C++ exception handling.
6882         * s390-tdep.c: Use C++ exception handling.
6883         * rust-lang.c: Use C++ exception handling.
6884         * rust-exp.y: Use C++ exception handling.
6885         * rs6000-tdep.c: Use C++ exception handling.
6886         * rs6000-aix-tdep.c: Use C++ exception handling.
6887         * riscv-tdep.c: Use C++ exception handling.
6888         * remote.c: Use C++ exception handling.
6889         * remote-fileio.c: Use C++ exception handling.
6890         * record-full.c: Use C++ exception handling.
6891         * record-btrace.c: Use C++ exception handling.
6892         * python/python.c: Use C++ exception handling.
6893         * python/py-value.c: Use C++ exception handling.
6894         * python/py-utils.c: Use C++ exception handling.
6895         * python/py-unwind.c: Use C++ exception handling.
6896         * python/py-type.c: Use C++ exception handling.
6897         * python/py-symbol.c: Use C++ exception handling.
6898         * python/py-record.c: Use C++ exception handling.
6899         * python/py-record-btrace.c: Use C++ exception handling.
6900         * python/py-progspace.c: Use C++ exception handling.
6901         * python/py-prettyprint.c: Use C++ exception handling.
6902         * python/py-param.c: Use C++ exception handling.
6903         * python/py-objfile.c: Use C++ exception handling.
6904         * python/py-linetable.c: Use C++ exception handling.
6905         * python/py-lazy-string.c: Use C++ exception handling.
6906         * python/py-infthread.c: Use C++ exception handling.
6907         * python/py-inferior.c: Use C++ exception handling.
6908         * python/py-gdb-readline.c: Use C++ exception handling.
6909         * python/py-framefilter.c: Use C++ exception handling.
6910         * python/py-frame.c: Use C++ exception handling.
6911         * python/py-finishbreakpoint.c: Use C++ exception handling.
6912         * python/py-cmd.c: Use C++ exception handling.
6913         * python/py-breakpoint.c: Use C++ exception handling.
6914         * python/py-arch.c: Use C++ exception handling.
6915         * printcmd.c: Use C++ exception handling.
6916         * ppc-linux-tdep.c: Use C++ exception handling.
6917         * parse.c: Use C++ exception handling.
6918         * p-valprint.c: Use C++ exception handling.
6919         * objc-lang.c: Use C++ exception handling.
6920         * mi/mi-main.c: Use C++ exception handling.
6921         * mi/mi-interp.c: Use C++ exception handling.
6922         * mi/mi-cmd-stack.c: Use C++ exception handling.
6923         * mi/mi-cmd-break.c: Use C++ exception handling.
6924         * main.c: Use C++ exception handling.
6925         * linux-thread-db.c: Use C++ exception handling.
6926         * linux-tdep.c: Use C++ exception handling.
6927         * linux-nat.c: Use C++ exception handling.
6928         * linux-fork.c: Use C++ exception handling.
6929         * linespec.c: Use C++ exception handling.
6930         * language.c: Use C++ exception handling.
6931         * jit.c: Use C++ exception handling.
6932         * infrun.c: Use C++ exception handling.
6933         * infcmd.c: Use C++ exception handling.
6934         * infcall.c: Use C++ exception handling.
6935         * inf-loop.c: Use C++ exception handling.
6936         * i386-tdep.c: Use C++ exception handling.
6937         * i386-linux-tdep.c: Use C++ exception handling.
6938         * guile/scm-value.c: Use C++ exception handling.
6939         * guile/scm-type.c: Use C++ exception handling.
6940         * guile/scm-symtab.c: Use C++ exception handling.
6941         * guile/scm-symbol.c: Use C++ exception handling.
6942         * guile/scm-pretty-print.c: Use C++ exception handling.
6943         * guile/scm-ports.c: Use C++ exception handling.
6944         * guile/scm-param.c: Use C++ exception handling.
6945         * guile/scm-math.c: Use C++ exception handling.
6946         * guile/scm-lazy-string.c: Use C++ exception handling.
6947         * guile/scm-frame.c: Use C++ exception handling.
6948         * guile/scm-disasm.c: Use C++ exception handling.
6949         * guile/scm-cmd.c: Use C++ exception handling.
6950         * guile/scm-breakpoint.c: Use C++ exception handling.
6951         * guile/scm-block.c: Use C++ exception handling.
6952         * guile/guile-internal.h: Use C++ exception handling.
6953         * gnu-v3-abi.c: Use C++ exception handling.
6954         * gdbtypes.c: Use C++ exception handling.
6955         * frame.c: Use C++ exception handling.
6956         * frame-unwind.c: Use C++ exception handling.
6957         * fbsd-tdep.c: Use C++ exception handling.
6958         * f-valprint.c: Use C++ exception handling.
6959         * exec.c: Use C++ exception handling.
6960         * event-top.c: Use C++ exception handling.
6961         * event-loop.c: Use C++ exception handling.
6962         * eval.c: Use C++ exception handling.
6963         * dwarf2read.c: Use C++ exception handling.
6964         * dwarf2loc.c: Use C++ exception handling.
6965         * dwarf2-frame.c: Use C++ exception handling.
6966         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6967         * dwarf-index-write.c: Use C++ exception handling.
6968         * dwarf-index-cache.c: Use C++ exception handling.
6969         * dtrace-probe.c: Use C++ exception handling.
6970         * disasm-selftests.c: Use C++ exception handling.
6971         * darwin-nat.c: Use C++ exception handling.
6972         * cp-valprint.c: Use C++ exception handling.
6973         * cp-support.c: Use C++ exception handling.
6974         * cp-abi.c: Use C++ exception handling.
6975         * corelow.c: Use C++ exception handling.
6976         * completer.c: Use C++ exception handling.
6977         * compile/compile-object-run.c: Use C++ exception handling.
6978         * compile/compile-object-load.c: Use C++ exception handling.
6979         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6980         * compile/compile-c-symbols.c: Use C++ exception handling.
6981         * common/selftest.c: Use C++ exception handling.
6982         * common/new-op.c: Use C++ exception handling.
6983         * cli/cli-script.c: Use C++ exception handling.
6984         * cli/cli-interp.c: Use C++ exception handling.
6985         * cli/cli-cmds.c: Use C++ exception handling.
6986         * c-varobj.c: Use C++ exception handling.
6987         * btrace.c: Use C++ exception handling.
6988         * breakpoint.c: Use C++ exception handling.
6989         * break-catch-throw.c: Use C++ exception handling.
6990         * arch-utils.c: Use C++ exception handling.
6991         * amd64-tdep.c: Use C++ exception handling.
6992         * ada-valprint.c: Use C++ exception handling.
6993         * ada-typeprint.c: Use C++ exception handling.
6994         * ada-lang.c: Use C++ exception handling.
6995         * aarch64-tdep.c: Use C++ exception handling.
6996
6997 2019-04-08  Tom Tromey  <tom@tromey.com>
6998
6999         * xml-support.c (gdb_xml_parser::parse): Update.
7000         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7001         * value.c (show_convenience): Update.
7002         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7003         (test_parse_flags_qcs): Update.
7004         * thread.c (thr_try_catch_cmd): Update.
7005         * target.c (target_translate_tls_address): Update.
7006         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7007         (info_frame_command_core, frame_apply_command_count): Update.
7008         * rust-exp.y (rust_lex_exception_test): Update.
7009         * riscv-tdep.c (riscv_print_one_register_info): Update.
7010         * remote.c (remote_target::enable_btrace): Update.
7011         * record-btrace.c (record_btrace_enable_warn): Update.
7012         * python/py-utils.c (gdbpy_convert_exception): Update.
7013         * printcmd.c (do_one_display, print_variable_and_value): Update.
7014         * mi/mi-main.c (mi_print_exception): Update.
7015         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7016         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7017         * linux-nat.c (linux_nat_target::attach): Update.
7018         * linux-fork.c (class scoped_switch_fork_info): Update.
7019         * infrun.c (displaced_step_prepare): Update.
7020         * infcall.c (call_function_by_hand_dummy): Update.
7021         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7022         * gnu-v3-abi.c (print_one_vtable): Update.
7023         * frame.c (get_prev_frame_always): Update.
7024         * f-valprint.c (info_common_command_for_block): Update.
7025         * exec.c (try_open_exec_file): Update.
7026         * exceptions.c (print_exception, exception_print)
7027         (exception_fprintf, exception_print_same): Update.
7028         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7029         * dwarf-index-cache.c (index_cache::store)
7030         (index_cache::lookup_gdb_index): Update.
7031         * darwin-nat.c (maybe_cache_shell): Update.
7032         * cp-valprint.c (cp_print_value_fields): Update.
7033         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7034         (gcc_cplus_symbol_address): Update.
7035         * compile/compile-c-symbols.c (gcc_convert_symbol)
7036         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7037         * common/selftest.c: Update.
7038         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7039         a std::string.
7040         (exception_try_scope_entry, exception_try_scope_exit): Don't
7041         declare.
7042         (struct exception_try_scope): Remove.
7043         (TRY): Don't use exception_try_scope.
7044         (struct gdb_exception): Add constructor, operator=.
7045         <what>: New method.
7046         (struct gdb_exception_RETURN_MASK_ALL)
7047         (struct gdb_exception_RETURN_MASK_ERROR)
7048         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7049         (struct gdb_quit_bad_alloc): Update.
7050         * common/common-exceptions.c (exception_none): Change
7051         initializer.
7052         (struct catcher) <state, exception>: Initialize inline.
7053         <prev>: Remove member.
7054         (current_catcher): Remove.
7055         (catchers): New global.
7056         (exceptions_state_mc_init): Simplify.
7057         (catcher_pop): Remove.
7058         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7059         (try_scope_depth, exception_try_scope_entry)
7060         (exception_try_scope_exit): Remove.
7061         (throw_exception_sjlj): Update.
7062         (exception_messages, exception_messages_size): Remove.
7063         (throw_it): Simplify.
7064         (gdb_exception_sliced_copy): Remove.
7065         (throw_exception_cxx): Update.
7066         * cli/cli-script.c (script_from_file): Update.
7067         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7068         Update.
7069         * ada-valprint.c (ada_val_print): Update.
7070         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7071         (create_excep_cond_exprs): Update.
7072
7073 2019-04-08  Tom Tromey  <tom@tromey.com>
7074
7075         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7076         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7077         (TRY, CATCH, END_CATCH): Remove some definitions.
7078         * common/common-exceptions.c: Don't use GDB_XCPT.
7079         (catcher_list_size): Remove.
7080         (throw_exception, throw_it): Simplify.
7081
7082 2019-04-05  Tom Tromey  <tom@tromey.com>
7083
7084         Revert the header-sorting patch.
7085         * ft32-tdep.c: Revert.
7086         * frv-tdep.c: Revert.
7087         * frv-linux-tdep.c: Revert.
7088         * frame.c: Revert.
7089         * frame-unwind.c: Revert.
7090         * frame-base.c: Revert.
7091         * fork-child.c: Revert.
7092         * findvar.c: Revert.
7093         * findcmd.c: Revert.
7094         * filesystem.c: Revert.
7095         * filename-seen-cache.h: Revert.
7096         * filename-seen-cache.c: Revert.
7097         * fbsd-tdep.c: Revert.
7098         * fbsd-nat.h: Revert.
7099         * fbsd-nat.c: Revert.
7100         * f-valprint.c: Revert.
7101         * f-typeprint.c: Revert.
7102         * f-lang.c: Revert.
7103         * extension.h: Revert.
7104         * extension.c: Revert.
7105         * extension-priv.h: Revert.
7106         * expprint.c: Revert.
7107         * exec.h: Revert.
7108         * exec.c: Revert.
7109         * exceptions.c: Revert.
7110         * event-top.c: Revert.
7111         * event-loop.c: Revert.
7112         * eval.c: Revert.
7113         * elfread.c: Revert.
7114         * dwarf2read.h: Revert.
7115         * dwarf2read.c: Revert.
7116         * dwarf2loc.c: Revert.
7117         * dwarf2expr.h: Revert.
7118         * dwarf2expr.c: Revert.
7119         * dwarf2-frame.c: Revert.
7120         * dwarf2-frame-tailcall.c: Revert.
7121         * dwarf-index-write.h: Revert.
7122         * dwarf-index-write.c: Revert.
7123         * dwarf-index-common.c: Revert.
7124         * dwarf-index-cache.h: Revert.
7125         * dwarf-index-cache.c: Revert.
7126         * dummy-frame.c: Revert.
7127         * dtrace-probe.c: Revert.
7128         * disasm.h: Revert.
7129         * disasm.c: Revert.
7130         * disasm-selftests.c: Revert.
7131         * dictionary.c: Revert.
7132         * dicos-tdep.c: Revert.
7133         * demangle.c: Revert.
7134         * dcache.h: Revert.
7135         * dcache.c: Revert.
7136         * darwin-nat.h: Revert.
7137         * darwin-nat.c: Revert.
7138         * darwin-nat-info.c: Revert.
7139         * d-valprint.c: Revert.
7140         * d-namespace.c: Revert.
7141         * d-lang.c: Revert.
7142         * ctf.c: Revert.
7143         * csky-tdep.c: Revert.
7144         * csky-linux-tdep.c: Revert.
7145         * cris-tdep.c: Revert.
7146         * cris-linux-tdep.c: Revert.
7147         * cp-valprint.c: Revert.
7148         * cp-support.c: Revert.
7149         * cp-namespace.c: Revert.
7150         * cp-abi.c: Revert.
7151         * corelow.c: Revert.
7152         * corefile.c: Revert.
7153         * continuations.c: Revert.
7154         * completer.h: Revert.
7155         * completer.c: Revert.
7156         * complaints.c: Revert.
7157         * coffread.c: Revert.
7158         * coff-pe-read.c: Revert.
7159         * cli-out.h: Revert.
7160         * cli-out.c: Revert.
7161         * charset.c: Revert.
7162         * c-varobj.c: Revert.
7163         * c-valprint.c: Revert.
7164         * c-typeprint.c: Revert.
7165         * c-lang.c: Revert.
7166         * buildsym.c: Revert.
7167         * buildsym-legacy.c: Revert.
7168         * build-id.h: Revert.
7169         * build-id.c: Revert.
7170         * btrace.c: Revert.
7171         * bsd-uthread.c: Revert.
7172         * breakpoint.h: Revert.
7173         * breakpoint.c: Revert.
7174         * break-catch-throw.c: Revert.
7175         * break-catch-syscall.c: Revert.
7176         * break-catch-sig.c: Revert.
7177         * blockframe.c: Revert.
7178         * block.c: Revert.
7179         * bfin-tdep.c: Revert.
7180         * bfin-linux-tdep.c: Revert.
7181         * bfd-target.c: Revert.
7182         * bcache.c: Revert.
7183         * ax-general.c: Revert.
7184         * ax-gdb.h: Revert.
7185         * ax-gdb.c: Revert.
7186         * avr-tdep.c: Revert.
7187         * auxv.c: Revert.
7188         * auto-load.c: Revert.
7189         * arm-wince-tdep.c: Revert.
7190         * arm-tdep.c: Revert.
7191         * arm-symbian-tdep.c: Revert.
7192         * arm-pikeos-tdep.c: Revert.
7193         * arm-obsd-tdep.c: Revert.
7194         * arm-nbsd-tdep.c: Revert.
7195         * arm-nbsd-nat.c: Revert.
7196         * arm-linux-tdep.c: Revert.
7197         * arm-linux-nat.c: Revert.
7198         * arm-fbsd-tdep.c: Revert.
7199         * arm-fbsd-nat.c: Revert.
7200         * arm-bsd-tdep.c: Revert.
7201         * arch-utils.c: Revert.
7202         * arc-tdep.c: Revert.
7203         * arc-newlib-tdep.c: Revert.
7204         * annotate.h: Revert.
7205         * annotate.c: Revert.
7206         * amd64-windows-tdep.c: Revert.
7207         * amd64-windows-nat.c: Revert.
7208         * amd64-tdep.c: Revert.
7209         * amd64-sol2-tdep.c: Revert.
7210         * amd64-obsd-tdep.c: Revert.
7211         * amd64-obsd-nat.c: Revert.
7212         * amd64-nbsd-tdep.c: Revert.
7213         * amd64-nbsd-nat.c: Revert.
7214         * amd64-nat.c: Revert.
7215         * amd64-linux-tdep.c: Revert.
7216         * amd64-linux-nat.c: Revert.
7217         * amd64-fbsd-tdep.c: Revert.
7218         * amd64-fbsd-nat.c: Revert.
7219         * amd64-dicos-tdep.c: Revert.
7220         * amd64-darwin-tdep.c: Revert.
7221         * amd64-bsd-nat.c: Revert.
7222         * alpha-tdep.c: Revert.
7223         * alpha-obsd-tdep.c: Revert.
7224         * alpha-nbsd-tdep.c: Revert.
7225         * alpha-mdebug-tdep.c: Revert.
7226         * alpha-linux-tdep.c: Revert.
7227         * alpha-linux-nat.c: Revert.
7228         * alpha-bsd-tdep.c: Revert.
7229         * alpha-bsd-nat.c: Revert.
7230         * aix-thread.c: Revert.
7231         * agent.c: Revert.
7232         * addrmap.c: Revert.
7233         * ada-varobj.c: Revert.
7234         * ada-valprint.c: Revert.
7235         * ada-typeprint.c: Revert.
7236         * ada-tasks.c: Revert.
7237         * ada-lang.c: Revert.
7238         * aarch64-tdep.c: Revert.
7239         * aarch64-ravenscar-thread.c: Revert.
7240         * aarch64-newlib-tdep.c: Revert.
7241         * aarch64-linux-tdep.c: Revert.
7242         * aarch64-linux-nat.c: Revert.
7243         * aarch64-fbsd-tdep.c: Revert.
7244         * aarch64-fbsd-nat.c: Revert.
7245         * aarch32-linux-nat.c: Revert.
7246
7247 2019-04-05  Tom Tromey  <tom@tromey.com>
7248
7249         * ft32-tdep.c: Sort headers.
7250         * frv-tdep.c: Sort headers.
7251         * frv-linux-tdep.c: Sort headers.
7252         * frame.c: Sort headers.
7253         * frame-unwind.c: Sort headers.
7254         * frame-base.c: Sort headers.
7255         * fork-child.c: Sort headers.
7256         * findvar.c: Sort headers.
7257         * findcmd.c: Sort headers.
7258         * filesystem.c: Sort headers.
7259         * filename-seen-cache.h: Sort headers.
7260         * filename-seen-cache.c: Sort headers.
7261         * fbsd-tdep.c: Sort headers.
7262         * fbsd-nat.h: Sort headers.
7263         * fbsd-nat.c: Sort headers.
7264         * f-valprint.c: Sort headers.
7265         * f-typeprint.c: Sort headers.
7266         * f-lang.c: Sort headers.
7267         * extension.h: Sort headers.
7268         * extension.c: Sort headers.
7269         * extension-priv.h: Sort headers.
7270         * expprint.c: Sort headers.
7271         * exec.h: Sort headers.
7272         * exec.c: Sort headers.
7273         * exceptions.c: Sort headers.
7274         * event-top.c: Sort headers.
7275         * event-loop.c: Sort headers.
7276         * eval.c: Sort headers.
7277         * elfread.c: Sort headers.
7278         * dwarf2read.h: Sort headers.
7279         * dwarf2read.c: Sort headers.
7280         * dwarf2loc.c: Sort headers.
7281         * dwarf2expr.h: Sort headers.
7282         * dwarf2expr.c: Sort headers.
7283         * dwarf2-frame.c: Sort headers.
7284         * dwarf2-frame-tailcall.c: Sort headers.
7285         * dwarf-index-write.h: Sort headers.
7286         * dwarf-index-write.c: Sort headers.
7287         * dwarf-index-common.c: Sort headers.
7288         * dwarf-index-cache.h: Sort headers.
7289         * dwarf-index-cache.c: Sort headers.
7290         * dummy-frame.c: Sort headers.
7291         * dtrace-probe.c: Sort headers.
7292         * disasm.h: Sort headers.
7293         * disasm.c: Sort headers.
7294         * disasm-selftests.c: Sort headers.
7295         * dictionary.c: Sort headers.
7296         * dicos-tdep.c: Sort headers.
7297         * demangle.c: Sort headers.
7298         * dcache.h: Sort headers.
7299         * dcache.c: Sort headers.
7300         * darwin-nat.h: Sort headers.
7301         * darwin-nat.c: Sort headers.
7302         * darwin-nat-info.c: Sort headers.
7303         * d-valprint.c: Sort headers.
7304         * d-namespace.c: Sort headers.
7305         * d-lang.c: Sort headers.
7306         * ctf.c: Sort headers.
7307         * csky-tdep.c: Sort headers.
7308         * csky-linux-tdep.c: Sort headers.
7309         * cris-tdep.c: Sort headers.
7310         * cris-linux-tdep.c: Sort headers.
7311         * cp-valprint.c: Sort headers.
7312         * cp-support.c: Sort headers.
7313         * cp-namespace.c: Sort headers.
7314         * cp-abi.c: Sort headers.
7315         * corelow.c: Sort headers.
7316         * corefile.c: Sort headers.
7317         * continuations.c: Sort headers.
7318         * completer.h: Sort headers.
7319         * completer.c: Sort headers.
7320         * complaints.c: Sort headers.
7321         * coffread.c: Sort headers.
7322         * coff-pe-read.c: Sort headers.
7323         * cli-out.h: Sort headers.
7324         * cli-out.c: Sort headers.
7325         * charset.c: Sort headers.
7326         * c-varobj.c: Sort headers.
7327         * c-valprint.c: Sort headers.
7328         * c-typeprint.c: Sort headers.
7329         * c-lang.c: Sort headers.
7330         * buildsym.c: Sort headers.
7331         * buildsym-legacy.c: Sort headers.
7332         * build-id.h: Sort headers.
7333         * build-id.c: Sort headers.
7334         * btrace.c: Sort headers.
7335         * bsd-uthread.c: Sort headers.
7336         * breakpoint.h: Sort headers.
7337         * breakpoint.c: Sort headers.
7338         * break-catch-throw.c: Sort headers.
7339         * break-catch-syscall.c: Sort headers.
7340         * break-catch-sig.c: Sort headers.
7341         * blockframe.c: Sort headers.
7342         * block.c: Sort headers.
7343         * bfin-tdep.c: Sort headers.
7344         * bfin-linux-tdep.c: Sort headers.
7345         * bfd-target.c: Sort headers.
7346         * bcache.c: Sort headers.
7347         * ax-general.c: Sort headers.
7348         * ax-gdb.h: Sort headers.
7349         * ax-gdb.c: Sort headers.
7350         * avr-tdep.c: Sort headers.
7351         * auxv.c: Sort headers.
7352         * auto-load.c: Sort headers.
7353         * arm-wince-tdep.c: Sort headers.
7354         * arm-tdep.c: Sort headers.
7355         * arm-symbian-tdep.c: Sort headers.
7356         * arm-pikeos-tdep.c: Sort headers.
7357         * arm-obsd-tdep.c: Sort headers.
7358         * arm-nbsd-tdep.c: Sort headers.
7359         * arm-nbsd-nat.c: Sort headers.
7360         * arm-linux-tdep.c: Sort headers.
7361         * arm-linux-nat.c: Sort headers.
7362         * arm-fbsd-tdep.c: Sort headers.
7363         * arm-fbsd-nat.c: Sort headers.
7364         * arm-bsd-tdep.c: Sort headers.
7365         * arch-utils.c: Sort headers.
7366         * arc-tdep.c: Sort headers.
7367         * arc-newlib-tdep.c: Sort headers.
7368         * annotate.h: Sort headers.
7369         * annotate.c: Sort headers.
7370         * amd64-windows-tdep.c: Sort headers.
7371         * amd64-windows-nat.c: Sort headers.
7372         * amd64-tdep.c: Sort headers.
7373         * amd64-sol2-tdep.c: Sort headers.
7374         * amd64-obsd-tdep.c: Sort headers.
7375         * amd64-obsd-nat.c: Sort headers.
7376         * amd64-nbsd-tdep.c: Sort headers.
7377         * amd64-nbsd-nat.c: Sort headers.
7378         * amd64-nat.c: Sort headers.
7379         * amd64-linux-tdep.c: Sort headers.
7380         * amd64-linux-nat.c: Sort headers.
7381         * amd64-fbsd-tdep.c: Sort headers.
7382         * amd64-fbsd-nat.c: Sort headers.
7383         * amd64-dicos-tdep.c: Sort headers.
7384         * amd64-darwin-tdep.c: Sort headers.
7385         * amd64-bsd-nat.c: Sort headers.
7386         * alpha-tdep.c: Sort headers.
7387         * alpha-obsd-tdep.c: Sort headers.
7388         * alpha-nbsd-tdep.c: Sort headers.
7389         * alpha-mdebug-tdep.c: Sort headers.
7390         * alpha-linux-tdep.c: Sort headers.
7391         * alpha-linux-nat.c: Sort headers.
7392         * alpha-bsd-tdep.c: Sort headers.
7393         * alpha-bsd-nat.c: Sort headers.
7394         * aix-thread.c: Sort headers.
7395         * agent.c: Sort headers.
7396         * addrmap.c: Sort headers.
7397         * ada-varobj.c: Sort headers.
7398         * ada-valprint.c: Sort headers.
7399         * ada-typeprint.c: Sort headers.
7400         * ada-tasks.c: Sort headers.
7401         * ada-lang.c: Sort headers.
7402         * aarch64-tdep.c: Sort headers.
7403         * aarch64-ravenscar-thread.c: Sort headers.
7404         * aarch64-newlib-tdep.c: Sort headers.
7405         * aarch64-linux-tdep.c: Sort headers.
7406         * aarch64-linux-nat.c: Sort headers.
7407         * aarch64-fbsd-tdep.c: Sort headers.
7408         * aarch64-fbsd-nat.c: Sort headers.
7409         * aarch32-linux-nat.c: Sort headers.
7410
7411 2019-04-04  Tom Tromey  <tom@tromey.com>
7412
7413         * varobj.c (varobj_create): Update.
7414         * rust-exp.y (struct rust_parser) <update_innermost_block,
7415         lookup_symbol>: New methods.
7416         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7417         Rename.
7418         (rust_parser::rust_lookup_type)
7419         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7420         * printcmd.c (display_command, do_one_display): Update.
7421         * parser-defs.h (struct parser_state) <parser_state>: Add
7422         "tracker" parameter.
7423         (block_tracker): New member.
7424         (class innermost_block_tracker) <innermost_block_tracker>: Add
7425         "types" parameter.
7426         <reset>: Remove method.
7427         (innermost_block): Don't declare.
7428         (null_post_parser): Update.
7429         * parse.c (innermost_block): Remove global.
7430         (write_dollar_variable): Update.
7431         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7432         Remove "tracker_types" parameter.
7433         (parse_expression): Add "tracker" parameter.
7434         (parse_expression_for_completion): Update.
7435         (null_post_parser): Add "tracker" parameter.
7436         * p-exp.y: Update rules.
7437         * m2-exp.y: Update rules.
7438         * language.h (struct language_defn) <la_post_parser>: Add
7439         "tracker" parameter.
7440         * go-exp.y: Update rules.
7441         * f-exp.y: Update rules.
7442         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7443         parameter.
7444         * d-exp.y: Update rules.
7445         * c-exp.y: Update rules.
7446         * breakpoint.c (set_breakpoint_condition): Create an
7447         innermost_block_tracker.
7448         (watch_command_1): Likewise.
7449         * ada-lang.c (resolve): Add "tracker" parameter.
7450         (resolve_subexp): Likewise.
7451         * ada-exp.y (write_var_from_sym): Update.
7452
7453 2019-04-04  Tom Tromey  <tom@tromey.com>
7454
7455         * type-stack.h: New file.
7456         * type-stack.c: New file.
7457         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7458         type-stack.h.
7459         (insert_into_type_stack, insert_type, push_type, push_type_int)
7460         (insert_type_address_space, pop_type, pop_type_int)
7461         (pop_typelist, pop_type_stack, append_type_stack)
7462         (push_type_stack, get_type_stack, push_typelist)
7463         (follow_type_instance_flags, follow_types): Don't declare.
7464         * parse.c (type_stack): Remove global.
7465         (parse_exp_in_context): Update.
7466         (insert_into_type_stack, insert_type, push_type, push_type_int)
7467         (insert_type_address_space, pop_type, pop_type_int)
7468         (pop_typelist, pop_type_stack, append_type_stack)
7469         (push_type_stack, get_type_stack, push_typelist)
7470         (follow_type_instance_flags, follow_types): Remove (moved to
7471         type-stack.c).
7472         * f-exp.y (type_stack): New global.
7473         Update rules.
7474         (push_kind_type, f_parse): Update.
7475         * d-exp.y (type_stack): New global.
7476         Update rules.
7477         (d_parse): Update.
7478         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7479         Update rules.
7480         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7481         (HFILES_NO_SRCDIR): Add type-stack.h.
7482
7483 2019-04-04  Tom Tromey  <tom@tromey.com>
7484
7485         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7486         (rust_parser::convert_ast_to_expression, rust_parse)
7487         (rust_lex_test_completion, rust_lex_tests): Update.
7488         * parser-defs.h (struct expr_completion_state): New.
7489         (struct parser_state) <parser_state>: Add completion parameter.
7490         <mark_struct_expression, mark_completion_tag>: New methods.
7491         <parse_completion, m_completion_state>: New members.
7492         (prefixify_expression, null_post_parser): Update.
7493         (mark_struct_expression, mark_completion_tag): Don't declare.
7494         * parse.c (parse_completion, expout_last_struct)
7495         (expout_tag_completion_type, expout_completion_name): Remove
7496         globals.
7497         (parser_state::mark_struct_expression)
7498         (parser_state::mark_completion_tag): Now methods.
7499         (prefixify_expression): Add last_struct parameter.
7500         (prefixify_subexp): Likewise.
7501         (parse_exp_1): Update.
7502         (parse_exp_in_context): Add cstate parameter.  Update.
7503         (parse_expression_for_completion): Create an
7504         expr_completion_state.
7505         (null_post_parser): Add "completion" parameter.
7506         * p-exp.y: Update rules.
7507         (yylex): Update.
7508         * language.h (struct language_defn) <la_post_parser>: Add
7509         "completing" parameter.
7510         * go-exp.y: Update rules.
7511         (lex_one_token): Update.
7512         * expression.h (parse_completion): Don't declare.
7513         * d-exp.y: Update rules.
7514         (lex_one_token): Update rules.
7515         * c-exp.y: Update rules.
7516         (lex_one_token): Update.
7517         * ada-lang.c (resolve): Add "parse_completion" parameter.
7518         (resolve_subexp): Likewise.
7519         (ada_resolve_function): Likewise.
7520
7521 2019-04-04  Tom Tromey  <tom@tromey.com>
7522
7523         * parser-defs.h (struct parser_state) <start_arglist,
7524         end_arglist>: New methods.
7525         <arglist_len, m_funcall_chain>: New members.
7526         (arglist_len, start_arglist, end_arglist): Don't declare.
7527         * parse.c (arglist_len, funcall_chain): Remove global.
7528         (start_arglist, end_arglist): Remove functions.
7529         (parse_exp_in_context): Update.
7530         * p-exp.y: Update rules.
7531         * m2-exp.y: Update rules.
7532         * go-exp.y: Update rules.
7533         * f-exp.y: Update rules.
7534         * d-exp.y: Update rules.
7535         * c-exp.y: Update rules.
7536
7537 2019-04-04  Tom Tromey  <tom@tromey.com>
7538
7539         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7540         lex_operator, push_back>: New methods.
7541         Update all rules.
7542         (rust_parser::lex_hex, lex_escape): Rename and update.
7543         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7544         (rust_parser::lex_operator): Rename and update.
7545         (rust_parser::lex_number, rustyylex, rustyyerror)
7546         (rust_lex_test_init, rust_lex_test_sequence)
7547         (rust_lex_test_push_back, rust_lex_tests): Update.
7548         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7549         parameter.
7550         <lexptr, prev_lexptr>: New members.
7551         (lexptr, prev_lexptr): Don't declare.
7552         * parse.c (lexptr, prev_lexptr): Remove globals.
7553         (parse_exp_in_context): Update.
7554         * p-exp.y (yylex, yyerror): Update.
7555         * m2-exp.y (parse_number, yylex, yyerror): Update.
7556         * go-exp.y (lex_one_token, yyerror): Update.
7557         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7558         * d-exp.y (lex_one_token, yyerror): Update.
7559         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7560         (lex_one_token, yyerror): Update.
7561         * ada-lex.l (YY_INPUT): Update.
7562         (rewind_to_char): Update.
7563         * ada-exp.y (yyerror): Update.
7564
7565 2019-04-04  Tom Tromey  <tom@tromey.com>
7566
7567         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7568         * parser-defs.h (struct parser_state) <parser_state>: Add new
7569         parameter.
7570         <comma_terminates>: New member.
7571         (comma_terminates): Don't declare global.
7572         * parse.c (comma_terminates): Remove global.
7573         (parse_exp_in_context): Update.
7574         * p-exp.y (yylex): Update.
7575         * m2-exp.y (yylex): Update.
7576         * go-exp.y (lex_one_token): Update.
7577         * f-exp.y (yylex): Update.
7578         * d-exp.y (lex_one_token): Update.
7579         * c-exp.y (lex_one_token): Update.
7580         * ada-lex.l: Update.
7581
7582 2019-04-04  Tom Tromey  <tom@tromey.com>
7583
7584         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7585         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7586         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7587         * parser-defs.h (paren_depth): Don't declare.
7588         * parse.c (paren_depth): Remove global.
7589         (parse_exp_in_context): Update.
7590         * p-exp.y (paren_depth): New global.
7591         (pascal_parse): Initialize it.
7592         * m2-exp.y (paren_depth): New global.
7593         (m2_parse): Initialize it.
7594         * go-exp.y (paren_depth): New global.
7595         (go_parse): Initialize it.
7596         * f-exp.y (paren_depth): New global.
7597         (f_parse): Initialize it.
7598         * d-exp.y (paren_depth): New global.
7599         (d_parse): Initialize it.
7600         * c-exp.y (paren_depth): New global.
7601         (c_parse): Initialize it.
7602         * ada-lex.l (paren_depth): New global.
7603         (lexer_init): Initialize it.
7604
7605 2019-04-04  Tom Tromey  <tom@tromey.com>
7606
7607         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7608         (rust_parser::convert_ast_to_type)
7609         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7610         * parser-defs.h (struct parser_state) <parser_state>: Add
7611         parameters.  Initialize new members.
7612         <expression_context_block, expression_context_pc>: New members.
7613         * parse.c (expression_context_block, expression_context_pc):
7614         Remove globals.
7615         (parse_exp_in_context): Update.
7616         * p-exp.y: Update all rules.
7617         (yylex): Update.
7618         * m2-exp.y: Update all rules.
7619         (yylex): Update.
7620         * go-exp.y (yylex): Update.
7621         * f-exp.y (yylex): Update.
7622         * d-exp.y: Update all rules.
7623         (yylex): Update.
7624         * c-exp.y: Update all rules.
7625         (lex_one_token, classify_name, yylex, c_parse): Update.
7626         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7627
7628 2019-04-04  Tom Tromey  <tom@tromey.com>
7629
7630         * gdbarch.h, gdbarch.c: Rebuild.
7631         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7632         * stap-probe.h:
7633         (struct stap_parse_info): Replace "parser_state" with
7634         "expr_builder".
7635         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7636         (parser_state): New class.
7637         * parse.c (expr_builder): Rename.
7638         (expr_builder::release): Rename.
7639         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7640         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7641         (write_exp_elt_longcst, write_exp_elt_floatcst)
7642         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7643         (write_exp_string_vector, write_exp_bitstring)
7644         (write_exp_msymbol, mark_struct_expression)
7645         (write_dollar_variable)
7646         (insert_type_address_space, increase_expout_size): Replace
7647         "parser_state" with "expr_builder".
7648         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7649         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7650         "parser_state" with "expr_builder".
7651
7652 2019-04-04  Tom Tromey  <tom@tromey.com>
7653
7654         * rust-exp.y: Replace "parse_language" with method call.
7655         * p-exp.y:
7656         (yylex): Replace "parse_language" with method call.
7657         * m2-exp.y:
7658         (yylex): Replace "parse_language" with method call.
7659         * go-exp.y (classify_name): Replace "parse_language" with method
7660         call.
7661         * f-exp.y (yylex): Replace "parse_language" with method call.
7662         * d-exp.y (lex_one_token): Replace "parse_language" with method
7663         call.
7664         * c-exp.y:
7665         (lex_one_token, classify_name, yylex): Replace "parse_language"
7666         with method call.
7667         * ada-exp.y (find_primitive_type, type_char)
7668         (type_system_address): Replace "parse_language" with method call.
7669
7670 2019-04-04  Tom Tromey  <tom@tromey.com>
7671
7672         * rust-exp.y: Replace "parse_gdbarch" with method call.
7673         * parse.c (write_dollar_variable, insert_type_address_space):
7674         Replace "parse_gdbarch" with method call.
7675         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7676         call.
7677         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7678         call.
7679         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7680         "parse_gdbarch" with method call.
7681         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7682         with method call.
7683         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7684         "parse_gdbarch" with method call.
7685         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7686         "parse_gdbarch" with method call.
7687         * c-exp.y (parse_type, parse_number, classify_name): Replace
7688         "parse_gdbarch" with method call.
7689         * ada-lex.l: Replace "parse_gdbarch" with method call.
7690         * ada-exp.y (parse_type, find_primitive_type, type_char)
7691         (type_system_address): Replace "parse_gdbarch" with method call.
7692
7693 2019-04-04  Tom Tromey  <tom@tromey.com>
7694
7695         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7696         * stap-probe.c (stap_parse_argument): Update.
7697         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7698         initial_size parameter.
7699         * rust-exp.y (rust_lex_tests): Update.
7700         * parse.c (parser_state): Update.
7701         (parse_exp_in_context): Update.
7702         * parser-defs.h (struct parser_state) <parser_state>: Remove
7703         "initial_size" parameter.
7704
7705 2019-04-04  Tom Tromey  <tom@tromey.com>
7706
7707         * parser-defs.h (increase_expout_size): Don't declare.
7708         * parse.c (increase_expout_size): Now static.
7709
7710 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7711
7712         * gnu-nat.c (gnu_nat_target::wait): Fix
7713         target_waitstatus_to_string call.
7714
7715 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7716
7717         * eval.c (evaluate_subexp_standard): Handle internal functions
7718         during Fortran function call handling.
7719
7720 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7721
7722         * NEWS: Mention new internal functions.
7723         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7724         (read_base_type): Use dwarf2_init_complex_target_type.
7725         * value.c (creal_internal_fn): New function.
7726         (cimag_internal_fn): New function.
7727         (_initialize_values): Register new internal functions.
7728
7729 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7730
7731         * infrun.c (stop_all_threads): If debug_infrun, always
7732         trace the wait status after wait_one, using
7733         target_waitstatus_to_string and target_pid_to_str.
7734         (handle_inferior_event): Replace various trace of
7735         wait status kind by a single trace.
7736         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7737         wait status kind image by target_waitstatus_to_string.
7738         * target/waitstatus.c (target_waitstatus_to_string): Fix
7739         obsolete comment.
7740
7741 2019-04-01  Tom Tromey  <tromey@adacore.com>
7742
7743         PR symtab/23331:
7744         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7745
7746 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7747             Pedro Alves  <palves@redhat.com>
7748
7749         * top.c (quit_force): Call 'finalize_values'.
7750         * value.c (finalize_values): New function.
7751         * value.h (finalize_values): Declare.
7752
7753 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7754
7755         * NEWS: Announce $_gdb_major and $_gdb_minor.
7756
7757         * top.c (init_gdb_version_vars): New function.
7758         (gdb_init): Call init_gdb_version_vars.
7759
7760 2019-03-29  Tom Tromey  <tromey@adacore.com>
7761
7762         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7763         help text.  Remove dead code.
7764
7765 2019-03-29  Keith Seitz  <keiths@redhat.com>
7766
7767         From Siddhesh Poyarekar:
7768         * f-lang.h (f77_get_upperbound): Return LONGEST.
7769         (f77_get_lowerbound): Likewise.
7770         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7771         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7772         print them.
7773         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7774         plongest to format print it.
7775         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7776         (f77_get_upperbound): Likewise.
7777         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7778         LOWER_BOUND to LONGEST.
7779         (f77_create_arrayprint_offset_tbl): Likewise.
7780
7781 2019-03-29  Keith Seitz  <keiths@redhat.com>
7782
7783         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7784         %s/pulongest for TYPE_LENGTH instead of %d in format
7785         strings.
7786         * ada-typerint.c (ada_print_type): Likewise.
7787         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7788         * compile/compile-c-support.c (generate_register_struct): Likewise.
7789         * gdbtypes.c (recursive_dump_type): Likewise.
7790         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7791         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7792         instead of %d in format strings.
7793         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7794         to std::min to ULONGEST.
7795         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7796         instead of %d in format strings.
7797         * tracepoint.c (info_scope_command): Likewise.
7798         * typeprint.c (print_offset_data::update)
7799         (print_offset_data::finish): Likewise.
7800         * xtensa-tdep.c (xtensa_store_return_value)
7801         (xtensa_push_dummy_call): Likewise.
7802
7803 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7804
7805         * windows-nat.c (display_selector): Fixed format specifications
7806         for 64-bit Cygwin.
7807
7808 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7809
7810         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7811
7812 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7813
7814         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7815         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7816         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7817         (nios2_linux_init_abi): Install it.
7818
7819 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7820
7821         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7822
7823 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7826
7827 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7828             Tom Tromey  <tromey@adacore.com>
7829
7830         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7831
7832 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7833
7834         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7835         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7836         method to compute the bounds of range types. Also print "[evaluated]"
7837         if the bounds' values come from a dynamic evaluation.
7838
7839 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7842         whitespace when pretty printing is on.
7843
7844 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7845
7846         * ppc-linux-nat.c: Add include.
7847
7848 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7849
7850         * NEWS: Mention AArch64 Pointer Authentication.
7851
7852 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7853
7854         * arm-linux-nat.c: Add include.
7855
7856 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7857
7858         * source-cache.c (source_cache::get_source_lines): Re-read
7859         fullname after calling open_source_file.
7860
7861 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7862
7863         * NEWS: Mention TLS support for FreeBSD.
7864
7865 2019-03-25  Tom Tromey  <tromey@adacore.com>
7866
7867         * minsyms.c (BUNCH_SIZE): Update comment.
7868         (~minimal_symbol_reader): Remove old comment.
7869         (compact_minimal_symbols): Update comment.
7870         (minimal_symbol_reader::install): Remove old comment.  Update
7871         other comments.
7872
7873 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7874
7875         * s390-linux-nat.c: Add include.
7876
7877 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7878
7879         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7880         Call linux_get_hwcap.
7881         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7882         Likewise.
7883         (aarch64_linux_get_hwcap): Remove function.
7884         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7885         declaration.
7886         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7887         linux_get_hwcap.
7888         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7889         * linux-tdep.c (linux_get_hwcap): Add function.
7890         (linux_get_hwcap2): Likewise.
7891         * linux-tdep.h (linux_get_hwcap): Add declaration.
7892         (linux_get_hwcap2): Likewise.
7893         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7894         (ppc_linux_get_hwcap2): Likewise.
7895         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7896         linux_get_hwcap.
7897         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7898         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7899         (ppc_linux_nat_target::read_description): Likewise.
7900         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7901         * s390-linux-nat.c: Likewise.
7902         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7903
7904 2019-03-24  Tom Tromey  <tom@tromey.com>
7905
7906         * ada-lang.c (standard_lookup): Simplify initialization.
7907         (ada_lookup_symbol_nonlocal): Simplify return.
7908         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7909         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7910         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7911         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7912         initialization.
7913         * solib.c (solib_global_lookup): Simplify.
7914         * symtab.c (null_block_symbol): Remove.
7915         (symbol_cache_lookup): Simplify returns.
7916         (lookup_language_this): Simplify returns.
7917         (lookup_symbol_aux): Simplify return.
7918         (lookup_local_symbol): Simplify returns.
7919         (lookup_global_symbol_from_objfile): Simplify return.
7920         (lookup_symbol_in_objfile_symtabs)
7921         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7922         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7923         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7924         * cp-namespace.c (cp_lookup_bare_symbol)
7925         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7926         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7927         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7928         (cp_lookup_symbol_via_imports): Simplify initialization.
7929         (find_symbol_in_baseclass): Likewise.
7930         * symtab.h (null_block_symbol): Remove.
7931         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7932         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7933         (d_lookup_symbol_module): Likewise.
7934         (find_symbol_in_baseclass): Simplify initialization.
7935
7936 2019-03-24  Tom Tromey  <tom@tromey.com>
7937
7938         * expression.h: Don't include symtab.h.
7939         (struct block): Forward declare.
7940
7941 2019-03-24  Tom Tromey  <tom@tromey.com>
7942
7943         * c-exp.y (typebase): Remove casts.
7944         * gdbtypes.c (lookup_unsigned_typename, )
7945         (lookup_signed_typename): Remove cast.
7946         * eval.c (parse_to_comma_and_eval): Remove cast.
7947         * parse.c (write_dollar_variable): Remove cast.
7948         * block.h (struct block) <superblock>: Now const.
7949         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7950         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7951         (map_block): Make "block" const.
7952         * symfile.h (struct quick_symbol_functions)
7953         <map_matching_symbols>: Constify block argument to "callback".
7954         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7955         const.
7956         (find_pc_sect_compunit_symtab): Make "b" const.
7957         (find_symbol_at_address): Likewise.
7958         (search_symbols): Likewise.
7959         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7960         (dw2_debug_names_lookup_symbol): Likewise.
7961         (dw2_map_matching_symbols): Update.
7962         * p-valprint.c (pascal_val_print): Remove "block".
7963         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7964         (aux_add_nonlocal_symbols): Make "block" const.
7965         (resolve_subexp): Remove cast.
7966         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7967         const.
7968         (iterate_over_file_blocks): Likewise.
7969         * f-exp.y (%union) <bval>: Remove.
7970         * coffread.c (patch_opaque_types): Make "b" const.
7971         * spu-tdep.c (spu_catch_start): Make "block" const.
7972         * c-valprint.c (print_unpacked_pointer): Remove "block".
7973         * symmisc.c (dump_symtab_1): Make "b" const.
7974         (block_depth): Make "block" const.
7975         * d-exp.y (%union) <bval>: Remove.
7976         * cp-support.h (cp_lookup_rtti_type): Update.
7977         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7978         * psymtab.c (psym_lookup_symbol): Make "block" const.
7979         (maintenance_check_psymtabs): Make "b" const.
7980         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7981         (enumerate_locals, enumerate_args): Update.
7982         * python/py-symtab.c (stpy_global_block): Make "block" const.
7983         (stpy_static_block): Likewise.
7984         * inline-frame.c (block_starting_point_at): Make "new_block"
7985         const.
7986         * block.c (find_block_in_blockvector): Make return type const.
7987         (blockvector_for_pc_sect): Make "b" const.
7988         (find_block_in_blockvector): Make "b" const.
7989
7990 2019-03-23  Tom Tromey  <tom@tromey.com>
7991
7992         * varobj.c (varobj_create): Update.
7993         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7994         * printcmd.c (display_command, do_one_display): Don't reset
7995         innermost_block.
7996         * parser-defs.h (enum innermost_block_tracker_type): Move to
7997         expression.h.
7998         (innermost_block): Update comment.
7999         * parse.c (parse_exp_1): Add tracker_types parameter.
8000         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8001         tracker_types parameter.  Reset innermost_block.
8002         (parse_exp_in_context): Remove.
8003         (parse_expression_for_completion): Update.
8004         * objfiles.c (~objfile): Don't reset expression_context_block or
8005         innermost_block.
8006         * expression.h (enum innermost_block_tracker_type): Move from
8007         parser-defs.h.
8008         (parse_exp_1): Add tracker_types parameter.
8009         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8010         reset innermost_block.
8011
8012 2019-03-23  Tom Tromey  <tom@tromey.com>
8013
8014         * objfiles.h: Include bcache.h.
8015
8016 2019-03-23  Tom Tromey  <tom@tromey.com>
8017
8018         * linespec.c (get_current_search_block): Use
8019         scoped_restore_current_language.
8020         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8021
8022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8023             Jiong Wang  <jiong.wang@arm.com>
8024
8025         * aarch64-linux-tdep.c
8026         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8027         section.
8028         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8029
8030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8031             Jiong Wang  <jiong.wang@arm.com>
8032
8033         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8034         instructions.
8035         (aarch64_analyze_prologue_test): Add PACIASP test.
8036         (aarch64_prologue_prev_register): Unmask PC value.
8037
8038 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8039             Jiong Wang  <jiong.wang@arm.com>
8040
8041         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8042         (aarch64_dwarf2_prev_register): Unmask PC value.
8043         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8044         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8045         DW_CFA_AARCH64_negate_ra_state.
8046         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8047
8048 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8049             Jiong Wang  <jiong.wang@arm.com>
8050
8051         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8052         registers.
8053         (aarch64_pseudo_register_name): Likewise.
8054         (aarch64_pseudo_register_type): Likewise.
8055         (aarch64_pseudo_register_reggroup_p): Likewise.
8056         (aarch64_gdbarch_init): Add pauth registers.
8057         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8058         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8059         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8060         (struct gdbarch_tdep): Add regnum for ra_state.
8061
8062 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8063             Jiong Wang  <jiong.wang@arm.com>
8064
8065         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8066
8067 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8068             Jiong Wang  <jiong.wang@arm.com>
8069
8070         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8071         function.
8072         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8073         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8074         (aarch64_gdbarch_init): Add puth registers.
8075         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8076         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8077         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8078
8079 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8080             Jiong Wang  <jiong.wang@arm.com>
8081
8082         * aarch64-linux-nat.c
8083         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8084         * aarch64-linux-tdep.c
8085         (aarch64_linux_core_read_description): Likewise.
8086         (aarch64_linux_get_hwcap): New function.
8087         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8088         (aarch64_linux_get_hwcap): New declaration.
8089
8090 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8091             Jiong Wang  <jiong.wang@arm.com>
8092
8093         * aarch64-linux-nat.c
8094         (aarch64_linux_nat_target::read_description): Add pauth param.
8095         * aarch64-linux-tdep.c
8096         (aarch64_linux_core_read_description): Likewise.
8097         * aarch64-tdep.c (struct target_desc): Add in pauth.
8098         (aarch64_read_description): Add pauth param.
8099         (aarch64_gdbarch_init): Likewise.
8100         * aarch64-tdep.h (aarch64_read_description): Likewise.
8101         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8102         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8103         * features/Makefile: Add new files.
8104         * features/aarch64-pauth.c: New file.
8105         * features/aarch64-pauth.xml: New file.
8106
8107 2019-03-20  Tom Tromey  <tromey@adacore.com>
8108
8109         * infrun.c (handle_inferior_event): Rename from
8110         handle_inferior_event_1.  Create a scoped_value_mark.
8111         (handle_inferior_event): Remove.
8112
8113 2019-03-19  Tom Tromey  <tromey@adacore.com>
8114
8115         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8116         * infrun.h (print_stop_event): Add "displays" parameter.
8117         * infrun.c (print_stop_event): Add "displays" parameter.
8118
8119 2019-03-19  Pedro Alves  <palves@redhat.com>
8120
8121         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8122         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8123         to -1.  Fix TABs vs spaces.
8124         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8125         * tui/tui-out.h (tui_ui_out) Add intro comments.
8126         <m_line, m_start_of_line>: In-class initialize, and add describing
8127         comment.
8128
8129 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8130
8131         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8132         variable names.
8133         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8134
8135 2019-03-18  Pedro Alves  <palves@redhat.com>
8136             Eli Zaretskii <eliz@gnu.org>
8137
8138         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8139         m_line and m_start_of_line.
8140
8141 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8142
8143         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8144         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8145         it returns a newline.  This fixes a regression in TU mode, whereby
8146         the next line is output on the same screen line as the user input.
8147
8148 2019-03-18  Tom Tromey  <tromey@adacore.com>
8149
8150         * minsyms.c (minimal_symbol_reader::install): Remove call to
8151         obstack_blank.
8152
8153 2019-03-18  Pedro Alves  <palves@redhat.com>
8154
8155         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8156         New globals.
8157         (apply_style): New, factored out from ...
8158         (apply_ansi_escape): ... this.  Handle reverse video mode.
8159         (tui_set_reverse_mode): New function.
8160         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8161         * tui/tui-winsource.c (tui_show_source_line): Use
8162         tui_set_reverse_mode instead of setting A_STANDOUT.
8163         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8164         New setter methods.
8165
8166 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8167
8168         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8169         Handle tabs.
8170
8171 2019-03-18  Tom Tromey  <tromey@adacore.com>
8172
8173         * ada-lang.c (empty_array): Add "high" parameter.
8174         (ada_evaluate_subexp): Update.
8175
8176 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8177
8178         * unittests/string_view-selftests.c: Define
8179         _initialize_string_view_selftests unconditionally.
8180
8181 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8182
8183         PR gdb/24350
8184         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8185
8186 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8187
8188         PR gdb/24351
8189         * windows-nat.c (display_selector): Fix format specifiers.
8190
8191 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8192
8193         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8194         tui_refill_source_window instead of tui_refresh_win, to update the
8195         current execution line.  This fixes redisplay of the current line
8196         when stepping through the code with "next" or "step".
8197
8198 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8199
8200         * source-cache.c (source_cache::get_source_lines): Call
8201         find_source_lines to initialize s->nlines.  This fixes vertical
8202         scrolling of TUI source window when the DOWN arrow is pressed.
8203
8204 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8205
8206         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8207         linux-thread-db.c (_initialize_thread_db): Likewise.
8208
8209 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8210
8211         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8212         wclrtoeol in tui_show_source_line".  This reverts changes made in
8213         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8214
8215 2019-03-15  Tom Tromey  <tom@tromey.com>
8216
8217         * symtab.h (struct minimal_symbol): Derive from
8218         general_symbol_info.
8219         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8220         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8221         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8222         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8223         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8224         (MSYMBOL_SEARCH_NAME): Update.
8225         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8226         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8227         * minsyms.c (minimal_symbol_reader::record_full): Update.
8228
8229 2019-03-15  Tom Tromey  <tom@tromey.com>
8230
8231         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8232
8233 2019-03-15  Tom Tromey  <tom@tromey.com>
8234
8235         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8236         unique_xmalloc_ptr.
8237         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8238         Update.
8239         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8240         (build_minimal_symbol_hash_tables)
8241         (minimal_symbol_reader::install): Update.
8242
8243 2019-03-15  Tom Tromey  <tom@tromey.com>
8244
8245         * symtab.c (create_demangled_names_hash): Update.
8246         (symbol_set_names): Update.
8247         * objfiles.h (struct objfile_per_bfd_storage)
8248         <demangled_names_hash>: Now an htab_up.
8249         * objfiles.c (objfile_per_bfd_storage): Simplify.
8250
8251 2019-03-15  Tom Tromey  <tom@tromey.com>
8252
8253         * objfiles.h (struct objfile_per_bfd_storage): Declare
8254         destructor.
8255         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8256         New.
8257         (get_objfile_bfd_data): Use new.  Don't initialize
8258         language_of_main.
8259         (free_objfile_per_bfd_storage): Remove.
8260         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8261
8262 2019-03-15  Tom Tromey  <tom@tromey.com>
8263
8264         * symfile.c (reread_symbols): Update.
8265         * objfiles.c (objfile::objfile): Update.
8266         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8267         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8268         comment.
8269         (minimal_symbol_reader::install): Update.
8270         (terminate_minimal_symbol_table): Remove.
8271         * jit.c (jit_object_close_impl): Update.
8272
8273 2019-03-15  Tom Tromey  <tom@tromey.com>
8274
8275         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8276         initializations.
8277
8278 2019-03-15  Tom Tromey  <tom@tromey.com>
8279
8280         * objfiles.h (struct objfile_per_bfd_storage)
8281         <demangled_hash_languages>: Now a bitset.
8282         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8283         (lookup_minimal_symbol): Update.
8284
8285 2019-03-15  Tom Tromey  <tom@tromey.com>
8286
8287         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8288         Don't return the symbol.
8289         * coffread.c (record_minimal_symbol): Use record_full.
8290
8291 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8292
8293         The MS-Windows port of ncurses fails to switch to a color pair if
8294         one or both of the colors are the implicit default colors.  This
8295         change records the default colors when TUI is initialized, and
8296         then specifies them explicitly when a color pair uses the default
8297         colors.  This allows color styling in TUI mode on MS-Windows.
8298
8299         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8300         ncurses_norm_attr.
8301         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8302         colors in ncurses_norm_attr.
8303         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8304         "none", replace it with the default color recorded in
8305         ncurses_norm_attr.
8306
8307 2019-03-14  Tom Tromey  <tromey@adacore.com>
8308
8309         * source-cache.h (class source_cache) <get_source_lines>: Return
8310         std::string.
8311         * source-cache.c (source_cache::extract_lines): Handle case where
8312         first_pos==npos.  Return std::string.
8313         (source_cache::get_source_lines): Update.
8314
8315 2019-03-14  Tom Tromey  <tromey@adacore.com>
8316
8317         * NEWS: Add item for "style sources" commands.
8318         * source-cache.c (source_cache::get_source_lines): Check
8319         source_styling.
8320         * cli/cli-style.c (source_styling): New global.
8321         (_initialize_cli_style): Add "style sources" commands.
8322         (show_style_sources): New function.
8323         * cli/cli-style.h (source_styling): Declare.
8324
8325 2019-03-14  Pedro Alves  <palves@redhat.com>
8326             Tom Tromey  <tromey@adacore.com>
8327
8328         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8329         * tui/tui-winsource.c (tui_refill_source_window): New function,
8330         from...
8331         (tui_horizontal_source_scroll): ... here.  Move some logic.
8332         * cli/cli-style.c (set_style_enabled): Notify new observable.
8333         * tui/tui-hooks.c (tui_redisplay_source): New function.
8334         (tui_attach_detach_observers): Attach or detach
8335         tui_redisplay_source.
8336         * observable.h (source_styling_changed): New observable.
8337         * observable.c: Define source_styling_changed observable.
8338
8339 2019-03-13  Tom Tromey  <tromey@adacore.com>
8340
8341         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8342         (i386_gnu_nat_target::store_registers): Update.
8343         * target-debug.h (target_debug_print_std_string): New macro.
8344         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8345         * windows-tdep.c (display_one_tib): Update.
8346         * tui/tui-stack.c (tui_make_status_line): Update.
8347         * top.c (print_inferior_quit_action): Update.
8348         * thread.c (thr_try_catch_cmd): Update.
8349         (add_thread_with_info): Update.
8350         (thread_target_id_str): Update.
8351         (thr_try_catch_cmd): Update.
8352         (thread_command): Update.
8353         (thread_find_command): Update.
8354         * record-btrace.c (record_btrace_target::info_record)
8355         (record_btrace_resume_thread, record_btrace_target::resume)
8356         (record_btrace_cancel_resume, record_btrace_step_thread)
8357         (record_btrace_target::wait, record_btrace_target::wait)
8358         (record_btrace_target::wait, record_btrace_target::stop): Update.
8359         * progspace.c (print_program_space): Update.
8360         * process-stratum-target.c
8361         (process_stratum_target::thread_address_space): Update.
8362         * linux-fork.c (linux_fork_mourn_inferior)
8363         (detach_checkpoint_command, info_checkpoints_command)
8364         (linux_fork_context): Update.
8365         (linux_fork_detach): Update.
8366         (class scoped_switch_fork_info): Update.
8367         (delete_checkpoint_command): Update.
8368         * infrun.c (follow_fork_inferior): Update.
8369         (follow_fork_inferior): Update.
8370         (proceed_after_vfork_done): Update.
8371         (handle_vfork_child_exec_or_exit): Update.
8372         (follow_exec): Update.
8373         (displaced_step_prepare_throw): Update.
8374         (displaced_step_restore): Update.
8375         (start_step_over): Update.
8376         (resume_1): Update.
8377         (clear_proceed_status_thread): Update.
8378         (proceed): Update.
8379         (print_target_wait_results): Update.
8380         (do_target_wait): Update.
8381         (context_switch): Update.
8382         (stop_all_threads): Update.
8383         (restart_threads): Update.
8384         (finish_step_over): Update.
8385         (handle_signal_stop): Update.
8386         (switch_back_to_stepped_thread): Update.
8387         (keep_going_pass_signal): Update.
8388         (print_exited_reason): Update.
8389         (normal_stop): Update.
8390         * inferior.c (inferior_pid_to_str): Change return type.
8391         (print_selected_inferior): Update.
8392         (add_inferior): Update.
8393         (detach_inferior): Update.
8394         * dummy-frame.c (fprint_dummy_frames): Update.
8395         * dcache.c (dcache_info_1): Update.
8396         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8397         (btrace_fetch, btrace_clear): Update.
8398         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8399         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8400         type.
8401         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8402         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8403         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8404         * gdbarch.c, gdbarch.h: Rebuild.
8405         * gdbarch.sh (core_pid_to_str): Change return type.
8406         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8407         return type.
8408         (windows_nat_target::pid_to_str): Change return type.
8409         (windows_delete_thread): Update.
8410         (windows_nat_target::attach): Update.
8411         (windows_nat_target::files_info): Update.
8412         * target-delegates.c: Rebuild.
8413         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8414         return type.
8415         (sol_thread_target::pid_to_str): Change return type.
8416         * remote.c (class remote_target) <pid_to_str>: Change return
8417         type.
8418         (remote_target::pid_to_str): Change return type.
8419         (extended_remote_target::attach, remote_target::remote_stop_ns)
8420         (remote_target::remote_notif_remove_queued_reply)
8421         (remote_target::push_stop_reply, remote_target::disable_btrace):
8422         Update.
8423         (extended_remote_target::attach): Update.
8424         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8425         type.
8426         (gdbsim_target::pid_to_str): Change return type.
8427         * ravenscar-thread.c (struct ravenscar_thread_target)
8428         <pid_to_str>: Change return type.
8429         (ravenscar_thread_target::pid_to_str): Change return type.
8430         * procfs.c (class procfs_target) <pid_to_str>: Change return
8431         type.
8432         (procfs_target::pid_to_str): Change return type.
8433         (procfs_target::attach): Update.
8434         (procfs_target::detach): Update.
8435         (procfs_target::fetch_registers): Update.
8436         (procfs_target::store_registers): Update.
8437         (procfs_target::wait): Update.
8438         (procfs_target::files_info): Update.
8439         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8440         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8441         return type.
8442         (nto_procfs_target::pid_to_str): Change return type.
8443         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8444         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8445         return type.
8446         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8447         (exit_lwp): Update.
8448         (attach_proc_task_lwp_callback, get_detach_signal)
8449         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8450         (linux_nat_target::resume, wait_lwp, stop_callback)
8451         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8452         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8453         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8454         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8455         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8456         type.
8457         (inf_ptrace_target::attach): Update.
8458         (inf_ptrace_target::files_info): Update.
8459         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8460         type.
8461         (go32_nat_target::pid_to_str): Change return type.
8462         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8463         (gnu_nat_target::wait): Update.
8464         (gnu_nat_target::wait): Update.
8465         (gnu_nat_target::resume): Update.
8466         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8467         (fbsd_nat_target::wait): Update.
8468         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8469         type.
8470         (darwin_nat_target::attach): Update.
8471         * corelow.c (class core_target) <pid_to_str>: Change return type.
8472         (core_target::pid_to_str): Change return type.
8473         * target.c (normal_pid_to_str): Change return type.
8474         (default_pid_to_str): Likewise.
8475         (target_pid_to_str): Change return type.
8476         (target_translate_tls_address): Update.
8477         (target_announce_detach): Update.
8478         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8479         return type.
8480         (bsd_uthread_target::pid_to_str): Change return type.
8481         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8482         type.
8483         (bsd_kvm_target::pid_to_str): Change return type.
8484         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8485         return type.
8486         (aix_thread_target::pid_to_str): Change return type.
8487         * target.h (struct target_ops) <pid_to_str>: Change return type.
8488         (target_pid_to_str, normal_pid_to_str): Likewise.
8489         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8490         type.
8491         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8492         type.
8493         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8494         return type.
8495         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8496         type.
8497         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8498         type.
8499         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8500         return type.
8501
8502 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8503
8504         * NEWS: Mention that the new default MI version is 3.  Mention
8505         changes to the output of commands and events that deal with
8506         multi-location breakpoints.
8507         * breakpoint.c: Include "mi/mi-out.h".
8508         (print_one_breakpoint): Change output syntax if using MI version
8509         >= 3.
8510         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8511         New.
8512         (mi_multi_location_breakpoint_output_fixed): New.
8513         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8514         (mi_cmd_fix_multi_location_breakpoint_output): New.
8515         (mi_multi_location_breakpoint_output_fixed): New.
8516         * mi/mi-cmds.c (mi_cmds): Register command
8517         -fix-multi-location-breakpoint-output.
8518         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8519         interpreter "mi".
8520
8521 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8522
8523         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8524         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8525         instantiate mi_ui_out based on interpreter name.
8526         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8527         * mi/mi-main.c (mi_load_progress): Likewise.
8528
8529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8530
8531         * NEWS: Combine separate "New targets" sections for 8.3.
8532
8533 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8534
8535         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8536         (ppcfbsd_init_abi): Install gdbarch
8537         "fetch_tls_load_module_address" and "get_thread_local_address"
8538         methods.
8539
8540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8541
8542         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8543         (riscv_fbsd_init_abi): Install gdbarch
8544         "fetch_tls_load_module_address" and "get_thread_local_address"
8545         methods.
8546
8547 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8548
8549         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8550         (i386fbsd_init_abi): Install gdbarch
8551         "fetch_tls_load_module_address" and "get_thread_local_address"
8552         methods.
8553
8554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8555
8556         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8557         (amd64fbsd_init_abi): Install gdbarch
8558         "fetch_tls_load_module_address" and "get_thread_local_address"
8559         methods.
8560
8561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8562
8563         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8564         (struct fbsd_pspace_data): New type.
8565         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8566         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8567         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8568         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8569         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8570
8571 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8572
8573         * gdbtypes.c (lookup_struct_elt): New function.
8574         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8575         * gdbtypes.h (struct struct_elt): New type.
8576         (lookup_struct_elt): New prototype.
8577
8578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8579
8580         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8581         remove disabled code block.
8582
8583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8584
8585         * gdbarch.sh (get_thread_local_address): New method.
8586         * gdbarch.h, gdbarch.c: Regenerate.
8587         * target.c (target_translate_tls_address): Use
8588         gdbarch_get_thread_local_address if present instead of
8589         target::get_thread_local_address.
8590
8591 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8592
8593         * target.h (target::get_thread_local_address): Update comment.
8594
8595 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8596
8597         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8598         objfile->separate_debug_objfile_backlink if not NULL.
8599
8600 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8601
8602         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8603         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8604         (amd64bsd_store_inferior_registers): Likewise.
8605         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8606         Enable segment base registers.
8607         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8608         PT_GETFSBASE and PT_GETGSBASE.
8609         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8610         PT_SETGSBASE.
8611         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8612         segment base registers.
8613         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8614
8615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8616
8617         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8618         Update calls to i386_target_description to add 'segments'
8619         parameter.
8620         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8621         add segment base registers.
8622         * arch/i386.c (i386_create_target_description): Add 'segments'
8623         parameter to enable segment base registers.
8624         * arch/i386.h (i386_create_target_description): Likewise.
8625         * features/i386/32bit-segments.xml: New file.
8626         * features/i386/32bit-segments.c: Generate.
8627         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8628         call to i386_target_description to add 'segments' parameter.
8629         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8630         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8631         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8632         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8633         if feature is present.
8634         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8635         Add 'segments' parameter to call to i386_target_description.
8636         (i386_target_description): Add 'segments' parameter to enable
8637         segment base registers.
8638         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8639         to call to i386_target_description.
8640         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8641         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8642         Define I386_NUM_REGS.
8643         (i386_target_description): Add 'segments' parameter to enable
8644         segment base registers.
8645
8646 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8647
8648         PR/24325
8649         * source-cache.c: #undef open and close, to avoid unresolved
8650         externals during linking.
8651
8652 2019-03-12  Tom Tromey  <tromey@adacore.com>
8653
8654         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8655         const.  Add initializers.
8656         (_initialize_remote): Don't initialize ptid globals.
8657
8658 2019-03-12  Pedro Alves  <palves@redhat.com>
8659
8660         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8661
8662 2019-03-12  Pedro Alves  <palves@redhat.com>
8663
8664         * cp-name-parser.y (main): Remove unused 'len' variable.
8665
8666 2019-03-12  Tom Tromey  <tromey@adacore.com>
8667
8668         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8669         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8670
8671 2019-03-12  Tom Tromey  <tromey@adacore.com>
8672
8673         * linux-nat.c (iterate_over_lwps): Update.
8674         (stop_callback): Remove parameter.
8675         (stop_wait_callback, detach_callback, resume_set_callback)
8676         (select_singlestep_lwp_callback, set_ignore_sigint)
8677         (status_callback, resumed_callback, resume_clear_callback)
8678         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8679         data parameter.
8680         (linux_nat_target::detach, linux_nat_target::resume)
8681         (linux_stop_and_wait_all_lwps, select_event_lwp)
8682         (linux_nat_filter_event, linux_nat_wait_1)
8683         (linux_nat_target::kill, linux_nat_target::stop)
8684         (linux_nat_target::stop): Update.
8685         (linux_nat_resume_callback): Change type.
8686         (resume_stopped_resumed_lwps, count_events_callback)
8687         (select_event_lwp_callback): Likewise.
8688         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8689         * arm-linux-nat.c (struct update_registers_data): Remove.
8690         (update_registers_callback): Change type.
8691         (arm_linux_insert_hw_breakpoint1): Update.
8692         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8693         parameter.
8694         (x86_linux_dr_set_addr): Update.
8695         (x86_linux_dr_set_control): Update.
8696         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8697         (iterate_over_lwps): Use gdb::function_view.
8698         * nat/aarch64-linux-hw-point.c (struct
8699         aarch64_dr_update_callback_param): Remove.
8700         (debug_reg_change_callback): Change type.
8701         (aarch64_notify_debug_reg_change): Update.
8702         * s390-linux-nat.c (s390_refresh_per_info): Update.
8703
8704 2019-03-11  Tom Tromey  <tromey@adacore.com>
8705
8706         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8707         redundant assignment to "this_cu".
8708
8709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8710
8711         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8712
8713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8714
8715         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8716         from...
8717         (rank_one_type): ... this.
8718
8719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8720
8721         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8722         from...
8723         (rank_one_type): ... this.
8724
8725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8726
8727         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8728         from...
8729         (rank_one_type): ... this.
8730
8731 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8732
8733         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8734         from...
8735         (rank_one_type): ... this.
8736
8737 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8738
8739         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8740         from...
8741         (rank_one_type): ... this.
8742
8743 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8744
8745         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8746         from...
8747         (rank_one_type): ... this.
8748
8749 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8750
8751         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8752         from...
8753         (rank_one_type): ... this.
8754
8755 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8756
8757         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8758         from...
8759         (rank_one_type): ... this.
8760
8761 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8762
8763         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8764         from...
8765         (rank_one_type): ... this.
8766
8767 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8768
8769         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8770         from...
8771         (rank_one_type): ... this.
8772
8773 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8774
8775         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8776         from...
8777         (rank_one_type): ... this.
8778
8779 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8780
8781         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8782         from...
8783         (rank_one_type): ... this.
8784
8785 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8786
8787         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8788         inferior-events' shows the example events.
8789
8790 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8791
8792         Support styling on native MS-Windows console
8793
8794         PR/24315
8795         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8796         on MS-Windows if $TERM is not defined.
8797
8798         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8799
8800         * posix-hdep.c (gdb_console_fputs):
8801         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8802         functions.
8803         * ui-file.h (gdb_console_fputs): Add prototype.
8804
8805         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8806         back to fputs only if the former returns zero.
8807
8808 2019-03-07  Tom Tromey  <tom@tromey.com>
8809
8810         * symmisc.c (print_symbol_bcache_statistics): Update.
8811         (print_objfile_statistics): Update.
8812         * symfile.c (allocate_symtab): Update.
8813         * stabsread.c: Don't include bcache.h.
8814         * psymtab.h (struct psymbol_bcache): Don't declare.
8815         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8816         (psymbol_bcache_init, psymbol_bcache_free)
8817         (psymbol_bcache_get_bcache): Don't declare.
8818         * psymtab.c (struct psymbol_bcache): Remove.
8819         (psymtab_storage::psymtab_storage): Update.
8820         (psymtab_storage::~psymtab_storage): Update.
8821         (psymbol_bcache_init, psymbol_bcache_free)
8822         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8823         (add_psymbol_to_bcache): Update.
8824         (allocate_psymtab): Update.
8825         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8826         macro_cache>: No longer pointers.
8827         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8828         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8829         * macrotab.c (macro_bcache): Update.
8830         * macroexp.c: Don't include bcache.h.
8831         * gdbtypes.c (check_types_worklist): Update.
8832         (types_deeply_equal): Remove TRY/CATCH.  Update.
8833         * elfread.c (elf_symtab_read): Update.
8834         * dwarf2read.c: Don't include bcache.h.
8835         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8836         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8837         (print_bcache_statistics, bcache_memory_used): Don't declare.
8838         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8839         methods.  Rename all data members.
8840         * bcache.c (struct bcache): Move to bcache.h.
8841         (bcache::expand_hash_table): Rename from expand_hash_table.
8842         (bcache): Remove.
8843         (bcache::insert): Rename from bcache_full.
8844         (bcache::compare): Rename from bcache_compare.
8845         (bcache_xmalloc): Remove.
8846         (bcache::~bcache): Rename from bcache_xfree.
8847         (bcache::print_statistics): Rename from print_bcache_statistics.
8848         (bcache::memory_used): Rename from bcache_memory_used.
8849
8850 2019-03-07  Pedro Alves  <palves@redhat.com>
8851
8852         * infrun.c (normal_stop): Also check for
8853         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8854
8855 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8856
8857         * f-lang.c (value_from_host_double): Moved to...
8858         * value.c (value_from_host_double): ...here.
8859         * value.h (value_from_host_double): Declare.
8860         * guile/scm-math.c (vlscm_convert_typed_number): Use
8861         value_from_host_double.
8862         (vlscm_convert_number): Likewise.
8863         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8864         * python/py-value.c (convert_value_from_python): Likewise.
8865
8866 2019-03-06  Tom Tromey  <tom@tromey.com>
8867
8868         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8869
8870 2019-03-06  Tom Tromey  <tom@tromey.com>
8871
8872         * utils.h (free_current_contents): Don't declare.
8873         * utils.c (free_current_contents): Remove.
8874
8875 2019-03-06  Tom Tromey  <tom@tromey.com>
8876
8877         * top.c (quit_force): Update.
8878         * main.c (captured_command_loop): Update.
8879         * common/new-op.c (operator new): Update.
8880         * common/common-exceptions.c (struct catcher)
8881         <save_cleanup_chain>: Remove member.
8882         (exceptions_state_mc_init): Update.
8883         (exception_try_scope_entry): Return nullptr.
8884         (exception_try_scope_exit, exception_rethrow)
8885         (throw_exception_sjlj, throw_exception_cxx): Update.
8886         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8887         (all_cleanups, do_cleanups, discard_cleanups)
8888         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8889         (restore_cleanups, restore_final_cleanups): Don't declare.
8890         (do_final_cleanups): Remove parameter.
8891         * common/cleanups.c (cleanup_chain, make_cleanup)
8892         (make_cleanup_dtor, all_cleanups, do_cleanups)
8893         (discard_my_cleanups, discard_cleanups)
8894         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8895         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8896         (null_cleanup): Remove.
8897         (do_final_cleanups): Remove parameter.
8898
8899 2019-03-06  Tom Tromey  <tom@tromey.com>
8900
8901         * remote.c (remote_target::remote_parse_stop_reply): Use
8902         unique_xmalloc_ptr.
8903
8904 2019-03-06  Tom Tromey  <tom@tromey.com>
8905
8906         * stabsread.c (struct stabs_field_info): Rename from field_info.
8907         <list, fnlist>: Add initializers.
8908         <obstack>: New member.
8909         (read_member_functions, read_struct_fields, read_baseclasses):
8910         Allocate on obstack.  Don't use cleanups.
8911         (read_one_struct_field, read_member_functions, read_struct_fields)
8912         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8913         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8914         (read_struct_type): Update.
8915
8916 2019-03-06  Tom Tromey  <tom@tromey.com>
8917
8918         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8919         * common/filestuff.h (make_cleanup_close): Don't declare.
8920         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8921         Remove.
8922
8923 2019-03-06  Tom Tromey  <tom@tromey.com>
8924
8925         * solib-aix.c: Use make_scope_exit.
8926
8927 2019-03-06  Tom Tromey  <tom@tromey.com>
8928
8929         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8930         Use make_scope_exit.
8931
8932 2019-03-06  Tom Tromey  <tom@tromey.com>
8933
8934         * solib-svr4.c (disable_probes_interface): Remove parameter.
8935         (svr4_handle_solib_event): Use make_scope_exit.
8936
8937 2019-03-06  Tom Tromey  <tom@tromey.com>
8938
8939         * remote.c (struct stop_reply_deleter): Remove.
8940         (stop_reply_up): Update.
8941         (struct stop_reply): Derive from notif_event.  Don't typedef.
8942         <regcache>: Now a std::vector.
8943         (stop_reply_xfree): Remove.
8944         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8945         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8946         (remote_target::discard_pending_stop_replies): Use delete.
8947         (remote_target::remote_parse_stop_reply): Update.
8948         (remote_target::process_stop_reply): Update.
8949         * remote-notif.h (struct notif_event): Add virtual destructor.
8950         Remove "dtr" member.
8951         (struct notif_client) <alloc_event>: Return a unique_ptr.
8952         (notif_event_xfree): Don't declare.
8953         (notif_event_up): New typedef.
8954         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8955         (notif_event_xfree, do_notif_event_xfree): Remove.
8956         (remote_notif_state_xfree): Update.
8957
8958 2019-03-06  Tom Tromey  <tom@tromey.com>
8959
8960         * infrun.c (displaced_step_clear_cleanup): Now a
8961         forward_scope_exit type.
8962         (displaced_step_prepare_throw): Update.
8963         (displaced_step_fixup): Update.
8964
8965 2019-03-06  Tom Tromey  <tom@tromey.com>
8966
8967         * inferior.h (class inferior): Update comment.
8968         * gdbthread.h (class thread_info): Update comment.
8969
8970 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8971             Tom Tromey  <tom@tromey.com>
8972
8973         * stabsread.h (struct stab_section_list): Remove.
8974         (coffstab_build_psymtabs): Update.
8975         * dbxread.c (symbuf_sections): Now a std::vector.
8976         (sect_idx): New global.
8977         (fill_symbuf): Update.
8978         (coffstab_build_psymtabs): Change type of stabsects parameter.
8979         Update.
8980         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8981         std::vector.
8982         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8983         (coff_locate_sections): Update.
8984         (coff_symfile_read): Remove cleanups.  Update.
8985         (init_stringtab): Add storage parameter.
8986         (free_stringtab, free_stringtab_cleanup): Remove.
8987         (init_lineno): Add storage parameter.
8988         (free_linetab, free_linetab_cleanup): Remove.
8989
8990 2019-03-06  Pedro Alves  <palves@redhat.com>
8991
8992         * linux-fork.c (fork_info::clobber_regs): Delete.
8993         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8994         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8995         comment.  Adjust.
8996         (scoped_switch_fork_info::scoped_switch_fork_info)
8997         (checkpoint_command, linux_fork_context): Adjust
8998         fork_save_infrun_state calls.
8999
9000 2019-03-06  Pedro Alves  <palves@redhat.com>
9001
9002         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9003         (inf_has_multiple_threads): Return 'bool' and rewrite using
9004         inferior_info::threads().
9005
9006 2019-03-06  Pedro Alves  <palves@redhat.com>
9007
9008         * linux-fork.c: Include <list>.
9009         (fork_list): Now a std::list instance.
9010         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9011         (forks_exist_p, find_last_fork): Adjust.
9012         (new_fork): Delete.
9013         (one_fork_p): New.
9014         (add_fork): Adjust.
9015         (free_fork): Delete, folded into fork_info::~fork_info().
9016         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9017         Adjust.
9018         (init_fork_list): Delete.
9019         (linux_fork_killall, linux_fork_mourn_inferior)
9020         (linux_fork_detach, info_checkpoints_command): Adjust.
9021         (_initialize_linux_fork): No longer call init_fork_list.
9022
9023 2019-03-06  Pedro Alves  <palves@redhat.com>
9024
9025         * linux-fork.c (new_fork): New, split out of ...
9026         (add_fork): ... this.  Return void.  Move "first fork" special
9027         case from here, to ...
9028         (checkpoint_command): ... here.
9029         * linux-linux.h (add_fork): Return void.
9030
9031 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9032
9033         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9034
9035 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9036             Chris January  <chris.january@arm.com>
9037             David Lecomber  <david.lecomber@arm.com>
9038
9039         * f-exp.y: New token, UNOP_INTRINSIC.
9040         (exp): New pattern using UNOP_INTRINSIC token.
9041         (f77_keywords): Add 'abs' keyword.
9042         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9043         (value_from_host_double): New function.
9044         (evaluate_subexp_f): Support UNOP_ABS.
9045
9046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9047
9048         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9049         types.
9050
9051 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9052
9053         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9054         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9055         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9056
9057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9058
9059         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9060
9061 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9062             Chris January  <chris.january@arm.com>
9063
9064         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9065         * f-exp.y: Define 'KIND' token.
9066         (exp): New pattern for KIND expressions.
9067         (ptype): Handle types with a kind extension.
9068         (direct_abs_decl): Extend to spot kind extensions.
9069         (f77_keywords): Add 'kind' to the list.
9070         (push_kind_type): New function.
9071         (convert_to_kind_type): New function.
9072         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9073         * parse.c (operator_length_standard): Likewise.
9074         * parser-defs.h (enum type_pieces): Add tp_kind.
9075         * std-operator.def: Add UNOP_KIND.
9076
9077 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9078
9079         * f-exp.y (f_parse): Set yydebug.
9080
9081 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * f-lang.c (evaluate_subexp_f): New function.
9084         (exp_descriptor_f): New global.
9085         (f_language_defn): Use exp_descriptor_f instead of
9086         exp_descriptor_standard.
9087
9088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9089
9090         * f-exp.y (struct token): Add comments.
9091         (dot_ops): Remove uppercase versions and the end marker.
9092         (f77_keywords): Likewise.
9093         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9094         entries in the dot_ops array are case insensitive, and use
9095         strncasecmp to compare strings.  Also some whitespace cleanup in
9096         this area.  Similar for the f77_keywords array, except entries in
9097         this list might be case sensitive.
9098
9099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9100
9101         * f-exp.y (struct f77_boolean_val): Add comments.
9102         (boolean_values): Remove uppercase versions, and end marker.
9103         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9104         and use strncasecmp to achieve case insensitivity.  Additionally,
9105         perform whitespace cleanup around this code.
9106
9107 2019-03-06  Tom Tromey  <tromey@adacore.com>
9108
9109         * remote-sim.c (gdbsim_target_open): Use result of
9110         gdb_argv::release.
9111
9112 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9113         Dirk Schubert  <dirk.schubert@arm.com>
9114         Chris January  <chris.january@arm.com>
9115
9116         * eval.c (evaluate_subexp_standard): Call Fortran argument
9117         wrapping logic.
9118         * f-lang.c (struct value): A value which can be passed into a
9119         Fortran function call.
9120         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9121         where appropriate.
9122         (struct type): Value ready for a Fortran function call.
9123         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9124         is needed.
9125         * f-lang.h (fortran_argument_convert): Declaration.
9126         (fortran_preserve_arg_pointer): Declaration.
9127         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9128
9129 2019-03-05  Tom Tromey  <tromey@adacore.com>
9130
9131         * python/py-prettyprint.c (print_string_repr): Remove #if.
9132         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9133
9134 2019-03-05  Tom Tromey  <tromey@adacore.com>
9135
9136         * target.c (the_dummy_target): Move later.  Change type to
9137         "dummy_target".
9138         (initialize_targets): Don't initialize the_dummy_target.
9139
9140 2019-03-05  Tom Tromey  <tromey@adacore.com>
9141
9142         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9143         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9144
9145 2019-03-05  Tom Tromey  <tromey@adacore.com>
9146
9147         * windows-nat.c (windows_nat_target::attach)
9148         (windows_nat_target::detach): Don't call gdb_flush.
9149         * valprint.c (generic_val_print, val_print, val_print_string):
9150         Don't call gdb_flush.
9151         * utils.c (defaulted_query): Don't call gdb_flush.
9152         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9153         * target.c (target_announce_detach): Don't call gdb_flush.
9154         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9155         * remote.c (extended_remote_target::attach): Don't call
9156         gdb_flush.
9157         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9158         * printcmd.c (do_examine): Don't call gdb_flush.
9159         (info_display_command): Don't call gdb_flush.
9160         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9161         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9162         * memattr.c (info_mem_command): Don't call gdb_flush.
9163         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9164         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9165         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9166         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9167         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9168         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9169         (gnu_nat_target::detach): Don't call gdb_flush.
9170         * f-valprint.c (f_val_print): Don't call gdb_flush.
9171         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9172         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9173         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9174         gdb_flush.
9175         * c-valprint.c (c_val_print): Don't call gdb_flush.
9176         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9177
9178 2019-03-05  Tom Tromey  <tromey@adacore.com>
9179
9180         * varobj.c (update_dynamic_varobj_children): Update.
9181         (install_default_visualizer): Use reset, not release.
9182         * value.c (set_internalvar): Update.
9183         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9184         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9185         ATTRIBUTE_UNUSED_RESULT.
9186
9187 2019-03-05  Tom Tromey  <tromey@adacore.com>
9188
9189         * remote.c (class scoped_remote_fd) <release>: Add
9190         ATTRIBUTE_UNUSED_RESULT.
9191
9192 2019-03-05  Tom Tromey  <tromey@adacore.com>
9193
9194         * macroexp.c (struct macro_buffer) <release>: Add
9195         ATTRIBUTE_UNUSED_RESULT.
9196
9197 2019-03-05  Tom Tromey  <tromey@adacore.com>
9198
9199         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9200         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9201         ATTRIBUTE_UNUSED_RESULT.
9202
9203 2019-03-05  Tom Tromey  <tromey@adacore.com>
9204
9205         * common/scoped_fd.h (class scoped_fd) <release>: Add
9206         ATTRIBUTE_UNUSED_RESULT.
9207
9208 2019-03-05  Tom Tromey  <tromey@adacore.com>
9209
9210         * parser-defs.h (struct parser_state) <release>: Add
9211         ATTRIBUTE_UNUSED_RESULT.
9212
9213 2019-03-05  Tom Tromey  <tromey@adacore.com>
9214
9215         * utils.h (class gdb_argv) <release>: Add
9216         ATTRIBUTE_UNUSED_RESULT.
9217         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9218
9219 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9220
9221         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9222         for-loop range, to avoid compiler warnings.
9223
9224         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9225         avoid compiler warnings about unused variables.
9226
9227         * NEWS: Mention end of support for native debugging on MS-Windows
9228         before XP.
9229
9230         PR gdb/24292
9231         * common/netstuff.c:
9232         * gdbserver/gdbreplay.c
9233         * gdbserver/remote-utils.c:
9234         * ser-tcp.c:
9235         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9236         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9237         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9238         'getaddrinfo' and 'freeaddrinfo' were not available before
9239         Windows XP, and mingw.org's MinGW headers by default define
9240         _WIN32_WINNT to 0x500.
9241
9242 2019-03-01  Gary Benson <gbenson@redhat.com>
9243
9244         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9245
9246 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9247             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9248
9249         PR gdb/8527
9250         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9251         set_sigint_trap, clear_sigint_trap.
9252
9253 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9254
9255         * target.c (target_detach): Clear the regcache and the
9256         frame cache.
9257
9258 2019-02-27  Pedro Alves  <palves@redhat.com>
9259
9260         * utils.c (set_screen_size): When we cap the height/width sizes,
9261         tweak the corresponding command variable to show "unlimited":
9262
9263 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9264             Pedro Alves  <palves@redhat.com>
9265
9266         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9267         before calling rl_set_screen_size.
9268
9269 2019-02-27  Tom Tromey  <tromey@adacore.com>
9270
9271         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9272         define.
9273         * python/py-value.c: Remove Python 2.4 workaround.
9274         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9275         workaround.
9276         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9277         Python 2.4 workaround.
9278         * python/python-internal.h: Remove Python 2.4 comment.
9279         (Py_ssize_t): Don't define.
9280         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9281         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9282         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9283         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9284         * python/python.c (do_start_initialization): Remove Python 2.4
9285         workaround.
9286         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9287         (print_children): Remove Python 2.4 workaround.
9288         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9289         workaround.
9290         (CHARBUFFERPROC_NAME): Remove.
9291         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9292         Python 2.4 workaround.
9293
9294 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9295
9296         * NEWS: Note minimum Python version.
9297
9298 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9299
9300         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9301         code from these functions.  Remove corresponding ifdefs.  Use
9302         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9303         Remove gotos and target of gotos.
9304         (infpy_search_memory): Likewise.
9305
9306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9309         (hppa_gdbarch_init): Don't register deleted functions with
9310         gdbarch.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9315         (h8300_unwind_sp): Delete.
9316         (h8300_dummy_id): Delete.
9317         (h8300_gdbarch_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9323         (ft32_unwind_pc): Delete.
9324         (ft32_unwind_sp): Delete.
9325         (ft32_gdbarch_init): Don't register deleted functions with
9326         gdbarch.
9327
9328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9331         (frv_unwind_pc): Delete.
9332         (frv_unwind_sp): Delete.
9333         (frv_gdbarch_init): Don't register deleted functions with
9334         gdbarch.
9335
9336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9337
9338         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9339         (riscv_unwind_pc): Delete.
9340         (riscv_unwind_sp): Delete.
9341         (riscv_gdbarch_init): Don't register deleted functions with
9342         gdbarch.
9343
9344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9347         (csky_unwind_pc): Delete.
9348         (csky_unwind_sp): Delete.
9349         (csky_gdbarch_init): Don't register deleted functions with
9350         gdbarch.
9351
9352 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9353
9354         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9355         (cris_unwind_pc): Delete.
9356         (cris_unwind_sp): Delete.
9357         (cris_gdbarch_init): Don't register deleted functions with
9358         gdbarch.
9359
9360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9361
9362         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9363         (bfin_unwind_pc): Delete.
9364         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9365
9366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9367
9368         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9369         (arm_unwind_pc): Delete.
9370         (arm_unwind_sp): Delete.
9371         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9372
9373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9374
9375         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9376         (arc_unwind_pc): Delete.
9377         (arc_unwind_sp): Delete.
9378         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9379
9380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9383         (alpha_unwind_pc): Delete.
9384         (alpha_gdbarch_init): Don't register deleted functions with
9385         gdbarch.
9386
9387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9388
9389         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9390         (aarch64_unwind_pc): Delete.
9391         (aarch64_unwind_sp): Delete.
9392         (aarch64_gdbarch_init): Don't register deleted functions with
9393         gdbarch.
9394
9395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9396
9397         * gdbtypes.c (type_align): Don't consider static members when
9398         computing structure alignment.
9399
9400 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9403         return 0 for other types.
9404         * arch-utils.c (default_type_align): Always return 0.
9405         * gdbarch.h: Regenerate.
9406         * gdbarch.sh (type_align): Extend comment.
9407         * gdbtypes.c (type_align): Add additional comments, always call
9408         gdbarch_type_align before applying the default rules.
9409         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9410         generic code will then apply a suitable default.
9411         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9412         types, return 0 for other types.
9413
9414 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9415
9416         * NEWS: Create a new section for the next release branch.
9417         Rename the section of the current branch, now that it has
9418         been cut.
9419
9420 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9421
9422         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9423         * version.in: Bump version to 8.3.50.DATE-git.
9424
9425 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9426
9427         * aix-thread.c (ptid_cmp): Remove unused variable.
9428         (get_signaled_thread): Likewise.
9429         (store_regs_user_thread): Likewise.
9430         (store_regs_kernel_thread): Likewise.
9431         (fetch_regs_kernel_thread): Remove shadowed variable.
9432
9433 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9434
9435         * features/riscv/32bit-cpu.xml: Add register numbers.
9436         * features/riscv/32bit-fpu.c: Regenerate.
9437         * features/riscv/32bit-fpu.xml: Add register numbers.
9438         * features/riscv/64bit-cpu.xml: Add register numbers.
9439         * features/riscv/64bit-fpu.c: Regenerate.
9440         * features/riscv/64bit-fpu.xml: Add register numbers.
9441
9442 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9443
9444         * NEWS: Mention two argument form of gdb.Value constructor.
9445         * python/py-value.c (convert_buffer_and_type_to_value): New
9446         function.
9447         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9448         Add support for handling an optional second argument.  Call
9449         convert_buffer_and_type_to_value as appropriate.
9450         * python/python-internal.h (Py_buffer_deleter): New struct.
9451         (Py_buffer_up): New typedef.
9452
9453 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9454
9455         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9456         instead of releasing ownership.
9457
9458 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9459
9460         * dwarf2read.c (open_and_init_dwp_file): Call
9461         elf_numsections instead of bfd_count_sections to initialize
9462         dwp_file->num_sections.
9463
9464 2019-02-25  Tom Tromey  <tromey@adacore.com>
9465
9466         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9467
9468 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9469
9470         * gcore.in: Add '--readnever' option when invoking GDB.
9471
9472 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9473
9474         * MAINTAINERS: Update my email address.
9475
9476 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9477
9478         * build-id.c (build_id_to_debug_bfd_1): New function.
9479         (build_id_to_debug_bfd): Look for separate debug file in
9480         sysroot.
9481
9482 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9483
9484         * gdbarch.sh: Update the copyright year range that is placed into
9485         generated files.
9486
9487 2019-02-22  Keith Seitz  <keiths@redhat.com>
9488
9489         PR symtab/23853
9490         * linespec.c (create_sals_line_offset): Search for the default
9491         symtab's filename instead of its fullname.
9492
9493 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9494
9495         * NEWS: Update style defaults.
9496
9497 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9498
9499         * main.c (captured_main_1): Disable styling in batch mode.
9500
9501 2019-02-20  Tom Tromey  <tom@tromey.com>
9502
9503         * symtab.c (symtab_symbol_info): Fix typos.
9504
9505 2019-02-20  Tom Tromey  <tromey@adacore.com>
9506
9507         * findcmd.c (_initialize_mem_search): Use upper case for
9508         metasyntactic variables.
9509
9510 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9511
9512         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9513         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9514
9515 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9516
9517         * top.h (source_file_name): Change to std::string.
9518         * top.c (source_file_name): Likewise.
9519         (command_line_input): Adjust.
9520         * cli/cli-script.c (script_from_file): Adjust.
9521
9522 2019-02-19  Tom Tromey  <tromey@adacore.com>
9523
9524         * ravenscar-thread.c
9525         (ravenscar_thread_target::update_thread_list): Don't call
9526         ada_build_task_list.
9527         * ada-lang.h (ada_build_task_list): Don't declare.
9528         * ada-tasks.c (struct ada_tasks_inferior_data)
9529         <task_list_valid_p>: Now bool.
9530         (read_known_tasks, ada_task_list_changed)
9531         (ada_tasks_invalidate_inferior_data): Update.
9532         (read_known_tasks_array): Return bool.
9533         (read_known_tasks_list): Likewise.
9534         (read_known_tasks): Return void.
9535         (ada_build_task_list): Now static.
9536
9537 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9538
9539         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9540         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9541
9542 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9543
9544         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9545         variant for ada_tasks_pspace_data_handle and
9546         ada_tasks_inferior_data_handle.
9547         (ada_tasks_pspace_data_cleanup): New function.
9548         (ada_tasks_inferior_data_cleanup): New function.
9549
9550 2019-02-17  Tom Tromey  <tom@tromey.com>
9551
9552         * macrotab.h (macro_source_fullname): Return a std::string.
9553         * macrotab.c (macro_include, check_for_redefinition)
9554         (macro_undef, macro_lookup_definition, foreach_macro)
9555         (foreach_macro_in_scope): Update.
9556         (macro_source_fullname): Return a std::string.
9557         * macrocmd.c (show_pp_source_pos): Update.
9558
9559 2019-02-17  Tom Tromey  <tom@tromey.com>
9560
9561         * macrocmd.c (show_pp_source_pos): Style the file names.
9562
9563 2019-02-17  Tom Tromey  <tom@tromey.com>
9564
9565         PR tui/24197:
9566         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9567
9568 2019-02-17  Tom Tromey  <tom@tromey.com>
9569
9570         * ada-lang.c (user_select_syms): Use filtered printing.
9571         * utils.c (wrap_style): New global.
9572         (desired_style): Remove.
9573         (emit_style_escape): Add stream parameter.
9574         (set_output_style, reset_terminal_style, prompt_for_continue):
9575         Update.
9576         (flush_wrap_buffer): Only flush gdb_stdout.
9577         (wrap_here): Set wrap_style.
9578         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9579         treat escape sequences as a character.  Change when wrap buffer is
9580         flushed.
9581         (fputs_styled): Do not set the output style when the default is
9582         requested.
9583         * ui-style.h (struct ui_file_style) <is_default>: New method.
9584         * source.c (print_source_lines_base): Emit escape sequences in one
9585         piece.
9586
9587 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9588
9589         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9590         integers and enumeration types.
9591
9592 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9593
9594         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9595         instead of lookup_symbol_in_language
9596         (do_exact_match): New function.
9597         (ada_get_symbol_name_matcher): Return do_exact_match when
9598         doing a verbatim match.
9599
9600 2019-02-15  Tom Tromey  <tromey@adacore.com>
9601
9602         * ravenscar-thread.c (ravenscar_thread_target::resume)
9603         (ravenscar_thread_target::wait): Special case wildcard requests.
9604
9605 2019-02-15  Tom Tromey  <tromey@adacore.com>
9606
9607         * ravenscar-thread.c (base_ptid): Remove.
9608         (struct ravenscar_thread_target) <close>: New method.
9609         <m_base_ptid>: New member.
9610         <update_inferior_ptid, active_task, task_is_currently_active,
9611         runtime_initialized>: Declare methods.
9612         <ravenscar_thread_target>: Add constructor.
9613         (ravenscar_thread_target::task_is_currently_active)
9614         (ravenscar_thread_target::update_inferior_ptid)
9615         (ravenscar_runtime_initialized): Rename.  Now methods.
9616         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9617         (ravenscar_thread_target::update_thread_list): Update.
9618         (ravenscar_thread_target::active_task): Now method.
9619         (ravenscar_thread_target::store_registers)
9620         (ravenscar_thread_target::prepare_to_store)
9621         (ravenscar_thread_target::prepare_to_store)
9622         (ravenscar_thread_target::mourn_inferior): Update.
9623         (ravenscar_inferior_created): Use "new" to create target.
9624         (ravenscar_thread_target::get_ada_task_ptid): Update.
9625         (_initialize_ravenscar): Don't initialize base_ptid.
9626         (ravenscar_ops): Remove global.
9627
9628 2019-02-15  Tom Tromey  <tromey@adacore.com>
9629
9630         * target.h (push_target): Declare new overload.
9631         * target.c (push_target): New overload, taking an rvalue reference.
9632         * remote.c (remote_target::open_1): Use push_target overload.
9633         * corelow.c (core_target_open): Use push_target overload.
9634
9635 2019-02-15  Tom Tromey  <tromey@adacore.com>
9636
9637         * ravenscar-thread.c (is_ravenscar_task)
9638         (ravenscar_task_is_currently_active): Return bool.
9639         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9640         (_initialize_ravenscar): Remove "(void)".
9641         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9642         Return bool.
9643
9644 2019-02-15  Tom Tromey  <tromey@adacore.com>
9645
9646         * ravenscar-thread.c (ravenscar_runtime_initializer)
9647         (has_ravenscar_runtime, get_running_thread_id)
9648         (ravenscar_thread_target::resume): Fix indentation.
9649
9650 2019-02-15  Tom Tromey  <tromey@adacore.com>
9651
9652         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9653         from ravenscar_arch_ops.
9654         (sparc_ravenscar_ops::fetch_registers)
9655         (sparc_ravenscar_ops::store_registers): Now methods.
9656         (sparc_ravenscar_prepare_to_store): Remove.
9657         (sparc_ravenscar_ops): Redefine.
9658         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9659         methods and destructor.  Remove members.
9660         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9661         (ravenscar_thread_target::store_registers)
9662         (ravenscar_thread_target::prepare_to_store): Update.
9663         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9664         Remove.
9665         (struct ppc_ravenscar_powerpc_ops): Derive from
9666         ravenscar_arch_ops.
9667         (ppc_ravenscar_powerpc_ops::fetch_registers)
9668         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9669         (ppc_ravenscar_powerpc_ops): Redefine.
9670         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9671         (ppc_ravenscar_e500_ops::fetch_registers)
9672         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9673         (ppc_ravenscar_e500_ops): Redefine.
9674         * aarch64-ravenscar-thread.c
9675         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9676         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9677         (aarch64_ravenscar_fetch_registers)
9678         (aarch64_ravenscar_store_registers): Now methods.
9679         (aarch64_ravenscar_ops): Redefine.
9680
9681 2019-02-15  Tom Tromey  <tromey@adacore.com>
9682
9683         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9684         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9685         (ravenscar_thread_target::stopped_by_watchpoint)
9686         (ravenscar_thread_target::stopped_data_address)
9687         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9688
9689 2019-02-15  Tom Tromey  <tromey@adacore.com>
9690
9691         * ravenscar-thread.c: Fix some typos.
9692
9693 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9694             Tom Tromey  <tromey@adacore.com>
9695
9696         * ada-lang.c (ada_exception_sal): Change addr_string to a
9697         std::string.
9698         (create_ada_exception_catchpoint): Update.
9699
9700 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9701             Tom Tromey  <tromey@adacore.com>
9702
9703         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9704         (bp_location_ops): Remove.
9705         (base_breakpoint_allocate_location): Update.
9706         (free_bp_location): Update.
9707         * ada-lang.c (class ada_catchpoint_location)
9708         <ada_catchpoint_location>: Remove ops parameter.
9709         (ada_catchpoint_location_dtor): Remove.
9710         (ada_catchpoint_location_ops): Remove.
9711         (allocate_location_exception): Update.
9712         * breakpoint.h (struct bp_location_ops): Remove.
9713         (class bp_location) <bp_location>: Remove bp_location_ops
9714         parameter.
9715         <~bp_location>: Add destructor.
9716         <ops>: Remove.
9717
9718 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9719             Pedro Alves  <palves@redhat.com>
9720
9721         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9722         'PATH_MAX'.
9723
9724 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9725             Samuel Thibault  <samuel.thibault@gnu.org>
9726             Thomas Schwinge  <thomas@codesourcery.com>
9727
9728         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9729         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9730
9731 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9732
9733         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9734         (check_empty): Use "const char *".
9735
9736         * gnu-nat.c (gnu_nat_target::detach): Instead of
9737         'detach_inferior (pid)' call
9738         'detach_inferior (find_inferior_pid (pid))'.
9739
9740         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9741         'nat/fork-inferior.o'.
9742         * gnu-nat.c: #include "nat/fork-inferior.h".
9743
9744         * gnu-nat.c (gnu_nat_target::detach): Instead of
9745         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9746         * gnu-nat.h: #include "inf-child.h".
9747         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9748         'i386_gnu_nat_target::fetch_registers'.
9749         (gnu_store_registers): Rename/move to
9750         'i386_gnu_nat_target::store_registers'.
9751
9752         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9753         * gnu-nat.h (mach_thread_info): New function.
9754         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9755
9756         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9757
9758 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9759
9760         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9761
9762 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9763
9764         * windows-nat.c (windows_add_thread): Add new parameter
9765         "main_thread_p" with default value set to false.  Update
9766         function documentation as well as all callers.
9767         (windows_delete_thread): Likewise.
9768         (fake_create_process): Update call to windows_add_thread.
9769         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9770         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9771         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9772         call to windows_delete_thread.
9773
9774 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9775
9776         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9777
9778 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9779
9780         * symfile.c (find_separate_debug_file): Use canonical path of
9781         sysroot with child_path instead of gdb_sysroot if it is valid.
9782
9783 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9784
9785         * symfile.c (find_separate_debug_file): Use child_path to
9786         determine if an object file is under a sysroot.
9787
9788 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9789
9790         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9791         unittests/child-path-selftests.c.
9792         * common/pathstuff.c (child_path): New function.
9793         * common/pathstuff.h (child_path): New prototype.
9794         * unittests/child-path-selftests.c: New file.
9795
9796 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9797
9798         * symfile.c (find_separate_debug_file): Look for separate debug
9799         files in debug directories under the sysroot.
9800
9801 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9802
9803         * symtab.h (struct minimal_symbol data_p): New const method.
9804         (struct minimal_symbol text_p): Likewise.
9805         * symtab.c (output_source_filename): Use file name style
9806         to print file name.
9807         (print_symbol_info): Likewise.
9808         (print_msymbol_info): Use address style to print addresses.
9809         Use function name style to print executable text symbols.
9810         (expand_symtab_containing_pc): Use data_p.
9811         (find_pc_sect_compunit_symtab): Likewise.
9812
9813 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9814
9815         * breakpoint.c (describe_other_breakpoints): Use address style
9816         to print addresses.
9817         (say_where): Likewise.
9818
9819 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9820
9821         * ada-typeprint.c (print_func_type): Print function name
9822         style to print function name.
9823         * c-typeprint.c (c_print_type_1): Likewise.
9824
9825 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9826
9827         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9828         for execve.
9829
9830 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9831
9832         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9833         type_stack.
9834
9835 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9836
9837         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9838         TYPE_CODE_REF types.
9839
9840 2019-02-08  Jim Wilson  <jimw@sifive.com>
9841
9842         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9843         (riscv_linux_fregset): New.
9844         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9845
9846 2019-02-07  Tom Tromey  <tom@tromey.com>
9847
9848         * thread.c (thread_cancel_execution_command): Update.
9849         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9850         methods.
9851         (struct thread_fsm_ops): Remove.
9852         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9853         (thread_fsm_should_stop, thread_fsm_return_value)
9854         (thread_fsm_set_finished, thread_fsm_finished_p)
9855         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9856         Don't declare.
9857         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9858         * infrun.c (clear_proceed_status_thread)
9859         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9860         (print_stop_event): Update.
9861         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9862         Add constructor.
9863         (step_command_fsm_ops): Remove.
9864         (new_step_command_fsm): Remove.
9865         (step_1): Update.
9866         (step_command_fsm::should_stop): Rename from
9867         step_command_fsm_should_stop.
9868         (step_command_fsm::clean_up): Rename from
9869         step_command_fsm_clean_up.
9870         (step_command_fsm::do_async_reply_reason): Rename from
9871         step_command_fsm_async_reply_reason.
9872         (struct until_next_fsm): Inherit from thread_fsm.  Add
9873         constructor.
9874         (until_next_fsm_ops): Remove.
9875         (new_until_next_fsm): Remove.
9876         (until_next_fsm::should_stop): Rename from
9877         until_next_fsm_should_stop.
9878         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9879         (until_next_fsm::do_async_reply_reason): Rename from
9880         until_next_fsm_async_reply_reason.
9881         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9882         constructor.  Change type of breakpoint.
9883         (finish_command_fsm_ops): Remove.
9884         (new_finish_command_fsm): Remove.
9885         (finish_command_fsm::should_stop): Rename from
9886         finish_command_fsm_should_stop.
9887         (finish_command_fsm::clean_up): Rename from
9888         finish_command_fsm_clean_up.
9889         (finish_command_fsm::return_value): Rename from
9890         finish_command_fsm_return_value.
9891         (finish_command_fsm::do_async_reply_reason): Rename from
9892         finish_command_fsm_async_reply_reason.
9893         (finish_command): Update.
9894         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9895         Add constructor.
9896         (call_thread_fsm_ops): Remove.
9897         (call_thread_fsm::call_thread_fsm): Rename from
9898         new_call_thread_fsm.
9899         (call_thread_fsm::should_stop): Rename from
9900         call_thread_fsm_should_stop.
9901         (call_thread_fsm::should_notify_stop): Rename from
9902         call_thread_fsm_should_notify_stop.
9903         (run_inferior_call, call_function_by_hand_dummy): Update.
9904         * cli/cli-interp.c (should_print_stop_to_console): Update.
9905         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9906         Add constructor.  Change type of location_breakpoint,
9907         caller_breakpoint.
9908         (until_break_fsm_ops): Remove.
9909         (new_until_break_fsm): Remove.
9910         (until_break_fsm::should_stop): Rename from
9911         until_break_fsm_should_stop.
9912         (until_break_fsm::clean_up): Rename from
9913         until_break_fsm_clean_up.
9914         (until_break_fsm::do_async_reply_reason): Rename from
9915         until_break_fsm_async_reply_reason.
9916         (until_break_command): Update.
9917         * thread-fsm.c: Remove.
9918         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9919
9920 2019-02-07  Tom Tromey  <tom@tromey.com>
9921
9922         * yy-remap.h: Add include guard.
9923         * xtensa-tdep.h: Add include guard.
9924         * xcoffread.h: Rename include guard.
9925         * varobj-iter.h: Add include guard.
9926         * tui/tui.h: Rename include guard.
9927         * tui/tui-winsource.h: Rename include guard.
9928         * tui/tui-wingeneral.h: Rename include guard.
9929         * tui/tui-windata.h: Rename include guard.
9930         * tui/tui-win.h: Rename include guard.
9931         * tui/tui-stack.h: Rename include guard.
9932         * tui/tui-source.h: Rename include guard.
9933         * tui/tui-regs.h: Rename include guard.
9934         * tui/tui-out.h: Rename include guard.
9935         * tui/tui-layout.h: Rename include guard.
9936         * tui/tui-io.h: Rename include guard.
9937         * tui/tui-hooks.h: Rename include guard.
9938         * tui/tui-file.h: Rename include guard.
9939         * tui/tui-disasm.h: Rename include guard.
9940         * tui/tui-data.h: Rename include guard.
9941         * tui/tui-command.h: Rename include guard.
9942         * tic6x-tdep.h: Add include guard.
9943         * target/waitstatus.h: Rename include guard.
9944         * target/wait.h: Rename include guard.
9945         * target/target.h: Rename include guard.
9946         * target/resume.h: Rename include guard.
9947         * target-float.h: Rename include guard.
9948         * stabsread.h: Add include guard.
9949         * rs6000-tdep.h: Add include guard.
9950         * riscv-fbsd-tdep.h: Add include guard.
9951         * regformats/regdef.h: Rename include guard.
9952         * record.h: Rename include guard.
9953         * python/python.h: Rename include guard.
9954         * python/python-internal.h: Rename include guard.
9955         * python/py-stopevent.h: Rename include guard.
9956         * python/py-ref.h: Rename include guard.
9957         * python/py-record.h: Rename include guard.
9958         * python/py-record-full.h: Rename include guard.
9959         * python/py-record-btrace.h: Rename include guard.
9960         * python/py-instruction.h: Rename include guard.
9961         * python/py-events.h: Rename include guard.
9962         * python/py-event.h: Rename include guard.
9963         * procfs.h: Add include guard.
9964         * proc-utils.h: Add include guard.
9965         * p-lang.h: Add include guard.
9966         * or1k-tdep.h: Rename include guard.
9967         * observable.h: Rename include guard.
9968         * nto-tdep.h: Rename include guard.
9969         * nat/x86-linux.h: Rename include guard.
9970         * nat/x86-linux-dregs.h: Rename include guard.
9971         * nat/x86-gcc-cpuid.h: Add include guard.
9972         * nat/x86-dregs.h: Rename include guard.
9973         * nat/x86-cpuid.h: Rename include guard.
9974         * nat/ppc-linux.h: Rename include guard.
9975         * nat/mips-linux-watch.h: Rename include guard.
9976         * nat/linux-waitpid.h: Rename include guard.
9977         * nat/linux-ptrace.h: Rename include guard.
9978         * nat/linux-procfs.h: Rename include guard.
9979         * nat/linux-osdata.h: Rename include guard.
9980         * nat/linux-nat.h: Rename include guard.
9981         * nat/linux-namespaces.h: Rename include guard.
9982         * nat/linux-btrace.h: Rename include guard.
9983         * nat/glibc_thread_db.h: Rename include guard.
9984         * nat/gdb_thread_db.h: Rename include guard.
9985         * nat/gdb_ptrace.h: Rename include guard.
9986         * nat/fork-inferior.h: Rename include guard.
9987         * nat/amd64-linux-siginfo.h: Rename include guard.
9988         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9989         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9990         * nat/aarch64-linux.h: Rename include guard.
9991         * nat/aarch64-linux-hw-point.h: Rename include guard.
9992         * mn10300-tdep.h: Add include guard.
9993         * mips-linux-tdep.h: Add include guard.
9994         * mi/mi-parse.h: Rename include guard.
9995         * mi/mi-out.h: Rename include guard.
9996         * mi/mi-main.h: Rename include guard.
9997         * mi/mi-interp.h: Rename include guard.
9998         * mi/mi-getopt.h: Rename include guard.
9999         * mi/mi-console.h: Rename include guard.
10000         * mi/mi-common.h: Rename include guard.
10001         * mi/mi-cmds.h: Rename include guard.
10002         * mi/mi-cmd-break.h: Rename include guard.
10003         * m2-lang.h: Add include guard.
10004         * location.h: Rename include guard.
10005         * linux-record.h: Rename include guard.
10006         * linux-nat.h: Add include guard.
10007         * linux-fork.h: Add include guard.
10008         * i386-darwin-tdep.h: Rename include guard.
10009         * hppa-linux-offsets.h: Add include guard.
10010         * guile/guile.h: Rename include guard.
10011         * guile/guile-internal.h: Rename include guard.
10012         * gnu-nat.h: Rename include guard.
10013         * gdb-stabs.h: Rename include guard.
10014         * frv-tdep.h: Add include guard.
10015         * f-lang.h: Add include guard.
10016         * event-loop.h: Add include guard.
10017         * darwin-nat.h: Rename include guard.
10018         * cp-abi.h: Rename include guard.
10019         * config/sparc/nm-sol2.h: Rename include guard.
10020         * config/nm-nto.h: Rename include guard.
10021         * config/nm-linux.h: Add include guard.
10022         * config/i386/nm-i386gnu.h: Rename include guard.
10023         * config/djgpp/nl_types.h: Rename include guard.
10024         * config/djgpp/langinfo.h: Rename include guard.
10025         * compile/gcc-cp-plugin.h: Add include guard.
10026         * compile/gcc-c-plugin.h: Add include guard.
10027         * compile/compile.h: Rename include guard.
10028         * compile/compile-object-run.h: Rename include guard.
10029         * compile/compile-object-load.h: Rename include guard.
10030         * compile/compile-internal.h: Rename include guard.
10031         * compile/compile-cplus.h: Rename include guard.
10032         * compile/compile-c.h: Rename include guard.
10033         * common/xml-utils.h: Rename include guard.
10034         * common/x86-xstate.h: Rename include guard.
10035         * common/version.h: Rename include guard.
10036         * common/vec.h: Rename include guard.
10037         * common/tdesc.h: Rename include guard.
10038         * common/selftest.h: Rename include guard.
10039         * common/scoped_restore.h: Rename include guard.
10040         * common/scoped_mmap.h: Rename include guard.
10041         * common/scoped_fd.h: Rename include guard.
10042         * common/safe-iterator.h: Rename include guard.
10043         * common/run-time-clock.h: Rename include guard.
10044         * common/refcounted-object.h: Rename include guard.
10045         * common/queue.h: Rename include guard.
10046         * common/ptid.h: Rename include guard.
10047         * common/print-utils.h: Rename include guard.
10048         * common/preprocessor.h: Rename include guard.
10049         * common/pathstuff.h: Rename include guard.
10050         * common/observable.h: Rename include guard.
10051         * common/netstuff.h: Rename include guard.
10052         * common/job-control.h: Rename include guard.
10053         * common/host-defs.h: Rename include guard.
10054         * common/gdb_wait.h: Rename include guard.
10055         * common/gdb_vecs.h: Rename include guard.
10056         * common/gdb_unlinker.h: Rename include guard.
10057         * common/gdb_unique_ptr.h: Rename include guard.
10058         * common/gdb_tilde_expand.h: Rename include guard.
10059         * common/gdb_sys_time.h: Rename include guard.
10060         * common/gdb_string_view.h: Rename include guard.
10061         * common/gdb_splay_tree.h: Rename include guard.
10062         * common/gdb_setjmp.h: Rename include guard.
10063         * common/gdb_ref_ptr.h: Rename include guard.
10064         * common/gdb_optional.h: Rename include guard.
10065         * common/gdb_locale.h: Rename include guard.
10066         * common/gdb_assert.h: Rename include guard.
10067         * common/filtered-iterator.h: Rename include guard.
10068         * common/filestuff.h: Rename include guard.
10069         * common/fileio.h: Rename include guard.
10070         * common/environ.h: Rename include guard.
10071         * common/common-utils.h: Rename include guard.
10072         * common/common-types.h: Rename include guard.
10073         * common/common-regcache.h: Rename include guard.
10074         * common/common-inferior.h: Rename include guard.
10075         * common/common-gdbthread.h: Rename include guard.
10076         * common/common-exceptions.h: Rename include guard.
10077         * common/common-defs.h: Rename include guard.
10078         * common/common-debug.h: Rename include guard.
10079         * common/cleanups.h: Rename include guard.
10080         * common/buffer.h: Rename include guard.
10081         * common/btrace-common.h: Rename include guard.
10082         * common/break-common.h: Rename include guard.
10083         * cli/cli-utils.h: Rename include guard.
10084         * cli/cli-style.h: Rename include guard.
10085         * cli/cli-setshow.h: Rename include guard.
10086         * cli/cli-script.h: Rename include guard.
10087         * cli/cli-interp.h: Rename include guard.
10088         * cli/cli-decode.h: Rename include guard.
10089         * cli/cli-cmds.h: Rename include guard.
10090         * charset-list.h: Add include guard.
10091         * buildsym-legacy.h: Rename include guard.
10092         * bfin-tdep.h: Add include guard.
10093         * ax.h: Rename include guard.
10094         * arm-linux-tdep.h: Add include guard.
10095         * arm-fbsd-tdep.h: Add include guard.
10096         * arch/xtensa.h: Rename include guard.
10097         * arch/tic6x.h: Add include guard.
10098         * arch/i386.h: Add include guard.
10099         * arch/arm.h: Rename include guard.
10100         * arch/arm-linux.h: Rename include guard.
10101         * arch/arm-get-next-pcs.h: Rename include guard.
10102         * arch/amd64.h: Add include guard.
10103         * arch/aarch64-insn.h: Rename include guard.
10104         * arch-utils.h: Rename include guard.
10105         * annotate.h: Add include guard.
10106         * amd64-darwin-tdep.h: Rename include guard.
10107         * aarch64-linux-tdep.h: Add include guard.
10108         * aarch64-fbsd-tdep.h: Add include guard.
10109         * aarch32-linux-nat.h: Add include guard.
10110
10111 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10112
10113         * macrotab.c (macro_define_internal): New function that
10114         factorizes macro_define_object_internal and macro_define_function
10115         code.
10116         (macro_define_object_internal): Use macro_define_internal.
10117         (macro_define_function): Likewise.
10118
10119 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10120
10121         * macrocmd.c (extract_identifier): Return
10122         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10123         callers.
10124
10125 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10126
10127         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10128
10129 2019-02-05  Tom Tromey  <tom@tromey.com>
10130
10131         * target.c (target_stack::unpush): Move assertion earlier.
10132
10133 2019-01-30  Tom Tromey  <tom@tromey.com>
10134
10135         PR python/23615:
10136         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10137         (gdbpy_parse_and_eval): Likewise.
10138         * python/python-internal.h (gdbpy_allow_threads): New class.
10139
10140 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10141
10142         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10143         (aarch64_fbsd_fpregmap): Move earlier.
10144         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10145         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10146         instead of individual calls to trad_frame_set_reg_addr.
10147         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10148         earlier.
10149         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10150         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10151         instead of individual calls to trad_frame_set_reg_addr.
10152
10153 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10154
10155         * CONTRIBUTE: Replace contribution list with wiki link.
10156
10157 2019-01-25  Tom Tromey  <tom@tromey.com>
10158
10159         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10160
10161 2019-01-25  Tom Tromey  <tom@tromey.com>
10162
10163         * xtensa-linux-nat.c: Fix common/ includes.
10164         * xml-support.h: Fix common/ includes.
10165         * xml-support.c: Fix common/ includes.
10166         * x86-linux-nat.c: Fix common/ includes.
10167         * windows-nat.c: Fix common/ includes.
10168         * varobj.h: Fix common/ includes.
10169         * varobj.c: Fix common/ includes.
10170         * value.c: Fix common/ includes.
10171         * valops.c: Fix common/ includes.
10172         * utils.c: Fix common/ includes.
10173         * unittests/xml-utils-selftests.c: Fix common/ includes.
10174         * unittests/utils-selftests.c: Fix common/ includes.
10175         * unittests/unpack-selftests.c: Fix common/ includes.
10176         * unittests/tracepoint-selftests.c: Fix common/ includes.
10177         * unittests/style-selftests.c: Fix common/ includes.
10178         * unittests/string_view-selftests.c: Fix common/ includes.
10179         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10180         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10181         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10182         * unittests/rsp-low-selftests.c: Fix common/ includes.
10183         * unittests/parse-connection-spec-selftests.c: Fix common/
10184         includes.
10185         * unittests/optional-selftests.c: Fix common/ includes.
10186         * unittests/offset-type-selftests.c: Fix common/ includes.
10187         * unittests/observable-selftests.c: Fix common/ includes.
10188         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10189         * unittests/memrange-selftests.c: Fix common/ includes.
10190         * unittests/memory-map-selftests.c: Fix common/ includes.
10191         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10192         * unittests/function-view-selftests.c: Fix common/ includes.
10193         * unittests/environ-selftests.c: Fix common/ includes.
10194         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10195         * unittests/common-utils-selftests.c: Fix common/ includes.
10196         * unittests/cli-utils-selftests.c: Fix common/ includes.
10197         * unittests/array-view-selftests.c: Fix common/ includes.
10198         * ui-file.c: Fix common/ includes.
10199         * tui/tui-io.c: Fix common/ includes.
10200         * tracepoint.h: Fix common/ includes.
10201         * tracepoint.c: Fix common/ includes.
10202         * tracefile-tfile.c: Fix common/ includes.
10203         * top.h: Fix common/ includes.
10204         * top.c: Fix common/ includes.
10205         * thread.c: Fix common/ includes.
10206         * target/waitstatus.h: Fix common/ includes.
10207         * target/waitstatus.c: Fix common/ includes.
10208         * target.h: Fix common/ includes.
10209         * target.c: Fix common/ includes.
10210         * target-memory.c: Fix common/ includes.
10211         * target-descriptions.c: Fix common/ includes.
10212         * symtab.h: Fix common/ includes.
10213         * symfile.c: Fix common/ includes.
10214         * stap-probe.c: Fix common/ includes.
10215         * spu-linux-nat.c: Fix common/ includes.
10216         * sparc-nat.c: Fix common/ includes.
10217         * source.c: Fix common/ includes.
10218         * solib.c: Fix common/ includes.
10219         * solib-target.c: Fix common/ includes.
10220         * ser-unix.c: Fix common/ includes.
10221         * ser-tcp.c: Fix common/ includes.
10222         * ser-pipe.c: Fix common/ includes.
10223         * ser-base.c: Fix common/ includes.
10224         * selftest-arch.c: Fix common/ includes.
10225         * s12z-tdep.c: Fix common/ includes.
10226         * rust-exp.y: Fix common/ includes.
10227         * rs6000-aix-tdep.c: Fix common/ includes.
10228         * riscv-tdep.c: Fix common/ includes.
10229         * remote.c: Fix common/ includes.
10230         * remote-notif.h: Fix common/ includes.
10231         * remote-fileio.h: Fix common/ includes.
10232         * remote-fileio.c: Fix common/ includes.
10233         * regcache.h: Fix common/ includes.
10234         * regcache.c: Fix common/ includes.
10235         * record-btrace.c: Fix common/ includes.
10236         * python/python.c: Fix common/ includes.
10237         * python/py-type.c: Fix common/ includes.
10238         * python/py-inferior.c: Fix common/ includes.
10239         * progspace.h: Fix common/ includes.
10240         * producer.c: Fix common/ includes.
10241         * procfs.c: Fix common/ includes.
10242         * proc-api.c: Fix common/ includes.
10243         * printcmd.c: Fix common/ includes.
10244         * ppc-linux-nat.c: Fix common/ includes.
10245         * parser-defs.h: Fix common/ includes.
10246         * osdata.c: Fix common/ includes.
10247         * obsd-nat.c: Fix common/ includes.
10248         * nat/x86-linux.c: Fix common/ includes.
10249         * nat/x86-linux-dregs.c: Fix common/ includes.
10250         * nat/x86-dregs.h: Fix common/ includes.
10251         * nat/x86-dregs.c: Fix common/ includes.
10252         * nat/ppc-linux.c: Fix common/ includes.
10253         * nat/mips-linux-watch.h: Fix common/ includes.
10254         * nat/mips-linux-watch.c: Fix common/ includes.
10255         * nat/linux-waitpid.c: Fix common/ includes.
10256         * nat/linux-ptrace.h: Fix common/ includes.
10257         * nat/linux-ptrace.c: Fix common/ includes.
10258         * nat/linux-procfs.c: Fix common/ includes.
10259         * nat/linux-personality.c: Fix common/ includes.
10260         * nat/linux-osdata.c: Fix common/ includes.
10261         * nat/linux-namespaces.c: Fix common/ includes.
10262         * nat/linux-btrace.h: Fix common/ includes.
10263         * nat/linux-btrace.c: Fix common/ includes.
10264         * nat/fork-inferior.c: Fix common/ includes.
10265         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10266         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10267         * nat/aarch64-linux.c: Fix common/ includes.
10268         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10269         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10270         * namespace.h: Fix common/ includes.
10271         * mips-linux-tdep.c: Fix common/ includes.
10272         * minsyms.c: Fix common/ includes.
10273         * mi/mi-parse.h: Fix common/ includes.
10274         * mi/mi-main.c: Fix common/ includes.
10275         * mi/mi-cmd-env.c: Fix common/ includes.
10276         * memrange.h: Fix common/ includes.
10277         * memattr.c: Fix common/ includes.
10278         * maint.h: Fix common/ includes.
10279         * maint.c: Fix common/ includes.
10280         * main.c: Fix common/ includes.
10281         * machoread.c: Fix common/ includes.
10282         * location.c: Fix common/ includes.
10283         * linux-thread-db.c: Fix common/ includes.
10284         * linux-nat.c: Fix common/ includes.
10285         * linux-fork.c: Fix common/ includes.
10286         * inline-frame.c: Fix common/ includes.
10287         * infrun.c: Fix common/ includes.
10288         * inflow.c: Fix common/ includes.
10289         * inferior.h: Fix common/ includes.
10290         * inferior.c: Fix common/ includes.
10291         * infcmd.c: Fix common/ includes.
10292         * inf-ptrace.c: Fix common/ includes.
10293         * inf-child.c: Fix common/ includes.
10294         * ia64-linux-nat.c: Fix common/ includes.
10295         * i387-tdep.c: Fix common/ includes.
10296         * i386-tdep.c: Fix common/ includes.
10297         * i386-linux-tdep.c: Fix common/ includes.
10298         * i386-linux-nat.c: Fix common/ includes.
10299         * i386-go32-tdep.c: Fix common/ includes.
10300         * i386-fbsd-tdep.c: Fix common/ includes.
10301         * i386-fbsd-nat.c: Fix common/ includes.
10302         * guile/scm-type.c: Fix common/ includes.
10303         * guile/guile.c: Fix common/ includes.
10304         * go32-nat.c: Fix common/ includes.
10305         * gnu-nat.c: Fix common/ includes.
10306         * gdbthread.h: Fix common/ includes.
10307         * gdbarch-selftests.c: Fix common/ includes.
10308         * gdb_usleep.c: Fix common/ includes.
10309         * gdb_select.h: Fix common/ includes.
10310         * gdb_bfd.c: Fix common/ includes.
10311         * gcore.c: Fix common/ includes.
10312         * fork-child.c: Fix common/ includes.
10313         * findvar.c: Fix common/ includes.
10314         * fbsd-nat.c: Fix common/ includes.
10315         * event-top.c: Fix common/ includes.
10316         * event-loop.c: Fix common/ includes.
10317         * dwarf2read.c: Fix common/ includes.
10318         * dwarf2loc.c: Fix common/ includes.
10319         * dwarf2-frame.c: Fix common/ includes.
10320         * dwarf-index-cache.c: Fix common/ includes.
10321         * dtrace-probe.c: Fix common/ includes.
10322         * disasm-selftests.c: Fix common/ includes.
10323         * defs.h: Fix common/ includes.
10324         * csky-tdep.c: Fix common/ includes.
10325         * cp-valprint.c: Fix common/ includes.
10326         * cp-support.h: Fix common/ includes.
10327         * cp-support.c: Fix common/ includes.
10328         * corelow.c: Fix common/ includes.
10329         * completer.h: Fix common/ includes.
10330         * completer.c: Fix common/ includes.
10331         * compile/compile.c: Fix common/ includes.
10332         * compile/compile-loc2c.c: Fix common/ includes.
10333         * compile/compile-cplus-types.c: Fix common/ includes.
10334         * compile/compile-cplus-symbols.c: Fix common/ includes.
10335         * command.h: Fix common/ includes.
10336         * cli/cli-dump.c: Fix common/ includes.
10337         * cli/cli-cmds.c: Fix common/ includes.
10338         * charset.c: Fix common/ includes.
10339         * build-id.c: Fix common/ includes.
10340         * btrace.h: Fix common/ includes.
10341         * btrace.c: Fix common/ includes.
10342         * breakpoint.h: Fix common/ includes.
10343         * breakpoint.c: Fix common/ includes.
10344         * ax.h:
10345         (enum agent_op): Fix common/ includes.
10346         * ax-general.c (struct aop_map): Fix common/ includes.
10347         * ax-gdb.c: Fix common/ includes.
10348         * auxv.c: Fix common/ includes.
10349         * auto-load.c: Fix common/ includes.
10350         * arm-tdep.c: Fix common/ includes.
10351         * arch/riscv.c: Fix common/ includes.
10352         * arch/ppc-linux-common.c: Fix common/ includes.
10353         * arch/i386.c: Fix common/ includes.
10354         * arch/arm.c: Fix common/ includes.
10355         * arch/arm-linux.c: Fix common/ includes.
10356         * arch/arm-get-next-pcs.c: Fix common/ includes.
10357         * arch/amd64.c: Fix common/ includes.
10358         * arch/aarch64.c: Fix common/ includes.
10359         * arch/aarch64-insn.c: Fix common/ includes.
10360         * arch-utils.c: Fix common/ includes.
10361         * amd64-windows-tdep.c: Fix common/ includes.
10362         * amd64-tdep.c: Fix common/ includes.
10363         * amd64-sol2-tdep.c: Fix common/ includes.
10364         * amd64-obsd-tdep.c: Fix common/ includes.
10365         * amd64-nbsd-tdep.c: Fix common/ includes.
10366         * amd64-linux-tdep.c: Fix common/ includes.
10367         * amd64-linux-nat.c: Fix common/ includes.
10368         * amd64-fbsd-tdep.c: Fix common/ includes.
10369         * amd64-fbsd-nat.c: Fix common/ includes.
10370         * amd64-dicos-tdep.c: Fix common/ includes.
10371         * amd64-darwin-tdep.c: Fix common/ includes.
10372         * agent.c: Fix common/ includes.
10373         * ada-lang.h: Fix common/ includes.
10374         * ada-lang.c: Fix common/ includes.
10375         * aarch64-tdep.c: Fix common/ includes.
10376
10377 2019-01-25  Tom Tromey  <tom@tromey.com>
10378
10379         * common/create-version.sh: Use common/version.h.
10380
10381 2019-01-24  Pedro Alves  <palves@redhat.com>
10382
10383         * infrun.c (signal_stop, signal_print, signal_program)
10384         (signal_catch, signal_pass): Now arrays instead of pointers.
10385         (update_signals_program_target, do_target_resume)
10386         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10387         * linux-nat.c (linux_nat_target::pass_signals)
10388         (linux_nat_target::create_inferior, linux_nat_target::attach):
10389         Adjust.
10390         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10391         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10392         * procfs.c (procfs_target::pass_signals): Adjust.
10393         * record-full.c (record_full_target::resume): Adjust.
10394         * remote.c (remote_target::pass_signals)
10395         (remote_target::program_signals): Adjust.
10396         * target-debug.h (target_debug_print_signals): Now takes a
10397         gdb::array_view as parameter.  Adjust.
10398         * target.h (target_ops) <pass_signals, program_signals>: Replace
10399         pointer and length parameters with gdb::array_view.
10400         (target_pass_signals, target_program_signals): Likewise.
10401         * target-delegates.c: Regenerate.
10402
10403 2019-01-24  Pedro Alves  <palves@redhat.com>
10404
10405         * common/forward-scope-exit.h
10406         (forward_scope_exit::forward_scope_exit): Pass arguments to
10407         m_bind_function directly, instead of creating a std::bind and
10408         copying that.
10409
10410 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10411
10412         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10413         for static members.
10414         (pass_in_v_vfp_candidate): Likewise.
10415
10416 2019-01-23  Tom Tromey  <tom@tromey.com>
10417             Pedro Alves  <palves@redhat.com>
10418
10419         * regcache.c (class regcache_invalidator): Remove.
10420         (regcache::raw_write): Use make_scope_exit.
10421
10422 2019-01-23  Tom Tromey  <tom@tromey.com>
10423
10424         * ui-out.h (class ui_out_emit_type): Update comment.
10425
10426 2019-01-23  Tom Tromey  <tom@tromey.com>
10427
10428         * infrun.c (fetch_inferior_event): Update comment.
10429
10430 2019-01-23  Tom Tromey  <tom@tromey.com>
10431             Pedro Alves  <palves@redhat.com>
10432
10433         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10434         parameter.
10435         (fetch_inferior_event): Use SCOPE_EXIT.
10436
10437
10438 2019-01-23  Tom Tromey  <tom@tromey.com>
10439             Pedro Alves  <palves@redhat.com>
10440
10441         * infrun.c (disable_thread_events): Delete.
10442         (stop_all_threads): Use SCOPE_EXIT.
10443
10444 2019-01-23  Tom Tromey  <tom@tromey.com>
10445             Pedro Alves  <palves@redhat.com>
10446
10447         * symfile.c: Include forward-scope-exit.h.
10448         (clear_symtab_users_cleanup): Replace forward declaration with
10449         a FORWARD_SCOPE_EXIT.
10450         (syms_from_objfile_1): Use the forward_scope_exit and
10451         gdb::optional instead of cleanup_function.
10452         (reread_symbols): Use the forward_scope_exit instead of
10453         cleanup_function.
10454         (clear_symtab_users_cleanup): Remove function.
10455
10456 2019-01-23  Tom Tromey  <tom@tromey.com>
10457             Pedro Alves  <palves@redhat.com>
10458
10459         * linux-nat.c: Include scope-exit.h.
10460         (cleanup_target_stop): Remove.
10461         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10462         SCOPE_EXIT.
10463
10464 2019-01-23  Tom Tromey  <tom@tromey.com>
10465             Pedro Alves  <palves@redhat.com>
10466
10467         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10468         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10469
10470 2019-01-23  Tom Tromey  <tom@tromey.com>
10471             Andrew Burgess  <andrew.burgess@embecosm.com>
10472             Pedro Alves  <palves@redhat.com>
10473
10474         * infrun.c (fetch_inferior_event): Use scope_exit.
10475         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10476         * top.c (execute_command): Use scope_exit.
10477         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10478         * utils.c (do_bpstat_clear_actions_cleanup)
10479         (make_bpstat_clear_actions_cleanup): Remove.
10480
10481 2019-01-23  Tom Tromey  <tom@tromey.com>
10482             Pedro Alves  <palves@redhat.com>
10483
10484         * infrun.c: Include "common/scope-exit.h"
10485         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10486         (wait_for_inferior): Use SCOPE_EXIT.
10487         (fetch_inferior_event): Use scope_exit.
10488
10489 2019-01-23  Tom Tromey  <tom@tromey.com>
10490             Pedro Alves  <palves@redhat.com>
10491
10492         * breakpoint.c (create_breakpoint): Remove cleanup.
10493
10494 2019-01-23  Tom Tromey  <tom@tromey.com>
10495             Andrew Burgess  <andrew.burgess@embecosm.com>
10496             Pedro Alves  <palves@redhat.com>
10497
10498 2019-01-23  Pedro Alves  <palves@redhat.com>
10499
10500         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10501
10502 2019-01-23  Pedro Alves  <palves@redhat.com>
10503             Andrew Burgess  <andrew.burgess@embecosm.com>
10504
10505         * gdbthread.h: Include "common/forward-scope-exit.h".
10506         (scoped_finish_thread_state): Redefine custom class in terms of
10507         forward_scope_exit.
10508
10509 2019-01-23  Pedro Alves  <palves@redhat.com>
10510             Andrew Burgess  <andrew.burgess@embecosm.com>
10511
10512         * common/forward-scope-exit.h: New file.
10513
10514 2019-01-23  Pedro Alves  <palves@redhat.com>
10515             Andrew Burgess  <andrew.burgess@embecosm.com>
10516             Tom Tromey  <tom@tromey.com>
10517
10518         * common/scope-exit.h: New file.
10519
10520 2019-01-23  Pedro Alves  <palves@redhat.com>
10521
10522         * common/preprocessor.h (ESC): Rename to ...
10523         (ESC_PARENS): ... this.
10524         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10525         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10526
10527 2019-01-23  Tom Tromey  <tom@tromey.com>
10528
10529         * language.h (class scoped_switch_to_sym_language_if_auto):
10530         Initialize m_lang in both cases.
10531
10532 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10533
10534         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10535         with XCNEW.
10536
10537 2019-01-22  Tom Tromey  <tom@tromey.com>
10538
10539         * corelow.c: Do not include sys/file.h.
10540
10541 2019-01-22  Tom Tromey  <tom@tromey.com>
10542
10543         * tui/tui-wingeneral.h: Include gdb_curses.h.
10544
10545 2019-01-22  Tom Tromey  <tom@tromey.com>
10546
10547         * source-cache.h (class source_cache) <get_source_lines,
10548         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10549
10550 2019-01-22  Tom Tromey  <tom@tromey.com>
10551
10552         * remote-fileio.h (struct remote_target): Declare.
10553
10554 2019-01-22  Tom Tromey  <tom@tromey.com>
10555
10556         * python/py-arch.c: Do not include py-ref.h.
10557         * python/py-bpevent.c: Do not include py-ref.h.
10558         * python/py-cmd.c: Do not include py-ref.h.
10559         * python/py-continueevent.c: Do not include py-ref.h.
10560         * python/py-event.h: Do not include py-ref.h.
10561         * python/py-evtregistry.c: Do not include py-ref.h.
10562         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10563         * python/py-frame.c: Do not include py-ref.h.
10564         * python/py-framefilter.c: Do not include py-ref.h.
10565         * python/py-function.c: Do not include py-ref.h.
10566         * python/py-infevents.c: Do not include py-ref.h.
10567         * python/py-linetable.c: Do not include py-ref.h.
10568         * python/py-objfile.c: Do not include py-ref.h.
10569         * python/py-param.c: Do not include py-ref.h.
10570         * python/py-prettyprint.c: Do not include py-ref.h.
10571         * python/py-progspace.c: Do not include py-ref.h.
10572         * python/py-symbol.c: Do not include py-ref.h.
10573         * python/py-symtab.c: Do not include py-ref.h.
10574         * python/py-type.c: Do not include py-ref.h.
10575         * python/py-unwind.c: Do not include py-ref.h.
10576         * python/py-utils.c: Do not include py-ref.h.
10577         * python/py-value.c: Do not include py-ref.h.
10578         * python/py-varobj.c: Do not include py-ref.h.
10579         * python/py-xmethods.c: Do not include py-ref.h.
10580         * python/python.c: Do not include py-ref.h.
10581         * varobj.c: Do not include py-ref.h.
10582
10583 2019-01-22  Tom Tromey  <tom@tromey.com>
10584
10585         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10586         keyword for bcache.
10587
10588 2019-01-22  Tom Tromey  <tom@tromey.com>
10589
10590         * compile/compile-cplus-types.c: Remove a comment by #include.
10591
10592 2019-01-22  Tom Tromey  <tom@tromey.com>
10593
10594         * compile/gcc-c-plugin.h: Include compile-internal.h.
10595
10596 2019-01-22  Tom Tromey  <tom@tromey.com>
10597
10598         * stabsread.c (EXTERN): Do not define.
10599         (symnum, next_symbol_text_func, processing_gcc_compilation)
10600         (within_function, global_sym_chain, global_stabs)
10601         (previous_stab_code, this_object_header_files)
10602         (n_this_object_header_files)
10603         (n_allocated_this_object_header_files): Define.
10604         * stabsread.h (EXTERN): Never define.  Use "extern".
10605
10606 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10607
10608         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10609         history_value.
10610
10611 2019-01-21  Tom Tromey  <tom@tromey.com>
10612
10613         * ui-out.c: Fix includes.
10614         * tui/tui-source.c: Fix includes.
10615         * target.c: Fix includes.
10616         * remote.c: Fix includes.
10617         * regcache.c: Fix includes.
10618         * python/py-block.c: Fix includes.
10619         * printcmd.c: Fix includes.
10620         * or1k-tdep.c: Fix includes.
10621         * mi/mi-main.c: Fix includes.
10622         * m32r-tdep.c: Fix includes.
10623         * csky-tdep.c: Fix includes.
10624         * compile/compile-cplus-types.c: Fix includes.
10625         * cli/cli-interp.c: Fix includes.
10626
10627 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10628
10629         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10630         for padding.
10631
10632 2019-01-16  Tom Tromey  <tom@tromey.com>
10633
10634         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10635         earlier.
10636         (struct objfile) <msymbols_range>: Move from top level.
10637         <msymbols>: New method.
10638         (class objfile_msymbols): Remove.
10639         * symtab.c (default_collect_symbol_completion_matches_break_on):
10640         Update.
10641         * symmisc.c (dump_msymbols): Update.
10642         * stabsread.c (scan_file_globals): Update.
10643         * objc-lang.c (info_selectors_command, info_classes_command)
10644         (find_methods): Update.
10645         * minsyms.c (find_solib_trampoline_target): Update.
10646         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10647         * coffread.c (coff_symfile_read): Update.
10648         * ada-lang.c (ada_lookup_simple_minsym)
10649         (ada_collect_symbol_completion_matches): Update.
10650
10651 2019-01-16  Tom Tromey  <tom@tromey.com>
10652
10653         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10654         type.  Remove no-argument constructor.
10655         <iterator::operator++>: Simplify.
10656         <begin>: Update.
10657         <end>: Use minimal_symbol_count.
10658
10659 2019-01-16  Tom Tromey  <tom@tromey.com>
10660
10661         * objfiles.h (struct objfile) <psymtabs>: New method.
10662         (class objfile_psymtabs): Remove.
10663         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10664         typedef.
10665         <range>: New method.
10666         (require_partial_symbols): Change return type.
10667         * psymtab.c (require_partial_symbols)
10668         (psym_expand_symtabs_matching): Update.
10669         * mdebugread.c (parse_partial_symbols): Update.
10670         * dbxread.c (dbx_end_psymtab): Update.
10671
10672 2019-01-15  Tom Tromey  <tom@tromey.com>
10673
10674         * symtab.c (lookup_objfile_from_block)
10675         (lookup_symbol_in_objfile_symtabs)
10676         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10677         (find_line_symtab, info_sources_command)
10678         (default_collect_symbol_completion_matches_break_on)
10679         (make_source_files_completion_list): Update.
10680         * symmisc.c (print_objfile_statistics, dump_objfile)
10681         (maintenance_print_symbols, maintenance_info_symtabs)
10682         (maintenance_check_symtabs, maintenance_info_line_tables):
10683         Update.
10684         * source.c (select_source_symtab)
10685         (forget_cached_source_info_for_objfile): Update.
10686         * objfiles.h (class objfile_compunits): Remove.
10687         (struct objfile) <compunits_range>: New typedef.
10688         (compunits): New method.
10689         * objfiles.c (objfile_relocate1): Update.
10690         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10691         * maint.c (count_symtabs_and_blocks): Update.
10692         * linespec.c (iterate_over_all_matching_symtabs): Update.
10693         * cp-support.c (add_symbol_overload_list_qualified): Update.
10694         * coffread.c (coff_symtab_read): Update.
10695         * ada-lang.c (add_nonlocal_symbols)
10696         (ada_collect_symbol_completion_matches)
10697         (ada_add_global_exceptions): Update.
10698
10699 2019-01-15  Tom Tromey  <tom@tromey.com>
10700
10701         * progspace.h (program_space) <objfiles_safe_range>: New
10702         typedef.
10703         <objfiles_safe>: New method.
10704         * objfiles.h (class all_objfiles_safe): Remove.
10705         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10706         * jit.c (jit_inferior_exit_hook): Update.
10707
10708 2019-01-17  Tom Tromey  <tom@tromey.com>
10709
10710         * progspace.h (program_space) <objfiles_range>: New typedef.
10711         <objfiles>: New method.
10712         <objfiles_head>: Rename from objfiles.
10713         (object_files): Update.
10714         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10715         * guile/scm-pretty-print.c
10716         (ppscm_find_pretty_printer_from_objfiles): Update.
10717         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10718         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10719         Update.
10720         * python/py-progspace.c (pspy_get_objfiles): Update.
10721         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10722         Update.
10723         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10724         (objfpy_lookup_objfile_by_build_id): Update.
10725         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10726         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10727         Update.
10728         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10729         (expand_symtab_containing_pc, lookup_objfile_from_block)
10730         (lookup_static_symbol, basic_lookup_transparent_type)
10731         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10732         (find_line_symtab, info_sources_command)
10733         (default_collect_symbol_completion_matches_break_on)
10734         (make_source_files_completion_list, find_main_name): Update.
10735         * symmisc.c (print_symbol_bcache_statistics)
10736         (print_objfile_statistics, maintenance_print_symbols)
10737         (maintenance_print_msymbols, maintenance_print_objfiles)
10738         (maintenance_info_symtabs, maintenance_check_symtabs)
10739         (maintenance_expand_symtabs, maintenance_info_line_tables):
10740         Update.
10741         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10742         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10743         (map_overlay_command, unmap_overlay_command)
10744         (simple_overlay_update, expand_symtabs_matching)
10745         (map_symbol_filenames): Update.
10746         * symfile-debug.c (set_debug_symfile): Update.
10747         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10748         Update.
10749         * source.c (select_source_symtab, forget_cached_source_info):
10750         Update.
10751         * solib.c (solib_read_symbols): Update.
10752         * solib-spu.c (append_ocl_sos): Update.
10753         * psymtab.c (maintenance_print_psymbols)
10754         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10755         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10756         * printcmd.c (info_symbol_command): Update.
10757         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10758         Update.
10759         * objfiles.h (class all_objfiles): Remove.
10760         * objfiles.c (have_partial_symbols, have_full_symbols)
10761         (have_minimal_symbols, qsort_cmp, update_section_map)
10762         (shared_objfile_contains_address_p)
10763         (default_iterate_over_objfiles_in_search_order): Update.
10764         * objc-lang.c (info_selectors_command, info_classes_command)
10765         (find_methods): Update.
10766         * minsyms.c (find_solib_trampoline_target): Update.
10767         * maint.c (maintenance_info_sections)
10768         (maintenance_translate_address, count_symtabs_and_blocks):
10769         Update.
10770         * main.c (captured_main_1): Update.
10771         * linux-thread-db.c (try_thread_db_load_from_pdir)
10772         (has_libpthread): Update.
10773         * linespec.c (iterate_over_all_matching_symtabs)
10774         (search_minsyms_for_name): Update.
10775         * jit.c (jit_find_objf_with_entry_addr): Update.
10776         * hppa-tdep.c (find_unwind_entry)
10777         (hppa_lookup_stub_minimal_symbol): Update.
10778         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10779         Update.
10780         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10781         (elf_gnu_ifunc_resolve_by_got): Update.
10782         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10783         * dwarf-index-write.c (save_gdb_index_command): Update.
10784         * cp-support.c (add_symbol_overload_list_qualified): Update.
10785         * breakpoint.c (create_overlay_event_breakpoint)
10786         (create_longjmp_master_breakpoint)
10787         (create_std_terminate_master_breakpoint)
10788         (create_exception_master_breakpoint): Update.
10789         * blockframe.c (find_pc_partial_function): Update.
10790         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10791         (ada_collect_symbol_completion_matches)
10792         (ada_add_global_exceptions): Update.
10793
10794 2019-01-17  Tom Tromey  <tom@tromey.com>
10795
10796         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10797         declare VEC.
10798         (solib_target_parse_libraries): Change return type.
10799         (library_list_start_segment, library_list_start_section)
10800         (library_list_end_library, library_list_start_library); Update.
10801         (solib_target_free_library_list): Remove.
10802         (solib_target_parse_libraries): Remove cleanup.  Change return
10803         type.
10804         (solib_target_current_sos): Update.
10805
10806 2019-01-17  Tom Tromey  <tromey@bapiya>
10807
10808         * valprint.c: Replace "the the" with "the".
10809         * symtab.c: Replace "the the" with "the".
10810         * solib.c: Replace "the the" with "the".
10811         * solib-dsbt.c: Replace "the the" with "the".
10812         * linespec.c: Replace "the the" with "the".
10813         * dwarf2loc.h: Replace "the the" with "the".
10814         * amd64-windows-tdep.c: Replace "the the" with "the".
10815         * aarch64-tdep.c: Replace "the the" with "the".
10816
10817 2019-01-16  Keith Seitz  <keiths@redhat.com>
10818
10819         PR gdb/23773
10820         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10821         <builder>: Rename to ..
10822         <m_builder>: ... this and make private.
10823         (dwarf2_cu::get_builder): New method.  Change all users of
10824         `builder' to use this method.
10825         (dwarf2_start_symtab): Move to ...
10826         (dwarf2_cu::start_symtab): ... here.  Update all callers
10827         (setup_type_unit_groups): Move to ...
10828         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10829         callers.
10830         (dwarf2_cu::reset_builder): New method.
10831         (process_full_compunit, process_full_type_unit): Use
10832         dwarf2_cu::reset_builder.
10833         (follow_die_offset): Record the ancestor CU if it is different
10834         from the followed DIE's CU.
10835         (follow_die_sig_1): Likewise.
10836
10837 2019-01-15  Tom Tromey  <tom@tromey.com>
10838
10839         * remote.c (class remote_state) <buf>: Now a char_vector.
10840         <buf_size>: Remove.
10841         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10842         parameter.
10843         (remote_target::getpkt_or_notif_sane_1)
10844         (remote_target::getpkt_sane)
10845         (remote_target::getpkt_or_notif_sane): Likewise.
10846         (class remote_target) <putpkt>: New overload.
10847         (remote_target::read_frame): Change type of "buf_p".  Remove
10848         sizeof_p parameter.
10849         (packet_ok): New overload.
10850         (packet_check_result): New overload.
10851         Update all uses.
10852
10853 2019-01-14  Tom Tromey  <tom@tromey.com>
10854
10855         * remote-notif.c (handle_notification, remote_notif_ack)
10856         (remote_notif_parse): Make "buf" const.
10857         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10858         const.
10859         (remote_notif_parse, remote_notif_ack, handle_notification):
10860         Likewise.
10861         * remote.c (remote_notif_stop_parse): Make "buf" const.
10862         (remote_target::remote_parse_stop_reply): Make "buf" const.
10863         (remote_notif_stop_ack): Make "buf" const.
10864
10865 2019-01-14  Tom Tromey  <tom@tromey.com>
10866
10867         * remote.c (remote_console_output): Make parameter const.
10868
10869 2019-01-14  Tom Tromey  <tom@tromey.com>
10870
10871         * target-debug.h (target_debug_print_signals): Constify.
10872         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10873         * procfs.c (procfs_target::pass_signals): Update.
10874         * linux-nat.c (linux_nat_target::pass_signals): Update.
10875         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10876         * target-delegates.c: Rebuild.
10877         * remote.c (remote_target::program_signals): Update.
10878         (remote_target::pass_signals): Update.
10879         * target.c (target_pass_signals): Constify argument.
10880         (target_program_signals): Likewise.
10881         * target.h (struct target_ops) <pass_signals, program_signals>:
10882         Constify argument.
10883         (target_pass_signals, target_program_signals): Constify argument.
10884
10885 2019-01-14  Tom Tromey  <tom@tromey.com>
10886
10887         PR tui/28819:
10888         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10889
10890 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10891
10892         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10893         field.
10894         * rs6000-tdep.c: Include reggroups.h.
10895         (IS_V_ALIAS_PSEUDOREG): Define.
10896         (rs6000_register_name): Return names for the "vX" aliases.
10897         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10898         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10899         aliases.  Call default_register_reggroup_p for all other
10900         pseudo-registers.
10901         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10902         New functions.
10903         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10904         Handle "vX" aliases.
10905         (v_alias_pseudo_register_collect): New function.
10906         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10907         (rs6000_gdbarch_init): Initialize "vX" aliases as
10908         pseudo-registers.  Restore registration of
10909         rs6000_pseudo_register_reggroup_p with
10910         set_tdesc_pseudo_register_reggroup_p.
10911
10912 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10913
10914         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10915         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10916         set_gdbarch_num_pseudo_regs.
10917
10918 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10919
10920         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10921         Remove arg prefixname, add do_set and do_show.
10922         Add member functions set_list and show_list.
10923         * cli/cli-style.c (class cli_style_option): Update accordingly.
10924         (style_set_list): Move to file scope.
10925         (style_show_list): Likewise.
10926         (set_style): Call help_list.
10927         (show_style): Call cmd_show_list.
10928         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10929         Update to use the new macro.
10930
10931 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10932
10933         * ada-lang.c (_initialize_ada_language): Expand the help text
10934         for the "catch exception" command.
10935
10936 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10937
10938         * symtab.c (matching_obj_sections): Initialize obj,
10939         declare it closer to its usage.
10940
10941 2019-01-10  Tom Tromey  <tom@tromey.com>
10942
10943         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10944         (basic_inf_threads_range): Remove.
10945         (inf_threads_range, inf_non_exited_threads_range)
10946         (safe_inf_threads_range): Use next_adapter.
10947
10948 2019-01-10  Keith Seitz  <keiths@redhat.com>
10949
10950         PR gdb/23712
10951         PR symtab/23010
10952         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10953         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10954
10955 2019-01-10  Keith Seitz  <keiths@redhat.com>
10956
10957         PR gdb/23712
10958         PR symtab/23010
10959         * dictionary.c (pending_to_vector): Remove.
10960         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10961         Remove _1 suffix, replacing functions of the same name.  Update
10962         all callers.
10963         (dict_create_hashed, dict_create_hashed_expandable)
10964         (dict_create_linear, dict_create_linear_expandable, dict_free)
10965         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10966         Make functions static.
10967
10968 2019-01-10  Keith Seitz  <keiths@redhat.com>
10969
10970         PR gdb/23712
10971         PR symtab/23010
10972         * dictionary.h (struct dictionary): Replace declaration with
10973         multidictionary.
10974         (dict_create_hashed, dict_create_hashed_expandable)
10975         (dict_create_linear, dict_create_linear_expandable)
10976         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10977         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10978         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10979         taking multidictionary argument.
10980         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10981         * block.h (struct block) <dict>: Change to multidictionary
10982         and rename `multidict'.
10983         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10984         symmisc.c: Update all dictionary references to multidictionary.
10985
10986 2019-01-10  Keith Seitz  <keiths@redhat.com>
10987
10988         PR gdb/23712
10989         PR symtab/23010
10990         * dictionary.c: Include unordered_map.
10991         (pending_to_vector): New function.
10992         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10993         Rewrite the non-"_1" functions to take vector instead
10994         of linked list.
10995         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10996         "new" _1 versions of the same name.
10997         (multidictionary): Define.
10998         (std::hash<enum language): New definition.
10999         (collate_pending_symbols_by_language, mdict_create_hashed)
11000         (mdict_create_hashed_expandable, mdict_create_linear)
11001         (mdict_create_linear_expandable, mdict_free)
11002         (find_language_dictionary, create_new_language_dictionary)
11003         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11004         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11005         (mdict_size, mdict_empty): New functions.
11006         * dictionary.h (mdict_iterator): Define.
11007
11008 2019-01-10  Pedro Alves  <palves@redhat.com>
11009
11010         * breakpoint.c (read_uploaded_action)
11011         (create_tracepoint_from_upload): Adjust to use
11012         gdb::unique_xmalloc_ptr.
11013         * ctf.c (ctf_write_uploaded_tp):
11014         (SET_ARRAY_FIELD): Use emplace_back.
11015         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11016         * tracefile-tfile.c (tfile_write_uploaded_tp):
11017         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11018         gdb::unique_xmalloc_ptr.
11019         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11020         at_string, cond_string, cmd_strings>: Replace char pointers
11021         with gdb::unique_xmalloc_ptr.
11022
11023 2019-01-10  Pedro Alves  <palves@redhat.com>
11024
11025         * solib-target.c (library_list_start_library): Don't xstrdup name.
11026
11027 2019-01-10  Pedro Alves  <palves@redhat.com>
11028
11029         * mdebugread.c (parse_partial_symbols): Use
11030         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11031
11032 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11033
11034         * linux-fork.c (scoped_switch_fork_info)
11035         <~scoped_switch_fork_info>: Fix incorrect variable name.
11036
11037 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11038
11039         * linux-fork.c (scoped_switch_fork_info)
11040         <scoped_switch_fork_info>: Make explicit.
11041         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11042
11043 2019-01-10  Tom Tromey  <tom@tromey.com>
11044
11045         * objfiles.h (objfile::reset_psymtabs): Update.
11046         * objfiles.c (objfile::objfile): Update.
11047         * psymtab.h (psymtab_storage::obstack): Update.
11048         (psymtab_storage::m_obstack): Use gdb::optional.
11049         (class psymtab_storage): Update comment.  Remove objfile
11050         parameter.
11051         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11052
11053 2019-01-10  Tom Tromey  <tom@tromey.com>
11054
11055         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11056         <free_psymtabs>: Now private.
11057         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11058         (allocate_psymtab): Use new method.
11059
11060 2019-01-10  Tom Tromey  <tom@tromey.com>
11061
11062         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11063         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11064         * mdebugread.c (parse_partial_symbols): Use
11065         allocate_dependencies.
11066         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11067         allocate_dependencies.
11068         (process_psymtab_comp_unit_reader)
11069         (build_type_psymtab_dependencies): Likewise.
11070         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11071
11072 2019-01-10  Tom Tromey  <tom@tromey.com>
11073
11074         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11075         PSYMBOL_SET_LANGUAGE.
11076         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11077
11078 2019-01-10  Tom Tromey  <tom@tromey.com>
11079
11080         * psymtab.h (psymtab_storage::obstack): New method.
11081         <m_obstack>: Rename from obstack; now private.
11082         * psymtab.c (psymtab_storage): Update.
11083         * dwarf2read.c (create_addrmap_from_index)
11084         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11085         Update.
11086
11087 2019-01-10  Tom Tromey  <tom@tromey.com>
11088
11089         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11090         * objfiles.h (objfile::reset_psymtabs): New method.
11091
11092 2019-01-10  Tom Tromey  <tom@tromey.com>
11093
11094         * symmisc.c (print_symbol_bcache_statistics): Update.
11095         (print_objfile_statistics): Update.
11096         * symfile.c (reread_symbols): Update.
11097         * psymtab.h (class psymtab_storage): New.
11098         * psymtab.c (psymtab_storage): New constructor.
11099         (~psymtab_storage): New destructor.
11100         (require_partial_symbols): Update.
11101         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11102         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11103         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11104         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11105         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11106         (start_psymtab_common, end_psymtab_common)
11107         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11108         (allocate_psymtab): Update.
11109         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11110         Update.
11111         (dump_psymtab_addrmap, maintenance_print_psymbols)
11112         (maintenance_check_psymtabs): Update.
11113         (class objfile_psymtabs): Move to objfiles.h.
11114         * psympriv.h (discard_psymtab): Now inline.
11115         (psymtab_discarder::psymtab_discarder): Update.
11116         (psymtab_discarder::~psymtab_discarder): Update.
11117         (ALL_OBJFILE_PSYMTABS): Rewrite.
11118         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11119         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11120         Remove fields.
11121         <partial_symtabs>: New field.
11122         (class objfile_psymtabs): Move from psymtab.h.  Update.
11123         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11124         psymbol_cache.
11125         (objfile::~objfile): Don't destroy psymbol_cache.
11126         * mdebugread.c (parse_partial_symbols): Update.
11127         * dwarf2read.c (create_addrmap_from_index)
11128         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11129         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11130         (add_partial_subprogram, dwarf2_ranges_read): Update.
11131         * dwarf-index-write.c (write_address_map)
11132         (write_one_signatured_type, recursively_write_psymbols)
11133         (class debug_names, class debug_names, write_psymtabs_to_index):
11134         Update.
11135
11136 2019-01-10  Tom Tromey  <tom@tromey.com>
11137
11138         * symtab.h (SYMBOL_SET_NAMES): Update.
11139         (symbol_set_names): Update.
11140         (MSYMBOL_SET_NAMES): Update.
11141         * symtab.c (symbol_set_names): Change argument to be an
11142         objfile_per_bfd_storage.
11143         * psymtab.c (add_psymbol_to_bcache): Update.
11144         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11145
11146 2019-01-10  Tom Tromey  <tom@tromey.com>
11147
11148         * symtab.c (create_demangled_names_hash): Change argument to be an
11149         objfile_per_bfd_storage.
11150         (symbol_set_names): Update.
11151
11152 2019-01-10  Tom Tromey  <tom@tromey.com>
11153
11154         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11155         init_psymbol_list.
11156         * psymtab.c (init_psymbol_list): Do nothing if already called.
11157         * psympriv.h (init_psymbol_list): Add comment.
11158         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11159         init_psymbol_list.
11160         * dbxread.c (dbx_symfile_read): Unconditionally call
11161         init_psymbol_list.
11162
11163 2019-01-10  Tom Tromey  <tom@tromey.com>
11164
11165         * xcoffread.c (scan_xcoff_symtab): Update.
11166         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11167         "where".
11168         * mdebugread.c (parse_partial_symbols)
11169         (handle_psymbol_enumerators): Update.
11170         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11171         * dbxread.c (read_dbx_symtab): Update.
11172         * psympriv.h (psymbol_placement): New enum.
11173         (add_psymbol_to_list): Update.
11174
11175 2019-01-10  Tom Tromey  <tom@tromey.com>
11176
11177         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11178         static_psymbols parameters.
11179         (scan_xcoff_symtab): Update.
11180         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11181         static_psymbols parameters.
11182         * psympriv.h (start_psymtab_common): Update.
11183         * mdebugread.c (parse_partial_symbols): Update.
11184         * dwarf2read.c (create_partial_symtab): Update.
11185         * dbxread.c (read_dbx_symtab): Update.
11186         (start_psymtab): Remove global_psymbols and static_psymbols
11187         parameters.
11188
11189 2019-01-10  Tom Tromey  <tom@tromey.com>
11190
11191         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11192         * psymtab.c (allocate_psymtab): Add comment.
11193         * psympriv.h (allocate_psymtab): Add comment.
11194         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11195         initializations.
11196         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11197
11198 2019-01-10  Tom Tromey  <tom@tromey.com>
11199
11200         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11201         Don't declare.
11202         * mipsread.c: Include mdebugread.h.
11203         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11204         Declare.
11205         * elfread.c: Include mdebugread.h.
11206
11207 2019-01-09  Tom Tromey  <tom@tromey.com>
11208
11209         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11210         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11211         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11212         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11213         (psym_lookup_symbol, psym_find_last_source_symtab)
11214         (psym_forget_cached_source_info, psym_print_stats)
11215         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11216         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11217         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11218         (psym_find_compunit_symtab_by_address)
11219         (maintenance_print_psymbols, maintenance_info_psymtabs)
11220         (maintenance_check_psymtabs): Use ranged for.
11221         * psymtab.h (class objfile_psymtabs): New.
11222         (require_partial_symbols): Return objfile_psymtabs.
11223         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11224
11225 2019-01-09  Tom Tromey  <tom@tromey.com>
11226
11227         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11228         (find_pc_mapped_section, list_overlays_command)
11229         (map_overlay_command, unmap_overlay_command)
11230         (simple_overlay_update): Use all_objfiles.
11231         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11232         * printcmd.c (info_symbol_command): Use all_objfiles.
11233         * objfiles.h (ALL_OBJSECTIONS): Remove.
11234         * maint.c (maintenance_translate_address): Use all_objfiles.
11235         * gcore.c (gcore_create_callback): Use all_objfiles.
11236         (objfile_find_memory_regions): Likewise.
11237
11238 2019-01-09  Tom Tromey  <tom@tromey.com>
11239
11240         * symtab.c (find_line_symtab, info_sources_command)
11241         (make_source_files_completion_list): Use objfile_compunits.
11242         * source.c (select_source_symtab): Use objfile_compunits.
11243         * objfiles.h (struct objfile): Update comment.
11244         (ALL_OBJFILES): Remove.
11245         (ALL_FILETABS): Remove.
11246         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11247         objfile_compunits.
11248
11249 2019-01-09  Tom Tromey  <tom@tromey.com>
11250
11251         * symmisc.c (print_objfile_statistics, dump_objfile)
11252         (maintenance_print_symbols): Use compunit_filetabs.
11253         * source.c (forget_cached_source_info_for_objfile): Use
11254         compunit_filetabs.
11255         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11256         (ALL_FILETABS): Use compunit_filetabs.
11257         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11258         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11259
11260 2019-01-09  Tom Tromey  <tom@tromey.com>
11261
11262         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11263         (compunit_filetabs): New.
11264         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11265         compunit_filetabs.
11266         (info_sources_command, make_source_files_completion_list): Remove
11267         declaration.
11268         * symmisc.c (print_objfile_statistics, dump_objfile)
11269         (maintenance_print_symbols): Remove declaration.
11270         (maintenance_info_symtabs): Use compunit_filetabs.
11271         (maintenance_info_line_tables): Likewise.
11272         * source.c (select_source_symtab): Change local variable name.
11273         (forget_cached_source_info_for_objfile): Remove declaration.
11274         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11275         * objfiles.c (objfile_relocate1): Remove declaration.
11276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11277         declaration.
11278         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11279         * coffread.c (coff_symtab_read): Remove declaration.
11280         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11281         compunit_filetabs.
11282
11283 2019-01-09  Tom Tromey  <tom@tromey.com>
11284
11285         * symtab.c (lookup_objfile_from_block)
11286         (find_pc_sect_compunit_symtab, search_symbols)
11287         (default_collect_symbol_completion_matches_break_on): Use
11288         objfile_compunits.
11289         * objfiles.h (ALL_COMPUNITS): Remove.
11290         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11291         * cp-support.c (add_symbol_overload_list_qualified): Use
11292         objfile_compunits.
11293         * ada-lang.c (ada_collect_symbol_completion_matches)
11294         (ada_add_global_exceptions): Use objfile_compunits.
11295
11296 2019-01-09  Tom Tromey  <tom@tromey.com>
11297
11298         * source.c (select_source_symtab)
11299         (forget_cached_source_info_for_objfile): Remove declaration.
11300         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11301         declaration.
11302         * maint.c (count_symtabs_and_blocks): Remove declaration.
11303         * cp-support.c (add_symbol_overload_list_qualified): Remove
11304         declaration.
11305         * coffread.c (coff_symtab_read): Remove declaration.
11306         * symtab.c (lookup_symbol_in_objfile_symtabs)
11307         (basic_lookup_transparent_type_1): Use objfile_compunits.
11308         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11309         (info_sources_command, search_symbols)
11310         (default_collect_symbol_completion_matches_break_on)
11311         (make_source_files_completion_list): Remove declaration.
11312         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11313         (ada_collect_symbol_completion_matches)
11314         (ada_add_global_exceptions): Remove declaration.
11315         * linespec.c (iterate_over_all_matching_symtabs): Use
11316         objfile_compunits.
11317         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11318         (class objfile_compunits): New.
11319         (ALL_COMPUNITS): Use objfile_compunits.
11320         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11321         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11322         objfile_compunits.
11323         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11324
11325 2019-01-09  Tom Tromey  <tom@tromey.com>
11326
11327         * symtab.c (search_symbols)
11328         (default_collect_symbol_completion_matches_break_on): Use
11329         objfile_msymbols.
11330         * ada-lang.c (ada_lookup_simple_minsym)
11331         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11332         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11333         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11334         objfile_msymbols.
11335         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11336         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11337         * objc-lang.c (find_methods): Use objfile_msymbols.
11338         (info_selectors_command, info_classes_command): Likewise.
11339         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11340         * objfiles.h (class objfile_msymbols): New.
11341         (ALL_OBJFILE_MSYMBOLS): Remove.
11342         (ALL_MSYMBOLS): Remove.
11343
11344 2019-01-09  Tom Tromey  <tom@tromey.com>
11345
11346         * common/next-iterator.h (next_adapter): Add Iterator template
11347         parameter.
11348         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11349         (class all_objfiles_safe): New.
11350         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11351         * objfiles.c (put_objfile_before): Update comment.
11352         (add_separate_debug_objfile): Likewise.
11353         (free_all_objfiles): Use all_objfiles_safe.
11354         (objfile_purge_solibs): Likewise.
11355
11356 2019-01-09  Tom Tromey  <tom@tromey.com>
11357
11358         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11359         (expand_symtab_containing_pc, lookup_static_symbol)
11360         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11361         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11362         all_objfiles.
11363         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11364         * breakpoint.c (create_overlay_event_breakpoint)
11365         (create_longjmp_master_breakpoint)
11366         (create_std_terminate_master_breakpoint)
11367         (create_exception_master_breakpoint): Use all_objfiles.
11368         * linux-thread-db.c (try_thread_db_load_from_pdir)
11369         (has_libpthread): Use all_objfiles.
11370         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11371         * linespec.c (iterate_over_all_matching_symtabs)
11372         (search_minsyms_for_name): Use all_objfiles.
11373         * maint.c (maintenance_info_sections): Use all_objfiles.
11374         * main.c (captured_main_1): Use all_objfiles.
11375         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11376         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11377         * guile/scm-pretty-print.c
11378         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11379         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11380         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11381         (maintenance_print_msymbols): Use all_objfiles.
11382         * source.c (select_source_symtab): Use all_objfiles.
11383         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11384         * symfile.c (remove_symbol_file_command)
11385         (expand_symtabs_matching, map_symbol_filenames): Use
11386         all_objfiles.
11387         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11388         all_objfiles.
11389         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11390         * objc-lang.c (find_methods): Use all_objfiles.
11391         * objfiles.c (have_partial_symbols, have_full_symbols)
11392         (have_minimal_symbols, qsort_cmp)
11393         (default_iterate_over_objfiles_in_search_order): Use
11394         all_objfiles.
11395         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11396         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11397         (maintenance_check_psymtabs): Use all_objfiles.
11398         (ALL_PSYMTABS): Remove.
11399         * compile/compile-object-run.c (do_module_cleanup): Use
11400         all_objfiles.
11401         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11402         * cp-support.c (add_symbol_overload_list_qualified): Use
11403         all_objfiles.
11404         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11405         Use all_objfiles.
11406         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11407         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11408         all_objfiles.
11409         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11410         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11411         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11412         Uses all_objfiles.
11413         * solib.c (solib_read_symbols): Use all_objfiles
11414
11415 2019-01-09  Tom Tromey  <tom@tromey.com>
11416
11417         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11418         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11419         all_objfiles.
11420         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11421         * symmisc.c (print_symbol_bcache_statistics)
11422         (print_objfile_statistics, maintenance_print_objfiles)
11423         (maintenance_info_symtabs, maintenance_check_symtabs)
11424         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11425         all_objfiles.
11426         * source.c (forget_cached_source_info): Use all_objfiles.
11427         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11428         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11429         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11430         * objfiles.c (update_section_map): Use all_objfiles.
11431         (shared_objfile_contains_address_p): Likewise.
11432         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11433         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11434
11435 2019-01-09  Tom Tromey  <tom@tromey.com>
11436
11437         * common/next-iterator.h: New file.
11438         * objfiles.h (class all_objfiles): New.
11439         (struct objfile_iterator): New.
11440
11441 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11442
11443         * NEWS: Move the description of the changed "frame", "select-frame",
11444          and "info frame" commands to the Changed commands section.
11445
11446 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11447
11448         * gdbtypes.c (check_stub_method_group): Remove handling of old
11449         mangling schemes.
11450         * linespec.c (find_methods): Likewise.
11451         * stabsread.c (read_member_functions): Likewise.
11452         * valops.c (search_struct_method): Likewise.
11453         (value_struct_elt_for_reference): Likewise.
11454         * NEWS: Mention this change.
11455
11456 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11457
11458         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11459         print_source_lines.
11460         * source.c (print_source_lines_base): Update line number check.
11461         (print_source_lines): New function.
11462         (source_lines_range::source_lines_range): New function.
11463         * source.h (class source_lines_range): New class.
11464         (print_source_lines): New declaration.
11465
11466 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11467
11468         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11469
11470 2019-01-08  Tom Tromey  <tom@tromey.com>
11471             Simon Marchi  <simon.marchi@ericsson.com>
11472
11473         PR gdb/24060
11474         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11475         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11476         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11477         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11478         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11479         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11480
11481 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11482
11483         * source.c (select_source_symtab): Move header comment to
11484         declaration in source.h.
11485         (forget_cached_source_info_for_objfile): Likewise.
11486         (forget_cached_source_info): Likewise.
11487         (identify_source_line): Likewise.
11488         * source.h (identify_source_line): Move declaration from symtab.h
11489         and add comment from source.c
11490         (print_source_lines): Likewise.
11491         (forget_cached_source_info_for_objfile): Likewise.
11492         (forget_cached_source_info): Likewise.
11493         (select_source_symtab): Likewise.
11494         (enum print_source_lines_flag): Move definition from symtab.h.
11495         * symtab.h (identify_source_line): Move declaration to source.h.
11496         (print_source_lines): Likewise.
11497         (forget_cached_source_info_for_objfile): Likewise.
11498         (forget_cached_source_info): Likewise.
11499         (select_source_symtab): Likewise.
11500         (enum print_source_lines_flag): Move definition to source.h.
11501         * tui/tui-hooks.c: Add 'source.h' include.
11502
11503 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11504
11505         * source.c (print_source_lines_base): Handle requests to print
11506         reverse line number sequences, and guard against empty lines
11507         string.
11508
11509 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11510
11511         * source.c (print_source_lines_base): Fix skip of '\r' if next
11512         character is '\n'.
11513
11514 2019-01-06  Tom Tromey  <tom@tromey.com>
11515
11516         * c-exp.y (struct c_parse_state) <macro_original_text,
11517         expansion_obstack>: New member.
11518         (macro_original_text, expansion_obstack): Remove globals.
11519         (scan_macro_expansion, scanning_macro_expansion)
11520         (finished_macro_expansion): Update.
11521         (scan_macro_cleanup): Remove.
11522         (yylex, c_parse): Update.
11523
11524 2019-01-06  Tom Tromey  <tom@tromey.com>
11525
11526         * c-exp.y (struct c_parse_state) <strings>: New member.
11527         (operator_stoken): Update.
11528
11529 2019-01-06  Tom Tromey  <tom@tromey.com>
11530
11531         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11532         (union type_stack_elt) <typelist_val>: Now a pointer to
11533         std::vector.
11534         (type_stack_cleanup): Don't declare.
11535         (push_typelist): Update.
11536         * parse.c (pop_typelist): Return a std::vector.
11537         (push_typelist): Take a std::vector.
11538         (follow_types): Update.  Do not free args.
11539         (type_stack_cleanup): Remove.
11540         * c-exp.y (struct c_parse_state): New.
11541         (cpstate): New global.
11542         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11543         (nonempty_typelist): Update.
11544         (func_mod): Create a new vector.
11545         (c_parse): Create a c_parse_state.
11546         (check_parameter_typelist): Do not delete params.
11547         (function_method): Update.  Do not delete type_list.
11548
11549 2019-01-06  Tom Tromey  <tom@tromey.com>
11550
11551         PR gdb/28155:
11552         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11553         check_typedef.
11554         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11555         (print_return_value): Likewise.
11556
11557 2019-01-05  Tom Tromey  <tom@tromey.com>
11558
11559         * contrib/cleanup_check.py: Remove.
11560         * contrib/gcc-with-excheck: Remove.
11561         * contrib/exsummary.py: Remove.
11562         * contrib/excheck.py: Remove.
11563
11564 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11565
11566         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11567         NULL. Initialize tpprev to NULL instead of assigning it
11568         to NULL on the next statement.
11569         * windows-nat.c (windows_delete_thread): Remove check for
11570         main_thread_id before printing thread exit notifications.
11571         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11572         Remove thread ID check against main_thread_id.
11573         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11574         windows_delete_thread.
11575         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11576
11577 2019-01-04  Tom Tromey  <tom@tromey.com>
11578
11579         * compile/compile.c (_initialize_compile): Use upper case for
11580         metasyntactic variables.
11581         * symmisc.c (_initialize_symmisc): Use upper case for
11582         metasyntactic variables.
11583         * psymtab.c (_initialize_psymtab): Use upper case for
11584         metasyntactic variables.
11585         * demangle.c (demangle_command): Use upper case for metasyntactic
11586         variables.
11587         (_initialize_demangler): Likewise.
11588         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11589         variables.
11590
11591 2019-01-03  Tom Tromey  <tom@tromey.com>
11592
11593         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11594
11595 2019-01-03  Tom Tromey  <tom@tromey.com>
11596
11597         * python/py-symtab.c (salpy_str): Update.
11598         (struct salpy_sal_object) <symtab>: Now a PyObject.
11599         (salpy_dealloc): Update.
11600         (del_objfile_sal): Use gdbpy_ref.
11601
11602 2019-01-03  Tom Tromey  <tom@tromey.com>
11603
11604         * python/py-type.c (convert_field): Use new_reference.  Return
11605         gdbpy_ref.
11606         (make_fielditem): Return gdbpy_ref.
11607         (typy_fields): Update.
11608         (typy_getitem): Update.
11609         (field_name): Return gdbpy_ref.  Use new_reference.
11610         (typy_iterator_iternext): Update.
11611
11612 2019-01-03  Tom Tromey  <tom@tromey.com>
11613
11614         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11615
11616 2019-01-03  Tom Tromey  <tom@tromey.com>
11617
11618         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11619         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11620         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11621         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11622         (pspy_set_type_printers): Likewise.
11623         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11624         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11625         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11626         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11627         (objfpy_set_type_printers): Likewise.
11628
11629 2019-01-03  Tom Tromey  <tom@tromey.com>
11630
11631         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11632         (gdbpy_print_stack): Use gdbpy_err_fetch.
11633         * python/python-internal.h (class gdbpy_err_fetch): New class.
11634         (class gdbpy_enter) <m_error_type, m_error_value,
11635         m_error_traceback>: Remove.
11636         <m_error>: New member.
11637         (gdbpy_exception_to_string): Don't declare.
11638         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11639         * python/py-value.c (convert_value_from_python): Use
11640         gdbpy_err_fetch.
11641         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11642         gdbpy_exception_to_string.
11643         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11644         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11645         gdbpy_err_fetch.
11646
11647 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11648
11649         * linux-nat.c (delete_lwp_cleanup): Delete.
11650         (struct lwp_deleter): New struct.
11651         (lwp_info_up): New typedef.
11652         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11653         lwp_info_up.
11654
11655 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11656
11657         * linux-fork.c (class scoped_switch_fork_info): New class.
11658         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11659
11660 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11661
11662         * valops.c (find_overload_match): Remove use of null_cleanup, and
11663         calls to do_cleanups.
11664
11665 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11666
11667         * compile/compile-cplus-types.c
11668         (compile_cplus_instance::decl_name): Handle changes to
11669         cp_func_name.
11670         * cp-support.c (cp_func_name): Update header comment, update
11671         return type.
11672         * cp-support.h (cp_func_name): Update return type in declaration.
11673         * valops.c (find_overload_match): Move temp_func local to top
11674         level of function and change its type.  Use temp_func to hold and
11675         delete temporary string obtained from cp_func_name.
11676
11677 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11678
11679         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11680         gdb::char_vector, remove cleanup, and update uses of `msg`.
11681
11682 2019-01-03  Jim Wilson  <jimw@sifive.com>
11683
11684         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11685
11686 2019-01-02  Tom Tromey  <tom@tromey.com>
11687
11688         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11689         (tdesc_parse_xml): Remove cleanups.
11690         * target-descriptions.h (make_cleanup_free_target_description):
11691         Don't declare.
11692         (target_desc_deleter): New struct.
11693         (target_desc_up): New typedef.
11694         * target-descriptions.c (target_desc_deleter::operator()): Rename
11695         from free_target_description.
11696         (make_cleanup_free_target_description): Remove.
11697
11698 2019-01-02  Tom Tromey  <tom@tromey.com>
11699
11700         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11701         constructor, destructor.
11702         (linespec_parser): Remove typedef.
11703         (~linespec_parser): Rename from linespec_parser_delete.
11704         (linespec_lex_to_end, linespec_complete_label)
11705         (linespec_complete): Update.
11706         (decode_line_full): Remove cleanups.
11707         (decode_line_1): Update.
11708
11709 2019-01-02  Tom Tromey  <tom@tromey.com>
11710
11711         * python/python-internal.h (inferior_to_inferior_object): Change
11712         return type.
11713         * python/py-exitedevent.c (create_exited_event_object): Update.
11714         * python/py-inferior.c (inferior_to_inferior_object): Return
11715         gdbpy_ref.
11716         (python_new_inferior, python_inferior_deleted)
11717         (thread_to_thread_object, delete_thread_object)
11718         (build_inferior_list, gdbpy_selected_inferior): Update.
11719         * python/py-infthread.c (create_thread_object): Update.  Also fail
11720         if inferior_to_inferior_object fails.
11721
11722 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11723
11724         * inferior.h (class inferior) <displaced_step_state>: New field.
11725         * infrun.h (struct displaced_step_state): Move here from
11726         infrun.c.  Initialize fields, add constructor.
11727         <inf>: Remove field.
11728         <reset>: New method.
11729         * infrun.c (struct displaced_step_inferior_state): Move to
11730         infrun.h.
11731         (displaced_step_inferior_states): Remove.
11732         (get_displaced_stepping_state): Adust.
11733         (displaced_step_in_progress_any_inferior): Adjust.
11734         (displaced_step_in_progress_thread): Adjust.
11735         (displaced_step_in_progress): Adjust.
11736         (add_displaced_stepping_state): Remove.
11737         (get_displaced_step_closure_by_addr): Adjust.
11738         (remove_displaced_stepping_state): Remove.
11739         (infrun_inferior_exit): Call displaced_step_state.reset.
11740         (use_displaced_stepping): Don't check for NULL.
11741         (displaced_step_prepare_throw): Call
11742         get_displaced_stepping_state.
11743         (displaced_step_fixup): Don't check for NULL.
11744         (prepare_for_detach): Don't check for NULL.
11745
11746 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11747
11748         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11749          in case of call that did not complete.
11750
11751 2019-01-02  Andrey Utkin  <autkin@undo.io>
11752
11753         * symfile.c (find_separate_debug_file): Fix search of debug files for
11754         remote debuggee.
11755
11756 2019-01-02  Tom Tromey  <tom@tromey.com>
11757
11758         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11759         indentation.
11760         * python/py-frame.c (frapy_older): Remove cast.
11761         (frapy_newer): Likewise.
11762         * python/py-breakpoint.c (local_setattro): Remove cast.
11763         * python/py-arch.c (archpy_name): Remove local variable.
11764         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11765
11766 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11767
11768         * unittests/basic_string_view/element_access/char/empty.cc:
11769         Fix year range in copyright header.
11770
11771 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11772
11773         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11774         Delete.
11775         <operator==>: Update with for removed field.
11776         <hash>: Likewise.
11777         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11778         <isa_features>: ...this.
11779         <abi_features>: New field.
11780         (riscv_isa_flen): Update comment.
11781         (riscv_abi_xlen): New declaration.
11782         (riscv_abi_flen): New declaration.
11783         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11784         isa_features.
11785         (riscv_abi_xlen): New function.
11786         (riscv_isa_flen): Update to get answer from isa_features.
11787         (riscv_abi_flen): New function.
11788         (riscv_has_fp_abi): Update to get answer from abi_features.
11789         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11790         xlen and flen.
11791         (riscv_call_info) <xlen, flen>: Update comment.
11792         (riscv_call_arg_struct): Remove invalid assertions
11793         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11794         is removed.
11795         (riscv_gdbarch_init): Gather isa features and abi features
11796         separately, ensure both match on the gdbarch when reusing an old
11797         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11798         a target with 64-bit float hardware.
11799
11800 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11801
11802         * source.c (search_command_helper): Stop reverse search
11803         when line 1 has been searched.
11804
11805 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11806
11807         * record-full.c (record_full_base_target::close): Rewrite
11808         record_full_core_buf_list free logic.
11809
11810 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11811
11812         * break-catch-syscall.c (print_one_catch_syscall): xfree
11813         the last text.
11814
11815 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11816
11817         * top.c (print_gdb_version): Update Copyright year in version
11818         message.
11819
11820 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11821
11822         Update copyright year range in all GDB files.
11823
11824 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11825
11826         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11827
11828 For older changes see ChangeLog-2018.
11829 \f
11830 Local Variables:
11831 mode: change-log
11832 left-margin: 8
11833 fill-column: 74
11834 version-control: never
11835 coding: utf-8
11836 End:
11837