gdb/ChangeLog

   1 2019-06-19  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (tui_init_win_info): Don't declare.
   4
   5 2019-06-19  Tom de Vries  <tdevries@suse.de>
   6
   7         * dwarf2read.h (abstract_to_concrete): Change type to
   8         std::unordered_map<sect_offset, std::vector<sect_offset>,
   9         gdb::hash_enum<sect_offset>>.
  10
  11 2019-06-19  Tom Tromey  <tromey@adacore.com>
  12
  13         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  14         EVAL_AVOID_SIDE_EFFECTS specially.
  15
  16 2019-06-19  Tom Tromey  <tromey@adacore.com>
  17
  18         * source-cache.c (highlighter): New global.
  19         (source_cache::get_source_lines): Create a highlighter on demand.
  20
  21 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  22
  23         * defs.h (deprecated_interactive_hook): Delete declaration.
  24         * interps.c (clear_interpreter_hooks): Remove use of
  25         deprecated_interactive_hook.
  26         * top.c (deprecated_interactive_hook): Delete definition.
  27         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  28
  29 2019-06-18  Tom de Vries  <tdevries@suse.de>
  30
  31         PR gdb/24515
  32         * dwarf2read.h (abstract_to_concrete): Change type from
  33         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  34         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  35         * dwarf2read.c (read_variable): Update.
  36         (dwarf2_fetch_die_loc_sect_off): Update.
  37
  38 2019-06-17  Tom de Vries  <tdevries@suse.de>
  39
  40         PR gdb/24617
  41         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  42         accessing parent[parent_len - 1].
  43
  44 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  45
  46         PR gdb/24364
  47         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  48         call dtrace_process_dof with NULL dof.
  49
  50 2019-06-16  Tom de Vries  <tdevries@suse.de>
  51
  52         PR gdb/24445
  53         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  54
  55 2019-06-16  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  58         (make_all_visible): Use address of member.
  59
  60 2019-06-16  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  63         (tui_free_window, free_content, free_content_elements): Remove
  64         unnecessary cast.
  65         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  66         cast.
  67         * tui/tui-regs.c (tui_show_register_group)
  68         (tui_display_registers_from, tui_display_reg_element_at_line):
  69         Remove unnecessary cast.
  70
  71 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
  72
  73         * linux-nat.c (normal_mask): Delete.
  74         (_initialize_linux_nat): Don't initialise normal_mask.
  75
  76 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         PR gdb/24445
  79         * dwarf-index-write.h (write_psymtabs_to_index): Add
  80         dwz_basename parameter.
  81         * dwarf-index-write.c (write_gdbindex): Move file writing to
  82         write_gdbindex_1.  Change return type void.
  83         (assert_file_size): Move up, remove filename parameter.
  84         (write_gdbindex_1): New function.
  85         (write_debug_names): Change return type to void, call
  86         assert_file_size.
  87         (struct index_wip_file): New struct.
  88         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
  89         file logic to index_wip_file.  Write index for dwz file if
  90         needed.
  91         (save_gdb_index_command): Pass basename of dwz file, if present.
  92         * dwarf-index-cache.c (index_cache::store): Obtain and pass
  93         build-id of dwz file, if present.
  94         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
  95         (dwarf2_get_dwz_file): Likewise.
  96         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
  97         (dwarf2_get_dwz_file): Likewise.
  98
  99 2019-06-16  Tom Tromey  <tom@tromey.com>
 100
 101         * coffread.c (process_coff_symbol): Use xstrdup.
 102         * value.c (create_internalvar): Use xstrdup.
 103
 104 2019-06-16  Tom Tromey  <tom@tromey.com>
 105
 106         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 107         * breakpoint.c (stopin_command, stopat_command)
 108         (until_break_command, decode_location_default): Remove unnecessary
 109         cast.
 110         * utils.c (subset_compare): Remove unnecessary cast.
 111         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 112         cast.
 113         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 114         cast.
 115         * infcmd.c (path_command): Remove unnecessary cast.
 116         * coffread.c (decode_type): Remove unnecessary cast.
 117         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 118         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 119         * tui/tui-stack.c (tui_show_locator_content)
 120         (tui_show_frame_info): Remove unnecessary cast.
 121         * tui/tui-win.c (tui_scroll_forward_command)
 122         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 123         (parse_scrolling_args): Remove unnecessary cast.
 124         * tui/tui-data.c (init_win_info, tui_del_window)
 125         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 126         (free_content_elements): Remove unnecessary cast.
 127         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 128         unnecessary cast.
 129         * tui/tui-source.c (tui_set_source_content)
 130         (tui_vertical_source_scroll): Remove unnecessary cast.
 131         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 132         cast.
 133         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 134         * tui/tui-regs.c (tui_display_registers_from)
 135         (tui_display_register): Remove unnecessary cast.
 136         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 137         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 138         (make_visible): Remove unnecessary cast.
 139         * tui/tui-winsource.c (tui_erase_source_content)
 140         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 141         unnecessary cast.
 142         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 143         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 144         * stabsread.c (read_type, read_array_type, read_range_type):
 145         Remove unnecessary cast.
 146         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 147         (parse_symbol, parse_type, upgrade_type, parse_external)
 148         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 149         unnecessary cast.
 150         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 151
 152 2019-06-16  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-data.c (tui_alloc_generic_win_info)
 155         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 156         checks.
 157
 158 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 159             Andrew Burgess  <andrew.burgess@embecosm.com>
 160
 161         * f-typeprint.c (f_print_type): Don't return early for not
 162         associated or not allocated types.
 163         (f_type_print_varspec_suffix): Add print_rank parameter and print
 164         ranks of array types in case they dangling.
 165         (f_type_print_base): Add print_rank parameter.
 166
 167 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 168
 169         * NEWS: Mention new MI commands.
 170         * break-catch-throw.c (enum exception_event_kind): Move to
 171         breakpoint.h.
 172         (print_mention_exception_catchpoint): Output text as a single
 173         message.
 174         (catch_exception_command_1): Rename to...
 175         (catch_exception_event): ...this, make non-static, update header
 176         command, and change some parameter types.
 177         (catch_catch_command): Update for changes to
 178         catch_exception_command_1.
 179         (catch_throw_command): Likewise.
 180         (catch_rethrow_command): Likewise.
 181         * breakpoint.c (enum exception_event_kind): Delete.
 182         * breakpoint.h (enum exception_event_kind): Moved here from
 183         break-catch-throw.c.
 184         (catch_exception_event): Declare.
 185         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 186         (mi_cmd_catch_throw): New function.
 187         (mi_cmd_catch_rethrow): New function.
 188         (mi_cmd_catch_catch): New function.
 189         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 190         'catch-catch' entries.
 191         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 192         (mi_cmd_catch_rethrow): Declare.
 193         (mi_cmd_catch_catch): Declare.
 194
 195 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         * annotate.c (annotate_source_line): Change return type to void,
 198         update implementation to match.
 199         * annotate.h (annotate_source_line): Change return type to void,
 200         update header comment.
 201         * stack.c (print_frame_info): Don't change what frame information
 202         is printed based on whether annotations are on or not.
 203
 204 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 205
 206         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 207         (annotate_source): Make static.
 208         (annotate_source_line): Moved from source.c and renamed from
 209         identify_source_line.  Update the return type.
 210         * annotate.h (annotate_source): Delete declaration.
 211         (annotate_source_line): Declaration moved from source.h, and
 212         renamed from identify_source_line.  Return type updated.
 213         * source.c (identify_source_line): Moved to annotate.c and renamed
 214         to annotate_source_line.
 215         (info_line_command): Remove check of annotation_level.
 216         * source.h (identify_source_line): Move declaration to annotate.h
 217         and rename to annotate_source_line.
 218         * stack.c: Add 'annotate.h' include.
 219         (print_frame_info): Remove check of annotation_level before
 220         calling annotate_source_line.
 221
 222 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 223
 224         * source-cache.c (source_cache::get_plain_source_lines): Use
 225         open_source_file_with_line_charpos instead of just
 226         open_source_file, remove call to find_source_lines.
 227         (source_cache::get_source_lines): Likewise.
 228         * source.c (find_source_lines): Make static.
 229         (get_filename_and_charpos): Renamed into...
 230         (open_source_file_with_line_charpos): ..this along with changes to
 231         return a scoped_fd, and some other minor clean ups.
 232         (identify_source_line): Use open_source_file_with_line_charpos.
 233         (search_command_helper): Use open_source_file_with_line_charpos
 234         instead of just open_source_file, remove call to
 235         find_source_lines.
 236         * source.h (open_source_file_with_line_charpos): Declare new
 237         function.
 238         (find_source_lines): Delete declaration.
 239
 240 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 241
 242         * source.c (get_filename_and_charpos): Remove fullname
 243         parameter.
 244         (identify_source_line): Update call to get_filename_and_charpos.
 245
 246 2019-06-14  Tom Tromey  <tromey@adacore.com>
 247
 248         PR gdb/24502:
 249         * ui-style.h (skip_ansi_escape): Update comment.
 250         * ui-file.h (class no_terminal_escape_file): New class.
 251         * ui-file.c (no_terminal_escape_file::write)
 252         (no_terminal_escape_file::puts): New methods.
 253         * cli/cli-logging.c (handle_redirections): Use
 254         no_terminal_escape_file.
 255
 256 2019-06-14  Tom Tromey  <tromey@adacore.com>
 257
 258         * NEWS: Move convenience variable news above Python news.
 259
 260 2019-06-14  Tom Tromey  <tom@tromey.com>
 261
 262         * gnulib: Move directory to top-level.
 263         * configure.ac: Don't configure gnulib.
 264         * configure: Rebuild.
 265         * common/common-defs.h: Use new path to gnulib.
 266         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 267         (GNULIB_H): Remove.
 268         (INCGNU): Look in new gnulib location.
 269         (HFILES_NO_SRCDIR): Remove gnulib files.
 270         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 271         (generated_files): Remove GNULIB_H.
 272         ($(LIBGNU), all-lib): Remove targets.
 273         (distclean): Don't mention GNULIB_BUILDDIR.
 274         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 275
 276 2019-06-14  Tom Tromey  <tromey@adacore.com>
 277
 278         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 279         Warn if symbol file does not provide any symbols.
 280
 281 2019-06-14  Tom Tromey  <tromey@adacore.com>
 282
 283         * source.c (find_and_open_source): Respect basenames_may_differ.
 284
 285 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * annotate.c (annotate_breakpoints_invalid): Make use of
 288         scoped_restore_terminal_state.
 289         (annotate_frames_invalid): Likewise.
 290
 291 2019-06-14  Tom Tromey  <tromey@adacore.com>
 292
 293         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 294         allow assignment to an internalvar.
 295
 296 2019-06-14  Tom Tromey  <tromey@adacore.com>
 297
 298         * ada-lex.l: Allow "_" in attribute names.
 299
 300 2019-06-14  Tom Tromey  <tromey@adacore.com>
 301
 302         PR gdb/24653:
 303         * regcache.c (registers_changed): Don't call alloca.
 304         * top.c (execute_command): Don't call alloca.
 305
 306 2019-06-13  Pedro Alves  <palves@redhat.com>
 307
 308         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 309         'expression'.  When parsing an expression, error out if there's
 310         junk after "unlimited".
 311         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 312         (do_set_command): Adjust calls to is_unlimited_literal.
 313
 314 2019-06-13  Pedro Alves  <palves@redhat.com>
 315
 316         * compile/compile.c (make_compile_options_def_group): Add braces
 317         around array_view initializer.
 318         * thread.c (make_thread_apply_all_options_def_group)
 319         (make_thread_apply_all_options_def_group): Likewise.
 320
 321 2019-06-13  Pedro Alves  <palves@redhat.com>
 322
 323         * NEWS (New commands): Mention "maint test-options
 324         require-delimiter", "maint test-options unknown-is-error", "maint
 325         test-options unknown-is-operand" and "maint show
 326         test-options-completion-result".
 327         (New command options, command completion): New section.
 328         (Completion improvements): New section.
 329         Mention that you can abbreviate "unlimited".
 330
 331 2019-06-13  Pedro Alves  <palves@redhat.com>
 332
 333         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 334         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 335         * unittests/cli-utils-selftests.c (test_parse_flags)
 336         (test_parse_flags_qcs): Delete.
 337         (test_cli_utils): Don't call deleted functions.
 338
 339 2019-06-13  Pedro Alves  <palves@redhat.com>
 340
 341         * thread.c: Include "cli/cli-option.h".
 342         (tp_array_compar_ascending): Global.
 343         (tp_array_compar): Delete function.
 344         (tp_array_compar_ascending, tp_array_compar_descending): New
 345         functions.
 346         (ascending_option_def, qcs_flag_option_def)
 347         (thr_qcs_flags_option_defs)
 348         (make_thread_apply_all_options_def_group)
 349         (make_thread_apply_options_def_group): New.
 350         (thread_apply_all_command): Use gdb::option::process_options.
 351         (thread_apply_command_completer)
 352         (thread_apply_all_command_completer): New.
 353         (thread_apply_command): Use gdb::option::process_options.
 354         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 355         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 356         to generate help text of "thread apply".  Adjust "taas"'s help.
 357         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 358         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 359
 360 2019-06-13  Pedro Alves  <palves@redhat.com>
 361
 362         * thread.c (thread_apply_command): Check for invalid TID with
 363         isdigit instead of !isalpha.
 364
 365 2019-06-13  Pedro Alves  <palves@redhat.com>
 366
 367         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 368         (validate_flags_qcs): New.
 369         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 370         (validate_flags_qcs): Declare.
 371         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 372         (make_frame_apply_options_def_group): New.
 373         (frame_apply_command_count): Process options with
 374         gdb::option::process_options.
 375         (frame_apply_completer): New.
 376         (frame_apply_level_completer, frame_apply_all_completer)
 377         (frame_apply_completer): New.
 378         (_initialize_stack): Update help of "frame apply", "frame apply
 379         level", "frame apply all" and "faas" to mention supported options
 380         and install command completers.
 381         * stack.h (frame_apply_all_completer): Declare.
 382         * thread.c: Include "stack.h".
 383         (tfaas_command): Add "--".
 384         (_initialize_thread): Update help "tfaas" to mention supported
 385         options and install command completer.
 386
 387 2019-06-13  Pedro Alves  <palves@redhat.com>
 388
 389         * completer.c (complete_nested_command_line): New.
 390         (gdb_completion_word_break_characters_throw): Add assertion.
 391         * completer.h (complete_nested_command_line): Declare.
 392
 393 2019-06-13  Pedro Alves  <palves@redhat.com>
 394
 395         * stack.c (parse_backtrace_qualifiers): New.
 396         (backtrace_command): Use it.
 397         (backtrace_command_completer): Complete on qualifiers.
 398
 399 2019-06-13  Pedro Alves  <palves@redhat.com>
 400
 401         * frame.c: Include "cli/cli-option.h.
 402         (user_set_backtrace_options): New.
 403         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 404         Delete.
 405         (get_prev_frame): Adjust.
 406         (boolean_option_def, uinteger_option_def)
 407         (set_backtrace_option_defs): New.
 408         (_initialize_frame): Adjust and use
 409         gdb::option::add_setshow_cmds_for_options to install "set
 410         backtrace past-main" and "set backtrace past-entry".
 411         * frame.h: Include "cli/cli-option.h".
 412         (struct frame_print_options): Forward declare.
 413         (print_frame_arguments_all, print_frame_arguments_scalars)
 414         (print_frame_arguments_none): Declare.
 415         (print_entry_values): Delete declaration.
 416         (struct frame_print_options, user_frame_print_options): New.
 417         (struct set_backtrace_options): New.
 418         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 419         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 420         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 421         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 422         (list_args_or_locals): Add frame_print_options parameter.
 423         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 424         * python/py-framefilter.c (enumerate_args): Pass down
 425         USER_FRAME_PRINT_OPTIONS.
 426         * stack.c: Include "cli/cli-option.h".
 427         (print_frame_arguments_all, print_frame_arguments_scalars)
 428         (print_frame_arguments_none): Declare.
 429         (print_raw_frame_arguments, print_entry_values): Delete.
 430         (user_frame_print_options): New.
 431         (boolean_option_def, enum_option_def, frame_print_option_defs):
 432         New.
 433         (struct backtrace_cmd_options): New.
 434         (bt_flag_option_def): New.
 435         (backtrace_command_option_defs): New.
 436         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 437         (print_frame_arg, read_frame_arg, print_frame_args)
 438         (print_frame_info, print_frame): Add frame_print_options parameter
 439         and use it.
 440         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 441         (backtrace_command_1): Add frame_print_options and
 442         backtrace_cmd_options parameters and use them.
 443         (make_backtrace_options_def_group): New.
 444         (backtrace_command): Process command options with
 445         gdb::option::process_options.
 446         (backtrace_command_completer): New.
 447         (_initialize_stack): Extend "backtrace"'s help to mention
 448         supported options.  Install completer for "backtrace".
 449         Install some settings commands with add_setshow_cmds_for_options.
 450
 451 2019-06-13  Pedro Alves  <palves@redhat.com>
 452
 453         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 454         and that "set/show print raw frame-arguments" are now deprecated.
 455
 456         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 457         command.
 458         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 459         * stack.c (_initialize_stack): Install "set/show print
 460         raw-frame-arguments", and deprecate "set/show print raw
 461         frame-arguments".
 462         * valprint.c (_initialize_valprint): Deprecate "set/show print
 463         raw".
 464
 465 2019-06-13  Pedro Alves  <palves@redhat.com>
 466
 467         * compile/compile.c (struct compile_options): New.
 468         (compile_flag_option_def, compile_command_option_defs)
 469         (make_compile_options_def_group): New.
 470         (compile_file_command): Handle options with
 471         gdb::option::process_options.
 472         (compile_file_command_completer): New function.
 473         (compile_code_command): Handle options with
 474         gdb::option::process_options.
 475         (compile_code_command_completer): New function.
 476         (_initialize_compiler): Install completers for "compile code" and
 477         "compile file".  Mention available options in "compile code" and
 478         "compile code"'s help.
 479         * completer.c (advance_to_completion_word): New, factored out from
 480         ...
 481         (advance_to_expression_complete_word_point): ... this.
 482         (advance_to_filename_complete_word_point): New.
 483         * completer.h (advance_to_filename_complete_word_point): New
 484         declaration.
 485
 486 2019-06-13  Pedro Alves  <palves@redhat.com>
 487
 488         * compile/compile.c: Include "cli/cli-option.h".
 489         (compile_print_value): Scope data pointer is now a
 490         value_print_options pointer; adjust.
 491         (compile_print_command): Process options.  Scope data pointer is
 492         now a value_print_options pointer; adjust.
 493         (_initialize_compile): Update "compile print"'s help to include
 494         supported options.  Install a completer for "compile print".
 495         * cp-valprint.c (show_vtblprint, show_objectprint)
 496         (show_static_field_print): Delete.
 497         (_initialize_cp_valprint): Don't install "set print
 498         static-members", "set print vtbl", "set print object" here.
 499         * printcmd.c: Include "cli/cli-option.h" and
 500         "common/gdb_optional.h".
 501         (print_command_parse_format): Rework to fill in a
 502         value_print_options instead of a format_data.
 503         (print_value): Change parameter type from format_data pointer to
 504         value_print_options reference.  Adjust.
 505         (print_command_1): Process options.  Adjust to pass down a
 506         value_print_options.
 507         (print_command_completer): New.
 508         (_initialize_printcmd): Install print_command_completer as
 509         handle_brkchars completer for the "print" command.  Update
 510         "print"'s help to include supported options.
 511         * valprint.c: Include "cli/cli-option.h".
 512         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 513         here from cp-valprint.c.
 514         (boolean_option_def, uinteger_option_def)
 515         (value_print_option_defs, make_value_print_options_def_group):
 516         New.  Use gdb::option::add_setshow_cmds_for_options to install
 517         "set print elements", "set print null-stop", "set print repeats",
 518         "set print pretty", "set print union", "set print array", "set
 519         print address", "set print symbol", "set print array-indexes".
 520         * valprint.h: Include <string> and "cli/cli-option.h".
 521         (make_value_print_options_def_group): Declare.
 522         (print_value): Change parameter type from format_data pointer to
 523         value_print_options reference.
 524         (print_command_completer): Declare.
 525
 526 2019-06-13  Pedro Alves  <palves@redhat.com>
 527
 528         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 529         (COMMON_SFILES): Add maint-test-settings.c.
 530         * cli/cli-decode.c (boolean_enums): New global, factored out from
 531         ...
 532         (add_setshow_boolean_cmd): ... here.
 533         * cli/cli-decode.h (boolean_enums): Declare.
 534         * cli/cli-option.c: New file.
 535         * cli/cli-option.h: New file.
 536         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 537         factored out from ...
 538         (parse_cli_boolean_value(const char *)): ... this.
 539         (is_unlimited_literal): Change parameter type to pointer to
 540         pointer.  Adjust and advance ARG pointer.
 541         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 542         (parse_cli_var_enum): New, factored out from ...
 543         (do_set_command): ... this.  Adjust.
 544         * cli/cli-setshow.h (parse_cli_boolean_value)
 545         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 546         (parse_cli_var_enum): Declare.
 547         * cli/cli-utils.c: Include "cli/cli-option.h".
 548         (get_ulongest): New.
 549         * cli/cli-utils.h (get_ulongest): Declare.
 550         (check_for_argument): New overloads.
 551         * maint-test-options.c: New file.
 552
 553 2019-06-13  Pedro Alves  <palves@redhat.com>
 554
 555         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 556         parse a range if "-" is at the end of the string.
 557
 558 2019-06-13  Pedro Alves  <palves@redhat.com>
 559
 560         * cli/cli-setshow.c (parse_auto_binary_operation)
 561         (parse_cli_boolean_value): Don't allow "o".
 562
 563 2019-06-13  Pedro Alves  <palves@redhat.com>
 564
 565         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 566         * NEWS: Mention maint test-settings KIND.
 567         * maint-test-settings.c: New file.
 568
 569 2019-06-13  Pedro Alves  <palves@redhat.com>
 570
 571         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 572         completer.
 573         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 574         "set" completers.
 575
 576 2019-06-13  Pedro Alves  <palves@redhat.com>
 577
 578         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 579         after item.
 580
 581 2019-06-13  Pedro Alves  <palves@redhat.com>
 582
 583         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 584
 585 2019-06-13  Pedro Alves <palves@redhat.com>
 586
 587         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 588         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 589         call.
 590         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 591         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 592         calls.
 593         (check_for_argument): Skip spaces after argument.
 594
 595 2019-06-13  Pedro Alves  <palves@redhat.com>
 596
 597         * thread.c (thread_apply_command): Adjust TID parsing.
 598         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 599         detected before end of string.
 600         (tid_is_in_list): Error out if LIST is invalid.
 601
 602 2019-06-13  Pedro Alves  <palves@redhat.com>
 603
 604         * completer.c (complete_line_internal_1): Rewind completion word
 605         point.
 606         (completion_tracker::advance_custom_word_point_by): Change
 607         parameter type to int.
 608         * completer.h (completion_tracker::advance_custom_word_point_by):
 609         Likewise.
 610
 611 2019-06-13  Pedro Alves  <palves@redhat.com>
 612
 613         * completer.c (advance_to_completion_word): Handle delimiters.
 614
 615 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 616
 617         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 618
 619 2019-06-11  Tom Tromey  <tom@tromey.com>
 620
 621         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 622         (xmalloc_failed): Move to alloc.c.
 623         * alloc.c: New file.
 624         * Makefile.in (COMMON_SFILES): Add alloc.c.
 625
 626 2019-06-11  Tom Tromey  <tom@tromey.com>
 627
 628         * nat/linux-waitpid.c: Don't include server.h.
 629         (linux_debug): Remove.
 630         (my_waitpid): Update.
 631
 632 2019-06-11  Tom Tromey  <tromey@adacore.com>
 633
 634         * infcall.c (_initialize_infcall): Remove trailing newline from
 635         help.
 636         * user-regs.c (_initialize_user_regs): Remove trailing newline
 637         from help.
 638         * typeprint.c (_initialize_typeprint): Remove trailing newline
 639         from help.
 640         * reverse.c (_initialize_reverse): Remove trailing newlines from
 641         help.
 642         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 643         from help.
 644         * language.c (add_set_language_command): Remove trailing newline
 645         from help.
 646         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 647         help.
 648         * disasm.c (_initialize_disasm): Remove trailing newline from
 649         help.
 650         * top.c (init_main): Remove trailing newline from help.
 651         * interps.c (_initialize_interpreter): Remove trailing newline
 652         from help.
 653         * btrace.c (_initialize_btrace): Remove trailing newlines from
 654         help.
 655         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 656         from help.
 657         * python/python.c (_initialize_python): Remove trailing newline
 658         from help.
 659         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 660         help.
 661         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 662         from help.  Reformat some text.
 663         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 664         from help.
 665         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 666         newline from help.
 667
 668 2019-06-11  Tom Tromey  <tromey@adacore.com>
 669
 670         * darwin-nat.c (darwin_decode_exception_message)
 671         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 672
 673 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * valops.c (value_slice): Check for not allocated or not
 676         associated values.
 677
 678 2019-06-10  Tom de Vries  <tdevries@suse.de>
 679
 680         PR gdb/24618
 681         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 682         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 683         invalid.
 684
 685 2019-06-10  Tom de Vries  <tdevries@suse.de>
 686
 687         PR gdb/24611
 688         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 689         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 690
 691 2019-06-10  Tom de Vries  <tdevries@suse.de>
 692
 693         PR symtab/24545
 694         * symtab.c (struct demangled_name_entry): Add language field.
 695         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 696         static minimal symbol".  Set and use language field.
 697
 698 2019-06-10  Tom Tromey  <tromey@adacore.com>
 699
 700         * ada-lang.c (_initialize_ada_language): Update help text.
 701
 702 2019-06-10  Tom Tromey  <tromey@adacore.com>
 703
 704         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 705         with a newline.
 706         * guile/guile.c (handle_boot_error): Don't end warning with a
 707         newline.
 708         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 709         warning with a newline.
 710         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 711         newline.
 712         (s12z_frame_cache): Likewise.
 713         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 714         a newline.
 715         * solib-svr4.c (disable_probes_interface): Don't end warning with
 716         a newline.
 717         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 718         newline.
 719         * python/python.c (do_finish_initialization): Don't end warning
 720         with a newline.
 721
 722 2019-06-10  Tom Tromey  <tom@tromey.com>
 723
 724         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 725         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 726         gdbpy_enter.
 727
 728 2019-06-10  Tom Tromey  <tromey@adacore.com>
 729
 730         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 731         data.
 732         (elf_new_init): Don't call stabsread_new_init.
 733         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 734         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 735         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 736
 737 2019-06-10  Tom de Vries  <tdevries@suse.de>
 738
 739         PR symtab/16264
 740         PR symtab/24517
 741         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 742
 743 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 744
 745         * source.c (find_and_open_source): Also rewrite relative file
 746         names.
 747
 748 2019-04-26  Amos Bird  <amosbird@gmail.com>
 749
 750         * annotate.c (annotate_thread_exited): Add "thread-exited"
 751         annotation.
 752
 753 2019-06-06  Tom Tromey  <tromey@adacore.com>
 754
 755         * maint.h (class scoped_command_stats): Use
 756         DISABLE_COPY_AND_ASSIGN.
 757         <print_time>: New method.
 758         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 759         print_time.
 760         (scoped_command_stats::print_time): New method.
 761
 762 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 765         instructions of lengths 6 or 8 bytes.
 766
 767 2019-06-04  Pedro Alves  <palves@redhat.com>
 768
 769         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 770
 771         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 772         * breakpoint.c (condition_completer): Likewise.
 773         * cli/cli-dump.c (scan_expression): Likewise.
 774         * common/filestuff.c (mkdir_recursive): Likewise.
 775         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 776         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 777         (gdb_abspath): Likewise.
 778         * compile/compile-cplus-types.c
 779         (compile_cplus_instance::decl_name): Likewise.
 780         * completer.c (complete_explicit_location):
 781         (signal_completer, reg_or_group_completer_1): Likewise.
 782         * cp-support.c (cp_remove_params_if_any): Likewise.
 783         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 784         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 785         * infcmd.c (strip_bg_char): Likewise.
 786         * linespec.c (copy_token_string): Likewise.
 787         * mi/mi-main.c (output_cores): Likewise.
 788         * psymtab.c (psymtab_search_name):
 789         * symfile.c (test_set_ext_lang_command): Likewise.
 790         * target.c (target_fileio_read_stralloc): Likewise.
 791         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 792         * value.c (complete_internalvar): Likewise.
 793
 794 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 795
 796         Add objfile property to gdb.Type.
 797         * NEWS: Mention Python API addition.
 798         * python/py-type.c (typy_get_objfile): New method.
 799
 800 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 801
 802         * NEWS: Mention the new set|show style [title|highlight].
 803         Mention changes to "show style", "help" and "apropos".
 804
 805 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 806
 807         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 808         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 809         instead of print_help_for_command.
 810         (print_doc_of_command): New function.
 811         (help_list): Add 'apropos -v word' suggestion.
 812         (print_help_for_command): Style the command name using title style.
 813         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 814         (_initialize_cli_cmds): Describe -v in apropos_command help.
 815
 816 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 817
 818         * cli/cli-style.h (cli_style_option): Add name in constructor,
 819         add m_name class member, add constructor with intensity,
 820         add name class function.
 821         (cli_style_option::add_setshow_commands): Remove name argument.
 822         (highlight_style, title_style): New styles.
 823         * cli/cli-style.c (do_show): New function that shows a style
 824         characteristic styling the style name with itself.
 825         (set_style_name): New function.
 826         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 827         Update all callers according to the changes in cli/cli-style.h.
 828         * utils.h (fputs_highlighted): New function.
 829         * utils.c (fputs_highlighted): Likewise.
 830
 831 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 832
 833         * NEWS: Mention new pipe command and new convenience variables.
 834
 835 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 836
 837         * cli/cli-cmds.c (pipe_command): New function.
 838         (_initialize_cli_cmds): Call add_com for pipe_command.
 839         Define | as an alias for pipe.
 840         (exit_status_set_internal_vars): New function.
 841         (shell_escape): Call exit_status_set_internal_vars.
 842         cli/cli-decode.c (find_command_name_length): Recognize | as
 843         a single character command.
 844
 845 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 846
 847         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 848         top.c (execute_command_to_ui_file): New function, mostly a copy
 849         of execute_command_to_string.
 850         (execute_command_to_string): Implement by calling
 851         execute_command_to_ui_file.
 852
 853 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 854
 855         * top.h (saved_command_line): Remove declaration.
 856         * top.c (previous_saved_command_line, previous_repeat_arguments):
 857         New variables.
 858         (saved_command_line): Make static, define together with other
 859         'repeat variables'.
 860         (dont_repeat): Clear repeat_arguments.
 861         (repeat_previous, get_saved_command_line, save_command_line):
 862         New functions.
 863         (gdb_init): Initialize saved_command_line
 864         and previous_saved_command_line.
 865         * main.c (captured_main_1): Remove saved_command_line initialization.
 866         * event-top.c (handle_line_of_input): Update to use
 867         the new 'repeat' related functions instead of direct access to
 868         saved_command_line.
 869         * command.h (repeat_previous, get_saved_command_line,
 870         save_command_line): New declarations.
 871         (dont_repeat): Add comment.
 872
 873 2019-05-30  Tom Tromey  <tromey@adacore.com>
 874
 875         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 876         Fix comment.
 877         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 878
 879 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 880
 881         PR cli/24587
 882         * completer.c (complete): Initialize variable word.
 883
 884 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 885
 886         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 887         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 888         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 889         'body' is NULL to the outter 'if', protecting the '!is_define'
 890         situation as well.
 891
 892 2019-05-29  Tom Tromey  <tromey@adacore.com>
 893
 894         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 895         (dwarf_unknown): New function.
 896         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 897         (dwarf_type_encoding_name): Use dwarf_unknown.
 898
 899 2019-05-29  Tom Tromey  <tromey@adacore.com>
 900
 901         PR c++/20020:
 902         * cp-valprint.c (cp_print_value_fields): Call
 903         cp_print_static_field inside "try".
 904
 905 2019-05-29  Tom Tromey  <tromey@adacore.com>
 906
 907         * inflow.c (struct terminal_info): Add default operator=.
 908         * configure: Rebuild.
 909         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 910         -Wdeprecated-copy-dtor, -Wredundant-move.
 911
 912 2019-05-29  Tom Tromey  <tromey@adacore.com>
 913
 914         * NEWS: Add entry.
 915         * infcmd.c (print_return_value_1): Handle finish_print
 916         option.
 917         (show_print_finish): New function.
 918         (_initialize_infcmd): Add "set/show print finish" commands.
 919         * valprint.c (user_print_options): Initialize new member.
 920         * valprint.h (struct value_print_options) <finish_print>: New
 921         member.
 922
 923 2019-05-28  Tom Tromey  <tromey@adacore.com>
 924
 925         * ada-lang.c (ada_remove_Xbn_suffix)
 926         (find_old_style_renaming_symbol)
 927         (parse_old_style_renaming): Remove.
 928         (ada_find_renaming_symbol): Don't call
 929         find_old_style_renaming_symbol.
 930         (ada_is_renaming_symbol): Rename from
 931         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 932         bool.  Now static.
 933         (ada_read_var_value): Update and simplify.
 934         * ada-exp.y (write_var_or_type): Remove old code.
 935
 936 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 937
 938         * event-top.c: Remove include comment.
 939         * inflow.c (class scoped_ignore_sigttou): Move from here...
 940         * inflow.h (class scoped_ignore_sigttou): ...to here.
 941         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 942         * top.c:  Remove include comment.
 943
 944 2019-05-27  Tom Tromey  <tom@tromey.com>
 945
 946         * NEWS: Fix typo.
 947
 948 2019-05-22  Tom Tromey  <tromey@adacore.com>
 949
 950         * target.c (target_follow_exec): Constify parameter.
 951         * target-delegates.c: Rebuild.
 952         * remote.c (remote_target::follow_exec): Constify parameter.
 953         * infrun.c (follow_exec): Constify parameter.
 954         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 955         (target_follow_exec): Likewise.
 956
 957 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 958
 959         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 960         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 961
 962 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 963
 964         * NEWS: Add debugredirect and testsuite sections.
 965
 966 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 967
 968         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 969         target descriptions using exclusively floating point register name
 970         aliases.
 971
 972 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         PR gdb/18644:
 975         * f-lang.c (build_fortran_types): Handle the case where
 976         gdbarch_floatformat_for_type returns a nullptr.
 977
 978 2019-05-21  Tom de Vries  <tdevries@suse.de>
 979
 980         PR cli/24587
 981         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 982
 983 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         PR gdb/18644:
 986         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 987         16-byte floats.
 988         * i386-tdep.c (i386_floatformat_for_type): Use
 989         floatformats_ia64_quad for the 16-byte floating point component
 990         within a fortran 32-byte complex number.
 991
 992 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 995         delete default constructor.
 996         (find_partial_die): Update to return const struct.
 997         (partial_die_parent_scope): Move variable declaration into scope
 998         of its use and change its type to auto.
 999         (guess_partial_die_structure_name): Likewise.
1000         (partial_die_info::fixup): Likewise.
1001
1002 2019-05-17  Tom Tromey  <tromey@adacore.com>
1003
1004         * source.c (find_and_open_source): Remove cast.
1005
1006 2019-05-17  Tom Tromey  <tromey@adacore.com>
1007
1008         * annotate.c (annotate_source): Make "filename" const.
1009         * annotate.h (annotate_source): Use const.
1010
1011 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * disasm.c (set_disassembler_options): Send errors to stderr.
1014
1015 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1016
1017         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1018         (cli_interp_base::set_logging): Check debug_redirect.
1019         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1020         * cli/cli-logging.c (debug_redirect): Add static variable.
1021         (pop_output_files): Add default param.
1022         (handle_redirections): Print debug setting.
1023         (show_logging_command): Likewise.
1024         (_initialize_cli_logging): Add debugredirect command.
1025         * interps.c (current_interp_set_logging): Add debug_redirect
1026         parameter.
1027         * interps.h (set_logging): Add debug_redirect parameter.
1028         (current_interp_set_logging): Likewise.
1029         * mi/mi-common.h: Likewise.
1030         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1031
1032 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1033             Tom Tromey  <tromey@adacore.com>
1034
1035         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1036         directly.
1037         * cli/cli-interp.h (make_logging_output): Remove declaration.
1038         * cli/cli-logging.c (make_logging_output): Remove function.
1039         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1040         directly.
1041         * ui-file.c (tee_file::tee_file): Remove bools.
1042         (tee_file::~tee_file): Remove deletes.
1043         * ui-file.h (tee_file): Remove bools.
1044
1045 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1046
1047         * mi/mi-cmds.h (mi_cmd_complete): New function.
1048         * mi/mi-main.c (mi_cmd_complete): Likewise.
1049         * mi/mi-cmds.c: Define new MI command -complete.
1050         * NEWS: Mention new -complete command.
1051
1052 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1053
1054         * completer.h (complete): New function.
1055         * completer.c (complete): Likewise.
1056         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1057         function defined in completer.h.
1058
1059 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1060
1061         * MAINTAINERS (Write After Approval): Add myself.
1062
1063 2019-05-17  Tom de Vries  <tdevries@suse.de>
1064
1065         PR gdb/24094
1066         * dwarf2read.c (struct cu_partial_die_info): New struct.
1067         (find_partial_die): Return cu_partial_die_info.
1068         (partial_die_parent_scope, guess_partial_die_structure_name)
1069         (partial_die_info::fixup): Handle new return type of find_partial_die.
1070
1071 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1072
1073         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1074         "std::string", simplifying the algorithm.
1075
1076 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1077
1078         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1079         (stap_static_probe_ops::get_probes): Likewise.
1080
1081 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1082
1083         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1084         '-')" and "else if".
1085         (stap_parse_single_operand): Join checks for
1086         "gdbarch_stap_parse_special_token_p" and
1087         "gdbarch_stap_parse_special_token" in the same "if" statement.
1088         Invert check when verifying for operation on register
1089         displacement.
1090
1091 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1092
1093         * stap-probe.c (stap_get_opcode): Update comment.
1094         (stap_get_expected_argument_type): Likewise.
1095         (handle_stap_probe): Likewise.
1096
1097 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1098
1099         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1100         return type to 'bool'.  Adjust comment.  Use 'bool' when
1101         appropriate.
1102         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1103         * stap-probe.c (stap_parse_argument_1): Likewise.
1104         (stap_is_operator): Likewise.
1105         (stap_is_generic_prefix): Likewise.
1106         (stap_is_register_prefix): Likewise.
1107         (stap_is_register_indirection_prefix): Likewise.
1108         (stap_is_integer_prefix): Likewise.
1109         (stap_generic_check_suffix): Likewise.
1110         (stap_check_integer_suffix): Likewise.
1111         (stap_check_register_suffix): Likewise.
1112         (stap_check_register_indirection_suffix): Likewise.
1113         (stap_parse_register_operand): Likewise.
1114         (stap_parse_single_operand): Likewise.
1115         (stap_parse_argument_1): Likewise.
1116         (stap_probe::get_argument_count): Likewise.
1117         (stap_is_operator): Likewise.
1118
1119 2019-05-16  Tom Tromey  <tromey@adacore.com>
1120
1121         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1122         keyword to foreach.
1123
1124 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1125
1126         * linux-thread-db.c (try_thread_db_load_1): Change return type
1127         to bool.
1128         (try_thread_db_load): Likewise.
1129         (try_thread_db_load_from_pdir_1): Likewise.
1130         (try_thread_db_load_from_pdir): Likewise.
1131         (try_thread_db_load_from_sdir): Likewise.
1132         (try_thread_db_load_from_dir): Likewise.
1133         (thread_db_load_search): Likewise.
1134         (has_libpthread): Likewise.
1135         (thread_db_load): Likewise.
1136
1137 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1138
1139         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1140         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1141         NULL, and complain/return if that's the case.
1142
1143 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1144
1145         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1146         (advance, posn, abstract_read_memory): New functions.
1147         [struct mem_read_abstraction]: New struct.
1148         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1149
1150 2019-05-14  Tom Tromey  <tromey@adacore.com>
1151
1152         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1153         value is not lval_memory.
1154
1155 2019-05-14  Tom Tromey  <tromey@adacore.com>
1156
1157         * solib.c (info_sharedlibrary_command): Style the file name.
1158
1159 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1160
1161         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1162         (aarch64_vnv_type): Likewise.
1163         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1164         * common/tdesc.c: Likewise.
1165         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1166         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1167         * features/aarch64-fpu.xml: Add ieee half view.
1168         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1169         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1170         * gdbtypes.h (struct builtin_type): Likewise.
1171         (struct objfile_type): Likewise.
1172
1173 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1174
1175         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1176         typo.
1177         * location.h (string_to_event_location): Likewise.
1178
1179 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1180
1181         GDB 8.3 released.
1182
1183 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1186         New variable declaration.
1187         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1188         New variable.
1189         (print_one_breakpoint): Use ui_out::test_flags and new global
1190         variable to compute use_fixed_output.
1191         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1192         Remove.
1193         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1194         (mi_multi_location_breakpoint_output_fixed): Remove.
1195         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1196         new variable.
1197         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1198         fix_multi_location_breakpoint_output flag if version >= 3.
1199         * ui-out.h (enum ui_out_flag)
1200         <fix_multi_location_breakpoint_output>: New enumerator.
1201
1202 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1203
1204         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1205
1206 2019-05-10  Tom Tromey  <tromey@adacore.com>
1207
1208         * ada-lang.c (catch_ada_completer): New function.
1209         (_initialize_ada_language): Use it.
1210
1211 2019-05-10  Tom Tromey  <tromey@adacore.com>
1212
1213         * thread.c (print_thread_info): Make "requested_threads" const.
1214         * gdbthread.h (print_thread_info): Make "requested_threads"
1215         const.
1216         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1217         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1218
1219 2019-05-08  Tom Tromey  <tom@tromey.com>
1220
1221         * gdbtypes.c (objfile_type_data): Change type.
1222         (objfile_type, _initialize_gdbtypes): Update.
1223
1224 2019-05-08  Tom Tromey  <tom@tromey.com>
1225
1226         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1227         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1228         (_initialize_dwarf2_frame): Update.
1229
1230 2019-05-08  Tom Tromey  <tom@tromey.com>
1231
1232         * objc-lang.c (objc_objfile_data): Change type.
1233         (find_methods): Update.
1234         (_initialize_objc_lang): Remove.
1235
1236 2019-05-08  Tom Tromey  <tom@tromey.com>
1237
1238         * stabsread.c (rs6000_builtin_type_data): Change type.
1239         (rs6000_builtin_type, _initialize_stabsread): Update.
1240
1241 2019-05-08  Tom Tromey  <tom@tromey.com>
1242
1243         * mips-tdep.c (mips_pdr_data): Remove.
1244         (_initialize_mips_tdep): Update.
1245
1246 2019-05-08  Tom Tromey  <tom@tromey.com>
1247
1248         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1249         (hppa_init_objfile_priv_data, read_unwind_info)
1250         (find_unwind_entry, _initialize_hppa_tdep): Update.
1251
1252 2019-05-08  Tom Tromey  <tom@tromey.com>
1253
1254         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1255         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1256         on obstack.
1257         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1258
1259 2019-05-08  Tom Tromey  <tom@tromey.com>
1260
1261         * mdebugread.c (basic_type_data): Change type.
1262         (basic_type, _initialize_mdebugread): Update.
1263
1264 2019-05-08  Tom Tromey  <tom@tromey.com>
1265
1266         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1267
1268 2019-05-08  Tom Tromey  <tom@tromey.com>
1269
1270         * nto-tdep.c (nto_inferior_data_reg): Change type.
1271         (nto_inferior_data): Update.
1272         (nto_inferior_data_cleanup, nto_new_inferior_data)
1273         (_initialize_nto_tdep): Remove.
1274         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1275
1276 2019-05-08  Tom Tromey  <tom@tromey.com>
1277
1278         * ada-lang.c (struct ada_inferior_data): Add initializers.
1279         (ada_inferior_data): Change type.
1280         (ada_inferior_data_cleanup): Remove.
1281         (get_ada_inferior_data, ada_inferior_exit)
1282         (struct ada_pspace_data): Add initializers, destructor.
1283         (ada_pspace_data_handle): Change type.
1284         (get_ada_pspace_data): Update.
1285         (ada_pspace_data_cleanup): Remove.
1286
1287 2019-05-08  Tom Tromey  <tom@tromey.com>
1288
1289         * coffread.c (struct coff_symfile_info): Add initializers.
1290         (coff_objfile_data_key): Move lower.  Change type.
1291         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1292         Update.
1293         (coff_free_info): Remove.
1294
1295 2019-05-08  Tom Tromey  <tom@tromey.com>
1296
1297         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1298         (fbsd_pspace_data_handle): Move lower.  Change type.
1299         (get_fbsd_pspace_data): Update.
1300         (fbsd_pspace_data_cleanup): Remove.
1301         (_initialize_fbsd_tdep): Update.
1302
1303 2019-05-08  Tom Tromey  <tom@tromey.com>
1304
1305         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1306         (get_ada_tasks_pspace_data): Update.
1307         (ada_tasks_pspace_data_cleanup): Remove.
1308         (_initialize_tasks): Update.
1309         (ada_tasks_inferior_data_handle): Change type.
1310         (get_ada_tasks_inferior_data): Update.
1311         (ada_tasks_inferior_data_cleanup): Remove.
1312         (struct ada_tasks_pspace_data): Add initializers.
1313
1314 2019-05-08  Tom Tromey  <tom@tromey.com>
1315
1316         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1317         * symfile-debug.c (debug_sym_get_probes): Change type.
1318         * stap-probe.c (handle_stap_probe):
1319         (stap_static_probe_ops::get_probes): Change type.
1320         * probe.h (class static_probe_ops) <get_probes>: Change type.
1321         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1322         (parse_probes_in_pspace): Update.
1323         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1324         Update.
1325         (any_static_probe_ops::get_probes): Change type.
1326         * elfread.c (elfread_data): New typedef.
1327         (probe_key): Change type.
1328         (elf_get_probes): Likewise.  Update.
1329         (probe_key_free): Remove.
1330         (_initialize_elfread): Update.
1331         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1332         Change type.
1333         (dtrace_process_dof_probe, dtrace_process_dof)
1334         (dtrace_static_probe_ops::get_probe): Change type.
1335
1336 2019-05-08  Tom Tromey  <tom@tromey.com>
1337
1338         * xcoffread.c (struct xcoff_symfile_info): Rename from
1339         coff_symfile_info.  Add initializers.
1340         (xcoff_objfile_data_key): Move lower.  Change type.
1341         (XCOFF_DATA): Rewrite.
1342         (xcoff_free_info): Remove.
1343         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1344         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1345         (xcoff_initial_scan): Update.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * solib-svr4.c (struct svr4_info): Add initializers and
1350         destructor.
1351         <probes_table>: Now an htab_up.
1352         (solib_svr4_pspace_data): Change type.
1353         (free_probes_table): Simplify.
1354         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1355         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1356         (probes_table_remove_objfile_probes, register_solib_event_probe)
1357         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1358         (_initialize_svr4_solib): Update.
1359
1360 2019-05-08  Tom Tromey  <tom@tromey.com>
1361
1362         * remote.c (remote_pspace_data): Change type.
1363         (remote_pspace_data_cleanup): Remove.
1364         (get_remote_exec_file, set_pspace_remote_exec_file)
1365         (_initialize_remote): Update.
1366
1367 2019-05-08  Tom Tromey  <tom@tromey.com>
1368
1369         * breakpoint.c (breakpoint_objfile_key): Change type.
1370         (get_breakpoint_objfile_data): Update.
1371         (free_breakpoint_objfile_data): Remove.
1372         (_initialize_breakpoint): Update.
1373
1374 2019-05-08  Tom Tromey  <tom@tromey.com>
1375
1376         * linux-tdep.c (struct linux_info): Add initializers.
1377         (linux_inferior_data): Move.  Change type.
1378         (invalidate_linux_cache_inf): Update.
1379         (linux_inferior_data_cleanup): Remove.
1380         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1381
1382 2019-05-08  Tom Tromey  <tom@tromey.com>
1383
1384         * auxv.c (auxv_inferior_data): Move.  Change type.
1385         (auxv_inferior_data_cleanup): Remove.
1386         (invalidate_auxv_cache_inf): Rewrite.
1387         (get_auxv_inferior_data, _initialize_auxv): Update.
1388
1389 2019-05-08  Tom Tromey  <tom@tromey.com>
1390
1391         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1392         (symfile_debug_objfile_data_key): Change type.
1393         (symfile_debug_installed, debug_qf_has_symbols)
1394         (debug_qf_find_last_source_symtab)
1395         (debug_qf_forget_cached_source_info)
1396         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1397         (debug_qf_print_stats, debug_qf_dump)
1398         (debug_qf_expand_symtabs_for_function)
1399         (debug_qf_expand_all_symtabs)
1400         (debug_qf_expand_symtabs_with_fullname)
1401         (debug_qf_map_matching_symbols)
1402         (debug_qf_expand_symtabs_matching)
1403         (debug_qf_find_pc_sect_compunit_symtab)
1404         (debug_qf_map_symbol_filenames)
1405         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1406         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1407         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1408         (debug_sym_read_linetable, debug_sym_relocate): Update.
1409         (symfile_debug_free_objfile): Remove.
1410         (install_symfile_debug_logging, _initialize_symfile_debug):
1411         Update.
1412
1413 2019-05-08  Tom Tromey  <tom@tromey.com>
1414
1415         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1416         allocate_on_obstack.
1417         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1418         (get_dwarf2_per_objfile): Update.
1419         (set_dwarf2_per_objfile): Remove.
1420         (dwarf2_has_info, dwarf2_get_section_info): Update.
1421         (dwarf2_free_objfile): Remove.
1422         (_initialize_dwarf2_read): Update.
1423
1424 2019-05-08  Tom Tromey  <tom@tromey.com>
1425
1426         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1427         initializers.
1428         <unsupported_script_warning_printed,
1429         script_not_found_warning_printed>: Now bool.
1430         (auto_load_pspace_data): Change type.
1431         (~auto_load_pspace_info): Rename from
1432         auto_load_pspace_data_cleanup.
1433         (get_auto_load_pspace_data, init_loaded_scripts_info)
1434         (clear_section_scripts, maybe_print_unsupported_script_warning)
1435         (maybe_print_script_not_found_warning, _initialize_auto_load):
1436         Update.
1437
1438 2019-05-08  Tom Tromey  <tom@tromey.com>
1439
1440         * objfiles.c (objfile_pspace_info): Add destructor and
1441         initializers.
1442         (objfiles_pspace_data): Change type.
1443         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1444         (get_objfile_pspace_data): Update.
1445         (objfiles_bfd_data): Change type.
1446         (get_objfile_bfd_data): Update.
1447         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1448
1449 2019-05-08  Tom Tromey  <tom@tromey.com>
1450
1451         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1452         Change type.
1453         (get_catch_syscall_inferior_data): Update.
1454         (catch_syscall_inferior_data_cleanup): Remove.
1455         (_initialize_break_catch_syscall): Update.
1456
1457 2019-05-08  Tom Tromey  <tom@tromey.com>
1458
1459         * inflow.c (struct terminal_info): Add destructor and
1460         initializers.
1461         (inflow_inferior_data): Change type.
1462         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1463         (get_inflow_inferior_data, inflow_inferior_exit)
1464         (swap_terminal_info, _initialize_inflow): Update.
1465
1466 2019-05-08  Tom Tromey  <tom@tromey.com>
1467
1468         * target-dcache.c (target_dcache_cleanup): Remove.
1469         (target_dcache_aspace_key): Change type.
1470         (target_dcache_init_p, target_dcache_invalidate)
1471         (target_dcache_get, target_dcache_get_or_init)
1472         (_initialize_target_dcache): Update.
1473         * dcache.h (struct dcache_deleter): New.
1474
1475 2019-05-08  Tom Tromey  <tom@tromey.com>
1476
1477         * symtab.c (struct symbol_cache): Add destructor and
1478         initializers.
1479         (symbol_cache_key): Move.  Change type.
1480         (make_symbol_cache, free_symbol_cache): Remove.
1481         (get_symbol_cache): Update.
1482         (symbol_cache_cleanup): Remove.
1483         (ALL_PSPACES, symbol_cache_flush)
1484         (maintenance_print_symbol_cache)
1485         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1486         Update.
1487
1488 2019-05-08  Tom Tromey  <tom@tromey.com>
1489
1490         * symtab.c (struct main_info): Add destructor and initializers.
1491         (main_progspace_key): Move.  Change type.
1492         (get_main_info): Update.
1493         (main_info_cleanup): Remove.
1494         (_initialize_symtab): Update.
1495
1496 2019-05-08  Tom Tromey  <tom@tromey.com>
1497
1498         * registry.h (DECLARE_REGISTRY): Define the _key class.
1499
1500 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * NEWS: Merge two 'New commands' sections.
1503
1504 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1505
1506         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1507         parameter and use Ada language definition instead.
1508         (ada_val_print_ptr): Remove unused language parameter.
1509         (ada_val_print_num): Remove language parameter and use Ada language
1510         definition instead.
1511         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1512         parameter.
1513         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1514         parameter and use Ada language definition instead.
1515         (ada_val_print_1): Update all ada_val_print_xxx calls.
1516         Remove language parameter.
1517         (ada_val_print): Update ada_val_print_1 call.
1518
1519 2019-05-08  Tom Tromey  <tromey@adacore.com>
1520
1521         * remote.c (remote_hw_watchpoint_limit)
1522         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1523         Now static.
1524
1525 2019-05-08  Tom Tromey  <tromey@adacore.com>
1526
1527         * maint.c (_initialize_maint_cmds): Move initialization code to
1528         remote.c.
1529         (watchdog, show_watchdog): Move to remote.c.
1530         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1531         "watchdog" static.
1532         (_initialize_remote): Move initialization code from maint.c.
1533         * defs.h (watchdog): Don't declare.
1534
1535 2019-05-08  Tom Tromey  <tromey@adacore.com>
1536
1537         * tui/tui-interp.c: Include main.h.
1538         * interps.c: Include main.h.
1539         * main.h (interpreter_p): Declare.
1540         * defs.h (interpreter_p): Don't declare.
1541
1542 2019-05-08  Tom Tromey  <tromey@adacore.com>
1543
1544         * dwarf2loc.c: Include dwarf2read.h.
1545         * defs.h (read_unsigned_leb128): Don't declare.
1546         * dwarf2read.h (read_unsigned_leb128): Declare.
1547
1548 2019-05-08  Tom Tromey  <tromey@adacore.com>
1549
1550         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1551         method.
1552
1553 2019-05-08  Tom Tromey  <tromey@adacore.com>
1554
1555         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1556         when no wrap column is set.
1557
1558 2019-05-08  Tom Tromey  <tromey@adacore.com>
1559
1560         * c-lang.c (c_get_string): Handle non-C-style arrays.
1561
1562 2019-05-08  Tom Tromey  <tromey@adacore.com>
1563
1564         * typeprint.c (print_offset_data::update): Print the bit offset,
1565         not the number of bits remaining.
1566
1567 2019-05-08  Tom Tromey  <tromey@adacore.com>
1568
1569         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1570         padding at end of comment.
1571
1572 2019-05-08  Tom Tromey  <tromey@adacore.com>
1573
1574         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1575         Compare main types.
1576
1577 2019-05-06  Tom Tromey  <tom@tromey.com>
1578
1579         * common/scoped_mmap.c: Include common-defs.h.
1580         * common/scoped_mmap.h: Don't include config.h.
1581
1582 2019-05-04  Tom Tromey  <tom@tromey.com>
1583
1584         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1585         (struct aarch64_call_info): Add initializers.
1586         <si>: Now a std::vector.
1587         (pass_on_stack, aarch64_push_dummy_call): Update.
1588
1589 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1590             Tom Tromey  <tom@tromey.com>
1591
1592         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1593         (ppc_threads): Now a std::vector.  Now static.
1594         (hwdebug_find_thread_points_by_tid)
1595         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1596         Update.
1597
1598 2019-05-04  Tom Tromey  <tom@tromey.com>
1599
1600         * arc-tdep.c (arc_tdesc_init): Return bool.
1601
1602 2019-05-04  Tom Tromey  <tom@tromey.com>
1603
1604         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1605         Use gdb_assert_not_reached.
1606
1607 2019-05-04  Tom Tromey  <tom@tromey.com>
1608
1609         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1610         "false".
1611
1612 2019-05-04  Tom Tromey  <tom@tromey.com>
1613
1614         * arc-tdep.c (arc_tdesc_init): Use bool.
1615
1616 2019-05-04  Tom Tromey  <tom@tromey.com>
1617
1618         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1619
1620 2019-05-04  Tom Tromey  <tom@tromey.com>
1621
1622         * cli/cli-cmds.c (valid_command_p): Return bool.
1623
1624 2019-05-04  Tom Tromey  <tom@tromey.com>
1625
1626         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1627         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1628
1629 2019-05-04  Raul Tambre  <raul@tambre.ee>
1630
1631         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1632         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1633         operator for comparison.
1634
1635 2019-05-04  Tom Tromey  <tom@tromey.com>
1636
1637         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1638         (lookup_partial_symbol, print_partial_symbols)
1639         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1640         (psymbol_compare): Update.
1641         (add_psymbol_to_bcache): Clear the entire psymbol.
1642         (maintenance_check_psymtabs): Update.
1643         * psympriv.h (struct partial_symbol): Don't derive from
1644         general_symbol_info.
1645         <obj_section, unrelocated_address, address,
1646         set_unrelocated_address>: Update.
1647         <ginfo>: New member.
1648         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1649         (debug_names::write_psymbols): Update.
1650
1651 2019-05-04  Tom de Vries  <tdevries@suse.de>
1652
1653         * contrib/cc-with-tweaks.sh: Support -n arg.
1654
1655 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1656
1657         * corelow.c (core_target::detach): Ensure frame cache and
1658         register caches are cleared.
1659         inferior.c (exit_inferior_1): Likewise.
1660
1661 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1662             Tom Tromey  <tom@tromey.com>
1663
1664         * dictionary.c (collate_pending_symbols_by_language): Remove
1665         "struct" from foreach.
1666         * symtab.c (lookup_global_symbol_from_objfile)
1667         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1668         foreach.
1669         * ser-tcp.c (net_open): Remove "struct" from foreach.
1670         * objfiles.c (objfile_relocate, objfile_rebase)
1671         (objfile_has_symbols): Remove "struct" from foreach.
1672         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1673         from foreach.
1674         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1675         foreach.
1676         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1677         "struct" from foreach.
1678         * ada-lang.c (create_excep_cond_exprs)
1679         (ada_exception_catchpoint_cond_string): Remove "struct" from
1680         foreach.
1681
1682 2019-05-03  Tom Tromey  <tromey@adacore.com>
1683
1684         * ada-exp.y (convert_char_literal): Check suffix of each
1685         enumerator.
1686
1687 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1688
1689         PR ada/21406:
1690         * ada-exp.y (yywrap): Don't define.
1691         * ada-lex.l (%option): Add noyywrap
1692         (yywrap): Remove.
1693
1694 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1695
1696         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1697         _WIN32_WINNT to the XP level, unless already defined to a higher
1698         level.
1699
1700         * unittests/parse-connection-spec-selftests.c:
1701         * ser-tcp.c:
1702         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1703         override.
1704
1705         * symfile.c (find_separate_debug_file): Remove colon from the
1706         drive spec of DOS/Windows file names of the target, so that the
1707         file name produced from DEBUGDIR and the target's directory will
1708         be valid on DOS/Windows systems.
1709
1710 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * rust-lang.c (val_print_struct): Handle printing structures
1713         containing strings.
1714
1715 2019-05-02  Tom Tromey  <tromey@adacore.com>
1716
1717         * valarith.c (_initialize_valarith): Remove.
1718
1719 2019-05-01  Tom Tromey  <tromey@adacore.com>
1720
1721         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1722         bitfields.
1723
1724 2019-05-01  Tom Tromey  <tromey@adacore.com>
1725
1726         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1727         for big-endian copies.
1728
1729 2019-04-30  Ali Tamur  <tamur@google.com>
1730         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1731         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1732         (read_3_bytes): New function.
1733
1734 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1735
1736         * windows-nat.c (main_thread_id): Delete.
1737         (handle_output_debug_string): Replace main_thread_id by
1738         current_event.dwThreadId.
1739         (fake_create_process): Likewise.
1740         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1741         Do not set main_thread_id.
1742         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1743         current_event.dwThreadId.
1744         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1745
1746 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1747
1748         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1749         Use current_event.dwThreadId instead of main_thread_id.
1750
1751 2019-04-30  Tom Tromey  <tromey@adacore.com>
1752
1753         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1754         (create_excep_cond_exprs): Iterate over program spaces.
1755         (ada_exception_catchpoint_cond_string): Examine all minimal
1756         symbols for exception types.
1757
1758 2019-04-30  Tom Tromey  <tromey@adacore.com>
1759
1760         PR c++/24470:
1761         * dwarf2read.c (process_structure_scope): Handle case where type
1762         has template parameters but no symbol was created.
1763
1764 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1765             Chris January  <chris.january@arm.com>
1766
1767         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1768         qualifier.
1769         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1770
1771 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1772
1773         * f-typeprint.c (f_print_type): Update rules for printing
1774         whitespace.
1775         (f_type_print_varspec_suffix): Likewise.
1776
1777 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1778             Chris January  <chris.january@arm.com>
1779
1780         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1781         function arguments.
1782
1783 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * f-lang.c (build_fortran_types): Change name of void type to
1786         lower case.
1787         * f-typeprint.c (f_type_print_base): Print the name of the void
1788         type, rather than a fixed string.
1789         * f-valprint.c (f_decorations): Use lower case void string.
1790
1791 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1792             Chris January  <chris.january@arm.com>
1793
1794         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1795         types for Fortran.
1796
1797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1798             Chris January  <chris.january@arm.com>
1799             David Lecomber  <david.lecomber@arm.com>
1800
1801         * f-exp.y (BINOP_INTRINSIC): New token.
1802         (exp): New parser rule handling BINOP_INTRINSIC.
1803         (f77_keywords): Add new builtin procedures.
1804         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1805         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1806         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1807         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1808         (print_unop_subexp_f): New function.
1809         (print_binop_subexp_f): New function.
1810         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1811         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1812         (dump_subexp_body_f): Likewise.
1813         (operator_check_f): Likewise.
1814         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1815         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1816
1817 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1820         UNOP_KIND.
1821         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1822         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1823         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1824         (operator_length_f): New fuction.
1825         (print_subexp_f): New function.
1826         (op_name_f): New function.
1827         (dump_subexp_body_f): New function.
1828         (operator_check_f): New function.
1829         (exp_descriptor_f): Replace standard expression handling functions
1830         with new functions.
1831         * gdb/fortran-operator.def: New file.
1832         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1833         * gdb/std-operator.def: Remove UNOP_KIND.
1834
1835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * std-operator.def: Remove unbalanced, stray double quote
1838         character.
1839
1840 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1841             Chris January  <chris.january@arm.com>
1842             Daniel Everett  <daniel.everett@arm.com>
1843             Nick Forrington  <nick.forrington@arm.com>
1844             Richard Bunt  <richard.bunt@arm.com>
1845
1846         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1847         of depth when printing anonymous structs or unions.
1848         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1849         Don't print either the top-level value, or the children if the
1850         max-depth is exceeded.
1851         (ppscm_print_children): When printing the key of a map, allow one
1852         extra level of depth.
1853         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1854         print either the top-level value, or the children if the max-depth
1855         is exceeded.
1856         (print_children): When printing the key of a map, allow one extra
1857         level of depth.
1858         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1859         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1860         (user_print_options): Initialise max_depth field.
1861         (val_print_scalar_or_string_type_p): New function.
1862         (val_print): Check to see if the max depth has been reached.
1863         (val_print_check_max_depth): Define new function.
1864         (show_print_max_depth): New function.
1865         (_initialize_valprint): Add 'print max-depth' option.
1866         * valprint.h (struct value_print_options) <max_depth>: New field.
1867         (val_print_check_max_depth): Declare new function.
1868         * NEWS: Document new feature.
1869
1870 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * ada-lang.c (ada_language_defn): Initialise new field.
1873         * c-lang.c (c_is_string_type_p): New function.
1874         (c_language_defn): Initialise new field.
1875         (cplus_language_defn): Initialise new field.
1876         (asm_language_defn): Initialise new field.
1877         (minimal_language_defn): Initialise new field.
1878         * c-lang.h (c_is_string_type_p): Declare new function.
1879         * d-lang.c (d_language_defn): Initialise new field.
1880         * f-lang.c (f_is_string_type_p): New function.
1881         (f_language_defn): Initialise new field.
1882         * go-lang.c (go_is_string_type_p): New function.
1883         (go_language_defn): Initialise new field.
1884         * language.c (default_is_string_type_p): New function.
1885         (unknown_language_defn): Initialise new field.
1886         (auto_language_defn): Initialise new field.
1887         * language.h (struct language_defn) <la_is_string_type_p>: New
1888         member variable.
1889         (default_is_string_type_p): Declare new function.
1890         * m2-lang.c (m2_language_defn): Initialise new field.
1891         * objc-lang.c (objc_language_defn): Initialise new field.
1892         * opencl-lang.c (opencl_language_defn): Initialise new field.
1893         * p-lang.c (pascal_is_string_type_p): New function.
1894         (pascal_language_defn): Initialise new field.
1895         * rust-lang.c (rust_is_string_type_p): New function.
1896         (rust_language_defn): Initialise new field.
1897
1898 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1901         New field.
1902         * ada-lang.c (ada_language_defn): Initialise new field.
1903         * c-lang.c (c_language_defn): Likewise.
1904         (cplus_language_defn): Likewise.
1905         (asm_language_defn): Likewise.
1906         (minimal_language_defn): Likewise.
1907         * d-lang.c (d_language_defn): Likewise.
1908         * f-lang.c (f_language_defn): Likewise.
1909         * go-lang.c (go_language_defn): Likewise.
1910         * language.c (unknown_language_defn): Likewise.
1911         (auto_language_defn): Likewise.
1912         * m2-lang.c (m2_language_defn): Likewise.
1913         * objc-lang.c (objc_language_defn): Likewise.
1914         * opencl-lang.c (opencl_language_defn): Likewise.
1915         * p-lang.c (pascal_language_defn): Likewise.
1916         * rust-lang.c (rust_language_defn): Likewise.
1917
1918 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * ada-lang.c (ada_is_character_type): Change return type to bool.
1921         (ada_is_string_type): Likewise.
1922         * ada-lang.h (ada_is_character_type): Update declaration
1923         (ada_is_string_type): Likewise.
1924
1925 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1926
1927         Support style in 'frame|thread apply'
1928
1929         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1930         * record.c (record_start, record_stop): Update callers of
1931         execute_command_to_string with false.
1932         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1933         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1934         methods.
1935         (class string_file): New constructor with term_out parameter.
1936         Override methods term_out and can_emit_style_escape.  New member
1937         term_out.
1938         (class stdio_file): Override can_emit_style_escape.
1939         (class tee_file): Override term_out and can_emit_style_escape.
1940         * utils.h (can_emit_style_escape): Remove.
1941         * utils.c (can_emit_style_escape): Likewise.
1942         Update all callers of can_emit_style_escape (SOMESTREAM) to
1943         SOMESTREAM->can_emit_style_escape.
1944         * source-cache.c (source_cache::get_source_lines): Likewise.
1945         * stack.c (frame_apply_command_count): Call execute_command_to_string
1946         passing the term_out characteristic of the current gdb_stdout.
1947         * thread.c (thr_try_catch_cmd): Likewise.
1948         * top.c (execute_command_to_string): pass term_out parameter
1949         to construct the string_file for the command output.
1950         * ui-file.c (term_cli_styling): New function (most code moved
1951         from utils.c can_emit_style_escape).
1952         (string_file::string_file, string_file::can_emit_style_escape,
1953         stdio_file::can_emit_style_escape, tee_file::term_out,
1954         tee_file::can_emit_style_escape): New functions.
1955
1956 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1957
1958         * NEWS: Mention the new set|show may-call-functions.
1959         * infcall.c (may_call_functions_p): New variable.
1960         (show_may_call_functions_p): New function.
1961         (call_function_by_hand_dummy): Throws an error if not
1962         may-call-functions.
1963         (_initialize_infcall): Call add_setshow_boolean_cmd for
1964         may-call-functions.
1965
1966 2019-04-25  Keith Seitz  <keiths@redhat.com>
1967
1968         PR c++/24367
1969         * cp-support.c (inspect_type): Don't attempt substitutions
1970         of symbol with the same name.
1971
1972 2019-04-25  Tom Tromey  <tromey@adacore.com>
1973
1974         PR gdb/24475:
1975         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1976         static.
1977
1978 2019-04-25  Tom Tromey  <tromey@adacore.com>
1979
1980         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1981         rvalue reference.
1982         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1983         (gdb_xml_parser::parse): Use std::move.
1984         * python/python-internal.h (gdbpy_convert_exception): Take a const
1985         reference.
1986         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1987         std::move.
1988         * python/py-utils.c (gdbpy_convert_exception): Take a const
1989         reference.
1990         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1991         Use std::move.
1992         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1993         Use std::move.
1994         * mi/mi-main.c (mi_print_exception): Take a const reference.
1995         * main.c (handle_command_errors): Take a const reference.
1996         * linespec.c (parse_linespec): Use std::move.
1997         * infcall.c (run_inferior_call): Use std::move.
1998         (call_function_by_hand_dummy): Use std::move.
1999         * exec.c (try_open_exec_file): Use std::move.
2000         * exceptions.h (exception_print, exception_fprintf)
2001         (exception_print_same): Update.
2002         * exceptions.c (print_exception, exception_print)
2003         (exception_fprintf, exception_print_same): Change parameters to
2004         const reference.
2005         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2006         * common/new-op.c: Use std::move.
2007         * common/common-exceptions.h (struct gdb_exception): Add move
2008         constructor.
2009         (struct gdb_exception_error, struct gdb_exception_quit, struct
2010         gdb_quit_bad_alloc): Change constructor to move constructor.
2011         (throw_exception): Change parameter to rvalue reference.
2012         * common/common-exceptions.c (throw_exception): Take rvalue
2013         reference.
2014         * cli/cli-interp.c (safe_execute_command): Use std::move.
2015         * breakpoint.c (insert_bp_location, location_to_sals): Use
2016         std::move.
2017
2018 2019-04-25  Tom Tromey  <tromey@adacore.com>
2019
2020         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2021         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2022         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2023         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2024         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2025         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2026         guile/scm-value.c: Use unpack.
2027         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2028         gdbscm_gdb_exception.
2029         (gdbscm_throw_gdb_exception): Likewise.
2030         (struct gdbscm_gdb_exception): New.
2031         (unpack): New function.
2032         (gdbscm_wrap): Use unpack.
2033
2034 2019-04-25  Tom Tromey  <tromey@adacore.com>
2035
2036         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2037         (gdb_rl_callback_handler): Use std::move.
2038         * common/common-exceptions.h (struct gdb_exception): Add move
2039         assignment operator.
2040         (throw_exception_sjlj): Change "exception" to const reference.
2041         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2042         (throw_exception_sjlj): Change "exception" to const reference.
2043
2044 2019-04-25  Tom Tromey  <tromey@adacore.com>
2045
2046         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2047         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2048         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2049         Update.
2050         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2051         Update.
2052         * mi/mi-interp.c (mi_interp::exec): Update.
2053         * linespec.c (parse_linespec): Update.
2054         * infcall.c (run_inferior_call): Update.
2055         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2056         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2057         (gdbscm_lookup_global_symbol): Update.
2058         * guile/scm-param.c (gdbscm_parameter_value): Update.
2059         * guile/scm-frame.c (gdbscm_frame_read_register)
2060         (gdbscm_frame_read_var): Update.
2061         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2062         * exec.c (try_open_exec_file): Update.
2063         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2064         (gdb_rl_callback_handler): Update.
2065         * common/common-exceptions.h (exception_none): Don't declare.
2066         * common/common-exceptions.c (exception_none): Don't define.
2067         (struct catcher) <exception>: Update.
2068         * cli/cli-interp.c (safe_execute_command): Update.
2069         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2070
2071 2019-04-25  Ali Tamur  <tamur@google.com>
2072
2073         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2074         (read_attribute_value): Likewise.
2075         (dwarf2_read_addr_index): Update comment.
2076         (read_str_index): Add DW_FORM_strx.
2077         (dwarf2_string_attr): Likewise.
2078         (dwarf2_const_value_attr): Likewise.
2079         (dump_die_shallow): Likewise.
2080         (dwarf2_fetch_constant_bytes): Likewise.
2081         (skip_form_bytes): Likewise.
2082         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2083
2084 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2085
2086         PR corefiles/11608
2087         PR corefiles/18187
2088         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2089         OFFSET.  Verify if current mapping contains an ELF header.
2090         (linux_find_memory_regions_full): Adjust call to
2091         dump_mapping_p.
2092
2093 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2094             Kang Li <kanglictf@gmail.com>
2095
2096         PR gdb/21600
2097
2098         * dwarf2-frame.c (read_initial_length): Be consistent about using
2099         unsigned representation of length.
2100         (decode_frame_entry_1): Likewise.  Check for wraparound of
2101         end pointer as well as buffer overflow.
2102
2103 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2104
2105         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2106         "vq".
2107
2108 2019-04-24  Tom Tromey  <tromey@adacore.com>
2109
2110         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2111
2112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2113
2114         * s12z-tdep.c (s12z_unwind_pc): Delete.
2115         (s12z_unwind_sp): Delete.
2116         (s12z_gdbarch_init): Don't register deleted functions with
2117         gdbarch.
2118
2119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * rl78-tdep.c (rl78_unwind_sp): Delete.
2122         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2123
2124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2125
2126         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2127         (xstormy16_unwind_pc): Delete.
2128         (xstormy16_dummy_id): Delete.
2129         (xstormy16_gdbarch_init): Don't register deleted functions with
2130         gdbarch.
2131
2132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * vax-tdep.c (vax_unwind_pc): Delete.
2135         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2136
2137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         * v850-tdep.c (v850_unwind_sp): Delete.
2140         (v850_unwind_pc): Delete.
2141         (v850_dummy_id): Delete.
2142         (v850_gdbarch_init): Don't register deleted functions with
2143         gdbarch.
2144
2145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2148         (tilegx_unwind_pc): Delete.
2149         (tilegx_unwind_dummy_id): Delete.
2150         (tilegx_gdbarch_init): Don't register deleted functions with
2151         gdbarch.
2152
2153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2154
2155         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2156         (tic6x_dummy_id): Delete.
2157         (tic6x_gdbarch_init): Don't register deleted functions with
2158         gdbarch.
2159
2160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * sparc-tdep.c (sparc_unwind_pc): Delete.
2163         (sparc32_gdbarch_init): Don't register deleted function with
2164         gdbarch.
2165
2166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * sh-tdep.c (sh_unwind_sp): Delete.
2169         (sh_unwind_pc): Delete.
2170         (sh_dummy_id): Delete.
2171         (sh_gdbarch_init): Don't register deleted functions with
2172         gdbarch.
2173
2174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2175
2176         * score-tdep.c (score_unwind_sp): Delete.
2177         (score_unwind_pc): Delete.
2178         (score_dummy_id): Delete.
2179         (score_gdbarch_init): Don't register deleted functions with
2180         gdbarch.
2181
2182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2183
2184         * rx-tdep.c (rx_unwind_pc): Delete.
2185         (rx_unwind_sp): Delete.
2186         (rx_dummy_id): Delete.
2187         (rx_gdbarch_init): Don't register deleted functions with
2188         gdbarch.  Update comment.
2189
2190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2193         (rs6000_dummy_id): Delete.
2194         (rs6000_gdbarch_init): Don't register deleted functions with
2195         gdbarch.
2196
2197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * or1k-tdep.c (or1k_dummy_id): Delete.
2200         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2201
2202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * nios2-tdep.c (nios2_dummy_id): Delete.
2205         (nios2_unwind_sp): Delete.
2206         (nios2_gdbarch_init): Don't register deleted functions with
2207         gdbarch.
2208
2209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * nds32-tdep.c (nds32_dummy_id): Delete.
2212         (nds32_unwind_pc): Delete.
2213         (nds32_unwind_sp): Delete.
2214         (nds32_gdbarch_init): Don't register deleted functions with
2215         gdbarch.
2216
2217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * msp430-tdep.c (msp430_unwind_pc): Delete.
2220         (msp430_unwind_sp): Delete.
2221         (msp430_dummy_id): Delete.
2222         (msp430_gdbarch_init): Don't register deleted functions with
2223         gdbarch.
2224
2225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * moxie-tdep.c (moxie_unwind_sp): Delete.
2228         (moxie_unwind_pc): Delete.
2229         (moxie_dummy_id): Delete.
2230         (moxie_gdbarch_init): Don't register deleted functions with
2231         gdbarch.
2232
2233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2236         (mn10300_unwind_pc): Delete.
2237         (mn10300_unwind_sp): Delete.
2238         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2239         mn10300_unwind_sp.
2240         (mn10300_frame_unwind_init): Don't register deleted functions with
2241         gdbarch.
2242
2243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * mep-tdep.c (mep_unwind_pc): Delete.
2246         (mep_unwind_sp): Delete.
2247         (mep_dummy_id): Delete.
2248         (mep_gdbarch_init): Don't register deleted functions with
2249         gdbarch.
2250
2251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2254         (m68hc11_unwind_sp): Delete.
2255         (m68hc11_gdbarch_init): Don't register deleted functions with
2256         gdbarch.
2257
2258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * m32r-tdep.c (m32r_unwind_sp): Delete.
2261         (m32r_unwind_pc): Delete.
2262         (m32r_dummy_id): Delete.
2263         (m32r_gdbarch_init): Don't register deleted functions with
2264         gdbarch.
2265
2266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * m32c-tdep.c (m32c_unwind_pc): Delete.
2269         (m32c_unwind_sp): Delete.
2270         (m32c_dummy_id): Delete.
2271         (m32c_gdbarch_init): Don't register deleted functions with
2272         gdbarch.
2273
2274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2275
2276         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2277         (lm32_unwind_pc): Delete.
2278         (lm32_dummy_id): Delete.
2279         (lm32_gdbarch_init): Don't register deleted functions with
2280         gdbarch.
2281
2282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2285         (iq2000_unwind_pc): Delete.
2286         (iq2000_dummy_id): Delete.
2287         (iq2000_gdbarch_init): Don't register deleted functions with
2288         gdbarch.
2289
2290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * nds32-tdep.c (nds32_type_align): Delete.
2293         (nds32_push_dummy_call): Use type_align instead.
2294
2295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * arm-tdep.c (arm_type_align): Only handle vector override case.
2298         (arm_push_dummy_call): Use type_align.
2299         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2300
2301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2302
2303         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2304         case.
2305         (pass_on_stack): Use type_align.
2306         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2307         function.
2308
2309 2019-04-23  Tom Tromey  <tromey@adacore.com>
2310
2311         * dwarf2read.c (line_header::file_name_at): Remove unused
2312         overload.
2313
2314 2019-04-23  Tom de Vries  <tdevries@suse.de>
2315
2316         PR gdb/24438
2317         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2318         invocation.
2319
2320
2321 2019-03-27  Ali Tamur  <tamur@google.com>
2322
2323         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2324         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2325         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2326         (dwarf_expr_context::get_addr_index): Likewise
2327         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2328         (symbol_needs_eval_context::get_addr_index): Likewise
2329         (disassemble_dwarf_expression): Add DW_OP_addrx
2330         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2331         (read_cutu_die_from_dwo): Update comment
2332         (skip_one_die): Add DW_FORM_addrx
2333         (read_attribute_value): Likewise
2334         (var_decode_location): Add DW_OP_addrx
2335         (dwarf2_const_value_attr): Add DW_FORM_addrx
2336         (dump_die_shallow): Likewise
2337         (dwarf2_fetch_constant_bytes): Likewise
2338         (decode_locdesc): Add DW_OP_addrx
2339         (skip_form_bytes): Add DW_FORM_addrx
2340
2341 2019-04-22  Ali Tamur  <tamur@google.com>
2342
2343         * MAINTAINERS (Write After Approval): Add self.
2344
2345 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2346
2347         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2348         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2349         (open_symbol_file_object): Likewise.
2350         (svr4_default_sos): Add info parameter.
2351         (svr4_read_so_list): Likewise.
2352         (svr4_current_sos_direct): Adjust functions calls to pass down
2353         info.
2354         (svr4_current_sos_1): Add info parameter.
2355         (svr4_current_sos): Call get_svr4_info, pass info down to
2356         svr4_current_sos_1.
2357         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2358         get_svr4_info.
2359         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2360         get_svr4_info.
2361         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2362         to get_svr4_info.
2363         (probes_table_remove_objfile_probes): Likewise.
2364         (register_solib_event_probe): Add info parameter.
2365         (solist_update_incremental): Pass info parameter down to
2366         svr4_read_so_list.
2367         (disable_probes_interface): Add info parameter.
2368         (svr4_handle_solib_event): Pass current_program_space to
2369         get_svr4_info.  Adjust disable_probes_interface cleanup.
2370         (svr4_create_probe_breakpoints): Add info parameter, pass it
2371         down to register_solib_event_probe.
2372         (svr4_create_solib_event_breakpoints): Add info parameter,
2373         pass it down to svr4_create_probe_breakpoints.
2374         (enable_break): Pass info down to
2375         svr4_create_solib_event_breakpoints.
2376         (svr4_solib_create_inferior_hook): Pass current_program_space to
2377         get_svr4_info.
2378         (svr4_clear_solib): Likewise.
2379
2380 2019-04-22  Pedro Alves  <palves@redhat.com>
2381
2382         * solib-svr4.c (svr4_free_objfile_observer): New.
2383         (probe_and_action::objfile): New field.
2384         (probes_table_htab_remove_objfile_probes)
2385         (probes_table_remove_objfile_probes): New functions.
2386         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2387         in the new probe_and_action.  Don't store the probe in 'lookup'.
2388         (svr4_create_probe_breakpoints): Pass objfile to
2389         register_solib_event_probe.
2390         (_initialize_svr4_solib): Register a free_objfile observer.
2391
2392 2019-04-19  Tom Tromey  <tom@tromey.com>
2393
2394         * common/queue.h: Remove.
2395
2396 2019-04-19  Tom Tromey  <tom@tromey.com>
2397
2398         * event-loop.c: Don't include "common/queue.h".
2399
2400 2019-04-19  Tom Tromey  <tom@tromey.com>
2401
2402         * remote.c (remote_target): Use delete.
2403         * remote-notif.h: Include <list>, not "common/queue.h".
2404         (notif_client_p): Remove typedef.
2405         (remote_notif_state): Add constructor, destructor, initializer.
2406         <notif_queue>: Now a std::list.
2407         (remote_notif_state_xfree): Don't declare.
2408         * remote-notif.c (remote_notif_process, handle_notification)
2409         (remote_notif_state_allocate): Update.
2410         (~remote_notif_state): Rename from remote_notif_state_xfree.
2411
2412 2019-04-19  Tom Tromey  <tom@tromey.com>
2413
2414         * symfile.c (reread_symbols): Update.
2415         * objfiles.c (objfile_register_static_link)
2416         (objfile_lookup_static_link): Update
2417         (~objfile) Don't delete static_links.
2418         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2419
2420 2019-04-19  Tom Tromey  <tom@tromey.com>
2421
2422         * type-stack.h (struct type_stack) <insert>: Constify string.
2423         * type-stack.c (type_stack::insert): Constify string.
2424         * gdbtypes.h (lookup_template_type): Update.
2425         (address_space_name_to_int): Update.
2426         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2427         const.
2428         (lookup_template_type): Make name const.
2429         * c-exp.y: Update rules.
2430         (lex_one_token, classify_name, classify_inner_name)
2431         (c_print_token): Update.
2432         * p-exp.y: Update rules.
2433         (yylex): Update.
2434         * f-exp.y: Update rules.
2435         (yylex): Update.
2436         * d-exp.y: Update rules.
2437         (lex_one_token, classify_name, classify_inner_name): Update.
2438         * parse.c (write_dollar_variable, copy_name): Return std::string.
2439         * parser-defs.h (copy_name): Change return type.
2440         * m2-exp.y: Update rules.
2441         (yylex): Update.
2442         * go-exp.y (lex_one_token): Update.
2443         Update rules.
2444         (classify_unsafe_function, classify_packaged_name)
2445         (classify_name, yylex): Update.
2446
2447 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2448
2449         * configure.ac: add --enable-source-highlight switch.
2450         * configure: Regenerate.
2451         * top.c (print_gdb_version): plumb --enable-source-highlight
2452         status to "show configuration".
2453
2454 2019-04-19  Tom Tromey  <tromey@adacore.com>
2455
2456         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2457         Check ADA_TYPE_P.
2458         (empty_record, ada_template_to_fixed_record_type_1)
2459         (template_to_static_fixed_type)
2460         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2461         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2462         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2463         macros.
2464
2465 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2466
2467         PR symtab/24423:
2468         * source.c (print_source_lines_base): Advance "iter" when a
2469         control character is seen.
2470
2471 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2472
2473         * inferior.h (struct infcall_suspend_state_deleter):
2474         Catch exception in destructor to avoid crash.
2475
2476 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2477
2478         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2479         close to the add_com "shell".
2480
2481 2019-04-18  Tom Tromey  <tromey@adacore.com>
2482
2483         * process-stratum-target.h (class process_stratum_target)
2484         <stratum>: Add "final".
2485
2486 2019-04-17  Tom Tromey  <tromey@adacore.com>
2487
2488         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2489         against nullptr before use.
2490
2491 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2492
2493         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2494
2495 2019-04-17  Jim Wilson  <jimw@sifive.com>
2496             Andrew Burgess  <andrew.burgess@embecosm.com>
2497
2498         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2499         code read might fail, assume 4-byte breakpoint in that case.
2500
2501 2019-04-15  Leszek Swirski  <leszeks@google.com>
2502
2503         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2504         rather than a hand-rolled POD check when checking for forced MEMORY
2505         classification.
2506
2507 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2508
2509         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2510         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2511         function.
2512         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2513         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2514         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2515         declaration.
2516
2517 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2518
2519         * aarch64-linux-nat.c
2520         (aarch64_linux_nat_target::thread_architecture): Add override.
2521         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2522         each VQ.
2523
2524 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2527
2528 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2529
2530         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2531         target types of size 96-bits, add some additional comments, and
2532         check that the builtin type we found was the correct size.
2533
2534 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2535
2536         * utils.c (prompt_for_continue): Don't restore the styling at the
2537         end, as applied_style has the wrong value.  This fixes styling in
2538         long lists of file names that are interrupted by the "Continue?"
2539         prompt.
2540
2541 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2544         * c-lang.c (c_language_defn): Likewise.
2545         (cplus_language_defn): Likewise.
2546         (asm_language_defn): Likewise.
2547         (minimal_language_defn): Likewise.
2548         * d-lang.c (d_language_defn): Likewise.
2549         * f-lang.c (f_language_defn): Likewise.
2550         * go-lang.c (go_language_defn): Likewise.
2551         * language.c (unknown_language_defn): Likewise.
2552         (auto_language_defn): Likewise.
2553         * language.h (struct language_defn): Remove la_magic field.
2554         (LANG_MAGIC): Delete.
2555         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2556         * objc-lang.c (objc_language_defn): Likewise.
2557         * opencl-lang.c (opencl_language_defn): Likewise.
2558         * p-lang.c (pascal_language_defn): Likewise.
2559         * rust-lang.c (rust_language_defn): Likewise.
2560
2561 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * riscv-tdep.c (riscv_type_align): New function.
2564         (riscv_type_alignment): Delete.
2565         (riscv_arg_location): Use 'type_align'.
2566         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2567
2568 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2569
2570         * gdbtypes.c (type_align): A struct with no non-static fields also
2571         has alignment of 1.
2572
2573 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2574
2575         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2576         component to 0.
2577         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2578         member.
2579         (riscv_struct_info::analyse): New implementation using new
2580         analyse_inner member function.
2581         (riscv_struct_info::field_offset): New member function.
2582         (riscv_struct_info::m_offsets): New member variable.
2583         (riscv_struct_info::analyse_inner): New private member function,
2584         takes the old implementation of riscv_struct_info::analyse but
2585         extended to track field offsets.
2586         (riscv_call_arg_struct): Update the struct folding special cases
2587         to handle cases where empty C++ structs, which are non-zero
2588         length, are found.
2589         (riscv_arg_location): Initialise the length of each location, a
2590         non-zero length now indicates the location is in use.
2591         (riscv_push_dummy_call): Allow for the first location having a
2592         non-zero offset when setting up arguments.
2593         (riscv_return_value): Likewise, but for return values.
2594
2595 2019-04-11  Tom Tromey  <tromey@adacore.com>
2596
2597         * utils.c (internal_vproblem): Make "msg" const.
2598
2599 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2602         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2603         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2604         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2605
2606 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2607
2608         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2609         function.
2610         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2611         of amd64_collect_native_gregset.
2612         (amd64_linux_nat_target::store_registers): Likewise.
2613
2614 2019-04-10  Tom Tromey  <tom@tromey.com>
2615
2616         * symtab.c (lookup_global_symbol_from_objfile)
2617         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2618         * objfiles.h (class separate_debug_iterator): New.
2619         (class separate_debug_range): New.
2620         (struct objfile) <separate_debug_objfiles>: New method.
2621         (objfile_separate_debug_iterate): Don't declare.
2622         * objfiles.c (separate_debug_iterator::operator++): Rename from
2623         objfile_separate_debug_iterate.
2624         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2625         iterator.
2626         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2627         iterator.
2628
2629 2019-04-10  Tom Tromey  <tom@tromey.com>
2630
2631         * symfile.c (reread_symbols): Remove old comment.
2632         * objfiles.c (free_all_objfiles): Fix a typo.
2633
2634 2019-04-10  Tom Tromey  <tom@tromey.com>
2635
2636         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2637         * minsyms.c (lookup_minimal_symbol): Use foreach.
2638         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2639         (lookup_minimal_symbol_solib_trampoline): Likewise.
2640         * symfile.c (reread_symbols): Use foreach.
2641
2642 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2643             Tom Tromey  <tromey@adacore.com>
2644
2645         PR rust/24414:
2646         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2647         (rust_lex_int_test): Change "value" to be LONGEST.
2648         (rust_lex_tests): Add test for long integer literal.
2649
2650 2019-04-09  Tom Tromey  <tromey@adacore.com>
2651
2652         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2653         to bool.
2654         (extended_remote_target::attach): Update.
2655         (remote_target::remote_notice_new_inferior): Update.
2656         (remote_target::add_current_inferior_and_thread): Update.
2657         * inferior.c (exit_inferior_1): Use "false".
2658         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2659
2660 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2661
2662         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2663         the "start" command.
2664
2665 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2666
2667         * python/py-inferior.c (infpy_thread_from_thread_handle):
2668         Adjust comments to reflect renaming of thread_from_thread_handle
2669         to thread_from_handle.  Adjust keywords.  Fix type error message.
2670         (inferior_object_methods): Add thread_from_handle.  Retain
2671         thread_from_thread_handle, but mark it as deprecated.
2672
2673 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2674
2675         * gdbthread.h (find_thread_by_handle): Revise declaration.
2676         * thread.c (find_thread_by_handle): Likewise.  Adjust
2677         implementation too.
2678         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2679         support for buffer objects as handles.
2680
2681 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2682
2683         * python/py-infthread.c (thpy_thread_handle): New function.
2684         (thread_object_methods): Register thpy_thread_handle.
2685
2686 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2687
2688         * gdbthread.h (thread_to_thread_handle): Declare.
2689         * thread.c (gdbtypes.h): Include.
2690         (thread_to_thread_handle): New function.
2691
2692         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2693         (target_thread_info_to_thread_handle): Declare.
2694         * target.c (target_thread_info_to_thread_handle): New function.
2695         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2696         * target-delegates.c: Regenerate.
2697
2698         * linux-thread-db.c (class thread_db_target): Add method
2699         thread_info_to_thread_handle.
2700         (thread_db_target::thread_info_to_thread_handle): Define.
2701         * remote.c (class remote_target): Add new method
2702         thread_info_to_thread_handle.
2703         (remote_target::thread_info_to_thread_handle): Define.
2704
2705 2019-04-08  Pedro Alves  <palves@redhat.com>
2706
2707         * common/common-exceptions.c (throw_exception): Don't create
2708         named object to throw; throw directly.
2709         (throw_it): Likewise.  Don't initialize gdb_exception::message
2710         here, with new; pass FMT and AP to the ctor instead.
2711         * common/common-exceptions.h: Include <string>.
2712         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2713         const char *, va_list)): New ctor.  Use std::make_shared.
2714         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2715         errors)): Delete.
2716         (gdb_exception_error::gdb_exception_error(enum errors, const char
2717         *, va_list)): New.
2718         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2719         Add assertion.
2720         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2721         errors)): Delete.
2722         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2723         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2724         Add assertion.
2725
2726 2019-04-08  Tom Tromey  <tom@tromey.com>
2727
2728         * valops.c (value_rtti_indirect_type): Replace throw_exception
2729         with throw.
2730         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2731         with throw.
2732         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2733         throw.
2734         * target.c (target_translate_tls_address): Replace throw_exception
2735         with throw.
2736         * stack.c (frame_apply_command_count): Replace throw_exception
2737         with throw.
2738         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2739         throw.
2740         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2741         with throw.
2742         * rs6000-tdep.c (rs6000_frame_cache)
2743         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2744         * remote.c: Replace throw_exception with throw.
2745         * record-full.c (record_full_message, record_full_wait_1)
2746         (record_full_restore): Replace throw_exception with throw.
2747         * record-btrace.c:
2748         (get_thread_current_frame_id, record_btrace_start_replaying)
2749         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2750         (cmd_record_btrace_start): Replace throw_exception with throw.
2751         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2752         throw.
2753         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2754         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2755         * linespec.c:
2756         (find_linespec_symbols): Replace throw_exception with throw.
2757         * infrun.c (displaced_step_prepare, resume): Replace
2758         throw_exception with throw.
2759         * infcmd.c (post_create_inferior): Replace throw_exception with
2760         throw.
2761         * inf-loop.c (inferior_event_handler): Replace throw_exception
2762         with throw.
2763         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2764         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2765         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2766         (get_prev_frame_always, get_frame_pc_if_available)
2767         (get_frame_address_in_block_if_available, get_frame_language):
2768         Replace throw_exception with throw.
2769         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2770         throw_exception with throw.
2771         * eval.c (fetch_subexp_value, evaluate_var_value)
2772         (evaluate_funcall, evaluate_subexp_standard): Replace
2773         throw_exception with throw.
2774         * dwarf2loc.c (call_site_find_chain)
2775         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2776         Replace throw_exception with throw.
2777         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2778         with throw.
2779         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2780         throw.
2781         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2782         * completer.c (complete_line_internal): Replace throw_exception
2783         with throw.
2784         * compile/compile-object-run.c (compile_object_run): Replace
2785         throw_exception with throw.
2786         * cli/cli-script.c (process_next_line): Replace throw_exception
2787         with throw.
2788         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2789         (btrace_enable, btrace_maint_update_pt_packets): Replace
2790         throw_exception with throw.
2791         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2792         throw_exception with throw.
2793         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2794         throw_exception with throw.
2795         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2796         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2797         * aarch64-tdep.c (aarch64_make_prologue_cache)
2798         (aarch64_make_stub_cache): Replace throw_exception with throw.
2799
2800 2019-04-08  Tom Tromey  <tom@tromey.com>
2801
2802         * common/common-exceptions.c (throw_exception): Rename from
2803         throw_exception_cxx.  Remove old copy.  Make argument const.
2804         (throw_it): Create and throw exception objects directly.
2805         * common/common-exceptions.h (throw_exception): Make argument
2806         const.
2807         (struct gdb_exception_error): Add constructor.
2808         (struct gdb_exception_quit): Add constructor.
2809
2810 2019-04-08  Tom Tromey  <tom@tromey.com>
2811
2812         * common/common-exceptions.h (exception_rethrow): Don't declare.
2813         (TRY_SJLJ): Update comment.
2814         (TRY, CATCH, END_CATCH): Remove.
2815         * common/common-exceptions.c (exception_rethrow): Remove.
2816
2817 2019-04-08  Tom Tromey  <tom@tromey.com>
2818
2819         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2820         Remove.
2821         (gdb_exception_error): Rename from
2822         gdb_exception_RETURN_MASK_ERROR.
2823         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2824         (gdb_quit_bad_alloc): Update.
2825         * aarch64-tdep.c: Update.
2826         * ada-lang.c: Update.
2827         * ada-typeprint.c: Update.
2828         * ada-valprint.c: Update.
2829         * amd64-tdep.c: Update.
2830         * arch-utils.c: Update.
2831         * break-catch-throw.c: Update.
2832         * breakpoint.c: Update.
2833         * btrace.c: Update.
2834         * c-varobj.c: Update.
2835         * cli/cli-cmds.c: Update.
2836         * cli/cli-interp.c: Update.
2837         * cli/cli-script.c: Update.
2838         * common/common-exceptions.c: Update.
2839         * common/new-op.c: Update.
2840         * common/selftest.c: Update.
2841         * compile/compile-c-symbols.c: Update.
2842         * compile/compile-cplus-symbols.c: Update.
2843         * compile/compile-object-load.c: Update.
2844         * compile/compile-object-run.c: Update.
2845         * completer.c: Update.
2846         * corelow.c: Update.
2847         * cp-abi.c: Update.
2848         * cp-support.c: Update.
2849         * cp-valprint.c: Update.
2850         * darwin-nat.c: Update.
2851         * disasm-selftests.c: Update.
2852         * dtrace-probe.c: Update.
2853         * dwarf-index-cache.c: Update.
2854         * dwarf-index-write.c: Update.
2855         * dwarf2-frame-tailcall.c: Update.
2856         * dwarf2-frame.c: Update.
2857         * dwarf2loc.c: Update.
2858         * dwarf2read.c: Update.
2859         * eval.c: Update.
2860         * event-loop.c: Update.
2861         * event-top.c: Update.
2862         * exec.c: Update.
2863         * f-valprint.c: Update.
2864         * fbsd-tdep.c: Update.
2865         * frame-unwind.c: Update.
2866         * frame.c: Update.
2867         * gdbtypes.c: Update.
2868         * gnu-v3-abi.c: Update.
2869         * guile/guile-internal.h: Update.
2870         * guile/scm-block.c: Update.
2871         * guile/scm-breakpoint.c: Update.
2872         * guile/scm-cmd.c: Update.
2873         * guile/scm-disasm.c: Update.
2874         * guile/scm-frame.c: Update.
2875         * guile/scm-lazy-string.c: Update.
2876         * guile/scm-math.c: Update.
2877         * guile/scm-param.c: Update.
2878         * guile/scm-ports.c: Update.
2879         * guile/scm-pretty-print.c: Update.
2880         * guile/scm-symbol.c: Update.
2881         * guile/scm-symtab.c: Update.
2882         * guile/scm-type.c: Update.
2883         * guile/scm-value.c: Update.
2884         * i386-linux-tdep.c: Update.
2885         * i386-tdep.c: Update.
2886         * inf-loop.c: Update.
2887         * infcall.c: Update.
2888         * infcmd.c: Update.
2889         * infrun.c: Update.
2890         * jit.c: Update.
2891         * language.c: Update.
2892         * linespec.c: Update.
2893         * linux-fork.c: Update.
2894         * linux-nat.c: Update.
2895         * linux-tdep.c: Update.
2896         * linux-thread-db.c: Update.
2897         * main.c: Update.
2898         * mi/mi-cmd-break.c: Update.
2899         * mi/mi-cmd-stack.c: Update.
2900         * mi/mi-interp.c: Update.
2901         * mi/mi-main.c: Update.
2902         * objc-lang.c: Update.
2903         * p-valprint.c: Update.
2904         * parse.c: Update.
2905         * ppc-linux-tdep.c: Update.
2906         * printcmd.c: Update.
2907         * python/py-arch.c: Update.
2908         * python/py-breakpoint.c: Update.
2909         * python/py-cmd.c: Update.
2910         * python/py-finishbreakpoint.c: Update.
2911         * python/py-frame.c: Update.
2912         * python/py-framefilter.c: Update.
2913         * python/py-gdb-readline.c: Update.
2914         * python/py-inferior.c: Update.
2915         * python/py-infthread.c: Update.
2916         * python/py-lazy-string.c: Update.
2917         * python/py-linetable.c: Update.
2918         * python/py-objfile.c: Update.
2919         * python/py-param.c: Update.
2920         * python/py-prettyprint.c: Update.
2921         * python/py-progspace.c: Update.
2922         * python/py-record-btrace.c: Update.
2923         * python/py-record.c: Update.
2924         * python/py-symbol.c: Update.
2925         * python/py-type.c: Update.
2926         * python/py-unwind.c: Update.
2927         * python/py-utils.c: Update.
2928         * python/py-value.c: Update.
2929         * python/python.c: Update.
2930         * record-btrace.c: Update.
2931         * record-full.c: Update.
2932         * remote-fileio.c: Update.
2933         * remote.c: Update.
2934         * riscv-tdep.c: Update.
2935         * rs6000-aix-tdep.c: Update.
2936         * rs6000-tdep.c: Update.
2937         * rust-exp.y: Update.
2938         * rust-lang.c: Update.
2939         * s390-tdep.c: Update.
2940         * selftest-arch.c: Update.
2941         * solib-dsbt.c: Update.
2942         * solib-frv.c: Update.
2943         * solib-spu.c: Update.
2944         * solib-svr4.c: Update.
2945         * solib.c: Update.
2946         * sparc64-linux-tdep.c: Update.
2947         * stack.c: Update.
2948         * symfile-mem.c: Update.
2949         * symmisc.c: Update.
2950         * target.c: Update.
2951         * thread.c: Update.
2952         * top.c: Update.
2953         * tracefile-tfile.c: Update.
2954         * tui/tui.c: Update.
2955         * typeprint.c: Update.
2956         * unittests/cli-utils-selftests.c: Update.
2957         * unittests/parse-connection-spec-selftests.c: Update.
2958         * valops.c: Update.
2959         * valprint.c: Update.
2960         * value.c: Update.
2961         * varobj.c: Update.
2962         * windows-nat.c: Update.
2963         * x86-linux-nat.c: Update.
2964         * xml-support.c: Update.
2965
2966 2019-04-08  Tom Tromey  <tom@tromey.com>
2967
2968         * xml-support.c: Use C++ exception handling.
2969         * x86-linux-nat.c: Use C++ exception handling.
2970         * windows-nat.c: Use C++ exception handling.
2971         * varobj.c: Use C++ exception handling.
2972         * value.c: Use C++ exception handling.
2973         * valprint.c: Use C++ exception handling.
2974         * valops.c: Use C++ exception handling.
2975         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2976         handling.
2977         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2978         * typeprint.c: Use C++ exception handling.
2979         * tui/tui.c: Use C++ exception handling.
2980         * tracefile-tfile.c: Use C++ exception handling.
2981         * top.c: Use C++ exception handling.
2982         * thread.c: Use C++ exception handling.
2983         * target.c: Use C++ exception handling.
2984         * symmisc.c: Use C++ exception handling.
2985         * symfile-mem.c: Use C++ exception handling.
2986         * stack.c: Use C++ exception handling.
2987         * sparc64-linux-tdep.c: Use C++ exception handling.
2988         * solib.c: Use C++ exception handling.
2989         * solib-svr4.c: Use C++ exception handling.
2990         * solib-spu.c: Use C++ exception handling.
2991         * solib-frv.c: Use C++ exception handling.
2992         * solib-dsbt.c: Use C++ exception handling.
2993         * selftest-arch.c: Use C++ exception handling.
2994         * s390-tdep.c: Use C++ exception handling.
2995         * rust-lang.c: Use C++ exception handling.
2996         * rust-exp.y: Use C++ exception handling.
2997         * rs6000-tdep.c: Use C++ exception handling.
2998         * rs6000-aix-tdep.c: Use C++ exception handling.
2999         * riscv-tdep.c: Use C++ exception handling.
3000         * remote.c: Use C++ exception handling.
3001         * remote-fileio.c: Use C++ exception handling.
3002         * record-full.c: Use C++ exception handling.
3003         * record-btrace.c: Use C++ exception handling.
3004         * python/python.c: Use C++ exception handling.
3005         * python/py-value.c: Use C++ exception handling.
3006         * python/py-utils.c: Use C++ exception handling.
3007         * python/py-unwind.c: Use C++ exception handling.
3008         * python/py-type.c: Use C++ exception handling.
3009         * python/py-symbol.c: Use C++ exception handling.
3010         * python/py-record.c: Use C++ exception handling.
3011         * python/py-record-btrace.c: Use C++ exception handling.
3012         * python/py-progspace.c: Use C++ exception handling.
3013         * python/py-prettyprint.c: Use C++ exception handling.
3014         * python/py-param.c: Use C++ exception handling.
3015         * python/py-objfile.c: Use C++ exception handling.
3016         * python/py-linetable.c: Use C++ exception handling.
3017         * python/py-lazy-string.c: Use C++ exception handling.
3018         * python/py-infthread.c: Use C++ exception handling.
3019         * python/py-inferior.c: Use C++ exception handling.
3020         * python/py-gdb-readline.c: Use C++ exception handling.
3021         * python/py-framefilter.c: Use C++ exception handling.
3022         * python/py-frame.c: Use C++ exception handling.
3023         * python/py-finishbreakpoint.c: Use C++ exception handling.
3024         * python/py-cmd.c: Use C++ exception handling.
3025         * python/py-breakpoint.c: Use C++ exception handling.
3026         * python/py-arch.c: Use C++ exception handling.
3027         * printcmd.c: Use C++ exception handling.
3028         * ppc-linux-tdep.c: Use C++ exception handling.
3029         * parse.c: Use C++ exception handling.
3030         * p-valprint.c: Use C++ exception handling.
3031         * objc-lang.c: Use C++ exception handling.
3032         * mi/mi-main.c: Use C++ exception handling.
3033         * mi/mi-interp.c: Use C++ exception handling.
3034         * mi/mi-cmd-stack.c: Use C++ exception handling.
3035         * mi/mi-cmd-break.c: Use C++ exception handling.
3036         * main.c: Use C++ exception handling.
3037         * linux-thread-db.c: Use C++ exception handling.
3038         * linux-tdep.c: Use C++ exception handling.
3039         * linux-nat.c: Use C++ exception handling.
3040         * linux-fork.c: Use C++ exception handling.
3041         * linespec.c: Use C++ exception handling.
3042         * language.c: Use C++ exception handling.
3043         * jit.c: Use C++ exception handling.
3044         * infrun.c: Use C++ exception handling.
3045         * infcmd.c: Use C++ exception handling.
3046         * infcall.c: Use C++ exception handling.
3047         * inf-loop.c: Use C++ exception handling.
3048         * i386-tdep.c: Use C++ exception handling.
3049         * i386-linux-tdep.c: Use C++ exception handling.
3050         * guile/scm-value.c: Use C++ exception handling.
3051         * guile/scm-type.c: Use C++ exception handling.
3052         * guile/scm-symtab.c: Use C++ exception handling.
3053         * guile/scm-symbol.c: Use C++ exception handling.
3054         * guile/scm-pretty-print.c: Use C++ exception handling.
3055         * guile/scm-ports.c: Use C++ exception handling.
3056         * guile/scm-param.c: Use C++ exception handling.
3057         * guile/scm-math.c: Use C++ exception handling.
3058         * guile/scm-lazy-string.c: Use C++ exception handling.
3059         * guile/scm-frame.c: Use C++ exception handling.
3060         * guile/scm-disasm.c: Use C++ exception handling.
3061         * guile/scm-cmd.c: Use C++ exception handling.
3062         * guile/scm-breakpoint.c: Use C++ exception handling.
3063         * guile/scm-block.c: Use C++ exception handling.
3064         * guile/guile-internal.h: Use C++ exception handling.
3065         * gnu-v3-abi.c: Use C++ exception handling.
3066         * gdbtypes.c: Use C++ exception handling.
3067         * frame.c: Use C++ exception handling.
3068         * frame-unwind.c: Use C++ exception handling.
3069         * fbsd-tdep.c: Use C++ exception handling.
3070         * f-valprint.c: Use C++ exception handling.
3071         * exec.c: Use C++ exception handling.
3072         * event-top.c: Use C++ exception handling.
3073         * event-loop.c: Use C++ exception handling.
3074         * eval.c: Use C++ exception handling.
3075         * dwarf2read.c: Use C++ exception handling.
3076         * dwarf2loc.c: Use C++ exception handling.
3077         * dwarf2-frame.c: Use C++ exception handling.
3078         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3079         * dwarf-index-write.c: Use C++ exception handling.
3080         * dwarf-index-cache.c: Use C++ exception handling.
3081         * dtrace-probe.c: Use C++ exception handling.
3082         * disasm-selftests.c: Use C++ exception handling.
3083         * darwin-nat.c: Use C++ exception handling.
3084         * cp-valprint.c: Use C++ exception handling.
3085         * cp-support.c: Use C++ exception handling.
3086         * cp-abi.c: Use C++ exception handling.
3087         * corelow.c: Use C++ exception handling.
3088         * completer.c: Use C++ exception handling.
3089         * compile/compile-object-run.c: Use C++ exception handling.
3090         * compile/compile-object-load.c: Use C++ exception handling.
3091         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3092         * compile/compile-c-symbols.c: Use C++ exception handling.
3093         * common/selftest.c: Use C++ exception handling.
3094         * common/new-op.c: Use C++ exception handling.
3095         * cli/cli-script.c: Use C++ exception handling.
3096         * cli/cli-interp.c: Use C++ exception handling.
3097         * cli/cli-cmds.c: Use C++ exception handling.
3098         * c-varobj.c: Use C++ exception handling.
3099         * btrace.c: Use C++ exception handling.
3100         * breakpoint.c: Use C++ exception handling.
3101         * break-catch-throw.c: Use C++ exception handling.
3102         * arch-utils.c: Use C++ exception handling.
3103         * amd64-tdep.c: Use C++ exception handling.
3104         * ada-valprint.c: Use C++ exception handling.
3105         * ada-typeprint.c: Use C++ exception handling.
3106         * ada-lang.c: Use C++ exception handling.
3107         * aarch64-tdep.c: Use C++ exception handling.
3108
3109 2019-04-08  Tom Tromey  <tom@tromey.com>
3110
3111         * xml-support.c (gdb_xml_parser::parse): Update.
3112         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3113         * value.c (show_convenience): Update.
3114         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3115         (test_parse_flags_qcs): Update.
3116         * thread.c (thr_try_catch_cmd): Update.
3117         * target.c (target_translate_tls_address): Update.
3118         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3119         (info_frame_command_core, frame_apply_command_count): Update.
3120         * rust-exp.y (rust_lex_exception_test): Update.
3121         * riscv-tdep.c (riscv_print_one_register_info): Update.
3122         * remote.c (remote_target::enable_btrace): Update.
3123         * record-btrace.c (record_btrace_enable_warn): Update.
3124         * python/py-utils.c (gdbpy_convert_exception): Update.
3125         * printcmd.c (do_one_display, print_variable_and_value): Update.
3126         * mi/mi-main.c (mi_print_exception): Update.
3127         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3128         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3129         * linux-nat.c (linux_nat_target::attach): Update.
3130         * linux-fork.c (class scoped_switch_fork_info): Update.
3131         * infrun.c (displaced_step_prepare): Update.
3132         * infcall.c (call_function_by_hand_dummy): Update.
3133         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3134         * gnu-v3-abi.c (print_one_vtable): Update.
3135         * frame.c (get_prev_frame_always): Update.
3136         * f-valprint.c (info_common_command_for_block): Update.
3137         * exec.c (try_open_exec_file): Update.
3138         * exceptions.c (print_exception, exception_print)
3139         (exception_fprintf, exception_print_same): Update.
3140         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3141         * dwarf-index-cache.c (index_cache::store)
3142         (index_cache::lookup_gdb_index): Update.
3143         * darwin-nat.c (maybe_cache_shell): Update.
3144         * cp-valprint.c (cp_print_value_fields): Update.
3145         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3146         (gcc_cplus_symbol_address): Update.
3147         * compile/compile-c-symbols.c (gcc_convert_symbol)
3148         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3149         * common/selftest.c: Update.
3150         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3151         a std::string.
3152         (exception_try_scope_entry, exception_try_scope_exit): Don't
3153         declare.
3154         (struct exception_try_scope): Remove.
3155         (TRY): Don't use exception_try_scope.
3156         (struct gdb_exception): Add constructor, operator=.
3157         <what>: New method.
3158         (struct gdb_exception_RETURN_MASK_ALL)
3159         (struct gdb_exception_RETURN_MASK_ERROR)
3160         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3161         (struct gdb_quit_bad_alloc): Update.
3162         * common/common-exceptions.c (exception_none): Change
3163         initializer.
3164         (struct catcher) <state, exception>: Initialize inline.
3165         <prev>: Remove member.
3166         (current_catcher): Remove.
3167         (catchers): New global.
3168         (exceptions_state_mc_init): Simplify.
3169         (catcher_pop): Remove.
3170         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3171         (try_scope_depth, exception_try_scope_entry)
3172         (exception_try_scope_exit): Remove.
3173         (throw_exception_sjlj): Update.
3174         (exception_messages, exception_messages_size): Remove.
3175         (throw_it): Simplify.
3176         (gdb_exception_sliced_copy): Remove.
3177         (throw_exception_cxx): Update.
3178         * cli/cli-script.c (script_from_file): Update.
3179         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3180         Update.
3181         * ada-valprint.c (ada_val_print): Update.
3182         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3183         (create_excep_cond_exprs): Update.
3184
3185 2019-04-08  Tom Tromey  <tom@tromey.com>
3186
3187         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3188         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3189         (TRY, CATCH, END_CATCH): Remove some definitions.
3190         * common/common-exceptions.c: Don't use GDB_XCPT.
3191         (catcher_list_size): Remove.
3192         (throw_exception, throw_it): Simplify.
3193
3194 2019-04-05  Tom Tromey  <tom@tromey.com>
3195
3196         Revert the header-sorting patch.
3197         * ft32-tdep.c: Revert.
3198         * frv-tdep.c: Revert.
3199         * frv-linux-tdep.c: Revert.
3200         * frame.c: Revert.
3201         * frame-unwind.c: Revert.
3202         * frame-base.c: Revert.
3203         * fork-child.c: Revert.
3204         * findvar.c: Revert.
3205         * findcmd.c: Revert.
3206         * filesystem.c: Revert.
3207         * filename-seen-cache.h: Revert.
3208         * filename-seen-cache.c: Revert.
3209         * fbsd-tdep.c: Revert.
3210         * fbsd-nat.h: Revert.
3211         * fbsd-nat.c: Revert.
3212         * f-valprint.c: Revert.
3213         * f-typeprint.c: Revert.
3214         * f-lang.c: Revert.
3215         * extension.h: Revert.
3216         * extension.c: Revert.
3217         * extension-priv.h: Revert.
3218         * expprint.c: Revert.
3219         * exec.h: Revert.
3220         * exec.c: Revert.
3221         * exceptions.c: Revert.
3222         * event-top.c: Revert.
3223         * event-loop.c: Revert.
3224         * eval.c: Revert.
3225         * elfread.c: Revert.
3226         * dwarf2read.h: Revert.
3227         * dwarf2read.c: Revert.
3228         * dwarf2loc.c: Revert.
3229         * dwarf2expr.h: Revert.
3230         * dwarf2expr.c: Revert.
3231         * dwarf2-frame.c: Revert.
3232         * dwarf2-frame-tailcall.c: Revert.
3233         * dwarf-index-write.h: Revert.
3234         * dwarf-index-write.c: Revert.
3235         * dwarf-index-common.c: Revert.
3236         * dwarf-index-cache.h: Revert.
3237         * dwarf-index-cache.c: Revert.
3238         * dummy-frame.c: Revert.
3239         * dtrace-probe.c: Revert.
3240         * disasm.h: Revert.
3241         * disasm.c: Revert.
3242         * disasm-selftests.c: Revert.
3243         * dictionary.c: Revert.
3244         * dicos-tdep.c: Revert.
3245         * demangle.c: Revert.
3246         * dcache.h: Revert.
3247         * dcache.c: Revert.
3248         * darwin-nat.h: Revert.
3249         * darwin-nat.c: Revert.
3250         * darwin-nat-info.c: Revert.
3251         * d-valprint.c: Revert.
3252         * d-namespace.c: Revert.
3253         * d-lang.c: Revert.
3254         * ctf.c: Revert.
3255         * csky-tdep.c: Revert.
3256         * csky-linux-tdep.c: Revert.
3257         * cris-tdep.c: Revert.
3258         * cris-linux-tdep.c: Revert.
3259         * cp-valprint.c: Revert.
3260         * cp-support.c: Revert.
3261         * cp-namespace.c: Revert.
3262         * cp-abi.c: Revert.
3263         * corelow.c: Revert.
3264         * corefile.c: Revert.
3265         * continuations.c: Revert.
3266         * completer.h: Revert.
3267         * completer.c: Revert.
3268         * complaints.c: Revert.
3269         * coffread.c: Revert.
3270         * coff-pe-read.c: Revert.
3271         * cli-out.h: Revert.
3272         * cli-out.c: Revert.
3273         * charset.c: Revert.
3274         * c-varobj.c: Revert.
3275         * c-valprint.c: Revert.
3276         * c-typeprint.c: Revert.
3277         * c-lang.c: Revert.
3278         * buildsym.c: Revert.
3279         * buildsym-legacy.c: Revert.
3280         * build-id.h: Revert.
3281         * build-id.c: Revert.
3282         * btrace.c: Revert.
3283         * bsd-uthread.c: Revert.
3284         * breakpoint.h: Revert.
3285         * breakpoint.c: Revert.
3286         * break-catch-throw.c: Revert.
3287         * break-catch-syscall.c: Revert.
3288         * break-catch-sig.c: Revert.
3289         * blockframe.c: Revert.
3290         * block.c: Revert.
3291         * bfin-tdep.c: Revert.
3292         * bfin-linux-tdep.c: Revert.
3293         * bfd-target.c: Revert.
3294         * bcache.c: Revert.
3295         * ax-general.c: Revert.
3296         * ax-gdb.h: Revert.
3297         * ax-gdb.c: Revert.
3298         * avr-tdep.c: Revert.
3299         * auxv.c: Revert.
3300         * auto-load.c: Revert.
3301         * arm-wince-tdep.c: Revert.
3302         * arm-tdep.c: Revert.
3303         * arm-symbian-tdep.c: Revert.
3304         * arm-pikeos-tdep.c: Revert.
3305         * arm-obsd-tdep.c: Revert.
3306         * arm-nbsd-tdep.c: Revert.
3307         * arm-nbsd-nat.c: Revert.
3308         * arm-linux-tdep.c: Revert.
3309         * arm-linux-nat.c: Revert.
3310         * arm-fbsd-tdep.c: Revert.
3311         * arm-fbsd-nat.c: Revert.
3312         * arm-bsd-tdep.c: Revert.
3313         * arch-utils.c: Revert.
3314         * arc-tdep.c: Revert.
3315         * arc-newlib-tdep.c: Revert.
3316         * annotate.h: Revert.
3317         * annotate.c: Revert.
3318         * amd64-windows-tdep.c: Revert.
3319         * amd64-windows-nat.c: Revert.
3320         * amd64-tdep.c: Revert.
3321         * amd64-sol2-tdep.c: Revert.
3322         * amd64-obsd-tdep.c: Revert.
3323         * amd64-obsd-nat.c: Revert.
3324         * amd64-nbsd-tdep.c: Revert.
3325         * amd64-nbsd-nat.c: Revert.
3326         * amd64-nat.c: Revert.
3327         * amd64-linux-tdep.c: Revert.
3328         * amd64-linux-nat.c: Revert.
3329         * amd64-fbsd-tdep.c: Revert.
3330         * amd64-fbsd-nat.c: Revert.
3331         * amd64-dicos-tdep.c: Revert.
3332         * amd64-darwin-tdep.c: Revert.
3333         * amd64-bsd-nat.c: Revert.
3334         * alpha-tdep.c: Revert.
3335         * alpha-obsd-tdep.c: Revert.
3336         * alpha-nbsd-tdep.c: Revert.
3337         * alpha-mdebug-tdep.c: Revert.
3338         * alpha-linux-tdep.c: Revert.
3339         * alpha-linux-nat.c: Revert.
3340         * alpha-bsd-tdep.c: Revert.
3341         * alpha-bsd-nat.c: Revert.
3342         * aix-thread.c: Revert.
3343         * agent.c: Revert.
3344         * addrmap.c: Revert.
3345         * ada-varobj.c: Revert.
3346         * ada-valprint.c: Revert.
3347         * ada-typeprint.c: Revert.
3348         * ada-tasks.c: Revert.
3349         * ada-lang.c: Revert.
3350         * aarch64-tdep.c: Revert.
3351         * aarch64-ravenscar-thread.c: Revert.
3352         * aarch64-newlib-tdep.c: Revert.
3353         * aarch64-linux-tdep.c: Revert.
3354         * aarch64-linux-nat.c: Revert.
3355         * aarch64-fbsd-tdep.c: Revert.
3356         * aarch64-fbsd-nat.c: Revert.
3357         * aarch32-linux-nat.c: Revert.
3358
3359 2019-04-05  Tom Tromey  <tom@tromey.com>
3360
3361         * ft32-tdep.c: Sort headers.
3362         * frv-tdep.c: Sort headers.
3363         * frv-linux-tdep.c: Sort headers.
3364         * frame.c: Sort headers.
3365         * frame-unwind.c: Sort headers.
3366         * frame-base.c: Sort headers.
3367         * fork-child.c: Sort headers.
3368         * findvar.c: Sort headers.
3369         * findcmd.c: Sort headers.
3370         * filesystem.c: Sort headers.
3371         * filename-seen-cache.h: Sort headers.
3372         * filename-seen-cache.c: Sort headers.
3373         * fbsd-tdep.c: Sort headers.
3374         * fbsd-nat.h: Sort headers.
3375         * fbsd-nat.c: Sort headers.
3376         * f-valprint.c: Sort headers.
3377         * f-typeprint.c: Sort headers.
3378         * f-lang.c: Sort headers.
3379         * extension.h: Sort headers.
3380         * extension.c: Sort headers.
3381         * extension-priv.h: Sort headers.
3382         * expprint.c: Sort headers.
3383         * exec.h: Sort headers.
3384         * exec.c: Sort headers.
3385         * exceptions.c: Sort headers.
3386         * event-top.c: Sort headers.
3387         * event-loop.c: Sort headers.
3388         * eval.c: Sort headers.
3389         * elfread.c: Sort headers.
3390         * dwarf2read.h: Sort headers.
3391         * dwarf2read.c: Sort headers.
3392         * dwarf2loc.c: Sort headers.
3393         * dwarf2expr.h: Sort headers.
3394         * dwarf2expr.c: Sort headers.
3395         * dwarf2-frame.c: Sort headers.
3396         * dwarf2-frame-tailcall.c: Sort headers.
3397         * dwarf-index-write.h: Sort headers.
3398         * dwarf-index-write.c: Sort headers.
3399         * dwarf-index-common.c: Sort headers.
3400         * dwarf-index-cache.h: Sort headers.
3401         * dwarf-index-cache.c: Sort headers.
3402         * dummy-frame.c: Sort headers.
3403         * dtrace-probe.c: Sort headers.
3404         * disasm.h: Sort headers.
3405         * disasm.c: Sort headers.
3406         * disasm-selftests.c: Sort headers.
3407         * dictionary.c: Sort headers.
3408         * dicos-tdep.c: Sort headers.
3409         * demangle.c: Sort headers.
3410         * dcache.h: Sort headers.
3411         * dcache.c: Sort headers.
3412         * darwin-nat.h: Sort headers.
3413         * darwin-nat.c: Sort headers.
3414         * darwin-nat-info.c: Sort headers.
3415         * d-valprint.c: Sort headers.
3416         * d-namespace.c: Sort headers.
3417         * d-lang.c: Sort headers.
3418         * ctf.c: Sort headers.
3419         * csky-tdep.c: Sort headers.
3420         * csky-linux-tdep.c: Sort headers.
3421         * cris-tdep.c: Sort headers.
3422         * cris-linux-tdep.c: Sort headers.
3423         * cp-valprint.c: Sort headers.
3424         * cp-support.c: Sort headers.
3425         * cp-namespace.c: Sort headers.
3426         * cp-abi.c: Sort headers.
3427         * corelow.c: Sort headers.
3428         * corefile.c: Sort headers.
3429         * continuations.c: Sort headers.
3430         * completer.h: Sort headers.
3431         * completer.c: Sort headers.
3432         * complaints.c: Sort headers.
3433         * coffread.c: Sort headers.
3434         * coff-pe-read.c: Sort headers.
3435         * cli-out.h: Sort headers.
3436         * cli-out.c: Sort headers.
3437         * charset.c: Sort headers.
3438         * c-varobj.c: Sort headers.
3439         * c-valprint.c: Sort headers.
3440         * c-typeprint.c: Sort headers.
3441         * c-lang.c: Sort headers.
3442         * buildsym.c: Sort headers.
3443         * buildsym-legacy.c: Sort headers.
3444         * build-id.h: Sort headers.
3445         * build-id.c: Sort headers.
3446         * btrace.c: Sort headers.
3447         * bsd-uthread.c: Sort headers.
3448         * breakpoint.h: Sort headers.
3449         * breakpoint.c: Sort headers.
3450         * break-catch-throw.c: Sort headers.
3451         * break-catch-syscall.c: Sort headers.
3452         * break-catch-sig.c: Sort headers.
3453         * blockframe.c: Sort headers.
3454         * block.c: Sort headers.
3455         * bfin-tdep.c: Sort headers.
3456         * bfin-linux-tdep.c: Sort headers.
3457         * bfd-target.c: Sort headers.
3458         * bcache.c: Sort headers.
3459         * ax-general.c: Sort headers.
3460         * ax-gdb.h: Sort headers.
3461         * ax-gdb.c: Sort headers.
3462         * avr-tdep.c: Sort headers.
3463         * auxv.c: Sort headers.
3464         * auto-load.c: Sort headers.
3465         * arm-wince-tdep.c: Sort headers.
3466         * arm-tdep.c: Sort headers.
3467         * arm-symbian-tdep.c: Sort headers.
3468         * arm-pikeos-tdep.c: Sort headers.
3469         * arm-obsd-tdep.c: Sort headers.
3470         * arm-nbsd-tdep.c: Sort headers.
3471         * arm-nbsd-nat.c: Sort headers.
3472         * arm-linux-tdep.c: Sort headers.
3473         * arm-linux-nat.c: Sort headers.
3474         * arm-fbsd-tdep.c: Sort headers.
3475         * arm-fbsd-nat.c: Sort headers.
3476         * arm-bsd-tdep.c: Sort headers.
3477         * arch-utils.c: Sort headers.
3478         * arc-tdep.c: Sort headers.
3479         * arc-newlib-tdep.c: Sort headers.
3480         * annotate.h: Sort headers.
3481         * annotate.c: Sort headers.
3482         * amd64-windows-tdep.c: Sort headers.
3483         * amd64-windows-nat.c: Sort headers.
3484         * amd64-tdep.c: Sort headers.
3485         * amd64-sol2-tdep.c: Sort headers.
3486         * amd64-obsd-tdep.c: Sort headers.
3487         * amd64-obsd-nat.c: Sort headers.
3488         * amd64-nbsd-tdep.c: Sort headers.
3489         * amd64-nbsd-nat.c: Sort headers.
3490         * amd64-nat.c: Sort headers.
3491         * amd64-linux-tdep.c: Sort headers.
3492         * amd64-linux-nat.c: Sort headers.
3493         * amd64-fbsd-tdep.c: Sort headers.
3494         * amd64-fbsd-nat.c: Sort headers.
3495         * amd64-dicos-tdep.c: Sort headers.
3496         * amd64-darwin-tdep.c: Sort headers.
3497         * amd64-bsd-nat.c: Sort headers.
3498         * alpha-tdep.c: Sort headers.
3499         * alpha-obsd-tdep.c: Sort headers.
3500         * alpha-nbsd-tdep.c: Sort headers.
3501         * alpha-mdebug-tdep.c: Sort headers.
3502         * alpha-linux-tdep.c: Sort headers.
3503         * alpha-linux-nat.c: Sort headers.
3504         * alpha-bsd-tdep.c: Sort headers.
3505         * alpha-bsd-nat.c: Sort headers.
3506         * aix-thread.c: Sort headers.
3507         * agent.c: Sort headers.
3508         * addrmap.c: Sort headers.
3509         * ada-varobj.c: Sort headers.
3510         * ada-valprint.c: Sort headers.
3511         * ada-typeprint.c: Sort headers.
3512         * ada-tasks.c: Sort headers.
3513         * ada-lang.c: Sort headers.
3514         * aarch64-tdep.c: Sort headers.
3515         * aarch64-ravenscar-thread.c: Sort headers.
3516         * aarch64-newlib-tdep.c: Sort headers.
3517         * aarch64-linux-tdep.c: Sort headers.
3518         * aarch64-linux-nat.c: Sort headers.
3519         * aarch64-fbsd-tdep.c: Sort headers.
3520         * aarch64-fbsd-nat.c: Sort headers.
3521         * aarch32-linux-nat.c: Sort headers.
3522
3523 2019-04-04  Tom Tromey  <tom@tromey.com>
3524
3525         * varobj.c (varobj_create): Update.
3526         * rust-exp.y (struct rust_parser) <update_innermost_block,
3527         lookup_symbol>: New methods.
3528         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3529         Rename.
3530         (rust_parser::rust_lookup_type)
3531         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3532         * printcmd.c (display_command, do_one_display): Update.
3533         * parser-defs.h (struct parser_state) <parser_state>: Add
3534         "tracker" parameter.
3535         (block_tracker): New member.
3536         (class innermost_block_tracker) <innermost_block_tracker>: Add
3537         "types" parameter.
3538         <reset>: Remove method.
3539         (innermost_block): Don't declare.
3540         (null_post_parser): Update.
3541         * parse.c (innermost_block): Remove global.
3542         (write_dollar_variable): Update.
3543         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3544         Remove "tracker_types" parameter.
3545         (parse_expression): Add "tracker" parameter.
3546         (parse_expression_for_completion): Update.
3547         (null_post_parser): Add "tracker" parameter.
3548         * p-exp.y: Update rules.
3549         * m2-exp.y: Update rules.
3550         * language.h (struct language_defn) <la_post_parser>: Add
3551         "tracker" parameter.
3552         * go-exp.y: Update rules.
3553         * f-exp.y: Update rules.
3554         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3555         parameter.
3556         * d-exp.y: Update rules.
3557         * c-exp.y: Update rules.
3558         * breakpoint.c (set_breakpoint_condition): Create an
3559         innermost_block_tracker.
3560         (watch_command_1): Likewise.
3561         * ada-lang.c (resolve): Add "tracker" parameter.
3562         (resolve_subexp): Likewise.
3563         * ada-exp.y (write_var_from_sym): Update.
3564
3565 2019-04-04  Tom Tromey  <tom@tromey.com>
3566
3567         * type-stack.h: New file.
3568         * type-stack.c: New file.
3569         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3570         type-stack.h.
3571         (insert_into_type_stack, insert_type, push_type, push_type_int)
3572         (insert_type_address_space, pop_type, pop_type_int)
3573         (pop_typelist, pop_type_stack, append_type_stack)
3574         (push_type_stack, get_type_stack, push_typelist)
3575         (follow_type_instance_flags, follow_types): Don't declare.
3576         * parse.c (type_stack): Remove global.
3577         (parse_exp_in_context): Update.
3578         (insert_into_type_stack, insert_type, push_type, push_type_int)
3579         (insert_type_address_space, pop_type, pop_type_int)
3580         (pop_typelist, pop_type_stack, append_type_stack)
3581         (push_type_stack, get_type_stack, push_typelist)
3582         (follow_type_instance_flags, follow_types): Remove (moved to
3583         type-stack.c).
3584         * f-exp.y (type_stack): New global.
3585         Update rules.
3586         (push_kind_type, f_parse): Update.
3587         * d-exp.y (type_stack): New global.
3588         Update rules.
3589         (d_parse): Update.
3590         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3591         Update rules.
3592         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3593         (HFILES_NO_SRCDIR): Add type-stack.h.
3594
3595 2019-04-04  Tom Tromey  <tom@tromey.com>
3596
3597         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3598         (rust_parser::convert_ast_to_expression, rust_parse)
3599         (rust_lex_test_completion, rust_lex_tests): Update.
3600         * parser-defs.h (struct expr_completion_state): New.
3601         (struct parser_state) <parser_state>: Add completion parameter.
3602         <mark_struct_expression, mark_completion_tag>: New methods.
3603         <parse_completion, m_completion_state>: New members.
3604         (prefixify_expression, null_post_parser): Update.
3605         (mark_struct_expression, mark_completion_tag): Don't declare.
3606         * parse.c (parse_completion, expout_last_struct)
3607         (expout_tag_completion_type, expout_completion_name): Remove
3608         globals.
3609         (parser_state::mark_struct_expression)
3610         (parser_state::mark_completion_tag): Now methods.
3611         (prefixify_expression): Add last_struct parameter.
3612         (prefixify_subexp): Likewise.
3613         (parse_exp_1): Update.
3614         (parse_exp_in_context): Add cstate parameter.  Update.
3615         (parse_expression_for_completion): Create an
3616         expr_completion_state.
3617         (null_post_parser): Add "completion" parameter.
3618         * p-exp.y: Update rules.
3619         (yylex): Update.
3620         * language.h (struct language_defn) <la_post_parser>: Add
3621         "completing" parameter.
3622         * go-exp.y: Update rules.
3623         (lex_one_token): Update.
3624         * expression.h (parse_completion): Don't declare.
3625         * d-exp.y: Update rules.
3626         (lex_one_token): Update rules.
3627         * c-exp.y: Update rules.
3628         (lex_one_token): Update.
3629         * ada-lang.c (resolve): Add "parse_completion" parameter.
3630         (resolve_subexp): Likewise.
3631         (ada_resolve_function): Likewise.
3632
3633 2019-04-04  Tom Tromey  <tom@tromey.com>
3634
3635         * parser-defs.h (struct parser_state) <start_arglist,
3636         end_arglist>: New methods.
3637         <arglist_len, m_funcall_chain>: New members.
3638         (arglist_len, start_arglist, end_arglist): Don't declare.
3639         * parse.c (arglist_len, funcall_chain): Remove global.
3640         (start_arglist, end_arglist): Remove functions.
3641         (parse_exp_in_context): Update.
3642         * p-exp.y: Update rules.
3643         * m2-exp.y: Update rules.
3644         * go-exp.y: Update rules.
3645         * f-exp.y: Update rules.
3646         * d-exp.y: Update rules.
3647         * c-exp.y: Update rules.
3648
3649 2019-04-04  Tom Tromey  <tom@tromey.com>
3650
3651         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3652         lex_operator, push_back>: New methods.
3653         Update all rules.
3654         (rust_parser::lex_hex, lex_escape): Rename and update.
3655         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3656         (rust_parser::lex_operator): Rename and update.
3657         (rust_parser::lex_number, rustyylex, rustyyerror)
3658         (rust_lex_test_init, rust_lex_test_sequence)
3659         (rust_lex_test_push_back, rust_lex_tests): Update.
3660         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3661         parameter.
3662         <lexptr, prev_lexptr>: New members.
3663         (lexptr, prev_lexptr): Don't declare.
3664         * parse.c (lexptr, prev_lexptr): Remove globals.
3665         (parse_exp_in_context): Update.
3666         * p-exp.y (yylex, yyerror): Update.
3667         * m2-exp.y (parse_number, yylex, yyerror): Update.
3668         * go-exp.y (lex_one_token, yyerror): Update.
3669         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3670         * d-exp.y (lex_one_token, yyerror): Update.
3671         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3672         (lex_one_token, yyerror): Update.
3673         * ada-lex.l (YY_INPUT): Update.
3674         (rewind_to_char): Update.
3675         * ada-exp.y (yyerror): Update.
3676
3677 2019-04-04  Tom Tromey  <tom@tromey.com>
3678
3679         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3680         * parser-defs.h (struct parser_state) <parser_state>: Add new
3681         parameter.
3682         <comma_terminates>: New member.
3683         (comma_terminates): Don't declare global.
3684         * parse.c (comma_terminates): Remove global.
3685         (parse_exp_in_context): Update.
3686         * p-exp.y (yylex): Update.
3687         * m2-exp.y (yylex): Update.
3688         * go-exp.y (lex_one_token): Update.
3689         * f-exp.y (yylex): Update.
3690         * d-exp.y (lex_one_token): Update.
3691         * c-exp.y (lex_one_token): Update.
3692         * ada-lex.l: Update.
3693
3694 2019-04-04  Tom Tromey  <tom@tromey.com>
3695
3696         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3697         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3698         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3699         * parser-defs.h (paren_depth): Don't declare.
3700         * parse.c (paren_depth): Remove global.
3701         (parse_exp_in_context): Update.
3702         * p-exp.y (paren_depth): New global.
3703         (pascal_parse): Initialize it.
3704         * m2-exp.y (paren_depth): New global.
3705         (m2_parse): Initialize it.
3706         * go-exp.y (paren_depth): New global.
3707         (go_parse): Initialize it.
3708         * f-exp.y (paren_depth): New global.
3709         (f_parse): Initialize it.
3710         * d-exp.y (paren_depth): New global.
3711         (d_parse): Initialize it.
3712         * c-exp.y (paren_depth): New global.
3713         (c_parse): Initialize it.
3714         * ada-lex.l (paren_depth): New global.
3715         (lexer_init): Initialize it.
3716
3717 2019-04-04  Tom Tromey  <tom@tromey.com>
3718
3719         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3720         (rust_parser::convert_ast_to_type)
3721         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3722         * parser-defs.h (struct parser_state) <parser_state>: Add
3723         parameters.  Initialize new members.
3724         <expression_context_block, expression_context_pc>: New members.
3725         * parse.c (expression_context_block, expression_context_pc):
3726         Remove globals.
3727         (parse_exp_in_context): Update.
3728         * p-exp.y: Update all rules.
3729         (yylex): Update.
3730         * m2-exp.y: Update all rules.
3731         (yylex): Update.
3732         * go-exp.y (yylex): Update.
3733         * f-exp.y (yylex): Update.
3734         * d-exp.y: Update all rules.
3735         (yylex): Update.
3736         * c-exp.y: Update all rules.
3737         (lex_one_token, classify_name, yylex, c_parse): Update.
3738         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3739
3740 2019-04-04  Tom Tromey  <tom@tromey.com>
3741
3742         * gdbarch.h, gdbarch.c: Rebuild.
3743         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3744         * stap-probe.h:
3745         (struct stap_parse_info): Replace "parser_state" with
3746         "expr_builder".
3747         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3748         (parser_state): New class.
3749         * parse.c (expr_builder): Rename.
3750         (expr_builder::release): Rename.
3751         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3752         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3753         (write_exp_elt_longcst, write_exp_elt_floatcst)
3754         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3755         (write_exp_string_vector, write_exp_bitstring)
3756         (write_exp_msymbol, mark_struct_expression)
3757         (write_dollar_variable)
3758         (insert_type_address_space, increase_expout_size): Replace
3759         "parser_state" with "expr_builder".
3760         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3761         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3762         "parser_state" with "expr_builder".
3763
3764 2019-04-04  Tom Tromey  <tom@tromey.com>
3765
3766         * rust-exp.y: Replace "parse_language" with method call.
3767         * p-exp.y:
3768         (yylex): Replace "parse_language" with method call.
3769         * m2-exp.y:
3770         (yylex): Replace "parse_language" with method call.
3771         * go-exp.y (classify_name): Replace "parse_language" with method
3772         call.
3773         * f-exp.y (yylex): Replace "parse_language" with method call.
3774         * d-exp.y (lex_one_token): Replace "parse_language" with method
3775         call.
3776         * c-exp.y:
3777         (lex_one_token, classify_name, yylex): Replace "parse_language"
3778         with method call.
3779         * ada-exp.y (find_primitive_type, type_char)
3780         (type_system_address): Replace "parse_language" with method call.
3781
3782 2019-04-04  Tom Tromey  <tom@tromey.com>
3783
3784         * rust-exp.y: Replace "parse_gdbarch" with method call.
3785         * parse.c (write_dollar_variable, insert_type_address_space):
3786         Replace "parse_gdbarch" with method call.
3787         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3788         call.
3789         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3790         call.
3791         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3792         "parse_gdbarch" with method call.
3793         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3794         with method call.
3795         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3796         "parse_gdbarch" with method call.
3797         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3798         "parse_gdbarch" with method call.
3799         * c-exp.y (parse_type, parse_number, classify_name): Replace
3800         "parse_gdbarch" with method call.
3801         * ada-lex.l: Replace "parse_gdbarch" with method call.
3802         * ada-exp.y (parse_type, find_primitive_type, type_char)
3803         (type_system_address): Replace "parse_gdbarch" with method call.
3804
3805 2019-04-04  Tom Tromey  <tom@tromey.com>
3806
3807         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3808         * stap-probe.c (stap_parse_argument): Update.
3809         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3810         initial_size parameter.
3811         * rust-exp.y (rust_lex_tests): Update.
3812         * parse.c (parser_state): Update.
3813         (parse_exp_in_context): Update.
3814         * parser-defs.h (struct parser_state) <parser_state>: Remove
3815         "initial_size" parameter.
3816
3817 2019-04-04  Tom Tromey  <tom@tromey.com>
3818
3819         * parser-defs.h (increase_expout_size): Don't declare.
3820         * parse.c (increase_expout_size): Now static.
3821
3822 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3823
3824         * gnu-nat.c (gnu_nat_target::wait): Fix
3825         target_waitstatus_to_string call.
3826
3827 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * eval.c (evaluate_subexp_standard): Handle internal functions
3830         during Fortran function call handling.
3831
3832 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3833
3834         * NEWS: Mention new internal functions.
3835         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3836         (read_base_type): Use dwarf2_init_complex_target_type.
3837         * value.c (creal_internal_fn): New function.
3838         (cimag_internal_fn): New function.
3839         (_initialize_values): Register new internal functions.
3840
3841 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3842
3843         * infrun.c (stop_all_threads): If debug_infrun, always
3844         trace the wait status after wait_one, using
3845         target_waitstatus_to_string and target_pid_to_str.
3846         (handle_inferior_event): Replace various trace of
3847         wait status kind by a single trace.
3848         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3849         wait status kind image by target_waitstatus_to_string.
3850         * target/waitstatus.c (target_waitstatus_to_string): Fix
3851         obsolete comment.
3852
3853 2019-04-01  Tom Tromey  <tromey@adacore.com>
3854
3855         PR symtab/23331:
3856         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3857
3858 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3859             Pedro Alves  <palves@redhat.com>
3860
3861         * top.c (quit_force): Call 'finalize_values'.
3862         * value.c (finalize_values): New function.
3863         * value.h (finalize_values): Declare.
3864
3865 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3866
3867         * NEWS: Announce $_gdb_major and $_gdb_minor.
3868
3869         * top.c (init_gdb_version_vars): New function.
3870         (gdb_init): Call init_gdb_version_vars.
3871
3872 2019-03-29  Tom Tromey  <tromey@adacore.com>
3873
3874         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3875         help text.  Remove dead code.
3876
3877 2019-03-29  Keith Seitz  <keiths@redhat.com>
3878
3879         From Siddhesh Poyarekar:
3880         * f-lang.h (f77_get_upperbound): Return LONGEST.
3881         (f77_get_lowerbound): Likewise.
3882         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3883         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3884         print them.
3885         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3886         plongest to format print it.
3887         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3888         (f77_get_upperbound): Likewise.
3889         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3890         LOWER_BOUND to LONGEST.
3891         (f77_create_arrayprint_offset_tbl): Likewise.
3892
3893 2019-03-29  Keith Seitz  <keiths@redhat.com>
3894
3895         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3896         %s/pulongest for TYPE_LENGTH instead of %d in format
3897         strings.
3898         * ada-typerint.c (ada_print_type): Likewise.
3899         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3900         * compile/compile-c-support.c (generate_register_struct): Likewise.
3901         * gdbtypes.c (recursive_dump_type): Likewise.
3902         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3903         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3904         instead of %d in format strings.
3905         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3906         to std::min to ULONGEST.
3907         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3908         instead of %d in format strings.
3909         * tracepoint.c (info_scope_command): Likewise.
3910         * typeprint.c (print_offset_data::update)
3911         (print_offset_data::finish): Likewise.
3912         * xtensa-tdep.c (xtensa_store_return_value)
3913         (xtensa_push_dummy_call): Likewise.
3914
3915 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3916
3917         * windows-nat.c (display_selector): Fixed format specifications
3918         for 64-bit Cygwin.
3919
3920 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3921
3922         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3923
3924 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3925
3926         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3927         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3928         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3929         (nios2_linux_init_abi): Install it.
3930
3931 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3932
3933         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3934
3935 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3936
3937         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3938
3939 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940             Tom Tromey  <tromey@adacore.com>
3941
3942         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3943
3944 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3945
3946         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3947         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3948         method to compute the bounds of range types. Also print "[evaluated]"
3949         if the bounds' values come from a dynamic evaluation.
3950
3951 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3952
3953         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3954         whitespace when pretty printing is on.
3955
3956 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3957
3958         * ppc-linux-nat.c: Add include.
3959
3960 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3961
3962         * NEWS: Mention AArch64 Pointer Authentication.
3963
3964 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * arm-linux-nat.c: Add include.
3967
3968 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3969
3970         * source-cache.c (source_cache::get_source_lines): Re-read
3971         fullname after calling open_source_file.
3972
3973 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3974
3975         * NEWS: Mention TLS support for FreeBSD.
3976
3977 2019-03-25  Tom Tromey  <tromey@adacore.com>
3978
3979         * minsyms.c (BUNCH_SIZE): Update comment.
3980         (~minimal_symbol_reader): Remove old comment.
3981         (compact_minimal_symbols): Update comment.
3982         (minimal_symbol_reader::install): Remove old comment.  Update
3983         other comments.
3984
3985 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3986
3987         * s390-linux-nat.c: Add include.
3988
3989 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3990
3991         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3992         Call linux_get_hwcap.
3993         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3994         Likewise.
3995         (aarch64_linux_get_hwcap): Remove function.
3996         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3997         declaration.
3998         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3999         linux_get_hwcap.
4000         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4001         * linux-tdep.c (linux_get_hwcap): Add function.
4002         (linux_get_hwcap2): Likewise.
4003         * linux-tdep.h (linux_get_hwcap): Add declaration.
4004         (linux_get_hwcap2): Likewise.
4005         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4006         (ppc_linux_get_hwcap2): Likewise.
4007         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4008         linux_get_hwcap.
4009         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4010         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4011         (ppc_linux_nat_target::read_description): Likewise.
4012         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4013         * s390-linux-nat.c: Likewise.
4014         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4015
4016 2019-03-24  Tom Tromey  <tom@tromey.com>
4017
4018         * ada-lang.c (standard_lookup): Simplify initialization.
4019         (ada_lookup_symbol_nonlocal): Simplify return.
4020         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4021         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4022         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4023         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4024         initialization.
4025         * solib.c (solib_global_lookup): Simplify.
4026         * symtab.c (null_block_symbol): Remove.
4027         (symbol_cache_lookup): Simplify returns.
4028         (lookup_language_this): Simplify returns.
4029         (lookup_symbol_aux): Simplify return.
4030         (lookup_local_symbol): Simplify returns.
4031         (lookup_global_symbol_from_objfile): Simplify return.
4032         (lookup_symbol_in_objfile_symtabs)
4033         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4034         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4035         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4036         * cp-namespace.c (cp_lookup_bare_symbol)
4037         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4038         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4039         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4040         (cp_lookup_symbol_via_imports): Simplify initialization.
4041         (find_symbol_in_baseclass): Likewise.
4042         * symtab.h (null_block_symbol): Remove.
4043         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4044         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4045         (d_lookup_symbol_module): Likewise.
4046         (find_symbol_in_baseclass): Simplify initialization.
4047
4048 2019-03-24  Tom Tromey  <tom@tromey.com>
4049
4050         * expression.h: Don't include symtab.h.
4051         (struct block): Forward declare.
4052
4053 2019-03-24  Tom Tromey  <tom@tromey.com>
4054
4055         * c-exp.y (typebase): Remove casts.
4056         * gdbtypes.c (lookup_unsigned_typename, )
4057         (lookup_signed_typename): Remove cast.
4058         * eval.c (parse_to_comma_and_eval): Remove cast.
4059         * parse.c (write_dollar_variable): Remove cast.
4060         * block.h (struct block) <superblock>: Now const.
4061         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4062         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4063         (map_block): Make "block" const.
4064         * symfile.h (struct quick_symbol_functions)
4065         <map_matching_symbols>: Constify block argument to "callback".
4066         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4067         const.
4068         (find_pc_sect_compunit_symtab): Make "b" const.
4069         (find_symbol_at_address): Likewise.
4070         (search_symbols): Likewise.
4071         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4072         (dw2_debug_names_lookup_symbol): Likewise.
4073         (dw2_map_matching_symbols): Update.
4074         * p-valprint.c (pascal_val_print): Remove "block".
4075         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4076         (aux_add_nonlocal_symbols): Make "block" const.
4077         (resolve_subexp): Remove cast.
4078         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4079         const.
4080         (iterate_over_file_blocks): Likewise.
4081         * f-exp.y (%union) <bval>: Remove.
4082         * coffread.c (patch_opaque_types): Make "b" const.
4083         * spu-tdep.c (spu_catch_start): Make "block" const.
4084         * c-valprint.c (print_unpacked_pointer): Remove "block".
4085         * symmisc.c (dump_symtab_1): Make "b" const.
4086         (block_depth): Make "block" const.
4087         * d-exp.y (%union) <bval>: Remove.
4088         * cp-support.h (cp_lookup_rtti_type): Update.
4089         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4090         * psymtab.c (psym_lookup_symbol): Make "block" const.
4091         (maintenance_check_psymtabs): Make "b" const.
4092         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4093         (enumerate_locals, enumerate_args): Update.
4094         * python/py-symtab.c (stpy_global_block): Make "block" const.
4095         (stpy_static_block): Likewise.
4096         * inline-frame.c (block_starting_point_at): Make "new_block"
4097         const.
4098         * block.c (find_block_in_blockvector): Make return type const.
4099         (blockvector_for_pc_sect): Make "b" const.
4100         (find_block_in_blockvector): Make "b" const.
4101
4102 2019-03-23  Tom Tromey  <tom@tromey.com>
4103
4104         * varobj.c (varobj_create): Update.
4105         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4106         * printcmd.c (display_command, do_one_display): Don't reset
4107         innermost_block.
4108         * parser-defs.h (enum innermost_block_tracker_type): Move to
4109         expression.h.
4110         (innermost_block): Update comment.
4111         * parse.c (parse_exp_1): Add tracker_types parameter.
4112         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4113         tracker_types parameter.  Reset innermost_block.
4114         (parse_exp_in_context): Remove.
4115         (parse_expression_for_completion): Update.
4116         * objfiles.c (~objfile): Don't reset expression_context_block or
4117         innermost_block.
4118         * expression.h (enum innermost_block_tracker_type): Move from
4119         parser-defs.h.
4120         (parse_exp_1): Add tracker_types parameter.
4121         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4122         reset innermost_block.
4123
4124 2019-03-23  Tom Tromey  <tom@tromey.com>
4125
4126         * objfiles.h: Include bcache.h.
4127
4128 2019-03-23  Tom Tromey  <tom@tromey.com>
4129
4130         * linespec.c (get_current_search_block): Use
4131         scoped_restore_current_language.
4132         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4133
4134 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4135             Jiong Wang  <jiong.wang@arm.com>
4136
4137         * aarch64-linux-tdep.c
4138         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4139         section.
4140         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4141
4142 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4143             Jiong Wang  <jiong.wang@arm.com>
4144
4145         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4146         instructions.
4147         (aarch64_analyze_prologue_test): Add PACIASP test.
4148         (aarch64_prologue_prev_register): Unmask PC value.
4149
4150 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4151             Jiong Wang  <jiong.wang@arm.com>
4152
4153         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4154         (aarch64_dwarf2_prev_register): Unmask PC value.
4155         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4156         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4157         DW_CFA_AARCH64_negate_ra_state.
4158         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4159
4160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4161             Jiong Wang  <jiong.wang@arm.com>
4162
4163         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4164         registers.
4165         (aarch64_pseudo_register_name): Likewise.
4166         (aarch64_pseudo_register_type): Likewise.
4167         (aarch64_pseudo_register_reggroup_p): Likewise.
4168         (aarch64_gdbarch_init): Add pauth registers.
4169         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4170         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4171         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4172         (struct gdbarch_tdep): Add regnum for ra_state.
4173
4174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4175             Jiong Wang  <jiong.wang@arm.com>
4176
4177         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4178
4179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4180             Jiong Wang  <jiong.wang@arm.com>
4181
4182         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4183         function.
4184         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4185         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4186         (aarch64_gdbarch_init): Add puth registers.
4187         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4188         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4189         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4190
4191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4192             Jiong Wang  <jiong.wang@arm.com>
4193
4194         * aarch64-linux-nat.c
4195         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4196         * aarch64-linux-tdep.c
4197         (aarch64_linux_core_read_description): Likewise.
4198         (aarch64_linux_get_hwcap): New function.
4199         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4200         (aarch64_linux_get_hwcap): New declaration.
4201
4202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4203             Jiong Wang  <jiong.wang@arm.com>
4204
4205         * aarch64-linux-nat.c
4206         (aarch64_linux_nat_target::read_description): Add pauth param.
4207         * aarch64-linux-tdep.c
4208         (aarch64_linux_core_read_description): Likewise.
4209         * aarch64-tdep.c (struct target_desc): Add in pauth.
4210         (aarch64_read_description): Add pauth param.
4211         (aarch64_gdbarch_init): Likewise.
4212         * aarch64-tdep.h (aarch64_read_description): Likewise.
4213         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4214         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4215         * features/Makefile: Add new files.
4216         * features/aarch64-pauth.c: New file.
4217         * features/aarch64-pauth.xml: New file.
4218
4219 2019-03-20  Tom Tromey  <tromey@adacore.com>
4220
4221         * infrun.c (handle_inferior_event): Rename from
4222         handle_inferior_event_1.  Create a scoped_value_mark.
4223         (handle_inferior_event): Remove.
4224
4225 2019-03-19  Tom Tromey  <tromey@adacore.com>
4226
4227         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4228         * infrun.h (print_stop_event): Add "displays" parameter.
4229         * infrun.c (print_stop_event): Add "displays" parameter.
4230
4231 2019-03-19  Pedro Alves  <palves@redhat.com>
4232
4233         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4234         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4235         to -1.  Fix TABs vs spaces.
4236         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4237         * tui/tui-out.h (tui_ui_out) Add intro comments.
4238         <m_line, m_start_of_line>: In-class initialize, and add describing
4239         comment.
4240
4241 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4242
4243         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4244         variable names.
4245         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4246
4247 2019-03-18  Pedro Alves  <palves@redhat.com>
4248             Eli Zaretskii <eliz@gnu.org>
4249
4250         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4251         m_line and m_start_of_line.
4252
4253 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4254
4255         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4256         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4257         it returns a newline.  This fixes a regression in TU mode, whereby
4258         the next line is output on the same screen line as the user input.
4259
4260 2019-03-18  Tom Tromey  <tromey@adacore.com>
4261
4262         * minsyms.c (minimal_symbol_reader::install): Remove call to
4263         obstack_blank.
4264
4265 2019-03-18  Pedro Alves  <palves@redhat.com>
4266
4267         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4268         New globals.
4269         (apply_style): New, factored out from ...
4270         (apply_ansi_escape): ... this.  Handle reverse video mode.
4271         (tui_set_reverse_mode): New function.
4272         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4273         * tui/tui-winsource.c (tui_show_source_line): Use
4274         tui_set_reverse_mode instead of setting A_STANDOUT.
4275         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4276         New setter methods.
4277
4278 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4279
4280         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4281         Handle tabs.
4282
4283 2019-03-18  Tom Tromey  <tromey@adacore.com>
4284
4285         * ada-lang.c (empty_array): Add "high" parameter.
4286         (ada_evaluate_subexp): Update.
4287
4288 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4289
4290         * unittests/string_view-selftests.c: Define
4291         _initialize_string_view_selftests unconditionally.
4292
4293 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4294
4295         PR gdb/24350
4296         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4297
4298 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4299
4300         PR gdb/24351
4301         * windows-nat.c (display_selector): Fix format specifiers.
4302
4303 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4304
4305         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4306         tui_refill_source_window instead of tui_refresh_win, to update the
4307         current execution line.  This fixes redisplay of the current line
4308         when stepping through the code with "next" or "step".
4309
4310 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4311
4312         * source-cache.c (source_cache::get_source_lines): Call
4313         find_source_lines to initialize s->nlines.  This fixes vertical
4314         scrolling of TUI source window when the DOWN arrow is pressed.
4315
4316 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4317
4318         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4319         linux-thread-db.c (_initialize_thread_db): Likewise.
4320
4321 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4322
4323         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4324         wclrtoeol in tui_show_source_line".  This reverts changes made in
4325         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4326
4327 2019-03-15  Tom Tromey  <tom@tromey.com>
4328
4329         * symtab.h (struct minimal_symbol): Derive from
4330         general_symbol_info.
4331         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4332         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4333         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4334         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4335         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4336         (MSYMBOL_SEARCH_NAME): Update.
4337         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4338         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4339         * minsyms.c (minimal_symbol_reader::record_full): Update.
4340
4341 2019-03-15  Tom Tromey  <tom@tromey.com>
4342
4343         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4344
4345 2019-03-15  Tom Tromey  <tom@tromey.com>
4346
4347         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4348         unique_xmalloc_ptr.
4349         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4350         Update.
4351         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4352         (build_minimal_symbol_hash_tables)
4353         (minimal_symbol_reader::install): Update.
4354
4355 2019-03-15  Tom Tromey  <tom@tromey.com>
4356
4357         * symtab.c (create_demangled_names_hash): Update.
4358         (symbol_set_names): Update.
4359         * objfiles.h (struct objfile_per_bfd_storage)
4360         <demangled_names_hash>: Now an htab_up.
4361         * objfiles.c (objfile_per_bfd_storage): Simplify.
4362
4363 2019-03-15  Tom Tromey  <tom@tromey.com>
4364
4365         * objfiles.h (struct objfile_per_bfd_storage): Declare
4366         destructor.
4367         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4368         New.
4369         (get_objfile_bfd_data): Use new.  Don't initialize
4370         language_of_main.
4371         (free_objfile_per_bfd_storage): Remove.
4372         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4373
4374 2019-03-15  Tom Tromey  <tom@tromey.com>
4375
4376         * symfile.c (reread_symbols): Update.
4377         * objfiles.c (objfile::objfile): Update.
4378         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4379         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4380         comment.
4381         (minimal_symbol_reader::install): Update.
4382         (terminate_minimal_symbol_table): Remove.
4383         * jit.c (jit_object_close_impl): Update.
4384
4385 2019-03-15  Tom Tromey  <tom@tromey.com>
4386
4387         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4388         initializations.
4389
4390 2019-03-15  Tom Tromey  <tom@tromey.com>
4391
4392         * objfiles.h (struct objfile_per_bfd_storage)
4393         <demangled_hash_languages>: Now a bitset.
4394         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4395         (lookup_minimal_symbol): Update.
4396
4397 2019-03-15  Tom Tromey  <tom@tromey.com>
4398
4399         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4400         Don't return the symbol.
4401         * coffread.c (record_minimal_symbol): Use record_full.
4402
4403 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4404
4405         The MS-Windows port of ncurses fails to switch to a color pair if
4406         one or both of the colors are the implicit default colors.  This
4407         change records the default colors when TUI is initialized, and
4408         then specifies them explicitly when a color pair uses the default
4409         colors.  This allows color styling in TUI mode on MS-Windows.
4410
4411         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4412         ncurses_norm_attr.
4413         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4414         colors in ncurses_norm_attr.
4415         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4416         "none", replace it with the default color recorded in
4417         ncurses_norm_attr.
4418
4419 2019-03-14  Tom Tromey  <tromey@adacore.com>
4420
4421         * source-cache.h (class source_cache) <get_source_lines>: Return
4422         std::string.
4423         * source-cache.c (source_cache::extract_lines): Handle case where
4424         first_pos==npos.  Return std::string.
4425         (source_cache::get_source_lines): Update.
4426
4427 2019-03-14  Tom Tromey  <tromey@adacore.com>
4428
4429         * NEWS: Add item for "style sources" commands.
4430         * source-cache.c (source_cache::get_source_lines): Check
4431         source_styling.
4432         * cli/cli-style.c (source_styling): New global.
4433         (_initialize_cli_style): Add "style sources" commands.
4434         (show_style_sources): New function.
4435         * cli/cli-style.h (source_styling): Declare.
4436
4437 2019-03-14  Pedro Alves  <palves@redhat.com>
4438             Tom Tromey  <tromey@adacore.com>
4439
4440         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4441         * tui/tui-winsource.c (tui_refill_source_window): New function,
4442         from...
4443         (tui_horizontal_source_scroll): ... here.  Move some logic.
4444         * cli/cli-style.c (set_style_enabled): Notify new observable.
4445         * tui/tui-hooks.c (tui_redisplay_source): New function.
4446         (tui_attach_detach_observers): Attach or detach
4447         tui_redisplay_source.
4448         * observable.h (source_styling_changed): New observable.
4449         * observable.c: Define source_styling_changed observable.
4450
4451 2019-03-13  Tom Tromey  <tromey@adacore.com>
4452
4453         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4454         (i386_gnu_nat_target::store_registers): Update.
4455         * target-debug.h (target_debug_print_std_string): New macro.
4456         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4457         * windows-tdep.c (display_one_tib): Update.
4458         * tui/tui-stack.c (tui_make_status_line): Update.
4459         * top.c (print_inferior_quit_action): Update.
4460         * thread.c (thr_try_catch_cmd): Update.
4461         (add_thread_with_info): Update.
4462         (thread_target_id_str): Update.
4463         (thr_try_catch_cmd): Update.
4464         (thread_command): Update.
4465         (thread_find_command): Update.
4466         * record-btrace.c (record_btrace_target::info_record)
4467         (record_btrace_resume_thread, record_btrace_target::resume)
4468         (record_btrace_cancel_resume, record_btrace_step_thread)
4469         (record_btrace_target::wait, record_btrace_target::wait)
4470         (record_btrace_target::wait, record_btrace_target::stop): Update.
4471         * progspace.c (print_program_space): Update.
4472         * process-stratum-target.c
4473         (process_stratum_target::thread_address_space): Update.
4474         * linux-fork.c (linux_fork_mourn_inferior)
4475         (detach_checkpoint_command, info_checkpoints_command)
4476         (linux_fork_context): Update.
4477         (linux_fork_detach): Update.
4478         (class scoped_switch_fork_info): Update.
4479         (delete_checkpoint_command): Update.
4480         * infrun.c (follow_fork_inferior): Update.
4481         (follow_fork_inferior): Update.
4482         (proceed_after_vfork_done): Update.
4483         (handle_vfork_child_exec_or_exit): Update.
4484         (follow_exec): Update.
4485         (displaced_step_prepare_throw): Update.
4486         (displaced_step_restore): Update.
4487         (start_step_over): Update.
4488         (resume_1): Update.
4489         (clear_proceed_status_thread): Update.
4490         (proceed): Update.
4491         (print_target_wait_results): Update.
4492         (do_target_wait): Update.
4493         (context_switch): Update.
4494         (stop_all_threads): Update.
4495         (restart_threads): Update.
4496         (finish_step_over): Update.
4497         (handle_signal_stop): Update.
4498         (switch_back_to_stepped_thread): Update.
4499         (keep_going_pass_signal): Update.
4500         (print_exited_reason): Update.
4501         (normal_stop): Update.
4502         * inferior.c (inferior_pid_to_str): Change return type.
4503         (print_selected_inferior): Update.
4504         (add_inferior): Update.
4505         (detach_inferior): Update.
4506         * dummy-frame.c (fprint_dummy_frames): Update.
4507         * dcache.c (dcache_info_1): Update.
4508         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4509         (btrace_fetch, btrace_clear): Update.
4510         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4511         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4512         type.
4513         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4514         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4515         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4516         * gdbarch.c, gdbarch.h: Rebuild.
4517         * gdbarch.sh (core_pid_to_str): Change return type.
4518         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4519         return type.
4520         (windows_nat_target::pid_to_str): Change return type.
4521         (windows_delete_thread): Update.
4522         (windows_nat_target::attach): Update.
4523         (windows_nat_target::files_info): Update.
4524         * target-delegates.c: Rebuild.
4525         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4526         return type.
4527         (sol_thread_target::pid_to_str): Change return type.
4528         * remote.c (class remote_target) <pid_to_str>: Change return
4529         type.
4530         (remote_target::pid_to_str): Change return type.
4531         (extended_remote_target::attach, remote_target::remote_stop_ns)
4532         (remote_target::remote_notif_remove_queued_reply)
4533         (remote_target::push_stop_reply, remote_target::disable_btrace):
4534         Update.
4535         (extended_remote_target::attach): Update.
4536         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4537         type.
4538         (gdbsim_target::pid_to_str): Change return type.
4539         * ravenscar-thread.c (struct ravenscar_thread_target)
4540         <pid_to_str>: Change return type.
4541         (ravenscar_thread_target::pid_to_str): Change return type.
4542         * procfs.c (class procfs_target) <pid_to_str>: Change return
4543         type.
4544         (procfs_target::pid_to_str): Change return type.
4545         (procfs_target::attach): Update.
4546         (procfs_target::detach): Update.
4547         (procfs_target::fetch_registers): Update.
4548         (procfs_target::store_registers): Update.
4549         (procfs_target::wait): Update.
4550         (procfs_target::files_info): Update.
4551         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4552         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4553         return type.
4554         (nto_procfs_target::pid_to_str): Change return type.
4555         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4556         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4557         return type.
4558         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4559         (exit_lwp): Update.
4560         (attach_proc_task_lwp_callback, get_detach_signal)
4561         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4562         (linux_nat_target::resume, wait_lwp, stop_callback)
4563         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4564         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4565         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4566         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4567         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4568         type.
4569         (inf_ptrace_target::attach): Update.
4570         (inf_ptrace_target::files_info): Update.
4571         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4572         type.
4573         (go32_nat_target::pid_to_str): Change return type.
4574         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4575         (gnu_nat_target::wait): Update.
4576         (gnu_nat_target::wait): Update.
4577         (gnu_nat_target::resume): Update.
4578         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4579         (fbsd_nat_target::wait): Update.
4580         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4581         type.
4582         (darwin_nat_target::attach): Update.
4583         * corelow.c (class core_target) <pid_to_str>: Change return type.
4584         (core_target::pid_to_str): Change return type.
4585         * target.c (normal_pid_to_str): Change return type.
4586         (default_pid_to_str): Likewise.
4587         (target_pid_to_str): Change return type.
4588         (target_translate_tls_address): Update.
4589         (target_announce_detach): Update.
4590         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4591         return type.
4592         (bsd_uthread_target::pid_to_str): Change return type.
4593         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4594         type.
4595         (bsd_kvm_target::pid_to_str): Change return type.
4596         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4597         return type.
4598         (aix_thread_target::pid_to_str): Change return type.
4599         * target.h (struct target_ops) <pid_to_str>: Change return type.
4600         (target_pid_to_str, normal_pid_to_str): Likewise.
4601         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4602         type.
4603         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4604         type.
4605         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4606         return type.
4607         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4608         type.
4609         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4610         type.
4611         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4612         return type.
4613
4614 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4615
4616         * NEWS: Mention that the new default MI version is 3.  Mention
4617         changes to the output of commands and events that deal with
4618         multi-location breakpoints.
4619         * breakpoint.c: Include "mi/mi-out.h".
4620         (print_one_breakpoint): Change output syntax if using MI version
4621         >= 3.
4622         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4623         New.
4624         (mi_multi_location_breakpoint_output_fixed): New.
4625         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4626         (mi_cmd_fix_multi_location_breakpoint_output): New.
4627         (mi_multi_location_breakpoint_output_fixed): New.
4628         * mi/mi-cmds.c (mi_cmds): Register command
4629         -fix-multi-location-breakpoint-output.
4630         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4631         interpreter "mi".
4632
4633 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4634
4635         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4636         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4637         instantiate mi_ui_out based on interpreter name.
4638         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4639         * mi/mi-main.c (mi_load_progress): Likewise.
4640
4641 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4642
4643         * NEWS: Combine separate "New targets" sections for 8.3.
4644
4645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4646
4647         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4648         (ppcfbsd_init_abi): Install gdbarch
4649         "fetch_tls_load_module_address" and "get_thread_local_address"
4650         methods.
4651
4652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4653
4654         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4655         (riscv_fbsd_init_abi): Install gdbarch
4656         "fetch_tls_load_module_address" and "get_thread_local_address"
4657         methods.
4658
4659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4660
4661         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4662         (i386fbsd_init_abi): Install gdbarch
4663         "fetch_tls_load_module_address" and "get_thread_local_address"
4664         methods.
4665
4666 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4667
4668         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4669         (amd64fbsd_init_abi): Install gdbarch
4670         "fetch_tls_load_module_address" and "get_thread_local_address"
4671         methods.
4672
4673 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4674
4675         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4676         (struct fbsd_pspace_data): New type.
4677         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4678         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4679         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4680         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4681         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4682
4683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4684
4685         * gdbtypes.c (lookup_struct_elt): New function.
4686         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4687         * gdbtypes.h (struct struct_elt): New type.
4688         (lookup_struct_elt): New prototype.
4689
4690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4691
4692         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4693         remove disabled code block.
4694
4695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4696
4697         * gdbarch.sh (get_thread_local_address): New method.
4698         * gdbarch.h, gdbarch.c: Regenerate.
4699         * target.c (target_translate_tls_address): Use
4700         gdbarch_get_thread_local_address if present instead of
4701         target::get_thread_local_address.
4702
4703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4704
4705         * target.h (target::get_thread_local_address): Update comment.
4706
4707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4708
4709         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4710         objfile->separate_debug_objfile_backlink if not NULL.
4711
4712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4713
4714         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4715         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4716         (amd64bsd_store_inferior_registers): Likewise.
4717         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4718         Enable segment base registers.
4719         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4720         PT_GETFSBASE and PT_GETGSBASE.
4721         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4722         PT_SETGSBASE.
4723         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4724         segment base registers.
4725         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4726
4727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4728
4729         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4730         Update calls to i386_target_description to add 'segments'
4731         parameter.
4732         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4733         add segment base registers.
4734         * arch/i386.c (i386_create_target_description): Add 'segments'
4735         parameter to enable segment base registers.
4736         * arch/i386.h (i386_create_target_description): Likewise.
4737         * features/i386/32bit-segments.xml: New file.
4738         * features/i386/32bit-segments.c: Generate.
4739         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4740         call to i386_target_description to add 'segments' parameter.
4741         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4742         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4743         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4744         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4745         if feature is present.
4746         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4747         Add 'segments' parameter to call to i386_target_description.
4748         (i386_target_description): Add 'segments' parameter to enable
4749         segment base registers.
4750         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4751         to call to i386_target_description.
4752         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4753         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4754         Define I386_NUM_REGS.
4755         (i386_target_description): Add 'segments' parameter to enable
4756         segment base registers.
4757
4758 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4759
4760         PR/24325
4761         * source-cache.c: #undef open and close, to avoid unresolved
4762         externals during linking.
4763
4764 2019-03-12  Tom Tromey  <tromey@adacore.com>
4765
4766         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4767         const.  Add initializers.
4768         (_initialize_remote): Don't initialize ptid globals.
4769
4770 2019-03-12  Pedro Alves  <palves@redhat.com>
4771
4772         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4773
4774 2019-03-12  Pedro Alves  <palves@redhat.com>
4775
4776         * cp-name-parser.y (main): Remove unused 'len' variable.
4777
4778 2019-03-12  Tom Tromey  <tromey@adacore.com>
4779
4780         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4781         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4782
4783 2019-03-12  Tom Tromey  <tromey@adacore.com>
4784
4785         * linux-nat.c (iterate_over_lwps): Update.
4786         (stop_callback): Remove parameter.
4787         (stop_wait_callback, detach_callback, resume_set_callback)
4788         (select_singlestep_lwp_callback, set_ignore_sigint)
4789         (status_callback, resumed_callback, resume_clear_callback)
4790         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4791         data parameter.
4792         (linux_nat_target::detach, linux_nat_target::resume)
4793         (linux_stop_and_wait_all_lwps, select_event_lwp)
4794         (linux_nat_filter_event, linux_nat_wait_1)
4795         (linux_nat_target::kill, linux_nat_target::stop)
4796         (linux_nat_target::stop): Update.
4797         (linux_nat_resume_callback): Change type.
4798         (resume_stopped_resumed_lwps, count_events_callback)
4799         (select_event_lwp_callback): Likewise.
4800         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4801         * arm-linux-nat.c (struct update_registers_data): Remove.
4802         (update_registers_callback): Change type.
4803         (arm_linux_insert_hw_breakpoint1): Update.
4804         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4805         parameter.
4806         (x86_linux_dr_set_addr): Update.
4807         (x86_linux_dr_set_control): Update.
4808         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4809         (iterate_over_lwps): Use gdb::function_view.
4810         * nat/aarch64-linux-hw-point.c (struct
4811         aarch64_dr_update_callback_param): Remove.
4812         (debug_reg_change_callback): Change type.
4813         (aarch64_notify_debug_reg_change): Update.
4814         * s390-linux-nat.c (s390_refresh_per_info): Update.
4815
4816 2019-03-11  Tom Tromey  <tromey@adacore.com>
4817
4818         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4819         redundant assignment to "this_cu".
4820
4821 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4822
4823         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4824
4825 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4826
4827         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4828         from...
4829         (rank_one_type): ... this.
4830
4831 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4832
4833         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4834         from...
4835         (rank_one_type): ... this.
4836
4837 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4838
4839         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4840         from...
4841         (rank_one_type): ... this.
4842
4843 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4844
4845         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4846         from...
4847         (rank_one_type): ... this.
4848
4849 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4850
4851         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4852         from...
4853         (rank_one_type): ... this.
4854
4855 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4856
4857         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4858         from...
4859         (rank_one_type): ... this.
4860
4861 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4862
4863         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4864         from...
4865         (rank_one_type): ... this.
4866
4867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4868
4869         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4870         from...
4871         (rank_one_type): ... this.
4872
4873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4874
4875         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4876         from...
4877         (rank_one_type): ... this.
4878
4879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4880
4881         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4882         from...
4883         (rank_one_type): ... this.
4884
4885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4886
4887         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4888         from...
4889         (rank_one_type): ... this.
4890
4891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4892
4893         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4894         from...
4895         (rank_one_type): ... this.
4896
4897 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4898
4899         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4900         inferior-events' shows the example events.
4901
4902 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4903
4904         Support styling on native MS-Windows console
4905
4906         PR/24315
4907         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4908         on MS-Windows if $TERM is not defined.
4909
4910         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4911
4912         * posix-hdep.c (gdb_console_fputs):
4913         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4914         functions.
4915         * ui-file.h (gdb_console_fputs): Add prototype.
4916
4917         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4918         back to fputs only if the former returns zero.
4919
4920 2019-03-07  Tom Tromey  <tom@tromey.com>
4921
4922         * symmisc.c (print_symbol_bcache_statistics): Update.
4923         (print_objfile_statistics): Update.
4924         * symfile.c (allocate_symtab): Update.
4925         * stabsread.c: Don't include bcache.h.
4926         * psymtab.h (struct psymbol_bcache): Don't declare.
4927         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4928         (psymbol_bcache_init, psymbol_bcache_free)
4929         (psymbol_bcache_get_bcache): Don't declare.
4930         * psymtab.c (struct psymbol_bcache): Remove.
4931         (psymtab_storage::psymtab_storage): Update.
4932         (psymtab_storage::~psymtab_storage): Update.
4933         (psymbol_bcache_init, psymbol_bcache_free)
4934         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4935         (add_psymbol_to_bcache): Update.
4936         (allocate_psymtab): Update.
4937         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4938         macro_cache>: No longer pointers.
4939         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4940         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4941         * macrotab.c (macro_bcache): Update.
4942         * macroexp.c: Don't include bcache.h.
4943         * gdbtypes.c (check_types_worklist): Update.
4944         (types_deeply_equal): Remove TRY/CATCH.  Update.
4945         * elfread.c (elf_symtab_read): Update.
4946         * dwarf2read.c: Don't include bcache.h.
4947         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4948         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4949         (print_bcache_statistics, bcache_memory_used): Don't declare.
4950         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4951         methods.  Rename all data members.
4952         * bcache.c (struct bcache): Move to bcache.h.
4953         (bcache::expand_hash_table): Rename from expand_hash_table.
4954         (bcache): Remove.
4955         (bcache::insert): Rename from bcache_full.
4956         (bcache::compare): Rename from bcache_compare.
4957         (bcache_xmalloc): Remove.
4958         (bcache::~bcache): Rename from bcache_xfree.
4959         (bcache::print_statistics): Rename from print_bcache_statistics.
4960         (bcache::memory_used): Rename from bcache_memory_used.
4961
4962 2019-03-07  Pedro Alves  <palves@redhat.com>
4963
4964         * infrun.c (normal_stop): Also check for
4965         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4966
4967 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4968
4969         * f-lang.c (value_from_host_double): Moved to...
4970         * value.c (value_from_host_double): ...here.
4971         * value.h (value_from_host_double): Declare.
4972         * guile/scm-math.c (vlscm_convert_typed_number): Use
4973         value_from_host_double.
4974         (vlscm_convert_number): Likewise.
4975         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4976         * python/py-value.c (convert_value_from_python): Likewise.
4977
4978 2019-03-06  Tom Tromey  <tom@tromey.com>
4979
4980         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4981
4982 2019-03-06  Tom Tromey  <tom@tromey.com>
4983
4984         * utils.h (free_current_contents): Don't declare.
4985         * utils.c (free_current_contents): Remove.
4986
4987 2019-03-06  Tom Tromey  <tom@tromey.com>
4988
4989         * top.c (quit_force): Update.
4990         * main.c (captured_command_loop): Update.
4991         * common/new-op.c (operator new): Update.
4992         * common/common-exceptions.c (struct catcher)
4993         <save_cleanup_chain>: Remove member.
4994         (exceptions_state_mc_init): Update.
4995         (exception_try_scope_entry): Return nullptr.
4996         (exception_try_scope_exit, exception_rethrow)
4997         (throw_exception_sjlj, throw_exception_cxx): Update.
4998         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4999         (all_cleanups, do_cleanups, discard_cleanups)
5000         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5001         (restore_cleanups, restore_final_cleanups): Don't declare.
5002         (do_final_cleanups): Remove parameter.
5003         * common/cleanups.c (cleanup_chain, make_cleanup)
5004         (make_cleanup_dtor, all_cleanups, do_cleanups)
5005         (discard_my_cleanups, discard_cleanups)
5006         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5007         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5008         (null_cleanup): Remove.
5009         (do_final_cleanups): Remove parameter.
5010
5011 2019-03-06  Tom Tromey  <tom@tromey.com>
5012
5013         * remote.c (remote_target::remote_parse_stop_reply): Use
5014         unique_xmalloc_ptr.
5015
5016 2019-03-06  Tom Tromey  <tom@tromey.com>
5017
5018         * stabsread.c (struct stabs_field_info): Rename from field_info.
5019         <list, fnlist>: Add initializers.
5020         <obstack>: New member.
5021         (read_member_functions, read_struct_fields, read_baseclasses):
5022         Allocate on obstack.  Don't use cleanups.
5023         (read_one_struct_field, read_member_functions, read_struct_fields)
5024         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5025         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5026         (read_struct_type): Update.
5027
5028 2019-03-06  Tom Tromey  <tom@tromey.com>
5029
5030         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5031         * common/filestuff.h (make_cleanup_close): Don't declare.
5032         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5033         Remove.
5034
5035 2019-03-06  Tom Tromey  <tom@tromey.com>
5036
5037         * solib-aix.c: Use make_scope_exit.
5038
5039 2019-03-06  Tom Tromey  <tom@tromey.com>
5040
5041         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5042         Use make_scope_exit.
5043
5044 2019-03-06  Tom Tromey  <tom@tromey.com>
5045
5046         * solib-svr4.c (disable_probes_interface): Remove parameter.
5047         (svr4_handle_solib_event): Use make_scope_exit.
5048
5049 2019-03-06  Tom Tromey  <tom@tromey.com>
5050
5051         * remote.c (struct stop_reply_deleter): Remove.
5052         (stop_reply_up): Update.
5053         (struct stop_reply): Derive from notif_event.  Don't typedef.
5054         <regcache>: Now a std::vector.
5055         (stop_reply_xfree): Remove.
5056         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5057         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5058         (remote_target::discard_pending_stop_replies): Use delete.
5059         (remote_target::remote_parse_stop_reply): Update.
5060         (remote_target::process_stop_reply): Update.
5061         * remote-notif.h (struct notif_event): Add virtual destructor.
5062         Remove "dtr" member.
5063         (struct notif_client) <alloc_event>: Return a unique_ptr.
5064         (notif_event_xfree): Don't declare.
5065         (notif_event_up): New typedef.
5066         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5067         (notif_event_xfree, do_notif_event_xfree): Remove.
5068         (remote_notif_state_xfree): Update.
5069
5070 2019-03-06  Tom Tromey  <tom@tromey.com>
5071
5072         * infrun.c (displaced_step_clear_cleanup): Now a
5073         forward_scope_exit type.
5074         (displaced_step_prepare_throw): Update.
5075         (displaced_step_fixup): Update.
5076
5077 2019-03-06  Tom Tromey  <tom@tromey.com>
5078
5079         * inferior.h (class inferior): Update comment.
5080         * gdbthread.h (class thread_info): Update comment.
5081
5082 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5083             Tom Tromey  <tom@tromey.com>
5084
5085         * stabsread.h (struct stab_section_list): Remove.
5086         (coffstab_build_psymtabs): Update.
5087         * dbxread.c (symbuf_sections): Now a std::vector.
5088         (sect_idx): New global.
5089         (fill_symbuf): Update.
5090         (coffstab_build_psymtabs): Change type of stabsects parameter.
5091         Update.
5092         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5093         std::vector.
5094         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5095         (coff_locate_sections): Update.
5096         (coff_symfile_read): Remove cleanups.  Update.
5097         (init_stringtab): Add storage parameter.
5098         (free_stringtab, free_stringtab_cleanup): Remove.
5099         (init_lineno): Add storage parameter.
5100         (free_linetab, free_linetab_cleanup): Remove.
5101
5102 2019-03-06  Pedro Alves  <palves@redhat.com>
5103
5104         * linux-fork.c (fork_info::clobber_regs): Delete.
5105         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5106         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5107         comment.  Adjust.
5108         (scoped_switch_fork_info::scoped_switch_fork_info)
5109         (checkpoint_command, linux_fork_context): Adjust
5110         fork_save_infrun_state calls.
5111
5112 2019-03-06  Pedro Alves  <palves@redhat.com>
5113
5114         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5115         (inf_has_multiple_threads): Return 'bool' and rewrite using
5116         inferior_info::threads().
5117
5118 2019-03-06  Pedro Alves  <palves@redhat.com>
5119
5120         * linux-fork.c: Include <list>.
5121         (fork_list): Now a std::list instance.
5122         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5123         (forks_exist_p, find_last_fork): Adjust.
5124         (new_fork): Delete.
5125         (one_fork_p): New.
5126         (add_fork): Adjust.
5127         (free_fork): Delete, folded into fork_info::~fork_info().
5128         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5129         Adjust.
5130         (init_fork_list): Delete.
5131         (linux_fork_killall, linux_fork_mourn_inferior)
5132         (linux_fork_detach, info_checkpoints_command): Adjust.
5133         (_initialize_linux_fork): No longer call init_fork_list.
5134
5135 2019-03-06  Pedro Alves  <palves@redhat.com>
5136
5137         * linux-fork.c (new_fork): New, split out of ...
5138         (add_fork): ... this.  Return void.  Move "first fork" special
5139         case from here, to ...
5140         (checkpoint_command): ... here.
5141         * linux-linux.h (add_fork): Return void.
5142
5143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5146
5147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5148             Chris January  <chris.january@arm.com>
5149             David Lecomber  <david.lecomber@arm.com>
5150
5151         * f-exp.y: New token, UNOP_INTRINSIC.
5152         (exp): New pattern using UNOP_INTRINSIC token.
5153         (f77_keywords): Add 'abs' keyword.
5154         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5155         (value_from_host_double): New function.
5156         (evaluate_subexp_f): Support UNOP_ABS.
5157
5158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5159
5160         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5161         types.
5162
5163 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5166         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5167         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5168
5169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5172
5173 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5174             Chris January  <chris.january@arm.com>
5175
5176         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5177         * f-exp.y: Define 'KIND' token.
5178         (exp): New pattern for KIND expressions.
5179         (ptype): Handle types with a kind extension.
5180         (direct_abs_decl): Extend to spot kind extensions.
5181         (f77_keywords): Add 'kind' to the list.
5182         (push_kind_type): New function.
5183         (convert_to_kind_type): New function.
5184         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5185         * parse.c (operator_length_standard): Likewise.
5186         * parser-defs.h (enum type_pieces): Add tp_kind.
5187         * std-operator.def: Add UNOP_KIND.
5188
5189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * f-exp.y (f_parse): Set yydebug.
5192
5193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5194
5195         * f-lang.c (evaluate_subexp_f): New function.
5196         (exp_descriptor_f): New global.
5197         (f_language_defn): Use exp_descriptor_f instead of
5198         exp_descriptor_standard.
5199
5200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5201
5202         * f-exp.y (struct token): Add comments.
5203         (dot_ops): Remove uppercase versions and the end marker.
5204         (f77_keywords): Likewise.
5205         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5206         entries in the dot_ops array are case insensitive, and use
5207         strncasecmp to compare strings.  Also some whitespace cleanup in
5208         this area.  Similar for the f77_keywords array, except entries in
5209         this list might be case sensitive.
5210
5211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * f-exp.y (struct f77_boolean_val): Add comments.
5214         (boolean_values): Remove uppercase versions, and end marker.
5215         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5216         and use strncasecmp to achieve case insensitivity.  Additionally,
5217         perform whitespace cleanup around this code.
5218
5219 2019-03-06  Tom Tromey  <tromey@adacore.com>
5220
5221         * remote-sim.c (gdbsim_target_open): Use result of
5222         gdb_argv::release.
5223
5224 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5225         Dirk Schubert  <dirk.schubert@arm.com>
5226         Chris January  <chris.january@arm.com>
5227
5228         * eval.c (evaluate_subexp_standard): Call Fortran argument
5229         wrapping logic.
5230         * f-lang.c (struct value): A value which can be passed into a
5231         Fortran function call.
5232         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5233         where appropriate.
5234         (struct type): Value ready for a Fortran function call.
5235         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5236         is needed.
5237         * f-lang.h (fortran_argument_convert): Declaration.
5238         (fortran_preserve_arg_pointer): Declaration.
5239         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5240
5241 2019-03-05  Tom Tromey  <tromey@adacore.com>
5242
5243         * python/py-prettyprint.c (print_string_repr): Remove #if.
5244         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5245
5246 2019-03-05  Tom Tromey  <tromey@adacore.com>
5247
5248         * target.c (the_dummy_target): Move later.  Change type to
5249         "dummy_target".
5250         (initialize_targets): Don't initialize the_dummy_target.
5251
5252 2019-03-05  Tom Tromey  <tromey@adacore.com>
5253
5254         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5255         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5256
5257 2019-03-05  Tom Tromey  <tromey@adacore.com>
5258
5259         * windows-nat.c (windows_nat_target::attach)
5260         (windows_nat_target::detach): Don't call gdb_flush.
5261         * valprint.c (generic_val_print, val_print, val_print_string):
5262         Don't call gdb_flush.
5263         * utils.c (defaulted_query): Don't call gdb_flush.
5264         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5265         * target.c (target_announce_detach): Don't call gdb_flush.
5266         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5267         * remote.c (extended_remote_target::attach): Don't call
5268         gdb_flush.
5269         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5270         * printcmd.c (do_examine): Don't call gdb_flush.
5271         (info_display_command): Don't call gdb_flush.
5272         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5273         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5274         * memattr.c (info_mem_command): Don't call gdb_flush.
5275         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5276         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5277         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5278         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5279         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5280         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5281         (gnu_nat_target::detach): Don't call gdb_flush.
5282         * f-valprint.c (f_val_print): Don't call gdb_flush.
5283         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5284         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5285         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5286         gdb_flush.
5287         * c-valprint.c (c_val_print): Don't call gdb_flush.
5288         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5289
5290 2019-03-05  Tom Tromey  <tromey@adacore.com>
5291
5292         * varobj.c (update_dynamic_varobj_children): Update.
5293         (install_default_visualizer): Use reset, not release.
5294         * value.c (set_internalvar): Update.
5295         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5296         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5297         ATTRIBUTE_UNUSED_RESULT.
5298
5299 2019-03-05  Tom Tromey  <tromey@adacore.com>
5300
5301         * remote.c (class scoped_remote_fd) <release>: Add
5302         ATTRIBUTE_UNUSED_RESULT.
5303
5304 2019-03-05  Tom Tromey  <tromey@adacore.com>
5305
5306         * macroexp.c (struct macro_buffer) <release>: Add
5307         ATTRIBUTE_UNUSED_RESULT.
5308
5309 2019-03-05  Tom Tromey  <tromey@adacore.com>
5310
5311         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5312         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5313         ATTRIBUTE_UNUSED_RESULT.
5314
5315 2019-03-05  Tom Tromey  <tromey@adacore.com>
5316
5317         * common/scoped_fd.h (class scoped_fd) <release>: Add
5318         ATTRIBUTE_UNUSED_RESULT.
5319
5320 2019-03-05  Tom Tromey  <tromey@adacore.com>
5321
5322         * parser-defs.h (struct parser_state) <release>: Add
5323         ATTRIBUTE_UNUSED_RESULT.
5324
5325 2019-03-05  Tom Tromey  <tromey@adacore.com>
5326
5327         * utils.h (class gdb_argv) <release>: Add
5328         ATTRIBUTE_UNUSED_RESULT.
5329         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5330
5331 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5332
5333         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5334         for-loop range, to avoid compiler warnings.
5335
5336         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5337         avoid compiler warnings about unused variables.
5338
5339         * NEWS: Mention end of support for native debugging on MS-Windows
5340         before XP.
5341
5342         PR gdb/24292
5343         * common/netstuff.c:
5344         * gdbserver/gdbreplay.c
5345         * gdbserver/remote-utils.c:
5346         * ser-tcp.c:
5347         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5348         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5349         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5350         'getaddrinfo' and 'freeaddrinfo' were not available before
5351         Windows XP, and mingw.org's MinGW headers by default define
5352         _WIN32_WINNT to 0x500.
5353
5354 2019-03-01  Gary Benson <gbenson@redhat.com>
5355
5356         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5357
5358 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5359             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5360
5361         PR gdb/8527
5362         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5363         set_sigint_trap, clear_sigint_trap.
5364
5365 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5366
5367         * target.c (target_detach): Clear the regcache and the
5368         frame cache.
5369
5370 2019-02-27  Pedro Alves  <palves@redhat.com>
5371
5372         * utils.c (set_screen_size): When we cap the height/width sizes,
5373         tweak the corresponding command variable to show "unlimited":
5374
5375 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5376             Pedro Alves  <palves@redhat.com>
5377
5378         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5379         before calling rl_set_screen_size.
5380
5381 2019-02-27  Tom Tromey  <tromey@adacore.com>
5382
5383         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5384         define.
5385         * python/py-value.c: Remove Python 2.4 workaround.
5386         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5387         workaround.
5388         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5389         Python 2.4 workaround.
5390         * python/python-internal.h: Remove Python 2.4 comment.
5391         (Py_ssize_t): Don't define.
5392         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5393         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5394         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5395         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5396         * python/python.c (do_start_initialization): Remove Python 2.4
5397         workaround.
5398         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5399         (print_children): Remove Python 2.4 workaround.
5400         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5401         workaround.
5402         (CHARBUFFERPROC_NAME): Remove.
5403         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5404         Python 2.4 workaround.
5405
5406 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5407
5408         * NEWS: Note minimum Python version.
5409
5410 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5411
5412         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5413         code from these functions.  Remove corresponding ifdefs.  Use
5414         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5415         Remove gotos and target of gotos.
5416         (infpy_search_memory): Likewise.
5417
5418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5421         (hppa_gdbarch_init): Don't register deleted functions with
5422         gdbarch.
5423
5424 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5425
5426         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5427         (h8300_unwind_sp): Delete.
5428         (h8300_dummy_id): Delete.
5429         (h8300_gdbarch_init): Don't register deleted functions with
5430         gdbarch.
5431
5432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5435         (ft32_unwind_pc): Delete.
5436         (ft32_unwind_sp): Delete.
5437         (ft32_gdbarch_init): Don't register deleted functions with
5438         gdbarch.
5439
5440 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5443         (frv_unwind_pc): Delete.
5444         (frv_unwind_sp): Delete.
5445         (frv_gdbarch_init): Don't register deleted functions with
5446         gdbarch.
5447
5448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5451         (riscv_unwind_pc): Delete.
5452         (riscv_unwind_sp): Delete.
5453         (riscv_gdbarch_init): Don't register deleted functions with
5454         gdbarch.
5455
5456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5459         (csky_unwind_pc): Delete.
5460         (csky_unwind_sp): Delete.
5461         (csky_gdbarch_init): Don't register deleted functions with
5462         gdbarch.
5463
5464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5467         (cris_unwind_pc): Delete.
5468         (cris_unwind_sp): Delete.
5469         (cris_gdbarch_init): Don't register deleted functions with
5470         gdbarch.
5471
5472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5475         (bfin_unwind_pc): Delete.
5476         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5477
5478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5481         (arm_unwind_pc): Delete.
5482         (arm_unwind_sp): Delete.
5483         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5484
5485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5488         (arc_unwind_pc): Delete.
5489         (arc_unwind_sp): Delete.
5490         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5491
5492 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5493
5494         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5495         (alpha_unwind_pc): Delete.
5496         (alpha_gdbarch_init): Don't register deleted functions with
5497         gdbarch.
5498
5499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5500
5501         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5502         (aarch64_unwind_pc): Delete.
5503         (aarch64_unwind_sp): Delete.
5504         (aarch64_gdbarch_init): Don't register deleted functions with
5505         gdbarch.
5506
5507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5508
5509         * gdbtypes.c (type_align): Don't consider static members when
5510         computing structure alignment.
5511
5512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5513
5514         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5515         return 0 for other types.
5516         * arch-utils.c (default_type_align): Always return 0.
5517         * gdbarch.h: Regenerate.
5518         * gdbarch.sh (type_align): Extend comment.
5519         * gdbtypes.c (type_align): Add additional comments, always call
5520         gdbarch_type_align before applying the default rules.
5521         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5522         generic code will then apply a suitable default.
5523         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5524         types, return 0 for other types.
5525
5526 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5527
5528         * NEWS: Create a new section for the next release branch.
5529         Rename the section of the current branch, now that it has
5530         been cut.
5531
5532 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5533
5534         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5535         * version.in: Bump version to 8.3.50.DATE-git.
5536
5537 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5538
5539         * aix-thread.c (ptid_cmp): Remove unused variable.
5540         (get_signaled_thread): Likewise.
5541         (store_regs_user_thread): Likewise.
5542         (store_regs_kernel_thread): Likewise.
5543         (fetch_regs_kernel_thread): Remove shadowed variable.
5544
5545 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5546
5547         * features/riscv/32bit-cpu.xml: Add register numbers.
5548         * features/riscv/32bit-fpu.c: Regenerate.
5549         * features/riscv/32bit-fpu.xml: Add register numbers.
5550         * features/riscv/64bit-cpu.xml: Add register numbers.
5551         * features/riscv/64bit-fpu.c: Regenerate.
5552         * features/riscv/64bit-fpu.xml: Add register numbers.
5553
5554 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5555
5556         * NEWS: Mention two argument form of gdb.Value constructor.
5557         * python/py-value.c (convert_buffer_and_type_to_value): New
5558         function.
5559         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5560         Add support for handling an optional second argument.  Call
5561         convert_buffer_and_type_to_value as appropriate.
5562         * python/python-internal.h (Py_buffer_deleter): New struct.
5563         (Py_buffer_up): New typedef.
5564
5565 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5566
5567         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5568         instead of releasing ownership.
5569
5570 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5571
5572         * dwarf2read.c (open_and_init_dwp_file): Call
5573         elf_numsections instead of bfd_count_sections to initialize
5574         dwp_file->num_sections.
5575
5576 2019-02-25  Tom Tromey  <tromey@adacore.com>
5577
5578         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5579
5580 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5581
5582         * gcore.in: Add '--readnever' option when invoking GDB.
5583
5584 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5585
5586         * MAINTAINERS: Update my email address.
5587
5588 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5589
5590         * build-id.c (build_id_to_debug_bfd_1): New function.
5591         (build_id_to_debug_bfd): Look for separate debug file in
5592         sysroot.
5593
5594 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * gdbarch.sh: Update the copyright year range that is placed into
5597         generated files.
5598
5599 2019-02-22  Keith Seitz  <keiths@redhat.com>
5600
5601         PR symtab/23853
5602         * linespec.c (create_sals_line_offset): Search for the default
5603         symtab's filename instead of its fullname.
5604
5605 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5606
5607         * NEWS: Update style defaults.
5608
5609 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5610
5611         * main.c (captured_main_1): Disable styling in batch mode.
5612
5613 2019-02-20  Tom Tromey  <tom@tromey.com>
5614
5615         * symtab.c (symtab_symbol_info): Fix typos.
5616
5617 2019-02-20  Tom Tromey  <tromey@adacore.com>
5618
5619         * findcmd.c (_initialize_mem_search): Use upper case for
5620         metasyntactic variables.
5621
5622 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5623
5624         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5625         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5626
5627 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5628
5629         * top.h (source_file_name): Change to std::string.
5630         * top.c (source_file_name): Likewise.
5631         (command_line_input): Adjust.
5632         * cli/cli-script.c (script_from_file): Adjust.
5633
5634 2019-02-19  Tom Tromey  <tromey@adacore.com>
5635
5636         * ravenscar-thread.c
5637         (ravenscar_thread_target::update_thread_list): Don't call
5638         ada_build_task_list.
5639         * ada-lang.h (ada_build_task_list): Don't declare.
5640         * ada-tasks.c (struct ada_tasks_inferior_data)
5641         <task_list_valid_p>: Now bool.
5642         (read_known_tasks, ada_task_list_changed)
5643         (ada_tasks_invalidate_inferior_data): Update.
5644         (read_known_tasks_array): Return bool.
5645         (read_known_tasks_list): Likewise.
5646         (read_known_tasks): Return void.
5647         (ada_build_task_list): Now static.
5648
5649 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5650
5651         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5652         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5653
5654 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5655
5656         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5657         variant for ada_tasks_pspace_data_handle and
5658         ada_tasks_inferior_data_handle.
5659         (ada_tasks_pspace_data_cleanup): New function.
5660         (ada_tasks_inferior_data_cleanup): New function.
5661
5662 2019-02-17  Tom Tromey  <tom@tromey.com>
5663
5664         * macrotab.h (macro_source_fullname): Return a std::string.
5665         * macrotab.c (macro_include, check_for_redefinition)
5666         (macro_undef, macro_lookup_definition, foreach_macro)
5667         (foreach_macro_in_scope): Update.
5668         (macro_source_fullname): Return a std::string.
5669         * macrocmd.c (show_pp_source_pos): Update.
5670
5671 2019-02-17  Tom Tromey  <tom@tromey.com>
5672
5673         * macrocmd.c (show_pp_source_pos): Style the file names.
5674
5675 2019-02-17  Tom Tromey  <tom@tromey.com>
5676
5677         PR tui/24197:
5678         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5679
5680 2019-02-17  Tom Tromey  <tom@tromey.com>
5681
5682         * ada-lang.c (user_select_syms): Use filtered printing.
5683         * utils.c (wrap_style): New global.
5684         (desired_style): Remove.
5685         (emit_style_escape): Add stream parameter.
5686         (set_output_style, reset_terminal_style, prompt_for_continue):
5687         Update.
5688         (flush_wrap_buffer): Only flush gdb_stdout.
5689         (wrap_here): Set wrap_style.
5690         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5691         treat escape sequences as a character.  Change when wrap buffer is
5692         flushed.
5693         (fputs_styled): Do not set the output style when the default is
5694         requested.
5695         * ui-style.h (struct ui_file_style) <is_default>: New method.
5696         * source.c (print_source_lines_base): Emit escape sequences in one
5697         piece.
5698
5699 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5700
5701         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5702         integers and enumeration types.
5703
5704 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5705
5706         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5707         instead of lookup_symbol_in_language
5708         (do_exact_match): New function.
5709         (ada_get_symbol_name_matcher): Return do_exact_match when
5710         doing a verbatim match.
5711
5712 2019-02-15  Tom Tromey  <tromey@adacore.com>
5713
5714         * ravenscar-thread.c (ravenscar_thread_target::resume)
5715         (ravenscar_thread_target::wait): Special case wildcard requests.
5716
5717 2019-02-15  Tom Tromey  <tromey@adacore.com>
5718
5719         * ravenscar-thread.c (base_ptid): Remove.
5720         (struct ravenscar_thread_target) <close>: New method.
5721         <m_base_ptid>: New member.
5722         <update_inferior_ptid, active_task, task_is_currently_active,
5723         runtime_initialized>: Declare methods.
5724         <ravenscar_thread_target>: Add constructor.
5725         (ravenscar_thread_target::task_is_currently_active)
5726         (ravenscar_thread_target::update_inferior_ptid)
5727         (ravenscar_runtime_initialized): Rename.  Now methods.
5728         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5729         (ravenscar_thread_target::update_thread_list): Update.
5730         (ravenscar_thread_target::active_task): Now method.
5731         (ravenscar_thread_target::store_registers)
5732         (ravenscar_thread_target::prepare_to_store)
5733         (ravenscar_thread_target::prepare_to_store)
5734         (ravenscar_thread_target::mourn_inferior): Update.
5735         (ravenscar_inferior_created): Use "new" to create target.
5736         (ravenscar_thread_target::get_ada_task_ptid): Update.
5737         (_initialize_ravenscar): Don't initialize base_ptid.
5738         (ravenscar_ops): Remove global.
5739
5740 2019-02-15  Tom Tromey  <tromey@adacore.com>
5741
5742         * target.h (push_target): Declare new overload.
5743         * target.c (push_target): New overload, taking an rvalue reference.
5744         * remote.c (remote_target::open_1): Use push_target overload.
5745         * corelow.c (core_target_open): Use push_target overload.
5746
5747 2019-02-15  Tom Tromey  <tromey@adacore.com>
5748
5749         * ravenscar-thread.c (is_ravenscar_task)
5750         (ravenscar_task_is_currently_active): Return bool.
5751         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5752         (_initialize_ravenscar): Remove "(void)".
5753         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5754         Return bool.
5755
5756 2019-02-15  Tom Tromey  <tromey@adacore.com>
5757
5758         * ravenscar-thread.c (ravenscar_runtime_initializer)
5759         (has_ravenscar_runtime, get_running_thread_id)
5760         (ravenscar_thread_target::resume): Fix indentation.
5761
5762 2019-02-15  Tom Tromey  <tromey@adacore.com>
5763
5764         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5765         from ravenscar_arch_ops.
5766         (sparc_ravenscar_ops::fetch_registers)
5767         (sparc_ravenscar_ops::store_registers): Now methods.
5768         (sparc_ravenscar_prepare_to_store): Remove.
5769         (sparc_ravenscar_ops): Redefine.
5770         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5771         methods and destructor.  Remove members.
5772         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5773         (ravenscar_thread_target::store_registers)
5774         (ravenscar_thread_target::prepare_to_store): Update.
5775         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5776         Remove.
5777         (struct ppc_ravenscar_powerpc_ops): Derive from
5778         ravenscar_arch_ops.
5779         (ppc_ravenscar_powerpc_ops::fetch_registers)
5780         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5781         (ppc_ravenscar_powerpc_ops): Redefine.
5782         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5783         (ppc_ravenscar_e500_ops::fetch_registers)
5784         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5785         (ppc_ravenscar_e500_ops): Redefine.
5786         * aarch64-ravenscar-thread.c
5787         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5788         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5789         (aarch64_ravenscar_fetch_registers)
5790         (aarch64_ravenscar_store_registers): Now methods.
5791         (aarch64_ravenscar_ops): Redefine.
5792
5793 2019-02-15  Tom Tromey  <tromey@adacore.com>
5794
5795         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5796         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5797         (ravenscar_thread_target::stopped_by_watchpoint)
5798         (ravenscar_thread_target::stopped_data_address)
5799         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5800
5801 2019-02-15  Tom Tromey  <tromey@adacore.com>
5802
5803         * ravenscar-thread.c: Fix some typos.
5804
5805 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5806             Tom Tromey  <tromey@adacore.com>
5807
5808         * ada-lang.c (ada_exception_sal): Change addr_string to a
5809         std::string.
5810         (create_ada_exception_catchpoint): Update.
5811
5812 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5813             Tom Tromey  <tromey@adacore.com>
5814
5815         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5816         (bp_location_ops): Remove.
5817         (base_breakpoint_allocate_location): Update.
5818         (free_bp_location): Update.
5819         * ada-lang.c (class ada_catchpoint_location)
5820         <ada_catchpoint_location>: Remove ops parameter.
5821         (ada_catchpoint_location_dtor): Remove.
5822         (ada_catchpoint_location_ops): Remove.
5823         (allocate_location_exception): Update.
5824         * breakpoint.h (struct bp_location_ops): Remove.
5825         (class bp_location) <bp_location>: Remove bp_location_ops
5826         parameter.
5827         <~bp_location>: Add destructor.
5828         <ops>: Remove.
5829
5830 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5831             Pedro Alves  <palves@redhat.com>
5832
5833         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5834         'PATH_MAX'.
5835
5836 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5837             Samuel Thibault  <samuel.thibault@gnu.org>
5838             Thomas Schwinge  <thomas@codesourcery.com>
5839
5840         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5841         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5842
5843 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5844
5845         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5846         (check_empty): Use "const char *".
5847
5848         * gnu-nat.c (gnu_nat_target::detach): Instead of
5849         'detach_inferior (pid)' call
5850         'detach_inferior (find_inferior_pid (pid))'.
5851
5852         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5853         'nat/fork-inferior.o'.
5854         * gnu-nat.c: #include "nat/fork-inferior.h".
5855
5856         * gnu-nat.c (gnu_nat_target::detach): Instead of
5857         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5858         * gnu-nat.h: #include "inf-child.h".
5859         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5860         'i386_gnu_nat_target::fetch_registers'.
5861         (gnu_store_registers): Rename/move to
5862         'i386_gnu_nat_target::store_registers'.
5863
5864         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5865         * gnu-nat.h (mach_thread_info): New function.
5866         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5867
5868         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5869
5870 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5871
5872         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5873
5874 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5875
5876         * windows-nat.c (windows_add_thread): Add new parameter
5877         "main_thread_p" with default value set to false.  Update
5878         function documentation as well as all callers.
5879         (windows_delete_thread): Likewise.
5880         (fake_create_process): Update call to windows_add_thread.
5881         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5882         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5883         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5884         call to windows_delete_thread.
5885
5886 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5887
5888         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5889
5890 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5891
5892         * symfile.c (find_separate_debug_file): Use canonical path of
5893         sysroot with child_path instead of gdb_sysroot if it is valid.
5894
5895 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5896
5897         * symfile.c (find_separate_debug_file): Use child_path to
5898         determine if an object file is under a sysroot.
5899
5900 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5901
5902         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5903         unittests/child-path-selftests.c.
5904         * common/pathstuff.c (child_path): New function.
5905         * common/pathstuff.h (child_path): New prototype.
5906         * unittests/child-path-selftests.c: New file.
5907
5908 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5909
5910         * symfile.c (find_separate_debug_file): Look for separate debug
5911         files in debug directories under the sysroot.
5912
5913 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5914
5915         * symtab.h (struct minimal_symbol data_p): New const method.
5916         (struct minimal_symbol text_p): Likewise.
5917         * symtab.c (output_source_filename): Use file name style
5918         to print file name.
5919         (print_symbol_info): Likewise.
5920         (print_msymbol_info): Use address style to print addresses.
5921         Use function name style to print executable text symbols.
5922         (expand_symtab_containing_pc): Use data_p.
5923         (find_pc_sect_compunit_symtab): Likewise.
5924
5925 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5926
5927         * breakpoint.c (describe_other_breakpoints): Use address style
5928         to print addresses.
5929         (say_where): Likewise.
5930
5931 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5932
5933         * ada-typeprint.c (print_func_type): Print function name
5934         style to print function name.
5935         * c-typeprint.c (c_print_type_1): Likewise.
5936
5937 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5938
5939         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5940         for execve.
5941
5942 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5943
5944         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5945         type_stack.
5946
5947 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5948
5949         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5950         TYPE_CODE_REF types.
5951
5952 2019-02-08  Jim Wilson  <jimw@sifive.com>
5953
5954         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5955         (riscv_linux_fregset): New.
5956         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5957
5958 2019-02-07  Tom Tromey  <tom@tromey.com>
5959
5960         * thread.c (thread_cancel_execution_command): Update.
5961         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5962         methods.
5963         (struct thread_fsm_ops): Remove.
5964         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5965         (thread_fsm_should_stop, thread_fsm_return_value)
5966         (thread_fsm_set_finished, thread_fsm_finished_p)
5967         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5968         Don't declare.
5969         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5970         * infrun.c (clear_proceed_status_thread)
5971         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5972         (print_stop_event): Update.
5973         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5974         Add constructor.
5975         (step_command_fsm_ops): Remove.
5976         (new_step_command_fsm): Remove.
5977         (step_1): Update.
5978         (step_command_fsm::should_stop): Rename from
5979         step_command_fsm_should_stop.
5980         (step_command_fsm::clean_up): Rename from
5981         step_command_fsm_clean_up.
5982         (step_command_fsm::do_async_reply_reason): Rename from
5983         step_command_fsm_async_reply_reason.
5984         (struct until_next_fsm): Inherit from thread_fsm.  Add
5985         constructor.
5986         (until_next_fsm_ops): Remove.
5987         (new_until_next_fsm): Remove.
5988         (until_next_fsm::should_stop): Rename from
5989         until_next_fsm_should_stop.
5990         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5991         (until_next_fsm::do_async_reply_reason): Rename from
5992         until_next_fsm_async_reply_reason.
5993         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5994         constructor.  Change type of breakpoint.
5995         (finish_command_fsm_ops): Remove.
5996         (new_finish_command_fsm): Remove.
5997         (finish_command_fsm::should_stop): Rename from
5998         finish_command_fsm_should_stop.
5999         (finish_command_fsm::clean_up): Rename from
6000         finish_command_fsm_clean_up.
6001         (finish_command_fsm::return_value): Rename from
6002         finish_command_fsm_return_value.
6003         (finish_command_fsm::do_async_reply_reason): Rename from
6004         finish_command_fsm_async_reply_reason.
6005         (finish_command): Update.
6006         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6007         Add constructor.
6008         (call_thread_fsm_ops): Remove.
6009         (call_thread_fsm::call_thread_fsm): Rename from
6010         new_call_thread_fsm.
6011         (call_thread_fsm::should_stop): Rename from
6012         call_thread_fsm_should_stop.
6013         (call_thread_fsm::should_notify_stop): Rename from
6014         call_thread_fsm_should_notify_stop.
6015         (run_inferior_call, call_function_by_hand_dummy): Update.
6016         * cli/cli-interp.c (should_print_stop_to_console): Update.
6017         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6018         Add constructor.  Change type of location_breakpoint,
6019         caller_breakpoint.
6020         (until_break_fsm_ops): Remove.
6021         (new_until_break_fsm): Remove.
6022         (until_break_fsm::should_stop): Rename from
6023         until_break_fsm_should_stop.
6024         (until_break_fsm::clean_up): Rename from
6025         until_break_fsm_clean_up.
6026         (until_break_fsm::do_async_reply_reason): Rename from
6027         until_break_fsm_async_reply_reason.
6028         (until_break_command): Update.
6029         * thread-fsm.c: Remove.
6030         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6031
6032 2019-02-07  Tom Tromey  <tom@tromey.com>
6033
6034         * yy-remap.h: Add include guard.
6035         * xtensa-tdep.h: Add include guard.
6036         * xcoffread.h: Rename include guard.
6037         * varobj-iter.h: Add include guard.
6038         * tui/tui.h: Rename include guard.
6039         * tui/tui-winsource.h: Rename include guard.
6040         * tui/tui-wingeneral.h: Rename include guard.
6041         * tui/tui-windata.h: Rename include guard.
6042         * tui/tui-win.h: Rename include guard.
6043         * tui/tui-stack.h: Rename include guard.
6044         * tui/tui-source.h: Rename include guard.
6045         * tui/tui-regs.h: Rename include guard.
6046         * tui/tui-out.h: Rename include guard.
6047         * tui/tui-layout.h: Rename include guard.
6048         * tui/tui-io.h: Rename include guard.
6049         * tui/tui-hooks.h: Rename include guard.
6050         * tui/tui-file.h: Rename include guard.
6051         * tui/tui-disasm.h: Rename include guard.
6052         * tui/tui-data.h: Rename include guard.
6053         * tui/tui-command.h: Rename include guard.
6054         * tic6x-tdep.h: Add include guard.
6055         * target/waitstatus.h: Rename include guard.
6056         * target/wait.h: Rename include guard.
6057         * target/target.h: Rename include guard.
6058         * target/resume.h: Rename include guard.
6059         * target-float.h: Rename include guard.
6060         * stabsread.h: Add include guard.
6061         * rs6000-tdep.h: Add include guard.
6062         * riscv-fbsd-tdep.h: Add include guard.
6063         * regformats/regdef.h: Rename include guard.
6064         * record.h: Rename include guard.
6065         * python/python.h: Rename include guard.
6066         * python/python-internal.h: Rename include guard.
6067         * python/py-stopevent.h: Rename include guard.
6068         * python/py-ref.h: Rename include guard.
6069         * python/py-record.h: Rename include guard.
6070         * python/py-record-full.h: Rename include guard.
6071         * python/py-record-btrace.h: Rename include guard.
6072         * python/py-instruction.h: Rename include guard.
6073         * python/py-events.h: Rename include guard.
6074         * python/py-event.h: Rename include guard.
6075         * procfs.h: Add include guard.
6076         * proc-utils.h: Add include guard.
6077         * p-lang.h: Add include guard.
6078         * or1k-tdep.h: Rename include guard.
6079         * observable.h: Rename include guard.
6080         * nto-tdep.h: Rename include guard.
6081         * nat/x86-linux.h: Rename include guard.
6082         * nat/x86-linux-dregs.h: Rename include guard.
6083         * nat/x86-gcc-cpuid.h: Add include guard.
6084         * nat/x86-dregs.h: Rename include guard.
6085         * nat/x86-cpuid.h: Rename include guard.
6086         * nat/ppc-linux.h: Rename include guard.
6087         * nat/mips-linux-watch.h: Rename include guard.
6088         * nat/linux-waitpid.h: Rename include guard.
6089         * nat/linux-ptrace.h: Rename include guard.
6090         * nat/linux-procfs.h: Rename include guard.
6091         * nat/linux-osdata.h: Rename include guard.
6092         * nat/linux-nat.h: Rename include guard.
6093         * nat/linux-namespaces.h: Rename include guard.
6094         * nat/linux-btrace.h: Rename include guard.
6095         * nat/glibc_thread_db.h: Rename include guard.
6096         * nat/gdb_thread_db.h: Rename include guard.
6097         * nat/gdb_ptrace.h: Rename include guard.
6098         * nat/fork-inferior.h: Rename include guard.
6099         * nat/amd64-linux-siginfo.h: Rename include guard.
6100         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6101         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6102         * nat/aarch64-linux.h: Rename include guard.
6103         * nat/aarch64-linux-hw-point.h: Rename include guard.
6104         * mn10300-tdep.h: Add include guard.
6105         * mips-linux-tdep.h: Add include guard.
6106         * mi/mi-parse.h: Rename include guard.
6107         * mi/mi-out.h: Rename include guard.
6108         * mi/mi-main.h: Rename include guard.
6109         * mi/mi-interp.h: Rename include guard.
6110         * mi/mi-getopt.h: Rename include guard.
6111         * mi/mi-console.h: Rename include guard.
6112         * mi/mi-common.h: Rename include guard.
6113         * mi/mi-cmds.h: Rename include guard.
6114         * mi/mi-cmd-break.h: Rename include guard.
6115         * m2-lang.h: Add include guard.
6116         * location.h: Rename include guard.
6117         * linux-record.h: Rename include guard.
6118         * linux-nat.h: Add include guard.
6119         * linux-fork.h: Add include guard.
6120         * i386-darwin-tdep.h: Rename include guard.
6121         * hppa-linux-offsets.h: Add include guard.
6122         * guile/guile.h: Rename include guard.
6123         * guile/guile-internal.h: Rename include guard.
6124         * gnu-nat.h: Rename include guard.
6125         * gdb-stabs.h: Rename include guard.
6126         * frv-tdep.h: Add include guard.
6127         * f-lang.h: Add include guard.
6128         * event-loop.h: Add include guard.
6129         * darwin-nat.h: Rename include guard.
6130         * cp-abi.h: Rename include guard.
6131         * config/sparc/nm-sol2.h: Rename include guard.
6132         * config/nm-nto.h: Rename include guard.
6133         * config/nm-linux.h: Add include guard.
6134         * config/i386/nm-i386gnu.h: Rename include guard.
6135         * config/djgpp/nl_types.h: Rename include guard.
6136         * config/djgpp/langinfo.h: Rename include guard.
6137         * compile/gcc-cp-plugin.h: Add include guard.
6138         * compile/gcc-c-plugin.h: Add include guard.
6139         * compile/compile.h: Rename include guard.
6140         * compile/compile-object-run.h: Rename include guard.
6141         * compile/compile-object-load.h: Rename include guard.
6142         * compile/compile-internal.h: Rename include guard.
6143         * compile/compile-cplus.h: Rename include guard.
6144         * compile/compile-c.h: Rename include guard.
6145         * common/xml-utils.h: Rename include guard.
6146         * common/x86-xstate.h: Rename include guard.
6147         * common/version.h: Rename include guard.
6148         * common/vec.h: Rename include guard.
6149         * common/tdesc.h: Rename include guard.
6150         * common/selftest.h: Rename include guard.
6151         * common/scoped_restore.h: Rename include guard.
6152         * common/scoped_mmap.h: Rename include guard.
6153         * common/scoped_fd.h: Rename include guard.
6154         * common/safe-iterator.h: Rename include guard.
6155         * common/run-time-clock.h: Rename include guard.
6156         * common/refcounted-object.h: Rename include guard.
6157         * common/queue.h: Rename include guard.
6158         * common/ptid.h: Rename include guard.
6159         * common/print-utils.h: Rename include guard.
6160         * common/preprocessor.h: Rename include guard.
6161         * common/pathstuff.h: Rename include guard.
6162         * common/observable.h: Rename include guard.
6163         * common/netstuff.h: Rename include guard.
6164         * common/job-control.h: Rename include guard.
6165         * common/host-defs.h: Rename include guard.
6166         * common/gdb_wait.h: Rename include guard.
6167         * common/gdb_vecs.h: Rename include guard.
6168         * common/gdb_unlinker.h: Rename include guard.
6169         * common/gdb_unique_ptr.h: Rename include guard.
6170         * common/gdb_tilde_expand.h: Rename include guard.
6171         * common/gdb_sys_time.h: Rename include guard.
6172         * common/gdb_string_view.h: Rename include guard.
6173         * common/gdb_splay_tree.h: Rename include guard.
6174         * common/gdb_setjmp.h: Rename include guard.
6175         * common/gdb_ref_ptr.h: Rename include guard.
6176         * common/gdb_optional.h: Rename include guard.
6177         * common/gdb_locale.h: Rename include guard.
6178         * common/gdb_assert.h: Rename include guard.
6179         * common/filtered-iterator.h: Rename include guard.
6180         * common/filestuff.h: Rename include guard.
6181         * common/fileio.h: Rename include guard.
6182         * common/environ.h: Rename include guard.
6183         * common/common-utils.h: Rename include guard.
6184         * common/common-types.h: Rename include guard.
6185         * common/common-regcache.h: Rename include guard.
6186         * common/common-inferior.h: Rename include guard.
6187         * common/common-gdbthread.h: Rename include guard.
6188         * common/common-exceptions.h: Rename include guard.
6189         * common/common-defs.h: Rename include guard.
6190         * common/common-debug.h: Rename include guard.
6191         * common/cleanups.h: Rename include guard.
6192         * common/buffer.h: Rename include guard.
6193         * common/btrace-common.h: Rename include guard.
6194         * common/break-common.h: Rename include guard.
6195         * cli/cli-utils.h: Rename include guard.
6196         * cli/cli-style.h: Rename include guard.
6197         * cli/cli-setshow.h: Rename include guard.
6198         * cli/cli-script.h: Rename include guard.
6199         * cli/cli-interp.h: Rename include guard.
6200         * cli/cli-decode.h: Rename include guard.
6201         * cli/cli-cmds.h: Rename include guard.
6202         * charset-list.h: Add include guard.
6203         * buildsym-legacy.h: Rename include guard.
6204         * bfin-tdep.h: Add include guard.
6205         * ax.h: Rename include guard.
6206         * arm-linux-tdep.h: Add include guard.
6207         * arm-fbsd-tdep.h: Add include guard.
6208         * arch/xtensa.h: Rename include guard.
6209         * arch/tic6x.h: Add include guard.
6210         * arch/i386.h: Add include guard.
6211         * arch/arm.h: Rename include guard.
6212         * arch/arm-linux.h: Rename include guard.
6213         * arch/arm-get-next-pcs.h: Rename include guard.
6214         * arch/amd64.h: Add include guard.
6215         * arch/aarch64-insn.h: Rename include guard.
6216         * arch-utils.h: Rename include guard.
6217         * annotate.h: Add include guard.
6218         * amd64-darwin-tdep.h: Rename include guard.
6219         * aarch64-linux-tdep.h: Add include guard.
6220         * aarch64-fbsd-tdep.h: Add include guard.
6221         * aarch32-linux-nat.h: Add include guard.
6222
6223 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6224
6225         * macrotab.c (macro_define_internal): New function that
6226         factorizes macro_define_object_internal and macro_define_function
6227         code.
6228         (macro_define_object_internal): Use macro_define_internal.
6229         (macro_define_function): Likewise.
6230
6231 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * macrocmd.c (extract_identifier): Return
6234         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6235         callers.
6236
6237 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6238
6239         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6240
6241 2019-02-05  Tom Tromey  <tom@tromey.com>
6242
6243         * target.c (target_stack::unpush): Move assertion earlier.
6244
6245 2019-01-30  Tom Tromey  <tom@tromey.com>
6246
6247         PR python/23615:
6248         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6249         (gdbpy_parse_and_eval): Likewise.
6250         * python/python-internal.h (gdbpy_allow_threads): New class.
6251
6252 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6253
6254         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6255         (aarch64_fbsd_fpregmap): Move earlier.
6256         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6257         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6258         instead of individual calls to trad_frame_set_reg_addr.
6259         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6260         earlier.
6261         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6262         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6263         instead of individual calls to trad_frame_set_reg_addr.
6264
6265 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6266
6267         * CONTRIBUTE: Replace contribution list with wiki link.
6268
6269 2019-01-25  Tom Tromey  <tom@tromey.com>
6270
6271         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6272
6273 2019-01-25  Tom Tromey  <tom@tromey.com>
6274
6275         * xtensa-linux-nat.c: Fix common/ includes.
6276         * xml-support.h: Fix common/ includes.
6277         * xml-support.c: Fix common/ includes.
6278         * x86-linux-nat.c: Fix common/ includes.
6279         * windows-nat.c: Fix common/ includes.
6280         * varobj.h: Fix common/ includes.
6281         * varobj.c: Fix common/ includes.
6282         * value.c: Fix common/ includes.
6283         * valops.c: Fix common/ includes.
6284         * utils.c: Fix common/ includes.
6285         * unittests/xml-utils-selftests.c: Fix common/ includes.
6286         * unittests/utils-selftests.c: Fix common/ includes.
6287         * unittests/unpack-selftests.c: Fix common/ includes.
6288         * unittests/tracepoint-selftests.c: Fix common/ includes.
6289         * unittests/style-selftests.c: Fix common/ includes.
6290         * unittests/string_view-selftests.c: Fix common/ includes.
6291         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6292         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6293         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6294         * unittests/rsp-low-selftests.c: Fix common/ includes.
6295         * unittests/parse-connection-spec-selftests.c: Fix common/
6296         includes.
6297         * unittests/optional-selftests.c: Fix common/ includes.
6298         * unittests/offset-type-selftests.c: Fix common/ includes.
6299         * unittests/observable-selftests.c: Fix common/ includes.
6300         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6301         * unittests/memrange-selftests.c: Fix common/ includes.
6302         * unittests/memory-map-selftests.c: Fix common/ includes.
6303         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6304         * unittests/function-view-selftests.c: Fix common/ includes.
6305         * unittests/environ-selftests.c: Fix common/ includes.
6306         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6307         * unittests/common-utils-selftests.c: Fix common/ includes.
6308         * unittests/cli-utils-selftests.c: Fix common/ includes.
6309         * unittests/array-view-selftests.c: Fix common/ includes.
6310         * ui-file.c: Fix common/ includes.
6311         * tui/tui-io.c: Fix common/ includes.
6312         * tracepoint.h: Fix common/ includes.
6313         * tracepoint.c: Fix common/ includes.
6314         * tracefile-tfile.c: Fix common/ includes.
6315         * top.h: Fix common/ includes.
6316         * top.c: Fix common/ includes.
6317         * thread.c: Fix common/ includes.
6318         * target/waitstatus.h: Fix common/ includes.
6319         * target/waitstatus.c: Fix common/ includes.
6320         * target.h: Fix common/ includes.
6321         * target.c: Fix common/ includes.
6322         * target-memory.c: Fix common/ includes.
6323         * target-descriptions.c: Fix common/ includes.
6324         * symtab.h: Fix common/ includes.
6325         * symfile.c: Fix common/ includes.
6326         * stap-probe.c: Fix common/ includes.
6327         * spu-linux-nat.c: Fix common/ includes.
6328         * sparc-nat.c: Fix common/ includes.
6329         * source.c: Fix common/ includes.
6330         * solib.c: Fix common/ includes.
6331         * solib-target.c: Fix common/ includes.
6332         * ser-unix.c: Fix common/ includes.
6333         * ser-tcp.c: Fix common/ includes.
6334         * ser-pipe.c: Fix common/ includes.
6335         * ser-base.c: Fix common/ includes.
6336         * selftest-arch.c: Fix common/ includes.
6337         * s12z-tdep.c: Fix common/ includes.
6338         * rust-exp.y: Fix common/ includes.
6339         * rs6000-aix-tdep.c: Fix common/ includes.
6340         * riscv-tdep.c: Fix common/ includes.
6341         * remote.c: Fix common/ includes.
6342         * remote-notif.h: Fix common/ includes.
6343         * remote-fileio.h: Fix common/ includes.
6344         * remote-fileio.c: Fix common/ includes.
6345         * regcache.h: Fix common/ includes.
6346         * regcache.c: Fix common/ includes.
6347         * record-btrace.c: Fix common/ includes.
6348         * python/python.c: Fix common/ includes.
6349         * python/py-type.c: Fix common/ includes.
6350         * python/py-inferior.c: Fix common/ includes.
6351         * progspace.h: Fix common/ includes.
6352         * producer.c: Fix common/ includes.
6353         * procfs.c: Fix common/ includes.
6354         * proc-api.c: Fix common/ includes.
6355         * printcmd.c: Fix common/ includes.
6356         * ppc-linux-nat.c: Fix common/ includes.
6357         * parser-defs.h: Fix common/ includes.
6358         * osdata.c: Fix common/ includes.
6359         * obsd-nat.c: Fix common/ includes.
6360         * nat/x86-linux.c: Fix common/ includes.
6361         * nat/x86-linux-dregs.c: Fix common/ includes.
6362         * nat/x86-dregs.h: Fix common/ includes.
6363         * nat/x86-dregs.c: Fix common/ includes.
6364         * nat/ppc-linux.c: Fix common/ includes.
6365         * nat/mips-linux-watch.h: Fix common/ includes.
6366         * nat/mips-linux-watch.c: Fix common/ includes.
6367         * nat/linux-waitpid.c: Fix common/ includes.
6368         * nat/linux-ptrace.h: Fix common/ includes.
6369         * nat/linux-ptrace.c: Fix common/ includes.
6370         * nat/linux-procfs.c: Fix common/ includes.
6371         * nat/linux-personality.c: Fix common/ includes.
6372         * nat/linux-osdata.c: Fix common/ includes.
6373         * nat/linux-namespaces.c: Fix common/ includes.
6374         * nat/linux-btrace.h: Fix common/ includes.
6375         * nat/linux-btrace.c: Fix common/ includes.
6376         * nat/fork-inferior.c: Fix common/ includes.
6377         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6378         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6379         * nat/aarch64-linux.c: Fix common/ includes.
6380         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6381         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6382         * namespace.h: Fix common/ includes.
6383         * mips-linux-tdep.c: Fix common/ includes.
6384         * minsyms.c: Fix common/ includes.
6385         * mi/mi-parse.h: Fix common/ includes.
6386         * mi/mi-main.c: Fix common/ includes.
6387         * mi/mi-cmd-env.c: Fix common/ includes.
6388         * memrange.h: Fix common/ includes.
6389         * memattr.c: Fix common/ includes.
6390         * maint.h: Fix common/ includes.
6391         * maint.c: Fix common/ includes.
6392         * main.c: Fix common/ includes.
6393         * machoread.c: Fix common/ includes.
6394         * location.c: Fix common/ includes.
6395         * linux-thread-db.c: Fix common/ includes.
6396         * linux-nat.c: Fix common/ includes.
6397         * linux-fork.c: Fix common/ includes.
6398         * inline-frame.c: Fix common/ includes.
6399         * infrun.c: Fix common/ includes.
6400         * inflow.c: Fix common/ includes.
6401         * inferior.h: Fix common/ includes.
6402         * inferior.c: Fix common/ includes.
6403         * infcmd.c: Fix common/ includes.
6404         * inf-ptrace.c: Fix common/ includes.
6405         * inf-child.c: Fix common/ includes.
6406         * ia64-linux-nat.c: Fix common/ includes.
6407         * i387-tdep.c: Fix common/ includes.
6408         * i386-tdep.c: Fix common/ includes.
6409         * i386-linux-tdep.c: Fix common/ includes.
6410         * i386-linux-nat.c: Fix common/ includes.
6411         * i386-go32-tdep.c: Fix common/ includes.
6412         * i386-fbsd-tdep.c: Fix common/ includes.
6413         * i386-fbsd-nat.c: Fix common/ includes.
6414         * guile/scm-type.c: Fix common/ includes.
6415         * guile/guile.c: Fix common/ includes.
6416         * go32-nat.c: Fix common/ includes.
6417         * gnu-nat.c: Fix common/ includes.
6418         * gdbthread.h: Fix common/ includes.
6419         * gdbarch-selftests.c: Fix common/ includes.
6420         * gdb_usleep.c: Fix common/ includes.
6421         * gdb_select.h: Fix common/ includes.
6422         * gdb_bfd.c: Fix common/ includes.
6423         * gcore.c: Fix common/ includes.
6424         * fork-child.c: Fix common/ includes.
6425         * findvar.c: Fix common/ includes.
6426         * fbsd-nat.c: Fix common/ includes.
6427         * event-top.c: Fix common/ includes.
6428         * event-loop.c: Fix common/ includes.
6429         * dwarf2read.c: Fix common/ includes.
6430         * dwarf2loc.c: Fix common/ includes.
6431         * dwarf2-frame.c: Fix common/ includes.
6432         * dwarf-index-cache.c: Fix common/ includes.
6433         * dtrace-probe.c: Fix common/ includes.
6434         * disasm-selftests.c: Fix common/ includes.
6435         * defs.h: Fix common/ includes.
6436         * csky-tdep.c: Fix common/ includes.
6437         * cp-valprint.c: Fix common/ includes.
6438         * cp-support.h: Fix common/ includes.
6439         * cp-support.c: Fix common/ includes.
6440         * corelow.c: Fix common/ includes.
6441         * completer.h: Fix common/ includes.
6442         * completer.c: Fix common/ includes.
6443         * compile/compile.c: Fix common/ includes.
6444         * compile/compile-loc2c.c: Fix common/ includes.
6445         * compile/compile-cplus-types.c: Fix common/ includes.
6446         * compile/compile-cplus-symbols.c: Fix common/ includes.
6447         * command.h: Fix common/ includes.
6448         * cli/cli-dump.c: Fix common/ includes.
6449         * cli/cli-cmds.c: Fix common/ includes.
6450         * charset.c: Fix common/ includes.
6451         * build-id.c: Fix common/ includes.
6452         * btrace.h: Fix common/ includes.
6453         * btrace.c: Fix common/ includes.
6454         * breakpoint.h: Fix common/ includes.
6455         * breakpoint.c: Fix common/ includes.
6456         * ax.h:
6457         (enum agent_op): Fix common/ includes.
6458         * ax-general.c (struct aop_map): Fix common/ includes.
6459         * ax-gdb.c: Fix common/ includes.
6460         * auxv.c: Fix common/ includes.
6461         * auto-load.c: Fix common/ includes.
6462         * arm-tdep.c: Fix common/ includes.
6463         * arch/riscv.c: Fix common/ includes.
6464         * arch/ppc-linux-common.c: Fix common/ includes.
6465         * arch/i386.c: Fix common/ includes.
6466         * arch/arm.c: Fix common/ includes.
6467         * arch/arm-linux.c: Fix common/ includes.
6468         * arch/arm-get-next-pcs.c: Fix common/ includes.
6469         * arch/amd64.c: Fix common/ includes.
6470         * arch/aarch64.c: Fix common/ includes.
6471         * arch/aarch64-insn.c: Fix common/ includes.
6472         * arch-utils.c: Fix common/ includes.
6473         * amd64-windows-tdep.c: Fix common/ includes.
6474         * amd64-tdep.c: Fix common/ includes.
6475         * amd64-sol2-tdep.c: Fix common/ includes.
6476         * amd64-obsd-tdep.c: Fix common/ includes.
6477         * amd64-nbsd-tdep.c: Fix common/ includes.
6478         * amd64-linux-tdep.c: Fix common/ includes.
6479         * amd64-linux-nat.c: Fix common/ includes.
6480         * amd64-fbsd-tdep.c: Fix common/ includes.
6481         * amd64-fbsd-nat.c: Fix common/ includes.
6482         * amd64-dicos-tdep.c: Fix common/ includes.
6483         * amd64-darwin-tdep.c: Fix common/ includes.
6484         * agent.c: Fix common/ includes.
6485         * ada-lang.h: Fix common/ includes.
6486         * ada-lang.c: Fix common/ includes.
6487         * aarch64-tdep.c: Fix common/ includes.
6488
6489 2019-01-25  Tom Tromey  <tom@tromey.com>
6490
6491         * common/create-version.sh: Use common/version.h.
6492
6493 2019-01-24  Pedro Alves  <palves@redhat.com>
6494
6495         * infrun.c (signal_stop, signal_print, signal_program)
6496         (signal_catch, signal_pass): Now arrays instead of pointers.
6497         (update_signals_program_target, do_target_resume)
6498         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6499         * linux-nat.c (linux_nat_target::pass_signals)
6500         (linux_nat_target::create_inferior, linux_nat_target::attach):
6501         Adjust.
6502         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6503         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6504         * procfs.c (procfs_target::pass_signals): Adjust.
6505         * record-full.c (record_full_target::resume): Adjust.
6506         * remote.c (remote_target::pass_signals)
6507         (remote_target::program_signals): Adjust.
6508         * target-debug.h (target_debug_print_signals): Now takes a
6509         gdb::array_view as parameter.  Adjust.
6510         * target.h (target_ops) <pass_signals, program_signals>: Replace
6511         pointer and length parameters with gdb::array_view.
6512         (target_pass_signals, target_program_signals): Likewise.
6513         * target-delegates.c: Regenerate.
6514
6515 2019-01-24  Pedro Alves  <palves@redhat.com>
6516
6517         * common/forward-scope-exit.h
6518         (forward_scope_exit::forward_scope_exit): Pass arguments to
6519         m_bind_function directly, instead of creating a std::bind and
6520         copying that.
6521
6522 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6523
6524         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6525         for static members.
6526         (pass_in_v_vfp_candidate): Likewise.
6527
6528 2019-01-23  Tom Tromey  <tom@tromey.com>
6529             Pedro Alves  <palves@redhat.com>
6530
6531         * regcache.c (class regcache_invalidator): Remove.
6532         (regcache::raw_write): Use make_scope_exit.
6533
6534 2019-01-23  Tom Tromey  <tom@tromey.com>
6535
6536         * ui-out.h (class ui_out_emit_type): Update comment.
6537
6538 2019-01-23  Tom Tromey  <tom@tromey.com>
6539
6540         * infrun.c (fetch_inferior_event): Update comment.
6541
6542 2019-01-23  Tom Tromey  <tom@tromey.com>
6543             Pedro Alves  <palves@redhat.com>
6544
6545         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6546         parameter.
6547         (fetch_inferior_event): Use SCOPE_EXIT.
6548
6549
6550 2019-01-23  Tom Tromey  <tom@tromey.com>
6551             Pedro Alves  <palves@redhat.com>
6552
6553         * infrun.c (disable_thread_events): Delete.
6554         (stop_all_threads): Use SCOPE_EXIT.
6555
6556 2019-01-23  Tom Tromey  <tom@tromey.com>
6557             Pedro Alves  <palves@redhat.com>
6558
6559         * symfile.c: Include forward-scope-exit.h.
6560         (clear_symtab_users_cleanup): Replace forward declaration with
6561         a FORWARD_SCOPE_EXIT.
6562         (syms_from_objfile_1): Use the forward_scope_exit and
6563         gdb::optional instead of cleanup_function.
6564         (reread_symbols): Use the forward_scope_exit instead of
6565         cleanup_function.
6566         (clear_symtab_users_cleanup): Remove function.
6567
6568 2019-01-23  Tom Tromey  <tom@tromey.com>
6569             Pedro Alves  <palves@redhat.com>
6570
6571         * linux-nat.c: Include scope-exit.h.
6572         (cleanup_target_stop): Remove.
6573         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6574         SCOPE_EXIT.
6575
6576 2019-01-23  Tom Tromey  <tom@tromey.com>
6577             Pedro Alves  <palves@redhat.com>
6578
6579         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6580         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6581
6582 2019-01-23  Tom Tromey  <tom@tromey.com>
6583             Andrew Burgess  <andrew.burgess@embecosm.com>
6584             Pedro Alves  <palves@redhat.com>
6585
6586         * infrun.c (fetch_inferior_event): Use scope_exit.
6587         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6588         * top.c (execute_command): Use scope_exit.
6589         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6590         * utils.c (do_bpstat_clear_actions_cleanup)
6591         (make_bpstat_clear_actions_cleanup): Remove.
6592
6593 2019-01-23  Tom Tromey  <tom@tromey.com>
6594             Pedro Alves  <palves@redhat.com>
6595
6596         * infrun.c: Include "common/scope-exit.h"
6597         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6598         (wait_for_inferior): Use SCOPE_EXIT.
6599         (fetch_inferior_event): Use scope_exit.
6600
6601 2019-01-23  Tom Tromey  <tom@tromey.com>
6602             Pedro Alves  <palves@redhat.com>
6603
6604         * breakpoint.c (create_breakpoint): Remove cleanup.
6605
6606 2019-01-23  Tom Tromey  <tom@tromey.com>
6607             Andrew Burgess  <andrew.burgess@embecosm.com>
6608             Pedro Alves  <palves@redhat.com>
6609
6610 2019-01-23  Pedro Alves  <palves@redhat.com>
6611
6612         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6613
6614 2019-01-23  Pedro Alves  <palves@redhat.com>
6615             Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * gdbthread.h: Include "common/forward-scope-exit.h".
6618         (scoped_finish_thread_state): Redefine custom class in terms of
6619         forward_scope_exit.
6620
6621 2019-01-23  Pedro Alves  <palves@redhat.com>
6622             Andrew Burgess  <andrew.burgess@embecosm.com>
6623
6624         * common/forward-scope-exit.h: New file.
6625
6626 2019-01-23  Pedro Alves  <palves@redhat.com>
6627             Andrew Burgess  <andrew.burgess@embecosm.com>
6628             Tom Tromey  <tom@tromey.com>
6629
6630         * common/scope-exit.h: New file.
6631
6632 2019-01-23  Pedro Alves  <palves@redhat.com>
6633
6634         * common/preprocessor.h (ESC): Rename to ...
6635         (ESC_PARENS): ... this.
6636         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6637         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6638
6639 2019-01-23  Tom Tromey  <tom@tromey.com>
6640
6641         * language.h (class scoped_switch_to_sym_language_if_auto):
6642         Initialize m_lang in both cases.
6643
6644 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6645
6646         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6647         with XCNEW.
6648
6649 2019-01-22  Tom Tromey  <tom@tromey.com>
6650
6651         * corelow.c: Do not include sys/file.h.
6652
6653 2019-01-22  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-wingeneral.h: Include gdb_curses.h.
6656
6657 2019-01-22  Tom Tromey  <tom@tromey.com>
6658
6659         * source-cache.h (class source_cache) <get_source_lines,
6660         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6661
6662 2019-01-22  Tom Tromey  <tom@tromey.com>
6663
6664         * remote-fileio.h (struct remote_target): Declare.
6665
6666 2019-01-22  Tom Tromey  <tom@tromey.com>
6667
6668         * python/py-arch.c: Do not include py-ref.h.
6669         * python/py-bpevent.c: Do not include py-ref.h.
6670         * python/py-cmd.c: Do not include py-ref.h.
6671         * python/py-continueevent.c: Do not include py-ref.h.
6672         * python/py-event.h: Do not include py-ref.h.
6673         * python/py-evtregistry.c: Do not include py-ref.h.
6674         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6675         * python/py-frame.c: Do not include py-ref.h.
6676         * python/py-framefilter.c: Do not include py-ref.h.
6677         * python/py-function.c: Do not include py-ref.h.
6678         * python/py-infevents.c: Do not include py-ref.h.
6679         * python/py-linetable.c: Do not include py-ref.h.
6680         * python/py-objfile.c: Do not include py-ref.h.
6681         * python/py-param.c: Do not include py-ref.h.
6682         * python/py-prettyprint.c: Do not include py-ref.h.
6683         * python/py-progspace.c: Do not include py-ref.h.
6684         * python/py-symbol.c: Do not include py-ref.h.
6685         * python/py-symtab.c: Do not include py-ref.h.
6686         * python/py-type.c: Do not include py-ref.h.
6687         * python/py-unwind.c: Do not include py-ref.h.
6688         * python/py-utils.c: Do not include py-ref.h.
6689         * python/py-value.c: Do not include py-ref.h.
6690         * python/py-varobj.c: Do not include py-ref.h.
6691         * python/py-xmethods.c: Do not include py-ref.h.
6692         * python/python.c: Do not include py-ref.h.
6693         * varobj.c: Do not include py-ref.h.
6694
6695 2019-01-22  Tom Tromey  <tom@tromey.com>
6696
6697         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6698         keyword for bcache.
6699
6700 2019-01-22  Tom Tromey  <tom@tromey.com>
6701
6702         * compile/compile-cplus-types.c: Remove a comment by #include.
6703
6704 2019-01-22  Tom Tromey  <tom@tromey.com>
6705
6706         * compile/gcc-c-plugin.h: Include compile-internal.h.
6707
6708 2019-01-22  Tom Tromey  <tom@tromey.com>
6709
6710         * stabsread.c (EXTERN): Do not define.
6711         (symnum, next_symbol_text_func, processing_gcc_compilation)
6712         (within_function, global_sym_chain, global_stabs)
6713         (previous_stab_code, this_object_header_files)
6714         (n_this_object_header_files)
6715         (n_allocated_this_object_header_files): Define.
6716         * stabsread.h (EXTERN): Never define.  Use "extern".
6717
6718 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6719
6720         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6721         history_value.
6722
6723 2019-01-21  Tom Tromey  <tom@tromey.com>
6724
6725         * ui-out.c: Fix includes.
6726         * tui/tui-source.c: Fix includes.
6727         * target.c: Fix includes.
6728         * remote.c: Fix includes.
6729         * regcache.c: Fix includes.
6730         * python/py-block.c: Fix includes.
6731         * printcmd.c: Fix includes.
6732         * or1k-tdep.c: Fix includes.
6733         * mi/mi-main.c: Fix includes.
6734         * m32r-tdep.c: Fix includes.
6735         * csky-tdep.c: Fix includes.
6736         * compile/compile-cplus-types.c: Fix includes.
6737         * cli/cli-interp.c: Fix includes.
6738
6739 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6740
6741         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6742         for padding.
6743
6744 2019-01-16  Tom Tromey  <tom@tromey.com>
6745
6746         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6747         earlier.
6748         (struct objfile) <msymbols_range>: Move from top level.
6749         <msymbols>: New method.
6750         (class objfile_msymbols): Remove.
6751         * symtab.c (default_collect_symbol_completion_matches_break_on):
6752         Update.
6753         * symmisc.c (dump_msymbols): Update.
6754         * stabsread.c (scan_file_globals): Update.
6755         * objc-lang.c (info_selectors_command, info_classes_command)
6756         (find_methods): Update.
6757         * minsyms.c (find_solib_trampoline_target): Update.
6758         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6759         * coffread.c (coff_symfile_read): Update.
6760         * ada-lang.c (ada_lookup_simple_minsym)
6761         (ada_collect_symbol_completion_matches): Update.
6762
6763 2019-01-16  Tom Tromey  <tom@tromey.com>
6764
6765         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6766         type.  Remove no-argument constructor.
6767         <iterator::operator++>: Simplify.
6768         <begin>: Update.
6769         <end>: Use minimal_symbol_count.
6770
6771 2019-01-16  Tom Tromey  <tom@tromey.com>
6772
6773         * objfiles.h (struct objfile) <psymtabs>: New method.
6774         (class objfile_psymtabs): Remove.
6775         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6776         typedef.
6777         <range>: New method.
6778         (require_partial_symbols): Change return type.
6779         * psymtab.c (require_partial_symbols)
6780         (psym_expand_symtabs_matching): Update.
6781         * mdebugread.c (parse_partial_symbols): Update.
6782         * dbxread.c (dbx_end_psymtab): Update.
6783
6784 2019-01-15  Tom Tromey  <tom@tromey.com>
6785
6786         * symtab.c (lookup_objfile_from_block)
6787         (lookup_symbol_in_objfile_symtabs)
6788         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6789         (find_line_symtab, info_sources_command)
6790         (default_collect_symbol_completion_matches_break_on)
6791         (make_source_files_completion_list): Update.
6792         * symmisc.c (print_objfile_statistics, dump_objfile)
6793         (maintenance_print_symbols, maintenance_info_symtabs)
6794         (maintenance_check_symtabs, maintenance_info_line_tables):
6795         Update.
6796         * source.c (select_source_symtab)
6797         (forget_cached_source_info_for_objfile): Update.
6798         * objfiles.h (class objfile_compunits): Remove.
6799         (struct objfile) <compunits_range>: New typedef.
6800         (compunits): New method.
6801         * objfiles.c (objfile_relocate1): Update.
6802         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6803         * maint.c (count_symtabs_and_blocks): Update.
6804         * linespec.c (iterate_over_all_matching_symtabs): Update.
6805         * cp-support.c (add_symbol_overload_list_qualified): Update.
6806         * coffread.c (coff_symtab_read): Update.
6807         * ada-lang.c (add_nonlocal_symbols)
6808         (ada_collect_symbol_completion_matches)
6809         (ada_add_global_exceptions): Update.
6810
6811 2019-01-15  Tom Tromey  <tom@tromey.com>
6812
6813         * progspace.h (program_space) <objfiles_safe_range>: New
6814         typedef.
6815         <objfiles_safe>: New method.
6816         * objfiles.h (class all_objfiles_safe): Remove.
6817         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6818         * jit.c (jit_inferior_exit_hook): Update.
6819
6820 2019-01-17  Tom Tromey  <tom@tromey.com>
6821
6822         * progspace.h (program_space) <objfiles_range>: New typedef.
6823         <objfiles>: New method.
6824         <objfiles_head>: Rename from objfiles.
6825         (object_files): Update.
6826         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6827         * guile/scm-pretty-print.c
6828         (ppscm_find_pretty_printer_from_objfiles): Update.
6829         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6830         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6831         Update.
6832         * python/py-progspace.c (pspy_get_objfiles): Update.
6833         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6834         Update.
6835         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6836         (objfpy_lookup_objfile_by_build_id): Update.
6837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6838         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6839         Update.
6840         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6841         (expand_symtab_containing_pc, lookup_objfile_from_block)
6842         (lookup_static_symbol, basic_lookup_transparent_type)
6843         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6844         (find_line_symtab, info_sources_command)
6845         (default_collect_symbol_completion_matches_break_on)
6846         (make_source_files_completion_list, find_main_name): Update.
6847         * symmisc.c (print_symbol_bcache_statistics)
6848         (print_objfile_statistics, maintenance_print_symbols)
6849         (maintenance_print_msymbols, maintenance_print_objfiles)
6850         (maintenance_info_symtabs, maintenance_check_symtabs)
6851         (maintenance_expand_symtabs, maintenance_info_line_tables):
6852         Update.
6853         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6854         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6855         (map_overlay_command, unmap_overlay_command)
6856         (simple_overlay_update, expand_symtabs_matching)
6857         (map_symbol_filenames): Update.
6858         * symfile-debug.c (set_debug_symfile): Update.
6859         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6860         Update.
6861         * source.c (select_source_symtab, forget_cached_source_info):
6862         Update.
6863         * solib.c (solib_read_symbols): Update.
6864         * solib-spu.c (append_ocl_sos): Update.
6865         * psymtab.c (maintenance_print_psymbols)
6866         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6867         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6868         * printcmd.c (info_symbol_command): Update.
6869         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6870         Update.
6871         * objfiles.h (class all_objfiles): Remove.
6872         * objfiles.c (have_partial_symbols, have_full_symbols)
6873         (have_minimal_symbols, qsort_cmp, update_section_map)
6874         (shared_objfile_contains_address_p)
6875         (default_iterate_over_objfiles_in_search_order): Update.
6876         * objc-lang.c (info_selectors_command, info_classes_command)
6877         (find_methods): Update.
6878         * minsyms.c (find_solib_trampoline_target): Update.
6879         * maint.c (maintenance_info_sections)
6880         (maintenance_translate_address, count_symtabs_and_blocks):
6881         Update.
6882         * main.c (captured_main_1): Update.
6883         * linux-thread-db.c (try_thread_db_load_from_pdir)
6884         (has_libpthread): Update.
6885         * linespec.c (iterate_over_all_matching_symtabs)
6886         (search_minsyms_for_name): Update.
6887         * jit.c (jit_find_objf_with_entry_addr): Update.
6888         * hppa-tdep.c (find_unwind_entry)
6889         (hppa_lookup_stub_minimal_symbol): Update.
6890         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6891         Update.
6892         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6893         (elf_gnu_ifunc_resolve_by_got): Update.
6894         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6895         * dwarf-index-write.c (save_gdb_index_command): Update.
6896         * cp-support.c (add_symbol_overload_list_qualified): Update.
6897         * breakpoint.c (create_overlay_event_breakpoint)
6898         (create_longjmp_master_breakpoint)
6899         (create_std_terminate_master_breakpoint)
6900         (create_exception_master_breakpoint): Update.
6901         * blockframe.c (find_pc_partial_function): Update.
6902         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6903         (ada_collect_symbol_completion_matches)
6904         (ada_add_global_exceptions): Update.
6905
6906 2019-01-17  Tom Tromey  <tom@tromey.com>
6907
6908         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6909         declare VEC.
6910         (solib_target_parse_libraries): Change return type.
6911         (library_list_start_segment, library_list_start_section)
6912         (library_list_end_library, library_list_start_library); Update.
6913         (solib_target_free_library_list): Remove.
6914         (solib_target_parse_libraries): Remove cleanup.  Change return
6915         type.
6916         (solib_target_current_sos): Update.
6917
6918 2019-01-17  Tom Tromey  <tromey@bapiya>
6919
6920         * valprint.c: Replace "the the" with "the".
6921         * symtab.c: Replace "the the" with "the".
6922         * solib.c: Replace "the the" with "the".
6923         * solib-dsbt.c: Replace "the the" with "the".
6924         * linespec.c: Replace "the the" with "the".
6925         * dwarf2loc.h: Replace "the the" with "the".
6926         * amd64-windows-tdep.c: Replace "the the" with "the".
6927         * aarch64-tdep.c: Replace "the the" with "the".
6928
6929 2019-01-16  Keith Seitz  <keiths@redhat.com>
6930
6931         PR gdb/23773
6932         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6933         <builder>: Rename to ..
6934         <m_builder>: ... this and make private.
6935         (dwarf2_cu::get_builder): New method.  Change all users of
6936         `builder' to use this method.
6937         (dwarf2_start_symtab): Move to ...
6938         (dwarf2_cu::start_symtab): ... here.  Update all callers
6939         (setup_type_unit_groups): Move to ...
6940         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6941         callers.
6942         (dwarf2_cu::reset_builder): New method.
6943         (process_full_compunit, process_full_type_unit): Use
6944         dwarf2_cu::reset_builder.
6945         (follow_die_offset): Record the ancestor CU if it is different
6946         from the followed DIE's CU.
6947         (follow_die_sig_1): Likewise.
6948
6949 2019-01-15  Tom Tromey  <tom@tromey.com>
6950
6951         * remote.c (class remote_state) <buf>: Now a char_vector.
6952         <buf_size>: Remove.
6953         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6954         parameter.
6955         (remote_target::getpkt_or_notif_sane_1)
6956         (remote_target::getpkt_sane)
6957         (remote_target::getpkt_or_notif_sane): Likewise.
6958         (class remote_target) <putpkt>: New overload.
6959         (remote_target::read_frame): Change type of "buf_p".  Remove
6960         sizeof_p parameter.
6961         (packet_ok): New overload.
6962         (packet_check_result): New overload.
6963         Update all uses.
6964
6965 2019-01-14  Tom Tromey  <tom@tromey.com>
6966
6967         * remote-notif.c (handle_notification, remote_notif_ack)
6968         (remote_notif_parse): Make "buf" const.
6969         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6970         const.
6971         (remote_notif_parse, remote_notif_ack, handle_notification):
6972         Likewise.
6973         * remote.c (remote_notif_stop_parse): Make "buf" const.
6974         (remote_target::remote_parse_stop_reply): Make "buf" const.
6975         (remote_notif_stop_ack): Make "buf" const.
6976
6977 2019-01-14  Tom Tromey  <tom@tromey.com>
6978
6979         * remote.c (remote_console_output): Make parameter const.
6980
6981 2019-01-14  Tom Tromey  <tom@tromey.com>
6982
6983         * target-debug.h (target_debug_print_signals): Constify.
6984         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6985         * procfs.c (procfs_target::pass_signals): Update.
6986         * linux-nat.c (linux_nat_target::pass_signals): Update.
6987         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6988         * target-delegates.c: Rebuild.
6989         * remote.c (remote_target::program_signals): Update.
6990         (remote_target::pass_signals): Update.
6991         * target.c (target_pass_signals): Constify argument.
6992         (target_program_signals): Likewise.
6993         * target.h (struct target_ops) <pass_signals, program_signals>:
6994         Constify argument.
6995         (target_pass_signals, target_program_signals): Constify argument.
6996
6997 2019-01-14  Tom Tromey  <tom@tromey.com>
6998
6999         PR tui/28819:
7000         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7001
7002 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7003
7004         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7005         field.
7006         * rs6000-tdep.c: Include reggroups.h.
7007         (IS_V_ALIAS_PSEUDOREG): Define.
7008         (rs6000_register_name): Return names for the "vX" aliases.
7009         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7010         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7011         aliases.  Call default_register_reggroup_p for all other
7012         pseudo-registers.
7013         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7014         New functions.
7015         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7016         Handle "vX" aliases.
7017         (v_alias_pseudo_register_collect): New function.
7018         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7019         (rs6000_gdbarch_init): Initialize "vX" aliases as
7020         pseudo-registers.  Restore registration of
7021         rs6000_pseudo_register_reggroup_p with
7022         set_tdesc_pseudo_register_reggroup_p.
7023
7024 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7025
7026         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7027         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7028         set_gdbarch_num_pseudo_regs.
7029
7030 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7031
7032         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7033         Remove arg prefixname, add do_set and do_show.
7034         Add member functions set_list and show_list.
7035         * cli/cli-style.c (class cli_style_option): Update accordingly.
7036         (style_set_list): Move to file scope.
7037         (style_show_list): Likewise.
7038         (set_style): Call help_list.
7039         (show_style): Call cmd_show_list.
7040         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7041         Update to use the new macro.
7042
7043 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7044
7045         * ada-lang.c (_initialize_ada_language): Expand the help text
7046         for the "catch exception" command.
7047
7048 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7049
7050         * symtab.c (matching_obj_sections): Initialize obj,
7051         declare it closer to its usage.
7052
7053 2019-01-10  Tom Tromey  <tom@tromey.com>
7054
7055         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7056         (basic_inf_threads_range): Remove.
7057         (inf_threads_range, inf_non_exited_threads_range)
7058         (safe_inf_threads_range): Use next_adapter.
7059
7060 2019-01-10  Keith Seitz  <keiths@redhat.com>
7061
7062         PR gdb/23712
7063         PR symtab/23010
7064         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7065         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7066
7067 2019-01-10  Keith Seitz  <keiths@redhat.com>
7068
7069         PR gdb/23712
7070         PR symtab/23010
7071         * dictionary.c (pending_to_vector): Remove.
7072         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7073         Remove _1 suffix, replacing functions of the same name.  Update
7074         all callers.
7075         (dict_create_hashed, dict_create_hashed_expandable)
7076         (dict_create_linear, dict_create_linear_expandable, dict_free)
7077         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7078         Make functions static.
7079
7080 2019-01-10  Keith Seitz  <keiths@redhat.com>
7081
7082         PR gdb/23712
7083         PR symtab/23010
7084         * dictionary.h (struct dictionary): Replace declaration with
7085         multidictionary.
7086         (dict_create_hashed, dict_create_hashed_expandable)
7087         (dict_create_linear, dict_create_linear_expandable)
7088         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7089         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7090         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7091         taking multidictionary argument.
7092         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7093         * block.h (struct block) <dict>: Change to multidictionary
7094         and rename `multidict'.
7095         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7096         symmisc.c: Update all dictionary references to multidictionary.
7097
7098 2019-01-10  Keith Seitz  <keiths@redhat.com>
7099
7100         PR gdb/23712
7101         PR symtab/23010
7102         * dictionary.c: Include unordered_map.
7103         (pending_to_vector): New function.
7104         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7105         Rewrite the non-"_1" functions to take vector instead
7106         of linked list.
7107         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7108         "new" _1 versions of the same name.
7109         (multidictionary): Define.
7110         (std::hash<enum language): New definition.
7111         (collate_pending_symbols_by_language, mdict_create_hashed)
7112         (mdict_create_hashed_expandable, mdict_create_linear)
7113         (mdict_create_linear_expandable, mdict_free)
7114         (find_language_dictionary, create_new_language_dictionary)
7115         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7116         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7117         (mdict_size, mdict_empty): New functions.
7118         * dictionary.h (mdict_iterator): Define.
7119
7120 2019-01-10  Pedro Alves  <palves@redhat.com>
7121
7122         * breakpoint.c (read_uploaded_action)
7123         (create_tracepoint_from_upload): Adjust to use
7124         gdb::unique_xmalloc_ptr.
7125         * ctf.c (ctf_write_uploaded_tp):
7126         (SET_ARRAY_FIELD): Use emplace_back.
7127         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7128         * tracefile-tfile.c (tfile_write_uploaded_tp):
7129         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7130         gdb::unique_xmalloc_ptr.
7131         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7132         at_string, cond_string, cmd_strings>: Replace char pointers
7133         with gdb::unique_xmalloc_ptr.
7134
7135 2019-01-10  Pedro Alves  <palves@redhat.com>
7136
7137         * solib-target.c (library_list_start_library): Don't xstrdup name.
7138
7139 2019-01-10  Pedro Alves  <palves@redhat.com>
7140
7141         * mdebugread.c (parse_partial_symbols): Use
7142         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7143
7144 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7145
7146         * linux-fork.c (scoped_switch_fork_info)
7147         <~scoped_switch_fork_info>: Fix incorrect variable name.
7148
7149 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * linux-fork.c (scoped_switch_fork_info)
7152         <scoped_switch_fork_info>: Make explicit.
7153         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7154
7155 2019-01-10  Tom Tromey  <tom@tromey.com>
7156
7157         * objfiles.h (objfile::reset_psymtabs): Update.
7158         * objfiles.c (objfile::objfile): Update.
7159         * psymtab.h (psymtab_storage::obstack): Update.
7160         (psymtab_storage::m_obstack): Use gdb::optional.
7161         (class psymtab_storage): Update comment.  Remove objfile
7162         parameter.
7163         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7164
7165 2019-01-10  Tom Tromey  <tom@tromey.com>
7166
7167         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7168         <free_psymtabs>: Now private.
7169         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7170         (allocate_psymtab): Use new method.
7171
7172 2019-01-10  Tom Tromey  <tom@tromey.com>
7173
7174         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7175         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7176         * mdebugread.c (parse_partial_symbols): Use
7177         allocate_dependencies.
7178         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7179         allocate_dependencies.
7180         (process_psymtab_comp_unit_reader)
7181         (build_type_psymtab_dependencies): Likewise.
7182         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7183
7184 2019-01-10  Tom Tromey  <tom@tromey.com>
7185
7186         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7187         PSYMBOL_SET_LANGUAGE.
7188         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7189
7190 2019-01-10  Tom Tromey  <tom@tromey.com>
7191
7192         * psymtab.h (psymtab_storage::obstack): New method.
7193         <m_obstack>: Rename from obstack; now private.
7194         * psymtab.c (psymtab_storage): Update.
7195         * dwarf2read.c (create_addrmap_from_index)
7196         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7197         Update.
7198
7199 2019-01-10  Tom Tromey  <tom@tromey.com>
7200
7201         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7202         * objfiles.h (objfile::reset_psymtabs): New method.
7203
7204 2019-01-10  Tom Tromey  <tom@tromey.com>
7205
7206         * symmisc.c (print_symbol_bcache_statistics): Update.
7207         (print_objfile_statistics): Update.
7208         * symfile.c (reread_symbols): Update.
7209         * psymtab.h (class psymtab_storage): New.
7210         * psymtab.c (psymtab_storage): New constructor.
7211         (~psymtab_storage): New destructor.
7212         (require_partial_symbols): Update.
7213         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7214         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7215         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7216         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7217         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7218         (start_psymtab_common, end_psymtab_common)
7219         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7220         (allocate_psymtab): Update.
7221         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7222         Update.
7223         (dump_psymtab_addrmap, maintenance_print_psymbols)
7224         (maintenance_check_psymtabs): Update.
7225         (class objfile_psymtabs): Move to objfiles.h.
7226         * psympriv.h (discard_psymtab): Now inline.
7227         (psymtab_discarder::psymtab_discarder): Update.
7228         (psymtab_discarder::~psymtab_discarder): Update.
7229         (ALL_OBJFILE_PSYMTABS): Rewrite.
7230         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7231         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7232         Remove fields.
7233         <partial_symtabs>: New field.
7234         (class objfile_psymtabs): Move from psymtab.h.  Update.
7235         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7236         psymbol_cache.
7237         (objfile::~objfile): Don't destroy psymbol_cache.
7238         * mdebugread.c (parse_partial_symbols): Update.
7239         * dwarf2read.c (create_addrmap_from_index)
7240         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7241         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7242         (add_partial_subprogram, dwarf2_ranges_read): Update.
7243         * dwarf-index-write.c (write_address_map)
7244         (write_one_signatured_type, recursively_write_psymbols)
7245         (class debug_names, class debug_names, write_psymtabs_to_index):
7246         Update.
7247
7248 2019-01-10  Tom Tromey  <tom@tromey.com>
7249
7250         * symtab.h (SYMBOL_SET_NAMES): Update.
7251         (symbol_set_names): Update.
7252         (MSYMBOL_SET_NAMES): Update.
7253         * symtab.c (symbol_set_names): Change argument to be an
7254         objfile_per_bfd_storage.
7255         * psymtab.c (add_psymbol_to_bcache): Update.
7256         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7257
7258 2019-01-10  Tom Tromey  <tom@tromey.com>
7259
7260         * symtab.c (create_demangled_names_hash): Change argument to be an
7261         objfile_per_bfd_storage.
7262         (symbol_set_names): Update.
7263
7264 2019-01-10  Tom Tromey  <tom@tromey.com>
7265
7266         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7267         init_psymbol_list.
7268         * psymtab.c (init_psymbol_list): Do nothing if already called.
7269         * psympriv.h (init_psymbol_list): Add comment.
7270         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7271         init_psymbol_list.
7272         * dbxread.c (dbx_symfile_read): Unconditionally call
7273         init_psymbol_list.
7274
7275 2019-01-10  Tom Tromey  <tom@tromey.com>
7276
7277         * xcoffread.c (scan_xcoff_symtab): Update.
7278         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7279         "where".
7280         * mdebugread.c (parse_partial_symbols)
7281         (handle_psymbol_enumerators): Update.
7282         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7283         * dbxread.c (read_dbx_symtab): Update.
7284         * psympriv.h (psymbol_placement): New enum.
7285         (add_psymbol_to_list): Update.
7286
7287 2019-01-10  Tom Tromey  <tom@tromey.com>
7288
7289         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7290         static_psymbols parameters.
7291         (scan_xcoff_symtab): Update.
7292         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7293         static_psymbols parameters.
7294         * psympriv.h (start_psymtab_common): Update.
7295         * mdebugread.c (parse_partial_symbols): Update.
7296         * dwarf2read.c (create_partial_symtab): Update.
7297         * dbxread.c (read_dbx_symtab): Update.
7298         (start_psymtab): Remove global_psymbols and static_psymbols
7299         parameters.
7300
7301 2019-01-10  Tom Tromey  <tom@tromey.com>
7302
7303         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7304         * psymtab.c (allocate_psymtab): Add comment.
7305         * psympriv.h (allocate_psymtab): Add comment.
7306         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7307         initializations.
7308         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7309
7310 2019-01-10  Tom Tromey  <tom@tromey.com>
7311
7312         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7313         Don't declare.
7314         * mipsread.c: Include mdebugread.h.
7315         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7316         Declare.
7317         * elfread.c: Include mdebugread.h.
7318
7319 2019-01-09  Tom Tromey  <tom@tromey.com>
7320
7321         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7322         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7323         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7324         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7325         (psym_lookup_symbol, psym_find_last_source_symtab)
7326         (psym_forget_cached_source_info, psym_print_stats)
7327         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7328         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7329         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7330         (psym_find_compunit_symtab_by_address)
7331         (maintenance_print_psymbols, maintenance_info_psymtabs)
7332         (maintenance_check_psymtabs): Use ranged for.
7333         * psymtab.h (class objfile_psymtabs): New.
7334         (require_partial_symbols): Return objfile_psymtabs.
7335         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7336
7337 2019-01-09  Tom Tromey  <tom@tromey.com>
7338
7339         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7340         (find_pc_mapped_section, list_overlays_command)
7341         (map_overlay_command, unmap_overlay_command)
7342         (simple_overlay_update): Use all_objfiles.
7343         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7344         * printcmd.c (info_symbol_command): Use all_objfiles.
7345         * objfiles.h (ALL_OBJSECTIONS): Remove.
7346         * maint.c (maintenance_translate_address): Use all_objfiles.
7347         * gcore.c (gcore_create_callback): Use all_objfiles.
7348         (objfile_find_memory_regions): Likewise.
7349
7350 2019-01-09  Tom Tromey  <tom@tromey.com>
7351
7352         * symtab.c (find_line_symtab, info_sources_command)
7353         (make_source_files_completion_list): Use objfile_compunits.
7354         * source.c (select_source_symtab): Use objfile_compunits.
7355         * objfiles.h (struct objfile): Update comment.
7356         (ALL_OBJFILES): Remove.
7357         (ALL_FILETABS): Remove.
7358         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7359         objfile_compunits.
7360
7361 2019-01-09  Tom Tromey  <tom@tromey.com>
7362
7363         * symmisc.c (print_objfile_statistics, dump_objfile)
7364         (maintenance_print_symbols): Use compunit_filetabs.
7365         * source.c (forget_cached_source_info_for_objfile): Use
7366         compunit_filetabs.
7367         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7368         (ALL_FILETABS): Use compunit_filetabs.
7369         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7370         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7371
7372 2019-01-09  Tom Tromey  <tom@tromey.com>
7373
7374         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7375         (compunit_filetabs): New.
7376         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7377         compunit_filetabs.
7378         (info_sources_command, make_source_files_completion_list): Remove
7379         declaration.
7380         * symmisc.c (print_objfile_statistics, dump_objfile)
7381         (maintenance_print_symbols): Remove declaration.
7382         (maintenance_info_symtabs): Use compunit_filetabs.
7383         (maintenance_info_line_tables): Likewise.
7384         * source.c (select_source_symtab): Change local variable name.
7385         (forget_cached_source_info_for_objfile): Remove declaration.
7386         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7387         * objfiles.c (objfile_relocate1): Remove declaration.
7388         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7389         declaration.
7390         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7391         * coffread.c (coff_symtab_read): Remove declaration.
7392         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7393         compunit_filetabs.
7394
7395 2019-01-09  Tom Tromey  <tom@tromey.com>
7396
7397         * symtab.c (lookup_objfile_from_block)
7398         (find_pc_sect_compunit_symtab, search_symbols)
7399         (default_collect_symbol_completion_matches_break_on): Use
7400         objfile_compunits.
7401         * objfiles.h (ALL_COMPUNITS): Remove.
7402         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7403         * cp-support.c (add_symbol_overload_list_qualified): Use
7404         objfile_compunits.
7405         * ada-lang.c (ada_collect_symbol_completion_matches)
7406         (ada_add_global_exceptions): Use objfile_compunits.
7407
7408 2019-01-09  Tom Tromey  <tom@tromey.com>
7409
7410         * source.c (select_source_symtab)
7411         (forget_cached_source_info_for_objfile): Remove declaration.
7412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7413         declaration.
7414         * maint.c (count_symtabs_and_blocks): Remove declaration.
7415         * cp-support.c (add_symbol_overload_list_qualified): Remove
7416         declaration.
7417         * coffread.c (coff_symtab_read): Remove declaration.
7418         * symtab.c (lookup_symbol_in_objfile_symtabs)
7419         (basic_lookup_transparent_type_1): Use objfile_compunits.
7420         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7421         (info_sources_command, search_symbols)
7422         (default_collect_symbol_completion_matches_break_on)
7423         (make_source_files_completion_list): Remove declaration.
7424         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7425         (ada_collect_symbol_completion_matches)
7426         (ada_add_global_exceptions): Remove declaration.
7427         * linespec.c (iterate_over_all_matching_symtabs): Use
7428         objfile_compunits.
7429         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7430         (class objfile_compunits): New.
7431         (ALL_COMPUNITS): Use objfile_compunits.
7432         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7433         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7434         objfile_compunits.
7435         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7436
7437 2019-01-09  Tom Tromey  <tom@tromey.com>
7438
7439         * symtab.c (search_symbols)
7440         (default_collect_symbol_completion_matches_break_on): Use
7441         objfile_msymbols.
7442         * ada-lang.c (ada_lookup_simple_minsym)
7443         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7444         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7445         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7446         objfile_msymbols.
7447         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7448         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7449         * objc-lang.c (find_methods): Use objfile_msymbols.
7450         (info_selectors_command, info_classes_command): Likewise.
7451         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7452         * objfiles.h (class objfile_msymbols): New.
7453         (ALL_OBJFILE_MSYMBOLS): Remove.
7454         (ALL_MSYMBOLS): Remove.
7455
7456 2019-01-09  Tom Tromey  <tom@tromey.com>
7457
7458         * common/next-iterator.h (next_adapter): Add Iterator template
7459         parameter.
7460         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7461         (class all_objfiles_safe): New.
7462         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7463         * objfiles.c (put_objfile_before): Update comment.
7464         (add_separate_debug_objfile): Likewise.
7465         (free_all_objfiles): Use all_objfiles_safe.
7466         (objfile_purge_solibs): Likewise.
7467
7468 2019-01-09  Tom Tromey  <tom@tromey.com>
7469
7470         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7471         (expand_symtab_containing_pc, lookup_static_symbol)
7472         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7473         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7474         all_objfiles.
7475         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7476         * breakpoint.c (create_overlay_event_breakpoint)
7477         (create_longjmp_master_breakpoint)
7478         (create_std_terminate_master_breakpoint)
7479         (create_exception_master_breakpoint): Use all_objfiles.
7480         * linux-thread-db.c (try_thread_db_load_from_pdir)
7481         (has_libpthread): Use all_objfiles.
7482         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7483         * linespec.c (iterate_over_all_matching_symtabs)
7484         (search_minsyms_for_name): Use all_objfiles.
7485         * maint.c (maintenance_info_sections): Use all_objfiles.
7486         * main.c (captured_main_1): Use all_objfiles.
7487         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7488         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7489         * guile/scm-pretty-print.c
7490         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7491         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7492         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7493         (maintenance_print_msymbols): Use all_objfiles.
7494         * source.c (select_source_symtab): Use all_objfiles.
7495         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7496         * symfile.c (remove_symbol_file_command)
7497         (expand_symtabs_matching, map_symbol_filenames): Use
7498         all_objfiles.
7499         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7500         all_objfiles.
7501         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7502         * objc-lang.c (find_methods): Use all_objfiles.
7503         * objfiles.c (have_partial_symbols, have_full_symbols)
7504         (have_minimal_symbols, qsort_cmp)
7505         (default_iterate_over_objfiles_in_search_order): Use
7506         all_objfiles.
7507         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7508         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7509         (maintenance_check_psymtabs): Use all_objfiles.
7510         (ALL_PSYMTABS): Remove.
7511         * compile/compile-object-run.c (do_module_cleanup): Use
7512         all_objfiles.
7513         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7514         * cp-support.c (add_symbol_overload_list_qualified): Use
7515         all_objfiles.
7516         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7517         Use all_objfiles.
7518         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7519         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7520         all_objfiles.
7521         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7522         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7523         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7524         Uses all_objfiles.
7525         * solib.c (solib_read_symbols): Use all_objfiles
7526
7527 2019-01-09  Tom Tromey  <tom@tromey.com>
7528
7529         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7530         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7531         all_objfiles.
7532         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7533         * symmisc.c (print_symbol_bcache_statistics)
7534         (print_objfile_statistics, maintenance_print_objfiles)
7535         (maintenance_info_symtabs, maintenance_check_symtabs)
7536         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7537         all_objfiles.
7538         * source.c (forget_cached_source_info): Use all_objfiles.
7539         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7540         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7541         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7542         * objfiles.c (update_section_map): Use all_objfiles.
7543         (shared_objfile_contains_address_p): Likewise.
7544         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7545         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7546
7547 2019-01-09  Tom Tromey  <tom@tromey.com>
7548
7549         * common/next-iterator.h: New file.
7550         * objfiles.h (class all_objfiles): New.
7551         (struct objfile_iterator): New.
7552
7553 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7554
7555         * NEWS: Move the description of the changed "frame", "select-frame",
7556          and "info frame" commands to the Changed commands section.
7557
7558 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7559
7560         * gdbtypes.c (check_stub_method_group): Remove handling of old
7561         mangling schemes.
7562         * linespec.c (find_methods): Likewise.
7563         * stabsread.c (read_member_functions): Likewise.
7564         * valops.c (search_struct_method): Likewise.
7565         (value_struct_elt_for_reference): Likewise.
7566         * NEWS: Mention this change.
7567
7568 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7569
7570         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7571         print_source_lines.
7572         * source.c (print_source_lines_base): Update line number check.
7573         (print_source_lines): New function.
7574         (source_lines_range::source_lines_range): New function.
7575         * source.h (class source_lines_range): New class.
7576         (print_source_lines): New declaration.
7577
7578 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7579
7580         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7581
7582 2019-01-08  Tom Tromey  <tom@tromey.com>
7583             Simon Marchi  <simon.marchi@ericsson.com>
7584
7585         PR gdb/24060
7586         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7587         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7588         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7589         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7590         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7591         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7592
7593 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7594
7595         * source.c (select_source_symtab): Move header comment to
7596         declaration in source.h.
7597         (forget_cached_source_info_for_objfile): Likewise.
7598         (forget_cached_source_info): Likewise.
7599         (identify_source_line): Likewise.
7600         * source.h (identify_source_line): Move declaration from symtab.h
7601         and add comment from source.c
7602         (print_source_lines): Likewise.
7603         (forget_cached_source_info_for_objfile): Likewise.
7604         (forget_cached_source_info): Likewise.
7605         (select_source_symtab): Likewise.
7606         (enum print_source_lines_flag): Move definition from symtab.h.
7607         * symtab.h (identify_source_line): Move declaration to source.h.
7608         (print_source_lines): Likewise.
7609         (forget_cached_source_info_for_objfile): Likewise.
7610         (forget_cached_source_info): Likewise.
7611         (select_source_symtab): Likewise.
7612         (enum print_source_lines_flag): Move definition to source.h.
7613         * tui/tui-hooks.c: Add 'source.h' include.
7614
7615 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * source.c (print_source_lines_base): Handle requests to print
7618         reverse line number sequences, and guard against empty lines
7619         string.
7620
7621 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7622
7623         * source.c (print_source_lines_base): Fix skip of '\r' if next
7624         character is '\n'.
7625
7626 2019-01-06  Tom Tromey  <tom@tromey.com>
7627
7628         * c-exp.y (struct c_parse_state) <macro_original_text,
7629         expansion_obstack>: New member.
7630         (macro_original_text, expansion_obstack): Remove globals.
7631         (scan_macro_expansion, scanning_macro_expansion)
7632         (finished_macro_expansion): Update.
7633         (scan_macro_cleanup): Remove.
7634         (yylex, c_parse): Update.
7635
7636 2019-01-06  Tom Tromey  <tom@tromey.com>
7637
7638         * c-exp.y (struct c_parse_state) <strings>: New member.
7639         (operator_stoken): Update.
7640
7641 2019-01-06  Tom Tromey  <tom@tromey.com>
7642
7643         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7644         (union type_stack_elt) <typelist_val>: Now a pointer to
7645         std::vector.
7646         (type_stack_cleanup): Don't declare.
7647         (push_typelist): Update.
7648         * parse.c (pop_typelist): Return a std::vector.
7649         (push_typelist): Take a std::vector.
7650         (follow_types): Update.  Do not free args.
7651         (type_stack_cleanup): Remove.
7652         * c-exp.y (struct c_parse_state): New.
7653         (cpstate): New global.
7654         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7655         (nonempty_typelist): Update.
7656         (func_mod): Create a new vector.
7657         (c_parse): Create a c_parse_state.
7658         (check_parameter_typelist): Do not delete params.
7659         (function_method): Update.  Do not delete type_list.
7660
7661 2019-01-06  Tom Tromey  <tom@tromey.com>
7662
7663         PR gdb/28155:
7664         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7665         check_typedef.
7666         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7667         (print_return_value): Likewise.
7668
7669 2019-01-05  Tom Tromey  <tom@tromey.com>
7670
7671         * contrib/cleanup_check.py: Remove.
7672         * contrib/gcc-with-excheck: Remove.
7673         * contrib/exsummary.py: Remove.
7674         * contrib/excheck.py: Remove.
7675
7676 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7677
7678         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7679         NULL. Initialize tpprev to NULL instead of assigning it
7680         to NULL on the next statement.
7681         * windows-nat.c (windows_delete_thread): Remove check for
7682         main_thread_id before printing thread exit notifications.
7683         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7684         Remove thread ID check against main_thread_id.
7685         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7686         windows_delete_thread.
7687         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7688
7689 2019-01-04  Tom Tromey  <tom@tromey.com>
7690
7691         * compile/compile.c (_initialize_compile): Use upper case for
7692         metasyntactic variables.
7693         * symmisc.c (_initialize_symmisc): Use upper case for
7694         metasyntactic variables.
7695         * psymtab.c (_initialize_psymtab): Use upper case for
7696         metasyntactic variables.
7697         * demangle.c (demangle_command): Use upper case for metasyntactic
7698         variables.
7699         (_initialize_demangler): Likewise.
7700         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7701         variables.
7702
7703 2019-01-03  Tom Tromey  <tom@tromey.com>
7704
7705         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7706
7707 2019-01-03  Tom Tromey  <tom@tromey.com>
7708
7709         * python/py-symtab.c (salpy_str): Update.
7710         (struct salpy_sal_object) <symtab>: Now a PyObject.
7711         (salpy_dealloc): Update.
7712         (del_objfile_sal): Use gdbpy_ref.
7713
7714 2019-01-03  Tom Tromey  <tom@tromey.com>
7715
7716         * python/py-type.c (convert_field): Use new_reference.  Return
7717         gdbpy_ref.
7718         (make_fielditem): Return gdbpy_ref.
7719         (typy_fields): Update.
7720         (typy_getitem): Update.
7721         (field_name): Return gdbpy_ref.  Use new_reference.
7722         (typy_iterator_iternext): Update.
7723
7724 2019-01-03  Tom Tromey  <tom@tromey.com>
7725
7726         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7727
7728 2019-01-03  Tom Tromey  <tom@tromey.com>
7729
7730         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7731         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7732         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7733         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7734         (pspy_set_type_printers): Likewise.
7735         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7736         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7737         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7738         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7739         (objfpy_set_type_printers): Likewise.
7740
7741 2019-01-03  Tom Tromey  <tom@tromey.com>
7742
7743         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7744         (gdbpy_print_stack): Use gdbpy_err_fetch.
7745         * python/python-internal.h (class gdbpy_err_fetch): New class.
7746         (class gdbpy_enter) <m_error_type, m_error_value,
7747         m_error_traceback>: Remove.
7748         <m_error>: New member.
7749         (gdbpy_exception_to_string): Don't declare.
7750         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7751         * python/py-value.c (convert_value_from_python): Use
7752         gdbpy_err_fetch.
7753         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7754         gdbpy_exception_to_string.
7755         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7756         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7757         gdbpy_err_fetch.
7758
7759 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * linux-nat.c (delete_lwp_cleanup): Delete.
7762         (struct lwp_deleter): New struct.
7763         (lwp_info_up): New typedef.
7764         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7765         lwp_info_up.
7766
7767 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * linux-fork.c (class scoped_switch_fork_info): New class.
7770         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7771
7772 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7773
7774         * valops.c (find_overload_match): Remove use of null_cleanup, and
7775         calls to do_cleanups.
7776
7777 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * compile/compile-cplus-types.c
7780         (compile_cplus_instance::decl_name): Handle changes to
7781         cp_func_name.
7782         * cp-support.c (cp_func_name): Update header comment, update
7783         return type.
7784         * cp-support.h (cp_func_name): Update return type in declaration.
7785         * valops.c (find_overload_match): Move temp_func local to top
7786         level of function and change its type.  Use temp_func to hold and
7787         delete temporary string obtained from cp_func_name.
7788
7789 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7792         gdb::char_vector, remove cleanup, and update uses of `msg`.
7793
7794 2019-01-03  Jim Wilson  <jimw@sifive.com>
7795
7796         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7797
7798 2019-01-02  Tom Tromey  <tom@tromey.com>
7799
7800         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7801         (tdesc_parse_xml): Remove cleanups.
7802         * target-descriptions.h (make_cleanup_free_target_description):
7803         Don't declare.
7804         (target_desc_deleter): New struct.
7805         (target_desc_up): New typedef.
7806         * target-descriptions.c (target_desc_deleter::operator()): Rename
7807         from free_target_description.
7808         (make_cleanup_free_target_description): Remove.
7809
7810 2019-01-02  Tom Tromey  <tom@tromey.com>
7811
7812         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7813         constructor, destructor.
7814         (linespec_parser): Remove typedef.
7815         (~linespec_parser): Rename from linespec_parser_delete.
7816         (linespec_lex_to_end, linespec_complete_label)
7817         (linespec_complete): Update.
7818         (decode_line_full): Remove cleanups.
7819         (decode_line_1): Update.
7820
7821 2019-01-02  Tom Tromey  <tom@tromey.com>
7822
7823         * python/python-internal.h (inferior_to_inferior_object): Change
7824         return type.
7825         * python/py-exitedevent.c (create_exited_event_object): Update.
7826         * python/py-inferior.c (inferior_to_inferior_object): Return
7827         gdbpy_ref.
7828         (python_new_inferior, python_inferior_deleted)
7829         (thread_to_thread_object, delete_thread_object)
7830         (build_inferior_list, gdbpy_selected_inferior): Update.
7831         * python/py-infthread.c (create_thread_object): Update.  Also fail
7832         if inferior_to_inferior_object fails.
7833
7834 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7835
7836         * inferior.h (class inferior) <displaced_step_state>: New field.
7837         * infrun.h (struct displaced_step_state): Move here from
7838         infrun.c.  Initialize fields, add constructor.
7839         <inf>: Remove field.
7840         <reset>: New method.
7841         * infrun.c (struct displaced_step_inferior_state): Move to
7842         infrun.h.
7843         (displaced_step_inferior_states): Remove.
7844         (get_displaced_stepping_state): Adust.
7845         (displaced_step_in_progress_any_inferior): Adjust.
7846         (displaced_step_in_progress_thread): Adjust.
7847         (displaced_step_in_progress): Adjust.
7848         (add_displaced_stepping_state): Remove.
7849         (get_displaced_step_closure_by_addr): Adjust.
7850         (remove_displaced_stepping_state): Remove.
7851         (infrun_inferior_exit): Call displaced_step_state.reset.
7852         (use_displaced_stepping): Don't check for NULL.
7853         (displaced_step_prepare_throw): Call
7854         get_displaced_stepping_state.
7855         (displaced_step_fixup): Don't check for NULL.
7856         (prepare_for_detach): Don't check for NULL.
7857
7858 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7859
7860         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7861          in case of call that did not complete.
7862
7863 2019-01-02  Andrey Utkin  <autkin@undo.io>
7864
7865         * symfile.c (find_separate_debug_file): Fix search of debug files for
7866         remote debuggee.
7867
7868 2019-01-02  Tom Tromey  <tom@tromey.com>
7869
7870         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7871         indentation.
7872         * python/py-frame.c (frapy_older): Remove cast.
7873         (frapy_newer): Likewise.
7874         * python/py-breakpoint.c (local_setattro): Remove cast.
7875         * python/py-arch.c (archpy_name): Remove local variable.
7876         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7877
7878 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7879
7880         * unittests/basic_string_view/element_access/char/empty.cc:
7881         Fix year range in copyright header.
7882
7883 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7884
7885         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7886         Delete.
7887         <operator==>: Update with for removed field.
7888         <hash>: Likewise.
7889         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7890         <isa_features>: ...this.
7891         <abi_features>: New field.
7892         (riscv_isa_flen): Update comment.
7893         (riscv_abi_xlen): New declaration.
7894         (riscv_abi_flen): New declaration.
7895         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7896         isa_features.
7897         (riscv_abi_xlen): New function.
7898         (riscv_isa_flen): Update to get answer from isa_features.
7899         (riscv_abi_flen): New function.
7900         (riscv_has_fp_abi): Update to get answer from abi_features.
7901         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7902         xlen and flen.
7903         (riscv_call_info) <xlen, flen>: Update comment.
7904         (riscv_call_arg_struct): Remove invalid assertions
7905         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7906         is removed.
7907         (riscv_gdbarch_init): Gather isa features and abi features
7908         separately, ensure both match on the gdbarch when reusing an old
7909         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7910         a target with 64-bit float hardware.
7911
7912 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7913
7914         * source.c (search_command_helper): Stop reverse search
7915         when line 1 has been searched.
7916
7917 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7918
7919         * record-full.c (record_full_base_target::close): Rewrite
7920         record_full_core_buf_list free logic.
7921
7922 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7923
7924         * break-catch-syscall.c (print_one_catch_syscall): xfree
7925         the last text.
7926
7927 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7928
7929         * top.c (print_gdb_version): Update Copyright year in version
7930         message.
7931
7932 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7933
7934         Update copyright year range in all GDB files.
7935
7936 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7937
7938         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7939
7940 For older changes see ChangeLog-2018.
7941 \f
7942 Local Variables:
7943 mode: change-log
7944 left-margin: 8
7945 fill-column: 74
7946 version-control: never
7947 coding: utf-8
7948 End:
7949