gdb/ChangeLog

   1 2020-10-22  Hannes Domani  <ssbssa@yahoo.de>
   2
   3         * gdbtypes.c (init_complex_type): Check target type name.
   4
   5 2020-10-22  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         PR gdb/26693
   8         * dwarf2/read.c (load_full_comp_unit): Add existing_cu
   9         parameter.
  10         (load_cu): Pass existing CU.
  11         (process_imported_unit_die): Likewise.
  12         (follow_die_offset): Likewise.
  13
  14 2020-10-14  Mihails Strasuns  <mihails.strasuns@intel.com>
  15
  16         * breakpoint.c (handle_jit_event): Add an argument, change how
  17         `jit_event_handler` is called.
  18
  19 2020-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         PR gdb/26642
  22         * infrun.c (do_target_wait_1): Clear TARGET_WNOHANG if the
  23         target can't do async.
  24         * target.c (target_wait): Assert that we don't pass
  25         TARGET_WNOHANG to a target that can't async.
  26
  27 2020-10-08  Shahab Vahedi  <shahab@synopsys.com>
  28
  29         * NEWS: Mention ARC support in GDBserver.
  30
  31 2020-10-07  Anton Kolesov  <anton.kolesov@synopsys.com>
  32
  33         * arc-linux-tdep.h: New file.
  34         * arc-linux-tdep.c (arc_linux_core_reg_offsets,
  35         arc_linux_supply_gregset, arc_linux_supply_v2_regset,
  36         arc_linux_collect_gregset, arc_linux_collect_v2_regset,
  37         arc_linux_gregset, arc_linux_v2_regset,
  38         arc_linux_iterate_over_regset_sections,
  39         arc_linux_core_read_description): Implement.
  40         (arc_linux_init_osabi): Set iterate_over_regset_sections.
  41         * arc-tdep.h (ARC_OFFSET_NO_REGISTER): Declare.
  42         (arc_gdbarch_features_create): Add.
  43         * arc-tdep.c (arc_gdbarch_features_create): Not static anymore.
  44
  45 2020-10-07  Shahab Vahedi  <shahab@synopsys.com>
  46
  47         * arch/arc.h: Rename "arc_gdbarch_features" to
  48         "arc_arch_features".
  49         * arc-tdep.h: Likewise.
  50         * arc-tdep.c: Likewise.
  51
  52 2020-09-28  Gareth Rees <grees@undo.io>  (tiny change)
  53
  54         PR python/26586
  55         * cli/cli-script.c (execute_control_commands): don't set
  56         instream to nullptr here as this breaks the from_tty argument
  57         to gdb.execute in Python.
  58         (execute_user_command): set instream to nullptr here instead.
  59
  60 2020-09-25  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  61
  62         * breakpoint.c (commands_command_1): Make a copy of the 'arg'
  63         argument.
  64
  65 2020-09-24  Tom Tromey  <tromey@adacore.com>
  66
  67         PR tui/26638:
  68         * tui/tui-stack.h (struct tui_locator_window) <can_focus>: New
  69         method.
  70         * tui/tui-data.h (struct tui_win_info) <can_focus>: New method.
  71         * tui/tui-data.c (tui_next_win): Exclude non-focusable windows.
  72         (tui_prev_win): Rewrite.
  73
  74 2020-09-23  Hannes Domani  <ssbssa@yahoo.de>
  75
  76         * nat/windows-nat.c (handle_exception): Handle 64bit breakpoints
  77         in WOW64 processes as SIGINT.
  78         * nat/windows-nat.h: Make wow64_process a shared variable.
  79         * windows-nat.c: Remove static wow64_process variable.
  80
  81 2020-09-18  Victor Collod  <vcollod@nvidia.com>
  82
  83         PR gdb/26635
  84         * i386-tdep.c (i386_skip_endbr): Add a helper function to skip endbr.
  85         (i386_analyze_prologue): Call i386_skip_endbr.
  86
  87 2020-09-18  Pedro Alves  <pedro@palves.net>
  88
  89         PR gdb/26631
  90         * thread.c (thread_find_command): Switch inferior before calling
  91         target methods.
  92
  93 2020-09-16  Tom Tromey  <tromey@adacore.com>
  94
  95         PR gdb/26598:
  96         * infrun.c (fill_in_stop_func): Use find_pc_partial_function_sym.
  97
  98 2020-09-14  Fredrik Hederstierna  <fredrik.hederstierna@verisure.com>
  99             Adam Renquinha <arenquinha@cimeq.qc.ca>
 100
 101         * arm-tdep.c (arm_m_exception_cache): Try use correct stack
 102         pointer and stack frame offset when unwinding.
 103
 104 2020-09-13  Joel Brobecker  <brobecker@adacore.com>
 105
 106         * version.in: Set GDB version number to 10.0.90.DATE-git.
 107
 108 2020-09-13  Joel Brobecker  <brobecker@adacore.com>
 109
 110         GDB 10.0.90 released.
 111
 112 2020-09-13  Joel Brobecker  <brobecker@adacore.com>
 113
 114         * version.in: Set GDB version number to 10.0.90.
 115
 116 2020-09-13  Joel Brobecker  <brobecker@adacore.com>
 117
 118         * NEWS: Change "Changes since GDB 9" to "Changes in GDB 10".
 119
 120 2020-09-13  Joel Brobecker  <brobecker@adacore.com>
 121
 122         GDB 10 branch created (8087c3fa8b5d695e3e29e69d70d0b35ec902ac59):
 123         * version.in: Bump version to 10.0.90.DATE-git.
 124
 125 2020-09-12  Joel Brobecker  <brobecker@adacore.com>
 126
 127         * infrun.c (namespace selftests): Only define #if GDB_SELF_TEST.
 128
 129 2020-09-11  Moritz Riesterer  <moritz.riesterer@intel.com>
 130             Felix Willgerodt  <Felix.Willgerodt@intel.com>
 131
 132         * gdbarch.sh: Added bfloat16 type.
 133         * gdbarch.c: Regenerated.
 134         * gdbarch.h: Regenerated.
 135         * gdbtypes.c (floatformats_bfloat16): New struct.
 136         (gdbtypes_post_init): Add builtin_bfloat16.
 137         * gdbtypes.h (struct builtin_type) <builtin_bfloat16>: New member.
 138         (floatformats_bfloat16): New struct.
 139         * i386-tdep.c (i386_zmm_type): Add field "v32_bfloat16"
 140         (i386_ymm_type): Add field "v16_bfloat16"
 141         (i386_gdbarch_init): Add set_gdbarch_bfloat16_format.
 142         * target-descriptions.c (make_gdb_type): Add case TDESC_TYPE_BFLOAT16.
 143         * gdbsupport/tdesc.cc (tdesc_predefined_types): New member bfloat16.
 144         * gdbsupport/tdesc.h (tdesc_type_kind): New member TDESC_TYPE_BFLOAT16.
 145         * features/i386/64bit-avx512.xml: Add bfloat16 type.
 146         * features/i386/64bit-avx512.c: Regenerated.
 147         * features/i386/64bit-sse.xml: Add bfloat16 type.
 148         * features/i386/64bit-sse.c: Regenerated.
 149
 150 2020-09-11  Felix Willgerodt  <felix.willgerodt@intel.com>
 151
 152         * i386-tdep.c (i386_zmm_type): Fix field names.
 153         (i386_ymm_type): Fix field names.
 154
 155 2020-09-11  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 156
 157         * breakpoint.c: Fix typo in the help message of the
 158         "set breakpoint condition-evaluation" command.
 159
 160 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 161
 162         * nbsd-nat.c: Include "nat/netbsd-nat.h".
 163         * (nbsd_nat_target::pid_to_exec_file)
 164         (nbsd_nat_target::thread_alive, nbsd_nat_target::thread_name)
 165         (nbsd_nat_target::post_startup_inferior)
 166         (nbsd_nat_target::post_attach, nbsd_nat_target::xfer_partial)
 167         (nbsd_add_threads): Switch local code to common gdb/nat functions.
 168         * (nbsd_pid_to_cmdline): Call sysctl from the global namespace.
 169         * (nbsd_thread_lister): Remove.
 170
 171 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 172
 173         * fork-inferior.c (startup_inferior): Avoid double free.
 174
 175 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 176
 177         * netbsd-nat.h (netbsd_nat::qxfer_siginfo): Add.
 178         * netbsd-nat.c (netbsd_nat::qxfer_siginfo): Likewise.
 179
 180 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 181
 182         * netbsd-nat.h (netbsd_nat::enable_proc_events): Add.
 183         * netbsd-nat.c: Include <sys/ptrace.h>.
 184         * (netbsd_nat::enable_proc_events): Add.
 185
 186 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 187
 188         * netbsd-nat.h: Include "gdbsupport/function-view.h".
 189         * (netbsd_nat::thread_alive, netbsd_nat::thread_name)
 190         (netbsd_nat::for_each_thread): Add.
 191         * netbsd-nat.c: Include "gdbsupport/common-defs.h" and
 192         "gdbsupport/common-debug.h".
 193         * (netbsd_nat::netbsd_thread_lister)
 194         (netbsd_nat::thread_alive, netbsd_nat::thread_name)
 195         (netbsd_nat::for_each_thread): Add.
 196
 197 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 198
 199         * netbsd-nat.h: Include <unistd.h>.
 200         * (netbsd_nat::pid_to_exec_file): Add.
 201         * netbsd-nat.c: Include <sys/types.h> and <sys/sysctl.h>.
 202         * (netbsd_nat::pid_to_exec_file) Add.
 203
 204 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 205
 206         * configure.nat (NATDEPFILES): Add nat/netbsd-nat.o when needed.
 207
 208 2020-09-10  Kamil Rytarowski  <n54@gmx.com>
 209
 210         * netbsd-nat.h: New file.
 211         * netbsd-nat.c: Likewise.
 212
 213 2020-09-09  Tom Tromey  <tromey@adacore.com>
 214
 215         * ada-lang.c (remove_extra_symbols): Do not increment when
 216         removing an element
 217
 218 2020-09-08  Tom Tromey  <tromey@adacore.com>
 219
 220         * gdb_bfd.c (gdb_bfd_open): Call bfd_fopen when fstat fails.
 221
 222 2020-09-08  Tom Tromey  <tromey@adacore.com>
 223
 224         PR win32/25302:
 225         * gdb_bfd.c (gdb_bfd_data): Add "st" parameter.
 226         (gdb_bfd_init_data): New function.
 227         (gdb_bfd_open, gdb_bfd_ref): Use gdb_bfd_init_data.
 228
 229 2020-09-07  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 230
 231         * infrun.c (fetch_inferior_event): Use
 232         `switch_to_target_no_thread` to switch the target.
 233
 234 2020-09-06  Tom Tromey  <tom@tromey.com>
 235
 236         * symfile.h (dwarf2_free_objfile): Don't declare.
 237
 238 2020-09-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 239
 240         * gdb/i386-tdep.c (i386_floatformat_for_type): Added conditions
 241         to match 16 byte real/complex type generated by Flang compiler.
 242
 243 2020-09-03  Tom de Vries  <tdevries@suse.de>
 244
 245         PR breakpoint/26546
 246         * dwarf2/read.c (new_symbol): Tag label symbol without DW_AT_low_pc as
 247         LOC_OPTIMIZED_OUT instead of LOC_LABEL.
 248
 249 2020-09-02  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * maint.c (index_digits): New function.
 252         (struct maint_print_section_data): Remove.
 253         (print_bfd_section_info): Remove print_data parameter, add arg
 254         and index_digits.
 255         (print_objfile_section_info): Likewise.
 256         (print_bfd_section_info_maybe_relocated): Likewise (plus
 257         objfile).
 258         (maintenance_info_sections): Adjust calls.
 259
 260 2020-09-02  Tom Tromey  <tromey@adacore.com>
 261
 262         * ada-varobj.c (ada_varobj_get_ptr_number_of_children): Return 0
 263         for null pointers.
 264         (ada_varobj_adjust_for_child_access): Special-case null pointers.
 265
 266 2020-09-01  Simon Marchi  <simon.marchi@polymtl.ca>
 267
 268         * bcache.h (struct bcache) <insert>: Change type of `added` to
 269         pointer to bool.
 270         * bcache.c (bcache::insert): Likewise.
 271         * gdbtypes.c (check_types_worklist): Adjust.
 272         * psymtab.c (add_psymbol_to_bcache): Adjust.
 273
 274 2020-08-31  Kevin Buettner  <kevinb@redhat.com>
 275
 276         * corelow.c (unordered_set): Include.
 277         (class core_target): Add field 'm_core_unavailable_mappings'.
 278         (core_target::build_file_mappings): Print only one warning
 279         per inaccessible file.  Add unavailable/broken mappings
 280         to m_core_unavailable_mappings.
 281         (core_target::xfer_partial): Call...
 282         (core_target::xfer_memory_via_mappings): New method.
 283
 284 2020-08-31  Simon Marchi  <simon.marchi@polymtl.ca>
 285
 286         * dwarf2/read.c (struct field_info) <non_public_fields>: Change
 287         type to bool.
 288
 289 2020-08-31  Simon Marchi  <simon.marchi@polymtl.ca>
 290
 291         * dwarf2/read.c (struct field_info): Fix indentation.
 292
 293 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
 294
 295         * frame-unwind.h (frame_prev_register_ftype): Fix adjective
 296         ordering in comment.
 297         * frame.c (frame_id_eq): Fix indentation.
 298
 299 2020-08-31  Scott Linder  <scott@scottlinder.com>
 300             Simon Marchi  <simon.marchi@efficios.com>
 301
 302         * inline-frame.c (inline_frame_this_id): Remove assert that prevents
 303         inline frame ids in outer frame.
 304
 305 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
 306
 307         * frame.h (enum frame_id_stack_status) <FID_STACK_OUTER>: New.
 308         * frame.c (fprint_frame_id): Handle FID_STACK_OUTER.
 309         (outer_frame_id): Use FID_STACK_OUTER instead of
 310         FID_STACK_INVALID.
 311         (frame_id_p): Don't check for outer_frame_id.
 312
 313 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
 314
 315         * frame-unwind.c (frame_unwind_got_optimized): Don't set
 316         regnum/frame in value.  Call allocate_value_lazy.
 317         * frame.c (frame_unwind_register_value): Use
 318         val_print_not_saved.
 319
 320 2020-08-31  Simon Marchi  <simon.marchi@efficios.com>
 321
 322         * gdbtypes.h (NULL_TYPE): Remove, change all uses to nullptr.
 323
 324 2020-08-29  Pedro Alves  <pedro@palves.net>
 325
 326         * progspace.c (print_program_space): Use all_inferiors.  Switch to
 327         the inferior before calling target_pid_to_str.
 328
 329 2020-08-28  Tom Tromey  <tom@tromey.com>
 330
 331         * xcoffread.c (xcoff_end_psymtab): Update comment.
 332         * dbxread.c (dbx_end_psymtab): Update comment.
 333
 334 2020-08-28  Tom de Vries  <tdevries@suse.de>
 335
 336         PR breakpoint/26544
 337         * breakpoint.c (parse_breakpoint_sals): Remove const from struct
 338         event_location.
 339         (create_breakpoint): Same.
 340         (base_breakpoint_decode_location): Same.
 341         (bkpt_create_sals_from_location): Same.
 342         (bkpt_decode_location): Same.
 343         (bkpt_probe_create_sals_from_location): Same.
 344         (bkpt_probe_decode_location): Same.
 345         (tracepoint_create_sals_from_location): Same.
 346         (tracepoint_decode_location): Same.
 347         (tracepoint_probe_decode_location): Same.
 348         (strace_marker_create_sals_from_location): Same.
 349         (strace_marker_decode_location): Same.
 350         (create_sals_from_location_default): Same.
 351         (decode_location_default): Same.
 352         * breakpoint.h (struct breakpoint_ops): Same.
 353         (create_breakpoint): Same.
 354         * linespec.h (decode_line_full): Same.
 355         * linespec.c (decode_line_full): Same.  Throw error if
 356         result.size () == 0.
 357
 358 2020-08-27  Pedro Alves  <pedro@palves.net>
 359
 360         PR gdb/26524
 361         * breakpoint.c (until_break_fsm) <location_breakpoint,
 362         caller_breakpoint>: Delete fields.
 363         <breakpoints>: New field.
 364         <until_break_fsm>: Adjust to save a breakpoint vector instead of
 365         two individual breakpoints.
 366         (until_break_fsm::should_stop): Loop over breakpoints in the
 367         breakpoint vector.
 368         (until_break_fsm::clean_up): Adjust to clear the breakpoints
 369         vector.
 370         (until_break_command): Handle location expanding into multiple
 371         sals.
 372
 373 2020-08-27  Pedro Alves  <pedro@palves.net>
 374
 375         PR gdb/26523
 376         * inline-frame.c (stopped_by_user_bp_inline_frame): Also consider
 377         bp_until breakpoints user-specified locations.  Update intro
 378         comment.
 379
 380 2020-08-27  Simon Marchi  <simon.marchi@polymtl.ca>
 381
 382         * gdb_bfd.h (gdb_bfd_section_iterator, gdb_bfd_section_range,
 383         gdb_bfd_sections): New.
 384         * maint.c (print_bfd_section_info): Change param type to
 385         maint_print_section_data.
 386         (print_objfile_section_info): Likewise.
 387         (print_bfd_section_info_maybe_relocated): Likewise.
 388         (maintenance_info_sections): Use gdb_bfd_sections.
 389
 390 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 391
 392         * MAINTAINERS: Add ARC target and maintainer.
 393
 394 2020-08-25  Anton Kolesov  <anton.kolesov@synopsys.com>
 395
 396         * configure.tgt: ARC support for GNU/Linux.
 397         * Makefile.in (ALL_TARGET_OBJS): Likewise.
 398         * arc-linux-tdep.c: New file.
 399         * arc-tdep.h (ARC_STATUS32_L_MASK, ARC_STATUS32_DE_MASK): Declare.
 400         * arc-tdep.c (arc_write_pc): Use it.
 401
 402 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 403
 404         * arc-tdep.c (arc_check_for_hardware_loop): New.
 405         * arc-tdep.h (gdbarch_tdep): New field has_hw_loops.
 406
 407 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 408
 409         * arc-tdep.h: Include "gdbarch.h".
 410
 411 2020-08-25  Shahab Vahedi  <shahab@synopsys.com>
 412
 413         * arch/arc.h
 414         (arc_gdbarch_features): New class to stir the selection of target XML.
 415         (arc_create_target_description): Use FEATURES to choose XML target.
 416         (arc_lookup_target_description): Use arc_create_target_description
 417         to create _new_ target descriptions or return the already created
 418         ones if the FEATURES is the same.
 419         * arch/arc.c: Implementation of prototypes described above.
 420         * gdb/arc-tdep.h (arc_regnum enum): Add more registers.
 421         (arc_gdbarch_features_init): Initialize the FEATURES struct.
 422         * arc-tdep.c (*_feature_name): Make feature names consistent.
 423         (arc_register_feature): A new struct to hold information about
 424         registers of a particular target/feature.
 425         (arc_check_tdesc_feature): Check if XML provides registers in
 426         compliance with ARC_REGISTER_FEATURE structs.
 427         (arc_update_acc_reg_names): Add aliases for r58 and r59.
 428         (determine_*_reg_feature_set): Which feature name to look for.
 429         (arc_gdbarch_features_init): Given MACH and ABFD, initialize FEATURES.
 430         (mach_type_to_arc_isa): Convert from a set of binutils machine types
 431         to expected ISA enums to be used in arc_gdbarch_features structs.
 432         * features/Makefile (FEATURE_XMLFILES): Add new files.
 433         * gdb/features/arc/v1-aux.c: New file.
 434         * gdb/features/arc/v1-aux.xml: Likewise.
 435         * gdb/features/arc/v1-core.c: Likewise.
 436         * gdb/features/arc/v1-core.xml: Likewise.
 437         * gdb/features/arc/v2-aux.c: Likewise.
 438         * gdb/features/arc/v2-aux.xml: Likewise.
 439         * gdb/features/arc/v2-core.c: Likewise.
 440         * gdb/features/arc/v2-core.xml: Likewise.
 441         * NEWS (Changes since GDB 9): Announce obsolence of old feature names.
 442
 443 2020-08-25  Gaius Mulley  <gaiusmod2@gmail.com>
 444             Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         PR m2/26372
 447         * m2-exp.y (exp): Improve comment for non_empty_arglist case, add
 448         an assert.  Remove single element array indexing pattern as the
 449         MULTI_SUBSCRIPT support will handle this case too.
 450
 451 2020-08-24  Simon Marchi  <simon.marchi@polymtl.ca>
 452
 453         * value.h (valprint_check_validity): Move declaration from
 454         here...
 455         * valprint.h (valprint_check_validity): ... to here.
 456
 457 2020-08-24  Simon Marchi  <simon.marchi@efficios.com>
 458
 459         * debug.h: New file.
 460         * debug.c (debug_prefixed_vprintf): New function.
 461         * infrun.c (infrun_debug_printf_1): Use debug_prefixed_vprintf.
 462         * linux-nat.c (linux_nat_debug_printf_1): Likewise.
 463
 464 2020-08-24  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * infrun.h (infrun_debug_printf_1): New function declaration.
 467         (infrun_debug_printf): New macro.
 468         * infrun.c (infrun_debug_printf_1): Use infrun_debug_printf
 469         throughout.
 470         (infrun_debug_printf): New function.
 471         * breakpoint.c (should_be_inserted): Use infrun_debug_printf.
 472         (handle_jit_event): Likewise.
 473
 474 2020-08-21  Mark Wielaard  <mark@klomp.org>
 475
 476         * ada-lex.l: Extend register warnings diagnostics comment for g++.
 477
 478 2020-08-22  Simon Marchi  <simon.marchi@efficios.com>
 479
 480         * frame.c (enum class frame_id_status): New.
 481         (struct frame_info) <this_id::p>: Change type to frame_id_status.
 482         (fprintf_frame): Update.
 483         (compute_frame_id): Set frame id status to "computing" on entry.
 484         Set it back to "not_computed" on failure and to "computed" on
 485         success.
 486         (get_frame_id): Assert the frame id is not being computed.
 487         (create_sentinel_frame): Use frame_id_status::COMPUTED.
 488         (create_new_frame): Likewise.
 489         (frame_cleanup_after_sniffer): Update assert.
 490
 491 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 492
 493         * regcache.c (pid_ptid_regcache_map): New type.
 494         (target_ptid_regcache_map): Remove.
 495         (target_pid_ptid_regcache_map): New type.
 496         (regcaches): Change type to target_pid_ptid_regcache_map.
 497         (get_thread_arch_aspace_regcache): Update.
 498         (regcache_thread_ptid_changed): Update, handle pid-like ptid
 499         case.
 500         (regcaches_size): Update.
 501         (regcache_count): Update.
 502         (registers_changed_ptid_target_pid_test): New.
 503         (_initialize_regcache): Register new test.
 504
 505 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 506
 507         * regcache.c (regcache_count): New.
 508         (struct regcache_test_data): New.
 509         (regcache_test_data_up): New.
 510         (populate_regcaches_for_test): New.
 511         (regcaches_test): Remove.
 512         (get_thread_arch_aspace_regcache_test): New.
 513         (registers_changed_ptid_all_test): New.
 514         (registers_changed_ptid_target_test): New.
 515         (registers_changed_ptid_target_ptid_test): New.
 516         (regcache_thread_ptid_changed): Remove regcache_count lambda.
 517         (_initialize_regcache): Register new tests.
 518
 519 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 520
 521         * regcache.c (test_get_thread_arch_aspace_regcache): Rename to...
 522         (get_thread_arch_aspace_regcache_and_check): ... this.  Remove
 523         gdbarch and aspace parameter.  Use current inferior's aspace.
 524         Validate regcache's arch value.
 525         (regcaches_test): Update.
 526
 527 2020-08-20  Simon Marchi  <simon.marchi@polymtl.ca>
 528
 529         * regcache.c (regcaches_test): Call registers_changed.
 530
 531 2020-08-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 532
 533         * infrun.c (process_event_stop_test): Fix typo "breapoint".
 534
 535 2020-08-19  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 536
 537         * amd64-tdep.c (amd64_skip_prologue): Using symbol table
 538         to find the end of prologue for flang compiled binaries.
 539         * arm-tdep.c (arm_skip_prologue): Likewise.
 540         * i386-tdep.c (i386_skip_prologue): Likewise.
 541         * producer.c (producer_is_llvm): New function.
 542         (producer_parsing_tests): Added new tests for clang/flang.
 543         * producer.h (producer_is_llvm): New declaration.
 544
 545 2020-08-18  Simon Marchi  <simon.marchi@efficios.com>
 546
 547         * linux-nat.c (linux_nat_debug_printf): New function.
 548         (linux_nat_debug_printf_1): New macro.  Use throughout the file.
 549
 550 2020-08-18  Aaron Merey  <amerey@redhat.com>
 551
 552         * Makefile.in (DEBUGINFOD_CFLAGS, DEBUGINFOD_LIBS): New variables.
 553         (INTERNAL_CFLAGS_BASE): Add DEBUGINFOD_CFLAGS.
 554         (CLIBS): Add DEBUGINFOD_LIBS.
 555
 556 2020-08-17  Sergei Trofimovich  <siarheit@google.com>
 557
 558         * ia64-linux-nat.c: Include "gdbarch.h" to declare used
 559         'gdbarch_num_regs'.
 560
 561 2020-08-17  Tom Tromey  <tromey@adacore.com>
 562
 563         * ada-varobj.c (ada_varobj_decode_var): Handle case where
 564         ada_get_decoded_value returns NULL.
 565
 566 2020-08-17  Tom Tromey  <tromey@adacore.com>
 567
 568         * python/py-inferior.c (infpy_search_memory): Use
 569         gdb_py_object_from_ulongest.
 570         * python/py-infevents.c (create_inferior_call_event_object)
 571         (create_memory_changed_event_object): Use
 572         gdb_py_object_from_ulongest.
 573         * python/py-linetable.c (ltpy_entry_get_pc): Use
 574         gdb_py_object_from_ulongest.
 575
 576 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
 577
 578         * loc.c (class symbol_needs_eval_context): Fix indentation.
 579
 580 2020-08-17  Simon Marchi  <simon.marchi@polymtl.ca>
 581
 582         * dwarf2/loc.c (dwarf2_loc_desc_get_symbol_read_needs): Use
 583         bool.
 584
 585 2020-08-17  Tom de Vries  <tdevries@suse.de>
 586
 587         PR gdb/26393
 588         * gdbtypes.c (dump_dynamic_prop): New function.
 589         (recursive_dump_type): Use dump_dynamic_prop for TYPE_CODE_RANGE.
 590
 591 2020-08-15  Tom de Vries  <tdevries@suse.de>
 592
 593         PR backtrace/26390
 594         * stack.c (print_frame_args): Temporarily set the selected
 595         frame to FRAME while printing the frame's arguments.
 596
 597 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 598
 599         PR breakpoints/26385
 600         * ppc-linux-nat.c (ppc_linux_nat_target::low_prepare_to_resume):
 601         Always clear watchpoint with PTRACE_SET_DEBUGREG.
 602
 603 2020-08-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 604
 605         * ppc-linux-nat.c (ppc_linux_dreg_interface::detect)
 606         (ppc_linux_nat_target::low_prepare_to_resume): Use ptrace () < 0
 607         and >= to check return value instead of == -1 and != -1.
 608
 609 2020-08-14  Simon Marchi  <simon.marchi@polymtl.ca>
 610
 611         * utils.h (class gdb_argv) <as_array_view>: New method.
 612         * utils.c (gdb_argv_as_array_view_test): New.
 613         (_initialize_utils): Register selftest.
 614         * maint.c (maintenance_selftest): Use the new method.
 615
 616 2020-08-13  Kamil Rytarowski  <n54@gmx.com>
 617
 618         * target.h (supports_dumpcore, dumpcore): New
 619         function declarations.
 620         * target.c (supports_dumpcore, dumpcore): New
 621         functions.
 622         * target-delegates.c: Rebuild.
 623         * gcore.c (gcore_command): Use target_supports_dumpcore ()
 624         and target_dumpcore ().
 625
 626 2020-08-13  Aaron Merey  <amerey@redhat.com>
 627
 628         * debuginfod-support.c: Replace global variables with user_data.
 629
 630 2020-08-13  Simon Marchi  <simon.marchi@polymtl.ca>
 631
 632         * maint.c (maintenance_selftest): Split args and pass array_view
 633         to run_tests.
 634
 635 2020-08-12  Luis Machado  <luis.machado@linaro.org>
 636
 637         * value.c (check_type_length_before_alloc): Use ULONGEST to store a
 638         type's length.
 639         Use %s and pulongest to print the length.
 640
 641 2020-08-12  Pedro Alves  <palves@redhat.com>
 642
 643         * NEWS: Move "Multi-target debugging support" item to the
 644         "Changes since GDB 9" section.
 645
 646 2020-08-12  Pedro Alves  <palves@redhat.com>
 647
 648         PR gdb/26336
 649         * progspace.c (program_space::remove_objfile): Invalidate the
 650         frame cache.
 651
 652 2020-08-11  Tom de Vries  <tdevries@suse.de>
 653
 654         * MAINTAINERS: Mark ms1 as deleted.
 655
 656 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 657
 658         PR gdb/26310
 659
 660         * aarch64-tdep.c (aarch64_analyze_prologue): Track use of SP/FP and
 661         act accordingly.
 662         (aarch64_analyze_prologue_test): Add more unit tests to exercise
 663         movz/str/stur/stp skipping behavior.
 664
 665 2020-08-10  Luis Machado  <luis.machado@linaro.org>
 666
 667         * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use
 668         struct user_sve_header instead of struct sve_context.
 669
 670 2020-08-09  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * read.h (dwarf2_fetch_die_loc_sect_off,
 673         dwarf2_fetch_die_loc_cu_off): Replace function pointer +
 674         `void *` parameter with function_view.
 675         * read.c (dwarf2_fetch_die_loc_sect_off,
 676         dwarf2_fetch_die_loc_cu_off): Likewise.
 677         * loc.c (get_frame_pc_for_per_cu_dwarf_call): Remove.
 678         (per_cu_dwarf_call): Adjust.
 679         (get_frame_address_in_block_wrapper): Remove.
 680         (indirect_synthetic_pointer): Adjust.
 681         (get_ax_pc): Remove.
 682         (dwarf2_compile_expr_to_ax): Adjust.
 683
 684 2020-08-08  Tom de Vries  <tdevries@suse.de>
 685
 686         PR build/26344
 687         * arch/riscv.c (riscv_lookup_target_description): Use an explicit
 688         constructor.
 689         * regcache.c (get_thread_arch_aspace_regcache): Same.
 690
 691 2020-08-07  Tom Tromey  <tromey@adacore.com>
 692
 693         * ravenscar-thread.c
 694         (ravenscar_thread_target::set_base_thread_from_ravenscar_task):
 695         New method.
 696         (ravenscar_thread_target::wait): Check
 697         runtime_initialized.
 698         (ravenscar_thread_target::prepare_to_store)
 699         (ravenscar_thread_target::stopped_by_sw_breakpoint)
 700         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 701         (ravenscar_thread_target::stopped_by_watchpoint)
 702         (ravenscar_thread_target::stopped_data_address)
 703         (ravenscar_thread_target::core_of_thread): Use
 704         scoped_restore_current_thread and
 705         set_base_thread_from_ravenscar_task.
 706
 707 2020-08-07  Tom Tromey  <tromey@adacore.com>
 708
 709         * ravenscar-thread.c (update_thread_list): Set inferior_ptid.
 710
 711 2020-08-07  Tom Tromey  <tromey@adacore.com>
 712
 713         * ravenscar-thread.c (ravenscar_thread_target::wait): Call
 714         update_inferior_ptid before update_thread_list.
 715         (temporarily_change_regcache_ptid): New class.
 716         (ravenscar_thread_target::fetch_registers)
 717         (ravenscar_thread_target::store_registers)
 718         (ravenscar_thread_target::prepare_to_store): Use base thread when
 719         forwarding operation.
 720
 721 2020-08-07  Tom Tromey  <tromey@adacore.com>
 722
 723         * ravenscar-thread.c (ravenscar_thread_target::resume): Handle
 724         "is_pid" case.
 725
 726 2020-08-07  Tom Tromey  <tromey@adacore.com>
 727
 728         * ravenscar-thread.c (xfer_partial, enable_btrace, add_thread):
 729         New methods.
 730         (ravenscar_thread_target::get_thread_base_cpu): Check m_cpu_map
 731         first.
 732         (ravenscar_thread_target::add_thread): Rename from
 733         ravenscar_add_thread.
 734         (ravenscar_thread_target::update_thread_list): Use a lambda.
 735         (ravenscar_thread_target::xfer_partial): New method.
 736
 737 2020-08-07  Tom Tromey  <tromey@adacore.com>
 738
 739         * ada-lang.h (ada_task_list_iterator_ftype): Now a
 740         gdb::function_view.
 741         (iterate_over_live_ada_tasks): Change type of argument.
 742         * ada-tasks.c (iterate_over_live_ada_tasks): Change type
 743         of argument.
 744
 745 2020-08-07  Tom Tromey  <tromey@adacore.com>
 746
 747         * ravenscar-thread.c (ravenscar_thread_target) <extra_thread_info>:
 748         Remove.
 749         (ravenscar_thread_target::extra_thread_info): Remove.
 750         (ravenscar_thread_target::pid_to_str): Mention Ravenscar in result;
 751         defer to target beneath for non-Ravenscar threads.
 752
 753 2020-08-07  Tom Tromey  <tromey@adacore.com>
 754
 755         * ravenscar-thread.c (ravenscar_thread_target) <get_base_cpu,
 756         get_base_thread_from_ravenscar_task>: Now methods.
 757         <m_cpu_map>: New member.
 758         (ravenscar_thread_target::get_thread_base_cpu): Rename from
 759         ravenscar_get_thread_base_cpu.  Check m_cpu_map.
 760         (ravenscar_thread_target::task_is_currently_active): Update.
 761         (ravenscar_thread_target::get_base_thread_from_ravenscar_task):
 762         Now a method.
 763         (ravenscar_thread_target::add_active_thread): Put initial thread
 764         into the m_cpu_map.
 765
 766 2020-08-07  Tom Tromey  <tromey@adacore.com>
 767
 768         * ravenscar-thread.c (ravenscar_thread_target::wait): Return
 769         event_ptid.
 770
 771 2020-08-07  Tom Tromey  <tromey@adacore.com>
 772
 773         * ravenscar-thread.c (ravenscar_thread_target::wait): Check
 774         runtime_initialized.
 775
 776 2020-08-07  Tom Tromey  <tromey@adacore.com>
 777
 778         * ravenscar-thread.c (ravenscar_thread_target): Don't call
 779         add_active_thread.
 780         (ravenscar_thread_target::add_active_thread): Now public.
 781         (ravenscar_inferior_created): Call add_active_thread after pushing
 782         the target.
 783
 784 2020-08-07  Simon Marchi  <simon.marchi@polymtl.ca>
 785
 786         * regcache.c (ptid_regcache_map): New type.
 787         (target_ptid_regcache_map): New type.
 788         (regcaches): Change type to target_ptid_regcache_map.
 789         (get_thread_arch_aspace_regcache): Update to regcaches' new
 790         type.
 791         (regcache_thread_ptid_changed): Likewise.
 792         (registers_changed_ptid): Likewise.
 793         (regcaches_size): Likewise.
 794         (regcaches_test): Update.
 795         (regcache_thread_ptid_changed): Update.
 796         * regcache.h (regcache_up): New type.
 797         * gdbsupport/ptid.h (hash_ptid): New struct.
 798
 799 2020-08-07  Simon Marchi  <simon.marchi@efficios.com>
 800
 801         * observable.h (thread_ptid_changed): Add parameter
 802         `process_stratum_target *`.
 803         * infrun.c (infrun_thread_ptid_changed): Add parameter
 804         `process_stratum_target *` and use it.
 805         (selftests): New namespace.
 806         (infrun_thread_ptid_changed): New function.
 807         (_initialize_infrun): Register selftest.
 808         * regcache.c (regcache_thread_ptid_changed): Add parameter
 809         `process_stratum_target *` and use it.
 810         (regcache_thread_ptid_changed): New function.
 811         (_initialize_regcache): Register selftest.
 812         * thread.c (thread_change_ptid): Pass target to
 813         thread_ptid_changed observable.
 814
 815 2020-08-06  Caroline Tice <cmtice@google.com>
 816
 817         * dwarf2/read.c (struct dwo_file): Update comment on 'sections' field.
 818         (struct dwp_sections): Update field comments.  Add loclists and
 819         rnglists fields.
 820         (struct virtual_v2_dwo_sections): Rename struct to
 821         'virtual_v2_or_v5_dwo_sections'; update comments at top of struct; add
 822         size & offset fields for loclists and rnglists.
 823         (struct dwp_hash_table): Add a 'v5' struct field to the union section.
 824         (create_debug_type_hash_table): Add 'DW_UT_split_type' to the check for
 825         skipping dummy type units.
 826         (create_dwp_hash_table): Update the large comment above the function to
 827         discuss Version 5 DWP files as well, with references.  Update all the
 828         version checks in the function to check for version 5 as well.  Add new
 829         section at the end to create dwp hash table for version 5.
 830         (create_dwp_v2_section): Rename function to
 831         'create_dwp_v2_or_v5_section'.  Update function comment appropriately.
 832         Add V5 to error message text.
 833         (create_dwo_unit_in_dwp_v2): Change calls to create_dwp_v2_section
 834         into calls to create_dwp_v2_or_v5_section.
 835         (create_dwo_unit_in_dwp_v5): New function.
 836         (lookup_dwo_unit_in_dwp): Update conditional statement to explicitly
 837         check for version2; add else clause to handle version 5.
 838         (open_and_init_dwo_file): Add code to check dwarf version & only call
 839         create_debug_types_hash_table (with sections.types) if version is not 5;
 840         else call create_debug_type_hash_table, with sections.info.
 841         (dwarf2_locate_v2_dwp_sections): Update function comment to mention
 842         version 5.
 843         (dwarf2_locate_v5_dwp_sections): New function.
 844         (open_and_init_dwp_file): Add else-if clause for version 5 to call
 845         bfd_map_over_sections with dwarf2_locate_v5_dwp_sections.
 846
 847 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 848
 849         * regcache.h (class regcache): Remove friend
 850         registers_changed_ptid.
 851         <regcache_thread_ptid_changed>: Remove.
 852         <regcaches>: Remove.
 853         * regcache.c (regcache::regcaches): Rename to...
 854         (regcaches): ... this.  Make static.
 855         (get_thread_arch_aspace_regcache): Update.
 856         (regcache::regcache_thread_ptid_changed): Rename to...
 857         (regcache_thread_ptid_changed): ... this.  Update.
 858         (class regcache_access): Remove.
 859         (regcaches_test): Update.
 860         (_initialize_regcache): Update.
 861         * sparc64-tdep.c, dwarf2/index-write.c, record-btrace.c: Include
 862         <forward_list>.
 863
 864 2020-08-06  Simon Marchi  <simon.marchi@efficios.com>
 865
 866         * regcache.h (class regcache) <current_regcache>: Rename to...
 867         <regcaches>: ... this.  Move doc here.
 868         * regcache.c (regcache::current_regcache) Rename to...
 869         (regcache::regcaches): ... this.  Move doc to header.
 870         (get_thread_arch_aspace_regcache): Update.
 871         (regcache::regcache_thread_ptid_changed): Update.
 872         (registers_changed_ptid): Update.
 873         (class regcache_access) <current_regcache_size>: Rename to...
 874         <regcaches_size>: ... this.
 875         (current_regcache_test): Rename to...
 876         (regcaches_test): ... this.
 877         (_initialize_regcache): Update.
 878
 879 2020-08-06  Victor Collod  <vcollod@nvidia.com>
 880
 881         * amd64-tdep.c (amd64_analyze_prologue): Fix incorrect comment.
 882
 883 2020-08-05  Kevin Buettner  <kevinb@redhat.com>
 884
 885         * corelow.c (core_target::build_file_mappings): Don't output
 886         null pathname in warning.
 887
 888 2020-08-05  Simon Marchi  <simon.marchi@polymtl.ca>
 889
 890         * gdb.dwarf2/clztest.exp, gdb.dwarf2/dw2-common-block.exp,
 891         gdb.dwarf2/dw2-dup-frame.exp, gdb.dwarf2/dw2-reg-undefined.exp,
 892         gdb.dwarf2/dw2-single-line-discriminators.exp,
 893         dw2-undefined-ret-addr.exp: Pass nopie to compilation options.
 894
 895 2020-08-05  Tom Tromey  <tromey@adacore.com>
 896
 897         PR rust/26197:
 898         * dwarf2/read.c (alloc_rust_variant): Handle univariant case.
 899         (quirk_rust_enum): Call alloc_rust_variant for univariant case.
 900         Fix off-by-one and type size errors in ordinary case.
 901
 902 2020-08-05  Tom de Vries  <tdevries@suse.de>
 903
 904         * gdbtypes.c (type_not_allocated, type_not_associated): Use
 905         "prop->const_val () == 0" instead of "prop->const_val () != 0".
 906
 907 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 908
 909         * frame.h (frame_id_p): Return bool.
 910         (frame_id_artificial_p): Return bool.
 911         (frame_id_eq): Return bool.
 912         (has_stack_frames): Return bool.
 913         (get_selected_frame): Fix typo in comment.
 914         (get_frame_pc_if_available): Return bool.
 915         (get_frame_address_in_block_if_available): Return bool.
 916         (get_frame_func_if_available): Return bool.
 917         (read_frame_register_unsigned): Return bool.
 918         (get_frame_register_bytes): Return bool.
 919         (safe_frame_unwind_memory): Return bool.
 920         (deprecated_frame_register_read): Return bool.
 921         (frame_unwinder_is): Return bool.
 922         * frame.c (struct frame_info) <prev_arch::p>: Change type to
 923         bool.
 924         <this_id::p>: Likewise.
 925         <prev_p>: Likewise.
 926         (frame_stash_add): Return bool.
 927         (get_frame_id): Use bool.
 928         (frame_id_build_special) Use bool.
 929         (frame_id_build_unavailable_stack): Use bool.
 930         (frame_id_build): Use bool.
 931         (frame_id_p): Return bool, use true/false instead of 1/0.
 932         (frame_id_artificial_p): Likewise.
 933         (frame_id_eq): Likewise.
 934         (frame_id_inner): Likewise.
 935         (get_frame_func_if_available): Likewise.
 936         (read_frame_register_unsigned): Likewise.
 937         (deprecated_frame_register_read): Likewise.
 938         (get_frame_register_bytes): Likewise.
 939         (has_stack_frames): Likewise.
 940         (inside_main_func): Likewise.
 941         (inside_entry_func): Likewise.
 942         (get_frame_pc_if_available): Likewise.
 943         (get_frame_address_in_block_if_available): Likewise.
 944         (frame_unwinder_is): Likewise.
 945         (safe_frame_unwind_memory): Likewise.
 946         (frame_unwind_arch): Likewise.
 947
 948 2020-08-04  Simon Marchi  <simon.marchi@efficios.com>
 949
 950         * frame.c (frame_info) <prev_func> <p>: Rename to status, change
 951         type to cached_copy_status.
 952         (fprintf_frame): Adjust.
 953         (get_frame_func_if_available): Adjust.
 954         (frame_cleanup_after_sniffer): Adjust.
 955
 956 2020-08-04  Mark Wielaard  <mark@klomp.org>
 957
 958         * MAINTAINERS (Write After Approval): Update email address.
 959
 960 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 961
 962         * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with
 963         dynamic_prop::const_val.
 964
 965 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 966
 967         * gdbtypes.h (TYPE_DYN_PROP_KIND): Remove, replace uses with
 968         dynamic_prop::kind.
 969
 970 2020-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 971
 972         * gdbtypes.h (TYPE_DYN_PROP_BATON): Remove.
 973
 974 2020-08-04  Jose E. Marchesi  <jose.marchesi@oracle.com>
 975
 976         * configure.tgt: Set gdb_sim for bpf-*-* targets.
 977
 978 2020-08-04  Weimin Pan <weimin.pan@oracle.com>
 979             Jose E. Marchesi  <jose.marchesi@oracle.com>
 980
 981         * configure.tgt: Add entry for bpf-*-*.
 982         * Makefile.in (ALL_TARGET_OBS): Add bpf-tdep.o
 983         (ALLDEPFILES): Add bpf-tdep.c.
 984         * bpf-tdep.c: New file.
 985         * MAINTAINERS: Add bpf target and maintainer.
 986         * NEWS: Mention the support for the new target.
 987
 988 2020-08-04  Tom de Vries  <tdevries@suse.de>
 989
 990         PR symtab/23270
 991         * dwarf2/read.c (find_partial_die): Change internal error into Dwarf
 992         Error.
 993
 994 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 995
 996         * syscalls/freebsd.xml: Regenerate.
 997
 998 2020-08-03  John Baldwin  <jhb@FreeBSD.org>
 999
1000         * syscalls/update-freebsd.sh: Fix usage and year range.
1001
1002 2020-08-03  Tom de Vries  <tdevries@suse.de>
1003
1004         PR symtab/26333
1005         * dwarf2/read.c (dwarf_decode_lines_1): Ignore
1006         DW_LNE_lo_user/DW_LNE_hi_user range.
1007
1008 2020-07-30  Simon Marchi  <simon.marchi@polymtl.ca>
1009
1010         PR ada/26318
1011         * ada-lang.c (ada_modulus): Return 0 if property is not of const
1012         kind.
1013
1014 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1015
1016         * breakpoint.c (set_breakpoint_condition): Do minor refactoring.
1017
1018 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1019
1020         * breakpoint.c (set_breakpoint_condition): Update the condition
1021         expressions after checking that the input condition string parses
1022         successfully and does not contain junk at the end.
1023
1024 2020-07-30  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1025
1026         * breakpoint.c (set_breakpoint_condition): Update the
1027         condition string after parsing the new condition successfully.
1028
1029 2020-07-30  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1030
1031         * proc-api.c (_STRUCTURED_PROC): Don't define.
1032         * proc-events.c: Likewise.
1033         * proc-flags.c: Likewise.
1034         * proc-why.c: Likewise.
1035         * procfs.c: Likewise.
1036
1037         * Makefile.in (INTERNAL_CPPFLAGS): Add LARGEFILE_CPPFLAGS.
1038         * configure, config.in: Regenerate.
1039
1040 2020-07-30  Tom de Vries  <tdevries@suse.de>
1041
1042         PR build/26320
1043         * ui-style.h (struct ui_file_style::color): Wrap m_value and
1044         m_red/m_green/m_blue in a union.
1045
1046 2020-07-29  Tom de Vries  <tdevries@suse.de>
1047
1048         PR tdep/26280
1049         * s390-tdep.c (s390_displaced_step_fixup): Fix Wmaybe-uninitialized.
1050
1051 2020-07-28  Tom Tromey  <tromey@adacore.com>
1052
1053         PR symtab/26270:
1054         * symtab.h (find_pc_partial_function_sym): Declare.
1055         * cli/cli-cmds.c (disassemble_command): Use
1056         find_pc_partial_function_sym.  Check asm_demangle.
1057         * blockframe.c (cache_pc_function_sym): New global.
1058         (cache_pc_function_name): Remove.
1059         (clear_pc_function_cache): Update.
1060         (find_pc_partial_function_sym): New function, from
1061         find_pc_partial_function.
1062         (find_pc_partial_function): Rewrite using
1063         find_pc_partial_function_sym.
1064
1065 2020-07-28  Tom Tromey  <tromey@adacore.com>
1066
1067         * cli/cli-cmds.c (_initialize_cli_cmds): Rearrange "disassemble"
1068         help.  Add usage.
1069
1070 2020-07-28  Tom Tromey  <tromey@adacore.com>
1071
1072         * dwarf2/expr.c (dwarf_expr_context::execute_stack_op)
1073         <DW_OP_GNU_variable_value>: Cast to address type.
1074
1075 2020-07-28  Kamil Rytarowski  <n54@gmx.com>
1076
1077         * nbsd-nat.h (nbsd_nat_target::xfer_partial): New declaration.
1078         * nbsd-nat.c (nbsd_nat_target::xfer_partial): New function.
1079         * nbsd-tdep.c (nbsd_gdbarch_data_handle, struct nbsd_gdbarch_data)
1080         (init_nbsd_gdbarch_data, get_nbsd_gdbarch_data)
1081         (nbsd_get_siginfo_type): New.
1082         (nbsd_init_abi): Install gdbarch "get_siginfo_type" method.
1083         (_initialize_nbsd_tdep): New.
1084
1085 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
1086
1087         PR binutils/26301
1088         * configure: Regenerated.
1089
1090 2020-07-28  H.J. Lu  <hongjiu.lu@intel.com>
1091
1092         PR binutils/26301
1093         * configure: Regenerated.
1094
1095 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * python/py-frame.c: Remove 'user-regs.h' include.
1098         (frapy_read_register): Rewrite to make use of
1099         gdbpy_parse_register_id.
1100         * python/py-registers.c (gdbpy_parse_register_id): New function,
1101         moved here from python/py-unwind.c.  Updated the return type, and
1102         also accepts register descriptor objects.
1103         * python/py-unwind.c: Remove 'user-regs.h' include.
1104         (pyuw_parse_register_id): Moved to python/py-registers.c.
1105         (unwind_infopy_add_saved_register): Update to use
1106         gdbpy_parse_register_id.
1107         (pending_framepy_read_register): Likewise.
1108         * python/python-internal.h (gdbpy_parse_register_id): Declare.
1109
1110 2020-07-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * python/py-registers.c: Add 'user-regs.h' include.
1113         (register_descriptor_iter_find): New function.
1114         (register_descriptor_iterator_object_methods): New static global
1115         methods array.
1116         (register_descriptor_iterator_object_type): Add pointer to methods
1117         array.
1118
1119 2020-07-27  John Baldwin  <jhb@FreeBSD.org>
1120
1121         * fbsd-nat.h: Include <osreldate.h>.  Define USE_SIGTRAP_SIGINFO
1122         for all architectures on FreeBSD 11.3 and later.
1123
1124 2020-07-27  Tom Tromey  <tromey@adacore.com>
1125
1126         * gcore.h (load_corefile): Don't declare.
1127
1128 2020-07-27  Tom de Vries  <tdevries@suse.de>
1129
1130         * configure.ac: Fix sys/sockets.h -> sys/socket.h typo.
1131         * config.in: Regenerate.
1132         * configure: Regenerate.
1133
1134 2020-07-26  Eli Zaretskii  <eliz@gnu.org>
1135
1136         * configure.ac (AC_CHECK_HEADERS): Check for sys/socket.h and
1137         ws2tcpip.h.  When checking whether socklen_t type is defined, use
1138         ws2tcpip.h if it is available and sys/socket.h isn't.
1139         * configure: Regenerate.
1140         * config.in: Regenerate.
1141
1142 2020-07-25  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         PR fortran/23051
1145         PR fortran/26139
1146         * valops.c (value_ind): Pass address to
1147         readjust_indirect_value_type.
1148         * value.c (readjust_indirect_value_type): Make parameter
1149         non-const, and add extra address parameter.  Resolve original type
1150         before using it.
1151         * value.h (readjust_indirect_value_type): Update function
1152         signature and comment.
1153
1154 2020-07-25  Tom de Vries  <tdevries@suse.de>
1155
1156         PR symtab/26243
1157         * dwarf2/read.c (lnp_state_machine::record_line): Ignore zero line
1158         entries.
1159
1160 2020-07-24  Aaron Merey  <amerey@redhat.com>
1161
1162         * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS.
1163         * configure: Rebuild.
1164
1165 2020-07-23  Kevin Buettner  <kevinb@redhat.com>
1166
1167         PR corefiles/26294
1168         * corelow.c (_initialize_corelow): Add period to help text
1169         for "maintenance print core-file-backed-mappings".
1170
1171 2020-07-23  Pedro Alves  <pedro@palves.net>
1172
1173         * frame-unwind.c (frame_unwind_try_unwinder): On exception, don't
1174         touch THIS_CACHE/THIS_FRAME if the frame cache was cleared
1175         meanwhile.
1176         * frame.c (frame_cache_generation, get_frame_cache_generation):
1177         New.
1178         (reinit_frame_cache): Increment FRAME_CACHE_GENERATION.
1179         (get_prev_frame_if_no_cycle): On exception, don't touch
1180         PREV_FRAME/THIS_FRAME if the frame cache was cleared meanwhile.
1181         * frame.h (get_frame_cache_generation): Declare.
1182
1183 2020-07-23  Tom de Vries  <tdevries@suse.de>
1184
1185         PR tui/26282
1186         * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
1187         New default constructor.
1188
1189 2020-07-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * disasm.c (do_mixed_source_and_assembly_deprecated): Don't
1192         exclude non-statement entries.
1193
1194 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1195
1196         * NEWS (New commands): Mention new command
1197         "maintenance print core-file-backed-mappings".
1198
1199 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1200
1201         * corelow.c (gdbcmd.h): Include.
1202         (core_target::info_proc_mappings): New method.
1203         (get_current_core_target): New function.
1204         (maintenance_print_core_file_backed_mappings): New function.
1205         (_initialize_corelow): Add core-file-backed-mappings to
1206         "maint print" commands.
1207
1208 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1209
1210         * linux-tdep.c (dump_note_entry_p): New function.
1211         (linux_dump_mapping_p_ftype): New typedef.
1212         (linux_find_memory_regions_full): Add new parameter,
1213         should_dump_mapping_p.
1214         (linux_find_memory_regions): Adjust call to
1215         linux_find_memory_regions_full.
1216         (linux_make_mappings_core_file_notes): Use dump_note_entry_p in
1217         call to linux_find_memory_regions_full.
1218
1219 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1220
1221         * corelow.c (solist.h, unordered_map): Include.
1222         (class core_target): Add field m_core_file_mappings and
1223         method build_file_mappings.
1224         (core_target::core_target): Call build_file_mappings.
1225         (core_target::~core_target): Free memory associated with
1226         m_core_file_mappings.
1227         (core_target::build_file_mappings): New method.
1228         (core_target::xfer_partial): Use m_core_file_mappings
1229         for memory transfers.
1230         * linux-tdep.c (linux_read_core_file_mappings): New
1231         function.
1232         (linux_core_info_proc_mappings): Rewrite to use
1233         linux_read_core_file_mappings.
1234         (linux_init_abi): Register linux_read_core_file_mappings.
1235
1236 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1237
1238         * arch-utils.c (default_read_core_file_mappings): New function.
1239         * arch-utils.c (default_read_core_file_mappings): Declare.
1240         * gdbarch.sh (read_core_file_mappings): New gdbarch method.
1241         * gdbarch.h, gdbarch.c: Regenerate.
1242
1243 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1244
1245         PR corefiles/25631
1246         * corelow.c (core_target:xfer_partial):  Revise
1247         TARGET_OBJECT_MEMORY case to consider non-SEC_HAS_CONTENTS
1248         case after first checking the stratum beneath the core
1249         target.
1250         (has_all_memory): Return true.
1251         * target.c (raw_memory_xfer_partial): Revise comment
1252         regarding use of has_all_memory.
1253
1254 2020-07-22  Kevin Buettner  <kevinb@redhat.com>
1255
1256         * exec.h (section_table_xfer_memory): Revise declaration,
1257         replacing section name parameter with an optional callback
1258         predicate.
1259         * exec.c (section_table_xfer_memory): Likewise.
1260         * bfd-target.c, exec.c, target.c, corelow.c: Adjust all callers
1261         of section_table_xfer_memory.
1262
1263 2020-07-22  Tom Tromey  <tromey@adacore.com>
1264
1265         * mi/mi-cmd-stack.c (list_args_or_locals): Use
1266         lookup_symbol_search_name.
1267
1268 2020-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * python/py-registers.c (gdbpy_register_object_data_init): Remove
1271         redundant local variable.
1272         (gdbpy_get_register_descriptor): Extract descriptor vector as a
1273         reference, not pointer, update code accordingly.
1274
1275 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1276             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1277
1278         * objfiles.h (struct objfile) <skip_jit_symbol_lookup>: New field.
1279         * jit.c (jit_breakpoint_re_set_internal): Use the
1280         `skip_jit_symbol_lookup` field.
1281
1282 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1283             Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1284
1285         * jit.c (jit_read_descriptor): Define the descriptor address once,
1286         use twice.
1287         (jit_breakpoint_deleted): Move the declaration of the loop variable
1288         `iter` into the loop header.
1289         (jit_breakpoint_re_set_internal): Move the declaration of the local
1290         variable `objf_data` to the first point of definition.
1291         (jit_event_handler): Move the declaration of local variables
1292         `code_entry`, `entry_addr`, and `objf` to their first point of use.
1293         Rename `objf` to `jited`.
1294
1295 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1296
1297         * jit.h (struct jiter_objfile_data) <jiter_objfile_data, objfile>:
1298         Remove.
1299         * jit.c (get_jiter_objfile_data): Update.
1300
1301 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1302             Simon Marchi  <simon.marchi@polymtl.ca>
1303
1304         * jit.c (struct jit_program_space_data): Remove.
1305         (jit_program_space_key): Remove.
1306         (jiter_objfile_data::~jiter_objfile_data): Remove program space
1307         stuff.
1308         (get_jit_program_space_data): Remove.
1309         (jit_breakpoint_deleted): Iterate on all of the program space's
1310         objfiles.
1311         (jit_inferior_init): Likewise.
1312         (jit_breakpoint_re_set_internal): Likewise.  Also change return
1313         type to void.
1314         (jit_breakpoint_re_set): Pass current_program_space to
1315         jit_breakpoint_re_set_internal.
1316
1317 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1318
1319         * jit.h (struct jiter_objfile_data) <cached_code_address,
1320         jit_breakpoint>: Move to here from ...
1321         * jit.c (jit_program_space_data): ... here.
1322         (jiter_objfile_data::~jiter_objfile_data): Update.
1323         (jit_breakpoint_deleted): Update.
1324         (jit_breakpoint_re_set_internal): Update.
1325
1326 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1327
1328         * jit.c (jiter_objfile_data::~jiter_objfile_data): Remove some
1329         checks.
1330         (jit_read_descriptor): Remove NULL check.
1331         (jit_event_handler): Add an assertion.
1332
1333 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1334
1335         * jit.h (struct jit_objfile_data):  Split into...
1336         (struct jiter_objfile_data): ... this ...
1337         (struct jited_objfile_data): ... and this.
1338         * objfiles.h (struct objfile) <jit_data>: Remove.
1339         <jiter_data, jited_data>: New fields.
1340         * jit.c (jit_objfile_data::~jit_objfile_data): Rename to ...
1341         (jiter_objfile_data::~jiter_objfile_data): ... this.
1342         (get_jit_objfile_data): Rename to ...
1343         (get_jiter_objfile_data): ... this.
1344         (add_objfile_entry): Update.
1345         (jit_read_descriptor): Use get_jiter_objfile_data.
1346         (jit_find_objf_with_entry_addr): Use objfile's jited_data field.
1347         (jit_breakpoint_re_set_internal): Use get_jiter_objfile_data.
1348         (jit_inferior_exit_hook): Use objfile's jited_data field.
1349
1350 2020-07-22  Simon Marchi  <simon.marchi@polymtl.ca>
1351
1352         * jit.h: Forward-declare `struct minimal_symbol`.
1353         (struct jit_objfile_data): Migrate to here from jit.c; also add a
1354         constructor, destructor, and an objfile* field.
1355         * jit.c (jit_objfile_data): Remove.
1356         (struct jit_objfile_data): Migrate from here to jit.h.
1357         (jit_objfile_data::~jit_objfile_data): New destructor
1358         implementation with code moved from free_objfile_data.
1359         (free_objfile_data): Delete.
1360         (get_jit_objfile_data): Update to use the jit_data field of objfile.
1361         (jit_find_objf_with_entry_addr): Ditto.
1362         (jit_inferior_exit_hook): Ditto.
1363         (_initialize_jit): Remove the call to
1364         register_objfile_data_with_cleanup.
1365         * objfiles.h (struct objfile) <jit_data>: New field.
1366
1367 2020-07-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1368
1369         * jit.h: Forward-declare `struct objfile`.
1370         (jit_event_handler): Add a second parameter, the JITer objfile.
1371         * jit.c (jit_read_descriptor): Change the signature to take the
1372         JITer objfile as an argument instead of the jit_program_space_data.
1373         (jit_inferior_init): Update the call to jit_read_descriptor.
1374         (jit_event_handler): Use the new JITer objfile argument when calling
1375         jit_read_descriptor.
1376         * breakpoint.c (handle_jit_event): Update the call to
1377         jit_event_handler to pass the JITer objfile.
1378
1379 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1380
1381         * gdbarch.c: Regenerate.
1382         * gdbarch.h: Regenerate.
1383         * gdbarch.sh (handle_segmentation_fault): Remove method.
1384         * infrun.c (handle_segmentation_fault): Remove.
1385         (print_signal_received_reason): Remove call to
1386         handle_segmentation_fault.
1387
1388 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1389
1390         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1391         Rename to sparc64_linux_report_signal_info and add siggnal
1392         argument.
1393         (sparc64_linux_init_abi): Use sparc64_linux_report_signal_info
1394         instead of sparc64_linux_handle_segmentation_fault.
1395
1396 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1397
1398         * amd64-linux-tdep.c (amd64_linux_init_abi_common): Use
1399         i386_linux_report_signal_info instead of
1400         i386_linux_handle_segmentation_fault.
1401         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Rename
1402         to i386_linux_report_signal_info and add siggnal argument.
1403         (i386_linux_init_abi): Use i386_linux_report_signal_info instead
1404         of i386_linux_handle_segmentation_fault.
1405         * i386-linux-tdep.h (i386_linux_handle_segmentation_fault): Rename
1406         to i386_linux_report_signal_info and add siggnal argument.
1407
1408 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1409
1410         * corelow.c (core_target_open): Invoke gdbarch report_signal_info
1411         hook if present.
1412
1413 2020-07-21  John Baldwin  <jhb@FreeBSD.org>
1414
1415         * gdbarch.c: Regenerate.
1416         * gdbarch.h: Regenerate.
1417         * gdbarch.sh (report_signal_info): New method.
1418         * infrun.c (print_signal_received_reason): Invoke gdbarch
1419         report_signal_info hook if present.
1420
1421 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * python/py-registers.c : Add 'unordered_map' include.
1424         (gdbpy_new_reggroup): Renamed to...
1425         (gdbpy_get_reggroup): ...this.  Update to only create register
1426         group descriptors when needed.
1427         (gdbpy_reggroup_iter_next): Update.
1428
1429 2020-07-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1430
1431         * python/py-registers.c (gdbpy_register_object_data): New static
1432         global.
1433         (gdbpy_register_object_data_init): New function.
1434         (gdbpy_new_register_descriptor): Renamed to...
1435         (gdbpy_get_register_descriptor): ...this, and update to reuse
1436         existing register descriptors where possible.
1437         (gdbpy_register_descriptor_iter_next): Update.
1438         (gdbpy_initialize_registers): Register new gdbarch data.
1439
1440 2020-07-21  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * linux-nat.c (stopped_pids): Make static.
1443
1444 2020-07-21  Simon Marchi  <simon.marchi@polymtl.ca>
1445
1446         PR ada/26235
1447         * gdbtypes.c (ada_discrete_type_low_bound,
1448         ada_discrete_type_high_bound): Handle undefined bounds.
1449
1450 2020-07-21  Kamil Rytarowski  <n54@gmx.com>
1451
1452         * nbsd-nat.h (nbsd_nat_target::supports_multi_process): New
1453         declaration.
1454         * nbsd-nat.c (nbsd_nat_target::supports_multi_process): New
1455         function.
1456
1457 2020-07-20  John Baldwin  <jhb@FreeBSD.org>
1458
1459         * fbsd-tdep.c (fbsd_skip_solib_resolver): New function.
1460         (fbsd_init_abi): Install gdbarch "skip_solib_resolver" method.
1461         * fbsd-tdep.h (fbsd_skip_solib_resolver): New prototype.
1462         * mips-fbsd-tdep.c (mips_fbsd_skip_solib_resolver): New function.
1463         (mips_fbsd_init_abi): Install gdbarch "skip_solib_resolver"
1464         method.
1465
1466 2020-07-20 Ludovic Courtès  <ludo@gnu.org>
1467
1468         * guile/scm-math.c (vlscm_integer_fits_p): Use 'uintmax_t'
1469         and 'intmax_t' instead of 'scm_t_uintmax' and 'scm_t_intmax',
1470         which are deprecated in Guile 3.0.
1471         * configure.ac (try_guile_versions): Add "guile-3.0".
1472         * configure (try_guile_versions): Regenerate.
1473         * NEWS: Update entry.
1474
1475 2020-07-20  Ludovic Courtès  <ludo@gnu.org>
1476             Doug Evans  <dje@google.com>
1477
1478         PR gdb/21104
1479         * guile/scm-ports.c (USING_GUILE_BEFORE_2_2): New macro.
1480         (ioscm_memory_port)[read_buf_size, write_buf_size]: Wrap in #if
1481         USING_GUILE_BEFORE_2_2.
1482         (stdio_port_desc, memory_port_desc) [!USING_GUILE_BEFORE_2_2]:
1483         Change type to 'scm_t_port_type *'.
1484         (natural_buffer_size) [!USING_GUILE_BEFORE_2_2]: New variable.
1485         (ioscm_open_port) [USING_GUILE_BEFORE_2_2]: Add 'stream'
1486         parameter and honor it.  Update callers.
1487         (ioscm_open_port) [!USING_GUILE_BEFORE_2_2]: New function.
1488         (ioscm_read_from_port, ioscm_write) [!USING_GUILE_BEFORE_2_2]: New
1489         functions.
1490         (ioscm_fill_input, ioscm_input_waiting, ioscm_flush): Wrap in #if
1491         USING_GUILE_BEFORE_2_2.
1492         (ioscm_init_gdb_stdio_port) [!USING_GUILE_BEFORE_2_2]: Use
1493         'ioscm_read_from_port'.  Call 'scm_set_port_read_wait_fd'.
1494         (ioscm_init_stdio_buffers) [!USING_GUILE_BEFORE_2_2]: New function.
1495         (gdbscm_stdio_port_p) [!USING_GUILE_BEFORE_2_2]: Use 'SCM_PORTP'
1496         and 'SCM_PORT_TYPE'.
1497         (gdbscm_memory_port_end_input, gdbscm_memory_port_seek)
1498         (ioscm_reinit_memory_port): Wrap in #if USING_GUILE_BEFORE_2_2.
1499         (gdbscm_memory_port_read, gdbscm_memory_port_write)
1500         (gdbscm_memory_port_seek, gdbscm_memory_port_close)
1501         [!USING_GUILE_BEFORE_2_2]: New functions.
1502         (gdbscm_memory_port_print): Remove use of 'SCM_PTOB_NAME'.
1503         (ioscm_init_memory_port_type) [!USING_GUILE_BEFORE_2_2]: Use
1504         'gdbscm_memory_port_read'.
1505         Wrap 'scm_set_port_end_input', 'scm_set_port_flush', and
1506         'scm_set_port_free' calls in #if USING_GUILE_BEFORE_2_2.
1507         (gdbscm_get_natural_buffer_sizes) [!USING_GUILE_BEFORE_2_2]: New
1508         function.
1509         (ioscm_init_memory_port): Remove.
1510         (ioscm_init_memory_port_stream): New function
1511         (ioscm_init_memory_port_buffers) [USING_GUILE_BEFORE_2_2]: New
1512         function.
1513         (gdbscm_memory_port_read_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1514         Return scm_from_uint (0).
1515         (gdbscm_set_memory_port_read_buffer_size_x)
1516         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1517         (gdbscm_memory_port_write_buffer_size) [!USING_GUILE_BEFORE_2_2]:
1518         Return scm_from_uint (0).
1519         (gdbscm_set_memory_port_write_buffer_size_x)
1520         [!USING_GUILE_BEFORE_2_2]: Call 'scm_setvbuf'.
1521         * configure.ac (try_guile_versions): Add "guile-2.2".
1522         * configure: Regenerate.
1523         * NEWS: Add entry.
1524
1525 2020-07-18  Tom Tromey  <tom@tromey.com>
1526
1527         * linux-nat.c (linux_multi_process): Remove.
1528         (linux_nat_target::supports_multi_process): Return true.
1529
1530 2020-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1531
1532         * arch/riscv.c (riscv_tdesc_cache): Change map type.
1533         (riscv_lookup_target_description): Return pointer out of
1534         unique_ptr.
1535         * target-descriptions.c (allocate_target_description): Add
1536         comment.
1537         (target_desc_deleter::operator()): Likewise.
1538         * target-descriptions.h (struct target_desc_deleter): Moved to
1539         gdbsupport/tdesc.h.
1540         (target_desc_up): Likewise.
1541
1542 2020-07-17  Tom Tromey  <tromey@adacore.com>
1543
1544         * linux-nat.c (linux_nat_target::supports_non_stop)
1545         (linux_nat_target::always_non_stop_p): Use "true".
1546         (linux_nat_target::supports_disable_randomization): Use "true" and
1547         "false".
1548
1549 2020-07-16  Caroline Tice  <cmtice@google.com>
1550
1551         * dwarf2/read.c (RNGLIST_HEADER_SIZE32) New constant definition.
1552         (RNGLIST_HEADER_SIZE64): New constant definition.
1553         (struct dwop_section_names): Add rnglists_dwo.
1554         (dwop_section_names): Add .debug_rnglists.dwo, .zdebug_rnglists.dwo.
1555         (struct loclist_header): Rename to 'loclists_rnglists_header'.
1556         (struct dwo_sections): Add rnglists field.
1557         (read_attribut_reprocess): Add tag parameter.
1558         (dwarf2_ranges_read): Add tag parameter & remove forward function decl.
1559         (cu_debug_rnglists_section): New function (decl & definition).
1560         (dwarf2_locate_dwo_sections): Add code to read rnglists_dwo section.
1561         (dwarf2_rnglists_process): Add a dwarf_tag parameter, for the kind of
1562         die whose range is being checked; get rnglist section from
1563         cu_debug_rnglists_section, to get from either objfile or dwo file as
1564         appropriate.  Add cases for DW_RLE_base_addressx,
1565         DW_RLE_startx_length, DW_RLE_startx_endx.  Also, update to only add
1566         the base address to DW_RLE_offset_pairs (not to all ranges), moving
1567         test inside if-condition and updating complaint message.
1568         (dwarf2_ranges_process): Add dwarf tag parameter and pass it to
1569         dwarf2_rnglists_process.
1570         (dwarf2_ranges_read): Add dwarf tag parameter and pass it to
1571         dwarf2_ranges_process.
1572         (dwarf2_get_pc_bounds): Check for DW_FORM_rnglistx when setting
1573         need_ranges_base and update comment appropriately.  Also pass die tag
1574         to dwarf2_ranges_read.
1575         (dwarf2_record_block_ranges): Check for DW_FORM_rnglistx when setting
1576         need_ranges_base and update comment appropriately.  Also pass die tag
1577         to dwarf2_ranges_process.
1578         (read_full_die_1): Add code to read DW_AT_rnglists_base and assign to
1579         cu->ranges_base.  Also pass die tag to read_attribute_reprocess.
1580         (partial_die_info::read): Check for DW_FORM_rnglistx when setting
1581         need_ranges_base and update comment appropriately.  Also pass die tag
1582         to read_attribute_reprocess and dwarf2_ranges_read.
1583         (read_loclist_header): Rename function to read_loclists_rnglists_header,
1584         and update function comment appropriately.
1585         (read_loclist_index): Call read_loclists_rnglists_header instead of
1586         read_loclist_header.
1587         (read_rnglist_index): New function.
1588         (read_attribute_reprocess):  Add tag parameter. Add code for
1589         DW_FORM_rnglistx, passing tag to read_rnglist_index.
1590         (read_attribute_value): Mark DW_FORM_rnglistx with need_reprocess.
1591
1592 2020-07-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1593
1594         * f-typeprint.c (f_type_print_base): Allow for dynamic types not
1595         being resolved.
1596
1597 2020-07-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * arch-utils.c (show_architecture): Update formatting of messages.
1600
1601 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1602
1603         * gdbtypes.h (struct type) <bounds>: Handle array and string
1604         types.
1605         * ada-lang.c (assign_aggregate): Use type::bounds on
1606         array/string type.
1607         * c-typeprint.c (c_type_print_varspec_suffix): Likewise.
1608         * c-varobj.c (c_number_of_children): Likewise.
1609         (c_describe_child): Likewise.
1610         * eval.c (evaluate_subexp_for_sizeof): Likewise.
1611         * f-typeprint.c (f_type_print_varspec_suffix): Likewise.
1612         (f_type_print_base): Likewise.
1613         * f-valprint.c (f77_array_offset_tbl): Likewise.
1614         (f77_get_upperbound): Likewise.
1615         (f77_print_array_1): Likewise.
1616         * guile/scm-type.c (gdbscm_type_range): Likewise.
1617         * m2-typeprint.c (m2_array): Likewise.
1618         (m2_is_long_set_of_type): Likewise.
1619         * m2-valprint.c (get_long_set_bounds): Likewise.
1620         * p-typeprint.c (pascal_type_print_varspec_prefix): Likewise.
1621         * python/py-type.c (typy_range): Likewise.
1622         * rust-lang.c (rust_internal_print_type): Likewise.
1623         * type-stack.c (type_stack::follow_types): Likewise.
1624         * valarith.c (value_subscripted_rvalue): Likewise.
1625         * valops.c (value_cast): Likewise.
1626
1627 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1628
1629         * gdbtypes.c (TYPE_ARRAY_BIT_STRIDE): Remove.  Update all
1630         callers to use the equivalent accessor methods.
1631
1632 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1633
1634         * gdbtypes.h (struct range_bounds) <bit_stride>: New method.
1635         (struct type) <bit_stride>: New method.
1636         (TYPE_BIT_STRIDE): Remove.
1637         * gdbtypes.c (update_static_array_size): Use type::bit_stride.
1638
1639 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1640
1641         * gdbtypes.h (TYPE_ARRAY_LOWER_BOUND_VALUE,
1642         TYPE_ARRAY_UPPER_BOUND_VALUE): Remove.  Update all
1643         callers to use the equivalent accessor methods instead.
1644
1645 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1646
1647         * gdbtypes.h (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED,
1648         TYPE_ARRAY_LOWER_BOUND_IS_UNDEFINED): Remove.  Update all
1649         callers to use the equivalent accessor methods instead.
1650
1651 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1652
1653         * gdbtypes.h (TYPE_LOW_BOUND_KIND,
1654         TYPE_HIGH_BOUND_KIND): Remove.  Update all callers
1655         to use dynamic_prop::kind.
1656
1657 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1658
1659         * gdbtypes.h (TYPE_LOW_BOUND_UNDEFINED,
1660         TYPE_HIGH_BOUND_UNDEFINED): Remove.  Update all callers
1661         to get the bound property's kind and check against
1662         PROP_UNDEFINED.
1663
1664 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1665
1666         * gdbtypes.h (TYPE_LOW_BOUND, TYPE_HIGH_BOUND): Remove.  Update
1667         all callers to use type::range_bounds followed by
1668         dynamic_prop::{low,high}.
1669
1670 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1671
1672         * gdbtypes.h (struct dynamic_prop) <kind, set_undefined,
1673         const_val, set_const_val, baton, set_locexpr, set_loclist,
1674         set_addr_offset, variant_parts, set_variant_parts,
1675         original_type, set_original_type>: New methods.
1676         <kind>: Rename to...
1677         <m_kind>: ... this.  Update all users to use the new methods
1678         instead.
1679         <data>: Rename to...
1680         <m_data>: ... this.  Update all users to use the new methods
1681         instead.
1682
1683 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1684
1685         * gdbtypes.c (get_discrete_bounds): Return failure if
1686         the range type's bounds are not both defined and constant
1687         values.
1688         (get_array_bounds): Update comment.  Remove undefined bound check.
1689
1690 2020-07-12  Simon Marchi  <simon.marchi@polymtl.ca>
1691
1692         * gdbtypes.h (TYPE_RANGE_DATA): Remove.  Update callers to use
1693         the type::bounds method directly.
1694
1695 2020-07-12  Simon Marchi  <simon.marchi@efficios.com>
1696
1697         * gdbtypes.h (struct type) <bounds, set_bounds>: New methods.
1698         (TYPE_RANGE_DATA): Use type::bounds.  Change all uses that
1699         are used to set the range type's bounds to use set_bounds.
1700
1701 2020-07-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1702
1703         * exec.c (_initialize_exec): Update exec-file-mismatch help.
1704
1705 2020-07-10  Pedro Alves  <pedro@palves.net>
1706
1707         * gdbthread.h (inferior_ref): Define.
1708         (scoped_restore_current_thread) <m_thread>: Now a thread_info_ref.
1709         (scoped_restore_current_thread) <m_inf>: Now an inferior_ref.
1710         * thread.c
1711         (scoped_restore_current_thread::restore):
1712         Adjust to gdb::ref_ptr.
1713         (scoped_restore_current_thread::~scoped_restore_current_thread):
1714         Remove manual decref handling.
1715         (scoped_restore_current_thread::scoped_restore_current_thread):
1716         Adjust to use
1717         inferior_ref::new_reference/thread_info_ref::new_reference.
1718         Incref the thread before calling get_frame_id instead of after.
1719         Let TARGET_CLOSE_ERROR propagate.
1720
1721 2020-07-10  Pedro Alves  <pedro@palves.net>
1722
1723         * frame-tailcall.c (dwarf2_tailcall_sniffer_first): Only swallow
1724         NO_ENTRY_VALUE_ERROR / MEMORY_ERROR / OPTIMIZED_OUT_ERROR /
1725         NOT_AVAILABLE_ERROR.
1726         * value.c (value_optimized_out): Only swallow MEMORY_ERROR /
1727         OPTIMIZED_OUT_ERROR / NOT_AVAILABLE_ERROR.
1728
1729 2020-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1730             Pedro Alves  <pedro@palves.net>
1731
1732         PR gdb/26199
1733         * infrun.c (threads_are_resumed_pending_p): Delete.
1734         (do_target_wait): Remove threads_are_executing and
1735         threads_are_resumed_pending_p checks from the inferior_matches
1736         lambda.  Update comments.
1737
1738 2020-07-10  Pedro Alves  <pedro@palves.net>
1739
1740         PR gdb/26199
1741         * infrun.c (handle_no_resumed): Transfer terminal to inferior with
1742         executing threads.
1743
1744 2020-07-10  Pedro Alves  <pedro@palves.net>
1745
1746         PR gdb/26199
1747         * infrun.c (handle_no_resumed): Handle multiple targets.
1748
1749 2020-07-10  Pedro Alves  <pedro@palves.net>
1750
1751         PR gdb/26199
1752         * infrun.c (prepare_to_wait): Check target_can_async_p instead of
1753         target_is_async_p.
1754
1755 2020-07-10  Pedro Alves  <pedro@palves.net>
1756
1757         PR gdb/26199
1758         * target.c (target_pass_ctrlc): Look at the inferior's non-exited
1759         threads, not all threads.
1760
1761 2020-07-10  Pedro Alves  <pedro@palves.net>
1762
1763         PR gdb/26199
1764         * remote.c (remote_target::open_1): Pass remote target pointer as
1765         data to create_async_event_handler.
1766         (remote_async_inferior_event_handler): Mark async event handler
1767         before returning if the remote target still has either pending
1768         events or unacknowledged notifications.
1769
1770 2020-07-10  John Baldwin  <jhb@FreeBSD.org>
1771
1772         * fbsd-nat.h (fbsd_nat_target::supports_multi_process): New
1773         declaration.
1774         * fbsd-nat.c (fbsd_nat_target::supports_multi_process): New
1775         function.
1776
1777 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1778
1779         * inf-ptrace.c (inf_ptrace_target::wait): Don't compare against
1780         inferior_ptid.
1781
1782 2020-07-09  John Baldwin  <jhb@FreeBSD.org>
1783
1784         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_ARGC,
1785         AT_FREEBSD_ARGV, AT_FREEBSD_ENVC, AT_FREEBSD_ENVV,
1786         AT_FREEBSD_PS_STRINGS.
1787
1788 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
1789
1790         * auto-load.c (auto_load_objfile_script_1): Convert drive part
1791         of debugfile path on Windows.
1792
1793 2020-07-08  John Baldwin  <jhb@FreeBSD.org>
1794
1795         * fbsd-nat.c (fbsd_nat_target::find_memory_regions): Rename 'obfd'
1796         argument to 'data'.
1797
1798 2020-07-08  Tom Tromey  <tromey@adacore.com>
1799
1800         * ada-lang.c (ada_exception_message_1): Use read_memory.
1801
1802 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         PR python/22748
1805         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Remove
1806         special handling for inline frames.
1807         * findvar.c (value_of_register_lazy): Skip inline frames when
1808         creating lazy register values.
1809         * frame.c (frame_id_computed_p): Delete definition.
1810         * frame.h (frame_id_computed_p): Delete declaration.
1811
1812 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * NEWS: Mention additions to Python API.
1815         * python/py-arch.c (archpy_register_groups): New function.
1816         (arch_object_methods): Add 'register_groups' method.
1817         * python/py-registers.c (reggroup_iterator_object): New struct.
1818         (reggroup_object): New struct.
1819         (gdbpy_new_reggroup): New function.
1820         (gdbpy_reggroup_to_string): New function.
1821         (gdbpy_reggroup_name): New function.
1822         (gdbpy_reggroup_iter): New function.
1823         (gdbpy_reggroup_iter_next): New function.
1824         (gdbpy_new_reggroup_iterator): New function
1825         (gdbpy_initialize_registers): Register new types.
1826         (reggroup_iterator_object_type): Define new Python type.
1827         (gdbpy_reggroup_getset): New static global.
1828         (reggroup_object_type): Define new Python type.
1829         * python/python-internal.h
1830
1831 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-registers.c
1834         * python/py-arch.c (archpy_registers): New function.
1835         (arch_object_methods): Add 'registers' method.
1836         * python/py-registers.c: New file.
1837         * python/python-internal.h
1838         (gdbpy_new_register_descriptor_iterator): Declare.
1839         (gdbpy_initialize_registers): Declare.
1840         * python/python.c (do_start_initialization): Call
1841         gdbpy_initialize_registers.
1842         * NEWS: Mention additions to the Python API.
1843
1844 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1845
1846         * NEWS: Mention new Python API method.
1847         * python/py-unwind.c (pending_framepy_architecture): New function.
1848         (pending_frame_object_methods): Add architecture method.
1849
1850 2020-07-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1851
1852         * gdbarch.c: Regenerate.
1853         * gdbarch.h: Regenerate.
1854         * gdbarch.sh (deprecated_set_gdbarch_data): Delete.
1855         (gdbarch_data): Use internal_error for the case where
1856         deprecated_set_gdbarch_data was originally needed.
1857         * ia64-libunwind-tdep.c (libunwind_descr_init): Update parameters,
1858         and use passed in obstack.
1859         (libunwind_frame_set_descr): Should no longer get back NULL from
1860         gdbarch_data.
1861         (_initialize_libunwind_frame): Register as a pre-init gdbarch data
1862         type.
1863         * user-regs.c (user_regs_init): Update parameters, and use passed
1864         in obstack.
1865         (user_reg_add): Should no longer get back NULL from gdbarch_data.
1866         (_initialize_user_regs): Register as a pre-init gdbarch data type.
1867
1868 2020-07-06  Tom de Vries  <tdevries@suse.de>
1869
1870         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
1871         End-Of-Sequence in lte_is_less_than.
1872         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
1873         "gdb: Don't reorder line table entries too much when sorting".
1874
1875 2020-07-06  Tom de Vries  <tdevries@suse.de>
1876
1877         PR tui/26205
1878         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
1879
1880 2020-07-05  Tom de Vries  <tdevries@suse.de>
1881
1882         PR build/26187
1883         * inferior.h (struct infcall_suspend_state_deleter): If available, use
1884         std::uncaught_exceptions instead of deprecated
1885         std::uncaught_exception.
1886
1887 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1888
1889         * macroexp.h (macro_stringify): Return
1890         gdb::unique_xmalloc_ptr<char>.
1891         * macroexp.c (macro_stringify): Likewise.
1892         * macrotab.c (fixup_definition): Update.
1893
1894 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1895
1896         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
1897         (lex_one_token): Update.
1898         * macroexp.c (struct macro_buffer) <release>: Return
1899         gdb::unique_xmalloc_ptr<char>.
1900         (macro_stringify): Update.
1901         (macro_expand): Update.
1902         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
1903         * macroexp.h (macro_expand_next): Likewise.
1904
1905 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
1906
1907         * macroexp.h (macro_lookup_ftype): Remove.
1908         (macro_expand, macro_expand_once, macro_expand_next): Remove
1909         lookup function parameters, add scope parameter.
1910         * macroexp.c (scan, substitute_args, expand, maybe_expand,
1911         macro_expand, macro_expand_once, macro_expand_next): Likewise.
1912         * macroscope.h (standard_macro_lookup): Change parameter type
1913         to macro_scope.
1914         * macroscope.c (standard_macro_lookup): Likewise.
1915         * c-exp.y (lex_one_token): Update.
1916         * macrocmd.c (macro_expand_command): Likewise.
1917         (macro_expand_once_command): Likewise.
1918
1919 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1920
1921         * inf-loop.c (inferior_event_handler): Remove client_data param.
1922         * inf-loop.h (inferior_event_handler): Likewise.
1923         * infcmd.c (step_1): Adjust.
1924         * infrun.c (proceed): Adjust.
1925         (fetch_inferior_event): Remove client_data param.
1926         (infrun_async_inferior_event_handler): Adjust.
1927         * infrun.h (fetch_inferior_event): Remove `void *` param.
1928         * linux-nat.c (handle_target_event): Adjust.
1929         * record-btrace.c (record_btrace_handle_async_inferior_event):
1930         Adjust.
1931         * record-full.c (record_full_async_inferior_event_handler):
1932         Adjust.
1933         * remote.c (remote_async_inferior_event_handler): Adjust.
1934
1935 2020-07-01  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
1938         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
1939
1940 2020-07-01  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
1943         tui_gen_win_info.
1944         (tui_win_info::make_window): Merge with
1945         tui_gen_win_info::make_window.
1946         (tui_win_info::make_visible): Move from tui_gen_win_info.
1947         * tui/tui-win.c (tui_win_info::max_width): Move from
1948         tui_gen_win_info.
1949         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
1950         type.
1951         <window_factory>: Likewise.
1952         * tui/tui-layout.c (tui_win_info::resize): Move from
1953         tui_gen_win_info.
1954         (make_standard_window): Change return type.
1955         (get_locator_window, tui_get_window_by_name): Likewise.
1956         (tui_layout_window::apply): Remove a cast.
1957         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
1958         (struct tui_win_info): Merge with tui_gen_win_info.
1959         (struct tui_gen_win_info): Remove.
1960
1961 2020-07-01  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-stack.h (struct tui_locator_window): Derive from
1964         tui_win_info.
1965         <do_scroll_horizontal, do_scroll_vertical>: New methods.
1966         <can_box>: New method.
1967
1968 2020-07-01  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-stack.h (struct tui_locator_window): Remove body.
1971
1972 2020-07-01  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-regs.c (tui_data_window::display_registers_from)
1975         (tui_data_window::display_registers_from)
1976         (tui_data_window::first_data_item_displayed)
1977         (tui_data_window::delete_data_content_windows): Update.
1978         (tui_data_window::refresh_window, tui_data_window::no_refresh):
1979         Remove.
1980         (tui_data_window::check_register_values): Update.
1981         (tui_data_item_window::rerender): Add parameters.  Update.
1982         (tui_data_item_window::refresh_window): Remove.
1983         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
1984         virtual.
1985         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
1986         tui_gen_win_info.
1987         <refresh_window, max_height, min_height>: Remove.
1988         <rerender>: Add parameters.
1989         <x, y, visible>: New members.
1990         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
1991         <m_item_width>: New member.
1992
1993 2020-07-01  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-regs.c (tui_data_window::show_register_group)
1996         (tui_data_window::check_register_values): Update.
1997         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
1998         from item_no.
1999
2000 2020-07-01  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
2003         useless "if".
2004
2005 2020-07-01  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2008         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
2009
2010 2020-07-01  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
2013         * tui/tui-winsource.h (enum tui_line_or_address_kind)
2014         (struct tui_line_or_address): Move from tui-data.h.
2015         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
2016         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
2017         (tui_cmd_window, tui_source_window_base, tui_source_window)
2018         (tui_disasm_window): Don't declare.
2019         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
2020         to tui-winsource.h.
2021         (SINGLE_KEY): Move to tui-stack.c.
2022
2023 2020-07-01  Tom Tromey  <tom@tromey.com>
2024
2025         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
2026         std::string.
2027         * tui/tui-regs.c (class tab_expansion_file): New.
2028         (tab_expansion_file::write): New method.
2029         (tui_register_format): Change return type.  Use
2030         tab_expansion_file.
2031         (tui_get_register, tui_data_window::display_registers_from)
2032         (tui_data_item_window::rerender): Update.
2033         * tui/tui-io.h (tui_expand_tabs): Don't declare.
2034         * tui/tui-io.c (tui_expand_tabs): Remove.
2035
2036 2020-07-01  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
2039
2040 2020-07-01  Fangrui Song  <maskray@google.com>
2041
2042         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
2043
2044 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
2045
2046         * dwarf2/read.c (set_die_type): Removed conditions to restrict
2047         forms for DW_AT_associated and DW_AT_allocated attributes,
2048         which is already checked in function attr_to_dynamic_prop.
2049
2050 2020-06-30  Tom Tromey  <tromey@adacore.com>
2051
2052         * dwarf2/read.c (quirk_rust_enum): Correctly call
2053         alloc_rust_variant for default-less enum.
2054
2055 2020-06-30  Tom Tromey  <tromey@adacore.com>
2056
2057         PR build/26183:
2058         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
2059         gdb::to_string.
2060
2061 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
2062
2063         * gdbarch.sh (displaced_step_copy_insn): Update doc.
2064         * gdbarch.h: Re-generate.
2065
2066 2020-06-28  Tom Tromey  <tom@tromey.com>
2067
2068         * command.h (cmd_types): Remove.
2069         (cmd_type): Don't declare.
2070         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
2071         typedef.
2072         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
2073         * cli/cli-decode.c (cmd_type): Remove.
2074
2075 2020-06-27  Pedro Alves  <palves@redhat.com>
2076
2077         * fork-child.c (prefork_hook): Adjust.
2078         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
2079         Delete.
2080         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
2081         * inferior.c (inferior::set_tty, inferior::tty): New methods.
2082         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
2083         Remove declarations.
2084         (struct inferior) <set_tty, tty>: New methods.
2085         (struct inferior) <terminal>: Rename to ...
2086         (struct inferior) <m_terminal>: ... this and make private.
2087         * main.c (captured_main_1): Adjust.
2088         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
2089         (mi_cmd_inferior_tty_show): Adjust.
2090         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
2091         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
2092
2093 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
2094
2095         * configure.ac: Add --enable-libctf: handle --disable-static
2096         properly.
2097         * acinclude.m4: sinclude ../config/enable.m4.
2098         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
2099         (LIBCTF): Substitute in.
2100         (CTF_DEPS): New, likewise.
2101         (CLIBS): libctf needs symbols from libbfd: move earlier.
2102         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
2103         flags.
2104         * ctfread.c: Surround in ENABLE_LIBCTF.
2105         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
2106         * configure: Regenerate.
2107         * config.in: Likewise.
2108
2109 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
2110
2111         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
2112
2113 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
2114
2115         * inferior.h (struct inferior) <terminal>: Change type to
2116         gdb::unique_xmalloc_ptr<char>.
2117         * inferior.c (inferior::~inferior): Don't free inf->terminal.
2118         * infcmd.c (set_inferior_io_terminal): Don't free terminal
2119         field, adjust to unique pointer.
2120         (get_inferior_io_terminal): Adjust to unique pointer.
2121
2122 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * riscv-tdep.c (riscv_print_registers_info): Loop over all
2125         registers, not just the known core set of registers.
2126
2127 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
2130         fflags, frm, and fcsr registers.
2131         (riscv_register_reggroup_p): Remove unknown CSRs from save and
2132         restore groups.
2133         (riscv_tdesc_unknown_reg): New function.
2134         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
2135         tdesc_use_registers.
2136         * riscv-tdep.h (struct gdbarch_tdep): Add
2137         unknown_csrs_first_regnum, unknown_csrs_count,
2138         duplicate_fflags_regnum, duplicate_frm_regnum, and
2139         duplicate_fcsr_regnum fields.
2140
2141 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * target-descriptions.c (tdesc_use_registers): Add new parameter a
2144         callback, use the callback (when not null) to help number unknown
2145         registers.
2146         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
2147         (tdesc_use_registers): Add extra parameter to declaration.
2148
2149 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2150
2151         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
2152         in the file.
2153         (class riscv_pending_register_alias): Likewise.
2154         (riscv_register_feature::register_info): Change 'required_p' field
2155         to 'required', and change its type.  Add 'check' member function.
2156         (riscv_register_feature::register_info::check): Define new member
2157         function.
2158         (riscv_xreg_feature): Change initialisation of 'required' field.
2159         (riscv_freg_feature): Likewise.
2160         (riscv_virtual_feature): Likewise.
2161         (riscv_csr_feature): Likewise.
2162         (riscv_check_tdesc_feature): Take extra parameter, the csr
2163         tdesc_feature, rewrite the function to use the new
2164         riscv_register_feature::register_info::check function.
2165         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
2166
2167 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         * features/Makefile: Remove all references to the deleted files
2170         below.
2171         * features/riscv/32bit-csr.c: Deleted.
2172         * features/riscv/32bit-csr.xml: Deleted.
2173         * features/riscv/64bit-csr.c: Deleted.
2174         * features/riscv/64bit-csr.xml: Deleted.
2175         * features/riscv/rebuild-csr-xml.sh: Deleted.
2176
2177 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
2180         whitespace error for declaration of names member variable.
2181         (struct riscv_register_feature): Add new prefer_first_name member
2182         variable, and fix whitespace error in declaration of registers.
2183         (riscv_xreg_feature): Initialize prefer_first_name field.
2184         (riscv_freg_feature): Likewise.
2185         (riscv_virtual_feature): Likewise.
2186         (riscv_csr_feature): Likewise.
2187         (riscv_register_name): Expand on comments.  Remove register name
2188         modifications for CSR and virtual registers.
2189
2190 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
2193         errors.
2194
2195 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
2198         riscv-opc.h.
2199         (class riscv_pending_register_alias): New class.
2200         (riscv_check_tdesc_feature): Take vector of pending aliases and
2201         populate it as appropriate.
2202         (riscv_setup_register_aliases): Delete.
2203         (riscv_gdbarch_init): Create vector of pending aliases and pass it
2204         to riscv_check_tdesc_feature in all cases.  Use the vector to
2205         create the register aliases.
2206
2207 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2208
2209         * sol2-tdep.c (sol2_static_transform_name): Remove.
2210         (sol2_init_abi): Don't register it.
2211         * gdbarch.sh (static_transform_name): Remove.
2212         * gdbarch.c, gdbarch.h: Regenerate.
2213
2214         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
2215         gdbarch_static_transform_name.
2216         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
2217         * stabsread.c (define_symbol) <'X'>: Remove.
2218         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
2219         handling.
2220         <'V'>: Likewise.
2221         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
2222         <'S'>: Remove call to gdbarch_static_transform_name.
2223
2224 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2225
2226         * procfs.c (procfs_pre_trace): New function.
2227         (procfs_target::create_inferior): Pass it to fork_inferior.
2228
2229 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2230
2231         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
2232         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
2233         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
2234         sol2-tdep.o, sparc-sol2-tdep.o.
2235         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
2236         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
2237         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
2238         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
2239
2240 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2241
2242         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
2243         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
2244         Call sol2_init_abi.
2245         Remove calls to set_gdbarch_skip_solib_resolver,
2246         set_gdbarch_core_pid_to_str.
2247         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
2248         (i386_sol2_static_transform_name): Remove.
2249         (i386_sol2_init_abi): Call sol2_init_abi.
2250         Remove calls to set_gdbarch_sofun_address_maybe_missing,
2251         set_gdbarch_static_transform_name,
2252         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
2253         Use sol2_sigtramp_p.
2254         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
2255         (sol2_sigtramp_p): New function.
2256         (sol2_static_transform_name): New function.
2257         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
2258         (sol2_init_abi): New function.
2259         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
2260         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
2261         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
2262         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
2263         (sparc_sol2_static_transform_name): Remove.
2264         (sparc32_sol2_init_abi): Call sol2_init_abi.
2265         Remove calls to set_gdbarch_sofun_address_maybe_missing,
2266         set_gdbarch_static_transform_name,
2267         set_gdbarch_skip_solib_resolver,
2268         set_gdbarch_core_pid_to_str.
2269         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
2270         (sparc_sol2_static_transform_name): Remove
2271         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
2272         call sol2_sigtramp_p.
2273         (sparc64_sol2_init_abi): Call sol2_init_abi.
2274         Remove calls to set_gdbarch_sofun_address_maybe_missing,
2275         set_gdbarch_static_transform_name,
2276         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
2277
2278 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2279
2280         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
2281         * exec.c (validate_exec_file): If from_tty, set both
2282         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
2283         * symfile.c (symbol_file_add_with_addrs): if always_confirm
2284         and from_tty, unconditionally ask a confirmation.
2285
2286 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * target-descriptions.c (tdesc_architecture_name): Protect against
2289         NULL pointer dereference.
2290         (maint_print_xml_tdesc_cmd): New function.
2291         (_initialize_target_descriptions): Register new 'maint print
2292         xml-tdesc' command and give it the filename completer.
2293         * NEWS: Mention new 'maint print xml-tdesc' command.
2294
2295 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2296
2297         * target-descriptions.c (class tdesc_compatible_info): New class.
2298         (struct target_desc): Change type of compatible vector.
2299         (tdesc_compatible_p): Update for change in type of
2300         target_desc::compatible.
2301         (tdesc_compatible_info_list): New function.
2302         (tdesc_compatible_info_arch_name): New function.
2303         (tdesc_add_compatible): Update for change in type of
2304         target_desc::compatible.
2305         (print_c_tdesc::visit_pre): Likewise.
2306
2307 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
2310         whitespace to underscore.
2311         (maint_print_c_tdesc_cmd): Use fake filename for target
2312         descriptions that came from the target.
2313         (_initialize_target_descriptions): Add filename command completion
2314         for 'maint print c-tdesc'.
2315
2316 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
2317
2318         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
2319         lines.
2320
2321 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
2322
2323         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
2324         lines.
2325         (dwarf2_find_location_expression): Likewise.
2326         (call_site_parameter_matches): Likewise.
2327         (dwarf2_compile_expr_to_ax): Likewise.
2328         (disassemble_dwarf_expression): Likewise.
2329         (loclist_describe_location): Likewise.
2330
2331 2020-06-23  Pedro Alves  <palves@redhat.com>
2332
2333         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
2334         progspace-and-thread.h.  Include scoped-mock-context.h instead.
2335         (register_to_value_test): Use scoped_mock_context.
2336         * regcache.c: Include "scoped-mock-context.h".
2337         (cooked_read_test): Don't error out if a target is already pushed.
2338         Use scoped_mock_context.  Adjust.
2339         * scoped-mock-context.h: New file.
2340
2341 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
2344         initializer.
2345         (ada_language::is_string_type_p): New member function.
2346         * c-lang.c (c_language_data): Delete la_is_string_type_p
2347         initializer.
2348         (cplus_language_data): Likewise.
2349         (asm_language_data): Likewise.
2350         (minimal_language_data): Likewise.
2351         * d-lang.c (d_language_data): Likewise.
2352         * f-lang.c (f_is_string_type_p): Delete function, implementation
2353         moved to f_language::is_string_type_p.
2354         (f_language_data): Delete la_is_string_type_p initializer.
2355         (f_language::is_string_type_p): New member function,
2356         implementation from f_is_string_type_p.
2357         * go-lang.c (go_is_string_type_p): Delete function, implementation
2358         moved to go_language::is_string_type_p.
2359         (go_language_data): Delete la_is_string_type_p initializer.
2360         (go_language::is_string_type_p): New member function,
2361         implementation from go_is_string_type_p.
2362         * language.c (language_defn::is_string_type_p): Define new member
2363         function.
2364         (default_is_string_type_p): Make static, add comment copied from
2365         header file.
2366         (unknown_language_data): Delete la_is_string_type_p initializer.
2367         (unknown_language::is_string_type_p): New member function.
2368         (auto_language_data): Delete la_is_string_type_p initializer.
2369         (auto_language::is_string_type_p): New member function.
2370         * language.h (language_data): Delete la_is_string_type_p field.
2371         (language_defn::is_string_type_p): Declare new function.
2372         (default_is_string_type_p): Delete desclaration, move comment to
2373         definition.
2374         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
2375         moved to m2_language::is_string_type_p.
2376         (m2_language_data): Delete la_is_string_type_p initializer.
2377         (m2_language::is_string_type_p): New member function,
2378         implementation from m2_is_string_type_p.
2379         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
2380         initializer.
2381         * opencl-lang.c (opencl_language_data): Likewise.
2382         * p-lang.c (pascal_is_string_type_p): Delete function,
2383         implementation moved to pascal_language::is_string_type_p.
2384         (pascal_language_data): Delete la_is_string_type_p initializer.
2385         (pascal_language::is_string_type_p): New member function,
2386         implementation from pascal_is_string_type_p.
2387         * rust-lang.c (rust_is_string_type_p): Delete function,
2388         implementation moved to rust_language::is_string_type_p.
2389         (rust_language_data): Delete la_is_string_type_p initializer.
2390         (rust_language::is_string_type_p): New member function,
2391         implementation from rust_is_string_type_p.
2392         * valprint.c (val_print_scalar_or_string_type_p): Update call to
2393         is_string_type_p.
2394
2395 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * ada-lang.c (ada_language_data): Delete la_print_typedef
2398         initializer.
2399         (ada_language::print_typedef): New member function.
2400         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
2401         (cplus_language_data): Likewise.
2402         (asm_language_data): Likewise.
2403         (minimal_language_data): Likewise.
2404         * d-lang.c (d_language_data): Likewise.
2405         * f-lang.c (f_language_data): Likewise.
2406         (f_language::print_typedef): New member function.
2407         * go-lang.c (go_language_data): Delete la_print_typedef
2408         initializer.
2409         * language.c (language_defn::print_typedef): Define member
2410         function.
2411         (unknown_language_data): Delete la_print_typedef initializer.
2412         (unknown_language::print_typedef): New member function.
2413         (auto_language_data): Delete la_print_typedef initializer.
2414         (auto_language::print_typedef): New member function.
2415         * language.h (language_data): Delete la_print_typedef field.
2416         (language_defn::print_typedef): Declare new member function.
2417         (LA_PRINT_TYPEDEF): Update call to print_typedef.
2418         (default_print_typedef): Delete declaration.
2419         * m2-lang.c (m2_language_data): Delete la_print_typedef
2420         initializer.
2421         (m2_language::print_typedef): New member function.
2422         * objc-lang.c (objc_language_data): Delete la_print_typedef
2423         initializer.
2424         * opencl-lang.c (opencl_language_data): Likewise.
2425         * p-lang.c (pascal_language_data): Likewise.
2426         (pascal_language::print_typedef): New member function.
2427         * rust-lang.c (rust_print_typedef): Delete function,
2428         implementation moved to rust_language::print_typedef.
2429         (rust_language): Delete la_print_typedef initializer.
2430         (rust_language::print_typedef): New member function,
2431         implementation from rust_print_typedef.
2432         * typeprint.c (default_print_typedef): Delete.
2433
2434 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2435
2436         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
2437         (ada_language::printstr): New member function.
2438         * c-lang.c (c_language_data): Delete la_printstr initializer.
2439         (cplus_language_data): Likewise.
2440         (asm_language_data): Likewise.
2441         (minimal_language_data): Likewise.
2442         * d-lang.c (d_language_data): Likewise.
2443         * f-lang.c (f_printstr): Rename to f_language::printstr.
2444         (f_language_data): Delete la_printstr initializer.
2445         (f_language::printstr): New member function, implementation from
2446         f_printstr.
2447         * go-lang.c (go_language_data): Delete la_printstr initializer.
2448         * language.c (language_defn::printstr): Define new member
2449         function.
2450         (unk_lang_printstr): Delete.
2451         (unknown_language_data): Delete la_printstr initializer.
2452         (unknown_language::printstr): New member function.
2453         (auto_language_data): Delete la_printstr initializer.
2454         (auto_language::printstr): New member function.
2455         * language.h (language_data): Delete la_printstr field.
2456         (language_defn::printstr): Declare new member function.
2457         (LA_PRINT_STRING): Update call to printstr.
2458         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
2459         (m2_language_data): Delete la_printstr initializer.
2460         (m2_language::printstr): New member function, implementation from
2461         m2_printstr.
2462         * objc-lang.c (objc_language_data): Delete la_printstr
2463         initializer.
2464         * opencl-lang.c (opencl_language_data): Likewise.
2465         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
2466         (pascal_language_data): Delete la_printstr initializer.
2467         (pascal_language::printstr): New member function, implementation
2468         from pascal_printstr.
2469         * p-lang.h (pascal_printstr): Delete declaration.
2470         * rust-lang.c (rust_printstr): Update header comment.
2471         (rust_language_data): Delete la_printstr initializer.
2472         (rust_language::printstr): New member function.
2473
2474 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
2477         (ada_language::printchar): New member function.
2478         * c-lang.c (c_language_data): Delete la_printchar initializer.
2479         (cplus_language_data): Likewise.
2480         (asm_language_data): Likewise.
2481         (minimal_language_data): Likewise.
2482         * d-lang.c (d_language_data): Likewise.
2483         * f-lang.c (f_printchar): Rename to f_language::printchar.
2484         (f_language_data): Delete la_printchar initializer.
2485         (f_language::printchar): New member function, implementation from
2486         f_printchar.
2487         * go-lang.c (go_language_data): Delete la_printchar initializer.
2488         * language.c (unk_lang_printchar): Delete.
2489         (language_defn::printchar): Define new member function.
2490         (unknown_language_data): Delete la_printchar initializer.
2491         (unknown_language::printchar): New member function.
2492         (auto_language_data): Delete la_printchar initializer.
2493         (auto_language::printchar): New member function.
2494         * language.h (language_data): Delete la_printchar field.
2495         (language_defn::printchar): Declare new member function.
2496         (LA_PRINT_CHAR): Update call to printchar.
2497         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
2498         (m2_language::printchar): New member function.
2499         * objc-lang.c (objc_language_data): Delete la_printchar
2500         initializer.
2501         * opencl-lang.c (opencl_language_data): Likewise.
2502         * p-lang.c (pascal_language_data): Delete la_printchar
2503         initializer.
2504         (pascal_language::printchar): New member function.
2505         * rust-lang.c (rust_printchar): Rename to
2506         rust_language::printchar.
2507         (rust_language_data): Delete la_printchar initializer.
2508         (rust_language::printchar): New member function, implementation
2509         from rust_printchar.
2510
2511 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2512
2513         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
2514         (ada_language_data): Delete la_emitchar initializer.
2515         (ada_language::emitchar): New member function, implementation from
2516         emit_char.
2517         * c-lang.c (c_language_data): Delete la_emitchar initializer.
2518         (cplus_language_data): Likewise.
2519         (asm_language_data): Likewise.
2520         (minimal_language_data): Likewise.
2521         * d-lang.c (d_language_data): Likewise.
2522         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
2523         (f_language_data): Delete la_emitchar initializer.
2524         (f_language::emitchar): New member function, implementation from
2525         f_emit_char.
2526         * go-lang.c (go_language_data): Delete la_emitchar initializer.
2527         * language.c (unk_lang_emit_char): Delete.
2528         (language_defn::emitchar): New member function definition.
2529         (unknown_language_data): Delete la_emitchar initializer.
2530         (unknown_language::emitchar): New member function.
2531         (auto_language_data): Delete la_emitchar initializer.
2532         (auto_language::emitchar): New member function.
2533         * language.h (language_data): Delete la_emitchar field.
2534         (language_defn::emitchar): New member field declaration.
2535         (LA_EMIT_CHAR): Update call to emitchar.
2536         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
2537         (m2_language_data): Delete la_emitchar initializer.
2538         (m2_language::emitchar): New member function, implementation from
2539         m2_emit_char.
2540         * objc-lang.c (objc_language_data): Delete la_emitchar
2541         initializer.
2542         * opencl-lang.c (opencl_language_data): Likewise.
2543         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
2544         (pascal_language_data): Delete la_emitchar initializer.
2545         (pascal_language::emitchar): New member function, implementation
2546         from pascal_emit_char.
2547         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
2548         (rust_language_data): Delete la_emitchar initializer.
2549         (rust_language::emitchar): New member function, implementation
2550         from rust_emitchar.
2551
2552 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2553
2554         * ada-lang.c (resolve): Rename to ada_language::post_parser.
2555         (ada_language_data): Delete la_post_parser initializer.
2556         (ada_language::post_parser): New member function.
2557         * c-lang.c (c_language_data): Delete la_post_parser initializer.
2558         (cplus_language_data): Likewise.
2559         (asm_language_data): Likewise.
2560         (minimal_language_data): Likewise.
2561         * d-lang.c (d_language_data): Likewise.
2562         * f-lang.c (f_language_data): Likewise.
2563         * go-lang.c (go_language_data): Likewise.
2564         * language.c (unknown_language_data): Likewise.
2565         (auto_language_data): Likewise.
2566         * language.h (language_data): Delete la_post_parser field.
2567         (language_defn::post_parser): New member function.
2568         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
2569         * objc-lang.c (objc_language_data): Likewise.
2570         * opencl-lang.c (opencl_language_data): Likewise.
2571         * p-lang.c (pascal_language_data): Likewise.
2572         * parse.c (parse_exp_in_context): Update call to post_parser.
2573         (null_post_parser): Delete definition.
2574         * parser-defs.h (null_post_parser): Delete declaration.
2575         * rust-lang.c (rust_language_data): Delete la_post_parser
2576         initializer.
2577
2578 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * ada-lang.c (parse): Rename to ada_language::parser.
2581         (ada_language_data): Delete la_parser initializer.
2582         (ada_language::parser): New member function, implementation from
2583         parse.
2584         * c-lang.c (c_language_data): Delete la_parser initializer.
2585         (cplus_language_data): Likewise.
2586         (asm_language_data): Likewise.
2587         (minimal_language_data): Likewise.
2588         * d-lang.c (d_language_data): Likewise.
2589         (d_language::parser): New member function.
2590         * f-lang.c (f_language_data): Delete la_parser initializer.
2591         (f_language::parser): New member function.
2592         * go-lang.c (go_language_data): Delete la_parser initializer.
2593         (go_language::parser): New member function.
2594         * language.c (unk_lang_parser): Delete.
2595         (language_defn::parser): Define new member function.
2596         (unknown_language_data): Delete la_parser initializer.
2597         (unknown_language::parser): New member function.
2598         (auto_language_data): Delete la_parser initializer.
2599         (auto_language::parser): New member function.
2600         * language.h (language_data): Delete la_parser field.
2601         (language_defn::parser): Declare new member function.
2602         * m2-lang.c (m2_language_data): Delete la_parser initializer.
2603         (m2_language::parser): New member function.
2604         * objc-lang.c (objc_language_data): Delete la_parser initializer.
2605         * opencl-lang.c (opencl_language_data): Likewise.
2606         * p-lang.c (pascal_language_data): Likewise.
2607         (pascal_language::parser): New member function.
2608         * parse.c (parse_exp_in_context): Update call to parser.
2609         * rust-lang.c (rust_language_data): Delete la_parser initializer.
2610         (rust_language::parser): New member function.
2611
2612 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * top.c (print_gdb_configuration): Print --with-python-libdir
2615         configuration value.
2616
2617 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2618
2619         * NEWS: Mention change to the alias command.
2620
2621 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2622
2623         * cli/cli-cmds.c (lookup_cmd_for_default_args)
2624         (alias_command_completer)
2625         (make_alias_options_def_group): New functions.
2626         (alias_opts, alias_option_defs): New struct and array.
2627         (alias_usage_error): Update usage.
2628         (alias_command): Handles optional DEFAULT-ARGS... arguments.
2629         Use option framework.
2630         (_initialize_cli_cmds): Update alias command help.
2631         Update aliases command help.
2632         (show_user):
2633         Add NULL for new default_args lookup_cmd argument.
2634         (valid_command_p): Rename to validate_aliased_command.
2635         Add NULL for new default_args lookup_cmd argument.  Verify that the
2636         aliased_command has no default args.
2637         * cli/cli-decode.c (help_cmd): Show aliases definitions.
2638         (lookup_cmd_1, lookup_cmd): New argument default_args.
2639         (add_alias_cmd):
2640         Add NULL for new default_args lookup_cmd argument.
2641         (print_help_for_command): Show default args under the layout
2642          alias some_alias = some_aliased_cmd some_alias_default_arg.
2643         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
2644         xfree default_args in destructor.
2645         * cli/cli-script.c (process_next_line, do_define_command):
2646         Add NULL for new default_args lookup_cmd argument.
2647         * command.h: Declare new default_args argument in lookup_cmd
2648         and lookup_cmd_1.
2649         * completer.c (complete_line_internal_1):
2650         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2651         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
2652         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
2653         Likewise.
2654         * infcmd.c (_initialize_infcmd): Likewise.
2655         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
2656         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
2657         * python/py-param.c (add_setshow_generic): Likewise.
2658         * remote.c (_initialize_remote): Likewise.
2659         * top.c (execute_command): Prepend default_args if command has some.
2660         (set_verbose):
2661         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2662         * tracepoint.c (validate_actionline, encode_actions_1):
2663         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
2664
2665 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2666
2667         * jit.c (jit_read_descriptor): Use bool as the return type.
2668         (jit_breakpoint_re_set_internal): Use bool as the return type.
2669         Invert the return value logic; return true if the jit breakpoint
2670         has been successfully initialized.
2671         (jit_inferior_init): Update the call to
2672         jit_breakpoint_re_set_internal.
2673
2674 2020-06-22  Pedro Alves  <palves@redhat.com>
2675
2676         PR gdb/25939
2677         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
2678         Use the current inferior instead.  Don't return
2679         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
2680         wait again.
2681         * sol-thread.c (sol_thread_target::wait): Don't reference
2682         inferior_ptid.
2683         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
2684         (sol_update_thread_list_callback): Use the current inferior's pid
2685         instead of inferior_ptid.
2686
2687 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2688
2689         * procfs.c: Cleanup many comments.
2690
2691         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
2692         (AFTER_WATCHFLAG): Replace by value.
2693
2694         (MAIN_PROC_NAME_FORMAT): Inline ...
2695         (create_procinfo): ... here.
2696
2697         (procfs_debug_inferior): Remove SYS_exec handling.
2698         (syscall_is_exec): Likewise.
2699         (procfs_set_exec_trap): Likewise.
2700
2701         (syscall_is_lwp_exit): Inline in callers.
2702         (syscall_is_exit): Likewise.
2703         (syscall_is_exec): Likewise.
2704         (syscall_is_lwp_create): Likewise.
2705
2706         (invalidate_cache): Remove #if 0 code.
2707
2708         (make_signal_thread_runnable):  Remove.
2709         (procfs_target::resume): Remove #if 0 code.
2710
2711 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2712
2713         PR gdb/25939
2714         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
2715         call ...
2716         (procfs_target::create_inferior): ... here.
2717
2718 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2719
2720         * exec.c (validate_exec_file): Ensure the build-id is up to
2721         date by calling reopen_exec_file (that checks file timestamp
2722         to decide to re-read the file).
2723
2724 2020-06-18  Pedro Alves  <palves@redhat.com>
2725
2726         PR gdb/25412
2727         * gdbthread.h (delete_thread, delete_thread_silent)
2728         (find_thread_ptid): Update comments.
2729         * thread.c (current_thread_): New global.
2730         (is_current_thread): Move higher, and reimplement.
2731         (inferior_thread): Reimplement.
2732         (set_thread_exited): Use bool.  Add assertions.
2733         (add_thread_silent): Simplify thread-reuse handling by always
2734         calling delete_thread.
2735         (delete_thread): Remove intro comment.
2736         (find_thread_ptid): Skip exited threads.
2737         (switch_to_thread_no_regs): Write to current_thread_.
2738         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
2739         INFERIOR_PTID.  Clear current_thread_.
2740
2741 2020-06-18  Pedro Alves  <palves@redhat.com>
2742
2743         * aix-thread.c (pd_update): Use switch_to_thread.
2744
2745 2020-06-18  Pedro Alves  <palves@redhat.com>
2746
2747         * ravenscar-thread.c (ravenscar_thread_target): Update.
2748         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
2749         (ravenscar_thread_target::add_active_thread): ... this.  Don't
2750         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
2751         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
2752
2753 2020-06-18  Pedro Alves  <palves@redhat.com>
2754
2755         * nat/windows-nat.c (current_windows_thread): Remove.
2756         * nat/windows-nat.h (current_windows_thread): Remove.
2757         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
2758         Adjust.
2759         (display_selectors): Adjust to fetch the current
2760         windows_thread_info based on inferior_ptid.
2761         (fake_create_process): No longer write to current_windows_thread.
2762         (windows_nat_target::get_windows_debug_event):
2763         Don't set inferior_ptid or current_windows_thread.
2764         (windows_nat_target::wait): Adjust to not rely on
2765         current_windows_thread.
2766         (do_initial_windows_stuff): Now a method of windows_nat_target.
2767         Switch to the last_ptid thread.
2768         (windows_nat_target::attach): Adjust.
2769         (windows_nat_target::detach): Use switch_to_no_thread instead of
2770         writing to inferior_ptid directly.
2771         (windows_nat_target::create_inferior): Adjust.
2772
2773 2020-06-18  Pedro Alves  <palves@redhat.com>
2774
2775         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
2776
2777 2020-06-18  Pedro Alves  <palves@redhat.com>
2778
2779         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
2780         after creating it, instead of writing to inferior_ptid.  Don't
2781         write to inferior_ptid.
2782
2783 2020-06-18  Pedro Alves  <palves@redhat.com>
2784
2785         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
2786
2787 2020-06-18  Pedro Alves  <palves@redhat.com>
2788
2789         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
2790         it, instead of writing to inferior_ptid.
2791
2792 2020-06-18  Pedro Alves  <palves@redhat.com>
2793
2794         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
2795         to inferior_ptid.
2796
2797 2020-06-18  Pedro Alves  <palves@redhat.com>
2798
2799         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
2800         instead of writing to inferior_ptid directly.
2801
2802 2020-06-18  Pedro Alves  <palves@redhat.com>
2803
2804         * corelow.c (core_target::close): Use switch_to_no_thread instead
2805         of writing to inferior_ptid directly.
2806         (add_to_thread_list, core_target_open): Use switch_to_thread
2807         instead of writing to inferior_ptid directly.
2808
2809 2020-06-18  Pedro Alves  <palves@redhat.com>
2810
2811         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
2812         inferior_ptid.
2813         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
2814         inferior_ptid.
2815         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
2816         inferior_ptid directly.
2817         (darwin_nat_target::init_thread_list): Switch to thread, instead
2818         of writing to inferior_ptid.
2819         (darwin_nat_target::attach): Don't write to inferior_ptid.
2820         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
2821
2822 2020-06-18  Pedro Alves  <palves@redhat.com>
2823
2824         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
2825         thread.
2826         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
2827         Instead use switch_to_thread.
2828         (gnu_nat_target::detach): Use switch_to_no_thread
2829         instead of writing to inferior_ptid directly.  Used passed-in
2830         inferior instead of looking up the inferior by pid.
2831
2832 2020-06-18  Pedro Alves  <palves@redhat.com>
2833
2834         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
2835         inferior_ptid.
2836
2837 2020-06-18  Pedro Alves  <palves@redhat.com>
2838
2839         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
2840         inferior_ptid.
2841         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
2842         thread.
2843         (nto_procfs_target::detach): Avoid referencing
2844         inferior_ptid.  Use switch_to_no_thread instead of writing to
2845         inferior_ptid directly.
2846         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
2847         instead of writing to inferior_ptid directly.
2848         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
2849         to thread.
2850
2851 2020-06-18  Pedro Alves  <palves@redhat.com>
2852
2853         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
2854         after creating it, instead of writing to inferior_ptid.
2855         (gdbsim_target_open): Use switch_to_no_thread instead of writing
2856         to inferior_ptid directly.
2857         (gdbsim_target::wait): Don't write to inferior_ptid.
2858
2859 2020-06-18  Pedro Alves  <palves@redhat.com>
2860
2861         * remote.c (remote_target::remote_notice_new_inferior): Use
2862         switch_to_thread instead of writing to inferior_ptid directly.
2863         (remote_target::add_current_inferior_and_thread): Use
2864         switch_to_no_thread instead of writing to inferior_ptid directly.
2865         (extended_remote_target::attach): Use switch_to_inferior_no_thread
2866         and switch_to_thread instead of using set_current_inferior or
2867         writing to inferior_ptid directly.
2868
2869 2020-06-18  Pedro Alves  <palves@redhat.com>
2870
2871         * tracectf.c (ctf_target_open): Switch to added thread instead of
2872         writing to inferior_ptid directly.
2873         (ctf_target::close): Use switch_to_no_thread instead of writing to
2874         inferior_ptid directly.
2875
2876 2020-06-18  Pedro Alves  <palves@redhat.com>
2877
2878         * tracefile-tfile.c (tfile_target_open): Don't write to
2879         inferior_ptid directly, instead switch to added thread.
2880         (tfile_target::close): Use switch_to_no_thread instead of writing
2881         to inferior_ptid directly.
2882
2883 2020-06-18  Pedro Alves  <palves@redhat.com>
2884
2885         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
2886         (procfs_target::detach): Use switch_to_no_thread
2887         instead of writing to inferior_ptid directly.
2888         (do_attach): Change return type to void.  Switch to the added
2889         thread.
2890         (procfs_target::create_inferior): Switch to the added thread.
2891         (procfs_do_thread_registers): Don't write to inferior_ptid.
2892
2893 2020-06-18  Pedro Alves  <palves@redhat.com>
2894
2895         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
2896         of writing to inferior_ptid.
2897         (scoped_restore_exited_inferior): Delete.
2898         (handle_vfork_child_exec_or_exit): Simplify using
2899         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
2900         instead of writing to inferior_ptid.
2901         (THREAD_STOPPED_BY): Delete.
2902         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
2903         (thread_stopped_by_hw_breakpoint): Delete.
2904         (save_waitstatus): Use
2905         scoped_restore_current_thread+switch_to_thread, and call
2906         target_stopped_by_watchpoint instead of
2907         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
2908         instead of thread_stopped_by_sw_breakpoint, and
2909         target_stopped_by_hw_breakpoint instead of
2910         thread_stopped_by_hw_breakpoint.
2911         (handle_inferior_event)
2912         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
2913         inferior_ptid directly, nor
2914         set_current_inferior/set_current_program_space.  Use
2915         switch_to_thread / switch_to_inferior_no_thread instead.
2916
2917 2020-06-18  Pedro Alves  <palves@redhat.com>
2918
2919         * target.c (generic_mourn_inferior): Use switch_to_no_thread
2920         instead of writing to inferior_ptid.
2921
2922 2020-06-18  Pedro Alves  <palves@redhat.com>
2923
2924         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
2925         added thread.
2926         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
2927         to the added thread.
2928         (inf_ptrace_target::detach_success): Use switch_to_no_thread
2929         instead of writing to inferior_ptid.
2930
2931 2020-06-18  Pedro Alves  <palves@redhat.com>
2932
2933         * gdbarch-selftests.c: Include "progspace-and-thread.h".
2934         (register_to_value_test): Mock a program_space too.  Heap-allocate
2935         the address space.  Don't write to inferior_ptid.  Use
2936         switch_to_thread instead.
2937
2938 2020-06-18  Pedro Alves  <palves@redhat.com>
2939
2940         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
2941         Delete.
2942         (find_signalled_thread()): New, factored out from
2943         linux_make_corefile_notes and adjusted to handle exited threads.
2944         (linux_make_corefile_notes): Adjust to use the new
2945         find_signalled_thread.
2946
2947 2020-06-18  Pedro Alves  <palves@redhat.com>
2948
2949         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
2950         of saving/restoring inferior_ptid.
2951
2952 2020-06-17  Tom Tromey  <tom@tromey.com>
2953
2954         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
2955         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
2956         declare.
2957         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
2958
2959 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
2960
2961         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
2962         of partial symtabs.
2963
2964 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2965
2966         * regformats/reg-arm.dat: Remove.
2967         * regformats/reg-bfin.dat: Remove.
2968         * regformats/reg-cris.dat: Remove.
2969         * regformats/reg-crisv32.dat: Remove.
2970         * regformats/reg-m32r.dat: Remove.
2971         * regformats/reg-tilegx.dat: Remove.
2972         * regformats/reg-tilegx32.dat: Remove.
2973
2974 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2975
2976         * features/Makefile (WHICH): Remove arm files.
2977         * regformats/arm/arm-with-iwmmxt.dat: Remove.
2978         * regformats/arm/arm-with-neon.dat: Remove.
2979         * regformats/arm/arm-with-vfpv2.dat: Remove.
2980         * regformats/arm/arm-with-vfpv3.dat: Remove.
2981
2982 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
2983
2984         * features/Makefile (XMLTOC): Remove rx.xml.
2985
2986 2020-06-17  Pedro Alves  <palves@redhat.com>
2987
2988         * gdbthread.h (thread_control_state) <trap_expected> Update
2989         comments.
2990
2991 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
2994         ada_language::lookup_symbol_nonlocal.
2995         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
2996         (ada_language::lookup_symbol_nonlocal): New member function,
2997         implementation from ada_lookup_symbol_nonlocal.
2998         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
2999         initializer.
3000         (cplus_language_data): Delete la_lookup_symbol_nonlocal
3001         initializer.
3002         (cplus_language::lookup_symbol_nonlocal): New member function.
3003         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
3004         (minimal_language_data) Likewise.
3005         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
3006         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
3007         initializer.
3008         (d_language::lookup_symbol_nonlocal): New member function.
3009         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
3010         initializer.
3011         (f_language::lookup_symbol_nonlocal): New member function.
3012         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
3013         initializer.
3014         * language.c (unknown_language_data): Likewise.
3015         (auto_language_data): Likewise.
3016         * language.h (language_data): Delete la_lookup_symbol_nonlocal
3017         field.
3018         (language_defn::lookup_symbol_nonlocal): New member function.
3019         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
3020         initializer.
3021         * objc-lang.c (objc_language_data): Likewise.
3022         * opencl-lang.c (opencl_language_data): Likewise.
3023         * p-lang.c (pascal_language_data): Likewise.
3024         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
3025         rust_language::lookup_symbol_nonlocal.
3026         (rust_language_data): Delete la_lookup_symbol_nonlocal
3027         initializer.
3028         (rust_language::lookup_symbol_nonlocal): New member function,
3029         implementation from rust_lookup_symbol_nonlocal.
3030         * symtab.c (lookup_symbol_aux): Update call to
3031         lookup_symbol_nonlocal.
3032         (basic_lookup_symbol_nonlocal): Rename to...
3033         (language_defn::lookup_symbol_nonlocal): ...this, and update
3034         header comment.  Remove language_defn parameter, and replace with
3035         uses of `this'.
3036         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
3037
3038 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3039
3040         * ada-lang.c (ada_language_data): Delete la_value_print_inner
3041         initializer.
3042         (ada_language::value_print_inner): New member function.
3043         * c-lang.c (c_language_data): Delete la_value_print_inner
3044         initializer.
3045         (cplus_language_data): Likewise.
3046         (asm_language_data): Likewise.
3047         (minimal_language_data): Likewise.
3048         * d-lang.c (d_language_data): Likewise.
3049         (d_language::value_print_inner): New member function.
3050         * f-lang.c (f_language_data): Delete la_value_print_inner
3051         initializer.
3052         (f_language::value_print_inner): New member function.
3053         * f-lang.h (f_value_print_innner): Rename to...
3054         (f_value_print_inner): ...this (note spelling of 'inner').
3055         * f-valprint.c (f_value_print_innner): Rename to...
3056         (f_value_print_inner): ...this (note spelling of 'inner').
3057         * go-lang.c (go_language_data): Delete la_value_print_inner
3058         initializer.
3059         (go_language::value_print_inner): New member function.
3060         * language.c (language_defn::value_print_inner): Define new member
3061         function.
3062         (unk_lang_value_print_inner): Delete.
3063         (unknown_language_data): Delete la_value_print_inner initializer.
3064         (unknown_language::value_print_inner): New member function.
3065         (auto_language_data): Delete la_value_print_inner initializer.
3066         (auto_language::value_print_inner): New member function.
3067         * language.h (language_data): Delete la_value_print_inner field.
3068         (language_defn::value_print_inner): Delcare new member function.
3069         * m2-lang.c (m2_language_data): Delete la_value_print_inner
3070         initializer.
3071         (m2_language::value_print_inner): New member function.
3072         * objc-lang.c (objc_language_data): Delete la_value_print_inner
3073         initializer.
3074         * opencl-lang.c (opencl_language_data): Likewise.
3075         * p-lang.c (pascal_language_data): Likewise.
3076         (pascal_language::value_print_inner): New member function.
3077         * rust-lang.c (rust_language_data): Delete la_value_print_inner
3078         initializer.
3079         (rust_language::value_print_inner): New member function.
3080         * valprint.c (do_val_print): Update call to value_print_inner.
3081
3082 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3083
3084         * ada-lang.c (ada_language_data): Delete la_value_print
3085         initializer.
3086         (ada_language::value_print): New member function.
3087         * c-lang.c (c_language_data): Delete la_value_print initializer.
3088         (cplus_language_data): Likewise.
3089         (asm_language_data): Likewise.
3090         (minimal_language_data): Likewise.
3091         * d-lang.c (d_language_data): Likewise.
3092         * f-lang.c (f_language_data): Likewise.
3093         * go-lang.c (go_language_data): Likewise.
3094         * language.c (unk_lang_value_print): Delete.
3095         (language_defn::value_print): Define new member function.
3096         (unknown_language_data): Delete la_value_print initializer.
3097         (unknown_language::value_print): New member function.
3098         (auto_language_data): Delete la_value_print initializer.
3099         (auto_language::value_print): New member function.
3100         * language.h (language_data): Delete la_value_print field.
3101         (language_defn::value_print): Declare new member function.
3102         (LA_VALUE_PRINT): Update call to value_print.
3103         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
3104         * objc-lang.c (objc_language_data): Likewise.
3105         * opencl-lang.c (opencl_language_data): Likewise.
3106         * p-lang.c (pascal_language_data): Likewise.
3107         (pascal_language::value_print): New member function.
3108         * rust-lang.c (rust_language_data): Delete la_value_print
3109         initializer.
3110
3111 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * ada-lang.c (ada_watch_location_expression): Rename to
3114         ada_language::watch_location_expression.
3115         (ada_language_data): Delete la_watch_location_expression
3116         initializer.
3117         (ada_language::watch_location_expression): New member function,
3118         implementation from ada_watch_location_expression.
3119         * breakpoint.c (watch_command_1): Update call to
3120         watch_location_expression.
3121         * c-lang.c (c_watch_location_expression): Rename to
3122         language_defn::watch_location_expression.
3123         (c_language_data): Delete la_watch_location_expression
3124         initializer.
3125         (cplus_language_data): Likewise.
3126         (asm_language_data): Likewise.
3127         (minimal_language_data): Likewise.
3128         * c-lang.h (c_watch_location_expression): Delete declaration.
3129         * d-lang.c (d_language_data): Delete la_watch_location_expression
3130         initializer.
3131         * f-lang.c (f_language_data): Likewise.
3132         * go-lang.c (go_language_data): Likewise.
3133         * language.c (language_defn::watch_location_expression): Member
3134         function implementation from c_watch_location_expression.
3135         (unknown_language_data): Delete la_watch_location_expression
3136         initializer.
3137         (auto_language_data): Likewise.
3138         * language.h (language_data): Delete la_watch_location_expression
3139         field.
3140         (language_defn::watch_location_expression): Declare new member
3141         function.
3142         * m2-lang.c (m2_language_data): Delete
3143         la_watch_location_expression initializer.
3144         * objc-lang.c (objc_language_data): Likewise.
3145         * opencl-lang.c (opencl_language_data): Likewise.
3146         * p-lang.c (pascal_language_data): Likewise.
3147         * rust-lang.c (rust_watch_location_expression): Rename to
3148         rust_language::watch_location_expression.
3149         (rust_language_data): Delete la_watch_location_expression
3150         initializer.
3151         (rust_language::watch_location_expression): New member function,
3152         implementation from rust_watch_location_expression.
3153
3154 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3155
3156         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
3157         ada_language::collect_symbol_completion_matches.
3158         (ada_language_data): Delete la_collect_symbol_completion_matches
3159         initializer.
3160         (ada_language::collect_symbol_completion_matches): New member
3161         function, implementation from
3162         ada_collect_symbol_completion_matches.
3163         * c-lang.c (c_language_data): Delete
3164         la_collect_symbol_completion_matches initializer.
3165         (cplus_language_data): Likewise.
3166         (asm_language_data): Likewise.
3167         (minimal_language_data): Likewise.
3168         * d-lang.c (d_language_data): Likewise.
3169         * f-lang.c (f_collect_symbol_completion_matches): Rename to
3170         f_language::collect_symbol_completion_matches.
3171         (f_language_data): Delete la_collect_symbol_completion_matches
3172         initializer.
3173         (f_language::collect_symbol_completion_matches) New member
3174         function, implementation from f_collect_symbol_completion_matches.
3175         * go-lang.c (go_language_data): Delete
3176         la_collect_symbol_completion_matches initializer.
3177         * language.c (unknown_language_data): Likewise.
3178         (auto_language_data): Likewise.
3179         * language.h (language_data): Delete
3180         la_collect_symbol_completion_matches field.
3181         (language_defn::collect_symbol_completion_matches): New member
3182         function.
3183         * m2-lang.c (m2_language_data): Delete
3184         la_collect_symbol_completion_matches initializer.
3185         * objc-lang.c (objc_language_data): Likewise.
3186         * opencl-lang.c (opencl_language_data): Likewise.
3187         * p-lang.c (pascal_language_data): Likewise.
3188         * rust-lang.c (rust_language_data): Likewise.
3189         * symtab.c (default_collect_symbol_completion_matches): Delete.
3190         (collect_symbol_completion_matches): Update call to
3191         collect_symbol_completion_matches.
3192         (collect_symbol_completion_matches_type): Likewise.
3193         * symtab.h (default_collect_symbol_completion_matches): Delete
3194         declaration.
3195
3196 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3197
3198         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
3199         (ada_language_data): Delete la_word_break_characters initializer.
3200         (ada_language::word_break_characters): New member function.
3201         * c-lang.c (c_language_data): Delete la_word_break_characters
3202         initializer.
3203         (cplus_language_data): Likewise.
3204         (asm_language_data): Likewise.
3205         (minimal_language_data): Likewise.
3206         * completer.c: Update global comment.
3207         (advance_to_expression_complete_word_point): Update call to
3208         word_break_characters.
3209         (complete_files_symbols): Likewise.
3210         (complete_line_internal_1): Likewise.
3211         (default_completer_handle_brkchars): Likewise.
3212         (skip_quoted_chars): Likewise.
3213         * d-lang.c (d_language_data): Delete la_word_break_characters
3214         initializer.
3215         * f-lang.c (f_word_break_characters): Delete.
3216         (f_language_data): Delete la_word_break_characters initializer.
3217         (f_language::word_break_characters): New member function.
3218         * go-lang.c (go_language_data): Delete la_word_break_characters
3219         initializer.
3220         * language.c (unknown_language_data): Likewise.
3221         (auto_language_data): Likewise.
3222         * language.h (default_word_break_characters): Move declaration to
3223         earlier in the file.
3224         (language_data): Delete la_word_break_characters field.
3225         (language_defn::word_break_characters): New member function.
3226         * m2-lang.c (m2_language_data): Delete la_word_break_characters
3227         initializer.
3228         * objc-lang.c (objc_language_data): Likewise.
3229         * opencl-lang.c (opencl_language_data): Likewise.
3230         * p-lang.c (pascal_language_data): Likewise.
3231         * rust-lang.c (rust_language_data): Likewise.
3232
3233 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
3236         (ada_language_data): Delete la_get_symbol_name_matcher
3237         initializer.
3238         (language_defn::get_symbol_name_matcher_inner): New member
3239         function.
3240         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
3241         initializer.
3242         (cplus_language_data): Likewise.
3243         (cplus_language::get_symbol_name_matcher_inner): New member
3244         function.
3245         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
3246         (minimal_language_data): Likewise.
3247         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
3248         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
3249         initializer.
3250         * dictionary.c (iter_match_first_hashed): Update call to
3251         get_symbol_name_matcher.
3252         (iter_match_next_hashed): Likewise.
3253         (iter_match_next_linear): Likewise.
3254         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
3255         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
3256         initializer.
3257         (f_language::get_symbol_name_matcher_inner): New member function.
3258         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
3259         initializer.
3260         * language.c (default_symbol_name_matcher): Update header comment,
3261         make static.
3262         (language_defn::get_symbol_name_matcher): New definition.
3263         (language_defn::get_symbol_name_matcher_inner): Likewise.
3264         (get_symbol_name_matcher): Delete.
3265         (unknown_language_data): Delete la_get_symbol_name_matcher
3266         initializer.
3267         (auto_language_data): Likewise.
3268         * language.h (language_data): Delete la_get_symbol_name_matcher
3269         field.
3270         (language_defn::get_symbol_name_matcher): New member function.
3271         (language_defn::get_symbol_name_matcher_inner): Likewise.
3272         (default_symbol_name_matcher): Delete declaration.
3273         * linespec.c (find_methods): Update call to
3274         get_symbol_name_matcher.
3275         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
3276         initializer.
3277         * minsyms.c (lookup_minimal_symbol): Update call to
3278         get_symbol_name_matcher.
3279         (iterate_over_minimal_symbols): Likewise.
3280         * objc-lang.c (objc_language_data): Delete
3281         la_get_symbol_name_matcher initializer.
3282         * opencl-lang.c (opencl_language_data): Likewise.
3283         * p-lang.c (pascal_language_data): Likewise.
3284         * psymtab.c (psymbol_name_matches): Update call to
3285         get_symbol_name_matcher.
3286         * rust-lang.c (rust_language_data): Delete
3287         la_get_symbol_name_matcher initializer.
3288         * symtab.c (symbol_matches_search_name): Update call to
3289         get_symbol_name_matcher.
3290         (compare_symbol_name): Likewise.
3291
3292 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * ada-lang.c (ada_language_data): Delete la_compute_program
3295         initializer.
3296         * c-lang.c (c_language_data): Likewise.
3297         (c_language::compute_program): New member function.
3298         (cplus_language_data): Delete la_compute_program initializer.
3299         (cplus_language::compute_program): New member function.
3300         (asm_language_data): Delete la_compute_program initializer.
3301         (minimal_language_data): Likewise.
3302         * c-lang.h (c_compute_program): Update comment.
3303         (cplus_compute_program): Likewise.
3304         * compile/compile-c-support.c (c_compute_program): Likewise.
3305         (cplus_compute_program): Likewise.
3306         * compile/compile.c (compile_to_object): Update call to
3307         la_compute_program.
3308         * d-lang.c (d_language_data): Delete la_compute_program
3309         initializer.
3310         * f-lang.c (f_language_data): Likewise.
3311         * go-lang.c (go_language_data): Likewise.
3312         * language.c (unknown_language_data): Likewise.
3313         (auto_language_data): Likewise.
3314         * language.h (language_data): Delete la_compute_program field.
3315         (language_defn::compute_program): New member function.
3316         * m2-lang.c (m2_language_data): Delete la_compute_program
3317         initializer.
3318         * objc-lang.c (objc_language_data): Likewise.
3319         * opencl-lang.c (opencl_language_data): Likewise.
3320         * p-lang.c (pascal_language_data): Likewise.
3321         * rust-lang.c (rust_language_data): Likewise.
3322
3323 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * ada-lang.c (ada_language_data) Delete
3326         la_class_name_from_physname initializer.
3327         * c-lang.c (c_language_data): Likewise.
3328         (cplus_language_data): Likewise.
3329         (cplus_language::class_name_from_physname): New member function.
3330         (asm_language_data): Delete la_class_name_from_physname
3331         initializer.
3332         (minimal_language_data): Likewise.
3333         * d-lang.c (d_language_data): Likewise.
3334         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
3335         method on language_defn class.
3336         (guess_full_die_structure_name): Likewise.
3337         * f-lang.c (f_language_data): Delete la_class_name_from_physname
3338         initializer.
3339         * go-lang.c (go_language_data): Likewise.
3340         * language.c (language_class_name_from_physname): Delete.
3341         (unk_lang_class_name): Delete.
3342         (unknown_language_data): Delete la_class_name_from_physname
3343         initializer.
3344         (auto_language_data): Likewise.
3345         * language.h (language_data): Delete la_class_name_from_physname
3346         field.
3347         (language_defn::class_name_from_physname): New function.
3348         (language_class_name_from_physname): Delete declaration.
3349         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
3350         initializer.
3351         * objc-lang.c (objc_language_data): Likewise.
3352         * opencl-lang.c (opencl_language_data): Likewise.
3353         * p-lang.c (pascal_language_data): Likewise.
3354         * rust-lang.c (rust_language_data): Likewise.
3355
3356 2020-06-16  Tom Tromey  <tom@tromey.com>
3357
3358         * tui/tui-data.h (STATUS_NAME): New macro.
3359         * tui/tui-layout.c (tui_remove_some_windows)
3360         (initialize_known_windows, tui_register_window)
3361         (tui_layout_split::remove_windows, initialize_layouts)
3362         (tui_new_layout_command): Don't use hard-coded window names.
3363
3364 2020-06-16  Tom Tromey  <tom@tromey.com>
3365
3366         PR tui/25348:
3367         * tui/tui.c (tui_ensure_readline_initialized): Rename from
3368         tui_initialize_readline.  Only run once.  Call rl_initialize.
3369         * tui/tui.h (tui_ensure_readline_initialized): Rename from
3370         tui_initialize_readline.
3371         * tui/tui-io.c (tui_setup_io): Call
3372         tui_ensure_readline_initialized.
3373         * tui/tui-interp.c (tui_interp::init): Update.
3374
3375 2020-06-16  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
3378         Also preserve the status window.
3379
3380 2020-06-16  Tom Tromey  <tom@tromey.com>
3381
3382         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
3383         where m_window==nullptr.
3384
3385 2020-06-15  Tom Tromey  <tromey@adacore.com>
3386
3387         * windows-nat.c (windows_nat::handle_output_debug_string):
3388         Update.
3389         (windows_nat::handle_ms_vc_exception): Update.
3390         * target.h (target_read_string): Change API.
3391         * target.c (target_read_string): Change API.
3392         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
3393         Update.
3394         * solib-frv.c (frv_current_sos): Update.
3395         * solib-dsbt.c (dsbt_current_sos): Update.
3396         * solib-darwin.c (darwin_current_sos): Update.
3397         * linux-thread-db.c (inferior_has_bug): Update.
3398         * expprint.c (print_subexp_standard): Update.
3399         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
3400         (ada_exception_message_1): Update.
3401
3402 2020-06-15  Tom Tromey  <tromey@adacore.com>
3403
3404         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
3405
3406 2020-06-15  Tom Tromey  <tromey@adacore.com>
3407
3408         * valprint.c (read_string): Update comment.
3409         * target.c (MIN): Remove.
3410         (target_read_string): Rewrite.
3411
3412 2020-06-15  Tom Tromey  <tromey@adacore.com>
3413
3414         * corefile.c (read_memory_string): Remove.
3415         * ada-valprint.c (ada_value_print_ptr): Update.
3416         * ada-lang.h (ada_tag_name): Change return type.
3417         * ada-lang.c (type_from_tag): Update.
3418         (ada_tag_name_from_tsd): Change return type.  Use
3419         target_read_string.
3420         (ada_tag_name): Likewise.
3421         * gdbcore.h (read_memory_string): Don't declare.
3422
3423 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
3424
3425         * symtab.c (rbreak_command): Ignore Windows drive colon.
3426
3427 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
3428
3429         * NEWS: Mention removed GDBserver host support.
3430
3431 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
3432
3433         * features/riscv/rebuild-csr-xml.sh: Updated.
3434
3435 2020-06-11  Tom Tromey  <tom@tromey.com>
3436
3437         PR gdb/18318:
3438         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
3439
3440 2020-06-09  Jonny Grant  <jg@jguk.org>
3441 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
3442
3443         * main.c (captured_main_1): Don't print new line after help.
3444         (print_gdb_help): add mailing list and IRC channel information
3445         to --help.  Add new lines between items in the footer.  Remove
3446         quotes around bug url.
3447
3448 2020-06-11  Keith Seitz  <keiths@redhat.com>
3449
3450         PR gdb/21356
3451         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
3452         Resolve typedefs for type length calculations.
3453
3454 2020-06-10  Tom de Vries  <tdevries@suse.de>
3455
3456         PR ada/24713
3457         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
3458         (write_psymbols): Enable .gdb_index for ada.
3459         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
3460         ada.
3461
3462 2020-06-10  Tom de Vries  <tdevries@suse.de>
3463
3464         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
3465         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
3466         namei" instead of "const char *name" argument.
3467         (dw2_map_matching_symbols): Use "offset_type namei" variant of
3468         dw2_symtab_iter_init.
3469
3470 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3471
3472         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
3473         to use type::field and field::type instead.
3474
3475 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3476
3477         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
3478         to use field::type instead.
3479
3480 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3481
3482         * gdbtypes.h (struct field) <type, set_type>: New methods.
3483         Rename `type` field to...
3484         <m_type>: ... this.  Change references throughout to use type or
3485         set_type methods.
3486         (FIELD_TYPE): Use field::type.  Change call sites that modify
3487         the field's type to use field::set_type instead.
3488
3489 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3490
3491         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
3492         to use type::index_type instead.
3493
3494 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
3495
3496         * gdbtypes.h (struct type) <index_type, set_index_type>: New
3497         methods.
3498         (TYPE_INDEX_TYPE): Use type::index_type.
3499         * gdbtypes.c (create_array_type_with_stride): Likewise.
3500
3501 2020-06-07  Tom Tromey  <tom@tromey.com>
3502
3503         * valprint.c (generic_val_print_float): Remove "embedded_offset"
3504         parameter.
3505         (generic_value_print): Update.
3506
3507 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         Revert commit 982a38f60b0.
3510         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
3511
3512 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3513
3514         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
3515         avoid use after free.
3516
3517 2020-06-05  Tom de Vries  <tdevries@suse.de>
3518
3519         * NEWS: Fix typos.
3520
3521 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
3522
3523         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
3524         the per_bfd object.
3525         (dwarf2_read_debug_names): Likewise.
3526         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
3527         object when re-using a per_bfd object with an index.
3528
3529 2020-06-03  Tom de Vries  <tdevries@suse.de>
3530
3531         PR symtab/26046
3532         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
3533         children for C++.
3534         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
3535         DW_TAG_subprogram.
3536
3537 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * ada-lang.c (ada_language_data): Delete skip_trampoline
3540         initializer.
3541         * c-lang.c (c_language_data): Likewise.
3542         (cplus_language_data): Likewise.
3543         (cplus_language::skip_trampoline): New member function.
3544         (asm_language_data): Delete skip_trampoline initializer.
3545         (minimal_language_data): Likewise.
3546         * d-lang.c (d_language_data): Likewise.
3547         * f-lang.c (f_language_data): Likewise.
3548         * go-lang.c (go_language_data): Likewise.
3549         * language.c (unk_lang_trampoline): Delete function.
3550         (skip_language_trampoline): Update.
3551         (unknown_language_data): Delete skip_trampoline initializer.
3552         (auto_language_data): Likewise.
3553         * language.h (language_data): Delete skip_trampoline field.
3554         (language_defn::skip_trampoline): New function.
3555         * m2-lang.c (m2_language_data): Delete skip_trampoline
3556         initializer.
3557         * objc-lang.c (objc_skip_trampoline): Delete function, move
3558         implementation to objc_language::skip_trampoline.
3559         (objc_language_data): Delete skip_trampoline initializer.
3560         (objc_language::skip_trampoline): New member function with
3561         implementation from objc_skip_trampoline.
3562         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
3563         initializer.
3564         * p-lang.c (pascal_language_data): Likewise.
3565         * rust-lang.c (rust_language_data): Likewise.
3566
3567 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
3570         (ada_language::demangle): New member function.
3571         * c-lang.c (c_language_data): Delete la_demangle initializer.
3572         (cplus_language_data): Delete la_demangle initializer.
3573         (cplus_language::demangle): New member function.
3574         (asm_language_data): Delete la_demangle initializer.
3575         (minimal_language_data): Delete la_demangle initializer.
3576         * d-lang.c (d_language_data): Delete la_demangle initializer.
3577         (d_language::demangle): New member function.
3578         * f-lang.c (f_language_data): Delete la_demangle initializer.
3579         (f_language::demangle): New member function.
3580         * go-lang.c (go_language_data): Delete la_demangle initializer.
3581         (go_language::demangle): New member function.
3582         * language.c (language_demangle): Update.
3583         (unk_lang_demangle): Delete.
3584         (unknown_language_data): Delete la_demangle initializer.
3585         (unknown_language::demangle): New member function.
3586         (auto_language_data): Delete la_demangle initializer.
3587         (auto_language::demangle): New member function.
3588         * language.h (language_data): Delete la_demangle field.
3589         (language_defn::demangle): New function.
3590         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
3591         * objc-lang.c (objc_language_data): Delete la_demangle
3592         initializer.
3593         (objc_language::demangle): New member function.
3594         * opencl-lang.c (opencl_language_data): Delete la_demangle
3595         initializer.
3596         * p-lang.c (pascal_language_data): Likewise.
3597         * rust-lang.c (rust_language_data): Likewise.
3598         (rust_language::demangle): New member function.
3599
3600 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3601
3602         * ada-lang.c (ada_language_data): Delete la_print_type
3603         initializer.
3604         (ada_language::print_type): New member function.
3605         * c-lang.c (c_language_data): Delete la_print_type initializer.
3606         (c_language::print_type): New member function.
3607         (cplus_language_data): Delete la_print_type initializer.
3608         (cplus_language::print_type): New member function.
3609         (asm_language_data): Delete la_print_type initializer.
3610         (asm_language::print_type): New member function.
3611         (minimal_language_data): Delete la_print_type initializer.
3612         (minimal_language::print_type): New member function.
3613         * d-lang.c (d_language_data): Delete la_print_type initializer.
3614         (d_language::print_type): New member function.
3615         * f-lang.c (f_language_data): Delete la_print_type initializer.
3616         (f_language::print_type): New member function.
3617         * go-lang.c (go_language_data): Delete la_print_type initializer.
3618         (go_language::print_type): New member function.
3619         * language.c (unk_lang_print_type): Delete.
3620         (unknown_language_data): Delete la_print_type initializer.
3621         (unknown_language::print_type): New member function.
3622         (auto_language_data): Delete la_print_type initializer.
3623         (auto_language::print_type): New member function.
3624         * language.h (language_data): Delete la_print_type field.
3625         (language_defn::print_type): New function.
3626         (LA_PRINT_TYPE): Update.
3627         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
3628         (m2_language::print_type): New member function.
3629         * objc-lang.c (objc_language_data): Delete la_print_type
3630         initializer.
3631         (objc_language::print_type): New member function.
3632         * opencl-lang.c (opencl_print_type): Delete, implementation moved
3633         to opencl_language::print_type.
3634         (opencl_language_data): Delete la_print_type initializer.
3635         (opencl_language::print_type): New member function, implementation
3636         from opencl_print_type.
3637         * p-lang.c (pascal_language_data): Delete la_print_type
3638         initializer.
3639         (pascal_language::print_type): New member function.
3640         * rust-lang.c (rust_print_type): Delete, implementation moved to
3641         rust_language::print_type.
3642         (rust_language_data): Delete la_print_type initializer.
3643         (rust_language::print_type): New member function, implementation
3644         from rust_print_type.
3645
3646 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3647
3648         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
3649         implementation moves to...
3650         (ada_language::sniff_from_mangled_name): ...here.  Update return
3651         type.
3652         (ada_language_data): Delete la_sniff_from_mangled_name
3653         initializer.
3654         * c-lang.c (c_language_data): Likewise.
3655         (cplus_language_data): Likewise.
3656         (cplus_language::sniff_from_mangled_name): New member function,
3657         implementation taken from gdb_sniff_from_mangled_name.
3658         (asm_language_data): Delete la_sniff_from_mangled_name
3659         initializer.
3660         (minimal_language_data): Likewise.
3661         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
3662         implementation moves to cplus_language::sniff_from_mangled_name.
3663         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
3664         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
3665         moves to...
3666         (d_language::sniff_from_mangled_name): ...here.
3667         (d_language_data): Delete la_sniff_from_mangled_name initializer.
3668         * f-lang.c (f_language_data): Likewise.
3669         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
3670         moves to...
3671         (go_language::sniff_from_mangled_name): ...here.
3672         (go_language_data): Delete la_sniff_from_mangled_name initializer.
3673         * language.c (language_sniff_from_mangled_name): Delete.
3674         (unknown_language_data): Delete la_sniff_from_mangled_name
3675         initializer.
3676         (auto_language_data): Likewise.
3677         * language.h (language_data): Delete la_sniff_from_mangled_name
3678         field.
3679         (language_defn::sniff_from_mangled_name): New function.
3680         (language_sniff_from_mangled_name): Delete declaration.
3681         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
3682         field.
3683         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
3684         implementation moves to...
3685         (objc_language::sniff_from_mangled_name): ...here.
3686         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
3687         * opencl-lang.c (opencl_language_data): Likewise.
3688         * p-lang.c (pascal_language_data): Likewise.
3689         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
3690         implementation moves to...
3691         (rust_language::sniff_from_mangled_name): ...here.
3692         (rust_language_data): Delete la_sniff_from_mangled_name
3693         initializer.
3694         * symtab.c (symbol_find_demangled_name): Call
3695         sniff_from_mangled_name member function.
3696
3697 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * ada-lang.c (ada_language_data): Delete la_search_name_hash
3700         initializer.
3701         * c-lang.c (c_language_data): Likewise.
3702         (cplus_language_data): Likewise.
3703         (cplus_language::search_name_hash): New member function.
3704         (asm_language_data): Delete la_search_name_hash initializer.
3705         (minimal_language_data): Likewise.
3706         * d-lang.c (d_language_data): Likewise.
3707         * dictionary.c (default_search_name_hash): Rename to...
3708         (language_defn::search_name_hash): ...this.
3709         * f-lang.c (f_language_data): Likewise.
3710         (f_language::search_name_hash): New member function.
3711         * go-lang.c (go_language_data): Delete la_search_name_hash
3712         initializer.
3713         * language.c (unknown_language_data): Likewise.
3714         (auto_language_data): Likewise.
3715         * language.h (struct language_data): Delete la_search_name_hash
3716         field.
3717         (language_defn::search_name_hash): Declare new member function.
3718         (default_search_name_hash): Delete declaration.
3719         * m2-lang.c (m2_language_data): Delete la_search_name_hash
3720         initializer.
3721         * objc-lang.c (objc_language_data): Likewise.
3722         * opencl-lang.c (opencl_language_data): Likewise.
3723         * p-lang.c (pascal_language_data): Likewise.
3724         * rust-lang.c (rust_language_data): Likewise.
3725         * symtab.c (search_name_hash): Update call.
3726
3727 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3728
3729         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
3730         initializer.
3731         * c-lang.c (class compile_instance): Declare.
3732         (c_language_data): Delete la_get_compile_instance initializer.
3733         (c_language::get_compile_instance): New member function.
3734         (cplus_language_data): Delete la_get_compile_instance initializer.
3735         (cplus_language::get_compile_instance): New member function.
3736         (asm_language_data): Delete la_get_compile_instance initializer.
3737         (minimal_language_data): Likewise.
3738         * c-lang.h (c_get_compile_context): Update comment.
3739         (cplus_get_compile_context): Update comment.
3740         * compile/compile.c (compile_to_object): Update calls, don't rely
3741         on function pointer being NULL.
3742         * d-lang.c (d_language_data): Delete la_get_compile_instance
3743         initializer.
3744         * f-lang.c (f_language_data): Likewise.
3745         * go-lang.c (go_language_data): Likewise.
3746         * language.c (unknown_language_data): Likewise.
3747         (auto_language_data): Likewise.
3748         * language.h (language_data): Delete la_get_compile_instance field.
3749         (language_defn::get_compile_instance): New member function.
3750         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
3751         initializer.
3752         * objc-lang.c (objc_language_data): Likewise.
3753         * opencl-lang.c (opencl_language_data): Likewise.
3754         * p-lang.c (pascal_language_data): Likewise.
3755         * rust-lang.c (rust_language_data): Likewise.
3756
3757 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * ada-lang.c (ada_add_all_symbols): Update comment.
3760         (ada_iterate_over_symbols): Delete, move implementation to...
3761         (ada_language::iterate_over_symbols): ...here, a new member
3762         function, rewrite to use range based for loop.
3763         (ada_language_data): Delete la_iterate_over_symbols initializer.
3764         * c-lang.c (c_language_data): Likewise.
3765         (cplus_language_data): Likewise.
3766         (asm_language_data): Likewise.
3767         (minimal_language_data): Likewise.
3768         * d-lang.c (d_language_data): Likewise.
3769         * f-lang.c (f_language_data): Likewise.
3770         * go-lang.c (go_language_data): Likewise.
3771         * language.c (unknown_language_data): Likewise.
3772         (auto_language_data): Likewise.
3773         * language.h (language_data): Delete la_iterate_over_symbols field.
3774         (language_defn::iterate_over_symbols): New member function.
3775         (LA_ITERATE_OVER_SYMBOLS): Update.
3776         * linespec.c (iterate_over_all_matching_symtabs): Update.
3777         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
3778         initializer.
3779         * objc-lang.c (objc_language_data): Likewise.
3780         * opencl-lang.c (opencl_language_data): Likewise.
3781         * p-lang.c (pascal_language_data): Likewise.
3782         * rust-lang.c (rust_language_data): Likewise.
3783
3784 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * ada-lang.c (ada_language_data): Delete
3787         la_lookup_transparent_type initializer.
3788         * c-lang.c (c_language_data): Likewise.
3789         (cplus_language_data): Likewise.
3790         (cplus_language::lookup_transparent_type): New member function.
3791         (asm_language_data): Delete la_lookup_transparent_type
3792         initializer.
3793         (minimal_language_data): Likewise.
3794         * d-lang.c (d_language_data): Likewise.
3795         * f-lang.c (f_language_data): Likewise.
3796         * go-lang.c (go_language_data): Likewise.
3797         * language.c (unknown_language_data): Likewise.
3798         (auto_language_data): Likewise.
3799         * language.h (struct language_data): Delete
3800         la_lookup_transparent_type field.
3801         (language_defn::lookup_transparent_type): New member function.
3802         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
3803         initializer.
3804         * objc-lang.c (objc_language_data): Likewise.
3805         * opencl-lang.c (opencl_language_data): Likewise.
3806         * p-lang.c (pascal_language_data): Likewise.
3807         * rust-lang.c (rust_language_data): Likewise.
3808         * symtab.c (symbol_matches_domain): Update call.
3809
3810 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * ada-lang.c (ada_language_arch_info): Delete function, move
3813         implementation to...
3814         (ada_language::language_arch_info): ...here, a new member
3815         function.
3816         (ada_language_data): Delete la_language_arch_info.
3817         * c-lang.c (c_language_data): Likewise.
3818         (c_language::language_arch_info): New member function.
3819         (cplus_language_arch_info): Delete function, move
3820         implementation to...
3821         (cplus_language::language_arch_info): ...here, a new member
3822         function.
3823         (cplus_language_data): Delete la_language_arch_info.
3824         (asm_language_data): Likewise.
3825         (asm_language::language_arch_info): New member function.
3826         (minimal_language_data): Delete la_language_arch_info.
3827         (minimal_language::language_arch_info): New member function.
3828         * d-lang.c (d_language_arch_info): Delete function, move
3829         implementation to...
3830         (d_language::language_arch_info): ...here, a new member
3831         function.
3832         (d_language_data): Delete la_language_arch_info.
3833         * f-lang.c (f_language_arch_info): Delete function, move
3834         implementation to...
3835         (f_language::language_arch_info): ...here, a new member
3836         function.
3837         (f_language_data): Delete la_language_arch_info.
3838         * go-lang.c (go_language_arch_info): Delete function, move
3839         implementation to...
3840         (go_language::language_arch_info): ...here, a new member
3841         function.
3842         (go_language_data): Delete la_language_arch_info.
3843         * language.c (unknown_language_data): Likewise.
3844         (unknown_language::language_arch_info): New member function.
3845         (auto_language_data): Delete la_language_arch_info.
3846         (auto_language::language_arch_info): New member function.
3847         (language_gdbarch_post_init): Update call to
3848         la_language_arch_info.
3849         * language.h (language_data): Delete la_language_arch_info
3850         function pointer.
3851         (language_defn::language_arch_info): New function.
3852         * m2-lang.c (m2_language_arch_info): Delete function, move
3853         implementation to...
3854         (m2_language::language_arch_info): ...here, a new member
3855         function.
3856         (m2_language_data): Delete la_language_arch_info.
3857         * objc-lang.c (objc_language_arch_info): Delete function, move
3858         implementation to...
3859         (objc_language::language_arch_info): ...here, a new member
3860         function.
3861         (objc_language_data): Delete la_language_arch_info.
3862         * opencl-lang.c (opencl_language_arch_info): Delete function, move
3863         implementation to...
3864         (opencl_language::language_arch_info): ...here, a new member
3865         function.
3866         (opencl_language_data): Delete la_language_arch_info.
3867         * p-lang.c (pascal_language_arch_info): Delete function, move
3868         implementation to...
3869         (pascal_language::language_arch_info): ...here, a new member
3870         function.
3871         (pascal_language_data): Delete la_language_arch_info.
3872         * rust-lang.c (rust_language_arch_info): Delete function, move
3873         implementation to...
3874         (rust_language::language_arch_info): ...here, a new member
3875         function.
3876         (rust_language_data): Delete la_language_arch_info.
3877
3878 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
3881         initializer.
3882         * c-lang.c (c_language_data): Likewise.
3883         (cplus_language_data): Likewise.
3884         (cplus_language::pass_by_reference_info): New method.
3885         (asm_language_data): Delete la_pass_by_reference initializer.
3886         (minimal_language_data): Likewise.
3887         * cp-abi.c (cp_pass_by_reference): Remove use of
3888         default_pass_by_reference.
3889         * d-lang.c (d_language_data): Likewise.
3890         * f-lang.c (f_language_data): Likewise.
3891         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
3892         default_pass_by_reference.
3893         * go-lang.c (go_language_data): Likewise.
3894         * language.c (language_pass_by_reference): Update.
3895         (default_pass_by_reference): Delete.
3896         (unknown_language_data): Delete la_pass_by_reference
3897         initializer.
3898         (auto_language_data): Likewise.
3899         * language.h (struct language_data): Delete la_pass_by_reference
3900         field.
3901         (language_defn::pass_by_reference_info): New member function.
3902         (default_pass_by_reference): Delete declaration.
3903         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
3904         initializer.
3905         * objc-lang.c (objc_language_data): Likewise.
3906         * opencl-lang.c (opencl_language_data): Likewise.
3907         * p-lang.c (pascal_language_data): Likewise.
3908         * rust-lang.c (rust_language_data): Likewise.
3909
3910 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * ada-lang.c (ada_read_var_value): Delete function, move
3913         implementation to...
3914         (ada_language::read_var_value): ...here.
3915         (ada_language_data): Delete la_read_var_value initializer.
3916         * c-lang.c (c_language_data): Likewise.
3917         (cplus_language_data): Likewise.
3918         (minimal_language_data): Likewise.
3919         * d-lang.c (d_language_data): Likewise.
3920         * f-lang.c (f_language_data): Likewise.
3921         * findvar.c (default_read_var_value): Rename to...
3922         (language_defn::read_var_value): ...this.
3923         * findvar.c (read_var_value): Update header comment, and change to
3924         call member function instead of function pointer.
3925         * go-lang.c (go_language_data): Likewise.
3926         * language.c (unknown_language_data): Delete la_read_var_value
3927         initializer.
3928         (auto_language_data): Likewise.
3929         * language.h (struct language_data): Delete la_read_var_value
3930         field.
3931         (language_defn::read_var_value): New member function.
3932         (default_read_var_value): Delete declaration.
3933         * m2-lang.c (m2_language_data): Delete la_read_var_value
3934         initializer.
3935         * objc-lang.c (objc_language_data): Likewise.
3936         * opencl-lang.c (opencl_language_data): Likewise.
3937         * p-lang.c (pascal_language_data): Likewise.
3938         * rust-lang.c (rust_language_data): Likewise.
3939         * value.h (default_read_var_value): Delete declaration.
3940
3941 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3942
3943         * ada-lang.c (ada_print_array_index): Delete function, move
3944         implementation to...
3945         (ada_language::print_array_index): ...here.
3946         (ada_language_data): Delete la_print_array_index initializer.
3947         * c-lang.c (c_language_data): Likewise.
3948         (cplus_language_data): Likewise.
3949         (minimal_language_data): Likewise.
3950         * d-lang.c (d_language_data): Likewise.
3951         * f-lang.c (f_language_data): Likewise.
3952         * go-lang.c (go_language_data): Likewise.
3953         * language.c (default_print_array_index): Delete function, move
3954         implementation to...
3955         (language_defn::print_array_index): ...here.
3956         (unknown_language_data): Delete la_print_array_index initializer.
3957         (auto_language_data): Likewise.
3958         * language.h (struct language_data): Delete la_print_array_index
3959         field.
3960         (language_defn::print_array_index): New member function.
3961         (LA_PRINT_ARRAY_INDEX): Update.
3962         (default_print_array_index): Delete declaration.
3963         * m2-lang.c (m2_language_data): Delete la_print_array_index
3964         initializer.
3965         * objc-lang.c (objc_language_data): Likewise.
3966         * opencl-lang.c (opencl_language_data): Likewise.
3967         * p-lang.c (pascal_language_data): Likewise.
3968         * rust-lang.c (rust_language_data): Likewise.
3969
3970 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3971
3972         * gdb/ada-lang.c (ada_language_defn): Convert to...
3973         (ada_language_data): ...this.
3974         (class ada_language): New class.
3975         (ada_language_defn): New static global.
3976         * gdb/c-lang.c (c_language_defn): Convert to...
3977         (c_language_data): ...this.
3978         (class c_language): New class.
3979         (c_language_defn): New static global.
3980         (cplus_language_defn): Convert to...
3981         (cplus_language_data): ...this.
3982         (class cplus_language): New class.
3983         (cplus_language_defn): New static global.
3984         (asm_language_defn): Convert to...
3985         (asm_language_data): ...this.
3986         (class asm_language): New class.
3987         (asm_language_defn): New static global.
3988         (minimal_language_defn): Convert to...
3989         (minimal_language_data): ...this.
3990         (class minimal_language): New class.
3991         (minimal_language_defn): New static global.
3992         * gdb/d-lang.c (d_language_defn): Convert to...
3993         (d_language_data): ...this.
3994         (class d_language): New class.
3995         (d_language_defn): New static global.
3996         * gdb/f-lang.c (f_language_defn): Convert to...
3997         (f_language_data): ...this.
3998         (class f_language): New class.
3999         (f_language_defn): New static global.
4000         * gdb/go-lang.c (go_language_defn): Convert to...
4001         (go_language_data): ...this.
4002         (class go_language): New class.
4003         (go_language_defn): New static global.
4004         * gdb/language.c (unknown_language_defn): Remove declaration.
4005         (current_language): Initialize to nullptr, real initialization is
4006         moved to _initialize_language.
4007         (languages): Delete global.
4008         (language_defn::languages): Define.
4009         (set_language_command): Use language_defn::languages.
4010         (set_language): Likewise.
4011         (range_error): Likewise.
4012         (language_enum): Likewise.
4013         (language_def): Likewise.
4014         (add_set_language_command): Use language_def::languages for the
4015         language list, and language_def to lookup language pointers.
4016         (skip_language_trampoline): Use language_defn::languages.
4017         (unknown_language_defn): Convert to...
4018         (unknown_language_data): ...this.
4019         (class unknown_language): New class.
4020         (unknown_language_defn): New static global.
4021         (auto_language_defn): Convert to...
4022         (auto_language_data): ...this.
4023         (class auto_language): New class.
4024         (auto_language_defn): New static global.
4025         (language_gdbarch_post_init): Use language_defn::languages.
4026         (_initialize_language): Initialize current_language.
4027         * gdb/language.h (struct language_defn): Rename to...
4028         (struct language_data): ...this.
4029         (struct language_defn): New.
4030         (auto_language_defn): Delete.
4031         (unknown_language_defn): Delete.
4032         (minimal_language_defn): Delete.
4033         (ada_language_defn): Delete.
4034         (asm_language_defn): Delete.
4035         (c_language_defn): Delete.
4036         (cplus_language_defn): Delete.
4037         (d_language_defn): Delete.
4038         (f_language_defn): Delete.
4039         (go_language_defn): Delete.
4040         (m2_language_defn): Delete.
4041         (objc_language_defn): Delete.
4042         (opencl_language_defn): Delete.
4043         (pascal_language_defn): Delete.
4044         (rust_language_defn): Delete.
4045         * gdb/m2-lang.c (m2_language_defn): Convert to...
4046         (m2_language_data): ...this.
4047         (class m2_language): New class.
4048         (m2_language_defn): New static global.
4049         * gdb/objc-lang.c (objc_language_defn): Convert to...
4050         (objc_language_data): ...this.
4051         (class objc_language): New class.
4052         (objc_language_defn): New static global.
4053         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
4054         (opencl_language_data): ...this.
4055         (class opencl_language): New class.
4056         (opencl_language_defn): New static global.
4057         * gdb/p-lang.c (pascal_language_defn): Convert to...
4058         (pascal_language_data): ...this.
4059         (class pascal_language): New class.
4060         (pascal_language_defn): New static global.
4061         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
4062         language pointer, update comment format.
4063         * gdb/rust-lang.c (rust_language_defn): Convert to...
4064         (rust_language_data): ...this.
4065         (class rust_language): New class.
4066         (rust_language_defn): New static global.
4067
4068 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
4071         member variable.
4072         <m_stmt_at_address>: New member variable.
4073         (lnp_state_machine::record_line): Don't record some lines, update
4074         tracking of is_stmt at the same address.
4075         (lnp_state_machine::lnp_state_machine): Initialise new member
4076         variables.
4077
4078 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4079
4080         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
4081         "-include gnu-nat-mig.h".
4082         * gnu-nat-mig.h: New file.
4083         * gnu-nat.c: Include "gnu-nat-mig.h".
4084         (exc_server, msg_reply_server, notify_server,
4085         process_reply_server): Remove declarations.
4086
4087 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4088
4089         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
4090         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
4091         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
4092         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
4093         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
4094         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
4095         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
4096         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
4097         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
4098         to gnu_nat_target class.
4099         * gnu-nat.c: Likewise.
4100         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
4101         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
4102         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
4103         object.
4104         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
4105         instead of `gnu_target'.
4106
4107 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4108
4109         * i386-gnu-tdep.c: Include "gdbcore.h"
4110         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
4111         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
4112         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
4113         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
4114         i386_gnu_sigcontext_addr): New functions
4115         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
4116         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
4117         tdep.
4118
4119 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4120
4121         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
4122         before fork_inferior call. Avoid calling it if target_is_pushed returns
4123         true.
4124
4125 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4126
4127         * gnu-nat.h (gnu_target): New variable declaration.
4128         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
4129         gnu_target.
4130         * gnu-nat.c (gnu_target): New variable.
4131         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
4132         add_thread_silent, and add_thread calls.
4133         (gnu_nat_target::create_inferior): Pass gnu_target to
4134         add_thread_silent, thread_change_ptid call.
4135         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
4136         call.
4137
4138 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4139
4140         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
4141         (gnu_nat_target::find_memory_regions): Remove unused
4142         `old_address' variable.
4143
4144 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4145
4146         * gnu-nat.c: Include "gdbarch.h".
4147
4148 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4149
4150         * reply_mig_hack.awk (Error return): Cast function through
4151         void *, to bypass compiler function call check.
4152
4153 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4154
4155         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
4156         $(srcdir)/reply_mig_hack.awk.
4157
4158 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
4159
4160         * gnu-nat.h (gnu_debug_flag): Set type to bool.
4161
4162 2020-05-30  Jonny Grant  <jg@jguk.org>
4163
4164         * configure.ac (ACX_BUGURL): change bug URL to https.
4165
4166 2020-05-30  Pedro Alves  <palves@redhat.com>
4167
4168         * cp-support.c (replace_typedefs_template): New.
4169         (replace_typedefs_qualified_name): Handle
4170         DEMANGLE_COMPONENT_TEMPLATE.
4171
4172 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
4175         dwarf2/index-cache.h, dwarf2/index-write.c,
4176         dwarf2/index-write.h, dwarf2/line-header.c,
4177         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
4178         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
4179         variables and fields from `dwarf2_per_objfile` to just
4180         `per_objfile` throughout.
4181
4182 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
4183
4184         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
4185         <push_dwarf_reg_entry_value>: Add comment.
4186
4187 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
4188             Keith Seitz  <keiths@redhat.com>
4189
4190         * python/python.c (do_start_initialization): Call PyEval_SaveThread
4191         instead of PyEval_ReleaseLock.
4192         (class gdbpy_gil): Move to earlier in file.
4193         (finalize_python): Set gdb_python_initialized.
4194         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
4195         when not initialized.
4196
4197 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
4198
4199         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
4200         <push_dwarf_reg_entry_value>: Remove assert.  Override
4201         per_objfile with caller_per_objfile.
4202
4203 2020-05-28  Tom de Vries  <tdevries@suse.de>
4204
4205         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
4206         PR gold/15646 workaround to symbol kind "type".
4207
4208 2020-05-27  Tom Tromey  <tromey@adacore.com>
4209
4210         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
4211
4212 2020-05-27  Tom Tromey  <tromey@adacore.com>
4213
4214         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
4215         Use htab_find_with_hash.
4216         <add_abbrev>: Remove "abbrev_number" parameter.
4217         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
4218         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
4219         (hash_abbrev): Add comment.
4220         (abbrev_table::lookup_abbrev): Move to header file.
4221         (abbrev_table::read): Update.
4222
4223 2020-05-27  Tom Tromey  <tromey@adacore.com>
4224
4225         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
4226         method.
4227         <canonical_name>: New member.
4228         <raw_name>: Rename from "name".
4229         (partial_die_info): Initialize canonical_name.
4230         (scan_partial_symbols): Check raw_name.
4231         (partial_die_parent_scope, partial_die_full_name)
4232         (add_partial_symbol, add_partial_subprogram)
4233         (add_partial_enumeration, load_partial_dies): Use "name" method.
4234         (partial_die_info::name): New method.
4235         (partial_die_info::read, guess_partial_die_structure_name)
4236         (partial_die_info::fixup): Update.
4237
4238 2020-05-27  Tom Tromey  <tromey@adacore.com>
4239
4240         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
4241         <get_ref_die_offset>: Inline.
4242         <get_ref_die_offset_complaint>: New method.
4243         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
4244         (attribute::get_ref_die_offset_complaint): Rename from
4245         get_ref_die_offset.  Just issue complaint.
4246
4247 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
4248
4249         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
4250
4251 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
4252
4253         * exec.c (exec_file_attach): Use errno value of first openp failure.
4254
4255 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
4256
4257         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
4258         Don't close thread handle.
4259
4260 2020-05-27  Tom Tromey  <tom@tromey.com>
4261             Simon Marchi  <simon.marchi@efficios.com>
4262
4263         * objfiles.h (struct objfile) <partial_symtabs>: Now a
4264         shared_ptr.
4265         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
4266         member.
4267         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
4268         dwarf2_per_bfd_objfile_data_key>: New globals.
4269         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
4270         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
4271         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
4272         shared.
4273         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
4274         short-circuit when sharing.
4275         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
4276         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
4277
4278 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4279
4280         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
4281         to...
4282         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
4283         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
4284
4285 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4286
4287         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
4288         build_name_components, find_name_components_bounds>:
4289         Add per_objfile parameter.
4290         (struct mapped_index) <symbol_name_at>: Likewise.
4291         (struct mapped_debug_names): Remove constructor.
4292         <dwarf2_per_objfile>: Remove field.
4293         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
4294         (mapped_index_base::find_name_components_bounds,
4295         mapped_index_base::build_name_components,
4296         dw2_expand_symtabs_matching_symbol): Likewise.
4297         (class mock_mapped_index) <symbol_name_at>: Likewise.
4298         (check_match): Likewise.
4299         (check_find_bounds_finds): Likewise.
4300         (test_mapped_index_find_name_component_bounds): Update.
4301         (CHECK_MATCH): Update.
4302         (dw2_expand_symtabs_matching): Update.
4303         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
4304         per_objfile parameter.
4305         <find_vec_in_debug_names>: Likewise.
4306         <m_per_objfile>: New field.
4307         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
4308         parameter.
4309         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
4310         (dw2_debug_names_iterator::next): Update.
4311         (dw2_debug_names_lookup_symbol): Update.
4312         (dw2_debug_names_expand_symtabs_for_function): Update.
4313         (dw2_debug_names_map_matching_symbols): Update.
4314         (dw2_debug_names_expand_symtabs_matching): Update.
4315         (dwarf2_read_debug_names): Update.
4316
4317 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4318
4319         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
4320         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
4321         move to dwarf2_per_objfile.
4322         <read_in_chain>: Remove.
4323         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
4324         remove_all_cus, age_comp_units>: New methods.
4325         <m_dwarf2_cus>: New member.
4326         (struct dwarf2_per_cu_data) <cu>: Remove.
4327         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
4328         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
4329         moved to methods of dwarf2_per_objfile.
4330         (dwarf2_clear_marks): Remove.
4331         (dwarf2_queue_item::~dwarf2_queue_item): Update.
4332         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
4333         (dwarf2_per_bfd::free_cached_comp_units): Remove.
4334         (dwarf2_per_objfile::remove_all_cus): New.
4335         (class free_cached_comp_units) <~free_cached_comp_units>:
4336         Update.
4337         (load_cu): Update.
4338         (dw2_do_instantiate_symtab): Adjust.
4339         (fill_in_sig_entry_from_dwo_entry): Adjust.
4340         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4341         (cutu_reader::cutu_reader): Likewise.
4342         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
4343         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
4344         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
4345         and dwarf2_per_objfile::age_comp_units.
4346         (load_partial_comp_unit): Update.
4347         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
4348         (process_queue): Likewise.
4349         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
4350         backlink.
4351         (dwarf2_read_addr_index): Likewise.
4352         (follow_die_offset): Likewise.
4353         (dwarf2_fetch_die_loc_sect_off): Likewise.
4354         (dwarf2_fetch_constant_bytes): Likewise.
4355         (dwarf2_fetch_die_type_sect_off): Likewise.
4356         (follow_die_sig_1): Likewise.
4357         (load_full_type_unit): Likewise.
4358         (read_signatured_type): Likewise.
4359         (dwarf2_cu::dwarf2_cu): Don't set cu field.
4360         (dwarf2_cu::~dwarf2_cu): Remove.
4361         (dwarf2_per_objfile::get_cu): New.
4362         (dwarf2_per_objfile::set_cu): New.
4363         (age_cached_comp_units): Rename to...
4364         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
4365         to std::unordered_map.
4366         (free_one_cached_comp_unit): Rename to...
4367         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
4368         to std::unordered_map.
4369         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
4370         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
4371         a dwarf2_per_objfile in data.
4372         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
4373         (dwarf2_clear_marks): Remove.
4374
4375 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4376
4377         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
4378         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
4379         (init_tu_and_read_dwo_dies): Likewise.
4380         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
4381         (cutu_reader::cutu_reader): Likewise.
4382         (load_partial_comp_unit): Likewise.
4383         (process_psymtab_comp_unit): Update.
4384         (build_type_psymtabs_1): Update.
4385         (process_skeletonless_type_unit): Update.
4386         (load_full_comp_unit): Update.
4387         (find_partial_die): Update.
4388         (dwarf2_read_addr_index): Update.
4389         (read_signatured_type): Update.
4390
4391 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4392
4393         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
4394         m_header_read_in>: New fields.
4395         <get_header>: New method.
4396         * dwarf2/read.c (per_cu_header_read_in): Remove.
4397         (dwarf2_per_cu_data::get_header): New.
4398         (dwarf2_per_cu_data::addr_size): Update.
4399         (dwarf2_per_cu_data::offset_size): Update.
4400         (dwarf2_per_cu_data::ref_addr_size): Update.
4401
4402 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4403
4404         * dwarf2/read.c (load_cu): Return dwarf2_cu.
4405         (dw2_do_instantiate_symtab): Update.
4406         (queue_and_load_all_dwo_tus): Change parameter from
4407         dwarf2_per_cu_data to dwarf2_cu.
4408         (dwarf2_fetch_die_loc_sect_off): Update.
4409         (dwarf2_fetch_constant_bytes): Update.
4410         (dwarf2_fetch_die_type_sect_off): Update.
4411
4412 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4413
4414         * dwarf2/read.c (process_full_comp_unit,
4415         process_full_type_unit): Remove per_cu, per_objfile paramters.
4416         Add dwarf2_cu parameter.
4417         (process_queue): Update.
4418
4419 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4420
4421         * dwarf2/read.c (create_cu_from_index_list): Replace
4422         dwarf2_per_objfile parameter with dwarf2_per_bfd.
4423         (create_cus_from_index_list): Likewise.
4424         (create_cus_from_index): Likewise.
4425         (create_signatured_type_table_from_index): Likewise.
4426         (create_cus_from_debug_names_list): Likewise.
4427         (create_cus_from_debug_names): Likewise.
4428         (dwarf2_read_gdb_index): Update.
4429         (dwarf2_read_debug_names): Update.
4430
4431 2020-05-27  Tom Tromey  <tom@tromey.com>
4432             Simon Marchi  <simon.marchi@efficios.com>
4433
4434         * dwarf2/read.h (struct dwarf2_per_objfile)
4435         <get_type_for_signatured_type, set_type_for_signatured_type>:
4436         New methods.
4437         <m_type_map>: New member.
4438         (struct signatured_type) <type>: Remove.
4439         * dwarf2/read.c
4440         (dwarf2_per_objfile::get_type_for_signatured_type,
4441         dwarf2_per_objfile::set_type_for_signatured_type): New.
4442         (get_signatured_type): Use new methods.
4443
4444 2020-05-27  Tom Tromey  <tom@tromey.com>
4445             Simon Marchi  <simon.marchi@efficios.com>
4446
4447         * dwarf2/read.h (struct type_unit_group_unshareable): New.
4448         (struct dwarf2_per_objfile) <type_units>: New member.
4449         <get_type_unit_group_unshareable>: New method.
4450         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
4451         num_symtabs, symtabs>: Remove; move to
4452         type_unit_group_unshareable.
4453         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
4454         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
4455         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
4456
4457 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * dwarf2/read.h (struct dwarf2_per_cu_data):
4460         <dwarf2_per_objfile>: Remove.
4461         * dwarf2/read.c (create_cu_from_index_list): Don't assign
4462         dwarf2_per_objfile.
4463         (create_signatured_type_table_from_index): Likewise.
4464         (create_signatured_type_table_from_debug_names): Likewise.
4465         (create_debug_type_hash_table): Likewise.
4466         (fill_in_sig_entry_from_dwo_entry): Likewise.
4467         (create_type_unit_group): Likewise.
4468         (read_comp_units_from_section): Likewise.
4469         (create_cus_hash_table): Likewise.
4470
4471 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4472
4473         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
4474         dwarf2_per_cu_data::dwarf2_per_objfile.
4475         (compute_compunit_symtab_includes): Likewise.
4476         (dwarf2_cu::start_symtab): Likewise.
4477
4478 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4479
4480         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
4481         parameter.
4482         * dwarf2/read.c (get_die_type_at_offset): Likewise.
4483         (read_namespace_alias): Update.
4484         (lookup_die_type): Update.
4485         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
4486         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
4487         Update.
4488         (disassemble_dwarf_expression): Update.
4489
4490 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4491
4492         * dwarf2/read.h (struct dwarf2_queue_item): Add
4493         dwarf2_per_objfile parameter, assign new parameter.
4494         <per_objfile>: New field.
4495         * dwarf2/read.c (free_one_cached_comp_unit): Add
4496         dwarf2_per_objfile parameter.
4497         (queue_comp_unit): Likewise.
4498         (dw2_do_instantiate_symtab): Update.
4499         (process_psymtab_comp_unit): Update.
4500         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
4501         (process_imported_unit_die): Update.
4502         (queue_and_load_dwo_tu): Update.
4503         (follow_die_offset): Update.
4504         (follow_die_sig_1): Update.
4505
4506 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4507
4508         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
4509         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
4510         (read_call_site_scope): Assign per_objfile.
4511         (dwarf2_per_cu_data::objfile): Remove.
4512         * gdbtypes.h (struct call_site) <per_objfile>: New member.
4513         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
4514         dwarf2_per_objfile parameter.
4515         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
4516         dwarf2_per_objfile parameter.
4517         (dwarf_expr_reg_to_entry_parameter): Add output
4518         dwarf2_per_objfile parameter.
4519         (locexpr_get_frame_base): Update.
4520         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
4521         <push_dwarf_reg_entry_value>: Update.
4522         <call_site_to_target_addr>: Update.
4523         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
4524         parameter.
4525         (value_of_dwarf_reg_entry): Update.
4526         (rw_pieced_value): Update.
4527         (indirect_synthetic_pointer): Update.
4528         (dwarf2_evaluate_property): Update.
4529         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
4530         parameter.
4531         (locexpr_read_variable): Update.
4532         (locexpr_get_symbol_read_needs): Update.
4533         (loclist_read_variable): Update.
4534
4535 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4536
4537         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
4538         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4539         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4540         parameter.
4541         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
4542         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
4543         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
4544         parameter.
4545         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
4546         sect_variable_value): Add dwarf2_per_objfile parameter.
4547         (class dwarf_evaluate_loc_desc) <dwarf_call,
4548         dwarf_variable_value>: Update.
4549         (fetch_const_value_from_synthetic_pointer): Add
4550         dwarf2_per_objfile parameter.
4551         (fetch_const_value_from_synthetic_pointer): Update.
4552         (coerced_pieced_ref): Update.
4553         (class symbol_needs_eval_context) <dwarf_call,
4554         dwarf_variable_value>: Update.
4555         (dwarf2_compile_expr_to_ax): Update.
4556
4557 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4558
4559         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
4560         parameter.
4561         (dwarf2_evaluate_loc_desc_full): Update.
4562
4563 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4564
4565         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
4566         parameter.
4567         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
4568         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
4569         dwarf2_per_objfile parameter.
4570         (decode_debug_loc_dwo_addresses): Likewise.
4571         (dwarf2_find_location_expression): Update.
4572         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
4573         (locexpr_describe_location_piece): Add dwarf2_per_objfile
4574         parameter.
4575         (disassemble_dwarf_expression): Add dwarf2_per_objfile
4576         parameter.
4577         (locexpr_describe_location_1): Likewise.
4578         (locexpr_describe_location): Update.
4579
4580 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4581
4582         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
4583         Remove.
4584         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
4585         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
4586         (dwarf2_compile_property_to_c): Update.
4587         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
4588         use text offset from objfile.
4589         (locexpr_tracepoint_var_ref): Update.
4590         (locexpr_generate_c_location): Update.
4591         (loclist_describe_location): Update.
4592         (loclist_tracepoint_var_ref): Update.
4593         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
4594         dwarf2_per_objfile parameter.
4595         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
4596         use text offset from objfile.
4597         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
4598
4599 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4600
4601         * dwarf2/expr.h (struct dwarf_expr_context)
4602         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
4603         <offset>: Remove.
4604         <per_objfile>: New member.
4605         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
4606         dwarf2_per_objfile parameter.  Don't set offset, set
4607         per_objfile.
4608         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
4609         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
4610         a dwarf2_per_objfile object instead of an offset.
4611         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
4612         constructor.
4613         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
4614         to dwarf2_expr_executor constructor.  Don't set offset.
4615         (dwarf2_fetch_cfa_info): Update.
4616         (struct dwarf2_frame_cache) <text_offset>: Remove.
4617         <per_objfile>: New field.
4618         (dwarf2_frame_cache): Update.
4619         (dwarf2_frame_prev_register): Update.
4620         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
4621         <dwarf_evaluate_loc_desc>: Add constructor.
4622         (dwarf2_evaluate_loc_desc_full): Update.
4623         (dwarf2_locexpr_baton_eval): Update.
4624         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
4625         Add constructor.
4626         (dwarf2_loc_desc_get_symbol_read_needs): Update.
4627
4628 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4629
4630         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
4631         addr_sized_int_type>: Move to dwarf2_cu.
4632         <int_type>: Move to dwarf2_per_objfile.
4633         (struct dwarf2_per_objfile) <int_type>: Move here.
4634         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
4635         addr_sized_int_type>: Move here.
4636         (read_func_scope): Update.
4637         (read_array_type): Update.
4638         (read_tag_string_type): Update.
4639         (attr_to_dynamic_prop): Update.
4640         (dwarf2_per_cu_data::int_type): Rename to...
4641         (dwarf2_per_objfile::int_type): ... this.
4642         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
4643         (dwarf2_cu::addr_sized_int_type): ... this.
4644         (read_subrange_type): Update.
4645         (dwarf2_per_cu_data::addr_type): Rename to...
4646         (dwarf2_cu::addr_type): ... this.
4647         (set_die_type): Update.
4648
4649 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4650
4651         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
4652         data through per_cu->cu.
4653
4654 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4655
4656         * dwarf2/read.c (lookup_dwo_comp_unit): Change
4657         dwarf2_per_cu_data parameter fo dwarf2_cu.
4658         (lookup_dwo_type_unit): Likewise.
4659         (read_cutu_die_from_dwo): Likewise.
4660         (lookup_dwo_unit): Likewise.
4661         (open_and_init_dwo_file): Likewise.
4662         (lookup_dwo_cutu): Likewise.
4663         (lookup_dwo_comp_unit): Likewise.
4664         (lookup_dwo_type_unit): Likewise.
4665         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4666         (cutu_reader::cutu_reader): Update.
4667
4668 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4669
4670         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
4671         parameter.
4672         (process_full_type_unit): Likewise.
4673         (process_queue): Update.
4674
4675 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4676
4677         * dwarf2/read.c (recursively_compute_inclusions): Add
4678         dwarf2_per_objfile parameter.
4679         (compute_compunit_symtab_includes): Likewise.
4680         (process_cu_includes): Update.
4681
4682 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4683
4684         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
4685         parameter.
4686         (create_type_unit_group): Update.
4687         (process_psymtab_comp_unit_reader): Update.
4688         (build_type_psymtabs_reader): Update.
4689
4690 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4691
4692         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
4693         object through m_this_cu->cu.
4694
4695 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4696
4697         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
4698         the info parameter.
4699         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
4700
4701 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4702
4703         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
4704         per_objfile parameter.
4705         (load_full_type_unit): Add per_objfile parameter.
4706         (read_signatured_type): Likewise.
4707         (load_full_comp_unit): Likewise.
4708         (load_cu): Likewise.
4709         (dw2_do_instantiate_symtab): Likewise.
4710         (dw2_get_file_names): Likewise.
4711         (dw2_map_symtabs_matching_filename): Update.
4712         (dw_expand_symtabs_matching_file_matcher): Update.
4713         (dw2_map_symbol_filenames): Update.
4714         (process_psymtab_comp_unit): Add per_objfile parameter.
4715         (build_type_psymtabs_1): Update.
4716         (process_skeletonless_type_unit): Update.
4717         (dwarf2_build_psymtabs_hard): Update.
4718         (load_partial_comp_unit): Add per_objfile parameter.
4719         (scan_partial_symbols): Update.
4720         (load_full_comp_unit): Add per_objfile parameter.
4721         (process_imported_unit_die): Update.
4722         (create_cus_hash_table): Update.
4723         (find_partial_die): Update.
4724         (dwarf2_read_addr_index): Update.
4725         (follow_die_offset): Update.
4726         (dwarf2_fetch_die_loc_sect_off): Update.
4727         (dwarf2_fetch_constant_bytes): Update.
4728         (dwarf2_fetch_die_type_sect_off): Update.
4729         (follow_die_sig_1): Update.
4730         (load_full_type_unit): Add per_objfile parameter.
4731         (read_signatured_type): Likewise.
4732
4733 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4734
4735         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
4736         of objfile_name.
4737
4738 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4739
4740         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
4741         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4742         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
4743         field.
4744         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
4745         (create_cus_from_index): Update.
4746         (dwarf2_read_gdb_index): Update.
4747         (create_cus_from_debug_names): Update.
4748         (dwarf2_read_debug_names): Update.
4749         (get_abbrev_section_for_cu): Update.
4750         (create_all_comp_units): Update.
4751         (read_attribute_value): Update.
4752         (get_debug_line_section): Update.
4753         * dwarf2/index-cache.c (index_cache::store): Update.
4754         * dwarf2/index-write.c (save_gdb_index_command): Update.
4755         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
4756
4757 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4758
4759         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
4760         member.
4761         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
4762         dwarf2_per_cu_data::per_bfd.
4763         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
4764         (create_type_unit_group): Likewise.
4765         (queue_comp_unit): Remove reference to
4766         per_cu->dwarf2_per_objfile.
4767         (maybe_queue_comp_unit): Likewise.
4768         (fill_in_sig_entry_from_dwo_entry): Assign new field.
4769         (create_cus_hash_table): Assign new field.
4770
4771 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4772
4773         * dwarf2/read.c: Replace
4774         dwarf2_cu->per_cu->dwarf2_per_objfile references with
4775         dwarf2_cu->per_objfile throughout.
4776
4777 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4778
4779         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
4780         parameter, don't use per_cu->dwarf2_per_objfile.
4781         (dw2_instantiate_symtab): Likewise.
4782         (dw2_find_last_source_symtab): Update.
4783         (dw2_map_expand_apply): Update.
4784         (dw2_lookup_symbol): Update.
4785         (dw2_expand_symtabs_for_function): Update.
4786         (dw2_expand_all_symtabs): Update.
4787         (dw2_expand_symtabs_with_fullname): Update.
4788         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
4789         don't use per_cu->dwarf2_per_objfile.
4790         (dw2_expand_marked_cus): Update.
4791         (dw2_find_pc_sect_compunit_symtab): Update.
4792         (dw2_debug_names_lookup_symbol): Update.
4793         (dw2_debug_names_expand_symtabs_for_function): Update.
4794         (dw2_debug_names_map_matching_symbols): Update.
4795         (dwarf2_psymtab::expand_psymtab): Update.
4796
4797 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4798
4799         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
4800         <per_objfile>: New member.
4801         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
4802         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
4803         call to dwarf2_cu.
4804         (cutu_reader::cutu_reader): Update.
4805         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
4806
4807 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
4808
4809         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
4810         struct dwarf2_per_objfile.
4811         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
4812         dwarf2_per_bfd.
4813         * dwarf2/read.c (set_die_type): Update.
4814         (get_die_type_at_offset): Update.
4815
4816 2020-05-27  Tom Tromey  <tom@tromey.com>
4817             Simon Marchi  <simon.marchi@efficios.com>
4818
4819         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
4820         method.
4821         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
4822         get_symtab, set_symtab>: New methods.
4823         <m_symtabs>: New field.
4824         (struct dwarf2_psymtab): Derive from partial_symtab.
4825         <readin_p, get_compunit_symtab>: Declare methods.
4826         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
4827         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
4828         New methods.
4829         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
4830         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
4831         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
4832         (dw2_symtab_iter_next, dw2_print_stats)
4833         (dw2_expand_symtabs_with_fullname)
4834         (dw2_expand_symtabs_matching_one)
4835         (dw_expand_symtabs_matching_file_matcher)
4836         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
4837         (dw2_debug_names_iterator::next)
4838         (dw2_debug_names_map_matching_symbols)
4839         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
4840         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
4841         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
4842         New methods.
4843         (get_compunit_symtab, process_full_comp_unit)
4844         (process_full_type_unit): Update.
4845         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
4846
4847 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
4848
4849         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
4850         then introduce a new dwarf2_per_objfile type.
4851         <read_line_string>: Move to the new dwarf2_per_objfile type.
4852         <objfile>: Likewise.
4853         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
4854         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
4855         dwarf2_per_objfile->per_bfd.
4856         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
4857         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
4858         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
4859         (dwarf2_per_bfd::free_cached_comp_units): ... this.
4860         (dwarf2_has_info): Allocate dwarf2_per_bfd.
4861         (dwarf2_per_objfile::locate_sections): Rename to...
4862         (dwarf2_per_bfd::locate_sections): ... this.
4863         (dwarf2_per_objfile::get_cutu): Rename to...
4864         (dwarf2_per_bfd::get_cutu): ... this.
4865         (dwarf2_per_objfile::get_cu): Rename to...
4866         (dwarf2_per_bfd::get_cu): ... this.
4867         (dwarf2_per_objfile::get_tu): Rename to...
4868         (dwarf2_per_bfd::get_tu): ... this.
4869         (dwarf2_per_objfile::allocate_per_cu): Rename to...
4870         (dwarf2_per_bfd::allocate_per_cu): ... this.
4871         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
4872         (dwarf2_per_bfd::allocate_signatured_type): ... this.
4873         (get_gdb_index_contents_ftype): Change parameter from
4874         dwarf2_per_objfile to dwarf2_per_bfd.
4875         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
4876         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
4877
4878 2020-05-27  Tom Tromey  <tom@tromey.com>
4879             Simon Marchi  <simon.marchi@efficios.com>
4880
4881         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
4882         (allocate_piece_closure): Set "per_objfile" member.
4883         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
4884         (locexpr_describe_location, loclist_describe_location): Use new
4885         member.
4886         * dwarf2/read.c (read_call_site_scope)
4887         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
4888         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
4889         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
4890         handle_data_member_location): Set per_objfile member.
4891         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
4892         member.
4893         (struct dwarf2_loclist_baton) <per_objfile>: New member.
4894
4895 2020-05-27  Tom Tromey  <tom@tromey.com>
4896
4897         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
4898         allocate_signatured_type>: Declare new methods.
4899         <m_num_psymtabs>: New member.
4900         (struct dwarf2_per_cu_data) <index>: New member.
4901         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
4902         (dwarf2_per_objfile::allocate_signatured_type): New methods.
4903         (create_cu_from_index_list): Use allocate_per_cu.
4904         (create_signatured_type_table_from_index)
4905         (create_signatured_type_table_from_debug_names)
4906         (create_debug_type_hash_table, add_type_unit)
4907         (read_comp_units_from_section): Use allocate_signatured_type.
4908
4909 2020-05-27  Tom Tromey  <tom@tromey.com>
4910
4911         * psymtab.c (partial_map_expand_apply)
4912         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4913         (psym_lookup_global_symbol_language)
4914         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4915         (psym_print_stats, psym_expand_symtabs_for_function)
4916         (psym_map_symbol_filenames, psym_map_matching_symbols)
4917         (psym_expand_symtabs_matching)
4918         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4919         (maintenance_check_psymtabs): Update.
4920         * psympriv.h (struct partial_symtab) <readin_p,
4921         get_compunit_symtab>: Add objfile parameter.
4922         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
4923         Likewise.
4924         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
4925         get_compunit_symtab>: Likewise.
4926         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
4927
4928 2020-05-27  Tom Tromey  <tom@tromey.com>
4929
4930         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
4931         member.
4932         * dwarf2/read.c (delete_file_name_entry): Fix comment.
4933         (create_cu_from_index_list)
4934         (create_signatured_type_table_from_index)
4935         (create_signatured_type_table_from_debug_names)
4936         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
4937         (dwarf2_create_include_psymtab)
4938         (create_debug_type_hash_table, add_type_unit)
4939         (create_type_unit_group, read_comp_units_from_section)
4940         (dwarf2_compute_name, create_cus_hash_table)
4941         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4942         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
4943         obstack.
4944         (dw2_get_real_path): Likewise.  Change argument to
4945         dwarf2_per_objfile.
4946
4947 2020-05-27  Luis Machado  <luis.machado@linaro.org>
4948
4949         PR tdep/26000
4950         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
4951         for ldrd (immediate).
4952
4953 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4954
4955         * command.h: Add comment giving the name of class_tui.
4956         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
4957         create the fake command for the help for class_tui.
4958
4959 2020-05-26  Tom Tromey  <tromey@adacore.com>
4960
4961         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
4962         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
4963         (val_atr): New function.
4964         (value_val_atr): Use it.
4965         * ada-valprint.c (print_optional_low_bound): Change low bound
4966         handling for enums.
4967         (val_print_packed_array_elements): Don't call discrete_position.
4968         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
4969         discrete_position for enum types.
4970         * language.c (default_print_array_index): Change type.
4971         * language.h (struct language_defn) <la_print_array_index>: Add
4972         index_type parameter, change type of index_value.
4973         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
4974         (default_print_array_index): Update.
4975         * valprint.c (maybe_print_array_index): Don't call
4976         value_from_longest.  Update.
4977         (value_print_array_elements): Don't call discrete_position.
4978
4979 2020-05-26  Tom Tromey  <tromey@adacore.com>
4980
4981         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
4982         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
4983
4984 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
4985
4986         PR gdb/13519
4987         * avr-tdep.c (avr_integer_to_address): Return data or code
4988         address accordingly to the second 'type' argument of the
4989         function.
4990
4991 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
4992
4993         * infcmd.c, inferior.h: (construct_inferior_arguments):
4994         Moved function from here to gdbsupport/common-inferior.{h,cc}
4995
4996 2020-05-23  Tom Tromey  <tom@tromey.com>
4997
4998         Revert commit eca1f90c:
4999         * NEWS: Remove entry for completion styling.
5000         * completer.c (_rl_completion_prefix_display_length): Move
5001         declaration later.
5002         (gdb_fnprint): Revert.
5003         (gdb_display_match_list_1): Likewise.
5004         * cli/cli-style.c (completion_prefix_style)
5005         (completion_difference_style, completion_suffix_style): Remove.
5006         (_initialize_cli_style): Revert.
5007         * cli/cli-style.h (completion_prefix_style)
5008         (completion_difference_style, completion_suffix_style): Don't
5009         declare.
5010
5011 2020-05-24  Pedro Alves  <palves@redhat.com>
5012
5013         * symtab.c (completion_list_add_name): Return boolean indication
5014         of whether the symbol matched.
5015         (completion_list_add_symbol): Don't try to remove C++ aliases if
5016         the symbol didn't match in the first place.
5017         * symtab.h (completion_list_add_name): Return bool.
5018
5019 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
5020
5021         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
5022         type::field.
5023
5024 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
5025
5026         GDB 9.2 released.
5027
5028 2020-05-23  Tom Tromey  <tom@tromey.com>
5029
5030         * NEWS: Add entry for completion styling.
5031         * completer.c (_rl_completion_prefix_display_length): Move
5032         declaration earlier.
5033         (gdb_fnprint): Use completion_style.
5034         (gdb_display_match_list_1): Likewise.
5035         * cli/cli-style.c (completion_prefix_style)
5036         (completion_difference_style, completion_suffix_style): New
5037         globals.
5038         (_initialize_cli_style): Register new globals.
5039         * cli/cli-style.h (completion_prefix_style)
5040         (completion_difference_style, completion_suffix_style): Declare.
5041
5042 2020-05-23  Pedro Alves  <palves@redhat.com>
5043
5044         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
5045         (parse_escape): Use ISDIGIT instead of isdigit.
5046         (puts_debug): Use gdb_isprint instead of isprint.
5047         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
5048         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
5049         ISSPACE instead of isspace.
5050         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
5051         instead of isspace.
5052         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
5053         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
5054         instead of isxdigit and ISDIGIT instead of isdigit.
5055
5056 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
5057
5058         * gdbtypes.h (struct type) <field>: New method.
5059         (TYPE_FIELDS): Remove, replace all uses with either type::fields
5060         or type::field.
5061
5062 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
5063
5064         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
5065         (TYPE_FIELDS): Use type::fields.  Change all call sites that
5066         modify the propery to use type::set_fields instead.
5067
5068 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
5069
5070         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
5071         type::num_fields instead.
5072
5073 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
5076         methods.
5077         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
5078         that modify the number of fields to use type::set_num_fields
5079         instead.
5080
5081 2020-05-22  Tom Tromey  <tromey@adacore.com>
5082
5083         * compile/compile-object-load.h (munmap_list_free): Don't
5084         declare.
5085
5086 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * annotate.c (annotate_source_line): Update return type, add call
5089         to update current symtab and line.
5090         * annotate.h (annotate_source_line): Update return type, and
5091         extend header comment.
5092         * source.c (info_line_command): Check annotation_level before
5093         calling annotate_source_line.
5094         * stack.c (print_frame_info): If calling annotate_source_line
5095         returns true, then don't print any other source line information.
5096
5097 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
5098
5099         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
5100
5101 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
5102
5103         * coffread.c (patch_type): Remove NULL check before xfree.
5104         * corefile.c (set_gnutarget): Likewise.
5105         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
5106         * exec.c (build_section_table): Likewise.
5107         * remote.c (remote_target::pass_signals): Likewise.
5108         * utils.c (n_spaces): Likewise.
5109         * cli/cli-script.c (document_command): Likewise.
5110         * i386-windows-tdep.c (core_process_module_section): Likewise.
5111         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
5112
5113 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
5114
5115         * symfile.c (reread_symbols): Clear objfile's section_offsets
5116         vector and section indices, re-compute them by calling
5117         sym_offsets.
5118
5119 2020-05-20  Tom Tromey  <tromey@adacore.com>
5120
5121         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
5122         (desc_one_bound, desc_index_type): Compute field name.
5123
5124 2020-05-20  Tom de Vries  <tdevries@suse.de>
5125
5126         PR symtab/25833
5127         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
5128
5129 2020-05-20  Alan Modra  <amodra@gmail.com>
5130
5131         PR 25993
5132         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
5133         bfd_set_filename.
5134         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
5135         passed to bfd_set_filename.
5136         * symfile-mem.c (add_vsyscall_page): Likewise for string
5137         passed to symbol_file_add_from_memory.
5138         (symbol_file_add_from_memory): Make name param a const char* and
5139         don't strdup.
5140
5141 2020-05-20  Alan Modra  <amodra@gmail.com>
5142
5143         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
5144         rather than accessing bfd->filename directly.
5145         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
5146         and use bfd_section_name.
5147         * dwarf2/frame.c (decode_frame_entry): Likewise.
5148         * exec.c (exec_set_section_address): Likewise.
5149         * solib-aix.c (solib_aix_bfd_open): Likewise.
5150         * stap-probe.c (get_stap_base_address): Likewise.
5151         * symfile.c (reread_symbols): Likewise.
5152
5153 2020-05-19  Tom Tromey  <tromey@adacore.com>
5154
5155         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
5156
5157 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
5158
5159         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
5160
5161 2020-05-19  Pedro Alves  <palves@redhat.com>
5162
5163         * NEWS (set exec-file-mismatch): Adjust entry.
5164         * exec.c: Include "build-id.h".
5165         (validate_exec_file): Try to match build IDs instead of filenames.
5166         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
5167         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
5168         and pass down 'warn_if_slow'.
5169         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
5170         gdb_bfd_open_closure to pass it down.
5171         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
5172
5173 2020-05-19  Pedro Alves  <palves@redhat.com>
5174
5175         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
5176         * target.c (target_fileio_open_1): Rename to target_fileio_open
5177         and make extern.  Use bool.
5178         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
5179         (target_fileio_read_alloc_1): Adjust.
5180         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
5181         (target_fileio_open_warn_if_slow): Delete declaration.
5182
5183 2020-05-19  Pedro Alves  <palves@redhat.com>
5184
5185         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
5186         Adjust all callers.
5187
5188 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
5189
5190         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
5191         whether disp is negative.
5192
5193 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
5194
5195         * symfile.h (struct symfile_segment_data)
5196         <~symfile_segment_data>: Remove.
5197         <segment_info>: Change to std::vector.
5198         * symfile.c (default_symfile_segments): Update.
5199         * elfread.c (elf_symfile_segments): Update.
5200
5201 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
5202
5203         * symfile.h (struct symfile_segment_data) <struct segment>: New.
5204         <segments>: New.
5205         <segment_bases, segment_sizes>: Remove.
5206         * symfile.c (default_symfile_segments): Update.
5207         * elfread.c (elf_symfile_segments): Update.
5208         * remote.c (remote_target::get_offsets): Update.
5209         * solib-target.c (solib_target_relocate_section_addresses):
5210         Update.
5211
5212 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
5213
5214         * symfile.h (struct symfile_segment_data): Initialize fields.
5215         <~symfile_segment_data>: Add.
5216         (symfile_segment_data_up): New.
5217         (struct sym_fns) <sym_segments>: Return a
5218         symfile_segment_data_up.
5219         (default_symfile_segments): Return a symfile_segment_data_up.
5220         (free_symfile_segment_data): Remove.
5221         (get_symfile_segment_data): Return a symfile_segment_data_up.
5222         * symfile.c (default_symfile_segments): Likewise.
5223         (get_symfile_segment_data): Likewise.
5224         (free_symfile_segment_data): Remove.
5225         (symfile_find_segment_sections): Update.
5226         * elfread.c (elf_symfile_segments): Return a
5227         symfile_segment_data_up.
5228         * remote.c (remote_target::get_offsets): Update.
5229         * solib-target.c (solib_target_relocate_section_addresses):
5230         Update.
5231         * symfile-debug.c (debug_sym_segments): Return a
5232         symfile_segment_data_up.
5233
5234 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5235
5236         PR build/25981
5237         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
5238         Hardcode register numbers.
5239
5240         PR build/25981
5241         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
5242         procfs_find_LDT_entry): Remove.
5243         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
5244         procfs_find_LDT_entry): Remove.
5245         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
5246         Remove.
5247
5248 2020-05-17  Pedro Alves  <palves@redhat.com>
5249             Andrew Burgess  <andrew.burgess@embecosm.com>
5250             Keno Fischer  <keno@juliacomputing.com>
5251
5252         PR gdb/25741
5253         * breakpoint.c (build_target_condition_list): Update comments.
5254         (build_target_command_list): Update comments and skip matching
5255         locations.
5256         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
5257         a separate function.  Simplify "set breakpoint auto-hw off"
5258         handling.
5259         (insert_breakpoints): Update comment.
5260         (tracepoint_locations_match): New parameter.  For breakpoints,
5261         compare location types too, if the caller wants to.
5262         (handle_automatic_hardware_breakpoints): New functions.
5263         (bp_location_is_less_than): Also sort by location type and
5264         hardware breakpoint length.
5265         (update_global_location_list): Handle "set breakpoint auto-hw on"
5266         here.
5267         (update_breakpoint_locations): Ask breakpoint_locations_match to
5268         ignore location types.
5269
5270 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
5271
5272         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
5273         type::name instead.
5274
5275 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
5276
5277         * gdbtypes.h (struct type) <name, set_name>: New methods.
5278         (TYPE_CODE): Use type::name.  Change all call sites used to set
5279         the name to use type::set_name instead.
5280
5281 2020-05-16  Tom Tromey  <tom@tromey.com>
5282
5283         * top.c (quit_force): Update.
5284         * infrun.c (handle_no_resumed): Update.
5285         * top.h (all_uis): New function.
5286         (ALL_UIS): Remove.
5287
5288 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
5289
5290         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
5291
5292 2020-05-16  Pedro Alves  <palves@redhat.com>
5293
5294         * ia64-linux-nat.c
5295         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
5296         Declare method.
5297         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
5298
5299 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
5300
5301         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
5302         (sparc64_adi_info): Likewise.
5303
5304 2020-05-15  Tom Tromey  <tom@tromey.com>
5305
5306         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
5307         block_objfile.
5308         (lookup_objfile_from_block): Remove.
5309         (lookup_symbol_in_block, lookup_symbol_in_static_block)
5310         (lookup_global_symbol): Use block_objfile.
5311         * symtab.h (lookup_objfile_from_block): Don't declare.
5312         * printcmd.c (clear_dangling_display_expressions): Use
5313         block_objfile.
5314         * parse.c (operator_check_standard): Use block_objfile.
5315
5316 2020-05-15  Tom Tromey  <tom@tromey.com>
5317
5318         * language.c (language_alloc_type_symbol): Set
5319         SYMBOL_SECTION.
5320         * symtab.c (initialize_objfile_symbol): Remove.
5321         (allocate_symbol): Remove.
5322         (allocate_template_symbol): Remove.
5323         * dwarf2/read.c (fixup_go_packaging): Use "new".
5324         (new_symbol): Use "new".
5325         (read_variable): Don't call initialize_objfile_symbol.  Use
5326         "new".
5327         (read_func_scope): Use "new".
5328         * xcoffread.c (process_xcoff_symbol): Don't call
5329         initialize_objfile_symbol.
5330         (SYMBOL_DUP): Remove.
5331         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
5332         "new".
5333         * symtab.h (allocate_symbol, initialize_objfile_symbol)
5334         (allocate_template_symbol): Don't declare.
5335         (struct symbol): Add copy constructor.  Change defaults.
5336         * jit.c (finalize_symtab): Use "new".
5337         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
5338         Use "new".
5339         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
5340         (common_block_end): Use "new".
5341         * mdebugread.c (parse_symbol): Use "new".
5342         (new_symbol): Likewise.
5343
5344 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5345
5346         * NEWS: Mention changes to help and apropos.
5347
5348 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5349
5350         * command.h (enum command_class): Improve comments, document
5351         that class_alias is for user-defined aliases, give the class
5352         name for each class, remove unused class_xdb.
5353         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
5354         * breakpoint.c (_initialize_breakpoint): Replace class_alias
5355         by a precise class.
5356         * infcmd.c (_initialize_infcmd): Likewise.
5357         * reverse.c (_initialize_reverse): Likewise.
5358         * stack.c (_initialize_stack): Likewise.
5359         * symfile.c (_initialize_symfile): Likewise.
5360         * tracepoint.c (_initialize_tracepoint): Likewise.
5361
5362 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5363
5364         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
5365         when their aliased command is traversed.
5366         (help_cmd): Add fput_command_names_styled call to
5367         output command name and aliases when command has an alias.
5368
5369 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5370
5371         * cli/cli-decode.h (help_cmd_list): Remove declaration.
5372         * cli/cli-decode.c (help_cmd_list): Declare as static,
5373         remove prefix argument, use bool for recurse arg, rework to show the aliases of
5374         a command together with the command.
5375         (fput_command_name_styled, fput_command_names_styled): New functions.
5376         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
5377         fput_command_name_styled.
5378         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
5379         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
5380
5381 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5382
5383         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
5384         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
5385         * command.h (cmd_show_list): Likewise.
5386         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
5387         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
5388
5389 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * unittests/command-def-selftests.c (traverse_command_structure):
5392         Verify all commands of a list have the same prefix command and
5393         that only the top cmdlist commands have a null prefix.
5394
5395 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5396
5397         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
5398         as prefix, not one of its aliases.
5399         (set_cmd_prefix): Remove.
5400         (do_add_cmd): Centralize the setting of the prefix of a command, when
5401         command is defined after its full chain of prefix commands.
5402         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
5403         (add_setshow_cmd_full): Likewise.
5404         (update_prefix_field_of_prefixed_commands): New function.
5405         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
5406         update_prefix_field_of_prefixed_commands.
5407         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
5408         addresses of remote_set_cmdlist and remote_show_cmdlist given
5409         as argument, not the address of an argument.
5410         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
5411         * gdb/remote.c (_initialize_remote): Likewise.
5412
5413 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5414
5415         * cli/cli-cmds.c (alias_command): Check for an existing alias
5416         using lookup_cmd_composition, as valid_command_p is too strict
5417         and forbids aliases that are the prefix of an existing alias
5418         or command.
5419         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
5420         command is properly recognised as a valid command.
5421
5422 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5423
5424         * unittests/help-doc-selftests.c: Rename to
5425         unittests/command-def-selftests.c
5426         * unittests/command-def-selftests.c (help_doc_tests): Update some
5427         comments.
5428         (command_structure_tests, traverse_command_structure): New namespace
5429         and function.
5430         (command_structure_invariants_tests): New function.
5431         (_initialize_command_def_selftests) Renamed from
5432         _initialize_help_doc_selftests, register command_structure_invariants
5433         selftest.
5434
5435 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5436
5437         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
5438         an alias of 'show'.
5439
5440 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
5441
5442         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
5443         ada_is_fixed_point_type.  Update all callers.
5444         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
5445         all callers.
5446         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
5447         Update all callers.
5448         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
5449         print_fixed_point_type.  Update all callers.
5450         * ada-valprint.c (ada_value_print_num): Replace call to
5451         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
5452
5453 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
5454
5455         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
5456         processors.
5457         (cpu_supports_bts): Add CV_AMD case.
5458
5459 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
5460             Simon Marchi  <simon.marchi@efficios.com>
5461
5462         * infrun.c (stop_all_threads): Collect multiple wait events at
5463         each pass.
5464
5465 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
5466
5467         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
5468         type::code instead.
5469
5470 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
5471
5472         * gdbtypes.h (struct type) <code, set_code>: New methods.
5473         (TYPE_CODE): Use type::code.  Change all call sites used to set
5474         the code to use type::set_code instead.
5475
5476 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5477             Tom de Vries  <tdevries@suse.de>
5478             Pedro Alves  <palves@redhat.com>
5479
5480         PR threads/25478
5481         * infrun.c (stop_all_threads): Do NOT ignore
5482         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
5483         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
5484         received.
5485         (handle_no_resumed): Remove code handling a live inferior with no
5486         threads.
5487         * remote.c (has_single_non_exited_thread): New.
5488         (remote_target::update_thread_list): Do not delete a thread if is
5489         the last thread of the process.
5490         * thread.c (thread_select): Call delete_exited_threads instead of
5491         prune_threads.
5492
5493 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5494
5495         * infrun.c (stop_all_threads): Enable/disable thread events of all
5496         targets.  Move a debug message denoting the end of the function
5497         into the SCOPED_EXIT block.
5498
5499 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5500
5501         * process-stratum-target.h: Include <set>.
5502         (all_non_exited_process_targets, switch_to_target_no_thread): New
5503         function declarations.
5504         * process-stratum-target.c (all_non_exited_process_targets)
5505         (switch_to_target_no_thread): New function implementations.
5506
5507 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5508
5509         * infrun.c (handle_inferior_event): Extract out a piece of code
5510         into...
5511         (mark_non_executing_threads): ...this new function.
5512
5513 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5514
5515         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
5516         use.
5517
5518 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5519
5520         * regcache.c (regcache_read_pc_protected): New function
5521         implementation that returns 0 if the PC cannot read via
5522         'regcache_read_pc'.
5523         * infrun.c (proceed): Call 'regcache_read_pc_protected'
5524         instead of 'regcache_read_pc'.
5525         (keep_going_pass_signal): Ditto.
5526
5527 2020-05-13  Tom Tromey  <tromey@adacore.com>
5528
5529         * ada-lang.c (align_value): Remove.
5530         (ada_template_to_fixed_record_type_1): Use align_up.
5531
5532 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5533
5534         * async-event.c: Update the copyright year.
5535         * async-event.h: Update the copyright year.
5536
5537 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
5538
5539         * objfiles.h (is_addr_in_objfile,
5540         shared_objfile_contains_address_p): Return bool.
5541         * objfile.c (is_addr_in_objfile,
5542         shared_objfile_contains_address_p): Return bool.
5543
5544 2020-05-11  Tom Tromey  <tromey@adacore.com>
5545
5546         * cli/cli-cmds.c (info_command): Restore.
5547         (_initialize_cli_cmds): Use add_prefix_command for "info".
5548         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
5549
5550 2020-05-11  Tom Tromey  <tromey@adacore.com>
5551
5552         * ada-lang.c (ada_value_primitive_field): Now public.
5553         * ada-lang.h (ada_value_primitive_field): Declare.
5554         * ada-valprint.c (print_field_values): Use
5555         ada_value_primitive_field for wrapper fields.
5556
5557 2020-05-11  Tom de Vries  <tdevries@suse.de>
5558
5559         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
5560         MODULE_DOMAIN.
5561
5562 2020-05-11  Tom de Vries  <tdevries@suse.de>
5563
5564         PR symtab/25941
5565         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
5566         with length 0, if not gdb-produced.
5567         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
5568
5569 2020-05-09  Tom de Vries  <tdevries@suse.de>
5570
5571         PR gdb/25955
5572         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
5573         calculation.
5574
5575 2020-05-09  Tom Tromey  <tom@tromey.com>
5576
5577         * top.c (server_command): Now bool.
5578         * top.h (server_command): Now bool.
5579
5580 2020-05-08  Tom Tromey  <tromey@adacore.com>
5581
5582         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
5583         already being processed.
5584
5585 2020-05-08  Tom Tromey  <tom@tromey.com>
5586
5587         * printcmd.c (struct display) <next>: Remove.
5588         <display>: New constructor.
5589         <exp_string>: Now a std::string.
5590         <enabled_p>: Now a bool.
5591         (display_number): Move definition earlier.
5592         (displays): Rename from display_chain.  Now a std::vector.
5593         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
5594         (display_command): Update.
5595         (do_one_display, disable_display)
5596         (enable_disable_display_command, do_enable_disable_display):
5597         Update.
5598         (free_display): Remove.
5599         (clear_displays): Rewrite.
5600         (delete_display): Update.
5601         (map_display_numbers): Use function_view.  Remove "data"
5602         parameter.  Update.
5603         (do_delete_display): Remove.
5604         (undisplay_command): Update.
5605         (do_one_display, do_displays, disable_display)
5606         (info_display_command): Update.
5607         (do_enable_disable_display): Remove.
5608         (enable_disable_display_command)
5609         (clear_dangling_display_expressions): Update.
5610
5611 2020-05-08  Tom Tromey  <tom@tromey.com>
5612
5613         * symtab.c (set_symbol_cache_size)
5614         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
5615         (maintenance_print_symbol_cache_statistics): Update.
5616         * symmisc.c (print_symbol_bcache_statistics)
5617         (print_objfile_statistics, maintenance_print_objfiles)
5618         (maintenance_info_symtabs, maintenance_check_symtabs)
5619         (maintenance_expand_symtabs, maintenance_info_line_tables):
5620         Update.
5621         * symfile-debug.c (set_debug_symfile): Update.
5622         * source.c (forget_cached_source_info): Update.
5623         * python/python.c (gdbpy_progspaces): Update.
5624         * psymtab.c (maintenance_info_psymtabs): Update.
5625         * probe.c (parse_probes): Update.
5626         * linespec.c (iterate_over_all_matching_symtabs)
5627         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
5628         * guile/scm-progspace.c (gdbscm_progspaces): Update.
5629         * exec.c (exec_target::close): Update.
5630         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
5631         * breakpoint.c (print_one_breakpoint_location)
5632         (create_longjmp_master_breakpoint)
5633         (create_std_terminate_master_breakpoint): Update.
5634         * progspace.c (program_spaces): Now a std::vector.
5635         (maybe_new_address_space): Update.
5636         (add_program_space): Remove.
5637         (program_space::program_space): Update.
5638         (remove_program_space): Update.
5639         (number_of_program_spaces): Remove.
5640         (print_program_space, update_address_spaces): Update.
5641         * progspace.h (program_spaces): Change type.
5642         (ALL_PSPACES): Remove.
5643         (number_of_program_spaces): Don't declare.
5644         (struct program_space) <next>: Remove.
5645
5646 2020-05-08  Tom Tromey  <tom@tromey.com>
5647
5648         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
5649         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
5650         (enable_break): Update.
5651         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
5652         (frv_fdpic_find_canonical_descriptor): Update.
5653         (frv_fetch_objfile_link_map): Update.
5654         * progspace.c (program_space::free_all_objfiles): Update.
5655         (program_space::solibs): New method.
5656         * progspace.h (struct program_space) <solibs>: New method.
5657         * solist.h (master_so_list): Don't declare.
5658         (ALL_SO_LIBS): Remove.
5659         * solib.h (so_list_head): Remove.
5660         (update_solib_list): Update comment.
5661         * solib.c (master_so_list): Remove.
5662         (solib_used, update_solib_list, solib_add)
5663         (info_sharedlibrary_command, clear_solib)
5664         (reload_shared_libraries_1, remove_user_added_objfile): Update.
5665
5666 2020-05-08  Tom Tromey  <tom@tromey.com>
5667
5668         * extension.c (extension_languages): Now a std::array.
5669         (ALL_EXTENSION_LANGUAGES): Remove.
5670         (get_ext_lang_defn, get_ext_lang_of_file)
5671         (eval_ext_lang_from_control_command): Update.
5672         (finish_ext_lang_initialization)
5673         (auto_load_ext_lang_scripts_for_objfile)
5674         (ext_lang_type_printers::ext_lang_type_printers)
5675         (apply_ext_lang_type_printers)
5676         (ext_lang_type_printers::~ext_lang_type_printers)
5677         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
5678         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
5679         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
5680         (get_matching_xmethod_workers, ext_lang_colorize)
5681         (ext_lang_before_prompt): Update.
5682         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
5683
5684 2020-05-08  Tom Tromey  <tom@tromey.com>
5685
5686         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
5687         overload.
5688         <swap_string, m_string>: Remove.
5689         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
5690         Update.
5691         * stabsread.c (define_symbol, read_type): Update.
5692         * linespec.c (find_linespec_symbols): Update.
5693         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
5694         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
5695         * dbxread.c (read_dbx_symtab): Update.
5696         * cp-support.h (cp_canonicalize_string_full)
5697         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
5698         Return unique_xmalloc_ptr.
5699         * cp-support.c (inspect_type): Update.
5700         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
5701         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
5702         Likewise.
5703         * c-typeprint.c (print_name_maybe_canonical): Update.
5704         * break-catch-throw.c (check_status_exception_catchpoint):
5705         Update.
5706
5707 2020-05-08  Tom de Vries  <tdevries@suse.de>
5708
5709         * infrun.c (follow_fork): Copy current_line and current_symtab to
5710         child thread.
5711
5712 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5713
5714         * async-event.c (struct async_signal_handler, struct
5715         async_event_handler): Reformat, remove typedef.
5716
5717 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5718
5719         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
5720         access thistype->main_type->dyn_prop_list directly.
5721
5722 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5723
5724         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
5725         (remove_dyn_prop): Remove.  Update all users to use
5726         type::remove_dyn_prop.
5727         * gdbtypes.c (remove_dyn_prop): Rename to...
5728         (type::remove_dyn_prop): ... this.
5729
5730 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
5731
5732         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
5733         (add_dyn_prop): Remove.  Update all users to use
5734         type::add_dyn_prop.
5735         * gdbtypes.c (add_dyn_prop): Rename to...
5736         (type::add_dyn_prop): ... this.
5737
5738 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
5739
5740         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
5741         (get_dyn_prop): Remove.  Update all users to use
5742         type::dyn_prop.
5743         * gdbtypes.c (get_dyn_prop): Rename to...
5744         (type::dyn_prop): ... this.
5745
5746 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5747
5748         * gdbtypes.h (struct main_type) <flag_static>: Remove.
5749
5750 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
5751
5752         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
5753         instruction, skip it if it's there.
5754
5755 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
5756
5757         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
5758
5759 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
5760
5761         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
5762         * gdbtypes.c (recursive_dump_type): Remove use of
5763         TYPE_INCOMPLETE.
5764
5765 2020-05-03  Tom Tromey  <tom@tromey.com>
5766
5767         * breakpoint.c (catch_command, tcatch_command): Remove.
5768         (_initialize_breakpoint): Use add_basic_prefix_cmd,
5769         add_show_prefix_cmd.
5770         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
5771         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
5772         Remove.
5773         (add_internal_problem_command): Use add_basic_prefix_cmd,
5774         add_show_prefix_cmd.
5775         * mips-tdep.c (set_mipsfpu_command): Remove.
5776         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
5777         * dwarf2/index-cache.c (set_index_cache_command): Remove.
5778         (_initialize_index_cache): Use add_basic_prefix_cmd.
5779         * memattr.c (dummy_cmd): Remove.
5780         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
5781         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
5782         (_initialize_tui_win): Use add_basic_prefix_cmd,
5783         add_show_prefix_cmd.
5784         * cli/cli-logging.c (set_logging_command): Remove.
5785         (_initialize_cli_logging): Use add_basic_prefix_cmd,
5786         add_show_prefix_cmd.
5787         (show_logging_command): Remove.
5788         * target.c (target_command): Remove.
5789         (add_target): Use add_basic_prefix_cmd.
5790
5791 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
5792
5793         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
5794
5795 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5796
5797         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
5798         info_command.
5799
5800 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
5801
5802         * nbsd-nat.c (nbsd_enable_proc_events)
5803         (nbsd_nat_target::post_startup_inferior): Add.
5804         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
5805         (nbsd_nat_target::update_thread_list): Rewrite.
5806         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
5807         "PTRACE_LWP_CREATE".
5808         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
5809
5810 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5811
5812         * stack.c (_initialize_stack): Remove duplicated creation
5813         of "frame" command and "f" alias.
5814
5815 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5816
5817         PR gdb/18706
5818         * gdbtypes.c (check_typedef): Calculate size of array of
5819         stubbed type.
5820
5821 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
5822
5823         PR gdb/15559
5824         * i386-tdep.c (i386_push_dummy_call): Call
5825         i386_thiscall_push_dummy_call.
5826         (i386_thiscall_push_dummy_call): New function.
5827         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
5828         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
5829         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
5830
5831 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5832
5833         * gdbarch.sh (do_read): Add shellcheck disable directive for
5834         warning SC2162.
5835
5836 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5837
5838         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
5839         "referenced but not assigned" warning.
5840
5841 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5842
5843         * gdbarch.sh: Remove code that sets fallbackdefault.
5844
5845 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5846
5847         * gdbarch.sh: Use shell operators && and || instead of
5848         -a and -o.
5849
5850 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5851
5852         * gdbarch.sh: Use $(...) instead of `...`.
5853
5854 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5855
5856         * gdbarch.sh: Use double quotes around variables.
5857
5858 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
5859
5860         * gdbarch.sh: Use %s with printf, instead of variables in the
5861         format string.
5862
5863 2020-04-29  Tom Tromey  <tromey@adacore.com>
5864
5865         PR ada/25875:
5866         * dwarf2/read.c (update_enumeration_type_from_children): Compute
5867         type fields here.
5868         (read_enumeration_type): Call
5869         update_enumeration_type_from_children later.  Update comments.
5870         (process_enumeration_scope): Don't create type fields.
5871
5872 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5873
5874         * nbsd-tdep.c: Include "xml-syscall.h".
5875         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
5876
5877 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
5878
5879         * nbsd-nat.c: Include "sys/wait.h".
5880         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
5881         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
5882         (nbsd_nat_target::remove_exec_catchpoint)
5883         (nbsd_nat_target::set_syscall_catchpoint): Add.
5884         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
5885         (nbsd_nat_target::insert_exec_catchpoint)
5886         (nbsd_nat_target::remove_exec_catchpoint)
5887         (nbsd_nat_target::set_syscall_catchpoint): Add.
5888         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
5889         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
5890         `nbsd_get_syscall_number'.
5891
5892 2020-04-29  Tom Tromey  <tom@tromey.com>
5893
5894         * stack.c (print_block_frame_labels): Remove.
5895
5896 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
5897
5898         PR gdb/17320
5899         * ada-valprint.c (val_print_packed_array_elements): Move array
5900         end bracket to new line.
5901         (ada_val_print_string): Remove extra spaces before first array
5902         element.
5903         * c-valprint.c (c_value_print_array): Likewise.
5904         * m2-valprint.c (m2_print_array_contents): Likewise.
5905         (m2_value_print_inner): Likewise.
5906         * p-valprint.c (pascal_value_print_inner): Likewise.
5907         * valprint.c (generic_val_print_array): Likewise.
5908         (value_print_array_elements): Move first array element and array
5909         end bracket to new line.
5910
5911 2020-04-29  Tom de Vries  <tdevries@suse.de>
5912
5913         PR symtab/25889
5914         * linespec.c (find_method): Fix ix calculation.
5915
5916 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
5917
5918         * syscalls/update-netbsd.sh: New file.
5919         * syscalls/netbsd.xml: Regenerate.
5920         * data-directory/Makefile.in: Register `netbsd.xml' in
5921         `SYSCALLS_FILES'.
5922
5923 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5924
5925         * syscalls/update-freebsd.sh: Add double quotes.
5926
5927 2020-04-28  Tom Tromey  <tom@tromey.com>
5928
5929         * NEWS: Update.
5930         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
5931         (cmdpy_init): Allow class_tui.
5932
5933 2020-04-28 Mark Williams <mark@myosotissp.com>
5934
5935         PR gdb/24480
5936         * dwarf2read.c: Add missing assingments to list_in_scope when
5937         start_symtab was already called.
5938
5939 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
5940
5941         PR gdb/25881
5942         * dwarf2/read.c (offset_map_type): Use
5943         gdb:hash_enum<sect_offset> as hash function.
5944
5945 2020-04-28  Tom de Vries  <tdevries@suse.de>
5946
5947         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
5948         with DW_AT_signature.
5949
5950 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
5951
5952         * configure.ac: Remove check for fs_base/gs_base in
5953         user_regs_struct.
5954         * configure: Re-generate.
5955         * config.in: Re-generate.
5956         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
5957         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
5958         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
5959
5960 2020-04-27  Luis Machado  <luis.machado@linaro.org>
5961
5962         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
5963         problematic inline frame unwinding situation.
5964         * frame.c (frame_id_computed_p): New function.
5965         * frame.h (frame_id_computed_p): New prototype.
5966
5967 2020-04-26  Tom Tromey  <tom@tromey.com>
5968
5969         * command.h (enum command_class) <class_pseudo>: Remove.
5970
5971 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5972
5973         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
5974         and whitespace.
5975
5976 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
5977
5978         * inf-ptrace.c (inf_ptrace_target::wait): Remove
5979         `PT_GET_PROCESS_STATE' block.
5980
5981 2020-04-24  Tom Tromey  <tom@tromey.com>
5982
5983         * symtab.h (symbol_get_demangled_name): Don't declare.
5984         * symtab.c (symbol_get_demangled_name): Remove.
5985         (general_symbol_info::natural_name)
5986         (general_symbol_info::demangled_name): Update.
5987
5988 2020-04-24  Tom Tromey  <tom@tromey.com>
5989
5990         PR rust/25025:
5991         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
5992
5993 2020-04-24  Tom Tromey  <tom@tromey.com>
5994
5995         PR symtab/12707:
5996         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
5997         exists.
5998         (new_symbol): Likewise.
5999         * compile/compile-object-load.c (get_out_value_type): Use
6000         symbol_matches_search_name.
6001
6002 2020-04-24  Tom Tromey  <tom@tromey.com>
6003
6004         * dwarf2/read.c (add_partial_symbol): Do not call
6005         compute_and_set_names.
6006
6007 2020-04-24  Tom Tromey  <tom@tromey.com>
6008
6009         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
6010         overload.
6011
6012 2020-04-24  Tom Tromey  <tom@tromey.com>
6013
6014         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
6015         (add_psymbol_to_list): New overload.  Make old overload call new
6016         one.
6017         * psympriv.h (add_psymbol_to_list): New overload.
6018
6019 2020-04-24  Tom Tromey  <tom@tromey.com>
6020
6021         * dwarf2/read.c (partial_die_info::read) <case
6022         DW_AT_linkage_name>: Use value_as_string.
6023         (dwarf2_string_attr): Use value_as_string.
6024         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
6025         method.
6026         * dwarf2/attribute.c (attribute::value_as_string): New method.
6027
6028 2020-04-24  Tom Tromey  <tom@tromey.com>
6029
6030         * symtab.c (general_symbol_info::natural_name)
6031         (general_symbol_info::demangled_name): Check for language_rust.
6032
6033 2020-04-24  Tom Tromey  <tom@tromey.com>
6034
6035         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
6036         (dwarf2_physname): ... from here.
6037         (partial_die_info::read): Add Rust "{" hack.
6038
6039 2020-04-24  Tom Tromey  <tom@tromey.com>
6040
6041         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
6042         method.
6043         (symbol_set_demangled_name): Don't declare.
6044         * symtab.c (general_symbol_info::set_demangled_name): Rename from
6045         symbol_set_demangled_name.
6046         (general_symbol_info::set_language)
6047         (general_symbol_info::compute_and_set_names): Update.
6048         * minsyms.c (minimal_symbol_reader::install): Update.
6049         * dwarf2/read.c (new_symbol): Update.
6050
6051 2020-04-24  Tom Tromey  <tromey@adacore.com>
6052
6053         PR python/23662:
6054         * python/py-type.c (convert_field): Handle
6055         FIELD_LOC_KIND_DWARF_BLOCK.
6056         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
6057         (typy_get_dynamic): Nw function.
6058         (type_object_getset): Add "dynamic".
6059         * NEWS: Add entry.
6060
6061 2020-04-24  Tom Tromey  <tromey@adacore.com>
6062
6063         * ada-typeprint.c (print_choices, print_variant_part)
6064         (print_record_field_types_dynamic): New functions.
6065         (print_record_field_types): Use print_record_field_types_dynamic.
6066
6067 2020-04-24  Tom Tromey  <tromey@adacore.com>
6068
6069         * dwarf2/read.c (handle_data_member_location): New overload.
6070         (dwarf2_add_field): Use it.
6071         (decode_locdesc): Add "computed" parameter.  Update comment.
6072         * gdbtypes.c (is_dynamic_type_internal): Also look for
6073         FIELD_LOC_KIND_DWARF_BLOCK.
6074         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
6075         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
6076         virtual base classes.
6077         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
6078         FIELD_LOC_KIND_DWARF_BLOCK.
6079
6080 2020-04-24  Tom Tromey  <tromey@adacore.com>
6081
6082         * dwarf2/read.c (read_structure_type): Handle dynamic length.
6083         * gdbtypes.c (is_dynamic_type_internal): Check
6084         TYPE_HAS_DYNAMIC_LENGTH.
6085         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
6086         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
6087         New macros.
6088         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
6089         constant.
6090
6091 2020-04-24  Tom Tromey  <tromey@adacore.com>
6092
6093         * dwarf2/read.c (struct variant_field): Rewrite.
6094         (struct variant_part_builder): New.
6095         (struct nextfield): Remove "variant" field.  Add "offset".
6096         (struct field_info): Add "current_variant_part" and
6097         "variant_parts".
6098         (alloc_discriminant_info): Remove.
6099         (alloc_rust_variant): New function.
6100         (quirk_rust_enum): Update.
6101         (dwarf2_add_field): Set "offset" member.  Don't handle
6102         DW_TAG_variant_part.
6103         (offset_map_type): New typedef.
6104         (convert_variant_range, create_one_variant)
6105         (create_one_variant_part, create_variant_parts)
6106         (add_variant_property): New functions.
6107         (dwarf2_attach_fields_to_type): Call add_variant_property.
6108         (read_structure_type): Don't handle DW_TAG_variant_part.
6109         (handle_variant_part, handle_variant): New functions.
6110         (handle_struct_member_die): Use them.
6111         (process_structure_scope): Don't handle variant parts.
6112         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
6113         (struct discriminant_info): Remove.
6114         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
6115         (struct main_type) <flag_discriminated_union>: Remove.
6116         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
6117         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
6118         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
6119         Update.
6120         * valops.c (value_union_variant): Remove.
6121         * value.h (value_union_variant): Don't declare.
6122
6123 2020-04-24  Tom Tromey  <tromey@adacore.com>
6124
6125         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
6126         (ada_value_primitive_packed_val): Update.
6127         * ada-valprint.c (ada_value_print_1): Update.
6128         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
6129         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
6130         just an address.  Use evaluate_for_locexpr_baton.
6131         (dwarf2_evaluate_property): Update.
6132         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
6133         array_view.
6134         * findvar.c (default_read_var_value): Update.
6135         * gdbtypes.c (compute_variant_fields_inner)
6136         (resolve_dynamic_type_internal): Update.
6137         (resolve_dynamic_type): Change type of valaddr parameter.
6138         * gdbtypes.h (resolve_dynamic_type): Update.
6139         * valarith.c (value_subscripted_rvalue): Update.
6140         * value.c (value_from_contents_and_address): Update.
6141
6142 2020-04-24  Tom Tromey  <tromey@adacore.com>
6143
6144         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
6145         "push_initial_value" parameter.
6146         (dwarf2_evaluate_property): Likewise.
6147         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
6148
6149 2020-04-24  Tom Tromey  <tromey@adacore.com>
6150
6151         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
6152         (variant::matches, compute_variant_fields_recurse)
6153         (compute_variant_fields_inner, compute_variant_fields): New
6154         functions.
6155         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
6156         Use resolved_type after type is made.
6157         (operator==): Add new cases.
6158         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
6159         (struct discriminant_range, struct variant, struct variant_part):
6160         New.
6161         (union dynamic_prop_data) <variant_parts, original_type>: New
6162         members.
6163         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
6164         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
6165         constants.
6166         * value.c (unpack_bits_as_long): Now public.
6167         * value.h (unpack_bits_as_long): Declare.
6168
6169 2020-04-24  Tom Tromey  <tromey@adacore.com>
6170
6171         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
6172         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
6173
6174 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
6175
6176         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
6177
6178 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
6179
6180         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
6181         (remove_fork_catchpoint, post_startup_inferior)
6182         (post_attach): Move...
6183         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
6184         (remove_fork_catchpoint, post_startup_inferior)
6185         (post_attach): ...here.
6186         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
6187         (remove_fork_catchpoint, post_startup_inferior)
6188         (post_attach): Move...
6189         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
6190         (remove_fork_catchpoint, post_startup_inferior)
6191         (post_attach): ...here.
6192
6193 2020-04-24  Tom Tromey  <tromey@adacore.com>
6194
6195         * nat/windows-nat.h (struct windows_thread_info)
6196         <pc_adjusted>: New member.
6197         * windows-nat.c (windows_fetch_one_register): Check
6198         pc_adjusted.
6199         (windows_nat_target::get_windows_debug_event)
6200         (windows_nat_target::wait): Set pc_adjusted.
6201
6202 2020-04-24  Tom de Vries  <tdevries@suse.de>
6203
6204         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
6205         Run gdb-add-index inside temp dir.
6206
6207 2020-04-23  Tom Tromey  <tromey@adacore.com>
6208
6209         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
6210         in loop.
6211
6212 2020-04-23  Luis Machado  <luis.machado@linaro.org>
6213
6214         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
6215         get_frame_register instead of gdbarch_unwind_pc.
6216
6217 2020-04-23  Tom de Vries  <tdevries@suse.de>
6218
6219         * symtab.c (lookup_global_symbol): Prefer def over decl.
6220
6221 2020-04-23  Tom de Vries  <tdevries@suse.de>
6222
6223         PR symtab/25807
6224         * block.c (best_symbol, better_symbol): Promote to external.
6225         * block.h (best_symbol, better_symbol): Declare.
6226         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
6227         decl.
6228
6229 2020-04-23  Tom Tromey  <tromey@adacore.com>
6230
6231         PR ada/25837:
6232         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
6233         "const char *", not a "const std::string &".
6234         <name_and_matcher::operator==>: Update.
6235         * unittests/lookup_name_info-selftests.c: Change type of
6236         "result".
6237
6238 2020-04-23  Tom Tromey  <tom@tromey.com>
6239
6240         * inferior.h (iterate_over_inferiors): Don't declare.
6241         * inferior.c (iterate_over_inferiors): Remove.
6242         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
6243         Remove.
6244         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
6245         use iterate_over_inferiors.
6246         (darwin_resume_inferior_it)
6247         (struct resume_inferior_threads_param)
6248         (darwin_resume_inferior_threads_it): Remove.
6249         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
6250
6251 2020-04-23  Tom de Vries  <tdevries@suse.de>
6252
6253         * blockframe.c (find_pc_partial_function): Use
6254         find_pc_sect_compunit_symtab rather than
6255         objfile->sf->qf->find_pc_sect_compunit_symtab.
6256
6257 2020-04-22  Tom de Vries  <tdevries@suse.de>
6258
6259         PR symtab/25764
6260         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
6261         in psymtabs.
6262
6263 2020-04-22  Tom de Vries  <tdevries@suse.de>
6264
6265         PR symtab/25801
6266         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
6267         symtabs.
6268
6269 2020-04-22  Tom de Vries  <tdevries@suse.de>
6270
6271         PR symtab/25700
6272         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
6273         CU if already created.
6274
6275 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6276
6277         * infrun.c (displaced_step_fixup): Switch to the event_thread
6278         before calling displaced_step_restore, not after.
6279
6280 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6281
6282         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
6283         its inferior is not recorded by us.
6284         (record_btrace_target_open): Replace call to
6285         all_non_exited_threads () with call to current_inferior
6286         ()->non_exited_threads ().
6287         (record_btrace_target::stop_recording): Likewise.
6288         (record_btrace_target::close): Likewise.
6289         (record_btrace_target::wait): Likewise.
6290         (record_btrace_target::record_stop_replaying): Likewise.
6291
6292 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6293
6294         * btrace.c (btrace_enable): Throw an error on double enables and
6295         when enabling recording fails.
6296         (btrace_disable): Throw an error if the thread is not recorded.
6297
6298 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
6299
6300         * record-btrace.c (record_btrace_target::fetch_registers): Forward
6301         request if we do not have a thread_info.
6302
6303 2020-04-21  Tom de Vries  <tdevries@suse.de>
6304
6305         PR gdb/25471
6306         * thread.c
6307         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
6308         exception in get_frame_id.
6309
6310 2020-04-20  Tom Tromey  <tromey@adacore.com>
6311
6312         * python/python.c (struct gdbpy_event): Mark move constructor as
6313         noexcept.
6314         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
6315         constructor as noexcept.
6316         * completer.h (struct completion_result): Mark move constructor as
6317         noexcept.
6318         * completer.c (completion_result::completion_result): Use
6319         initialization style.  Don't call reset_match_list.
6320
6321 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
6322
6323         * MAINTAINERS (Write After Approval): Add myself.
6324
6325 2020-04-18  Tom Tromey  <tom@tromey.com>
6326
6327         * windows-tdep.c (init_w32_command_list)
6328         (w32_prefix_command_valid): Restore.
6329         (_initialize_windows_tdep): Call init_w32_command_list.
6330
6331 2020-04-18  Tom Tromey  <tom@tromey.com>
6332
6333         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
6334         * value.c (value_fn_field): Update.
6335         * valops.c (find_function_in_inferior)
6336         (value_allocate_space_in_inferior): Update.
6337         * tui/tui-winsource.c (tui_update_source_windows_with_line):
6338         Update.
6339         * tui/tui-source.c (tui_source_window::set_contents): Update.
6340         * symtab.c (lookup_global_or_static_symbol)
6341         (find_function_start_sal_1, skip_prologue_sal)
6342         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
6343         * symmisc.c (dump_msymbols, dump_symtab_1)
6344         (maintenance_print_one_line_table): Update.
6345         * symfile.c (init_entry_point_info, section_is_mapped)
6346         (list_overlays_command, simple_read_overlay_table)
6347         (simple_overlay_update_1): Update.
6348         * stap-probe.c (handle_stap_probe): Update.
6349         * stabsread.c (dbx_init_float_type, define_symbol)
6350         (read_one_struct_field, read_enum_type, read_range_type): Update.
6351         * source.c (info_line_command): Update.
6352         * python/python.c (gdbpy_source_objfile_script)
6353         (gdbpy_execute_objfile_script): Update.
6354         * python/py-type.c (save_objfile_types): Update.
6355         * python/py-objfile.c (py_free_objfile): Update.
6356         * python/py-inferior.c (python_new_objfile): Update.
6357         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
6358         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
6359         (maintenance_check_psymtabs): Update.
6360         * printcmd.c (info_address_command): Update.
6361         * objfiles.h (struct objfile) <arch>: New method, from
6362         get_objfile_arch.
6363         (get_objfile_arch): Don't declare.
6364         * objfiles.c (get_objfile_arch): Remove.
6365         (filter_overlapping_sections): Update.
6366         * minsyms.c (msymbol_is_function): Update.
6367         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
6368         (output_nondebug_symbol): Update.
6369         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
6370         (mdebug_expand_psymtab): Update.
6371         * machoread.c (macho_add_oso_symfile): Update.
6372         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
6373         Update.
6374         * linux-fork.c (checkpoint_command): Update.
6375         * linespec.c (convert_linespec_to_sals): Update.
6376         * jit.c (finalize_symtab): Update.
6377         * infrun.c (insert_exception_resume_from_probe): Update.
6378         * ia64-tdep.c (ia64_find_unwind_table): Update.
6379         * hppa-tdep.c (internalize_unwinds): Update.
6380         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
6381         Update.
6382         * gcore.c (call_target_sbrk): Update.
6383         * elfread.c (record_minimal_symbol, elf_symtab_read)
6384         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
6385         (elf_gnu_ifunc_resolve_by_got): Update.
6386         * dwarf2/read.c (create_addrmap_from_index)
6387         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6388         (read_debug_names_from_section)
6389         (process_psymtab_comp_unit_reader, add_partial_symbol)
6390         (add_partial_subprogram, process_full_comp_unit)
6391         (read_file_scope, read_func_scope, read_lexical_block_scope)
6392         (read_call_site_scope, dwarf2_ranges_read)
6393         (dwarf2_record_block_ranges, dwarf2_add_field)
6394         (mark_common_block_symbol_computed, read_tag_pointer_type)
6395         (read_tag_string_type, dwarf2_init_float_type)
6396         (dwarf2_init_complex_target_type, read_base_type)
6397         (partial_die_info::read, partial_die_info::read)
6398         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
6399         (dwarf2_fetch_die_loc_sect_off): Update.
6400         * dwarf2/loc.c (dwarf2_find_location_expression)
6401         (class dwarf_evaluate_loc_desc, rw_pieced_value)
6402         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
6403         (dwarf2_loc_desc_get_symbol_read_needs)
6404         (locexpr_describe_location_piece, locexpr_describe_location_1)
6405         (loclist_describe_location): Update.
6406         * dwarf2/index-write.c (write_debug_names): Update.
6407         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
6408         * dtrace-probe.c (dtrace_process_dof): Update.
6409         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
6410         (process_one_symbol): Update.
6411         * ctfread.c (ctf_init_float_type, read_base_type): Update.
6412         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
6413         (coff_read_enum_type): Update.
6414         * cli/cli-cmds.c (edit_command, list_command): Update.
6415         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
6416         * breakpoint.c (create_overlay_event_breakpoint)
6417         (create_longjmp_master_breakpoint)
6418         (create_std_terminate_master_breakpoint)
6419         (create_exception_master_breakpoint, get_sal_arch): Update.
6420         * block.c (block_gdbarch): Update.
6421         * annotate.c (annotate_source_line): Update.
6422
6423 2020-04-17  Tom Tromey  <tromey@adacore.com>
6424
6425         * auto-load.c (show_auto_load_cmd): Remove.
6426         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
6427         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
6428         (maintenance_print_arc_command): Remove.
6429         * tui/tui-win.c (tui_command): Remove.
6430         (tui_get_cmd_list): Use add_basic_prefix_cmd.
6431         * tui/tui-layout.c (tui_layout_command): Remove.
6432         (_initialize_tui_layout): Use add_basic_prefix_cmd.
6433         * python/python.c (user_set_python, user_show_python): Remove.
6434         (_initialize_python): Use add_basic_prefix_cmd,
6435         add_show_prefix_cmd.
6436         * guile/guile.c (set_guile_command, show_guile_command): Remove.
6437         (install_gdb_commands): Use add_basic_prefix_cmd,
6438         add_show_prefix_cmd.
6439         (info_guile_command): Remove.
6440         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
6441         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
6442         add_show_prefix_cmd.
6443         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
6444         Remove do_set and do_show parameters.
6445         * cli/cli-style.c (set_style, show_style): Remove.
6446         (_initialize_cli_style): Use add_basic_prefix_cmd,
6447         add_show_prefix_cmd.
6448         (cli_style_option::add_setshow_commands): Remove do_set and
6449         do_show parameters.
6450         (cli_style_option::add_setshow_commands): Use
6451         add_basic_prefix_cmd, add_show_prefix_cmd.
6452         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
6453         (set_style_name): Remove.
6454         * cli/cli-dump.c (dump_command, append_command): Remove.
6455         (srec_dump_command, ihex_dump_command, verilog_dump_command)
6456         (tekhex_dump_command, binary_dump_command)
6457         (binary_append_command): Remove.
6458         (_initialize_cli_dump): Use add_basic_prefix_cmd.
6459         * windows-tdep.c (w32_prefix_command_valid): Remove global.
6460         (init_w32_command_list): Remove; move into ...
6461         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
6462         * valprint.c (set_print, show_print, set_print_raw)
6463         (show_print_raw): Remove.
6464         (_initialize_valprint): Use add_basic_prefix_cmd,
6465         add_show_prefix_cmd.
6466         * typeprint.c (set_print_type, show_print_type): Remove.
6467         (_initialize_typeprint): Use add_basic_prefix_cmd,
6468         add_show_prefix_cmd.
6469         * record.c (set_record_command, show_record_command): Remove.
6470         (_initialize_record): Use add_basic_prefix_cmd,
6471         add_show_prefix_cmd.
6472         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
6473         add_show_prefix_cmd.
6474         (info_command, show_command, set_debug, show_debug): Remove.
6475         * top.h (set_history, show_history): Don't declare.
6476         * top.c (set_history, show_history): Remove.
6477         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
6478         (unset_tdesc_cmd): Remove.
6479         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
6480         add_show_prefix_cmd.
6481         * symtab.c (info_module_command): Remove.
6482         (_initialize_symtab): Use add_basic_prefix_cmd.
6483         * symfile.c (overlay_command): Remove.
6484         (_initialize_symfile): Use add_basic_prefix_cmd.
6485         * sparc64-tdep.c (info_adi_command): Remove.
6486         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
6487         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
6488         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
6489         add_show_prefix_cmd.
6490         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
6491         (_initialize_serial): Use add_basic_prefix_cmd,
6492         add_show_prefix_cmd.
6493         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
6494         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
6495         add_show_prefix_cmd.
6496         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
6497         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
6498         add_show_prefix_cmd.
6499         * riscv-tdep.c (show_riscv_command, set_riscv_command)
6500         (show_debug_riscv_command, set_debug_riscv_command): Remove.
6501         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
6502         add_show_prefix_cmd.
6503         * remote.c (remote_command, set_remote_cmd): Remove.
6504         (_initialize_remote): Use add_basic_prefix_cmd.
6505         * record-full.c (set_record_full_command)
6506         (show_record_full_command): Remove.
6507         (_initialize_record_full): Use add_basic_prefix_cmd,
6508         add_show_prefix_cmd.
6509         * record-btrace.c (cmd_set_record_btrace)
6510         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
6511         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
6512         (cmd_show_record_btrace_pt): Remove.
6513         (_initialize_record_btrace): Use add_basic_prefix_cmd,
6514         add_show_prefix_cmd.
6515         * ravenscar-thread.c (set_ravenscar_command)
6516         (show_ravenscar_command): Remove.
6517         (_initialize_ravenscar): Use add_basic_prefix_cmd,
6518         add_show_prefix_cmd.
6519         * mips-tdep.c (show_mips_command, set_mips_command)
6520         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
6521         add_show_prefix_cmd.
6522         * maint.c (maintenance_command, maintenance_info_command)
6523         (maintenance_check_command, maintenance_print_command)
6524         (maintenance_set_cmd, maintenance_show_cmd): Remove.
6525         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
6526         add_show_prefix_cmd.
6527         (show_per_command_cmd): Remove.
6528         * maint-test-settings.c (maintenance_set_test_settings_cmd):
6529         Remove.
6530         (maintenance_show_test_settings_cmd): Remove.
6531         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
6532         add_show_prefix_cmd.
6533         * maint-test-options.c (maintenance_test_options_command):
6534         Remove.
6535         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
6536         * macrocmd.c (macro_command): Remove
6537         (_initialize_macrocmd): Use add_basic_prefix_cmd.
6538         * language.c (set_check, show_check): Remove.
6539         (_initialize_language): Use add_basic_prefix_cmd,
6540         add_show_prefix_cmd.
6541         * infcmd.c (unset_command): Remove.
6542         (_initialize_infcmd): Use add_basic_prefix_cmd.
6543         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
6544         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
6545         add_show_prefix_cmd.
6546         * go32-nat.c (go32_info_dos_command): Remove.
6547         (_initialize_go32_nat): Use add_basic_prefix_cmd.
6548         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
6549         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
6550         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
6551         (_initialize_frame): Use add_basic_prefix_cmd,
6552         add_show_prefix_cmd.
6553         * dcache.c (set_dcache_command, show_dcache_command): Remove.
6554         (_initialize_dcache): Use add_basic_prefix_cmd,
6555         add_show_prefix_cmd.
6556         * cp-support.c (maint_cplus_command): Remove.
6557         (_initialize_cp_support): Use add_basic_prefix_cmd.
6558         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
6559         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
6560         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
6561         add_basic_prefix_cmd, add_show_prefix_cmd.
6562         * breakpoint.c (save_command): Remove.
6563         (_initialize_breakpoint): Use add_basic_prefix_cmd.
6564         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
6565         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
6566         add_show_prefix_cmd.
6567         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
6568         (set_ada_command, show_ada_command): Remove.
6569         (_initialize_ada_language): Use add_basic_prefix_cmd,
6570         add_show_prefix_cmd.
6571         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
6572
6573 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
6574
6575         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
6576         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
6577
6578 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6579
6580         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
6581         warning messages.
6582
6583 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
6584
6585         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
6586         import table is not at beginning of .idata section.
6587
6588 2020-04-16  Pedro Alves  <palves@redhat.com>
6589
6590         * inferior.c (delete_inferior): Use delete operator directly
6591         instead of delete_program_space.
6592         * progspace.c (add_program_space): New, factored out from
6593         program_space::program_space.
6594         (remove_program_space): New, factored out from
6595         delete_program_space.
6596         (program_space::program_space): Remove intro comment.  Rewrite.
6597         (program_space::~program_space): Remove intro comment.  Call
6598         remove_program_space.
6599         (delete_program_space): Delete.
6600         * progspace.h (program_space::program_space): Make explicit.  Move
6601         intro comment here, adjusted.
6602         (program_space::~program_space): Move intro comment here,
6603         adjusted.
6604         (delete_program_space): Remove.
6605
6606 2020-04-16  Tom Tromey  <tromey@adacore.com>
6607
6608         * windows-nat.c (windows_nat::handle_access_violation): New
6609         function.
6610         * nat/windows-nat.h (handle_access_violation): Declare.
6611         * nat/windows-nat.c (handle_exception): Move Cygwin code to
6612         windows-nat.c.  Call handle_access_violation.
6613
6614 2020-04-16  Tom de Vries  <tdevries@suse.de>
6615
6616         PR symtab/25791
6617         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
6618         CUs without psymtab.
6619
6620 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
6621
6622         * python/python.c (do_start_initialization): Don't call
6623         PyEval_InitThreads for Python 3.9 and beyond.
6624
6625 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
6626
6627         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
6628         thread functions.
6629         (obsd_nat_target::wait): Likewise.
6630
6631 2020-04-15  Tom Tromey  <tromey@adacore.com>
6632
6633         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
6634         (DEBUG_EXCEPT): Use debug_printf.
6635
6636 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6637
6638         * completer.c (class completion_tracker::completion_hash_entry)
6639         <hash_name>: New member function.
6640         (completion_tracker::discard_completions): New callback to hash a
6641         completion_hash_entry, pass this to htab_create_alloc.
6642
6643 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
6644
6645         * windows-nat.c (windows_make_so): Warn rather than stopping with
6646         an error if realpath() fails.
6647
6648 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
6649
6650         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
6651         (nbsd_nat_target::info_proc): Add do_status.
6652
6653 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
6654             Tom de Vries  <tdevries@suse.de>
6655
6656         PR symtab/25718
6657         * psympriv.h (struct partial_symtab::read_symtab)
6658         (struct partial_symtab::expand_psymtab)
6659         (struct partial_symtab::read_dependencies): Update comments.
6660         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
6661         read_symtab for includer.
6662         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
6663         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
6664         (struct dwarf2_include_psymtab::m_readin): Remove.
6665         (struct dwarf2_include_psymtab::includer): New member function.
6666         (dwarf2_psymtab::expand_psymtab): Assert !readin.
6667
6668 2020-04-14  Tom de Vries  <tdevries@suse.de>
6669
6670         PR symtab/25720
6671         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
6672         with NULL symbol_matcher and lookup_name.
6673         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
6674         and lookup_name.
6675         * dwarf2/read.c (dw2_expand_symtabs_matching)
6676         (dw2_debug_names_expand_symtabs_matching): Same.
6677         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
6678         Make lookup_name a pointer.  Update comment.
6679         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
6680         lookup_name being a pointer.
6681         * symfile.c (expand_symtabs_matching): Same.
6682         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
6683         * linespec.c (iterate_over_all_matching_symtabs): Same.
6684
6685 2020-04-13  Tom Tromey  <tom@tromey.com>
6686
6687         * run-on-main-thread.c: Update include.
6688         * unittests/main-thread-selftests.c: Update include.
6689         * tui/tui-win.c: Update include.
6690         * tui/tui-io.c: Update include.
6691         * tui/tui-interp.c: Update include.
6692         * tui/tui-hooks.c: Update include.
6693         * top.h: Update include.
6694         * top.c: Update include.
6695         * ser-base.c: Update include.
6696         * remote.c: Update include.
6697         * remote-notif.c: Update include.
6698         * remote-fileio.c: Update include.
6699         * record-full.c: Update include.
6700         * record-btrace.c: Update include.
6701         * python/python.c: Update include.
6702         * posix-hdep.c: Update include.
6703         * mingw-hdep.c: Update include.
6704         * mi/mi-main.c: Update include.
6705         * mi/mi-interp.c: Update include.
6706         * main.c: Update include.
6707         * linux-nat.c: Update include.
6708         * interps.c: Update include.
6709         * infrun.c: Update include.
6710         * inf-loop.c: Update include.
6711         * event-top.c: Update include.
6712         * event-loop.c: Move to ../gdbsupport/.
6713         * event-loop.h: Move to ../gdbsupport/.
6714         * async-event.h: Update include.
6715         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
6716
6717 2020-04-13  Tom Tromey  <tom@tromey.com>
6718
6719         * tui/tui-win.c: Include async-event.h.
6720         * remote.c: Include async-event.h.
6721         * remote-notif.c: Include async-event.h.
6722         * record-full.c: Include async-event.h.
6723         * record-btrace.c: Include async-event.h.
6724         * infrun.c: Include async-event.h.
6725         * event-top.c: Include async-event.h.
6726         * event-loop.h: Move some declarations to async-event.h.
6727         * event-loop.c: Don't include ser-event.h or top.h.  Move some
6728         code to async-event.c.
6729         * async-event.h: New file.
6730         * async-event.c: New file.
6731         * Makefile.in (COMMON_SFILES): Add async-event.c.
6732         (HFILES_NO_SRCDIR): Add async-event.h.
6733
6734 2020-04-13  Tom Tromey  <tom@tromey.com>
6735
6736         * utils.c (flush_streams): New function.
6737         * event-loop.c (gdb_wait_for_event): Call flush_streams.
6738
6739 2020-04-13  Tom Tromey  <tom@tromey.com>
6740
6741         * event-loop.c (handle_file_event): Use warning, not
6742         printf_unfiltered.
6743
6744 2020-04-13  Tom Tromey  <tom@tromey.com>
6745
6746         * event-loop.c: Include <chrono>.
6747
6748 2020-04-13  Tom Tromey  <tom@tromey.com>
6749
6750         * gdb_select.h: Move to ../gdbsupport/.
6751         * event-loop.c: Update include path.
6752         * top.c: Update include path.
6753         * ser-base.c: Update include path.
6754         * ui-file.c: Update include path.
6755         * ser-tcp.c: Update include path.
6756         * guile/scm-ports.c: Update include path.
6757         * posix-hdep.c: Update include path.
6758         * ser-unix.c: Update include path.
6759         * gdb_usleep.c: Update include path.
6760         * mingw-hdep.c: Update include path.
6761         * inflow.c: Update include path.
6762         * infrun.c: Update include path.
6763         * event-top.c: Update include path.
6764
6765 2020-04-13  Tom Tromey  <tom@tromey.com>
6766
6767         * configure: Rebuild.
6768         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
6769
6770 2020-04-13  Tom Tromey  <tom@tromey.com>
6771
6772         * event-loop.h (start_event_loop): Don't declare.
6773         * event-loop.c (start_event_loop): Move...
6774         * main.c (start_event_loop): ...here.  Now static.
6775
6776 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
6777
6778         * MAINTAINERS: Update my email address.
6779
6780 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6781
6782         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
6783         IP_ALL.
6784
6785 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6786
6787         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
6788         (nbsd_nat_target::info_proc): Add do_cmdline.
6789
6790 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6791
6792         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
6793         (nbsd_nat_target::info_proc): Add do_cwd.
6794
6795 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
6796
6797         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
6798
6799 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
6800
6801         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
6802         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
6803         (nbsd_nat_target::info_proc): New functions.
6804         * nbsd-nat.c (kinfo_get_vmmap): New function.
6805         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
6806         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
6807         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
6808         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
6809         functions.
6810         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
6811         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6812         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6813         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
6814         (KINFO_VME_FLAG_GROWS_DOWN): New.
6815
6816 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
6817
6818         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
6819         bit shift.
6820
6821 2020-04-10  Tom Tromey  <tromey@adacore.com>
6822
6823         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
6824
6825 2020-04-10  Tom Tromey  <tromey@adacore.com>
6826
6827         * symtab.c (get_symbol_address, get_msymbol_address): Skip
6828         separate debug files.
6829
6830 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
6831
6832         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6833         Move to...
6834         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
6835         ... here.
6836         * windows-nat.c (windows_nat_target::get_windows_debug_event):
6837         Check for STATUS_WX86_BREAKPOINT.
6838         (windows_nat_target::wait): Same.
6839
6840 2020-04-10  Tom de Vries  <tdevries@suse.de>
6841
6842         PR cli/25808
6843         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
6844
6845 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
6846
6847         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
6848         (Write After Approval): Remove Tom de Vries.
6849
6850 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6851
6852         revert partially:
6853         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6854
6855         * buildsym.c (record_line): Fix undefined behavior and preserve
6856         lines at eof.
6857
6858 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
6859
6860         * auxv.h (svr4_auxv_parse): New.
6861         * auxv.c (default_auxv_parse): Split into default_auxv_parse
6862         and generic_auxv_parse.
6863         (svr4_auxv_parse): Add.
6864         * obsd-tdep.c: Include "auxv.h".
6865         (obsd_auxv_parse): Remove.
6866         (obsd_init_abi): Remove comment.
6867         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
6868         from `obsd_auxv_parse' to `svr4_auxv_parse'.
6869         * nbsd-tdep.c: Include "auxv.h".
6870         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
6871
6872 2020-04-08  Tom Tromey  <tromey@adacore.com>
6873
6874         * nat/windows-nat.h (last_wait_event): Don't declare.
6875         (wait_for_debug_event): Update comment.
6876         * nat/windows-nat.c (last_wait_event): Now static.
6877
6878 2020-04-08  Tom Tromey  <tromey@adacore.com>
6879
6880         * windows-nat.c (wait_for_debug_event): Move to
6881         nat/windows-nat.c.
6882         * nat/windows-nat.h (wait_for_debug_event): Declare.
6883         * nat/windows-nat.c (wait_for_debug_event): Move from
6884         windows-nat.c.  No longer static.
6885
6886 2020-04-08  Tom Tromey  <tromey@adacore.com>
6887
6888         * windows-nat.c (get_windows_debug_event): Use
6889         fetch_pending_stop.
6890         * nat/windows-nat.h (fetch_pending_stop): Declare.
6891         * nat/windows-nat.c (fetch_pending_stop): New function.
6892
6893 2020-04-08  Tom Tromey  <tromey@adacore.com>
6894
6895         * windows-nat.c (windows_continue): Use matching_pending_stop and
6896         continue_last_debug_event.
6897         * nat/windows-nat.h (matching_pending_stop)
6898         (continue_last_debug_event): Declare.
6899         * nat/windows-nat.c (DEBUG_EVENTS): New define.
6900         (matching_pending_stop, continue_last_debug_event): New
6901         functions.
6902
6903 2020-04-08  Tom Tromey  <tromey@adacore.com>
6904
6905         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
6906         (handle_exception_result): Move to nat/windows-nat.h.
6907         (DEBUG_EXCEPTION_SIMPLE): Remove.
6908         (windows_nat::handle_ms_vc_exception): New function.
6909         (handle_exception): Move to nat/windows-nat.c.
6910         (get_windows_debug_event): Update.
6911         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
6912         nat/windows-nat.c.
6913         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
6914         (handle_exception_result): Move from windows-nat.c.
6915         (handle_exception): Declare.
6916         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
6917         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
6918         windows-nat.c.
6919
6920 2020-04-08  Tom Tromey  <tromey@adacore.com>
6921
6922         * windows-nat.c (exception_count, event_count): Remove.
6923         (handle_exception, get_windows_debug_event)
6924         (do_initial_windows_stuff): Update.
6925
6926 2020-04-08  Tom Tromey  <tromey@adacore.com>
6927
6928         * windows-nat.c (windows_nat::handle_load_dll)
6929         (windows_nat::handle_unload_dll): Rename.  No longer static.
6930         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
6931         Declare.
6932
6933 2020-04-08  Tom Tromey  <tromey@adacore.com>
6934
6935         * complaints.h (stop_whining): Declare at top-level.
6936         (complaint): Don't declare stop_whining.
6937
6938 2020-04-08  Tom Tromey  <tromey@adacore.com>
6939
6940         * windows-nat.c (windows_nat::handle_output_debug_string):
6941         Rename.  No longer static.
6942         * nat/windows-nat.h (handle_output_debug_string): Declare.
6943
6944 2020-04-08  Tom Tromey  <tromey@adacore.com>
6945
6946         * windows-nat.c (current_process_handle, current_process_id)
6947         (main_thread_id, last_sig, current_event, last_wait_event)
6948         (current_windows_thread, desired_stop_thread_id, pending_stops)
6949         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
6950         (display_selectors, fake_create_process)
6951         (get_windows_debug_event): Update.
6952         * nat/windows-nat.h (current_process_handle, current_process_id)
6953         (main_thread_id, last_sig, current_event, last_wait_event)
6954         (current_windows_thread, desired_stop_thread_id, pending_stops)
6955         (struct pending_stop, siginfo_er): Move from windows-nat.c.
6956         * nat/windows-nat.c (current_process_handle, current_process_id)
6957         (main_thread_id, last_sig, current_event, last_wait_event)
6958         (current_windows_thread, desired_stop_thread_id, pending_stops)
6959         (siginfo_er): New globals.  Move from windows-nat.c.
6960
6961 2020-04-08  Tom Tromey  <tromey@adacore.com>
6962
6963         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
6964         (handle_load_dll): Update.
6965         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
6966
6967 2020-04-08  Tom Tromey  <tromey@adacore.com>
6968
6969         * windows-nat.c (enum thread_disposition_type): Move to
6970         nat/windows-nat.h.
6971         (windows_nat::thread_rec): Rename from thread_rec.  No longer
6972         static.
6973         (windows_add_thread, windows_nat_target::fetch_registers)
6974         (windows_nat_target::store_registers, handle_exception)
6975         (windows_nat_target::resume, get_windows_debug_event)
6976         (windows_nat_target::get_tib_address)
6977         (windows_nat_target::thread_name)
6978         (windows_nat_target::thread_alive): Update.
6979         * nat/windows-nat.h (enum thread_disposition_type): Move from
6980         windows-nat.c.
6981         (thread_rec): Declare.
6982
6983 2020-04-08  Tom Tromey  <tromey@adacore.com>
6984
6985         * windows-nat.c: Add "using namespace".
6986         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
6987         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
6988
6989 2020-04-08  Tom Tromey  <tromey@adacore.com>
6990
6991         * nat/windows-nat.h (struct windows_thread_info): Declare
6992         destructor.
6993         * nat/windows-nat.c (~windows_thread_info): New.
6994
6995 2020-04-08  Tom Tromey  <tromey@adacore.com>
6996
6997         PR gdb/22992
6998         * windows-nat.c (current_event): Update comment.
6999         (last_wait_event, desired_stop_thread_id): New globals.
7000         (struct pending_stop): New.
7001         (pending_stops): New global.
7002         (windows_nat_target) <stopped_by_sw_breakpoint>
7003         <supports_stopped_by_sw_breakpoint>: New methods.
7004         (windows_fetch_one_register): Add assertions.  Adjust PC.
7005         (windows_continue): Handle pending stops.  Suspend other threads
7006         when stepping.  Use last_wait_event
7007         (wait_for_debug_event): New function.
7008         (get_windows_debug_event): Use wait_for_debug_event.  Handle
7009         pending stops.  Queue spurious stops.
7010         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
7011         (windows_nat_target::kill): Use wait_for_debug_event.
7012         * nat/windows-nat.h (struct windows_thread_info)
7013         <stopped_at_software_breakpoint>: New field.
7014         * nat/windows-nat.c (windows_thread_info::resume): Clear
7015         stopped_at_software_breakpoint.
7016
7017 2020-04-08  Tom Tromey  <tromey@adacore.com>
7018
7019         * windows-nat.c (enum thread_disposition_type): New.
7020         (thread_rec): Replace "get_context" parameter with "disposition";
7021         change type.
7022         (windows_add_thread, windows_nat_target::fetch_registers)
7023         (windows_nat_target::store_registers, handle_exception)
7024         (windows_nat_target::resume, get_windows_debug_event)
7025         (windows_nat_target::get_tib_address)
7026         (windows_nat_target::thread_name)
7027         (windows_nat_target::thread_alive): Update.
7028
7029 2020-04-08  Tom Tromey  <tromey@adacore.com>
7030
7031         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
7032         (windows_continue): Use windows_continue::resume.
7033         * nat/windows-nat.h (struct windows_thread_info) <suspend,
7034         resume>: Declare new methods.
7035         * nat/windows-nat.c: New file.
7036         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
7037
7038 2020-04-08  Tom Tromey  <tromey@adacore.com>
7039
7040         * windows-nat.c (windows_add_thread, windows_delete_thread)
7041         (windows_nat_target::fetch_registers)
7042         (windows_nat_target::store_registers, fake_create_process)
7043         (windows_nat_target::resume, windows_nat_target::resume)
7044         (get_windows_debug_event, windows_nat_target::wait)
7045         (windows_nat_target::pid_to_str)
7046         (windows_nat_target::get_tib_address)
7047         (windows_nat_target::get_ada_task_ptid)
7048         (windows_nat_target::thread_name)
7049         (windows_nat_target::thread_alive): Use lwp, not tid.
7050
7051 2020-04-08  Tom Tromey  <tromey@adacore.com>
7052
7053         * windows-nat.c (handle_exception)
7054         (windows_nat_target::thread_name): Update.
7055         * nat/windows-nat.h (windows_thread_info): Remove destructor.
7056         <name>: Now unique_xmalloc_ptr.
7057
7058 2020-04-08  Tom Tromey  <tromey@adacore.com>
7059
7060         * windows-nat.c (thread_rec)
7061         (windows_nat_target::fetch_registers): Update.
7062         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
7063         Update comment.
7064         <debug_registers_changed, reload_context>: Now bool.
7065
7066 2020-04-08  Tom Tromey  <tromey@adacore.com>
7067
7068         * windows-nat.c (windows_add_thread): Use new.
7069         (windows_init_thread_list, windows_delete_thread): Use delete.
7070         (get_windows_debug_event): Update.
7071         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
7072         destructor, and initializers.
7073
7074 2020-04-08  Tom Tromey  <tromey@adacore.com>
7075
7076         * windows-nat.c (struct windows_thread_info): Remove.
7077         * nat/windows-nat.h: New file.
7078
7079 2020-04-08  Tom Tromey  <tromey@adacore.com>
7080
7081         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
7082         (thread_rec, windows_add_thread, windows_delete_thread)
7083         (windows_continue): Update.
7084
7085 2020-04-08  Tom Tromey  <tromey@adacore.com>
7086
7087         * windows-nat.c (struct windows_thread_info): Remove typedef.
7088         (thread_head): Remove.
7089         (thread_list): New global.
7090         (thread_rec, windows_add_thread, windows_init_thread_list)
7091         (windows_delete_thread, windows_continue): Update.
7092
7093 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
7094
7095         * windows-tdep.h (windows_init_abi): Add comment.
7096         (cygwin_init_abi): New declaration.
7097         * windows-tdep.c: Split signal enumeration in two, one for
7098         Windows and one for Cygwin.
7099         (windows_gdb_signal_to_target): Only deal with signal of the
7100         Windows OS ABI.
7101         (cygwin_gdb_signal_to_target): New function.
7102         (windows_init_abi): Rename to windows_init_abi_common, don't set
7103         gdb_signal_to_target gdbarch method.  Add new new function with
7104         this name.
7105         (cygwin_init_abi): New function.
7106         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
7107         comment.  Don't call windows_init_abi.
7108         (amd64_windows_init_abi): Add comment, call windows_init_abi.
7109         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
7110         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
7111         i386_windows_init_abi_common, don't call windows_init_abi.  Add
7112         a new function of this name.
7113         (i386_cygwin_init_abi): New function.
7114         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
7115         OS ABI Cygwin.
7116
7117 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
7118
7119         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
7120         parameter.c.
7121         (dwarf2_read_gdb_index): Update.
7122
7123 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
7124
7125         * nbsd-tdep.c: Include "objfiles.h".
7126         (nbsd_skip_solib_resolver): New.
7127         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
7128
7129 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
7130
7131         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
7132         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
7133         with DW_LLE_base_addressx are being emitted in DWARFv5.
7134         Add the newly added kind DW_LOC_OFFSET_PAIR also.
7135         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
7136         unsigned integer.
7137
7138 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
7139
7140         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
7141         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
7142         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
7143         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
7144         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
7145         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
7146         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
7147
7148
7149 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
7150
7151         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
7152         (read_loclist_index): New function definition.
7153         (lookup_loclist_base): New function definition.
7154         (read_loclist_header): New function definition.
7155         (dwarf2_cu): Add loclist_base and loclist_header field.
7156         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
7157         (read_full_die_1): Read the value of DW_AT_loclists_base.
7158         (read_attribute_reprocess): Handle DW_FORM_loclistx.
7159         (read_attribute_value): Handle DW_FORM_loclistx.
7160         (skip_one_die): Handle DW_FORM_loclistx.
7161         (loclist_header): New structure declaration.
7162         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
7163
7164 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
7165
7166         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
7167         constructor.  Remove `addr` parameter from other constructor and
7168         add `per_cu` parameter.
7169         * dwarf2/read.c (create_partial_symtab): Update.
7170
7171 2020-04-07  Tom de Vries  <tdevries@suse.de>
7172
7173         PR symtab/25796
7174         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
7175         (partial_die_info::fixup): Inherit has_const_value.
7176
7177 2020-04-07  Tom de Vries  <tdevries@suse.de>
7178
7179         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
7180         symbols without address.
7181
7182 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
7183
7184         * nbsd-nat.h (struct thread_info): Add forward declaration.
7185         (nbsd_nat_target::thread_alive): Add.
7186         (nbsd_nat_target::thread_name): Likewise.
7187         (nbsd_nat_target::update_thread_list): Likewise.
7188         (update_thread_list::post_attach): Likewise.
7189         (post_attach::pid_to_str): Likewise.
7190         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
7191         (nbsd_thread_lister): Add.
7192         (nbsd_nat_target::thread_alive): Likewise.
7193         (nbsd_nat_target::thread_name): Likewise.
7194         (nbsd_add_threads): Likewise.
7195         (update_thread_list::post_attach): Likewise.
7196         (nbsd_nat_target::update_thread_list): Likewise.
7197         (post_attach::pid_to_str): Likewise.
7198
7199 2020-04-06  Tom Tromey  <tromey@adacore.com>
7200
7201         * ada-valprint.c (print_variant_part): Extract the variant field.
7202         (print_field_values): Use the field as the outer value when
7203         recursing.
7204
7205 2020-04-06  Tom Tromey  <tromey@adacore.com>
7206
7207         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
7208         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
7209         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
7210         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
7211         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
7212
7213 2020-04-06  Tom Tromey  <tromey@adacore.com>
7214
7215         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
7216         TYPE_CODE_ERROR.
7217
7218 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
7219
7220         * nbsd-tdep.c: Include "gdbarch.h".
7221         Define enum with NetBSD signal numbers.
7222         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
7223         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
7224         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
7225         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
7226         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
7227         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
7228         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
7229         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
7230         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
7231         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
7232         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
7233         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
7234
7235 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
7236
7237         PR gdb/25325
7238         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
7239
7240 2020-04-03  Tom Tromey  <tromey@adacore.com>
7241
7242         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
7243         Read constant block.
7244
7245 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
7246
7247         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
7248         (gdb_bfd_get_full_section_contents): New declaration.
7249         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
7250         * windows-tdep.c (is_linked_with_cygwin_dll): Use
7251         gdb_bfd_get_full_section_contents.
7252
7253 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
7254
7255         * exec.c (build_section_table): Replace internal_error with
7256         gdb_assert.
7257         (section_table_xfer_memory_partial): Likewise.
7258         * mdebugread.c (parse_partial_symbols): Likewise.
7259         * psymtab.c (lookup_partial_symbol): Likewise.
7260         * utils.c (wrap_here): Likewise.
7261
7262 2020-04-02  Tom Tromey  <tromey@adacore.com>
7263
7264         * f-lang.c (build_fortran_types): Use arch_type to initialize
7265         builtin_complex_s32 in the TYPE_CODE_ERROR case.
7266
7267 2020-04-02  Tom Tromey  <tromey@adacore.com>
7268
7269         * dwarf2/read.c (partial_die_info::read): Do not create a vector
7270         of attributes.
7271
7272 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7273             Bernd Edlinger <bernd.edlinger@hotmail.de>
7274             Tom Tromey  <tromey@adacore.com>
7275
7276         * buildsym.c (buildsym_compunit::record_line): Remove
7277         deduplication code.
7278
7279 2020-04-02  Tom de Vries  <tdevries@suse.de>
7280
7281         PR ada/24671
7282         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
7283
7284 2020-04-02  Tom de Vries  <tdevries@suse.de>
7285
7286         * dwarf2/read.c (dwarf2_gdb_index_functions,
7287         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
7288         NULL.
7289         * psymtab.c (psym_lookup_global_symbol_language): New function.
7290         (psym_functions): Init psym_lookup_global_symbol_language with
7291         psym_lookup_global_symbol_language.
7292         * symfile-debug.c (debug_sym_quick_functions): Init
7293         lookup_global_symbol_language with NULL.
7294         * symfile.c (set_initial_language): Remove fixme comment.
7295         * symfile.h (struct quick_symbol_functions): Add
7296         lookup_global_symbol_language.
7297         * symtab.c (find_quick_global_symbol_language): New function.
7298         (find_main_name): Use find_quick_global_symbol_language.
7299
7300 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
7301
7302         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
7303
7304 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7305
7306         * buildsym.c (record_line): Fix undefined behavior and preserve
7307         lines at eof.
7308
7309 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7310
7311         * buildsym.c (record_line): Fix the resizing condition.
7312
7313 2020-04-01  Tom Tromey  <tom@tromey.com>
7314
7315         * value.h (value_literal_complex): Add comment.
7316         * valops.c (value_literal_complex): Refer to value.h.
7317
7318 2020-04-01  Tom Tromey  <tom@tromey.com>
7319
7320         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
7321         (scalar_type): New rule, from typebase.
7322         (typebase): Use scalar_type.  Recognize complex types.
7323         (field_name): Handle FLOAT_KEYWORD.
7324         (ident_tokens): Add _Complex and __complex__.
7325
7326 2020-04-01  Tom Tromey  <tom@tromey.com>
7327
7328         PR exp/25299:
7329         * valarith.c (promotion_type, complex_binop): New functions.
7330         (scalar_binop): Handle complex numbers.  Use promotion_type.
7331         (value_pos, value_neg, value_complement): Handle complex numbers.
7332
7333 2020-04-01  Tom Tromey  <tom@tromey.com>
7334
7335         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
7336         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
7337         (parse_number): Handle complex numbers.
7338
7339 2020-04-01  Tom Tromey  <tom@tromey.com>
7340
7341         * c-valprint.c (c_decorations): Change complex suffix to "i".
7342
7343 2020-04-01  Tom Tromey  <tom@tromey.com>
7344
7345         * valprint.c (generic_value_print_complex): Use accessors.
7346         * value.h (value_real_part, value_imaginary_part): Declare.
7347         * valops.c (value_real_part, value_imaginary_part): New
7348         functions.
7349         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
7350
7351 2020-04-01  Tom Tromey  <tom@tromey.com>
7352
7353         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
7354         (read_range_type): Update.
7355         * mdebugread.c (basic_type): Update.
7356         * go-lang.c (build_go_types): Use init_complex_type.
7357         * gdbtypes.h (struct main_type) <complex_type>: New member.
7358         (init_complex_type): Update.
7359         (arch_complex_type): Don't declare.
7360         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
7361         Make name if none given.  Use alloc_type_copy.  Look for cached
7362         complex type.
7363         (arch_complex_type): Remove.
7364         (gdbtypes_post_init): Use init_complex_type.
7365         * f-lang.c (build_fortran_types): Use init_complex_type.
7366         * dwarf2/read.c (read_base_type): Update.
7367         * d-lang.c (build_d_types): Use init_complex_type.
7368         * ctfread.c (read_base_type): Update.
7369
7370 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7371
7372         * infrun.c (stop_all_threads): Update assertion, plus when
7373         stopping threads, take into account that we might be trying
7374         to stop an all-stop target.
7375         (stop_waiting): Call 'stop_all_threads' if there exists a
7376         non-stop target.
7377
7378 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7379
7380         * target.h (exists_non_stop_target): New function declaration.
7381         * target.c (exists_non_stop_target): New function.
7382
7383 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
7384
7385         PR gdb/24789
7386         * eval.c (is_integral_or_integral_reference): New function.
7387         (evaluate_subexp_standard): Allow integer references in
7388         pointer arithmetic.
7389
7390 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7391
7392         * remote.c (remote_target::remote_parse_stop_reply): Remove the
7393         check for no ptid in the stop reply when the target is non-stop.
7394
7395 2020-04-01  Tom Tromey  <tromey@adacore.com>
7396
7397         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
7398         "name" parameter to rvalue reference.  Initialize m_name_holder.
7399         <lookup_name_info>: New overloads.
7400         <name>: Return gdb::string_view.
7401         <c_str>: New method.
7402         <make_ignore_params>: Update.
7403         <search_name_hash>: Update.
7404         <language_lookup_name>: Return const char *.
7405         <m_name>: Change type.
7406         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
7407         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
7408         (lookup_name_info::match_any): Update.
7409         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
7410         Update.
7411         * minsyms.c (linkage_name_str): Update.
7412         * language.c (default_symbol_name_matcher): Update.
7413         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
7414         Update.
7415         * ada-lang.c (ada_fold_name): Change parameter to string_view.
7416         (ada_lookup_name_info::ada_lookup_name_info): Update.
7417         (literal_symbol_name_matcher): Update.
7418
7419 2020-04-01  Tom Tromey  <tromey@adacore.com>
7420
7421         * psymtab.c (psymtab_search_name): Remove function.
7422         (psym_lookup_symbol): Create search name and lookup name here.
7423         (lookup_partial_symbol): Remove "name" parameter; add
7424         lookup_name.
7425         (psym_expand_symtabs_for_function): Update.
7426
7427 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
7428
7429         PR tui/25597:
7430         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
7431
7432 2020-03-31  Tom Tromey  <tromey@adacore.com>
7433
7434         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
7435         memcpy.
7436
7437 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
7438
7439         * features/riscv/32bit-csr.xml: Regenerated.
7440         * features/riscv/64bit-csr.xml: Regenerated.
7441
7442 2020-03-30  Tom Tromey  <tromey@adacore.com>
7443
7444         * ada-valprint.c (print_variant_part): Update.
7445         * ada-lang.h (ada_which_variant_applies): Update.
7446         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
7447         outer_valaddr parameters; replace with "outer" value parameter.
7448         (to_fixed_variant_branch_type): Update.
7449
7450 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7451
7452         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
7453         <list>.  Remove inclusion of observable.h.
7454         (PPC_DEBUG_CURRENT_VERSION): Move up define.
7455         (struct arch_lwp_info): New struct.
7456         (class ppc_linux_dreg_interface): New class.
7457         (struct ppc_linux_process_info): New struct.
7458         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
7459         <low_new_clone, low_forget_process, low_prepare_to_resume>
7460         <copy_thread_dreg_state, mark_thread_stale>
7461         <mark_debug_registers_changed, register_hw_breakpoint>
7462         <clear_hw_breakpoint, register_wp, clear_wp>
7463         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
7464         <num_memory_accesses, get_trigger_type>
7465         <create_watchpoint_request, hwdebug_point_cmp>
7466         <init_arch_lwp_info, get_arch_lwp_info>
7467         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
7468         methods.
7469         <struct ptid_hash>: New inner struct.
7470         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
7471         members.
7472         (saved_dabr_value, hwdebug_info, max_slots_number)
7473         (struct hw_break_tuple, struct thread_points, ppc_threads)
7474         (have_ptrace_hwdebug_interface)
7475         (hwdebug_find_thread_points_by_tid)
7476         (hwdebug_insert_point, hwdebug_remove_point): Remove.
7477         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
7478         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
7479         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
7480         use m_dreg_interface.
7481         (hwdebug_point_cmp): Change to...
7482         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
7483         reference arguments instead of pointers.
7484         (ppc_linux_nat_target::ranged_break_num_registers): Use
7485         m_dreg_interface.
7486         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
7487         m_dreg_interface.  Call register_hw_breakpoint.
7488         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
7489         m_dreg_interface.  Call clear_hw_breakpoint.
7490         (get_trigger_type): Change to...
7491         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
7492         comment.
7493         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
7494         use m_dreg_interface.  Call register_hw_breakpoint.
7495         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
7496         use m_dreg_interface.  Call clear_hw_breakpoint.
7497         (can_use_watchpoint_cond_accel): Change to...
7498         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
7499         method.  Update comment, use m_dreg_interface and
7500         m_process_info.
7501         (calculate_dvc): Change to...
7502         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
7503         m_dreg_interface.
7504         (num_memory_accesses): Change to...
7505         (ppc_linux_nat_target::num_memory_accesses): ...this method.
7506         (check_condition): Change to...
7507         (ppc_linux_nat_target::check_condition): ...this method.
7508         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
7509         comment, use m_dreg_interface.
7510         (create_watchpoint_request): Change to...
7511         (ppc_linux_nat_target::create_watchpoint_request): ...this
7512         method.  Use m_dreg_interface.
7513         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
7514         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
7515         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
7516         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
7517         (ppc_linux_nat_target::low_forget_process)
7518         (ppc_linux_nat_target::low_new_fork)
7519         (ppc_linux_nat_target::low_new_clone)
7520         (ppc_linux_nat_target::low_delete_thread)
7521         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
7522         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
7523         only call mark_thread_stale.
7524         (ppc_linux_thread_exit): Remove.
7525         (ppc_linux_nat_target::stopped_data_address): Change to...
7526         (ppc_linux_nat_target::low_stopped_data_address): This. Add
7527         comment, use m_dreg_interface and m_thread_hw_breakpoints.
7528         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
7529         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
7530         comment.  Call low_stopped_data_address.
7531         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
7532         m_dreg_interface.
7533         (ppc_linux_nat_target::masked_watch_num_registers): Use
7534         m_dreg_interface.
7535         (ppc_linux_nat_target::copy_thread_dreg_state)
7536         (ppc_linux_nat_target::mark_thread_stale)
7537         (ppc_linux_nat_target::mark_debug_registers_changed)
7538         (ppc_linux_nat_target::register_hw_breakpoint)
7539         (ppc_linux_nat_target::clear_hw_breakpoint)
7540         (ppc_linux_nat_target::register_wp)
7541         (ppc_linux_nat_target::clear_wp)
7542         (ppc_linux_nat_target::init_arch_lwp_info)
7543         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
7544         (_initialize_ppc_linux_nat): Remove observer callback.
7545
7546 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7547
7548         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
7549         (ppc_linux_nat_target::auxv_parse)
7550         (ppc_linux_nat_target::read_description)
7551         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
7552         Move up.
7553
7554 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7555
7556         * linux-nat.h (low_new_clone): New method.
7557         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
7558
7559 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7560
7561         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
7562         (dbx_expand_psymtab): ... this.
7563         (start_psymtab): Update.
7564         * mdebugread.c (psymtab_to_symtab_1): Rename to...
7565         (mdebug_expand_psymtab): ... this.
7566         (parse_partial_symbols): Update.
7567         (new_psymtab): Update.
7568         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
7569         (xcoff_expand_psymtab): ... this.
7570         (xcoff_start_psymtab): Update.
7571
7572 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7573
7574         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
7575         <expand_dependencies>: ... this.
7576         * psymtab.c (partial_symtab::read_dependencies): Rename to...
7577         (partial_symtab::expand_dependencies): ... this.
7578         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
7579         Update.
7580         (dwarf2_psymtab::expand_psymtab): Update.
7581         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7582         * mdebugread.c (psymtab_to_symtab_1): Update.
7583         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7584
7585 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
7586
7587         * psympriv.h (discard_psymtab): Remove.
7588         * dbxread.c (dbx_end_psymtab): Update.
7589         * xcoffread.c (xcoff_end_psymtab): Update.
7590
7591 2020-03-28  Tom Tromey  <tom@tromey.com>
7592
7593         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
7594         comment.
7595
7596 2020-03-28  Tom Tromey  <tom@tromey.com>
7597
7598         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
7599
7600 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
7601
7602         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7603
7604 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
7605
7606         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
7607
7608 2020-03-26  Tom Tromey  <tom@tromey.com>
7609
7610         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
7611         (mark_common_block_symbol_computed, read_tag_string_type)
7612         (attr_to_dynamic_prop, read_subrange_type): Update.
7613         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
7614         to be methods on struct attribute.
7615         (skip_one_die, process_imported_unit_die, read_namespace_alias)
7616         (read_call_site_scope, partial_die_info::read)
7617         (partial_die_info::read, lookup_die_type, follow_die_ref):
7618         Update.
7619         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
7620         from dwarf2_get_ref_die_offset.
7621         (attribute::constant_value): New method, from
7622         dwarf2_get_attr_constant_value.
7623         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
7624         Declare method.
7625         <constant_value>: New method.
7626
7627 2020-03-26  Tom Tromey  <tom@tromey.com>
7628
7629         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
7630         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
7631         (dwarf_type_encoding_name): Move to stringify.c.
7632         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
7633         * dwarf2/stringify.c: New file.
7634         * dwarf2/stringify.h: New file.
7635
7636 2020-03-26  Tom Tromey  <tom@tromey.com>
7637
7638         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
7639         Rewrite.
7640
7641 2020-03-26  Tom Tromey  <tom@tromey.com>
7642
7643         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
7644         methods.
7645         * dwarf2/read.c (lookup_addr_base): Move to die.h.
7646         (lookup_ranges_base): Likewise.
7647         (read_cutu_die_from_dwo, read_full_die_1): Update.
7648
7649 2020-03-26  Tom Tromey  <tom@tromey.com>
7650
7651         * dwarf2/read.c (read_import_statement, read_file_scope)
7652         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
7653         (read_lexical_block_scope, read_call_site_scope)
7654         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
7655         (handle_struct_member_die, process_structure_scope)
7656         (update_enumeration_type_from_children)
7657         (process_enumeration_scope, read_array_type, read_common_block)
7658         (read_namespace, read_module, read_subroutine_type): Update.
7659         (sibling_die): Remove.
7660
7661 2020-03-26  Tom Tromey  <tom@tromey.com>
7662
7663         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
7664         (build_type_psymtabs_reader, read_structure_type)
7665         (read_enumeration_type, read_full_die_1): Update.
7666         (dwarf2_attr_no_follow): Move to die.h.
7667         * dwarf2/die.h (struct die_info) <attr>: New method.
7668
7669 2020-03-26  Tom Tromey  <tom@tromey.com>
7670
7671         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
7672         <base_address>: Now an optional.
7673         (dwarf2_find_base_address, dwarf2_rnglists_process)
7674         (dwarf2_ranges_process, fill_in_loclist_baton)
7675         (dwarf2_symbol_mark_computed): Update.
7676
7677 2020-03-26  Tom Tromey  <tom@tromey.com>
7678
7679         * dwarf2/read.c (struct die_info): Move to die.h.
7680         * dwarf2/die.h: New file.
7681
7682 2020-03-26  Tom Tromey  <tom@tromey.com>
7683
7684         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
7685         * dwarf2/read.c
7686         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7687         Move to line-header.c.
7688         (read_checked_initial_length_and_offset, read_formatted_entries):
7689         Likewise.
7690         (dwarf_decode_line_header): Split into two.
7691         * dwarf2/line-header.c
7692         (dwarf2_statement_list_fits_in_line_number_section_complaint):
7693         Move from read.c.
7694         (read_checked_initial_length_and_offset, read_formatted_entries):
7695         Likewise.
7696         (dwarf_decode_line_header): New function, split from read.c.
7697
7698 2020-03-26  Tom Tromey  <tom@tromey.com>
7699
7700         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
7701         Declare method.
7702         * dwarf2/read.c (read_attribute_value): Update.
7703         (dwarf2_per_objfile::read_line_string): Rename from
7704         read_indirect_line_string.
7705         (read_formatted_entries): Update.
7706
7707 2020-03-26  Tom Tromey  <tom@tromey.com>
7708
7709         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
7710         variable.
7711
7712 2020-03-26  Tom Tromey  <tom@tromey.com>
7713
7714         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
7715         const.
7716         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
7717         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
7718         parameter const.
7719
7720 2020-03-26  Tom Tromey  <tom@tromey.com>
7721
7722         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
7723         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
7724         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
7725         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
7726
7727 2020-03-26  Tom Tromey  <tom@tromey.com>
7728
7729         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
7730         file_names_size, file_full_name, file_file_name>: Use const.
7731         <file_name_at, file_names>: Add const overload.
7732         * dwarf2/line-header.c (line_header::file_file_name)
7733         (line_header::file_full_name): Update.
7734
7735 2020-03-26  Tom Tromey  <tom@tromey.com>
7736
7737         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
7738         (macro_start_file, consume_improper_spaces)
7739         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
7740         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
7741         (dwarf_decode_macros): Move to macro.c.
7742         * dwarf2/macro.c: New file.
7743         * dwarf2/macro.h: New file.
7744         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
7745
7746 2020-03-26  Tom Tromey  <tom@tromey.com>
7747
7748         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
7749         method.
7750         * dwarf2/section.c: New method.  From
7751         read_indirect_string_at_offset_from.
7752         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
7753         (read_indirect_string_at_offset_from): Move to section.c.
7754         (read_indirect_string_at_offset): Rewrite.
7755         (read_indirect_line_string_at_offset): Remove.
7756         (read_indirect_string, read_indirect_line_string)
7757         (dwarf_decode_macro_bytes): Update.
7758
7759 2020-03-26  Tom Tromey  <tom@tromey.com>
7760
7761         * dwarf2/section.h (struct dwarf2_section_info)
7762         <overload_complaint>: Declare.
7763         (dwarf2_section_buffer_overflow_complaint): Don't declare.
7764         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
7765         Rename from dwarf2_section_buffer_overflow_complaint.
7766         * dwarf2/read.c (skip_one_die, partial_die_info::read)
7767         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
7768
7769 2020-03-26  Tom Tromey  <tom@tromey.com>
7770
7771         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
7772         Declare.
7773         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
7774         Move from read.c.
7775         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
7776         to section.c.
7777
7778 2020-03-26  Tom Tromey  <tom@tromey.com>
7779
7780         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
7781
7782 2020-03-26  Tom Tromey  <tom@tromey.com>
7783
7784         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
7785         "builder".
7786         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
7787         parameter.
7788         (dwarf_decode_macros): Update.
7789
7790 2020-03-26  Tom Tromey  <tom@tromey.com>
7791
7792         * dwarf2/read.c (read_attribute_value): Update.
7793         (read_indirect_string_from_dwz): Move to dwz.c; change into
7794         method.
7795         (dwarf_decode_macro_bytes): Update.
7796         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
7797         * dwarf2/dwz.c: New file.
7798         * Makefile.in (COMMON_SFILES): Add dwz.c.
7799
7800 2020-03-26  Tom Tromey  <tom@tromey.com>
7801
7802         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
7803         * dwarf2/read.c: Add include.
7804         * dwarf2/index-write.c: Add include.
7805         * dwarf2/index-cache.c: Add include.
7806         * dwarf2/dwz.h: New file.
7807
7808 2020-03-25  Tom Tromey  <tom@tromey.com>
7809
7810         * compile/compile-object-load.c (get_out_value_type): Mention
7811         correct symbol name in error message.
7812
7813 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
7814
7815         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
7816
7817 2020-03-25  Tom de Vries  <tdevries@suse.de>
7818
7819         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
7820         * symmisc.c (dump_symtab_1): Print user and includes fields.
7821         (maintenance_info_symtabs): Same.
7822
7823 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         PR gdb/25534
7826         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
7827         (riscv_regcache_cooked_write): New function.
7828         (riscv_push_dummy_call): Use new function.
7829         (riscv_return_value): Likewise.
7830
7831 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
7832
7833         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
7834         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
7835         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
7836         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
7837         * infrun.c (follow_fork): Likewise.
7838         (follow_fork_inferior): Likewise.
7839         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
7840         * linux-nat.h (class linux_nat_target): Likewise.
7841         * remote.c (class remote_target) <follow_fork>: Likewise.
7842         (remote_target::follow_fork): Likewise.
7843         * target-delegates.c: Re-generate.
7844         * target.c (default_follow_fork): Likewise.
7845         (target_follow_fork): Likewise.
7846         * target.h (struct target_ops) <follow_fork>: Likewise.
7847         (target_follow_fork): Likewise.
7848
7849 2020-03-24  Tom de Vries  <tdevries@suse.de>
7850
7851         * psymtab.c (maintenance_info_psymtabs): Print user field.
7852
7853 2020-03-20  Tom Tromey  <tromey@adacore.com>
7854
7855         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
7856         const.
7857         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
7858         const.
7859
7860 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
7861
7862         * ptrace.m4: Don't check for ptrace declaration.
7863         * config.in: Re-generate.
7864         * configure: Re-generate.
7865         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
7866         not defined.
7867
7868 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7869
7870         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
7871         `PTRACE_TYPE_RET'.
7872         * i386-bsd-nat.c (gdb_ptrace): Likewise.
7873         * sparc-nat.c (gdb_ptrace): Likewise.
7874         * x86-bsd-nat.c (gdb_ptrace): Likewise.
7875
7876 2020-03-20  Tom Tromey  <tromey@adacore.com>
7877
7878         * c-exp.y (lex_one_token): Fix assert.
7879
7880 2020-03-20  Tom Tromey  <tromey@adacore.com>
7881
7882         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
7883         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
7884         strncpy call.
7885
7886 2020-03-20  Tom Tromey  <tromey@adacore.com>
7887
7888         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
7889
7890 2020-03-20  Tom Tromey  <tromey@adacore.com>
7891
7892         * ada-valprint.c (print_variant_part): Remove parameters; switch
7893         to value-based API.
7894         (print_field_values): Likewise.
7895         (ada_val_print_struct_union): Likewise.
7896         (ada_value_print_1): Update.
7897
7898 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7899
7900         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
7901         nbsd_nat_target instead of inf_ptrace_target.
7902         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
7903         nbsd_nat_target.
7904
7905 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7906
7907         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
7908         it to the ptrace call.
7909         * (store_registers): Likewise.
7910
7911 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
7912
7913         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
7914         it to the ptrace call.
7915         * (store_registers): Likewise.
7916
7917 2020-03-19  Luis Machado  <luis.machado@linaro.org>
7918
7919         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
7920         valid, fetch vg value from ptrace.
7921
7922 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7923         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
7924         * inf-ptrace.c: Likewise.
7925         * (gdb_ptrace): Add.
7926         * (inf_ptrace_target::resume): Update.
7927         * (inf_ptrace_target::xfer_partial): Likewise.
7928         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
7929         * (inf_ptrace_peek_poke): Update.
7930
7931 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
7932
7933         * x86-bsd-nat.c (gdb_ptrace): New.
7934         * (x86bsd_dr_set): Add new argument `ptid'.
7935         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
7936         x86bsd_dr_set_addr): Update.
7937
7938 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7939
7940         * remote.c (remote_target::process_stop_reply): Handle events for
7941         all threads differently.
7942
7943 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7944
7945         * completer.c (completion_tracker::remove_completion): Define new
7946         function.
7947         * completer.h (completion_tracker::remove_completion): Declare new
7948         function.
7949         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
7950         when adding a C++ function symbol.
7951
7952 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * completer.c (completion_tracker::completion_hash_entry): Define
7955         new class.
7956         (advance_to_filename_complete_word_point): Call
7957         recompute_lowest_common_denominator.
7958         (completion_tracker::completion_tracker): Call discard_completions
7959         to setup the hash table.
7960         (completion_tracker::discard_completions): Allow for being called
7961         from the constructor, pass new equal function, and element deleter
7962         when constructing the hash table.  Initialise new class member
7963         variables.
7964         (completion_tracker::maybe_add_completion): Remove use of
7965         m_entries_vec, and store more information into m_entries_hash.
7966         (completion_tracker::recompute_lcd_visitor): New function, most
7967         content taken from...
7968         (completion_tracker::recompute_lowest_common_denominator):
7969         ...here, this now just visits each item in the hash calling the
7970         above visitor.
7971         (completion_tracker::build_completion_result): Remove use of
7972         m_entries_vec, call recompute_lowest_common_denominator.
7973         * completer.h (completion_tracker::have_completions): Remove use
7974         of m_entries_vec.
7975         (completion_tracker::completion_hash_entry): Declare new class.
7976         (completion_tracker::recompute_lowest_common_denominator): Change
7977         function signature.
7978         (completion_tracker::recompute_lcd_visitor): Declare new function.
7979         (completion_tracker::m_entries_vec): Delete.
7980         (completion_tracker::m_entries_hash): Initialize to NULL.
7981         (completion_tracker::m_lowest_common_denominator_valid): New
7982         member variable.
7983         (completion_tracker::m_lowest_common_denominator_max_length): New
7984         member variable.
7985
7986 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7987
7988         * regformats/regdef.h: Put reg in gdb namespace.
7989
7990 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7991
7992         * i386-bsd-nat.c (gdb_ptrace): New.
7993         * (i386bsd_fetch_inferior_registers,
7994         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
7995         * (i386bsd_fetch_inferior_registers,
7996         i386bsd_store_inferior_registers) Use gdb_ptrace.
7997
7998 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
7999
8000         * amd64-bsd-nat.c (gdb_ptrace): New.
8001         * (amd64bsd_fetch_inferior_registers,
8002         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
8003         * (amd64bsd_fetch_inferior_registers,
8004         amd64bsd_store_inferior_registers) Use gdb_ptrace.
8005
8006 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8007
8008         * user-regs.c (user_reg::read): Rename to...
8009         (user_reg::xread): ...this.
8010         * (append_user_reg): Rename argument `read' to `xread'.
8011         * (user_reg_add_builtin): Likewise.
8012         * (user_reg_add): Likewise.
8013         * (value_of_user_reg): Likewise.
8014
8015 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8016
8017         * sparc-nat.c (gdb_ptrace): New.
8018         * sparc-nat.c (sparc_fetch_inferior_registers)
8019         (sparc_store_inferior_registers) Remove obsolete comment.
8020         * sparc-nat.c (sparc_fetch_inferior_registers)
8021         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
8022         * sparc-nat.c (sparc_fetch_inferior_registers)
8023         (sparc_store_inferior_registers) Use gdb_ptrace.
8024
8025 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8026
8027         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
8028         it to the ptrace call.
8029         * sh-nbsd-nat.c (store_registers): Likewise.
8030
8031 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8032
8033         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
8034         nbsd_nat_target instead of inf_ptrace_target.
8035         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
8036         nbsd_nat_target.
8037
8038 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8039
8040         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
8041
8042 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
8043
8044         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
8045         <sys/sysctl.h>.
8046         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
8047
8048 2020-03-17  Tom de Vries  <tdevries@suse.de>
8049
8050         PR gdb/23710
8051         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
8052         fields.
8053         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
8054         fields.
8055         (process_imported_unit_die): Skip import of c++ CUs.
8056
8057 2020-03-16  Tom Tromey  <tom@tromey.com>
8058
8059         * p-valprint.c (pascal_object_print_value): Initialize
8060         base_value.
8061
8062 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
8063             Shahab Vahedi  <shahab@synopsys.com>
8064
8065         * Makefile.in: Add arch/arc.o
8066         * configure.tgt: Likewise.
8067         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
8068         (_initialize_arc_tdep): Don't initialize old target descriptions.
8069         (arc_read_description): New function to cache target descriptions.
8070         * arc-tdep.h (arc_read_description): Add proto type.
8071         * arch/arc.c: New file.
8072         * arch/arc.h: Likewise.
8073         * features/Makefile: Replace old target descriptions with new.
8074         * features/arc-arcompact.c: Remove.
8075         * features/arc-arcompact.xml: Likewise.
8076         * features/arc-v2.c: Likewise
8077         * features/arc-v2.xml: Likewise
8078         * features/arc/aux-arcompact.xml: New file.
8079         * features/arc/aux-v2.xml: Likewise.
8080         * features/arc/core-arcompact.xml: Likewise.
8081         * features/arc/core-v2.xml: Likewise.
8082         * features/arc/aux-arcompact.c: Generate.
8083         * features/arc/aux-v2.c: Likewise.
8084         * features/arc/core-arcompact.c: Likewise.
8085         * features/arc/core-v2.c: Likewise.
8086         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
8087
8088 2020-03-16  Tom Tromey  <tromey@adacore.com>
8089
8090         PR gdb/25663:
8091         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
8092         putting value into bcache.
8093
8094 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8095
8096         PR gdb/21500
8097         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
8098         to...
8099         (amd64_windows_init_abi_common): ... this.  Don't set size of
8100         long type.
8101         (amd64_windows_init_abi): New function.
8102         (amd64_cygwin_init_abi): New function.
8103         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
8104         the Cygwin OS ABI.
8105         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
8106         comment.
8107
8108 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8109
8110         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
8111         * windows-tdep.c (CYGWIN_DLL_NAME): New.
8112         (pe_import_directory_entry): New struct type.
8113         (is_linked_with_cygwin_dll): New function.
8114         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
8115         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
8116         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
8117
8118 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8119
8120         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
8121         i386_cygwin_core_osabi_sniffer.
8122
8123 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8124
8125         * i386-cygwin-tdep.c: Rename to...
8126         * i386-windows-tdep.c: ... this.
8127         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
8128         i386-windows-tdep.c.
8129         * configure.tgt: Likewise.
8130
8131 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8132
8133         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
8134         * osabi.c (gdb_osabi_names): Add "Windows".
8135         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
8136         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
8137         (i386_cygwin_core_osabi_sniffer): New function, extracted from
8138         i386_cygwin_osabi_sniffer.
8139         (_initialize_i386_cygwin_tdep): Register OS ABI
8140         GDB_OSABI_WINDOWS for i386.
8141         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
8142         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
8143         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
8144         for x86-64.
8145         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
8146         when the target matches '*-*-mingw*'.
8147
8148 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8149
8150         * defs.h (enum gdb_osabi): Move to...
8151         * osabi.h (enum gdb_osabi): ... here.
8152         * gdbarch.sh: Include osabi.h in gdbarch.h.
8153         * gdbarch.h: Re-generate.
8154
8155 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
8156
8157         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
8158         function.
8159         (_initialize_amd64_windows_tdep): Register osabi sniffer.
8160
8161 2020-03-14  Tom Tromey  <tom@tromey.com>
8162
8163         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
8164         for C++.
8165         (c_type_print_modifier): Likewise.  Add "language" parameter.
8166         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
8167         (c_type_print_base_1): Update.
8168         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
8169         constants.
8170         * type-stack.c (type_stack::insert): Handle tp_atomic and
8171         tp_restrict.
8172         (type_stack::follow_type_instance_flags): Likewise.
8173         (type_stack::follow_types): Likewise.  Merge type-following code.
8174         * c-exp.y (RESTRICT, ATOMIC): New tokens.
8175         (space_identifier, cv_with_space_id)
8176         (const_or_volatile_or_space_identifier_noopt)
8177         (const_or_volatile_or_space_identifier): Remove.
8178         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
8179         rules.
8180         (ptr_operator, typebase): Update.
8181         (enum token_flag) <FLAG_C>: New constant.
8182         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
8183         "_Atomic".
8184         (lex_one_token): Handle FLAG_C.
8185
8186 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8187
8188         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
8189         it to the ptrace call.
8190         * m68k-bsd-nat.c (store_registers): Likewise.
8191
8192 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8193
8194         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
8195         gdb_byte *.
8196         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
8197         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
8198         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
8199
8200 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8201
8202         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
8203         nbsd_nat_target instead of inf_ptrace_target.
8204         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
8205         nbsd_nat_target.
8206
8207 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8208
8209         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
8210         register_t.
8211
8212 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8213
8214         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
8215         it to the ptrace call.
8216         * alpha-bsd-nat.c (store_registers): Likewise.
8217
8218 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8219
8220         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
8221         includes.
8222         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
8223         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
8224         fill_fpregset): Likewise.
8225
8226 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8227
8228         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
8229         nbsd_nat_target instead of inf_ptrace_target.
8230         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
8231         nbsd_nat_target.
8232
8233 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8234
8235         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
8236         register_t.
8237
8238 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8239
8240         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
8241         it to the ptrace call.
8242         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
8243         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
8244         * arm-nbsd-nat.c (store_register): Likewise.
8245         * arm-nbsd-nat.c (store_regs): Likewise.
8246         * arm-nbsd-nat.c (store_fp_register): Likewise.
8247         * arm-nbsd-nat.c (store_fp_regs): Likewise.
8248
8249 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8250
8251         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
8252         nbsd_nat_target instead of inf_ptrace_target.
8253         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
8254         nbsd_nat_target.
8255
8256 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8257
8258         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
8259         it to the ptrace call.
8260         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
8261
8262 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8263
8264         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
8265         it to the ptrace call.
8266         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
8267
8268 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8269
8270         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
8271         gdb_byte *.
8272         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
8273
8274 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8275
8276         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
8277         instead of inf_ptrace_target.
8278         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
8279         nbsd_nat_target.
8280
8281 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8282
8283         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8284         register_t.
8285
8286 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8287
8288         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8289         register_t.
8290
8291 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
8292
8293         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
8294         register_t.
8295
8296 2020-03-13  Tom Tromey  <tom@tromey.com>
8297
8298         * value.h (val_print): Don't declare.
8299         * valprint.h (val_print_array_elements)
8300         (val_print_scalar_formatted, generic_val_print): Don't declare.
8301         * valprint.c (generic_val_print_array): Take a struct value.
8302         (generic_val_print_ptr, generic_val_print_memberptr)
8303         (generic_val_print_bool, generic_val_print_int)
8304         (generic_val_print_char, generic_val_print_complex)
8305         (generic_val_print): Remove.
8306         (generic_value_print): Update.
8307         (do_val_print): Remove unused parameters.  Don't call
8308         la_val_print.
8309         (val_print): Remove.
8310         (common_val_print): Update.  Don't call value_check_printable.
8311         (val_print_scalar_formatted, val_print_array_elements): Remove.
8312         * rust-lang.c (rust_val_print): Remove.
8313         (rust_language_defn): Update.
8314         * p-valprint.c (pascal_val_print): Remove.
8315         (pascal_value_print_inner): Update.
8316         (pascal_object_print_val_fields, pascal_object_print_val):
8317         Remove.
8318         (pascal_object_print_static_field): Update.
8319         * p-lang.h (pascal_val_print): Don't declare.
8320         * p-lang.c (pascal_language_defn): Update.
8321         * opencl-lang.c (opencl_language_defn): Update.
8322         * objc-lang.c (objc_language_defn): Update.
8323         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
8324         * m2-lang.h (m2_val_print): Don't declare.
8325         * m2-lang.c (m2_language_defn): Update.
8326         * language.h (struct language_defn) <la_val_print>: Remove.
8327         * language.c (unk_lang_value_print_inner): Rename.  Change
8328         argument types.
8329         (unknown_language_defn, auto_language_defn): Update.
8330         * go-valprint.c (go_val_print): Remove.
8331         * go-lang.h (go_val_print): Don't declare.
8332         * go-lang.c (go_language_defn): Update.
8333         * f-valprint.c (f_val_print): Remove.
8334         * f-lang.h (f_value_print): Don't declare.
8335         * f-lang.c (f_language_defn): Update.
8336         * d-valprint.c (d_val_print): Remove.
8337         * d-lang.h (d_value_print): Don't declare.
8338         * d-lang.c (d_language_defn): Update.
8339         * cp-valprint.c (cp_print_value_fields)
8340         (cp_print_value_fields_rtti, cp_print_value): Remove.
8341         (cp_print_static_field): Update.
8342         * c-valprint.c (c_val_print_array, c_val_print_ptr)
8343         (c_val_print_struct, c_val_print_union, c_val_print_int)
8344         (c_val_print_memberptr, c_val_print): Remove.
8345         * c-lang.h (c_val_print_array, cp_print_value_fields)
8346         (cp_print_value_fields_rtti): Don't declare.
8347         * c-lang.c (c_language_defn, cplus_language_defn)
8348         (asm_language_defn, minimal_language_defn): Update.
8349         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
8350         (ada_val_print_enum): Take a struct value.
8351         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
8352         (ada_val_print): Remove.
8353         (ada_value_print_1): Update.
8354         (printable_val_type): Remove.
8355         * ada-lang.h (ada_val_print): Don't declare.
8356         * ada-lang.c (ada_language_defn): Update.
8357
8358 2020-03-13  Tom Tromey  <tom@tromey.com>
8359
8360         * valprint.c (do_val_print): Update.
8361         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
8362         a struct value.
8363         (value_to_value_object_no_release): Declare.
8364         * python/py-value.c (value_to_value_object_no_release): New
8365         function.
8366         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
8367         struct value.
8368         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
8369         function.
8370         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
8371         a struct value.
8372         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
8373         Declare.
8374         (gdbscm_apply_val_pretty_printer): Take a struct value.
8375         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
8376         value.
8377         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
8378         value.
8379         * extension-priv.h (struct extension_language_ops)
8380         <apply_val_pretty_printer>: Take a struct value.
8381         * cp-valprint.c (cp_print_value): Create a struct value.
8382         (cp_print_value): Update.
8383
8384 2020-03-13  Tom Tromey  <tom@tromey.com>
8385
8386         * ada-valprint.c (print_field_values): Call common_val_print.
8387
8388 2020-03-13  Tom Tromey  <tom@tromey.com>
8389
8390         * ada-valprint.c (val_print_packed_array_elements): Remove
8391         bitoffset and val parameters.  Call common_val_print.
8392         (ada_val_print_string): Remove offset, address, and original_value
8393         parameters.
8394         (ada_val_print_array): Update.
8395         (ada_value_print_array): New function.
8396         (ada_value_print_1): Call it.
8397
8398 2020-03-13  Tom Tromey  <tom@tromey.com>
8399
8400         * ada-valprint.c (ada_value_print): Use common_val_print.
8401
8402 2020-03-13  Tom Tromey  <tom@tromey.com>
8403
8404         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
8405
8406 2020-03-13  Tom Tromey  <tom@tromey.com>
8407
8408         * ada-valprint.c (ada_value_print_num): New function.
8409         (ada_value_print_1): Use it.
8410
8411 2020-03-13  Tom Tromey  <tom@tromey.com>
8412
8413         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
8414
8415 2020-03-13  Tom Tromey  <tom@tromey.com>
8416
8417         * ada-valprint.c (ada_value_print_ptr): New function.
8418         (ada_value_print_1): Use it.
8419
8420 2020-03-13  Tom Tromey  <tom@tromey.com>
8421
8422         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
8423         call common_val_print.
8424         (ada_val_print_1): Update.
8425         (ada_value_print_1): New function.
8426         (ada_value_print_inner): Rewrite.
8427
8428 2020-03-13  Tom Tromey  <tom@tromey.com>
8429
8430         * cp-valprint.c (cp_print_value_fields): Update.
8431         (cp_print_value): New function.
8432
8433 2020-03-13  Tom Tromey  <tom@tromey.com>
8434
8435         * m2-valprint.c (m2_value_print_inner): Use
8436         cp_print_value_fields.
8437         * cp-valprint.c (cp_print_value_fields): New function.
8438         * c-valprint.c (c_value_print_struct): New function.
8439         (c_value_print_inner): Use c_value_print_struct.
8440         * c-lang.h (cp_print_value_fields): Declare.
8441
8442 2020-03-13  Tom Tromey  <tom@tromey.com>
8443
8444         * c-valprint.c (c_value_print_array): New function.
8445         (c_value_print_inner): Use it.
8446
8447 2020-03-13  Tom Tromey  <tom@tromey.com>
8448
8449         * c-valprint.c (c_value_print_memberptr): New function.
8450         (c_value_print_inner): Use it.
8451
8452 2020-03-13  Tom Tromey  <tom@tromey.com>
8453
8454         * c-valprint.c (c_value_print_int): New function.
8455         (c_value_print_inner): Use it.
8456
8457 2020-03-13  Tom Tromey  <tom@tromey.com>
8458
8459         * c-valprint.c (c_value_print_ptr): New function.
8460         (c_value_print_inner): Use it.
8461
8462 2020-03-13  Tom Tromey  <tom@tromey.com>
8463
8464         * c-valprint.c (c_value_print_inner): Rewrite.
8465
8466 2020-03-13  Tom Tromey  <tom@tromey.com>
8467
8468         * valprint.c (generic_value_print_complex): New function.
8469         (generic_value_print): Use it.
8470
8471 2020-03-13  Tom Tromey  <tom@tromey.com>
8472
8473         * valprint.c (generic_val_print_float): Don't call
8474         val_print_scalar_formatted.
8475         (generic_val_print, generic_value_print): Update.
8476
8477 2020-03-13  Tom Tromey  <tom@tromey.com>
8478
8479         * valprint.c (generic_value_print_char): New function
8480         (generic_value_print): Use it.
8481
8482 2020-03-13  Tom Tromey  <tom@tromey.com>
8483
8484         * valprint.c (generic_value_print_int): New function.
8485         (generic_value_print): Use it.
8486
8487 2020-03-13  Tom Tromey  <tom@tromey.com>
8488
8489         * valprint.c (generic_value_print_bool): New function.
8490         (generic_value_print): Use it.
8491
8492 2020-03-13  Tom Tromey  <tom@tromey.com>
8493
8494         * valprint.c (generic_val_print_func): Simplify.
8495         (generic_val_print, generic_value_print): Update.
8496
8497 2020-03-13  Tom Tromey  <tom@tromey.com>
8498
8499         * valprint.c (generic_val_print_flags): Remove.
8500         (generic_val_print, generic_value_print): Update.
8501         (val_print_type_code_flags): Add original_value parameter.
8502
8503 2020-03-13  Tom Tromey  <tom@tromey.com>
8504
8505         * valprint.c (generic_val_print): Update.
8506         (generic_value_print): Update.
8507         * valprint.c (generic_val_print_enum): Don't call
8508         val_print_scalar_formatted.
8509
8510 2020-03-13  Tom Tromey  <tom@tromey.com>
8511
8512         * valprint.c (generic_value_print): Call generic_value_print_ptr.
8513         * valprint.c (generic_value_print_ptr): New function.
8514
8515 2020-03-13  Tom Tromey  <tom@tromey.com>
8516
8517         * valprint.c (generic_value_print): Rewrite.
8518
8519 2020-03-13  Tom Tromey  <tom@tromey.com>
8520
8521         * p-valprint.c (pascal_object_print_value_fields)
8522         (pascal_object_print_value): New functions.
8523
8524 2020-03-13  Tom Tromey  <tom@tromey.com>
8525
8526         * p-valprint.c (pascal_value_print_inner): Rewrite.
8527
8528 2020-03-13  Tom Tromey  <tom@tromey.com>
8529
8530         * f-valprint.c (f_value_print_innner): Rewrite.
8531
8532 2020-03-13  Tom Tromey  <tom@tromey.com>
8533
8534         * m2-valprint.c (m2_print_unbounded_array): New overload.
8535         (m2_print_unbounded_array): Update.
8536         (m2_print_array_contents): Take a struct value.
8537         (m2_value_print_inner): Rewrite.
8538
8539 2020-03-13  Tom Tromey  <tom@tromey.com>
8540
8541         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
8542         (d_value_print_inner): New function.
8543         * d-lang.h (d_value_print_inner): Declare.
8544         * d-lang.c (d_language_defn): Use d_value_print_inner.
8545
8546 2020-03-13  Tom Tromey  <tom@tromey.com>
8547
8548         * go-valprint.c (go_value_print_inner): New function.
8549         * go-lang.h (go_value_print_inner): Declare.
8550         * go-lang.c (go_language_defn): Use go_value_print_inner.
8551
8552 2020-03-13  Tom Tromey  <tom@tromey.com>
8553
8554         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
8555         API.
8556         (rust_val_print): Rewrite.
8557         (rust_value_print_inner): New function, from rust_val_print.
8558         (rust_language_defn): Use rust_value_print_inner.
8559
8560 2020-03-13  Tom Tromey  <tom@tromey.com>
8561
8562         * ada-valprint.c (ada_value_print_inner): New function.
8563         * ada-lang.h (ada_value_print_inner): Declare.
8564         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
8565
8566 2020-03-13  Tom Tromey  <tom@tromey.com>
8567
8568         * f-valprint.c (f_value_print_innner): New function.
8569         * f-lang.h (f_value_print_innner): Declare.
8570         * f-lang.c (f_language_defn): Use f_value_print_innner.
8571
8572 2020-03-13  Tom Tromey  <tom@tromey.com>
8573
8574         * p-valprint.c (pascal_value_print_inner): New function.
8575         * p-lang.h (pascal_value_print_inner): Declare.
8576         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
8577
8578 2020-03-13  Tom Tromey  <tom@tromey.com>
8579
8580         * m2-valprint.c (m2_value_print_inner): New function.
8581         * m2-lang.h (m2_value_print_inner): Declare.
8582         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
8583
8584 2020-03-13  Tom Tromey  <tom@tromey.com>
8585
8586         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
8587         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
8588         * c-valprint.c (c_value_print_inner): New function.
8589         * c-lang.h (c_value_print_inner): Declare.
8590         * c-lang.c (c_language_defn, cplus_language_defn)
8591         (asm_language_defn, minimal_language_defn): Use
8592         c_value_print_inner.
8593
8594 2020-03-13  Tom Tromey  <tom@tromey.com>
8595
8596         * p-valprint.c (pascal_object_print_value_fields): Now static.
8597         * p-lang.h (pascal_object_print_value_fields): Don't declare.
8598
8599 2020-03-13  Tom Tromey  <tom@tromey.com>
8600
8601         * c-valprint.c (c_val_print_array): Simplify.
8602
8603 2020-03-13  Tom Tromey  <tom@tromey.com>
8604
8605         * valprint.c (value_print_array_elements): New function.
8606         * valprint.h (value_print_array_elements): Declare.
8607
8608 2020-03-13  Tom Tromey  <tom@tromey.com>
8609
8610         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
8611         * mips-tdep.c (mips_print_register): Use
8612         value_print_scalar_formatted.
8613
8614 2020-03-13  Tom Tromey  <tom@tromey.com>
8615
8616         * valprint.h (value_print_scalar_formatted): Declare.
8617         * valprint.c (value_print_scalar_formatted): New function.
8618
8619 2020-03-13  Tom Tromey  <tom@tromey.com>
8620
8621         * valprint.h (generic_value_print): Declare.
8622         * valprint.c (generic_value_print): New function.
8623
8624 2020-03-13  Tom Tromey  <tom@tromey.com>
8625
8626         * valprint.c (do_val_print): Call la_value_print_inner, if
8627         available.
8628         * rust-lang.c (rust_language_defn): Update.
8629         * p-lang.c (pascal_language_defn): Update.
8630         * opencl-lang.c (opencl_language_defn): Update.
8631         * objc-lang.c (objc_language_defn): Update.
8632         * m2-lang.c (m2_language_defn): Update.
8633         * language.h (struct language_defn) <la_value_print_inner>: New
8634         member.
8635         * language.c (unknown_language_defn, auto_language_defn): Update.
8636         * go-lang.c (go_language_defn): Update.
8637         * f-lang.c (f_language_defn): Update.
8638         * d-lang.c (d_language_defn): Update.
8639         * c-lang.c (c_language_defn, cplus_language_defn)
8640         (asm_language_defn, minimal_language_defn): Update.
8641         * ada-lang.c (ada_language_defn): Update.
8642
8643 2020-03-13  Tom Tromey  <tom@tromey.com>
8644
8645         * c-valprint.c (c_value_print): Use common_val_print.
8646
8647 2020-03-13  Tom Tromey  <tom@tromey.com>
8648
8649         * cp-valprint.c (cp_print_static_field): Use common_val_print.
8650
8651 2020-03-13  Tom Tromey  <tom@tromey.com>
8652
8653         * f-valprint.c (f77_print_array_1, f_val_print): Use
8654         common_val_print.
8655
8656 2020-03-13  Tom Tromey  <tom@tromey.com>
8657
8658         * riscv-tdep.c (riscv_print_one_register_info): Use
8659         common_val_print.
8660
8661 2020-03-13  Tom Tromey  <tom@tromey.com>
8662
8663         * mi/mi-main.c (output_register): Use common_val_print.
8664
8665 2020-03-13  Tom Tromey  <tom@tromey.com>
8666
8667         * infcmd.c (default_print_one_register_info): Use
8668         common_val_print.
8669
8670 2020-03-13  Tom Tromey  <tom@tromey.com>
8671
8672         * valprint.h (common_val_print_checked): Declare.
8673         * valprint.c (common_val_print_checked): New function.
8674         * stack.c (print_frame_arg): Use common_val_print_checked.
8675
8676 2020-03-13  Tom Tromey  <tom@tromey.com>
8677
8678         * valprint.c (do_val_print): New function, from val_print.
8679         (val_print): Use do_val_print.
8680         (common_val_print): Use do_val_print.
8681
8682 2020-03-13  Tom Tromey  <tom@tromey.com>
8683
8684         * valprint.c (value_print): Use scoped_value_mark.
8685
8686 2020-03-13  Tom de Vries  <tdevries@suse.de>
8687
8688         PR symtab/25646
8689         * psymtab.c (partial_symtab::partial_symtab): Don't set
8690         globals_offset and statics_offset.  Push element onto
8691         current_global_psymbols and current_static_psymbols stacks.
8692         (concat): New function.
8693         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
8694         element from current_global_psymbols and current_static_psymbols
8695         stacks.  Concat popped elements to global_psymbols and
8696         static_symbols.
8697         (add_psymbol_to_list): Use current_global_psymbols and
8698         current_static_psymbols stacks.
8699         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
8700         current_static_psymbols fields.
8701
8702 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8703
8704         * corelow.c (sniff_core_bfd): Remove.
8705         (class core_target) <m_core_vec>: Remove.
8706         (core_target::core_target): Update.
8707         (core_file_fns): Remove.
8708         (deprecated_add_core_fns): Remove.
8709         (default_core_sniffer): Remove.
8710         (sniff_core_bfd): Remove.
8711         (default_check_format): Remove.
8712         (gdb_check_format): Remove.
8713         (core_target_open): Update.
8714         (core_target::get_core_register_section): Update.
8715         (get_core_registers_cb): Update.
8716         (core_target::fetch_registers): Update.
8717         * gdbcore.h (struct core_fns): Remove.
8718         (deprecated_add_core_fns): Remove.
8719         (default_core_sniffer): Remove.
8720         (default_check_format): Remove.
8721
8722 2020-03-12  Tom Tromey  <tom@tromey.com>
8723
8724         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
8725         CORE_ADDR.
8726         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
8727
8728 2020-03-12  Tom Tromey  <tom@tromey.com>
8729
8730         * remote.c (remote_target::download_tracepoint)
8731         (remote_target::enable_tracepoint)
8732         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
8733         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
8734         sprintf_vma.
8735
8736 2020-03-12  Tom Tromey  <tom@tromey.com>
8737
8738         * symfile-mem.c: Update CORE_ADDR size assert.
8739
8740 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8741
8742         * selftest.m4: Move to gdbsupport/.
8743         * acinclude.m4: Update path to selftest.m4.
8744
8745 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8746
8747         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
8748         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
8749         gdbarch-selfselftests.c and selftest-arch.c.
8750         (SUBDIR_UNITTESTS_OBS): Rename to...
8751         (SELFTESTS_OBS): ... this.
8752         (COMMON_SFILES): Remove disasm-selftests.c and
8753         gdbarch-selftests.c.
8754         * configure.ac: Don't add selftest-arch.{c,o} to
8755         CONFIG_{SRCS,OBS}.
8756         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
8757         preprocessor conditions.
8758
8759 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8760
8761         * configure.ac: Don't source bfd/development.sh.
8762         * selftest.m4: Modify comment.
8763         * configure: Re-generate.
8764
8765 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
8766
8767         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
8768         not "true" or "false".
8769         * configure: Re-generate.
8770
8771 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
8772
8773         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
8774         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
8775         renamed to arm_nbsd_supply_gregset.
8776         (fetch_register): Update to call arm_nbsd_supply_gregset.
8777         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
8778         (arm_netbsd_nat_target::fetch_registers): Update.
8779         (fetch_elfcore_registers): Removed.
8780         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
8781         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
8782         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
8783         not require NetBSD system headers.
8784         (arm_nbsd_regset): New struct.
8785         (arm_nbsd_iterate_over_regset_sections): New function.
8786         (arm_netbsd_init_abi_common): Updated to call
8787         set_gdbarch_iterate_over_regset_sections.
8788         * arm-nbsd-tdep.h: New file.
8789
8790 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
8791
8792         * symtab.c (find_pc_sect_line): Add check which prevents infinite
8793         recursion.
8794
8795 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
8796
8797         * configure: Re-generate.
8798
8799 2020-03-11  Tom Tromey  <tromey@adacore.com>
8800
8801         * ada-typeprint.c (print_choices): Fix comment.
8802
8803 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8804
8805         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
8806         previous item in the list, when the list has no items.
8807
8808 2020-03-11  Tom de Vries  <tdevries@suse.de>
8809
8810         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
8811         PROP_LOCLIST handling code.
8812
8813 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8814
8815         * buildsym-legacy.c (record_line): Pass extra parameter to
8816         record_line.
8817         * buildsym.c (buildsym_compunit::record_line): Take an extra
8818         parameter, reduce duplication in the line table, and record the
8819         is_stmt flag in the line table.
8820         * buildsym.h (buildsym_compunit::record_line): Add extra
8821         parameter.
8822         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
8823         non-statement lines.
8824         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
8825         this to the symtab builder.
8826         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
8827         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
8828         through to dwarf_record_line_1.
8829         * infrun.c (process_event_stop_test): When stepping, don't stop at
8830         a non-statement instruction, and only refresh the step info when
8831         we land in the middle of a line's range.  Also add an extra
8832         comment.
8833         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
8834         field.
8835         * record-btrace.c (btrace_find_line_range): Only record lines
8836         marked as is-statement.
8837         * stack.c (frame_show_address): Show the frame address if we are
8838         in a non-statement sal.
8839         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
8840         (maintenance_print_one_line_table): Print a header for the is_stmt
8841         column, and include is_stmt information in the output.
8842         * symtab.c (find_pc_sect_line): Find lines marked as statements in
8843         preference to non-statements.
8844         (find_pcs_for_symtab_line): Prefer is-statement entries.
8845         (find_line_common): Likewise.
8846         * symtab.h (struct linetable_entry): Add is_stmt field.
8847         (struct symtab_and_line): Likewise.
8848         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
8849         arranging the line table.
8850
8851 2020-03-07  Tom de Vries  <tdevries@suse.de>
8852
8853         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
8854         DIE.
8855
8856 2020-03-07  Tom Tromey  <tom@tromey.com>
8857
8858         * valops.c (value_literal_complex): Remove obsolete comment.
8859         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
8860         comment.
8861
8862 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
8863
8864         * infrun.h: Forward-declare thread_info.
8865         (set_step_info): Add thread_info parameter, add doc.
8866         * infrun.c (set_step_info): Add thread_info parameter, move doc
8867         to header.
8868         * infrun.c (process_event_stop_test): Pass thread to
8869         set_step_info call.
8870         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
8871         set_step_info.
8872         (prepare_one_step): Add thread_info parameter, pass it to
8873         set_step_frame and prepare_one_step (recursive) call.
8874         (step_1): Pass thread to prepare_one_step call.
8875         (step_command_fsm::should_stop): Pass thread to
8876         prepare_one_step.
8877         (until_next_fsm): Pass thread to set_step_frame call.
8878         (finish_command): Pass thread to set_step_info call.
8879
8880 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
8881
8882         * windows-tdep.c (windows_solib_create_inferior_hook):
8883         Check if inferior is running.
8884
8885 2020-03-06  Tom de Vries  <tdevries@suse.de>
8886
8887         * NEWS: Fix "the the".
8888         * ctfread.c: Same.
8889
8890 2020-03-06  Tom de Vries  <tdevries@suse.de>
8891
8892         * psymtab.c (psymtab_to_symtab): Don't print "done.".
8893
8894 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8895
8896         * .dir-locals.el: Add a comment referencing the other copies of
8897         this file.
8898
8899 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
8900
8901         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
8902         psargs.
8903
8904 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8905
8906         * .gitattributes: New file.
8907
8908 2020-03-04  Tom Tromey  <tom@tromey.com>
8909
8910         * symmisc.c (print_symbol_bcache_statistics)
8911         (print_objfile_statistics): Update.
8912         * symfile.c (allocate_symtab): Use intern.
8913         * psymtab.c (partial_symtab::partial_symtab): Use intern.
8914         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8915         macro_cache>: Remove.
8916         <string_cache>: New member.
8917         (struct objfile) <intern>: New methods.
8918         * elfread.c (elf_symtab_read): Use intern.
8919         * dwarf2/read.c (fixup_go_packaging): Intern package name.
8920         (dwarf2_compute_name, dwarf2_physname)
8921         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
8922         names.
8923         (guess_partial_die_structure_name): Update.
8924         (partial_die_info::fixup): Intern name.
8925         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
8926         name.
8927         (dwarf2_name): Intern name.  Update.
8928         * buildsym.c (buildsym_compunit::get_macro_table): Use
8929         string_cache.
8930
8931 2020-03-04  Tom Tromey  <tom@tromey.com>
8932
8933         * jit.c (bfd_open_from_target_memory): Make "target" const.
8934         * corefile.c (gnutarget): Now const.
8935         * gdbcore.h (gnutarget): Now const.
8936
8937 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
8938
8939         * NEWS: Mention support for WOW64 processes.
8940         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
8941         (amd64_windows_segment_register_p): Remove static.
8942         (_initialize_amd64_windows_nat): Update.
8943         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
8944         * i386-windows-nat.c (context_offset): Update.
8945         (i386_mappings): Rename and remove static.
8946         (i386_windows_segment_register_p): Remove static.
8947         (_initialize_i386_windows_nat): Update.
8948         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
8949         (STATUS_WX86_SINGLE_STEP): New macro.
8950         (EnumProcessModulesEx): New macro.
8951         (Wow64SuspendThread): New macro.
8952         (Wow64GetThreadContext): New macro.
8953         (Wow64SetThreadContext): New macro.
8954         (Wow64GetThreadSelectorEntry): New macro.
8955         (windows_set_context_register_offsets): Add static.
8956         (windows_set_segment_register_p): Likewise.
8957         (windows_add_thread): Adapt for WOW64 processes.
8958         (windows_fetch_one_register): Likewise.
8959         (windows_nat_target::fetch_registers): Likewise.
8960         (windows_store_one_register): Likewise.
8961         (display_selector): Likewise.
8962         (display_selectors): Likewise.
8963         (handle_exception): Likewise.
8964         (windows_continue): Likewise.
8965         (windows_nat_target::resume): Likewise.
8966         (windows_add_all_dlls): Likewise.
8967         (do_initial_windows_stuff): Likewise.
8968         (windows_nat_target::attach): Likewise.
8969         (windows_get_exec_module_filename): Likewise.
8970         (windows_nat_target::create_inferior): Likewise.
8971         (windows_xfer_siginfo): Likewise.
8972         (_initialize_loadable): Initialize Wow64SuspendThread,
8973         Wow64GetThreadContext, Wow64SetThreadContext,
8974         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
8975         * windows-nat.h (windows_set_context_register_offsets):
8976         Remove declaration.
8977         (windows_set_segment_register_p): Likewise.
8978         (i386_windows_segment_register_p): Add declaration.
8979         (amd64_windows_segment_register_p): Likewise.
8980
8981 2020-03-04  Luis Machado  <luis.machado@linaro.org>
8982
8983         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
8984         in "info registers" for AArch64/ARM.
8985
8986         The change caused "info registers" to not print GPR's.
8987
8988         gdb/ChangeLog:
8989
8990         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8991
8992         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8993         when reg->group is empty and reggroup is not.
8994
8995 2020-03-03  Tom Tromey  <tromey@adacore.com>
8996
8997         * dwarf2/frame.c (struct dwarf2_frame_cache)
8998         <checked_tailcall_bottom, entry_cfa_sp_offset,
8999         entry_cfa_sp_offset_p>: Remove members.
9000         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
9001         (dwarf2_frame_prev_register): Don't call
9002         dwarf2_tailcall_sniffer_first.
9003         (dwarf2_append_unwinders): Don't append tailcall unwinder.
9004         * frame-unwind.c (add_unwinder): New fuction.
9005         (frame_unwind_init): Use it.  Add tailcall unwinder.
9006
9007 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9008             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9009
9010         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
9011         value should be printed as true.
9012
9013 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
9014
9015         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
9016         (windows_init_abi): Set and use windows_so_ops.
9017
9018 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
9019
9020         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
9021         when verifying if dealing with a convenience variable.
9022
9023 2020-03-03  Luis Machado  <luis.machado@linaro.org>
9024
9025         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
9026
9027 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
9028
9029         * infrun.c (gdbarch_supports_displaced_stepping): New.
9030         (use_displaced_stepping): Break up conditions in smaller pieces.
9031         Use gdbarch_supports_displaced_stepping.
9032         (displaced_step_prepare_throw): Use
9033         gdbarch_supports_displaced_stepping.
9034
9035 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * NEWS: Mention new behaviour of the history filename.
9038         * top.c (write_history_p): Add comment.
9039         (show_write_history_p): Add header comment, give a different
9040         message when history writing is on, but the history filename is
9041         empty.
9042         (history_filename): Add comment.
9043         (history_filename_empty): New function.
9044         (show_history_filename): Add header comment, give a different
9045         message when the filename is empty.
9046         (init_history): Compare history_filename against nullptr, and only
9047         read history if the filename is not empty.
9048         (set_history_filename): Add header comment, and only make
9049         non-empty filenames absolute.
9050         (init_main): Make the filename argument to 'set history filename'
9051         optional.
9052
9053 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
9054
9055         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
9056         (arm_supply_vfpregset): ...this, and update to use VFP registers.
9057         (fetch_fp_register): Update.
9058         (fetch_fp_regs): Update.
9059         (store_fp_register): Update.
9060         (store_fp_regs): Update.
9061         (arm_netbsd_nat_target::read_description): New function.
9062         (fetch_elfcore_registers): Update.
9063
9064 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9065
9066         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
9067         general_thread if the stop reply is missing a thread-id.
9068         (remote_target::process_stop_reply): Use the first non-exited
9069         thread if the target didn't pass a thread-id.
9070         * infrun.c (do_target_wait): Move call to
9071         switch_to_inferior_no_thread to ....
9072         (do_target_wait_1): ... here.
9073
9074 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
9075
9076         * debuginfod-support.c: Include defs.h first.
9077
9078 2020-02-28  Tom de Vries  <tdevries@suse.de>
9079
9080         * symfile.c (set_initial_language): Use default language for lookup.
9081
9082 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
9083
9084         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
9085         reader variable, pass `this` to read_cutu_die_from_dwo.
9086
9087 2020-02-27  Aaron Merey  <amerey@redhat.com>
9088
9089         * source.c (open_source_file): Check for nullptr when computing
9090         srcpath.
9091
9092 2020-02-27  Tom Tromey  <tromey@adacore.com>
9093
9094         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
9095         member.
9096         (dwarf2_add_field): Don't update nfields.
9097         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
9098
9099 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9100
9101         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
9102         abs.
9103
9104 2020-02-26  Tom Tromey  <tom@tromey.com>
9105
9106         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
9107         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
9108         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
9109         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
9110         per_cu_data.
9111
9112 2020-02-26  Tom Tromey  <tom@tromey.com>
9113
9114         * dwarf2/index-write.c (psym_index_map): Change type.
9115         (add_address_entry_worker, write_one_signatured_type)
9116         (recursively_count_psymbols, recursively_write_psymbols)
9117         (class debug_names, psyms_seen_size, write_gdbindex)
9118         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
9119
9120 2020-02-26  Aaron Merey  <amerey@redhat.com>
9121
9122         * Makefile.in: Handle optional debuginfod support.
9123         * NEWS: Update.
9124         * README: Add --with-debuginfod summary.
9125         * config.in: Regenerate.
9126         * configure: Regenerate.
9127         * configure.ac: Handle optional debuginfod support.
9128         * debuginfod-support.c: debuginfod helper functions.
9129         * debuginfod-support.h: Ditto.
9130         * doc/gdb.texinfo: Add --with-debuginfod to configure options
9131         summary.
9132         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
9133         when a dwz file cannot be found.
9134         * elfread.c (elf_symfile_read): Query debuginfod servers when a
9135         debuginfo file cannot be found.
9136         * source.c (open_source_file): Query debuginfod servers when a
9137         source file cannot be found.
9138         * top.c (print_gdb_configuration): Include
9139         --{with,without}-debuginfod in the output.
9140
9141 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
9142
9143         * thread.c (thr_try_catch_cmd): Print thread name.
9144
9145 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
9146
9147         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
9148         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
9149         dwarf2_fetch_die_type_sect_off): Move to...
9150         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
9151         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
9152         dwarf2_fetch_die_type_sect_off): ... here.
9153         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
9154         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
9155         dwarf2_fetch_die_type_sect_off): Move doc to header file.
9156
9157 2020-02-26  Tom de Vries  <tdevries@suse.de>
9158
9159         PR gdb/25603
9160         * symfile.c (set_initial_language): Exit-early if
9161         language_mode == language_mode_manual.
9162
9163 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
9164
9165         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
9166         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
9167         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
9168
9169 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
9170
9171         * gdbtypes.c (create_array_type_with_stride): Handle negative
9172         array strides.
9173         * valarith.c (value_subscripted_rvalue): Likewise.
9174
9175 2020-02-25  Luis Machado  <luis.machado@linaro.org>
9176
9177         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
9178
9179 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
9180
9181         * loc.h (dwarf2_get_die_type): Move to...
9182         * read.h (dwarf2_get_die_type): ... here.
9183         * read.c (dwarf2_get_die_type): Move doc to header.
9184
9185 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
9186
9187         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
9188         'gnulib/Makefile.in' to the list.
9189
9190 2020-02-24  Tom Tromey  <tom@tromey.com>
9191
9192         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
9193         Remove.
9194         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
9195         XOBNEWVEC.
9196
9197 2020-02-24  Tom Tromey  <tom@tromey.com>
9198
9199         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
9200         New method.
9201         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
9202         (dw2_do_instantiate_symtab, dw2_get_file_names)
9203         (build_type_psymtab_dependencies, load_full_type_unit): Update.
9204
9205 2020-02-24  Tom Tromey  <tom@tromey.com>
9206
9207         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
9208         make_scoped_restore.
9209         (dwarf2_psymtab::read_symtab): Don't clear
9210         reading_partial_symbols.
9211
9212 2020-02-24  Tom de Vries  <tdevries@suse.de>
9213
9214         PR gdb/25592
9215         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
9216
9217 2020-02-24  Tom de Vries  <tdevries@suse.de>
9218
9219         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
9220         commands layout next/prev/regs.
9221
9222 2020-02-22  Tom Tromey  <tom@tromey.com>
9223
9224         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
9225         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
9226
9227 2020-02-22  Tom Tromey  <tom@tromey.com>
9228
9229         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
9230
9231 2020-02-22  Tom Tromey  <tom@tromey.com>
9232
9233         * tui/tui-win.c (_initialize_tui_win): Add usage text.
9234         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
9235         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
9236         * tui/tui.c (_initialize_tui): Add usage text.
9237
9238 2020-02-22  Tom Tromey  <tom@tromey.com>
9239
9240         * tui/tui-win.c (tui_set_focus_command)
9241         (tui_set_win_height_command): Use error_no_arg.
9242         (_initialize_tui_win): Update help text.
9243         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
9244
9245 2020-02-22  Tom Tromey  <tom@tromey.com>
9246
9247         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
9248         * tui/tui-disasm.h (struct tui_disasm_window)
9249         <display_start_addr>: Declare.
9250         * tui/tui-source.h (struct tui_source_window)
9251         <display_start_addr>: Declare.
9252         * tui/tui-winsource.h (struct tui_source_window_base)
9253         <show_source_line, display_start_addr>: New methods.
9254         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
9255         Rename and move to protected section.
9256         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
9257         (tui_source_window_base::do_erase_source_content): Update.
9258         (tui_source_window_base::show_source_line): Now a method.
9259         (tui_source_window_base::show_source_content)
9260         (tui_source_window_base::tui_source_window_base)
9261         (tui_source_window_base::rerender)
9262         (tui_source_window_base::refill)
9263         (tui_source_window_base::do_scroll_horizontal)
9264         (tui_source_window_base::set_is_exec_point_at)
9265         (tui_source_window_base::update_breakpoint_info)
9266         (tui_source_window_base::update_exec_info): Update.
9267         * tui/tui-source.c (tui_source_window::set_contents)
9268         (tui_source_window::showing_source_p)
9269         (tui_source_window::do_scroll_vertical)
9270         (tui_source_window::location_matches_p)
9271         (tui_source_window::line_is_displayed): Update.
9272         (tui_source_window::display_start_addr): New method.
9273         * tui/tui-disasm.c (tui_disasm_window::set_contents)
9274         (tui_disasm_window::do_scroll_vertical)
9275         (tui_disasm_window::location_matches_p): Update.
9276         (tui_disasm_window::display_start_addr): New method.
9277
9278 2020-02-22  Tom Tromey  <tom@tromey.com>
9279
9280         * NEWS: Add entry for gdb.register_window_type.
9281         * tui/tui-layout.h (window_factory): New typedef.
9282         (tui_register_window): Declare.
9283         * tui/tui-layout.c (saved_tui_windows): New global.
9284         (tui_apply_current_layout): Use it.
9285         (tui_register_window): New function.
9286         * python/python.c (do_start_initialization): Call
9287         gdbpy_initialize_tui.
9288         (python_GdbMethods): Add "register_window_type" function.
9289         * python/python-internal.h (gdbpy_register_tui_window)
9290         (gdbpy_initialize_tui): Declare.
9291         * python/py-tui.c: New file.
9292         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
9293
9294 2020-02-22  Tom Tromey  <tom@tromey.com>
9295
9296         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
9297
9298 2020-02-22  Tom Tromey  <tom@tromey.com>
9299
9300         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
9301         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
9302         * tui/tui-data.c (tui_set_win_with_focus): Remove.
9303         (tui_set_win_focus_to): Move from tui-win.c.
9304
9305 2020-02-22  Tom Tromey  <tom@tromey.com>
9306
9307         * tui/tui-layout.c (make_standard_window, get_locator_window): New
9308         functions.
9309         (known_window_types): New global.
9310         (tui_get_window_by_name): Reimplement.
9311         (initialize_known_windows): New function.
9312         (validate_window_name): Rewrite.
9313         (_initialize_tui_layout): Call initialize_known_windows.
9314
9315 2020-02-22  Tom Tromey  <tom@tromey.com>
9316
9317         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
9318         Remove constants.
9319         * tui/tui-winsource.h (struct tui_source_window_base)
9320         <tui_source_window_base>: Remove parameter.
9321         * tui/tui-winsource.c
9322         (tui_source_window_base::tui_source_window_base): Remove
9323         parameter.
9324         (tui_source_window_base::refill): Update.
9325         * tui/tui-stack.h (struct tui_locator_window)
9326         <tui_locator_window>: Update.
9327         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
9328         Default the constructor.
9329         * tui/tui-regs.h (struct tui_data_item_window)
9330         <tui_data_item_window>: Default the constructor.
9331         (struct tui_data_window) <tui_data_window>: Likewise.
9332         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
9333         Default the constructor.
9334         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
9335         Default the constructor.
9336         <type>: Remove.
9337         (struct tui_win_info) <tui_win_info>: Default the constructor.
9338         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
9339         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
9340         Default the constructor.
9341
9342 2020-02-22  Tom Tromey  <tom@tromey.com>
9343
9344         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
9345         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
9346         * tui/tui-win.c (tui_resize_all): Don't call
9347         tui_delete_invisible_windows.
9348         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
9349         done.
9350         (tui_set_layout): Update.
9351         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
9352         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
9353         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
9354
9355 2020-02-22  Tom Tromey  <tom@tromey.com>
9356
9357         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
9358         correctly.
9359
9360 2020-02-22  Tom Tromey  <tom@tromey.com>
9361
9362         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
9363
9364 2020-02-22  Tom Tromey  <tom@tromey.com>
9365
9366         * tui/tui-winsource.h (struct tui_source_window_iterator)
9367         <inner_iterator>: New etytypedef.
9368         <tui_source_window_iterator>: Take "end" parameter.
9369         <tui_source_window_iterator>: Take iterator.
9370         <operator*, advance>: Update.
9371         <m_iter>: Change type.
9372         <m_end>: New field.
9373         (struct tui_source_windows) <begin, end>: Update.
9374         * tui/tui-layout.c (tui_windows): New global.
9375         (tui_apply_current_layout): Clear tui_windows.
9376         (tui_layout_window::apply): Update tui_windows.
9377         * tui/tui-data.h (tui_windows): Declare.
9378         (all_tui_windows): Now inline function.
9379         (class tui_window_iterator, struct all_tui_windows): Remove.
9380
9381 2020-02-22  Tom Tromey  <tom@tromey.com>
9382
9383         PR tui/17850:
9384         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
9385         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
9386         "height" argument.
9387         (class tui_layout_window) <get_sizes>: Likewise.
9388         (class tui_layout_split) <tui_layout_split>: Add "vertical"
9389         argument.
9390         <get_sizes>: Add "height" argument.
9391         <m_vertical>: New field.
9392         * tui/tui-layout.c (tui_layout_split::clone): Update.
9393         (tui_layout_split::get_sizes): Add "height" argument.
9394         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
9395         (tui_new_layout_command): Parse "-horizontal".
9396         (_initialize_tui_layout): Update help string.
9397         (tui_layout_split::specification): Add "-horizontal" when needed.
9398         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
9399         argument.
9400         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
9401         New methods.
9402
9403 2020-02-22  Tom Tromey  <tom@tromey.com>
9404
9405         * tui/tui-layout.h (enum tui_adjust_result): New.
9406         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
9407         (class tui_layout_window) <adjust_size>: Return
9408         tui_adjust_result.  Rewrite.
9409         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
9410         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
9411
9412 2020-02-22  Tom Tromey  <tom@tromey.com>
9413
9414         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
9415         parameter and return types.
9416         (class tui_layout_base) <specification>: Add "depth".
9417         (class tui_layout_window) <specification>: Add "depth".
9418         (class tui_layout_split) <specification>: Add "depth".
9419         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
9420         and return types.
9421         (tui_new_layout_command): Parse sub-layouts.
9422         (_initialize_tui_layout): Update help string.
9423         (tui_layout_window::specification): Add "depth".
9424         (add_layout_command): Update.
9425
9426 2020-02-22  Tom Tromey  <tom@tromey.com>
9427
9428         * NEWS: Add "tui new-layout" item.
9429         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
9430         Add new-layout command to help text.
9431         (validate_window_name): New function.
9432         (tui_new_layout_command): New function.
9433         (_initialize_tui_layout): Register "new-layout".
9434         (tui_layout_window::specification): New method.
9435         (tui_layout_window::specification): New method.
9436         * tui/tui-layout.h (class tui_layout_base) <specification>: New
9437         method.
9438         (class tui_layout_window) <specification>: New method.
9439         (class tui_layout_split) <specification>: New method.
9440
9441 2020-02-22  Tom Tromey  <tom@tromey.com>
9442
9443         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
9444         * tui/tui-win.c (window_name_completer): Update comment.
9445         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
9446         Declare method.
9447         (class tui_layout_window) <replace_window>: Likewise.
9448         (class tui_layout_split) <replace_window>: Likewise.
9449         (tui_set_layout): Don't declare.
9450         (tui_set_initial_layout): Declare function.
9451         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
9452         (asm_regs_layout): New globals.
9453         (tui_current_layout, show_layout): Remove.
9454         (tui_set_layout, tui_add_win_to_layout): Rewrite.
9455         (find_layout, tui_apply_layout): New function.
9456         (layout_completer): Remove.
9457         (tui_next_layout): Reimplement.
9458         (tui_next_layout_command): New function.
9459         (tui_set_initial_layout, tui_prev_layout_command): New functions.
9460         (tui_regs_layout): Reimplement.
9461         (tui_regs_layout_command): New function.
9462         (extract_display_start_addr): Rewrite.
9463         (next_layout, prev_layout): Remove.
9464         (tui_layout_window::replace_window): New method.
9465         (tui_layout_split::replace_window): New method.
9466         (destroy_layout): New function.
9467         (layout_list): New global.
9468         (add_layout_command): New function.
9469         (initialize_layouts): Update.
9470         (tui_layout_command): New function.
9471         (_initialize_tui_layout): Install "layout" commands.
9472         * tui/tui-data.h (enum tui_layout_type): Remove.
9473         (tui_current_layout): Don't declare.
9474
9475 2020-02-22  Tom Tromey  <tom@tromey.com>
9476
9477         * tui/tui-regs.c (tui_reg_layout): Remove.
9478         (tui_reg_command): Use tui_regs_layout.
9479         * tui/tui-layout.h (tui_reg_command): Declare.
9480         * tui/tui-layout.c (tui_reg_command): New function.
9481
9482 2020-02-22  Tom Tromey  <tom@tromey.com>
9483
9484         * tui/tui.c (tui_rl_delete_other_windows): Call
9485         tui_remove_some_windows.
9486         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
9487         Declare method.
9488         (class tui_layout_window) <remove_windows>: New method.
9489         (class tui_layout_split) <remove_windows>: Declare.
9490         (tui_remove_some_windows): Declare.
9491         * tui/tui-layout.c (tui_remove_some_windows): New function.
9492         (tui_layout_split::remove_windows): New method.
9493
9494 2020-02-22  Tom Tromey  <tom@tromey.com>
9495
9496         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
9497         * tui/tui-layout.h (tui_next_layout): Declare.
9498         * tui/tui-layout.c (tui_next_layout): New function.
9499
9500 2020-02-22  Tom Tromey  <tom@tromey.com>
9501
9502         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
9503         correct coordinates.
9504
9505 2020-02-22  Tom Tromey  <tom@tromey.com>
9506
9507         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
9508         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
9509         DATA_WIN case.
9510
9511 2020-02-22  Tom Tromey  <tom@tromey.com>
9512
9513         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
9514         TUI_DISASM_WIN, not tui_win_list.
9515
9516 2020-02-22  Tom Tromey  <tom@tromey.com>
9517
9518         * valprint.c (generic_val_print_enum_1)
9519         (val_print_type_code_flags): Style member names.
9520         * rust-lang.c (val_print_struct, rust_print_enum)
9521         (rust_print_struct_def, rust_internal_print_type): Style member
9522         names.
9523         * p-valprint.c (pascal_object_print_value_fields): Style member
9524         names.  Only call fprintf_symbol_filtered for static members.
9525         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
9526         * f-valprint.c (f_val_print): Style member names.
9527         * f-typeprint.c (f_type_print_base): Style member names.
9528         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
9529         call fprintf_symbol_filtered for static members.
9530         (cp_print_class_member): Style member names.
9531         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
9532         member names.
9533         * ada-valprint.c (ada_print_scalar): Style enum names.
9534         (ada_val_print_enum): Likewise.
9535         * ada-typeprint.c (print_enum_type): Style enum names.
9536
9537 2020-02-21  Tom Tromey  <tom@tromey.com>
9538
9539         * psympriv.h (struct partial_symtab): Update comment.
9540
9541 2020-02-21  Tom Tromey  <tromey@adacore.com>
9542
9543         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
9544         type is CORE_ADDR.
9545
9546 2020-02-21  Tom de Vries  <tdevries@suse.de>
9547
9548         PR gdb/25534
9549         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
9550         if dependencies[i]->user != NULL.
9551
9552 2020-02-21  Ali Tamur  <tamur@google.com>
9553
9554         * dwarf2/read.c (dwarf2_name): Add null check.
9555
9556 2020-02-20  Tom Tromey  <tom@tromey.com>
9557
9558         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
9559         ">=", in binary search.
9560         (dwarf2_find_containing_comp_unit): New overload.
9561         (run_test): New self-test.
9562         (_initialize_dwarf2_read): Register new test.
9563
9564 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
9565
9566         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
9567         * riscv-tdep.h: Likewise.
9568         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
9569         rv32-only CSR.
9570         * features/riscv/64bit-csr.xml: Regenerated.
9571
9572 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
9573             Tom Tromey  <tom@tromey.com>
9574
9575         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
9576         of 'fputc_unfiltered'.
9577         (putchar_unfiltered): Call 'fputc_unfiltered'.
9578         (fputc_unfiltered): Call 'fputs_unfiltered'.
9579
9580 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
9581
9582         * config.in: Regenerate.
9583         * configure: Regenerate.
9584         * configure.ac: Add --with-python-libdir option.
9585         * main.c: Use WITH_PYTHON_LIBDIR.
9586
9587 2020-02-19  Tom Tromey  <tom@tromey.com>
9588
9589         * symtab.c (general_symbol_info::compute_and_set_names): Use
9590         obstack_strndup.  Simplify call to symbol_set_demangled_name.
9591
9592 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
9593
9594         * dwarf2/read.c (allocate_signatured_type_table,
9595         allocate_dwo_unit_table, allocate_type_unit_groups_table,
9596         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
9597         Remove objfile parameter, update all callers.
9598
9599 2020-02-19  Doug Evans  <dje@google.com>
9600
9601         PR rust/25535
9602         * rust-lang.c (rust_print_enum): Apply embedded_offset to
9603         rust_enum_variant calculation.
9604
9605 2020-02-19  Tom Tromey  <tromey@adacore.com>
9606
9607         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
9608
9609 2020-02-19  Tom Tromey  <tromey@adacore.com>
9610
9611         * ada-lang.c (cache_symbol): Use obstack_strdup.
9612
9613 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9614
9615         * configure: Regenerate.
9616
9617 2020-02-19  Tom Tromey  <tromey@adacore.com>
9618
9619         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
9620         NULL check.
9621
9622 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
9623
9624         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
9625
9626 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
9627
9628         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
9629         if GDBSERVER is not defined.
9630         (riscv_tdesc_cache): Likewise, also store const target_desc.
9631         (STATIC_IN_GDB): Define.
9632         (riscv_create_target_description): Update declaration with
9633         STATIC_IN_GDB.
9634         (riscv_lookup_target_description): New function, only define if
9635         GDBSERVER is not defined.
9636         * arch/riscv.h (riscv_create_target_description): Declare only
9637         when GDBSERVER is defined.
9638         (riscv_lookup_target_description): New declaration when GDBSERVER
9639         is not defined.
9640         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
9641         (riscv_linux_read_features): ...this, and return
9642         riscv_gdbarch_features instead of target_desc.
9643         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
9644         (riscv_linux_read_description): Rename to...
9645         (riscv_linux_read_features): ...this.
9646         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
9647         Update to use riscv_gdbarch_features and
9648         riscv_lookup_target_description.
9649         * riscv-tdep.c (riscv_find_default_target_description): Use
9650         riscv_lookup_target_description instead of
9651         riscv_create_target_description.
9652
9653 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9654
9655         * valprint.c (generic_val_print_enum_1): When printing a flag
9656         enum with value 0 and there is no enumerator with value 0, print
9657         just "0" instead of "(unknown: 0x0)".
9658
9659 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9660
9661         * valprint.c (generic_val_print_enum_1): Print unknown part of
9662         flag enum in hex.
9663
9664 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9665
9666         * dwarf2/read.c (update_enumeration_type_from_children): Allow
9667         flag enums to contain duplicate enumerators.
9668         * valprint.c (generic_val_print_enum_1): Update comment.
9669
9670 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9671
9672         * dwarf2/read.c: Include "count-one-bits.h".
9673         (update_enumeration_type_from_children): If an enumerator has
9674         multiple bits set, don't treat the enumeration as a "flag enum".
9675         * valprint.c (generic_val_print_enum_1): Assert that enumerators
9676         of flag enums have 0 or 1 bit set.
9677
9678 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9679
9680         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
9681         conversion.
9682         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9683         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9684         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9685         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9686         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9687
9688 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
9689
9690         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
9691
9692 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9693
9694         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
9695         displaced_step_closure_up.
9696         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9697         (struct displaced_step_closure_up):
9698         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9699         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9700         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
9701         Likewise.
9702         * gdbarch.sh (displaced_step_copy_insn): Likewise.
9703         * gdbarch.c, gdbarch.h: Re-generate.
9704         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
9705         displaced_step_closure_up.
9706         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9707         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9708         * infrun.h (displaced_step_closure_up): New type alias.
9709         (struct displaced_step_inferior_state) <step_closure>: Change
9710         type to displaced_step_closure_up.
9711         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
9712         displaced_step_closure_up.
9713         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9714
9715 2020-02-14  Tom Tromey  <tom@tromey.com>
9716
9717         * minidebug.c (gnu_debug_key): New global.
9718         (find_separate_debug_file_in_section): Use it.
9719
9720 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9721
9722         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
9723         std::unique_ptr.
9724         * gdbarch.c: Re-generate.
9725         * gdbarch.h: Re-generate.
9726         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
9727         change.
9728         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
9729         type to std::unique_ptr.
9730         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
9731         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
9732         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
9733         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
9734         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
9735         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
9736         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
9737         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
9738         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
9739
9740 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9741
9742         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
9743         std::unique_ptr.
9744         (displaced_step_clear): Rename to...
9745         (displaced_step_reset): ... this.  Just call displaced->reset ().
9746         (displaced_step_clear_cleanup): Rename to...
9747         (displaced_step_reset_cleanup): ... this.
9748         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
9749         (displaced_step_fixup): Likewise.
9750         (resume_1): Likewise.
9751         (handle_inferior_event): Restore child's memory before calling
9752         displaced_step_fixup on the parent.
9753         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
9754         to std::unique_ptr.
9755         <step_closure>: Change type to std::unique_ptr.
9756
9757 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
9758
9759         * arm-tdep.c: Include count-one-bits.h.
9760         (cleanup_block_store_pc): Use count_one_bits.
9761         (cleanup_block_load_pc): Use count_one_bits.
9762         (arm_copy_block_xfer): Use count_one_bits.
9763         (thumb2_copy_block_xfer): Use count_one_bits.
9764         (thumb_copy_pop_pc_16bit): Use count_one_bits.
9765         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
9766         (thumb_get_next_pcs_raw): Use count_one_bits.
9767         (arm_get_next_pcs_raw): Use count_one_bits_l.
9768         * arch/arm.c (bitcount): Remove.
9769         * arch/arm.h (bitcount): Remove.
9770
9771 2020-02-14  Tom Tromey  <tromey@adacore.com>
9772
9773         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
9774         Update.
9775         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
9776         * dwarf2/loc.c (call_site_find_chain_1): Return
9777         unique_xmalloc_ptr.
9778         (call_site_find_chain): Likewise.
9779
9780 2020-02-14  Richard Biener  <rguenther@suse.de>
9781
9782         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
9783         on expression with division operators.
9784
9785 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
9786
9787         * MAINTAINERS (Write After Approval): Adding myself.
9788
9789 2020-02-12  Tom Tromey  <tom@tromey.com>
9790
9791         * event-loop.c (event_data, gdb_event, event_handler_func):
9792         Remove.
9793
9794 2020-02-12  Tom Tromey  <tom@tromey.com>
9795
9796         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
9797         (dwarf2_frame_objfile_data): Add comment.
9798         (find_comp_unit, set_comp_unit): New functions.
9799         (dwarf2_frame_find_fde): Use find_comp_unit.
9800         (dwarf2_build_frame_info): Use set_comp_unit.
9801
9802 2020-02-12  Tom Tromey  <tom@tromey.com>
9803
9804         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
9805         (comp_unit): Don't initialize objfile.
9806         (execute_cfa_program): Add text_offset parameter.
9807         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
9808         (dwarf2_frame_cache): Update.
9809         (dwarf2_build_frame_info): Don't set "objfile" member.
9810
9811 2020-02-12  Tom Tromey  <tom@tromey.com>
9812
9813         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
9814         (decode_frame_entry): Likewise.
9815         (dwarf2_build_frame_info): Update.
9816
9817 2020-02-12  Tom Tromey  <tom@tromey.com>
9818
9819         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
9820         (decode_frame_entry_1): Use the comp_unit obstack.
9821
9822 2020-02-12  Tom Tromey  <tom@tromey.com>
9823
9824         * dwarf2/frame.c (struct comp_unit): Add initializers and
9825         constructor.
9826         (dwarf2_frame_objfile_data): Store a comp_unit.
9827         (dwarf2_frame_find_fde): Update.
9828         (dwarf2_build_frame_info): Use "new".
9829
9830 2020-02-12  Tom Tromey  <tom@tromey.com>
9831
9832         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
9833         (dwarf2_fde_table): Typedef for std::vector.
9834         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
9835         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
9836         (decode_frame_entry): Update.
9837         (dwarf2_build_frame_info): Use "new".
9838
9839 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9840
9841         * arm-tdep.c (arm_gdbarch_init): Update.
9842         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
9843         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
9844         have_neon, is_m>: Change to bool.
9845
9846 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
9847
9848         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
9849
9850 2020-02-12  Tom Tromey  <tom@tromey.com>
9851
9852         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
9853
9854 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
9855
9856         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
9857         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
9858
9859 2020-02-11  Tom Tromey  <tom@tromey.com>
9860
9861         * psymtab.h: Update comment.
9862
9863 2020-02-11  Tom Tromey  <tom@tromey.com>
9864
9865         * gdb_obstack.h (struct auto_obstack): Use
9866         DISABLE_COPY_AND_ASSIGN.
9867
9868 2020-02-11  Tom Tromey  <tom@tromey.com>
9869
9870         * dwarf2/frame.h (struct objfile): Don't forward declare.
9871
9872 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9873
9874         * cris-tdep.c (cris_supply_gregset): Change signature to match
9875         what struct regset expects.
9876         (cris_regset): New struct.
9877         (fetch_core_registers): Remove.
9878         (cris_iterate_over_regset_sections): New function.
9879         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
9880         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
9881
9882 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9883
9884         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
9885         registers.
9886
9887 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
9888
9889         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
9890
9891 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9892
9893         * configure: Re-generate.
9894
9895 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9896
9897         * configure: Re-generate.
9898
9899 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
9900
9901         * acinclude: Update warning.m4 path.
9902         * warning.m4: Move to gdbsupport.
9903
9904 2020-02-11  Tom Tromey  <tromey@adacore.com>
9905
9906         * remote.c (remote_console_output): Update.
9907         * printcmd.c (printf_command): Update.
9908         * event-loop.c (gdb_wait_for_event): Update.
9909         * linux-nat.c (sigchld_handler): Update.
9910         * remote-sim.c (gdb_os_write_stdout): Update.
9911         (gdb_os_flush_stdout): Update.
9912         (gdb_os_flush_stderr): Update.
9913         (gdb_os_write_stderr): Update.
9914         * exceptions.c (print_exception): Update.
9915         * remote-fileio.c (remote_fileio_func_read): Update.
9916         (remote_fileio_func_write): Update.
9917         * tui/tui.c (tui_enable): Update.
9918         * tui/tui-interp.c (tui_interp::init): Update.
9919         * utils.c (init_page_info): Update.
9920         (putchar_unfiltered, fputc_unfiltered): Update.
9921         (gdb_flush): Update.
9922         (emit_style_escape): Update.
9923         (flush_wrap_buffer, fputs_maybe_filtered): Update.
9924         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
9925         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
9926         (stderr_file::write): Update.
9927         (stderr_file::puts): Update.
9928         * ui-file.h (ui_file_isatty, ui_file_write)
9929         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
9930         (ui_file_puts): Don't declare.
9931
9932 2020-02-10  Tom de Vries  <tdevries@suse.de>
9933
9934         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
9935         sentinel to char *.
9936
9937 2020-02-09  Tom de Vries  <tdevries@suse.de>
9938
9939         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
9940         filename if it matches "<artificial>".
9941
9942 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9943
9944         * windows-tdep.c (struct enum_value_name): New struct.
9945         (create_enum): New function.
9946         (windows_get_siginfo_type): Create and use enum types.
9947
9948 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
9949
9950         * NEWS: Mention $_siginfo support for Windows.
9951         * windows-nat.c (handle_exception): Set siginfo_er.
9952         (windows_nat_target::mourn_inferior): Reset siginfo_er.
9953         (windows_xfer_siginfo): New function.
9954         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
9955         * windows-tdep.c (struct windows_gdbarch_data): New struct.
9956         (init_windows_gdbarch_data): New function.
9957         (get_windows_gdbarch_data): New function.
9958         (windows_get_siginfo_type): New function.
9959         (windows_init_abi): Register windows_get_siginfo_type.
9960         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
9961
9962 2020-02-08  Tom Tromey  <tom@tromey.com>
9963
9964         * dwarf2/read.c (class cutu_reader) <cutu_reader,
9965         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
9966         <keep>: Declare method.
9967         <m_keep>: Remove member.
9968         <~cutu_reader>: Remove.
9969         (cutu_reader::init_tu_and_read_dwo_dies): Update.
9970         (cutu_reader::cutu_reader): Update.
9971         (cutu_reader::keep): Rename from ~cutu_reader.
9972         (process_psymtab_comp_unit, build_type_psymtabs_1)
9973         (process_skeletonless_type_unit, load_partial_comp_unit)
9974         (load_full_comp_unit, dwarf2_read_addr_index)
9975         (read_signatured_type): Update.
9976
9977 2020-02-08  Tom Tromey  <tom@tromey.com>
9978
9979         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
9980         "want_partial_unit" parameter.
9981         (process_psymtab_comp_unit): Change want_partial_unit to bool.
9982         Inline check for DW_TAG_partial_unit.
9983         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
9984
9985 2020-02-08  Tom Tromey  <tom@tromey.com>
9986
9987         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
9988         read.c.
9989         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
9990         read.c.
9991
9992 2020-02-08  Tom Tromey  <tom@tromey.com>
9993
9994         * dwarf2/read.c (read_address): Move to comp-unit.c.
9995         (dwarf2_rnglists_process, dwarf2_ranges_process)
9996         (read_attribute_value, dwarf_decode_lines_1)
9997         (var_decode_location, decode_locdesc): Update.
9998         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
9999         read.c.  Remove "cu" parameter.
10000         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
10001         method.
10002
10003 2020-02-08  Tom Tromey  <tom@tromey.com>
10004
10005         * dwarf2/read.c (read_attribute_value, read_indirect_string)
10006         (read_indirect_line_string): Update.
10007         * dwarf2/comp-unit.c (read_offset): Remove.
10008         (read_comp_unit_head): Update.
10009         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
10010         method.
10011         (read_offset): Don't declare.
10012
10013 2020-02-08  Tom Tromey  <tom@tromey.com>
10014
10015         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
10016         * dwarf2/read.c (struct comp_unit_head): Move to
10017         dwarf2/comp-unit.h.
10018         (enum class rcuh_kind): Move to comp-unit.h.
10019         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
10020         (read_comp_unit_head, error_check_comp_unit_head)
10021         (read_and_check_comp_unit_head): Move to comp-unit.c.
10022         (read_offset, dwarf_unit_type_name): Likewise.
10023         (create_debug_type_hash_table, read_cutu_die_from_dwo)
10024         (cutu_reader::cutu_reader, read_call_site_scope)
10025         (find_partial_die, follow_die_offset): Update.
10026         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
10027
10028 2020-02-08  Tom Tromey  <tom@tromey.com>
10029
10030         * dwarf2/read.c (read_offset_1): Move to leb.c.
10031         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
10032         (dwarf_decode_macro_bytes): Update.
10033         * dwarf2/leb.c (read_offset): Rename; move from read.c.
10034         * dwarf2/leb.h (read_offset): Declare.
10035
10036 2020-02-08  Tom Tromey  <tom@tromey.com>
10037
10038         * dwarf2/read.c (dwarf2_section_size): Remove.
10039         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
10040         Update.
10041         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
10042
10043 2020-02-08  Tom Tromey  <tom@tromey.com>
10044
10045         * dwarf2/read.c (read_initial_length): Move to leb.c.
10046         * dwarf2/leb.h (read_initial_length): Declare.
10047         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
10048         handle_nonstd parameter.
10049         * dwarf2/frame.c (read_initial_length): Remove.
10050         (decode_frame_entry_1): Update.
10051
10052 2020-02-08  Tom Tromey  <tom@tromey.com>
10053
10054         * dwarf2/loc.c (dwarf2_find_location_expression)
10055         (dwarf_evaluate_loc_desc::get_tls_address)
10056         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
10057         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
10058         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
10059         (dwarf2_compile_property_to_c)
10060         (dwarf2_loc_desc_get_symbol_read_needs)
10061         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
10062         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
10063         (loclist_describe_location, loclist_tracepoint_var_ref)
10064         (loclist_generate_c_location): Update.
10065         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
10066         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
10067         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
10068         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
10069         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
10070         (dwarf2_per_cu_data::addr_size)
10071         (dwarf2_per_cu_data::ref_addr_size)
10072         (dwarf2_per_cu_data::text_offset)
10073         (dwarf2_per_cu_data::addr_type): Now methods.
10074         (per_cu_header_read_in): Make per_cu "const".
10075         (dwarf2_version): Remove.
10076         (dwarf2_per_cu_data::int_type): Now a method.
10077         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
10078         (set_die_type, read_array_type, read_subrange_index_type)
10079         (read_tag_string_type, read_subrange_type): Update.
10080         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
10081         offset_size, ref_addr_size, text_offset, addr_type, version,
10082         objfile, int_type, addr_sized_int_type>: Declare methods.
10083
10084 2020-02-08  Tom Tromey  <tom@tromey.com>
10085
10086         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
10087         Move earlier.
10088
10089 2020-02-08  Tom Tromey  <tom@tromey.com>
10090
10091         * dwarf2/read.h (dwarf_line_debug): Declare.
10092         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
10093         * dwarf2/read.c: Move line_header code to new files.
10094         (dwarf_line_debug): No longer static.
10095         * dwarf2/line-header.c: New file.
10096         * dwarf2/line-header.h: New file.
10097
10098 2020-02-08  Tom Tromey  <tom@tromey.com>
10099
10100         * dwarf2/read.c (struct line_header) <file_full_name,
10101         file_file_name>: Return unique_xmalloc_ptr.
10102         (line_header::file_file_name): Update.
10103         (line_header::file_full_name): Update.
10104         (dw2_get_file_names_reader): Update.
10105         (macro_start_file): Update.
10106
10107 2020-02-08  Tom Tromey  <tom@tromey.com>
10108
10109         * dwarf2/read.c (struct line_header) <file_full_name,
10110         file_file_name>: Declare methods.
10111         (dw2_get_file_names_reader): Update.
10112         (file_file_name): Now a method.
10113         (file_full_name): Likewise.
10114         (macro_start_file): Update.
10115
10116 2020-02-08  Tom Tromey  <tom@tromey.com>
10117
10118         * dwarf2/read.c (dwarf_always_disassemble)
10119         (show_dwarf_always_disassemble): Move to loc.c.
10120         (_initialize_dwarf2_read): Move "always-disassemble" registration
10121         to loc.c.
10122         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
10123         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
10124         static.
10125         (show_dwarf_always_disassemble): Move from read.c.
10126         (_initialize_dwarf2loc): Move always-disassemble from read.c.
10127
10128 2020-02-08  Tom Tromey  <tom@tromey.com>
10129
10130         * dwarf2/read.c (~dwarf2_per_objfile): Update.
10131         (create_quick_file_names_table): Return htab_up.
10132         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
10133         Update.
10134         * dwarf2/read.h (struct dwarf2_per_objfile)
10135         <quick_file_names_table>: Now htab_up.
10136
10137 2020-02-08  Tom Tromey  <tom@tromey.com>
10138
10139         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
10140
10141 2020-02-08  Tom Tromey  <tom@tromey.com>
10142
10143         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
10144         Rewrite.
10145         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
10146         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
10147         (abbrev_table::abbrev_table): No longer inline.
10148         (ABBREV_HASH_SIZE): Remove.
10149         (abbrev_table::m_abbrevs): Now an htab_up.
10150
10151 2020-02-08  Tom Tromey  <tom@tromey.com>
10152
10153         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
10154         (cutu_reader): Update.
10155         (build_type_psymtabs_1): Update.
10156         * dwarf2/abbrev.c (abbrev_table::read): Rename.
10157         (abbrev_table::alloc_abbrev): Update.
10158         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
10159         (abbrev_table::read): New static method, renamed from
10160         abbrev_table_read_table.
10161         (abbrev_table::alloc_abbrev)
10162         (abbrev_table::add_abbrev): Now private.
10163         (abbrev_table::abbrev_table): Now private.
10164         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
10165
10166 2020-02-08  Tom Tromey  <tom@tromey.com>
10167
10168         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
10169         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
10170         htab_up.
10171
10172 2020-02-08  Tom Tromey  <tom@tromey.com>
10173
10174         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
10175         htab_up.
10176         (lookup_dwo_unit_in_dwp): Update.
10177         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
10178         on obstack.
10179
10180 2020-02-08  Tom Tromey  <tom@tromey.com>
10181
10182         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
10183         obstack.
10184
10185 2020-02-08  Tom Tromey  <tom@tromey.com>
10186
10187         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
10188         line_header_hash.
10189         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
10190         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
10191         Change type to htab_up.
10192
10193 2020-02-08  Tom Tromey  <tom@tromey.com>
10194
10195         * dwarf2/read.c (allocate_type_unit_groups_table): Return
10196         htab_up.  Don't allocate on obstack.
10197         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
10198         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
10199         Change type to htab_up.
10200
10201 2020-02-08  Tom Tromey  <tom@tromey.com>
10202
10203         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
10204         Change type to htab_up.
10205         * dwarf2/read.c (create_signatured_type_table_from_index)
10206         (create_signatured_type_table_from_debug_names)
10207         (create_all_type_units, add_type_unit)
10208         (lookup_dwo_signatured_type, lookup_signatured_type)
10209         (process_skeletonless_type_unit): Update.
10210         (create_debug_type_hash_table, create_debug_types_hash_table):
10211         Change type of types_htab.
10212         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
10213         htab_up.  Don't allocate on obstack.
10214         (create_cus_hash_table): Change type of cus_htab parameter.
10215         (struct dwo_file) <cus, tus>: Now htab_up.
10216         (lookup_dwo_signatured_type, lookup_dwo_cutu)
10217         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
10218         (queue_and_load_all_dwo_tus): Update.
10219         * dwarf2/index-write.c (write_gdbindex): Update.
10220         (write_debug_names): Update.
10221
10222 2020-02-08  Tom Tromey  <tom@tromey.com>
10223
10224         * dwarf2/read.h (struct dwarf2_queue_item): Move from
10225         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
10226         destructor.
10227         (struct dwarf2_per_objfile) <queue>: New member.
10228         * dwarf2/read.c (struct dwarf2_queue_item): Move to
10229         dwarf2/read.h.
10230         (dwarf2_queue, dwarf2_queue_tail): Remove.
10231         (class dwarf2_queue_guard): Add parameter to constructor.  Use
10232         DISABLE_COPY_AND_ASSIGN.
10233         <m_per_objfile>: New member.
10234         <~dwarf2_queue_guard>: Rewrite.
10235         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
10236         Update.
10237         (~dwarf2_queue_item): New.
10238
10239 2020-02-08  Tom Tromey  <tom@tromey.com>
10240
10241         * dwarf2/read.c (struct die_info) <has_children>: New member.
10242         (dw2_get_file_names_reader): Remove has_children.
10243         (dw2_get_file_names): Update.
10244         (read_cutu_die_from_dwo): Remove has_children.
10245         (cutu_reader::init_tu_and_read_dwo_dies)
10246         (cutu_reader::cutu_reader): Update.
10247         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
10248         Remove has_children.
10249         (build_type_psymtabs_1, process_skeletonless_type_unit)
10250         (load_partial_comp_unit, load_full_comp_unit): Update.
10251         (create_dwo_cu_reader): Remove has_children.
10252         (create_cus_hash_table, read_die_and_children): Update.
10253         (read_full_die_1,read_full_die): Remove has_children.
10254         (read_signatured_type): Update.
10255         (class cutu_reader) <has_children>: Remove.
10256
10257 2020-02-08  Tom Tromey  <tom@tromey.com>
10258
10259         * dwarf2/expr.c: Rename from dwarf2expr.c.
10260         * dwarf2/expr.h: Rename from dwarf2expr.h.
10261         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
10262         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
10263         * dwarf2/frame.c: Rename from dwarf2-frame.c.
10264         * dwarf2/frame.h: Rename from dwarf2-frame.h.
10265         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
10266         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
10267         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
10268         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
10269         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
10270         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
10271         * dwarf2/loc.c: Rename from dwarf2loc.c.
10272         * dwarf2/loc.h: Rename from dwarf2loc.h.
10273         * dwarf2/read.c: Rename from dwarf2read.c.
10274         * dwarf2/read.h: Rename from dwarf2read.h.
10275         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
10276         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
10277         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
10278         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
10279         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
10280         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
10281         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
10282         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
10283         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
10284         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
10285         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
10286         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
10287         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
10288         Update.
10289         * Makefile.in (COMMON_SFILES): Update.
10290         (HFILES_NO_SRCDIR): Update.
10291
10292 2020-02-08  Tom Tromey  <tom@tromey.com>
10293
10294         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
10295         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
10296
10297 2020-02-08  Tom Tromey  <tom@tromey.com>
10298
10299         * dwarf2read.h (struct die_info): Don't declare.
10300
10301 2020-02-08  Tom Tromey  <tom@tromey.com>
10302
10303         * dwarf2read.h (die_info_ptr): Remove typedef.
10304
10305 2020-02-08  Tom Tromey  <tom@tromey.com>
10306
10307         * dwarf2read.c (read_call_site_scope)
10308         (handle_data_member_location, dwarf2_add_member_fn)
10309         (mark_common_block_symbol_computed, read_common_block)
10310         (attr_to_dynamic_prop, partial_die_info::read)
10311         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
10312         (dwarf2_symbol_mark_computed, set_die_type): Update.
10313         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
10314         method.
10315         (attr_form_is_block): Don't declare.
10316         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
10317
10318 2020-02-08  Tom Tromey  <tom@tromey.com>
10319
10320         * dwarf2read.c (dwarf2_find_base_address, )
10321         (read_call_site_scope, rust_containing_type)
10322         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
10323         (handle_data_member_location, dwarf2_add_member_fn)
10324         (get_alignment, read_structure_type, process_structure_scope)
10325         (mark_common_block_symbol_computed, read_common_block)
10326         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
10327         (partial_die_info::read, read_attribute_value, new_symbol)
10328         (lookup_die_type, dwarf2_get_ref_die_offset)
10329         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
10330         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
10331         (dwarf2_symbol_mark_computed): Update.
10332         * dwarf2/attribute.h (struct attribute) <value_as_address,
10333         form_is_section_offset, form_is_constant, form_is_ref>: Declare
10334         methods.
10335         (value_as_address, attr_form_is_section_offset)
10336         (attr_form_is_constant, attr_form_is_ref): Don't declare.
10337         * dwarf2/attribute.c (attribute::value_as_address)
10338         (attribute::form_is_section_offset, attribute::form_is_constant)
10339         (attribute::form_is_ref): Now methods.
10340
10341 2020-02-08  Tom Tromey  <tom@tromey.com>
10342
10343         * dwarf2read.c (struct attribute, DW_STRING)
10344         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
10345         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
10346         (attr_form_is_block, attr_form_is_section_offset)
10347         (attr_form_is_constant, attr_form_is_ref): Move.
10348         * dwarf2/attribute.h: New file.
10349         * dwarf2/attribute.c: New file, from dwarf2read.c.
10350         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
10351
10352 2020-02-08  Tom Tromey  <tom@tromey.com>
10353
10354         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
10355         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
10356         Move.
10357         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
10358         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
10359         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
10360         abbrev.c.
10361         * dwarf2/abbrev.h: New file.
10362         * dwarf2/abbrev.c: New file, from dwarf2read.c.
10363         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
10364
10365 2020-02-08  Tom Tromey  <tom@tromey.com>
10366
10367         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
10368         (dwarf2_section_size, dwarf2_get_section_info)
10369         (create_signatured_type_table_from_debug_names)
10370         (create_addrmap_from_aranges, read_debug_names_from_section)
10371         (get_gdb_index_contents_from_section, read_comp_unit_head)
10372         (error_check_comp_unit_head, read_abbrev_offset)
10373         (create_debug_type_hash_table, init_cu_die_reader)
10374         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
10375         (read_comp_units_from_section, create_cus_hash_table)
10376         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
10377         (create_dwp_v2_section, dwarf2_rnglists_process)
10378         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
10379         (abbrev_table_read_table, read_indirect_string_at_offset_from)
10380         (read_indirect_string_from_dwz, read_addr_index_1)
10381         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
10382         (dwarf_decode_macro_bytes, dwarf_decode_macros)
10383         (fill_in_loclist_baton): Update.
10384         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
10385         get_containing_section, get_bfd_owner, get_bfd_section,
10386         get_file_name, get_id, get_flags, empty, read>: Declare methods.
10387         (dwarf2_read_section, get_section_name, get_section_file_name)
10388         (get_containing_section, get_section_bfd_owner)
10389         (get_section_bfd_section, get_section_name, get_section_file_name)
10390         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
10391         declare.
10392         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
10393         (dwarf2_section_info::get_bfd_owner)
10394         (dwarf2_section_info::get_bfd_section)
10395         (dwarf2_section_info::get_name)
10396         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
10397         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
10398         (dwarf2_section_info::read): Now methods.
10399         * dwarf-index-write.c (class debug_names): Update.
10400
10401 2020-02-08  Tom Tromey  <tom@tromey.com>
10402
10403         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
10404         Move to dwarf2/section.h.
10405         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
10406         (get_section_bfd_section, get_section_name)
10407         (get_section_file_name, get_section_id, get_section_flags)
10408         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
10409         dwarf2/section.c.
10410         * dwarf2/section.h: New file.
10411         * dwarf2/section.c: New file, from dwarf2read.c.
10412         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
10413
10414 2020-02-08  Tom Tromey  <tom@tromey.com>
10415
10416         * dwarf2read.h (read_unsigned_leb128): Don't declare.
10417         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
10418         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
10419         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
10420         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
10421         * dwarf2/leb.h: New file, from dwarf2read.c.
10422         * dwarf2/leb.c: New file, from dwarf2read.c.
10423         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
10424         Remove.
10425         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
10426         (COMMON_SFILES): Add dwarf2/leb.c.
10427
10428 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
10429
10430         GDB 9.1 released.
10431
10432 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
10433
10434         PR gdb/25190:
10435         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
10436         * gdb/remote.c (remote_console_output): Update.
10437         * gdb/ui-file.c (fputs_unfiltered): Rename to...
10438         (ui_file_puts): ...this.
10439         * gdb/ui-file.h (ui_file_puts): Add declaration.
10440         * gdb/utils.c (emit_style_escape): Update.
10441         (flush_wrap_buffer): Update.
10442         (fputs_maybe_filtered): Update.
10443         (fputs_unfiltered): Add function.
10444
10445 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
10446
10447         * gdb/event-loop.c (gdb_wait_for_event): Update.
10448         * gdb/printcmd.c (printf_command): Update.
10449         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
10450         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
10451         (gdb_os_flush_stderr): Update.
10452         * gdb/remote.c (remote_console_output): Update.
10453         * gdb/ui-file.c (gdb_flush): Rename to...
10454         (ui_file_flush): ...this.
10455         (stderr_file::write): Update.
10456         (stderr_file::puts): Update.
10457         * gdb/ui-file.h (gdb_flush): Rename to...
10458         (ui_file_flush): ...this.
10459         * gdb/utils.c (gdb_flush): Add function.
10460         * gdb/utils.h (gdb_flush): Add declaration.
10461
10462 2020-02-07  Tom Tromey  <tromey@adacore.com>
10463
10464         PR breakpoints/24915:
10465         * source.c (find_and_open_source): Do not check basenames_may_differ.
10466
10467 2020-02-07  Tom Tromey  <tom@tromey.com>
10468
10469         * README: Update gdbserver documentation.
10470         * gdbserver: Move to top level.
10471         * configure.tgt (build_gdbserver): Remove.
10472         * configure.ac: Remove --enable-gdbserver.
10473         * configure: Rebuild.
10474         * Makefile.in (distclean): Don't mention gdbserver.
10475
10476 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
10477
10478         * source-cache.c (source_cache::ensure): Surround
10479         get_plain_source_lines with a try/catch.
10480         (source_cache::get_line_charpos): Get rid of try/catch
10481         and only check for the return value of "ensure".
10482         * tui/tui-source.c (tui_source_window::set_contents):
10483         Simplify "nlines" calculation.
10484
10485 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
10486
10487         * MAINTAINERS (Write After Approval): Add myself.
10488
10489 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10490
10491         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
10492         function call.
10493
10494 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
10495
10496         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
10497
10498 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
10499
10500         * nat/riscv-linux-tdesc.h: New file.
10501         * nat/riscv-linux-tdesc.c: New file, taking code from...
10502         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
10503         ... here.
10504         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
10505         NATDEPFILES.
10506
10507 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
10508
10509         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
10510         we don't set the fake simulator ptid to the null_ptid.
10511
10512 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
10513
10514         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
10515         * gdbthread.h (class thread_info) <resumed>: Likewise.
10516         * infrun.c (resume_1): Likewise.
10517         (proceed): Likewise.
10518         (infrun_thread_stop_requested): Likewise.
10519         (stop_all_threads): Likewise.
10520         (handle_inferior_event): Likewise.
10521         (restart_threads): Likewise.
10522         (finish_step_over): Likewise.
10523         (keep_going_stepped_thread): Likewise.
10524         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
10525         (linux_handle_extended_wait): Likewise.
10526         * record-btrace.c (get_thread_current_frame_id): Likewise.
10527         * record-full.c (record_full_wait_1): Likewise.
10528         * remote.c (remote_target::process_initial_stop_replies): Likewise.
10529         * target.c (target_resume): Likewise.
10530         * thread.c (set_running_thread): Likewise.
10531
10532 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
10533
10534         * f-valprint.c (f77_print_array_1): Changed datatype of index
10535         variable to LONGEST from int to enable it to contain bound
10536         values correctly.
10537
10538 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
10539
10540         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
10541         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
10542         offsets according to FLEN determined.
10543         (riscv_linux_nat_target::read_description): Determine FLEN
10544         dynamically.
10545         (riscv_linux_nat_target::fetch_registers): Size regset buffer
10546         according to FLEN determined.
10547         (riscv_linux_nat_target::store_registers): Likewise.
10548
10549 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
10550
10551         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
10552         when reg->group is empty and reggroup is not.
10553
10554 2020-01-31  Tom Tromey  <tromey@adacore.com>
10555
10556         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
10557         Call beneath target's mourn_inferior after unpushing.
10558
10559 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10560
10561         PR tui/9765
10562         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
10563         have enough lines to fill the screen, still return the lowest
10564         address we found.
10565
10566 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
10569         '-', '<', and '>' commands.
10570
10571 2020-01-29  Pedro Alves  <palves@redhat.com>
10572             Sergio Durigan Junior  <sergiodj@redhat.com>
10573
10574         * infcmd.c (construct_inferior_arguments): Assert that
10575         'argc' is greater than 0.
10576
10577 2020-01-29  Luis Machado  <luis.machado@linaro.org>
10578
10579         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
10580         (BRK_INSN_MASK): Define to 0xd4200000.
10581         (aarch64_program_breakpoint_here_p): New function.
10582         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
10583         * arch-utils.c (default_program_breakpoint_here_p): Moved from
10584         breakpoint.c.
10585         * arch-utils.h (default_program_breakpoint_here_p): Moved from
10586         breakpoint.h
10587         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
10588         call gdbarch_program_breakpoint_here_p.
10589         (program_breakpoint_here): Moved to arch-utils.c, renamed to
10590         default_program_breakpoint_here_p, changed return type to bool and
10591         simplified.
10592         * breakpoint.h (program_breakpoint_here): Moved prototype to
10593         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
10594         return type to bool.
10595         * gdbarch.c: Regenerate.
10596         * gdbarch.h: Regenerate.
10597         * gdbarch.sh (program_breakpoint_here_p): New method.
10598         * infrun.c (handle_signal_stop): Call
10599         gdbarch_program_breakpoint_here_p.
10600
10601 2020-01-26  Tom Tromey  <tom@tromey.com>
10602
10603         * ctfread.c (struct ctf_fp_info): Reindent.
10604         (_initialize_ctfread): Remove.
10605
10606 2020-01-26  Tom Tromey  <tom@tromey.com>
10607
10608         * psymtab.c (partial_map_expand_apply)
10609         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
10610         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
10611         (psym_print_stats, psym_expand_symtabs_for_function)
10612         (psym_map_symbol_filenames, psym_map_matching_symbols)
10613         (psym_expand_symtabs_matching)
10614         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
10615         (maintenance_check_psymtabs): Use new methods.
10616         * psympriv.h (struct partial_symtab) <readin_p,
10617         get_compunit_symtab>: New methods.
10618         <readin, compunit_symtab>: Remove members.
10619         (struct standard_psymtab): New.
10620         (struct legacy_psymtab): Derive from standard_psymtab.
10621         * dwarf2read.h (struct dwarf2_psymtab): Derive from
10622         standard_psymtab.
10623         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
10624
10625 2020-01-26  Tom Tromey  <tom@tromey.com>
10626
10627         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
10628         read_dependencies.  Add assert.
10629         * psymtab.c (partial_symtab::read_dependencies): New method.
10630         * psympriv.h (struct partial_symtab) <read_dependencies>: New
10631         method.
10632         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
10633         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
10634         read_dependencies.
10635         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
10636         Add assert.
10637
10638 2020-01-26  Tom Tromey  <tom@tromey.com>
10639
10640         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
10641         Call expand_psymtab.
10642         (xcoff_read_symtab): Call expand_psymtab.
10643         (xcoff_start_psymtab, xcoff_end_psymtab): Set
10644         legacy_expand_psymtab.
10645         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
10646         method.
10647         (struct legacy_psymtab) <expand_psymtab>: Implement.
10648         <legacy_expand_psymtab>: New member.
10649         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
10650         (parse_partial_symbols): Set legacy_expand_psymtab.
10651         (psymtab_to_symtab_1): Change argument order.  Call
10652         expand_psymtab.
10653         (new_psymtab): Set legacy_expand_psymtab.
10654         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
10655         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
10656         expand_psymtab.
10657         (dwarf2_psymtab::expand_psymtab): Rename from
10658         psymtab_to_symtab_1.  Call expand_psymtab.
10659         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
10660         (dbx_end_psymtab): Likewise.
10661         (dbx_psymtab_to_symtab_1): Change argument order. Call
10662         expand_psymtab.
10663         (dbx_read_symtab): Call expand_psymtab.
10664         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
10665         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
10666         (ctf_psymtab::read_symtab): Call expand_psymtab.
10667
10668 2020-01-26  Tom Tromey  <tom@tromey.com>
10669
10670         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
10671         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
10672         messages.
10673         * mdebugread.c (mdebug_read_symtab): Remove prints.
10674         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
10675         assert.
10676         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
10677
10678 2020-01-26  Tom Tromey  <tom@tromey.com>
10679
10680         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
10681         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
10682         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
10683         legacy_symtab.
10684         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
10685         * psymtab.c (psymtab_to_symtab): Call method.
10686         (dump_psymtab): Update.
10687         * psympriv.h (struct partial_symtab): Add virtual destructor.
10688         <read_symtab>: New method.
10689         (struct legacy_symtab): New.
10690         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
10691         (struct pst_map) <pst>: Now a legacy_psymtab.
10692         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
10693         (new_psymtab): Use legacy_psymtab.
10694         * dwarf2read.h (struct dwarf2_psymtab): New.
10695         (struct dwarf2_per_cu_data) <psymtab>: Use it.
10696         * dwarf2read.c (dwarf2_create_include_psymtab)
10697         (dwarf2_build_include_psymtabs, create_type_unit_group)
10698         (create_partial_symtab, process_psymtab_comp_unit_reader)
10699         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
10700         (set_partial_user): Use dwarf2_psymtab.
10701         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
10702         (psymtab_to_symtab_1, process_full_comp_unit)
10703         (process_full_type_unit, dwarf2_ranges_read)
10704         (dwarf2_get_pc_bounds, psymtab_include_file_name)
10705         (dwarf_decode_lines): Use dwarf2_psymtab.
10706         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
10707         (add_address_entry_worker, write_one_signatured_type)
10708         (recursively_count_psymbols, recursively_write_psymbols)
10709         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
10710         (write_debug_names): Likewise.
10711         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
10712         <pst>: Now a legacy_psymtab.
10713         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
10714         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
10715         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
10716         * ctfread.c (struct ctf_psymtab): New.
10717         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
10718         ctf_psymtab.
10719         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
10720         (create_partial_symtab): Return a ctf_psymtab.
10721         (scan_partial_symbols): Update.
10722
10723 2020-01-26  Tom Tromey  <tom@tromey.com>
10724
10725         * xcoffread.c (xcoff_start_psymtab): Use new.
10726         * psymtab.c (partial_symtab::partial_symtab): New constructor,
10727         renamed from start_psymtab_common.
10728         * psympriv.h (struct partial_symtab): Add new constructor.
10729         (start_psymtab_common): Don't declare.
10730         * mdebugread.c (parse_partial_symbols): Use new.
10731         * dwarf2read.c (create_partial_symtab): Use new.
10732         * dbxread.c (start_psymtab): Use new.
10733         * ctfread.c (create_partial_symtab): Use new.
10734
10735 2020-01-26  Tom Tromey  <tom@tromey.com>
10736
10737         * xcoffread.c (xcoff_end_psymtab): Use new.
10738         * psymtab.c (start_psymtab_common): Use new.
10739         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
10740         Update.
10741         * psympriv.h (struct partial_symtab): Add parameters to
10742         constructor.  Don't inline.
10743         (allocate_psymtab): Don't declare.
10744         * mdebugread.c (new_psymtab): Use new.
10745         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
10746         * dbxread.c (dbx_end_psymtab): Use new.
10747
10748 2020-01-26  Tom Tromey  <tom@tromey.com>
10749
10750         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
10751         allocate_psymtab.  Update documentation.
10752         * psymtab.c (psymtab_storage::install_psymtab): Rename from
10753         allocate_psymtab.  Do not use new.
10754         (allocate_psymtab): Use new.  Update.
10755
10756 2020-01-26  Tom Tromey  <tom@tromey.com>
10757
10758         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
10759         * psymtab.c (psym_print_stats): Update.
10760         * psympriv.h (struct partial_symtab) <readin,
10761         psymtabs_addrmap_supported, anonymous>: Now bool.
10762         * mdebugread.c (psymtab_to_symtab_1): Update.
10763         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
10764         (build_type_psymtabs_reader, psymtab_to_symtab_1)
10765         (process_full_comp_unit, process_full_type_unit): Update.
10766         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
10767         * ctfread.c (psymtab_to_symtab): Update.
10768
10769 2020-01-26  Tom Tromey  <tom@tromey.com>
10770
10771         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
10772         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
10773         * psymtab.c (psymtab_storage): Delete psymtabs.
10774         (psymtab_storage::allocate_psymtab): Use new.
10775         (psymtab_storage::discard_psymtab): Use delete.
10776         * psympriv.h (struct partial_symtab): Add constructor and
10777         initializers.
10778
10779 2020-01-26  Tom Tromey  <tom@tromey.com>
10780
10781         * machoread.c: Do not include psympriv.h.
10782
10783 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10784
10785         * NEWS: Mention the new option and the set/show commands.
10786
10787 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10788
10789         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
10790         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
10791         (validate_exec_file): New variables, enums, functions.
10792         (exec_file_locate_attach, print_section_info): Style the filenames.
10793         (_initialize_exec): Install show_exec_file_mismatch_command and
10794          set_exec_file_mismatch_command.
10795         * gdbcore.h (validate_exec_file): Declare.
10796         * infcmd.c (attach_command): Call validate_exec_file.
10797         * remote.c ( remote_target::remote_add_inferior): Likewise.
10798
10799 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10800
10801         * frame.c (find_frame_sal): Move call to get_next_frame into more
10802         inner scope.
10803         * inline-frame.c (inilne_state) <inline_state>: Update argument
10804         types.
10805         (inilne_state) <skipped_symbol>: Rename to...
10806         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
10807         (skip_inline_frames): Build vector of skipped symbols and use this
10808         to reate the inline_state.
10809         (inline_skipped_symbol): Add a comment and some assertions, fetch
10810         skipped symbol from the list.
10811
10812 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10813
10814         * buildsym.c (lte_is_less_than): Delete.
10815         (buildsym_compunit::end_symtab_with_blockvector): Create local
10816         lambda function to sort line table entries, and use
10817         std::stable_sort instead of std::sort.
10818         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
10819         markers when looking for a previous line.
10820
10821 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * dwarf2read.c (lnp_state_machine::record_line): Include
10824         end_sequence parameter in debug print out.  Record the line if we
10825         are at an end_sequence marker even if it's not the start of a
10826         statement.
10827         * symmisc.c (maintenance_print_one_line_table): Print end of
10828         sequence markers with 'END' not '0'.
10829
10830 2020-01-24  Pedro Alves  <palves@redhat.com>
10831
10832         PR gdb/25410
10833         * thread.c (scoped_restore_current_thread::restore): Use
10834         switch_to_inferior_no_thread.
10835         * exec.c: Include "progspace-and-thread.h".
10836         (add_target_sections, remove_target_sections):
10837         scoped_restore_current_pspace_and_thread instead of
10838         scoped_restore_current_thread.
10839         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
10840         and aspace to the inferior before calling clone_program_space.
10841         Remove stale comment.
10842
10843 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10844
10845         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
10846         (arm_netbsd_nat_target::fetch_registers): ...this.
10847         (arm_nbsd_nat_target::store_registers): Rename to...
10848         (arm_netbsd_nat_target::store_registers): ...this.
10849
10850 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10851
10852         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
10853         register_t.
10854
10855 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
10856
10857         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
10858         Update comment.
10859         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
10860         Likewise.
10861         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
10862         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
10863         the correct replacement (iterate_over_regset_sections).
10864         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
10865         Update comment.
10866
10867 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
10868
10869         PR gdb/23718
10870         * gdb/python/python.c (execute_gdb_command): Call
10871         async_enable_stdin in catch block.
10872
10873 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10874
10875         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
10876         SWITCH_THRU_ALL_UIS.
10877
10878 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
10879
10880         PR tui/9765
10881         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
10882         comment, add extra parameter, and update to store previous symbol
10883         when appropriate.
10884         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
10885         add extra parameter.
10886         * tui/tui-disasm.c (tui_disassemble): Update header comment,
10887         remove unneeded parameter, add try/catch around gdb_print_insn,
10888         rewrite to add items to asm_lines vector.
10889         (tui_find_backward_disassembly_start_address): New function.
10890         (tui_find_disassembly_address): Updated throughout.
10891         (tui_disasm_window::set_contents): Update for changes to
10892         tui_disassemble.
10893         (tui_disasm_window::do_scroll_vertical): No need to adjust the
10894         number of lines to scroll.
10895
10896 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
10897
10898         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
10899         (SECT_OFF_DATA): Likewise.
10900         (SECT_OFF_RODATA): Likewise.
10901         (SECT_OFF_TEXT): Likewise.
10902         (SECT_OFF_BSS): Likewise.
10903         (struct objfile) <text_section_offset, data_section_offset>: New
10904         methods.
10905         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
10906         objfile::text_section_offset.
10907         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
10908         * coffread.c (coff_symtab_read): Likewise.
10909         (enter_linenos): Likewise.
10910         (process_coff_symbol): Likewise.
10911         * ctfread.c (get_objfile_text_range): Likewise.
10912         * dtrace-probe.c (dtrace_probe::get_relocated_address):
10913         Use objfile::data_section_offset.
10914         * dwarf2-frame.c (execute_cfa_program): Use
10915         objfile::text_section_offset.
10916         (dwarf2_frame_find_fde): Likewise.
10917         * dwarf2read.c (create_addrmap_from_index): Likewise.
10918         (create_addrmap_from_aranges): Likewise.
10919         (dw2_find_pc_sect_compunit_symtab): Likewise.
10920         (process_psymtab_comp_unit_reader): Likewise.
10921         (add_partial_symbol): Likewise.
10922         (add_partial_subprogram): Likewise.
10923         (process_full_comp_unit): Likewise.
10924         (read_file_scope): Likewise.
10925         (read_func_scope): Likewise.
10926         (read_lexical_block_scope): Likewise.
10927         (read_call_site_scope): Likewise.
10928         (dwarf2_rnglists_process): Likewise.
10929         (dwarf2_ranges_process): Likewise.
10930         (dwarf2_ranges_read): Likewise.
10931         (dwarf_decode_lines_1): Likewise.
10932         (new_symbol): Likewise.
10933         (dwarf2_fetch_die_loc_sect_off): Likewise.
10934         (dwarf2_per_cu_text_offset): Likewise.
10935         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
10936         * hppa-tdep.c (read_unwind_info): Likewise.
10937         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
10938         * psympriv.h (struct partial_symtab): Likewise.
10939         * psymtab.c (find_pc_sect_psymtab): Likewise.
10940         * solib-svr4.c (enable_break): Likewise.
10941         * stap-probe.c (relocate_address): Use
10942         objfile::data_section_offset.
10943         * xcoffread.c (enter_line_range): Use
10944         objfile::text_section_offset.
10945         (read_xcoff_symtab): Likewise.
10946
10947 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10948
10949         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
10950         declaration to narrower scopes.
10951
10952 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
10953
10954         * darwin-nat.h (struct darwin_exception_msg, enum
10955         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
10956         Move up.
10957         (class darwin_nat_target) <wait_1, check_new_threads,
10958         decode_exception_message, decode_message, stop_inferior,
10959         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
10960         * darwin-nat.c (darwin_check_new_threads): Rename to...
10961         (darwin_nat_target::check_new_threads): ... this.
10962         (darwin_suspend_inferior_it): Remove.
10963         (darwin_decode_exception_message): Rename to...
10964         (darwin_nat_target::decode_exception_message): ... this.
10965         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
10966         (darwin_decode_message): Rename to...
10967         (darwin_nat_target::decode_message): ... this.
10968         (cancel_breakpoint): Rename to...
10969         (darwin_nat_target::cancel_breakpoint): ... this.
10970         (darwin_wait): Rename to...
10971         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
10972         instead of iterate_over_inferiors.
10973         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
10974         (darwin_stop_inferior): Rename to...
10975         (darwin_nat_target::stop_inferior): ... this.
10976         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
10977         (darwin_init_thread_list): Rename to...
10978         (darwin_nat_target::init_thread_list): ... this.
10979         (darwin_ptrace_him): Rename to...
10980         (darwin_nat_target::ptrace_him): ... this.
10981         (darwin_nat_target::create_inferior): Pass lambda function to
10982         fork_inferior.
10983         (darwin_nat_target::detach): Call stop_inferior instead of
10984         darwin_stop_inferior.
10985         * fork-inferior.h (fork_inferior): Change init_trace_fun
10986         parameter to gdb::function_view.
10987         * fork-inferior.c (fork_inferior): Likewise.
10988
10989 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
10990
10991         * i386-cygwin-tdep.c (core_process_module_section): Update.
10992         * windows-nat.c (struct lm_info_windows): Add text_offset.
10993         (windows_xfer_shared_libraries): Update.
10994         * windows-tdep.c (windows_xfer_shared_library):
10995         Add text_offset_cached argument.
10996         * windows-tdep.h (windows_xfer_shared_library): Update.
10997
10998 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
10999
11000         * gdbarch.sh: Add declaration for _initialize_gdbarch.
11001
11002 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
11003
11004         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
11005         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
11006         replace with range-based for.
11007         (gdbsim_interrupt_inferior): Remove.
11008         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
11009         with a range-based for.  Inline code from
11010         gdbsim_interrupt_inferior.
11011
11012 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
11013
11014         * infrun.c (proceed): Fix indentation.
11015
11016 2020-01-21  Tom Tromey  <tromey@adacore.com>
11017
11018         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
11019         * python/python.c (python_extension_ops): Update.
11020         (gdbpy_colorize): New function.
11021         * python/lib/gdb/__init__.py (colorize): New function.
11022         * extension.h (ext_lang_colorize): Declare.
11023         * extension.c (ext_lang_colorize): New function.
11024         * extension-priv.h (struct extension_language_ops) <colorize>: New
11025         member.
11026         * cli/cli-style.c (_initialize_cli_style): Update help text.
11027
11028 2020-01-21  Luis Machado  <luis.machado@linaro.org>
11029
11030         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
11031         <cond>: Change type to bool.
11032         (aarch64_displaced_step_b_cond): Update cond to use bool type.
11033         (aarch64_displaced_step_cb): Likewise.
11034         (aarch64_displaced_step_tb): Likewise.
11035
11036 2020-01-21  Luis Machado  <luis.machado@linaro.org>
11037
11038         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
11039         output.
11040
11041 2020-01-21  Luis Machado  <luis.machado@linaro.org>
11042
11043         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
11044         <pc_adjust>: Adjust the documentation.
11045         (aarch64_displaced_step_fixup): Check if PC really moved before
11046         adjusting it.
11047
11048 2020-01-19  Tom Tromey  <tom@tromey.com>
11049
11050         * disasm.c (~gdb_disassembler): New destructor.
11051         (gdb_buffered_insn_length): Call disassemble_free_target.
11052         * disasm.h (class gdb_disassembler): Declare destructor.  Use
11053         DISABLE_COPY_AND_ASSIGN.
11054
11055 2020-01-19  Tom Tromey  <tom@tromey.com>
11056
11057         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
11058         (die_reader_func_ftype): Remove.
11059         (cutu_reader): New class.
11060         (dw2_get_file_names_reader): Remove "data" parameter.
11061         (dw2_get_file_names): Use cutu_reader.
11062         (create_debug_type_hash_table): Update.
11063         (read_cutu_die_from_dwo): Update comment.
11064         (lookup_dwo_unit): Add dwo_name parameter.
11065         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
11066         die_reader_func_ftype and data parameters.
11067         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
11068         Remove die_reader_func_ftype and data parameters.
11069         (~cutu_reader): New; from init_cutu_and_read_dies.
11070         (cutu_reader::cutu_reader): Rename from
11071         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
11072         and data parameters.
11073         (init_cutu_and_read_dies_simple): Remove.
11074         (struct process_psymtab_comp_unit_data): Remove.
11075         (process_psymtab_comp_unit_reader): Remove data parameter; add
11076         want_partial_unit and pretend_language parameters.
11077         (process_psymtab_comp_unit): Use cutu_reader.
11078         (build_type_psymtabs_reader): Remove data parameter.
11079         (build_type_psymtabs_1): Use cutu_reader.
11080         (process_skeletonless_type_unit): Likewise.
11081         (load_partial_comp_unit_reader): Remove.
11082         (load_partial_comp_unit): Use cutu_reader.
11083         (load_full_comp_unit_reader): Remove.
11084         (load_full_comp_unit): Use cutu_reader.
11085         (struct create_dwo_cu_data): Remove.
11086         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
11087         dwo_unit parameters.
11088         (create_cus_hash_table): Use cutu_reader.
11089         (struct dwarf2_read_addr_index_data): Remove.
11090         (dwarf2_read_addr_index_reader): Remove.
11091         (dwarf2_read_addr_index): Use cutu_reader.
11092         (read_signatured_type_reader): Remove.
11093         (read_signatured_type): Use cutu_reader.
11094
11095 2020-01-19  Tom Tromey  <tom@tromey.com>
11096
11097         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
11098         * tui/tui-wingeneral.h (class tui_suppress_output): New.
11099         (tui_wrefresh): Declare.
11100         * tui/tui-wingeneral.c (suppress_output): New global.
11101         (tui_suppress_output, ~tui_suppress_output): New constructor and
11102         destructor.
11103         (tui_wrefresh): New function.
11104         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
11105         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
11106         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
11107         method.
11108         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
11109         tui_wrefresh.
11110         (tui_data_window::no_refresh): New method.
11111         (tui_data_item_window::refresh_window): Call tui_wrefresh.
11112         (tui_reg_command): Use tui_suppress_output
11113         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
11114         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
11115         method.
11116         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
11117
11118 2020-01-19  Tom Tromey  <tom@tromey.com>
11119
11120         * tui/tui-winsource.c (tui_update_source_windows_with_line):
11121         Handle case where symtab is null.
11122
11123 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
11124
11125         * linux-fork.c (one_fork_p): Simplify.
11126
11127 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
11128
11129         * top.c (struct qt_args): Remove.
11130         (kill_or_detach): Change return type to void, replace `void *`
11131         parameter with a proper one.
11132         (print_inferior_quit_action):  Likewise.
11133         (quit_confirm): Use range-based for loop to iterate over inferiors.
11134         (quit_force): Likewise.
11135
11136 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
11137
11138         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
11139         `void *` parameter with proper parameters.
11140         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
11141         (print_one_inferior): Change return type to void, replace `void *`
11142         parameter with proper parameters.
11143         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
11144         inferiors.
11145         (get_other_inferior): Remove.
11146         (mi_cmd_remove_inferior): Use range-based loop to iterate over
11147         inferiors.
11148
11149 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
11150
11151         * mi/mi-interp.c (report_initial_inferior): Remove.
11152         (mi_interp::init): Use range-based for to iterate over inferiors.
11153
11154 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
11155
11156         * python/py-inferior.c (build_inferior_list): Remove.
11157         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
11158
11159 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
11160
11161         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
11162         (btrace_stitch_trace): Likewise.
11163         * charset.c (intermediate_encoding): Likewise (vaild).
11164         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
11165         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
11166         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
11167
11168 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
11169
11170         * windows-tdep.c (windows_get_tlb_type):
11171         Add rtl_user_process_parameters type.
11172
11173 2020-01-16  Pedro Alves  <palves@redhat.com>
11174             Norbert Lange  <nolange79@gmail.com>
11175
11176         PR build/24805
11177         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
11178         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
11179         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
11180         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
11181         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
11182         (ps_plog): Redeclare exported functions with default visibility.
11183
11184 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
11185
11186         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
11187         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
11188
11189 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
11190
11191         * infcmd.c (post_create_inferior): Use get_thread_regcache
11192         instead of get_current_regcache.
11193
11194 2020-01-14  Tom Tromey  <tom@tromey.com>
11195
11196         PR symtab/12535:
11197         * python/python.c (gdbpy_decode_line): Treat empty string the same
11198         as no argument.
11199
11200 2020-01-14  Tom Tromey  <tom@tromey.com>
11201
11202         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
11203
11204 2020-01-14  Tom Tromey  <tom@tromey.com>
11205
11206         * nat/linux-btrace.c: Don't include <config.h>.
11207         * nat/linux-ptrace.c: Don't include <config.h>.
11208         * nat/x86-linux-dregs.c: Don't include <config.h>.
11209
11210 2020-01-14  Tom Tromey  <tom@tromey.com>
11211
11212         * configure: Rebuild.
11213         * configure.ac: Move many checks to ../gdbsupport/common.m4.
11214
11215 2020-01-14  Tom Tromey  <tom@tromey.com>
11216
11217         * nat/x86-linux-dregs.c: Include configh.h.
11218         * nat/linux-ptrace.c: Include configh.h.
11219         * nat/linux-btrace.c: Include configh.h.
11220         * defs.h: Include config.h, bfd.h.
11221         * configure.ac: Don't source common.host.
11222         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
11223         * configure: Rebuild.
11224         * acinclude.m4: Update path.
11225         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
11226         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
11227         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
11228         (CLIBS): Add LIBSUPPORT.
11229         (CDEPS): Likewise.
11230         (COMMON_SFILES): Remove gdbsupport files.
11231         (HFILES_NO_SRCDIR): Likewise.
11232         (stamp-version): Update path to create-version.sh.
11233         (ALLDEPFILES): Remove gdbsupport files.
11234
11235 2020-01-14  Tom Tromey  <tom@tromey.com>
11236
11237         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
11238         USE_WIN32API when needed.
11239         * configure.ac (USE_WIN32API): Don't define.
11240         (WIN32LIBS): Use WIN32APILIBS.
11241         * configure: Rebuild.
11242
11243 2020-01-14  Tom Tromey  <tom@tromey.com>
11244
11245         * configure: Rebuild.
11246         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
11247
11248 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
11249
11250         * skip.c (skip_function_command): Make skip w/o arguments use the
11251         name of the inlined function if pc is inside any inlined function.
11252
11253 2020-01-14  Luis Machado  <luis.machado@linaro.org>
11254
11255         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
11256         * infrun.c (resume_1): Likewise.
11257         (handle_inferior_event): Remove stale comment.
11258         * linux-nat.c (linux_nat_target::resume): Update comments.
11259         (save_stop_reason): Likewise.
11260         (linux_nat_filter_event): Likewise.
11261         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
11262
11263 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11264
11265         * elfread.c (record_minimal_symbol): Set section index to 0 for
11266         non-allocatable sections.
11267
11268
11269 2020-01-13  Ali Tamur <tamur@google.com>
11270
11271         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
11272         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
11273         to gdb::optional.  Update comments.
11274         (dwo_file): Update comments.
11275         (read_attribute): Update API to take an additional out parameter,
11276         need_reprocess.  This is used to mark attributes that need other
11277         attributes (e.g. str_offsets_base) for correct computation which may not
11278         have been read yet.
11279         (read_attribute_reprocess): New function declaration.
11280         (read_addr_index): Likewise.
11281         (read_dwo_str_index): Likewise.
11282         (read_stub_str_index): Likewise.
11283         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
11284         (lookup_addr_base): New function definition.
11285         (lookup_ranges_base): Likewise.
11286         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
11287         lookup_ranges_base.
11288         (init_cutu_and_read_dies): Update comments.
11289         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
11290         unit.  This is used to inherit parent's str_offsets_base and addr_base.
11291         Update comments.
11292         (init_cutu_and_read_dies_simple): Reflect API changes.
11293         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
11294         (create_cus_hash_table): Change API to take parent compile unit.
11295         Reflect API changes.
11296         (open_and_init_dwo_file): Reflect API changes.
11297         (dwarf2_get_pc_bounds): Update comments.
11298         (dwarf2_record_block_ranges): Likewise.
11299         (read_full_die_1): Change implementation to reprocess attributes that
11300         need str_offsets_base and addr_base.
11301         (partial_die_info::read): Likewise.
11302         (read_attribute_reprocess): New function definition.
11303         (read_attribute_value): Change API to take an additional out parameter,
11304         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
11305         when a non-dwo compile unit has index based attributes.
11306         (read_attribute): Reflect API changes.
11307         (read_addr_index_1): Reflect API changes.  Update comments.
11308         (dwarf2_read_addr_index_data): Reflect API changes.
11309         (dwarf2_read_addr_index): Likewise.
11310         (read_str_index): Change API and implementation.  This becomes a helper
11311         to be used by the new string index related methods.  Update error
11312         message and comments.
11313         (read_dwo_str_index): New function definition.
11314         (read_stub_str_index): Likewise.
11315         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
11316         * symfile.h (dwarf2_debug_sections): Likewise.
11317         * xcoffread.c (dwarf2_debug_sections): Likewise.
11318
11319 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11320
11321         * gdbcore.h (struct core_fns) <core_read_registers>: Change
11322         core_reg_sect type to gdb_byte *.
11323         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
11324         * cris-tdep.c (fetch_core_registers): Likewise.
11325         * corelow.c (core_target::get_core_register_section): Change
11326         type of `contents` to gdb::byte_vector.
11327
11328 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11329
11330         * tui/tui-wingeneral.c (box_win): Position the title in the center
11331         of the border.
11332
11333 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11334
11335         * corelow.c (core_target::get_core_register_section): Use
11336           std::vector instead of alloca.
11337
11338 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11339
11340         * warning.m4: Add -Wmissing-declarations to build_warnings.
11341         * configure: Re-generate.
11342
11343 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11344
11345         * python/python.c (init__gdb_module): Add declaration.
11346
11347 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
11348
11349         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
11350         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
11351         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
11352         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
11353         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
11354         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
11355         * ada-exp.y (_initialize_ada_exp): Add declaration.
11356         * ada-lang.c (_initialize_ada_language): Add declaration.
11357         * ada-tasks.c (_initialize_tasks): Add declaration.
11358         * agent.c (_initialize_agent): Add declaration.
11359         * aix-thread.c (_initialize_aix_thread): Add declaration.
11360         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
11361         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
11362         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
11363         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
11364         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
11365         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
11366         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
11367         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
11368         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
11369         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
11370         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
11371         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
11372         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
11373         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
11374         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
11375         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
11376         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
11377         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
11378         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
11379         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
11380         * annotate.c (_initialize_annotate): Add declaration.
11381         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
11382         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
11383         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
11384         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
11385         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
11386         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
11387         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
11388         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
11389         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
11390         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
11391         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
11392         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
11393         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
11394         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
11395         * auto-load.c (_initialize_auto_load): Add declaration.
11396         * auxv.c (_initialize_auxv): Add declaration.
11397         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
11398         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
11399         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
11400         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
11401         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
11402         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
11403         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
11404         * breakpoint.c (_initialize_breakpoint): Add declaration.
11405         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
11406         * btrace.c (_initialize_btrace): Add declaration.
11407         * charset.c (_initialize_charset): Add declaration.
11408         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
11409         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
11410         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
11411         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
11412         * cli/cli-script.c (_initialize_cli_script): Add declaration.
11413         * cli/cli-style.c (_initialize_cli_style): Add declaration.
11414         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
11415         * coffread.c (_initialize_coffread): Add declaration.
11416         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
11417         * compile/compile.c (_initialize_compile): Add declaration.
11418         * complaints.c (_initialize_complaints): Add declaration.
11419         * completer.c (_initialize_completer): Add declaration.
11420         * copying.c (_initialize_copying): Add declaration.
11421         * corefile.c (_initialize_core): Add declaration.
11422         * corelow.c (_initialize_corelow): Add declaration.
11423         * cp-abi.c (_initialize_cp_abi): Add declaration.
11424         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
11425         * cp-support.c (_initialize_cp_support): Add declaration.
11426         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
11427         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
11428         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
11429         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
11430         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
11431         * ctfread.c (_initialize_ctfread): Add declaration.
11432         * d-lang.c (_initialize_d_language): Add declaration.
11433         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
11434         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
11435         * dbxread.c (_initialize_dbxread): Add declaration.
11436         * dcache.c (_initialize_dcache): Add declaration.
11437         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
11438         * disasm.c (_initialize_disasm): Add declaration.
11439         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
11440         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
11441         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
11442         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
11443         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
11444         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
11445         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
11446         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
11447         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
11448         * elfread.c (_initialize_elfread): Add declaration.
11449         * exec.c (_initialize_exec): Add declaration.
11450         * extension.c (_initialize_extension): Add declaration.
11451         * f-lang.c (_initialize_f_language): Add declaration.
11452         * f-valprint.c (_initialize_f_valprint): Add declaration.
11453         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
11454         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
11455         * filesystem.c (_initialize_filesystem): Add declaration.
11456         * findcmd.c (_initialize_mem_search): Add declaration.
11457         * findvar.c (_initialize_findvar): Add declaration.
11458         * fork-child.c (_initialize_fork_child): Add declaration.
11459         * frame-base.c (_initialize_frame_base): Add declaration.
11460         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
11461         * frame.c (_initialize_frame): Add declaration.
11462         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
11463         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
11464         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
11465         * gcore.c (_initialize_gcore): Add declaration.
11466         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
11467         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
11468         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
11469         * gdbarch.c (_initialize_gdbarch): Add declaration.
11470         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
11471         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
11472         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
11473         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
11474         * go-lang.c (_initialize_go_language): Add declaration.
11475         * go32-nat.c (_initialize_go32_nat): Add declaration.
11476         * guile/guile.c (_initialize_guile): Add declaration.
11477         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
11478         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
11479         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
11480         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
11481         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
11482         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
11483         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
11484         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
11485         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
11486         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
11487         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
11488         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
11489         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
11490         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
11491         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
11492         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
11493         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
11494         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
11495         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
11496         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
11497         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
11498         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
11499         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
11500         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
11501         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
11502         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
11503         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
11504         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
11505         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
11506         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
11507         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
11508         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
11509         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
11510         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
11511         * infcall.c (_initialize_infcall): Add declaration.
11512         * infcmd.c (_initialize_infcmd): Add declaration.
11513         * inflow.c (_initialize_inflow): Add declaration.
11514         * infrun.c (_initialize_infrun): Add declaration.
11515         * interps.c (_initialize_interpreter): Add declaration.
11516         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
11517         * jit.c (_initialize_jit): Add declaration.
11518         * language.c (_initialize_language): Add declaration.
11519         * linux-fork.c (_initialize_linux_fork): Add declaration.
11520         * linux-nat.c (_initialize_linux_nat): Add declaration.
11521         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
11522         * linux-thread-db.c (_initialize_thread_db): Add declaration.
11523         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
11524         * m2-lang.c (_initialize_m2_language): Add declaration.
11525         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
11526         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
11527         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
11528         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
11529         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
11530         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
11531         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
11532         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
11533         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
11534         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
11535         * machoread.c (_initialize_machoread): Add declaration.
11536         * macrocmd.c (_initialize_macrocmd): Add declaration.
11537         * macroscope.c (_initialize_macroscope): Add declaration.
11538         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
11539         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
11540         * maint.c (_initialize_maint_cmds): Add declaration.
11541         * mdebugread.c (_initialize_mdebugread): Add declaration.
11542         * memattr.c (_initialize_mem): Add declaration.
11543         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
11544         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
11545         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
11546         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
11547         * mi/mi-main.c (_initialize_mi_main): Add declaration.
11548         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
11549         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
11550         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
11551         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
11552         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
11553         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
11554         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
11555         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
11556         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
11557         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
11558         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
11559         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
11560         * mipsread.c (_initialize_mipsread): Add declaration.
11561         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
11562         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
11563         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
11564         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
11565         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
11566         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
11567         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
11568         * nto-procfs.c (_initialize_procfs): Add declaration.
11569         * objc-lang.c (_initialize_objc_language): Add declaration.
11570         * observable.c (_initialize_observer): Add declaration.
11571         * opencl-lang.c (_initialize_opencl_language): Add declaration.
11572         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
11573         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
11574         * osabi.c (_initialize_gdb_osabi): Add declaration.
11575         * osdata.c (_initialize_osdata): Add declaration.
11576         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
11577         * parse.c (_initialize_parse): Add declaration.
11578         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
11579         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
11580         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
11581         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
11582         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
11583         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
11584         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
11585         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
11586         * printcmd.c (_initialize_printcmd): Add declaration.
11587         * probe.c (_initialize_probe): Add declaration.
11588         * proc-api.c (_initialize_proc_api): Add declaration.
11589         * proc-events.c (_initialize_proc_events): Add declaration.
11590         * proc-service.c (_initialize_proc_service): Add declaration.
11591         * procfs.c (_initialize_procfs): Add declaration.
11592         * producer.c (_initialize_producer): Add declaration.
11593         * psymtab.c (_initialize_psymtab): Add declaration.
11594         * python/python.c (_initialize_python): Add declaration.
11595         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
11596         * record-btrace.c (_initialize_record_btrace): Add declaration.
11597         * record-full.c (_initialize_record_full): Add declaration.
11598         * record.c (_initialize_record): Add declaration.
11599         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
11600         * regcache.c (_initialize_regcache): Add declaration.
11601         * reggroups.c (_initialize_reggroup): Add declaration.
11602         * remote-notif.c (_initialize_notif): Add declaration.
11603         * remote-sim.c (_initialize_remote_sim): Add declaration.
11604         * remote.c (_initialize_remote): Add declaration.
11605         * reverse.c (_initialize_reverse): Add declaration.
11606         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
11607         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
11608         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
11609         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
11610         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
11611         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
11612         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
11613         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
11614         Add declaration.
11615         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
11616         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
11617         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
11618         * rust-exp.y (_initialize_rust_exp): Add declaration.
11619         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
11620         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
11621         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
11622         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
11623         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
11624         * score-tdep.c (_initialize_score_tdep): Add declaration.
11625         * ser-go32.c (_initialize_ser_dos): Add declaration.
11626         * ser-mingw.c (_initialize_ser_windows): Add declaration.
11627         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
11628         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
11629         * ser-uds.c (_initialize_ser_socket): Add declaration.
11630         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
11631         * serial.c (_initialize_serial): Add declaration.
11632         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
11633         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
11634         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
11635         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
11636         * skip.c (_initialize_step_skip): Add declaration.
11637         * sol-thread.c (_initialize_sol_thread): Add declaration.
11638         * solib-aix.c (_initialize_solib_aix): Add declaration.
11639         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
11640         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
11641         * solib-frv.c (_initialize_frv_solib): Add declaration.
11642         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
11643         * solib-target.c (_initialize_solib_target): Add declaration.
11644         * solib.c (_initialize_solib): Add declaration.
11645         * source-cache.c (_initialize_source_cache): Add declaration.
11646         * source.c (_initialize_source): Add declaration.
11647         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
11648         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
11649         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
11650         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
11651         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
11652         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
11653         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
11654         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
11655         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
11656         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
11657         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
11658         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
11659         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
11660         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
11661         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
11662         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
11663         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
11664         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
11665         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
11666         * stabsread.c (_initialize_stabsread): Add declaration.
11667         * stack.c (_initialize_stack): Add declaration.
11668         * stap-probe.c (_initialize_stap_probe): Add declaration.
11669         * std-regs.c (_initialize_frame_reg): Add declaration.
11670         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
11671         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
11672         * symfile.c (_initialize_symfile): Add declaration.
11673         * symmisc.c (_initialize_symmisc): Add declaration.
11674         * symtab.c (_initialize_symtab): Add declaration.
11675         * target.c (_initialize_target): Add declaration.
11676         * target-connection.c (_initialize_target_connection): Add
11677         declaration.
11678         * target-dcache.c (_initialize_target_dcache): Add declaration.
11679         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
11680         * thread.c (_initialize_thread): Add declaration.
11681         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
11682         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
11683         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
11684         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
11685         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
11686         * tracectf.c (_initialize_ctf): Add declaration.
11687         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
11688         * tracefile.c (_initialize_tracefile): Add declaration.
11689         * tracepoint.c (_initialize_tracepoint): Add declaration.
11690         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
11691         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
11692         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
11693         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
11694         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
11695         * tui/tui-win.c (_initialize_tui_win): Add declaration.
11696         * tui/tui.c (_initialize_tui): Add declaration.
11697         * typeprint.c (_initialize_typeprint): Add declaration.
11698         * ui-style.c (_initialize_ui_style): Add declaration.
11699         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
11700         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
11701         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
11702         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
11703         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
11704         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
11705         * unittests/filtered_iterator-selftests.c
11706         (_initialize_filtered_iterator_selftests): Add declaration.
11707         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
11708         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
11709         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
11710         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
11711         * unittests/main-thread-selftests.c
11712         (_initialize_main_thread_selftests): Add declaration.
11713         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
11714         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
11715         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
11716         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
11717         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
11718         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
11719         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
11720         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
11721         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
11722         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
11723         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
11724         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
11725         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
11726         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
11727         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
11728         declaration.
11729         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
11730         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
11731         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
11732         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
11733         * user-regs.c (_initialize_user_regs): Add declaration.
11734         * utils.c (_initialize_utils): Add declaration.
11735         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
11736         * valops.c (_initialize_valops): Add declaration.
11737         * valprint.c (_initialize_valprint): Add declaration.
11738         * value.c (_initialize_values): Add declaration.
11739         * varobj.c (_initialize_varobj): Add declaration.
11740         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
11741         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
11742         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
11743         * windows-nat.c (_initialize_windows_nat): Add declaration.
11744         (_initialize_check_for_gdb_ini): Add declaration.
11745         (_initialize_loadable): Add declaration.
11746         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
11747         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
11748         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
11749         * xcoffread.c (_initialize_xcoffread): Add declaration.
11750         * xml-support.c (_initialize_xml_support): Add declaration.
11751         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
11752         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
11753         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
11754         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
11755
11756 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11757
11758         * regformats/regdat.sh: Generate declaration for init function.
11759
11760 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
11761
11762         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
11763         up.
11764         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
11765         close_one_inferior>: New methods.
11766         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
11767         pass down target to find_inferior_pid.
11768         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
11769         Pass down target to find_inferior_ptid.
11770         (gdbsim_target::create_inferior): Pass down target to
11771         add_thread_silent.
11772         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
11773         target down to find_inferior_ptid and switch_to_thread.
11774         (gdbsim_target::close): Update to call close_one_inferior.
11775         (struct resume_data): Remove.
11776         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
11777         directly, rather than through a void pointer.
11778         (gdbsim_target::resume): Update to call resume_one_inferior.
11779
11780 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
11781
11782         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
11783
11784 2020-01-12  Pedro Alves  <palves@redhat.com>
11785
11786         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
11787         directly for the current inferior instead of
11788         discard_all_inferiors.
11789         (discard_all_inferiors): Delete.
11790
11791 2020-01-11  Tom Tromey  <tom@tromey.com>
11792
11793         * tui/tui-wingeneral.c (box_win): Check cli_styling.
11794         * tui/tui-winsource.c (tui_source_window_base::refill): Use
11795         deprecated_safe_get_selected_frame.
11796
11797 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
11798
11799         * inferior.c (print_inferior): Switch inferior before printing it.
11800
11801 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
11802             Pedro Alves  <palves@redhat.com>
11803
11804         * progspace-and-thread.c (switch_to_program_space_and_thread):
11805         Assert there's an inferior for PSPACE.  Use
11806         switch_to_inferior_no_thread to switch the inferior too.
11807         * progspace.c (program_space::~program_space): Call
11808         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
11809         (program_space::free_all_objfiles): Don't call clear_symtab_users
11810         here.
11811         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
11812
11813 2020-01-10  Pedro Alves  <palves@redhat.com>
11814
11815         * NEWS: Mention multi-target debugging, "info connections", and
11816         "add-inferior -no-connection".
11817
11818 2020-01-10  Pedro Alves  <palves@redhat.com>
11819
11820         * infrun.c: Include "target-connection.h".
11821         (check_multi_target_resumption): New.
11822         (proceed): Call it.
11823         * target-connection.c (make_target_connection_string): Make
11824         extern.
11825         * target-connection.h (make_target_connection_string): Declare.
11826
11827 2020-01-10  Pedro Alves  <palves@redhat.com>
11828
11829         * Makefile.in (COMMON_SFILES): Add target-connection.c.
11830         * inferior.c (uiout_field_connection): New function.
11831         (print_inferior): Add new "connection-id" column.
11832         (add_inferior_command): Show connection number/string of added
11833         inferior.
11834         * process-stratum-target.h
11835         (process_stratum_target::connection_string): New virtual method.
11836         (process_stratum_target::connection_number): New field.
11837         * remote.c (remote_target::connection_string): New override.
11838         * target-connection.c: New file.
11839         * target-connection.h: New file.
11840         * target.c (decref_target): Remove process_stratum targets from
11841         the connection list.
11842         (target_stack::push): Add process_stratum targets to the
11843         connection list.
11844
11845 2020-01-10  Pedro Alves  <palves@redhat.com>
11846
11847         Revert:
11848         2016-04-12  Pedro Alves  <palves@redhat.com>
11849         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
11850         Remove references to name.
11851         * serial.h (struct serial) <name>: Delete.
11852
11853 2020-01-10  Pedro Alves  <palves@redhat.com>
11854
11855         * gdbarch-selftests.c (register_to_value_test): Remove "target
11856         already pushed" check.
11857
11858 2020-01-10  Pedro Alves  <palves@redhat.com>
11859             John Baldwin  <jhb@FreeBSD.org>
11860
11861         * aarch64-linux-nat.c
11862         (aarch64_linux_nat_target::thread_architecture): Adjust.
11863         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
11864         (task_command_1): Likewise.
11865         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
11866         (aix_thread_target::wait, aix_thread_target::fetch_registers)
11867         (aix_thread_target::store_registers)
11868         (aix_thread_target::thread_alive): Adjust.
11869         * amd64-fbsd-tdep.c: Include "inferior.h".
11870         (amd64fbsd_get_thread_local_address): Pass down target.
11871         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
11872         thread's gdbarch instead of target_gdbarch.
11873         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
11874         get_last_target_status.
11875         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
11876         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
11877         inferiors.
11878         (update_inserted_breakpoint_locations): Skip if inferiors with no
11879         execution.
11880         (update_global_location_list): When handling moribund locations,
11881         find representative inferior for location's pspace, and use thread
11882         count of its process_stratum target.
11883         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
11884         * bsd-uthread.c (bsd_uthread_target::wait): Use
11885         as_process_stratum_target and adjust thread_change_ptid and
11886         add_thread calls.
11887         (bsd_uthread_target::update_thread_list): Use
11888         as_process_stratum_target and adjust find_thread_ptid,
11889         thread_change_ptid and add_thread calls.
11890         * btrace.c (maint_btrace_packet_history_cmd): Adjust
11891         find_thread_ptid call.
11892         * corelow.c (add_to_thread_list): Adjust add_thread call.
11893         (core_target_open): Adjust add_thread_silent and thread_count
11894         calls.
11895         (core_target::pid_to_str): Adjust find_inferior_ptid call.
11896         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
11897         * event-top.c (async_disconnect): Pop targets from all inferiors.
11898         * exec.c (add_target_sections): Push exec target on all inferiors
11899         sharing the program space.
11900         (remove_target_sections): Remove the exec target from all
11901         inferiors sharing the program space.
11902         (exec_on_vfork): New.
11903         * exec.h (exec_on_vfork): Declare.
11904         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
11905         Pass it down.
11906         (fbsd_nat_target::update_thread_list): Adjust.
11907         (fbsd_nat_target::resume): Adjust.
11908         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
11909         down.
11910         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
11911         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
11912         get_thread_arch_regcache call.
11913         * fork-child.c (gdb_startup_inferior): Pass target down to
11914         startup_inferior and set_executing.
11915         * gdbthread.h (struct process_stratum_target): Forward declare.
11916         (add_thread, add_thread_silent, add_thread_with_info)
11917         (in_thread_list): Add process_stratum_target parameter.
11918         (find_thread_ptid(inferior*, ptid_t)): New overload.
11919         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
11920         parameter.
11921         (all_threads()): Delete overload.
11922         (all_threads, all_non_exited_threads): Add process_stratum_target
11923         parameter.
11924         (all_threads_safe): Use brace initialization.
11925         (thread_count): Add process_stratum_target parameter.
11926         (set_resumed, set_running, set_stop_requested, set_executing)
11927         (threads_are_executing, finish_thread_state): Add
11928         process_stratum_target parameter.
11929         (switch_to_thread): Use is_current_thread.
11930         * i386-fbsd-tdep.c: Include "inferior.h".
11931         (i386fbsd_get_thread_local_address): Pass down target.
11932         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
11933         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
11934         have_inferiors check.
11935         * inf-ptrace.c (inf_ptrace_target::create_inferior)
11936         (inf_ptrace_target::attach): Adjust.
11937         * infcall.c (run_inferior_call): Adjust.
11938         * infcmd.c (run_command_1): Pass target to
11939         scoped_finish_thread_state.
11940         (proceed_thread_callback): Skip inferiors with no execution.
11941         (continue_command): Rename 'all_threads' local to avoid hiding
11942         'all_threads' function.  Adjust get_last_target_status call.
11943         (prepare_one_step): Adjust set_running call.
11944         (signal_command): Use user_visible_resume_target.  Compare thread
11945         pointers instead of inferior_ptid.
11946         (info_program_command): Adjust to pass down target.
11947         (attach_command): Mark target's 'thread_executing' flag.
11948         (stop_current_target_threads_ns): New, factored out from ...
11949         (interrupt_target_1): ... this.  Switch inferior before making
11950         target calls.
11951         * inferior-iter.h
11952         (struct all_inferiors_iterator, struct all_inferiors_range)
11953         (struct all_inferiors_safe_range)
11954         (struct all_non_exited_inferiors_range): Filter on
11955         process_stratum_target too.  Remove explicit.
11956         * inferior.c (inferior::inferior): Push dummy target on target
11957         stack.
11958         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
11959         Add process_stratum_target parameter, and pass it down.
11960         (have_live_inferiors): Adjust.
11961         (switch_to_inferior_and_push_target): New.
11962         (add_inferior_command, clone_inferior_command): Handle
11963         "-no-connection" parameter.  Use
11964         switch_to_inferior_and_push_target.
11965         (_initialize_inferior): Mention "-no-connection" option in
11966         the help of "add-inferior" and "clone-inferior" commands.
11967         * inferior.h: Include "process-stratum-target.h".
11968         (interrupt_target_1): Use bool.
11969         (struct inferior) <push_target, unpush_target, target_is_pushed,
11970         find_target_beneath, top_target, process_target, target_at,
11971         m_stack>: New.
11972         (discard_all_inferiors): Delete.
11973         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
11974         (all_inferiors, all_non_exited_inferiors): Add
11975         process_stratum_target parameter.
11976         * infrun.c: Include "gdb_select.h" and <unordered_map>.
11977         (target_last_proc_target): New global.
11978         (follow_fork_inferior): Push target on new inferior.  Pass target
11979         to add_thread_silent.  Call exec_on_vfork.  Handle target's
11980         reference count.
11981         (follow_fork): Adjust get_last_target_status call.  Also consider
11982         target.
11983         (follow_exec): Push target on new inferior.
11984         (struct execution_control_state) <target>: New field.
11985         (user_visible_resume_target): New.
11986         (do_target_resume): Call target_async.
11987         (resume_1): Set target's threads_executing flag.  Consider resume
11988         target.
11989         (commit_resume_all_targets): New.
11990         (proceed): Also consider resume target.  Skip threads of inferiors
11991         with no execution.  Commit resumtion in all targets.
11992         (start_remote): Pass current inferior to wait_for_inferior.
11993         (infrun_thread_stop_requested): Consider target as well.  Pass
11994         thread_info pointer to clear_inline_frame_state instead of ptid.
11995         (infrun_thread_thread_exit): Consider target as well.
11996         (random_pending_event_thread): New inferior parameter.  Use it.
11997         (do_target_wait): Rename to ...
11998         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
11999         down.
12000         (threads_are_resumed_pending_p, do_target_wait): New.
12001         (prepare_for_detach): Adjust calls.
12002         (wait_for_inferior): New inferior parameter.  Handle it.  Use
12003         do_target_wait_1 instead of do_target_wait.
12004         (fetch_inferior_event): Adjust.  Switch to representative
12005         inferior.  Pass target down.
12006         (set_last_target_status): Add process_stratum_target parameter.
12007         Save target in global.
12008         (get_last_target_status): Add process_stratum_target parameter and
12009         handle it.
12010         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
12011         (context_switch): Check inferior_ptid == null_ptid before calling
12012         inferior_thread().
12013         (get_inferior_stop_soon): Pass down target.
12014         (wait_one): Rename to ...
12015         (poll_one_curr_target): ... this.
12016         (struct wait_one_event): New.
12017         (wait_one): New.
12018         (stop_all_threads): Adjust.
12019         (handle_no_resumed, handle_inferior_event): Adjust to consider the
12020         event's target.
12021         (switch_back_to_stepped_thread): Also consider target.
12022         (print_stop_event): Update.
12023         (normal_stop): Update.  Also consider the resume target.
12024         * infrun.h (wait_for_inferior): Remove declaration.
12025         (user_visible_resume_target): New declaration.
12026         (get_last_target_status, set_last_target_status): New
12027         process_stratum_target parameter.
12028         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
12029         process_stratum_target parameter, and use it.
12030         (clear_inline_frame_state (thread_info*)): New.
12031         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
12032         process_stratum_target parameter.
12033         (clear_inline_frame_state (thread_info*)): Declare.
12034         * linux-fork.c (delete_checkpoint_command): Pass target down to
12035         find_thread_ptid.
12036         (checkpoint_command): Adjust.
12037         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
12038         instead of just tweaking inferior_ptid.
12039         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
12040         (exit_lwp): Pass target down to find_thread_ptid.
12041         (attach_proc_task_lwp_callback): Pass target down to
12042         add_thread/set_running/set_executing.
12043         (linux_nat_target::attach): Pass target down to
12044         thread_change_ptid.
12045         (get_detach_signal): Pass target down to find_thread_ptid.
12046         Consider last target status's target.
12047         (linux_resume_one_lwp_throw, resume_lwp)
12048         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
12049         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
12050         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
12051         (linux_nat_target::async_wait_fd): New.
12052         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
12053         target down.
12054         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
12055         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
12056         * linux-thread-db.c (struct thread_db_info::process_target): New
12057         field.
12058         (add_thread_db_info): Save target.
12059         (get_thread_db_info): New process_stratum_target parameter.  Also
12060         match target.
12061         (delete_thread_db_info): New process_stratum_target parameter.
12062         Also match target.
12063         (thread_from_lwp): Adjust to pass down target.
12064         (thread_db_notice_clone): Pass down target.
12065         (check_thread_db_callback): Pass down target.
12066         (try_thread_db_load_1): Always push the thread_db target.
12067         (try_thread_db_load, record_thread): Pass target down.
12068         (thread_db_target::detach): Pass target down.  Always unpush the
12069         thread_db target.
12070         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
12071         target down.  Always unpush the thread_db target.
12072         (find_new_threads_callback, thread_db_find_new_threads_2)
12073         (thread_db_target::update_thread_list): Pass target down.
12074         (thread_db_target::pid_to_str): Pass current inferior down.
12075         (thread_db_target::get_thread_local_address): Pass target down.
12076         (thread_db_target::resume, maintenance_check_libthread_db): Pass
12077         target down.
12078         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
12079         * procfs.c (procfs_target::procfs_init_inferior): Declare.
12080         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
12081         (procfs_init_inferior): Rename to ...
12082         (procfs_target::procfs_init_inferior): ... this and adjust.
12083         (procfs_target::create_inferior, procfs_notice_thread)
12084         (procfs_do_thread_registers): Adjust.
12085         * ppc-fbsd-tdep.c: Include "inferior.h".
12086         (ppcfbsd_get_thread_local_address): Pass down target.
12087         * proc-service.c (ps_xfer_memory): Switch current inferior and
12088         program space as well.
12089         (get_ps_regcache): Pass target down.
12090         * process-stratum-target.c
12091         (process_stratum_target::thread_address_space)
12092         (process_stratum_target::thread_architecture): Pass target down.
12093         * process-stratum-target.h
12094         (process_stratum_target::threads_executing): New field.
12095         (as_process_stratum_target): New.
12096         * ravenscar-thread.c
12097         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
12098         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
12099         down.
12100         * record-btrace.c (record_btrace_target::info_record): Adjust.
12101         (record_btrace_target::record_method)
12102         (record_btrace_target::record_is_replaying)
12103         (record_btrace_target::fetch_registers)
12104         (get_thread_current_frame_id, record_btrace_target::resume)
12105         (record_btrace_target::wait, record_btrace_target::stop): Pass
12106         target down.
12107         * record-full.c (record_full_wait_1): Switch to event thread.
12108         Pass target down.
12109         * regcache.c (regcache::regcache)
12110         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
12111         process_stratum_target parameter and handle it.
12112         (current_thread_target): New global.
12113         (get_thread_regcache): Add process_stratum_target parameter and
12114         handle it.  Switch inferior before calling target method.
12115         (get_thread_regcache): Pass target down.
12116         (get_thread_regcache_for_ptid): Pass target down.
12117         (registers_changed_ptid): Add process_stratum_target parameter and
12118         handle it.
12119         (registers_changed_thread, registers_changed): Pass target down.
12120         (test_get_thread_arch_aspace_regcache): New.
12121         (current_regcache_test): Define a couple local test_target_ops
12122         instances and use them for testing.
12123         (readwrite_regcache): Pass process_stratum_target parameter.
12124         (cooked_read_test, cooked_write_test): Pass mock_target down.
12125         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
12126         (get_thread_arch_aspace_regcache): Add process_stratum_target
12127         parameter.
12128         (regcache::target): New method.
12129         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
12130         (regcache::registers_changed_ptid): Add process_stratum_target
12131         parameter.
12132         (regcache::m_target): New field.
12133         (registers_changed_ptid): Add process_stratum_target parameter.
12134         * remote.c (remote_state::supports_vCont_probed): New field.
12135         (remote_target::async_wait_fd): New method.
12136         (remote_unpush_and_throw): Add remote_target parameter.
12137         (get_current_remote_target): Adjust.
12138         (remote_target::remote_add_inferior): Push target.
12139         (remote_target::remote_add_thread)
12140         (remote_target::remote_notice_new_inferior)
12141         (get_remote_thread_info): Pass target down.
12142         (remote_target::update_thread_list): Skip threads of inferiors
12143         bound to other targets.  (remote_target::close): Don't discard
12144         inferiors.  (remote_target::add_current_inferior_and_thread)
12145         (remote_target::process_initial_stop_replies)
12146         (remote_target::start_remote)
12147         (remote_target::remote_serial_quit_handler): Pass down target.
12148         (remote_target::remote_unpush_target): New remote_target
12149         parameter.  Unpush the target from all inferiors.
12150         (remote_target::remote_unpush_and_throw): New remote_target
12151         parameter.  Pass it down.
12152         (remote_target::open_1): Check whether the current inferior has
12153         execution instead of checking whether any inferior is live.  Pass
12154         target down.
12155         (remote_target::remote_detach_1): Pass down target.  Use
12156         remote_unpush_target.
12157         (extended_remote_target::attach): Pass down target.
12158         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
12159         (remote_target::append_resumption): Pass down target.
12160         (remote_target::append_pending_thread_resumptions)
12161         (remote_target::remote_resume_with_hc, remote_target::resume)
12162         (remote_target::commit_resume): Pass down target.
12163         (remote_target::remote_stop_ns): Check supports_vCont_probed.
12164         (remote_target::interrupt_query)
12165         (remote_target::remove_new_fork_children)
12166         (remote_target::check_pending_events_prevent_wildcard_vcont)
12167         (remote_target::remote_parse_stop_reply)
12168         (remote_target::process_stop_reply): Pass down target.
12169         (first_remote_resumed_thread): New remote_target parameter.  Pass
12170         it down.
12171         (remote_target::wait_as): Pass down target.
12172         (unpush_and_perror): New remote_target parameter.  Pass it down.
12173         (remote_target::readchar, remote_target::remote_serial_write)
12174         (remote_target::getpkt_or_notif_sane_1)
12175         (remote_target::kill_new_fork_children, remote_target::kill): Pass
12176         down target.
12177         (remote_target::mourn_inferior): Pass down target.  Use
12178         remote_unpush_target.
12179         (remote_target::core_of_thread)
12180         (remote_target::remote_btrace_maybe_reopen): Pass down target.
12181         (remote_target::pid_to_exec_file)
12182         (remote_target::thread_handle_to_thread_info): Pass down target.
12183         (remote_target::async_wait_fd): New.
12184         * riscv-fbsd-tdep.c: Include "inferior.h".
12185         (riscv_fbsd_get_thread_local_address): Pass down target.
12186         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
12187         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
12188         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
12189         Adjust.
12190         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
12191         * solib-svr4.c (enable_break): Pass down target.
12192         * spu-multiarch.c (parse_spufs_run): Pass down target.
12193         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
12194         * target-delegates.c: Regenerate.
12195         * target.c (g_target_stack): Delete.
12196         (current_top_target): Return the current inferior's top target.
12197         (target_has_execution_1): Refer to the passed-in inferior's top
12198         target.
12199         (target_supports_terminal_ours): Check whether the initial
12200         inferior was already created.
12201         (decref_target): New.
12202         (target_stack::push): Incref/decref the target.
12203         (push_target, push_target, unpush_target): Adjust.
12204         (target_stack::unpush): Defref target.
12205         (target_is_pushed): Return bool.  Adjust to refer to the current
12206         inferior's target stack.
12207         (dispose_inferior): Delete, and inline parts ...
12208         (target_preopen): ... here.  Only dispose of the current inferior.
12209         (target_detach): Hold strong target reference while detaching.
12210         Pass target down.
12211         (target_thread_name): Add assertion.
12212         (target_resume): Pass down target.
12213         (target_ops::beneath, find_target_at): Adjust to refer to the
12214         current inferior's target stack.
12215         (get_dummy_target): New.
12216         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
12217         has a thread running.
12218         (initialize_targets): Rename to ...
12219         (_initialize_target): ... this.
12220         * target.h: Include "gdbsupport/refcounted-object.h".
12221         (struct target_ops): Inherit refcounted_object.
12222         (target_ops::shortname, target_ops::longname): Make const.
12223         (target_ops::async_wait_fd): New method.
12224         (decref_target): Declare.
12225         (struct target_ops_ref_policy): New.
12226         (target_ops_ref): New typedef.
12227         (get_dummy_target): Declare function.
12228         (target_is_pushed): Return bool.
12229         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
12230         (all_matching_threads_iterator::all_matching_threads_iterator):
12231         Handle filter target.
12232         * thread-iter.h (struct all_matching_threads_iterator, struct
12233         all_matching_threads_range, class all_non_exited_threads_range):
12234         Filter by target too.  Remove explicit.
12235         * thread.c (threads_executing): Delete.
12236         (inferior_thread): Pass down current inferior.
12237         (clear_thread_inferior_resources): Pass down thread pointer
12238         instead of ptid_t.
12239         (add_thread_silent, add_thread_with_info, add_thread): Add
12240         process_stratum_target parameter.  Use it for thread and inferior
12241         searches.
12242         (is_current_thread): New.
12243         (thread_info::deletable): Use it.
12244         (find_thread_ptid, thread_count, in_thread_list)
12245         (thread_change_ptid, set_resumed, set_running): New
12246         process_stratum_target parameter.  Pass it down.
12247         (set_executing): New process_stratum_target parameter.  Pass it
12248         down.  Adjust reference to 'threads_executing'.
12249         (threads_are_executing): New process_stratum_target parameter.
12250         Adjust reference to 'threads_executing'.
12251         (set_stop_requested, finish_thread_state): New
12252         process_stratum_target parameter.  Pass it down.
12253         (switch_to_thread): Also match inferior.
12254         (switch_to_thread): New process_stratum_target parameter.  Pass it
12255         down.
12256         (update_threads_executing): Reimplement.
12257         * top.c (quit_force): Pop targets from all inferior.
12258         (gdb_init): Don't call initialize_targets.
12259         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
12260         Declare.
12261         (windows_add_thread, windows_delete_thread): Adjust.
12262         (get_windows_debug_event): Rename to ...
12263         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
12264         * tracefile-tfile.c (tfile_target_open): Pass down target.
12265         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
12266         Forward declare.
12267         (switch_to_thread): Add process_stratum_target parameter.
12268         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
12269         parameter.  Use it.
12270         (mi_on_resume): Pass target down.
12271         * nat/fork-inferior.c (startup_inferior): Add
12272         process_stratum_target parameter.  Pass it down.
12273         * nat/fork-inferior.h (startup_inferior): Add
12274         process_stratum_target parameter.
12275         * python/py-threadevent.c (py_get_event_thread): Pass target down.
12276
12277 2020-01-10  Pedro Alves  <palves@redhat.com>
12278
12279         * remote.c (remote_target::start_remote): Don't set inferior_ptid
12280         directly.  Instead find the first thread in the thread list and
12281         use switch_to_thread.
12282
12283 2020-01-10  Pedro Alves  <palves@redhat.com>
12284
12285         * remote.c (remote_target::remote_add_inferior): Don't bind a
12286         process to the current inferior if the current inferior is already
12287         bound to a process.
12288
12289 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
12290             Pedro Alves  <palves@redhat.com>
12291
12292         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
12293         If no process is specified, return null_ptid instead of
12294         inferior_ptid.
12295         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
12296         TARGET_WAITKIND_SIGNALLED with no pid.
12297
12298 2020-01-10  Pedro Alves  <palves@redhat.com>
12299
12300         * remote.c (first_remote_resumed_thread): New.
12301         (remote_target::wait_as): Use it as default event_ptid instead of
12302         inferior_ptid.
12303
12304 2020-01-10  Pedro Alves  <palves@redhat.com>
12305
12306         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
12307
12308 2020-01-10  Pedro Alves  <palves@redhat.com>
12309
12310         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
12311         not -1.
12312
12313 2020-01-10  Pedro Alves  <palves@redhat.com>
12314
12315         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
12316         ptid to get_last_target_status.
12317         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
12318         ptid to get_last_target_status.
12319         * infcmd.c (continue_command): Don't pass a target_waitstatus to
12320         get_last_target_status.
12321         (info_program_command): Don't pass a target_waitstatus to
12322         get_last_target_status.
12323         * infrun.c (init_wait_for_inferior): Use
12324         nullify_last_target_wait_ptid.
12325         (get_last_target_status): Handle nullptr arguments.
12326         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
12327         (print_stop_event): Don't pass a ptid to get_last_target_status.
12328         (normal_stop): Don't pass a ptid to get_last_target_status.
12329         * infrun.h (get_last_target_status, set_last_target_status): Move
12330         comments here and update.
12331         (nullify_last_target_wait_ptid): Declare.
12332         * linux-fork.c (fork_load_infrun_state): Remove local extern
12333         declaration of nullify_last_target_wait_ptid.
12334         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
12335         to get_last_target_status.
12336
12337 2020-01-10  Pedro Alves  <palves@redhat.com>
12338
12339         * gdbthread.h (scoped_restore_current_thread)
12340         <dont_restore, restore, m_dont_restore>: Declare.
12341         * thread.c (thread_alive): Add assertion.  Return bool.
12342         (switch_to_thread_if_alive): New.
12343         (prune_threads): Switch inferior/thread.
12344         (print_thread_info_1): Switch thread before calling target methods.
12345         (scoped_restore_current_thread::restore): New, factored out from
12346         ...
12347         (scoped_restore_current_thread::~scoped_restore_current_thread):
12348         ... this.
12349         (scoped_restore_current_thread::scoped_restore_current_thread):
12350         Add assertion.
12351         (thread_apply_all_command, thread_select): Use
12352         switch_to_thread_if_alive.
12353         * infrun.c (proceed, restart_threads, handle_signal_stop)
12354         (switch_back_to_stepped_thread): Switch current thread before
12355         calling target methods.
12356
12357 2020-01-10  Pedro Alves <palves@redhat.com>
12358
12359         * inferior.c (switch_to_inferior_no_thread): New function,
12360         factored out from ...
12361         (inferior_command): ... here.
12362         * inferior.h (switch_to_inferior_no_thread): Declare.
12363         * mi/mi-main.c (run_one_inferior): Use
12364         switch_to_inferior_no_thread.
12365
12366 2020-01-10  Pedro Alves  <palves@redhat.com>
12367
12368         * infcmd.c (kill_command): Remove dead code.
12369
12370 2020-01-10  Pedro Alves  <palves@redhat.com>
12371
12372         * remote.c (remote_target::mourn_inferior): No longer check
12373         whether the target is running.
12374
12375 2020-01-10  Pedro Alves  <palves@redhat.com>
12376
12377         * corelow.c (core_target::has_execution): Change parameter type to
12378         inferior pointer.
12379         * inferior.c (number_of_live_inferiors): Use
12380         inferior::has_execution instead of target_has_execution_1.
12381         * inferior.h (inferior::has_execution): New.
12382         * linux-thread-db.c (thread_db_target::update_thread_list): Use
12383         inferior::has_execution instead of target_has_execution_1.
12384         * process-stratum-target.c
12385         (process_stratum_target::has_execution): Change parameter type to
12386         inferior pointer.  Check the inferior's PID instead of
12387         inferior_ptid.
12388         * process-stratum-target.h
12389         (process_stratum_target::has_execution): Change parameter type to
12390         inferior pointer.
12391         * record-full.c (record_full_core_target::has_execution): Change
12392         parameter type to inferior pointer.
12393         * target.c (target_has_execution_1): Change parameter type to
12394         inferior pointer.
12395         (target_has_execution_current): Adjust.
12396         * target.h (target_ops::has_execution): Change parameter type to
12397         inferior pointer.
12398         (target_has_execution_1): Change parameter type to inferior
12399         pointer.  Change return type to bool.
12400         * tracefile.h (tracefile_target::has_execution): Change parameter
12401         type to inferior pointer.
12402
12403 2020-01-10  Pedro Alves  <palves@redhat.com>
12404
12405         * exceptions.c (print_flush): Remove current_top_target() check.
12406
12407 2020-01-10  Pedro Alves  <palves@redhat.com>
12408
12409         * remote.c (show_remote_exec_file): Show the current inferior's
12410         exec-file instead of the command variable's value.
12411
12412 2020-01-10  Pedro Alves  <palves@redhat.com>
12413
12414         * record-full.c (record_full_resume_ptid): New global.
12415         (record_full_target::resume): Set it.
12416         (record_full_wait_1): Use record_full_resume_ptid instead of
12417         inferior_ptid.
12418
12419 2020-01-10  Pedro Alves  <palves@redhat.com>
12420
12421         * gdbthread.h (scoped_restore_current_thread)
12422         <dont_restore, restore, m_dont_restore>: Declare.
12423         * thread.c (thread_alive): Add assertion.  Return bool.
12424         (switch_to_thread_if_alive): New.
12425         (prune_threads): Switch inferior/thread.
12426         (print_thread_info_1): Switch thread before calling target methods.
12427         (scoped_restore_current_thread::restore): New, factored out from
12428         ...
12429         (scoped_restore_current_thread::~scoped_restore_current_thread):
12430         ... this.
12431         (scoped_restore_current_thread::scoped_restore_current_thread):
12432         Add assertion.
12433         (thread_apply_all_command, thread_select): Use
12434         switch_to_thread_if_alive.
12435
12436 2020-01-10  George Barrett  <bob@bob131.so>
12437
12438         * stap-probe.c (stap_modify_semaphore): Don't check for null
12439         semaphores.
12440         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
12441         for null semaphores.
12442
12443 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12444
12445         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
12446         all source windows, and maintain horizontal scroll status while
12447         doing so.
12448
12449 2020-01-09  Tom Tromey  <tom@tromey.com>
12450
12451         PR tui/18932:
12452         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
12453         update_source_window, not print_source_lines.
12454
12455 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12456
12457         * tui/tui.c (tui_enable): Register tui hooks after calling
12458         tui_display_main.
12459
12460 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
12461
12462         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
12463
12464 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
12465
12466         * thread.c (print_thread_info_1): Fix indentation.
12467
12468 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
12469
12470         * symtab.c (general_symbol_info::compute_and_set_names): Move the
12471         unique_xmalloc_ptr outside the if to always free the demangled name.
12472
12473 2020-01-08  Tom Tromey  <tromey@adacore.com>
12474
12475         * xcoffread.c (enter_line_range, read_xcoff_symtab)
12476         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
12477         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
12478         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
12479         Remove.
12480         (section_offsets): New typedef.
12481         * symtab.c (fixup_section, get_msymbol_address): Update.
12482         * symmisc.c (dump_msymbols): Update.
12483         * symfile.h (relative_addr_info_to_section_offsets)
12484         (symfile_map_offsets_to_segments): Update.
12485         * symfile.c (build_section_addr_info_from_objfile)
12486         (init_objfile_sect_indices): Update.
12487         (struct place_section_arg): Change type of "offsets".
12488         (place_section): Update.
12489         (relative_addr_info_to_section_offsets): Change type of
12490         "section_offsets".  Remove "num_sections" parameter.
12491         (default_symfile_offsets, syms_from_objfile_1)
12492         (set_objfile_default_section_offset): Update.
12493         (reread_symbols): No need to preserve section offsets by hand.
12494         (symfile_map_offsets_to_segments): Change type of "offsets".
12495         * stap-probe.c (relocate_address): Update.
12496         * stabsread.h (process_one_symbol): Update.
12497         * solib-target.c (struct lm_info_target) <offsets>: Change type.
12498         (solib_target_relocate_section_addresses): Update.
12499         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
12500         Update.
12501         * solib-frv.c (frv_relocate_main_executable): Update.
12502         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
12503         * solib-aix.c (solib_aix_get_section_offsets): Change return
12504         type.
12505         (solib_aix_solib_create_inferior_hook): Update.
12506         * remote.c (remote_target::get_offsets): Update.
12507         * psymtab.c (find_pc_sect_psymtab): Update.
12508         * psympriv.h (struct partial_symbol) <address, text_low,
12509         text_high>: Update.
12510         * objfiles.h (obj_section_offset): Update.
12511         (struct objfile) <section_offsets>: Change type.
12512         <num_sections>: Remove.
12513         (objfile_relocate): Update.
12514         * objfiles.c (entry_point_address_query): Update
12515         (relocate_one_symbol): Change type of "section_offsets".
12516         (objfile_relocate1, objfile_relocate1): Change type of
12517         "new_offsets".
12518         (objfile_rebase1): Update.
12519         * mipsread.c (mipscoff_symfile_read): Update.
12520         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
12521         parameter.
12522         * mdebugread.c (parse_symbol): Change type of "section_offsets".
12523         (parse_external, psymtab_to_symtab_1): Update.
12524         * machoread.c (macho_symfile_offsets): Update.
12525         * ia64-tdep.c (ia64_find_unwind_table): Update.
12526         * hppa-tdep.c (read_unwind_info): Update.
12527         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
12528         * dwarf2read.c (create_addrmap_from_index)
12529         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12530         (process_psymtab_comp_unit_reader, add_partial_symbol)
12531         (add_partial_subprogram, process_full_comp_unit)
12532         (read_file_scope, read_func_scope, read_lexical_block_scope)
12533         (read_call_site_scope, dwarf2_rnglists_process)
12534         (dwarf2_ranges_process, dwarf2_ranges_read)
12535         (dwarf_decode_lines_1, var_decode_location, new_symbol)
12536         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
12537         Update.
12538         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
12539         Update.
12540         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
12541         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
12542         (process_one_symbol): Change type of "section_offsets".
12543         * ctfread.c (get_objfile_text_range): Update.
12544         * coffread.c (coff_symtab_read, enter_linenos)
12545         (process_coff_symbol): Update.
12546         * coff-pe-read.c (add_pe_forwarded_sym): Update.
12547         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
12548
12549 2020-01-08  Tom Tromey  <tromey@adacore.com>
12550
12551         * dwarf2read.c (parse_macro_definition): Use std::string.
12552         (parse_macro_definition): Likewise.
12553
12554 2020-01-08  Tom Tromey  <tromey@adacore.com>
12555
12556         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
12557         (ATTR_ALLOC_CHUNK): Remove.
12558
12559 2020-01-08  Tom Tromey  <tromey@adacore.com>
12560
12561         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
12562
12563 2020-01-08  Tom Tromey  <tromey@adacore.com>
12564
12565         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
12566         (dwarf2_compute_name, open_dwo_file): Likewise.
12567         (process_enumeration_scope): Use std::vector.
12568         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
12569         (partial_die_info::fixup, dwarf2_start_subfile)
12570         (guess_full_die_structure_name, dwarf2_name): Likewise.
12571         (determine_prefix): Update.
12572         (guess_full_die_structure_name): Make return type const.
12573         (partial_die_full_name): Return unique_xmalloc_ptr.
12574         (DW_FIELD_ALLOC_CHUNK): Remove.
12575
12576 2020-01-07  Tom Tromey  <tromey@adacore.com>
12577
12578         PR build/24937:
12579         * stap-probe.c (class stap_static_probe_ops): Add constructor.
12580
12581 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12582
12583         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
12584
12585 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
12586
12587         * stack.c (print_frame_info): Move disassemble_next_line code
12588         inside source_print block.
12589
12590 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12591
12592         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
12593         gdb/signals.h, as we are now using native signal symbols.
12594
12595 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12596
12597         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
12598         overflow by an early check of content vs threshold.
12599         * tui/tui-source.c (tui_source_window::line_is_displayed):
12600         Likewise.
12601
12602 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12603
12604         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
12605
12606 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
12607
12608         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
12609         export table if no section contains it's RVA.
12610
12611 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12612
12613         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
12614
12615 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
12616
12617         * source.c (print_source_lines_base): Set last_line_listed.
12618
12619 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
12620
12621         * tui/tui-disasm.c: Remove trailing spaces.
12622
12623 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
12624             Pedro Alves  <palves@redhat.com>
12625
12626         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
12627         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
12628         (windows_gdb_signal_to_target): New function, uses the above
12629         enumeration to convert GDB internal signal codes to equivalent
12630         Windows codes.
12631         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
12632         * windows-nat.c: Include "gdb_wait.h".
12633         (get_windows_debug_event): Extract the fatal exception from the
12634         exit status and convert to the equivalent Posix signal number.
12635         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
12636         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
12637         * gdbsupport/gdb_wait.c: New file, implements
12638         windows_status_to_termsig.
12639         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
12640         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
12641
12642 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
12643
12644         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
12645         show_layout.
12646
12647 2020-01-05  Luis Machado  <luis.machado@linaro.org>
12648
12649         * aarch64-linux-nat.c
12650         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
12651         and bfd_mach_aarch64.
12652
12653 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12654
12655         * ui-file.c (stdio_file::can_emit_style_escape)
12656         (tee_file::can_emit_style_escape): Ensure style is used also on
12657         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
12658         to gdb_stdout.
12659         * main.c (set_gdb_data_directory): Use file style to output the
12660         warning that the given pathname is not a directory.
12661         * top.c (show_history_filename, gdb_safe_append_history)
12662         (show_gdb_datadir): Use file style.
12663
12664 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12665
12666         * solib-target.c (struct lm_info_target):
12667         Change offsets to be a unique_xmalloc_ptr.
12668         (solib_target_relocate_section_addresses): Update.
12669
12670 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
12671
12672         * windows-nat.c (windows_clear_solib): Free so_list linked list.
12673
12674 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
12675
12676         * MAINTAINERS (Write After Approval): Add myself.
12677
12678 2020-01-02  Luis Machado  <luis.machado@linaro.org>
12679
12680         * proc-service.c (get_ps_regcache): Remove reference to obsolete
12681         Cell BE architecture.
12682         * target.h (struct target_ops) <thread_architecture>: Likewise.
12683
12684 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12685
12686         * Makefile.in: Use INSTALL_PROGRAM_ENV.
12687
12688 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
12689
12690         * MAINTAINERS (Write After Approval): Add myself.
12691
12692 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12693
12694         * gdbarch.sh: Update copyright year range of generated files.
12695
12696 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12697
12698         Update copyright year range in all GDB files.
12699
12700 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12701
12702         * copyright.py: Convert to Python 3.
12703
12704 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12705
12706         * copyright.py: Adapt after move of gnulib directory from gdb
12707         directory to toplevel directory.
12708
12709 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12710
12711         * copyright.py (main): Exit if run from the wrong directory.
12712
12713 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12714
12715         * top.c (print_gdb_version): Change copyright year to 2020.
12716
12717 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
12718
12719         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
12720
12721 For older changes see ChangeLog-2019.
12722 \f
12723 Local Variables:
12724 mode: change-log
12725 left-margin: 8
12726 fill-column: 74
12727 version-control: never
12728 coding: utf-8
12729 End: