]> git.ipfire.org Git - thirdparty/binutils-gdb.git/blob - gdb/ChangeLog
TUI window resize should not need invisibility
[thirdparty/binutils-gdb.git] / gdb / ChangeLog
1 2019-08-15 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4 (show_data): Don't change window visibility.
5 (tui_gen_win_info::resize): Remove special case for command
6 window. Use wresize, when available.
7 (show_source_or_disasm_and_command): Don't change window
8 visibility.
9 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
10 <make_visible>: New method.
11 * tui/tui-command.c (tui_cmd_window::resize): New method.
12
13 2019-08-15 Tom Tromey <tom@tromey.com>
14
15 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
16 (struct tui_source_windows): New.
17 * tui/tui-winsource.c (tui_display_main): Update.
18 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
19 (new_height_ok, parse_scrolling_args): Update.
20 * tui/tui-layout.c (show_layout, show_data): Update.
21 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
22 (tui_add_to_source_windows): Don't declare.
23 * tui/tui-data.c (source_windows, tui_source_windows)
24 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
25
26 2019-08-15 Tom Tromey <tom@tromey.com>
27
28 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
29 Rename from reset.
30 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
31 * tui/tui-layout.c (show_source_disasm_command, show_data):
32 Update.
33 (tui_gen_win_info::resize): Rename.
34 (show_source_or_disasm_and_command): Update.
35 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
36 reset.
37
38 2019-08-15 Tom Tromey <tom@tromey.com>
39
40 * tui/tui-stack.c (tui_initialize_static_data): Remove.
41 * tui/tui-interp.c (tui_interp::init): Don't call
42 tui_initialize_static_data.
43 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
44
45 2019-08-15 Tom Tromey <tom@tromey.com>
46
47 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
48 examine tui_win_list.
49
50 2019-08-15 Tom Tromey <tom@tromey.com>
51
52 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
53 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
54 tui_clear_source_content.
55 (tui_clear_source_content): Remove.
56 (tui_source_window_base::do_erase_source_content): Hoist call to
57 content.clear().
58 * tui/tui-stack.c (tui_show_frame_info): Don't call
59 tui_clear_source_content.
60
61 2019-08-15 Tom Tromey <tom@tromey.com>
62
63 * tui/tui-winsource.h (struct tui_source_window_base)
64 <do_erase_source_content>: New method.
65 <erase_source_content>: New method.
66 (tui_erase_source_content): Don't declare.
67 * tui/tui-winsource.c (tui_clear_source_content): Update.
68 (tui_source_window_base::do_erase_source_content): Rename from
69 tui_erase_source_content.
70 (tui_source_window_base::show_source_content): Update.
71 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
72 * tui/tui-source.h (struct tui_source_window)
73 <erase_source_content>: New method.
74 * tui/tui-disasm.h (struct tui_disasm_window)
75 <erase_source_content>: New method.
76
77 2019-08-15 Tom Tromey <tom@tromey.com>
78
79 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
80 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
81 constructor.
82 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
83 * tui/tui-source.c (tui_set_source_content): Update.
84 * tui/tui-disasm.c (tui_set_disassem_content): Update.
85
86 2019-08-15 Tom Tromey <tom@tromey.com>
87
88 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
89 * tui/tui-winsource.c (tui_line_is_displayed): Move to
90 tui-source.c.
91 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
92 Declare.
93 * tui/tui-source.c (tui_source_window::line_is_displayed): New
94 method.
95 (tui_source_window::maybe_update): Update.
96
97 2019-08-15 Tom Tromey <tom@tromey.com>
98
99 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
100 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
101 tui-disasm.c.
102 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
103 Declare.
104 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
105 method.
106 (tui_disasm_window::maybe_update): Update.
107
108 2019-08-15 Tom Tromey <tom@tromey.com>
109
110 * tui/tui-winsource.h (struct tui_source_window_base)
111 <maybe_update>: Declare.
112 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
113 method.
114 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
115 Declare.
116 * tui/tui-source.c (tui_source_window::maybe_update): New method.
117 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
118 Declare.
119 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
120
121 2019-08-15 Tom Tromey <tom@tromey.com>
122
123 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
124
125 2019-08-15 Tom Tromey <tom@tromey.com>
126
127 * tui/tui-wingeneral.c: Include tui-stack.h.
128 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
129 (struct tui_locator_window): Move from tui-data.h.
130 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
131 (tui_initialize_static_data): Move from tui-data.c.
132 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
133 (struct tui_locator_window): Move to tui-stack.c.
134 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
135 (tui_initialize_static_data): Move to tui-stack.c.
136
137 2019-08-15 Tom Tromey <tom@tromey.com>
138
139 * tui/tui-layout.c (show_source_disasm_command)
140 (show_source_or_disasm_and_command): Use make_visible method, not
141 tui_make_window.
142 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
143 Remove.
144
145 2019-08-15 Tom Tromey <tom@tromey.com>
146
147 * tui/tui-wingeneral.h (tui_make_window): Update.
148 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
149 parameter.
150 (tui_gen_win_info::make_visible): Update.
151 * tui/tui-regs.c (tui_data_window::display_registers_from):
152 Update.
153 * tui/tui-layout.c (show_source_disasm_command)
154 (show_source_or_disasm_and_command): Update.
155 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
156 (enum tui_box): Remove.
157 (struct tui_win_info) <can_box>: New method.
158 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
159 method.
160
161 2019-08-15 Tom de Vries <tdevries@suse.de>
162
163 * linux-nat-trad.c: Include gdbarch.h.
164
165 2019-08-14 Alan Hayward <alan.hayward@arm.com>
166
167 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
168 register sizes.
169
170 2019-08-14 Tom Tromey <tromey@adacore.com>
171
172 * darwin-nat.c: Include gdbarch.h.
173 * darwin-nat-info.c: Include gdbarch.h.
174
175 2019-08-13 Tom Tromey <tom@tromey.com>
176
177 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
178 Remove.
179 * tui/tui-data.c (tui_initialize_static_data): Update.
180
181 2019-08-13 Tom Tromey <tom@tromey.com>
182
183 * tui/tui-winsource.h (struct tui_exec_info_window)
184 <~tui_exec_info_window, maybe_allocate_content, get_content,
185 m_content>: Remove.
186 (struct tui_source_window_base) <set_exec_info_content,
187 show_exec_info_content>: Don't declare.
188 * tui/tui-winsource.c
189 (tui_exec_info_window::maybe_allocate_content): Remove.
190 (tui_source_window_base::update_exec_info): Rename from
191 set_exec_info_content.
192 (tui_source_window_base::show_exec_info_content)
193 (tui_source_window_base::update_exec_info): Remove.
194
195 2019-08-13 Tom Tromey <tom@tromey.com>
196
197 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
198 declare.
199 * tui/tui-winsource.c (tui_update_source_window_as_is)
200 (tui_update_source_windows_with_addr, tui_erase_source_content):
201 Update.
202 (tui_clear_exec_info_content): Remove.
203
204 2019-08-13 Tom Tromey <tom@tromey.com>
205
206 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
207 declare.
208 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
209 call tui_erase_exec_info_content.
210 (tui_clear_exec_info_content): Rename from
211 tui_erase_exec_info_content.
212 (tui_clear_exec_info_content): Delete.
213
214 2019-08-13 Tom Tromey <tom@tromey.com>
215
216 * tui/tui-winsource.h (struct tui_source_window_base)
217 <show_exec_info_content>: Declare.
218 (tui_show_exec_info_content): Don't declare.
219 * tui/tui-winsource.c
220 (tui_source_window_base::show_exec_info_content): Rename from
221 tui_show_exec_info_content.
222 (tui_source_window_base::update_exec_info): Update.
223
224 2019-08-13 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
227 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
228 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
229 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
230 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
231 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
232 ... here.
233
234 2019-08-13 Tom Tromey <tom@tromey.com>
235
236 * tui/tui-winsource.h (struct tui_source_window_base)
237 <update_exec_info>: Declare.
238 (tui_update_exec_info): Don't declare.
239 * tui/tui-winsource.c (tui_update_source_window_as_is)
240 (tui_source_window_base::refresh_all)
241 (tui_update_all_breakpoint_info): Update.
242 (tui_source_window_base::update_exec_info): Rename from
243 tui_update_exec_info.
244 * tui/tui-stack.c (tui_show_frame_info): Update.
245
246 2019-08-13 Tom Tromey <tom@tromey.com>
247
248 * tui/tui-winsource.h (struct tui_source_window_base)
249 <set_exec_info_content>: Declare.
250 (tui_set_exec_info_content): Don't declare.
251 * tui/tui-winsource.c
252 (tui_source_window_base::set_exec_info_content): Rename from
253 tui_set_exec_info_content.
254 (tui_update_exec_info): Update.
255
256 2019-08-13 Tom Tromey <tom@tromey.com>
257
258 * tui/tui-winsource.h (struct tui_source_window_base)
259 <show_source_content>: Declare.
260 (tui_show_source_content): Don't declare.
261 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
262 (tui_source_window_base::show_source_content): Rename from
263 tui_show_source_content.
264 (tui_source_window_base::refresh_all): Update.
265 * tui/tui-layout.c (show_source_disasm_command)
266 (show_source_or_disasm_and_command): Update.
267
268 2019-08-13 Tom Tromey <tom@tromey.com>
269
270 * tui/tui-winsource.c (tui_erase_source_content)
271 (tui_show_source_content, tui_source_window_base::refresh_all):
272 Update.
273 * tui/tui-wingeneral.h
274 (tui_check_and_display_highlight_if_needed): Don't declare.
275 * tui/tui-wingeneral.c
276 (tui_win_info::check_and_display_highlight_if_needed): Rename from
277 check_and_display_highlight_if_needed.
278 * tui/tui-win.c (tui_rehighlight_all)
279 (tui_win_info::make_visible_with_new_height): Update.
280 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
281 (tui_data_window::erase_data_content)
282 (tui_data_window::display_all_data): Update.
283 * tui/tui-data.h (struct tui_win_info)
284 <check_and_display_highlight_if_needed>: Declare.
285
286 2019-08-13 Tom Tromey <tom@tromey.com>
287
288 * tui/tui-win.c (tui_resize_all): Call
289 tui_delete_invisible_windows.
290 * tui/tui-layout.c (show_layout): Call
291 tui_delete_invisible_windows.
292 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
293 * tui/tui-data.c (tui_delete_invisible_windows): New function.
294
295 2019-08-13 Tom Tromey <tom@tromey.com>
296
297 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
298 tui_add_win_to_layout.
299
300 2019-08-13 Tom Tromey <tom@tromey.com>
301
302 * tui/tui-layout.h (tui_default_win_height): Don't declare.
303 * tui/tui-layout.c (tui_default_win_height): Now static.
304
305 2019-08-13 Tom Tromey <tom@tromey.com>
306
307 * tui/tui-layout.c (show_layout): Unify all layout cases into a
308 single switch.
309 (show_source_disasm_command, show_source_or_disasm_and_command):
310 Don't check current layout.
311
312 2019-08-13 Tom Tromey <tom@tromey.com>
313
314 * tui/tui-wingeneral.c (make_all_visible): Remove.
315 (tui_make_all_invisible): Simplify.
316 * tui/tui-layout.c (tui_make_all_invisible): Move from
317 tui-wingeneral.c; simplify.
318 (show_layout): Hoist call to tui_make_all_invisible.
319 (show_data): Don't call tui_make_all_invisible.
320
321 2019-08-13 Tom Tromey <tom@tromey.com>
322
323 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
324 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
325
326 2019-08-13 Tom Tromey <tom@tromey.com>
327
328 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
329 tui-data.c.
330 (show_source_disasm_command, show_data)
331 (show_source_or_disasm_and_command): Don't use
332 tui_set_current_layout_to.
333 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
334 * tui/tui-data.c (current_layout, tui_current_layout): Move to
335 tui-layout.c.
336 (tui_set_current_layout_to): Remove.
337
338 2019-08-13 Tom Tromey <tom@tromey.com>
339
340 * tui/tui-layout.c (tui_set_layout): Update.
341 * tui/tui-data.h (struct tui_layout_def): Remove.
342 (tui_layout_def): Don't declare.
343 * tui/tui-data.c (layout_def): Remove.
344 (tui_layout_def): Remove.
345
346 2019-08-13 Tom Tromey <tom@tromey.com>
347
348 * tui/tui-winsource.h (struct tui_source_window_base)
349 <clear_detail>: No longer "override".
350 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
351 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
352 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
353 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
354 Remove.
355 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
356
357 2019-08-13 Tom Tromey <tromey@adacore.com>
358
359 * tracepoint.c: Don't include readline.h or history.h.
360
361 2019-08-12 Tom Tromey <tom@tromey.com>
362
363 * configure: Rebuild.
364 * configure.ac: Check for readline 7.
365 * NEWS: Mention readline 7 requirement.
366 * README: Update.
367
368 2019-08-12 Tom Tromey <tom@tromey.com>
369
370 * mingw-hdep.c (gdb_select): Remove readline hack.
371
372 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
373
374 * blockframe.c (find_pc_partial_function): Set *block to nullptr
375 when the function fails.
376
377 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
378
379 * s390-tdep.c (s390_type_align): New function.
380 (s390_gdbarch_init): Set it as type_align gdbarch method.
381
382 2019-08-09 Tom de Vries <tdevries@suse.de>
383
384 PR gdb/24591
385 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
386 pc_low with relocation offset.
387
388 2019-08-07 Tom Tromey <tromey@adacore.com>
389
390 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
391 (print_frame_args): Update.
392 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
393 Update.
394 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
395 * frame.h (struct frame_arg): Add initializers.
396 <error>: Now a unique_xmalloc_ptr.
397
398 2019-08-07 Alan Hayward <alan.hayward@arm.com>
399
400 * NEWS: Expand the Pointer Authentication entry.
401 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
402 (aarch64_frame_unmask_lr): ... to this.
403 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
404 Call aarch64_frame_unmask_lr.
405 * frame.c (struct frame_info): Add "masked" variable.
406 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
407 (fprint_frame): Check for masked pc.
408 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
409 declarations.
410 * python/py-framefilter.c (py_print_frame): Check for masked pc.
411 * stack.c (print_frame): Check for masked pc.
412
413 2019-08-06 Tom Tromey <tom@tromey.com>
414
415 * stabsread.c (patch_block_stabs, read_one_struct_field)
416 (read_enum_type): Use obstack_strndup.
417 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
418 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
419 * dwarf2read.c (guess_full_die_structure_name)
420 (anonymous_struct_prefix): Use obstack_strndup.
421 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
422 * c-exp.y (yylex): Use obstack_strndup.
423 * ada-exp.y (write_object_renaming, write_ambiguous_var)
424 (write_var_or_type): Use obstack_strndup.
425
426 2019-08-06 Tom Tromey <tom@tromey.com>
427
428 * symfile.c (reread_symbols): Use obstack_strdup.
429 * stabsread.c (read_type): Use obstack_strdup.
430 * gdb_obstack.h (obstack_strdup): New overload.
431 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
432 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
433 (dwarf2_canonicalize_name): Use obstack_strdup.
434 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
435 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
436 Use obstack_strdup.
437
438 2019-08-06 Tom Tromey <tom@tromey.com>
439
440 * gdb_obstack.h (obstack_strdup): Define.
441 * gdb_obstack.c (obstack_strdup): Don't define.
442
443 2019-08-06 Tom Tromey <tom@tromey.com>
444
445 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
446 obstack_strdup.
447 * typeprint.c (typedef_hash_table::find_global_typedef): Use
448 obstack_strdup.
449 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
450 * stabsread.c (common_block_start): Use obstack_strdup.
451 * objfiles.c (set_objfile_main_name, objfile): Use
452 obstack_strdup.
453 * namespace.c (add_using_directive): Use obstack_strdup.
454 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
455 * jit.c (finalize_symtab): Use obstack_strdup.
456 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
457 (guess_partial_die_structure_name, partial_die_info::fixup)
458 (dwarf2_name): Use obstack_strdup.
459 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
460 obstack_strdup.
461 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
462 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
463 obstack_strdup.
464 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
465
466 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
467
468 * unittests/help-doc-selftests.c: New file.
469 * Makefile.in: Add the new file.
470
471 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
472
473 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
474 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
475 the full first line, except when FOR_VALUE_PREFIX. In this case,
476 the trailing '.' is not output, and the first character is uppercased.
477 (print_help_for_command): Update call to print_doc_line.
478 (print_doc_of_command): Likewise.
479 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
480 * cli/cli-option.c (append_indented_doc): Do not append newline.
481 (build_help_option): Append newline after first appended_indented_doc
482 only if a second call is done.
483 (build_help): Append 2 new lines before each option, except the first
484 one.
485 * compile/compile.c (_initialize_compile): Add new lines after
486 %OPTIONS%, when not at the end of the help.
487 Change help doc or code
488 producing the help doc to respect the invariants.
489 * maint-test-options.c (_initialize_maint_test_options): Likewise.
490 Also removed the new line after 'Options:', as all other commands
491 do not put an empty line between 'Options:' and the first option.
492 * printcmd.c (_initialize_printcmd): Likewise.
493 * stack.c (_initialize_stack): Likewise.
494 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
495 incorrectly telling COMMAND is optional.
496 * ada-lang.c (_initialize_ada_language): Change help doc or code
497 producing the help doc to respect the invariants.
498 * ada-tasks.c (_initialize_ada_tasks): Likewise.
499 * breakpoint.c (_initialize_breakpoint): Likewise.
500 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
501 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
502 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
503 * cli/cli-style.c (cli_style_option::add_setshow_commands,
504 _initialize_cli_style): Likewise.
505 * corelow.c (core_target_info): Likewise.
506 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
507 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
508 * filesystem.c (_initialize_filesystem): Likewise.
509 * frame.c (_initialize_frame): Likewise.
510 * gnu-nat.c (add_task_commands): Likewise.
511 * infcall.c (_initialize_infcall): Likewise.
512 * infcmd.c (_initialize_infcmd): Likewise.
513 * interps.c (_initialize_interpreter): Likewise.
514 * language.c (_initialize_language): Likewise.
515 * linux-fork.c (_initialize_linux_fork): Likewise.
516 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
517 * maint.c (_initialize_maint_cmds): Likewise.
518 * memattr.c (_initialize_mem): Likewise.
519 * printcmd.c (_initialize_printcmd): Likewise.
520 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
521 _RegEx): Likewise.
522 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
523 * record-btrace.c (_initialize_record_btrace): Likewise.
524 * record-full.c (_initialize_record_full): Likewise.
525 * record.c (_initialize_record): Likewise.
526 * regcache-dump.c (_initialize_regcache_dump): Likewise.
527 * regcache.c (_initialize_regcache): Likewise.
528 * remote.c (add_packet_config_cmd, init_remote_threadtests,
529 _initialize_remote): Likewise.
530 * ser-tcp.c (_initialize_ser_tcp): Likewise.
531 * serial.c (_initialize_serial): Likewise.
532 * skip.c (_initialize_step_skip): Likewise.
533 * source.c (_initialize_source): Likewise.
534 * stack.c (_initialize_stack): Likewise.
535 * symfile.c (_initialize_symfile): Likewise.
536 * symtab.c (_initialize_symtab): Likewise.
537 * target-descriptions.c (_initialize_target_descriptions): Likewise.
538 * top.c (init_main): Likewise.
539 * tracefile-tfile.c (tfile_target_info): Likewise.
540 * tracepoint.c (_initialize_tracepoint): Likewise.
541 * tui/tui-win.c (_initialize_tui_win): Likewise.
542 * utils.c (add_internal_problem_command): Likewise.
543 * valprint.c (value_print_option_defs): Likewise.
544
545 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
546
547 PR build/24886
548 * configure.ac: Drop enable-libmcheck support.
549 * configure, config.in: Rebuild.
550 * libmcheck.m4: Remove.
551 * acinclude.m4: Don't include it.
552 * Makefile.in: Don't distribute it.
553 * top.c (print_gdb_configuration): Don't mention it.
554
555 2019-08-06 Tom Tromey <tom@tromey.com>
556
557 * utils.c (set_output_style): Sometimes pass stream to
558 emit_style_escape.
559 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
560 * record-btrace.c (btrace_insn_history): Update.
561 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
562 method.
563 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
564 Update initializers.
565 <m_uiout>: New field.
566 <m_di>: Move lower.
567 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
568 Remove "uiout" parameter.
569 (dump_insns): Update.
570 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
571 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
572
573 2019-08-06 Christian Biesinger <cbiesinger@google.com>
574
575 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
576 (error_in_psymtab_expansion): Likewise.
577 (lookup_symbol_via_quick_fns): Likewise.
578 (basic_lookup_transparent_type_quick): Likewise.
579 (basic_lookup_transparent_type_1): Likewise.
580
581 2019-08-06 Tom Tromey <tromey@adacore.com>
582
583 * source.c (last_source_error): Now bool.
584 (print_source_lines_base): Make "noprint" bool. Only open
585 source file when last_source_visited changes.
586
587 2019-08-06 Tom Tromey <tromey@adacore.com>
588
589 * annotate.c (annotate_source_line): Use g_source_cache.
590 * source-cache.c (source_cache::get_plain_source_lines): Change
591 parameters. Populate m_offset_cache.
592 (source_cache::ensure): New method.
593 (source_cache::get_line_charpos): New method.
594 (extract_lines): Move lower. Change parameters.
595 (source_cache::get_source_lines): Move lower.
596 * source-cache.h (class source_cache): Update comment.
597 <get_line_charpos>: New method.
598 <get_source_lines>: Update comment.
599 <clear>: Clear m_offset_cache.
600 <get_plain_source_lines>: Change parameters.
601 <ensure>: New method
602 <m_offset_cache>: New member.
603 * source.c (forget_cached_source_info_for_objfile): Update.
604 (info_source_command): Use g_source_cache.
605 (find_source_lines, open_source_file_with_line_charpos): Remove.
606 (print_source_lines_base, search_command_helper): Use g_source_cache.
607 * source.h (open_source_file_with_line_charpos): Don't declare.
608 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
609 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
610 Use g_source_cache.
611
612 2019-08-06 Tom Tromey <tromey@adacore.com>
613
614 * source-cache.c (source_cache::get_plain_source_lines):
615 Remove "first_line" and "last_line" parameters.
616 (source_cache::get_source_lines): Cache plain text.
617 * source-cache.h (class source_cache)
618 <get_plain_source_lines>: Update.
619
620 2019-08-06 Tom Tromey <tromey@adacore.com>
621
622 * source-cache.c (extract_lines): No longer a method.
623 Changed type of parameter. Include final newline.
624 (selftests::extract_lines_test): New function.
625 (_initialize_source_cache): Likewise.
626 * source-cache.h (class source_cache)
627 <extract_lines>: Don't declare.
628
629 2019-08-06 Tom Tromey <tromey@adacore.com>
630
631 * breakpoint.c (init_breakpoint_sal): Update.
632 (breakpoint): Update.
633 * breakpoint.h (struct breakpoint) <filter>: Now a
634 unique_xmalloc_ptr.
635
636 2019-08-05 Christian Biesinger <cbiesinger@google.com>
637
638 * NEWS: Mention dictionary access on blocks.
639 * python/py-block.c (blpy_getitem): New function.
640 (block_object_as_mapping): New struct.
641 (block_object_type): Use new struct for tp_as_mapping field.
642
643 2019-08-05 Christian Biesinger <cbiesinger@google.com>
644
645 * objfiles.h (objfile): Add a comment describing partial symbols.
646
647 2019-08-05 Tom Tromey <tromey@adacore.com>
648
649 * compile/compile.c (_initialize_compile): Use _(), not N_().
650 * thread.c (_initialize_thread): Use _(), not N_().
651 * stack.c (_initialize_stack): Use _(), not N_().
652 * printcmd.c (_initialize_printcmd): Use _(), not N_().
653
654 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
655
656 * dwarf2read.c (struct dw2_symtab_iterator):
657 <want_specific_block>: Remove.
658 <block_index>: Change type to gdb::optional.
659 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
660 change type of BLOCK_INDEX parameter to gdb::optional.
661 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
662 (dw2_lookup_symbol): Don't pass argument for
663 WANT_SPECIFIC_BLOCK.
664 (dw2_expand_symtabs_for_function): Don't pass argument for
665 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
666 (class dw2_debug_names_iterator)
667 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
668 parameter, change BLOCK_INDEX type to gdb::optional.
669 <m_want_specific_block>: Remove.
670 <m_block_index>: Change type to gdb::optional.
671 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
672 gdb::optional. Re-write in function of gdb::optional.
673 (dw2_debug_names_lookup_symbol): Don't pass argument for
674 WANT_SPECIFIC_BLOCK.
675 (dw2_debug_names_expand_symtabs_for_function): Don't pass
676 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
677 BLOCK_INDEX.
678
679 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
680
681 * NEWS: Mention changes to "info sources" command.
682
683 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
684
685 * symtab.c (filename_partial_match_opts): New struct type.
686 (struct output_source_filename_data): New members
687 regexp, c_regexp, partial_match.
688 (output_source_filename): Use new members to decide to print file.
689 (info_sources_option_defs): New variable.
690 (make_info_sources_options_def_group, print_info_sources_header,
691 info_sources_command_completer):
692 New functions.
693 (info_sources_command): Read new optional arguments.
694 (_initialize_symtab): Update info sources help.
695
696 2019-08-02 Alexandre Oliva <oliva@adacore.com>
697
698 * ada-lang.c (exception_support_info_v0): Renamed from...
699 (default_exception_support_info): ... this. Create new
700 definition for v1.
701 (ada_has_this_exception_support): Look up catch_handlers_sym.
702 (ada_exception_support_info_sniffer): Try v0 after default.
703
704 2019-08-01 Tom Tromey <tromey@adacore.com>
705
706 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
707 gdbarch.h.
708
709 2019-08-01 Christian Biesinger <cbiesinger@google.com>
710
711 * s12z-tdep.c: Fix include path for s12z-opc.h.
712
713 2019-08-01 Alan Hayward <alan.hayward@arm.com>
714
715 * NEWS: Require GNU make 3.82.
716
717 2019-07-16 Tom Tromey <tom@tromey.com>
718
719 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
720 declare.
721
722 2019-07-30 Tom Tromey <tromey@adacore.com>
723
724 * block.c (contained_in): Remove BLOCK_FUNCTION check.
725
726 2019-07-30 Kevin Buettner <kevinb@redhat.com>
727
728 * printcmd.c (print_address_symbolic): Print negative offsets.
729 (build_address_symbolic): Force signed arithmetic when computing
730 offset.
731
732 2019-07-30 Christian Biesinger <cbiesinger@google.com>
733
734 PR/24474: Add a function to lookup static variables.
735 * NEWS: Mention this new function.
736 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
737 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
738 * python/python.c (python_GdbMethods): Add new function.
739
740 2019-07-29 Christian Biesinger <cbiesinger@google.com>
741
742 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
743 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
744 (objfpy_lookup_static_symbol): New function.
745 (objfile_object_methods): Add new functions.
746
747 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
748
749 * NEWS: Mention 'set|show print frame-info'. Mention new
750 'presence' value for 'frame-arguments'. Mention new '-frame-info'
751 backtrace argument. Mention that python frame filtering code
752 is now consistent with what 'backtrace' command prints.
753
754 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
755
756 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
757 comments.
758 (print_frame_info_auto, print_frame_info_source_line,
759 print_frame_info_location, print_frame_info_source_and_location,
760 print_frame_info_location_and_address, print_frame_info_short_location):
761 New declarations.
762 (struct frame_print_options): New member print_frame_info.
763 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
764 * stack.h (get_user_print_what_frame_info): New declaration.
765 (frame_show_address): New declaration.
766 * stack.c (print_frame_arguments_choices): New value 'presence'.
767 (print_frame_info_auto, print_frame_info_source_line,
768 print_frame_info_location, print_frame_info_source_and_location,
769 print_frame_info_location_and_address, print_frame_info_short_location,
770 print_frame_info_choices, print_frame_info_print_what): New definitions.
771 (print_frame_args): Only print dots for args if print frame-arguments
772 is 'presence'.
773 (frame_print_option_defs): New element for "frame-info".
774 (get_user_print_what_frame_info): New function.
775 (frame_show_address): Make non static. Move comment to stack.h.
776 (print_frame_info_to_print_what): New function.
777 (print_frame_info): Update comment. Use fp_opts.print_frame_info
778 to decide what to print.
779 (backtrace_command_1): Handle the new print_frame_arguments_presence
780 value.
781 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
782 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
783 (py_print_frame): In non-mi mode, use LOCATION as default for
784 print_what, similarly to frame information printed directly by
785 backtrace command. Handle frame-info user option in non MI mode.
786
787 2019-07-27 Kevin Buettner <kevinb@redhat.com>
788
789 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
790 Add case for debugging 32-bit target on 64-bit host. Revise
791 comment.
792
793 2019-07-27 Kevin Buettner <kevinb@redhat.com>
794
795 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
796 instead of find_function_entry_range_from_pc.
797
798 2019-07-27 Kevin Buettner <kevinb@redhat.com>
799
800 * stack.c (find_frame_funname): Remove code which preferred
801 minsym over symtab sym in "certain pathological cases".
802
803 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
804 parameter. Change type of "do_demangle" to bool.
805 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
806 Pass suitable "prefer_sym_over_minsym" flag to
807 build_address_symbolic(). Don't output "+" for negative offsets.
808 * printcmd.c (print_address_symbolic): Update invocation of
809 build_address_symbolic to include a "prefer_sym_over_minsym"
810 flag.
811 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
812 Restrict cases in which use of minimal symbol is preferred to that
813 of a found symbol. Update comments.
814
815 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
816 for entry pc when entry pc is out of range for that FDE.
817
818 2019-07-26 Brian Callahan <bcallah@openbsd.org>
819
820 PR gdb/24839:
821 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
822 type.
823
824 2019-07-25 Christian Biesinger <cbiesinger@google.com>
825
826 * python/py-objfile.c (add_separate_debug_file): Fix comment about
827 this function's Python signature.
828
829
830 2019-07-24 Christian Biesinger <cbiesinger@google.com>
831
832 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
833 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
834 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
835 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
836 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
837
838
839 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
840
841 * h8300-tdep.c (h8300_register_name_common): New.
842 h8300_register_name): Use h8300_register_name_common.
843 (h8300s_register_name): Likewise.
844 (h8300sx_register_name): Likewise.
845 (h8300h_register_nam): New.
846 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
847
848
849 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
850
851 * arm-tdep.c (arm_skip_cmse_entry): New function.
852 (arm_is_sgstubs_section): New function.
853 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
854
855 2019-07-22 Tom Tromey <tom@tromey.com>
856
857 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
858 Don't self-assign.
859
860 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
861
862 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
863 type_print.
864
865 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
866
867 * symtab.c (search_symbols): Adjust msymbol matching type arrays
868 so that GDB doesn't match any msymbols when searching in the
869 TYPES_DOMAIN.
870 (print_symbol_info): Print using typedef_print or type_print based
871 on the type of the symbol. Add updated FIXME comment moved from...
872 (_initialize_symtab): ... move and update FIXME comment to above.
873
874 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
875
876 * NEWS: Mention adding -q option to "info types".
877 * symtab.c (struct info_types_options): New struct.
878 (info_types_options_defs): New variable.
879 (make_info_types_options_def_group): New function.
880 (info_types_command): Use gdb::option framework to parse options.
881 (info_types_command_completer): New function.
882 (_initialize_symtab): Extend the help text on "info types" and
883 register command completer.
884
885 2019-07-21 Christian Biesinger <cbiesinger@google.com>
886
887 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
888 (lookup_symbol_in_objfile): Change int to block_enum and add a
889 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
890
891 2019-07-20 Christian Biesinger <cbiesinger@google.com>
892
893 * MAINTAINERS (Write After Approval): Add self.
894
895 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
896
897 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
898 instruction to the dummy code region.
899
900 2019-07-19 Tom Tromey <tromey@adacore.com>
901
902 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
903 (ARGSUSED, PARAMS, __func__): Remove rules.
904
905 2019-07-19 Alan Hayward <alan.hayward@arm.com>
906
907 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
908 * features/arm/arm-with-iwmmxt.c: Remove.
909 * features/arm/arm-with-iwmmxt.xml: Remove.
910 * features/arm/arm-with-m-fpa-layout.c: Remove.
911 * features/arm/arm-with-m-fpa-layout.xml: Remove.
912 * features/arm/arm-with-m-vfp-d16.c: Remove.
913 * features/arm/arm-with-m-vfp-d16.xml: Remove.
914 * features/arm/arm-with-m.c: Remove.
915 * features/arm/arm-with-m.xml: Remove.
916 * features/arm/arm-with-neon.c: Remove.
917 * features/arm/arm-with-neon.xml: Remove.
918 * features/arm/arm-with-vfpv2.c: Remove.
919 * features/arm/arm-with-vfpv2.xml: Remove.
920 * features/arm/arm-with-vfpv3.c: Remove.
921 * features/arm/arm-with-vfpv3.xml: Remove.
922
923 2019-07-19 Alan Hayward <alan.hayward@arm.com>
924
925 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
926
927 2019-07-19 Alan Hayward <alan.hayward@arm.com>
928
929 * arch/aarch32.c (aarch32_create_target_description): Create
930 target descriptions using features.
931 * arch/arm.c (arm_create_target_description)
932 (arm_create_mprofile_target_description): Likewise.
933 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
934
935 2019-07-19 Alan Hayward <alan.hayward@arm.com>
936
937 * Makefile.in: Add new files.
938 * aarch32-tdep.c: New file.
939 * aarch32-tdep.h: New file.
940 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
941 Call aarch32_read_description.
942 * arch/aarch32.c: New file.
943 * arch/aarch32.h: New file.
944 * arch/arm.c (arm_create_target_description)
945 (arm_create_mprofile_target_description): New function.
946 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
947 (arm_create_target_description)
948 (arm_create_mprofile_target_description): New declaration.
949 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
950 read_description functions.
951 * arm-linux-nat.c (arm_linux_nat_target::read_description):
952 Likewise.
953 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
954 * arm-tdep.c (tdesc_arm_list): New variable.
955 (arm_register_g_packet_guesses): Call create description functions.
956 (arm_read_description) (arm_read_mprofile_description): New
957 function.
958 * arm-tdep.h (arm_read_description)
959 (arm_read_mprofile_description): Add declaration.
960 * configure.tgt: Add new files.
961
962 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
963
964 * top.c (new_ui_command): Open specified terminal just once.
965
966 2019-07-18 Tom Tromey <tromey@adacore.com>
967
968 * symtab.c (main_name): Constify return type.
969 * symfile.c (set_initial_language): Update.
970 * symtab.h (main_name): Constify return type.
971
972 2019-07-17 Tom Tromey <tom@tromey.com>
973
974 * tui/tui-winsource.c (tui_update_source_window)
975 (tui_update_source_window_as_is)
976 (tui_update_source_windows_with_line): Remove return.
977 * tui/tui-disasm.c (tui_show_disassem)
978 (tui_show_disassem_and_update_source): Remove return.
979 * tui/tui.c (tui_reset): Remove return.
980 * tui/tui-wingeneral.c
981 (tui_check_and_display_highlight_if_needed): Remove return.
982
983 2019-07-17 Tom Tromey <tom@tromey.com>
984
985 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
986
987 2019-07-17 Tom Tromey <tom@tromey.com>
988
989 * tui/tui-winsource.h (struct tui_exec_info_window)
990 (struct tui_source_window_base): Move from tui-data.h.
991 * tui/tui-winsource.c: Move many method definitions from
992 elsewhere. Remove "structuring" comments.
993 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
994 (tui_source_window_base::refresh_window): Move to
995 tui-winsource.c.
996 * tui/tui-win.c (tui_source_window_base::refresh_all)
997 (tui_source_window_base::update_tab_width)
998 (tui_source_window_base::set_new_height)
999 (tui_source_window_base::do_make_visible_with_new_height): Move to
1000 tui-winsource.c.
1001 * tui/tui-source.h: Update.
1002 * tui/tui-source.c (tui_source_window_base::reset): Move to
1003 tui-winsource.c.
1004 * tui/tui-disasm.h: Update.
1005 * tui/tui-data.h (struct tui_exec_info_window): Move to
1006 tui-winsource.h.
1007 (struct tui_source_window_base): Likewise.
1008 * tui/tui-data.c (tui_source_window_base::clear_detail)
1009 (tui_source_window_base, ~tui_source_window_base): Move to
1010 tui-winsource.c.
1011
1012 2019-07-17 Tom Tromey <tom@tromey.com>
1013
1014 * tui/tui-win.c (tui_resize_all)
1015 (tui_source_window_base::update_tab_width)
1016 (tui_adjust_win_heights): Update.
1017 (tui_win_info::make_invisible_and_set_new_height): Rename from
1018 make_invisible_and_set_new_height.
1019 * tui/tui-data.h (struct tui_win_info)
1020 <make_invisible_and_set_new_height>: New method.
1021
1022 2019-07-17 Tom Tromey <tom@tromey.com>
1023
1024 * tui/tui.c: Update.
1025 * tui/tui-source.h (struct tui_source_window): Move from
1026 tui-data.h.
1027 * tui/tui-layout.c: Update.
1028 * tui/tui-disasm.c: Update.
1029 * tui/tui-data.h (struct tui_source_window): Move to
1030 tui-source.h.
1031
1032 2019-07-17 Tom Tromey <tom@tromey.com>
1033
1034 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1035 tui-data.h.
1036 * tui/tui-data.h (struct tui_disasm_window): Move to
1037 tui-disasm.h.
1038
1039 2019-07-17 Tom Tromey <tom@tromey.com>
1040
1041 * tui/tui-regs.h (struct tui_data_item_window): Move from
1042 tui-data.h.
1043 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1044 * tui/tui-data.h (struct tui_data_item_window): Move to
1045 tui-regs.h.
1046 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1047
1048 2019-07-17 Tom Tromey <tom@tromey.com>
1049
1050 * tui/tui.c: Update.
1051 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1052 (tui_cmd_window::max_height): Move to tui-command.c.
1053 * tui/tui-layout.c: Update.
1054 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1055 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1056 tui-command.c.
1057 * tui/tui-command.h (struct tui_cmd_window): Move from
1058 tui-data.h.
1059 * tui/tui-command.c: Remove "structuring" comments.
1060 (tui_cmd_window::clear_detail)
1061 (tui_cmd_window::do_make_visible_with_new_height)
1062 (tui_cmd_window::max_height): Move from elsewhere.
1063
1064 2019-07-17 Tom Tromey <tom@tromey.com>
1065
1066 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1067 Now static.
1068 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1069 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1070
1071 2019-07-17 Tom Tromey <tom@tromey.com>
1072
1073 * tui/tui.c: Update.
1074 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1075 tui-regs.c.
1076 * tui/tui-windata.h: Remove file.
1077 * tui/tui-windata.c: Remove file.
1078 * tui/tui-win.c (tui_data_window::set_new_height)
1079 (tui_data_window::do_make_visible_with_new_height): Move to
1080 tui-regs.c.
1081 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1082 * tui/tui-regs.c: Remove "structuring" comments.
1083 (tui_data_window::first_data_item_displayed)
1084 (tui_data_window::delete_data_content_windows)
1085 (tui_data_window::erase_data_content)
1086 (tui_data_window::display_all_data)
1087 (tui_data_window::refresh_all)
1088 (tui_data_window::do_scroll_vertical)
1089 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1090 (tui_data_window::do_make_visible_with_new_height)
1091 (tui_data_window::refresh_window): Move from elsewhere.
1092 (_initialize_tui_regs): Move to end of file.
1093 * tui/tui-layout.c: Update.
1094 * tui/tui-hooks.c: Update.
1095 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1096 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1097 tui-regs.c.
1098 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1099
1100 2019-07-17 Tom Tromey <tom@tromey.com>
1101
1102 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1103 seen.
1104
1105 2019-07-17 Tom Tromey <tom@tromey.com>
1106
1107 * tui/tui-win.c (tui_source_window_base::set_new_height)
1108 (tui_source_window_base::do_make_visible_with_new_height): Use
1109 m_has_locator field directly.
1110 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1111 method.
1112 (struct tui_source_window_base) <has_locator>: Likewise.
1113
1114 2019-07-17 Tom Tromey <tom@tromey.com>
1115
1116 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1117 Don't declare.
1118 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1119 Remove.
1120 * tui/tui-win.c (tui_source_window_base::set_new_height)
1121 (tui_source_window_base::set_new_height)
1122 (make_invisible_and_set_new_height)
1123 (tui_source_window_base::do_make_visible_with_new_height)
1124 (tui_source_window_base::do_make_visible_with_new_height):
1125 Update.
1126 * tui/tui-layout.c (show_source_disasm_command, show_data)
1127 (show_source_or_disasm_and_command): Update.
1128 * tui/tui-layout.c (show_layout): Update.
1129
1130 2019-07-17 Tom Tromey <tom@tromey.com>
1131
1132 * tui/tui-layout.c (make_data_window): Remove.
1133 (show_data): Unify creation and re-initialization cases.
1134
1135 2019-07-17 Tom Tromey <tom@tromey.com>
1136
1137 * tui/tui-layout.c (make_source_window, make_disasm_window):
1138 Remove.
1139 (show_data): Unify creation and re-initialization cases.
1140
1141 2019-07-17 Tom Tromey <tom@tromey.com>
1142
1143 * tui/tui-layout.c (make_command_window): Remove.
1144 (show_source_disasm_command, show_source_or_disasm_and_command):
1145 Unify creation and re-initialization cases.
1146
1147 2019-07-17 Tom Tromey <tom@tromey.com>
1148
1149 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1150 creation and re-initialization cases.
1151
1152 2019-07-17 Tom Tromey <tom@tromey.com>
1153
1154 * tui/tui-regs.c (tui_get_register): Return void.
1155
1156 2019-07-17 Tom Tromey <tom@tromey.com>
1157
1158 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1159 Simplify.
1160
1161 2019-07-17 Tom Tromey <tom@tromey.com>
1162
1163 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1164 resetting.
1165
1166 2019-07-17 Tom Tromey <tom@tromey.com>
1167
1168 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1169 * tui/tui-regs.c (tui_reg_layout): New function.
1170 (tui_show_registers, tui_reg_command): Use it.
1171 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1172 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1173 parameters.
1174 (tui_layout_command): Remove.
1175
1176 2019-07-17 Tom Tromey <tom@tromey.com>
1177
1178 * tui/tui-layout.h (tui/tui-layout): Return void.
1179 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1180
1181 2019-07-17 Tom Tromey <tom@tromey.com>
1182
1183 * tui/tui-layout.c (show_source_disasm_command, show_data):
1184 Update.
1185 (reset_locator): Remove.
1186 (show_source_or_disasm_and_command): Update.
1187
1188 2019-07-17 Tom Tromey <tom@tromey.com>
1189
1190 * tui/tui-source.c (tui_source_window_base::reset): Remove
1191 win_type parameter.
1192 * tui/tui-layout.c (make_command_window, make_source_window)
1193 (make_disasm_window, make_data_window)
1194 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1195 (reset_locator, show_source_or_disasm_and_command): Update.
1196 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1197 win_type parameter.
1198 (struct tui_source_window_base) <reset>: Likewise.
1199
1200 2019-07-17 Tom Tromey <tom@tromey.com>
1201
1202 * tui/tui-layout.c (show_source_disasm_command): Use
1203 reset_locator.
1204 (reset_locator): New function.
1205 (init_and_make_win): Remove.
1206 (show_source_or_disasm_and_command): Use reset_locator.
1207
1208 2019-07-17 Tom Tromey <tom@tromey.com>
1209
1210 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1211 condition.
1212 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1213 Remove condition.
1214 * tui/tui-source.c (tui_source_window_base::reset): New method.
1215 * tui/tui-layout.c (make_command_window): Don't call
1216 init_and_make_win.
1217 (make_source_window, make_disasm_window): Don't call
1218 make_source_or_disasm_window.
1219 (make_data_window): Don't call init_and_make_win. Change calling
1220 convention.
1221 (show_source_disasm_command, show_data): Simplify.
1222 (make_source_or_disasm_window): Remove.
1223 (show_source_or_disasm_and_command): Simplify.
1224 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1225 (struct tui_source_window_base) <reset>: Likewise.
1226 <execution_info>: Remove initializer.
1227 * tui/tui-data.c (tui_source_window_base): Initialize
1228 execution_info.
1229
1230 2019-07-17 Tom Tromey <tom@tromey.com>
1231
1232 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1233 variable.
1234
1235 2019-07-17 Tom Tromey <tom@tromey.com>
1236
1237 * tui/tui.c (tui_rl_other_window): Update.
1238 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1239 superclass method first. Always iterate over regs_content.
1240 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1241 method.
1242 * tui/tui-win.c (tui_set_focus_command): Update.
1243
1244 2019-07-17 Tom Tromey <tom@tromey.com>
1245
1246 * tui/tui-win.c (tui_set_focus_command): Rename from
1247 tui_set_focus. Call tui_enable.
1248 (tui_set_focus_command): Remove.
1249
1250 2019-07-17 Tom Tromey <tom@tromey.com>
1251
1252 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1253 refresh_window.
1254 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1255 touchwin.
1256 (tui_data_window::refresh_window): Call refresh_window on data
1257 items. Always call superclass refresh_window.
1258 (tui_win_info::refresh): Remove.
1259 (tui_source_window_base::refresh_window): Update.
1260 (tui_refresh_all): Update.
1261 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1262 refresh_window.
1263 (show_source_or_disasm_and_command): Likewise.
1264 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1265 (struct tui_source_window_base) <refresh>: Likewise.
1266
1267 2019-07-17 Tom Tromey <tom@tromey.com>
1268
1269 * tui/tui-winsource.c (tui_clear_source_content)
1270 (tui_show_source_content): Update.
1271 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1272 whether content is empty.
1273 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1274 Remove.
1275
1276 2019-07-17 Tom Tromey <tom@tromey.com>
1277
1278 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1279 window's contents.
1280 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1281 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1282
1283 2019-07-17 Tom Tromey <tom@tromey.com>
1284
1285 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1286 (struct tui_data_item_window): Update.
1287
1288 2019-07-17 Tom Tromey <tom@tromey.com>
1289
1290 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1291 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1292 defines.
1293
1294 2019-07-17 Tom Tromey <tom@tromey.com>
1295
1296 * tui/tui-winsource.h (tui_erase_source_content)
1297 (tui_clear_source_content): Remove "display_prompt" parameter.
1298 * tui/tui-winsource.c (tui_update_source_window_as_is)
1299 (tui_update_source_windows_with_addr): Update.
1300 (tui_clear_source_content): Remove "display_prompt" parameter.
1301 (tui_erase_source_content): Likewise. Simplify.
1302 (tui_show_source_content): Update.
1303 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1304 * tui/tui-stack.c (tui_show_frame_info): Update.
1305 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1306 Remove defines.
1307
1308 2019-07-17 Tom Tromey <tom@tromey.com>
1309
1310 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1311 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1312 parameter.
1313 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1314 parameter.
1315
1316 2019-07-17 Tom Tromey <tom@tromey.com>
1317
1318 * tui/tui-winsource.c (tui_clear_source_content)
1319 (tui_show_source_content, tui_show_exec_info_content)
1320 (tui_clear_exec_info_content): Update.
1321 * tui/tui-stack.c (tui_show_locator_content): Update.
1322 (tui_show_frame_info): Update.
1323 * tui/tui-source.h (tui_source_window): Don't declare.
1324 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1325 from tui_source_is_displayed.
1326 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1327 Remove field.
1328 (struct tui_source_window_base) <content_in_use>: New field. Now
1329 bool.
1330 (struct tui_source_window) <showing_source_p>: New method.
1331 (TUI_SRC_WIN): Change cast.
1332 * tui/tui-data.c (tui_initialize_static_data): Update.
1333
1334 2019-07-17 Tom Tromey <tom@tromey.com>
1335
1336 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1337 location_matches_p.
1338 * tui/tui-source.c (tui_source_window::location_matches_p): New
1339 method.
1340 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1341 method.
1342 * tui/tui-data.h (struct tui_source_window_base)
1343 <location_matches_p>: New method.
1344 (struct tui_source_window, struct tui_disasm_window)
1345 <location_matches_p>: Likewise.
1346
1347 2019-07-17 Tom Tromey <tom@tromey.com>
1348
1349 * tui/tui-win.c (tui_set_win_height_command): Rename from
1350 tui_set_win_height.
1351 (tui_set_win_height_command): Remove.
1352
1353 2019-07-17 Tom Tromey <tom@tromey.com>
1354
1355 * tui/tui-source.c (tui_source_window): New constructor. Add
1356 observer.
1357 (~tui_source_window): New destructor.
1358 (tui_source_window::style_changed): New method.
1359 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1360 (tui_attach_detach_observers): Update.
1361 * tui/tui-data.h (struct tui_source_window): Make constructor not
1362 inline. Add destructor.
1363 (struct tui_source_window) <style_changed>: New method.
1364 <m_observable>: New member.
1365
1366 2019-07-17 Tom Tromey <tom@tromey.com>
1367
1368 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1369 * tui/tui-win.c (tui_resize_all): Fix typo.
1370
1371 2019-07-17 Tom Tromey <tom@tromey.com>
1372
1373 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1374 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1375 (tui_refresh_all): Remove "list" parameter. Use foreach.
1376 * tui/tui-win.c (window_name_completer): Use foreach.
1377 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1378 (update_tab_width): Likewise.
1379 * tui/tui-layout.c (show_layout): Update.
1380 * tui/tui-data.h (class tui_window_iterator): New.
1381 (struct all_tui_windows): New.
1382 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1383
1384 2019-07-17 Tom Tromey <tom@tromey.com>
1385
1386 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1387 parameter. Don't reference globals.
1388 (tui_reg_command): Update.
1389
1390 2019-07-17 Tom Tromey <tom@tromey.com>
1391
1392 * tui/tui-regs.c (tui_show_registers): Simplify.
1393
1394 2019-07-17 Tom Tromey <tom@tromey.com>
1395
1396 * tui/tui-regs.c (tui_show_registers): Update.
1397 (tui_show_register_group): Add win_info parameter.
1398
1399 2019-07-17 Tom Tromey <tom@tromey.com>
1400
1401 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1402 Rename from tui_display_reg_element_at_line.
1403 (tui_data_window::display_registers_from_line): Update.
1404 * tui/tui-data.h (struct tui_data_window)
1405 <display_reg_element_at_line>: New method.
1406
1407 2019-07-17 Tom Tromey <tom@tromey.com>
1408
1409 * tui/tui-regs.h (tui_display_registers_from)
1410 (tui_display_registers_from_line): Don't declare.
1411 * tui/tui-windata.c (tui_data_window::display_all_data)
1412 (tui_data_window::refresh_all)
1413 (tui_data_window::do_scroll_vertical): Update.
1414 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1415 from tui_display_registers_from.
1416 (tui_display_reg_element_at_line): Update.
1417 (tui_data_window::display_registers_from_line): Rename from
1418 tui_display_registers_from_line.
1419 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1420 display_registers_from_line>: New methods.
1421
1422 2019-07-17 Tom Tromey <tom@tromey.com>
1423
1424 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1425 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1426 from tui_erase_data_content.
1427 (tui_data_window::display_all_data)
1428 (tui_data_window::refresh_all)
1429 (tui_data_window::do_scroll_vertical): Update.
1430 * tui/tui-regs.c (tui_show_registers): Update.
1431 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1432 New method.
1433
1434 2019-07-17 Tom Tromey <tom@tromey.com>
1435
1436 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1437 declare.
1438 * tui/tui-windata.c
1439 (tui_data_window::delete_data_content_windows): Rename from
1440 tui_delete_data_content_windows.
1441 (tui_data_window::display_all_data)
1442 (tui_data_window::do_scroll_vertical): Update.
1443 * tui/tui-data.h (struct tui_data_window)
1444 <delete_data_content_windows>: New method.
1445
1446 2019-07-17 Tom Tromey <tom@tromey.com>
1447
1448 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1449 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1450
1451 2019-07-17 Tom Tromey <tom@tromey.com>
1452
1453 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1454 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1455 from tui_display_all_data.
1456 * tui/tui-win.c
1457 (tui_data_window::do_make_visible_with_new_height): Update.
1458 * tui/tui-regs.c (tui_show_registers): Update.
1459 * tui/tui-layout.c (tui_set_layout): Update.
1460 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1461 method.
1462
1463 2019-07-17 Tom Tromey <tom@tromey.com>
1464
1465 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1466 * tui/tui-windata.c (tui_display_data_from): Remove.
1467 (tui_data_window::refresh_all): Update.
1468
1469 2019-07-17 Tom Tromey <tom@tromey.com>
1470
1471 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1472 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1473 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1474 tui_display_registers_from_line.
1475 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1476 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1477 "force_display" parameter.
1478
1479 2019-07-17 Tom Tromey <tom@tromey.com>
1480
1481 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1482 declare.
1483 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1484 Rename from tui_first_reg_element_no_inline.
1485 (tui_display_reg_element_at_line)
1486 (tui_display_registers_from_line): Update.
1487 * tui/tui-data.h (struct tui_data_window)
1488 <first_reg_element_no_inline>: New method.
1489
1490 2019-07-17 Tom Tromey <tom@tromey.com>
1491
1492 * tui/tui-windata.c (tui_display_data_from)
1493 (tui_data_window::do_scroll_vertical): Update.
1494 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1495 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1496 Rename from tui_line_from_reg_element_no.
1497 (tui_display_registers_from_line): Update.
1498 * tui/tui-data.h (struct tui_data_window)
1499 <line_from_reg_element_no>: New method.
1500
1501 2019-07-17 Tom Tromey <tom@tromey.com>
1502
1503 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1504 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1505 tui_last_regs_line_no.
1506 (tui_display_reg_element_at_line)
1507 (tui_display_registers_from_line): Update.
1508 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1509 method.
1510
1511 2019-07-17 Tom Tromey <tom@tromey.com>
1512
1513 PR tui/24722:
1514 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1515 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1516 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1517 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1518 (tui_update_breakpoint_info): Likewise.
1519 * tui/tui-hooks.c (tui_event_create_breakpoint)
1520 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1521 Update.
1522
1523 2019-07-17 Tom Tromey <tom@tromey.com>
1524
1525 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1526
1527 2019-07-17 Tom Tromey <tom@tromey.com>
1528
1529 * tui/tui-winsource.c (tui_update_source_window_as_is)
1530 (tui_update_source_windows_with_addr): Update.
1531 * tui/tui-source.h (tui_set_source_content)
1532 (tui_show_symtab_source): Add "win_info" parameter.
1533 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1534 parameter.
1535 (tui_show_symtab_source): Likewise.
1536
1537 2019-07-17 Tom Tromey <tom@tromey.com>
1538
1539 * tui/tui-wingeneral.c
1540 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1541
1542 2019-07-17 Tom Tromey <tom@tromey.com>
1543
1544 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1545 (struct tui_cmd_window) <can_scroll>: New method.
1546 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1547 method.
1548
1549 2019-07-17 Tom Tromey <tromey@adacore.com>
1550
1551 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1552 do_field_signed>: Rename. Change type of "value".
1553 * ui-out.c (ui_out::field_signed): Rename from field_int.
1554 Change type of "value".
1555 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1556 type of "value".
1557 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1558 do_field_int. Change type of "value".
1559 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1560 do_field_int. Change type of "value".
1561 * tracepoint.c (trace_status_mi, tfind_1)
1562 (print_one_static_tracepoint_marker): Update.
1563 * thread.c (print_thread_info_1, print_selected_thread_frame):
1564 Update.
1565 * stack.c (print_frame, print_frame_info): Update.
1566 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1567 Update.
1568 * source.c (print_source_lines_base): Update.
1569 * skip.c (info_skip_command): Update.
1570 * record-btrace.c (btrace_ui_out_decode_error)
1571 (btrace_call_history_src_line): Update.
1572 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1573 Update.
1574 * progspace.c (print_program_space): Update.
1575 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1576 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1577 do_field_int. Change type of "value".
1578 * mi/mi-out.c (mi_ui_out::do_table_begin)
1579 (mi_ui_out::do_table_header): Update.
1580 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1581 type of "value".
1582 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1583 (mi_cmd_data_list_changed_registers, output_register)
1584 (mi_cmd_data_read_memory, mi_load_progress)
1585 (mi_cmd_trace_frame_collected): Update.
1586 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1587 Update.
1588 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1589 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1590 (mi_cmd_var_list_children, varobj_update_one): Update.
1591 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1592 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1593 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1594 * inferior.c (print_inferior): Update.
1595 * gdb_bfd.c (print_one_bfd): Update.
1596 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1597 Update.
1598 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1599 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1600 do_field_int. Change type of "value".
1601 * cli-out.c (cli_ui_out::do_field_signed): Rename from
1602 do_field_int. Change type of "value".
1603 * breakpoint.c (watchpoint_check, print_breakpoint_location)
1604 (print_one_breakpoint_location, print_it_catch_fork)
1605 (print_one_catch_fork, print_it_catch_vfork)
1606 (print_one_catch_vfork, print_it_catch_solib)
1607 (print_it_catch_exec, print_it_ranged_breakpoint)
1608 (print_mention_watchpoint, print_mention_masked_watchpoint)
1609 (bkpt_print_it, update_static_tracepoint): Update.
1610 * break-catch-throw.c (print_it_exception_catchpoint): Update.
1611 * break-catch-syscall.c (print_it_catch_syscall): Update.
1612 * ada-tasks.c (print_ada_task_info): Update.
1613 * ada-lang.c (print_it_exception, print_mention_exception):
1614 Update.
1615
1616 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
1617
1618 PR breakpoints/24541
1619 * gdbarch.c: Regenerate.
1620 * gdbarch.h: Regenerate.
1621 * gdbarch.sh: Adjust return type and parameter types for
1622 'stap_adjust_register'.
1623 (i386_stap_adjust_register): Adjust signature and return new
1624 register name.
1625 * stap-probe.c (stap_parse_register_operand): Adjust use of
1626 'gdbarch_stap_adjust_register'.
1627
1628 2019-07-17 Tom Tromey <tromey@adacore.com>
1629
1630 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
1631 declare VEC.
1632 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1633 std::vector.
1634 (struct s390_process_info): Add initializers.
1635 (s390_add_process): Use new.
1636 (s390_linux_nat_target::low_forget_process): Use delete.
1637 (s390_linux_nat_target::low_new_fork)
1638 (s390_linux_nat_target::stopped_by_watchpoint)
1639 (s390_linux_nat_target::low_prepare_to_resume)
1640 (s390_linux_nat_target::insert_watchpoint)
1641 (s390_linux_nat_target::insert_hw_breakpoint)
1642 (s390_linux_nat_target::remove_watchpoint)
1643 (s390_linux_nat_target::remove_hw_breakpoint): Update.
1644
1645 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1646
1647 * aarch64-fbsd-nat.c: Include regcache.h.
1648 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1649 argument.
1650 (aarch64_fbsd_nat_target::fetch_registers)
1651 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1652 variable.
1653 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1654
1655 2019-07-16 John Baldwin <jhb@FreeBSD.org>
1656
1657 * fbsd-nat.c: Include gdbarch.h.
1658
1659 2019-07-15 Tom Tromey <tromey@adacore.com>
1660
1661 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1662
1663 2019-07-15 Tom Tromey <tromey@adacore.com>
1664
1665 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1666 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1667 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1668 * cli-out.c (cli_ui_out::do_field_int): New method.
1669 * ui-out.c (ui_out::field_unsigned): New method.
1670 * symfile.c (generic_load): Use field_unsigned.
1671 (print_transfer_performance): Likewise.
1672 * record-btrace.c (ui_out_field_uint): Remove.
1673 (btrace_call_history_insn_range, btrace_call_history): Use
1674 field_unsigned.
1675 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1676 field_unsigned.
1677 * ui-out.h (class ui_out) <field_unsigned>: New method.
1678 <do_field_unsigned>: Likewise.
1679
1680 2019-07-15 Tom Tromey <tromey@adacore.com>
1681
1682 * mi/mi-main.c (list_available_thread_groups): Use field_string.
1683 * mi/mi-interp.c (mi_memory_changed): Use field_string.
1684 * target.c (flash_erase_command): Use field_string.
1685 * infrun.c (print_signal_received_reason): Use field_string.
1686 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1687 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1688 field_string.
1689 * ada-tasks.c (print_ada_task_info): Use field_string.
1690
1691 2019-07-15 Tom Tromey <tromey@adacore.com>
1692
1693 * target.c (flash_erase_command): Use field_core_addr.
1694 * symfile.c (generic_load): Use field_core_addr.
1695 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1696 Use field_core_addr.
1697 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1698 field_core_addr.
1699
1700 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1701
1702 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1703 value if its desired type is smaller than a CORE_ADDR and signed.
1704
1705 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1706
1707 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1708 of changes to field names, and use new is_reference field to
1709 decide if a property is a reference or not.
1710 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1711 field.
1712 (struct dwarf2_property_baton): Update header comment, rename
1713 'referenced_type' to 'property_type' and update comments.
1714 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1715 default property type, store in property baton, update to take
1716 accound of renamed field.
1717 (read_func_scope): Update call to attr_to_dynamic_prop.
1718 (read_array_type): Likewise.
1719 (dwarf2_per_cu_addr_sized_int_type): New function.
1720 (read_subrange_index_type): Move type finding code to
1721 dwarf2_per_cu_addr_sized_int_type.
1722 (read_subrange_type): Update calls to attr_to_dynamic_prop.
1723 (dwarf2_per_cu_addr_type): New function.
1724 (set_die_type): Update calls to attr_to_dynamic_prop.
1725
1726 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1727
1728 * dwarf2read.c (read_subrange_index_type): New function.
1729 (read_subrange_type): Move code into new function and call it.
1730 * gdbtypes.c (create_range_type): Add some asserts.
1731
1732 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1733
1734 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1735 update return statements.
1736 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1737 declaration, and update comment to match.
1738 * gdbtypes.c (resolve_dynamic_array): Update call to
1739 dwarf2_evaluate_property to match new return type.
1740
1741 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
1742
1743 * valarith.c (value_subscripted_rvalue): Change lowerbound
1744 parameter type from int to LONGEST.
1745 * value.h (value_subscripted_rvalue): Likewise in declaration.
1746
1747 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1748
1749 * cli/cli-utils.c (info_print_command_completer): New function.
1750 * cli/cli-utils.h: Add 'completer.h' include, and forward
1751 declaration for 'struct cmd_list_element'.
1752 (info_print_command_completer): Declare.
1753 * stack.c (_initialize_stack): Add completer for 'info locals' and
1754 'info args'.
1755 * symtab.c (_initialize_symtab): Add completer for 'info
1756 variables' and 'info functions'.
1757 * NEWS: Mention completion for additional info commands.
1758
1759 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1760
1761 * cli/cli-utils.c (extract_info_print_args): Delete.
1762 (extract_arg_maybe_quoted): Delete.
1763 (info_print_options_defs): New variable.
1764 (make_info_print_options_def_group): New function.
1765 (extract_info_print_options): Define new function.
1766 * cli/cli-utils.h (extract_info_print_args): Delete.
1767 (struct info_print_options): New structure.
1768 (extract_info_print_options): Declare new function.
1769 * stack.c (info_locals_command): Update to use new
1770 extract_info_print_options, also add a header comment.
1771 (info_args_command): Likewise.
1772 * symtab.c (info_variables_command): Likewise.
1773 (info_functions_command): Likewise.
1774
1775 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
1776
1777 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1778 to extract string arguments.
1779 * common/common-utils.c (extract_string_maybe_quoted): New function.
1780 * common/common-utils.h (extract_string_maybe_quoted): Declare.
1781
1782 2019-07-11 Tom Tromey <tromey@adacore.com>
1783
1784 * main.c (get_init_files): Use GDBINIT, not gdbinit.
1785 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1786 * top.h (gdbinit): Don't declare.
1787 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1788 into...
1789 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
1790 * top.c (gdb_init): Don't call init_cli_cmds.
1791 (gdbinit): Remove.
1792 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1793
1794 2019-07-11 Tom Tromey <tromey@adacore.com>
1795
1796 * python/py-inferior.c (add_thread_object): Don't use thread_obj
1797 after it has been moved.
1798
1799 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1800
1801 * valops.c (value_must_coerce_to_target): Change return type to
1802 bool.
1803 * value.h (value_must_coerce_to_target): Likewise.
1804
1805 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
1806
1807 * breakpoint.c (is_hardware_watchpoint): Remove
1808 forward-declaration.
1809 (is_masked_watchpoint): Change return type to bool.
1810 (is_tracepoint): Likewise.
1811 (is_breakpoint): Likewise.
1812 (is_hardware_watchpoint): Likewise.
1813 (is_watchpoint): Likewise.
1814 (is_no_memory_software_watchpoint): Likewise.
1815 (is_catchpoint): Likewise.
1816 (breakpoint_1): Make FILTER parameter's return type bool.
1817 is_masked_watchpoint): Change return type to bool.
1818 (save_breakpoints): Make FILTER parameter's return type bool.
1819 * breakpoint.h (is_breakpoint): Change return type to bool.
1820 (is_watchpoint): Likewise.
1821 (is_catchpoint): Likewise.
1822 (is_tracepoint): Likewise.
1823
1824 2019-07-10 Tom Tromey <tom@tromey.com>
1825
1826 * defs.h: Don't include gdbarch.h.
1827 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1828 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1829 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1830 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1831 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1832 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1833 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1834 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1835 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1836 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1837 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1838 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1839 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1840 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1841 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1842 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1843 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1844 record-btrace.c, record.h, regcache-dump.c, regcache.h,
1845 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1846 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1847 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1848 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1849 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1850 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1851 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1852 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1853 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1854
1855 2019-07-10 Tom Tromey <tromey@adacore.com>
1856
1857 * ada-lang.h (is_ada_exception_catchpoint): Declare.
1858 * breakpoint.c (init_ada_exception_breakpoint): Register as
1859 bp_catchpoint.
1860 (print_one_breakpoint_location, print_one_breakpoint): Use
1861 is_ada_exception_catchpoint.
1862 * ada-lang.c (class ada_catchpoint_location): Pass
1863 bp_loc_software_breakpoint to bp_location constructor.
1864 (is_ada_exception_catchpoint): New function.
1865
1866 2019-07-10 Tom Tromey <tromey@adacore.com>
1867
1868 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
1869 VEC.
1870 (struct arm_exidx_entry): New method operator<.
1871 (struct arm_exidx_data) <section_maps>: Change type.
1872 (arm_exidx_data_free): Remove.
1873 (arm_exidx_data_key): Change type. Move lower.
1874 (arm_exidx_new_objfile): Update.
1875 (arm_compare_exidx_entries): Remove.
1876 (arm_find_exidx_entry, _initialize_arm_tdep)
1877
1878 2019-07-10 Tom Tromey <tromey@adacore.com>
1879
1880 * solib-spu.c (ocl_program_data_key): Change type.
1881 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1882 Update.
1883
1884 2019-07-10 Tom Tromey <tromey@adacore.com>
1885
1886 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
1887 (struct solib_aix_inferior_data) <library_list>: Change type.
1888 (solib_aix_inferior_data_handle): Change type.
1889 (get_solib_aix_inferior_data): Update.
1890 (solib_aix_free_library_list): Remove.
1891 (library_list_start_library): Update.
1892 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1893 return type.
1894 (solib_aix_get_library_list)
1895 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1896 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1897
1898 2019-07-10 Tom Tromey <tromey@adacore.com>
1899
1900 * solib-dsbt.c (struct dsbt_info): Add initializers.
1901 (solib_dsbt_pspace_data): Change type.
1902 (dsbt_pspace_data_cleanup): Remove.
1903 (get_dsbt_info, _initialize_dsbt_solib): Update.
1904
1905 2019-07-10 Tom Tromey <tromey@adacore.com>
1906
1907 * spu-tdep.c (spu_overlay_data): Change type.
1908 (spu_get_overlay_table, spu_overlay_new_objfile)
1909 (_initialize_spu_tdep): Update.
1910
1911 2019-07-10 Tom Tromey <tromey@adacore.com>
1912
1913 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1914 destructor.
1915 (dbx_objfile_data_key): Change type and declare later.
1916 (DBX_SYMFILE_INFO): Rewrite.
1917 * dbxread.c (dbx_objfile_data_key): Change type.
1918 (dbx_symfile_init): Update.
1919 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
1920 (coffstab_build_psymtabs, elfstab_build_psymtabs)
1921 (stabsect_build_psymtabs, _initialize_dbxread): Update.
1922
1923 2019-07-10 Tom Tromey <tromey@adacore.com>
1924
1925 * jit.c (jit_program_space_key): Change type. Move lower.
1926 (get_jit_program_space_data): Update.
1927 (jit_program_space_data_cleanup): Remove.
1928 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1929 Update.
1930 (struct jit_program_space_data): Add initializers.
1931
1932 2019-07-10 Tom Tromey <tromey@adacore.com>
1933
1934 * solib-darwin.c (struct darwin_info): Add initializers.
1935 (solib_darwin_pspace_data): Change type.
1936 (darwin_pspace_data_cleanup): Remove.
1937 (get_darwin_info, _initialize_darwin_solib): Update.
1938
1939 2019-07-10 Tom Tromey <tromey@adacore.com>
1940
1941 * remote-sim.c (struct sim_inferior_data): Add initializers,
1942 constructor, and destructor.
1943 (sim_inferior_data_key): Change type. Move lower.
1944 (check_for_duplicate_sim_descriptor): Update.
1945 (get_sim_inferior_data): Use new. Update.
1946 (~sim_inferior_data_cleanup): Rename from
1947 sim_inferior_data_cleanup. Simplify.
1948 (gdbsim_close_inferior, simulator_command)
1949 (sim_command_completer, _initialize_remote_sim): Update.
1950 (next_pid, INITIAL_PID): Move earlier.
1951
1952 2019-07-10 Tom Tromey <tromey@adacore.com>
1953
1954 * python/python-internal.h (create_thread_object): Return
1955 gdbpy_ref.
1956 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1957 * python/py-inferior.c (struct threadlist_entry): Add
1958 constructor.
1959 <thread_obj>: Now a gdbpy_ref.
1960 (thread_to_thread_object): Update.
1961 (add_thread_object): Use new.
1962 (delete_thread_object): Use delete.
1963 (infpy_threads): Update.
1964 (py_free_inferior): Update. Construct "inf_obj" after acquiring
1965 GIL.
1966
1967 2019-07-10 Tom Tromey <tromey@adacore.com>
1968
1969 * valops.c (value_cast): Specialize error message for Ada.
1970
1971 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1972
1973 * breakpoint.c (breakpoint_1): Update doc and parameter names.
1974
1975 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
1976
1977 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1978 bpstat_should_step): Return bool, adjust comments.
1979 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1980 bpstat_should_step): Likewise.
1981
1982 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1983
1984 * features/Makefile: Use feature target descriptions for Arm.
1985 * features/arm/arm-core.c: Generate new file.
1986 * features/arm/arm-fpa.c: Likewise.
1987 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1988 * features/arm/arm-m-profile.c: Likewise.
1989 * features/arm/arm-vfpv2.c: Likewise.
1990 * features/arm/arm-vfpv3.c: Likewise.
1991 * features/arm/xscale-iwmmxt.c: Likewise.
1992 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1993
1994 2019-07-10 Alan Hayward <alan.hayward@arm.com>
1995
1996 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1997 ptrace earlier.
1998
1999 2019-07-10 Alan Hayward <alan.hayward@arm.com>
2000
2001 * features/aarch64-pauth.c: Regenerate.
2002
2003 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2004
2005 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2006 bool.
2007 (bpstat_what): Use false instead of 0.
2008
2009 2019-07-09 Pedro Alves <palves@redhat.com>
2010
2011 * break-catch-throw.c (is_exception_catchpoint): New.
2012 * breakpoint.c (print_one_breakpoint_location): New parameter
2013 'raw_loc'. Handle it. Use
2014 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2015 looking at the breakpoint's type.
2016 (print_one_breakpoint): If handling "maint info breakpoints", also
2017 print locations of exception catchpoints.
2018 * breakpoint.h (is_exception_catchpoint): Declare.
2019
2020 2019-07-09 Pedro Alves <palves@redhat.com>
2021
2022 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2023 "addr" field.
2024 (allocate_location_exception_catchpoint): New.
2025 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2026 (initialize_throw_catchpoint_ops): Install
2027 allocate_location_exception_catchpoint as allocate_location
2028 method.
2029 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2030 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2031 bp_loc_other.
2032 (breakpoint_address_is_meaningful): Delete.
2033 (bl_address_is_meaningful): New.
2034 (breakpoint_locations_match): Adjust comment.
2035 (bp_location_from_bp_type): New, factored out of...
2036 (bp_location::bp_location(breakpoint *)): ... this.
2037 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2038 factored out of...
2039 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2040 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2041 breakpoint_address_is_meaningful.
2042 (bp_locations_compare): Adjust comment.
2043 (update_global_location_list): Use bl_address_is_meaningful
2044 instead of breakpoint_address_is_meaningful.
2045 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2046 explicit.
2047 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2048 * python/py-breakpoint.c (bppy_get_location): No longer check
2049 whether location is null.
2050
2051 2019-07-09 Pedro Alves <palves@redhat.com>
2052
2053 PR c++/15468
2054 * breakpoint.c (print_one_breakpoint_location): Remove
2055 single-location assert.
2056
2057 2019-07-09 Tom Tromey <tom@tromey.com>
2058
2059 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2060 * configure: Rebuild.
2061 * configure.ac: Change common to gdbsupport.
2062 * gdbsupport: Rename from common.
2063 * acinclude.m4: Change common to gdbsupport.
2064 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2065 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2066 gdbsupport.
2067 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2068 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2069 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2070 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2071 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2072 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2073 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2074 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2075 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2076 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2077 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2078 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2079 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2080 coff-pe-read.c, command.h, compile/compile-c-support.c,
2081 compile/compile-c.h, compile/compile-cplus-symbols.c,
2082 compile/compile-cplus-types.c, compile/compile-cplus.h,
2083 compile/compile-loc2c.c, compile/compile.c, completer.c,
2084 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2085 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2086 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2087 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2088 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2089 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2090 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2091 features/aarch64-core.c, features/aarch64-fpu.c,
2092 features/aarch64-pauth.c, features/aarch64-sve.c,
2093 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2094 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2095 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2096 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2097 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2098 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2099 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2100 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2101 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2102 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2103 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2104 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2105 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2106 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2107 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2108 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2109 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2110 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2111 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2112 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2113 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2114 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2115 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2116 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2117 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2118 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2119 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2120 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2121 minsyms.c, mips-linux-tdep.c, namespace.h,
2122 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2123 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2124 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2125 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2126 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2127 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2128 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2129 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2130 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2131 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2132 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2133 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2134 procfs.c, producer.c, progspace.h, psymtab.h,
2135 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2136 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2137 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2138 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2139 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2140 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2141 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2142 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2143 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2144 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2145 target-memory.c, target.c, target.h, target/waitstatus.c,
2146 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2147 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2148 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2149 unittests/array-view-selftests.c,
2150 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2151 unittests/common-utils-selftests.c,
2152 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2153 unittests/format_pieces-selftests.c,
2154 unittests/function-view-selftests.c,
2155 unittests/lookup_name_info-selftests.c,
2156 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2157 unittests/mkdir-recursive-selftests.c,
2158 unittests/observable-selftests.c,
2159 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2160 unittests/parse-connection-spec-selftests.c,
2161 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2162 unittests/scoped_fd-selftests.c,
2163 unittests/scoped_mmap-selftests.c,
2164 unittests/scoped_restore-selftests.c,
2165 unittests/string_view-selftests.c, unittests/style-selftests.c,
2166 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2167 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2168 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2169 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2170 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2171 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2172
2173 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2174
2175 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2176 bool value.
2177 (decode_digits_ordinary): Set explicit_line field in sal.
2178 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2179 symtab_and_line that was set on an explicit line number in
2180 assembler code. Do always update the recorded symtab and line if
2181 we do skip the prologue.
2182
2183 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2184
2185 * breakpoint.c (set_breakpoint_location_function): Remove
2186 explicit_loc parameter.
2187 (momentary_breakpoint_from_master): Update call to
2188 set_breakpoint_location_function.
2189 (add_location_to_breakpoint): Likewise.
2190
2191 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2192
2193 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2194 required features based on default bfd type when no specific bfd
2195 is present.
2196
2197 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2198
2199 * NEWS: Mention that GDB printf and eval commands can now print
2200 C-style and Ada-style convenience var strings without
2201 calling the inferior.
2202 * printcmd.c (printf_c_string): Locally print GDB internal var
2203 instead of transiting via the inferior.
2204 (printf_wide_c_string): Likewise.
2205
2206 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2207
2208 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2209
2210 2019-07-04 Tom Tromey <tom@tromey.com>
2211
2212 PR tui/24724:
2213 * tui/tui-winsource.c (tui_clear_source_content): Update.
2214 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2215 (tui_update_breakpoint_info): Update.
2216 (tui_set_exec_info_content): Update.
2217 * tui/tui-source.c (tui_set_source_content_nil): Update.
2218 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2219 has_break.
2220 * tui/tui-data.h (enum tui_bp_flag): New.
2221 (tui_bp_flags): New enum flags type.
2222 (struct tui_source_element) <break_mode>: Change type. Rename
2223 from has_break.
2224 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2225 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2226 constants.
2227 * tui/tui-winsource.h: Fix comment.
2228
2229 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2230
2231 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2232 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2233 (store_fpregs_to_thread)
2234 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2235 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2236 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2237 (IWMMXT_REGS_SIZE): Add define.
2238 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2239 (fetch_vfp_regs, store_vfp_regs)
2240 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2241 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2242
2243 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2244
2245 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2246 defines.
2247 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2248 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2249 (ARM_INT_REGISTER_SIZE): ...to this.
2250 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2251 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2252 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2253 (arm_linux_collect_gregset, supply_nwfpe_register)
2254 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2255 defines.
2256 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2257 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2258 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2259 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2260 (arm_return_in_memory, arm_store_return_value)
2261 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2262 (arm_record_ld_st_multiple): Likewise.
2263 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2264 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2265
2266 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2267
2268 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2269 AARCH64_DISPLACED_MODIFIED_INSNS.
2270 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2271 (aarch64_displaced_step_copy_insn): Likewise.
2272 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2273 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2274 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2275 ARM_DISPLACED_MODIFIED_INSNS.
2276 * arm-tdep.c (arm_gdbarch_init): Likewise.
2277 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2278 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2279 (struct arm_displaced_step_closure): Use
2280 ARM_DISPLACED_MODIFIED_INSNS.
2281
2282 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2283
2284 * features/Makefile: Remove unused xml files.
2285 * features/aarch64.xml: Remove.
2286 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2287 * features/i386/amd64-avx-avx512.xml: Remove.
2288 * features/i386/amd64-avx-linux.xml: Remove.
2289 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2290 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2291 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2292 * features/i386/amd64-avx-mpx.xml: Remove.
2293 * features/i386/amd64-avx.xml: Remove.
2294 * features/i386/amd64-linux.xml: Remove.
2295 * features/i386/amd64-mpx-linux.xml: Remove.
2296 * features/i386/amd64-mpx.xml: Remove.
2297 * features/i386/amd64.xml: Remove.
2298 * features/i386/i386-avx-avx512-linux.xml: Remove.
2299 * features/i386/i386-avx-avx512.xml: Remove.
2300 * features/i386/i386-avx-linux.xml: Remove.
2301 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2302 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2303 * features/i386/i386-avx-mpx-linux.xml: Remove.
2304 * features/i386/i386-avx-mpx.xml: Remove.
2305 * features/i386/i386-avx.xml: Remove.
2306 * features/i386/i386-linux.xml: Remove.
2307 * features/i386/i386-mmx-linux.xml: Remove.
2308 * features/i386/i386-mmx.xml: Remove.
2309 * features/i386/i386-mpx-linux.xml: Remove.
2310 * features/i386/i386-mpx.xml: Remove.
2311 * features/i386/i386.xml: Remove.
2312 * features/i386/x32-avx-avx512-linux.xml: Remove.
2313 * features/i386/x32-avx-linux.xml: Remove.
2314 * features/i386/x32-linux.xml: Remove.
2315
2316 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2317
2318 * regformats/aarch64.dat: Remove.
2319 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2320 * regformats/i386/amd64-avx-linux.dat: Remove.
2321 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2322 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2323 * regformats/i386/amd64-linux.dat: Remove.
2324 * regformats/i386/amd64-mpx-linux.dat: Remove.
2325 * regformats/i386/amd64.dat: Remove.
2326 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2327 * regformats/i386/i386-avx-linux.dat: Remove.
2328 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2329 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2330 * regformats/i386/i386-linux.dat: Remove.
2331 * regformats/i386/i386-mmx-linux.dat: Remove.
2332 * regformats/i386/i386-mpx-linux.dat: Remove.
2333 * regformats/i386/i386.dat: Remove.
2334 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2335 * regformats/i386/x32-avx-linux.dat: Remove.
2336 * regformats/i386/x32-linux.dat: Remove.
2337
2338 2019-07-04 Alan Hayward <alan.hayward@arm.com>
2339
2340 * aarch64-tdep.c: Remove xml self tests.
2341 * amd64-linux-tdep.c: Likewise.
2342 * amd64-tdep.c: Likewise.
2343 * i386-linux-tdep.c: Likewise.
2344 * i386-tdep.c: Likewise.
2345
2346 2019-07-03 Pedro Alves <palves@redhat.com>
2347
2348 PR cli/24732
2349 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2350 (pipe_cmd_option_defs): New.
2351 (make_pipe_cmd_options_def_group): New.
2352 (pipe_command): Use gdb::option::process_options.
2353 (pipe_command_completer): New function.
2354 (_initialize_cli_cmds): Install completer for "pipe" command.
2355
2356 2019-07-03 Pedro Alves <palves@redhat.com>
2357
2358 * cli/cli-option.c (union option_value) <string>: New field.
2359 (struct option_def_and_value): Add ctor, move ctor, dtor and
2360 use DISABLE_COPY_AND_ASSIGN.
2361 (option_def_and_value::clear_value): New.
2362 (parse_option, save_option_value_in_ctx, get_val_type_str)
2363 (add_setshow_cmds_for_options): Handle var_string.
2364 * cli-option.h (union option_def::var_address) <string>: New
2365 field.
2366 (struct string_option_def): New.
2367 * maint-test-options.c (struct test_options_opts): Add default
2368 ctor and use DISABLE_COPY_AND_ASSIGN.
2369 <string_opt>: New field.
2370 (test_options_opts::~test_options_opts): New.
2371 (test_options_opts::dump): Also dump "-string".
2372 (test_options_option_defs): Install "string.
2373
2374 2019-07-03 Pedro Alves <palves@redhat.com>
2375
2376 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2377 option_value with a null enumeration.
2378 (complete_options): Save the option values in the context.
2379 (save_option_value_in_ctx): New, factored out from ...
2380 (process_options): ... here.
2381 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2382 of the function.
2383 * maint-test-options.c (test_options_opts::dump): New, factored
2384 out from ...
2385 (maintenance_test_options_command_mode): ... here.
2386 (maintenance_test_options_command_completion_result): Delete.
2387 (maintenance_test_options_command_completion_text): Update
2388 comment.
2389 (maintenance_show_test_options_completion_result): Change
2390 prototype. Just print
2391 maintenance_test_options_command_completion_text.
2392 (save_completion_result): New.
2393 (maintenance_test_options_completer_mode): Pass options context to
2394 complete_options, and then save a dump.
2395 (_initialize_maint_test_options): Use add_cmd to install "maint
2396 show test-options-completion-result".
2397
2398 2019-07-03 Pedro Alves <palves@redhat.com>
2399
2400 * NEWS (New commands): Mention "with" and "maint with".
2401 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2402 (with_command, with_command_completer): New.
2403 (pipe_command): Adjust to new repeat_previous
2404 interface.
2405 (_initialize_cli_cmds): Install the "with" command and its "w"
2406 alias.
2407 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2408 declarations.
2409 * cli/cli-setshow.c (parse_cli_var_uinteger)
2410 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2411 argument strings for all var_types.
2412 (get_setshow_command_value_string): New, factored out from ...
2413 (do_show_command): ... this.
2414 * cli/cli-setshow.h: Include <string>.
2415 (get_setshow_command_value_string): Declare.
2416 * command.h (repeat_previous): Now returns const char *. Adjust
2417 comment.
2418 * maint.c: Include "cli/cli-cmds.h".
2419 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2420 (_initialize_maint_cmds): Register the "maintenance with" command.
2421 * top.c (repeat_previous): Move bits from pipe_command here:
2422 Return the saved command line, if any; error out if there's no
2423 command to relaunch.
2424
2425 2019-07-03 Pedro Alves <palves@redhat.com>
2426
2427 * NEWS (New commands): Mention "maint set/show test-settings"
2428 instead of "maint test-settings".
2429 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2430 (maintenance_test_settings_set_list): Rename to ...
2431 (maintenance_set_test_settings_list): ... this.
2432 (maintenance_test_settings_show_list): Rename to ...
2433 (maintenance_show_test_settings_list): ... this.
2434 (maintenance_test_settings_cmd): Delete.
2435 (maintenance_test_settings_set_cmd): ...
2436 (maintenance_set_test_settings_cmd): ... this.
2437 (maintenance_test_settings_show_cmd): ...
2438 (maintenance_show_test_settings_cmd): ... this.
2439 (maintenance_test_settings_show_value_cmd):
2440 (maintenance_show_test_settings_value_cmd): ... this.
2441 (_initialize_maint_test_settings): No longer install the "maint
2442 test-settings" prefix command. Rename "maint test-settings set"
2443 to "maint set test-settings", and "maint test-settings show" to
2444 "maint show test-settings". Adjust all subcommands.
2445
2446 2019-07-03 Pedro Alves <palves@redhat.com>
2447
2448 * maint-test-settings.c: Fix file's intro comment. Replace all
2449 references to "test-options" with references to "test-settings",
2450 in comments.
2451
2452 2019-07-03 Pedro Alves <palves@redhat.com>
2453
2454 * maint-test-settings.c (maintenance_test_settings_xxx)
2455 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2456 New.
2457 (maintenance_test_settings_enums): Use them.
2458 (maintenance_test_settings_enum): Default to
2459 maintenance_test_settings_xxx.
2460 (_initialize_maint_test_settings): Initialize
2461 MAINTENANCE_TEST_SETTINGS_FILENAME.
2462
2463 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2464
2465 * breakpoint.h (remove_breakpoints_inf): Change return type to
2466 void, move function documentation here.
2467 * breakpoint.c (remove_breakpoints_inf): Change return type to
2468 void, move function documentation to header.
2469
2470 2019-07-02 Pedro Alves <palves@redhat.com>
2471
2472 * NEWS (Completion improvements): Mention "info threads".
2473 * thread.c (struct info_threads_opts, info_threads_option_defs)
2474 (make_info_threads_options_def_group): New.
2475 (info_threads_command): Use gdb::option::process_options.
2476 (info_threads_command_completer): New.
2477 (_initialize_thread): Use gdb::option::build_help to build the
2478 help text for "info threads".
2479
2480 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2481
2482 * defs.h (generic_load): Move from here...
2483 * symfile.h (generic_load): ... to here. Rename name parameter
2484 to args.
2485 * symfile.c (generic_load): Add comment.
2486
2487 2019-07-01 Tom Tromey <tromey@adacore.com>
2488
2489 * dwarf2read.c
2490 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2491 declaration of without_params. Fix formatting.
2492
2493 2019-07-01 Tom Tromey <tromey@adacore.com>
2494
2495 * ada-exp.y (find_primitive_type): Update.
2496 * ada-lang.h (ada_lookup_symbol): Update.
2497 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2498 parameter.
2499 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2500
2501 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2502
2503 PR breakpoints/24541
2504 * gdbarch.c: Regenerate.
2505 * gdbarch.h: Regenerate.
2506 * gdbarch.sh: Add 'stap_adjust_register'.
2507 * i386-tdep.c: Include '<unordered_set>'.
2508 (i386_stap_adjust_register): New function.
2509 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2510 * stap-probe.c (stap_parse_register_operand): Call
2511 'gdbarch_stap_adjust_register'.
2512
2513 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2514
2515 PR python/24742
2516 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2517 * python/python.c (do_start_initialization): Use 'xmalloc'
2518 instead of 'PyMem_Malloc'.
2519
2520 2019-06-28 Tom Tromey <tromey@adacore.com>
2521
2522 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2523 for Ada.
2524
2525 2019-06-27 Tom Tromey <tromey@adacore.com>
2526
2527 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2528 objfile_key.
2529 (arm_find_mapping_symbol, arm_record_special_symbol)
2530 (_initialize_arm_tdep): Update.
2531 (arm_objfile_data_free): Remove.
2532
2533 2019-06-27 Tom Tromey <tromey@adacore.com>
2534
2535 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2536 to cp_print_static_field.
2537
2538 2019-06-26 Tom Tromey <tromey@adacore.com>
2539
2540 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2541 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2542 declare.
2543
2544 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2545
2546 * features/aarch64-core.c (create_feature_aarch64_core):
2547 Regenerate.
2548 * features/aarch64-core.xml: Add cpsr flags.
2549
2550 2019-06-26 Alan Hayward <alan.hayward@arm.com>
2551
2552 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2553 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2554
2555 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2556
2557 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2558 field.
2559 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2560 use.
2561 (arm_record_special_symbol): Don't insert new symbol in sorted
2562 position, push it at the end.
2563
2564 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2565
2566 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2567 (arm_mapping_symbol_s): Remove.
2568 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2569 (arm_mapping_symbol_vec): New typedef.
2570 (struct arm_per_objfile): Add constructor.
2571 <section_maps>: Change type to
2572 std::unique_ptr<arm_mapping_symbol_vec[]>.
2573 (arm_compare_mapping_symbols): Remove.
2574 (arm_find_mapping_symbol): Adjust to section_maps type change.
2575 (arm_objfile_data_free): Call delete on arm_per_objfile.
2576 (arm_record_special_symbol): Adjust to section_maps type change.
2577 Allocate arm_per_objfile with new.
2578
2579 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2580
2581 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2582 with the command prefix.
2583
2584 2019-06-25 Tom Tromey <tom@tromey.com>
2585
2586 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2587 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2588
2589 2019-06-25 Tom Tromey <tom@tromey.com>
2590
2591 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2592 type.
2593 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2594 protected.
2595
2596 2019-06-25 Tom Tromey <tom@tromey.com>
2597
2598 * tui/tui-winsource.c
2599 (tui_source_window_base::set_is_exec_point_at): Add check against
2600 LOA_ADDRESS.
2601
2602 2019-06-25 Tom Tromey <tom@tromey.com>
2603
2604 * tui/tui-source.c (tui_set_source_content): Don't check before
2605 xfree.
2606 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2607
2608 2019-06-25 Tom Tromey <tom@tromey.com>
2609
2610 * tui/tui-winsource.h (tui_update_source_window_as_is)
2611 (tui_alloc_source_buffer, tui_line_is_displayed)
2612 (tui_addr_is_displayed): Change type of win_info.
2613 * tui/tui-winsource.c (tui_update_source_window_as_is)
2614 (tui_clear_source_content, tui_show_source_line)
2615 (tui_show_source_content, tui_source_window_base::refill)
2616 (tui_source_window_base::set_is_exec_point_at)
2617 (tui_source_window_base::set_is_exec_point_at)
2618 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2619 (tui_alloc_source_buffer, tui_line_is_displayed)
2620 (tui_addr_is_displayed): Change type of win_info. Update.
2621 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2622 (tui_source_window_base::do_make_visible_with_new_height):
2623 Update.
2624 * tui/tui-source.c (tui_set_source_content)
2625 (tui_set_source_content_nil)
2626 (tui_source_window::do_scroll_vertical): Update.
2627 * tui/tui-layout.c (show_layout): Update.
2628 * tui/tui-disasm.c (tui_set_disassem_content)
2629 (tui_disasm_window::do_scroll_vertical): Update.
2630 * tui/tui-data.h (tui_win_content): Remove.
2631 (struct tui_gen_win_info) <content, content_size>: Remove.
2632 (struct tui_source_element): Add initializers and destructor.
2633 (union tui_which_element, struct tui_win_element): Remove.
2634 (struct tui_source_window_base) <content>: New field.
2635 (struct tui_data_window): Remove destructor.
2636 (tui_alloc_content, tui_free_win_content)
2637 (tui_free_all_source_wins_content): Don't declare.
2638 * tui/tui-data.c (tui_initialize_static_data): Update.
2639 (init_content_element, tui_alloc_content): Remove.
2640 (~tui_gen_win_info): Update.
2641 (~tui_data_window, tui_free_all_source_wins_content)
2642 (tui_free_win_content, free_content, free_content_elements):
2643 Remove.
2644
2645 2019-06-25 Tom Tromey <tom@tromey.com>
2646
2647 * tui/tui-winsource.h (tui_clear_source_content)
2648 (tui_erase_source_content, tui_show_source_content): Change type
2649 of win_info.
2650 * tui/tui-winsource.c (tui_clear_source_content)
2651 (tui_erase_source_content, tui_show_source_content): Change type
2652 of win_info.
2653 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2654 * tui/tui-source.h (tui_set_source_content_nil): Change type of
2655 win_info.
2656 * tui/tui-source.c (tui_set_source_content_nil): Change type of
2657 win_info.
2658 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2659
2660 2019-06-25 Tom Tromey <tom@tromey.com>
2661
2662 * tui/tui-winsource.c (tui_clear_source_content)
2663 (tui_source_window_base::set_is_exec_point_at): Update.
2664 * tui/tui-source.c (tui_set_source_content_nil): Update.
2665 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2666 a bool.
2667 * tui/tui-data.c (init_content_element): Update.
2668
2669 2019-06-25 Tom Tromey <tom@tromey.com>
2670
2671 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2672 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2673 * tui/tui-layout.c (init_and_make_win): Update.
2674 * tui/tui.h (enum tui_win_type): Update.
2675 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2676 tui_win_is_auxillary.
2677 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2678 tui_win_is_auxillary.
2679
2680 2019-06-25 Tom Tromey <tom@tromey.com>
2681
2682 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2683 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2684 (tui_delete_data_content_windows, tui_display_all_data)
2685 (tui_data_window::do_scroll_vertical, tui_display_data_from):
2686 Update.
2687 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2688 * tui/tui-regs.c (tui_last_regs_line_no)
2689 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2690 (tui_show_registers): Update.
2691 (tui_show_register_group): Return void. Update.
2692 (tui_display_registers_from, tui_display_reg_element_at_line)
2693 (tui_display_registers_from_line, tui_check_register_values):
2694 Update.
2695 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2696 member.
2697 (struct tui_data_window) <regs_content>: Now a std::vector.
2698 <regs_content_count>: Remove.
2699 (tui_add_content_elements, tui_free_data_content): Don't declare.
2700 * tui/tui-data.c (tui_data_window::clear_detail): Update.
2701 (init_content_element): Remove DATA_WIN case. Add assert.
2702 (tui_add_content_elements): Remove.
2703 (tui_data_window): Update.
2704 (tui_free_data_content): Remove.
2705 (free_content_elements): Remove DATA_WIN case.
2706
2707 2019-06-25 Tom Tromey <tom@tromey.com>
2708
2709 * tui/tui-data.c (tui_data_item_window): Update.
2710 * tui/tui-windata.h (tui_check_data_values): Don't declare.
2711 * tui/tui-windata.c (tui_display_all_data)
2712 (tui_display_data_from_line): Update.
2713 (tui_check_data_values): Remove.
2714 * tui/tui-regs.c (tui_show_register_group)
2715 (tui_display_reg_element_at_line): Update.
2716 * tui/tui-hooks.c (tui_register_changed)
2717 (tui_refresh_frame_and_register_information): Call
2718 tui_check_register_values.
2719 * tui/tui-data.h (struct tui_data_window) <data_content,
2720 data_content_count, data_type>: Remove.
2721 (enum tui_data_type): Remove.
2722
2723 * tui/tui-data.c (tui_data_window::clear_detail)
2724 (~tui_data_window): Update.
2725
2726 2019-06-25 Tom Tromey <tom@tromey.com>
2727
2728 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2729 declare.
2730 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2731 Rename from tui_first_data_item_displayed. Update.
2732 (tui_data_window::refresh_all)
2733 (tui_data_window::do_scroll_vertical): Update.
2734 * tui/tui-data.h (struct tui_data_window)
2735 <first_data_item_displayed>: Declare new method.
2736
2737 2019-06-25 Tom Tromey <tom@tromey.com>
2738
2739 * tui/tui-data.h (tui_init_generic_part): Don't declare.
2740 * tui/tui-data.c (tui_init_generic_part): Remove, moving
2741 contents...
2742 (tui_initialize_static_data): ...here.
2743
2744 2019-06-25 Tom Tromey <tom@tromey.com>
2745
2746 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2747 (tui_display_registers_from, tui_check_register_values): Update.
2748 (tui_display_register): Remove win_info parameter; update.
2749 (tui_get_register): Change type of parameters.
2750 * tui/tui-data.h (struct tui_data_element): Remove.
2751 (union tui_which_element) <data>: Remove.
2752 <data_window>: Change type.
2753 (struct tui_data_item_window): New.
2754 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2755 case. Add assert.
2756 (~tui_data_item_window): New destructor.
2757 (free_content_elements): Remove DATA_ITEM_WIN case.
2758
2759 2019-06-25 Tom Tromey <tom@tromey.com>
2760
2761 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2762 Remove.
2763
2764 2019-06-25 Tom Tromey <tom@tromey.com>
2765
2766 * tui/tui-data.h (struct tui_command_element): Remove.
2767 (union tui_which_element) <command>: Remove.
2768 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
2769 assert.
2770 (free_content_elements): Remove CMD_WIN case.
2771
2772 2019-06-25 Tom Tromey <tom@tromey.com>
2773
2774 * tui/tui-layout.c (tui_set_layout): Update.
2775 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2776 * tui/tui-data.c (layout_def): Update.
2777
2778 2019-06-25 Tom Tromey <tom@tromey.com>
2779
2780 * tui/tui-wingeneral.c (tui_refresh_all): Update.
2781 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2782 (tui_source_window_base::set_new_height): Update.
2783 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2784 Update.
2785 (tui_set_locator_fullname, tui_set_locator_info)
2786 (tui_show_frame_info): Update.
2787 * tui/tui-source.c (tui_set_source_content)
2788 (tui_source_is_displayed): Update.
2789 * tui/tui-layout.c (show_source_disasm_command, show_data)
2790 (show_source_or_disasm_and_command): Update.
2791 * tui/tui-disasm.c (tui_set_disassem_content)
2792 (tui_get_begin_asm_address): Update.
2793 * tui/tui-data.h (struct tui_locator_element): Remove.
2794 (union tui_which_element) <locator>: Remove.
2795 (struct tui_locator_window): New.
2796 (tui_locator_win_info_ptr): Change return type.
2797 * tui/tui-data.c (_locator): Change type.
2798 (tui_locator_win_info_ptr): Change return type.
2799 (init_content_element): Remove LOCATOR_WIN case. Add assert.
2800 (tui_alloc_content): Add assert.
2801
2802 2019-06-25 Tom Tromey <tom@tromey.com>
2803
2804 * tui/tui-winsource.c
2805 (tui_exec_info_window::maybe_allocate_content): New method.
2806 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2807 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2808 (make_source_or_disasm_window): Add cast.
2809 * tui/tui-data.h (union tui_which_element) <simple_string>:
2810 Remove.
2811 (struct tui_source_info): New.
2812 (struct tui_source_window_base) <execution_info>: Change type.
2813 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2814 case, and add assert.
2815 (tui_alloc_content): Add assert.
2816
2817 2019-06-25 Tom Tromey <tom@tromey.com>
2818
2819 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2820 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2821 * tui/tui-data.c (tui_alloc_win_info): Remove.
2822
2823 2019-06-25 Tom Tromey <tom@tromey.com>
2824
2825 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2826 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2827 can_highlight.
2828
2829 2019-06-25 Tom Tromey <tom@tromey.com>
2830
2831 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2832 make_visible_with_new_height method.
2833 (tui_win_info::make_visible_with_new_height): New method.
2834 (tui_source_window_base::do_make_visible_with_new_height)
2835 (tui_data_window::do_make_visible_with_new_height)
2836 (tui_cmd_window::do_make_visible_with_new_height): New methods.
2837 (make_visible_with_new_height): Remove.
2838 (tui_resize_all, tui_adjust_win_heights): Use
2839 make_visible_with_new_height method.
2840 * tui/tui-data.h (struct tui_win_info)
2841 <do_make_visible_with_new_height, make_visible_with_new_height>:
2842 New methods.
2843 (struct tui_source_window_base, struct tui_data_window)
2844 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2845 methods.
2846
2847 2019-06-25 Tom Tromey <tom@tromey.com>
2848
2849 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2850 method.
2851 (update_tab_width): Call update_tab_width method.
2852 * tui/tui-data.h (struct tui_win_info)
2853 (struct tui_source_window_base) <update_tab_width>: New methods.
2854
2855 2019-06-25 Tom Tromey <tom@tromey.com>
2856
2857 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2858 parameter.
2859 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2860 parameter.
2861 (tui_gen_win_info::make_visible): Update.
2862 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2863 parameter.
2864 * tui/tui-data.h (enum tui_box): New enum.
2865 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2866
2867 2019-06-25 Tom Tromey <tom@tromey.com>
2868
2869 * tui/tui-layout.c (make_source_or_disasm_window): Always use
2870 init_and_make_win for EXEC_INFO_WIN.
2871 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2872 longer inline.
2873 (struct tui_win_info) <~tui_win_info>: Inline.
2874 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2875 Don't declare.
2876 * tui/tui-data.c (source_win, disasm_win): Remove globals.
2877 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2878 Remove.
2879 (tui_initialize_static_data): Update.
2880 (~tui_gen_win_info): Handle more cleanup here.
2881 (~tui_source_window_base): Delete "execution_info".
2882 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2883
2884 2019-06-25 Tom Tromey <tom@tromey.com>
2885
2886 * tui/tui-layout.c (make_command_window): Don't set
2887 can_highlight.
2888 (show_source_disasm_command): Call the reset method.
2889 (show_data): Don't set can_highlight. Call the reset method.
2890 (tui_gen_win_info::reset): Rename from init_gen_win_info
2891 (init_and_make_win): Simplify. Return tui_gen_win_info.
2892 (show_source_or_disasm_and_command): Call the reset method.
2893 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2894 (struct tui_cmd_window): Set can_highlight.
2895
2896 2019-06-25 Tom Tromey <tom@tromey.com>
2897
2898 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2899 from make_visible.
2900 (tui_make_visible, tui_make_invisible): Rewrite.
2901 (tui_win_info::make_visible): Remove.
2902 (tui_source_window_base::make_visible): Update.
2903 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2904 method. Moved from...
2905 (struct tui_win_info) <make_visible>: ...here.
2906
2907 2019-06-25 Tom Tromey <tom@tromey.com>
2908
2909 * tui/tui-winsource.c
2910 (tui_source_window_base::do_scroll_horizontal): Remove direction
2911 parameter.
2912 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2913 direction parameter.
2914 * tui/tui-win.c (tui_win_info::forward_scroll)
2915 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2916 (tui_win_info::right_scroll): Update.
2917 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2918 direction parameter.
2919 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2920 direction parameter.
2921 * tui/tui-data.h (enum tui_scroll_direction): Remove.
2922 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2923 Remove direction parameter.
2924 (struct tui_source_window_base, struct tui_source_window)
2925 (struct tui_disasm_window, struct tui_data_window)
2926 (struct tui_cmd_window): Update.
2927
2928 2019-06-25 Tom Tromey <tom@tromey.com>
2929
2930 * tui/tui-winsource.h (tui_set_exec_info_content)
2931 (tui_show_exec_info_content, tui_erase_exec_info_content)
2932 (tui_clear_exec_info_content, tui_update_exec_info): Change
2933 argument to tui_source_window_base.
2934 * tui/tui-winsource.c (tui_set_exec_info_content)
2935 (tui_show_exec_info_content, tui_erase_exec_info_content)
2936 (tui_clear_exec_info_content, tui_update_exec_info): Change
2937 argument to tui_source_window_base.
2938
2939 2019-06-25 Tom Tromey <tom@tromey.com>
2940
2941 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2942 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2943
2944 2019-06-25 Tom Tromey <tom@tromey.com>
2945
2946 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2947 check.
2948
2949 2019-06-25 Tom Tromey <tom@tromey.com>
2950
2951 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2952 type to void.
2953 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2954 type to void.
2955 * tui/tui-source.c (tui_set_source_content): Update.
2956 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2957
2958 2019-06-25 Tom Tromey <tom@tromey.com>
2959
2960 * tui/tui-win.c (window_name_completer, tui_set_focus)
2961 (tui_all_windows_info): Use name method.
2962 * tui/tui-data.h (struct tui_gen_win_info)
2963 (struct tui_source_window, struct tui_disasm_window)
2964 (struct tui_data_window, struct tui_cmd_window) <name>: New
2965 method.
2966 (tui_win_name): Don't declare.
2967 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2968 (tui_win_name): Remove.
2969
2970 2019-06-25 Tom Tromey <tom@tromey.com>
2971
2972 * tui/tui-winsource.h (tui_update_source_window)
2973 (tui_update_source_window_as_is): Change parameter type.
2974 * tui/tui-winsource.c (tui_update_source_window): Change win_info
2975 to be a tui_source_window_base.
2976 (tui_update_source_window_as_is): Likewise.
2977 * tui/tui-win.c (make_visible_with_new_height): Update.
2978
2979 2019-06-25 Tom Tromey <tom@tromey.com>
2980
2981 * tui/tui-winsource.c (tui_erase_source_content)
2982 (tui_show_source_content, tui_show_exec_info_content)
2983 (tui_erase_exec_info_content): Use refresh_window method.
2984 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2985 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2986 from tui_refresh_win.
2987 (tui_data_window::refresh_window): New method.
2988 (tui_win_info::refresh, tui_source_window_base::refresh)
2989 (tui_refresh_all): Use refresh_window method.
2990 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2991 method.
2992 * tui/tui-regs.c (tui_display_register): Call refresh_window
2993 method.
2994 * tui/tui-layout.c (show_source_disasm_command)
2995 (show_source_or_disasm_and_command): Call refresh_window method.
2996 * tui/tui-data.h (struct tui_gen_win_info)
2997 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2998 New method.
2999
3000 2019-06-25 Tom Tromey <tom@tromey.com>
3001
3002 * tui/tui.c (tui_rl_other_window, tui_enable)
3003 (tui_is_window_visible, tui_get_command_dimension): Update.
3004 * tui/tui-winsource.c (tui_update_source_window_as_is)
3005 (tui_clear_source_content, tui_erase_source_content)
3006 (tui_show_source_line, tui_source_window_base::refill)
3007 (tui_source_window_base::do_scroll_horizontal)
3008 (tui_source_window_base::set_is_exec_point_at)
3009 (tui_update_breakpoint_info, tui_set_exec_info_content)
3010 (tui_alloc_source_buffer, tui_line_is_displayed)
3011 (tui_addr_is_displayed): Update.
3012 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3013 (tui_check_and_display_highlight_if_needed)
3014 (tui_win_info::make_visible, tui_win_info::refresh)
3015 (tui_refresh_all): Update.
3016 * tui/tui-windata.c (tui_first_data_item_displayed)
3017 (tui_delete_data_content_windows, tui_erase_data_content)
3018 (tui_display_all_data, tui_data_window::refresh_all)
3019 (tui_check_data_values): Update.
3020 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3021 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3022 (tui_win_info::backward_scroll, tui_refresh_all_win)
3023 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3024 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3025 (tui_source_window_base::set_new_height)
3026 (tui_data_window::set_new_height)
3027 (make_invisible_and_set_new_height)
3028 (make_visible_with_new_height, new_height_ok)
3029 (parse_scrolling_args): Update.
3030 * tui/tui-stack.c (tui_show_frame_info): Update.
3031 * tui/tui-source.c (tui_set_source_content)
3032 (tui_set_source_content_nil, tui_source_is_displayed)
3033 (tui_source_window::do_scroll_vertical): Update.
3034 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3035 (tui_display_registers_from, tui_display_reg_element_at_line)
3036 (tui_check_register_values, tui_reg_command): Update.
3037 * tui/tui-layout.c (tui_default_win_height)
3038 (show_source_disasm_command, show_data, init_and_make_win)
3039 (show_source_or_disasm_and_command): Update.
3040 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3041 (tui_redisplay_readline, tui_mld_flush)
3042 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3043 (tui_getc): Update.
3044 * tui/tui-disasm.c (tui_set_disassem_content)
3045 (tui_disasm_window::do_scroll_vertical): Update.
3046 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3047 Now virtual.
3048 (struct tui_win_info): Derive from tui_gen_win_info.
3049 <~tui_win_info>: Mark as override.
3050 <generic>: Remove member.
3051 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3052 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3053 (~tui_data_window, ~tui_win_info)
3054 (tui_free_all_source_wins_content): Update.
3055 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3056
3057 2019-06-25 Tom Tromey <tom@tromey.com>
3058
3059 * tui/tui-layout.c (init_and_make_win): Use new.
3060 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3061 destructor, initializers.
3062 (tui_alloc_generic_win_info): Don't declare.
3063 * tui/tui-data.c (_locator): Add argument to constructor.
3064 (source_win, disasm_win): New globals.
3065 (exec_info): Remove.
3066 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3067 Update.
3068 (tui_alloc_generic_win_info): Remove.
3069 (init_content_element): Use new.
3070 (tui_win_info::tui_win_info): Update.
3071 (free_content_elements) <case DATA_WIN>: Use delete.
3072
3073 2019-06-25 Tom Tromey <tom@tromey.com>
3074
3075 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3076 * tui/tui-windata.c (tui_first_data_item_displayed)
3077 (tui_delete_data_content_windows): Update.
3078 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3079 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3080 (tui_display_registers_from, tui_check_register_values): Update.
3081 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3082 pointer.
3083 * tui/tui-data.c (init_content_element): Update. Allocate the new
3084 window.
3085 (tui_free_data_content): Update.
3086 (free_content_elements) <case DATA_WIN>: Free the window.
3087
3088 2019-06-25 Tom Tromey <tom@tromey.com>
3089
3090 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3091 Update.
3092 * tui/tui-layout.c (make_command_window)
3093 (show_source_disasm_command, show_data, init_and_make_win)
3094 (show_source_or_disasm_and_command): Update.
3095 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3096 method.
3097 <can_highight, is_highlighted>: Now bool.
3098 (tui_set_win_highlight): Don't declare.
3099 * tui/tui-data.c (tui_set_win_highlight): Remove.
3100
3101 2019-06-25 Tom Tromey <tom@tromey.com>
3102
3103 * tui/tui-wingeneral.c (make_visible): Remove check of window
3104 type.
3105
3106 2019-06-25 Tom Tromey <tom@tromey.com>
3107
3108 * tui/tui-win.c (tui_win_info::max_height)
3109 (tui_cmd_window::max_height): New methods.
3110 (new_height_ok): Call max_height.
3111 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3112 <max_height>: New method.
3113
3114 2019-06-25 Tom Tromey <tom@tromey.com>
3115
3116 * tui/tui-win.c (tui_source_window_base::set_new_height)
3117 (tui_data_window::set_new_height): New methods.
3118 (make_invisible_and_set_new_height): Call set_new_height method.
3119 * tui/tui-data.h (struct tui_win_info)
3120 (struct tui_source_window_base, struct tui_data_window)
3121 <set_new_height>: New method.
3122
3123 2019-06-25 Tom Tromey <tom@tromey.com>
3124
3125 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3126 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3127 tui_refresh_data_win.
3128 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3129 method.
3130 (tui_refresh_all_win): Call the refresh_all method.
3131 (tui_set_focus): Likewise.
3132 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3133 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3134 Likewise.
3135
3136 2019-06-25 Tom Tromey <tom@tromey.com>
3137
3138 * tui/tui-winsource.h (tui_refill_source_window)
3139 (tui_set_is_exec_point_at): Don't declare.
3140 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3141 (tui_source_window_base::refill): Rename from
3142 tui_refill_source_window.
3143 (tui_source_window_base::do_scroll_horizontal): Update.
3144 (tui_source_window_base::set_is_exec_point_at): Rename from
3145 tui_set_is_exec_point_at.
3146 (tui_update_all_breakpoint_info): Update.
3147 * tui/tui-stack.c (tui_show_frame_info): Update.
3148 * tui/tui-layout.c (show_data): Add cast.
3149 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3150 * tui/tui-data.h (struct tui_source_window_base) <refill,
3151 set_is_exec_point_at>: New methods.
3152 (tui_source_windows, tui_add_to_source_windows): Update types.
3153 (tui_add_to_source_windows): Remove redundant declaration.
3154 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3155 (tui_source_windows): Change return type.
3156 (tui_clear_source_windows_detail): Update.
3157 (tui_add_to_source_windows): Change type of parameter.
3158 (tui_free_all_source_wins_content): Update.
3159
3160 2019-06-25 Tom Tromey <tom@tromey.com>
3161
3162 * tui/tui-wingeneral.c (tui_win_info::refresh)
3163 (tui_source_window_base::refresh): New methods.
3164 (tui_refresh_all): Call the refresh method.
3165 * tui/tui-data.h (struct tui_win_info)
3166 (struct tui_source_window_base) <refresh>: New method.
3167
3168 2019-06-25 Tom Tromey <tom@tromey.com>
3169
3170 * tui/tui.h (tui_is_window_visible): Return bool.
3171 * tui/tui.c (tui_is_window_visible): Return bool.
3172 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3173 (tui_make_visible, tui_make_invisible)
3174 (tui_win_info::make_visible)
3175 (tui_source_window_base::make_visible, make_all_visible)
3176 (tui_make_all_visible, tui_make_all_invisible): Update.
3177 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3178 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3179 bool.
3180 (struct tui_win_info, struct tui_source_window_base)
3181 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3182 * tui/tui-data.c (tui_init_generic_part): Update.
3183
3184 2019-06-25 Tom Tromey <tom@tromey.com>
3185
3186 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3187 (tui_source_window_base::make_visible): New methods.
3188 (make_all_visible): Make method call.
3189 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3190 (struct tui_source_window_base, struct tui_cmd_window): Override
3191 make_visible.
3192 (tui_win_is_source_type): Don't declare.
3193 * tui/tui-data.c (tui_win_is_source_type): Remove.
3194
3195 2019-06-25 Tom Tromey <tom@tromey.com>
3196
3197 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3198 NULL check.
3199
3200 2019-06-25 Tom Tromey <tom@tromey.com>
3201
3202 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3203 Inline constructor. Add initializers for members.
3204 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3205 constructors; now inline in class.
3206
3207 2019-06-25 Tom Tromey <tom@tromey.com>
3208
3209 * tui/tui-regs.c (tui_show_registers): Update.
3210 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3211 bool.
3212 * tui/tui-data.c (tui_data_window::clear_detail)
3213 (tui_data_window): Update.
3214
3215 2019-06-25 Tom Tromey <tom@tromey.com>
3216
3217 * tui/tui-windata.c (tui_display_all_data)
3218 (tui_display_data_from_line, tui_display_data_from)
3219 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3220 Update.
3221 * tui/tui-regs.c (tui_last_regs_line_no)
3222 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3223 (tui_show_registers, tui_show_register_group)
3224 (tui_display_registers_from, tui_display_reg_element_at_line)
3225 (tui_display_registers_from_line, tui_check_register_values)
3226 (tui_reg_next, tui_reg_prev): Update.
3227 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3228 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3229 tui_data_window.
3230 (struct tui_win_info) <detail>: Remove. Add new fields from
3231 tui_data_info.
3232 (TUI_DATA_WIN): Add cast.
3233 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3234 (~tui_data_window): Simplify.
3235
3236 2019-06-25 Tom Tromey <tom@tromey.com>
3237
3238 * tui/tui-layout.c (show_source_disasm_command)
3239 (show_source_or_disasm_and_command): Update.
3240 * tui/tui-io.c (update_cmdwin_start_line)
3241 (tui_redisplay_readline): Update.
3242 * tui/tui-data.h (struct tui_command_info): Remove.
3243 (struct tui_win_info) <detail>: Remove command_info member.
3244 (struct tui_data_window) <start_line>: New member, from
3245 tui_command_info.
3246 (TUI_CMD_WIN): Add casts.
3247
3248 2019-06-25 Tom Tromey <tom@tromey.com>
3249
3250 * tui/tui-winsource.c (tui_update_source_window)
3251 (tui_refill_source_window)
3252 (tui_source_window_base::do_scroll_horizontal)
3253 (tui_update_breakpoint_info, tui_set_exec_info_content)
3254 (tui_show_exec_info_content, tui_erase_exec_info_content)
3255 (tui_clear_exec_info_content): Update.
3256 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3257 Update.
3258 * tui/tui-win.c (make_invisible_and_set_new_height)
3259 (make_visible_with_new_height): Update.
3260 * tui/tui-source.c (tui_set_source_content)
3261 (tui_show_symtab_source): Update.
3262 * tui/tui-layout.c (extract_display_start_addr)
3263 (show_source_disasm_command, show_data)
3264 (make_source_or_disasm_window)
3265 (show_source_or_disasm_and_command): Update.
3266 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3267 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3268 "gdbarch".
3269 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3270 to tui_source_window_base.
3271 (struct tui_win_info) <detail>: Remove source_info member.
3272 (struct tui_source_window_base) <has_locator>: Inline.
3273 Move contents from tui_source_info; rename has_locator member to
3274 m_has_locator.
3275 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3276 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3277 header file.
3278 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3279 Simplify.
3280 (tui_free_all_source_wins_content): Cast to
3281 tui_source_window_base.
3282
3283 2019-06-25 Tom Tromey <tom@tromey.com>
3284
3285 * tui/tui-win.c (make_invisible_and_set_new_height)
3286 (make_visible_with_new_height): Call has_locator method.
3287 * tui/tui-layout.c (show_source_disasm_command, show_data)
3288 (show_source_or_disasm_and_command): Update for bool change.
3289 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3290 (tui_win_info) <has_locator>: New method.
3291 (struct tui_source_window_base) <has_locator>: New method.
3292 (tui_win_has_locator): Don't declare.
3293 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3294 from tui_win_has_locator.
3295 (tui_source_window_base): Use false, not FALSE.
3296
3297 2019-06-25 Tom Tromey <tom@tromey.com>
3298
3299 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3300 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3301 clear_detail method directly.
3302 (tui_clear_win_detail): Remove.
3303
3304 2019-06-25 Tom Tromey <tom@tromey.com>
3305
3306 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3307 "this", not TUI_DISASM_WIN.
3308
3309 2019-06-25 Tom Tromey <tom@tromey.com>
3310
3311 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3312 declare.
3313 * tui/tui-winsource.c
3314 (tui_source_window_base::do_scroll_horizontal): Rename from
3315 tui_horizontal_source_scroll.
3316 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3317 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3318 from tui_vertical_data_scroll.
3319 * tui/tui-win.h (tui_scroll): Don't declare.
3320 * tui/tui-win.c (tui_win_info::forward_scroll)
3321 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3322 (tui_win_info::right_scroll): Rename and update.
3323 (tui_scroll_forward_command, tui_scroll_backward_command)
3324 (tui_scroll_left_command, tui_scroll_right_command): Update.
3325 (tui_scroll): Remove.
3326 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3327 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3328 from tui_vertical_source_scroll.
3329 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3330 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3331 from tui_vertical_disassem_scroll.
3332 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3333 do_scroll_horizontal>: New methods.
3334 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3335 Likewise.
3336 (struct tui_source_window_base): Add do_scroll_horizontal.
3337 (struct tui_source_window, struct tui_disasm_window): Add
3338 do_scroll_vertical.
3339 (struct tui_data_window, struct tui_cmd_window): Add
3340 do_scroll_horizontal and do_scroll_vertical.
3341 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3342
3343 2019-06-25 Tom Tromey <tom@tromey.com>
3344
3345 * tui/tui-data.h (struct tui_source_window_base): New struct.
3346 (struct tui_source_window): Derive from tui_source_window_base.
3347 (struct tui_disasm_window): New struct.
3348 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3349 from tui_source_window::clear_detail.
3350 (tui_source_window_base): Rename from tui_source_window.
3351 (~tui_source_window_base): Rename from ~tui_source_window.
3352 (tui_alloc_win_info): Create a tui_disasm_window.
3353
3354 2019-06-25 Tom Tromey <tom@tromey.com>
3355
3356 * tui/tui-data.h (struct tui_source_window)
3357 (struct tui_data_window): Declare destructors.
3358 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3359 destructors.
3360 (tui_win_info): Simplify.
3361
3362 2019-06-25 Tom Tromey <tom@tromey.com>
3363
3364 * tui/tui-winsource.c (tui_display_main)
3365 (tui_update_source_windows_with_addr)
3366 (tui_update_all_breakpoint_info): Update.
3367 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3368 (new_height_ok, parse_scrolling_args): Update.
3369 * tui/tui-stack.c (tui_show_frame_info): Update.
3370 * tui/tui-data.h (struct tui_list): Remove.
3371 (tui_source_windows): Return a reference to a std::vector.
3372 * tui/tui-data.c (source_windows): Now a std::vector.
3373 (tui_source_windows): Change return type.
3374 (tui_clear_source_windows): Rewrite.
3375 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3376 (tui_free_all_source_wins_content): Rewrite.
3377
3378 2019-06-25 Tom Tromey <tom@tromey.com>
3379
3380 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3381 (struct tui_data_window, struct tui_cmd_window): Declare
3382 clear_detail method.
3383 * tui/tui-data.c (tui_source_window::clear_detail)
3384 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3385 methods.
3386 (tui_clear_win_detail): Simplify.
3387
3388 2019-06-25 Tom Tromey <tom@tromey.com>
3389
3390 * tui/tui-layout.c (make_source_window, make_disasm_window)
3391 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3392 Return the new window.
3393 (show_source_disasm_command, show_data)
3394 (show_source_or_disasm_and_command): Update.
3395
3396 2019-06-25 Tom Tromey <tom@tromey.com>
3397
3398 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3399 parameter. Return the new window.
3400 (show_source_disasm_command): Update and remove NULL check.
3401 (show_source_or_disasm_and_command): Update.
3402
3403 2019-06-25 Tom Tromey <tom@tromey.com>
3404
3405 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3406
3407 2019-06-25 Tom Tromey <tom@tromey.com>
3408
3409 * tui/tui-data.h (struct tui_win_info): Make constructor
3410 protected. Make destructor virtual. Add initializers.
3411 (tui_source_window, tui_data_window, tui_cmd_window): New
3412 classes.
3413 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3414 constructor. Add "type" parameter.
3415 (tui_source_window, tui_data_window, tui_cmd_window): New
3416 constructors.
3417 (tui_alloc_win_info): Instantiate the appropriate subclass.
3418
3419 2019-06-25 Tom Tromey <tom@tromey.com>
3420
3421 * tui/tui-win.c (tui_resize_all): Use delete.
3422 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3423 destructor.
3424 (tui_free_window): Don't declare.
3425 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3426 Update.
3427
3428 2019-06-25 Tom Tromey <tom@tromey.com>
3429
3430 * tui/tui-data.h (struct tui_win_info): Add constructor.
3431 * tui/tui-data.c (tui_alloc_win_info): Use new.
3432 (tui_free_window): Use delete.
3433
3434 2019-06-22 Tom Tromey <tom@tromey.com>
3435
3436 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3437 declare.
3438 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3439
3440 2019-06-22 Tom Tromey <tom@tromey.com>
3441
3442 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3443 declare.
3444 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3445
3446 2019-06-22 Tom de Vries <tdevries@suse.de>
3447
3448 * dwarf2read.c (create_addrmap_from_aranges)
3449 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3450 instead of '%zu'.
3451
3452 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
3453
3454 * dwarf2read.h (dwarf2_section_info_def): Remove.
3455 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3456 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3457 std::vector<dwarf2_section_info>.
3458 (struct dwo_file) <~dwo_file>: Remove.
3459 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3460 types field.
3461 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3462 (dwarf2_read_debug_names): Likewise.
3463 (create_debug_types_hash_table): Change parameter type to
3464 array_view, adjust code accordingly.
3465 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3466 (partial_die_info::fixup): Likewise.
3467 (determine_prefix): Likewise.
3468 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3469
3470 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3471
3472 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3473 gdb_bfd_ref_ptr.
3474 <~dwo_file>: Remove call to gdb_bfd_unref.
3475 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3476 gdb_bfd_ref_ptr::get.
3477
3478 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3479
3480 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3481 type to htab_up.
3482 * dwarf2read.c (struct dwo_file): Initialize fields.
3483 <~dwo_file>: New.
3484 (free_dwo_file): Remove, move content to ~dwo_file.
3485 (struct dwo_file_deleter): Remove.
3486 (dwo_file_up>: Remove custom deleter.
3487 (free_dwo_files): Remove.
3488 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3489 dwo_files.
3490 (process_skeletonless_type_units): Call unique_ptr::get.
3491 (allocate_dwo_file_hash_table): Add deleter to created hash
3492 table. Change return type to htab_up.
3493 (lookup_dwo_file_slot): Don't memset dwo_file, call
3494 unique_ptr::get.
3495 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3496 (create_dwo_unit_in_dwp_v2): Likewise.
3497 (open_and_init_dwo_file): Likewise.
3498 (free_dwo_file_from_slot): Remove.
3499
3500 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3501
3502 * dwarf2read.h (struct dwarf2_section_info) <readin,
3503 is_virtual>: Change type to bool.
3504 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3505 true instead of 1.
3506
3507 2019-06-19 Tom Tromey <tom@tromey.com>
3508
3509 * tui/tui-data.h (tui_init_content_element): Don't declare.
3510
3511 2019-06-19 Tom Tromey <tom@tromey.com>
3512
3513 * tui/tui-data.h (tui_init_win_info): Don't declare.
3514
3515 2019-06-19 Tom de Vries <tdevries@suse.de>
3516
3517 * dwarf2read.h (abstract_to_concrete): Change type to
3518 std::unordered_map<sect_offset, std::vector<sect_offset>,
3519 gdb::hash_enum<sect_offset>>.
3520
3521 2019-06-19 Tom Tromey <tromey@adacore.com>
3522
3523 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3524 EVAL_AVOID_SIDE_EFFECTS specially.
3525
3526 2019-06-19 Tom Tromey <tromey@adacore.com>
3527
3528 * source-cache.c (highlighter): New global.
3529 (source_cache::get_source_lines): Create a highlighter on demand.
3530
3531 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3532
3533 * defs.h (deprecated_interactive_hook): Delete declaration.
3534 * interps.c (clear_interpreter_hooks): Remove use of
3535 deprecated_interactive_hook.
3536 * top.c (deprecated_interactive_hook): Delete definition.
3537 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3538
3539 2019-06-18 Tom de Vries <tdevries@suse.de>
3540
3541 PR gdb/24515
3542 * dwarf2read.h (abstract_to_concrete): Change type from
3543 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3544 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3545 * dwarf2read.c (read_variable): Update.
3546 (dwarf2_fetch_die_loc_sect_off): Update.
3547
3548 2019-06-17 Tom de Vries <tdevries@suse.de>
3549
3550 PR gdb/24617
3551 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3552 accessing parent[parent_len - 1].
3553
3554 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3555
3556 PR gdb/24364
3557 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3558 call dtrace_process_dof with NULL dof.
3559
3560 2019-06-16 Tom de Vries <tdevries@suse.de>
3561
3562 PR gdb/24445
3563 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3564
3565 2019-06-16 Tom Tromey <tom@tromey.com>
3566
3567 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3568 (make_all_visible): Use address of member.
3569
3570 2019-06-16 Tom Tromey <tom@tromey.com>
3571
3572 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3573 (tui_free_window, free_content, free_content_elements): Remove
3574 unnecessary cast.
3575 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3576 cast.
3577 * tui/tui-regs.c (tui_show_register_group)
3578 (tui_display_registers_from, tui_display_reg_element_at_line):
3579 Remove unnecessary cast.
3580
3581 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3582
3583 * linux-nat.c (normal_mask): Delete.
3584 (_initialize_linux_nat): Don't initialise normal_mask.
3585
3586 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3587
3588 PR gdb/24445
3589 * dwarf-index-write.h (write_psymtabs_to_index): Add
3590 dwz_basename parameter.
3591 * dwarf-index-write.c (write_gdbindex): Move file writing to
3592 write_gdbindex_1. Change return type void.
3593 (assert_file_size): Move up, remove filename parameter.
3594 (write_gdbindex_1): New function.
3595 (write_debug_names): Change return type to void, call
3596 assert_file_size.
3597 (struct index_wip_file): New struct.
3598 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3599 file logic to index_wip_file. Write index for dwz file if
3600 needed.
3601 (save_gdb_index_command): Pass basename of dwz file, if present.
3602 * dwarf-index-cache.c (index_cache::store): Obtain and pass
3603 build-id of dwz file, if present.
3604 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3605 (dwarf2_get_dwz_file): Likewise.
3606 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3607 (dwarf2_get_dwz_file): Likewise.
3608
3609 2019-06-16 Tom Tromey <tom@tromey.com>
3610
3611 * coffread.c (process_coff_symbol): Use xstrdup.
3612 * value.c (create_internalvar): Use xstrdup.
3613
3614 2019-06-16 Tom Tromey <tom@tromey.com>
3615
3616 * valops.c (value_cast, value_slice): Remove unnecessary cast.
3617 * breakpoint.c (stopin_command, stopat_command)
3618 (until_break_command, decode_location_default): Remove unnecessary
3619 cast.
3620 * utils.c (subset_compare): Remove unnecessary cast.
3621 * ada-lang.c (ada_update_initial_language): Remove unnecessary
3622 cast.
3623 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3624 cast.
3625 * infcmd.c (path_command): Remove unnecessary cast.
3626 * coffread.c (decode_type): Remove unnecessary cast.
3627 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3628 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3629 * tui/tui-stack.c (tui_show_locator_content)
3630 (tui_show_frame_info): Remove unnecessary cast.
3631 * tui/tui-win.c (tui_scroll_forward_command)
3632 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3633 (parse_scrolling_args): Remove unnecessary cast.
3634 * tui/tui-data.c (init_win_info, tui_del_window)
3635 (tui_free_window, tui_del_data_windows, tui_free_data_content)
3636 (free_content_elements): Remove unnecessary cast.
3637 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3638 unnecessary cast.
3639 * tui/tui-source.c (tui_set_source_content)
3640 (tui_vertical_source_scroll): Remove unnecessary cast.
3641 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3642 cast.
3643 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3644 * tui/tui-regs.c (tui_display_registers_from)
3645 (tui_display_register): Remove unnecessary cast.
3646 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3647 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3648 (make_visible): Remove unnecessary cast.
3649 * tui/tui-winsource.c (tui_erase_source_content)
3650 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3651 unnecessary cast.
3652 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3653 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3654 * stabsread.c (read_type, read_array_type, read_range_type):
3655 Remove unnecessary cast.
3656 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3657 (parse_symbol, parse_type, upgrade_type, parse_external)
3658 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3659 unnecessary cast.
3660 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3661
3662 2019-06-16 Tom Tromey <tom@tromey.com>
3663
3664 * tui/tui-data.c (tui_alloc_generic_win_info)
3665 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3666 checks.
3667
3668 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
3669 Andrew Burgess <andrew.burgess@embecosm.com>
3670
3671 * f-typeprint.c (f_print_type): Don't return early for not
3672 associated or not allocated types.
3673 (f_type_print_varspec_suffix): Add print_rank parameter and print
3674 ranks of array types in case they dangling.
3675 (f_type_print_base): Add print_rank parameter.
3676
3677 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3678
3679 * NEWS: Mention new MI commands.
3680 * break-catch-throw.c (enum exception_event_kind): Move to
3681 breakpoint.h.
3682 (print_mention_exception_catchpoint): Output text as a single
3683 message.
3684 (catch_exception_command_1): Rename to...
3685 (catch_exception_event): ...this, make non-static, update header
3686 command, and change some parameter types.
3687 (catch_catch_command): Update for changes to
3688 catch_exception_command_1.
3689 (catch_throw_command): Likewise.
3690 (catch_rethrow_command): Likewise.
3691 * breakpoint.c (enum exception_event_kind): Delete.
3692 * breakpoint.h (enum exception_event_kind): Moved here from
3693 break-catch-throw.c.
3694 (catch_exception_event): Declare.
3695 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3696 (mi_cmd_catch_throw): New function.
3697 (mi_cmd_catch_rethrow): New function.
3698 (mi_cmd_catch_catch): New function.
3699 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3700 'catch-catch' entries.
3701 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3702 (mi_cmd_catch_rethrow): Declare.
3703 (mi_cmd_catch_catch): Declare.
3704
3705 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3706
3707 * annotate.c (annotate_source_line): Change return type to void,
3708 update implementation to match.
3709 * annotate.h (annotate_source_line): Change return type to void,
3710 update header comment.
3711 * stack.c (print_frame_info): Don't change what frame information
3712 is printed based on whether annotations are on or not.
3713
3714 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3715
3716 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3717 (annotate_source): Make static.
3718 (annotate_source_line): Moved from source.c and renamed from
3719 identify_source_line. Update the return type.
3720 * annotate.h (annotate_source): Delete declaration.
3721 (annotate_source_line): Declaration moved from source.h, and
3722 renamed from identify_source_line. Return type updated.
3723 * source.c (identify_source_line): Moved to annotate.c and renamed
3724 to annotate_source_line.
3725 (info_line_command): Remove check of annotation_level.
3726 * source.h (identify_source_line): Move declaration to annotate.h
3727 and rename to annotate_source_line.
3728 * stack.c: Add 'annotate.h' include.
3729 (print_frame_info): Remove check of annotation_level before
3730 calling annotate_source_line.
3731
3732 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3733
3734 * source-cache.c (source_cache::get_plain_source_lines): Use
3735 open_source_file_with_line_charpos instead of just
3736 open_source_file, remove call to find_source_lines.
3737 (source_cache::get_source_lines): Likewise.
3738 * source.c (find_source_lines): Make static.
3739 (get_filename_and_charpos): Renamed into...
3740 (open_source_file_with_line_charpos): ..this along with changes to
3741 return a scoped_fd, and some other minor clean ups.
3742 (identify_source_line): Use open_source_file_with_line_charpos.
3743 (search_command_helper): Use open_source_file_with_line_charpos
3744 instead of just open_source_file, remove call to
3745 find_source_lines.
3746 * source.h (open_source_file_with_line_charpos): Declare new
3747 function.
3748 (find_source_lines): Delete declaration.
3749
3750 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
3751
3752 * source.c (get_filename_and_charpos): Remove fullname
3753 parameter.
3754 (identify_source_line): Update call to get_filename_and_charpos.
3755
3756 2019-06-14 Tom Tromey <tromey@adacore.com>
3757
3758 PR gdb/24502:
3759 * ui-style.h (skip_ansi_escape): Update comment.
3760 * ui-file.h (class no_terminal_escape_file): New class.
3761 * ui-file.c (no_terminal_escape_file::write)
3762 (no_terminal_escape_file::puts): New methods.
3763 * cli/cli-logging.c (handle_redirections): Use
3764 no_terminal_escape_file.
3765
3766 2019-06-14 Tom Tromey <tromey@adacore.com>
3767
3768 * NEWS: Move convenience variable news above Python news.
3769
3770 2019-06-14 Tom Tromey <tom@tromey.com>
3771
3772 * gnulib: Move directory to top-level.
3773 * configure.ac: Don't configure gnulib.
3774 * configure: Rebuild.
3775 * common/common-defs.h: Use new path to gnulib.
3776 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3777 (GNULIB_H): Remove.
3778 (INCGNU): Look in new gnulib location.
3779 (HFILES_NO_SRCDIR): Remove gnulib files.
3780 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3781 (generated_files): Remove GNULIB_H.
3782 ($(LIBGNU), all-lib): Remove targets.
3783 (distclean): Don't mention GNULIB_BUILDDIR.
3784 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3785
3786 2019-06-14 Tom Tromey <tromey@adacore.com>
3787
3788 * symfile.c (add_symbol_file_command): Remove obsolete comment.
3789 Warn if symbol file does not provide any symbols.
3790
3791 2019-06-14 Tom Tromey <tromey@adacore.com>
3792
3793 * source.c (find_and_open_source): Respect basenames_may_differ.
3794
3795 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
3796
3797 * annotate.c (annotate_breakpoints_invalid): Make use of
3798 scoped_restore_terminal_state.
3799 (annotate_frames_invalid): Likewise.
3800
3801 2019-06-14 Tom Tromey <tromey@adacore.com>
3802
3803 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3804 allow assignment to an internalvar.
3805
3806 2019-06-14 Tom Tromey <tromey@adacore.com>
3807
3808 * ada-lex.l: Allow "_" in attribute names.
3809
3810 2019-06-14 Tom Tromey <tromey@adacore.com>
3811
3812 PR gdb/24653:
3813 * regcache.c (registers_changed): Don't call alloca.
3814 * top.c (execute_command): Don't call alloca.
3815
3816 2019-06-13 Pedro Alves <palves@redhat.com>
3817
3818 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3819 'expression'. When parsing an expression, error out if there's
3820 junk after "unlimited".
3821 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3822 (do_set_command): Adjust calls to is_unlimited_literal.
3823
3824 2019-06-13 Pedro Alves <palves@redhat.com>
3825
3826 * compile/compile.c (make_compile_options_def_group): Add braces
3827 around array_view initializer.
3828 * thread.c (make_thread_apply_all_options_def_group)
3829 (make_thread_apply_all_options_def_group): Likewise.
3830
3831 2019-06-13 Pedro Alves <palves@redhat.com>
3832
3833 * NEWS (New commands): Mention "maint test-options
3834 require-delimiter", "maint test-options unknown-is-error", "maint
3835 test-options unknown-is-operand" and "maint show
3836 test-options-completion-result".
3837 (New command options, command completion): New section.
3838 (Completion improvements): New section.
3839 Mention that you can abbreviate "unlimited".
3840
3841 2019-06-13 Pedro Alves <palves@redhat.com>
3842
3843 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3844 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3845 * unittests/cli-utils-selftests.c (test_parse_flags)
3846 (test_parse_flags_qcs): Delete.
3847 (test_cli_utils): Don't call deleted functions.
3848
3849 2019-06-13 Pedro Alves <palves@redhat.com>
3850
3851 * thread.c: Include "cli/cli-option.h".
3852 (tp_array_compar_ascending): Global.
3853 (tp_array_compar): Delete function.
3854 (tp_array_compar_ascending, tp_array_compar_descending): New
3855 functions.
3856 (ascending_option_def, qcs_flag_option_def)
3857 (thr_qcs_flags_option_defs)
3858 (make_thread_apply_all_options_def_group)
3859 (make_thread_apply_options_def_group): New.
3860 (thread_apply_all_command): Use gdb::option::process_options.
3861 (thread_apply_command_completer)
3862 (thread_apply_all_command_completer): New.
3863 (thread_apply_command): Use gdb::option::process_options.
3864 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3865 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
3866 to generate help text of "thread apply". Adjust "taas"'s help.
3867 * tid-parse.c (tid_range_parser::in_thread_range): New method.
3868 * tid-parse.h (tid_range_parser::in_thread_range): New method.
3869
3870 2019-06-13 Pedro Alves <palves@redhat.com>
3871
3872 * thread.c (thread_apply_command): Check for invalid TID with
3873 isdigit instead of !isalpha.
3874
3875 2019-06-13 Pedro Alves <palves@redhat.com>
3876
3877 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3878 (validate_flags_qcs): New.
3879 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3880 (validate_flags_qcs): Declare.
3881 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3882 (make_frame_apply_options_def_group): New.
3883 (frame_apply_command_count): Process options with
3884 gdb::option::process_options.
3885 (frame_apply_completer): New.
3886 (frame_apply_level_completer, frame_apply_all_completer)
3887 (frame_apply_completer): New.
3888 (_initialize_stack): Update help of "frame apply", "frame apply
3889 level", "frame apply all" and "faas" to mention supported options
3890 and install command completers.
3891 * stack.h (frame_apply_all_completer): Declare.
3892 * thread.c: Include "stack.h".
3893 (tfaas_command): Add "--".
3894 (_initialize_thread): Update help "tfaas" to mention supported
3895 options and install command completer.
3896
3897 2019-06-13 Pedro Alves <palves@redhat.com>
3898
3899 * completer.c (complete_nested_command_line): New.
3900 (gdb_completion_word_break_characters_throw): Add assertion.
3901 * completer.h (complete_nested_command_line): Declare.
3902
3903 2019-06-13 Pedro Alves <palves@redhat.com>
3904
3905 * stack.c (parse_backtrace_qualifiers): New.
3906 (backtrace_command): Use it.
3907 (backtrace_command_completer): Complete on qualifiers.
3908
3909 2019-06-13 Pedro Alves <palves@redhat.com>
3910
3911 * frame.c: Include "cli/cli-option.h.
3912 (user_set_backtrace_options): New.
3913 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3914 Delete.
3915 (get_prev_frame): Adjust.
3916 (boolean_option_def, uinteger_option_def)
3917 (set_backtrace_option_defs): New.
3918 (_initialize_frame): Adjust and use
3919 gdb::option::add_setshow_cmds_for_options to install "set
3920 backtrace past-main" and "set backtrace past-entry".
3921 * frame.h: Include "cli/cli-option.h".
3922 (struct frame_print_options): Forward declare.
3923 (print_frame_arguments_all, print_frame_arguments_scalars)
3924 (print_frame_arguments_none): Declare.
3925 (print_entry_values): Delete declaration.
3926 (struct frame_print_options, user_frame_print_options): New.
3927 (struct set_backtrace_options): New.
3928 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3929 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3930 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3931 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3932 (list_args_or_locals): Add frame_print_options parameter.
3933 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3934 * python/py-framefilter.c (enumerate_args): Pass down
3935 USER_FRAME_PRINT_OPTIONS.
3936 * stack.c: Include "cli/cli-option.h".
3937 (print_frame_arguments_all, print_frame_arguments_scalars)
3938 (print_frame_arguments_none): Declare.
3939 (print_raw_frame_arguments, print_entry_values): Delete.
3940 (user_frame_print_options): New.
3941 (boolean_option_def, enum_option_def, frame_print_option_defs):
3942 New.
3943 (struct backtrace_cmd_options): New.
3944 (bt_flag_option_def): New.
3945 (backtrace_command_option_defs): New.
3946 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3947 (print_frame_arg, read_frame_arg, print_frame_args)
3948 (print_frame_info, print_frame): Add frame_print_options parameter
3949 and use it.
3950 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3951 (backtrace_command_1): Add frame_print_options and
3952 backtrace_cmd_options parameters and use them.
3953 (make_backtrace_options_def_group): New.
3954 (backtrace_command): Process command options with
3955 gdb::option::process_options.
3956 (backtrace_command_completer): New.
3957 (_initialize_stack): Extend "backtrace"'s help to mention
3958 supported options. Install completer for "backtrace".
3959 Install some settings commands with add_setshow_cmds_for_options.
3960
3961 2019-06-13 Pedro Alves <palves@redhat.com>
3962
3963 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3964 and that "set/show print raw frame-arguments" are now deprecated.
3965
3966 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3967 command.
3968 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3969 * stack.c (_initialize_stack): Install "set/show print
3970 raw-frame-arguments", and deprecate "set/show print raw
3971 frame-arguments".
3972 * valprint.c (_initialize_valprint): Deprecate "set/show print
3973 raw".
3974
3975 2019-06-13 Pedro Alves <palves@redhat.com>
3976
3977 * compile/compile.c (struct compile_options): New.
3978 (compile_flag_option_def, compile_command_option_defs)
3979 (make_compile_options_def_group): New.
3980 (compile_file_command): Handle options with
3981 gdb::option::process_options.
3982 (compile_file_command_completer): New function.
3983 (compile_code_command): Handle options with
3984 gdb::option::process_options.
3985 (compile_code_command_completer): New function.
3986 (_initialize_compiler): Install completers for "compile code" and
3987 "compile file". Mention available options in "compile code" and
3988 "compile code"'s help.
3989 * completer.c (advance_to_completion_word): New, factored out from
3990 ...
3991 (advance_to_expression_complete_word_point): ... this.
3992 (advance_to_filename_complete_word_point): New.
3993 * completer.h (advance_to_filename_complete_word_point): New
3994 declaration.
3995
3996 2019-06-13 Pedro Alves <palves@redhat.com>
3997
3998 * compile/compile.c: Include "cli/cli-option.h".
3999 (compile_print_value): Scope data pointer is now a
4000 value_print_options pointer; adjust.
4001 (compile_print_command): Process options. Scope data pointer is
4002 now a value_print_options pointer; adjust.
4003 (_initialize_compile): Update "compile print"'s help to include
4004 supported options. Install a completer for "compile print".
4005 * cp-valprint.c (show_vtblprint, show_objectprint)
4006 (show_static_field_print): Delete.
4007 (_initialize_cp_valprint): Don't install "set print
4008 static-members", "set print vtbl", "set print object" here.
4009 * printcmd.c: Include "cli/cli-option.h" and
4010 "common/gdb_optional.h".
4011 (print_command_parse_format): Rework to fill in a
4012 value_print_options instead of a format_data.
4013 (print_value): Change parameter type from format_data pointer to
4014 value_print_options reference. Adjust.
4015 (print_command_1): Process options. Adjust to pass down a
4016 value_print_options.
4017 (print_command_completer): New.
4018 (_initialize_printcmd): Install print_command_completer as
4019 handle_brkchars completer for the "print" command. Update
4020 "print"'s help to include supported options.
4021 * valprint.c: Include "cli/cli-option.h".
4022 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4023 here from cp-valprint.c.
4024 (boolean_option_def, uinteger_option_def)
4025 (value_print_option_defs, make_value_print_options_def_group):
4026 New. Use gdb::option::add_setshow_cmds_for_options to install
4027 "set print elements", "set print null-stop", "set print repeats",
4028 "set print pretty", "set print union", "set print array", "set
4029 print address", "set print symbol", "set print array-indexes".
4030 * valprint.h: Include <string> and "cli/cli-option.h".
4031 (make_value_print_options_def_group): Declare.
4032 (print_value): Change parameter type from format_data pointer to
4033 value_print_options reference.
4034 (print_command_completer): Declare.
4035
4036 2019-06-13 Pedro Alves <palves@redhat.com>
4037
4038 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4039 (COMMON_SFILES): Add maint-test-settings.c.
4040 * cli/cli-decode.c (boolean_enums): New global, factored out from
4041 ...
4042 (add_setshow_boolean_cmd): ... here.
4043 * cli/cli-decode.h (boolean_enums): Declare.
4044 * cli/cli-option.c: New file.
4045 * cli/cli-option.h: New file.
4046 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4047 factored out from ...
4048 (parse_cli_boolean_value(const char *)): ... this.
4049 (is_unlimited_literal): Change parameter type to pointer to
4050 pointer. Adjust and advance ARG pointer.
4051 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4052 (parse_cli_var_enum): New, factored out from ...
4053 (do_set_command): ... this. Adjust.
4054 * cli/cli-setshow.h (parse_cli_boolean_value)
4055 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4056 (parse_cli_var_enum): Declare.
4057 * cli/cli-utils.c: Include "cli/cli-option.h".
4058 (get_ulongest): New.
4059 * cli/cli-utils.h (get_ulongest): Declare.
4060 (check_for_argument): New overloads.
4061 * maint-test-options.c: New file.
4062
4063 2019-06-13 Pedro Alves <palves@redhat.com>
4064
4065 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4066 parse a range if "-" is at the end of the string.
4067
4068 2019-06-13 Pedro Alves <palves@redhat.com>
4069
4070 * cli/cli-setshow.c (parse_auto_binary_operation)
4071 (parse_cli_boolean_value): Don't allow "o".
4072
4073 2019-06-13 Pedro Alves <palves@redhat.com>
4074
4075 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4076 * NEWS: Mention maint test-settings KIND.
4077 * maint-test-settings.c: New file.
4078
4079 2019-06-13 Pedro Alves <palves@redhat.com>
4080
4081 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4082 completer.
4083 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4084 "set" completers.
4085
4086 2019-06-13 Pedro Alves <palves@redhat.com>
4087
4088 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4089 after item.
4090
4091 2019-06-13 Pedro Alves <palves@redhat.com>
4092
4093 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4094
4095 2019-06-13 Pedro Alves <palves@redhat.com>
4096
4097 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4098 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4099 call.
4100 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4101 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4102 calls.
4103 (check_for_argument): Skip spaces after argument.
4104
4105 2019-06-13 Pedro Alves <palves@redhat.com>
4106
4107 * thread.c (thread_apply_command): Adjust TID parsing.
4108 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4109 detected before end of string.
4110 (tid_is_in_list): Error out if LIST is invalid.
4111
4112 2019-06-13 Pedro Alves <palves@redhat.com>
4113
4114 * completer.c (complete_line_internal_1): Rewind completion word
4115 point.
4116 (completion_tracker::advance_custom_word_point_by): Change
4117 parameter type to int.
4118 * completer.h (completion_tracker::advance_custom_word_point_by):
4119 Likewise.
4120
4121 2019-06-13 Pedro Alves <palves@redhat.com>
4122
4123 * completer.c (advance_to_completion_word): Handle delimiters.
4124
4125 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4126
4127 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4128
4129 2019-06-11 Tom Tromey <tom@tromey.com>
4130
4131 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4132 (xmalloc_failed): Move to alloc.c.
4133 * alloc.c: New file.
4134 * Makefile.in (COMMON_SFILES): Add alloc.c.
4135
4136 2019-06-11 Tom Tromey <tom@tromey.com>
4137
4138 * nat/linux-waitpid.c: Don't include server.h.
4139 (linux_debug): Remove.
4140 (my_waitpid): Update.
4141
4142 2019-06-11 Tom Tromey <tromey@adacore.com>
4143
4144 * infcall.c (_initialize_infcall): Remove trailing newline from
4145 help.
4146 * user-regs.c (_initialize_user_regs): Remove trailing newline
4147 from help.
4148 * typeprint.c (_initialize_typeprint): Remove trailing newline
4149 from help.
4150 * reverse.c (_initialize_reverse): Remove trailing newlines from
4151 help.
4152 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4153 from help.
4154 * language.c (add_set_language_command): Remove trailing newline
4155 from help.
4156 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4157 help.
4158 * disasm.c (_initialize_disasm): Remove trailing newline from
4159 help.
4160 * top.c (init_main): Remove trailing newline from help.
4161 * interps.c (_initialize_interpreter): Remove trailing newline
4162 from help.
4163 * btrace.c (_initialize_btrace): Remove trailing newlines from
4164 help.
4165 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4166 from help.
4167 * python/python.c (_initialize_python): Remove trailing newline
4168 from help.
4169 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4170 help.
4171 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4172 from help. Reformat some text.
4173 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4174 from help.
4175 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4176 newline from help.
4177
4178 2019-06-11 Tom Tromey <tromey@adacore.com>
4179
4180 * darwin-nat.c (darwin_decode_exception_message)
4181 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4182
4183 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4184
4185 * valops.c (value_slice): Check for not allocated or not
4186 associated values.
4187
4188 2019-06-10 Tom de Vries <tdevries@suse.de>
4189
4190 PR gdb/24618
4191 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4192 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4193 invalid.
4194
4195 2019-06-10 Tom de Vries <tdevries@suse.de>
4196
4197 PR gdb/24611
4198 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4199 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4200
4201 2019-06-10 Tom de Vries <tdevries@suse.de>
4202
4203 PR symtab/24545
4204 * symtab.c (struct demangled_name_entry): Add language field.
4205 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4206 static minimal symbol". Set and use language field.
4207
4208 2019-06-10 Tom Tromey <tromey@adacore.com>
4209
4210 * ada-lang.c (_initialize_ada_language): Update help text.
4211
4212 2019-06-10 Tom Tromey <tromey@adacore.com>
4213
4214 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4215 with a newline.
4216 * guile/guile.c (handle_boot_error): Don't end warning with a
4217 newline.
4218 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4219 warning with a newline.
4220 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4221 newline.
4222 (s12z_frame_cache): Likewise.
4223 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4224 a newline.
4225 * solib-svr4.c (disable_probes_interface): Don't end warning with
4226 a newline.
4227 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4228 newline.
4229 * python/python.c (do_finish_initialization): Don't end warning
4230 with a newline.
4231
4232 2019-06-10 Tom Tromey <tom@tromey.com>
4233
4234 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4235 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4236 gdbpy_enter.
4237
4238 2019-06-10 Tom Tromey <tromey@adacore.com>
4239
4240 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4241 data.
4242 (elf_new_init): Don't call stabsread_new_init.
4243 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4244 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4245 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4246
4247 2019-06-10 Tom de Vries <tdevries@suse.de>
4248
4249 PR symtab/16264
4250 PR symtab/24517
4251 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4252
4253 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4254
4255 * source.c (find_and_open_source): Also rewrite relative file
4256 names.
4257
4258 2019-04-26 Amos Bird <amosbird@gmail.com>
4259
4260 * annotate.c (annotate_thread_exited): Add "thread-exited"
4261 annotation.
4262
4263 2019-06-06 Tom Tromey <tromey@adacore.com>
4264
4265 * maint.h (class scoped_command_stats): Use
4266 DISABLE_COPY_AND_ASSIGN.
4267 <print_time>: New method.
4268 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4269 print_time.
4270 (scoped_command_stats::print_time): New method.
4271
4272 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4273
4274 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4275 instructions of lengths 6 or 8 bytes.
4276
4277 2019-06-04 Pedro Alves <palves@redhat.com>
4278
4279 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4280
4281 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4282 * breakpoint.c (condition_completer): Likewise.
4283 * cli/cli-dump.c (scan_expression): Likewise.
4284 * common/filestuff.c (mkdir_recursive): Likewise.
4285 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4286 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4287 (gdb_abspath): Likewise.
4288 * compile/compile-cplus-types.c
4289 (compile_cplus_instance::decl_name): Likewise.
4290 * completer.c (complete_explicit_location):
4291 (signal_completer, reg_or_group_completer_1): Likewise.
4292 * cp-support.c (cp_remove_params_if_any): Likewise.
4293 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4294 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4295 * infcmd.c (strip_bg_char): Likewise.
4296 * linespec.c (copy_token_string): Likewise.
4297 * mi/mi-main.c (output_cores): Likewise.
4298 * psymtab.c (psymtab_search_name):
4299 * symfile.c (test_set_ext_lang_command): Likewise.
4300 * target.c (target_fileio_read_stralloc): Likewise.
4301 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4302 * value.c (complete_internalvar): Likewise.
4303
4304 2019-06-04 Christian Biesinger <cbiesinger@google.com>
4305
4306 Add objfile property to gdb.Type.
4307 * NEWS: Mention Python API addition.
4308 * python/py-type.c (typy_get_objfile): New method.
4309
4310 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4311
4312 * NEWS: Mention the new set|show style [title|highlight].
4313 Mention changes to "show style", "help" and "apropos".
4314
4315 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4316
4317 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4318 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4319 instead of print_help_for_command.
4320 (print_doc_of_command): New function.
4321 (help_list): Add 'apropos -v word' suggestion.
4322 (print_help_for_command): Style the command name using title style.
4323 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4324 (_initialize_cli_cmds): Describe -v in apropos_command help.
4325
4326 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4327
4328 * cli/cli-style.h (cli_style_option): Add name in constructor,
4329 add m_name class member, add constructor with intensity,
4330 add name class function.
4331 (cli_style_option::add_setshow_commands): Remove name argument.
4332 (highlight_style, title_style): New styles.
4333 * cli/cli-style.c (do_show): New function that shows a style
4334 characteristic styling the style name with itself.
4335 (set_style_name): New function.
4336 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4337 Update all callers according to the changes in cli/cli-style.h.
4338 * utils.h (fputs_highlighted): New function.
4339 * utils.c (fputs_highlighted): Likewise.
4340
4341 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4342
4343 * NEWS: Mention new pipe command and new convenience variables.
4344
4345 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4346
4347 * cli/cli-cmds.c (pipe_command): New function.
4348 (_initialize_cli_cmds): Call add_com for pipe_command.
4349 Define | as an alias for pipe.
4350 (exit_status_set_internal_vars): New function.
4351 (shell_escape): Call exit_status_set_internal_vars.
4352 cli/cli-decode.c (find_command_name_length): Recognize | as
4353 a single character command.
4354
4355 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4356
4357 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4358 top.c (execute_command_to_ui_file): New function, mostly a copy
4359 of execute_command_to_string.
4360 (execute_command_to_string): Implement by calling
4361 execute_command_to_ui_file.
4362
4363 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4364
4365 * top.h (saved_command_line): Remove declaration.
4366 * top.c (previous_saved_command_line, previous_repeat_arguments):
4367 New variables.
4368 (saved_command_line): Make static, define together with other
4369 'repeat variables'.
4370 (dont_repeat): Clear repeat_arguments.
4371 (repeat_previous, get_saved_command_line, save_command_line):
4372 New functions.
4373 (gdb_init): Initialize saved_command_line
4374 and previous_saved_command_line.
4375 * main.c (captured_main_1): Remove saved_command_line initialization.
4376 * event-top.c (handle_line_of_input): Update to use
4377 the new 'repeat' related functions instead of direct access to
4378 saved_command_line.
4379 * command.h (repeat_previous, get_saved_command_line,
4380 save_command_line): New declarations.
4381 (dont_repeat): Add comment.
4382
4383 2019-05-30 Tom Tromey <tromey@adacore.com>
4384
4385 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4386 Fix comment.
4387 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4388
4389 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4390
4391 PR cli/24587
4392 * completer.c (complete): Initialize variable word.
4393
4394 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4395
4396 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4397 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4398 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4399 'body' is NULL to the outter 'if', protecting the '!is_define'
4400 situation as well.
4401
4402 2019-05-29 Tom Tromey <tromey@adacore.com>
4403
4404 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4405 (dwarf_unknown): New function.
4406 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4407 (dwarf_type_encoding_name): Use dwarf_unknown.
4408
4409 2019-05-29 Tom Tromey <tromey@adacore.com>
4410
4411 PR c++/20020:
4412 * cp-valprint.c (cp_print_value_fields): Call
4413 cp_print_static_field inside "try".
4414
4415 2019-05-29 Tom Tromey <tromey@adacore.com>
4416
4417 * inflow.c (struct terminal_info): Add default operator=.
4418 * configure: Rebuild.
4419 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4420 -Wdeprecated-copy-dtor, -Wredundant-move.
4421
4422 2019-05-29 Tom Tromey <tromey@adacore.com>
4423
4424 * NEWS: Add entry.
4425 * infcmd.c (print_return_value_1): Handle finish_print
4426 option.
4427 (show_print_finish): New function.
4428 (_initialize_infcmd): Add "set/show print finish" commands.
4429 * valprint.c (user_print_options): Initialize new member.
4430 * valprint.h (struct value_print_options) <finish_print>: New
4431 member.
4432
4433 2019-05-28 Tom Tromey <tromey@adacore.com>
4434
4435 * ada-lang.c (ada_remove_Xbn_suffix)
4436 (find_old_style_renaming_symbol)
4437 (parse_old_style_renaming): Remove.
4438 (ada_find_renaming_symbol): Don't call
4439 find_old_style_renaming_symbol.
4440 (ada_is_renaming_symbol): Rename from
4441 ada_find_renaming_symbol. Remove "block" parameter. Return
4442 bool. Now static.
4443 (ada_read_var_value): Update and simplify.
4444 * ada-exp.y (write_var_or_type): Remove old code.
4445
4446 2019-05-28 Alan Hayward <alan.hayward@arm.com>
4447
4448 * event-top.c: Remove include comment.
4449 * inflow.c (class scoped_ignore_sigttou): Move from here...
4450 * inflow.h (class scoped_ignore_sigttou): ...to here.
4451 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4452 * top.c: Remove include comment.
4453
4454 2019-05-27 Tom Tromey <tom@tromey.com>
4455
4456 * NEWS: Fix typo.
4457
4458 2019-05-22 Tom Tromey <tromey@adacore.com>
4459
4460 * target.c (target_follow_exec): Constify parameter.
4461 * target-delegates.c: Rebuild.
4462 * remote.c (remote_target::follow_exec): Constify parameter.
4463 * infrun.c (follow_exec): Constify parameter.
4464 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4465 (target_follow_exec): Likewise.
4466
4467 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4468
4469 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4470 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4471
4472 2019-05-22 Alan Hayward <alan.hayward@arm.com>
4473
4474 * NEWS: Add debugredirect and testsuite sections.
4475
4476 2019-05-22 Simon Cook <simon.cook@embecosm.com>
4477
4478 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4479 target descriptions using exclusively floating point register name
4480 aliases.
4481
4482 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4483
4484 PR gdb/18644:
4485 * f-lang.c (build_fortran_types): Handle the case where
4486 gdbarch_floatformat_for_type returns a nullptr.
4487
4488 2019-05-21 Tom de Vries <tdevries@suse.de>
4489
4490 PR cli/24587
4491 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4492
4493 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4494
4495 PR gdb/18644:
4496 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4497 16-byte floats.
4498 * i386-tdep.c (i386_floatformat_for_type): Use
4499 floatformats_ia64_quad for the 16-byte floating point component
4500 within a fortran 32-byte complex number.
4501
4502 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4503
4504 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4505 delete default constructor.
4506 (find_partial_die): Update to return const struct.
4507 (partial_die_parent_scope): Move variable declaration into scope
4508 of its use and change its type to auto.
4509 (guess_partial_die_structure_name): Likewise.
4510 (partial_die_info::fixup): Likewise.
4511
4512 2019-05-17 Tom Tromey <tromey@adacore.com>
4513
4514 * source.c (find_and_open_source): Remove cast.
4515
4516 2019-05-17 Tom Tromey <tromey@adacore.com>
4517
4518 * annotate.c (annotate_source): Make "filename" const.
4519 * annotate.h (annotate_source): Use const.
4520
4521 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4522
4523 * disasm.c (set_disassembler_options): Send errors to stderr.
4524
4525 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4526
4527 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4528 (cli_interp_base::set_logging): Check debug_redirect.
4529 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4530 * cli/cli-logging.c (debug_redirect): Add static variable.
4531 (pop_output_files): Add default param.
4532 (handle_redirections): Print debug setting.
4533 (show_logging_command): Likewise.
4534 (_initialize_cli_logging): Add debugredirect command.
4535 * interps.c (current_interp_set_logging): Add debug_redirect
4536 parameter.
4537 * interps.h (set_logging): Add debug_redirect parameter.
4538 (current_interp_set_logging): Likewise.
4539 * mi/mi-common.h: Likewise.
4540 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4541
4542 2019-05-17 Alan Hayward <alan.hayward@arm.com>
4543 Tom Tromey <tromey@adacore.com>
4544
4545 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4546 directly.
4547 * cli/cli-interp.h (make_logging_output): Remove declaration.
4548 * cli/cli-logging.c (make_logging_output): Remove function.
4549 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4550 directly.
4551 * ui-file.c (tee_file::tee_file): Remove bools.
4552 (tee_file::~tee_file): Remove deletes.
4553 * ui-file.h (tee_file): Remove bools.
4554
4555 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4556
4557 * mi/mi-cmds.h (mi_cmd_complete): New function.
4558 * mi/mi-main.c (mi_cmd_complete): Likewise.
4559 * mi/mi-cmds.c: Define new MI command -complete.
4560 * NEWS: Mention new -complete command.
4561
4562 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4563
4564 * completer.h (complete): New function.
4565 * completer.c (complete): Likewise.
4566 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4567 function defined in completer.h.
4568
4569 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4570
4571 * MAINTAINERS (Write After Approval): Add myself.
4572
4573 2019-05-17 Tom de Vries <tdevries@suse.de>
4574
4575 PR gdb/24094
4576 * dwarf2read.c (struct cu_partial_die_info): New struct.
4577 (find_partial_die): Return cu_partial_die_info.
4578 (partial_die_parent_scope, guess_partial_die_structure_name)
4579 (partial_die_info::fixup): Handle new return type of find_partial_die.
4580
4581 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4582
4583 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4584 "std::string", simplifying the algorithm.
4585
4586 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4587
4588 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4589 (stap_static_probe_ops::get_probes): Likewise.
4590
4591 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4592
4593 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4594 '-')" and "else if".
4595 (stap_parse_single_operand): Join checks for
4596 "gdbarch_stap_parse_special_token_p" and
4597 "gdbarch_stap_parse_special_token" in the same "if" statement.
4598 Invert check when verifying for operation on register
4599 displacement.
4600
4601 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4602
4603 * stap-probe.c (stap_get_opcode): Update comment.
4604 (stap_get_expected_argument_type): Likewise.
4605 (handle_stap_probe): Likewise.
4606
4607 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4608
4609 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4610 return type to 'bool'. Adjust comment. Use 'bool' when
4611 appropriate.
4612 (i386_stap_parse_special_token_three_arg_disp): Likewise.
4613 * stap-probe.c (stap_parse_argument_1): Likewise.
4614 (stap_is_operator): Likewise.
4615 (stap_is_generic_prefix): Likewise.
4616 (stap_is_register_prefix): Likewise.
4617 (stap_is_register_indirection_prefix): Likewise.
4618 (stap_is_integer_prefix): Likewise.
4619 (stap_generic_check_suffix): Likewise.
4620 (stap_check_integer_suffix): Likewise.
4621 (stap_check_register_suffix): Likewise.
4622 (stap_check_register_indirection_suffix): Likewise.
4623 (stap_parse_register_operand): Likewise.
4624 (stap_parse_single_operand): Likewise.
4625 (stap_parse_argument_1): Likewise.
4626 (stap_probe::get_argument_count): Likewise.
4627 (stap_is_operator): Likewise.
4628
4629 2019-05-16 Tom Tromey <tromey@adacore.com>
4630
4631 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4632 keyword to foreach.
4633
4634 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
4635
4636 * linux-thread-db.c (try_thread_db_load_1): Change return type
4637 to bool.
4638 (try_thread_db_load): Likewise.
4639 (try_thread_db_load_from_pdir_1): Likewise.
4640 (try_thread_db_load_from_pdir): Likewise.
4641 (try_thread_db_load_from_sdir): Likewise.
4642 (try_thread_db_load_from_dir): Likewise.
4643 (thread_db_load_search): Likewise.
4644 (has_libpthread): Likewise.
4645 (thread_db_load): Likewise.
4646
4647 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
4648
4649 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4650 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4651 NULL, and complain/return if that's the case.
4652
4653 2019-05-15 John Darrington <john@darrington.wattle.id.au>
4654
4655 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4656 (advance, posn, abstract_read_memory): New functions.
4657 [struct mem_read_abstraction]: New struct.
4658 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4659
4660 2019-05-14 Tom Tromey <tromey@adacore.com>
4661
4662 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4663 value is not lval_memory.
4664
4665 2019-05-14 Tom Tromey <tromey@adacore.com>
4666
4667 * solib.c (info_sharedlibrary_command): Style the file name.
4668
4669 2019-05-14 Alan Hayward <alan.hayward@arm.com>
4670
4671 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4672 (aarch64_vnv_type): Likewise.
4673 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4674 * common/tdesc.c: Likewise.
4675 * common/tdesc.h (enum tdesc_type_kind): Likewise.
4676 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4677 * features/aarch64-fpu.xml: Add ieee half view.
4678 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4679 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4680 * gdbtypes.h (struct builtin_type): Likewise.
4681 (struct objfile_type): Likewise.
4682
4683 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
4684
4685 * language.c (language_sniff_from_mangled_name): Fix "langauge"
4686 typo.
4687 * location.h (string_to_event_location): Likewise.
4688
4689 2019-05-11 Joel Brobecker <brobecker@adacore.com>
4690
4691 GDB 8.3 released.
4692
4693 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4694
4695 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4696 New variable declaration.
4697 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4698 New variable.
4699 (print_one_breakpoint): Use ui_out::test_flags and new global
4700 variable to compute use_fixed_output.
4701 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4702 Remove.
4703 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4704 (mi_multi_location_breakpoint_output_fixed): Remove.
4705 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4706 new variable.
4707 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4708 fix_multi_location_breakpoint_output flag if version >= 3.
4709 * ui-out.h (enum ui_out_flag)
4710 <fix_multi_location_breakpoint_output>: New enumerator.
4711
4712 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
4713
4714 * contrib/cc-with-tweaks.sh: Validate dwz's work.
4715
4716 2019-05-10 Tom Tromey <tromey@adacore.com>
4717
4718 * ada-lang.c (catch_ada_completer): New function.
4719 (_initialize_ada_language): Use it.
4720
4721 2019-05-10 Tom Tromey <tromey@adacore.com>
4722
4723 * thread.c (print_thread_info): Make "requested_threads" const.
4724 * gdbthread.h (print_thread_info): Make "requested_threads"
4725 const.
4726 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4727 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4728
4729 2019-05-08 Tom Tromey <tom@tromey.com>
4730
4731 * gdbtypes.c (objfile_type_data): Change type.
4732 (objfile_type, _initialize_gdbtypes): Update.
4733
4734 2019-05-08 Tom Tromey <tom@tromey.com>
4735
4736 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4737 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4738 (_initialize_dwarf2_frame): Update.
4739
4740 2019-05-08 Tom Tromey <tom@tromey.com>
4741
4742 * objc-lang.c (objc_objfile_data): Change type.
4743 (find_methods): Update.
4744 (_initialize_objc_lang): Remove.
4745
4746 2019-05-08 Tom Tromey <tom@tromey.com>
4747
4748 * stabsread.c (rs6000_builtin_type_data): Change type.
4749 (rs6000_builtin_type, _initialize_stabsread): Update.
4750
4751 2019-05-08 Tom Tromey <tom@tromey.com>
4752
4753 * mips-tdep.c (mips_pdr_data): Remove.
4754 (_initialize_mips_tdep): Update.
4755
4756 2019-05-08 Tom Tromey <tom@tromey.com>
4757
4758 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4759 (hppa_init_objfile_priv_data, read_unwind_info)
4760 (find_unwind_entry, _initialize_hppa_tdep): Update.
4761
4762 2019-05-08 Tom Tromey <tom@tromey.com>
4763
4764 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4765 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
4766 on obstack.
4767 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4768
4769 2019-05-08 Tom Tromey <tom@tromey.com>
4770
4771 * mdebugread.c (basic_type_data): Change type.
4772 (basic_type, _initialize_mdebugread): Update.
4773
4774 2019-05-08 Tom Tromey <tom@tromey.com>
4775
4776 * common/gdb_unique_ptr.h (struct noop_deleter): New.
4777
4778 2019-05-08 Tom Tromey <tom@tromey.com>
4779
4780 * nto-tdep.c (nto_inferior_data_reg): Change type.
4781 (nto_inferior_data): Update.
4782 (nto_inferior_data_cleanup, nto_new_inferior_data)
4783 (_initialize_nto_tdep): Remove.
4784 * nto-tdep.h (struct nto_inferior_data): Add initializers.
4785
4786 2019-05-08 Tom Tromey <tom@tromey.com>
4787
4788 * ada-lang.c (struct ada_inferior_data): Add initializers.
4789 (ada_inferior_data): Change type.
4790 (ada_inferior_data_cleanup): Remove.
4791 (get_ada_inferior_data, ada_inferior_exit)
4792 (struct ada_pspace_data): Add initializers, destructor.
4793 (ada_pspace_data_handle): Change type.
4794 (get_ada_pspace_data): Update.
4795 (ada_pspace_data_cleanup): Remove.
4796
4797 2019-05-08 Tom Tromey <tom@tromey.com>
4798
4799 * coffread.c (struct coff_symfile_info): Add initializers.
4800 (coff_objfile_data_key): Move lower. Change type.
4801 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4802 Update.
4803 (coff_free_info): Remove.
4804
4805 2019-05-08 Tom Tromey <tom@tromey.com>
4806
4807 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4808 (fbsd_pspace_data_handle): Move lower. Change type.
4809 (get_fbsd_pspace_data): Update.
4810 (fbsd_pspace_data_cleanup): Remove.
4811 (_initialize_fbsd_tdep): Update.
4812
4813 2019-05-08 Tom Tromey <tom@tromey.com>
4814
4815 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4816 (get_ada_tasks_pspace_data): Update.
4817 (ada_tasks_pspace_data_cleanup): Remove.
4818 (_initialize_tasks): Update.
4819 (ada_tasks_inferior_data_handle): Change type.
4820 (get_ada_tasks_inferior_data): Update.
4821 (ada_tasks_inferior_data_cleanup): Remove.
4822 (struct ada_tasks_pspace_data): Add initializers.
4823
4824 2019-05-08 Tom Tromey <tom@tromey.com>
4825
4826 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4827 * symfile-debug.c (debug_sym_get_probes): Change type.
4828 * stap-probe.c (handle_stap_probe):
4829 (stap_static_probe_ops::get_probes): Change type.
4830 * probe.h (class static_probe_ops) <get_probes>: Change type.
4831 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4832 (parse_probes_in_pspace): Update.
4833 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4834 Update.
4835 (any_static_probe_ops::get_probes): Change type.
4836 * elfread.c (elfread_data): New typedef.
4837 (probe_key): Change type.
4838 (elf_get_probes): Likewise. Update.
4839 (probe_key_free): Remove.
4840 (_initialize_elfread): Update.
4841 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4842 Change type.
4843 (dtrace_process_dof_probe, dtrace_process_dof)
4844 (dtrace_static_probe_ops::get_probe): Change type.
4845
4846 2019-05-08 Tom Tromey <tom@tromey.com>
4847
4848 * xcoffread.c (struct xcoff_symfile_info): Rename from
4849 coff_symfile_info. Add initializers.
4850 (xcoff_objfile_data_key): Move lower. Change type.
4851 (XCOFF_DATA): Rewrite.
4852 (xcoff_free_info): Remove.
4853 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4854 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4855 (xcoff_initial_scan): Update.
4856
4857 2019-05-08 Tom Tromey <tom@tromey.com>
4858
4859 * solib-svr4.c (struct svr4_info): Add initializers and
4860 destructor.
4861 <probes_table>: Now an htab_up.
4862 (solib_svr4_pspace_data): Change type.
4863 (free_probes_table): Simplify.
4864 (~svr4_info): Rename from svr4_pspace_data_cleanup.
4865 (get_svr4_info, probes_table_htab_remove_objfile_probes)
4866 (probes_table_remove_objfile_probes, register_solib_event_probe)
4867 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4868 (_initialize_svr4_solib): Update.
4869
4870 2019-05-08 Tom Tromey <tom@tromey.com>
4871
4872 * remote.c (remote_pspace_data): Change type.
4873 (remote_pspace_data_cleanup): Remove.
4874 (get_remote_exec_file, set_pspace_remote_exec_file)
4875 (_initialize_remote): Update.
4876
4877 2019-05-08 Tom Tromey <tom@tromey.com>
4878
4879 * breakpoint.c (breakpoint_objfile_key): Change type.
4880 (get_breakpoint_objfile_data): Update.
4881 (free_breakpoint_objfile_data): Remove.
4882 (_initialize_breakpoint): Update.
4883
4884 2019-05-08 Tom Tromey <tom@tromey.com>
4885
4886 * linux-tdep.c (struct linux_info): Add initializers.
4887 (linux_inferior_data): Move. Change type.
4888 (invalidate_linux_cache_inf): Update.
4889 (linux_inferior_data_cleanup): Remove.
4890 (get_linux_inferior_data, _initialize_linux_tdep): Update.
4891
4892 2019-05-08 Tom Tromey <tom@tromey.com>
4893
4894 * auxv.c (auxv_inferior_data): Move. Change type.
4895 (auxv_inferior_data_cleanup): Remove.
4896 (invalidate_auxv_cache_inf): Rewrite.
4897 (get_auxv_inferior_data, _initialize_auxv): Update.
4898
4899 2019-05-08 Tom Tromey <tom@tromey.com>
4900
4901 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4902 (symfile_debug_objfile_data_key): Change type.
4903 (symfile_debug_installed, debug_qf_has_symbols)
4904 (debug_qf_find_last_source_symtab)
4905 (debug_qf_forget_cached_source_info)
4906 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4907 (debug_qf_print_stats, debug_qf_dump)
4908 (debug_qf_expand_symtabs_for_function)
4909 (debug_qf_expand_all_symtabs)
4910 (debug_qf_expand_symtabs_with_fullname)
4911 (debug_qf_map_matching_symbols)
4912 (debug_qf_expand_symtabs_matching)
4913 (debug_qf_find_pc_sect_compunit_symtab)
4914 (debug_qf_map_symbol_filenames)
4915 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4916 (debug_sym_new_init, debug_sym_init, debug_sym_read)
4917 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4918 (debug_sym_read_linetable, debug_sym_relocate): Update.
4919 (symfile_debug_free_objfile): Remove.
4920 (install_symfile_debug_logging, _initialize_symfile_debug):
4921 Update.
4922
4923 2019-05-08 Tom Tromey <tom@tromey.com>
4924
4925 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4926 allocate_on_obstack.
4927 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4928 (get_dwarf2_per_objfile): Update.
4929 (set_dwarf2_per_objfile): Remove.
4930 (dwarf2_has_info, dwarf2_get_section_info): Update.
4931 (dwarf2_free_objfile): Remove.
4932 (_initialize_dwarf2_read): Update.
4933
4934 2019-05-08 Tom Tromey <tom@tromey.com>
4935
4936 * auto-load.c (struct auto_load_pspace_info): Add destructor and
4937 initializers.
4938 <unsupported_script_warning_printed,
4939 script_not_found_warning_printed>: Now bool.
4940 (auto_load_pspace_data): Change type.
4941 (~auto_load_pspace_info): Rename from
4942 auto_load_pspace_data_cleanup.
4943 (get_auto_load_pspace_data, init_loaded_scripts_info)
4944 (clear_section_scripts, maybe_print_unsupported_script_warning)
4945 (maybe_print_script_not_found_warning, _initialize_auto_load):
4946 Update.
4947
4948 2019-05-08 Tom Tromey <tom@tromey.com>
4949
4950 * objfiles.c (objfile_pspace_info): Add destructor and
4951 initializers.
4952 (objfiles_pspace_data): Change type.
4953 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4954 (get_objfile_pspace_data): Update.
4955 (objfiles_bfd_data): Change type.
4956 (get_objfile_bfd_data): Update.
4957 (objfile_bfd_data_free, _initialize_objfiles): Remove.
4958
4959 2019-05-08 Tom Tromey <tom@tromey.com>
4960
4961 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4962 Change type.
4963 (get_catch_syscall_inferior_data): Update.
4964 (catch_syscall_inferior_data_cleanup): Remove.
4965 (_initialize_break_catch_syscall): Update.
4966
4967 2019-05-08 Tom Tromey <tom@tromey.com>
4968
4969 * inflow.c (struct terminal_info): Add destructor and
4970 initializers.
4971 (inflow_inferior_data): Change type.
4972 (~terminal_info): Rename from inflow_inferior_data_cleanup.
4973 (get_inflow_inferior_data, inflow_inferior_exit)
4974 (swap_terminal_info, _initialize_inflow): Update.
4975
4976 2019-05-08 Tom Tromey <tom@tromey.com>
4977
4978 * target-dcache.c (target_dcache_cleanup): Remove.
4979 (target_dcache_aspace_key): Change type.
4980 (target_dcache_init_p, target_dcache_invalidate)
4981 (target_dcache_get, target_dcache_get_or_init)
4982 (_initialize_target_dcache): Update.
4983 * dcache.h (struct dcache_deleter): New.
4984
4985 2019-05-08 Tom Tromey <tom@tromey.com>
4986
4987 * symtab.c (struct symbol_cache): Add destructor and
4988 initializers.
4989 (symbol_cache_key): Move. Change type.
4990 (make_symbol_cache, free_symbol_cache): Remove.
4991 (get_symbol_cache): Update.
4992 (symbol_cache_cleanup): Remove.
4993 (ALL_PSPACES, symbol_cache_flush)
4994 (maintenance_print_symbol_cache)
4995 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4996 Update.
4997
4998 2019-05-08 Tom Tromey <tom@tromey.com>
4999
5000 * symtab.c (struct main_info): Add destructor and initializers.
5001 (main_progspace_key): Move. Change type.
5002 (get_main_info): Update.
5003 (main_info_cleanup): Remove.
5004 (_initialize_symtab): Update.
5005
5006 2019-05-08 Tom Tromey <tom@tromey.com>
5007
5008 * registry.h (DECLARE_REGISTRY): Define the _key class.
5009
5010 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5011
5012 * NEWS: Merge two 'New commands' sections.
5013
5014 2019-05-08 Joel Brobecker <brobecker@adacore.com>
5015
5016 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5017 parameter and use Ada language definition instead.
5018 (ada_val_print_ptr): Remove unused language parameter.
5019 (ada_val_print_num): Remove language parameter and use Ada language
5020 definition instead.
5021 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5022 parameter.
5023 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5024 parameter and use Ada language definition instead.
5025 (ada_val_print_1): Update all ada_val_print_xxx calls.
5026 Remove language parameter.
5027 (ada_val_print): Update ada_val_print_1 call.
5028
5029 2019-05-08 Tom Tromey <tromey@adacore.com>
5030
5031 * remote.c (remote_hw_watchpoint_limit)
5032 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5033 Now static.
5034
5035 2019-05-08 Tom Tromey <tromey@adacore.com>
5036
5037 * maint.c (_initialize_maint_cmds): Move initialization code to
5038 remote.c.
5039 (watchdog, show_watchdog): Move to remote.c.
5040 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5041 "watchdog" static.
5042 (_initialize_remote): Move initialization code from maint.c.
5043 * defs.h (watchdog): Don't declare.
5044
5045 2019-05-08 Tom Tromey <tromey@adacore.com>
5046
5047 * tui/tui-interp.c: Include main.h.
5048 * interps.c: Include main.h.
5049 * main.h (interpreter_p): Declare.
5050 * defs.h (interpreter_p): Don't declare.
5051
5052 2019-05-08 Tom Tromey <tromey@adacore.com>
5053
5054 * dwarf2loc.c: Include dwarf2read.h.
5055 * defs.h (read_unsigned_leb128): Don't declare.
5056 * dwarf2read.h (read_unsigned_leb128): Declare.
5057
5058 2019-05-08 Tom Tromey <tromey@adacore.com>
5059
5060 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5061 method.
5062
5063 2019-05-08 Tom Tromey <tromey@adacore.com>
5064
5065 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5066 when no wrap column is set.
5067
5068 2019-05-08 Tom Tromey <tromey@adacore.com>
5069
5070 * c-lang.c (c_get_string): Handle non-C-style arrays.
5071
5072 2019-05-08 Tom Tromey <tromey@adacore.com>
5073
5074 * typeprint.c (print_offset_data::update): Print the bit offset,
5075 not the number of bits remaining.
5076
5077 2019-05-08 Tom Tromey <tromey@adacore.com>
5078
5079 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5080 padding at end of comment.
5081
5082 2019-05-08 Tom Tromey <tromey@adacore.com>
5083
5084 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5085 Compare main types.
5086
5087 2019-05-06 Tom Tromey <tom@tromey.com>
5088
5089 * common/scoped_mmap.c: Include common-defs.h.
5090 * common/scoped_mmap.h: Don't include config.h.
5091
5092 2019-05-04 Tom Tromey <tom@tromey.com>
5093
5094 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5095 (struct aarch64_call_info): Add initializers.
5096 <si>: Now a std::vector.
5097 (pass_on_stack, aarch64_push_dummy_call): Update.
5098
5099 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
5100 Tom Tromey <tom@tromey.com>
5101
5102 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5103 (ppc_threads): Now a std::vector. Now static.
5104 (hwdebug_find_thread_points_by_tid)
5105 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5106 Update.
5107
5108 2019-05-04 Tom Tromey <tom@tromey.com>
5109
5110 * arc-tdep.c (arc_tdesc_init): Return bool.
5111
5112 2019-05-04 Tom Tromey <tom@tromey.com>
5113
5114 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5115 Use gdb_assert_not_reached.
5116
5117 2019-05-04 Tom Tromey <tom@tromey.com>
5118
5119 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5120 "false".
5121
5122 2019-05-04 Tom Tromey <tom@tromey.com>
5123
5124 * arc-tdep.c (arc_tdesc_init): Use bool.
5125
5126 2019-05-04 Tom Tromey <tom@tromey.com>
5127
5128 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5129
5130 2019-05-04 Tom Tromey <tom@tromey.com>
5131
5132 * cli/cli-cmds.c (valid_command_p): Return bool.
5133
5134 2019-05-04 Tom Tromey <tom@tromey.com>
5135
5136 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5137 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5138
5139 2019-05-04 Raul Tambre <raul@tambre.ee>
5140
5141 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5142 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5143 operator for comparison.
5144
5145 2019-05-04 Tom Tromey <tom@tromey.com>
5146
5147 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5148 (lookup_partial_symbol, print_partial_symbols)
5149 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5150 (psymbol_compare): Update.
5151 (add_psymbol_to_bcache): Clear the entire psymbol.
5152 (maintenance_check_psymtabs): Update.
5153 * psympriv.h (struct partial_symbol): Don't derive from
5154 general_symbol_info.
5155 <obj_section, unrelocated_address, address,
5156 set_unrelocated_address>: Update.
5157 <ginfo>: New member.
5158 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5159 (debug_names::write_psymbols): Update.
5160
5161 2019-05-04 Tom de Vries <tdevries@suse.de>
5162
5163 * contrib/cc-with-tweaks.sh: Support -n arg.
5164
5165 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5166
5167 * corelow.c (core_target::detach): Ensure frame cache and
5168 register caches are cleared.
5169 inferior.c (exit_inferior_1): Likewise.
5170
5171 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5172 Tom Tromey <tom@tromey.com>
5173
5174 * dictionary.c (collate_pending_symbols_by_language): Remove
5175 "struct" from foreach.
5176 * symtab.c (lookup_global_symbol_from_objfile)
5177 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5178 foreach.
5179 * ser-tcp.c (net_open): Remove "struct" from foreach.
5180 * objfiles.c (objfile_relocate, objfile_rebase)
5181 (objfile_has_symbols): Remove "struct" from foreach.
5182 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5183 from foreach.
5184 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5185 foreach.
5186 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5187 "struct" from foreach.
5188 * ada-lang.c (create_excep_cond_exprs)
5189 (ada_exception_catchpoint_cond_string): Remove "struct" from
5190 foreach.
5191
5192 2019-05-03 Tom Tromey <tromey@adacore.com>
5193
5194 * ada-exp.y (convert_char_literal): Check suffix of each
5195 enumerator.
5196
5197 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5198
5199 PR ada/21406:
5200 * ada-exp.y (yywrap): Don't define.
5201 * ada-lex.l (%option): Add noyywrap
5202 (yywrap): Remove.
5203
5204 2019-05-03 Eli Zaretskii <eliz@gnu.org>
5205
5206 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5207 _WIN32_WINNT to the XP level, unless already defined to a higher
5208 level.
5209
5210 * unittests/parse-connection-spec-selftests.c:
5211 * ser-tcp.c:
5212 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5213 override.
5214
5215 * symfile.c (find_separate_debug_file): Remove colon from the
5216 drive spec of DOS/Windows file names of the target, so that the
5217 file name produced from DEBUGDIR and the target's directory will
5218 be valid on DOS/Windows systems.
5219
5220 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5221
5222 * rust-lang.c (val_print_struct): Handle printing structures
5223 containing strings.
5224
5225 2019-05-02 Tom Tromey <tromey@adacore.com>
5226
5227 * valarith.c (_initialize_valarith): Remove.
5228
5229 2019-05-01 Tom Tromey <tromey@adacore.com>
5230
5231 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5232 bitfields.
5233
5234 2019-05-01 Tom Tromey <tromey@adacore.com>
5235
5236 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5237 for big-endian copies.
5238
5239 2019-04-30 Ali Tamur <tamur@google.com>
5240 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5241 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5242 (read_3_bytes): New function.
5243
5244 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5245
5246 * windows-nat.c (main_thread_id): Delete.
5247 (handle_output_debug_string): Replace main_thread_id by
5248 current_event.dwThreadId.
5249 (fake_create_process): Likewise.
5250 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5251 Do not set main_thread_id.
5252 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5253 current_event.dwThreadId.
5254 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5255
5256 2019-04-30 Joel Brobecker <brobecker@adacore.com>
5257
5258 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5259 Use current_event.dwThreadId instead of main_thread_id.
5260
5261 2019-04-30 Tom Tromey <tromey@adacore.com>
5262
5263 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5264 (create_excep_cond_exprs): Iterate over program spaces.
5265 (ada_exception_catchpoint_cond_string): Examine all minimal
5266 symbols for exception types.
5267
5268 2019-04-30 Tom Tromey <tromey@adacore.com>
5269
5270 PR c++/24470:
5271 * dwarf2read.c (process_structure_scope): Handle case where type
5272 has template parameters but no symbol was created.
5273
5274 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5275 Chris January <chris.january@arm.com>
5276
5277 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5278 qualifier.
5279 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5280
5281 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5282
5283 * f-typeprint.c (f_print_type): Update rules for printing
5284 whitespace.
5285 (f_type_print_varspec_suffix): Likewise.
5286
5287 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5288 Chris January <chris.january@arm.com>
5289
5290 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5291 function arguments.
5292
5293 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5294
5295 * f-lang.c (build_fortran_types): Change name of void type to
5296 lower case.
5297 * f-typeprint.c (f_type_print_base): Print the name of the void
5298 type, rather than a fixed string.
5299 * f-valprint.c (f_decorations): Use lower case void string.
5300
5301 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5302 Chris January <chris.january@arm.com>
5303
5304 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5305 types for Fortran.
5306
5307 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5308 Chris January <chris.january@arm.com>
5309 David Lecomber <david.lecomber@arm.com>
5310
5311 * f-exp.y (BINOP_INTRINSIC): New token.
5312 (exp): New parser rule handling BINOP_INTRINSIC.
5313 (f77_keywords): Add new builtin procedures.
5314 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5315 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5316 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5317 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5318 (print_unop_subexp_f): New function.
5319 (print_binop_subexp_f): New function.
5320 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5321 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5322 (dump_subexp_body_f): Likewise.
5323 (operator_check_f): Likewise.
5324 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5325 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5326
5327 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5328
5329 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5330 UNOP_KIND.
5331 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5332 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5333 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5334 (operator_length_f): New fuction.
5335 (print_subexp_f): New function.
5336 (op_name_f): New function.
5337 (dump_subexp_body_f): New function.
5338 (operator_check_f): New function.
5339 (exp_descriptor_f): Replace standard expression handling functions
5340 with new functions.
5341 * gdb/fortran-operator.def: New file.
5342 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5343 * gdb/std-operator.def: Remove UNOP_KIND.
5344
5345 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5346
5347 * std-operator.def: Remove unbalanced, stray double quote
5348 character.
5349
5350 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5351 Chris January <chris.january@arm.com>
5352 Daniel Everett <daniel.everett@arm.com>
5353 Nick Forrington <nick.forrington@arm.com>
5354 Richard Bunt <richard.bunt@arm.com>
5355
5356 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5357 of depth when printing anonymous structs or unions.
5358 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5359 Don't print either the top-level value, or the children if the
5360 max-depth is exceeded.
5361 (ppscm_print_children): When printing the key of a map, allow one
5362 extra level of depth.
5363 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5364 print either the top-level value, or the children if the max-depth
5365 is exceeded.
5366 (print_children): When printing the key of a map, allow one extra
5367 level of depth.
5368 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5369 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5370 (user_print_options): Initialise max_depth field.
5371 (val_print_scalar_or_string_type_p): New function.
5372 (val_print): Check to see if the max depth has been reached.
5373 (val_print_check_max_depth): Define new function.
5374 (show_print_max_depth): New function.
5375 (_initialize_valprint): Add 'print max-depth' option.
5376 * valprint.h (struct value_print_options) <max_depth>: New field.
5377 (val_print_check_max_depth): Declare new function.
5378 * NEWS: Document new feature.
5379
5380 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5381
5382 * ada-lang.c (ada_language_defn): Initialise new field.
5383 * c-lang.c (c_is_string_type_p): New function.
5384 (c_language_defn): Initialise new field.
5385 (cplus_language_defn): Initialise new field.
5386 (asm_language_defn): Initialise new field.
5387 (minimal_language_defn): Initialise new field.
5388 * c-lang.h (c_is_string_type_p): Declare new function.
5389 * d-lang.c (d_language_defn): Initialise new field.
5390 * f-lang.c (f_is_string_type_p): New function.
5391 (f_language_defn): Initialise new field.
5392 * go-lang.c (go_is_string_type_p): New function.
5393 (go_language_defn): Initialise new field.
5394 * language.c (default_is_string_type_p): New function.
5395 (unknown_language_defn): Initialise new field.
5396 (auto_language_defn): Initialise new field.
5397 * language.h (struct language_defn) <la_is_string_type_p>: New
5398 member variable.
5399 (default_is_string_type_p): Declare new function.
5400 * m2-lang.c (m2_language_defn): Initialise new field.
5401 * objc-lang.c (objc_language_defn): Initialise new field.
5402 * opencl-lang.c (opencl_language_defn): Initialise new field.
5403 * p-lang.c (pascal_is_string_type_p): New function.
5404 (pascal_language_defn): Initialise new field.
5405 * rust-lang.c (rust_is_string_type_p): New function.
5406 (rust_language_defn): Initialise new field.
5407
5408 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5409
5410 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5411 New field.
5412 * ada-lang.c (ada_language_defn): Initialise new field.
5413 * c-lang.c (c_language_defn): Likewise.
5414 (cplus_language_defn): Likewise.
5415 (asm_language_defn): Likewise.
5416 (minimal_language_defn): Likewise.
5417 * d-lang.c (d_language_defn): Likewise.
5418 * f-lang.c (f_language_defn): Likewise.
5419 * go-lang.c (go_language_defn): Likewise.
5420 * language.c (unknown_language_defn): Likewise.
5421 (auto_language_defn): Likewise.
5422 * m2-lang.c (m2_language_defn): Likewise.
5423 * objc-lang.c (objc_language_defn): Likewise.
5424 * opencl-lang.c (opencl_language_defn): Likewise.
5425 * p-lang.c (pascal_language_defn): Likewise.
5426 * rust-lang.c (rust_language_defn): Likewise.
5427
5428 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5429
5430 * ada-lang.c (ada_is_character_type): Change return type to bool.
5431 (ada_is_string_type): Likewise.
5432 * ada-lang.h (ada_is_character_type): Update declaration
5433 (ada_is_string_type): Likewise.
5434
5435 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5436
5437 Support style in 'frame|thread apply'
5438
5439 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5440 * record.c (record_start, record_stop): Update callers of
5441 execute_command_to_string with false.
5442 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5443 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5444 methods.
5445 (class string_file): New constructor with term_out parameter.
5446 Override methods term_out and can_emit_style_escape. New member
5447 term_out.
5448 (class stdio_file): Override can_emit_style_escape.
5449 (class tee_file): Override term_out and can_emit_style_escape.
5450 * utils.h (can_emit_style_escape): Remove.
5451 * utils.c (can_emit_style_escape): Likewise.
5452 Update all callers of can_emit_style_escape (SOMESTREAM) to
5453 SOMESTREAM->can_emit_style_escape.
5454 * source-cache.c (source_cache::get_source_lines): Likewise.
5455 * stack.c (frame_apply_command_count): Call execute_command_to_string
5456 passing the term_out characteristic of the current gdb_stdout.
5457 * thread.c (thr_try_catch_cmd): Likewise.
5458 * top.c (execute_command_to_string): pass term_out parameter
5459 to construct the string_file for the command output.
5460 * ui-file.c (term_cli_styling): New function (most code moved
5461 from utils.c can_emit_style_escape).
5462 (string_file::string_file, string_file::can_emit_style_escape,
5463 stdio_file::can_emit_style_escape, tee_file::term_out,
5464 tee_file::can_emit_style_escape): New functions.
5465
5466 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5467
5468 * NEWS: Mention the new set|show may-call-functions.
5469 * infcall.c (may_call_functions_p): New variable.
5470 (show_may_call_functions_p): New function.
5471 (call_function_by_hand_dummy): Throws an error if not
5472 may-call-functions.
5473 (_initialize_infcall): Call add_setshow_boolean_cmd for
5474 may-call-functions.
5475
5476 2019-04-25 Keith Seitz <keiths@redhat.com>
5477
5478 PR c++/24367
5479 * cp-support.c (inspect_type): Don't attempt substitutions
5480 of symbol with the same name.
5481
5482 2019-04-25 Tom Tromey <tromey@adacore.com>
5483
5484 PR gdb/24475:
5485 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5486 static.
5487
5488 2019-04-25 Tom Tromey <tromey@adacore.com>
5489
5490 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5491 rvalue reference.
5492 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5493 (gdb_xml_parser::parse): Use std::move.
5494 * python/python-internal.h (gdbpy_convert_exception): Take a const
5495 reference.
5496 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5497 std::move.
5498 * python/py-utils.c (gdbpy_convert_exception): Take a const
5499 reference.
5500 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5501 Use std::move.
5502 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5503 Use std::move.
5504 * mi/mi-main.c (mi_print_exception): Take a const reference.
5505 * main.c (handle_command_errors): Take a const reference.
5506 * linespec.c (parse_linespec): Use std::move.
5507 * infcall.c (run_inferior_call): Use std::move.
5508 (call_function_by_hand_dummy): Use std::move.
5509 * exec.c (try_open_exec_file): Use std::move.
5510 * exceptions.h (exception_print, exception_fprintf)
5511 (exception_print_same): Update.
5512 * exceptions.c (print_exception, exception_print)
5513 (exception_fprintf, exception_print_same): Change parameters to
5514 const reference.
5515 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5516 * common/new-op.c: Use std::move.
5517 * common/common-exceptions.h (struct gdb_exception): Add move
5518 constructor.
5519 (struct gdb_exception_error, struct gdb_exception_quit, struct
5520 gdb_quit_bad_alloc): Change constructor to move constructor.
5521 (throw_exception): Change parameter to rvalue reference.
5522 * common/common-exceptions.c (throw_exception): Take rvalue
5523 reference.
5524 * cli/cli-interp.c (safe_execute_command): Use std::move.
5525 * breakpoint.c (insert_bp_location, location_to_sals): Use
5526 std::move.
5527
5528 2019-04-25 Tom Tromey <tromey@adacore.com>
5529
5530 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5531 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5532 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5533 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5534 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5535 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5536 guile/scm-value.c: Use unpack.
5537 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5538 gdbscm_gdb_exception.
5539 (gdbscm_throw_gdb_exception): Likewise.
5540 (struct gdbscm_gdb_exception): New.
5541 (unpack): New function.
5542 (gdbscm_wrap): Use unpack.
5543
5544 2019-04-25 Tom Tromey <tromey@adacore.com>
5545
5546 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5547 (gdb_rl_callback_handler): Use std::move.
5548 * common/common-exceptions.h (struct gdb_exception): Add move
5549 assignment operator.
5550 (throw_exception_sjlj): Change "exception" to const reference.
5551 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5552 (throw_exception_sjlj): Change "exception" to const reference.
5553
5554 2019-04-25 Tom Tromey <tromey@adacore.com>
5555
5556 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5557 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5558 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5559 Update.
5560 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5561 Update.
5562 * mi/mi-interp.c (mi_interp::exec): Update.
5563 * linespec.c (parse_linespec): Update.
5564 * infcall.c (run_inferior_call): Update.
5565 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5566 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5567 (gdbscm_lookup_global_symbol): Update.
5568 * guile/scm-param.c (gdbscm_parameter_value): Update.
5569 * guile/scm-frame.c (gdbscm_frame_read_register)
5570 (gdbscm_frame_read_var): Update.
5571 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5572 * exec.c (try_open_exec_file): Update.
5573 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5574 (gdb_rl_callback_handler): Update.
5575 * common/common-exceptions.h (exception_none): Don't declare.
5576 * common/common-exceptions.c (exception_none): Don't define.
5577 (struct catcher) <exception>: Update.
5578 * cli/cli-interp.c (safe_execute_command): Update.
5579 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5580
5581 2019-04-25 Ali Tamur <tamur@google.com>
5582
5583 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5584 (read_attribute_value): Likewise.
5585 (dwarf2_read_addr_index): Update comment.
5586 (read_str_index): Add DW_FORM_strx.
5587 (dwarf2_string_attr): Likewise.
5588 (dwarf2_const_value_attr): Likewise.
5589 (dump_die_shallow): Likewise.
5590 (dwarf2_fetch_constant_bytes): Likewise.
5591 (skip_form_bytes): Likewise.
5592 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5593
5594 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5595
5596 PR corefiles/11608
5597 PR corefiles/18187
5598 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5599 OFFSET. Verify if current mapping contains an ELF header.
5600 (linux_find_memory_regions_full): Adjust call to
5601 dump_mapping_p.
5602
5603 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
5604 Kang Li <kanglictf@gmail.com>
5605
5606 PR gdb/21600
5607
5608 * dwarf2-frame.c (read_initial_length): Be consistent about using
5609 unsigned representation of length.
5610 (decode_frame_entry_1): Likewise. Check for wraparound of
5611 end pointer as well as buffer overflow.
5612
5613 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
5614
5615 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5616 "vq".
5617
5618 2019-04-24 Tom Tromey <tromey@adacore.com>
5619
5620 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5621
5622 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5623
5624 * s12z-tdep.c (s12z_unwind_pc): Delete.
5625 (s12z_unwind_sp): Delete.
5626 (s12z_gdbarch_init): Don't register deleted functions with
5627 gdbarch.
5628
5629 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5630
5631 * rl78-tdep.c (rl78_unwind_sp): Delete.
5632 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5633
5634 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5635
5636 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5637 (xstormy16_unwind_pc): Delete.
5638 (xstormy16_dummy_id): Delete.
5639 (xstormy16_gdbarch_init): Don't register deleted functions with
5640 gdbarch.
5641
5642 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5643
5644 * vax-tdep.c (vax_unwind_pc): Delete.
5645 (vax_gdbarch_init): Don't register deleted function with gdbarch.
5646
5647 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5648
5649 * v850-tdep.c (v850_unwind_sp): Delete.
5650 (v850_unwind_pc): Delete.
5651 (v850_dummy_id): Delete.
5652 (v850_gdbarch_init): Don't register deleted functions with
5653 gdbarch.
5654
5655 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5656
5657 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5658 (tilegx_unwind_pc): Delete.
5659 (tilegx_unwind_dummy_id): Delete.
5660 (tilegx_gdbarch_init): Don't register deleted functions with
5661 gdbarch.
5662
5663 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5664
5665 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5666 (tic6x_dummy_id): Delete.
5667 (tic6x_gdbarch_init): Don't register deleted functions with
5668 gdbarch.
5669
5670 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5671
5672 * sparc-tdep.c (sparc_unwind_pc): Delete.
5673 (sparc32_gdbarch_init): Don't register deleted function with
5674 gdbarch.
5675
5676 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5677
5678 * sh-tdep.c (sh_unwind_sp): Delete.
5679 (sh_unwind_pc): Delete.
5680 (sh_dummy_id): Delete.
5681 (sh_gdbarch_init): Don't register deleted functions with
5682 gdbarch.
5683
5684 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5685
5686 * score-tdep.c (score_unwind_sp): Delete.
5687 (score_unwind_pc): Delete.
5688 (score_dummy_id): Delete.
5689 (score_gdbarch_init): Don't register deleted functions with
5690 gdbarch.
5691
5692 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5693
5694 * rx-tdep.c (rx_unwind_pc): Delete.
5695 (rx_unwind_sp): Delete.
5696 (rx_dummy_id): Delete.
5697 (rx_gdbarch_init): Don't register deleted functions with
5698 gdbarch. Update comment.
5699
5700 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5701
5702 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5703 (rs6000_dummy_id): Delete.
5704 (rs6000_gdbarch_init): Don't register deleted functions with
5705 gdbarch.
5706
5707 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5708
5709 * or1k-tdep.c (or1k_dummy_id): Delete.
5710 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5711
5712 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5713
5714 * nios2-tdep.c (nios2_dummy_id): Delete.
5715 (nios2_unwind_sp): Delete.
5716 (nios2_gdbarch_init): Don't register deleted functions with
5717 gdbarch.
5718
5719 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5720
5721 * nds32-tdep.c (nds32_dummy_id): Delete.
5722 (nds32_unwind_pc): Delete.
5723 (nds32_unwind_sp): Delete.
5724 (nds32_gdbarch_init): Don't register deleted functions with
5725 gdbarch.
5726
5727 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5728
5729 * msp430-tdep.c (msp430_unwind_pc): Delete.
5730 (msp430_unwind_sp): Delete.
5731 (msp430_dummy_id): Delete.
5732 (msp430_gdbarch_init): Don't register deleted functions with
5733 gdbarch.
5734
5735 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5736
5737 * moxie-tdep.c (moxie_unwind_sp): Delete.
5738 (moxie_unwind_pc): Delete.
5739 (moxie_dummy_id): Delete.
5740 (moxie_gdbarch_init): Don't register deleted functions with
5741 gdbarch.
5742
5743 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5744
5745 * mn10300-tdep.c (mn10300_dummy_id): Delete.
5746 (mn10300_unwind_pc): Delete.
5747 (mn10300_unwind_sp): Delete.
5748 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5749 mn10300_unwind_sp.
5750 (mn10300_frame_unwind_init): Don't register deleted functions with
5751 gdbarch.
5752
5753 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5754
5755 * mep-tdep.c (mep_unwind_pc): Delete.
5756 (mep_unwind_sp): Delete.
5757 (mep_dummy_id): Delete.
5758 (mep_gdbarch_init): Don't register deleted functions with
5759 gdbarch.
5760
5761 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5762
5763 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5764 (m68hc11_unwind_sp): Delete.
5765 (m68hc11_gdbarch_init): Don't register deleted functions with
5766 gdbarch.
5767
5768 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5769
5770 * m32r-tdep.c (m32r_unwind_sp): Delete.
5771 (m32r_unwind_pc): Delete.
5772 (m32r_dummy_id): Delete.
5773 (m32r_gdbarch_init): Don't register deleted functions with
5774 gdbarch.
5775
5776 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5777
5778 * m32c-tdep.c (m32c_unwind_pc): Delete.
5779 (m32c_unwind_sp): Delete.
5780 (m32c_dummy_id): Delete.
5781 (m32c_gdbarch_init): Don't register deleted functions with
5782 gdbarch.
5783
5784 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5785
5786 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5787 (lm32_unwind_pc): Delete.
5788 (lm32_dummy_id): Delete.
5789 (lm32_gdbarch_init): Don't register deleted functions with
5790 gdbarch.
5791
5792 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5793
5794 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5795 (iq2000_unwind_pc): Delete.
5796 (iq2000_dummy_id): Delete.
5797 (iq2000_gdbarch_init): Don't register deleted functions with
5798 gdbarch.
5799
5800 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5801
5802 * nds32-tdep.c (nds32_type_align): Delete.
5803 (nds32_push_dummy_call): Use type_align instead.
5804
5805 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5806
5807 * arm-tdep.c (arm_type_align): Only handle vector override case.
5808 (arm_push_dummy_call): Use type_align.
5809 (arm_gdbarch_init): Register arm_type_align gdbarch function.
5810
5811 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
5812
5813 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5814 case.
5815 (pass_on_stack): Use type_align.
5816 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5817 function.
5818
5819 2019-04-23 Tom Tromey <tromey@adacore.com>
5820
5821 * dwarf2read.c (line_header::file_name_at): Remove unused
5822 overload.
5823
5824 2019-04-23 Tom de Vries <tdevries@suse.de>
5825
5826 PR gdb/24438
5827 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5828 invocation.
5829
5830
5831 2019-03-27 Ali Tamur <tamur@google.com>
5832
5833 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5834 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5835 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5836 (dwarf_expr_context::get_addr_index): Likewise
5837 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5838 (symbol_needs_eval_context::get_addr_index): Likewise
5839 (disassemble_dwarf_expression): Add DW_OP_addrx
5840 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5841 (read_cutu_die_from_dwo): Update comment
5842 (skip_one_die): Add DW_FORM_addrx
5843 (read_attribute_value): Likewise
5844 (var_decode_location): Add DW_OP_addrx
5845 (dwarf2_const_value_attr): Add DW_FORM_addrx
5846 (dump_die_shallow): Likewise
5847 (dwarf2_fetch_constant_bytes): Likewise
5848 (decode_locdesc): Add DW_OP_addrx
5849 (skip_form_bytes): Add DW_FORM_addrx
5850
5851 2019-04-22 Ali Tamur <tamur@google.com>
5852
5853 * MAINTAINERS (Write After Approval): Add self.
5854
5855 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
5856
5857 * solib-svr4.c (get_svr4_info): Add pspace parameter.
5858 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5859 (open_symbol_file_object): Likewise.
5860 (svr4_default_sos): Add info parameter.
5861 (svr4_read_so_list): Likewise.
5862 (svr4_current_sos_direct): Adjust functions calls to pass down
5863 info.
5864 (svr4_current_sos_1): Add info parameter.
5865 (svr4_current_sos): Call get_svr4_info, pass info down to
5866 svr4_current_sos_1.
5867 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5868 get_svr4_info.
5869 (svr4_in_dynsym_resolve_code): Pass current_program_space to
5870 get_svr4_info.
5871 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5872 to get_svr4_info.
5873 (probes_table_remove_objfile_probes): Likewise.
5874 (register_solib_event_probe): Add info parameter.
5875 (solist_update_incremental): Pass info parameter down to
5876 svr4_read_so_list.
5877 (disable_probes_interface): Add info parameter.
5878 (svr4_handle_solib_event): Pass current_program_space to
5879 get_svr4_info. Adjust disable_probes_interface cleanup.
5880 (svr4_create_probe_breakpoints): Add info parameter, pass it
5881 down to register_solib_event_probe.
5882 (svr4_create_solib_event_breakpoints): Add info parameter,
5883 pass it down to svr4_create_probe_breakpoints.
5884 (enable_break): Pass info down to
5885 svr4_create_solib_event_breakpoints.
5886 (svr4_solib_create_inferior_hook): Pass current_program_space to
5887 get_svr4_info.
5888 (svr4_clear_solib): Likewise.
5889
5890 2019-04-22 Pedro Alves <palves@redhat.com>
5891
5892 * solib-svr4.c (svr4_free_objfile_observer): New.
5893 (probe_and_action::objfile): New field.
5894 (probes_table_htab_remove_objfile_probes)
5895 (probes_table_remove_objfile_probes): New functions.
5896 (register_solib_event_probe): Add 'objfile' parameter. Store it
5897 in the new probe_and_action. Don't store the probe in 'lookup'.
5898 (svr4_create_probe_breakpoints): Pass objfile to
5899 register_solib_event_probe.
5900 (_initialize_svr4_solib): Register a free_objfile observer.
5901
5902 2019-04-19 Tom Tromey <tom@tromey.com>
5903
5904 * common/queue.h: Remove.
5905
5906 2019-04-19 Tom Tromey <tom@tromey.com>
5907
5908 * event-loop.c: Don't include "common/queue.h".
5909
5910 2019-04-19 Tom Tromey <tom@tromey.com>
5911
5912 * remote.c (remote_target): Use delete.
5913 * remote-notif.h: Include <list>, not "common/queue.h".
5914 (notif_client_p): Remove typedef.
5915 (remote_notif_state): Add constructor, destructor, initializer.
5916 <notif_queue>: Now a std::list.
5917 (remote_notif_state_xfree): Don't declare.
5918 * remote-notif.c (remote_notif_process, handle_notification)
5919 (remote_notif_state_allocate): Update.
5920 (~remote_notif_state): Rename from remote_notif_state_xfree.
5921
5922 2019-04-19 Tom Tromey <tom@tromey.com>
5923
5924 * symfile.c (reread_symbols): Update.
5925 * objfiles.c (objfile_register_static_link)
5926 (objfile_lookup_static_link): Update
5927 (~objfile) Don't delete static_links.
5928 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5929
5930 2019-04-19 Tom Tromey <tom@tromey.com>
5931
5932 * type-stack.h (struct type_stack) <insert>: Constify string.
5933 * type-stack.c (type_stack::insert): Constify string.
5934 * gdbtypes.h (lookup_template_type): Update.
5935 (address_space_name_to_int): Update.
5936 * gdbtypes.c (address_space_name_to_int): Make space_identifier
5937 const.
5938 (lookup_template_type): Make name const.
5939 * c-exp.y: Update rules.
5940 (lex_one_token, classify_name, classify_inner_name)
5941 (c_print_token): Update.
5942 * p-exp.y: Update rules.
5943 (yylex): Update.
5944 * f-exp.y: Update rules.
5945 (yylex): Update.
5946 * d-exp.y: Update rules.
5947 (lex_one_token, classify_name, classify_inner_name): Update.
5948 * parse.c (write_dollar_variable, copy_name): Return std::string.
5949 * parser-defs.h (copy_name): Change return type.
5950 * m2-exp.y: Update rules.
5951 (yylex): Update.
5952 * go-exp.y (lex_one_token): Update.
5953 Update rules.
5954 (classify_unsafe_function, classify_packaged_name)
5955 (classify_name, yylex): Update.
5956
5957 2019-04-19 Sergei Trofimovich <siarheit@google.com>
5958
5959 * configure.ac: add --enable-source-highlight switch.
5960 * configure: Regenerate.
5961 * top.c (print_gdb_version): plumb --enable-source-highlight
5962 status to "show configuration".
5963
5964 2019-04-19 Tom Tromey <tromey@adacore.com>
5965
5966 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5967 Check ADA_TYPE_P.
5968 (empty_record, ada_template_to_fixed_record_type_1)
5969 (template_to_static_fixed_type)
5970 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5971 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5972 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5973 macros.
5974
5975 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
5976
5977 PR symtab/24423:
5978 * source.c (print_source_lines_base): Advance "iter" when a
5979 control character is seen.
5980
5981 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5982
5983 * inferior.h (struct infcall_suspend_state_deleter):
5984 Catch exception in destructor to avoid crash.
5985
5986 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5987
5988 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5989 close to the add_com "shell".
5990
5991 2019-04-18 Tom Tromey <tromey@adacore.com>
5992
5993 * process-stratum-target.h (class process_stratum_target)
5994 <stratum>: Add "final".
5995
5996 2019-04-17 Tom Tromey <tromey@adacore.com>
5997
5998 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5999 against nullptr before use.
6000
6001 2019-04-17 Alan Hayward <alan.hayward@arm.com>
6002
6003 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6004
6005 2019-04-17 Jim Wilson <jimw@sifive.com>
6006 Andrew Burgess <andrew.burgess@embecosm.com>
6007
6008 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6009 code read might fail, assume 4-byte breakpoint in that case.
6010
6011 2019-04-15 Leszek Swirski <leszeks@google.com>
6012
6013 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6014 rather than a hand-rolled POD check when checking for forced MEMORY
6015 classification.
6016
6017 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6018
6019 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6020 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6021 function.
6022 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6023 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6024 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6025 declaration.
6026
6027 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6028
6029 * aarch64-linux-nat.c
6030 (aarch64_linux_nat_target::thread_architecture): Add override.
6031 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6032 each VQ.
6033
6034 2019-04-15 Alan Hayward <alan.hayward@arm.com>
6035
6036 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6037
6038 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6039
6040 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6041 target types of size 96-bits, add some additional comments, and
6042 check that the builtin type we found was the correct size.
6043
6044 2019-04-12 Eli Zaretskii <eliz@gnu.org>
6045
6046 * utils.c (prompt_for_continue): Don't restore the styling at the
6047 end, as applied_style has the wrong value. This fixes styling in
6048 long lists of file names that are interrupted by the "Continue?"
6049 prompt.
6050
6051 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6052
6053 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6054 * c-lang.c (c_language_defn): Likewise.
6055 (cplus_language_defn): Likewise.
6056 (asm_language_defn): Likewise.
6057 (minimal_language_defn): Likewise.
6058 * d-lang.c (d_language_defn): Likewise.
6059 * f-lang.c (f_language_defn): Likewise.
6060 * go-lang.c (go_language_defn): Likewise.
6061 * language.c (unknown_language_defn): Likewise.
6062 (auto_language_defn): Likewise.
6063 * language.h (struct language_defn): Remove la_magic field.
6064 (LANG_MAGIC): Delete.
6065 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6066 * objc-lang.c (objc_language_defn): Likewise.
6067 * opencl-lang.c (opencl_language_defn): Likewise.
6068 * p-lang.c (pascal_language_defn): Likewise.
6069 * rust-lang.c (rust_language_defn): Likewise.
6070
6071 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6072
6073 * riscv-tdep.c (riscv_type_align): New function.
6074 (riscv_type_alignment): Delete.
6075 (riscv_arg_location): Use 'type_align'.
6076 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6077
6078 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6079
6080 * gdbtypes.c (type_align): A struct with no non-static fields also
6081 has alignment of 1.
6082
6083 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6084
6085 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6086 component to 0.
6087 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6088 member.
6089 (riscv_struct_info::analyse): New implementation using new
6090 analyse_inner member function.
6091 (riscv_struct_info::field_offset): New member function.
6092 (riscv_struct_info::m_offsets): New member variable.
6093 (riscv_struct_info::analyse_inner): New private member function,
6094 takes the old implementation of riscv_struct_info::analyse but
6095 extended to track field offsets.
6096 (riscv_call_arg_struct): Update the struct folding special cases
6097 to handle cases where empty C++ structs, which are non-zero
6098 length, are found.
6099 (riscv_arg_location): Initialise the length of each location, a
6100 non-zero length now indicates the location is in use.
6101 (riscv_push_dummy_call): Allow for the first location having a
6102 non-zero offset when setting up arguments.
6103 (riscv_return_value): Likewise, but for return values.
6104
6105 2019-04-11 Tom Tromey <tromey@adacore.com>
6106
6107 * utils.c (internal_vproblem): Make "msg" const.
6108
6109 2019-04-11 Alan Hayward <alan.hayward@arm.com>
6110
6111 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6112 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6113 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6114 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6115
6116 2019-04-10 Kevin Buettner <kevinb@redhat.com>
6117
6118 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6119 function.
6120 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6121 of amd64_collect_native_gregset.
6122 (amd64_linux_nat_target::store_registers): Likewise.
6123
6124 2019-04-10 Tom Tromey <tom@tromey.com>
6125
6126 * symtab.c (lookup_global_symbol_from_objfile)
6127 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6128 * objfiles.h (class separate_debug_iterator): New.
6129 (class separate_debug_range): New.
6130 (struct objfile) <separate_debug_objfiles>: New method.
6131 (objfile_separate_debug_iterate): Don't declare.
6132 * objfiles.c (separate_debug_iterator::operator++): Rename from
6133 objfile_separate_debug_iterate.
6134 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6135 iterator.
6136 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6137 iterator.
6138
6139 2019-04-10 Tom Tromey <tom@tromey.com>
6140
6141 * symfile.c (reread_symbols): Remove old comment.
6142 * objfiles.c (free_all_objfiles): Fix a typo.
6143
6144 2019-04-10 Tom Tromey <tom@tromey.com>
6145
6146 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6147 * minsyms.c (lookup_minimal_symbol): Use foreach.
6148 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6149 (lookup_minimal_symbol_solib_trampoline): Likewise.
6150 * symfile.c (reread_symbols): Use foreach.
6151
6152 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
6153 Tom Tromey <tromey@adacore.com>
6154
6155 PR rust/24414:
6156 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6157 (rust_lex_int_test): Change "value" to be LONGEST.
6158 (rust_lex_tests): Add test for long integer literal.
6159
6160 2019-04-09 Tom Tromey <tromey@adacore.com>
6161
6162 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6163 to bool.
6164 (extended_remote_target::attach): Update.
6165 (remote_target::remote_notice_new_inferior): Update.
6166 (remote_target::add_current_inferior_and_thread): Update.
6167 * inferior.c (exit_inferior_1): Use "false".
6168 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6169
6170 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
6171
6172 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6173 the "start" command.
6174
6175 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6176
6177 * python/py-inferior.c (infpy_thread_from_thread_handle):
6178 Adjust comments to reflect renaming of thread_from_thread_handle
6179 to thread_from_handle. Adjust keywords. Fix type error message.
6180 (inferior_object_methods): Add thread_from_handle. Retain
6181 thread_from_thread_handle, but mark it as deprecated.
6182
6183 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6184
6185 * gdbthread.h (find_thread_by_handle): Revise declaration.
6186 * thread.c (find_thread_by_handle): Likewise. Adjust
6187 implementation too.
6188 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6189 support for buffer objects as handles.
6190
6191 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6192
6193 * python/py-infthread.c (thpy_thread_handle): New function.
6194 (thread_object_methods): Register thpy_thread_handle.
6195
6196 2019-04-08 Kevin Buettner <kevinb@redhat.com>
6197
6198 * gdbthread.h (thread_to_thread_handle): Declare.
6199 * thread.c (gdbtypes.h): Include.
6200 (thread_to_thread_handle): New function.
6201
6202 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6203 (target_thread_info_to_thread_handle): Declare.
6204 * target.c (target_thread_info_to_thread_handle): New function.
6205 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6206 * target-delegates.c: Regenerate.
6207
6208 * linux-thread-db.c (class thread_db_target): Add method
6209 thread_info_to_thread_handle.
6210 (thread_db_target::thread_info_to_thread_handle): Define.
6211 * remote.c (class remote_target): Add new method
6212 thread_info_to_thread_handle.
6213 (remote_target::thread_info_to_thread_handle): Define.
6214
6215 2019-04-08 Pedro Alves <palves@redhat.com>
6216
6217 * common/common-exceptions.c (throw_exception): Don't create
6218 named object to throw; throw directly.
6219 (throw_it): Likewise. Don't initialize gdb_exception::message
6220 here, with new; pass FMT and AP to the ctor instead.
6221 * common/common-exceptions.h: Include <string>.
6222 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6223 const char *, va_list)): New ctor. Use std::make_shared.
6224 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6225 errors)): Delete.
6226 (gdb_exception_error::gdb_exception_error(enum errors, const char
6227 *, va_list)): New.
6228 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6229 Add assertion.
6230 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6231 errors)): Delete.
6232 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6233 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6234 Add assertion.
6235
6236 2019-04-08 Tom Tromey <tom@tromey.com>
6237
6238 * valops.c (value_rtti_indirect_type): Replace throw_exception
6239 with throw.
6240 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6241 with throw.
6242 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6243 throw.
6244 * target.c (target_translate_tls_address): Replace throw_exception
6245 with throw.
6246 * stack.c (frame_apply_command_count): Replace throw_exception
6247 with throw.
6248 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6249 throw.
6250 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6251 with throw.
6252 * rs6000-tdep.c (rs6000_frame_cache)
6253 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6254 * remote.c: Replace throw_exception with throw.
6255 * record-full.c (record_full_message, record_full_wait_1)
6256 (record_full_restore): Replace throw_exception with throw.
6257 * record-btrace.c:
6258 (get_thread_current_frame_id, record_btrace_start_replaying)
6259 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6260 (cmd_record_btrace_start): Replace throw_exception with throw.
6261 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6262 throw.
6263 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6264 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6265 * linespec.c:
6266 (find_linespec_symbols): Replace throw_exception with throw.
6267 * infrun.c (displaced_step_prepare, resume): Replace
6268 throw_exception with throw.
6269 * infcmd.c (post_create_inferior): Replace throw_exception with
6270 throw.
6271 * inf-loop.c (inferior_event_handler): Replace throw_exception
6272 with throw.
6273 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6274 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6275 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6276 (get_prev_frame_always, get_frame_pc_if_available)
6277 (get_frame_address_in_block_if_available, get_frame_language):
6278 Replace throw_exception with throw.
6279 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6280 throw_exception with throw.
6281 * eval.c (fetch_subexp_value, evaluate_var_value)
6282 (evaluate_funcall, evaluate_subexp_standard): Replace
6283 throw_exception with throw.
6284 * dwarf2loc.c (call_site_find_chain)
6285 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6286 Replace throw_exception with throw.
6287 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6288 with throw.
6289 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6290 throw.
6291 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6292 * completer.c (complete_line_internal): Replace throw_exception
6293 with throw.
6294 * compile/compile-object-run.c (compile_object_run): Replace
6295 throw_exception with throw.
6296 * cli/cli-script.c (process_next_line): Replace throw_exception
6297 with throw.
6298 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6299 (btrace_enable, btrace_maint_update_pt_packets): Replace
6300 throw_exception with throw.
6301 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6302 throw_exception with throw.
6303 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6304 throw_exception with throw.
6305 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6306 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6307 * aarch64-tdep.c (aarch64_make_prologue_cache)
6308 (aarch64_make_stub_cache): Replace throw_exception with throw.
6309
6310 2019-04-08 Tom Tromey <tom@tromey.com>
6311
6312 * common/common-exceptions.c (throw_exception): Rename from
6313 throw_exception_cxx. Remove old copy. Make argument const.
6314 (throw_it): Create and throw exception objects directly.
6315 * common/common-exceptions.h (throw_exception): Make argument
6316 const.
6317 (struct gdb_exception_error): Add constructor.
6318 (struct gdb_exception_quit): Add constructor.
6319
6320 2019-04-08 Tom Tromey <tom@tromey.com>
6321
6322 * common/common-exceptions.h (exception_rethrow): Don't declare.
6323 (TRY_SJLJ): Update comment.
6324 (TRY, CATCH, END_CATCH): Remove.
6325 * common/common-exceptions.c (exception_rethrow): Remove.
6326
6327 2019-04-08 Tom Tromey <tom@tromey.com>
6328
6329 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6330 Remove.
6331 (gdb_exception_error): Rename from
6332 gdb_exception_RETURN_MASK_ERROR.
6333 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6334 (gdb_quit_bad_alloc): Update.
6335 * aarch64-tdep.c: Update.
6336 * ada-lang.c: Update.
6337 * ada-typeprint.c: Update.
6338 * ada-valprint.c: Update.
6339 * amd64-tdep.c: Update.
6340 * arch-utils.c: Update.
6341 * break-catch-throw.c: Update.
6342 * breakpoint.c: Update.
6343 * btrace.c: Update.
6344 * c-varobj.c: Update.
6345 * cli/cli-cmds.c: Update.
6346 * cli/cli-interp.c: Update.
6347 * cli/cli-script.c: Update.
6348 * common/common-exceptions.c: Update.
6349 * common/new-op.c: Update.
6350 * common/selftest.c: Update.
6351 * compile/compile-c-symbols.c: Update.
6352 * compile/compile-cplus-symbols.c: Update.
6353 * compile/compile-object-load.c: Update.
6354 * compile/compile-object-run.c: Update.
6355 * completer.c: Update.
6356 * corelow.c: Update.
6357 * cp-abi.c: Update.
6358 * cp-support.c: Update.
6359 * cp-valprint.c: Update.
6360 * darwin-nat.c: Update.
6361 * disasm-selftests.c: Update.
6362 * dtrace-probe.c: Update.
6363 * dwarf-index-cache.c: Update.
6364 * dwarf-index-write.c: Update.
6365 * dwarf2-frame-tailcall.c: Update.
6366 * dwarf2-frame.c: Update.
6367 * dwarf2loc.c: Update.
6368 * dwarf2read.c: Update.
6369 * eval.c: Update.
6370 * event-loop.c: Update.
6371 * event-top.c: Update.
6372 * exec.c: Update.
6373 * f-valprint.c: Update.
6374 * fbsd-tdep.c: Update.
6375 * frame-unwind.c: Update.
6376 * frame.c: Update.
6377 * gdbtypes.c: Update.
6378 * gnu-v3-abi.c: Update.
6379 * guile/guile-internal.h: Update.
6380 * guile/scm-block.c: Update.
6381 * guile/scm-breakpoint.c: Update.
6382 * guile/scm-cmd.c: Update.
6383 * guile/scm-disasm.c: Update.
6384 * guile/scm-frame.c: Update.
6385 * guile/scm-lazy-string.c: Update.
6386 * guile/scm-math.c: Update.
6387 * guile/scm-param.c: Update.
6388 * guile/scm-ports.c: Update.
6389 * guile/scm-pretty-print.c: Update.
6390 * guile/scm-symbol.c: Update.
6391 * guile/scm-symtab.c: Update.
6392 * guile/scm-type.c: Update.
6393 * guile/scm-value.c: Update.
6394 * i386-linux-tdep.c: Update.
6395 * i386-tdep.c: Update.
6396 * inf-loop.c: Update.
6397 * infcall.c: Update.
6398 * infcmd.c: Update.
6399 * infrun.c: Update.
6400 * jit.c: Update.
6401 * language.c: Update.
6402 * linespec.c: Update.
6403 * linux-fork.c: Update.
6404 * linux-nat.c: Update.
6405 * linux-tdep.c: Update.
6406 * linux-thread-db.c: Update.
6407 * main.c: Update.
6408 * mi/mi-cmd-break.c: Update.
6409 * mi/mi-cmd-stack.c: Update.
6410 * mi/mi-interp.c: Update.
6411 * mi/mi-main.c: Update.
6412 * objc-lang.c: Update.
6413 * p-valprint.c: Update.
6414 * parse.c: Update.
6415 * ppc-linux-tdep.c: Update.
6416 * printcmd.c: Update.
6417 * python/py-arch.c: Update.
6418 * python/py-breakpoint.c: Update.
6419 * python/py-cmd.c: Update.
6420 * python/py-finishbreakpoint.c: Update.
6421 * python/py-frame.c: Update.
6422 * python/py-framefilter.c: Update.
6423 * python/py-gdb-readline.c: Update.
6424 * python/py-inferior.c: Update.
6425 * python/py-infthread.c: Update.
6426 * python/py-lazy-string.c: Update.
6427 * python/py-linetable.c: Update.
6428 * python/py-objfile.c: Update.
6429 * python/py-param.c: Update.
6430 * python/py-prettyprint.c: Update.
6431 * python/py-progspace.c: Update.
6432 * python/py-record-btrace.c: Update.
6433 * python/py-record.c: Update.
6434 * python/py-symbol.c: Update.
6435 * python/py-type.c: Update.
6436 * python/py-unwind.c: Update.
6437 * python/py-utils.c: Update.
6438 * python/py-value.c: Update.
6439 * python/python.c: Update.
6440 * record-btrace.c: Update.
6441 * record-full.c: Update.
6442 * remote-fileio.c: Update.
6443 * remote.c: Update.
6444 * riscv-tdep.c: Update.
6445 * rs6000-aix-tdep.c: Update.
6446 * rs6000-tdep.c: Update.
6447 * rust-exp.y: Update.
6448 * rust-lang.c: Update.
6449 * s390-tdep.c: Update.
6450 * selftest-arch.c: Update.
6451 * solib-dsbt.c: Update.
6452 * solib-frv.c: Update.
6453 * solib-spu.c: Update.
6454 * solib-svr4.c: Update.
6455 * solib.c: Update.
6456 * sparc64-linux-tdep.c: Update.
6457 * stack.c: Update.
6458 * symfile-mem.c: Update.
6459 * symmisc.c: Update.
6460 * target.c: Update.
6461 * thread.c: Update.
6462 * top.c: Update.
6463 * tracefile-tfile.c: Update.
6464 * tui/tui.c: Update.
6465 * typeprint.c: Update.
6466 * unittests/cli-utils-selftests.c: Update.
6467 * unittests/parse-connection-spec-selftests.c: Update.
6468 * valops.c: Update.
6469 * valprint.c: Update.
6470 * value.c: Update.
6471 * varobj.c: Update.
6472 * windows-nat.c: Update.
6473 * x86-linux-nat.c: Update.
6474 * xml-support.c: Update.
6475
6476 2019-04-08 Tom Tromey <tom@tromey.com>
6477
6478 * xml-support.c: Use C++ exception handling.
6479 * x86-linux-nat.c: Use C++ exception handling.
6480 * windows-nat.c: Use C++ exception handling.
6481 * varobj.c: Use C++ exception handling.
6482 * value.c: Use C++ exception handling.
6483 * valprint.c: Use C++ exception handling.
6484 * valops.c: Use C++ exception handling.
6485 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6486 handling.
6487 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6488 * typeprint.c: Use C++ exception handling.
6489 * tui/tui.c: Use C++ exception handling.
6490 * tracefile-tfile.c: Use C++ exception handling.
6491 * top.c: Use C++ exception handling.
6492 * thread.c: Use C++ exception handling.
6493 * target.c: Use C++ exception handling.
6494 * symmisc.c: Use C++ exception handling.
6495 * symfile-mem.c: Use C++ exception handling.
6496 * stack.c: Use C++ exception handling.
6497 * sparc64-linux-tdep.c: Use C++ exception handling.
6498 * solib.c: Use C++ exception handling.
6499 * solib-svr4.c: Use C++ exception handling.
6500 * solib-spu.c: Use C++ exception handling.
6501 * solib-frv.c: Use C++ exception handling.
6502 * solib-dsbt.c: Use C++ exception handling.
6503 * selftest-arch.c: Use C++ exception handling.
6504 * s390-tdep.c: Use C++ exception handling.
6505 * rust-lang.c: Use C++ exception handling.
6506 * rust-exp.y: Use C++ exception handling.
6507 * rs6000-tdep.c: Use C++ exception handling.
6508 * rs6000-aix-tdep.c: Use C++ exception handling.
6509 * riscv-tdep.c: Use C++ exception handling.
6510 * remote.c: Use C++ exception handling.
6511 * remote-fileio.c: Use C++ exception handling.
6512 * record-full.c: Use C++ exception handling.
6513 * record-btrace.c: Use C++ exception handling.
6514 * python/python.c: Use C++ exception handling.
6515 * python/py-value.c: Use C++ exception handling.
6516 * python/py-utils.c: Use C++ exception handling.
6517 * python/py-unwind.c: Use C++ exception handling.
6518 * python/py-type.c: Use C++ exception handling.
6519 * python/py-symbol.c: Use C++ exception handling.
6520 * python/py-record.c: Use C++ exception handling.
6521 * python/py-record-btrace.c: Use C++ exception handling.
6522 * python/py-progspace.c: Use C++ exception handling.
6523 * python/py-prettyprint.c: Use C++ exception handling.
6524 * python/py-param.c: Use C++ exception handling.
6525 * python/py-objfile.c: Use C++ exception handling.
6526 * python/py-linetable.c: Use C++ exception handling.
6527 * python/py-lazy-string.c: Use C++ exception handling.
6528 * python/py-infthread.c: Use C++ exception handling.
6529 * python/py-inferior.c: Use C++ exception handling.
6530 * python/py-gdb-readline.c: Use C++ exception handling.
6531 * python/py-framefilter.c: Use C++ exception handling.
6532 * python/py-frame.c: Use C++ exception handling.
6533 * python/py-finishbreakpoint.c: Use C++ exception handling.
6534 * python/py-cmd.c: Use C++ exception handling.
6535 * python/py-breakpoint.c: Use C++ exception handling.
6536 * python/py-arch.c: Use C++ exception handling.
6537 * printcmd.c: Use C++ exception handling.
6538 * ppc-linux-tdep.c: Use C++ exception handling.
6539 * parse.c: Use C++ exception handling.
6540 * p-valprint.c: Use C++ exception handling.
6541 * objc-lang.c: Use C++ exception handling.
6542 * mi/mi-main.c: Use C++ exception handling.
6543 * mi/mi-interp.c: Use C++ exception handling.
6544 * mi/mi-cmd-stack.c: Use C++ exception handling.
6545 * mi/mi-cmd-break.c: Use C++ exception handling.
6546 * main.c: Use C++ exception handling.
6547 * linux-thread-db.c: Use C++ exception handling.
6548 * linux-tdep.c: Use C++ exception handling.
6549 * linux-nat.c: Use C++ exception handling.
6550 * linux-fork.c: Use C++ exception handling.
6551 * linespec.c: Use C++ exception handling.
6552 * language.c: Use C++ exception handling.
6553 * jit.c: Use C++ exception handling.
6554 * infrun.c: Use C++ exception handling.
6555 * infcmd.c: Use C++ exception handling.
6556 * infcall.c: Use C++ exception handling.
6557 * inf-loop.c: Use C++ exception handling.
6558 * i386-tdep.c: Use C++ exception handling.
6559 * i386-linux-tdep.c: Use C++ exception handling.
6560 * guile/scm-value.c: Use C++ exception handling.
6561 * guile/scm-type.c: Use C++ exception handling.
6562 * guile/scm-symtab.c: Use C++ exception handling.
6563 * guile/scm-symbol.c: Use C++ exception handling.
6564 * guile/scm-pretty-print.c: Use C++ exception handling.
6565 * guile/scm-ports.c: Use C++ exception handling.
6566 * guile/scm-param.c: Use C++ exception handling.
6567 * guile/scm-math.c: Use C++ exception handling.
6568 * guile/scm-lazy-string.c: Use C++ exception handling.
6569 * guile/scm-frame.c: Use C++ exception handling.
6570 * guile/scm-disasm.c: Use C++ exception handling.
6571 * guile/scm-cmd.c: Use C++ exception handling.
6572 * guile/scm-breakpoint.c: Use C++ exception handling.
6573 * guile/scm-block.c: Use C++ exception handling.
6574 * guile/guile-internal.h: Use C++ exception handling.
6575 * gnu-v3-abi.c: Use C++ exception handling.
6576 * gdbtypes.c: Use C++ exception handling.
6577 * frame.c: Use C++ exception handling.
6578 * frame-unwind.c: Use C++ exception handling.
6579 * fbsd-tdep.c: Use C++ exception handling.
6580 * f-valprint.c: Use C++ exception handling.
6581 * exec.c: Use C++ exception handling.
6582 * event-top.c: Use C++ exception handling.
6583 * event-loop.c: Use C++ exception handling.
6584 * eval.c: Use C++ exception handling.
6585 * dwarf2read.c: Use C++ exception handling.
6586 * dwarf2loc.c: Use C++ exception handling.
6587 * dwarf2-frame.c: Use C++ exception handling.
6588 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6589 * dwarf-index-write.c: Use C++ exception handling.
6590 * dwarf-index-cache.c: Use C++ exception handling.
6591 * dtrace-probe.c: Use C++ exception handling.
6592 * disasm-selftests.c: Use C++ exception handling.
6593 * darwin-nat.c: Use C++ exception handling.
6594 * cp-valprint.c: Use C++ exception handling.
6595 * cp-support.c: Use C++ exception handling.
6596 * cp-abi.c: Use C++ exception handling.
6597 * corelow.c: Use C++ exception handling.
6598 * completer.c: Use C++ exception handling.
6599 * compile/compile-object-run.c: Use C++ exception handling.
6600 * compile/compile-object-load.c: Use C++ exception handling.
6601 * compile/compile-cplus-symbols.c: Use C++ exception handling.
6602 * compile/compile-c-symbols.c: Use C++ exception handling.
6603 * common/selftest.c: Use C++ exception handling.
6604 * common/new-op.c: Use C++ exception handling.
6605 * cli/cli-script.c: Use C++ exception handling.
6606 * cli/cli-interp.c: Use C++ exception handling.
6607 * cli/cli-cmds.c: Use C++ exception handling.
6608 * c-varobj.c: Use C++ exception handling.
6609 * btrace.c: Use C++ exception handling.
6610 * breakpoint.c: Use C++ exception handling.
6611 * break-catch-throw.c: Use C++ exception handling.
6612 * arch-utils.c: Use C++ exception handling.
6613 * amd64-tdep.c: Use C++ exception handling.
6614 * ada-valprint.c: Use C++ exception handling.
6615 * ada-typeprint.c: Use C++ exception handling.
6616 * ada-lang.c: Use C++ exception handling.
6617 * aarch64-tdep.c: Use C++ exception handling.
6618
6619 2019-04-08 Tom Tromey <tom@tromey.com>
6620
6621 * xml-support.c (gdb_xml_parser::parse): Update.
6622 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6623 * value.c (show_convenience): Update.
6624 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6625 (test_parse_flags_qcs): Update.
6626 * thread.c (thr_try_catch_cmd): Update.
6627 * target.c (target_translate_tls_address): Update.
6628 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6629 (info_frame_command_core, frame_apply_command_count): Update.
6630 * rust-exp.y (rust_lex_exception_test): Update.
6631 * riscv-tdep.c (riscv_print_one_register_info): Update.
6632 * remote.c (remote_target::enable_btrace): Update.
6633 * record-btrace.c (record_btrace_enable_warn): Update.
6634 * python/py-utils.c (gdbpy_convert_exception): Update.
6635 * printcmd.c (do_one_display, print_variable_and_value): Update.
6636 * mi/mi-main.c (mi_print_exception): Update.
6637 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6638 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6639 * linux-nat.c (linux_nat_target::attach): Update.
6640 * linux-fork.c (class scoped_switch_fork_info): Update.
6641 * infrun.c (displaced_step_prepare): Update.
6642 * infcall.c (call_function_by_hand_dummy): Update.
6643 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6644 * gnu-v3-abi.c (print_one_vtable): Update.
6645 * frame.c (get_prev_frame_always): Update.
6646 * f-valprint.c (info_common_command_for_block): Update.
6647 * exec.c (try_open_exec_file): Update.
6648 * exceptions.c (print_exception, exception_print)
6649 (exception_fprintf, exception_print_same): Update.
6650 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6651 * dwarf-index-cache.c (index_cache::store)
6652 (index_cache::lookup_gdb_index): Update.
6653 * darwin-nat.c (maybe_cache_shell): Update.
6654 * cp-valprint.c (cp_print_value_fields): Update.
6655 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6656 (gcc_cplus_symbol_address): Update.
6657 * compile/compile-c-symbols.c (gcc_convert_symbol)
6658 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6659 * common/selftest.c: Update.
6660 * common/common-exceptions.h (struct gdb_exception) <message>: Now
6661 a std::string.
6662 (exception_try_scope_entry, exception_try_scope_exit): Don't
6663 declare.
6664 (struct exception_try_scope): Remove.
6665 (TRY): Don't use exception_try_scope.
6666 (struct gdb_exception): Add constructor, operator=.
6667 <what>: New method.
6668 (struct gdb_exception_RETURN_MASK_ALL)
6669 (struct gdb_exception_RETURN_MASK_ERROR)
6670 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6671 (struct gdb_quit_bad_alloc): Update.
6672 * common/common-exceptions.c (exception_none): Change
6673 initializer.
6674 (struct catcher) <state, exception>: Initialize inline.
6675 <prev>: Remove member.
6676 (current_catcher): Remove.
6677 (catchers): New global.
6678 (exceptions_state_mc_init): Simplify.
6679 (catcher_pop): Remove.
6680 (exceptions_state_mc, exceptions_state_mc_catch): Update.
6681 (try_scope_depth, exception_try_scope_entry)
6682 (exception_try_scope_exit): Remove.
6683 (throw_exception_sjlj): Update.
6684 (exception_messages, exception_messages_size): Remove.
6685 (throw_it): Simplify.
6686 (gdb_exception_sliced_copy): Remove.
6687 (throw_exception_cxx): Update.
6688 * cli/cli-script.c (script_from_file): Update.
6689 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6690 Update.
6691 * ada-valprint.c (ada_val_print): Update.
6692 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6693 (create_excep_cond_exprs): Update.
6694
6695 2019-04-08 Tom Tromey <tom@tromey.com>
6696
6697 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6698 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6699 (TRY, CATCH, END_CATCH): Remove some definitions.
6700 * common/common-exceptions.c: Don't use GDB_XCPT.
6701 (catcher_list_size): Remove.
6702 (throw_exception, throw_it): Simplify.
6703
6704 2019-04-05 Tom Tromey <tom@tromey.com>
6705
6706 Revert the header-sorting patch.
6707 * ft32-tdep.c: Revert.
6708 * frv-tdep.c: Revert.
6709 * frv-linux-tdep.c: Revert.
6710 * frame.c: Revert.
6711 * frame-unwind.c: Revert.
6712 * frame-base.c: Revert.
6713 * fork-child.c: Revert.
6714 * findvar.c: Revert.
6715 * findcmd.c: Revert.
6716 * filesystem.c: Revert.
6717 * filename-seen-cache.h: Revert.
6718 * filename-seen-cache.c: Revert.
6719 * fbsd-tdep.c: Revert.
6720 * fbsd-nat.h: Revert.
6721 * fbsd-nat.c: Revert.
6722 * f-valprint.c: Revert.
6723 * f-typeprint.c: Revert.
6724 * f-lang.c: Revert.
6725 * extension.h: Revert.
6726 * extension.c: Revert.
6727 * extension-priv.h: Revert.
6728 * expprint.c: Revert.
6729 * exec.h: Revert.
6730 * exec.c: Revert.
6731 * exceptions.c: Revert.
6732 * event-top.c: Revert.
6733 * event-loop.c: Revert.
6734 * eval.c: Revert.
6735 * elfread.c: Revert.
6736 * dwarf2read.h: Revert.
6737 * dwarf2read.c: Revert.
6738 * dwarf2loc.c: Revert.
6739 * dwarf2expr.h: Revert.
6740 * dwarf2expr.c: Revert.
6741 * dwarf2-frame.c: Revert.
6742 * dwarf2-frame-tailcall.c: Revert.
6743 * dwarf-index-write.h: Revert.
6744 * dwarf-index-write.c: Revert.
6745 * dwarf-index-common.c: Revert.
6746 * dwarf-index-cache.h: Revert.
6747 * dwarf-index-cache.c: Revert.
6748 * dummy-frame.c: Revert.
6749 * dtrace-probe.c: Revert.
6750 * disasm.h: Revert.
6751 * disasm.c: Revert.
6752 * disasm-selftests.c: Revert.
6753 * dictionary.c: Revert.
6754 * dicos-tdep.c: Revert.
6755 * demangle.c: Revert.
6756 * dcache.h: Revert.
6757 * dcache.c: Revert.
6758 * darwin-nat.h: Revert.
6759 * darwin-nat.c: Revert.
6760 * darwin-nat-info.c: Revert.
6761 * d-valprint.c: Revert.
6762 * d-namespace.c: Revert.
6763 * d-lang.c: Revert.
6764 * ctf.c: Revert.
6765 * csky-tdep.c: Revert.
6766 * csky-linux-tdep.c: Revert.
6767 * cris-tdep.c: Revert.
6768 * cris-linux-tdep.c: Revert.
6769 * cp-valprint.c: Revert.
6770 * cp-support.c: Revert.
6771 * cp-namespace.c: Revert.
6772 * cp-abi.c: Revert.
6773 * corelow.c: Revert.
6774 * corefile.c: Revert.
6775 * continuations.c: Revert.
6776 * completer.h: Revert.
6777 * completer.c: Revert.
6778 * complaints.c: Revert.
6779 * coffread.c: Revert.
6780 * coff-pe-read.c: Revert.
6781 * cli-out.h: Revert.
6782 * cli-out.c: Revert.
6783 * charset.c: Revert.
6784 * c-varobj.c: Revert.
6785 * c-valprint.c: Revert.
6786 * c-typeprint.c: Revert.
6787 * c-lang.c: Revert.
6788 * buildsym.c: Revert.
6789 * buildsym-legacy.c: Revert.
6790 * build-id.h: Revert.
6791 * build-id.c: Revert.
6792 * btrace.c: Revert.
6793 * bsd-uthread.c: Revert.
6794 * breakpoint.h: Revert.
6795 * breakpoint.c: Revert.
6796 * break-catch-throw.c: Revert.
6797 * break-catch-syscall.c: Revert.
6798 * break-catch-sig.c: Revert.
6799 * blockframe.c: Revert.
6800 * block.c: Revert.
6801 * bfin-tdep.c: Revert.
6802 * bfin-linux-tdep.c: Revert.
6803 * bfd-target.c: Revert.
6804 * bcache.c: Revert.
6805 * ax-general.c: Revert.
6806 * ax-gdb.h: Revert.
6807 * ax-gdb.c: Revert.
6808 * avr-tdep.c: Revert.
6809 * auxv.c: Revert.
6810 * auto-load.c: Revert.
6811 * arm-wince-tdep.c: Revert.
6812 * arm-tdep.c: Revert.
6813 * arm-symbian-tdep.c: Revert.
6814 * arm-pikeos-tdep.c: Revert.
6815 * arm-obsd-tdep.c: Revert.
6816 * arm-nbsd-tdep.c: Revert.
6817 * arm-nbsd-nat.c: Revert.
6818 * arm-linux-tdep.c: Revert.
6819 * arm-linux-nat.c: Revert.
6820 * arm-fbsd-tdep.c: Revert.
6821 * arm-fbsd-nat.c: Revert.
6822 * arm-bsd-tdep.c: Revert.
6823 * arch-utils.c: Revert.
6824 * arc-tdep.c: Revert.
6825 * arc-newlib-tdep.c: Revert.
6826 * annotate.h: Revert.
6827 * annotate.c: Revert.
6828 * amd64-windows-tdep.c: Revert.
6829 * amd64-windows-nat.c: Revert.
6830 * amd64-tdep.c: Revert.
6831 * amd64-sol2-tdep.c: Revert.
6832 * amd64-obsd-tdep.c: Revert.
6833 * amd64-obsd-nat.c: Revert.
6834 * amd64-nbsd-tdep.c: Revert.
6835 * amd64-nbsd-nat.c: Revert.
6836 * amd64-nat.c: Revert.
6837 * amd64-linux-tdep.c: Revert.
6838 * amd64-linux-nat.c: Revert.
6839 * amd64-fbsd-tdep.c: Revert.
6840 * amd64-fbsd-nat.c: Revert.
6841 * amd64-dicos-tdep.c: Revert.
6842 * amd64-darwin-tdep.c: Revert.
6843 * amd64-bsd-nat.c: Revert.
6844 * alpha-tdep.c: Revert.
6845 * alpha-obsd-tdep.c: Revert.
6846 * alpha-nbsd-tdep.c: Revert.
6847 * alpha-mdebug-tdep.c: Revert.
6848 * alpha-linux-tdep.c: Revert.
6849 * alpha-linux-nat.c: Revert.
6850 * alpha-bsd-tdep.c: Revert.
6851 * alpha-bsd-nat.c: Revert.
6852 * aix-thread.c: Revert.
6853 * agent.c: Revert.
6854 * addrmap.c: Revert.
6855 * ada-varobj.c: Revert.
6856 * ada-valprint.c: Revert.
6857 * ada-typeprint.c: Revert.
6858 * ada-tasks.c: Revert.
6859 * ada-lang.c: Revert.
6860 * aarch64-tdep.c: Revert.
6861 * aarch64-ravenscar-thread.c: Revert.
6862 * aarch64-newlib-tdep.c: Revert.
6863 * aarch64-linux-tdep.c: Revert.
6864 * aarch64-linux-nat.c: Revert.
6865 * aarch64-fbsd-tdep.c: Revert.
6866 * aarch64-fbsd-nat.c: Revert.
6867 * aarch32-linux-nat.c: Revert.
6868
6869 2019-04-05 Tom Tromey <tom@tromey.com>
6870
6871 * ft32-tdep.c: Sort headers.
6872 * frv-tdep.c: Sort headers.
6873 * frv-linux-tdep.c: Sort headers.
6874 * frame.c: Sort headers.
6875 * frame-unwind.c: Sort headers.
6876 * frame-base.c: Sort headers.
6877 * fork-child.c: Sort headers.
6878 * findvar.c: Sort headers.
6879 * findcmd.c: Sort headers.
6880 * filesystem.c: Sort headers.
6881 * filename-seen-cache.h: Sort headers.
6882 * filename-seen-cache.c: Sort headers.
6883 * fbsd-tdep.c: Sort headers.
6884 * fbsd-nat.h: Sort headers.
6885 * fbsd-nat.c: Sort headers.
6886 * f-valprint.c: Sort headers.
6887 * f-typeprint.c: Sort headers.
6888 * f-lang.c: Sort headers.
6889 * extension.h: Sort headers.
6890 * extension.c: Sort headers.
6891 * extension-priv.h: Sort headers.
6892 * expprint.c: Sort headers.
6893 * exec.h: Sort headers.
6894 * exec.c: Sort headers.
6895 * exceptions.c: Sort headers.
6896 * event-top.c: Sort headers.
6897 * event-loop.c: Sort headers.
6898 * eval.c: Sort headers.
6899 * elfread.c: Sort headers.
6900 * dwarf2read.h: Sort headers.
6901 * dwarf2read.c: Sort headers.
6902 * dwarf2loc.c: Sort headers.
6903 * dwarf2expr.h: Sort headers.
6904 * dwarf2expr.c: Sort headers.
6905 * dwarf2-frame.c: Sort headers.
6906 * dwarf2-frame-tailcall.c: Sort headers.
6907 * dwarf-index-write.h: Sort headers.
6908 * dwarf-index-write.c: Sort headers.
6909 * dwarf-index-common.c: Sort headers.
6910 * dwarf-index-cache.h: Sort headers.
6911 * dwarf-index-cache.c: Sort headers.
6912 * dummy-frame.c: Sort headers.
6913 * dtrace-probe.c: Sort headers.
6914 * disasm.h: Sort headers.
6915 * disasm.c: Sort headers.
6916 * disasm-selftests.c: Sort headers.
6917 * dictionary.c: Sort headers.
6918 * dicos-tdep.c: Sort headers.
6919 * demangle.c: Sort headers.
6920 * dcache.h: Sort headers.
6921 * dcache.c: Sort headers.
6922 * darwin-nat.h: Sort headers.
6923 * darwin-nat.c: Sort headers.
6924 * darwin-nat-info.c: Sort headers.
6925 * d-valprint.c: Sort headers.
6926 * d-namespace.c: Sort headers.
6927 * d-lang.c: Sort headers.
6928 * ctf.c: Sort headers.
6929 * csky-tdep.c: Sort headers.
6930 * csky-linux-tdep.c: Sort headers.
6931 * cris-tdep.c: Sort headers.
6932 * cris-linux-tdep.c: Sort headers.
6933 * cp-valprint.c: Sort headers.
6934 * cp-support.c: Sort headers.
6935 * cp-namespace.c: Sort headers.
6936 * cp-abi.c: Sort headers.
6937 * corelow.c: Sort headers.
6938 * corefile.c: Sort headers.
6939 * continuations.c: Sort headers.
6940 * completer.h: Sort headers.
6941 * completer.c: Sort headers.
6942 * complaints.c: Sort headers.
6943 * coffread.c: Sort headers.
6944 * coff-pe-read.c: Sort headers.
6945 * cli-out.h: Sort headers.
6946 * cli-out.c: Sort headers.
6947 * charset.c: Sort headers.
6948 * c-varobj.c: Sort headers.
6949 * c-valprint.c: Sort headers.
6950 * c-typeprint.c: Sort headers.
6951 * c-lang.c: Sort headers.
6952 * buildsym.c: Sort headers.
6953 * buildsym-legacy.c: Sort headers.
6954 * build-id.h: Sort headers.
6955 * build-id.c: Sort headers.
6956 * btrace.c: Sort headers.
6957 * bsd-uthread.c: Sort headers.
6958 * breakpoint.h: Sort headers.
6959 * breakpoint.c: Sort headers.
6960 * break-catch-throw.c: Sort headers.
6961 * break-catch-syscall.c: Sort headers.
6962 * break-catch-sig.c: Sort headers.
6963 * blockframe.c: Sort headers.
6964 * block.c: Sort headers.
6965 * bfin-tdep.c: Sort headers.
6966 * bfin-linux-tdep.c: Sort headers.
6967 * bfd-target.c: Sort headers.
6968 * bcache.c: Sort headers.
6969 * ax-general.c: Sort headers.
6970 * ax-gdb.h: Sort headers.
6971 * ax-gdb.c: Sort headers.
6972 * avr-tdep.c: Sort headers.
6973 * auxv.c: Sort headers.
6974 * auto-load.c: Sort headers.
6975 * arm-wince-tdep.c: Sort headers.
6976 * arm-tdep.c: Sort headers.
6977 * arm-symbian-tdep.c: Sort headers.
6978 * arm-pikeos-tdep.c: Sort headers.
6979 * arm-obsd-tdep.c: Sort headers.
6980 * arm-nbsd-tdep.c: Sort headers.
6981 * arm-nbsd-nat.c: Sort headers.
6982 * arm-linux-tdep.c: Sort headers.
6983 * arm-linux-nat.c: Sort headers.
6984 * arm-fbsd-tdep.c: Sort headers.
6985 * arm-fbsd-nat.c: Sort headers.
6986 * arm-bsd-tdep.c: Sort headers.
6987 * arch-utils.c: Sort headers.
6988 * arc-tdep.c: Sort headers.
6989 * arc-newlib-tdep.c: Sort headers.
6990 * annotate.h: Sort headers.
6991 * annotate.c: Sort headers.
6992 * amd64-windows-tdep.c: Sort headers.
6993 * amd64-windows-nat.c: Sort headers.
6994 * amd64-tdep.c: Sort headers.
6995 * amd64-sol2-tdep.c: Sort headers.
6996 * amd64-obsd-tdep.c: Sort headers.
6997 * amd64-obsd-nat.c: Sort headers.
6998 * amd64-nbsd-tdep.c: Sort headers.
6999 * amd64-nbsd-nat.c: Sort headers.
7000 * amd64-nat.c: Sort headers.
7001 * amd64-linux-tdep.c: Sort headers.
7002 * amd64-linux-nat.c: Sort headers.
7003 * amd64-fbsd-tdep.c: Sort headers.
7004 * amd64-fbsd-nat.c: Sort headers.
7005 * amd64-dicos-tdep.c: Sort headers.
7006 * amd64-darwin-tdep.c: Sort headers.
7007 * amd64-bsd-nat.c: Sort headers.
7008 * alpha-tdep.c: Sort headers.
7009 * alpha-obsd-tdep.c: Sort headers.
7010 * alpha-nbsd-tdep.c: Sort headers.
7011 * alpha-mdebug-tdep.c: Sort headers.
7012 * alpha-linux-tdep.c: Sort headers.
7013 * alpha-linux-nat.c: Sort headers.
7014 * alpha-bsd-tdep.c: Sort headers.
7015 * alpha-bsd-nat.c: Sort headers.
7016 * aix-thread.c: Sort headers.
7017 * agent.c: Sort headers.
7018 * addrmap.c: Sort headers.
7019 * ada-varobj.c: Sort headers.
7020 * ada-valprint.c: Sort headers.
7021 * ada-typeprint.c: Sort headers.
7022 * ada-tasks.c: Sort headers.
7023 * ada-lang.c: Sort headers.
7024 * aarch64-tdep.c: Sort headers.
7025 * aarch64-ravenscar-thread.c: Sort headers.
7026 * aarch64-newlib-tdep.c: Sort headers.
7027 * aarch64-linux-tdep.c: Sort headers.
7028 * aarch64-linux-nat.c: Sort headers.
7029 * aarch64-fbsd-tdep.c: Sort headers.
7030 * aarch64-fbsd-nat.c: Sort headers.
7031 * aarch32-linux-nat.c: Sort headers.
7032
7033 2019-04-04 Tom Tromey <tom@tromey.com>
7034
7035 * varobj.c (varobj_create): Update.
7036 * rust-exp.y (struct rust_parser) <update_innermost_block,
7037 lookup_symbol>: New methods.
7038 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7039 Rename.
7040 (rust_parser::rust_lookup_type)
7041 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7042 * printcmd.c (display_command, do_one_display): Update.
7043 * parser-defs.h (struct parser_state) <parser_state>: Add
7044 "tracker" parameter.
7045 (block_tracker): New member.
7046 (class innermost_block_tracker) <innermost_block_tracker>: Add
7047 "types" parameter.
7048 <reset>: Remove method.
7049 (innermost_block): Don't declare.
7050 (null_post_parser): Update.
7051 * parse.c (innermost_block): Remove global.
7052 (write_dollar_variable): Update.
7053 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7054 Remove "tracker_types" parameter.
7055 (parse_expression): Add "tracker" parameter.
7056 (parse_expression_for_completion): Update.
7057 (null_post_parser): Add "tracker" parameter.
7058 * p-exp.y: Update rules.
7059 * m2-exp.y: Update rules.
7060 * language.h (struct language_defn) <la_post_parser>: Add
7061 "tracker" parameter.
7062 * go-exp.y: Update rules.
7063 * f-exp.y: Update rules.
7064 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7065 parameter.
7066 * d-exp.y: Update rules.
7067 * c-exp.y: Update rules.
7068 * breakpoint.c (set_breakpoint_condition): Create an
7069 innermost_block_tracker.
7070 (watch_command_1): Likewise.
7071 * ada-lang.c (resolve): Add "tracker" parameter.
7072 (resolve_subexp): Likewise.
7073 * ada-exp.y (write_var_from_sym): Update.
7074
7075 2019-04-04 Tom Tromey <tom@tromey.com>
7076
7077 * type-stack.h: New file.
7078 * type-stack.c: New file.
7079 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7080 type-stack.h.
7081 (insert_into_type_stack, insert_type, push_type, push_type_int)
7082 (insert_type_address_space, pop_type, pop_type_int)
7083 (pop_typelist, pop_type_stack, append_type_stack)
7084 (push_type_stack, get_type_stack, push_typelist)
7085 (follow_type_instance_flags, follow_types): Don't declare.
7086 * parse.c (type_stack): Remove global.
7087 (parse_exp_in_context): Update.
7088 (insert_into_type_stack, insert_type, push_type, push_type_int)
7089 (insert_type_address_space, pop_type, pop_type_int)
7090 (pop_typelist, pop_type_stack, append_type_stack)
7091 (push_type_stack, get_type_stack, push_typelist)
7092 (follow_type_instance_flags, follow_types): Remove (moved to
7093 type-stack.c).
7094 * f-exp.y (type_stack): New global.
7095 Update rules.
7096 (push_kind_type, f_parse): Update.
7097 * d-exp.y (type_stack): New global.
7098 Update rules.
7099 (d_parse): Update.
7100 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7101 Update rules.
7102 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7103 (HFILES_NO_SRCDIR): Add type-stack.h.
7104
7105 2019-04-04 Tom Tromey <tom@tromey.com>
7106
7107 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7108 (rust_parser::convert_ast_to_expression, rust_parse)
7109 (rust_lex_test_completion, rust_lex_tests): Update.
7110 * parser-defs.h (struct expr_completion_state): New.
7111 (struct parser_state) <parser_state>: Add completion parameter.
7112 <mark_struct_expression, mark_completion_tag>: New methods.
7113 <parse_completion, m_completion_state>: New members.
7114 (prefixify_expression, null_post_parser): Update.
7115 (mark_struct_expression, mark_completion_tag): Don't declare.
7116 * parse.c (parse_completion, expout_last_struct)
7117 (expout_tag_completion_type, expout_completion_name): Remove
7118 globals.
7119 (parser_state::mark_struct_expression)
7120 (parser_state::mark_completion_tag): Now methods.
7121 (prefixify_expression): Add last_struct parameter.
7122 (prefixify_subexp): Likewise.
7123 (parse_exp_1): Update.
7124 (parse_exp_in_context): Add cstate parameter. Update.
7125 (parse_expression_for_completion): Create an
7126 expr_completion_state.
7127 (null_post_parser): Add "completion" parameter.
7128 * p-exp.y: Update rules.
7129 (yylex): Update.
7130 * language.h (struct language_defn) <la_post_parser>: Add
7131 "completing" parameter.
7132 * go-exp.y: Update rules.
7133 (lex_one_token): Update.
7134 * expression.h (parse_completion): Don't declare.
7135 * d-exp.y: Update rules.
7136 (lex_one_token): Update rules.
7137 * c-exp.y: Update rules.
7138 (lex_one_token): Update.
7139 * ada-lang.c (resolve): Add "parse_completion" parameter.
7140 (resolve_subexp): Likewise.
7141 (ada_resolve_function): Likewise.
7142
7143 2019-04-04 Tom Tromey <tom@tromey.com>
7144
7145 * parser-defs.h (struct parser_state) <start_arglist,
7146 end_arglist>: New methods.
7147 <arglist_len, m_funcall_chain>: New members.
7148 (arglist_len, start_arglist, end_arglist): Don't declare.
7149 * parse.c (arglist_len, funcall_chain): Remove global.
7150 (start_arglist, end_arglist): Remove functions.
7151 (parse_exp_in_context): Update.
7152 * p-exp.y: Update rules.
7153 * m2-exp.y: Update rules.
7154 * go-exp.y: Update rules.
7155 * f-exp.y: Update rules.
7156 * d-exp.y: Update rules.
7157 * c-exp.y: Update rules.
7158
7159 2019-04-04 Tom Tromey <tom@tromey.com>
7160
7161 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7162 lex_operator, push_back>: New methods.
7163 Update all rules.
7164 (rust_parser::lex_hex, lex_escape): Rename and update.
7165 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7166 (rust_parser::lex_operator): Rename and update.
7167 (rust_parser::lex_number, rustyylex, rustyyerror)
7168 (rust_lex_test_init, rust_lex_test_sequence)
7169 (rust_lex_test_push_back, rust_lex_tests): Update.
7170 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7171 parameter.
7172 <lexptr, prev_lexptr>: New members.
7173 (lexptr, prev_lexptr): Don't declare.
7174 * parse.c (lexptr, prev_lexptr): Remove globals.
7175 (parse_exp_in_context): Update.
7176 * p-exp.y (yylex, yyerror): Update.
7177 * m2-exp.y (parse_number, yylex, yyerror): Update.
7178 * go-exp.y (lex_one_token, yyerror): Update.
7179 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7180 * d-exp.y (lex_one_token, yyerror): Update.
7181 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7182 (lex_one_token, yyerror): Update.
7183 * ada-lex.l (YY_INPUT): Update.
7184 (rewind_to_char): Update.
7185 * ada-exp.y (yyerror): Update.
7186
7187 2019-04-04 Tom Tromey <tom@tromey.com>
7188
7189 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7190 * parser-defs.h (struct parser_state) <parser_state>: Add new
7191 parameter.
7192 <comma_terminates>: New member.
7193 (comma_terminates): Don't declare global.
7194 * parse.c (comma_terminates): Remove global.
7195 (parse_exp_in_context): Update.
7196 * p-exp.y (yylex): Update.
7197 * m2-exp.y (yylex): Update.
7198 * go-exp.y (lex_one_token): Update.
7199 * f-exp.y (yylex): Update.
7200 * d-exp.y (lex_one_token): Update.
7201 * c-exp.y (lex_one_token): Update.
7202 * ada-lex.l: Update.
7203
7204 2019-04-04 Tom Tromey <tom@tromey.com>
7205
7206 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7207 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7208 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7209 * parser-defs.h (paren_depth): Don't declare.
7210 * parse.c (paren_depth): Remove global.
7211 (parse_exp_in_context): Update.
7212 * p-exp.y (paren_depth): New global.
7213 (pascal_parse): Initialize it.
7214 * m2-exp.y (paren_depth): New global.
7215 (m2_parse): Initialize it.
7216 * go-exp.y (paren_depth): New global.
7217 (go_parse): Initialize it.
7218 * f-exp.y (paren_depth): New global.
7219 (f_parse): Initialize it.
7220 * d-exp.y (paren_depth): New global.
7221 (d_parse): Initialize it.
7222 * c-exp.y (paren_depth): New global.
7223 (c_parse): Initialize it.
7224 * ada-lex.l (paren_depth): New global.
7225 (lexer_init): Initialize it.
7226
7227 2019-04-04 Tom Tromey <tom@tromey.com>
7228
7229 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7230 (rust_parser::convert_ast_to_type)
7231 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7232 * parser-defs.h (struct parser_state) <parser_state>: Add
7233 parameters. Initialize new members.
7234 <expression_context_block, expression_context_pc>: New members.
7235 * parse.c (expression_context_block, expression_context_pc):
7236 Remove globals.
7237 (parse_exp_in_context): Update.
7238 * p-exp.y: Update all rules.
7239 (yylex): Update.
7240 * m2-exp.y: Update all rules.
7241 (yylex): Update.
7242 * go-exp.y (yylex): Update.
7243 * f-exp.y (yylex): Update.
7244 * d-exp.y: Update all rules.
7245 (yylex): Update.
7246 * c-exp.y: Update all rules.
7247 (lex_one_token, classify_name, yylex, c_parse): Update.
7248 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7249
7250 2019-04-04 Tom Tromey <tom@tromey.com>
7251
7252 * gdbarch.h, gdbarch.c: Rebuild.
7253 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7254 * stap-probe.h:
7255 (struct stap_parse_info): Replace "parser_state" with
7256 "expr_builder".
7257 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7258 (parser_state): New class.
7259 * parse.c (expr_builder): Rename.
7260 (expr_builder::release): Rename.
7261 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7262 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7263 (write_exp_elt_longcst, write_exp_elt_floatcst)
7264 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7265 (write_exp_string_vector, write_exp_bitstring)
7266 (write_exp_msymbol, mark_struct_expression)
7267 (write_dollar_variable)
7268 (insert_type_address_space, increase_expout_size): Replace
7269 "parser_state" with "expr_builder".
7270 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7271 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7272 "parser_state" with "expr_builder".
7273
7274 2019-04-04 Tom Tromey <tom@tromey.com>
7275
7276 * rust-exp.y: Replace "parse_language" with method call.
7277 * p-exp.y:
7278 (yylex): Replace "parse_language" with method call.
7279 * m2-exp.y:
7280 (yylex): Replace "parse_language" with method call.
7281 * go-exp.y (classify_name): Replace "parse_language" with method
7282 call.
7283 * f-exp.y (yylex): Replace "parse_language" with method call.
7284 * d-exp.y (lex_one_token): Replace "parse_language" with method
7285 call.
7286 * c-exp.y:
7287 (lex_one_token, classify_name, yylex): Replace "parse_language"
7288 with method call.
7289 * ada-exp.y (find_primitive_type, type_char)
7290 (type_system_address): Replace "parse_language" with method call.
7291
7292 2019-04-04 Tom Tromey <tom@tromey.com>
7293
7294 * rust-exp.y: Replace "parse_gdbarch" with method call.
7295 * parse.c (write_dollar_variable, insert_type_address_space):
7296 Replace "parse_gdbarch" with method call.
7297 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7298 call.
7299 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7300 call.
7301 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7302 "parse_gdbarch" with method call.
7303 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7304 with method call.
7305 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7306 "parse_gdbarch" with method call.
7307 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7308 "parse_gdbarch" with method call.
7309 * c-exp.y (parse_type, parse_number, classify_name): Replace
7310 "parse_gdbarch" with method call.
7311 * ada-lex.l: Replace "parse_gdbarch" with method call.
7312 * ada-exp.y (parse_type, find_primitive_type, type_char)
7313 (type_system_address): Replace "parse_gdbarch" with method call.
7314
7315 2019-04-04 Tom Tromey <tom@tromey.com>
7316
7317 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7318 * stap-probe.c (stap_parse_argument): Update.
7319 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7320 initial_size parameter.
7321 * rust-exp.y (rust_lex_tests): Update.
7322 * parse.c (parser_state): Update.
7323 (parse_exp_in_context): Update.
7324 * parser-defs.h (struct parser_state) <parser_state>: Remove
7325 "initial_size" parameter.
7326
7327 2019-04-04 Tom Tromey <tom@tromey.com>
7328
7329 * parser-defs.h (increase_expout_size): Don't declare.
7330 * parse.c (increase_expout_size): Now static.
7331
7332 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7333
7334 * gnu-nat.c (gnu_nat_target::wait): Fix
7335 target_waitstatus_to_string call.
7336
7337 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7338
7339 * eval.c (evaluate_subexp_standard): Handle internal functions
7340 during Fortran function call handling.
7341
7342 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7343
7344 * NEWS: Mention new internal functions.
7345 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7346 (read_base_type): Use dwarf2_init_complex_target_type.
7347 * value.c (creal_internal_fn): New function.
7348 (cimag_internal_fn): New function.
7349 (_initialize_values): Register new internal functions.
7350
7351 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7352
7353 * infrun.c (stop_all_threads): If debug_infrun, always
7354 trace the wait status after wait_one, using
7355 target_waitstatus_to_string and target_pid_to_str.
7356 (handle_inferior_event): Replace various trace of
7357 wait status kind by a single trace.
7358 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7359 wait status kind image by target_waitstatus_to_string.
7360 * target/waitstatus.c (target_waitstatus_to_string): Fix
7361 obsolete comment.
7362
7363 2019-04-01 Tom Tromey <tromey@adacore.com>
7364
7365 PR symtab/23331:
7366 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7367
7368 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7369 Pedro Alves <palves@redhat.com>
7370
7371 * top.c (quit_force): Call 'finalize_values'.
7372 * value.c (finalize_values): New function.
7373 * value.h (finalize_values): Declare.
7374
7375 2019-03-30 Eli Zaretskii <eliz@gnu.org>
7376
7377 * NEWS: Announce $_gdb_major and $_gdb_minor.
7378
7379 * top.c (init_gdb_version_vars): New function.
7380 (gdb_init): Call init_gdb_version_vars.
7381
7382 2019-03-29 Tom Tromey <tromey@adacore.com>
7383
7384 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7385 help text. Remove dead code.
7386
7387 2019-03-29 Keith Seitz <keiths@redhat.com>
7388
7389 From Siddhesh Poyarekar:
7390 * f-lang.h (f77_get_upperbound): Return LONGEST.
7391 (f77_get_lowerbound): Likewise.
7392 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7393 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7394 print them.
7395 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7396 plongest to format print it.
7397 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7398 (f77_get_upperbound): Likewise.
7399 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7400 LOWER_BOUND to LONGEST.
7401 (f77_create_arrayprint_offset_tbl): Likewise.
7402
7403 2019-03-29 Keith Seitz <keiths@redhat.com>
7404
7405 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7406 %s/pulongest for TYPE_LENGTH instead of %d in format
7407 strings.
7408 * ada-typerint.c (ada_print_type): Likewise.
7409 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7410 * compile/compile-c-support.c (generate_register_struct): Likewise.
7411 * gdbtypes.c (recursive_dump_type): Likewise.
7412 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7413 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7414 instead of %d in format strings.
7415 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7416 to std::min to ULONGEST.
7417 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7418 instead of %d in format strings.
7419 * tracepoint.c (info_scope_command): Likewise.
7420 * typeprint.c (print_offset_data::update)
7421 (print_offset_data::finish): Likewise.
7422 * xtensa-tdep.c (xtensa_store_return_value)
7423 (xtensa_push_dummy_call): Likewise.
7424
7425 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7426
7427 * windows-nat.c (display_selector): Fixed format specifications
7428 for 64-bit Cygwin.
7429
7430 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7431
7432 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7433
7434 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7435
7436 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7437 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7438 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7439 (nios2_linux_init_abi): Install it.
7440
7441 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7442
7443 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7444
7445 2019-03-28 Alan Hayward <alan.hayward@arm.com>
7446
7447 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7448
7449 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7450 Tom Tromey <tromey@adacore.com>
7451
7452 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7453
7454 2019-03-26 Joel Brobecker <brobecker@adacore.com>
7455
7456 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7457 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7458 method to compute the bounds of range types. Also print "[evaluated]"
7459 if the bounds' values come from a dynamic evaluation.
7460
7461 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7462
7463 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7464 whitespace when pretty printing is on.
7465
7466 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7467
7468 * ppc-linux-nat.c: Add include.
7469
7470 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7471
7472 * NEWS: Mention AArch64 Pointer Authentication.
7473
7474 2019-03-26 Alan Hayward <alan.hayward@arm.com>
7475
7476 * arm-linux-nat.c: Add include.
7477
7478 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7479
7480 * source-cache.c (source_cache::get_source_lines): Re-read
7481 fullname after calling open_source_file.
7482
7483 2019-03-25 John Baldwin <jhb@FreeBSD.org>
7484
7485 * NEWS: Mention TLS support for FreeBSD.
7486
7487 2019-03-25 Tom Tromey <tromey@adacore.com>
7488
7489 * minsyms.c (BUNCH_SIZE): Update comment.
7490 (~minimal_symbol_reader): Remove old comment.
7491 (compact_minimal_symbols): Update comment.
7492 (minimal_symbol_reader::install): Remove old comment. Update
7493 other comments.
7494
7495 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7496
7497 * s390-linux-nat.c: Add include.
7498
7499 2019-03-25 Alan Hayward <alan.hayward@arm.com>
7500
7501 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7502 Call linux_get_hwcap.
7503 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7504 Likewise.
7505 (aarch64_linux_get_hwcap): Remove function.
7506 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7507 declaration.
7508 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7509 linux_get_hwcap.
7510 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7511 * linux-tdep.c (linux_get_hwcap): Add function.
7512 (linux_get_hwcap2): Likewise.
7513 * linux-tdep.h (linux_get_hwcap): Add declaration.
7514 (linux_get_hwcap2): Likewise.
7515 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7516 (ppc_linux_get_hwcap2): Likewise.
7517 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7518 linux_get_hwcap.
7519 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7520 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7521 (ppc_linux_nat_target::read_description): Likewise.
7522 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7523 * s390-linux-nat.c: Likewise.
7524 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7525
7526 2019-03-24 Tom Tromey <tom@tromey.com>
7527
7528 * ada-lang.c (standard_lookup): Simplify initialization.
7529 (ada_lookup_symbol_nonlocal): Simplify return.
7530 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7531 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7532 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7533 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7534 initialization.
7535 * solib.c (solib_global_lookup): Simplify.
7536 * symtab.c (null_block_symbol): Remove.
7537 (symbol_cache_lookup): Simplify returns.
7538 (lookup_language_this): Simplify returns.
7539 (lookup_symbol_aux): Simplify return.
7540 (lookup_local_symbol): Simplify returns.
7541 (lookup_global_symbol_from_objfile): Simplify return.
7542 (lookup_symbol_in_objfile_symtabs)
7543 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7544 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7545 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7546 * cp-namespace.c (cp_lookup_bare_symbol)
7547 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7548 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7549 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7550 (cp_lookup_symbol_via_imports): Simplify initialization.
7551 (find_symbol_in_baseclass): Likewise.
7552 * symtab.h (null_block_symbol): Remove.
7553 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7554 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7555 (d_lookup_symbol_module): Likewise.
7556 (find_symbol_in_baseclass): Simplify initialization.
7557
7558 2019-03-24 Tom Tromey <tom@tromey.com>
7559
7560 * expression.h: Don't include symtab.h.
7561 (struct block): Forward declare.
7562
7563 2019-03-24 Tom Tromey <tom@tromey.com>
7564
7565 * c-exp.y (typebase): Remove casts.
7566 * gdbtypes.c (lookup_unsigned_typename, )
7567 (lookup_signed_typename): Remove cast.
7568 * eval.c (parse_to_comma_and_eval): Remove cast.
7569 * parse.c (write_dollar_variable): Remove cast.
7570 * block.h (struct block) <superblock>: Now const.
7571 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7572 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7573 (map_block): Make "block" const.
7574 * symfile.h (struct quick_symbol_functions)
7575 <map_matching_symbols>: Constify block argument to "callback".
7576 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7577 const.
7578 (find_pc_sect_compunit_symtab): Make "b" const.
7579 (find_symbol_at_address): Likewise.
7580 (search_symbols): Likewise.
7581 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7582 (dw2_debug_names_lookup_symbol): Likewise.
7583 (dw2_map_matching_symbols): Update.
7584 * p-valprint.c (pascal_val_print): Remove "block".
7585 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7586 (aux_add_nonlocal_symbols): Make "block" const.
7587 (resolve_subexp): Remove cast.
7588 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7589 const.
7590 (iterate_over_file_blocks): Likewise.
7591 * f-exp.y (%union) <bval>: Remove.
7592 * coffread.c (patch_opaque_types): Make "b" const.
7593 * spu-tdep.c (spu_catch_start): Make "block" const.
7594 * c-valprint.c (print_unpacked_pointer): Remove "block".
7595 * symmisc.c (dump_symtab_1): Make "b" const.
7596 (block_depth): Make "block" const.
7597 * d-exp.y (%union) <bval>: Remove.
7598 * cp-support.h (cp_lookup_rtti_type): Update.
7599 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7600 * psymtab.c (psym_lookup_symbol): Make "block" const.
7601 (maintenance_check_psymtabs): Make "b" const.
7602 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7603 (enumerate_locals, enumerate_args): Update.
7604 * python/py-symtab.c (stpy_global_block): Make "block" const.
7605 (stpy_static_block): Likewise.
7606 * inline-frame.c (block_starting_point_at): Make "new_block"
7607 const.
7608 * block.c (find_block_in_blockvector): Make return type const.
7609 (blockvector_for_pc_sect): Make "b" const.
7610 (find_block_in_blockvector): Make "b" const.
7611
7612 2019-03-23 Tom Tromey <tom@tromey.com>
7613
7614 * varobj.c (varobj_create): Update.
7615 * symfile.c (clear_symtab_users): Don't reset innermost_block.
7616 * printcmd.c (display_command, do_one_display): Don't reset
7617 innermost_block.
7618 * parser-defs.h (enum innermost_block_tracker_type): Move to
7619 expression.h.
7620 (innermost_block): Update comment.
7621 * parse.c (parse_exp_1): Add tracker_types parameter.
7622 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
7623 tracker_types parameter. Reset innermost_block.
7624 (parse_exp_in_context): Remove.
7625 (parse_expression_for_completion): Update.
7626 * objfiles.c (~objfile): Don't reset expression_context_block or
7627 innermost_block.
7628 * expression.h (enum innermost_block_tracker_type): Move from
7629 parser-defs.h.
7630 (parse_exp_1): Add tracker_types parameter.
7631 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7632 reset innermost_block.
7633
7634 2019-03-23 Tom Tromey <tom@tromey.com>
7635
7636 * objfiles.h: Include bcache.h.
7637
7638 2019-03-23 Tom Tromey <tom@tromey.com>
7639
7640 * linespec.c (get_current_search_block): Use
7641 scoped_restore_current_language.
7642 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7643
7644 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7645 Jiong Wang <jiong.wang@arm.com>
7646
7647 * aarch64-linux-tdep.c
7648 (aarch64_linux_iterate_over_regset_sections): Check for pauth
7649 section.
7650 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7651
7652 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7653 Jiong Wang <jiong.wang@arm.com>
7654
7655 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7656 instructions.
7657 (aarch64_analyze_prologue_test): Add PACIASP test.
7658 (aarch64_prologue_prev_register): Unmask PC value.
7659
7660 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7661 Jiong Wang <jiong.wang@arm.com>
7662
7663 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7664 (aarch64_dwarf2_prev_register): Unmask PC value.
7665 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7666 (aarch64_execute_dwarf_cfa_vendor_op): Check for
7667 DW_CFA_AARCH64_negate_ra_state.
7668 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7669
7670 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7671 Jiong Wang <jiong.wang@arm.com>
7672
7673 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7674 registers.
7675 (aarch64_pseudo_register_name): Likewise.
7676 (aarch64_pseudo_register_type): Likewise.
7677 (aarch64_pseudo_register_reggroup_p): Likewise.
7678 (aarch64_gdbarch_init): Add pauth registers.
7679 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7680 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7681 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7682 (struct gdbarch_tdep): Add regnum for ra_state.
7683
7684 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7685 Jiong Wang <jiong.wang@arm.com>
7686
7687 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7688
7689 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7690 Jiong Wang <jiong.wang@arm.com>
7691
7692 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7693 function.
7694 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7695 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7696 (aarch64_gdbarch_init): Add puth registers.
7697 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7698 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7699 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7700
7701 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7702 Jiong Wang <jiong.wang@arm.com>
7703
7704 * aarch64-linux-nat.c
7705 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7706 * aarch64-linux-tdep.c
7707 (aarch64_linux_core_read_description): Likewise.
7708 (aarch64_linux_get_hwcap): New function.
7709 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7710 (aarch64_linux_get_hwcap): New declaration.
7711
7712 2019-03-22 Alan Hayward <alan.hayward@arm.com>
7713 Jiong Wang <jiong.wang@arm.com>
7714
7715 * aarch64-linux-nat.c
7716 (aarch64_linux_nat_target::read_description): Add pauth param.
7717 * aarch64-linux-tdep.c
7718 (aarch64_linux_core_read_description): Likewise.
7719 * aarch64-tdep.c (struct target_desc): Add in pauth.
7720 (aarch64_read_description): Add pauth param.
7721 (aarch64_gdbarch_init): Likewise.
7722 * aarch64-tdep.h (aarch64_read_description): Likewise.
7723 * arch/aarch64.c (aarch64_create_target_description): Likewise.
7724 * arch/aarch64.h (aarch64_create_target_description): Likewise.
7725 * features/Makefile: Add new files.
7726 * features/aarch64-pauth.c: New file.
7727 * features/aarch64-pauth.xml: New file.
7728
7729 2019-03-20 Tom Tromey <tromey@adacore.com>
7730
7731 * infrun.c (handle_inferior_event): Rename from
7732 handle_inferior_event_1. Create a scoped_value_mark.
7733 (handle_inferior_event): Remove.
7734
7735 2019-03-19 Tom Tromey <tromey@adacore.com>
7736
7737 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7738 * infrun.h (print_stop_event): Add "displays" parameter.
7739 * infrun.c (print_stop_event): Add "displays" parameter.
7740
7741 2019-03-19 Pedro Alves <palves@redhat.com>
7742
7743 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7744 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
7745 to -1. Fix TABs vs spaces.
7746 (tui_ui_out::tui_ui_out): Don't initialize fields here.
7747 * tui/tui-out.h (tui_ui_out) Add intro comments.
7748 <m_line, m_start_of_line>: In-class initialize, and add describing
7749 comment.
7750
7751 2019-03-18 Alan Hayward <alan.hayward@arm.com>
7752
7753 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7754 variable names.
7755 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7756
7757 2019-03-18 Pedro Alves <palves@redhat.com>
7758 Eli Zaretskii <eliz@gnu.org>
7759
7760 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7761 m_line and m_start_of_line.
7762
7763 2019-03-18 Eli Zaretskii <eliz@gnu.org>
7764
7765 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7766 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7767 it returns a newline. This fixes a regression in TU mode, whereby
7768 the next line is output on the same screen line as the user input.
7769
7770 2019-03-18 Tom Tromey <tromey@adacore.com>
7771
7772 * minsyms.c (minimal_symbol_reader::install): Remove call to
7773 obstack_blank.
7774
7775 2019-03-18 Pedro Alves <palves@redhat.com>
7776
7777 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7778 New globals.
7779 (apply_style): New, factored out from ...
7780 (apply_ansi_escape): ... this. Handle reverse video mode.
7781 (tui_set_reverse_mode): New function.
7782 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7783 * tui/tui-winsource.c (tui_show_source_line): Use
7784 tui_set_reverse_mode instead of setting A_STANDOUT.
7785 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7786 New setter methods.
7787
7788 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
7789
7790 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7791 Handle tabs.
7792
7793 2019-03-18 Tom Tromey <tromey@adacore.com>
7794
7795 * ada-lang.c (empty_array): Add "high" parameter.
7796 (ada_evaluate_subexp): Update.
7797
7798 2019-03-17 Sergei Trofimovich <siarheit@google.com>
7799
7800 * unittests/string_view-selftests.c: Define
7801 _initialize_string_view_selftests unconditionally.
7802
7803 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7804
7805 PR gdb/24350
7806 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7807
7808 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
7809
7810 PR gdb/24351
7811 * windows-nat.c (display_selector): Fix format specifiers.
7812
7813 2019-03-17 Eli Zaretskii <eliz@gnu.org>
7814
7815 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7816 tui_refill_source_window instead of tui_refresh_win, to update the
7817 current execution line. This fixes redisplay of the current line
7818 when stepping through the code with "next" or "step".
7819
7820 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7821
7822 * source-cache.c (source_cache::get_source_lines): Call
7823 find_source_lines to initialize s->nlines. This fixes vertical
7824 scrolling of TUI source window when the DOWN arrow is pressed.
7825
7826 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7827
7828 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7829 linux-thread-db.c (_initialize_thread_db): Likewise.
7830
7831 2019-03-16 Eli Zaretskii <eliz@gnu.org>
7832
7833 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7834 wclrtoeol in tui_show_source_line". This reverts changes made in
7835 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7836
7837 2019-03-15 Tom Tromey <tom@tromey.com>
7838
7839 * symtab.h (struct minimal_symbol): Derive from
7840 general_symbol_info.
7841 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7842 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7843 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7844 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7845 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7846 (MSYMBOL_SEARCH_NAME): Update.
7847 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7848 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7849 * minsyms.c (minimal_symbol_reader::record_full): Update.
7850
7851 2019-03-15 Tom Tromey <tom@tromey.com>
7852
7853 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7854
7855 2019-03-15 Tom Tromey <tom@tromey.com>
7856
7857 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7858 unique_xmalloc_ptr.
7859 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7860 Update.
7861 * minsyms.c (lookup_minimal_symbol_by_pc_section)
7862 (build_minimal_symbol_hash_tables)
7863 (minimal_symbol_reader::install): Update.
7864
7865 2019-03-15 Tom Tromey <tom@tromey.com>
7866
7867 * symtab.c (create_demangled_names_hash): Update.
7868 (symbol_set_names): Update.
7869 * objfiles.h (struct objfile_per_bfd_storage)
7870 <demangled_names_hash>: Now an htab_up.
7871 * objfiles.c (objfile_per_bfd_storage): Simplify.
7872
7873 2019-03-15 Tom Tromey <tom@tromey.com>
7874
7875 * objfiles.h (struct objfile_per_bfd_storage): Declare
7876 destructor.
7877 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7878 New.
7879 (get_objfile_bfd_data): Use new. Don't initialize
7880 language_of_main.
7881 (free_objfile_per_bfd_storage): Remove.
7882 (objfile_bfd_data_free, objfile::~objfile): Use delete.
7883
7884 2019-03-15 Tom Tromey <tom@tromey.com>
7885
7886 * symfile.c (reread_symbols): Update.
7887 * objfiles.c (objfile::objfile): Update.
7888 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7889 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7890 comment.
7891 (minimal_symbol_reader::install): Update.
7892 (terminate_minimal_symbol_table): Remove.
7893 * jit.c (jit_object_close_impl): Update.
7894
7895 2019-03-15 Tom Tromey <tom@tromey.com>
7896
7897 * minsyms.c (minimal_symbol_reader::record_full): Remove some
7898 initializations.
7899
7900 2019-03-15 Tom Tromey <tom@tromey.com>
7901
7902 * objfiles.h (struct objfile_per_bfd_storage)
7903 <demangled_hash_languages>: Now a bitset.
7904 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7905 (lookup_minimal_symbol): Update.
7906
7907 2019-03-15 Tom Tromey <tom@tromey.com>
7908
7909 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7910 Don't return the symbol.
7911 * coffread.c (record_minimal_symbol): Use record_full.
7912
7913 2019-03-14 Eli Zaretskii <eliz@gnu.org>
7914
7915 The MS-Windows port of ncurses fails to switch to a color pair if
7916 one or both of the colors are the implicit default colors. This
7917 change records the default colors when TUI is initialized, and
7918 then specifies them explicitly when a color pair uses the default
7919 colors. This allows color styling in TUI mode on MS-Windows.
7920
7921 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
7922 ncurses_norm_attr.
7923 (tui_initialize_io) [__MINGW32__]: Record the default terminal
7924 colors in ncurses_norm_attr.
7925 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7926 "none", replace it with the default color recorded in
7927 ncurses_norm_attr.
7928
7929 2019-03-14 Tom Tromey <tromey@adacore.com>
7930
7931 * source-cache.h (class source_cache) <get_source_lines>: Return
7932 std::string.
7933 * source-cache.c (source_cache::extract_lines): Handle case where
7934 first_pos==npos. Return std::string.
7935 (source_cache::get_source_lines): Update.
7936
7937 2019-03-14 Tom Tromey <tromey@adacore.com>
7938
7939 * NEWS: Add item for "style sources" commands.
7940 * source-cache.c (source_cache::get_source_lines): Check
7941 source_styling.
7942 * cli/cli-style.c (source_styling): New global.
7943 (_initialize_cli_style): Add "style sources" commands.
7944 (show_style_sources): New function.
7945 * cli/cli-style.h (source_styling): Declare.
7946
7947 2019-03-14 Pedro Alves <palves@redhat.com>
7948 Tom Tromey <tromey@adacore.com>
7949
7950 * tui/tui-winsource.h (tui_refill_source_window): Declare.
7951 * tui/tui-winsource.c (tui_refill_source_window): New function,
7952 from...
7953 (tui_horizontal_source_scroll): ... here. Move some logic.
7954 * cli/cli-style.c (set_style_enabled): Notify new observable.
7955 * tui/tui-hooks.c (tui_redisplay_source): New function.
7956 (tui_attach_detach_observers): Attach or detach
7957 tui_redisplay_source.
7958 * observable.h (source_styling_changed): New observable.
7959 * observable.c: Define source_styling_changed observable.
7960
7961 2019-03-13 Tom Tromey <tromey@adacore.com>
7962
7963 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7964 (i386_gnu_nat_target::store_registers): Update.
7965 * target-debug.h (target_debug_print_std_string): New macro.
7966 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7967 * windows-tdep.c (display_one_tib): Update.
7968 * tui/tui-stack.c (tui_make_status_line): Update.
7969 * top.c (print_inferior_quit_action): Update.
7970 * thread.c (thr_try_catch_cmd): Update.
7971 (add_thread_with_info): Update.
7972 (thread_target_id_str): Update.
7973 (thr_try_catch_cmd): Update.
7974 (thread_command): Update.
7975 (thread_find_command): Update.
7976 * record-btrace.c (record_btrace_target::info_record)
7977 (record_btrace_resume_thread, record_btrace_target::resume)
7978 (record_btrace_cancel_resume, record_btrace_step_thread)
7979 (record_btrace_target::wait, record_btrace_target::wait)
7980 (record_btrace_target::wait, record_btrace_target::stop): Update.
7981 * progspace.c (print_program_space): Update.
7982 * process-stratum-target.c
7983 (process_stratum_target::thread_address_space): Update.
7984 * linux-fork.c (linux_fork_mourn_inferior)
7985 (detach_checkpoint_command, info_checkpoints_command)
7986 (linux_fork_context): Update.
7987 (linux_fork_detach): Update.
7988 (class scoped_switch_fork_info): Update.
7989 (delete_checkpoint_command): Update.
7990 * infrun.c (follow_fork_inferior): Update.
7991 (follow_fork_inferior): Update.
7992 (proceed_after_vfork_done): Update.
7993 (handle_vfork_child_exec_or_exit): Update.
7994 (follow_exec): Update.
7995 (displaced_step_prepare_throw): Update.
7996 (displaced_step_restore): Update.
7997 (start_step_over): Update.
7998 (resume_1): Update.
7999 (clear_proceed_status_thread): Update.
8000 (proceed): Update.
8001 (print_target_wait_results): Update.
8002 (do_target_wait): Update.
8003 (context_switch): Update.
8004 (stop_all_threads): Update.
8005 (restart_threads): Update.
8006 (finish_step_over): Update.
8007 (handle_signal_stop): Update.
8008 (switch_back_to_stepped_thread): Update.
8009 (keep_going_pass_signal): Update.
8010 (print_exited_reason): Update.
8011 (normal_stop): Update.
8012 * inferior.c (inferior_pid_to_str): Change return type.
8013 (print_selected_inferior): Update.
8014 (add_inferior): Update.
8015 (detach_inferior): Update.
8016 * dummy-frame.c (fprint_dummy_frames): Update.
8017 * dcache.c (dcache_info_1): Update.
8018 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8019 (btrace_fetch, btrace_clear): Update.
8020 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8021 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8022 type.
8023 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8024 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8025 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8026 * gdbarch.c, gdbarch.h: Rebuild.
8027 * gdbarch.sh (core_pid_to_str): Change return type.
8028 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8029 return type.
8030 (windows_nat_target::pid_to_str): Change return type.
8031 (windows_delete_thread): Update.
8032 (windows_nat_target::attach): Update.
8033 (windows_nat_target::files_info): Update.
8034 * target-delegates.c: Rebuild.
8035 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8036 return type.
8037 (sol_thread_target::pid_to_str): Change return type.
8038 * remote.c (class remote_target) <pid_to_str>: Change return
8039 type.
8040 (remote_target::pid_to_str): Change return type.
8041 (extended_remote_target::attach, remote_target::remote_stop_ns)
8042 (remote_target::remote_notif_remove_queued_reply)
8043 (remote_target::push_stop_reply, remote_target::disable_btrace):
8044 Update.
8045 (extended_remote_target::attach): Update.
8046 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8047 type.
8048 (gdbsim_target::pid_to_str): Change return type.
8049 * ravenscar-thread.c (struct ravenscar_thread_target)
8050 <pid_to_str>: Change return type.
8051 (ravenscar_thread_target::pid_to_str): Change return type.
8052 * procfs.c (class procfs_target) <pid_to_str>: Change return
8053 type.
8054 (procfs_target::pid_to_str): Change return type.
8055 (procfs_target::attach): Update.
8056 (procfs_target::detach): Update.
8057 (procfs_target::fetch_registers): Update.
8058 (procfs_target::store_registers): Update.
8059 (procfs_target::wait): Update.
8060 (procfs_target::files_info): Update.
8061 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8062 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8063 return type.
8064 (nto_procfs_target::pid_to_str): Change return type.
8065 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8066 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8067 return type.
8068 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8069 (exit_lwp): Update.
8070 (attach_proc_task_lwp_callback, get_detach_signal)
8071 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8072 (linux_nat_target::resume, wait_lwp, stop_callback)
8073 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8074 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8075 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8076 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8077 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8078 type.
8079 (inf_ptrace_target::attach): Update.
8080 (inf_ptrace_target::files_info): Update.
8081 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8082 type.
8083 (go32_nat_target::pid_to_str): Change return type.
8084 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8085 (gnu_nat_target::wait): Update.
8086 (gnu_nat_target::wait): Update.
8087 (gnu_nat_target::resume): Update.
8088 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8089 (fbsd_nat_target::wait): Update.
8090 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8091 type.
8092 (darwin_nat_target::attach): Update.
8093 * corelow.c (class core_target) <pid_to_str>: Change return type.
8094 (core_target::pid_to_str): Change return type.
8095 * target.c (normal_pid_to_str): Change return type.
8096 (default_pid_to_str): Likewise.
8097 (target_pid_to_str): Change return type.
8098 (target_translate_tls_address): Update.
8099 (target_announce_detach): Update.
8100 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8101 return type.
8102 (bsd_uthread_target::pid_to_str): Change return type.
8103 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8104 type.
8105 (bsd_kvm_target::pid_to_str): Change return type.
8106 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8107 return type.
8108 (aix_thread_target::pid_to_str): Change return type.
8109 * target.h (struct target_ops) <pid_to_str>: Change return type.
8110 (target_pid_to_str, normal_pid_to_str): Likewise.
8111 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8112 type.
8113 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8114 type.
8115 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8116 return type.
8117 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8118 type.
8119 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8120 type.
8121 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8122 return type.
8123
8124 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8125
8126 * NEWS: Mention that the new default MI version is 3. Mention
8127 changes to the output of commands and events that deal with
8128 multi-location breakpoints.
8129 * breakpoint.c: Include "mi/mi-out.h".
8130 (print_one_breakpoint): Change output syntax if using MI version
8131 >= 3.
8132 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8133 New.
8134 (mi_multi_location_breakpoint_output_fixed): New.
8135 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8136 (mi_cmd_fix_multi_location_breakpoint_output): New.
8137 (mi_multi_location_breakpoint_output_fixed): New.
8138 * mi/mi-cmds.c (mi_cmds): Register command
8139 -fix-multi-location-breakpoint-output.
8140 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8141 interpreter "mi".
8142
8143 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8144
8145 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8146 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8147 instantiate mi_ui_out based on interpreter name.
8148 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8149 * mi/mi-main.c (mi_load_progress): Likewise.
8150
8151 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8152
8153 * NEWS: Combine separate "New targets" sections for 8.3.
8154
8155 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8156
8157 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8158 (ppcfbsd_init_abi): Install gdbarch
8159 "fetch_tls_load_module_address" and "get_thread_local_address"
8160 methods.
8161
8162 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8163
8164 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8165 (riscv_fbsd_init_abi): Install gdbarch
8166 "fetch_tls_load_module_address" and "get_thread_local_address"
8167 methods.
8168
8169 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8170
8171 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8172 (i386fbsd_init_abi): Install gdbarch
8173 "fetch_tls_load_module_address" and "get_thread_local_address"
8174 methods.
8175
8176 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8177
8178 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8179 (amd64fbsd_init_abi): Install gdbarch
8180 "fetch_tls_load_module_address" and "get_thread_local_address"
8181 methods.
8182
8183 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8184
8185 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8186 (struct fbsd_pspace_data): New type.
8187 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8188 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8189 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8190 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8191 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8192
8193 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8194
8195 * gdbtypes.c (lookup_struct_elt): New function.
8196 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8197 * gdbtypes.h (struct struct_elt): New type.
8198 (lookup_struct_elt): New prototype.
8199
8200 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8201
8202 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8203 remove disabled code block.
8204
8205 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8206
8207 * gdbarch.sh (get_thread_local_address): New method.
8208 * gdbarch.h, gdbarch.c: Regenerate.
8209 * target.c (target_translate_tls_address): Use
8210 gdbarch_get_thread_local_address if present instead of
8211 target::get_thread_local_address.
8212
8213 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8214
8215 * target.h (target::get_thread_local_address): Update comment.
8216
8217 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8218
8219 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8220 objfile->separate_debug_objfile_backlink if not NULL.
8221
8222 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8223
8224 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8225 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8226 (amd64bsd_store_inferior_registers): Likewise.
8227 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8228 Enable segment base registers.
8229 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8230 PT_GETFSBASE and PT_GETGSBASE.
8231 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8232 PT_SETGSBASE.
8233 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8234 segment base registers.
8235 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8236
8237 2019-03-12 John Baldwin <jhb@FreeBSD.org>
8238
8239 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8240 Update calls to i386_target_description to add 'segments'
8241 parameter.
8242 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8243 add segment base registers.
8244 * arch/i386.c (i386_create_target_description): Add 'segments'
8245 parameter to enable segment base registers.
8246 * arch/i386.h (i386_create_target_description): Likewise.
8247 * features/i386/32bit-segments.xml: New file.
8248 * features/i386/32bit-segments.c: Generate.
8249 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8250 call to i386_target_description to add 'segments' parameter.
8251 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8252 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8253 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8254 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8255 if feature is present.
8256 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8257 Add 'segments' parameter to call to i386_target_description.
8258 (i386_target_description): Add 'segments' parameter to enable
8259 segment base registers.
8260 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8261 to call to i386_target_description.
8262 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8263 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8264 Define I386_NUM_REGS.
8265 (i386_target_description): Add 'segments' parameter to enable
8266 segment base registers.
8267
8268 2019-03-12 Eli Zaretskii <eliz@gnu.org>
8269
8270 PR/24325
8271 * source-cache.c: #undef open and close, to avoid unresolved
8272 externals during linking.
8273
8274 2019-03-12 Tom Tromey <tromey@adacore.com>
8275
8276 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8277 const. Add initializers.
8278 (_initialize_remote): Don't initialize ptid globals.
8279
8280 2019-03-12 Pedro Alves <palves@redhat.com>
8281
8282 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8283
8284 2019-03-12 Pedro Alves <palves@redhat.com>
8285
8286 * cp-name-parser.y (main): Remove unused 'len' variable.
8287
8288 2019-03-12 Tom Tromey <tromey@adacore.com>
8289
8290 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8291 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8292
8293 2019-03-12 Tom Tromey <tromey@adacore.com>
8294
8295 * linux-nat.c (iterate_over_lwps): Update.
8296 (stop_callback): Remove parameter.
8297 (stop_wait_callback, detach_callback, resume_set_callback)
8298 (select_singlestep_lwp_callback, set_ignore_sigint)
8299 (status_callback, resumed_callback, resume_clear_callback)
8300 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8301 data parameter.
8302 (linux_nat_target::detach, linux_nat_target::resume)
8303 (linux_stop_and_wait_all_lwps, select_event_lwp)
8304 (linux_nat_filter_event, linux_nat_wait_1)
8305 (linux_nat_target::kill, linux_nat_target::stop)
8306 (linux_nat_target::stop): Update.
8307 (linux_nat_resume_callback): Change type.
8308 (resume_stopped_resumed_lwps, count_events_callback)
8309 (select_event_lwp_callback): Likewise.
8310 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8311 * arm-linux-nat.c (struct update_registers_data): Remove.
8312 (update_registers_callback): Change type.
8313 (arm_linux_insert_hw_breakpoint1): Update.
8314 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8315 parameter.
8316 (x86_linux_dr_set_addr): Update.
8317 (x86_linux_dr_set_control): Update.
8318 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8319 (iterate_over_lwps): Use gdb::function_view.
8320 * nat/aarch64-linux-hw-point.c (struct
8321 aarch64_dr_update_callback_param): Remove.
8322 (debug_reg_change_callback): Change type.
8323 (aarch64_notify_debug_reg_change): Update.
8324 * s390-linux-nat.c (s390_refresh_per_info): Update.
8325
8326 2019-03-11 Tom Tromey <tromey@adacore.com>
8327
8328 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8329 redundant assignment to "this_cu".
8330
8331 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8332
8333 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8334
8335 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8336
8337 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8338 from...
8339 (rank_one_type): ... this.
8340
8341 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8342
8343 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8344 from...
8345 (rank_one_type): ... this.
8346
8347 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8348
8349 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8350 from...
8351 (rank_one_type): ... this.
8352
8353 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8354
8355 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8356 from...
8357 (rank_one_type): ... this.
8358
8359 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8360
8361 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8362 from...
8363 (rank_one_type): ... this.
8364
8365 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8366
8367 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8368 from...
8369 (rank_one_type): ... this.
8370
8371 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8372
8373 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8374 from...
8375 (rank_one_type): ... this.
8376
8377 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8378
8379 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8380 from...
8381 (rank_one_type): ... this.
8382
8383 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8384
8385 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8386 from...
8387 (rank_one_type): ... this.
8388
8389 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8390
8391 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8392 from...
8393 (rank_one_type): ... this.
8394
8395 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8396
8397 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8398 from...
8399 (rank_one_type): ... this.
8400
8401 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
8402
8403 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8404 from...
8405 (rank_one_type): ... this.
8406
8407 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8408
8409 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8410 inferior-events' shows the example events.
8411
8412 2019-03-08 Eli Zaretskii <eliz@gnu.org>
8413
8414 Support styling on native MS-Windows console
8415
8416 PR/24315
8417 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8418 on MS-Windows if $TERM is not defined.
8419
8420 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8421
8422 * posix-hdep.c (gdb_console_fputs):
8423 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8424 functions.
8425 * ui-file.h (gdb_console_fputs): Add prototype.
8426
8427 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8428 back to fputs only if the former returns zero.
8429
8430 2019-03-07 Tom Tromey <tom@tromey.com>
8431
8432 * symmisc.c (print_symbol_bcache_statistics): Update.
8433 (print_objfile_statistics): Update.
8434 * symfile.c (allocate_symtab): Update.
8435 * stabsread.c: Don't include bcache.h.
8436 * psymtab.h (struct psymbol_bcache): Don't declare.
8437 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8438 (psymbol_bcache_init, psymbol_bcache_free)
8439 (psymbol_bcache_get_bcache): Don't declare.
8440 * psymtab.c (struct psymbol_bcache): Remove.
8441 (psymtab_storage::psymtab_storage): Update.
8442 (psymtab_storage::~psymtab_storage): Update.
8443 (psymbol_bcache_init, psymbol_bcache_free)
8444 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8445 (add_psymbol_to_bcache): Update.
8446 (allocate_psymtab): Update.
8447 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8448 macro_cache>: No longer pointers.
8449 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8450 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8451 * macrotab.c (macro_bcache): Update.
8452 * macroexp.c: Don't include bcache.h.
8453 * gdbtypes.c (check_types_worklist): Update.
8454 (types_deeply_equal): Remove TRY/CATCH. Update.
8455 * elfread.c (elf_symtab_read): Update.
8456 * dwarf2read.c: Don't include bcache.h.
8457 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8458 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8459 (print_bcache_statistics, bcache_memory_used): Don't declare.
8460 (struct bcache): Move from bcache.c. Add constructor, destructor,
8461 methods. Rename all data members.
8462 * bcache.c (struct bcache): Move to bcache.h.
8463 (bcache::expand_hash_table): Rename from expand_hash_table.
8464 (bcache): Remove.
8465 (bcache::insert): Rename from bcache_full.
8466 (bcache::compare): Rename from bcache_compare.
8467 (bcache_xmalloc): Remove.
8468 (bcache::~bcache): Rename from bcache_xfree.
8469 (bcache::print_statistics): Rename from print_bcache_statistics.
8470 (bcache::memory_used): Rename from bcache_memory_used.
8471
8472 2019-03-07 Pedro Alves <palves@redhat.com>
8473
8474 * infrun.c (normal_stop): Also check for
8475 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8476
8477 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8478
8479 * f-lang.c (value_from_host_double): Moved to...
8480 * value.c (value_from_host_double): ...here.
8481 * value.h (value_from_host_double): Declare.
8482 * guile/scm-math.c (vlscm_convert_typed_number): Use
8483 value_from_host_double.
8484 (vlscm_convert_number): Likewise.
8485 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8486 * python/py-value.c (convert_value_from_python): Likewise.
8487
8488 2019-03-06 Tom Tromey <tom@tromey.com>
8489
8490 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8491
8492 2019-03-06 Tom Tromey <tom@tromey.com>
8493
8494 * utils.h (free_current_contents): Don't declare.
8495 * utils.c (free_current_contents): Remove.
8496
8497 2019-03-06 Tom Tromey <tom@tromey.com>
8498
8499 * top.c (quit_force): Update.
8500 * main.c (captured_command_loop): Update.
8501 * common/new-op.c (operator new): Update.
8502 * common/common-exceptions.c (struct catcher)
8503 <save_cleanup_chain>: Remove member.
8504 (exceptions_state_mc_init): Update.
8505 (exception_try_scope_entry): Return nullptr.
8506 (exception_try_scope_exit, exception_rethrow)
8507 (throw_exception_sjlj, throw_exception_cxx): Update.
8508 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8509 (all_cleanups, do_cleanups, discard_cleanups)
8510 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8511 (restore_cleanups, restore_final_cleanups): Don't declare.
8512 (do_final_cleanups): Remove parameter.
8513 * common/cleanups.c (cleanup_chain, make_cleanup)
8514 (make_cleanup_dtor, all_cleanups, do_cleanups)
8515 (discard_my_cleanups, discard_cleanups)
8516 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8517 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8518 (null_cleanup): Remove.
8519 (do_final_cleanups): Remove parameter.
8520
8521 2019-03-06 Tom Tromey <tom@tromey.com>
8522
8523 * remote.c (remote_target::remote_parse_stop_reply): Use
8524 unique_xmalloc_ptr.
8525
8526 2019-03-06 Tom Tromey <tom@tromey.com>
8527
8528 * stabsread.c (struct stabs_field_info): Rename from field_info.
8529 <list, fnlist>: Add initializers.
8530 <obstack>: New member.
8531 (read_member_functions, read_struct_fields, read_baseclasses):
8532 Allocate on obstack. Don't use cleanups.
8533 (read_one_struct_field, read_member_functions, read_struct_fields)
8534 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8535 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8536 (read_struct_type): Update.
8537
8538 2019-03-06 Tom Tromey <tom@tromey.com>
8539
8540 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8541 * common/filestuff.h (make_cleanup_close): Don't declare.
8542 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8543 Remove.
8544
8545 2019-03-06 Tom Tromey <tom@tromey.com>
8546
8547 * solib-aix.c: Use make_scope_exit.
8548
8549 2019-03-06 Tom Tromey <tom@tromey.com>
8550
8551 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8552 Use make_scope_exit.
8553
8554 2019-03-06 Tom Tromey <tom@tromey.com>
8555
8556 * solib-svr4.c (disable_probes_interface): Remove parameter.
8557 (svr4_handle_solib_event): Use make_scope_exit.
8558
8559 2019-03-06 Tom Tromey <tom@tromey.com>
8560
8561 * remote.c (struct stop_reply_deleter): Remove.
8562 (stop_reply_up): Update.
8563 (struct stop_reply): Derive from notif_event. Don't typedef.
8564 <regcache>: Now a std::vector.
8565 (stop_reply_xfree): Remove.
8566 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8567 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8568 (remote_target::discard_pending_stop_replies): Use delete.
8569 (remote_target::remote_parse_stop_reply): Update.
8570 (remote_target::process_stop_reply): Update.
8571 * remote-notif.h (struct notif_event): Add virtual destructor.
8572 Remove "dtr" member.
8573 (struct notif_client) <alloc_event>: Return a unique_ptr.
8574 (notif_event_xfree): Don't declare.
8575 (notif_event_up): New typedef.
8576 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8577 (notif_event_xfree, do_notif_event_xfree): Remove.
8578 (remote_notif_state_xfree): Update.
8579
8580 2019-03-06 Tom Tromey <tom@tromey.com>
8581
8582 * infrun.c (displaced_step_clear_cleanup): Now a
8583 forward_scope_exit type.
8584 (displaced_step_prepare_throw): Update.
8585 (displaced_step_fixup): Update.
8586
8587 2019-03-06 Tom Tromey <tom@tromey.com>
8588
8589 * inferior.h (class inferior): Update comment.
8590 * gdbthread.h (class thread_info): Update comment.
8591
8592 2019-03-06 Joel Brobecker <brobecker@adacore.com>
8593 Tom Tromey <tom@tromey.com>
8594
8595 * stabsread.h (struct stab_section_list): Remove.
8596 (coffstab_build_psymtabs): Update.
8597 * dbxread.c (symbuf_sections): Now a std::vector.
8598 (sect_idx): New global.
8599 (fill_symbuf): Update.
8600 (coffstab_build_psymtabs): Change type of stabsects parameter.
8601 Update.
8602 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8603 std::vector.
8604 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8605 (coff_locate_sections): Update.
8606 (coff_symfile_read): Remove cleanups. Update.
8607 (init_stringtab): Add storage parameter.
8608 (free_stringtab, free_stringtab_cleanup): Remove.
8609 (init_lineno): Add storage parameter.
8610 (free_linetab, free_linetab_cleanup): Remove.
8611
8612 2019-03-06 Pedro Alves <palves@redhat.com>
8613
8614 * linux-fork.c (fork_info::clobber_regs): Delete.
8615 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8616 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
8617 comment. Adjust.
8618 (scoped_switch_fork_info::scoped_switch_fork_info)
8619 (checkpoint_command, linux_fork_context): Adjust
8620 fork_save_infrun_state calls.
8621
8622 2019-03-06 Pedro Alves <palves@redhat.com>
8623
8624 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8625 (inf_has_multiple_threads): Return 'bool' and rewrite using
8626 inferior_info::threads().
8627
8628 2019-03-06 Pedro Alves <palves@redhat.com>
8629
8630 * linux-fork.c: Include <list>.
8631 (fork_list): Now a std::list instance.
8632 (fork_info): Add ctor, dtor, and in-class initialize all fields.
8633 (forks_exist_p, find_last_fork): Adjust.
8634 (new_fork): Delete.
8635 (one_fork_p): New.
8636 (add_fork): Adjust.
8637 (free_fork): Delete, folded into fork_info::~fork_info().
8638 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8639 Adjust.
8640 (init_fork_list): Delete.
8641 (linux_fork_killall, linux_fork_mourn_inferior)
8642 (linux_fork_detach, info_checkpoints_command): Adjust.
8643 (_initialize_linux_fork): No longer call init_fork_list.
8644
8645 2019-03-06 Pedro Alves <palves@redhat.com>
8646
8647 * linux-fork.c (new_fork): New, split out of ...
8648 (add_fork): ... this. Return void. Move "first fork" special
8649 case from here, to ...
8650 (checkpoint_command): ... here.
8651 * linux-linux.h (add_fork): Return void.
8652
8653 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8654
8655 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8656
8657 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8658 Chris January <chris.january@arm.com>
8659 David Lecomber <david.lecomber@arm.com>
8660
8661 * f-exp.y: New token, UNOP_INTRINSIC.
8662 (exp): New pattern using UNOP_INTRINSIC token.
8663 (f77_keywords): Add 'abs' keyword.
8664 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8665 (value_from_host_double): New function.
8666 (evaluate_subexp_f): Support UNOP_ABS.
8667
8668 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8669
8670 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8671 types.
8672
8673 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8674
8675 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8676 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8677 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8678
8679 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8680
8681 * f-exp.y (convert_to_kind_type): Handle more type kinds.
8682
8683 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8684 Chris January <chris.january@arm.com>
8685
8686 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8687 * f-exp.y: Define 'KIND' token.
8688 (exp): New pattern for KIND expressions.
8689 (ptype): Handle types with a kind extension.
8690 (direct_abs_decl): Extend to spot kind extensions.
8691 (f77_keywords): Add 'kind' to the list.
8692 (push_kind_type): New function.
8693 (convert_to_kind_type): New function.
8694 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8695 * parse.c (operator_length_standard): Likewise.
8696 * parser-defs.h (enum type_pieces): Add tp_kind.
8697 * std-operator.def: Add UNOP_KIND.
8698
8699 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8700
8701 * f-exp.y (f_parse): Set yydebug.
8702
8703 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8704
8705 * f-lang.c (evaluate_subexp_f): New function.
8706 (exp_descriptor_f): New global.
8707 (f_language_defn): Use exp_descriptor_f instead of
8708 exp_descriptor_standard.
8709
8710 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8711
8712 * f-exp.y (struct token): Add comments.
8713 (dot_ops): Remove uppercase versions and the end marker.
8714 (f77_keywords): Likewise.
8715 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8716 entries in the dot_ops array are case insensitive, and use
8717 strncasecmp to compare strings. Also some whitespace cleanup in
8718 this area. Similar for the f77_keywords array, except entries in
8719 this list might be case sensitive.
8720
8721 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
8722
8723 * f-exp.y (struct f77_boolean_val): Add comments.
8724 (boolean_values): Remove uppercase versions, and end marker.
8725 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8726 and use strncasecmp to achieve case insensitivity. Additionally,
8727 perform whitespace cleanup around this code.
8728
8729 2019-03-06 Tom Tromey <tromey@adacore.com>
8730
8731 * remote-sim.c (gdbsim_target_open): Use result of
8732 gdb_argv::release.
8733
8734 2019-03-06 Richard Bunt <richard.bunt@arm.com>
8735 Dirk Schubert <dirk.schubert@arm.com>
8736 Chris January <chris.january@arm.com>
8737
8738 * eval.c (evaluate_subexp_standard): Call Fortran argument
8739 wrapping logic.
8740 * f-lang.c (struct value): A value which can be passed into a
8741 Fortran function call.
8742 (fortran_argument_convert): Wrap Fortran arguments in a pointer
8743 where appropriate.
8744 (struct type): Value ready for a Fortran function call.
8745 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8746 is needed.
8747 * f-lang.h (fortran_argument_convert): Declaration.
8748 (fortran_preserve_arg_pointer): Declaration.
8749 * infcall.c (value_arg_coerce): Call Fortran argument logic.
8750
8751 2019-03-05 Tom Tromey <tromey@adacore.com>
8752
8753 * python/py-prettyprint.c (print_string_repr): Remove #if.
8754 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8755
8756 2019-03-05 Tom Tromey <tromey@adacore.com>
8757
8758 * target.c (the_dummy_target): Move later. Change type to
8759 "dummy_target".
8760 (initialize_targets): Don't initialize the_dummy_target.
8761
8762 2019-03-05 Tom Tromey <tromey@adacore.com>
8763
8764 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8765 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8766
8767 2019-03-05 Tom Tromey <tromey@adacore.com>
8768
8769 * windows-nat.c (windows_nat_target::attach)
8770 (windows_nat_target::detach): Don't call gdb_flush.
8771 * valprint.c (generic_val_print, val_print, val_print_string):
8772 Don't call gdb_flush.
8773 * utils.c (defaulted_query): Don't call gdb_flush.
8774 * typeprint.c (print_type_scalar): Don't call gdb_flush.
8775 * target.c (target_announce_detach): Don't call gdb_flush.
8776 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8777 * remote.c (extended_remote_target::attach): Don't call
8778 gdb_flush.
8779 * procfs.c (procfs_target::detach): Don't call gdb_flush.
8780 * printcmd.c (do_examine): Don't call gdb_flush.
8781 (info_display_command): Don't call gdb_flush.
8782 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8783 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8784 * memattr.c (info_mem_command): Don't call gdb_flush.
8785 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8786 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8787 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8788 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8789 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8790 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8791 (gnu_nat_target::detach): Don't call gdb_flush.
8792 * f-valprint.c (f_val_print): Don't call gdb_flush.
8793 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8794 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8795 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8796 gdb_flush.
8797 * c-valprint.c (c_val_print): Don't call gdb_flush.
8798 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8799
8800 2019-03-05 Tom Tromey <tromey@adacore.com>
8801
8802 * varobj.c (update_dynamic_varobj_children): Update.
8803 (install_default_visualizer): Use reset, not release.
8804 * value.c (set_internalvar): Update.
8805 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8806 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8807 ATTRIBUTE_UNUSED_RESULT.
8808
8809 2019-03-05 Tom Tromey <tromey@adacore.com>
8810
8811 * remote.c (class scoped_remote_fd) <release>: Add
8812 ATTRIBUTE_UNUSED_RESULT.
8813
8814 2019-03-05 Tom Tromey <tromey@adacore.com>
8815
8816 * macroexp.c (struct macro_buffer) <release>: Add
8817 ATTRIBUTE_UNUSED_RESULT.
8818
8819 2019-03-05 Tom Tromey <tromey@adacore.com>
8820
8821 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8822 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8823 ATTRIBUTE_UNUSED_RESULT.
8824
8825 2019-03-05 Tom Tromey <tromey@adacore.com>
8826
8827 * common/scoped_fd.h (class scoped_fd) <release>: Add
8828 ATTRIBUTE_UNUSED_RESULT.
8829
8830 2019-03-05 Tom Tromey <tromey@adacore.com>
8831
8832 * parser-defs.h (struct parser_state) <release>: Add
8833 ATTRIBUTE_UNUSED_RESULT.
8834
8835 2019-03-05 Tom Tromey <tromey@adacore.com>
8836
8837 * utils.h (class gdb_argv) <release>: Add
8838 ATTRIBUTE_UNUSED_RESULT.
8839 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8840
8841 2019-03-02 Eli Zaretskii <eliz@gnu.org>
8842
8843 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8844 for-loop range, to avoid compiler warnings.
8845
8846 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8847 avoid compiler warnings about unused variables.
8848
8849 * NEWS: Mention end of support for native debugging on MS-Windows
8850 before XP.
8851
8852 PR gdb/24292
8853 * common/netstuff.c:
8854 * gdbserver/gdbreplay.c
8855 * gdbserver/remote-utils.c:
8856 * ser-tcp.c:
8857 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8858 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
8859 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8860 'getaddrinfo' and 'freeaddrinfo' were not available before
8861 Windows XP, and mingw.org's MinGW headers by default define
8862 _WIN32_WINNT to 0x500.
8863
8864 2019-03-01 Gary Benson <gbenson@redhat.com>
8865
8866 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8867
8868 2019-02-28 Brian Vandenberg <phantall@gmail.com>
8869 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
8870
8871 PR gdb/8527
8872 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8873 set_sigint_trap, clear_sigint_trap.
8874
8875 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8876
8877 * target.c (target_detach): Clear the regcache and the
8878 frame cache.
8879
8880 2019-02-27 Pedro Alves <palves@redhat.com>
8881
8882 * utils.c (set_screen_size): When we cap the height/width sizes,
8883 tweak the corresponding command variable to show "unlimited":
8884
8885 2019-02-27 Saagar Jha <saagar@saagarjha.com>
8886 Pedro Alves <palves@redhat.com>
8887
8888 * utils.c (set_screen_size): Reduce "infinite" rows and columns
8889 before calling rl_set_screen_size.
8890
8891 2019-02-27 Tom Tromey <tromey@adacore.com>
8892
8893 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8894 define.
8895 * python/py-value.c: Remove Python 2.4 workaround.
8896 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8897 workaround.
8898 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8899 Python 2.4 workaround.
8900 * python/python-internal.h: Remove Python 2.4 comment.
8901 (Py_ssize_t): Don't define.
8902 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8903 (gdb_Py_DECREF): Remove Python 2.4 workaround.
8904 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8905 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8906 * python/python.c (do_start_initialization): Remove Python 2.4
8907 workaround.
8908 * python/py-prettyprint.c (class dummy_python_frame): Remove.
8909 (print_children): Remove Python 2.4 workaround.
8910 * python/py-inferior.c (buffer_procs): Remove Python 2.4
8911 workaround.
8912 (CHARBUFFERPROC_NAME): Remove.
8913 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8914 Python 2.4 workaround.
8915
8916 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8917
8918 * NEWS: Note minimum Python version.
8919
8920 2019-02-27 Kevin Buettner <kevinb@redhat.com>
8921
8922 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8923 code from these functions. Remove corresponding ifdefs. Use
8924 Py_buffer_up instead of explicit calls to PyBuffer_Release.
8925 Remove gotos and target of gotos.
8926 (infpy_search_memory): Likewise.
8927
8928 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8929
8930 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8931 (hppa_gdbarch_init): Don't register deleted functions with
8932 gdbarch.
8933
8934 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8935
8936 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8937 (h8300_unwind_sp): Delete.
8938 (h8300_dummy_id): Delete.
8939 (h8300_gdbarch_init): Don't register deleted functions with
8940 gdbarch.
8941
8942 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8943
8944 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8945 (ft32_unwind_pc): Delete.
8946 (ft32_unwind_sp): Delete.
8947 (ft32_gdbarch_init): Don't register deleted functions with
8948 gdbarch.
8949
8950 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8951
8952 * gdb/frv-tdep.c (frv_dummy_id): Delete.
8953 (frv_unwind_pc): Delete.
8954 (frv_unwind_sp): Delete.
8955 (frv_gdbarch_init): Don't register deleted functions with
8956 gdbarch.
8957
8958 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8959
8960 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8961 (riscv_unwind_pc): Delete.
8962 (riscv_unwind_sp): Delete.
8963 (riscv_gdbarch_init): Don't register deleted functions with
8964 gdbarch.
8965
8966 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8967
8968 * gdb/csky-tdep.c (csky_dummy_id): Delete.
8969 (csky_unwind_pc): Delete.
8970 (csky_unwind_sp): Delete.
8971 (csky_gdbarch_init): Don't register deleted functions with
8972 gdbarch.
8973
8974 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8975
8976 * gdb/cris-tdep.c (cris_dummy_id): Delete.
8977 (cris_unwind_pc): Delete.
8978 (cris_unwind_sp): Delete.
8979 (cris_gdbarch_init): Don't register deleted functions with
8980 gdbarch.
8981
8982 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8983
8984 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8985 (bfin_unwind_pc): Delete.
8986 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8987
8988 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8989
8990 * gdb/arm-tdep.c (arm_dummy_id): Delete.
8991 (arm_unwind_pc): Delete.
8992 (arm_unwind_sp): Delete.
8993 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8994
8995 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
8996
8997 * gdb/arc-tdep.c (arc_dummy_id): Delete.
8998 (arc_unwind_pc): Delete.
8999 (arc_unwind_sp): Delete.
9000 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9001
9002 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9003
9004 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9005 (alpha_unwind_pc): Delete.
9006 (alpha_gdbarch_init): Don't register deleted functions with
9007 gdbarch.
9008
9009 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9010
9011 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9012 (aarch64_unwind_pc): Delete.
9013 (aarch64_unwind_sp): Delete.
9014 (aarch64_gdbarch_init): Don't register deleted functions with
9015 gdbarch.
9016
9017 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9018
9019 * gdbtypes.c (type_align): Don't consider static members when
9020 computing structure alignment.
9021
9022 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9023
9024 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9025 return 0 for other types.
9026 * arch-utils.c (default_type_align): Always return 0.
9027 * gdbarch.h: Regenerate.
9028 * gdbarch.sh (type_align): Extend comment.
9029 * gdbtypes.c (type_align): Add additional comments, always call
9030 gdbarch_type_align before applying the default rules.
9031 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9032 generic code will then apply a suitable default.
9033 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9034 types, return 0 for other types.
9035
9036 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9037
9038 * NEWS: Create a new section for the next release branch.
9039 Rename the section of the current branch, now that it has
9040 been cut.
9041
9042 2019-02-27 Joel Brobecker <brobecker@adacore.com>
9043
9044 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9045 * version.in: Bump version to 8.3.50.DATE-git.
9046
9047 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
9048
9049 * aix-thread.c (ptid_cmp): Remove unused variable.
9050 (get_signaled_thread): Likewise.
9051 (store_regs_user_thread): Likewise.
9052 (store_regs_kernel_thread): Likewise.
9053 (fetch_regs_kernel_thread): Remove shadowed variable.
9054
9055 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9056
9057 * features/riscv/32bit-cpu.xml: Add register numbers.
9058 * features/riscv/32bit-fpu.c: Regenerate.
9059 * features/riscv/32bit-fpu.xml: Add register numbers.
9060 * features/riscv/64bit-cpu.xml: Add register numbers.
9061 * features/riscv/64bit-fpu.c: Regenerate.
9062 * features/riscv/64bit-fpu.xml: Add register numbers.
9063
9064 2019-02-26 Kevin Buettner <kevinb@redhat.com>
9065
9066 * NEWS: Mention two argument form of gdb.Value constructor.
9067 * python/py-value.c (convert_buffer_and_type_to_value): New
9068 function.
9069 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9070 Add support for handling an optional second argument. Call
9071 convert_buffer_and_type_to_value as appropriate.
9072 * python/python-internal.h (Py_buffer_deleter): New struct.
9073 (Py_buffer_up): New typedef.
9074
9075 2019-02-25 John Baldwin <jhb@FreeBSD.org>
9076
9077 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9078 instead of releasing ownership.
9079
9080 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
9081
9082 * dwarf2read.c (open_and_init_dwp_file): Call
9083 elf_numsections instead of bfd_count_sections to initialize
9084 dwp_file->num_sections.
9085
9086 2019-02-25 Tom Tromey <tromey@adacore.com>
9087
9088 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9089
9090 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9091
9092 * gcore.in: Add '--readnever' option when invoking GDB.
9093
9094 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9095
9096 * MAINTAINERS: Update my email address.
9097
9098 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9099
9100 * build-id.c (build_id_to_debug_bfd_1): New function.
9101 (build_id_to_debug_bfd): Look for separate debug file in
9102 sysroot.
9103
9104 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9105
9106 * gdbarch.sh: Update the copyright year range that is placed into
9107 generated files.
9108
9109 2019-02-22 Keith Seitz <keiths@redhat.com>
9110
9111 PR symtab/23853
9112 * linespec.c (create_sals_line_offset): Search for the default
9113 symtab's filename instead of its fullname.
9114
9115 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9116
9117 * NEWS: Update style defaults.
9118
9119 2019-02-21 Alan Hayward <alan.hayward@arm.com>
9120
9121 * main.c (captured_main_1): Disable styling in batch mode.
9122
9123 2019-02-20 Tom Tromey <tom@tromey.com>
9124
9125 * symtab.c (symtab_symbol_info): Fix typos.
9126
9127 2019-02-20 Tom Tromey <tromey@adacore.com>
9128
9129 * findcmd.c (_initialize_mem_search): Use upper case for
9130 metasyntactic variables.
9131
9132 2019-02-20 Alan Hayward <alan.hayward@arm.com>
9133
9134 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9135 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9136
9137 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9138
9139 * top.h (source_file_name): Change to std::string.
9140 * top.c (source_file_name): Likewise.
9141 (command_line_input): Adjust.
9142 * cli/cli-script.c (script_from_file): Adjust.
9143
9144 2019-02-19 Tom Tromey <tromey@adacore.com>
9145
9146 * ravenscar-thread.c
9147 (ravenscar_thread_target::update_thread_list): Don't call
9148 ada_build_task_list.
9149 * ada-lang.h (ada_build_task_list): Don't declare.
9150 * ada-tasks.c (struct ada_tasks_inferior_data)
9151 <task_list_valid_p>: Now bool.
9152 (read_known_tasks, ada_task_list_changed)
9153 (ada_tasks_invalidate_inferior_data): Update.
9154 (read_known_tasks_array): Return bool.
9155 (read_known_tasks_list): Likewise.
9156 (read_known_tasks): Return void.
9157 (ada_build_task_list): Now static.
9158
9159 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9160
9161 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9162 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9163
9164 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9165
9166 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9167 variant for ada_tasks_pspace_data_handle and
9168 ada_tasks_inferior_data_handle.
9169 (ada_tasks_pspace_data_cleanup): New function.
9170 (ada_tasks_inferior_data_cleanup): New function.
9171
9172 2019-02-17 Tom Tromey <tom@tromey.com>
9173
9174 * macrotab.h (macro_source_fullname): Return a std::string.
9175 * macrotab.c (macro_include, check_for_redefinition)
9176 (macro_undef, macro_lookup_definition, foreach_macro)
9177 (foreach_macro_in_scope): Update.
9178 (macro_source_fullname): Return a std::string.
9179 * macrocmd.c (show_pp_source_pos): Update.
9180
9181 2019-02-17 Tom Tromey <tom@tromey.com>
9182
9183 * macrocmd.c (show_pp_source_pos): Style the file names.
9184
9185 2019-02-17 Tom Tromey <tom@tromey.com>
9186
9187 PR tui/24197:
9188 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9189
9190 2019-02-17 Tom Tromey <tom@tromey.com>
9191
9192 * ada-lang.c (user_select_syms): Use filtered printing.
9193 * utils.c (wrap_style): New global.
9194 (desired_style): Remove.
9195 (emit_style_escape): Add stream parameter.
9196 (set_output_style, reset_terminal_style, prompt_for_continue):
9197 Update.
9198 (flush_wrap_buffer): Only flush gdb_stdout.
9199 (wrap_here): Set wrap_style.
9200 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9201 treat escape sequences as a character. Change when wrap buffer is
9202 flushed.
9203 (fputs_styled): Do not set the output style when the default is
9204 requested.
9205 * ui-style.h (struct ui_file_style) <is_default>: New method.
9206 * source.c (print_source_lines_base): Emit escape sequences in one
9207 piece.
9208
9209 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9210
9211 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9212 integers and enumeration types.
9213
9214 2019-02-17 Joel Brobecker <brobecker@adacore.com>
9215
9216 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9217 instead of lookup_symbol_in_language
9218 (do_exact_match): New function.
9219 (ada_get_symbol_name_matcher): Return do_exact_match when
9220 doing a verbatim match.
9221
9222 2019-02-15 Tom Tromey <tromey@adacore.com>
9223
9224 * ravenscar-thread.c (ravenscar_thread_target::resume)
9225 (ravenscar_thread_target::wait): Special case wildcard requests.
9226
9227 2019-02-15 Tom Tromey <tromey@adacore.com>
9228
9229 * ravenscar-thread.c (base_ptid): Remove.
9230 (struct ravenscar_thread_target) <close>: New method.
9231 <m_base_ptid>: New member.
9232 <update_inferior_ptid, active_task, task_is_currently_active,
9233 runtime_initialized>: Declare methods.
9234 <ravenscar_thread_target>: Add constructor.
9235 (ravenscar_thread_target::task_is_currently_active)
9236 (ravenscar_thread_target::update_inferior_ptid)
9237 (ravenscar_runtime_initialized): Rename. Now methods.
9238 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9239 (ravenscar_thread_target::update_thread_list): Update.
9240 (ravenscar_thread_target::active_task): Now method.
9241 (ravenscar_thread_target::store_registers)
9242 (ravenscar_thread_target::prepare_to_store)
9243 (ravenscar_thread_target::prepare_to_store)
9244 (ravenscar_thread_target::mourn_inferior): Update.
9245 (ravenscar_inferior_created): Use "new" to create target.
9246 (ravenscar_thread_target::get_ada_task_ptid): Update.
9247 (_initialize_ravenscar): Don't initialize base_ptid.
9248 (ravenscar_ops): Remove global.
9249
9250 2019-02-15 Tom Tromey <tromey@adacore.com>
9251
9252 * target.h (push_target): Declare new overload.
9253 * target.c (push_target): New overload, taking an rvalue reference.
9254 * remote.c (remote_target::open_1): Use push_target overload.
9255 * corelow.c (core_target_open): Use push_target overload.
9256
9257 2019-02-15 Tom Tromey <tromey@adacore.com>
9258
9259 * ravenscar-thread.c (is_ravenscar_task)
9260 (ravenscar_task_is_currently_active): Return bool.
9261 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9262 (_initialize_ravenscar): Remove "(void)".
9263 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9264 Return bool.
9265
9266 2019-02-15 Tom Tromey <tromey@adacore.com>
9267
9268 * ravenscar-thread.c (ravenscar_runtime_initializer)
9269 (has_ravenscar_runtime, get_running_thread_id)
9270 (ravenscar_thread_target::resume): Fix indentation.
9271
9272 2019-02-15 Tom Tromey <tromey@adacore.com>
9273
9274 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9275 from ravenscar_arch_ops.
9276 (sparc_ravenscar_ops::fetch_registers)
9277 (sparc_ravenscar_ops::store_registers): Now methods.
9278 (sparc_ravenscar_prepare_to_store): Remove.
9279 (sparc_ravenscar_ops): Redefine.
9280 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9281 methods and destructor. Remove members.
9282 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9283 (ravenscar_thread_target::store_registers)
9284 (ravenscar_thread_target::prepare_to_store): Update.
9285 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9286 Remove.
9287 (struct ppc_ravenscar_powerpc_ops): Derive from
9288 ravenscar_arch_ops.
9289 (ppc_ravenscar_powerpc_ops::fetch_registers)
9290 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9291 (ppc_ravenscar_powerpc_ops): Redefine.
9292 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9293 (ppc_ravenscar_e500_ops::fetch_registers)
9294 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9295 (ppc_ravenscar_e500_ops): Redefine.
9296 * aarch64-ravenscar-thread.c
9297 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9298 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9299 (aarch64_ravenscar_fetch_registers)
9300 (aarch64_ravenscar_store_registers): Now methods.
9301 (aarch64_ravenscar_ops): Redefine.
9302
9303 2019-02-15 Tom Tromey <tromey@adacore.com>
9304
9305 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9306 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9307 (ravenscar_thread_target::stopped_by_watchpoint)
9308 (ravenscar_thread_target::stopped_data_address)
9309 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9310
9311 2019-02-15 Tom Tromey <tromey@adacore.com>
9312
9313 * ravenscar-thread.c: Fix some typos.
9314
9315 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9316 Tom Tromey <tromey@adacore.com>
9317
9318 * ada-lang.c (ada_exception_sal): Change addr_string to a
9319 std::string.
9320 (create_ada_exception_catchpoint): Update.
9321
9322 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9323 Tom Tromey <tromey@adacore.com>
9324
9325 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9326 (bp_location_ops): Remove.
9327 (base_breakpoint_allocate_location): Update.
9328 (free_bp_location): Update.
9329 * ada-lang.c (class ada_catchpoint_location)
9330 <ada_catchpoint_location>: Remove ops parameter.
9331 (ada_catchpoint_location_dtor): Remove.
9332 (ada_catchpoint_location_ops): Remove.
9333 (allocate_location_exception): Update.
9334 * breakpoint.h (struct bp_location_ops): Remove.
9335 (class bp_location) <bp_location>: Remove bp_location_ops
9336 parameter.
9337 <~bp_location>: Add destructor.
9338 <ops>: Remove.
9339
9340 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9341 Pedro Alves <palves@redhat.com>
9342
9343 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9344 'PATH_MAX'.
9345
9346 2019-02-14 David Michael <fedora.dm0@gmail.com>
9347 Samuel Thibault <samuel.thibault@gnu.org>
9348 Thomas Schwinge <thomas@codesourcery.com>
9349
9350 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9351 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9352
9353 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9354
9355 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9356 (check_empty): Use "const char *".
9357
9358 * gnu-nat.c (gnu_nat_target::detach): Instead of
9359 'detach_inferior (pid)' call
9360 'detach_inferior (find_inferior_pid (pid))'.
9361
9362 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9363 'nat/fork-inferior.o'.
9364 * gnu-nat.c: #include "nat/fork-inferior.h".
9365
9366 * gnu-nat.c (gnu_nat_target::detach): Instead of
9367 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9368 * gnu-nat.h: #include "inf-child.h".
9369 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9370 'i386_gnu_nat_target::fetch_registers'.
9371 (gnu_store_registers): Rename/move to
9372 'i386_gnu_nat_target::store_registers'.
9373
9374 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9375 * gnu-nat.h (mach_thread_info): New function.
9376 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9377
9378 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9379
9380 2019-02-14 Frederic Konrad <konrad@adacore.com>
9381
9382 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9383
9384 2019-02-14 Joel Brobecker <brobecker@adacore.com>
9385
9386 * windows-nat.c (windows_add_thread): Add new parameter
9387 "main_thread_p" with default value set to false. Update
9388 function documentation as well as all callers.
9389 (windows_delete_thread): Likewise.
9390 (fake_create_process): Update call to windows_add_thread.
9391 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9392 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9393 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9394 call to windows_delete_thread.
9395
9396 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9397
9398 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9399
9400 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9401
9402 * symfile.c (find_separate_debug_file): Use canonical path of
9403 sysroot with child_path instead of gdb_sysroot if it is valid.
9404
9405 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9406
9407 * symfile.c (find_separate_debug_file): Use child_path to
9408 determine if an object file is under a sysroot.
9409
9410 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9411
9412 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9413 unittests/child-path-selftests.c.
9414 * common/pathstuff.c (child_path): New function.
9415 * common/pathstuff.h (child_path): New prototype.
9416 * unittests/child-path-selftests.c: New file.
9417
9418 2019-02-12 John Baldwin <jhb@FreeBSD.org>
9419
9420 * symfile.c (find_separate_debug_file): Look for separate debug
9421 files in debug directories under the sysroot.
9422
9423 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9424
9425 * symtab.h (struct minimal_symbol data_p): New const method.
9426 (struct minimal_symbol text_p): Likewise.
9427 * symtab.c (output_source_filename): Use file name style
9428 to print file name.
9429 (print_symbol_info): Likewise.
9430 (print_msymbol_info): Use address style to print addresses.
9431 Use function name style to print executable text symbols.
9432 (expand_symtab_containing_pc): Use data_p.
9433 (find_pc_sect_compunit_symtab): Likewise.
9434
9435 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9436
9437 * breakpoint.c (describe_other_breakpoints): Use address style
9438 to print addresses.
9439 (say_where): Likewise.
9440
9441 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9442
9443 * ada-typeprint.c (print_func_type): Print function name
9444 style to print function name.
9445 * c-typeprint.c (c_print_type_1): Likewise.
9446
9447 2019-02-11 Alan Hayward <alan.hayward@arm.com>
9448
9449 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9450 for execve.
9451
9452 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9453
9454 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9455 type_stack.
9456
9457 2019-02-10 Joel Brobecker <brobecker@adacore.com>
9458
9459 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9460 TYPE_CODE_REF types.
9461
9462 2019-02-08 Jim Wilson <jimw@sifive.com>
9463
9464 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9465 (riscv_linux_fregset): New.
9466 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9467
9468 2019-02-07 Tom Tromey <tom@tromey.com>
9469
9470 * thread.c (thread_cancel_execution_command): Update.
9471 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9472 methods.
9473 (struct thread_fsm_ops): Remove.
9474 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9475 (thread_fsm_should_stop, thread_fsm_return_value)
9476 (thread_fsm_set_finished, thread_fsm_finished_p)
9477 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9478 Don't declare.
9479 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9480 * infrun.c (clear_proceed_status_thread)
9481 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9482 (print_stop_event): Update.
9483 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9484 Add constructor.
9485 (step_command_fsm_ops): Remove.
9486 (new_step_command_fsm): Remove.
9487 (step_1): Update.
9488 (step_command_fsm::should_stop): Rename from
9489 step_command_fsm_should_stop.
9490 (step_command_fsm::clean_up): Rename from
9491 step_command_fsm_clean_up.
9492 (step_command_fsm::do_async_reply_reason): Rename from
9493 step_command_fsm_async_reply_reason.
9494 (struct until_next_fsm): Inherit from thread_fsm. Add
9495 constructor.
9496 (until_next_fsm_ops): Remove.
9497 (new_until_next_fsm): Remove.
9498 (until_next_fsm::should_stop): Rename from
9499 until_next_fsm_should_stop.
9500 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9501 (until_next_fsm::do_async_reply_reason): Rename from
9502 until_next_fsm_async_reply_reason.
9503 (struct finish_command_fsm): Inherit from thread_fsm. Add
9504 constructor. Change type of breakpoint.
9505 (finish_command_fsm_ops): Remove.
9506 (new_finish_command_fsm): Remove.
9507 (finish_command_fsm::should_stop): Rename from
9508 finish_command_fsm_should_stop.
9509 (finish_command_fsm::clean_up): Rename from
9510 finish_command_fsm_clean_up.
9511 (finish_command_fsm::return_value): Rename from
9512 finish_command_fsm_return_value.
9513 (finish_command_fsm::do_async_reply_reason): Rename from
9514 finish_command_fsm_async_reply_reason.
9515 (finish_command): Update.
9516 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9517 Add constructor.
9518 (call_thread_fsm_ops): Remove.
9519 (call_thread_fsm::call_thread_fsm): Rename from
9520 new_call_thread_fsm.
9521 (call_thread_fsm::should_stop): Rename from
9522 call_thread_fsm_should_stop.
9523 (call_thread_fsm::should_notify_stop): Rename from
9524 call_thread_fsm_should_notify_stop.
9525 (run_inferior_call, call_function_by_hand_dummy): Update.
9526 * cli/cli-interp.c (should_print_stop_to_console): Update.
9527 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9528 Add constructor. Change type of location_breakpoint,
9529 caller_breakpoint.
9530 (until_break_fsm_ops): Remove.
9531 (new_until_break_fsm): Remove.
9532 (until_break_fsm::should_stop): Rename from
9533 until_break_fsm_should_stop.
9534 (until_break_fsm::clean_up): Rename from
9535 until_break_fsm_clean_up.
9536 (until_break_fsm::do_async_reply_reason): Rename from
9537 until_break_fsm_async_reply_reason.
9538 (until_break_command): Update.
9539 * thread-fsm.c: Remove.
9540 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9541
9542 2019-02-07 Tom Tromey <tom@tromey.com>
9543
9544 * yy-remap.h: Add include guard.
9545 * xtensa-tdep.h: Add include guard.
9546 * xcoffread.h: Rename include guard.
9547 * varobj-iter.h: Add include guard.
9548 * tui/tui.h: Rename include guard.
9549 * tui/tui-winsource.h: Rename include guard.
9550 * tui/tui-wingeneral.h: Rename include guard.
9551 * tui/tui-windata.h: Rename include guard.
9552 * tui/tui-win.h: Rename include guard.
9553 * tui/tui-stack.h: Rename include guard.
9554 * tui/tui-source.h: Rename include guard.
9555 * tui/tui-regs.h: Rename include guard.
9556 * tui/tui-out.h: Rename include guard.
9557 * tui/tui-layout.h: Rename include guard.
9558 * tui/tui-io.h: Rename include guard.
9559 * tui/tui-hooks.h: Rename include guard.
9560 * tui/tui-file.h: Rename include guard.
9561 * tui/tui-disasm.h: Rename include guard.
9562 * tui/tui-data.h: Rename include guard.
9563 * tui/tui-command.h: Rename include guard.
9564 * tic6x-tdep.h: Add include guard.
9565 * target/waitstatus.h: Rename include guard.
9566 * target/wait.h: Rename include guard.
9567 * target/target.h: Rename include guard.
9568 * target/resume.h: Rename include guard.
9569 * target-float.h: Rename include guard.
9570 * stabsread.h: Add include guard.
9571 * rs6000-tdep.h: Add include guard.
9572 * riscv-fbsd-tdep.h: Add include guard.
9573 * regformats/regdef.h: Rename include guard.
9574 * record.h: Rename include guard.
9575 * python/python.h: Rename include guard.
9576 * python/python-internal.h: Rename include guard.
9577 * python/py-stopevent.h: Rename include guard.
9578 * python/py-ref.h: Rename include guard.
9579 * python/py-record.h: Rename include guard.
9580 * python/py-record-full.h: Rename include guard.
9581 * python/py-record-btrace.h: Rename include guard.
9582 * python/py-instruction.h: Rename include guard.
9583 * python/py-events.h: Rename include guard.
9584 * python/py-event.h: Rename include guard.
9585 * procfs.h: Add include guard.
9586 * proc-utils.h: Add include guard.
9587 * p-lang.h: Add include guard.
9588 * or1k-tdep.h: Rename include guard.
9589 * observable.h: Rename include guard.
9590 * nto-tdep.h: Rename include guard.
9591 * nat/x86-linux.h: Rename include guard.
9592 * nat/x86-linux-dregs.h: Rename include guard.
9593 * nat/x86-gcc-cpuid.h: Add include guard.
9594 * nat/x86-dregs.h: Rename include guard.
9595 * nat/x86-cpuid.h: Rename include guard.
9596 * nat/ppc-linux.h: Rename include guard.
9597 * nat/mips-linux-watch.h: Rename include guard.
9598 * nat/linux-waitpid.h: Rename include guard.
9599 * nat/linux-ptrace.h: Rename include guard.
9600 * nat/linux-procfs.h: Rename include guard.
9601 * nat/linux-osdata.h: Rename include guard.
9602 * nat/linux-nat.h: Rename include guard.
9603 * nat/linux-namespaces.h: Rename include guard.
9604 * nat/linux-btrace.h: Rename include guard.
9605 * nat/glibc_thread_db.h: Rename include guard.
9606 * nat/gdb_thread_db.h: Rename include guard.
9607 * nat/gdb_ptrace.h: Rename include guard.
9608 * nat/fork-inferior.h: Rename include guard.
9609 * nat/amd64-linux-siginfo.h: Rename include guard.
9610 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9611 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9612 * nat/aarch64-linux.h: Rename include guard.
9613 * nat/aarch64-linux-hw-point.h: Rename include guard.
9614 * mn10300-tdep.h: Add include guard.
9615 * mips-linux-tdep.h: Add include guard.
9616 * mi/mi-parse.h: Rename include guard.
9617 * mi/mi-out.h: Rename include guard.
9618 * mi/mi-main.h: Rename include guard.
9619 * mi/mi-interp.h: Rename include guard.
9620 * mi/mi-getopt.h: Rename include guard.
9621 * mi/mi-console.h: Rename include guard.
9622 * mi/mi-common.h: Rename include guard.
9623 * mi/mi-cmds.h: Rename include guard.
9624 * mi/mi-cmd-break.h: Rename include guard.
9625 * m2-lang.h: Add include guard.
9626 * location.h: Rename include guard.
9627 * linux-record.h: Rename include guard.
9628 * linux-nat.h: Add include guard.
9629 * linux-fork.h: Add include guard.
9630 * i386-darwin-tdep.h: Rename include guard.
9631 * hppa-linux-offsets.h: Add include guard.
9632 * guile/guile.h: Rename include guard.
9633 * guile/guile-internal.h: Rename include guard.
9634 * gnu-nat.h: Rename include guard.
9635 * gdb-stabs.h: Rename include guard.
9636 * frv-tdep.h: Add include guard.
9637 * f-lang.h: Add include guard.
9638 * event-loop.h: Add include guard.
9639 * darwin-nat.h: Rename include guard.
9640 * cp-abi.h: Rename include guard.
9641 * config/sparc/nm-sol2.h: Rename include guard.
9642 * config/nm-nto.h: Rename include guard.
9643 * config/nm-linux.h: Add include guard.
9644 * config/i386/nm-i386gnu.h: Rename include guard.
9645 * config/djgpp/nl_types.h: Rename include guard.
9646 * config/djgpp/langinfo.h: Rename include guard.
9647 * compile/gcc-cp-plugin.h: Add include guard.
9648 * compile/gcc-c-plugin.h: Add include guard.
9649 * compile/compile.h: Rename include guard.
9650 * compile/compile-object-run.h: Rename include guard.
9651 * compile/compile-object-load.h: Rename include guard.
9652 * compile/compile-internal.h: Rename include guard.
9653 * compile/compile-cplus.h: Rename include guard.
9654 * compile/compile-c.h: Rename include guard.
9655 * common/xml-utils.h: Rename include guard.
9656 * common/x86-xstate.h: Rename include guard.
9657 * common/version.h: Rename include guard.
9658 * common/vec.h: Rename include guard.
9659 * common/tdesc.h: Rename include guard.
9660 * common/selftest.h: Rename include guard.
9661 * common/scoped_restore.h: Rename include guard.
9662 * common/scoped_mmap.h: Rename include guard.
9663 * common/scoped_fd.h: Rename include guard.
9664 * common/safe-iterator.h: Rename include guard.
9665 * common/run-time-clock.h: Rename include guard.
9666 * common/refcounted-object.h: Rename include guard.
9667 * common/queue.h: Rename include guard.
9668 * common/ptid.h: Rename include guard.
9669 * common/print-utils.h: Rename include guard.
9670 * common/preprocessor.h: Rename include guard.
9671 * common/pathstuff.h: Rename include guard.
9672 * common/observable.h: Rename include guard.
9673 * common/netstuff.h: Rename include guard.
9674 * common/job-control.h: Rename include guard.
9675 * common/host-defs.h: Rename include guard.
9676 * common/gdb_wait.h: Rename include guard.
9677 * common/gdb_vecs.h: Rename include guard.
9678 * common/gdb_unlinker.h: Rename include guard.
9679 * common/gdb_unique_ptr.h: Rename include guard.
9680 * common/gdb_tilde_expand.h: Rename include guard.
9681 * common/gdb_sys_time.h: Rename include guard.
9682 * common/gdb_string_view.h: Rename include guard.
9683 * common/gdb_splay_tree.h: Rename include guard.
9684 * common/gdb_setjmp.h: Rename include guard.
9685 * common/gdb_ref_ptr.h: Rename include guard.
9686 * common/gdb_optional.h: Rename include guard.
9687 * common/gdb_locale.h: Rename include guard.
9688 * common/gdb_assert.h: Rename include guard.
9689 * common/filtered-iterator.h: Rename include guard.
9690 * common/filestuff.h: Rename include guard.
9691 * common/fileio.h: Rename include guard.
9692 * common/environ.h: Rename include guard.
9693 * common/common-utils.h: Rename include guard.
9694 * common/common-types.h: Rename include guard.
9695 * common/common-regcache.h: Rename include guard.
9696 * common/common-inferior.h: Rename include guard.
9697 * common/common-gdbthread.h: Rename include guard.
9698 * common/common-exceptions.h: Rename include guard.
9699 * common/common-defs.h: Rename include guard.
9700 * common/common-debug.h: Rename include guard.
9701 * common/cleanups.h: Rename include guard.
9702 * common/buffer.h: Rename include guard.
9703 * common/btrace-common.h: Rename include guard.
9704 * common/break-common.h: Rename include guard.
9705 * cli/cli-utils.h: Rename include guard.
9706 * cli/cli-style.h: Rename include guard.
9707 * cli/cli-setshow.h: Rename include guard.
9708 * cli/cli-script.h: Rename include guard.
9709 * cli/cli-interp.h: Rename include guard.
9710 * cli/cli-decode.h: Rename include guard.
9711 * cli/cli-cmds.h: Rename include guard.
9712 * charset-list.h: Add include guard.
9713 * buildsym-legacy.h: Rename include guard.
9714 * bfin-tdep.h: Add include guard.
9715 * ax.h: Rename include guard.
9716 * arm-linux-tdep.h: Add include guard.
9717 * arm-fbsd-tdep.h: Add include guard.
9718 * arch/xtensa.h: Rename include guard.
9719 * arch/tic6x.h: Add include guard.
9720 * arch/i386.h: Add include guard.
9721 * arch/arm.h: Rename include guard.
9722 * arch/arm-linux.h: Rename include guard.
9723 * arch/arm-get-next-pcs.h: Rename include guard.
9724 * arch/amd64.h: Add include guard.
9725 * arch/aarch64-insn.h: Rename include guard.
9726 * arch-utils.h: Rename include guard.
9727 * annotate.h: Add include guard.
9728 * amd64-darwin-tdep.h: Rename include guard.
9729 * aarch64-linux-tdep.h: Add include guard.
9730 * aarch64-fbsd-tdep.h: Add include guard.
9731 * aarch32-linux-nat.h: Add include guard.
9732
9733 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9734
9735 * macrotab.c (macro_define_internal): New function that
9736 factorizes macro_define_object_internal and macro_define_function
9737 code.
9738 (macro_define_object_internal): Use macro_define_internal.
9739 (macro_define_function): Likewise.
9740
9741 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9742
9743 * macrocmd.c (extract_identifier): Return
9744 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9745 callers.
9746
9747 2019-02-06 John Baldwin <jhb@FreeBSD.org>
9748
9749 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9750
9751 2019-02-05 Tom Tromey <tom@tromey.com>
9752
9753 * target.c (target_stack::unpush): Move assertion earlier.
9754
9755 2019-01-30 Tom Tromey <tom@tromey.com>
9756
9757 PR python/23615:
9758 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9759 (gdbpy_parse_and_eval): Likewise.
9760 * python/python-internal.h (gdbpy_allow_threads): New class.
9761
9762 2019-01-28 John Baldwin <jhb@FreeBSD.org>
9763
9764 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9765 (aarch64_fbsd_fpregmap): Move earlier.
9766 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9767 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9768 instead of individual calls to trad_frame_set_reg_addr.
9769 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9770 earlier.
9771 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9772 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9773 instead of individual calls to trad_frame_set_reg_addr.
9774
9775 2019-01-28 Alan Hayward <alan.hayward@arm.com>
9776
9777 * CONTRIBUTE: Replace contribution list with wiki link.
9778
9779 2019-01-25 Tom Tromey <tom@tromey.com>
9780
9781 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9782
9783 2019-01-25 Tom Tromey <tom@tromey.com>
9784
9785 * xtensa-linux-nat.c: Fix common/ includes.
9786 * xml-support.h: Fix common/ includes.
9787 * xml-support.c: Fix common/ includes.
9788 * x86-linux-nat.c: Fix common/ includes.
9789 * windows-nat.c: Fix common/ includes.
9790 * varobj.h: Fix common/ includes.
9791 * varobj.c: Fix common/ includes.
9792 * value.c: Fix common/ includes.
9793 * valops.c: Fix common/ includes.
9794 * utils.c: Fix common/ includes.
9795 * unittests/xml-utils-selftests.c: Fix common/ includes.
9796 * unittests/utils-selftests.c: Fix common/ includes.
9797 * unittests/unpack-selftests.c: Fix common/ includes.
9798 * unittests/tracepoint-selftests.c: Fix common/ includes.
9799 * unittests/style-selftests.c: Fix common/ includes.
9800 * unittests/string_view-selftests.c: Fix common/ includes.
9801 * unittests/scoped_restore-selftests.c: Fix common/ includes.
9802 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9803 * unittests/scoped_fd-selftests.c: Fix common/ includes.
9804 * unittests/rsp-low-selftests.c: Fix common/ includes.
9805 * unittests/parse-connection-spec-selftests.c: Fix common/
9806 includes.
9807 * unittests/optional-selftests.c: Fix common/ includes.
9808 * unittests/offset-type-selftests.c: Fix common/ includes.
9809 * unittests/observable-selftests.c: Fix common/ includes.
9810 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9811 * unittests/memrange-selftests.c: Fix common/ includes.
9812 * unittests/memory-map-selftests.c: Fix common/ includes.
9813 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9814 * unittests/function-view-selftests.c: Fix common/ includes.
9815 * unittests/environ-selftests.c: Fix common/ includes.
9816 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9817 * unittests/common-utils-selftests.c: Fix common/ includes.
9818 * unittests/cli-utils-selftests.c: Fix common/ includes.
9819 * unittests/array-view-selftests.c: Fix common/ includes.
9820 * ui-file.c: Fix common/ includes.
9821 * tui/tui-io.c: Fix common/ includes.
9822 * tracepoint.h: Fix common/ includes.
9823 * tracepoint.c: Fix common/ includes.
9824 * tracefile-tfile.c: Fix common/ includes.
9825 * top.h: Fix common/ includes.
9826 * top.c: Fix common/ includes.
9827 * thread.c: Fix common/ includes.
9828 * target/waitstatus.h: Fix common/ includes.
9829 * target/waitstatus.c: Fix common/ includes.
9830 * target.h: Fix common/ includes.
9831 * target.c: Fix common/ includes.
9832 * target-memory.c: Fix common/ includes.
9833 * target-descriptions.c: Fix common/ includes.
9834 * symtab.h: Fix common/ includes.
9835 * symfile.c: Fix common/ includes.
9836 * stap-probe.c: Fix common/ includes.
9837 * spu-linux-nat.c: Fix common/ includes.
9838 * sparc-nat.c: Fix common/ includes.
9839 * source.c: Fix common/ includes.
9840 * solib.c: Fix common/ includes.
9841 * solib-target.c: Fix common/ includes.
9842 * ser-unix.c: Fix common/ includes.
9843 * ser-tcp.c: Fix common/ includes.
9844 * ser-pipe.c: Fix common/ includes.
9845 * ser-base.c: Fix common/ includes.
9846 * selftest-arch.c: Fix common/ includes.
9847 * s12z-tdep.c: Fix common/ includes.
9848 * rust-exp.y: Fix common/ includes.
9849 * rs6000-aix-tdep.c: Fix common/ includes.
9850 * riscv-tdep.c: Fix common/ includes.
9851 * remote.c: Fix common/ includes.
9852 * remote-notif.h: Fix common/ includes.
9853 * remote-fileio.h: Fix common/ includes.
9854 * remote-fileio.c: Fix common/ includes.
9855 * regcache.h: Fix common/ includes.
9856 * regcache.c: Fix common/ includes.
9857 * record-btrace.c: Fix common/ includes.
9858 * python/python.c: Fix common/ includes.
9859 * python/py-type.c: Fix common/ includes.
9860 * python/py-inferior.c: Fix common/ includes.
9861 * progspace.h: Fix common/ includes.
9862 * producer.c: Fix common/ includes.
9863 * procfs.c: Fix common/ includes.
9864 * proc-api.c: Fix common/ includes.
9865 * printcmd.c: Fix common/ includes.
9866 * ppc-linux-nat.c: Fix common/ includes.
9867 * parser-defs.h: Fix common/ includes.
9868 * osdata.c: Fix common/ includes.
9869 * obsd-nat.c: Fix common/ includes.
9870 * nat/x86-linux.c: Fix common/ includes.
9871 * nat/x86-linux-dregs.c: Fix common/ includes.
9872 * nat/x86-dregs.h: Fix common/ includes.
9873 * nat/x86-dregs.c: Fix common/ includes.
9874 * nat/ppc-linux.c: Fix common/ includes.
9875 * nat/mips-linux-watch.h: Fix common/ includes.
9876 * nat/mips-linux-watch.c: Fix common/ includes.
9877 * nat/linux-waitpid.c: Fix common/ includes.
9878 * nat/linux-ptrace.h: Fix common/ includes.
9879 * nat/linux-ptrace.c: Fix common/ includes.
9880 * nat/linux-procfs.c: Fix common/ includes.
9881 * nat/linux-personality.c: Fix common/ includes.
9882 * nat/linux-osdata.c: Fix common/ includes.
9883 * nat/linux-namespaces.c: Fix common/ includes.
9884 * nat/linux-btrace.h: Fix common/ includes.
9885 * nat/linux-btrace.c: Fix common/ includes.
9886 * nat/fork-inferior.c: Fix common/ includes.
9887 * nat/amd64-linux-siginfo.c: Fix common/ includes.
9888 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9889 * nat/aarch64-linux.c: Fix common/ includes.
9890 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9891 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9892 * namespace.h: Fix common/ includes.
9893 * mips-linux-tdep.c: Fix common/ includes.
9894 * minsyms.c: Fix common/ includes.
9895 * mi/mi-parse.h: Fix common/ includes.
9896 * mi/mi-main.c: Fix common/ includes.
9897 * mi/mi-cmd-env.c: Fix common/ includes.
9898 * memrange.h: Fix common/ includes.
9899 * memattr.c: Fix common/ includes.
9900 * maint.h: Fix common/ includes.
9901 * maint.c: Fix common/ includes.
9902 * main.c: Fix common/ includes.
9903 * machoread.c: Fix common/ includes.
9904 * location.c: Fix common/ includes.
9905 * linux-thread-db.c: Fix common/ includes.
9906 * linux-nat.c: Fix common/ includes.
9907 * linux-fork.c: Fix common/ includes.
9908 * inline-frame.c: Fix common/ includes.
9909 * infrun.c: Fix common/ includes.
9910 * inflow.c: Fix common/ includes.
9911 * inferior.h: Fix common/ includes.
9912 * inferior.c: Fix common/ includes.
9913 * infcmd.c: Fix common/ includes.
9914 * inf-ptrace.c: Fix common/ includes.
9915 * inf-child.c: Fix common/ includes.
9916 * ia64-linux-nat.c: Fix common/ includes.
9917 * i387-tdep.c: Fix common/ includes.
9918 * i386-tdep.c: Fix common/ includes.
9919 * i386-linux-tdep.c: Fix common/ includes.
9920 * i386-linux-nat.c: Fix common/ includes.
9921 * i386-go32-tdep.c: Fix common/ includes.
9922 * i386-fbsd-tdep.c: Fix common/ includes.
9923 * i386-fbsd-nat.c: Fix common/ includes.
9924 * guile/scm-type.c: Fix common/ includes.
9925 * guile/guile.c: Fix common/ includes.
9926 * go32-nat.c: Fix common/ includes.
9927 * gnu-nat.c: Fix common/ includes.
9928 * gdbthread.h: Fix common/ includes.
9929 * gdbarch-selftests.c: Fix common/ includes.
9930 * gdb_usleep.c: Fix common/ includes.
9931 * gdb_select.h: Fix common/ includes.
9932 * gdb_bfd.c: Fix common/ includes.
9933 * gcore.c: Fix common/ includes.
9934 * fork-child.c: Fix common/ includes.
9935 * findvar.c: Fix common/ includes.
9936 * fbsd-nat.c: Fix common/ includes.
9937 * event-top.c: Fix common/ includes.
9938 * event-loop.c: Fix common/ includes.
9939 * dwarf2read.c: Fix common/ includes.
9940 * dwarf2loc.c: Fix common/ includes.
9941 * dwarf2-frame.c: Fix common/ includes.
9942 * dwarf-index-cache.c: Fix common/ includes.
9943 * dtrace-probe.c: Fix common/ includes.
9944 * disasm-selftests.c: Fix common/ includes.
9945 * defs.h: Fix common/ includes.
9946 * csky-tdep.c: Fix common/ includes.
9947 * cp-valprint.c: Fix common/ includes.
9948 * cp-support.h: Fix common/ includes.
9949 * cp-support.c: Fix common/ includes.
9950 * corelow.c: Fix common/ includes.
9951 * completer.h: Fix common/ includes.
9952 * completer.c: Fix common/ includes.
9953 * compile/compile.c: Fix common/ includes.
9954 * compile/compile-loc2c.c: Fix common/ includes.
9955 * compile/compile-cplus-types.c: Fix common/ includes.
9956 * compile/compile-cplus-symbols.c: Fix common/ includes.
9957 * command.h: Fix common/ includes.
9958 * cli/cli-dump.c: Fix common/ includes.
9959 * cli/cli-cmds.c: Fix common/ includes.
9960 * charset.c: Fix common/ includes.
9961 * build-id.c: Fix common/ includes.
9962 * btrace.h: Fix common/ includes.
9963 * btrace.c: Fix common/ includes.
9964 * breakpoint.h: Fix common/ includes.
9965 * breakpoint.c: Fix common/ includes.
9966 * ax.h:
9967 (enum agent_op): Fix common/ includes.
9968 * ax-general.c (struct aop_map): Fix common/ includes.
9969 * ax-gdb.c: Fix common/ includes.
9970 * auxv.c: Fix common/ includes.
9971 * auto-load.c: Fix common/ includes.
9972 * arm-tdep.c: Fix common/ includes.
9973 * arch/riscv.c: Fix common/ includes.
9974 * arch/ppc-linux-common.c: Fix common/ includes.
9975 * arch/i386.c: Fix common/ includes.
9976 * arch/arm.c: Fix common/ includes.
9977 * arch/arm-linux.c: Fix common/ includes.
9978 * arch/arm-get-next-pcs.c: Fix common/ includes.
9979 * arch/amd64.c: Fix common/ includes.
9980 * arch/aarch64.c: Fix common/ includes.
9981 * arch/aarch64-insn.c: Fix common/ includes.
9982 * arch-utils.c: Fix common/ includes.
9983 * amd64-windows-tdep.c: Fix common/ includes.
9984 * amd64-tdep.c: Fix common/ includes.
9985 * amd64-sol2-tdep.c: Fix common/ includes.
9986 * amd64-obsd-tdep.c: Fix common/ includes.
9987 * amd64-nbsd-tdep.c: Fix common/ includes.
9988 * amd64-linux-tdep.c: Fix common/ includes.
9989 * amd64-linux-nat.c: Fix common/ includes.
9990 * amd64-fbsd-tdep.c: Fix common/ includes.
9991 * amd64-fbsd-nat.c: Fix common/ includes.
9992 * amd64-dicos-tdep.c: Fix common/ includes.
9993 * amd64-darwin-tdep.c: Fix common/ includes.
9994 * agent.c: Fix common/ includes.
9995 * ada-lang.h: Fix common/ includes.
9996 * ada-lang.c: Fix common/ includes.
9997 * aarch64-tdep.c: Fix common/ includes.
9998
9999 2019-01-25 Tom Tromey <tom@tromey.com>
10000
10001 * common/create-version.sh: Use common/version.h.
10002
10003 2019-01-24 Pedro Alves <palves@redhat.com>
10004
10005 * infrun.c (signal_stop, signal_print, signal_program)
10006 (signal_catch, signal_pass): Now arrays instead of pointers.
10007 (update_signals_program_target, do_target_resume)
10008 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10009 * linux-nat.c (linux_nat_target::pass_signals)
10010 (linux_nat_target::create_inferior, linux_nat_target::attach):
10011 Adjust.
10012 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10013 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10014 * procfs.c (procfs_target::pass_signals): Adjust.
10015 * record-full.c (record_full_target::resume): Adjust.
10016 * remote.c (remote_target::pass_signals)
10017 (remote_target::program_signals): Adjust.
10018 * target-debug.h (target_debug_print_signals): Now takes a
10019 gdb::array_view as parameter. Adjust.
10020 * target.h (target_ops) <pass_signals, program_signals>: Replace
10021 pointer and length parameters with gdb::array_view.
10022 (target_pass_signals, target_program_signals): Likewise.
10023 * target-delegates.c: Regenerate.
10024
10025 2019-01-24 Pedro Alves <palves@redhat.com>
10026
10027 * common/forward-scope-exit.h
10028 (forward_scope_exit::forward_scope_exit): Pass arguments to
10029 m_bind_function directly, instead of creating a std::bind and
10030 copying that.
10031
10032 2019-01-24 Alan Hayward <alan.hayward@arm.com>
10033
10034 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10035 for static members.
10036 (pass_in_v_vfp_candidate): Likewise.
10037
10038 2019-01-23 Tom Tromey <tom@tromey.com>
10039 Pedro Alves <palves@redhat.com>
10040
10041 * regcache.c (class regcache_invalidator): Remove.
10042 (regcache::raw_write): Use make_scope_exit.
10043
10044 2019-01-23 Tom Tromey <tom@tromey.com>
10045
10046 * ui-out.h (class ui_out_emit_type): Update comment.
10047
10048 2019-01-23 Tom Tromey <tom@tromey.com>
10049
10050 * infrun.c (fetch_inferior_event): Update comment.
10051
10052 2019-01-23 Tom Tromey <tom@tromey.com>
10053 Pedro Alves <palves@redhat.com>
10054
10055 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10056 parameter.
10057 (fetch_inferior_event): Use SCOPE_EXIT.
10058
10059
10060 2019-01-23 Tom Tromey <tom@tromey.com>
10061 Pedro Alves <palves@redhat.com>
10062
10063 * infrun.c (disable_thread_events): Delete.
10064 (stop_all_threads): Use SCOPE_EXIT.
10065
10066 2019-01-23 Tom Tromey <tom@tromey.com>
10067 Pedro Alves <palves@redhat.com>
10068
10069 * symfile.c: Include forward-scope-exit.h.
10070 (clear_symtab_users_cleanup): Replace forward declaration with
10071 a FORWARD_SCOPE_EXIT.
10072 (syms_from_objfile_1): Use the forward_scope_exit and
10073 gdb::optional instead of cleanup_function.
10074 (reread_symbols): Use the forward_scope_exit instead of
10075 cleanup_function.
10076 (clear_symtab_users_cleanup): Remove function.
10077
10078 2019-01-23 Tom Tromey <tom@tromey.com>
10079 Pedro Alves <palves@redhat.com>
10080
10081 * linux-nat.c: Include scope-exit.h.
10082 (cleanup_target_stop): Remove.
10083 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10084 SCOPE_EXIT.
10085
10086 2019-01-23 Tom Tromey <tom@tromey.com>
10087 Pedro Alves <palves@redhat.com>
10088
10089 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10090 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10091
10092 2019-01-23 Tom Tromey <tom@tromey.com>
10093 Andrew Burgess <andrew.burgess@embecosm.com>
10094 Pedro Alves <palves@redhat.com>
10095
10096 * infrun.c (fetch_inferior_event): Use scope_exit.
10097 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10098 * top.c (execute_command): Use scope_exit.
10099 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10100 * utils.c (do_bpstat_clear_actions_cleanup)
10101 (make_bpstat_clear_actions_cleanup): Remove.
10102
10103 2019-01-23 Tom Tromey <tom@tromey.com>
10104 Pedro Alves <palves@redhat.com>
10105
10106 * infrun.c: Include "common/scope-exit.h"
10107 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10108 (wait_for_inferior): Use SCOPE_EXIT.
10109 (fetch_inferior_event): Use scope_exit.
10110
10111 2019-01-23 Tom Tromey <tom@tromey.com>
10112 Pedro Alves <palves@redhat.com>
10113
10114 * breakpoint.c (create_breakpoint): Remove cleanup.
10115
10116 2019-01-23 Tom Tromey <tom@tromey.com>
10117 Andrew Burgess <andrew.burgess@embecosm.com>
10118 Pedro Alves <palves@redhat.com>
10119
10120 2019-01-23 Pedro Alves <palves@redhat.com>
10121
10122 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10123
10124 2019-01-23 Pedro Alves <palves@redhat.com>
10125 Andrew Burgess <andrew.burgess@embecosm.com>
10126
10127 * gdbthread.h: Include "common/forward-scope-exit.h".
10128 (scoped_finish_thread_state): Redefine custom class in terms of
10129 forward_scope_exit.
10130
10131 2019-01-23 Pedro Alves <palves@redhat.com>
10132 Andrew Burgess <andrew.burgess@embecosm.com>
10133
10134 * common/forward-scope-exit.h: New file.
10135
10136 2019-01-23 Pedro Alves <palves@redhat.com>
10137 Andrew Burgess <andrew.burgess@embecosm.com>
10138 Tom Tromey <tom@tromey.com>
10139
10140 * common/scope-exit.h: New file.
10141
10142 2019-01-23 Pedro Alves <palves@redhat.com>
10143
10144 * common/preprocessor.h (ESC): Rename to ...
10145 (ESC_PARENS): ... this.
10146 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10147 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10148
10149 2019-01-23 Tom Tromey <tom@tromey.com>
10150
10151 * language.h (class scoped_switch_to_sym_language_if_auto):
10152 Initialize m_lang in both cases.
10153
10154 2019-01-23 Alan Hayward <alan.hayward@arm.com>
10155
10156 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10157 with XCNEW.
10158
10159 2019-01-22 Tom Tromey <tom@tromey.com>
10160
10161 * corelow.c: Do not include sys/file.h.
10162
10163 2019-01-22 Tom Tromey <tom@tromey.com>
10164
10165 * tui/tui-wingeneral.h: Include gdb_curses.h.
10166
10167 2019-01-22 Tom Tromey <tom@tromey.com>
10168
10169 * source-cache.h (class source_cache) <get_source_lines,
10170 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10171
10172 2019-01-22 Tom Tromey <tom@tromey.com>
10173
10174 * remote-fileio.h (struct remote_target): Declare.
10175
10176 2019-01-22 Tom Tromey <tom@tromey.com>
10177
10178 * python/py-arch.c: Do not include py-ref.h.
10179 * python/py-bpevent.c: Do not include py-ref.h.
10180 * python/py-cmd.c: Do not include py-ref.h.
10181 * python/py-continueevent.c: Do not include py-ref.h.
10182 * python/py-event.h: Do not include py-ref.h.
10183 * python/py-evtregistry.c: Do not include py-ref.h.
10184 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10185 * python/py-frame.c: Do not include py-ref.h.
10186 * python/py-framefilter.c: Do not include py-ref.h.
10187 * python/py-function.c: Do not include py-ref.h.
10188 * python/py-infevents.c: Do not include py-ref.h.
10189 * python/py-linetable.c: Do not include py-ref.h.
10190 * python/py-objfile.c: Do not include py-ref.h.
10191 * python/py-param.c: Do not include py-ref.h.
10192 * python/py-prettyprint.c: Do not include py-ref.h.
10193 * python/py-progspace.c: Do not include py-ref.h.
10194 * python/py-symbol.c: Do not include py-ref.h.
10195 * python/py-symtab.c: Do not include py-ref.h.
10196 * python/py-type.c: Do not include py-ref.h.
10197 * python/py-unwind.c: Do not include py-ref.h.
10198 * python/py-utils.c: Do not include py-ref.h.
10199 * python/py-value.c: Do not include py-ref.h.
10200 * python/py-varobj.c: Do not include py-ref.h.
10201 * python/py-xmethods.c: Do not include py-ref.h.
10202 * python/python.c: Do not include py-ref.h.
10203 * varobj.c: Do not include py-ref.h.
10204
10205 2019-01-22 Tom Tromey <tom@tromey.com>
10206
10207 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10208 keyword for bcache.
10209
10210 2019-01-22 Tom Tromey <tom@tromey.com>
10211
10212 * compile/compile-cplus-types.c: Remove a comment by #include.
10213
10214 2019-01-22 Tom Tromey <tom@tromey.com>
10215
10216 * compile/gcc-c-plugin.h: Include compile-internal.h.
10217
10218 2019-01-22 Tom Tromey <tom@tromey.com>
10219
10220 * stabsread.c (EXTERN): Do not define.
10221 (symnum, next_symbol_text_func, processing_gcc_compilation)
10222 (within_function, global_sym_chain, global_stabs)
10223 (previous_stab_code, this_object_header_files)
10224 (n_this_object_header_files)
10225 (n_allocated_this_object_header_files): Define.
10226 * stabsread.h (EXTERN): Never define. Use "extern".
10227
10228 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10229
10230 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10231 history_value.
10232
10233 2019-01-21 Tom Tromey <tom@tromey.com>
10234
10235 * ui-out.c: Fix includes.
10236 * tui/tui-source.c: Fix includes.
10237 * target.c: Fix includes.
10238 * remote.c: Fix includes.
10239 * regcache.c: Fix includes.
10240 * python/py-block.c: Fix includes.
10241 * printcmd.c: Fix includes.
10242 * or1k-tdep.c: Fix includes.
10243 * mi/mi-main.c: Fix includes.
10244 * m32r-tdep.c: Fix includes.
10245 * csky-tdep.c: Fix includes.
10246 * compile/compile-cplus-types.c: Fix includes.
10247 * cli/cli-interp.c: Fix includes.
10248
10249 2019-01-21 Alan Hayward <alan.hayward@arm.com>
10250
10251 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10252 for padding.
10253
10254 2019-01-16 Tom Tromey <tom@tromey.com>
10255
10256 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10257 earlier.
10258 (struct objfile) <msymbols_range>: Move from top level.
10259 <msymbols>: New method.
10260 (class objfile_msymbols): Remove.
10261 * symtab.c (default_collect_symbol_completion_matches_break_on):
10262 Update.
10263 * symmisc.c (dump_msymbols): Update.
10264 * stabsread.c (scan_file_globals): Update.
10265 * objc-lang.c (info_selectors_command, info_classes_command)
10266 (find_methods): Update.
10267 * minsyms.c (find_solib_trampoline_target): Update.
10268 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10269 * coffread.c (coff_symfile_read): Update.
10270 * ada-lang.c (ada_lookup_simple_minsym)
10271 (ada_collect_symbol_completion_matches): Update.
10272
10273 2019-01-16 Tom Tromey <tom@tromey.com>
10274
10275 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10276 type. Remove no-argument constructor.
10277 <iterator::operator++>: Simplify.
10278 <begin>: Update.
10279 <end>: Use minimal_symbol_count.
10280
10281 2019-01-16 Tom Tromey <tom@tromey.com>
10282
10283 * objfiles.h (struct objfile) <psymtabs>: New method.
10284 (class objfile_psymtabs): Remove.
10285 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10286 typedef.
10287 <range>: New method.
10288 (require_partial_symbols): Change return type.
10289 * psymtab.c (require_partial_symbols)
10290 (psym_expand_symtabs_matching): Update.
10291 * mdebugread.c (parse_partial_symbols): Update.
10292 * dbxread.c (dbx_end_psymtab): Update.
10293
10294 2019-01-15 Tom Tromey <tom@tromey.com>
10295
10296 * symtab.c (lookup_objfile_from_block)
10297 (lookup_symbol_in_objfile_symtabs)
10298 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10299 (find_line_symtab, info_sources_command)
10300 (default_collect_symbol_completion_matches_break_on)
10301 (make_source_files_completion_list): Update.
10302 * symmisc.c (print_objfile_statistics, dump_objfile)
10303 (maintenance_print_symbols, maintenance_info_symtabs)
10304 (maintenance_check_symtabs, maintenance_info_line_tables):
10305 Update.
10306 * source.c (select_source_symtab)
10307 (forget_cached_source_info_for_objfile): Update.
10308 * objfiles.h (class objfile_compunits): Remove.
10309 (struct objfile) <compunits_range>: New typedef.
10310 (compunits): New method.
10311 * objfiles.c (objfile_relocate1): Update.
10312 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10313 * maint.c (count_symtabs_and_blocks): Update.
10314 * linespec.c (iterate_over_all_matching_symtabs): Update.
10315 * cp-support.c (add_symbol_overload_list_qualified): Update.
10316 * coffread.c (coff_symtab_read): Update.
10317 * ada-lang.c (add_nonlocal_symbols)
10318 (ada_collect_symbol_completion_matches)
10319 (ada_add_global_exceptions): Update.
10320
10321 2019-01-15 Tom Tromey <tom@tromey.com>
10322
10323 * progspace.h (program_space) <objfiles_safe_range>: New
10324 typedef.
10325 <objfiles_safe>: New method.
10326 * objfiles.h (class all_objfiles_safe): Remove.
10327 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10328 * jit.c (jit_inferior_exit_hook): Update.
10329
10330 2019-01-17 Tom Tromey <tom@tromey.com>
10331
10332 * progspace.h (program_space) <objfiles_range>: New typedef.
10333 <objfiles>: New method.
10334 <objfiles_head>: Rename from objfiles.
10335 (object_files): Update.
10336 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10337 * guile/scm-pretty-print.c
10338 (ppscm_find_pretty_printer_from_objfiles): Update.
10339 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10340 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10341 Update.
10342 * python/py-progspace.c (pspy_get_objfiles): Update.
10343 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10344 Update.
10345 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10346 (objfpy_lookup_objfile_by_build_id): Update.
10347 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10348 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10349 Update.
10350 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10351 (expand_symtab_containing_pc, lookup_objfile_from_block)
10352 (lookup_static_symbol, basic_lookup_transparent_type)
10353 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10354 (find_line_symtab, info_sources_command)
10355 (default_collect_symbol_completion_matches_break_on)
10356 (make_source_files_completion_list, find_main_name): Update.
10357 * symmisc.c (print_symbol_bcache_statistics)
10358 (print_objfile_statistics, maintenance_print_symbols)
10359 (maintenance_print_msymbols, maintenance_print_objfiles)
10360 (maintenance_info_symtabs, maintenance_check_symtabs)
10361 (maintenance_expand_symtabs, maintenance_info_line_tables):
10362 Update.
10363 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10364 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10365 (map_overlay_command, unmap_overlay_command)
10366 (simple_overlay_update, expand_symtabs_matching)
10367 (map_symbol_filenames): Update.
10368 * symfile-debug.c (set_debug_symfile): Update.
10369 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10370 Update.
10371 * source.c (select_source_symtab, forget_cached_source_info):
10372 Update.
10373 * solib.c (solib_read_symbols): Update.
10374 * solib-spu.c (append_ocl_sos): Update.
10375 * psymtab.c (maintenance_print_psymbols)
10376 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10377 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10378 * printcmd.c (info_symbol_command): Update.
10379 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10380 Update.
10381 * objfiles.h (class all_objfiles): Remove.
10382 * objfiles.c (have_partial_symbols, have_full_symbols)
10383 (have_minimal_symbols, qsort_cmp, update_section_map)
10384 (shared_objfile_contains_address_p)
10385 (default_iterate_over_objfiles_in_search_order): Update.
10386 * objc-lang.c (info_selectors_command, info_classes_command)
10387 (find_methods): Update.
10388 * minsyms.c (find_solib_trampoline_target): Update.
10389 * maint.c (maintenance_info_sections)
10390 (maintenance_translate_address, count_symtabs_and_blocks):
10391 Update.
10392 * main.c (captured_main_1): Update.
10393 * linux-thread-db.c (try_thread_db_load_from_pdir)
10394 (has_libpthread): Update.
10395 * linespec.c (iterate_over_all_matching_symtabs)
10396 (search_minsyms_for_name): Update.
10397 * jit.c (jit_find_objf_with_entry_addr): Update.
10398 * hppa-tdep.c (find_unwind_entry)
10399 (hppa_lookup_stub_minimal_symbol): Update.
10400 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10401 Update.
10402 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10403 (elf_gnu_ifunc_resolve_by_got): Update.
10404 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10405 * dwarf-index-write.c (save_gdb_index_command): Update.
10406 * cp-support.c (add_symbol_overload_list_qualified): Update.
10407 * breakpoint.c (create_overlay_event_breakpoint)
10408 (create_longjmp_master_breakpoint)
10409 (create_std_terminate_master_breakpoint)
10410 (create_exception_master_breakpoint): Update.
10411 * blockframe.c (find_pc_partial_function): Update.
10412 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10413 (ada_collect_symbol_completion_matches)
10414 (ada_add_global_exceptions): Update.
10415
10416 2019-01-17 Tom Tromey <tom@tromey.com>
10417
10418 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10419 declare VEC.
10420 (solib_target_parse_libraries): Change return type.
10421 (library_list_start_segment, library_list_start_section)
10422 (library_list_end_library, library_list_start_library); Update.
10423 (solib_target_free_library_list): Remove.
10424 (solib_target_parse_libraries): Remove cleanup. Change return
10425 type.
10426 (solib_target_current_sos): Update.
10427
10428 2019-01-17 Tom Tromey <tromey@bapiya>
10429
10430 * valprint.c: Replace "the the" with "the".
10431 * symtab.c: Replace "the the" with "the".
10432 * solib.c: Replace "the the" with "the".
10433 * solib-dsbt.c: Replace "the the" with "the".
10434 * linespec.c: Replace "the the" with "the".
10435 * dwarf2loc.h: Replace "the the" with "the".
10436 * amd64-windows-tdep.c: Replace "the the" with "the".
10437 * aarch64-tdep.c: Replace "the the" with "the".
10438
10439 2019-01-16 Keith Seitz <keiths@redhat.com>
10440
10441 PR gdb/23773
10442 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10443 <builder>: Rename to ..
10444 <m_builder>: ... this and make private.
10445 (dwarf2_cu::get_builder): New method. Change all users of
10446 `builder' to use this method.
10447 (dwarf2_start_symtab): Move to ...
10448 (dwarf2_cu::start_symtab): ... here. Update all callers
10449 (setup_type_unit_groups): Move to ...
10450 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10451 callers.
10452 (dwarf2_cu::reset_builder): New method.
10453 (process_full_compunit, process_full_type_unit): Use
10454 dwarf2_cu::reset_builder.
10455 (follow_die_offset): Record the ancestor CU if it is different
10456 from the followed DIE's CU.
10457 (follow_die_sig_1): Likewise.
10458
10459 2019-01-15 Tom Tromey <tom@tromey.com>
10460
10461 * remote.c (class remote_state) <buf>: Now a char_vector.
10462 <buf_size>: Remove.
10463 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10464 parameter.
10465 (remote_target::getpkt_or_notif_sane_1)
10466 (remote_target::getpkt_sane)
10467 (remote_target::getpkt_or_notif_sane): Likewise.
10468 (class remote_target) <putpkt>: New overload.
10469 (remote_target::read_frame): Change type of "buf_p". Remove
10470 sizeof_p parameter.
10471 (packet_ok): New overload.
10472 (packet_check_result): New overload.
10473 Update all uses.
10474
10475 2019-01-14 Tom Tromey <tom@tromey.com>
10476
10477 * remote-notif.c (handle_notification, remote_notif_ack)
10478 (remote_notif_parse): Make "buf" const.
10479 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10480 const.
10481 (remote_notif_parse, remote_notif_ack, handle_notification):
10482 Likewise.
10483 * remote.c (remote_notif_stop_parse): Make "buf" const.
10484 (remote_target::remote_parse_stop_reply): Make "buf" const.
10485 (remote_notif_stop_ack): Make "buf" const.
10486
10487 2019-01-14 Tom Tromey <tom@tromey.com>
10488
10489 * remote.c (remote_console_output): Make parameter const.
10490
10491 2019-01-14 Tom Tromey <tom@tromey.com>
10492
10493 * target-debug.h (target_debug_print_signals): Constify.
10494 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10495 * procfs.c (procfs_target::pass_signals): Update.
10496 * linux-nat.c (linux_nat_target::pass_signals): Update.
10497 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10498 * target-delegates.c: Rebuild.
10499 * remote.c (remote_target::program_signals): Update.
10500 (remote_target::pass_signals): Update.
10501 * target.c (target_pass_signals): Constify argument.
10502 (target_program_signals): Likewise.
10503 * target.h (struct target_ops) <pass_signals, program_signals>:
10504 Constify argument.
10505 (target_pass_signals, target_program_signals): Constify argument.
10506
10507 2019-01-14 Tom Tromey <tom@tromey.com>
10508
10509 PR tui/28819:
10510 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10511
10512 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10513
10514 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10515 field.
10516 * rs6000-tdep.c: Include reggroups.h.
10517 (IS_V_ALIAS_PSEUDOREG): Define.
10518 (rs6000_register_name): Return names for the "vX" aliases.
10519 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10520 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10521 aliases. Call default_register_reggroup_p for all other
10522 pseudo-registers.
10523 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10524 New functions.
10525 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10526 Handle "vX" aliases.
10527 (v_alias_pseudo_register_collect): New function.
10528 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10529 (rs6000_gdbarch_init): Initialize "vX" aliases as
10530 pseudo-registers. Restore registration of
10531 rs6000_pseudo_register_reggroup_p with
10532 set_tdesc_pseudo_register_reggroup_p.
10533
10534 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10535
10536 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10537 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10538 set_gdbarch_num_pseudo_regs.
10539
10540 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10541
10542 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10543 Remove arg prefixname, add do_set and do_show.
10544 Add member functions set_list and show_list.
10545 * cli/cli-style.c (class cli_style_option): Update accordingly.
10546 (style_set_list): Move to file scope.
10547 (style_show_list): Likewise.
10548 (set_style): Call help_list.
10549 (show_style): Call cmd_show_list.
10550 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10551 Update to use the new macro.
10552
10553 2019-10-12 Joel Brobecker <brobecker@adacore.com>
10554
10555 * ada-lang.c (_initialize_ada_language): Expand the help text
10556 for the "catch exception" command.
10557
10558 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10559
10560 * symtab.c (matching_obj_sections): Initialize obj,
10561 declare it closer to its usage.
10562
10563 2019-01-10 Tom Tromey <tom@tromey.com>
10564
10565 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10566 (basic_inf_threads_range): Remove.
10567 (inf_threads_range, inf_non_exited_threads_range)
10568 (safe_inf_threads_range): Use next_adapter.
10569
10570 2019-01-10 Keith Seitz <keiths@redhat.com>
10571
10572 PR gdb/23712
10573 PR symtab/23010
10574 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10575 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10576
10577 2019-01-10 Keith Seitz <keiths@redhat.com>
10578
10579 PR gdb/23712
10580 PR symtab/23010
10581 * dictionary.c (pending_to_vector): Remove.
10582 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10583 Remove _1 suffix, replacing functions of the same name. Update
10584 all callers.
10585 (dict_create_hashed, dict_create_hashed_expandable)
10586 (dict_create_linear, dict_create_linear_expandable, dict_free)
10587 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10588 Make functions static.
10589
10590 2019-01-10 Keith Seitz <keiths@redhat.com>
10591
10592 PR gdb/23712
10593 PR symtab/23010
10594 * dictionary.h (struct dictionary): Replace declaration with
10595 multidictionary.
10596 (dict_create_hashed, dict_create_hashed_expandable)
10597 (dict_create_linear, dict_create_linear_expandable)
10598 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10599 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10600 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10601 taking multidictionary argument.
10602 [ALL_DICT_SYMBOLS]: Update for multidictionary.
10603 * block.h (struct block) <dict>: Change to multidictionary
10604 and rename `multidict'.
10605 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10606 symmisc.c: Update all dictionary references to multidictionary.
10607
10608 2019-01-10 Keith Seitz <keiths@redhat.com>
10609
10610 PR gdb/23712
10611 PR symtab/23010
10612 * dictionary.c: Include unordered_map.
10613 (pending_to_vector): New function.
10614 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10615 Rewrite the non-"_1" functions to take vector instead
10616 of linked list.
10617 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10618 "new" _1 versions of the same name.
10619 (multidictionary): Define.
10620 (std::hash<enum language): New definition.
10621 (collate_pending_symbols_by_language, mdict_create_hashed)
10622 (mdict_create_hashed_expandable, mdict_create_linear)
10623 (mdict_create_linear_expandable, mdict_free)
10624 (find_language_dictionary, create_new_language_dictionary)
10625 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10626 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10627 (mdict_size, mdict_empty): New functions.
10628 * dictionary.h (mdict_iterator): Define.
10629
10630 2019-01-10 Pedro Alves <palves@redhat.com>
10631
10632 * breakpoint.c (read_uploaded_action)
10633 (create_tracepoint_from_upload): Adjust to use
10634 gdb::unique_xmalloc_ptr.
10635 * ctf.c (ctf_write_uploaded_tp):
10636 (SET_ARRAY_FIELD): Use emplace_back.
10637 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10638 * tracefile-tfile.c (tfile_write_uploaded_tp):
10639 * tracepoint.c (parse_tracepoint_definition): Adjust to use
10640 gdb::unique_xmalloc_ptr.
10641 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10642 at_string, cond_string, cmd_strings>: Replace char pointers
10643 with gdb::unique_xmalloc_ptr.
10644
10645 2019-01-10 Pedro Alves <palves@redhat.com>
10646
10647 * solib-target.c (library_list_start_library): Don't xstrdup name.
10648
10649 2019-01-10 Pedro Alves <palves@redhat.com>
10650
10651 * mdebugread.c (parse_partial_symbols): Use
10652 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10653
10654 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10655
10656 * linux-fork.c (scoped_switch_fork_info)
10657 <~scoped_switch_fork_info>: Fix incorrect variable name.
10658
10659 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
10660
10661 * linux-fork.c (scoped_switch_fork_info)
10662 <scoped_switch_fork_info>: Make explicit.
10663 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10664
10665 2019-01-10 Tom Tromey <tom@tromey.com>
10666
10667 * objfiles.h (objfile::reset_psymtabs): Update.
10668 * objfiles.c (objfile::objfile): Update.
10669 * psymtab.h (psymtab_storage::obstack): Update.
10670 (psymtab_storage::m_obstack): Use gdb::optional.
10671 (class psymtab_storage): Update comment. Remove objfile
10672 parameter.
10673 * psymtab.c (psymtab_storage::psymtab_storage): Update.
10674
10675 2019-01-10 Tom Tromey <tom@tromey.com>
10676
10677 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10678 <free_psymtabs>: Now private.
10679 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10680 (allocate_psymtab): Use new method.
10681
10682 2019-01-10 Tom Tromey <tom@tromey.com>
10683
10684 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10685 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10686 * mdebugread.c (parse_partial_symbols): Use
10687 allocate_dependencies.
10688 * dwarf2read.c (dwarf2_create_include_psymtab): Use
10689 allocate_dependencies.
10690 (process_psymtab_comp_unit_reader)
10691 (build_type_psymtab_dependencies): Likewise.
10692 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10693
10694 2019-01-10 Tom Tromey <tom@tromey.com>
10695
10696 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10697 PSYMBOL_SET_LANGUAGE.
10698 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10699
10700 2019-01-10 Tom Tromey <tom@tromey.com>
10701
10702 * psymtab.h (psymtab_storage::obstack): New method.
10703 <m_obstack>: Rename from obstack; now private.
10704 * psymtab.c (psymtab_storage): Update.
10705 * dwarf2read.c (create_addrmap_from_index)
10706 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10707 Update.
10708
10709 2019-01-10 Tom Tromey <tom@tromey.com>
10710
10711 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10712 * objfiles.h (objfile::reset_psymtabs): New method.
10713
10714 2019-01-10 Tom Tromey <tom@tromey.com>
10715
10716 * symmisc.c (print_symbol_bcache_statistics): Update.
10717 (print_objfile_statistics): Update.
10718 * symfile.c (reread_symbols): Update.
10719 * psymtab.h (class psymtab_storage): New.
10720 * psymtab.c (psymtab_storage): New constructor.
10721 (~psymtab_storage): New destructor.
10722 (require_partial_symbols): Update.
10723 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10724 (find_pc_sect_psymtab, find_pc_sect_psymbol)
10725 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10726 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10727 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10728 (start_psymtab_common, end_psymtab_common)
10729 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10730 (allocate_psymtab): Update.
10731 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10732 Update.
10733 (dump_psymtab_addrmap, maintenance_print_psymbols)
10734 (maintenance_check_psymtabs): Update.
10735 (class objfile_psymtabs): Move to objfiles.h.
10736 * psympriv.h (discard_psymtab): Now inline.
10737 (psymtab_discarder::psymtab_discarder): Update.
10738 (psymtab_discarder::~psymtab_discarder): Update.
10739 (ALL_OBJFILE_PSYMTABS): Rewrite.
10740 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10741 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10742 Remove fields.
10743 <partial_symtabs>: New field.
10744 (class objfile_psymtabs): Move from psymtab.h. Update.
10745 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10746 psymbol_cache.
10747 (objfile::~objfile): Don't destroy psymbol_cache.
10748 * mdebugread.c (parse_partial_symbols): Update.
10749 * dwarf2read.c (create_addrmap_from_index)
10750 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10751 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10752 (add_partial_subprogram, dwarf2_ranges_read): Update.
10753 * dwarf-index-write.c (write_address_map)
10754 (write_one_signatured_type, recursively_write_psymbols)
10755 (class debug_names, class debug_names, write_psymtabs_to_index):
10756 Update.
10757
10758 2019-01-10 Tom Tromey <tom@tromey.com>
10759
10760 * symtab.h (SYMBOL_SET_NAMES): Update.
10761 (symbol_set_names): Update.
10762 (MSYMBOL_SET_NAMES): Update.
10763 * symtab.c (symbol_set_names): Change argument to be an
10764 objfile_per_bfd_storage.
10765 * psymtab.c (add_psymbol_to_bcache): Update.
10766 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10767
10768 2019-01-10 Tom Tromey <tom@tromey.com>
10769
10770 * symtab.c (create_demangled_names_hash): Change argument to be an
10771 objfile_per_bfd_storage.
10772 (symbol_set_names): Update.
10773
10774 2019-01-10 Tom Tromey <tom@tromey.com>
10775
10776 * xcoffread.c (xcoff_initial_scan): Unconditionally call
10777 init_psymbol_list.
10778 * psymtab.c (init_psymbol_list): Do nothing if already called.
10779 * psympriv.h (init_psymbol_list): Add comment.
10780 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10781 init_psymbol_list.
10782 * dbxread.c (dbx_symfile_read): Unconditionally call
10783 init_psymbol_list.
10784
10785 2019-01-10 Tom Tromey <tom@tromey.com>
10786
10787 * xcoffread.c (scan_xcoff_symtab): Update.
10788 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10789 "where".
10790 * mdebugread.c (parse_partial_symbols)
10791 (handle_psymbol_enumerators): Update.
10792 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10793 * dbxread.c (read_dbx_symtab): Update.
10794 * psympriv.h (psymbol_placement): New enum.
10795 (add_psymbol_to_list): Update.
10796
10797 2019-01-10 Tom Tromey <tom@tromey.com>
10798
10799 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10800 static_psymbols parameters.
10801 (scan_xcoff_symtab): Update.
10802 * psymtab.c (start_psymtab_common): Remove global_psymbols and
10803 static_psymbols parameters.
10804 * psympriv.h (start_psymtab_common): Update.
10805 * mdebugread.c (parse_partial_symbols): Update.
10806 * dwarf2read.c (create_partial_symtab): Update.
10807 * dbxread.c (read_dbx_symtab): Update.
10808 (start_psymtab): Remove global_psymbols and static_psymbols
10809 parameters.
10810
10811 2019-01-10 Tom Tromey <tom@tromey.com>
10812
10813 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10814 * psymtab.c (allocate_psymtab): Add comment.
10815 * psympriv.h (allocate_psymtab): Add comment.
10816 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10817 initializations.
10818 * dbxread.c (dbx_end_psymtab): Remove some initializations.
10819
10820 2019-01-10 Tom Tromey <tom@tromey.com>
10821
10822 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10823 Don't declare.
10824 * mipsread.c: Include mdebugread.h.
10825 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10826 Declare.
10827 * elfread.c: Include mdebugread.h.
10828
10829 2019-01-09 Tom Tromey <tom@tromey.com>
10830
10831 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10832 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10833 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10834 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10835 (psym_lookup_symbol, psym_find_last_source_symtab)
10836 (psym_forget_cached_source_info, psym_print_stats)
10837 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10838 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10839 (psym_map_matching_symbols, psym_expand_symtabs_matching)
10840 (psym_find_compunit_symtab_by_address)
10841 (maintenance_print_psymbols, maintenance_info_psymtabs)
10842 (maintenance_check_psymtabs): Use ranged for.
10843 * psymtab.h (class objfile_psymtabs): New.
10844 (require_partial_symbols): Return objfile_psymtabs.
10845 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10846
10847 2019-01-09 Tom Tromey <tom@tromey.com>
10848
10849 * symfile.c (overlay_invalidate_all, find_pc_overlay)
10850 (find_pc_mapped_section, list_overlays_command)
10851 (map_overlay_command, unmap_overlay_command)
10852 (simple_overlay_update): Use all_objfiles.
10853 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10854 * printcmd.c (info_symbol_command): Use all_objfiles.
10855 * objfiles.h (ALL_OBJSECTIONS): Remove.
10856 * maint.c (maintenance_translate_address): Use all_objfiles.
10857 * gcore.c (gcore_create_callback): Use all_objfiles.
10858 (objfile_find_memory_regions): Likewise.
10859
10860 2019-01-09 Tom Tromey <tom@tromey.com>
10861
10862 * symtab.c (find_line_symtab, info_sources_command)
10863 (make_source_files_completion_list): Use objfile_compunits.
10864 * source.c (select_source_symtab): Use objfile_compunits.
10865 * objfiles.h (struct objfile): Update comment.
10866 (ALL_OBJFILES): Remove.
10867 (ALL_FILETABS): Remove.
10868 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10869 objfile_compunits.
10870
10871 2019-01-09 Tom Tromey <tom@tromey.com>
10872
10873 * symmisc.c (print_objfile_statistics, dump_objfile)
10874 (maintenance_print_symbols): Use compunit_filetabs.
10875 * source.c (forget_cached_source_info_for_objfile): Use
10876 compunit_filetabs.
10877 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10878 (ALL_FILETABS): Use compunit_filetabs.
10879 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10880 * coffread.c (coff_symtab_read): Use compunit_filetabs.
10881
10882 2019-01-09 Tom Tromey <tom@tromey.com>
10883
10884 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10885 (compunit_filetabs): New.
10886 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10887 compunit_filetabs.
10888 (info_sources_command, make_source_files_completion_list): Remove
10889 declaration.
10890 * symmisc.c (print_objfile_statistics, dump_objfile)
10891 (maintenance_print_symbols): Remove declaration.
10892 (maintenance_info_symtabs): Use compunit_filetabs.
10893 (maintenance_info_line_tables): Likewise.
10894 * source.c (select_source_symtab): Change local variable name.
10895 (forget_cached_source_info_for_objfile): Remove declaration.
10896 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10897 * objfiles.c (objfile_relocate1): Remove declaration.
10898 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10899 declaration.
10900 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10901 * coffread.c (coff_symtab_read): Remove declaration.
10902 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10903 compunit_filetabs.
10904
10905 2019-01-09 Tom Tromey <tom@tromey.com>
10906
10907 * symtab.c (lookup_objfile_from_block)
10908 (find_pc_sect_compunit_symtab, search_symbols)
10909 (default_collect_symbol_completion_matches_break_on): Use
10910 objfile_compunits.
10911 * objfiles.h (ALL_COMPUNITS): Remove.
10912 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10913 * cp-support.c (add_symbol_overload_list_qualified): Use
10914 objfile_compunits.
10915 * ada-lang.c (ada_collect_symbol_completion_matches)
10916 (ada_add_global_exceptions): Use objfile_compunits.
10917
10918 2019-01-09 Tom Tromey <tom@tromey.com>
10919
10920 * source.c (select_source_symtab)
10921 (forget_cached_source_info_for_objfile): Remove declaration.
10922 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10923 declaration.
10924 * maint.c (count_symtabs_and_blocks): Remove declaration.
10925 * cp-support.c (add_symbol_overload_list_qualified): Remove
10926 declaration.
10927 * coffread.c (coff_symtab_read): Remove declaration.
10928 * symtab.c (lookup_symbol_in_objfile_symtabs)
10929 (basic_lookup_transparent_type_1): Use objfile_compunits.
10930 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10931 (info_sources_command, search_symbols)
10932 (default_collect_symbol_completion_matches_break_on)
10933 (make_source_files_completion_list): Remove declaration.
10934 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10935 (ada_collect_symbol_completion_matches)
10936 (ada_add_global_exceptions): Remove declaration.
10937 * linespec.c (iterate_over_all_matching_symtabs): Use
10938 objfile_compunits.
10939 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10940 (class objfile_compunits): New.
10941 (ALL_COMPUNITS): Use objfile_compunits.
10942 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10943 (maintenance_check_symtabs, maintenance_info_line_tables): Use
10944 objfile_compunits.
10945 * objfiles.c (objfile_relocate1): Use objfile_compunits.
10946
10947 2019-01-09 Tom Tromey <tom@tromey.com>
10948
10949 * symtab.c (search_symbols)
10950 (default_collect_symbol_completion_matches_break_on): Use
10951 objfile_msymbols.
10952 * ada-lang.c (ada_lookup_simple_minsym)
10953 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10954 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10955 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10956 objfile_msymbols.
10957 * coffread.c (coff_symfile_read): Use objfile_msymbols.
10958 * symmisc.c (dump_msymbols): Use objfile_msymbols.
10959 * objc-lang.c (find_methods): Use objfile_msymbols.
10960 (info_selectors_command, info_classes_command): Likewise.
10961 * stabsread.c (scan_file_globals): Use objfile_msymbols.
10962 * objfiles.h (class objfile_msymbols): New.
10963 (ALL_OBJFILE_MSYMBOLS): Remove.
10964 (ALL_MSYMBOLS): Remove.
10965
10966 2019-01-09 Tom Tromey <tom@tromey.com>
10967
10968 * common/next-iterator.h (next_adapter): Add Iterator template
10969 parameter.
10970 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10971 (class all_objfiles_safe): New.
10972 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10973 * objfiles.c (put_objfile_before): Update comment.
10974 (add_separate_debug_objfile): Likewise.
10975 (free_all_objfiles): Use all_objfiles_safe.
10976 (objfile_purge_solibs): Likewise.
10977
10978 2019-01-09 Tom Tromey <tom@tromey.com>
10979
10980 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10981 (expand_symtab_containing_pc, lookup_static_symbol)
10982 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10983 (find_symbol_at_address, find_line_symtab, find_main_name): Use
10984 all_objfiles.
10985 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10986 * breakpoint.c (create_overlay_event_breakpoint)
10987 (create_longjmp_master_breakpoint)
10988 (create_std_terminate_master_breakpoint)
10989 (create_exception_master_breakpoint): Use all_objfiles.
10990 * linux-thread-db.c (try_thread_db_load_from_pdir)
10991 (has_libpthread): Use all_objfiles.
10992 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10993 * linespec.c (iterate_over_all_matching_symtabs)
10994 (search_minsyms_for_name): Use all_objfiles.
10995 * maint.c (maintenance_info_sections): Use all_objfiles.
10996 * main.c (captured_main_1): Use all_objfiles.
10997 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10998 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10999 * guile/scm-pretty-print.c
11000 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11001 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11002 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11003 (maintenance_print_msymbols): Use all_objfiles.
11004 * source.c (select_source_symtab): Use all_objfiles.
11005 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11006 * symfile.c (remove_symbol_file_command)
11007 (expand_symtabs_matching, map_symbol_filenames): Use
11008 all_objfiles.
11009 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11010 all_objfiles.
11011 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11012 * objc-lang.c (find_methods): Use all_objfiles.
11013 * objfiles.c (have_partial_symbols, have_full_symbols)
11014 (have_minimal_symbols, qsort_cmp)
11015 (default_iterate_over_objfiles_in_search_order): Use
11016 all_objfiles.
11017 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11018 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11019 (maintenance_check_psymtabs): Use all_objfiles.
11020 (ALL_PSYMTABS): Remove.
11021 * compile/compile-object-run.c (do_module_cleanup): Use
11022 all_objfiles.
11023 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11024 * cp-support.c (add_symbol_overload_list_qualified): Use
11025 all_objfiles.
11026 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11027 Use all_objfiles.
11028 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11029 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11030 all_objfiles.
11031 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11032 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11033 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11034 Uses all_objfiles.
11035 * solib.c (solib_read_symbols): Use all_objfiles
11036
11037 2019-01-09 Tom Tromey <tom@tromey.com>
11038
11039 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11040 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11041 all_objfiles.
11042 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11043 * symmisc.c (print_symbol_bcache_statistics)
11044 (print_objfile_statistics, maintenance_print_objfiles)
11045 (maintenance_info_symtabs, maintenance_check_symtabs)
11046 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11047 all_objfiles.
11048 * source.c (forget_cached_source_info): Use all_objfiles.
11049 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11050 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11051 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11052 * objfiles.c (update_section_map): Use all_objfiles.
11053 (shared_objfile_contains_address_p): Likewise.
11054 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11055 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11056
11057 2019-01-09 Tom Tromey <tom@tromey.com>
11058
11059 * common/next-iterator.h: New file.
11060 * objfiles.h (class all_objfiles): New.
11061 (struct objfile_iterator): New.
11062
11063 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11064
11065 * NEWS: Move the description of the changed "frame", "select-frame",
11066 and "info frame" commands to the Changed commands section.
11067
11068 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11069
11070 * gdbtypes.c (check_stub_method_group): Remove handling of old
11071 mangling schemes.
11072 * linespec.c (find_methods): Likewise.
11073 * stabsread.c (read_member_functions): Likewise.
11074 * valops.c (search_struct_method): Likewise.
11075 (value_struct_elt_for_reference): Likewise.
11076 * NEWS: Mention this change.
11077
11078 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11079
11080 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11081 print_source_lines.
11082 * source.c (print_source_lines_base): Update line number check.
11083 (print_source_lines): New function.
11084 (source_lines_range::source_lines_range): New function.
11085 * source.h (class source_lines_range): New class.
11086 (print_source_lines): New declaration.
11087
11088 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11089
11090 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11091
11092 2019-01-08 Tom Tromey <tom@tromey.com>
11093 Simon Marchi <simon.marchi@ericsson.com>
11094
11095 PR gdb/24060
11096 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11097 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11098 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11099 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11100 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11101 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11102
11103 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11104
11105 * source.c (select_source_symtab): Move header comment to
11106 declaration in source.h.
11107 (forget_cached_source_info_for_objfile): Likewise.
11108 (forget_cached_source_info): Likewise.
11109 (identify_source_line): Likewise.
11110 * source.h (identify_source_line): Move declaration from symtab.h
11111 and add comment from source.c
11112 (print_source_lines): Likewise.
11113 (forget_cached_source_info_for_objfile): Likewise.
11114 (forget_cached_source_info): Likewise.
11115 (select_source_symtab): Likewise.
11116 (enum print_source_lines_flag): Move definition from symtab.h.
11117 * symtab.h (identify_source_line): Move declaration to source.h.
11118 (print_source_lines): Likewise.
11119 (forget_cached_source_info_for_objfile): Likewise.
11120 (forget_cached_source_info): Likewise.
11121 (select_source_symtab): Likewise.
11122 (enum print_source_lines_flag): Move definition to source.h.
11123 * tui/tui-hooks.c: Add 'source.h' include.
11124
11125 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11126
11127 * source.c (print_source_lines_base): Handle requests to print
11128 reverse line number sequences, and guard against empty lines
11129 string.
11130
11131 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11132
11133 * source.c (print_source_lines_base): Fix skip of '\r' if next
11134 character is '\n'.
11135
11136 2019-01-06 Tom Tromey <tom@tromey.com>
11137
11138 * c-exp.y (struct c_parse_state) <macro_original_text,
11139 expansion_obstack>: New member.
11140 (macro_original_text, expansion_obstack): Remove globals.
11141 (scan_macro_expansion, scanning_macro_expansion)
11142 (finished_macro_expansion): Update.
11143 (scan_macro_cleanup): Remove.
11144 (yylex, c_parse): Update.
11145
11146 2019-01-06 Tom Tromey <tom@tromey.com>
11147
11148 * c-exp.y (struct c_parse_state) <strings>: New member.
11149 (operator_stoken): Update.
11150
11151 2019-01-06 Tom Tromey <tom@tromey.com>
11152
11153 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11154 (union type_stack_elt) <typelist_val>: Now a pointer to
11155 std::vector.
11156 (type_stack_cleanup): Don't declare.
11157 (push_typelist): Update.
11158 * parse.c (pop_typelist): Return a std::vector.
11159 (push_typelist): Take a std::vector.
11160 (follow_types): Update. Do not free args.
11161 (type_stack_cleanup): Remove.
11162 * c-exp.y (struct c_parse_state): New.
11163 (cpstate): New global.
11164 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11165 (nonempty_typelist): Update.
11166 (func_mod): Create a new vector.
11167 (c_parse): Create a c_parse_state.
11168 (check_parameter_typelist): Do not delete params.
11169 (function_method): Update. Do not delete type_list.
11170
11171 2019-01-06 Tom Tromey <tom@tromey.com>
11172
11173 PR gdb/28155:
11174 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11175 check_typedef.
11176 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11177 (print_return_value): Likewise.
11178
11179 2019-01-05 Tom Tromey <tom@tromey.com>
11180
11181 * contrib/cleanup_check.py: Remove.
11182 * contrib/gcc-with-excheck: Remove.
11183 * contrib/exsummary.py: Remove.
11184 * contrib/excheck.py: Remove.
11185
11186 2019-01-05 Joel Brobecker <brobecker@adacore.com>
11187
11188 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11189 NULL. Initialize tpprev to NULL instead of assigning it
11190 to NULL on the next statement.
11191 * windows-nat.c (windows_delete_thread): Remove check for
11192 main_thread_id before printing thread exit notifications.
11193 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11194 Remove thread ID check against main_thread_id.
11195 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11196 windows_delete_thread.
11197 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11198
11199 2019-01-04 Tom Tromey <tom@tromey.com>
11200
11201 * compile/compile.c (_initialize_compile): Use upper case for
11202 metasyntactic variables.
11203 * symmisc.c (_initialize_symmisc): Use upper case for
11204 metasyntactic variables.
11205 * psymtab.c (_initialize_psymtab): Use upper case for
11206 metasyntactic variables.
11207 * demangle.c (demangle_command): Use upper case for metasyntactic
11208 variables.
11209 (_initialize_demangler): Likewise.
11210 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11211 variables.
11212
11213 2019-01-03 Tom Tromey <tom@tromey.com>
11214
11215 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11216
11217 2019-01-03 Tom Tromey <tom@tromey.com>
11218
11219 * python/py-symtab.c (salpy_str): Update.
11220 (struct salpy_sal_object) <symtab>: Now a PyObject.
11221 (salpy_dealloc): Update.
11222 (del_objfile_sal): Use gdbpy_ref.
11223
11224 2019-01-03 Tom Tromey <tom@tromey.com>
11225
11226 * python/py-type.c (convert_field): Use new_reference. Return
11227 gdbpy_ref.
11228 (make_fielditem): Return gdbpy_ref.
11229 (typy_fields): Update.
11230 (typy_getitem): Update.
11231 (field_name): Return gdbpy_ref. Use new_reference.
11232 (typy_iterator_iternext): Update.
11233
11234 2019-01-03 Tom Tromey <tom@tromey.com>
11235
11236 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11237
11238 2019-01-03 Tom Tromey <tom@tromey.com>
11239
11240 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11241 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11242 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11243 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11244 (pspy_set_type_printers): Likewise.
11245 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11246 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11247 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11248 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11249 (objfpy_set_type_printers): Likewise.
11250
11251 2019-01-03 Tom Tromey <tom@tromey.com>
11252
11253 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11254 (gdbpy_print_stack): Use gdbpy_err_fetch.
11255 * python/python-internal.h (class gdbpy_err_fetch): New class.
11256 (class gdbpy_enter) <m_error_type, m_error_value,
11257 m_error_traceback>: Remove.
11258 <m_error>: New member.
11259 (gdbpy_exception_to_string): Don't declare.
11260 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11261 * python/py-value.c (convert_value_from_python): Use
11262 gdbpy_err_fetch.
11263 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11264 gdbpy_exception_to_string.
11265 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11266 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11267 gdbpy_err_fetch.
11268
11269 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11270
11271 * linux-nat.c (delete_lwp_cleanup): Delete.
11272 (struct lwp_deleter): New struct.
11273 (lwp_info_up): New typedef.
11274 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11275 lwp_info_up.
11276
11277 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11278
11279 * linux-fork.c (class scoped_switch_fork_info): New class.
11280 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11281
11282 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11283
11284 * valops.c (find_overload_match): Remove use of null_cleanup, and
11285 calls to do_cleanups.
11286
11287 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11288
11289 * compile/compile-cplus-types.c
11290 (compile_cplus_instance::decl_name): Handle changes to
11291 cp_func_name.
11292 * cp-support.c (cp_func_name): Update header comment, update
11293 return type.
11294 * cp-support.h (cp_func_name): Update return type in declaration.
11295 * valops.c (find_overload_match): Move temp_func local to top
11296 level of function and change its type. Use temp_func to hold and
11297 delete temporary string obtained from cp_func_name.
11298
11299 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11300
11301 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11302 gdb::char_vector, remove cleanup, and update uses of `msg`.
11303
11304 2019-01-03 Jim Wilson <jimw@sifive.com>
11305
11306 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11307
11308 2019-01-02 Tom Tromey <tom@tromey.com>
11309
11310 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11311 (tdesc_parse_xml): Remove cleanups.
11312 * target-descriptions.h (make_cleanup_free_target_description):
11313 Don't declare.
11314 (target_desc_deleter): New struct.
11315 (target_desc_up): New typedef.
11316 * target-descriptions.c (target_desc_deleter::operator()): Rename
11317 from free_target_description.
11318 (make_cleanup_free_target_description): Remove.
11319
11320 2019-01-02 Tom Tromey <tom@tromey.com>
11321
11322 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11323 constructor, destructor.
11324 (linespec_parser): Remove typedef.
11325 (~linespec_parser): Rename from linespec_parser_delete.
11326 (linespec_lex_to_end, linespec_complete_label)
11327 (linespec_complete): Update.
11328 (decode_line_full): Remove cleanups.
11329 (decode_line_1): Update.
11330
11331 2019-01-02 Tom Tromey <tom@tromey.com>
11332
11333 * python/python-internal.h (inferior_to_inferior_object): Change
11334 return type.
11335 * python/py-exitedevent.c (create_exited_event_object): Update.
11336 * python/py-inferior.c (inferior_to_inferior_object): Return
11337 gdbpy_ref.
11338 (python_new_inferior, python_inferior_deleted)
11339 (thread_to_thread_object, delete_thread_object)
11340 (build_inferior_list, gdbpy_selected_inferior): Update.
11341 * python/py-infthread.c (create_thread_object): Update. Also fail
11342 if inferior_to_inferior_object fails.
11343
11344 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11345
11346 * inferior.h (class inferior) <displaced_step_state>: New field.
11347 * infrun.h (struct displaced_step_state): Move here from
11348 infrun.c. Initialize fields, add constructor.
11349 <inf>: Remove field.
11350 <reset>: New method.
11351 * infrun.c (struct displaced_step_inferior_state): Move to
11352 infrun.h.
11353 (displaced_step_inferior_states): Remove.
11354 (get_displaced_stepping_state): Adust.
11355 (displaced_step_in_progress_any_inferior): Adjust.
11356 (displaced_step_in_progress_thread): Adjust.
11357 (displaced_step_in_progress): Adjust.
11358 (add_displaced_stepping_state): Remove.
11359 (get_displaced_step_closure_by_addr): Adjust.
11360 (remove_displaced_stepping_state): Remove.
11361 (infrun_inferior_exit): Call displaced_step_state.reset.
11362 (use_displaced_stepping): Don't check for NULL.
11363 (displaced_step_prepare_throw): Call
11364 get_displaced_stepping_state.
11365 (displaced_step_fixup): Don't check for NULL.
11366 (prepare_for_detach): Don't check for NULL.
11367
11368 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11369
11370 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11371 in case of call that did not complete.
11372
11373 2019-01-02 Andrey Utkin <autkin@undo.io>
11374
11375 * symfile.c (find_separate_debug_file): Fix search of debug files for
11376 remote debuggee.
11377
11378 2019-01-02 Tom Tromey <tom@tromey.com>
11379
11380 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11381 indentation.
11382 * python/py-frame.c (frapy_older): Remove cast.
11383 (frapy_newer): Likewise.
11384 * python/py-breakpoint.c (local_setattro): Remove cast.
11385 * python/py-arch.c (archpy_name): Remove local variable.
11386 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11387
11388 2019-01-02 Joel Brobecker <brobecker@adacore.com>
11389
11390 * unittests/basic_string_view/element_access/char/empty.cc:
11391 Fix year range in copyright header.
11392
11393 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11394
11395 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11396 Delete.
11397 <operator==>: Update with for removed field.
11398 <hash>: Likewise.
11399 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11400 <isa_features>: ...this.
11401 <abi_features>: New field.
11402 (riscv_isa_flen): Update comment.
11403 (riscv_abi_xlen): New declaration.
11404 (riscv_abi_flen): New declaration.
11405 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11406 isa_features.
11407 (riscv_abi_xlen): New function.
11408 (riscv_isa_flen): Update to get answer from isa_features.
11409 (riscv_abi_flen): New function.
11410 (riscv_has_fp_abi): Update to get answer from abi_features.
11411 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11412 xlen and flen.
11413 (riscv_call_info) <xlen, flen>: Update comment.
11414 (riscv_call_arg_struct): Remove invalid assertions
11415 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11416 is removed.
11417 (riscv_gdbarch_init): Gather isa features and abi features
11418 separately, ensure both match on the gdbarch when reusing an old
11419 gdbarch. Relax an error check to allow 32-bit abi float to run on
11420 a target with 64-bit float hardware.
11421
11422 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11423
11424 * source.c (search_command_helper): Stop reverse search
11425 when line 1 has been searched.
11426
11427 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11428
11429 * record-full.c (record_full_base_target::close): Rewrite
11430 record_full_core_buf_list free logic.
11431
11432 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11433
11434 * break-catch-syscall.c (print_one_catch_syscall): xfree
11435 the last text.
11436
11437 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11438
11439 * top.c (print_gdb_version): Update Copyright year in version
11440 message.
11441
11442 2019-01-01 Joel Brobecker <brobecker@adacore.com>
11443
11444 Update copyright year range in all GDB files.
11445
11446 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
11447
11448 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11449
11450 For older changes see ChangeLog-2018.
11451 \f
11452 Local Variables:
11453 mode: change-log
11454 left-margin: 8
11455 fill-column: 74
11456 version-control: never
11457 coding: utf-8
11458 End:
11459