gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <set_contents>: Declare.
   5         * tui/tui-winsource.c
   6         (tui_source_window_base::update_source_window_as_is): Update.
   7         * tui/tui-source.h (struct tui_source_window) <set_contents>:
   8         Declare.
   9         (tui_set_source_content): Don't declare.
  10         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  11         tui_set_source_content.
  12         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  13         Declare.
  14         (tui_set_disassem_content): Don't declare.
  15         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  16         tui_set_disassem_content.
  17
  18 2019-08-16  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-winsource.h (struct tui_source_window_base)
  21         <update_breakpoint_info>: Declare.
  22         (tui_update_breakpoint_info): Don't declare.
  23         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  24         (tui_update_all_breakpoint_info): Update.
  25         (tui_source_window_base::update_breakpoint_info): Rename from
  26         tui_update_breakpoint_info.
  27         (tui_source_window_base::update_exec_info): Update.
  28
  29 2019-08-16  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-winsource.h (struct tui_source_window_base)
  32         <update_source_window>: Declare.
  33         (tui_update_source_window): Don't declare.
  34         * tui/tui-winsource.c
  35         (tui_source_window_base::update_source_window): Rename from
  36         tui_update_source_window.
  37         (tui_source_window_base::rerender): Update.
  38         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  39         * tui/tui-disasm.c (tui_show_disassem)
  40         (tui_show_disassem_and_update_source)
  41         (tui_disasm_window::maybe_update): Update.
  42
  43 2019-08-16  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-winsource.h (struct tui_source_window_base)
  46         <update_source_window_as_is>: Declare.
  47         (tui_update_source_window_as_is): Don't declare.
  48         * tui/tui-winsource.c (tui_update_source_window): Update
  49         (tui_source_window_base::update_source_window_as_is): Rename from
  50         tui_update_source_window_as_is.
  51         (tui_source_window_base::refill): Update.
  52         * tui/tui-source.c (tui_show_symtab_source): Update.
  53         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  54         Update.
  55
  56 2019-08-16  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-winsource.h (tui_update_source_window)
  59         (tui_update_source_window_as_is): Remove "noerror" parameter.
  60         * tui/tui-winsource.c (tui_update_source_window)
  61         (tui_update_source_window_as_is): Remove "noerror" parameter.
  62         (tui_update_source_windows_with_addr)
  63         (tui_update_source_windows_with_line)
  64         (tui_source_window_base::rerender)
  65         (tui_source_window_base::refill): Update.
  66         * tui/tui-source.h (tui_set_source_content)
  67         (tui_show_symtab_source): Remove "noerror" parameter.
  68         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  69         parameter.
  70         (tui_show_symtab_source): Likewise.
  71         (tui_source_window::maybe_update): Update.
  72         * tui/tui-disasm.c (tui_show_disassem)
  73         (tui_show_disassem_and_update_source)
  74         (tui_disasm_window::do_scroll_vertical)
  75         (tui_disasm_window::maybe_update): Update.
  76
  77 2019-08-16  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui.c (tui_is_window_visible): Update.
  80         * tui/tui-wingeneral.c (tui_make_window)
  81         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  82         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  83         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  84         (tui_set_win_height_command, parse_scrolling_args): Update.
  85         * tui/tui-source.c (tui_source_window::style_changed): Update.
  86         * tui/tui-regs.c (tui_show_registers)
  87         (tui_data_window::first_data_item_displayed)
  88         (tui_data_window::delete_data_content_windows)
  89         (tui_check_register_values, tui_reg_command): Update.
  90         * tui/tui-disasm.c (tui_show_disassem): Update.
  91         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
  92         method.
  93         <is_visible>: Remove field.
  94         * tui/tui-data.c (tui_next_win, tui_prev_win)
  95         (tui_delete_invisible_windows): Update.
  96
  97 2019-08-16  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-winsource.h (struct tui_source_window_base)
 100         <m_has_locator>: Remove.
 101         * tui/tui-layout.c (show_source_disasm_command, show_data)
 102         (show_source_or_disasm_and_command): Update.
 103
 104 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 105
 106         * NEWS (Other MI changes): New subsection.
 107         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 108         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 109         * arch-utils.c (default_get_pc_address_flags): New function.
 110         * arch-utils.h (default_get_pc_address_flags): New declaration.
 111         * gdbarch.sh: Add get_pc_address_flags.
 112         * gdbarch.c: Regenerate.
 113         * gdbarch.h: Likewise.
 114         * stack.c (print_pc): New function.
 115         (print_frame_info) (print_frame): Call print_pc.
 116
 117 2019-08-16  Tom de Vries  <tdevries@suse.de>
 118
 119         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 120         print_objfile_section_info.
 121
 122 2019-08-15  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 125         calling update_cmdwin_start_line.
 126         * tui/tui-winsource.h (struct tui_source_window_base)
 127         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 128         <rerender>: Declare.
 129         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 130         Call rerender.
 131         (tui_source_window_base::set_new_height): Remove.
 132         (tui_source_window_base::rerender): Rename from
 133         do_make_visible_with_new_height.
 134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 135         resize method.
 136         (tui_win_info::make_invisible_and_set_new_height)
 137         (tui_win_info::make_visible_with_new_height): Remove.
 138         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 139         Declare.
 140         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 141         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 142         do_make_visible_with_new_height>: Don't declare.
 143         <rerender>: Declare.
 144         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 145         set_new_height.
 146         (tui_data_window::do_make_visible_with_new_height): Remove.
 147         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 148         call tui_show_locator_content.
 149         (tui_gen_win_info::resize): Call rerender.
 150         (show_source_or_disasm_and_command): Don't call
 151         tui_show_locator_content.
 152         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 153         method.
 154         (struct tui_win_info) <rerender>: Declare.
 155         <set_new_height, make_invisible_and_set_new_height,
 156         make_visible_with_new_height>: Don't declare.
 157         * tui/tui-data.c (tui_win_list::rerender): New method.
 158         * tui/tui-command.h (struct tui_cmd_window)
 159         <do_make_visible_with_new_height>: Don't declare.
 160         * tui/tui-command.c
 161         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 162
 163 2019-08-15  Tom Tromey  <tromey@adacore.com>
 164
 165         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 166         * ada-lang.c (ada_enum_name): Likewise.
 167
 168 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 169
 170         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 171         leading underscore.
 172         (GdbOutputErrorFile): Likewise.
 173         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 174         accordingly.
 175         (execute_unwinders): Rename to have a leading underscore.
 176         (auto_load_packages): Likewise.
 177         (global scope): Adjust call to auto_load_packages accordingly.
 178         (GdbSetPythonDirectory): Likewise.
 179         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 180         instead of execute_unwinders.
 181
 182 2019-08-15  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 185         (show_data): Don't change window visibility.
 186         (tui_gen_win_info::resize): Remove special case for command
 187         window.  Use wresize, when available.
 188         (show_source_or_disasm_and_command): Don't change window
 189         visibility.
 190         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 191         <make_visible>: New method.
 192         * tui/tui-command.c (tui_cmd_window::resize): New method.
 193
 194 2019-08-15  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 197         (struct tui_source_windows): New.
 198         * tui/tui-winsource.c (tui_display_main): Update.
 199         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 200         (new_height_ok, parse_scrolling_args): Update.
 201         * tui/tui-layout.c (show_layout, show_data): Update.
 202         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 203         (tui_add_to_source_windows): Don't declare.
 204         * tui/tui-data.c (source_windows, tui_source_windows)
 205         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 206
 207 2019-08-15  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 210         Rename from reset.
 211         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 212         * tui/tui-layout.c (show_source_disasm_command, show_data):
 213         Update.
 214         (tui_gen_win_info::resize): Rename.
 215         (show_source_or_disasm_and_command): Update.
 216         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 217         reset.
 218
 219 2019-08-15  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 222         * tui/tui-interp.c (tui_interp::init): Don't call
 223         tui_initialize_static_data.
 224         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 225
 226 2019-08-15  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 229         examine tui_win_list.
 230
 231 2019-08-15  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 234         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 235         tui_clear_source_content.
 236         (tui_clear_source_content): Remove.
 237         (tui_source_window_base::do_erase_source_content): Hoist call to
 238         content.clear().
 239         * tui/tui-stack.c (tui_show_frame_info): Don't call
 240         tui_clear_source_content.
 241
 242 2019-08-15  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-winsource.h (struct tui_source_window_base)
 245         <do_erase_source_content>: New method.
 246         <erase_source_content>: New method.
 247         (tui_erase_source_content): Don't declare.
 248         * tui/tui-winsource.c (tui_clear_source_content): Update.
 249         (tui_source_window_base::do_erase_source_content): Rename from
 250         tui_erase_source_content.
 251         (tui_source_window_base::show_source_content): Update.
 252         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 253         * tui/tui-source.h (struct tui_source_window)
 254         <erase_source_content>: New method.
 255         * tui/tui-disasm.h (struct tui_disasm_window)
 256         <erase_source_content>: New method.
 257
 258 2019-08-15  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 261         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 262         constructor.
 263         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 264         * tui/tui-source.c (tui_set_source_content): Update.
 265         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 266
 267 2019-08-15  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 270         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 271         tui-source.c.
 272         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 273         Declare.
 274         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 275         method.
 276         (tui_source_window::maybe_update): Update.
 277
 278 2019-08-15  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 281         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 282         tui-disasm.c.
 283         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 284         Declare.
 285         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 286         method.
 287         (tui_disasm_window::maybe_update): Update.
 288
 289 2019-08-15  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-winsource.h (struct tui_source_window_base)
 292         <maybe_update>: Declare.
 293         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 294         method.
 295         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 296         Declare.
 297         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 298         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 299         Declare.
 300         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 301
 302 2019-08-15  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 305
 306 2019-08-15  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui-wingeneral.c: Include tui-stack.h.
 309         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 310         (struct tui_locator_window): Move from tui-data.h.
 311         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 312         (tui_initialize_static_data): Move from tui-data.c.
 313         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 314         (struct tui_locator_window): Move to tui-stack.c.
 315         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 316         (tui_initialize_static_data): Move to tui-stack.c.
 317
 318 2019-08-15  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-layout.c (show_source_disasm_command)
 321         (show_source_or_disasm_and_command): Use make_visible method, not
 322         tui_make_window.
 323         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 324         Remove.
 325
 326 2019-08-15  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-wingeneral.h (tui_make_window): Update.
 329         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 330         parameter.
 331         (tui_gen_win_info::make_visible): Update.
 332         * tui/tui-regs.c (tui_data_window::display_registers_from):
 333         Update.
 334         * tui/tui-layout.c (show_source_disasm_command)
 335         (show_source_or_disasm_and_command): Update.
 336         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 337         (enum tui_box): Remove.
 338         (struct tui_win_info) <can_box>: New method.
 339         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 340         method.
 341
 342 2019-08-15  Tom de Vries  <tdevries@suse.de>
 343
 344         * linux-nat-trad.c: Include gdbarch.h.
 345
 346 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 347
 348         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 349         register sizes.
 350
 351 2019-08-14  Tom Tromey  <tromey@adacore.com>
 352
 353         * darwin-nat.c: Include gdbarch.h.
 354         * darwin-nat-info.c: Include gdbarch.h.
 355
 356 2019-08-13  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 359         Remove.
 360         * tui/tui-data.c (tui_initialize_static_data): Update.
 361
 362 2019-08-13  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-winsource.h (struct tui_exec_info_window)
 365         <~tui_exec_info_window, maybe_allocate_content, get_content,
 366         m_content>: Remove.
 367         (struct tui_source_window_base) <set_exec_info_content,
 368         show_exec_info_content>: Don't declare.
 369         * tui/tui-winsource.c
 370         (tui_exec_info_window::maybe_allocate_content): Remove.
 371         (tui_source_window_base::update_exec_info): Rename from
 372         set_exec_info_content.
 373         (tui_source_window_base::show_exec_info_content)
 374         (tui_source_window_base::update_exec_info): Remove.
 375
 376 2019-08-13  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 379         declare.
 380         * tui/tui-winsource.c (tui_update_source_window_as_is)
 381         (tui_update_source_windows_with_addr, tui_erase_source_content):
 382         Update.
 383         (tui_clear_exec_info_content): Remove.
 384
 385 2019-08-13  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 388         declare.
 389         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 390         call tui_erase_exec_info_content.
 391         (tui_clear_exec_info_content): Rename from
 392         tui_erase_exec_info_content.
 393         (tui_clear_exec_info_content): Delete.
 394
 395 2019-08-13  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-winsource.h (struct tui_source_window_base)
 398         <show_exec_info_content>: Declare.
 399         (tui_show_exec_info_content): Don't declare.
 400         * tui/tui-winsource.c
 401         (tui_source_window_base::show_exec_info_content): Rename from
 402         tui_show_exec_info_content.
 403         (tui_source_window_base::update_exec_info): Update.
 404
 405 2019-08-13  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 408         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 409         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 410         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 411         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 412         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 413         ... here.
 414
 415 2019-08-13  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.h (struct tui_source_window_base)
 418         <update_exec_info>: Declare.
 419         (tui_update_exec_info): Don't declare.
 420         * tui/tui-winsource.c (tui_update_source_window_as_is)
 421         (tui_source_window_base::refresh_all)
 422         (tui_update_all_breakpoint_info): Update.
 423         (tui_source_window_base::update_exec_info): Rename from
 424         tui_update_exec_info.
 425         * tui/tui-stack.c (tui_show_frame_info): Update.
 426
 427 2019-08-13  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-winsource.h (struct tui_source_window_base)
 430         <set_exec_info_content>: Declare.
 431         (tui_set_exec_info_content): Don't declare.
 432         * tui/tui-winsource.c
 433         (tui_source_window_base::set_exec_info_content): Rename from
 434         tui_set_exec_info_content.
 435         (tui_update_exec_info): Update.
 436
 437 2019-08-13  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-winsource.h (struct tui_source_window_base)
 440         <show_source_content>: Declare.
 441         (tui_show_source_content): Don't declare.
 442         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 443         (tui_source_window_base::show_source_content): Rename from
 444         tui_show_source_content.
 445         (tui_source_window_base::refresh_all): Update.
 446         * tui/tui-layout.c (show_source_disasm_command)
 447         (show_source_or_disasm_and_command): Update.
 448
 449 2019-08-13  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-winsource.c (tui_erase_source_content)
 452         (tui_show_source_content, tui_source_window_base::refresh_all):
 453         Update.
 454         * tui/tui-wingeneral.h
 455         (tui_check_and_display_highlight_if_needed): Don't declare.
 456         * tui/tui-wingeneral.c
 457         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 458         check_and_display_highlight_if_needed.
 459         * tui/tui-win.c (tui_rehighlight_all)
 460         (tui_win_info::make_visible_with_new_height): Update.
 461         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 462         (tui_data_window::erase_data_content)
 463         (tui_data_window::display_all_data): Update.
 464         * tui/tui-data.h (struct tui_win_info)
 465         <check_and_display_highlight_if_needed>: Declare.
 466
 467 2019-08-13  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-win.c (tui_resize_all): Call
 470         tui_delete_invisible_windows.
 471         * tui/tui-layout.c (show_layout): Call
 472         tui_delete_invisible_windows.
 473         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 474         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 475
 476 2019-08-13  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 479         tui_add_win_to_layout.
 480
 481 2019-08-13  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 484         * tui/tui-layout.c (tui_default_win_height): Now static.
 485
 486 2019-08-13  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 489         single switch.
 490         (show_source_disasm_command, show_source_or_disasm_and_command):
 491         Don't check current layout.
 492
 493 2019-08-13  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-wingeneral.c (make_all_visible): Remove.
 496         (tui_make_all_invisible): Simplify.
 497         * tui/tui-layout.c (tui_make_all_invisible): Move from
 498         tui-wingeneral.c; simplify.
 499         (show_layout): Hoist call to tui_make_all_invisible.
 500         (show_data): Don't call tui_make_all_invisible.
 501
 502 2019-08-13  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 505         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 506
 507 2019-08-13  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 510         tui-data.c.
 511         (show_source_disasm_command, show_data)
 512         (show_source_or_disasm_and_command): Don't use
 513         tui_set_current_layout_to.
 514         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 515         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 516         tui-layout.c.
 517         (tui_set_current_layout_to): Remove.
 518
 519 2019-08-13  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-layout.c (tui_set_layout): Update.
 522         * tui/tui-data.h (struct tui_layout_def): Remove.
 523         (tui_layout_def): Don't declare.
 524         * tui/tui-data.c (layout_def): Remove.
 525         (tui_layout_def): Remove.
 526
 527 2019-08-13  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-winsource.h (struct tui_source_window_base)
 530         <clear_detail>: No longer "override".
 531         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 532         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 533         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 534         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 535         Remove.
 536         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 537
 538 2019-08-13  Tom Tromey  <tromey@adacore.com>
 539
 540         * tracepoint.c: Don't include readline.h or history.h.
 541
 542 2019-08-12  Tom Tromey  <tom@tromey.com>
 543
 544         * configure: Rebuild.
 545         * configure.ac: Check for readline 7.
 546         * NEWS: Mention readline 7 requirement.
 547         * README: Update.
 548
 549 2019-08-12  Tom Tromey  <tom@tromey.com>
 550
 551         * mingw-hdep.c (gdb_select): Remove readline hack.
 552
 553 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 554
 555         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 556         when the function fails.
 557
 558 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 559
 560         * s390-tdep.c (s390_type_align): New function.
 561         (s390_gdbarch_init): Set it as type_align gdbarch method.
 562
 563 2019-08-09  Tom de Vries  <tdevries@suse.de>
 564
 565         PR gdb/24591
 566         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 567         pc_low with relocation offset.
 568
 569 2019-08-07  Tom Tromey  <tromey@adacore.com>
 570
 571         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 572         (print_frame_args): Update.
 573         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 574         Update.
 575         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 576         * frame.h (struct frame_arg): Add initializers.
 577         <error>: Now a unique_xmalloc_ptr.
 578
 579 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 580
 581         * NEWS: Expand the Pointer Authentication entry.
 582         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 583         (aarch64_frame_unmask_lr): ... to this.
 584         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 585         Call aarch64_frame_unmask_lr.
 586         * frame.c (struct frame_info): Add "masked" variable.
 587         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 588         (fprint_frame): Check for masked pc.
 589         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 590         declarations.
 591         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 592         * stack.c (print_frame): Check for masked pc.
 593
 594 2019-08-06  Tom Tromey  <tom@tromey.com>
 595
 596         * stabsread.c (patch_block_stabs, read_one_struct_field)
 597         (read_enum_type): Use obstack_strndup.
 598         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 599         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 600         * dwarf2read.c (guess_full_die_structure_name)
 601         (anonymous_struct_prefix): Use obstack_strndup.
 602         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 603         * c-exp.y (yylex): Use obstack_strndup.
 604         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 605         (write_var_or_type): Use obstack_strndup.
 606
 607 2019-08-06  Tom Tromey  <tom@tromey.com>
 608
 609         * symfile.c (reread_symbols): Use obstack_strdup.
 610         * stabsread.c (read_type): Use obstack_strdup.
 611         * gdb_obstack.h (obstack_strdup): New overload.
 612         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 613         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 614         (dwarf2_canonicalize_name): Use obstack_strdup.
 615         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 616         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 617         Use obstack_strdup.
 618
 619 2019-08-06  Tom Tromey  <tom@tromey.com>
 620
 621         * gdb_obstack.h (obstack_strdup): Define.
 622         * gdb_obstack.c (obstack_strdup): Don't define.
 623
 624 2019-08-06  Tom Tromey  <tom@tromey.com>
 625
 626         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 627         obstack_strdup.
 628         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 629         obstack_strdup.
 630         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 631         * stabsread.c (common_block_start): Use obstack_strdup.
 632         * objfiles.c (set_objfile_main_name, objfile): Use
 633         obstack_strdup.
 634         * namespace.c (add_using_directive): Use obstack_strdup.
 635         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 636         * jit.c (finalize_symtab): Use obstack_strdup.
 637         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 638         (guess_partial_die_structure_name, partial_die_info::fixup)
 639         (dwarf2_name): Use obstack_strdup.
 640         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 641         obstack_strdup.
 642         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 643         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 644         obstack_strdup.
 645         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 646
 647 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 648
 649         * unittests/help-doc-selftests.c: New file.
 650         * Makefile.in: Add the new file.
 651
 652 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 653
 654         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 655         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 656         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 657         the trailing '.' is not output, and the first character is uppercased.
 658         (print_help_for_command): Update call to print_doc_line.
 659         (print_doc_of_command): Likewise.
 660         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 661         * cli/cli-option.c (append_indented_doc): Do not append newline.
 662         (build_help_option): Append newline after first appended_indented_doc
 663         only if a second call is done.
 664         (build_help): Append 2 new lines before each option, except the first
 665         one.
 666         * compile/compile.c (_initialize_compile): Add new lines after
 667         %OPTIONS%, when not at the end of the help.
 668         Change help doc or code
 669         producing the help doc to respect the invariants.
 670         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 671         Also removed the new line after 'Options:', as all other commands
 672         do not put an empty line between 'Options:' and the first option.
 673         * printcmd.c (_initialize_printcmd): Likewise.
 674         * stack.c (_initialize_stack): Likewise.
 675         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 676         incorrectly telling COMMAND is optional.
 677         * ada-lang.c (_initialize_ada_language): Change help doc or code
 678         producing the help doc to respect the invariants.
 679         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 680         * breakpoint.c (_initialize_breakpoint): Likewise.
 681         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 682         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 683         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 684         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 685         _initialize_cli_style): Likewise.
 686         * corelow.c (core_target_info): Likewise.
 687         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 688         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 689         * filesystem.c (_initialize_filesystem): Likewise.
 690         * frame.c (_initialize_frame): Likewise.
 691         * gnu-nat.c (add_task_commands): Likewise.
 692         * infcall.c (_initialize_infcall): Likewise.
 693         * infcmd.c (_initialize_infcmd): Likewise.
 694         * interps.c (_initialize_interpreter): Likewise.
 695         * language.c (_initialize_language): Likewise.
 696         * linux-fork.c (_initialize_linux_fork): Likewise.
 697         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 698         * maint.c (_initialize_maint_cmds): Likewise.
 699         * memattr.c (_initialize_mem): Likewise.
 700         * printcmd.c (_initialize_printcmd): Likewise.
 701         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 702         _RegEx): Likewise.
 703         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 704         * record-btrace.c (_initialize_record_btrace): Likewise.
 705         * record-full.c (_initialize_record_full): Likewise.
 706         * record.c (_initialize_record): Likewise.
 707         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 708         * regcache.c (_initialize_regcache): Likewise.
 709         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 710         _initialize_remote): Likewise.
 711         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 712         * serial.c (_initialize_serial): Likewise.
 713         * skip.c (_initialize_step_skip): Likewise.
 714         * source.c (_initialize_source): Likewise.
 715         * stack.c (_initialize_stack): Likewise.
 716         * symfile.c (_initialize_symfile): Likewise.
 717         * symtab.c (_initialize_symtab): Likewise.
 718         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 719         * top.c (init_main): Likewise.
 720         * tracefile-tfile.c (tfile_target_info): Likewise.
 721         * tracepoint.c (_initialize_tracepoint): Likewise.
 722         * tui/tui-win.c (_initialize_tui_win): Likewise.
 723         * utils.c (add_internal_problem_command): Likewise.
 724         * valprint.c (value_print_option_defs): Likewise.
 725
 726 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 727
 728         PR build/24886
 729         * configure.ac: Drop enable-libmcheck support.
 730         * configure, config.in: Rebuild.
 731         * libmcheck.m4: Remove.
 732         * acinclude.m4: Don't include it.
 733         * Makefile.in: Don't distribute it.
 734         * top.c (print_gdb_configuration): Don't mention it.
 735
 736 2019-08-06  Tom Tromey  <tom@tromey.com>
 737
 738         * utils.c (set_output_style): Sometimes pass stream to
 739         emit_style_escape.
 740         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 741         * record-btrace.c (btrace_insn_history): Update.
 742         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 743         method.
 744         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 745         Update initializers.
 746         <m_uiout>: New field.
 747         <m_di>: Move lower.
 748         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 749         Remove "uiout" parameter.
 750         (dump_insns): Update.
 751         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 752         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 753
 754 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 755
 756         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 757         (error_in_psymtab_expansion): Likewise.
 758         (lookup_symbol_via_quick_fns): Likewise.
 759         (basic_lookup_transparent_type_quick): Likewise.
 760         (basic_lookup_transparent_type_1): Likewise.
 761
 762 2019-08-06  Tom Tromey  <tromey@adacore.com>
 763
 764         * source.c (last_source_error): Now bool.
 765         (print_source_lines_base): Make "noprint" bool.  Only open
 766         source file when last_source_visited changes.
 767
 768 2019-08-06  Tom Tromey  <tromey@adacore.com>
 769
 770         * annotate.c (annotate_source_line): Use g_source_cache.
 771         * source-cache.c (source_cache::get_plain_source_lines): Change
 772         parameters.  Populate m_offset_cache.
 773         (source_cache::ensure): New method.
 774         (source_cache::get_line_charpos): New method.
 775         (extract_lines): Move lower.  Change parameters.
 776         (source_cache::get_source_lines): Move lower.
 777         * source-cache.h (class source_cache): Update comment.
 778         <get_line_charpos>: New method.
 779         <get_source_lines>: Update comment.
 780         <clear>: Clear m_offset_cache.
 781         <get_plain_source_lines>: Change parameters.
 782         <ensure>: New method
 783         <m_offset_cache>: New member.
 784         * source.c (forget_cached_source_info_for_objfile): Update.
 785         (info_source_command): Use g_source_cache.
 786         (find_source_lines, open_source_file_with_line_charpos): Remove.
 787         (print_source_lines_base, search_command_helper): Use g_source_cache.
 788         * source.h (open_source_file_with_line_charpos): Don't declare.
 789         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 790         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 791         Use g_source_cache.
 792
 793 2019-08-06  Tom Tromey  <tromey@adacore.com>
 794
 795         * source-cache.c (source_cache::get_plain_source_lines):
 796         Remove "first_line" and "last_line" parameters.
 797         (source_cache::get_source_lines): Cache plain text.
 798         * source-cache.h (class source_cache)
 799         <get_plain_source_lines>: Update.
 800
 801 2019-08-06  Tom Tromey  <tromey@adacore.com>
 802
 803         * source-cache.c (extract_lines): No longer a method.
 804         Changed type of parameter.  Include final newline.
 805         (selftests::extract_lines_test): New function.
 806         (_initialize_source_cache): Likewise.
 807         * source-cache.h (class source_cache)
 808         <extract_lines>: Don't declare.
 809
 810 2019-08-06  Tom Tromey  <tromey@adacore.com>
 811
 812         * breakpoint.c (init_breakpoint_sal): Update.
 813         (breakpoint): Update.
 814         * breakpoint.h (struct breakpoint) <filter>: Now a
 815         unique_xmalloc_ptr.
 816
 817 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 818
 819         * NEWS: Mention dictionary access on blocks.
 820         * python/py-block.c (blpy_getitem): New function.
 821         (block_object_as_mapping): New struct.
 822         (block_object_type): Use new struct for tp_as_mapping field.
 823
 824 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 825
 826         * objfiles.h (objfile): Add a comment describing partial symbols.
 827
 828 2019-08-05  Tom Tromey  <tromey@adacore.com>
 829
 830         * compile/compile.c (_initialize_compile): Use _(), not N_().
 831         * thread.c (_initialize_thread): Use _(), not N_().
 832         * stack.c (_initialize_stack): Use _(), not N_().
 833         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 834
 835 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 836
 837         * dwarf2read.c (struct dw2_symtab_iterator):
 838         <want_specific_block>: Remove.
 839         <block_index>: Change type to gdb::optional.
 840         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 841         change type of BLOCK_INDEX parameter to gdb::optional.
 842         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 843         (dw2_lookup_symbol): Don't pass argument for
 844         WANT_SPECIFIC_BLOCK.
 845         (dw2_expand_symtabs_for_function): Don't pass argument for
 846         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 847         (class dw2_debug_names_iterator)
 848         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 849         parameter, change BLOCK_INDEX type to gdb::optional.
 850         <m_want_specific_block>: Remove.
 851         <m_block_index>: Change type to gdb::optional.
 852         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 853         gdb::optional.  Re-write in function of gdb::optional.
 854         (dw2_debug_names_lookup_symbol): Don't pass argument for
 855         WANT_SPECIFIC_BLOCK.
 856         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 857         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 858         BLOCK_INDEX.
 859
 860 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 861
 862         * NEWS: Mention changes to "info sources" command.
 863
 864 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * symtab.c (filename_partial_match_opts): New struct type.
 867         (struct output_source_filename_data): New members
 868         regexp, c_regexp, partial_match.
 869         (output_source_filename): Use new members to decide to print file.
 870         (info_sources_option_defs): New variable.
 871         (make_info_sources_options_def_group, print_info_sources_header,
 872         info_sources_command_completer):
 873         New functions.
 874         (info_sources_command): Read new optional arguments.
 875         (_initialize_symtab): Update info sources help.
 876
 877 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 878
 879         * ada-lang.c (exception_support_info_v0): Renamed from...
 880         (default_exception_support_info): ... this.  Create new
 881         definition for v1.
 882         (ada_has_this_exception_support): Look up catch_handlers_sym.
 883         (ada_exception_support_info_sniffer): Try v0 after default.
 884
 885 2019-08-01  Tom Tromey  <tromey@adacore.com>
 886
 887         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 888         gdbarch.h.
 889
 890 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 891
 892         * s12z-tdep.c: Fix include path for s12z-opc.h.
 893
 894 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 895
 896         * NEWS: Require GNU make 3.82.
 897
 898 2019-07-16  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 901         declare.
 902
 903 2019-07-30  Tom Tromey  <tromey@adacore.com>
 904
 905         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 906
 907 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 908
 909         * printcmd.c (print_address_symbolic): Print negative offsets.
 910         (build_address_symbolic): Force signed arithmetic when computing
 911         offset.
 912
 913 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 914
 915         PR/24474: Add a function to lookup static variables.
 916         * NEWS: Mention this new function.
 917         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 918         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 919         * python/python.c (python_GdbMethods): Add new function.
 920
 921 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 922
 923         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 924         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 925         (objfpy_lookup_static_symbol): New function.
 926         (objfile_object_methods): Add new functions.
 927
 928 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 929
 930         * NEWS: Mention 'set|show print frame-info'.  Mention new
 931         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 932         backtrace argument.  Mention that python frame filtering code
 933         is now consistent with what 'backtrace' command prints.
 934
 935 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 936
 937         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 938         comments.
 939         (print_frame_info_auto, print_frame_info_source_line,
 940         print_frame_info_location, print_frame_info_source_and_location,
 941         print_frame_info_location_and_address, print_frame_info_short_location):
 942         New declarations.
 943         (struct frame_print_options): New member print_frame_info.
 944         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 945         * stack.h (get_user_print_what_frame_info): New declaration.
 946         (frame_show_address): New declaration.
 947         * stack.c (print_frame_arguments_choices): New value 'presence'.
 948         (print_frame_info_auto, print_frame_info_source_line,
 949         print_frame_info_location, print_frame_info_source_and_location,
 950         print_frame_info_location_and_address, print_frame_info_short_location,
 951         print_frame_info_choices, print_frame_info_print_what): New definitions.
 952         (print_frame_args): Only print dots for args if print frame-arguments
 953         is 'presence'.
 954         (frame_print_option_defs): New element for "frame-info".
 955         (get_user_print_what_frame_info): New function.
 956         (frame_show_address): Make non static.  Move comment to stack.h.
 957         (print_frame_info_to_print_what): New function.
 958         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 959         to decide what to print.
 960         (backtrace_command_1): Handle the new print_frame_arguments_presence
 961         value.
 962         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 963         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 964         (py_print_frame): In non-mi mode, use LOCATION as default for
 965         print_what, similarly to frame information printed directly by
 966         backtrace command. Handle frame-info user option in non MI mode.
 967
 968 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 969
 970         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 971         Add case for debugging 32-bit target on 64-bit host.  Revise
 972         comment.
 973
 974 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 975
 976         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 977         instead of find_function_entry_range_from_pc.
 978
 979 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 980
 981         * stack.c (find_frame_funname): Remove code which preferred
 982         minsym over symtab sym in "certain pathological cases".
 983
 984         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 985         parameter.  Change type of "do_demangle" to bool.
 986         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 987         Pass suitable "prefer_sym_over_minsym" flag to
 988         build_address_symbolic().  Don't output "+" for negative offsets.
 989         * printcmd.c (print_address_symbolic): Update invocation of
 990         build_address_symbolic to include a "prefer_sym_over_minsym"
 991         flag.
 992         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 993         Restrict cases in which use of minimal symbol is preferred to that
 994         of a found symbol.  Update comments.
 995
 996         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 997         for entry pc when entry pc is out of range for that FDE.
 998
 999 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1000
1001         PR gdb/24839:
1002         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1003         type.
1004
1005 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1008         this function's Python signature.
1009
1010
1011 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1012
1013         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1014         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1015         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1016         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1017         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1018
1019
1020 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1021
1022         * h8300-tdep.c (h8300_register_name_common): New.
1023         h8300_register_name): Use h8300_register_name_common.
1024         (h8300s_register_name): Likewise.
1025         (h8300sx_register_name): Likewise.
1026         (h8300h_register_nam): New.
1027         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1028
1029
1030 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1031
1032         * arm-tdep.c (arm_skip_cmse_entry): New function.
1033         (arm_is_sgstubs_section): New function.
1034         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1035
1036 2019-07-22  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1039         Don't self-assign.
1040
1041 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1042
1043         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1044         type_print.
1045
1046 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1049         so that GDB doesn't match any msymbols when searching in the
1050         TYPES_DOMAIN.
1051         (print_symbol_info): Print using typedef_print or type_print based
1052         on the type of the symbol.  Add updated FIXME comment moved from...
1053         (_initialize_symtab): ... move and update FIXME comment to above.
1054
1055 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         * NEWS: Mention adding -q option to "info types".
1058         * symtab.c (struct info_types_options): New struct.
1059         (info_types_options_defs): New variable.
1060         (make_info_types_options_def_group): New function.
1061         (info_types_command): Use gdb::option framework to parse options.
1062         (info_types_command_completer): New function.
1063         (_initialize_symtab): Extend the help text on "info types" and
1064         register command completer.
1065
1066 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1067
1068         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1069         (lookup_symbol_in_objfile): Change int to block_enum and add a
1070         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1071
1072 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1073
1074         * MAINTAINERS (Write After Approval): Add self.
1075
1076 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1077
1078         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1079         instruction to the dummy code region.
1080
1081 2019-07-19  Tom Tromey  <tromey@adacore.com>
1082
1083         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1084         (ARGSUSED, PARAMS, __func__): Remove rules.
1085
1086 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1087
1088         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1089         * features/arm/arm-with-iwmmxt.c: Remove.
1090         * features/arm/arm-with-iwmmxt.xml: Remove.
1091         * features/arm/arm-with-m-fpa-layout.c: Remove.
1092         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1093         * features/arm/arm-with-m-vfp-d16.c: Remove.
1094         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1095         * features/arm/arm-with-m.c: Remove.
1096         * features/arm/arm-with-m.xml: Remove.
1097         * features/arm/arm-with-neon.c: Remove.
1098         * features/arm/arm-with-neon.xml: Remove.
1099         * features/arm/arm-with-vfpv2.c: Remove.
1100         * features/arm/arm-with-vfpv2.xml: Remove.
1101         * features/arm/arm-with-vfpv3.c: Remove.
1102         * features/arm/arm-with-vfpv3.xml: Remove.
1103
1104 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1105
1106         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1107
1108 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1109
1110         * arch/aarch32.c (aarch32_create_target_description): Create
1111         target descriptions using features.
1112         * arch/arm.c (arm_create_target_description)
1113         (arm_create_mprofile_target_description): Likewise.
1114         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1115
1116 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1117
1118         * Makefile.in: Add new files.
1119         * aarch32-tdep.c: New file.
1120         * aarch32-tdep.h: New file.
1121         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1122         Call aarch32_read_description.
1123         * arch/aarch32.c: New file.
1124         * arch/aarch32.h: New file.
1125         * arch/arm.c (arm_create_target_description)
1126         (arm_create_mprofile_target_description): New function.
1127         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1128         (arm_create_target_description)
1129         (arm_create_mprofile_target_description): New declaration.
1130         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1131         read_description functions.
1132         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1133         Likewise.
1134         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1135         * arm-tdep.c (tdesc_arm_list): New variable.
1136         (arm_register_g_packet_guesses): Call create description functions.
1137         (arm_read_description) (arm_read_mprofile_description): New
1138         function.
1139         * arm-tdep.h (arm_read_description)
1140         (arm_read_mprofile_description): Add declaration.
1141         * configure.tgt: Add new files.
1142
1143 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1144
1145         * top.c (new_ui_command): Open specified terminal just once.
1146
1147 2019-07-18  Tom Tromey  <tromey@adacore.com>
1148
1149         * symtab.c (main_name): Constify return type.
1150         * symfile.c (set_initial_language): Update.
1151         * symtab.h (main_name): Constify return type.
1152
1153 2019-07-17  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-winsource.c (tui_update_source_window)
1156         (tui_update_source_window_as_is)
1157         (tui_update_source_windows_with_line): Remove return.
1158         * tui/tui-disasm.c (tui_show_disassem)
1159         (tui_show_disassem_and_update_source): Remove return.
1160         * tui/tui.c (tui_reset): Remove return.
1161         * tui/tui-wingeneral.c
1162         (tui_check_and_display_highlight_if_needed): Remove return.
1163
1164 2019-07-17  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-winsource.h (struct tui_exec_info_window)
1171         (struct tui_source_window_base): Move from tui-data.h.
1172         * tui/tui-winsource.c: Move many method definitions from
1173         elsewhere.  Remove "structuring" comments.
1174         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1175         (tui_source_window_base::refresh_window): Move to
1176         tui-winsource.c.
1177         * tui/tui-win.c (tui_source_window_base::refresh_all)
1178         (tui_source_window_base::update_tab_width)
1179         (tui_source_window_base::set_new_height)
1180         (tui_source_window_base::do_make_visible_with_new_height): Move to
1181         tui-winsource.c.
1182         * tui/tui-source.h: Update.
1183         * tui/tui-source.c (tui_source_window_base::reset): Move to
1184         tui-winsource.c.
1185         * tui/tui-disasm.h: Update.
1186         * tui/tui-data.h (struct tui_exec_info_window): Move to
1187         tui-winsource.h.
1188         (struct tui_source_window_base): Likewise.
1189         * tui/tui-data.c (tui_source_window_base::clear_detail)
1190         (tui_source_window_base, ~tui_source_window_base): Move to
1191         tui-winsource.c.
1192
1193 2019-07-17  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-win.c (tui_resize_all)
1196         (tui_source_window_base::update_tab_width)
1197         (tui_adjust_win_heights): Update.
1198         (tui_win_info::make_invisible_and_set_new_height): Rename from
1199         make_invisible_and_set_new_height.
1200         * tui/tui-data.h (struct tui_win_info)
1201         <make_invisible_and_set_new_height>: New method.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui.c: Update.
1206         * tui/tui-source.h (struct tui_source_window): Move from
1207         tui-data.h.
1208         * tui/tui-layout.c: Update.
1209         * tui/tui-disasm.c: Update.
1210         * tui/tui-data.h (struct tui_source_window): Move to
1211         tui-source.h.
1212
1213 2019-07-17  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1216         tui-data.h.
1217         * tui/tui-data.h (struct tui_disasm_window): Move to
1218         tui-disasm.h.
1219
1220 2019-07-17  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-regs.h (struct tui_data_item_window): Move from
1223         tui-data.h.
1224         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1225         * tui/tui-data.h (struct tui_data_item_window): Move to
1226         tui-regs.h.
1227         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1228
1229 2019-07-17  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui.c: Update.
1232         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1233         (tui_cmd_window::max_height): Move to tui-command.c.
1234         * tui/tui-layout.c: Update.
1235         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1236         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1237         tui-command.c.
1238         * tui/tui-command.h (struct tui_cmd_window): Move from
1239         tui-data.h.
1240         * tui/tui-command.c: Remove "structuring" comments.
1241         (tui_cmd_window::clear_detail)
1242         (tui_cmd_window::do_make_visible_with_new_height)
1243         (tui_cmd_window::max_height): Move from elsewhere.
1244
1245 2019-07-17  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1248         Now static.
1249         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1250         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1251
1252 2019-07-17  Tom Tromey  <tom@tromey.com>
1253
1254         * tui/tui.c: Update.
1255         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1256         tui-regs.c.
1257         * tui/tui-windata.h: Remove file.
1258         * tui/tui-windata.c: Remove file.
1259         * tui/tui-win.c (tui_data_window::set_new_height)
1260         (tui_data_window::do_make_visible_with_new_height): Move to
1261         tui-regs.c.
1262         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1263         * tui/tui-regs.c: Remove "structuring" comments.
1264         (tui_data_window::first_data_item_displayed)
1265         (tui_data_window::delete_data_content_windows)
1266         (tui_data_window::erase_data_content)
1267         (tui_data_window::display_all_data)
1268         (tui_data_window::refresh_all)
1269         (tui_data_window::do_scroll_vertical)
1270         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1271         (tui_data_window::do_make_visible_with_new_height)
1272         (tui_data_window::refresh_window): Move from elsewhere.
1273         (_initialize_tui_regs): Move to end of file.
1274         * tui/tui-layout.c: Update.
1275         * tui/tui-hooks.c: Update.
1276         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1277         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1278         tui-regs.c.
1279         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1280
1281 2019-07-17  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1284         seen.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-win.c (tui_source_window_base::set_new_height)
1289         (tui_source_window_base::do_make_visible_with_new_height): Use
1290         m_has_locator field directly.
1291         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1292         method.
1293         (struct tui_source_window_base) <has_locator>: Likewise.
1294
1295 2019-07-17  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1298         Don't declare.
1299         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1300         Remove.
1301         * tui/tui-win.c (tui_source_window_base::set_new_height)
1302         (tui_source_window_base::set_new_height)
1303         (make_invisible_and_set_new_height)
1304         (tui_source_window_base::do_make_visible_with_new_height)
1305         (tui_source_window_base::do_make_visible_with_new_height):
1306         Update.
1307         * tui/tui-layout.c (show_source_disasm_command, show_data)
1308         (show_source_or_disasm_and_command): Update.
1309         * tui/tui-layout.c (show_layout): Update.
1310
1311 2019-07-17  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-layout.c (make_data_window): Remove.
1314         (show_data): Unify creation and re-initialization cases.
1315
1316 2019-07-17  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-layout.c (make_source_window, make_disasm_window):
1319         Remove.
1320         (show_data): Unify creation and re-initialization cases.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-layout.c (make_command_window): Remove.
1325         (show_source_disasm_command, show_source_or_disasm_and_command):
1326         Unify creation and re-initialization cases.
1327
1328 2019-07-17  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1331         creation and re-initialization cases.
1332
1333 2019-07-17  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-regs.c (tui_get_register): Return void.
1336
1337 2019-07-17  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1340         Simplify.
1341
1342 2019-07-17  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1345         resetting.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1350         * tui/tui-regs.c (tui_reg_layout): New function.
1351         (tui_show_registers, tui_reg_command): Use it.
1352         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1353         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1354         parameters.
1355         (tui_layout_command): Remove.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-layout.h (tui/tui-layout): Return void.
1360         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1361
1362 2019-07-17  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-layout.c (show_source_disasm_command, show_data):
1365         Update.
1366         (reset_locator): Remove.
1367         (show_source_or_disasm_and_command): Update.
1368
1369 2019-07-17  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-source.c (tui_source_window_base::reset): Remove
1372         win_type parameter.
1373         * tui/tui-layout.c (make_command_window, make_source_window)
1374         (make_disasm_window, make_data_window)
1375         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1376         (reset_locator, show_source_or_disasm_and_command): Update.
1377         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1378         win_type parameter.
1379         (struct tui_source_window_base) <reset>: Likewise.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-layout.c (show_source_disasm_command): Use
1384         reset_locator.
1385         (reset_locator): New function.
1386         (init_and_make_win): Remove.
1387         (show_source_or_disasm_and_command): Use reset_locator.
1388
1389 2019-07-17  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1392         condition.
1393         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1394         Remove condition.
1395         * tui/tui-source.c (tui_source_window_base::reset): New method.
1396         * tui/tui-layout.c (make_command_window): Don't call
1397         init_and_make_win.
1398         (make_source_window, make_disasm_window): Don't call
1399         make_source_or_disasm_window.
1400         (make_data_window): Don't call init_and_make_win.  Change calling
1401         convention.
1402         (show_source_disasm_command, show_data): Simplify.
1403         (make_source_or_disasm_window): Remove.
1404         (show_source_or_disasm_and_command): Simplify.
1405         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1406         (struct tui_source_window_base) <reset>: Likewise.
1407         <execution_info>: Remove initializer.
1408         * tui/tui-data.c (tui_source_window_base): Initialize
1409         execution_info.
1410
1411 2019-07-17  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1414         variable.
1415
1416 2019-07-17  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui.c (tui_rl_other_window): Update.
1419         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1420         superclass method first.  Always iterate over regs_content.
1421         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1422         method.
1423         * tui/tui-win.c (tui_set_focus_command): Update.
1424
1425 2019-07-17  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-win.c (tui_set_focus_command): Rename from
1428         tui_set_focus.  Call tui_enable.
1429         (tui_set_focus_command): Remove.
1430
1431 2019-07-17  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1434         refresh_window.
1435         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1436         touchwin.
1437         (tui_data_window::refresh_window): Call refresh_window on data
1438         items.  Always call superclass refresh_window.
1439         (tui_win_info::refresh): Remove.
1440         (tui_source_window_base::refresh_window): Update.
1441         (tui_refresh_all): Update.
1442         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1443         refresh_window.
1444         (show_source_or_disasm_and_command): Likewise.
1445         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1446         (struct tui_source_window_base) <refresh>: Likewise.
1447
1448 2019-07-17  Tom Tromey  <tom@tromey.com>
1449
1450         * tui/tui-winsource.c (tui_clear_source_content)
1451         (tui_show_source_content): Update.
1452         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1453         whether content is empty.
1454         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1455         Remove.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1460         window's contents.
1461         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1462         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1467         (struct tui_data_item_window): Update.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1472         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1473         defines.
1474
1475 2019-07-17  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-winsource.h (tui_erase_source_content)
1478         (tui_clear_source_content): Remove "display_prompt" parameter.
1479         * tui/tui-winsource.c (tui_update_source_window_as_is)
1480         (tui_update_source_windows_with_addr): Update.
1481         (tui_clear_source_content): Remove "display_prompt" parameter.
1482         (tui_erase_source_content): Likewise.  Simplify.
1483         (tui_show_source_content): Update.
1484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1485         * tui/tui-stack.c (tui_show_frame_info): Update.
1486         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1487         Remove defines.
1488
1489 2019-07-17  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1492         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1493         parameter.
1494         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1495         parameter.
1496
1497 2019-07-17  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-winsource.c (tui_clear_source_content)
1500         (tui_show_source_content, tui_show_exec_info_content)
1501         (tui_clear_exec_info_content): Update.
1502         * tui/tui-stack.c (tui_show_locator_content): Update.
1503         (tui_show_frame_info): Update.
1504         * tui/tui-source.h (tui_source_window): Don't declare.
1505         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1506         from tui_source_is_displayed.
1507         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1508         Remove field.
1509         (struct tui_source_window_base) <content_in_use>: New field.  Now
1510         bool.
1511         (struct tui_source_window) <showing_source_p>: New method.
1512         (TUI_SRC_WIN): Change cast.
1513         * tui/tui-data.c (tui_initialize_static_data): Update.
1514
1515 2019-07-17  Tom Tromey  <tom@tromey.com>
1516
1517         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1518         location_matches_p.
1519         * tui/tui-source.c (tui_source_window::location_matches_p): New
1520         method.
1521         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1522         method.
1523         * tui/tui-data.h (struct tui_source_window_base)
1524         <location_matches_p>: New method.
1525         (struct tui_source_window, struct tui_disasm_window)
1526         <location_matches_p>: Likewise.
1527
1528 2019-07-17  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-win.c (tui_set_win_height_command): Rename from
1531         tui_set_win_height.
1532         (tui_set_win_height_command): Remove.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-source.c (tui_source_window): New constructor.  Add
1537         observer.
1538         (~tui_source_window): New destructor.
1539         (tui_source_window::style_changed): New method.
1540         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1541         (tui_attach_detach_observers): Update.
1542         * tui/tui-data.h (struct tui_source_window): Make constructor not
1543         inline.  Add destructor.
1544         (struct tui_source_window) <style_changed>: New method.
1545         <m_observable>: New member.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1550         * tui/tui-win.c (tui_resize_all): Fix typo.
1551
1552 2019-07-17  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1555         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1556         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1557         * tui/tui-win.c (window_name_completer): Use foreach.
1558         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1559         (update_tab_width): Likewise.
1560         * tui/tui-layout.c (show_layout): Update.
1561         * tui/tui-data.h (class tui_window_iterator): New.
1562         (struct all_tui_windows): New.
1563         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1564
1565 2019-07-17  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1568         parameter.  Don't reference globals.
1569         (tui_reg_command): Update.
1570
1571 2019-07-17  Tom Tromey  <tom@tromey.com>
1572
1573         * tui/tui-regs.c (tui_show_registers): Simplify.
1574
1575 2019-07-17  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-regs.c (tui_show_registers): Update.
1578         (tui_show_register_group): Add win_info parameter.
1579
1580 2019-07-17  Tom Tromey  <tom@tromey.com>
1581
1582         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1583         Rename from tui_display_reg_element_at_line.
1584         (tui_data_window::display_registers_from_line): Update.
1585         * tui/tui-data.h (struct tui_data_window)
1586         <display_reg_element_at_line>: New method.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-regs.h (tui_display_registers_from)
1591         (tui_display_registers_from_line): Don't declare.
1592         * tui/tui-windata.c (tui_data_window::display_all_data)
1593         (tui_data_window::refresh_all)
1594         (tui_data_window::do_scroll_vertical): Update.
1595         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1596         from tui_display_registers_from.
1597         (tui_display_reg_element_at_line): Update.
1598         (tui_data_window::display_registers_from_line): Rename from
1599         tui_display_registers_from_line.
1600         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1601         display_registers_from_line>: New methods.
1602
1603 2019-07-17  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1606         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1607         from tui_erase_data_content.
1608         (tui_data_window::display_all_data)
1609         (tui_data_window::refresh_all)
1610         (tui_data_window::do_scroll_vertical): Update.
1611         * tui/tui-regs.c (tui_show_registers): Update.
1612         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1613         New method.
1614
1615 2019-07-17  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1618         declare.
1619         * tui/tui-windata.c
1620         (tui_data_window::delete_data_content_windows): Rename from
1621         tui_delete_data_content_windows.
1622         (tui_data_window::display_all_data)
1623         (tui_data_window::do_scroll_vertical): Update.
1624         * tui/tui-data.h (struct tui_data_window)
1625         <delete_data_content_windows>: New method.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1630         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1635         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1636         from tui_display_all_data.
1637         * tui/tui-win.c
1638         (tui_data_window::do_make_visible_with_new_height): Update.
1639         * tui/tui-regs.c (tui_show_registers): Update.
1640         * tui/tui-layout.c (tui_set_layout): Update.
1641         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1642         method.
1643
1644 2019-07-17  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1647         * tui/tui-windata.c (tui_display_data_from): Remove.
1648         (tui_data_window::refresh_all): Update.
1649
1650 2019-07-17  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1653         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1654         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1655         tui_display_registers_from_line.
1656         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1657         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1658         "force_display" parameter.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1663         declare.
1664         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1665         Rename from tui_first_reg_element_no_inline.
1666         (tui_display_reg_element_at_line)
1667         (tui_display_registers_from_line): Update.
1668         * tui/tui-data.h (struct tui_data_window)
1669         <first_reg_element_no_inline>: New method.
1670
1671 2019-07-17  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-windata.c (tui_display_data_from)
1674         (tui_data_window::do_scroll_vertical): Update.
1675         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1676         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1677         Rename from tui_line_from_reg_element_no.
1678         (tui_display_registers_from_line): Update.
1679         * tui/tui-data.h (struct tui_data_window)
1680         <line_from_reg_element_no>: New method.
1681
1682 2019-07-17  Tom Tromey  <tom@tromey.com>
1683
1684         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1685         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1686         tui_last_regs_line_no.
1687         (tui_display_reg_element_at_line)
1688         (tui_display_registers_from_line): Update.
1689         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1690         method.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         PR tui/24722:
1695         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1696         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1697         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1698         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1699         (tui_update_breakpoint_info): Likewise.
1700         * tui/tui-hooks.c (tui_event_create_breakpoint)
1701         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1702         Update.
1703
1704 2019-07-17  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-winsource.c (tui_update_source_window_as_is)
1711         (tui_update_source_windows_with_addr): Update.
1712         * tui/tui-source.h (tui_set_source_content)
1713         (tui_show_symtab_source): Add "win_info" parameter.
1714         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1715         parameter.
1716         (tui_show_symtab_source): Likewise.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-wingeneral.c
1721         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1726         (struct tui_cmd_window) <can_scroll>: New method.
1727         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1728         method.
1729
1730 2019-07-17  Tom Tromey  <tromey@adacore.com>
1731
1732         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1733         do_field_signed>: Rename.  Change type of "value".
1734         * ui-out.c (ui_out::field_signed): Rename from field_int.
1735         Change type of "value".
1736         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1737         type of "value".
1738         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1739         do_field_int.  Change type of "value".
1740         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1741         do_field_int.  Change type of "value".
1742         * tracepoint.c (trace_status_mi, tfind_1)
1743         (print_one_static_tracepoint_marker): Update.
1744         * thread.c (print_thread_info_1, print_selected_thread_frame):
1745         Update.
1746         * stack.c (print_frame, print_frame_info): Update.
1747         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1748         Update.
1749         * source.c (print_source_lines_base): Update.
1750         * skip.c (info_skip_command): Update.
1751         * record-btrace.c (btrace_ui_out_decode_error)
1752         (btrace_call_history_src_line): Update.
1753         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1754         Update.
1755         * progspace.c (print_program_space): Update.
1756         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1757         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1758         do_field_int.  Change type of "value".
1759         * mi/mi-out.c (mi_ui_out::do_table_begin)
1760         (mi_ui_out::do_table_header): Update.
1761         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1762         type of "value".
1763         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1764         (mi_cmd_data_list_changed_registers, output_register)
1765         (mi_cmd_data_read_memory, mi_load_progress)
1766         (mi_cmd_trace_frame_collected): Update.
1767         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1768         Update.
1769         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1770         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1771         (mi_cmd_var_list_children, varobj_update_one): Update.
1772         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1773         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1774         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1775         * inferior.c (print_inferior): Update.
1776         * gdb_bfd.c (print_one_bfd): Update.
1777         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1778         Update.
1779         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1780         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1781         do_field_int.  Change type of "value".
1782         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1783         do_field_int.  Change type of "value".
1784         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1785         (print_one_breakpoint_location, print_it_catch_fork)
1786         (print_one_catch_fork, print_it_catch_vfork)
1787         (print_one_catch_vfork, print_it_catch_solib)
1788         (print_it_catch_exec, print_it_ranged_breakpoint)
1789         (print_mention_watchpoint, print_mention_masked_watchpoint)
1790         (bkpt_print_it, update_static_tracepoint): Update.
1791         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1792         * break-catch-syscall.c (print_it_catch_syscall): Update.
1793         * ada-tasks.c (print_ada_task_info): Update.
1794         * ada-lang.c (print_it_exception, print_mention_exception):
1795         Update.
1796
1797 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1798
1799         PR breakpoints/24541
1800         * gdbarch.c: Regenerate.
1801         * gdbarch.h: Regenerate.
1802         * gdbarch.sh: Adjust return type and parameter types for
1803         'stap_adjust_register'.
1804         (i386_stap_adjust_register): Adjust signature and return new
1805         register name.
1806         * stap-probe.c (stap_parse_register_operand): Adjust use of
1807         'gdbarch_stap_adjust_register'.
1808
1809 2019-07-17  Tom Tromey  <tromey@adacore.com>
1810
1811         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1812         declare VEC.
1813         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1814         std::vector.
1815         (struct s390_process_info): Add initializers.
1816         (s390_add_process): Use new.
1817         (s390_linux_nat_target::low_forget_process): Use delete.
1818         (s390_linux_nat_target::low_new_fork)
1819         (s390_linux_nat_target::stopped_by_watchpoint)
1820         (s390_linux_nat_target::low_prepare_to_resume)
1821         (s390_linux_nat_target::insert_watchpoint)
1822         (s390_linux_nat_target::insert_hw_breakpoint)
1823         (s390_linux_nat_target::remove_watchpoint)
1824         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1825
1826 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1827
1828         * aarch64-fbsd-nat.c: Include regcache.h.
1829         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1830         argument.
1831         (aarch64_fbsd_nat_target::fetch_registers)
1832         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1833         variable.
1834         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1835
1836 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1837
1838         * fbsd-nat.c: Include gdbarch.h.
1839
1840 2019-07-15  Tom Tromey  <tromey@adacore.com>
1841
1842         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1843
1844 2019-07-15  Tom Tromey  <tromey@adacore.com>
1845
1846         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1847         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1848         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1849         * cli-out.c (cli_ui_out::do_field_int): New method.
1850         * ui-out.c (ui_out::field_unsigned): New method.
1851         * symfile.c (generic_load): Use field_unsigned.
1852         (print_transfer_performance): Likewise.
1853         * record-btrace.c (ui_out_field_uint): Remove.
1854         (btrace_call_history_insn_range, btrace_call_history): Use
1855         field_unsigned.
1856         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1857         field_unsigned.
1858         * ui-out.h (class ui_out) <field_unsigned>: New method.
1859         <do_field_unsigned>: Likewise.
1860
1861 2019-07-15  Tom Tromey  <tromey@adacore.com>
1862
1863         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1864         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1865         * target.c (flash_erase_command): Use field_string.
1866         * infrun.c (print_signal_received_reason): Use field_string.
1867         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1868         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1869         field_string.
1870         * ada-tasks.c (print_ada_task_info): Use field_string.
1871
1872 2019-07-15  Tom Tromey  <tromey@adacore.com>
1873
1874         * target.c (flash_erase_command): Use field_core_addr.
1875         * symfile.c (generic_load): Use field_core_addr.
1876         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1877         Use field_core_addr.
1878         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1879         field_core_addr.
1880
1881 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1882
1883         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1884         value if its desired type is smaller than a CORE_ADDR and signed.
1885
1886 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1889         of changes to field names, and use new is_reference field to
1890         decide if a property is a reference or not.
1891         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1892         field.
1893         (struct dwarf2_property_baton): Update header comment, rename
1894         'referenced_type' to 'property_type' and update comments.
1895         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1896         default property type, store in property baton, update to take
1897         accound of renamed field.
1898         (read_func_scope): Update call to attr_to_dynamic_prop.
1899         (read_array_type): Likewise.
1900         (dwarf2_per_cu_addr_sized_int_type): New function.
1901         (read_subrange_index_type): Move type finding code to
1902         dwarf2_per_cu_addr_sized_int_type.
1903         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1904         (dwarf2_per_cu_addr_type): New function.
1905         (set_die_type): Update calls to attr_to_dynamic_prop.
1906
1907 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1908
1909         * dwarf2read.c (read_subrange_index_type): New function.
1910         (read_subrange_type): Move code into new function and call it.
1911         * gdbtypes.c (create_range_type): Add some asserts.
1912
1913 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1914
1915         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1916         update return statements.
1917         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1918         declaration, and update comment to match.
1919         * gdbtypes.c (resolve_dynamic_array): Update call to
1920         dwarf2_evaluate_property to match new return type.
1921
1922 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1923
1924         * valarith.c (value_subscripted_rvalue): Change lowerbound
1925         parameter type from int to LONGEST.
1926         * value.h (value_subscripted_rvalue): Likewise in declaration.
1927
1928 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * cli/cli-utils.c (info_print_command_completer): New function.
1931         * cli/cli-utils.h: Add 'completer.h' include, and forward
1932         declaration for 'struct cmd_list_element'.
1933         (info_print_command_completer): Declare.
1934         * stack.c (_initialize_stack): Add completer for 'info locals' and
1935         'info args'.
1936         * symtab.c (_initialize_symtab): Add completer for 'info
1937         variables' and 'info functions'.
1938         * NEWS: Mention completion for additional info commands.
1939
1940 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * cli/cli-utils.c (extract_info_print_args): Delete.
1943         (extract_arg_maybe_quoted): Delete.
1944         (info_print_options_defs): New variable.
1945         (make_info_print_options_def_group): New function.
1946         (extract_info_print_options): Define new function.
1947         * cli/cli-utils.h (extract_info_print_args): Delete.
1948         (struct info_print_options): New structure.
1949         (extract_info_print_options): Declare new function.
1950         * stack.c (info_locals_command): Update to use new
1951         extract_info_print_options, also add a header comment.
1952         (info_args_command): Likewise.
1953         * symtab.c (info_variables_command): Likewise.
1954         (info_functions_command): Likewise.
1955
1956 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1959         to extract string arguments.
1960         * common/common-utils.c (extract_string_maybe_quoted): New function.
1961         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1962
1963 2019-07-11  Tom Tromey  <tromey@adacore.com>
1964
1965         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1966         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1967         * top.h (gdbinit): Don't declare.
1968         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1969         into...
1970         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1971         * top.c (gdb_init): Don't call init_cli_cmds.
1972         (gdbinit): Remove.
1973         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1974
1975 2019-07-11  Tom Tromey  <tromey@adacore.com>
1976
1977         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1978         after it has been moved.
1979
1980 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1981
1982         * valops.c (value_must_coerce_to_target): Change return type to
1983         bool.
1984         * value.h (value_must_coerce_to_target): Likewise.
1985
1986 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1987
1988         * breakpoint.c (is_hardware_watchpoint): Remove
1989         forward-declaration.
1990         (is_masked_watchpoint): Change return type to bool.
1991         (is_tracepoint): Likewise.
1992         (is_breakpoint): Likewise.
1993         (is_hardware_watchpoint): Likewise.
1994         (is_watchpoint): Likewise.
1995         (is_no_memory_software_watchpoint): Likewise.
1996         (is_catchpoint): Likewise.
1997         (breakpoint_1): Make FILTER parameter's return type bool.
1998         is_masked_watchpoint): Change return type to bool.
1999         (save_breakpoints): Make FILTER parameter's return type bool.
2000         * breakpoint.h (is_breakpoint): Change return type to bool.
2001         (is_watchpoint): Likewise.
2002         (is_catchpoint): Likewise.
2003         (is_tracepoint): Likewise.
2004
2005 2019-07-10  Tom Tromey  <tom@tromey.com>
2006
2007         * defs.h: Don't include gdbarch.h.
2008         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2009         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2010         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2011         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2012         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2013         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2014         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2015         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2016         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2017         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2018         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2019         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2020         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2021         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2022         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2023         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2024         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2025         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2026         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2027         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2028         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2029         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2030         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2031         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2032         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2033         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2034         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2035
2036 2019-07-10  Tom Tromey  <tromey@adacore.com>
2037
2038         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2039         * breakpoint.c (init_ada_exception_breakpoint): Register as
2040         bp_catchpoint.
2041         (print_one_breakpoint_location, print_one_breakpoint): Use
2042         is_ada_exception_catchpoint.
2043         * ada-lang.c (class ada_catchpoint_location): Pass
2044         bp_loc_software_breakpoint to bp_location constructor.
2045         (is_ada_exception_catchpoint): New function.
2046
2047 2019-07-10  Tom Tromey  <tromey@adacore.com>
2048
2049         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2050         VEC.
2051         (struct arm_exidx_entry): New method operator<.
2052         (struct arm_exidx_data) <section_maps>: Change type.
2053         (arm_exidx_data_free): Remove.
2054         (arm_exidx_data_key): Change type.  Move lower.
2055         (arm_exidx_new_objfile): Update.
2056         (arm_compare_exidx_entries): Remove.
2057         (arm_find_exidx_entry, _initialize_arm_tdep)
2058
2059 2019-07-10  Tom Tromey  <tromey@adacore.com>
2060
2061         * solib-spu.c (ocl_program_data_key): Change type.
2062         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2063         Update.
2064
2065 2019-07-10  Tom Tromey  <tromey@adacore.com>
2066
2067         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2068         (struct solib_aix_inferior_data) <library_list>: Change type.
2069         (solib_aix_inferior_data_handle): Change type.
2070         (get_solib_aix_inferior_data): Update.
2071         (solib_aix_free_library_list): Remove.
2072         (library_list_start_library): Update.
2073         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2074         return type.
2075         (solib_aix_get_library_list)
2076         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2077         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2078
2079 2019-07-10  Tom Tromey  <tromey@adacore.com>
2080
2081         * solib-dsbt.c (struct dsbt_info): Add initializers.
2082         (solib_dsbt_pspace_data): Change type.
2083         (dsbt_pspace_data_cleanup): Remove.
2084         (get_dsbt_info, _initialize_dsbt_solib): Update.
2085
2086 2019-07-10  Tom Tromey  <tromey@adacore.com>
2087
2088         * spu-tdep.c (spu_overlay_data): Change type.
2089         (spu_get_overlay_table, spu_overlay_new_objfile)
2090         (_initialize_spu_tdep): Update.
2091
2092 2019-07-10  Tom Tromey  <tromey@adacore.com>
2093
2094         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2095         destructor.
2096         (dbx_objfile_data_key): Change type and declare later.
2097         (DBX_SYMFILE_INFO): Rewrite.
2098         * dbxread.c (dbx_objfile_data_key): Change type.
2099         (dbx_symfile_init): Update.
2100         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2101         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2102         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2103
2104 2019-07-10  Tom Tromey  <tromey@adacore.com>
2105
2106         * jit.c (jit_program_space_key): Change type.  Move lower.
2107         (get_jit_program_space_data): Update.
2108         (jit_program_space_data_cleanup): Remove.
2109         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2110         Update.
2111         (struct jit_program_space_data): Add initializers.
2112
2113 2019-07-10  Tom Tromey  <tromey@adacore.com>
2114
2115         * solib-darwin.c (struct darwin_info): Add initializers.
2116         (solib_darwin_pspace_data): Change type.
2117         (darwin_pspace_data_cleanup): Remove.
2118         (get_darwin_info, _initialize_darwin_solib): Update.
2119
2120 2019-07-10  Tom Tromey  <tromey@adacore.com>
2121
2122         * remote-sim.c (struct sim_inferior_data): Add initializers,
2123         constructor, and destructor.
2124         (sim_inferior_data_key): Change type.  Move lower.
2125         (check_for_duplicate_sim_descriptor): Update.
2126         (get_sim_inferior_data): Use new.  Update.
2127         (~sim_inferior_data_cleanup): Rename from
2128         sim_inferior_data_cleanup.  Simplify.
2129         (gdbsim_close_inferior, simulator_command)
2130         (sim_command_completer, _initialize_remote_sim): Update.
2131         (next_pid, INITIAL_PID): Move earlier.
2132
2133 2019-07-10  Tom Tromey  <tromey@adacore.com>
2134
2135         * python/python-internal.h (create_thread_object): Return
2136         gdbpy_ref.
2137         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2138         * python/py-inferior.c (struct threadlist_entry): Add
2139         constructor.
2140         <thread_obj>: Now a gdbpy_ref.
2141         (thread_to_thread_object): Update.
2142         (add_thread_object): Use new.
2143         (delete_thread_object): Use delete.
2144         (infpy_threads): Update.
2145         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2146         GIL.
2147
2148 2019-07-10  Tom Tromey  <tromey@adacore.com>
2149
2150         * valops.c (value_cast): Specialize error message for Ada.
2151
2152 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2153
2154         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2155
2156 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2157
2158         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2159         bpstat_should_step): Return bool, adjust comments.
2160         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2161         bpstat_should_step): Likewise.
2162
2163 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2164
2165         * features/Makefile: Use feature target descriptions for Arm.
2166         * features/arm/arm-core.c: Generate new file.
2167         * features/arm/arm-fpa.c: Likewise.
2168         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2169         * features/arm/arm-m-profile.c: Likewise.
2170         * features/arm/arm-vfpv2.c: Likewise.
2171         * features/arm/arm-vfpv3.c: Likewise.
2172         * features/arm/xscale-iwmmxt.c: Likewise.
2173         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2174
2175 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2176
2177         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2178         ptrace earlier.
2179
2180 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2181
2182         * features/aarch64-pauth.c: Regenerate.
2183
2184 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2185
2186         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2187         bool.
2188         (bpstat_what): Use false instead of 0.
2189
2190 2019-07-09  Pedro Alves  <palves@redhat.com>
2191
2192         * break-catch-throw.c (is_exception_catchpoint): New.
2193         * breakpoint.c (print_one_breakpoint_location): New parameter
2194         'raw_loc'.  Handle it.  Use
2195         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2196         looking at the breakpoint's type.
2197         (print_one_breakpoint): If handling "maint info breakpoints", also
2198         print locations of exception catchpoints.
2199         * breakpoint.h (is_exception_catchpoint): Declare.
2200
2201 2019-07-09  Pedro Alves  <palves@redhat.com>
2202
2203         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2204         "addr" field.
2205         (allocate_location_exception_catchpoint): New.
2206         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2207         (initialize_throw_catchpoint_ops): Install
2208         allocate_location_exception_catchpoint as allocate_location
2209         method.
2210         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2211         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2212         bp_loc_other.
2213         (breakpoint_address_is_meaningful): Delete.
2214         (bl_address_is_meaningful): New.
2215         (breakpoint_locations_match): Adjust comment.
2216         (bp_location_from_bp_type): New, factored out of...
2217         (bp_location::bp_location(breakpoint *)): ... this.
2218         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2219         factored out of...
2220         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2221         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2222         breakpoint_address_is_meaningful.
2223         (bp_locations_compare): Adjust comment.
2224         (update_global_location_list): Use bl_address_is_meaningful
2225         instead of breakpoint_address_is_meaningful.
2226         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2227         explicit.
2228         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2229         * python/py-breakpoint.c (bppy_get_location): No longer check
2230         whether location is null.
2231
2232 2019-07-09  Pedro Alves  <palves@redhat.com>
2233
2234         PR c++/15468
2235         * breakpoint.c (print_one_breakpoint_location): Remove
2236         single-location assert.
2237
2238 2019-07-09  Tom Tromey  <tom@tromey.com>
2239
2240         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2241         * configure: Rebuild.
2242         * configure.ac: Change common to gdbsupport.
2243         * gdbsupport: Rename from common.
2244         * acinclude.m4: Change common to gdbsupport.
2245         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2246         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2247         gdbsupport.
2248         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2249         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2250         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2251         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2252         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2253         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2254         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2255         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2256         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2257         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2258         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2259         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2260         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2261         coff-pe-read.c, command.h, compile/compile-c-support.c,
2262         compile/compile-c.h, compile/compile-cplus-symbols.c,
2263         compile/compile-cplus-types.c, compile/compile-cplus.h,
2264         compile/compile-loc2c.c, compile/compile.c, completer.c,
2265         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2266         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2267         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2268         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2269         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2270         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2271         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2272         features/aarch64-core.c, features/aarch64-fpu.c,
2273         features/aarch64-pauth.c, features/aarch64-sve.c,
2274         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2275         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2276         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2277         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2278         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2279         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2280         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2281         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2282         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2283         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2284         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2285         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2286         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2287         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2288         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2289         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2290         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2291         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2292         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2293         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2294         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2295         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2296         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2297         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2298         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2299         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2300         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2301         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2302         minsyms.c, mips-linux-tdep.c, namespace.h,
2303         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2304         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2305         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2306         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2307         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2308         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2309         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2310         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2311         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2312         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2313         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2314         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2315         procfs.c, producer.c, progspace.h, psymtab.h,
2316         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2317         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2318         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2319         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2320         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2321         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2322         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2323         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2324         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2325         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2326         target-memory.c, target.c, target.h, target/waitstatus.c,
2327         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2328         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2329         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2330         unittests/array-view-selftests.c,
2331         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2332         unittests/common-utils-selftests.c,
2333         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2334         unittests/format_pieces-selftests.c,
2335         unittests/function-view-selftests.c,
2336         unittests/lookup_name_info-selftests.c,
2337         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2338         unittests/mkdir-recursive-selftests.c,
2339         unittests/observable-selftests.c,
2340         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2341         unittests/parse-connection-spec-selftests.c,
2342         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2343         unittests/scoped_fd-selftests.c,
2344         unittests/scoped_mmap-selftests.c,
2345         unittests/scoped_restore-selftests.c,
2346         unittests/string_view-selftests.c, unittests/style-selftests.c,
2347         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2348         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2349         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2350         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2351         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2352         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2353
2354 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2357         bool value.
2358         (decode_digits_ordinary): Set explicit_line field in sal.
2359         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2360         symtab_and_line that was set on an explicit line number in
2361         assembler code.  Do always update the recorded symtab and line if
2362         we do skip the prologue.
2363
2364 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * breakpoint.c (set_breakpoint_location_function): Remove
2367         explicit_loc parameter.
2368         (momentary_breakpoint_from_master): Update call to
2369         set_breakpoint_location_function.
2370         (add_location_to_breakpoint): Likewise.
2371
2372 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2375         required features based on default bfd type when no specific bfd
2376         is present.
2377
2378 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2379
2380         * NEWS: Mention that GDB printf and eval commands can now print
2381         C-style and Ada-style convenience var strings without
2382         calling the inferior.
2383         * printcmd.c (printf_c_string): Locally print GDB internal var
2384         instead of transiting via the inferior.
2385         (printf_wide_c_string): Likewise.
2386
2387 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2388
2389         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2390
2391 2019-07-04  Tom Tromey  <tom@tromey.com>
2392
2393         PR tui/24724:
2394         * tui/tui-winsource.c (tui_clear_source_content): Update.
2395         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2396         (tui_update_breakpoint_info): Update.
2397         (tui_set_exec_info_content): Update.
2398         * tui/tui-source.c (tui_set_source_content_nil): Update.
2399         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2400         has_break.
2401         * tui/tui-data.h (enum tui_bp_flag): New.
2402         (tui_bp_flags): New enum flags type.
2403         (struct tui_source_element) <break_mode>: Change type.  Rename
2404         from has_break.
2405         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2406         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2407         constants.
2408         * tui/tui-winsource.h: Fix comment.
2409
2410 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2411
2412         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2413         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2414         (store_fpregs_to_thread)
2415         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2416         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2417         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2418         (IWMMXT_REGS_SIZE): Add define.
2419         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2420         (fetch_vfp_regs, store_vfp_regs)
2421         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2422         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2423
2424 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2427         defines.
2428         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2429         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2430         (ARM_INT_REGISTER_SIZE): ...to this.
2431         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2432         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2433         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2434         (arm_linux_collect_gregset, supply_nwfpe_register)
2435         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2436         defines.
2437         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2438         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2439         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2440         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2441         (arm_return_in_memory, arm_store_return_value)
2442         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2443         (arm_record_ld_st_multiple): Likewise.
2444         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2445         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2446
2447 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2448
2449         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2450         AARCH64_DISPLACED_MODIFIED_INSNS.
2451         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2452         (aarch64_displaced_step_copy_insn): Likewise.
2453         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2454         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2455         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2456         ARM_DISPLACED_MODIFIED_INSNS.
2457         * arm-tdep.c (arm_gdbarch_init): Likewise.
2458         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2459         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2460         (struct arm_displaced_step_closure): Use
2461         ARM_DISPLACED_MODIFIED_INSNS.
2462
2463 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2464
2465         * features/Makefile: Remove unused xml files.
2466         * features/aarch64.xml: Remove.
2467         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2468         * features/i386/amd64-avx-avx512.xml: Remove.
2469         * features/i386/amd64-avx-linux.xml: Remove.
2470         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2471         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2472         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2473         * features/i386/amd64-avx-mpx.xml: Remove.
2474         * features/i386/amd64-avx.xml: Remove.
2475         * features/i386/amd64-linux.xml: Remove.
2476         * features/i386/amd64-mpx-linux.xml: Remove.
2477         * features/i386/amd64-mpx.xml: Remove.
2478         * features/i386/amd64.xml: Remove.
2479         * features/i386/i386-avx-avx512-linux.xml: Remove.
2480         * features/i386/i386-avx-avx512.xml: Remove.
2481         * features/i386/i386-avx-linux.xml: Remove.
2482         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2483         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2484         * features/i386/i386-avx-mpx-linux.xml: Remove.
2485         * features/i386/i386-avx-mpx.xml: Remove.
2486         * features/i386/i386-avx.xml: Remove.
2487         * features/i386/i386-linux.xml: Remove.
2488         * features/i386/i386-mmx-linux.xml: Remove.
2489         * features/i386/i386-mmx.xml: Remove.
2490         * features/i386/i386-mpx-linux.xml: Remove.
2491         * features/i386/i386-mpx.xml: Remove.
2492         * features/i386/i386.xml: Remove.
2493         * features/i386/x32-avx-avx512-linux.xml: Remove.
2494         * features/i386/x32-avx-linux.xml: Remove.
2495         * features/i386/x32-linux.xml: Remove.
2496
2497 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2498
2499         * regformats/aarch64.dat: Remove.
2500         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2501         * regformats/i386/amd64-avx-linux.dat: Remove.
2502         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2503         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2504         * regformats/i386/amd64-linux.dat: Remove.
2505         * regformats/i386/amd64-mpx-linux.dat: Remove.
2506         * regformats/i386/amd64.dat: Remove.
2507         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2508         * regformats/i386/i386-avx-linux.dat: Remove.
2509         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2510         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2511         * regformats/i386/i386-linux.dat: Remove.
2512         * regformats/i386/i386-mmx-linux.dat: Remove.
2513         * regformats/i386/i386-mpx-linux.dat: Remove.
2514         * regformats/i386/i386.dat: Remove.
2515         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2516         * regformats/i386/x32-avx-linux.dat: Remove.
2517         * regformats/i386/x32-linux.dat: Remove.
2518
2519 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * aarch64-tdep.c: Remove xml self tests.
2522         * amd64-linux-tdep.c: Likewise.
2523         * amd64-tdep.c: Likewise.
2524         * i386-linux-tdep.c: Likewise.
2525         * i386-tdep.c: Likewise.
2526
2527 2019-07-03  Pedro Alves  <palves@redhat.com>
2528
2529         PR cli/24732
2530         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2531         (pipe_cmd_option_defs): New.
2532         (make_pipe_cmd_options_def_group): New.
2533         (pipe_command): Use gdb::option::process_options.
2534         (pipe_command_completer): New function.
2535         (_initialize_cli_cmds): Install completer for "pipe" command.
2536
2537 2019-07-03  Pedro Alves  <palves@redhat.com>
2538
2539         * cli/cli-option.c (union option_value) <string>: New field.
2540         (struct option_def_and_value): Add ctor, move ctor, dtor and
2541         use DISABLE_COPY_AND_ASSIGN.
2542         (option_def_and_value::clear_value): New.
2543         (parse_option, save_option_value_in_ctx, get_val_type_str)
2544         (add_setshow_cmds_for_options): Handle var_string.
2545         * cli-option.h (union option_def::var_address) <string>: New
2546         field.
2547         (struct string_option_def): New.
2548         * maint-test-options.c (struct test_options_opts): Add default
2549         ctor and use DISABLE_COPY_AND_ASSIGN.
2550         <string_opt>: New field.
2551         (test_options_opts::~test_options_opts): New.
2552         (test_options_opts::dump): Also dump "-string".
2553         (test_options_option_defs): Install "string.
2554
2555 2019-07-03  Pedro Alves  <palves@redhat.com>
2556
2557         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2558         option_value with a null enumeration.
2559         (complete_options): Save the option values in the context.
2560         (save_option_value_in_ctx): New, factored out from ...
2561         (process_options): ... here.
2562         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2563         of the function.
2564         * maint-test-options.c (test_options_opts::dump): New, factored
2565         out from ...
2566         (maintenance_test_options_command_mode): ... here.
2567         (maintenance_test_options_command_completion_result): Delete.
2568         (maintenance_test_options_command_completion_text): Update
2569         comment.
2570         (maintenance_show_test_options_completion_result): Change
2571         prototype.  Just print
2572         maintenance_test_options_command_completion_text.
2573         (save_completion_result): New.
2574         (maintenance_test_options_completer_mode): Pass options context to
2575         complete_options, and then save a dump.
2576         (_initialize_maint_test_options): Use add_cmd to install "maint
2577         show test-options-completion-result".
2578
2579 2019-07-03  Pedro Alves  <palves@redhat.com>
2580
2581         * NEWS (New commands): Mention "with" and "maint with".
2582         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2583         (with_command, with_command_completer): New.
2584         (pipe_command): Adjust to new repeat_previous
2585         interface.
2586         (_initialize_cli_cmds): Install the "with" command and its "w"
2587         alias.
2588         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2589         declarations.
2590         * cli/cli-setshow.c (parse_cli_var_uinteger)
2591         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2592         argument strings for all var_types.
2593         (get_setshow_command_value_string): New, factored out from ...
2594         (do_show_command): ... this.
2595         * cli/cli-setshow.h: Include <string>.
2596         (get_setshow_command_value_string): Declare.
2597         * command.h (repeat_previous): Now returns const char *.  Adjust
2598         comment.
2599         * maint.c: Include "cli/cli-cmds.h".
2600         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2601         (_initialize_maint_cmds): Register the "maintenance with" command.
2602         * top.c (repeat_previous): Move bits from pipe_command here:
2603         Return the saved command line, if any; error out if there's no
2604         command to relaunch.
2605
2606 2019-07-03  Pedro Alves  <palves@redhat.com>
2607
2608         * NEWS (New commands): Mention "maint set/show test-settings"
2609         instead of "maint test-settings".
2610         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2611         (maintenance_test_settings_set_list): Rename to ...
2612         (maintenance_set_test_settings_list): ... this.
2613         (maintenance_test_settings_show_list): Rename to  ...
2614         (maintenance_show_test_settings_list): ... this.
2615         (maintenance_test_settings_cmd): Delete.
2616         (maintenance_test_settings_set_cmd): ...
2617         (maintenance_set_test_settings_cmd): ... this.
2618         (maintenance_test_settings_show_cmd): ...
2619         (maintenance_show_test_settings_cmd): ... this.
2620         (maintenance_test_settings_show_value_cmd):
2621         (maintenance_show_test_settings_value_cmd): ... this.
2622         (_initialize_maint_test_settings): No longer install the "maint
2623         test-settings" prefix command.  Rename "maint test-settings set"
2624         to "maint set test-settings", and "maint test-settings show" to
2625         "maint show test-settings".  Adjust all subcommands.
2626
2627 2019-07-03  Pedro Alves  <palves@redhat.com>
2628
2629         * maint-test-settings.c: Fix file's intro comment.  Replace all
2630         references to "test-options" with references to "test-settings",
2631         in comments.
2632
2633 2019-07-03  Pedro Alves  <palves@redhat.com>
2634
2635         * maint-test-settings.c (maintenance_test_settings_xxx)
2636         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2637         New.
2638         (maintenance_test_settings_enums): Use them.
2639         (maintenance_test_settings_enum): Default to
2640         maintenance_test_settings_xxx.
2641         (_initialize_maint_test_settings): Initialize
2642         MAINTENANCE_TEST_SETTINGS_FILENAME.
2643
2644 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2645
2646         * breakpoint.h (remove_breakpoints_inf): Change return type to
2647         void, move function documentation here.
2648         * breakpoint.c (remove_breakpoints_inf): Change return type to
2649         void, move function documentation to header.
2650
2651 2019-07-02  Pedro Alves  <palves@redhat.com>
2652
2653         * NEWS (Completion improvements): Mention "info threads".
2654         * thread.c (struct info_threads_opts, info_threads_option_defs)
2655         (make_info_threads_options_def_group): New.
2656         (info_threads_command): Use gdb::option::process_options.
2657         (info_threads_command_completer): New.
2658         (_initialize_thread): Use gdb::option::build_help to build the
2659         help text for "info threads".
2660
2661 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2662
2663         * defs.h (generic_load): Move from here...
2664         * symfile.h (generic_load): ... to here.  Rename name parameter
2665         to args.
2666         * symfile.c (generic_load): Add comment.
2667
2668 2019-07-01  Tom Tromey  <tromey@adacore.com>
2669
2670         * dwarf2read.c
2671         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2672         declaration of without_params.  Fix formatting.
2673
2674 2019-07-01  Tom Tromey  <tromey@adacore.com>
2675
2676         * ada-exp.y (find_primitive_type): Update.
2677         * ada-lang.h (ada_lookup_symbol): Update.
2678         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2679         parameter.
2680         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2681
2682 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2683
2684         PR breakpoints/24541
2685         * gdbarch.c: Regenerate.
2686         * gdbarch.h: Regenerate.
2687         * gdbarch.sh: Add 'stap_adjust_register'.
2688         * i386-tdep.c: Include '<unordered_set>'.
2689         (i386_stap_adjust_register): New function.
2690         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2691         * stap-probe.c (stap_parse_register_operand): Call
2692         'gdbarch_stap_adjust_register'.
2693
2694 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2695
2696         PR python/24742
2697         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2698         * python/python.c (do_start_initialization): Use 'xmalloc'
2699         instead of 'PyMem_Malloc'.
2700
2701 2019-06-28  Tom Tromey  <tromey@adacore.com>
2702
2703         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2704         for Ada.
2705
2706 2019-06-27  Tom Tromey  <tromey@adacore.com>
2707
2708         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2709         objfile_key.
2710         (arm_find_mapping_symbol, arm_record_special_symbol)
2711         (_initialize_arm_tdep): Update.
2712         (arm_objfile_data_free): Remove.
2713
2714 2019-06-27  Tom Tromey  <tromey@adacore.com>
2715
2716         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2717         to cp_print_static_field.
2718
2719 2019-06-26  Tom Tromey  <tromey@adacore.com>
2720
2721         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2722         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2723         declare.
2724
2725 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2726
2727         * features/aarch64-core.c (create_feature_aarch64_core):
2728         Regenerate.
2729         * features/aarch64-core.xml: Add cpsr flags.
2730
2731 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2734         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2735
2736 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2737
2738         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2739         field.
2740         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2741         use.
2742         (arm_record_special_symbol): Don't insert new symbol in sorted
2743         position, push it at the end.
2744
2745 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2746
2747         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2748         (arm_mapping_symbol_s): Remove.
2749         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2750         (arm_mapping_symbol_vec): New typedef.
2751         (struct arm_per_objfile): Add constructor.
2752         <section_maps>: Change type to
2753         std::unique_ptr<arm_mapping_symbol_vec[]>.
2754         (arm_compare_mapping_symbols): Remove.
2755         (arm_find_mapping_symbol): Adjust to section_maps type change.
2756         (arm_objfile_data_free): Call delete on arm_per_objfile.
2757         (arm_record_special_symbol): Adjust to section_maps type change.
2758         Allocate arm_per_objfile with new.
2759
2760 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2761
2762         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2763         with the command prefix.
2764
2765 2019-06-25  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2768         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2769
2770 2019-06-25  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2773         type.
2774         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2775         protected.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-winsource.c
2780         (tui_source_window_base::set_is_exec_point_at): Add check against
2781         LOA_ADDRESS.
2782
2783 2019-06-25  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-source.c (tui_set_source_content): Don't check before
2786         xfree.
2787         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2788
2789 2019-06-25  Tom Tromey  <tom@tromey.com>
2790
2791         * tui/tui-winsource.h (tui_update_source_window_as_is)
2792         (tui_alloc_source_buffer, tui_line_is_displayed)
2793         (tui_addr_is_displayed): Change type of win_info.
2794         * tui/tui-winsource.c (tui_update_source_window_as_is)
2795         (tui_clear_source_content, tui_show_source_line)
2796         (tui_show_source_content, tui_source_window_base::refill)
2797         (tui_source_window_base::set_is_exec_point_at)
2798         (tui_source_window_base::set_is_exec_point_at)
2799         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2800         (tui_alloc_source_buffer, tui_line_is_displayed)
2801         (tui_addr_is_displayed): Change type of win_info.  Update.
2802         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2803         (tui_source_window_base::do_make_visible_with_new_height):
2804         Update.
2805         * tui/tui-source.c (tui_set_source_content)
2806         (tui_set_source_content_nil)
2807         (tui_source_window::do_scroll_vertical): Update.
2808         * tui/tui-layout.c (show_layout): Update.
2809         * tui/tui-disasm.c (tui_set_disassem_content)
2810         (tui_disasm_window::do_scroll_vertical): Update.
2811         * tui/tui-data.h (tui_win_content): Remove.
2812         (struct tui_gen_win_info) <content, content_size>: Remove.
2813         (struct tui_source_element): Add initializers and destructor.
2814         (union tui_which_element, struct tui_win_element): Remove.
2815         (struct tui_source_window_base) <content>: New field.
2816         (struct tui_data_window): Remove destructor.
2817         (tui_alloc_content, tui_free_win_content)
2818         (tui_free_all_source_wins_content): Don't declare.
2819         * tui/tui-data.c (tui_initialize_static_data): Update.
2820         (init_content_element, tui_alloc_content): Remove.
2821         (~tui_gen_win_info): Update.
2822         (~tui_data_window, tui_free_all_source_wins_content)
2823         (tui_free_win_content, free_content, free_content_elements):
2824         Remove.
2825
2826 2019-06-25  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-winsource.h (tui_clear_source_content)
2829         (tui_erase_source_content, tui_show_source_content): Change type
2830         of win_info.
2831         * tui/tui-winsource.c (tui_clear_source_content)
2832         (tui_erase_source_content, tui_show_source_content): Change type
2833         of win_info.
2834         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2835         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2836         win_info.
2837         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2838         win_info.
2839         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2840
2841 2019-06-25  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-winsource.c (tui_clear_source_content)
2844         (tui_source_window_base::set_is_exec_point_at): Update.
2845         * tui/tui-source.c (tui_set_source_content_nil): Update.
2846         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2847         a bool.
2848         * tui/tui-data.c (init_content_element): Update.
2849
2850 2019-06-25  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2853         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2854         * tui/tui-layout.c (init_and_make_win): Update.
2855         * tui/tui.h (enum tui_win_type): Update.
2856         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2857         tui_win_is_auxillary.
2858         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2859         tui_win_is_auxillary.
2860
2861 2019-06-25  Tom Tromey  <tom@tromey.com>
2862
2863         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2864         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2865         (tui_delete_data_content_windows, tui_display_all_data)
2866         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2867         Update.
2868         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2869         * tui/tui-regs.c (tui_last_regs_line_no)
2870         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2871         (tui_show_registers): Update.
2872         (tui_show_register_group): Return void.  Update.
2873         (tui_display_registers_from, tui_display_reg_element_at_line)
2874         (tui_display_registers_from_line, tui_check_register_values):
2875         Update.
2876         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2877         member.
2878         (struct tui_data_window) <regs_content>: Now a std::vector.
2879         <regs_content_count>: Remove.
2880         (tui_add_content_elements, tui_free_data_content): Don't declare.
2881         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2882         (init_content_element): Remove DATA_WIN case.  Add assert.
2883         (tui_add_content_elements): Remove.
2884         (tui_data_window): Update.
2885         (tui_free_data_content): Remove.
2886         (free_content_elements): Remove DATA_WIN case.
2887
2888 2019-06-25  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-data.c (tui_data_item_window): Update.
2891         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2892         * tui/tui-windata.c (tui_display_all_data)
2893         (tui_display_data_from_line): Update.
2894         (tui_check_data_values): Remove.
2895         * tui/tui-regs.c (tui_show_register_group)
2896         (tui_display_reg_element_at_line): Update.
2897         * tui/tui-hooks.c (tui_register_changed)
2898         (tui_refresh_frame_and_register_information): Call
2899         tui_check_register_values.
2900         * tui/tui-data.h (struct tui_data_window) <data_content,
2901         data_content_count, data_type>: Remove.
2902         (enum tui_data_type): Remove.
2903
2904         * tui/tui-data.c (tui_data_window::clear_detail)
2905         (~tui_data_window): Update.
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2910         declare.
2911         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2912         Rename from tui_first_data_item_displayed.  Update.
2913         (tui_data_window::refresh_all)
2914         (tui_data_window::do_scroll_vertical): Update.
2915         * tui/tui-data.h (struct tui_data_window)
2916         <first_data_item_displayed>: Declare new method.
2917
2918 2019-06-25  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2921         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2922         contents...
2923         (tui_initialize_static_data): ...here.
2924
2925 2019-06-25  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2928         (tui_display_registers_from, tui_check_register_values): Update.
2929         (tui_display_register): Remove win_info parameter; update.
2930         (tui_get_register): Change type of parameters.
2931         * tui/tui-data.h (struct tui_data_element): Remove.
2932         (union tui_which_element) <data>: Remove.
2933         <data_window>: Change type.
2934         (struct tui_data_item_window): New.
2935         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2936         case.  Add assert.
2937         (~tui_data_item_window): New destructor.
2938         (free_content_elements): Remove DATA_ITEM_WIN case.
2939
2940 2019-06-25  Tom Tromey  <tom@tromey.com>
2941
2942         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2943         Remove.
2944
2945 2019-06-25  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-data.h (struct tui_command_element): Remove.
2948         (union tui_which_element) <command>: Remove.
2949         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2950         assert.
2951         (free_content_elements): Remove CMD_WIN case.
2952
2953 2019-06-25  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-layout.c (tui_set_layout): Update.
2956         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2957         * tui/tui-data.c (layout_def): Update.
2958
2959 2019-06-25  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2962         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2963         (tui_source_window_base::set_new_height): Update.
2964         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2965         Update.
2966         (tui_set_locator_fullname, tui_set_locator_info)
2967         (tui_show_frame_info): Update.
2968         * tui/tui-source.c (tui_set_source_content)
2969         (tui_source_is_displayed): Update.
2970         * tui/tui-layout.c (show_source_disasm_command, show_data)
2971         (show_source_or_disasm_and_command): Update.
2972         * tui/tui-disasm.c (tui_set_disassem_content)
2973         (tui_get_begin_asm_address): Update.
2974         * tui/tui-data.h (struct tui_locator_element): Remove.
2975         (union tui_which_element) <locator>: Remove.
2976         (struct tui_locator_window): New.
2977         (tui_locator_win_info_ptr): Change return type.
2978         * tui/tui-data.c (_locator): Change type.
2979         (tui_locator_win_info_ptr): Change return type.
2980         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2981         (tui_alloc_content): Add assert.
2982
2983 2019-06-25  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-winsource.c
2986         (tui_exec_info_window::maybe_allocate_content): New method.
2987         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2988         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2989         (make_source_or_disasm_window): Add cast.
2990         * tui/tui-data.h (union tui_which_element) <simple_string>:
2991         Remove.
2992         (struct tui_source_info): New.
2993         (struct tui_source_window_base) <execution_info>: Change type.
2994         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2995         case, and add assert.
2996         (tui_alloc_content): Add assert.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3001         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3002         * tui/tui-data.c (tui_alloc_win_info): Remove.
3003
3004 2019-06-25  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3007         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3008         can_highlight.
3009
3010 2019-06-25  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3013         make_visible_with_new_height method.
3014         (tui_win_info::make_visible_with_new_height): New method.
3015         (tui_source_window_base::do_make_visible_with_new_height)
3016         (tui_data_window::do_make_visible_with_new_height)
3017         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3018         (make_visible_with_new_height): Remove.
3019         (tui_resize_all, tui_adjust_win_heights): Use
3020         make_visible_with_new_height method.
3021         * tui/tui-data.h (struct tui_win_info)
3022         <do_make_visible_with_new_height, make_visible_with_new_height>:
3023         New methods.
3024         (struct tui_source_window_base, struct tui_data_window)
3025         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3026         methods.
3027
3028 2019-06-25  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3031         method.
3032         (update_tab_width): Call update_tab_width method.
3033         * tui/tui-data.h (struct tui_win_info)
3034         (struct tui_source_window_base) <update_tab_width>: New methods.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3039         parameter.
3040         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3041         parameter.
3042         (tui_gen_win_info::make_visible): Update.
3043         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3044         parameter.
3045         * tui/tui-data.h (enum tui_box): New enum.
3046         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3047
3048 2019-06-25  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3051         init_and_make_win for EXEC_INFO_WIN.
3052         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3053         longer inline.
3054         (struct tui_win_info) <~tui_win_info>: Inline.
3055         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3056         Don't declare.
3057         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3058         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3059         Remove.
3060         (tui_initialize_static_data): Update.
3061         (~tui_gen_win_info): Handle more cleanup here.
3062         (~tui_source_window_base): Delete "execution_info".
3063         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3064
3065 2019-06-25  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui-layout.c (make_command_window): Don't set
3068         can_highlight.
3069         (show_source_disasm_command): Call the reset method.
3070         (show_data): Don't set can_highlight.  Call the reset method.
3071         (tui_gen_win_info::reset): Rename from init_gen_win_info
3072         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3073         (show_source_or_disasm_and_command): Call the reset method.
3074         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3075         (struct tui_cmd_window): Set can_highlight.
3076
3077 2019-06-25  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3080         from make_visible.
3081         (tui_make_visible, tui_make_invisible): Rewrite.
3082         (tui_win_info::make_visible): Remove.
3083         (tui_source_window_base::make_visible): Update.
3084         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3085         method.  Moved from...
3086         (struct tui_win_info) <make_visible>: ...here.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-winsource.c
3091         (tui_source_window_base::do_scroll_horizontal): Remove direction
3092         parameter.
3093         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3094         direction parameter.
3095         * tui/tui-win.c (tui_win_info::forward_scroll)
3096         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3097         (tui_win_info::right_scroll): Update.
3098         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3099         direction parameter.
3100         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3101         direction parameter.
3102         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3103         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3104         Remove direction parameter.
3105         (struct tui_source_window_base, struct tui_source_window)
3106         (struct tui_disasm_window, struct tui_data_window)
3107         (struct tui_cmd_window): Update.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-winsource.h (tui_set_exec_info_content)
3112         (tui_show_exec_info_content, tui_erase_exec_info_content)
3113         (tui_clear_exec_info_content, tui_update_exec_info): Change
3114         argument to tui_source_window_base.
3115         * tui/tui-winsource.c (tui_set_exec_info_content)
3116         (tui_show_exec_info_content, tui_erase_exec_info_content)
3117         (tui_clear_exec_info_content, tui_update_exec_info): Change
3118         argument to tui_source_window_base.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3123         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3124
3125 2019-06-25  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3128         check.
3129
3130 2019-06-25  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3133         type to void.
3134         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3135         type to void.
3136         * tui/tui-source.c (tui_set_source_content): Update.
3137         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-win.c (window_name_completer, tui_set_focus)
3142         (tui_all_windows_info): Use name method.
3143         * tui/tui-data.h (struct tui_gen_win_info)
3144         (struct tui_source_window, struct tui_disasm_window)
3145         (struct tui_data_window, struct tui_cmd_window) <name>: New
3146         method.
3147         (tui_win_name): Don't declare.
3148         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3149         (tui_win_name): Remove.
3150
3151 2019-06-25  Tom Tromey  <tom@tromey.com>
3152
3153         * tui/tui-winsource.h (tui_update_source_window)
3154         (tui_update_source_window_as_is): Change parameter type.
3155         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3156         to be a tui_source_window_base.
3157         (tui_update_source_window_as_is): Likewise.
3158         * tui/tui-win.c (make_visible_with_new_height): Update.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-winsource.c (tui_erase_source_content)
3163         (tui_show_source_content, tui_show_exec_info_content)
3164         (tui_erase_exec_info_content): Use refresh_window method.
3165         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3166         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3167         from tui_refresh_win.
3168         (tui_data_window::refresh_window): New method.
3169         (tui_win_info::refresh, tui_source_window_base::refresh)
3170         (tui_refresh_all): Use refresh_window method.
3171         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3172         method.
3173         * tui/tui-regs.c (tui_display_register): Call refresh_window
3174         method.
3175         * tui/tui-layout.c (show_source_disasm_command)
3176         (show_source_or_disasm_and_command): Call refresh_window method.
3177         * tui/tui-data.h (struct tui_gen_win_info)
3178         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3179         New method.
3180
3181 2019-06-25  Tom Tromey  <tom@tromey.com>
3182
3183         * tui/tui.c (tui_rl_other_window, tui_enable)
3184         (tui_is_window_visible, tui_get_command_dimension): Update.
3185         * tui/tui-winsource.c (tui_update_source_window_as_is)
3186         (tui_clear_source_content, tui_erase_source_content)
3187         (tui_show_source_line, tui_source_window_base::refill)
3188         (tui_source_window_base::do_scroll_horizontal)
3189         (tui_source_window_base::set_is_exec_point_at)
3190         (tui_update_breakpoint_info, tui_set_exec_info_content)
3191         (tui_alloc_source_buffer, tui_line_is_displayed)
3192         (tui_addr_is_displayed): Update.
3193         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3194         (tui_check_and_display_highlight_if_needed)
3195         (tui_win_info::make_visible, tui_win_info::refresh)
3196         (tui_refresh_all): Update.
3197         * tui/tui-windata.c (tui_first_data_item_displayed)
3198         (tui_delete_data_content_windows, tui_erase_data_content)
3199         (tui_display_all_data, tui_data_window::refresh_all)
3200         (tui_check_data_values): Update.
3201         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3202         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3203         (tui_win_info::backward_scroll, tui_refresh_all_win)
3204         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3205         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3206         (tui_source_window_base::set_new_height)
3207         (tui_data_window::set_new_height)
3208         (make_invisible_and_set_new_height)
3209         (make_visible_with_new_height, new_height_ok)
3210         (parse_scrolling_args): Update.
3211         * tui/tui-stack.c (tui_show_frame_info): Update.
3212         * tui/tui-source.c (tui_set_source_content)
3213         (tui_set_source_content_nil, tui_source_is_displayed)
3214         (tui_source_window::do_scroll_vertical): Update.
3215         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3216         (tui_display_registers_from, tui_display_reg_element_at_line)
3217         (tui_check_register_values, tui_reg_command): Update.
3218         * tui/tui-layout.c (tui_default_win_height)
3219         (show_source_disasm_command, show_data, init_and_make_win)
3220         (show_source_or_disasm_and_command): Update.
3221         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3222         (tui_redisplay_readline, tui_mld_flush)
3223         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3224         (tui_getc): Update.
3225         * tui/tui-disasm.c (tui_set_disassem_content)
3226         (tui_disasm_window::do_scroll_vertical): Update.
3227         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3228         Now virtual.
3229         (struct tui_win_info): Derive from tui_gen_win_info.
3230         <~tui_win_info>: Mark as override.
3231         <generic>: Remove member.
3232         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3233         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3234         (~tui_data_window, ~tui_win_info)
3235         (tui_free_all_source_wins_content): Update.
3236         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3237
3238 2019-06-25  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-layout.c (init_and_make_win): Use new.
3241         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3242         destructor, initializers.
3243         (tui_alloc_generic_win_info): Don't declare.
3244         * tui/tui-data.c (_locator): Add argument to constructor.
3245         (source_win, disasm_win): New globals.
3246         (exec_info): Remove.
3247         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3248         Update.
3249         (tui_alloc_generic_win_info): Remove.
3250         (init_content_element): Use new.
3251         (tui_win_info::tui_win_info): Update.
3252         (free_content_elements) <case DATA_WIN>: Use delete.
3253
3254 2019-06-25  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3257         * tui/tui-windata.c (tui_first_data_item_displayed)
3258         (tui_delete_data_content_windows): Update.
3259         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3260         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3261         (tui_display_registers_from, tui_check_register_values): Update.
3262         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3263         pointer.
3264         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3265         window.
3266         (tui_free_data_content): Update.
3267         (free_content_elements) <case DATA_WIN>: Free the window.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3272         Update.
3273         * tui/tui-layout.c (make_command_window)
3274         (show_source_disasm_command, show_data, init_and_make_win)
3275         (show_source_or_disasm_and_command): Update.
3276         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3277         method.
3278         <can_highight, is_highlighted>: Now bool.
3279         (tui_set_win_highlight): Don't declare.
3280         * tui/tui-data.c (tui_set_win_highlight): Remove.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-wingeneral.c (make_visible): Remove check of window
3285         type.
3286
3287 2019-06-25  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-win.c (tui_win_info::max_height)
3290         (tui_cmd_window::max_height): New methods.
3291         (new_height_ok): Call max_height.
3292         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3293         <max_height>: New method.
3294
3295 2019-06-25  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-win.c (tui_source_window_base::set_new_height)
3298         (tui_data_window::set_new_height): New methods.
3299         (make_invisible_and_set_new_height): Call set_new_height method.
3300         * tui/tui-data.h (struct tui_win_info)
3301         (struct tui_source_window_base, struct tui_data_window)
3302         <set_new_height>: New method.
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3307         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3308         tui_refresh_data_win.
3309         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3310         method.
3311         (tui_refresh_all_win): Call the refresh_all method.
3312         (tui_set_focus): Likewise.
3313         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3314         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3315         Likewise.
3316
3317 2019-06-25  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-winsource.h (tui_refill_source_window)
3320         (tui_set_is_exec_point_at): Don't declare.
3321         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3322         (tui_source_window_base::refill): Rename from
3323         tui_refill_source_window.
3324         (tui_source_window_base::do_scroll_horizontal): Update.
3325         (tui_source_window_base::set_is_exec_point_at): Rename from
3326         tui_set_is_exec_point_at.
3327         (tui_update_all_breakpoint_info): Update.
3328         * tui/tui-stack.c (tui_show_frame_info): Update.
3329         * tui/tui-layout.c (show_data): Add cast.
3330         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3331         * tui/tui-data.h (struct tui_source_window_base) <refill,
3332         set_is_exec_point_at>: New methods.
3333         (tui_source_windows, tui_add_to_source_windows): Update types.
3334         (tui_add_to_source_windows): Remove redundant declaration.
3335         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3336         (tui_source_windows): Change return type.
3337         (tui_clear_source_windows_detail): Update.
3338         (tui_add_to_source_windows): Change type of parameter.
3339         (tui_free_all_source_wins_content): Update.
3340
3341 2019-06-25  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-wingeneral.c (tui_win_info::refresh)
3344         (tui_source_window_base::refresh): New methods.
3345         (tui_refresh_all): Call the refresh method.
3346         * tui/tui-data.h (struct tui_win_info)
3347         (struct tui_source_window_base) <refresh>: New method.
3348
3349 2019-06-25  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui.h (tui_is_window_visible): Return bool.
3352         * tui/tui.c (tui_is_window_visible): Return bool.
3353         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3354         (tui_make_visible, tui_make_invisible)
3355         (tui_win_info::make_visible)
3356         (tui_source_window_base::make_visible, make_all_visible)
3357         (tui_make_all_visible, tui_make_all_invisible): Update.
3358         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3359         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3360         bool.
3361         (struct tui_win_info, struct tui_source_window_base)
3362         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3363         * tui/tui-data.c (tui_init_generic_part): Update.
3364
3365 2019-06-25  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3368         (tui_source_window_base::make_visible): New methods.
3369         (make_all_visible): Make method call.
3370         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3371         (struct tui_source_window_base, struct tui_cmd_window): Override
3372         make_visible.
3373         (tui_win_is_source_type): Don't declare.
3374         * tui/tui-data.c (tui_win_is_source_type): Remove.
3375
3376 2019-06-25  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3379         NULL check.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3384         Inline constructor.  Add initializers for members.
3385         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3386         constructors; now inline in class.
3387
3388 2019-06-25  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-regs.c (tui_show_registers): Update.
3391         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3392         bool.
3393         * tui/tui-data.c (tui_data_window::clear_detail)
3394         (tui_data_window): Update.
3395
3396 2019-06-25  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-windata.c (tui_display_all_data)
3399         (tui_display_data_from_line, tui_display_data_from)
3400         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3401         Update.
3402         * tui/tui-regs.c (tui_last_regs_line_no)
3403         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3404         (tui_show_registers, tui_show_register_group)
3405         (tui_display_registers_from, tui_display_reg_element_at_line)
3406         (tui_display_registers_from_line, tui_check_register_values)
3407         (tui_reg_next, tui_reg_prev): Update.
3408         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3409         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3410         tui_data_window.
3411         (struct tui_win_info) <detail>: Remove.  Add new fields from
3412         tui_data_info.
3413         (TUI_DATA_WIN): Add cast.
3414         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3415         (~tui_data_window): Simplify.
3416
3417 2019-06-25  Tom Tromey  <tom@tromey.com>
3418
3419         * tui/tui-layout.c (show_source_disasm_command)
3420         (show_source_or_disasm_and_command): Update.
3421         * tui/tui-io.c (update_cmdwin_start_line)
3422         (tui_redisplay_readline): Update.
3423         * tui/tui-data.h (struct tui_command_info): Remove.
3424         (struct tui_win_info) <detail>: Remove command_info member.
3425         (struct tui_data_window) <start_line>: New member, from
3426         tui_command_info.
3427         (TUI_CMD_WIN): Add casts.
3428
3429 2019-06-25  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-winsource.c (tui_update_source_window)
3432         (tui_refill_source_window)
3433         (tui_source_window_base::do_scroll_horizontal)
3434         (tui_update_breakpoint_info, tui_set_exec_info_content)
3435         (tui_show_exec_info_content, tui_erase_exec_info_content)
3436         (tui_clear_exec_info_content): Update.
3437         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3438         Update.
3439         * tui/tui-win.c (make_invisible_and_set_new_height)
3440         (make_visible_with_new_height): Update.
3441         * tui/tui-source.c (tui_set_source_content)
3442         (tui_show_symtab_source): Update.
3443         * tui/tui-layout.c (extract_display_start_addr)
3444         (show_source_disasm_command, show_data)
3445         (make_source_or_disasm_window)
3446         (show_source_or_disasm_and_command): Update.
3447         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3448         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3449         "gdbarch".
3450         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3451         to tui_source_window_base.
3452         (struct tui_win_info) <detail>: Remove source_info member.
3453         (struct tui_source_window_base) <has_locator>: Inline.
3454         Move contents from tui_source_info; rename has_locator member to
3455         m_has_locator.
3456         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3457         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3458         header file.
3459         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3460         Simplify.
3461         (tui_free_all_source_wins_content): Cast to
3462         tui_source_window_base.
3463
3464 2019-06-25  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-win.c (make_invisible_and_set_new_height)
3467         (make_visible_with_new_height): Call has_locator method.
3468         * tui/tui-layout.c (show_source_disasm_command, show_data)
3469         (show_source_or_disasm_and_command): Update for bool change.
3470         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3471         (tui_win_info) <has_locator>: New method.
3472         (struct tui_source_window_base) <has_locator>: New method.
3473         (tui_win_has_locator): Don't declare.
3474         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3475         from tui_win_has_locator.
3476         (tui_source_window_base): Use false, not FALSE.
3477
3478 2019-06-25  Tom Tromey  <tom@tromey.com>
3479
3480         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3481         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3482         clear_detail method directly.
3483         (tui_clear_win_detail): Remove.
3484
3485 2019-06-25  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3488         "this", not TUI_DISASM_WIN.
3489
3490 2019-06-25  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3493         declare.
3494         * tui/tui-winsource.c
3495         (tui_source_window_base::do_scroll_horizontal): Rename from
3496         tui_horizontal_source_scroll.
3497         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3498         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3499         from tui_vertical_data_scroll.
3500         * tui/tui-win.h (tui_scroll): Don't declare.
3501         * tui/tui-win.c (tui_win_info::forward_scroll)
3502         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3503         (tui_win_info::right_scroll): Rename and update.
3504         (tui_scroll_forward_command, tui_scroll_backward_command)
3505         (tui_scroll_left_command, tui_scroll_right_command): Update.
3506         (tui_scroll): Remove.
3507         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3508         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3509         from tui_vertical_source_scroll.
3510         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3511         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3512         from tui_vertical_disassem_scroll.
3513         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3514         do_scroll_horizontal>: New methods.
3515         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3516         Likewise.
3517         (struct tui_source_window_base): Add do_scroll_horizontal.
3518         (struct tui_source_window, struct tui_disasm_window): Add
3519         do_scroll_vertical.
3520         (struct tui_data_window, struct tui_cmd_window): Add
3521         do_scroll_horizontal and do_scroll_vertical.
3522         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-data.h (struct tui_source_window_base): New struct.
3527         (struct tui_source_window): Derive from tui_source_window_base.
3528         (struct tui_disasm_window): New struct.
3529         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3530         from tui_source_window::clear_detail.
3531         (tui_source_window_base): Rename from tui_source_window.
3532         (~tui_source_window_base): Rename from ~tui_source_window.
3533         (tui_alloc_win_info): Create a tui_disasm_window.
3534
3535 2019-06-25  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-data.h (struct tui_source_window)
3538         (struct tui_data_window): Declare destructors.
3539         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3540         destructors.
3541         (tui_win_info): Simplify.
3542
3543 2019-06-25  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-winsource.c (tui_display_main)
3546         (tui_update_source_windows_with_addr)
3547         (tui_update_all_breakpoint_info): Update.
3548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3549         (new_height_ok, parse_scrolling_args): Update.
3550         * tui/tui-stack.c (tui_show_frame_info): Update.
3551         * tui/tui-data.h (struct tui_list): Remove.
3552         (tui_source_windows): Return a reference to a std::vector.
3553         * tui/tui-data.c (source_windows): Now a std::vector.
3554         (tui_source_windows): Change return type.
3555         (tui_clear_source_windows): Rewrite.
3556         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3557         (tui_free_all_source_wins_content): Rewrite.
3558
3559 2019-06-25  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3562         (struct tui_data_window, struct tui_cmd_window): Declare
3563         clear_detail method.
3564         * tui/tui-data.c (tui_source_window::clear_detail)
3565         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3566         methods.
3567         (tui_clear_win_detail): Simplify.
3568
3569 2019-06-25  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-layout.c (make_source_window, make_disasm_window)
3572         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3573         Return the new window.
3574         (show_source_disasm_command, show_data)
3575         (show_source_or_disasm_and_command): Update.
3576
3577 2019-06-25  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3580         parameter.  Return the new window.
3581         (show_source_disasm_command): Update and remove NULL check.
3582         (show_source_or_disasm_and_command): Update.
3583
3584 2019-06-25  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-data.h (struct tui_win_info): Make constructor
3591         protected.  Make destructor virtual.  Add initializers.
3592         (tui_source_window, tui_data_window, tui_cmd_window): New
3593         classes.
3594         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3595         constructor.  Add "type" parameter.
3596         (tui_source_window, tui_data_window, tui_cmd_window): New
3597         constructors.
3598         (tui_alloc_win_info): Instantiate the appropriate subclass.
3599
3600 2019-06-25  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui-win.c (tui_resize_all): Use delete.
3603         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3604         destructor.
3605         (tui_free_window): Don't declare.
3606         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3607         Update.
3608
3609 2019-06-25  Tom Tromey  <tom@tromey.com>
3610
3611         * tui/tui-data.h (struct tui_win_info): Add constructor.
3612         * tui/tui-data.c (tui_alloc_win_info): Use new.
3613         (tui_free_window): Use delete.
3614
3615 2019-06-22  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3618         declare.
3619         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3620
3621 2019-06-22  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3624         declare.
3625         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3626
3627 2019-06-22  Tom de Vries  <tdevries@suse.de>
3628
3629         * dwarf2read.c (create_addrmap_from_aranges)
3630         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3631         instead of '%zu'.
3632
3633 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3634
3635         * dwarf2read.h (dwarf2_section_info_def): Remove.
3636         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3637         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3638         std::vector<dwarf2_section_info>.
3639         (struct dwo_file) <~dwo_file>: Remove.
3640         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3641         types field.
3642         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3643         (dwarf2_read_debug_names): Likewise.
3644         (create_debug_types_hash_table): Change parameter type to
3645         array_view, adjust code accordingly.
3646         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3647         (partial_die_info::fixup): Likewise.
3648         (determine_prefix): Likewise.
3649         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3650
3651 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3652
3653         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3654         gdb_bfd_ref_ptr.
3655         <~dwo_file>: Remove call to gdb_bfd_unref.
3656         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3657         gdb_bfd_ref_ptr::get.
3658
3659 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3660
3661         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3662         type to htab_up.
3663         * dwarf2read.c (struct dwo_file): Initialize fields.
3664         <~dwo_file>: New.
3665         (free_dwo_file): Remove, move content to ~dwo_file.
3666         (struct dwo_file_deleter): Remove.
3667         (dwo_file_up>: Remove custom deleter.
3668         (free_dwo_files): Remove.
3669         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3670         dwo_files.
3671         (process_skeletonless_type_units): Call unique_ptr::get.
3672         (allocate_dwo_file_hash_table): Add deleter to created hash
3673         table.  Change return type to htab_up.
3674         (lookup_dwo_file_slot): Don't memset dwo_file, call
3675         unique_ptr::get.
3676         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3677         (create_dwo_unit_in_dwp_v2): Likewise.
3678         (open_and_init_dwo_file): Likewise.
3679         (free_dwo_file_from_slot): Remove.
3680
3681 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3682
3683         * dwarf2read.h (struct dwarf2_section_info) <readin,
3684         is_virtual>: Change type to bool.
3685         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3686         true instead of 1.
3687
3688 2019-06-19  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-data.h (tui_init_content_element): Don't declare.
3691
3692 2019-06-19  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui-data.h (tui_init_win_info): Don't declare.
3695
3696 2019-06-19  Tom de Vries  <tdevries@suse.de>
3697
3698         * dwarf2read.h (abstract_to_concrete): Change type to
3699         std::unordered_map<sect_offset, std::vector<sect_offset>,
3700         gdb::hash_enum<sect_offset>>.
3701
3702 2019-06-19  Tom Tromey  <tromey@adacore.com>
3703
3704         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3705         EVAL_AVOID_SIDE_EFFECTS specially.
3706
3707 2019-06-19  Tom Tromey  <tromey@adacore.com>
3708
3709         * source-cache.c (highlighter): New global.
3710         (source_cache::get_source_lines): Create a highlighter on demand.
3711
3712 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * defs.h (deprecated_interactive_hook): Delete declaration.
3715         * interps.c (clear_interpreter_hooks): Remove use of
3716         deprecated_interactive_hook.
3717         * top.c (deprecated_interactive_hook): Delete definition.
3718         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3719
3720 2019-06-18  Tom de Vries  <tdevries@suse.de>
3721
3722         PR gdb/24515
3723         * dwarf2read.h (abstract_to_concrete): Change type from
3724         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3725         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3726         * dwarf2read.c (read_variable): Update.
3727         (dwarf2_fetch_die_loc_sect_off): Update.
3728
3729 2019-06-17  Tom de Vries  <tdevries@suse.de>
3730
3731         PR gdb/24617
3732         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3733         accessing parent[parent_len - 1].
3734
3735 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3736
3737         PR gdb/24364
3738         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3739         call dtrace_process_dof with NULL dof.
3740
3741 2019-06-16  Tom de Vries  <tdevries@suse.de>
3742
3743         PR gdb/24445
3744         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3745
3746 2019-06-16  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3749         (make_all_visible): Use address of member.
3750
3751 2019-06-16  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3754         (tui_free_window, free_content, free_content_elements): Remove
3755         unnecessary cast.
3756         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3757         cast.
3758         * tui/tui-regs.c (tui_show_register_group)
3759         (tui_display_registers_from, tui_display_reg_element_at_line):
3760         Remove unnecessary cast.
3761
3762 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * linux-nat.c (normal_mask): Delete.
3765         (_initialize_linux_nat): Don't initialise normal_mask.
3766
3767 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3768
3769         PR gdb/24445
3770         * dwarf-index-write.h (write_psymtabs_to_index): Add
3771         dwz_basename parameter.
3772         * dwarf-index-write.c (write_gdbindex): Move file writing to
3773         write_gdbindex_1.  Change return type void.
3774         (assert_file_size): Move up, remove filename parameter.
3775         (write_gdbindex_1): New function.
3776         (write_debug_names): Change return type to void, call
3777         assert_file_size.
3778         (struct index_wip_file): New struct.
3779         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3780         file logic to index_wip_file.  Write index for dwz file if
3781         needed.
3782         (save_gdb_index_command): Pass basename of dwz file, if present.
3783         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3784         build-id of dwz file, if present.
3785         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3786         (dwarf2_get_dwz_file): Likewise.
3787         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3788         (dwarf2_get_dwz_file): Likewise.
3789
3790 2019-06-16  Tom Tromey  <tom@tromey.com>
3791
3792         * coffread.c (process_coff_symbol): Use xstrdup.
3793         * value.c (create_internalvar): Use xstrdup.
3794
3795 2019-06-16  Tom Tromey  <tom@tromey.com>
3796
3797         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3798         * breakpoint.c (stopin_command, stopat_command)
3799         (until_break_command, decode_location_default): Remove unnecessary
3800         cast.
3801         * utils.c (subset_compare): Remove unnecessary cast.
3802         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3803         cast.
3804         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3805         cast.
3806         * infcmd.c (path_command): Remove unnecessary cast.
3807         * coffread.c (decode_type): Remove unnecessary cast.
3808         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3809         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3810         * tui/tui-stack.c (tui_show_locator_content)
3811         (tui_show_frame_info): Remove unnecessary cast.
3812         * tui/tui-win.c (tui_scroll_forward_command)
3813         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3814         (parse_scrolling_args): Remove unnecessary cast.
3815         * tui/tui-data.c (init_win_info, tui_del_window)
3816         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3817         (free_content_elements): Remove unnecessary cast.
3818         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3819         unnecessary cast.
3820         * tui/tui-source.c (tui_set_source_content)
3821         (tui_vertical_source_scroll): Remove unnecessary cast.
3822         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3823         cast.
3824         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3825         * tui/tui-regs.c (tui_display_registers_from)
3826         (tui_display_register): Remove unnecessary cast.
3827         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3828         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3829         (make_visible): Remove unnecessary cast.
3830         * tui/tui-winsource.c (tui_erase_source_content)
3831         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3832         unnecessary cast.
3833         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3834         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3835         * stabsread.c (read_type, read_array_type, read_range_type):
3836         Remove unnecessary cast.
3837         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3838         (parse_symbol, parse_type, upgrade_type, parse_external)
3839         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3840         unnecessary cast.
3841         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3842
3843 2019-06-16  Tom Tromey  <tom@tromey.com>
3844
3845         * tui/tui-data.c (tui_alloc_generic_win_info)
3846         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3847         checks.
3848
3849 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3850             Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * f-typeprint.c (f_print_type): Don't return early for not
3853         associated or not allocated types.
3854         (f_type_print_varspec_suffix): Add print_rank parameter and print
3855         ranks of array types in case they dangling.
3856         (f_type_print_base): Add print_rank parameter.
3857
3858 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * NEWS: Mention new MI commands.
3861         * break-catch-throw.c (enum exception_event_kind): Move to
3862         breakpoint.h.
3863         (print_mention_exception_catchpoint): Output text as a single
3864         message.
3865         (catch_exception_command_1): Rename to...
3866         (catch_exception_event): ...this, make non-static, update header
3867         command, and change some parameter types.
3868         (catch_catch_command): Update for changes to
3869         catch_exception_command_1.
3870         (catch_throw_command): Likewise.
3871         (catch_rethrow_command): Likewise.
3872         * breakpoint.c (enum exception_event_kind): Delete.
3873         * breakpoint.h (enum exception_event_kind): Moved here from
3874         break-catch-throw.c.
3875         (catch_exception_event): Declare.
3876         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3877         (mi_cmd_catch_throw): New function.
3878         (mi_cmd_catch_rethrow): New function.
3879         (mi_cmd_catch_catch): New function.
3880         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3881         'catch-catch' entries.
3882         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3883         (mi_cmd_catch_rethrow): Declare.
3884         (mi_cmd_catch_catch): Declare.
3885
3886 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * annotate.c (annotate_source_line): Change return type to void,
3889         update implementation to match.
3890         * annotate.h (annotate_source_line): Change return type to void,
3891         update header comment.
3892         * stack.c (print_frame_info): Don't change what frame information
3893         is printed based on whether annotations are on or not.
3894
3895 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3898         (annotate_source): Make static.
3899         (annotate_source_line): Moved from source.c and renamed from
3900         identify_source_line.  Update the return type.
3901         * annotate.h (annotate_source): Delete declaration.
3902         (annotate_source_line): Declaration moved from source.h, and
3903         renamed from identify_source_line.  Return type updated.
3904         * source.c (identify_source_line): Moved to annotate.c and renamed
3905         to annotate_source_line.
3906         (info_line_command): Remove check of annotation_level.
3907         * source.h (identify_source_line): Move declaration to annotate.h
3908         and rename to annotate_source_line.
3909         * stack.c: Add 'annotate.h' include.
3910         (print_frame_info): Remove check of annotation_level before
3911         calling annotate_source_line.
3912
3913 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * source-cache.c (source_cache::get_plain_source_lines): Use
3916         open_source_file_with_line_charpos instead of just
3917         open_source_file, remove call to find_source_lines.
3918         (source_cache::get_source_lines): Likewise.
3919         * source.c (find_source_lines): Make static.
3920         (get_filename_and_charpos): Renamed into...
3921         (open_source_file_with_line_charpos): ..this along with changes to
3922         return a scoped_fd, and some other minor clean ups.
3923         (identify_source_line): Use open_source_file_with_line_charpos.
3924         (search_command_helper): Use open_source_file_with_line_charpos
3925         instead of just open_source_file, remove call to
3926         find_source_lines.
3927         * source.h (open_source_file_with_line_charpos): Declare new
3928         function.
3929         (find_source_lines): Delete declaration.
3930
3931 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * source.c (get_filename_and_charpos): Remove fullname
3934         parameter.
3935         (identify_source_line): Update call to get_filename_and_charpos.
3936
3937 2019-06-14  Tom Tromey  <tromey@adacore.com>
3938
3939         PR gdb/24502:
3940         * ui-style.h (skip_ansi_escape): Update comment.
3941         * ui-file.h (class no_terminal_escape_file): New class.
3942         * ui-file.c (no_terminal_escape_file::write)
3943         (no_terminal_escape_file::puts): New methods.
3944         * cli/cli-logging.c (handle_redirections): Use
3945         no_terminal_escape_file.
3946
3947 2019-06-14  Tom Tromey  <tromey@adacore.com>
3948
3949         * NEWS: Move convenience variable news above Python news.
3950
3951 2019-06-14  Tom Tromey  <tom@tromey.com>
3952
3953         * gnulib: Move directory to top-level.
3954         * configure.ac: Don't configure gnulib.
3955         * configure: Rebuild.
3956         * common/common-defs.h: Use new path to gnulib.
3957         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3958         (GNULIB_H): Remove.
3959         (INCGNU): Look in new gnulib location.
3960         (HFILES_NO_SRCDIR): Remove gnulib files.
3961         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3962         (generated_files): Remove GNULIB_H.
3963         ($(LIBGNU), all-lib): Remove targets.
3964         (distclean): Don't mention GNULIB_BUILDDIR.
3965         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3966
3967 2019-06-14  Tom Tromey  <tromey@adacore.com>
3968
3969         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3970         Warn if symbol file does not provide any symbols.
3971
3972 2019-06-14  Tom Tromey  <tromey@adacore.com>
3973
3974         * source.c (find_and_open_source): Respect basenames_may_differ.
3975
3976 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * annotate.c (annotate_breakpoints_invalid): Make use of
3979         scoped_restore_terminal_state.
3980         (annotate_frames_invalid): Likewise.
3981
3982 2019-06-14  Tom Tromey  <tromey@adacore.com>
3983
3984         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3985         allow assignment to an internalvar.
3986
3987 2019-06-14  Tom Tromey  <tromey@adacore.com>
3988
3989         * ada-lex.l: Allow "_" in attribute names.
3990
3991 2019-06-14  Tom Tromey  <tromey@adacore.com>
3992
3993         PR gdb/24653:
3994         * regcache.c (registers_changed): Don't call alloca.
3995         * top.c (execute_command): Don't call alloca.
3996
3997 2019-06-13  Pedro Alves  <palves@redhat.com>
3998
3999         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4000         'expression'.  When parsing an expression, error out if there's
4001         junk after "unlimited".
4002         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4003         (do_set_command): Adjust calls to is_unlimited_literal.
4004
4005 2019-06-13  Pedro Alves  <palves@redhat.com>
4006
4007         * compile/compile.c (make_compile_options_def_group): Add braces
4008         around array_view initializer.
4009         * thread.c (make_thread_apply_all_options_def_group)
4010         (make_thread_apply_all_options_def_group): Likewise.
4011
4012 2019-06-13  Pedro Alves  <palves@redhat.com>
4013
4014         * NEWS (New commands): Mention "maint test-options
4015         require-delimiter", "maint test-options unknown-is-error", "maint
4016         test-options unknown-is-operand" and "maint show
4017         test-options-completion-result".
4018         (New command options, command completion): New section.
4019         (Completion improvements): New section.
4020         Mention that you can abbreviate "unlimited".
4021
4022 2019-06-13  Pedro Alves  <palves@redhat.com>
4023
4024         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4025         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4026         * unittests/cli-utils-selftests.c (test_parse_flags)
4027         (test_parse_flags_qcs): Delete.
4028         (test_cli_utils): Don't call deleted functions.
4029
4030 2019-06-13  Pedro Alves  <palves@redhat.com>
4031
4032         * thread.c: Include "cli/cli-option.h".
4033         (tp_array_compar_ascending): Global.
4034         (tp_array_compar): Delete function.
4035         (tp_array_compar_ascending, tp_array_compar_descending): New
4036         functions.
4037         (ascending_option_def, qcs_flag_option_def)
4038         (thr_qcs_flags_option_defs)
4039         (make_thread_apply_all_options_def_group)
4040         (make_thread_apply_options_def_group): New.
4041         (thread_apply_all_command): Use gdb::option::process_options.
4042         (thread_apply_command_completer)
4043         (thread_apply_all_command_completer): New.
4044         (thread_apply_command): Use gdb::option::process_options.
4045         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4046         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4047         to generate help text of "thread apply".  Adjust "taas"'s help.
4048         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4049         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4050
4051 2019-06-13  Pedro Alves  <palves@redhat.com>
4052
4053         * thread.c (thread_apply_command): Check for invalid TID with
4054         isdigit instead of !isalpha.
4055
4056 2019-06-13  Pedro Alves  <palves@redhat.com>
4057
4058         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4059         (validate_flags_qcs): New.
4060         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4061         (validate_flags_qcs): Declare.
4062         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4063         (make_frame_apply_options_def_group): New.
4064         (frame_apply_command_count): Process options with
4065         gdb::option::process_options.
4066         (frame_apply_completer): New.
4067         (frame_apply_level_completer, frame_apply_all_completer)
4068         (frame_apply_completer): New.
4069         (_initialize_stack): Update help of "frame apply", "frame apply
4070         level", "frame apply all" and "faas" to mention supported options
4071         and install command completers.
4072         * stack.h (frame_apply_all_completer): Declare.
4073         * thread.c: Include "stack.h".
4074         (tfaas_command): Add "--".
4075         (_initialize_thread): Update help "tfaas" to mention supported
4076         options and install command completer.
4077
4078 2019-06-13  Pedro Alves  <palves@redhat.com>
4079
4080         * completer.c (complete_nested_command_line): New.
4081         (gdb_completion_word_break_characters_throw): Add assertion.
4082         * completer.h (complete_nested_command_line): Declare.
4083
4084 2019-06-13  Pedro Alves  <palves@redhat.com>
4085
4086         * stack.c (parse_backtrace_qualifiers): New.
4087         (backtrace_command): Use it.
4088         (backtrace_command_completer): Complete on qualifiers.
4089
4090 2019-06-13  Pedro Alves  <palves@redhat.com>
4091
4092         * frame.c: Include "cli/cli-option.h.
4093         (user_set_backtrace_options): New.
4094         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4095         Delete.
4096         (get_prev_frame): Adjust.
4097         (boolean_option_def, uinteger_option_def)
4098         (set_backtrace_option_defs): New.
4099         (_initialize_frame): Adjust and use
4100         gdb::option::add_setshow_cmds_for_options to install "set
4101         backtrace past-main" and "set backtrace past-entry".
4102         * frame.h: Include "cli/cli-option.h".
4103         (struct frame_print_options): Forward declare.
4104         (print_frame_arguments_all, print_frame_arguments_scalars)
4105         (print_frame_arguments_none): Declare.
4106         (print_entry_values): Delete declaration.
4107         (struct frame_print_options, user_frame_print_options): New.
4108         (struct set_backtrace_options): New.
4109         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4110         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4111         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4112         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4113         (list_args_or_locals): Add frame_print_options parameter.
4114         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4115         * python/py-framefilter.c (enumerate_args): Pass down
4116         USER_FRAME_PRINT_OPTIONS.
4117         * stack.c: Include "cli/cli-option.h".
4118         (print_frame_arguments_all, print_frame_arguments_scalars)
4119         (print_frame_arguments_none): Declare.
4120         (print_raw_frame_arguments, print_entry_values): Delete.
4121         (user_frame_print_options): New.
4122         (boolean_option_def, enum_option_def, frame_print_option_defs):
4123         New.
4124         (struct backtrace_cmd_options): New.
4125         (bt_flag_option_def): New.
4126         (backtrace_command_option_defs): New.
4127         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4128         (print_frame_arg, read_frame_arg, print_frame_args)
4129         (print_frame_info, print_frame): Add frame_print_options parameter
4130         and use it.
4131         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4132         (backtrace_command_1): Add frame_print_options and
4133         backtrace_cmd_options parameters and use them.
4134         (make_backtrace_options_def_group): New.
4135         (backtrace_command): Process command options with
4136         gdb::option::process_options.
4137         (backtrace_command_completer): New.
4138         (_initialize_stack): Extend "backtrace"'s help to mention
4139         supported options.  Install completer for "backtrace".
4140         Install some settings commands with add_setshow_cmds_for_options.
4141
4142 2019-06-13  Pedro Alves  <palves@redhat.com>
4143
4144         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4145         and that "set/show print raw frame-arguments" are now deprecated.
4146
4147         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4148         command.
4149         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4150         * stack.c (_initialize_stack): Install "set/show print
4151         raw-frame-arguments", and deprecate "set/show print raw
4152         frame-arguments".
4153         * valprint.c (_initialize_valprint): Deprecate "set/show print
4154         raw".
4155
4156 2019-06-13  Pedro Alves  <palves@redhat.com>
4157
4158         * compile/compile.c (struct compile_options): New.
4159         (compile_flag_option_def, compile_command_option_defs)
4160         (make_compile_options_def_group): New.
4161         (compile_file_command): Handle options with
4162         gdb::option::process_options.
4163         (compile_file_command_completer): New function.
4164         (compile_code_command): Handle options with
4165         gdb::option::process_options.
4166         (compile_code_command_completer): New function.
4167         (_initialize_compiler): Install completers for "compile code" and
4168         "compile file".  Mention available options in "compile code" and
4169         "compile code"'s help.
4170         * completer.c (advance_to_completion_word): New, factored out from
4171         ...
4172         (advance_to_expression_complete_word_point): ... this.
4173         (advance_to_filename_complete_word_point): New.
4174         * completer.h (advance_to_filename_complete_word_point): New
4175         declaration.
4176
4177 2019-06-13  Pedro Alves  <palves@redhat.com>
4178
4179         * compile/compile.c: Include "cli/cli-option.h".
4180         (compile_print_value): Scope data pointer is now a
4181         value_print_options pointer; adjust.
4182         (compile_print_command): Process options.  Scope data pointer is
4183         now a value_print_options pointer; adjust.
4184         (_initialize_compile): Update "compile print"'s help to include
4185         supported options.  Install a completer for "compile print".
4186         * cp-valprint.c (show_vtblprint, show_objectprint)
4187         (show_static_field_print): Delete.
4188         (_initialize_cp_valprint): Don't install "set print
4189         static-members", "set print vtbl", "set print object" here.
4190         * printcmd.c: Include "cli/cli-option.h" and
4191         "common/gdb_optional.h".
4192         (print_command_parse_format): Rework to fill in a
4193         value_print_options instead of a format_data.
4194         (print_value): Change parameter type from format_data pointer to
4195         value_print_options reference.  Adjust.
4196         (print_command_1): Process options.  Adjust to pass down a
4197         value_print_options.
4198         (print_command_completer): New.
4199         (_initialize_printcmd): Install print_command_completer as
4200         handle_brkchars completer for the "print" command.  Update
4201         "print"'s help to include supported options.
4202         * valprint.c: Include "cli/cli-option.h".
4203         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4204         here from cp-valprint.c.
4205         (boolean_option_def, uinteger_option_def)
4206         (value_print_option_defs, make_value_print_options_def_group):
4207         New.  Use gdb::option::add_setshow_cmds_for_options to install
4208         "set print elements", "set print null-stop", "set print repeats",
4209         "set print pretty", "set print union", "set print array", "set
4210         print address", "set print symbol", "set print array-indexes".
4211         * valprint.h: Include <string> and "cli/cli-option.h".
4212         (make_value_print_options_def_group): Declare.
4213         (print_value): Change parameter type from format_data pointer to
4214         value_print_options reference.
4215         (print_command_completer): Declare.
4216
4217 2019-06-13  Pedro Alves  <palves@redhat.com>
4218
4219         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4220         (COMMON_SFILES): Add maint-test-settings.c.
4221         * cli/cli-decode.c (boolean_enums): New global, factored out from
4222         ...
4223         (add_setshow_boolean_cmd): ... here.
4224         * cli/cli-decode.h (boolean_enums): Declare.
4225         * cli/cli-option.c: New file.
4226         * cli/cli-option.h: New file.
4227         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4228         factored out from ...
4229         (parse_cli_boolean_value(const char *)): ... this.
4230         (is_unlimited_literal): Change parameter type to pointer to
4231         pointer.  Adjust and advance ARG pointer.
4232         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4233         (parse_cli_var_enum): New, factored out from ...
4234         (do_set_command): ... this.  Adjust.
4235         * cli/cli-setshow.h (parse_cli_boolean_value)
4236         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4237         (parse_cli_var_enum): Declare.
4238         * cli/cli-utils.c: Include "cli/cli-option.h".
4239         (get_ulongest): New.
4240         * cli/cli-utils.h (get_ulongest): Declare.
4241         (check_for_argument): New overloads.
4242         * maint-test-options.c: New file.
4243
4244 2019-06-13  Pedro Alves  <palves@redhat.com>
4245
4246         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4247         parse a range if "-" is at the end of the string.
4248
4249 2019-06-13  Pedro Alves  <palves@redhat.com>
4250
4251         * cli/cli-setshow.c (parse_auto_binary_operation)
4252         (parse_cli_boolean_value): Don't allow "o".
4253
4254 2019-06-13  Pedro Alves  <palves@redhat.com>
4255
4256         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4257         * NEWS: Mention maint test-settings KIND.
4258         * maint-test-settings.c: New file.
4259
4260 2019-06-13  Pedro Alves  <palves@redhat.com>
4261
4262         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4263         completer.
4264         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4265         "set" completers.
4266
4267 2019-06-13  Pedro Alves  <palves@redhat.com>
4268
4269         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4270         after item.
4271
4272 2019-06-13  Pedro Alves  <palves@redhat.com>
4273
4274         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4275
4276 2019-06-13  Pedro Alves <palves@redhat.com>
4277
4278         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4279         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4280         call.
4281         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4282         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4283         calls.
4284         (check_for_argument): Skip spaces after argument.
4285
4286 2019-06-13  Pedro Alves  <palves@redhat.com>
4287
4288         * thread.c (thread_apply_command): Adjust TID parsing.
4289         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4290         detected before end of string.
4291         (tid_is_in_list): Error out if LIST is invalid.
4292
4293 2019-06-13  Pedro Alves  <palves@redhat.com>
4294
4295         * completer.c (complete_line_internal_1): Rewind completion word
4296         point.
4297         (completion_tracker::advance_custom_word_point_by): Change
4298         parameter type to int.
4299         * completer.h (completion_tracker::advance_custom_word_point_by):
4300         Likewise.
4301
4302 2019-06-13  Pedro Alves  <palves@redhat.com>
4303
4304         * completer.c (advance_to_completion_word): Handle delimiters.
4305
4306 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4307
4308         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4309
4310 2019-06-11  Tom Tromey  <tom@tromey.com>
4311
4312         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4313         (xmalloc_failed): Move to alloc.c.
4314         * alloc.c: New file.
4315         * Makefile.in (COMMON_SFILES): Add alloc.c.
4316
4317 2019-06-11  Tom Tromey  <tom@tromey.com>
4318
4319         * nat/linux-waitpid.c: Don't include server.h.
4320         (linux_debug): Remove.
4321         (my_waitpid): Update.
4322
4323 2019-06-11  Tom Tromey  <tromey@adacore.com>
4324
4325         * infcall.c (_initialize_infcall): Remove trailing newline from
4326         help.
4327         * user-regs.c (_initialize_user_regs): Remove trailing newline
4328         from help.
4329         * typeprint.c (_initialize_typeprint): Remove trailing newline
4330         from help.
4331         * reverse.c (_initialize_reverse): Remove trailing newlines from
4332         help.
4333         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4334         from help.
4335         * language.c (add_set_language_command): Remove trailing newline
4336         from help.
4337         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4338         help.
4339         * disasm.c (_initialize_disasm): Remove trailing newline from
4340         help.
4341         * top.c (init_main): Remove trailing newline from help.
4342         * interps.c (_initialize_interpreter): Remove trailing newline
4343         from help.
4344         * btrace.c (_initialize_btrace): Remove trailing newlines from
4345         help.
4346         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4347         from help.
4348         * python/python.c (_initialize_python): Remove trailing newline
4349         from help.
4350         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4351         help.
4352         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4353         from help.  Reformat some text.
4354         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4355         from help.
4356         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4357         newline from help.
4358
4359 2019-06-11  Tom Tromey  <tromey@adacore.com>
4360
4361         * darwin-nat.c (darwin_decode_exception_message)
4362         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4363
4364 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4365
4366         * valops.c (value_slice): Check for not allocated or not
4367         associated values.
4368
4369 2019-06-10  Tom de Vries  <tdevries@suse.de>
4370
4371         PR gdb/24618
4372         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4373         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4374         invalid.
4375
4376 2019-06-10  Tom de Vries  <tdevries@suse.de>
4377
4378         PR gdb/24611
4379         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4380         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4381
4382 2019-06-10  Tom de Vries  <tdevries@suse.de>
4383
4384         PR symtab/24545
4385         * symtab.c (struct demangled_name_entry): Add language field.
4386         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4387         static minimal symbol".  Set and use language field.
4388
4389 2019-06-10  Tom Tromey  <tromey@adacore.com>
4390
4391         * ada-lang.c (_initialize_ada_language): Update help text.
4392
4393 2019-06-10  Tom Tromey  <tromey@adacore.com>
4394
4395         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4396         with a newline.
4397         * guile/guile.c (handle_boot_error): Don't end warning with a
4398         newline.
4399         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4400         warning with a newline.
4401         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4402         newline.
4403         (s12z_frame_cache): Likewise.
4404         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4405         a newline.
4406         * solib-svr4.c (disable_probes_interface): Don't end warning with
4407         a newline.
4408         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4409         newline.
4410         * python/python.c (do_finish_initialization): Don't end warning
4411         with a newline.
4412
4413 2019-06-10  Tom Tromey  <tom@tromey.com>
4414
4415         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4416         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4417         gdbpy_enter.
4418
4419 2019-06-10  Tom Tromey  <tromey@adacore.com>
4420
4421         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4422         data.
4423         (elf_new_init): Don't call stabsread_new_init.
4424         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4425         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4426         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4427
4428 2019-06-10  Tom de Vries  <tdevries@suse.de>
4429
4430         PR symtab/16264
4431         PR symtab/24517
4432         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4433
4434 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4435
4436         * source.c (find_and_open_source): Also rewrite relative file
4437         names.
4438
4439 2019-04-26  Amos Bird  <amosbird@gmail.com>
4440
4441         * annotate.c (annotate_thread_exited): Add "thread-exited"
4442         annotation.
4443
4444 2019-06-06  Tom Tromey  <tromey@adacore.com>
4445
4446         * maint.h (class scoped_command_stats): Use
4447         DISABLE_COPY_AND_ASSIGN.
4448         <print_time>: New method.
4449         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4450         print_time.
4451         (scoped_command_stats::print_time): New method.
4452
4453 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4454
4455         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4456         instructions of lengths 6 or 8 bytes.
4457
4458 2019-06-04  Pedro Alves  <palves@redhat.com>
4459
4460         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4461
4462         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4463         * breakpoint.c (condition_completer): Likewise.
4464         * cli/cli-dump.c (scan_expression): Likewise.
4465         * common/filestuff.c (mkdir_recursive): Likewise.
4466         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4467         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4468         (gdb_abspath): Likewise.
4469         * compile/compile-cplus-types.c
4470         (compile_cplus_instance::decl_name): Likewise.
4471         * completer.c (complete_explicit_location):
4472         (signal_completer, reg_or_group_completer_1): Likewise.
4473         * cp-support.c (cp_remove_params_if_any): Likewise.
4474         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4475         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4476         * infcmd.c (strip_bg_char): Likewise.
4477         * linespec.c (copy_token_string): Likewise.
4478         * mi/mi-main.c (output_cores): Likewise.
4479         * psymtab.c (psymtab_search_name):
4480         * symfile.c (test_set_ext_lang_command): Likewise.
4481         * target.c (target_fileio_read_stralloc): Likewise.
4482         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4483         * value.c (complete_internalvar): Likewise.
4484
4485 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4486
4487         Add objfile property to gdb.Type.
4488         * NEWS: Mention Python API addition.
4489         * python/py-type.c (typy_get_objfile): New method.
4490
4491 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4492
4493         * NEWS: Mention the new set|show style [title|highlight].
4494         Mention changes to "show style", "help" and "apropos".
4495
4496 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4497
4498         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4499         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4500         instead of print_help_for_command.
4501         (print_doc_of_command): New function.
4502         (help_list): Add 'apropos -v word' suggestion.
4503         (print_help_for_command): Style the command name using title style.
4504         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4505         (_initialize_cli_cmds): Describe -v in apropos_command help.
4506
4507 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4508
4509         * cli/cli-style.h (cli_style_option): Add name in constructor,
4510         add m_name class member, add constructor with intensity,
4511         add name class function.
4512         (cli_style_option::add_setshow_commands): Remove name argument.
4513         (highlight_style, title_style): New styles.
4514         * cli/cli-style.c (do_show): New function that shows a style
4515         characteristic styling the style name with itself.
4516         (set_style_name): New function.
4517         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4518         Update all callers according to the changes in cli/cli-style.h.
4519         * utils.h (fputs_highlighted): New function.
4520         * utils.c (fputs_highlighted): Likewise.
4521
4522 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4523
4524         * NEWS: Mention new pipe command and new convenience variables.
4525
4526 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4527
4528         * cli/cli-cmds.c (pipe_command): New function.
4529         (_initialize_cli_cmds): Call add_com for pipe_command.
4530         Define | as an alias for pipe.
4531         (exit_status_set_internal_vars): New function.
4532         (shell_escape): Call exit_status_set_internal_vars.
4533         cli/cli-decode.c (find_command_name_length): Recognize | as
4534         a single character command.
4535
4536 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4537
4538         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4539         top.c (execute_command_to_ui_file): New function, mostly a copy
4540         of execute_command_to_string.
4541         (execute_command_to_string): Implement by calling
4542         execute_command_to_ui_file.
4543
4544 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4545
4546         * top.h (saved_command_line): Remove declaration.
4547         * top.c (previous_saved_command_line, previous_repeat_arguments):
4548         New variables.
4549         (saved_command_line): Make static, define together with other
4550         'repeat variables'.
4551         (dont_repeat): Clear repeat_arguments.
4552         (repeat_previous, get_saved_command_line, save_command_line):
4553         New functions.
4554         (gdb_init): Initialize saved_command_line
4555         and previous_saved_command_line.
4556         * main.c (captured_main_1): Remove saved_command_line initialization.
4557         * event-top.c (handle_line_of_input): Update to use
4558         the new 'repeat' related functions instead of direct access to
4559         saved_command_line.
4560         * command.h (repeat_previous, get_saved_command_line,
4561         save_command_line): New declarations.
4562         (dont_repeat): Add comment.
4563
4564 2019-05-30  Tom Tromey  <tromey@adacore.com>
4565
4566         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4567         Fix comment.
4568         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4569
4570 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4571
4572         PR cli/24587
4573         * completer.c (complete): Initialize variable word.
4574
4575 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4576
4577         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4578         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4579         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4580         'body' is NULL to the outter 'if', protecting the '!is_define'
4581         situation as well.
4582
4583 2019-05-29  Tom Tromey  <tromey@adacore.com>
4584
4585         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4586         (dwarf_unknown): New function.
4587         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4588         (dwarf_type_encoding_name): Use dwarf_unknown.
4589
4590 2019-05-29  Tom Tromey  <tromey@adacore.com>
4591
4592         PR c++/20020:
4593         * cp-valprint.c (cp_print_value_fields): Call
4594         cp_print_static_field inside "try".
4595
4596 2019-05-29  Tom Tromey  <tromey@adacore.com>
4597
4598         * inflow.c (struct terminal_info): Add default operator=.
4599         * configure: Rebuild.
4600         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4601         -Wdeprecated-copy-dtor, -Wredundant-move.
4602
4603 2019-05-29  Tom Tromey  <tromey@adacore.com>
4604
4605         * NEWS: Add entry.
4606         * infcmd.c (print_return_value_1): Handle finish_print
4607         option.
4608         (show_print_finish): New function.
4609         (_initialize_infcmd): Add "set/show print finish" commands.
4610         * valprint.c (user_print_options): Initialize new member.
4611         * valprint.h (struct value_print_options) <finish_print>: New
4612         member.
4613
4614 2019-05-28  Tom Tromey  <tromey@adacore.com>
4615
4616         * ada-lang.c (ada_remove_Xbn_suffix)
4617         (find_old_style_renaming_symbol)
4618         (parse_old_style_renaming): Remove.
4619         (ada_find_renaming_symbol): Don't call
4620         find_old_style_renaming_symbol.
4621         (ada_is_renaming_symbol): Rename from
4622         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4623         bool.  Now static.
4624         (ada_read_var_value): Update and simplify.
4625         * ada-exp.y (write_var_or_type): Remove old code.
4626
4627 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4628
4629         * event-top.c: Remove include comment.
4630         * inflow.c (class scoped_ignore_sigttou): Move from here...
4631         * inflow.h (class scoped_ignore_sigttou): ...to here.
4632         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4633         * top.c:  Remove include comment.
4634
4635 2019-05-27  Tom Tromey  <tom@tromey.com>
4636
4637         * NEWS: Fix typo.
4638
4639 2019-05-22  Tom Tromey  <tromey@adacore.com>
4640
4641         * target.c (target_follow_exec): Constify parameter.
4642         * target-delegates.c: Rebuild.
4643         * remote.c (remote_target::follow_exec): Constify parameter.
4644         * infrun.c (follow_exec): Constify parameter.
4645         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4646         (target_follow_exec): Likewise.
4647
4648 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4649
4650         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4651         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4652
4653 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4654
4655         * NEWS: Add debugredirect and testsuite sections.
4656
4657 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4658
4659         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4660         target descriptions using exclusively floating point register name
4661         aliases.
4662
4663 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         PR gdb/18644:
4666         * f-lang.c (build_fortran_types): Handle the case where
4667         gdbarch_floatformat_for_type returns a nullptr.
4668
4669 2019-05-21  Tom de Vries  <tdevries@suse.de>
4670
4671         PR cli/24587
4672         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4673
4674 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         PR gdb/18644:
4677         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4678         16-byte floats.
4679         * i386-tdep.c (i386_floatformat_for_type): Use
4680         floatformats_ia64_quad for the 16-byte floating point component
4681         within a fortran 32-byte complex number.
4682
4683 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4684
4685         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4686         delete default constructor.
4687         (find_partial_die): Update to return const struct.
4688         (partial_die_parent_scope): Move variable declaration into scope
4689         of its use and change its type to auto.
4690         (guess_partial_die_structure_name): Likewise.
4691         (partial_die_info::fixup): Likewise.
4692
4693 2019-05-17  Tom Tromey  <tromey@adacore.com>
4694
4695         * source.c (find_and_open_source): Remove cast.
4696
4697 2019-05-17  Tom Tromey  <tromey@adacore.com>
4698
4699         * annotate.c (annotate_source): Make "filename" const.
4700         * annotate.h (annotate_source): Use const.
4701
4702 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4703
4704         * disasm.c (set_disassembler_options): Send errors to stderr.
4705
4706 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4707
4708         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4709         (cli_interp_base::set_logging): Check debug_redirect.
4710         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4711         * cli/cli-logging.c (debug_redirect): Add static variable.
4712         (pop_output_files): Add default param.
4713         (handle_redirections): Print debug setting.
4714         (show_logging_command): Likewise.
4715         (_initialize_cli_logging): Add debugredirect command.
4716         * interps.c (current_interp_set_logging): Add debug_redirect
4717         parameter.
4718         * interps.h (set_logging): Add debug_redirect parameter.
4719         (current_interp_set_logging): Likewise.
4720         * mi/mi-common.h: Likewise.
4721         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4722
4723 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4724             Tom Tromey  <tromey@adacore.com>
4725
4726         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4727         directly.
4728         * cli/cli-interp.h (make_logging_output): Remove declaration.
4729         * cli/cli-logging.c (make_logging_output): Remove function.
4730         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4731         directly.
4732         * ui-file.c (tee_file::tee_file): Remove bools.
4733         (tee_file::~tee_file): Remove deletes.
4734         * ui-file.h (tee_file): Remove bools.
4735
4736 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4737
4738         * mi/mi-cmds.h (mi_cmd_complete): New function.
4739         * mi/mi-main.c (mi_cmd_complete): Likewise.
4740         * mi/mi-cmds.c: Define new MI command -complete.
4741         * NEWS: Mention new -complete command.
4742
4743 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4744
4745         * completer.h (complete): New function.
4746         * completer.c (complete): Likewise.
4747         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4748         function defined in completer.h.
4749
4750 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4751
4752         * MAINTAINERS (Write After Approval): Add myself.
4753
4754 2019-05-17  Tom de Vries  <tdevries@suse.de>
4755
4756         PR gdb/24094
4757         * dwarf2read.c (struct cu_partial_die_info): New struct.
4758         (find_partial_die): Return cu_partial_die_info.
4759         (partial_die_parent_scope, guess_partial_die_structure_name)
4760         (partial_die_info::fixup): Handle new return type of find_partial_die.
4761
4762 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4763
4764         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4765         "std::string", simplifying the algorithm.
4766
4767 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4768
4769         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4770         (stap_static_probe_ops::get_probes): Likewise.
4771
4772 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4773
4774         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4775         '-')" and "else if".
4776         (stap_parse_single_operand): Join checks for
4777         "gdbarch_stap_parse_special_token_p" and
4778         "gdbarch_stap_parse_special_token" in the same "if" statement.
4779         Invert check when verifying for operation on register
4780         displacement.
4781
4782 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4783
4784         * stap-probe.c (stap_get_opcode): Update comment.
4785         (stap_get_expected_argument_type): Likewise.
4786         (handle_stap_probe): Likewise.
4787
4788 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4789
4790         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4791         return type to 'bool'.  Adjust comment.  Use 'bool' when
4792         appropriate.
4793         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4794         * stap-probe.c (stap_parse_argument_1): Likewise.
4795         (stap_is_operator): Likewise.
4796         (stap_is_generic_prefix): Likewise.
4797         (stap_is_register_prefix): Likewise.
4798         (stap_is_register_indirection_prefix): Likewise.
4799         (stap_is_integer_prefix): Likewise.
4800         (stap_generic_check_suffix): Likewise.
4801         (stap_check_integer_suffix): Likewise.
4802         (stap_check_register_suffix): Likewise.
4803         (stap_check_register_indirection_suffix): Likewise.
4804         (stap_parse_register_operand): Likewise.
4805         (stap_parse_single_operand): Likewise.
4806         (stap_parse_argument_1): Likewise.
4807         (stap_probe::get_argument_count): Likewise.
4808         (stap_is_operator): Likewise.
4809
4810 2019-05-16  Tom Tromey  <tromey@adacore.com>
4811
4812         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4813         keyword to foreach.
4814
4815 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4816
4817         * linux-thread-db.c (try_thread_db_load_1): Change return type
4818         to bool.
4819         (try_thread_db_load): Likewise.
4820         (try_thread_db_load_from_pdir_1): Likewise.
4821         (try_thread_db_load_from_pdir): Likewise.
4822         (try_thread_db_load_from_sdir): Likewise.
4823         (try_thread_db_load_from_dir): Likewise.
4824         (thread_db_load_search): Likewise.
4825         (has_libpthread): Likewise.
4826         (thread_db_load): Likewise.
4827
4828 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4829
4830         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4831         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4832         NULL, and complain/return if that's the case.
4833
4834 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4835
4836         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4837         (advance, posn, abstract_read_memory): New functions.
4838         [struct mem_read_abstraction]: New struct.
4839         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4840
4841 2019-05-14  Tom Tromey  <tromey@adacore.com>
4842
4843         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4844         value is not lval_memory.
4845
4846 2019-05-14  Tom Tromey  <tromey@adacore.com>
4847
4848         * solib.c (info_sharedlibrary_command): Style the file name.
4849
4850 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4851
4852         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4853         (aarch64_vnv_type): Likewise.
4854         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4855         * common/tdesc.c: Likewise.
4856         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4857         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4858         * features/aarch64-fpu.xml: Add ieee half view.
4859         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4860         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4861         * gdbtypes.h (struct builtin_type): Likewise.
4862         (struct objfile_type): Likewise.
4863
4864 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4865
4866         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4867         typo.
4868         * location.h (string_to_event_location): Likewise.
4869
4870 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4871
4872         GDB 8.3 released.
4873
4874 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4875
4876         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4877         New variable declaration.
4878         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4879         New variable.
4880         (print_one_breakpoint): Use ui_out::test_flags and new global
4881         variable to compute use_fixed_output.
4882         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4883         Remove.
4884         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4885         (mi_multi_location_breakpoint_output_fixed): Remove.
4886         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4887         new variable.
4888         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4889         fix_multi_location_breakpoint_output flag if version >= 3.
4890         * ui-out.h (enum ui_out_flag)
4891         <fix_multi_location_breakpoint_output>: New enumerator.
4892
4893 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4894
4895         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4896
4897 2019-05-10  Tom Tromey  <tromey@adacore.com>
4898
4899         * ada-lang.c (catch_ada_completer): New function.
4900         (_initialize_ada_language): Use it.
4901
4902 2019-05-10  Tom Tromey  <tromey@adacore.com>
4903
4904         * thread.c (print_thread_info): Make "requested_threads" const.
4905         * gdbthread.h (print_thread_info): Make "requested_threads"
4906         const.
4907         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4908         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4909
4910 2019-05-08  Tom Tromey  <tom@tromey.com>
4911
4912         * gdbtypes.c (objfile_type_data): Change type.
4913         (objfile_type, _initialize_gdbtypes): Update.
4914
4915 2019-05-08  Tom Tromey  <tom@tromey.com>
4916
4917         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4918         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4919         (_initialize_dwarf2_frame): Update.
4920
4921 2019-05-08  Tom Tromey  <tom@tromey.com>
4922
4923         * objc-lang.c (objc_objfile_data): Change type.
4924         (find_methods): Update.
4925         (_initialize_objc_lang): Remove.
4926
4927 2019-05-08  Tom Tromey  <tom@tromey.com>
4928
4929         * stabsread.c (rs6000_builtin_type_data): Change type.
4930         (rs6000_builtin_type, _initialize_stabsread): Update.
4931
4932 2019-05-08  Tom Tromey  <tom@tromey.com>
4933
4934         * mips-tdep.c (mips_pdr_data): Remove.
4935         (_initialize_mips_tdep): Update.
4936
4937 2019-05-08  Tom Tromey  <tom@tromey.com>
4938
4939         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4940         (hppa_init_objfile_priv_data, read_unwind_info)
4941         (find_unwind_entry, _initialize_hppa_tdep): Update.
4942
4943 2019-05-08  Tom Tromey  <tom@tromey.com>
4944
4945         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4946         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4947         on obstack.
4948         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4949
4950 2019-05-08  Tom Tromey  <tom@tromey.com>
4951
4952         * mdebugread.c (basic_type_data): Change type.
4953         (basic_type, _initialize_mdebugread): Update.
4954
4955 2019-05-08  Tom Tromey  <tom@tromey.com>
4956
4957         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4958
4959 2019-05-08  Tom Tromey  <tom@tromey.com>
4960
4961         * nto-tdep.c (nto_inferior_data_reg): Change type.
4962         (nto_inferior_data): Update.
4963         (nto_inferior_data_cleanup, nto_new_inferior_data)
4964         (_initialize_nto_tdep): Remove.
4965         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4966
4967 2019-05-08  Tom Tromey  <tom@tromey.com>
4968
4969         * ada-lang.c (struct ada_inferior_data): Add initializers.
4970         (ada_inferior_data): Change type.
4971         (ada_inferior_data_cleanup): Remove.
4972         (get_ada_inferior_data, ada_inferior_exit)
4973         (struct ada_pspace_data): Add initializers, destructor.
4974         (ada_pspace_data_handle): Change type.
4975         (get_ada_pspace_data): Update.
4976         (ada_pspace_data_cleanup): Remove.
4977
4978 2019-05-08  Tom Tromey  <tom@tromey.com>
4979
4980         * coffread.c (struct coff_symfile_info): Add initializers.
4981         (coff_objfile_data_key): Move lower.  Change type.
4982         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4983         Update.
4984         (coff_free_info): Remove.
4985
4986 2019-05-08  Tom Tromey  <tom@tromey.com>
4987
4988         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4989         (fbsd_pspace_data_handle): Move lower.  Change type.
4990         (get_fbsd_pspace_data): Update.
4991         (fbsd_pspace_data_cleanup): Remove.
4992         (_initialize_fbsd_tdep): Update.
4993
4994 2019-05-08  Tom Tromey  <tom@tromey.com>
4995
4996         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4997         (get_ada_tasks_pspace_data): Update.
4998         (ada_tasks_pspace_data_cleanup): Remove.
4999         (_initialize_tasks): Update.
5000         (ada_tasks_inferior_data_handle): Change type.
5001         (get_ada_tasks_inferior_data): Update.
5002         (ada_tasks_inferior_data_cleanup): Remove.
5003         (struct ada_tasks_pspace_data): Add initializers.
5004
5005 2019-05-08  Tom Tromey  <tom@tromey.com>
5006
5007         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5008         * symfile-debug.c (debug_sym_get_probes): Change type.
5009         * stap-probe.c (handle_stap_probe):
5010         (stap_static_probe_ops::get_probes): Change type.
5011         * probe.h (class static_probe_ops) <get_probes>: Change type.
5012         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5013         (parse_probes_in_pspace): Update.
5014         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5015         Update.
5016         (any_static_probe_ops::get_probes): Change type.
5017         * elfread.c (elfread_data): New typedef.
5018         (probe_key): Change type.
5019         (elf_get_probes): Likewise.  Update.
5020         (probe_key_free): Remove.
5021         (_initialize_elfread): Update.
5022         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5023         Change type.
5024         (dtrace_process_dof_probe, dtrace_process_dof)
5025         (dtrace_static_probe_ops::get_probe): Change type.
5026
5027 2019-05-08  Tom Tromey  <tom@tromey.com>
5028
5029         * xcoffread.c (struct xcoff_symfile_info): Rename from
5030         coff_symfile_info.  Add initializers.
5031         (xcoff_objfile_data_key): Move lower.  Change type.
5032         (XCOFF_DATA): Rewrite.
5033         (xcoff_free_info): Remove.
5034         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5035         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5036         (xcoff_initial_scan): Update.
5037
5038 2019-05-08  Tom Tromey  <tom@tromey.com>
5039
5040         * solib-svr4.c (struct svr4_info): Add initializers and
5041         destructor.
5042         <probes_table>: Now an htab_up.
5043         (solib_svr4_pspace_data): Change type.
5044         (free_probes_table): Simplify.
5045         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5046         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5047         (probes_table_remove_objfile_probes, register_solib_event_probe)
5048         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5049         (_initialize_svr4_solib): Update.
5050
5051 2019-05-08  Tom Tromey  <tom@tromey.com>
5052
5053         * remote.c (remote_pspace_data): Change type.
5054         (remote_pspace_data_cleanup): Remove.
5055         (get_remote_exec_file, set_pspace_remote_exec_file)
5056         (_initialize_remote): Update.
5057
5058 2019-05-08  Tom Tromey  <tom@tromey.com>
5059
5060         * breakpoint.c (breakpoint_objfile_key): Change type.
5061         (get_breakpoint_objfile_data): Update.
5062         (free_breakpoint_objfile_data): Remove.
5063         (_initialize_breakpoint): Update.
5064
5065 2019-05-08  Tom Tromey  <tom@tromey.com>
5066
5067         * linux-tdep.c (struct linux_info): Add initializers.
5068         (linux_inferior_data): Move.  Change type.
5069         (invalidate_linux_cache_inf): Update.
5070         (linux_inferior_data_cleanup): Remove.
5071         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5072
5073 2019-05-08  Tom Tromey  <tom@tromey.com>
5074
5075         * auxv.c (auxv_inferior_data): Move.  Change type.
5076         (auxv_inferior_data_cleanup): Remove.
5077         (invalidate_auxv_cache_inf): Rewrite.
5078         (get_auxv_inferior_data, _initialize_auxv): Update.
5079
5080 2019-05-08  Tom Tromey  <tom@tromey.com>
5081
5082         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5083         (symfile_debug_objfile_data_key): Change type.
5084         (symfile_debug_installed, debug_qf_has_symbols)
5085         (debug_qf_find_last_source_symtab)
5086         (debug_qf_forget_cached_source_info)
5087         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5088         (debug_qf_print_stats, debug_qf_dump)
5089         (debug_qf_expand_symtabs_for_function)
5090         (debug_qf_expand_all_symtabs)
5091         (debug_qf_expand_symtabs_with_fullname)
5092         (debug_qf_map_matching_symbols)
5093         (debug_qf_expand_symtabs_matching)
5094         (debug_qf_find_pc_sect_compunit_symtab)
5095         (debug_qf_map_symbol_filenames)
5096         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5097         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5098         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5099         (debug_sym_read_linetable, debug_sym_relocate): Update.
5100         (symfile_debug_free_objfile): Remove.
5101         (install_symfile_debug_logging, _initialize_symfile_debug):
5102         Update.
5103
5104 2019-05-08  Tom Tromey  <tom@tromey.com>
5105
5106         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5107         allocate_on_obstack.
5108         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5109         (get_dwarf2_per_objfile): Update.
5110         (set_dwarf2_per_objfile): Remove.
5111         (dwarf2_has_info, dwarf2_get_section_info): Update.
5112         (dwarf2_free_objfile): Remove.
5113         (_initialize_dwarf2_read): Update.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5118         initializers.
5119         <unsupported_script_warning_printed,
5120         script_not_found_warning_printed>: Now bool.
5121         (auto_load_pspace_data): Change type.
5122         (~auto_load_pspace_info): Rename from
5123         auto_load_pspace_data_cleanup.
5124         (get_auto_load_pspace_data, init_loaded_scripts_info)
5125         (clear_section_scripts, maybe_print_unsupported_script_warning)
5126         (maybe_print_script_not_found_warning, _initialize_auto_load):
5127         Update.
5128
5129 2019-05-08  Tom Tromey  <tom@tromey.com>
5130
5131         * objfiles.c (objfile_pspace_info): Add destructor and
5132         initializers.
5133         (objfiles_pspace_data): Change type.
5134         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5135         (get_objfile_pspace_data): Update.
5136         (objfiles_bfd_data): Change type.
5137         (get_objfile_bfd_data): Update.
5138         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5139
5140 2019-05-08  Tom Tromey  <tom@tromey.com>
5141
5142         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5143         Change type.
5144         (get_catch_syscall_inferior_data): Update.
5145         (catch_syscall_inferior_data_cleanup): Remove.
5146         (_initialize_break_catch_syscall): Update.
5147
5148 2019-05-08  Tom Tromey  <tom@tromey.com>
5149
5150         * inflow.c (struct terminal_info): Add destructor and
5151         initializers.
5152         (inflow_inferior_data): Change type.
5153         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5154         (get_inflow_inferior_data, inflow_inferior_exit)
5155         (swap_terminal_info, _initialize_inflow): Update.
5156
5157 2019-05-08  Tom Tromey  <tom@tromey.com>
5158
5159         * target-dcache.c (target_dcache_cleanup): Remove.
5160         (target_dcache_aspace_key): Change type.
5161         (target_dcache_init_p, target_dcache_invalidate)
5162         (target_dcache_get, target_dcache_get_or_init)
5163         (_initialize_target_dcache): Update.
5164         * dcache.h (struct dcache_deleter): New.
5165
5166 2019-05-08  Tom Tromey  <tom@tromey.com>
5167
5168         * symtab.c (struct symbol_cache): Add destructor and
5169         initializers.
5170         (symbol_cache_key): Move.  Change type.
5171         (make_symbol_cache, free_symbol_cache): Remove.
5172         (get_symbol_cache): Update.
5173         (symbol_cache_cleanup): Remove.
5174         (ALL_PSPACES, symbol_cache_flush)
5175         (maintenance_print_symbol_cache)
5176         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5177         Update.
5178
5179 2019-05-08  Tom Tromey  <tom@tromey.com>
5180
5181         * symtab.c (struct main_info): Add destructor and initializers.
5182         (main_progspace_key): Move.  Change type.
5183         (get_main_info): Update.
5184         (main_info_cleanup): Remove.
5185         (_initialize_symtab): Update.
5186
5187 2019-05-08  Tom Tromey  <tom@tromey.com>
5188
5189         * registry.h (DECLARE_REGISTRY): Define the _key class.
5190
5191 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * NEWS: Merge two 'New commands' sections.
5194
5195 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5196
5197         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5198         parameter and use Ada language definition instead.
5199         (ada_val_print_ptr): Remove unused language parameter.
5200         (ada_val_print_num): Remove language parameter and use Ada language
5201         definition instead.
5202         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5203         parameter.
5204         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5205         parameter and use Ada language definition instead.
5206         (ada_val_print_1): Update all ada_val_print_xxx calls.
5207         Remove language parameter.
5208         (ada_val_print): Update ada_val_print_1 call.
5209
5210 2019-05-08  Tom Tromey  <tromey@adacore.com>
5211
5212         * remote.c (remote_hw_watchpoint_limit)
5213         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5214         Now static.
5215
5216 2019-05-08  Tom Tromey  <tromey@adacore.com>
5217
5218         * maint.c (_initialize_maint_cmds): Move initialization code to
5219         remote.c.
5220         (watchdog, show_watchdog): Move to remote.c.
5221         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5222         "watchdog" static.
5223         (_initialize_remote): Move initialization code from maint.c.
5224         * defs.h (watchdog): Don't declare.
5225
5226 2019-05-08  Tom Tromey  <tromey@adacore.com>
5227
5228         * tui/tui-interp.c: Include main.h.
5229         * interps.c: Include main.h.
5230         * main.h (interpreter_p): Declare.
5231         * defs.h (interpreter_p): Don't declare.
5232
5233 2019-05-08  Tom Tromey  <tromey@adacore.com>
5234
5235         * dwarf2loc.c: Include dwarf2read.h.
5236         * defs.h (read_unsigned_leb128): Don't declare.
5237         * dwarf2read.h (read_unsigned_leb128): Declare.
5238
5239 2019-05-08  Tom Tromey  <tromey@adacore.com>
5240
5241         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5242         method.
5243
5244 2019-05-08  Tom Tromey  <tromey@adacore.com>
5245
5246         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5247         when no wrap column is set.
5248
5249 2019-05-08  Tom Tromey  <tromey@adacore.com>
5250
5251         * c-lang.c (c_get_string): Handle non-C-style arrays.
5252
5253 2019-05-08  Tom Tromey  <tromey@adacore.com>
5254
5255         * typeprint.c (print_offset_data::update): Print the bit offset,
5256         not the number of bits remaining.
5257
5258 2019-05-08  Tom Tromey  <tromey@adacore.com>
5259
5260         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5261         padding at end of comment.
5262
5263 2019-05-08  Tom Tromey  <tromey@adacore.com>
5264
5265         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5266         Compare main types.
5267
5268 2019-05-06  Tom Tromey  <tom@tromey.com>
5269
5270         * common/scoped_mmap.c: Include common-defs.h.
5271         * common/scoped_mmap.h: Don't include config.h.
5272
5273 2019-05-04  Tom Tromey  <tom@tromey.com>
5274
5275         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5276         (struct aarch64_call_info): Add initializers.
5277         <si>: Now a std::vector.
5278         (pass_on_stack, aarch64_push_dummy_call): Update.
5279
5280 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5281             Tom Tromey  <tom@tromey.com>
5282
5283         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5284         (ppc_threads): Now a std::vector.  Now static.
5285         (hwdebug_find_thread_points_by_tid)
5286         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5287         Update.
5288
5289 2019-05-04  Tom Tromey  <tom@tromey.com>
5290
5291         * arc-tdep.c (arc_tdesc_init): Return bool.
5292
5293 2019-05-04  Tom Tromey  <tom@tromey.com>
5294
5295         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5296         Use gdb_assert_not_reached.
5297
5298 2019-05-04  Tom Tromey  <tom@tromey.com>
5299
5300         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5301         "false".
5302
5303 2019-05-04  Tom Tromey  <tom@tromey.com>
5304
5305         * arc-tdep.c (arc_tdesc_init): Use bool.
5306
5307 2019-05-04  Tom Tromey  <tom@tromey.com>
5308
5309         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5310
5311 2019-05-04  Tom Tromey  <tom@tromey.com>
5312
5313         * cli/cli-cmds.c (valid_command_p): Return bool.
5314
5315 2019-05-04  Tom Tromey  <tom@tromey.com>
5316
5317         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5318         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5319
5320 2019-05-04  Raul Tambre  <raul@tambre.ee>
5321
5322         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5323         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5324         operator for comparison.
5325
5326 2019-05-04  Tom Tromey  <tom@tromey.com>
5327
5328         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5329         (lookup_partial_symbol, print_partial_symbols)
5330         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5331         (psymbol_compare): Update.
5332         (add_psymbol_to_bcache): Clear the entire psymbol.
5333         (maintenance_check_psymtabs): Update.
5334         * psympriv.h (struct partial_symbol): Don't derive from
5335         general_symbol_info.
5336         <obj_section, unrelocated_address, address,
5337         set_unrelocated_address>: Update.
5338         <ginfo>: New member.
5339         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5340         (debug_names::write_psymbols): Update.
5341
5342 2019-05-04  Tom de Vries  <tdevries@suse.de>
5343
5344         * contrib/cc-with-tweaks.sh: Support -n arg.
5345
5346 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5347
5348         * corelow.c (core_target::detach): Ensure frame cache and
5349         register caches are cleared.
5350         inferior.c (exit_inferior_1): Likewise.
5351
5352 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5353             Tom Tromey  <tom@tromey.com>
5354
5355         * dictionary.c (collate_pending_symbols_by_language): Remove
5356         "struct" from foreach.
5357         * symtab.c (lookup_global_symbol_from_objfile)
5358         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5359         foreach.
5360         * ser-tcp.c (net_open): Remove "struct" from foreach.
5361         * objfiles.c (objfile_relocate, objfile_rebase)
5362         (objfile_has_symbols): Remove "struct" from foreach.
5363         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5364         from foreach.
5365         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5366         foreach.
5367         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5368         "struct" from foreach.
5369         * ada-lang.c (create_excep_cond_exprs)
5370         (ada_exception_catchpoint_cond_string): Remove "struct" from
5371         foreach.
5372
5373 2019-05-03  Tom Tromey  <tromey@adacore.com>
5374
5375         * ada-exp.y (convert_char_literal): Check suffix of each
5376         enumerator.
5377
5378 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5379
5380         PR ada/21406:
5381         * ada-exp.y (yywrap): Don't define.
5382         * ada-lex.l (%option): Add noyywrap
5383         (yywrap): Remove.
5384
5385 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5386
5387         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5388         _WIN32_WINNT to the XP level, unless already defined to a higher
5389         level.
5390
5391         * unittests/parse-connection-spec-selftests.c:
5392         * ser-tcp.c:
5393         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5394         override.
5395
5396         * symfile.c (find_separate_debug_file): Remove colon from the
5397         drive spec of DOS/Windows file names of the target, so that the
5398         file name produced from DEBUGDIR and the target's directory will
5399         be valid on DOS/Windows systems.
5400
5401 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * rust-lang.c (val_print_struct): Handle printing structures
5404         containing strings.
5405
5406 2019-05-02  Tom Tromey  <tromey@adacore.com>
5407
5408         * valarith.c (_initialize_valarith): Remove.
5409
5410 2019-05-01  Tom Tromey  <tromey@adacore.com>
5411
5412         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5413         bitfields.
5414
5415 2019-05-01  Tom Tromey  <tromey@adacore.com>
5416
5417         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5418         for big-endian copies.
5419
5420 2019-04-30  Ali Tamur  <tamur@google.com>
5421         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5422         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5423         (read_3_bytes): New function.
5424
5425 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5426
5427         * windows-nat.c (main_thread_id): Delete.
5428         (handle_output_debug_string): Replace main_thread_id by
5429         current_event.dwThreadId.
5430         (fake_create_process): Likewise.
5431         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5432         Do not set main_thread_id.
5433         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5434         current_event.dwThreadId.
5435         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5436
5437 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5438
5439         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5440         Use current_event.dwThreadId instead of main_thread_id.
5441
5442 2019-04-30  Tom Tromey  <tromey@adacore.com>
5443
5444         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5445         (create_excep_cond_exprs): Iterate over program spaces.
5446         (ada_exception_catchpoint_cond_string): Examine all minimal
5447         symbols for exception types.
5448
5449 2019-04-30  Tom Tromey  <tromey@adacore.com>
5450
5451         PR c++/24470:
5452         * dwarf2read.c (process_structure_scope): Handle case where type
5453         has template parameters but no symbol was created.
5454
5455 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5456             Chris January  <chris.january@arm.com>
5457
5458         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5459         qualifier.
5460         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5461
5462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5463
5464         * f-typeprint.c (f_print_type): Update rules for printing
5465         whitespace.
5466         (f_type_print_varspec_suffix): Likewise.
5467
5468 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5469             Chris January  <chris.january@arm.com>
5470
5471         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5472         function arguments.
5473
5474 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * f-lang.c (build_fortran_types): Change name of void type to
5477         lower case.
5478         * f-typeprint.c (f_type_print_base): Print the name of the void
5479         type, rather than a fixed string.
5480         * f-valprint.c (f_decorations): Use lower case void string.
5481
5482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5483             Chris January  <chris.january@arm.com>
5484
5485         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5486         types for Fortran.
5487
5488 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5489             Chris January  <chris.january@arm.com>
5490             David Lecomber  <david.lecomber@arm.com>
5491
5492         * f-exp.y (BINOP_INTRINSIC): New token.
5493         (exp): New parser rule handling BINOP_INTRINSIC.
5494         (f77_keywords): Add new builtin procedures.
5495         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5496         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5497         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5498         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5499         (print_unop_subexp_f): New function.
5500         (print_binop_subexp_f): New function.
5501         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5502         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5503         (dump_subexp_body_f): Likewise.
5504         (operator_check_f): Likewise.
5505         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5506         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5507
5508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5511         UNOP_KIND.
5512         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5513         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5514         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5515         (operator_length_f): New fuction.
5516         (print_subexp_f): New function.
5517         (op_name_f): New function.
5518         (dump_subexp_body_f): New function.
5519         (operator_check_f): New function.
5520         (exp_descriptor_f): Replace standard expression handling functions
5521         with new functions.
5522         * gdb/fortran-operator.def: New file.
5523         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5524         * gdb/std-operator.def: Remove UNOP_KIND.
5525
5526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * std-operator.def: Remove unbalanced, stray double quote
5529         character.
5530
5531 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5532             Chris January  <chris.january@arm.com>
5533             Daniel Everett  <daniel.everett@arm.com>
5534             Nick Forrington  <nick.forrington@arm.com>
5535             Richard Bunt  <richard.bunt@arm.com>
5536
5537         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5538         of depth when printing anonymous structs or unions.
5539         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5540         Don't print either the top-level value, or the children if the
5541         max-depth is exceeded.
5542         (ppscm_print_children): When printing the key of a map, allow one
5543         extra level of depth.
5544         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5545         print either the top-level value, or the children if the max-depth
5546         is exceeded.
5547         (print_children): When printing the key of a map, allow one extra
5548         level of depth.
5549         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5550         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5551         (user_print_options): Initialise max_depth field.
5552         (val_print_scalar_or_string_type_p): New function.
5553         (val_print): Check to see if the max depth has been reached.
5554         (val_print_check_max_depth): Define new function.
5555         (show_print_max_depth): New function.
5556         (_initialize_valprint): Add 'print max-depth' option.
5557         * valprint.h (struct value_print_options) <max_depth>: New field.
5558         (val_print_check_max_depth): Declare new function.
5559         * NEWS: Document new feature.
5560
5561 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * ada-lang.c (ada_language_defn): Initialise new field.
5564         * c-lang.c (c_is_string_type_p): New function.
5565         (c_language_defn): Initialise new field.
5566         (cplus_language_defn): Initialise new field.
5567         (asm_language_defn): Initialise new field.
5568         (minimal_language_defn): Initialise new field.
5569         * c-lang.h (c_is_string_type_p): Declare new function.
5570         * d-lang.c (d_language_defn): Initialise new field.
5571         * f-lang.c (f_is_string_type_p): New function.
5572         (f_language_defn): Initialise new field.
5573         * go-lang.c (go_is_string_type_p): New function.
5574         (go_language_defn): Initialise new field.
5575         * language.c (default_is_string_type_p): New function.
5576         (unknown_language_defn): Initialise new field.
5577         (auto_language_defn): Initialise new field.
5578         * language.h (struct language_defn) <la_is_string_type_p>: New
5579         member variable.
5580         (default_is_string_type_p): Declare new function.
5581         * m2-lang.c (m2_language_defn): Initialise new field.
5582         * objc-lang.c (objc_language_defn): Initialise new field.
5583         * opencl-lang.c (opencl_language_defn): Initialise new field.
5584         * p-lang.c (pascal_is_string_type_p): New function.
5585         (pascal_language_defn): Initialise new field.
5586         * rust-lang.c (rust_is_string_type_p): New function.
5587         (rust_language_defn): Initialise new field.
5588
5589 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5590
5591         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5592         New field.
5593         * ada-lang.c (ada_language_defn): Initialise new field.
5594         * c-lang.c (c_language_defn): Likewise.
5595         (cplus_language_defn): Likewise.
5596         (asm_language_defn): Likewise.
5597         (minimal_language_defn): Likewise.
5598         * d-lang.c (d_language_defn): Likewise.
5599         * f-lang.c (f_language_defn): Likewise.
5600         * go-lang.c (go_language_defn): Likewise.
5601         * language.c (unknown_language_defn): Likewise.
5602         (auto_language_defn): Likewise.
5603         * m2-lang.c (m2_language_defn): Likewise.
5604         * objc-lang.c (objc_language_defn): Likewise.
5605         * opencl-lang.c (opencl_language_defn): Likewise.
5606         * p-lang.c (pascal_language_defn): Likewise.
5607         * rust-lang.c (rust_language_defn): Likewise.
5608
5609 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * ada-lang.c (ada_is_character_type): Change return type to bool.
5612         (ada_is_string_type): Likewise.
5613         * ada-lang.h (ada_is_character_type): Update declaration
5614         (ada_is_string_type): Likewise.
5615
5616 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5617
5618         Support style in 'frame|thread apply'
5619
5620         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5621         * record.c (record_start, record_stop): Update callers of
5622         execute_command_to_string with false.
5623         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5624         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5625         methods.
5626         (class string_file): New constructor with term_out parameter.
5627         Override methods term_out and can_emit_style_escape.  New member
5628         term_out.
5629         (class stdio_file): Override can_emit_style_escape.
5630         (class tee_file): Override term_out and can_emit_style_escape.
5631         * utils.h (can_emit_style_escape): Remove.
5632         * utils.c (can_emit_style_escape): Likewise.
5633         Update all callers of can_emit_style_escape (SOMESTREAM) to
5634         SOMESTREAM->can_emit_style_escape.
5635         * source-cache.c (source_cache::get_source_lines): Likewise.
5636         * stack.c (frame_apply_command_count): Call execute_command_to_string
5637         passing the term_out characteristic of the current gdb_stdout.
5638         * thread.c (thr_try_catch_cmd): Likewise.
5639         * top.c (execute_command_to_string): pass term_out parameter
5640         to construct the string_file for the command output.
5641         * ui-file.c (term_cli_styling): New function (most code moved
5642         from utils.c can_emit_style_escape).
5643         (string_file::string_file, string_file::can_emit_style_escape,
5644         stdio_file::can_emit_style_escape, tee_file::term_out,
5645         tee_file::can_emit_style_escape): New functions.
5646
5647 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5648
5649         * NEWS: Mention the new set|show may-call-functions.
5650         * infcall.c (may_call_functions_p): New variable.
5651         (show_may_call_functions_p): New function.
5652         (call_function_by_hand_dummy): Throws an error if not
5653         may-call-functions.
5654         (_initialize_infcall): Call add_setshow_boolean_cmd for
5655         may-call-functions.
5656
5657 2019-04-25  Keith Seitz  <keiths@redhat.com>
5658
5659         PR c++/24367
5660         * cp-support.c (inspect_type): Don't attempt substitutions
5661         of symbol with the same name.
5662
5663 2019-04-25  Tom Tromey  <tromey@adacore.com>
5664
5665         PR gdb/24475:
5666         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5667         static.
5668
5669 2019-04-25  Tom Tromey  <tromey@adacore.com>
5670
5671         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5672         rvalue reference.
5673         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5674         (gdb_xml_parser::parse): Use std::move.
5675         * python/python-internal.h (gdbpy_convert_exception): Take a const
5676         reference.
5677         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5678         std::move.
5679         * python/py-utils.c (gdbpy_convert_exception): Take a const
5680         reference.
5681         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5682         Use std::move.
5683         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5684         Use std::move.
5685         * mi/mi-main.c (mi_print_exception): Take a const reference.
5686         * main.c (handle_command_errors): Take a const reference.
5687         * linespec.c (parse_linespec): Use std::move.
5688         * infcall.c (run_inferior_call): Use std::move.
5689         (call_function_by_hand_dummy): Use std::move.
5690         * exec.c (try_open_exec_file): Use std::move.
5691         * exceptions.h (exception_print, exception_fprintf)
5692         (exception_print_same): Update.
5693         * exceptions.c (print_exception, exception_print)
5694         (exception_fprintf, exception_print_same): Change parameters to
5695         const reference.
5696         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5697         * common/new-op.c: Use std::move.
5698         * common/common-exceptions.h (struct gdb_exception): Add move
5699         constructor.
5700         (struct gdb_exception_error, struct gdb_exception_quit, struct
5701         gdb_quit_bad_alloc): Change constructor to move constructor.
5702         (throw_exception): Change parameter to rvalue reference.
5703         * common/common-exceptions.c (throw_exception): Take rvalue
5704         reference.
5705         * cli/cli-interp.c (safe_execute_command): Use std::move.
5706         * breakpoint.c (insert_bp_location, location_to_sals): Use
5707         std::move.
5708
5709 2019-04-25  Tom Tromey  <tromey@adacore.com>
5710
5711         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5712         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5713         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5714         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5715         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5716         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5717         guile/scm-value.c: Use unpack.
5718         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5719         gdbscm_gdb_exception.
5720         (gdbscm_throw_gdb_exception): Likewise.
5721         (struct gdbscm_gdb_exception): New.
5722         (unpack): New function.
5723         (gdbscm_wrap): Use unpack.
5724
5725 2019-04-25  Tom Tromey  <tromey@adacore.com>
5726
5727         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5728         (gdb_rl_callback_handler): Use std::move.
5729         * common/common-exceptions.h (struct gdb_exception): Add move
5730         assignment operator.
5731         (throw_exception_sjlj): Change "exception" to const reference.
5732         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5733         (throw_exception_sjlj): Change "exception" to const reference.
5734
5735 2019-04-25  Tom Tromey  <tromey@adacore.com>
5736
5737         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5738         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5739         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5740         Update.
5741         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5742         Update.
5743         * mi/mi-interp.c (mi_interp::exec): Update.
5744         * linespec.c (parse_linespec): Update.
5745         * infcall.c (run_inferior_call): Update.
5746         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5747         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5748         (gdbscm_lookup_global_symbol): Update.
5749         * guile/scm-param.c (gdbscm_parameter_value): Update.
5750         * guile/scm-frame.c (gdbscm_frame_read_register)
5751         (gdbscm_frame_read_var): Update.
5752         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5753         * exec.c (try_open_exec_file): Update.
5754         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5755         (gdb_rl_callback_handler): Update.
5756         * common/common-exceptions.h (exception_none): Don't declare.
5757         * common/common-exceptions.c (exception_none): Don't define.
5758         (struct catcher) <exception>: Update.
5759         * cli/cli-interp.c (safe_execute_command): Update.
5760         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5761
5762 2019-04-25  Ali Tamur  <tamur@google.com>
5763
5764         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5765         (read_attribute_value): Likewise.
5766         (dwarf2_read_addr_index): Update comment.
5767         (read_str_index): Add DW_FORM_strx.
5768         (dwarf2_string_attr): Likewise.
5769         (dwarf2_const_value_attr): Likewise.
5770         (dump_die_shallow): Likewise.
5771         (dwarf2_fetch_constant_bytes): Likewise.
5772         (skip_form_bytes): Likewise.
5773         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5774
5775 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5776
5777         PR corefiles/11608
5778         PR corefiles/18187
5779         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5780         OFFSET.  Verify if current mapping contains an ELF header.
5781         (linux_find_memory_regions_full): Adjust call to
5782         dump_mapping_p.
5783
5784 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5785             Kang Li <kanglictf@gmail.com>
5786
5787         PR gdb/21600
5788
5789         * dwarf2-frame.c (read_initial_length): Be consistent about using
5790         unsigned representation of length.
5791         (decode_frame_entry_1): Likewise.  Check for wraparound of
5792         end pointer as well as buffer overflow.
5793
5794 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5795
5796         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5797         "vq".
5798
5799 2019-04-24  Tom Tromey  <tromey@adacore.com>
5800
5801         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5802
5803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * s12z-tdep.c (s12z_unwind_pc): Delete.
5806         (s12z_unwind_sp): Delete.
5807         (s12z_gdbarch_init): Don't register deleted functions with
5808         gdbarch.
5809
5810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5811
5812         * rl78-tdep.c (rl78_unwind_sp): Delete.
5813         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5814
5815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5818         (xstormy16_unwind_pc): Delete.
5819         (xstormy16_dummy_id): Delete.
5820         (xstormy16_gdbarch_init): Don't register deleted functions with
5821         gdbarch.
5822
5823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * vax-tdep.c (vax_unwind_pc): Delete.
5826         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5827
5828 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * v850-tdep.c (v850_unwind_sp): Delete.
5831         (v850_unwind_pc): Delete.
5832         (v850_dummy_id): Delete.
5833         (v850_gdbarch_init): Don't register deleted functions with
5834         gdbarch.
5835
5836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5837
5838         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5839         (tilegx_unwind_pc): Delete.
5840         (tilegx_unwind_dummy_id): Delete.
5841         (tilegx_gdbarch_init): Don't register deleted functions with
5842         gdbarch.
5843
5844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5845
5846         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5847         (tic6x_dummy_id): Delete.
5848         (tic6x_gdbarch_init): Don't register deleted functions with
5849         gdbarch.
5850
5851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5852
5853         * sparc-tdep.c (sparc_unwind_pc): Delete.
5854         (sparc32_gdbarch_init): Don't register deleted function with
5855         gdbarch.
5856
5857 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5858
5859         * sh-tdep.c (sh_unwind_sp): Delete.
5860         (sh_unwind_pc): Delete.
5861         (sh_dummy_id): Delete.
5862         (sh_gdbarch_init): Don't register deleted functions with
5863         gdbarch.
5864
5865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * score-tdep.c (score_unwind_sp): Delete.
5868         (score_unwind_pc): Delete.
5869         (score_dummy_id): Delete.
5870         (score_gdbarch_init): Don't register deleted functions with
5871         gdbarch.
5872
5873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5874
5875         * rx-tdep.c (rx_unwind_pc): Delete.
5876         (rx_unwind_sp): Delete.
5877         (rx_dummy_id): Delete.
5878         (rx_gdbarch_init): Don't register deleted functions with
5879         gdbarch.  Update comment.
5880
5881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5882
5883         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5884         (rs6000_dummy_id): Delete.
5885         (rs6000_gdbarch_init): Don't register deleted functions with
5886         gdbarch.
5887
5888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * or1k-tdep.c (or1k_dummy_id): Delete.
5891         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5892
5893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * nios2-tdep.c (nios2_dummy_id): Delete.
5896         (nios2_unwind_sp): Delete.
5897         (nios2_gdbarch_init): Don't register deleted functions with
5898         gdbarch.
5899
5900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5901
5902         * nds32-tdep.c (nds32_dummy_id): Delete.
5903         (nds32_unwind_pc): Delete.
5904         (nds32_unwind_sp): Delete.
5905         (nds32_gdbarch_init): Don't register deleted functions with
5906         gdbarch.
5907
5908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * msp430-tdep.c (msp430_unwind_pc): Delete.
5911         (msp430_unwind_sp): Delete.
5912         (msp430_dummy_id): Delete.
5913         (msp430_gdbarch_init): Don't register deleted functions with
5914         gdbarch.
5915
5916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5917
5918         * moxie-tdep.c (moxie_unwind_sp): Delete.
5919         (moxie_unwind_pc): Delete.
5920         (moxie_dummy_id): Delete.
5921         (moxie_gdbarch_init): Don't register deleted functions with
5922         gdbarch.
5923
5924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5925
5926         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5927         (mn10300_unwind_pc): Delete.
5928         (mn10300_unwind_sp): Delete.
5929         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5930         mn10300_unwind_sp.
5931         (mn10300_frame_unwind_init): Don't register deleted functions with
5932         gdbarch.
5933
5934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * mep-tdep.c (mep_unwind_pc): Delete.
5937         (mep_unwind_sp): Delete.
5938         (mep_dummy_id): Delete.
5939         (mep_gdbarch_init): Don't register deleted functions with
5940         gdbarch.
5941
5942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5945         (m68hc11_unwind_sp): Delete.
5946         (m68hc11_gdbarch_init): Don't register deleted functions with
5947         gdbarch.
5948
5949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5950
5951         * m32r-tdep.c (m32r_unwind_sp): Delete.
5952         (m32r_unwind_pc): Delete.
5953         (m32r_dummy_id): Delete.
5954         (m32r_gdbarch_init): Don't register deleted functions with
5955         gdbarch.
5956
5957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5958
5959         * m32c-tdep.c (m32c_unwind_pc): Delete.
5960         (m32c_unwind_sp): Delete.
5961         (m32c_dummy_id): Delete.
5962         (m32c_gdbarch_init): Don't register deleted functions with
5963         gdbarch.
5964
5965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5968         (lm32_unwind_pc): Delete.
5969         (lm32_dummy_id): Delete.
5970         (lm32_gdbarch_init): Don't register deleted functions with
5971         gdbarch.
5972
5973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5976         (iq2000_unwind_pc): Delete.
5977         (iq2000_dummy_id): Delete.
5978         (iq2000_gdbarch_init): Don't register deleted functions with
5979         gdbarch.
5980
5981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * nds32-tdep.c (nds32_type_align): Delete.
5984         (nds32_push_dummy_call): Use type_align instead.
5985
5986 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5987
5988         * arm-tdep.c (arm_type_align): Only handle vector override case.
5989         (arm_push_dummy_call): Use type_align.
5990         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5991
5992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5995         case.
5996         (pass_on_stack): Use type_align.
5997         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5998         function.
5999
6000 2019-04-23  Tom Tromey  <tromey@adacore.com>
6001
6002         * dwarf2read.c (line_header::file_name_at): Remove unused
6003         overload.
6004
6005 2019-04-23  Tom de Vries  <tdevries@suse.de>
6006
6007         PR gdb/24438
6008         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6009         invocation.
6010
6011
6012 2019-03-27  Ali Tamur  <tamur@google.com>
6013
6014         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6015         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6016         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6017         (dwarf_expr_context::get_addr_index): Likewise
6018         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6019         (symbol_needs_eval_context::get_addr_index): Likewise
6020         (disassemble_dwarf_expression): Add DW_OP_addrx
6021         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6022         (read_cutu_die_from_dwo): Update comment
6023         (skip_one_die): Add DW_FORM_addrx
6024         (read_attribute_value): Likewise
6025         (var_decode_location): Add DW_OP_addrx
6026         (dwarf2_const_value_attr): Add DW_FORM_addrx
6027         (dump_die_shallow): Likewise
6028         (dwarf2_fetch_constant_bytes): Likewise
6029         (decode_locdesc): Add DW_OP_addrx
6030         (skip_form_bytes): Add DW_FORM_addrx
6031
6032 2019-04-22  Ali Tamur  <tamur@google.com>
6033
6034         * MAINTAINERS (Write After Approval): Add self.
6035
6036 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6037
6038         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6039         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6040         (open_symbol_file_object): Likewise.
6041         (svr4_default_sos): Add info parameter.
6042         (svr4_read_so_list): Likewise.
6043         (svr4_current_sos_direct): Adjust functions calls to pass down
6044         info.
6045         (svr4_current_sos_1): Add info parameter.
6046         (svr4_current_sos): Call get_svr4_info, pass info down to
6047         svr4_current_sos_1.
6048         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6049         get_svr4_info.
6050         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6051         get_svr4_info.
6052         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6053         to get_svr4_info.
6054         (probes_table_remove_objfile_probes): Likewise.
6055         (register_solib_event_probe): Add info parameter.
6056         (solist_update_incremental): Pass info parameter down to
6057         svr4_read_so_list.
6058         (disable_probes_interface): Add info parameter.
6059         (svr4_handle_solib_event): Pass current_program_space to
6060         get_svr4_info.  Adjust disable_probes_interface cleanup.
6061         (svr4_create_probe_breakpoints): Add info parameter, pass it
6062         down to register_solib_event_probe.
6063         (svr4_create_solib_event_breakpoints): Add info parameter,
6064         pass it down to svr4_create_probe_breakpoints.
6065         (enable_break): Pass info down to
6066         svr4_create_solib_event_breakpoints.
6067         (svr4_solib_create_inferior_hook): Pass current_program_space to
6068         get_svr4_info.
6069         (svr4_clear_solib): Likewise.
6070
6071 2019-04-22  Pedro Alves  <palves@redhat.com>
6072
6073         * solib-svr4.c (svr4_free_objfile_observer): New.
6074         (probe_and_action::objfile): New field.
6075         (probes_table_htab_remove_objfile_probes)
6076         (probes_table_remove_objfile_probes): New functions.
6077         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6078         in the new probe_and_action.  Don't store the probe in 'lookup'.
6079         (svr4_create_probe_breakpoints): Pass objfile to
6080         register_solib_event_probe.
6081         (_initialize_svr4_solib): Register a free_objfile observer.
6082
6083 2019-04-19  Tom Tromey  <tom@tromey.com>
6084
6085         * common/queue.h: Remove.
6086
6087 2019-04-19  Tom Tromey  <tom@tromey.com>
6088
6089         * event-loop.c: Don't include "common/queue.h".
6090
6091 2019-04-19  Tom Tromey  <tom@tromey.com>
6092
6093         * remote.c (remote_target): Use delete.
6094         * remote-notif.h: Include <list>, not "common/queue.h".
6095         (notif_client_p): Remove typedef.
6096         (remote_notif_state): Add constructor, destructor, initializer.
6097         <notif_queue>: Now a std::list.
6098         (remote_notif_state_xfree): Don't declare.
6099         * remote-notif.c (remote_notif_process, handle_notification)
6100         (remote_notif_state_allocate): Update.
6101         (~remote_notif_state): Rename from remote_notif_state_xfree.
6102
6103 2019-04-19  Tom Tromey  <tom@tromey.com>
6104
6105         * symfile.c (reread_symbols): Update.
6106         * objfiles.c (objfile_register_static_link)
6107         (objfile_lookup_static_link): Update
6108         (~objfile) Don't delete static_links.
6109         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6110
6111 2019-04-19  Tom Tromey  <tom@tromey.com>
6112
6113         * type-stack.h (struct type_stack) <insert>: Constify string.
6114         * type-stack.c (type_stack::insert): Constify string.
6115         * gdbtypes.h (lookup_template_type): Update.
6116         (address_space_name_to_int): Update.
6117         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6118         const.
6119         (lookup_template_type): Make name const.
6120         * c-exp.y: Update rules.
6121         (lex_one_token, classify_name, classify_inner_name)
6122         (c_print_token): Update.
6123         * p-exp.y: Update rules.
6124         (yylex): Update.
6125         * f-exp.y: Update rules.
6126         (yylex): Update.
6127         * d-exp.y: Update rules.
6128         (lex_one_token, classify_name, classify_inner_name): Update.
6129         * parse.c (write_dollar_variable, copy_name): Return std::string.
6130         * parser-defs.h (copy_name): Change return type.
6131         * m2-exp.y: Update rules.
6132         (yylex): Update.
6133         * go-exp.y (lex_one_token): Update.
6134         Update rules.
6135         (classify_unsafe_function, classify_packaged_name)
6136         (classify_name, yylex): Update.
6137
6138 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6139
6140         * configure.ac: add --enable-source-highlight switch.
6141         * configure: Regenerate.
6142         * top.c (print_gdb_version): plumb --enable-source-highlight
6143         status to "show configuration".
6144
6145 2019-04-19  Tom Tromey  <tromey@adacore.com>
6146
6147         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6148         Check ADA_TYPE_P.
6149         (empty_record, ada_template_to_fixed_record_type_1)
6150         (template_to_static_fixed_type)
6151         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6152         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6153         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6154         macros.
6155
6156 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6157
6158         PR symtab/24423:
6159         * source.c (print_source_lines_base): Advance "iter" when a
6160         control character is seen.
6161
6162 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6163
6164         * inferior.h (struct infcall_suspend_state_deleter):
6165         Catch exception in destructor to avoid crash.
6166
6167 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168
6169         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6170         close to the add_com "shell".
6171
6172 2019-04-18  Tom Tromey  <tromey@adacore.com>
6173
6174         * process-stratum-target.h (class process_stratum_target)
6175         <stratum>: Add "final".
6176
6177 2019-04-17  Tom Tromey  <tromey@adacore.com>
6178
6179         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6180         against nullptr before use.
6181
6182 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6183
6184         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6185
6186 2019-04-17  Jim Wilson  <jimw@sifive.com>
6187             Andrew Burgess  <andrew.burgess@embecosm.com>
6188
6189         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6190         code read might fail, assume 4-byte breakpoint in that case.
6191
6192 2019-04-15  Leszek Swirski  <leszeks@google.com>
6193
6194         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6195         rather than a hand-rolled POD check when checking for forced MEMORY
6196         classification.
6197
6198 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6199
6200         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6201         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6202         function.
6203         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6204         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6205         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6206         declaration.
6207
6208 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6209
6210         * aarch64-linux-nat.c
6211         (aarch64_linux_nat_target::thread_architecture): Add override.
6212         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6213         each VQ.
6214
6215 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6216
6217         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6218
6219 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6222         target types of size 96-bits, add some additional comments, and
6223         check that the builtin type we found was the correct size.
6224
6225 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6226
6227         * utils.c (prompt_for_continue): Don't restore the styling at the
6228         end, as applied_style has the wrong value.  This fixes styling in
6229         long lists of file names that are interrupted by the "Continue?"
6230         prompt.
6231
6232 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6235         * c-lang.c (c_language_defn): Likewise.
6236         (cplus_language_defn): Likewise.
6237         (asm_language_defn): Likewise.
6238         (minimal_language_defn): Likewise.
6239         * d-lang.c (d_language_defn): Likewise.
6240         * f-lang.c (f_language_defn): Likewise.
6241         * go-lang.c (go_language_defn): Likewise.
6242         * language.c (unknown_language_defn): Likewise.
6243         (auto_language_defn): Likewise.
6244         * language.h (struct language_defn): Remove la_magic field.
6245         (LANG_MAGIC): Delete.
6246         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6247         * objc-lang.c (objc_language_defn): Likewise.
6248         * opencl-lang.c (opencl_language_defn): Likewise.
6249         * p-lang.c (pascal_language_defn): Likewise.
6250         * rust-lang.c (rust_language_defn): Likewise.
6251
6252 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * riscv-tdep.c (riscv_type_align): New function.
6255         (riscv_type_alignment): Delete.
6256         (riscv_arg_location): Use 'type_align'.
6257         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6258
6259 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6260
6261         * gdbtypes.c (type_align): A struct with no non-static fields also
6262         has alignment of 1.
6263
6264 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6267         component to 0.
6268         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6269         member.
6270         (riscv_struct_info::analyse): New implementation using new
6271         analyse_inner member function.
6272         (riscv_struct_info::field_offset): New member function.
6273         (riscv_struct_info::m_offsets): New member variable.
6274         (riscv_struct_info::analyse_inner): New private member function,
6275         takes the old implementation of riscv_struct_info::analyse but
6276         extended to track field offsets.
6277         (riscv_call_arg_struct): Update the struct folding special cases
6278         to handle cases where empty C++ structs, which are non-zero
6279         length, are found.
6280         (riscv_arg_location): Initialise the length of each location, a
6281         non-zero length now indicates the location is in use.
6282         (riscv_push_dummy_call): Allow for the first location having a
6283         non-zero offset when setting up arguments.
6284         (riscv_return_value): Likewise, but for return values.
6285
6286 2019-04-11  Tom Tromey  <tromey@adacore.com>
6287
6288         * utils.c (internal_vproblem): Make "msg" const.
6289
6290 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6291
6292         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6293         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6294         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6295         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6296
6297 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6298
6299         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6300         function.
6301         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6302         of amd64_collect_native_gregset.
6303         (amd64_linux_nat_target::store_registers): Likewise.
6304
6305 2019-04-10  Tom Tromey  <tom@tromey.com>
6306
6307         * symtab.c (lookup_global_symbol_from_objfile)
6308         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6309         * objfiles.h (class separate_debug_iterator): New.
6310         (class separate_debug_range): New.
6311         (struct objfile) <separate_debug_objfiles>: New method.
6312         (objfile_separate_debug_iterate): Don't declare.
6313         * objfiles.c (separate_debug_iterator::operator++): Rename from
6314         objfile_separate_debug_iterate.
6315         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6316         iterator.
6317         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6318         iterator.
6319
6320 2019-04-10  Tom Tromey  <tom@tromey.com>
6321
6322         * symfile.c (reread_symbols): Remove old comment.
6323         * objfiles.c (free_all_objfiles): Fix a typo.
6324
6325 2019-04-10  Tom Tromey  <tom@tromey.com>
6326
6327         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6328         * minsyms.c (lookup_minimal_symbol): Use foreach.
6329         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6330         (lookup_minimal_symbol_solib_trampoline): Likewise.
6331         * symfile.c (reread_symbols): Use foreach.
6332
6333 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6334             Tom Tromey  <tromey@adacore.com>
6335
6336         PR rust/24414:
6337         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6338         (rust_lex_int_test): Change "value" to be LONGEST.
6339         (rust_lex_tests): Add test for long integer literal.
6340
6341 2019-04-09  Tom Tromey  <tromey@adacore.com>
6342
6343         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6344         to bool.
6345         (extended_remote_target::attach): Update.
6346         (remote_target::remote_notice_new_inferior): Update.
6347         (remote_target::add_current_inferior_and_thread): Update.
6348         * inferior.c (exit_inferior_1): Use "false".
6349         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6350
6351 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6352
6353         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6354         the "start" command.
6355
6356 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6357
6358         * python/py-inferior.c (infpy_thread_from_thread_handle):
6359         Adjust comments to reflect renaming of thread_from_thread_handle
6360         to thread_from_handle.  Adjust keywords.  Fix type error message.
6361         (inferior_object_methods): Add thread_from_handle.  Retain
6362         thread_from_thread_handle, but mark it as deprecated.
6363
6364 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6365
6366         * gdbthread.h (find_thread_by_handle): Revise declaration.
6367         * thread.c (find_thread_by_handle): Likewise.  Adjust
6368         implementation too.
6369         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6370         support for buffer objects as handles.
6371
6372 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6373
6374         * python/py-infthread.c (thpy_thread_handle): New function.
6375         (thread_object_methods): Register thpy_thread_handle.
6376
6377 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6378
6379         * gdbthread.h (thread_to_thread_handle): Declare.
6380         * thread.c (gdbtypes.h): Include.
6381         (thread_to_thread_handle): New function.
6382
6383         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6384         (target_thread_info_to_thread_handle): Declare.
6385         * target.c (target_thread_info_to_thread_handle): New function.
6386         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6387         * target-delegates.c: Regenerate.
6388
6389         * linux-thread-db.c (class thread_db_target): Add method
6390         thread_info_to_thread_handle.
6391         (thread_db_target::thread_info_to_thread_handle): Define.
6392         * remote.c (class remote_target): Add new method
6393         thread_info_to_thread_handle.
6394         (remote_target::thread_info_to_thread_handle): Define.
6395
6396 2019-04-08  Pedro Alves  <palves@redhat.com>
6397
6398         * common/common-exceptions.c (throw_exception): Don't create
6399         named object to throw; throw directly.
6400         (throw_it): Likewise.  Don't initialize gdb_exception::message
6401         here, with new; pass FMT and AP to the ctor instead.
6402         * common/common-exceptions.h: Include <string>.
6403         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6404         const char *, va_list)): New ctor.  Use std::make_shared.
6405         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6406         errors)): Delete.
6407         (gdb_exception_error::gdb_exception_error(enum errors, const char
6408         *, va_list)): New.
6409         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6410         Add assertion.
6411         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6412         errors)): Delete.
6413         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6414         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6415         Add assertion.
6416
6417 2019-04-08  Tom Tromey  <tom@tromey.com>
6418
6419         * valops.c (value_rtti_indirect_type): Replace throw_exception
6420         with throw.
6421         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6422         with throw.
6423         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6424         throw.
6425         * target.c (target_translate_tls_address): Replace throw_exception
6426         with throw.
6427         * stack.c (frame_apply_command_count): Replace throw_exception
6428         with throw.
6429         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6430         throw.
6431         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6432         with throw.
6433         * rs6000-tdep.c (rs6000_frame_cache)
6434         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6435         * remote.c: Replace throw_exception with throw.
6436         * record-full.c (record_full_message, record_full_wait_1)
6437         (record_full_restore): Replace throw_exception with throw.
6438         * record-btrace.c:
6439         (get_thread_current_frame_id, record_btrace_start_replaying)
6440         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6441         (cmd_record_btrace_start): Replace throw_exception with throw.
6442         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6443         throw.
6444         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6445         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6446         * linespec.c:
6447         (find_linespec_symbols): Replace throw_exception with throw.
6448         * infrun.c (displaced_step_prepare, resume): Replace
6449         throw_exception with throw.
6450         * infcmd.c (post_create_inferior): Replace throw_exception with
6451         throw.
6452         * inf-loop.c (inferior_event_handler): Replace throw_exception
6453         with throw.
6454         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6455         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6456         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6457         (get_prev_frame_always, get_frame_pc_if_available)
6458         (get_frame_address_in_block_if_available, get_frame_language):
6459         Replace throw_exception with throw.
6460         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6461         throw_exception with throw.
6462         * eval.c (fetch_subexp_value, evaluate_var_value)
6463         (evaluate_funcall, evaluate_subexp_standard): Replace
6464         throw_exception with throw.
6465         * dwarf2loc.c (call_site_find_chain)
6466         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6467         Replace throw_exception with throw.
6468         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6469         with throw.
6470         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6471         throw.
6472         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6473         * completer.c (complete_line_internal): Replace throw_exception
6474         with throw.
6475         * compile/compile-object-run.c (compile_object_run): Replace
6476         throw_exception with throw.
6477         * cli/cli-script.c (process_next_line): Replace throw_exception
6478         with throw.
6479         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6480         (btrace_enable, btrace_maint_update_pt_packets): Replace
6481         throw_exception with throw.
6482         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6483         throw_exception with throw.
6484         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6485         throw_exception with throw.
6486         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6487         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6488         * aarch64-tdep.c (aarch64_make_prologue_cache)
6489         (aarch64_make_stub_cache): Replace throw_exception with throw.
6490
6491 2019-04-08  Tom Tromey  <tom@tromey.com>
6492
6493         * common/common-exceptions.c (throw_exception): Rename from
6494         throw_exception_cxx.  Remove old copy.  Make argument const.
6495         (throw_it): Create and throw exception objects directly.
6496         * common/common-exceptions.h (throw_exception): Make argument
6497         const.
6498         (struct gdb_exception_error): Add constructor.
6499         (struct gdb_exception_quit): Add constructor.
6500
6501 2019-04-08  Tom Tromey  <tom@tromey.com>
6502
6503         * common/common-exceptions.h (exception_rethrow): Don't declare.
6504         (TRY_SJLJ): Update comment.
6505         (TRY, CATCH, END_CATCH): Remove.
6506         * common/common-exceptions.c (exception_rethrow): Remove.
6507
6508 2019-04-08  Tom Tromey  <tom@tromey.com>
6509
6510         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6511         Remove.
6512         (gdb_exception_error): Rename from
6513         gdb_exception_RETURN_MASK_ERROR.
6514         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6515         (gdb_quit_bad_alloc): Update.
6516         * aarch64-tdep.c: Update.
6517         * ada-lang.c: Update.
6518         * ada-typeprint.c: Update.
6519         * ada-valprint.c: Update.
6520         * amd64-tdep.c: Update.
6521         * arch-utils.c: Update.
6522         * break-catch-throw.c: Update.
6523         * breakpoint.c: Update.
6524         * btrace.c: Update.
6525         * c-varobj.c: Update.
6526         * cli/cli-cmds.c: Update.
6527         * cli/cli-interp.c: Update.
6528         * cli/cli-script.c: Update.
6529         * common/common-exceptions.c: Update.
6530         * common/new-op.c: Update.
6531         * common/selftest.c: Update.
6532         * compile/compile-c-symbols.c: Update.
6533         * compile/compile-cplus-symbols.c: Update.
6534         * compile/compile-object-load.c: Update.
6535         * compile/compile-object-run.c: Update.
6536         * completer.c: Update.
6537         * corelow.c: Update.
6538         * cp-abi.c: Update.
6539         * cp-support.c: Update.
6540         * cp-valprint.c: Update.
6541         * darwin-nat.c: Update.
6542         * disasm-selftests.c: Update.
6543         * dtrace-probe.c: Update.
6544         * dwarf-index-cache.c: Update.
6545         * dwarf-index-write.c: Update.
6546         * dwarf2-frame-tailcall.c: Update.
6547         * dwarf2-frame.c: Update.
6548         * dwarf2loc.c: Update.
6549         * dwarf2read.c: Update.
6550         * eval.c: Update.
6551         * event-loop.c: Update.
6552         * event-top.c: Update.
6553         * exec.c: Update.
6554         * f-valprint.c: Update.
6555         * fbsd-tdep.c: Update.
6556         * frame-unwind.c: Update.
6557         * frame.c: Update.
6558         * gdbtypes.c: Update.
6559         * gnu-v3-abi.c: Update.
6560         * guile/guile-internal.h: Update.
6561         * guile/scm-block.c: Update.
6562         * guile/scm-breakpoint.c: Update.
6563         * guile/scm-cmd.c: Update.
6564         * guile/scm-disasm.c: Update.
6565         * guile/scm-frame.c: Update.
6566         * guile/scm-lazy-string.c: Update.
6567         * guile/scm-math.c: Update.
6568         * guile/scm-param.c: Update.
6569         * guile/scm-ports.c: Update.
6570         * guile/scm-pretty-print.c: Update.
6571         * guile/scm-symbol.c: Update.
6572         * guile/scm-symtab.c: Update.
6573         * guile/scm-type.c: Update.
6574         * guile/scm-value.c: Update.
6575         * i386-linux-tdep.c: Update.
6576         * i386-tdep.c: Update.
6577         * inf-loop.c: Update.
6578         * infcall.c: Update.
6579         * infcmd.c: Update.
6580         * infrun.c: Update.
6581         * jit.c: Update.
6582         * language.c: Update.
6583         * linespec.c: Update.
6584         * linux-fork.c: Update.
6585         * linux-nat.c: Update.
6586         * linux-tdep.c: Update.
6587         * linux-thread-db.c: Update.
6588         * main.c: Update.
6589         * mi/mi-cmd-break.c: Update.
6590         * mi/mi-cmd-stack.c: Update.
6591         * mi/mi-interp.c: Update.
6592         * mi/mi-main.c: Update.
6593         * objc-lang.c: Update.
6594         * p-valprint.c: Update.
6595         * parse.c: Update.
6596         * ppc-linux-tdep.c: Update.
6597         * printcmd.c: Update.
6598         * python/py-arch.c: Update.
6599         * python/py-breakpoint.c: Update.
6600         * python/py-cmd.c: Update.
6601         * python/py-finishbreakpoint.c: Update.
6602         * python/py-frame.c: Update.
6603         * python/py-framefilter.c: Update.
6604         * python/py-gdb-readline.c: Update.
6605         * python/py-inferior.c: Update.
6606         * python/py-infthread.c: Update.
6607         * python/py-lazy-string.c: Update.
6608         * python/py-linetable.c: Update.
6609         * python/py-objfile.c: Update.
6610         * python/py-param.c: Update.
6611         * python/py-prettyprint.c: Update.
6612         * python/py-progspace.c: Update.
6613         * python/py-record-btrace.c: Update.
6614         * python/py-record.c: Update.
6615         * python/py-symbol.c: Update.
6616         * python/py-type.c: Update.
6617         * python/py-unwind.c: Update.
6618         * python/py-utils.c: Update.
6619         * python/py-value.c: Update.
6620         * python/python.c: Update.
6621         * record-btrace.c: Update.
6622         * record-full.c: Update.
6623         * remote-fileio.c: Update.
6624         * remote.c: Update.
6625         * riscv-tdep.c: Update.
6626         * rs6000-aix-tdep.c: Update.
6627         * rs6000-tdep.c: Update.
6628         * rust-exp.y: Update.
6629         * rust-lang.c: Update.
6630         * s390-tdep.c: Update.
6631         * selftest-arch.c: Update.
6632         * solib-dsbt.c: Update.
6633         * solib-frv.c: Update.
6634         * solib-spu.c: Update.
6635         * solib-svr4.c: Update.
6636         * solib.c: Update.
6637         * sparc64-linux-tdep.c: Update.
6638         * stack.c: Update.
6639         * symfile-mem.c: Update.
6640         * symmisc.c: Update.
6641         * target.c: Update.
6642         * thread.c: Update.
6643         * top.c: Update.
6644         * tracefile-tfile.c: Update.
6645         * tui/tui.c: Update.
6646         * typeprint.c: Update.
6647         * unittests/cli-utils-selftests.c: Update.
6648         * unittests/parse-connection-spec-selftests.c: Update.
6649         * valops.c: Update.
6650         * valprint.c: Update.
6651         * value.c: Update.
6652         * varobj.c: Update.
6653         * windows-nat.c: Update.
6654         * x86-linux-nat.c: Update.
6655         * xml-support.c: Update.
6656
6657 2019-04-08  Tom Tromey  <tom@tromey.com>
6658
6659         * xml-support.c: Use C++ exception handling.
6660         * x86-linux-nat.c: Use C++ exception handling.
6661         * windows-nat.c: Use C++ exception handling.
6662         * varobj.c: Use C++ exception handling.
6663         * value.c: Use C++ exception handling.
6664         * valprint.c: Use C++ exception handling.
6665         * valops.c: Use C++ exception handling.
6666         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6667         handling.
6668         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6669         * typeprint.c: Use C++ exception handling.
6670         * tui/tui.c: Use C++ exception handling.
6671         * tracefile-tfile.c: Use C++ exception handling.
6672         * top.c: Use C++ exception handling.
6673         * thread.c: Use C++ exception handling.
6674         * target.c: Use C++ exception handling.
6675         * symmisc.c: Use C++ exception handling.
6676         * symfile-mem.c: Use C++ exception handling.
6677         * stack.c: Use C++ exception handling.
6678         * sparc64-linux-tdep.c: Use C++ exception handling.
6679         * solib.c: Use C++ exception handling.
6680         * solib-svr4.c: Use C++ exception handling.
6681         * solib-spu.c: Use C++ exception handling.
6682         * solib-frv.c: Use C++ exception handling.
6683         * solib-dsbt.c: Use C++ exception handling.
6684         * selftest-arch.c: Use C++ exception handling.
6685         * s390-tdep.c: Use C++ exception handling.
6686         * rust-lang.c: Use C++ exception handling.
6687         * rust-exp.y: Use C++ exception handling.
6688         * rs6000-tdep.c: Use C++ exception handling.
6689         * rs6000-aix-tdep.c: Use C++ exception handling.
6690         * riscv-tdep.c: Use C++ exception handling.
6691         * remote.c: Use C++ exception handling.
6692         * remote-fileio.c: Use C++ exception handling.
6693         * record-full.c: Use C++ exception handling.
6694         * record-btrace.c: Use C++ exception handling.
6695         * python/python.c: Use C++ exception handling.
6696         * python/py-value.c: Use C++ exception handling.
6697         * python/py-utils.c: Use C++ exception handling.
6698         * python/py-unwind.c: Use C++ exception handling.
6699         * python/py-type.c: Use C++ exception handling.
6700         * python/py-symbol.c: Use C++ exception handling.
6701         * python/py-record.c: Use C++ exception handling.
6702         * python/py-record-btrace.c: Use C++ exception handling.
6703         * python/py-progspace.c: Use C++ exception handling.
6704         * python/py-prettyprint.c: Use C++ exception handling.
6705         * python/py-param.c: Use C++ exception handling.
6706         * python/py-objfile.c: Use C++ exception handling.
6707         * python/py-linetable.c: Use C++ exception handling.
6708         * python/py-lazy-string.c: Use C++ exception handling.
6709         * python/py-infthread.c: Use C++ exception handling.
6710         * python/py-inferior.c: Use C++ exception handling.
6711         * python/py-gdb-readline.c: Use C++ exception handling.
6712         * python/py-framefilter.c: Use C++ exception handling.
6713         * python/py-frame.c: Use C++ exception handling.
6714         * python/py-finishbreakpoint.c: Use C++ exception handling.
6715         * python/py-cmd.c: Use C++ exception handling.
6716         * python/py-breakpoint.c: Use C++ exception handling.
6717         * python/py-arch.c: Use C++ exception handling.
6718         * printcmd.c: Use C++ exception handling.
6719         * ppc-linux-tdep.c: Use C++ exception handling.
6720         * parse.c: Use C++ exception handling.
6721         * p-valprint.c: Use C++ exception handling.
6722         * objc-lang.c: Use C++ exception handling.
6723         * mi/mi-main.c: Use C++ exception handling.
6724         * mi/mi-interp.c: Use C++ exception handling.
6725         * mi/mi-cmd-stack.c: Use C++ exception handling.
6726         * mi/mi-cmd-break.c: Use C++ exception handling.
6727         * main.c: Use C++ exception handling.
6728         * linux-thread-db.c: Use C++ exception handling.
6729         * linux-tdep.c: Use C++ exception handling.
6730         * linux-nat.c: Use C++ exception handling.
6731         * linux-fork.c: Use C++ exception handling.
6732         * linespec.c: Use C++ exception handling.
6733         * language.c: Use C++ exception handling.
6734         * jit.c: Use C++ exception handling.
6735         * infrun.c: Use C++ exception handling.
6736         * infcmd.c: Use C++ exception handling.
6737         * infcall.c: Use C++ exception handling.
6738         * inf-loop.c: Use C++ exception handling.
6739         * i386-tdep.c: Use C++ exception handling.
6740         * i386-linux-tdep.c: Use C++ exception handling.
6741         * guile/scm-value.c: Use C++ exception handling.
6742         * guile/scm-type.c: Use C++ exception handling.
6743         * guile/scm-symtab.c: Use C++ exception handling.
6744         * guile/scm-symbol.c: Use C++ exception handling.
6745         * guile/scm-pretty-print.c: Use C++ exception handling.
6746         * guile/scm-ports.c: Use C++ exception handling.
6747         * guile/scm-param.c: Use C++ exception handling.
6748         * guile/scm-math.c: Use C++ exception handling.
6749         * guile/scm-lazy-string.c: Use C++ exception handling.
6750         * guile/scm-frame.c: Use C++ exception handling.
6751         * guile/scm-disasm.c: Use C++ exception handling.
6752         * guile/scm-cmd.c: Use C++ exception handling.
6753         * guile/scm-breakpoint.c: Use C++ exception handling.
6754         * guile/scm-block.c: Use C++ exception handling.
6755         * guile/guile-internal.h: Use C++ exception handling.
6756         * gnu-v3-abi.c: Use C++ exception handling.
6757         * gdbtypes.c: Use C++ exception handling.
6758         * frame.c: Use C++ exception handling.
6759         * frame-unwind.c: Use C++ exception handling.
6760         * fbsd-tdep.c: Use C++ exception handling.
6761         * f-valprint.c: Use C++ exception handling.
6762         * exec.c: Use C++ exception handling.
6763         * event-top.c: Use C++ exception handling.
6764         * event-loop.c: Use C++ exception handling.
6765         * eval.c: Use C++ exception handling.
6766         * dwarf2read.c: Use C++ exception handling.
6767         * dwarf2loc.c: Use C++ exception handling.
6768         * dwarf2-frame.c: Use C++ exception handling.
6769         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6770         * dwarf-index-write.c: Use C++ exception handling.
6771         * dwarf-index-cache.c: Use C++ exception handling.
6772         * dtrace-probe.c: Use C++ exception handling.
6773         * disasm-selftests.c: Use C++ exception handling.
6774         * darwin-nat.c: Use C++ exception handling.
6775         * cp-valprint.c: Use C++ exception handling.
6776         * cp-support.c: Use C++ exception handling.
6777         * cp-abi.c: Use C++ exception handling.
6778         * corelow.c: Use C++ exception handling.
6779         * completer.c: Use C++ exception handling.
6780         * compile/compile-object-run.c: Use C++ exception handling.
6781         * compile/compile-object-load.c: Use C++ exception handling.
6782         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6783         * compile/compile-c-symbols.c: Use C++ exception handling.
6784         * common/selftest.c: Use C++ exception handling.
6785         * common/new-op.c: Use C++ exception handling.
6786         * cli/cli-script.c: Use C++ exception handling.
6787         * cli/cli-interp.c: Use C++ exception handling.
6788         * cli/cli-cmds.c: Use C++ exception handling.
6789         * c-varobj.c: Use C++ exception handling.
6790         * btrace.c: Use C++ exception handling.
6791         * breakpoint.c: Use C++ exception handling.
6792         * break-catch-throw.c: Use C++ exception handling.
6793         * arch-utils.c: Use C++ exception handling.
6794         * amd64-tdep.c: Use C++ exception handling.
6795         * ada-valprint.c: Use C++ exception handling.
6796         * ada-typeprint.c: Use C++ exception handling.
6797         * ada-lang.c: Use C++ exception handling.
6798         * aarch64-tdep.c: Use C++ exception handling.
6799
6800 2019-04-08  Tom Tromey  <tom@tromey.com>
6801
6802         * xml-support.c (gdb_xml_parser::parse): Update.
6803         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6804         * value.c (show_convenience): Update.
6805         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6806         (test_parse_flags_qcs): Update.
6807         * thread.c (thr_try_catch_cmd): Update.
6808         * target.c (target_translate_tls_address): Update.
6809         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6810         (info_frame_command_core, frame_apply_command_count): Update.
6811         * rust-exp.y (rust_lex_exception_test): Update.
6812         * riscv-tdep.c (riscv_print_one_register_info): Update.
6813         * remote.c (remote_target::enable_btrace): Update.
6814         * record-btrace.c (record_btrace_enable_warn): Update.
6815         * python/py-utils.c (gdbpy_convert_exception): Update.
6816         * printcmd.c (do_one_display, print_variable_and_value): Update.
6817         * mi/mi-main.c (mi_print_exception): Update.
6818         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6819         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6820         * linux-nat.c (linux_nat_target::attach): Update.
6821         * linux-fork.c (class scoped_switch_fork_info): Update.
6822         * infrun.c (displaced_step_prepare): Update.
6823         * infcall.c (call_function_by_hand_dummy): Update.
6824         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6825         * gnu-v3-abi.c (print_one_vtable): Update.
6826         * frame.c (get_prev_frame_always): Update.
6827         * f-valprint.c (info_common_command_for_block): Update.
6828         * exec.c (try_open_exec_file): Update.
6829         * exceptions.c (print_exception, exception_print)
6830         (exception_fprintf, exception_print_same): Update.
6831         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6832         * dwarf-index-cache.c (index_cache::store)
6833         (index_cache::lookup_gdb_index): Update.
6834         * darwin-nat.c (maybe_cache_shell): Update.
6835         * cp-valprint.c (cp_print_value_fields): Update.
6836         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6837         (gcc_cplus_symbol_address): Update.
6838         * compile/compile-c-symbols.c (gcc_convert_symbol)
6839         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6840         * common/selftest.c: Update.
6841         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6842         a std::string.
6843         (exception_try_scope_entry, exception_try_scope_exit): Don't
6844         declare.
6845         (struct exception_try_scope): Remove.
6846         (TRY): Don't use exception_try_scope.
6847         (struct gdb_exception): Add constructor, operator=.
6848         <what>: New method.
6849         (struct gdb_exception_RETURN_MASK_ALL)
6850         (struct gdb_exception_RETURN_MASK_ERROR)
6851         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6852         (struct gdb_quit_bad_alloc): Update.
6853         * common/common-exceptions.c (exception_none): Change
6854         initializer.
6855         (struct catcher) <state, exception>: Initialize inline.
6856         <prev>: Remove member.
6857         (current_catcher): Remove.
6858         (catchers): New global.
6859         (exceptions_state_mc_init): Simplify.
6860         (catcher_pop): Remove.
6861         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6862         (try_scope_depth, exception_try_scope_entry)
6863         (exception_try_scope_exit): Remove.
6864         (throw_exception_sjlj): Update.
6865         (exception_messages, exception_messages_size): Remove.
6866         (throw_it): Simplify.
6867         (gdb_exception_sliced_copy): Remove.
6868         (throw_exception_cxx): Update.
6869         * cli/cli-script.c (script_from_file): Update.
6870         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6871         Update.
6872         * ada-valprint.c (ada_val_print): Update.
6873         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6874         (create_excep_cond_exprs): Update.
6875
6876 2019-04-08  Tom Tromey  <tom@tromey.com>
6877
6878         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6879         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6880         (TRY, CATCH, END_CATCH): Remove some definitions.
6881         * common/common-exceptions.c: Don't use GDB_XCPT.
6882         (catcher_list_size): Remove.
6883         (throw_exception, throw_it): Simplify.
6884
6885 2019-04-05  Tom Tromey  <tom@tromey.com>
6886
6887         Revert the header-sorting patch.
6888         * ft32-tdep.c: Revert.
6889         * frv-tdep.c: Revert.
6890         * frv-linux-tdep.c: Revert.
6891         * frame.c: Revert.
6892         * frame-unwind.c: Revert.
6893         * frame-base.c: Revert.
6894         * fork-child.c: Revert.
6895         * findvar.c: Revert.
6896         * findcmd.c: Revert.
6897         * filesystem.c: Revert.
6898         * filename-seen-cache.h: Revert.
6899         * filename-seen-cache.c: Revert.
6900         * fbsd-tdep.c: Revert.
6901         * fbsd-nat.h: Revert.
6902         * fbsd-nat.c: Revert.
6903         * f-valprint.c: Revert.
6904         * f-typeprint.c: Revert.
6905         * f-lang.c: Revert.
6906         * extension.h: Revert.
6907         * extension.c: Revert.
6908         * extension-priv.h: Revert.
6909         * expprint.c: Revert.
6910         * exec.h: Revert.
6911         * exec.c: Revert.
6912         * exceptions.c: Revert.
6913         * event-top.c: Revert.
6914         * event-loop.c: Revert.
6915         * eval.c: Revert.
6916         * elfread.c: Revert.
6917         * dwarf2read.h: Revert.
6918         * dwarf2read.c: Revert.
6919         * dwarf2loc.c: Revert.
6920         * dwarf2expr.h: Revert.
6921         * dwarf2expr.c: Revert.
6922         * dwarf2-frame.c: Revert.
6923         * dwarf2-frame-tailcall.c: Revert.
6924         * dwarf-index-write.h: Revert.
6925         * dwarf-index-write.c: Revert.
6926         * dwarf-index-common.c: Revert.
6927         * dwarf-index-cache.h: Revert.
6928         * dwarf-index-cache.c: Revert.
6929         * dummy-frame.c: Revert.
6930         * dtrace-probe.c: Revert.
6931         * disasm.h: Revert.
6932         * disasm.c: Revert.
6933         * disasm-selftests.c: Revert.
6934         * dictionary.c: Revert.
6935         * dicos-tdep.c: Revert.
6936         * demangle.c: Revert.
6937         * dcache.h: Revert.
6938         * dcache.c: Revert.
6939         * darwin-nat.h: Revert.
6940         * darwin-nat.c: Revert.
6941         * darwin-nat-info.c: Revert.
6942         * d-valprint.c: Revert.
6943         * d-namespace.c: Revert.
6944         * d-lang.c: Revert.
6945         * ctf.c: Revert.
6946         * csky-tdep.c: Revert.
6947         * csky-linux-tdep.c: Revert.
6948         * cris-tdep.c: Revert.
6949         * cris-linux-tdep.c: Revert.
6950         * cp-valprint.c: Revert.
6951         * cp-support.c: Revert.
6952         * cp-namespace.c: Revert.
6953         * cp-abi.c: Revert.
6954         * corelow.c: Revert.
6955         * corefile.c: Revert.
6956         * continuations.c: Revert.
6957         * completer.h: Revert.
6958         * completer.c: Revert.
6959         * complaints.c: Revert.
6960         * coffread.c: Revert.
6961         * coff-pe-read.c: Revert.
6962         * cli-out.h: Revert.
6963         * cli-out.c: Revert.
6964         * charset.c: Revert.
6965         * c-varobj.c: Revert.
6966         * c-valprint.c: Revert.
6967         * c-typeprint.c: Revert.
6968         * c-lang.c: Revert.
6969         * buildsym.c: Revert.
6970         * buildsym-legacy.c: Revert.
6971         * build-id.h: Revert.
6972         * build-id.c: Revert.
6973         * btrace.c: Revert.
6974         * bsd-uthread.c: Revert.
6975         * breakpoint.h: Revert.
6976         * breakpoint.c: Revert.
6977         * break-catch-throw.c: Revert.
6978         * break-catch-syscall.c: Revert.
6979         * break-catch-sig.c: Revert.
6980         * blockframe.c: Revert.
6981         * block.c: Revert.
6982         * bfin-tdep.c: Revert.
6983         * bfin-linux-tdep.c: Revert.
6984         * bfd-target.c: Revert.
6985         * bcache.c: Revert.
6986         * ax-general.c: Revert.
6987         * ax-gdb.h: Revert.
6988         * ax-gdb.c: Revert.
6989         * avr-tdep.c: Revert.
6990         * auxv.c: Revert.
6991         * auto-load.c: Revert.
6992         * arm-wince-tdep.c: Revert.
6993         * arm-tdep.c: Revert.
6994         * arm-symbian-tdep.c: Revert.
6995         * arm-pikeos-tdep.c: Revert.
6996         * arm-obsd-tdep.c: Revert.
6997         * arm-nbsd-tdep.c: Revert.
6998         * arm-nbsd-nat.c: Revert.
6999         * arm-linux-tdep.c: Revert.
7000         * arm-linux-nat.c: Revert.
7001         * arm-fbsd-tdep.c: Revert.
7002         * arm-fbsd-nat.c: Revert.
7003         * arm-bsd-tdep.c: Revert.
7004         * arch-utils.c: Revert.
7005         * arc-tdep.c: Revert.
7006         * arc-newlib-tdep.c: Revert.
7007         * annotate.h: Revert.
7008         * annotate.c: Revert.
7009         * amd64-windows-tdep.c: Revert.
7010         * amd64-windows-nat.c: Revert.
7011         * amd64-tdep.c: Revert.
7012         * amd64-sol2-tdep.c: Revert.
7013         * amd64-obsd-tdep.c: Revert.
7014         * amd64-obsd-nat.c: Revert.
7015         * amd64-nbsd-tdep.c: Revert.
7016         * amd64-nbsd-nat.c: Revert.
7017         * amd64-nat.c: Revert.
7018         * amd64-linux-tdep.c: Revert.
7019         * amd64-linux-nat.c: Revert.
7020         * amd64-fbsd-tdep.c: Revert.
7021         * amd64-fbsd-nat.c: Revert.
7022         * amd64-dicos-tdep.c: Revert.
7023         * amd64-darwin-tdep.c: Revert.
7024         * amd64-bsd-nat.c: Revert.
7025         * alpha-tdep.c: Revert.
7026         * alpha-obsd-tdep.c: Revert.
7027         * alpha-nbsd-tdep.c: Revert.
7028         * alpha-mdebug-tdep.c: Revert.
7029         * alpha-linux-tdep.c: Revert.
7030         * alpha-linux-nat.c: Revert.
7031         * alpha-bsd-tdep.c: Revert.
7032         * alpha-bsd-nat.c: Revert.
7033         * aix-thread.c: Revert.
7034         * agent.c: Revert.
7035         * addrmap.c: Revert.
7036         * ada-varobj.c: Revert.
7037         * ada-valprint.c: Revert.
7038         * ada-typeprint.c: Revert.
7039         * ada-tasks.c: Revert.
7040         * ada-lang.c: Revert.
7041         * aarch64-tdep.c: Revert.
7042         * aarch64-ravenscar-thread.c: Revert.
7043         * aarch64-newlib-tdep.c: Revert.
7044         * aarch64-linux-tdep.c: Revert.
7045         * aarch64-linux-nat.c: Revert.
7046         * aarch64-fbsd-tdep.c: Revert.
7047         * aarch64-fbsd-nat.c: Revert.
7048         * aarch32-linux-nat.c: Revert.
7049
7050 2019-04-05  Tom Tromey  <tom@tromey.com>
7051
7052         * ft32-tdep.c: Sort headers.
7053         * frv-tdep.c: Sort headers.
7054         * frv-linux-tdep.c: Sort headers.
7055         * frame.c: Sort headers.
7056         * frame-unwind.c: Sort headers.
7057         * frame-base.c: Sort headers.
7058         * fork-child.c: Sort headers.
7059         * findvar.c: Sort headers.
7060         * findcmd.c: Sort headers.
7061         * filesystem.c: Sort headers.
7062         * filename-seen-cache.h: Sort headers.
7063         * filename-seen-cache.c: Sort headers.
7064         * fbsd-tdep.c: Sort headers.
7065         * fbsd-nat.h: Sort headers.
7066         * fbsd-nat.c: Sort headers.
7067         * f-valprint.c: Sort headers.
7068         * f-typeprint.c: Sort headers.
7069         * f-lang.c: Sort headers.
7070         * extension.h: Sort headers.
7071         * extension.c: Sort headers.
7072         * extension-priv.h: Sort headers.
7073         * expprint.c: Sort headers.
7074         * exec.h: Sort headers.
7075         * exec.c: Sort headers.
7076         * exceptions.c: Sort headers.
7077         * event-top.c: Sort headers.
7078         * event-loop.c: Sort headers.
7079         * eval.c: Sort headers.
7080         * elfread.c: Sort headers.
7081         * dwarf2read.h: Sort headers.
7082         * dwarf2read.c: Sort headers.
7083         * dwarf2loc.c: Sort headers.
7084         * dwarf2expr.h: Sort headers.
7085         * dwarf2expr.c: Sort headers.
7086         * dwarf2-frame.c: Sort headers.
7087         * dwarf2-frame-tailcall.c: Sort headers.
7088         * dwarf-index-write.h: Sort headers.
7089         * dwarf-index-write.c: Sort headers.
7090         * dwarf-index-common.c: Sort headers.
7091         * dwarf-index-cache.h: Sort headers.
7092         * dwarf-index-cache.c: Sort headers.
7093         * dummy-frame.c: Sort headers.
7094         * dtrace-probe.c: Sort headers.
7095         * disasm.h: Sort headers.
7096         * disasm.c: Sort headers.
7097         * disasm-selftests.c: Sort headers.
7098         * dictionary.c: Sort headers.
7099         * dicos-tdep.c: Sort headers.
7100         * demangle.c: Sort headers.
7101         * dcache.h: Sort headers.
7102         * dcache.c: Sort headers.
7103         * darwin-nat.h: Sort headers.
7104         * darwin-nat.c: Sort headers.
7105         * darwin-nat-info.c: Sort headers.
7106         * d-valprint.c: Sort headers.
7107         * d-namespace.c: Sort headers.
7108         * d-lang.c: Sort headers.
7109         * ctf.c: Sort headers.
7110         * csky-tdep.c: Sort headers.
7111         * csky-linux-tdep.c: Sort headers.
7112         * cris-tdep.c: Sort headers.
7113         * cris-linux-tdep.c: Sort headers.
7114         * cp-valprint.c: Sort headers.
7115         * cp-support.c: Sort headers.
7116         * cp-namespace.c: Sort headers.
7117         * cp-abi.c: Sort headers.
7118         * corelow.c: Sort headers.
7119         * corefile.c: Sort headers.
7120         * continuations.c: Sort headers.
7121         * completer.h: Sort headers.
7122         * completer.c: Sort headers.
7123         * complaints.c: Sort headers.
7124         * coffread.c: Sort headers.
7125         * coff-pe-read.c: Sort headers.
7126         * cli-out.h: Sort headers.
7127         * cli-out.c: Sort headers.
7128         * charset.c: Sort headers.
7129         * c-varobj.c: Sort headers.
7130         * c-valprint.c: Sort headers.
7131         * c-typeprint.c: Sort headers.
7132         * c-lang.c: Sort headers.
7133         * buildsym.c: Sort headers.
7134         * buildsym-legacy.c: Sort headers.
7135         * build-id.h: Sort headers.
7136         * build-id.c: Sort headers.
7137         * btrace.c: Sort headers.
7138         * bsd-uthread.c: Sort headers.
7139         * breakpoint.h: Sort headers.
7140         * breakpoint.c: Sort headers.
7141         * break-catch-throw.c: Sort headers.
7142         * break-catch-syscall.c: Sort headers.
7143         * break-catch-sig.c: Sort headers.
7144         * blockframe.c: Sort headers.
7145         * block.c: Sort headers.
7146         * bfin-tdep.c: Sort headers.
7147         * bfin-linux-tdep.c: Sort headers.
7148         * bfd-target.c: Sort headers.
7149         * bcache.c: Sort headers.
7150         * ax-general.c: Sort headers.
7151         * ax-gdb.h: Sort headers.
7152         * ax-gdb.c: Sort headers.
7153         * avr-tdep.c: Sort headers.
7154         * auxv.c: Sort headers.
7155         * auto-load.c: Sort headers.
7156         * arm-wince-tdep.c: Sort headers.
7157         * arm-tdep.c: Sort headers.
7158         * arm-symbian-tdep.c: Sort headers.
7159         * arm-pikeos-tdep.c: Sort headers.
7160         * arm-obsd-tdep.c: Sort headers.
7161         * arm-nbsd-tdep.c: Sort headers.
7162         * arm-nbsd-nat.c: Sort headers.
7163         * arm-linux-tdep.c: Sort headers.
7164         * arm-linux-nat.c: Sort headers.
7165         * arm-fbsd-tdep.c: Sort headers.
7166         * arm-fbsd-nat.c: Sort headers.
7167         * arm-bsd-tdep.c: Sort headers.
7168         * arch-utils.c: Sort headers.
7169         * arc-tdep.c: Sort headers.
7170         * arc-newlib-tdep.c: Sort headers.
7171         * annotate.h: Sort headers.
7172         * annotate.c: Sort headers.
7173         * amd64-windows-tdep.c: Sort headers.
7174         * amd64-windows-nat.c: Sort headers.
7175         * amd64-tdep.c: Sort headers.
7176         * amd64-sol2-tdep.c: Sort headers.
7177         * amd64-obsd-tdep.c: Sort headers.
7178         * amd64-obsd-nat.c: Sort headers.
7179         * amd64-nbsd-tdep.c: Sort headers.
7180         * amd64-nbsd-nat.c: Sort headers.
7181         * amd64-nat.c: Sort headers.
7182         * amd64-linux-tdep.c: Sort headers.
7183         * amd64-linux-nat.c: Sort headers.
7184         * amd64-fbsd-tdep.c: Sort headers.
7185         * amd64-fbsd-nat.c: Sort headers.
7186         * amd64-dicos-tdep.c: Sort headers.
7187         * amd64-darwin-tdep.c: Sort headers.
7188         * amd64-bsd-nat.c: Sort headers.
7189         * alpha-tdep.c: Sort headers.
7190         * alpha-obsd-tdep.c: Sort headers.
7191         * alpha-nbsd-tdep.c: Sort headers.
7192         * alpha-mdebug-tdep.c: Sort headers.
7193         * alpha-linux-tdep.c: Sort headers.
7194         * alpha-linux-nat.c: Sort headers.
7195         * alpha-bsd-tdep.c: Sort headers.
7196         * alpha-bsd-nat.c: Sort headers.
7197         * aix-thread.c: Sort headers.
7198         * agent.c: Sort headers.
7199         * addrmap.c: Sort headers.
7200         * ada-varobj.c: Sort headers.
7201         * ada-valprint.c: Sort headers.
7202         * ada-typeprint.c: Sort headers.
7203         * ada-tasks.c: Sort headers.
7204         * ada-lang.c: Sort headers.
7205         * aarch64-tdep.c: Sort headers.
7206         * aarch64-ravenscar-thread.c: Sort headers.
7207         * aarch64-newlib-tdep.c: Sort headers.
7208         * aarch64-linux-tdep.c: Sort headers.
7209         * aarch64-linux-nat.c: Sort headers.
7210         * aarch64-fbsd-tdep.c: Sort headers.
7211         * aarch64-fbsd-nat.c: Sort headers.
7212         * aarch32-linux-nat.c: Sort headers.
7213
7214 2019-04-04  Tom Tromey  <tom@tromey.com>
7215
7216         * varobj.c (varobj_create): Update.
7217         * rust-exp.y (struct rust_parser) <update_innermost_block,
7218         lookup_symbol>: New methods.
7219         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7220         Rename.
7221         (rust_parser::rust_lookup_type)
7222         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7223         * printcmd.c (display_command, do_one_display): Update.
7224         * parser-defs.h (struct parser_state) <parser_state>: Add
7225         "tracker" parameter.
7226         (block_tracker): New member.
7227         (class innermost_block_tracker) <innermost_block_tracker>: Add
7228         "types" parameter.
7229         <reset>: Remove method.
7230         (innermost_block): Don't declare.
7231         (null_post_parser): Update.
7232         * parse.c (innermost_block): Remove global.
7233         (write_dollar_variable): Update.
7234         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7235         Remove "tracker_types" parameter.
7236         (parse_expression): Add "tracker" parameter.
7237         (parse_expression_for_completion): Update.
7238         (null_post_parser): Add "tracker" parameter.
7239         * p-exp.y: Update rules.
7240         * m2-exp.y: Update rules.
7241         * language.h (struct language_defn) <la_post_parser>: Add
7242         "tracker" parameter.
7243         * go-exp.y: Update rules.
7244         * f-exp.y: Update rules.
7245         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7246         parameter.
7247         * d-exp.y: Update rules.
7248         * c-exp.y: Update rules.
7249         * breakpoint.c (set_breakpoint_condition): Create an
7250         innermost_block_tracker.
7251         (watch_command_1): Likewise.
7252         * ada-lang.c (resolve): Add "tracker" parameter.
7253         (resolve_subexp): Likewise.
7254         * ada-exp.y (write_var_from_sym): Update.
7255
7256 2019-04-04  Tom Tromey  <tom@tromey.com>
7257
7258         * type-stack.h: New file.
7259         * type-stack.c: New file.
7260         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7261         type-stack.h.
7262         (insert_into_type_stack, insert_type, push_type, push_type_int)
7263         (insert_type_address_space, pop_type, pop_type_int)
7264         (pop_typelist, pop_type_stack, append_type_stack)
7265         (push_type_stack, get_type_stack, push_typelist)
7266         (follow_type_instance_flags, follow_types): Don't declare.
7267         * parse.c (type_stack): Remove global.
7268         (parse_exp_in_context): Update.
7269         (insert_into_type_stack, insert_type, push_type, push_type_int)
7270         (insert_type_address_space, pop_type, pop_type_int)
7271         (pop_typelist, pop_type_stack, append_type_stack)
7272         (push_type_stack, get_type_stack, push_typelist)
7273         (follow_type_instance_flags, follow_types): Remove (moved to
7274         type-stack.c).
7275         * f-exp.y (type_stack): New global.
7276         Update rules.
7277         (push_kind_type, f_parse): Update.
7278         * d-exp.y (type_stack): New global.
7279         Update rules.
7280         (d_parse): Update.
7281         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7282         Update rules.
7283         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7284         (HFILES_NO_SRCDIR): Add type-stack.h.
7285
7286 2019-04-04  Tom Tromey  <tom@tromey.com>
7287
7288         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7289         (rust_parser::convert_ast_to_expression, rust_parse)
7290         (rust_lex_test_completion, rust_lex_tests): Update.
7291         * parser-defs.h (struct expr_completion_state): New.
7292         (struct parser_state) <parser_state>: Add completion parameter.
7293         <mark_struct_expression, mark_completion_tag>: New methods.
7294         <parse_completion, m_completion_state>: New members.
7295         (prefixify_expression, null_post_parser): Update.
7296         (mark_struct_expression, mark_completion_tag): Don't declare.
7297         * parse.c (parse_completion, expout_last_struct)
7298         (expout_tag_completion_type, expout_completion_name): Remove
7299         globals.
7300         (parser_state::mark_struct_expression)
7301         (parser_state::mark_completion_tag): Now methods.
7302         (prefixify_expression): Add last_struct parameter.
7303         (prefixify_subexp): Likewise.
7304         (parse_exp_1): Update.
7305         (parse_exp_in_context): Add cstate parameter.  Update.
7306         (parse_expression_for_completion): Create an
7307         expr_completion_state.
7308         (null_post_parser): Add "completion" parameter.
7309         * p-exp.y: Update rules.
7310         (yylex): Update.
7311         * language.h (struct language_defn) <la_post_parser>: Add
7312         "completing" parameter.
7313         * go-exp.y: Update rules.
7314         (lex_one_token): Update.
7315         * expression.h (parse_completion): Don't declare.
7316         * d-exp.y: Update rules.
7317         (lex_one_token): Update rules.
7318         * c-exp.y: Update rules.
7319         (lex_one_token): Update.
7320         * ada-lang.c (resolve): Add "parse_completion" parameter.
7321         (resolve_subexp): Likewise.
7322         (ada_resolve_function): Likewise.
7323
7324 2019-04-04  Tom Tromey  <tom@tromey.com>
7325
7326         * parser-defs.h (struct parser_state) <start_arglist,
7327         end_arglist>: New methods.
7328         <arglist_len, m_funcall_chain>: New members.
7329         (arglist_len, start_arglist, end_arglist): Don't declare.
7330         * parse.c (arglist_len, funcall_chain): Remove global.
7331         (start_arglist, end_arglist): Remove functions.
7332         (parse_exp_in_context): Update.
7333         * p-exp.y: Update rules.
7334         * m2-exp.y: Update rules.
7335         * go-exp.y: Update rules.
7336         * f-exp.y: Update rules.
7337         * d-exp.y: Update rules.
7338         * c-exp.y: Update rules.
7339
7340 2019-04-04  Tom Tromey  <tom@tromey.com>
7341
7342         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7343         lex_operator, push_back>: New methods.
7344         Update all rules.
7345         (rust_parser::lex_hex, lex_escape): Rename and update.
7346         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7347         (rust_parser::lex_operator): Rename and update.
7348         (rust_parser::lex_number, rustyylex, rustyyerror)
7349         (rust_lex_test_init, rust_lex_test_sequence)
7350         (rust_lex_test_push_back, rust_lex_tests): Update.
7351         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7352         parameter.
7353         <lexptr, prev_lexptr>: New members.
7354         (lexptr, prev_lexptr): Don't declare.
7355         * parse.c (lexptr, prev_lexptr): Remove globals.
7356         (parse_exp_in_context): Update.
7357         * p-exp.y (yylex, yyerror): Update.
7358         * m2-exp.y (parse_number, yylex, yyerror): Update.
7359         * go-exp.y (lex_one_token, yyerror): Update.
7360         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7361         * d-exp.y (lex_one_token, yyerror): Update.
7362         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7363         (lex_one_token, yyerror): Update.
7364         * ada-lex.l (YY_INPUT): Update.
7365         (rewind_to_char): Update.
7366         * ada-exp.y (yyerror): Update.
7367
7368 2019-04-04  Tom Tromey  <tom@tromey.com>
7369
7370         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7371         * parser-defs.h (struct parser_state) <parser_state>: Add new
7372         parameter.
7373         <comma_terminates>: New member.
7374         (comma_terminates): Don't declare global.
7375         * parse.c (comma_terminates): Remove global.
7376         (parse_exp_in_context): Update.
7377         * p-exp.y (yylex): Update.
7378         * m2-exp.y (yylex): Update.
7379         * go-exp.y (lex_one_token): Update.
7380         * f-exp.y (yylex): Update.
7381         * d-exp.y (lex_one_token): Update.
7382         * c-exp.y (lex_one_token): Update.
7383         * ada-lex.l: Update.
7384
7385 2019-04-04  Tom Tromey  <tom@tromey.com>
7386
7387         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7388         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7389         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7390         * parser-defs.h (paren_depth): Don't declare.
7391         * parse.c (paren_depth): Remove global.
7392         (parse_exp_in_context): Update.
7393         * p-exp.y (paren_depth): New global.
7394         (pascal_parse): Initialize it.
7395         * m2-exp.y (paren_depth): New global.
7396         (m2_parse): Initialize it.
7397         * go-exp.y (paren_depth): New global.
7398         (go_parse): Initialize it.
7399         * f-exp.y (paren_depth): New global.
7400         (f_parse): Initialize it.
7401         * d-exp.y (paren_depth): New global.
7402         (d_parse): Initialize it.
7403         * c-exp.y (paren_depth): New global.
7404         (c_parse): Initialize it.
7405         * ada-lex.l (paren_depth): New global.
7406         (lexer_init): Initialize it.
7407
7408 2019-04-04  Tom Tromey  <tom@tromey.com>
7409
7410         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7411         (rust_parser::convert_ast_to_type)
7412         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7413         * parser-defs.h (struct parser_state) <parser_state>: Add
7414         parameters.  Initialize new members.
7415         <expression_context_block, expression_context_pc>: New members.
7416         * parse.c (expression_context_block, expression_context_pc):
7417         Remove globals.
7418         (parse_exp_in_context): Update.
7419         * p-exp.y: Update all rules.
7420         (yylex): Update.
7421         * m2-exp.y: Update all rules.
7422         (yylex): Update.
7423         * go-exp.y (yylex): Update.
7424         * f-exp.y (yylex): Update.
7425         * d-exp.y: Update all rules.
7426         (yylex): Update.
7427         * c-exp.y: Update all rules.
7428         (lex_one_token, classify_name, yylex, c_parse): Update.
7429         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7430
7431 2019-04-04  Tom Tromey  <tom@tromey.com>
7432
7433         * gdbarch.h, gdbarch.c: Rebuild.
7434         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7435         * stap-probe.h:
7436         (struct stap_parse_info): Replace "parser_state" with
7437         "expr_builder".
7438         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7439         (parser_state): New class.
7440         * parse.c (expr_builder): Rename.
7441         (expr_builder::release): Rename.
7442         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7443         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7444         (write_exp_elt_longcst, write_exp_elt_floatcst)
7445         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7446         (write_exp_string_vector, write_exp_bitstring)
7447         (write_exp_msymbol, mark_struct_expression)
7448         (write_dollar_variable)
7449         (insert_type_address_space, increase_expout_size): Replace
7450         "parser_state" with "expr_builder".
7451         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7452         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7453         "parser_state" with "expr_builder".
7454
7455 2019-04-04  Tom Tromey  <tom@tromey.com>
7456
7457         * rust-exp.y: Replace "parse_language" with method call.
7458         * p-exp.y:
7459         (yylex): Replace "parse_language" with method call.
7460         * m2-exp.y:
7461         (yylex): Replace "parse_language" with method call.
7462         * go-exp.y (classify_name): Replace "parse_language" with method
7463         call.
7464         * f-exp.y (yylex): Replace "parse_language" with method call.
7465         * d-exp.y (lex_one_token): Replace "parse_language" with method
7466         call.
7467         * c-exp.y:
7468         (lex_one_token, classify_name, yylex): Replace "parse_language"
7469         with method call.
7470         * ada-exp.y (find_primitive_type, type_char)
7471         (type_system_address): Replace "parse_language" with method call.
7472
7473 2019-04-04  Tom Tromey  <tom@tromey.com>
7474
7475         * rust-exp.y: Replace "parse_gdbarch" with method call.
7476         * parse.c (write_dollar_variable, insert_type_address_space):
7477         Replace "parse_gdbarch" with method call.
7478         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7479         call.
7480         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7481         call.
7482         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7483         "parse_gdbarch" with method call.
7484         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7485         with method call.
7486         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7487         "parse_gdbarch" with method call.
7488         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7489         "parse_gdbarch" with method call.
7490         * c-exp.y (parse_type, parse_number, classify_name): Replace
7491         "parse_gdbarch" with method call.
7492         * ada-lex.l: Replace "parse_gdbarch" with method call.
7493         * ada-exp.y (parse_type, find_primitive_type, type_char)
7494         (type_system_address): Replace "parse_gdbarch" with method call.
7495
7496 2019-04-04  Tom Tromey  <tom@tromey.com>
7497
7498         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7499         * stap-probe.c (stap_parse_argument): Update.
7500         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7501         initial_size parameter.
7502         * rust-exp.y (rust_lex_tests): Update.
7503         * parse.c (parser_state): Update.
7504         (parse_exp_in_context): Update.
7505         * parser-defs.h (struct parser_state) <parser_state>: Remove
7506         "initial_size" parameter.
7507
7508 2019-04-04  Tom Tromey  <tom@tromey.com>
7509
7510         * parser-defs.h (increase_expout_size): Don't declare.
7511         * parse.c (increase_expout_size): Now static.
7512
7513 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7514
7515         * gnu-nat.c (gnu_nat_target::wait): Fix
7516         target_waitstatus_to_string call.
7517
7518 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * eval.c (evaluate_subexp_standard): Handle internal functions
7521         during Fortran function call handling.
7522
7523 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7524
7525         * NEWS: Mention new internal functions.
7526         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7527         (read_base_type): Use dwarf2_init_complex_target_type.
7528         * value.c (creal_internal_fn): New function.
7529         (cimag_internal_fn): New function.
7530         (_initialize_values): Register new internal functions.
7531
7532 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7533
7534         * infrun.c (stop_all_threads): If debug_infrun, always
7535         trace the wait status after wait_one, using
7536         target_waitstatus_to_string and target_pid_to_str.
7537         (handle_inferior_event): Replace various trace of
7538         wait status kind by a single trace.
7539         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7540         wait status kind image by target_waitstatus_to_string.
7541         * target/waitstatus.c (target_waitstatus_to_string): Fix
7542         obsolete comment.
7543
7544 2019-04-01  Tom Tromey  <tromey@adacore.com>
7545
7546         PR symtab/23331:
7547         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7548
7549 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7550             Pedro Alves  <palves@redhat.com>
7551
7552         * top.c (quit_force): Call 'finalize_values'.
7553         * value.c (finalize_values): New function.
7554         * value.h (finalize_values): Declare.
7555
7556 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7557
7558         * NEWS: Announce $_gdb_major and $_gdb_minor.
7559
7560         * top.c (init_gdb_version_vars): New function.
7561         (gdb_init): Call init_gdb_version_vars.
7562
7563 2019-03-29  Tom Tromey  <tromey@adacore.com>
7564
7565         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7566         help text.  Remove dead code.
7567
7568 2019-03-29  Keith Seitz  <keiths@redhat.com>
7569
7570         From Siddhesh Poyarekar:
7571         * f-lang.h (f77_get_upperbound): Return LONGEST.
7572         (f77_get_lowerbound): Likewise.
7573         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7574         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7575         print them.
7576         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7577         plongest to format print it.
7578         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7579         (f77_get_upperbound): Likewise.
7580         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7581         LOWER_BOUND to LONGEST.
7582         (f77_create_arrayprint_offset_tbl): Likewise.
7583
7584 2019-03-29  Keith Seitz  <keiths@redhat.com>
7585
7586         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7587         %s/pulongest for TYPE_LENGTH instead of %d in format
7588         strings.
7589         * ada-typerint.c (ada_print_type): Likewise.
7590         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7591         * compile/compile-c-support.c (generate_register_struct): Likewise.
7592         * gdbtypes.c (recursive_dump_type): Likewise.
7593         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7594         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7595         instead of %d in format strings.
7596         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7597         to std::min to ULONGEST.
7598         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7599         instead of %d in format strings.
7600         * tracepoint.c (info_scope_command): Likewise.
7601         * typeprint.c (print_offset_data::update)
7602         (print_offset_data::finish): Likewise.
7603         * xtensa-tdep.c (xtensa_store_return_value)
7604         (xtensa_push_dummy_call): Likewise.
7605
7606 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7607
7608         * windows-nat.c (display_selector): Fixed format specifications
7609         for 64-bit Cygwin.
7610
7611 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7612
7613         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7614
7615 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7616
7617         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7618         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7619         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7620         (nios2_linux_init_abi): Install it.
7621
7622 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7623
7624         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7625
7626 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7627
7628         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7629
7630 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7631             Tom Tromey  <tromey@adacore.com>
7632
7633         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7634
7635 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7636
7637         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7638         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7639         method to compute the bounds of range types. Also print "[evaluated]"
7640         if the bounds' values come from a dynamic evaluation.
7641
7642 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7643
7644         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7645         whitespace when pretty printing is on.
7646
7647 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7648
7649         * ppc-linux-nat.c: Add include.
7650
7651 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7652
7653         * NEWS: Mention AArch64 Pointer Authentication.
7654
7655 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7656
7657         * arm-linux-nat.c: Add include.
7658
7659 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7660
7661         * source-cache.c (source_cache::get_source_lines): Re-read
7662         fullname after calling open_source_file.
7663
7664 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7665
7666         * NEWS: Mention TLS support for FreeBSD.
7667
7668 2019-03-25  Tom Tromey  <tromey@adacore.com>
7669
7670         * minsyms.c (BUNCH_SIZE): Update comment.
7671         (~minimal_symbol_reader): Remove old comment.
7672         (compact_minimal_symbols): Update comment.
7673         (minimal_symbol_reader::install): Remove old comment.  Update
7674         other comments.
7675
7676 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7677
7678         * s390-linux-nat.c: Add include.
7679
7680 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7681
7682         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7683         Call linux_get_hwcap.
7684         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7685         Likewise.
7686         (aarch64_linux_get_hwcap): Remove function.
7687         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7688         declaration.
7689         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7690         linux_get_hwcap.
7691         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7692         * linux-tdep.c (linux_get_hwcap): Add function.
7693         (linux_get_hwcap2): Likewise.
7694         * linux-tdep.h (linux_get_hwcap): Add declaration.
7695         (linux_get_hwcap2): Likewise.
7696         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7697         (ppc_linux_get_hwcap2): Likewise.
7698         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7699         linux_get_hwcap.
7700         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7701         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7702         (ppc_linux_nat_target::read_description): Likewise.
7703         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7704         * s390-linux-nat.c: Likewise.
7705         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7706
7707 2019-03-24  Tom Tromey  <tom@tromey.com>
7708
7709         * ada-lang.c (standard_lookup): Simplify initialization.
7710         (ada_lookup_symbol_nonlocal): Simplify return.
7711         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7712         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7713         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7714         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7715         initialization.
7716         * solib.c (solib_global_lookup): Simplify.
7717         * symtab.c (null_block_symbol): Remove.
7718         (symbol_cache_lookup): Simplify returns.
7719         (lookup_language_this): Simplify returns.
7720         (lookup_symbol_aux): Simplify return.
7721         (lookup_local_symbol): Simplify returns.
7722         (lookup_global_symbol_from_objfile): Simplify return.
7723         (lookup_symbol_in_objfile_symtabs)
7724         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7725         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7726         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7727         * cp-namespace.c (cp_lookup_bare_symbol)
7728         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7729         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7730         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7731         (cp_lookup_symbol_via_imports): Simplify initialization.
7732         (find_symbol_in_baseclass): Likewise.
7733         * symtab.h (null_block_symbol): Remove.
7734         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7735         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7736         (d_lookup_symbol_module): Likewise.
7737         (find_symbol_in_baseclass): Simplify initialization.
7738
7739 2019-03-24  Tom Tromey  <tom@tromey.com>
7740
7741         * expression.h: Don't include symtab.h.
7742         (struct block): Forward declare.
7743
7744 2019-03-24  Tom Tromey  <tom@tromey.com>
7745
7746         * c-exp.y (typebase): Remove casts.
7747         * gdbtypes.c (lookup_unsigned_typename, )
7748         (lookup_signed_typename): Remove cast.
7749         * eval.c (parse_to_comma_and_eval): Remove cast.
7750         * parse.c (write_dollar_variable): Remove cast.
7751         * block.h (struct block) <superblock>: Now const.
7752         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7753         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7754         (map_block): Make "block" const.
7755         * symfile.h (struct quick_symbol_functions)
7756         <map_matching_symbols>: Constify block argument to "callback".
7757         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7758         const.
7759         (find_pc_sect_compunit_symtab): Make "b" const.
7760         (find_symbol_at_address): Likewise.
7761         (search_symbols): Likewise.
7762         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7763         (dw2_debug_names_lookup_symbol): Likewise.
7764         (dw2_map_matching_symbols): Update.
7765         * p-valprint.c (pascal_val_print): Remove "block".
7766         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7767         (aux_add_nonlocal_symbols): Make "block" const.
7768         (resolve_subexp): Remove cast.
7769         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7770         const.
7771         (iterate_over_file_blocks): Likewise.
7772         * f-exp.y (%union) <bval>: Remove.
7773         * coffread.c (patch_opaque_types): Make "b" const.
7774         * spu-tdep.c (spu_catch_start): Make "block" const.
7775         * c-valprint.c (print_unpacked_pointer): Remove "block".
7776         * symmisc.c (dump_symtab_1): Make "b" const.
7777         (block_depth): Make "block" const.
7778         * d-exp.y (%union) <bval>: Remove.
7779         * cp-support.h (cp_lookup_rtti_type): Update.
7780         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7781         * psymtab.c (psym_lookup_symbol): Make "block" const.
7782         (maintenance_check_psymtabs): Make "b" const.
7783         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7784         (enumerate_locals, enumerate_args): Update.
7785         * python/py-symtab.c (stpy_global_block): Make "block" const.
7786         (stpy_static_block): Likewise.
7787         * inline-frame.c (block_starting_point_at): Make "new_block"
7788         const.
7789         * block.c (find_block_in_blockvector): Make return type const.
7790         (blockvector_for_pc_sect): Make "b" const.
7791         (find_block_in_blockvector): Make "b" const.
7792
7793 2019-03-23  Tom Tromey  <tom@tromey.com>
7794
7795         * varobj.c (varobj_create): Update.
7796         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7797         * printcmd.c (display_command, do_one_display): Don't reset
7798         innermost_block.
7799         * parser-defs.h (enum innermost_block_tracker_type): Move to
7800         expression.h.
7801         (innermost_block): Update comment.
7802         * parse.c (parse_exp_1): Add tracker_types parameter.
7803         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7804         tracker_types parameter.  Reset innermost_block.
7805         (parse_exp_in_context): Remove.
7806         (parse_expression_for_completion): Update.
7807         * objfiles.c (~objfile): Don't reset expression_context_block or
7808         innermost_block.
7809         * expression.h (enum innermost_block_tracker_type): Move from
7810         parser-defs.h.
7811         (parse_exp_1): Add tracker_types parameter.
7812         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7813         reset innermost_block.
7814
7815 2019-03-23  Tom Tromey  <tom@tromey.com>
7816
7817         * objfiles.h: Include bcache.h.
7818
7819 2019-03-23  Tom Tromey  <tom@tromey.com>
7820
7821         * linespec.c (get_current_search_block): Use
7822         scoped_restore_current_language.
7823         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7824
7825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7826             Jiong Wang  <jiong.wang@arm.com>
7827
7828         * aarch64-linux-tdep.c
7829         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7830         section.
7831         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7832
7833 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7834             Jiong Wang  <jiong.wang@arm.com>
7835
7836         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7837         instructions.
7838         (aarch64_analyze_prologue_test): Add PACIASP test.
7839         (aarch64_prologue_prev_register): Unmask PC value.
7840
7841 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7842             Jiong Wang  <jiong.wang@arm.com>
7843
7844         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7845         (aarch64_dwarf2_prev_register): Unmask PC value.
7846         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7847         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7848         DW_CFA_AARCH64_negate_ra_state.
7849         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7850
7851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7852             Jiong Wang  <jiong.wang@arm.com>
7853
7854         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7855         registers.
7856         (aarch64_pseudo_register_name): Likewise.
7857         (aarch64_pseudo_register_type): Likewise.
7858         (aarch64_pseudo_register_reggroup_p): Likewise.
7859         (aarch64_gdbarch_init): Add pauth registers.
7860         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7861         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7862         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7863         (struct gdbarch_tdep): Add regnum for ra_state.
7864
7865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7866             Jiong Wang  <jiong.wang@arm.com>
7867
7868         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7869
7870 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7871             Jiong Wang  <jiong.wang@arm.com>
7872
7873         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7874         function.
7875         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7876         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7877         (aarch64_gdbarch_init): Add puth registers.
7878         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7879         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7880         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7881
7882 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7883             Jiong Wang  <jiong.wang@arm.com>
7884
7885         * aarch64-linux-nat.c
7886         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7887         * aarch64-linux-tdep.c
7888         (aarch64_linux_core_read_description): Likewise.
7889         (aarch64_linux_get_hwcap): New function.
7890         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7891         (aarch64_linux_get_hwcap): New declaration.
7892
7893 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7894             Jiong Wang  <jiong.wang@arm.com>
7895
7896         * aarch64-linux-nat.c
7897         (aarch64_linux_nat_target::read_description): Add pauth param.
7898         * aarch64-linux-tdep.c
7899         (aarch64_linux_core_read_description): Likewise.
7900         * aarch64-tdep.c (struct target_desc): Add in pauth.
7901         (aarch64_read_description): Add pauth param.
7902         (aarch64_gdbarch_init): Likewise.
7903         * aarch64-tdep.h (aarch64_read_description): Likewise.
7904         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7905         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7906         * features/Makefile: Add new files.
7907         * features/aarch64-pauth.c: New file.
7908         * features/aarch64-pauth.xml: New file.
7909
7910 2019-03-20  Tom Tromey  <tromey@adacore.com>
7911
7912         * infrun.c (handle_inferior_event): Rename from
7913         handle_inferior_event_1.  Create a scoped_value_mark.
7914         (handle_inferior_event): Remove.
7915
7916 2019-03-19  Tom Tromey  <tromey@adacore.com>
7917
7918         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7919         * infrun.h (print_stop_event): Add "displays" parameter.
7920         * infrun.c (print_stop_event): Add "displays" parameter.
7921
7922 2019-03-19  Pedro Alves  <palves@redhat.com>
7923
7924         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7925         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7926         to -1.  Fix TABs vs spaces.
7927         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7928         * tui/tui-out.h (tui_ui_out) Add intro comments.
7929         <m_line, m_start_of_line>: In-class initialize, and add describing
7930         comment.
7931
7932 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7933
7934         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7935         variable names.
7936         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7937
7938 2019-03-18  Pedro Alves  <palves@redhat.com>
7939             Eli Zaretskii <eliz@gnu.org>
7940
7941         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7942         m_line and m_start_of_line.
7943
7944 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7945
7946         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7947         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7948         it returns a newline.  This fixes a regression in TU mode, whereby
7949         the next line is output on the same screen line as the user input.
7950
7951 2019-03-18  Tom Tromey  <tromey@adacore.com>
7952
7953         * minsyms.c (minimal_symbol_reader::install): Remove call to
7954         obstack_blank.
7955
7956 2019-03-18  Pedro Alves  <palves@redhat.com>
7957
7958         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7959         New globals.
7960         (apply_style): New, factored out from ...
7961         (apply_ansi_escape): ... this.  Handle reverse video mode.
7962         (tui_set_reverse_mode): New function.
7963         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7964         * tui/tui-winsource.c (tui_show_source_line): Use
7965         tui_set_reverse_mode instead of setting A_STANDOUT.
7966         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7967         New setter methods.
7968
7969 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7970
7971         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7972         Handle tabs.
7973
7974 2019-03-18  Tom Tromey  <tromey@adacore.com>
7975
7976         * ada-lang.c (empty_array): Add "high" parameter.
7977         (ada_evaluate_subexp): Update.
7978
7979 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7980
7981         * unittests/string_view-selftests.c: Define
7982         _initialize_string_view_selftests unconditionally.
7983
7984 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7985
7986         PR gdb/24350
7987         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7988
7989 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7990
7991         PR gdb/24351
7992         * windows-nat.c (display_selector): Fix format specifiers.
7993
7994 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7995
7996         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7997         tui_refill_source_window instead of tui_refresh_win, to update the
7998         current execution line.  This fixes redisplay of the current line
7999         when stepping through the code with "next" or "step".
8000
8001 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8002
8003         * source-cache.c (source_cache::get_source_lines): Call
8004         find_source_lines to initialize s->nlines.  This fixes vertical
8005         scrolling of TUI source window when the DOWN arrow is pressed.
8006
8007 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008
8009         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8010         linux-thread-db.c (_initialize_thread_db): Likewise.
8011
8012 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8013
8014         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8015         wclrtoeol in tui_show_source_line".  This reverts changes made in
8016         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8017
8018 2019-03-15  Tom Tromey  <tom@tromey.com>
8019
8020         * symtab.h (struct minimal_symbol): Derive from
8021         general_symbol_info.
8022         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8023         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8024         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8025         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8026         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8027         (MSYMBOL_SEARCH_NAME): Update.
8028         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8029         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8030         * minsyms.c (minimal_symbol_reader::record_full): Update.
8031
8032 2019-03-15  Tom Tromey  <tom@tromey.com>
8033
8034         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8035
8036 2019-03-15  Tom Tromey  <tom@tromey.com>
8037
8038         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8039         unique_xmalloc_ptr.
8040         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8041         Update.
8042         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8043         (build_minimal_symbol_hash_tables)
8044         (minimal_symbol_reader::install): Update.
8045
8046 2019-03-15  Tom Tromey  <tom@tromey.com>
8047
8048         * symtab.c (create_demangled_names_hash): Update.
8049         (symbol_set_names): Update.
8050         * objfiles.h (struct objfile_per_bfd_storage)
8051         <demangled_names_hash>: Now an htab_up.
8052         * objfiles.c (objfile_per_bfd_storage): Simplify.
8053
8054 2019-03-15  Tom Tromey  <tom@tromey.com>
8055
8056         * objfiles.h (struct objfile_per_bfd_storage): Declare
8057         destructor.
8058         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8059         New.
8060         (get_objfile_bfd_data): Use new.  Don't initialize
8061         language_of_main.
8062         (free_objfile_per_bfd_storage): Remove.
8063         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8064
8065 2019-03-15  Tom Tromey  <tom@tromey.com>
8066
8067         * symfile.c (reread_symbols): Update.
8068         * objfiles.c (objfile::objfile): Update.
8069         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8070         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8071         comment.
8072         (minimal_symbol_reader::install): Update.
8073         (terminate_minimal_symbol_table): Remove.
8074         * jit.c (jit_object_close_impl): Update.
8075
8076 2019-03-15  Tom Tromey  <tom@tromey.com>
8077
8078         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8079         initializations.
8080
8081 2019-03-15  Tom Tromey  <tom@tromey.com>
8082
8083         * objfiles.h (struct objfile_per_bfd_storage)
8084         <demangled_hash_languages>: Now a bitset.
8085         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8086         (lookup_minimal_symbol): Update.
8087
8088 2019-03-15  Tom Tromey  <tom@tromey.com>
8089
8090         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8091         Don't return the symbol.
8092         * coffread.c (record_minimal_symbol): Use record_full.
8093
8094 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8095
8096         The MS-Windows port of ncurses fails to switch to a color pair if
8097         one or both of the colors are the implicit default colors.  This
8098         change records the default colors when TUI is initialized, and
8099         then specifies them explicitly when a color pair uses the default
8100         colors.  This allows color styling in TUI mode on MS-Windows.
8101
8102         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8103         ncurses_norm_attr.
8104         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8105         colors in ncurses_norm_attr.
8106         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8107         "none", replace it with the default color recorded in
8108         ncurses_norm_attr.
8109
8110 2019-03-14  Tom Tromey  <tromey@adacore.com>
8111
8112         * source-cache.h (class source_cache) <get_source_lines>: Return
8113         std::string.
8114         * source-cache.c (source_cache::extract_lines): Handle case where
8115         first_pos==npos.  Return std::string.
8116         (source_cache::get_source_lines): Update.
8117
8118 2019-03-14  Tom Tromey  <tromey@adacore.com>
8119
8120         * NEWS: Add item for "style sources" commands.
8121         * source-cache.c (source_cache::get_source_lines): Check
8122         source_styling.
8123         * cli/cli-style.c (source_styling): New global.
8124         (_initialize_cli_style): Add "style sources" commands.
8125         (show_style_sources): New function.
8126         * cli/cli-style.h (source_styling): Declare.
8127
8128 2019-03-14  Pedro Alves  <palves@redhat.com>
8129             Tom Tromey  <tromey@adacore.com>
8130
8131         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8132         * tui/tui-winsource.c (tui_refill_source_window): New function,
8133         from...
8134         (tui_horizontal_source_scroll): ... here.  Move some logic.
8135         * cli/cli-style.c (set_style_enabled): Notify new observable.
8136         * tui/tui-hooks.c (tui_redisplay_source): New function.
8137         (tui_attach_detach_observers): Attach or detach
8138         tui_redisplay_source.
8139         * observable.h (source_styling_changed): New observable.
8140         * observable.c: Define source_styling_changed observable.
8141
8142 2019-03-13  Tom Tromey  <tromey@adacore.com>
8143
8144         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8145         (i386_gnu_nat_target::store_registers): Update.
8146         * target-debug.h (target_debug_print_std_string): New macro.
8147         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8148         * windows-tdep.c (display_one_tib): Update.
8149         * tui/tui-stack.c (tui_make_status_line): Update.
8150         * top.c (print_inferior_quit_action): Update.
8151         * thread.c (thr_try_catch_cmd): Update.
8152         (add_thread_with_info): Update.
8153         (thread_target_id_str): Update.
8154         (thr_try_catch_cmd): Update.
8155         (thread_command): Update.
8156         (thread_find_command): Update.
8157         * record-btrace.c (record_btrace_target::info_record)
8158         (record_btrace_resume_thread, record_btrace_target::resume)
8159         (record_btrace_cancel_resume, record_btrace_step_thread)
8160         (record_btrace_target::wait, record_btrace_target::wait)
8161         (record_btrace_target::wait, record_btrace_target::stop): Update.
8162         * progspace.c (print_program_space): Update.
8163         * process-stratum-target.c
8164         (process_stratum_target::thread_address_space): Update.
8165         * linux-fork.c (linux_fork_mourn_inferior)
8166         (detach_checkpoint_command, info_checkpoints_command)
8167         (linux_fork_context): Update.
8168         (linux_fork_detach): Update.
8169         (class scoped_switch_fork_info): Update.
8170         (delete_checkpoint_command): Update.
8171         * infrun.c (follow_fork_inferior): Update.
8172         (follow_fork_inferior): Update.
8173         (proceed_after_vfork_done): Update.
8174         (handle_vfork_child_exec_or_exit): Update.
8175         (follow_exec): Update.
8176         (displaced_step_prepare_throw): Update.
8177         (displaced_step_restore): Update.
8178         (start_step_over): Update.
8179         (resume_1): Update.
8180         (clear_proceed_status_thread): Update.
8181         (proceed): Update.
8182         (print_target_wait_results): Update.
8183         (do_target_wait): Update.
8184         (context_switch): Update.
8185         (stop_all_threads): Update.
8186         (restart_threads): Update.
8187         (finish_step_over): Update.
8188         (handle_signal_stop): Update.
8189         (switch_back_to_stepped_thread): Update.
8190         (keep_going_pass_signal): Update.
8191         (print_exited_reason): Update.
8192         (normal_stop): Update.
8193         * inferior.c (inferior_pid_to_str): Change return type.
8194         (print_selected_inferior): Update.
8195         (add_inferior): Update.
8196         (detach_inferior): Update.
8197         * dummy-frame.c (fprint_dummy_frames): Update.
8198         * dcache.c (dcache_info_1): Update.
8199         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8200         (btrace_fetch, btrace_clear): Update.
8201         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8202         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8203         type.
8204         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8205         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8206         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8207         * gdbarch.c, gdbarch.h: Rebuild.
8208         * gdbarch.sh (core_pid_to_str): Change return type.
8209         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8210         return type.
8211         (windows_nat_target::pid_to_str): Change return type.
8212         (windows_delete_thread): Update.
8213         (windows_nat_target::attach): Update.
8214         (windows_nat_target::files_info): Update.
8215         * target-delegates.c: Rebuild.
8216         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8217         return type.
8218         (sol_thread_target::pid_to_str): Change return type.
8219         * remote.c (class remote_target) <pid_to_str>: Change return
8220         type.
8221         (remote_target::pid_to_str): Change return type.
8222         (extended_remote_target::attach, remote_target::remote_stop_ns)
8223         (remote_target::remote_notif_remove_queued_reply)
8224         (remote_target::push_stop_reply, remote_target::disable_btrace):
8225         Update.
8226         (extended_remote_target::attach): Update.
8227         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8228         type.
8229         (gdbsim_target::pid_to_str): Change return type.
8230         * ravenscar-thread.c (struct ravenscar_thread_target)
8231         <pid_to_str>: Change return type.
8232         (ravenscar_thread_target::pid_to_str): Change return type.
8233         * procfs.c (class procfs_target) <pid_to_str>: Change return
8234         type.
8235         (procfs_target::pid_to_str): Change return type.
8236         (procfs_target::attach): Update.
8237         (procfs_target::detach): Update.
8238         (procfs_target::fetch_registers): Update.
8239         (procfs_target::store_registers): Update.
8240         (procfs_target::wait): Update.
8241         (procfs_target::files_info): Update.
8242         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8243         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8244         return type.
8245         (nto_procfs_target::pid_to_str): Change return type.
8246         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8247         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8248         return type.
8249         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8250         (exit_lwp): Update.
8251         (attach_proc_task_lwp_callback, get_detach_signal)
8252         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8253         (linux_nat_target::resume, wait_lwp, stop_callback)
8254         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8255         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8256         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8257         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8258         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8259         type.
8260         (inf_ptrace_target::attach): Update.
8261         (inf_ptrace_target::files_info): Update.
8262         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8263         type.
8264         (go32_nat_target::pid_to_str): Change return type.
8265         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8266         (gnu_nat_target::wait): Update.
8267         (gnu_nat_target::wait): Update.
8268         (gnu_nat_target::resume): Update.
8269         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8270         (fbsd_nat_target::wait): Update.
8271         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8272         type.
8273         (darwin_nat_target::attach): Update.
8274         * corelow.c (class core_target) <pid_to_str>: Change return type.
8275         (core_target::pid_to_str): Change return type.
8276         * target.c (normal_pid_to_str): Change return type.
8277         (default_pid_to_str): Likewise.
8278         (target_pid_to_str): Change return type.
8279         (target_translate_tls_address): Update.
8280         (target_announce_detach): Update.
8281         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8282         return type.
8283         (bsd_uthread_target::pid_to_str): Change return type.
8284         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8285         type.
8286         (bsd_kvm_target::pid_to_str): Change return type.
8287         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8288         return type.
8289         (aix_thread_target::pid_to_str): Change return type.
8290         * target.h (struct target_ops) <pid_to_str>: Change return type.
8291         (target_pid_to_str, normal_pid_to_str): Likewise.
8292         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8293         type.
8294         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8295         type.
8296         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8297         return type.
8298         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8299         type.
8300         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8301         type.
8302         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8303         return type.
8304
8305 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8306
8307         * NEWS: Mention that the new default MI version is 3.  Mention
8308         changes to the output of commands and events that deal with
8309         multi-location breakpoints.
8310         * breakpoint.c: Include "mi/mi-out.h".
8311         (print_one_breakpoint): Change output syntax if using MI version
8312         >= 3.
8313         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8314         New.
8315         (mi_multi_location_breakpoint_output_fixed): New.
8316         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8317         (mi_cmd_fix_multi_location_breakpoint_output): New.
8318         (mi_multi_location_breakpoint_output_fixed): New.
8319         * mi/mi-cmds.c (mi_cmds): Register command
8320         -fix-multi-location-breakpoint-output.
8321         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8322         interpreter "mi".
8323
8324 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8325
8326         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8327         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8328         instantiate mi_ui_out based on interpreter name.
8329         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8330         * mi/mi-main.c (mi_load_progress): Likewise.
8331
8332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8333
8334         * NEWS: Combine separate "New targets" sections for 8.3.
8335
8336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8337
8338         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8339         (ppcfbsd_init_abi): Install gdbarch
8340         "fetch_tls_load_module_address" and "get_thread_local_address"
8341         methods.
8342
8343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8344
8345         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8346         (riscv_fbsd_init_abi): Install gdbarch
8347         "fetch_tls_load_module_address" and "get_thread_local_address"
8348         methods.
8349
8350 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8351
8352         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8353         (i386fbsd_init_abi): Install gdbarch
8354         "fetch_tls_load_module_address" and "get_thread_local_address"
8355         methods.
8356
8357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8358
8359         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8360         (amd64fbsd_init_abi): Install gdbarch
8361         "fetch_tls_load_module_address" and "get_thread_local_address"
8362         methods.
8363
8364 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8365
8366         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8367         (struct fbsd_pspace_data): New type.
8368         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8369         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8370         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8371         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8372         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8373
8374 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8375
8376         * gdbtypes.c (lookup_struct_elt): New function.
8377         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8378         * gdbtypes.h (struct struct_elt): New type.
8379         (lookup_struct_elt): New prototype.
8380
8381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8382
8383         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8384         remove disabled code block.
8385
8386 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8387
8388         * gdbarch.sh (get_thread_local_address): New method.
8389         * gdbarch.h, gdbarch.c: Regenerate.
8390         * target.c (target_translate_tls_address): Use
8391         gdbarch_get_thread_local_address if present instead of
8392         target::get_thread_local_address.
8393
8394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8395
8396         * target.h (target::get_thread_local_address): Update comment.
8397
8398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8399
8400         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8401         objfile->separate_debug_objfile_backlink if not NULL.
8402
8403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8404
8405         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8406         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8407         (amd64bsd_store_inferior_registers): Likewise.
8408         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8409         Enable segment base registers.
8410         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8411         PT_GETFSBASE and PT_GETGSBASE.
8412         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8413         PT_SETGSBASE.
8414         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8415         segment base registers.
8416         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8417
8418 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8419
8420         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8421         Update calls to i386_target_description to add 'segments'
8422         parameter.
8423         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8424         add segment base registers.
8425         * arch/i386.c (i386_create_target_description): Add 'segments'
8426         parameter to enable segment base registers.
8427         * arch/i386.h (i386_create_target_description): Likewise.
8428         * features/i386/32bit-segments.xml: New file.
8429         * features/i386/32bit-segments.c: Generate.
8430         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8431         call to i386_target_description to add 'segments' parameter.
8432         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8433         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8434         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8435         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8436         if feature is present.
8437         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8438         Add 'segments' parameter to call to i386_target_description.
8439         (i386_target_description): Add 'segments' parameter to enable
8440         segment base registers.
8441         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8442         to call to i386_target_description.
8443         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8444         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8445         Define I386_NUM_REGS.
8446         (i386_target_description): Add 'segments' parameter to enable
8447         segment base registers.
8448
8449 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8450
8451         PR/24325
8452         * source-cache.c: #undef open and close, to avoid unresolved
8453         externals during linking.
8454
8455 2019-03-12  Tom Tromey  <tromey@adacore.com>
8456
8457         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8458         const.  Add initializers.
8459         (_initialize_remote): Don't initialize ptid globals.
8460
8461 2019-03-12  Pedro Alves  <palves@redhat.com>
8462
8463         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8464
8465 2019-03-12  Pedro Alves  <palves@redhat.com>
8466
8467         * cp-name-parser.y (main): Remove unused 'len' variable.
8468
8469 2019-03-12  Tom Tromey  <tromey@adacore.com>
8470
8471         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8472         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8473
8474 2019-03-12  Tom Tromey  <tromey@adacore.com>
8475
8476         * linux-nat.c (iterate_over_lwps): Update.
8477         (stop_callback): Remove parameter.
8478         (stop_wait_callback, detach_callback, resume_set_callback)
8479         (select_singlestep_lwp_callback, set_ignore_sigint)
8480         (status_callback, resumed_callback, resume_clear_callback)
8481         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8482         data parameter.
8483         (linux_nat_target::detach, linux_nat_target::resume)
8484         (linux_stop_and_wait_all_lwps, select_event_lwp)
8485         (linux_nat_filter_event, linux_nat_wait_1)
8486         (linux_nat_target::kill, linux_nat_target::stop)
8487         (linux_nat_target::stop): Update.
8488         (linux_nat_resume_callback): Change type.
8489         (resume_stopped_resumed_lwps, count_events_callback)
8490         (select_event_lwp_callback): Likewise.
8491         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8492         * arm-linux-nat.c (struct update_registers_data): Remove.
8493         (update_registers_callback): Change type.
8494         (arm_linux_insert_hw_breakpoint1): Update.
8495         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8496         parameter.
8497         (x86_linux_dr_set_addr): Update.
8498         (x86_linux_dr_set_control): Update.
8499         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8500         (iterate_over_lwps): Use gdb::function_view.
8501         * nat/aarch64-linux-hw-point.c (struct
8502         aarch64_dr_update_callback_param): Remove.
8503         (debug_reg_change_callback): Change type.
8504         (aarch64_notify_debug_reg_change): Update.
8505         * s390-linux-nat.c (s390_refresh_per_info): Update.
8506
8507 2019-03-11  Tom Tromey  <tromey@adacore.com>
8508
8509         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8510         redundant assignment to "this_cu".
8511
8512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8513
8514         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8515
8516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8517
8518         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8519         from...
8520         (rank_one_type): ... this.
8521
8522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8523
8524         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8525         from...
8526         (rank_one_type): ... this.
8527
8528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8529
8530         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8531         from...
8532         (rank_one_type): ... this.
8533
8534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8535
8536         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8537         from...
8538         (rank_one_type): ... this.
8539
8540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8541
8542         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8543         from...
8544         (rank_one_type): ... this.
8545
8546 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8547
8548         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8549         from...
8550         (rank_one_type): ... this.
8551
8552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8553
8554         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8555         from...
8556         (rank_one_type): ... this.
8557
8558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8559
8560         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8561         from...
8562         (rank_one_type): ... this.
8563
8564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8565
8566         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8567         from...
8568         (rank_one_type): ... this.
8569
8570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8571
8572         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8573         from...
8574         (rank_one_type): ... this.
8575
8576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8577
8578         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8579         from...
8580         (rank_one_type): ... this.
8581
8582 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8583
8584         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8585         from...
8586         (rank_one_type): ... this.
8587
8588 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8589
8590         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8591         inferior-events' shows the example events.
8592
8593 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8594
8595         Support styling on native MS-Windows console
8596
8597         PR/24315
8598         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8599         on MS-Windows if $TERM is not defined.
8600
8601         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8602
8603         * posix-hdep.c (gdb_console_fputs):
8604         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8605         functions.
8606         * ui-file.h (gdb_console_fputs): Add prototype.
8607
8608         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8609         back to fputs only if the former returns zero.
8610
8611 2019-03-07  Tom Tromey  <tom@tromey.com>
8612
8613         * symmisc.c (print_symbol_bcache_statistics): Update.
8614         (print_objfile_statistics): Update.
8615         * symfile.c (allocate_symtab): Update.
8616         * stabsread.c: Don't include bcache.h.
8617         * psymtab.h (struct psymbol_bcache): Don't declare.
8618         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8619         (psymbol_bcache_init, psymbol_bcache_free)
8620         (psymbol_bcache_get_bcache): Don't declare.
8621         * psymtab.c (struct psymbol_bcache): Remove.
8622         (psymtab_storage::psymtab_storage): Update.
8623         (psymtab_storage::~psymtab_storage): Update.
8624         (psymbol_bcache_init, psymbol_bcache_free)
8625         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8626         (add_psymbol_to_bcache): Update.
8627         (allocate_psymtab): Update.
8628         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8629         macro_cache>: No longer pointers.
8630         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8631         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8632         * macrotab.c (macro_bcache): Update.
8633         * macroexp.c: Don't include bcache.h.
8634         * gdbtypes.c (check_types_worklist): Update.
8635         (types_deeply_equal): Remove TRY/CATCH.  Update.
8636         * elfread.c (elf_symtab_read): Update.
8637         * dwarf2read.c: Don't include bcache.h.
8638         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8639         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8640         (print_bcache_statistics, bcache_memory_used): Don't declare.
8641         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8642         methods.  Rename all data members.
8643         * bcache.c (struct bcache): Move to bcache.h.
8644         (bcache::expand_hash_table): Rename from expand_hash_table.
8645         (bcache): Remove.
8646         (bcache::insert): Rename from bcache_full.
8647         (bcache::compare): Rename from bcache_compare.
8648         (bcache_xmalloc): Remove.
8649         (bcache::~bcache): Rename from bcache_xfree.
8650         (bcache::print_statistics): Rename from print_bcache_statistics.
8651         (bcache::memory_used): Rename from bcache_memory_used.
8652
8653 2019-03-07  Pedro Alves  <palves@redhat.com>
8654
8655         * infrun.c (normal_stop): Also check for
8656         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8657
8658 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8659
8660         * f-lang.c (value_from_host_double): Moved to...
8661         * value.c (value_from_host_double): ...here.
8662         * value.h (value_from_host_double): Declare.
8663         * guile/scm-math.c (vlscm_convert_typed_number): Use
8664         value_from_host_double.
8665         (vlscm_convert_number): Likewise.
8666         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8667         * python/py-value.c (convert_value_from_python): Likewise.
8668
8669 2019-03-06  Tom Tromey  <tom@tromey.com>
8670
8671         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8672
8673 2019-03-06  Tom Tromey  <tom@tromey.com>
8674
8675         * utils.h (free_current_contents): Don't declare.
8676         * utils.c (free_current_contents): Remove.
8677
8678 2019-03-06  Tom Tromey  <tom@tromey.com>
8679
8680         * top.c (quit_force): Update.
8681         * main.c (captured_command_loop): Update.
8682         * common/new-op.c (operator new): Update.
8683         * common/common-exceptions.c (struct catcher)
8684         <save_cleanup_chain>: Remove member.
8685         (exceptions_state_mc_init): Update.
8686         (exception_try_scope_entry): Return nullptr.
8687         (exception_try_scope_exit, exception_rethrow)
8688         (throw_exception_sjlj, throw_exception_cxx): Update.
8689         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8690         (all_cleanups, do_cleanups, discard_cleanups)
8691         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8692         (restore_cleanups, restore_final_cleanups): Don't declare.
8693         (do_final_cleanups): Remove parameter.
8694         * common/cleanups.c (cleanup_chain, make_cleanup)
8695         (make_cleanup_dtor, all_cleanups, do_cleanups)
8696         (discard_my_cleanups, discard_cleanups)
8697         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8698         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8699         (null_cleanup): Remove.
8700         (do_final_cleanups): Remove parameter.
8701
8702 2019-03-06  Tom Tromey  <tom@tromey.com>
8703
8704         * remote.c (remote_target::remote_parse_stop_reply): Use
8705         unique_xmalloc_ptr.
8706
8707 2019-03-06  Tom Tromey  <tom@tromey.com>
8708
8709         * stabsread.c (struct stabs_field_info): Rename from field_info.
8710         <list, fnlist>: Add initializers.
8711         <obstack>: New member.
8712         (read_member_functions, read_struct_fields, read_baseclasses):
8713         Allocate on obstack.  Don't use cleanups.
8714         (read_one_struct_field, read_member_functions, read_struct_fields)
8715         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8716         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8717         (read_struct_type): Update.
8718
8719 2019-03-06  Tom Tromey  <tom@tromey.com>
8720
8721         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8722         * common/filestuff.h (make_cleanup_close): Don't declare.
8723         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8724         Remove.
8725
8726 2019-03-06  Tom Tromey  <tom@tromey.com>
8727
8728         * solib-aix.c: Use make_scope_exit.
8729
8730 2019-03-06  Tom Tromey  <tom@tromey.com>
8731
8732         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8733         Use make_scope_exit.
8734
8735 2019-03-06  Tom Tromey  <tom@tromey.com>
8736
8737         * solib-svr4.c (disable_probes_interface): Remove parameter.
8738         (svr4_handle_solib_event): Use make_scope_exit.
8739
8740 2019-03-06  Tom Tromey  <tom@tromey.com>
8741
8742         * remote.c (struct stop_reply_deleter): Remove.
8743         (stop_reply_up): Update.
8744         (struct stop_reply): Derive from notif_event.  Don't typedef.
8745         <regcache>: Now a std::vector.
8746         (stop_reply_xfree): Remove.
8747         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8748         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8749         (remote_target::discard_pending_stop_replies): Use delete.
8750         (remote_target::remote_parse_stop_reply): Update.
8751         (remote_target::process_stop_reply): Update.
8752         * remote-notif.h (struct notif_event): Add virtual destructor.
8753         Remove "dtr" member.
8754         (struct notif_client) <alloc_event>: Return a unique_ptr.
8755         (notif_event_xfree): Don't declare.
8756         (notif_event_up): New typedef.
8757         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8758         (notif_event_xfree, do_notif_event_xfree): Remove.
8759         (remote_notif_state_xfree): Update.
8760
8761 2019-03-06  Tom Tromey  <tom@tromey.com>
8762
8763         * infrun.c (displaced_step_clear_cleanup): Now a
8764         forward_scope_exit type.
8765         (displaced_step_prepare_throw): Update.
8766         (displaced_step_fixup): Update.
8767
8768 2019-03-06  Tom Tromey  <tom@tromey.com>
8769
8770         * inferior.h (class inferior): Update comment.
8771         * gdbthread.h (class thread_info): Update comment.
8772
8773 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8774             Tom Tromey  <tom@tromey.com>
8775
8776         * stabsread.h (struct stab_section_list): Remove.
8777         (coffstab_build_psymtabs): Update.
8778         * dbxread.c (symbuf_sections): Now a std::vector.
8779         (sect_idx): New global.
8780         (fill_symbuf): Update.
8781         (coffstab_build_psymtabs): Change type of stabsects parameter.
8782         Update.
8783         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8784         std::vector.
8785         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8786         (coff_locate_sections): Update.
8787         (coff_symfile_read): Remove cleanups.  Update.
8788         (init_stringtab): Add storage parameter.
8789         (free_stringtab, free_stringtab_cleanup): Remove.
8790         (init_lineno): Add storage parameter.
8791         (free_linetab, free_linetab_cleanup): Remove.
8792
8793 2019-03-06  Pedro Alves  <palves@redhat.com>
8794
8795         * linux-fork.c (fork_info::clobber_regs): Delete.
8796         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8797         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8798         comment.  Adjust.
8799         (scoped_switch_fork_info::scoped_switch_fork_info)
8800         (checkpoint_command, linux_fork_context): Adjust
8801         fork_save_infrun_state calls.
8802
8803 2019-03-06  Pedro Alves  <palves@redhat.com>
8804
8805         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8806         (inf_has_multiple_threads): Return 'bool' and rewrite using
8807         inferior_info::threads().
8808
8809 2019-03-06  Pedro Alves  <palves@redhat.com>
8810
8811         * linux-fork.c: Include <list>.
8812         (fork_list): Now a std::list instance.
8813         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8814         (forks_exist_p, find_last_fork): Adjust.
8815         (new_fork): Delete.
8816         (one_fork_p): New.
8817         (add_fork): Adjust.
8818         (free_fork): Delete, folded into fork_info::~fork_info().
8819         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8820         Adjust.
8821         (init_fork_list): Delete.
8822         (linux_fork_killall, linux_fork_mourn_inferior)
8823         (linux_fork_detach, info_checkpoints_command): Adjust.
8824         (_initialize_linux_fork): No longer call init_fork_list.
8825
8826 2019-03-06  Pedro Alves  <palves@redhat.com>
8827
8828         * linux-fork.c (new_fork): New, split out of ...
8829         (add_fork): ... this.  Return void.  Move "first fork" special
8830         case from here, to ...
8831         (checkpoint_command): ... here.
8832         * linux-linux.h (add_fork): Return void.
8833
8834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8835
8836         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8837
8838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8839             Chris January  <chris.january@arm.com>
8840             David Lecomber  <david.lecomber@arm.com>
8841
8842         * f-exp.y: New token, UNOP_INTRINSIC.
8843         (exp): New pattern using UNOP_INTRINSIC token.
8844         (f77_keywords): Add 'abs' keyword.
8845         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8846         (value_from_host_double): New function.
8847         (evaluate_subexp_f): Support UNOP_ABS.
8848
8849 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8850
8851         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8852         types.
8853
8854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8855
8856         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8857         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8858         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8859
8860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8861
8862         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8863
8864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8865             Chris January  <chris.january@arm.com>
8866
8867         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8868         * f-exp.y: Define 'KIND' token.
8869         (exp): New pattern for KIND expressions.
8870         (ptype): Handle types with a kind extension.
8871         (direct_abs_decl): Extend to spot kind extensions.
8872         (f77_keywords): Add 'kind' to the list.
8873         (push_kind_type): New function.
8874         (convert_to_kind_type): New function.
8875         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8876         * parse.c (operator_length_standard): Likewise.
8877         * parser-defs.h (enum type_pieces): Add tp_kind.
8878         * std-operator.def: Add UNOP_KIND.
8879
8880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * f-exp.y (f_parse): Set yydebug.
8883
8884 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8885
8886         * f-lang.c (evaluate_subexp_f): New function.
8887         (exp_descriptor_f): New global.
8888         (f_language_defn): Use exp_descriptor_f instead of
8889         exp_descriptor_standard.
8890
8891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * f-exp.y (struct token): Add comments.
8894         (dot_ops): Remove uppercase versions and the end marker.
8895         (f77_keywords): Likewise.
8896         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8897         entries in the dot_ops array are case insensitive, and use
8898         strncasecmp to compare strings.  Also some whitespace cleanup in
8899         this area.  Similar for the f77_keywords array, except entries in
8900         this list might be case sensitive.
8901
8902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * f-exp.y (struct f77_boolean_val): Add comments.
8905         (boolean_values): Remove uppercase versions, and end marker.
8906         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8907         and use strncasecmp to achieve case insensitivity.  Additionally,
8908         perform whitespace cleanup around this code.
8909
8910 2019-03-06  Tom Tromey  <tromey@adacore.com>
8911
8912         * remote-sim.c (gdbsim_target_open): Use result of
8913         gdb_argv::release.
8914
8915 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8916         Dirk Schubert  <dirk.schubert@arm.com>
8917         Chris January  <chris.january@arm.com>
8918
8919         * eval.c (evaluate_subexp_standard): Call Fortran argument
8920         wrapping logic.
8921         * f-lang.c (struct value): A value which can be passed into a
8922         Fortran function call.
8923         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8924         where appropriate.
8925         (struct type): Value ready for a Fortran function call.
8926         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8927         is needed.
8928         * f-lang.h (fortran_argument_convert): Declaration.
8929         (fortran_preserve_arg_pointer): Declaration.
8930         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8931
8932 2019-03-05  Tom Tromey  <tromey@adacore.com>
8933
8934         * python/py-prettyprint.c (print_string_repr): Remove #if.
8935         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8936
8937 2019-03-05  Tom Tromey  <tromey@adacore.com>
8938
8939         * target.c (the_dummy_target): Move later.  Change type to
8940         "dummy_target".
8941         (initialize_targets): Don't initialize the_dummy_target.
8942
8943 2019-03-05  Tom Tromey  <tromey@adacore.com>
8944
8945         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8946         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8947
8948 2019-03-05  Tom Tromey  <tromey@adacore.com>
8949
8950         * windows-nat.c (windows_nat_target::attach)
8951         (windows_nat_target::detach): Don't call gdb_flush.
8952         * valprint.c (generic_val_print, val_print, val_print_string):
8953         Don't call gdb_flush.
8954         * utils.c (defaulted_query): Don't call gdb_flush.
8955         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8956         * target.c (target_announce_detach): Don't call gdb_flush.
8957         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8958         * remote.c (extended_remote_target::attach): Don't call
8959         gdb_flush.
8960         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8961         * printcmd.c (do_examine): Don't call gdb_flush.
8962         (info_display_command): Don't call gdb_flush.
8963         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8964         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8965         * memattr.c (info_mem_command): Don't call gdb_flush.
8966         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8967         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8968         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8969         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8970         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8971         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8972         (gnu_nat_target::detach): Don't call gdb_flush.
8973         * f-valprint.c (f_val_print): Don't call gdb_flush.
8974         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8975         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8976         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8977         gdb_flush.
8978         * c-valprint.c (c_val_print): Don't call gdb_flush.
8979         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8980
8981 2019-03-05  Tom Tromey  <tromey@adacore.com>
8982
8983         * varobj.c (update_dynamic_varobj_children): Update.
8984         (install_default_visualizer): Use reset, not release.
8985         * value.c (set_internalvar): Update.
8986         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8987         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8988         ATTRIBUTE_UNUSED_RESULT.
8989
8990 2019-03-05  Tom Tromey  <tromey@adacore.com>
8991
8992         * remote.c (class scoped_remote_fd) <release>: Add
8993         ATTRIBUTE_UNUSED_RESULT.
8994
8995 2019-03-05  Tom Tromey  <tromey@adacore.com>
8996
8997         * macroexp.c (struct macro_buffer) <release>: Add
8998         ATTRIBUTE_UNUSED_RESULT.
8999
9000 2019-03-05  Tom Tromey  <tromey@adacore.com>
9001
9002         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9003         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9004         ATTRIBUTE_UNUSED_RESULT.
9005
9006 2019-03-05  Tom Tromey  <tromey@adacore.com>
9007
9008         * common/scoped_fd.h (class scoped_fd) <release>: Add
9009         ATTRIBUTE_UNUSED_RESULT.
9010
9011 2019-03-05  Tom Tromey  <tromey@adacore.com>
9012
9013         * parser-defs.h (struct parser_state) <release>: Add
9014         ATTRIBUTE_UNUSED_RESULT.
9015
9016 2019-03-05  Tom Tromey  <tromey@adacore.com>
9017
9018         * utils.h (class gdb_argv) <release>: Add
9019         ATTRIBUTE_UNUSED_RESULT.
9020         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9021
9022 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9023
9024         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9025         for-loop range, to avoid compiler warnings.
9026
9027         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9028         avoid compiler warnings about unused variables.
9029
9030         * NEWS: Mention end of support for native debugging on MS-Windows
9031         before XP.
9032
9033         PR gdb/24292
9034         * common/netstuff.c:
9035         * gdbserver/gdbreplay.c
9036         * gdbserver/remote-utils.c:
9037         * ser-tcp.c:
9038         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9039         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9040         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9041         'getaddrinfo' and 'freeaddrinfo' were not available before
9042         Windows XP, and mingw.org's MinGW headers by default define
9043         _WIN32_WINNT to 0x500.
9044
9045 2019-03-01  Gary Benson <gbenson@redhat.com>
9046
9047         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9048
9049 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9050             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9051
9052         PR gdb/8527
9053         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9054         set_sigint_trap, clear_sigint_trap.
9055
9056 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9057
9058         * target.c (target_detach): Clear the regcache and the
9059         frame cache.
9060
9061 2019-02-27  Pedro Alves  <palves@redhat.com>
9062
9063         * utils.c (set_screen_size): When we cap the height/width sizes,
9064         tweak the corresponding command variable to show "unlimited":
9065
9066 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9067             Pedro Alves  <palves@redhat.com>
9068
9069         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9070         before calling rl_set_screen_size.
9071
9072 2019-02-27  Tom Tromey  <tromey@adacore.com>
9073
9074         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9075         define.
9076         * python/py-value.c: Remove Python 2.4 workaround.
9077         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9078         workaround.
9079         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9080         Python 2.4 workaround.
9081         * python/python-internal.h: Remove Python 2.4 comment.
9082         (Py_ssize_t): Don't define.
9083         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9084         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9085         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9086         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9087         * python/python.c (do_start_initialization): Remove Python 2.4
9088         workaround.
9089         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9090         (print_children): Remove Python 2.4 workaround.
9091         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9092         workaround.
9093         (CHARBUFFERPROC_NAME): Remove.
9094         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9095         Python 2.4 workaround.
9096
9097 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9098
9099         * NEWS: Note minimum Python version.
9100
9101 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9102
9103         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9104         code from these functions.  Remove corresponding ifdefs.  Use
9105         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9106         Remove gotos and target of gotos.
9107         (infpy_search_memory): Likewise.
9108
9109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9110
9111         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9112         (hppa_gdbarch_init): Don't register deleted functions with
9113         gdbarch.
9114
9115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9116
9117         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9118         (h8300_unwind_sp): Delete.
9119         (h8300_dummy_id): Delete.
9120         (h8300_gdbarch_init): Don't register deleted functions with
9121         gdbarch.
9122
9123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9126         (ft32_unwind_pc): Delete.
9127         (ft32_unwind_sp): Delete.
9128         (ft32_gdbarch_init): Don't register deleted functions with
9129         gdbarch.
9130
9131 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9132
9133         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9134         (frv_unwind_pc): Delete.
9135         (frv_unwind_sp): Delete.
9136         (frv_gdbarch_init): Don't register deleted functions with
9137         gdbarch.
9138
9139 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9140
9141         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9142         (riscv_unwind_pc): Delete.
9143         (riscv_unwind_sp): Delete.
9144         (riscv_gdbarch_init): Don't register deleted functions with
9145         gdbarch.
9146
9147 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9148
9149         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9150         (csky_unwind_pc): Delete.
9151         (csky_unwind_sp): Delete.
9152         (csky_gdbarch_init): Don't register deleted functions with
9153         gdbarch.
9154
9155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9158         (cris_unwind_pc): Delete.
9159         (cris_unwind_sp): Delete.
9160         (cris_gdbarch_init): Don't register deleted functions with
9161         gdbarch.
9162
9163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9164
9165         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9166         (bfin_unwind_pc): Delete.
9167         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9168
9169 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9170
9171         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9172         (arm_unwind_pc): Delete.
9173         (arm_unwind_sp): Delete.
9174         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9175
9176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9177
9178         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9179         (arc_unwind_pc): Delete.
9180         (arc_unwind_sp): Delete.
9181         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9182
9183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9184
9185         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9186         (alpha_unwind_pc): Delete.
9187         (alpha_gdbarch_init): Don't register deleted functions with
9188         gdbarch.
9189
9190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9191
9192         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9193         (aarch64_unwind_pc): Delete.
9194         (aarch64_unwind_sp): Delete.
9195         (aarch64_gdbarch_init): Don't register deleted functions with
9196         gdbarch.
9197
9198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * gdbtypes.c (type_align): Don't consider static members when
9201         computing structure alignment.
9202
9203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9204
9205         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9206         return 0 for other types.
9207         * arch-utils.c (default_type_align): Always return 0.
9208         * gdbarch.h: Regenerate.
9209         * gdbarch.sh (type_align): Extend comment.
9210         * gdbtypes.c (type_align): Add additional comments, always call
9211         gdbarch_type_align before applying the default rules.
9212         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9213         generic code will then apply a suitable default.
9214         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9215         types, return 0 for other types.
9216
9217 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9218
9219         * NEWS: Create a new section for the next release branch.
9220         Rename the section of the current branch, now that it has
9221         been cut.
9222
9223 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9224
9225         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9226         * version.in: Bump version to 8.3.50.DATE-git.
9227
9228 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9229
9230         * aix-thread.c (ptid_cmp): Remove unused variable.
9231         (get_signaled_thread): Likewise.
9232         (store_regs_user_thread): Likewise.
9233         (store_regs_kernel_thread): Likewise.
9234         (fetch_regs_kernel_thread): Remove shadowed variable.
9235
9236 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * features/riscv/32bit-cpu.xml: Add register numbers.
9239         * features/riscv/32bit-fpu.c: Regenerate.
9240         * features/riscv/32bit-fpu.xml: Add register numbers.
9241         * features/riscv/64bit-cpu.xml: Add register numbers.
9242         * features/riscv/64bit-fpu.c: Regenerate.
9243         * features/riscv/64bit-fpu.xml: Add register numbers.
9244
9245 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9246
9247         * NEWS: Mention two argument form of gdb.Value constructor.
9248         * python/py-value.c (convert_buffer_and_type_to_value): New
9249         function.
9250         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9251         Add support for handling an optional second argument.  Call
9252         convert_buffer_and_type_to_value as appropriate.
9253         * python/python-internal.h (Py_buffer_deleter): New struct.
9254         (Py_buffer_up): New typedef.
9255
9256 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9257
9258         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9259         instead of releasing ownership.
9260
9261 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9262
9263         * dwarf2read.c (open_and_init_dwp_file): Call
9264         elf_numsections instead of bfd_count_sections to initialize
9265         dwp_file->num_sections.
9266
9267 2019-02-25  Tom Tromey  <tromey@adacore.com>
9268
9269         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9270
9271 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9272
9273         * gcore.in: Add '--readnever' option when invoking GDB.
9274
9275 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9276
9277         * MAINTAINERS: Update my email address.
9278
9279 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9280
9281         * build-id.c (build_id_to_debug_bfd_1): New function.
9282         (build_id_to_debug_bfd): Look for separate debug file in
9283         sysroot.
9284
9285 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * gdbarch.sh: Update the copyright year range that is placed into
9288         generated files.
9289
9290 2019-02-22  Keith Seitz  <keiths@redhat.com>
9291
9292         PR symtab/23853
9293         * linespec.c (create_sals_line_offset): Search for the default
9294         symtab's filename instead of its fullname.
9295
9296 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9297
9298         * NEWS: Update style defaults.
9299
9300 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9301
9302         * main.c (captured_main_1): Disable styling in batch mode.
9303
9304 2019-02-20  Tom Tromey  <tom@tromey.com>
9305
9306         * symtab.c (symtab_symbol_info): Fix typos.
9307
9308 2019-02-20  Tom Tromey  <tromey@adacore.com>
9309
9310         * findcmd.c (_initialize_mem_search): Use upper case for
9311         metasyntactic variables.
9312
9313 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9314
9315         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9316         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9317
9318 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9319
9320         * top.h (source_file_name): Change to std::string.
9321         * top.c (source_file_name): Likewise.
9322         (command_line_input): Adjust.
9323         * cli/cli-script.c (script_from_file): Adjust.
9324
9325 2019-02-19  Tom Tromey  <tromey@adacore.com>
9326
9327         * ravenscar-thread.c
9328         (ravenscar_thread_target::update_thread_list): Don't call
9329         ada_build_task_list.
9330         * ada-lang.h (ada_build_task_list): Don't declare.
9331         * ada-tasks.c (struct ada_tasks_inferior_data)
9332         <task_list_valid_p>: Now bool.
9333         (read_known_tasks, ada_task_list_changed)
9334         (ada_tasks_invalidate_inferior_data): Update.
9335         (read_known_tasks_array): Return bool.
9336         (read_known_tasks_list): Likewise.
9337         (read_known_tasks): Return void.
9338         (ada_build_task_list): Now static.
9339
9340 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9341
9342         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9343         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9344
9345 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9346
9347         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9348         variant for ada_tasks_pspace_data_handle and
9349         ada_tasks_inferior_data_handle.
9350         (ada_tasks_pspace_data_cleanup): New function.
9351         (ada_tasks_inferior_data_cleanup): New function.
9352
9353 2019-02-17  Tom Tromey  <tom@tromey.com>
9354
9355         * macrotab.h (macro_source_fullname): Return a std::string.
9356         * macrotab.c (macro_include, check_for_redefinition)
9357         (macro_undef, macro_lookup_definition, foreach_macro)
9358         (foreach_macro_in_scope): Update.
9359         (macro_source_fullname): Return a std::string.
9360         * macrocmd.c (show_pp_source_pos): Update.
9361
9362 2019-02-17  Tom Tromey  <tom@tromey.com>
9363
9364         * macrocmd.c (show_pp_source_pos): Style the file names.
9365
9366 2019-02-17  Tom Tromey  <tom@tromey.com>
9367
9368         PR tui/24197:
9369         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9370
9371 2019-02-17  Tom Tromey  <tom@tromey.com>
9372
9373         * ada-lang.c (user_select_syms): Use filtered printing.
9374         * utils.c (wrap_style): New global.
9375         (desired_style): Remove.
9376         (emit_style_escape): Add stream parameter.
9377         (set_output_style, reset_terminal_style, prompt_for_continue):
9378         Update.
9379         (flush_wrap_buffer): Only flush gdb_stdout.
9380         (wrap_here): Set wrap_style.
9381         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9382         treat escape sequences as a character.  Change when wrap buffer is
9383         flushed.
9384         (fputs_styled): Do not set the output style when the default is
9385         requested.
9386         * ui-style.h (struct ui_file_style) <is_default>: New method.
9387         * source.c (print_source_lines_base): Emit escape sequences in one
9388         piece.
9389
9390 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9391
9392         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9393         integers and enumeration types.
9394
9395 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9396
9397         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9398         instead of lookup_symbol_in_language
9399         (do_exact_match): New function.
9400         (ada_get_symbol_name_matcher): Return do_exact_match when
9401         doing a verbatim match.
9402
9403 2019-02-15  Tom Tromey  <tromey@adacore.com>
9404
9405         * ravenscar-thread.c (ravenscar_thread_target::resume)
9406         (ravenscar_thread_target::wait): Special case wildcard requests.
9407
9408 2019-02-15  Tom Tromey  <tromey@adacore.com>
9409
9410         * ravenscar-thread.c (base_ptid): Remove.
9411         (struct ravenscar_thread_target) <close>: New method.
9412         <m_base_ptid>: New member.
9413         <update_inferior_ptid, active_task, task_is_currently_active,
9414         runtime_initialized>: Declare methods.
9415         <ravenscar_thread_target>: Add constructor.
9416         (ravenscar_thread_target::task_is_currently_active)
9417         (ravenscar_thread_target::update_inferior_ptid)
9418         (ravenscar_runtime_initialized): Rename.  Now methods.
9419         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9420         (ravenscar_thread_target::update_thread_list): Update.
9421         (ravenscar_thread_target::active_task): Now method.
9422         (ravenscar_thread_target::store_registers)
9423         (ravenscar_thread_target::prepare_to_store)
9424         (ravenscar_thread_target::prepare_to_store)
9425         (ravenscar_thread_target::mourn_inferior): Update.
9426         (ravenscar_inferior_created): Use "new" to create target.
9427         (ravenscar_thread_target::get_ada_task_ptid): Update.
9428         (_initialize_ravenscar): Don't initialize base_ptid.
9429         (ravenscar_ops): Remove global.
9430
9431 2019-02-15  Tom Tromey  <tromey@adacore.com>
9432
9433         * target.h (push_target): Declare new overload.
9434         * target.c (push_target): New overload, taking an rvalue reference.
9435         * remote.c (remote_target::open_1): Use push_target overload.
9436         * corelow.c (core_target_open): Use push_target overload.
9437
9438 2019-02-15  Tom Tromey  <tromey@adacore.com>
9439
9440         * ravenscar-thread.c (is_ravenscar_task)
9441         (ravenscar_task_is_currently_active): Return bool.
9442         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9443         (_initialize_ravenscar): Remove "(void)".
9444         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9445         Return bool.
9446
9447 2019-02-15  Tom Tromey  <tromey@adacore.com>
9448
9449         * ravenscar-thread.c (ravenscar_runtime_initializer)
9450         (has_ravenscar_runtime, get_running_thread_id)
9451         (ravenscar_thread_target::resume): Fix indentation.
9452
9453 2019-02-15  Tom Tromey  <tromey@adacore.com>
9454
9455         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9456         from ravenscar_arch_ops.
9457         (sparc_ravenscar_ops::fetch_registers)
9458         (sparc_ravenscar_ops::store_registers): Now methods.
9459         (sparc_ravenscar_prepare_to_store): Remove.
9460         (sparc_ravenscar_ops): Redefine.
9461         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9462         methods and destructor.  Remove members.
9463         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9464         (ravenscar_thread_target::store_registers)
9465         (ravenscar_thread_target::prepare_to_store): Update.
9466         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9467         Remove.
9468         (struct ppc_ravenscar_powerpc_ops): Derive from
9469         ravenscar_arch_ops.
9470         (ppc_ravenscar_powerpc_ops::fetch_registers)
9471         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9472         (ppc_ravenscar_powerpc_ops): Redefine.
9473         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9474         (ppc_ravenscar_e500_ops::fetch_registers)
9475         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9476         (ppc_ravenscar_e500_ops): Redefine.
9477         * aarch64-ravenscar-thread.c
9478         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9479         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9480         (aarch64_ravenscar_fetch_registers)
9481         (aarch64_ravenscar_store_registers): Now methods.
9482         (aarch64_ravenscar_ops): Redefine.
9483
9484 2019-02-15  Tom Tromey  <tromey@adacore.com>
9485
9486         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9487         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9488         (ravenscar_thread_target::stopped_by_watchpoint)
9489         (ravenscar_thread_target::stopped_data_address)
9490         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9491
9492 2019-02-15  Tom Tromey  <tromey@adacore.com>
9493
9494         * ravenscar-thread.c: Fix some typos.
9495
9496 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9497             Tom Tromey  <tromey@adacore.com>
9498
9499         * ada-lang.c (ada_exception_sal): Change addr_string to a
9500         std::string.
9501         (create_ada_exception_catchpoint): Update.
9502
9503 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9504             Tom Tromey  <tromey@adacore.com>
9505
9506         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9507         (bp_location_ops): Remove.
9508         (base_breakpoint_allocate_location): Update.
9509         (free_bp_location): Update.
9510         * ada-lang.c (class ada_catchpoint_location)
9511         <ada_catchpoint_location>: Remove ops parameter.
9512         (ada_catchpoint_location_dtor): Remove.
9513         (ada_catchpoint_location_ops): Remove.
9514         (allocate_location_exception): Update.
9515         * breakpoint.h (struct bp_location_ops): Remove.
9516         (class bp_location) <bp_location>: Remove bp_location_ops
9517         parameter.
9518         <~bp_location>: Add destructor.
9519         <ops>: Remove.
9520
9521 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9522             Pedro Alves  <palves@redhat.com>
9523
9524         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9525         'PATH_MAX'.
9526
9527 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9528             Samuel Thibault  <samuel.thibault@gnu.org>
9529             Thomas Schwinge  <thomas@codesourcery.com>
9530
9531         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9532         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9533
9534 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9535
9536         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9537         (check_empty): Use "const char *".
9538
9539         * gnu-nat.c (gnu_nat_target::detach): Instead of
9540         'detach_inferior (pid)' call
9541         'detach_inferior (find_inferior_pid (pid))'.
9542
9543         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9544         'nat/fork-inferior.o'.
9545         * gnu-nat.c: #include "nat/fork-inferior.h".
9546
9547         * gnu-nat.c (gnu_nat_target::detach): Instead of
9548         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9549         * gnu-nat.h: #include "inf-child.h".
9550         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9551         'i386_gnu_nat_target::fetch_registers'.
9552         (gnu_store_registers): Rename/move to
9553         'i386_gnu_nat_target::store_registers'.
9554
9555         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9556         * gnu-nat.h (mach_thread_info): New function.
9557         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9558
9559         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9560
9561 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9562
9563         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9564
9565 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9566
9567         * windows-nat.c (windows_add_thread): Add new parameter
9568         "main_thread_p" with default value set to false.  Update
9569         function documentation as well as all callers.
9570         (windows_delete_thread): Likewise.
9571         (fake_create_process): Update call to windows_add_thread.
9572         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9573         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9574         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9575         call to windows_delete_thread.
9576
9577 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9578
9579         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9580
9581 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9582
9583         * symfile.c (find_separate_debug_file): Use canonical path of
9584         sysroot with child_path instead of gdb_sysroot if it is valid.
9585
9586 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9587
9588         * symfile.c (find_separate_debug_file): Use child_path to
9589         determine if an object file is under a sysroot.
9590
9591 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9592
9593         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9594         unittests/child-path-selftests.c.
9595         * common/pathstuff.c (child_path): New function.
9596         * common/pathstuff.h (child_path): New prototype.
9597         * unittests/child-path-selftests.c: New file.
9598
9599 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9600
9601         * symfile.c (find_separate_debug_file): Look for separate debug
9602         files in debug directories under the sysroot.
9603
9604 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9605
9606         * symtab.h (struct minimal_symbol data_p): New const method.
9607         (struct minimal_symbol text_p): Likewise.
9608         * symtab.c (output_source_filename): Use file name style
9609         to print file name.
9610         (print_symbol_info): Likewise.
9611         (print_msymbol_info): Use address style to print addresses.
9612         Use function name style to print executable text symbols.
9613         (expand_symtab_containing_pc): Use data_p.
9614         (find_pc_sect_compunit_symtab): Likewise.
9615
9616 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9617
9618         * breakpoint.c (describe_other_breakpoints): Use address style
9619         to print addresses.
9620         (say_where): Likewise.
9621
9622 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9623
9624         * ada-typeprint.c (print_func_type): Print function name
9625         style to print function name.
9626         * c-typeprint.c (c_print_type_1): Likewise.
9627
9628 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9629
9630         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9631         for execve.
9632
9633 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9634
9635         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9636         type_stack.
9637
9638 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9639
9640         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9641         TYPE_CODE_REF types.
9642
9643 2019-02-08  Jim Wilson  <jimw@sifive.com>
9644
9645         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9646         (riscv_linux_fregset): New.
9647         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9648
9649 2019-02-07  Tom Tromey  <tom@tromey.com>
9650
9651         * thread.c (thread_cancel_execution_command): Update.
9652         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9653         methods.
9654         (struct thread_fsm_ops): Remove.
9655         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9656         (thread_fsm_should_stop, thread_fsm_return_value)
9657         (thread_fsm_set_finished, thread_fsm_finished_p)
9658         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9659         Don't declare.
9660         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9661         * infrun.c (clear_proceed_status_thread)
9662         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9663         (print_stop_event): Update.
9664         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9665         Add constructor.
9666         (step_command_fsm_ops): Remove.
9667         (new_step_command_fsm): Remove.
9668         (step_1): Update.
9669         (step_command_fsm::should_stop): Rename from
9670         step_command_fsm_should_stop.
9671         (step_command_fsm::clean_up): Rename from
9672         step_command_fsm_clean_up.
9673         (step_command_fsm::do_async_reply_reason): Rename from
9674         step_command_fsm_async_reply_reason.
9675         (struct until_next_fsm): Inherit from thread_fsm.  Add
9676         constructor.
9677         (until_next_fsm_ops): Remove.
9678         (new_until_next_fsm): Remove.
9679         (until_next_fsm::should_stop): Rename from
9680         until_next_fsm_should_stop.
9681         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9682         (until_next_fsm::do_async_reply_reason): Rename from
9683         until_next_fsm_async_reply_reason.
9684         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9685         constructor.  Change type of breakpoint.
9686         (finish_command_fsm_ops): Remove.
9687         (new_finish_command_fsm): Remove.
9688         (finish_command_fsm::should_stop): Rename from
9689         finish_command_fsm_should_stop.
9690         (finish_command_fsm::clean_up): Rename from
9691         finish_command_fsm_clean_up.
9692         (finish_command_fsm::return_value): Rename from
9693         finish_command_fsm_return_value.
9694         (finish_command_fsm::do_async_reply_reason): Rename from
9695         finish_command_fsm_async_reply_reason.
9696         (finish_command): Update.
9697         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9698         Add constructor.
9699         (call_thread_fsm_ops): Remove.
9700         (call_thread_fsm::call_thread_fsm): Rename from
9701         new_call_thread_fsm.
9702         (call_thread_fsm::should_stop): Rename from
9703         call_thread_fsm_should_stop.
9704         (call_thread_fsm::should_notify_stop): Rename from
9705         call_thread_fsm_should_notify_stop.
9706         (run_inferior_call, call_function_by_hand_dummy): Update.
9707         * cli/cli-interp.c (should_print_stop_to_console): Update.
9708         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9709         Add constructor.  Change type of location_breakpoint,
9710         caller_breakpoint.
9711         (until_break_fsm_ops): Remove.
9712         (new_until_break_fsm): Remove.
9713         (until_break_fsm::should_stop): Rename from
9714         until_break_fsm_should_stop.
9715         (until_break_fsm::clean_up): Rename from
9716         until_break_fsm_clean_up.
9717         (until_break_fsm::do_async_reply_reason): Rename from
9718         until_break_fsm_async_reply_reason.
9719         (until_break_command): Update.
9720         * thread-fsm.c: Remove.
9721         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9722
9723 2019-02-07  Tom Tromey  <tom@tromey.com>
9724
9725         * yy-remap.h: Add include guard.
9726         * xtensa-tdep.h: Add include guard.
9727         * xcoffread.h: Rename include guard.
9728         * varobj-iter.h: Add include guard.
9729         * tui/tui.h: Rename include guard.
9730         * tui/tui-winsource.h: Rename include guard.
9731         * tui/tui-wingeneral.h: Rename include guard.
9732         * tui/tui-windata.h: Rename include guard.
9733         * tui/tui-win.h: Rename include guard.
9734         * tui/tui-stack.h: Rename include guard.
9735         * tui/tui-source.h: Rename include guard.
9736         * tui/tui-regs.h: Rename include guard.
9737         * tui/tui-out.h: Rename include guard.
9738         * tui/tui-layout.h: Rename include guard.
9739         * tui/tui-io.h: Rename include guard.
9740         * tui/tui-hooks.h: Rename include guard.
9741         * tui/tui-file.h: Rename include guard.
9742         * tui/tui-disasm.h: Rename include guard.
9743         * tui/tui-data.h: Rename include guard.
9744         * tui/tui-command.h: Rename include guard.
9745         * tic6x-tdep.h: Add include guard.
9746         * target/waitstatus.h: Rename include guard.
9747         * target/wait.h: Rename include guard.
9748         * target/target.h: Rename include guard.
9749         * target/resume.h: Rename include guard.
9750         * target-float.h: Rename include guard.
9751         * stabsread.h: Add include guard.
9752         * rs6000-tdep.h: Add include guard.
9753         * riscv-fbsd-tdep.h: Add include guard.
9754         * regformats/regdef.h: Rename include guard.
9755         * record.h: Rename include guard.
9756         * python/python.h: Rename include guard.
9757         * python/python-internal.h: Rename include guard.
9758         * python/py-stopevent.h: Rename include guard.
9759         * python/py-ref.h: Rename include guard.
9760         * python/py-record.h: Rename include guard.
9761         * python/py-record-full.h: Rename include guard.
9762         * python/py-record-btrace.h: Rename include guard.
9763         * python/py-instruction.h: Rename include guard.
9764         * python/py-events.h: Rename include guard.
9765         * python/py-event.h: Rename include guard.
9766         * procfs.h: Add include guard.
9767         * proc-utils.h: Add include guard.
9768         * p-lang.h: Add include guard.
9769         * or1k-tdep.h: Rename include guard.
9770         * observable.h: Rename include guard.
9771         * nto-tdep.h: Rename include guard.
9772         * nat/x86-linux.h: Rename include guard.
9773         * nat/x86-linux-dregs.h: Rename include guard.
9774         * nat/x86-gcc-cpuid.h: Add include guard.
9775         * nat/x86-dregs.h: Rename include guard.
9776         * nat/x86-cpuid.h: Rename include guard.
9777         * nat/ppc-linux.h: Rename include guard.
9778         * nat/mips-linux-watch.h: Rename include guard.
9779         * nat/linux-waitpid.h: Rename include guard.
9780         * nat/linux-ptrace.h: Rename include guard.
9781         * nat/linux-procfs.h: Rename include guard.
9782         * nat/linux-osdata.h: Rename include guard.
9783         * nat/linux-nat.h: Rename include guard.
9784         * nat/linux-namespaces.h: Rename include guard.
9785         * nat/linux-btrace.h: Rename include guard.
9786         * nat/glibc_thread_db.h: Rename include guard.
9787         * nat/gdb_thread_db.h: Rename include guard.
9788         * nat/gdb_ptrace.h: Rename include guard.
9789         * nat/fork-inferior.h: Rename include guard.
9790         * nat/amd64-linux-siginfo.h: Rename include guard.
9791         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9792         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9793         * nat/aarch64-linux.h: Rename include guard.
9794         * nat/aarch64-linux-hw-point.h: Rename include guard.
9795         * mn10300-tdep.h: Add include guard.
9796         * mips-linux-tdep.h: Add include guard.
9797         * mi/mi-parse.h: Rename include guard.
9798         * mi/mi-out.h: Rename include guard.
9799         * mi/mi-main.h: Rename include guard.
9800         * mi/mi-interp.h: Rename include guard.
9801         * mi/mi-getopt.h: Rename include guard.
9802         * mi/mi-console.h: Rename include guard.
9803         * mi/mi-common.h: Rename include guard.
9804         * mi/mi-cmds.h: Rename include guard.
9805         * mi/mi-cmd-break.h: Rename include guard.
9806         * m2-lang.h: Add include guard.
9807         * location.h: Rename include guard.
9808         * linux-record.h: Rename include guard.
9809         * linux-nat.h: Add include guard.
9810         * linux-fork.h: Add include guard.
9811         * i386-darwin-tdep.h: Rename include guard.
9812         * hppa-linux-offsets.h: Add include guard.
9813         * guile/guile.h: Rename include guard.
9814         * guile/guile-internal.h: Rename include guard.
9815         * gnu-nat.h: Rename include guard.
9816         * gdb-stabs.h: Rename include guard.
9817         * frv-tdep.h: Add include guard.
9818         * f-lang.h: Add include guard.
9819         * event-loop.h: Add include guard.
9820         * darwin-nat.h: Rename include guard.
9821         * cp-abi.h: Rename include guard.
9822         * config/sparc/nm-sol2.h: Rename include guard.
9823         * config/nm-nto.h: Rename include guard.
9824         * config/nm-linux.h: Add include guard.
9825         * config/i386/nm-i386gnu.h: Rename include guard.
9826         * config/djgpp/nl_types.h: Rename include guard.
9827         * config/djgpp/langinfo.h: Rename include guard.
9828         * compile/gcc-cp-plugin.h: Add include guard.
9829         * compile/gcc-c-plugin.h: Add include guard.
9830         * compile/compile.h: Rename include guard.
9831         * compile/compile-object-run.h: Rename include guard.
9832         * compile/compile-object-load.h: Rename include guard.
9833         * compile/compile-internal.h: Rename include guard.
9834         * compile/compile-cplus.h: Rename include guard.
9835         * compile/compile-c.h: Rename include guard.
9836         * common/xml-utils.h: Rename include guard.
9837         * common/x86-xstate.h: Rename include guard.
9838         * common/version.h: Rename include guard.
9839         * common/vec.h: Rename include guard.
9840         * common/tdesc.h: Rename include guard.
9841         * common/selftest.h: Rename include guard.
9842         * common/scoped_restore.h: Rename include guard.
9843         * common/scoped_mmap.h: Rename include guard.
9844         * common/scoped_fd.h: Rename include guard.
9845         * common/safe-iterator.h: Rename include guard.
9846         * common/run-time-clock.h: Rename include guard.
9847         * common/refcounted-object.h: Rename include guard.
9848         * common/queue.h: Rename include guard.
9849         * common/ptid.h: Rename include guard.
9850         * common/print-utils.h: Rename include guard.
9851         * common/preprocessor.h: Rename include guard.
9852         * common/pathstuff.h: Rename include guard.
9853         * common/observable.h: Rename include guard.
9854         * common/netstuff.h: Rename include guard.
9855         * common/job-control.h: Rename include guard.
9856         * common/host-defs.h: Rename include guard.
9857         * common/gdb_wait.h: Rename include guard.
9858         * common/gdb_vecs.h: Rename include guard.
9859         * common/gdb_unlinker.h: Rename include guard.
9860         * common/gdb_unique_ptr.h: Rename include guard.
9861         * common/gdb_tilde_expand.h: Rename include guard.
9862         * common/gdb_sys_time.h: Rename include guard.
9863         * common/gdb_string_view.h: Rename include guard.
9864         * common/gdb_splay_tree.h: Rename include guard.
9865         * common/gdb_setjmp.h: Rename include guard.
9866         * common/gdb_ref_ptr.h: Rename include guard.
9867         * common/gdb_optional.h: Rename include guard.
9868         * common/gdb_locale.h: Rename include guard.
9869         * common/gdb_assert.h: Rename include guard.
9870         * common/filtered-iterator.h: Rename include guard.
9871         * common/filestuff.h: Rename include guard.
9872         * common/fileio.h: Rename include guard.
9873         * common/environ.h: Rename include guard.
9874         * common/common-utils.h: Rename include guard.
9875         * common/common-types.h: Rename include guard.
9876         * common/common-regcache.h: Rename include guard.
9877         * common/common-inferior.h: Rename include guard.
9878         * common/common-gdbthread.h: Rename include guard.
9879         * common/common-exceptions.h: Rename include guard.
9880         * common/common-defs.h: Rename include guard.
9881         * common/common-debug.h: Rename include guard.
9882         * common/cleanups.h: Rename include guard.
9883         * common/buffer.h: Rename include guard.
9884         * common/btrace-common.h: Rename include guard.
9885         * common/break-common.h: Rename include guard.
9886         * cli/cli-utils.h: Rename include guard.
9887         * cli/cli-style.h: Rename include guard.
9888         * cli/cli-setshow.h: Rename include guard.
9889         * cli/cli-script.h: Rename include guard.
9890         * cli/cli-interp.h: Rename include guard.
9891         * cli/cli-decode.h: Rename include guard.
9892         * cli/cli-cmds.h: Rename include guard.
9893         * charset-list.h: Add include guard.
9894         * buildsym-legacy.h: Rename include guard.
9895         * bfin-tdep.h: Add include guard.
9896         * ax.h: Rename include guard.
9897         * arm-linux-tdep.h: Add include guard.
9898         * arm-fbsd-tdep.h: Add include guard.
9899         * arch/xtensa.h: Rename include guard.
9900         * arch/tic6x.h: Add include guard.
9901         * arch/i386.h: Add include guard.
9902         * arch/arm.h: Rename include guard.
9903         * arch/arm-linux.h: Rename include guard.
9904         * arch/arm-get-next-pcs.h: Rename include guard.
9905         * arch/amd64.h: Add include guard.
9906         * arch/aarch64-insn.h: Rename include guard.
9907         * arch-utils.h: Rename include guard.
9908         * annotate.h: Add include guard.
9909         * amd64-darwin-tdep.h: Rename include guard.
9910         * aarch64-linux-tdep.h: Add include guard.
9911         * aarch64-fbsd-tdep.h: Add include guard.
9912         * aarch32-linux-nat.h: Add include guard.
9913
9914 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9915
9916         * macrotab.c (macro_define_internal): New function that
9917         factorizes macro_define_object_internal and macro_define_function
9918         code.
9919         (macro_define_object_internal): Use macro_define_internal.
9920         (macro_define_function): Likewise.
9921
9922 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9923
9924         * macrocmd.c (extract_identifier): Return
9925         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9926         callers.
9927
9928 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9929
9930         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9931
9932 2019-02-05  Tom Tromey  <tom@tromey.com>
9933
9934         * target.c (target_stack::unpush): Move assertion earlier.
9935
9936 2019-01-30  Tom Tromey  <tom@tromey.com>
9937
9938         PR python/23615:
9939         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9940         (gdbpy_parse_and_eval): Likewise.
9941         * python/python-internal.h (gdbpy_allow_threads): New class.
9942
9943 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9944
9945         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9946         (aarch64_fbsd_fpregmap): Move earlier.
9947         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9948         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9949         instead of individual calls to trad_frame_set_reg_addr.
9950         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9951         earlier.
9952         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9953         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9954         instead of individual calls to trad_frame_set_reg_addr.
9955
9956 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9957
9958         * CONTRIBUTE: Replace contribution list with wiki link.
9959
9960 2019-01-25  Tom Tromey  <tom@tromey.com>
9961
9962         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9963
9964 2019-01-25  Tom Tromey  <tom@tromey.com>
9965
9966         * xtensa-linux-nat.c: Fix common/ includes.
9967         * xml-support.h: Fix common/ includes.
9968         * xml-support.c: Fix common/ includes.
9969         * x86-linux-nat.c: Fix common/ includes.
9970         * windows-nat.c: Fix common/ includes.
9971         * varobj.h: Fix common/ includes.
9972         * varobj.c: Fix common/ includes.
9973         * value.c: Fix common/ includes.
9974         * valops.c: Fix common/ includes.
9975         * utils.c: Fix common/ includes.
9976         * unittests/xml-utils-selftests.c: Fix common/ includes.
9977         * unittests/utils-selftests.c: Fix common/ includes.
9978         * unittests/unpack-selftests.c: Fix common/ includes.
9979         * unittests/tracepoint-selftests.c: Fix common/ includes.
9980         * unittests/style-selftests.c: Fix common/ includes.
9981         * unittests/string_view-selftests.c: Fix common/ includes.
9982         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9983         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9984         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9985         * unittests/rsp-low-selftests.c: Fix common/ includes.
9986         * unittests/parse-connection-spec-selftests.c: Fix common/
9987         includes.
9988         * unittests/optional-selftests.c: Fix common/ includes.
9989         * unittests/offset-type-selftests.c: Fix common/ includes.
9990         * unittests/observable-selftests.c: Fix common/ includes.
9991         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9992         * unittests/memrange-selftests.c: Fix common/ includes.
9993         * unittests/memory-map-selftests.c: Fix common/ includes.
9994         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9995         * unittests/function-view-selftests.c: Fix common/ includes.
9996         * unittests/environ-selftests.c: Fix common/ includes.
9997         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9998         * unittests/common-utils-selftests.c: Fix common/ includes.
9999         * unittests/cli-utils-selftests.c: Fix common/ includes.
10000         * unittests/array-view-selftests.c: Fix common/ includes.
10001         * ui-file.c: Fix common/ includes.
10002         * tui/tui-io.c: Fix common/ includes.
10003         * tracepoint.h: Fix common/ includes.
10004         * tracepoint.c: Fix common/ includes.
10005         * tracefile-tfile.c: Fix common/ includes.
10006         * top.h: Fix common/ includes.
10007         * top.c: Fix common/ includes.
10008         * thread.c: Fix common/ includes.
10009         * target/waitstatus.h: Fix common/ includes.
10010         * target/waitstatus.c: Fix common/ includes.
10011         * target.h: Fix common/ includes.
10012         * target.c: Fix common/ includes.
10013         * target-memory.c: Fix common/ includes.
10014         * target-descriptions.c: Fix common/ includes.
10015         * symtab.h: Fix common/ includes.
10016         * symfile.c: Fix common/ includes.
10017         * stap-probe.c: Fix common/ includes.
10018         * spu-linux-nat.c: Fix common/ includes.
10019         * sparc-nat.c: Fix common/ includes.
10020         * source.c: Fix common/ includes.
10021         * solib.c: Fix common/ includes.
10022         * solib-target.c: Fix common/ includes.
10023         * ser-unix.c: Fix common/ includes.
10024         * ser-tcp.c: Fix common/ includes.
10025         * ser-pipe.c: Fix common/ includes.
10026         * ser-base.c: Fix common/ includes.
10027         * selftest-arch.c: Fix common/ includes.
10028         * s12z-tdep.c: Fix common/ includes.
10029         * rust-exp.y: Fix common/ includes.
10030         * rs6000-aix-tdep.c: Fix common/ includes.
10031         * riscv-tdep.c: Fix common/ includes.
10032         * remote.c: Fix common/ includes.
10033         * remote-notif.h: Fix common/ includes.
10034         * remote-fileio.h: Fix common/ includes.
10035         * remote-fileio.c: Fix common/ includes.
10036         * regcache.h: Fix common/ includes.
10037         * regcache.c: Fix common/ includes.
10038         * record-btrace.c: Fix common/ includes.
10039         * python/python.c: Fix common/ includes.
10040         * python/py-type.c: Fix common/ includes.
10041         * python/py-inferior.c: Fix common/ includes.
10042         * progspace.h: Fix common/ includes.
10043         * producer.c: Fix common/ includes.
10044         * procfs.c: Fix common/ includes.
10045         * proc-api.c: Fix common/ includes.
10046         * printcmd.c: Fix common/ includes.
10047         * ppc-linux-nat.c: Fix common/ includes.
10048         * parser-defs.h: Fix common/ includes.
10049         * osdata.c: Fix common/ includes.
10050         * obsd-nat.c: Fix common/ includes.
10051         * nat/x86-linux.c: Fix common/ includes.
10052         * nat/x86-linux-dregs.c: Fix common/ includes.
10053         * nat/x86-dregs.h: Fix common/ includes.
10054         * nat/x86-dregs.c: Fix common/ includes.
10055         * nat/ppc-linux.c: Fix common/ includes.
10056         * nat/mips-linux-watch.h: Fix common/ includes.
10057         * nat/mips-linux-watch.c: Fix common/ includes.
10058         * nat/linux-waitpid.c: Fix common/ includes.
10059         * nat/linux-ptrace.h: Fix common/ includes.
10060         * nat/linux-ptrace.c: Fix common/ includes.
10061         * nat/linux-procfs.c: Fix common/ includes.
10062         * nat/linux-personality.c: Fix common/ includes.
10063         * nat/linux-osdata.c: Fix common/ includes.
10064         * nat/linux-namespaces.c: Fix common/ includes.
10065         * nat/linux-btrace.h: Fix common/ includes.
10066         * nat/linux-btrace.c: Fix common/ includes.
10067         * nat/fork-inferior.c: Fix common/ includes.
10068         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10069         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10070         * nat/aarch64-linux.c: Fix common/ includes.
10071         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10072         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10073         * namespace.h: Fix common/ includes.
10074         * mips-linux-tdep.c: Fix common/ includes.
10075         * minsyms.c: Fix common/ includes.
10076         * mi/mi-parse.h: Fix common/ includes.
10077         * mi/mi-main.c: Fix common/ includes.
10078         * mi/mi-cmd-env.c: Fix common/ includes.
10079         * memrange.h: Fix common/ includes.
10080         * memattr.c: Fix common/ includes.
10081         * maint.h: Fix common/ includes.
10082         * maint.c: Fix common/ includes.
10083         * main.c: Fix common/ includes.
10084         * machoread.c: Fix common/ includes.
10085         * location.c: Fix common/ includes.
10086         * linux-thread-db.c: Fix common/ includes.
10087         * linux-nat.c: Fix common/ includes.
10088         * linux-fork.c: Fix common/ includes.
10089         * inline-frame.c: Fix common/ includes.
10090         * infrun.c: Fix common/ includes.
10091         * inflow.c: Fix common/ includes.
10092         * inferior.h: Fix common/ includes.
10093         * inferior.c: Fix common/ includes.
10094         * infcmd.c: Fix common/ includes.
10095         * inf-ptrace.c: Fix common/ includes.
10096         * inf-child.c: Fix common/ includes.
10097         * ia64-linux-nat.c: Fix common/ includes.
10098         * i387-tdep.c: Fix common/ includes.
10099         * i386-tdep.c: Fix common/ includes.
10100         * i386-linux-tdep.c: Fix common/ includes.
10101         * i386-linux-nat.c: Fix common/ includes.
10102         * i386-go32-tdep.c: Fix common/ includes.
10103         * i386-fbsd-tdep.c: Fix common/ includes.
10104         * i386-fbsd-nat.c: Fix common/ includes.
10105         * guile/scm-type.c: Fix common/ includes.
10106         * guile/guile.c: Fix common/ includes.
10107         * go32-nat.c: Fix common/ includes.
10108         * gnu-nat.c: Fix common/ includes.
10109         * gdbthread.h: Fix common/ includes.
10110         * gdbarch-selftests.c: Fix common/ includes.
10111         * gdb_usleep.c: Fix common/ includes.
10112         * gdb_select.h: Fix common/ includes.
10113         * gdb_bfd.c: Fix common/ includes.
10114         * gcore.c: Fix common/ includes.
10115         * fork-child.c: Fix common/ includes.
10116         * findvar.c: Fix common/ includes.
10117         * fbsd-nat.c: Fix common/ includes.
10118         * event-top.c: Fix common/ includes.
10119         * event-loop.c: Fix common/ includes.
10120         * dwarf2read.c: Fix common/ includes.
10121         * dwarf2loc.c: Fix common/ includes.
10122         * dwarf2-frame.c: Fix common/ includes.
10123         * dwarf-index-cache.c: Fix common/ includes.
10124         * dtrace-probe.c: Fix common/ includes.
10125         * disasm-selftests.c: Fix common/ includes.
10126         * defs.h: Fix common/ includes.
10127         * csky-tdep.c: Fix common/ includes.
10128         * cp-valprint.c: Fix common/ includes.
10129         * cp-support.h: Fix common/ includes.
10130         * cp-support.c: Fix common/ includes.
10131         * corelow.c: Fix common/ includes.
10132         * completer.h: Fix common/ includes.
10133         * completer.c: Fix common/ includes.
10134         * compile/compile.c: Fix common/ includes.
10135         * compile/compile-loc2c.c: Fix common/ includes.
10136         * compile/compile-cplus-types.c: Fix common/ includes.
10137         * compile/compile-cplus-symbols.c: Fix common/ includes.
10138         * command.h: Fix common/ includes.
10139         * cli/cli-dump.c: Fix common/ includes.
10140         * cli/cli-cmds.c: Fix common/ includes.
10141         * charset.c: Fix common/ includes.
10142         * build-id.c: Fix common/ includes.
10143         * btrace.h: Fix common/ includes.
10144         * btrace.c: Fix common/ includes.
10145         * breakpoint.h: Fix common/ includes.
10146         * breakpoint.c: Fix common/ includes.
10147         * ax.h:
10148         (enum agent_op): Fix common/ includes.
10149         * ax-general.c (struct aop_map): Fix common/ includes.
10150         * ax-gdb.c: Fix common/ includes.
10151         * auxv.c: Fix common/ includes.
10152         * auto-load.c: Fix common/ includes.
10153         * arm-tdep.c: Fix common/ includes.
10154         * arch/riscv.c: Fix common/ includes.
10155         * arch/ppc-linux-common.c: Fix common/ includes.
10156         * arch/i386.c: Fix common/ includes.
10157         * arch/arm.c: Fix common/ includes.
10158         * arch/arm-linux.c: Fix common/ includes.
10159         * arch/arm-get-next-pcs.c: Fix common/ includes.
10160         * arch/amd64.c: Fix common/ includes.
10161         * arch/aarch64.c: Fix common/ includes.
10162         * arch/aarch64-insn.c: Fix common/ includes.
10163         * arch-utils.c: Fix common/ includes.
10164         * amd64-windows-tdep.c: Fix common/ includes.
10165         * amd64-tdep.c: Fix common/ includes.
10166         * amd64-sol2-tdep.c: Fix common/ includes.
10167         * amd64-obsd-tdep.c: Fix common/ includes.
10168         * amd64-nbsd-tdep.c: Fix common/ includes.
10169         * amd64-linux-tdep.c: Fix common/ includes.
10170         * amd64-linux-nat.c: Fix common/ includes.
10171         * amd64-fbsd-tdep.c: Fix common/ includes.
10172         * amd64-fbsd-nat.c: Fix common/ includes.
10173         * amd64-dicos-tdep.c: Fix common/ includes.
10174         * amd64-darwin-tdep.c: Fix common/ includes.
10175         * agent.c: Fix common/ includes.
10176         * ada-lang.h: Fix common/ includes.
10177         * ada-lang.c: Fix common/ includes.
10178         * aarch64-tdep.c: Fix common/ includes.
10179
10180 2019-01-25  Tom Tromey  <tom@tromey.com>
10181
10182         * common/create-version.sh: Use common/version.h.
10183
10184 2019-01-24  Pedro Alves  <palves@redhat.com>
10185
10186         * infrun.c (signal_stop, signal_print, signal_program)
10187         (signal_catch, signal_pass): Now arrays instead of pointers.
10188         (update_signals_program_target, do_target_resume)
10189         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10190         * linux-nat.c (linux_nat_target::pass_signals)
10191         (linux_nat_target::create_inferior, linux_nat_target::attach):
10192         Adjust.
10193         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10194         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10195         * procfs.c (procfs_target::pass_signals): Adjust.
10196         * record-full.c (record_full_target::resume): Adjust.
10197         * remote.c (remote_target::pass_signals)
10198         (remote_target::program_signals): Adjust.
10199         * target-debug.h (target_debug_print_signals): Now takes a
10200         gdb::array_view as parameter.  Adjust.
10201         * target.h (target_ops) <pass_signals, program_signals>: Replace
10202         pointer and length parameters with gdb::array_view.
10203         (target_pass_signals, target_program_signals): Likewise.
10204         * target-delegates.c: Regenerate.
10205
10206 2019-01-24  Pedro Alves  <palves@redhat.com>
10207
10208         * common/forward-scope-exit.h
10209         (forward_scope_exit::forward_scope_exit): Pass arguments to
10210         m_bind_function directly, instead of creating a std::bind and
10211         copying that.
10212
10213 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10214
10215         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10216         for static members.
10217         (pass_in_v_vfp_candidate): Likewise.
10218
10219 2019-01-23  Tom Tromey  <tom@tromey.com>
10220             Pedro Alves  <palves@redhat.com>
10221
10222         * regcache.c (class regcache_invalidator): Remove.
10223         (regcache::raw_write): Use make_scope_exit.
10224
10225 2019-01-23  Tom Tromey  <tom@tromey.com>
10226
10227         * ui-out.h (class ui_out_emit_type): Update comment.
10228
10229 2019-01-23  Tom Tromey  <tom@tromey.com>
10230
10231         * infrun.c (fetch_inferior_event): Update comment.
10232
10233 2019-01-23  Tom Tromey  <tom@tromey.com>
10234             Pedro Alves  <palves@redhat.com>
10235
10236         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10237         parameter.
10238         (fetch_inferior_event): Use SCOPE_EXIT.
10239
10240
10241 2019-01-23  Tom Tromey  <tom@tromey.com>
10242             Pedro Alves  <palves@redhat.com>
10243
10244         * infrun.c (disable_thread_events): Delete.
10245         (stop_all_threads): Use SCOPE_EXIT.
10246
10247 2019-01-23  Tom Tromey  <tom@tromey.com>
10248             Pedro Alves  <palves@redhat.com>
10249
10250         * symfile.c: Include forward-scope-exit.h.
10251         (clear_symtab_users_cleanup): Replace forward declaration with
10252         a FORWARD_SCOPE_EXIT.
10253         (syms_from_objfile_1): Use the forward_scope_exit and
10254         gdb::optional instead of cleanup_function.
10255         (reread_symbols): Use the forward_scope_exit instead of
10256         cleanup_function.
10257         (clear_symtab_users_cleanup): Remove function.
10258
10259 2019-01-23  Tom Tromey  <tom@tromey.com>
10260             Pedro Alves  <palves@redhat.com>
10261
10262         * linux-nat.c: Include scope-exit.h.
10263         (cleanup_target_stop): Remove.
10264         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10265         SCOPE_EXIT.
10266
10267 2019-01-23  Tom Tromey  <tom@tromey.com>
10268             Pedro Alves  <palves@redhat.com>
10269
10270         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10271         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10272
10273 2019-01-23  Tom Tromey  <tom@tromey.com>
10274             Andrew Burgess  <andrew.burgess@embecosm.com>
10275             Pedro Alves  <palves@redhat.com>
10276
10277         * infrun.c (fetch_inferior_event): Use scope_exit.
10278         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10279         * top.c (execute_command): Use scope_exit.
10280         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10281         * utils.c (do_bpstat_clear_actions_cleanup)
10282         (make_bpstat_clear_actions_cleanup): Remove.
10283
10284 2019-01-23  Tom Tromey  <tom@tromey.com>
10285             Pedro Alves  <palves@redhat.com>
10286
10287         * infrun.c: Include "common/scope-exit.h"
10288         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10289         (wait_for_inferior): Use SCOPE_EXIT.
10290         (fetch_inferior_event): Use scope_exit.
10291
10292 2019-01-23  Tom Tromey  <tom@tromey.com>
10293             Pedro Alves  <palves@redhat.com>
10294
10295         * breakpoint.c (create_breakpoint): Remove cleanup.
10296
10297 2019-01-23  Tom Tromey  <tom@tromey.com>
10298             Andrew Burgess  <andrew.burgess@embecosm.com>
10299             Pedro Alves  <palves@redhat.com>
10300
10301 2019-01-23  Pedro Alves  <palves@redhat.com>
10302
10303         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10304
10305 2019-01-23  Pedro Alves  <palves@redhat.com>
10306             Andrew Burgess  <andrew.burgess@embecosm.com>
10307
10308         * gdbthread.h: Include "common/forward-scope-exit.h".
10309         (scoped_finish_thread_state): Redefine custom class in terms of
10310         forward_scope_exit.
10311
10312 2019-01-23  Pedro Alves  <palves@redhat.com>
10313             Andrew Burgess  <andrew.burgess@embecosm.com>
10314
10315         * common/forward-scope-exit.h: New file.
10316
10317 2019-01-23  Pedro Alves  <palves@redhat.com>
10318             Andrew Burgess  <andrew.burgess@embecosm.com>
10319             Tom Tromey  <tom@tromey.com>
10320
10321         * common/scope-exit.h: New file.
10322
10323 2019-01-23  Pedro Alves  <palves@redhat.com>
10324
10325         * common/preprocessor.h (ESC): Rename to ...
10326         (ESC_PARENS): ... this.
10327         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10328         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10329
10330 2019-01-23  Tom Tromey  <tom@tromey.com>
10331
10332         * language.h (class scoped_switch_to_sym_language_if_auto):
10333         Initialize m_lang in both cases.
10334
10335 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10336
10337         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10338         with XCNEW.
10339
10340 2019-01-22  Tom Tromey  <tom@tromey.com>
10341
10342         * corelow.c: Do not include sys/file.h.
10343
10344 2019-01-22  Tom Tromey  <tom@tromey.com>
10345
10346         * tui/tui-wingeneral.h: Include gdb_curses.h.
10347
10348 2019-01-22  Tom Tromey  <tom@tromey.com>
10349
10350         * source-cache.h (class source_cache) <get_source_lines,
10351         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10352
10353 2019-01-22  Tom Tromey  <tom@tromey.com>
10354
10355         * remote-fileio.h (struct remote_target): Declare.
10356
10357 2019-01-22  Tom Tromey  <tom@tromey.com>
10358
10359         * python/py-arch.c: Do not include py-ref.h.
10360         * python/py-bpevent.c: Do not include py-ref.h.
10361         * python/py-cmd.c: Do not include py-ref.h.
10362         * python/py-continueevent.c: Do not include py-ref.h.
10363         * python/py-event.h: Do not include py-ref.h.
10364         * python/py-evtregistry.c: Do not include py-ref.h.
10365         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10366         * python/py-frame.c: Do not include py-ref.h.
10367         * python/py-framefilter.c: Do not include py-ref.h.
10368         * python/py-function.c: Do not include py-ref.h.
10369         * python/py-infevents.c: Do not include py-ref.h.
10370         * python/py-linetable.c: Do not include py-ref.h.
10371         * python/py-objfile.c: Do not include py-ref.h.
10372         * python/py-param.c: Do not include py-ref.h.
10373         * python/py-prettyprint.c: Do not include py-ref.h.
10374         * python/py-progspace.c: Do not include py-ref.h.
10375         * python/py-symbol.c: Do not include py-ref.h.
10376         * python/py-symtab.c: Do not include py-ref.h.
10377         * python/py-type.c: Do not include py-ref.h.
10378         * python/py-unwind.c: Do not include py-ref.h.
10379         * python/py-utils.c: Do not include py-ref.h.
10380         * python/py-value.c: Do not include py-ref.h.
10381         * python/py-varobj.c: Do not include py-ref.h.
10382         * python/py-xmethods.c: Do not include py-ref.h.
10383         * python/python.c: Do not include py-ref.h.
10384         * varobj.c: Do not include py-ref.h.
10385
10386 2019-01-22  Tom Tromey  <tom@tromey.com>
10387
10388         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10389         keyword for bcache.
10390
10391 2019-01-22  Tom Tromey  <tom@tromey.com>
10392
10393         * compile/compile-cplus-types.c: Remove a comment by #include.
10394
10395 2019-01-22  Tom Tromey  <tom@tromey.com>
10396
10397         * compile/gcc-c-plugin.h: Include compile-internal.h.
10398
10399 2019-01-22  Tom Tromey  <tom@tromey.com>
10400
10401         * stabsread.c (EXTERN): Do not define.
10402         (symnum, next_symbol_text_func, processing_gcc_compilation)
10403         (within_function, global_sym_chain, global_stabs)
10404         (previous_stab_code, this_object_header_files)
10405         (n_this_object_header_files)
10406         (n_allocated_this_object_header_files): Define.
10407         * stabsread.h (EXTERN): Never define.  Use "extern".
10408
10409 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10410
10411         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10412         history_value.
10413
10414 2019-01-21  Tom Tromey  <tom@tromey.com>
10415
10416         * ui-out.c: Fix includes.
10417         * tui/tui-source.c: Fix includes.
10418         * target.c: Fix includes.
10419         * remote.c: Fix includes.
10420         * regcache.c: Fix includes.
10421         * python/py-block.c: Fix includes.
10422         * printcmd.c: Fix includes.
10423         * or1k-tdep.c: Fix includes.
10424         * mi/mi-main.c: Fix includes.
10425         * m32r-tdep.c: Fix includes.
10426         * csky-tdep.c: Fix includes.
10427         * compile/compile-cplus-types.c: Fix includes.
10428         * cli/cli-interp.c: Fix includes.
10429
10430 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10431
10432         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10433         for padding.
10434
10435 2019-01-16  Tom Tromey  <tom@tromey.com>
10436
10437         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10438         earlier.
10439         (struct objfile) <msymbols_range>: Move from top level.
10440         <msymbols>: New method.
10441         (class objfile_msymbols): Remove.
10442         * symtab.c (default_collect_symbol_completion_matches_break_on):
10443         Update.
10444         * symmisc.c (dump_msymbols): Update.
10445         * stabsread.c (scan_file_globals): Update.
10446         * objc-lang.c (info_selectors_command, info_classes_command)
10447         (find_methods): Update.
10448         * minsyms.c (find_solib_trampoline_target): Update.
10449         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10450         * coffread.c (coff_symfile_read): Update.
10451         * ada-lang.c (ada_lookup_simple_minsym)
10452         (ada_collect_symbol_completion_matches): Update.
10453
10454 2019-01-16  Tom Tromey  <tom@tromey.com>
10455
10456         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10457         type.  Remove no-argument constructor.
10458         <iterator::operator++>: Simplify.
10459         <begin>: Update.
10460         <end>: Use minimal_symbol_count.
10461
10462 2019-01-16  Tom Tromey  <tom@tromey.com>
10463
10464         * objfiles.h (struct objfile) <psymtabs>: New method.
10465         (class objfile_psymtabs): Remove.
10466         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10467         typedef.
10468         <range>: New method.
10469         (require_partial_symbols): Change return type.
10470         * psymtab.c (require_partial_symbols)
10471         (psym_expand_symtabs_matching): Update.
10472         * mdebugread.c (parse_partial_symbols): Update.
10473         * dbxread.c (dbx_end_psymtab): Update.
10474
10475 2019-01-15  Tom Tromey  <tom@tromey.com>
10476
10477         * symtab.c (lookup_objfile_from_block)
10478         (lookup_symbol_in_objfile_symtabs)
10479         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10480         (find_line_symtab, info_sources_command)
10481         (default_collect_symbol_completion_matches_break_on)
10482         (make_source_files_completion_list): Update.
10483         * symmisc.c (print_objfile_statistics, dump_objfile)
10484         (maintenance_print_symbols, maintenance_info_symtabs)
10485         (maintenance_check_symtabs, maintenance_info_line_tables):
10486         Update.
10487         * source.c (select_source_symtab)
10488         (forget_cached_source_info_for_objfile): Update.
10489         * objfiles.h (class objfile_compunits): Remove.
10490         (struct objfile) <compunits_range>: New typedef.
10491         (compunits): New method.
10492         * objfiles.c (objfile_relocate1): Update.
10493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10494         * maint.c (count_symtabs_and_blocks): Update.
10495         * linespec.c (iterate_over_all_matching_symtabs): Update.
10496         * cp-support.c (add_symbol_overload_list_qualified): Update.
10497         * coffread.c (coff_symtab_read): Update.
10498         * ada-lang.c (add_nonlocal_symbols)
10499         (ada_collect_symbol_completion_matches)
10500         (ada_add_global_exceptions): Update.
10501
10502 2019-01-15  Tom Tromey  <tom@tromey.com>
10503
10504         * progspace.h (program_space) <objfiles_safe_range>: New
10505         typedef.
10506         <objfiles_safe>: New method.
10507         * objfiles.h (class all_objfiles_safe): Remove.
10508         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10509         * jit.c (jit_inferior_exit_hook): Update.
10510
10511 2019-01-17  Tom Tromey  <tom@tromey.com>
10512
10513         * progspace.h (program_space) <objfiles_range>: New typedef.
10514         <objfiles>: New method.
10515         <objfiles_head>: Rename from objfiles.
10516         (object_files): Update.
10517         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10518         * guile/scm-pretty-print.c
10519         (ppscm_find_pretty_printer_from_objfiles): Update.
10520         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10521         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10522         Update.
10523         * python/py-progspace.c (pspy_get_objfiles): Update.
10524         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10525         Update.
10526         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10527         (objfpy_lookup_objfile_by_build_id): Update.
10528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10529         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10530         Update.
10531         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10532         (expand_symtab_containing_pc, lookup_objfile_from_block)
10533         (lookup_static_symbol, basic_lookup_transparent_type)
10534         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10535         (find_line_symtab, info_sources_command)
10536         (default_collect_symbol_completion_matches_break_on)
10537         (make_source_files_completion_list, find_main_name): Update.
10538         * symmisc.c (print_symbol_bcache_statistics)
10539         (print_objfile_statistics, maintenance_print_symbols)
10540         (maintenance_print_msymbols, maintenance_print_objfiles)
10541         (maintenance_info_symtabs, maintenance_check_symtabs)
10542         (maintenance_expand_symtabs, maintenance_info_line_tables):
10543         Update.
10544         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10545         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10546         (map_overlay_command, unmap_overlay_command)
10547         (simple_overlay_update, expand_symtabs_matching)
10548         (map_symbol_filenames): Update.
10549         * symfile-debug.c (set_debug_symfile): Update.
10550         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10551         Update.
10552         * source.c (select_source_symtab, forget_cached_source_info):
10553         Update.
10554         * solib.c (solib_read_symbols): Update.
10555         * solib-spu.c (append_ocl_sos): Update.
10556         * psymtab.c (maintenance_print_psymbols)
10557         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10558         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10559         * printcmd.c (info_symbol_command): Update.
10560         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10561         Update.
10562         * objfiles.h (class all_objfiles): Remove.
10563         * objfiles.c (have_partial_symbols, have_full_symbols)
10564         (have_minimal_symbols, qsort_cmp, update_section_map)
10565         (shared_objfile_contains_address_p)
10566         (default_iterate_over_objfiles_in_search_order): Update.
10567         * objc-lang.c (info_selectors_command, info_classes_command)
10568         (find_methods): Update.
10569         * minsyms.c (find_solib_trampoline_target): Update.
10570         * maint.c (maintenance_info_sections)
10571         (maintenance_translate_address, count_symtabs_and_blocks):
10572         Update.
10573         * main.c (captured_main_1): Update.
10574         * linux-thread-db.c (try_thread_db_load_from_pdir)
10575         (has_libpthread): Update.
10576         * linespec.c (iterate_over_all_matching_symtabs)
10577         (search_minsyms_for_name): Update.
10578         * jit.c (jit_find_objf_with_entry_addr): Update.
10579         * hppa-tdep.c (find_unwind_entry)
10580         (hppa_lookup_stub_minimal_symbol): Update.
10581         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10582         Update.
10583         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10584         (elf_gnu_ifunc_resolve_by_got): Update.
10585         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10586         * dwarf-index-write.c (save_gdb_index_command): Update.
10587         * cp-support.c (add_symbol_overload_list_qualified): Update.
10588         * breakpoint.c (create_overlay_event_breakpoint)
10589         (create_longjmp_master_breakpoint)
10590         (create_std_terminate_master_breakpoint)
10591         (create_exception_master_breakpoint): Update.
10592         * blockframe.c (find_pc_partial_function): Update.
10593         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10594         (ada_collect_symbol_completion_matches)
10595         (ada_add_global_exceptions): Update.
10596
10597 2019-01-17  Tom Tromey  <tom@tromey.com>
10598
10599         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10600         declare VEC.
10601         (solib_target_parse_libraries): Change return type.
10602         (library_list_start_segment, library_list_start_section)
10603         (library_list_end_library, library_list_start_library); Update.
10604         (solib_target_free_library_list): Remove.
10605         (solib_target_parse_libraries): Remove cleanup.  Change return
10606         type.
10607         (solib_target_current_sos): Update.
10608
10609 2019-01-17  Tom Tromey  <tromey@bapiya>
10610
10611         * valprint.c: Replace "the the" with "the".
10612         * symtab.c: Replace "the the" with "the".
10613         * solib.c: Replace "the the" with "the".
10614         * solib-dsbt.c: Replace "the the" with "the".
10615         * linespec.c: Replace "the the" with "the".
10616         * dwarf2loc.h: Replace "the the" with "the".
10617         * amd64-windows-tdep.c: Replace "the the" with "the".
10618         * aarch64-tdep.c: Replace "the the" with "the".
10619
10620 2019-01-16  Keith Seitz  <keiths@redhat.com>
10621
10622         PR gdb/23773
10623         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10624         <builder>: Rename to ..
10625         <m_builder>: ... this and make private.
10626         (dwarf2_cu::get_builder): New method.  Change all users of
10627         `builder' to use this method.
10628         (dwarf2_start_symtab): Move to ...
10629         (dwarf2_cu::start_symtab): ... here.  Update all callers
10630         (setup_type_unit_groups): Move to ...
10631         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10632         callers.
10633         (dwarf2_cu::reset_builder): New method.
10634         (process_full_compunit, process_full_type_unit): Use
10635         dwarf2_cu::reset_builder.
10636         (follow_die_offset): Record the ancestor CU if it is different
10637         from the followed DIE's CU.
10638         (follow_die_sig_1): Likewise.
10639
10640 2019-01-15  Tom Tromey  <tom@tromey.com>
10641
10642         * remote.c (class remote_state) <buf>: Now a char_vector.
10643         <buf_size>: Remove.
10644         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10645         parameter.
10646         (remote_target::getpkt_or_notif_sane_1)
10647         (remote_target::getpkt_sane)
10648         (remote_target::getpkt_or_notif_sane): Likewise.
10649         (class remote_target) <putpkt>: New overload.
10650         (remote_target::read_frame): Change type of "buf_p".  Remove
10651         sizeof_p parameter.
10652         (packet_ok): New overload.
10653         (packet_check_result): New overload.
10654         Update all uses.
10655
10656 2019-01-14  Tom Tromey  <tom@tromey.com>
10657
10658         * remote-notif.c (handle_notification, remote_notif_ack)
10659         (remote_notif_parse): Make "buf" const.
10660         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10661         const.
10662         (remote_notif_parse, remote_notif_ack, handle_notification):
10663         Likewise.
10664         * remote.c (remote_notif_stop_parse): Make "buf" const.
10665         (remote_target::remote_parse_stop_reply): Make "buf" const.
10666         (remote_notif_stop_ack): Make "buf" const.
10667
10668 2019-01-14  Tom Tromey  <tom@tromey.com>
10669
10670         * remote.c (remote_console_output): Make parameter const.
10671
10672 2019-01-14  Tom Tromey  <tom@tromey.com>
10673
10674         * target-debug.h (target_debug_print_signals): Constify.
10675         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10676         * procfs.c (procfs_target::pass_signals): Update.
10677         * linux-nat.c (linux_nat_target::pass_signals): Update.
10678         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10679         * target-delegates.c: Rebuild.
10680         * remote.c (remote_target::program_signals): Update.
10681         (remote_target::pass_signals): Update.
10682         * target.c (target_pass_signals): Constify argument.
10683         (target_program_signals): Likewise.
10684         * target.h (struct target_ops) <pass_signals, program_signals>:
10685         Constify argument.
10686         (target_pass_signals, target_program_signals): Constify argument.
10687
10688 2019-01-14  Tom Tromey  <tom@tromey.com>
10689
10690         PR tui/28819:
10691         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10692
10693 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10694
10695         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10696         field.
10697         * rs6000-tdep.c: Include reggroups.h.
10698         (IS_V_ALIAS_PSEUDOREG): Define.
10699         (rs6000_register_name): Return names for the "vX" aliases.
10700         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10701         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10702         aliases.  Call default_register_reggroup_p for all other
10703         pseudo-registers.
10704         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10705         New functions.
10706         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10707         Handle "vX" aliases.
10708         (v_alias_pseudo_register_collect): New function.
10709         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10710         (rs6000_gdbarch_init): Initialize "vX" aliases as
10711         pseudo-registers.  Restore registration of
10712         rs6000_pseudo_register_reggroup_p with
10713         set_tdesc_pseudo_register_reggroup_p.
10714
10715 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10716
10717         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10718         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10719         set_gdbarch_num_pseudo_regs.
10720
10721 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10722
10723         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10724         Remove arg prefixname, add do_set and do_show.
10725         Add member functions set_list and show_list.
10726         * cli/cli-style.c (class cli_style_option): Update accordingly.
10727         (style_set_list): Move to file scope.
10728         (style_show_list): Likewise.
10729         (set_style): Call help_list.
10730         (show_style): Call cmd_show_list.
10731         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10732         Update to use the new macro.
10733
10734 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10735
10736         * ada-lang.c (_initialize_ada_language): Expand the help text
10737         for the "catch exception" command.
10738
10739 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10740
10741         * symtab.c (matching_obj_sections): Initialize obj,
10742         declare it closer to its usage.
10743
10744 2019-01-10  Tom Tromey  <tom@tromey.com>
10745
10746         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10747         (basic_inf_threads_range): Remove.
10748         (inf_threads_range, inf_non_exited_threads_range)
10749         (safe_inf_threads_range): Use next_adapter.
10750
10751 2019-01-10  Keith Seitz  <keiths@redhat.com>
10752
10753         PR gdb/23712
10754         PR symtab/23010
10755         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10756         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10757
10758 2019-01-10  Keith Seitz  <keiths@redhat.com>
10759
10760         PR gdb/23712
10761         PR symtab/23010
10762         * dictionary.c (pending_to_vector): Remove.
10763         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10764         Remove _1 suffix, replacing functions of the same name.  Update
10765         all callers.
10766         (dict_create_hashed, dict_create_hashed_expandable)
10767         (dict_create_linear, dict_create_linear_expandable, dict_free)
10768         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10769         Make functions static.
10770
10771 2019-01-10  Keith Seitz  <keiths@redhat.com>
10772
10773         PR gdb/23712
10774         PR symtab/23010
10775         * dictionary.h (struct dictionary): Replace declaration with
10776         multidictionary.
10777         (dict_create_hashed, dict_create_hashed_expandable)
10778         (dict_create_linear, dict_create_linear_expandable)
10779         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10780         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10781         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10782         taking multidictionary argument.
10783         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10784         * block.h (struct block) <dict>: Change to multidictionary
10785         and rename `multidict'.
10786         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10787         symmisc.c: Update all dictionary references to multidictionary.
10788
10789 2019-01-10  Keith Seitz  <keiths@redhat.com>
10790
10791         PR gdb/23712
10792         PR symtab/23010
10793         * dictionary.c: Include unordered_map.
10794         (pending_to_vector): New function.
10795         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10796         Rewrite the non-"_1" functions to take vector instead
10797         of linked list.
10798         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10799         "new" _1 versions of the same name.
10800         (multidictionary): Define.
10801         (std::hash<enum language): New definition.
10802         (collate_pending_symbols_by_language, mdict_create_hashed)
10803         (mdict_create_hashed_expandable, mdict_create_linear)
10804         (mdict_create_linear_expandable, mdict_free)
10805         (find_language_dictionary, create_new_language_dictionary)
10806         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10807         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10808         (mdict_size, mdict_empty): New functions.
10809         * dictionary.h (mdict_iterator): Define.
10810
10811 2019-01-10  Pedro Alves  <palves@redhat.com>
10812
10813         * breakpoint.c (read_uploaded_action)
10814         (create_tracepoint_from_upload): Adjust to use
10815         gdb::unique_xmalloc_ptr.
10816         * ctf.c (ctf_write_uploaded_tp):
10817         (SET_ARRAY_FIELD): Use emplace_back.
10818         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10819         * tracefile-tfile.c (tfile_write_uploaded_tp):
10820         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10821         gdb::unique_xmalloc_ptr.
10822         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10823         at_string, cond_string, cmd_strings>: Replace char pointers
10824         with gdb::unique_xmalloc_ptr.
10825
10826 2019-01-10  Pedro Alves  <palves@redhat.com>
10827
10828         * solib-target.c (library_list_start_library): Don't xstrdup name.
10829
10830 2019-01-10  Pedro Alves  <palves@redhat.com>
10831
10832         * mdebugread.c (parse_partial_symbols): Use
10833         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10834
10835 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10836
10837         * linux-fork.c (scoped_switch_fork_info)
10838         <~scoped_switch_fork_info>: Fix incorrect variable name.
10839
10840 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * linux-fork.c (scoped_switch_fork_info)
10843         <scoped_switch_fork_info>: Make explicit.
10844         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10845
10846 2019-01-10  Tom Tromey  <tom@tromey.com>
10847
10848         * objfiles.h (objfile::reset_psymtabs): Update.
10849         * objfiles.c (objfile::objfile): Update.
10850         * psymtab.h (psymtab_storage::obstack): Update.
10851         (psymtab_storage::m_obstack): Use gdb::optional.
10852         (class psymtab_storage): Update comment.  Remove objfile
10853         parameter.
10854         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10855
10856 2019-01-10  Tom Tromey  <tom@tromey.com>
10857
10858         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10859         <free_psymtabs>: Now private.
10860         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10861         (allocate_psymtab): Use new method.
10862
10863 2019-01-10  Tom Tromey  <tom@tromey.com>
10864
10865         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10866         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10867         * mdebugread.c (parse_partial_symbols): Use
10868         allocate_dependencies.
10869         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10870         allocate_dependencies.
10871         (process_psymtab_comp_unit_reader)
10872         (build_type_psymtab_dependencies): Likewise.
10873         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10874
10875 2019-01-10  Tom Tromey  <tom@tromey.com>
10876
10877         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10878         PSYMBOL_SET_LANGUAGE.
10879         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10880
10881 2019-01-10  Tom Tromey  <tom@tromey.com>
10882
10883         * psymtab.h (psymtab_storage::obstack): New method.
10884         <m_obstack>: Rename from obstack; now private.
10885         * psymtab.c (psymtab_storage): Update.
10886         * dwarf2read.c (create_addrmap_from_index)
10887         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10888         Update.
10889
10890 2019-01-10  Tom Tromey  <tom@tromey.com>
10891
10892         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10893         * objfiles.h (objfile::reset_psymtabs): New method.
10894
10895 2019-01-10  Tom Tromey  <tom@tromey.com>
10896
10897         * symmisc.c (print_symbol_bcache_statistics): Update.
10898         (print_objfile_statistics): Update.
10899         * symfile.c (reread_symbols): Update.
10900         * psymtab.h (class psymtab_storage): New.
10901         * psymtab.c (psymtab_storage): New constructor.
10902         (~psymtab_storage): New destructor.
10903         (require_partial_symbols): Update.
10904         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10905         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10906         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10907         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10908         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10909         (start_psymtab_common, end_psymtab_common)
10910         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10911         (allocate_psymtab): Update.
10912         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10913         Update.
10914         (dump_psymtab_addrmap, maintenance_print_psymbols)
10915         (maintenance_check_psymtabs): Update.
10916         (class objfile_psymtabs): Move to objfiles.h.
10917         * psympriv.h (discard_psymtab): Now inline.
10918         (psymtab_discarder::psymtab_discarder): Update.
10919         (psymtab_discarder::~psymtab_discarder): Update.
10920         (ALL_OBJFILE_PSYMTABS): Rewrite.
10921         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10922         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10923         Remove fields.
10924         <partial_symtabs>: New field.
10925         (class objfile_psymtabs): Move from psymtab.h.  Update.
10926         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10927         psymbol_cache.
10928         (objfile::~objfile): Don't destroy psymbol_cache.
10929         * mdebugread.c (parse_partial_symbols): Update.
10930         * dwarf2read.c (create_addrmap_from_index)
10931         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10932         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10933         (add_partial_subprogram, dwarf2_ranges_read): Update.
10934         * dwarf-index-write.c (write_address_map)
10935         (write_one_signatured_type, recursively_write_psymbols)
10936         (class debug_names, class debug_names, write_psymtabs_to_index):
10937         Update.
10938
10939 2019-01-10  Tom Tromey  <tom@tromey.com>
10940
10941         * symtab.h (SYMBOL_SET_NAMES): Update.
10942         (symbol_set_names): Update.
10943         (MSYMBOL_SET_NAMES): Update.
10944         * symtab.c (symbol_set_names): Change argument to be an
10945         objfile_per_bfd_storage.
10946         * psymtab.c (add_psymbol_to_bcache): Update.
10947         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10948
10949 2019-01-10  Tom Tromey  <tom@tromey.com>
10950
10951         * symtab.c (create_demangled_names_hash): Change argument to be an
10952         objfile_per_bfd_storage.
10953         (symbol_set_names): Update.
10954
10955 2019-01-10  Tom Tromey  <tom@tromey.com>
10956
10957         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10958         init_psymbol_list.
10959         * psymtab.c (init_psymbol_list): Do nothing if already called.
10960         * psympriv.h (init_psymbol_list): Add comment.
10961         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10962         init_psymbol_list.
10963         * dbxread.c (dbx_symfile_read): Unconditionally call
10964         init_psymbol_list.
10965
10966 2019-01-10  Tom Tromey  <tom@tromey.com>
10967
10968         * xcoffread.c (scan_xcoff_symtab): Update.
10969         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10970         "where".
10971         * mdebugread.c (parse_partial_symbols)
10972         (handle_psymbol_enumerators): Update.
10973         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10974         * dbxread.c (read_dbx_symtab): Update.
10975         * psympriv.h (psymbol_placement): New enum.
10976         (add_psymbol_to_list): Update.
10977
10978 2019-01-10  Tom Tromey  <tom@tromey.com>
10979
10980         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10981         static_psymbols parameters.
10982         (scan_xcoff_symtab): Update.
10983         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10984         static_psymbols parameters.
10985         * psympriv.h (start_psymtab_common): Update.
10986         * mdebugread.c (parse_partial_symbols): Update.
10987         * dwarf2read.c (create_partial_symtab): Update.
10988         * dbxread.c (read_dbx_symtab): Update.
10989         (start_psymtab): Remove global_psymbols and static_psymbols
10990         parameters.
10991
10992 2019-01-10  Tom Tromey  <tom@tromey.com>
10993
10994         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10995         * psymtab.c (allocate_psymtab): Add comment.
10996         * psympriv.h (allocate_psymtab): Add comment.
10997         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10998         initializations.
10999         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11000
11001 2019-01-10  Tom Tromey  <tom@tromey.com>
11002
11003         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11004         Don't declare.
11005         * mipsread.c: Include mdebugread.h.
11006         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11007         Declare.
11008         * elfread.c: Include mdebugread.h.
11009
11010 2019-01-09  Tom Tromey  <tom@tromey.com>
11011
11012         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11013         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11014         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11015         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11016         (psym_lookup_symbol, psym_find_last_source_symtab)
11017         (psym_forget_cached_source_info, psym_print_stats)
11018         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11019         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11020         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11021         (psym_find_compunit_symtab_by_address)
11022         (maintenance_print_psymbols, maintenance_info_psymtabs)
11023         (maintenance_check_psymtabs): Use ranged for.
11024         * psymtab.h (class objfile_psymtabs): New.
11025         (require_partial_symbols): Return objfile_psymtabs.
11026         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11027
11028 2019-01-09  Tom Tromey  <tom@tromey.com>
11029
11030         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11031         (find_pc_mapped_section, list_overlays_command)
11032         (map_overlay_command, unmap_overlay_command)
11033         (simple_overlay_update): Use all_objfiles.
11034         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11035         * printcmd.c (info_symbol_command): Use all_objfiles.
11036         * objfiles.h (ALL_OBJSECTIONS): Remove.
11037         * maint.c (maintenance_translate_address): Use all_objfiles.
11038         * gcore.c (gcore_create_callback): Use all_objfiles.
11039         (objfile_find_memory_regions): Likewise.
11040
11041 2019-01-09  Tom Tromey  <tom@tromey.com>
11042
11043         * symtab.c (find_line_symtab, info_sources_command)
11044         (make_source_files_completion_list): Use objfile_compunits.
11045         * source.c (select_source_symtab): Use objfile_compunits.
11046         * objfiles.h (struct objfile): Update comment.
11047         (ALL_OBJFILES): Remove.
11048         (ALL_FILETABS): Remove.
11049         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11050         objfile_compunits.
11051
11052 2019-01-09  Tom Tromey  <tom@tromey.com>
11053
11054         * symmisc.c (print_objfile_statistics, dump_objfile)
11055         (maintenance_print_symbols): Use compunit_filetabs.
11056         * source.c (forget_cached_source_info_for_objfile): Use
11057         compunit_filetabs.
11058         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11059         (ALL_FILETABS): Use compunit_filetabs.
11060         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11061         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11062
11063 2019-01-09  Tom Tromey  <tom@tromey.com>
11064
11065         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11066         (compunit_filetabs): New.
11067         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11068         compunit_filetabs.
11069         (info_sources_command, make_source_files_completion_list): Remove
11070         declaration.
11071         * symmisc.c (print_objfile_statistics, dump_objfile)
11072         (maintenance_print_symbols): Remove declaration.
11073         (maintenance_info_symtabs): Use compunit_filetabs.
11074         (maintenance_info_line_tables): Likewise.
11075         * source.c (select_source_symtab): Change local variable name.
11076         (forget_cached_source_info_for_objfile): Remove declaration.
11077         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11078         * objfiles.c (objfile_relocate1): Remove declaration.
11079         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11080         declaration.
11081         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11082         * coffread.c (coff_symtab_read): Remove declaration.
11083         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11084         compunit_filetabs.
11085
11086 2019-01-09  Tom Tromey  <tom@tromey.com>
11087
11088         * symtab.c (lookup_objfile_from_block)
11089         (find_pc_sect_compunit_symtab, search_symbols)
11090         (default_collect_symbol_completion_matches_break_on): Use
11091         objfile_compunits.
11092         * objfiles.h (ALL_COMPUNITS): Remove.
11093         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11094         * cp-support.c (add_symbol_overload_list_qualified): Use
11095         objfile_compunits.
11096         * ada-lang.c (ada_collect_symbol_completion_matches)
11097         (ada_add_global_exceptions): Use objfile_compunits.
11098
11099 2019-01-09  Tom Tromey  <tom@tromey.com>
11100
11101         * source.c (select_source_symtab)
11102         (forget_cached_source_info_for_objfile): Remove declaration.
11103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11104         declaration.
11105         * maint.c (count_symtabs_and_blocks): Remove declaration.
11106         * cp-support.c (add_symbol_overload_list_qualified): Remove
11107         declaration.
11108         * coffread.c (coff_symtab_read): Remove declaration.
11109         * symtab.c (lookup_symbol_in_objfile_symtabs)
11110         (basic_lookup_transparent_type_1): Use objfile_compunits.
11111         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11112         (info_sources_command, search_symbols)
11113         (default_collect_symbol_completion_matches_break_on)
11114         (make_source_files_completion_list): Remove declaration.
11115         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11116         (ada_collect_symbol_completion_matches)
11117         (ada_add_global_exceptions): Remove declaration.
11118         * linespec.c (iterate_over_all_matching_symtabs): Use
11119         objfile_compunits.
11120         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11121         (class objfile_compunits): New.
11122         (ALL_COMPUNITS): Use objfile_compunits.
11123         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11124         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11125         objfile_compunits.
11126         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11127
11128 2019-01-09  Tom Tromey  <tom@tromey.com>
11129
11130         * symtab.c (search_symbols)
11131         (default_collect_symbol_completion_matches_break_on): Use
11132         objfile_msymbols.
11133         * ada-lang.c (ada_lookup_simple_minsym)
11134         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11135         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11136         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11137         objfile_msymbols.
11138         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11139         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11140         * objc-lang.c (find_methods): Use objfile_msymbols.
11141         (info_selectors_command, info_classes_command): Likewise.
11142         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11143         * objfiles.h (class objfile_msymbols): New.
11144         (ALL_OBJFILE_MSYMBOLS): Remove.
11145         (ALL_MSYMBOLS): Remove.
11146
11147 2019-01-09  Tom Tromey  <tom@tromey.com>
11148
11149         * common/next-iterator.h (next_adapter): Add Iterator template
11150         parameter.
11151         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11152         (class all_objfiles_safe): New.
11153         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11154         * objfiles.c (put_objfile_before): Update comment.
11155         (add_separate_debug_objfile): Likewise.
11156         (free_all_objfiles): Use all_objfiles_safe.
11157         (objfile_purge_solibs): Likewise.
11158
11159 2019-01-09  Tom Tromey  <tom@tromey.com>
11160
11161         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11162         (expand_symtab_containing_pc, lookup_static_symbol)
11163         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11164         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11165         all_objfiles.
11166         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11167         * breakpoint.c (create_overlay_event_breakpoint)
11168         (create_longjmp_master_breakpoint)
11169         (create_std_terminate_master_breakpoint)
11170         (create_exception_master_breakpoint): Use all_objfiles.
11171         * linux-thread-db.c (try_thread_db_load_from_pdir)
11172         (has_libpthread): Use all_objfiles.
11173         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11174         * linespec.c (iterate_over_all_matching_symtabs)
11175         (search_minsyms_for_name): Use all_objfiles.
11176         * maint.c (maintenance_info_sections): Use all_objfiles.
11177         * main.c (captured_main_1): Use all_objfiles.
11178         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11179         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11180         * guile/scm-pretty-print.c
11181         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11182         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11183         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11184         (maintenance_print_msymbols): Use all_objfiles.
11185         * source.c (select_source_symtab): Use all_objfiles.
11186         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11187         * symfile.c (remove_symbol_file_command)
11188         (expand_symtabs_matching, map_symbol_filenames): Use
11189         all_objfiles.
11190         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11191         all_objfiles.
11192         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11193         * objc-lang.c (find_methods): Use all_objfiles.
11194         * objfiles.c (have_partial_symbols, have_full_symbols)
11195         (have_minimal_symbols, qsort_cmp)
11196         (default_iterate_over_objfiles_in_search_order): Use
11197         all_objfiles.
11198         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11199         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11200         (maintenance_check_psymtabs): Use all_objfiles.
11201         (ALL_PSYMTABS): Remove.
11202         * compile/compile-object-run.c (do_module_cleanup): Use
11203         all_objfiles.
11204         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11205         * cp-support.c (add_symbol_overload_list_qualified): Use
11206         all_objfiles.
11207         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11208         Use all_objfiles.
11209         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11210         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11211         all_objfiles.
11212         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11213         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11214         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11215         Uses all_objfiles.
11216         * solib.c (solib_read_symbols): Use all_objfiles
11217
11218 2019-01-09  Tom Tromey  <tom@tromey.com>
11219
11220         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11221         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11222         all_objfiles.
11223         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11224         * symmisc.c (print_symbol_bcache_statistics)
11225         (print_objfile_statistics, maintenance_print_objfiles)
11226         (maintenance_info_symtabs, maintenance_check_symtabs)
11227         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11228         all_objfiles.
11229         * source.c (forget_cached_source_info): Use all_objfiles.
11230         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11231         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11232         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11233         * objfiles.c (update_section_map): Use all_objfiles.
11234         (shared_objfile_contains_address_p): Likewise.
11235         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11236         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11237
11238 2019-01-09  Tom Tromey  <tom@tromey.com>
11239
11240         * common/next-iterator.h: New file.
11241         * objfiles.h (class all_objfiles): New.
11242         (struct objfile_iterator): New.
11243
11244 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11245
11246         * NEWS: Move the description of the changed "frame", "select-frame",
11247          and "info frame" commands to the Changed commands section.
11248
11249 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11250
11251         * gdbtypes.c (check_stub_method_group): Remove handling of old
11252         mangling schemes.
11253         * linespec.c (find_methods): Likewise.
11254         * stabsread.c (read_member_functions): Likewise.
11255         * valops.c (search_struct_method): Likewise.
11256         (value_struct_elt_for_reference): Likewise.
11257         * NEWS: Mention this change.
11258
11259 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11260
11261         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11262         print_source_lines.
11263         * source.c (print_source_lines_base): Update line number check.
11264         (print_source_lines): New function.
11265         (source_lines_range::source_lines_range): New function.
11266         * source.h (class source_lines_range): New class.
11267         (print_source_lines): New declaration.
11268
11269 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11270
11271         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11272
11273 2019-01-08  Tom Tromey  <tom@tromey.com>
11274             Simon Marchi  <simon.marchi@ericsson.com>
11275
11276         PR gdb/24060
11277         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11278         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11279         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11280         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11281         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11282         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11283
11284 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11285
11286         * source.c (select_source_symtab): Move header comment to
11287         declaration in source.h.
11288         (forget_cached_source_info_for_objfile): Likewise.
11289         (forget_cached_source_info): Likewise.
11290         (identify_source_line): Likewise.
11291         * source.h (identify_source_line): Move declaration from symtab.h
11292         and add comment from source.c
11293         (print_source_lines): Likewise.
11294         (forget_cached_source_info_for_objfile): Likewise.
11295         (forget_cached_source_info): Likewise.
11296         (select_source_symtab): Likewise.
11297         (enum print_source_lines_flag): Move definition from symtab.h.
11298         * symtab.h (identify_source_line): Move declaration to source.h.
11299         (print_source_lines): Likewise.
11300         (forget_cached_source_info_for_objfile): Likewise.
11301         (forget_cached_source_info): Likewise.
11302         (select_source_symtab): Likewise.
11303         (enum print_source_lines_flag): Move definition to source.h.
11304         * tui/tui-hooks.c: Add 'source.h' include.
11305
11306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11307
11308         * source.c (print_source_lines_base): Handle requests to print
11309         reverse line number sequences, and guard against empty lines
11310         string.
11311
11312 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11313
11314         * source.c (print_source_lines_base): Fix skip of '\r' if next
11315         character is '\n'.
11316
11317 2019-01-06  Tom Tromey  <tom@tromey.com>
11318
11319         * c-exp.y (struct c_parse_state) <macro_original_text,
11320         expansion_obstack>: New member.
11321         (macro_original_text, expansion_obstack): Remove globals.
11322         (scan_macro_expansion, scanning_macro_expansion)
11323         (finished_macro_expansion): Update.
11324         (scan_macro_cleanup): Remove.
11325         (yylex, c_parse): Update.
11326
11327 2019-01-06  Tom Tromey  <tom@tromey.com>
11328
11329         * c-exp.y (struct c_parse_state) <strings>: New member.
11330         (operator_stoken): Update.
11331
11332 2019-01-06  Tom Tromey  <tom@tromey.com>
11333
11334         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11335         (union type_stack_elt) <typelist_val>: Now a pointer to
11336         std::vector.
11337         (type_stack_cleanup): Don't declare.
11338         (push_typelist): Update.
11339         * parse.c (pop_typelist): Return a std::vector.
11340         (push_typelist): Take a std::vector.
11341         (follow_types): Update.  Do not free args.
11342         (type_stack_cleanup): Remove.
11343         * c-exp.y (struct c_parse_state): New.
11344         (cpstate): New global.
11345         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11346         (nonempty_typelist): Update.
11347         (func_mod): Create a new vector.
11348         (c_parse): Create a c_parse_state.
11349         (check_parameter_typelist): Do not delete params.
11350         (function_method): Update.  Do not delete type_list.
11351
11352 2019-01-06  Tom Tromey  <tom@tromey.com>
11353
11354         PR gdb/28155:
11355         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11356         check_typedef.
11357         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11358         (print_return_value): Likewise.
11359
11360 2019-01-05  Tom Tromey  <tom@tromey.com>
11361
11362         * contrib/cleanup_check.py: Remove.
11363         * contrib/gcc-with-excheck: Remove.
11364         * contrib/exsummary.py: Remove.
11365         * contrib/excheck.py: Remove.
11366
11367 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11368
11369         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11370         NULL. Initialize tpprev to NULL instead of assigning it
11371         to NULL on the next statement.
11372         * windows-nat.c (windows_delete_thread): Remove check for
11373         main_thread_id before printing thread exit notifications.
11374         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11375         Remove thread ID check against main_thread_id.
11376         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11377         windows_delete_thread.
11378         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11379
11380 2019-01-04  Tom Tromey  <tom@tromey.com>
11381
11382         * compile/compile.c (_initialize_compile): Use upper case for
11383         metasyntactic variables.
11384         * symmisc.c (_initialize_symmisc): Use upper case for
11385         metasyntactic variables.
11386         * psymtab.c (_initialize_psymtab): Use upper case for
11387         metasyntactic variables.
11388         * demangle.c (demangle_command): Use upper case for metasyntactic
11389         variables.
11390         (_initialize_demangler): Likewise.
11391         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11392         variables.
11393
11394 2019-01-03  Tom Tromey  <tom@tromey.com>
11395
11396         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11397
11398 2019-01-03  Tom Tromey  <tom@tromey.com>
11399
11400         * python/py-symtab.c (salpy_str): Update.
11401         (struct salpy_sal_object) <symtab>: Now a PyObject.
11402         (salpy_dealloc): Update.
11403         (del_objfile_sal): Use gdbpy_ref.
11404
11405 2019-01-03  Tom Tromey  <tom@tromey.com>
11406
11407         * python/py-type.c (convert_field): Use new_reference.  Return
11408         gdbpy_ref.
11409         (make_fielditem): Return gdbpy_ref.
11410         (typy_fields): Update.
11411         (typy_getitem): Update.
11412         (field_name): Return gdbpy_ref.  Use new_reference.
11413         (typy_iterator_iternext): Update.
11414
11415 2019-01-03  Tom Tromey  <tom@tromey.com>
11416
11417         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11418
11419 2019-01-03  Tom Tromey  <tom@tromey.com>
11420
11421         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11422         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11423         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11424         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11425         (pspy_set_type_printers): Likewise.
11426         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11427         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11428         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11429         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11430         (objfpy_set_type_printers): Likewise.
11431
11432 2019-01-03  Tom Tromey  <tom@tromey.com>
11433
11434         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11435         (gdbpy_print_stack): Use gdbpy_err_fetch.
11436         * python/python-internal.h (class gdbpy_err_fetch): New class.
11437         (class gdbpy_enter) <m_error_type, m_error_value,
11438         m_error_traceback>: Remove.
11439         <m_error>: New member.
11440         (gdbpy_exception_to_string): Don't declare.
11441         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11442         * python/py-value.c (convert_value_from_python): Use
11443         gdbpy_err_fetch.
11444         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11445         gdbpy_exception_to_string.
11446         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11447         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11448         gdbpy_err_fetch.
11449
11450 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11451
11452         * linux-nat.c (delete_lwp_cleanup): Delete.
11453         (struct lwp_deleter): New struct.
11454         (lwp_info_up): New typedef.
11455         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11456         lwp_info_up.
11457
11458 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11459
11460         * linux-fork.c (class scoped_switch_fork_info): New class.
11461         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11462
11463 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11464
11465         * valops.c (find_overload_match): Remove use of null_cleanup, and
11466         calls to do_cleanups.
11467
11468 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * compile/compile-cplus-types.c
11471         (compile_cplus_instance::decl_name): Handle changes to
11472         cp_func_name.
11473         * cp-support.c (cp_func_name): Update header comment, update
11474         return type.
11475         * cp-support.h (cp_func_name): Update return type in declaration.
11476         * valops.c (find_overload_match): Move temp_func local to top
11477         level of function and change its type.  Use temp_func to hold and
11478         delete temporary string obtained from cp_func_name.
11479
11480 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11483         gdb::char_vector, remove cleanup, and update uses of `msg`.
11484
11485 2019-01-03  Jim Wilson  <jimw@sifive.com>
11486
11487         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11488
11489 2019-01-02  Tom Tromey  <tom@tromey.com>
11490
11491         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11492         (tdesc_parse_xml): Remove cleanups.
11493         * target-descriptions.h (make_cleanup_free_target_description):
11494         Don't declare.
11495         (target_desc_deleter): New struct.
11496         (target_desc_up): New typedef.
11497         * target-descriptions.c (target_desc_deleter::operator()): Rename
11498         from free_target_description.
11499         (make_cleanup_free_target_description): Remove.
11500
11501 2019-01-02  Tom Tromey  <tom@tromey.com>
11502
11503         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11504         constructor, destructor.
11505         (linespec_parser): Remove typedef.
11506         (~linespec_parser): Rename from linespec_parser_delete.
11507         (linespec_lex_to_end, linespec_complete_label)
11508         (linespec_complete): Update.
11509         (decode_line_full): Remove cleanups.
11510         (decode_line_1): Update.
11511
11512 2019-01-02  Tom Tromey  <tom@tromey.com>
11513
11514         * python/python-internal.h (inferior_to_inferior_object): Change
11515         return type.
11516         * python/py-exitedevent.c (create_exited_event_object): Update.
11517         * python/py-inferior.c (inferior_to_inferior_object): Return
11518         gdbpy_ref.
11519         (python_new_inferior, python_inferior_deleted)
11520         (thread_to_thread_object, delete_thread_object)
11521         (build_inferior_list, gdbpy_selected_inferior): Update.
11522         * python/py-infthread.c (create_thread_object): Update.  Also fail
11523         if inferior_to_inferior_object fails.
11524
11525 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11526
11527         * inferior.h (class inferior) <displaced_step_state>: New field.
11528         * infrun.h (struct displaced_step_state): Move here from
11529         infrun.c.  Initialize fields, add constructor.
11530         <inf>: Remove field.
11531         <reset>: New method.
11532         * infrun.c (struct displaced_step_inferior_state): Move to
11533         infrun.h.
11534         (displaced_step_inferior_states): Remove.
11535         (get_displaced_stepping_state): Adust.
11536         (displaced_step_in_progress_any_inferior): Adjust.
11537         (displaced_step_in_progress_thread): Adjust.
11538         (displaced_step_in_progress): Adjust.
11539         (add_displaced_stepping_state): Remove.
11540         (get_displaced_step_closure_by_addr): Adjust.
11541         (remove_displaced_stepping_state): Remove.
11542         (infrun_inferior_exit): Call displaced_step_state.reset.
11543         (use_displaced_stepping): Don't check for NULL.
11544         (displaced_step_prepare_throw): Call
11545         get_displaced_stepping_state.
11546         (displaced_step_fixup): Don't check for NULL.
11547         (prepare_for_detach): Don't check for NULL.
11548
11549 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11550
11551         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11552          in case of call that did not complete.
11553
11554 2019-01-02  Andrey Utkin  <autkin@undo.io>
11555
11556         * symfile.c (find_separate_debug_file): Fix search of debug files for
11557         remote debuggee.
11558
11559 2019-01-02  Tom Tromey  <tom@tromey.com>
11560
11561         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11562         indentation.
11563         * python/py-frame.c (frapy_older): Remove cast.
11564         (frapy_newer): Likewise.
11565         * python/py-breakpoint.c (local_setattro): Remove cast.
11566         * python/py-arch.c (archpy_name): Remove local variable.
11567         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11568
11569 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11570
11571         * unittests/basic_string_view/element_access/char/empty.cc:
11572         Fix year range in copyright header.
11573
11574 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11575
11576         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11577         Delete.
11578         <operator==>: Update with for removed field.
11579         <hash>: Likewise.
11580         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11581         <isa_features>: ...this.
11582         <abi_features>: New field.
11583         (riscv_isa_flen): Update comment.
11584         (riscv_abi_xlen): New declaration.
11585         (riscv_abi_flen): New declaration.
11586         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11587         isa_features.
11588         (riscv_abi_xlen): New function.
11589         (riscv_isa_flen): Update to get answer from isa_features.
11590         (riscv_abi_flen): New function.
11591         (riscv_has_fp_abi): Update to get answer from abi_features.
11592         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11593         xlen and flen.
11594         (riscv_call_info) <xlen, flen>: Update comment.
11595         (riscv_call_arg_struct): Remove invalid assertions
11596         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11597         is removed.
11598         (riscv_gdbarch_init): Gather isa features and abi features
11599         separately, ensure both match on the gdbarch when reusing an old
11600         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11601         a target with 64-bit float hardware.
11602
11603 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11604
11605         * source.c (search_command_helper): Stop reverse search
11606         when line 1 has been searched.
11607
11608 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11609
11610         * record-full.c (record_full_base_target::close): Rewrite
11611         record_full_core_buf_list free logic.
11612
11613 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11614
11615         * break-catch-syscall.c (print_one_catch_syscall): xfree
11616         the last text.
11617
11618 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11619
11620         * top.c (print_gdb_version): Update Copyright year in version
11621         message.
11622
11623 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11624
11625         Update copyright year range in all GDB files.
11626
11627 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11628
11629         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11630
11631 For older changes see ChangeLog-2018.
11632 \f
11633 Local Variables:
11634 mode: change-log
11635 left-margin: 8
11636 fill-column: 74
11637 version-control: never
11638 coding: utf-8
11639 End:
11640