gdb/ChangeLog

   1 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
   2
   3         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
   4         unnecessary thread walk if remote doesn't support the packet.
   5
   6 2019-08-19  Tom Tromey  <tromey@adacore.com>
   7
   8         * python/py-value.c (value_has_field): Fix indentation.
   9
  10 2019-08-19  Tom Tromey  <tromey@adacore.com>
  11
  12         * printcmd.c (do_one_display, info_display_command): Update.
  13         * block.h (contained_in): Return bool.  Add allow_nested
  14         parameter.
  15         * block.c (contained_in): Return bool.  Add allow_nested
  16         parameter.
  17
  18 2019-08-19  Tom Tromey  <tom@tromey.com>
  19
  20         * configure: Rebuild.
  21         * configure.ac: Disallow the combination of -static-libstdc++ and
  22         source highlight.
  23         * source-cache.c (get_language_name): Handle rust.
  24         (source_cache::get_source_lines): Ignore highlighting exceptions.
  25
  26 2019-08-16  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  29         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  30         (struct tui_source_window_base) <make_visible, refresh_window,
  31         resize>: Remove methods.
  32         <execution_info>: Remove field.
  33         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  34         (tui_show_source_line, tui_source_window_base)
  35         (~tui_source_window_base): Update.
  36         (tui_source_window_base::resize)
  37         (tui_source_window_base::make_visible)
  38         (tui_source_window_base::refresh_window): Remove.
  39         (tui_source_window_base::update_exec_info): Update.
  40         * tui/tui-source.c (tui_source_window::set_contents): Update.
  41         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  42
  43 2019-08-16  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  46         deprecated_query_hook.
  47
  48 2019-08-16  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  51         (tui_update_source_windows_with_line): Update.
  52         * tui/tui-source.h (struct tui_source_window)
  53         <show_symtab_source>: Declare.
  54         (tui_show_symtab_source): Don't declare.
  55         * tui/tui-source.c (tui_show_symtab_source): Rename from
  56         tui_show_symtab_source.
  57
  58 2019-08-16  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui-winsource.h (struct tui_source_window_base)
  61         <set_contents>: Declare.
  62         * tui/tui-winsource.c
  63         (tui_source_window_base::update_source_window_as_is): Update.
  64         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  65         Declare.
  66         (tui_set_source_content): Don't declare.
  67         * tui/tui-source.c (tui_source_window::set_contents): Rename from
  68         tui_set_source_content.
  69         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  70         Declare.
  71         (tui_set_disassem_content): Don't declare.
  72         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
  73         tui_set_disassem_content.
  74
  75 2019-08-16  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-winsource.h (struct tui_source_window_base)
  78         <update_breakpoint_info>: Declare.
  79         (tui_update_breakpoint_info): Don't declare.
  80         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
  81         (tui_update_all_breakpoint_info): Update.
  82         (tui_source_window_base::update_breakpoint_info): Rename from
  83         tui_update_breakpoint_info.
  84         (tui_source_window_base::update_exec_info): Update.
  85
  86 2019-08-16  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-winsource.h (struct tui_source_window_base)
  89         <update_source_window>: Declare.
  90         (tui_update_source_window): Don't declare.
  91         * tui/tui-winsource.c
  92         (tui_source_window_base::update_source_window): Rename from
  93         tui_update_source_window.
  94         (tui_source_window_base::rerender): Update.
  95         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  96         * tui/tui-disasm.c (tui_show_disassem)
  97         (tui_show_disassem_and_update_source)
  98         (tui_disasm_window::maybe_update): Update.
  99
 100 2019-08-16  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-winsource.h (struct tui_source_window_base)
 103         <update_source_window_as_is>: Declare.
 104         (tui_update_source_window_as_is): Don't declare.
 105         * tui/tui-winsource.c (tui_update_source_window): Update
 106         (tui_source_window_base::update_source_window_as_is): Rename from
 107         tui_update_source_window_as_is.
 108         (tui_source_window_base::refill): Update.
 109         * tui/tui-source.c (tui_show_symtab_source): Update.
 110         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 111         Update.
 112
 113 2019-08-16  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.h (tui_update_source_window)
 116         (tui_update_source_window_as_is): Remove "noerror" parameter.
 117         * tui/tui-winsource.c (tui_update_source_window)
 118         (tui_update_source_window_as_is): Remove "noerror" parameter.
 119         (tui_update_source_windows_with_addr)
 120         (tui_update_source_windows_with_line)
 121         (tui_source_window_base::rerender)
 122         (tui_source_window_base::refill): Update.
 123         * tui/tui-source.h (tui_set_source_content)
 124         (tui_show_symtab_source): Remove "noerror" parameter.
 125         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 126         parameter.
 127         (tui_show_symtab_source): Likewise.
 128         (tui_source_window::maybe_update): Update.
 129         * tui/tui-disasm.c (tui_show_disassem)
 130         (tui_show_disassem_and_update_source)
 131         (tui_disasm_window::do_scroll_vertical)
 132         (tui_disasm_window::maybe_update): Update.
 133
 134 2019-08-16  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui.c (tui_is_window_visible): Update.
 137         * tui/tui-wingeneral.c (tui_make_window)
 138         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 139         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 140         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 141         (tui_set_win_height_command, parse_scrolling_args): Update.
 142         * tui/tui-source.c (tui_source_window::style_changed): Update.
 143         * tui/tui-regs.c (tui_show_registers)
 144         (tui_data_window::first_data_item_displayed)
 145         (tui_data_window::delete_data_content_windows)
 146         (tui_check_register_values, tui_reg_command): Update.
 147         * tui/tui-disasm.c (tui_show_disassem): Update.
 148         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 149         method.
 150         <is_visible>: Remove field.
 151         * tui/tui-data.c (tui_next_win, tui_prev_win)
 152         (tui_delete_invisible_windows): Update.
 153
 154 2019-08-16  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-winsource.h (struct tui_source_window_base)
 157         <m_has_locator>: Remove.
 158         * tui/tui-layout.c (show_source_disasm_command, show_data)
 159         (show_source_or_disasm_and_command): Update.
 160
 161 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 162
 163         * NEWS (Other MI changes): New subsection.
 164         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 165         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 166         * arch-utils.c (default_get_pc_address_flags): New function.
 167         * arch-utils.h (default_get_pc_address_flags): New declaration.
 168         * gdbarch.sh: Add get_pc_address_flags.
 169         * gdbarch.c: Regenerate.
 170         * gdbarch.h: Likewise.
 171         * stack.c (print_pc): New function.
 172         (print_frame_info) (print_frame): Call print_pc.
 173
 174 2019-08-16  Tom de Vries  <tdevries@suse.de>
 175
 176         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 177         print_objfile_section_info.
 178
 179 2019-08-15  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 182         calling update_cmdwin_start_line.
 183         * tui/tui-winsource.h (struct tui_source_window_base)
 184         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 185         <rerender>: Declare.
 186         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 187         Call rerender.
 188         (tui_source_window_base::set_new_height): Remove.
 189         (tui_source_window_base::rerender): Rename from
 190         do_make_visible_with_new_height.
 191         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 192         resize method.
 193         (tui_win_info::make_invisible_and_set_new_height)
 194         (tui_win_info::make_visible_with_new_height): Remove.
 195         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 196         Declare.
 197         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 198         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 199         do_make_visible_with_new_height>: Don't declare.
 200         <rerender>: Declare.
 201         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 202         set_new_height.
 203         (tui_data_window::do_make_visible_with_new_height): Remove.
 204         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 205         call tui_show_locator_content.
 206         (tui_gen_win_info::resize): Call rerender.
 207         (show_source_or_disasm_and_command): Don't call
 208         tui_show_locator_content.
 209         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 210         method.
 211         (struct tui_win_info) <rerender>: Declare.
 212         <set_new_height, make_invisible_and_set_new_height,
 213         make_visible_with_new_height>: Don't declare.
 214         * tui/tui-data.c (tui_win_list::rerender): New method.
 215         * tui/tui-command.h (struct tui_cmd_window)
 216         <do_make_visible_with_new_height>: Don't declare.
 217         * tui/tui-command.c
 218         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 219
 220 2019-08-15  Tom Tromey  <tromey@adacore.com>
 221
 222         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 223         * ada-lang.c (ada_enum_name): Likewise.
 224
 225 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 226
 227         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 228         leading underscore.
 229         (GdbOutputErrorFile): Likewise.
 230         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 231         accordingly.
 232         (execute_unwinders): Rename to have a leading underscore.
 233         (auto_load_packages): Likewise.
 234         (global scope): Adjust call to auto_load_packages accordingly.
 235         (GdbSetPythonDirectory): Likewise.
 236         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 237         instead of execute_unwinders.
 238
 239 2019-08-15  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 242         (show_data): Don't change window visibility.
 243         (tui_gen_win_info::resize): Remove special case for command
 244         window.  Use wresize, when available.
 245         (show_source_or_disasm_and_command): Don't change window
 246         visibility.
 247         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 248         <make_visible>: New method.
 249         * tui/tui-command.c (tui_cmd_window::resize): New method.
 250
 251 2019-08-15  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 254         (struct tui_source_windows): New.
 255         * tui/tui-winsource.c (tui_display_main): Update.
 256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 257         (new_height_ok, parse_scrolling_args): Update.
 258         * tui/tui-layout.c (show_layout, show_data): Update.
 259         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 260         (tui_add_to_source_windows): Don't declare.
 261         * tui/tui-data.c (source_windows, tui_source_windows)
 262         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 263
 264 2019-08-15  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 267         Rename from reset.
 268         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 269         * tui/tui-layout.c (show_source_disasm_command, show_data):
 270         Update.
 271         (tui_gen_win_info::resize): Rename.
 272         (show_source_or_disasm_and_command): Update.
 273         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 274         reset.
 275
 276 2019-08-15  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 279         * tui/tui-interp.c (tui_interp::init): Don't call
 280         tui_initialize_static_data.
 281         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 282
 283 2019-08-15  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 286         examine tui_win_list.
 287
 288 2019-08-15  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 291         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 292         tui_clear_source_content.
 293         (tui_clear_source_content): Remove.
 294         (tui_source_window_base::do_erase_source_content): Hoist call to
 295         content.clear().
 296         * tui/tui-stack.c (tui_show_frame_info): Don't call
 297         tui_clear_source_content.
 298
 299 2019-08-15  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-winsource.h (struct tui_source_window_base)
 302         <do_erase_source_content>: New method.
 303         <erase_source_content>: New method.
 304         (tui_erase_source_content): Don't declare.
 305         * tui/tui-winsource.c (tui_clear_source_content): Update.
 306         (tui_source_window_base::do_erase_source_content): Rename from
 307         tui_erase_source_content.
 308         (tui_source_window_base::show_source_content): Update.
 309         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 310         * tui/tui-source.h (struct tui_source_window)
 311         <erase_source_content>: New method.
 312         * tui/tui-disasm.h (struct tui_disasm_window)
 313         <erase_source_content>: New method.
 314
 315 2019-08-15  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 318         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 319         constructor.
 320         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 321         * tui/tui-source.c (tui_set_source_content): Update.
 322         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 323
 324 2019-08-15  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 327         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 328         tui-source.c.
 329         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 330         Declare.
 331         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 332         method.
 333         (tui_source_window::maybe_update): Update.
 334
 335 2019-08-15  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 338         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 339         tui-disasm.c.
 340         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 341         Declare.
 342         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 343         method.
 344         (tui_disasm_window::maybe_update): Update.
 345
 346 2019-08-15  Tom Tromey  <tom@tromey.com>
 347
 348         * tui/tui-winsource.h (struct tui_source_window_base)
 349         <maybe_update>: Declare.
 350         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 351         method.
 352         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 353         Declare.
 354         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 355         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 356         Declare.
 357         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 358
 359 2019-08-15  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 362
 363 2019-08-15  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-wingeneral.c: Include tui-stack.h.
 366         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 367         (struct tui_locator_window): Move from tui-data.h.
 368         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 369         (tui_initialize_static_data): Move from tui-data.c.
 370         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 371         (struct tui_locator_window): Move to tui-stack.c.
 372         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 373         (tui_initialize_static_data): Move to tui-stack.c.
 374
 375 2019-08-15  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-layout.c (show_source_disasm_command)
 378         (show_source_or_disasm_and_command): Use make_visible method, not
 379         tui_make_window.
 380         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 381         Remove.
 382
 383 2019-08-15  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-wingeneral.h (tui_make_window): Update.
 386         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 387         parameter.
 388         (tui_gen_win_info::make_visible): Update.
 389         * tui/tui-regs.c (tui_data_window::display_registers_from):
 390         Update.
 391         * tui/tui-layout.c (show_source_disasm_command)
 392         (show_source_or_disasm_and_command): Update.
 393         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 394         (enum tui_box): Remove.
 395         (struct tui_win_info) <can_box>: New method.
 396         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 397         method.
 398
 399 2019-08-15  Tom de Vries  <tdevries@suse.de>
 400
 401         * linux-nat-trad.c: Include gdbarch.h.
 402
 403 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 404
 405         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 406         register sizes.
 407
 408 2019-08-14  Tom Tromey  <tromey@adacore.com>
 409
 410         * darwin-nat.c: Include gdbarch.h.
 411         * darwin-nat-info.c: Include gdbarch.h.
 412
 413 2019-08-13  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 416         Remove.
 417         * tui/tui-data.c (tui_initialize_static_data): Update.
 418
 419 2019-08-13  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-winsource.h (struct tui_exec_info_window)
 422         <~tui_exec_info_window, maybe_allocate_content, get_content,
 423         m_content>: Remove.
 424         (struct tui_source_window_base) <set_exec_info_content,
 425         show_exec_info_content>: Don't declare.
 426         * tui/tui-winsource.c
 427         (tui_exec_info_window::maybe_allocate_content): Remove.
 428         (tui_source_window_base::update_exec_info): Rename from
 429         set_exec_info_content.
 430         (tui_source_window_base::show_exec_info_content)
 431         (tui_source_window_base::update_exec_info): Remove.
 432
 433 2019-08-13  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 436         declare.
 437         * tui/tui-winsource.c (tui_update_source_window_as_is)
 438         (tui_update_source_windows_with_addr, tui_erase_source_content):
 439         Update.
 440         (tui_clear_exec_info_content): Remove.
 441
 442 2019-08-13  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 445         declare.
 446         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 447         call tui_erase_exec_info_content.
 448         (tui_clear_exec_info_content): Rename from
 449         tui_erase_exec_info_content.
 450         (tui_clear_exec_info_content): Delete.
 451
 452 2019-08-13  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui-winsource.h (struct tui_source_window_base)
 455         <show_exec_info_content>: Declare.
 456         (tui_show_exec_info_content): Don't declare.
 457         * tui/tui-winsource.c
 458         (tui_source_window_base::show_exec_info_content): Rename from
 459         tui_show_exec_info_content.
 460         (tui_source_window_base::update_exec_info): Update.
 461
 462 2019-08-13  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 465         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 466         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 467         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 468         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 469         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 470         ... here.
 471
 472 2019-08-13  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-winsource.h (struct tui_source_window_base)
 475         <update_exec_info>: Declare.
 476         (tui_update_exec_info): Don't declare.
 477         * tui/tui-winsource.c (tui_update_source_window_as_is)
 478         (tui_source_window_base::refresh_all)
 479         (tui_update_all_breakpoint_info): Update.
 480         (tui_source_window_base::update_exec_info): Rename from
 481         tui_update_exec_info.
 482         * tui/tui-stack.c (tui_show_frame_info): Update.
 483
 484 2019-08-13  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_source_window_base)
 487         <set_exec_info_content>: Declare.
 488         (tui_set_exec_info_content): Don't declare.
 489         * tui/tui-winsource.c
 490         (tui_source_window_base::set_exec_info_content): Rename from
 491         tui_set_exec_info_content.
 492         (tui_update_exec_info): Update.
 493
 494 2019-08-13  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-winsource.h (struct tui_source_window_base)
 497         <show_source_content>: Declare.
 498         (tui_show_source_content): Don't declare.
 499         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 500         (tui_source_window_base::show_source_content): Rename from
 501         tui_show_source_content.
 502         (tui_source_window_base::refresh_all): Update.
 503         * tui/tui-layout.c (show_source_disasm_command)
 504         (show_source_or_disasm_and_command): Update.
 505
 506 2019-08-13  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-winsource.c (tui_erase_source_content)
 509         (tui_show_source_content, tui_source_window_base::refresh_all):
 510         Update.
 511         * tui/tui-wingeneral.h
 512         (tui_check_and_display_highlight_if_needed): Don't declare.
 513         * tui/tui-wingeneral.c
 514         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 515         check_and_display_highlight_if_needed.
 516         * tui/tui-win.c (tui_rehighlight_all)
 517         (tui_win_info::make_visible_with_new_height): Update.
 518         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 519         (tui_data_window::erase_data_content)
 520         (tui_data_window::display_all_data): Update.
 521         * tui/tui-data.h (struct tui_win_info)
 522         <check_and_display_highlight_if_needed>: Declare.
 523
 524 2019-08-13  Tom Tromey  <tom@tromey.com>
 525
 526         * tui/tui-win.c (tui_resize_all): Call
 527         tui_delete_invisible_windows.
 528         * tui/tui-layout.c (show_layout): Call
 529         tui_delete_invisible_windows.
 530         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 531         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 532
 533 2019-08-13  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 536         tui_add_win_to_layout.
 537
 538 2019-08-13  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 541         * tui/tui-layout.c (tui_default_win_height): Now static.
 542
 543 2019-08-13  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 546         single switch.
 547         (show_source_disasm_command, show_source_or_disasm_and_command):
 548         Don't check current layout.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-wingeneral.c (make_all_visible): Remove.
 553         (tui_make_all_invisible): Simplify.
 554         * tui/tui-layout.c (tui_make_all_invisible): Move from
 555         tui-wingeneral.c; simplify.
 556         (show_layout): Hoist call to tui_make_all_invisible.
 557         (show_data): Don't call tui_make_all_invisible.
 558
 559 2019-08-13  Tom Tromey  <tom@tromey.com>
 560
 561         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 562         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 563
 564 2019-08-13  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 567         tui-data.c.
 568         (show_source_disasm_command, show_data)
 569         (show_source_or_disasm_and_command): Don't use
 570         tui_set_current_layout_to.
 571         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 572         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 573         tui-layout.c.
 574         (tui_set_current_layout_to): Remove.
 575
 576 2019-08-13  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-layout.c (tui_set_layout): Update.
 579         * tui/tui-data.h (struct tui_layout_def): Remove.
 580         (tui_layout_def): Don't declare.
 581         * tui/tui-data.c (layout_def): Remove.
 582         (tui_layout_def): Remove.
 583
 584 2019-08-13  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-winsource.h (struct tui_source_window_base)
 587         <clear_detail>: No longer "override".
 588         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 589         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 590         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 591         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 592         Remove.
 593         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 594
 595 2019-08-13  Tom Tromey  <tromey@adacore.com>
 596
 597         * tracepoint.c: Don't include readline.h or history.h.
 598
 599 2019-08-12  Tom Tromey  <tom@tromey.com>
 600
 601         * configure: Rebuild.
 602         * configure.ac: Check for readline 7.
 603         * NEWS: Mention readline 7 requirement.
 604         * README: Update.
 605
 606 2019-08-12  Tom Tromey  <tom@tromey.com>
 607
 608         * mingw-hdep.c (gdb_select): Remove readline hack.
 609
 610 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 611
 612         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 613         when the function fails.
 614
 615 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 616
 617         * s390-tdep.c (s390_type_align): New function.
 618         (s390_gdbarch_init): Set it as type_align gdbarch method.
 619
 620 2019-08-09  Tom de Vries  <tdevries@suse.de>
 621
 622         PR gdb/24591
 623         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 624         pc_low with relocation offset.
 625
 626 2019-08-07  Tom Tromey  <tromey@adacore.com>
 627
 628         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 629         (print_frame_args): Update.
 630         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 631         Update.
 632         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 633         * frame.h (struct frame_arg): Add initializers.
 634         <error>: Now a unique_xmalloc_ptr.
 635
 636 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 637
 638         * NEWS: Expand the Pointer Authentication entry.
 639         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 640         (aarch64_frame_unmask_lr): ... to this.
 641         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 642         Call aarch64_frame_unmask_lr.
 643         * frame.c (struct frame_info): Add "masked" variable.
 644         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 645         (fprint_frame): Check for masked pc.
 646         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 647         declarations.
 648         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 649         * stack.c (print_frame): Check for masked pc.
 650
 651 2019-08-06  Tom Tromey  <tom@tromey.com>
 652
 653         * stabsread.c (patch_block_stabs, read_one_struct_field)
 654         (read_enum_type): Use obstack_strndup.
 655         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 656         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 657         * dwarf2read.c (guess_full_die_structure_name)
 658         (anonymous_struct_prefix): Use obstack_strndup.
 659         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 660         * c-exp.y (yylex): Use obstack_strndup.
 661         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 662         (write_var_or_type): Use obstack_strndup.
 663
 664 2019-08-06  Tom Tromey  <tom@tromey.com>
 665
 666         * symfile.c (reread_symbols): Use obstack_strdup.
 667         * stabsread.c (read_type): Use obstack_strdup.
 668         * gdb_obstack.h (obstack_strdup): New overload.
 669         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 670         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 671         (dwarf2_canonicalize_name): Use obstack_strdup.
 672         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 673         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 674         Use obstack_strdup.
 675
 676 2019-08-06  Tom Tromey  <tom@tromey.com>
 677
 678         * gdb_obstack.h (obstack_strdup): Define.
 679         * gdb_obstack.c (obstack_strdup): Don't define.
 680
 681 2019-08-06  Tom Tromey  <tom@tromey.com>
 682
 683         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 684         obstack_strdup.
 685         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 686         obstack_strdup.
 687         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 688         * stabsread.c (common_block_start): Use obstack_strdup.
 689         * objfiles.c (set_objfile_main_name, objfile): Use
 690         obstack_strdup.
 691         * namespace.c (add_using_directive): Use obstack_strdup.
 692         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 693         * jit.c (finalize_symtab): Use obstack_strdup.
 694         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 695         (guess_partial_die_structure_name, partial_die_info::fixup)
 696         (dwarf2_name): Use obstack_strdup.
 697         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 698         obstack_strdup.
 699         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 700         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 701         obstack_strdup.
 702         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 703
 704 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 705
 706         * unittests/help-doc-selftests.c: New file.
 707         * Makefile.in: Add the new file.
 708
 709 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 710
 711         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 712         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 713         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 714         the trailing '.' is not output, and the first character is uppercased.
 715         (print_help_for_command): Update call to print_doc_line.
 716         (print_doc_of_command): Likewise.
 717         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 718         * cli/cli-option.c (append_indented_doc): Do not append newline.
 719         (build_help_option): Append newline after first appended_indented_doc
 720         only if a second call is done.
 721         (build_help): Append 2 new lines before each option, except the first
 722         one.
 723         * compile/compile.c (_initialize_compile): Add new lines after
 724         %OPTIONS%, when not at the end of the help.
 725         Change help doc or code
 726         producing the help doc to respect the invariants.
 727         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 728         Also removed the new line after 'Options:', as all other commands
 729         do not put an empty line between 'Options:' and the first option.
 730         * printcmd.c (_initialize_printcmd): Likewise.
 731         * stack.c (_initialize_stack): Likewise.
 732         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 733         incorrectly telling COMMAND is optional.
 734         * ada-lang.c (_initialize_ada_language): Change help doc or code
 735         producing the help doc to respect the invariants.
 736         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 737         * breakpoint.c (_initialize_breakpoint): Likewise.
 738         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 739         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 740         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 741         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 742         _initialize_cli_style): Likewise.
 743         * corelow.c (core_target_info): Likewise.
 744         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 745         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 746         * filesystem.c (_initialize_filesystem): Likewise.
 747         * frame.c (_initialize_frame): Likewise.
 748         * gnu-nat.c (add_task_commands): Likewise.
 749         * infcall.c (_initialize_infcall): Likewise.
 750         * infcmd.c (_initialize_infcmd): Likewise.
 751         * interps.c (_initialize_interpreter): Likewise.
 752         * language.c (_initialize_language): Likewise.
 753         * linux-fork.c (_initialize_linux_fork): Likewise.
 754         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 755         * maint.c (_initialize_maint_cmds): Likewise.
 756         * memattr.c (_initialize_mem): Likewise.
 757         * printcmd.c (_initialize_printcmd): Likewise.
 758         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 759         _RegEx): Likewise.
 760         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 761         * record-btrace.c (_initialize_record_btrace): Likewise.
 762         * record-full.c (_initialize_record_full): Likewise.
 763         * record.c (_initialize_record): Likewise.
 764         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 765         * regcache.c (_initialize_regcache): Likewise.
 766         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 767         _initialize_remote): Likewise.
 768         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 769         * serial.c (_initialize_serial): Likewise.
 770         * skip.c (_initialize_step_skip): Likewise.
 771         * source.c (_initialize_source): Likewise.
 772         * stack.c (_initialize_stack): Likewise.
 773         * symfile.c (_initialize_symfile): Likewise.
 774         * symtab.c (_initialize_symtab): Likewise.
 775         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 776         * top.c (init_main): Likewise.
 777         * tracefile-tfile.c (tfile_target_info): Likewise.
 778         * tracepoint.c (_initialize_tracepoint): Likewise.
 779         * tui/tui-win.c (_initialize_tui_win): Likewise.
 780         * utils.c (add_internal_problem_command): Likewise.
 781         * valprint.c (value_print_option_defs): Likewise.
 782
 783 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 784
 785         PR build/24886
 786         * configure.ac: Drop enable-libmcheck support.
 787         * configure, config.in: Rebuild.
 788         * libmcheck.m4: Remove.
 789         * acinclude.m4: Don't include it.
 790         * Makefile.in: Don't distribute it.
 791         * top.c (print_gdb_configuration): Don't mention it.
 792
 793 2019-08-06  Tom Tromey  <tom@tromey.com>
 794
 795         * utils.c (set_output_style): Sometimes pass stream to
 796         emit_style_escape.
 797         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 798         * record-btrace.c (btrace_insn_history): Update.
 799         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 800         method.
 801         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 802         Update initializers.
 803         <m_uiout>: New field.
 804         <m_di>: Move lower.
 805         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 806         Remove "uiout" parameter.
 807         (dump_insns): Update.
 808         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 809         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 810
 811 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 812
 813         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 814         (error_in_psymtab_expansion): Likewise.
 815         (lookup_symbol_via_quick_fns): Likewise.
 816         (basic_lookup_transparent_type_quick): Likewise.
 817         (basic_lookup_transparent_type_1): Likewise.
 818
 819 2019-08-06  Tom Tromey  <tromey@adacore.com>
 820
 821         * source.c (last_source_error): Now bool.
 822         (print_source_lines_base): Make "noprint" bool.  Only open
 823         source file when last_source_visited changes.
 824
 825 2019-08-06  Tom Tromey  <tromey@adacore.com>
 826
 827         * annotate.c (annotate_source_line): Use g_source_cache.
 828         * source-cache.c (source_cache::get_plain_source_lines): Change
 829         parameters.  Populate m_offset_cache.
 830         (source_cache::ensure): New method.
 831         (source_cache::get_line_charpos): New method.
 832         (extract_lines): Move lower.  Change parameters.
 833         (source_cache::get_source_lines): Move lower.
 834         * source-cache.h (class source_cache): Update comment.
 835         <get_line_charpos>: New method.
 836         <get_source_lines>: Update comment.
 837         <clear>: Clear m_offset_cache.
 838         <get_plain_source_lines>: Change parameters.
 839         <ensure>: New method
 840         <m_offset_cache>: New member.
 841         * source.c (forget_cached_source_info_for_objfile): Update.
 842         (info_source_command): Use g_source_cache.
 843         (find_source_lines, open_source_file_with_line_charpos): Remove.
 844         (print_source_lines_base, search_command_helper): Use g_source_cache.
 845         * source.h (open_source_file_with_line_charpos): Don't declare.
 846         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 847         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 848         Use g_source_cache.
 849
 850 2019-08-06  Tom Tromey  <tromey@adacore.com>
 851
 852         * source-cache.c (source_cache::get_plain_source_lines):
 853         Remove "first_line" and "last_line" parameters.
 854         (source_cache::get_source_lines): Cache plain text.
 855         * source-cache.h (class source_cache)
 856         <get_plain_source_lines>: Update.
 857
 858 2019-08-06  Tom Tromey  <tromey@adacore.com>
 859
 860         * source-cache.c (extract_lines): No longer a method.
 861         Changed type of parameter.  Include final newline.
 862         (selftests::extract_lines_test): New function.
 863         (_initialize_source_cache): Likewise.
 864         * source-cache.h (class source_cache)
 865         <extract_lines>: Don't declare.
 866
 867 2019-08-06  Tom Tromey  <tromey@adacore.com>
 868
 869         * breakpoint.c (init_breakpoint_sal): Update.
 870         (breakpoint): Update.
 871         * breakpoint.h (struct breakpoint) <filter>: Now a
 872         unique_xmalloc_ptr.
 873
 874 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 875
 876         * NEWS: Mention dictionary access on blocks.
 877         * python/py-block.c (blpy_getitem): New function.
 878         (block_object_as_mapping): New struct.
 879         (block_object_type): Use new struct for tp_as_mapping field.
 880
 881 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 882
 883         * objfiles.h (objfile): Add a comment describing partial symbols.
 884
 885 2019-08-05  Tom Tromey  <tromey@adacore.com>
 886
 887         * compile/compile.c (_initialize_compile): Use _(), not N_().
 888         * thread.c (_initialize_thread): Use _(), not N_().
 889         * stack.c (_initialize_stack): Use _(), not N_().
 890         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 891
 892 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 893
 894         * dwarf2read.c (struct dw2_symtab_iterator):
 895         <want_specific_block>: Remove.
 896         <block_index>: Change type to gdb::optional.
 897         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 898         change type of BLOCK_INDEX parameter to gdb::optional.
 899         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 900         (dw2_lookup_symbol): Don't pass argument for
 901         WANT_SPECIFIC_BLOCK.
 902         (dw2_expand_symtabs_for_function): Don't pass argument for
 903         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 904         (class dw2_debug_names_iterator)
 905         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 906         parameter, change BLOCK_INDEX type to gdb::optional.
 907         <m_want_specific_block>: Remove.
 908         <m_block_index>: Change type to gdb::optional.
 909         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 910         gdb::optional.  Re-write in function of gdb::optional.
 911         (dw2_debug_names_lookup_symbol): Don't pass argument for
 912         WANT_SPECIFIC_BLOCK.
 913         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 914         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 915         BLOCK_INDEX.
 916
 917 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 918
 919         * NEWS: Mention changes to "info sources" command.
 920
 921 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922
 923         * symtab.c (filename_partial_match_opts): New struct type.
 924         (struct output_source_filename_data): New members
 925         regexp, c_regexp, partial_match.
 926         (output_source_filename): Use new members to decide to print file.
 927         (info_sources_option_defs): New variable.
 928         (make_info_sources_options_def_group, print_info_sources_header,
 929         info_sources_command_completer):
 930         New functions.
 931         (info_sources_command): Read new optional arguments.
 932         (_initialize_symtab): Update info sources help.
 933
 934 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 935
 936         * ada-lang.c (exception_support_info_v0): Renamed from...
 937         (default_exception_support_info): ... this.  Create new
 938         definition for v1.
 939         (ada_has_this_exception_support): Look up catch_handlers_sym.
 940         (ada_exception_support_info_sniffer): Try v0 after default.
 941
 942 2019-08-01  Tom Tromey  <tromey@adacore.com>
 943
 944         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 945         gdbarch.h.
 946
 947 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 948
 949         * s12z-tdep.c: Fix include path for s12z-opc.h.
 950
 951 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 952
 953         * NEWS: Require GNU make 3.82.
 954
 955 2019-07-16  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 958         declare.
 959
 960 2019-07-30  Tom Tromey  <tromey@adacore.com>
 961
 962         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 963
 964 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 965
 966         * printcmd.c (print_address_symbolic): Print negative offsets.
 967         (build_address_symbolic): Force signed arithmetic when computing
 968         offset.
 969
 970 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 971
 972         PR/24474: Add a function to lookup static variables.
 973         * NEWS: Mention this new function.
 974         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 975         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 976         * python/python.c (python_GdbMethods): Add new function.
 977
 978 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 979
 980         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 981         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 982         (objfpy_lookup_static_symbol): New function.
 983         (objfile_object_methods): Add new functions.
 984
 985 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 986
 987         * NEWS: Mention 'set|show print frame-info'.  Mention new
 988         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 989         backtrace argument.  Mention that python frame filtering code
 990         is now consistent with what 'backtrace' command prints.
 991
 992 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 993
 994         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 995         comments.
 996         (print_frame_info_auto, print_frame_info_source_line,
 997         print_frame_info_location, print_frame_info_source_and_location,
 998         print_frame_info_location_and_address, print_frame_info_short_location):
 999         New declarations.
1000         (struct frame_print_options): New member print_frame_info.
1001         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1002         * stack.h (get_user_print_what_frame_info): New declaration.
1003         (frame_show_address): New declaration.
1004         * stack.c (print_frame_arguments_choices): New value 'presence'.
1005         (print_frame_info_auto, print_frame_info_source_line,
1006         print_frame_info_location, print_frame_info_source_and_location,
1007         print_frame_info_location_and_address, print_frame_info_short_location,
1008         print_frame_info_choices, print_frame_info_print_what): New definitions.
1009         (print_frame_args): Only print dots for args if print frame-arguments
1010         is 'presence'.
1011         (frame_print_option_defs): New element for "frame-info".
1012         (get_user_print_what_frame_info): New function.
1013         (frame_show_address): Make non static.  Move comment to stack.h.
1014         (print_frame_info_to_print_what): New function.
1015         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1016         to decide what to print.
1017         (backtrace_command_1): Handle the new print_frame_arguments_presence
1018         value.
1019         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1020         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1021         (py_print_frame): In non-mi mode, use LOCATION as default for
1022         print_what, similarly to frame information printed directly by
1023         backtrace command. Handle frame-info user option in non MI mode.
1024
1025 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1026
1027         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1028         Add case for debugging 32-bit target on 64-bit host.  Revise
1029         comment.
1030
1031 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1032
1033         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1034         instead of find_function_entry_range_from_pc.
1035
1036 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1037
1038         * stack.c (find_frame_funname): Remove code which preferred
1039         minsym over symtab sym in "certain pathological cases".
1040
1041         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1042         parameter.  Change type of "do_demangle" to bool.
1043         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1044         Pass suitable "prefer_sym_over_minsym" flag to
1045         build_address_symbolic().  Don't output "+" for negative offsets.
1046         * printcmd.c (print_address_symbolic): Update invocation of
1047         build_address_symbolic to include a "prefer_sym_over_minsym"
1048         flag.
1049         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1050         Restrict cases in which use of minimal symbol is preferred to that
1051         of a found symbol.  Update comments.
1052
1053         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1054         for entry pc when entry pc is out of range for that FDE.
1055
1056 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1057
1058         PR gdb/24839:
1059         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1060         type.
1061
1062 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1063
1064         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1065         this function's Python signature.
1066
1067
1068 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1069
1070         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1071         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1072         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1073         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1074         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1075
1076
1077 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1078
1079         * h8300-tdep.c (h8300_register_name_common): New.
1080         h8300_register_name): Use h8300_register_name_common.
1081         (h8300s_register_name): Likewise.
1082         (h8300sx_register_name): Likewise.
1083         (h8300h_register_nam): New.
1084         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1085
1086
1087 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1088
1089         * arm-tdep.c (arm_skip_cmse_entry): New function.
1090         (arm_is_sgstubs_section): New function.
1091         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1092
1093 2019-07-22  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1096         Don't self-assign.
1097
1098 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1099
1100         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1101         type_print.
1102
1103 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1106         so that GDB doesn't match any msymbols when searching in the
1107         TYPES_DOMAIN.
1108         (print_symbol_info): Print using typedef_print or type_print based
1109         on the type of the symbol.  Add updated FIXME comment moved from...
1110         (_initialize_symtab): ... move and update FIXME comment to above.
1111
1112 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * NEWS: Mention adding -q option to "info types".
1115         * symtab.c (struct info_types_options): New struct.
1116         (info_types_options_defs): New variable.
1117         (make_info_types_options_def_group): New function.
1118         (info_types_command): Use gdb::option framework to parse options.
1119         (info_types_command_completer): New function.
1120         (_initialize_symtab): Extend the help text on "info types" and
1121         register command completer.
1122
1123 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1124
1125         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1126         (lookup_symbol_in_objfile): Change int to block_enum and add a
1127         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1128
1129 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1130
1131         * MAINTAINERS (Write After Approval): Add self.
1132
1133 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1136         instruction to the dummy code region.
1137
1138 2019-07-19  Tom Tromey  <tromey@adacore.com>
1139
1140         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1141         (ARGSUSED, PARAMS, __func__): Remove rules.
1142
1143 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1144
1145         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1146         * features/arm/arm-with-iwmmxt.c: Remove.
1147         * features/arm/arm-with-iwmmxt.xml: Remove.
1148         * features/arm/arm-with-m-fpa-layout.c: Remove.
1149         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1150         * features/arm/arm-with-m-vfp-d16.c: Remove.
1151         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1152         * features/arm/arm-with-m.c: Remove.
1153         * features/arm/arm-with-m.xml: Remove.
1154         * features/arm/arm-with-neon.c: Remove.
1155         * features/arm/arm-with-neon.xml: Remove.
1156         * features/arm/arm-with-vfpv2.c: Remove.
1157         * features/arm/arm-with-vfpv2.xml: Remove.
1158         * features/arm/arm-with-vfpv3.c: Remove.
1159         * features/arm/arm-with-vfpv3.xml: Remove.
1160
1161 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1164
1165 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * arch/aarch32.c (aarch32_create_target_description): Create
1168         target descriptions using features.
1169         * arch/arm.c (arm_create_target_description)
1170         (arm_create_mprofile_target_description): Likewise.
1171         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1172
1173 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * Makefile.in: Add new files.
1176         * aarch32-tdep.c: New file.
1177         * aarch32-tdep.h: New file.
1178         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1179         Call aarch32_read_description.
1180         * arch/aarch32.c: New file.
1181         * arch/aarch32.h: New file.
1182         * arch/arm.c (arm_create_target_description)
1183         (arm_create_mprofile_target_description): New function.
1184         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1185         (arm_create_target_description)
1186         (arm_create_mprofile_target_description): New declaration.
1187         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1188         read_description functions.
1189         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1190         Likewise.
1191         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1192         * arm-tdep.c (tdesc_arm_list): New variable.
1193         (arm_register_g_packet_guesses): Call create description functions.
1194         (arm_read_description) (arm_read_mprofile_description): New
1195         function.
1196         * arm-tdep.h (arm_read_description)
1197         (arm_read_mprofile_description): Add declaration.
1198         * configure.tgt: Add new files.
1199
1200 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1201
1202         * top.c (new_ui_command): Open specified terminal just once.
1203
1204 2019-07-18  Tom Tromey  <tromey@adacore.com>
1205
1206         * symtab.c (main_name): Constify return type.
1207         * symfile.c (set_initial_language): Update.
1208         * symtab.h (main_name): Constify return type.
1209
1210 2019-07-17  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-winsource.c (tui_update_source_window)
1213         (tui_update_source_window_as_is)
1214         (tui_update_source_windows_with_line): Remove return.
1215         * tui/tui-disasm.c (tui_show_disassem)
1216         (tui_show_disassem_and_update_source): Remove return.
1217         * tui/tui.c (tui_reset): Remove return.
1218         * tui/tui-wingeneral.c
1219         (tui_check_and_display_highlight_if_needed): Remove return.
1220
1221 2019-07-17  Tom Tromey  <tom@tromey.com>
1222
1223         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1224
1225 2019-07-17  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-winsource.h (struct tui_exec_info_window)
1228         (struct tui_source_window_base): Move from tui-data.h.
1229         * tui/tui-winsource.c: Move many method definitions from
1230         elsewhere.  Remove "structuring" comments.
1231         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1232         (tui_source_window_base::refresh_window): Move to
1233         tui-winsource.c.
1234         * tui/tui-win.c (tui_source_window_base::refresh_all)
1235         (tui_source_window_base::update_tab_width)
1236         (tui_source_window_base::set_new_height)
1237         (tui_source_window_base::do_make_visible_with_new_height): Move to
1238         tui-winsource.c.
1239         * tui/tui-source.h: Update.
1240         * tui/tui-source.c (tui_source_window_base::reset): Move to
1241         tui-winsource.c.
1242         * tui/tui-disasm.h: Update.
1243         * tui/tui-data.h (struct tui_exec_info_window): Move to
1244         tui-winsource.h.
1245         (struct tui_source_window_base): Likewise.
1246         * tui/tui-data.c (tui_source_window_base::clear_detail)
1247         (tui_source_window_base, ~tui_source_window_base): Move to
1248         tui-winsource.c.
1249
1250 2019-07-17  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-win.c (tui_resize_all)
1253         (tui_source_window_base::update_tab_width)
1254         (tui_adjust_win_heights): Update.
1255         (tui_win_info::make_invisible_and_set_new_height): Rename from
1256         make_invisible_and_set_new_height.
1257         * tui/tui-data.h (struct tui_win_info)
1258         <make_invisible_and_set_new_height>: New method.
1259
1260 2019-07-17  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui.c: Update.
1263         * tui/tui-source.h (struct tui_source_window): Move from
1264         tui-data.h.
1265         * tui/tui-layout.c: Update.
1266         * tui/tui-disasm.c: Update.
1267         * tui/tui-data.h (struct tui_source_window): Move to
1268         tui-source.h.
1269
1270 2019-07-17  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1273         tui-data.h.
1274         * tui/tui-data.h (struct tui_disasm_window): Move to
1275         tui-disasm.h.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-regs.h (struct tui_data_item_window): Move from
1280         tui-data.h.
1281         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1282         * tui/tui-data.h (struct tui_data_item_window): Move to
1283         tui-regs.h.
1284         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui.c: Update.
1289         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1290         (tui_cmd_window::max_height): Move to tui-command.c.
1291         * tui/tui-layout.c: Update.
1292         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1293         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1294         tui-command.c.
1295         * tui/tui-command.h (struct tui_cmd_window): Move from
1296         tui-data.h.
1297         * tui/tui-command.c: Remove "structuring" comments.
1298         (tui_cmd_window::clear_detail)
1299         (tui_cmd_window::do_make_visible_with_new_height)
1300         (tui_cmd_window::max_height): Move from elsewhere.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1305         Now static.
1306         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1307         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui.c: Update.
1312         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1313         tui-regs.c.
1314         * tui/tui-windata.h: Remove file.
1315         * tui/tui-windata.c: Remove file.
1316         * tui/tui-win.c (tui_data_window::set_new_height)
1317         (tui_data_window::do_make_visible_with_new_height): Move to
1318         tui-regs.c.
1319         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1320         * tui/tui-regs.c: Remove "structuring" comments.
1321         (tui_data_window::first_data_item_displayed)
1322         (tui_data_window::delete_data_content_windows)
1323         (tui_data_window::erase_data_content)
1324         (tui_data_window::display_all_data)
1325         (tui_data_window::refresh_all)
1326         (tui_data_window::do_scroll_vertical)
1327         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1328         (tui_data_window::do_make_visible_with_new_height)
1329         (tui_data_window::refresh_window): Move from elsewhere.
1330         (_initialize_tui_regs): Move to end of file.
1331         * tui/tui-layout.c: Update.
1332         * tui/tui-hooks.c: Update.
1333         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1334         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1335         tui-regs.c.
1336         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1337
1338 2019-07-17  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1341         seen.
1342
1343 2019-07-17  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-win.c (tui_source_window_base::set_new_height)
1346         (tui_source_window_base::do_make_visible_with_new_height): Use
1347         m_has_locator field directly.
1348         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1349         method.
1350         (struct tui_source_window_base) <has_locator>: Likewise.
1351
1352 2019-07-17  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1355         Don't declare.
1356         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1357         Remove.
1358         * tui/tui-win.c (tui_source_window_base::set_new_height)
1359         (tui_source_window_base::set_new_height)
1360         (make_invisible_and_set_new_height)
1361         (tui_source_window_base::do_make_visible_with_new_height)
1362         (tui_source_window_base::do_make_visible_with_new_height):
1363         Update.
1364         * tui/tui-layout.c (show_source_disasm_command, show_data)
1365         (show_source_or_disasm_and_command): Update.
1366         * tui/tui-layout.c (show_layout): Update.
1367
1368 2019-07-17  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-layout.c (make_data_window): Remove.
1371         (show_data): Unify creation and re-initialization cases.
1372
1373 2019-07-17  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-layout.c (make_source_window, make_disasm_window):
1376         Remove.
1377         (show_data): Unify creation and re-initialization cases.
1378
1379 2019-07-17  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-layout.c (make_command_window): Remove.
1382         (show_source_disasm_command, show_source_or_disasm_and_command):
1383         Unify creation and re-initialization cases.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1388         creation and re-initialization cases.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-regs.c (tui_get_register): Return void.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1397         Simplify.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1402         resetting.
1403
1404 2019-07-17  Tom Tromey  <tom@tromey.com>
1405
1406         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1407         * tui/tui-regs.c (tui_reg_layout): New function.
1408         (tui_show_registers, tui_reg_command): Use it.
1409         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1410         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1411         parameters.
1412         (tui_layout_command): Remove.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-layout.h (tui/tui-layout): Return void.
1417         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1418
1419 2019-07-17  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-layout.c (show_source_disasm_command, show_data):
1422         Update.
1423         (reset_locator): Remove.
1424         (show_source_or_disasm_and_command): Update.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-source.c (tui_source_window_base::reset): Remove
1429         win_type parameter.
1430         * tui/tui-layout.c (make_command_window, make_source_window)
1431         (make_disasm_window, make_data_window)
1432         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1433         (reset_locator, show_source_or_disasm_and_command): Update.
1434         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1435         win_type parameter.
1436         (struct tui_source_window_base) <reset>: Likewise.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-layout.c (show_source_disasm_command): Use
1441         reset_locator.
1442         (reset_locator): New function.
1443         (init_and_make_win): Remove.
1444         (show_source_or_disasm_and_command): Use reset_locator.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1449         condition.
1450         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1451         Remove condition.
1452         * tui/tui-source.c (tui_source_window_base::reset): New method.
1453         * tui/tui-layout.c (make_command_window): Don't call
1454         init_and_make_win.
1455         (make_source_window, make_disasm_window): Don't call
1456         make_source_or_disasm_window.
1457         (make_data_window): Don't call init_and_make_win.  Change calling
1458         convention.
1459         (show_source_disasm_command, show_data): Simplify.
1460         (make_source_or_disasm_window): Remove.
1461         (show_source_or_disasm_and_command): Simplify.
1462         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1463         (struct tui_source_window_base) <reset>: Likewise.
1464         <execution_info>: Remove initializer.
1465         * tui/tui-data.c (tui_source_window_base): Initialize
1466         execution_info.
1467
1468 2019-07-17  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1471         variable.
1472
1473 2019-07-17  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui.c (tui_rl_other_window): Update.
1476         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1477         superclass method first.  Always iterate over regs_content.
1478         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1479         method.
1480         * tui/tui-win.c (tui_set_focus_command): Update.
1481
1482 2019-07-17  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-win.c (tui_set_focus_command): Rename from
1485         tui_set_focus.  Call tui_enable.
1486         (tui_set_focus_command): Remove.
1487
1488 2019-07-17  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1491         refresh_window.
1492         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1493         touchwin.
1494         (tui_data_window::refresh_window): Call refresh_window on data
1495         items.  Always call superclass refresh_window.
1496         (tui_win_info::refresh): Remove.
1497         (tui_source_window_base::refresh_window): Update.
1498         (tui_refresh_all): Update.
1499         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1500         refresh_window.
1501         (show_source_or_disasm_and_command): Likewise.
1502         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1503         (struct tui_source_window_base) <refresh>: Likewise.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-winsource.c (tui_clear_source_content)
1508         (tui_show_source_content): Update.
1509         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1510         whether content is empty.
1511         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1512         Remove.
1513
1514 2019-07-17  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1517         window's contents.
1518         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1519         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1520
1521 2019-07-17  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1524         (struct tui_data_item_window): Update.
1525
1526 2019-07-17  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1529         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1530         defines.
1531
1532 2019-07-17  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-winsource.h (tui_erase_source_content)
1535         (tui_clear_source_content): Remove "display_prompt" parameter.
1536         * tui/tui-winsource.c (tui_update_source_window_as_is)
1537         (tui_update_source_windows_with_addr): Update.
1538         (tui_clear_source_content): Remove "display_prompt" parameter.
1539         (tui_erase_source_content): Likewise.  Simplify.
1540         (tui_show_source_content): Update.
1541         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1542         * tui/tui-stack.c (tui_show_frame_info): Update.
1543         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1544         Remove defines.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1549         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1550         parameter.
1551         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1552         parameter.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-winsource.c (tui_clear_source_content)
1557         (tui_show_source_content, tui_show_exec_info_content)
1558         (tui_clear_exec_info_content): Update.
1559         * tui/tui-stack.c (tui_show_locator_content): Update.
1560         (tui_show_frame_info): Update.
1561         * tui/tui-source.h (tui_source_window): Don't declare.
1562         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1563         from tui_source_is_displayed.
1564         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1565         Remove field.
1566         (struct tui_source_window_base) <content_in_use>: New field.  Now
1567         bool.
1568         (struct tui_source_window) <showing_source_p>: New method.
1569         (TUI_SRC_WIN): Change cast.
1570         * tui/tui-data.c (tui_initialize_static_data): Update.
1571
1572 2019-07-17  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1575         location_matches_p.
1576         * tui/tui-source.c (tui_source_window::location_matches_p): New
1577         method.
1578         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1579         method.
1580         * tui/tui-data.h (struct tui_source_window_base)
1581         <location_matches_p>: New method.
1582         (struct tui_source_window, struct tui_disasm_window)
1583         <location_matches_p>: Likewise.
1584
1585 2019-07-17  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-win.c (tui_set_win_height_command): Rename from
1588         tui_set_win_height.
1589         (tui_set_win_height_command): Remove.
1590
1591 2019-07-17  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-source.c (tui_source_window): New constructor.  Add
1594         observer.
1595         (~tui_source_window): New destructor.
1596         (tui_source_window::style_changed): New method.
1597         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1598         (tui_attach_detach_observers): Update.
1599         * tui/tui-data.h (struct tui_source_window): Make constructor not
1600         inline.  Add destructor.
1601         (struct tui_source_window) <style_changed>: New method.
1602         <m_observable>: New member.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1607         * tui/tui-win.c (tui_resize_all): Fix typo.
1608
1609 2019-07-17  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1612         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1613         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1614         * tui/tui-win.c (window_name_completer): Use foreach.
1615         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1616         (update_tab_width): Likewise.
1617         * tui/tui-layout.c (show_layout): Update.
1618         * tui/tui-data.h (class tui_window_iterator): New.
1619         (struct all_tui_windows): New.
1620         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1625         parameter.  Don't reference globals.
1626         (tui_reg_command): Update.
1627
1628 2019-07-17  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-regs.c (tui_show_registers): Simplify.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-regs.c (tui_show_registers): Update.
1635         (tui_show_register_group): Add win_info parameter.
1636
1637 2019-07-17  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1640         Rename from tui_display_reg_element_at_line.
1641         (tui_data_window::display_registers_from_line): Update.
1642         * tui/tui-data.h (struct tui_data_window)
1643         <display_reg_element_at_line>: New method.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-regs.h (tui_display_registers_from)
1648         (tui_display_registers_from_line): Don't declare.
1649         * tui/tui-windata.c (tui_data_window::display_all_data)
1650         (tui_data_window::refresh_all)
1651         (tui_data_window::do_scroll_vertical): Update.
1652         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1653         from tui_display_registers_from.
1654         (tui_display_reg_element_at_line): Update.
1655         (tui_data_window::display_registers_from_line): Rename from
1656         tui_display_registers_from_line.
1657         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1658         display_registers_from_line>: New methods.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1663         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1664         from tui_erase_data_content.
1665         (tui_data_window::display_all_data)
1666         (tui_data_window::refresh_all)
1667         (tui_data_window::do_scroll_vertical): Update.
1668         * tui/tui-regs.c (tui_show_registers): Update.
1669         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1670         New method.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1675         declare.
1676         * tui/tui-windata.c
1677         (tui_data_window::delete_data_content_windows): Rename from
1678         tui_delete_data_content_windows.
1679         (tui_data_window::display_all_data)
1680         (tui_data_window::do_scroll_vertical): Update.
1681         * tui/tui-data.h (struct tui_data_window)
1682         <delete_data_content_windows>: New method.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1687         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1688
1689 2019-07-17  Tom Tromey  <tom@tromey.com>
1690
1691         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1692         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1693         from tui_display_all_data.
1694         * tui/tui-win.c
1695         (tui_data_window::do_make_visible_with_new_height): Update.
1696         * tui/tui-regs.c (tui_show_registers): Update.
1697         * tui/tui-layout.c (tui_set_layout): Update.
1698         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1699         method.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1704         * tui/tui-windata.c (tui_display_data_from): Remove.
1705         (tui_data_window::refresh_all): Update.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1710         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1711         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1712         tui_display_registers_from_line.
1713         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1714         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1715         "force_display" parameter.
1716
1717 2019-07-17  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1720         declare.
1721         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1722         Rename from tui_first_reg_element_no_inline.
1723         (tui_display_reg_element_at_line)
1724         (tui_display_registers_from_line): Update.
1725         * tui/tui-data.h (struct tui_data_window)
1726         <first_reg_element_no_inline>: New method.
1727
1728 2019-07-17  Tom Tromey  <tom@tromey.com>
1729
1730         * tui/tui-windata.c (tui_display_data_from)
1731         (tui_data_window::do_scroll_vertical): Update.
1732         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1733         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1734         Rename from tui_line_from_reg_element_no.
1735         (tui_display_registers_from_line): Update.
1736         * tui/tui-data.h (struct tui_data_window)
1737         <line_from_reg_element_no>: New method.
1738
1739 2019-07-17  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1742         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1743         tui_last_regs_line_no.
1744         (tui_display_reg_element_at_line)
1745         (tui_display_registers_from_line): Update.
1746         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1747         method.
1748
1749 2019-07-17  Tom Tromey  <tom@tromey.com>
1750
1751         PR tui/24722:
1752         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1753         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1754         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1755         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1756         (tui_update_breakpoint_info): Likewise.
1757         * tui/tui-hooks.c (tui_event_create_breakpoint)
1758         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1759         Update.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1764
1765 2019-07-17  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-winsource.c (tui_update_source_window_as_is)
1768         (tui_update_source_windows_with_addr): Update.
1769         * tui/tui-source.h (tui_set_source_content)
1770         (tui_show_symtab_source): Add "win_info" parameter.
1771         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1772         parameter.
1773         (tui_show_symtab_source): Likewise.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-wingeneral.c
1778         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1779
1780 2019-07-17  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1783         (struct tui_cmd_window) <can_scroll>: New method.
1784         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1785         method.
1786
1787 2019-07-17  Tom Tromey  <tromey@adacore.com>
1788
1789         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1790         do_field_signed>: Rename.  Change type of "value".
1791         * ui-out.c (ui_out::field_signed): Rename from field_int.
1792         Change type of "value".
1793         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1794         type of "value".
1795         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1796         do_field_int.  Change type of "value".
1797         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1798         do_field_int.  Change type of "value".
1799         * tracepoint.c (trace_status_mi, tfind_1)
1800         (print_one_static_tracepoint_marker): Update.
1801         * thread.c (print_thread_info_1, print_selected_thread_frame):
1802         Update.
1803         * stack.c (print_frame, print_frame_info): Update.
1804         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1805         Update.
1806         * source.c (print_source_lines_base): Update.
1807         * skip.c (info_skip_command): Update.
1808         * record-btrace.c (btrace_ui_out_decode_error)
1809         (btrace_call_history_src_line): Update.
1810         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1811         Update.
1812         * progspace.c (print_program_space): Update.
1813         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1814         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1815         do_field_int.  Change type of "value".
1816         * mi/mi-out.c (mi_ui_out::do_table_begin)
1817         (mi_ui_out::do_table_header): Update.
1818         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1819         type of "value".
1820         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1821         (mi_cmd_data_list_changed_registers, output_register)
1822         (mi_cmd_data_read_memory, mi_load_progress)
1823         (mi_cmd_trace_frame_collected): Update.
1824         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1825         Update.
1826         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1827         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1828         (mi_cmd_var_list_children, varobj_update_one): Update.
1829         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1830         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1831         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1832         * inferior.c (print_inferior): Update.
1833         * gdb_bfd.c (print_one_bfd): Update.
1834         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1835         Update.
1836         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1837         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1838         do_field_int.  Change type of "value".
1839         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1840         do_field_int.  Change type of "value".
1841         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1842         (print_one_breakpoint_location, print_it_catch_fork)
1843         (print_one_catch_fork, print_it_catch_vfork)
1844         (print_one_catch_vfork, print_it_catch_solib)
1845         (print_it_catch_exec, print_it_ranged_breakpoint)
1846         (print_mention_watchpoint, print_mention_masked_watchpoint)
1847         (bkpt_print_it, update_static_tracepoint): Update.
1848         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1849         * break-catch-syscall.c (print_it_catch_syscall): Update.
1850         * ada-tasks.c (print_ada_task_info): Update.
1851         * ada-lang.c (print_it_exception, print_mention_exception):
1852         Update.
1853
1854 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         PR breakpoints/24541
1857         * gdbarch.c: Regenerate.
1858         * gdbarch.h: Regenerate.
1859         * gdbarch.sh: Adjust return type and parameter types for
1860         'stap_adjust_register'.
1861         (i386_stap_adjust_register): Adjust signature and return new
1862         register name.
1863         * stap-probe.c (stap_parse_register_operand): Adjust use of
1864         'gdbarch_stap_adjust_register'.
1865
1866 2019-07-17  Tom Tromey  <tromey@adacore.com>
1867
1868         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1869         declare VEC.
1870         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1871         std::vector.
1872         (struct s390_process_info): Add initializers.
1873         (s390_add_process): Use new.
1874         (s390_linux_nat_target::low_forget_process): Use delete.
1875         (s390_linux_nat_target::low_new_fork)
1876         (s390_linux_nat_target::stopped_by_watchpoint)
1877         (s390_linux_nat_target::low_prepare_to_resume)
1878         (s390_linux_nat_target::insert_watchpoint)
1879         (s390_linux_nat_target::insert_hw_breakpoint)
1880         (s390_linux_nat_target::remove_watchpoint)
1881         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1882
1883 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1884
1885         * aarch64-fbsd-nat.c: Include regcache.h.
1886         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1887         argument.
1888         (aarch64_fbsd_nat_target::fetch_registers)
1889         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1890         variable.
1891         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1892
1893 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1894
1895         * fbsd-nat.c: Include gdbarch.h.
1896
1897 2019-07-15  Tom Tromey  <tromey@adacore.com>
1898
1899         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1900
1901 2019-07-15  Tom Tromey  <tromey@adacore.com>
1902
1903         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1904         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1905         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1906         * cli-out.c (cli_ui_out::do_field_int): New method.
1907         * ui-out.c (ui_out::field_unsigned): New method.
1908         * symfile.c (generic_load): Use field_unsigned.
1909         (print_transfer_performance): Likewise.
1910         * record-btrace.c (ui_out_field_uint): Remove.
1911         (btrace_call_history_insn_range, btrace_call_history): Use
1912         field_unsigned.
1913         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1914         field_unsigned.
1915         * ui-out.h (class ui_out) <field_unsigned>: New method.
1916         <do_field_unsigned>: Likewise.
1917
1918 2019-07-15  Tom Tromey  <tromey@adacore.com>
1919
1920         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1921         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1922         * target.c (flash_erase_command): Use field_string.
1923         * infrun.c (print_signal_received_reason): Use field_string.
1924         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1925         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1926         field_string.
1927         * ada-tasks.c (print_ada_task_info): Use field_string.
1928
1929 2019-07-15  Tom Tromey  <tromey@adacore.com>
1930
1931         * target.c (flash_erase_command): Use field_core_addr.
1932         * symfile.c (generic_load): Use field_core_addr.
1933         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1934         Use field_core_addr.
1935         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1936         field_core_addr.
1937
1938 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1941         value if its desired type is smaller than a CORE_ADDR and signed.
1942
1943 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1946         of changes to field names, and use new is_reference field to
1947         decide if a property is a reference or not.
1948         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1949         field.
1950         (struct dwarf2_property_baton): Update header comment, rename
1951         'referenced_type' to 'property_type' and update comments.
1952         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1953         default property type, store in property baton, update to take
1954         accound of renamed field.
1955         (read_func_scope): Update call to attr_to_dynamic_prop.
1956         (read_array_type): Likewise.
1957         (dwarf2_per_cu_addr_sized_int_type): New function.
1958         (read_subrange_index_type): Move type finding code to
1959         dwarf2_per_cu_addr_sized_int_type.
1960         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1961         (dwarf2_per_cu_addr_type): New function.
1962         (set_die_type): Update calls to attr_to_dynamic_prop.
1963
1964 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1965
1966         * dwarf2read.c (read_subrange_index_type): New function.
1967         (read_subrange_type): Move code into new function and call it.
1968         * gdbtypes.c (create_range_type): Add some asserts.
1969
1970 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1973         update return statements.
1974         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1975         declaration, and update comment to match.
1976         * gdbtypes.c (resolve_dynamic_array): Update call to
1977         dwarf2_evaluate_property to match new return type.
1978
1979 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1980
1981         * valarith.c (value_subscripted_rvalue): Change lowerbound
1982         parameter type from int to LONGEST.
1983         * value.h (value_subscripted_rvalue): Likewise in declaration.
1984
1985 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * cli/cli-utils.c (info_print_command_completer): New function.
1988         * cli/cli-utils.h: Add 'completer.h' include, and forward
1989         declaration for 'struct cmd_list_element'.
1990         (info_print_command_completer): Declare.
1991         * stack.c (_initialize_stack): Add completer for 'info locals' and
1992         'info args'.
1993         * symtab.c (_initialize_symtab): Add completer for 'info
1994         variables' and 'info functions'.
1995         * NEWS: Mention completion for additional info commands.
1996
1997 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1998
1999         * cli/cli-utils.c (extract_info_print_args): Delete.
2000         (extract_arg_maybe_quoted): Delete.
2001         (info_print_options_defs): New variable.
2002         (make_info_print_options_def_group): New function.
2003         (extract_info_print_options): Define new function.
2004         * cli/cli-utils.h (extract_info_print_args): Delete.
2005         (struct info_print_options): New structure.
2006         (extract_info_print_options): Declare new function.
2007         * stack.c (info_locals_command): Update to use new
2008         extract_info_print_options, also add a header comment.
2009         (info_args_command): Likewise.
2010         * symtab.c (info_variables_command): Likewise.
2011         (info_functions_command): Likewise.
2012
2013 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2016         to extract string arguments.
2017         * common/common-utils.c (extract_string_maybe_quoted): New function.
2018         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2019
2020 2019-07-11  Tom Tromey  <tromey@adacore.com>
2021
2022         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2023         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2024         * top.h (gdbinit): Don't declare.
2025         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2026         into...
2027         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2028         * top.c (gdb_init): Don't call init_cli_cmds.
2029         (gdbinit): Remove.
2030         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2031
2032 2019-07-11  Tom Tromey  <tromey@adacore.com>
2033
2034         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2035         after it has been moved.
2036
2037 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2038
2039         * valops.c (value_must_coerce_to_target): Change return type to
2040         bool.
2041         * value.h (value_must_coerce_to_target): Likewise.
2042
2043 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2044
2045         * breakpoint.c (is_hardware_watchpoint): Remove
2046         forward-declaration.
2047         (is_masked_watchpoint): Change return type to bool.
2048         (is_tracepoint): Likewise.
2049         (is_breakpoint): Likewise.
2050         (is_hardware_watchpoint): Likewise.
2051         (is_watchpoint): Likewise.
2052         (is_no_memory_software_watchpoint): Likewise.
2053         (is_catchpoint): Likewise.
2054         (breakpoint_1): Make FILTER parameter's return type bool.
2055         is_masked_watchpoint): Change return type to bool.
2056         (save_breakpoints): Make FILTER parameter's return type bool.
2057         * breakpoint.h (is_breakpoint): Change return type to bool.
2058         (is_watchpoint): Likewise.
2059         (is_catchpoint): Likewise.
2060         (is_tracepoint): Likewise.
2061
2062 2019-07-10  Tom Tromey  <tom@tromey.com>
2063
2064         * defs.h: Don't include gdbarch.h.
2065         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2066         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2067         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2068         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2069         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2070         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2071         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2072         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2073         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2074         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2075         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2076         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2077         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2078         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2079         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2080         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2081         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2082         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2083         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2084         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2085         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2086         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2087         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2088         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2089         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2090         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2091         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2092
2093 2019-07-10  Tom Tromey  <tromey@adacore.com>
2094
2095         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2096         * breakpoint.c (init_ada_exception_breakpoint): Register as
2097         bp_catchpoint.
2098         (print_one_breakpoint_location, print_one_breakpoint): Use
2099         is_ada_exception_catchpoint.
2100         * ada-lang.c (class ada_catchpoint_location): Pass
2101         bp_loc_software_breakpoint to bp_location constructor.
2102         (is_ada_exception_catchpoint): New function.
2103
2104 2019-07-10  Tom Tromey  <tromey@adacore.com>
2105
2106         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2107         VEC.
2108         (struct arm_exidx_entry): New method operator<.
2109         (struct arm_exidx_data) <section_maps>: Change type.
2110         (arm_exidx_data_free): Remove.
2111         (arm_exidx_data_key): Change type.  Move lower.
2112         (arm_exidx_new_objfile): Update.
2113         (arm_compare_exidx_entries): Remove.
2114         (arm_find_exidx_entry, _initialize_arm_tdep)
2115
2116 2019-07-10  Tom Tromey  <tromey@adacore.com>
2117
2118         * solib-spu.c (ocl_program_data_key): Change type.
2119         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2120         Update.
2121
2122 2019-07-10  Tom Tromey  <tromey@adacore.com>
2123
2124         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2125         (struct solib_aix_inferior_data) <library_list>: Change type.
2126         (solib_aix_inferior_data_handle): Change type.
2127         (get_solib_aix_inferior_data): Update.
2128         (solib_aix_free_library_list): Remove.
2129         (library_list_start_library): Update.
2130         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2131         return type.
2132         (solib_aix_get_library_list)
2133         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2134         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2135
2136 2019-07-10  Tom Tromey  <tromey@adacore.com>
2137
2138         * solib-dsbt.c (struct dsbt_info): Add initializers.
2139         (solib_dsbt_pspace_data): Change type.
2140         (dsbt_pspace_data_cleanup): Remove.
2141         (get_dsbt_info, _initialize_dsbt_solib): Update.
2142
2143 2019-07-10  Tom Tromey  <tromey@adacore.com>
2144
2145         * spu-tdep.c (spu_overlay_data): Change type.
2146         (spu_get_overlay_table, spu_overlay_new_objfile)
2147         (_initialize_spu_tdep): Update.
2148
2149 2019-07-10  Tom Tromey  <tromey@adacore.com>
2150
2151         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2152         destructor.
2153         (dbx_objfile_data_key): Change type and declare later.
2154         (DBX_SYMFILE_INFO): Rewrite.
2155         * dbxread.c (dbx_objfile_data_key): Change type.
2156         (dbx_symfile_init): Update.
2157         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2158         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2159         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2160
2161 2019-07-10  Tom Tromey  <tromey@adacore.com>
2162
2163         * jit.c (jit_program_space_key): Change type.  Move lower.
2164         (get_jit_program_space_data): Update.
2165         (jit_program_space_data_cleanup): Remove.
2166         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2167         Update.
2168         (struct jit_program_space_data): Add initializers.
2169
2170 2019-07-10  Tom Tromey  <tromey@adacore.com>
2171
2172         * solib-darwin.c (struct darwin_info): Add initializers.
2173         (solib_darwin_pspace_data): Change type.
2174         (darwin_pspace_data_cleanup): Remove.
2175         (get_darwin_info, _initialize_darwin_solib): Update.
2176
2177 2019-07-10  Tom Tromey  <tromey@adacore.com>
2178
2179         * remote-sim.c (struct sim_inferior_data): Add initializers,
2180         constructor, and destructor.
2181         (sim_inferior_data_key): Change type.  Move lower.
2182         (check_for_duplicate_sim_descriptor): Update.
2183         (get_sim_inferior_data): Use new.  Update.
2184         (~sim_inferior_data_cleanup): Rename from
2185         sim_inferior_data_cleanup.  Simplify.
2186         (gdbsim_close_inferior, simulator_command)
2187         (sim_command_completer, _initialize_remote_sim): Update.
2188         (next_pid, INITIAL_PID): Move earlier.
2189
2190 2019-07-10  Tom Tromey  <tromey@adacore.com>
2191
2192         * python/python-internal.h (create_thread_object): Return
2193         gdbpy_ref.
2194         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2195         * python/py-inferior.c (struct threadlist_entry): Add
2196         constructor.
2197         <thread_obj>: Now a gdbpy_ref.
2198         (thread_to_thread_object): Update.
2199         (add_thread_object): Use new.
2200         (delete_thread_object): Use delete.
2201         (infpy_threads): Update.
2202         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2203         GIL.
2204
2205 2019-07-10  Tom Tromey  <tromey@adacore.com>
2206
2207         * valops.c (value_cast): Specialize error message for Ada.
2208
2209 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2210
2211         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2212
2213 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2214
2215         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2216         bpstat_should_step): Return bool, adjust comments.
2217         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2218         bpstat_should_step): Likewise.
2219
2220 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2221
2222         * features/Makefile: Use feature target descriptions for Arm.
2223         * features/arm/arm-core.c: Generate new file.
2224         * features/arm/arm-fpa.c: Likewise.
2225         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2226         * features/arm/arm-m-profile.c: Likewise.
2227         * features/arm/arm-vfpv2.c: Likewise.
2228         * features/arm/arm-vfpv3.c: Likewise.
2229         * features/arm/xscale-iwmmxt.c: Likewise.
2230         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2231
2232 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2233
2234         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2235         ptrace earlier.
2236
2237 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2238
2239         * features/aarch64-pauth.c: Regenerate.
2240
2241 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2242
2243         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2244         bool.
2245         (bpstat_what): Use false instead of 0.
2246
2247 2019-07-09  Pedro Alves  <palves@redhat.com>
2248
2249         * break-catch-throw.c (is_exception_catchpoint): New.
2250         * breakpoint.c (print_one_breakpoint_location): New parameter
2251         'raw_loc'.  Handle it.  Use
2252         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2253         looking at the breakpoint's type.
2254         (print_one_breakpoint): If handling "maint info breakpoints", also
2255         print locations of exception catchpoints.
2256         * breakpoint.h (is_exception_catchpoint): Declare.
2257
2258 2019-07-09  Pedro Alves  <palves@redhat.com>
2259
2260         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2261         "addr" field.
2262         (allocate_location_exception_catchpoint): New.
2263         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2264         (initialize_throw_catchpoint_ops): Install
2265         allocate_location_exception_catchpoint as allocate_location
2266         method.
2267         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2268         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2269         bp_loc_other.
2270         (breakpoint_address_is_meaningful): Delete.
2271         (bl_address_is_meaningful): New.
2272         (breakpoint_locations_match): Adjust comment.
2273         (bp_location_from_bp_type): New, factored out of...
2274         (bp_location::bp_location(breakpoint *)): ... this.
2275         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2276         factored out of...
2277         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2278         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2279         breakpoint_address_is_meaningful.
2280         (bp_locations_compare): Adjust comment.
2281         (update_global_location_list): Use bl_address_is_meaningful
2282         instead of breakpoint_address_is_meaningful.
2283         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2284         explicit.
2285         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2286         * python/py-breakpoint.c (bppy_get_location): No longer check
2287         whether location is null.
2288
2289 2019-07-09  Pedro Alves  <palves@redhat.com>
2290
2291         PR c++/15468
2292         * breakpoint.c (print_one_breakpoint_location): Remove
2293         single-location assert.
2294
2295 2019-07-09  Tom Tromey  <tom@tromey.com>
2296
2297         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2298         * configure: Rebuild.
2299         * configure.ac: Change common to gdbsupport.
2300         * gdbsupport: Rename from common.
2301         * acinclude.m4: Change common to gdbsupport.
2302         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2303         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2304         gdbsupport.
2305         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2306         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2307         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2308         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2309         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2310         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2311         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2312         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2313         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2314         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2315         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2316         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2317         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2318         coff-pe-read.c, command.h, compile/compile-c-support.c,
2319         compile/compile-c.h, compile/compile-cplus-symbols.c,
2320         compile/compile-cplus-types.c, compile/compile-cplus.h,
2321         compile/compile-loc2c.c, compile/compile.c, completer.c,
2322         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2323         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2324         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2325         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2326         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2327         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2328         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2329         features/aarch64-core.c, features/aarch64-fpu.c,
2330         features/aarch64-pauth.c, features/aarch64-sve.c,
2331         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2332         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2333         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2334         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2335         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2336         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2337         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2338         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2339         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2340         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2341         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2342         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2343         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2344         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2345         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2346         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2347         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2348         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2349         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2350         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2351         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2352         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2353         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2354         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2355         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2356         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2357         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2358         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2359         minsyms.c, mips-linux-tdep.c, namespace.h,
2360         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2361         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2362         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2363         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2364         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2365         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2366         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2367         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2368         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2369         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2370         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2371         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2372         procfs.c, producer.c, progspace.h, psymtab.h,
2373         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2374         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2375         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2376         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2377         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2378         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2379         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2380         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2381         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2382         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2383         target-memory.c, target.c, target.h, target/waitstatus.c,
2384         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2385         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2386         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2387         unittests/array-view-selftests.c,
2388         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2389         unittests/common-utils-selftests.c,
2390         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2391         unittests/format_pieces-selftests.c,
2392         unittests/function-view-selftests.c,
2393         unittests/lookup_name_info-selftests.c,
2394         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2395         unittests/mkdir-recursive-selftests.c,
2396         unittests/observable-selftests.c,
2397         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2398         unittests/parse-connection-spec-selftests.c,
2399         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2400         unittests/scoped_fd-selftests.c,
2401         unittests/scoped_mmap-selftests.c,
2402         unittests/scoped_restore-selftests.c,
2403         unittests/string_view-selftests.c, unittests/style-selftests.c,
2404         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2405         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2406         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2407         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2408         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2409         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2410
2411 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2414         bool value.
2415         (decode_digits_ordinary): Set explicit_line field in sal.
2416         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2417         symtab_and_line that was set on an explicit line number in
2418         assembler code.  Do always update the recorded symtab and line if
2419         we do skip the prologue.
2420
2421 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * breakpoint.c (set_breakpoint_location_function): Remove
2424         explicit_loc parameter.
2425         (momentary_breakpoint_from_master): Update call to
2426         set_breakpoint_location_function.
2427         (add_location_to_breakpoint): Likewise.
2428
2429 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2430
2431         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2432         required features based on default bfd type when no specific bfd
2433         is present.
2434
2435 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * NEWS: Mention that GDB printf and eval commands can now print
2438         C-style and Ada-style convenience var strings without
2439         calling the inferior.
2440         * printcmd.c (printf_c_string): Locally print GDB internal var
2441         instead of transiting via the inferior.
2442         (printf_wide_c_string): Likewise.
2443
2444 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2445
2446         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2447
2448 2019-07-04  Tom Tromey  <tom@tromey.com>
2449
2450         PR tui/24724:
2451         * tui/tui-winsource.c (tui_clear_source_content): Update.
2452         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2453         (tui_update_breakpoint_info): Update.
2454         (tui_set_exec_info_content): Update.
2455         * tui/tui-source.c (tui_set_source_content_nil): Update.
2456         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2457         has_break.
2458         * tui/tui-data.h (enum tui_bp_flag): New.
2459         (tui_bp_flags): New enum flags type.
2460         (struct tui_source_element) <break_mode>: Change type.  Rename
2461         from has_break.
2462         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2463         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2464         constants.
2465         * tui/tui-winsource.h: Fix comment.
2466
2467 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2468
2469         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2470         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2471         (store_fpregs_to_thread)
2472         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2473         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2474         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2475         (IWMMXT_REGS_SIZE): Add define.
2476         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2477         (fetch_vfp_regs, store_vfp_regs)
2478         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2479         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2480
2481 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2482
2483         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2484         defines.
2485         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2486         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2487         (ARM_INT_REGISTER_SIZE): ...to this.
2488         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2489         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2490         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2491         (arm_linux_collect_gregset, supply_nwfpe_register)
2492         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2493         defines.
2494         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2495         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2496         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2497         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2498         (arm_return_in_memory, arm_store_return_value)
2499         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2500         (arm_record_ld_st_multiple): Likewise.
2501         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2502         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2503
2504 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2505
2506         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2507         AARCH64_DISPLACED_MODIFIED_INSNS.
2508         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2509         (aarch64_displaced_step_copy_insn): Likewise.
2510         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2511         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2512         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2513         ARM_DISPLACED_MODIFIED_INSNS.
2514         * arm-tdep.c (arm_gdbarch_init): Likewise.
2515         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2516         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2517         (struct arm_displaced_step_closure): Use
2518         ARM_DISPLACED_MODIFIED_INSNS.
2519
2520 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2521
2522         * features/Makefile: Remove unused xml files.
2523         * features/aarch64.xml: Remove.
2524         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2525         * features/i386/amd64-avx-avx512.xml: Remove.
2526         * features/i386/amd64-avx-linux.xml: Remove.
2527         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2528         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2529         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2530         * features/i386/amd64-avx-mpx.xml: Remove.
2531         * features/i386/amd64-avx.xml: Remove.
2532         * features/i386/amd64-linux.xml: Remove.
2533         * features/i386/amd64-mpx-linux.xml: Remove.
2534         * features/i386/amd64-mpx.xml: Remove.
2535         * features/i386/amd64.xml: Remove.
2536         * features/i386/i386-avx-avx512-linux.xml: Remove.
2537         * features/i386/i386-avx-avx512.xml: Remove.
2538         * features/i386/i386-avx-linux.xml: Remove.
2539         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2540         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2541         * features/i386/i386-avx-mpx-linux.xml: Remove.
2542         * features/i386/i386-avx-mpx.xml: Remove.
2543         * features/i386/i386-avx.xml: Remove.
2544         * features/i386/i386-linux.xml: Remove.
2545         * features/i386/i386-mmx-linux.xml: Remove.
2546         * features/i386/i386-mmx.xml: Remove.
2547         * features/i386/i386-mpx-linux.xml: Remove.
2548         * features/i386/i386-mpx.xml: Remove.
2549         * features/i386/i386.xml: Remove.
2550         * features/i386/x32-avx-avx512-linux.xml: Remove.
2551         * features/i386/x32-avx-linux.xml: Remove.
2552         * features/i386/x32-linux.xml: Remove.
2553
2554 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2555
2556         * regformats/aarch64.dat: Remove.
2557         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2558         * regformats/i386/amd64-avx-linux.dat: Remove.
2559         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2560         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2561         * regformats/i386/amd64-linux.dat: Remove.
2562         * regformats/i386/amd64-mpx-linux.dat: Remove.
2563         * regformats/i386/amd64.dat: Remove.
2564         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2565         * regformats/i386/i386-avx-linux.dat: Remove.
2566         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2567         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2568         * regformats/i386/i386-linux.dat: Remove.
2569         * regformats/i386/i386-mmx-linux.dat: Remove.
2570         * regformats/i386/i386-mpx-linux.dat: Remove.
2571         * regformats/i386/i386.dat: Remove.
2572         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2573         * regformats/i386/x32-avx-linux.dat: Remove.
2574         * regformats/i386/x32-linux.dat: Remove.
2575
2576 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2577
2578         * aarch64-tdep.c: Remove xml self tests.
2579         * amd64-linux-tdep.c: Likewise.
2580         * amd64-tdep.c: Likewise.
2581         * i386-linux-tdep.c: Likewise.
2582         * i386-tdep.c: Likewise.
2583
2584 2019-07-03  Pedro Alves  <palves@redhat.com>
2585
2586         PR cli/24732
2587         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2588         (pipe_cmd_option_defs): New.
2589         (make_pipe_cmd_options_def_group): New.
2590         (pipe_command): Use gdb::option::process_options.
2591         (pipe_command_completer): New function.
2592         (_initialize_cli_cmds): Install completer for "pipe" command.
2593
2594 2019-07-03  Pedro Alves  <palves@redhat.com>
2595
2596         * cli/cli-option.c (union option_value) <string>: New field.
2597         (struct option_def_and_value): Add ctor, move ctor, dtor and
2598         use DISABLE_COPY_AND_ASSIGN.
2599         (option_def_and_value::clear_value): New.
2600         (parse_option, save_option_value_in_ctx, get_val_type_str)
2601         (add_setshow_cmds_for_options): Handle var_string.
2602         * cli-option.h (union option_def::var_address) <string>: New
2603         field.
2604         (struct string_option_def): New.
2605         * maint-test-options.c (struct test_options_opts): Add default
2606         ctor and use DISABLE_COPY_AND_ASSIGN.
2607         <string_opt>: New field.
2608         (test_options_opts::~test_options_opts): New.
2609         (test_options_opts::dump): Also dump "-string".
2610         (test_options_option_defs): Install "string.
2611
2612 2019-07-03  Pedro Alves  <palves@redhat.com>
2613
2614         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2615         option_value with a null enumeration.
2616         (complete_options): Save the option values in the context.
2617         (save_option_value_in_ctx): New, factored out from ...
2618         (process_options): ... here.
2619         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2620         of the function.
2621         * maint-test-options.c (test_options_opts::dump): New, factored
2622         out from ...
2623         (maintenance_test_options_command_mode): ... here.
2624         (maintenance_test_options_command_completion_result): Delete.
2625         (maintenance_test_options_command_completion_text): Update
2626         comment.
2627         (maintenance_show_test_options_completion_result): Change
2628         prototype.  Just print
2629         maintenance_test_options_command_completion_text.
2630         (save_completion_result): New.
2631         (maintenance_test_options_completer_mode): Pass options context to
2632         complete_options, and then save a dump.
2633         (_initialize_maint_test_options): Use add_cmd to install "maint
2634         show test-options-completion-result".
2635
2636 2019-07-03  Pedro Alves  <palves@redhat.com>
2637
2638         * NEWS (New commands): Mention "with" and "maint with".
2639         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2640         (with_command, with_command_completer): New.
2641         (pipe_command): Adjust to new repeat_previous
2642         interface.
2643         (_initialize_cli_cmds): Install the "with" command and its "w"
2644         alias.
2645         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2646         declarations.
2647         * cli/cli-setshow.c (parse_cli_var_uinteger)
2648         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2649         argument strings for all var_types.
2650         (get_setshow_command_value_string): New, factored out from ...
2651         (do_show_command): ... this.
2652         * cli/cli-setshow.h: Include <string>.
2653         (get_setshow_command_value_string): Declare.
2654         * command.h (repeat_previous): Now returns const char *.  Adjust
2655         comment.
2656         * maint.c: Include "cli/cli-cmds.h".
2657         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2658         (_initialize_maint_cmds): Register the "maintenance with" command.
2659         * top.c (repeat_previous): Move bits from pipe_command here:
2660         Return the saved command line, if any; error out if there's no
2661         command to relaunch.
2662
2663 2019-07-03  Pedro Alves  <palves@redhat.com>
2664
2665         * NEWS (New commands): Mention "maint set/show test-settings"
2666         instead of "maint test-settings".
2667         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2668         (maintenance_test_settings_set_list): Rename to ...
2669         (maintenance_set_test_settings_list): ... this.
2670         (maintenance_test_settings_show_list): Rename to  ...
2671         (maintenance_show_test_settings_list): ... this.
2672         (maintenance_test_settings_cmd): Delete.
2673         (maintenance_test_settings_set_cmd): ...
2674         (maintenance_set_test_settings_cmd): ... this.
2675         (maintenance_test_settings_show_cmd): ...
2676         (maintenance_show_test_settings_cmd): ... this.
2677         (maintenance_test_settings_show_value_cmd):
2678         (maintenance_show_test_settings_value_cmd): ... this.
2679         (_initialize_maint_test_settings): No longer install the "maint
2680         test-settings" prefix command.  Rename "maint test-settings set"
2681         to "maint set test-settings", and "maint test-settings show" to
2682         "maint show test-settings".  Adjust all subcommands.
2683
2684 2019-07-03  Pedro Alves  <palves@redhat.com>
2685
2686         * maint-test-settings.c: Fix file's intro comment.  Replace all
2687         references to "test-options" with references to "test-settings",
2688         in comments.
2689
2690 2019-07-03  Pedro Alves  <palves@redhat.com>
2691
2692         * maint-test-settings.c (maintenance_test_settings_xxx)
2693         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2694         New.
2695         (maintenance_test_settings_enums): Use them.
2696         (maintenance_test_settings_enum): Default to
2697         maintenance_test_settings_xxx.
2698         (_initialize_maint_test_settings): Initialize
2699         MAINTENANCE_TEST_SETTINGS_FILENAME.
2700
2701 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2702
2703         * breakpoint.h (remove_breakpoints_inf): Change return type to
2704         void, move function documentation here.
2705         * breakpoint.c (remove_breakpoints_inf): Change return type to
2706         void, move function documentation to header.
2707
2708 2019-07-02  Pedro Alves  <palves@redhat.com>
2709
2710         * NEWS (Completion improvements): Mention "info threads".
2711         * thread.c (struct info_threads_opts, info_threads_option_defs)
2712         (make_info_threads_options_def_group): New.
2713         (info_threads_command): Use gdb::option::process_options.
2714         (info_threads_command_completer): New.
2715         (_initialize_thread): Use gdb::option::build_help to build the
2716         help text for "info threads".
2717
2718 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2719
2720         * defs.h (generic_load): Move from here...
2721         * symfile.h (generic_load): ... to here.  Rename name parameter
2722         to args.
2723         * symfile.c (generic_load): Add comment.
2724
2725 2019-07-01  Tom Tromey  <tromey@adacore.com>
2726
2727         * dwarf2read.c
2728         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2729         declaration of without_params.  Fix formatting.
2730
2731 2019-07-01  Tom Tromey  <tromey@adacore.com>
2732
2733         * ada-exp.y (find_primitive_type): Update.
2734         * ada-lang.h (ada_lookup_symbol): Update.
2735         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2736         parameter.
2737         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2738
2739 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2740
2741         PR breakpoints/24541
2742         * gdbarch.c: Regenerate.
2743         * gdbarch.h: Regenerate.
2744         * gdbarch.sh: Add 'stap_adjust_register'.
2745         * i386-tdep.c: Include '<unordered_set>'.
2746         (i386_stap_adjust_register): New function.
2747         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2748         * stap-probe.c (stap_parse_register_operand): Call
2749         'gdbarch_stap_adjust_register'.
2750
2751 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2752
2753         PR python/24742
2754         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2755         * python/python.c (do_start_initialization): Use 'xmalloc'
2756         instead of 'PyMem_Malloc'.
2757
2758 2019-06-28  Tom Tromey  <tromey@adacore.com>
2759
2760         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2761         for Ada.
2762
2763 2019-06-27  Tom Tromey  <tromey@adacore.com>
2764
2765         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2766         objfile_key.
2767         (arm_find_mapping_symbol, arm_record_special_symbol)
2768         (_initialize_arm_tdep): Update.
2769         (arm_objfile_data_free): Remove.
2770
2771 2019-06-27  Tom Tromey  <tromey@adacore.com>
2772
2773         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2774         to cp_print_static_field.
2775
2776 2019-06-26  Tom Tromey  <tromey@adacore.com>
2777
2778         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2779         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2780         declare.
2781
2782 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2783
2784         * features/aarch64-core.c (create_feature_aarch64_core):
2785         Regenerate.
2786         * features/aarch64-core.xml: Add cpsr flags.
2787
2788 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2789
2790         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2791         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2792
2793 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2794
2795         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2796         field.
2797         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2798         use.
2799         (arm_record_special_symbol): Don't insert new symbol in sorted
2800         position, push it at the end.
2801
2802 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2803
2804         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2805         (arm_mapping_symbol_s): Remove.
2806         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2807         (arm_mapping_symbol_vec): New typedef.
2808         (struct arm_per_objfile): Add constructor.
2809         <section_maps>: Change type to
2810         std::unique_ptr<arm_mapping_symbol_vec[]>.
2811         (arm_compare_mapping_symbols): Remove.
2812         (arm_find_mapping_symbol): Adjust to section_maps type change.
2813         (arm_objfile_data_free): Call delete on arm_per_objfile.
2814         (arm_record_special_symbol): Adjust to section_maps type change.
2815         Allocate arm_per_objfile with new.
2816
2817 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2818
2819         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2820         with the command prefix.
2821
2822 2019-06-25  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2825         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2826
2827 2019-06-25  Tom Tromey  <tom@tromey.com>
2828
2829         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2830         type.
2831         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2832         protected.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-winsource.c
2837         (tui_source_window_base::set_is_exec_point_at): Add check against
2838         LOA_ADDRESS.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-source.c (tui_set_source_content): Don't check before
2843         xfree.
2844         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2845
2846 2019-06-25  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-winsource.h (tui_update_source_window_as_is)
2849         (tui_alloc_source_buffer, tui_line_is_displayed)
2850         (tui_addr_is_displayed): Change type of win_info.
2851         * tui/tui-winsource.c (tui_update_source_window_as_is)
2852         (tui_clear_source_content, tui_show_source_line)
2853         (tui_show_source_content, tui_source_window_base::refill)
2854         (tui_source_window_base::set_is_exec_point_at)
2855         (tui_source_window_base::set_is_exec_point_at)
2856         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2857         (tui_alloc_source_buffer, tui_line_is_displayed)
2858         (tui_addr_is_displayed): Change type of win_info.  Update.
2859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2860         (tui_source_window_base::do_make_visible_with_new_height):
2861         Update.
2862         * tui/tui-source.c (tui_set_source_content)
2863         (tui_set_source_content_nil)
2864         (tui_source_window::do_scroll_vertical): Update.
2865         * tui/tui-layout.c (show_layout): Update.
2866         * tui/tui-disasm.c (tui_set_disassem_content)
2867         (tui_disasm_window::do_scroll_vertical): Update.
2868         * tui/tui-data.h (tui_win_content): Remove.
2869         (struct tui_gen_win_info) <content, content_size>: Remove.
2870         (struct tui_source_element): Add initializers and destructor.
2871         (union tui_which_element, struct tui_win_element): Remove.
2872         (struct tui_source_window_base) <content>: New field.
2873         (struct tui_data_window): Remove destructor.
2874         (tui_alloc_content, tui_free_win_content)
2875         (tui_free_all_source_wins_content): Don't declare.
2876         * tui/tui-data.c (tui_initialize_static_data): Update.
2877         (init_content_element, tui_alloc_content): Remove.
2878         (~tui_gen_win_info): Update.
2879         (~tui_data_window, tui_free_all_source_wins_content)
2880         (tui_free_win_content, free_content, free_content_elements):
2881         Remove.
2882
2883 2019-06-25  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-winsource.h (tui_clear_source_content)
2886         (tui_erase_source_content, tui_show_source_content): Change type
2887         of win_info.
2888         * tui/tui-winsource.c (tui_clear_source_content)
2889         (tui_erase_source_content, tui_show_source_content): Change type
2890         of win_info.
2891         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2892         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2893         win_info.
2894         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2895         win_info.
2896         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2897
2898 2019-06-25  Tom Tromey  <tom@tromey.com>
2899
2900         * tui/tui-winsource.c (tui_clear_source_content)
2901         (tui_source_window_base::set_is_exec_point_at): Update.
2902         * tui/tui-source.c (tui_set_source_content_nil): Update.
2903         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2904         a bool.
2905         * tui/tui-data.c (init_content_element): Update.
2906
2907 2019-06-25  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2910         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2911         * tui/tui-layout.c (init_and_make_win): Update.
2912         * tui/tui.h (enum tui_win_type): Update.
2913         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2914         tui_win_is_auxillary.
2915         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2916         tui_win_is_auxillary.
2917
2918 2019-06-25  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2921         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2922         (tui_delete_data_content_windows, tui_display_all_data)
2923         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2924         Update.
2925         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2926         * tui/tui-regs.c (tui_last_regs_line_no)
2927         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2928         (tui_show_registers): Update.
2929         (tui_show_register_group): Return void.  Update.
2930         (tui_display_registers_from, tui_display_reg_element_at_line)
2931         (tui_display_registers_from_line, tui_check_register_values):
2932         Update.
2933         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2934         member.
2935         (struct tui_data_window) <regs_content>: Now a std::vector.
2936         <regs_content_count>: Remove.
2937         (tui_add_content_elements, tui_free_data_content): Don't declare.
2938         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2939         (init_content_element): Remove DATA_WIN case.  Add assert.
2940         (tui_add_content_elements): Remove.
2941         (tui_data_window): Update.
2942         (tui_free_data_content): Remove.
2943         (free_content_elements): Remove DATA_WIN case.
2944
2945 2019-06-25  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-data.c (tui_data_item_window): Update.
2948         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2949         * tui/tui-windata.c (tui_display_all_data)
2950         (tui_display_data_from_line): Update.
2951         (tui_check_data_values): Remove.
2952         * tui/tui-regs.c (tui_show_register_group)
2953         (tui_display_reg_element_at_line): Update.
2954         * tui/tui-hooks.c (tui_register_changed)
2955         (tui_refresh_frame_and_register_information): Call
2956         tui_check_register_values.
2957         * tui/tui-data.h (struct tui_data_window) <data_content,
2958         data_content_count, data_type>: Remove.
2959         (enum tui_data_type): Remove.
2960
2961         * tui/tui-data.c (tui_data_window::clear_detail)
2962         (~tui_data_window): Update.
2963
2964 2019-06-25  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2967         declare.
2968         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2969         Rename from tui_first_data_item_displayed.  Update.
2970         (tui_data_window::refresh_all)
2971         (tui_data_window::do_scroll_vertical): Update.
2972         * tui/tui-data.h (struct tui_data_window)
2973         <first_data_item_displayed>: Declare new method.
2974
2975 2019-06-25  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2978         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2979         contents...
2980         (tui_initialize_static_data): ...here.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2985         (tui_display_registers_from, tui_check_register_values): Update.
2986         (tui_display_register): Remove win_info parameter; update.
2987         (tui_get_register): Change type of parameters.
2988         * tui/tui-data.h (struct tui_data_element): Remove.
2989         (union tui_which_element) <data>: Remove.
2990         <data_window>: Change type.
2991         (struct tui_data_item_window): New.
2992         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2993         case.  Add assert.
2994         (~tui_data_item_window): New destructor.
2995         (free_content_elements): Remove DATA_ITEM_WIN case.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3000         Remove.
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-data.h (struct tui_command_element): Remove.
3005         (union tui_which_element) <command>: Remove.
3006         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3007         assert.
3008         (free_content_elements): Remove CMD_WIN case.
3009
3010 2019-06-25  Tom Tromey  <tom@tromey.com>
3011
3012         * tui/tui-layout.c (tui_set_layout): Update.
3013         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3014         * tui/tui-data.c (layout_def): Update.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3019         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3020         (tui_source_window_base::set_new_height): Update.
3021         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3022         Update.
3023         (tui_set_locator_fullname, tui_set_locator_info)
3024         (tui_show_frame_info): Update.
3025         * tui/tui-source.c (tui_set_source_content)
3026         (tui_source_is_displayed): Update.
3027         * tui/tui-layout.c (show_source_disasm_command, show_data)
3028         (show_source_or_disasm_and_command): Update.
3029         * tui/tui-disasm.c (tui_set_disassem_content)
3030         (tui_get_begin_asm_address): Update.
3031         * tui/tui-data.h (struct tui_locator_element): Remove.
3032         (union tui_which_element) <locator>: Remove.
3033         (struct tui_locator_window): New.
3034         (tui_locator_win_info_ptr): Change return type.
3035         * tui/tui-data.c (_locator): Change type.
3036         (tui_locator_win_info_ptr): Change return type.
3037         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3038         (tui_alloc_content): Add assert.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-winsource.c
3043         (tui_exec_info_window::maybe_allocate_content): New method.
3044         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3045         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3046         (make_source_or_disasm_window): Add cast.
3047         * tui/tui-data.h (union tui_which_element) <simple_string>:
3048         Remove.
3049         (struct tui_source_info): New.
3050         (struct tui_source_window_base) <execution_info>: Change type.
3051         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3052         case, and add assert.
3053         (tui_alloc_content): Add assert.
3054
3055 2019-06-25  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3058         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3059         * tui/tui-data.c (tui_alloc_win_info): Remove.
3060
3061 2019-06-25  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3064         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3065         can_highlight.
3066
3067 2019-06-25  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3070         make_visible_with_new_height method.
3071         (tui_win_info::make_visible_with_new_height): New method.
3072         (tui_source_window_base::do_make_visible_with_new_height)
3073         (tui_data_window::do_make_visible_with_new_height)
3074         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3075         (make_visible_with_new_height): Remove.
3076         (tui_resize_all, tui_adjust_win_heights): Use
3077         make_visible_with_new_height method.
3078         * tui/tui-data.h (struct tui_win_info)
3079         <do_make_visible_with_new_height, make_visible_with_new_height>:
3080         New methods.
3081         (struct tui_source_window_base, struct tui_data_window)
3082         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3083         methods.
3084
3085 2019-06-25  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3088         method.
3089         (update_tab_width): Call update_tab_width method.
3090         * tui/tui-data.h (struct tui_win_info)
3091         (struct tui_source_window_base) <update_tab_width>: New methods.
3092
3093 2019-06-25  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3096         parameter.
3097         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3098         parameter.
3099         (tui_gen_win_info::make_visible): Update.
3100         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3101         parameter.
3102         * tui/tui-data.h (enum tui_box): New enum.
3103         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3108         init_and_make_win for EXEC_INFO_WIN.
3109         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3110         longer inline.
3111         (struct tui_win_info) <~tui_win_info>: Inline.
3112         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3113         Don't declare.
3114         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3115         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3116         Remove.
3117         (tui_initialize_static_data): Update.
3118         (~tui_gen_win_info): Handle more cleanup here.
3119         (~tui_source_window_base): Delete "execution_info".
3120         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3121
3122 2019-06-25  Tom Tromey  <tom@tromey.com>
3123
3124         * tui/tui-layout.c (make_command_window): Don't set
3125         can_highlight.
3126         (show_source_disasm_command): Call the reset method.
3127         (show_data): Don't set can_highlight.  Call the reset method.
3128         (tui_gen_win_info::reset): Rename from init_gen_win_info
3129         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3130         (show_source_or_disasm_and_command): Call the reset method.
3131         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3132         (struct tui_cmd_window): Set can_highlight.
3133
3134 2019-06-25  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3137         from make_visible.
3138         (tui_make_visible, tui_make_invisible): Rewrite.
3139         (tui_win_info::make_visible): Remove.
3140         (tui_source_window_base::make_visible): Update.
3141         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3142         method.  Moved from...
3143         (struct tui_win_info) <make_visible>: ...here.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-winsource.c
3148         (tui_source_window_base::do_scroll_horizontal): Remove direction
3149         parameter.
3150         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3151         direction parameter.
3152         * tui/tui-win.c (tui_win_info::forward_scroll)
3153         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3154         (tui_win_info::right_scroll): Update.
3155         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3156         direction parameter.
3157         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3158         direction parameter.
3159         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3160         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3161         Remove direction parameter.
3162         (struct tui_source_window_base, struct tui_source_window)
3163         (struct tui_disasm_window, struct tui_data_window)
3164         (struct tui_cmd_window): Update.
3165
3166 2019-06-25  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-winsource.h (tui_set_exec_info_content)
3169         (tui_show_exec_info_content, tui_erase_exec_info_content)
3170         (tui_clear_exec_info_content, tui_update_exec_info): Change
3171         argument to tui_source_window_base.
3172         * tui/tui-winsource.c (tui_set_exec_info_content)
3173         (tui_show_exec_info_content, tui_erase_exec_info_content)
3174         (tui_clear_exec_info_content, tui_update_exec_info): Change
3175         argument to tui_source_window_base.
3176
3177 2019-06-25  Tom Tromey  <tom@tromey.com>
3178
3179         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3180         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3181
3182 2019-06-25  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3185         check.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3190         type to void.
3191         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3192         type to void.
3193         * tui/tui-source.c (tui_set_source_content): Update.
3194         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3195
3196 2019-06-25  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-win.c (window_name_completer, tui_set_focus)
3199         (tui_all_windows_info): Use name method.
3200         * tui/tui-data.h (struct tui_gen_win_info)
3201         (struct tui_source_window, struct tui_disasm_window)
3202         (struct tui_data_window, struct tui_cmd_window) <name>: New
3203         method.
3204         (tui_win_name): Don't declare.
3205         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3206         (tui_win_name): Remove.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-winsource.h (tui_update_source_window)
3211         (tui_update_source_window_as_is): Change parameter type.
3212         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3213         to be a tui_source_window_base.
3214         (tui_update_source_window_as_is): Likewise.
3215         * tui/tui-win.c (make_visible_with_new_height): Update.
3216
3217 2019-06-25  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-winsource.c (tui_erase_source_content)
3220         (tui_show_source_content, tui_show_exec_info_content)
3221         (tui_erase_exec_info_content): Use refresh_window method.
3222         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3223         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3224         from tui_refresh_win.
3225         (tui_data_window::refresh_window): New method.
3226         (tui_win_info::refresh, tui_source_window_base::refresh)
3227         (tui_refresh_all): Use refresh_window method.
3228         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3229         method.
3230         * tui/tui-regs.c (tui_display_register): Call refresh_window
3231         method.
3232         * tui/tui-layout.c (show_source_disasm_command)
3233         (show_source_or_disasm_and_command): Call refresh_window method.
3234         * tui/tui-data.h (struct tui_gen_win_info)
3235         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3236         New method.
3237
3238 2019-06-25  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui.c (tui_rl_other_window, tui_enable)
3241         (tui_is_window_visible, tui_get_command_dimension): Update.
3242         * tui/tui-winsource.c (tui_update_source_window_as_is)
3243         (tui_clear_source_content, tui_erase_source_content)
3244         (tui_show_source_line, tui_source_window_base::refill)
3245         (tui_source_window_base::do_scroll_horizontal)
3246         (tui_source_window_base::set_is_exec_point_at)
3247         (tui_update_breakpoint_info, tui_set_exec_info_content)
3248         (tui_alloc_source_buffer, tui_line_is_displayed)
3249         (tui_addr_is_displayed): Update.
3250         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3251         (tui_check_and_display_highlight_if_needed)
3252         (tui_win_info::make_visible, tui_win_info::refresh)
3253         (tui_refresh_all): Update.
3254         * tui/tui-windata.c (tui_first_data_item_displayed)
3255         (tui_delete_data_content_windows, tui_erase_data_content)
3256         (tui_display_all_data, tui_data_window::refresh_all)
3257         (tui_check_data_values): Update.
3258         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3259         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3260         (tui_win_info::backward_scroll, tui_refresh_all_win)
3261         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3262         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3263         (tui_source_window_base::set_new_height)
3264         (tui_data_window::set_new_height)
3265         (make_invisible_and_set_new_height)
3266         (make_visible_with_new_height, new_height_ok)
3267         (parse_scrolling_args): Update.
3268         * tui/tui-stack.c (tui_show_frame_info): Update.
3269         * tui/tui-source.c (tui_set_source_content)
3270         (tui_set_source_content_nil, tui_source_is_displayed)
3271         (tui_source_window::do_scroll_vertical): Update.
3272         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3273         (tui_display_registers_from, tui_display_reg_element_at_line)
3274         (tui_check_register_values, tui_reg_command): Update.
3275         * tui/tui-layout.c (tui_default_win_height)
3276         (show_source_disasm_command, show_data, init_and_make_win)
3277         (show_source_or_disasm_and_command): Update.
3278         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3279         (tui_redisplay_readline, tui_mld_flush)
3280         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3281         (tui_getc): Update.
3282         * tui/tui-disasm.c (tui_set_disassem_content)
3283         (tui_disasm_window::do_scroll_vertical): Update.
3284         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3285         Now virtual.
3286         (struct tui_win_info): Derive from tui_gen_win_info.
3287         <~tui_win_info>: Mark as override.
3288         <generic>: Remove member.
3289         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3290         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3291         (~tui_data_window, ~tui_win_info)
3292         (tui_free_all_source_wins_content): Update.
3293         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3294
3295 2019-06-25  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-layout.c (init_and_make_win): Use new.
3298         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3299         destructor, initializers.
3300         (tui_alloc_generic_win_info): Don't declare.
3301         * tui/tui-data.c (_locator): Add argument to constructor.
3302         (source_win, disasm_win): New globals.
3303         (exec_info): Remove.
3304         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3305         Update.
3306         (tui_alloc_generic_win_info): Remove.
3307         (init_content_element): Use new.
3308         (tui_win_info::tui_win_info): Update.
3309         (free_content_elements) <case DATA_WIN>: Use delete.
3310
3311 2019-06-25  Tom Tromey  <tom@tromey.com>
3312
3313         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3314         * tui/tui-windata.c (tui_first_data_item_displayed)
3315         (tui_delete_data_content_windows): Update.
3316         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3317         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3318         (tui_display_registers_from, tui_check_register_values): Update.
3319         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3320         pointer.
3321         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3322         window.
3323         (tui_free_data_content): Update.
3324         (free_content_elements) <case DATA_WIN>: Free the window.
3325
3326 2019-06-25  Tom Tromey  <tom@tromey.com>
3327
3328         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3329         Update.
3330         * tui/tui-layout.c (make_command_window)
3331         (show_source_disasm_command, show_data, init_and_make_win)
3332         (show_source_or_disasm_and_command): Update.
3333         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3334         method.
3335         <can_highight, is_highlighted>: Now bool.
3336         (tui_set_win_highlight): Don't declare.
3337         * tui/tui-data.c (tui_set_win_highlight): Remove.
3338
3339 2019-06-25  Tom Tromey  <tom@tromey.com>
3340
3341         * tui/tui-wingeneral.c (make_visible): Remove check of window
3342         type.
3343
3344 2019-06-25  Tom Tromey  <tom@tromey.com>
3345
3346         * tui/tui-win.c (tui_win_info::max_height)
3347         (tui_cmd_window::max_height): New methods.
3348         (new_height_ok): Call max_height.
3349         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3350         <max_height>: New method.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-win.c (tui_source_window_base::set_new_height)
3355         (tui_data_window::set_new_height): New methods.
3356         (make_invisible_and_set_new_height): Call set_new_height method.
3357         * tui/tui-data.h (struct tui_win_info)
3358         (struct tui_source_window_base, struct tui_data_window)
3359         <set_new_height>: New method.
3360
3361 2019-06-25  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3364         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3365         tui_refresh_data_win.
3366         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3367         method.
3368         (tui_refresh_all_win): Call the refresh_all method.
3369         (tui_set_focus): Likewise.
3370         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3371         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3372         Likewise.
3373
3374 2019-06-25  Tom Tromey  <tom@tromey.com>
3375
3376         * tui/tui-winsource.h (tui_refill_source_window)
3377         (tui_set_is_exec_point_at): Don't declare.
3378         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3379         (tui_source_window_base::refill): Rename from
3380         tui_refill_source_window.
3381         (tui_source_window_base::do_scroll_horizontal): Update.
3382         (tui_source_window_base::set_is_exec_point_at): Rename from
3383         tui_set_is_exec_point_at.
3384         (tui_update_all_breakpoint_info): Update.
3385         * tui/tui-stack.c (tui_show_frame_info): Update.
3386         * tui/tui-layout.c (show_data): Add cast.
3387         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3388         * tui/tui-data.h (struct tui_source_window_base) <refill,
3389         set_is_exec_point_at>: New methods.
3390         (tui_source_windows, tui_add_to_source_windows): Update types.
3391         (tui_add_to_source_windows): Remove redundant declaration.
3392         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3393         (tui_source_windows): Change return type.
3394         (tui_clear_source_windows_detail): Update.
3395         (tui_add_to_source_windows): Change type of parameter.
3396         (tui_free_all_source_wins_content): Update.
3397
3398 2019-06-25  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-wingeneral.c (tui_win_info::refresh)
3401         (tui_source_window_base::refresh): New methods.
3402         (tui_refresh_all): Call the refresh method.
3403         * tui/tui-data.h (struct tui_win_info)
3404         (struct tui_source_window_base) <refresh>: New method.
3405
3406 2019-06-25  Tom Tromey  <tom@tromey.com>
3407
3408         * tui/tui.h (tui_is_window_visible): Return bool.
3409         * tui/tui.c (tui_is_window_visible): Return bool.
3410         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3411         (tui_make_visible, tui_make_invisible)
3412         (tui_win_info::make_visible)
3413         (tui_source_window_base::make_visible, make_all_visible)
3414         (tui_make_all_visible, tui_make_all_invisible): Update.
3415         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3416         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3417         bool.
3418         (struct tui_win_info, struct tui_source_window_base)
3419         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3420         * tui/tui-data.c (tui_init_generic_part): Update.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3425         (tui_source_window_base::make_visible): New methods.
3426         (make_all_visible): Make method call.
3427         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3428         (struct tui_source_window_base, struct tui_cmd_window): Override
3429         make_visible.
3430         (tui_win_is_source_type): Don't declare.
3431         * tui/tui-data.c (tui_win_is_source_type): Remove.
3432
3433 2019-06-25  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3436         NULL check.
3437
3438 2019-06-25  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3441         Inline constructor.  Add initializers for members.
3442         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3443         constructors; now inline in class.
3444
3445 2019-06-25  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-regs.c (tui_show_registers): Update.
3448         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3449         bool.
3450         * tui/tui-data.c (tui_data_window::clear_detail)
3451         (tui_data_window): Update.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-windata.c (tui_display_all_data)
3456         (tui_display_data_from_line, tui_display_data_from)
3457         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3458         Update.
3459         * tui/tui-regs.c (tui_last_regs_line_no)
3460         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3461         (tui_show_registers, tui_show_register_group)
3462         (tui_display_registers_from, tui_display_reg_element_at_line)
3463         (tui_display_registers_from_line, tui_check_register_values)
3464         (tui_reg_next, tui_reg_prev): Update.
3465         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3466         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3467         tui_data_window.
3468         (struct tui_win_info) <detail>: Remove.  Add new fields from
3469         tui_data_info.
3470         (TUI_DATA_WIN): Add cast.
3471         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3472         (~tui_data_window): Simplify.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-layout.c (show_source_disasm_command)
3477         (show_source_or_disasm_and_command): Update.
3478         * tui/tui-io.c (update_cmdwin_start_line)
3479         (tui_redisplay_readline): Update.
3480         * tui/tui-data.h (struct tui_command_info): Remove.
3481         (struct tui_win_info) <detail>: Remove command_info member.
3482         (struct tui_data_window) <start_line>: New member, from
3483         tui_command_info.
3484         (TUI_CMD_WIN): Add casts.
3485
3486 2019-06-25  Tom Tromey  <tom@tromey.com>
3487
3488         * tui/tui-winsource.c (tui_update_source_window)
3489         (tui_refill_source_window)
3490         (tui_source_window_base::do_scroll_horizontal)
3491         (tui_update_breakpoint_info, tui_set_exec_info_content)
3492         (tui_show_exec_info_content, tui_erase_exec_info_content)
3493         (tui_clear_exec_info_content): Update.
3494         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3495         Update.
3496         * tui/tui-win.c (make_invisible_and_set_new_height)
3497         (make_visible_with_new_height): Update.
3498         * tui/tui-source.c (tui_set_source_content)
3499         (tui_show_symtab_source): Update.
3500         * tui/tui-layout.c (extract_display_start_addr)
3501         (show_source_disasm_command, show_data)
3502         (make_source_or_disasm_window)
3503         (show_source_or_disasm_and_command): Update.
3504         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3505         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3506         "gdbarch".
3507         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3508         to tui_source_window_base.
3509         (struct tui_win_info) <detail>: Remove source_info member.
3510         (struct tui_source_window_base) <has_locator>: Inline.
3511         Move contents from tui_source_info; rename has_locator member to
3512         m_has_locator.
3513         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3514         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3515         header file.
3516         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3517         Simplify.
3518         (tui_free_all_source_wins_content): Cast to
3519         tui_source_window_base.
3520
3521 2019-06-25  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-win.c (make_invisible_and_set_new_height)
3524         (make_visible_with_new_height): Call has_locator method.
3525         * tui/tui-layout.c (show_source_disasm_command, show_data)
3526         (show_source_or_disasm_and_command): Update for bool change.
3527         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3528         (tui_win_info) <has_locator>: New method.
3529         (struct tui_source_window_base) <has_locator>: New method.
3530         (tui_win_has_locator): Don't declare.
3531         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3532         from tui_win_has_locator.
3533         (tui_source_window_base): Use false, not FALSE.
3534
3535 2019-06-25  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3538         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3539         clear_detail method directly.
3540         (tui_clear_win_detail): Remove.
3541
3542 2019-06-25  Tom Tromey  <tom@tromey.com>
3543
3544         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3545         "this", not TUI_DISASM_WIN.
3546
3547 2019-06-25  Tom Tromey  <tom@tromey.com>
3548
3549         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3550         declare.
3551         * tui/tui-winsource.c
3552         (tui_source_window_base::do_scroll_horizontal): Rename from
3553         tui_horizontal_source_scroll.
3554         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3555         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3556         from tui_vertical_data_scroll.
3557         * tui/tui-win.h (tui_scroll): Don't declare.
3558         * tui/tui-win.c (tui_win_info::forward_scroll)
3559         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3560         (tui_win_info::right_scroll): Rename and update.
3561         (tui_scroll_forward_command, tui_scroll_backward_command)
3562         (tui_scroll_left_command, tui_scroll_right_command): Update.
3563         (tui_scroll): Remove.
3564         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3565         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3566         from tui_vertical_source_scroll.
3567         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3568         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3569         from tui_vertical_disassem_scroll.
3570         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3571         do_scroll_horizontal>: New methods.
3572         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3573         Likewise.
3574         (struct tui_source_window_base): Add do_scroll_horizontal.
3575         (struct tui_source_window, struct tui_disasm_window): Add
3576         do_scroll_vertical.
3577         (struct tui_data_window, struct tui_cmd_window): Add
3578         do_scroll_horizontal and do_scroll_vertical.
3579         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3580
3581 2019-06-25  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-data.h (struct tui_source_window_base): New struct.
3584         (struct tui_source_window): Derive from tui_source_window_base.
3585         (struct tui_disasm_window): New struct.
3586         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3587         from tui_source_window::clear_detail.
3588         (tui_source_window_base): Rename from tui_source_window.
3589         (~tui_source_window_base): Rename from ~tui_source_window.
3590         (tui_alloc_win_info): Create a tui_disasm_window.
3591
3592 2019-06-25  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-data.h (struct tui_source_window)
3595         (struct tui_data_window): Declare destructors.
3596         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3597         destructors.
3598         (tui_win_info): Simplify.
3599
3600 2019-06-25  Tom Tromey  <tom@tromey.com>
3601
3602         * tui/tui-winsource.c (tui_display_main)
3603         (tui_update_source_windows_with_addr)
3604         (tui_update_all_breakpoint_info): Update.
3605         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3606         (new_height_ok, parse_scrolling_args): Update.
3607         * tui/tui-stack.c (tui_show_frame_info): Update.
3608         * tui/tui-data.h (struct tui_list): Remove.
3609         (tui_source_windows): Return a reference to a std::vector.
3610         * tui/tui-data.c (source_windows): Now a std::vector.
3611         (tui_source_windows): Change return type.
3612         (tui_clear_source_windows): Rewrite.
3613         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3614         (tui_free_all_source_wins_content): Rewrite.
3615
3616 2019-06-25  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3619         (struct tui_data_window, struct tui_cmd_window): Declare
3620         clear_detail method.
3621         * tui/tui-data.c (tui_source_window::clear_detail)
3622         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3623         methods.
3624         (tui_clear_win_detail): Simplify.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-layout.c (make_source_window, make_disasm_window)
3629         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3630         Return the new window.
3631         (show_source_disasm_command, show_data)
3632         (show_source_or_disasm_and_command): Update.
3633
3634 2019-06-25  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3637         parameter.  Return the new window.
3638         (show_source_disasm_command): Update and remove NULL check.
3639         (show_source_or_disasm_and_command): Update.
3640
3641 2019-06-25  Tom Tromey  <tom@tromey.com>
3642
3643         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-data.h (struct tui_win_info): Make constructor
3648         protected.  Make destructor virtual.  Add initializers.
3649         (tui_source_window, tui_data_window, tui_cmd_window): New
3650         classes.
3651         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3652         constructor.  Add "type" parameter.
3653         (tui_source_window, tui_data_window, tui_cmd_window): New
3654         constructors.
3655         (tui_alloc_win_info): Instantiate the appropriate subclass.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-win.c (tui_resize_all): Use delete.
3660         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3661         destructor.
3662         (tui_free_window): Don't declare.
3663         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3664         Update.
3665
3666 2019-06-25  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-data.h (struct tui_win_info): Add constructor.
3669         * tui/tui-data.c (tui_alloc_win_info): Use new.
3670         (tui_free_window): Use delete.
3671
3672 2019-06-22  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3675         declare.
3676         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3677
3678 2019-06-22  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3681         declare.
3682         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3683
3684 2019-06-22  Tom de Vries  <tdevries@suse.de>
3685
3686         * dwarf2read.c (create_addrmap_from_aranges)
3687         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3688         instead of '%zu'.
3689
3690 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3691
3692         * dwarf2read.h (dwarf2_section_info_def): Remove.
3693         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3694         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3695         std::vector<dwarf2_section_info>.
3696         (struct dwo_file) <~dwo_file>: Remove.
3697         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3698         types field.
3699         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3700         (dwarf2_read_debug_names): Likewise.
3701         (create_debug_types_hash_table): Change parameter type to
3702         array_view, adjust code accordingly.
3703         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3704         (partial_die_info::fixup): Likewise.
3705         (determine_prefix): Likewise.
3706         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3707
3708 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3709
3710         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3711         gdb_bfd_ref_ptr.
3712         <~dwo_file>: Remove call to gdb_bfd_unref.
3713         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3714         gdb_bfd_ref_ptr::get.
3715
3716 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3717
3718         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3719         type to htab_up.
3720         * dwarf2read.c (struct dwo_file): Initialize fields.
3721         <~dwo_file>: New.
3722         (free_dwo_file): Remove, move content to ~dwo_file.
3723         (struct dwo_file_deleter): Remove.
3724         (dwo_file_up>: Remove custom deleter.
3725         (free_dwo_files): Remove.
3726         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3727         dwo_files.
3728         (process_skeletonless_type_units): Call unique_ptr::get.
3729         (allocate_dwo_file_hash_table): Add deleter to created hash
3730         table.  Change return type to htab_up.
3731         (lookup_dwo_file_slot): Don't memset dwo_file, call
3732         unique_ptr::get.
3733         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3734         (create_dwo_unit_in_dwp_v2): Likewise.
3735         (open_and_init_dwo_file): Likewise.
3736         (free_dwo_file_from_slot): Remove.
3737
3738 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3739
3740         * dwarf2read.h (struct dwarf2_section_info) <readin,
3741         is_virtual>: Change type to bool.
3742         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3743         true instead of 1.
3744
3745 2019-06-19  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui-data.h (tui_init_content_element): Don't declare.
3748
3749 2019-06-19  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-data.h (tui_init_win_info): Don't declare.
3752
3753 2019-06-19  Tom de Vries  <tdevries@suse.de>
3754
3755         * dwarf2read.h (abstract_to_concrete): Change type to
3756         std::unordered_map<sect_offset, std::vector<sect_offset>,
3757         gdb::hash_enum<sect_offset>>.
3758
3759 2019-06-19  Tom Tromey  <tromey@adacore.com>
3760
3761         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3762         EVAL_AVOID_SIDE_EFFECTS specially.
3763
3764 2019-06-19  Tom Tromey  <tromey@adacore.com>
3765
3766         * source-cache.c (highlighter): New global.
3767         (source_cache::get_source_lines): Create a highlighter on demand.
3768
3769 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * defs.h (deprecated_interactive_hook): Delete declaration.
3772         * interps.c (clear_interpreter_hooks): Remove use of
3773         deprecated_interactive_hook.
3774         * top.c (deprecated_interactive_hook): Delete definition.
3775         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3776
3777 2019-06-18  Tom de Vries  <tdevries@suse.de>
3778
3779         PR gdb/24515
3780         * dwarf2read.h (abstract_to_concrete): Change type from
3781         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3782         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3783         * dwarf2read.c (read_variable): Update.
3784         (dwarf2_fetch_die_loc_sect_off): Update.
3785
3786 2019-06-17  Tom de Vries  <tdevries@suse.de>
3787
3788         PR gdb/24617
3789         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3790         accessing parent[parent_len - 1].
3791
3792 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3793
3794         PR gdb/24364
3795         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3796         call dtrace_process_dof with NULL dof.
3797
3798 2019-06-16  Tom de Vries  <tdevries@suse.de>
3799
3800         PR gdb/24445
3801         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3802
3803 2019-06-16  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3806         (make_all_visible): Use address of member.
3807
3808 2019-06-16  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3811         (tui_free_window, free_content, free_content_elements): Remove
3812         unnecessary cast.
3813         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3814         cast.
3815         * tui/tui-regs.c (tui_show_register_group)
3816         (tui_display_registers_from, tui_display_reg_element_at_line):
3817         Remove unnecessary cast.
3818
3819 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * linux-nat.c (normal_mask): Delete.
3822         (_initialize_linux_nat): Don't initialise normal_mask.
3823
3824 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3825
3826         PR gdb/24445
3827         * dwarf-index-write.h (write_psymtabs_to_index): Add
3828         dwz_basename parameter.
3829         * dwarf-index-write.c (write_gdbindex): Move file writing to
3830         write_gdbindex_1.  Change return type void.
3831         (assert_file_size): Move up, remove filename parameter.
3832         (write_gdbindex_1): New function.
3833         (write_debug_names): Change return type to void, call
3834         assert_file_size.
3835         (struct index_wip_file): New struct.
3836         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3837         file logic to index_wip_file.  Write index for dwz file if
3838         needed.
3839         (save_gdb_index_command): Pass basename of dwz file, if present.
3840         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3841         build-id of dwz file, if present.
3842         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3843         (dwarf2_get_dwz_file): Likewise.
3844         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3845         (dwarf2_get_dwz_file): Likewise.
3846
3847 2019-06-16  Tom Tromey  <tom@tromey.com>
3848
3849         * coffread.c (process_coff_symbol): Use xstrdup.
3850         * value.c (create_internalvar): Use xstrdup.
3851
3852 2019-06-16  Tom Tromey  <tom@tromey.com>
3853
3854         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3855         * breakpoint.c (stopin_command, stopat_command)
3856         (until_break_command, decode_location_default): Remove unnecessary
3857         cast.
3858         * utils.c (subset_compare): Remove unnecessary cast.
3859         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3860         cast.
3861         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3862         cast.
3863         * infcmd.c (path_command): Remove unnecessary cast.
3864         * coffread.c (decode_type): Remove unnecessary cast.
3865         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3866         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3867         * tui/tui-stack.c (tui_show_locator_content)
3868         (tui_show_frame_info): Remove unnecessary cast.
3869         * tui/tui-win.c (tui_scroll_forward_command)
3870         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3871         (parse_scrolling_args): Remove unnecessary cast.
3872         * tui/tui-data.c (init_win_info, tui_del_window)
3873         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3874         (free_content_elements): Remove unnecessary cast.
3875         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3876         unnecessary cast.
3877         * tui/tui-source.c (tui_set_source_content)
3878         (tui_vertical_source_scroll): Remove unnecessary cast.
3879         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3880         cast.
3881         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3882         * tui/tui-regs.c (tui_display_registers_from)
3883         (tui_display_register): Remove unnecessary cast.
3884         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3885         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3886         (make_visible): Remove unnecessary cast.
3887         * tui/tui-winsource.c (tui_erase_source_content)
3888         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3889         unnecessary cast.
3890         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3891         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3892         * stabsread.c (read_type, read_array_type, read_range_type):
3893         Remove unnecessary cast.
3894         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3895         (parse_symbol, parse_type, upgrade_type, parse_external)
3896         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3897         unnecessary cast.
3898         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3899
3900 2019-06-16  Tom Tromey  <tom@tromey.com>
3901
3902         * tui/tui-data.c (tui_alloc_generic_win_info)
3903         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3904         checks.
3905
3906 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3907             Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * f-typeprint.c (f_print_type): Don't return early for not
3910         associated or not allocated types.
3911         (f_type_print_varspec_suffix): Add print_rank parameter and print
3912         ranks of array types in case they dangling.
3913         (f_type_print_base): Add print_rank parameter.
3914
3915 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * NEWS: Mention new MI commands.
3918         * break-catch-throw.c (enum exception_event_kind): Move to
3919         breakpoint.h.
3920         (print_mention_exception_catchpoint): Output text as a single
3921         message.
3922         (catch_exception_command_1): Rename to...
3923         (catch_exception_event): ...this, make non-static, update header
3924         command, and change some parameter types.
3925         (catch_catch_command): Update for changes to
3926         catch_exception_command_1.
3927         (catch_throw_command): Likewise.
3928         (catch_rethrow_command): Likewise.
3929         * breakpoint.c (enum exception_event_kind): Delete.
3930         * breakpoint.h (enum exception_event_kind): Moved here from
3931         break-catch-throw.c.
3932         (catch_exception_event): Declare.
3933         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3934         (mi_cmd_catch_throw): New function.
3935         (mi_cmd_catch_rethrow): New function.
3936         (mi_cmd_catch_catch): New function.
3937         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3938         'catch-catch' entries.
3939         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3940         (mi_cmd_catch_rethrow): Declare.
3941         (mi_cmd_catch_catch): Declare.
3942
3943 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3944
3945         * annotate.c (annotate_source_line): Change return type to void,
3946         update implementation to match.
3947         * annotate.h (annotate_source_line): Change return type to void,
3948         update header comment.
3949         * stack.c (print_frame_info): Don't change what frame information
3950         is printed based on whether annotations are on or not.
3951
3952 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3953
3954         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3955         (annotate_source): Make static.
3956         (annotate_source_line): Moved from source.c and renamed from
3957         identify_source_line.  Update the return type.
3958         * annotate.h (annotate_source): Delete declaration.
3959         (annotate_source_line): Declaration moved from source.h, and
3960         renamed from identify_source_line.  Return type updated.
3961         * source.c (identify_source_line): Moved to annotate.c and renamed
3962         to annotate_source_line.
3963         (info_line_command): Remove check of annotation_level.
3964         * source.h (identify_source_line): Move declaration to annotate.h
3965         and rename to annotate_source_line.
3966         * stack.c: Add 'annotate.h' include.
3967         (print_frame_info): Remove check of annotation_level before
3968         calling annotate_source_line.
3969
3970 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3971
3972         * source-cache.c (source_cache::get_plain_source_lines): Use
3973         open_source_file_with_line_charpos instead of just
3974         open_source_file, remove call to find_source_lines.
3975         (source_cache::get_source_lines): Likewise.
3976         * source.c (find_source_lines): Make static.
3977         (get_filename_and_charpos): Renamed into...
3978         (open_source_file_with_line_charpos): ..this along with changes to
3979         return a scoped_fd, and some other minor clean ups.
3980         (identify_source_line): Use open_source_file_with_line_charpos.
3981         (search_command_helper): Use open_source_file_with_line_charpos
3982         instead of just open_source_file, remove call to
3983         find_source_lines.
3984         * source.h (open_source_file_with_line_charpos): Declare new
3985         function.
3986         (find_source_lines): Delete declaration.
3987
3988 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3989
3990         * source.c (get_filename_and_charpos): Remove fullname
3991         parameter.
3992         (identify_source_line): Update call to get_filename_and_charpos.
3993
3994 2019-06-14  Tom Tromey  <tromey@adacore.com>
3995
3996         PR gdb/24502:
3997         * ui-style.h (skip_ansi_escape): Update comment.
3998         * ui-file.h (class no_terminal_escape_file): New class.
3999         * ui-file.c (no_terminal_escape_file::write)
4000         (no_terminal_escape_file::puts): New methods.
4001         * cli/cli-logging.c (handle_redirections): Use
4002         no_terminal_escape_file.
4003
4004 2019-06-14  Tom Tromey  <tromey@adacore.com>
4005
4006         * NEWS: Move convenience variable news above Python news.
4007
4008 2019-06-14  Tom Tromey  <tom@tromey.com>
4009
4010         * gnulib: Move directory to top-level.
4011         * configure.ac: Don't configure gnulib.
4012         * configure: Rebuild.
4013         * common/common-defs.h: Use new path to gnulib.
4014         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4015         (GNULIB_H): Remove.
4016         (INCGNU): Look in new gnulib location.
4017         (HFILES_NO_SRCDIR): Remove gnulib files.
4018         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4019         (generated_files): Remove GNULIB_H.
4020         ($(LIBGNU), all-lib): Remove targets.
4021         (distclean): Don't mention GNULIB_BUILDDIR.
4022         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4023
4024 2019-06-14  Tom Tromey  <tromey@adacore.com>
4025
4026         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4027         Warn if symbol file does not provide any symbols.
4028
4029 2019-06-14  Tom Tromey  <tromey@adacore.com>
4030
4031         * source.c (find_and_open_source): Respect basenames_may_differ.
4032
4033 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * annotate.c (annotate_breakpoints_invalid): Make use of
4036         scoped_restore_terminal_state.
4037         (annotate_frames_invalid): Likewise.
4038
4039 2019-06-14  Tom Tromey  <tromey@adacore.com>
4040
4041         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4042         allow assignment to an internalvar.
4043
4044 2019-06-14  Tom Tromey  <tromey@adacore.com>
4045
4046         * ada-lex.l: Allow "_" in attribute names.
4047
4048 2019-06-14  Tom Tromey  <tromey@adacore.com>
4049
4050         PR gdb/24653:
4051         * regcache.c (registers_changed): Don't call alloca.
4052         * top.c (execute_command): Don't call alloca.
4053
4054 2019-06-13  Pedro Alves  <palves@redhat.com>
4055
4056         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4057         'expression'.  When parsing an expression, error out if there's
4058         junk after "unlimited".
4059         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4060         (do_set_command): Adjust calls to is_unlimited_literal.
4061
4062 2019-06-13  Pedro Alves  <palves@redhat.com>
4063
4064         * compile/compile.c (make_compile_options_def_group): Add braces
4065         around array_view initializer.
4066         * thread.c (make_thread_apply_all_options_def_group)
4067         (make_thread_apply_all_options_def_group): Likewise.
4068
4069 2019-06-13  Pedro Alves  <palves@redhat.com>
4070
4071         * NEWS (New commands): Mention "maint test-options
4072         require-delimiter", "maint test-options unknown-is-error", "maint
4073         test-options unknown-is-operand" and "maint show
4074         test-options-completion-result".
4075         (New command options, command completion): New section.
4076         (Completion improvements): New section.
4077         Mention that you can abbreviate "unlimited".
4078
4079 2019-06-13  Pedro Alves  <palves@redhat.com>
4080
4081         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4082         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4083         * unittests/cli-utils-selftests.c (test_parse_flags)
4084         (test_parse_flags_qcs): Delete.
4085         (test_cli_utils): Don't call deleted functions.
4086
4087 2019-06-13  Pedro Alves  <palves@redhat.com>
4088
4089         * thread.c: Include "cli/cli-option.h".
4090         (tp_array_compar_ascending): Global.
4091         (tp_array_compar): Delete function.
4092         (tp_array_compar_ascending, tp_array_compar_descending): New
4093         functions.
4094         (ascending_option_def, qcs_flag_option_def)
4095         (thr_qcs_flags_option_defs)
4096         (make_thread_apply_all_options_def_group)
4097         (make_thread_apply_options_def_group): New.
4098         (thread_apply_all_command): Use gdb::option::process_options.
4099         (thread_apply_command_completer)
4100         (thread_apply_all_command_completer): New.
4101         (thread_apply_command): Use gdb::option::process_options.
4102         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4103         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4104         to generate help text of "thread apply".  Adjust "taas"'s help.
4105         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4106         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4107
4108 2019-06-13  Pedro Alves  <palves@redhat.com>
4109
4110         * thread.c (thread_apply_command): Check for invalid TID with
4111         isdigit instead of !isalpha.
4112
4113 2019-06-13  Pedro Alves  <palves@redhat.com>
4114
4115         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4116         (validate_flags_qcs): New.
4117         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4118         (validate_flags_qcs): Declare.
4119         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4120         (make_frame_apply_options_def_group): New.
4121         (frame_apply_command_count): Process options with
4122         gdb::option::process_options.
4123         (frame_apply_completer): New.
4124         (frame_apply_level_completer, frame_apply_all_completer)
4125         (frame_apply_completer): New.
4126         (_initialize_stack): Update help of "frame apply", "frame apply
4127         level", "frame apply all" and "faas" to mention supported options
4128         and install command completers.
4129         * stack.h (frame_apply_all_completer): Declare.
4130         * thread.c: Include "stack.h".
4131         (tfaas_command): Add "--".
4132         (_initialize_thread): Update help "tfaas" to mention supported
4133         options and install command completer.
4134
4135 2019-06-13  Pedro Alves  <palves@redhat.com>
4136
4137         * completer.c (complete_nested_command_line): New.
4138         (gdb_completion_word_break_characters_throw): Add assertion.
4139         * completer.h (complete_nested_command_line): Declare.
4140
4141 2019-06-13  Pedro Alves  <palves@redhat.com>
4142
4143         * stack.c (parse_backtrace_qualifiers): New.
4144         (backtrace_command): Use it.
4145         (backtrace_command_completer): Complete on qualifiers.
4146
4147 2019-06-13  Pedro Alves  <palves@redhat.com>
4148
4149         * frame.c: Include "cli/cli-option.h.
4150         (user_set_backtrace_options): New.
4151         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4152         Delete.
4153         (get_prev_frame): Adjust.
4154         (boolean_option_def, uinteger_option_def)
4155         (set_backtrace_option_defs): New.
4156         (_initialize_frame): Adjust and use
4157         gdb::option::add_setshow_cmds_for_options to install "set
4158         backtrace past-main" and "set backtrace past-entry".
4159         * frame.h: Include "cli/cli-option.h".
4160         (struct frame_print_options): Forward declare.
4161         (print_frame_arguments_all, print_frame_arguments_scalars)
4162         (print_frame_arguments_none): Declare.
4163         (print_entry_values): Delete declaration.
4164         (struct frame_print_options, user_frame_print_options): New.
4165         (struct set_backtrace_options): New.
4166         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4167         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4168         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4169         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4170         (list_args_or_locals): Add frame_print_options parameter.
4171         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4172         * python/py-framefilter.c (enumerate_args): Pass down
4173         USER_FRAME_PRINT_OPTIONS.
4174         * stack.c: Include "cli/cli-option.h".
4175         (print_frame_arguments_all, print_frame_arguments_scalars)
4176         (print_frame_arguments_none): Declare.
4177         (print_raw_frame_arguments, print_entry_values): Delete.
4178         (user_frame_print_options): New.
4179         (boolean_option_def, enum_option_def, frame_print_option_defs):
4180         New.
4181         (struct backtrace_cmd_options): New.
4182         (bt_flag_option_def): New.
4183         (backtrace_command_option_defs): New.
4184         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4185         (print_frame_arg, read_frame_arg, print_frame_args)
4186         (print_frame_info, print_frame): Add frame_print_options parameter
4187         and use it.
4188         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4189         (backtrace_command_1): Add frame_print_options and
4190         backtrace_cmd_options parameters and use them.
4191         (make_backtrace_options_def_group): New.
4192         (backtrace_command): Process command options with
4193         gdb::option::process_options.
4194         (backtrace_command_completer): New.
4195         (_initialize_stack): Extend "backtrace"'s help to mention
4196         supported options.  Install completer for "backtrace".
4197         Install some settings commands with add_setshow_cmds_for_options.
4198
4199 2019-06-13  Pedro Alves  <palves@redhat.com>
4200
4201         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4202         and that "set/show print raw frame-arguments" are now deprecated.
4203
4204         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4205         command.
4206         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4207         * stack.c (_initialize_stack): Install "set/show print
4208         raw-frame-arguments", and deprecate "set/show print raw
4209         frame-arguments".
4210         * valprint.c (_initialize_valprint): Deprecate "set/show print
4211         raw".
4212
4213 2019-06-13  Pedro Alves  <palves@redhat.com>
4214
4215         * compile/compile.c (struct compile_options): New.
4216         (compile_flag_option_def, compile_command_option_defs)
4217         (make_compile_options_def_group): New.
4218         (compile_file_command): Handle options with
4219         gdb::option::process_options.
4220         (compile_file_command_completer): New function.
4221         (compile_code_command): Handle options with
4222         gdb::option::process_options.
4223         (compile_code_command_completer): New function.
4224         (_initialize_compiler): Install completers for "compile code" and
4225         "compile file".  Mention available options in "compile code" and
4226         "compile code"'s help.
4227         * completer.c (advance_to_completion_word): New, factored out from
4228         ...
4229         (advance_to_expression_complete_word_point): ... this.
4230         (advance_to_filename_complete_word_point): New.
4231         * completer.h (advance_to_filename_complete_word_point): New
4232         declaration.
4233
4234 2019-06-13  Pedro Alves  <palves@redhat.com>
4235
4236         * compile/compile.c: Include "cli/cli-option.h".
4237         (compile_print_value): Scope data pointer is now a
4238         value_print_options pointer; adjust.
4239         (compile_print_command): Process options.  Scope data pointer is
4240         now a value_print_options pointer; adjust.
4241         (_initialize_compile): Update "compile print"'s help to include
4242         supported options.  Install a completer for "compile print".
4243         * cp-valprint.c (show_vtblprint, show_objectprint)
4244         (show_static_field_print): Delete.
4245         (_initialize_cp_valprint): Don't install "set print
4246         static-members", "set print vtbl", "set print object" here.
4247         * printcmd.c: Include "cli/cli-option.h" and
4248         "common/gdb_optional.h".
4249         (print_command_parse_format): Rework to fill in a
4250         value_print_options instead of a format_data.
4251         (print_value): Change parameter type from format_data pointer to
4252         value_print_options reference.  Adjust.
4253         (print_command_1): Process options.  Adjust to pass down a
4254         value_print_options.
4255         (print_command_completer): New.
4256         (_initialize_printcmd): Install print_command_completer as
4257         handle_brkchars completer for the "print" command.  Update
4258         "print"'s help to include supported options.
4259         * valprint.c: Include "cli/cli-option.h".
4260         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4261         here from cp-valprint.c.
4262         (boolean_option_def, uinteger_option_def)
4263         (value_print_option_defs, make_value_print_options_def_group):
4264         New.  Use gdb::option::add_setshow_cmds_for_options to install
4265         "set print elements", "set print null-stop", "set print repeats",
4266         "set print pretty", "set print union", "set print array", "set
4267         print address", "set print symbol", "set print array-indexes".
4268         * valprint.h: Include <string> and "cli/cli-option.h".
4269         (make_value_print_options_def_group): Declare.
4270         (print_value): Change parameter type from format_data pointer to
4271         value_print_options reference.
4272         (print_command_completer): Declare.
4273
4274 2019-06-13  Pedro Alves  <palves@redhat.com>
4275
4276         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4277         (COMMON_SFILES): Add maint-test-settings.c.
4278         * cli/cli-decode.c (boolean_enums): New global, factored out from
4279         ...
4280         (add_setshow_boolean_cmd): ... here.
4281         * cli/cli-decode.h (boolean_enums): Declare.
4282         * cli/cli-option.c: New file.
4283         * cli/cli-option.h: New file.
4284         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4285         factored out from ...
4286         (parse_cli_boolean_value(const char *)): ... this.
4287         (is_unlimited_literal): Change parameter type to pointer to
4288         pointer.  Adjust and advance ARG pointer.
4289         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4290         (parse_cli_var_enum): New, factored out from ...
4291         (do_set_command): ... this.  Adjust.
4292         * cli/cli-setshow.h (parse_cli_boolean_value)
4293         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4294         (parse_cli_var_enum): Declare.
4295         * cli/cli-utils.c: Include "cli/cli-option.h".
4296         (get_ulongest): New.
4297         * cli/cli-utils.h (get_ulongest): Declare.
4298         (check_for_argument): New overloads.
4299         * maint-test-options.c: New file.
4300
4301 2019-06-13  Pedro Alves  <palves@redhat.com>
4302
4303         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4304         parse a range if "-" is at the end of the string.
4305
4306 2019-06-13  Pedro Alves  <palves@redhat.com>
4307
4308         * cli/cli-setshow.c (parse_auto_binary_operation)
4309         (parse_cli_boolean_value): Don't allow "o".
4310
4311 2019-06-13  Pedro Alves  <palves@redhat.com>
4312
4313         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4314         * NEWS: Mention maint test-settings KIND.
4315         * maint-test-settings.c: New file.
4316
4317 2019-06-13  Pedro Alves  <palves@redhat.com>
4318
4319         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4320         completer.
4321         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4322         "set" completers.
4323
4324 2019-06-13  Pedro Alves  <palves@redhat.com>
4325
4326         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4327         after item.
4328
4329 2019-06-13  Pedro Alves  <palves@redhat.com>
4330
4331         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4332
4333 2019-06-13  Pedro Alves <palves@redhat.com>
4334
4335         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4336         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4337         call.
4338         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4339         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4340         calls.
4341         (check_for_argument): Skip spaces after argument.
4342
4343 2019-06-13  Pedro Alves  <palves@redhat.com>
4344
4345         * thread.c (thread_apply_command): Adjust TID parsing.
4346         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4347         detected before end of string.
4348         (tid_is_in_list): Error out if LIST is invalid.
4349
4350 2019-06-13  Pedro Alves  <palves@redhat.com>
4351
4352         * completer.c (complete_line_internal_1): Rewind completion word
4353         point.
4354         (completion_tracker::advance_custom_word_point_by): Change
4355         parameter type to int.
4356         * completer.h (completion_tracker::advance_custom_word_point_by):
4357         Likewise.
4358
4359 2019-06-13  Pedro Alves  <palves@redhat.com>
4360
4361         * completer.c (advance_to_completion_word): Handle delimiters.
4362
4363 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4364
4365         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4366
4367 2019-06-11  Tom Tromey  <tom@tromey.com>
4368
4369         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4370         (xmalloc_failed): Move to alloc.c.
4371         * alloc.c: New file.
4372         * Makefile.in (COMMON_SFILES): Add alloc.c.
4373
4374 2019-06-11  Tom Tromey  <tom@tromey.com>
4375
4376         * nat/linux-waitpid.c: Don't include server.h.
4377         (linux_debug): Remove.
4378         (my_waitpid): Update.
4379
4380 2019-06-11  Tom Tromey  <tromey@adacore.com>
4381
4382         * infcall.c (_initialize_infcall): Remove trailing newline from
4383         help.
4384         * user-regs.c (_initialize_user_regs): Remove trailing newline
4385         from help.
4386         * typeprint.c (_initialize_typeprint): Remove trailing newline
4387         from help.
4388         * reverse.c (_initialize_reverse): Remove trailing newlines from
4389         help.
4390         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4391         from help.
4392         * language.c (add_set_language_command): Remove trailing newline
4393         from help.
4394         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4395         help.
4396         * disasm.c (_initialize_disasm): Remove trailing newline from
4397         help.
4398         * top.c (init_main): Remove trailing newline from help.
4399         * interps.c (_initialize_interpreter): Remove trailing newline
4400         from help.
4401         * btrace.c (_initialize_btrace): Remove trailing newlines from
4402         help.
4403         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4404         from help.
4405         * python/python.c (_initialize_python): Remove trailing newline
4406         from help.
4407         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4408         help.
4409         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4410         from help.  Reformat some text.
4411         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4412         from help.
4413         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4414         newline from help.
4415
4416 2019-06-11  Tom Tromey  <tromey@adacore.com>
4417
4418         * darwin-nat.c (darwin_decode_exception_message)
4419         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4420
4421 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * valops.c (value_slice): Check for not allocated or not
4424         associated values.
4425
4426 2019-06-10  Tom de Vries  <tdevries@suse.de>
4427
4428         PR gdb/24618
4429         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4430         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4431         invalid.
4432
4433 2019-06-10  Tom de Vries  <tdevries@suse.de>
4434
4435         PR gdb/24611
4436         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4437         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4438
4439 2019-06-10  Tom de Vries  <tdevries@suse.de>
4440
4441         PR symtab/24545
4442         * symtab.c (struct demangled_name_entry): Add language field.
4443         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4444         static minimal symbol".  Set and use language field.
4445
4446 2019-06-10  Tom Tromey  <tromey@adacore.com>
4447
4448         * ada-lang.c (_initialize_ada_language): Update help text.
4449
4450 2019-06-10  Tom Tromey  <tromey@adacore.com>
4451
4452         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4453         with a newline.
4454         * guile/guile.c (handle_boot_error): Don't end warning with a
4455         newline.
4456         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4457         warning with a newline.
4458         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4459         newline.
4460         (s12z_frame_cache): Likewise.
4461         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4462         a newline.
4463         * solib-svr4.c (disable_probes_interface): Don't end warning with
4464         a newline.
4465         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4466         newline.
4467         * python/python.c (do_finish_initialization): Don't end warning
4468         with a newline.
4469
4470 2019-06-10  Tom Tromey  <tom@tromey.com>
4471
4472         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4473         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4474         gdbpy_enter.
4475
4476 2019-06-10  Tom Tromey  <tromey@adacore.com>
4477
4478         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4479         data.
4480         (elf_new_init): Don't call stabsread_new_init.
4481         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4482         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4483         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4484
4485 2019-06-10  Tom de Vries  <tdevries@suse.de>
4486
4487         PR symtab/16264
4488         PR symtab/24517
4489         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4490
4491 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4492
4493         * source.c (find_and_open_source): Also rewrite relative file
4494         names.
4495
4496 2019-04-26  Amos Bird  <amosbird@gmail.com>
4497
4498         * annotate.c (annotate_thread_exited): Add "thread-exited"
4499         annotation.
4500
4501 2019-06-06  Tom Tromey  <tromey@adacore.com>
4502
4503         * maint.h (class scoped_command_stats): Use
4504         DISABLE_COPY_AND_ASSIGN.
4505         <print_time>: New method.
4506         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4507         print_time.
4508         (scoped_command_stats::print_time): New method.
4509
4510 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4511
4512         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4513         instructions of lengths 6 or 8 bytes.
4514
4515 2019-06-04  Pedro Alves  <palves@redhat.com>
4516
4517         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4518
4519         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4520         * breakpoint.c (condition_completer): Likewise.
4521         * cli/cli-dump.c (scan_expression): Likewise.
4522         * common/filestuff.c (mkdir_recursive): Likewise.
4523         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4524         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4525         (gdb_abspath): Likewise.
4526         * compile/compile-cplus-types.c
4527         (compile_cplus_instance::decl_name): Likewise.
4528         * completer.c (complete_explicit_location):
4529         (signal_completer, reg_or_group_completer_1): Likewise.
4530         * cp-support.c (cp_remove_params_if_any): Likewise.
4531         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4532         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4533         * infcmd.c (strip_bg_char): Likewise.
4534         * linespec.c (copy_token_string): Likewise.
4535         * mi/mi-main.c (output_cores): Likewise.
4536         * psymtab.c (psymtab_search_name):
4537         * symfile.c (test_set_ext_lang_command): Likewise.
4538         * target.c (target_fileio_read_stralloc): Likewise.
4539         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4540         * value.c (complete_internalvar): Likewise.
4541
4542 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4543
4544         Add objfile property to gdb.Type.
4545         * NEWS: Mention Python API addition.
4546         * python/py-type.c (typy_get_objfile): New method.
4547
4548 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4549
4550         * NEWS: Mention the new set|show style [title|highlight].
4551         Mention changes to "show style", "help" and "apropos".
4552
4553 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4554
4555         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4556         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4557         instead of print_help_for_command.
4558         (print_doc_of_command): New function.
4559         (help_list): Add 'apropos -v word' suggestion.
4560         (print_help_for_command): Style the command name using title style.
4561         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4562         (_initialize_cli_cmds): Describe -v in apropos_command help.
4563
4564 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4565
4566         * cli/cli-style.h (cli_style_option): Add name in constructor,
4567         add m_name class member, add constructor with intensity,
4568         add name class function.
4569         (cli_style_option::add_setshow_commands): Remove name argument.
4570         (highlight_style, title_style): New styles.
4571         * cli/cli-style.c (do_show): New function that shows a style
4572         characteristic styling the style name with itself.
4573         (set_style_name): New function.
4574         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4575         Update all callers according to the changes in cli/cli-style.h.
4576         * utils.h (fputs_highlighted): New function.
4577         * utils.c (fputs_highlighted): Likewise.
4578
4579 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4580
4581         * NEWS: Mention new pipe command and new convenience variables.
4582
4583 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4584
4585         * cli/cli-cmds.c (pipe_command): New function.
4586         (_initialize_cli_cmds): Call add_com for pipe_command.
4587         Define | as an alias for pipe.
4588         (exit_status_set_internal_vars): New function.
4589         (shell_escape): Call exit_status_set_internal_vars.
4590         cli/cli-decode.c (find_command_name_length): Recognize | as
4591         a single character command.
4592
4593 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4594
4595         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4596         top.c (execute_command_to_ui_file): New function, mostly a copy
4597         of execute_command_to_string.
4598         (execute_command_to_string): Implement by calling
4599         execute_command_to_ui_file.
4600
4601 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4602
4603         * top.h (saved_command_line): Remove declaration.
4604         * top.c (previous_saved_command_line, previous_repeat_arguments):
4605         New variables.
4606         (saved_command_line): Make static, define together with other
4607         'repeat variables'.
4608         (dont_repeat): Clear repeat_arguments.
4609         (repeat_previous, get_saved_command_line, save_command_line):
4610         New functions.
4611         (gdb_init): Initialize saved_command_line
4612         and previous_saved_command_line.
4613         * main.c (captured_main_1): Remove saved_command_line initialization.
4614         * event-top.c (handle_line_of_input): Update to use
4615         the new 'repeat' related functions instead of direct access to
4616         saved_command_line.
4617         * command.h (repeat_previous, get_saved_command_line,
4618         save_command_line): New declarations.
4619         (dont_repeat): Add comment.
4620
4621 2019-05-30  Tom Tromey  <tromey@adacore.com>
4622
4623         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4624         Fix comment.
4625         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4626
4627 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4628
4629         PR cli/24587
4630         * completer.c (complete): Initialize variable word.
4631
4632 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4633
4634         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4635         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4636         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4637         'body' is NULL to the outter 'if', protecting the '!is_define'
4638         situation as well.
4639
4640 2019-05-29  Tom Tromey  <tromey@adacore.com>
4641
4642         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4643         (dwarf_unknown): New function.
4644         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4645         (dwarf_type_encoding_name): Use dwarf_unknown.
4646
4647 2019-05-29  Tom Tromey  <tromey@adacore.com>
4648
4649         PR c++/20020:
4650         * cp-valprint.c (cp_print_value_fields): Call
4651         cp_print_static_field inside "try".
4652
4653 2019-05-29  Tom Tromey  <tromey@adacore.com>
4654
4655         * inflow.c (struct terminal_info): Add default operator=.
4656         * configure: Rebuild.
4657         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4658         -Wdeprecated-copy-dtor, -Wredundant-move.
4659
4660 2019-05-29  Tom Tromey  <tromey@adacore.com>
4661
4662         * NEWS: Add entry.
4663         * infcmd.c (print_return_value_1): Handle finish_print
4664         option.
4665         (show_print_finish): New function.
4666         (_initialize_infcmd): Add "set/show print finish" commands.
4667         * valprint.c (user_print_options): Initialize new member.
4668         * valprint.h (struct value_print_options) <finish_print>: New
4669         member.
4670
4671 2019-05-28  Tom Tromey  <tromey@adacore.com>
4672
4673         * ada-lang.c (ada_remove_Xbn_suffix)
4674         (find_old_style_renaming_symbol)
4675         (parse_old_style_renaming): Remove.
4676         (ada_find_renaming_symbol): Don't call
4677         find_old_style_renaming_symbol.
4678         (ada_is_renaming_symbol): Rename from
4679         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4680         bool.  Now static.
4681         (ada_read_var_value): Update and simplify.
4682         * ada-exp.y (write_var_or_type): Remove old code.
4683
4684 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4685
4686         * event-top.c: Remove include comment.
4687         * inflow.c (class scoped_ignore_sigttou): Move from here...
4688         * inflow.h (class scoped_ignore_sigttou): ...to here.
4689         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4690         * top.c:  Remove include comment.
4691
4692 2019-05-27  Tom Tromey  <tom@tromey.com>
4693
4694         * NEWS: Fix typo.
4695
4696 2019-05-22  Tom Tromey  <tromey@adacore.com>
4697
4698         * target.c (target_follow_exec): Constify parameter.
4699         * target-delegates.c: Rebuild.
4700         * remote.c (remote_target::follow_exec): Constify parameter.
4701         * infrun.c (follow_exec): Constify parameter.
4702         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4703         (target_follow_exec): Likewise.
4704
4705 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4706
4707         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4708         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4709
4710 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4711
4712         * NEWS: Add debugredirect and testsuite sections.
4713
4714 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4715
4716         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4717         target descriptions using exclusively floating point register name
4718         aliases.
4719
4720 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         PR gdb/18644:
4723         * f-lang.c (build_fortran_types): Handle the case where
4724         gdbarch_floatformat_for_type returns a nullptr.
4725
4726 2019-05-21  Tom de Vries  <tdevries@suse.de>
4727
4728         PR cli/24587
4729         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4730
4731 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4732
4733         PR gdb/18644:
4734         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4735         16-byte floats.
4736         * i386-tdep.c (i386_floatformat_for_type): Use
4737         floatformats_ia64_quad for the 16-byte floating point component
4738         within a fortran 32-byte complex number.
4739
4740 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4743         delete default constructor.
4744         (find_partial_die): Update to return const struct.
4745         (partial_die_parent_scope): Move variable declaration into scope
4746         of its use and change its type to auto.
4747         (guess_partial_die_structure_name): Likewise.
4748         (partial_die_info::fixup): Likewise.
4749
4750 2019-05-17  Tom Tromey  <tromey@adacore.com>
4751
4752         * source.c (find_and_open_source): Remove cast.
4753
4754 2019-05-17  Tom Tromey  <tromey@adacore.com>
4755
4756         * annotate.c (annotate_source): Make "filename" const.
4757         * annotate.h (annotate_source): Use const.
4758
4759 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4760
4761         * disasm.c (set_disassembler_options): Send errors to stderr.
4762
4763 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4764
4765         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4766         (cli_interp_base::set_logging): Check debug_redirect.
4767         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4768         * cli/cli-logging.c (debug_redirect): Add static variable.
4769         (pop_output_files): Add default param.
4770         (handle_redirections): Print debug setting.
4771         (show_logging_command): Likewise.
4772         (_initialize_cli_logging): Add debugredirect command.
4773         * interps.c (current_interp_set_logging): Add debug_redirect
4774         parameter.
4775         * interps.h (set_logging): Add debug_redirect parameter.
4776         (current_interp_set_logging): Likewise.
4777         * mi/mi-common.h: Likewise.
4778         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4779
4780 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4781             Tom Tromey  <tromey@adacore.com>
4782
4783         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4784         directly.
4785         * cli/cli-interp.h (make_logging_output): Remove declaration.
4786         * cli/cli-logging.c (make_logging_output): Remove function.
4787         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4788         directly.
4789         * ui-file.c (tee_file::tee_file): Remove bools.
4790         (tee_file::~tee_file): Remove deletes.
4791         * ui-file.h (tee_file): Remove bools.
4792
4793 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4794
4795         * mi/mi-cmds.h (mi_cmd_complete): New function.
4796         * mi/mi-main.c (mi_cmd_complete): Likewise.
4797         * mi/mi-cmds.c: Define new MI command -complete.
4798         * NEWS: Mention new -complete command.
4799
4800 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4801
4802         * completer.h (complete): New function.
4803         * completer.c (complete): Likewise.
4804         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4805         function defined in completer.h.
4806
4807 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4808
4809         * MAINTAINERS (Write After Approval): Add myself.
4810
4811 2019-05-17  Tom de Vries  <tdevries@suse.de>
4812
4813         PR gdb/24094
4814         * dwarf2read.c (struct cu_partial_die_info): New struct.
4815         (find_partial_die): Return cu_partial_die_info.
4816         (partial_die_parent_scope, guess_partial_die_structure_name)
4817         (partial_die_info::fixup): Handle new return type of find_partial_die.
4818
4819 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4820
4821         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4822         "std::string", simplifying the algorithm.
4823
4824 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4825
4826         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4827         (stap_static_probe_ops::get_probes): Likewise.
4828
4829 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4830
4831         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4832         '-')" and "else if".
4833         (stap_parse_single_operand): Join checks for
4834         "gdbarch_stap_parse_special_token_p" and
4835         "gdbarch_stap_parse_special_token" in the same "if" statement.
4836         Invert check when verifying for operation on register
4837         displacement.
4838
4839 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4840
4841         * stap-probe.c (stap_get_opcode): Update comment.
4842         (stap_get_expected_argument_type): Likewise.
4843         (handle_stap_probe): Likewise.
4844
4845 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4846
4847         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4848         return type to 'bool'.  Adjust comment.  Use 'bool' when
4849         appropriate.
4850         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4851         * stap-probe.c (stap_parse_argument_1): Likewise.
4852         (stap_is_operator): Likewise.
4853         (stap_is_generic_prefix): Likewise.
4854         (stap_is_register_prefix): Likewise.
4855         (stap_is_register_indirection_prefix): Likewise.
4856         (stap_is_integer_prefix): Likewise.
4857         (stap_generic_check_suffix): Likewise.
4858         (stap_check_integer_suffix): Likewise.
4859         (stap_check_register_suffix): Likewise.
4860         (stap_check_register_indirection_suffix): Likewise.
4861         (stap_parse_register_operand): Likewise.
4862         (stap_parse_single_operand): Likewise.
4863         (stap_parse_argument_1): Likewise.
4864         (stap_probe::get_argument_count): Likewise.
4865         (stap_is_operator): Likewise.
4866
4867 2019-05-16  Tom Tromey  <tromey@adacore.com>
4868
4869         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4870         keyword to foreach.
4871
4872 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4873
4874         * linux-thread-db.c (try_thread_db_load_1): Change return type
4875         to bool.
4876         (try_thread_db_load): Likewise.
4877         (try_thread_db_load_from_pdir_1): Likewise.
4878         (try_thread_db_load_from_pdir): Likewise.
4879         (try_thread_db_load_from_sdir): Likewise.
4880         (try_thread_db_load_from_dir): Likewise.
4881         (thread_db_load_search): Likewise.
4882         (has_libpthread): Likewise.
4883         (thread_db_load): Likewise.
4884
4885 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4886
4887         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4888         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4889         NULL, and complain/return if that's the case.
4890
4891 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4892
4893         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4894         (advance, posn, abstract_read_memory): New functions.
4895         [struct mem_read_abstraction]: New struct.
4896         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4897
4898 2019-05-14  Tom Tromey  <tromey@adacore.com>
4899
4900         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4901         value is not lval_memory.
4902
4903 2019-05-14  Tom Tromey  <tromey@adacore.com>
4904
4905         * solib.c (info_sharedlibrary_command): Style the file name.
4906
4907 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4910         (aarch64_vnv_type): Likewise.
4911         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4912         * common/tdesc.c: Likewise.
4913         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4914         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4915         * features/aarch64-fpu.xml: Add ieee half view.
4916         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4917         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4918         * gdbtypes.h (struct builtin_type): Likewise.
4919         (struct objfile_type): Likewise.
4920
4921 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4922
4923         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4924         typo.
4925         * location.h (string_to_event_location): Likewise.
4926
4927 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4928
4929         GDB 8.3 released.
4930
4931 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4932
4933         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4934         New variable declaration.
4935         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4936         New variable.
4937         (print_one_breakpoint): Use ui_out::test_flags and new global
4938         variable to compute use_fixed_output.
4939         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4940         Remove.
4941         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4942         (mi_multi_location_breakpoint_output_fixed): Remove.
4943         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4944         new variable.
4945         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4946         fix_multi_location_breakpoint_output flag if version >= 3.
4947         * ui-out.h (enum ui_out_flag)
4948         <fix_multi_location_breakpoint_output>: New enumerator.
4949
4950 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4953
4954 2019-05-10  Tom Tromey  <tromey@adacore.com>
4955
4956         * ada-lang.c (catch_ada_completer): New function.
4957         (_initialize_ada_language): Use it.
4958
4959 2019-05-10  Tom Tromey  <tromey@adacore.com>
4960
4961         * thread.c (print_thread_info): Make "requested_threads" const.
4962         * gdbthread.h (print_thread_info): Make "requested_threads"
4963         const.
4964         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4965         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4966
4967 2019-05-08  Tom Tromey  <tom@tromey.com>
4968
4969         * gdbtypes.c (objfile_type_data): Change type.
4970         (objfile_type, _initialize_gdbtypes): Update.
4971
4972 2019-05-08  Tom Tromey  <tom@tromey.com>
4973
4974         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4975         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4976         (_initialize_dwarf2_frame): Update.
4977
4978 2019-05-08  Tom Tromey  <tom@tromey.com>
4979
4980         * objc-lang.c (objc_objfile_data): Change type.
4981         (find_methods): Update.
4982         (_initialize_objc_lang): Remove.
4983
4984 2019-05-08  Tom Tromey  <tom@tromey.com>
4985
4986         * stabsread.c (rs6000_builtin_type_data): Change type.
4987         (rs6000_builtin_type, _initialize_stabsread): Update.
4988
4989 2019-05-08  Tom Tromey  <tom@tromey.com>
4990
4991         * mips-tdep.c (mips_pdr_data): Remove.
4992         (_initialize_mips_tdep): Update.
4993
4994 2019-05-08  Tom Tromey  <tom@tromey.com>
4995
4996         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4997         (hppa_init_objfile_priv_data, read_unwind_info)
4998         (find_unwind_entry, _initialize_hppa_tdep): Update.
4999
5000 2019-05-08  Tom Tromey  <tom@tromey.com>
5001
5002         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5003         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5004         on obstack.
5005         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5006
5007 2019-05-08  Tom Tromey  <tom@tromey.com>
5008
5009         * mdebugread.c (basic_type_data): Change type.
5010         (basic_type, _initialize_mdebugread): Update.
5011
5012 2019-05-08  Tom Tromey  <tom@tromey.com>
5013
5014         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5015
5016 2019-05-08  Tom Tromey  <tom@tromey.com>
5017
5018         * nto-tdep.c (nto_inferior_data_reg): Change type.
5019         (nto_inferior_data): Update.
5020         (nto_inferior_data_cleanup, nto_new_inferior_data)
5021         (_initialize_nto_tdep): Remove.
5022         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5023
5024 2019-05-08  Tom Tromey  <tom@tromey.com>
5025
5026         * ada-lang.c (struct ada_inferior_data): Add initializers.
5027         (ada_inferior_data): Change type.
5028         (ada_inferior_data_cleanup): Remove.
5029         (get_ada_inferior_data, ada_inferior_exit)
5030         (struct ada_pspace_data): Add initializers, destructor.
5031         (ada_pspace_data_handle): Change type.
5032         (get_ada_pspace_data): Update.
5033         (ada_pspace_data_cleanup): Remove.
5034
5035 2019-05-08  Tom Tromey  <tom@tromey.com>
5036
5037         * coffread.c (struct coff_symfile_info): Add initializers.
5038         (coff_objfile_data_key): Move lower.  Change type.
5039         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5040         Update.
5041         (coff_free_info): Remove.
5042
5043 2019-05-08  Tom Tromey  <tom@tromey.com>
5044
5045         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5046         (fbsd_pspace_data_handle): Move lower.  Change type.
5047         (get_fbsd_pspace_data): Update.
5048         (fbsd_pspace_data_cleanup): Remove.
5049         (_initialize_fbsd_tdep): Update.
5050
5051 2019-05-08  Tom Tromey  <tom@tromey.com>
5052
5053         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5054         (get_ada_tasks_pspace_data): Update.
5055         (ada_tasks_pspace_data_cleanup): Remove.
5056         (_initialize_tasks): Update.
5057         (ada_tasks_inferior_data_handle): Change type.
5058         (get_ada_tasks_inferior_data): Update.
5059         (ada_tasks_inferior_data_cleanup): Remove.
5060         (struct ada_tasks_pspace_data): Add initializers.
5061
5062 2019-05-08  Tom Tromey  <tom@tromey.com>
5063
5064         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5065         * symfile-debug.c (debug_sym_get_probes): Change type.
5066         * stap-probe.c (handle_stap_probe):
5067         (stap_static_probe_ops::get_probes): Change type.
5068         * probe.h (class static_probe_ops) <get_probes>: Change type.
5069         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5070         (parse_probes_in_pspace): Update.
5071         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5072         Update.
5073         (any_static_probe_ops::get_probes): Change type.
5074         * elfread.c (elfread_data): New typedef.
5075         (probe_key): Change type.
5076         (elf_get_probes): Likewise.  Update.
5077         (probe_key_free): Remove.
5078         (_initialize_elfread): Update.
5079         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5080         Change type.
5081         (dtrace_process_dof_probe, dtrace_process_dof)
5082         (dtrace_static_probe_ops::get_probe): Change type.
5083
5084 2019-05-08  Tom Tromey  <tom@tromey.com>
5085
5086         * xcoffread.c (struct xcoff_symfile_info): Rename from
5087         coff_symfile_info.  Add initializers.
5088         (xcoff_objfile_data_key): Move lower.  Change type.
5089         (XCOFF_DATA): Rewrite.
5090         (xcoff_free_info): Remove.
5091         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5092         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5093         (xcoff_initial_scan): Update.
5094
5095 2019-05-08  Tom Tromey  <tom@tromey.com>
5096
5097         * solib-svr4.c (struct svr4_info): Add initializers and
5098         destructor.
5099         <probes_table>: Now an htab_up.
5100         (solib_svr4_pspace_data): Change type.
5101         (free_probes_table): Simplify.
5102         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5103         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5104         (probes_table_remove_objfile_probes, register_solib_event_probe)
5105         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5106         (_initialize_svr4_solib): Update.
5107
5108 2019-05-08  Tom Tromey  <tom@tromey.com>
5109
5110         * remote.c (remote_pspace_data): Change type.
5111         (remote_pspace_data_cleanup): Remove.
5112         (get_remote_exec_file, set_pspace_remote_exec_file)
5113         (_initialize_remote): Update.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * breakpoint.c (breakpoint_objfile_key): Change type.
5118         (get_breakpoint_objfile_data): Update.
5119         (free_breakpoint_objfile_data): Remove.
5120         (_initialize_breakpoint): Update.
5121
5122 2019-05-08  Tom Tromey  <tom@tromey.com>
5123
5124         * linux-tdep.c (struct linux_info): Add initializers.
5125         (linux_inferior_data): Move.  Change type.
5126         (invalidate_linux_cache_inf): Update.
5127         (linux_inferior_data_cleanup): Remove.
5128         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5129
5130 2019-05-08  Tom Tromey  <tom@tromey.com>
5131
5132         * auxv.c (auxv_inferior_data): Move.  Change type.
5133         (auxv_inferior_data_cleanup): Remove.
5134         (invalidate_auxv_cache_inf): Rewrite.
5135         (get_auxv_inferior_data, _initialize_auxv): Update.
5136
5137 2019-05-08  Tom Tromey  <tom@tromey.com>
5138
5139         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5140         (symfile_debug_objfile_data_key): Change type.
5141         (symfile_debug_installed, debug_qf_has_symbols)
5142         (debug_qf_find_last_source_symtab)
5143         (debug_qf_forget_cached_source_info)
5144         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5145         (debug_qf_print_stats, debug_qf_dump)
5146         (debug_qf_expand_symtabs_for_function)
5147         (debug_qf_expand_all_symtabs)
5148         (debug_qf_expand_symtabs_with_fullname)
5149         (debug_qf_map_matching_symbols)
5150         (debug_qf_expand_symtabs_matching)
5151         (debug_qf_find_pc_sect_compunit_symtab)
5152         (debug_qf_map_symbol_filenames)
5153         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5154         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5155         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5156         (debug_sym_read_linetable, debug_sym_relocate): Update.
5157         (symfile_debug_free_objfile): Remove.
5158         (install_symfile_debug_logging, _initialize_symfile_debug):
5159         Update.
5160
5161 2019-05-08  Tom Tromey  <tom@tromey.com>
5162
5163         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5164         allocate_on_obstack.
5165         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5166         (get_dwarf2_per_objfile): Update.
5167         (set_dwarf2_per_objfile): Remove.
5168         (dwarf2_has_info, dwarf2_get_section_info): Update.
5169         (dwarf2_free_objfile): Remove.
5170         (_initialize_dwarf2_read): Update.
5171
5172 2019-05-08  Tom Tromey  <tom@tromey.com>
5173
5174         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5175         initializers.
5176         <unsupported_script_warning_printed,
5177         script_not_found_warning_printed>: Now bool.
5178         (auto_load_pspace_data): Change type.
5179         (~auto_load_pspace_info): Rename from
5180         auto_load_pspace_data_cleanup.
5181         (get_auto_load_pspace_data, init_loaded_scripts_info)
5182         (clear_section_scripts, maybe_print_unsupported_script_warning)
5183         (maybe_print_script_not_found_warning, _initialize_auto_load):
5184         Update.
5185
5186 2019-05-08  Tom Tromey  <tom@tromey.com>
5187
5188         * objfiles.c (objfile_pspace_info): Add destructor and
5189         initializers.
5190         (objfiles_pspace_data): Change type.
5191         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5192         (get_objfile_pspace_data): Update.
5193         (objfiles_bfd_data): Change type.
5194         (get_objfile_bfd_data): Update.
5195         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5196
5197 2019-05-08  Tom Tromey  <tom@tromey.com>
5198
5199         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5200         Change type.
5201         (get_catch_syscall_inferior_data): Update.
5202         (catch_syscall_inferior_data_cleanup): Remove.
5203         (_initialize_break_catch_syscall): Update.
5204
5205 2019-05-08  Tom Tromey  <tom@tromey.com>
5206
5207         * inflow.c (struct terminal_info): Add destructor and
5208         initializers.
5209         (inflow_inferior_data): Change type.
5210         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5211         (get_inflow_inferior_data, inflow_inferior_exit)
5212         (swap_terminal_info, _initialize_inflow): Update.
5213
5214 2019-05-08  Tom Tromey  <tom@tromey.com>
5215
5216         * target-dcache.c (target_dcache_cleanup): Remove.
5217         (target_dcache_aspace_key): Change type.
5218         (target_dcache_init_p, target_dcache_invalidate)
5219         (target_dcache_get, target_dcache_get_or_init)
5220         (_initialize_target_dcache): Update.
5221         * dcache.h (struct dcache_deleter): New.
5222
5223 2019-05-08  Tom Tromey  <tom@tromey.com>
5224
5225         * symtab.c (struct symbol_cache): Add destructor and
5226         initializers.
5227         (symbol_cache_key): Move.  Change type.
5228         (make_symbol_cache, free_symbol_cache): Remove.
5229         (get_symbol_cache): Update.
5230         (symbol_cache_cleanup): Remove.
5231         (ALL_PSPACES, symbol_cache_flush)
5232         (maintenance_print_symbol_cache)
5233         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5234         Update.
5235
5236 2019-05-08  Tom Tromey  <tom@tromey.com>
5237
5238         * symtab.c (struct main_info): Add destructor and initializers.
5239         (main_progspace_key): Move.  Change type.
5240         (get_main_info): Update.
5241         (main_info_cleanup): Remove.
5242         (_initialize_symtab): Update.
5243
5244 2019-05-08  Tom Tromey  <tom@tromey.com>
5245
5246         * registry.h (DECLARE_REGISTRY): Define the _key class.
5247
5248 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * NEWS: Merge two 'New commands' sections.
5251
5252 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5253
5254         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5255         parameter and use Ada language definition instead.
5256         (ada_val_print_ptr): Remove unused language parameter.
5257         (ada_val_print_num): Remove language parameter and use Ada language
5258         definition instead.
5259         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5260         parameter.
5261         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5262         parameter and use Ada language definition instead.
5263         (ada_val_print_1): Update all ada_val_print_xxx calls.
5264         Remove language parameter.
5265         (ada_val_print): Update ada_val_print_1 call.
5266
5267 2019-05-08  Tom Tromey  <tromey@adacore.com>
5268
5269         * remote.c (remote_hw_watchpoint_limit)
5270         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5271         Now static.
5272
5273 2019-05-08  Tom Tromey  <tromey@adacore.com>
5274
5275         * maint.c (_initialize_maint_cmds): Move initialization code to
5276         remote.c.
5277         (watchdog, show_watchdog): Move to remote.c.
5278         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5279         "watchdog" static.
5280         (_initialize_remote): Move initialization code from maint.c.
5281         * defs.h (watchdog): Don't declare.
5282
5283 2019-05-08  Tom Tromey  <tromey@adacore.com>
5284
5285         * tui/tui-interp.c: Include main.h.
5286         * interps.c: Include main.h.
5287         * main.h (interpreter_p): Declare.
5288         * defs.h (interpreter_p): Don't declare.
5289
5290 2019-05-08  Tom Tromey  <tromey@adacore.com>
5291
5292         * dwarf2loc.c: Include dwarf2read.h.
5293         * defs.h (read_unsigned_leb128): Don't declare.
5294         * dwarf2read.h (read_unsigned_leb128): Declare.
5295
5296 2019-05-08  Tom Tromey  <tromey@adacore.com>
5297
5298         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5299         method.
5300
5301 2019-05-08  Tom Tromey  <tromey@adacore.com>
5302
5303         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5304         when no wrap column is set.
5305
5306 2019-05-08  Tom Tromey  <tromey@adacore.com>
5307
5308         * c-lang.c (c_get_string): Handle non-C-style arrays.
5309
5310 2019-05-08  Tom Tromey  <tromey@adacore.com>
5311
5312         * typeprint.c (print_offset_data::update): Print the bit offset,
5313         not the number of bits remaining.
5314
5315 2019-05-08  Tom Tromey  <tromey@adacore.com>
5316
5317         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5318         padding at end of comment.
5319
5320 2019-05-08  Tom Tromey  <tromey@adacore.com>
5321
5322         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5323         Compare main types.
5324
5325 2019-05-06  Tom Tromey  <tom@tromey.com>
5326
5327         * common/scoped_mmap.c: Include common-defs.h.
5328         * common/scoped_mmap.h: Don't include config.h.
5329
5330 2019-05-04  Tom Tromey  <tom@tromey.com>
5331
5332         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5333         (struct aarch64_call_info): Add initializers.
5334         <si>: Now a std::vector.
5335         (pass_on_stack, aarch64_push_dummy_call): Update.
5336
5337 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5338             Tom Tromey  <tom@tromey.com>
5339
5340         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5341         (ppc_threads): Now a std::vector.  Now static.
5342         (hwdebug_find_thread_points_by_tid)
5343         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5344         Update.
5345
5346 2019-05-04  Tom Tromey  <tom@tromey.com>
5347
5348         * arc-tdep.c (arc_tdesc_init): Return bool.
5349
5350 2019-05-04  Tom Tromey  <tom@tromey.com>
5351
5352         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5353         Use gdb_assert_not_reached.
5354
5355 2019-05-04  Tom Tromey  <tom@tromey.com>
5356
5357         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5358         "false".
5359
5360 2019-05-04  Tom Tromey  <tom@tromey.com>
5361
5362         * arc-tdep.c (arc_tdesc_init): Use bool.
5363
5364 2019-05-04  Tom Tromey  <tom@tromey.com>
5365
5366         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5367
5368 2019-05-04  Tom Tromey  <tom@tromey.com>
5369
5370         * cli/cli-cmds.c (valid_command_p): Return bool.
5371
5372 2019-05-04  Tom Tromey  <tom@tromey.com>
5373
5374         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5375         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5376
5377 2019-05-04  Raul Tambre  <raul@tambre.ee>
5378
5379         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5380         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5381         operator for comparison.
5382
5383 2019-05-04  Tom Tromey  <tom@tromey.com>
5384
5385         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5386         (lookup_partial_symbol, print_partial_symbols)
5387         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5388         (psymbol_compare): Update.
5389         (add_psymbol_to_bcache): Clear the entire psymbol.
5390         (maintenance_check_psymtabs): Update.
5391         * psympriv.h (struct partial_symbol): Don't derive from
5392         general_symbol_info.
5393         <obj_section, unrelocated_address, address,
5394         set_unrelocated_address>: Update.
5395         <ginfo>: New member.
5396         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5397         (debug_names::write_psymbols): Update.
5398
5399 2019-05-04  Tom de Vries  <tdevries@suse.de>
5400
5401         * contrib/cc-with-tweaks.sh: Support -n arg.
5402
5403 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5404
5405         * corelow.c (core_target::detach): Ensure frame cache and
5406         register caches are cleared.
5407         inferior.c (exit_inferior_1): Likewise.
5408
5409 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5410             Tom Tromey  <tom@tromey.com>
5411
5412         * dictionary.c (collate_pending_symbols_by_language): Remove
5413         "struct" from foreach.
5414         * symtab.c (lookup_global_symbol_from_objfile)
5415         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5416         foreach.
5417         * ser-tcp.c (net_open): Remove "struct" from foreach.
5418         * objfiles.c (objfile_relocate, objfile_rebase)
5419         (objfile_has_symbols): Remove "struct" from foreach.
5420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5421         from foreach.
5422         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5423         foreach.
5424         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5425         "struct" from foreach.
5426         * ada-lang.c (create_excep_cond_exprs)
5427         (ada_exception_catchpoint_cond_string): Remove "struct" from
5428         foreach.
5429
5430 2019-05-03  Tom Tromey  <tromey@adacore.com>
5431
5432         * ada-exp.y (convert_char_literal): Check suffix of each
5433         enumerator.
5434
5435 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5436
5437         PR ada/21406:
5438         * ada-exp.y (yywrap): Don't define.
5439         * ada-lex.l (%option): Add noyywrap
5440         (yywrap): Remove.
5441
5442 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5443
5444         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5445         _WIN32_WINNT to the XP level, unless already defined to a higher
5446         level.
5447
5448         * unittests/parse-connection-spec-selftests.c:
5449         * ser-tcp.c:
5450         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5451         override.
5452
5453         * symfile.c (find_separate_debug_file): Remove colon from the
5454         drive spec of DOS/Windows file names of the target, so that the
5455         file name produced from DEBUGDIR and the target's directory will
5456         be valid on DOS/Windows systems.
5457
5458 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5459
5460         * rust-lang.c (val_print_struct): Handle printing structures
5461         containing strings.
5462
5463 2019-05-02  Tom Tromey  <tromey@adacore.com>
5464
5465         * valarith.c (_initialize_valarith): Remove.
5466
5467 2019-05-01  Tom Tromey  <tromey@adacore.com>
5468
5469         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5470         bitfields.
5471
5472 2019-05-01  Tom Tromey  <tromey@adacore.com>
5473
5474         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5475         for big-endian copies.
5476
5477 2019-04-30  Ali Tamur  <tamur@google.com>
5478         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5479         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5480         (read_3_bytes): New function.
5481
5482 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5483
5484         * windows-nat.c (main_thread_id): Delete.
5485         (handle_output_debug_string): Replace main_thread_id by
5486         current_event.dwThreadId.
5487         (fake_create_process): Likewise.
5488         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5489         Do not set main_thread_id.
5490         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5491         current_event.dwThreadId.
5492         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5493
5494 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5495
5496         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5497         Use current_event.dwThreadId instead of main_thread_id.
5498
5499 2019-04-30  Tom Tromey  <tromey@adacore.com>
5500
5501         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5502         (create_excep_cond_exprs): Iterate over program spaces.
5503         (ada_exception_catchpoint_cond_string): Examine all minimal
5504         symbols for exception types.
5505
5506 2019-04-30  Tom Tromey  <tromey@adacore.com>
5507
5508         PR c++/24470:
5509         * dwarf2read.c (process_structure_scope): Handle case where type
5510         has template parameters but no symbol was created.
5511
5512 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5513             Chris January  <chris.january@arm.com>
5514
5515         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5516         qualifier.
5517         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5518
5519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * f-typeprint.c (f_print_type): Update rules for printing
5522         whitespace.
5523         (f_type_print_varspec_suffix): Likewise.
5524
5525 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5526             Chris January  <chris.january@arm.com>
5527
5528         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5529         function arguments.
5530
5531 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * f-lang.c (build_fortran_types): Change name of void type to
5534         lower case.
5535         * f-typeprint.c (f_type_print_base): Print the name of the void
5536         type, rather than a fixed string.
5537         * f-valprint.c (f_decorations): Use lower case void string.
5538
5539 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5540             Chris January  <chris.january@arm.com>
5541
5542         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5543         types for Fortran.
5544
5545 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5546             Chris January  <chris.january@arm.com>
5547             David Lecomber  <david.lecomber@arm.com>
5548
5549         * f-exp.y (BINOP_INTRINSIC): New token.
5550         (exp): New parser rule handling BINOP_INTRINSIC.
5551         (f77_keywords): Add new builtin procedures.
5552         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5553         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5554         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5555         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5556         (print_unop_subexp_f): New function.
5557         (print_binop_subexp_f): New function.
5558         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5559         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5560         (dump_subexp_body_f): Likewise.
5561         (operator_check_f): Likewise.
5562         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5563         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5564
5565 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5566
5567         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5568         UNOP_KIND.
5569         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5570         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5571         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5572         (operator_length_f): New fuction.
5573         (print_subexp_f): New function.
5574         (op_name_f): New function.
5575         (dump_subexp_body_f): New function.
5576         (operator_check_f): New function.
5577         (exp_descriptor_f): Replace standard expression handling functions
5578         with new functions.
5579         * gdb/fortran-operator.def: New file.
5580         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5581         * gdb/std-operator.def: Remove UNOP_KIND.
5582
5583 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * std-operator.def: Remove unbalanced, stray double quote
5586         character.
5587
5588 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5589             Chris January  <chris.january@arm.com>
5590             Daniel Everett  <daniel.everett@arm.com>
5591             Nick Forrington  <nick.forrington@arm.com>
5592             Richard Bunt  <richard.bunt@arm.com>
5593
5594         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5595         of depth when printing anonymous structs or unions.
5596         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5597         Don't print either the top-level value, or the children if the
5598         max-depth is exceeded.
5599         (ppscm_print_children): When printing the key of a map, allow one
5600         extra level of depth.
5601         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5602         print either the top-level value, or the children if the max-depth
5603         is exceeded.
5604         (print_children): When printing the key of a map, allow one extra
5605         level of depth.
5606         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5607         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5608         (user_print_options): Initialise max_depth field.
5609         (val_print_scalar_or_string_type_p): New function.
5610         (val_print): Check to see if the max depth has been reached.
5611         (val_print_check_max_depth): Define new function.
5612         (show_print_max_depth): New function.
5613         (_initialize_valprint): Add 'print max-depth' option.
5614         * valprint.h (struct value_print_options) <max_depth>: New field.
5615         (val_print_check_max_depth): Declare new function.
5616         * NEWS: Document new feature.
5617
5618 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5619
5620         * ada-lang.c (ada_language_defn): Initialise new field.
5621         * c-lang.c (c_is_string_type_p): New function.
5622         (c_language_defn): Initialise new field.
5623         (cplus_language_defn): Initialise new field.
5624         (asm_language_defn): Initialise new field.
5625         (minimal_language_defn): Initialise new field.
5626         * c-lang.h (c_is_string_type_p): Declare new function.
5627         * d-lang.c (d_language_defn): Initialise new field.
5628         * f-lang.c (f_is_string_type_p): New function.
5629         (f_language_defn): Initialise new field.
5630         * go-lang.c (go_is_string_type_p): New function.
5631         (go_language_defn): Initialise new field.
5632         * language.c (default_is_string_type_p): New function.
5633         (unknown_language_defn): Initialise new field.
5634         (auto_language_defn): Initialise new field.
5635         * language.h (struct language_defn) <la_is_string_type_p>: New
5636         member variable.
5637         (default_is_string_type_p): Declare new function.
5638         * m2-lang.c (m2_language_defn): Initialise new field.
5639         * objc-lang.c (objc_language_defn): Initialise new field.
5640         * opencl-lang.c (opencl_language_defn): Initialise new field.
5641         * p-lang.c (pascal_is_string_type_p): New function.
5642         (pascal_language_defn): Initialise new field.
5643         * rust-lang.c (rust_is_string_type_p): New function.
5644         (rust_language_defn): Initialise new field.
5645
5646 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5649         New field.
5650         * ada-lang.c (ada_language_defn): Initialise new field.
5651         * c-lang.c (c_language_defn): Likewise.
5652         (cplus_language_defn): Likewise.
5653         (asm_language_defn): Likewise.
5654         (minimal_language_defn): Likewise.
5655         * d-lang.c (d_language_defn): Likewise.
5656         * f-lang.c (f_language_defn): Likewise.
5657         * go-lang.c (go_language_defn): Likewise.
5658         * language.c (unknown_language_defn): Likewise.
5659         (auto_language_defn): Likewise.
5660         * m2-lang.c (m2_language_defn): Likewise.
5661         * objc-lang.c (objc_language_defn): Likewise.
5662         * opencl-lang.c (opencl_language_defn): Likewise.
5663         * p-lang.c (pascal_language_defn): Likewise.
5664         * rust-lang.c (rust_language_defn): Likewise.
5665
5666 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5667
5668         * ada-lang.c (ada_is_character_type): Change return type to bool.
5669         (ada_is_string_type): Likewise.
5670         * ada-lang.h (ada_is_character_type): Update declaration
5671         (ada_is_string_type): Likewise.
5672
5673 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5674
5675         Support style in 'frame|thread apply'
5676
5677         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5678         * record.c (record_start, record_stop): Update callers of
5679         execute_command_to_string with false.
5680         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5681         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5682         methods.
5683         (class string_file): New constructor with term_out parameter.
5684         Override methods term_out and can_emit_style_escape.  New member
5685         term_out.
5686         (class stdio_file): Override can_emit_style_escape.
5687         (class tee_file): Override term_out and can_emit_style_escape.
5688         * utils.h (can_emit_style_escape): Remove.
5689         * utils.c (can_emit_style_escape): Likewise.
5690         Update all callers of can_emit_style_escape (SOMESTREAM) to
5691         SOMESTREAM->can_emit_style_escape.
5692         * source-cache.c (source_cache::get_source_lines): Likewise.
5693         * stack.c (frame_apply_command_count): Call execute_command_to_string
5694         passing the term_out characteristic of the current gdb_stdout.
5695         * thread.c (thr_try_catch_cmd): Likewise.
5696         * top.c (execute_command_to_string): pass term_out parameter
5697         to construct the string_file for the command output.
5698         * ui-file.c (term_cli_styling): New function (most code moved
5699         from utils.c can_emit_style_escape).
5700         (string_file::string_file, string_file::can_emit_style_escape,
5701         stdio_file::can_emit_style_escape, tee_file::term_out,
5702         tee_file::can_emit_style_escape): New functions.
5703
5704 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5705
5706         * NEWS: Mention the new set|show may-call-functions.
5707         * infcall.c (may_call_functions_p): New variable.
5708         (show_may_call_functions_p): New function.
5709         (call_function_by_hand_dummy): Throws an error if not
5710         may-call-functions.
5711         (_initialize_infcall): Call add_setshow_boolean_cmd for
5712         may-call-functions.
5713
5714 2019-04-25  Keith Seitz  <keiths@redhat.com>
5715
5716         PR c++/24367
5717         * cp-support.c (inspect_type): Don't attempt substitutions
5718         of symbol with the same name.
5719
5720 2019-04-25  Tom Tromey  <tromey@adacore.com>
5721
5722         PR gdb/24475:
5723         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5724         static.
5725
5726 2019-04-25  Tom Tromey  <tromey@adacore.com>
5727
5728         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5729         rvalue reference.
5730         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5731         (gdb_xml_parser::parse): Use std::move.
5732         * python/python-internal.h (gdbpy_convert_exception): Take a const
5733         reference.
5734         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5735         std::move.
5736         * python/py-utils.c (gdbpy_convert_exception): Take a const
5737         reference.
5738         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5739         Use std::move.
5740         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5741         Use std::move.
5742         * mi/mi-main.c (mi_print_exception): Take a const reference.
5743         * main.c (handle_command_errors): Take a const reference.
5744         * linespec.c (parse_linespec): Use std::move.
5745         * infcall.c (run_inferior_call): Use std::move.
5746         (call_function_by_hand_dummy): Use std::move.
5747         * exec.c (try_open_exec_file): Use std::move.
5748         * exceptions.h (exception_print, exception_fprintf)
5749         (exception_print_same): Update.
5750         * exceptions.c (print_exception, exception_print)
5751         (exception_fprintf, exception_print_same): Change parameters to
5752         const reference.
5753         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5754         * common/new-op.c: Use std::move.
5755         * common/common-exceptions.h (struct gdb_exception): Add move
5756         constructor.
5757         (struct gdb_exception_error, struct gdb_exception_quit, struct
5758         gdb_quit_bad_alloc): Change constructor to move constructor.
5759         (throw_exception): Change parameter to rvalue reference.
5760         * common/common-exceptions.c (throw_exception): Take rvalue
5761         reference.
5762         * cli/cli-interp.c (safe_execute_command): Use std::move.
5763         * breakpoint.c (insert_bp_location, location_to_sals): Use
5764         std::move.
5765
5766 2019-04-25  Tom Tromey  <tromey@adacore.com>
5767
5768         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5769         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5770         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5771         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5772         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5773         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5774         guile/scm-value.c: Use unpack.
5775         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5776         gdbscm_gdb_exception.
5777         (gdbscm_throw_gdb_exception): Likewise.
5778         (struct gdbscm_gdb_exception): New.
5779         (unpack): New function.
5780         (gdbscm_wrap): Use unpack.
5781
5782 2019-04-25  Tom Tromey  <tromey@adacore.com>
5783
5784         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5785         (gdb_rl_callback_handler): Use std::move.
5786         * common/common-exceptions.h (struct gdb_exception): Add move
5787         assignment operator.
5788         (throw_exception_sjlj): Change "exception" to const reference.
5789         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5790         (throw_exception_sjlj): Change "exception" to const reference.
5791
5792 2019-04-25  Tom Tromey  <tromey@adacore.com>
5793
5794         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5795         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5796         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5797         Update.
5798         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5799         Update.
5800         * mi/mi-interp.c (mi_interp::exec): Update.
5801         * linespec.c (parse_linespec): Update.
5802         * infcall.c (run_inferior_call): Update.
5803         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5804         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5805         (gdbscm_lookup_global_symbol): Update.
5806         * guile/scm-param.c (gdbscm_parameter_value): Update.
5807         * guile/scm-frame.c (gdbscm_frame_read_register)
5808         (gdbscm_frame_read_var): Update.
5809         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5810         * exec.c (try_open_exec_file): Update.
5811         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5812         (gdb_rl_callback_handler): Update.
5813         * common/common-exceptions.h (exception_none): Don't declare.
5814         * common/common-exceptions.c (exception_none): Don't define.
5815         (struct catcher) <exception>: Update.
5816         * cli/cli-interp.c (safe_execute_command): Update.
5817         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5818
5819 2019-04-25  Ali Tamur  <tamur@google.com>
5820
5821         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5822         (read_attribute_value): Likewise.
5823         (dwarf2_read_addr_index): Update comment.
5824         (read_str_index): Add DW_FORM_strx.
5825         (dwarf2_string_attr): Likewise.
5826         (dwarf2_const_value_attr): Likewise.
5827         (dump_die_shallow): Likewise.
5828         (dwarf2_fetch_constant_bytes): Likewise.
5829         (skip_form_bytes): Likewise.
5830         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5831
5832 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5833
5834         PR corefiles/11608
5835         PR corefiles/18187
5836         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5837         OFFSET.  Verify if current mapping contains an ELF header.
5838         (linux_find_memory_regions_full): Adjust call to
5839         dump_mapping_p.
5840
5841 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5842             Kang Li <kanglictf@gmail.com>
5843
5844         PR gdb/21600
5845
5846         * dwarf2-frame.c (read_initial_length): Be consistent about using
5847         unsigned representation of length.
5848         (decode_frame_entry_1): Likewise.  Check for wraparound of
5849         end pointer as well as buffer overflow.
5850
5851 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5852
5853         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5854         "vq".
5855
5856 2019-04-24  Tom Tromey  <tromey@adacore.com>
5857
5858         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5859
5860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * s12z-tdep.c (s12z_unwind_pc): Delete.
5863         (s12z_unwind_sp): Delete.
5864         (s12z_gdbarch_init): Don't register deleted functions with
5865         gdbarch.
5866
5867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5868
5869         * rl78-tdep.c (rl78_unwind_sp): Delete.
5870         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5871
5872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5875         (xstormy16_unwind_pc): Delete.
5876         (xstormy16_dummy_id): Delete.
5877         (xstormy16_gdbarch_init): Don't register deleted functions with
5878         gdbarch.
5879
5880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * vax-tdep.c (vax_unwind_pc): Delete.
5883         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5884
5885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5886
5887         * v850-tdep.c (v850_unwind_sp): Delete.
5888         (v850_unwind_pc): Delete.
5889         (v850_dummy_id): Delete.
5890         (v850_gdbarch_init): Don't register deleted functions with
5891         gdbarch.
5892
5893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5896         (tilegx_unwind_pc): Delete.
5897         (tilegx_unwind_dummy_id): Delete.
5898         (tilegx_gdbarch_init): Don't register deleted functions with
5899         gdbarch.
5900
5901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5902
5903         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5904         (tic6x_dummy_id): Delete.
5905         (tic6x_gdbarch_init): Don't register deleted functions with
5906         gdbarch.
5907
5908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5909
5910         * sparc-tdep.c (sparc_unwind_pc): Delete.
5911         (sparc32_gdbarch_init): Don't register deleted function with
5912         gdbarch.
5913
5914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * sh-tdep.c (sh_unwind_sp): Delete.
5917         (sh_unwind_pc): Delete.
5918         (sh_dummy_id): Delete.
5919         (sh_gdbarch_init): Don't register deleted functions with
5920         gdbarch.
5921
5922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * score-tdep.c (score_unwind_sp): Delete.
5925         (score_unwind_pc): Delete.
5926         (score_dummy_id): Delete.
5927         (score_gdbarch_init): Don't register deleted functions with
5928         gdbarch.
5929
5930 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5931
5932         * rx-tdep.c (rx_unwind_pc): Delete.
5933         (rx_unwind_sp): Delete.
5934         (rx_dummy_id): Delete.
5935         (rx_gdbarch_init): Don't register deleted functions with
5936         gdbarch.  Update comment.
5937
5938 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5939
5940         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5941         (rs6000_dummy_id): Delete.
5942         (rs6000_gdbarch_init): Don't register deleted functions with
5943         gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * or1k-tdep.c (or1k_dummy_id): Delete.
5948         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5949
5950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5951
5952         * nios2-tdep.c (nios2_dummy_id): Delete.
5953         (nios2_unwind_sp): Delete.
5954         (nios2_gdbarch_init): Don't register deleted functions with
5955         gdbarch.
5956
5957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5958
5959         * nds32-tdep.c (nds32_dummy_id): Delete.
5960         (nds32_unwind_pc): Delete.
5961         (nds32_unwind_sp): Delete.
5962         (nds32_gdbarch_init): Don't register deleted functions with
5963         gdbarch.
5964
5965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * msp430-tdep.c (msp430_unwind_pc): Delete.
5968         (msp430_unwind_sp): Delete.
5969         (msp430_dummy_id): Delete.
5970         (msp430_gdbarch_init): Don't register deleted functions with
5971         gdbarch.
5972
5973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * moxie-tdep.c (moxie_unwind_sp): Delete.
5976         (moxie_unwind_pc): Delete.
5977         (moxie_dummy_id): Delete.
5978         (moxie_gdbarch_init): Don't register deleted functions with
5979         gdbarch.
5980
5981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5984         (mn10300_unwind_pc): Delete.
5985         (mn10300_unwind_sp): Delete.
5986         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5987         mn10300_unwind_sp.
5988         (mn10300_frame_unwind_init): Don't register deleted functions with
5989         gdbarch.
5990
5991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5992
5993         * mep-tdep.c (mep_unwind_pc): Delete.
5994         (mep_unwind_sp): Delete.
5995         (mep_dummy_id): Delete.
5996         (mep_gdbarch_init): Don't register deleted functions with
5997         gdbarch.
5998
5999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6000
6001         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6002         (m68hc11_unwind_sp): Delete.
6003         (m68hc11_gdbarch_init): Don't register deleted functions with
6004         gdbarch.
6005
6006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6007
6008         * m32r-tdep.c (m32r_unwind_sp): Delete.
6009         (m32r_unwind_pc): Delete.
6010         (m32r_dummy_id): Delete.
6011         (m32r_gdbarch_init): Don't register deleted functions with
6012         gdbarch.
6013
6014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * m32c-tdep.c (m32c_unwind_pc): Delete.
6017         (m32c_unwind_sp): Delete.
6018         (m32c_dummy_id): Delete.
6019         (m32c_gdbarch_init): Don't register deleted functions with
6020         gdbarch.
6021
6022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6025         (lm32_unwind_pc): Delete.
6026         (lm32_dummy_id): Delete.
6027         (lm32_gdbarch_init): Don't register deleted functions with
6028         gdbarch.
6029
6030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6033         (iq2000_unwind_pc): Delete.
6034         (iq2000_dummy_id): Delete.
6035         (iq2000_gdbarch_init): Don't register deleted functions with
6036         gdbarch.
6037
6038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * nds32-tdep.c (nds32_type_align): Delete.
6041         (nds32_push_dummy_call): Use type_align instead.
6042
6043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6044
6045         * arm-tdep.c (arm_type_align): Only handle vector override case.
6046         (arm_push_dummy_call): Use type_align.
6047         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6048
6049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6052         case.
6053         (pass_on_stack): Use type_align.
6054         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6055         function.
6056
6057 2019-04-23  Tom Tromey  <tromey@adacore.com>
6058
6059         * dwarf2read.c (line_header::file_name_at): Remove unused
6060         overload.
6061
6062 2019-04-23  Tom de Vries  <tdevries@suse.de>
6063
6064         PR gdb/24438
6065         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6066         invocation.
6067
6068
6069 2019-03-27  Ali Tamur  <tamur@google.com>
6070
6071         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6072         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6073         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6074         (dwarf_expr_context::get_addr_index): Likewise
6075         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6076         (symbol_needs_eval_context::get_addr_index): Likewise
6077         (disassemble_dwarf_expression): Add DW_OP_addrx
6078         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6079         (read_cutu_die_from_dwo): Update comment
6080         (skip_one_die): Add DW_FORM_addrx
6081         (read_attribute_value): Likewise
6082         (var_decode_location): Add DW_OP_addrx
6083         (dwarf2_const_value_attr): Add DW_FORM_addrx
6084         (dump_die_shallow): Likewise
6085         (dwarf2_fetch_constant_bytes): Likewise
6086         (decode_locdesc): Add DW_OP_addrx
6087         (skip_form_bytes): Add DW_FORM_addrx
6088
6089 2019-04-22  Ali Tamur  <tamur@google.com>
6090
6091         * MAINTAINERS (Write After Approval): Add self.
6092
6093 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6094
6095         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6096         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6097         (open_symbol_file_object): Likewise.
6098         (svr4_default_sos): Add info parameter.
6099         (svr4_read_so_list): Likewise.
6100         (svr4_current_sos_direct): Adjust functions calls to pass down
6101         info.
6102         (svr4_current_sos_1): Add info parameter.
6103         (svr4_current_sos): Call get_svr4_info, pass info down to
6104         svr4_current_sos_1.
6105         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6106         get_svr4_info.
6107         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6108         get_svr4_info.
6109         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6110         to get_svr4_info.
6111         (probes_table_remove_objfile_probes): Likewise.
6112         (register_solib_event_probe): Add info parameter.
6113         (solist_update_incremental): Pass info parameter down to
6114         svr4_read_so_list.
6115         (disable_probes_interface): Add info parameter.
6116         (svr4_handle_solib_event): Pass current_program_space to
6117         get_svr4_info.  Adjust disable_probes_interface cleanup.
6118         (svr4_create_probe_breakpoints): Add info parameter, pass it
6119         down to register_solib_event_probe.
6120         (svr4_create_solib_event_breakpoints): Add info parameter,
6121         pass it down to svr4_create_probe_breakpoints.
6122         (enable_break): Pass info down to
6123         svr4_create_solib_event_breakpoints.
6124         (svr4_solib_create_inferior_hook): Pass current_program_space to
6125         get_svr4_info.
6126         (svr4_clear_solib): Likewise.
6127
6128 2019-04-22  Pedro Alves  <palves@redhat.com>
6129
6130         * solib-svr4.c (svr4_free_objfile_observer): New.
6131         (probe_and_action::objfile): New field.
6132         (probes_table_htab_remove_objfile_probes)
6133         (probes_table_remove_objfile_probes): New functions.
6134         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6135         in the new probe_and_action.  Don't store the probe in 'lookup'.
6136         (svr4_create_probe_breakpoints): Pass objfile to
6137         register_solib_event_probe.
6138         (_initialize_svr4_solib): Register a free_objfile observer.
6139
6140 2019-04-19  Tom Tromey  <tom@tromey.com>
6141
6142         * common/queue.h: Remove.
6143
6144 2019-04-19  Tom Tromey  <tom@tromey.com>
6145
6146         * event-loop.c: Don't include "common/queue.h".
6147
6148 2019-04-19  Tom Tromey  <tom@tromey.com>
6149
6150         * remote.c (remote_target): Use delete.
6151         * remote-notif.h: Include <list>, not "common/queue.h".
6152         (notif_client_p): Remove typedef.
6153         (remote_notif_state): Add constructor, destructor, initializer.
6154         <notif_queue>: Now a std::list.
6155         (remote_notif_state_xfree): Don't declare.
6156         * remote-notif.c (remote_notif_process, handle_notification)
6157         (remote_notif_state_allocate): Update.
6158         (~remote_notif_state): Rename from remote_notif_state_xfree.
6159
6160 2019-04-19  Tom Tromey  <tom@tromey.com>
6161
6162         * symfile.c (reread_symbols): Update.
6163         * objfiles.c (objfile_register_static_link)
6164         (objfile_lookup_static_link): Update
6165         (~objfile) Don't delete static_links.
6166         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6167
6168 2019-04-19  Tom Tromey  <tom@tromey.com>
6169
6170         * type-stack.h (struct type_stack) <insert>: Constify string.
6171         * type-stack.c (type_stack::insert): Constify string.
6172         * gdbtypes.h (lookup_template_type): Update.
6173         (address_space_name_to_int): Update.
6174         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6175         const.
6176         (lookup_template_type): Make name const.
6177         * c-exp.y: Update rules.
6178         (lex_one_token, classify_name, classify_inner_name)
6179         (c_print_token): Update.
6180         * p-exp.y: Update rules.
6181         (yylex): Update.
6182         * f-exp.y: Update rules.
6183         (yylex): Update.
6184         * d-exp.y: Update rules.
6185         (lex_one_token, classify_name, classify_inner_name): Update.
6186         * parse.c (write_dollar_variable, copy_name): Return std::string.
6187         * parser-defs.h (copy_name): Change return type.
6188         * m2-exp.y: Update rules.
6189         (yylex): Update.
6190         * go-exp.y (lex_one_token): Update.
6191         Update rules.
6192         (classify_unsafe_function, classify_packaged_name)
6193         (classify_name, yylex): Update.
6194
6195 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6196
6197         * configure.ac: add --enable-source-highlight switch.
6198         * configure: Regenerate.
6199         * top.c (print_gdb_version): plumb --enable-source-highlight
6200         status to "show configuration".
6201
6202 2019-04-19  Tom Tromey  <tromey@adacore.com>
6203
6204         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6205         Check ADA_TYPE_P.
6206         (empty_record, ada_template_to_fixed_record_type_1)
6207         (template_to_static_fixed_type)
6208         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6209         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6210         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6211         macros.
6212
6213 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6214
6215         PR symtab/24423:
6216         * source.c (print_source_lines_base): Advance "iter" when a
6217         control character is seen.
6218
6219 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6220
6221         * inferior.h (struct infcall_suspend_state_deleter):
6222         Catch exception in destructor to avoid crash.
6223
6224 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6225
6226         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6227         close to the add_com "shell".
6228
6229 2019-04-18  Tom Tromey  <tromey@adacore.com>
6230
6231         * process-stratum-target.h (class process_stratum_target)
6232         <stratum>: Add "final".
6233
6234 2019-04-17  Tom Tromey  <tromey@adacore.com>
6235
6236         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6237         against nullptr before use.
6238
6239 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6240
6241         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6242
6243 2019-04-17  Jim Wilson  <jimw@sifive.com>
6244             Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6247         code read might fail, assume 4-byte breakpoint in that case.
6248
6249 2019-04-15  Leszek Swirski  <leszeks@google.com>
6250
6251         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6252         rather than a hand-rolled POD check when checking for forced MEMORY
6253         classification.
6254
6255 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6256
6257         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6258         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6259         function.
6260         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6261         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6262         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6263         declaration.
6264
6265 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6266
6267         * aarch64-linux-nat.c
6268         (aarch64_linux_nat_target::thread_architecture): Add override.
6269         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6270         each VQ.
6271
6272 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6273
6274         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6275
6276 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6279         target types of size 96-bits, add some additional comments, and
6280         check that the builtin type we found was the correct size.
6281
6282 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6283
6284         * utils.c (prompt_for_continue): Don't restore the styling at the
6285         end, as applied_style has the wrong value.  This fixes styling in
6286         long lists of file names that are interrupted by the "Continue?"
6287         prompt.
6288
6289 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6290
6291         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6292         * c-lang.c (c_language_defn): Likewise.
6293         (cplus_language_defn): Likewise.
6294         (asm_language_defn): Likewise.
6295         (minimal_language_defn): Likewise.
6296         * d-lang.c (d_language_defn): Likewise.
6297         * f-lang.c (f_language_defn): Likewise.
6298         * go-lang.c (go_language_defn): Likewise.
6299         * language.c (unknown_language_defn): Likewise.
6300         (auto_language_defn): Likewise.
6301         * language.h (struct language_defn): Remove la_magic field.
6302         (LANG_MAGIC): Delete.
6303         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6304         * objc-lang.c (objc_language_defn): Likewise.
6305         * opencl-lang.c (opencl_language_defn): Likewise.
6306         * p-lang.c (pascal_language_defn): Likewise.
6307         * rust-lang.c (rust_language_defn): Likewise.
6308
6309 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * riscv-tdep.c (riscv_type_align): New function.
6312         (riscv_type_alignment): Delete.
6313         (riscv_arg_location): Use 'type_align'.
6314         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6315
6316 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * gdbtypes.c (type_align): A struct with no non-static fields also
6319         has alignment of 1.
6320
6321 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6324         component to 0.
6325         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6326         member.
6327         (riscv_struct_info::analyse): New implementation using new
6328         analyse_inner member function.
6329         (riscv_struct_info::field_offset): New member function.
6330         (riscv_struct_info::m_offsets): New member variable.
6331         (riscv_struct_info::analyse_inner): New private member function,
6332         takes the old implementation of riscv_struct_info::analyse but
6333         extended to track field offsets.
6334         (riscv_call_arg_struct): Update the struct folding special cases
6335         to handle cases where empty C++ structs, which are non-zero
6336         length, are found.
6337         (riscv_arg_location): Initialise the length of each location, a
6338         non-zero length now indicates the location is in use.
6339         (riscv_push_dummy_call): Allow for the first location having a
6340         non-zero offset when setting up arguments.
6341         (riscv_return_value): Likewise, but for return values.
6342
6343 2019-04-11  Tom Tromey  <tromey@adacore.com>
6344
6345         * utils.c (internal_vproblem): Make "msg" const.
6346
6347 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6348
6349         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6350         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6351         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6352         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6353
6354 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6355
6356         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6357         function.
6358         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6359         of amd64_collect_native_gregset.
6360         (amd64_linux_nat_target::store_registers): Likewise.
6361
6362 2019-04-10  Tom Tromey  <tom@tromey.com>
6363
6364         * symtab.c (lookup_global_symbol_from_objfile)
6365         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6366         * objfiles.h (class separate_debug_iterator): New.
6367         (class separate_debug_range): New.
6368         (struct objfile) <separate_debug_objfiles>: New method.
6369         (objfile_separate_debug_iterate): Don't declare.
6370         * objfiles.c (separate_debug_iterator::operator++): Rename from
6371         objfile_separate_debug_iterate.
6372         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6373         iterator.
6374         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6375         iterator.
6376
6377 2019-04-10  Tom Tromey  <tom@tromey.com>
6378
6379         * symfile.c (reread_symbols): Remove old comment.
6380         * objfiles.c (free_all_objfiles): Fix a typo.
6381
6382 2019-04-10  Tom Tromey  <tom@tromey.com>
6383
6384         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6385         * minsyms.c (lookup_minimal_symbol): Use foreach.
6386         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6387         (lookup_minimal_symbol_solib_trampoline): Likewise.
6388         * symfile.c (reread_symbols): Use foreach.
6389
6390 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6391             Tom Tromey  <tromey@adacore.com>
6392
6393         PR rust/24414:
6394         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6395         (rust_lex_int_test): Change "value" to be LONGEST.
6396         (rust_lex_tests): Add test for long integer literal.
6397
6398 2019-04-09  Tom Tromey  <tromey@adacore.com>
6399
6400         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6401         to bool.
6402         (extended_remote_target::attach): Update.
6403         (remote_target::remote_notice_new_inferior): Update.
6404         (remote_target::add_current_inferior_and_thread): Update.
6405         * inferior.c (exit_inferior_1): Use "false".
6406         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6407
6408 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6409
6410         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6411         the "start" command.
6412
6413 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6414
6415         * python/py-inferior.c (infpy_thread_from_thread_handle):
6416         Adjust comments to reflect renaming of thread_from_thread_handle
6417         to thread_from_handle.  Adjust keywords.  Fix type error message.
6418         (inferior_object_methods): Add thread_from_handle.  Retain
6419         thread_from_thread_handle, but mark it as deprecated.
6420
6421 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6422
6423         * gdbthread.h (find_thread_by_handle): Revise declaration.
6424         * thread.c (find_thread_by_handle): Likewise.  Adjust
6425         implementation too.
6426         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6427         support for buffer objects as handles.
6428
6429 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6430
6431         * python/py-infthread.c (thpy_thread_handle): New function.
6432         (thread_object_methods): Register thpy_thread_handle.
6433
6434 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6435
6436         * gdbthread.h (thread_to_thread_handle): Declare.
6437         * thread.c (gdbtypes.h): Include.
6438         (thread_to_thread_handle): New function.
6439
6440         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6441         (target_thread_info_to_thread_handle): Declare.
6442         * target.c (target_thread_info_to_thread_handle): New function.
6443         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6444         * target-delegates.c: Regenerate.
6445
6446         * linux-thread-db.c (class thread_db_target): Add method
6447         thread_info_to_thread_handle.
6448         (thread_db_target::thread_info_to_thread_handle): Define.
6449         * remote.c (class remote_target): Add new method
6450         thread_info_to_thread_handle.
6451         (remote_target::thread_info_to_thread_handle): Define.
6452
6453 2019-04-08  Pedro Alves  <palves@redhat.com>
6454
6455         * common/common-exceptions.c (throw_exception): Don't create
6456         named object to throw; throw directly.
6457         (throw_it): Likewise.  Don't initialize gdb_exception::message
6458         here, with new; pass FMT and AP to the ctor instead.
6459         * common/common-exceptions.h: Include <string>.
6460         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6461         const char *, va_list)): New ctor.  Use std::make_shared.
6462         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6463         errors)): Delete.
6464         (gdb_exception_error::gdb_exception_error(enum errors, const char
6465         *, va_list)): New.
6466         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6467         Add assertion.
6468         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6469         errors)): Delete.
6470         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6471         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6472         Add assertion.
6473
6474 2019-04-08  Tom Tromey  <tom@tromey.com>
6475
6476         * valops.c (value_rtti_indirect_type): Replace throw_exception
6477         with throw.
6478         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6479         with throw.
6480         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6481         throw.
6482         * target.c (target_translate_tls_address): Replace throw_exception
6483         with throw.
6484         * stack.c (frame_apply_command_count): Replace throw_exception
6485         with throw.
6486         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6487         throw.
6488         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6489         with throw.
6490         * rs6000-tdep.c (rs6000_frame_cache)
6491         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6492         * remote.c: Replace throw_exception with throw.
6493         * record-full.c (record_full_message, record_full_wait_1)
6494         (record_full_restore): Replace throw_exception with throw.
6495         * record-btrace.c:
6496         (get_thread_current_frame_id, record_btrace_start_replaying)
6497         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6498         (cmd_record_btrace_start): Replace throw_exception with throw.
6499         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6500         throw.
6501         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6502         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6503         * linespec.c:
6504         (find_linespec_symbols): Replace throw_exception with throw.
6505         * infrun.c (displaced_step_prepare, resume): Replace
6506         throw_exception with throw.
6507         * infcmd.c (post_create_inferior): Replace throw_exception with
6508         throw.
6509         * inf-loop.c (inferior_event_handler): Replace throw_exception
6510         with throw.
6511         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6512         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6513         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6514         (get_prev_frame_always, get_frame_pc_if_available)
6515         (get_frame_address_in_block_if_available, get_frame_language):
6516         Replace throw_exception with throw.
6517         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6518         throw_exception with throw.
6519         * eval.c (fetch_subexp_value, evaluate_var_value)
6520         (evaluate_funcall, evaluate_subexp_standard): Replace
6521         throw_exception with throw.
6522         * dwarf2loc.c (call_site_find_chain)
6523         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6524         Replace throw_exception with throw.
6525         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6526         with throw.
6527         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6528         throw.
6529         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6530         * completer.c (complete_line_internal): Replace throw_exception
6531         with throw.
6532         * compile/compile-object-run.c (compile_object_run): Replace
6533         throw_exception with throw.
6534         * cli/cli-script.c (process_next_line): Replace throw_exception
6535         with throw.
6536         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6537         (btrace_enable, btrace_maint_update_pt_packets): Replace
6538         throw_exception with throw.
6539         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6540         throw_exception with throw.
6541         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6542         throw_exception with throw.
6543         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6544         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6545         * aarch64-tdep.c (aarch64_make_prologue_cache)
6546         (aarch64_make_stub_cache): Replace throw_exception with throw.
6547
6548 2019-04-08  Tom Tromey  <tom@tromey.com>
6549
6550         * common/common-exceptions.c (throw_exception): Rename from
6551         throw_exception_cxx.  Remove old copy.  Make argument const.
6552         (throw_it): Create and throw exception objects directly.
6553         * common/common-exceptions.h (throw_exception): Make argument
6554         const.
6555         (struct gdb_exception_error): Add constructor.
6556         (struct gdb_exception_quit): Add constructor.
6557
6558 2019-04-08  Tom Tromey  <tom@tromey.com>
6559
6560         * common/common-exceptions.h (exception_rethrow): Don't declare.
6561         (TRY_SJLJ): Update comment.
6562         (TRY, CATCH, END_CATCH): Remove.
6563         * common/common-exceptions.c (exception_rethrow): Remove.
6564
6565 2019-04-08  Tom Tromey  <tom@tromey.com>
6566
6567         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6568         Remove.
6569         (gdb_exception_error): Rename from
6570         gdb_exception_RETURN_MASK_ERROR.
6571         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6572         (gdb_quit_bad_alloc): Update.
6573         * aarch64-tdep.c: Update.
6574         * ada-lang.c: Update.
6575         * ada-typeprint.c: Update.
6576         * ada-valprint.c: Update.
6577         * amd64-tdep.c: Update.
6578         * arch-utils.c: Update.
6579         * break-catch-throw.c: Update.
6580         * breakpoint.c: Update.
6581         * btrace.c: Update.
6582         * c-varobj.c: Update.
6583         * cli/cli-cmds.c: Update.
6584         * cli/cli-interp.c: Update.
6585         * cli/cli-script.c: Update.
6586         * common/common-exceptions.c: Update.
6587         * common/new-op.c: Update.
6588         * common/selftest.c: Update.
6589         * compile/compile-c-symbols.c: Update.
6590         * compile/compile-cplus-symbols.c: Update.
6591         * compile/compile-object-load.c: Update.
6592         * compile/compile-object-run.c: Update.
6593         * completer.c: Update.
6594         * corelow.c: Update.
6595         * cp-abi.c: Update.
6596         * cp-support.c: Update.
6597         * cp-valprint.c: Update.
6598         * darwin-nat.c: Update.
6599         * disasm-selftests.c: Update.
6600         * dtrace-probe.c: Update.
6601         * dwarf-index-cache.c: Update.
6602         * dwarf-index-write.c: Update.
6603         * dwarf2-frame-tailcall.c: Update.
6604         * dwarf2-frame.c: Update.
6605         * dwarf2loc.c: Update.
6606         * dwarf2read.c: Update.
6607         * eval.c: Update.
6608         * event-loop.c: Update.
6609         * event-top.c: Update.
6610         * exec.c: Update.
6611         * f-valprint.c: Update.
6612         * fbsd-tdep.c: Update.
6613         * frame-unwind.c: Update.
6614         * frame.c: Update.
6615         * gdbtypes.c: Update.
6616         * gnu-v3-abi.c: Update.
6617         * guile/guile-internal.h: Update.
6618         * guile/scm-block.c: Update.
6619         * guile/scm-breakpoint.c: Update.
6620         * guile/scm-cmd.c: Update.
6621         * guile/scm-disasm.c: Update.
6622         * guile/scm-frame.c: Update.
6623         * guile/scm-lazy-string.c: Update.
6624         * guile/scm-math.c: Update.
6625         * guile/scm-param.c: Update.
6626         * guile/scm-ports.c: Update.
6627         * guile/scm-pretty-print.c: Update.
6628         * guile/scm-symbol.c: Update.
6629         * guile/scm-symtab.c: Update.
6630         * guile/scm-type.c: Update.
6631         * guile/scm-value.c: Update.
6632         * i386-linux-tdep.c: Update.
6633         * i386-tdep.c: Update.
6634         * inf-loop.c: Update.
6635         * infcall.c: Update.
6636         * infcmd.c: Update.
6637         * infrun.c: Update.
6638         * jit.c: Update.
6639         * language.c: Update.
6640         * linespec.c: Update.
6641         * linux-fork.c: Update.
6642         * linux-nat.c: Update.
6643         * linux-tdep.c: Update.
6644         * linux-thread-db.c: Update.
6645         * main.c: Update.
6646         * mi/mi-cmd-break.c: Update.
6647         * mi/mi-cmd-stack.c: Update.
6648         * mi/mi-interp.c: Update.
6649         * mi/mi-main.c: Update.
6650         * objc-lang.c: Update.
6651         * p-valprint.c: Update.
6652         * parse.c: Update.
6653         * ppc-linux-tdep.c: Update.
6654         * printcmd.c: Update.
6655         * python/py-arch.c: Update.
6656         * python/py-breakpoint.c: Update.
6657         * python/py-cmd.c: Update.
6658         * python/py-finishbreakpoint.c: Update.
6659         * python/py-frame.c: Update.
6660         * python/py-framefilter.c: Update.
6661         * python/py-gdb-readline.c: Update.
6662         * python/py-inferior.c: Update.
6663         * python/py-infthread.c: Update.
6664         * python/py-lazy-string.c: Update.
6665         * python/py-linetable.c: Update.
6666         * python/py-objfile.c: Update.
6667         * python/py-param.c: Update.
6668         * python/py-prettyprint.c: Update.
6669         * python/py-progspace.c: Update.
6670         * python/py-record-btrace.c: Update.
6671         * python/py-record.c: Update.
6672         * python/py-symbol.c: Update.
6673         * python/py-type.c: Update.
6674         * python/py-unwind.c: Update.
6675         * python/py-utils.c: Update.
6676         * python/py-value.c: Update.
6677         * python/python.c: Update.
6678         * record-btrace.c: Update.
6679         * record-full.c: Update.
6680         * remote-fileio.c: Update.
6681         * remote.c: Update.
6682         * riscv-tdep.c: Update.
6683         * rs6000-aix-tdep.c: Update.
6684         * rs6000-tdep.c: Update.
6685         * rust-exp.y: Update.
6686         * rust-lang.c: Update.
6687         * s390-tdep.c: Update.
6688         * selftest-arch.c: Update.
6689         * solib-dsbt.c: Update.
6690         * solib-frv.c: Update.
6691         * solib-spu.c: Update.
6692         * solib-svr4.c: Update.
6693         * solib.c: Update.
6694         * sparc64-linux-tdep.c: Update.
6695         * stack.c: Update.
6696         * symfile-mem.c: Update.
6697         * symmisc.c: Update.
6698         * target.c: Update.
6699         * thread.c: Update.
6700         * top.c: Update.
6701         * tracefile-tfile.c: Update.
6702         * tui/tui.c: Update.
6703         * typeprint.c: Update.
6704         * unittests/cli-utils-selftests.c: Update.
6705         * unittests/parse-connection-spec-selftests.c: Update.
6706         * valops.c: Update.
6707         * valprint.c: Update.
6708         * value.c: Update.
6709         * varobj.c: Update.
6710         * windows-nat.c: Update.
6711         * x86-linux-nat.c: Update.
6712         * xml-support.c: Update.
6713
6714 2019-04-08  Tom Tromey  <tom@tromey.com>
6715
6716         * xml-support.c: Use C++ exception handling.
6717         * x86-linux-nat.c: Use C++ exception handling.
6718         * windows-nat.c: Use C++ exception handling.
6719         * varobj.c: Use C++ exception handling.
6720         * value.c: Use C++ exception handling.
6721         * valprint.c: Use C++ exception handling.
6722         * valops.c: Use C++ exception handling.
6723         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6724         handling.
6725         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6726         * typeprint.c: Use C++ exception handling.
6727         * tui/tui.c: Use C++ exception handling.
6728         * tracefile-tfile.c: Use C++ exception handling.
6729         * top.c: Use C++ exception handling.
6730         * thread.c: Use C++ exception handling.
6731         * target.c: Use C++ exception handling.
6732         * symmisc.c: Use C++ exception handling.
6733         * symfile-mem.c: Use C++ exception handling.
6734         * stack.c: Use C++ exception handling.
6735         * sparc64-linux-tdep.c: Use C++ exception handling.
6736         * solib.c: Use C++ exception handling.
6737         * solib-svr4.c: Use C++ exception handling.
6738         * solib-spu.c: Use C++ exception handling.
6739         * solib-frv.c: Use C++ exception handling.
6740         * solib-dsbt.c: Use C++ exception handling.
6741         * selftest-arch.c: Use C++ exception handling.
6742         * s390-tdep.c: Use C++ exception handling.
6743         * rust-lang.c: Use C++ exception handling.
6744         * rust-exp.y: Use C++ exception handling.
6745         * rs6000-tdep.c: Use C++ exception handling.
6746         * rs6000-aix-tdep.c: Use C++ exception handling.
6747         * riscv-tdep.c: Use C++ exception handling.
6748         * remote.c: Use C++ exception handling.
6749         * remote-fileio.c: Use C++ exception handling.
6750         * record-full.c: Use C++ exception handling.
6751         * record-btrace.c: Use C++ exception handling.
6752         * python/python.c: Use C++ exception handling.
6753         * python/py-value.c: Use C++ exception handling.
6754         * python/py-utils.c: Use C++ exception handling.
6755         * python/py-unwind.c: Use C++ exception handling.
6756         * python/py-type.c: Use C++ exception handling.
6757         * python/py-symbol.c: Use C++ exception handling.
6758         * python/py-record.c: Use C++ exception handling.
6759         * python/py-record-btrace.c: Use C++ exception handling.
6760         * python/py-progspace.c: Use C++ exception handling.
6761         * python/py-prettyprint.c: Use C++ exception handling.
6762         * python/py-param.c: Use C++ exception handling.
6763         * python/py-objfile.c: Use C++ exception handling.
6764         * python/py-linetable.c: Use C++ exception handling.
6765         * python/py-lazy-string.c: Use C++ exception handling.
6766         * python/py-infthread.c: Use C++ exception handling.
6767         * python/py-inferior.c: Use C++ exception handling.
6768         * python/py-gdb-readline.c: Use C++ exception handling.
6769         * python/py-framefilter.c: Use C++ exception handling.
6770         * python/py-frame.c: Use C++ exception handling.
6771         * python/py-finishbreakpoint.c: Use C++ exception handling.
6772         * python/py-cmd.c: Use C++ exception handling.
6773         * python/py-breakpoint.c: Use C++ exception handling.
6774         * python/py-arch.c: Use C++ exception handling.
6775         * printcmd.c: Use C++ exception handling.
6776         * ppc-linux-tdep.c: Use C++ exception handling.
6777         * parse.c: Use C++ exception handling.
6778         * p-valprint.c: Use C++ exception handling.
6779         * objc-lang.c: Use C++ exception handling.
6780         * mi/mi-main.c: Use C++ exception handling.
6781         * mi/mi-interp.c: Use C++ exception handling.
6782         * mi/mi-cmd-stack.c: Use C++ exception handling.
6783         * mi/mi-cmd-break.c: Use C++ exception handling.
6784         * main.c: Use C++ exception handling.
6785         * linux-thread-db.c: Use C++ exception handling.
6786         * linux-tdep.c: Use C++ exception handling.
6787         * linux-nat.c: Use C++ exception handling.
6788         * linux-fork.c: Use C++ exception handling.
6789         * linespec.c: Use C++ exception handling.
6790         * language.c: Use C++ exception handling.
6791         * jit.c: Use C++ exception handling.
6792         * infrun.c: Use C++ exception handling.
6793         * infcmd.c: Use C++ exception handling.
6794         * infcall.c: Use C++ exception handling.
6795         * inf-loop.c: Use C++ exception handling.
6796         * i386-tdep.c: Use C++ exception handling.
6797         * i386-linux-tdep.c: Use C++ exception handling.
6798         * guile/scm-value.c: Use C++ exception handling.
6799         * guile/scm-type.c: Use C++ exception handling.
6800         * guile/scm-symtab.c: Use C++ exception handling.
6801         * guile/scm-symbol.c: Use C++ exception handling.
6802         * guile/scm-pretty-print.c: Use C++ exception handling.
6803         * guile/scm-ports.c: Use C++ exception handling.
6804         * guile/scm-param.c: Use C++ exception handling.
6805         * guile/scm-math.c: Use C++ exception handling.
6806         * guile/scm-lazy-string.c: Use C++ exception handling.
6807         * guile/scm-frame.c: Use C++ exception handling.
6808         * guile/scm-disasm.c: Use C++ exception handling.
6809         * guile/scm-cmd.c: Use C++ exception handling.
6810         * guile/scm-breakpoint.c: Use C++ exception handling.
6811         * guile/scm-block.c: Use C++ exception handling.
6812         * guile/guile-internal.h: Use C++ exception handling.
6813         * gnu-v3-abi.c: Use C++ exception handling.
6814         * gdbtypes.c: Use C++ exception handling.
6815         * frame.c: Use C++ exception handling.
6816         * frame-unwind.c: Use C++ exception handling.
6817         * fbsd-tdep.c: Use C++ exception handling.
6818         * f-valprint.c: Use C++ exception handling.
6819         * exec.c: Use C++ exception handling.
6820         * event-top.c: Use C++ exception handling.
6821         * event-loop.c: Use C++ exception handling.
6822         * eval.c: Use C++ exception handling.
6823         * dwarf2read.c: Use C++ exception handling.
6824         * dwarf2loc.c: Use C++ exception handling.
6825         * dwarf2-frame.c: Use C++ exception handling.
6826         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6827         * dwarf-index-write.c: Use C++ exception handling.
6828         * dwarf-index-cache.c: Use C++ exception handling.
6829         * dtrace-probe.c: Use C++ exception handling.
6830         * disasm-selftests.c: Use C++ exception handling.
6831         * darwin-nat.c: Use C++ exception handling.
6832         * cp-valprint.c: Use C++ exception handling.
6833         * cp-support.c: Use C++ exception handling.
6834         * cp-abi.c: Use C++ exception handling.
6835         * corelow.c: Use C++ exception handling.
6836         * completer.c: Use C++ exception handling.
6837         * compile/compile-object-run.c: Use C++ exception handling.
6838         * compile/compile-object-load.c: Use C++ exception handling.
6839         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6840         * compile/compile-c-symbols.c: Use C++ exception handling.
6841         * common/selftest.c: Use C++ exception handling.
6842         * common/new-op.c: Use C++ exception handling.
6843         * cli/cli-script.c: Use C++ exception handling.
6844         * cli/cli-interp.c: Use C++ exception handling.
6845         * cli/cli-cmds.c: Use C++ exception handling.
6846         * c-varobj.c: Use C++ exception handling.
6847         * btrace.c: Use C++ exception handling.
6848         * breakpoint.c: Use C++ exception handling.
6849         * break-catch-throw.c: Use C++ exception handling.
6850         * arch-utils.c: Use C++ exception handling.
6851         * amd64-tdep.c: Use C++ exception handling.
6852         * ada-valprint.c: Use C++ exception handling.
6853         * ada-typeprint.c: Use C++ exception handling.
6854         * ada-lang.c: Use C++ exception handling.
6855         * aarch64-tdep.c: Use C++ exception handling.
6856
6857 2019-04-08  Tom Tromey  <tom@tromey.com>
6858
6859         * xml-support.c (gdb_xml_parser::parse): Update.
6860         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6861         * value.c (show_convenience): Update.
6862         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6863         (test_parse_flags_qcs): Update.
6864         * thread.c (thr_try_catch_cmd): Update.
6865         * target.c (target_translate_tls_address): Update.
6866         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6867         (info_frame_command_core, frame_apply_command_count): Update.
6868         * rust-exp.y (rust_lex_exception_test): Update.
6869         * riscv-tdep.c (riscv_print_one_register_info): Update.
6870         * remote.c (remote_target::enable_btrace): Update.
6871         * record-btrace.c (record_btrace_enable_warn): Update.
6872         * python/py-utils.c (gdbpy_convert_exception): Update.
6873         * printcmd.c (do_one_display, print_variable_and_value): Update.
6874         * mi/mi-main.c (mi_print_exception): Update.
6875         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6876         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6877         * linux-nat.c (linux_nat_target::attach): Update.
6878         * linux-fork.c (class scoped_switch_fork_info): Update.
6879         * infrun.c (displaced_step_prepare): Update.
6880         * infcall.c (call_function_by_hand_dummy): Update.
6881         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6882         * gnu-v3-abi.c (print_one_vtable): Update.
6883         * frame.c (get_prev_frame_always): Update.
6884         * f-valprint.c (info_common_command_for_block): Update.
6885         * exec.c (try_open_exec_file): Update.
6886         * exceptions.c (print_exception, exception_print)
6887         (exception_fprintf, exception_print_same): Update.
6888         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6889         * dwarf-index-cache.c (index_cache::store)
6890         (index_cache::lookup_gdb_index): Update.
6891         * darwin-nat.c (maybe_cache_shell): Update.
6892         * cp-valprint.c (cp_print_value_fields): Update.
6893         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6894         (gcc_cplus_symbol_address): Update.
6895         * compile/compile-c-symbols.c (gcc_convert_symbol)
6896         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6897         * common/selftest.c: Update.
6898         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6899         a std::string.
6900         (exception_try_scope_entry, exception_try_scope_exit): Don't
6901         declare.
6902         (struct exception_try_scope): Remove.
6903         (TRY): Don't use exception_try_scope.
6904         (struct gdb_exception): Add constructor, operator=.
6905         <what>: New method.
6906         (struct gdb_exception_RETURN_MASK_ALL)
6907         (struct gdb_exception_RETURN_MASK_ERROR)
6908         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6909         (struct gdb_quit_bad_alloc): Update.
6910         * common/common-exceptions.c (exception_none): Change
6911         initializer.
6912         (struct catcher) <state, exception>: Initialize inline.
6913         <prev>: Remove member.
6914         (current_catcher): Remove.
6915         (catchers): New global.
6916         (exceptions_state_mc_init): Simplify.
6917         (catcher_pop): Remove.
6918         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6919         (try_scope_depth, exception_try_scope_entry)
6920         (exception_try_scope_exit): Remove.
6921         (throw_exception_sjlj): Update.
6922         (exception_messages, exception_messages_size): Remove.
6923         (throw_it): Simplify.
6924         (gdb_exception_sliced_copy): Remove.
6925         (throw_exception_cxx): Update.
6926         * cli/cli-script.c (script_from_file): Update.
6927         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6928         Update.
6929         * ada-valprint.c (ada_val_print): Update.
6930         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6931         (create_excep_cond_exprs): Update.
6932
6933 2019-04-08  Tom Tromey  <tom@tromey.com>
6934
6935         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6936         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6937         (TRY, CATCH, END_CATCH): Remove some definitions.
6938         * common/common-exceptions.c: Don't use GDB_XCPT.
6939         (catcher_list_size): Remove.
6940         (throw_exception, throw_it): Simplify.
6941
6942 2019-04-05  Tom Tromey  <tom@tromey.com>
6943
6944         Revert the header-sorting patch.
6945         * ft32-tdep.c: Revert.
6946         * frv-tdep.c: Revert.
6947         * frv-linux-tdep.c: Revert.
6948         * frame.c: Revert.
6949         * frame-unwind.c: Revert.
6950         * frame-base.c: Revert.
6951         * fork-child.c: Revert.
6952         * findvar.c: Revert.
6953         * findcmd.c: Revert.
6954         * filesystem.c: Revert.
6955         * filename-seen-cache.h: Revert.
6956         * filename-seen-cache.c: Revert.
6957         * fbsd-tdep.c: Revert.
6958         * fbsd-nat.h: Revert.
6959         * fbsd-nat.c: Revert.
6960         * f-valprint.c: Revert.
6961         * f-typeprint.c: Revert.
6962         * f-lang.c: Revert.
6963         * extension.h: Revert.
6964         * extension.c: Revert.
6965         * extension-priv.h: Revert.
6966         * expprint.c: Revert.
6967         * exec.h: Revert.
6968         * exec.c: Revert.
6969         * exceptions.c: Revert.
6970         * event-top.c: Revert.
6971         * event-loop.c: Revert.
6972         * eval.c: Revert.
6973         * elfread.c: Revert.
6974         * dwarf2read.h: Revert.
6975         * dwarf2read.c: Revert.
6976         * dwarf2loc.c: Revert.
6977         * dwarf2expr.h: Revert.
6978         * dwarf2expr.c: Revert.
6979         * dwarf2-frame.c: Revert.
6980         * dwarf2-frame-tailcall.c: Revert.
6981         * dwarf-index-write.h: Revert.
6982         * dwarf-index-write.c: Revert.
6983         * dwarf-index-common.c: Revert.
6984         * dwarf-index-cache.h: Revert.
6985         * dwarf-index-cache.c: Revert.
6986         * dummy-frame.c: Revert.
6987         * dtrace-probe.c: Revert.
6988         * disasm.h: Revert.
6989         * disasm.c: Revert.
6990         * disasm-selftests.c: Revert.
6991         * dictionary.c: Revert.
6992         * dicos-tdep.c: Revert.
6993         * demangle.c: Revert.
6994         * dcache.h: Revert.
6995         * dcache.c: Revert.
6996         * darwin-nat.h: Revert.
6997         * darwin-nat.c: Revert.
6998         * darwin-nat-info.c: Revert.
6999         * d-valprint.c: Revert.
7000         * d-namespace.c: Revert.
7001         * d-lang.c: Revert.
7002         * ctf.c: Revert.
7003         * csky-tdep.c: Revert.
7004         * csky-linux-tdep.c: Revert.
7005         * cris-tdep.c: Revert.
7006         * cris-linux-tdep.c: Revert.
7007         * cp-valprint.c: Revert.
7008         * cp-support.c: Revert.
7009         * cp-namespace.c: Revert.
7010         * cp-abi.c: Revert.
7011         * corelow.c: Revert.
7012         * corefile.c: Revert.
7013         * continuations.c: Revert.
7014         * completer.h: Revert.
7015         * completer.c: Revert.
7016         * complaints.c: Revert.
7017         * coffread.c: Revert.
7018         * coff-pe-read.c: Revert.
7019         * cli-out.h: Revert.
7020         * cli-out.c: Revert.
7021         * charset.c: Revert.
7022         * c-varobj.c: Revert.
7023         * c-valprint.c: Revert.
7024         * c-typeprint.c: Revert.
7025         * c-lang.c: Revert.
7026         * buildsym.c: Revert.
7027         * buildsym-legacy.c: Revert.
7028         * build-id.h: Revert.
7029         * build-id.c: Revert.
7030         * btrace.c: Revert.
7031         * bsd-uthread.c: Revert.
7032         * breakpoint.h: Revert.
7033         * breakpoint.c: Revert.
7034         * break-catch-throw.c: Revert.
7035         * break-catch-syscall.c: Revert.
7036         * break-catch-sig.c: Revert.
7037         * blockframe.c: Revert.
7038         * block.c: Revert.
7039         * bfin-tdep.c: Revert.
7040         * bfin-linux-tdep.c: Revert.
7041         * bfd-target.c: Revert.
7042         * bcache.c: Revert.
7043         * ax-general.c: Revert.
7044         * ax-gdb.h: Revert.
7045         * ax-gdb.c: Revert.
7046         * avr-tdep.c: Revert.
7047         * auxv.c: Revert.
7048         * auto-load.c: Revert.
7049         * arm-wince-tdep.c: Revert.
7050         * arm-tdep.c: Revert.
7051         * arm-symbian-tdep.c: Revert.
7052         * arm-pikeos-tdep.c: Revert.
7053         * arm-obsd-tdep.c: Revert.
7054         * arm-nbsd-tdep.c: Revert.
7055         * arm-nbsd-nat.c: Revert.
7056         * arm-linux-tdep.c: Revert.
7057         * arm-linux-nat.c: Revert.
7058         * arm-fbsd-tdep.c: Revert.
7059         * arm-fbsd-nat.c: Revert.
7060         * arm-bsd-tdep.c: Revert.
7061         * arch-utils.c: Revert.
7062         * arc-tdep.c: Revert.
7063         * arc-newlib-tdep.c: Revert.
7064         * annotate.h: Revert.
7065         * annotate.c: Revert.
7066         * amd64-windows-tdep.c: Revert.
7067         * amd64-windows-nat.c: Revert.
7068         * amd64-tdep.c: Revert.
7069         * amd64-sol2-tdep.c: Revert.
7070         * amd64-obsd-tdep.c: Revert.
7071         * amd64-obsd-nat.c: Revert.
7072         * amd64-nbsd-tdep.c: Revert.
7073         * amd64-nbsd-nat.c: Revert.
7074         * amd64-nat.c: Revert.
7075         * amd64-linux-tdep.c: Revert.
7076         * amd64-linux-nat.c: Revert.
7077         * amd64-fbsd-tdep.c: Revert.
7078         * amd64-fbsd-nat.c: Revert.
7079         * amd64-dicos-tdep.c: Revert.
7080         * amd64-darwin-tdep.c: Revert.
7081         * amd64-bsd-nat.c: Revert.
7082         * alpha-tdep.c: Revert.
7083         * alpha-obsd-tdep.c: Revert.
7084         * alpha-nbsd-tdep.c: Revert.
7085         * alpha-mdebug-tdep.c: Revert.
7086         * alpha-linux-tdep.c: Revert.
7087         * alpha-linux-nat.c: Revert.
7088         * alpha-bsd-tdep.c: Revert.
7089         * alpha-bsd-nat.c: Revert.
7090         * aix-thread.c: Revert.
7091         * agent.c: Revert.
7092         * addrmap.c: Revert.
7093         * ada-varobj.c: Revert.
7094         * ada-valprint.c: Revert.
7095         * ada-typeprint.c: Revert.
7096         * ada-tasks.c: Revert.
7097         * ada-lang.c: Revert.
7098         * aarch64-tdep.c: Revert.
7099         * aarch64-ravenscar-thread.c: Revert.
7100         * aarch64-newlib-tdep.c: Revert.
7101         * aarch64-linux-tdep.c: Revert.
7102         * aarch64-linux-nat.c: Revert.
7103         * aarch64-fbsd-tdep.c: Revert.
7104         * aarch64-fbsd-nat.c: Revert.
7105         * aarch32-linux-nat.c: Revert.
7106
7107 2019-04-05  Tom Tromey  <tom@tromey.com>
7108
7109         * ft32-tdep.c: Sort headers.
7110         * frv-tdep.c: Sort headers.
7111         * frv-linux-tdep.c: Sort headers.
7112         * frame.c: Sort headers.
7113         * frame-unwind.c: Sort headers.
7114         * frame-base.c: Sort headers.
7115         * fork-child.c: Sort headers.
7116         * findvar.c: Sort headers.
7117         * findcmd.c: Sort headers.
7118         * filesystem.c: Sort headers.
7119         * filename-seen-cache.h: Sort headers.
7120         * filename-seen-cache.c: Sort headers.
7121         * fbsd-tdep.c: Sort headers.
7122         * fbsd-nat.h: Sort headers.
7123         * fbsd-nat.c: Sort headers.
7124         * f-valprint.c: Sort headers.
7125         * f-typeprint.c: Sort headers.
7126         * f-lang.c: Sort headers.
7127         * extension.h: Sort headers.
7128         * extension.c: Sort headers.
7129         * extension-priv.h: Sort headers.
7130         * expprint.c: Sort headers.
7131         * exec.h: Sort headers.
7132         * exec.c: Sort headers.
7133         * exceptions.c: Sort headers.
7134         * event-top.c: Sort headers.
7135         * event-loop.c: Sort headers.
7136         * eval.c: Sort headers.
7137         * elfread.c: Sort headers.
7138         * dwarf2read.h: Sort headers.
7139         * dwarf2read.c: Sort headers.
7140         * dwarf2loc.c: Sort headers.
7141         * dwarf2expr.h: Sort headers.
7142         * dwarf2expr.c: Sort headers.
7143         * dwarf2-frame.c: Sort headers.
7144         * dwarf2-frame-tailcall.c: Sort headers.
7145         * dwarf-index-write.h: Sort headers.
7146         * dwarf-index-write.c: Sort headers.
7147         * dwarf-index-common.c: Sort headers.
7148         * dwarf-index-cache.h: Sort headers.
7149         * dwarf-index-cache.c: Sort headers.
7150         * dummy-frame.c: Sort headers.
7151         * dtrace-probe.c: Sort headers.
7152         * disasm.h: Sort headers.
7153         * disasm.c: Sort headers.
7154         * disasm-selftests.c: Sort headers.
7155         * dictionary.c: Sort headers.
7156         * dicos-tdep.c: Sort headers.
7157         * demangle.c: Sort headers.
7158         * dcache.h: Sort headers.
7159         * dcache.c: Sort headers.
7160         * darwin-nat.h: Sort headers.
7161         * darwin-nat.c: Sort headers.
7162         * darwin-nat-info.c: Sort headers.
7163         * d-valprint.c: Sort headers.
7164         * d-namespace.c: Sort headers.
7165         * d-lang.c: Sort headers.
7166         * ctf.c: Sort headers.
7167         * csky-tdep.c: Sort headers.
7168         * csky-linux-tdep.c: Sort headers.
7169         * cris-tdep.c: Sort headers.
7170         * cris-linux-tdep.c: Sort headers.
7171         * cp-valprint.c: Sort headers.
7172         * cp-support.c: Sort headers.
7173         * cp-namespace.c: Sort headers.
7174         * cp-abi.c: Sort headers.
7175         * corelow.c: Sort headers.
7176         * corefile.c: Sort headers.
7177         * continuations.c: Sort headers.
7178         * completer.h: Sort headers.
7179         * completer.c: Sort headers.
7180         * complaints.c: Sort headers.
7181         * coffread.c: Sort headers.
7182         * coff-pe-read.c: Sort headers.
7183         * cli-out.h: Sort headers.
7184         * cli-out.c: Sort headers.
7185         * charset.c: Sort headers.
7186         * c-varobj.c: Sort headers.
7187         * c-valprint.c: Sort headers.
7188         * c-typeprint.c: Sort headers.
7189         * c-lang.c: Sort headers.
7190         * buildsym.c: Sort headers.
7191         * buildsym-legacy.c: Sort headers.
7192         * build-id.h: Sort headers.
7193         * build-id.c: Sort headers.
7194         * btrace.c: Sort headers.
7195         * bsd-uthread.c: Sort headers.
7196         * breakpoint.h: Sort headers.
7197         * breakpoint.c: Sort headers.
7198         * break-catch-throw.c: Sort headers.
7199         * break-catch-syscall.c: Sort headers.
7200         * break-catch-sig.c: Sort headers.
7201         * blockframe.c: Sort headers.
7202         * block.c: Sort headers.
7203         * bfin-tdep.c: Sort headers.
7204         * bfin-linux-tdep.c: Sort headers.
7205         * bfd-target.c: Sort headers.
7206         * bcache.c: Sort headers.
7207         * ax-general.c: Sort headers.
7208         * ax-gdb.h: Sort headers.
7209         * ax-gdb.c: Sort headers.
7210         * avr-tdep.c: Sort headers.
7211         * auxv.c: Sort headers.
7212         * auto-load.c: Sort headers.
7213         * arm-wince-tdep.c: Sort headers.
7214         * arm-tdep.c: Sort headers.
7215         * arm-symbian-tdep.c: Sort headers.
7216         * arm-pikeos-tdep.c: Sort headers.
7217         * arm-obsd-tdep.c: Sort headers.
7218         * arm-nbsd-tdep.c: Sort headers.
7219         * arm-nbsd-nat.c: Sort headers.
7220         * arm-linux-tdep.c: Sort headers.
7221         * arm-linux-nat.c: Sort headers.
7222         * arm-fbsd-tdep.c: Sort headers.
7223         * arm-fbsd-nat.c: Sort headers.
7224         * arm-bsd-tdep.c: Sort headers.
7225         * arch-utils.c: Sort headers.
7226         * arc-tdep.c: Sort headers.
7227         * arc-newlib-tdep.c: Sort headers.
7228         * annotate.h: Sort headers.
7229         * annotate.c: Sort headers.
7230         * amd64-windows-tdep.c: Sort headers.
7231         * amd64-windows-nat.c: Sort headers.
7232         * amd64-tdep.c: Sort headers.
7233         * amd64-sol2-tdep.c: Sort headers.
7234         * amd64-obsd-tdep.c: Sort headers.
7235         * amd64-obsd-nat.c: Sort headers.
7236         * amd64-nbsd-tdep.c: Sort headers.
7237         * amd64-nbsd-nat.c: Sort headers.
7238         * amd64-nat.c: Sort headers.
7239         * amd64-linux-tdep.c: Sort headers.
7240         * amd64-linux-nat.c: Sort headers.
7241         * amd64-fbsd-tdep.c: Sort headers.
7242         * amd64-fbsd-nat.c: Sort headers.
7243         * amd64-dicos-tdep.c: Sort headers.
7244         * amd64-darwin-tdep.c: Sort headers.
7245         * amd64-bsd-nat.c: Sort headers.
7246         * alpha-tdep.c: Sort headers.
7247         * alpha-obsd-tdep.c: Sort headers.
7248         * alpha-nbsd-tdep.c: Sort headers.
7249         * alpha-mdebug-tdep.c: Sort headers.
7250         * alpha-linux-tdep.c: Sort headers.
7251         * alpha-linux-nat.c: Sort headers.
7252         * alpha-bsd-tdep.c: Sort headers.
7253         * alpha-bsd-nat.c: Sort headers.
7254         * aix-thread.c: Sort headers.
7255         * agent.c: Sort headers.
7256         * addrmap.c: Sort headers.
7257         * ada-varobj.c: Sort headers.
7258         * ada-valprint.c: Sort headers.
7259         * ada-typeprint.c: Sort headers.
7260         * ada-tasks.c: Sort headers.
7261         * ada-lang.c: Sort headers.
7262         * aarch64-tdep.c: Sort headers.
7263         * aarch64-ravenscar-thread.c: Sort headers.
7264         * aarch64-newlib-tdep.c: Sort headers.
7265         * aarch64-linux-tdep.c: Sort headers.
7266         * aarch64-linux-nat.c: Sort headers.
7267         * aarch64-fbsd-tdep.c: Sort headers.
7268         * aarch64-fbsd-nat.c: Sort headers.
7269         * aarch32-linux-nat.c: Sort headers.
7270
7271 2019-04-04  Tom Tromey  <tom@tromey.com>
7272
7273         * varobj.c (varobj_create): Update.
7274         * rust-exp.y (struct rust_parser) <update_innermost_block,
7275         lookup_symbol>: New methods.
7276         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7277         Rename.
7278         (rust_parser::rust_lookup_type)
7279         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7280         * printcmd.c (display_command, do_one_display): Update.
7281         * parser-defs.h (struct parser_state) <parser_state>: Add
7282         "tracker" parameter.
7283         (block_tracker): New member.
7284         (class innermost_block_tracker) <innermost_block_tracker>: Add
7285         "types" parameter.
7286         <reset>: Remove method.
7287         (innermost_block): Don't declare.
7288         (null_post_parser): Update.
7289         * parse.c (innermost_block): Remove global.
7290         (write_dollar_variable): Update.
7291         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7292         Remove "tracker_types" parameter.
7293         (parse_expression): Add "tracker" parameter.
7294         (parse_expression_for_completion): Update.
7295         (null_post_parser): Add "tracker" parameter.
7296         * p-exp.y: Update rules.
7297         * m2-exp.y: Update rules.
7298         * language.h (struct language_defn) <la_post_parser>: Add
7299         "tracker" parameter.
7300         * go-exp.y: Update rules.
7301         * f-exp.y: Update rules.
7302         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7303         parameter.
7304         * d-exp.y: Update rules.
7305         * c-exp.y: Update rules.
7306         * breakpoint.c (set_breakpoint_condition): Create an
7307         innermost_block_tracker.
7308         (watch_command_1): Likewise.
7309         * ada-lang.c (resolve): Add "tracker" parameter.
7310         (resolve_subexp): Likewise.
7311         * ada-exp.y (write_var_from_sym): Update.
7312
7313 2019-04-04  Tom Tromey  <tom@tromey.com>
7314
7315         * type-stack.h: New file.
7316         * type-stack.c: New file.
7317         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7318         type-stack.h.
7319         (insert_into_type_stack, insert_type, push_type, push_type_int)
7320         (insert_type_address_space, pop_type, pop_type_int)
7321         (pop_typelist, pop_type_stack, append_type_stack)
7322         (push_type_stack, get_type_stack, push_typelist)
7323         (follow_type_instance_flags, follow_types): Don't declare.
7324         * parse.c (type_stack): Remove global.
7325         (parse_exp_in_context): Update.
7326         (insert_into_type_stack, insert_type, push_type, push_type_int)
7327         (insert_type_address_space, pop_type, pop_type_int)
7328         (pop_typelist, pop_type_stack, append_type_stack)
7329         (push_type_stack, get_type_stack, push_typelist)
7330         (follow_type_instance_flags, follow_types): Remove (moved to
7331         type-stack.c).
7332         * f-exp.y (type_stack): New global.
7333         Update rules.
7334         (push_kind_type, f_parse): Update.
7335         * d-exp.y (type_stack): New global.
7336         Update rules.
7337         (d_parse): Update.
7338         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7339         Update rules.
7340         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7341         (HFILES_NO_SRCDIR): Add type-stack.h.
7342
7343 2019-04-04  Tom Tromey  <tom@tromey.com>
7344
7345         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7346         (rust_parser::convert_ast_to_expression, rust_parse)
7347         (rust_lex_test_completion, rust_lex_tests): Update.
7348         * parser-defs.h (struct expr_completion_state): New.
7349         (struct parser_state) <parser_state>: Add completion parameter.
7350         <mark_struct_expression, mark_completion_tag>: New methods.
7351         <parse_completion, m_completion_state>: New members.
7352         (prefixify_expression, null_post_parser): Update.
7353         (mark_struct_expression, mark_completion_tag): Don't declare.
7354         * parse.c (parse_completion, expout_last_struct)
7355         (expout_tag_completion_type, expout_completion_name): Remove
7356         globals.
7357         (parser_state::mark_struct_expression)
7358         (parser_state::mark_completion_tag): Now methods.
7359         (prefixify_expression): Add last_struct parameter.
7360         (prefixify_subexp): Likewise.
7361         (parse_exp_1): Update.
7362         (parse_exp_in_context): Add cstate parameter.  Update.
7363         (parse_expression_for_completion): Create an
7364         expr_completion_state.
7365         (null_post_parser): Add "completion" parameter.
7366         * p-exp.y: Update rules.
7367         (yylex): Update.
7368         * language.h (struct language_defn) <la_post_parser>: Add
7369         "completing" parameter.
7370         * go-exp.y: Update rules.
7371         (lex_one_token): Update.
7372         * expression.h (parse_completion): Don't declare.
7373         * d-exp.y: Update rules.
7374         (lex_one_token): Update rules.
7375         * c-exp.y: Update rules.
7376         (lex_one_token): Update.
7377         * ada-lang.c (resolve): Add "parse_completion" parameter.
7378         (resolve_subexp): Likewise.
7379         (ada_resolve_function): Likewise.
7380
7381 2019-04-04  Tom Tromey  <tom@tromey.com>
7382
7383         * parser-defs.h (struct parser_state) <start_arglist,
7384         end_arglist>: New methods.
7385         <arglist_len, m_funcall_chain>: New members.
7386         (arglist_len, start_arglist, end_arglist): Don't declare.
7387         * parse.c (arglist_len, funcall_chain): Remove global.
7388         (start_arglist, end_arglist): Remove functions.
7389         (parse_exp_in_context): Update.
7390         * p-exp.y: Update rules.
7391         * m2-exp.y: Update rules.
7392         * go-exp.y: Update rules.
7393         * f-exp.y: Update rules.
7394         * d-exp.y: Update rules.
7395         * c-exp.y: Update rules.
7396
7397 2019-04-04  Tom Tromey  <tom@tromey.com>
7398
7399         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7400         lex_operator, push_back>: New methods.
7401         Update all rules.
7402         (rust_parser::lex_hex, lex_escape): Rename and update.
7403         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7404         (rust_parser::lex_operator): Rename and update.
7405         (rust_parser::lex_number, rustyylex, rustyyerror)
7406         (rust_lex_test_init, rust_lex_test_sequence)
7407         (rust_lex_test_push_back, rust_lex_tests): Update.
7408         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7409         parameter.
7410         <lexptr, prev_lexptr>: New members.
7411         (lexptr, prev_lexptr): Don't declare.
7412         * parse.c (lexptr, prev_lexptr): Remove globals.
7413         (parse_exp_in_context): Update.
7414         * p-exp.y (yylex, yyerror): Update.
7415         * m2-exp.y (parse_number, yylex, yyerror): Update.
7416         * go-exp.y (lex_one_token, yyerror): Update.
7417         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7418         * d-exp.y (lex_one_token, yyerror): Update.
7419         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7420         (lex_one_token, yyerror): Update.
7421         * ada-lex.l (YY_INPUT): Update.
7422         (rewind_to_char): Update.
7423         * ada-exp.y (yyerror): Update.
7424
7425 2019-04-04  Tom Tromey  <tom@tromey.com>
7426
7427         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7428         * parser-defs.h (struct parser_state) <parser_state>: Add new
7429         parameter.
7430         <comma_terminates>: New member.
7431         (comma_terminates): Don't declare global.
7432         * parse.c (comma_terminates): Remove global.
7433         (parse_exp_in_context): Update.
7434         * p-exp.y (yylex): Update.
7435         * m2-exp.y (yylex): Update.
7436         * go-exp.y (lex_one_token): Update.
7437         * f-exp.y (yylex): Update.
7438         * d-exp.y (lex_one_token): Update.
7439         * c-exp.y (lex_one_token): Update.
7440         * ada-lex.l: Update.
7441
7442 2019-04-04  Tom Tromey  <tom@tromey.com>
7443
7444         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7445         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7446         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7447         * parser-defs.h (paren_depth): Don't declare.
7448         * parse.c (paren_depth): Remove global.
7449         (parse_exp_in_context): Update.
7450         * p-exp.y (paren_depth): New global.
7451         (pascal_parse): Initialize it.
7452         * m2-exp.y (paren_depth): New global.
7453         (m2_parse): Initialize it.
7454         * go-exp.y (paren_depth): New global.
7455         (go_parse): Initialize it.
7456         * f-exp.y (paren_depth): New global.
7457         (f_parse): Initialize it.
7458         * d-exp.y (paren_depth): New global.
7459         (d_parse): Initialize it.
7460         * c-exp.y (paren_depth): New global.
7461         (c_parse): Initialize it.
7462         * ada-lex.l (paren_depth): New global.
7463         (lexer_init): Initialize it.
7464
7465 2019-04-04  Tom Tromey  <tom@tromey.com>
7466
7467         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7468         (rust_parser::convert_ast_to_type)
7469         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7470         * parser-defs.h (struct parser_state) <parser_state>: Add
7471         parameters.  Initialize new members.
7472         <expression_context_block, expression_context_pc>: New members.
7473         * parse.c (expression_context_block, expression_context_pc):
7474         Remove globals.
7475         (parse_exp_in_context): Update.
7476         * p-exp.y: Update all rules.
7477         (yylex): Update.
7478         * m2-exp.y: Update all rules.
7479         (yylex): Update.
7480         * go-exp.y (yylex): Update.
7481         * f-exp.y (yylex): Update.
7482         * d-exp.y: Update all rules.
7483         (yylex): Update.
7484         * c-exp.y: Update all rules.
7485         (lex_one_token, classify_name, yylex, c_parse): Update.
7486         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7487
7488 2019-04-04  Tom Tromey  <tom@tromey.com>
7489
7490         * gdbarch.h, gdbarch.c: Rebuild.
7491         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7492         * stap-probe.h:
7493         (struct stap_parse_info): Replace "parser_state" with
7494         "expr_builder".
7495         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7496         (parser_state): New class.
7497         * parse.c (expr_builder): Rename.
7498         (expr_builder::release): Rename.
7499         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7500         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7501         (write_exp_elt_longcst, write_exp_elt_floatcst)
7502         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7503         (write_exp_string_vector, write_exp_bitstring)
7504         (write_exp_msymbol, mark_struct_expression)
7505         (write_dollar_variable)
7506         (insert_type_address_space, increase_expout_size): Replace
7507         "parser_state" with "expr_builder".
7508         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7509         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7510         "parser_state" with "expr_builder".
7511
7512 2019-04-04  Tom Tromey  <tom@tromey.com>
7513
7514         * rust-exp.y: Replace "parse_language" with method call.
7515         * p-exp.y:
7516         (yylex): Replace "parse_language" with method call.
7517         * m2-exp.y:
7518         (yylex): Replace "parse_language" with method call.
7519         * go-exp.y (classify_name): Replace "parse_language" with method
7520         call.
7521         * f-exp.y (yylex): Replace "parse_language" with method call.
7522         * d-exp.y (lex_one_token): Replace "parse_language" with method
7523         call.
7524         * c-exp.y:
7525         (lex_one_token, classify_name, yylex): Replace "parse_language"
7526         with method call.
7527         * ada-exp.y (find_primitive_type, type_char)
7528         (type_system_address): Replace "parse_language" with method call.
7529
7530 2019-04-04  Tom Tromey  <tom@tromey.com>
7531
7532         * rust-exp.y: Replace "parse_gdbarch" with method call.
7533         * parse.c (write_dollar_variable, insert_type_address_space):
7534         Replace "parse_gdbarch" with method call.
7535         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7536         call.
7537         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7538         call.
7539         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7540         "parse_gdbarch" with method call.
7541         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7542         with method call.
7543         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7544         "parse_gdbarch" with method call.
7545         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7546         "parse_gdbarch" with method call.
7547         * c-exp.y (parse_type, parse_number, classify_name): Replace
7548         "parse_gdbarch" with method call.
7549         * ada-lex.l: Replace "parse_gdbarch" with method call.
7550         * ada-exp.y (parse_type, find_primitive_type, type_char)
7551         (type_system_address): Replace "parse_gdbarch" with method call.
7552
7553 2019-04-04  Tom Tromey  <tom@tromey.com>
7554
7555         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7556         * stap-probe.c (stap_parse_argument): Update.
7557         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7558         initial_size parameter.
7559         * rust-exp.y (rust_lex_tests): Update.
7560         * parse.c (parser_state): Update.
7561         (parse_exp_in_context): Update.
7562         * parser-defs.h (struct parser_state) <parser_state>: Remove
7563         "initial_size" parameter.
7564
7565 2019-04-04  Tom Tromey  <tom@tromey.com>
7566
7567         * parser-defs.h (increase_expout_size): Don't declare.
7568         * parse.c (increase_expout_size): Now static.
7569
7570 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7571
7572         * gnu-nat.c (gnu_nat_target::wait): Fix
7573         target_waitstatus_to_string call.
7574
7575 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7576
7577         * eval.c (evaluate_subexp_standard): Handle internal functions
7578         during Fortran function call handling.
7579
7580 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         * NEWS: Mention new internal functions.
7583         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7584         (read_base_type): Use dwarf2_init_complex_target_type.
7585         * value.c (creal_internal_fn): New function.
7586         (cimag_internal_fn): New function.
7587         (_initialize_values): Register new internal functions.
7588
7589 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7590
7591         * infrun.c (stop_all_threads): If debug_infrun, always
7592         trace the wait status after wait_one, using
7593         target_waitstatus_to_string and target_pid_to_str.
7594         (handle_inferior_event): Replace various trace of
7595         wait status kind by a single trace.
7596         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7597         wait status kind image by target_waitstatus_to_string.
7598         * target/waitstatus.c (target_waitstatus_to_string): Fix
7599         obsolete comment.
7600
7601 2019-04-01  Tom Tromey  <tromey@adacore.com>
7602
7603         PR symtab/23331:
7604         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7605
7606 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7607             Pedro Alves  <palves@redhat.com>
7608
7609         * top.c (quit_force): Call 'finalize_values'.
7610         * value.c (finalize_values): New function.
7611         * value.h (finalize_values): Declare.
7612
7613 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7614
7615         * NEWS: Announce $_gdb_major and $_gdb_minor.
7616
7617         * top.c (init_gdb_version_vars): New function.
7618         (gdb_init): Call init_gdb_version_vars.
7619
7620 2019-03-29  Tom Tromey  <tromey@adacore.com>
7621
7622         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7623         help text.  Remove dead code.
7624
7625 2019-03-29  Keith Seitz  <keiths@redhat.com>
7626
7627         From Siddhesh Poyarekar:
7628         * f-lang.h (f77_get_upperbound): Return LONGEST.
7629         (f77_get_lowerbound): Likewise.
7630         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7631         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7632         print them.
7633         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7634         plongest to format print it.
7635         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7636         (f77_get_upperbound): Likewise.
7637         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7638         LOWER_BOUND to LONGEST.
7639         (f77_create_arrayprint_offset_tbl): Likewise.
7640
7641 2019-03-29  Keith Seitz  <keiths@redhat.com>
7642
7643         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7644         %s/pulongest for TYPE_LENGTH instead of %d in format
7645         strings.
7646         * ada-typerint.c (ada_print_type): Likewise.
7647         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7648         * compile/compile-c-support.c (generate_register_struct): Likewise.
7649         * gdbtypes.c (recursive_dump_type): Likewise.
7650         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7651         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7652         instead of %d in format strings.
7653         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7654         to std::min to ULONGEST.
7655         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7656         instead of %d in format strings.
7657         * tracepoint.c (info_scope_command): Likewise.
7658         * typeprint.c (print_offset_data::update)
7659         (print_offset_data::finish): Likewise.
7660         * xtensa-tdep.c (xtensa_store_return_value)
7661         (xtensa_push_dummy_call): Likewise.
7662
7663 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7664
7665         * windows-nat.c (display_selector): Fixed format specifications
7666         for 64-bit Cygwin.
7667
7668 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7669
7670         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7671
7672 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7673
7674         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7675         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7676         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7677         (nios2_linux_init_abi): Install it.
7678
7679 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7680
7681         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7682
7683 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7684
7685         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7686
7687 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7688             Tom Tromey  <tromey@adacore.com>
7689
7690         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7691
7692 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7693
7694         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7695         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7696         method to compute the bounds of range types. Also print "[evaluated]"
7697         if the bounds' values come from a dynamic evaluation.
7698
7699 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7700
7701         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7702         whitespace when pretty printing is on.
7703
7704 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7705
7706         * ppc-linux-nat.c: Add include.
7707
7708 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7709
7710         * NEWS: Mention AArch64 Pointer Authentication.
7711
7712 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7713
7714         * arm-linux-nat.c: Add include.
7715
7716 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7717
7718         * source-cache.c (source_cache::get_source_lines): Re-read
7719         fullname after calling open_source_file.
7720
7721 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7722
7723         * NEWS: Mention TLS support for FreeBSD.
7724
7725 2019-03-25  Tom Tromey  <tromey@adacore.com>
7726
7727         * minsyms.c (BUNCH_SIZE): Update comment.
7728         (~minimal_symbol_reader): Remove old comment.
7729         (compact_minimal_symbols): Update comment.
7730         (minimal_symbol_reader::install): Remove old comment.  Update
7731         other comments.
7732
7733 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7734
7735         * s390-linux-nat.c: Add include.
7736
7737 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7738
7739         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7740         Call linux_get_hwcap.
7741         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7742         Likewise.
7743         (aarch64_linux_get_hwcap): Remove function.
7744         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7745         declaration.
7746         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7747         linux_get_hwcap.
7748         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7749         * linux-tdep.c (linux_get_hwcap): Add function.
7750         (linux_get_hwcap2): Likewise.
7751         * linux-tdep.h (linux_get_hwcap): Add declaration.
7752         (linux_get_hwcap2): Likewise.
7753         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7754         (ppc_linux_get_hwcap2): Likewise.
7755         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7756         linux_get_hwcap.
7757         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7758         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7759         (ppc_linux_nat_target::read_description): Likewise.
7760         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7761         * s390-linux-nat.c: Likewise.
7762         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7763
7764 2019-03-24  Tom Tromey  <tom@tromey.com>
7765
7766         * ada-lang.c (standard_lookup): Simplify initialization.
7767         (ada_lookup_symbol_nonlocal): Simplify return.
7768         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7769         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7770         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7771         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7772         initialization.
7773         * solib.c (solib_global_lookup): Simplify.
7774         * symtab.c (null_block_symbol): Remove.
7775         (symbol_cache_lookup): Simplify returns.
7776         (lookup_language_this): Simplify returns.
7777         (lookup_symbol_aux): Simplify return.
7778         (lookup_local_symbol): Simplify returns.
7779         (lookup_global_symbol_from_objfile): Simplify return.
7780         (lookup_symbol_in_objfile_symtabs)
7781         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7782         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7783         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7784         * cp-namespace.c (cp_lookup_bare_symbol)
7785         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7786         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7787         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7788         (cp_lookup_symbol_via_imports): Simplify initialization.
7789         (find_symbol_in_baseclass): Likewise.
7790         * symtab.h (null_block_symbol): Remove.
7791         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7792         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7793         (d_lookup_symbol_module): Likewise.
7794         (find_symbol_in_baseclass): Simplify initialization.
7795
7796 2019-03-24  Tom Tromey  <tom@tromey.com>
7797
7798         * expression.h: Don't include symtab.h.
7799         (struct block): Forward declare.
7800
7801 2019-03-24  Tom Tromey  <tom@tromey.com>
7802
7803         * c-exp.y (typebase): Remove casts.
7804         * gdbtypes.c (lookup_unsigned_typename, )
7805         (lookup_signed_typename): Remove cast.
7806         * eval.c (parse_to_comma_and_eval): Remove cast.
7807         * parse.c (write_dollar_variable): Remove cast.
7808         * block.h (struct block) <superblock>: Now const.
7809         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7810         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7811         (map_block): Make "block" const.
7812         * symfile.h (struct quick_symbol_functions)
7813         <map_matching_symbols>: Constify block argument to "callback".
7814         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7815         const.
7816         (find_pc_sect_compunit_symtab): Make "b" const.
7817         (find_symbol_at_address): Likewise.
7818         (search_symbols): Likewise.
7819         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7820         (dw2_debug_names_lookup_symbol): Likewise.
7821         (dw2_map_matching_symbols): Update.
7822         * p-valprint.c (pascal_val_print): Remove "block".
7823         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7824         (aux_add_nonlocal_symbols): Make "block" const.
7825         (resolve_subexp): Remove cast.
7826         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7827         const.
7828         (iterate_over_file_blocks): Likewise.
7829         * f-exp.y (%union) <bval>: Remove.
7830         * coffread.c (patch_opaque_types): Make "b" const.
7831         * spu-tdep.c (spu_catch_start): Make "block" const.
7832         * c-valprint.c (print_unpacked_pointer): Remove "block".
7833         * symmisc.c (dump_symtab_1): Make "b" const.
7834         (block_depth): Make "block" const.
7835         * d-exp.y (%union) <bval>: Remove.
7836         * cp-support.h (cp_lookup_rtti_type): Update.
7837         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7838         * psymtab.c (psym_lookup_symbol): Make "block" const.
7839         (maintenance_check_psymtabs): Make "b" const.
7840         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7841         (enumerate_locals, enumerate_args): Update.
7842         * python/py-symtab.c (stpy_global_block): Make "block" const.
7843         (stpy_static_block): Likewise.
7844         * inline-frame.c (block_starting_point_at): Make "new_block"
7845         const.
7846         * block.c (find_block_in_blockvector): Make return type const.
7847         (blockvector_for_pc_sect): Make "b" const.
7848         (find_block_in_blockvector): Make "b" const.
7849
7850 2019-03-23  Tom Tromey  <tom@tromey.com>
7851
7852         * varobj.c (varobj_create): Update.
7853         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7854         * printcmd.c (display_command, do_one_display): Don't reset
7855         innermost_block.
7856         * parser-defs.h (enum innermost_block_tracker_type): Move to
7857         expression.h.
7858         (innermost_block): Update comment.
7859         * parse.c (parse_exp_1): Add tracker_types parameter.
7860         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7861         tracker_types parameter.  Reset innermost_block.
7862         (parse_exp_in_context): Remove.
7863         (parse_expression_for_completion): Update.
7864         * objfiles.c (~objfile): Don't reset expression_context_block or
7865         innermost_block.
7866         * expression.h (enum innermost_block_tracker_type): Move from
7867         parser-defs.h.
7868         (parse_exp_1): Add tracker_types parameter.
7869         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7870         reset innermost_block.
7871
7872 2019-03-23  Tom Tromey  <tom@tromey.com>
7873
7874         * objfiles.h: Include bcache.h.
7875
7876 2019-03-23  Tom Tromey  <tom@tromey.com>
7877
7878         * linespec.c (get_current_search_block): Use
7879         scoped_restore_current_language.
7880         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7881
7882 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7883             Jiong Wang  <jiong.wang@arm.com>
7884
7885         * aarch64-linux-tdep.c
7886         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7887         section.
7888         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7889
7890 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7891             Jiong Wang  <jiong.wang@arm.com>
7892
7893         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7894         instructions.
7895         (aarch64_analyze_prologue_test): Add PACIASP test.
7896         (aarch64_prologue_prev_register): Unmask PC value.
7897
7898 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7899             Jiong Wang  <jiong.wang@arm.com>
7900
7901         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7902         (aarch64_dwarf2_prev_register): Unmask PC value.
7903         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7904         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7905         DW_CFA_AARCH64_negate_ra_state.
7906         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7907
7908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7909             Jiong Wang  <jiong.wang@arm.com>
7910
7911         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7912         registers.
7913         (aarch64_pseudo_register_name): Likewise.
7914         (aarch64_pseudo_register_type): Likewise.
7915         (aarch64_pseudo_register_reggroup_p): Likewise.
7916         (aarch64_gdbarch_init): Add pauth registers.
7917         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7918         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7919         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7920         (struct gdbarch_tdep): Add regnum for ra_state.
7921
7922 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7923             Jiong Wang  <jiong.wang@arm.com>
7924
7925         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7926
7927 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7928             Jiong Wang  <jiong.wang@arm.com>
7929
7930         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7931         function.
7932         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7933         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7934         (aarch64_gdbarch_init): Add puth registers.
7935         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7936         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7937         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7938
7939 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7940             Jiong Wang  <jiong.wang@arm.com>
7941
7942         * aarch64-linux-nat.c
7943         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7944         * aarch64-linux-tdep.c
7945         (aarch64_linux_core_read_description): Likewise.
7946         (aarch64_linux_get_hwcap): New function.
7947         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7948         (aarch64_linux_get_hwcap): New declaration.
7949
7950 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7951             Jiong Wang  <jiong.wang@arm.com>
7952
7953         * aarch64-linux-nat.c
7954         (aarch64_linux_nat_target::read_description): Add pauth param.
7955         * aarch64-linux-tdep.c
7956         (aarch64_linux_core_read_description): Likewise.
7957         * aarch64-tdep.c (struct target_desc): Add in pauth.
7958         (aarch64_read_description): Add pauth param.
7959         (aarch64_gdbarch_init): Likewise.
7960         * aarch64-tdep.h (aarch64_read_description): Likewise.
7961         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7962         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7963         * features/Makefile: Add new files.
7964         * features/aarch64-pauth.c: New file.
7965         * features/aarch64-pauth.xml: New file.
7966
7967 2019-03-20  Tom Tromey  <tromey@adacore.com>
7968
7969         * infrun.c (handle_inferior_event): Rename from
7970         handle_inferior_event_1.  Create a scoped_value_mark.
7971         (handle_inferior_event): Remove.
7972
7973 2019-03-19  Tom Tromey  <tromey@adacore.com>
7974
7975         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7976         * infrun.h (print_stop_event): Add "displays" parameter.
7977         * infrun.c (print_stop_event): Add "displays" parameter.
7978
7979 2019-03-19  Pedro Alves  <palves@redhat.com>
7980
7981         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7982         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7983         to -1.  Fix TABs vs spaces.
7984         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7985         * tui/tui-out.h (tui_ui_out) Add intro comments.
7986         <m_line, m_start_of_line>: In-class initialize, and add describing
7987         comment.
7988
7989 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7990
7991         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7992         variable names.
7993         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7994
7995 2019-03-18  Pedro Alves  <palves@redhat.com>
7996             Eli Zaretskii <eliz@gnu.org>
7997
7998         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7999         m_line and m_start_of_line.
8000
8001 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8002
8003         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8004         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8005         it returns a newline.  This fixes a regression in TU mode, whereby
8006         the next line is output on the same screen line as the user input.
8007
8008 2019-03-18  Tom Tromey  <tromey@adacore.com>
8009
8010         * minsyms.c (minimal_symbol_reader::install): Remove call to
8011         obstack_blank.
8012
8013 2019-03-18  Pedro Alves  <palves@redhat.com>
8014
8015         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8016         New globals.
8017         (apply_style): New, factored out from ...
8018         (apply_ansi_escape): ... this.  Handle reverse video mode.
8019         (tui_set_reverse_mode): New function.
8020         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8021         * tui/tui-winsource.c (tui_show_source_line): Use
8022         tui_set_reverse_mode instead of setting A_STANDOUT.
8023         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8024         New setter methods.
8025
8026 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8027
8028         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8029         Handle tabs.
8030
8031 2019-03-18  Tom Tromey  <tromey@adacore.com>
8032
8033         * ada-lang.c (empty_array): Add "high" parameter.
8034         (ada_evaluate_subexp): Update.
8035
8036 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8037
8038         * unittests/string_view-selftests.c: Define
8039         _initialize_string_view_selftests unconditionally.
8040
8041 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8042
8043         PR gdb/24350
8044         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8045
8046 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8047
8048         PR gdb/24351
8049         * windows-nat.c (display_selector): Fix format specifiers.
8050
8051 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8052
8053         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8054         tui_refill_source_window instead of tui_refresh_win, to update the
8055         current execution line.  This fixes redisplay of the current line
8056         when stepping through the code with "next" or "step".
8057
8058 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8059
8060         * source-cache.c (source_cache::get_source_lines): Call
8061         find_source_lines to initialize s->nlines.  This fixes vertical
8062         scrolling of TUI source window when the DOWN arrow is pressed.
8063
8064 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8065
8066         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8067         linux-thread-db.c (_initialize_thread_db): Likewise.
8068
8069 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8070
8071         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8072         wclrtoeol in tui_show_source_line".  This reverts changes made in
8073         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8074
8075 2019-03-15  Tom Tromey  <tom@tromey.com>
8076
8077         * symtab.h (struct minimal_symbol): Derive from
8078         general_symbol_info.
8079         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8080         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8081         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8082         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8083         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8084         (MSYMBOL_SEARCH_NAME): Update.
8085         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8086         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8087         * minsyms.c (minimal_symbol_reader::record_full): Update.
8088
8089 2019-03-15  Tom Tromey  <tom@tromey.com>
8090
8091         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8092
8093 2019-03-15  Tom Tromey  <tom@tromey.com>
8094
8095         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8096         unique_xmalloc_ptr.
8097         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8098         Update.
8099         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8100         (build_minimal_symbol_hash_tables)
8101         (minimal_symbol_reader::install): Update.
8102
8103 2019-03-15  Tom Tromey  <tom@tromey.com>
8104
8105         * symtab.c (create_demangled_names_hash): Update.
8106         (symbol_set_names): Update.
8107         * objfiles.h (struct objfile_per_bfd_storage)
8108         <demangled_names_hash>: Now an htab_up.
8109         * objfiles.c (objfile_per_bfd_storage): Simplify.
8110
8111 2019-03-15  Tom Tromey  <tom@tromey.com>
8112
8113         * objfiles.h (struct objfile_per_bfd_storage): Declare
8114         destructor.
8115         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8116         New.
8117         (get_objfile_bfd_data): Use new.  Don't initialize
8118         language_of_main.
8119         (free_objfile_per_bfd_storage): Remove.
8120         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8121
8122 2019-03-15  Tom Tromey  <tom@tromey.com>
8123
8124         * symfile.c (reread_symbols): Update.
8125         * objfiles.c (objfile::objfile): Update.
8126         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8127         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8128         comment.
8129         (minimal_symbol_reader::install): Update.
8130         (terminate_minimal_symbol_table): Remove.
8131         * jit.c (jit_object_close_impl): Update.
8132
8133 2019-03-15  Tom Tromey  <tom@tromey.com>
8134
8135         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8136         initializations.
8137
8138 2019-03-15  Tom Tromey  <tom@tromey.com>
8139
8140         * objfiles.h (struct objfile_per_bfd_storage)
8141         <demangled_hash_languages>: Now a bitset.
8142         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8143         (lookup_minimal_symbol): Update.
8144
8145 2019-03-15  Tom Tromey  <tom@tromey.com>
8146
8147         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8148         Don't return the symbol.
8149         * coffread.c (record_minimal_symbol): Use record_full.
8150
8151 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8152
8153         The MS-Windows port of ncurses fails to switch to a color pair if
8154         one or both of the colors are the implicit default colors.  This
8155         change records the default colors when TUI is initialized, and
8156         then specifies them explicitly when a color pair uses the default
8157         colors.  This allows color styling in TUI mode on MS-Windows.
8158
8159         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8160         ncurses_norm_attr.
8161         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8162         colors in ncurses_norm_attr.
8163         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8164         "none", replace it with the default color recorded in
8165         ncurses_norm_attr.
8166
8167 2019-03-14  Tom Tromey  <tromey@adacore.com>
8168
8169         * source-cache.h (class source_cache) <get_source_lines>: Return
8170         std::string.
8171         * source-cache.c (source_cache::extract_lines): Handle case where
8172         first_pos==npos.  Return std::string.
8173         (source_cache::get_source_lines): Update.
8174
8175 2019-03-14  Tom Tromey  <tromey@adacore.com>
8176
8177         * NEWS: Add item for "style sources" commands.
8178         * source-cache.c (source_cache::get_source_lines): Check
8179         source_styling.
8180         * cli/cli-style.c (source_styling): New global.
8181         (_initialize_cli_style): Add "style sources" commands.
8182         (show_style_sources): New function.
8183         * cli/cli-style.h (source_styling): Declare.
8184
8185 2019-03-14  Pedro Alves  <palves@redhat.com>
8186             Tom Tromey  <tromey@adacore.com>
8187
8188         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8189         * tui/tui-winsource.c (tui_refill_source_window): New function,
8190         from...
8191         (tui_horizontal_source_scroll): ... here.  Move some logic.
8192         * cli/cli-style.c (set_style_enabled): Notify new observable.
8193         * tui/tui-hooks.c (tui_redisplay_source): New function.
8194         (tui_attach_detach_observers): Attach or detach
8195         tui_redisplay_source.
8196         * observable.h (source_styling_changed): New observable.
8197         * observable.c: Define source_styling_changed observable.
8198
8199 2019-03-13  Tom Tromey  <tromey@adacore.com>
8200
8201         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8202         (i386_gnu_nat_target::store_registers): Update.
8203         * target-debug.h (target_debug_print_std_string): New macro.
8204         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8205         * windows-tdep.c (display_one_tib): Update.
8206         * tui/tui-stack.c (tui_make_status_line): Update.
8207         * top.c (print_inferior_quit_action): Update.
8208         * thread.c (thr_try_catch_cmd): Update.
8209         (add_thread_with_info): Update.
8210         (thread_target_id_str): Update.
8211         (thr_try_catch_cmd): Update.
8212         (thread_command): Update.
8213         (thread_find_command): Update.
8214         * record-btrace.c (record_btrace_target::info_record)
8215         (record_btrace_resume_thread, record_btrace_target::resume)
8216         (record_btrace_cancel_resume, record_btrace_step_thread)
8217         (record_btrace_target::wait, record_btrace_target::wait)
8218         (record_btrace_target::wait, record_btrace_target::stop): Update.
8219         * progspace.c (print_program_space): Update.
8220         * process-stratum-target.c
8221         (process_stratum_target::thread_address_space): Update.
8222         * linux-fork.c (linux_fork_mourn_inferior)
8223         (detach_checkpoint_command, info_checkpoints_command)
8224         (linux_fork_context): Update.
8225         (linux_fork_detach): Update.
8226         (class scoped_switch_fork_info): Update.
8227         (delete_checkpoint_command): Update.
8228         * infrun.c (follow_fork_inferior): Update.
8229         (follow_fork_inferior): Update.
8230         (proceed_after_vfork_done): Update.
8231         (handle_vfork_child_exec_or_exit): Update.
8232         (follow_exec): Update.
8233         (displaced_step_prepare_throw): Update.
8234         (displaced_step_restore): Update.
8235         (start_step_over): Update.
8236         (resume_1): Update.
8237         (clear_proceed_status_thread): Update.
8238         (proceed): Update.
8239         (print_target_wait_results): Update.
8240         (do_target_wait): Update.
8241         (context_switch): Update.
8242         (stop_all_threads): Update.
8243         (restart_threads): Update.
8244         (finish_step_over): Update.
8245         (handle_signal_stop): Update.
8246         (switch_back_to_stepped_thread): Update.
8247         (keep_going_pass_signal): Update.
8248         (print_exited_reason): Update.
8249         (normal_stop): Update.
8250         * inferior.c (inferior_pid_to_str): Change return type.
8251         (print_selected_inferior): Update.
8252         (add_inferior): Update.
8253         (detach_inferior): Update.
8254         * dummy-frame.c (fprint_dummy_frames): Update.
8255         * dcache.c (dcache_info_1): Update.
8256         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8257         (btrace_fetch, btrace_clear): Update.
8258         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8259         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8260         type.
8261         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8262         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8263         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8264         * gdbarch.c, gdbarch.h: Rebuild.
8265         * gdbarch.sh (core_pid_to_str): Change return type.
8266         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8267         return type.
8268         (windows_nat_target::pid_to_str): Change return type.
8269         (windows_delete_thread): Update.
8270         (windows_nat_target::attach): Update.
8271         (windows_nat_target::files_info): Update.
8272         * target-delegates.c: Rebuild.
8273         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8274         return type.
8275         (sol_thread_target::pid_to_str): Change return type.
8276         * remote.c (class remote_target) <pid_to_str>: Change return
8277         type.
8278         (remote_target::pid_to_str): Change return type.
8279         (extended_remote_target::attach, remote_target::remote_stop_ns)
8280         (remote_target::remote_notif_remove_queued_reply)
8281         (remote_target::push_stop_reply, remote_target::disable_btrace):
8282         Update.
8283         (extended_remote_target::attach): Update.
8284         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8285         type.
8286         (gdbsim_target::pid_to_str): Change return type.
8287         * ravenscar-thread.c (struct ravenscar_thread_target)
8288         <pid_to_str>: Change return type.
8289         (ravenscar_thread_target::pid_to_str): Change return type.
8290         * procfs.c (class procfs_target) <pid_to_str>: Change return
8291         type.
8292         (procfs_target::pid_to_str): Change return type.
8293         (procfs_target::attach): Update.
8294         (procfs_target::detach): Update.
8295         (procfs_target::fetch_registers): Update.
8296         (procfs_target::store_registers): Update.
8297         (procfs_target::wait): Update.
8298         (procfs_target::files_info): Update.
8299         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8300         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8301         return type.
8302         (nto_procfs_target::pid_to_str): Change return type.
8303         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8304         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8305         return type.
8306         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8307         (exit_lwp): Update.
8308         (attach_proc_task_lwp_callback, get_detach_signal)
8309         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8310         (linux_nat_target::resume, wait_lwp, stop_callback)
8311         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8312         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8313         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8314         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8315         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8316         type.
8317         (inf_ptrace_target::attach): Update.
8318         (inf_ptrace_target::files_info): Update.
8319         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8320         type.
8321         (go32_nat_target::pid_to_str): Change return type.
8322         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8323         (gnu_nat_target::wait): Update.
8324         (gnu_nat_target::wait): Update.
8325         (gnu_nat_target::resume): Update.
8326         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8327         (fbsd_nat_target::wait): Update.
8328         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8329         type.
8330         (darwin_nat_target::attach): Update.
8331         * corelow.c (class core_target) <pid_to_str>: Change return type.
8332         (core_target::pid_to_str): Change return type.
8333         * target.c (normal_pid_to_str): Change return type.
8334         (default_pid_to_str): Likewise.
8335         (target_pid_to_str): Change return type.
8336         (target_translate_tls_address): Update.
8337         (target_announce_detach): Update.
8338         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8339         return type.
8340         (bsd_uthread_target::pid_to_str): Change return type.
8341         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8342         type.
8343         (bsd_kvm_target::pid_to_str): Change return type.
8344         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8345         return type.
8346         (aix_thread_target::pid_to_str): Change return type.
8347         * target.h (struct target_ops) <pid_to_str>: Change return type.
8348         (target_pid_to_str, normal_pid_to_str): Likewise.
8349         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8350         type.
8351         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8352         type.
8353         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8354         return type.
8355         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8356         type.
8357         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8358         type.
8359         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8360         return type.
8361
8362 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8363
8364         * NEWS: Mention that the new default MI version is 3.  Mention
8365         changes to the output of commands and events that deal with
8366         multi-location breakpoints.
8367         * breakpoint.c: Include "mi/mi-out.h".
8368         (print_one_breakpoint): Change output syntax if using MI version
8369         >= 3.
8370         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8371         New.
8372         (mi_multi_location_breakpoint_output_fixed): New.
8373         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8374         (mi_cmd_fix_multi_location_breakpoint_output): New.
8375         (mi_multi_location_breakpoint_output_fixed): New.
8376         * mi/mi-cmds.c (mi_cmds): Register command
8377         -fix-multi-location-breakpoint-output.
8378         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8379         interpreter "mi".
8380
8381 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8382
8383         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8384         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8385         instantiate mi_ui_out based on interpreter name.
8386         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8387         * mi/mi-main.c (mi_load_progress): Likewise.
8388
8389 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8390
8391         * NEWS: Combine separate "New targets" sections for 8.3.
8392
8393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8394
8395         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8396         (ppcfbsd_init_abi): Install gdbarch
8397         "fetch_tls_load_module_address" and "get_thread_local_address"
8398         methods.
8399
8400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8401
8402         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8403         (riscv_fbsd_init_abi): Install gdbarch
8404         "fetch_tls_load_module_address" and "get_thread_local_address"
8405         methods.
8406
8407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8408
8409         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8410         (i386fbsd_init_abi): Install gdbarch
8411         "fetch_tls_load_module_address" and "get_thread_local_address"
8412         methods.
8413
8414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8415
8416         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8417         (amd64fbsd_init_abi): Install gdbarch
8418         "fetch_tls_load_module_address" and "get_thread_local_address"
8419         methods.
8420
8421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8422
8423         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8424         (struct fbsd_pspace_data): New type.
8425         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8426         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8427         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8428         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8429         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8430
8431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8432
8433         * gdbtypes.c (lookup_struct_elt): New function.
8434         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8435         * gdbtypes.h (struct struct_elt): New type.
8436         (lookup_struct_elt): New prototype.
8437
8438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8439
8440         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8441         remove disabled code block.
8442
8443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8444
8445         * gdbarch.sh (get_thread_local_address): New method.
8446         * gdbarch.h, gdbarch.c: Regenerate.
8447         * target.c (target_translate_tls_address): Use
8448         gdbarch_get_thread_local_address if present instead of
8449         target::get_thread_local_address.
8450
8451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8452
8453         * target.h (target::get_thread_local_address): Update comment.
8454
8455 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8456
8457         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8458         objfile->separate_debug_objfile_backlink if not NULL.
8459
8460 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8461
8462         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8463         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8464         (amd64bsd_store_inferior_registers): Likewise.
8465         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8466         Enable segment base registers.
8467         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8468         PT_GETFSBASE and PT_GETGSBASE.
8469         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8470         PT_SETGSBASE.
8471         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8472         segment base registers.
8473         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8474
8475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8476
8477         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8478         Update calls to i386_target_description to add 'segments'
8479         parameter.
8480         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8481         add segment base registers.
8482         * arch/i386.c (i386_create_target_description): Add 'segments'
8483         parameter to enable segment base registers.
8484         * arch/i386.h (i386_create_target_description): Likewise.
8485         * features/i386/32bit-segments.xml: New file.
8486         * features/i386/32bit-segments.c: Generate.
8487         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8488         call to i386_target_description to add 'segments' parameter.
8489         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8490         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8491         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8492         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8493         if feature is present.
8494         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8495         Add 'segments' parameter to call to i386_target_description.
8496         (i386_target_description): Add 'segments' parameter to enable
8497         segment base registers.
8498         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8499         to call to i386_target_description.
8500         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8501         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8502         Define I386_NUM_REGS.
8503         (i386_target_description): Add 'segments' parameter to enable
8504         segment base registers.
8505
8506 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8507
8508         PR/24325
8509         * source-cache.c: #undef open and close, to avoid unresolved
8510         externals during linking.
8511
8512 2019-03-12  Tom Tromey  <tromey@adacore.com>
8513
8514         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8515         const.  Add initializers.
8516         (_initialize_remote): Don't initialize ptid globals.
8517
8518 2019-03-12  Pedro Alves  <palves@redhat.com>
8519
8520         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8521
8522 2019-03-12  Pedro Alves  <palves@redhat.com>
8523
8524         * cp-name-parser.y (main): Remove unused 'len' variable.
8525
8526 2019-03-12  Tom Tromey  <tromey@adacore.com>
8527
8528         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8529         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8530
8531 2019-03-12  Tom Tromey  <tromey@adacore.com>
8532
8533         * linux-nat.c (iterate_over_lwps): Update.
8534         (stop_callback): Remove parameter.
8535         (stop_wait_callback, detach_callback, resume_set_callback)
8536         (select_singlestep_lwp_callback, set_ignore_sigint)
8537         (status_callback, resumed_callback, resume_clear_callback)
8538         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8539         data parameter.
8540         (linux_nat_target::detach, linux_nat_target::resume)
8541         (linux_stop_and_wait_all_lwps, select_event_lwp)
8542         (linux_nat_filter_event, linux_nat_wait_1)
8543         (linux_nat_target::kill, linux_nat_target::stop)
8544         (linux_nat_target::stop): Update.
8545         (linux_nat_resume_callback): Change type.
8546         (resume_stopped_resumed_lwps, count_events_callback)
8547         (select_event_lwp_callback): Likewise.
8548         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8549         * arm-linux-nat.c (struct update_registers_data): Remove.
8550         (update_registers_callback): Change type.
8551         (arm_linux_insert_hw_breakpoint1): Update.
8552         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8553         parameter.
8554         (x86_linux_dr_set_addr): Update.
8555         (x86_linux_dr_set_control): Update.
8556         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8557         (iterate_over_lwps): Use gdb::function_view.
8558         * nat/aarch64-linux-hw-point.c (struct
8559         aarch64_dr_update_callback_param): Remove.
8560         (debug_reg_change_callback): Change type.
8561         (aarch64_notify_debug_reg_change): Update.
8562         * s390-linux-nat.c (s390_refresh_per_info): Update.
8563
8564 2019-03-11  Tom Tromey  <tromey@adacore.com>
8565
8566         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8567         redundant assignment to "this_cu".
8568
8569 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8570
8571         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8572
8573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8574
8575         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8576         from...
8577         (rank_one_type): ... this.
8578
8579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8580
8581         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8582         from...
8583         (rank_one_type): ... this.
8584
8585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8586
8587         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8588         from...
8589         (rank_one_type): ... this.
8590
8591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8592
8593         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8594         from...
8595         (rank_one_type): ... this.
8596
8597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8598
8599         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8600         from...
8601         (rank_one_type): ... this.
8602
8603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8604
8605         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8606         from...
8607         (rank_one_type): ... this.
8608
8609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8610
8611         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8612         from...
8613         (rank_one_type): ... this.
8614
8615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8616
8617         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8618         from...
8619         (rank_one_type): ... this.
8620
8621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8622
8623         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8624         from...
8625         (rank_one_type): ... this.
8626
8627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8628
8629         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8630         from...
8631         (rank_one_type): ... this.
8632
8633 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8634
8635         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8636         from...
8637         (rank_one_type): ... this.
8638
8639 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8640
8641         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8642         from...
8643         (rank_one_type): ... this.
8644
8645 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8646
8647         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8648         inferior-events' shows the example events.
8649
8650 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8651
8652         Support styling on native MS-Windows console
8653
8654         PR/24315
8655         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8656         on MS-Windows if $TERM is not defined.
8657
8658         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8659
8660         * posix-hdep.c (gdb_console_fputs):
8661         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8662         functions.
8663         * ui-file.h (gdb_console_fputs): Add prototype.
8664
8665         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8666         back to fputs only if the former returns zero.
8667
8668 2019-03-07  Tom Tromey  <tom@tromey.com>
8669
8670         * symmisc.c (print_symbol_bcache_statistics): Update.
8671         (print_objfile_statistics): Update.
8672         * symfile.c (allocate_symtab): Update.
8673         * stabsread.c: Don't include bcache.h.
8674         * psymtab.h (struct psymbol_bcache): Don't declare.
8675         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8676         (psymbol_bcache_init, psymbol_bcache_free)
8677         (psymbol_bcache_get_bcache): Don't declare.
8678         * psymtab.c (struct psymbol_bcache): Remove.
8679         (psymtab_storage::psymtab_storage): Update.
8680         (psymtab_storage::~psymtab_storage): Update.
8681         (psymbol_bcache_init, psymbol_bcache_free)
8682         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8683         (add_psymbol_to_bcache): Update.
8684         (allocate_psymtab): Update.
8685         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8686         macro_cache>: No longer pointers.
8687         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8688         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8689         * macrotab.c (macro_bcache): Update.
8690         * macroexp.c: Don't include bcache.h.
8691         * gdbtypes.c (check_types_worklist): Update.
8692         (types_deeply_equal): Remove TRY/CATCH.  Update.
8693         * elfread.c (elf_symtab_read): Update.
8694         * dwarf2read.c: Don't include bcache.h.
8695         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8696         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8697         (print_bcache_statistics, bcache_memory_used): Don't declare.
8698         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8699         methods.  Rename all data members.
8700         * bcache.c (struct bcache): Move to bcache.h.
8701         (bcache::expand_hash_table): Rename from expand_hash_table.
8702         (bcache): Remove.
8703         (bcache::insert): Rename from bcache_full.
8704         (bcache::compare): Rename from bcache_compare.
8705         (bcache_xmalloc): Remove.
8706         (bcache::~bcache): Rename from bcache_xfree.
8707         (bcache::print_statistics): Rename from print_bcache_statistics.
8708         (bcache::memory_used): Rename from bcache_memory_used.
8709
8710 2019-03-07  Pedro Alves  <palves@redhat.com>
8711
8712         * infrun.c (normal_stop): Also check for
8713         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8714
8715 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8716
8717         * f-lang.c (value_from_host_double): Moved to...
8718         * value.c (value_from_host_double): ...here.
8719         * value.h (value_from_host_double): Declare.
8720         * guile/scm-math.c (vlscm_convert_typed_number): Use
8721         value_from_host_double.
8722         (vlscm_convert_number): Likewise.
8723         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8724         * python/py-value.c (convert_value_from_python): Likewise.
8725
8726 2019-03-06  Tom Tromey  <tom@tromey.com>
8727
8728         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8729
8730 2019-03-06  Tom Tromey  <tom@tromey.com>
8731
8732         * utils.h (free_current_contents): Don't declare.
8733         * utils.c (free_current_contents): Remove.
8734
8735 2019-03-06  Tom Tromey  <tom@tromey.com>
8736
8737         * top.c (quit_force): Update.
8738         * main.c (captured_command_loop): Update.
8739         * common/new-op.c (operator new): Update.
8740         * common/common-exceptions.c (struct catcher)
8741         <save_cleanup_chain>: Remove member.
8742         (exceptions_state_mc_init): Update.
8743         (exception_try_scope_entry): Return nullptr.
8744         (exception_try_scope_exit, exception_rethrow)
8745         (throw_exception_sjlj, throw_exception_cxx): Update.
8746         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8747         (all_cleanups, do_cleanups, discard_cleanups)
8748         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8749         (restore_cleanups, restore_final_cleanups): Don't declare.
8750         (do_final_cleanups): Remove parameter.
8751         * common/cleanups.c (cleanup_chain, make_cleanup)
8752         (make_cleanup_dtor, all_cleanups, do_cleanups)
8753         (discard_my_cleanups, discard_cleanups)
8754         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8755         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8756         (null_cleanup): Remove.
8757         (do_final_cleanups): Remove parameter.
8758
8759 2019-03-06  Tom Tromey  <tom@tromey.com>
8760
8761         * remote.c (remote_target::remote_parse_stop_reply): Use
8762         unique_xmalloc_ptr.
8763
8764 2019-03-06  Tom Tromey  <tom@tromey.com>
8765
8766         * stabsread.c (struct stabs_field_info): Rename from field_info.
8767         <list, fnlist>: Add initializers.
8768         <obstack>: New member.
8769         (read_member_functions, read_struct_fields, read_baseclasses):
8770         Allocate on obstack.  Don't use cleanups.
8771         (read_one_struct_field, read_member_functions, read_struct_fields)
8772         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8773         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8774         (read_struct_type): Update.
8775
8776 2019-03-06  Tom Tromey  <tom@tromey.com>
8777
8778         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8779         * common/filestuff.h (make_cleanup_close): Don't declare.
8780         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8781         Remove.
8782
8783 2019-03-06  Tom Tromey  <tom@tromey.com>
8784
8785         * solib-aix.c: Use make_scope_exit.
8786
8787 2019-03-06  Tom Tromey  <tom@tromey.com>
8788
8789         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8790         Use make_scope_exit.
8791
8792 2019-03-06  Tom Tromey  <tom@tromey.com>
8793
8794         * solib-svr4.c (disable_probes_interface): Remove parameter.
8795         (svr4_handle_solib_event): Use make_scope_exit.
8796
8797 2019-03-06  Tom Tromey  <tom@tromey.com>
8798
8799         * remote.c (struct stop_reply_deleter): Remove.
8800         (stop_reply_up): Update.
8801         (struct stop_reply): Derive from notif_event.  Don't typedef.
8802         <regcache>: Now a std::vector.
8803         (stop_reply_xfree): Remove.
8804         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8805         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8806         (remote_target::discard_pending_stop_replies): Use delete.
8807         (remote_target::remote_parse_stop_reply): Update.
8808         (remote_target::process_stop_reply): Update.
8809         * remote-notif.h (struct notif_event): Add virtual destructor.
8810         Remove "dtr" member.
8811         (struct notif_client) <alloc_event>: Return a unique_ptr.
8812         (notif_event_xfree): Don't declare.
8813         (notif_event_up): New typedef.
8814         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8815         (notif_event_xfree, do_notif_event_xfree): Remove.
8816         (remote_notif_state_xfree): Update.
8817
8818 2019-03-06  Tom Tromey  <tom@tromey.com>
8819
8820         * infrun.c (displaced_step_clear_cleanup): Now a
8821         forward_scope_exit type.
8822         (displaced_step_prepare_throw): Update.
8823         (displaced_step_fixup): Update.
8824
8825 2019-03-06  Tom Tromey  <tom@tromey.com>
8826
8827         * inferior.h (class inferior): Update comment.
8828         * gdbthread.h (class thread_info): Update comment.
8829
8830 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8831             Tom Tromey  <tom@tromey.com>
8832
8833         * stabsread.h (struct stab_section_list): Remove.
8834         (coffstab_build_psymtabs): Update.
8835         * dbxread.c (symbuf_sections): Now a std::vector.
8836         (sect_idx): New global.
8837         (fill_symbuf): Update.
8838         (coffstab_build_psymtabs): Change type of stabsects parameter.
8839         Update.
8840         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8841         std::vector.
8842         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8843         (coff_locate_sections): Update.
8844         (coff_symfile_read): Remove cleanups.  Update.
8845         (init_stringtab): Add storage parameter.
8846         (free_stringtab, free_stringtab_cleanup): Remove.
8847         (init_lineno): Add storage parameter.
8848         (free_linetab, free_linetab_cleanup): Remove.
8849
8850 2019-03-06  Pedro Alves  <palves@redhat.com>
8851
8852         * linux-fork.c (fork_info::clobber_regs): Delete.
8853         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8854         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8855         comment.  Adjust.
8856         (scoped_switch_fork_info::scoped_switch_fork_info)
8857         (checkpoint_command, linux_fork_context): Adjust
8858         fork_save_infrun_state calls.
8859
8860 2019-03-06  Pedro Alves  <palves@redhat.com>
8861
8862         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8863         (inf_has_multiple_threads): Return 'bool' and rewrite using
8864         inferior_info::threads().
8865
8866 2019-03-06  Pedro Alves  <palves@redhat.com>
8867
8868         * linux-fork.c: Include <list>.
8869         (fork_list): Now a std::list instance.
8870         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8871         (forks_exist_p, find_last_fork): Adjust.
8872         (new_fork): Delete.
8873         (one_fork_p): New.
8874         (add_fork): Adjust.
8875         (free_fork): Delete, folded into fork_info::~fork_info().
8876         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8877         Adjust.
8878         (init_fork_list): Delete.
8879         (linux_fork_killall, linux_fork_mourn_inferior)
8880         (linux_fork_detach, info_checkpoints_command): Adjust.
8881         (_initialize_linux_fork): No longer call init_fork_list.
8882
8883 2019-03-06  Pedro Alves  <palves@redhat.com>
8884
8885         * linux-fork.c (new_fork): New, split out of ...
8886         (add_fork): ... this.  Return void.  Move "first fork" special
8887         case from here, to ...
8888         (checkpoint_command): ... here.
8889         * linux-linux.h (add_fork): Return void.
8890
8891 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8892
8893         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8894
8895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8896             Chris January  <chris.january@arm.com>
8897             David Lecomber  <david.lecomber@arm.com>
8898
8899         * f-exp.y: New token, UNOP_INTRINSIC.
8900         (exp): New pattern using UNOP_INTRINSIC token.
8901         (f77_keywords): Add 'abs' keyword.
8902         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8903         (value_from_host_double): New function.
8904         (evaluate_subexp_f): Support UNOP_ABS.
8905
8906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8909         types.
8910
8911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8912
8913         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8914         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8915         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8916
8917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8918
8919         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8920
8921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8922             Chris January  <chris.january@arm.com>
8923
8924         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8925         * f-exp.y: Define 'KIND' token.
8926         (exp): New pattern for KIND expressions.
8927         (ptype): Handle types with a kind extension.
8928         (direct_abs_decl): Extend to spot kind extensions.
8929         (f77_keywords): Add 'kind' to the list.
8930         (push_kind_type): New function.
8931         (convert_to_kind_type): New function.
8932         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8933         * parse.c (operator_length_standard): Likewise.
8934         * parser-defs.h (enum type_pieces): Add tp_kind.
8935         * std-operator.def: Add UNOP_KIND.
8936
8937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8938
8939         * f-exp.y (f_parse): Set yydebug.
8940
8941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8942
8943         * f-lang.c (evaluate_subexp_f): New function.
8944         (exp_descriptor_f): New global.
8945         (f_language_defn): Use exp_descriptor_f instead of
8946         exp_descriptor_standard.
8947
8948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * f-exp.y (struct token): Add comments.
8951         (dot_ops): Remove uppercase versions and the end marker.
8952         (f77_keywords): Likewise.
8953         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8954         entries in the dot_ops array are case insensitive, and use
8955         strncasecmp to compare strings.  Also some whitespace cleanup in
8956         this area.  Similar for the f77_keywords array, except entries in
8957         this list might be case sensitive.
8958
8959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8960
8961         * f-exp.y (struct f77_boolean_val): Add comments.
8962         (boolean_values): Remove uppercase versions, and end marker.
8963         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8964         and use strncasecmp to achieve case insensitivity.  Additionally,
8965         perform whitespace cleanup around this code.
8966
8967 2019-03-06  Tom Tromey  <tromey@adacore.com>
8968
8969         * remote-sim.c (gdbsim_target_open): Use result of
8970         gdb_argv::release.
8971
8972 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8973         Dirk Schubert  <dirk.schubert@arm.com>
8974         Chris January  <chris.january@arm.com>
8975
8976         * eval.c (evaluate_subexp_standard): Call Fortran argument
8977         wrapping logic.
8978         * f-lang.c (struct value): A value which can be passed into a
8979         Fortran function call.
8980         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8981         where appropriate.
8982         (struct type): Value ready for a Fortran function call.
8983         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8984         is needed.
8985         * f-lang.h (fortran_argument_convert): Declaration.
8986         (fortran_preserve_arg_pointer): Declaration.
8987         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8988
8989 2019-03-05  Tom Tromey  <tromey@adacore.com>
8990
8991         * python/py-prettyprint.c (print_string_repr): Remove #if.
8992         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8993
8994 2019-03-05  Tom Tromey  <tromey@adacore.com>
8995
8996         * target.c (the_dummy_target): Move later.  Change type to
8997         "dummy_target".
8998         (initialize_targets): Don't initialize the_dummy_target.
8999
9000 2019-03-05  Tom Tromey  <tromey@adacore.com>
9001
9002         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9003         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9004
9005 2019-03-05  Tom Tromey  <tromey@adacore.com>
9006
9007         * windows-nat.c (windows_nat_target::attach)
9008         (windows_nat_target::detach): Don't call gdb_flush.
9009         * valprint.c (generic_val_print, val_print, val_print_string):
9010         Don't call gdb_flush.
9011         * utils.c (defaulted_query): Don't call gdb_flush.
9012         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9013         * target.c (target_announce_detach): Don't call gdb_flush.
9014         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9015         * remote.c (extended_remote_target::attach): Don't call
9016         gdb_flush.
9017         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9018         * printcmd.c (do_examine): Don't call gdb_flush.
9019         (info_display_command): Don't call gdb_flush.
9020         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9021         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9022         * memattr.c (info_mem_command): Don't call gdb_flush.
9023         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9024         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9025         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9026         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9027         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9028         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9029         (gnu_nat_target::detach): Don't call gdb_flush.
9030         * f-valprint.c (f_val_print): Don't call gdb_flush.
9031         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9032         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9033         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9034         gdb_flush.
9035         * c-valprint.c (c_val_print): Don't call gdb_flush.
9036         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9037
9038 2019-03-05  Tom Tromey  <tromey@adacore.com>
9039
9040         * varobj.c (update_dynamic_varobj_children): Update.
9041         (install_default_visualizer): Use reset, not release.
9042         * value.c (set_internalvar): Update.
9043         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9044         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9045         ATTRIBUTE_UNUSED_RESULT.
9046
9047 2019-03-05  Tom Tromey  <tromey@adacore.com>
9048
9049         * remote.c (class scoped_remote_fd) <release>: Add
9050         ATTRIBUTE_UNUSED_RESULT.
9051
9052 2019-03-05  Tom Tromey  <tromey@adacore.com>
9053
9054         * macroexp.c (struct macro_buffer) <release>: Add
9055         ATTRIBUTE_UNUSED_RESULT.
9056
9057 2019-03-05  Tom Tromey  <tromey@adacore.com>
9058
9059         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9060         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9061         ATTRIBUTE_UNUSED_RESULT.
9062
9063 2019-03-05  Tom Tromey  <tromey@adacore.com>
9064
9065         * common/scoped_fd.h (class scoped_fd) <release>: Add
9066         ATTRIBUTE_UNUSED_RESULT.
9067
9068 2019-03-05  Tom Tromey  <tromey@adacore.com>
9069
9070         * parser-defs.h (struct parser_state) <release>: Add
9071         ATTRIBUTE_UNUSED_RESULT.
9072
9073 2019-03-05  Tom Tromey  <tromey@adacore.com>
9074
9075         * utils.h (class gdb_argv) <release>: Add
9076         ATTRIBUTE_UNUSED_RESULT.
9077         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9078
9079 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9080
9081         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9082         for-loop range, to avoid compiler warnings.
9083
9084         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9085         avoid compiler warnings about unused variables.
9086
9087         * NEWS: Mention end of support for native debugging on MS-Windows
9088         before XP.
9089
9090         PR gdb/24292
9091         * common/netstuff.c:
9092         * gdbserver/gdbreplay.c
9093         * gdbserver/remote-utils.c:
9094         * ser-tcp.c:
9095         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9096         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9097         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9098         'getaddrinfo' and 'freeaddrinfo' were not available before
9099         Windows XP, and mingw.org's MinGW headers by default define
9100         _WIN32_WINNT to 0x500.
9101
9102 2019-03-01  Gary Benson <gbenson@redhat.com>
9103
9104         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9105
9106 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9107             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9108
9109         PR gdb/8527
9110         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9111         set_sigint_trap, clear_sigint_trap.
9112
9113 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9114
9115         * target.c (target_detach): Clear the regcache and the
9116         frame cache.
9117
9118 2019-02-27  Pedro Alves  <palves@redhat.com>
9119
9120         * utils.c (set_screen_size): When we cap the height/width sizes,
9121         tweak the corresponding command variable to show "unlimited":
9122
9123 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9124             Pedro Alves  <palves@redhat.com>
9125
9126         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9127         before calling rl_set_screen_size.
9128
9129 2019-02-27  Tom Tromey  <tromey@adacore.com>
9130
9131         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9132         define.
9133         * python/py-value.c: Remove Python 2.4 workaround.
9134         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9135         workaround.
9136         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9137         Python 2.4 workaround.
9138         * python/python-internal.h: Remove Python 2.4 comment.
9139         (Py_ssize_t): Don't define.
9140         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9141         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9142         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9143         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9144         * python/python.c (do_start_initialization): Remove Python 2.4
9145         workaround.
9146         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9147         (print_children): Remove Python 2.4 workaround.
9148         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9149         workaround.
9150         (CHARBUFFERPROC_NAME): Remove.
9151         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9152         Python 2.4 workaround.
9153
9154 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9155
9156         * NEWS: Note minimum Python version.
9157
9158 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9159
9160         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9161         code from these functions.  Remove corresponding ifdefs.  Use
9162         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9163         Remove gotos and target of gotos.
9164         (infpy_search_memory): Likewise.
9165
9166 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9167
9168         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9169         (hppa_gdbarch_init): Don't register deleted functions with
9170         gdbarch.
9171
9172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9173
9174         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9175         (h8300_unwind_sp): Delete.
9176         (h8300_dummy_id): Delete.
9177         (h8300_gdbarch_init): Don't register deleted functions with
9178         gdbarch.
9179
9180 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9181
9182         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9183         (ft32_unwind_pc): Delete.
9184         (ft32_unwind_sp): Delete.
9185         (ft32_gdbarch_init): Don't register deleted functions with
9186         gdbarch.
9187
9188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9189
9190         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9191         (frv_unwind_pc): Delete.
9192         (frv_unwind_sp): Delete.
9193         (frv_gdbarch_init): Don't register deleted functions with
9194         gdbarch.
9195
9196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9197
9198         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9199         (riscv_unwind_pc): Delete.
9200         (riscv_unwind_sp): Delete.
9201         (riscv_gdbarch_init): Don't register deleted functions with
9202         gdbarch.
9203
9204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9207         (csky_unwind_pc): Delete.
9208         (csky_unwind_sp): Delete.
9209         (csky_gdbarch_init): Don't register deleted functions with
9210         gdbarch.
9211
9212 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9213
9214         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9215         (cris_unwind_pc): Delete.
9216         (cris_unwind_sp): Delete.
9217         (cris_gdbarch_init): Don't register deleted functions with
9218         gdbarch.
9219
9220 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9221
9222         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9223         (bfin_unwind_pc): Delete.
9224         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9225
9226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9229         (arm_unwind_pc): Delete.
9230         (arm_unwind_sp): Delete.
9231         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9232
9233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9234
9235         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9236         (arc_unwind_pc): Delete.
9237         (arc_unwind_sp): Delete.
9238         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9239
9240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9241
9242         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9243         (alpha_unwind_pc): Delete.
9244         (alpha_gdbarch_init): Don't register deleted functions with
9245         gdbarch.
9246
9247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9248
9249         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9250         (aarch64_unwind_pc): Delete.
9251         (aarch64_unwind_sp): Delete.
9252         (aarch64_gdbarch_init): Don't register deleted functions with
9253         gdbarch.
9254
9255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * gdbtypes.c (type_align): Don't consider static members when
9258         computing structure alignment.
9259
9260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9261
9262         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9263         return 0 for other types.
9264         * arch-utils.c (default_type_align): Always return 0.
9265         * gdbarch.h: Regenerate.
9266         * gdbarch.sh (type_align): Extend comment.
9267         * gdbtypes.c (type_align): Add additional comments, always call
9268         gdbarch_type_align before applying the default rules.
9269         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9270         generic code will then apply a suitable default.
9271         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9272         types, return 0 for other types.
9273
9274 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9275
9276         * NEWS: Create a new section for the next release branch.
9277         Rename the section of the current branch, now that it has
9278         been cut.
9279
9280 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9281
9282         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9283         * version.in: Bump version to 8.3.50.DATE-git.
9284
9285 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9286
9287         * aix-thread.c (ptid_cmp): Remove unused variable.
9288         (get_signaled_thread): Likewise.
9289         (store_regs_user_thread): Likewise.
9290         (store_regs_kernel_thread): Likewise.
9291         (fetch_regs_kernel_thread): Remove shadowed variable.
9292
9293 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9294
9295         * features/riscv/32bit-cpu.xml: Add register numbers.
9296         * features/riscv/32bit-fpu.c: Regenerate.
9297         * features/riscv/32bit-fpu.xml: Add register numbers.
9298         * features/riscv/64bit-cpu.xml: Add register numbers.
9299         * features/riscv/64bit-fpu.c: Regenerate.
9300         * features/riscv/64bit-fpu.xml: Add register numbers.
9301
9302 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9303
9304         * NEWS: Mention two argument form of gdb.Value constructor.
9305         * python/py-value.c (convert_buffer_and_type_to_value): New
9306         function.
9307         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9308         Add support for handling an optional second argument.  Call
9309         convert_buffer_and_type_to_value as appropriate.
9310         * python/python-internal.h (Py_buffer_deleter): New struct.
9311         (Py_buffer_up): New typedef.
9312
9313 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9314
9315         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9316         instead of releasing ownership.
9317
9318 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9319
9320         * dwarf2read.c (open_and_init_dwp_file): Call
9321         elf_numsections instead of bfd_count_sections to initialize
9322         dwp_file->num_sections.
9323
9324 2019-02-25  Tom Tromey  <tromey@adacore.com>
9325
9326         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9327
9328 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9329
9330         * gcore.in: Add '--readnever' option when invoking GDB.
9331
9332 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9333
9334         * MAINTAINERS: Update my email address.
9335
9336 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9337
9338         * build-id.c (build_id_to_debug_bfd_1): New function.
9339         (build_id_to_debug_bfd): Look for separate debug file in
9340         sysroot.
9341
9342 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9343
9344         * gdbarch.sh: Update the copyright year range that is placed into
9345         generated files.
9346
9347 2019-02-22  Keith Seitz  <keiths@redhat.com>
9348
9349         PR symtab/23853
9350         * linespec.c (create_sals_line_offset): Search for the default
9351         symtab's filename instead of its fullname.
9352
9353 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9354
9355         * NEWS: Update style defaults.
9356
9357 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9358
9359         * main.c (captured_main_1): Disable styling in batch mode.
9360
9361 2019-02-20  Tom Tromey  <tom@tromey.com>
9362
9363         * symtab.c (symtab_symbol_info): Fix typos.
9364
9365 2019-02-20  Tom Tromey  <tromey@adacore.com>
9366
9367         * findcmd.c (_initialize_mem_search): Use upper case for
9368         metasyntactic variables.
9369
9370 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9371
9372         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9373         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9374
9375 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9376
9377         * top.h (source_file_name): Change to std::string.
9378         * top.c (source_file_name): Likewise.
9379         (command_line_input): Adjust.
9380         * cli/cli-script.c (script_from_file): Adjust.
9381
9382 2019-02-19  Tom Tromey  <tromey@adacore.com>
9383
9384         * ravenscar-thread.c
9385         (ravenscar_thread_target::update_thread_list): Don't call
9386         ada_build_task_list.
9387         * ada-lang.h (ada_build_task_list): Don't declare.
9388         * ada-tasks.c (struct ada_tasks_inferior_data)
9389         <task_list_valid_p>: Now bool.
9390         (read_known_tasks, ada_task_list_changed)
9391         (ada_tasks_invalidate_inferior_data): Update.
9392         (read_known_tasks_array): Return bool.
9393         (read_known_tasks_list): Likewise.
9394         (read_known_tasks): Return void.
9395         (ada_build_task_list): Now static.
9396
9397 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9398
9399         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9400         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9401
9402 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9403
9404         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9405         variant for ada_tasks_pspace_data_handle and
9406         ada_tasks_inferior_data_handle.
9407         (ada_tasks_pspace_data_cleanup): New function.
9408         (ada_tasks_inferior_data_cleanup): New function.
9409
9410 2019-02-17  Tom Tromey  <tom@tromey.com>
9411
9412         * macrotab.h (macro_source_fullname): Return a std::string.
9413         * macrotab.c (macro_include, check_for_redefinition)
9414         (macro_undef, macro_lookup_definition, foreach_macro)
9415         (foreach_macro_in_scope): Update.
9416         (macro_source_fullname): Return a std::string.
9417         * macrocmd.c (show_pp_source_pos): Update.
9418
9419 2019-02-17  Tom Tromey  <tom@tromey.com>
9420
9421         * macrocmd.c (show_pp_source_pos): Style the file names.
9422
9423 2019-02-17  Tom Tromey  <tom@tromey.com>
9424
9425         PR tui/24197:
9426         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9427
9428 2019-02-17  Tom Tromey  <tom@tromey.com>
9429
9430         * ada-lang.c (user_select_syms): Use filtered printing.
9431         * utils.c (wrap_style): New global.
9432         (desired_style): Remove.
9433         (emit_style_escape): Add stream parameter.
9434         (set_output_style, reset_terminal_style, prompt_for_continue):
9435         Update.
9436         (flush_wrap_buffer): Only flush gdb_stdout.
9437         (wrap_here): Set wrap_style.
9438         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9439         treat escape sequences as a character.  Change when wrap buffer is
9440         flushed.
9441         (fputs_styled): Do not set the output style when the default is
9442         requested.
9443         * ui-style.h (struct ui_file_style) <is_default>: New method.
9444         * source.c (print_source_lines_base): Emit escape sequences in one
9445         piece.
9446
9447 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9448
9449         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9450         integers and enumeration types.
9451
9452 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9453
9454         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9455         instead of lookup_symbol_in_language
9456         (do_exact_match): New function.
9457         (ada_get_symbol_name_matcher): Return do_exact_match when
9458         doing a verbatim match.
9459
9460 2019-02-15  Tom Tromey  <tromey@adacore.com>
9461
9462         * ravenscar-thread.c (ravenscar_thread_target::resume)
9463         (ravenscar_thread_target::wait): Special case wildcard requests.
9464
9465 2019-02-15  Tom Tromey  <tromey@adacore.com>
9466
9467         * ravenscar-thread.c (base_ptid): Remove.
9468         (struct ravenscar_thread_target) <close>: New method.
9469         <m_base_ptid>: New member.
9470         <update_inferior_ptid, active_task, task_is_currently_active,
9471         runtime_initialized>: Declare methods.
9472         <ravenscar_thread_target>: Add constructor.
9473         (ravenscar_thread_target::task_is_currently_active)
9474         (ravenscar_thread_target::update_inferior_ptid)
9475         (ravenscar_runtime_initialized): Rename.  Now methods.
9476         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9477         (ravenscar_thread_target::update_thread_list): Update.
9478         (ravenscar_thread_target::active_task): Now method.
9479         (ravenscar_thread_target::store_registers)
9480         (ravenscar_thread_target::prepare_to_store)
9481         (ravenscar_thread_target::prepare_to_store)
9482         (ravenscar_thread_target::mourn_inferior): Update.
9483         (ravenscar_inferior_created): Use "new" to create target.
9484         (ravenscar_thread_target::get_ada_task_ptid): Update.
9485         (_initialize_ravenscar): Don't initialize base_ptid.
9486         (ravenscar_ops): Remove global.
9487
9488 2019-02-15  Tom Tromey  <tromey@adacore.com>
9489
9490         * target.h (push_target): Declare new overload.
9491         * target.c (push_target): New overload, taking an rvalue reference.
9492         * remote.c (remote_target::open_1): Use push_target overload.
9493         * corelow.c (core_target_open): Use push_target overload.
9494
9495 2019-02-15  Tom Tromey  <tromey@adacore.com>
9496
9497         * ravenscar-thread.c (is_ravenscar_task)
9498         (ravenscar_task_is_currently_active): Return bool.
9499         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9500         (_initialize_ravenscar): Remove "(void)".
9501         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9502         Return bool.
9503
9504 2019-02-15  Tom Tromey  <tromey@adacore.com>
9505
9506         * ravenscar-thread.c (ravenscar_runtime_initializer)
9507         (has_ravenscar_runtime, get_running_thread_id)
9508         (ravenscar_thread_target::resume): Fix indentation.
9509
9510 2019-02-15  Tom Tromey  <tromey@adacore.com>
9511
9512         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9513         from ravenscar_arch_ops.
9514         (sparc_ravenscar_ops::fetch_registers)
9515         (sparc_ravenscar_ops::store_registers): Now methods.
9516         (sparc_ravenscar_prepare_to_store): Remove.
9517         (sparc_ravenscar_ops): Redefine.
9518         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9519         methods and destructor.  Remove members.
9520         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9521         (ravenscar_thread_target::store_registers)
9522         (ravenscar_thread_target::prepare_to_store): Update.
9523         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9524         Remove.
9525         (struct ppc_ravenscar_powerpc_ops): Derive from
9526         ravenscar_arch_ops.
9527         (ppc_ravenscar_powerpc_ops::fetch_registers)
9528         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9529         (ppc_ravenscar_powerpc_ops): Redefine.
9530         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9531         (ppc_ravenscar_e500_ops::fetch_registers)
9532         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9533         (ppc_ravenscar_e500_ops): Redefine.
9534         * aarch64-ravenscar-thread.c
9535         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9536         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9537         (aarch64_ravenscar_fetch_registers)
9538         (aarch64_ravenscar_store_registers): Now methods.
9539         (aarch64_ravenscar_ops): Redefine.
9540
9541 2019-02-15  Tom Tromey  <tromey@adacore.com>
9542
9543         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9544         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9545         (ravenscar_thread_target::stopped_by_watchpoint)
9546         (ravenscar_thread_target::stopped_data_address)
9547         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9548
9549 2019-02-15  Tom Tromey  <tromey@adacore.com>
9550
9551         * ravenscar-thread.c: Fix some typos.
9552
9553 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9554             Tom Tromey  <tromey@adacore.com>
9555
9556         * ada-lang.c (ada_exception_sal): Change addr_string to a
9557         std::string.
9558         (create_ada_exception_catchpoint): Update.
9559
9560 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9561             Tom Tromey  <tromey@adacore.com>
9562
9563         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9564         (bp_location_ops): Remove.
9565         (base_breakpoint_allocate_location): Update.
9566         (free_bp_location): Update.
9567         * ada-lang.c (class ada_catchpoint_location)
9568         <ada_catchpoint_location>: Remove ops parameter.
9569         (ada_catchpoint_location_dtor): Remove.
9570         (ada_catchpoint_location_ops): Remove.
9571         (allocate_location_exception): Update.
9572         * breakpoint.h (struct bp_location_ops): Remove.
9573         (class bp_location) <bp_location>: Remove bp_location_ops
9574         parameter.
9575         <~bp_location>: Add destructor.
9576         <ops>: Remove.
9577
9578 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9579             Pedro Alves  <palves@redhat.com>
9580
9581         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9582         'PATH_MAX'.
9583
9584 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9585             Samuel Thibault  <samuel.thibault@gnu.org>
9586             Thomas Schwinge  <thomas@codesourcery.com>
9587
9588         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9589         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9590
9591 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9592
9593         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9594         (check_empty): Use "const char *".
9595
9596         * gnu-nat.c (gnu_nat_target::detach): Instead of
9597         'detach_inferior (pid)' call
9598         'detach_inferior (find_inferior_pid (pid))'.
9599
9600         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9601         'nat/fork-inferior.o'.
9602         * gnu-nat.c: #include "nat/fork-inferior.h".
9603
9604         * gnu-nat.c (gnu_nat_target::detach): Instead of
9605         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9606         * gnu-nat.h: #include "inf-child.h".
9607         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9608         'i386_gnu_nat_target::fetch_registers'.
9609         (gnu_store_registers): Rename/move to
9610         'i386_gnu_nat_target::store_registers'.
9611
9612         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9613         * gnu-nat.h (mach_thread_info): New function.
9614         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9615
9616         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9617
9618 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9619
9620         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9621
9622 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9623
9624         * windows-nat.c (windows_add_thread): Add new parameter
9625         "main_thread_p" with default value set to false.  Update
9626         function documentation as well as all callers.
9627         (windows_delete_thread): Likewise.
9628         (fake_create_process): Update call to windows_add_thread.
9629         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9630         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9631         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9632         call to windows_delete_thread.
9633
9634 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9635
9636         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9637
9638 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9639
9640         * symfile.c (find_separate_debug_file): Use canonical path of
9641         sysroot with child_path instead of gdb_sysroot if it is valid.
9642
9643 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9644
9645         * symfile.c (find_separate_debug_file): Use child_path to
9646         determine if an object file is under a sysroot.
9647
9648 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9649
9650         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9651         unittests/child-path-selftests.c.
9652         * common/pathstuff.c (child_path): New function.
9653         * common/pathstuff.h (child_path): New prototype.
9654         * unittests/child-path-selftests.c: New file.
9655
9656 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9657
9658         * symfile.c (find_separate_debug_file): Look for separate debug
9659         files in debug directories under the sysroot.
9660
9661 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9662
9663         * symtab.h (struct minimal_symbol data_p): New const method.
9664         (struct minimal_symbol text_p): Likewise.
9665         * symtab.c (output_source_filename): Use file name style
9666         to print file name.
9667         (print_symbol_info): Likewise.
9668         (print_msymbol_info): Use address style to print addresses.
9669         Use function name style to print executable text symbols.
9670         (expand_symtab_containing_pc): Use data_p.
9671         (find_pc_sect_compunit_symtab): Likewise.
9672
9673 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9674
9675         * breakpoint.c (describe_other_breakpoints): Use address style
9676         to print addresses.
9677         (say_where): Likewise.
9678
9679 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9680
9681         * ada-typeprint.c (print_func_type): Print function name
9682         style to print function name.
9683         * c-typeprint.c (c_print_type_1): Likewise.
9684
9685 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9686
9687         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9688         for execve.
9689
9690 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9691
9692         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9693         type_stack.
9694
9695 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9696
9697         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9698         TYPE_CODE_REF types.
9699
9700 2019-02-08  Jim Wilson  <jimw@sifive.com>
9701
9702         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9703         (riscv_linux_fregset): New.
9704         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9705
9706 2019-02-07  Tom Tromey  <tom@tromey.com>
9707
9708         * thread.c (thread_cancel_execution_command): Update.
9709         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9710         methods.
9711         (struct thread_fsm_ops): Remove.
9712         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9713         (thread_fsm_should_stop, thread_fsm_return_value)
9714         (thread_fsm_set_finished, thread_fsm_finished_p)
9715         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9716         Don't declare.
9717         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9718         * infrun.c (clear_proceed_status_thread)
9719         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9720         (print_stop_event): Update.
9721         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9722         Add constructor.
9723         (step_command_fsm_ops): Remove.
9724         (new_step_command_fsm): Remove.
9725         (step_1): Update.
9726         (step_command_fsm::should_stop): Rename from
9727         step_command_fsm_should_stop.
9728         (step_command_fsm::clean_up): Rename from
9729         step_command_fsm_clean_up.
9730         (step_command_fsm::do_async_reply_reason): Rename from
9731         step_command_fsm_async_reply_reason.
9732         (struct until_next_fsm): Inherit from thread_fsm.  Add
9733         constructor.
9734         (until_next_fsm_ops): Remove.
9735         (new_until_next_fsm): Remove.
9736         (until_next_fsm::should_stop): Rename from
9737         until_next_fsm_should_stop.
9738         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9739         (until_next_fsm::do_async_reply_reason): Rename from
9740         until_next_fsm_async_reply_reason.
9741         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9742         constructor.  Change type of breakpoint.
9743         (finish_command_fsm_ops): Remove.
9744         (new_finish_command_fsm): Remove.
9745         (finish_command_fsm::should_stop): Rename from
9746         finish_command_fsm_should_stop.
9747         (finish_command_fsm::clean_up): Rename from
9748         finish_command_fsm_clean_up.
9749         (finish_command_fsm::return_value): Rename from
9750         finish_command_fsm_return_value.
9751         (finish_command_fsm::do_async_reply_reason): Rename from
9752         finish_command_fsm_async_reply_reason.
9753         (finish_command): Update.
9754         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9755         Add constructor.
9756         (call_thread_fsm_ops): Remove.
9757         (call_thread_fsm::call_thread_fsm): Rename from
9758         new_call_thread_fsm.
9759         (call_thread_fsm::should_stop): Rename from
9760         call_thread_fsm_should_stop.
9761         (call_thread_fsm::should_notify_stop): Rename from
9762         call_thread_fsm_should_notify_stop.
9763         (run_inferior_call, call_function_by_hand_dummy): Update.
9764         * cli/cli-interp.c (should_print_stop_to_console): Update.
9765         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9766         Add constructor.  Change type of location_breakpoint,
9767         caller_breakpoint.
9768         (until_break_fsm_ops): Remove.
9769         (new_until_break_fsm): Remove.
9770         (until_break_fsm::should_stop): Rename from
9771         until_break_fsm_should_stop.
9772         (until_break_fsm::clean_up): Rename from
9773         until_break_fsm_clean_up.
9774         (until_break_fsm::do_async_reply_reason): Rename from
9775         until_break_fsm_async_reply_reason.
9776         (until_break_command): Update.
9777         * thread-fsm.c: Remove.
9778         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9779
9780 2019-02-07  Tom Tromey  <tom@tromey.com>
9781
9782         * yy-remap.h: Add include guard.
9783         * xtensa-tdep.h: Add include guard.
9784         * xcoffread.h: Rename include guard.
9785         * varobj-iter.h: Add include guard.
9786         * tui/tui.h: Rename include guard.
9787         * tui/tui-winsource.h: Rename include guard.
9788         * tui/tui-wingeneral.h: Rename include guard.
9789         * tui/tui-windata.h: Rename include guard.
9790         * tui/tui-win.h: Rename include guard.
9791         * tui/tui-stack.h: Rename include guard.
9792         * tui/tui-source.h: Rename include guard.
9793         * tui/tui-regs.h: Rename include guard.
9794         * tui/tui-out.h: Rename include guard.
9795         * tui/tui-layout.h: Rename include guard.
9796         * tui/tui-io.h: Rename include guard.
9797         * tui/tui-hooks.h: Rename include guard.
9798         * tui/tui-file.h: Rename include guard.
9799         * tui/tui-disasm.h: Rename include guard.
9800         * tui/tui-data.h: Rename include guard.
9801         * tui/tui-command.h: Rename include guard.
9802         * tic6x-tdep.h: Add include guard.
9803         * target/waitstatus.h: Rename include guard.
9804         * target/wait.h: Rename include guard.
9805         * target/target.h: Rename include guard.
9806         * target/resume.h: Rename include guard.
9807         * target-float.h: Rename include guard.
9808         * stabsread.h: Add include guard.
9809         * rs6000-tdep.h: Add include guard.
9810         * riscv-fbsd-tdep.h: Add include guard.
9811         * regformats/regdef.h: Rename include guard.
9812         * record.h: Rename include guard.
9813         * python/python.h: Rename include guard.
9814         * python/python-internal.h: Rename include guard.
9815         * python/py-stopevent.h: Rename include guard.
9816         * python/py-ref.h: Rename include guard.
9817         * python/py-record.h: Rename include guard.
9818         * python/py-record-full.h: Rename include guard.
9819         * python/py-record-btrace.h: Rename include guard.
9820         * python/py-instruction.h: Rename include guard.
9821         * python/py-events.h: Rename include guard.
9822         * python/py-event.h: Rename include guard.
9823         * procfs.h: Add include guard.
9824         * proc-utils.h: Add include guard.
9825         * p-lang.h: Add include guard.
9826         * or1k-tdep.h: Rename include guard.
9827         * observable.h: Rename include guard.
9828         * nto-tdep.h: Rename include guard.
9829         * nat/x86-linux.h: Rename include guard.
9830         * nat/x86-linux-dregs.h: Rename include guard.
9831         * nat/x86-gcc-cpuid.h: Add include guard.
9832         * nat/x86-dregs.h: Rename include guard.
9833         * nat/x86-cpuid.h: Rename include guard.
9834         * nat/ppc-linux.h: Rename include guard.
9835         * nat/mips-linux-watch.h: Rename include guard.
9836         * nat/linux-waitpid.h: Rename include guard.
9837         * nat/linux-ptrace.h: Rename include guard.
9838         * nat/linux-procfs.h: Rename include guard.
9839         * nat/linux-osdata.h: Rename include guard.
9840         * nat/linux-nat.h: Rename include guard.
9841         * nat/linux-namespaces.h: Rename include guard.
9842         * nat/linux-btrace.h: Rename include guard.
9843         * nat/glibc_thread_db.h: Rename include guard.
9844         * nat/gdb_thread_db.h: Rename include guard.
9845         * nat/gdb_ptrace.h: Rename include guard.
9846         * nat/fork-inferior.h: Rename include guard.
9847         * nat/amd64-linux-siginfo.h: Rename include guard.
9848         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9849         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9850         * nat/aarch64-linux.h: Rename include guard.
9851         * nat/aarch64-linux-hw-point.h: Rename include guard.
9852         * mn10300-tdep.h: Add include guard.
9853         * mips-linux-tdep.h: Add include guard.
9854         * mi/mi-parse.h: Rename include guard.
9855         * mi/mi-out.h: Rename include guard.
9856         * mi/mi-main.h: Rename include guard.
9857         * mi/mi-interp.h: Rename include guard.
9858         * mi/mi-getopt.h: Rename include guard.
9859         * mi/mi-console.h: Rename include guard.
9860         * mi/mi-common.h: Rename include guard.
9861         * mi/mi-cmds.h: Rename include guard.
9862         * mi/mi-cmd-break.h: Rename include guard.
9863         * m2-lang.h: Add include guard.
9864         * location.h: Rename include guard.
9865         * linux-record.h: Rename include guard.
9866         * linux-nat.h: Add include guard.
9867         * linux-fork.h: Add include guard.
9868         * i386-darwin-tdep.h: Rename include guard.
9869         * hppa-linux-offsets.h: Add include guard.
9870         * guile/guile.h: Rename include guard.
9871         * guile/guile-internal.h: Rename include guard.
9872         * gnu-nat.h: Rename include guard.
9873         * gdb-stabs.h: Rename include guard.
9874         * frv-tdep.h: Add include guard.
9875         * f-lang.h: Add include guard.
9876         * event-loop.h: Add include guard.
9877         * darwin-nat.h: Rename include guard.
9878         * cp-abi.h: Rename include guard.
9879         * config/sparc/nm-sol2.h: Rename include guard.
9880         * config/nm-nto.h: Rename include guard.
9881         * config/nm-linux.h: Add include guard.
9882         * config/i386/nm-i386gnu.h: Rename include guard.
9883         * config/djgpp/nl_types.h: Rename include guard.
9884         * config/djgpp/langinfo.h: Rename include guard.
9885         * compile/gcc-cp-plugin.h: Add include guard.
9886         * compile/gcc-c-plugin.h: Add include guard.
9887         * compile/compile.h: Rename include guard.
9888         * compile/compile-object-run.h: Rename include guard.
9889         * compile/compile-object-load.h: Rename include guard.
9890         * compile/compile-internal.h: Rename include guard.
9891         * compile/compile-cplus.h: Rename include guard.
9892         * compile/compile-c.h: Rename include guard.
9893         * common/xml-utils.h: Rename include guard.
9894         * common/x86-xstate.h: Rename include guard.
9895         * common/version.h: Rename include guard.
9896         * common/vec.h: Rename include guard.
9897         * common/tdesc.h: Rename include guard.
9898         * common/selftest.h: Rename include guard.
9899         * common/scoped_restore.h: Rename include guard.
9900         * common/scoped_mmap.h: Rename include guard.
9901         * common/scoped_fd.h: Rename include guard.
9902         * common/safe-iterator.h: Rename include guard.
9903         * common/run-time-clock.h: Rename include guard.
9904         * common/refcounted-object.h: Rename include guard.
9905         * common/queue.h: Rename include guard.
9906         * common/ptid.h: Rename include guard.
9907         * common/print-utils.h: Rename include guard.
9908         * common/preprocessor.h: Rename include guard.
9909         * common/pathstuff.h: Rename include guard.
9910         * common/observable.h: Rename include guard.
9911         * common/netstuff.h: Rename include guard.
9912         * common/job-control.h: Rename include guard.
9913         * common/host-defs.h: Rename include guard.
9914         * common/gdb_wait.h: Rename include guard.
9915         * common/gdb_vecs.h: Rename include guard.
9916         * common/gdb_unlinker.h: Rename include guard.
9917         * common/gdb_unique_ptr.h: Rename include guard.
9918         * common/gdb_tilde_expand.h: Rename include guard.
9919         * common/gdb_sys_time.h: Rename include guard.
9920         * common/gdb_string_view.h: Rename include guard.
9921         * common/gdb_splay_tree.h: Rename include guard.
9922         * common/gdb_setjmp.h: Rename include guard.
9923         * common/gdb_ref_ptr.h: Rename include guard.
9924         * common/gdb_optional.h: Rename include guard.
9925         * common/gdb_locale.h: Rename include guard.
9926         * common/gdb_assert.h: Rename include guard.
9927         * common/filtered-iterator.h: Rename include guard.
9928         * common/filestuff.h: Rename include guard.
9929         * common/fileio.h: Rename include guard.
9930         * common/environ.h: Rename include guard.
9931         * common/common-utils.h: Rename include guard.
9932         * common/common-types.h: Rename include guard.
9933         * common/common-regcache.h: Rename include guard.
9934         * common/common-inferior.h: Rename include guard.
9935         * common/common-gdbthread.h: Rename include guard.
9936         * common/common-exceptions.h: Rename include guard.
9937         * common/common-defs.h: Rename include guard.
9938         * common/common-debug.h: Rename include guard.
9939         * common/cleanups.h: Rename include guard.
9940         * common/buffer.h: Rename include guard.
9941         * common/btrace-common.h: Rename include guard.
9942         * common/break-common.h: Rename include guard.
9943         * cli/cli-utils.h: Rename include guard.
9944         * cli/cli-style.h: Rename include guard.
9945         * cli/cli-setshow.h: Rename include guard.
9946         * cli/cli-script.h: Rename include guard.
9947         * cli/cli-interp.h: Rename include guard.
9948         * cli/cli-decode.h: Rename include guard.
9949         * cli/cli-cmds.h: Rename include guard.
9950         * charset-list.h: Add include guard.
9951         * buildsym-legacy.h: Rename include guard.
9952         * bfin-tdep.h: Add include guard.
9953         * ax.h: Rename include guard.
9954         * arm-linux-tdep.h: Add include guard.
9955         * arm-fbsd-tdep.h: Add include guard.
9956         * arch/xtensa.h: Rename include guard.
9957         * arch/tic6x.h: Add include guard.
9958         * arch/i386.h: Add include guard.
9959         * arch/arm.h: Rename include guard.
9960         * arch/arm-linux.h: Rename include guard.
9961         * arch/arm-get-next-pcs.h: Rename include guard.
9962         * arch/amd64.h: Add include guard.
9963         * arch/aarch64-insn.h: Rename include guard.
9964         * arch-utils.h: Rename include guard.
9965         * annotate.h: Add include guard.
9966         * amd64-darwin-tdep.h: Rename include guard.
9967         * aarch64-linux-tdep.h: Add include guard.
9968         * aarch64-fbsd-tdep.h: Add include guard.
9969         * aarch32-linux-nat.h: Add include guard.
9970
9971 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9972
9973         * macrotab.c (macro_define_internal): New function that
9974         factorizes macro_define_object_internal and macro_define_function
9975         code.
9976         (macro_define_object_internal): Use macro_define_internal.
9977         (macro_define_function): Likewise.
9978
9979 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9980
9981         * macrocmd.c (extract_identifier): Return
9982         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9983         callers.
9984
9985 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9986
9987         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9988
9989 2019-02-05  Tom Tromey  <tom@tromey.com>
9990
9991         * target.c (target_stack::unpush): Move assertion earlier.
9992
9993 2019-01-30  Tom Tromey  <tom@tromey.com>
9994
9995         PR python/23615:
9996         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9997         (gdbpy_parse_and_eval): Likewise.
9998         * python/python-internal.h (gdbpy_allow_threads): New class.
9999
10000 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10001
10002         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10003         (aarch64_fbsd_fpregmap): Move earlier.
10004         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10005         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10006         instead of individual calls to trad_frame_set_reg_addr.
10007         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10008         earlier.
10009         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10010         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10011         instead of individual calls to trad_frame_set_reg_addr.
10012
10013 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10014
10015         * CONTRIBUTE: Replace contribution list with wiki link.
10016
10017 2019-01-25  Tom Tromey  <tom@tromey.com>
10018
10019         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10020
10021 2019-01-25  Tom Tromey  <tom@tromey.com>
10022
10023         * xtensa-linux-nat.c: Fix common/ includes.
10024         * xml-support.h: Fix common/ includes.
10025         * xml-support.c: Fix common/ includes.
10026         * x86-linux-nat.c: Fix common/ includes.
10027         * windows-nat.c: Fix common/ includes.
10028         * varobj.h: Fix common/ includes.
10029         * varobj.c: Fix common/ includes.
10030         * value.c: Fix common/ includes.
10031         * valops.c: Fix common/ includes.
10032         * utils.c: Fix common/ includes.
10033         * unittests/xml-utils-selftests.c: Fix common/ includes.
10034         * unittests/utils-selftests.c: Fix common/ includes.
10035         * unittests/unpack-selftests.c: Fix common/ includes.
10036         * unittests/tracepoint-selftests.c: Fix common/ includes.
10037         * unittests/style-selftests.c: Fix common/ includes.
10038         * unittests/string_view-selftests.c: Fix common/ includes.
10039         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10040         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10041         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10042         * unittests/rsp-low-selftests.c: Fix common/ includes.
10043         * unittests/parse-connection-spec-selftests.c: Fix common/
10044         includes.
10045         * unittests/optional-selftests.c: Fix common/ includes.
10046         * unittests/offset-type-selftests.c: Fix common/ includes.
10047         * unittests/observable-selftests.c: Fix common/ includes.
10048         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10049         * unittests/memrange-selftests.c: Fix common/ includes.
10050         * unittests/memory-map-selftests.c: Fix common/ includes.
10051         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10052         * unittests/function-view-selftests.c: Fix common/ includes.
10053         * unittests/environ-selftests.c: Fix common/ includes.
10054         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10055         * unittests/common-utils-selftests.c: Fix common/ includes.
10056         * unittests/cli-utils-selftests.c: Fix common/ includes.
10057         * unittests/array-view-selftests.c: Fix common/ includes.
10058         * ui-file.c: Fix common/ includes.
10059         * tui/tui-io.c: Fix common/ includes.
10060         * tracepoint.h: Fix common/ includes.
10061         * tracepoint.c: Fix common/ includes.
10062         * tracefile-tfile.c: Fix common/ includes.
10063         * top.h: Fix common/ includes.
10064         * top.c: Fix common/ includes.
10065         * thread.c: Fix common/ includes.
10066         * target/waitstatus.h: Fix common/ includes.
10067         * target/waitstatus.c: Fix common/ includes.
10068         * target.h: Fix common/ includes.
10069         * target.c: Fix common/ includes.
10070         * target-memory.c: Fix common/ includes.
10071         * target-descriptions.c: Fix common/ includes.
10072         * symtab.h: Fix common/ includes.
10073         * symfile.c: Fix common/ includes.
10074         * stap-probe.c: Fix common/ includes.
10075         * spu-linux-nat.c: Fix common/ includes.
10076         * sparc-nat.c: Fix common/ includes.
10077         * source.c: Fix common/ includes.
10078         * solib.c: Fix common/ includes.
10079         * solib-target.c: Fix common/ includes.
10080         * ser-unix.c: Fix common/ includes.
10081         * ser-tcp.c: Fix common/ includes.
10082         * ser-pipe.c: Fix common/ includes.
10083         * ser-base.c: Fix common/ includes.
10084         * selftest-arch.c: Fix common/ includes.
10085         * s12z-tdep.c: Fix common/ includes.
10086         * rust-exp.y: Fix common/ includes.
10087         * rs6000-aix-tdep.c: Fix common/ includes.
10088         * riscv-tdep.c: Fix common/ includes.
10089         * remote.c: Fix common/ includes.
10090         * remote-notif.h: Fix common/ includes.
10091         * remote-fileio.h: Fix common/ includes.
10092         * remote-fileio.c: Fix common/ includes.
10093         * regcache.h: Fix common/ includes.
10094         * regcache.c: Fix common/ includes.
10095         * record-btrace.c: Fix common/ includes.
10096         * python/python.c: Fix common/ includes.
10097         * python/py-type.c: Fix common/ includes.
10098         * python/py-inferior.c: Fix common/ includes.
10099         * progspace.h: Fix common/ includes.
10100         * producer.c: Fix common/ includes.
10101         * procfs.c: Fix common/ includes.
10102         * proc-api.c: Fix common/ includes.
10103         * printcmd.c: Fix common/ includes.
10104         * ppc-linux-nat.c: Fix common/ includes.
10105         * parser-defs.h: Fix common/ includes.
10106         * osdata.c: Fix common/ includes.
10107         * obsd-nat.c: Fix common/ includes.
10108         * nat/x86-linux.c: Fix common/ includes.
10109         * nat/x86-linux-dregs.c: Fix common/ includes.
10110         * nat/x86-dregs.h: Fix common/ includes.
10111         * nat/x86-dregs.c: Fix common/ includes.
10112         * nat/ppc-linux.c: Fix common/ includes.
10113         * nat/mips-linux-watch.h: Fix common/ includes.
10114         * nat/mips-linux-watch.c: Fix common/ includes.
10115         * nat/linux-waitpid.c: Fix common/ includes.
10116         * nat/linux-ptrace.h: Fix common/ includes.
10117         * nat/linux-ptrace.c: Fix common/ includes.
10118         * nat/linux-procfs.c: Fix common/ includes.
10119         * nat/linux-personality.c: Fix common/ includes.
10120         * nat/linux-osdata.c: Fix common/ includes.
10121         * nat/linux-namespaces.c: Fix common/ includes.
10122         * nat/linux-btrace.h: Fix common/ includes.
10123         * nat/linux-btrace.c: Fix common/ includes.
10124         * nat/fork-inferior.c: Fix common/ includes.
10125         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10126         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10127         * nat/aarch64-linux.c: Fix common/ includes.
10128         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10129         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10130         * namespace.h: Fix common/ includes.
10131         * mips-linux-tdep.c: Fix common/ includes.
10132         * minsyms.c: Fix common/ includes.
10133         * mi/mi-parse.h: Fix common/ includes.
10134         * mi/mi-main.c: Fix common/ includes.
10135         * mi/mi-cmd-env.c: Fix common/ includes.
10136         * memrange.h: Fix common/ includes.
10137         * memattr.c: Fix common/ includes.
10138         * maint.h: Fix common/ includes.
10139         * maint.c: Fix common/ includes.
10140         * main.c: Fix common/ includes.
10141         * machoread.c: Fix common/ includes.
10142         * location.c: Fix common/ includes.
10143         * linux-thread-db.c: Fix common/ includes.
10144         * linux-nat.c: Fix common/ includes.
10145         * linux-fork.c: Fix common/ includes.
10146         * inline-frame.c: Fix common/ includes.
10147         * infrun.c: Fix common/ includes.
10148         * inflow.c: Fix common/ includes.
10149         * inferior.h: Fix common/ includes.
10150         * inferior.c: Fix common/ includes.
10151         * infcmd.c: Fix common/ includes.
10152         * inf-ptrace.c: Fix common/ includes.
10153         * inf-child.c: Fix common/ includes.
10154         * ia64-linux-nat.c: Fix common/ includes.
10155         * i387-tdep.c: Fix common/ includes.
10156         * i386-tdep.c: Fix common/ includes.
10157         * i386-linux-tdep.c: Fix common/ includes.
10158         * i386-linux-nat.c: Fix common/ includes.
10159         * i386-go32-tdep.c: Fix common/ includes.
10160         * i386-fbsd-tdep.c: Fix common/ includes.
10161         * i386-fbsd-nat.c: Fix common/ includes.
10162         * guile/scm-type.c: Fix common/ includes.
10163         * guile/guile.c: Fix common/ includes.
10164         * go32-nat.c: Fix common/ includes.
10165         * gnu-nat.c: Fix common/ includes.
10166         * gdbthread.h: Fix common/ includes.
10167         * gdbarch-selftests.c: Fix common/ includes.
10168         * gdb_usleep.c: Fix common/ includes.
10169         * gdb_select.h: Fix common/ includes.
10170         * gdb_bfd.c: Fix common/ includes.
10171         * gcore.c: Fix common/ includes.
10172         * fork-child.c: Fix common/ includes.
10173         * findvar.c: Fix common/ includes.
10174         * fbsd-nat.c: Fix common/ includes.
10175         * event-top.c: Fix common/ includes.
10176         * event-loop.c: Fix common/ includes.
10177         * dwarf2read.c: Fix common/ includes.
10178         * dwarf2loc.c: Fix common/ includes.
10179         * dwarf2-frame.c: Fix common/ includes.
10180         * dwarf-index-cache.c: Fix common/ includes.
10181         * dtrace-probe.c: Fix common/ includes.
10182         * disasm-selftests.c: Fix common/ includes.
10183         * defs.h: Fix common/ includes.
10184         * csky-tdep.c: Fix common/ includes.
10185         * cp-valprint.c: Fix common/ includes.
10186         * cp-support.h: Fix common/ includes.
10187         * cp-support.c: Fix common/ includes.
10188         * corelow.c: Fix common/ includes.
10189         * completer.h: Fix common/ includes.
10190         * completer.c: Fix common/ includes.
10191         * compile/compile.c: Fix common/ includes.
10192         * compile/compile-loc2c.c: Fix common/ includes.
10193         * compile/compile-cplus-types.c: Fix common/ includes.
10194         * compile/compile-cplus-symbols.c: Fix common/ includes.
10195         * command.h: Fix common/ includes.
10196         * cli/cli-dump.c: Fix common/ includes.
10197         * cli/cli-cmds.c: Fix common/ includes.
10198         * charset.c: Fix common/ includes.
10199         * build-id.c: Fix common/ includes.
10200         * btrace.h: Fix common/ includes.
10201         * btrace.c: Fix common/ includes.
10202         * breakpoint.h: Fix common/ includes.
10203         * breakpoint.c: Fix common/ includes.
10204         * ax.h:
10205         (enum agent_op): Fix common/ includes.
10206         * ax-general.c (struct aop_map): Fix common/ includes.
10207         * ax-gdb.c: Fix common/ includes.
10208         * auxv.c: Fix common/ includes.
10209         * auto-load.c: Fix common/ includes.
10210         * arm-tdep.c: Fix common/ includes.
10211         * arch/riscv.c: Fix common/ includes.
10212         * arch/ppc-linux-common.c: Fix common/ includes.
10213         * arch/i386.c: Fix common/ includes.
10214         * arch/arm.c: Fix common/ includes.
10215         * arch/arm-linux.c: Fix common/ includes.
10216         * arch/arm-get-next-pcs.c: Fix common/ includes.
10217         * arch/amd64.c: Fix common/ includes.
10218         * arch/aarch64.c: Fix common/ includes.
10219         * arch/aarch64-insn.c: Fix common/ includes.
10220         * arch-utils.c: Fix common/ includes.
10221         * amd64-windows-tdep.c: Fix common/ includes.
10222         * amd64-tdep.c: Fix common/ includes.
10223         * amd64-sol2-tdep.c: Fix common/ includes.
10224         * amd64-obsd-tdep.c: Fix common/ includes.
10225         * amd64-nbsd-tdep.c: Fix common/ includes.
10226         * amd64-linux-tdep.c: Fix common/ includes.
10227         * amd64-linux-nat.c: Fix common/ includes.
10228         * amd64-fbsd-tdep.c: Fix common/ includes.
10229         * amd64-fbsd-nat.c: Fix common/ includes.
10230         * amd64-dicos-tdep.c: Fix common/ includes.
10231         * amd64-darwin-tdep.c: Fix common/ includes.
10232         * agent.c: Fix common/ includes.
10233         * ada-lang.h: Fix common/ includes.
10234         * ada-lang.c: Fix common/ includes.
10235         * aarch64-tdep.c: Fix common/ includes.
10236
10237 2019-01-25  Tom Tromey  <tom@tromey.com>
10238
10239         * common/create-version.sh: Use common/version.h.
10240
10241 2019-01-24  Pedro Alves  <palves@redhat.com>
10242
10243         * infrun.c (signal_stop, signal_print, signal_program)
10244         (signal_catch, signal_pass): Now arrays instead of pointers.
10245         (update_signals_program_target, do_target_resume)
10246         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10247         * linux-nat.c (linux_nat_target::pass_signals)
10248         (linux_nat_target::create_inferior, linux_nat_target::attach):
10249         Adjust.
10250         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10251         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10252         * procfs.c (procfs_target::pass_signals): Adjust.
10253         * record-full.c (record_full_target::resume): Adjust.
10254         * remote.c (remote_target::pass_signals)
10255         (remote_target::program_signals): Adjust.
10256         * target-debug.h (target_debug_print_signals): Now takes a
10257         gdb::array_view as parameter.  Adjust.
10258         * target.h (target_ops) <pass_signals, program_signals>: Replace
10259         pointer and length parameters with gdb::array_view.
10260         (target_pass_signals, target_program_signals): Likewise.
10261         * target-delegates.c: Regenerate.
10262
10263 2019-01-24  Pedro Alves  <palves@redhat.com>
10264
10265         * common/forward-scope-exit.h
10266         (forward_scope_exit::forward_scope_exit): Pass arguments to
10267         m_bind_function directly, instead of creating a std::bind and
10268         copying that.
10269
10270 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10271
10272         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10273         for static members.
10274         (pass_in_v_vfp_candidate): Likewise.
10275
10276 2019-01-23  Tom Tromey  <tom@tromey.com>
10277             Pedro Alves  <palves@redhat.com>
10278
10279         * regcache.c (class regcache_invalidator): Remove.
10280         (regcache::raw_write): Use make_scope_exit.
10281
10282 2019-01-23  Tom Tromey  <tom@tromey.com>
10283
10284         * ui-out.h (class ui_out_emit_type): Update comment.
10285
10286 2019-01-23  Tom Tromey  <tom@tromey.com>
10287
10288         * infrun.c (fetch_inferior_event): Update comment.
10289
10290 2019-01-23  Tom Tromey  <tom@tromey.com>
10291             Pedro Alves  <palves@redhat.com>
10292
10293         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10294         parameter.
10295         (fetch_inferior_event): Use SCOPE_EXIT.
10296
10297
10298 2019-01-23  Tom Tromey  <tom@tromey.com>
10299             Pedro Alves  <palves@redhat.com>
10300
10301         * infrun.c (disable_thread_events): Delete.
10302         (stop_all_threads): Use SCOPE_EXIT.
10303
10304 2019-01-23  Tom Tromey  <tom@tromey.com>
10305             Pedro Alves  <palves@redhat.com>
10306
10307         * symfile.c: Include forward-scope-exit.h.
10308         (clear_symtab_users_cleanup): Replace forward declaration with
10309         a FORWARD_SCOPE_EXIT.
10310         (syms_from_objfile_1): Use the forward_scope_exit and
10311         gdb::optional instead of cleanup_function.
10312         (reread_symbols): Use the forward_scope_exit instead of
10313         cleanup_function.
10314         (clear_symtab_users_cleanup): Remove function.
10315
10316 2019-01-23  Tom Tromey  <tom@tromey.com>
10317             Pedro Alves  <palves@redhat.com>
10318
10319         * linux-nat.c: Include scope-exit.h.
10320         (cleanup_target_stop): Remove.
10321         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10322         SCOPE_EXIT.
10323
10324 2019-01-23  Tom Tromey  <tom@tromey.com>
10325             Pedro Alves  <palves@redhat.com>
10326
10327         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10328         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10329
10330 2019-01-23  Tom Tromey  <tom@tromey.com>
10331             Andrew Burgess  <andrew.burgess@embecosm.com>
10332             Pedro Alves  <palves@redhat.com>
10333
10334         * infrun.c (fetch_inferior_event): Use scope_exit.
10335         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10336         * top.c (execute_command): Use scope_exit.
10337         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10338         * utils.c (do_bpstat_clear_actions_cleanup)
10339         (make_bpstat_clear_actions_cleanup): Remove.
10340
10341 2019-01-23  Tom Tromey  <tom@tromey.com>
10342             Pedro Alves  <palves@redhat.com>
10343
10344         * infrun.c: Include "common/scope-exit.h"
10345         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10346         (wait_for_inferior): Use SCOPE_EXIT.
10347         (fetch_inferior_event): Use scope_exit.
10348
10349 2019-01-23  Tom Tromey  <tom@tromey.com>
10350             Pedro Alves  <palves@redhat.com>
10351
10352         * breakpoint.c (create_breakpoint): Remove cleanup.
10353
10354 2019-01-23  Tom Tromey  <tom@tromey.com>
10355             Andrew Burgess  <andrew.burgess@embecosm.com>
10356             Pedro Alves  <palves@redhat.com>
10357
10358 2019-01-23  Pedro Alves  <palves@redhat.com>
10359
10360         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10361
10362 2019-01-23  Pedro Alves  <palves@redhat.com>
10363             Andrew Burgess  <andrew.burgess@embecosm.com>
10364
10365         * gdbthread.h: Include "common/forward-scope-exit.h".
10366         (scoped_finish_thread_state): Redefine custom class in terms of
10367         forward_scope_exit.
10368
10369 2019-01-23  Pedro Alves  <palves@redhat.com>
10370             Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * common/forward-scope-exit.h: New file.
10373
10374 2019-01-23  Pedro Alves  <palves@redhat.com>
10375             Andrew Burgess  <andrew.burgess@embecosm.com>
10376             Tom Tromey  <tom@tromey.com>
10377
10378         * common/scope-exit.h: New file.
10379
10380 2019-01-23  Pedro Alves  <palves@redhat.com>
10381
10382         * common/preprocessor.h (ESC): Rename to ...
10383         (ESC_PARENS): ... this.
10384         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10385         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10386
10387 2019-01-23  Tom Tromey  <tom@tromey.com>
10388
10389         * language.h (class scoped_switch_to_sym_language_if_auto):
10390         Initialize m_lang in both cases.
10391
10392 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10393
10394         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10395         with XCNEW.
10396
10397 2019-01-22  Tom Tromey  <tom@tromey.com>
10398
10399         * corelow.c: Do not include sys/file.h.
10400
10401 2019-01-22  Tom Tromey  <tom@tromey.com>
10402
10403         * tui/tui-wingeneral.h: Include gdb_curses.h.
10404
10405 2019-01-22  Tom Tromey  <tom@tromey.com>
10406
10407         * source-cache.h (class source_cache) <get_source_lines,
10408         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10409
10410 2019-01-22  Tom Tromey  <tom@tromey.com>
10411
10412         * remote-fileio.h (struct remote_target): Declare.
10413
10414 2019-01-22  Tom Tromey  <tom@tromey.com>
10415
10416         * python/py-arch.c: Do not include py-ref.h.
10417         * python/py-bpevent.c: Do not include py-ref.h.
10418         * python/py-cmd.c: Do not include py-ref.h.
10419         * python/py-continueevent.c: Do not include py-ref.h.
10420         * python/py-event.h: Do not include py-ref.h.
10421         * python/py-evtregistry.c: Do not include py-ref.h.
10422         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10423         * python/py-frame.c: Do not include py-ref.h.
10424         * python/py-framefilter.c: Do not include py-ref.h.
10425         * python/py-function.c: Do not include py-ref.h.
10426         * python/py-infevents.c: Do not include py-ref.h.
10427         * python/py-linetable.c: Do not include py-ref.h.
10428         * python/py-objfile.c: Do not include py-ref.h.
10429         * python/py-param.c: Do not include py-ref.h.
10430         * python/py-prettyprint.c: Do not include py-ref.h.
10431         * python/py-progspace.c: Do not include py-ref.h.
10432         * python/py-symbol.c: Do not include py-ref.h.
10433         * python/py-symtab.c: Do not include py-ref.h.
10434         * python/py-type.c: Do not include py-ref.h.
10435         * python/py-unwind.c: Do not include py-ref.h.
10436         * python/py-utils.c: Do not include py-ref.h.
10437         * python/py-value.c: Do not include py-ref.h.
10438         * python/py-varobj.c: Do not include py-ref.h.
10439         * python/py-xmethods.c: Do not include py-ref.h.
10440         * python/python.c: Do not include py-ref.h.
10441         * varobj.c: Do not include py-ref.h.
10442
10443 2019-01-22  Tom Tromey  <tom@tromey.com>
10444
10445         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10446         keyword for bcache.
10447
10448 2019-01-22  Tom Tromey  <tom@tromey.com>
10449
10450         * compile/compile-cplus-types.c: Remove a comment by #include.
10451
10452 2019-01-22  Tom Tromey  <tom@tromey.com>
10453
10454         * compile/gcc-c-plugin.h: Include compile-internal.h.
10455
10456 2019-01-22  Tom Tromey  <tom@tromey.com>
10457
10458         * stabsread.c (EXTERN): Do not define.
10459         (symnum, next_symbol_text_func, processing_gcc_compilation)
10460         (within_function, global_sym_chain, global_stabs)
10461         (previous_stab_code, this_object_header_files)
10462         (n_this_object_header_files)
10463         (n_allocated_this_object_header_files): Define.
10464         * stabsread.h (EXTERN): Never define.  Use "extern".
10465
10466 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10467
10468         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10469         history_value.
10470
10471 2019-01-21  Tom Tromey  <tom@tromey.com>
10472
10473         * ui-out.c: Fix includes.
10474         * tui/tui-source.c: Fix includes.
10475         * target.c: Fix includes.
10476         * remote.c: Fix includes.
10477         * regcache.c: Fix includes.
10478         * python/py-block.c: Fix includes.
10479         * printcmd.c: Fix includes.
10480         * or1k-tdep.c: Fix includes.
10481         * mi/mi-main.c: Fix includes.
10482         * m32r-tdep.c: Fix includes.
10483         * csky-tdep.c: Fix includes.
10484         * compile/compile-cplus-types.c: Fix includes.
10485         * cli/cli-interp.c: Fix includes.
10486
10487 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10488
10489         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10490         for padding.
10491
10492 2019-01-16  Tom Tromey  <tom@tromey.com>
10493
10494         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10495         earlier.
10496         (struct objfile) <msymbols_range>: Move from top level.
10497         <msymbols>: New method.
10498         (class objfile_msymbols): Remove.
10499         * symtab.c (default_collect_symbol_completion_matches_break_on):
10500         Update.
10501         * symmisc.c (dump_msymbols): Update.
10502         * stabsread.c (scan_file_globals): Update.
10503         * objc-lang.c (info_selectors_command, info_classes_command)
10504         (find_methods): Update.
10505         * minsyms.c (find_solib_trampoline_target): Update.
10506         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10507         * coffread.c (coff_symfile_read): Update.
10508         * ada-lang.c (ada_lookup_simple_minsym)
10509         (ada_collect_symbol_completion_matches): Update.
10510
10511 2019-01-16  Tom Tromey  <tom@tromey.com>
10512
10513         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10514         type.  Remove no-argument constructor.
10515         <iterator::operator++>: Simplify.
10516         <begin>: Update.
10517         <end>: Use minimal_symbol_count.
10518
10519 2019-01-16  Tom Tromey  <tom@tromey.com>
10520
10521         * objfiles.h (struct objfile) <psymtabs>: New method.
10522         (class objfile_psymtabs): Remove.
10523         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10524         typedef.
10525         <range>: New method.
10526         (require_partial_symbols): Change return type.
10527         * psymtab.c (require_partial_symbols)
10528         (psym_expand_symtabs_matching): Update.
10529         * mdebugread.c (parse_partial_symbols): Update.
10530         * dbxread.c (dbx_end_psymtab): Update.
10531
10532 2019-01-15  Tom Tromey  <tom@tromey.com>
10533
10534         * symtab.c (lookup_objfile_from_block)
10535         (lookup_symbol_in_objfile_symtabs)
10536         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10537         (find_line_symtab, info_sources_command)
10538         (default_collect_symbol_completion_matches_break_on)
10539         (make_source_files_completion_list): Update.
10540         * symmisc.c (print_objfile_statistics, dump_objfile)
10541         (maintenance_print_symbols, maintenance_info_symtabs)
10542         (maintenance_check_symtabs, maintenance_info_line_tables):
10543         Update.
10544         * source.c (select_source_symtab)
10545         (forget_cached_source_info_for_objfile): Update.
10546         * objfiles.h (class objfile_compunits): Remove.
10547         (struct objfile) <compunits_range>: New typedef.
10548         (compunits): New method.
10549         * objfiles.c (objfile_relocate1): Update.
10550         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10551         * maint.c (count_symtabs_and_blocks): Update.
10552         * linespec.c (iterate_over_all_matching_symtabs): Update.
10553         * cp-support.c (add_symbol_overload_list_qualified): Update.
10554         * coffread.c (coff_symtab_read): Update.
10555         * ada-lang.c (add_nonlocal_symbols)
10556         (ada_collect_symbol_completion_matches)
10557         (ada_add_global_exceptions): Update.
10558
10559 2019-01-15  Tom Tromey  <tom@tromey.com>
10560
10561         * progspace.h (program_space) <objfiles_safe_range>: New
10562         typedef.
10563         <objfiles_safe>: New method.
10564         * objfiles.h (class all_objfiles_safe): Remove.
10565         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10566         * jit.c (jit_inferior_exit_hook): Update.
10567
10568 2019-01-17  Tom Tromey  <tom@tromey.com>
10569
10570         * progspace.h (program_space) <objfiles_range>: New typedef.
10571         <objfiles>: New method.
10572         <objfiles_head>: Rename from objfiles.
10573         (object_files): Update.
10574         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10575         * guile/scm-pretty-print.c
10576         (ppscm_find_pretty_printer_from_objfiles): Update.
10577         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10578         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10579         Update.
10580         * python/py-progspace.c (pspy_get_objfiles): Update.
10581         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10582         Update.
10583         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10584         (objfpy_lookup_objfile_by_build_id): Update.
10585         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10586         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10587         Update.
10588         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10589         (expand_symtab_containing_pc, lookup_objfile_from_block)
10590         (lookup_static_symbol, basic_lookup_transparent_type)
10591         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10592         (find_line_symtab, info_sources_command)
10593         (default_collect_symbol_completion_matches_break_on)
10594         (make_source_files_completion_list, find_main_name): Update.
10595         * symmisc.c (print_symbol_bcache_statistics)
10596         (print_objfile_statistics, maintenance_print_symbols)
10597         (maintenance_print_msymbols, maintenance_print_objfiles)
10598         (maintenance_info_symtabs, maintenance_check_symtabs)
10599         (maintenance_expand_symtabs, maintenance_info_line_tables):
10600         Update.
10601         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10602         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10603         (map_overlay_command, unmap_overlay_command)
10604         (simple_overlay_update, expand_symtabs_matching)
10605         (map_symbol_filenames): Update.
10606         * symfile-debug.c (set_debug_symfile): Update.
10607         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10608         Update.
10609         * source.c (select_source_symtab, forget_cached_source_info):
10610         Update.
10611         * solib.c (solib_read_symbols): Update.
10612         * solib-spu.c (append_ocl_sos): Update.
10613         * psymtab.c (maintenance_print_psymbols)
10614         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10615         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10616         * printcmd.c (info_symbol_command): Update.
10617         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10618         Update.
10619         * objfiles.h (class all_objfiles): Remove.
10620         * objfiles.c (have_partial_symbols, have_full_symbols)
10621         (have_minimal_symbols, qsort_cmp, update_section_map)
10622         (shared_objfile_contains_address_p)
10623         (default_iterate_over_objfiles_in_search_order): Update.
10624         * objc-lang.c (info_selectors_command, info_classes_command)
10625         (find_methods): Update.
10626         * minsyms.c (find_solib_trampoline_target): Update.
10627         * maint.c (maintenance_info_sections)
10628         (maintenance_translate_address, count_symtabs_and_blocks):
10629         Update.
10630         * main.c (captured_main_1): Update.
10631         * linux-thread-db.c (try_thread_db_load_from_pdir)
10632         (has_libpthread): Update.
10633         * linespec.c (iterate_over_all_matching_symtabs)
10634         (search_minsyms_for_name): Update.
10635         * jit.c (jit_find_objf_with_entry_addr): Update.
10636         * hppa-tdep.c (find_unwind_entry)
10637         (hppa_lookup_stub_minimal_symbol): Update.
10638         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10639         Update.
10640         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10641         (elf_gnu_ifunc_resolve_by_got): Update.
10642         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10643         * dwarf-index-write.c (save_gdb_index_command): Update.
10644         * cp-support.c (add_symbol_overload_list_qualified): Update.
10645         * breakpoint.c (create_overlay_event_breakpoint)
10646         (create_longjmp_master_breakpoint)
10647         (create_std_terminate_master_breakpoint)
10648         (create_exception_master_breakpoint): Update.
10649         * blockframe.c (find_pc_partial_function): Update.
10650         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10651         (ada_collect_symbol_completion_matches)
10652         (ada_add_global_exceptions): Update.
10653
10654 2019-01-17  Tom Tromey  <tom@tromey.com>
10655
10656         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10657         declare VEC.
10658         (solib_target_parse_libraries): Change return type.
10659         (library_list_start_segment, library_list_start_section)
10660         (library_list_end_library, library_list_start_library); Update.
10661         (solib_target_free_library_list): Remove.
10662         (solib_target_parse_libraries): Remove cleanup.  Change return
10663         type.
10664         (solib_target_current_sos): Update.
10665
10666 2019-01-17  Tom Tromey  <tromey@bapiya>
10667
10668         * valprint.c: Replace "the the" with "the".
10669         * symtab.c: Replace "the the" with "the".
10670         * solib.c: Replace "the the" with "the".
10671         * solib-dsbt.c: Replace "the the" with "the".
10672         * linespec.c: Replace "the the" with "the".
10673         * dwarf2loc.h: Replace "the the" with "the".
10674         * amd64-windows-tdep.c: Replace "the the" with "the".
10675         * aarch64-tdep.c: Replace "the the" with "the".
10676
10677 2019-01-16  Keith Seitz  <keiths@redhat.com>
10678
10679         PR gdb/23773
10680         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10681         <builder>: Rename to ..
10682         <m_builder>: ... this and make private.
10683         (dwarf2_cu::get_builder): New method.  Change all users of
10684         `builder' to use this method.
10685         (dwarf2_start_symtab): Move to ...
10686         (dwarf2_cu::start_symtab): ... here.  Update all callers
10687         (setup_type_unit_groups): Move to ...
10688         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10689         callers.
10690         (dwarf2_cu::reset_builder): New method.
10691         (process_full_compunit, process_full_type_unit): Use
10692         dwarf2_cu::reset_builder.
10693         (follow_die_offset): Record the ancestor CU if it is different
10694         from the followed DIE's CU.
10695         (follow_die_sig_1): Likewise.
10696
10697 2019-01-15  Tom Tromey  <tom@tromey.com>
10698
10699         * remote.c (class remote_state) <buf>: Now a char_vector.
10700         <buf_size>: Remove.
10701         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10702         parameter.
10703         (remote_target::getpkt_or_notif_sane_1)
10704         (remote_target::getpkt_sane)
10705         (remote_target::getpkt_or_notif_sane): Likewise.
10706         (class remote_target) <putpkt>: New overload.
10707         (remote_target::read_frame): Change type of "buf_p".  Remove
10708         sizeof_p parameter.
10709         (packet_ok): New overload.
10710         (packet_check_result): New overload.
10711         Update all uses.
10712
10713 2019-01-14  Tom Tromey  <tom@tromey.com>
10714
10715         * remote-notif.c (handle_notification, remote_notif_ack)
10716         (remote_notif_parse): Make "buf" const.
10717         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10718         const.
10719         (remote_notif_parse, remote_notif_ack, handle_notification):
10720         Likewise.
10721         * remote.c (remote_notif_stop_parse): Make "buf" const.
10722         (remote_target::remote_parse_stop_reply): Make "buf" const.
10723         (remote_notif_stop_ack): Make "buf" const.
10724
10725 2019-01-14  Tom Tromey  <tom@tromey.com>
10726
10727         * remote.c (remote_console_output): Make parameter const.
10728
10729 2019-01-14  Tom Tromey  <tom@tromey.com>
10730
10731         * target-debug.h (target_debug_print_signals): Constify.
10732         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10733         * procfs.c (procfs_target::pass_signals): Update.
10734         * linux-nat.c (linux_nat_target::pass_signals): Update.
10735         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10736         * target-delegates.c: Rebuild.
10737         * remote.c (remote_target::program_signals): Update.
10738         (remote_target::pass_signals): Update.
10739         * target.c (target_pass_signals): Constify argument.
10740         (target_program_signals): Likewise.
10741         * target.h (struct target_ops) <pass_signals, program_signals>:
10742         Constify argument.
10743         (target_pass_signals, target_program_signals): Constify argument.
10744
10745 2019-01-14  Tom Tromey  <tom@tromey.com>
10746
10747         PR tui/28819:
10748         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10749
10750 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10751
10752         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10753         field.
10754         * rs6000-tdep.c: Include reggroups.h.
10755         (IS_V_ALIAS_PSEUDOREG): Define.
10756         (rs6000_register_name): Return names for the "vX" aliases.
10757         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10758         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10759         aliases.  Call default_register_reggroup_p for all other
10760         pseudo-registers.
10761         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10762         New functions.
10763         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10764         Handle "vX" aliases.
10765         (v_alias_pseudo_register_collect): New function.
10766         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10767         (rs6000_gdbarch_init): Initialize "vX" aliases as
10768         pseudo-registers.  Restore registration of
10769         rs6000_pseudo_register_reggroup_p with
10770         set_tdesc_pseudo_register_reggroup_p.
10771
10772 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10773
10774         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10775         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10776         set_gdbarch_num_pseudo_regs.
10777
10778 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10779
10780         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10781         Remove arg prefixname, add do_set and do_show.
10782         Add member functions set_list and show_list.
10783         * cli/cli-style.c (class cli_style_option): Update accordingly.
10784         (style_set_list): Move to file scope.
10785         (style_show_list): Likewise.
10786         (set_style): Call help_list.
10787         (show_style): Call cmd_show_list.
10788         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10789         Update to use the new macro.
10790
10791 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10792
10793         * ada-lang.c (_initialize_ada_language): Expand the help text
10794         for the "catch exception" command.
10795
10796 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10797
10798         * symtab.c (matching_obj_sections): Initialize obj,
10799         declare it closer to its usage.
10800
10801 2019-01-10  Tom Tromey  <tom@tromey.com>
10802
10803         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10804         (basic_inf_threads_range): Remove.
10805         (inf_threads_range, inf_non_exited_threads_range)
10806         (safe_inf_threads_range): Use next_adapter.
10807
10808 2019-01-10  Keith Seitz  <keiths@redhat.com>
10809
10810         PR gdb/23712
10811         PR symtab/23010
10812         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10813         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10814
10815 2019-01-10  Keith Seitz  <keiths@redhat.com>
10816
10817         PR gdb/23712
10818         PR symtab/23010
10819         * dictionary.c (pending_to_vector): Remove.
10820         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10821         Remove _1 suffix, replacing functions of the same name.  Update
10822         all callers.
10823         (dict_create_hashed, dict_create_hashed_expandable)
10824         (dict_create_linear, dict_create_linear_expandable, dict_free)
10825         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10826         Make functions static.
10827
10828 2019-01-10  Keith Seitz  <keiths@redhat.com>
10829
10830         PR gdb/23712
10831         PR symtab/23010
10832         * dictionary.h (struct dictionary): Replace declaration with
10833         multidictionary.
10834         (dict_create_hashed, dict_create_hashed_expandable)
10835         (dict_create_linear, dict_create_linear_expandable)
10836         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10837         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10838         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10839         taking multidictionary argument.
10840         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10841         * block.h (struct block) <dict>: Change to multidictionary
10842         and rename `multidict'.
10843         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10844         symmisc.c: Update all dictionary references to multidictionary.
10845
10846 2019-01-10  Keith Seitz  <keiths@redhat.com>
10847
10848         PR gdb/23712
10849         PR symtab/23010
10850         * dictionary.c: Include unordered_map.
10851         (pending_to_vector): New function.
10852         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10853         Rewrite the non-"_1" functions to take vector instead
10854         of linked list.
10855         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10856         "new" _1 versions of the same name.
10857         (multidictionary): Define.
10858         (std::hash<enum language): New definition.
10859         (collate_pending_symbols_by_language, mdict_create_hashed)
10860         (mdict_create_hashed_expandable, mdict_create_linear)
10861         (mdict_create_linear_expandable, mdict_free)
10862         (find_language_dictionary, create_new_language_dictionary)
10863         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10864         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10865         (mdict_size, mdict_empty): New functions.
10866         * dictionary.h (mdict_iterator): Define.
10867
10868 2019-01-10  Pedro Alves  <palves@redhat.com>
10869
10870         * breakpoint.c (read_uploaded_action)
10871         (create_tracepoint_from_upload): Adjust to use
10872         gdb::unique_xmalloc_ptr.
10873         * ctf.c (ctf_write_uploaded_tp):
10874         (SET_ARRAY_FIELD): Use emplace_back.
10875         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10876         * tracefile-tfile.c (tfile_write_uploaded_tp):
10877         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10878         gdb::unique_xmalloc_ptr.
10879         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10880         at_string, cond_string, cmd_strings>: Replace char pointers
10881         with gdb::unique_xmalloc_ptr.
10882
10883 2019-01-10  Pedro Alves  <palves@redhat.com>
10884
10885         * solib-target.c (library_list_start_library): Don't xstrdup name.
10886
10887 2019-01-10  Pedro Alves  <palves@redhat.com>
10888
10889         * mdebugread.c (parse_partial_symbols): Use
10890         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10891
10892 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * linux-fork.c (scoped_switch_fork_info)
10895         <~scoped_switch_fork_info>: Fix incorrect variable name.
10896
10897 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10898
10899         * linux-fork.c (scoped_switch_fork_info)
10900         <scoped_switch_fork_info>: Make explicit.
10901         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10902
10903 2019-01-10  Tom Tromey  <tom@tromey.com>
10904
10905         * objfiles.h (objfile::reset_psymtabs): Update.
10906         * objfiles.c (objfile::objfile): Update.
10907         * psymtab.h (psymtab_storage::obstack): Update.
10908         (psymtab_storage::m_obstack): Use gdb::optional.
10909         (class psymtab_storage): Update comment.  Remove objfile
10910         parameter.
10911         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10912
10913 2019-01-10  Tom Tromey  <tom@tromey.com>
10914
10915         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10916         <free_psymtabs>: Now private.
10917         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10918         (allocate_psymtab): Use new method.
10919
10920 2019-01-10  Tom Tromey  <tom@tromey.com>
10921
10922         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10923         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10924         * mdebugread.c (parse_partial_symbols): Use
10925         allocate_dependencies.
10926         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10927         allocate_dependencies.
10928         (process_psymtab_comp_unit_reader)
10929         (build_type_psymtab_dependencies): Likewise.
10930         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10931
10932 2019-01-10  Tom Tromey  <tom@tromey.com>
10933
10934         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10935         PSYMBOL_SET_LANGUAGE.
10936         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10937
10938 2019-01-10  Tom Tromey  <tom@tromey.com>
10939
10940         * psymtab.h (psymtab_storage::obstack): New method.
10941         <m_obstack>: Rename from obstack; now private.
10942         * psymtab.c (psymtab_storage): Update.
10943         * dwarf2read.c (create_addrmap_from_index)
10944         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10945         Update.
10946
10947 2019-01-10  Tom Tromey  <tom@tromey.com>
10948
10949         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10950         * objfiles.h (objfile::reset_psymtabs): New method.
10951
10952 2019-01-10  Tom Tromey  <tom@tromey.com>
10953
10954         * symmisc.c (print_symbol_bcache_statistics): Update.
10955         (print_objfile_statistics): Update.
10956         * symfile.c (reread_symbols): Update.
10957         * psymtab.h (class psymtab_storage): New.
10958         * psymtab.c (psymtab_storage): New constructor.
10959         (~psymtab_storage): New destructor.
10960         (require_partial_symbols): Update.
10961         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10962         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10963         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10964         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10965         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10966         (start_psymtab_common, end_psymtab_common)
10967         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10968         (allocate_psymtab): Update.
10969         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10970         Update.
10971         (dump_psymtab_addrmap, maintenance_print_psymbols)
10972         (maintenance_check_psymtabs): Update.
10973         (class objfile_psymtabs): Move to objfiles.h.
10974         * psympriv.h (discard_psymtab): Now inline.
10975         (psymtab_discarder::psymtab_discarder): Update.
10976         (psymtab_discarder::~psymtab_discarder): Update.
10977         (ALL_OBJFILE_PSYMTABS): Rewrite.
10978         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10979         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10980         Remove fields.
10981         <partial_symtabs>: New field.
10982         (class objfile_psymtabs): Move from psymtab.h.  Update.
10983         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10984         psymbol_cache.
10985         (objfile::~objfile): Don't destroy psymbol_cache.
10986         * mdebugread.c (parse_partial_symbols): Update.
10987         * dwarf2read.c (create_addrmap_from_index)
10988         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10989         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10990         (add_partial_subprogram, dwarf2_ranges_read): Update.
10991         * dwarf-index-write.c (write_address_map)
10992         (write_one_signatured_type, recursively_write_psymbols)
10993         (class debug_names, class debug_names, write_psymtabs_to_index):
10994         Update.
10995
10996 2019-01-10  Tom Tromey  <tom@tromey.com>
10997
10998         * symtab.h (SYMBOL_SET_NAMES): Update.
10999         (symbol_set_names): Update.
11000         (MSYMBOL_SET_NAMES): Update.
11001         * symtab.c (symbol_set_names): Change argument to be an
11002         objfile_per_bfd_storage.
11003         * psymtab.c (add_psymbol_to_bcache): Update.
11004         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11005
11006 2019-01-10  Tom Tromey  <tom@tromey.com>
11007
11008         * symtab.c (create_demangled_names_hash): Change argument to be an
11009         objfile_per_bfd_storage.
11010         (symbol_set_names): Update.
11011
11012 2019-01-10  Tom Tromey  <tom@tromey.com>
11013
11014         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11015         init_psymbol_list.
11016         * psymtab.c (init_psymbol_list): Do nothing if already called.
11017         * psympriv.h (init_psymbol_list): Add comment.
11018         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11019         init_psymbol_list.
11020         * dbxread.c (dbx_symfile_read): Unconditionally call
11021         init_psymbol_list.
11022
11023 2019-01-10  Tom Tromey  <tom@tromey.com>
11024
11025         * xcoffread.c (scan_xcoff_symtab): Update.
11026         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11027         "where".
11028         * mdebugread.c (parse_partial_symbols)
11029         (handle_psymbol_enumerators): Update.
11030         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11031         * dbxread.c (read_dbx_symtab): Update.
11032         * psympriv.h (psymbol_placement): New enum.
11033         (add_psymbol_to_list): Update.
11034
11035 2019-01-10  Tom Tromey  <tom@tromey.com>
11036
11037         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11038         static_psymbols parameters.
11039         (scan_xcoff_symtab): Update.
11040         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11041         static_psymbols parameters.
11042         * psympriv.h (start_psymtab_common): Update.
11043         * mdebugread.c (parse_partial_symbols): Update.
11044         * dwarf2read.c (create_partial_symtab): Update.
11045         * dbxread.c (read_dbx_symtab): Update.
11046         (start_psymtab): Remove global_psymbols and static_psymbols
11047         parameters.
11048
11049 2019-01-10  Tom Tromey  <tom@tromey.com>
11050
11051         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11052         * psymtab.c (allocate_psymtab): Add comment.
11053         * psympriv.h (allocate_psymtab): Add comment.
11054         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11055         initializations.
11056         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11057
11058 2019-01-10  Tom Tromey  <tom@tromey.com>
11059
11060         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11061         Don't declare.
11062         * mipsread.c: Include mdebugread.h.
11063         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11064         Declare.
11065         * elfread.c: Include mdebugread.h.
11066
11067 2019-01-09  Tom Tromey  <tom@tromey.com>
11068
11069         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11070         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11071         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11072         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11073         (psym_lookup_symbol, psym_find_last_source_symtab)
11074         (psym_forget_cached_source_info, psym_print_stats)
11075         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11076         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11077         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11078         (psym_find_compunit_symtab_by_address)
11079         (maintenance_print_psymbols, maintenance_info_psymtabs)
11080         (maintenance_check_psymtabs): Use ranged for.
11081         * psymtab.h (class objfile_psymtabs): New.
11082         (require_partial_symbols): Return objfile_psymtabs.
11083         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11084
11085 2019-01-09  Tom Tromey  <tom@tromey.com>
11086
11087         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11088         (find_pc_mapped_section, list_overlays_command)
11089         (map_overlay_command, unmap_overlay_command)
11090         (simple_overlay_update): Use all_objfiles.
11091         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11092         * printcmd.c (info_symbol_command): Use all_objfiles.
11093         * objfiles.h (ALL_OBJSECTIONS): Remove.
11094         * maint.c (maintenance_translate_address): Use all_objfiles.
11095         * gcore.c (gcore_create_callback): Use all_objfiles.
11096         (objfile_find_memory_regions): Likewise.
11097
11098 2019-01-09  Tom Tromey  <tom@tromey.com>
11099
11100         * symtab.c (find_line_symtab, info_sources_command)
11101         (make_source_files_completion_list): Use objfile_compunits.
11102         * source.c (select_source_symtab): Use objfile_compunits.
11103         * objfiles.h (struct objfile): Update comment.
11104         (ALL_OBJFILES): Remove.
11105         (ALL_FILETABS): Remove.
11106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11107         objfile_compunits.
11108
11109 2019-01-09  Tom Tromey  <tom@tromey.com>
11110
11111         * symmisc.c (print_objfile_statistics, dump_objfile)
11112         (maintenance_print_symbols): Use compunit_filetabs.
11113         * source.c (forget_cached_source_info_for_objfile): Use
11114         compunit_filetabs.
11115         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11116         (ALL_FILETABS): Use compunit_filetabs.
11117         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11118         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11119
11120 2019-01-09  Tom Tromey  <tom@tromey.com>
11121
11122         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11123         (compunit_filetabs): New.
11124         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11125         compunit_filetabs.
11126         (info_sources_command, make_source_files_completion_list): Remove
11127         declaration.
11128         * symmisc.c (print_objfile_statistics, dump_objfile)
11129         (maintenance_print_symbols): Remove declaration.
11130         (maintenance_info_symtabs): Use compunit_filetabs.
11131         (maintenance_info_line_tables): Likewise.
11132         * source.c (select_source_symtab): Change local variable name.
11133         (forget_cached_source_info_for_objfile): Remove declaration.
11134         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11135         * objfiles.c (objfile_relocate1): Remove declaration.
11136         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11137         declaration.
11138         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11139         * coffread.c (coff_symtab_read): Remove declaration.
11140         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11141         compunit_filetabs.
11142
11143 2019-01-09  Tom Tromey  <tom@tromey.com>
11144
11145         * symtab.c (lookup_objfile_from_block)
11146         (find_pc_sect_compunit_symtab, search_symbols)
11147         (default_collect_symbol_completion_matches_break_on): Use
11148         objfile_compunits.
11149         * objfiles.h (ALL_COMPUNITS): Remove.
11150         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11151         * cp-support.c (add_symbol_overload_list_qualified): Use
11152         objfile_compunits.
11153         * ada-lang.c (ada_collect_symbol_completion_matches)
11154         (ada_add_global_exceptions): Use objfile_compunits.
11155
11156 2019-01-09  Tom Tromey  <tom@tromey.com>
11157
11158         * source.c (select_source_symtab)
11159         (forget_cached_source_info_for_objfile): Remove declaration.
11160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11161         declaration.
11162         * maint.c (count_symtabs_and_blocks): Remove declaration.
11163         * cp-support.c (add_symbol_overload_list_qualified): Remove
11164         declaration.
11165         * coffread.c (coff_symtab_read): Remove declaration.
11166         * symtab.c (lookup_symbol_in_objfile_symtabs)
11167         (basic_lookup_transparent_type_1): Use objfile_compunits.
11168         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11169         (info_sources_command, search_symbols)
11170         (default_collect_symbol_completion_matches_break_on)
11171         (make_source_files_completion_list): Remove declaration.
11172         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11173         (ada_collect_symbol_completion_matches)
11174         (ada_add_global_exceptions): Remove declaration.
11175         * linespec.c (iterate_over_all_matching_symtabs): Use
11176         objfile_compunits.
11177         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11178         (class objfile_compunits): New.
11179         (ALL_COMPUNITS): Use objfile_compunits.
11180         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11181         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11182         objfile_compunits.
11183         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11184
11185 2019-01-09  Tom Tromey  <tom@tromey.com>
11186
11187         * symtab.c (search_symbols)
11188         (default_collect_symbol_completion_matches_break_on): Use
11189         objfile_msymbols.
11190         * ada-lang.c (ada_lookup_simple_minsym)
11191         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11192         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11193         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11194         objfile_msymbols.
11195         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11196         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11197         * objc-lang.c (find_methods): Use objfile_msymbols.
11198         (info_selectors_command, info_classes_command): Likewise.
11199         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11200         * objfiles.h (class objfile_msymbols): New.
11201         (ALL_OBJFILE_MSYMBOLS): Remove.
11202         (ALL_MSYMBOLS): Remove.
11203
11204 2019-01-09  Tom Tromey  <tom@tromey.com>
11205
11206         * common/next-iterator.h (next_adapter): Add Iterator template
11207         parameter.
11208         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11209         (class all_objfiles_safe): New.
11210         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11211         * objfiles.c (put_objfile_before): Update comment.
11212         (add_separate_debug_objfile): Likewise.
11213         (free_all_objfiles): Use all_objfiles_safe.
11214         (objfile_purge_solibs): Likewise.
11215
11216 2019-01-09  Tom Tromey  <tom@tromey.com>
11217
11218         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11219         (expand_symtab_containing_pc, lookup_static_symbol)
11220         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11221         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11222         all_objfiles.
11223         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11224         * breakpoint.c (create_overlay_event_breakpoint)
11225         (create_longjmp_master_breakpoint)
11226         (create_std_terminate_master_breakpoint)
11227         (create_exception_master_breakpoint): Use all_objfiles.
11228         * linux-thread-db.c (try_thread_db_load_from_pdir)
11229         (has_libpthread): Use all_objfiles.
11230         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11231         * linespec.c (iterate_over_all_matching_symtabs)
11232         (search_minsyms_for_name): Use all_objfiles.
11233         * maint.c (maintenance_info_sections): Use all_objfiles.
11234         * main.c (captured_main_1): Use all_objfiles.
11235         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11236         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11237         * guile/scm-pretty-print.c
11238         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11239         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11240         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11241         (maintenance_print_msymbols): Use all_objfiles.
11242         * source.c (select_source_symtab): Use all_objfiles.
11243         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11244         * symfile.c (remove_symbol_file_command)
11245         (expand_symtabs_matching, map_symbol_filenames): Use
11246         all_objfiles.
11247         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11248         all_objfiles.
11249         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11250         * objc-lang.c (find_methods): Use all_objfiles.
11251         * objfiles.c (have_partial_symbols, have_full_symbols)
11252         (have_minimal_symbols, qsort_cmp)
11253         (default_iterate_over_objfiles_in_search_order): Use
11254         all_objfiles.
11255         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11256         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11257         (maintenance_check_psymtabs): Use all_objfiles.
11258         (ALL_PSYMTABS): Remove.
11259         * compile/compile-object-run.c (do_module_cleanup): Use
11260         all_objfiles.
11261         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11262         * cp-support.c (add_symbol_overload_list_qualified): Use
11263         all_objfiles.
11264         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11265         Use all_objfiles.
11266         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11267         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11268         all_objfiles.
11269         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11270         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11271         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11272         Uses all_objfiles.
11273         * solib.c (solib_read_symbols): Use all_objfiles
11274
11275 2019-01-09  Tom Tromey  <tom@tromey.com>
11276
11277         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11278         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11279         all_objfiles.
11280         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11281         * symmisc.c (print_symbol_bcache_statistics)
11282         (print_objfile_statistics, maintenance_print_objfiles)
11283         (maintenance_info_symtabs, maintenance_check_symtabs)
11284         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11285         all_objfiles.
11286         * source.c (forget_cached_source_info): Use all_objfiles.
11287         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11288         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11289         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11290         * objfiles.c (update_section_map): Use all_objfiles.
11291         (shared_objfile_contains_address_p): Likewise.
11292         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11293         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11294
11295 2019-01-09  Tom Tromey  <tom@tromey.com>
11296
11297         * common/next-iterator.h: New file.
11298         * objfiles.h (class all_objfiles): New.
11299         (struct objfile_iterator): New.
11300
11301 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11302
11303         * NEWS: Move the description of the changed "frame", "select-frame",
11304          and "info frame" commands to the Changed commands section.
11305
11306 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11307
11308         * gdbtypes.c (check_stub_method_group): Remove handling of old
11309         mangling schemes.
11310         * linespec.c (find_methods): Likewise.
11311         * stabsread.c (read_member_functions): Likewise.
11312         * valops.c (search_struct_method): Likewise.
11313         (value_struct_elt_for_reference): Likewise.
11314         * NEWS: Mention this change.
11315
11316 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11317
11318         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11319         print_source_lines.
11320         * source.c (print_source_lines_base): Update line number check.
11321         (print_source_lines): New function.
11322         (source_lines_range::source_lines_range): New function.
11323         * source.h (class source_lines_range): New class.
11324         (print_source_lines): New declaration.
11325
11326 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11327
11328         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11329
11330 2019-01-08  Tom Tromey  <tom@tromey.com>
11331             Simon Marchi  <simon.marchi@ericsson.com>
11332
11333         PR gdb/24060
11334         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11335         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11336         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11337         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11338         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11339         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11340
11341 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11342
11343         * source.c (select_source_symtab): Move header comment to
11344         declaration in source.h.
11345         (forget_cached_source_info_for_objfile): Likewise.
11346         (forget_cached_source_info): Likewise.
11347         (identify_source_line): Likewise.
11348         * source.h (identify_source_line): Move declaration from symtab.h
11349         and add comment from source.c
11350         (print_source_lines): Likewise.
11351         (forget_cached_source_info_for_objfile): Likewise.
11352         (forget_cached_source_info): Likewise.
11353         (select_source_symtab): Likewise.
11354         (enum print_source_lines_flag): Move definition from symtab.h.
11355         * symtab.h (identify_source_line): Move declaration to source.h.
11356         (print_source_lines): Likewise.
11357         (forget_cached_source_info_for_objfile): Likewise.
11358         (forget_cached_source_info): Likewise.
11359         (select_source_symtab): Likewise.
11360         (enum print_source_lines_flag): Move definition to source.h.
11361         * tui/tui-hooks.c: Add 'source.h' include.
11362
11363 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11364
11365         * source.c (print_source_lines_base): Handle requests to print
11366         reverse line number sequences, and guard against empty lines
11367         string.
11368
11369 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11370
11371         * source.c (print_source_lines_base): Fix skip of '\r' if next
11372         character is '\n'.
11373
11374 2019-01-06  Tom Tromey  <tom@tromey.com>
11375
11376         * c-exp.y (struct c_parse_state) <macro_original_text,
11377         expansion_obstack>: New member.
11378         (macro_original_text, expansion_obstack): Remove globals.
11379         (scan_macro_expansion, scanning_macro_expansion)
11380         (finished_macro_expansion): Update.
11381         (scan_macro_cleanup): Remove.
11382         (yylex, c_parse): Update.
11383
11384 2019-01-06  Tom Tromey  <tom@tromey.com>
11385
11386         * c-exp.y (struct c_parse_state) <strings>: New member.
11387         (operator_stoken): Update.
11388
11389 2019-01-06  Tom Tromey  <tom@tromey.com>
11390
11391         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11392         (union type_stack_elt) <typelist_val>: Now a pointer to
11393         std::vector.
11394         (type_stack_cleanup): Don't declare.
11395         (push_typelist): Update.
11396         * parse.c (pop_typelist): Return a std::vector.
11397         (push_typelist): Take a std::vector.
11398         (follow_types): Update.  Do not free args.
11399         (type_stack_cleanup): Remove.
11400         * c-exp.y (struct c_parse_state): New.
11401         (cpstate): New global.
11402         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11403         (nonempty_typelist): Update.
11404         (func_mod): Create a new vector.
11405         (c_parse): Create a c_parse_state.
11406         (check_parameter_typelist): Do not delete params.
11407         (function_method): Update.  Do not delete type_list.
11408
11409 2019-01-06  Tom Tromey  <tom@tromey.com>
11410
11411         PR gdb/28155:
11412         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11413         check_typedef.
11414         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11415         (print_return_value): Likewise.
11416
11417 2019-01-05  Tom Tromey  <tom@tromey.com>
11418
11419         * contrib/cleanup_check.py: Remove.
11420         * contrib/gcc-with-excheck: Remove.
11421         * contrib/exsummary.py: Remove.
11422         * contrib/excheck.py: Remove.
11423
11424 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11425
11426         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11427         NULL. Initialize tpprev to NULL instead of assigning it
11428         to NULL on the next statement.
11429         * windows-nat.c (windows_delete_thread): Remove check for
11430         main_thread_id before printing thread exit notifications.
11431         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11432         Remove thread ID check against main_thread_id.
11433         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11434         windows_delete_thread.
11435         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11436
11437 2019-01-04  Tom Tromey  <tom@tromey.com>
11438
11439         * compile/compile.c (_initialize_compile): Use upper case for
11440         metasyntactic variables.
11441         * symmisc.c (_initialize_symmisc): Use upper case for
11442         metasyntactic variables.
11443         * psymtab.c (_initialize_psymtab): Use upper case for
11444         metasyntactic variables.
11445         * demangle.c (demangle_command): Use upper case for metasyntactic
11446         variables.
11447         (_initialize_demangler): Likewise.
11448         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11449         variables.
11450
11451 2019-01-03  Tom Tromey  <tom@tromey.com>
11452
11453         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11454
11455 2019-01-03  Tom Tromey  <tom@tromey.com>
11456
11457         * python/py-symtab.c (salpy_str): Update.
11458         (struct salpy_sal_object) <symtab>: Now a PyObject.
11459         (salpy_dealloc): Update.
11460         (del_objfile_sal): Use gdbpy_ref.
11461
11462 2019-01-03  Tom Tromey  <tom@tromey.com>
11463
11464         * python/py-type.c (convert_field): Use new_reference.  Return
11465         gdbpy_ref.
11466         (make_fielditem): Return gdbpy_ref.
11467         (typy_fields): Update.
11468         (typy_getitem): Update.
11469         (field_name): Return gdbpy_ref.  Use new_reference.
11470         (typy_iterator_iternext): Update.
11471
11472 2019-01-03  Tom Tromey  <tom@tromey.com>
11473
11474         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11475
11476 2019-01-03  Tom Tromey  <tom@tromey.com>
11477
11478         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11479         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11480         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11481         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11482         (pspy_set_type_printers): Likewise.
11483         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11484         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11485         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11486         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11487         (objfpy_set_type_printers): Likewise.
11488
11489 2019-01-03  Tom Tromey  <tom@tromey.com>
11490
11491         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11492         (gdbpy_print_stack): Use gdbpy_err_fetch.
11493         * python/python-internal.h (class gdbpy_err_fetch): New class.
11494         (class gdbpy_enter) <m_error_type, m_error_value,
11495         m_error_traceback>: Remove.
11496         <m_error>: New member.
11497         (gdbpy_exception_to_string): Don't declare.
11498         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11499         * python/py-value.c (convert_value_from_python): Use
11500         gdbpy_err_fetch.
11501         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11502         gdbpy_exception_to_string.
11503         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11504         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11505         gdbpy_err_fetch.
11506
11507 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11508
11509         * linux-nat.c (delete_lwp_cleanup): Delete.
11510         (struct lwp_deleter): New struct.
11511         (lwp_info_up): New typedef.
11512         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11513         lwp_info_up.
11514
11515 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * linux-fork.c (class scoped_switch_fork_info): New class.
11518         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11519
11520 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11521
11522         * valops.c (find_overload_match): Remove use of null_cleanup, and
11523         calls to do_cleanups.
11524
11525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11526
11527         * compile/compile-cplus-types.c
11528         (compile_cplus_instance::decl_name): Handle changes to
11529         cp_func_name.
11530         * cp-support.c (cp_func_name): Update header comment, update
11531         return type.
11532         * cp-support.h (cp_func_name): Update return type in declaration.
11533         * valops.c (find_overload_match): Move temp_func local to top
11534         level of function and change its type.  Use temp_func to hold and
11535         delete temporary string obtained from cp_func_name.
11536
11537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11538
11539         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11540         gdb::char_vector, remove cleanup, and update uses of `msg`.
11541
11542 2019-01-03  Jim Wilson  <jimw@sifive.com>
11543
11544         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11545
11546 2019-01-02  Tom Tromey  <tom@tromey.com>
11547
11548         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11549         (tdesc_parse_xml): Remove cleanups.
11550         * target-descriptions.h (make_cleanup_free_target_description):
11551         Don't declare.
11552         (target_desc_deleter): New struct.
11553         (target_desc_up): New typedef.
11554         * target-descriptions.c (target_desc_deleter::operator()): Rename
11555         from free_target_description.
11556         (make_cleanup_free_target_description): Remove.
11557
11558 2019-01-02  Tom Tromey  <tom@tromey.com>
11559
11560         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11561         constructor, destructor.
11562         (linespec_parser): Remove typedef.
11563         (~linespec_parser): Rename from linespec_parser_delete.
11564         (linespec_lex_to_end, linespec_complete_label)
11565         (linespec_complete): Update.
11566         (decode_line_full): Remove cleanups.
11567         (decode_line_1): Update.
11568
11569 2019-01-02  Tom Tromey  <tom@tromey.com>
11570
11571         * python/python-internal.h (inferior_to_inferior_object): Change
11572         return type.
11573         * python/py-exitedevent.c (create_exited_event_object): Update.
11574         * python/py-inferior.c (inferior_to_inferior_object): Return
11575         gdbpy_ref.
11576         (python_new_inferior, python_inferior_deleted)
11577         (thread_to_thread_object, delete_thread_object)
11578         (build_inferior_list, gdbpy_selected_inferior): Update.
11579         * python/py-infthread.c (create_thread_object): Update.  Also fail
11580         if inferior_to_inferior_object fails.
11581
11582 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11583
11584         * inferior.h (class inferior) <displaced_step_state>: New field.
11585         * infrun.h (struct displaced_step_state): Move here from
11586         infrun.c.  Initialize fields, add constructor.
11587         <inf>: Remove field.
11588         <reset>: New method.
11589         * infrun.c (struct displaced_step_inferior_state): Move to
11590         infrun.h.
11591         (displaced_step_inferior_states): Remove.
11592         (get_displaced_stepping_state): Adust.
11593         (displaced_step_in_progress_any_inferior): Adjust.
11594         (displaced_step_in_progress_thread): Adjust.
11595         (displaced_step_in_progress): Adjust.
11596         (add_displaced_stepping_state): Remove.
11597         (get_displaced_step_closure_by_addr): Adjust.
11598         (remove_displaced_stepping_state): Remove.
11599         (infrun_inferior_exit): Call displaced_step_state.reset.
11600         (use_displaced_stepping): Don't check for NULL.
11601         (displaced_step_prepare_throw): Call
11602         get_displaced_stepping_state.
11603         (displaced_step_fixup): Don't check for NULL.
11604         (prepare_for_detach): Don't check for NULL.
11605
11606 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11607
11608         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11609          in case of call that did not complete.
11610
11611 2019-01-02  Andrey Utkin  <autkin@undo.io>
11612
11613         * symfile.c (find_separate_debug_file): Fix search of debug files for
11614         remote debuggee.
11615
11616 2019-01-02  Tom Tromey  <tom@tromey.com>
11617
11618         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11619         indentation.
11620         * python/py-frame.c (frapy_older): Remove cast.
11621         (frapy_newer): Likewise.
11622         * python/py-breakpoint.c (local_setattro): Remove cast.
11623         * python/py-arch.c (archpy_name): Remove local variable.
11624         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11625
11626 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11627
11628         * unittests/basic_string_view/element_access/char/empty.cc:
11629         Fix year range in copyright header.
11630
11631 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11632
11633         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11634         Delete.
11635         <operator==>: Update with for removed field.
11636         <hash>: Likewise.
11637         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11638         <isa_features>: ...this.
11639         <abi_features>: New field.
11640         (riscv_isa_flen): Update comment.
11641         (riscv_abi_xlen): New declaration.
11642         (riscv_abi_flen): New declaration.
11643         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11644         isa_features.
11645         (riscv_abi_xlen): New function.
11646         (riscv_isa_flen): Update to get answer from isa_features.
11647         (riscv_abi_flen): New function.
11648         (riscv_has_fp_abi): Update to get answer from abi_features.
11649         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11650         xlen and flen.
11651         (riscv_call_info) <xlen, flen>: Update comment.
11652         (riscv_call_arg_struct): Remove invalid assertions
11653         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11654         is removed.
11655         (riscv_gdbarch_init): Gather isa features and abi features
11656         separately, ensure both match on the gdbarch when reusing an old
11657         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11658         a target with 64-bit float hardware.
11659
11660 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11661
11662         * source.c (search_command_helper): Stop reverse search
11663         when line 1 has been searched.
11664
11665 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11666
11667         * record-full.c (record_full_base_target::close): Rewrite
11668         record_full_core_buf_list free logic.
11669
11670 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11671
11672         * break-catch-syscall.c (print_one_catch_syscall): xfree
11673         the last text.
11674
11675 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11676
11677         * top.c (print_gdb_version): Update Copyright year in version
11678         message.
11679
11680 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11681
11682         Update copyright year range in all GDB files.
11683
11684 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11685
11686         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11687
11688 For older changes see ChangeLog-2018.
11689 \f
11690 Local Variables:
11691 mode: change-log
11692 left-margin: 8
11693 fill-column: 74
11694 version-control: never
11695 coding: utf-8
11696 End:
11697