gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
   4         * tui/tui-wingeneral.c (box_win): Change type of win_info.
   5         (box_win): Update.
   6         (tui_gen_win_info::make_window): Rename from tui_make_window.
   7         (tui_win_info::make_window): New method.
   8         (tui_gen_win_info::make_visible): Update.
   9         * tui/tui-source.c (tui_source_window::set_contents): Update.
  10         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
  11         (tui_data_window::display_registers_from): Update.
  12         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  13         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
  14         Declare.
  15         <can_box>: Remove.
  16         <title>: Remove.
  17         (struct tui_win_info) <make_window>: Declare.
  18         <can_box>: Now virtual.
  19         <title>: New member.
  20         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
  21         * tui/tui-command.c (tui_cmd_window::resize): Update.
  22
  23 2019-08-20  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
  26         * tui/tui-regs.c (tui_data_window::show_registers): Update.
  27         (tui_data_window::check_register_values): Update.
  28
  29 2019-08-20  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.h (struct tui_data_window): Use
  32         DISABLE_COPY_AND_ASSIGN.
  33         <regs_content>: Change type, removing unique_ptr.
  34         <tui_data_window>: Add move constructor.
  35         * tui/tui-regs.c (tui_data_window::show_registers)
  36         (tui_data_window::show_register_group)
  37         (tui_data_window::display_registers_from)
  38         (tui_data_window::display_registers_from)
  39         (tui_data_window::first_data_item_displayed)
  40         (tui_data_window::delete_data_content_windows)
  41         (tui_data_window::rerender, tui_data_window::refresh_window)
  42         (tui_data_window::check_register_values): Update.
  43
  44 2019-08-20  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  47         show_register_group>: Declare.
  48         (tui_show_register_group): Don't declare.
  49         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  50         tui_show_registers.
  51         (tui_data_window::show_register_group): Rename from
  52         tui_show_register_group.
  53         (tui_data_window::check_register_values, tui_reg_command):
  54         Update.
  55         * tui/tui-layout.c (tui_set_layout): Update.
  56
  57 2019-08-20  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  60         Declare.
  61         (tui_check_register_values): Don't declare.
  62         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  63         from tui_check_register_values.
  64         * tui/tui-hooks.c (tui_register_changed): Update.
  65
  66 2019-08-20  Tom Tromey  <tom@tromey.com>
  67
  68         * tui/tui-regs.c (tui_reg_layout): Move later.
  69         (tui_show_registers): Don't enable TUI mode or change layout.
  70
  71 2019-08-20  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-regs.h (struct tui_data_item_window)
  74         <~tui_data_item_window>: Remove.
  75         <content>: Now a unique_xmalloc_ptr.
  76         * tui/tui-regs.c (tui_register_format): Return a
  77         unique_xmalloc_ptr.
  78         (tui_get_register): Update.
  79         (~tui_data_item_window): Remove.
  80         (tui_data_window::display_registers_from, tui_display_register):
  81         Update.
  82         * tui/tui-io.h (tui_expand_tabs): Update.
  83         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  84         Remove "col" parameter.
  85
  86 2019-08-20  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  89         field.
  90         * tui/tui-regs.c (~tui_data_item_window): Update.
  91
  92 2019-08-20  Tom Tromey  <tom@tromey.com>
  93
  94         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  95         earlier.
  96
  97 2019-08-20  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 100
 101 2019-08-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-source.h (struct tui_source_window): Update.
 104         * tui/tui-regs.c (tui_show_registers): Update.
 105         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 106         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 107         (NO_REGS_STRING): Remove defines.
 108
 109 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 110
 111         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 112         unnecessary thread walk if remote doesn't support the packet.
 113
 114 2019-08-19  Tom Tromey  <tromey@adacore.com>
 115
 116         * python/py-value.c (value_has_field): Fix indentation.
 117
 118 2019-08-19  Tom Tromey  <tromey@adacore.com>
 119
 120         * printcmd.c (do_one_display, info_display_command): Update.
 121         * block.h (contained_in): Return bool.  Add allow_nested
 122         parameter.
 123         * block.c (contained_in): Return bool.  Add allow_nested
 124         parameter.
 125
 126 2019-08-19  Tom Tromey  <tom@tromey.com>
 127
 128         * configure: Rebuild.
 129         * configure.ac: Disallow the combination of -static-libstdc++ and
 130         source highlight.
 131         * source-cache.c (get_language_name): Handle rust.
 132         (source_cache::get_source_lines): Ignore highlighting exceptions.
 133
 134 2019-08-16  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 137         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 138         (struct tui_source_window_base) <make_visible, refresh_window,
 139         resize>: Remove methods.
 140         <execution_info>: Remove field.
 141         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 142         (tui_show_source_line, tui_source_window_base)
 143         (~tui_source_window_base): Update.
 144         (tui_source_window_base::resize)
 145         (tui_source_window_base::make_visible)
 146         (tui_source_window_base::refresh_window): Remove.
 147         (tui_source_window_base::update_exec_info): Update.
 148         * tui/tui-source.c (tui_source_window::set_contents): Update.
 149         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 150
 151 2019-08-16  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 154         deprecated_query_hook.
 155
 156 2019-08-16  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 159         (tui_update_source_windows_with_line): Update.
 160         * tui/tui-source.h (struct tui_source_window)
 161         <show_symtab_source>: Declare.
 162         (tui_show_symtab_source): Don't declare.
 163         * tui/tui-source.c (tui_show_symtab_source): Rename from
 164         tui_show_symtab_source.
 165
 166 2019-08-16  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-winsource.h (struct tui_source_window_base)
 169         <set_contents>: Declare.
 170         * tui/tui-winsource.c
 171         (tui_source_window_base::update_source_window_as_is): Update.
 172         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 173         Declare.
 174         (tui_set_source_content): Don't declare.
 175         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 176         tui_set_source_content.
 177         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 178         Declare.
 179         (tui_set_disassem_content): Don't declare.
 180         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 181         tui_set_disassem_content.
 182
 183 2019-08-16  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-winsource.h (struct tui_source_window_base)
 186         <update_breakpoint_info>: Declare.
 187         (tui_update_breakpoint_info): Don't declare.
 188         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 189         (tui_update_all_breakpoint_info): Update.
 190         (tui_source_window_base::update_breakpoint_info): Rename from
 191         tui_update_breakpoint_info.
 192         (tui_source_window_base::update_exec_info): Update.
 193
 194 2019-08-16  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.h (struct tui_source_window_base)
 197         <update_source_window>: Declare.
 198         (tui_update_source_window): Don't declare.
 199         * tui/tui-winsource.c
 200         (tui_source_window_base::update_source_window): Rename from
 201         tui_update_source_window.
 202         (tui_source_window_base::rerender): Update.
 203         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 204         * tui/tui-disasm.c (tui_show_disassem)
 205         (tui_show_disassem_and_update_source)
 206         (tui_disasm_window::maybe_update): Update.
 207
 208 2019-08-16  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-winsource.h (struct tui_source_window_base)
 211         <update_source_window_as_is>: Declare.
 212         (tui_update_source_window_as_is): Don't declare.
 213         * tui/tui-winsource.c (tui_update_source_window): Update
 214         (tui_source_window_base::update_source_window_as_is): Rename from
 215         tui_update_source_window_as_is.
 216         (tui_source_window_base::refill): Update.
 217         * tui/tui-source.c (tui_show_symtab_source): Update.
 218         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 219         Update.
 220
 221 2019-08-16  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-winsource.h (tui_update_source_window)
 224         (tui_update_source_window_as_is): Remove "noerror" parameter.
 225         * tui/tui-winsource.c (tui_update_source_window)
 226         (tui_update_source_window_as_is): Remove "noerror" parameter.
 227         (tui_update_source_windows_with_addr)
 228         (tui_update_source_windows_with_line)
 229         (tui_source_window_base::rerender)
 230         (tui_source_window_base::refill): Update.
 231         * tui/tui-source.h (tui_set_source_content)
 232         (tui_show_symtab_source): Remove "noerror" parameter.
 233         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 234         parameter.
 235         (tui_show_symtab_source): Likewise.
 236         (tui_source_window::maybe_update): Update.
 237         * tui/tui-disasm.c (tui_show_disassem)
 238         (tui_show_disassem_and_update_source)
 239         (tui_disasm_window::do_scroll_vertical)
 240         (tui_disasm_window::maybe_update): Update.
 241
 242 2019-08-16  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui.c (tui_is_window_visible): Update.
 245         * tui/tui-wingeneral.c (tui_make_window)
 246         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 247         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 248         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 249         (tui_set_win_height_command, parse_scrolling_args): Update.
 250         * tui/tui-source.c (tui_source_window::style_changed): Update.
 251         * tui/tui-regs.c (tui_show_registers)
 252         (tui_data_window::first_data_item_displayed)
 253         (tui_data_window::delete_data_content_windows)
 254         (tui_check_register_values, tui_reg_command): Update.
 255         * tui/tui-disasm.c (tui_show_disassem): Update.
 256         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 257         method.
 258         <is_visible>: Remove field.
 259         * tui/tui-data.c (tui_next_win, tui_prev_win)
 260         (tui_delete_invisible_windows): Update.
 261
 262 2019-08-16  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-winsource.h (struct tui_source_window_base)
 265         <m_has_locator>: Remove.
 266         * tui/tui-layout.c (show_source_disasm_command, show_data)
 267         (show_source_or_disasm_and_command): Update.
 268
 269 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 270
 271         * NEWS (Other MI changes): New subsection.
 272         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 273         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 274         * arch-utils.c (default_get_pc_address_flags): New function.
 275         * arch-utils.h (default_get_pc_address_flags): New declaration.
 276         * gdbarch.sh: Add get_pc_address_flags.
 277         * gdbarch.c: Regenerate.
 278         * gdbarch.h: Likewise.
 279         * stack.c (print_pc): New function.
 280         (print_frame_info) (print_frame): Call print_pc.
 281
 282 2019-08-16  Tom de Vries  <tdevries@suse.de>
 283
 284         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 285         print_objfile_section_info.
 286
 287 2019-08-15  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 290         calling update_cmdwin_start_line.
 291         * tui/tui-winsource.h (struct tui_source_window_base)
 292         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 293         <rerender>: Declare.
 294         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 295         Call rerender.
 296         (tui_source_window_base::set_new_height): Remove.
 297         (tui_source_window_base::rerender): Rename from
 298         do_make_visible_with_new_height.
 299         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 300         resize method.
 301         (tui_win_info::make_invisible_and_set_new_height)
 302         (tui_win_info::make_visible_with_new_height): Remove.
 303         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 304         Declare.
 305         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 306         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 307         do_make_visible_with_new_height>: Don't declare.
 308         <rerender>: Declare.
 309         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 310         set_new_height.
 311         (tui_data_window::do_make_visible_with_new_height): Remove.
 312         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 313         call tui_show_locator_content.
 314         (tui_gen_win_info::resize): Call rerender.
 315         (show_source_or_disasm_and_command): Don't call
 316         tui_show_locator_content.
 317         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 318         method.
 319         (struct tui_win_info) <rerender>: Declare.
 320         <set_new_height, make_invisible_and_set_new_height,
 321         make_visible_with_new_height>: Don't declare.
 322         * tui/tui-data.c (tui_win_list::rerender): New method.
 323         * tui/tui-command.h (struct tui_cmd_window)
 324         <do_make_visible_with_new_height>: Don't declare.
 325         * tui/tui-command.c
 326         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 327
 328 2019-08-15  Tom Tromey  <tromey@adacore.com>
 329
 330         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 331         * ada-lang.c (ada_enum_name): Likewise.
 332
 333 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 334
 335         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 336         leading underscore.
 337         (GdbOutputErrorFile): Likewise.
 338         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 339         accordingly.
 340         (execute_unwinders): Rename to have a leading underscore.
 341         (auto_load_packages): Likewise.
 342         (global scope): Adjust call to auto_load_packages accordingly.
 343         (GdbSetPythonDirectory): Likewise.
 344         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 345         instead of execute_unwinders.
 346
 347 2019-08-15  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 350         (show_data): Don't change window visibility.
 351         (tui_gen_win_info::resize): Remove special case for command
 352         window.  Use wresize, when available.
 353         (show_source_or_disasm_and_command): Don't change window
 354         visibility.
 355         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 356         <make_visible>: New method.
 357         * tui/tui-command.c (tui_cmd_window::resize): New method.
 358
 359 2019-08-15  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 362         (struct tui_source_windows): New.
 363         * tui/tui-winsource.c (tui_display_main): Update.
 364         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 365         (new_height_ok, parse_scrolling_args): Update.
 366         * tui/tui-layout.c (show_layout, show_data): Update.
 367         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 368         (tui_add_to_source_windows): Don't declare.
 369         * tui/tui-data.c (source_windows, tui_source_windows)
 370         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 371
 372 2019-08-15  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 375         Rename from reset.
 376         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 377         * tui/tui-layout.c (show_source_disasm_command, show_data):
 378         Update.
 379         (tui_gen_win_info::resize): Rename.
 380         (show_source_or_disasm_and_command): Update.
 381         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 382         reset.
 383
 384 2019-08-15  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 387         * tui/tui-interp.c (tui_interp::init): Don't call
 388         tui_initialize_static_data.
 389         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 390
 391 2019-08-15  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 394         examine tui_win_list.
 395
 396 2019-08-15  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 399         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 400         tui_clear_source_content.
 401         (tui_clear_source_content): Remove.
 402         (tui_source_window_base::do_erase_source_content): Hoist call to
 403         content.clear().
 404         * tui/tui-stack.c (tui_show_frame_info): Don't call
 405         tui_clear_source_content.
 406
 407 2019-08-15  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-winsource.h (struct tui_source_window_base)
 410         <do_erase_source_content>: New method.
 411         <erase_source_content>: New method.
 412         (tui_erase_source_content): Don't declare.
 413         * tui/tui-winsource.c (tui_clear_source_content): Update.
 414         (tui_source_window_base::do_erase_source_content): Rename from
 415         tui_erase_source_content.
 416         (tui_source_window_base::show_source_content): Update.
 417         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 418         * tui/tui-source.h (struct tui_source_window)
 419         <erase_source_content>: New method.
 420         * tui/tui-disasm.h (struct tui_disasm_window)
 421         <erase_source_content>: New method.
 422
 423 2019-08-15  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 426         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 427         constructor.
 428         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 429         * tui/tui-source.c (tui_set_source_content): Update.
 430         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 431
 432 2019-08-15  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 435         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 436         tui-source.c.
 437         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 438         Declare.
 439         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 440         method.
 441         (tui_source_window::maybe_update): Update.
 442
 443 2019-08-15  Tom Tromey  <tom@tromey.com>
 444
 445         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 446         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 447         tui-disasm.c.
 448         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 449         Declare.
 450         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 451         method.
 452         (tui_disasm_window::maybe_update): Update.
 453
 454 2019-08-15  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-winsource.h (struct tui_source_window_base)
 457         <maybe_update>: Declare.
 458         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 459         method.
 460         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 461         Declare.
 462         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 463         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 464         Declare.
 465         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 466
 467 2019-08-15  Tom Tromey  <tom@tromey.com>
 468
 469         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 470
 471 2019-08-15  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-wingeneral.c: Include tui-stack.h.
 474         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 475         (struct tui_locator_window): Move from tui-data.h.
 476         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 477         (tui_initialize_static_data): Move from tui-data.c.
 478         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 479         (struct tui_locator_window): Move to tui-stack.c.
 480         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 481         (tui_initialize_static_data): Move to tui-stack.c.
 482
 483 2019-08-15  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-layout.c (show_source_disasm_command)
 486         (show_source_or_disasm_and_command): Use make_visible method, not
 487         tui_make_window.
 488         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 489         Remove.
 490
 491 2019-08-15  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-wingeneral.h (tui_make_window): Update.
 494         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 495         parameter.
 496         (tui_gen_win_info::make_visible): Update.
 497         * tui/tui-regs.c (tui_data_window::display_registers_from):
 498         Update.
 499         * tui/tui-layout.c (show_source_disasm_command)
 500         (show_source_or_disasm_and_command): Update.
 501         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 502         (enum tui_box): Remove.
 503         (struct tui_win_info) <can_box>: New method.
 504         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 505         method.
 506
 507 2019-08-15  Tom de Vries  <tdevries@suse.de>
 508
 509         * linux-nat-trad.c: Include gdbarch.h.
 510
 511 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 512
 513         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 514         register sizes.
 515
 516 2019-08-14  Tom Tromey  <tromey@adacore.com>
 517
 518         * darwin-nat.c: Include gdbarch.h.
 519         * darwin-nat-info.c: Include gdbarch.h.
 520
 521 2019-08-13  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 524         Remove.
 525         * tui/tui-data.c (tui_initialize_static_data): Update.
 526
 527 2019-08-13  Tom Tromey  <tom@tromey.com>
 528
 529         * tui/tui-winsource.h (struct tui_exec_info_window)
 530         <~tui_exec_info_window, maybe_allocate_content, get_content,
 531         m_content>: Remove.
 532         (struct tui_source_window_base) <set_exec_info_content,
 533         show_exec_info_content>: Don't declare.
 534         * tui/tui-winsource.c
 535         (tui_exec_info_window::maybe_allocate_content): Remove.
 536         (tui_source_window_base::update_exec_info): Rename from
 537         set_exec_info_content.
 538         (tui_source_window_base::show_exec_info_content)
 539         (tui_source_window_base::update_exec_info): Remove.
 540
 541 2019-08-13  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 544         declare.
 545         * tui/tui-winsource.c (tui_update_source_window_as_is)
 546         (tui_update_source_windows_with_addr, tui_erase_source_content):
 547         Update.
 548         (tui_clear_exec_info_content): Remove.
 549
 550 2019-08-13  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 553         declare.
 554         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 555         call tui_erase_exec_info_content.
 556         (tui_clear_exec_info_content): Rename from
 557         tui_erase_exec_info_content.
 558         (tui_clear_exec_info_content): Delete.
 559
 560 2019-08-13  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui-winsource.h (struct tui_source_window_base)
 563         <show_exec_info_content>: Declare.
 564         (tui_show_exec_info_content): Don't declare.
 565         * tui/tui-winsource.c
 566         (tui_source_window_base::show_exec_info_content): Rename from
 567         tui_show_exec_info_content.
 568         (tui_source_window_base::update_exec_info): Update.
 569
 570 2019-08-13  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 573         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 574         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 575         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 576         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 577         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 578         ... here.
 579
 580 2019-08-13  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-winsource.h (struct tui_source_window_base)
 583         <update_exec_info>: Declare.
 584         (tui_update_exec_info): Don't declare.
 585         * tui/tui-winsource.c (tui_update_source_window_as_is)
 586         (tui_source_window_base::refresh_all)
 587         (tui_update_all_breakpoint_info): Update.
 588         (tui_source_window_base::update_exec_info): Rename from
 589         tui_update_exec_info.
 590         * tui/tui-stack.c (tui_show_frame_info): Update.
 591
 592 2019-08-13  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.h (struct tui_source_window_base)
 595         <set_exec_info_content>: Declare.
 596         (tui_set_exec_info_content): Don't declare.
 597         * tui/tui-winsource.c
 598         (tui_source_window_base::set_exec_info_content): Rename from
 599         tui_set_exec_info_content.
 600         (tui_update_exec_info): Update.
 601
 602 2019-08-13  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-winsource.h (struct tui_source_window_base)
 605         <show_source_content>: Declare.
 606         (tui_show_source_content): Don't declare.
 607         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 608         (tui_source_window_base::show_source_content): Rename from
 609         tui_show_source_content.
 610         (tui_source_window_base::refresh_all): Update.
 611         * tui/tui-layout.c (show_source_disasm_command)
 612         (show_source_or_disasm_and_command): Update.
 613
 614 2019-08-13  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-winsource.c (tui_erase_source_content)
 617         (tui_show_source_content, tui_source_window_base::refresh_all):
 618         Update.
 619         * tui/tui-wingeneral.h
 620         (tui_check_and_display_highlight_if_needed): Don't declare.
 621         * tui/tui-wingeneral.c
 622         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 623         check_and_display_highlight_if_needed.
 624         * tui/tui-win.c (tui_rehighlight_all)
 625         (tui_win_info::make_visible_with_new_height): Update.
 626         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 627         (tui_data_window::erase_data_content)
 628         (tui_data_window::display_all_data): Update.
 629         * tui/tui-data.h (struct tui_win_info)
 630         <check_and_display_highlight_if_needed>: Declare.
 631
 632 2019-08-13  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-win.c (tui_resize_all): Call
 635         tui_delete_invisible_windows.
 636         * tui/tui-layout.c (show_layout): Call
 637         tui_delete_invisible_windows.
 638         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 639         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 640
 641 2019-08-13  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 644         tui_add_win_to_layout.
 645
 646 2019-08-13  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 649         * tui/tui-layout.c (tui_default_win_height): Now static.
 650
 651 2019-08-13  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 654         single switch.
 655         (show_source_disasm_command, show_source_or_disasm_and_command):
 656         Don't check current layout.
 657
 658 2019-08-13  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-wingeneral.c (make_all_visible): Remove.
 661         (tui_make_all_invisible): Simplify.
 662         * tui/tui-layout.c (tui_make_all_invisible): Move from
 663         tui-wingeneral.c; simplify.
 664         (show_layout): Hoist call to tui_make_all_invisible.
 665         (show_data): Don't call tui_make_all_invisible.
 666
 667 2019-08-13  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 670         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 671
 672 2019-08-13  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 675         tui-data.c.
 676         (show_source_disasm_command, show_data)
 677         (show_source_or_disasm_and_command): Don't use
 678         tui_set_current_layout_to.
 679         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 680         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 681         tui-layout.c.
 682         (tui_set_current_layout_to): Remove.
 683
 684 2019-08-13  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-layout.c (tui_set_layout): Update.
 687         * tui/tui-data.h (struct tui_layout_def): Remove.
 688         (tui_layout_def): Don't declare.
 689         * tui/tui-data.c (layout_def): Remove.
 690         (tui_layout_def): Remove.
 691
 692 2019-08-13  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-winsource.h (struct tui_source_window_base)
 695         <clear_detail>: No longer "override".
 696         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 697         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 698         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 699         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 700         Remove.
 701         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 702
 703 2019-08-13  Tom Tromey  <tromey@adacore.com>
 704
 705         * tracepoint.c: Don't include readline.h or history.h.
 706
 707 2019-08-12  Tom Tromey  <tom@tromey.com>
 708
 709         * configure: Rebuild.
 710         * configure.ac: Check for readline 7.
 711         * NEWS: Mention readline 7 requirement.
 712         * README: Update.
 713
 714 2019-08-12  Tom Tromey  <tom@tromey.com>
 715
 716         * mingw-hdep.c (gdb_select): Remove readline hack.
 717
 718 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 719
 720         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 721         when the function fails.
 722
 723 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 724
 725         * s390-tdep.c (s390_type_align): New function.
 726         (s390_gdbarch_init): Set it as type_align gdbarch method.
 727
 728 2019-08-09  Tom de Vries  <tdevries@suse.de>
 729
 730         PR gdb/24591
 731         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 732         pc_low with relocation offset.
 733
 734 2019-08-07  Tom Tromey  <tromey@adacore.com>
 735
 736         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 737         (print_frame_args): Update.
 738         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 739         Update.
 740         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 741         * frame.h (struct frame_arg): Add initializers.
 742         <error>: Now a unique_xmalloc_ptr.
 743
 744 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 745
 746         * NEWS: Expand the Pointer Authentication entry.
 747         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 748         (aarch64_frame_unmask_lr): ... to this.
 749         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 750         Call aarch64_frame_unmask_lr.
 751         * frame.c (struct frame_info): Add "masked" variable.
 752         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 753         (fprint_frame): Check for masked pc.
 754         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 755         declarations.
 756         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 757         * stack.c (print_frame): Check for masked pc.
 758
 759 2019-08-06  Tom Tromey  <tom@tromey.com>
 760
 761         * stabsread.c (patch_block_stabs, read_one_struct_field)
 762         (read_enum_type): Use obstack_strndup.
 763         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 764         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 765         * dwarf2read.c (guess_full_die_structure_name)
 766         (anonymous_struct_prefix): Use obstack_strndup.
 767         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 768         * c-exp.y (yylex): Use obstack_strndup.
 769         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 770         (write_var_or_type): Use obstack_strndup.
 771
 772 2019-08-06  Tom Tromey  <tom@tromey.com>
 773
 774         * symfile.c (reread_symbols): Use obstack_strdup.
 775         * stabsread.c (read_type): Use obstack_strdup.
 776         * gdb_obstack.h (obstack_strdup): New overload.
 777         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 778         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 779         (dwarf2_canonicalize_name): Use obstack_strdup.
 780         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 781         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 782         Use obstack_strdup.
 783
 784 2019-08-06  Tom Tromey  <tom@tromey.com>
 785
 786         * gdb_obstack.h (obstack_strdup): Define.
 787         * gdb_obstack.c (obstack_strdup): Don't define.
 788
 789 2019-08-06  Tom Tromey  <tom@tromey.com>
 790
 791         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 792         obstack_strdup.
 793         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 794         obstack_strdup.
 795         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 796         * stabsread.c (common_block_start): Use obstack_strdup.
 797         * objfiles.c (set_objfile_main_name, objfile): Use
 798         obstack_strdup.
 799         * namespace.c (add_using_directive): Use obstack_strdup.
 800         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 801         * jit.c (finalize_symtab): Use obstack_strdup.
 802         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 803         (guess_partial_die_structure_name, partial_die_info::fixup)
 804         (dwarf2_name): Use obstack_strdup.
 805         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 806         obstack_strdup.
 807         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 808         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 809         obstack_strdup.
 810         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 811
 812 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 813
 814         * unittests/help-doc-selftests.c: New file.
 815         * Makefile.in: Add the new file.
 816
 817 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 818
 819         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 820         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 821         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 822         the trailing '.' is not output, and the first character is uppercased.
 823         (print_help_for_command): Update call to print_doc_line.
 824         (print_doc_of_command): Likewise.
 825         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 826         * cli/cli-option.c (append_indented_doc): Do not append newline.
 827         (build_help_option): Append newline after first appended_indented_doc
 828         only if a second call is done.
 829         (build_help): Append 2 new lines before each option, except the first
 830         one.
 831         * compile/compile.c (_initialize_compile): Add new lines after
 832         %OPTIONS%, when not at the end of the help.
 833         Change help doc or code
 834         producing the help doc to respect the invariants.
 835         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 836         Also removed the new line after 'Options:', as all other commands
 837         do not put an empty line between 'Options:' and the first option.
 838         * printcmd.c (_initialize_printcmd): Likewise.
 839         * stack.c (_initialize_stack): Likewise.
 840         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 841         incorrectly telling COMMAND is optional.
 842         * ada-lang.c (_initialize_ada_language): Change help doc or code
 843         producing the help doc to respect the invariants.
 844         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 845         * breakpoint.c (_initialize_breakpoint): Likewise.
 846         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 847         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 848         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 849         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 850         _initialize_cli_style): Likewise.
 851         * corelow.c (core_target_info): Likewise.
 852         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 853         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 854         * filesystem.c (_initialize_filesystem): Likewise.
 855         * frame.c (_initialize_frame): Likewise.
 856         * gnu-nat.c (add_task_commands): Likewise.
 857         * infcall.c (_initialize_infcall): Likewise.
 858         * infcmd.c (_initialize_infcmd): Likewise.
 859         * interps.c (_initialize_interpreter): Likewise.
 860         * language.c (_initialize_language): Likewise.
 861         * linux-fork.c (_initialize_linux_fork): Likewise.
 862         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 863         * maint.c (_initialize_maint_cmds): Likewise.
 864         * memattr.c (_initialize_mem): Likewise.
 865         * printcmd.c (_initialize_printcmd): Likewise.
 866         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 867         _RegEx): Likewise.
 868         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 869         * record-btrace.c (_initialize_record_btrace): Likewise.
 870         * record-full.c (_initialize_record_full): Likewise.
 871         * record.c (_initialize_record): Likewise.
 872         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 873         * regcache.c (_initialize_regcache): Likewise.
 874         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 875         _initialize_remote): Likewise.
 876         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 877         * serial.c (_initialize_serial): Likewise.
 878         * skip.c (_initialize_step_skip): Likewise.
 879         * source.c (_initialize_source): Likewise.
 880         * stack.c (_initialize_stack): Likewise.
 881         * symfile.c (_initialize_symfile): Likewise.
 882         * symtab.c (_initialize_symtab): Likewise.
 883         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 884         * top.c (init_main): Likewise.
 885         * tracefile-tfile.c (tfile_target_info): Likewise.
 886         * tracepoint.c (_initialize_tracepoint): Likewise.
 887         * tui/tui-win.c (_initialize_tui_win): Likewise.
 888         * utils.c (add_internal_problem_command): Likewise.
 889         * valprint.c (value_print_option_defs): Likewise.
 890
 891 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 892
 893         PR build/24886
 894         * configure.ac: Drop enable-libmcheck support.
 895         * configure, config.in: Rebuild.
 896         * libmcheck.m4: Remove.
 897         * acinclude.m4: Don't include it.
 898         * Makefile.in: Don't distribute it.
 899         * top.c (print_gdb_configuration): Don't mention it.
 900
 901 2019-08-06  Tom Tromey  <tom@tromey.com>
 902
 903         * utils.c (set_output_style): Sometimes pass stream to
 904         emit_style_escape.
 905         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 906         * record-btrace.c (btrace_insn_history): Update.
 907         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 908         method.
 909         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 910         Update initializers.
 911         <m_uiout>: New field.
 912         <m_di>: Move lower.
 913         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 914         Remove "uiout" parameter.
 915         (dump_insns): Update.
 916         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 917         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 918
 919 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 920
 921         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 922         (error_in_psymtab_expansion): Likewise.
 923         (lookup_symbol_via_quick_fns): Likewise.
 924         (basic_lookup_transparent_type_quick): Likewise.
 925         (basic_lookup_transparent_type_1): Likewise.
 926
 927 2019-08-06  Tom Tromey  <tromey@adacore.com>
 928
 929         * source.c (last_source_error): Now bool.
 930         (print_source_lines_base): Make "noprint" bool.  Only open
 931         source file when last_source_visited changes.
 932
 933 2019-08-06  Tom Tromey  <tromey@adacore.com>
 934
 935         * annotate.c (annotate_source_line): Use g_source_cache.
 936         * source-cache.c (source_cache::get_plain_source_lines): Change
 937         parameters.  Populate m_offset_cache.
 938         (source_cache::ensure): New method.
 939         (source_cache::get_line_charpos): New method.
 940         (extract_lines): Move lower.  Change parameters.
 941         (source_cache::get_source_lines): Move lower.
 942         * source-cache.h (class source_cache): Update comment.
 943         <get_line_charpos>: New method.
 944         <get_source_lines>: Update comment.
 945         <clear>: Clear m_offset_cache.
 946         <get_plain_source_lines>: Change parameters.
 947         <ensure>: New method
 948         <m_offset_cache>: New member.
 949         * source.c (forget_cached_source_info_for_objfile): Update.
 950         (info_source_command): Use g_source_cache.
 951         (find_source_lines, open_source_file_with_line_charpos): Remove.
 952         (print_source_lines_base, search_command_helper): Use g_source_cache.
 953         * source.h (open_source_file_with_line_charpos): Don't declare.
 954         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 955         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 956         Use g_source_cache.
 957
 958 2019-08-06  Tom Tromey  <tromey@adacore.com>
 959
 960         * source-cache.c (source_cache::get_plain_source_lines):
 961         Remove "first_line" and "last_line" parameters.
 962         (source_cache::get_source_lines): Cache plain text.
 963         * source-cache.h (class source_cache)
 964         <get_plain_source_lines>: Update.
 965
 966 2019-08-06  Tom Tromey  <tromey@adacore.com>
 967
 968         * source-cache.c (extract_lines): No longer a method.
 969         Changed type of parameter.  Include final newline.
 970         (selftests::extract_lines_test): New function.
 971         (_initialize_source_cache): Likewise.
 972         * source-cache.h (class source_cache)
 973         <extract_lines>: Don't declare.
 974
 975 2019-08-06  Tom Tromey  <tromey@adacore.com>
 976
 977         * breakpoint.c (init_breakpoint_sal): Update.
 978         (breakpoint): Update.
 979         * breakpoint.h (struct breakpoint) <filter>: Now a
 980         unique_xmalloc_ptr.
 981
 982 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 983
 984         * NEWS: Mention dictionary access on blocks.
 985         * python/py-block.c (blpy_getitem): New function.
 986         (block_object_as_mapping): New struct.
 987         (block_object_type): Use new struct for tp_as_mapping field.
 988
 989 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 990
 991         * objfiles.h (objfile): Add a comment describing partial symbols.
 992
 993 2019-08-05  Tom Tromey  <tromey@adacore.com>
 994
 995         * compile/compile.c (_initialize_compile): Use _(), not N_().
 996         * thread.c (_initialize_thread): Use _(), not N_().
 997         * stack.c (_initialize_stack): Use _(), not N_().
 998         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 999
1000 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1001
1002         * dwarf2read.c (struct dw2_symtab_iterator):
1003         <want_specific_block>: Remove.
1004         <block_index>: Change type to gdb::optional.
1005         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1006         change type of BLOCK_INDEX parameter to gdb::optional.
1007         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1008         (dw2_lookup_symbol): Don't pass argument for
1009         WANT_SPECIFIC_BLOCK.
1010         (dw2_expand_symtabs_for_function): Don't pass argument for
1011         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1012         (class dw2_debug_names_iterator)
1013         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1014         parameter, change BLOCK_INDEX type to gdb::optional.
1015         <m_want_specific_block>: Remove.
1016         <m_block_index>: Change type to gdb::optional.
1017         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1018         gdb::optional.  Re-write in function of gdb::optional.
1019         (dw2_debug_names_lookup_symbol): Don't pass argument for
1020         WANT_SPECIFIC_BLOCK.
1021         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1022         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1023         BLOCK_INDEX.
1024
1025 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1026
1027         * NEWS: Mention changes to "info sources" command.
1028
1029 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1030
1031         * symtab.c (filename_partial_match_opts): New struct type.
1032         (struct output_source_filename_data): New members
1033         regexp, c_regexp, partial_match.
1034         (output_source_filename): Use new members to decide to print file.
1035         (info_sources_option_defs): New variable.
1036         (make_info_sources_options_def_group, print_info_sources_header,
1037         info_sources_command_completer):
1038         New functions.
1039         (info_sources_command): Read new optional arguments.
1040         (_initialize_symtab): Update info sources help.
1041
1042 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1043
1044         * ada-lang.c (exception_support_info_v0): Renamed from...
1045         (default_exception_support_info): ... this.  Create new
1046         definition for v1.
1047         (ada_has_this_exception_support): Look up catch_handlers_sym.
1048         (ada_exception_support_info_sniffer): Try v0 after default.
1049
1050 2019-08-01  Tom Tromey  <tromey@adacore.com>
1051
1052         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1053         gdbarch.h.
1054
1055 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1056
1057         * s12z-tdep.c: Fix include path for s12z-opc.h.
1058
1059 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1060
1061         * NEWS: Require GNU make 3.82.
1062
1063 2019-07-16  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1066         declare.
1067
1068 2019-07-30  Tom Tromey  <tromey@adacore.com>
1069
1070         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1071
1072 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1073
1074         * printcmd.c (print_address_symbolic): Print negative offsets.
1075         (build_address_symbolic): Force signed arithmetic when computing
1076         offset.
1077
1078 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1079
1080         PR/24474: Add a function to lookup static variables.
1081         * NEWS: Mention this new function.
1082         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1083         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1084         * python/python.c (python_GdbMethods): Add new function.
1085
1086 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1087
1088         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1089         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1090         (objfpy_lookup_static_symbol): New function.
1091         (objfile_object_methods): Add new functions.
1092
1093 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1094
1095         * NEWS: Mention 'set|show print frame-info'.  Mention new
1096         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1097         backtrace argument.  Mention that python frame filtering code
1098         is now consistent with what 'backtrace' command prints.
1099
1100 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1101
1102         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1103         comments.
1104         (print_frame_info_auto, print_frame_info_source_line,
1105         print_frame_info_location, print_frame_info_source_and_location,
1106         print_frame_info_location_and_address, print_frame_info_short_location):
1107         New declarations.
1108         (struct frame_print_options): New member print_frame_info.
1109         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1110         * stack.h (get_user_print_what_frame_info): New declaration.
1111         (frame_show_address): New declaration.
1112         * stack.c (print_frame_arguments_choices): New value 'presence'.
1113         (print_frame_info_auto, print_frame_info_source_line,
1114         print_frame_info_location, print_frame_info_source_and_location,
1115         print_frame_info_location_and_address, print_frame_info_short_location,
1116         print_frame_info_choices, print_frame_info_print_what): New definitions.
1117         (print_frame_args): Only print dots for args if print frame-arguments
1118         is 'presence'.
1119         (frame_print_option_defs): New element for "frame-info".
1120         (get_user_print_what_frame_info): New function.
1121         (frame_show_address): Make non static.  Move comment to stack.h.
1122         (print_frame_info_to_print_what): New function.
1123         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1124         to decide what to print.
1125         (backtrace_command_1): Handle the new print_frame_arguments_presence
1126         value.
1127         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1128         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1129         (py_print_frame): In non-mi mode, use LOCATION as default for
1130         print_what, similarly to frame information printed directly by
1131         backtrace command. Handle frame-info user option in non MI mode.
1132
1133 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1134
1135         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1136         Add case for debugging 32-bit target on 64-bit host.  Revise
1137         comment.
1138
1139 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1140
1141         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1142         instead of find_function_entry_range_from_pc.
1143
1144 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1145
1146         * stack.c (find_frame_funname): Remove code which preferred
1147         minsym over symtab sym in "certain pathological cases".
1148
1149         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1150         parameter.  Change type of "do_demangle" to bool.
1151         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1152         Pass suitable "prefer_sym_over_minsym" flag to
1153         build_address_symbolic().  Don't output "+" for negative offsets.
1154         * printcmd.c (print_address_symbolic): Update invocation of
1155         build_address_symbolic to include a "prefer_sym_over_minsym"
1156         flag.
1157         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1158         Restrict cases in which use of minimal symbol is preferred to that
1159         of a found symbol.  Update comments.
1160
1161         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1162         for entry pc when entry pc is out of range for that FDE.
1163
1164 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1165
1166         PR gdb/24839:
1167         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1168         type.
1169
1170 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1171
1172         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1173         this function's Python signature.
1174
1175
1176 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1177
1178         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1179         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1180         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1181         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1182         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1183
1184
1185 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1186
1187         * h8300-tdep.c (h8300_register_name_common): New.
1188         h8300_register_name): Use h8300_register_name_common.
1189         (h8300s_register_name): Likewise.
1190         (h8300sx_register_name): Likewise.
1191         (h8300h_register_nam): New.
1192         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1193
1194
1195 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1196
1197         * arm-tdep.c (arm_skip_cmse_entry): New function.
1198         (arm_is_sgstubs_section): New function.
1199         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1200
1201 2019-07-22  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1204         Don't self-assign.
1205
1206 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1209         type_print.
1210
1211 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1212
1213         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1214         so that GDB doesn't match any msymbols when searching in the
1215         TYPES_DOMAIN.
1216         (print_symbol_info): Print using typedef_print or type_print based
1217         on the type of the symbol.  Add updated FIXME comment moved from...
1218         (_initialize_symtab): ... move and update FIXME comment to above.
1219
1220 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * NEWS: Mention adding -q option to "info types".
1223         * symtab.c (struct info_types_options): New struct.
1224         (info_types_options_defs): New variable.
1225         (make_info_types_options_def_group): New function.
1226         (info_types_command): Use gdb::option framework to parse options.
1227         (info_types_command_completer): New function.
1228         (_initialize_symtab): Extend the help text on "info types" and
1229         register command completer.
1230
1231 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1232
1233         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1234         (lookup_symbol_in_objfile): Change int to block_enum and add a
1235         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1236
1237 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1238
1239         * MAINTAINERS (Write After Approval): Add self.
1240
1241 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1244         instruction to the dummy code region.
1245
1246 2019-07-19  Tom Tromey  <tromey@adacore.com>
1247
1248         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1249         (ARGSUSED, PARAMS, __func__): Remove rules.
1250
1251 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1254         * features/arm/arm-with-iwmmxt.c: Remove.
1255         * features/arm/arm-with-iwmmxt.xml: Remove.
1256         * features/arm/arm-with-m-fpa-layout.c: Remove.
1257         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1258         * features/arm/arm-with-m-vfp-d16.c: Remove.
1259         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1260         * features/arm/arm-with-m.c: Remove.
1261         * features/arm/arm-with-m.xml: Remove.
1262         * features/arm/arm-with-neon.c: Remove.
1263         * features/arm/arm-with-neon.xml: Remove.
1264         * features/arm/arm-with-vfpv2.c: Remove.
1265         * features/arm/arm-with-vfpv2.xml: Remove.
1266         * features/arm/arm-with-vfpv3.c: Remove.
1267         * features/arm/arm-with-vfpv3.xml: Remove.
1268
1269 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1272
1273 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * arch/aarch32.c (aarch32_create_target_description): Create
1276         target descriptions using features.
1277         * arch/arm.c (arm_create_target_description)
1278         (arm_create_mprofile_target_description): Likewise.
1279         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1280
1281 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1282
1283         * Makefile.in: Add new files.
1284         * aarch32-tdep.c: New file.
1285         * aarch32-tdep.h: New file.
1286         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1287         Call aarch32_read_description.
1288         * arch/aarch32.c: New file.
1289         * arch/aarch32.h: New file.
1290         * arch/arm.c (arm_create_target_description)
1291         (arm_create_mprofile_target_description): New function.
1292         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1293         (arm_create_target_description)
1294         (arm_create_mprofile_target_description): New declaration.
1295         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1296         read_description functions.
1297         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1298         Likewise.
1299         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1300         * arm-tdep.c (tdesc_arm_list): New variable.
1301         (arm_register_g_packet_guesses): Call create description functions.
1302         (arm_read_description) (arm_read_mprofile_description): New
1303         function.
1304         * arm-tdep.h (arm_read_description)
1305         (arm_read_mprofile_description): Add declaration.
1306         * configure.tgt: Add new files.
1307
1308 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1309
1310         * top.c (new_ui_command): Open specified terminal just once.
1311
1312 2019-07-18  Tom Tromey  <tromey@adacore.com>
1313
1314         * symtab.c (main_name): Constify return type.
1315         * symfile.c (set_initial_language): Update.
1316         * symtab.h (main_name): Constify return type.
1317
1318 2019-07-17  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-winsource.c (tui_update_source_window)
1321         (tui_update_source_window_as_is)
1322         (tui_update_source_windows_with_line): Remove return.
1323         * tui/tui-disasm.c (tui_show_disassem)
1324         (tui_show_disassem_and_update_source): Remove return.
1325         * tui/tui.c (tui_reset): Remove return.
1326         * tui/tui-wingeneral.c
1327         (tui_check_and_display_highlight_if_needed): Remove return.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1332
1333 2019-07-17  Tom Tromey  <tom@tromey.com>
1334
1335         * tui/tui-winsource.h (struct tui_exec_info_window)
1336         (struct tui_source_window_base): Move from tui-data.h.
1337         * tui/tui-winsource.c: Move many method definitions from
1338         elsewhere.  Remove "structuring" comments.
1339         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1340         (tui_source_window_base::refresh_window): Move to
1341         tui-winsource.c.
1342         * tui/tui-win.c (tui_source_window_base::refresh_all)
1343         (tui_source_window_base::update_tab_width)
1344         (tui_source_window_base::set_new_height)
1345         (tui_source_window_base::do_make_visible_with_new_height): Move to
1346         tui-winsource.c.
1347         * tui/tui-source.h: Update.
1348         * tui/tui-source.c (tui_source_window_base::reset): Move to
1349         tui-winsource.c.
1350         * tui/tui-disasm.h: Update.
1351         * tui/tui-data.h (struct tui_exec_info_window): Move to
1352         tui-winsource.h.
1353         (struct tui_source_window_base): Likewise.
1354         * tui/tui-data.c (tui_source_window_base::clear_detail)
1355         (tui_source_window_base, ~tui_source_window_base): Move to
1356         tui-winsource.c.
1357
1358 2019-07-17  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-win.c (tui_resize_all)
1361         (tui_source_window_base::update_tab_width)
1362         (tui_adjust_win_heights): Update.
1363         (tui_win_info::make_invisible_and_set_new_height): Rename from
1364         make_invisible_and_set_new_height.
1365         * tui/tui-data.h (struct tui_win_info)
1366         <make_invisible_and_set_new_height>: New method.
1367
1368 2019-07-17  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui.c: Update.
1371         * tui/tui-source.h (struct tui_source_window): Move from
1372         tui-data.h.
1373         * tui/tui-layout.c: Update.
1374         * tui/tui-disasm.c: Update.
1375         * tui/tui-data.h (struct tui_source_window): Move to
1376         tui-source.h.
1377
1378 2019-07-17  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1381         tui-data.h.
1382         * tui/tui-data.h (struct tui_disasm_window): Move to
1383         tui-disasm.h.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-regs.h (struct tui_data_item_window): Move from
1388         tui-data.h.
1389         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1390         * tui/tui-data.h (struct tui_data_item_window): Move to
1391         tui-regs.h.
1392         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1393
1394 2019-07-17  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui.c: Update.
1397         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1398         (tui_cmd_window::max_height): Move to tui-command.c.
1399         * tui/tui-layout.c: Update.
1400         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1401         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1402         tui-command.c.
1403         * tui/tui-command.h (struct tui_cmd_window): Move from
1404         tui-data.h.
1405         * tui/tui-command.c: Remove "structuring" comments.
1406         (tui_cmd_window::clear_detail)
1407         (tui_cmd_window::do_make_visible_with_new_height)
1408         (tui_cmd_window::max_height): Move from elsewhere.
1409
1410 2019-07-17  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1413         Now static.
1414         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1415         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui.c: Update.
1420         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1421         tui-regs.c.
1422         * tui/tui-windata.h: Remove file.
1423         * tui/tui-windata.c: Remove file.
1424         * tui/tui-win.c (tui_data_window::set_new_height)
1425         (tui_data_window::do_make_visible_with_new_height): Move to
1426         tui-regs.c.
1427         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1428         * tui/tui-regs.c: Remove "structuring" comments.
1429         (tui_data_window::first_data_item_displayed)
1430         (tui_data_window::delete_data_content_windows)
1431         (tui_data_window::erase_data_content)
1432         (tui_data_window::display_all_data)
1433         (tui_data_window::refresh_all)
1434         (tui_data_window::do_scroll_vertical)
1435         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1436         (tui_data_window::do_make_visible_with_new_height)
1437         (tui_data_window::refresh_window): Move from elsewhere.
1438         (_initialize_tui_regs): Move to end of file.
1439         * tui/tui-layout.c: Update.
1440         * tui/tui-hooks.c: Update.
1441         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1442         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1443         tui-regs.c.
1444         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1445
1446 2019-07-17  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1449         seen.
1450
1451 2019-07-17  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-win.c (tui_source_window_base::set_new_height)
1454         (tui_source_window_base::do_make_visible_with_new_height): Use
1455         m_has_locator field directly.
1456         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1457         method.
1458         (struct tui_source_window_base) <has_locator>: Likewise.
1459
1460 2019-07-17  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1463         Don't declare.
1464         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1465         Remove.
1466         * tui/tui-win.c (tui_source_window_base::set_new_height)
1467         (tui_source_window_base::set_new_height)
1468         (make_invisible_and_set_new_height)
1469         (tui_source_window_base::do_make_visible_with_new_height)
1470         (tui_source_window_base::do_make_visible_with_new_height):
1471         Update.
1472         * tui/tui-layout.c (show_source_disasm_command, show_data)
1473         (show_source_or_disasm_and_command): Update.
1474         * tui/tui-layout.c (show_layout): Update.
1475
1476 2019-07-17  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-layout.c (make_data_window): Remove.
1479         (show_data): Unify creation and re-initialization cases.
1480
1481 2019-07-17  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-layout.c (make_source_window, make_disasm_window):
1484         Remove.
1485         (show_data): Unify creation and re-initialization cases.
1486
1487 2019-07-17  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-layout.c (make_command_window): Remove.
1490         (show_source_disasm_command, show_source_or_disasm_and_command):
1491         Unify creation and re-initialization cases.
1492
1493 2019-07-17  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1496         creation and re-initialization cases.
1497
1498 2019-07-17  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-regs.c (tui_get_register): Return void.
1501
1502 2019-07-17  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1505         Simplify.
1506
1507 2019-07-17  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1510         resetting.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1515         * tui/tui-regs.c (tui_reg_layout): New function.
1516         (tui_show_registers, tui_reg_command): Use it.
1517         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1518         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1519         parameters.
1520         (tui_layout_command): Remove.
1521
1522 2019-07-17  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-layout.h (tui/tui-layout): Return void.
1525         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1526
1527 2019-07-17  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-layout.c (show_source_disasm_command, show_data):
1530         Update.
1531         (reset_locator): Remove.
1532         (show_source_or_disasm_and_command): Update.
1533
1534 2019-07-17  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-source.c (tui_source_window_base::reset): Remove
1537         win_type parameter.
1538         * tui/tui-layout.c (make_command_window, make_source_window)
1539         (make_disasm_window, make_data_window)
1540         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1541         (reset_locator, show_source_or_disasm_and_command): Update.
1542         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1543         win_type parameter.
1544         (struct tui_source_window_base) <reset>: Likewise.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-layout.c (show_source_disasm_command): Use
1549         reset_locator.
1550         (reset_locator): New function.
1551         (init_and_make_win): Remove.
1552         (show_source_or_disasm_and_command): Use reset_locator.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1557         condition.
1558         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1559         Remove condition.
1560         * tui/tui-source.c (tui_source_window_base::reset): New method.
1561         * tui/tui-layout.c (make_command_window): Don't call
1562         init_and_make_win.
1563         (make_source_window, make_disasm_window): Don't call
1564         make_source_or_disasm_window.
1565         (make_data_window): Don't call init_and_make_win.  Change calling
1566         convention.
1567         (show_source_disasm_command, show_data): Simplify.
1568         (make_source_or_disasm_window): Remove.
1569         (show_source_or_disasm_and_command): Simplify.
1570         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1571         (struct tui_source_window_base) <reset>: Likewise.
1572         <execution_info>: Remove initializer.
1573         * tui/tui-data.c (tui_source_window_base): Initialize
1574         execution_info.
1575
1576 2019-07-17  Tom Tromey  <tom@tromey.com>
1577
1578         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1579         variable.
1580
1581 2019-07-17  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui.c (tui_rl_other_window): Update.
1584         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1585         superclass method first.  Always iterate over regs_content.
1586         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1587         method.
1588         * tui/tui-win.c (tui_set_focus_command): Update.
1589
1590 2019-07-17  Tom Tromey  <tom@tromey.com>
1591
1592         * tui/tui-win.c (tui_set_focus_command): Rename from
1593         tui_set_focus.  Call tui_enable.
1594         (tui_set_focus_command): Remove.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1599         refresh_window.
1600         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1601         touchwin.
1602         (tui_data_window::refresh_window): Call refresh_window on data
1603         items.  Always call superclass refresh_window.
1604         (tui_win_info::refresh): Remove.
1605         (tui_source_window_base::refresh_window): Update.
1606         (tui_refresh_all): Update.
1607         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1608         refresh_window.
1609         (show_source_or_disasm_and_command): Likewise.
1610         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1611         (struct tui_source_window_base) <refresh>: Likewise.
1612
1613 2019-07-17  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-winsource.c (tui_clear_source_content)
1616         (tui_show_source_content): Update.
1617         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1618         whether content is empty.
1619         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1620         Remove.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1625         window's contents.
1626         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1627         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1628
1629 2019-07-17  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1632         (struct tui_data_item_window): Update.
1633
1634 2019-07-17  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1637         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1638         defines.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-winsource.h (tui_erase_source_content)
1643         (tui_clear_source_content): Remove "display_prompt" parameter.
1644         * tui/tui-winsource.c (tui_update_source_window_as_is)
1645         (tui_update_source_windows_with_addr): Update.
1646         (tui_clear_source_content): Remove "display_prompt" parameter.
1647         (tui_erase_source_content): Likewise.  Simplify.
1648         (tui_show_source_content): Update.
1649         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1650         * tui/tui-stack.c (tui_show_frame_info): Update.
1651         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1652         Remove defines.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1657         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1658         parameter.
1659         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1660         parameter.
1661
1662 2019-07-17  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.c (tui_clear_source_content)
1665         (tui_show_source_content, tui_show_exec_info_content)
1666         (tui_clear_exec_info_content): Update.
1667         * tui/tui-stack.c (tui_show_locator_content): Update.
1668         (tui_show_frame_info): Update.
1669         * tui/tui-source.h (tui_source_window): Don't declare.
1670         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1671         from tui_source_is_displayed.
1672         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1673         Remove field.
1674         (struct tui_source_window_base) <content_in_use>: New field.  Now
1675         bool.
1676         (struct tui_source_window) <showing_source_p>: New method.
1677         (TUI_SRC_WIN): Change cast.
1678         * tui/tui-data.c (tui_initialize_static_data): Update.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1683         location_matches_p.
1684         * tui/tui-source.c (tui_source_window::location_matches_p): New
1685         method.
1686         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1687         method.
1688         * tui/tui-data.h (struct tui_source_window_base)
1689         <location_matches_p>: New method.
1690         (struct tui_source_window, struct tui_disasm_window)
1691         <location_matches_p>: Likewise.
1692
1693 2019-07-17  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-win.c (tui_set_win_height_command): Rename from
1696         tui_set_win_height.
1697         (tui_set_win_height_command): Remove.
1698
1699 2019-07-17  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-source.c (tui_source_window): New constructor.  Add
1702         observer.
1703         (~tui_source_window): New destructor.
1704         (tui_source_window::style_changed): New method.
1705         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1706         (tui_attach_detach_observers): Update.
1707         * tui/tui-data.h (struct tui_source_window): Make constructor not
1708         inline.  Add destructor.
1709         (struct tui_source_window) <style_changed>: New method.
1710         <m_observable>: New member.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1715         * tui/tui-win.c (tui_resize_all): Fix typo.
1716
1717 2019-07-17  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1720         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1721         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1722         * tui/tui-win.c (window_name_completer): Use foreach.
1723         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1724         (update_tab_width): Likewise.
1725         * tui/tui-layout.c (show_layout): Update.
1726         * tui/tui-data.h (class tui_window_iterator): New.
1727         (struct all_tui_windows): New.
1728         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1729
1730 2019-07-17  Tom Tromey  <tom@tromey.com>
1731
1732         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1733         parameter.  Don't reference globals.
1734         (tui_reg_command): Update.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-regs.c (tui_show_registers): Simplify.
1739
1740 2019-07-17  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-regs.c (tui_show_registers): Update.
1743         (tui_show_register_group): Add win_info parameter.
1744
1745 2019-07-17  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1748         Rename from tui_display_reg_element_at_line.
1749         (tui_data_window::display_registers_from_line): Update.
1750         * tui/tui-data.h (struct tui_data_window)
1751         <display_reg_element_at_line>: New method.
1752
1753 2019-07-17  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-regs.h (tui_display_registers_from)
1756         (tui_display_registers_from_line): Don't declare.
1757         * tui/tui-windata.c (tui_data_window::display_all_data)
1758         (tui_data_window::refresh_all)
1759         (tui_data_window::do_scroll_vertical): Update.
1760         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1761         from tui_display_registers_from.
1762         (tui_display_reg_element_at_line): Update.
1763         (tui_data_window::display_registers_from_line): Rename from
1764         tui_display_registers_from_line.
1765         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1766         display_registers_from_line>: New methods.
1767
1768 2019-07-17  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1771         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1772         from tui_erase_data_content.
1773         (tui_data_window::display_all_data)
1774         (tui_data_window::refresh_all)
1775         (tui_data_window::do_scroll_vertical): Update.
1776         * tui/tui-regs.c (tui_show_registers): Update.
1777         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1778         New method.
1779
1780 2019-07-17  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1783         declare.
1784         * tui/tui-windata.c
1785         (tui_data_window::delete_data_content_windows): Rename from
1786         tui_delete_data_content_windows.
1787         (tui_data_window::display_all_data)
1788         (tui_data_window::do_scroll_vertical): Update.
1789         * tui/tui-data.h (struct tui_data_window)
1790         <delete_data_content_windows>: New method.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1795         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1800         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1801         from tui_display_all_data.
1802         * tui/tui-win.c
1803         (tui_data_window::do_make_visible_with_new_height): Update.
1804         * tui/tui-regs.c (tui_show_registers): Update.
1805         * tui/tui-layout.c (tui_set_layout): Update.
1806         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1807         method.
1808
1809 2019-07-17  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1812         * tui/tui-windata.c (tui_display_data_from): Remove.
1813         (tui_data_window::refresh_all): Update.
1814
1815 2019-07-17  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1818         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1819         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1820         tui_display_registers_from_line.
1821         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1822         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1823         "force_display" parameter.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1828         declare.
1829         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1830         Rename from tui_first_reg_element_no_inline.
1831         (tui_display_reg_element_at_line)
1832         (tui_display_registers_from_line): Update.
1833         * tui/tui-data.h (struct tui_data_window)
1834         <first_reg_element_no_inline>: New method.
1835
1836 2019-07-17  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-windata.c (tui_display_data_from)
1839         (tui_data_window::do_scroll_vertical): Update.
1840         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1841         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1842         Rename from tui_line_from_reg_element_no.
1843         (tui_display_registers_from_line): Update.
1844         * tui/tui-data.h (struct tui_data_window)
1845         <line_from_reg_element_no>: New method.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1850         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1851         tui_last_regs_line_no.
1852         (tui_display_reg_element_at_line)
1853         (tui_display_registers_from_line): Update.
1854         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1855         method.
1856
1857 2019-07-17  Tom Tromey  <tom@tromey.com>
1858
1859         PR tui/24722:
1860         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1861         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1862         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1863         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1864         (tui_update_breakpoint_info): Likewise.
1865         * tui/tui-hooks.c (tui_event_create_breakpoint)
1866         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1867         Update.
1868
1869 2019-07-17  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1872
1873 2019-07-17  Tom Tromey  <tom@tromey.com>
1874
1875         * tui/tui-winsource.c (tui_update_source_window_as_is)
1876         (tui_update_source_windows_with_addr): Update.
1877         * tui/tui-source.h (tui_set_source_content)
1878         (tui_show_symtab_source): Add "win_info" parameter.
1879         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1880         parameter.
1881         (tui_show_symtab_source): Likewise.
1882
1883 2019-07-17  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-wingeneral.c
1886         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1887
1888 2019-07-17  Tom Tromey  <tom@tromey.com>
1889
1890         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1891         (struct tui_cmd_window) <can_scroll>: New method.
1892         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1893         method.
1894
1895 2019-07-17  Tom Tromey  <tromey@adacore.com>
1896
1897         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1898         do_field_signed>: Rename.  Change type of "value".
1899         * ui-out.c (ui_out::field_signed): Rename from field_int.
1900         Change type of "value".
1901         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1902         type of "value".
1903         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1904         do_field_int.  Change type of "value".
1905         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1906         do_field_int.  Change type of "value".
1907         * tracepoint.c (trace_status_mi, tfind_1)
1908         (print_one_static_tracepoint_marker): Update.
1909         * thread.c (print_thread_info_1, print_selected_thread_frame):
1910         Update.
1911         * stack.c (print_frame, print_frame_info): Update.
1912         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1913         Update.
1914         * source.c (print_source_lines_base): Update.
1915         * skip.c (info_skip_command): Update.
1916         * record-btrace.c (btrace_ui_out_decode_error)
1917         (btrace_call_history_src_line): Update.
1918         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1919         Update.
1920         * progspace.c (print_program_space): Update.
1921         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1922         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1923         do_field_int.  Change type of "value".
1924         * mi/mi-out.c (mi_ui_out::do_table_begin)
1925         (mi_ui_out::do_table_header): Update.
1926         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1927         type of "value".
1928         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1929         (mi_cmd_data_list_changed_registers, output_register)
1930         (mi_cmd_data_read_memory, mi_load_progress)
1931         (mi_cmd_trace_frame_collected): Update.
1932         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1933         Update.
1934         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1935         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1936         (mi_cmd_var_list_children, varobj_update_one): Update.
1937         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1938         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1939         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1940         * inferior.c (print_inferior): Update.
1941         * gdb_bfd.c (print_one_bfd): Update.
1942         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1943         Update.
1944         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1945         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1946         do_field_int.  Change type of "value".
1947         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1948         do_field_int.  Change type of "value".
1949         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1950         (print_one_breakpoint_location, print_it_catch_fork)
1951         (print_one_catch_fork, print_it_catch_vfork)
1952         (print_one_catch_vfork, print_it_catch_solib)
1953         (print_it_catch_exec, print_it_ranged_breakpoint)
1954         (print_mention_watchpoint, print_mention_masked_watchpoint)
1955         (bkpt_print_it, update_static_tracepoint): Update.
1956         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1957         * break-catch-syscall.c (print_it_catch_syscall): Update.
1958         * ada-tasks.c (print_ada_task_info): Update.
1959         * ada-lang.c (print_it_exception, print_mention_exception):
1960         Update.
1961
1962 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         PR breakpoints/24541
1965         * gdbarch.c: Regenerate.
1966         * gdbarch.h: Regenerate.
1967         * gdbarch.sh: Adjust return type and parameter types for
1968         'stap_adjust_register'.
1969         (i386_stap_adjust_register): Adjust signature and return new
1970         register name.
1971         * stap-probe.c (stap_parse_register_operand): Adjust use of
1972         'gdbarch_stap_adjust_register'.
1973
1974 2019-07-17  Tom Tromey  <tromey@adacore.com>
1975
1976         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1977         declare VEC.
1978         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1979         std::vector.
1980         (struct s390_process_info): Add initializers.
1981         (s390_add_process): Use new.
1982         (s390_linux_nat_target::low_forget_process): Use delete.
1983         (s390_linux_nat_target::low_new_fork)
1984         (s390_linux_nat_target::stopped_by_watchpoint)
1985         (s390_linux_nat_target::low_prepare_to_resume)
1986         (s390_linux_nat_target::insert_watchpoint)
1987         (s390_linux_nat_target::insert_hw_breakpoint)
1988         (s390_linux_nat_target::remove_watchpoint)
1989         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1990
1991 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1992
1993         * aarch64-fbsd-nat.c: Include regcache.h.
1994         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1995         argument.
1996         (aarch64_fbsd_nat_target::fetch_registers)
1997         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1998         variable.
1999         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2000
2001 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2002
2003         * fbsd-nat.c: Include gdbarch.h.
2004
2005 2019-07-15  Tom Tromey  <tromey@adacore.com>
2006
2007         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2008
2009 2019-07-15  Tom Tromey  <tromey@adacore.com>
2010
2011         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2012         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2013         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2014         * cli-out.c (cli_ui_out::do_field_int): New method.
2015         * ui-out.c (ui_out::field_unsigned): New method.
2016         * symfile.c (generic_load): Use field_unsigned.
2017         (print_transfer_performance): Likewise.
2018         * record-btrace.c (ui_out_field_uint): Remove.
2019         (btrace_call_history_insn_range, btrace_call_history): Use
2020         field_unsigned.
2021         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2022         field_unsigned.
2023         * ui-out.h (class ui_out) <field_unsigned>: New method.
2024         <do_field_unsigned>: Likewise.
2025
2026 2019-07-15  Tom Tromey  <tromey@adacore.com>
2027
2028         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2029         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2030         * target.c (flash_erase_command): Use field_string.
2031         * infrun.c (print_signal_received_reason): Use field_string.
2032         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2033         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2034         field_string.
2035         * ada-tasks.c (print_ada_task_info): Use field_string.
2036
2037 2019-07-15  Tom Tromey  <tromey@adacore.com>
2038
2039         * target.c (flash_erase_command): Use field_core_addr.
2040         * symfile.c (generic_load): Use field_core_addr.
2041         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2042         Use field_core_addr.
2043         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2044         field_core_addr.
2045
2046 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2049         value if its desired type is smaller than a CORE_ADDR and signed.
2050
2051 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2054         of changes to field names, and use new is_reference field to
2055         decide if a property is a reference or not.
2056         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2057         field.
2058         (struct dwarf2_property_baton): Update header comment, rename
2059         'referenced_type' to 'property_type' and update comments.
2060         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2061         default property type, store in property baton, update to take
2062         accound of renamed field.
2063         (read_func_scope): Update call to attr_to_dynamic_prop.
2064         (read_array_type): Likewise.
2065         (dwarf2_per_cu_addr_sized_int_type): New function.
2066         (read_subrange_index_type): Move type finding code to
2067         dwarf2_per_cu_addr_sized_int_type.
2068         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2069         (dwarf2_per_cu_addr_type): New function.
2070         (set_die_type): Update calls to attr_to_dynamic_prop.
2071
2072 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2073
2074         * dwarf2read.c (read_subrange_index_type): New function.
2075         (read_subrange_type): Move code into new function and call it.
2076         * gdbtypes.c (create_range_type): Add some asserts.
2077
2078 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2081         update return statements.
2082         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2083         declaration, and update comment to match.
2084         * gdbtypes.c (resolve_dynamic_array): Update call to
2085         dwarf2_evaluate_property to match new return type.
2086
2087 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * valarith.c (value_subscripted_rvalue): Change lowerbound
2090         parameter type from int to LONGEST.
2091         * value.h (value_subscripted_rvalue): Likewise in declaration.
2092
2093 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2094
2095         * cli/cli-utils.c (info_print_command_completer): New function.
2096         * cli/cli-utils.h: Add 'completer.h' include, and forward
2097         declaration for 'struct cmd_list_element'.
2098         (info_print_command_completer): Declare.
2099         * stack.c (_initialize_stack): Add completer for 'info locals' and
2100         'info args'.
2101         * symtab.c (_initialize_symtab): Add completer for 'info
2102         variables' and 'info functions'.
2103         * NEWS: Mention completion for additional info commands.
2104
2105 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2106
2107         * cli/cli-utils.c (extract_info_print_args): Delete.
2108         (extract_arg_maybe_quoted): Delete.
2109         (info_print_options_defs): New variable.
2110         (make_info_print_options_def_group): New function.
2111         (extract_info_print_options): Define new function.
2112         * cli/cli-utils.h (extract_info_print_args): Delete.
2113         (struct info_print_options): New structure.
2114         (extract_info_print_options): Declare new function.
2115         * stack.c (info_locals_command): Update to use new
2116         extract_info_print_options, also add a header comment.
2117         (info_args_command): Likewise.
2118         * symtab.c (info_variables_command): Likewise.
2119         (info_functions_command): Likewise.
2120
2121 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2124         to extract string arguments.
2125         * common/common-utils.c (extract_string_maybe_quoted): New function.
2126         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2127
2128 2019-07-11  Tom Tromey  <tromey@adacore.com>
2129
2130         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2131         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2132         * top.h (gdbinit): Don't declare.
2133         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2134         into...
2135         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2136         * top.c (gdb_init): Don't call init_cli_cmds.
2137         (gdbinit): Remove.
2138         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2139
2140 2019-07-11  Tom Tromey  <tromey@adacore.com>
2141
2142         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2143         after it has been moved.
2144
2145 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2146
2147         * valops.c (value_must_coerce_to_target): Change return type to
2148         bool.
2149         * value.h (value_must_coerce_to_target): Likewise.
2150
2151 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2152
2153         * breakpoint.c (is_hardware_watchpoint): Remove
2154         forward-declaration.
2155         (is_masked_watchpoint): Change return type to bool.
2156         (is_tracepoint): Likewise.
2157         (is_breakpoint): Likewise.
2158         (is_hardware_watchpoint): Likewise.
2159         (is_watchpoint): Likewise.
2160         (is_no_memory_software_watchpoint): Likewise.
2161         (is_catchpoint): Likewise.
2162         (breakpoint_1): Make FILTER parameter's return type bool.
2163         is_masked_watchpoint): Change return type to bool.
2164         (save_breakpoints): Make FILTER parameter's return type bool.
2165         * breakpoint.h (is_breakpoint): Change return type to bool.
2166         (is_watchpoint): Likewise.
2167         (is_catchpoint): Likewise.
2168         (is_tracepoint): Likewise.
2169
2170 2019-07-10  Tom Tromey  <tom@tromey.com>
2171
2172         * defs.h: Don't include gdbarch.h.
2173         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2174         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2175         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2176         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2177         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2178         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2179         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2180         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2181         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2182         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2183         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2184         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2185         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2186         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2187         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2188         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2189         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2190         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2191         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2192         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2193         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2194         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2195         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2196         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2197         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2198         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2199         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2200
2201 2019-07-10  Tom Tromey  <tromey@adacore.com>
2202
2203         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2204         * breakpoint.c (init_ada_exception_breakpoint): Register as
2205         bp_catchpoint.
2206         (print_one_breakpoint_location, print_one_breakpoint): Use
2207         is_ada_exception_catchpoint.
2208         * ada-lang.c (class ada_catchpoint_location): Pass
2209         bp_loc_software_breakpoint to bp_location constructor.
2210         (is_ada_exception_catchpoint): New function.
2211
2212 2019-07-10  Tom Tromey  <tromey@adacore.com>
2213
2214         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2215         VEC.
2216         (struct arm_exidx_entry): New method operator<.
2217         (struct arm_exidx_data) <section_maps>: Change type.
2218         (arm_exidx_data_free): Remove.
2219         (arm_exidx_data_key): Change type.  Move lower.
2220         (arm_exidx_new_objfile): Update.
2221         (arm_compare_exidx_entries): Remove.
2222         (arm_find_exidx_entry, _initialize_arm_tdep)
2223
2224 2019-07-10  Tom Tromey  <tromey@adacore.com>
2225
2226         * solib-spu.c (ocl_program_data_key): Change type.
2227         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2228         Update.
2229
2230 2019-07-10  Tom Tromey  <tromey@adacore.com>
2231
2232         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2233         (struct solib_aix_inferior_data) <library_list>: Change type.
2234         (solib_aix_inferior_data_handle): Change type.
2235         (get_solib_aix_inferior_data): Update.
2236         (solib_aix_free_library_list): Remove.
2237         (library_list_start_library): Update.
2238         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2239         return type.
2240         (solib_aix_get_library_list)
2241         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2242         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2243
2244 2019-07-10  Tom Tromey  <tromey@adacore.com>
2245
2246         * solib-dsbt.c (struct dsbt_info): Add initializers.
2247         (solib_dsbt_pspace_data): Change type.
2248         (dsbt_pspace_data_cleanup): Remove.
2249         (get_dsbt_info, _initialize_dsbt_solib): Update.
2250
2251 2019-07-10  Tom Tromey  <tromey@adacore.com>
2252
2253         * spu-tdep.c (spu_overlay_data): Change type.
2254         (spu_get_overlay_table, spu_overlay_new_objfile)
2255         (_initialize_spu_tdep): Update.
2256
2257 2019-07-10  Tom Tromey  <tromey@adacore.com>
2258
2259         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2260         destructor.
2261         (dbx_objfile_data_key): Change type and declare later.
2262         (DBX_SYMFILE_INFO): Rewrite.
2263         * dbxread.c (dbx_objfile_data_key): Change type.
2264         (dbx_symfile_init): Update.
2265         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2266         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2267         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2268
2269 2019-07-10  Tom Tromey  <tromey@adacore.com>
2270
2271         * jit.c (jit_program_space_key): Change type.  Move lower.
2272         (get_jit_program_space_data): Update.
2273         (jit_program_space_data_cleanup): Remove.
2274         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2275         Update.
2276         (struct jit_program_space_data): Add initializers.
2277
2278 2019-07-10  Tom Tromey  <tromey@adacore.com>
2279
2280         * solib-darwin.c (struct darwin_info): Add initializers.
2281         (solib_darwin_pspace_data): Change type.
2282         (darwin_pspace_data_cleanup): Remove.
2283         (get_darwin_info, _initialize_darwin_solib): Update.
2284
2285 2019-07-10  Tom Tromey  <tromey@adacore.com>
2286
2287         * remote-sim.c (struct sim_inferior_data): Add initializers,
2288         constructor, and destructor.
2289         (sim_inferior_data_key): Change type.  Move lower.
2290         (check_for_duplicate_sim_descriptor): Update.
2291         (get_sim_inferior_data): Use new.  Update.
2292         (~sim_inferior_data_cleanup): Rename from
2293         sim_inferior_data_cleanup.  Simplify.
2294         (gdbsim_close_inferior, simulator_command)
2295         (sim_command_completer, _initialize_remote_sim): Update.
2296         (next_pid, INITIAL_PID): Move earlier.
2297
2298 2019-07-10  Tom Tromey  <tromey@adacore.com>
2299
2300         * python/python-internal.h (create_thread_object): Return
2301         gdbpy_ref.
2302         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2303         * python/py-inferior.c (struct threadlist_entry): Add
2304         constructor.
2305         <thread_obj>: Now a gdbpy_ref.
2306         (thread_to_thread_object): Update.
2307         (add_thread_object): Use new.
2308         (delete_thread_object): Use delete.
2309         (infpy_threads): Update.
2310         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2311         GIL.
2312
2313 2019-07-10  Tom Tromey  <tromey@adacore.com>
2314
2315         * valops.c (value_cast): Specialize error message for Ada.
2316
2317 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2318
2319         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2320
2321 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2322
2323         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2324         bpstat_should_step): Return bool, adjust comments.
2325         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2326         bpstat_should_step): Likewise.
2327
2328 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2329
2330         * features/Makefile: Use feature target descriptions for Arm.
2331         * features/arm/arm-core.c: Generate new file.
2332         * features/arm/arm-fpa.c: Likewise.
2333         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2334         * features/arm/arm-m-profile.c: Likewise.
2335         * features/arm/arm-vfpv2.c: Likewise.
2336         * features/arm/arm-vfpv3.c: Likewise.
2337         * features/arm/xscale-iwmmxt.c: Likewise.
2338         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2339
2340 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2341
2342         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2343         ptrace earlier.
2344
2345 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2346
2347         * features/aarch64-pauth.c: Regenerate.
2348
2349 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2350
2351         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2352         bool.
2353         (bpstat_what): Use false instead of 0.
2354
2355 2019-07-09  Pedro Alves  <palves@redhat.com>
2356
2357         * break-catch-throw.c (is_exception_catchpoint): New.
2358         * breakpoint.c (print_one_breakpoint_location): New parameter
2359         'raw_loc'.  Handle it.  Use
2360         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2361         looking at the breakpoint's type.
2362         (print_one_breakpoint): If handling "maint info breakpoints", also
2363         print locations of exception catchpoints.
2364         * breakpoint.h (is_exception_catchpoint): Declare.
2365
2366 2019-07-09  Pedro Alves  <palves@redhat.com>
2367
2368         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2369         "addr" field.
2370         (allocate_location_exception_catchpoint): New.
2371         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2372         (initialize_throw_catchpoint_ops): Install
2373         allocate_location_exception_catchpoint as allocate_location
2374         method.
2375         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2376         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2377         bp_loc_other.
2378         (breakpoint_address_is_meaningful): Delete.
2379         (bl_address_is_meaningful): New.
2380         (breakpoint_locations_match): Adjust comment.
2381         (bp_location_from_bp_type): New, factored out of...
2382         (bp_location::bp_location(breakpoint *)): ... this.
2383         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2384         factored out of...
2385         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2386         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2387         breakpoint_address_is_meaningful.
2388         (bp_locations_compare): Adjust comment.
2389         (update_global_location_list): Use bl_address_is_meaningful
2390         instead of breakpoint_address_is_meaningful.
2391         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2392         explicit.
2393         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2394         * python/py-breakpoint.c (bppy_get_location): No longer check
2395         whether location is null.
2396
2397 2019-07-09  Pedro Alves  <palves@redhat.com>
2398
2399         PR c++/15468
2400         * breakpoint.c (print_one_breakpoint_location): Remove
2401         single-location assert.
2402
2403 2019-07-09  Tom Tromey  <tom@tromey.com>
2404
2405         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2406         * configure: Rebuild.
2407         * configure.ac: Change common to gdbsupport.
2408         * gdbsupport: Rename from common.
2409         * acinclude.m4: Change common to gdbsupport.
2410         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2411         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2412         gdbsupport.
2413         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2414         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2415         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2416         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2417         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2418         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2419         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2420         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2421         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2422         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2423         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2424         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2425         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2426         coff-pe-read.c, command.h, compile/compile-c-support.c,
2427         compile/compile-c.h, compile/compile-cplus-symbols.c,
2428         compile/compile-cplus-types.c, compile/compile-cplus.h,
2429         compile/compile-loc2c.c, compile/compile.c, completer.c,
2430         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2431         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2432         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2433         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2434         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2435         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2436         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2437         features/aarch64-core.c, features/aarch64-fpu.c,
2438         features/aarch64-pauth.c, features/aarch64-sve.c,
2439         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2440         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2441         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2442         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2443         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2444         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2445         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2446         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2447         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2448         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2449         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2450         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2451         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2452         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2453         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2454         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2455         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2456         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2457         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2458         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2459         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2460         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2461         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2462         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2463         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2464         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2465         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2466         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2467         minsyms.c, mips-linux-tdep.c, namespace.h,
2468         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2469         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2470         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2471         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2472         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2473         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2474         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2475         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2476         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2477         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2478         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2479         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2480         procfs.c, producer.c, progspace.h, psymtab.h,
2481         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2482         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2483         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2484         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2485         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2486         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2487         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2488         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2489         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2490         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2491         target-memory.c, target.c, target.h, target/waitstatus.c,
2492         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2493         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2494         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2495         unittests/array-view-selftests.c,
2496         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2497         unittests/common-utils-selftests.c,
2498         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2499         unittests/format_pieces-selftests.c,
2500         unittests/function-view-selftests.c,
2501         unittests/lookup_name_info-selftests.c,
2502         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2503         unittests/mkdir-recursive-selftests.c,
2504         unittests/observable-selftests.c,
2505         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2506         unittests/parse-connection-spec-selftests.c,
2507         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2508         unittests/scoped_fd-selftests.c,
2509         unittests/scoped_mmap-selftests.c,
2510         unittests/scoped_restore-selftests.c,
2511         unittests/string_view-selftests.c, unittests/style-selftests.c,
2512         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2513         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2514         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2515         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2516         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2517         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2518
2519 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2522         bool value.
2523         (decode_digits_ordinary): Set explicit_line field in sal.
2524         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2525         symtab_and_line that was set on an explicit line number in
2526         assembler code.  Do always update the recorded symtab and line if
2527         we do skip the prologue.
2528
2529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * breakpoint.c (set_breakpoint_location_function): Remove
2532         explicit_loc parameter.
2533         (momentary_breakpoint_from_master): Update call to
2534         set_breakpoint_location_function.
2535         (add_location_to_breakpoint): Likewise.
2536
2537 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2540         required features based on default bfd type when no specific bfd
2541         is present.
2542
2543 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2544
2545         * NEWS: Mention that GDB printf and eval commands can now print
2546         C-style and Ada-style convenience var strings without
2547         calling the inferior.
2548         * printcmd.c (printf_c_string): Locally print GDB internal var
2549         instead of transiting via the inferior.
2550         (printf_wide_c_string): Likewise.
2551
2552 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2553
2554         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2555
2556 2019-07-04  Tom Tromey  <tom@tromey.com>
2557
2558         PR tui/24724:
2559         * tui/tui-winsource.c (tui_clear_source_content): Update.
2560         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2561         (tui_update_breakpoint_info): Update.
2562         (tui_set_exec_info_content): Update.
2563         * tui/tui-source.c (tui_set_source_content_nil): Update.
2564         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2565         has_break.
2566         * tui/tui-data.h (enum tui_bp_flag): New.
2567         (tui_bp_flags): New enum flags type.
2568         (struct tui_source_element) <break_mode>: Change type.  Rename
2569         from has_break.
2570         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2571         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2572         constants.
2573         * tui/tui-winsource.h: Fix comment.
2574
2575 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2578         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2579         (store_fpregs_to_thread)
2580         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2581         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2582         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2583         (IWMMXT_REGS_SIZE): Add define.
2584         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2585         (fetch_vfp_regs, store_vfp_regs)
2586         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2587         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2588
2589 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2592         defines.
2593         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2594         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2595         (ARM_INT_REGISTER_SIZE): ...to this.
2596         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2597         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2598         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2599         (arm_linux_collect_gregset, supply_nwfpe_register)
2600         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2601         defines.
2602         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2603         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2604         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2605         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2606         (arm_return_in_memory, arm_store_return_value)
2607         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2608         (arm_record_ld_st_multiple): Likewise.
2609         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2610         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2611
2612 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2613
2614         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2615         AARCH64_DISPLACED_MODIFIED_INSNS.
2616         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2617         (aarch64_displaced_step_copy_insn): Likewise.
2618         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2619         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2620         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2621         ARM_DISPLACED_MODIFIED_INSNS.
2622         * arm-tdep.c (arm_gdbarch_init): Likewise.
2623         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2624         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2625         (struct arm_displaced_step_closure): Use
2626         ARM_DISPLACED_MODIFIED_INSNS.
2627
2628 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2629
2630         * features/Makefile: Remove unused xml files.
2631         * features/aarch64.xml: Remove.
2632         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2633         * features/i386/amd64-avx-avx512.xml: Remove.
2634         * features/i386/amd64-avx-linux.xml: Remove.
2635         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2636         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2637         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2638         * features/i386/amd64-avx-mpx.xml: Remove.
2639         * features/i386/amd64-avx.xml: Remove.
2640         * features/i386/amd64-linux.xml: Remove.
2641         * features/i386/amd64-mpx-linux.xml: Remove.
2642         * features/i386/amd64-mpx.xml: Remove.
2643         * features/i386/amd64.xml: Remove.
2644         * features/i386/i386-avx-avx512-linux.xml: Remove.
2645         * features/i386/i386-avx-avx512.xml: Remove.
2646         * features/i386/i386-avx-linux.xml: Remove.
2647         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2648         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2649         * features/i386/i386-avx-mpx-linux.xml: Remove.
2650         * features/i386/i386-avx-mpx.xml: Remove.
2651         * features/i386/i386-avx.xml: Remove.
2652         * features/i386/i386-linux.xml: Remove.
2653         * features/i386/i386-mmx-linux.xml: Remove.
2654         * features/i386/i386-mmx.xml: Remove.
2655         * features/i386/i386-mpx-linux.xml: Remove.
2656         * features/i386/i386-mpx.xml: Remove.
2657         * features/i386/i386.xml: Remove.
2658         * features/i386/x32-avx-avx512-linux.xml: Remove.
2659         * features/i386/x32-avx-linux.xml: Remove.
2660         * features/i386/x32-linux.xml: Remove.
2661
2662 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2663
2664         * regformats/aarch64.dat: Remove.
2665         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2666         * regformats/i386/amd64-avx-linux.dat: Remove.
2667         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2668         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2669         * regformats/i386/amd64-linux.dat: Remove.
2670         * regformats/i386/amd64-mpx-linux.dat: Remove.
2671         * regformats/i386/amd64.dat: Remove.
2672         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2673         * regformats/i386/i386-avx-linux.dat: Remove.
2674         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2675         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2676         * regformats/i386/i386-linux.dat: Remove.
2677         * regformats/i386/i386-mmx-linux.dat: Remove.
2678         * regformats/i386/i386-mpx-linux.dat: Remove.
2679         * regformats/i386/i386.dat: Remove.
2680         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2681         * regformats/i386/x32-avx-linux.dat: Remove.
2682         * regformats/i386/x32-linux.dat: Remove.
2683
2684 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2685
2686         * aarch64-tdep.c: Remove xml self tests.
2687         * amd64-linux-tdep.c: Likewise.
2688         * amd64-tdep.c: Likewise.
2689         * i386-linux-tdep.c: Likewise.
2690         * i386-tdep.c: Likewise.
2691
2692 2019-07-03  Pedro Alves  <palves@redhat.com>
2693
2694         PR cli/24732
2695         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2696         (pipe_cmd_option_defs): New.
2697         (make_pipe_cmd_options_def_group): New.
2698         (pipe_command): Use gdb::option::process_options.
2699         (pipe_command_completer): New function.
2700         (_initialize_cli_cmds): Install completer for "pipe" command.
2701
2702 2019-07-03  Pedro Alves  <palves@redhat.com>
2703
2704         * cli/cli-option.c (union option_value) <string>: New field.
2705         (struct option_def_and_value): Add ctor, move ctor, dtor and
2706         use DISABLE_COPY_AND_ASSIGN.
2707         (option_def_and_value::clear_value): New.
2708         (parse_option, save_option_value_in_ctx, get_val_type_str)
2709         (add_setshow_cmds_for_options): Handle var_string.
2710         * cli-option.h (union option_def::var_address) <string>: New
2711         field.
2712         (struct string_option_def): New.
2713         * maint-test-options.c (struct test_options_opts): Add default
2714         ctor and use DISABLE_COPY_AND_ASSIGN.
2715         <string_opt>: New field.
2716         (test_options_opts::~test_options_opts): New.
2717         (test_options_opts::dump): Also dump "-string".
2718         (test_options_option_defs): Install "string.
2719
2720 2019-07-03  Pedro Alves  <palves@redhat.com>
2721
2722         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2723         option_value with a null enumeration.
2724         (complete_options): Save the option values in the context.
2725         (save_option_value_in_ctx): New, factored out from ...
2726         (process_options): ... here.
2727         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2728         of the function.
2729         * maint-test-options.c (test_options_opts::dump): New, factored
2730         out from ...
2731         (maintenance_test_options_command_mode): ... here.
2732         (maintenance_test_options_command_completion_result): Delete.
2733         (maintenance_test_options_command_completion_text): Update
2734         comment.
2735         (maintenance_show_test_options_completion_result): Change
2736         prototype.  Just print
2737         maintenance_test_options_command_completion_text.
2738         (save_completion_result): New.
2739         (maintenance_test_options_completer_mode): Pass options context to
2740         complete_options, and then save a dump.
2741         (_initialize_maint_test_options): Use add_cmd to install "maint
2742         show test-options-completion-result".
2743
2744 2019-07-03  Pedro Alves  <palves@redhat.com>
2745
2746         * NEWS (New commands): Mention "with" and "maint with".
2747         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2748         (with_command, with_command_completer): New.
2749         (pipe_command): Adjust to new repeat_previous
2750         interface.
2751         (_initialize_cli_cmds): Install the "with" command and its "w"
2752         alias.
2753         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2754         declarations.
2755         * cli/cli-setshow.c (parse_cli_var_uinteger)
2756         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2757         argument strings for all var_types.
2758         (get_setshow_command_value_string): New, factored out from ...
2759         (do_show_command): ... this.
2760         * cli/cli-setshow.h: Include <string>.
2761         (get_setshow_command_value_string): Declare.
2762         * command.h (repeat_previous): Now returns const char *.  Adjust
2763         comment.
2764         * maint.c: Include "cli/cli-cmds.h".
2765         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2766         (_initialize_maint_cmds): Register the "maintenance with" command.
2767         * top.c (repeat_previous): Move bits from pipe_command here:
2768         Return the saved command line, if any; error out if there's no
2769         command to relaunch.
2770
2771 2019-07-03  Pedro Alves  <palves@redhat.com>
2772
2773         * NEWS (New commands): Mention "maint set/show test-settings"
2774         instead of "maint test-settings".
2775         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2776         (maintenance_test_settings_set_list): Rename to ...
2777         (maintenance_set_test_settings_list): ... this.
2778         (maintenance_test_settings_show_list): Rename to  ...
2779         (maintenance_show_test_settings_list): ... this.
2780         (maintenance_test_settings_cmd): Delete.
2781         (maintenance_test_settings_set_cmd): ...
2782         (maintenance_set_test_settings_cmd): ... this.
2783         (maintenance_test_settings_show_cmd): ...
2784         (maintenance_show_test_settings_cmd): ... this.
2785         (maintenance_test_settings_show_value_cmd):
2786         (maintenance_show_test_settings_value_cmd): ... this.
2787         (_initialize_maint_test_settings): No longer install the "maint
2788         test-settings" prefix command.  Rename "maint test-settings set"
2789         to "maint set test-settings", and "maint test-settings show" to
2790         "maint show test-settings".  Adjust all subcommands.
2791
2792 2019-07-03  Pedro Alves  <palves@redhat.com>
2793
2794         * maint-test-settings.c: Fix file's intro comment.  Replace all
2795         references to "test-options" with references to "test-settings",
2796         in comments.
2797
2798 2019-07-03  Pedro Alves  <palves@redhat.com>
2799
2800         * maint-test-settings.c (maintenance_test_settings_xxx)
2801         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2802         New.
2803         (maintenance_test_settings_enums): Use them.
2804         (maintenance_test_settings_enum): Default to
2805         maintenance_test_settings_xxx.
2806         (_initialize_maint_test_settings): Initialize
2807         MAINTENANCE_TEST_SETTINGS_FILENAME.
2808
2809 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2810
2811         * breakpoint.h (remove_breakpoints_inf): Change return type to
2812         void, move function documentation here.
2813         * breakpoint.c (remove_breakpoints_inf): Change return type to
2814         void, move function documentation to header.
2815
2816 2019-07-02  Pedro Alves  <palves@redhat.com>
2817
2818         * NEWS (Completion improvements): Mention "info threads".
2819         * thread.c (struct info_threads_opts, info_threads_option_defs)
2820         (make_info_threads_options_def_group): New.
2821         (info_threads_command): Use gdb::option::process_options.
2822         (info_threads_command_completer): New.
2823         (_initialize_thread): Use gdb::option::build_help to build the
2824         help text for "info threads".
2825
2826 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2827
2828         * defs.h (generic_load): Move from here...
2829         * symfile.h (generic_load): ... to here.  Rename name parameter
2830         to args.
2831         * symfile.c (generic_load): Add comment.
2832
2833 2019-07-01  Tom Tromey  <tromey@adacore.com>
2834
2835         * dwarf2read.c
2836         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2837         declaration of without_params.  Fix formatting.
2838
2839 2019-07-01  Tom Tromey  <tromey@adacore.com>
2840
2841         * ada-exp.y (find_primitive_type): Update.
2842         * ada-lang.h (ada_lookup_symbol): Update.
2843         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2844         parameter.
2845         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2846
2847 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2848
2849         PR breakpoints/24541
2850         * gdbarch.c: Regenerate.
2851         * gdbarch.h: Regenerate.
2852         * gdbarch.sh: Add 'stap_adjust_register'.
2853         * i386-tdep.c: Include '<unordered_set>'.
2854         (i386_stap_adjust_register): New function.
2855         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2856         * stap-probe.c (stap_parse_register_operand): Call
2857         'gdbarch_stap_adjust_register'.
2858
2859 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2860
2861         PR python/24742
2862         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2863         * python/python.c (do_start_initialization): Use 'xmalloc'
2864         instead of 'PyMem_Malloc'.
2865
2866 2019-06-28  Tom Tromey  <tromey@adacore.com>
2867
2868         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2869         for Ada.
2870
2871 2019-06-27  Tom Tromey  <tromey@adacore.com>
2872
2873         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2874         objfile_key.
2875         (arm_find_mapping_symbol, arm_record_special_symbol)
2876         (_initialize_arm_tdep): Update.
2877         (arm_objfile_data_free): Remove.
2878
2879 2019-06-27  Tom Tromey  <tromey@adacore.com>
2880
2881         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2882         to cp_print_static_field.
2883
2884 2019-06-26  Tom Tromey  <tromey@adacore.com>
2885
2886         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2887         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2888         declare.
2889
2890 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2891
2892         * features/aarch64-core.c (create_feature_aarch64_core):
2893         Regenerate.
2894         * features/aarch64-core.xml: Add cpsr flags.
2895
2896 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2897
2898         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2899         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2900
2901 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2902
2903         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2904         field.
2905         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2906         use.
2907         (arm_record_special_symbol): Don't insert new symbol in sorted
2908         position, push it at the end.
2909
2910 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2911
2912         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2913         (arm_mapping_symbol_s): Remove.
2914         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2915         (arm_mapping_symbol_vec): New typedef.
2916         (struct arm_per_objfile): Add constructor.
2917         <section_maps>: Change type to
2918         std::unique_ptr<arm_mapping_symbol_vec[]>.
2919         (arm_compare_mapping_symbols): Remove.
2920         (arm_find_mapping_symbol): Adjust to section_maps type change.
2921         (arm_objfile_data_free): Call delete on arm_per_objfile.
2922         (arm_record_special_symbol): Adjust to section_maps type change.
2923         Allocate arm_per_objfile with new.
2924
2925 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2926
2927         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2928         with the command prefix.
2929
2930 2019-06-25  Tom Tromey  <tom@tromey.com>
2931
2932         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2933         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2934
2935 2019-06-25  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2938         type.
2939         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2940         protected.
2941
2942 2019-06-25  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-winsource.c
2945         (tui_source_window_base::set_is_exec_point_at): Add check against
2946         LOA_ADDRESS.
2947
2948 2019-06-25  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-source.c (tui_set_source_content): Don't check before
2951         xfree.
2952         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2953
2954 2019-06-25  Tom Tromey  <tom@tromey.com>
2955
2956         * tui/tui-winsource.h (tui_update_source_window_as_is)
2957         (tui_alloc_source_buffer, tui_line_is_displayed)
2958         (tui_addr_is_displayed): Change type of win_info.
2959         * tui/tui-winsource.c (tui_update_source_window_as_is)
2960         (tui_clear_source_content, tui_show_source_line)
2961         (tui_show_source_content, tui_source_window_base::refill)
2962         (tui_source_window_base::set_is_exec_point_at)
2963         (tui_source_window_base::set_is_exec_point_at)
2964         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2965         (tui_alloc_source_buffer, tui_line_is_displayed)
2966         (tui_addr_is_displayed): Change type of win_info.  Update.
2967         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2968         (tui_source_window_base::do_make_visible_with_new_height):
2969         Update.
2970         * tui/tui-source.c (tui_set_source_content)
2971         (tui_set_source_content_nil)
2972         (tui_source_window::do_scroll_vertical): Update.
2973         * tui/tui-layout.c (show_layout): Update.
2974         * tui/tui-disasm.c (tui_set_disassem_content)
2975         (tui_disasm_window::do_scroll_vertical): Update.
2976         * tui/tui-data.h (tui_win_content): Remove.
2977         (struct tui_gen_win_info) <content, content_size>: Remove.
2978         (struct tui_source_element): Add initializers and destructor.
2979         (union tui_which_element, struct tui_win_element): Remove.
2980         (struct tui_source_window_base) <content>: New field.
2981         (struct tui_data_window): Remove destructor.
2982         (tui_alloc_content, tui_free_win_content)
2983         (tui_free_all_source_wins_content): Don't declare.
2984         * tui/tui-data.c (tui_initialize_static_data): Update.
2985         (init_content_element, tui_alloc_content): Remove.
2986         (~tui_gen_win_info): Update.
2987         (~tui_data_window, tui_free_all_source_wins_content)
2988         (tui_free_win_content, free_content, free_content_elements):
2989         Remove.
2990
2991 2019-06-25  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-winsource.h (tui_clear_source_content)
2994         (tui_erase_source_content, tui_show_source_content): Change type
2995         of win_info.
2996         * tui/tui-winsource.c (tui_clear_source_content)
2997         (tui_erase_source_content, tui_show_source_content): Change type
2998         of win_info.
2999         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3000         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3001         win_info.
3002         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3003         win_info.
3004         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3005
3006 2019-06-25  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-winsource.c (tui_clear_source_content)
3009         (tui_source_window_base::set_is_exec_point_at): Update.
3010         * tui/tui-source.c (tui_set_source_content_nil): Update.
3011         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3012         a bool.
3013         * tui/tui-data.c (init_content_element): Update.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3018         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3019         * tui/tui-layout.c (init_and_make_win): Update.
3020         * tui/tui.h (enum tui_win_type): Update.
3021         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3022         tui_win_is_auxillary.
3023         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3024         tui_win_is_auxillary.
3025
3026 2019-06-25  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3029         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3030         (tui_delete_data_content_windows, tui_display_all_data)
3031         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3032         Update.
3033         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3034         * tui/tui-regs.c (tui_last_regs_line_no)
3035         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3036         (tui_show_registers): Update.
3037         (tui_show_register_group): Return void.  Update.
3038         (tui_display_registers_from, tui_display_reg_element_at_line)
3039         (tui_display_registers_from_line, tui_check_register_values):
3040         Update.
3041         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3042         member.
3043         (struct tui_data_window) <regs_content>: Now a std::vector.
3044         <regs_content_count>: Remove.
3045         (tui_add_content_elements, tui_free_data_content): Don't declare.
3046         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3047         (init_content_element): Remove DATA_WIN case.  Add assert.
3048         (tui_add_content_elements): Remove.
3049         (tui_data_window): Update.
3050         (tui_free_data_content): Remove.
3051         (free_content_elements): Remove DATA_WIN case.
3052
3053 2019-06-25  Tom Tromey  <tom@tromey.com>
3054
3055         * tui/tui-data.c (tui_data_item_window): Update.
3056         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3057         * tui/tui-windata.c (tui_display_all_data)
3058         (tui_display_data_from_line): Update.
3059         (tui_check_data_values): Remove.
3060         * tui/tui-regs.c (tui_show_register_group)
3061         (tui_display_reg_element_at_line): Update.
3062         * tui/tui-hooks.c (tui_register_changed)
3063         (tui_refresh_frame_and_register_information): Call
3064         tui_check_register_values.
3065         * tui/tui-data.h (struct tui_data_window) <data_content,
3066         data_content_count, data_type>: Remove.
3067         (enum tui_data_type): Remove.
3068
3069         * tui/tui-data.c (tui_data_window::clear_detail)
3070         (~tui_data_window): Update.
3071
3072 2019-06-25  Tom Tromey  <tom@tromey.com>
3073
3074         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3075         declare.
3076         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3077         Rename from tui_first_data_item_displayed.  Update.
3078         (tui_data_window::refresh_all)
3079         (tui_data_window::do_scroll_vertical): Update.
3080         * tui/tui-data.h (struct tui_data_window)
3081         <first_data_item_displayed>: Declare new method.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3086         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3087         contents...
3088         (tui_initialize_static_data): ...here.
3089
3090 2019-06-25  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3093         (tui_display_registers_from, tui_check_register_values): Update.
3094         (tui_display_register): Remove win_info parameter; update.
3095         (tui_get_register): Change type of parameters.
3096         * tui/tui-data.h (struct tui_data_element): Remove.
3097         (union tui_which_element) <data>: Remove.
3098         <data_window>: Change type.
3099         (struct tui_data_item_window): New.
3100         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3101         case.  Add assert.
3102         (~tui_data_item_window): New destructor.
3103         (free_content_elements): Remove DATA_ITEM_WIN case.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3108         Remove.
3109
3110 2019-06-25  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-data.h (struct tui_command_element): Remove.
3113         (union tui_which_element) <command>: Remove.
3114         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3115         assert.
3116         (free_content_elements): Remove CMD_WIN case.
3117
3118 2019-06-25  Tom Tromey  <tom@tromey.com>
3119
3120         * tui/tui-layout.c (tui_set_layout): Update.
3121         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3122         * tui/tui-data.c (layout_def): Update.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3127         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3128         (tui_source_window_base::set_new_height): Update.
3129         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3130         Update.
3131         (tui_set_locator_fullname, tui_set_locator_info)
3132         (tui_show_frame_info): Update.
3133         * tui/tui-source.c (tui_set_source_content)
3134         (tui_source_is_displayed): Update.
3135         * tui/tui-layout.c (show_source_disasm_command, show_data)
3136         (show_source_or_disasm_and_command): Update.
3137         * tui/tui-disasm.c (tui_set_disassem_content)
3138         (tui_get_begin_asm_address): Update.
3139         * tui/tui-data.h (struct tui_locator_element): Remove.
3140         (union tui_which_element) <locator>: Remove.
3141         (struct tui_locator_window): New.
3142         (tui_locator_win_info_ptr): Change return type.
3143         * tui/tui-data.c (_locator): Change type.
3144         (tui_locator_win_info_ptr): Change return type.
3145         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3146         (tui_alloc_content): Add assert.
3147
3148 2019-06-25  Tom Tromey  <tom@tromey.com>
3149
3150         * tui/tui-winsource.c
3151         (tui_exec_info_window::maybe_allocate_content): New method.
3152         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3153         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3154         (make_source_or_disasm_window): Add cast.
3155         * tui/tui-data.h (union tui_which_element) <simple_string>:
3156         Remove.
3157         (struct tui_source_info): New.
3158         (struct tui_source_window_base) <execution_info>: Change type.
3159         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3160         case, and add assert.
3161         (tui_alloc_content): Add assert.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3166         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3167         * tui/tui-data.c (tui_alloc_win_info): Remove.
3168
3169 2019-06-25  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3172         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3173         can_highlight.
3174
3175 2019-06-25  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3178         make_visible_with_new_height method.
3179         (tui_win_info::make_visible_with_new_height): New method.
3180         (tui_source_window_base::do_make_visible_with_new_height)
3181         (tui_data_window::do_make_visible_with_new_height)
3182         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3183         (make_visible_with_new_height): Remove.
3184         (tui_resize_all, tui_adjust_win_heights): Use
3185         make_visible_with_new_height method.
3186         * tui/tui-data.h (struct tui_win_info)
3187         <do_make_visible_with_new_height, make_visible_with_new_height>:
3188         New methods.
3189         (struct tui_source_window_base, struct tui_data_window)
3190         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3191         methods.
3192
3193 2019-06-25  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3196         method.
3197         (update_tab_width): Call update_tab_width method.
3198         * tui/tui-data.h (struct tui_win_info)
3199         (struct tui_source_window_base) <update_tab_width>: New methods.
3200
3201 2019-06-25  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3204         parameter.
3205         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3206         parameter.
3207         (tui_gen_win_info::make_visible): Update.
3208         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3209         parameter.
3210         * tui/tui-data.h (enum tui_box): New enum.
3211         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3212
3213 2019-06-25  Tom Tromey  <tom@tromey.com>
3214
3215         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3216         init_and_make_win for EXEC_INFO_WIN.
3217         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3218         longer inline.
3219         (struct tui_win_info) <~tui_win_info>: Inline.
3220         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3221         Don't declare.
3222         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3223         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3224         Remove.
3225         (tui_initialize_static_data): Update.
3226         (~tui_gen_win_info): Handle more cleanup here.
3227         (~tui_source_window_base): Delete "execution_info".
3228         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3229
3230 2019-06-25  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-layout.c (make_command_window): Don't set
3233         can_highlight.
3234         (show_source_disasm_command): Call the reset method.
3235         (show_data): Don't set can_highlight.  Call the reset method.
3236         (tui_gen_win_info::reset): Rename from init_gen_win_info
3237         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3238         (show_source_or_disasm_and_command): Call the reset method.
3239         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3240         (struct tui_cmd_window): Set can_highlight.
3241
3242 2019-06-25  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3245         from make_visible.
3246         (tui_make_visible, tui_make_invisible): Rewrite.
3247         (tui_win_info::make_visible): Remove.
3248         (tui_source_window_base::make_visible): Update.
3249         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3250         method.  Moved from...
3251         (struct tui_win_info) <make_visible>: ...here.
3252
3253 2019-06-25  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-winsource.c
3256         (tui_source_window_base::do_scroll_horizontal): Remove direction
3257         parameter.
3258         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3259         direction parameter.
3260         * tui/tui-win.c (tui_win_info::forward_scroll)
3261         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3262         (tui_win_info::right_scroll): Update.
3263         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3264         direction parameter.
3265         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3266         direction parameter.
3267         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3268         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3269         Remove direction parameter.
3270         (struct tui_source_window_base, struct tui_source_window)
3271         (struct tui_disasm_window, struct tui_data_window)
3272         (struct tui_cmd_window): Update.
3273
3274 2019-06-25  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-winsource.h (tui_set_exec_info_content)
3277         (tui_show_exec_info_content, tui_erase_exec_info_content)
3278         (tui_clear_exec_info_content, tui_update_exec_info): Change
3279         argument to tui_source_window_base.
3280         * tui/tui-winsource.c (tui_set_exec_info_content)
3281         (tui_show_exec_info_content, tui_erase_exec_info_content)
3282         (tui_clear_exec_info_content, tui_update_exec_info): Change
3283         argument to tui_source_window_base.
3284
3285 2019-06-25  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3288         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3293         check.
3294
3295 2019-06-25  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3298         type to void.
3299         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3300         type to void.
3301         * tui/tui-source.c (tui_set_source_content): Update.
3302         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-win.c (window_name_completer, tui_set_focus)
3307         (tui_all_windows_info): Use name method.
3308         * tui/tui-data.h (struct tui_gen_win_info)
3309         (struct tui_source_window, struct tui_disasm_window)
3310         (struct tui_data_window, struct tui_cmd_window) <name>: New
3311         method.
3312         (tui_win_name): Don't declare.
3313         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3314         (tui_win_name): Remove.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-winsource.h (tui_update_source_window)
3319         (tui_update_source_window_as_is): Change parameter type.
3320         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3321         to be a tui_source_window_base.
3322         (tui_update_source_window_as_is): Likewise.
3323         * tui/tui-win.c (make_visible_with_new_height): Update.
3324
3325 2019-06-25  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-winsource.c (tui_erase_source_content)
3328         (tui_show_source_content, tui_show_exec_info_content)
3329         (tui_erase_exec_info_content): Use refresh_window method.
3330         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3331         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3332         from tui_refresh_win.
3333         (tui_data_window::refresh_window): New method.
3334         (tui_win_info::refresh, tui_source_window_base::refresh)
3335         (tui_refresh_all): Use refresh_window method.
3336         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3337         method.
3338         * tui/tui-regs.c (tui_display_register): Call refresh_window
3339         method.
3340         * tui/tui-layout.c (show_source_disasm_command)
3341         (show_source_or_disasm_and_command): Call refresh_window method.
3342         * tui/tui-data.h (struct tui_gen_win_info)
3343         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3344         New method.
3345
3346 2019-06-25  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui.c (tui_rl_other_window, tui_enable)
3349         (tui_is_window_visible, tui_get_command_dimension): Update.
3350         * tui/tui-winsource.c (tui_update_source_window_as_is)
3351         (tui_clear_source_content, tui_erase_source_content)
3352         (tui_show_source_line, tui_source_window_base::refill)
3353         (tui_source_window_base::do_scroll_horizontal)
3354         (tui_source_window_base::set_is_exec_point_at)
3355         (tui_update_breakpoint_info, tui_set_exec_info_content)
3356         (tui_alloc_source_buffer, tui_line_is_displayed)
3357         (tui_addr_is_displayed): Update.
3358         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3359         (tui_check_and_display_highlight_if_needed)
3360         (tui_win_info::make_visible, tui_win_info::refresh)
3361         (tui_refresh_all): Update.
3362         * tui/tui-windata.c (tui_first_data_item_displayed)
3363         (tui_delete_data_content_windows, tui_erase_data_content)
3364         (tui_display_all_data, tui_data_window::refresh_all)
3365         (tui_check_data_values): Update.
3366         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3367         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3368         (tui_win_info::backward_scroll, tui_refresh_all_win)
3369         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3370         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3371         (tui_source_window_base::set_new_height)
3372         (tui_data_window::set_new_height)
3373         (make_invisible_and_set_new_height)
3374         (make_visible_with_new_height, new_height_ok)
3375         (parse_scrolling_args): Update.
3376         * tui/tui-stack.c (tui_show_frame_info): Update.
3377         * tui/tui-source.c (tui_set_source_content)
3378         (tui_set_source_content_nil, tui_source_is_displayed)
3379         (tui_source_window::do_scroll_vertical): Update.
3380         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3381         (tui_display_registers_from, tui_display_reg_element_at_line)
3382         (tui_check_register_values, tui_reg_command): Update.
3383         * tui/tui-layout.c (tui_default_win_height)
3384         (show_source_disasm_command, show_data, init_and_make_win)
3385         (show_source_or_disasm_and_command): Update.
3386         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3387         (tui_redisplay_readline, tui_mld_flush)
3388         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3389         (tui_getc): Update.
3390         * tui/tui-disasm.c (tui_set_disassem_content)
3391         (tui_disasm_window::do_scroll_vertical): Update.
3392         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3393         Now virtual.
3394         (struct tui_win_info): Derive from tui_gen_win_info.
3395         <~tui_win_info>: Mark as override.
3396         <generic>: Remove member.
3397         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3398         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3399         (~tui_data_window, ~tui_win_info)
3400         (tui_free_all_source_wins_content): Update.
3401         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-layout.c (init_and_make_win): Use new.
3406         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3407         destructor, initializers.
3408         (tui_alloc_generic_win_info): Don't declare.
3409         * tui/tui-data.c (_locator): Add argument to constructor.
3410         (source_win, disasm_win): New globals.
3411         (exec_info): Remove.
3412         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3413         Update.
3414         (tui_alloc_generic_win_info): Remove.
3415         (init_content_element): Use new.
3416         (tui_win_info::tui_win_info): Update.
3417         (free_content_elements) <case DATA_WIN>: Use delete.
3418
3419 2019-06-25  Tom Tromey  <tom@tromey.com>
3420
3421         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3422         * tui/tui-windata.c (tui_first_data_item_displayed)
3423         (tui_delete_data_content_windows): Update.
3424         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3425         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3426         (tui_display_registers_from, tui_check_register_values): Update.
3427         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3428         pointer.
3429         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3430         window.
3431         (tui_free_data_content): Update.
3432         (free_content_elements) <case DATA_WIN>: Free the window.
3433
3434 2019-06-25  Tom Tromey  <tom@tromey.com>
3435
3436         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3437         Update.
3438         * tui/tui-layout.c (make_command_window)
3439         (show_source_disasm_command, show_data, init_and_make_win)
3440         (show_source_or_disasm_and_command): Update.
3441         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3442         method.
3443         <can_highight, is_highlighted>: Now bool.
3444         (tui_set_win_highlight): Don't declare.
3445         * tui/tui-data.c (tui_set_win_highlight): Remove.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-wingeneral.c (make_visible): Remove check of window
3450         type.
3451
3452 2019-06-25  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-win.c (tui_win_info::max_height)
3455         (tui_cmd_window::max_height): New methods.
3456         (new_height_ok): Call max_height.
3457         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3458         <max_height>: New method.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-win.c (tui_source_window_base::set_new_height)
3463         (tui_data_window::set_new_height): New methods.
3464         (make_invisible_and_set_new_height): Call set_new_height method.
3465         * tui/tui-data.h (struct tui_win_info)
3466         (struct tui_source_window_base, struct tui_data_window)
3467         <set_new_height>: New method.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3472         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3473         tui_refresh_data_win.
3474         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3475         method.
3476         (tui_refresh_all_win): Call the refresh_all method.
3477         (tui_set_focus): Likewise.
3478         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3479         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3480         Likewise.
3481
3482 2019-06-25  Tom Tromey  <tom@tromey.com>
3483
3484         * tui/tui-winsource.h (tui_refill_source_window)
3485         (tui_set_is_exec_point_at): Don't declare.
3486         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3487         (tui_source_window_base::refill): Rename from
3488         tui_refill_source_window.
3489         (tui_source_window_base::do_scroll_horizontal): Update.
3490         (tui_source_window_base::set_is_exec_point_at): Rename from
3491         tui_set_is_exec_point_at.
3492         (tui_update_all_breakpoint_info): Update.
3493         * tui/tui-stack.c (tui_show_frame_info): Update.
3494         * tui/tui-layout.c (show_data): Add cast.
3495         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3496         * tui/tui-data.h (struct tui_source_window_base) <refill,
3497         set_is_exec_point_at>: New methods.
3498         (tui_source_windows, tui_add_to_source_windows): Update types.
3499         (tui_add_to_source_windows): Remove redundant declaration.
3500         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3501         (tui_source_windows): Change return type.
3502         (tui_clear_source_windows_detail): Update.
3503         (tui_add_to_source_windows): Change type of parameter.
3504         (tui_free_all_source_wins_content): Update.
3505
3506 2019-06-25  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-wingeneral.c (tui_win_info::refresh)
3509         (tui_source_window_base::refresh): New methods.
3510         (tui_refresh_all): Call the refresh method.
3511         * tui/tui-data.h (struct tui_win_info)
3512         (struct tui_source_window_base) <refresh>: New method.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui.h (tui_is_window_visible): Return bool.
3517         * tui/tui.c (tui_is_window_visible): Return bool.
3518         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3519         (tui_make_visible, tui_make_invisible)
3520         (tui_win_info::make_visible)
3521         (tui_source_window_base::make_visible, make_all_visible)
3522         (tui_make_all_visible, tui_make_all_invisible): Update.
3523         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3524         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3525         bool.
3526         (struct tui_win_info, struct tui_source_window_base)
3527         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3528         * tui/tui-data.c (tui_init_generic_part): Update.
3529
3530 2019-06-25  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3533         (tui_source_window_base::make_visible): New methods.
3534         (make_all_visible): Make method call.
3535         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3536         (struct tui_source_window_base, struct tui_cmd_window): Override
3537         make_visible.
3538         (tui_win_is_source_type): Don't declare.
3539         * tui/tui-data.c (tui_win_is_source_type): Remove.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3544         NULL check.
3545
3546 2019-06-25  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3549         Inline constructor.  Add initializers for members.
3550         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3551         constructors; now inline in class.
3552
3553 2019-06-25  Tom Tromey  <tom@tromey.com>
3554
3555         * tui/tui-regs.c (tui_show_registers): Update.
3556         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3557         bool.
3558         * tui/tui-data.c (tui_data_window::clear_detail)
3559         (tui_data_window): Update.
3560
3561 2019-06-25  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-windata.c (tui_display_all_data)
3564         (tui_display_data_from_line, tui_display_data_from)
3565         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3566         Update.
3567         * tui/tui-regs.c (tui_last_regs_line_no)
3568         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3569         (tui_show_registers, tui_show_register_group)
3570         (tui_display_registers_from, tui_display_reg_element_at_line)
3571         (tui_display_registers_from_line, tui_check_register_values)
3572         (tui_reg_next, tui_reg_prev): Update.
3573         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3574         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3575         tui_data_window.
3576         (struct tui_win_info) <detail>: Remove.  Add new fields from
3577         tui_data_info.
3578         (TUI_DATA_WIN): Add cast.
3579         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3580         (~tui_data_window): Simplify.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-layout.c (show_source_disasm_command)
3585         (show_source_or_disasm_and_command): Update.
3586         * tui/tui-io.c (update_cmdwin_start_line)
3587         (tui_redisplay_readline): Update.
3588         * tui/tui-data.h (struct tui_command_info): Remove.
3589         (struct tui_win_info) <detail>: Remove command_info member.
3590         (struct tui_data_window) <start_line>: New member, from
3591         tui_command_info.
3592         (TUI_CMD_WIN): Add casts.
3593
3594 2019-06-25  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-winsource.c (tui_update_source_window)
3597         (tui_refill_source_window)
3598         (tui_source_window_base::do_scroll_horizontal)
3599         (tui_update_breakpoint_info, tui_set_exec_info_content)
3600         (tui_show_exec_info_content, tui_erase_exec_info_content)
3601         (tui_clear_exec_info_content): Update.
3602         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3603         Update.
3604         * tui/tui-win.c (make_invisible_and_set_new_height)
3605         (make_visible_with_new_height): Update.
3606         * tui/tui-source.c (tui_set_source_content)
3607         (tui_show_symtab_source): Update.
3608         * tui/tui-layout.c (extract_display_start_addr)
3609         (show_source_disasm_command, show_data)
3610         (make_source_or_disasm_window)
3611         (show_source_or_disasm_and_command): Update.
3612         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3613         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3614         "gdbarch".
3615         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3616         to tui_source_window_base.
3617         (struct tui_win_info) <detail>: Remove source_info member.
3618         (struct tui_source_window_base) <has_locator>: Inline.
3619         Move contents from tui_source_info; rename has_locator member to
3620         m_has_locator.
3621         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3622         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3623         header file.
3624         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3625         Simplify.
3626         (tui_free_all_source_wins_content): Cast to
3627         tui_source_window_base.
3628
3629 2019-06-25  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-win.c (make_invisible_and_set_new_height)
3632         (make_visible_with_new_height): Call has_locator method.
3633         * tui/tui-layout.c (show_source_disasm_command, show_data)
3634         (show_source_or_disasm_and_command): Update for bool change.
3635         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3636         (tui_win_info) <has_locator>: New method.
3637         (struct tui_source_window_base) <has_locator>: New method.
3638         (tui_win_has_locator): Don't declare.
3639         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3640         from tui_win_has_locator.
3641         (tui_source_window_base): Use false, not FALSE.
3642
3643 2019-06-25  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3646         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3647         clear_detail method directly.
3648         (tui_clear_win_detail): Remove.
3649
3650 2019-06-25  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3653         "this", not TUI_DISASM_WIN.
3654
3655 2019-06-25  Tom Tromey  <tom@tromey.com>
3656
3657         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3658         declare.
3659         * tui/tui-winsource.c
3660         (tui_source_window_base::do_scroll_horizontal): Rename from
3661         tui_horizontal_source_scroll.
3662         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3663         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3664         from tui_vertical_data_scroll.
3665         * tui/tui-win.h (tui_scroll): Don't declare.
3666         * tui/tui-win.c (tui_win_info::forward_scroll)
3667         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3668         (tui_win_info::right_scroll): Rename and update.
3669         (tui_scroll_forward_command, tui_scroll_backward_command)
3670         (tui_scroll_left_command, tui_scroll_right_command): Update.
3671         (tui_scroll): Remove.
3672         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3673         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3674         from tui_vertical_source_scroll.
3675         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3676         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3677         from tui_vertical_disassem_scroll.
3678         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3679         do_scroll_horizontal>: New methods.
3680         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3681         Likewise.
3682         (struct tui_source_window_base): Add do_scroll_horizontal.
3683         (struct tui_source_window, struct tui_disasm_window): Add
3684         do_scroll_vertical.
3685         (struct tui_data_window, struct tui_cmd_window): Add
3686         do_scroll_horizontal and do_scroll_vertical.
3687         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3688
3689 2019-06-25  Tom Tromey  <tom@tromey.com>
3690
3691         * tui/tui-data.h (struct tui_source_window_base): New struct.
3692         (struct tui_source_window): Derive from tui_source_window_base.
3693         (struct tui_disasm_window): New struct.
3694         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3695         from tui_source_window::clear_detail.
3696         (tui_source_window_base): Rename from tui_source_window.
3697         (~tui_source_window_base): Rename from ~tui_source_window.
3698         (tui_alloc_win_info): Create a tui_disasm_window.
3699
3700 2019-06-25  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-data.h (struct tui_source_window)
3703         (struct tui_data_window): Declare destructors.
3704         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3705         destructors.
3706         (tui_win_info): Simplify.
3707
3708 2019-06-25  Tom Tromey  <tom@tromey.com>
3709
3710         * tui/tui-winsource.c (tui_display_main)
3711         (tui_update_source_windows_with_addr)
3712         (tui_update_all_breakpoint_info): Update.
3713         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3714         (new_height_ok, parse_scrolling_args): Update.
3715         * tui/tui-stack.c (tui_show_frame_info): Update.
3716         * tui/tui-data.h (struct tui_list): Remove.
3717         (tui_source_windows): Return a reference to a std::vector.
3718         * tui/tui-data.c (source_windows): Now a std::vector.
3719         (tui_source_windows): Change return type.
3720         (tui_clear_source_windows): Rewrite.
3721         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3722         (tui_free_all_source_wins_content): Rewrite.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3727         (struct tui_data_window, struct tui_cmd_window): Declare
3728         clear_detail method.
3729         * tui/tui-data.c (tui_source_window::clear_detail)
3730         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3731         methods.
3732         (tui_clear_win_detail): Simplify.
3733
3734 2019-06-25  Tom Tromey  <tom@tromey.com>
3735
3736         * tui/tui-layout.c (make_source_window, make_disasm_window)
3737         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3738         Return the new window.
3739         (show_source_disasm_command, show_data)
3740         (show_source_or_disasm_and_command): Update.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3745         parameter.  Return the new window.
3746         (show_source_disasm_command): Update and remove NULL check.
3747         (show_source_or_disasm_and_command): Update.
3748
3749 2019-06-25  Tom Tromey  <tom@tromey.com>
3750
3751         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3752
3753 2019-06-25  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-data.h (struct tui_win_info): Make constructor
3756         protected.  Make destructor virtual.  Add initializers.
3757         (tui_source_window, tui_data_window, tui_cmd_window): New
3758         classes.
3759         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3760         constructor.  Add "type" parameter.
3761         (tui_source_window, tui_data_window, tui_cmd_window): New
3762         constructors.
3763         (tui_alloc_win_info): Instantiate the appropriate subclass.
3764
3765 2019-06-25  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-win.c (tui_resize_all): Use delete.
3768         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3769         destructor.
3770         (tui_free_window): Don't declare.
3771         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3772         Update.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-data.h (struct tui_win_info): Add constructor.
3777         * tui/tui-data.c (tui_alloc_win_info): Use new.
3778         (tui_free_window): Use delete.
3779
3780 2019-06-22  Tom Tromey  <tom@tromey.com>
3781
3782         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3783         declare.
3784         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3785
3786 2019-06-22  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3789         declare.
3790         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3791
3792 2019-06-22  Tom de Vries  <tdevries@suse.de>
3793
3794         * dwarf2read.c (create_addrmap_from_aranges)
3795         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3796         instead of '%zu'.
3797
3798 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3799
3800         * dwarf2read.h (dwarf2_section_info_def): Remove.
3801         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3802         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3803         std::vector<dwarf2_section_info>.
3804         (struct dwo_file) <~dwo_file>: Remove.
3805         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3806         types field.
3807         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3808         (dwarf2_read_debug_names): Likewise.
3809         (create_debug_types_hash_table): Change parameter type to
3810         array_view, adjust code accordingly.
3811         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3812         (partial_die_info::fixup): Likewise.
3813         (determine_prefix): Likewise.
3814         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3815
3816 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3817
3818         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3819         gdb_bfd_ref_ptr.
3820         <~dwo_file>: Remove call to gdb_bfd_unref.
3821         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3822         gdb_bfd_ref_ptr::get.
3823
3824 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3825
3826         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3827         type to htab_up.
3828         * dwarf2read.c (struct dwo_file): Initialize fields.
3829         <~dwo_file>: New.
3830         (free_dwo_file): Remove, move content to ~dwo_file.
3831         (struct dwo_file_deleter): Remove.
3832         (dwo_file_up>: Remove custom deleter.
3833         (free_dwo_files): Remove.
3834         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3835         dwo_files.
3836         (process_skeletonless_type_units): Call unique_ptr::get.
3837         (allocate_dwo_file_hash_table): Add deleter to created hash
3838         table.  Change return type to htab_up.
3839         (lookup_dwo_file_slot): Don't memset dwo_file, call
3840         unique_ptr::get.
3841         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3842         (create_dwo_unit_in_dwp_v2): Likewise.
3843         (open_and_init_dwo_file): Likewise.
3844         (free_dwo_file_from_slot): Remove.
3845
3846 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3847
3848         * dwarf2read.h (struct dwarf2_section_info) <readin,
3849         is_virtual>: Change type to bool.
3850         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3851         true instead of 1.
3852
3853 2019-06-19  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-data.h (tui_init_content_element): Don't declare.
3856
3857 2019-06-19  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-data.h (tui_init_win_info): Don't declare.
3860
3861 2019-06-19  Tom de Vries  <tdevries@suse.de>
3862
3863         * dwarf2read.h (abstract_to_concrete): Change type to
3864         std::unordered_map<sect_offset, std::vector<sect_offset>,
3865         gdb::hash_enum<sect_offset>>.
3866
3867 2019-06-19  Tom Tromey  <tromey@adacore.com>
3868
3869         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3870         EVAL_AVOID_SIDE_EFFECTS specially.
3871
3872 2019-06-19  Tom Tromey  <tromey@adacore.com>
3873
3874         * source-cache.c (highlighter): New global.
3875         (source_cache::get_source_lines): Create a highlighter on demand.
3876
3877 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * defs.h (deprecated_interactive_hook): Delete declaration.
3880         * interps.c (clear_interpreter_hooks): Remove use of
3881         deprecated_interactive_hook.
3882         * top.c (deprecated_interactive_hook): Delete definition.
3883         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3884
3885 2019-06-18  Tom de Vries  <tdevries@suse.de>
3886
3887         PR gdb/24515
3888         * dwarf2read.h (abstract_to_concrete): Change type from
3889         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3890         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3891         * dwarf2read.c (read_variable): Update.
3892         (dwarf2_fetch_die_loc_sect_off): Update.
3893
3894 2019-06-17  Tom de Vries  <tdevries@suse.de>
3895
3896         PR gdb/24617
3897         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3898         accessing parent[parent_len - 1].
3899
3900 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3901
3902         PR gdb/24364
3903         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3904         call dtrace_process_dof with NULL dof.
3905
3906 2019-06-16  Tom de Vries  <tdevries@suse.de>
3907
3908         PR gdb/24445
3909         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3910
3911 2019-06-16  Tom Tromey  <tom@tromey.com>
3912
3913         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3914         (make_all_visible): Use address of member.
3915
3916 2019-06-16  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3919         (tui_free_window, free_content, free_content_elements): Remove
3920         unnecessary cast.
3921         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3922         cast.
3923         * tui/tui-regs.c (tui_show_register_group)
3924         (tui_display_registers_from, tui_display_reg_element_at_line):
3925         Remove unnecessary cast.
3926
3927 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * linux-nat.c (normal_mask): Delete.
3930         (_initialize_linux_nat): Don't initialise normal_mask.
3931
3932 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3933
3934         PR gdb/24445
3935         * dwarf-index-write.h (write_psymtabs_to_index): Add
3936         dwz_basename parameter.
3937         * dwarf-index-write.c (write_gdbindex): Move file writing to
3938         write_gdbindex_1.  Change return type void.
3939         (assert_file_size): Move up, remove filename parameter.
3940         (write_gdbindex_1): New function.
3941         (write_debug_names): Change return type to void, call
3942         assert_file_size.
3943         (struct index_wip_file): New struct.
3944         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3945         file logic to index_wip_file.  Write index for dwz file if
3946         needed.
3947         (save_gdb_index_command): Pass basename of dwz file, if present.
3948         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3949         build-id of dwz file, if present.
3950         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3951         (dwarf2_get_dwz_file): Likewise.
3952         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3953         (dwarf2_get_dwz_file): Likewise.
3954
3955 2019-06-16  Tom Tromey  <tom@tromey.com>
3956
3957         * coffread.c (process_coff_symbol): Use xstrdup.
3958         * value.c (create_internalvar): Use xstrdup.
3959
3960 2019-06-16  Tom Tromey  <tom@tromey.com>
3961
3962         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3963         * breakpoint.c (stopin_command, stopat_command)
3964         (until_break_command, decode_location_default): Remove unnecessary
3965         cast.
3966         * utils.c (subset_compare): Remove unnecessary cast.
3967         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3968         cast.
3969         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3970         cast.
3971         * infcmd.c (path_command): Remove unnecessary cast.
3972         * coffread.c (decode_type): Remove unnecessary cast.
3973         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3974         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3975         * tui/tui-stack.c (tui_show_locator_content)
3976         (tui_show_frame_info): Remove unnecessary cast.
3977         * tui/tui-win.c (tui_scroll_forward_command)
3978         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3979         (parse_scrolling_args): Remove unnecessary cast.
3980         * tui/tui-data.c (init_win_info, tui_del_window)
3981         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3982         (free_content_elements): Remove unnecessary cast.
3983         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3984         unnecessary cast.
3985         * tui/tui-source.c (tui_set_source_content)
3986         (tui_vertical_source_scroll): Remove unnecessary cast.
3987         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3988         cast.
3989         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3990         * tui/tui-regs.c (tui_display_registers_from)
3991         (tui_display_register): Remove unnecessary cast.
3992         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3993         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3994         (make_visible): Remove unnecessary cast.
3995         * tui/tui-winsource.c (tui_erase_source_content)
3996         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3997         unnecessary cast.
3998         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3999         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4000         * stabsread.c (read_type, read_array_type, read_range_type):
4001         Remove unnecessary cast.
4002         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4003         (parse_symbol, parse_type, upgrade_type, parse_external)
4004         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4005         unnecessary cast.
4006         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4007
4008 2019-06-16  Tom Tromey  <tom@tromey.com>
4009
4010         * tui/tui-data.c (tui_alloc_generic_win_info)
4011         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4012         checks.
4013
4014 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4015             Andrew Burgess  <andrew.burgess@embecosm.com>
4016
4017         * f-typeprint.c (f_print_type): Don't return early for not
4018         associated or not allocated types.
4019         (f_type_print_varspec_suffix): Add print_rank parameter and print
4020         ranks of array types in case they dangling.
4021         (f_type_print_base): Add print_rank parameter.
4022
4023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4024
4025         * NEWS: Mention new MI commands.
4026         * break-catch-throw.c (enum exception_event_kind): Move to
4027         breakpoint.h.
4028         (print_mention_exception_catchpoint): Output text as a single
4029         message.
4030         (catch_exception_command_1): Rename to...
4031         (catch_exception_event): ...this, make non-static, update header
4032         command, and change some parameter types.
4033         (catch_catch_command): Update for changes to
4034         catch_exception_command_1.
4035         (catch_throw_command): Likewise.
4036         (catch_rethrow_command): Likewise.
4037         * breakpoint.c (enum exception_event_kind): Delete.
4038         * breakpoint.h (enum exception_event_kind): Moved here from
4039         break-catch-throw.c.
4040         (catch_exception_event): Declare.
4041         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4042         (mi_cmd_catch_throw): New function.
4043         (mi_cmd_catch_rethrow): New function.
4044         (mi_cmd_catch_catch): New function.
4045         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4046         'catch-catch' entries.
4047         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4048         (mi_cmd_catch_rethrow): Declare.
4049         (mi_cmd_catch_catch): Declare.
4050
4051 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * annotate.c (annotate_source_line): Change return type to void,
4054         update implementation to match.
4055         * annotate.h (annotate_source_line): Change return type to void,
4056         update header comment.
4057         * stack.c (print_frame_info): Don't change what frame information
4058         is printed based on whether annotations are on or not.
4059
4060 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4061
4062         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4063         (annotate_source): Make static.
4064         (annotate_source_line): Moved from source.c and renamed from
4065         identify_source_line.  Update the return type.
4066         * annotate.h (annotate_source): Delete declaration.
4067         (annotate_source_line): Declaration moved from source.h, and
4068         renamed from identify_source_line.  Return type updated.
4069         * source.c (identify_source_line): Moved to annotate.c and renamed
4070         to annotate_source_line.
4071         (info_line_command): Remove check of annotation_level.
4072         * source.h (identify_source_line): Move declaration to annotate.h
4073         and rename to annotate_source_line.
4074         * stack.c: Add 'annotate.h' include.
4075         (print_frame_info): Remove check of annotation_level before
4076         calling annotate_source_line.
4077
4078 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * source-cache.c (source_cache::get_plain_source_lines): Use
4081         open_source_file_with_line_charpos instead of just
4082         open_source_file, remove call to find_source_lines.
4083         (source_cache::get_source_lines): Likewise.
4084         * source.c (find_source_lines): Make static.
4085         (get_filename_and_charpos): Renamed into...
4086         (open_source_file_with_line_charpos): ..this along with changes to
4087         return a scoped_fd, and some other minor clean ups.
4088         (identify_source_line): Use open_source_file_with_line_charpos.
4089         (search_command_helper): Use open_source_file_with_line_charpos
4090         instead of just open_source_file, remove call to
4091         find_source_lines.
4092         * source.h (open_source_file_with_line_charpos): Declare new
4093         function.
4094         (find_source_lines): Delete declaration.
4095
4096 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * source.c (get_filename_and_charpos): Remove fullname
4099         parameter.
4100         (identify_source_line): Update call to get_filename_and_charpos.
4101
4102 2019-06-14  Tom Tromey  <tromey@adacore.com>
4103
4104         PR gdb/24502:
4105         * ui-style.h (skip_ansi_escape): Update comment.
4106         * ui-file.h (class no_terminal_escape_file): New class.
4107         * ui-file.c (no_terminal_escape_file::write)
4108         (no_terminal_escape_file::puts): New methods.
4109         * cli/cli-logging.c (handle_redirections): Use
4110         no_terminal_escape_file.
4111
4112 2019-06-14  Tom Tromey  <tromey@adacore.com>
4113
4114         * NEWS: Move convenience variable news above Python news.
4115
4116 2019-06-14  Tom Tromey  <tom@tromey.com>
4117
4118         * gnulib: Move directory to top-level.
4119         * configure.ac: Don't configure gnulib.
4120         * configure: Rebuild.
4121         * common/common-defs.h: Use new path to gnulib.
4122         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4123         (GNULIB_H): Remove.
4124         (INCGNU): Look in new gnulib location.
4125         (HFILES_NO_SRCDIR): Remove gnulib files.
4126         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4127         (generated_files): Remove GNULIB_H.
4128         ($(LIBGNU), all-lib): Remove targets.
4129         (distclean): Don't mention GNULIB_BUILDDIR.
4130         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4131
4132 2019-06-14  Tom Tromey  <tromey@adacore.com>
4133
4134         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4135         Warn if symbol file does not provide any symbols.
4136
4137 2019-06-14  Tom Tromey  <tromey@adacore.com>
4138
4139         * source.c (find_and_open_source): Respect basenames_may_differ.
4140
4141 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * annotate.c (annotate_breakpoints_invalid): Make use of
4144         scoped_restore_terminal_state.
4145         (annotate_frames_invalid): Likewise.
4146
4147 2019-06-14  Tom Tromey  <tromey@adacore.com>
4148
4149         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4150         allow assignment to an internalvar.
4151
4152 2019-06-14  Tom Tromey  <tromey@adacore.com>
4153
4154         * ada-lex.l: Allow "_" in attribute names.
4155
4156 2019-06-14  Tom Tromey  <tromey@adacore.com>
4157
4158         PR gdb/24653:
4159         * regcache.c (registers_changed): Don't call alloca.
4160         * top.c (execute_command): Don't call alloca.
4161
4162 2019-06-13  Pedro Alves  <palves@redhat.com>
4163
4164         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4165         'expression'.  When parsing an expression, error out if there's
4166         junk after "unlimited".
4167         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4168         (do_set_command): Adjust calls to is_unlimited_literal.
4169
4170 2019-06-13  Pedro Alves  <palves@redhat.com>
4171
4172         * compile/compile.c (make_compile_options_def_group): Add braces
4173         around array_view initializer.
4174         * thread.c (make_thread_apply_all_options_def_group)
4175         (make_thread_apply_all_options_def_group): Likewise.
4176
4177 2019-06-13  Pedro Alves  <palves@redhat.com>
4178
4179         * NEWS (New commands): Mention "maint test-options
4180         require-delimiter", "maint test-options unknown-is-error", "maint
4181         test-options unknown-is-operand" and "maint show
4182         test-options-completion-result".
4183         (New command options, command completion): New section.
4184         (Completion improvements): New section.
4185         Mention that you can abbreviate "unlimited".
4186
4187 2019-06-13  Pedro Alves  <palves@redhat.com>
4188
4189         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4190         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4191         * unittests/cli-utils-selftests.c (test_parse_flags)
4192         (test_parse_flags_qcs): Delete.
4193         (test_cli_utils): Don't call deleted functions.
4194
4195 2019-06-13  Pedro Alves  <palves@redhat.com>
4196
4197         * thread.c: Include "cli/cli-option.h".
4198         (tp_array_compar_ascending): Global.
4199         (tp_array_compar): Delete function.
4200         (tp_array_compar_ascending, tp_array_compar_descending): New
4201         functions.
4202         (ascending_option_def, qcs_flag_option_def)
4203         (thr_qcs_flags_option_defs)
4204         (make_thread_apply_all_options_def_group)
4205         (make_thread_apply_options_def_group): New.
4206         (thread_apply_all_command): Use gdb::option::process_options.
4207         (thread_apply_command_completer)
4208         (thread_apply_all_command_completer): New.
4209         (thread_apply_command): Use gdb::option::process_options.
4210         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4211         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4212         to generate help text of "thread apply".  Adjust "taas"'s help.
4213         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4214         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4215
4216 2019-06-13  Pedro Alves  <palves@redhat.com>
4217
4218         * thread.c (thread_apply_command): Check for invalid TID with
4219         isdigit instead of !isalpha.
4220
4221 2019-06-13  Pedro Alves  <palves@redhat.com>
4222
4223         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4224         (validate_flags_qcs): New.
4225         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4226         (validate_flags_qcs): Declare.
4227         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4228         (make_frame_apply_options_def_group): New.
4229         (frame_apply_command_count): Process options with
4230         gdb::option::process_options.
4231         (frame_apply_completer): New.
4232         (frame_apply_level_completer, frame_apply_all_completer)
4233         (frame_apply_completer): New.
4234         (_initialize_stack): Update help of "frame apply", "frame apply
4235         level", "frame apply all" and "faas" to mention supported options
4236         and install command completers.
4237         * stack.h (frame_apply_all_completer): Declare.
4238         * thread.c: Include "stack.h".
4239         (tfaas_command): Add "--".
4240         (_initialize_thread): Update help "tfaas" to mention supported
4241         options and install command completer.
4242
4243 2019-06-13  Pedro Alves  <palves@redhat.com>
4244
4245         * completer.c (complete_nested_command_line): New.
4246         (gdb_completion_word_break_characters_throw): Add assertion.
4247         * completer.h (complete_nested_command_line): Declare.
4248
4249 2019-06-13  Pedro Alves  <palves@redhat.com>
4250
4251         * stack.c (parse_backtrace_qualifiers): New.
4252         (backtrace_command): Use it.
4253         (backtrace_command_completer): Complete on qualifiers.
4254
4255 2019-06-13  Pedro Alves  <palves@redhat.com>
4256
4257         * frame.c: Include "cli/cli-option.h.
4258         (user_set_backtrace_options): New.
4259         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4260         Delete.
4261         (get_prev_frame): Adjust.
4262         (boolean_option_def, uinteger_option_def)
4263         (set_backtrace_option_defs): New.
4264         (_initialize_frame): Adjust and use
4265         gdb::option::add_setshow_cmds_for_options to install "set
4266         backtrace past-main" and "set backtrace past-entry".
4267         * frame.h: Include "cli/cli-option.h".
4268         (struct frame_print_options): Forward declare.
4269         (print_frame_arguments_all, print_frame_arguments_scalars)
4270         (print_frame_arguments_none): Declare.
4271         (print_entry_values): Delete declaration.
4272         (struct frame_print_options, user_frame_print_options): New.
4273         (struct set_backtrace_options): New.
4274         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4275         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4276         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4277         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4278         (list_args_or_locals): Add frame_print_options parameter.
4279         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4280         * python/py-framefilter.c (enumerate_args): Pass down
4281         USER_FRAME_PRINT_OPTIONS.
4282         * stack.c: Include "cli/cli-option.h".
4283         (print_frame_arguments_all, print_frame_arguments_scalars)
4284         (print_frame_arguments_none): Declare.
4285         (print_raw_frame_arguments, print_entry_values): Delete.
4286         (user_frame_print_options): New.
4287         (boolean_option_def, enum_option_def, frame_print_option_defs):
4288         New.
4289         (struct backtrace_cmd_options): New.
4290         (bt_flag_option_def): New.
4291         (backtrace_command_option_defs): New.
4292         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4293         (print_frame_arg, read_frame_arg, print_frame_args)
4294         (print_frame_info, print_frame): Add frame_print_options parameter
4295         and use it.
4296         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4297         (backtrace_command_1): Add frame_print_options and
4298         backtrace_cmd_options parameters and use them.
4299         (make_backtrace_options_def_group): New.
4300         (backtrace_command): Process command options with
4301         gdb::option::process_options.
4302         (backtrace_command_completer): New.
4303         (_initialize_stack): Extend "backtrace"'s help to mention
4304         supported options.  Install completer for "backtrace".
4305         Install some settings commands with add_setshow_cmds_for_options.
4306
4307 2019-06-13  Pedro Alves  <palves@redhat.com>
4308
4309         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4310         and that "set/show print raw frame-arguments" are now deprecated.
4311
4312         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4313         command.
4314         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4315         * stack.c (_initialize_stack): Install "set/show print
4316         raw-frame-arguments", and deprecate "set/show print raw
4317         frame-arguments".
4318         * valprint.c (_initialize_valprint): Deprecate "set/show print
4319         raw".
4320
4321 2019-06-13  Pedro Alves  <palves@redhat.com>
4322
4323         * compile/compile.c (struct compile_options): New.
4324         (compile_flag_option_def, compile_command_option_defs)
4325         (make_compile_options_def_group): New.
4326         (compile_file_command): Handle options with
4327         gdb::option::process_options.
4328         (compile_file_command_completer): New function.
4329         (compile_code_command): Handle options with
4330         gdb::option::process_options.
4331         (compile_code_command_completer): New function.
4332         (_initialize_compiler): Install completers for "compile code" and
4333         "compile file".  Mention available options in "compile code" and
4334         "compile code"'s help.
4335         * completer.c (advance_to_completion_word): New, factored out from
4336         ...
4337         (advance_to_expression_complete_word_point): ... this.
4338         (advance_to_filename_complete_word_point): New.
4339         * completer.h (advance_to_filename_complete_word_point): New
4340         declaration.
4341
4342 2019-06-13  Pedro Alves  <palves@redhat.com>
4343
4344         * compile/compile.c: Include "cli/cli-option.h".
4345         (compile_print_value): Scope data pointer is now a
4346         value_print_options pointer; adjust.
4347         (compile_print_command): Process options.  Scope data pointer is
4348         now a value_print_options pointer; adjust.
4349         (_initialize_compile): Update "compile print"'s help to include
4350         supported options.  Install a completer for "compile print".
4351         * cp-valprint.c (show_vtblprint, show_objectprint)
4352         (show_static_field_print): Delete.
4353         (_initialize_cp_valprint): Don't install "set print
4354         static-members", "set print vtbl", "set print object" here.
4355         * printcmd.c: Include "cli/cli-option.h" and
4356         "common/gdb_optional.h".
4357         (print_command_parse_format): Rework to fill in a
4358         value_print_options instead of a format_data.
4359         (print_value): Change parameter type from format_data pointer to
4360         value_print_options reference.  Adjust.
4361         (print_command_1): Process options.  Adjust to pass down a
4362         value_print_options.
4363         (print_command_completer): New.
4364         (_initialize_printcmd): Install print_command_completer as
4365         handle_brkchars completer for the "print" command.  Update
4366         "print"'s help to include supported options.
4367         * valprint.c: Include "cli/cli-option.h".
4368         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4369         here from cp-valprint.c.
4370         (boolean_option_def, uinteger_option_def)
4371         (value_print_option_defs, make_value_print_options_def_group):
4372         New.  Use gdb::option::add_setshow_cmds_for_options to install
4373         "set print elements", "set print null-stop", "set print repeats",
4374         "set print pretty", "set print union", "set print array", "set
4375         print address", "set print symbol", "set print array-indexes".
4376         * valprint.h: Include <string> and "cli/cli-option.h".
4377         (make_value_print_options_def_group): Declare.
4378         (print_value): Change parameter type from format_data pointer to
4379         value_print_options reference.
4380         (print_command_completer): Declare.
4381
4382 2019-06-13  Pedro Alves  <palves@redhat.com>
4383
4384         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4385         (COMMON_SFILES): Add maint-test-settings.c.
4386         * cli/cli-decode.c (boolean_enums): New global, factored out from
4387         ...
4388         (add_setshow_boolean_cmd): ... here.
4389         * cli/cli-decode.h (boolean_enums): Declare.
4390         * cli/cli-option.c: New file.
4391         * cli/cli-option.h: New file.
4392         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4393         factored out from ...
4394         (parse_cli_boolean_value(const char *)): ... this.
4395         (is_unlimited_literal): Change parameter type to pointer to
4396         pointer.  Adjust and advance ARG pointer.
4397         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4398         (parse_cli_var_enum): New, factored out from ...
4399         (do_set_command): ... this.  Adjust.
4400         * cli/cli-setshow.h (parse_cli_boolean_value)
4401         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4402         (parse_cli_var_enum): Declare.
4403         * cli/cli-utils.c: Include "cli/cli-option.h".
4404         (get_ulongest): New.
4405         * cli/cli-utils.h (get_ulongest): Declare.
4406         (check_for_argument): New overloads.
4407         * maint-test-options.c: New file.
4408
4409 2019-06-13  Pedro Alves  <palves@redhat.com>
4410
4411         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4412         parse a range if "-" is at the end of the string.
4413
4414 2019-06-13  Pedro Alves  <palves@redhat.com>
4415
4416         * cli/cli-setshow.c (parse_auto_binary_operation)
4417         (parse_cli_boolean_value): Don't allow "o".
4418
4419 2019-06-13  Pedro Alves  <palves@redhat.com>
4420
4421         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4422         * NEWS: Mention maint test-settings KIND.
4423         * maint-test-settings.c: New file.
4424
4425 2019-06-13  Pedro Alves  <palves@redhat.com>
4426
4427         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4428         completer.
4429         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4430         "set" completers.
4431
4432 2019-06-13  Pedro Alves  <palves@redhat.com>
4433
4434         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4435         after item.
4436
4437 2019-06-13  Pedro Alves  <palves@redhat.com>
4438
4439         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4440
4441 2019-06-13  Pedro Alves <palves@redhat.com>
4442
4443         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4444         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4445         call.
4446         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4447         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4448         calls.
4449         (check_for_argument): Skip spaces after argument.
4450
4451 2019-06-13  Pedro Alves  <palves@redhat.com>
4452
4453         * thread.c (thread_apply_command): Adjust TID parsing.
4454         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4455         detected before end of string.
4456         (tid_is_in_list): Error out if LIST is invalid.
4457
4458 2019-06-13  Pedro Alves  <palves@redhat.com>
4459
4460         * completer.c (complete_line_internal_1): Rewind completion word
4461         point.
4462         (completion_tracker::advance_custom_word_point_by): Change
4463         parameter type to int.
4464         * completer.h (completion_tracker::advance_custom_word_point_by):
4465         Likewise.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * completer.c (advance_to_completion_word): Handle delimiters.
4470
4471 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4472
4473         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4474
4475 2019-06-11  Tom Tromey  <tom@tromey.com>
4476
4477         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4478         (xmalloc_failed): Move to alloc.c.
4479         * alloc.c: New file.
4480         * Makefile.in (COMMON_SFILES): Add alloc.c.
4481
4482 2019-06-11  Tom Tromey  <tom@tromey.com>
4483
4484         * nat/linux-waitpid.c: Don't include server.h.
4485         (linux_debug): Remove.
4486         (my_waitpid): Update.
4487
4488 2019-06-11  Tom Tromey  <tromey@adacore.com>
4489
4490         * infcall.c (_initialize_infcall): Remove trailing newline from
4491         help.
4492         * user-regs.c (_initialize_user_regs): Remove trailing newline
4493         from help.
4494         * typeprint.c (_initialize_typeprint): Remove trailing newline
4495         from help.
4496         * reverse.c (_initialize_reverse): Remove trailing newlines from
4497         help.
4498         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4499         from help.
4500         * language.c (add_set_language_command): Remove trailing newline
4501         from help.
4502         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4503         help.
4504         * disasm.c (_initialize_disasm): Remove trailing newline from
4505         help.
4506         * top.c (init_main): Remove trailing newline from help.
4507         * interps.c (_initialize_interpreter): Remove trailing newline
4508         from help.
4509         * btrace.c (_initialize_btrace): Remove trailing newlines from
4510         help.
4511         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4512         from help.
4513         * python/python.c (_initialize_python): Remove trailing newline
4514         from help.
4515         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4516         help.
4517         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4518         from help.  Reformat some text.
4519         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4520         from help.
4521         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4522         newline from help.
4523
4524 2019-06-11  Tom Tromey  <tromey@adacore.com>
4525
4526         * darwin-nat.c (darwin_decode_exception_message)
4527         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4528
4529 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * valops.c (value_slice): Check for not allocated or not
4532         associated values.
4533
4534 2019-06-10  Tom de Vries  <tdevries@suse.de>
4535
4536         PR gdb/24618
4537         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4538         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4539         invalid.
4540
4541 2019-06-10  Tom de Vries  <tdevries@suse.de>
4542
4543         PR gdb/24611
4544         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4545         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4546
4547 2019-06-10  Tom de Vries  <tdevries@suse.de>
4548
4549         PR symtab/24545
4550         * symtab.c (struct demangled_name_entry): Add language field.
4551         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4552         static minimal symbol".  Set and use language field.
4553
4554 2019-06-10  Tom Tromey  <tromey@adacore.com>
4555
4556         * ada-lang.c (_initialize_ada_language): Update help text.
4557
4558 2019-06-10  Tom Tromey  <tromey@adacore.com>
4559
4560         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4561         with a newline.
4562         * guile/guile.c (handle_boot_error): Don't end warning with a
4563         newline.
4564         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4565         warning with a newline.
4566         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4567         newline.
4568         (s12z_frame_cache): Likewise.
4569         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4570         a newline.
4571         * solib-svr4.c (disable_probes_interface): Don't end warning with
4572         a newline.
4573         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4574         newline.
4575         * python/python.c (do_finish_initialization): Don't end warning
4576         with a newline.
4577
4578 2019-06-10  Tom Tromey  <tom@tromey.com>
4579
4580         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4581         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4582         gdbpy_enter.
4583
4584 2019-06-10  Tom Tromey  <tromey@adacore.com>
4585
4586         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4587         data.
4588         (elf_new_init): Don't call stabsread_new_init.
4589         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4590         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4591         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4592
4593 2019-06-10  Tom de Vries  <tdevries@suse.de>
4594
4595         PR symtab/16264
4596         PR symtab/24517
4597         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4598
4599 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4600
4601         * source.c (find_and_open_source): Also rewrite relative file
4602         names.
4603
4604 2019-04-26  Amos Bird  <amosbird@gmail.com>
4605
4606         * annotate.c (annotate_thread_exited): Add "thread-exited"
4607         annotation.
4608
4609 2019-06-06  Tom Tromey  <tromey@adacore.com>
4610
4611         * maint.h (class scoped_command_stats): Use
4612         DISABLE_COPY_AND_ASSIGN.
4613         <print_time>: New method.
4614         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4615         print_time.
4616         (scoped_command_stats::print_time): New method.
4617
4618 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4621         instructions of lengths 6 or 8 bytes.
4622
4623 2019-06-04  Pedro Alves  <palves@redhat.com>
4624
4625         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4626
4627         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4628         * breakpoint.c (condition_completer): Likewise.
4629         * cli/cli-dump.c (scan_expression): Likewise.
4630         * common/filestuff.c (mkdir_recursive): Likewise.
4631         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4632         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4633         (gdb_abspath): Likewise.
4634         * compile/compile-cplus-types.c
4635         (compile_cplus_instance::decl_name): Likewise.
4636         * completer.c (complete_explicit_location):
4637         (signal_completer, reg_or_group_completer_1): Likewise.
4638         * cp-support.c (cp_remove_params_if_any): Likewise.
4639         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4640         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4641         * infcmd.c (strip_bg_char): Likewise.
4642         * linespec.c (copy_token_string): Likewise.
4643         * mi/mi-main.c (output_cores): Likewise.
4644         * psymtab.c (psymtab_search_name):
4645         * symfile.c (test_set_ext_lang_command): Likewise.
4646         * target.c (target_fileio_read_stralloc): Likewise.
4647         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4648         * value.c (complete_internalvar): Likewise.
4649
4650 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4651
4652         Add objfile property to gdb.Type.
4653         * NEWS: Mention Python API addition.
4654         * python/py-type.c (typy_get_objfile): New method.
4655
4656 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4657
4658         * NEWS: Mention the new set|show style [title|highlight].
4659         Mention changes to "show style", "help" and "apropos".
4660
4661 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4662
4663         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4664         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4665         instead of print_help_for_command.
4666         (print_doc_of_command): New function.
4667         (help_list): Add 'apropos -v word' suggestion.
4668         (print_help_for_command): Style the command name using title style.
4669         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4670         (_initialize_cli_cmds): Describe -v in apropos_command help.
4671
4672 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4673
4674         * cli/cli-style.h (cli_style_option): Add name in constructor,
4675         add m_name class member, add constructor with intensity,
4676         add name class function.
4677         (cli_style_option::add_setshow_commands): Remove name argument.
4678         (highlight_style, title_style): New styles.
4679         * cli/cli-style.c (do_show): New function that shows a style
4680         characteristic styling the style name with itself.
4681         (set_style_name): New function.
4682         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4683         Update all callers according to the changes in cli/cli-style.h.
4684         * utils.h (fputs_highlighted): New function.
4685         * utils.c (fputs_highlighted): Likewise.
4686
4687 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4688
4689         * NEWS: Mention new pipe command and new convenience variables.
4690
4691 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4692
4693         * cli/cli-cmds.c (pipe_command): New function.
4694         (_initialize_cli_cmds): Call add_com for pipe_command.
4695         Define | as an alias for pipe.
4696         (exit_status_set_internal_vars): New function.
4697         (shell_escape): Call exit_status_set_internal_vars.
4698         cli/cli-decode.c (find_command_name_length): Recognize | as
4699         a single character command.
4700
4701 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4702
4703         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4704         top.c (execute_command_to_ui_file): New function, mostly a copy
4705         of execute_command_to_string.
4706         (execute_command_to_string): Implement by calling
4707         execute_command_to_ui_file.
4708
4709 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4710
4711         * top.h (saved_command_line): Remove declaration.
4712         * top.c (previous_saved_command_line, previous_repeat_arguments):
4713         New variables.
4714         (saved_command_line): Make static, define together with other
4715         'repeat variables'.
4716         (dont_repeat): Clear repeat_arguments.
4717         (repeat_previous, get_saved_command_line, save_command_line):
4718         New functions.
4719         (gdb_init): Initialize saved_command_line
4720         and previous_saved_command_line.
4721         * main.c (captured_main_1): Remove saved_command_line initialization.
4722         * event-top.c (handle_line_of_input): Update to use
4723         the new 'repeat' related functions instead of direct access to
4724         saved_command_line.
4725         * command.h (repeat_previous, get_saved_command_line,
4726         save_command_line): New declarations.
4727         (dont_repeat): Add comment.
4728
4729 2019-05-30  Tom Tromey  <tromey@adacore.com>
4730
4731         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4732         Fix comment.
4733         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4734
4735 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4736
4737         PR cli/24587
4738         * completer.c (complete): Initialize variable word.
4739
4740 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4741
4742         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4743         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4744         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4745         'body' is NULL to the outter 'if', protecting the '!is_define'
4746         situation as well.
4747
4748 2019-05-29  Tom Tromey  <tromey@adacore.com>
4749
4750         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4751         (dwarf_unknown): New function.
4752         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4753         (dwarf_type_encoding_name): Use dwarf_unknown.
4754
4755 2019-05-29  Tom Tromey  <tromey@adacore.com>
4756
4757         PR c++/20020:
4758         * cp-valprint.c (cp_print_value_fields): Call
4759         cp_print_static_field inside "try".
4760
4761 2019-05-29  Tom Tromey  <tromey@adacore.com>
4762
4763         * inflow.c (struct terminal_info): Add default operator=.
4764         * configure: Rebuild.
4765         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4766         -Wdeprecated-copy-dtor, -Wredundant-move.
4767
4768 2019-05-29  Tom Tromey  <tromey@adacore.com>
4769
4770         * NEWS: Add entry.
4771         * infcmd.c (print_return_value_1): Handle finish_print
4772         option.
4773         (show_print_finish): New function.
4774         (_initialize_infcmd): Add "set/show print finish" commands.
4775         * valprint.c (user_print_options): Initialize new member.
4776         * valprint.h (struct value_print_options) <finish_print>: New
4777         member.
4778
4779 2019-05-28  Tom Tromey  <tromey@adacore.com>
4780
4781         * ada-lang.c (ada_remove_Xbn_suffix)
4782         (find_old_style_renaming_symbol)
4783         (parse_old_style_renaming): Remove.
4784         (ada_find_renaming_symbol): Don't call
4785         find_old_style_renaming_symbol.
4786         (ada_is_renaming_symbol): Rename from
4787         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4788         bool.  Now static.
4789         (ada_read_var_value): Update and simplify.
4790         * ada-exp.y (write_var_or_type): Remove old code.
4791
4792 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4793
4794         * event-top.c: Remove include comment.
4795         * inflow.c (class scoped_ignore_sigttou): Move from here...
4796         * inflow.h (class scoped_ignore_sigttou): ...to here.
4797         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4798         * top.c:  Remove include comment.
4799
4800 2019-05-27  Tom Tromey  <tom@tromey.com>
4801
4802         * NEWS: Fix typo.
4803
4804 2019-05-22  Tom Tromey  <tromey@adacore.com>
4805
4806         * target.c (target_follow_exec): Constify parameter.
4807         * target-delegates.c: Rebuild.
4808         * remote.c (remote_target::follow_exec): Constify parameter.
4809         * infrun.c (follow_exec): Constify parameter.
4810         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4811         (target_follow_exec): Likewise.
4812
4813 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4814
4815         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4816         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4817
4818 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4819
4820         * NEWS: Add debugredirect and testsuite sections.
4821
4822 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4823
4824         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4825         target descriptions using exclusively floating point register name
4826         aliases.
4827
4828 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         PR gdb/18644:
4831         * f-lang.c (build_fortran_types): Handle the case where
4832         gdbarch_floatformat_for_type returns a nullptr.
4833
4834 2019-05-21  Tom de Vries  <tdevries@suse.de>
4835
4836         PR cli/24587
4837         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4838
4839 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         PR gdb/18644:
4842         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4843         16-byte floats.
4844         * i386-tdep.c (i386_floatformat_for_type): Use
4845         floatformats_ia64_quad for the 16-byte floating point component
4846         within a fortran 32-byte complex number.
4847
4848 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4849
4850         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4851         delete default constructor.
4852         (find_partial_die): Update to return const struct.
4853         (partial_die_parent_scope): Move variable declaration into scope
4854         of its use and change its type to auto.
4855         (guess_partial_die_structure_name): Likewise.
4856         (partial_die_info::fixup): Likewise.
4857
4858 2019-05-17  Tom Tromey  <tromey@adacore.com>
4859
4860         * source.c (find_and_open_source): Remove cast.
4861
4862 2019-05-17  Tom Tromey  <tromey@adacore.com>
4863
4864         * annotate.c (annotate_source): Make "filename" const.
4865         * annotate.h (annotate_source): Use const.
4866
4867 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4868
4869         * disasm.c (set_disassembler_options): Send errors to stderr.
4870
4871 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4872
4873         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4874         (cli_interp_base::set_logging): Check debug_redirect.
4875         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4876         * cli/cli-logging.c (debug_redirect): Add static variable.
4877         (pop_output_files): Add default param.
4878         (handle_redirections): Print debug setting.
4879         (show_logging_command): Likewise.
4880         (_initialize_cli_logging): Add debugredirect command.
4881         * interps.c (current_interp_set_logging): Add debug_redirect
4882         parameter.
4883         * interps.h (set_logging): Add debug_redirect parameter.
4884         (current_interp_set_logging): Likewise.
4885         * mi/mi-common.h: Likewise.
4886         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4887
4888 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4889             Tom Tromey  <tromey@adacore.com>
4890
4891         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4892         directly.
4893         * cli/cli-interp.h (make_logging_output): Remove declaration.
4894         * cli/cli-logging.c (make_logging_output): Remove function.
4895         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4896         directly.
4897         * ui-file.c (tee_file::tee_file): Remove bools.
4898         (tee_file::~tee_file): Remove deletes.
4899         * ui-file.h (tee_file): Remove bools.
4900
4901 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4902
4903         * mi/mi-cmds.h (mi_cmd_complete): New function.
4904         * mi/mi-main.c (mi_cmd_complete): Likewise.
4905         * mi/mi-cmds.c: Define new MI command -complete.
4906         * NEWS: Mention new -complete command.
4907
4908 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4909
4910         * completer.h (complete): New function.
4911         * completer.c (complete): Likewise.
4912         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4913         function defined in completer.h.
4914
4915 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4916
4917         * MAINTAINERS (Write After Approval): Add myself.
4918
4919 2019-05-17  Tom de Vries  <tdevries@suse.de>
4920
4921         PR gdb/24094
4922         * dwarf2read.c (struct cu_partial_die_info): New struct.
4923         (find_partial_die): Return cu_partial_die_info.
4924         (partial_die_parent_scope, guess_partial_die_structure_name)
4925         (partial_die_info::fixup): Handle new return type of find_partial_die.
4926
4927 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4928
4929         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4930         "std::string", simplifying the algorithm.
4931
4932 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4933
4934         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4935         (stap_static_probe_ops::get_probes): Likewise.
4936
4937 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4938
4939         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4940         '-')" and "else if".
4941         (stap_parse_single_operand): Join checks for
4942         "gdbarch_stap_parse_special_token_p" and
4943         "gdbarch_stap_parse_special_token" in the same "if" statement.
4944         Invert check when verifying for operation on register
4945         displacement.
4946
4947 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4948
4949         * stap-probe.c (stap_get_opcode): Update comment.
4950         (stap_get_expected_argument_type): Likewise.
4951         (handle_stap_probe): Likewise.
4952
4953 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4954
4955         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4956         return type to 'bool'.  Adjust comment.  Use 'bool' when
4957         appropriate.
4958         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4959         * stap-probe.c (stap_parse_argument_1): Likewise.
4960         (stap_is_operator): Likewise.
4961         (stap_is_generic_prefix): Likewise.
4962         (stap_is_register_prefix): Likewise.
4963         (stap_is_register_indirection_prefix): Likewise.
4964         (stap_is_integer_prefix): Likewise.
4965         (stap_generic_check_suffix): Likewise.
4966         (stap_check_integer_suffix): Likewise.
4967         (stap_check_register_suffix): Likewise.
4968         (stap_check_register_indirection_suffix): Likewise.
4969         (stap_parse_register_operand): Likewise.
4970         (stap_parse_single_operand): Likewise.
4971         (stap_parse_argument_1): Likewise.
4972         (stap_probe::get_argument_count): Likewise.
4973         (stap_is_operator): Likewise.
4974
4975 2019-05-16  Tom Tromey  <tromey@adacore.com>
4976
4977         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4978         keyword to foreach.
4979
4980 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4981
4982         * linux-thread-db.c (try_thread_db_load_1): Change return type
4983         to bool.
4984         (try_thread_db_load): Likewise.
4985         (try_thread_db_load_from_pdir_1): Likewise.
4986         (try_thread_db_load_from_pdir): Likewise.
4987         (try_thread_db_load_from_sdir): Likewise.
4988         (try_thread_db_load_from_dir): Likewise.
4989         (thread_db_load_search): Likewise.
4990         (has_libpthread): Likewise.
4991         (thread_db_load): Likewise.
4992
4993 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4994
4995         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4996         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4997         NULL, and complain/return if that's the case.
4998
4999 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5000
5001         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5002         (advance, posn, abstract_read_memory): New functions.
5003         [struct mem_read_abstraction]: New struct.
5004         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5005
5006 2019-05-14  Tom Tromey  <tromey@adacore.com>
5007
5008         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5009         value is not lval_memory.
5010
5011 2019-05-14  Tom Tromey  <tromey@adacore.com>
5012
5013         * solib.c (info_sharedlibrary_command): Style the file name.
5014
5015 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5016
5017         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5018         (aarch64_vnv_type): Likewise.
5019         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5020         * common/tdesc.c: Likewise.
5021         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5022         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5023         * features/aarch64-fpu.xml: Add ieee half view.
5024         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5025         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5026         * gdbtypes.h (struct builtin_type): Likewise.
5027         (struct objfile_type): Likewise.
5028
5029 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5030
5031         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5032         typo.
5033         * location.h (string_to_event_location): Likewise.
5034
5035 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5036
5037         GDB 8.3 released.
5038
5039 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5040
5041         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5042         New variable declaration.
5043         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5044         New variable.
5045         (print_one_breakpoint): Use ui_out::test_flags and new global
5046         variable to compute use_fixed_output.
5047         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5048         Remove.
5049         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5050         (mi_multi_location_breakpoint_output_fixed): Remove.
5051         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5052         new variable.
5053         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5054         fix_multi_location_breakpoint_output flag if version >= 3.
5055         * ui-out.h (enum ui_out_flag)
5056         <fix_multi_location_breakpoint_output>: New enumerator.
5057
5058 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5059
5060         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5061
5062 2019-05-10  Tom Tromey  <tromey@adacore.com>
5063
5064         * ada-lang.c (catch_ada_completer): New function.
5065         (_initialize_ada_language): Use it.
5066
5067 2019-05-10  Tom Tromey  <tromey@adacore.com>
5068
5069         * thread.c (print_thread_info): Make "requested_threads" const.
5070         * gdbthread.h (print_thread_info): Make "requested_threads"
5071         const.
5072         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5073         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5074
5075 2019-05-08  Tom Tromey  <tom@tromey.com>
5076
5077         * gdbtypes.c (objfile_type_data): Change type.
5078         (objfile_type, _initialize_gdbtypes): Update.
5079
5080 2019-05-08  Tom Tromey  <tom@tromey.com>
5081
5082         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5083         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5084         (_initialize_dwarf2_frame): Update.
5085
5086 2019-05-08  Tom Tromey  <tom@tromey.com>
5087
5088         * objc-lang.c (objc_objfile_data): Change type.
5089         (find_methods): Update.
5090         (_initialize_objc_lang): Remove.
5091
5092 2019-05-08  Tom Tromey  <tom@tromey.com>
5093
5094         * stabsread.c (rs6000_builtin_type_data): Change type.
5095         (rs6000_builtin_type, _initialize_stabsread): Update.
5096
5097 2019-05-08  Tom Tromey  <tom@tromey.com>
5098
5099         * mips-tdep.c (mips_pdr_data): Remove.
5100         (_initialize_mips_tdep): Update.
5101
5102 2019-05-08  Tom Tromey  <tom@tromey.com>
5103
5104         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5105         (hppa_init_objfile_priv_data, read_unwind_info)
5106         (find_unwind_entry, _initialize_hppa_tdep): Update.
5107
5108 2019-05-08  Tom Tromey  <tom@tromey.com>
5109
5110         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5111         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5112         on obstack.
5113         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5114
5115 2019-05-08  Tom Tromey  <tom@tromey.com>
5116
5117         * mdebugread.c (basic_type_data): Change type.
5118         (basic_type, _initialize_mdebugread): Update.
5119
5120 2019-05-08  Tom Tromey  <tom@tromey.com>
5121
5122         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5123
5124 2019-05-08  Tom Tromey  <tom@tromey.com>
5125
5126         * nto-tdep.c (nto_inferior_data_reg): Change type.
5127         (nto_inferior_data): Update.
5128         (nto_inferior_data_cleanup, nto_new_inferior_data)
5129         (_initialize_nto_tdep): Remove.
5130         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5131
5132 2019-05-08  Tom Tromey  <tom@tromey.com>
5133
5134         * ada-lang.c (struct ada_inferior_data): Add initializers.
5135         (ada_inferior_data): Change type.
5136         (ada_inferior_data_cleanup): Remove.
5137         (get_ada_inferior_data, ada_inferior_exit)
5138         (struct ada_pspace_data): Add initializers, destructor.
5139         (ada_pspace_data_handle): Change type.
5140         (get_ada_pspace_data): Update.
5141         (ada_pspace_data_cleanup): Remove.
5142
5143 2019-05-08  Tom Tromey  <tom@tromey.com>
5144
5145         * coffread.c (struct coff_symfile_info): Add initializers.
5146         (coff_objfile_data_key): Move lower.  Change type.
5147         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5148         Update.
5149         (coff_free_info): Remove.
5150
5151 2019-05-08  Tom Tromey  <tom@tromey.com>
5152
5153         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5154         (fbsd_pspace_data_handle): Move lower.  Change type.
5155         (get_fbsd_pspace_data): Update.
5156         (fbsd_pspace_data_cleanup): Remove.
5157         (_initialize_fbsd_tdep): Update.
5158
5159 2019-05-08  Tom Tromey  <tom@tromey.com>
5160
5161         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5162         (get_ada_tasks_pspace_data): Update.
5163         (ada_tasks_pspace_data_cleanup): Remove.
5164         (_initialize_tasks): Update.
5165         (ada_tasks_inferior_data_handle): Change type.
5166         (get_ada_tasks_inferior_data): Update.
5167         (ada_tasks_inferior_data_cleanup): Remove.
5168         (struct ada_tasks_pspace_data): Add initializers.
5169
5170 2019-05-08  Tom Tromey  <tom@tromey.com>
5171
5172         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5173         * symfile-debug.c (debug_sym_get_probes): Change type.
5174         * stap-probe.c (handle_stap_probe):
5175         (stap_static_probe_ops::get_probes): Change type.
5176         * probe.h (class static_probe_ops) <get_probes>: Change type.
5177         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5178         (parse_probes_in_pspace): Update.
5179         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5180         Update.
5181         (any_static_probe_ops::get_probes): Change type.
5182         * elfread.c (elfread_data): New typedef.
5183         (probe_key): Change type.
5184         (elf_get_probes): Likewise.  Update.
5185         (probe_key_free): Remove.
5186         (_initialize_elfread): Update.
5187         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5188         Change type.
5189         (dtrace_process_dof_probe, dtrace_process_dof)
5190         (dtrace_static_probe_ops::get_probe): Change type.
5191
5192 2019-05-08  Tom Tromey  <tom@tromey.com>
5193
5194         * xcoffread.c (struct xcoff_symfile_info): Rename from
5195         coff_symfile_info.  Add initializers.
5196         (xcoff_objfile_data_key): Move lower.  Change type.
5197         (XCOFF_DATA): Rewrite.
5198         (xcoff_free_info): Remove.
5199         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5200         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5201         (xcoff_initial_scan): Update.
5202
5203 2019-05-08  Tom Tromey  <tom@tromey.com>
5204
5205         * solib-svr4.c (struct svr4_info): Add initializers and
5206         destructor.
5207         <probes_table>: Now an htab_up.
5208         (solib_svr4_pspace_data): Change type.
5209         (free_probes_table): Simplify.
5210         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5211         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5212         (probes_table_remove_objfile_probes, register_solib_event_probe)
5213         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5214         (_initialize_svr4_solib): Update.
5215
5216 2019-05-08  Tom Tromey  <tom@tromey.com>
5217
5218         * remote.c (remote_pspace_data): Change type.
5219         (remote_pspace_data_cleanup): Remove.
5220         (get_remote_exec_file, set_pspace_remote_exec_file)
5221         (_initialize_remote): Update.
5222
5223 2019-05-08  Tom Tromey  <tom@tromey.com>
5224
5225         * breakpoint.c (breakpoint_objfile_key): Change type.
5226         (get_breakpoint_objfile_data): Update.
5227         (free_breakpoint_objfile_data): Remove.
5228         (_initialize_breakpoint): Update.
5229
5230 2019-05-08  Tom Tromey  <tom@tromey.com>
5231
5232         * linux-tdep.c (struct linux_info): Add initializers.
5233         (linux_inferior_data): Move.  Change type.
5234         (invalidate_linux_cache_inf): Update.
5235         (linux_inferior_data_cleanup): Remove.
5236         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5237
5238 2019-05-08  Tom Tromey  <tom@tromey.com>
5239
5240         * auxv.c (auxv_inferior_data): Move.  Change type.
5241         (auxv_inferior_data_cleanup): Remove.
5242         (invalidate_auxv_cache_inf): Rewrite.
5243         (get_auxv_inferior_data, _initialize_auxv): Update.
5244
5245 2019-05-08  Tom Tromey  <tom@tromey.com>
5246
5247         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5248         (symfile_debug_objfile_data_key): Change type.
5249         (symfile_debug_installed, debug_qf_has_symbols)
5250         (debug_qf_find_last_source_symtab)
5251         (debug_qf_forget_cached_source_info)
5252         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5253         (debug_qf_print_stats, debug_qf_dump)
5254         (debug_qf_expand_symtabs_for_function)
5255         (debug_qf_expand_all_symtabs)
5256         (debug_qf_expand_symtabs_with_fullname)
5257         (debug_qf_map_matching_symbols)
5258         (debug_qf_expand_symtabs_matching)
5259         (debug_qf_find_pc_sect_compunit_symtab)
5260         (debug_qf_map_symbol_filenames)
5261         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5262         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5263         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5264         (debug_sym_read_linetable, debug_sym_relocate): Update.
5265         (symfile_debug_free_objfile): Remove.
5266         (install_symfile_debug_logging, _initialize_symfile_debug):
5267         Update.
5268
5269 2019-05-08  Tom Tromey  <tom@tromey.com>
5270
5271         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5272         allocate_on_obstack.
5273         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5274         (get_dwarf2_per_objfile): Update.
5275         (set_dwarf2_per_objfile): Remove.
5276         (dwarf2_has_info, dwarf2_get_section_info): Update.
5277         (dwarf2_free_objfile): Remove.
5278         (_initialize_dwarf2_read): Update.
5279
5280 2019-05-08  Tom Tromey  <tom@tromey.com>
5281
5282         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5283         initializers.
5284         <unsupported_script_warning_printed,
5285         script_not_found_warning_printed>: Now bool.
5286         (auto_load_pspace_data): Change type.
5287         (~auto_load_pspace_info): Rename from
5288         auto_load_pspace_data_cleanup.
5289         (get_auto_load_pspace_data, init_loaded_scripts_info)
5290         (clear_section_scripts, maybe_print_unsupported_script_warning)
5291         (maybe_print_script_not_found_warning, _initialize_auto_load):
5292         Update.
5293
5294 2019-05-08  Tom Tromey  <tom@tromey.com>
5295
5296         * objfiles.c (objfile_pspace_info): Add destructor and
5297         initializers.
5298         (objfiles_pspace_data): Change type.
5299         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5300         (get_objfile_pspace_data): Update.
5301         (objfiles_bfd_data): Change type.
5302         (get_objfile_bfd_data): Update.
5303         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5304
5305 2019-05-08  Tom Tromey  <tom@tromey.com>
5306
5307         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5308         Change type.
5309         (get_catch_syscall_inferior_data): Update.
5310         (catch_syscall_inferior_data_cleanup): Remove.
5311         (_initialize_break_catch_syscall): Update.
5312
5313 2019-05-08  Tom Tromey  <tom@tromey.com>
5314
5315         * inflow.c (struct terminal_info): Add destructor and
5316         initializers.
5317         (inflow_inferior_data): Change type.
5318         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5319         (get_inflow_inferior_data, inflow_inferior_exit)
5320         (swap_terminal_info, _initialize_inflow): Update.
5321
5322 2019-05-08  Tom Tromey  <tom@tromey.com>
5323
5324         * target-dcache.c (target_dcache_cleanup): Remove.
5325         (target_dcache_aspace_key): Change type.
5326         (target_dcache_init_p, target_dcache_invalidate)
5327         (target_dcache_get, target_dcache_get_or_init)
5328         (_initialize_target_dcache): Update.
5329         * dcache.h (struct dcache_deleter): New.
5330
5331 2019-05-08  Tom Tromey  <tom@tromey.com>
5332
5333         * symtab.c (struct symbol_cache): Add destructor and
5334         initializers.
5335         (symbol_cache_key): Move.  Change type.
5336         (make_symbol_cache, free_symbol_cache): Remove.
5337         (get_symbol_cache): Update.
5338         (symbol_cache_cleanup): Remove.
5339         (ALL_PSPACES, symbol_cache_flush)
5340         (maintenance_print_symbol_cache)
5341         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5342         Update.
5343
5344 2019-05-08  Tom Tromey  <tom@tromey.com>
5345
5346         * symtab.c (struct main_info): Add destructor and initializers.
5347         (main_progspace_key): Move.  Change type.
5348         (get_main_info): Update.
5349         (main_info_cleanup): Remove.
5350         (_initialize_symtab): Update.
5351
5352 2019-05-08  Tom Tromey  <tom@tromey.com>
5353
5354         * registry.h (DECLARE_REGISTRY): Define the _key class.
5355
5356 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * NEWS: Merge two 'New commands' sections.
5359
5360 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5361
5362         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5363         parameter and use Ada language definition instead.
5364         (ada_val_print_ptr): Remove unused language parameter.
5365         (ada_val_print_num): Remove language parameter and use Ada language
5366         definition instead.
5367         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5368         parameter.
5369         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5370         parameter and use Ada language definition instead.
5371         (ada_val_print_1): Update all ada_val_print_xxx calls.
5372         Remove language parameter.
5373         (ada_val_print): Update ada_val_print_1 call.
5374
5375 2019-05-08  Tom Tromey  <tromey@adacore.com>
5376
5377         * remote.c (remote_hw_watchpoint_limit)
5378         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5379         Now static.
5380
5381 2019-05-08  Tom Tromey  <tromey@adacore.com>
5382
5383         * maint.c (_initialize_maint_cmds): Move initialization code to
5384         remote.c.
5385         (watchdog, show_watchdog): Move to remote.c.
5386         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5387         "watchdog" static.
5388         (_initialize_remote): Move initialization code from maint.c.
5389         * defs.h (watchdog): Don't declare.
5390
5391 2019-05-08  Tom Tromey  <tromey@adacore.com>
5392
5393         * tui/tui-interp.c: Include main.h.
5394         * interps.c: Include main.h.
5395         * main.h (interpreter_p): Declare.
5396         * defs.h (interpreter_p): Don't declare.
5397
5398 2019-05-08  Tom Tromey  <tromey@adacore.com>
5399
5400         * dwarf2loc.c: Include dwarf2read.h.
5401         * defs.h (read_unsigned_leb128): Don't declare.
5402         * dwarf2read.h (read_unsigned_leb128): Declare.
5403
5404 2019-05-08  Tom Tromey  <tromey@adacore.com>
5405
5406         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5407         method.
5408
5409 2019-05-08  Tom Tromey  <tromey@adacore.com>
5410
5411         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5412         when no wrap column is set.
5413
5414 2019-05-08  Tom Tromey  <tromey@adacore.com>
5415
5416         * c-lang.c (c_get_string): Handle non-C-style arrays.
5417
5418 2019-05-08  Tom Tromey  <tromey@adacore.com>
5419
5420         * typeprint.c (print_offset_data::update): Print the bit offset,
5421         not the number of bits remaining.
5422
5423 2019-05-08  Tom Tromey  <tromey@adacore.com>
5424
5425         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5426         padding at end of comment.
5427
5428 2019-05-08  Tom Tromey  <tromey@adacore.com>
5429
5430         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5431         Compare main types.
5432
5433 2019-05-06  Tom Tromey  <tom@tromey.com>
5434
5435         * common/scoped_mmap.c: Include common-defs.h.
5436         * common/scoped_mmap.h: Don't include config.h.
5437
5438 2019-05-04  Tom Tromey  <tom@tromey.com>
5439
5440         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5441         (struct aarch64_call_info): Add initializers.
5442         <si>: Now a std::vector.
5443         (pass_on_stack, aarch64_push_dummy_call): Update.
5444
5445 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5446             Tom Tromey  <tom@tromey.com>
5447
5448         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5449         (ppc_threads): Now a std::vector.  Now static.
5450         (hwdebug_find_thread_points_by_tid)
5451         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5452         Update.
5453
5454 2019-05-04  Tom Tromey  <tom@tromey.com>
5455
5456         * arc-tdep.c (arc_tdesc_init): Return bool.
5457
5458 2019-05-04  Tom Tromey  <tom@tromey.com>
5459
5460         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5461         Use gdb_assert_not_reached.
5462
5463 2019-05-04  Tom Tromey  <tom@tromey.com>
5464
5465         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5466         "false".
5467
5468 2019-05-04  Tom Tromey  <tom@tromey.com>
5469
5470         * arc-tdep.c (arc_tdesc_init): Use bool.
5471
5472 2019-05-04  Tom Tromey  <tom@tromey.com>
5473
5474         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5475
5476 2019-05-04  Tom Tromey  <tom@tromey.com>
5477
5478         * cli/cli-cmds.c (valid_command_p): Return bool.
5479
5480 2019-05-04  Tom Tromey  <tom@tromey.com>
5481
5482         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5483         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5484
5485 2019-05-04  Raul Tambre  <raul@tambre.ee>
5486
5487         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5488         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5489         operator for comparison.
5490
5491 2019-05-04  Tom Tromey  <tom@tromey.com>
5492
5493         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5494         (lookup_partial_symbol, print_partial_symbols)
5495         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5496         (psymbol_compare): Update.
5497         (add_psymbol_to_bcache): Clear the entire psymbol.
5498         (maintenance_check_psymtabs): Update.
5499         * psympriv.h (struct partial_symbol): Don't derive from
5500         general_symbol_info.
5501         <obj_section, unrelocated_address, address,
5502         set_unrelocated_address>: Update.
5503         <ginfo>: New member.
5504         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5505         (debug_names::write_psymbols): Update.
5506
5507 2019-05-04  Tom de Vries  <tdevries@suse.de>
5508
5509         * contrib/cc-with-tweaks.sh: Support -n arg.
5510
5511 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5512
5513         * corelow.c (core_target::detach): Ensure frame cache and
5514         register caches are cleared.
5515         inferior.c (exit_inferior_1): Likewise.
5516
5517 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5518             Tom Tromey  <tom@tromey.com>
5519
5520         * dictionary.c (collate_pending_symbols_by_language): Remove
5521         "struct" from foreach.
5522         * symtab.c (lookup_global_symbol_from_objfile)
5523         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5524         foreach.
5525         * ser-tcp.c (net_open): Remove "struct" from foreach.
5526         * objfiles.c (objfile_relocate, objfile_rebase)
5527         (objfile_has_symbols): Remove "struct" from foreach.
5528         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5529         from foreach.
5530         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5531         foreach.
5532         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5533         "struct" from foreach.
5534         * ada-lang.c (create_excep_cond_exprs)
5535         (ada_exception_catchpoint_cond_string): Remove "struct" from
5536         foreach.
5537
5538 2019-05-03  Tom Tromey  <tromey@adacore.com>
5539
5540         * ada-exp.y (convert_char_literal): Check suffix of each
5541         enumerator.
5542
5543 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5544
5545         PR ada/21406:
5546         * ada-exp.y (yywrap): Don't define.
5547         * ada-lex.l (%option): Add noyywrap
5548         (yywrap): Remove.
5549
5550 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5551
5552         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5553         _WIN32_WINNT to the XP level, unless already defined to a higher
5554         level.
5555
5556         * unittests/parse-connection-spec-selftests.c:
5557         * ser-tcp.c:
5558         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5559         override.
5560
5561         * symfile.c (find_separate_debug_file): Remove colon from the
5562         drive spec of DOS/Windows file names of the target, so that the
5563         file name produced from DEBUGDIR and the target's directory will
5564         be valid on DOS/Windows systems.
5565
5566 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * rust-lang.c (val_print_struct): Handle printing structures
5569         containing strings.
5570
5571 2019-05-02  Tom Tromey  <tromey@adacore.com>
5572
5573         * valarith.c (_initialize_valarith): Remove.
5574
5575 2019-05-01  Tom Tromey  <tromey@adacore.com>
5576
5577         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5578         bitfields.
5579
5580 2019-05-01  Tom Tromey  <tromey@adacore.com>
5581
5582         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5583         for big-endian copies.
5584
5585 2019-04-30  Ali Tamur  <tamur@google.com>
5586         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5587         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5588         (read_3_bytes): New function.
5589
5590 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5591
5592         * windows-nat.c (main_thread_id): Delete.
5593         (handle_output_debug_string): Replace main_thread_id by
5594         current_event.dwThreadId.
5595         (fake_create_process): Likewise.
5596         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5597         Do not set main_thread_id.
5598         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5599         current_event.dwThreadId.
5600         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5601
5602 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5603
5604         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5605         Use current_event.dwThreadId instead of main_thread_id.
5606
5607 2019-04-30  Tom Tromey  <tromey@adacore.com>
5608
5609         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5610         (create_excep_cond_exprs): Iterate over program spaces.
5611         (ada_exception_catchpoint_cond_string): Examine all minimal
5612         symbols for exception types.
5613
5614 2019-04-30  Tom Tromey  <tromey@adacore.com>
5615
5616         PR c++/24470:
5617         * dwarf2read.c (process_structure_scope): Handle case where type
5618         has template parameters but no symbol was created.
5619
5620 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5621             Chris January  <chris.january@arm.com>
5622
5623         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5624         qualifier.
5625         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5626
5627 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5628
5629         * f-typeprint.c (f_print_type): Update rules for printing
5630         whitespace.
5631         (f_type_print_varspec_suffix): Likewise.
5632
5633 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5634             Chris January  <chris.january@arm.com>
5635
5636         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5637         function arguments.
5638
5639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5640
5641         * f-lang.c (build_fortran_types): Change name of void type to
5642         lower case.
5643         * f-typeprint.c (f_type_print_base): Print the name of the void
5644         type, rather than a fixed string.
5645         * f-valprint.c (f_decorations): Use lower case void string.
5646
5647 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5648             Chris January  <chris.january@arm.com>
5649
5650         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5651         types for Fortran.
5652
5653 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5654             Chris January  <chris.january@arm.com>
5655             David Lecomber  <david.lecomber@arm.com>
5656
5657         * f-exp.y (BINOP_INTRINSIC): New token.
5658         (exp): New parser rule handling BINOP_INTRINSIC.
5659         (f77_keywords): Add new builtin procedures.
5660         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5661         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5662         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5663         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5664         (print_unop_subexp_f): New function.
5665         (print_binop_subexp_f): New function.
5666         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5667         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5668         (dump_subexp_body_f): Likewise.
5669         (operator_check_f): Likewise.
5670         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5671         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5672
5673 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5674
5675         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5676         UNOP_KIND.
5677         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5678         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5679         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5680         (operator_length_f): New fuction.
5681         (print_subexp_f): New function.
5682         (op_name_f): New function.
5683         (dump_subexp_body_f): New function.
5684         (operator_check_f): New function.
5685         (exp_descriptor_f): Replace standard expression handling functions
5686         with new functions.
5687         * gdb/fortran-operator.def: New file.
5688         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5689         * gdb/std-operator.def: Remove UNOP_KIND.
5690
5691 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5692
5693         * std-operator.def: Remove unbalanced, stray double quote
5694         character.
5695
5696 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5697             Chris January  <chris.january@arm.com>
5698             Daniel Everett  <daniel.everett@arm.com>
5699             Nick Forrington  <nick.forrington@arm.com>
5700             Richard Bunt  <richard.bunt@arm.com>
5701
5702         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5703         of depth when printing anonymous structs or unions.
5704         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5705         Don't print either the top-level value, or the children if the
5706         max-depth is exceeded.
5707         (ppscm_print_children): When printing the key of a map, allow one
5708         extra level of depth.
5709         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5710         print either the top-level value, or the children if the max-depth
5711         is exceeded.
5712         (print_children): When printing the key of a map, allow one extra
5713         level of depth.
5714         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5715         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5716         (user_print_options): Initialise max_depth field.
5717         (val_print_scalar_or_string_type_p): New function.
5718         (val_print): Check to see if the max depth has been reached.
5719         (val_print_check_max_depth): Define new function.
5720         (show_print_max_depth): New function.
5721         (_initialize_valprint): Add 'print max-depth' option.
5722         * valprint.h (struct value_print_options) <max_depth>: New field.
5723         (val_print_check_max_depth): Declare new function.
5724         * NEWS: Document new feature.
5725
5726 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * ada-lang.c (ada_language_defn): Initialise new field.
5729         * c-lang.c (c_is_string_type_p): New function.
5730         (c_language_defn): Initialise new field.
5731         (cplus_language_defn): Initialise new field.
5732         (asm_language_defn): Initialise new field.
5733         (minimal_language_defn): Initialise new field.
5734         * c-lang.h (c_is_string_type_p): Declare new function.
5735         * d-lang.c (d_language_defn): Initialise new field.
5736         * f-lang.c (f_is_string_type_p): New function.
5737         (f_language_defn): Initialise new field.
5738         * go-lang.c (go_is_string_type_p): New function.
5739         (go_language_defn): Initialise new field.
5740         * language.c (default_is_string_type_p): New function.
5741         (unknown_language_defn): Initialise new field.
5742         (auto_language_defn): Initialise new field.
5743         * language.h (struct language_defn) <la_is_string_type_p>: New
5744         member variable.
5745         (default_is_string_type_p): Declare new function.
5746         * m2-lang.c (m2_language_defn): Initialise new field.
5747         * objc-lang.c (objc_language_defn): Initialise new field.
5748         * opencl-lang.c (opencl_language_defn): Initialise new field.
5749         * p-lang.c (pascal_is_string_type_p): New function.
5750         (pascal_language_defn): Initialise new field.
5751         * rust-lang.c (rust_is_string_type_p): New function.
5752         (rust_language_defn): Initialise new field.
5753
5754 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5755
5756         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5757         New field.
5758         * ada-lang.c (ada_language_defn): Initialise new field.
5759         * c-lang.c (c_language_defn): Likewise.
5760         (cplus_language_defn): Likewise.
5761         (asm_language_defn): Likewise.
5762         (minimal_language_defn): Likewise.
5763         * d-lang.c (d_language_defn): Likewise.
5764         * f-lang.c (f_language_defn): Likewise.
5765         * go-lang.c (go_language_defn): Likewise.
5766         * language.c (unknown_language_defn): Likewise.
5767         (auto_language_defn): Likewise.
5768         * m2-lang.c (m2_language_defn): Likewise.
5769         * objc-lang.c (objc_language_defn): Likewise.
5770         * opencl-lang.c (opencl_language_defn): Likewise.
5771         * p-lang.c (pascal_language_defn): Likewise.
5772         * rust-lang.c (rust_language_defn): Likewise.
5773
5774 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5775
5776         * ada-lang.c (ada_is_character_type): Change return type to bool.
5777         (ada_is_string_type): Likewise.
5778         * ada-lang.h (ada_is_character_type): Update declaration
5779         (ada_is_string_type): Likewise.
5780
5781 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5782
5783         Support style in 'frame|thread apply'
5784
5785         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5786         * record.c (record_start, record_stop): Update callers of
5787         execute_command_to_string with false.
5788         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5789         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5790         methods.
5791         (class string_file): New constructor with term_out parameter.
5792         Override methods term_out and can_emit_style_escape.  New member
5793         term_out.
5794         (class stdio_file): Override can_emit_style_escape.
5795         (class tee_file): Override term_out and can_emit_style_escape.
5796         * utils.h (can_emit_style_escape): Remove.
5797         * utils.c (can_emit_style_escape): Likewise.
5798         Update all callers of can_emit_style_escape (SOMESTREAM) to
5799         SOMESTREAM->can_emit_style_escape.
5800         * source-cache.c (source_cache::get_source_lines): Likewise.
5801         * stack.c (frame_apply_command_count): Call execute_command_to_string
5802         passing the term_out characteristic of the current gdb_stdout.
5803         * thread.c (thr_try_catch_cmd): Likewise.
5804         * top.c (execute_command_to_string): pass term_out parameter
5805         to construct the string_file for the command output.
5806         * ui-file.c (term_cli_styling): New function (most code moved
5807         from utils.c can_emit_style_escape).
5808         (string_file::string_file, string_file::can_emit_style_escape,
5809         stdio_file::can_emit_style_escape, tee_file::term_out,
5810         tee_file::can_emit_style_escape): New functions.
5811
5812 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5813
5814         * NEWS: Mention the new set|show may-call-functions.
5815         * infcall.c (may_call_functions_p): New variable.
5816         (show_may_call_functions_p): New function.
5817         (call_function_by_hand_dummy): Throws an error if not
5818         may-call-functions.
5819         (_initialize_infcall): Call add_setshow_boolean_cmd for
5820         may-call-functions.
5821
5822 2019-04-25  Keith Seitz  <keiths@redhat.com>
5823
5824         PR c++/24367
5825         * cp-support.c (inspect_type): Don't attempt substitutions
5826         of symbol with the same name.
5827
5828 2019-04-25  Tom Tromey  <tromey@adacore.com>
5829
5830         PR gdb/24475:
5831         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5832         static.
5833
5834 2019-04-25  Tom Tromey  <tromey@adacore.com>
5835
5836         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5837         rvalue reference.
5838         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5839         (gdb_xml_parser::parse): Use std::move.
5840         * python/python-internal.h (gdbpy_convert_exception): Take a const
5841         reference.
5842         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5843         std::move.
5844         * python/py-utils.c (gdbpy_convert_exception): Take a const
5845         reference.
5846         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5847         Use std::move.
5848         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5849         Use std::move.
5850         * mi/mi-main.c (mi_print_exception): Take a const reference.
5851         * main.c (handle_command_errors): Take a const reference.
5852         * linespec.c (parse_linespec): Use std::move.
5853         * infcall.c (run_inferior_call): Use std::move.
5854         (call_function_by_hand_dummy): Use std::move.
5855         * exec.c (try_open_exec_file): Use std::move.
5856         * exceptions.h (exception_print, exception_fprintf)
5857         (exception_print_same): Update.
5858         * exceptions.c (print_exception, exception_print)
5859         (exception_fprintf, exception_print_same): Change parameters to
5860         const reference.
5861         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5862         * common/new-op.c: Use std::move.
5863         * common/common-exceptions.h (struct gdb_exception): Add move
5864         constructor.
5865         (struct gdb_exception_error, struct gdb_exception_quit, struct
5866         gdb_quit_bad_alloc): Change constructor to move constructor.
5867         (throw_exception): Change parameter to rvalue reference.
5868         * common/common-exceptions.c (throw_exception): Take rvalue
5869         reference.
5870         * cli/cli-interp.c (safe_execute_command): Use std::move.
5871         * breakpoint.c (insert_bp_location, location_to_sals): Use
5872         std::move.
5873
5874 2019-04-25  Tom Tromey  <tromey@adacore.com>
5875
5876         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5877         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5878         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5879         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5880         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5881         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5882         guile/scm-value.c: Use unpack.
5883         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5884         gdbscm_gdb_exception.
5885         (gdbscm_throw_gdb_exception): Likewise.
5886         (struct gdbscm_gdb_exception): New.
5887         (unpack): New function.
5888         (gdbscm_wrap): Use unpack.
5889
5890 2019-04-25  Tom Tromey  <tromey@adacore.com>
5891
5892         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5893         (gdb_rl_callback_handler): Use std::move.
5894         * common/common-exceptions.h (struct gdb_exception): Add move
5895         assignment operator.
5896         (throw_exception_sjlj): Change "exception" to const reference.
5897         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5898         (throw_exception_sjlj): Change "exception" to const reference.
5899
5900 2019-04-25  Tom Tromey  <tromey@adacore.com>
5901
5902         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5903         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5904         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5905         Update.
5906         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5907         Update.
5908         * mi/mi-interp.c (mi_interp::exec): Update.
5909         * linespec.c (parse_linespec): Update.
5910         * infcall.c (run_inferior_call): Update.
5911         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5912         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5913         (gdbscm_lookup_global_symbol): Update.
5914         * guile/scm-param.c (gdbscm_parameter_value): Update.
5915         * guile/scm-frame.c (gdbscm_frame_read_register)
5916         (gdbscm_frame_read_var): Update.
5917         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5918         * exec.c (try_open_exec_file): Update.
5919         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5920         (gdb_rl_callback_handler): Update.
5921         * common/common-exceptions.h (exception_none): Don't declare.
5922         * common/common-exceptions.c (exception_none): Don't define.
5923         (struct catcher) <exception>: Update.
5924         * cli/cli-interp.c (safe_execute_command): Update.
5925         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5926
5927 2019-04-25  Ali Tamur  <tamur@google.com>
5928
5929         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5930         (read_attribute_value): Likewise.
5931         (dwarf2_read_addr_index): Update comment.
5932         (read_str_index): Add DW_FORM_strx.
5933         (dwarf2_string_attr): Likewise.
5934         (dwarf2_const_value_attr): Likewise.
5935         (dump_die_shallow): Likewise.
5936         (dwarf2_fetch_constant_bytes): Likewise.
5937         (skip_form_bytes): Likewise.
5938         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5939
5940 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5941
5942         PR corefiles/11608
5943         PR corefiles/18187
5944         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5945         OFFSET.  Verify if current mapping contains an ELF header.
5946         (linux_find_memory_regions_full): Adjust call to
5947         dump_mapping_p.
5948
5949 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5950             Kang Li <kanglictf@gmail.com>
5951
5952         PR gdb/21600
5953
5954         * dwarf2-frame.c (read_initial_length): Be consistent about using
5955         unsigned representation of length.
5956         (decode_frame_entry_1): Likewise.  Check for wraparound of
5957         end pointer as well as buffer overflow.
5958
5959 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5960
5961         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5962         "vq".
5963
5964 2019-04-24  Tom Tromey  <tromey@adacore.com>
5965
5966         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5967
5968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * s12z-tdep.c (s12z_unwind_pc): Delete.
5971         (s12z_unwind_sp): Delete.
5972         (s12z_gdbarch_init): Don't register deleted functions with
5973         gdbarch.
5974
5975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * rl78-tdep.c (rl78_unwind_sp): Delete.
5978         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5979
5980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5981
5982         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5983         (xstormy16_unwind_pc): Delete.
5984         (xstormy16_dummy_id): Delete.
5985         (xstormy16_gdbarch_init): Don't register deleted functions with
5986         gdbarch.
5987
5988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * vax-tdep.c (vax_unwind_pc): Delete.
5991         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5992
5993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * v850-tdep.c (v850_unwind_sp): Delete.
5996         (v850_unwind_pc): Delete.
5997         (v850_dummy_id): Delete.
5998         (v850_gdbarch_init): Don't register deleted functions with
5999         gdbarch.
6000
6001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6004         (tilegx_unwind_pc): Delete.
6005         (tilegx_unwind_dummy_id): Delete.
6006         (tilegx_gdbarch_init): Don't register deleted functions with
6007         gdbarch.
6008
6009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6012         (tic6x_dummy_id): Delete.
6013         (tic6x_gdbarch_init): Don't register deleted functions with
6014         gdbarch.
6015
6016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * sparc-tdep.c (sparc_unwind_pc): Delete.
6019         (sparc32_gdbarch_init): Don't register deleted function with
6020         gdbarch.
6021
6022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6023
6024         * sh-tdep.c (sh_unwind_sp): Delete.
6025         (sh_unwind_pc): Delete.
6026         (sh_dummy_id): Delete.
6027         (sh_gdbarch_init): Don't register deleted functions with
6028         gdbarch.
6029
6030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * score-tdep.c (score_unwind_sp): Delete.
6033         (score_unwind_pc): Delete.
6034         (score_dummy_id): Delete.
6035         (score_gdbarch_init): Don't register deleted functions with
6036         gdbarch.
6037
6038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6039
6040         * rx-tdep.c (rx_unwind_pc): Delete.
6041         (rx_unwind_sp): Delete.
6042         (rx_dummy_id): Delete.
6043         (rx_gdbarch_init): Don't register deleted functions with
6044         gdbarch.  Update comment.
6045
6046 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6047
6048         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6049         (rs6000_dummy_id): Delete.
6050         (rs6000_gdbarch_init): Don't register deleted functions with
6051         gdbarch.
6052
6053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * or1k-tdep.c (or1k_dummy_id): Delete.
6056         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6057
6058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6059
6060         * nios2-tdep.c (nios2_dummy_id): Delete.
6061         (nios2_unwind_sp): Delete.
6062         (nios2_gdbarch_init): Don't register deleted functions with
6063         gdbarch.
6064
6065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6066
6067         * nds32-tdep.c (nds32_dummy_id): Delete.
6068         (nds32_unwind_pc): Delete.
6069         (nds32_unwind_sp): Delete.
6070         (nds32_gdbarch_init): Don't register deleted functions with
6071         gdbarch.
6072
6073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6074
6075         * msp430-tdep.c (msp430_unwind_pc): Delete.
6076         (msp430_unwind_sp): Delete.
6077         (msp430_dummy_id): Delete.
6078         (msp430_gdbarch_init): Don't register deleted functions with
6079         gdbarch.
6080
6081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * moxie-tdep.c (moxie_unwind_sp): Delete.
6084         (moxie_unwind_pc): Delete.
6085         (moxie_dummy_id): Delete.
6086         (moxie_gdbarch_init): Don't register deleted functions with
6087         gdbarch.
6088
6089 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6090
6091         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6092         (mn10300_unwind_pc): Delete.
6093         (mn10300_unwind_sp): Delete.
6094         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6095         mn10300_unwind_sp.
6096         (mn10300_frame_unwind_init): Don't register deleted functions with
6097         gdbarch.
6098
6099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6100
6101         * mep-tdep.c (mep_unwind_pc): Delete.
6102         (mep_unwind_sp): Delete.
6103         (mep_dummy_id): Delete.
6104         (mep_gdbarch_init): Don't register deleted functions with
6105         gdbarch.
6106
6107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6110         (m68hc11_unwind_sp): Delete.
6111         (m68hc11_gdbarch_init): Don't register deleted functions with
6112         gdbarch.
6113
6114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * m32r-tdep.c (m32r_unwind_sp): Delete.
6117         (m32r_unwind_pc): Delete.
6118         (m32r_dummy_id): Delete.
6119         (m32r_gdbarch_init): Don't register deleted functions with
6120         gdbarch.
6121
6122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * m32c-tdep.c (m32c_unwind_pc): Delete.
6125         (m32c_unwind_sp): Delete.
6126         (m32c_dummy_id): Delete.
6127         (m32c_gdbarch_init): Don't register deleted functions with
6128         gdbarch.
6129
6130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6131
6132         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6133         (lm32_unwind_pc): Delete.
6134         (lm32_dummy_id): Delete.
6135         (lm32_gdbarch_init): Don't register deleted functions with
6136         gdbarch.
6137
6138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6141         (iq2000_unwind_pc): Delete.
6142         (iq2000_dummy_id): Delete.
6143         (iq2000_gdbarch_init): Don't register deleted functions with
6144         gdbarch.
6145
6146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6147
6148         * nds32-tdep.c (nds32_type_align): Delete.
6149         (nds32_push_dummy_call): Use type_align instead.
6150
6151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6152
6153         * arm-tdep.c (arm_type_align): Only handle vector override case.
6154         (arm_push_dummy_call): Use type_align.
6155         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6156
6157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6160         case.
6161         (pass_on_stack): Use type_align.
6162         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6163         function.
6164
6165 2019-04-23  Tom Tromey  <tromey@adacore.com>
6166
6167         * dwarf2read.c (line_header::file_name_at): Remove unused
6168         overload.
6169
6170 2019-04-23  Tom de Vries  <tdevries@suse.de>
6171
6172         PR gdb/24438
6173         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6174         invocation.
6175
6176
6177 2019-03-27  Ali Tamur  <tamur@google.com>
6178
6179         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6180         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6181         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6182         (dwarf_expr_context::get_addr_index): Likewise
6183         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6184         (symbol_needs_eval_context::get_addr_index): Likewise
6185         (disassemble_dwarf_expression): Add DW_OP_addrx
6186         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6187         (read_cutu_die_from_dwo): Update comment
6188         (skip_one_die): Add DW_FORM_addrx
6189         (read_attribute_value): Likewise
6190         (var_decode_location): Add DW_OP_addrx
6191         (dwarf2_const_value_attr): Add DW_FORM_addrx
6192         (dump_die_shallow): Likewise
6193         (dwarf2_fetch_constant_bytes): Likewise
6194         (decode_locdesc): Add DW_OP_addrx
6195         (skip_form_bytes): Add DW_FORM_addrx
6196
6197 2019-04-22  Ali Tamur  <tamur@google.com>
6198
6199         * MAINTAINERS (Write After Approval): Add self.
6200
6201 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6202
6203         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6204         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6205         (open_symbol_file_object): Likewise.
6206         (svr4_default_sos): Add info parameter.
6207         (svr4_read_so_list): Likewise.
6208         (svr4_current_sos_direct): Adjust functions calls to pass down
6209         info.
6210         (svr4_current_sos_1): Add info parameter.
6211         (svr4_current_sos): Call get_svr4_info, pass info down to
6212         svr4_current_sos_1.
6213         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6214         get_svr4_info.
6215         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6216         get_svr4_info.
6217         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6218         to get_svr4_info.
6219         (probes_table_remove_objfile_probes): Likewise.
6220         (register_solib_event_probe): Add info parameter.
6221         (solist_update_incremental): Pass info parameter down to
6222         svr4_read_so_list.
6223         (disable_probes_interface): Add info parameter.
6224         (svr4_handle_solib_event): Pass current_program_space to
6225         get_svr4_info.  Adjust disable_probes_interface cleanup.
6226         (svr4_create_probe_breakpoints): Add info parameter, pass it
6227         down to register_solib_event_probe.
6228         (svr4_create_solib_event_breakpoints): Add info parameter,
6229         pass it down to svr4_create_probe_breakpoints.
6230         (enable_break): Pass info down to
6231         svr4_create_solib_event_breakpoints.
6232         (svr4_solib_create_inferior_hook): Pass current_program_space to
6233         get_svr4_info.
6234         (svr4_clear_solib): Likewise.
6235
6236 2019-04-22  Pedro Alves  <palves@redhat.com>
6237
6238         * solib-svr4.c (svr4_free_objfile_observer): New.
6239         (probe_and_action::objfile): New field.
6240         (probes_table_htab_remove_objfile_probes)
6241         (probes_table_remove_objfile_probes): New functions.
6242         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6243         in the new probe_and_action.  Don't store the probe in 'lookup'.
6244         (svr4_create_probe_breakpoints): Pass objfile to
6245         register_solib_event_probe.
6246         (_initialize_svr4_solib): Register a free_objfile observer.
6247
6248 2019-04-19  Tom Tromey  <tom@tromey.com>
6249
6250         * common/queue.h: Remove.
6251
6252 2019-04-19  Tom Tromey  <tom@tromey.com>
6253
6254         * event-loop.c: Don't include "common/queue.h".
6255
6256 2019-04-19  Tom Tromey  <tom@tromey.com>
6257
6258         * remote.c (remote_target): Use delete.
6259         * remote-notif.h: Include <list>, not "common/queue.h".
6260         (notif_client_p): Remove typedef.
6261         (remote_notif_state): Add constructor, destructor, initializer.
6262         <notif_queue>: Now a std::list.
6263         (remote_notif_state_xfree): Don't declare.
6264         * remote-notif.c (remote_notif_process, handle_notification)
6265         (remote_notif_state_allocate): Update.
6266         (~remote_notif_state): Rename from remote_notif_state_xfree.
6267
6268 2019-04-19  Tom Tromey  <tom@tromey.com>
6269
6270         * symfile.c (reread_symbols): Update.
6271         * objfiles.c (objfile_register_static_link)
6272         (objfile_lookup_static_link): Update
6273         (~objfile) Don't delete static_links.
6274         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6275
6276 2019-04-19  Tom Tromey  <tom@tromey.com>
6277
6278         * type-stack.h (struct type_stack) <insert>: Constify string.
6279         * type-stack.c (type_stack::insert): Constify string.
6280         * gdbtypes.h (lookup_template_type): Update.
6281         (address_space_name_to_int): Update.
6282         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6283         const.
6284         (lookup_template_type): Make name const.
6285         * c-exp.y: Update rules.
6286         (lex_one_token, classify_name, classify_inner_name)
6287         (c_print_token): Update.
6288         * p-exp.y: Update rules.
6289         (yylex): Update.
6290         * f-exp.y: Update rules.
6291         (yylex): Update.
6292         * d-exp.y: Update rules.
6293         (lex_one_token, classify_name, classify_inner_name): Update.
6294         * parse.c (write_dollar_variable, copy_name): Return std::string.
6295         * parser-defs.h (copy_name): Change return type.
6296         * m2-exp.y: Update rules.
6297         (yylex): Update.
6298         * go-exp.y (lex_one_token): Update.
6299         Update rules.
6300         (classify_unsafe_function, classify_packaged_name)
6301         (classify_name, yylex): Update.
6302
6303 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6304
6305         * configure.ac: add --enable-source-highlight switch.
6306         * configure: Regenerate.
6307         * top.c (print_gdb_version): plumb --enable-source-highlight
6308         status to "show configuration".
6309
6310 2019-04-19  Tom Tromey  <tromey@adacore.com>
6311
6312         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6313         Check ADA_TYPE_P.
6314         (empty_record, ada_template_to_fixed_record_type_1)
6315         (template_to_static_fixed_type)
6316         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6317         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6318         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6319         macros.
6320
6321 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6322
6323         PR symtab/24423:
6324         * source.c (print_source_lines_base): Advance "iter" when a
6325         control character is seen.
6326
6327 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6328
6329         * inferior.h (struct infcall_suspend_state_deleter):
6330         Catch exception in destructor to avoid crash.
6331
6332 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6333
6334         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6335         close to the add_com "shell".
6336
6337 2019-04-18  Tom Tromey  <tromey@adacore.com>
6338
6339         * process-stratum-target.h (class process_stratum_target)
6340         <stratum>: Add "final".
6341
6342 2019-04-17  Tom Tromey  <tromey@adacore.com>
6343
6344         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6345         against nullptr before use.
6346
6347 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6348
6349         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6350
6351 2019-04-17  Jim Wilson  <jimw@sifive.com>
6352             Andrew Burgess  <andrew.burgess@embecosm.com>
6353
6354         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6355         code read might fail, assume 4-byte breakpoint in that case.
6356
6357 2019-04-15  Leszek Swirski  <leszeks@google.com>
6358
6359         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6360         rather than a hand-rolled POD check when checking for forced MEMORY
6361         classification.
6362
6363 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6364
6365         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6366         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6367         function.
6368         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6369         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6370         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6371         declaration.
6372
6373 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6374
6375         * aarch64-linux-nat.c
6376         (aarch64_linux_nat_target::thread_architecture): Add override.
6377         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6378         each VQ.
6379
6380 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6381
6382         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6383
6384 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6387         target types of size 96-bits, add some additional comments, and
6388         check that the builtin type we found was the correct size.
6389
6390 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6391
6392         * utils.c (prompt_for_continue): Don't restore the styling at the
6393         end, as applied_style has the wrong value.  This fixes styling in
6394         long lists of file names that are interrupted by the "Continue?"
6395         prompt.
6396
6397 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6400         * c-lang.c (c_language_defn): Likewise.
6401         (cplus_language_defn): Likewise.
6402         (asm_language_defn): Likewise.
6403         (minimal_language_defn): Likewise.
6404         * d-lang.c (d_language_defn): Likewise.
6405         * f-lang.c (f_language_defn): Likewise.
6406         * go-lang.c (go_language_defn): Likewise.
6407         * language.c (unknown_language_defn): Likewise.
6408         (auto_language_defn): Likewise.
6409         * language.h (struct language_defn): Remove la_magic field.
6410         (LANG_MAGIC): Delete.
6411         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6412         * objc-lang.c (objc_language_defn): Likewise.
6413         * opencl-lang.c (opencl_language_defn): Likewise.
6414         * p-lang.c (pascal_language_defn): Likewise.
6415         * rust-lang.c (rust_language_defn): Likewise.
6416
6417 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         * riscv-tdep.c (riscv_type_align): New function.
6420         (riscv_type_alignment): Delete.
6421         (riscv_arg_location): Use 'type_align'.
6422         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6423
6424 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * gdbtypes.c (type_align): A struct with no non-static fields also
6427         has alignment of 1.
6428
6429 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6430
6431         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6432         component to 0.
6433         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6434         member.
6435         (riscv_struct_info::analyse): New implementation using new
6436         analyse_inner member function.
6437         (riscv_struct_info::field_offset): New member function.
6438         (riscv_struct_info::m_offsets): New member variable.
6439         (riscv_struct_info::analyse_inner): New private member function,
6440         takes the old implementation of riscv_struct_info::analyse but
6441         extended to track field offsets.
6442         (riscv_call_arg_struct): Update the struct folding special cases
6443         to handle cases where empty C++ structs, which are non-zero
6444         length, are found.
6445         (riscv_arg_location): Initialise the length of each location, a
6446         non-zero length now indicates the location is in use.
6447         (riscv_push_dummy_call): Allow for the first location having a
6448         non-zero offset when setting up arguments.
6449         (riscv_return_value): Likewise, but for return values.
6450
6451 2019-04-11  Tom Tromey  <tromey@adacore.com>
6452
6453         * utils.c (internal_vproblem): Make "msg" const.
6454
6455 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6456
6457         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6458         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6459         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6460         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6461
6462 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6463
6464         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6465         function.
6466         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6467         of amd64_collect_native_gregset.
6468         (amd64_linux_nat_target::store_registers): Likewise.
6469
6470 2019-04-10  Tom Tromey  <tom@tromey.com>
6471
6472         * symtab.c (lookup_global_symbol_from_objfile)
6473         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6474         * objfiles.h (class separate_debug_iterator): New.
6475         (class separate_debug_range): New.
6476         (struct objfile) <separate_debug_objfiles>: New method.
6477         (objfile_separate_debug_iterate): Don't declare.
6478         * objfiles.c (separate_debug_iterator::operator++): Rename from
6479         objfile_separate_debug_iterate.
6480         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6481         iterator.
6482         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6483         iterator.
6484
6485 2019-04-10  Tom Tromey  <tom@tromey.com>
6486
6487         * symfile.c (reread_symbols): Remove old comment.
6488         * objfiles.c (free_all_objfiles): Fix a typo.
6489
6490 2019-04-10  Tom Tromey  <tom@tromey.com>
6491
6492         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6493         * minsyms.c (lookup_minimal_symbol): Use foreach.
6494         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6495         (lookup_minimal_symbol_solib_trampoline): Likewise.
6496         * symfile.c (reread_symbols): Use foreach.
6497
6498 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6499             Tom Tromey  <tromey@adacore.com>
6500
6501         PR rust/24414:
6502         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6503         (rust_lex_int_test): Change "value" to be LONGEST.
6504         (rust_lex_tests): Add test for long integer literal.
6505
6506 2019-04-09  Tom Tromey  <tromey@adacore.com>
6507
6508         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6509         to bool.
6510         (extended_remote_target::attach): Update.
6511         (remote_target::remote_notice_new_inferior): Update.
6512         (remote_target::add_current_inferior_and_thread): Update.
6513         * inferior.c (exit_inferior_1): Use "false".
6514         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6515
6516 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6517
6518         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6519         the "start" command.
6520
6521 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6522
6523         * python/py-inferior.c (infpy_thread_from_thread_handle):
6524         Adjust comments to reflect renaming of thread_from_thread_handle
6525         to thread_from_handle.  Adjust keywords.  Fix type error message.
6526         (inferior_object_methods): Add thread_from_handle.  Retain
6527         thread_from_thread_handle, but mark it as deprecated.
6528
6529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6530
6531         * gdbthread.h (find_thread_by_handle): Revise declaration.
6532         * thread.c (find_thread_by_handle): Likewise.  Adjust
6533         implementation too.
6534         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6535         support for buffer objects as handles.
6536
6537 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6538
6539         * python/py-infthread.c (thpy_thread_handle): New function.
6540         (thread_object_methods): Register thpy_thread_handle.
6541
6542 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6543
6544         * gdbthread.h (thread_to_thread_handle): Declare.
6545         * thread.c (gdbtypes.h): Include.
6546         (thread_to_thread_handle): New function.
6547
6548         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6549         (target_thread_info_to_thread_handle): Declare.
6550         * target.c (target_thread_info_to_thread_handle): New function.
6551         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6552         * target-delegates.c: Regenerate.
6553
6554         * linux-thread-db.c (class thread_db_target): Add method
6555         thread_info_to_thread_handle.
6556         (thread_db_target::thread_info_to_thread_handle): Define.
6557         * remote.c (class remote_target): Add new method
6558         thread_info_to_thread_handle.
6559         (remote_target::thread_info_to_thread_handle): Define.
6560
6561 2019-04-08  Pedro Alves  <palves@redhat.com>
6562
6563         * common/common-exceptions.c (throw_exception): Don't create
6564         named object to throw; throw directly.
6565         (throw_it): Likewise.  Don't initialize gdb_exception::message
6566         here, with new; pass FMT and AP to the ctor instead.
6567         * common/common-exceptions.h: Include <string>.
6568         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6569         const char *, va_list)): New ctor.  Use std::make_shared.
6570         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6571         errors)): Delete.
6572         (gdb_exception_error::gdb_exception_error(enum errors, const char
6573         *, va_list)): New.
6574         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6575         Add assertion.
6576         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6577         errors)): Delete.
6578         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6579         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6580         Add assertion.
6581
6582 2019-04-08  Tom Tromey  <tom@tromey.com>
6583
6584         * valops.c (value_rtti_indirect_type): Replace throw_exception
6585         with throw.
6586         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6587         with throw.
6588         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6589         throw.
6590         * target.c (target_translate_tls_address): Replace throw_exception
6591         with throw.
6592         * stack.c (frame_apply_command_count): Replace throw_exception
6593         with throw.
6594         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6595         throw.
6596         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6597         with throw.
6598         * rs6000-tdep.c (rs6000_frame_cache)
6599         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6600         * remote.c: Replace throw_exception with throw.
6601         * record-full.c (record_full_message, record_full_wait_1)
6602         (record_full_restore): Replace throw_exception with throw.
6603         * record-btrace.c:
6604         (get_thread_current_frame_id, record_btrace_start_replaying)
6605         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6606         (cmd_record_btrace_start): Replace throw_exception with throw.
6607         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6608         throw.
6609         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6610         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6611         * linespec.c:
6612         (find_linespec_symbols): Replace throw_exception with throw.
6613         * infrun.c (displaced_step_prepare, resume): Replace
6614         throw_exception with throw.
6615         * infcmd.c (post_create_inferior): Replace throw_exception with
6616         throw.
6617         * inf-loop.c (inferior_event_handler): Replace throw_exception
6618         with throw.
6619         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6620         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6621         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6622         (get_prev_frame_always, get_frame_pc_if_available)
6623         (get_frame_address_in_block_if_available, get_frame_language):
6624         Replace throw_exception with throw.
6625         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6626         throw_exception with throw.
6627         * eval.c (fetch_subexp_value, evaluate_var_value)
6628         (evaluate_funcall, evaluate_subexp_standard): Replace
6629         throw_exception with throw.
6630         * dwarf2loc.c (call_site_find_chain)
6631         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6632         Replace throw_exception with throw.
6633         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6634         with throw.
6635         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6636         throw.
6637         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6638         * completer.c (complete_line_internal): Replace throw_exception
6639         with throw.
6640         * compile/compile-object-run.c (compile_object_run): Replace
6641         throw_exception with throw.
6642         * cli/cli-script.c (process_next_line): Replace throw_exception
6643         with throw.
6644         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6645         (btrace_enable, btrace_maint_update_pt_packets): Replace
6646         throw_exception with throw.
6647         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6648         throw_exception with throw.
6649         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6650         throw_exception with throw.
6651         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6652         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6653         * aarch64-tdep.c (aarch64_make_prologue_cache)
6654         (aarch64_make_stub_cache): Replace throw_exception with throw.
6655
6656 2019-04-08  Tom Tromey  <tom@tromey.com>
6657
6658         * common/common-exceptions.c (throw_exception): Rename from
6659         throw_exception_cxx.  Remove old copy.  Make argument const.
6660         (throw_it): Create and throw exception objects directly.
6661         * common/common-exceptions.h (throw_exception): Make argument
6662         const.
6663         (struct gdb_exception_error): Add constructor.
6664         (struct gdb_exception_quit): Add constructor.
6665
6666 2019-04-08  Tom Tromey  <tom@tromey.com>
6667
6668         * common/common-exceptions.h (exception_rethrow): Don't declare.
6669         (TRY_SJLJ): Update comment.
6670         (TRY, CATCH, END_CATCH): Remove.
6671         * common/common-exceptions.c (exception_rethrow): Remove.
6672
6673 2019-04-08  Tom Tromey  <tom@tromey.com>
6674
6675         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6676         Remove.
6677         (gdb_exception_error): Rename from
6678         gdb_exception_RETURN_MASK_ERROR.
6679         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6680         (gdb_quit_bad_alloc): Update.
6681         * aarch64-tdep.c: Update.
6682         * ada-lang.c: Update.
6683         * ada-typeprint.c: Update.
6684         * ada-valprint.c: Update.
6685         * amd64-tdep.c: Update.
6686         * arch-utils.c: Update.
6687         * break-catch-throw.c: Update.
6688         * breakpoint.c: Update.
6689         * btrace.c: Update.
6690         * c-varobj.c: Update.
6691         * cli/cli-cmds.c: Update.
6692         * cli/cli-interp.c: Update.
6693         * cli/cli-script.c: Update.
6694         * common/common-exceptions.c: Update.
6695         * common/new-op.c: Update.
6696         * common/selftest.c: Update.
6697         * compile/compile-c-symbols.c: Update.
6698         * compile/compile-cplus-symbols.c: Update.
6699         * compile/compile-object-load.c: Update.
6700         * compile/compile-object-run.c: Update.
6701         * completer.c: Update.
6702         * corelow.c: Update.
6703         * cp-abi.c: Update.
6704         * cp-support.c: Update.
6705         * cp-valprint.c: Update.
6706         * darwin-nat.c: Update.
6707         * disasm-selftests.c: Update.
6708         * dtrace-probe.c: Update.
6709         * dwarf-index-cache.c: Update.
6710         * dwarf-index-write.c: Update.
6711         * dwarf2-frame-tailcall.c: Update.
6712         * dwarf2-frame.c: Update.
6713         * dwarf2loc.c: Update.
6714         * dwarf2read.c: Update.
6715         * eval.c: Update.
6716         * event-loop.c: Update.
6717         * event-top.c: Update.
6718         * exec.c: Update.
6719         * f-valprint.c: Update.
6720         * fbsd-tdep.c: Update.
6721         * frame-unwind.c: Update.
6722         * frame.c: Update.
6723         * gdbtypes.c: Update.
6724         * gnu-v3-abi.c: Update.
6725         * guile/guile-internal.h: Update.
6726         * guile/scm-block.c: Update.
6727         * guile/scm-breakpoint.c: Update.
6728         * guile/scm-cmd.c: Update.
6729         * guile/scm-disasm.c: Update.
6730         * guile/scm-frame.c: Update.
6731         * guile/scm-lazy-string.c: Update.
6732         * guile/scm-math.c: Update.
6733         * guile/scm-param.c: Update.
6734         * guile/scm-ports.c: Update.
6735         * guile/scm-pretty-print.c: Update.
6736         * guile/scm-symbol.c: Update.
6737         * guile/scm-symtab.c: Update.
6738         * guile/scm-type.c: Update.
6739         * guile/scm-value.c: Update.
6740         * i386-linux-tdep.c: Update.
6741         * i386-tdep.c: Update.
6742         * inf-loop.c: Update.
6743         * infcall.c: Update.
6744         * infcmd.c: Update.
6745         * infrun.c: Update.
6746         * jit.c: Update.
6747         * language.c: Update.
6748         * linespec.c: Update.
6749         * linux-fork.c: Update.
6750         * linux-nat.c: Update.
6751         * linux-tdep.c: Update.
6752         * linux-thread-db.c: Update.
6753         * main.c: Update.
6754         * mi/mi-cmd-break.c: Update.
6755         * mi/mi-cmd-stack.c: Update.
6756         * mi/mi-interp.c: Update.
6757         * mi/mi-main.c: Update.
6758         * objc-lang.c: Update.
6759         * p-valprint.c: Update.
6760         * parse.c: Update.
6761         * ppc-linux-tdep.c: Update.
6762         * printcmd.c: Update.
6763         * python/py-arch.c: Update.
6764         * python/py-breakpoint.c: Update.
6765         * python/py-cmd.c: Update.
6766         * python/py-finishbreakpoint.c: Update.
6767         * python/py-frame.c: Update.
6768         * python/py-framefilter.c: Update.
6769         * python/py-gdb-readline.c: Update.
6770         * python/py-inferior.c: Update.
6771         * python/py-infthread.c: Update.
6772         * python/py-lazy-string.c: Update.
6773         * python/py-linetable.c: Update.
6774         * python/py-objfile.c: Update.
6775         * python/py-param.c: Update.
6776         * python/py-prettyprint.c: Update.
6777         * python/py-progspace.c: Update.
6778         * python/py-record-btrace.c: Update.
6779         * python/py-record.c: Update.
6780         * python/py-symbol.c: Update.
6781         * python/py-type.c: Update.
6782         * python/py-unwind.c: Update.
6783         * python/py-utils.c: Update.
6784         * python/py-value.c: Update.
6785         * python/python.c: Update.
6786         * record-btrace.c: Update.
6787         * record-full.c: Update.
6788         * remote-fileio.c: Update.
6789         * remote.c: Update.
6790         * riscv-tdep.c: Update.
6791         * rs6000-aix-tdep.c: Update.
6792         * rs6000-tdep.c: Update.
6793         * rust-exp.y: Update.
6794         * rust-lang.c: Update.
6795         * s390-tdep.c: Update.
6796         * selftest-arch.c: Update.
6797         * solib-dsbt.c: Update.
6798         * solib-frv.c: Update.
6799         * solib-spu.c: Update.
6800         * solib-svr4.c: Update.
6801         * solib.c: Update.
6802         * sparc64-linux-tdep.c: Update.
6803         * stack.c: Update.
6804         * symfile-mem.c: Update.
6805         * symmisc.c: Update.
6806         * target.c: Update.
6807         * thread.c: Update.
6808         * top.c: Update.
6809         * tracefile-tfile.c: Update.
6810         * tui/tui.c: Update.
6811         * typeprint.c: Update.
6812         * unittests/cli-utils-selftests.c: Update.
6813         * unittests/parse-connection-spec-selftests.c: Update.
6814         * valops.c: Update.
6815         * valprint.c: Update.
6816         * value.c: Update.
6817         * varobj.c: Update.
6818         * windows-nat.c: Update.
6819         * x86-linux-nat.c: Update.
6820         * xml-support.c: Update.
6821
6822 2019-04-08  Tom Tromey  <tom@tromey.com>
6823
6824         * xml-support.c: Use C++ exception handling.
6825         * x86-linux-nat.c: Use C++ exception handling.
6826         * windows-nat.c: Use C++ exception handling.
6827         * varobj.c: Use C++ exception handling.
6828         * value.c: Use C++ exception handling.
6829         * valprint.c: Use C++ exception handling.
6830         * valops.c: Use C++ exception handling.
6831         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6832         handling.
6833         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6834         * typeprint.c: Use C++ exception handling.
6835         * tui/tui.c: Use C++ exception handling.
6836         * tracefile-tfile.c: Use C++ exception handling.
6837         * top.c: Use C++ exception handling.
6838         * thread.c: Use C++ exception handling.
6839         * target.c: Use C++ exception handling.
6840         * symmisc.c: Use C++ exception handling.
6841         * symfile-mem.c: Use C++ exception handling.
6842         * stack.c: Use C++ exception handling.
6843         * sparc64-linux-tdep.c: Use C++ exception handling.
6844         * solib.c: Use C++ exception handling.
6845         * solib-svr4.c: Use C++ exception handling.
6846         * solib-spu.c: Use C++ exception handling.
6847         * solib-frv.c: Use C++ exception handling.
6848         * solib-dsbt.c: Use C++ exception handling.
6849         * selftest-arch.c: Use C++ exception handling.
6850         * s390-tdep.c: Use C++ exception handling.
6851         * rust-lang.c: Use C++ exception handling.
6852         * rust-exp.y: Use C++ exception handling.
6853         * rs6000-tdep.c: Use C++ exception handling.
6854         * rs6000-aix-tdep.c: Use C++ exception handling.
6855         * riscv-tdep.c: Use C++ exception handling.
6856         * remote.c: Use C++ exception handling.
6857         * remote-fileio.c: Use C++ exception handling.
6858         * record-full.c: Use C++ exception handling.
6859         * record-btrace.c: Use C++ exception handling.
6860         * python/python.c: Use C++ exception handling.
6861         * python/py-value.c: Use C++ exception handling.
6862         * python/py-utils.c: Use C++ exception handling.
6863         * python/py-unwind.c: Use C++ exception handling.
6864         * python/py-type.c: Use C++ exception handling.
6865         * python/py-symbol.c: Use C++ exception handling.
6866         * python/py-record.c: Use C++ exception handling.
6867         * python/py-record-btrace.c: Use C++ exception handling.
6868         * python/py-progspace.c: Use C++ exception handling.
6869         * python/py-prettyprint.c: Use C++ exception handling.
6870         * python/py-param.c: Use C++ exception handling.
6871         * python/py-objfile.c: Use C++ exception handling.
6872         * python/py-linetable.c: Use C++ exception handling.
6873         * python/py-lazy-string.c: Use C++ exception handling.
6874         * python/py-infthread.c: Use C++ exception handling.
6875         * python/py-inferior.c: Use C++ exception handling.
6876         * python/py-gdb-readline.c: Use C++ exception handling.
6877         * python/py-framefilter.c: Use C++ exception handling.
6878         * python/py-frame.c: Use C++ exception handling.
6879         * python/py-finishbreakpoint.c: Use C++ exception handling.
6880         * python/py-cmd.c: Use C++ exception handling.
6881         * python/py-breakpoint.c: Use C++ exception handling.
6882         * python/py-arch.c: Use C++ exception handling.
6883         * printcmd.c: Use C++ exception handling.
6884         * ppc-linux-tdep.c: Use C++ exception handling.
6885         * parse.c: Use C++ exception handling.
6886         * p-valprint.c: Use C++ exception handling.
6887         * objc-lang.c: Use C++ exception handling.
6888         * mi/mi-main.c: Use C++ exception handling.
6889         * mi/mi-interp.c: Use C++ exception handling.
6890         * mi/mi-cmd-stack.c: Use C++ exception handling.
6891         * mi/mi-cmd-break.c: Use C++ exception handling.
6892         * main.c: Use C++ exception handling.
6893         * linux-thread-db.c: Use C++ exception handling.
6894         * linux-tdep.c: Use C++ exception handling.
6895         * linux-nat.c: Use C++ exception handling.
6896         * linux-fork.c: Use C++ exception handling.
6897         * linespec.c: Use C++ exception handling.
6898         * language.c: Use C++ exception handling.
6899         * jit.c: Use C++ exception handling.
6900         * infrun.c: Use C++ exception handling.
6901         * infcmd.c: Use C++ exception handling.
6902         * infcall.c: Use C++ exception handling.
6903         * inf-loop.c: Use C++ exception handling.
6904         * i386-tdep.c: Use C++ exception handling.
6905         * i386-linux-tdep.c: Use C++ exception handling.
6906         * guile/scm-value.c: Use C++ exception handling.
6907         * guile/scm-type.c: Use C++ exception handling.
6908         * guile/scm-symtab.c: Use C++ exception handling.
6909         * guile/scm-symbol.c: Use C++ exception handling.
6910         * guile/scm-pretty-print.c: Use C++ exception handling.
6911         * guile/scm-ports.c: Use C++ exception handling.
6912         * guile/scm-param.c: Use C++ exception handling.
6913         * guile/scm-math.c: Use C++ exception handling.
6914         * guile/scm-lazy-string.c: Use C++ exception handling.
6915         * guile/scm-frame.c: Use C++ exception handling.
6916         * guile/scm-disasm.c: Use C++ exception handling.
6917         * guile/scm-cmd.c: Use C++ exception handling.
6918         * guile/scm-breakpoint.c: Use C++ exception handling.
6919         * guile/scm-block.c: Use C++ exception handling.
6920         * guile/guile-internal.h: Use C++ exception handling.
6921         * gnu-v3-abi.c: Use C++ exception handling.
6922         * gdbtypes.c: Use C++ exception handling.
6923         * frame.c: Use C++ exception handling.
6924         * frame-unwind.c: Use C++ exception handling.
6925         * fbsd-tdep.c: Use C++ exception handling.
6926         * f-valprint.c: Use C++ exception handling.
6927         * exec.c: Use C++ exception handling.
6928         * event-top.c: Use C++ exception handling.
6929         * event-loop.c: Use C++ exception handling.
6930         * eval.c: Use C++ exception handling.
6931         * dwarf2read.c: Use C++ exception handling.
6932         * dwarf2loc.c: Use C++ exception handling.
6933         * dwarf2-frame.c: Use C++ exception handling.
6934         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6935         * dwarf-index-write.c: Use C++ exception handling.
6936         * dwarf-index-cache.c: Use C++ exception handling.
6937         * dtrace-probe.c: Use C++ exception handling.
6938         * disasm-selftests.c: Use C++ exception handling.
6939         * darwin-nat.c: Use C++ exception handling.
6940         * cp-valprint.c: Use C++ exception handling.
6941         * cp-support.c: Use C++ exception handling.
6942         * cp-abi.c: Use C++ exception handling.
6943         * corelow.c: Use C++ exception handling.
6944         * completer.c: Use C++ exception handling.
6945         * compile/compile-object-run.c: Use C++ exception handling.
6946         * compile/compile-object-load.c: Use C++ exception handling.
6947         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6948         * compile/compile-c-symbols.c: Use C++ exception handling.
6949         * common/selftest.c: Use C++ exception handling.
6950         * common/new-op.c: Use C++ exception handling.
6951         * cli/cli-script.c: Use C++ exception handling.
6952         * cli/cli-interp.c: Use C++ exception handling.
6953         * cli/cli-cmds.c: Use C++ exception handling.
6954         * c-varobj.c: Use C++ exception handling.
6955         * btrace.c: Use C++ exception handling.
6956         * breakpoint.c: Use C++ exception handling.
6957         * break-catch-throw.c: Use C++ exception handling.
6958         * arch-utils.c: Use C++ exception handling.
6959         * amd64-tdep.c: Use C++ exception handling.
6960         * ada-valprint.c: Use C++ exception handling.
6961         * ada-typeprint.c: Use C++ exception handling.
6962         * ada-lang.c: Use C++ exception handling.
6963         * aarch64-tdep.c: Use C++ exception handling.
6964
6965 2019-04-08  Tom Tromey  <tom@tromey.com>
6966
6967         * xml-support.c (gdb_xml_parser::parse): Update.
6968         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6969         * value.c (show_convenience): Update.
6970         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6971         (test_parse_flags_qcs): Update.
6972         * thread.c (thr_try_catch_cmd): Update.
6973         * target.c (target_translate_tls_address): Update.
6974         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6975         (info_frame_command_core, frame_apply_command_count): Update.
6976         * rust-exp.y (rust_lex_exception_test): Update.
6977         * riscv-tdep.c (riscv_print_one_register_info): Update.
6978         * remote.c (remote_target::enable_btrace): Update.
6979         * record-btrace.c (record_btrace_enable_warn): Update.
6980         * python/py-utils.c (gdbpy_convert_exception): Update.
6981         * printcmd.c (do_one_display, print_variable_and_value): Update.
6982         * mi/mi-main.c (mi_print_exception): Update.
6983         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6984         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6985         * linux-nat.c (linux_nat_target::attach): Update.
6986         * linux-fork.c (class scoped_switch_fork_info): Update.
6987         * infrun.c (displaced_step_prepare): Update.
6988         * infcall.c (call_function_by_hand_dummy): Update.
6989         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6990         * gnu-v3-abi.c (print_one_vtable): Update.
6991         * frame.c (get_prev_frame_always): Update.
6992         * f-valprint.c (info_common_command_for_block): Update.
6993         * exec.c (try_open_exec_file): Update.
6994         * exceptions.c (print_exception, exception_print)
6995         (exception_fprintf, exception_print_same): Update.
6996         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6997         * dwarf-index-cache.c (index_cache::store)
6998         (index_cache::lookup_gdb_index): Update.
6999         * darwin-nat.c (maybe_cache_shell): Update.
7000         * cp-valprint.c (cp_print_value_fields): Update.
7001         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7002         (gcc_cplus_symbol_address): Update.
7003         * compile/compile-c-symbols.c (gcc_convert_symbol)
7004         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7005         * common/selftest.c: Update.
7006         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7007         a std::string.
7008         (exception_try_scope_entry, exception_try_scope_exit): Don't
7009         declare.
7010         (struct exception_try_scope): Remove.
7011         (TRY): Don't use exception_try_scope.
7012         (struct gdb_exception): Add constructor, operator=.
7013         <what>: New method.
7014         (struct gdb_exception_RETURN_MASK_ALL)
7015         (struct gdb_exception_RETURN_MASK_ERROR)
7016         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7017         (struct gdb_quit_bad_alloc): Update.
7018         * common/common-exceptions.c (exception_none): Change
7019         initializer.
7020         (struct catcher) <state, exception>: Initialize inline.
7021         <prev>: Remove member.
7022         (current_catcher): Remove.
7023         (catchers): New global.
7024         (exceptions_state_mc_init): Simplify.
7025         (catcher_pop): Remove.
7026         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7027         (try_scope_depth, exception_try_scope_entry)
7028         (exception_try_scope_exit): Remove.
7029         (throw_exception_sjlj): Update.
7030         (exception_messages, exception_messages_size): Remove.
7031         (throw_it): Simplify.
7032         (gdb_exception_sliced_copy): Remove.
7033         (throw_exception_cxx): Update.
7034         * cli/cli-script.c (script_from_file): Update.
7035         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7036         Update.
7037         * ada-valprint.c (ada_val_print): Update.
7038         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7039         (create_excep_cond_exprs): Update.
7040
7041 2019-04-08  Tom Tromey  <tom@tromey.com>
7042
7043         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7044         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7045         (TRY, CATCH, END_CATCH): Remove some definitions.
7046         * common/common-exceptions.c: Don't use GDB_XCPT.
7047         (catcher_list_size): Remove.
7048         (throw_exception, throw_it): Simplify.
7049
7050 2019-04-05  Tom Tromey  <tom@tromey.com>
7051
7052         Revert the header-sorting patch.
7053         * ft32-tdep.c: Revert.
7054         * frv-tdep.c: Revert.
7055         * frv-linux-tdep.c: Revert.
7056         * frame.c: Revert.
7057         * frame-unwind.c: Revert.
7058         * frame-base.c: Revert.
7059         * fork-child.c: Revert.
7060         * findvar.c: Revert.
7061         * findcmd.c: Revert.
7062         * filesystem.c: Revert.
7063         * filename-seen-cache.h: Revert.
7064         * filename-seen-cache.c: Revert.
7065         * fbsd-tdep.c: Revert.
7066         * fbsd-nat.h: Revert.
7067         * fbsd-nat.c: Revert.
7068         * f-valprint.c: Revert.
7069         * f-typeprint.c: Revert.
7070         * f-lang.c: Revert.
7071         * extension.h: Revert.
7072         * extension.c: Revert.
7073         * extension-priv.h: Revert.
7074         * expprint.c: Revert.
7075         * exec.h: Revert.
7076         * exec.c: Revert.
7077         * exceptions.c: Revert.
7078         * event-top.c: Revert.
7079         * event-loop.c: Revert.
7080         * eval.c: Revert.
7081         * elfread.c: Revert.
7082         * dwarf2read.h: Revert.
7083         * dwarf2read.c: Revert.
7084         * dwarf2loc.c: Revert.
7085         * dwarf2expr.h: Revert.
7086         * dwarf2expr.c: Revert.
7087         * dwarf2-frame.c: Revert.
7088         * dwarf2-frame-tailcall.c: Revert.
7089         * dwarf-index-write.h: Revert.
7090         * dwarf-index-write.c: Revert.
7091         * dwarf-index-common.c: Revert.
7092         * dwarf-index-cache.h: Revert.
7093         * dwarf-index-cache.c: Revert.
7094         * dummy-frame.c: Revert.
7095         * dtrace-probe.c: Revert.
7096         * disasm.h: Revert.
7097         * disasm.c: Revert.
7098         * disasm-selftests.c: Revert.
7099         * dictionary.c: Revert.
7100         * dicos-tdep.c: Revert.
7101         * demangle.c: Revert.
7102         * dcache.h: Revert.
7103         * dcache.c: Revert.
7104         * darwin-nat.h: Revert.
7105         * darwin-nat.c: Revert.
7106         * darwin-nat-info.c: Revert.
7107         * d-valprint.c: Revert.
7108         * d-namespace.c: Revert.
7109         * d-lang.c: Revert.
7110         * ctf.c: Revert.
7111         * csky-tdep.c: Revert.
7112         * csky-linux-tdep.c: Revert.
7113         * cris-tdep.c: Revert.
7114         * cris-linux-tdep.c: Revert.
7115         * cp-valprint.c: Revert.
7116         * cp-support.c: Revert.
7117         * cp-namespace.c: Revert.
7118         * cp-abi.c: Revert.
7119         * corelow.c: Revert.
7120         * corefile.c: Revert.
7121         * continuations.c: Revert.
7122         * completer.h: Revert.
7123         * completer.c: Revert.
7124         * complaints.c: Revert.
7125         * coffread.c: Revert.
7126         * coff-pe-read.c: Revert.
7127         * cli-out.h: Revert.
7128         * cli-out.c: Revert.
7129         * charset.c: Revert.
7130         * c-varobj.c: Revert.
7131         * c-valprint.c: Revert.
7132         * c-typeprint.c: Revert.
7133         * c-lang.c: Revert.
7134         * buildsym.c: Revert.
7135         * buildsym-legacy.c: Revert.
7136         * build-id.h: Revert.
7137         * build-id.c: Revert.
7138         * btrace.c: Revert.
7139         * bsd-uthread.c: Revert.
7140         * breakpoint.h: Revert.
7141         * breakpoint.c: Revert.
7142         * break-catch-throw.c: Revert.
7143         * break-catch-syscall.c: Revert.
7144         * break-catch-sig.c: Revert.
7145         * blockframe.c: Revert.
7146         * block.c: Revert.
7147         * bfin-tdep.c: Revert.
7148         * bfin-linux-tdep.c: Revert.
7149         * bfd-target.c: Revert.
7150         * bcache.c: Revert.
7151         * ax-general.c: Revert.
7152         * ax-gdb.h: Revert.
7153         * ax-gdb.c: Revert.
7154         * avr-tdep.c: Revert.
7155         * auxv.c: Revert.
7156         * auto-load.c: Revert.
7157         * arm-wince-tdep.c: Revert.
7158         * arm-tdep.c: Revert.
7159         * arm-symbian-tdep.c: Revert.
7160         * arm-pikeos-tdep.c: Revert.
7161         * arm-obsd-tdep.c: Revert.
7162         * arm-nbsd-tdep.c: Revert.
7163         * arm-nbsd-nat.c: Revert.
7164         * arm-linux-tdep.c: Revert.
7165         * arm-linux-nat.c: Revert.
7166         * arm-fbsd-tdep.c: Revert.
7167         * arm-fbsd-nat.c: Revert.
7168         * arm-bsd-tdep.c: Revert.
7169         * arch-utils.c: Revert.
7170         * arc-tdep.c: Revert.
7171         * arc-newlib-tdep.c: Revert.
7172         * annotate.h: Revert.
7173         * annotate.c: Revert.
7174         * amd64-windows-tdep.c: Revert.
7175         * amd64-windows-nat.c: Revert.
7176         * amd64-tdep.c: Revert.
7177         * amd64-sol2-tdep.c: Revert.
7178         * amd64-obsd-tdep.c: Revert.
7179         * amd64-obsd-nat.c: Revert.
7180         * amd64-nbsd-tdep.c: Revert.
7181         * amd64-nbsd-nat.c: Revert.
7182         * amd64-nat.c: Revert.
7183         * amd64-linux-tdep.c: Revert.
7184         * amd64-linux-nat.c: Revert.
7185         * amd64-fbsd-tdep.c: Revert.
7186         * amd64-fbsd-nat.c: Revert.
7187         * amd64-dicos-tdep.c: Revert.
7188         * amd64-darwin-tdep.c: Revert.
7189         * amd64-bsd-nat.c: Revert.
7190         * alpha-tdep.c: Revert.
7191         * alpha-obsd-tdep.c: Revert.
7192         * alpha-nbsd-tdep.c: Revert.
7193         * alpha-mdebug-tdep.c: Revert.
7194         * alpha-linux-tdep.c: Revert.
7195         * alpha-linux-nat.c: Revert.
7196         * alpha-bsd-tdep.c: Revert.
7197         * alpha-bsd-nat.c: Revert.
7198         * aix-thread.c: Revert.
7199         * agent.c: Revert.
7200         * addrmap.c: Revert.
7201         * ada-varobj.c: Revert.
7202         * ada-valprint.c: Revert.
7203         * ada-typeprint.c: Revert.
7204         * ada-tasks.c: Revert.
7205         * ada-lang.c: Revert.
7206         * aarch64-tdep.c: Revert.
7207         * aarch64-ravenscar-thread.c: Revert.
7208         * aarch64-newlib-tdep.c: Revert.
7209         * aarch64-linux-tdep.c: Revert.
7210         * aarch64-linux-nat.c: Revert.
7211         * aarch64-fbsd-tdep.c: Revert.
7212         * aarch64-fbsd-nat.c: Revert.
7213         * aarch32-linux-nat.c: Revert.
7214
7215 2019-04-05  Tom Tromey  <tom@tromey.com>
7216
7217         * ft32-tdep.c: Sort headers.
7218         * frv-tdep.c: Sort headers.
7219         * frv-linux-tdep.c: Sort headers.
7220         * frame.c: Sort headers.
7221         * frame-unwind.c: Sort headers.
7222         * frame-base.c: Sort headers.
7223         * fork-child.c: Sort headers.
7224         * findvar.c: Sort headers.
7225         * findcmd.c: Sort headers.
7226         * filesystem.c: Sort headers.
7227         * filename-seen-cache.h: Sort headers.
7228         * filename-seen-cache.c: Sort headers.
7229         * fbsd-tdep.c: Sort headers.
7230         * fbsd-nat.h: Sort headers.
7231         * fbsd-nat.c: Sort headers.
7232         * f-valprint.c: Sort headers.
7233         * f-typeprint.c: Sort headers.
7234         * f-lang.c: Sort headers.
7235         * extension.h: Sort headers.
7236         * extension.c: Sort headers.
7237         * extension-priv.h: Sort headers.
7238         * expprint.c: Sort headers.
7239         * exec.h: Sort headers.
7240         * exec.c: Sort headers.
7241         * exceptions.c: Sort headers.
7242         * event-top.c: Sort headers.
7243         * event-loop.c: Sort headers.
7244         * eval.c: Sort headers.
7245         * elfread.c: Sort headers.
7246         * dwarf2read.h: Sort headers.
7247         * dwarf2read.c: Sort headers.
7248         * dwarf2loc.c: Sort headers.
7249         * dwarf2expr.h: Sort headers.
7250         * dwarf2expr.c: Sort headers.
7251         * dwarf2-frame.c: Sort headers.
7252         * dwarf2-frame-tailcall.c: Sort headers.
7253         * dwarf-index-write.h: Sort headers.
7254         * dwarf-index-write.c: Sort headers.
7255         * dwarf-index-common.c: Sort headers.
7256         * dwarf-index-cache.h: Sort headers.
7257         * dwarf-index-cache.c: Sort headers.
7258         * dummy-frame.c: Sort headers.
7259         * dtrace-probe.c: Sort headers.
7260         * disasm.h: Sort headers.
7261         * disasm.c: Sort headers.
7262         * disasm-selftests.c: Sort headers.
7263         * dictionary.c: Sort headers.
7264         * dicos-tdep.c: Sort headers.
7265         * demangle.c: Sort headers.
7266         * dcache.h: Sort headers.
7267         * dcache.c: Sort headers.
7268         * darwin-nat.h: Sort headers.
7269         * darwin-nat.c: Sort headers.
7270         * darwin-nat-info.c: Sort headers.
7271         * d-valprint.c: Sort headers.
7272         * d-namespace.c: Sort headers.
7273         * d-lang.c: Sort headers.
7274         * ctf.c: Sort headers.
7275         * csky-tdep.c: Sort headers.
7276         * csky-linux-tdep.c: Sort headers.
7277         * cris-tdep.c: Sort headers.
7278         * cris-linux-tdep.c: Sort headers.
7279         * cp-valprint.c: Sort headers.
7280         * cp-support.c: Sort headers.
7281         * cp-namespace.c: Sort headers.
7282         * cp-abi.c: Sort headers.
7283         * corelow.c: Sort headers.
7284         * corefile.c: Sort headers.
7285         * continuations.c: Sort headers.
7286         * completer.h: Sort headers.
7287         * completer.c: Sort headers.
7288         * complaints.c: Sort headers.
7289         * coffread.c: Sort headers.
7290         * coff-pe-read.c: Sort headers.
7291         * cli-out.h: Sort headers.
7292         * cli-out.c: Sort headers.
7293         * charset.c: Sort headers.
7294         * c-varobj.c: Sort headers.
7295         * c-valprint.c: Sort headers.
7296         * c-typeprint.c: Sort headers.
7297         * c-lang.c: Sort headers.
7298         * buildsym.c: Sort headers.
7299         * buildsym-legacy.c: Sort headers.
7300         * build-id.h: Sort headers.
7301         * build-id.c: Sort headers.
7302         * btrace.c: Sort headers.
7303         * bsd-uthread.c: Sort headers.
7304         * breakpoint.h: Sort headers.
7305         * breakpoint.c: Sort headers.
7306         * break-catch-throw.c: Sort headers.
7307         * break-catch-syscall.c: Sort headers.
7308         * break-catch-sig.c: Sort headers.
7309         * blockframe.c: Sort headers.
7310         * block.c: Sort headers.
7311         * bfin-tdep.c: Sort headers.
7312         * bfin-linux-tdep.c: Sort headers.
7313         * bfd-target.c: Sort headers.
7314         * bcache.c: Sort headers.
7315         * ax-general.c: Sort headers.
7316         * ax-gdb.h: Sort headers.
7317         * ax-gdb.c: Sort headers.
7318         * avr-tdep.c: Sort headers.
7319         * auxv.c: Sort headers.
7320         * auto-load.c: Sort headers.
7321         * arm-wince-tdep.c: Sort headers.
7322         * arm-tdep.c: Sort headers.
7323         * arm-symbian-tdep.c: Sort headers.
7324         * arm-pikeos-tdep.c: Sort headers.
7325         * arm-obsd-tdep.c: Sort headers.
7326         * arm-nbsd-tdep.c: Sort headers.
7327         * arm-nbsd-nat.c: Sort headers.
7328         * arm-linux-tdep.c: Sort headers.
7329         * arm-linux-nat.c: Sort headers.
7330         * arm-fbsd-tdep.c: Sort headers.
7331         * arm-fbsd-nat.c: Sort headers.
7332         * arm-bsd-tdep.c: Sort headers.
7333         * arch-utils.c: Sort headers.
7334         * arc-tdep.c: Sort headers.
7335         * arc-newlib-tdep.c: Sort headers.
7336         * annotate.h: Sort headers.
7337         * annotate.c: Sort headers.
7338         * amd64-windows-tdep.c: Sort headers.
7339         * amd64-windows-nat.c: Sort headers.
7340         * amd64-tdep.c: Sort headers.
7341         * amd64-sol2-tdep.c: Sort headers.
7342         * amd64-obsd-tdep.c: Sort headers.
7343         * amd64-obsd-nat.c: Sort headers.
7344         * amd64-nbsd-tdep.c: Sort headers.
7345         * amd64-nbsd-nat.c: Sort headers.
7346         * amd64-nat.c: Sort headers.
7347         * amd64-linux-tdep.c: Sort headers.
7348         * amd64-linux-nat.c: Sort headers.
7349         * amd64-fbsd-tdep.c: Sort headers.
7350         * amd64-fbsd-nat.c: Sort headers.
7351         * amd64-dicos-tdep.c: Sort headers.
7352         * amd64-darwin-tdep.c: Sort headers.
7353         * amd64-bsd-nat.c: Sort headers.
7354         * alpha-tdep.c: Sort headers.
7355         * alpha-obsd-tdep.c: Sort headers.
7356         * alpha-nbsd-tdep.c: Sort headers.
7357         * alpha-mdebug-tdep.c: Sort headers.
7358         * alpha-linux-tdep.c: Sort headers.
7359         * alpha-linux-nat.c: Sort headers.
7360         * alpha-bsd-tdep.c: Sort headers.
7361         * alpha-bsd-nat.c: Sort headers.
7362         * aix-thread.c: Sort headers.
7363         * agent.c: Sort headers.
7364         * addrmap.c: Sort headers.
7365         * ada-varobj.c: Sort headers.
7366         * ada-valprint.c: Sort headers.
7367         * ada-typeprint.c: Sort headers.
7368         * ada-tasks.c: Sort headers.
7369         * ada-lang.c: Sort headers.
7370         * aarch64-tdep.c: Sort headers.
7371         * aarch64-ravenscar-thread.c: Sort headers.
7372         * aarch64-newlib-tdep.c: Sort headers.
7373         * aarch64-linux-tdep.c: Sort headers.
7374         * aarch64-linux-nat.c: Sort headers.
7375         * aarch64-fbsd-tdep.c: Sort headers.
7376         * aarch64-fbsd-nat.c: Sort headers.
7377         * aarch32-linux-nat.c: Sort headers.
7378
7379 2019-04-04  Tom Tromey  <tom@tromey.com>
7380
7381         * varobj.c (varobj_create): Update.
7382         * rust-exp.y (struct rust_parser) <update_innermost_block,
7383         lookup_symbol>: New methods.
7384         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7385         Rename.
7386         (rust_parser::rust_lookup_type)
7387         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7388         * printcmd.c (display_command, do_one_display): Update.
7389         * parser-defs.h (struct parser_state) <parser_state>: Add
7390         "tracker" parameter.
7391         (block_tracker): New member.
7392         (class innermost_block_tracker) <innermost_block_tracker>: Add
7393         "types" parameter.
7394         <reset>: Remove method.
7395         (innermost_block): Don't declare.
7396         (null_post_parser): Update.
7397         * parse.c (innermost_block): Remove global.
7398         (write_dollar_variable): Update.
7399         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7400         Remove "tracker_types" parameter.
7401         (parse_expression): Add "tracker" parameter.
7402         (parse_expression_for_completion): Update.
7403         (null_post_parser): Add "tracker" parameter.
7404         * p-exp.y: Update rules.
7405         * m2-exp.y: Update rules.
7406         * language.h (struct language_defn) <la_post_parser>: Add
7407         "tracker" parameter.
7408         * go-exp.y: Update rules.
7409         * f-exp.y: Update rules.
7410         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7411         parameter.
7412         * d-exp.y: Update rules.
7413         * c-exp.y: Update rules.
7414         * breakpoint.c (set_breakpoint_condition): Create an
7415         innermost_block_tracker.
7416         (watch_command_1): Likewise.
7417         * ada-lang.c (resolve): Add "tracker" parameter.
7418         (resolve_subexp): Likewise.
7419         * ada-exp.y (write_var_from_sym): Update.
7420
7421 2019-04-04  Tom Tromey  <tom@tromey.com>
7422
7423         * type-stack.h: New file.
7424         * type-stack.c: New file.
7425         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7426         type-stack.h.
7427         (insert_into_type_stack, insert_type, push_type, push_type_int)
7428         (insert_type_address_space, pop_type, pop_type_int)
7429         (pop_typelist, pop_type_stack, append_type_stack)
7430         (push_type_stack, get_type_stack, push_typelist)
7431         (follow_type_instance_flags, follow_types): Don't declare.
7432         * parse.c (type_stack): Remove global.
7433         (parse_exp_in_context): Update.
7434         (insert_into_type_stack, insert_type, push_type, push_type_int)
7435         (insert_type_address_space, pop_type, pop_type_int)
7436         (pop_typelist, pop_type_stack, append_type_stack)
7437         (push_type_stack, get_type_stack, push_typelist)
7438         (follow_type_instance_flags, follow_types): Remove (moved to
7439         type-stack.c).
7440         * f-exp.y (type_stack): New global.
7441         Update rules.
7442         (push_kind_type, f_parse): Update.
7443         * d-exp.y (type_stack): New global.
7444         Update rules.
7445         (d_parse): Update.
7446         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7447         Update rules.
7448         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7449         (HFILES_NO_SRCDIR): Add type-stack.h.
7450
7451 2019-04-04  Tom Tromey  <tom@tromey.com>
7452
7453         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7454         (rust_parser::convert_ast_to_expression, rust_parse)
7455         (rust_lex_test_completion, rust_lex_tests): Update.
7456         * parser-defs.h (struct expr_completion_state): New.
7457         (struct parser_state) <parser_state>: Add completion parameter.
7458         <mark_struct_expression, mark_completion_tag>: New methods.
7459         <parse_completion, m_completion_state>: New members.
7460         (prefixify_expression, null_post_parser): Update.
7461         (mark_struct_expression, mark_completion_tag): Don't declare.
7462         * parse.c (parse_completion, expout_last_struct)
7463         (expout_tag_completion_type, expout_completion_name): Remove
7464         globals.
7465         (parser_state::mark_struct_expression)
7466         (parser_state::mark_completion_tag): Now methods.
7467         (prefixify_expression): Add last_struct parameter.
7468         (prefixify_subexp): Likewise.
7469         (parse_exp_1): Update.
7470         (parse_exp_in_context): Add cstate parameter.  Update.
7471         (parse_expression_for_completion): Create an
7472         expr_completion_state.
7473         (null_post_parser): Add "completion" parameter.
7474         * p-exp.y: Update rules.
7475         (yylex): Update.
7476         * language.h (struct language_defn) <la_post_parser>: Add
7477         "completing" parameter.
7478         * go-exp.y: Update rules.
7479         (lex_one_token): Update.
7480         * expression.h (parse_completion): Don't declare.
7481         * d-exp.y: Update rules.
7482         (lex_one_token): Update rules.
7483         * c-exp.y: Update rules.
7484         (lex_one_token): Update.
7485         * ada-lang.c (resolve): Add "parse_completion" parameter.
7486         (resolve_subexp): Likewise.
7487         (ada_resolve_function): Likewise.
7488
7489 2019-04-04  Tom Tromey  <tom@tromey.com>
7490
7491         * parser-defs.h (struct parser_state) <start_arglist,
7492         end_arglist>: New methods.
7493         <arglist_len, m_funcall_chain>: New members.
7494         (arglist_len, start_arglist, end_arglist): Don't declare.
7495         * parse.c (arglist_len, funcall_chain): Remove global.
7496         (start_arglist, end_arglist): Remove functions.
7497         (parse_exp_in_context): Update.
7498         * p-exp.y: Update rules.
7499         * m2-exp.y: Update rules.
7500         * go-exp.y: Update rules.
7501         * f-exp.y: Update rules.
7502         * d-exp.y: Update rules.
7503         * c-exp.y: Update rules.
7504
7505 2019-04-04  Tom Tromey  <tom@tromey.com>
7506
7507         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7508         lex_operator, push_back>: New methods.
7509         Update all rules.
7510         (rust_parser::lex_hex, lex_escape): Rename and update.
7511         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7512         (rust_parser::lex_operator): Rename and update.
7513         (rust_parser::lex_number, rustyylex, rustyyerror)
7514         (rust_lex_test_init, rust_lex_test_sequence)
7515         (rust_lex_test_push_back, rust_lex_tests): Update.
7516         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7517         parameter.
7518         <lexptr, prev_lexptr>: New members.
7519         (lexptr, prev_lexptr): Don't declare.
7520         * parse.c (lexptr, prev_lexptr): Remove globals.
7521         (parse_exp_in_context): Update.
7522         * p-exp.y (yylex, yyerror): Update.
7523         * m2-exp.y (parse_number, yylex, yyerror): Update.
7524         * go-exp.y (lex_one_token, yyerror): Update.
7525         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7526         * d-exp.y (lex_one_token, yyerror): Update.
7527         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7528         (lex_one_token, yyerror): Update.
7529         * ada-lex.l (YY_INPUT): Update.
7530         (rewind_to_char): Update.
7531         * ada-exp.y (yyerror): Update.
7532
7533 2019-04-04  Tom Tromey  <tom@tromey.com>
7534
7535         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7536         * parser-defs.h (struct parser_state) <parser_state>: Add new
7537         parameter.
7538         <comma_terminates>: New member.
7539         (comma_terminates): Don't declare global.
7540         * parse.c (comma_terminates): Remove global.
7541         (parse_exp_in_context): Update.
7542         * p-exp.y (yylex): Update.
7543         * m2-exp.y (yylex): Update.
7544         * go-exp.y (lex_one_token): Update.
7545         * f-exp.y (yylex): Update.
7546         * d-exp.y (lex_one_token): Update.
7547         * c-exp.y (lex_one_token): Update.
7548         * ada-lex.l: Update.
7549
7550 2019-04-04  Tom Tromey  <tom@tromey.com>
7551
7552         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7553         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7554         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7555         * parser-defs.h (paren_depth): Don't declare.
7556         * parse.c (paren_depth): Remove global.
7557         (parse_exp_in_context): Update.
7558         * p-exp.y (paren_depth): New global.
7559         (pascal_parse): Initialize it.
7560         * m2-exp.y (paren_depth): New global.
7561         (m2_parse): Initialize it.
7562         * go-exp.y (paren_depth): New global.
7563         (go_parse): Initialize it.
7564         * f-exp.y (paren_depth): New global.
7565         (f_parse): Initialize it.
7566         * d-exp.y (paren_depth): New global.
7567         (d_parse): Initialize it.
7568         * c-exp.y (paren_depth): New global.
7569         (c_parse): Initialize it.
7570         * ada-lex.l (paren_depth): New global.
7571         (lexer_init): Initialize it.
7572
7573 2019-04-04  Tom Tromey  <tom@tromey.com>
7574
7575         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7576         (rust_parser::convert_ast_to_type)
7577         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7578         * parser-defs.h (struct parser_state) <parser_state>: Add
7579         parameters.  Initialize new members.
7580         <expression_context_block, expression_context_pc>: New members.
7581         * parse.c (expression_context_block, expression_context_pc):
7582         Remove globals.
7583         (parse_exp_in_context): Update.
7584         * p-exp.y: Update all rules.
7585         (yylex): Update.
7586         * m2-exp.y: Update all rules.
7587         (yylex): Update.
7588         * go-exp.y (yylex): Update.
7589         * f-exp.y (yylex): Update.
7590         * d-exp.y: Update all rules.
7591         (yylex): Update.
7592         * c-exp.y: Update all rules.
7593         (lex_one_token, classify_name, yylex, c_parse): Update.
7594         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7595
7596 2019-04-04  Tom Tromey  <tom@tromey.com>
7597
7598         * gdbarch.h, gdbarch.c: Rebuild.
7599         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7600         * stap-probe.h:
7601         (struct stap_parse_info): Replace "parser_state" with
7602         "expr_builder".
7603         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7604         (parser_state): New class.
7605         * parse.c (expr_builder): Rename.
7606         (expr_builder::release): Rename.
7607         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7608         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7609         (write_exp_elt_longcst, write_exp_elt_floatcst)
7610         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7611         (write_exp_string_vector, write_exp_bitstring)
7612         (write_exp_msymbol, mark_struct_expression)
7613         (write_dollar_variable)
7614         (insert_type_address_space, increase_expout_size): Replace
7615         "parser_state" with "expr_builder".
7616         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7617         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7618         "parser_state" with "expr_builder".
7619
7620 2019-04-04  Tom Tromey  <tom@tromey.com>
7621
7622         * rust-exp.y: Replace "parse_language" with method call.
7623         * p-exp.y:
7624         (yylex): Replace "parse_language" with method call.
7625         * m2-exp.y:
7626         (yylex): Replace "parse_language" with method call.
7627         * go-exp.y (classify_name): Replace "parse_language" with method
7628         call.
7629         * f-exp.y (yylex): Replace "parse_language" with method call.
7630         * d-exp.y (lex_one_token): Replace "parse_language" with method
7631         call.
7632         * c-exp.y:
7633         (lex_one_token, classify_name, yylex): Replace "parse_language"
7634         with method call.
7635         * ada-exp.y (find_primitive_type, type_char)
7636         (type_system_address): Replace "parse_language" with method call.
7637
7638 2019-04-04  Tom Tromey  <tom@tromey.com>
7639
7640         * rust-exp.y: Replace "parse_gdbarch" with method call.
7641         * parse.c (write_dollar_variable, insert_type_address_space):
7642         Replace "parse_gdbarch" with method call.
7643         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7644         call.
7645         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7646         call.
7647         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7648         "parse_gdbarch" with method call.
7649         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7650         with method call.
7651         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7652         "parse_gdbarch" with method call.
7653         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7654         "parse_gdbarch" with method call.
7655         * c-exp.y (parse_type, parse_number, classify_name): Replace
7656         "parse_gdbarch" with method call.
7657         * ada-lex.l: Replace "parse_gdbarch" with method call.
7658         * ada-exp.y (parse_type, find_primitive_type, type_char)
7659         (type_system_address): Replace "parse_gdbarch" with method call.
7660
7661 2019-04-04  Tom Tromey  <tom@tromey.com>
7662
7663         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7664         * stap-probe.c (stap_parse_argument): Update.
7665         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7666         initial_size parameter.
7667         * rust-exp.y (rust_lex_tests): Update.
7668         * parse.c (parser_state): Update.
7669         (parse_exp_in_context): Update.
7670         * parser-defs.h (struct parser_state) <parser_state>: Remove
7671         "initial_size" parameter.
7672
7673 2019-04-04  Tom Tromey  <tom@tromey.com>
7674
7675         * parser-defs.h (increase_expout_size): Don't declare.
7676         * parse.c (increase_expout_size): Now static.
7677
7678 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7679
7680         * gnu-nat.c (gnu_nat_target::wait): Fix
7681         target_waitstatus_to_string call.
7682
7683 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7684
7685         * eval.c (evaluate_subexp_standard): Handle internal functions
7686         during Fortran function call handling.
7687
7688 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7689
7690         * NEWS: Mention new internal functions.
7691         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7692         (read_base_type): Use dwarf2_init_complex_target_type.
7693         * value.c (creal_internal_fn): New function.
7694         (cimag_internal_fn): New function.
7695         (_initialize_values): Register new internal functions.
7696
7697 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7698
7699         * infrun.c (stop_all_threads): If debug_infrun, always
7700         trace the wait status after wait_one, using
7701         target_waitstatus_to_string and target_pid_to_str.
7702         (handle_inferior_event): Replace various trace of
7703         wait status kind by a single trace.
7704         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7705         wait status kind image by target_waitstatus_to_string.
7706         * target/waitstatus.c (target_waitstatus_to_string): Fix
7707         obsolete comment.
7708
7709 2019-04-01  Tom Tromey  <tromey@adacore.com>
7710
7711         PR symtab/23331:
7712         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7713
7714 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7715             Pedro Alves  <palves@redhat.com>
7716
7717         * top.c (quit_force): Call 'finalize_values'.
7718         * value.c (finalize_values): New function.
7719         * value.h (finalize_values): Declare.
7720
7721 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7722
7723         * NEWS: Announce $_gdb_major and $_gdb_minor.
7724
7725         * top.c (init_gdb_version_vars): New function.
7726         (gdb_init): Call init_gdb_version_vars.
7727
7728 2019-03-29  Tom Tromey  <tromey@adacore.com>
7729
7730         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7731         help text.  Remove dead code.
7732
7733 2019-03-29  Keith Seitz  <keiths@redhat.com>
7734
7735         From Siddhesh Poyarekar:
7736         * f-lang.h (f77_get_upperbound): Return LONGEST.
7737         (f77_get_lowerbound): Likewise.
7738         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7739         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7740         print them.
7741         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7742         plongest to format print it.
7743         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7744         (f77_get_upperbound): Likewise.
7745         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7746         LOWER_BOUND to LONGEST.
7747         (f77_create_arrayprint_offset_tbl): Likewise.
7748
7749 2019-03-29  Keith Seitz  <keiths@redhat.com>
7750
7751         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7752         %s/pulongest for TYPE_LENGTH instead of %d in format
7753         strings.
7754         * ada-typerint.c (ada_print_type): Likewise.
7755         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7756         * compile/compile-c-support.c (generate_register_struct): Likewise.
7757         * gdbtypes.c (recursive_dump_type): Likewise.
7758         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7759         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7760         instead of %d in format strings.
7761         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7762         to std::min to ULONGEST.
7763         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7764         instead of %d in format strings.
7765         * tracepoint.c (info_scope_command): Likewise.
7766         * typeprint.c (print_offset_data::update)
7767         (print_offset_data::finish): Likewise.
7768         * xtensa-tdep.c (xtensa_store_return_value)
7769         (xtensa_push_dummy_call): Likewise.
7770
7771 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7772
7773         * windows-nat.c (display_selector): Fixed format specifications
7774         for 64-bit Cygwin.
7775
7776 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7777
7778         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7779
7780 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7781
7782         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7783         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7784         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7785         (nios2_linux_init_abi): Install it.
7786
7787 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7788
7789         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7790
7791 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7792
7793         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7794
7795 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7796             Tom Tromey  <tromey@adacore.com>
7797
7798         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7799
7800 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7801
7802         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7803         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7804         method to compute the bounds of range types. Also print "[evaluated]"
7805         if the bounds' values come from a dynamic evaluation.
7806
7807 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7808
7809         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7810         whitespace when pretty printing is on.
7811
7812 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7813
7814         * ppc-linux-nat.c: Add include.
7815
7816 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7817
7818         * NEWS: Mention AArch64 Pointer Authentication.
7819
7820 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7821
7822         * arm-linux-nat.c: Add include.
7823
7824 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7825
7826         * source-cache.c (source_cache::get_source_lines): Re-read
7827         fullname after calling open_source_file.
7828
7829 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7830
7831         * NEWS: Mention TLS support for FreeBSD.
7832
7833 2019-03-25  Tom Tromey  <tromey@adacore.com>
7834
7835         * minsyms.c (BUNCH_SIZE): Update comment.
7836         (~minimal_symbol_reader): Remove old comment.
7837         (compact_minimal_symbols): Update comment.
7838         (minimal_symbol_reader::install): Remove old comment.  Update
7839         other comments.
7840
7841 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7842
7843         * s390-linux-nat.c: Add include.
7844
7845 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7846
7847         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7848         Call linux_get_hwcap.
7849         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7850         Likewise.
7851         (aarch64_linux_get_hwcap): Remove function.
7852         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7853         declaration.
7854         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7855         linux_get_hwcap.
7856         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7857         * linux-tdep.c (linux_get_hwcap): Add function.
7858         (linux_get_hwcap2): Likewise.
7859         * linux-tdep.h (linux_get_hwcap): Add declaration.
7860         (linux_get_hwcap2): Likewise.
7861         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7862         (ppc_linux_get_hwcap2): Likewise.
7863         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7864         linux_get_hwcap.
7865         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7866         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7867         (ppc_linux_nat_target::read_description): Likewise.
7868         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7869         * s390-linux-nat.c: Likewise.
7870         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7871
7872 2019-03-24  Tom Tromey  <tom@tromey.com>
7873
7874         * ada-lang.c (standard_lookup): Simplify initialization.
7875         (ada_lookup_symbol_nonlocal): Simplify return.
7876         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7877         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7878         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7879         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7880         initialization.
7881         * solib.c (solib_global_lookup): Simplify.
7882         * symtab.c (null_block_symbol): Remove.
7883         (symbol_cache_lookup): Simplify returns.
7884         (lookup_language_this): Simplify returns.
7885         (lookup_symbol_aux): Simplify return.
7886         (lookup_local_symbol): Simplify returns.
7887         (lookup_global_symbol_from_objfile): Simplify return.
7888         (lookup_symbol_in_objfile_symtabs)
7889         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7890         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7891         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7892         * cp-namespace.c (cp_lookup_bare_symbol)
7893         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7894         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7895         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7896         (cp_lookup_symbol_via_imports): Simplify initialization.
7897         (find_symbol_in_baseclass): Likewise.
7898         * symtab.h (null_block_symbol): Remove.
7899         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7900         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7901         (d_lookup_symbol_module): Likewise.
7902         (find_symbol_in_baseclass): Simplify initialization.
7903
7904 2019-03-24  Tom Tromey  <tom@tromey.com>
7905
7906         * expression.h: Don't include symtab.h.
7907         (struct block): Forward declare.
7908
7909 2019-03-24  Tom Tromey  <tom@tromey.com>
7910
7911         * c-exp.y (typebase): Remove casts.
7912         * gdbtypes.c (lookup_unsigned_typename, )
7913         (lookup_signed_typename): Remove cast.
7914         * eval.c (parse_to_comma_and_eval): Remove cast.
7915         * parse.c (write_dollar_variable): Remove cast.
7916         * block.h (struct block) <superblock>: Now const.
7917         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7918         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7919         (map_block): Make "block" const.
7920         * symfile.h (struct quick_symbol_functions)
7921         <map_matching_symbols>: Constify block argument to "callback".
7922         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7923         const.
7924         (find_pc_sect_compunit_symtab): Make "b" const.
7925         (find_symbol_at_address): Likewise.
7926         (search_symbols): Likewise.
7927         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7928         (dw2_debug_names_lookup_symbol): Likewise.
7929         (dw2_map_matching_symbols): Update.
7930         * p-valprint.c (pascal_val_print): Remove "block".
7931         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7932         (aux_add_nonlocal_symbols): Make "block" const.
7933         (resolve_subexp): Remove cast.
7934         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7935         const.
7936         (iterate_over_file_blocks): Likewise.
7937         * f-exp.y (%union) <bval>: Remove.
7938         * coffread.c (patch_opaque_types): Make "b" const.
7939         * spu-tdep.c (spu_catch_start): Make "block" const.
7940         * c-valprint.c (print_unpacked_pointer): Remove "block".
7941         * symmisc.c (dump_symtab_1): Make "b" const.
7942         (block_depth): Make "block" const.
7943         * d-exp.y (%union) <bval>: Remove.
7944         * cp-support.h (cp_lookup_rtti_type): Update.
7945         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7946         * psymtab.c (psym_lookup_symbol): Make "block" const.
7947         (maintenance_check_psymtabs): Make "b" const.
7948         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7949         (enumerate_locals, enumerate_args): Update.
7950         * python/py-symtab.c (stpy_global_block): Make "block" const.
7951         (stpy_static_block): Likewise.
7952         * inline-frame.c (block_starting_point_at): Make "new_block"
7953         const.
7954         * block.c (find_block_in_blockvector): Make return type const.
7955         (blockvector_for_pc_sect): Make "b" const.
7956         (find_block_in_blockvector): Make "b" const.
7957
7958 2019-03-23  Tom Tromey  <tom@tromey.com>
7959
7960         * varobj.c (varobj_create): Update.
7961         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7962         * printcmd.c (display_command, do_one_display): Don't reset
7963         innermost_block.
7964         * parser-defs.h (enum innermost_block_tracker_type): Move to
7965         expression.h.
7966         (innermost_block): Update comment.
7967         * parse.c (parse_exp_1): Add tracker_types parameter.
7968         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7969         tracker_types parameter.  Reset innermost_block.
7970         (parse_exp_in_context): Remove.
7971         (parse_expression_for_completion): Update.
7972         * objfiles.c (~objfile): Don't reset expression_context_block or
7973         innermost_block.
7974         * expression.h (enum innermost_block_tracker_type): Move from
7975         parser-defs.h.
7976         (parse_exp_1): Add tracker_types parameter.
7977         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7978         reset innermost_block.
7979
7980 2019-03-23  Tom Tromey  <tom@tromey.com>
7981
7982         * objfiles.h: Include bcache.h.
7983
7984 2019-03-23  Tom Tromey  <tom@tromey.com>
7985
7986         * linespec.c (get_current_search_block): Use
7987         scoped_restore_current_language.
7988         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7989
7990 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7991             Jiong Wang  <jiong.wang@arm.com>
7992
7993         * aarch64-linux-tdep.c
7994         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7995         section.
7996         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7997
7998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7999             Jiong Wang  <jiong.wang@arm.com>
8000
8001         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8002         instructions.
8003         (aarch64_analyze_prologue_test): Add PACIASP test.
8004         (aarch64_prologue_prev_register): Unmask PC value.
8005
8006 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8007             Jiong Wang  <jiong.wang@arm.com>
8008
8009         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8010         (aarch64_dwarf2_prev_register): Unmask PC value.
8011         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8012         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8013         DW_CFA_AARCH64_negate_ra_state.
8014         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8015
8016 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8017             Jiong Wang  <jiong.wang@arm.com>
8018
8019         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8020         registers.
8021         (aarch64_pseudo_register_name): Likewise.
8022         (aarch64_pseudo_register_type): Likewise.
8023         (aarch64_pseudo_register_reggroup_p): Likewise.
8024         (aarch64_gdbarch_init): Add pauth registers.
8025         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8026         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8027         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8028         (struct gdbarch_tdep): Add regnum for ra_state.
8029
8030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8031             Jiong Wang  <jiong.wang@arm.com>
8032
8033         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8034
8035 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8036             Jiong Wang  <jiong.wang@arm.com>
8037
8038         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8039         function.
8040         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8041         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8042         (aarch64_gdbarch_init): Add puth registers.
8043         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8044         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8045         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8046
8047 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8048             Jiong Wang  <jiong.wang@arm.com>
8049
8050         * aarch64-linux-nat.c
8051         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8052         * aarch64-linux-tdep.c
8053         (aarch64_linux_core_read_description): Likewise.
8054         (aarch64_linux_get_hwcap): New function.
8055         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8056         (aarch64_linux_get_hwcap): New declaration.
8057
8058 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8059             Jiong Wang  <jiong.wang@arm.com>
8060
8061         * aarch64-linux-nat.c
8062         (aarch64_linux_nat_target::read_description): Add pauth param.
8063         * aarch64-linux-tdep.c
8064         (aarch64_linux_core_read_description): Likewise.
8065         * aarch64-tdep.c (struct target_desc): Add in pauth.
8066         (aarch64_read_description): Add pauth param.
8067         (aarch64_gdbarch_init): Likewise.
8068         * aarch64-tdep.h (aarch64_read_description): Likewise.
8069         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8070         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8071         * features/Makefile: Add new files.
8072         * features/aarch64-pauth.c: New file.
8073         * features/aarch64-pauth.xml: New file.
8074
8075 2019-03-20  Tom Tromey  <tromey@adacore.com>
8076
8077         * infrun.c (handle_inferior_event): Rename from
8078         handle_inferior_event_1.  Create a scoped_value_mark.
8079         (handle_inferior_event): Remove.
8080
8081 2019-03-19  Tom Tromey  <tromey@adacore.com>
8082
8083         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8084         * infrun.h (print_stop_event): Add "displays" parameter.
8085         * infrun.c (print_stop_event): Add "displays" parameter.
8086
8087 2019-03-19  Pedro Alves  <palves@redhat.com>
8088
8089         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8090         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8091         to -1.  Fix TABs vs spaces.
8092         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8093         * tui/tui-out.h (tui_ui_out) Add intro comments.
8094         <m_line, m_start_of_line>: In-class initialize, and add describing
8095         comment.
8096
8097 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8098
8099         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8100         variable names.
8101         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8102
8103 2019-03-18  Pedro Alves  <palves@redhat.com>
8104             Eli Zaretskii <eliz@gnu.org>
8105
8106         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8107         m_line and m_start_of_line.
8108
8109 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8110
8111         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8112         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8113         it returns a newline.  This fixes a regression in TU mode, whereby
8114         the next line is output on the same screen line as the user input.
8115
8116 2019-03-18  Tom Tromey  <tromey@adacore.com>
8117
8118         * minsyms.c (minimal_symbol_reader::install): Remove call to
8119         obstack_blank.
8120
8121 2019-03-18  Pedro Alves  <palves@redhat.com>
8122
8123         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8124         New globals.
8125         (apply_style): New, factored out from ...
8126         (apply_ansi_escape): ... this.  Handle reverse video mode.
8127         (tui_set_reverse_mode): New function.
8128         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8129         * tui/tui-winsource.c (tui_show_source_line): Use
8130         tui_set_reverse_mode instead of setting A_STANDOUT.
8131         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8132         New setter methods.
8133
8134 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8135
8136         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8137         Handle tabs.
8138
8139 2019-03-18  Tom Tromey  <tromey@adacore.com>
8140
8141         * ada-lang.c (empty_array): Add "high" parameter.
8142         (ada_evaluate_subexp): Update.
8143
8144 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8145
8146         * unittests/string_view-selftests.c: Define
8147         _initialize_string_view_selftests unconditionally.
8148
8149 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8150
8151         PR gdb/24350
8152         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8153
8154 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8155
8156         PR gdb/24351
8157         * windows-nat.c (display_selector): Fix format specifiers.
8158
8159 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8160
8161         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8162         tui_refill_source_window instead of tui_refresh_win, to update the
8163         current execution line.  This fixes redisplay of the current line
8164         when stepping through the code with "next" or "step".
8165
8166 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8167
8168         * source-cache.c (source_cache::get_source_lines): Call
8169         find_source_lines to initialize s->nlines.  This fixes vertical
8170         scrolling of TUI source window when the DOWN arrow is pressed.
8171
8172 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8173
8174         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8175         linux-thread-db.c (_initialize_thread_db): Likewise.
8176
8177 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8178
8179         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8180         wclrtoeol in tui_show_source_line".  This reverts changes made in
8181         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8182
8183 2019-03-15  Tom Tromey  <tom@tromey.com>
8184
8185         * symtab.h (struct minimal_symbol): Derive from
8186         general_symbol_info.
8187         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8188         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8189         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8190         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8191         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8192         (MSYMBOL_SEARCH_NAME): Update.
8193         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8194         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8195         * minsyms.c (minimal_symbol_reader::record_full): Update.
8196
8197 2019-03-15  Tom Tromey  <tom@tromey.com>
8198
8199         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8200
8201 2019-03-15  Tom Tromey  <tom@tromey.com>
8202
8203         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8204         unique_xmalloc_ptr.
8205         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8206         Update.
8207         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8208         (build_minimal_symbol_hash_tables)
8209         (minimal_symbol_reader::install): Update.
8210
8211 2019-03-15  Tom Tromey  <tom@tromey.com>
8212
8213         * symtab.c (create_demangled_names_hash): Update.
8214         (symbol_set_names): Update.
8215         * objfiles.h (struct objfile_per_bfd_storage)
8216         <demangled_names_hash>: Now an htab_up.
8217         * objfiles.c (objfile_per_bfd_storage): Simplify.
8218
8219 2019-03-15  Tom Tromey  <tom@tromey.com>
8220
8221         * objfiles.h (struct objfile_per_bfd_storage): Declare
8222         destructor.
8223         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8224         New.
8225         (get_objfile_bfd_data): Use new.  Don't initialize
8226         language_of_main.
8227         (free_objfile_per_bfd_storage): Remove.
8228         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8229
8230 2019-03-15  Tom Tromey  <tom@tromey.com>
8231
8232         * symfile.c (reread_symbols): Update.
8233         * objfiles.c (objfile::objfile): Update.
8234         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8235         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8236         comment.
8237         (minimal_symbol_reader::install): Update.
8238         (terminate_minimal_symbol_table): Remove.
8239         * jit.c (jit_object_close_impl): Update.
8240
8241 2019-03-15  Tom Tromey  <tom@tromey.com>
8242
8243         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8244         initializations.
8245
8246 2019-03-15  Tom Tromey  <tom@tromey.com>
8247
8248         * objfiles.h (struct objfile_per_bfd_storage)
8249         <demangled_hash_languages>: Now a bitset.
8250         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8251         (lookup_minimal_symbol): Update.
8252
8253 2019-03-15  Tom Tromey  <tom@tromey.com>
8254
8255         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8256         Don't return the symbol.
8257         * coffread.c (record_minimal_symbol): Use record_full.
8258
8259 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8260
8261         The MS-Windows port of ncurses fails to switch to a color pair if
8262         one or both of the colors are the implicit default colors.  This
8263         change records the default colors when TUI is initialized, and
8264         then specifies them explicitly when a color pair uses the default
8265         colors.  This allows color styling in TUI mode on MS-Windows.
8266
8267         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8268         ncurses_norm_attr.
8269         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8270         colors in ncurses_norm_attr.
8271         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8272         "none", replace it with the default color recorded in
8273         ncurses_norm_attr.
8274
8275 2019-03-14  Tom Tromey  <tromey@adacore.com>
8276
8277         * source-cache.h (class source_cache) <get_source_lines>: Return
8278         std::string.
8279         * source-cache.c (source_cache::extract_lines): Handle case where
8280         first_pos==npos.  Return std::string.
8281         (source_cache::get_source_lines): Update.
8282
8283 2019-03-14  Tom Tromey  <tromey@adacore.com>
8284
8285         * NEWS: Add item for "style sources" commands.
8286         * source-cache.c (source_cache::get_source_lines): Check
8287         source_styling.
8288         * cli/cli-style.c (source_styling): New global.
8289         (_initialize_cli_style): Add "style sources" commands.
8290         (show_style_sources): New function.
8291         * cli/cli-style.h (source_styling): Declare.
8292
8293 2019-03-14  Pedro Alves  <palves@redhat.com>
8294             Tom Tromey  <tromey@adacore.com>
8295
8296         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8297         * tui/tui-winsource.c (tui_refill_source_window): New function,
8298         from...
8299         (tui_horizontal_source_scroll): ... here.  Move some logic.
8300         * cli/cli-style.c (set_style_enabled): Notify new observable.
8301         * tui/tui-hooks.c (tui_redisplay_source): New function.
8302         (tui_attach_detach_observers): Attach or detach
8303         tui_redisplay_source.
8304         * observable.h (source_styling_changed): New observable.
8305         * observable.c: Define source_styling_changed observable.
8306
8307 2019-03-13  Tom Tromey  <tromey@adacore.com>
8308
8309         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8310         (i386_gnu_nat_target::store_registers): Update.
8311         * target-debug.h (target_debug_print_std_string): New macro.
8312         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8313         * windows-tdep.c (display_one_tib): Update.
8314         * tui/tui-stack.c (tui_make_status_line): Update.
8315         * top.c (print_inferior_quit_action): Update.
8316         * thread.c (thr_try_catch_cmd): Update.
8317         (add_thread_with_info): Update.
8318         (thread_target_id_str): Update.
8319         (thr_try_catch_cmd): Update.
8320         (thread_command): Update.
8321         (thread_find_command): Update.
8322         * record-btrace.c (record_btrace_target::info_record)
8323         (record_btrace_resume_thread, record_btrace_target::resume)
8324         (record_btrace_cancel_resume, record_btrace_step_thread)
8325         (record_btrace_target::wait, record_btrace_target::wait)
8326         (record_btrace_target::wait, record_btrace_target::stop): Update.
8327         * progspace.c (print_program_space): Update.
8328         * process-stratum-target.c
8329         (process_stratum_target::thread_address_space): Update.
8330         * linux-fork.c (linux_fork_mourn_inferior)
8331         (detach_checkpoint_command, info_checkpoints_command)
8332         (linux_fork_context): Update.
8333         (linux_fork_detach): Update.
8334         (class scoped_switch_fork_info): Update.
8335         (delete_checkpoint_command): Update.
8336         * infrun.c (follow_fork_inferior): Update.
8337         (follow_fork_inferior): Update.
8338         (proceed_after_vfork_done): Update.
8339         (handle_vfork_child_exec_or_exit): Update.
8340         (follow_exec): Update.
8341         (displaced_step_prepare_throw): Update.
8342         (displaced_step_restore): Update.
8343         (start_step_over): Update.
8344         (resume_1): Update.
8345         (clear_proceed_status_thread): Update.
8346         (proceed): Update.
8347         (print_target_wait_results): Update.
8348         (do_target_wait): Update.
8349         (context_switch): Update.
8350         (stop_all_threads): Update.
8351         (restart_threads): Update.
8352         (finish_step_over): Update.
8353         (handle_signal_stop): Update.
8354         (switch_back_to_stepped_thread): Update.
8355         (keep_going_pass_signal): Update.
8356         (print_exited_reason): Update.
8357         (normal_stop): Update.
8358         * inferior.c (inferior_pid_to_str): Change return type.
8359         (print_selected_inferior): Update.
8360         (add_inferior): Update.
8361         (detach_inferior): Update.
8362         * dummy-frame.c (fprint_dummy_frames): Update.
8363         * dcache.c (dcache_info_1): Update.
8364         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8365         (btrace_fetch, btrace_clear): Update.
8366         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8367         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8368         type.
8369         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8370         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8371         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8372         * gdbarch.c, gdbarch.h: Rebuild.
8373         * gdbarch.sh (core_pid_to_str): Change return type.
8374         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8375         return type.
8376         (windows_nat_target::pid_to_str): Change return type.
8377         (windows_delete_thread): Update.
8378         (windows_nat_target::attach): Update.
8379         (windows_nat_target::files_info): Update.
8380         * target-delegates.c: Rebuild.
8381         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8382         return type.
8383         (sol_thread_target::pid_to_str): Change return type.
8384         * remote.c (class remote_target) <pid_to_str>: Change return
8385         type.
8386         (remote_target::pid_to_str): Change return type.
8387         (extended_remote_target::attach, remote_target::remote_stop_ns)
8388         (remote_target::remote_notif_remove_queued_reply)
8389         (remote_target::push_stop_reply, remote_target::disable_btrace):
8390         Update.
8391         (extended_remote_target::attach): Update.
8392         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8393         type.
8394         (gdbsim_target::pid_to_str): Change return type.
8395         * ravenscar-thread.c (struct ravenscar_thread_target)
8396         <pid_to_str>: Change return type.
8397         (ravenscar_thread_target::pid_to_str): Change return type.
8398         * procfs.c (class procfs_target) <pid_to_str>: Change return
8399         type.
8400         (procfs_target::pid_to_str): Change return type.
8401         (procfs_target::attach): Update.
8402         (procfs_target::detach): Update.
8403         (procfs_target::fetch_registers): Update.
8404         (procfs_target::store_registers): Update.
8405         (procfs_target::wait): Update.
8406         (procfs_target::files_info): Update.
8407         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8408         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8409         return type.
8410         (nto_procfs_target::pid_to_str): Change return type.
8411         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8412         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8413         return type.
8414         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8415         (exit_lwp): Update.
8416         (attach_proc_task_lwp_callback, get_detach_signal)
8417         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8418         (linux_nat_target::resume, wait_lwp, stop_callback)
8419         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8420         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8421         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8422         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8423         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8424         type.
8425         (inf_ptrace_target::attach): Update.
8426         (inf_ptrace_target::files_info): Update.
8427         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8428         type.
8429         (go32_nat_target::pid_to_str): Change return type.
8430         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8431         (gnu_nat_target::wait): Update.
8432         (gnu_nat_target::wait): Update.
8433         (gnu_nat_target::resume): Update.
8434         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8435         (fbsd_nat_target::wait): Update.
8436         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8437         type.
8438         (darwin_nat_target::attach): Update.
8439         * corelow.c (class core_target) <pid_to_str>: Change return type.
8440         (core_target::pid_to_str): Change return type.
8441         * target.c (normal_pid_to_str): Change return type.
8442         (default_pid_to_str): Likewise.
8443         (target_pid_to_str): Change return type.
8444         (target_translate_tls_address): Update.
8445         (target_announce_detach): Update.
8446         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8447         return type.
8448         (bsd_uthread_target::pid_to_str): Change return type.
8449         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8450         type.
8451         (bsd_kvm_target::pid_to_str): Change return type.
8452         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8453         return type.
8454         (aix_thread_target::pid_to_str): Change return type.
8455         * target.h (struct target_ops) <pid_to_str>: Change return type.
8456         (target_pid_to_str, normal_pid_to_str): Likewise.
8457         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8458         type.
8459         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8460         type.
8461         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8462         return type.
8463         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8464         type.
8465         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8466         type.
8467         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8468         return type.
8469
8470 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8471
8472         * NEWS: Mention that the new default MI version is 3.  Mention
8473         changes to the output of commands and events that deal with
8474         multi-location breakpoints.
8475         * breakpoint.c: Include "mi/mi-out.h".
8476         (print_one_breakpoint): Change output syntax if using MI version
8477         >= 3.
8478         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8479         New.
8480         (mi_multi_location_breakpoint_output_fixed): New.
8481         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8482         (mi_cmd_fix_multi_location_breakpoint_output): New.
8483         (mi_multi_location_breakpoint_output_fixed): New.
8484         * mi/mi-cmds.c (mi_cmds): Register command
8485         -fix-multi-location-breakpoint-output.
8486         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8487         interpreter "mi".
8488
8489 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8490
8491         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8492         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8493         instantiate mi_ui_out based on interpreter name.
8494         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8495         * mi/mi-main.c (mi_load_progress): Likewise.
8496
8497 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8498
8499         * NEWS: Combine separate "New targets" sections for 8.3.
8500
8501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8502
8503         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8504         (ppcfbsd_init_abi): Install gdbarch
8505         "fetch_tls_load_module_address" and "get_thread_local_address"
8506         methods.
8507
8508 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8509
8510         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8511         (riscv_fbsd_init_abi): Install gdbarch
8512         "fetch_tls_load_module_address" and "get_thread_local_address"
8513         methods.
8514
8515 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8516
8517         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8518         (i386fbsd_init_abi): Install gdbarch
8519         "fetch_tls_load_module_address" and "get_thread_local_address"
8520         methods.
8521
8522 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8523
8524         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8525         (amd64fbsd_init_abi): Install gdbarch
8526         "fetch_tls_load_module_address" and "get_thread_local_address"
8527         methods.
8528
8529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8530
8531         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8532         (struct fbsd_pspace_data): New type.
8533         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8534         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8535         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8536         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8537         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8538
8539 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8540
8541         * gdbtypes.c (lookup_struct_elt): New function.
8542         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8543         * gdbtypes.h (struct struct_elt): New type.
8544         (lookup_struct_elt): New prototype.
8545
8546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8547
8548         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8549         remove disabled code block.
8550
8551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8552
8553         * gdbarch.sh (get_thread_local_address): New method.
8554         * gdbarch.h, gdbarch.c: Regenerate.
8555         * target.c (target_translate_tls_address): Use
8556         gdbarch_get_thread_local_address if present instead of
8557         target::get_thread_local_address.
8558
8559 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8560
8561         * target.h (target::get_thread_local_address): Update comment.
8562
8563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8564
8565         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8566         objfile->separate_debug_objfile_backlink if not NULL.
8567
8568 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8569
8570         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8571         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8572         (amd64bsd_store_inferior_registers): Likewise.
8573         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8574         Enable segment base registers.
8575         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8576         PT_GETFSBASE and PT_GETGSBASE.
8577         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8578         PT_SETGSBASE.
8579         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8580         segment base registers.
8581         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8582
8583 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8584
8585         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8586         Update calls to i386_target_description to add 'segments'
8587         parameter.
8588         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8589         add segment base registers.
8590         * arch/i386.c (i386_create_target_description): Add 'segments'
8591         parameter to enable segment base registers.
8592         * arch/i386.h (i386_create_target_description): Likewise.
8593         * features/i386/32bit-segments.xml: New file.
8594         * features/i386/32bit-segments.c: Generate.
8595         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8596         call to i386_target_description to add 'segments' parameter.
8597         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8598         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8599         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8600         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8601         if feature is present.
8602         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8603         Add 'segments' parameter to call to i386_target_description.
8604         (i386_target_description): Add 'segments' parameter to enable
8605         segment base registers.
8606         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8607         to call to i386_target_description.
8608         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8609         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8610         Define I386_NUM_REGS.
8611         (i386_target_description): Add 'segments' parameter to enable
8612         segment base registers.
8613
8614 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8615
8616         PR/24325
8617         * source-cache.c: #undef open and close, to avoid unresolved
8618         externals during linking.
8619
8620 2019-03-12  Tom Tromey  <tromey@adacore.com>
8621
8622         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8623         const.  Add initializers.
8624         (_initialize_remote): Don't initialize ptid globals.
8625
8626 2019-03-12  Pedro Alves  <palves@redhat.com>
8627
8628         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8629
8630 2019-03-12  Pedro Alves  <palves@redhat.com>
8631
8632         * cp-name-parser.y (main): Remove unused 'len' variable.
8633
8634 2019-03-12  Tom Tromey  <tromey@adacore.com>
8635
8636         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8637         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8638
8639 2019-03-12  Tom Tromey  <tromey@adacore.com>
8640
8641         * linux-nat.c (iterate_over_lwps): Update.
8642         (stop_callback): Remove parameter.
8643         (stop_wait_callback, detach_callback, resume_set_callback)
8644         (select_singlestep_lwp_callback, set_ignore_sigint)
8645         (status_callback, resumed_callback, resume_clear_callback)
8646         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8647         data parameter.
8648         (linux_nat_target::detach, linux_nat_target::resume)
8649         (linux_stop_and_wait_all_lwps, select_event_lwp)
8650         (linux_nat_filter_event, linux_nat_wait_1)
8651         (linux_nat_target::kill, linux_nat_target::stop)
8652         (linux_nat_target::stop): Update.
8653         (linux_nat_resume_callback): Change type.
8654         (resume_stopped_resumed_lwps, count_events_callback)
8655         (select_event_lwp_callback): Likewise.
8656         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8657         * arm-linux-nat.c (struct update_registers_data): Remove.
8658         (update_registers_callback): Change type.
8659         (arm_linux_insert_hw_breakpoint1): Update.
8660         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8661         parameter.
8662         (x86_linux_dr_set_addr): Update.
8663         (x86_linux_dr_set_control): Update.
8664         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8665         (iterate_over_lwps): Use gdb::function_view.
8666         * nat/aarch64-linux-hw-point.c (struct
8667         aarch64_dr_update_callback_param): Remove.
8668         (debug_reg_change_callback): Change type.
8669         (aarch64_notify_debug_reg_change): Update.
8670         * s390-linux-nat.c (s390_refresh_per_info): Update.
8671
8672 2019-03-11  Tom Tromey  <tromey@adacore.com>
8673
8674         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8675         redundant assignment to "this_cu".
8676
8677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8678
8679         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8680
8681 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8682
8683         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8684         from...
8685         (rank_one_type): ... this.
8686
8687 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8688
8689         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8690         from...
8691         (rank_one_type): ... this.
8692
8693 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8694
8695         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8696         from...
8697         (rank_one_type): ... this.
8698
8699 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8700
8701         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8702         from...
8703         (rank_one_type): ... this.
8704
8705 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8706
8707         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8708         from...
8709         (rank_one_type): ... this.
8710
8711 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8712
8713         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8714         from...
8715         (rank_one_type): ... this.
8716
8717 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8718
8719         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8720         from...
8721         (rank_one_type): ... this.
8722
8723 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8724
8725         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8726         from...
8727         (rank_one_type): ... this.
8728
8729 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8730
8731         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8732         from...
8733         (rank_one_type): ... this.
8734
8735 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8736
8737         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8738         from...
8739         (rank_one_type): ... this.
8740
8741 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8742
8743         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8744         from...
8745         (rank_one_type): ... this.
8746
8747 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8748
8749         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8750         from...
8751         (rank_one_type): ... this.
8752
8753 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8754
8755         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8756         inferior-events' shows the example events.
8757
8758 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8759
8760         Support styling on native MS-Windows console
8761
8762         PR/24315
8763         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8764         on MS-Windows if $TERM is not defined.
8765
8766         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8767
8768         * posix-hdep.c (gdb_console_fputs):
8769         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8770         functions.
8771         * ui-file.h (gdb_console_fputs): Add prototype.
8772
8773         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8774         back to fputs only if the former returns zero.
8775
8776 2019-03-07  Tom Tromey  <tom@tromey.com>
8777
8778         * symmisc.c (print_symbol_bcache_statistics): Update.
8779         (print_objfile_statistics): Update.
8780         * symfile.c (allocate_symtab): Update.
8781         * stabsread.c: Don't include bcache.h.
8782         * psymtab.h (struct psymbol_bcache): Don't declare.
8783         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8784         (psymbol_bcache_init, psymbol_bcache_free)
8785         (psymbol_bcache_get_bcache): Don't declare.
8786         * psymtab.c (struct psymbol_bcache): Remove.
8787         (psymtab_storage::psymtab_storage): Update.
8788         (psymtab_storage::~psymtab_storage): Update.
8789         (psymbol_bcache_init, psymbol_bcache_free)
8790         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8791         (add_psymbol_to_bcache): Update.
8792         (allocate_psymtab): Update.
8793         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8794         macro_cache>: No longer pointers.
8795         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8796         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8797         * macrotab.c (macro_bcache): Update.
8798         * macroexp.c: Don't include bcache.h.
8799         * gdbtypes.c (check_types_worklist): Update.
8800         (types_deeply_equal): Remove TRY/CATCH.  Update.
8801         * elfread.c (elf_symtab_read): Update.
8802         * dwarf2read.c: Don't include bcache.h.
8803         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8804         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8805         (print_bcache_statistics, bcache_memory_used): Don't declare.
8806         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8807         methods.  Rename all data members.
8808         * bcache.c (struct bcache): Move to bcache.h.
8809         (bcache::expand_hash_table): Rename from expand_hash_table.
8810         (bcache): Remove.
8811         (bcache::insert): Rename from bcache_full.
8812         (bcache::compare): Rename from bcache_compare.
8813         (bcache_xmalloc): Remove.
8814         (bcache::~bcache): Rename from bcache_xfree.
8815         (bcache::print_statistics): Rename from print_bcache_statistics.
8816         (bcache::memory_used): Rename from bcache_memory_used.
8817
8818 2019-03-07  Pedro Alves  <palves@redhat.com>
8819
8820         * infrun.c (normal_stop): Also check for
8821         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8822
8823 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * f-lang.c (value_from_host_double): Moved to...
8826         * value.c (value_from_host_double): ...here.
8827         * value.h (value_from_host_double): Declare.
8828         * guile/scm-math.c (vlscm_convert_typed_number): Use
8829         value_from_host_double.
8830         (vlscm_convert_number): Likewise.
8831         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8832         * python/py-value.c (convert_value_from_python): Likewise.
8833
8834 2019-03-06  Tom Tromey  <tom@tromey.com>
8835
8836         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8837
8838 2019-03-06  Tom Tromey  <tom@tromey.com>
8839
8840         * utils.h (free_current_contents): Don't declare.
8841         * utils.c (free_current_contents): Remove.
8842
8843 2019-03-06  Tom Tromey  <tom@tromey.com>
8844
8845         * top.c (quit_force): Update.
8846         * main.c (captured_command_loop): Update.
8847         * common/new-op.c (operator new): Update.
8848         * common/common-exceptions.c (struct catcher)
8849         <save_cleanup_chain>: Remove member.
8850         (exceptions_state_mc_init): Update.
8851         (exception_try_scope_entry): Return nullptr.
8852         (exception_try_scope_exit, exception_rethrow)
8853         (throw_exception_sjlj, throw_exception_cxx): Update.
8854         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8855         (all_cleanups, do_cleanups, discard_cleanups)
8856         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8857         (restore_cleanups, restore_final_cleanups): Don't declare.
8858         (do_final_cleanups): Remove parameter.
8859         * common/cleanups.c (cleanup_chain, make_cleanup)
8860         (make_cleanup_dtor, all_cleanups, do_cleanups)
8861         (discard_my_cleanups, discard_cleanups)
8862         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8863         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8864         (null_cleanup): Remove.
8865         (do_final_cleanups): Remove parameter.
8866
8867 2019-03-06  Tom Tromey  <tom@tromey.com>
8868
8869         * remote.c (remote_target::remote_parse_stop_reply): Use
8870         unique_xmalloc_ptr.
8871
8872 2019-03-06  Tom Tromey  <tom@tromey.com>
8873
8874         * stabsread.c (struct stabs_field_info): Rename from field_info.
8875         <list, fnlist>: Add initializers.
8876         <obstack>: New member.
8877         (read_member_functions, read_struct_fields, read_baseclasses):
8878         Allocate on obstack.  Don't use cleanups.
8879         (read_one_struct_field, read_member_functions, read_struct_fields)
8880         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8881         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8882         (read_struct_type): Update.
8883
8884 2019-03-06  Tom Tromey  <tom@tromey.com>
8885
8886         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8887         * common/filestuff.h (make_cleanup_close): Don't declare.
8888         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8889         Remove.
8890
8891 2019-03-06  Tom Tromey  <tom@tromey.com>
8892
8893         * solib-aix.c: Use make_scope_exit.
8894
8895 2019-03-06  Tom Tromey  <tom@tromey.com>
8896
8897         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8898         Use make_scope_exit.
8899
8900 2019-03-06  Tom Tromey  <tom@tromey.com>
8901
8902         * solib-svr4.c (disable_probes_interface): Remove parameter.
8903         (svr4_handle_solib_event): Use make_scope_exit.
8904
8905 2019-03-06  Tom Tromey  <tom@tromey.com>
8906
8907         * remote.c (struct stop_reply_deleter): Remove.
8908         (stop_reply_up): Update.
8909         (struct stop_reply): Derive from notif_event.  Don't typedef.
8910         <regcache>: Now a std::vector.
8911         (stop_reply_xfree): Remove.
8912         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8913         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8914         (remote_target::discard_pending_stop_replies): Use delete.
8915         (remote_target::remote_parse_stop_reply): Update.
8916         (remote_target::process_stop_reply): Update.
8917         * remote-notif.h (struct notif_event): Add virtual destructor.
8918         Remove "dtr" member.
8919         (struct notif_client) <alloc_event>: Return a unique_ptr.
8920         (notif_event_xfree): Don't declare.
8921         (notif_event_up): New typedef.
8922         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8923         (notif_event_xfree, do_notif_event_xfree): Remove.
8924         (remote_notif_state_xfree): Update.
8925
8926 2019-03-06  Tom Tromey  <tom@tromey.com>
8927
8928         * infrun.c (displaced_step_clear_cleanup): Now a
8929         forward_scope_exit type.
8930         (displaced_step_prepare_throw): Update.
8931         (displaced_step_fixup): Update.
8932
8933 2019-03-06  Tom Tromey  <tom@tromey.com>
8934
8935         * inferior.h (class inferior): Update comment.
8936         * gdbthread.h (class thread_info): Update comment.
8937
8938 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8939             Tom Tromey  <tom@tromey.com>
8940
8941         * stabsread.h (struct stab_section_list): Remove.
8942         (coffstab_build_psymtabs): Update.
8943         * dbxread.c (symbuf_sections): Now a std::vector.
8944         (sect_idx): New global.
8945         (fill_symbuf): Update.
8946         (coffstab_build_psymtabs): Change type of stabsects parameter.
8947         Update.
8948         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8949         std::vector.
8950         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8951         (coff_locate_sections): Update.
8952         (coff_symfile_read): Remove cleanups.  Update.
8953         (init_stringtab): Add storage parameter.
8954         (free_stringtab, free_stringtab_cleanup): Remove.
8955         (init_lineno): Add storage parameter.
8956         (free_linetab, free_linetab_cleanup): Remove.
8957
8958 2019-03-06  Pedro Alves  <palves@redhat.com>
8959
8960         * linux-fork.c (fork_info::clobber_regs): Delete.
8961         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8962         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8963         comment.  Adjust.
8964         (scoped_switch_fork_info::scoped_switch_fork_info)
8965         (checkpoint_command, linux_fork_context): Adjust
8966         fork_save_infrun_state calls.
8967
8968 2019-03-06  Pedro Alves  <palves@redhat.com>
8969
8970         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8971         (inf_has_multiple_threads): Return 'bool' and rewrite using
8972         inferior_info::threads().
8973
8974 2019-03-06  Pedro Alves  <palves@redhat.com>
8975
8976         * linux-fork.c: Include <list>.
8977         (fork_list): Now a std::list instance.
8978         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8979         (forks_exist_p, find_last_fork): Adjust.
8980         (new_fork): Delete.
8981         (one_fork_p): New.
8982         (add_fork): Adjust.
8983         (free_fork): Delete, folded into fork_info::~fork_info().
8984         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8985         Adjust.
8986         (init_fork_list): Delete.
8987         (linux_fork_killall, linux_fork_mourn_inferior)
8988         (linux_fork_detach, info_checkpoints_command): Adjust.
8989         (_initialize_linux_fork): No longer call init_fork_list.
8990
8991 2019-03-06  Pedro Alves  <palves@redhat.com>
8992
8993         * linux-fork.c (new_fork): New, split out of ...
8994         (add_fork): ... this.  Return void.  Move "first fork" special
8995         case from here, to ...
8996         (checkpoint_command): ... here.
8997         * linux-linux.h (add_fork): Return void.
8998
8999 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9000
9001         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9002
9003 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9004             Chris January  <chris.january@arm.com>
9005             David Lecomber  <david.lecomber@arm.com>
9006
9007         * f-exp.y: New token, UNOP_INTRINSIC.
9008         (exp): New pattern using UNOP_INTRINSIC token.
9009         (f77_keywords): Add 'abs' keyword.
9010         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9011         (value_from_host_double): New function.
9012         (evaluate_subexp_f): Support UNOP_ABS.
9013
9014 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9015
9016         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9017         types.
9018
9019 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9020
9021         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9022         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9023         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9024
9025 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9026
9027         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9028
9029 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9030             Chris January  <chris.january@arm.com>
9031
9032         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9033         * f-exp.y: Define 'KIND' token.
9034         (exp): New pattern for KIND expressions.
9035         (ptype): Handle types with a kind extension.
9036         (direct_abs_decl): Extend to spot kind extensions.
9037         (f77_keywords): Add 'kind' to the list.
9038         (push_kind_type): New function.
9039         (convert_to_kind_type): New function.
9040         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9041         * parse.c (operator_length_standard): Likewise.
9042         * parser-defs.h (enum type_pieces): Add tp_kind.
9043         * std-operator.def: Add UNOP_KIND.
9044
9045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9046
9047         * f-exp.y (f_parse): Set yydebug.
9048
9049 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9050
9051         * f-lang.c (evaluate_subexp_f): New function.
9052         (exp_descriptor_f): New global.
9053         (f_language_defn): Use exp_descriptor_f instead of
9054         exp_descriptor_standard.
9055
9056 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9057
9058         * f-exp.y (struct token): Add comments.
9059         (dot_ops): Remove uppercase versions and the end marker.
9060         (f77_keywords): Likewise.
9061         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9062         entries in the dot_ops array are case insensitive, and use
9063         strncasecmp to compare strings.  Also some whitespace cleanup in
9064         this area.  Similar for the f77_keywords array, except entries in
9065         this list might be case sensitive.
9066
9067 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9068
9069         * f-exp.y (struct f77_boolean_val): Add comments.
9070         (boolean_values): Remove uppercase versions, and end marker.
9071         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9072         and use strncasecmp to achieve case insensitivity.  Additionally,
9073         perform whitespace cleanup around this code.
9074
9075 2019-03-06  Tom Tromey  <tromey@adacore.com>
9076
9077         * remote-sim.c (gdbsim_target_open): Use result of
9078         gdb_argv::release.
9079
9080 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9081         Dirk Schubert  <dirk.schubert@arm.com>
9082         Chris January  <chris.january@arm.com>
9083
9084         * eval.c (evaluate_subexp_standard): Call Fortran argument
9085         wrapping logic.
9086         * f-lang.c (struct value): A value which can be passed into a
9087         Fortran function call.
9088         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9089         where appropriate.
9090         (struct type): Value ready for a Fortran function call.
9091         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9092         is needed.
9093         * f-lang.h (fortran_argument_convert): Declaration.
9094         (fortran_preserve_arg_pointer): Declaration.
9095         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9096
9097 2019-03-05  Tom Tromey  <tromey@adacore.com>
9098
9099         * python/py-prettyprint.c (print_string_repr): Remove #if.
9100         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9101
9102 2019-03-05  Tom Tromey  <tromey@adacore.com>
9103
9104         * target.c (the_dummy_target): Move later.  Change type to
9105         "dummy_target".
9106         (initialize_targets): Don't initialize the_dummy_target.
9107
9108 2019-03-05  Tom Tromey  <tromey@adacore.com>
9109
9110         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9111         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9112
9113 2019-03-05  Tom Tromey  <tromey@adacore.com>
9114
9115         * windows-nat.c (windows_nat_target::attach)
9116         (windows_nat_target::detach): Don't call gdb_flush.
9117         * valprint.c (generic_val_print, val_print, val_print_string):
9118         Don't call gdb_flush.
9119         * utils.c (defaulted_query): Don't call gdb_flush.
9120         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9121         * target.c (target_announce_detach): Don't call gdb_flush.
9122         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9123         * remote.c (extended_remote_target::attach): Don't call
9124         gdb_flush.
9125         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9126         * printcmd.c (do_examine): Don't call gdb_flush.
9127         (info_display_command): Don't call gdb_flush.
9128         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9129         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9130         * memattr.c (info_mem_command): Don't call gdb_flush.
9131         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9132         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9133         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9134         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9135         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9136         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9137         (gnu_nat_target::detach): Don't call gdb_flush.
9138         * f-valprint.c (f_val_print): Don't call gdb_flush.
9139         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9140         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9141         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9142         gdb_flush.
9143         * c-valprint.c (c_val_print): Don't call gdb_flush.
9144         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9145
9146 2019-03-05  Tom Tromey  <tromey@adacore.com>
9147
9148         * varobj.c (update_dynamic_varobj_children): Update.
9149         (install_default_visualizer): Use reset, not release.
9150         * value.c (set_internalvar): Update.
9151         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9152         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9153         ATTRIBUTE_UNUSED_RESULT.
9154
9155 2019-03-05  Tom Tromey  <tromey@adacore.com>
9156
9157         * remote.c (class scoped_remote_fd) <release>: Add
9158         ATTRIBUTE_UNUSED_RESULT.
9159
9160 2019-03-05  Tom Tromey  <tromey@adacore.com>
9161
9162         * macroexp.c (struct macro_buffer) <release>: Add
9163         ATTRIBUTE_UNUSED_RESULT.
9164
9165 2019-03-05  Tom Tromey  <tromey@adacore.com>
9166
9167         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9168         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9169         ATTRIBUTE_UNUSED_RESULT.
9170
9171 2019-03-05  Tom Tromey  <tromey@adacore.com>
9172
9173         * common/scoped_fd.h (class scoped_fd) <release>: Add
9174         ATTRIBUTE_UNUSED_RESULT.
9175
9176 2019-03-05  Tom Tromey  <tromey@adacore.com>
9177
9178         * parser-defs.h (struct parser_state) <release>: Add
9179         ATTRIBUTE_UNUSED_RESULT.
9180
9181 2019-03-05  Tom Tromey  <tromey@adacore.com>
9182
9183         * utils.h (class gdb_argv) <release>: Add
9184         ATTRIBUTE_UNUSED_RESULT.
9185         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9186
9187 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9188
9189         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9190         for-loop range, to avoid compiler warnings.
9191
9192         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9193         avoid compiler warnings about unused variables.
9194
9195         * NEWS: Mention end of support for native debugging on MS-Windows
9196         before XP.
9197
9198         PR gdb/24292
9199         * common/netstuff.c:
9200         * gdbserver/gdbreplay.c
9201         * gdbserver/remote-utils.c:
9202         * ser-tcp.c:
9203         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9204         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9205         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9206         'getaddrinfo' and 'freeaddrinfo' were not available before
9207         Windows XP, and mingw.org's MinGW headers by default define
9208         _WIN32_WINNT to 0x500.
9209
9210 2019-03-01  Gary Benson <gbenson@redhat.com>
9211
9212         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9213
9214 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9215             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9216
9217         PR gdb/8527
9218         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9219         set_sigint_trap, clear_sigint_trap.
9220
9221 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9222
9223         * target.c (target_detach): Clear the regcache and the
9224         frame cache.
9225
9226 2019-02-27  Pedro Alves  <palves@redhat.com>
9227
9228         * utils.c (set_screen_size): When we cap the height/width sizes,
9229         tweak the corresponding command variable to show "unlimited":
9230
9231 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9232             Pedro Alves  <palves@redhat.com>
9233
9234         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9235         before calling rl_set_screen_size.
9236
9237 2019-02-27  Tom Tromey  <tromey@adacore.com>
9238
9239         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9240         define.
9241         * python/py-value.c: Remove Python 2.4 workaround.
9242         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9243         workaround.
9244         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9245         Python 2.4 workaround.
9246         * python/python-internal.h: Remove Python 2.4 comment.
9247         (Py_ssize_t): Don't define.
9248         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9249         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9250         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9251         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9252         * python/python.c (do_start_initialization): Remove Python 2.4
9253         workaround.
9254         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9255         (print_children): Remove Python 2.4 workaround.
9256         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9257         workaround.
9258         (CHARBUFFERPROC_NAME): Remove.
9259         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9260         Python 2.4 workaround.
9261
9262 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9263
9264         * NEWS: Note minimum Python version.
9265
9266 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9267
9268         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9269         code from these functions.  Remove corresponding ifdefs.  Use
9270         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9271         Remove gotos and target of gotos.
9272         (infpy_search_memory): Likewise.
9273
9274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9277         (hppa_gdbarch_init): Don't register deleted functions with
9278         gdbarch.
9279
9280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9283         (h8300_unwind_sp): Delete.
9284         (h8300_dummy_id): Delete.
9285         (h8300_gdbarch_init): Don't register deleted functions with
9286         gdbarch.
9287
9288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9289
9290         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9291         (ft32_unwind_pc): Delete.
9292         (ft32_unwind_sp): Delete.
9293         (ft32_gdbarch_init): Don't register deleted functions with
9294         gdbarch.
9295
9296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9297
9298         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9299         (frv_unwind_pc): Delete.
9300         (frv_unwind_sp): Delete.
9301         (frv_gdbarch_init): Don't register deleted functions with
9302         gdbarch.
9303
9304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9307         (riscv_unwind_pc): Delete.
9308         (riscv_unwind_sp): Delete.
9309         (riscv_gdbarch_init): Don't register deleted functions with
9310         gdbarch.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9315         (csky_unwind_pc): Delete.
9316         (csky_unwind_sp): Delete.
9317         (csky_gdbarch_init): Don't register deleted functions with
9318         gdbarch.
9319
9320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9321
9322         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9323         (cris_unwind_pc): Delete.
9324         (cris_unwind_sp): Delete.
9325         (cris_gdbarch_init): Don't register deleted functions with
9326         gdbarch.
9327
9328 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9329
9330         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9331         (bfin_unwind_pc): Delete.
9332         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9333
9334 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9335
9336         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9337         (arm_unwind_pc): Delete.
9338         (arm_unwind_sp): Delete.
9339         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9340
9341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9342
9343         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9344         (arc_unwind_pc): Delete.
9345         (arc_unwind_sp): Delete.
9346         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9347
9348 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9349
9350         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9351         (alpha_unwind_pc): Delete.
9352         (alpha_gdbarch_init): Don't register deleted functions with
9353         gdbarch.
9354
9355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9356
9357         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9358         (aarch64_unwind_pc): Delete.
9359         (aarch64_unwind_sp): Delete.
9360         (aarch64_gdbarch_init): Don't register deleted functions with
9361         gdbarch.
9362
9363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9364
9365         * gdbtypes.c (type_align): Don't consider static members when
9366         computing structure alignment.
9367
9368 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9369
9370         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9371         return 0 for other types.
9372         * arch-utils.c (default_type_align): Always return 0.
9373         * gdbarch.h: Regenerate.
9374         * gdbarch.sh (type_align): Extend comment.
9375         * gdbtypes.c (type_align): Add additional comments, always call
9376         gdbarch_type_align before applying the default rules.
9377         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9378         generic code will then apply a suitable default.
9379         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9380         types, return 0 for other types.
9381
9382 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9383
9384         * NEWS: Create a new section for the next release branch.
9385         Rename the section of the current branch, now that it has
9386         been cut.
9387
9388 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9389
9390         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9391         * version.in: Bump version to 8.3.50.DATE-git.
9392
9393 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9394
9395         * aix-thread.c (ptid_cmp): Remove unused variable.
9396         (get_signaled_thread): Likewise.
9397         (store_regs_user_thread): Likewise.
9398         (store_regs_kernel_thread): Likewise.
9399         (fetch_regs_kernel_thread): Remove shadowed variable.
9400
9401 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9402
9403         * features/riscv/32bit-cpu.xml: Add register numbers.
9404         * features/riscv/32bit-fpu.c: Regenerate.
9405         * features/riscv/32bit-fpu.xml: Add register numbers.
9406         * features/riscv/64bit-cpu.xml: Add register numbers.
9407         * features/riscv/64bit-fpu.c: Regenerate.
9408         * features/riscv/64bit-fpu.xml: Add register numbers.
9409
9410 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9411
9412         * NEWS: Mention two argument form of gdb.Value constructor.
9413         * python/py-value.c (convert_buffer_and_type_to_value): New
9414         function.
9415         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9416         Add support for handling an optional second argument.  Call
9417         convert_buffer_and_type_to_value as appropriate.
9418         * python/python-internal.h (Py_buffer_deleter): New struct.
9419         (Py_buffer_up): New typedef.
9420
9421 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9422
9423         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9424         instead of releasing ownership.
9425
9426 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9427
9428         * dwarf2read.c (open_and_init_dwp_file): Call
9429         elf_numsections instead of bfd_count_sections to initialize
9430         dwp_file->num_sections.
9431
9432 2019-02-25  Tom Tromey  <tromey@adacore.com>
9433
9434         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9435
9436 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9437
9438         * gcore.in: Add '--readnever' option when invoking GDB.
9439
9440 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9441
9442         * MAINTAINERS: Update my email address.
9443
9444 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9445
9446         * build-id.c (build_id_to_debug_bfd_1): New function.
9447         (build_id_to_debug_bfd): Look for separate debug file in
9448         sysroot.
9449
9450 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9451
9452         * gdbarch.sh: Update the copyright year range that is placed into
9453         generated files.
9454
9455 2019-02-22  Keith Seitz  <keiths@redhat.com>
9456
9457         PR symtab/23853
9458         * linespec.c (create_sals_line_offset): Search for the default
9459         symtab's filename instead of its fullname.
9460
9461 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9462
9463         * NEWS: Update style defaults.
9464
9465 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9466
9467         * main.c (captured_main_1): Disable styling in batch mode.
9468
9469 2019-02-20  Tom Tromey  <tom@tromey.com>
9470
9471         * symtab.c (symtab_symbol_info): Fix typos.
9472
9473 2019-02-20  Tom Tromey  <tromey@adacore.com>
9474
9475         * findcmd.c (_initialize_mem_search): Use upper case for
9476         metasyntactic variables.
9477
9478 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9479
9480         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9481         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9482
9483 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9484
9485         * top.h (source_file_name): Change to std::string.
9486         * top.c (source_file_name): Likewise.
9487         (command_line_input): Adjust.
9488         * cli/cli-script.c (script_from_file): Adjust.
9489
9490 2019-02-19  Tom Tromey  <tromey@adacore.com>
9491
9492         * ravenscar-thread.c
9493         (ravenscar_thread_target::update_thread_list): Don't call
9494         ada_build_task_list.
9495         * ada-lang.h (ada_build_task_list): Don't declare.
9496         * ada-tasks.c (struct ada_tasks_inferior_data)
9497         <task_list_valid_p>: Now bool.
9498         (read_known_tasks, ada_task_list_changed)
9499         (ada_tasks_invalidate_inferior_data): Update.
9500         (read_known_tasks_array): Return bool.
9501         (read_known_tasks_list): Likewise.
9502         (read_known_tasks): Return void.
9503         (ada_build_task_list): Now static.
9504
9505 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9506
9507         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9508         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9509
9510 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9511
9512         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9513         variant for ada_tasks_pspace_data_handle and
9514         ada_tasks_inferior_data_handle.
9515         (ada_tasks_pspace_data_cleanup): New function.
9516         (ada_tasks_inferior_data_cleanup): New function.
9517
9518 2019-02-17  Tom Tromey  <tom@tromey.com>
9519
9520         * macrotab.h (macro_source_fullname): Return a std::string.
9521         * macrotab.c (macro_include, check_for_redefinition)
9522         (macro_undef, macro_lookup_definition, foreach_macro)
9523         (foreach_macro_in_scope): Update.
9524         (macro_source_fullname): Return a std::string.
9525         * macrocmd.c (show_pp_source_pos): Update.
9526
9527 2019-02-17  Tom Tromey  <tom@tromey.com>
9528
9529         * macrocmd.c (show_pp_source_pos): Style the file names.
9530
9531 2019-02-17  Tom Tromey  <tom@tromey.com>
9532
9533         PR tui/24197:
9534         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9535
9536 2019-02-17  Tom Tromey  <tom@tromey.com>
9537
9538         * ada-lang.c (user_select_syms): Use filtered printing.
9539         * utils.c (wrap_style): New global.
9540         (desired_style): Remove.
9541         (emit_style_escape): Add stream parameter.
9542         (set_output_style, reset_terminal_style, prompt_for_continue):
9543         Update.
9544         (flush_wrap_buffer): Only flush gdb_stdout.
9545         (wrap_here): Set wrap_style.
9546         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9547         treat escape sequences as a character.  Change when wrap buffer is
9548         flushed.
9549         (fputs_styled): Do not set the output style when the default is
9550         requested.
9551         * ui-style.h (struct ui_file_style) <is_default>: New method.
9552         * source.c (print_source_lines_base): Emit escape sequences in one
9553         piece.
9554
9555 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9556
9557         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9558         integers and enumeration types.
9559
9560 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9561
9562         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9563         instead of lookup_symbol_in_language
9564         (do_exact_match): New function.
9565         (ada_get_symbol_name_matcher): Return do_exact_match when
9566         doing a verbatim match.
9567
9568 2019-02-15  Tom Tromey  <tromey@adacore.com>
9569
9570         * ravenscar-thread.c (ravenscar_thread_target::resume)
9571         (ravenscar_thread_target::wait): Special case wildcard requests.
9572
9573 2019-02-15  Tom Tromey  <tromey@adacore.com>
9574
9575         * ravenscar-thread.c (base_ptid): Remove.
9576         (struct ravenscar_thread_target) <close>: New method.
9577         <m_base_ptid>: New member.
9578         <update_inferior_ptid, active_task, task_is_currently_active,
9579         runtime_initialized>: Declare methods.
9580         <ravenscar_thread_target>: Add constructor.
9581         (ravenscar_thread_target::task_is_currently_active)
9582         (ravenscar_thread_target::update_inferior_ptid)
9583         (ravenscar_runtime_initialized): Rename.  Now methods.
9584         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9585         (ravenscar_thread_target::update_thread_list): Update.
9586         (ravenscar_thread_target::active_task): Now method.
9587         (ravenscar_thread_target::store_registers)
9588         (ravenscar_thread_target::prepare_to_store)
9589         (ravenscar_thread_target::prepare_to_store)
9590         (ravenscar_thread_target::mourn_inferior): Update.
9591         (ravenscar_inferior_created): Use "new" to create target.
9592         (ravenscar_thread_target::get_ada_task_ptid): Update.
9593         (_initialize_ravenscar): Don't initialize base_ptid.
9594         (ravenscar_ops): Remove global.
9595
9596 2019-02-15  Tom Tromey  <tromey@adacore.com>
9597
9598         * target.h (push_target): Declare new overload.
9599         * target.c (push_target): New overload, taking an rvalue reference.
9600         * remote.c (remote_target::open_1): Use push_target overload.
9601         * corelow.c (core_target_open): Use push_target overload.
9602
9603 2019-02-15  Tom Tromey  <tromey@adacore.com>
9604
9605         * ravenscar-thread.c (is_ravenscar_task)
9606         (ravenscar_task_is_currently_active): Return bool.
9607         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9608         (_initialize_ravenscar): Remove "(void)".
9609         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9610         Return bool.
9611
9612 2019-02-15  Tom Tromey  <tromey@adacore.com>
9613
9614         * ravenscar-thread.c (ravenscar_runtime_initializer)
9615         (has_ravenscar_runtime, get_running_thread_id)
9616         (ravenscar_thread_target::resume): Fix indentation.
9617
9618 2019-02-15  Tom Tromey  <tromey@adacore.com>
9619
9620         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9621         from ravenscar_arch_ops.
9622         (sparc_ravenscar_ops::fetch_registers)
9623         (sparc_ravenscar_ops::store_registers): Now methods.
9624         (sparc_ravenscar_prepare_to_store): Remove.
9625         (sparc_ravenscar_ops): Redefine.
9626         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9627         methods and destructor.  Remove members.
9628         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9629         (ravenscar_thread_target::store_registers)
9630         (ravenscar_thread_target::prepare_to_store): Update.
9631         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9632         Remove.
9633         (struct ppc_ravenscar_powerpc_ops): Derive from
9634         ravenscar_arch_ops.
9635         (ppc_ravenscar_powerpc_ops::fetch_registers)
9636         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9637         (ppc_ravenscar_powerpc_ops): Redefine.
9638         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9639         (ppc_ravenscar_e500_ops::fetch_registers)
9640         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9641         (ppc_ravenscar_e500_ops): Redefine.
9642         * aarch64-ravenscar-thread.c
9643         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9644         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9645         (aarch64_ravenscar_fetch_registers)
9646         (aarch64_ravenscar_store_registers): Now methods.
9647         (aarch64_ravenscar_ops): Redefine.
9648
9649 2019-02-15  Tom Tromey  <tromey@adacore.com>
9650
9651         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9652         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9653         (ravenscar_thread_target::stopped_by_watchpoint)
9654         (ravenscar_thread_target::stopped_data_address)
9655         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9656
9657 2019-02-15  Tom Tromey  <tromey@adacore.com>
9658
9659         * ravenscar-thread.c: Fix some typos.
9660
9661 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9662             Tom Tromey  <tromey@adacore.com>
9663
9664         * ada-lang.c (ada_exception_sal): Change addr_string to a
9665         std::string.
9666         (create_ada_exception_catchpoint): Update.
9667
9668 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9669             Tom Tromey  <tromey@adacore.com>
9670
9671         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9672         (bp_location_ops): Remove.
9673         (base_breakpoint_allocate_location): Update.
9674         (free_bp_location): Update.
9675         * ada-lang.c (class ada_catchpoint_location)
9676         <ada_catchpoint_location>: Remove ops parameter.
9677         (ada_catchpoint_location_dtor): Remove.
9678         (ada_catchpoint_location_ops): Remove.
9679         (allocate_location_exception): Update.
9680         * breakpoint.h (struct bp_location_ops): Remove.
9681         (class bp_location) <bp_location>: Remove bp_location_ops
9682         parameter.
9683         <~bp_location>: Add destructor.
9684         <ops>: Remove.
9685
9686 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9687             Pedro Alves  <palves@redhat.com>
9688
9689         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9690         'PATH_MAX'.
9691
9692 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9693             Samuel Thibault  <samuel.thibault@gnu.org>
9694             Thomas Schwinge  <thomas@codesourcery.com>
9695
9696         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9697         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9698
9699 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9700
9701         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9702         (check_empty): Use "const char *".
9703
9704         * gnu-nat.c (gnu_nat_target::detach): Instead of
9705         'detach_inferior (pid)' call
9706         'detach_inferior (find_inferior_pid (pid))'.
9707
9708         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9709         'nat/fork-inferior.o'.
9710         * gnu-nat.c: #include "nat/fork-inferior.h".
9711
9712         * gnu-nat.c (gnu_nat_target::detach): Instead of
9713         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9714         * gnu-nat.h: #include "inf-child.h".
9715         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9716         'i386_gnu_nat_target::fetch_registers'.
9717         (gnu_store_registers): Rename/move to
9718         'i386_gnu_nat_target::store_registers'.
9719
9720         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9721         * gnu-nat.h (mach_thread_info): New function.
9722         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9723
9724         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9725
9726 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9727
9728         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9729
9730 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9731
9732         * windows-nat.c (windows_add_thread): Add new parameter
9733         "main_thread_p" with default value set to false.  Update
9734         function documentation as well as all callers.
9735         (windows_delete_thread): Likewise.
9736         (fake_create_process): Update call to windows_add_thread.
9737         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9738         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9739         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9740         call to windows_delete_thread.
9741
9742 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9743
9744         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9745
9746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9747
9748         * symfile.c (find_separate_debug_file): Use canonical path of
9749         sysroot with child_path instead of gdb_sysroot if it is valid.
9750
9751 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9752
9753         * symfile.c (find_separate_debug_file): Use child_path to
9754         determine if an object file is under a sysroot.
9755
9756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9757
9758         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9759         unittests/child-path-selftests.c.
9760         * common/pathstuff.c (child_path): New function.
9761         * common/pathstuff.h (child_path): New prototype.
9762         * unittests/child-path-selftests.c: New file.
9763
9764 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9765
9766         * symfile.c (find_separate_debug_file): Look for separate debug
9767         files in debug directories under the sysroot.
9768
9769 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9770
9771         * symtab.h (struct minimal_symbol data_p): New const method.
9772         (struct minimal_symbol text_p): Likewise.
9773         * symtab.c (output_source_filename): Use file name style
9774         to print file name.
9775         (print_symbol_info): Likewise.
9776         (print_msymbol_info): Use address style to print addresses.
9777         Use function name style to print executable text symbols.
9778         (expand_symtab_containing_pc): Use data_p.
9779         (find_pc_sect_compunit_symtab): Likewise.
9780
9781 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9782
9783         * breakpoint.c (describe_other_breakpoints): Use address style
9784         to print addresses.
9785         (say_where): Likewise.
9786
9787 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9788
9789         * ada-typeprint.c (print_func_type): Print function name
9790         style to print function name.
9791         * c-typeprint.c (c_print_type_1): Likewise.
9792
9793 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9794
9795         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9796         for execve.
9797
9798 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9799
9800         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9801         type_stack.
9802
9803 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9804
9805         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9806         TYPE_CODE_REF types.
9807
9808 2019-02-08  Jim Wilson  <jimw@sifive.com>
9809
9810         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9811         (riscv_linux_fregset): New.
9812         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9813
9814 2019-02-07  Tom Tromey  <tom@tromey.com>
9815
9816         * thread.c (thread_cancel_execution_command): Update.
9817         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9818         methods.
9819         (struct thread_fsm_ops): Remove.
9820         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9821         (thread_fsm_should_stop, thread_fsm_return_value)
9822         (thread_fsm_set_finished, thread_fsm_finished_p)
9823         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9824         Don't declare.
9825         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9826         * infrun.c (clear_proceed_status_thread)
9827         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9828         (print_stop_event): Update.
9829         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9830         Add constructor.
9831         (step_command_fsm_ops): Remove.
9832         (new_step_command_fsm): Remove.
9833         (step_1): Update.
9834         (step_command_fsm::should_stop): Rename from
9835         step_command_fsm_should_stop.
9836         (step_command_fsm::clean_up): Rename from
9837         step_command_fsm_clean_up.
9838         (step_command_fsm::do_async_reply_reason): Rename from
9839         step_command_fsm_async_reply_reason.
9840         (struct until_next_fsm): Inherit from thread_fsm.  Add
9841         constructor.
9842         (until_next_fsm_ops): Remove.
9843         (new_until_next_fsm): Remove.
9844         (until_next_fsm::should_stop): Rename from
9845         until_next_fsm_should_stop.
9846         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9847         (until_next_fsm::do_async_reply_reason): Rename from
9848         until_next_fsm_async_reply_reason.
9849         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9850         constructor.  Change type of breakpoint.
9851         (finish_command_fsm_ops): Remove.
9852         (new_finish_command_fsm): Remove.
9853         (finish_command_fsm::should_stop): Rename from
9854         finish_command_fsm_should_stop.
9855         (finish_command_fsm::clean_up): Rename from
9856         finish_command_fsm_clean_up.
9857         (finish_command_fsm::return_value): Rename from
9858         finish_command_fsm_return_value.
9859         (finish_command_fsm::do_async_reply_reason): Rename from
9860         finish_command_fsm_async_reply_reason.
9861         (finish_command): Update.
9862         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9863         Add constructor.
9864         (call_thread_fsm_ops): Remove.
9865         (call_thread_fsm::call_thread_fsm): Rename from
9866         new_call_thread_fsm.
9867         (call_thread_fsm::should_stop): Rename from
9868         call_thread_fsm_should_stop.
9869         (call_thread_fsm::should_notify_stop): Rename from
9870         call_thread_fsm_should_notify_stop.
9871         (run_inferior_call, call_function_by_hand_dummy): Update.
9872         * cli/cli-interp.c (should_print_stop_to_console): Update.
9873         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9874         Add constructor.  Change type of location_breakpoint,
9875         caller_breakpoint.
9876         (until_break_fsm_ops): Remove.
9877         (new_until_break_fsm): Remove.
9878         (until_break_fsm::should_stop): Rename from
9879         until_break_fsm_should_stop.
9880         (until_break_fsm::clean_up): Rename from
9881         until_break_fsm_clean_up.
9882         (until_break_fsm::do_async_reply_reason): Rename from
9883         until_break_fsm_async_reply_reason.
9884         (until_break_command): Update.
9885         * thread-fsm.c: Remove.
9886         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9887
9888 2019-02-07  Tom Tromey  <tom@tromey.com>
9889
9890         * yy-remap.h: Add include guard.
9891         * xtensa-tdep.h: Add include guard.
9892         * xcoffread.h: Rename include guard.
9893         * varobj-iter.h: Add include guard.
9894         * tui/tui.h: Rename include guard.
9895         * tui/tui-winsource.h: Rename include guard.
9896         * tui/tui-wingeneral.h: Rename include guard.
9897         * tui/tui-windata.h: Rename include guard.
9898         * tui/tui-win.h: Rename include guard.
9899         * tui/tui-stack.h: Rename include guard.
9900         * tui/tui-source.h: Rename include guard.
9901         * tui/tui-regs.h: Rename include guard.
9902         * tui/tui-out.h: Rename include guard.
9903         * tui/tui-layout.h: Rename include guard.
9904         * tui/tui-io.h: Rename include guard.
9905         * tui/tui-hooks.h: Rename include guard.
9906         * tui/tui-file.h: Rename include guard.
9907         * tui/tui-disasm.h: Rename include guard.
9908         * tui/tui-data.h: Rename include guard.
9909         * tui/tui-command.h: Rename include guard.
9910         * tic6x-tdep.h: Add include guard.
9911         * target/waitstatus.h: Rename include guard.
9912         * target/wait.h: Rename include guard.
9913         * target/target.h: Rename include guard.
9914         * target/resume.h: Rename include guard.
9915         * target-float.h: Rename include guard.
9916         * stabsread.h: Add include guard.
9917         * rs6000-tdep.h: Add include guard.
9918         * riscv-fbsd-tdep.h: Add include guard.
9919         * regformats/regdef.h: Rename include guard.
9920         * record.h: Rename include guard.
9921         * python/python.h: Rename include guard.
9922         * python/python-internal.h: Rename include guard.
9923         * python/py-stopevent.h: Rename include guard.
9924         * python/py-ref.h: Rename include guard.
9925         * python/py-record.h: Rename include guard.
9926         * python/py-record-full.h: Rename include guard.
9927         * python/py-record-btrace.h: Rename include guard.
9928         * python/py-instruction.h: Rename include guard.
9929         * python/py-events.h: Rename include guard.
9930         * python/py-event.h: Rename include guard.
9931         * procfs.h: Add include guard.
9932         * proc-utils.h: Add include guard.
9933         * p-lang.h: Add include guard.
9934         * or1k-tdep.h: Rename include guard.
9935         * observable.h: Rename include guard.
9936         * nto-tdep.h: Rename include guard.
9937         * nat/x86-linux.h: Rename include guard.
9938         * nat/x86-linux-dregs.h: Rename include guard.
9939         * nat/x86-gcc-cpuid.h: Add include guard.
9940         * nat/x86-dregs.h: Rename include guard.
9941         * nat/x86-cpuid.h: Rename include guard.
9942         * nat/ppc-linux.h: Rename include guard.
9943         * nat/mips-linux-watch.h: Rename include guard.
9944         * nat/linux-waitpid.h: Rename include guard.
9945         * nat/linux-ptrace.h: Rename include guard.
9946         * nat/linux-procfs.h: Rename include guard.
9947         * nat/linux-osdata.h: Rename include guard.
9948         * nat/linux-nat.h: Rename include guard.
9949         * nat/linux-namespaces.h: Rename include guard.
9950         * nat/linux-btrace.h: Rename include guard.
9951         * nat/glibc_thread_db.h: Rename include guard.
9952         * nat/gdb_thread_db.h: Rename include guard.
9953         * nat/gdb_ptrace.h: Rename include guard.
9954         * nat/fork-inferior.h: Rename include guard.
9955         * nat/amd64-linux-siginfo.h: Rename include guard.
9956         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9957         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9958         * nat/aarch64-linux.h: Rename include guard.
9959         * nat/aarch64-linux-hw-point.h: Rename include guard.
9960         * mn10300-tdep.h: Add include guard.
9961         * mips-linux-tdep.h: Add include guard.
9962         * mi/mi-parse.h: Rename include guard.
9963         * mi/mi-out.h: Rename include guard.
9964         * mi/mi-main.h: Rename include guard.
9965         * mi/mi-interp.h: Rename include guard.
9966         * mi/mi-getopt.h: Rename include guard.
9967         * mi/mi-console.h: Rename include guard.
9968         * mi/mi-common.h: Rename include guard.
9969         * mi/mi-cmds.h: Rename include guard.
9970         * mi/mi-cmd-break.h: Rename include guard.
9971         * m2-lang.h: Add include guard.
9972         * location.h: Rename include guard.
9973         * linux-record.h: Rename include guard.
9974         * linux-nat.h: Add include guard.
9975         * linux-fork.h: Add include guard.
9976         * i386-darwin-tdep.h: Rename include guard.
9977         * hppa-linux-offsets.h: Add include guard.
9978         * guile/guile.h: Rename include guard.
9979         * guile/guile-internal.h: Rename include guard.
9980         * gnu-nat.h: Rename include guard.
9981         * gdb-stabs.h: Rename include guard.
9982         * frv-tdep.h: Add include guard.
9983         * f-lang.h: Add include guard.
9984         * event-loop.h: Add include guard.
9985         * darwin-nat.h: Rename include guard.
9986         * cp-abi.h: Rename include guard.
9987         * config/sparc/nm-sol2.h: Rename include guard.
9988         * config/nm-nto.h: Rename include guard.
9989         * config/nm-linux.h: Add include guard.
9990         * config/i386/nm-i386gnu.h: Rename include guard.
9991         * config/djgpp/nl_types.h: Rename include guard.
9992         * config/djgpp/langinfo.h: Rename include guard.
9993         * compile/gcc-cp-plugin.h: Add include guard.
9994         * compile/gcc-c-plugin.h: Add include guard.
9995         * compile/compile.h: Rename include guard.
9996         * compile/compile-object-run.h: Rename include guard.
9997         * compile/compile-object-load.h: Rename include guard.
9998         * compile/compile-internal.h: Rename include guard.
9999         * compile/compile-cplus.h: Rename include guard.
10000         * compile/compile-c.h: Rename include guard.
10001         * common/xml-utils.h: Rename include guard.
10002         * common/x86-xstate.h: Rename include guard.
10003         * common/version.h: Rename include guard.
10004         * common/vec.h: Rename include guard.
10005         * common/tdesc.h: Rename include guard.
10006         * common/selftest.h: Rename include guard.
10007         * common/scoped_restore.h: Rename include guard.
10008         * common/scoped_mmap.h: Rename include guard.
10009         * common/scoped_fd.h: Rename include guard.
10010         * common/safe-iterator.h: Rename include guard.
10011         * common/run-time-clock.h: Rename include guard.
10012         * common/refcounted-object.h: Rename include guard.
10013         * common/queue.h: Rename include guard.
10014         * common/ptid.h: Rename include guard.
10015         * common/print-utils.h: Rename include guard.
10016         * common/preprocessor.h: Rename include guard.
10017         * common/pathstuff.h: Rename include guard.
10018         * common/observable.h: Rename include guard.
10019         * common/netstuff.h: Rename include guard.
10020         * common/job-control.h: Rename include guard.
10021         * common/host-defs.h: Rename include guard.
10022         * common/gdb_wait.h: Rename include guard.
10023         * common/gdb_vecs.h: Rename include guard.
10024         * common/gdb_unlinker.h: Rename include guard.
10025         * common/gdb_unique_ptr.h: Rename include guard.
10026         * common/gdb_tilde_expand.h: Rename include guard.
10027         * common/gdb_sys_time.h: Rename include guard.
10028         * common/gdb_string_view.h: Rename include guard.
10029         * common/gdb_splay_tree.h: Rename include guard.
10030         * common/gdb_setjmp.h: Rename include guard.
10031         * common/gdb_ref_ptr.h: Rename include guard.
10032         * common/gdb_optional.h: Rename include guard.
10033         * common/gdb_locale.h: Rename include guard.
10034         * common/gdb_assert.h: Rename include guard.
10035         * common/filtered-iterator.h: Rename include guard.
10036         * common/filestuff.h: Rename include guard.
10037         * common/fileio.h: Rename include guard.
10038         * common/environ.h: Rename include guard.
10039         * common/common-utils.h: Rename include guard.
10040         * common/common-types.h: Rename include guard.
10041         * common/common-regcache.h: Rename include guard.
10042         * common/common-inferior.h: Rename include guard.
10043         * common/common-gdbthread.h: Rename include guard.
10044         * common/common-exceptions.h: Rename include guard.
10045         * common/common-defs.h: Rename include guard.
10046         * common/common-debug.h: Rename include guard.
10047         * common/cleanups.h: Rename include guard.
10048         * common/buffer.h: Rename include guard.
10049         * common/btrace-common.h: Rename include guard.
10050         * common/break-common.h: Rename include guard.
10051         * cli/cli-utils.h: Rename include guard.
10052         * cli/cli-style.h: Rename include guard.
10053         * cli/cli-setshow.h: Rename include guard.
10054         * cli/cli-script.h: Rename include guard.
10055         * cli/cli-interp.h: Rename include guard.
10056         * cli/cli-decode.h: Rename include guard.
10057         * cli/cli-cmds.h: Rename include guard.
10058         * charset-list.h: Add include guard.
10059         * buildsym-legacy.h: Rename include guard.
10060         * bfin-tdep.h: Add include guard.
10061         * ax.h: Rename include guard.
10062         * arm-linux-tdep.h: Add include guard.
10063         * arm-fbsd-tdep.h: Add include guard.
10064         * arch/xtensa.h: Rename include guard.
10065         * arch/tic6x.h: Add include guard.
10066         * arch/i386.h: Add include guard.
10067         * arch/arm.h: Rename include guard.
10068         * arch/arm-linux.h: Rename include guard.
10069         * arch/arm-get-next-pcs.h: Rename include guard.
10070         * arch/amd64.h: Add include guard.
10071         * arch/aarch64-insn.h: Rename include guard.
10072         * arch-utils.h: Rename include guard.
10073         * annotate.h: Add include guard.
10074         * amd64-darwin-tdep.h: Rename include guard.
10075         * aarch64-linux-tdep.h: Add include guard.
10076         * aarch64-fbsd-tdep.h: Add include guard.
10077         * aarch32-linux-nat.h: Add include guard.
10078
10079 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10080
10081         * macrotab.c (macro_define_internal): New function that
10082         factorizes macro_define_object_internal and macro_define_function
10083         code.
10084         (macro_define_object_internal): Use macro_define_internal.
10085         (macro_define_function): Likewise.
10086
10087 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10088
10089         * macrocmd.c (extract_identifier): Return
10090         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10091         callers.
10092
10093 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10094
10095         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10096
10097 2019-02-05  Tom Tromey  <tom@tromey.com>
10098
10099         * target.c (target_stack::unpush): Move assertion earlier.
10100
10101 2019-01-30  Tom Tromey  <tom@tromey.com>
10102
10103         PR python/23615:
10104         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10105         (gdbpy_parse_and_eval): Likewise.
10106         * python/python-internal.h (gdbpy_allow_threads): New class.
10107
10108 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10109
10110         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10111         (aarch64_fbsd_fpregmap): Move earlier.
10112         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10113         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10114         instead of individual calls to trad_frame_set_reg_addr.
10115         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10116         earlier.
10117         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10118         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10119         instead of individual calls to trad_frame_set_reg_addr.
10120
10121 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10122
10123         * CONTRIBUTE: Replace contribution list with wiki link.
10124
10125 2019-01-25  Tom Tromey  <tom@tromey.com>
10126
10127         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10128
10129 2019-01-25  Tom Tromey  <tom@tromey.com>
10130
10131         * xtensa-linux-nat.c: Fix common/ includes.
10132         * xml-support.h: Fix common/ includes.
10133         * xml-support.c: Fix common/ includes.
10134         * x86-linux-nat.c: Fix common/ includes.
10135         * windows-nat.c: Fix common/ includes.
10136         * varobj.h: Fix common/ includes.
10137         * varobj.c: Fix common/ includes.
10138         * value.c: Fix common/ includes.
10139         * valops.c: Fix common/ includes.
10140         * utils.c: Fix common/ includes.
10141         * unittests/xml-utils-selftests.c: Fix common/ includes.
10142         * unittests/utils-selftests.c: Fix common/ includes.
10143         * unittests/unpack-selftests.c: Fix common/ includes.
10144         * unittests/tracepoint-selftests.c: Fix common/ includes.
10145         * unittests/style-selftests.c: Fix common/ includes.
10146         * unittests/string_view-selftests.c: Fix common/ includes.
10147         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10148         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10149         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10150         * unittests/rsp-low-selftests.c: Fix common/ includes.
10151         * unittests/parse-connection-spec-selftests.c: Fix common/
10152         includes.
10153         * unittests/optional-selftests.c: Fix common/ includes.
10154         * unittests/offset-type-selftests.c: Fix common/ includes.
10155         * unittests/observable-selftests.c: Fix common/ includes.
10156         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10157         * unittests/memrange-selftests.c: Fix common/ includes.
10158         * unittests/memory-map-selftests.c: Fix common/ includes.
10159         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10160         * unittests/function-view-selftests.c: Fix common/ includes.
10161         * unittests/environ-selftests.c: Fix common/ includes.
10162         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10163         * unittests/common-utils-selftests.c: Fix common/ includes.
10164         * unittests/cli-utils-selftests.c: Fix common/ includes.
10165         * unittests/array-view-selftests.c: Fix common/ includes.
10166         * ui-file.c: Fix common/ includes.
10167         * tui/tui-io.c: Fix common/ includes.
10168         * tracepoint.h: Fix common/ includes.
10169         * tracepoint.c: Fix common/ includes.
10170         * tracefile-tfile.c: Fix common/ includes.
10171         * top.h: Fix common/ includes.
10172         * top.c: Fix common/ includes.
10173         * thread.c: Fix common/ includes.
10174         * target/waitstatus.h: Fix common/ includes.
10175         * target/waitstatus.c: Fix common/ includes.
10176         * target.h: Fix common/ includes.
10177         * target.c: Fix common/ includes.
10178         * target-memory.c: Fix common/ includes.
10179         * target-descriptions.c: Fix common/ includes.
10180         * symtab.h: Fix common/ includes.
10181         * symfile.c: Fix common/ includes.
10182         * stap-probe.c: Fix common/ includes.
10183         * spu-linux-nat.c: Fix common/ includes.
10184         * sparc-nat.c: Fix common/ includes.
10185         * source.c: Fix common/ includes.
10186         * solib.c: Fix common/ includes.
10187         * solib-target.c: Fix common/ includes.
10188         * ser-unix.c: Fix common/ includes.
10189         * ser-tcp.c: Fix common/ includes.
10190         * ser-pipe.c: Fix common/ includes.
10191         * ser-base.c: Fix common/ includes.
10192         * selftest-arch.c: Fix common/ includes.
10193         * s12z-tdep.c: Fix common/ includes.
10194         * rust-exp.y: Fix common/ includes.
10195         * rs6000-aix-tdep.c: Fix common/ includes.
10196         * riscv-tdep.c: Fix common/ includes.
10197         * remote.c: Fix common/ includes.
10198         * remote-notif.h: Fix common/ includes.
10199         * remote-fileio.h: Fix common/ includes.
10200         * remote-fileio.c: Fix common/ includes.
10201         * regcache.h: Fix common/ includes.
10202         * regcache.c: Fix common/ includes.
10203         * record-btrace.c: Fix common/ includes.
10204         * python/python.c: Fix common/ includes.
10205         * python/py-type.c: Fix common/ includes.
10206         * python/py-inferior.c: Fix common/ includes.
10207         * progspace.h: Fix common/ includes.
10208         * producer.c: Fix common/ includes.
10209         * procfs.c: Fix common/ includes.
10210         * proc-api.c: Fix common/ includes.
10211         * printcmd.c: Fix common/ includes.
10212         * ppc-linux-nat.c: Fix common/ includes.
10213         * parser-defs.h: Fix common/ includes.
10214         * osdata.c: Fix common/ includes.
10215         * obsd-nat.c: Fix common/ includes.
10216         * nat/x86-linux.c: Fix common/ includes.
10217         * nat/x86-linux-dregs.c: Fix common/ includes.
10218         * nat/x86-dregs.h: Fix common/ includes.
10219         * nat/x86-dregs.c: Fix common/ includes.
10220         * nat/ppc-linux.c: Fix common/ includes.
10221         * nat/mips-linux-watch.h: Fix common/ includes.
10222         * nat/mips-linux-watch.c: Fix common/ includes.
10223         * nat/linux-waitpid.c: Fix common/ includes.
10224         * nat/linux-ptrace.h: Fix common/ includes.
10225         * nat/linux-ptrace.c: Fix common/ includes.
10226         * nat/linux-procfs.c: Fix common/ includes.
10227         * nat/linux-personality.c: Fix common/ includes.
10228         * nat/linux-osdata.c: Fix common/ includes.
10229         * nat/linux-namespaces.c: Fix common/ includes.
10230         * nat/linux-btrace.h: Fix common/ includes.
10231         * nat/linux-btrace.c: Fix common/ includes.
10232         * nat/fork-inferior.c: Fix common/ includes.
10233         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10234         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10235         * nat/aarch64-linux.c: Fix common/ includes.
10236         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10237         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10238         * namespace.h: Fix common/ includes.
10239         * mips-linux-tdep.c: Fix common/ includes.
10240         * minsyms.c: Fix common/ includes.
10241         * mi/mi-parse.h: Fix common/ includes.
10242         * mi/mi-main.c: Fix common/ includes.
10243         * mi/mi-cmd-env.c: Fix common/ includes.
10244         * memrange.h: Fix common/ includes.
10245         * memattr.c: Fix common/ includes.
10246         * maint.h: Fix common/ includes.
10247         * maint.c: Fix common/ includes.
10248         * main.c: Fix common/ includes.
10249         * machoread.c: Fix common/ includes.
10250         * location.c: Fix common/ includes.
10251         * linux-thread-db.c: Fix common/ includes.
10252         * linux-nat.c: Fix common/ includes.
10253         * linux-fork.c: Fix common/ includes.
10254         * inline-frame.c: Fix common/ includes.
10255         * infrun.c: Fix common/ includes.
10256         * inflow.c: Fix common/ includes.
10257         * inferior.h: Fix common/ includes.
10258         * inferior.c: Fix common/ includes.
10259         * infcmd.c: Fix common/ includes.
10260         * inf-ptrace.c: Fix common/ includes.
10261         * inf-child.c: Fix common/ includes.
10262         * ia64-linux-nat.c: Fix common/ includes.
10263         * i387-tdep.c: Fix common/ includes.
10264         * i386-tdep.c: Fix common/ includes.
10265         * i386-linux-tdep.c: Fix common/ includes.
10266         * i386-linux-nat.c: Fix common/ includes.
10267         * i386-go32-tdep.c: Fix common/ includes.
10268         * i386-fbsd-tdep.c: Fix common/ includes.
10269         * i386-fbsd-nat.c: Fix common/ includes.
10270         * guile/scm-type.c: Fix common/ includes.
10271         * guile/guile.c: Fix common/ includes.
10272         * go32-nat.c: Fix common/ includes.
10273         * gnu-nat.c: Fix common/ includes.
10274         * gdbthread.h: Fix common/ includes.
10275         * gdbarch-selftests.c: Fix common/ includes.
10276         * gdb_usleep.c: Fix common/ includes.
10277         * gdb_select.h: Fix common/ includes.
10278         * gdb_bfd.c: Fix common/ includes.
10279         * gcore.c: Fix common/ includes.
10280         * fork-child.c: Fix common/ includes.
10281         * findvar.c: Fix common/ includes.
10282         * fbsd-nat.c: Fix common/ includes.
10283         * event-top.c: Fix common/ includes.
10284         * event-loop.c: Fix common/ includes.
10285         * dwarf2read.c: Fix common/ includes.
10286         * dwarf2loc.c: Fix common/ includes.
10287         * dwarf2-frame.c: Fix common/ includes.
10288         * dwarf-index-cache.c: Fix common/ includes.
10289         * dtrace-probe.c: Fix common/ includes.
10290         * disasm-selftests.c: Fix common/ includes.
10291         * defs.h: Fix common/ includes.
10292         * csky-tdep.c: Fix common/ includes.
10293         * cp-valprint.c: Fix common/ includes.
10294         * cp-support.h: Fix common/ includes.
10295         * cp-support.c: Fix common/ includes.
10296         * corelow.c: Fix common/ includes.
10297         * completer.h: Fix common/ includes.
10298         * completer.c: Fix common/ includes.
10299         * compile/compile.c: Fix common/ includes.
10300         * compile/compile-loc2c.c: Fix common/ includes.
10301         * compile/compile-cplus-types.c: Fix common/ includes.
10302         * compile/compile-cplus-symbols.c: Fix common/ includes.
10303         * command.h: Fix common/ includes.
10304         * cli/cli-dump.c: Fix common/ includes.
10305         * cli/cli-cmds.c: Fix common/ includes.
10306         * charset.c: Fix common/ includes.
10307         * build-id.c: Fix common/ includes.
10308         * btrace.h: Fix common/ includes.
10309         * btrace.c: Fix common/ includes.
10310         * breakpoint.h: Fix common/ includes.
10311         * breakpoint.c: Fix common/ includes.
10312         * ax.h:
10313         (enum agent_op): Fix common/ includes.
10314         * ax-general.c (struct aop_map): Fix common/ includes.
10315         * ax-gdb.c: Fix common/ includes.
10316         * auxv.c: Fix common/ includes.
10317         * auto-load.c: Fix common/ includes.
10318         * arm-tdep.c: Fix common/ includes.
10319         * arch/riscv.c: Fix common/ includes.
10320         * arch/ppc-linux-common.c: Fix common/ includes.
10321         * arch/i386.c: Fix common/ includes.
10322         * arch/arm.c: Fix common/ includes.
10323         * arch/arm-linux.c: Fix common/ includes.
10324         * arch/arm-get-next-pcs.c: Fix common/ includes.
10325         * arch/amd64.c: Fix common/ includes.
10326         * arch/aarch64.c: Fix common/ includes.
10327         * arch/aarch64-insn.c: Fix common/ includes.
10328         * arch-utils.c: Fix common/ includes.
10329         * amd64-windows-tdep.c: Fix common/ includes.
10330         * amd64-tdep.c: Fix common/ includes.
10331         * amd64-sol2-tdep.c: Fix common/ includes.
10332         * amd64-obsd-tdep.c: Fix common/ includes.
10333         * amd64-nbsd-tdep.c: Fix common/ includes.
10334         * amd64-linux-tdep.c: Fix common/ includes.
10335         * amd64-linux-nat.c: Fix common/ includes.
10336         * amd64-fbsd-tdep.c: Fix common/ includes.
10337         * amd64-fbsd-nat.c: Fix common/ includes.
10338         * amd64-dicos-tdep.c: Fix common/ includes.
10339         * amd64-darwin-tdep.c: Fix common/ includes.
10340         * agent.c: Fix common/ includes.
10341         * ada-lang.h: Fix common/ includes.
10342         * ada-lang.c: Fix common/ includes.
10343         * aarch64-tdep.c: Fix common/ includes.
10344
10345 2019-01-25  Tom Tromey  <tom@tromey.com>
10346
10347         * common/create-version.sh: Use common/version.h.
10348
10349 2019-01-24  Pedro Alves  <palves@redhat.com>
10350
10351         * infrun.c (signal_stop, signal_print, signal_program)
10352         (signal_catch, signal_pass): Now arrays instead of pointers.
10353         (update_signals_program_target, do_target_resume)
10354         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10355         * linux-nat.c (linux_nat_target::pass_signals)
10356         (linux_nat_target::create_inferior, linux_nat_target::attach):
10357         Adjust.
10358         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10359         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10360         * procfs.c (procfs_target::pass_signals): Adjust.
10361         * record-full.c (record_full_target::resume): Adjust.
10362         * remote.c (remote_target::pass_signals)
10363         (remote_target::program_signals): Adjust.
10364         * target-debug.h (target_debug_print_signals): Now takes a
10365         gdb::array_view as parameter.  Adjust.
10366         * target.h (target_ops) <pass_signals, program_signals>: Replace
10367         pointer and length parameters with gdb::array_view.
10368         (target_pass_signals, target_program_signals): Likewise.
10369         * target-delegates.c: Regenerate.
10370
10371 2019-01-24  Pedro Alves  <palves@redhat.com>
10372
10373         * common/forward-scope-exit.h
10374         (forward_scope_exit::forward_scope_exit): Pass arguments to
10375         m_bind_function directly, instead of creating a std::bind and
10376         copying that.
10377
10378 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10379
10380         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10381         for static members.
10382         (pass_in_v_vfp_candidate): Likewise.
10383
10384 2019-01-23  Tom Tromey  <tom@tromey.com>
10385             Pedro Alves  <palves@redhat.com>
10386
10387         * regcache.c (class regcache_invalidator): Remove.
10388         (regcache::raw_write): Use make_scope_exit.
10389
10390 2019-01-23  Tom Tromey  <tom@tromey.com>
10391
10392         * ui-out.h (class ui_out_emit_type): Update comment.
10393
10394 2019-01-23  Tom Tromey  <tom@tromey.com>
10395
10396         * infrun.c (fetch_inferior_event): Update comment.
10397
10398 2019-01-23  Tom Tromey  <tom@tromey.com>
10399             Pedro Alves  <palves@redhat.com>
10400
10401         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10402         parameter.
10403         (fetch_inferior_event): Use SCOPE_EXIT.
10404
10405
10406 2019-01-23  Tom Tromey  <tom@tromey.com>
10407             Pedro Alves  <palves@redhat.com>
10408
10409         * infrun.c (disable_thread_events): Delete.
10410         (stop_all_threads): Use SCOPE_EXIT.
10411
10412 2019-01-23  Tom Tromey  <tom@tromey.com>
10413             Pedro Alves  <palves@redhat.com>
10414
10415         * symfile.c: Include forward-scope-exit.h.
10416         (clear_symtab_users_cleanup): Replace forward declaration with
10417         a FORWARD_SCOPE_EXIT.
10418         (syms_from_objfile_1): Use the forward_scope_exit and
10419         gdb::optional instead of cleanup_function.
10420         (reread_symbols): Use the forward_scope_exit instead of
10421         cleanup_function.
10422         (clear_symtab_users_cleanup): Remove function.
10423
10424 2019-01-23  Tom Tromey  <tom@tromey.com>
10425             Pedro Alves  <palves@redhat.com>
10426
10427         * linux-nat.c: Include scope-exit.h.
10428         (cleanup_target_stop): Remove.
10429         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10430         SCOPE_EXIT.
10431
10432 2019-01-23  Tom Tromey  <tom@tromey.com>
10433             Pedro Alves  <palves@redhat.com>
10434
10435         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10436         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10437
10438 2019-01-23  Tom Tromey  <tom@tromey.com>
10439             Andrew Burgess  <andrew.burgess@embecosm.com>
10440             Pedro Alves  <palves@redhat.com>
10441
10442         * infrun.c (fetch_inferior_event): Use scope_exit.
10443         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10444         * top.c (execute_command): Use scope_exit.
10445         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10446         * utils.c (do_bpstat_clear_actions_cleanup)
10447         (make_bpstat_clear_actions_cleanup): Remove.
10448
10449 2019-01-23  Tom Tromey  <tom@tromey.com>
10450             Pedro Alves  <palves@redhat.com>
10451
10452         * infrun.c: Include "common/scope-exit.h"
10453         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10454         (wait_for_inferior): Use SCOPE_EXIT.
10455         (fetch_inferior_event): Use scope_exit.
10456
10457 2019-01-23  Tom Tromey  <tom@tromey.com>
10458             Pedro Alves  <palves@redhat.com>
10459
10460         * breakpoint.c (create_breakpoint): Remove cleanup.
10461
10462 2019-01-23  Tom Tromey  <tom@tromey.com>
10463             Andrew Burgess  <andrew.burgess@embecosm.com>
10464             Pedro Alves  <palves@redhat.com>
10465
10466 2019-01-23  Pedro Alves  <palves@redhat.com>
10467
10468         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10469
10470 2019-01-23  Pedro Alves  <palves@redhat.com>
10471             Andrew Burgess  <andrew.burgess@embecosm.com>
10472
10473         * gdbthread.h: Include "common/forward-scope-exit.h".
10474         (scoped_finish_thread_state): Redefine custom class in terms of
10475         forward_scope_exit.
10476
10477 2019-01-23  Pedro Alves  <palves@redhat.com>
10478             Andrew Burgess  <andrew.burgess@embecosm.com>
10479
10480         * common/forward-scope-exit.h: New file.
10481
10482 2019-01-23  Pedro Alves  <palves@redhat.com>
10483             Andrew Burgess  <andrew.burgess@embecosm.com>
10484             Tom Tromey  <tom@tromey.com>
10485
10486         * common/scope-exit.h: New file.
10487
10488 2019-01-23  Pedro Alves  <palves@redhat.com>
10489
10490         * common/preprocessor.h (ESC): Rename to ...
10491         (ESC_PARENS): ... this.
10492         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10493         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10494
10495 2019-01-23  Tom Tromey  <tom@tromey.com>
10496
10497         * language.h (class scoped_switch_to_sym_language_if_auto):
10498         Initialize m_lang in both cases.
10499
10500 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10501
10502         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10503         with XCNEW.
10504
10505 2019-01-22  Tom Tromey  <tom@tromey.com>
10506
10507         * corelow.c: Do not include sys/file.h.
10508
10509 2019-01-22  Tom Tromey  <tom@tromey.com>
10510
10511         * tui/tui-wingeneral.h: Include gdb_curses.h.
10512
10513 2019-01-22  Tom Tromey  <tom@tromey.com>
10514
10515         * source-cache.h (class source_cache) <get_source_lines,
10516         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10517
10518 2019-01-22  Tom Tromey  <tom@tromey.com>
10519
10520         * remote-fileio.h (struct remote_target): Declare.
10521
10522 2019-01-22  Tom Tromey  <tom@tromey.com>
10523
10524         * python/py-arch.c: Do not include py-ref.h.
10525         * python/py-bpevent.c: Do not include py-ref.h.
10526         * python/py-cmd.c: Do not include py-ref.h.
10527         * python/py-continueevent.c: Do not include py-ref.h.
10528         * python/py-event.h: Do not include py-ref.h.
10529         * python/py-evtregistry.c: Do not include py-ref.h.
10530         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10531         * python/py-frame.c: Do not include py-ref.h.
10532         * python/py-framefilter.c: Do not include py-ref.h.
10533         * python/py-function.c: Do not include py-ref.h.
10534         * python/py-infevents.c: Do not include py-ref.h.
10535         * python/py-linetable.c: Do not include py-ref.h.
10536         * python/py-objfile.c: Do not include py-ref.h.
10537         * python/py-param.c: Do not include py-ref.h.
10538         * python/py-prettyprint.c: Do not include py-ref.h.
10539         * python/py-progspace.c: Do not include py-ref.h.
10540         * python/py-symbol.c: Do not include py-ref.h.
10541         * python/py-symtab.c: Do not include py-ref.h.
10542         * python/py-type.c: Do not include py-ref.h.
10543         * python/py-unwind.c: Do not include py-ref.h.
10544         * python/py-utils.c: Do not include py-ref.h.
10545         * python/py-value.c: Do not include py-ref.h.
10546         * python/py-varobj.c: Do not include py-ref.h.
10547         * python/py-xmethods.c: Do not include py-ref.h.
10548         * python/python.c: Do not include py-ref.h.
10549         * varobj.c: Do not include py-ref.h.
10550
10551 2019-01-22  Tom Tromey  <tom@tromey.com>
10552
10553         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10554         keyword for bcache.
10555
10556 2019-01-22  Tom Tromey  <tom@tromey.com>
10557
10558         * compile/compile-cplus-types.c: Remove a comment by #include.
10559
10560 2019-01-22  Tom Tromey  <tom@tromey.com>
10561
10562         * compile/gcc-c-plugin.h: Include compile-internal.h.
10563
10564 2019-01-22  Tom Tromey  <tom@tromey.com>
10565
10566         * stabsread.c (EXTERN): Do not define.
10567         (symnum, next_symbol_text_func, processing_gcc_compilation)
10568         (within_function, global_sym_chain, global_stabs)
10569         (previous_stab_code, this_object_header_files)
10570         (n_this_object_header_files)
10571         (n_allocated_this_object_header_files): Define.
10572         * stabsread.h (EXTERN): Never define.  Use "extern".
10573
10574 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10575
10576         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10577         history_value.
10578
10579 2019-01-21  Tom Tromey  <tom@tromey.com>
10580
10581         * ui-out.c: Fix includes.
10582         * tui/tui-source.c: Fix includes.
10583         * target.c: Fix includes.
10584         * remote.c: Fix includes.
10585         * regcache.c: Fix includes.
10586         * python/py-block.c: Fix includes.
10587         * printcmd.c: Fix includes.
10588         * or1k-tdep.c: Fix includes.
10589         * mi/mi-main.c: Fix includes.
10590         * m32r-tdep.c: Fix includes.
10591         * csky-tdep.c: Fix includes.
10592         * compile/compile-cplus-types.c: Fix includes.
10593         * cli/cli-interp.c: Fix includes.
10594
10595 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10596
10597         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10598         for padding.
10599
10600 2019-01-16  Tom Tromey  <tom@tromey.com>
10601
10602         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10603         earlier.
10604         (struct objfile) <msymbols_range>: Move from top level.
10605         <msymbols>: New method.
10606         (class objfile_msymbols): Remove.
10607         * symtab.c (default_collect_symbol_completion_matches_break_on):
10608         Update.
10609         * symmisc.c (dump_msymbols): Update.
10610         * stabsread.c (scan_file_globals): Update.
10611         * objc-lang.c (info_selectors_command, info_classes_command)
10612         (find_methods): Update.
10613         * minsyms.c (find_solib_trampoline_target): Update.
10614         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10615         * coffread.c (coff_symfile_read): Update.
10616         * ada-lang.c (ada_lookup_simple_minsym)
10617         (ada_collect_symbol_completion_matches): Update.
10618
10619 2019-01-16  Tom Tromey  <tom@tromey.com>
10620
10621         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10622         type.  Remove no-argument constructor.
10623         <iterator::operator++>: Simplify.
10624         <begin>: Update.
10625         <end>: Use minimal_symbol_count.
10626
10627 2019-01-16  Tom Tromey  <tom@tromey.com>
10628
10629         * objfiles.h (struct objfile) <psymtabs>: New method.
10630         (class objfile_psymtabs): Remove.
10631         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10632         typedef.
10633         <range>: New method.
10634         (require_partial_symbols): Change return type.
10635         * psymtab.c (require_partial_symbols)
10636         (psym_expand_symtabs_matching): Update.
10637         * mdebugread.c (parse_partial_symbols): Update.
10638         * dbxread.c (dbx_end_psymtab): Update.
10639
10640 2019-01-15  Tom Tromey  <tom@tromey.com>
10641
10642         * symtab.c (lookup_objfile_from_block)
10643         (lookup_symbol_in_objfile_symtabs)
10644         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10645         (find_line_symtab, info_sources_command)
10646         (default_collect_symbol_completion_matches_break_on)
10647         (make_source_files_completion_list): Update.
10648         * symmisc.c (print_objfile_statistics, dump_objfile)
10649         (maintenance_print_symbols, maintenance_info_symtabs)
10650         (maintenance_check_symtabs, maintenance_info_line_tables):
10651         Update.
10652         * source.c (select_source_symtab)
10653         (forget_cached_source_info_for_objfile): Update.
10654         * objfiles.h (class objfile_compunits): Remove.
10655         (struct objfile) <compunits_range>: New typedef.
10656         (compunits): New method.
10657         * objfiles.c (objfile_relocate1): Update.
10658         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10659         * maint.c (count_symtabs_and_blocks): Update.
10660         * linespec.c (iterate_over_all_matching_symtabs): Update.
10661         * cp-support.c (add_symbol_overload_list_qualified): Update.
10662         * coffread.c (coff_symtab_read): Update.
10663         * ada-lang.c (add_nonlocal_symbols)
10664         (ada_collect_symbol_completion_matches)
10665         (ada_add_global_exceptions): Update.
10666
10667 2019-01-15  Tom Tromey  <tom@tromey.com>
10668
10669         * progspace.h (program_space) <objfiles_safe_range>: New
10670         typedef.
10671         <objfiles_safe>: New method.
10672         * objfiles.h (class all_objfiles_safe): Remove.
10673         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10674         * jit.c (jit_inferior_exit_hook): Update.
10675
10676 2019-01-17  Tom Tromey  <tom@tromey.com>
10677
10678         * progspace.h (program_space) <objfiles_range>: New typedef.
10679         <objfiles>: New method.
10680         <objfiles_head>: Rename from objfiles.
10681         (object_files): Update.
10682         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10683         * guile/scm-pretty-print.c
10684         (ppscm_find_pretty_printer_from_objfiles): Update.
10685         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10686         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10687         Update.
10688         * python/py-progspace.c (pspy_get_objfiles): Update.
10689         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10690         Update.
10691         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10692         (objfpy_lookup_objfile_by_build_id): Update.
10693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10694         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10695         Update.
10696         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10697         (expand_symtab_containing_pc, lookup_objfile_from_block)
10698         (lookup_static_symbol, basic_lookup_transparent_type)
10699         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10700         (find_line_symtab, info_sources_command)
10701         (default_collect_symbol_completion_matches_break_on)
10702         (make_source_files_completion_list, find_main_name): Update.
10703         * symmisc.c (print_symbol_bcache_statistics)
10704         (print_objfile_statistics, maintenance_print_symbols)
10705         (maintenance_print_msymbols, maintenance_print_objfiles)
10706         (maintenance_info_symtabs, maintenance_check_symtabs)
10707         (maintenance_expand_symtabs, maintenance_info_line_tables):
10708         Update.
10709         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10710         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10711         (map_overlay_command, unmap_overlay_command)
10712         (simple_overlay_update, expand_symtabs_matching)
10713         (map_symbol_filenames): Update.
10714         * symfile-debug.c (set_debug_symfile): Update.
10715         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10716         Update.
10717         * source.c (select_source_symtab, forget_cached_source_info):
10718         Update.
10719         * solib.c (solib_read_symbols): Update.
10720         * solib-spu.c (append_ocl_sos): Update.
10721         * psymtab.c (maintenance_print_psymbols)
10722         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10723         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10724         * printcmd.c (info_symbol_command): Update.
10725         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10726         Update.
10727         * objfiles.h (class all_objfiles): Remove.
10728         * objfiles.c (have_partial_symbols, have_full_symbols)
10729         (have_minimal_symbols, qsort_cmp, update_section_map)
10730         (shared_objfile_contains_address_p)
10731         (default_iterate_over_objfiles_in_search_order): Update.
10732         * objc-lang.c (info_selectors_command, info_classes_command)
10733         (find_methods): Update.
10734         * minsyms.c (find_solib_trampoline_target): Update.
10735         * maint.c (maintenance_info_sections)
10736         (maintenance_translate_address, count_symtabs_and_blocks):
10737         Update.
10738         * main.c (captured_main_1): Update.
10739         * linux-thread-db.c (try_thread_db_load_from_pdir)
10740         (has_libpthread): Update.
10741         * linespec.c (iterate_over_all_matching_symtabs)
10742         (search_minsyms_for_name): Update.
10743         * jit.c (jit_find_objf_with_entry_addr): Update.
10744         * hppa-tdep.c (find_unwind_entry)
10745         (hppa_lookup_stub_minimal_symbol): Update.
10746         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10747         Update.
10748         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10749         (elf_gnu_ifunc_resolve_by_got): Update.
10750         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10751         * dwarf-index-write.c (save_gdb_index_command): Update.
10752         * cp-support.c (add_symbol_overload_list_qualified): Update.
10753         * breakpoint.c (create_overlay_event_breakpoint)
10754         (create_longjmp_master_breakpoint)
10755         (create_std_terminate_master_breakpoint)
10756         (create_exception_master_breakpoint): Update.
10757         * blockframe.c (find_pc_partial_function): Update.
10758         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10759         (ada_collect_symbol_completion_matches)
10760         (ada_add_global_exceptions): Update.
10761
10762 2019-01-17  Tom Tromey  <tom@tromey.com>
10763
10764         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10765         declare VEC.
10766         (solib_target_parse_libraries): Change return type.
10767         (library_list_start_segment, library_list_start_section)
10768         (library_list_end_library, library_list_start_library); Update.
10769         (solib_target_free_library_list): Remove.
10770         (solib_target_parse_libraries): Remove cleanup.  Change return
10771         type.
10772         (solib_target_current_sos): Update.
10773
10774 2019-01-17  Tom Tromey  <tromey@bapiya>
10775
10776         * valprint.c: Replace "the the" with "the".
10777         * symtab.c: Replace "the the" with "the".
10778         * solib.c: Replace "the the" with "the".
10779         * solib-dsbt.c: Replace "the the" with "the".
10780         * linespec.c: Replace "the the" with "the".
10781         * dwarf2loc.h: Replace "the the" with "the".
10782         * amd64-windows-tdep.c: Replace "the the" with "the".
10783         * aarch64-tdep.c: Replace "the the" with "the".
10784
10785 2019-01-16  Keith Seitz  <keiths@redhat.com>
10786
10787         PR gdb/23773
10788         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10789         <builder>: Rename to ..
10790         <m_builder>: ... this and make private.
10791         (dwarf2_cu::get_builder): New method.  Change all users of
10792         `builder' to use this method.
10793         (dwarf2_start_symtab): Move to ...
10794         (dwarf2_cu::start_symtab): ... here.  Update all callers
10795         (setup_type_unit_groups): Move to ...
10796         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10797         callers.
10798         (dwarf2_cu::reset_builder): New method.
10799         (process_full_compunit, process_full_type_unit): Use
10800         dwarf2_cu::reset_builder.
10801         (follow_die_offset): Record the ancestor CU if it is different
10802         from the followed DIE's CU.
10803         (follow_die_sig_1): Likewise.
10804
10805 2019-01-15  Tom Tromey  <tom@tromey.com>
10806
10807         * remote.c (class remote_state) <buf>: Now a char_vector.
10808         <buf_size>: Remove.
10809         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10810         parameter.
10811         (remote_target::getpkt_or_notif_sane_1)
10812         (remote_target::getpkt_sane)
10813         (remote_target::getpkt_or_notif_sane): Likewise.
10814         (class remote_target) <putpkt>: New overload.
10815         (remote_target::read_frame): Change type of "buf_p".  Remove
10816         sizeof_p parameter.
10817         (packet_ok): New overload.
10818         (packet_check_result): New overload.
10819         Update all uses.
10820
10821 2019-01-14  Tom Tromey  <tom@tromey.com>
10822
10823         * remote-notif.c (handle_notification, remote_notif_ack)
10824         (remote_notif_parse): Make "buf" const.
10825         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10826         const.
10827         (remote_notif_parse, remote_notif_ack, handle_notification):
10828         Likewise.
10829         * remote.c (remote_notif_stop_parse): Make "buf" const.
10830         (remote_target::remote_parse_stop_reply): Make "buf" const.
10831         (remote_notif_stop_ack): Make "buf" const.
10832
10833 2019-01-14  Tom Tromey  <tom@tromey.com>
10834
10835         * remote.c (remote_console_output): Make parameter const.
10836
10837 2019-01-14  Tom Tromey  <tom@tromey.com>
10838
10839         * target-debug.h (target_debug_print_signals): Constify.
10840         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10841         * procfs.c (procfs_target::pass_signals): Update.
10842         * linux-nat.c (linux_nat_target::pass_signals): Update.
10843         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10844         * target-delegates.c: Rebuild.
10845         * remote.c (remote_target::program_signals): Update.
10846         (remote_target::pass_signals): Update.
10847         * target.c (target_pass_signals): Constify argument.
10848         (target_program_signals): Likewise.
10849         * target.h (struct target_ops) <pass_signals, program_signals>:
10850         Constify argument.
10851         (target_pass_signals, target_program_signals): Constify argument.
10852
10853 2019-01-14  Tom Tromey  <tom@tromey.com>
10854
10855         PR tui/28819:
10856         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10857
10858 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10859
10860         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10861         field.
10862         * rs6000-tdep.c: Include reggroups.h.
10863         (IS_V_ALIAS_PSEUDOREG): Define.
10864         (rs6000_register_name): Return names for the "vX" aliases.
10865         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10866         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10867         aliases.  Call default_register_reggroup_p for all other
10868         pseudo-registers.
10869         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10870         New functions.
10871         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10872         Handle "vX" aliases.
10873         (v_alias_pseudo_register_collect): New function.
10874         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10875         (rs6000_gdbarch_init): Initialize "vX" aliases as
10876         pseudo-registers.  Restore registration of
10877         rs6000_pseudo_register_reggroup_p with
10878         set_tdesc_pseudo_register_reggroup_p.
10879
10880 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10881
10882         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10883         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10884         set_gdbarch_num_pseudo_regs.
10885
10886 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10887
10888         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10889         Remove arg prefixname, add do_set and do_show.
10890         Add member functions set_list and show_list.
10891         * cli/cli-style.c (class cli_style_option): Update accordingly.
10892         (style_set_list): Move to file scope.
10893         (style_show_list): Likewise.
10894         (set_style): Call help_list.
10895         (show_style): Call cmd_show_list.
10896         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10897         Update to use the new macro.
10898
10899 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10900
10901         * ada-lang.c (_initialize_ada_language): Expand the help text
10902         for the "catch exception" command.
10903
10904 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10905
10906         * symtab.c (matching_obj_sections): Initialize obj,
10907         declare it closer to its usage.
10908
10909 2019-01-10  Tom Tromey  <tom@tromey.com>
10910
10911         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10912         (basic_inf_threads_range): Remove.
10913         (inf_threads_range, inf_non_exited_threads_range)
10914         (safe_inf_threads_range): Use next_adapter.
10915
10916 2019-01-10  Keith Seitz  <keiths@redhat.com>
10917
10918         PR gdb/23712
10919         PR symtab/23010
10920         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10921         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10922
10923 2019-01-10  Keith Seitz  <keiths@redhat.com>
10924
10925         PR gdb/23712
10926         PR symtab/23010
10927         * dictionary.c (pending_to_vector): Remove.
10928         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10929         Remove _1 suffix, replacing functions of the same name.  Update
10930         all callers.
10931         (dict_create_hashed, dict_create_hashed_expandable)
10932         (dict_create_linear, dict_create_linear_expandable, dict_free)
10933         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10934         Make functions static.
10935
10936 2019-01-10  Keith Seitz  <keiths@redhat.com>
10937
10938         PR gdb/23712
10939         PR symtab/23010
10940         * dictionary.h (struct dictionary): Replace declaration with
10941         multidictionary.
10942         (dict_create_hashed, dict_create_hashed_expandable)
10943         (dict_create_linear, dict_create_linear_expandable)
10944         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10945         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10946         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10947         taking multidictionary argument.
10948         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10949         * block.h (struct block) <dict>: Change to multidictionary
10950         and rename `multidict'.
10951         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10952         symmisc.c: Update all dictionary references to multidictionary.
10953
10954 2019-01-10  Keith Seitz  <keiths@redhat.com>
10955
10956         PR gdb/23712
10957         PR symtab/23010
10958         * dictionary.c: Include unordered_map.
10959         (pending_to_vector): New function.
10960         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10961         Rewrite the non-"_1" functions to take vector instead
10962         of linked list.
10963         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10964         "new" _1 versions of the same name.
10965         (multidictionary): Define.
10966         (std::hash<enum language): New definition.
10967         (collate_pending_symbols_by_language, mdict_create_hashed)
10968         (mdict_create_hashed_expandable, mdict_create_linear)
10969         (mdict_create_linear_expandable, mdict_free)
10970         (find_language_dictionary, create_new_language_dictionary)
10971         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10972         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10973         (mdict_size, mdict_empty): New functions.
10974         * dictionary.h (mdict_iterator): Define.
10975
10976 2019-01-10  Pedro Alves  <palves@redhat.com>
10977
10978         * breakpoint.c (read_uploaded_action)
10979         (create_tracepoint_from_upload): Adjust to use
10980         gdb::unique_xmalloc_ptr.
10981         * ctf.c (ctf_write_uploaded_tp):
10982         (SET_ARRAY_FIELD): Use emplace_back.
10983         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10984         * tracefile-tfile.c (tfile_write_uploaded_tp):
10985         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10986         gdb::unique_xmalloc_ptr.
10987         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10988         at_string, cond_string, cmd_strings>: Replace char pointers
10989         with gdb::unique_xmalloc_ptr.
10990
10991 2019-01-10  Pedro Alves  <palves@redhat.com>
10992
10993         * solib-target.c (library_list_start_library): Don't xstrdup name.
10994
10995 2019-01-10  Pedro Alves  <palves@redhat.com>
10996
10997         * mdebugread.c (parse_partial_symbols): Use
10998         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10999
11000 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11001
11002         * linux-fork.c (scoped_switch_fork_info)
11003         <~scoped_switch_fork_info>: Fix incorrect variable name.
11004
11005 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11006
11007         * linux-fork.c (scoped_switch_fork_info)
11008         <scoped_switch_fork_info>: Make explicit.
11009         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11010
11011 2019-01-10  Tom Tromey  <tom@tromey.com>
11012
11013         * objfiles.h (objfile::reset_psymtabs): Update.
11014         * objfiles.c (objfile::objfile): Update.
11015         * psymtab.h (psymtab_storage::obstack): Update.
11016         (psymtab_storage::m_obstack): Use gdb::optional.
11017         (class psymtab_storage): Update comment.  Remove objfile
11018         parameter.
11019         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11020
11021 2019-01-10  Tom Tromey  <tom@tromey.com>
11022
11023         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11024         <free_psymtabs>: Now private.
11025         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11026         (allocate_psymtab): Use new method.
11027
11028 2019-01-10  Tom Tromey  <tom@tromey.com>
11029
11030         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11031         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11032         * mdebugread.c (parse_partial_symbols): Use
11033         allocate_dependencies.
11034         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11035         allocate_dependencies.
11036         (process_psymtab_comp_unit_reader)
11037         (build_type_psymtab_dependencies): Likewise.
11038         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11039
11040 2019-01-10  Tom Tromey  <tom@tromey.com>
11041
11042         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11043         PSYMBOL_SET_LANGUAGE.
11044         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11045
11046 2019-01-10  Tom Tromey  <tom@tromey.com>
11047
11048         * psymtab.h (psymtab_storage::obstack): New method.
11049         <m_obstack>: Rename from obstack; now private.
11050         * psymtab.c (psymtab_storage): Update.
11051         * dwarf2read.c (create_addrmap_from_index)
11052         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11053         Update.
11054
11055 2019-01-10  Tom Tromey  <tom@tromey.com>
11056
11057         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11058         * objfiles.h (objfile::reset_psymtabs): New method.
11059
11060 2019-01-10  Tom Tromey  <tom@tromey.com>
11061
11062         * symmisc.c (print_symbol_bcache_statistics): Update.
11063         (print_objfile_statistics): Update.
11064         * symfile.c (reread_symbols): Update.
11065         * psymtab.h (class psymtab_storage): New.
11066         * psymtab.c (psymtab_storage): New constructor.
11067         (~psymtab_storage): New destructor.
11068         (require_partial_symbols): Update.
11069         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11070         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11071         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11072         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11073         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11074         (start_psymtab_common, end_psymtab_common)
11075         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11076         (allocate_psymtab): Update.
11077         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11078         Update.
11079         (dump_psymtab_addrmap, maintenance_print_psymbols)
11080         (maintenance_check_psymtabs): Update.
11081         (class objfile_psymtabs): Move to objfiles.h.
11082         * psympriv.h (discard_psymtab): Now inline.
11083         (psymtab_discarder::psymtab_discarder): Update.
11084         (psymtab_discarder::~psymtab_discarder): Update.
11085         (ALL_OBJFILE_PSYMTABS): Rewrite.
11086         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11087         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11088         Remove fields.
11089         <partial_symtabs>: New field.
11090         (class objfile_psymtabs): Move from psymtab.h.  Update.
11091         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11092         psymbol_cache.
11093         (objfile::~objfile): Don't destroy psymbol_cache.
11094         * mdebugread.c (parse_partial_symbols): Update.
11095         * dwarf2read.c (create_addrmap_from_index)
11096         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11097         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11098         (add_partial_subprogram, dwarf2_ranges_read): Update.
11099         * dwarf-index-write.c (write_address_map)
11100         (write_one_signatured_type, recursively_write_psymbols)
11101         (class debug_names, class debug_names, write_psymtabs_to_index):
11102         Update.
11103
11104 2019-01-10  Tom Tromey  <tom@tromey.com>
11105
11106         * symtab.h (SYMBOL_SET_NAMES): Update.
11107         (symbol_set_names): Update.
11108         (MSYMBOL_SET_NAMES): Update.
11109         * symtab.c (symbol_set_names): Change argument to be an
11110         objfile_per_bfd_storage.
11111         * psymtab.c (add_psymbol_to_bcache): Update.
11112         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11113
11114 2019-01-10  Tom Tromey  <tom@tromey.com>
11115
11116         * symtab.c (create_demangled_names_hash): Change argument to be an
11117         objfile_per_bfd_storage.
11118         (symbol_set_names): Update.
11119
11120 2019-01-10  Tom Tromey  <tom@tromey.com>
11121
11122         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11123         init_psymbol_list.
11124         * psymtab.c (init_psymbol_list): Do nothing if already called.
11125         * psympriv.h (init_psymbol_list): Add comment.
11126         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11127         init_psymbol_list.
11128         * dbxread.c (dbx_symfile_read): Unconditionally call
11129         init_psymbol_list.
11130
11131 2019-01-10  Tom Tromey  <tom@tromey.com>
11132
11133         * xcoffread.c (scan_xcoff_symtab): Update.
11134         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11135         "where".
11136         * mdebugread.c (parse_partial_symbols)
11137         (handle_psymbol_enumerators): Update.
11138         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11139         * dbxread.c (read_dbx_symtab): Update.
11140         * psympriv.h (psymbol_placement): New enum.
11141         (add_psymbol_to_list): Update.
11142
11143 2019-01-10  Tom Tromey  <tom@tromey.com>
11144
11145         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11146         static_psymbols parameters.
11147         (scan_xcoff_symtab): Update.
11148         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11149         static_psymbols parameters.
11150         * psympriv.h (start_psymtab_common): Update.
11151         * mdebugread.c (parse_partial_symbols): Update.
11152         * dwarf2read.c (create_partial_symtab): Update.
11153         * dbxread.c (read_dbx_symtab): Update.
11154         (start_psymtab): Remove global_psymbols and static_psymbols
11155         parameters.
11156
11157 2019-01-10  Tom Tromey  <tom@tromey.com>
11158
11159         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11160         * psymtab.c (allocate_psymtab): Add comment.
11161         * psympriv.h (allocate_psymtab): Add comment.
11162         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11163         initializations.
11164         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11165
11166 2019-01-10  Tom Tromey  <tom@tromey.com>
11167
11168         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11169         Don't declare.
11170         * mipsread.c: Include mdebugread.h.
11171         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11172         Declare.
11173         * elfread.c: Include mdebugread.h.
11174
11175 2019-01-09  Tom Tromey  <tom@tromey.com>
11176
11177         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11178         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11179         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11180         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11181         (psym_lookup_symbol, psym_find_last_source_symtab)
11182         (psym_forget_cached_source_info, psym_print_stats)
11183         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11184         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11185         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11186         (psym_find_compunit_symtab_by_address)
11187         (maintenance_print_psymbols, maintenance_info_psymtabs)
11188         (maintenance_check_psymtabs): Use ranged for.
11189         * psymtab.h (class objfile_psymtabs): New.
11190         (require_partial_symbols): Return objfile_psymtabs.
11191         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11192
11193 2019-01-09  Tom Tromey  <tom@tromey.com>
11194
11195         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11196         (find_pc_mapped_section, list_overlays_command)
11197         (map_overlay_command, unmap_overlay_command)
11198         (simple_overlay_update): Use all_objfiles.
11199         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11200         * printcmd.c (info_symbol_command): Use all_objfiles.
11201         * objfiles.h (ALL_OBJSECTIONS): Remove.
11202         * maint.c (maintenance_translate_address): Use all_objfiles.
11203         * gcore.c (gcore_create_callback): Use all_objfiles.
11204         (objfile_find_memory_regions): Likewise.
11205
11206 2019-01-09  Tom Tromey  <tom@tromey.com>
11207
11208         * symtab.c (find_line_symtab, info_sources_command)
11209         (make_source_files_completion_list): Use objfile_compunits.
11210         * source.c (select_source_symtab): Use objfile_compunits.
11211         * objfiles.h (struct objfile): Update comment.
11212         (ALL_OBJFILES): Remove.
11213         (ALL_FILETABS): Remove.
11214         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11215         objfile_compunits.
11216
11217 2019-01-09  Tom Tromey  <tom@tromey.com>
11218
11219         * symmisc.c (print_objfile_statistics, dump_objfile)
11220         (maintenance_print_symbols): Use compunit_filetabs.
11221         * source.c (forget_cached_source_info_for_objfile): Use
11222         compunit_filetabs.
11223         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11224         (ALL_FILETABS): Use compunit_filetabs.
11225         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11226         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11227
11228 2019-01-09  Tom Tromey  <tom@tromey.com>
11229
11230         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11231         (compunit_filetabs): New.
11232         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11233         compunit_filetabs.
11234         (info_sources_command, make_source_files_completion_list): Remove
11235         declaration.
11236         * symmisc.c (print_objfile_statistics, dump_objfile)
11237         (maintenance_print_symbols): Remove declaration.
11238         (maintenance_info_symtabs): Use compunit_filetabs.
11239         (maintenance_info_line_tables): Likewise.
11240         * source.c (select_source_symtab): Change local variable name.
11241         (forget_cached_source_info_for_objfile): Remove declaration.
11242         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11243         * objfiles.c (objfile_relocate1): Remove declaration.
11244         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11245         declaration.
11246         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11247         * coffread.c (coff_symtab_read): Remove declaration.
11248         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11249         compunit_filetabs.
11250
11251 2019-01-09  Tom Tromey  <tom@tromey.com>
11252
11253         * symtab.c (lookup_objfile_from_block)
11254         (find_pc_sect_compunit_symtab, search_symbols)
11255         (default_collect_symbol_completion_matches_break_on): Use
11256         objfile_compunits.
11257         * objfiles.h (ALL_COMPUNITS): Remove.
11258         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11259         * cp-support.c (add_symbol_overload_list_qualified): Use
11260         objfile_compunits.
11261         * ada-lang.c (ada_collect_symbol_completion_matches)
11262         (ada_add_global_exceptions): Use objfile_compunits.
11263
11264 2019-01-09  Tom Tromey  <tom@tromey.com>
11265
11266         * source.c (select_source_symtab)
11267         (forget_cached_source_info_for_objfile): Remove declaration.
11268         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11269         declaration.
11270         * maint.c (count_symtabs_and_blocks): Remove declaration.
11271         * cp-support.c (add_symbol_overload_list_qualified): Remove
11272         declaration.
11273         * coffread.c (coff_symtab_read): Remove declaration.
11274         * symtab.c (lookup_symbol_in_objfile_symtabs)
11275         (basic_lookup_transparent_type_1): Use objfile_compunits.
11276         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11277         (info_sources_command, search_symbols)
11278         (default_collect_symbol_completion_matches_break_on)
11279         (make_source_files_completion_list): Remove declaration.
11280         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11281         (ada_collect_symbol_completion_matches)
11282         (ada_add_global_exceptions): Remove declaration.
11283         * linespec.c (iterate_over_all_matching_symtabs): Use
11284         objfile_compunits.
11285         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11286         (class objfile_compunits): New.
11287         (ALL_COMPUNITS): Use objfile_compunits.
11288         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11289         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11290         objfile_compunits.
11291         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11292
11293 2019-01-09  Tom Tromey  <tom@tromey.com>
11294
11295         * symtab.c (search_symbols)
11296         (default_collect_symbol_completion_matches_break_on): Use
11297         objfile_msymbols.
11298         * ada-lang.c (ada_lookup_simple_minsym)
11299         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11300         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11301         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11302         objfile_msymbols.
11303         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11304         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11305         * objc-lang.c (find_methods): Use objfile_msymbols.
11306         (info_selectors_command, info_classes_command): Likewise.
11307         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11308         * objfiles.h (class objfile_msymbols): New.
11309         (ALL_OBJFILE_MSYMBOLS): Remove.
11310         (ALL_MSYMBOLS): Remove.
11311
11312 2019-01-09  Tom Tromey  <tom@tromey.com>
11313
11314         * common/next-iterator.h (next_adapter): Add Iterator template
11315         parameter.
11316         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11317         (class all_objfiles_safe): New.
11318         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11319         * objfiles.c (put_objfile_before): Update comment.
11320         (add_separate_debug_objfile): Likewise.
11321         (free_all_objfiles): Use all_objfiles_safe.
11322         (objfile_purge_solibs): Likewise.
11323
11324 2019-01-09  Tom Tromey  <tom@tromey.com>
11325
11326         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11327         (expand_symtab_containing_pc, lookup_static_symbol)
11328         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11329         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11330         all_objfiles.
11331         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11332         * breakpoint.c (create_overlay_event_breakpoint)
11333         (create_longjmp_master_breakpoint)
11334         (create_std_terminate_master_breakpoint)
11335         (create_exception_master_breakpoint): Use all_objfiles.
11336         * linux-thread-db.c (try_thread_db_load_from_pdir)
11337         (has_libpthread): Use all_objfiles.
11338         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11339         * linespec.c (iterate_over_all_matching_symtabs)
11340         (search_minsyms_for_name): Use all_objfiles.
11341         * maint.c (maintenance_info_sections): Use all_objfiles.
11342         * main.c (captured_main_1): Use all_objfiles.
11343         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11344         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11345         * guile/scm-pretty-print.c
11346         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11347         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11348         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11349         (maintenance_print_msymbols): Use all_objfiles.
11350         * source.c (select_source_symtab): Use all_objfiles.
11351         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11352         * symfile.c (remove_symbol_file_command)
11353         (expand_symtabs_matching, map_symbol_filenames): Use
11354         all_objfiles.
11355         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11356         all_objfiles.
11357         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11358         * objc-lang.c (find_methods): Use all_objfiles.
11359         * objfiles.c (have_partial_symbols, have_full_symbols)
11360         (have_minimal_symbols, qsort_cmp)
11361         (default_iterate_over_objfiles_in_search_order): Use
11362         all_objfiles.
11363         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11364         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11365         (maintenance_check_psymtabs): Use all_objfiles.
11366         (ALL_PSYMTABS): Remove.
11367         * compile/compile-object-run.c (do_module_cleanup): Use
11368         all_objfiles.
11369         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11370         * cp-support.c (add_symbol_overload_list_qualified): Use
11371         all_objfiles.
11372         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11373         Use all_objfiles.
11374         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11375         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11376         all_objfiles.
11377         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11378         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11379         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11380         Uses all_objfiles.
11381         * solib.c (solib_read_symbols): Use all_objfiles
11382
11383 2019-01-09  Tom Tromey  <tom@tromey.com>
11384
11385         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11386         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11387         all_objfiles.
11388         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11389         * symmisc.c (print_symbol_bcache_statistics)
11390         (print_objfile_statistics, maintenance_print_objfiles)
11391         (maintenance_info_symtabs, maintenance_check_symtabs)
11392         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11393         all_objfiles.
11394         * source.c (forget_cached_source_info): Use all_objfiles.
11395         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11396         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11397         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11398         * objfiles.c (update_section_map): Use all_objfiles.
11399         (shared_objfile_contains_address_p): Likewise.
11400         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11401         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11402
11403 2019-01-09  Tom Tromey  <tom@tromey.com>
11404
11405         * common/next-iterator.h: New file.
11406         * objfiles.h (class all_objfiles): New.
11407         (struct objfile_iterator): New.
11408
11409 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11410
11411         * NEWS: Move the description of the changed "frame", "select-frame",
11412          and "info frame" commands to the Changed commands section.
11413
11414 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11415
11416         * gdbtypes.c (check_stub_method_group): Remove handling of old
11417         mangling schemes.
11418         * linespec.c (find_methods): Likewise.
11419         * stabsread.c (read_member_functions): Likewise.
11420         * valops.c (search_struct_method): Likewise.
11421         (value_struct_elt_for_reference): Likewise.
11422         * NEWS: Mention this change.
11423
11424 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11425
11426         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11427         print_source_lines.
11428         * source.c (print_source_lines_base): Update line number check.
11429         (print_source_lines): New function.
11430         (source_lines_range::source_lines_range): New function.
11431         * source.h (class source_lines_range): New class.
11432         (print_source_lines): New declaration.
11433
11434 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11435
11436         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11437
11438 2019-01-08  Tom Tromey  <tom@tromey.com>
11439             Simon Marchi  <simon.marchi@ericsson.com>
11440
11441         PR gdb/24060
11442         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11443         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11444         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11445         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11446         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11447         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11448
11449 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11450
11451         * source.c (select_source_symtab): Move header comment to
11452         declaration in source.h.
11453         (forget_cached_source_info_for_objfile): Likewise.
11454         (forget_cached_source_info): Likewise.
11455         (identify_source_line): Likewise.
11456         * source.h (identify_source_line): Move declaration from symtab.h
11457         and add comment from source.c
11458         (print_source_lines): Likewise.
11459         (forget_cached_source_info_for_objfile): Likewise.
11460         (forget_cached_source_info): Likewise.
11461         (select_source_symtab): Likewise.
11462         (enum print_source_lines_flag): Move definition from symtab.h.
11463         * symtab.h (identify_source_line): Move declaration to source.h.
11464         (print_source_lines): Likewise.
11465         (forget_cached_source_info_for_objfile): Likewise.
11466         (forget_cached_source_info): Likewise.
11467         (select_source_symtab): Likewise.
11468         (enum print_source_lines_flag): Move definition to source.h.
11469         * tui/tui-hooks.c: Add 'source.h' include.
11470
11471 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11472
11473         * source.c (print_source_lines_base): Handle requests to print
11474         reverse line number sequences, and guard against empty lines
11475         string.
11476
11477 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11478
11479         * source.c (print_source_lines_base): Fix skip of '\r' if next
11480         character is '\n'.
11481
11482 2019-01-06  Tom Tromey  <tom@tromey.com>
11483
11484         * c-exp.y (struct c_parse_state) <macro_original_text,
11485         expansion_obstack>: New member.
11486         (macro_original_text, expansion_obstack): Remove globals.
11487         (scan_macro_expansion, scanning_macro_expansion)
11488         (finished_macro_expansion): Update.
11489         (scan_macro_cleanup): Remove.
11490         (yylex, c_parse): Update.
11491
11492 2019-01-06  Tom Tromey  <tom@tromey.com>
11493
11494         * c-exp.y (struct c_parse_state) <strings>: New member.
11495         (operator_stoken): Update.
11496
11497 2019-01-06  Tom Tromey  <tom@tromey.com>
11498
11499         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11500         (union type_stack_elt) <typelist_val>: Now a pointer to
11501         std::vector.
11502         (type_stack_cleanup): Don't declare.
11503         (push_typelist): Update.
11504         * parse.c (pop_typelist): Return a std::vector.
11505         (push_typelist): Take a std::vector.
11506         (follow_types): Update.  Do not free args.
11507         (type_stack_cleanup): Remove.
11508         * c-exp.y (struct c_parse_state): New.
11509         (cpstate): New global.
11510         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11511         (nonempty_typelist): Update.
11512         (func_mod): Create a new vector.
11513         (c_parse): Create a c_parse_state.
11514         (check_parameter_typelist): Do not delete params.
11515         (function_method): Update.  Do not delete type_list.
11516
11517 2019-01-06  Tom Tromey  <tom@tromey.com>
11518
11519         PR gdb/28155:
11520         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11521         check_typedef.
11522         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11523         (print_return_value): Likewise.
11524
11525 2019-01-05  Tom Tromey  <tom@tromey.com>
11526
11527         * contrib/cleanup_check.py: Remove.
11528         * contrib/gcc-with-excheck: Remove.
11529         * contrib/exsummary.py: Remove.
11530         * contrib/excheck.py: Remove.
11531
11532 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11533
11534         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11535         NULL. Initialize tpprev to NULL instead of assigning it
11536         to NULL on the next statement.
11537         * windows-nat.c (windows_delete_thread): Remove check for
11538         main_thread_id before printing thread exit notifications.
11539         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11540         Remove thread ID check against main_thread_id.
11541         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11542         windows_delete_thread.
11543         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11544
11545 2019-01-04  Tom Tromey  <tom@tromey.com>
11546
11547         * compile/compile.c (_initialize_compile): Use upper case for
11548         metasyntactic variables.
11549         * symmisc.c (_initialize_symmisc): Use upper case for
11550         metasyntactic variables.
11551         * psymtab.c (_initialize_psymtab): Use upper case for
11552         metasyntactic variables.
11553         * demangle.c (demangle_command): Use upper case for metasyntactic
11554         variables.
11555         (_initialize_demangler): Likewise.
11556         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11557         variables.
11558
11559 2019-01-03  Tom Tromey  <tom@tromey.com>
11560
11561         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11562
11563 2019-01-03  Tom Tromey  <tom@tromey.com>
11564
11565         * python/py-symtab.c (salpy_str): Update.
11566         (struct salpy_sal_object) <symtab>: Now a PyObject.
11567         (salpy_dealloc): Update.
11568         (del_objfile_sal): Use gdbpy_ref.
11569
11570 2019-01-03  Tom Tromey  <tom@tromey.com>
11571
11572         * python/py-type.c (convert_field): Use new_reference.  Return
11573         gdbpy_ref.
11574         (make_fielditem): Return gdbpy_ref.
11575         (typy_fields): Update.
11576         (typy_getitem): Update.
11577         (field_name): Return gdbpy_ref.  Use new_reference.
11578         (typy_iterator_iternext): Update.
11579
11580 2019-01-03  Tom Tromey  <tom@tromey.com>
11581
11582         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11583
11584 2019-01-03  Tom Tromey  <tom@tromey.com>
11585
11586         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11587         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11588         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11589         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11590         (pspy_set_type_printers): Likewise.
11591         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11592         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11593         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11594         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11595         (objfpy_set_type_printers): Likewise.
11596
11597 2019-01-03  Tom Tromey  <tom@tromey.com>
11598
11599         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11600         (gdbpy_print_stack): Use gdbpy_err_fetch.
11601         * python/python-internal.h (class gdbpy_err_fetch): New class.
11602         (class gdbpy_enter) <m_error_type, m_error_value,
11603         m_error_traceback>: Remove.
11604         <m_error>: New member.
11605         (gdbpy_exception_to_string): Don't declare.
11606         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11607         * python/py-value.c (convert_value_from_python): Use
11608         gdbpy_err_fetch.
11609         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11610         gdbpy_exception_to_string.
11611         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11612         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11613         gdbpy_err_fetch.
11614
11615 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11616
11617         * linux-nat.c (delete_lwp_cleanup): Delete.
11618         (struct lwp_deleter): New struct.
11619         (lwp_info_up): New typedef.
11620         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11621         lwp_info_up.
11622
11623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11624
11625         * linux-fork.c (class scoped_switch_fork_info): New class.
11626         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11627
11628 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11629
11630         * valops.c (find_overload_match): Remove use of null_cleanup, and
11631         calls to do_cleanups.
11632
11633 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11634
11635         * compile/compile-cplus-types.c
11636         (compile_cplus_instance::decl_name): Handle changes to
11637         cp_func_name.
11638         * cp-support.c (cp_func_name): Update header comment, update
11639         return type.
11640         * cp-support.h (cp_func_name): Update return type in declaration.
11641         * valops.c (find_overload_match): Move temp_func local to top
11642         level of function and change its type.  Use temp_func to hold and
11643         delete temporary string obtained from cp_func_name.
11644
11645 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11646
11647         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11648         gdb::char_vector, remove cleanup, and update uses of `msg`.
11649
11650 2019-01-03  Jim Wilson  <jimw@sifive.com>
11651
11652         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11653
11654 2019-01-02  Tom Tromey  <tom@tromey.com>
11655
11656         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11657         (tdesc_parse_xml): Remove cleanups.
11658         * target-descriptions.h (make_cleanup_free_target_description):
11659         Don't declare.
11660         (target_desc_deleter): New struct.
11661         (target_desc_up): New typedef.
11662         * target-descriptions.c (target_desc_deleter::operator()): Rename
11663         from free_target_description.
11664         (make_cleanup_free_target_description): Remove.
11665
11666 2019-01-02  Tom Tromey  <tom@tromey.com>
11667
11668         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11669         constructor, destructor.
11670         (linespec_parser): Remove typedef.
11671         (~linespec_parser): Rename from linespec_parser_delete.
11672         (linespec_lex_to_end, linespec_complete_label)
11673         (linespec_complete): Update.
11674         (decode_line_full): Remove cleanups.
11675         (decode_line_1): Update.
11676
11677 2019-01-02  Tom Tromey  <tom@tromey.com>
11678
11679         * python/python-internal.h (inferior_to_inferior_object): Change
11680         return type.
11681         * python/py-exitedevent.c (create_exited_event_object): Update.
11682         * python/py-inferior.c (inferior_to_inferior_object): Return
11683         gdbpy_ref.
11684         (python_new_inferior, python_inferior_deleted)
11685         (thread_to_thread_object, delete_thread_object)
11686         (build_inferior_list, gdbpy_selected_inferior): Update.
11687         * python/py-infthread.c (create_thread_object): Update.  Also fail
11688         if inferior_to_inferior_object fails.
11689
11690 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11691
11692         * inferior.h (class inferior) <displaced_step_state>: New field.
11693         * infrun.h (struct displaced_step_state): Move here from
11694         infrun.c.  Initialize fields, add constructor.
11695         <inf>: Remove field.
11696         <reset>: New method.
11697         * infrun.c (struct displaced_step_inferior_state): Move to
11698         infrun.h.
11699         (displaced_step_inferior_states): Remove.
11700         (get_displaced_stepping_state): Adust.
11701         (displaced_step_in_progress_any_inferior): Adjust.
11702         (displaced_step_in_progress_thread): Adjust.
11703         (displaced_step_in_progress): Adjust.
11704         (add_displaced_stepping_state): Remove.
11705         (get_displaced_step_closure_by_addr): Adjust.
11706         (remove_displaced_stepping_state): Remove.
11707         (infrun_inferior_exit): Call displaced_step_state.reset.
11708         (use_displaced_stepping): Don't check for NULL.
11709         (displaced_step_prepare_throw): Call
11710         get_displaced_stepping_state.
11711         (displaced_step_fixup): Don't check for NULL.
11712         (prepare_for_detach): Don't check for NULL.
11713
11714 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11715
11716         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11717          in case of call that did not complete.
11718
11719 2019-01-02  Andrey Utkin  <autkin@undo.io>
11720
11721         * symfile.c (find_separate_debug_file): Fix search of debug files for
11722         remote debuggee.
11723
11724 2019-01-02  Tom Tromey  <tom@tromey.com>
11725
11726         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11727         indentation.
11728         * python/py-frame.c (frapy_older): Remove cast.
11729         (frapy_newer): Likewise.
11730         * python/py-breakpoint.c (local_setattro): Remove cast.
11731         * python/py-arch.c (archpy_name): Remove local variable.
11732         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11733
11734 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11735
11736         * unittests/basic_string_view/element_access/char/empty.cc:
11737         Fix year range in copyright header.
11738
11739 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11740
11741         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11742         Delete.
11743         <operator==>: Update with for removed field.
11744         <hash>: Likewise.
11745         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11746         <isa_features>: ...this.
11747         <abi_features>: New field.
11748         (riscv_isa_flen): Update comment.
11749         (riscv_abi_xlen): New declaration.
11750         (riscv_abi_flen): New declaration.
11751         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11752         isa_features.
11753         (riscv_abi_xlen): New function.
11754         (riscv_isa_flen): Update to get answer from isa_features.
11755         (riscv_abi_flen): New function.
11756         (riscv_has_fp_abi): Update to get answer from abi_features.
11757         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11758         xlen and flen.
11759         (riscv_call_info) <xlen, flen>: Update comment.
11760         (riscv_call_arg_struct): Remove invalid assertions
11761         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11762         is removed.
11763         (riscv_gdbarch_init): Gather isa features and abi features
11764         separately, ensure both match on the gdbarch when reusing an old
11765         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11766         a target with 64-bit float hardware.
11767
11768 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11769
11770         * source.c (search_command_helper): Stop reverse search
11771         when line 1 has been searched.
11772
11773 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11774
11775         * record-full.c (record_full_base_target::close): Rewrite
11776         record_full_core_buf_list free logic.
11777
11778 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11779
11780         * break-catch-syscall.c (print_one_catch_syscall): xfree
11781         the last text.
11782
11783 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11784
11785         * top.c (print_gdb_version): Update Copyright year in version
11786         message.
11787
11788 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11789
11790         Update copyright year range in all GDB files.
11791
11792 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11793
11794         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11795
11796 For older changes see ChangeLog-2018.
11797 \f
11798 Local Variables:
11799 mode: change-log
11800 left-margin: 8
11801 fill-column: 74
11802 version-control: never
11803 coding: utf-8
11804 End:
11805