gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_item_window)
   4         <~tui_data_item_window>: Remove.
   5         <content>: Now a unique_xmalloc_ptr.
   6         * tui/tui-regs.c (tui_register_format): Return a
   7         unique_xmalloc_ptr.
   8         (tui_get_register): Update.
   9         (~tui_data_item_window): Remove.
  10         (tui_data_window::display_registers_from, tui_display_register):
  11         Update.
  12         * tui/tui-io.h (tui_expand_tabs): Update.
  13         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  14         Remove "col" parameter.
  15
  16 2019-08-20  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  19         field.
  20         * tui/tui-regs.c (~tui_data_item_window): Update.
  21
  22 2019-08-20  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  25         earlier.
  26
  27 2019-08-20  Tom Tromey  <tom@tromey.com>
  28
  29         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  30
  31 2019-08-20  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-source.h (struct tui_source_window): Update.
  34         * tui/tui-regs.c (tui_show_registers): Update.
  35         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  36         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  37         (NO_REGS_STRING): Remove defines.
  38
  39 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  40
  41         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  42         unnecessary thread walk if remote doesn't support the packet.
  43
  44 2019-08-19  Tom Tromey  <tromey@adacore.com>
  45
  46         * python/py-value.c (value_has_field): Fix indentation.
  47
  48 2019-08-19  Tom Tromey  <tromey@adacore.com>
  49
  50         * printcmd.c (do_one_display, info_display_command): Update.
  51         * block.h (contained_in): Return bool.  Add allow_nested
  52         parameter.
  53         * block.c (contained_in): Return bool.  Add allow_nested
  54         parameter.
  55
  56 2019-08-19  Tom Tromey  <tom@tromey.com>
  57
  58         * configure: Rebuild.
  59         * configure.ac: Disallow the combination of -static-libstdc++ and
  60         source highlight.
  61         * source-cache.c (get_language_name): Handle rust.
  62         (source_cache::get_source_lines): Ignore highlighting exceptions.
  63
  64 2019-08-16  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
  67         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
  68         (struct tui_source_window_base) <make_visible, refresh_window,
  69         resize>: Remove methods.
  70         <execution_info>: Remove field.
  71         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
  72         (tui_show_source_line, tui_source_window_base)
  73         (~tui_source_window_base): Update.
  74         (tui_source_window_base::resize)
  75         (tui_source_window_base::make_visible)
  76         (tui_source_window_base::refresh_window): Remove.
  77         (tui_source_window_base::update_exec_info): Update.
  78         * tui/tui-source.c (tui_source_window::set_contents): Update.
  79         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  80
  81 2019-08-16  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-hooks.c (tui_remove_hooks): Don't set
  84         deprecated_query_hook.
  85
  86 2019-08-16  Tom Tromey  <tom@tromey.com>
  87
  88         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  89         (tui_update_source_windows_with_line): Update.
  90         * tui/tui-source.h (struct tui_source_window)
  91         <show_symtab_source>: Declare.
  92         (tui_show_symtab_source): Don't declare.
  93         * tui/tui-source.c (tui_show_symtab_source): Rename from
  94         tui_show_symtab_source.
  95
  96 2019-08-16  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.h (struct tui_source_window_base)
  99         <set_contents>: Declare.
 100         * tui/tui-winsource.c
 101         (tui_source_window_base::update_source_window_as_is): Update.
 102         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 103         Declare.
 104         (tui_set_source_content): Don't declare.
 105         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 106         tui_set_source_content.
 107         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 108         Declare.
 109         (tui_set_disassem_content): Don't declare.
 110         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 111         tui_set_disassem_content.
 112
 113 2019-08-16  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.h (struct tui_source_window_base)
 116         <update_breakpoint_info>: Declare.
 117         (tui_update_breakpoint_info): Don't declare.
 118         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 119         (tui_update_all_breakpoint_info): Update.
 120         (tui_source_window_base::update_breakpoint_info): Rename from
 121         tui_update_breakpoint_info.
 122         (tui_source_window_base::update_exec_info): Update.
 123
 124 2019-08-16  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-winsource.h (struct tui_source_window_base)
 127         <update_source_window>: Declare.
 128         (tui_update_source_window): Don't declare.
 129         * tui/tui-winsource.c
 130         (tui_source_window_base::update_source_window): Rename from
 131         tui_update_source_window.
 132         (tui_source_window_base::rerender): Update.
 133         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 134         * tui/tui-disasm.c (tui_show_disassem)
 135         (tui_show_disassem_and_update_source)
 136         (tui_disasm_window::maybe_update): Update.
 137
 138 2019-08-16  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.h (struct tui_source_window_base)
 141         <update_source_window_as_is>: Declare.
 142         (tui_update_source_window_as_is): Don't declare.
 143         * tui/tui-winsource.c (tui_update_source_window): Update
 144         (tui_source_window_base::update_source_window_as_is): Rename from
 145         tui_update_source_window_as_is.
 146         (tui_source_window_base::refill): Update.
 147         * tui/tui-source.c (tui_show_symtab_source): Update.
 148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 149         Update.
 150
 151 2019-08-16  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-winsource.h (tui_update_source_window)
 154         (tui_update_source_window_as_is): Remove "noerror" parameter.
 155         * tui/tui-winsource.c (tui_update_source_window)
 156         (tui_update_source_window_as_is): Remove "noerror" parameter.
 157         (tui_update_source_windows_with_addr)
 158         (tui_update_source_windows_with_line)
 159         (tui_source_window_base::rerender)
 160         (tui_source_window_base::refill): Update.
 161         * tui/tui-source.h (tui_set_source_content)
 162         (tui_show_symtab_source): Remove "noerror" parameter.
 163         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 164         parameter.
 165         (tui_show_symtab_source): Likewise.
 166         (tui_source_window::maybe_update): Update.
 167         * tui/tui-disasm.c (tui_show_disassem)
 168         (tui_show_disassem_and_update_source)
 169         (tui_disasm_window::do_scroll_vertical)
 170         (tui_disasm_window::maybe_update): Update.
 171
 172 2019-08-16  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui.c (tui_is_window_visible): Update.
 175         * tui/tui-wingeneral.c (tui_make_window)
 176         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 177         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 178         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 179         (tui_set_win_height_command, parse_scrolling_args): Update.
 180         * tui/tui-source.c (tui_source_window::style_changed): Update.
 181         * tui/tui-regs.c (tui_show_registers)
 182         (tui_data_window::first_data_item_displayed)
 183         (tui_data_window::delete_data_content_windows)
 184         (tui_check_register_values, tui_reg_command): Update.
 185         * tui/tui-disasm.c (tui_show_disassem): Update.
 186         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 187         method.
 188         <is_visible>: Remove field.
 189         * tui/tui-data.c (tui_next_win, tui_prev_win)
 190         (tui_delete_invisible_windows): Update.
 191
 192 2019-08-16  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-winsource.h (struct tui_source_window_base)
 195         <m_has_locator>: Remove.
 196         * tui/tui-layout.c (show_source_disasm_command, show_data)
 197         (show_source_or_disasm_and_command): Update.
 198
 199 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 200
 201         * NEWS (Other MI changes): New subsection.
 202         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 203         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 204         * arch-utils.c (default_get_pc_address_flags): New function.
 205         * arch-utils.h (default_get_pc_address_flags): New declaration.
 206         * gdbarch.sh: Add get_pc_address_flags.
 207         * gdbarch.c: Regenerate.
 208         * gdbarch.h: Likewise.
 209         * stack.c (print_pc): New function.
 210         (print_frame_info) (print_frame): Call print_pc.
 211
 212 2019-08-16  Tom de Vries  <tdevries@suse.de>
 213
 214         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 215         print_objfile_section_info.
 216
 217 2019-08-15  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 220         calling update_cmdwin_start_line.
 221         * tui/tui-winsource.h (struct tui_source_window_base)
 222         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 223         <rerender>: Declare.
 224         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 225         Call rerender.
 226         (tui_source_window_base::set_new_height): Remove.
 227         (tui_source_window_base::rerender): Rename from
 228         do_make_visible_with_new_height.
 229         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 230         resize method.
 231         (tui_win_info::make_invisible_and_set_new_height)
 232         (tui_win_info::make_visible_with_new_height): Remove.
 233         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 234         Declare.
 235         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 236         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 237         do_make_visible_with_new_height>: Don't declare.
 238         <rerender>: Declare.
 239         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 240         set_new_height.
 241         (tui_data_window::do_make_visible_with_new_height): Remove.
 242         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 243         call tui_show_locator_content.
 244         (tui_gen_win_info::resize): Call rerender.
 245         (show_source_or_disasm_and_command): Don't call
 246         tui_show_locator_content.
 247         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 248         method.
 249         (struct tui_win_info) <rerender>: Declare.
 250         <set_new_height, make_invisible_and_set_new_height,
 251         make_visible_with_new_height>: Don't declare.
 252         * tui/tui-data.c (tui_win_list::rerender): New method.
 253         * tui/tui-command.h (struct tui_cmd_window)
 254         <do_make_visible_with_new_height>: Don't declare.
 255         * tui/tui-command.c
 256         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 257
 258 2019-08-15  Tom Tromey  <tromey@adacore.com>
 259
 260         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 261         * ada-lang.c (ada_enum_name): Likewise.
 262
 263 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 264
 265         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 266         leading underscore.
 267         (GdbOutputErrorFile): Likewise.
 268         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 269         accordingly.
 270         (execute_unwinders): Rename to have a leading underscore.
 271         (auto_load_packages): Likewise.
 272         (global scope): Adjust call to auto_load_packages accordingly.
 273         (GdbSetPythonDirectory): Likewise.
 274         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 275         instead of execute_unwinders.
 276
 277 2019-08-15  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 280         (show_data): Don't change window visibility.
 281         (tui_gen_win_info::resize): Remove special case for command
 282         window.  Use wresize, when available.
 283         (show_source_or_disasm_and_command): Don't change window
 284         visibility.
 285         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 286         <make_visible>: New method.
 287         * tui/tui-command.c (tui_cmd_window::resize): New method.
 288
 289 2019-08-15  Tom Tromey  <tom@tromey.com>
 290
 291         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 292         (struct tui_source_windows): New.
 293         * tui/tui-winsource.c (tui_display_main): Update.
 294         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 295         (new_height_ok, parse_scrolling_args): Update.
 296         * tui/tui-layout.c (show_layout, show_data): Update.
 297         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 298         (tui_add_to_source_windows): Don't declare.
 299         * tui/tui-data.c (source_windows, tui_source_windows)
 300         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 301
 302 2019-08-15  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 305         Rename from reset.
 306         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 307         * tui/tui-layout.c (show_source_disasm_command, show_data):
 308         Update.
 309         (tui_gen_win_info::resize): Rename.
 310         (show_source_or_disasm_and_command): Update.
 311         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 312         reset.
 313
 314 2019-08-15  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 317         * tui/tui-interp.c (tui_interp::init): Don't call
 318         tui_initialize_static_data.
 319         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 320
 321 2019-08-15  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 324         examine tui_win_list.
 325
 326 2019-08-15  Tom Tromey  <tom@tromey.com>
 327
 328         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 329         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 330         tui_clear_source_content.
 331         (tui_clear_source_content): Remove.
 332         (tui_source_window_base::do_erase_source_content): Hoist call to
 333         content.clear().
 334         * tui/tui-stack.c (tui_show_frame_info): Don't call
 335         tui_clear_source_content.
 336
 337 2019-08-15  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.h (struct tui_source_window_base)
 340         <do_erase_source_content>: New method.
 341         <erase_source_content>: New method.
 342         (tui_erase_source_content): Don't declare.
 343         * tui/tui-winsource.c (tui_clear_source_content): Update.
 344         (tui_source_window_base::do_erase_source_content): Rename from
 345         tui_erase_source_content.
 346         (tui_source_window_base::show_source_content): Update.
 347         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 348         * tui/tui-source.h (struct tui_source_window)
 349         <erase_source_content>: New method.
 350         * tui/tui-disasm.h (struct tui_disasm_window)
 351         <erase_source_content>: New method.
 352
 353 2019-08-15  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 356         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 357         constructor.
 358         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 359         * tui/tui-source.c (tui_set_source_content): Update.
 360         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 361
 362 2019-08-15  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 365         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 366         tui-source.c.
 367         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 368         Declare.
 369         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 370         method.
 371         (tui_source_window::maybe_update): Update.
 372
 373 2019-08-15  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 376         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 377         tui-disasm.c.
 378         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 379         Declare.
 380         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 381         method.
 382         (tui_disasm_window::maybe_update): Update.
 383
 384 2019-08-15  Tom Tromey  <tom@tromey.com>
 385
 386         * tui/tui-winsource.h (struct tui_source_window_base)
 387         <maybe_update>: Declare.
 388         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 389         method.
 390         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 391         Declare.
 392         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 393         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 394         Declare.
 395         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 396
 397 2019-08-15  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 400
 401 2019-08-15  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-wingeneral.c: Include tui-stack.h.
 404         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 405         (struct tui_locator_window): Move from tui-data.h.
 406         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 407         (tui_initialize_static_data): Move from tui-data.c.
 408         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 409         (struct tui_locator_window): Move to tui-stack.c.
 410         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 411         (tui_initialize_static_data): Move to tui-stack.c.
 412
 413 2019-08-15  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-layout.c (show_source_disasm_command)
 416         (show_source_or_disasm_and_command): Use make_visible method, not
 417         tui_make_window.
 418         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 419         Remove.
 420
 421 2019-08-15  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-wingeneral.h (tui_make_window): Update.
 424         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 425         parameter.
 426         (tui_gen_win_info::make_visible): Update.
 427         * tui/tui-regs.c (tui_data_window::display_registers_from):
 428         Update.
 429         * tui/tui-layout.c (show_source_disasm_command)
 430         (show_source_or_disasm_and_command): Update.
 431         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 432         (enum tui_box): Remove.
 433         (struct tui_win_info) <can_box>: New method.
 434         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 435         method.
 436
 437 2019-08-15  Tom de Vries  <tdevries@suse.de>
 438
 439         * linux-nat-trad.c: Include gdbarch.h.
 440
 441 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 442
 443         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 444         register sizes.
 445
 446 2019-08-14  Tom Tromey  <tromey@adacore.com>
 447
 448         * darwin-nat.c: Include gdbarch.h.
 449         * darwin-nat-info.c: Include gdbarch.h.
 450
 451 2019-08-13  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 454         Remove.
 455         * tui/tui-data.c (tui_initialize_static_data): Update.
 456
 457 2019-08-13  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.h (struct tui_exec_info_window)
 460         <~tui_exec_info_window, maybe_allocate_content, get_content,
 461         m_content>: Remove.
 462         (struct tui_source_window_base) <set_exec_info_content,
 463         show_exec_info_content>: Don't declare.
 464         * tui/tui-winsource.c
 465         (tui_exec_info_window::maybe_allocate_content): Remove.
 466         (tui_source_window_base::update_exec_info): Rename from
 467         set_exec_info_content.
 468         (tui_source_window_base::show_exec_info_content)
 469         (tui_source_window_base::update_exec_info): Remove.
 470
 471 2019-08-13  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 474         declare.
 475         * tui/tui-winsource.c (tui_update_source_window_as_is)
 476         (tui_update_source_windows_with_addr, tui_erase_source_content):
 477         Update.
 478         (tui_clear_exec_info_content): Remove.
 479
 480 2019-08-13  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 483         declare.
 484         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 485         call tui_erase_exec_info_content.
 486         (tui_clear_exec_info_content): Rename from
 487         tui_erase_exec_info_content.
 488         (tui_clear_exec_info_content): Delete.
 489
 490 2019-08-13  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-winsource.h (struct tui_source_window_base)
 493         <show_exec_info_content>: Declare.
 494         (tui_show_exec_info_content): Don't declare.
 495         * tui/tui-winsource.c
 496         (tui_source_window_base::show_exec_info_content): Rename from
 497         tui_show_exec_info_content.
 498         (tui_source_window_base::update_exec_info): Update.
 499
 500 2019-08-13  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 503         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 504         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 505         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 506         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 507         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 508         ... here.
 509
 510 2019-08-13  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.h (struct tui_source_window_base)
 513         <update_exec_info>: Declare.
 514         (tui_update_exec_info): Don't declare.
 515         * tui/tui-winsource.c (tui_update_source_window_as_is)
 516         (tui_source_window_base::refresh_all)
 517         (tui_update_all_breakpoint_info): Update.
 518         (tui_source_window_base::update_exec_info): Rename from
 519         tui_update_exec_info.
 520         * tui/tui-stack.c (tui_show_frame_info): Update.
 521
 522 2019-08-13  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-winsource.h (struct tui_source_window_base)
 525         <set_exec_info_content>: Declare.
 526         (tui_set_exec_info_content): Don't declare.
 527         * tui/tui-winsource.c
 528         (tui_source_window_base::set_exec_info_content): Rename from
 529         tui_set_exec_info_content.
 530         (tui_update_exec_info): Update.
 531
 532 2019-08-13  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-winsource.h (struct tui_source_window_base)
 535         <show_source_content>: Declare.
 536         (tui_show_source_content): Don't declare.
 537         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 538         (tui_source_window_base::show_source_content): Rename from
 539         tui_show_source_content.
 540         (tui_source_window_base::refresh_all): Update.
 541         * tui/tui-layout.c (show_source_disasm_command)
 542         (show_source_or_disasm_and_command): Update.
 543
 544 2019-08-13  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-winsource.c (tui_erase_source_content)
 547         (tui_show_source_content, tui_source_window_base::refresh_all):
 548         Update.
 549         * tui/tui-wingeneral.h
 550         (tui_check_and_display_highlight_if_needed): Don't declare.
 551         * tui/tui-wingeneral.c
 552         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 553         check_and_display_highlight_if_needed.
 554         * tui/tui-win.c (tui_rehighlight_all)
 555         (tui_win_info::make_visible_with_new_height): Update.
 556         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 557         (tui_data_window::erase_data_content)
 558         (tui_data_window::display_all_data): Update.
 559         * tui/tui-data.h (struct tui_win_info)
 560         <check_and_display_highlight_if_needed>: Declare.
 561
 562 2019-08-13  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-win.c (tui_resize_all): Call
 565         tui_delete_invisible_windows.
 566         * tui/tui-layout.c (show_layout): Call
 567         tui_delete_invisible_windows.
 568         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 569         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 570
 571 2019-08-13  Tom Tromey  <tom@tromey.com>
 572
 573         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 574         tui_add_win_to_layout.
 575
 576 2019-08-13  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 579         * tui/tui-layout.c (tui_default_win_height): Now static.
 580
 581 2019-08-13  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 584         single switch.
 585         (show_source_disasm_command, show_source_or_disasm_and_command):
 586         Don't check current layout.
 587
 588 2019-08-13  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-wingeneral.c (make_all_visible): Remove.
 591         (tui_make_all_invisible): Simplify.
 592         * tui/tui-layout.c (tui_make_all_invisible): Move from
 593         tui-wingeneral.c; simplify.
 594         (show_layout): Hoist call to tui_make_all_invisible.
 595         (show_data): Don't call tui_make_all_invisible.
 596
 597 2019-08-13  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 600         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 601
 602 2019-08-13  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 605         tui-data.c.
 606         (show_source_disasm_command, show_data)
 607         (show_source_or_disasm_and_command): Don't use
 608         tui_set_current_layout_to.
 609         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 610         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 611         tui-layout.c.
 612         (tui_set_current_layout_to): Remove.
 613
 614 2019-08-13  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-layout.c (tui_set_layout): Update.
 617         * tui/tui-data.h (struct tui_layout_def): Remove.
 618         (tui_layout_def): Don't declare.
 619         * tui/tui-data.c (layout_def): Remove.
 620         (tui_layout_def): Remove.
 621
 622 2019-08-13  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.h (struct tui_source_window_base)
 625         <clear_detail>: No longer "override".
 626         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 627         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 628         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 629         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 630         Remove.
 631         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 632
 633 2019-08-13  Tom Tromey  <tromey@adacore.com>
 634
 635         * tracepoint.c: Don't include readline.h or history.h.
 636
 637 2019-08-12  Tom Tromey  <tom@tromey.com>
 638
 639         * configure: Rebuild.
 640         * configure.ac: Check for readline 7.
 641         * NEWS: Mention readline 7 requirement.
 642         * README: Update.
 643
 644 2019-08-12  Tom Tromey  <tom@tromey.com>
 645
 646         * mingw-hdep.c (gdb_select): Remove readline hack.
 647
 648 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 649
 650         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 651         when the function fails.
 652
 653 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 654
 655         * s390-tdep.c (s390_type_align): New function.
 656         (s390_gdbarch_init): Set it as type_align gdbarch method.
 657
 658 2019-08-09  Tom de Vries  <tdevries@suse.de>
 659
 660         PR gdb/24591
 661         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 662         pc_low with relocation offset.
 663
 664 2019-08-07  Tom Tromey  <tromey@adacore.com>
 665
 666         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 667         (print_frame_args): Update.
 668         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 669         Update.
 670         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 671         * frame.h (struct frame_arg): Add initializers.
 672         <error>: Now a unique_xmalloc_ptr.
 673
 674 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 675
 676         * NEWS: Expand the Pointer Authentication entry.
 677         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 678         (aarch64_frame_unmask_lr): ... to this.
 679         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 680         Call aarch64_frame_unmask_lr.
 681         * frame.c (struct frame_info): Add "masked" variable.
 682         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 683         (fprint_frame): Check for masked pc.
 684         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 685         declarations.
 686         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 687         * stack.c (print_frame): Check for masked pc.
 688
 689 2019-08-06  Tom Tromey  <tom@tromey.com>
 690
 691         * stabsread.c (patch_block_stabs, read_one_struct_field)
 692         (read_enum_type): Use obstack_strndup.
 693         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 694         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 695         * dwarf2read.c (guess_full_die_structure_name)
 696         (anonymous_struct_prefix): Use obstack_strndup.
 697         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 698         * c-exp.y (yylex): Use obstack_strndup.
 699         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 700         (write_var_or_type): Use obstack_strndup.
 701
 702 2019-08-06  Tom Tromey  <tom@tromey.com>
 703
 704         * symfile.c (reread_symbols): Use obstack_strdup.
 705         * stabsread.c (read_type): Use obstack_strdup.
 706         * gdb_obstack.h (obstack_strdup): New overload.
 707         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 708         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 709         (dwarf2_canonicalize_name): Use obstack_strdup.
 710         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 711         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 712         Use obstack_strdup.
 713
 714 2019-08-06  Tom Tromey  <tom@tromey.com>
 715
 716         * gdb_obstack.h (obstack_strdup): Define.
 717         * gdb_obstack.c (obstack_strdup): Don't define.
 718
 719 2019-08-06  Tom Tromey  <tom@tromey.com>
 720
 721         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 722         obstack_strdup.
 723         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 724         obstack_strdup.
 725         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 726         * stabsread.c (common_block_start): Use obstack_strdup.
 727         * objfiles.c (set_objfile_main_name, objfile): Use
 728         obstack_strdup.
 729         * namespace.c (add_using_directive): Use obstack_strdup.
 730         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 731         * jit.c (finalize_symtab): Use obstack_strdup.
 732         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 733         (guess_partial_die_structure_name, partial_die_info::fixup)
 734         (dwarf2_name): Use obstack_strdup.
 735         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 736         obstack_strdup.
 737         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 738         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 739         obstack_strdup.
 740         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 741
 742 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 743
 744         * unittests/help-doc-selftests.c: New file.
 745         * Makefile.in: Add the new file.
 746
 747 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 748
 749         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 750         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 751         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 752         the trailing '.' is not output, and the first character is uppercased.
 753         (print_help_for_command): Update call to print_doc_line.
 754         (print_doc_of_command): Likewise.
 755         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 756         * cli/cli-option.c (append_indented_doc): Do not append newline.
 757         (build_help_option): Append newline after first appended_indented_doc
 758         only if a second call is done.
 759         (build_help): Append 2 new lines before each option, except the first
 760         one.
 761         * compile/compile.c (_initialize_compile): Add new lines after
 762         %OPTIONS%, when not at the end of the help.
 763         Change help doc or code
 764         producing the help doc to respect the invariants.
 765         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 766         Also removed the new line after 'Options:', as all other commands
 767         do not put an empty line between 'Options:' and the first option.
 768         * printcmd.c (_initialize_printcmd): Likewise.
 769         * stack.c (_initialize_stack): Likewise.
 770         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 771         incorrectly telling COMMAND is optional.
 772         * ada-lang.c (_initialize_ada_language): Change help doc or code
 773         producing the help doc to respect the invariants.
 774         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 775         * breakpoint.c (_initialize_breakpoint): Likewise.
 776         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 777         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 778         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 779         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 780         _initialize_cli_style): Likewise.
 781         * corelow.c (core_target_info): Likewise.
 782         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 783         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 784         * filesystem.c (_initialize_filesystem): Likewise.
 785         * frame.c (_initialize_frame): Likewise.
 786         * gnu-nat.c (add_task_commands): Likewise.
 787         * infcall.c (_initialize_infcall): Likewise.
 788         * infcmd.c (_initialize_infcmd): Likewise.
 789         * interps.c (_initialize_interpreter): Likewise.
 790         * language.c (_initialize_language): Likewise.
 791         * linux-fork.c (_initialize_linux_fork): Likewise.
 792         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 793         * maint.c (_initialize_maint_cmds): Likewise.
 794         * memattr.c (_initialize_mem): Likewise.
 795         * printcmd.c (_initialize_printcmd): Likewise.
 796         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 797         _RegEx): Likewise.
 798         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 799         * record-btrace.c (_initialize_record_btrace): Likewise.
 800         * record-full.c (_initialize_record_full): Likewise.
 801         * record.c (_initialize_record): Likewise.
 802         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 803         * regcache.c (_initialize_regcache): Likewise.
 804         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 805         _initialize_remote): Likewise.
 806         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 807         * serial.c (_initialize_serial): Likewise.
 808         * skip.c (_initialize_step_skip): Likewise.
 809         * source.c (_initialize_source): Likewise.
 810         * stack.c (_initialize_stack): Likewise.
 811         * symfile.c (_initialize_symfile): Likewise.
 812         * symtab.c (_initialize_symtab): Likewise.
 813         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 814         * top.c (init_main): Likewise.
 815         * tracefile-tfile.c (tfile_target_info): Likewise.
 816         * tracepoint.c (_initialize_tracepoint): Likewise.
 817         * tui/tui-win.c (_initialize_tui_win): Likewise.
 818         * utils.c (add_internal_problem_command): Likewise.
 819         * valprint.c (value_print_option_defs): Likewise.
 820
 821 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 822
 823         PR build/24886
 824         * configure.ac: Drop enable-libmcheck support.
 825         * configure, config.in: Rebuild.
 826         * libmcheck.m4: Remove.
 827         * acinclude.m4: Don't include it.
 828         * Makefile.in: Don't distribute it.
 829         * top.c (print_gdb_configuration): Don't mention it.
 830
 831 2019-08-06  Tom Tromey  <tom@tromey.com>
 832
 833         * utils.c (set_output_style): Sometimes pass stream to
 834         emit_style_escape.
 835         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 836         * record-btrace.c (btrace_insn_history): Update.
 837         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 838         method.
 839         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 840         Update initializers.
 841         <m_uiout>: New field.
 842         <m_di>: Move lower.
 843         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 844         Remove "uiout" parameter.
 845         (dump_insns): Update.
 846         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 847         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 848
 849 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 852         (error_in_psymtab_expansion): Likewise.
 853         (lookup_symbol_via_quick_fns): Likewise.
 854         (basic_lookup_transparent_type_quick): Likewise.
 855         (basic_lookup_transparent_type_1): Likewise.
 856
 857 2019-08-06  Tom Tromey  <tromey@adacore.com>
 858
 859         * source.c (last_source_error): Now bool.
 860         (print_source_lines_base): Make "noprint" bool.  Only open
 861         source file when last_source_visited changes.
 862
 863 2019-08-06  Tom Tromey  <tromey@adacore.com>
 864
 865         * annotate.c (annotate_source_line): Use g_source_cache.
 866         * source-cache.c (source_cache::get_plain_source_lines): Change
 867         parameters.  Populate m_offset_cache.
 868         (source_cache::ensure): New method.
 869         (source_cache::get_line_charpos): New method.
 870         (extract_lines): Move lower.  Change parameters.
 871         (source_cache::get_source_lines): Move lower.
 872         * source-cache.h (class source_cache): Update comment.
 873         <get_line_charpos>: New method.
 874         <get_source_lines>: Update comment.
 875         <clear>: Clear m_offset_cache.
 876         <get_plain_source_lines>: Change parameters.
 877         <ensure>: New method
 878         <m_offset_cache>: New member.
 879         * source.c (forget_cached_source_info_for_objfile): Update.
 880         (info_source_command): Use g_source_cache.
 881         (find_source_lines, open_source_file_with_line_charpos): Remove.
 882         (print_source_lines_base, search_command_helper): Use g_source_cache.
 883         * source.h (open_source_file_with_line_charpos): Don't declare.
 884         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 885         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 886         Use g_source_cache.
 887
 888 2019-08-06  Tom Tromey  <tromey@adacore.com>
 889
 890         * source-cache.c (source_cache::get_plain_source_lines):
 891         Remove "first_line" and "last_line" parameters.
 892         (source_cache::get_source_lines): Cache plain text.
 893         * source-cache.h (class source_cache)
 894         <get_plain_source_lines>: Update.
 895
 896 2019-08-06  Tom Tromey  <tromey@adacore.com>
 897
 898         * source-cache.c (extract_lines): No longer a method.
 899         Changed type of parameter.  Include final newline.
 900         (selftests::extract_lines_test): New function.
 901         (_initialize_source_cache): Likewise.
 902         * source-cache.h (class source_cache)
 903         <extract_lines>: Don't declare.
 904
 905 2019-08-06  Tom Tromey  <tromey@adacore.com>
 906
 907         * breakpoint.c (init_breakpoint_sal): Update.
 908         (breakpoint): Update.
 909         * breakpoint.h (struct breakpoint) <filter>: Now a
 910         unique_xmalloc_ptr.
 911
 912 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 913
 914         * NEWS: Mention dictionary access on blocks.
 915         * python/py-block.c (blpy_getitem): New function.
 916         (block_object_as_mapping): New struct.
 917         (block_object_type): Use new struct for tp_as_mapping field.
 918
 919 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 920
 921         * objfiles.h (objfile): Add a comment describing partial symbols.
 922
 923 2019-08-05  Tom Tromey  <tromey@adacore.com>
 924
 925         * compile/compile.c (_initialize_compile): Use _(), not N_().
 926         * thread.c (_initialize_thread): Use _(), not N_().
 927         * stack.c (_initialize_stack): Use _(), not N_().
 928         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 929
 930 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 931
 932         * dwarf2read.c (struct dw2_symtab_iterator):
 933         <want_specific_block>: Remove.
 934         <block_index>: Change type to gdb::optional.
 935         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 936         change type of BLOCK_INDEX parameter to gdb::optional.
 937         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 938         (dw2_lookup_symbol): Don't pass argument for
 939         WANT_SPECIFIC_BLOCK.
 940         (dw2_expand_symtabs_for_function): Don't pass argument for
 941         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 942         (class dw2_debug_names_iterator)
 943         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 944         parameter, change BLOCK_INDEX type to gdb::optional.
 945         <m_want_specific_block>: Remove.
 946         <m_block_index>: Change type to gdb::optional.
 947         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 948         gdb::optional.  Re-write in function of gdb::optional.
 949         (dw2_debug_names_lookup_symbol): Don't pass argument for
 950         WANT_SPECIFIC_BLOCK.
 951         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 952         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 953         BLOCK_INDEX.
 954
 955 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 956
 957         * NEWS: Mention changes to "info sources" command.
 958
 959 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 960
 961         * symtab.c (filename_partial_match_opts): New struct type.
 962         (struct output_source_filename_data): New members
 963         regexp, c_regexp, partial_match.
 964         (output_source_filename): Use new members to decide to print file.
 965         (info_sources_option_defs): New variable.
 966         (make_info_sources_options_def_group, print_info_sources_header,
 967         info_sources_command_completer):
 968         New functions.
 969         (info_sources_command): Read new optional arguments.
 970         (_initialize_symtab): Update info sources help.
 971
 972 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 973
 974         * ada-lang.c (exception_support_info_v0): Renamed from...
 975         (default_exception_support_info): ... this.  Create new
 976         definition for v1.
 977         (ada_has_this_exception_support): Look up catch_handlers_sym.
 978         (ada_exception_support_info_sniffer): Try v0 after default.
 979
 980 2019-08-01  Tom Tromey  <tromey@adacore.com>
 981
 982         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 983         gdbarch.h.
 984
 985 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 986
 987         * s12z-tdep.c: Fix include path for s12z-opc.h.
 988
 989 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 990
 991         * NEWS: Require GNU make 3.82.
 992
 993 2019-07-16  Tom Tromey  <tom@tromey.com>
 994
 995         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 996         declare.
 997
 998 2019-07-30  Tom Tromey  <tromey@adacore.com>
 999
1000         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1001
1002 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1003
1004         * printcmd.c (print_address_symbolic): Print negative offsets.
1005         (build_address_symbolic): Force signed arithmetic when computing
1006         offset.
1007
1008 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1009
1010         PR/24474: Add a function to lookup static variables.
1011         * NEWS: Mention this new function.
1012         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1013         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1014         * python/python.c (python_GdbMethods): Add new function.
1015
1016 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1017
1018         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1019         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1020         (objfpy_lookup_static_symbol): New function.
1021         (objfile_object_methods): Add new functions.
1022
1023 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1024
1025         * NEWS: Mention 'set|show print frame-info'.  Mention new
1026         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1027         backtrace argument.  Mention that python frame filtering code
1028         is now consistent with what 'backtrace' command prints.
1029
1030 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1031
1032         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1033         comments.
1034         (print_frame_info_auto, print_frame_info_source_line,
1035         print_frame_info_location, print_frame_info_source_and_location,
1036         print_frame_info_location_and_address, print_frame_info_short_location):
1037         New declarations.
1038         (struct frame_print_options): New member print_frame_info.
1039         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1040         * stack.h (get_user_print_what_frame_info): New declaration.
1041         (frame_show_address): New declaration.
1042         * stack.c (print_frame_arguments_choices): New value 'presence'.
1043         (print_frame_info_auto, print_frame_info_source_line,
1044         print_frame_info_location, print_frame_info_source_and_location,
1045         print_frame_info_location_and_address, print_frame_info_short_location,
1046         print_frame_info_choices, print_frame_info_print_what): New definitions.
1047         (print_frame_args): Only print dots for args if print frame-arguments
1048         is 'presence'.
1049         (frame_print_option_defs): New element for "frame-info".
1050         (get_user_print_what_frame_info): New function.
1051         (frame_show_address): Make non static.  Move comment to stack.h.
1052         (print_frame_info_to_print_what): New function.
1053         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1054         to decide what to print.
1055         (backtrace_command_1): Handle the new print_frame_arguments_presence
1056         value.
1057         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1058         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1059         (py_print_frame): In non-mi mode, use LOCATION as default for
1060         print_what, similarly to frame information printed directly by
1061         backtrace command. Handle frame-info user option in non MI mode.
1062
1063 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1064
1065         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1066         Add case for debugging 32-bit target on 64-bit host.  Revise
1067         comment.
1068
1069 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1070
1071         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1072         instead of find_function_entry_range_from_pc.
1073
1074 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1075
1076         * stack.c (find_frame_funname): Remove code which preferred
1077         minsym over symtab sym in "certain pathological cases".
1078
1079         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1080         parameter.  Change type of "do_demangle" to bool.
1081         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1082         Pass suitable "prefer_sym_over_minsym" flag to
1083         build_address_symbolic().  Don't output "+" for negative offsets.
1084         * printcmd.c (print_address_symbolic): Update invocation of
1085         build_address_symbolic to include a "prefer_sym_over_minsym"
1086         flag.
1087         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1088         Restrict cases in which use of minimal symbol is preferred to that
1089         of a found symbol.  Update comments.
1090
1091         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1092         for entry pc when entry pc is out of range for that FDE.
1093
1094 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1095
1096         PR gdb/24839:
1097         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1098         type.
1099
1100 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1101
1102         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1103         this function's Python signature.
1104
1105
1106 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1107
1108         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1109         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1110         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1111         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1112         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1113
1114
1115 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1116
1117         * h8300-tdep.c (h8300_register_name_common): New.
1118         h8300_register_name): Use h8300_register_name_common.
1119         (h8300s_register_name): Likewise.
1120         (h8300sx_register_name): Likewise.
1121         (h8300h_register_nam): New.
1122         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1123
1124
1125 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1126
1127         * arm-tdep.c (arm_skip_cmse_entry): New function.
1128         (arm_is_sgstubs_section): New function.
1129         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1130
1131 2019-07-22  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1134         Don't self-assign.
1135
1136 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1139         type_print.
1140
1141 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1144         so that GDB doesn't match any msymbols when searching in the
1145         TYPES_DOMAIN.
1146         (print_symbol_info): Print using typedef_print or type_print based
1147         on the type of the symbol.  Add updated FIXME comment moved from...
1148         (_initialize_symtab): ... move and update FIXME comment to above.
1149
1150 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * NEWS: Mention adding -q option to "info types".
1153         * symtab.c (struct info_types_options): New struct.
1154         (info_types_options_defs): New variable.
1155         (make_info_types_options_def_group): New function.
1156         (info_types_command): Use gdb::option framework to parse options.
1157         (info_types_command_completer): New function.
1158         (_initialize_symtab): Extend the help text on "info types" and
1159         register command completer.
1160
1161 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1162
1163         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1164         (lookup_symbol_in_objfile): Change int to block_enum and add a
1165         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1166
1167 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1168
1169         * MAINTAINERS (Write After Approval): Add self.
1170
1171 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1174         instruction to the dummy code region.
1175
1176 2019-07-19  Tom Tromey  <tromey@adacore.com>
1177
1178         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1179         (ARGSUSED, PARAMS, __func__): Remove rules.
1180
1181 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1182
1183         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1184         * features/arm/arm-with-iwmmxt.c: Remove.
1185         * features/arm/arm-with-iwmmxt.xml: Remove.
1186         * features/arm/arm-with-m-fpa-layout.c: Remove.
1187         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1188         * features/arm/arm-with-m-vfp-d16.c: Remove.
1189         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1190         * features/arm/arm-with-m.c: Remove.
1191         * features/arm/arm-with-m.xml: Remove.
1192         * features/arm/arm-with-neon.c: Remove.
1193         * features/arm/arm-with-neon.xml: Remove.
1194         * features/arm/arm-with-vfpv2.c: Remove.
1195         * features/arm/arm-with-vfpv2.xml: Remove.
1196         * features/arm/arm-with-vfpv3.c: Remove.
1197         * features/arm/arm-with-vfpv3.xml: Remove.
1198
1199 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1200
1201         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1202
1203 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1204
1205         * arch/aarch32.c (aarch32_create_target_description): Create
1206         target descriptions using features.
1207         * arch/arm.c (arm_create_target_description)
1208         (arm_create_mprofile_target_description): Likewise.
1209         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1210
1211 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1212
1213         * Makefile.in: Add new files.
1214         * aarch32-tdep.c: New file.
1215         * aarch32-tdep.h: New file.
1216         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1217         Call aarch32_read_description.
1218         * arch/aarch32.c: New file.
1219         * arch/aarch32.h: New file.
1220         * arch/arm.c (arm_create_target_description)
1221         (arm_create_mprofile_target_description): New function.
1222         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1223         (arm_create_target_description)
1224         (arm_create_mprofile_target_description): New declaration.
1225         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1226         read_description functions.
1227         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1228         Likewise.
1229         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1230         * arm-tdep.c (tdesc_arm_list): New variable.
1231         (arm_register_g_packet_guesses): Call create description functions.
1232         (arm_read_description) (arm_read_mprofile_description): New
1233         function.
1234         * arm-tdep.h (arm_read_description)
1235         (arm_read_mprofile_description): Add declaration.
1236         * configure.tgt: Add new files.
1237
1238 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1239
1240         * top.c (new_ui_command): Open specified terminal just once.
1241
1242 2019-07-18  Tom Tromey  <tromey@adacore.com>
1243
1244         * symtab.c (main_name): Constify return type.
1245         * symfile.c (set_initial_language): Update.
1246         * symtab.h (main_name): Constify return type.
1247
1248 2019-07-17  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-winsource.c (tui_update_source_window)
1251         (tui_update_source_window_as_is)
1252         (tui_update_source_windows_with_line): Remove return.
1253         * tui/tui-disasm.c (tui_show_disassem)
1254         (tui_show_disassem_and_update_source): Remove return.
1255         * tui/tui.c (tui_reset): Remove return.
1256         * tui/tui-wingeneral.c
1257         (tui_check_and_display_highlight_if_needed): Remove return.
1258
1259 2019-07-17  Tom Tromey  <tom@tromey.com>
1260
1261         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1262
1263 2019-07-17  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-winsource.h (struct tui_exec_info_window)
1266         (struct tui_source_window_base): Move from tui-data.h.
1267         * tui/tui-winsource.c: Move many method definitions from
1268         elsewhere.  Remove "structuring" comments.
1269         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1270         (tui_source_window_base::refresh_window): Move to
1271         tui-winsource.c.
1272         * tui/tui-win.c (tui_source_window_base::refresh_all)
1273         (tui_source_window_base::update_tab_width)
1274         (tui_source_window_base::set_new_height)
1275         (tui_source_window_base::do_make_visible_with_new_height): Move to
1276         tui-winsource.c.
1277         * tui/tui-source.h: Update.
1278         * tui/tui-source.c (tui_source_window_base::reset): Move to
1279         tui-winsource.c.
1280         * tui/tui-disasm.h: Update.
1281         * tui/tui-data.h (struct tui_exec_info_window): Move to
1282         tui-winsource.h.
1283         (struct tui_source_window_base): Likewise.
1284         * tui/tui-data.c (tui_source_window_base::clear_detail)
1285         (tui_source_window_base, ~tui_source_window_base): Move to
1286         tui-winsource.c.
1287
1288 2019-07-17  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-win.c (tui_resize_all)
1291         (tui_source_window_base::update_tab_width)
1292         (tui_adjust_win_heights): Update.
1293         (tui_win_info::make_invisible_and_set_new_height): Rename from
1294         make_invisible_and_set_new_height.
1295         * tui/tui-data.h (struct tui_win_info)
1296         <make_invisible_and_set_new_height>: New method.
1297
1298 2019-07-17  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui.c: Update.
1301         * tui/tui-source.h (struct tui_source_window): Move from
1302         tui-data.h.
1303         * tui/tui-layout.c: Update.
1304         * tui/tui-disasm.c: Update.
1305         * tui/tui-data.h (struct tui_source_window): Move to
1306         tui-source.h.
1307
1308 2019-07-17  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1311         tui-data.h.
1312         * tui/tui-data.h (struct tui_disasm_window): Move to
1313         tui-disasm.h.
1314
1315 2019-07-17  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-regs.h (struct tui_data_item_window): Move from
1318         tui-data.h.
1319         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1320         * tui/tui-data.h (struct tui_data_item_window): Move to
1321         tui-regs.h.
1322         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1323
1324 2019-07-17  Tom Tromey  <tom@tromey.com>
1325
1326         * tui/tui.c: Update.
1327         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1328         (tui_cmd_window::max_height): Move to tui-command.c.
1329         * tui/tui-layout.c: Update.
1330         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1331         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1332         tui-command.c.
1333         * tui/tui-command.h (struct tui_cmd_window): Move from
1334         tui-data.h.
1335         * tui/tui-command.c: Remove "structuring" comments.
1336         (tui_cmd_window::clear_detail)
1337         (tui_cmd_window::do_make_visible_with_new_height)
1338         (tui_cmd_window::max_height): Move from elsewhere.
1339
1340 2019-07-17  Tom Tromey  <tom@tromey.com>
1341
1342         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1343         Now static.
1344         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1345         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1346
1347 2019-07-17  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui.c: Update.
1350         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1351         tui-regs.c.
1352         * tui/tui-windata.h: Remove file.
1353         * tui/tui-windata.c: Remove file.
1354         * tui/tui-win.c (tui_data_window::set_new_height)
1355         (tui_data_window::do_make_visible_with_new_height): Move to
1356         tui-regs.c.
1357         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1358         * tui/tui-regs.c: Remove "structuring" comments.
1359         (tui_data_window::first_data_item_displayed)
1360         (tui_data_window::delete_data_content_windows)
1361         (tui_data_window::erase_data_content)
1362         (tui_data_window::display_all_data)
1363         (tui_data_window::refresh_all)
1364         (tui_data_window::do_scroll_vertical)
1365         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1366         (tui_data_window::do_make_visible_with_new_height)
1367         (tui_data_window::refresh_window): Move from elsewhere.
1368         (_initialize_tui_regs): Move to end of file.
1369         * tui/tui-layout.c: Update.
1370         * tui/tui-hooks.c: Update.
1371         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1372         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1373         tui-regs.c.
1374         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1375
1376 2019-07-17  Tom Tromey  <tom@tromey.com>
1377
1378         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1379         seen.
1380
1381 2019-07-17  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-win.c (tui_source_window_base::set_new_height)
1384         (tui_source_window_base::do_make_visible_with_new_height): Use
1385         m_has_locator field directly.
1386         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1387         method.
1388         (struct tui_source_window_base) <has_locator>: Likewise.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1393         Don't declare.
1394         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1395         Remove.
1396         * tui/tui-win.c (tui_source_window_base::set_new_height)
1397         (tui_source_window_base::set_new_height)
1398         (make_invisible_and_set_new_height)
1399         (tui_source_window_base::do_make_visible_with_new_height)
1400         (tui_source_window_base::do_make_visible_with_new_height):
1401         Update.
1402         * tui/tui-layout.c (show_source_disasm_command, show_data)
1403         (show_source_or_disasm_and_command): Update.
1404         * tui/tui-layout.c (show_layout): Update.
1405
1406 2019-07-17  Tom Tromey  <tom@tromey.com>
1407
1408         * tui/tui-layout.c (make_data_window): Remove.
1409         (show_data): Unify creation and re-initialization cases.
1410
1411 2019-07-17  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-layout.c (make_source_window, make_disasm_window):
1414         Remove.
1415         (show_data): Unify creation and re-initialization cases.
1416
1417 2019-07-17  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-layout.c (make_command_window): Remove.
1420         (show_source_disasm_command, show_source_or_disasm_and_command):
1421         Unify creation and re-initialization cases.
1422
1423 2019-07-17  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1426         creation and re-initialization cases.
1427
1428 2019-07-17  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-regs.c (tui_get_register): Return void.
1431
1432 2019-07-17  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1435         Simplify.
1436
1437 2019-07-17  Tom Tromey  <tom@tromey.com>
1438
1439         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1440         resetting.
1441
1442 2019-07-17  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1445         * tui/tui-regs.c (tui_reg_layout): New function.
1446         (tui_show_registers, tui_reg_command): Use it.
1447         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1448         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1449         parameters.
1450         (tui_layout_command): Remove.
1451
1452 2019-07-17  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-layout.h (tui/tui-layout): Return void.
1455         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1456
1457 2019-07-17  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-layout.c (show_source_disasm_command, show_data):
1460         Update.
1461         (reset_locator): Remove.
1462         (show_source_or_disasm_and_command): Update.
1463
1464 2019-07-17  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-source.c (tui_source_window_base::reset): Remove
1467         win_type parameter.
1468         * tui/tui-layout.c (make_command_window, make_source_window)
1469         (make_disasm_window, make_data_window)
1470         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1471         (reset_locator, show_source_or_disasm_and_command): Update.
1472         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1473         win_type parameter.
1474         (struct tui_source_window_base) <reset>: Likewise.
1475
1476 2019-07-17  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-layout.c (show_source_disasm_command): Use
1479         reset_locator.
1480         (reset_locator): New function.
1481         (init_and_make_win): Remove.
1482         (show_source_or_disasm_and_command): Use reset_locator.
1483
1484 2019-07-17  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1487         condition.
1488         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1489         Remove condition.
1490         * tui/tui-source.c (tui_source_window_base::reset): New method.
1491         * tui/tui-layout.c (make_command_window): Don't call
1492         init_and_make_win.
1493         (make_source_window, make_disasm_window): Don't call
1494         make_source_or_disasm_window.
1495         (make_data_window): Don't call init_and_make_win.  Change calling
1496         convention.
1497         (show_source_disasm_command, show_data): Simplify.
1498         (make_source_or_disasm_window): Remove.
1499         (show_source_or_disasm_and_command): Simplify.
1500         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1501         (struct tui_source_window_base) <reset>: Likewise.
1502         <execution_info>: Remove initializer.
1503         * tui/tui-data.c (tui_source_window_base): Initialize
1504         execution_info.
1505
1506 2019-07-17  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1509         variable.
1510
1511 2019-07-17  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui.c (tui_rl_other_window): Update.
1514         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1515         superclass method first.  Always iterate over regs_content.
1516         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1517         method.
1518         * tui/tui-win.c (tui_set_focus_command): Update.
1519
1520 2019-07-17  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-win.c (tui_set_focus_command): Rename from
1523         tui_set_focus.  Call tui_enable.
1524         (tui_set_focus_command): Remove.
1525
1526 2019-07-17  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1529         refresh_window.
1530         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1531         touchwin.
1532         (tui_data_window::refresh_window): Call refresh_window on data
1533         items.  Always call superclass refresh_window.
1534         (tui_win_info::refresh): Remove.
1535         (tui_source_window_base::refresh_window): Update.
1536         (tui_refresh_all): Update.
1537         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1538         refresh_window.
1539         (show_source_or_disasm_and_command): Likewise.
1540         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1541         (struct tui_source_window_base) <refresh>: Likewise.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-winsource.c (tui_clear_source_content)
1546         (tui_show_source_content): Update.
1547         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1548         whether content is empty.
1549         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1550         Remove.
1551
1552 2019-07-17  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1555         window's contents.
1556         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1557         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1558
1559 2019-07-17  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1562         (struct tui_data_item_window): Update.
1563
1564 2019-07-17  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1567         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1568         defines.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-winsource.h (tui_erase_source_content)
1573         (tui_clear_source_content): Remove "display_prompt" parameter.
1574         * tui/tui-winsource.c (tui_update_source_window_as_is)
1575         (tui_update_source_windows_with_addr): Update.
1576         (tui_clear_source_content): Remove "display_prompt" parameter.
1577         (tui_erase_source_content): Likewise.  Simplify.
1578         (tui_show_source_content): Update.
1579         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1580         * tui/tui-stack.c (tui_show_frame_info): Update.
1581         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1582         Remove defines.
1583
1584 2019-07-17  Tom Tromey  <tom@tromey.com>
1585
1586         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1587         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1588         parameter.
1589         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1590         parameter.
1591
1592 2019-07-17  Tom Tromey  <tom@tromey.com>
1593
1594         * tui/tui-winsource.c (tui_clear_source_content)
1595         (tui_show_source_content, tui_show_exec_info_content)
1596         (tui_clear_exec_info_content): Update.
1597         * tui/tui-stack.c (tui_show_locator_content): Update.
1598         (tui_show_frame_info): Update.
1599         * tui/tui-source.h (tui_source_window): Don't declare.
1600         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1601         from tui_source_is_displayed.
1602         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1603         Remove field.
1604         (struct tui_source_window_base) <content_in_use>: New field.  Now
1605         bool.
1606         (struct tui_source_window) <showing_source_p>: New method.
1607         (TUI_SRC_WIN): Change cast.
1608         * tui/tui-data.c (tui_initialize_static_data): Update.
1609
1610 2019-07-17  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1613         location_matches_p.
1614         * tui/tui-source.c (tui_source_window::location_matches_p): New
1615         method.
1616         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1617         method.
1618         * tui/tui-data.h (struct tui_source_window_base)
1619         <location_matches_p>: New method.
1620         (struct tui_source_window, struct tui_disasm_window)
1621         <location_matches_p>: Likewise.
1622
1623 2019-07-17  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-win.c (tui_set_win_height_command): Rename from
1626         tui_set_win_height.
1627         (tui_set_win_height_command): Remove.
1628
1629 2019-07-17  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-source.c (tui_source_window): New constructor.  Add
1632         observer.
1633         (~tui_source_window): New destructor.
1634         (tui_source_window::style_changed): New method.
1635         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1636         (tui_attach_detach_observers): Update.
1637         * tui/tui-data.h (struct tui_source_window): Make constructor not
1638         inline.  Add destructor.
1639         (struct tui_source_window) <style_changed>: New method.
1640         <m_observable>: New member.
1641
1642 2019-07-17  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1645         * tui/tui-win.c (tui_resize_all): Fix typo.
1646
1647 2019-07-17  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1650         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1651         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1652         * tui/tui-win.c (window_name_completer): Use foreach.
1653         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1654         (update_tab_width): Likewise.
1655         * tui/tui-layout.c (show_layout): Update.
1656         * tui/tui-data.h (class tui_window_iterator): New.
1657         (struct all_tui_windows): New.
1658         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1663         parameter.  Don't reference globals.
1664         (tui_reg_command): Update.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-regs.c (tui_show_registers): Simplify.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-regs.c (tui_show_registers): Update.
1673         (tui_show_register_group): Add win_info parameter.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1678         Rename from tui_display_reg_element_at_line.
1679         (tui_data_window::display_registers_from_line): Update.
1680         * tui/tui-data.h (struct tui_data_window)
1681         <display_reg_element_at_line>: New method.
1682
1683 2019-07-17  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-regs.h (tui_display_registers_from)
1686         (tui_display_registers_from_line): Don't declare.
1687         * tui/tui-windata.c (tui_data_window::display_all_data)
1688         (tui_data_window::refresh_all)
1689         (tui_data_window::do_scroll_vertical): Update.
1690         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1691         from tui_display_registers_from.
1692         (tui_display_reg_element_at_line): Update.
1693         (tui_data_window::display_registers_from_line): Rename from
1694         tui_display_registers_from_line.
1695         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1696         display_registers_from_line>: New methods.
1697
1698 2019-07-17  Tom Tromey  <tom@tromey.com>
1699
1700         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1701         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1702         from tui_erase_data_content.
1703         (tui_data_window::display_all_data)
1704         (tui_data_window::refresh_all)
1705         (tui_data_window::do_scroll_vertical): Update.
1706         * tui/tui-regs.c (tui_show_registers): Update.
1707         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1708         New method.
1709
1710 2019-07-17  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1713         declare.
1714         * tui/tui-windata.c
1715         (tui_data_window::delete_data_content_windows): Rename from
1716         tui_delete_data_content_windows.
1717         (tui_data_window::display_all_data)
1718         (tui_data_window::do_scroll_vertical): Update.
1719         * tui/tui-data.h (struct tui_data_window)
1720         <delete_data_content_windows>: New method.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1725         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1726
1727 2019-07-17  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1730         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1731         from tui_display_all_data.
1732         * tui/tui-win.c
1733         (tui_data_window::do_make_visible_with_new_height): Update.
1734         * tui/tui-regs.c (tui_show_registers): Update.
1735         * tui/tui-layout.c (tui_set_layout): Update.
1736         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1737         method.
1738
1739 2019-07-17  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1742         * tui/tui-windata.c (tui_display_data_from): Remove.
1743         (tui_data_window::refresh_all): Update.
1744
1745 2019-07-17  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1748         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1749         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1750         tui_display_registers_from_line.
1751         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1752         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1753         "force_display" parameter.
1754
1755 2019-07-17  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1758         declare.
1759         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1760         Rename from tui_first_reg_element_no_inline.
1761         (tui_display_reg_element_at_line)
1762         (tui_display_registers_from_line): Update.
1763         * tui/tui-data.h (struct tui_data_window)
1764         <first_reg_element_no_inline>: New method.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-windata.c (tui_display_data_from)
1769         (tui_data_window::do_scroll_vertical): Update.
1770         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1771         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1772         Rename from tui_line_from_reg_element_no.
1773         (tui_display_registers_from_line): Update.
1774         * tui/tui-data.h (struct tui_data_window)
1775         <line_from_reg_element_no>: New method.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1780         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1781         tui_last_regs_line_no.
1782         (tui_display_reg_element_at_line)
1783         (tui_display_registers_from_line): Update.
1784         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1785         method.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         PR tui/24722:
1790         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1791         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1792         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1793         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1794         (tui_update_breakpoint_info): Likewise.
1795         * tui/tui-hooks.c (tui_event_create_breakpoint)
1796         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1797         Update.
1798
1799 2019-07-17  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-winsource.c (tui_update_source_window_as_is)
1806         (tui_update_source_windows_with_addr): Update.
1807         * tui/tui-source.h (tui_set_source_content)
1808         (tui_show_symtab_source): Add "win_info" parameter.
1809         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1810         parameter.
1811         (tui_show_symtab_source): Likewise.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-wingeneral.c
1816         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1817
1818 2019-07-17  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1821         (struct tui_cmd_window) <can_scroll>: New method.
1822         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1823         method.
1824
1825 2019-07-17  Tom Tromey  <tromey@adacore.com>
1826
1827         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1828         do_field_signed>: Rename.  Change type of "value".
1829         * ui-out.c (ui_out::field_signed): Rename from field_int.
1830         Change type of "value".
1831         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1832         type of "value".
1833         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1834         do_field_int.  Change type of "value".
1835         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1836         do_field_int.  Change type of "value".
1837         * tracepoint.c (trace_status_mi, tfind_1)
1838         (print_one_static_tracepoint_marker): Update.
1839         * thread.c (print_thread_info_1, print_selected_thread_frame):
1840         Update.
1841         * stack.c (print_frame, print_frame_info): Update.
1842         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1843         Update.
1844         * source.c (print_source_lines_base): Update.
1845         * skip.c (info_skip_command): Update.
1846         * record-btrace.c (btrace_ui_out_decode_error)
1847         (btrace_call_history_src_line): Update.
1848         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1849         Update.
1850         * progspace.c (print_program_space): Update.
1851         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1852         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1853         do_field_int.  Change type of "value".
1854         * mi/mi-out.c (mi_ui_out::do_table_begin)
1855         (mi_ui_out::do_table_header): Update.
1856         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1857         type of "value".
1858         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1859         (mi_cmd_data_list_changed_registers, output_register)
1860         (mi_cmd_data_read_memory, mi_load_progress)
1861         (mi_cmd_trace_frame_collected): Update.
1862         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1863         Update.
1864         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1865         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1866         (mi_cmd_var_list_children, varobj_update_one): Update.
1867         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1868         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1869         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1870         * inferior.c (print_inferior): Update.
1871         * gdb_bfd.c (print_one_bfd): Update.
1872         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1873         Update.
1874         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1875         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1876         do_field_int.  Change type of "value".
1877         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1878         do_field_int.  Change type of "value".
1879         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1880         (print_one_breakpoint_location, print_it_catch_fork)
1881         (print_one_catch_fork, print_it_catch_vfork)
1882         (print_one_catch_vfork, print_it_catch_solib)
1883         (print_it_catch_exec, print_it_ranged_breakpoint)
1884         (print_mention_watchpoint, print_mention_masked_watchpoint)
1885         (bkpt_print_it, update_static_tracepoint): Update.
1886         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1887         * break-catch-syscall.c (print_it_catch_syscall): Update.
1888         * ada-tasks.c (print_ada_task_info): Update.
1889         * ada-lang.c (print_it_exception, print_mention_exception):
1890         Update.
1891
1892 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         PR breakpoints/24541
1895         * gdbarch.c: Regenerate.
1896         * gdbarch.h: Regenerate.
1897         * gdbarch.sh: Adjust return type and parameter types for
1898         'stap_adjust_register'.
1899         (i386_stap_adjust_register): Adjust signature and return new
1900         register name.
1901         * stap-probe.c (stap_parse_register_operand): Adjust use of
1902         'gdbarch_stap_adjust_register'.
1903
1904 2019-07-17  Tom Tromey  <tromey@adacore.com>
1905
1906         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1907         declare VEC.
1908         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1909         std::vector.
1910         (struct s390_process_info): Add initializers.
1911         (s390_add_process): Use new.
1912         (s390_linux_nat_target::low_forget_process): Use delete.
1913         (s390_linux_nat_target::low_new_fork)
1914         (s390_linux_nat_target::stopped_by_watchpoint)
1915         (s390_linux_nat_target::low_prepare_to_resume)
1916         (s390_linux_nat_target::insert_watchpoint)
1917         (s390_linux_nat_target::insert_hw_breakpoint)
1918         (s390_linux_nat_target::remove_watchpoint)
1919         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1920
1921 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1922
1923         * aarch64-fbsd-nat.c: Include regcache.h.
1924         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1925         argument.
1926         (aarch64_fbsd_nat_target::fetch_registers)
1927         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1928         variable.
1929         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1930
1931 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1932
1933         * fbsd-nat.c: Include gdbarch.h.
1934
1935 2019-07-15  Tom Tromey  <tromey@adacore.com>
1936
1937         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1938
1939 2019-07-15  Tom Tromey  <tromey@adacore.com>
1940
1941         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1942         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1943         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1944         * cli-out.c (cli_ui_out::do_field_int): New method.
1945         * ui-out.c (ui_out::field_unsigned): New method.
1946         * symfile.c (generic_load): Use field_unsigned.
1947         (print_transfer_performance): Likewise.
1948         * record-btrace.c (ui_out_field_uint): Remove.
1949         (btrace_call_history_insn_range, btrace_call_history): Use
1950         field_unsigned.
1951         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1952         field_unsigned.
1953         * ui-out.h (class ui_out) <field_unsigned>: New method.
1954         <do_field_unsigned>: Likewise.
1955
1956 2019-07-15  Tom Tromey  <tromey@adacore.com>
1957
1958         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1959         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1960         * target.c (flash_erase_command): Use field_string.
1961         * infrun.c (print_signal_received_reason): Use field_string.
1962         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1963         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1964         field_string.
1965         * ada-tasks.c (print_ada_task_info): Use field_string.
1966
1967 2019-07-15  Tom Tromey  <tromey@adacore.com>
1968
1969         * target.c (flash_erase_command): Use field_core_addr.
1970         * symfile.c (generic_load): Use field_core_addr.
1971         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1972         Use field_core_addr.
1973         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1974         field_core_addr.
1975
1976 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1977
1978         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1979         value if its desired type is smaller than a CORE_ADDR and signed.
1980
1981 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1984         of changes to field names, and use new is_reference field to
1985         decide if a property is a reference or not.
1986         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1987         field.
1988         (struct dwarf2_property_baton): Update header comment, rename
1989         'referenced_type' to 'property_type' and update comments.
1990         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1991         default property type, store in property baton, update to take
1992         accound of renamed field.
1993         (read_func_scope): Update call to attr_to_dynamic_prop.
1994         (read_array_type): Likewise.
1995         (dwarf2_per_cu_addr_sized_int_type): New function.
1996         (read_subrange_index_type): Move type finding code to
1997         dwarf2_per_cu_addr_sized_int_type.
1998         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1999         (dwarf2_per_cu_addr_type): New function.
2000         (set_die_type): Update calls to attr_to_dynamic_prop.
2001
2002 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * dwarf2read.c (read_subrange_index_type): New function.
2005         (read_subrange_type): Move code into new function and call it.
2006         * gdbtypes.c (create_range_type): Add some asserts.
2007
2008 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2009
2010         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2011         update return statements.
2012         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2013         declaration, and update comment to match.
2014         * gdbtypes.c (resolve_dynamic_array): Update call to
2015         dwarf2_evaluate_property to match new return type.
2016
2017 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * valarith.c (value_subscripted_rvalue): Change lowerbound
2020         parameter type from int to LONGEST.
2021         * value.h (value_subscripted_rvalue): Likewise in declaration.
2022
2023 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * cli/cli-utils.c (info_print_command_completer): New function.
2026         * cli/cli-utils.h: Add 'completer.h' include, and forward
2027         declaration for 'struct cmd_list_element'.
2028         (info_print_command_completer): Declare.
2029         * stack.c (_initialize_stack): Add completer for 'info locals' and
2030         'info args'.
2031         * symtab.c (_initialize_symtab): Add completer for 'info
2032         variables' and 'info functions'.
2033         * NEWS: Mention completion for additional info commands.
2034
2035 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2036
2037         * cli/cli-utils.c (extract_info_print_args): Delete.
2038         (extract_arg_maybe_quoted): Delete.
2039         (info_print_options_defs): New variable.
2040         (make_info_print_options_def_group): New function.
2041         (extract_info_print_options): Define new function.
2042         * cli/cli-utils.h (extract_info_print_args): Delete.
2043         (struct info_print_options): New structure.
2044         (extract_info_print_options): Declare new function.
2045         * stack.c (info_locals_command): Update to use new
2046         extract_info_print_options, also add a header comment.
2047         (info_args_command): Likewise.
2048         * symtab.c (info_variables_command): Likewise.
2049         (info_functions_command): Likewise.
2050
2051 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2052
2053         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2054         to extract string arguments.
2055         * common/common-utils.c (extract_string_maybe_quoted): New function.
2056         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2057
2058 2019-07-11  Tom Tromey  <tromey@adacore.com>
2059
2060         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2061         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2062         * top.h (gdbinit): Don't declare.
2063         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2064         into...
2065         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2066         * top.c (gdb_init): Don't call init_cli_cmds.
2067         (gdbinit): Remove.
2068         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2069
2070 2019-07-11  Tom Tromey  <tromey@adacore.com>
2071
2072         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2073         after it has been moved.
2074
2075 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2076
2077         * valops.c (value_must_coerce_to_target): Change return type to
2078         bool.
2079         * value.h (value_must_coerce_to_target): Likewise.
2080
2081 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2082
2083         * breakpoint.c (is_hardware_watchpoint): Remove
2084         forward-declaration.
2085         (is_masked_watchpoint): Change return type to bool.
2086         (is_tracepoint): Likewise.
2087         (is_breakpoint): Likewise.
2088         (is_hardware_watchpoint): Likewise.
2089         (is_watchpoint): Likewise.
2090         (is_no_memory_software_watchpoint): Likewise.
2091         (is_catchpoint): Likewise.
2092         (breakpoint_1): Make FILTER parameter's return type bool.
2093         is_masked_watchpoint): Change return type to bool.
2094         (save_breakpoints): Make FILTER parameter's return type bool.
2095         * breakpoint.h (is_breakpoint): Change return type to bool.
2096         (is_watchpoint): Likewise.
2097         (is_catchpoint): Likewise.
2098         (is_tracepoint): Likewise.
2099
2100 2019-07-10  Tom Tromey  <tom@tromey.com>
2101
2102         * defs.h: Don't include gdbarch.h.
2103         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2104         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2105         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2106         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2107         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2108         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2109         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2110         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2111         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2112         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2113         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2114         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2115         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2116         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2117         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2118         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2119         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2120         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2121         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2122         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2123         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2124         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2125         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2126         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2127         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2128         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2129         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2130
2131 2019-07-10  Tom Tromey  <tromey@adacore.com>
2132
2133         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2134         * breakpoint.c (init_ada_exception_breakpoint): Register as
2135         bp_catchpoint.
2136         (print_one_breakpoint_location, print_one_breakpoint): Use
2137         is_ada_exception_catchpoint.
2138         * ada-lang.c (class ada_catchpoint_location): Pass
2139         bp_loc_software_breakpoint to bp_location constructor.
2140         (is_ada_exception_catchpoint): New function.
2141
2142 2019-07-10  Tom Tromey  <tromey@adacore.com>
2143
2144         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2145         VEC.
2146         (struct arm_exidx_entry): New method operator<.
2147         (struct arm_exidx_data) <section_maps>: Change type.
2148         (arm_exidx_data_free): Remove.
2149         (arm_exidx_data_key): Change type.  Move lower.
2150         (arm_exidx_new_objfile): Update.
2151         (arm_compare_exidx_entries): Remove.
2152         (arm_find_exidx_entry, _initialize_arm_tdep)
2153
2154 2019-07-10  Tom Tromey  <tromey@adacore.com>
2155
2156         * solib-spu.c (ocl_program_data_key): Change type.
2157         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2158         Update.
2159
2160 2019-07-10  Tom Tromey  <tromey@adacore.com>
2161
2162         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2163         (struct solib_aix_inferior_data) <library_list>: Change type.
2164         (solib_aix_inferior_data_handle): Change type.
2165         (get_solib_aix_inferior_data): Update.
2166         (solib_aix_free_library_list): Remove.
2167         (library_list_start_library): Update.
2168         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2169         return type.
2170         (solib_aix_get_library_list)
2171         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2172         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2173
2174 2019-07-10  Tom Tromey  <tromey@adacore.com>
2175
2176         * solib-dsbt.c (struct dsbt_info): Add initializers.
2177         (solib_dsbt_pspace_data): Change type.
2178         (dsbt_pspace_data_cleanup): Remove.
2179         (get_dsbt_info, _initialize_dsbt_solib): Update.
2180
2181 2019-07-10  Tom Tromey  <tromey@adacore.com>
2182
2183         * spu-tdep.c (spu_overlay_data): Change type.
2184         (spu_get_overlay_table, spu_overlay_new_objfile)
2185         (_initialize_spu_tdep): Update.
2186
2187 2019-07-10  Tom Tromey  <tromey@adacore.com>
2188
2189         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2190         destructor.
2191         (dbx_objfile_data_key): Change type and declare later.
2192         (DBX_SYMFILE_INFO): Rewrite.
2193         * dbxread.c (dbx_objfile_data_key): Change type.
2194         (dbx_symfile_init): Update.
2195         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2196         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2197         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2198
2199 2019-07-10  Tom Tromey  <tromey@adacore.com>
2200
2201         * jit.c (jit_program_space_key): Change type.  Move lower.
2202         (get_jit_program_space_data): Update.
2203         (jit_program_space_data_cleanup): Remove.
2204         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2205         Update.
2206         (struct jit_program_space_data): Add initializers.
2207
2208 2019-07-10  Tom Tromey  <tromey@adacore.com>
2209
2210         * solib-darwin.c (struct darwin_info): Add initializers.
2211         (solib_darwin_pspace_data): Change type.
2212         (darwin_pspace_data_cleanup): Remove.
2213         (get_darwin_info, _initialize_darwin_solib): Update.
2214
2215 2019-07-10  Tom Tromey  <tromey@adacore.com>
2216
2217         * remote-sim.c (struct sim_inferior_data): Add initializers,
2218         constructor, and destructor.
2219         (sim_inferior_data_key): Change type.  Move lower.
2220         (check_for_duplicate_sim_descriptor): Update.
2221         (get_sim_inferior_data): Use new.  Update.
2222         (~sim_inferior_data_cleanup): Rename from
2223         sim_inferior_data_cleanup.  Simplify.
2224         (gdbsim_close_inferior, simulator_command)
2225         (sim_command_completer, _initialize_remote_sim): Update.
2226         (next_pid, INITIAL_PID): Move earlier.
2227
2228 2019-07-10  Tom Tromey  <tromey@adacore.com>
2229
2230         * python/python-internal.h (create_thread_object): Return
2231         gdbpy_ref.
2232         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2233         * python/py-inferior.c (struct threadlist_entry): Add
2234         constructor.
2235         <thread_obj>: Now a gdbpy_ref.
2236         (thread_to_thread_object): Update.
2237         (add_thread_object): Use new.
2238         (delete_thread_object): Use delete.
2239         (infpy_threads): Update.
2240         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2241         GIL.
2242
2243 2019-07-10  Tom Tromey  <tromey@adacore.com>
2244
2245         * valops.c (value_cast): Specialize error message for Ada.
2246
2247 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2248
2249         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2250
2251 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2252
2253         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2254         bpstat_should_step): Return bool, adjust comments.
2255         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2256         bpstat_should_step): Likewise.
2257
2258 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2259
2260         * features/Makefile: Use feature target descriptions for Arm.
2261         * features/arm/arm-core.c: Generate new file.
2262         * features/arm/arm-fpa.c: Likewise.
2263         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2264         * features/arm/arm-m-profile.c: Likewise.
2265         * features/arm/arm-vfpv2.c: Likewise.
2266         * features/arm/arm-vfpv3.c: Likewise.
2267         * features/arm/xscale-iwmmxt.c: Likewise.
2268         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2269
2270 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2271
2272         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2273         ptrace earlier.
2274
2275 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2276
2277         * features/aarch64-pauth.c: Regenerate.
2278
2279 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2280
2281         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2282         bool.
2283         (bpstat_what): Use false instead of 0.
2284
2285 2019-07-09  Pedro Alves  <palves@redhat.com>
2286
2287         * break-catch-throw.c (is_exception_catchpoint): New.
2288         * breakpoint.c (print_one_breakpoint_location): New parameter
2289         'raw_loc'.  Handle it.  Use
2290         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2291         looking at the breakpoint's type.
2292         (print_one_breakpoint): If handling "maint info breakpoints", also
2293         print locations of exception catchpoints.
2294         * breakpoint.h (is_exception_catchpoint): Declare.
2295
2296 2019-07-09  Pedro Alves  <palves@redhat.com>
2297
2298         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2299         "addr" field.
2300         (allocate_location_exception_catchpoint): New.
2301         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2302         (initialize_throw_catchpoint_ops): Install
2303         allocate_location_exception_catchpoint as allocate_location
2304         method.
2305         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2306         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2307         bp_loc_other.
2308         (breakpoint_address_is_meaningful): Delete.
2309         (bl_address_is_meaningful): New.
2310         (breakpoint_locations_match): Adjust comment.
2311         (bp_location_from_bp_type): New, factored out of...
2312         (bp_location::bp_location(breakpoint *)): ... this.
2313         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2314         factored out of...
2315         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2316         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2317         breakpoint_address_is_meaningful.
2318         (bp_locations_compare): Adjust comment.
2319         (update_global_location_list): Use bl_address_is_meaningful
2320         instead of breakpoint_address_is_meaningful.
2321         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2322         explicit.
2323         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2324         * python/py-breakpoint.c (bppy_get_location): No longer check
2325         whether location is null.
2326
2327 2019-07-09  Pedro Alves  <palves@redhat.com>
2328
2329         PR c++/15468
2330         * breakpoint.c (print_one_breakpoint_location): Remove
2331         single-location assert.
2332
2333 2019-07-09  Tom Tromey  <tom@tromey.com>
2334
2335         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2336         * configure: Rebuild.
2337         * configure.ac: Change common to gdbsupport.
2338         * gdbsupport: Rename from common.
2339         * acinclude.m4: Change common to gdbsupport.
2340         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2341         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2342         gdbsupport.
2343         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2344         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2345         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2346         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2347         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2348         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2349         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2350         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2351         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2352         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2353         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2354         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2355         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2356         coff-pe-read.c, command.h, compile/compile-c-support.c,
2357         compile/compile-c.h, compile/compile-cplus-symbols.c,
2358         compile/compile-cplus-types.c, compile/compile-cplus.h,
2359         compile/compile-loc2c.c, compile/compile.c, completer.c,
2360         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2361         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2362         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2363         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2364         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2365         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2366         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2367         features/aarch64-core.c, features/aarch64-fpu.c,
2368         features/aarch64-pauth.c, features/aarch64-sve.c,
2369         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2370         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2371         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2372         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2373         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2374         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2375         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2376         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2377         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2378         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2379         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2380         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2381         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2382         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2383         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2384         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2385         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2386         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2387         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2388         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2389         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2390         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2391         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2392         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2393         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2394         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2395         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2396         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2397         minsyms.c, mips-linux-tdep.c, namespace.h,
2398         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2399         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2400         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2401         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2402         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2403         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2404         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2405         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2406         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2407         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2408         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2409         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2410         procfs.c, producer.c, progspace.h, psymtab.h,
2411         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2412         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2413         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2414         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2415         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2416         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2417         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2418         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2419         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2420         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2421         target-memory.c, target.c, target.h, target/waitstatus.c,
2422         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2423         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2424         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2425         unittests/array-view-selftests.c,
2426         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2427         unittests/common-utils-selftests.c,
2428         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2429         unittests/format_pieces-selftests.c,
2430         unittests/function-view-selftests.c,
2431         unittests/lookup_name_info-selftests.c,
2432         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2433         unittests/mkdir-recursive-selftests.c,
2434         unittests/observable-selftests.c,
2435         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2436         unittests/parse-connection-spec-selftests.c,
2437         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2438         unittests/scoped_fd-selftests.c,
2439         unittests/scoped_mmap-selftests.c,
2440         unittests/scoped_restore-selftests.c,
2441         unittests/string_view-selftests.c, unittests/style-selftests.c,
2442         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2443         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2444         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2445         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2446         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2447         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2448
2449 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2452         bool value.
2453         (decode_digits_ordinary): Set explicit_line field in sal.
2454         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2455         symtab_and_line that was set on an explicit line number in
2456         assembler code.  Do always update the recorded symtab and line if
2457         we do skip the prologue.
2458
2459 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * breakpoint.c (set_breakpoint_location_function): Remove
2462         explicit_loc parameter.
2463         (momentary_breakpoint_from_master): Update call to
2464         set_breakpoint_location_function.
2465         (add_location_to_breakpoint): Likewise.
2466
2467 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2468
2469         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2470         required features based on default bfd type when no specific bfd
2471         is present.
2472
2473 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2474
2475         * NEWS: Mention that GDB printf and eval commands can now print
2476         C-style and Ada-style convenience var strings without
2477         calling the inferior.
2478         * printcmd.c (printf_c_string): Locally print GDB internal var
2479         instead of transiting via the inferior.
2480         (printf_wide_c_string): Likewise.
2481
2482 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2483
2484         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2485
2486 2019-07-04  Tom Tromey  <tom@tromey.com>
2487
2488         PR tui/24724:
2489         * tui/tui-winsource.c (tui_clear_source_content): Update.
2490         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2491         (tui_update_breakpoint_info): Update.
2492         (tui_set_exec_info_content): Update.
2493         * tui/tui-source.c (tui_set_source_content_nil): Update.
2494         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2495         has_break.
2496         * tui/tui-data.h (enum tui_bp_flag): New.
2497         (tui_bp_flags): New enum flags type.
2498         (struct tui_source_element) <break_mode>: Change type.  Rename
2499         from has_break.
2500         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2501         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2502         constants.
2503         * tui/tui-winsource.h: Fix comment.
2504
2505 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2506
2507         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2508         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2509         (store_fpregs_to_thread)
2510         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2511         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2512         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2513         (IWMMXT_REGS_SIZE): Add define.
2514         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2515         (fetch_vfp_regs, store_vfp_regs)
2516         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2517         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2518
2519 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2522         defines.
2523         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2524         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2525         (ARM_INT_REGISTER_SIZE): ...to this.
2526         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2527         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2528         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2529         (arm_linux_collect_gregset, supply_nwfpe_register)
2530         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2531         defines.
2532         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2533         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2534         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2535         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2536         (arm_return_in_memory, arm_store_return_value)
2537         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2538         (arm_record_ld_st_multiple): Likewise.
2539         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2540         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2541
2542 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2543
2544         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2545         AARCH64_DISPLACED_MODIFIED_INSNS.
2546         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2547         (aarch64_displaced_step_copy_insn): Likewise.
2548         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2549         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2550         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2551         ARM_DISPLACED_MODIFIED_INSNS.
2552         * arm-tdep.c (arm_gdbarch_init): Likewise.
2553         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2554         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2555         (struct arm_displaced_step_closure): Use
2556         ARM_DISPLACED_MODIFIED_INSNS.
2557
2558 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2559
2560         * features/Makefile: Remove unused xml files.
2561         * features/aarch64.xml: Remove.
2562         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2563         * features/i386/amd64-avx-avx512.xml: Remove.
2564         * features/i386/amd64-avx-linux.xml: Remove.
2565         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2566         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2567         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2568         * features/i386/amd64-avx-mpx.xml: Remove.
2569         * features/i386/amd64-avx.xml: Remove.
2570         * features/i386/amd64-linux.xml: Remove.
2571         * features/i386/amd64-mpx-linux.xml: Remove.
2572         * features/i386/amd64-mpx.xml: Remove.
2573         * features/i386/amd64.xml: Remove.
2574         * features/i386/i386-avx-avx512-linux.xml: Remove.
2575         * features/i386/i386-avx-avx512.xml: Remove.
2576         * features/i386/i386-avx-linux.xml: Remove.
2577         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2578         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2579         * features/i386/i386-avx-mpx-linux.xml: Remove.
2580         * features/i386/i386-avx-mpx.xml: Remove.
2581         * features/i386/i386-avx.xml: Remove.
2582         * features/i386/i386-linux.xml: Remove.
2583         * features/i386/i386-mmx-linux.xml: Remove.
2584         * features/i386/i386-mmx.xml: Remove.
2585         * features/i386/i386-mpx-linux.xml: Remove.
2586         * features/i386/i386-mpx.xml: Remove.
2587         * features/i386/i386.xml: Remove.
2588         * features/i386/x32-avx-avx512-linux.xml: Remove.
2589         * features/i386/x32-avx-linux.xml: Remove.
2590         * features/i386/x32-linux.xml: Remove.
2591
2592 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2593
2594         * regformats/aarch64.dat: Remove.
2595         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2596         * regformats/i386/amd64-avx-linux.dat: Remove.
2597         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2598         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2599         * regformats/i386/amd64-linux.dat: Remove.
2600         * regformats/i386/amd64-mpx-linux.dat: Remove.
2601         * regformats/i386/amd64.dat: Remove.
2602         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2603         * regformats/i386/i386-avx-linux.dat: Remove.
2604         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2605         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2606         * regformats/i386/i386-linux.dat: Remove.
2607         * regformats/i386/i386-mmx-linux.dat: Remove.
2608         * regformats/i386/i386-mpx-linux.dat: Remove.
2609         * regformats/i386/i386.dat: Remove.
2610         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2611         * regformats/i386/x32-avx-linux.dat: Remove.
2612         * regformats/i386/x32-linux.dat: Remove.
2613
2614 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2615
2616         * aarch64-tdep.c: Remove xml self tests.
2617         * amd64-linux-tdep.c: Likewise.
2618         * amd64-tdep.c: Likewise.
2619         * i386-linux-tdep.c: Likewise.
2620         * i386-tdep.c: Likewise.
2621
2622 2019-07-03  Pedro Alves  <palves@redhat.com>
2623
2624         PR cli/24732
2625         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2626         (pipe_cmd_option_defs): New.
2627         (make_pipe_cmd_options_def_group): New.
2628         (pipe_command): Use gdb::option::process_options.
2629         (pipe_command_completer): New function.
2630         (_initialize_cli_cmds): Install completer for "pipe" command.
2631
2632 2019-07-03  Pedro Alves  <palves@redhat.com>
2633
2634         * cli/cli-option.c (union option_value) <string>: New field.
2635         (struct option_def_and_value): Add ctor, move ctor, dtor and
2636         use DISABLE_COPY_AND_ASSIGN.
2637         (option_def_and_value::clear_value): New.
2638         (parse_option, save_option_value_in_ctx, get_val_type_str)
2639         (add_setshow_cmds_for_options): Handle var_string.
2640         * cli-option.h (union option_def::var_address) <string>: New
2641         field.
2642         (struct string_option_def): New.
2643         * maint-test-options.c (struct test_options_opts): Add default
2644         ctor and use DISABLE_COPY_AND_ASSIGN.
2645         <string_opt>: New field.
2646         (test_options_opts::~test_options_opts): New.
2647         (test_options_opts::dump): Also dump "-string".
2648         (test_options_option_defs): Install "string.
2649
2650 2019-07-03  Pedro Alves  <palves@redhat.com>
2651
2652         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2653         option_value with a null enumeration.
2654         (complete_options): Save the option values in the context.
2655         (save_option_value_in_ctx): New, factored out from ...
2656         (process_options): ... here.
2657         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2658         of the function.
2659         * maint-test-options.c (test_options_opts::dump): New, factored
2660         out from ...
2661         (maintenance_test_options_command_mode): ... here.
2662         (maintenance_test_options_command_completion_result): Delete.
2663         (maintenance_test_options_command_completion_text): Update
2664         comment.
2665         (maintenance_show_test_options_completion_result): Change
2666         prototype.  Just print
2667         maintenance_test_options_command_completion_text.
2668         (save_completion_result): New.
2669         (maintenance_test_options_completer_mode): Pass options context to
2670         complete_options, and then save a dump.
2671         (_initialize_maint_test_options): Use add_cmd to install "maint
2672         show test-options-completion-result".
2673
2674 2019-07-03  Pedro Alves  <palves@redhat.com>
2675
2676         * NEWS (New commands): Mention "with" and "maint with".
2677         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2678         (with_command, with_command_completer): New.
2679         (pipe_command): Adjust to new repeat_previous
2680         interface.
2681         (_initialize_cli_cmds): Install the "with" command and its "w"
2682         alias.
2683         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2684         declarations.
2685         * cli/cli-setshow.c (parse_cli_var_uinteger)
2686         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2687         argument strings for all var_types.
2688         (get_setshow_command_value_string): New, factored out from ...
2689         (do_show_command): ... this.
2690         * cli/cli-setshow.h: Include <string>.
2691         (get_setshow_command_value_string): Declare.
2692         * command.h (repeat_previous): Now returns const char *.  Adjust
2693         comment.
2694         * maint.c: Include "cli/cli-cmds.h".
2695         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2696         (_initialize_maint_cmds): Register the "maintenance with" command.
2697         * top.c (repeat_previous): Move bits from pipe_command here:
2698         Return the saved command line, if any; error out if there's no
2699         command to relaunch.
2700
2701 2019-07-03  Pedro Alves  <palves@redhat.com>
2702
2703         * NEWS (New commands): Mention "maint set/show test-settings"
2704         instead of "maint test-settings".
2705         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2706         (maintenance_test_settings_set_list): Rename to ...
2707         (maintenance_set_test_settings_list): ... this.
2708         (maintenance_test_settings_show_list): Rename to  ...
2709         (maintenance_show_test_settings_list): ... this.
2710         (maintenance_test_settings_cmd): Delete.
2711         (maintenance_test_settings_set_cmd): ...
2712         (maintenance_set_test_settings_cmd): ... this.
2713         (maintenance_test_settings_show_cmd): ...
2714         (maintenance_show_test_settings_cmd): ... this.
2715         (maintenance_test_settings_show_value_cmd):
2716         (maintenance_show_test_settings_value_cmd): ... this.
2717         (_initialize_maint_test_settings): No longer install the "maint
2718         test-settings" prefix command.  Rename "maint test-settings set"
2719         to "maint set test-settings", and "maint test-settings show" to
2720         "maint show test-settings".  Adjust all subcommands.
2721
2722 2019-07-03  Pedro Alves  <palves@redhat.com>
2723
2724         * maint-test-settings.c: Fix file's intro comment.  Replace all
2725         references to "test-options" with references to "test-settings",
2726         in comments.
2727
2728 2019-07-03  Pedro Alves  <palves@redhat.com>
2729
2730         * maint-test-settings.c (maintenance_test_settings_xxx)
2731         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2732         New.
2733         (maintenance_test_settings_enums): Use them.
2734         (maintenance_test_settings_enum): Default to
2735         maintenance_test_settings_xxx.
2736         (_initialize_maint_test_settings): Initialize
2737         MAINTENANCE_TEST_SETTINGS_FILENAME.
2738
2739 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2740
2741         * breakpoint.h (remove_breakpoints_inf): Change return type to
2742         void, move function documentation here.
2743         * breakpoint.c (remove_breakpoints_inf): Change return type to
2744         void, move function documentation to header.
2745
2746 2019-07-02  Pedro Alves  <palves@redhat.com>
2747
2748         * NEWS (Completion improvements): Mention "info threads".
2749         * thread.c (struct info_threads_opts, info_threads_option_defs)
2750         (make_info_threads_options_def_group): New.
2751         (info_threads_command): Use gdb::option::process_options.
2752         (info_threads_command_completer): New.
2753         (_initialize_thread): Use gdb::option::build_help to build the
2754         help text for "info threads".
2755
2756 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2757
2758         * defs.h (generic_load): Move from here...
2759         * symfile.h (generic_load): ... to here.  Rename name parameter
2760         to args.
2761         * symfile.c (generic_load): Add comment.
2762
2763 2019-07-01  Tom Tromey  <tromey@adacore.com>
2764
2765         * dwarf2read.c
2766         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2767         declaration of without_params.  Fix formatting.
2768
2769 2019-07-01  Tom Tromey  <tromey@adacore.com>
2770
2771         * ada-exp.y (find_primitive_type): Update.
2772         * ada-lang.h (ada_lookup_symbol): Update.
2773         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2774         parameter.
2775         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2776
2777 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2778
2779         PR breakpoints/24541
2780         * gdbarch.c: Regenerate.
2781         * gdbarch.h: Regenerate.
2782         * gdbarch.sh: Add 'stap_adjust_register'.
2783         * i386-tdep.c: Include '<unordered_set>'.
2784         (i386_stap_adjust_register): New function.
2785         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2786         * stap-probe.c (stap_parse_register_operand): Call
2787         'gdbarch_stap_adjust_register'.
2788
2789 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2790
2791         PR python/24742
2792         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2793         * python/python.c (do_start_initialization): Use 'xmalloc'
2794         instead of 'PyMem_Malloc'.
2795
2796 2019-06-28  Tom Tromey  <tromey@adacore.com>
2797
2798         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2799         for Ada.
2800
2801 2019-06-27  Tom Tromey  <tromey@adacore.com>
2802
2803         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2804         objfile_key.
2805         (arm_find_mapping_symbol, arm_record_special_symbol)
2806         (_initialize_arm_tdep): Update.
2807         (arm_objfile_data_free): Remove.
2808
2809 2019-06-27  Tom Tromey  <tromey@adacore.com>
2810
2811         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2812         to cp_print_static_field.
2813
2814 2019-06-26  Tom Tromey  <tromey@adacore.com>
2815
2816         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2817         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2818         declare.
2819
2820 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2821
2822         * features/aarch64-core.c (create_feature_aarch64_core):
2823         Regenerate.
2824         * features/aarch64-core.xml: Add cpsr flags.
2825
2826 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2827
2828         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2829         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2830
2831 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2832
2833         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2834         field.
2835         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2836         use.
2837         (arm_record_special_symbol): Don't insert new symbol in sorted
2838         position, push it at the end.
2839
2840 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2841
2842         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2843         (arm_mapping_symbol_s): Remove.
2844         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2845         (arm_mapping_symbol_vec): New typedef.
2846         (struct arm_per_objfile): Add constructor.
2847         <section_maps>: Change type to
2848         std::unique_ptr<arm_mapping_symbol_vec[]>.
2849         (arm_compare_mapping_symbols): Remove.
2850         (arm_find_mapping_symbol): Adjust to section_maps type change.
2851         (arm_objfile_data_free): Call delete on arm_per_objfile.
2852         (arm_record_special_symbol): Adjust to section_maps type change.
2853         Allocate arm_per_objfile with new.
2854
2855 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2856
2857         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2858         with the command prefix.
2859
2860 2019-06-25  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2863         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2864
2865 2019-06-25  Tom Tromey  <tom@tromey.com>
2866
2867         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2868         type.
2869         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2870         protected.
2871
2872 2019-06-25  Tom Tromey  <tom@tromey.com>
2873
2874         * tui/tui-winsource.c
2875         (tui_source_window_base::set_is_exec_point_at): Add check against
2876         LOA_ADDRESS.
2877
2878 2019-06-25  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-source.c (tui_set_source_content): Don't check before
2881         xfree.
2882         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2883
2884 2019-06-25  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-winsource.h (tui_update_source_window_as_is)
2887         (tui_alloc_source_buffer, tui_line_is_displayed)
2888         (tui_addr_is_displayed): Change type of win_info.
2889         * tui/tui-winsource.c (tui_update_source_window_as_is)
2890         (tui_clear_source_content, tui_show_source_line)
2891         (tui_show_source_content, tui_source_window_base::refill)
2892         (tui_source_window_base::set_is_exec_point_at)
2893         (tui_source_window_base::set_is_exec_point_at)
2894         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2895         (tui_alloc_source_buffer, tui_line_is_displayed)
2896         (tui_addr_is_displayed): Change type of win_info.  Update.
2897         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2898         (tui_source_window_base::do_make_visible_with_new_height):
2899         Update.
2900         * tui/tui-source.c (tui_set_source_content)
2901         (tui_set_source_content_nil)
2902         (tui_source_window::do_scroll_vertical): Update.
2903         * tui/tui-layout.c (show_layout): Update.
2904         * tui/tui-disasm.c (tui_set_disassem_content)
2905         (tui_disasm_window::do_scroll_vertical): Update.
2906         * tui/tui-data.h (tui_win_content): Remove.
2907         (struct tui_gen_win_info) <content, content_size>: Remove.
2908         (struct tui_source_element): Add initializers and destructor.
2909         (union tui_which_element, struct tui_win_element): Remove.
2910         (struct tui_source_window_base) <content>: New field.
2911         (struct tui_data_window): Remove destructor.
2912         (tui_alloc_content, tui_free_win_content)
2913         (tui_free_all_source_wins_content): Don't declare.
2914         * tui/tui-data.c (tui_initialize_static_data): Update.
2915         (init_content_element, tui_alloc_content): Remove.
2916         (~tui_gen_win_info): Update.
2917         (~tui_data_window, tui_free_all_source_wins_content)
2918         (tui_free_win_content, free_content, free_content_elements):
2919         Remove.
2920
2921 2019-06-25  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-winsource.h (tui_clear_source_content)
2924         (tui_erase_source_content, tui_show_source_content): Change type
2925         of win_info.
2926         * tui/tui-winsource.c (tui_clear_source_content)
2927         (tui_erase_source_content, tui_show_source_content): Change type
2928         of win_info.
2929         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2930         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2931         win_info.
2932         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2933         win_info.
2934         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2935
2936 2019-06-25  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-winsource.c (tui_clear_source_content)
2939         (tui_source_window_base::set_is_exec_point_at): Update.
2940         * tui/tui-source.c (tui_set_source_content_nil): Update.
2941         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2942         a bool.
2943         * tui/tui-data.c (init_content_element): Update.
2944
2945 2019-06-25  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2948         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2949         * tui/tui-layout.c (init_and_make_win): Update.
2950         * tui/tui.h (enum tui_win_type): Update.
2951         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2952         tui_win_is_auxillary.
2953         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2954         tui_win_is_auxillary.
2955
2956 2019-06-25  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2959         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2960         (tui_delete_data_content_windows, tui_display_all_data)
2961         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2962         Update.
2963         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2964         * tui/tui-regs.c (tui_last_regs_line_no)
2965         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2966         (tui_show_registers): Update.
2967         (tui_show_register_group): Return void.  Update.
2968         (tui_display_registers_from, tui_display_reg_element_at_line)
2969         (tui_display_registers_from_line, tui_check_register_values):
2970         Update.
2971         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2972         member.
2973         (struct tui_data_window) <regs_content>: Now a std::vector.
2974         <regs_content_count>: Remove.
2975         (tui_add_content_elements, tui_free_data_content): Don't declare.
2976         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2977         (init_content_element): Remove DATA_WIN case.  Add assert.
2978         (tui_add_content_elements): Remove.
2979         (tui_data_window): Update.
2980         (tui_free_data_content): Remove.
2981         (free_content_elements): Remove DATA_WIN case.
2982
2983 2019-06-25  Tom Tromey  <tom@tromey.com>
2984
2985         * tui/tui-data.c (tui_data_item_window): Update.
2986         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2987         * tui/tui-windata.c (tui_display_all_data)
2988         (tui_display_data_from_line): Update.
2989         (tui_check_data_values): Remove.
2990         * tui/tui-regs.c (tui_show_register_group)
2991         (tui_display_reg_element_at_line): Update.
2992         * tui/tui-hooks.c (tui_register_changed)
2993         (tui_refresh_frame_and_register_information): Call
2994         tui_check_register_values.
2995         * tui/tui-data.h (struct tui_data_window) <data_content,
2996         data_content_count, data_type>: Remove.
2997         (enum tui_data_type): Remove.
2998
2999         * tui/tui-data.c (tui_data_window::clear_detail)
3000         (~tui_data_window): Update.
3001
3002 2019-06-25  Tom Tromey  <tom@tromey.com>
3003
3004         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3005         declare.
3006         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3007         Rename from tui_first_data_item_displayed.  Update.
3008         (tui_data_window::refresh_all)
3009         (tui_data_window::do_scroll_vertical): Update.
3010         * tui/tui-data.h (struct tui_data_window)
3011         <first_data_item_displayed>: Declare new method.
3012
3013 2019-06-25  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3016         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3017         contents...
3018         (tui_initialize_static_data): ...here.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3023         (tui_display_registers_from, tui_check_register_values): Update.
3024         (tui_display_register): Remove win_info parameter; update.
3025         (tui_get_register): Change type of parameters.
3026         * tui/tui-data.h (struct tui_data_element): Remove.
3027         (union tui_which_element) <data>: Remove.
3028         <data_window>: Change type.
3029         (struct tui_data_item_window): New.
3030         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3031         case.  Add assert.
3032         (~tui_data_item_window): New destructor.
3033         (free_content_elements): Remove DATA_ITEM_WIN case.
3034
3035 2019-06-25  Tom Tromey  <tom@tromey.com>
3036
3037         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3038         Remove.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-data.h (struct tui_command_element): Remove.
3043         (union tui_which_element) <command>: Remove.
3044         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3045         assert.
3046         (free_content_elements): Remove CMD_WIN case.
3047
3048 2019-06-25  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui-layout.c (tui_set_layout): Update.
3051         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3052         * tui/tui-data.c (layout_def): Update.
3053
3054 2019-06-25  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3057         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3058         (tui_source_window_base::set_new_height): Update.
3059         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3060         Update.
3061         (tui_set_locator_fullname, tui_set_locator_info)
3062         (tui_show_frame_info): Update.
3063         * tui/tui-source.c (tui_set_source_content)
3064         (tui_source_is_displayed): Update.
3065         * tui/tui-layout.c (show_source_disasm_command, show_data)
3066         (show_source_or_disasm_and_command): Update.
3067         * tui/tui-disasm.c (tui_set_disassem_content)
3068         (tui_get_begin_asm_address): Update.
3069         * tui/tui-data.h (struct tui_locator_element): Remove.
3070         (union tui_which_element) <locator>: Remove.
3071         (struct tui_locator_window): New.
3072         (tui_locator_win_info_ptr): Change return type.
3073         * tui/tui-data.c (_locator): Change type.
3074         (tui_locator_win_info_ptr): Change return type.
3075         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3076         (tui_alloc_content): Add assert.
3077
3078 2019-06-25  Tom Tromey  <tom@tromey.com>
3079
3080         * tui/tui-winsource.c
3081         (tui_exec_info_window::maybe_allocate_content): New method.
3082         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3083         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3084         (make_source_or_disasm_window): Add cast.
3085         * tui/tui-data.h (union tui_which_element) <simple_string>:
3086         Remove.
3087         (struct tui_source_info): New.
3088         (struct tui_source_window_base) <execution_info>: Change type.
3089         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3090         case, and add assert.
3091         (tui_alloc_content): Add assert.
3092
3093 2019-06-25  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3096         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3097         * tui/tui-data.c (tui_alloc_win_info): Remove.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3102         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3103         can_highlight.
3104
3105 2019-06-25  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3108         make_visible_with_new_height method.
3109         (tui_win_info::make_visible_with_new_height): New method.
3110         (tui_source_window_base::do_make_visible_with_new_height)
3111         (tui_data_window::do_make_visible_with_new_height)
3112         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3113         (make_visible_with_new_height): Remove.
3114         (tui_resize_all, tui_adjust_win_heights): Use
3115         make_visible_with_new_height method.
3116         * tui/tui-data.h (struct tui_win_info)
3117         <do_make_visible_with_new_height, make_visible_with_new_height>:
3118         New methods.
3119         (struct tui_source_window_base, struct tui_data_window)
3120         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3121         methods.
3122
3123 2019-06-25  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3126         method.
3127         (update_tab_width): Call update_tab_width method.
3128         * tui/tui-data.h (struct tui_win_info)
3129         (struct tui_source_window_base) <update_tab_width>: New methods.
3130
3131 2019-06-25  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3134         parameter.
3135         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3136         parameter.
3137         (tui_gen_win_info::make_visible): Update.
3138         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3139         parameter.
3140         * tui/tui-data.h (enum tui_box): New enum.
3141         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3142
3143 2019-06-25  Tom Tromey  <tom@tromey.com>
3144
3145         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3146         init_and_make_win for EXEC_INFO_WIN.
3147         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3148         longer inline.
3149         (struct tui_win_info) <~tui_win_info>: Inline.
3150         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3151         Don't declare.
3152         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3153         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3154         Remove.
3155         (tui_initialize_static_data): Update.
3156         (~tui_gen_win_info): Handle more cleanup here.
3157         (~tui_source_window_base): Delete "execution_info".
3158         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-layout.c (make_command_window): Don't set
3163         can_highlight.
3164         (show_source_disasm_command): Call the reset method.
3165         (show_data): Don't set can_highlight.  Call the reset method.
3166         (tui_gen_win_info::reset): Rename from init_gen_win_info
3167         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3168         (show_source_or_disasm_and_command): Call the reset method.
3169         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3170         (struct tui_cmd_window): Set can_highlight.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3175         from make_visible.
3176         (tui_make_visible, tui_make_invisible): Rewrite.
3177         (tui_win_info::make_visible): Remove.
3178         (tui_source_window_base::make_visible): Update.
3179         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3180         method.  Moved from...
3181         (struct tui_win_info) <make_visible>: ...here.
3182
3183 2019-06-25  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-winsource.c
3186         (tui_source_window_base::do_scroll_horizontal): Remove direction
3187         parameter.
3188         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3189         direction parameter.
3190         * tui/tui-win.c (tui_win_info::forward_scroll)
3191         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3192         (tui_win_info::right_scroll): Update.
3193         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3194         direction parameter.
3195         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3196         direction parameter.
3197         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3198         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3199         Remove direction parameter.
3200         (struct tui_source_window_base, struct tui_source_window)
3201         (struct tui_disasm_window, struct tui_data_window)
3202         (struct tui_cmd_window): Update.
3203
3204 2019-06-25  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-winsource.h (tui_set_exec_info_content)
3207         (tui_show_exec_info_content, tui_erase_exec_info_content)
3208         (tui_clear_exec_info_content, tui_update_exec_info): Change
3209         argument to tui_source_window_base.
3210         * tui/tui-winsource.c (tui_set_exec_info_content)
3211         (tui_show_exec_info_content, tui_erase_exec_info_content)
3212         (tui_clear_exec_info_content, tui_update_exec_info): Change
3213         argument to tui_source_window_base.
3214
3215 2019-06-25  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3218         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3223         check.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3228         type to void.
3229         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3230         type to void.
3231         * tui/tui-source.c (tui_set_source_content): Update.
3232         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-win.c (window_name_completer, tui_set_focus)
3237         (tui_all_windows_info): Use name method.
3238         * tui/tui-data.h (struct tui_gen_win_info)
3239         (struct tui_source_window, struct tui_disasm_window)
3240         (struct tui_data_window, struct tui_cmd_window) <name>: New
3241         method.
3242         (tui_win_name): Don't declare.
3243         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3244         (tui_win_name): Remove.
3245
3246 2019-06-25  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-winsource.h (tui_update_source_window)
3249         (tui_update_source_window_as_is): Change parameter type.
3250         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3251         to be a tui_source_window_base.
3252         (tui_update_source_window_as_is): Likewise.
3253         * tui/tui-win.c (make_visible_with_new_height): Update.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-winsource.c (tui_erase_source_content)
3258         (tui_show_source_content, tui_show_exec_info_content)
3259         (tui_erase_exec_info_content): Use refresh_window method.
3260         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3261         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3262         from tui_refresh_win.
3263         (tui_data_window::refresh_window): New method.
3264         (tui_win_info::refresh, tui_source_window_base::refresh)
3265         (tui_refresh_all): Use refresh_window method.
3266         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3267         method.
3268         * tui/tui-regs.c (tui_display_register): Call refresh_window
3269         method.
3270         * tui/tui-layout.c (show_source_disasm_command)
3271         (show_source_or_disasm_and_command): Call refresh_window method.
3272         * tui/tui-data.h (struct tui_gen_win_info)
3273         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3274         New method.
3275
3276 2019-06-25  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui.c (tui_rl_other_window, tui_enable)
3279         (tui_is_window_visible, tui_get_command_dimension): Update.
3280         * tui/tui-winsource.c (tui_update_source_window_as_is)
3281         (tui_clear_source_content, tui_erase_source_content)
3282         (tui_show_source_line, tui_source_window_base::refill)
3283         (tui_source_window_base::do_scroll_horizontal)
3284         (tui_source_window_base::set_is_exec_point_at)
3285         (tui_update_breakpoint_info, tui_set_exec_info_content)
3286         (tui_alloc_source_buffer, tui_line_is_displayed)
3287         (tui_addr_is_displayed): Update.
3288         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3289         (tui_check_and_display_highlight_if_needed)
3290         (tui_win_info::make_visible, tui_win_info::refresh)
3291         (tui_refresh_all): Update.
3292         * tui/tui-windata.c (tui_first_data_item_displayed)
3293         (tui_delete_data_content_windows, tui_erase_data_content)
3294         (tui_display_all_data, tui_data_window::refresh_all)
3295         (tui_check_data_values): Update.
3296         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3297         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3298         (tui_win_info::backward_scroll, tui_refresh_all_win)
3299         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3300         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3301         (tui_source_window_base::set_new_height)
3302         (tui_data_window::set_new_height)
3303         (make_invisible_and_set_new_height)
3304         (make_visible_with_new_height, new_height_ok)
3305         (parse_scrolling_args): Update.
3306         * tui/tui-stack.c (tui_show_frame_info): Update.
3307         * tui/tui-source.c (tui_set_source_content)
3308         (tui_set_source_content_nil, tui_source_is_displayed)
3309         (tui_source_window::do_scroll_vertical): Update.
3310         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3311         (tui_display_registers_from, tui_display_reg_element_at_line)
3312         (tui_check_register_values, tui_reg_command): Update.
3313         * tui/tui-layout.c (tui_default_win_height)
3314         (show_source_disasm_command, show_data, init_and_make_win)
3315         (show_source_or_disasm_and_command): Update.
3316         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3317         (tui_redisplay_readline, tui_mld_flush)
3318         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3319         (tui_getc): Update.
3320         * tui/tui-disasm.c (tui_set_disassem_content)
3321         (tui_disasm_window::do_scroll_vertical): Update.
3322         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3323         Now virtual.
3324         (struct tui_win_info): Derive from tui_gen_win_info.
3325         <~tui_win_info>: Mark as override.
3326         <generic>: Remove member.
3327         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3328         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3329         (~tui_data_window, ~tui_win_info)
3330         (tui_free_all_source_wins_content): Update.
3331         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3332
3333 2019-06-25  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-layout.c (init_and_make_win): Use new.
3336         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3337         destructor, initializers.
3338         (tui_alloc_generic_win_info): Don't declare.
3339         * tui/tui-data.c (_locator): Add argument to constructor.
3340         (source_win, disasm_win): New globals.
3341         (exec_info): Remove.
3342         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3343         Update.
3344         (tui_alloc_generic_win_info): Remove.
3345         (init_content_element): Use new.
3346         (tui_win_info::tui_win_info): Update.
3347         (free_content_elements) <case DATA_WIN>: Use delete.
3348
3349 2019-06-25  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3352         * tui/tui-windata.c (tui_first_data_item_displayed)
3353         (tui_delete_data_content_windows): Update.
3354         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3355         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3356         (tui_display_registers_from, tui_check_register_values): Update.
3357         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3358         pointer.
3359         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3360         window.
3361         (tui_free_data_content): Update.
3362         (free_content_elements) <case DATA_WIN>: Free the window.
3363
3364 2019-06-25  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3367         Update.
3368         * tui/tui-layout.c (make_command_window)
3369         (show_source_disasm_command, show_data, init_and_make_win)
3370         (show_source_or_disasm_and_command): Update.
3371         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3372         method.
3373         <can_highight, is_highlighted>: Now bool.
3374         (tui_set_win_highlight): Don't declare.
3375         * tui/tui-data.c (tui_set_win_highlight): Remove.
3376
3377 2019-06-25  Tom Tromey  <tom@tromey.com>
3378
3379         * tui/tui-wingeneral.c (make_visible): Remove check of window
3380         type.
3381
3382 2019-06-25  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-win.c (tui_win_info::max_height)
3385         (tui_cmd_window::max_height): New methods.
3386         (new_height_ok): Call max_height.
3387         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3388         <max_height>: New method.
3389
3390 2019-06-25  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-win.c (tui_source_window_base::set_new_height)
3393         (tui_data_window::set_new_height): New methods.
3394         (make_invisible_and_set_new_height): Call set_new_height method.
3395         * tui/tui-data.h (struct tui_win_info)
3396         (struct tui_source_window_base, struct tui_data_window)
3397         <set_new_height>: New method.
3398
3399 2019-06-25  Tom Tromey  <tom@tromey.com>
3400
3401         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3402         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3403         tui_refresh_data_win.
3404         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3405         method.
3406         (tui_refresh_all_win): Call the refresh_all method.
3407         (tui_set_focus): Likewise.
3408         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3409         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3410         Likewise.
3411
3412 2019-06-25  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-winsource.h (tui_refill_source_window)
3415         (tui_set_is_exec_point_at): Don't declare.
3416         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3417         (tui_source_window_base::refill): Rename from
3418         tui_refill_source_window.
3419         (tui_source_window_base::do_scroll_horizontal): Update.
3420         (tui_source_window_base::set_is_exec_point_at): Rename from
3421         tui_set_is_exec_point_at.
3422         (tui_update_all_breakpoint_info): Update.
3423         * tui/tui-stack.c (tui_show_frame_info): Update.
3424         * tui/tui-layout.c (show_data): Add cast.
3425         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3426         * tui/tui-data.h (struct tui_source_window_base) <refill,
3427         set_is_exec_point_at>: New methods.
3428         (tui_source_windows, tui_add_to_source_windows): Update types.
3429         (tui_add_to_source_windows): Remove redundant declaration.
3430         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3431         (tui_source_windows): Change return type.
3432         (tui_clear_source_windows_detail): Update.
3433         (tui_add_to_source_windows): Change type of parameter.
3434         (tui_free_all_source_wins_content): Update.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-wingeneral.c (tui_win_info::refresh)
3439         (tui_source_window_base::refresh): New methods.
3440         (tui_refresh_all): Call the refresh method.
3441         * tui/tui-data.h (struct tui_win_info)
3442         (struct tui_source_window_base) <refresh>: New method.
3443
3444 2019-06-25  Tom Tromey  <tom@tromey.com>
3445
3446         * tui/tui.h (tui_is_window_visible): Return bool.
3447         * tui/tui.c (tui_is_window_visible): Return bool.
3448         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3449         (tui_make_visible, tui_make_invisible)
3450         (tui_win_info::make_visible)
3451         (tui_source_window_base::make_visible, make_all_visible)
3452         (tui_make_all_visible, tui_make_all_invisible): Update.
3453         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3454         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3455         bool.
3456         (struct tui_win_info, struct tui_source_window_base)
3457         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3458         * tui/tui-data.c (tui_init_generic_part): Update.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3463         (tui_source_window_base::make_visible): New methods.
3464         (make_all_visible): Make method call.
3465         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3466         (struct tui_source_window_base, struct tui_cmd_window): Override
3467         make_visible.
3468         (tui_win_is_source_type): Don't declare.
3469         * tui/tui-data.c (tui_win_is_source_type): Remove.
3470
3471 2019-06-25  Tom Tromey  <tom@tromey.com>
3472
3473         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3474         NULL check.
3475
3476 2019-06-25  Tom Tromey  <tom@tromey.com>
3477
3478         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3479         Inline constructor.  Add initializers for members.
3480         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3481         constructors; now inline in class.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-regs.c (tui_show_registers): Update.
3486         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3487         bool.
3488         * tui/tui-data.c (tui_data_window::clear_detail)
3489         (tui_data_window): Update.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-windata.c (tui_display_all_data)
3494         (tui_display_data_from_line, tui_display_data_from)
3495         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3496         Update.
3497         * tui/tui-regs.c (tui_last_regs_line_no)
3498         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3499         (tui_show_registers, tui_show_register_group)
3500         (tui_display_registers_from, tui_display_reg_element_at_line)
3501         (tui_display_registers_from_line, tui_check_register_values)
3502         (tui_reg_next, tui_reg_prev): Update.
3503         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3504         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3505         tui_data_window.
3506         (struct tui_win_info) <detail>: Remove.  Add new fields from
3507         tui_data_info.
3508         (TUI_DATA_WIN): Add cast.
3509         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3510         (~tui_data_window): Simplify.
3511
3512 2019-06-25  Tom Tromey  <tom@tromey.com>
3513
3514         * tui/tui-layout.c (show_source_disasm_command)
3515         (show_source_or_disasm_and_command): Update.
3516         * tui/tui-io.c (update_cmdwin_start_line)
3517         (tui_redisplay_readline): Update.
3518         * tui/tui-data.h (struct tui_command_info): Remove.
3519         (struct tui_win_info) <detail>: Remove command_info member.
3520         (struct tui_data_window) <start_line>: New member, from
3521         tui_command_info.
3522         (TUI_CMD_WIN): Add casts.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-winsource.c (tui_update_source_window)
3527         (tui_refill_source_window)
3528         (tui_source_window_base::do_scroll_horizontal)
3529         (tui_update_breakpoint_info, tui_set_exec_info_content)
3530         (tui_show_exec_info_content, tui_erase_exec_info_content)
3531         (tui_clear_exec_info_content): Update.
3532         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3533         Update.
3534         * tui/tui-win.c (make_invisible_and_set_new_height)
3535         (make_visible_with_new_height): Update.
3536         * tui/tui-source.c (tui_set_source_content)
3537         (tui_show_symtab_source): Update.
3538         * tui/tui-layout.c (extract_display_start_addr)
3539         (show_source_disasm_command, show_data)
3540         (make_source_or_disasm_window)
3541         (show_source_or_disasm_and_command): Update.
3542         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3543         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3544         "gdbarch".
3545         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3546         to tui_source_window_base.
3547         (struct tui_win_info) <detail>: Remove source_info member.
3548         (struct tui_source_window_base) <has_locator>: Inline.
3549         Move contents from tui_source_info; rename has_locator member to
3550         m_has_locator.
3551         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3552         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3553         header file.
3554         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3555         Simplify.
3556         (tui_free_all_source_wins_content): Cast to
3557         tui_source_window_base.
3558
3559 2019-06-25  Tom Tromey  <tom@tromey.com>
3560
3561         * tui/tui-win.c (make_invisible_and_set_new_height)
3562         (make_visible_with_new_height): Call has_locator method.
3563         * tui/tui-layout.c (show_source_disasm_command, show_data)
3564         (show_source_or_disasm_and_command): Update for bool change.
3565         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3566         (tui_win_info) <has_locator>: New method.
3567         (struct tui_source_window_base) <has_locator>: New method.
3568         (tui_win_has_locator): Don't declare.
3569         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3570         from tui_win_has_locator.
3571         (tui_source_window_base): Use false, not FALSE.
3572
3573 2019-06-25  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3576         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3577         clear_detail method directly.
3578         (tui_clear_win_detail): Remove.
3579
3580 2019-06-25  Tom Tromey  <tom@tromey.com>
3581
3582         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3583         "this", not TUI_DISASM_WIN.
3584
3585 2019-06-25  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3588         declare.
3589         * tui/tui-winsource.c
3590         (tui_source_window_base::do_scroll_horizontal): Rename from
3591         tui_horizontal_source_scroll.
3592         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3593         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3594         from tui_vertical_data_scroll.
3595         * tui/tui-win.h (tui_scroll): Don't declare.
3596         * tui/tui-win.c (tui_win_info::forward_scroll)
3597         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3598         (tui_win_info::right_scroll): Rename and update.
3599         (tui_scroll_forward_command, tui_scroll_backward_command)
3600         (tui_scroll_left_command, tui_scroll_right_command): Update.
3601         (tui_scroll): Remove.
3602         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3603         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3604         from tui_vertical_source_scroll.
3605         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3606         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3607         from tui_vertical_disassem_scroll.
3608         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3609         do_scroll_horizontal>: New methods.
3610         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3611         Likewise.
3612         (struct tui_source_window_base): Add do_scroll_horizontal.
3613         (struct tui_source_window, struct tui_disasm_window): Add
3614         do_scroll_vertical.
3615         (struct tui_data_window, struct tui_cmd_window): Add
3616         do_scroll_horizontal and do_scroll_vertical.
3617         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3618
3619 2019-06-25  Tom Tromey  <tom@tromey.com>
3620
3621         * tui/tui-data.h (struct tui_source_window_base): New struct.
3622         (struct tui_source_window): Derive from tui_source_window_base.
3623         (struct tui_disasm_window): New struct.
3624         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3625         from tui_source_window::clear_detail.
3626         (tui_source_window_base): Rename from tui_source_window.
3627         (~tui_source_window_base): Rename from ~tui_source_window.
3628         (tui_alloc_win_info): Create a tui_disasm_window.
3629
3630 2019-06-25  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-data.h (struct tui_source_window)
3633         (struct tui_data_window): Declare destructors.
3634         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3635         destructors.
3636         (tui_win_info): Simplify.
3637
3638 2019-06-25  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-winsource.c (tui_display_main)
3641         (tui_update_source_windows_with_addr)
3642         (tui_update_all_breakpoint_info): Update.
3643         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3644         (new_height_ok, parse_scrolling_args): Update.
3645         * tui/tui-stack.c (tui_show_frame_info): Update.
3646         * tui/tui-data.h (struct tui_list): Remove.
3647         (tui_source_windows): Return a reference to a std::vector.
3648         * tui/tui-data.c (source_windows): Now a std::vector.
3649         (tui_source_windows): Change return type.
3650         (tui_clear_source_windows): Rewrite.
3651         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3652         (tui_free_all_source_wins_content): Rewrite.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3657         (struct tui_data_window, struct tui_cmd_window): Declare
3658         clear_detail method.
3659         * tui/tui-data.c (tui_source_window::clear_detail)
3660         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3661         methods.
3662         (tui_clear_win_detail): Simplify.
3663
3664 2019-06-25  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-layout.c (make_source_window, make_disasm_window)
3667         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3668         Return the new window.
3669         (show_source_disasm_command, show_data)
3670         (show_source_or_disasm_and_command): Update.
3671
3672 2019-06-25  Tom Tromey  <tom@tromey.com>
3673
3674         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3675         parameter.  Return the new window.
3676         (show_source_disasm_command): Update and remove NULL check.
3677         (show_source_or_disasm_and_command): Update.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3682
3683 2019-06-25  Tom Tromey  <tom@tromey.com>
3684
3685         * tui/tui-data.h (struct tui_win_info): Make constructor
3686         protected.  Make destructor virtual.  Add initializers.
3687         (tui_source_window, tui_data_window, tui_cmd_window): New
3688         classes.
3689         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3690         constructor.  Add "type" parameter.
3691         (tui_source_window, tui_data_window, tui_cmd_window): New
3692         constructors.
3693         (tui_alloc_win_info): Instantiate the appropriate subclass.
3694
3695 2019-06-25  Tom Tromey  <tom@tromey.com>
3696
3697         * tui/tui-win.c (tui_resize_all): Use delete.
3698         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3699         destructor.
3700         (tui_free_window): Don't declare.
3701         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3702         Update.
3703
3704 2019-06-25  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-data.h (struct tui_win_info): Add constructor.
3707         * tui/tui-data.c (tui_alloc_win_info): Use new.
3708         (tui_free_window): Use delete.
3709
3710 2019-06-22  Tom Tromey  <tom@tromey.com>
3711
3712         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3713         declare.
3714         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3715
3716 2019-06-22  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3719         declare.
3720         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3721
3722 2019-06-22  Tom de Vries  <tdevries@suse.de>
3723
3724         * dwarf2read.c (create_addrmap_from_aranges)
3725         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3726         instead of '%zu'.
3727
3728 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3729
3730         * dwarf2read.h (dwarf2_section_info_def): Remove.
3731         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3732         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3733         std::vector<dwarf2_section_info>.
3734         (struct dwo_file) <~dwo_file>: Remove.
3735         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3736         types field.
3737         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3738         (dwarf2_read_debug_names): Likewise.
3739         (create_debug_types_hash_table): Change parameter type to
3740         array_view, adjust code accordingly.
3741         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3742         (partial_die_info::fixup): Likewise.
3743         (determine_prefix): Likewise.
3744         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3745
3746 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3747
3748         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3749         gdb_bfd_ref_ptr.
3750         <~dwo_file>: Remove call to gdb_bfd_unref.
3751         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3752         gdb_bfd_ref_ptr::get.
3753
3754 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3755
3756         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3757         type to htab_up.
3758         * dwarf2read.c (struct dwo_file): Initialize fields.
3759         <~dwo_file>: New.
3760         (free_dwo_file): Remove, move content to ~dwo_file.
3761         (struct dwo_file_deleter): Remove.
3762         (dwo_file_up>: Remove custom deleter.
3763         (free_dwo_files): Remove.
3764         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3765         dwo_files.
3766         (process_skeletonless_type_units): Call unique_ptr::get.
3767         (allocate_dwo_file_hash_table): Add deleter to created hash
3768         table.  Change return type to htab_up.
3769         (lookup_dwo_file_slot): Don't memset dwo_file, call
3770         unique_ptr::get.
3771         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3772         (create_dwo_unit_in_dwp_v2): Likewise.
3773         (open_and_init_dwo_file): Likewise.
3774         (free_dwo_file_from_slot): Remove.
3775
3776 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3777
3778         * dwarf2read.h (struct dwarf2_section_info) <readin,
3779         is_virtual>: Change type to bool.
3780         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3781         true instead of 1.
3782
3783 2019-06-19  Tom Tromey  <tom@tromey.com>
3784
3785         * tui/tui-data.h (tui_init_content_element): Don't declare.
3786
3787 2019-06-19  Tom Tromey  <tom@tromey.com>
3788
3789         * tui/tui-data.h (tui_init_win_info): Don't declare.
3790
3791 2019-06-19  Tom de Vries  <tdevries@suse.de>
3792
3793         * dwarf2read.h (abstract_to_concrete): Change type to
3794         std::unordered_map<sect_offset, std::vector<sect_offset>,
3795         gdb::hash_enum<sect_offset>>.
3796
3797 2019-06-19  Tom Tromey  <tromey@adacore.com>
3798
3799         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3800         EVAL_AVOID_SIDE_EFFECTS specially.
3801
3802 2019-06-19  Tom Tromey  <tromey@adacore.com>
3803
3804         * source-cache.c (highlighter): New global.
3805         (source_cache::get_source_lines): Create a highlighter on demand.
3806
3807 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * defs.h (deprecated_interactive_hook): Delete declaration.
3810         * interps.c (clear_interpreter_hooks): Remove use of
3811         deprecated_interactive_hook.
3812         * top.c (deprecated_interactive_hook): Delete definition.
3813         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3814
3815 2019-06-18  Tom de Vries  <tdevries@suse.de>
3816
3817         PR gdb/24515
3818         * dwarf2read.h (abstract_to_concrete): Change type from
3819         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3820         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3821         * dwarf2read.c (read_variable): Update.
3822         (dwarf2_fetch_die_loc_sect_off): Update.
3823
3824 2019-06-17  Tom de Vries  <tdevries@suse.de>
3825
3826         PR gdb/24617
3827         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3828         accessing parent[parent_len - 1].
3829
3830 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3831
3832         PR gdb/24364
3833         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3834         call dtrace_process_dof with NULL dof.
3835
3836 2019-06-16  Tom de Vries  <tdevries@suse.de>
3837
3838         PR gdb/24445
3839         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3840
3841 2019-06-16  Tom Tromey  <tom@tromey.com>
3842
3843         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3844         (make_all_visible): Use address of member.
3845
3846 2019-06-16  Tom Tromey  <tom@tromey.com>
3847
3848         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3849         (tui_free_window, free_content, free_content_elements): Remove
3850         unnecessary cast.
3851         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3852         cast.
3853         * tui/tui-regs.c (tui_show_register_group)
3854         (tui_display_registers_from, tui_display_reg_element_at_line):
3855         Remove unnecessary cast.
3856
3857 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3858
3859         * linux-nat.c (normal_mask): Delete.
3860         (_initialize_linux_nat): Don't initialise normal_mask.
3861
3862 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3863
3864         PR gdb/24445
3865         * dwarf-index-write.h (write_psymtabs_to_index): Add
3866         dwz_basename parameter.
3867         * dwarf-index-write.c (write_gdbindex): Move file writing to
3868         write_gdbindex_1.  Change return type void.
3869         (assert_file_size): Move up, remove filename parameter.
3870         (write_gdbindex_1): New function.
3871         (write_debug_names): Change return type to void, call
3872         assert_file_size.
3873         (struct index_wip_file): New struct.
3874         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3875         file logic to index_wip_file.  Write index for dwz file if
3876         needed.
3877         (save_gdb_index_command): Pass basename of dwz file, if present.
3878         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3879         build-id of dwz file, if present.
3880         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3881         (dwarf2_get_dwz_file): Likewise.
3882         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3883         (dwarf2_get_dwz_file): Likewise.
3884
3885 2019-06-16  Tom Tromey  <tom@tromey.com>
3886
3887         * coffread.c (process_coff_symbol): Use xstrdup.
3888         * value.c (create_internalvar): Use xstrdup.
3889
3890 2019-06-16  Tom Tromey  <tom@tromey.com>
3891
3892         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3893         * breakpoint.c (stopin_command, stopat_command)
3894         (until_break_command, decode_location_default): Remove unnecessary
3895         cast.
3896         * utils.c (subset_compare): Remove unnecessary cast.
3897         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3898         cast.
3899         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3900         cast.
3901         * infcmd.c (path_command): Remove unnecessary cast.
3902         * coffread.c (decode_type): Remove unnecessary cast.
3903         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3904         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3905         * tui/tui-stack.c (tui_show_locator_content)
3906         (tui_show_frame_info): Remove unnecessary cast.
3907         * tui/tui-win.c (tui_scroll_forward_command)
3908         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3909         (parse_scrolling_args): Remove unnecessary cast.
3910         * tui/tui-data.c (init_win_info, tui_del_window)
3911         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3912         (free_content_elements): Remove unnecessary cast.
3913         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3914         unnecessary cast.
3915         * tui/tui-source.c (tui_set_source_content)
3916         (tui_vertical_source_scroll): Remove unnecessary cast.
3917         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3918         cast.
3919         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3920         * tui/tui-regs.c (tui_display_registers_from)
3921         (tui_display_register): Remove unnecessary cast.
3922         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3923         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3924         (make_visible): Remove unnecessary cast.
3925         * tui/tui-winsource.c (tui_erase_source_content)
3926         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3927         unnecessary cast.
3928         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3929         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3930         * stabsread.c (read_type, read_array_type, read_range_type):
3931         Remove unnecessary cast.
3932         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3933         (parse_symbol, parse_type, upgrade_type, parse_external)
3934         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3935         unnecessary cast.
3936         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3937
3938 2019-06-16  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-data.c (tui_alloc_generic_win_info)
3941         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3942         checks.
3943
3944 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3945             Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * f-typeprint.c (f_print_type): Don't return early for not
3948         associated or not allocated types.
3949         (f_type_print_varspec_suffix): Add print_rank parameter and print
3950         ranks of array types in case they dangling.
3951         (f_type_print_base): Add print_rank parameter.
3952
3953 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3954
3955         * NEWS: Mention new MI commands.
3956         * break-catch-throw.c (enum exception_event_kind): Move to
3957         breakpoint.h.
3958         (print_mention_exception_catchpoint): Output text as a single
3959         message.
3960         (catch_exception_command_1): Rename to...
3961         (catch_exception_event): ...this, make non-static, update header
3962         command, and change some parameter types.
3963         (catch_catch_command): Update for changes to
3964         catch_exception_command_1.
3965         (catch_throw_command): Likewise.
3966         (catch_rethrow_command): Likewise.
3967         * breakpoint.c (enum exception_event_kind): Delete.
3968         * breakpoint.h (enum exception_event_kind): Moved here from
3969         break-catch-throw.c.
3970         (catch_exception_event): Declare.
3971         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3972         (mi_cmd_catch_throw): New function.
3973         (mi_cmd_catch_rethrow): New function.
3974         (mi_cmd_catch_catch): New function.
3975         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3976         'catch-catch' entries.
3977         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3978         (mi_cmd_catch_rethrow): Declare.
3979         (mi_cmd_catch_catch): Declare.
3980
3981 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3982
3983         * annotate.c (annotate_source_line): Change return type to void,
3984         update implementation to match.
3985         * annotate.h (annotate_source_line): Change return type to void,
3986         update header comment.
3987         * stack.c (print_frame_info): Don't change what frame information
3988         is printed based on whether annotations are on or not.
3989
3990 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3991
3992         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3993         (annotate_source): Make static.
3994         (annotate_source_line): Moved from source.c and renamed from
3995         identify_source_line.  Update the return type.
3996         * annotate.h (annotate_source): Delete declaration.
3997         (annotate_source_line): Declaration moved from source.h, and
3998         renamed from identify_source_line.  Return type updated.
3999         * source.c (identify_source_line): Moved to annotate.c and renamed
4000         to annotate_source_line.
4001         (info_line_command): Remove check of annotation_level.
4002         * source.h (identify_source_line): Move declaration to annotate.h
4003         and rename to annotate_source_line.
4004         * stack.c: Add 'annotate.h' include.
4005         (print_frame_info): Remove check of annotation_level before
4006         calling annotate_source_line.
4007
4008 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * source-cache.c (source_cache::get_plain_source_lines): Use
4011         open_source_file_with_line_charpos instead of just
4012         open_source_file, remove call to find_source_lines.
4013         (source_cache::get_source_lines): Likewise.
4014         * source.c (find_source_lines): Make static.
4015         (get_filename_and_charpos): Renamed into...
4016         (open_source_file_with_line_charpos): ..this along with changes to
4017         return a scoped_fd, and some other minor clean ups.
4018         (identify_source_line): Use open_source_file_with_line_charpos.
4019         (search_command_helper): Use open_source_file_with_line_charpos
4020         instead of just open_source_file, remove call to
4021         find_source_lines.
4022         * source.h (open_source_file_with_line_charpos): Declare new
4023         function.
4024         (find_source_lines): Delete declaration.
4025
4026 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * source.c (get_filename_and_charpos): Remove fullname
4029         parameter.
4030         (identify_source_line): Update call to get_filename_and_charpos.
4031
4032 2019-06-14  Tom Tromey  <tromey@adacore.com>
4033
4034         PR gdb/24502:
4035         * ui-style.h (skip_ansi_escape): Update comment.
4036         * ui-file.h (class no_terminal_escape_file): New class.
4037         * ui-file.c (no_terminal_escape_file::write)
4038         (no_terminal_escape_file::puts): New methods.
4039         * cli/cli-logging.c (handle_redirections): Use
4040         no_terminal_escape_file.
4041
4042 2019-06-14  Tom Tromey  <tromey@adacore.com>
4043
4044         * NEWS: Move convenience variable news above Python news.
4045
4046 2019-06-14  Tom Tromey  <tom@tromey.com>
4047
4048         * gnulib: Move directory to top-level.
4049         * configure.ac: Don't configure gnulib.
4050         * configure: Rebuild.
4051         * common/common-defs.h: Use new path to gnulib.
4052         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4053         (GNULIB_H): Remove.
4054         (INCGNU): Look in new gnulib location.
4055         (HFILES_NO_SRCDIR): Remove gnulib files.
4056         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4057         (generated_files): Remove GNULIB_H.
4058         ($(LIBGNU), all-lib): Remove targets.
4059         (distclean): Don't mention GNULIB_BUILDDIR.
4060         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4061
4062 2019-06-14  Tom Tromey  <tromey@adacore.com>
4063
4064         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4065         Warn if symbol file does not provide any symbols.
4066
4067 2019-06-14  Tom Tromey  <tromey@adacore.com>
4068
4069         * source.c (find_and_open_source): Respect basenames_may_differ.
4070
4071 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4072
4073         * annotate.c (annotate_breakpoints_invalid): Make use of
4074         scoped_restore_terminal_state.
4075         (annotate_frames_invalid): Likewise.
4076
4077 2019-06-14  Tom Tromey  <tromey@adacore.com>
4078
4079         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4080         allow assignment to an internalvar.
4081
4082 2019-06-14  Tom Tromey  <tromey@adacore.com>
4083
4084         * ada-lex.l: Allow "_" in attribute names.
4085
4086 2019-06-14  Tom Tromey  <tromey@adacore.com>
4087
4088         PR gdb/24653:
4089         * regcache.c (registers_changed): Don't call alloca.
4090         * top.c (execute_command): Don't call alloca.
4091
4092 2019-06-13  Pedro Alves  <palves@redhat.com>
4093
4094         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4095         'expression'.  When parsing an expression, error out if there's
4096         junk after "unlimited".
4097         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4098         (do_set_command): Adjust calls to is_unlimited_literal.
4099
4100 2019-06-13  Pedro Alves  <palves@redhat.com>
4101
4102         * compile/compile.c (make_compile_options_def_group): Add braces
4103         around array_view initializer.
4104         * thread.c (make_thread_apply_all_options_def_group)
4105         (make_thread_apply_all_options_def_group): Likewise.
4106
4107 2019-06-13  Pedro Alves  <palves@redhat.com>
4108
4109         * NEWS (New commands): Mention "maint test-options
4110         require-delimiter", "maint test-options unknown-is-error", "maint
4111         test-options unknown-is-operand" and "maint show
4112         test-options-completion-result".
4113         (New command options, command completion): New section.
4114         (Completion improvements): New section.
4115         Mention that you can abbreviate "unlimited".
4116
4117 2019-06-13  Pedro Alves  <palves@redhat.com>
4118
4119         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4120         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4121         * unittests/cli-utils-selftests.c (test_parse_flags)
4122         (test_parse_flags_qcs): Delete.
4123         (test_cli_utils): Don't call deleted functions.
4124
4125 2019-06-13  Pedro Alves  <palves@redhat.com>
4126
4127         * thread.c: Include "cli/cli-option.h".
4128         (tp_array_compar_ascending): Global.
4129         (tp_array_compar): Delete function.
4130         (tp_array_compar_ascending, tp_array_compar_descending): New
4131         functions.
4132         (ascending_option_def, qcs_flag_option_def)
4133         (thr_qcs_flags_option_defs)
4134         (make_thread_apply_all_options_def_group)
4135         (make_thread_apply_options_def_group): New.
4136         (thread_apply_all_command): Use gdb::option::process_options.
4137         (thread_apply_command_completer)
4138         (thread_apply_all_command_completer): New.
4139         (thread_apply_command): Use gdb::option::process_options.
4140         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4141         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4142         to generate help text of "thread apply".  Adjust "taas"'s help.
4143         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4144         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4145
4146 2019-06-13  Pedro Alves  <palves@redhat.com>
4147
4148         * thread.c (thread_apply_command): Check for invalid TID with
4149         isdigit instead of !isalpha.
4150
4151 2019-06-13  Pedro Alves  <palves@redhat.com>
4152
4153         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4154         (validate_flags_qcs): New.
4155         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4156         (validate_flags_qcs): Declare.
4157         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4158         (make_frame_apply_options_def_group): New.
4159         (frame_apply_command_count): Process options with
4160         gdb::option::process_options.
4161         (frame_apply_completer): New.
4162         (frame_apply_level_completer, frame_apply_all_completer)
4163         (frame_apply_completer): New.
4164         (_initialize_stack): Update help of "frame apply", "frame apply
4165         level", "frame apply all" and "faas" to mention supported options
4166         and install command completers.
4167         * stack.h (frame_apply_all_completer): Declare.
4168         * thread.c: Include "stack.h".
4169         (tfaas_command): Add "--".
4170         (_initialize_thread): Update help "tfaas" to mention supported
4171         options and install command completer.
4172
4173 2019-06-13  Pedro Alves  <palves@redhat.com>
4174
4175         * completer.c (complete_nested_command_line): New.
4176         (gdb_completion_word_break_characters_throw): Add assertion.
4177         * completer.h (complete_nested_command_line): Declare.
4178
4179 2019-06-13  Pedro Alves  <palves@redhat.com>
4180
4181         * stack.c (parse_backtrace_qualifiers): New.
4182         (backtrace_command): Use it.
4183         (backtrace_command_completer): Complete on qualifiers.
4184
4185 2019-06-13  Pedro Alves  <palves@redhat.com>
4186
4187         * frame.c: Include "cli/cli-option.h.
4188         (user_set_backtrace_options): New.
4189         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4190         Delete.
4191         (get_prev_frame): Adjust.
4192         (boolean_option_def, uinteger_option_def)
4193         (set_backtrace_option_defs): New.
4194         (_initialize_frame): Adjust and use
4195         gdb::option::add_setshow_cmds_for_options to install "set
4196         backtrace past-main" and "set backtrace past-entry".
4197         * frame.h: Include "cli/cli-option.h".
4198         (struct frame_print_options): Forward declare.
4199         (print_frame_arguments_all, print_frame_arguments_scalars)
4200         (print_frame_arguments_none): Declare.
4201         (print_entry_values): Delete declaration.
4202         (struct frame_print_options, user_frame_print_options): New.
4203         (struct set_backtrace_options): New.
4204         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4205         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4206         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4207         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4208         (list_args_or_locals): Add frame_print_options parameter.
4209         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4210         * python/py-framefilter.c (enumerate_args): Pass down
4211         USER_FRAME_PRINT_OPTIONS.
4212         * stack.c: Include "cli/cli-option.h".
4213         (print_frame_arguments_all, print_frame_arguments_scalars)
4214         (print_frame_arguments_none): Declare.
4215         (print_raw_frame_arguments, print_entry_values): Delete.
4216         (user_frame_print_options): New.
4217         (boolean_option_def, enum_option_def, frame_print_option_defs):
4218         New.
4219         (struct backtrace_cmd_options): New.
4220         (bt_flag_option_def): New.
4221         (backtrace_command_option_defs): New.
4222         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4223         (print_frame_arg, read_frame_arg, print_frame_args)
4224         (print_frame_info, print_frame): Add frame_print_options parameter
4225         and use it.
4226         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4227         (backtrace_command_1): Add frame_print_options and
4228         backtrace_cmd_options parameters and use them.
4229         (make_backtrace_options_def_group): New.
4230         (backtrace_command): Process command options with
4231         gdb::option::process_options.
4232         (backtrace_command_completer): New.
4233         (_initialize_stack): Extend "backtrace"'s help to mention
4234         supported options.  Install completer for "backtrace".
4235         Install some settings commands with add_setshow_cmds_for_options.
4236
4237 2019-06-13  Pedro Alves  <palves@redhat.com>
4238
4239         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4240         and that "set/show print raw frame-arguments" are now deprecated.
4241
4242         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4243         command.
4244         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4245         * stack.c (_initialize_stack): Install "set/show print
4246         raw-frame-arguments", and deprecate "set/show print raw
4247         frame-arguments".
4248         * valprint.c (_initialize_valprint): Deprecate "set/show print
4249         raw".
4250
4251 2019-06-13  Pedro Alves  <palves@redhat.com>
4252
4253         * compile/compile.c (struct compile_options): New.
4254         (compile_flag_option_def, compile_command_option_defs)
4255         (make_compile_options_def_group): New.
4256         (compile_file_command): Handle options with
4257         gdb::option::process_options.
4258         (compile_file_command_completer): New function.
4259         (compile_code_command): Handle options with
4260         gdb::option::process_options.
4261         (compile_code_command_completer): New function.
4262         (_initialize_compiler): Install completers for "compile code" and
4263         "compile file".  Mention available options in "compile code" and
4264         "compile code"'s help.
4265         * completer.c (advance_to_completion_word): New, factored out from
4266         ...
4267         (advance_to_expression_complete_word_point): ... this.
4268         (advance_to_filename_complete_word_point): New.
4269         * completer.h (advance_to_filename_complete_word_point): New
4270         declaration.
4271
4272 2019-06-13  Pedro Alves  <palves@redhat.com>
4273
4274         * compile/compile.c: Include "cli/cli-option.h".
4275         (compile_print_value): Scope data pointer is now a
4276         value_print_options pointer; adjust.
4277         (compile_print_command): Process options.  Scope data pointer is
4278         now a value_print_options pointer; adjust.
4279         (_initialize_compile): Update "compile print"'s help to include
4280         supported options.  Install a completer for "compile print".
4281         * cp-valprint.c (show_vtblprint, show_objectprint)
4282         (show_static_field_print): Delete.
4283         (_initialize_cp_valprint): Don't install "set print
4284         static-members", "set print vtbl", "set print object" here.
4285         * printcmd.c: Include "cli/cli-option.h" and
4286         "common/gdb_optional.h".
4287         (print_command_parse_format): Rework to fill in a
4288         value_print_options instead of a format_data.
4289         (print_value): Change parameter type from format_data pointer to
4290         value_print_options reference.  Adjust.
4291         (print_command_1): Process options.  Adjust to pass down a
4292         value_print_options.
4293         (print_command_completer): New.
4294         (_initialize_printcmd): Install print_command_completer as
4295         handle_brkchars completer for the "print" command.  Update
4296         "print"'s help to include supported options.
4297         * valprint.c: Include "cli/cli-option.h".
4298         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4299         here from cp-valprint.c.
4300         (boolean_option_def, uinteger_option_def)
4301         (value_print_option_defs, make_value_print_options_def_group):
4302         New.  Use gdb::option::add_setshow_cmds_for_options to install
4303         "set print elements", "set print null-stop", "set print repeats",
4304         "set print pretty", "set print union", "set print array", "set
4305         print address", "set print symbol", "set print array-indexes".
4306         * valprint.h: Include <string> and "cli/cli-option.h".
4307         (make_value_print_options_def_group): Declare.
4308         (print_value): Change parameter type from format_data pointer to
4309         value_print_options reference.
4310         (print_command_completer): Declare.
4311
4312 2019-06-13  Pedro Alves  <palves@redhat.com>
4313
4314         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4315         (COMMON_SFILES): Add maint-test-settings.c.
4316         * cli/cli-decode.c (boolean_enums): New global, factored out from
4317         ...
4318         (add_setshow_boolean_cmd): ... here.
4319         * cli/cli-decode.h (boolean_enums): Declare.
4320         * cli/cli-option.c: New file.
4321         * cli/cli-option.h: New file.
4322         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4323         factored out from ...
4324         (parse_cli_boolean_value(const char *)): ... this.
4325         (is_unlimited_literal): Change parameter type to pointer to
4326         pointer.  Adjust and advance ARG pointer.
4327         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4328         (parse_cli_var_enum): New, factored out from ...
4329         (do_set_command): ... this.  Adjust.
4330         * cli/cli-setshow.h (parse_cli_boolean_value)
4331         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4332         (parse_cli_var_enum): Declare.
4333         * cli/cli-utils.c: Include "cli/cli-option.h".
4334         (get_ulongest): New.
4335         * cli/cli-utils.h (get_ulongest): Declare.
4336         (check_for_argument): New overloads.
4337         * maint-test-options.c: New file.
4338
4339 2019-06-13  Pedro Alves  <palves@redhat.com>
4340
4341         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4342         parse a range if "-" is at the end of the string.
4343
4344 2019-06-13  Pedro Alves  <palves@redhat.com>
4345
4346         * cli/cli-setshow.c (parse_auto_binary_operation)
4347         (parse_cli_boolean_value): Don't allow "o".
4348
4349 2019-06-13  Pedro Alves  <palves@redhat.com>
4350
4351         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4352         * NEWS: Mention maint test-settings KIND.
4353         * maint-test-settings.c: New file.
4354
4355 2019-06-13  Pedro Alves  <palves@redhat.com>
4356
4357         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4358         completer.
4359         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4360         "set" completers.
4361
4362 2019-06-13  Pedro Alves  <palves@redhat.com>
4363
4364         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4365         after item.
4366
4367 2019-06-13  Pedro Alves  <palves@redhat.com>
4368
4369         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4370
4371 2019-06-13  Pedro Alves <palves@redhat.com>
4372
4373         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4374         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4375         call.
4376         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4377         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4378         calls.
4379         (check_for_argument): Skip spaces after argument.
4380
4381 2019-06-13  Pedro Alves  <palves@redhat.com>
4382
4383         * thread.c (thread_apply_command): Adjust TID parsing.
4384         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4385         detected before end of string.
4386         (tid_is_in_list): Error out if LIST is invalid.
4387
4388 2019-06-13  Pedro Alves  <palves@redhat.com>
4389
4390         * completer.c (complete_line_internal_1): Rewind completion word
4391         point.
4392         (completion_tracker::advance_custom_word_point_by): Change
4393         parameter type to int.
4394         * completer.h (completion_tracker::advance_custom_word_point_by):
4395         Likewise.
4396
4397 2019-06-13  Pedro Alves  <palves@redhat.com>
4398
4399         * completer.c (advance_to_completion_word): Handle delimiters.
4400
4401 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4402
4403         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4404
4405 2019-06-11  Tom Tromey  <tom@tromey.com>
4406
4407         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4408         (xmalloc_failed): Move to alloc.c.
4409         * alloc.c: New file.
4410         * Makefile.in (COMMON_SFILES): Add alloc.c.
4411
4412 2019-06-11  Tom Tromey  <tom@tromey.com>
4413
4414         * nat/linux-waitpid.c: Don't include server.h.
4415         (linux_debug): Remove.
4416         (my_waitpid): Update.
4417
4418 2019-06-11  Tom Tromey  <tromey@adacore.com>
4419
4420         * infcall.c (_initialize_infcall): Remove trailing newline from
4421         help.
4422         * user-regs.c (_initialize_user_regs): Remove trailing newline
4423         from help.
4424         * typeprint.c (_initialize_typeprint): Remove trailing newline
4425         from help.
4426         * reverse.c (_initialize_reverse): Remove trailing newlines from
4427         help.
4428         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4429         from help.
4430         * language.c (add_set_language_command): Remove trailing newline
4431         from help.
4432         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4433         help.
4434         * disasm.c (_initialize_disasm): Remove trailing newline from
4435         help.
4436         * top.c (init_main): Remove trailing newline from help.
4437         * interps.c (_initialize_interpreter): Remove trailing newline
4438         from help.
4439         * btrace.c (_initialize_btrace): Remove trailing newlines from
4440         help.
4441         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4442         from help.
4443         * python/python.c (_initialize_python): Remove trailing newline
4444         from help.
4445         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4446         help.
4447         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4448         from help.  Reformat some text.
4449         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4450         from help.
4451         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4452         newline from help.
4453
4454 2019-06-11  Tom Tromey  <tromey@adacore.com>
4455
4456         * darwin-nat.c (darwin_decode_exception_message)
4457         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4458
4459 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * valops.c (value_slice): Check for not allocated or not
4462         associated values.
4463
4464 2019-06-10  Tom de Vries  <tdevries@suse.de>
4465
4466         PR gdb/24618
4467         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4468         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4469         invalid.
4470
4471 2019-06-10  Tom de Vries  <tdevries@suse.de>
4472
4473         PR gdb/24611
4474         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4475         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4476
4477 2019-06-10  Tom de Vries  <tdevries@suse.de>
4478
4479         PR symtab/24545
4480         * symtab.c (struct demangled_name_entry): Add language field.
4481         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4482         static minimal symbol".  Set and use language field.
4483
4484 2019-06-10  Tom Tromey  <tromey@adacore.com>
4485
4486         * ada-lang.c (_initialize_ada_language): Update help text.
4487
4488 2019-06-10  Tom Tromey  <tromey@adacore.com>
4489
4490         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4491         with a newline.
4492         * guile/guile.c (handle_boot_error): Don't end warning with a
4493         newline.
4494         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4495         warning with a newline.
4496         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4497         newline.
4498         (s12z_frame_cache): Likewise.
4499         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4500         a newline.
4501         * solib-svr4.c (disable_probes_interface): Don't end warning with
4502         a newline.
4503         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4504         newline.
4505         * python/python.c (do_finish_initialization): Don't end warning
4506         with a newline.
4507
4508 2019-06-10  Tom Tromey  <tom@tromey.com>
4509
4510         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4511         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4512         gdbpy_enter.
4513
4514 2019-06-10  Tom Tromey  <tromey@adacore.com>
4515
4516         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4517         data.
4518         (elf_new_init): Don't call stabsread_new_init.
4519         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4520         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4521         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4522
4523 2019-06-10  Tom de Vries  <tdevries@suse.de>
4524
4525         PR symtab/16264
4526         PR symtab/24517
4527         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4528
4529 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4530
4531         * source.c (find_and_open_source): Also rewrite relative file
4532         names.
4533
4534 2019-04-26  Amos Bird  <amosbird@gmail.com>
4535
4536         * annotate.c (annotate_thread_exited): Add "thread-exited"
4537         annotation.
4538
4539 2019-06-06  Tom Tromey  <tromey@adacore.com>
4540
4541         * maint.h (class scoped_command_stats): Use
4542         DISABLE_COPY_AND_ASSIGN.
4543         <print_time>: New method.
4544         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4545         print_time.
4546         (scoped_command_stats::print_time): New method.
4547
4548 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4549
4550         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4551         instructions of lengths 6 or 8 bytes.
4552
4553 2019-06-04  Pedro Alves  <palves@redhat.com>
4554
4555         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4556
4557         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4558         * breakpoint.c (condition_completer): Likewise.
4559         * cli/cli-dump.c (scan_expression): Likewise.
4560         * common/filestuff.c (mkdir_recursive): Likewise.
4561         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4562         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4563         (gdb_abspath): Likewise.
4564         * compile/compile-cplus-types.c
4565         (compile_cplus_instance::decl_name): Likewise.
4566         * completer.c (complete_explicit_location):
4567         (signal_completer, reg_or_group_completer_1): Likewise.
4568         * cp-support.c (cp_remove_params_if_any): Likewise.
4569         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4570         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4571         * infcmd.c (strip_bg_char): Likewise.
4572         * linespec.c (copy_token_string): Likewise.
4573         * mi/mi-main.c (output_cores): Likewise.
4574         * psymtab.c (psymtab_search_name):
4575         * symfile.c (test_set_ext_lang_command): Likewise.
4576         * target.c (target_fileio_read_stralloc): Likewise.
4577         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4578         * value.c (complete_internalvar): Likewise.
4579
4580 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4581
4582         Add objfile property to gdb.Type.
4583         * NEWS: Mention Python API addition.
4584         * python/py-type.c (typy_get_objfile): New method.
4585
4586 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4587
4588         * NEWS: Mention the new set|show style [title|highlight].
4589         Mention changes to "show style", "help" and "apropos".
4590
4591 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4592
4593         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4594         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4595         instead of print_help_for_command.
4596         (print_doc_of_command): New function.
4597         (help_list): Add 'apropos -v word' suggestion.
4598         (print_help_for_command): Style the command name using title style.
4599         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4600         (_initialize_cli_cmds): Describe -v in apropos_command help.
4601
4602 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4603
4604         * cli/cli-style.h (cli_style_option): Add name in constructor,
4605         add m_name class member, add constructor with intensity,
4606         add name class function.
4607         (cli_style_option::add_setshow_commands): Remove name argument.
4608         (highlight_style, title_style): New styles.
4609         * cli/cli-style.c (do_show): New function that shows a style
4610         characteristic styling the style name with itself.
4611         (set_style_name): New function.
4612         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4613         Update all callers according to the changes in cli/cli-style.h.
4614         * utils.h (fputs_highlighted): New function.
4615         * utils.c (fputs_highlighted): Likewise.
4616
4617 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4618
4619         * NEWS: Mention new pipe command and new convenience variables.
4620
4621 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4622
4623         * cli/cli-cmds.c (pipe_command): New function.
4624         (_initialize_cli_cmds): Call add_com for pipe_command.
4625         Define | as an alias for pipe.
4626         (exit_status_set_internal_vars): New function.
4627         (shell_escape): Call exit_status_set_internal_vars.
4628         cli/cli-decode.c (find_command_name_length): Recognize | as
4629         a single character command.
4630
4631 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4632
4633         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4634         top.c (execute_command_to_ui_file): New function, mostly a copy
4635         of execute_command_to_string.
4636         (execute_command_to_string): Implement by calling
4637         execute_command_to_ui_file.
4638
4639 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4640
4641         * top.h (saved_command_line): Remove declaration.
4642         * top.c (previous_saved_command_line, previous_repeat_arguments):
4643         New variables.
4644         (saved_command_line): Make static, define together with other
4645         'repeat variables'.
4646         (dont_repeat): Clear repeat_arguments.
4647         (repeat_previous, get_saved_command_line, save_command_line):
4648         New functions.
4649         (gdb_init): Initialize saved_command_line
4650         and previous_saved_command_line.
4651         * main.c (captured_main_1): Remove saved_command_line initialization.
4652         * event-top.c (handle_line_of_input): Update to use
4653         the new 'repeat' related functions instead of direct access to
4654         saved_command_line.
4655         * command.h (repeat_previous, get_saved_command_line,
4656         save_command_line): New declarations.
4657         (dont_repeat): Add comment.
4658
4659 2019-05-30  Tom Tromey  <tromey@adacore.com>
4660
4661         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4662         Fix comment.
4663         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4664
4665 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4666
4667         PR cli/24587
4668         * completer.c (complete): Initialize variable word.
4669
4670 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4671
4672         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4673         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4674         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4675         'body' is NULL to the outter 'if', protecting the '!is_define'
4676         situation as well.
4677
4678 2019-05-29  Tom Tromey  <tromey@adacore.com>
4679
4680         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4681         (dwarf_unknown): New function.
4682         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4683         (dwarf_type_encoding_name): Use dwarf_unknown.
4684
4685 2019-05-29  Tom Tromey  <tromey@adacore.com>
4686
4687         PR c++/20020:
4688         * cp-valprint.c (cp_print_value_fields): Call
4689         cp_print_static_field inside "try".
4690
4691 2019-05-29  Tom Tromey  <tromey@adacore.com>
4692
4693         * inflow.c (struct terminal_info): Add default operator=.
4694         * configure: Rebuild.
4695         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4696         -Wdeprecated-copy-dtor, -Wredundant-move.
4697
4698 2019-05-29  Tom Tromey  <tromey@adacore.com>
4699
4700         * NEWS: Add entry.
4701         * infcmd.c (print_return_value_1): Handle finish_print
4702         option.
4703         (show_print_finish): New function.
4704         (_initialize_infcmd): Add "set/show print finish" commands.
4705         * valprint.c (user_print_options): Initialize new member.
4706         * valprint.h (struct value_print_options) <finish_print>: New
4707         member.
4708
4709 2019-05-28  Tom Tromey  <tromey@adacore.com>
4710
4711         * ada-lang.c (ada_remove_Xbn_suffix)
4712         (find_old_style_renaming_symbol)
4713         (parse_old_style_renaming): Remove.
4714         (ada_find_renaming_symbol): Don't call
4715         find_old_style_renaming_symbol.
4716         (ada_is_renaming_symbol): Rename from
4717         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4718         bool.  Now static.
4719         (ada_read_var_value): Update and simplify.
4720         * ada-exp.y (write_var_or_type): Remove old code.
4721
4722 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4723
4724         * event-top.c: Remove include comment.
4725         * inflow.c (class scoped_ignore_sigttou): Move from here...
4726         * inflow.h (class scoped_ignore_sigttou): ...to here.
4727         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4728         * top.c:  Remove include comment.
4729
4730 2019-05-27  Tom Tromey  <tom@tromey.com>
4731
4732         * NEWS: Fix typo.
4733
4734 2019-05-22  Tom Tromey  <tromey@adacore.com>
4735
4736         * target.c (target_follow_exec): Constify parameter.
4737         * target-delegates.c: Rebuild.
4738         * remote.c (remote_target::follow_exec): Constify parameter.
4739         * infrun.c (follow_exec): Constify parameter.
4740         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4741         (target_follow_exec): Likewise.
4742
4743 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4744
4745         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4746         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4747
4748 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4749
4750         * NEWS: Add debugredirect and testsuite sections.
4751
4752 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4753
4754         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4755         target descriptions using exclusively floating point register name
4756         aliases.
4757
4758 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         PR gdb/18644:
4761         * f-lang.c (build_fortran_types): Handle the case where
4762         gdbarch_floatformat_for_type returns a nullptr.
4763
4764 2019-05-21  Tom de Vries  <tdevries@suse.de>
4765
4766         PR cli/24587
4767         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4768
4769 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         PR gdb/18644:
4772         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4773         16-byte floats.
4774         * i386-tdep.c (i386_floatformat_for_type): Use
4775         floatformats_ia64_quad for the 16-byte floating point component
4776         within a fortran 32-byte complex number.
4777
4778 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4781         delete default constructor.
4782         (find_partial_die): Update to return const struct.
4783         (partial_die_parent_scope): Move variable declaration into scope
4784         of its use and change its type to auto.
4785         (guess_partial_die_structure_name): Likewise.
4786         (partial_die_info::fixup): Likewise.
4787
4788 2019-05-17  Tom Tromey  <tromey@adacore.com>
4789
4790         * source.c (find_and_open_source): Remove cast.
4791
4792 2019-05-17  Tom Tromey  <tromey@adacore.com>
4793
4794         * annotate.c (annotate_source): Make "filename" const.
4795         * annotate.h (annotate_source): Use const.
4796
4797 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4798
4799         * disasm.c (set_disassembler_options): Send errors to stderr.
4800
4801 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4802
4803         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4804         (cli_interp_base::set_logging): Check debug_redirect.
4805         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4806         * cli/cli-logging.c (debug_redirect): Add static variable.
4807         (pop_output_files): Add default param.
4808         (handle_redirections): Print debug setting.
4809         (show_logging_command): Likewise.
4810         (_initialize_cli_logging): Add debugredirect command.
4811         * interps.c (current_interp_set_logging): Add debug_redirect
4812         parameter.
4813         * interps.h (set_logging): Add debug_redirect parameter.
4814         (current_interp_set_logging): Likewise.
4815         * mi/mi-common.h: Likewise.
4816         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4817
4818 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4819             Tom Tromey  <tromey@adacore.com>
4820
4821         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4822         directly.
4823         * cli/cli-interp.h (make_logging_output): Remove declaration.
4824         * cli/cli-logging.c (make_logging_output): Remove function.
4825         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4826         directly.
4827         * ui-file.c (tee_file::tee_file): Remove bools.
4828         (tee_file::~tee_file): Remove deletes.
4829         * ui-file.h (tee_file): Remove bools.
4830
4831 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4832
4833         * mi/mi-cmds.h (mi_cmd_complete): New function.
4834         * mi/mi-main.c (mi_cmd_complete): Likewise.
4835         * mi/mi-cmds.c: Define new MI command -complete.
4836         * NEWS: Mention new -complete command.
4837
4838 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4839
4840         * completer.h (complete): New function.
4841         * completer.c (complete): Likewise.
4842         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4843         function defined in completer.h.
4844
4845 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4846
4847         * MAINTAINERS (Write After Approval): Add myself.
4848
4849 2019-05-17  Tom de Vries  <tdevries@suse.de>
4850
4851         PR gdb/24094
4852         * dwarf2read.c (struct cu_partial_die_info): New struct.
4853         (find_partial_die): Return cu_partial_die_info.
4854         (partial_die_parent_scope, guess_partial_die_structure_name)
4855         (partial_die_info::fixup): Handle new return type of find_partial_die.
4856
4857 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4858
4859         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4860         "std::string", simplifying the algorithm.
4861
4862 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4863
4864         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4865         (stap_static_probe_ops::get_probes): Likewise.
4866
4867 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4868
4869         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4870         '-')" and "else if".
4871         (stap_parse_single_operand): Join checks for
4872         "gdbarch_stap_parse_special_token_p" and
4873         "gdbarch_stap_parse_special_token" in the same "if" statement.
4874         Invert check when verifying for operation on register
4875         displacement.
4876
4877 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4878
4879         * stap-probe.c (stap_get_opcode): Update comment.
4880         (stap_get_expected_argument_type): Likewise.
4881         (handle_stap_probe): Likewise.
4882
4883 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4884
4885         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4886         return type to 'bool'.  Adjust comment.  Use 'bool' when
4887         appropriate.
4888         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4889         * stap-probe.c (stap_parse_argument_1): Likewise.
4890         (stap_is_operator): Likewise.
4891         (stap_is_generic_prefix): Likewise.
4892         (stap_is_register_prefix): Likewise.
4893         (stap_is_register_indirection_prefix): Likewise.
4894         (stap_is_integer_prefix): Likewise.
4895         (stap_generic_check_suffix): Likewise.
4896         (stap_check_integer_suffix): Likewise.
4897         (stap_check_register_suffix): Likewise.
4898         (stap_check_register_indirection_suffix): Likewise.
4899         (stap_parse_register_operand): Likewise.
4900         (stap_parse_single_operand): Likewise.
4901         (stap_parse_argument_1): Likewise.
4902         (stap_probe::get_argument_count): Likewise.
4903         (stap_is_operator): Likewise.
4904
4905 2019-05-16  Tom Tromey  <tromey@adacore.com>
4906
4907         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4908         keyword to foreach.
4909
4910 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4911
4912         * linux-thread-db.c (try_thread_db_load_1): Change return type
4913         to bool.
4914         (try_thread_db_load): Likewise.
4915         (try_thread_db_load_from_pdir_1): Likewise.
4916         (try_thread_db_load_from_pdir): Likewise.
4917         (try_thread_db_load_from_sdir): Likewise.
4918         (try_thread_db_load_from_dir): Likewise.
4919         (thread_db_load_search): Likewise.
4920         (has_libpthread): Likewise.
4921         (thread_db_load): Likewise.
4922
4923 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4924
4925         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4926         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4927         NULL, and complain/return if that's the case.
4928
4929 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4930
4931         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4932         (advance, posn, abstract_read_memory): New functions.
4933         [struct mem_read_abstraction]: New struct.
4934         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4935
4936 2019-05-14  Tom Tromey  <tromey@adacore.com>
4937
4938         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4939         value is not lval_memory.
4940
4941 2019-05-14  Tom Tromey  <tromey@adacore.com>
4942
4943         * solib.c (info_sharedlibrary_command): Style the file name.
4944
4945 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4946
4947         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4948         (aarch64_vnv_type): Likewise.
4949         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4950         * common/tdesc.c: Likewise.
4951         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4952         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4953         * features/aarch64-fpu.xml: Add ieee half view.
4954         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4955         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4956         * gdbtypes.h (struct builtin_type): Likewise.
4957         (struct objfile_type): Likewise.
4958
4959 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4960
4961         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4962         typo.
4963         * location.h (string_to_event_location): Likewise.
4964
4965 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4966
4967         GDB 8.3 released.
4968
4969 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4970
4971         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4972         New variable declaration.
4973         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4974         New variable.
4975         (print_one_breakpoint): Use ui_out::test_flags and new global
4976         variable to compute use_fixed_output.
4977         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4978         Remove.
4979         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4980         (mi_multi_location_breakpoint_output_fixed): Remove.
4981         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4982         new variable.
4983         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4984         fix_multi_location_breakpoint_output flag if version >= 3.
4985         * ui-out.h (enum ui_out_flag)
4986         <fix_multi_location_breakpoint_output>: New enumerator.
4987
4988 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4989
4990         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4991
4992 2019-05-10  Tom Tromey  <tromey@adacore.com>
4993
4994         * ada-lang.c (catch_ada_completer): New function.
4995         (_initialize_ada_language): Use it.
4996
4997 2019-05-10  Tom Tromey  <tromey@adacore.com>
4998
4999         * thread.c (print_thread_info): Make "requested_threads" const.
5000         * gdbthread.h (print_thread_info): Make "requested_threads"
5001         const.
5002         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5003         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5004
5005 2019-05-08  Tom Tromey  <tom@tromey.com>
5006
5007         * gdbtypes.c (objfile_type_data): Change type.
5008         (objfile_type, _initialize_gdbtypes): Update.
5009
5010 2019-05-08  Tom Tromey  <tom@tromey.com>
5011
5012         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5013         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5014         (_initialize_dwarf2_frame): Update.
5015
5016 2019-05-08  Tom Tromey  <tom@tromey.com>
5017
5018         * objc-lang.c (objc_objfile_data): Change type.
5019         (find_methods): Update.
5020         (_initialize_objc_lang): Remove.
5021
5022 2019-05-08  Tom Tromey  <tom@tromey.com>
5023
5024         * stabsread.c (rs6000_builtin_type_data): Change type.
5025         (rs6000_builtin_type, _initialize_stabsread): Update.
5026
5027 2019-05-08  Tom Tromey  <tom@tromey.com>
5028
5029         * mips-tdep.c (mips_pdr_data): Remove.
5030         (_initialize_mips_tdep): Update.
5031
5032 2019-05-08  Tom Tromey  <tom@tromey.com>
5033
5034         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5035         (hppa_init_objfile_priv_data, read_unwind_info)
5036         (find_unwind_entry, _initialize_hppa_tdep): Update.
5037
5038 2019-05-08  Tom Tromey  <tom@tromey.com>
5039
5040         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5041         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5042         on obstack.
5043         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5044
5045 2019-05-08  Tom Tromey  <tom@tromey.com>
5046
5047         * mdebugread.c (basic_type_data): Change type.
5048         (basic_type, _initialize_mdebugread): Update.
5049
5050 2019-05-08  Tom Tromey  <tom@tromey.com>
5051
5052         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5053
5054 2019-05-08  Tom Tromey  <tom@tromey.com>
5055
5056         * nto-tdep.c (nto_inferior_data_reg): Change type.
5057         (nto_inferior_data): Update.
5058         (nto_inferior_data_cleanup, nto_new_inferior_data)
5059         (_initialize_nto_tdep): Remove.
5060         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5061
5062 2019-05-08  Tom Tromey  <tom@tromey.com>
5063
5064         * ada-lang.c (struct ada_inferior_data): Add initializers.
5065         (ada_inferior_data): Change type.
5066         (ada_inferior_data_cleanup): Remove.
5067         (get_ada_inferior_data, ada_inferior_exit)
5068         (struct ada_pspace_data): Add initializers, destructor.
5069         (ada_pspace_data_handle): Change type.
5070         (get_ada_pspace_data): Update.
5071         (ada_pspace_data_cleanup): Remove.
5072
5073 2019-05-08  Tom Tromey  <tom@tromey.com>
5074
5075         * coffread.c (struct coff_symfile_info): Add initializers.
5076         (coff_objfile_data_key): Move lower.  Change type.
5077         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5078         Update.
5079         (coff_free_info): Remove.
5080
5081 2019-05-08  Tom Tromey  <tom@tromey.com>
5082
5083         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5084         (fbsd_pspace_data_handle): Move lower.  Change type.
5085         (get_fbsd_pspace_data): Update.
5086         (fbsd_pspace_data_cleanup): Remove.
5087         (_initialize_fbsd_tdep): Update.
5088
5089 2019-05-08  Tom Tromey  <tom@tromey.com>
5090
5091         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5092         (get_ada_tasks_pspace_data): Update.
5093         (ada_tasks_pspace_data_cleanup): Remove.
5094         (_initialize_tasks): Update.
5095         (ada_tasks_inferior_data_handle): Change type.
5096         (get_ada_tasks_inferior_data): Update.
5097         (ada_tasks_inferior_data_cleanup): Remove.
5098         (struct ada_tasks_pspace_data): Add initializers.
5099
5100 2019-05-08  Tom Tromey  <tom@tromey.com>
5101
5102         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5103         * symfile-debug.c (debug_sym_get_probes): Change type.
5104         * stap-probe.c (handle_stap_probe):
5105         (stap_static_probe_ops::get_probes): Change type.
5106         * probe.h (class static_probe_ops) <get_probes>: Change type.
5107         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5108         (parse_probes_in_pspace): Update.
5109         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5110         Update.
5111         (any_static_probe_ops::get_probes): Change type.
5112         * elfread.c (elfread_data): New typedef.
5113         (probe_key): Change type.
5114         (elf_get_probes): Likewise.  Update.
5115         (probe_key_free): Remove.
5116         (_initialize_elfread): Update.
5117         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5118         Change type.
5119         (dtrace_process_dof_probe, dtrace_process_dof)
5120         (dtrace_static_probe_ops::get_probe): Change type.
5121
5122 2019-05-08  Tom Tromey  <tom@tromey.com>
5123
5124         * xcoffread.c (struct xcoff_symfile_info): Rename from
5125         coff_symfile_info.  Add initializers.
5126         (xcoff_objfile_data_key): Move lower.  Change type.
5127         (XCOFF_DATA): Rewrite.
5128         (xcoff_free_info): Remove.
5129         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5130         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5131         (xcoff_initial_scan): Update.
5132
5133 2019-05-08  Tom Tromey  <tom@tromey.com>
5134
5135         * solib-svr4.c (struct svr4_info): Add initializers and
5136         destructor.
5137         <probes_table>: Now an htab_up.
5138         (solib_svr4_pspace_data): Change type.
5139         (free_probes_table): Simplify.
5140         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5141         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5142         (probes_table_remove_objfile_probes, register_solib_event_probe)
5143         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5144         (_initialize_svr4_solib): Update.
5145
5146 2019-05-08  Tom Tromey  <tom@tromey.com>
5147
5148         * remote.c (remote_pspace_data): Change type.
5149         (remote_pspace_data_cleanup): Remove.
5150         (get_remote_exec_file, set_pspace_remote_exec_file)
5151         (_initialize_remote): Update.
5152
5153 2019-05-08  Tom Tromey  <tom@tromey.com>
5154
5155         * breakpoint.c (breakpoint_objfile_key): Change type.
5156         (get_breakpoint_objfile_data): Update.
5157         (free_breakpoint_objfile_data): Remove.
5158         (_initialize_breakpoint): Update.
5159
5160 2019-05-08  Tom Tromey  <tom@tromey.com>
5161
5162         * linux-tdep.c (struct linux_info): Add initializers.
5163         (linux_inferior_data): Move.  Change type.
5164         (invalidate_linux_cache_inf): Update.
5165         (linux_inferior_data_cleanup): Remove.
5166         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5167
5168 2019-05-08  Tom Tromey  <tom@tromey.com>
5169
5170         * auxv.c (auxv_inferior_data): Move.  Change type.
5171         (auxv_inferior_data_cleanup): Remove.
5172         (invalidate_auxv_cache_inf): Rewrite.
5173         (get_auxv_inferior_data, _initialize_auxv): Update.
5174
5175 2019-05-08  Tom Tromey  <tom@tromey.com>
5176
5177         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5178         (symfile_debug_objfile_data_key): Change type.
5179         (symfile_debug_installed, debug_qf_has_symbols)
5180         (debug_qf_find_last_source_symtab)
5181         (debug_qf_forget_cached_source_info)
5182         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5183         (debug_qf_print_stats, debug_qf_dump)
5184         (debug_qf_expand_symtabs_for_function)
5185         (debug_qf_expand_all_symtabs)
5186         (debug_qf_expand_symtabs_with_fullname)
5187         (debug_qf_map_matching_symbols)
5188         (debug_qf_expand_symtabs_matching)
5189         (debug_qf_find_pc_sect_compunit_symtab)
5190         (debug_qf_map_symbol_filenames)
5191         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5192         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5193         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5194         (debug_sym_read_linetable, debug_sym_relocate): Update.
5195         (symfile_debug_free_objfile): Remove.
5196         (install_symfile_debug_logging, _initialize_symfile_debug):
5197         Update.
5198
5199 2019-05-08  Tom Tromey  <tom@tromey.com>
5200
5201         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5202         allocate_on_obstack.
5203         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5204         (get_dwarf2_per_objfile): Update.
5205         (set_dwarf2_per_objfile): Remove.
5206         (dwarf2_has_info, dwarf2_get_section_info): Update.
5207         (dwarf2_free_objfile): Remove.
5208         (_initialize_dwarf2_read): Update.
5209
5210 2019-05-08  Tom Tromey  <tom@tromey.com>
5211
5212         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5213         initializers.
5214         <unsupported_script_warning_printed,
5215         script_not_found_warning_printed>: Now bool.
5216         (auto_load_pspace_data): Change type.
5217         (~auto_load_pspace_info): Rename from
5218         auto_load_pspace_data_cleanup.
5219         (get_auto_load_pspace_data, init_loaded_scripts_info)
5220         (clear_section_scripts, maybe_print_unsupported_script_warning)
5221         (maybe_print_script_not_found_warning, _initialize_auto_load):
5222         Update.
5223
5224 2019-05-08  Tom Tromey  <tom@tromey.com>
5225
5226         * objfiles.c (objfile_pspace_info): Add destructor and
5227         initializers.
5228         (objfiles_pspace_data): Change type.
5229         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5230         (get_objfile_pspace_data): Update.
5231         (objfiles_bfd_data): Change type.
5232         (get_objfile_bfd_data): Update.
5233         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5234
5235 2019-05-08  Tom Tromey  <tom@tromey.com>
5236
5237         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5238         Change type.
5239         (get_catch_syscall_inferior_data): Update.
5240         (catch_syscall_inferior_data_cleanup): Remove.
5241         (_initialize_break_catch_syscall): Update.
5242
5243 2019-05-08  Tom Tromey  <tom@tromey.com>
5244
5245         * inflow.c (struct terminal_info): Add destructor and
5246         initializers.
5247         (inflow_inferior_data): Change type.
5248         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5249         (get_inflow_inferior_data, inflow_inferior_exit)
5250         (swap_terminal_info, _initialize_inflow): Update.
5251
5252 2019-05-08  Tom Tromey  <tom@tromey.com>
5253
5254         * target-dcache.c (target_dcache_cleanup): Remove.
5255         (target_dcache_aspace_key): Change type.
5256         (target_dcache_init_p, target_dcache_invalidate)
5257         (target_dcache_get, target_dcache_get_or_init)
5258         (_initialize_target_dcache): Update.
5259         * dcache.h (struct dcache_deleter): New.
5260
5261 2019-05-08  Tom Tromey  <tom@tromey.com>
5262
5263         * symtab.c (struct symbol_cache): Add destructor and
5264         initializers.
5265         (symbol_cache_key): Move.  Change type.
5266         (make_symbol_cache, free_symbol_cache): Remove.
5267         (get_symbol_cache): Update.
5268         (symbol_cache_cleanup): Remove.
5269         (ALL_PSPACES, symbol_cache_flush)
5270         (maintenance_print_symbol_cache)
5271         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5272         Update.
5273
5274 2019-05-08  Tom Tromey  <tom@tromey.com>
5275
5276         * symtab.c (struct main_info): Add destructor and initializers.
5277         (main_progspace_key): Move.  Change type.
5278         (get_main_info): Update.
5279         (main_info_cleanup): Remove.
5280         (_initialize_symtab): Update.
5281
5282 2019-05-08  Tom Tromey  <tom@tromey.com>
5283
5284         * registry.h (DECLARE_REGISTRY): Define the _key class.
5285
5286 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5287
5288         * NEWS: Merge two 'New commands' sections.
5289
5290 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5291
5292         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5293         parameter and use Ada language definition instead.
5294         (ada_val_print_ptr): Remove unused language parameter.
5295         (ada_val_print_num): Remove language parameter and use Ada language
5296         definition instead.
5297         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5298         parameter.
5299         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5300         parameter and use Ada language definition instead.
5301         (ada_val_print_1): Update all ada_val_print_xxx calls.
5302         Remove language parameter.
5303         (ada_val_print): Update ada_val_print_1 call.
5304
5305 2019-05-08  Tom Tromey  <tromey@adacore.com>
5306
5307         * remote.c (remote_hw_watchpoint_limit)
5308         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5309         Now static.
5310
5311 2019-05-08  Tom Tromey  <tromey@adacore.com>
5312
5313         * maint.c (_initialize_maint_cmds): Move initialization code to
5314         remote.c.
5315         (watchdog, show_watchdog): Move to remote.c.
5316         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5317         "watchdog" static.
5318         (_initialize_remote): Move initialization code from maint.c.
5319         * defs.h (watchdog): Don't declare.
5320
5321 2019-05-08  Tom Tromey  <tromey@adacore.com>
5322
5323         * tui/tui-interp.c: Include main.h.
5324         * interps.c: Include main.h.
5325         * main.h (interpreter_p): Declare.
5326         * defs.h (interpreter_p): Don't declare.
5327
5328 2019-05-08  Tom Tromey  <tromey@adacore.com>
5329
5330         * dwarf2loc.c: Include dwarf2read.h.
5331         * defs.h (read_unsigned_leb128): Don't declare.
5332         * dwarf2read.h (read_unsigned_leb128): Declare.
5333
5334 2019-05-08  Tom Tromey  <tromey@adacore.com>
5335
5336         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5337         method.
5338
5339 2019-05-08  Tom Tromey  <tromey@adacore.com>
5340
5341         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5342         when no wrap column is set.
5343
5344 2019-05-08  Tom Tromey  <tromey@adacore.com>
5345
5346         * c-lang.c (c_get_string): Handle non-C-style arrays.
5347
5348 2019-05-08  Tom Tromey  <tromey@adacore.com>
5349
5350         * typeprint.c (print_offset_data::update): Print the bit offset,
5351         not the number of bits remaining.
5352
5353 2019-05-08  Tom Tromey  <tromey@adacore.com>
5354
5355         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5356         padding at end of comment.
5357
5358 2019-05-08  Tom Tromey  <tromey@adacore.com>
5359
5360         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5361         Compare main types.
5362
5363 2019-05-06  Tom Tromey  <tom@tromey.com>
5364
5365         * common/scoped_mmap.c: Include common-defs.h.
5366         * common/scoped_mmap.h: Don't include config.h.
5367
5368 2019-05-04  Tom Tromey  <tom@tromey.com>
5369
5370         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5371         (struct aarch64_call_info): Add initializers.
5372         <si>: Now a std::vector.
5373         (pass_on_stack, aarch64_push_dummy_call): Update.
5374
5375 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5376             Tom Tromey  <tom@tromey.com>
5377
5378         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5379         (ppc_threads): Now a std::vector.  Now static.
5380         (hwdebug_find_thread_points_by_tid)
5381         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5382         Update.
5383
5384 2019-05-04  Tom Tromey  <tom@tromey.com>
5385
5386         * arc-tdep.c (arc_tdesc_init): Return bool.
5387
5388 2019-05-04  Tom Tromey  <tom@tromey.com>
5389
5390         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5391         Use gdb_assert_not_reached.
5392
5393 2019-05-04  Tom Tromey  <tom@tromey.com>
5394
5395         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5396         "false".
5397
5398 2019-05-04  Tom Tromey  <tom@tromey.com>
5399
5400         * arc-tdep.c (arc_tdesc_init): Use bool.
5401
5402 2019-05-04  Tom Tromey  <tom@tromey.com>
5403
5404         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5405
5406 2019-05-04  Tom Tromey  <tom@tromey.com>
5407
5408         * cli/cli-cmds.c (valid_command_p): Return bool.
5409
5410 2019-05-04  Tom Tromey  <tom@tromey.com>
5411
5412         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5413         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5414
5415 2019-05-04  Raul Tambre  <raul@tambre.ee>
5416
5417         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5418         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5419         operator for comparison.
5420
5421 2019-05-04  Tom Tromey  <tom@tromey.com>
5422
5423         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5424         (lookup_partial_symbol, print_partial_symbols)
5425         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5426         (psymbol_compare): Update.
5427         (add_psymbol_to_bcache): Clear the entire psymbol.
5428         (maintenance_check_psymtabs): Update.
5429         * psympriv.h (struct partial_symbol): Don't derive from
5430         general_symbol_info.
5431         <obj_section, unrelocated_address, address,
5432         set_unrelocated_address>: Update.
5433         <ginfo>: New member.
5434         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5435         (debug_names::write_psymbols): Update.
5436
5437 2019-05-04  Tom de Vries  <tdevries@suse.de>
5438
5439         * contrib/cc-with-tweaks.sh: Support -n arg.
5440
5441 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5442
5443         * corelow.c (core_target::detach): Ensure frame cache and
5444         register caches are cleared.
5445         inferior.c (exit_inferior_1): Likewise.
5446
5447 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5448             Tom Tromey  <tom@tromey.com>
5449
5450         * dictionary.c (collate_pending_symbols_by_language): Remove
5451         "struct" from foreach.
5452         * symtab.c (lookup_global_symbol_from_objfile)
5453         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5454         foreach.
5455         * ser-tcp.c (net_open): Remove "struct" from foreach.
5456         * objfiles.c (objfile_relocate, objfile_rebase)
5457         (objfile_has_symbols): Remove "struct" from foreach.
5458         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5459         from foreach.
5460         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5461         foreach.
5462         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5463         "struct" from foreach.
5464         * ada-lang.c (create_excep_cond_exprs)
5465         (ada_exception_catchpoint_cond_string): Remove "struct" from
5466         foreach.
5467
5468 2019-05-03  Tom Tromey  <tromey@adacore.com>
5469
5470         * ada-exp.y (convert_char_literal): Check suffix of each
5471         enumerator.
5472
5473 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5474
5475         PR ada/21406:
5476         * ada-exp.y (yywrap): Don't define.
5477         * ada-lex.l (%option): Add noyywrap
5478         (yywrap): Remove.
5479
5480 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5481
5482         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5483         _WIN32_WINNT to the XP level, unless already defined to a higher
5484         level.
5485
5486         * unittests/parse-connection-spec-selftests.c:
5487         * ser-tcp.c:
5488         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5489         override.
5490
5491         * symfile.c (find_separate_debug_file): Remove colon from the
5492         drive spec of DOS/Windows file names of the target, so that the
5493         file name produced from DEBUGDIR and the target's directory will
5494         be valid on DOS/Windows systems.
5495
5496 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5497
5498         * rust-lang.c (val_print_struct): Handle printing structures
5499         containing strings.
5500
5501 2019-05-02  Tom Tromey  <tromey@adacore.com>
5502
5503         * valarith.c (_initialize_valarith): Remove.
5504
5505 2019-05-01  Tom Tromey  <tromey@adacore.com>
5506
5507         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5508         bitfields.
5509
5510 2019-05-01  Tom Tromey  <tromey@adacore.com>
5511
5512         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5513         for big-endian copies.
5514
5515 2019-04-30  Ali Tamur  <tamur@google.com>
5516         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5517         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5518         (read_3_bytes): New function.
5519
5520 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5521
5522         * windows-nat.c (main_thread_id): Delete.
5523         (handle_output_debug_string): Replace main_thread_id by
5524         current_event.dwThreadId.
5525         (fake_create_process): Likewise.
5526         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5527         Do not set main_thread_id.
5528         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5529         current_event.dwThreadId.
5530         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5531
5532 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5533
5534         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5535         Use current_event.dwThreadId instead of main_thread_id.
5536
5537 2019-04-30  Tom Tromey  <tromey@adacore.com>
5538
5539         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5540         (create_excep_cond_exprs): Iterate over program spaces.
5541         (ada_exception_catchpoint_cond_string): Examine all minimal
5542         symbols for exception types.
5543
5544 2019-04-30  Tom Tromey  <tromey@adacore.com>
5545
5546         PR c++/24470:
5547         * dwarf2read.c (process_structure_scope): Handle case where type
5548         has template parameters but no symbol was created.
5549
5550 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5551             Chris January  <chris.january@arm.com>
5552
5553         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5554         qualifier.
5555         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5556
5557 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5558
5559         * f-typeprint.c (f_print_type): Update rules for printing
5560         whitespace.
5561         (f_type_print_varspec_suffix): Likewise.
5562
5563 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5564             Chris January  <chris.january@arm.com>
5565
5566         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5567         function arguments.
5568
5569 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5570
5571         * f-lang.c (build_fortran_types): Change name of void type to
5572         lower case.
5573         * f-typeprint.c (f_type_print_base): Print the name of the void
5574         type, rather than a fixed string.
5575         * f-valprint.c (f_decorations): Use lower case void string.
5576
5577 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5578             Chris January  <chris.january@arm.com>
5579
5580         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5581         types for Fortran.
5582
5583 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5584             Chris January  <chris.january@arm.com>
5585             David Lecomber  <david.lecomber@arm.com>
5586
5587         * f-exp.y (BINOP_INTRINSIC): New token.
5588         (exp): New parser rule handling BINOP_INTRINSIC.
5589         (f77_keywords): Add new builtin procedures.
5590         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5591         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5592         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5593         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5594         (print_unop_subexp_f): New function.
5595         (print_binop_subexp_f): New function.
5596         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5597         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5598         (dump_subexp_body_f): Likewise.
5599         (operator_check_f): Likewise.
5600         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5601         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5602
5603 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5604
5605         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5606         UNOP_KIND.
5607         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5608         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5609         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5610         (operator_length_f): New fuction.
5611         (print_subexp_f): New function.
5612         (op_name_f): New function.
5613         (dump_subexp_body_f): New function.
5614         (operator_check_f): New function.
5615         (exp_descriptor_f): Replace standard expression handling functions
5616         with new functions.
5617         * gdb/fortran-operator.def: New file.
5618         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5619         * gdb/std-operator.def: Remove UNOP_KIND.
5620
5621 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5622
5623         * std-operator.def: Remove unbalanced, stray double quote
5624         character.
5625
5626 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5627             Chris January  <chris.january@arm.com>
5628             Daniel Everett  <daniel.everett@arm.com>
5629             Nick Forrington  <nick.forrington@arm.com>
5630             Richard Bunt  <richard.bunt@arm.com>
5631
5632         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5633         of depth when printing anonymous structs or unions.
5634         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5635         Don't print either the top-level value, or the children if the
5636         max-depth is exceeded.
5637         (ppscm_print_children): When printing the key of a map, allow one
5638         extra level of depth.
5639         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5640         print either the top-level value, or the children if the max-depth
5641         is exceeded.
5642         (print_children): When printing the key of a map, allow one extra
5643         level of depth.
5644         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5645         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5646         (user_print_options): Initialise max_depth field.
5647         (val_print_scalar_or_string_type_p): New function.
5648         (val_print): Check to see if the max depth has been reached.
5649         (val_print_check_max_depth): Define new function.
5650         (show_print_max_depth): New function.
5651         (_initialize_valprint): Add 'print max-depth' option.
5652         * valprint.h (struct value_print_options) <max_depth>: New field.
5653         (val_print_check_max_depth): Declare new function.
5654         * NEWS: Document new feature.
5655
5656 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * ada-lang.c (ada_language_defn): Initialise new field.
5659         * c-lang.c (c_is_string_type_p): New function.
5660         (c_language_defn): Initialise new field.
5661         (cplus_language_defn): Initialise new field.
5662         (asm_language_defn): Initialise new field.
5663         (minimal_language_defn): Initialise new field.
5664         * c-lang.h (c_is_string_type_p): Declare new function.
5665         * d-lang.c (d_language_defn): Initialise new field.
5666         * f-lang.c (f_is_string_type_p): New function.
5667         (f_language_defn): Initialise new field.
5668         * go-lang.c (go_is_string_type_p): New function.
5669         (go_language_defn): Initialise new field.
5670         * language.c (default_is_string_type_p): New function.
5671         (unknown_language_defn): Initialise new field.
5672         (auto_language_defn): Initialise new field.
5673         * language.h (struct language_defn) <la_is_string_type_p>: New
5674         member variable.
5675         (default_is_string_type_p): Declare new function.
5676         * m2-lang.c (m2_language_defn): Initialise new field.
5677         * objc-lang.c (objc_language_defn): Initialise new field.
5678         * opencl-lang.c (opencl_language_defn): Initialise new field.
5679         * p-lang.c (pascal_is_string_type_p): New function.
5680         (pascal_language_defn): Initialise new field.
5681         * rust-lang.c (rust_is_string_type_p): New function.
5682         (rust_language_defn): Initialise new field.
5683
5684 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5687         New field.
5688         * ada-lang.c (ada_language_defn): Initialise new field.
5689         * c-lang.c (c_language_defn): Likewise.
5690         (cplus_language_defn): Likewise.
5691         (asm_language_defn): Likewise.
5692         (minimal_language_defn): Likewise.
5693         * d-lang.c (d_language_defn): Likewise.
5694         * f-lang.c (f_language_defn): Likewise.
5695         * go-lang.c (go_language_defn): Likewise.
5696         * language.c (unknown_language_defn): Likewise.
5697         (auto_language_defn): Likewise.
5698         * m2-lang.c (m2_language_defn): Likewise.
5699         * objc-lang.c (objc_language_defn): Likewise.
5700         * opencl-lang.c (opencl_language_defn): Likewise.
5701         * p-lang.c (pascal_language_defn): Likewise.
5702         * rust-lang.c (rust_language_defn): Likewise.
5703
5704 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * ada-lang.c (ada_is_character_type): Change return type to bool.
5707         (ada_is_string_type): Likewise.
5708         * ada-lang.h (ada_is_character_type): Update declaration
5709         (ada_is_string_type): Likewise.
5710
5711 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5712
5713         Support style in 'frame|thread apply'
5714
5715         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5716         * record.c (record_start, record_stop): Update callers of
5717         execute_command_to_string with false.
5718         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5719         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5720         methods.
5721         (class string_file): New constructor with term_out parameter.
5722         Override methods term_out and can_emit_style_escape.  New member
5723         term_out.
5724         (class stdio_file): Override can_emit_style_escape.
5725         (class tee_file): Override term_out and can_emit_style_escape.
5726         * utils.h (can_emit_style_escape): Remove.
5727         * utils.c (can_emit_style_escape): Likewise.
5728         Update all callers of can_emit_style_escape (SOMESTREAM) to
5729         SOMESTREAM->can_emit_style_escape.
5730         * source-cache.c (source_cache::get_source_lines): Likewise.
5731         * stack.c (frame_apply_command_count): Call execute_command_to_string
5732         passing the term_out characteristic of the current gdb_stdout.
5733         * thread.c (thr_try_catch_cmd): Likewise.
5734         * top.c (execute_command_to_string): pass term_out parameter
5735         to construct the string_file for the command output.
5736         * ui-file.c (term_cli_styling): New function (most code moved
5737         from utils.c can_emit_style_escape).
5738         (string_file::string_file, string_file::can_emit_style_escape,
5739         stdio_file::can_emit_style_escape, tee_file::term_out,
5740         tee_file::can_emit_style_escape): New functions.
5741
5742 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5743
5744         * NEWS: Mention the new set|show may-call-functions.
5745         * infcall.c (may_call_functions_p): New variable.
5746         (show_may_call_functions_p): New function.
5747         (call_function_by_hand_dummy): Throws an error if not
5748         may-call-functions.
5749         (_initialize_infcall): Call add_setshow_boolean_cmd for
5750         may-call-functions.
5751
5752 2019-04-25  Keith Seitz  <keiths@redhat.com>
5753
5754         PR c++/24367
5755         * cp-support.c (inspect_type): Don't attempt substitutions
5756         of symbol with the same name.
5757
5758 2019-04-25  Tom Tromey  <tromey@adacore.com>
5759
5760         PR gdb/24475:
5761         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5762         static.
5763
5764 2019-04-25  Tom Tromey  <tromey@adacore.com>
5765
5766         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5767         rvalue reference.
5768         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5769         (gdb_xml_parser::parse): Use std::move.
5770         * python/python-internal.h (gdbpy_convert_exception): Take a const
5771         reference.
5772         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5773         std::move.
5774         * python/py-utils.c (gdbpy_convert_exception): Take a const
5775         reference.
5776         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5777         Use std::move.
5778         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5779         Use std::move.
5780         * mi/mi-main.c (mi_print_exception): Take a const reference.
5781         * main.c (handle_command_errors): Take a const reference.
5782         * linespec.c (parse_linespec): Use std::move.
5783         * infcall.c (run_inferior_call): Use std::move.
5784         (call_function_by_hand_dummy): Use std::move.
5785         * exec.c (try_open_exec_file): Use std::move.
5786         * exceptions.h (exception_print, exception_fprintf)
5787         (exception_print_same): Update.
5788         * exceptions.c (print_exception, exception_print)
5789         (exception_fprintf, exception_print_same): Change parameters to
5790         const reference.
5791         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5792         * common/new-op.c: Use std::move.
5793         * common/common-exceptions.h (struct gdb_exception): Add move
5794         constructor.
5795         (struct gdb_exception_error, struct gdb_exception_quit, struct
5796         gdb_quit_bad_alloc): Change constructor to move constructor.
5797         (throw_exception): Change parameter to rvalue reference.
5798         * common/common-exceptions.c (throw_exception): Take rvalue
5799         reference.
5800         * cli/cli-interp.c (safe_execute_command): Use std::move.
5801         * breakpoint.c (insert_bp_location, location_to_sals): Use
5802         std::move.
5803
5804 2019-04-25  Tom Tromey  <tromey@adacore.com>
5805
5806         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5807         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5808         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5809         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5810         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5811         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5812         guile/scm-value.c: Use unpack.
5813         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5814         gdbscm_gdb_exception.
5815         (gdbscm_throw_gdb_exception): Likewise.
5816         (struct gdbscm_gdb_exception): New.
5817         (unpack): New function.
5818         (gdbscm_wrap): Use unpack.
5819
5820 2019-04-25  Tom Tromey  <tromey@adacore.com>
5821
5822         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5823         (gdb_rl_callback_handler): Use std::move.
5824         * common/common-exceptions.h (struct gdb_exception): Add move
5825         assignment operator.
5826         (throw_exception_sjlj): Change "exception" to const reference.
5827         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5828         (throw_exception_sjlj): Change "exception" to const reference.
5829
5830 2019-04-25  Tom Tromey  <tromey@adacore.com>
5831
5832         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5833         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5834         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5835         Update.
5836         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5837         Update.
5838         * mi/mi-interp.c (mi_interp::exec): Update.
5839         * linespec.c (parse_linespec): Update.
5840         * infcall.c (run_inferior_call): Update.
5841         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5842         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5843         (gdbscm_lookup_global_symbol): Update.
5844         * guile/scm-param.c (gdbscm_parameter_value): Update.
5845         * guile/scm-frame.c (gdbscm_frame_read_register)
5846         (gdbscm_frame_read_var): Update.
5847         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5848         * exec.c (try_open_exec_file): Update.
5849         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5850         (gdb_rl_callback_handler): Update.
5851         * common/common-exceptions.h (exception_none): Don't declare.
5852         * common/common-exceptions.c (exception_none): Don't define.
5853         (struct catcher) <exception>: Update.
5854         * cli/cli-interp.c (safe_execute_command): Update.
5855         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5856
5857 2019-04-25  Ali Tamur  <tamur@google.com>
5858
5859         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5860         (read_attribute_value): Likewise.
5861         (dwarf2_read_addr_index): Update comment.
5862         (read_str_index): Add DW_FORM_strx.
5863         (dwarf2_string_attr): Likewise.
5864         (dwarf2_const_value_attr): Likewise.
5865         (dump_die_shallow): Likewise.
5866         (dwarf2_fetch_constant_bytes): Likewise.
5867         (skip_form_bytes): Likewise.
5868         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5869
5870 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5871
5872         PR corefiles/11608
5873         PR corefiles/18187
5874         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5875         OFFSET.  Verify if current mapping contains an ELF header.
5876         (linux_find_memory_regions_full): Adjust call to
5877         dump_mapping_p.
5878
5879 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5880             Kang Li <kanglictf@gmail.com>
5881
5882         PR gdb/21600
5883
5884         * dwarf2-frame.c (read_initial_length): Be consistent about using
5885         unsigned representation of length.
5886         (decode_frame_entry_1): Likewise.  Check for wraparound of
5887         end pointer as well as buffer overflow.
5888
5889 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5890
5891         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5892         "vq".
5893
5894 2019-04-24  Tom Tromey  <tromey@adacore.com>
5895
5896         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5897
5898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * s12z-tdep.c (s12z_unwind_pc): Delete.
5901         (s12z_unwind_sp): Delete.
5902         (s12z_gdbarch_init): Don't register deleted functions with
5903         gdbarch.
5904
5905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * rl78-tdep.c (rl78_unwind_sp): Delete.
5908         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5909
5910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5911
5912         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5913         (xstormy16_unwind_pc): Delete.
5914         (xstormy16_dummy_id): Delete.
5915         (xstormy16_gdbarch_init): Don't register deleted functions with
5916         gdbarch.
5917
5918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5919
5920         * vax-tdep.c (vax_unwind_pc): Delete.
5921         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5922
5923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5924
5925         * v850-tdep.c (v850_unwind_sp): Delete.
5926         (v850_unwind_pc): Delete.
5927         (v850_dummy_id): Delete.
5928         (v850_gdbarch_init): Don't register deleted functions with
5929         gdbarch.
5930
5931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5932
5933         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5934         (tilegx_unwind_pc): Delete.
5935         (tilegx_unwind_dummy_id): Delete.
5936         (tilegx_gdbarch_init): Don't register deleted functions with
5937         gdbarch.
5938
5939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5942         (tic6x_dummy_id): Delete.
5943         (tic6x_gdbarch_init): Don't register deleted functions with
5944         gdbarch.
5945
5946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5947
5948         * sparc-tdep.c (sparc_unwind_pc): Delete.
5949         (sparc32_gdbarch_init): Don't register deleted function with
5950         gdbarch.
5951
5952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5953
5954         * sh-tdep.c (sh_unwind_sp): Delete.
5955         (sh_unwind_pc): Delete.
5956         (sh_dummy_id): Delete.
5957         (sh_gdbarch_init): Don't register deleted functions with
5958         gdbarch.
5959
5960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5961
5962         * score-tdep.c (score_unwind_sp): Delete.
5963         (score_unwind_pc): Delete.
5964         (score_dummy_id): Delete.
5965         (score_gdbarch_init): Don't register deleted functions with
5966         gdbarch.
5967
5968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5969
5970         * rx-tdep.c (rx_unwind_pc): Delete.
5971         (rx_unwind_sp): Delete.
5972         (rx_dummy_id): Delete.
5973         (rx_gdbarch_init): Don't register deleted functions with
5974         gdbarch.  Update comment.
5975
5976 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5977
5978         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5979         (rs6000_dummy_id): Delete.
5980         (rs6000_gdbarch_init): Don't register deleted functions with
5981         gdbarch.
5982
5983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5984
5985         * or1k-tdep.c (or1k_dummy_id): Delete.
5986         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5987
5988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5989
5990         * nios2-tdep.c (nios2_dummy_id): Delete.
5991         (nios2_unwind_sp): Delete.
5992         (nios2_gdbarch_init): Don't register deleted functions with
5993         gdbarch.
5994
5995 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5996
5997         * nds32-tdep.c (nds32_dummy_id): Delete.
5998         (nds32_unwind_pc): Delete.
5999         (nds32_unwind_sp): Delete.
6000         (nds32_gdbarch_init): Don't register deleted functions with
6001         gdbarch.
6002
6003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6004
6005         * msp430-tdep.c (msp430_unwind_pc): Delete.
6006         (msp430_unwind_sp): Delete.
6007         (msp430_dummy_id): Delete.
6008         (msp430_gdbarch_init): Don't register deleted functions with
6009         gdbarch.
6010
6011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6012
6013         * moxie-tdep.c (moxie_unwind_sp): Delete.
6014         (moxie_unwind_pc): Delete.
6015         (moxie_dummy_id): Delete.
6016         (moxie_gdbarch_init): Don't register deleted functions with
6017         gdbarch.
6018
6019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6020
6021         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6022         (mn10300_unwind_pc): Delete.
6023         (mn10300_unwind_sp): Delete.
6024         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6025         mn10300_unwind_sp.
6026         (mn10300_frame_unwind_init): Don't register deleted functions with
6027         gdbarch.
6028
6029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6030
6031         * mep-tdep.c (mep_unwind_pc): Delete.
6032         (mep_unwind_sp): Delete.
6033         (mep_dummy_id): Delete.
6034         (mep_gdbarch_init): Don't register deleted functions with
6035         gdbarch.
6036
6037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6038
6039         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6040         (m68hc11_unwind_sp): Delete.
6041         (m68hc11_gdbarch_init): Don't register deleted functions with
6042         gdbarch.
6043
6044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * m32r-tdep.c (m32r_unwind_sp): Delete.
6047         (m32r_unwind_pc): Delete.
6048         (m32r_dummy_id): Delete.
6049         (m32r_gdbarch_init): Don't register deleted functions with
6050         gdbarch.
6051
6052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6053
6054         * m32c-tdep.c (m32c_unwind_pc): Delete.
6055         (m32c_unwind_sp): Delete.
6056         (m32c_dummy_id): Delete.
6057         (m32c_gdbarch_init): Don't register deleted functions with
6058         gdbarch.
6059
6060 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6061
6062         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6063         (lm32_unwind_pc): Delete.
6064         (lm32_dummy_id): Delete.
6065         (lm32_gdbarch_init): Don't register deleted functions with
6066         gdbarch.
6067
6068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6069
6070         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6071         (iq2000_unwind_pc): Delete.
6072         (iq2000_dummy_id): Delete.
6073         (iq2000_gdbarch_init): Don't register deleted functions with
6074         gdbarch.
6075
6076 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * nds32-tdep.c (nds32_type_align): Delete.
6079         (nds32_push_dummy_call): Use type_align instead.
6080
6081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6082
6083         * arm-tdep.c (arm_type_align): Only handle vector override case.
6084         (arm_push_dummy_call): Use type_align.
6085         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6086
6087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6088
6089         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6090         case.
6091         (pass_on_stack): Use type_align.
6092         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6093         function.
6094
6095 2019-04-23  Tom Tromey  <tromey@adacore.com>
6096
6097         * dwarf2read.c (line_header::file_name_at): Remove unused
6098         overload.
6099
6100 2019-04-23  Tom de Vries  <tdevries@suse.de>
6101
6102         PR gdb/24438
6103         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6104         invocation.
6105
6106
6107 2019-03-27  Ali Tamur  <tamur@google.com>
6108
6109         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6110         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6111         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6112         (dwarf_expr_context::get_addr_index): Likewise
6113         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6114         (symbol_needs_eval_context::get_addr_index): Likewise
6115         (disassemble_dwarf_expression): Add DW_OP_addrx
6116         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6117         (read_cutu_die_from_dwo): Update comment
6118         (skip_one_die): Add DW_FORM_addrx
6119         (read_attribute_value): Likewise
6120         (var_decode_location): Add DW_OP_addrx
6121         (dwarf2_const_value_attr): Add DW_FORM_addrx
6122         (dump_die_shallow): Likewise
6123         (dwarf2_fetch_constant_bytes): Likewise
6124         (decode_locdesc): Add DW_OP_addrx
6125         (skip_form_bytes): Add DW_FORM_addrx
6126
6127 2019-04-22  Ali Tamur  <tamur@google.com>
6128
6129         * MAINTAINERS (Write After Approval): Add self.
6130
6131 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6132
6133         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6134         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6135         (open_symbol_file_object): Likewise.
6136         (svr4_default_sos): Add info parameter.
6137         (svr4_read_so_list): Likewise.
6138         (svr4_current_sos_direct): Adjust functions calls to pass down
6139         info.
6140         (svr4_current_sos_1): Add info parameter.
6141         (svr4_current_sos): Call get_svr4_info, pass info down to
6142         svr4_current_sos_1.
6143         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6144         get_svr4_info.
6145         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6146         get_svr4_info.
6147         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6148         to get_svr4_info.
6149         (probes_table_remove_objfile_probes): Likewise.
6150         (register_solib_event_probe): Add info parameter.
6151         (solist_update_incremental): Pass info parameter down to
6152         svr4_read_so_list.
6153         (disable_probes_interface): Add info parameter.
6154         (svr4_handle_solib_event): Pass current_program_space to
6155         get_svr4_info.  Adjust disable_probes_interface cleanup.
6156         (svr4_create_probe_breakpoints): Add info parameter, pass it
6157         down to register_solib_event_probe.
6158         (svr4_create_solib_event_breakpoints): Add info parameter,
6159         pass it down to svr4_create_probe_breakpoints.
6160         (enable_break): Pass info down to
6161         svr4_create_solib_event_breakpoints.
6162         (svr4_solib_create_inferior_hook): Pass current_program_space to
6163         get_svr4_info.
6164         (svr4_clear_solib): Likewise.
6165
6166 2019-04-22  Pedro Alves  <palves@redhat.com>
6167
6168         * solib-svr4.c (svr4_free_objfile_observer): New.
6169         (probe_and_action::objfile): New field.
6170         (probes_table_htab_remove_objfile_probes)
6171         (probes_table_remove_objfile_probes): New functions.
6172         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6173         in the new probe_and_action.  Don't store the probe in 'lookup'.
6174         (svr4_create_probe_breakpoints): Pass objfile to
6175         register_solib_event_probe.
6176         (_initialize_svr4_solib): Register a free_objfile observer.
6177
6178 2019-04-19  Tom Tromey  <tom@tromey.com>
6179
6180         * common/queue.h: Remove.
6181
6182 2019-04-19  Tom Tromey  <tom@tromey.com>
6183
6184         * event-loop.c: Don't include "common/queue.h".
6185
6186 2019-04-19  Tom Tromey  <tom@tromey.com>
6187
6188         * remote.c (remote_target): Use delete.
6189         * remote-notif.h: Include <list>, not "common/queue.h".
6190         (notif_client_p): Remove typedef.
6191         (remote_notif_state): Add constructor, destructor, initializer.
6192         <notif_queue>: Now a std::list.
6193         (remote_notif_state_xfree): Don't declare.
6194         * remote-notif.c (remote_notif_process, handle_notification)
6195         (remote_notif_state_allocate): Update.
6196         (~remote_notif_state): Rename from remote_notif_state_xfree.
6197
6198 2019-04-19  Tom Tromey  <tom@tromey.com>
6199
6200         * symfile.c (reread_symbols): Update.
6201         * objfiles.c (objfile_register_static_link)
6202         (objfile_lookup_static_link): Update
6203         (~objfile) Don't delete static_links.
6204         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6205
6206 2019-04-19  Tom Tromey  <tom@tromey.com>
6207
6208         * type-stack.h (struct type_stack) <insert>: Constify string.
6209         * type-stack.c (type_stack::insert): Constify string.
6210         * gdbtypes.h (lookup_template_type): Update.
6211         (address_space_name_to_int): Update.
6212         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6213         const.
6214         (lookup_template_type): Make name const.
6215         * c-exp.y: Update rules.
6216         (lex_one_token, classify_name, classify_inner_name)
6217         (c_print_token): Update.
6218         * p-exp.y: Update rules.
6219         (yylex): Update.
6220         * f-exp.y: Update rules.
6221         (yylex): Update.
6222         * d-exp.y: Update rules.
6223         (lex_one_token, classify_name, classify_inner_name): Update.
6224         * parse.c (write_dollar_variable, copy_name): Return std::string.
6225         * parser-defs.h (copy_name): Change return type.
6226         * m2-exp.y: Update rules.
6227         (yylex): Update.
6228         * go-exp.y (lex_one_token): Update.
6229         Update rules.
6230         (classify_unsafe_function, classify_packaged_name)
6231         (classify_name, yylex): Update.
6232
6233 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6234
6235         * configure.ac: add --enable-source-highlight switch.
6236         * configure: Regenerate.
6237         * top.c (print_gdb_version): plumb --enable-source-highlight
6238         status to "show configuration".
6239
6240 2019-04-19  Tom Tromey  <tromey@adacore.com>
6241
6242         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6243         Check ADA_TYPE_P.
6244         (empty_record, ada_template_to_fixed_record_type_1)
6245         (template_to_static_fixed_type)
6246         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6247         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6248         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6249         macros.
6250
6251 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6252
6253         PR symtab/24423:
6254         * source.c (print_source_lines_base): Advance "iter" when a
6255         control character is seen.
6256
6257 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6258
6259         * inferior.h (struct infcall_suspend_state_deleter):
6260         Catch exception in destructor to avoid crash.
6261
6262 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6263
6264         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6265         close to the add_com "shell".
6266
6267 2019-04-18  Tom Tromey  <tromey@adacore.com>
6268
6269         * process-stratum-target.h (class process_stratum_target)
6270         <stratum>: Add "final".
6271
6272 2019-04-17  Tom Tromey  <tromey@adacore.com>
6273
6274         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6275         against nullptr before use.
6276
6277 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6278
6279         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6280
6281 2019-04-17  Jim Wilson  <jimw@sifive.com>
6282             Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6285         code read might fail, assume 4-byte breakpoint in that case.
6286
6287 2019-04-15  Leszek Swirski  <leszeks@google.com>
6288
6289         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6290         rather than a hand-rolled POD check when checking for forced MEMORY
6291         classification.
6292
6293 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6294
6295         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6296         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6297         function.
6298         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6299         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6300         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6301         declaration.
6302
6303 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6304
6305         * aarch64-linux-nat.c
6306         (aarch64_linux_nat_target::thread_architecture): Add override.
6307         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6308         each VQ.
6309
6310 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6311
6312         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6313
6314 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6317         target types of size 96-bits, add some additional comments, and
6318         check that the builtin type we found was the correct size.
6319
6320 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6321
6322         * utils.c (prompt_for_continue): Don't restore the styling at the
6323         end, as applied_style has the wrong value.  This fixes styling in
6324         long lists of file names that are interrupted by the "Continue?"
6325         prompt.
6326
6327 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6330         * c-lang.c (c_language_defn): Likewise.
6331         (cplus_language_defn): Likewise.
6332         (asm_language_defn): Likewise.
6333         (minimal_language_defn): Likewise.
6334         * d-lang.c (d_language_defn): Likewise.
6335         * f-lang.c (f_language_defn): Likewise.
6336         * go-lang.c (go_language_defn): Likewise.
6337         * language.c (unknown_language_defn): Likewise.
6338         (auto_language_defn): Likewise.
6339         * language.h (struct language_defn): Remove la_magic field.
6340         (LANG_MAGIC): Delete.
6341         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6342         * objc-lang.c (objc_language_defn): Likewise.
6343         * opencl-lang.c (opencl_language_defn): Likewise.
6344         * p-lang.c (pascal_language_defn): Likewise.
6345         * rust-lang.c (rust_language_defn): Likewise.
6346
6347 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * riscv-tdep.c (riscv_type_align): New function.
6350         (riscv_type_alignment): Delete.
6351         (riscv_arg_location): Use 'type_align'.
6352         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6353
6354 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * gdbtypes.c (type_align): A struct with no non-static fields also
6357         has alignment of 1.
6358
6359 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6360
6361         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6362         component to 0.
6363         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6364         member.
6365         (riscv_struct_info::analyse): New implementation using new
6366         analyse_inner member function.
6367         (riscv_struct_info::field_offset): New member function.
6368         (riscv_struct_info::m_offsets): New member variable.
6369         (riscv_struct_info::analyse_inner): New private member function,
6370         takes the old implementation of riscv_struct_info::analyse but
6371         extended to track field offsets.
6372         (riscv_call_arg_struct): Update the struct folding special cases
6373         to handle cases where empty C++ structs, which are non-zero
6374         length, are found.
6375         (riscv_arg_location): Initialise the length of each location, a
6376         non-zero length now indicates the location is in use.
6377         (riscv_push_dummy_call): Allow for the first location having a
6378         non-zero offset when setting up arguments.
6379         (riscv_return_value): Likewise, but for return values.
6380
6381 2019-04-11  Tom Tromey  <tromey@adacore.com>
6382
6383         * utils.c (internal_vproblem): Make "msg" const.
6384
6385 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6386
6387         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6388         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6389         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6390         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6391
6392 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6393
6394         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6395         function.
6396         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6397         of amd64_collect_native_gregset.
6398         (amd64_linux_nat_target::store_registers): Likewise.
6399
6400 2019-04-10  Tom Tromey  <tom@tromey.com>
6401
6402         * symtab.c (lookup_global_symbol_from_objfile)
6403         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6404         * objfiles.h (class separate_debug_iterator): New.
6405         (class separate_debug_range): New.
6406         (struct objfile) <separate_debug_objfiles>: New method.
6407         (objfile_separate_debug_iterate): Don't declare.
6408         * objfiles.c (separate_debug_iterator::operator++): Rename from
6409         objfile_separate_debug_iterate.
6410         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6411         iterator.
6412         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6413         iterator.
6414
6415 2019-04-10  Tom Tromey  <tom@tromey.com>
6416
6417         * symfile.c (reread_symbols): Remove old comment.
6418         * objfiles.c (free_all_objfiles): Fix a typo.
6419
6420 2019-04-10  Tom Tromey  <tom@tromey.com>
6421
6422         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6423         * minsyms.c (lookup_minimal_symbol): Use foreach.
6424         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6425         (lookup_minimal_symbol_solib_trampoline): Likewise.
6426         * symfile.c (reread_symbols): Use foreach.
6427
6428 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6429             Tom Tromey  <tromey@adacore.com>
6430
6431         PR rust/24414:
6432         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6433         (rust_lex_int_test): Change "value" to be LONGEST.
6434         (rust_lex_tests): Add test for long integer literal.
6435
6436 2019-04-09  Tom Tromey  <tromey@adacore.com>
6437
6438         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6439         to bool.
6440         (extended_remote_target::attach): Update.
6441         (remote_target::remote_notice_new_inferior): Update.
6442         (remote_target::add_current_inferior_and_thread): Update.
6443         * inferior.c (exit_inferior_1): Use "false".
6444         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6445
6446 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6447
6448         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6449         the "start" command.
6450
6451 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6452
6453         * python/py-inferior.c (infpy_thread_from_thread_handle):
6454         Adjust comments to reflect renaming of thread_from_thread_handle
6455         to thread_from_handle.  Adjust keywords.  Fix type error message.
6456         (inferior_object_methods): Add thread_from_handle.  Retain
6457         thread_from_thread_handle, but mark it as deprecated.
6458
6459 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6460
6461         * gdbthread.h (find_thread_by_handle): Revise declaration.
6462         * thread.c (find_thread_by_handle): Likewise.  Adjust
6463         implementation too.
6464         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6465         support for buffer objects as handles.
6466
6467 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6468
6469         * python/py-infthread.c (thpy_thread_handle): New function.
6470         (thread_object_methods): Register thpy_thread_handle.
6471
6472 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6473
6474         * gdbthread.h (thread_to_thread_handle): Declare.
6475         * thread.c (gdbtypes.h): Include.
6476         (thread_to_thread_handle): New function.
6477
6478         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6479         (target_thread_info_to_thread_handle): Declare.
6480         * target.c (target_thread_info_to_thread_handle): New function.
6481         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6482         * target-delegates.c: Regenerate.
6483
6484         * linux-thread-db.c (class thread_db_target): Add method
6485         thread_info_to_thread_handle.
6486         (thread_db_target::thread_info_to_thread_handle): Define.
6487         * remote.c (class remote_target): Add new method
6488         thread_info_to_thread_handle.
6489         (remote_target::thread_info_to_thread_handle): Define.
6490
6491 2019-04-08  Pedro Alves  <palves@redhat.com>
6492
6493         * common/common-exceptions.c (throw_exception): Don't create
6494         named object to throw; throw directly.
6495         (throw_it): Likewise.  Don't initialize gdb_exception::message
6496         here, with new; pass FMT and AP to the ctor instead.
6497         * common/common-exceptions.h: Include <string>.
6498         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6499         const char *, va_list)): New ctor.  Use std::make_shared.
6500         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6501         errors)): Delete.
6502         (gdb_exception_error::gdb_exception_error(enum errors, const char
6503         *, va_list)): New.
6504         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6505         Add assertion.
6506         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6507         errors)): Delete.
6508         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6509         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6510         Add assertion.
6511
6512 2019-04-08  Tom Tromey  <tom@tromey.com>
6513
6514         * valops.c (value_rtti_indirect_type): Replace throw_exception
6515         with throw.
6516         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6517         with throw.
6518         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6519         throw.
6520         * target.c (target_translate_tls_address): Replace throw_exception
6521         with throw.
6522         * stack.c (frame_apply_command_count): Replace throw_exception
6523         with throw.
6524         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6525         throw.
6526         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6527         with throw.
6528         * rs6000-tdep.c (rs6000_frame_cache)
6529         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6530         * remote.c: Replace throw_exception with throw.
6531         * record-full.c (record_full_message, record_full_wait_1)
6532         (record_full_restore): Replace throw_exception with throw.
6533         * record-btrace.c:
6534         (get_thread_current_frame_id, record_btrace_start_replaying)
6535         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6536         (cmd_record_btrace_start): Replace throw_exception with throw.
6537         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6538         throw.
6539         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6540         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6541         * linespec.c:
6542         (find_linespec_symbols): Replace throw_exception with throw.
6543         * infrun.c (displaced_step_prepare, resume): Replace
6544         throw_exception with throw.
6545         * infcmd.c (post_create_inferior): Replace throw_exception with
6546         throw.
6547         * inf-loop.c (inferior_event_handler): Replace throw_exception
6548         with throw.
6549         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6550         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6551         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6552         (get_prev_frame_always, get_frame_pc_if_available)
6553         (get_frame_address_in_block_if_available, get_frame_language):
6554         Replace throw_exception with throw.
6555         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6556         throw_exception with throw.
6557         * eval.c (fetch_subexp_value, evaluate_var_value)
6558         (evaluate_funcall, evaluate_subexp_standard): Replace
6559         throw_exception with throw.
6560         * dwarf2loc.c (call_site_find_chain)
6561         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6562         Replace throw_exception with throw.
6563         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6564         with throw.
6565         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6566         throw.
6567         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6568         * completer.c (complete_line_internal): Replace throw_exception
6569         with throw.
6570         * compile/compile-object-run.c (compile_object_run): Replace
6571         throw_exception with throw.
6572         * cli/cli-script.c (process_next_line): Replace throw_exception
6573         with throw.
6574         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6575         (btrace_enable, btrace_maint_update_pt_packets): Replace
6576         throw_exception with throw.
6577         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6578         throw_exception with throw.
6579         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6580         throw_exception with throw.
6581         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6582         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6583         * aarch64-tdep.c (aarch64_make_prologue_cache)
6584         (aarch64_make_stub_cache): Replace throw_exception with throw.
6585
6586 2019-04-08  Tom Tromey  <tom@tromey.com>
6587
6588         * common/common-exceptions.c (throw_exception): Rename from
6589         throw_exception_cxx.  Remove old copy.  Make argument const.
6590         (throw_it): Create and throw exception objects directly.
6591         * common/common-exceptions.h (throw_exception): Make argument
6592         const.
6593         (struct gdb_exception_error): Add constructor.
6594         (struct gdb_exception_quit): Add constructor.
6595
6596 2019-04-08  Tom Tromey  <tom@tromey.com>
6597
6598         * common/common-exceptions.h (exception_rethrow): Don't declare.
6599         (TRY_SJLJ): Update comment.
6600         (TRY, CATCH, END_CATCH): Remove.
6601         * common/common-exceptions.c (exception_rethrow): Remove.
6602
6603 2019-04-08  Tom Tromey  <tom@tromey.com>
6604
6605         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6606         Remove.
6607         (gdb_exception_error): Rename from
6608         gdb_exception_RETURN_MASK_ERROR.
6609         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6610         (gdb_quit_bad_alloc): Update.
6611         * aarch64-tdep.c: Update.
6612         * ada-lang.c: Update.
6613         * ada-typeprint.c: Update.
6614         * ada-valprint.c: Update.
6615         * amd64-tdep.c: Update.
6616         * arch-utils.c: Update.
6617         * break-catch-throw.c: Update.
6618         * breakpoint.c: Update.
6619         * btrace.c: Update.
6620         * c-varobj.c: Update.
6621         * cli/cli-cmds.c: Update.
6622         * cli/cli-interp.c: Update.
6623         * cli/cli-script.c: Update.
6624         * common/common-exceptions.c: Update.
6625         * common/new-op.c: Update.
6626         * common/selftest.c: Update.
6627         * compile/compile-c-symbols.c: Update.
6628         * compile/compile-cplus-symbols.c: Update.
6629         * compile/compile-object-load.c: Update.
6630         * compile/compile-object-run.c: Update.
6631         * completer.c: Update.
6632         * corelow.c: Update.
6633         * cp-abi.c: Update.
6634         * cp-support.c: Update.
6635         * cp-valprint.c: Update.
6636         * darwin-nat.c: Update.
6637         * disasm-selftests.c: Update.
6638         * dtrace-probe.c: Update.
6639         * dwarf-index-cache.c: Update.
6640         * dwarf-index-write.c: Update.
6641         * dwarf2-frame-tailcall.c: Update.
6642         * dwarf2-frame.c: Update.
6643         * dwarf2loc.c: Update.
6644         * dwarf2read.c: Update.
6645         * eval.c: Update.
6646         * event-loop.c: Update.
6647         * event-top.c: Update.
6648         * exec.c: Update.
6649         * f-valprint.c: Update.
6650         * fbsd-tdep.c: Update.
6651         * frame-unwind.c: Update.
6652         * frame.c: Update.
6653         * gdbtypes.c: Update.
6654         * gnu-v3-abi.c: Update.
6655         * guile/guile-internal.h: Update.
6656         * guile/scm-block.c: Update.
6657         * guile/scm-breakpoint.c: Update.
6658         * guile/scm-cmd.c: Update.
6659         * guile/scm-disasm.c: Update.
6660         * guile/scm-frame.c: Update.
6661         * guile/scm-lazy-string.c: Update.
6662         * guile/scm-math.c: Update.
6663         * guile/scm-param.c: Update.
6664         * guile/scm-ports.c: Update.
6665         * guile/scm-pretty-print.c: Update.
6666         * guile/scm-symbol.c: Update.
6667         * guile/scm-symtab.c: Update.
6668         * guile/scm-type.c: Update.
6669         * guile/scm-value.c: Update.
6670         * i386-linux-tdep.c: Update.
6671         * i386-tdep.c: Update.
6672         * inf-loop.c: Update.
6673         * infcall.c: Update.
6674         * infcmd.c: Update.
6675         * infrun.c: Update.
6676         * jit.c: Update.
6677         * language.c: Update.
6678         * linespec.c: Update.
6679         * linux-fork.c: Update.
6680         * linux-nat.c: Update.
6681         * linux-tdep.c: Update.
6682         * linux-thread-db.c: Update.
6683         * main.c: Update.
6684         * mi/mi-cmd-break.c: Update.
6685         * mi/mi-cmd-stack.c: Update.
6686         * mi/mi-interp.c: Update.
6687         * mi/mi-main.c: Update.
6688         * objc-lang.c: Update.
6689         * p-valprint.c: Update.
6690         * parse.c: Update.
6691         * ppc-linux-tdep.c: Update.
6692         * printcmd.c: Update.
6693         * python/py-arch.c: Update.
6694         * python/py-breakpoint.c: Update.
6695         * python/py-cmd.c: Update.
6696         * python/py-finishbreakpoint.c: Update.
6697         * python/py-frame.c: Update.
6698         * python/py-framefilter.c: Update.
6699         * python/py-gdb-readline.c: Update.
6700         * python/py-inferior.c: Update.
6701         * python/py-infthread.c: Update.
6702         * python/py-lazy-string.c: Update.
6703         * python/py-linetable.c: Update.
6704         * python/py-objfile.c: Update.
6705         * python/py-param.c: Update.
6706         * python/py-prettyprint.c: Update.
6707         * python/py-progspace.c: Update.
6708         * python/py-record-btrace.c: Update.
6709         * python/py-record.c: Update.
6710         * python/py-symbol.c: Update.
6711         * python/py-type.c: Update.
6712         * python/py-unwind.c: Update.
6713         * python/py-utils.c: Update.
6714         * python/py-value.c: Update.
6715         * python/python.c: Update.
6716         * record-btrace.c: Update.
6717         * record-full.c: Update.
6718         * remote-fileio.c: Update.
6719         * remote.c: Update.
6720         * riscv-tdep.c: Update.
6721         * rs6000-aix-tdep.c: Update.
6722         * rs6000-tdep.c: Update.
6723         * rust-exp.y: Update.
6724         * rust-lang.c: Update.
6725         * s390-tdep.c: Update.
6726         * selftest-arch.c: Update.
6727         * solib-dsbt.c: Update.
6728         * solib-frv.c: Update.
6729         * solib-spu.c: Update.
6730         * solib-svr4.c: Update.
6731         * solib.c: Update.
6732         * sparc64-linux-tdep.c: Update.
6733         * stack.c: Update.
6734         * symfile-mem.c: Update.
6735         * symmisc.c: Update.
6736         * target.c: Update.
6737         * thread.c: Update.
6738         * top.c: Update.
6739         * tracefile-tfile.c: Update.
6740         * tui/tui.c: Update.
6741         * typeprint.c: Update.
6742         * unittests/cli-utils-selftests.c: Update.
6743         * unittests/parse-connection-spec-selftests.c: Update.
6744         * valops.c: Update.
6745         * valprint.c: Update.
6746         * value.c: Update.
6747         * varobj.c: Update.
6748         * windows-nat.c: Update.
6749         * x86-linux-nat.c: Update.
6750         * xml-support.c: Update.
6751
6752 2019-04-08  Tom Tromey  <tom@tromey.com>
6753
6754         * xml-support.c: Use C++ exception handling.
6755         * x86-linux-nat.c: Use C++ exception handling.
6756         * windows-nat.c: Use C++ exception handling.
6757         * varobj.c: Use C++ exception handling.
6758         * value.c: Use C++ exception handling.
6759         * valprint.c: Use C++ exception handling.
6760         * valops.c: Use C++ exception handling.
6761         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6762         handling.
6763         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6764         * typeprint.c: Use C++ exception handling.
6765         * tui/tui.c: Use C++ exception handling.
6766         * tracefile-tfile.c: Use C++ exception handling.
6767         * top.c: Use C++ exception handling.
6768         * thread.c: Use C++ exception handling.
6769         * target.c: Use C++ exception handling.
6770         * symmisc.c: Use C++ exception handling.
6771         * symfile-mem.c: Use C++ exception handling.
6772         * stack.c: Use C++ exception handling.
6773         * sparc64-linux-tdep.c: Use C++ exception handling.
6774         * solib.c: Use C++ exception handling.
6775         * solib-svr4.c: Use C++ exception handling.
6776         * solib-spu.c: Use C++ exception handling.
6777         * solib-frv.c: Use C++ exception handling.
6778         * solib-dsbt.c: Use C++ exception handling.
6779         * selftest-arch.c: Use C++ exception handling.
6780         * s390-tdep.c: Use C++ exception handling.
6781         * rust-lang.c: Use C++ exception handling.
6782         * rust-exp.y: Use C++ exception handling.
6783         * rs6000-tdep.c: Use C++ exception handling.
6784         * rs6000-aix-tdep.c: Use C++ exception handling.
6785         * riscv-tdep.c: Use C++ exception handling.
6786         * remote.c: Use C++ exception handling.
6787         * remote-fileio.c: Use C++ exception handling.
6788         * record-full.c: Use C++ exception handling.
6789         * record-btrace.c: Use C++ exception handling.
6790         * python/python.c: Use C++ exception handling.
6791         * python/py-value.c: Use C++ exception handling.
6792         * python/py-utils.c: Use C++ exception handling.
6793         * python/py-unwind.c: Use C++ exception handling.
6794         * python/py-type.c: Use C++ exception handling.
6795         * python/py-symbol.c: Use C++ exception handling.
6796         * python/py-record.c: Use C++ exception handling.
6797         * python/py-record-btrace.c: Use C++ exception handling.
6798         * python/py-progspace.c: Use C++ exception handling.
6799         * python/py-prettyprint.c: Use C++ exception handling.
6800         * python/py-param.c: Use C++ exception handling.
6801         * python/py-objfile.c: Use C++ exception handling.
6802         * python/py-linetable.c: Use C++ exception handling.
6803         * python/py-lazy-string.c: Use C++ exception handling.
6804         * python/py-infthread.c: Use C++ exception handling.
6805         * python/py-inferior.c: Use C++ exception handling.
6806         * python/py-gdb-readline.c: Use C++ exception handling.
6807         * python/py-framefilter.c: Use C++ exception handling.
6808         * python/py-frame.c: Use C++ exception handling.
6809         * python/py-finishbreakpoint.c: Use C++ exception handling.
6810         * python/py-cmd.c: Use C++ exception handling.
6811         * python/py-breakpoint.c: Use C++ exception handling.
6812         * python/py-arch.c: Use C++ exception handling.
6813         * printcmd.c: Use C++ exception handling.
6814         * ppc-linux-tdep.c: Use C++ exception handling.
6815         * parse.c: Use C++ exception handling.
6816         * p-valprint.c: Use C++ exception handling.
6817         * objc-lang.c: Use C++ exception handling.
6818         * mi/mi-main.c: Use C++ exception handling.
6819         * mi/mi-interp.c: Use C++ exception handling.
6820         * mi/mi-cmd-stack.c: Use C++ exception handling.
6821         * mi/mi-cmd-break.c: Use C++ exception handling.
6822         * main.c: Use C++ exception handling.
6823         * linux-thread-db.c: Use C++ exception handling.
6824         * linux-tdep.c: Use C++ exception handling.
6825         * linux-nat.c: Use C++ exception handling.
6826         * linux-fork.c: Use C++ exception handling.
6827         * linespec.c: Use C++ exception handling.
6828         * language.c: Use C++ exception handling.
6829         * jit.c: Use C++ exception handling.
6830         * infrun.c: Use C++ exception handling.
6831         * infcmd.c: Use C++ exception handling.
6832         * infcall.c: Use C++ exception handling.
6833         * inf-loop.c: Use C++ exception handling.
6834         * i386-tdep.c: Use C++ exception handling.
6835         * i386-linux-tdep.c: Use C++ exception handling.
6836         * guile/scm-value.c: Use C++ exception handling.
6837         * guile/scm-type.c: Use C++ exception handling.
6838         * guile/scm-symtab.c: Use C++ exception handling.
6839         * guile/scm-symbol.c: Use C++ exception handling.
6840         * guile/scm-pretty-print.c: Use C++ exception handling.
6841         * guile/scm-ports.c: Use C++ exception handling.
6842         * guile/scm-param.c: Use C++ exception handling.
6843         * guile/scm-math.c: Use C++ exception handling.
6844         * guile/scm-lazy-string.c: Use C++ exception handling.
6845         * guile/scm-frame.c: Use C++ exception handling.
6846         * guile/scm-disasm.c: Use C++ exception handling.
6847         * guile/scm-cmd.c: Use C++ exception handling.
6848         * guile/scm-breakpoint.c: Use C++ exception handling.
6849         * guile/scm-block.c: Use C++ exception handling.
6850         * guile/guile-internal.h: Use C++ exception handling.
6851         * gnu-v3-abi.c: Use C++ exception handling.
6852         * gdbtypes.c: Use C++ exception handling.
6853         * frame.c: Use C++ exception handling.
6854         * frame-unwind.c: Use C++ exception handling.
6855         * fbsd-tdep.c: Use C++ exception handling.
6856         * f-valprint.c: Use C++ exception handling.
6857         * exec.c: Use C++ exception handling.
6858         * event-top.c: Use C++ exception handling.
6859         * event-loop.c: Use C++ exception handling.
6860         * eval.c: Use C++ exception handling.
6861         * dwarf2read.c: Use C++ exception handling.
6862         * dwarf2loc.c: Use C++ exception handling.
6863         * dwarf2-frame.c: Use C++ exception handling.
6864         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6865         * dwarf-index-write.c: Use C++ exception handling.
6866         * dwarf-index-cache.c: Use C++ exception handling.
6867         * dtrace-probe.c: Use C++ exception handling.
6868         * disasm-selftests.c: Use C++ exception handling.
6869         * darwin-nat.c: Use C++ exception handling.
6870         * cp-valprint.c: Use C++ exception handling.
6871         * cp-support.c: Use C++ exception handling.
6872         * cp-abi.c: Use C++ exception handling.
6873         * corelow.c: Use C++ exception handling.
6874         * completer.c: Use C++ exception handling.
6875         * compile/compile-object-run.c: Use C++ exception handling.
6876         * compile/compile-object-load.c: Use C++ exception handling.
6877         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6878         * compile/compile-c-symbols.c: Use C++ exception handling.
6879         * common/selftest.c: Use C++ exception handling.
6880         * common/new-op.c: Use C++ exception handling.
6881         * cli/cli-script.c: Use C++ exception handling.
6882         * cli/cli-interp.c: Use C++ exception handling.
6883         * cli/cli-cmds.c: Use C++ exception handling.
6884         * c-varobj.c: Use C++ exception handling.
6885         * btrace.c: Use C++ exception handling.
6886         * breakpoint.c: Use C++ exception handling.
6887         * break-catch-throw.c: Use C++ exception handling.
6888         * arch-utils.c: Use C++ exception handling.
6889         * amd64-tdep.c: Use C++ exception handling.
6890         * ada-valprint.c: Use C++ exception handling.
6891         * ada-typeprint.c: Use C++ exception handling.
6892         * ada-lang.c: Use C++ exception handling.
6893         * aarch64-tdep.c: Use C++ exception handling.
6894
6895 2019-04-08  Tom Tromey  <tom@tromey.com>
6896
6897         * xml-support.c (gdb_xml_parser::parse): Update.
6898         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6899         * value.c (show_convenience): Update.
6900         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6901         (test_parse_flags_qcs): Update.
6902         * thread.c (thr_try_catch_cmd): Update.
6903         * target.c (target_translate_tls_address): Update.
6904         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6905         (info_frame_command_core, frame_apply_command_count): Update.
6906         * rust-exp.y (rust_lex_exception_test): Update.
6907         * riscv-tdep.c (riscv_print_one_register_info): Update.
6908         * remote.c (remote_target::enable_btrace): Update.
6909         * record-btrace.c (record_btrace_enable_warn): Update.
6910         * python/py-utils.c (gdbpy_convert_exception): Update.
6911         * printcmd.c (do_one_display, print_variable_and_value): Update.
6912         * mi/mi-main.c (mi_print_exception): Update.
6913         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6914         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6915         * linux-nat.c (linux_nat_target::attach): Update.
6916         * linux-fork.c (class scoped_switch_fork_info): Update.
6917         * infrun.c (displaced_step_prepare): Update.
6918         * infcall.c (call_function_by_hand_dummy): Update.
6919         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6920         * gnu-v3-abi.c (print_one_vtable): Update.
6921         * frame.c (get_prev_frame_always): Update.
6922         * f-valprint.c (info_common_command_for_block): Update.
6923         * exec.c (try_open_exec_file): Update.
6924         * exceptions.c (print_exception, exception_print)
6925         (exception_fprintf, exception_print_same): Update.
6926         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6927         * dwarf-index-cache.c (index_cache::store)
6928         (index_cache::lookup_gdb_index): Update.
6929         * darwin-nat.c (maybe_cache_shell): Update.
6930         * cp-valprint.c (cp_print_value_fields): Update.
6931         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6932         (gcc_cplus_symbol_address): Update.
6933         * compile/compile-c-symbols.c (gcc_convert_symbol)
6934         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6935         * common/selftest.c: Update.
6936         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6937         a std::string.
6938         (exception_try_scope_entry, exception_try_scope_exit): Don't
6939         declare.
6940         (struct exception_try_scope): Remove.
6941         (TRY): Don't use exception_try_scope.
6942         (struct gdb_exception): Add constructor, operator=.
6943         <what>: New method.
6944         (struct gdb_exception_RETURN_MASK_ALL)
6945         (struct gdb_exception_RETURN_MASK_ERROR)
6946         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6947         (struct gdb_quit_bad_alloc): Update.
6948         * common/common-exceptions.c (exception_none): Change
6949         initializer.
6950         (struct catcher) <state, exception>: Initialize inline.
6951         <prev>: Remove member.
6952         (current_catcher): Remove.
6953         (catchers): New global.
6954         (exceptions_state_mc_init): Simplify.
6955         (catcher_pop): Remove.
6956         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6957         (try_scope_depth, exception_try_scope_entry)
6958         (exception_try_scope_exit): Remove.
6959         (throw_exception_sjlj): Update.
6960         (exception_messages, exception_messages_size): Remove.
6961         (throw_it): Simplify.
6962         (gdb_exception_sliced_copy): Remove.
6963         (throw_exception_cxx): Update.
6964         * cli/cli-script.c (script_from_file): Update.
6965         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6966         Update.
6967         * ada-valprint.c (ada_val_print): Update.
6968         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6969         (create_excep_cond_exprs): Update.
6970
6971 2019-04-08  Tom Tromey  <tom@tromey.com>
6972
6973         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6974         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6975         (TRY, CATCH, END_CATCH): Remove some definitions.
6976         * common/common-exceptions.c: Don't use GDB_XCPT.
6977         (catcher_list_size): Remove.
6978         (throw_exception, throw_it): Simplify.
6979
6980 2019-04-05  Tom Tromey  <tom@tromey.com>
6981
6982         Revert the header-sorting patch.
6983         * ft32-tdep.c: Revert.
6984         * frv-tdep.c: Revert.
6985         * frv-linux-tdep.c: Revert.
6986         * frame.c: Revert.
6987         * frame-unwind.c: Revert.
6988         * frame-base.c: Revert.
6989         * fork-child.c: Revert.
6990         * findvar.c: Revert.
6991         * findcmd.c: Revert.
6992         * filesystem.c: Revert.
6993         * filename-seen-cache.h: Revert.
6994         * filename-seen-cache.c: Revert.
6995         * fbsd-tdep.c: Revert.
6996         * fbsd-nat.h: Revert.
6997         * fbsd-nat.c: Revert.
6998         * f-valprint.c: Revert.
6999         * f-typeprint.c: Revert.
7000         * f-lang.c: Revert.
7001         * extension.h: Revert.
7002         * extension.c: Revert.
7003         * extension-priv.h: Revert.
7004         * expprint.c: Revert.
7005         * exec.h: Revert.
7006         * exec.c: Revert.
7007         * exceptions.c: Revert.
7008         * event-top.c: Revert.
7009         * event-loop.c: Revert.
7010         * eval.c: Revert.
7011         * elfread.c: Revert.
7012         * dwarf2read.h: Revert.
7013         * dwarf2read.c: Revert.
7014         * dwarf2loc.c: Revert.
7015         * dwarf2expr.h: Revert.
7016         * dwarf2expr.c: Revert.
7017         * dwarf2-frame.c: Revert.
7018         * dwarf2-frame-tailcall.c: Revert.
7019         * dwarf-index-write.h: Revert.
7020         * dwarf-index-write.c: Revert.
7021         * dwarf-index-common.c: Revert.
7022         * dwarf-index-cache.h: Revert.
7023         * dwarf-index-cache.c: Revert.
7024         * dummy-frame.c: Revert.
7025         * dtrace-probe.c: Revert.
7026         * disasm.h: Revert.
7027         * disasm.c: Revert.
7028         * disasm-selftests.c: Revert.
7029         * dictionary.c: Revert.
7030         * dicos-tdep.c: Revert.
7031         * demangle.c: Revert.
7032         * dcache.h: Revert.
7033         * dcache.c: Revert.
7034         * darwin-nat.h: Revert.
7035         * darwin-nat.c: Revert.
7036         * darwin-nat-info.c: Revert.
7037         * d-valprint.c: Revert.
7038         * d-namespace.c: Revert.
7039         * d-lang.c: Revert.
7040         * ctf.c: Revert.
7041         * csky-tdep.c: Revert.
7042         * csky-linux-tdep.c: Revert.
7043         * cris-tdep.c: Revert.
7044         * cris-linux-tdep.c: Revert.
7045         * cp-valprint.c: Revert.
7046         * cp-support.c: Revert.
7047         * cp-namespace.c: Revert.
7048         * cp-abi.c: Revert.
7049         * corelow.c: Revert.
7050         * corefile.c: Revert.
7051         * continuations.c: Revert.
7052         * completer.h: Revert.
7053         * completer.c: Revert.
7054         * complaints.c: Revert.
7055         * coffread.c: Revert.
7056         * coff-pe-read.c: Revert.
7057         * cli-out.h: Revert.
7058         * cli-out.c: Revert.
7059         * charset.c: Revert.
7060         * c-varobj.c: Revert.
7061         * c-valprint.c: Revert.
7062         * c-typeprint.c: Revert.
7063         * c-lang.c: Revert.
7064         * buildsym.c: Revert.
7065         * buildsym-legacy.c: Revert.
7066         * build-id.h: Revert.
7067         * build-id.c: Revert.
7068         * btrace.c: Revert.
7069         * bsd-uthread.c: Revert.
7070         * breakpoint.h: Revert.
7071         * breakpoint.c: Revert.
7072         * break-catch-throw.c: Revert.
7073         * break-catch-syscall.c: Revert.
7074         * break-catch-sig.c: Revert.
7075         * blockframe.c: Revert.
7076         * block.c: Revert.
7077         * bfin-tdep.c: Revert.
7078         * bfin-linux-tdep.c: Revert.
7079         * bfd-target.c: Revert.
7080         * bcache.c: Revert.
7081         * ax-general.c: Revert.
7082         * ax-gdb.h: Revert.
7083         * ax-gdb.c: Revert.
7084         * avr-tdep.c: Revert.
7085         * auxv.c: Revert.
7086         * auto-load.c: Revert.
7087         * arm-wince-tdep.c: Revert.
7088         * arm-tdep.c: Revert.
7089         * arm-symbian-tdep.c: Revert.
7090         * arm-pikeos-tdep.c: Revert.
7091         * arm-obsd-tdep.c: Revert.
7092         * arm-nbsd-tdep.c: Revert.
7093         * arm-nbsd-nat.c: Revert.
7094         * arm-linux-tdep.c: Revert.
7095         * arm-linux-nat.c: Revert.
7096         * arm-fbsd-tdep.c: Revert.
7097         * arm-fbsd-nat.c: Revert.
7098         * arm-bsd-tdep.c: Revert.
7099         * arch-utils.c: Revert.
7100         * arc-tdep.c: Revert.
7101         * arc-newlib-tdep.c: Revert.
7102         * annotate.h: Revert.
7103         * annotate.c: Revert.
7104         * amd64-windows-tdep.c: Revert.
7105         * amd64-windows-nat.c: Revert.
7106         * amd64-tdep.c: Revert.
7107         * amd64-sol2-tdep.c: Revert.
7108         * amd64-obsd-tdep.c: Revert.
7109         * amd64-obsd-nat.c: Revert.
7110         * amd64-nbsd-tdep.c: Revert.
7111         * amd64-nbsd-nat.c: Revert.
7112         * amd64-nat.c: Revert.
7113         * amd64-linux-tdep.c: Revert.
7114         * amd64-linux-nat.c: Revert.
7115         * amd64-fbsd-tdep.c: Revert.
7116         * amd64-fbsd-nat.c: Revert.
7117         * amd64-dicos-tdep.c: Revert.
7118         * amd64-darwin-tdep.c: Revert.
7119         * amd64-bsd-nat.c: Revert.
7120         * alpha-tdep.c: Revert.
7121         * alpha-obsd-tdep.c: Revert.
7122         * alpha-nbsd-tdep.c: Revert.
7123         * alpha-mdebug-tdep.c: Revert.
7124         * alpha-linux-tdep.c: Revert.
7125         * alpha-linux-nat.c: Revert.
7126         * alpha-bsd-tdep.c: Revert.
7127         * alpha-bsd-nat.c: Revert.
7128         * aix-thread.c: Revert.
7129         * agent.c: Revert.
7130         * addrmap.c: Revert.
7131         * ada-varobj.c: Revert.
7132         * ada-valprint.c: Revert.
7133         * ada-typeprint.c: Revert.
7134         * ada-tasks.c: Revert.
7135         * ada-lang.c: Revert.
7136         * aarch64-tdep.c: Revert.
7137         * aarch64-ravenscar-thread.c: Revert.
7138         * aarch64-newlib-tdep.c: Revert.
7139         * aarch64-linux-tdep.c: Revert.
7140         * aarch64-linux-nat.c: Revert.
7141         * aarch64-fbsd-tdep.c: Revert.
7142         * aarch64-fbsd-nat.c: Revert.
7143         * aarch32-linux-nat.c: Revert.
7144
7145 2019-04-05  Tom Tromey  <tom@tromey.com>
7146
7147         * ft32-tdep.c: Sort headers.
7148         * frv-tdep.c: Sort headers.
7149         * frv-linux-tdep.c: Sort headers.
7150         * frame.c: Sort headers.
7151         * frame-unwind.c: Sort headers.
7152         * frame-base.c: Sort headers.
7153         * fork-child.c: Sort headers.
7154         * findvar.c: Sort headers.
7155         * findcmd.c: Sort headers.
7156         * filesystem.c: Sort headers.
7157         * filename-seen-cache.h: Sort headers.
7158         * filename-seen-cache.c: Sort headers.
7159         * fbsd-tdep.c: Sort headers.
7160         * fbsd-nat.h: Sort headers.
7161         * fbsd-nat.c: Sort headers.
7162         * f-valprint.c: Sort headers.
7163         * f-typeprint.c: Sort headers.
7164         * f-lang.c: Sort headers.
7165         * extension.h: Sort headers.
7166         * extension.c: Sort headers.
7167         * extension-priv.h: Sort headers.
7168         * expprint.c: Sort headers.
7169         * exec.h: Sort headers.
7170         * exec.c: Sort headers.
7171         * exceptions.c: Sort headers.
7172         * event-top.c: Sort headers.
7173         * event-loop.c: Sort headers.
7174         * eval.c: Sort headers.
7175         * elfread.c: Sort headers.
7176         * dwarf2read.h: Sort headers.
7177         * dwarf2read.c: Sort headers.
7178         * dwarf2loc.c: Sort headers.
7179         * dwarf2expr.h: Sort headers.
7180         * dwarf2expr.c: Sort headers.
7181         * dwarf2-frame.c: Sort headers.
7182         * dwarf2-frame-tailcall.c: Sort headers.
7183         * dwarf-index-write.h: Sort headers.
7184         * dwarf-index-write.c: Sort headers.
7185         * dwarf-index-common.c: Sort headers.
7186         * dwarf-index-cache.h: Sort headers.
7187         * dwarf-index-cache.c: Sort headers.
7188         * dummy-frame.c: Sort headers.
7189         * dtrace-probe.c: Sort headers.
7190         * disasm.h: Sort headers.
7191         * disasm.c: Sort headers.
7192         * disasm-selftests.c: Sort headers.
7193         * dictionary.c: Sort headers.
7194         * dicos-tdep.c: Sort headers.
7195         * demangle.c: Sort headers.
7196         * dcache.h: Sort headers.
7197         * dcache.c: Sort headers.
7198         * darwin-nat.h: Sort headers.
7199         * darwin-nat.c: Sort headers.
7200         * darwin-nat-info.c: Sort headers.
7201         * d-valprint.c: Sort headers.
7202         * d-namespace.c: Sort headers.
7203         * d-lang.c: Sort headers.
7204         * ctf.c: Sort headers.
7205         * csky-tdep.c: Sort headers.
7206         * csky-linux-tdep.c: Sort headers.
7207         * cris-tdep.c: Sort headers.
7208         * cris-linux-tdep.c: Sort headers.
7209         * cp-valprint.c: Sort headers.
7210         * cp-support.c: Sort headers.
7211         * cp-namespace.c: Sort headers.
7212         * cp-abi.c: Sort headers.
7213         * corelow.c: Sort headers.
7214         * corefile.c: Sort headers.
7215         * continuations.c: Sort headers.
7216         * completer.h: Sort headers.
7217         * completer.c: Sort headers.
7218         * complaints.c: Sort headers.
7219         * coffread.c: Sort headers.
7220         * coff-pe-read.c: Sort headers.
7221         * cli-out.h: Sort headers.
7222         * cli-out.c: Sort headers.
7223         * charset.c: Sort headers.
7224         * c-varobj.c: Sort headers.
7225         * c-valprint.c: Sort headers.
7226         * c-typeprint.c: Sort headers.
7227         * c-lang.c: Sort headers.
7228         * buildsym.c: Sort headers.
7229         * buildsym-legacy.c: Sort headers.
7230         * build-id.h: Sort headers.
7231         * build-id.c: Sort headers.
7232         * btrace.c: Sort headers.
7233         * bsd-uthread.c: Sort headers.
7234         * breakpoint.h: Sort headers.
7235         * breakpoint.c: Sort headers.
7236         * break-catch-throw.c: Sort headers.
7237         * break-catch-syscall.c: Sort headers.
7238         * break-catch-sig.c: Sort headers.
7239         * blockframe.c: Sort headers.
7240         * block.c: Sort headers.
7241         * bfin-tdep.c: Sort headers.
7242         * bfin-linux-tdep.c: Sort headers.
7243         * bfd-target.c: Sort headers.
7244         * bcache.c: Sort headers.
7245         * ax-general.c: Sort headers.
7246         * ax-gdb.h: Sort headers.
7247         * ax-gdb.c: Sort headers.
7248         * avr-tdep.c: Sort headers.
7249         * auxv.c: Sort headers.
7250         * auto-load.c: Sort headers.
7251         * arm-wince-tdep.c: Sort headers.
7252         * arm-tdep.c: Sort headers.
7253         * arm-symbian-tdep.c: Sort headers.
7254         * arm-pikeos-tdep.c: Sort headers.
7255         * arm-obsd-tdep.c: Sort headers.
7256         * arm-nbsd-tdep.c: Sort headers.
7257         * arm-nbsd-nat.c: Sort headers.
7258         * arm-linux-tdep.c: Sort headers.
7259         * arm-linux-nat.c: Sort headers.
7260         * arm-fbsd-tdep.c: Sort headers.
7261         * arm-fbsd-nat.c: Sort headers.
7262         * arm-bsd-tdep.c: Sort headers.
7263         * arch-utils.c: Sort headers.
7264         * arc-tdep.c: Sort headers.
7265         * arc-newlib-tdep.c: Sort headers.
7266         * annotate.h: Sort headers.
7267         * annotate.c: Sort headers.
7268         * amd64-windows-tdep.c: Sort headers.
7269         * amd64-windows-nat.c: Sort headers.
7270         * amd64-tdep.c: Sort headers.
7271         * amd64-sol2-tdep.c: Sort headers.
7272         * amd64-obsd-tdep.c: Sort headers.
7273         * amd64-obsd-nat.c: Sort headers.
7274         * amd64-nbsd-tdep.c: Sort headers.
7275         * amd64-nbsd-nat.c: Sort headers.
7276         * amd64-nat.c: Sort headers.
7277         * amd64-linux-tdep.c: Sort headers.
7278         * amd64-linux-nat.c: Sort headers.
7279         * amd64-fbsd-tdep.c: Sort headers.
7280         * amd64-fbsd-nat.c: Sort headers.
7281         * amd64-dicos-tdep.c: Sort headers.
7282         * amd64-darwin-tdep.c: Sort headers.
7283         * amd64-bsd-nat.c: Sort headers.
7284         * alpha-tdep.c: Sort headers.
7285         * alpha-obsd-tdep.c: Sort headers.
7286         * alpha-nbsd-tdep.c: Sort headers.
7287         * alpha-mdebug-tdep.c: Sort headers.
7288         * alpha-linux-tdep.c: Sort headers.
7289         * alpha-linux-nat.c: Sort headers.
7290         * alpha-bsd-tdep.c: Sort headers.
7291         * alpha-bsd-nat.c: Sort headers.
7292         * aix-thread.c: Sort headers.
7293         * agent.c: Sort headers.
7294         * addrmap.c: Sort headers.
7295         * ada-varobj.c: Sort headers.
7296         * ada-valprint.c: Sort headers.
7297         * ada-typeprint.c: Sort headers.
7298         * ada-tasks.c: Sort headers.
7299         * ada-lang.c: Sort headers.
7300         * aarch64-tdep.c: Sort headers.
7301         * aarch64-ravenscar-thread.c: Sort headers.
7302         * aarch64-newlib-tdep.c: Sort headers.
7303         * aarch64-linux-tdep.c: Sort headers.
7304         * aarch64-linux-nat.c: Sort headers.
7305         * aarch64-fbsd-tdep.c: Sort headers.
7306         * aarch64-fbsd-nat.c: Sort headers.
7307         * aarch32-linux-nat.c: Sort headers.
7308
7309 2019-04-04  Tom Tromey  <tom@tromey.com>
7310
7311         * varobj.c (varobj_create): Update.
7312         * rust-exp.y (struct rust_parser) <update_innermost_block,
7313         lookup_symbol>: New methods.
7314         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7315         Rename.
7316         (rust_parser::rust_lookup_type)
7317         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7318         * printcmd.c (display_command, do_one_display): Update.
7319         * parser-defs.h (struct parser_state) <parser_state>: Add
7320         "tracker" parameter.
7321         (block_tracker): New member.
7322         (class innermost_block_tracker) <innermost_block_tracker>: Add
7323         "types" parameter.
7324         <reset>: Remove method.
7325         (innermost_block): Don't declare.
7326         (null_post_parser): Update.
7327         * parse.c (innermost_block): Remove global.
7328         (write_dollar_variable): Update.
7329         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7330         Remove "tracker_types" parameter.
7331         (parse_expression): Add "tracker" parameter.
7332         (parse_expression_for_completion): Update.
7333         (null_post_parser): Add "tracker" parameter.
7334         * p-exp.y: Update rules.
7335         * m2-exp.y: Update rules.
7336         * language.h (struct language_defn) <la_post_parser>: Add
7337         "tracker" parameter.
7338         * go-exp.y: Update rules.
7339         * f-exp.y: Update rules.
7340         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7341         parameter.
7342         * d-exp.y: Update rules.
7343         * c-exp.y: Update rules.
7344         * breakpoint.c (set_breakpoint_condition): Create an
7345         innermost_block_tracker.
7346         (watch_command_1): Likewise.
7347         * ada-lang.c (resolve): Add "tracker" parameter.
7348         (resolve_subexp): Likewise.
7349         * ada-exp.y (write_var_from_sym): Update.
7350
7351 2019-04-04  Tom Tromey  <tom@tromey.com>
7352
7353         * type-stack.h: New file.
7354         * type-stack.c: New file.
7355         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7356         type-stack.h.
7357         (insert_into_type_stack, insert_type, push_type, push_type_int)
7358         (insert_type_address_space, pop_type, pop_type_int)
7359         (pop_typelist, pop_type_stack, append_type_stack)
7360         (push_type_stack, get_type_stack, push_typelist)
7361         (follow_type_instance_flags, follow_types): Don't declare.
7362         * parse.c (type_stack): Remove global.
7363         (parse_exp_in_context): Update.
7364         (insert_into_type_stack, insert_type, push_type, push_type_int)
7365         (insert_type_address_space, pop_type, pop_type_int)
7366         (pop_typelist, pop_type_stack, append_type_stack)
7367         (push_type_stack, get_type_stack, push_typelist)
7368         (follow_type_instance_flags, follow_types): Remove (moved to
7369         type-stack.c).
7370         * f-exp.y (type_stack): New global.
7371         Update rules.
7372         (push_kind_type, f_parse): Update.
7373         * d-exp.y (type_stack): New global.
7374         Update rules.
7375         (d_parse): Update.
7376         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7377         Update rules.
7378         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7379         (HFILES_NO_SRCDIR): Add type-stack.h.
7380
7381 2019-04-04  Tom Tromey  <tom@tromey.com>
7382
7383         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7384         (rust_parser::convert_ast_to_expression, rust_parse)
7385         (rust_lex_test_completion, rust_lex_tests): Update.
7386         * parser-defs.h (struct expr_completion_state): New.
7387         (struct parser_state) <parser_state>: Add completion parameter.
7388         <mark_struct_expression, mark_completion_tag>: New methods.
7389         <parse_completion, m_completion_state>: New members.
7390         (prefixify_expression, null_post_parser): Update.
7391         (mark_struct_expression, mark_completion_tag): Don't declare.
7392         * parse.c (parse_completion, expout_last_struct)
7393         (expout_tag_completion_type, expout_completion_name): Remove
7394         globals.
7395         (parser_state::mark_struct_expression)
7396         (parser_state::mark_completion_tag): Now methods.
7397         (prefixify_expression): Add last_struct parameter.
7398         (prefixify_subexp): Likewise.
7399         (parse_exp_1): Update.
7400         (parse_exp_in_context): Add cstate parameter.  Update.
7401         (parse_expression_for_completion): Create an
7402         expr_completion_state.
7403         (null_post_parser): Add "completion" parameter.
7404         * p-exp.y: Update rules.
7405         (yylex): Update.
7406         * language.h (struct language_defn) <la_post_parser>: Add
7407         "completing" parameter.
7408         * go-exp.y: Update rules.
7409         (lex_one_token): Update.
7410         * expression.h (parse_completion): Don't declare.
7411         * d-exp.y: Update rules.
7412         (lex_one_token): Update rules.
7413         * c-exp.y: Update rules.
7414         (lex_one_token): Update.
7415         * ada-lang.c (resolve): Add "parse_completion" parameter.
7416         (resolve_subexp): Likewise.
7417         (ada_resolve_function): Likewise.
7418
7419 2019-04-04  Tom Tromey  <tom@tromey.com>
7420
7421         * parser-defs.h (struct parser_state) <start_arglist,
7422         end_arglist>: New methods.
7423         <arglist_len, m_funcall_chain>: New members.
7424         (arglist_len, start_arglist, end_arglist): Don't declare.
7425         * parse.c (arglist_len, funcall_chain): Remove global.
7426         (start_arglist, end_arglist): Remove functions.
7427         (parse_exp_in_context): Update.
7428         * p-exp.y: Update rules.
7429         * m2-exp.y: Update rules.
7430         * go-exp.y: Update rules.
7431         * f-exp.y: Update rules.
7432         * d-exp.y: Update rules.
7433         * c-exp.y: Update rules.
7434
7435 2019-04-04  Tom Tromey  <tom@tromey.com>
7436
7437         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7438         lex_operator, push_back>: New methods.
7439         Update all rules.
7440         (rust_parser::lex_hex, lex_escape): Rename and update.
7441         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7442         (rust_parser::lex_operator): Rename and update.
7443         (rust_parser::lex_number, rustyylex, rustyyerror)
7444         (rust_lex_test_init, rust_lex_test_sequence)
7445         (rust_lex_test_push_back, rust_lex_tests): Update.
7446         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7447         parameter.
7448         <lexptr, prev_lexptr>: New members.
7449         (lexptr, prev_lexptr): Don't declare.
7450         * parse.c (lexptr, prev_lexptr): Remove globals.
7451         (parse_exp_in_context): Update.
7452         * p-exp.y (yylex, yyerror): Update.
7453         * m2-exp.y (parse_number, yylex, yyerror): Update.
7454         * go-exp.y (lex_one_token, yyerror): Update.
7455         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7456         * d-exp.y (lex_one_token, yyerror): Update.
7457         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7458         (lex_one_token, yyerror): Update.
7459         * ada-lex.l (YY_INPUT): Update.
7460         (rewind_to_char): Update.
7461         * ada-exp.y (yyerror): Update.
7462
7463 2019-04-04  Tom Tromey  <tom@tromey.com>
7464
7465         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7466         * parser-defs.h (struct parser_state) <parser_state>: Add new
7467         parameter.
7468         <comma_terminates>: New member.
7469         (comma_terminates): Don't declare global.
7470         * parse.c (comma_terminates): Remove global.
7471         (parse_exp_in_context): Update.
7472         * p-exp.y (yylex): Update.
7473         * m2-exp.y (yylex): Update.
7474         * go-exp.y (lex_one_token): Update.
7475         * f-exp.y (yylex): Update.
7476         * d-exp.y (lex_one_token): Update.
7477         * c-exp.y (lex_one_token): Update.
7478         * ada-lex.l: Update.
7479
7480 2019-04-04  Tom Tromey  <tom@tromey.com>
7481
7482         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7483         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7484         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7485         * parser-defs.h (paren_depth): Don't declare.
7486         * parse.c (paren_depth): Remove global.
7487         (parse_exp_in_context): Update.
7488         * p-exp.y (paren_depth): New global.
7489         (pascal_parse): Initialize it.
7490         * m2-exp.y (paren_depth): New global.
7491         (m2_parse): Initialize it.
7492         * go-exp.y (paren_depth): New global.
7493         (go_parse): Initialize it.
7494         * f-exp.y (paren_depth): New global.
7495         (f_parse): Initialize it.
7496         * d-exp.y (paren_depth): New global.
7497         (d_parse): Initialize it.
7498         * c-exp.y (paren_depth): New global.
7499         (c_parse): Initialize it.
7500         * ada-lex.l (paren_depth): New global.
7501         (lexer_init): Initialize it.
7502
7503 2019-04-04  Tom Tromey  <tom@tromey.com>
7504
7505         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7506         (rust_parser::convert_ast_to_type)
7507         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7508         * parser-defs.h (struct parser_state) <parser_state>: Add
7509         parameters.  Initialize new members.
7510         <expression_context_block, expression_context_pc>: New members.
7511         * parse.c (expression_context_block, expression_context_pc):
7512         Remove globals.
7513         (parse_exp_in_context): Update.
7514         * p-exp.y: Update all rules.
7515         (yylex): Update.
7516         * m2-exp.y: Update all rules.
7517         (yylex): Update.
7518         * go-exp.y (yylex): Update.
7519         * f-exp.y (yylex): Update.
7520         * d-exp.y: Update all rules.
7521         (yylex): Update.
7522         * c-exp.y: Update all rules.
7523         (lex_one_token, classify_name, yylex, c_parse): Update.
7524         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7525
7526 2019-04-04  Tom Tromey  <tom@tromey.com>
7527
7528         * gdbarch.h, gdbarch.c: Rebuild.
7529         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7530         * stap-probe.h:
7531         (struct stap_parse_info): Replace "parser_state" with
7532         "expr_builder".
7533         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7534         (parser_state): New class.
7535         * parse.c (expr_builder): Rename.
7536         (expr_builder::release): Rename.
7537         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7538         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7539         (write_exp_elt_longcst, write_exp_elt_floatcst)
7540         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7541         (write_exp_string_vector, write_exp_bitstring)
7542         (write_exp_msymbol, mark_struct_expression)
7543         (write_dollar_variable)
7544         (insert_type_address_space, increase_expout_size): Replace
7545         "parser_state" with "expr_builder".
7546         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7547         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7548         "parser_state" with "expr_builder".
7549
7550 2019-04-04  Tom Tromey  <tom@tromey.com>
7551
7552         * rust-exp.y: Replace "parse_language" with method call.
7553         * p-exp.y:
7554         (yylex): Replace "parse_language" with method call.
7555         * m2-exp.y:
7556         (yylex): Replace "parse_language" with method call.
7557         * go-exp.y (classify_name): Replace "parse_language" with method
7558         call.
7559         * f-exp.y (yylex): Replace "parse_language" with method call.
7560         * d-exp.y (lex_one_token): Replace "parse_language" with method
7561         call.
7562         * c-exp.y:
7563         (lex_one_token, classify_name, yylex): Replace "parse_language"
7564         with method call.
7565         * ada-exp.y (find_primitive_type, type_char)
7566         (type_system_address): Replace "parse_language" with method call.
7567
7568 2019-04-04  Tom Tromey  <tom@tromey.com>
7569
7570         * rust-exp.y: Replace "parse_gdbarch" with method call.
7571         * parse.c (write_dollar_variable, insert_type_address_space):
7572         Replace "parse_gdbarch" with method call.
7573         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7574         call.
7575         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7576         call.
7577         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7578         "parse_gdbarch" with method call.
7579         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7580         with method call.
7581         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7582         "parse_gdbarch" with method call.
7583         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7584         "parse_gdbarch" with method call.
7585         * c-exp.y (parse_type, parse_number, classify_name): Replace
7586         "parse_gdbarch" with method call.
7587         * ada-lex.l: Replace "parse_gdbarch" with method call.
7588         * ada-exp.y (parse_type, find_primitive_type, type_char)
7589         (type_system_address): Replace "parse_gdbarch" with method call.
7590
7591 2019-04-04  Tom Tromey  <tom@tromey.com>
7592
7593         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7594         * stap-probe.c (stap_parse_argument): Update.
7595         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7596         initial_size parameter.
7597         * rust-exp.y (rust_lex_tests): Update.
7598         * parse.c (parser_state): Update.
7599         (parse_exp_in_context): Update.
7600         * parser-defs.h (struct parser_state) <parser_state>: Remove
7601         "initial_size" parameter.
7602
7603 2019-04-04  Tom Tromey  <tom@tromey.com>
7604
7605         * parser-defs.h (increase_expout_size): Don't declare.
7606         * parse.c (increase_expout_size): Now static.
7607
7608 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7609
7610         * gnu-nat.c (gnu_nat_target::wait): Fix
7611         target_waitstatus_to_string call.
7612
7613 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * eval.c (evaluate_subexp_standard): Handle internal functions
7616         during Fortran function call handling.
7617
7618 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7619
7620         * NEWS: Mention new internal functions.
7621         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7622         (read_base_type): Use dwarf2_init_complex_target_type.
7623         * value.c (creal_internal_fn): New function.
7624         (cimag_internal_fn): New function.
7625         (_initialize_values): Register new internal functions.
7626
7627 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7628
7629         * infrun.c (stop_all_threads): If debug_infrun, always
7630         trace the wait status after wait_one, using
7631         target_waitstatus_to_string and target_pid_to_str.
7632         (handle_inferior_event): Replace various trace of
7633         wait status kind by a single trace.
7634         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7635         wait status kind image by target_waitstatus_to_string.
7636         * target/waitstatus.c (target_waitstatus_to_string): Fix
7637         obsolete comment.
7638
7639 2019-04-01  Tom Tromey  <tromey@adacore.com>
7640
7641         PR symtab/23331:
7642         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7643
7644 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7645             Pedro Alves  <palves@redhat.com>
7646
7647         * top.c (quit_force): Call 'finalize_values'.
7648         * value.c (finalize_values): New function.
7649         * value.h (finalize_values): Declare.
7650
7651 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7652
7653         * NEWS: Announce $_gdb_major and $_gdb_minor.
7654
7655         * top.c (init_gdb_version_vars): New function.
7656         (gdb_init): Call init_gdb_version_vars.
7657
7658 2019-03-29  Tom Tromey  <tromey@adacore.com>
7659
7660         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7661         help text.  Remove dead code.
7662
7663 2019-03-29  Keith Seitz  <keiths@redhat.com>
7664
7665         From Siddhesh Poyarekar:
7666         * f-lang.h (f77_get_upperbound): Return LONGEST.
7667         (f77_get_lowerbound): Likewise.
7668         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7669         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7670         print them.
7671         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7672         plongest to format print it.
7673         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7674         (f77_get_upperbound): Likewise.
7675         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7676         LOWER_BOUND to LONGEST.
7677         (f77_create_arrayprint_offset_tbl): Likewise.
7678
7679 2019-03-29  Keith Seitz  <keiths@redhat.com>
7680
7681         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7682         %s/pulongest for TYPE_LENGTH instead of %d in format
7683         strings.
7684         * ada-typerint.c (ada_print_type): Likewise.
7685         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7686         * compile/compile-c-support.c (generate_register_struct): Likewise.
7687         * gdbtypes.c (recursive_dump_type): Likewise.
7688         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7689         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7690         instead of %d in format strings.
7691         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7692         to std::min to ULONGEST.
7693         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7694         instead of %d in format strings.
7695         * tracepoint.c (info_scope_command): Likewise.
7696         * typeprint.c (print_offset_data::update)
7697         (print_offset_data::finish): Likewise.
7698         * xtensa-tdep.c (xtensa_store_return_value)
7699         (xtensa_push_dummy_call): Likewise.
7700
7701 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7702
7703         * windows-nat.c (display_selector): Fixed format specifications
7704         for 64-bit Cygwin.
7705
7706 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7707
7708         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7709
7710 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7711
7712         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7713         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7714         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7715         (nios2_linux_init_abi): Install it.
7716
7717 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7718
7719         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7720
7721 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7722
7723         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7724
7725 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7726             Tom Tromey  <tromey@adacore.com>
7727
7728         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7729
7730 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7731
7732         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7733         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7734         method to compute the bounds of range types. Also print "[evaluated]"
7735         if the bounds' values come from a dynamic evaluation.
7736
7737 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7738
7739         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7740         whitespace when pretty printing is on.
7741
7742 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7743
7744         * ppc-linux-nat.c: Add include.
7745
7746 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7747
7748         * NEWS: Mention AArch64 Pointer Authentication.
7749
7750 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7751
7752         * arm-linux-nat.c: Add include.
7753
7754 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7755
7756         * source-cache.c (source_cache::get_source_lines): Re-read
7757         fullname after calling open_source_file.
7758
7759 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7760
7761         * NEWS: Mention TLS support for FreeBSD.
7762
7763 2019-03-25  Tom Tromey  <tromey@adacore.com>
7764
7765         * minsyms.c (BUNCH_SIZE): Update comment.
7766         (~minimal_symbol_reader): Remove old comment.
7767         (compact_minimal_symbols): Update comment.
7768         (minimal_symbol_reader::install): Remove old comment.  Update
7769         other comments.
7770
7771 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7772
7773         * s390-linux-nat.c: Add include.
7774
7775 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7776
7777         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7778         Call linux_get_hwcap.
7779         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7780         Likewise.
7781         (aarch64_linux_get_hwcap): Remove function.
7782         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7783         declaration.
7784         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7785         linux_get_hwcap.
7786         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7787         * linux-tdep.c (linux_get_hwcap): Add function.
7788         (linux_get_hwcap2): Likewise.
7789         * linux-tdep.h (linux_get_hwcap): Add declaration.
7790         (linux_get_hwcap2): Likewise.
7791         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7792         (ppc_linux_get_hwcap2): Likewise.
7793         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7794         linux_get_hwcap.
7795         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7796         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7797         (ppc_linux_nat_target::read_description): Likewise.
7798         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7799         * s390-linux-nat.c: Likewise.
7800         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7801
7802 2019-03-24  Tom Tromey  <tom@tromey.com>
7803
7804         * ada-lang.c (standard_lookup): Simplify initialization.
7805         (ada_lookup_symbol_nonlocal): Simplify return.
7806         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7807         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7808         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7809         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7810         initialization.
7811         * solib.c (solib_global_lookup): Simplify.
7812         * symtab.c (null_block_symbol): Remove.
7813         (symbol_cache_lookup): Simplify returns.
7814         (lookup_language_this): Simplify returns.
7815         (lookup_symbol_aux): Simplify return.
7816         (lookup_local_symbol): Simplify returns.
7817         (lookup_global_symbol_from_objfile): Simplify return.
7818         (lookup_symbol_in_objfile_symtabs)
7819         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7820         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7821         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7822         * cp-namespace.c (cp_lookup_bare_symbol)
7823         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7824         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7825         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7826         (cp_lookup_symbol_via_imports): Simplify initialization.
7827         (find_symbol_in_baseclass): Likewise.
7828         * symtab.h (null_block_symbol): Remove.
7829         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7830         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7831         (d_lookup_symbol_module): Likewise.
7832         (find_symbol_in_baseclass): Simplify initialization.
7833
7834 2019-03-24  Tom Tromey  <tom@tromey.com>
7835
7836         * expression.h: Don't include symtab.h.
7837         (struct block): Forward declare.
7838
7839 2019-03-24  Tom Tromey  <tom@tromey.com>
7840
7841         * c-exp.y (typebase): Remove casts.
7842         * gdbtypes.c (lookup_unsigned_typename, )
7843         (lookup_signed_typename): Remove cast.
7844         * eval.c (parse_to_comma_and_eval): Remove cast.
7845         * parse.c (write_dollar_variable): Remove cast.
7846         * block.h (struct block) <superblock>: Now const.
7847         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7848         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7849         (map_block): Make "block" const.
7850         * symfile.h (struct quick_symbol_functions)
7851         <map_matching_symbols>: Constify block argument to "callback".
7852         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7853         const.
7854         (find_pc_sect_compunit_symtab): Make "b" const.
7855         (find_symbol_at_address): Likewise.
7856         (search_symbols): Likewise.
7857         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7858         (dw2_debug_names_lookup_symbol): Likewise.
7859         (dw2_map_matching_symbols): Update.
7860         * p-valprint.c (pascal_val_print): Remove "block".
7861         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7862         (aux_add_nonlocal_symbols): Make "block" const.
7863         (resolve_subexp): Remove cast.
7864         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7865         const.
7866         (iterate_over_file_blocks): Likewise.
7867         * f-exp.y (%union) <bval>: Remove.
7868         * coffread.c (patch_opaque_types): Make "b" const.
7869         * spu-tdep.c (spu_catch_start): Make "block" const.
7870         * c-valprint.c (print_unpacked_pointer): Remove "block".
7871         * symmisc.c (dump_symtab_1): Make "b" const.
7872         (block_depth): Make "block" const.
7873         * d-exp.y (%union) <bval>: Remove.
7874         * cp-support.h (cp_lookup_rtti_type): Update.
7875         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7876         * psymtab.c (psym_lookup_symbol): Make "block" const.
7877         (maintenance_check_psymtabs): Make "b" const.
7878         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7879         (enumerate_locals, enumerate_args): Update.
7880         * python/py-symtab.c (stpy_global_block): Make "block" const.
7881         (stpy_static_block): Likewise.
7882         * inline-frame.c (block_starting_point_at): Make "new_block"
7883         const.
7884         * block.c (find_block_in_blockvector): Make return type const.
7885         (blockvector_for_pc_sect): Make "b" const.
7886         (find_block_in_blockvector): Make "b" const.
7887
7888 2019-03-23  Tom Tromey  <tom@tromey.com>
7889
7890         * varobj.c (varobj_create): Update.
7891         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7892         * printcmd.c (display_command, do_one_display): Don't reset
7893         innermost_block.
7894         * parser-defs.h (enum innermost_block_tracker_type): Move to
7895         expression.h.
7896         (innermost_block): Update comment.
7897         * parse.c (parse_exp_1): Add tracker_types parameter.
7898         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7899         tracker_types parameter.  Reset innermost_block.
7900         (parse_exp_in_context): Remove.
7901         (parse_expression_for_completion): Update.
7902         * objfiles.c (~objfile): Don't reset expression_context_block or
7903         innermost_block.
7904         * expression.h (enum innermost_block_tracker_type): Move from
7905         parser-defs.h.
7906         (parse_exp_1): Add tracker_types parameter.
7907         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7908         reset innermost_block.
7909
7910 2019-03-23  Tom Tromey  <tom@tromey.com>
7911
7912         * objfiles.h: Include bcache.h.
7913
7914 2019-03-23  Tom Tromey  <tom@tromey.com>
7915
7916         * linespec.c (get_current_search_block): Use
7917         scoped_restore_current_language.
7918         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7919
7920 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7921             Jiong Wang  <jiong.wang@arm.com>
7922
7923         * aarch64-linux-tdep.c
7924         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7925         section.
7926         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7927
7928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7929             Jiong Wang  <jiong.wang@arm.com>
7930
7931         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7932         instructions.
7933         (aarch64_analyze_prologue_test): Add PACIASP test.
7934         (aarch64_prologue_prev_register): Unmask PC value.
7935
7936 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7937             Jiong Wang  <jiong.wang@arm.com>
7938
7939         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7940         (aarch64_dwarf2_prev_register): Unmask PC value.
7941         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7942         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7943         DW_CFA_AARCH64_negate_ra_state.
7944         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7945
7946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7947             Jiong Wang  <jiong.wang@arm.com>
7948
7949         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7950         registers.
7951         (aarch64_pseudo_register_name): Likewise.
7952         (aarch64_pseudo_register_type): Likewise.
7953         (aarch64_pseudo_register_reggroup_p): Likewise.
7954         (aarch64_gdbarch_init): Add pauth registers.
7955         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7956         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7957         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7958         (struct gdbarch_tdep): Add regnum for ra_state.
7959
7960 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7961             Jiong Wang  <jiong.wang@arm.com>
7962
7963         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7964
7965 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7966             Jiong Wang  <jiong.wang@arm.com>
7967
7968         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7969         function.
7970         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7971         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7972         (aarch64_gdbarch_init): Add puth registers.
7973         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7974         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7975         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7976
7977 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7978             Jiong Wang  <jiong.wang@arm.com>
7979
7980         * aarch64-linux-nat.c
7981         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7982         * aarch64-linux-tdep.c
7983         (aarch64_linux_core_read_description): Likewise.
7984         (aarch64_linux_get_hwcap): New function.
7985         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7986         (aarch64_linux_get_hwcap): New declaration.
7987
7988 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7989             Jiong Wang  <jiong.wang@arm.com>
7990
7991         * aarch64-linux-nat.c
7992         (aarch64_linux_nat_target::read_description): Add pauth param.
7993         * aarch64-linux-tdep.c
7994         (aarch64_linux_core_read_description): Likewise.
7995         * aarch64-tdep.c (struct target_desc): Add in pauth.
7996         (aarch64_read_description): Add pauth param.
7997         (aarch64_gdbarch_init): Likewise.
7998         * aarch64-tdep.h (aarch64_read_description): Likewise.
7999         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8000         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8001         * features/Makefile: Add new files.
8002         * features/aarch64-pauth.c: New file.
8003         * features/aarch64-pauth.xml: New file.
8004
8005 2019-03-20  Tom Tromey  <tromey@adacore.com>
8006
8007         * infrun.c (handle_inferior_event): Rename from
8008         handle_inferior_event_1.  Create a scoped_value_mark.
8009         (handle_inferior_event): Remove.
8010
8011 2019-03-19  Tom Tromey  <tromey@adacore.com>
8012
8013         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8014         * infrun.h (print_stop_event): Add "displays" parameter.
8015         * infrun.c (print_stop_event): Add "displays" parameter.
8016
8017 2019-03-19  Pedro Alves  <palves@redhat.com>
8018
8019         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8020         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8021         to -1.  Fix TABs vs spaces.
8022         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8023         * tui/tui-out.h (tui_ui_out) Add intro comments.
8024         <m_line, m_start_of_line>: In-class initialize, and add describing
8025         comment.
8026
8027 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8028
8029         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8030         variable names.
8031         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8032
8033 2019-03-18  Pedro Alves  <palves@redhat.com>
8034             Eli Zaretskii <eliz@gnu.org>
8035
8036         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8037         m_line and m_start_of_line.
8038
8039 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8040
8041         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8042         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8043         it returns a newline.  This fixes a regression in TU mode, whereby
8044         the next line is output on the same screen line as the user input.
8045
8046 2019-03-18  Tom Tromey  <tromey@adacore.com>
8047
8048         * minsyms.c (minimal_symbol_reader::install): Remove call to
8049         obstack_blank.
8050
8051 2019-03-18  Pedro Alves  <palves@redhat.com>
8052
8053         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8054         New globals.
8055         (apply_style): New, factored out from ...
8056         (apply_ansi_escape): ... this.  Handle reverse video mode.
8057         (tui_set_reverse_mode): New function.
8058         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8059         * tui/tui-winsource.c (tui_show_source_line): Use
8060         tui_set_reverse_mode instead of setting A_STANDOUT.
8061         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8062         New setter methods.
8063
8064 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8065
8066         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8067         Handle tabs.
8068
8069 2019-03-18  Tom Tromey  <tromey@adacore.com>
8070
8071         * ada-lang.c (empty_array): Add "high" parameter.
8072         (ada_evaluate_subexp): Update.
8073
8074 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8075
8076         * unittests/string_view-selftests.c: Define
8077         _initialize_string_view_selftests unconditionally.
8078
8079 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8080
8081         PR gdb/24350
8082         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8083
8084 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8085
8086         PR gdb/24351
8087         * windows-nat.c (display_selector): Fix format specifiers.
8088
8089 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8090
8091         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8092         tui_refill_source_window instead of tui_refresh_win, to update the
8093         current execution line.  This fixes redisplay of the current line
8094         when stepping through the code with "next" or "step".
8095
8096 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8097
8098         * source-cache.c (source_cache::get_source_lines): Call
8099         find_source_lines to initialize s->nlines.  This fixes vertical
8100         scrolling of TUI source window when the DOWN arrow is pressed.
8101
8102 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8103
8104         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8105         linux-thread-db.c (_initialize_thread_db): Likewise.
8106
8107 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8108
8109         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8110         wclrtoeol in tui_show_source_line".  This reverts changes made in
8111         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8112
8113 2019-03-15  Tom Tromey  <tom@tromey.com>
8114
8115         * symtab.h (struct minimal_symbol): Derive from
8116         general_symbol_info.
8117         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8118         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8119         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8120         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8121         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8122         (MSYMBOL_SEARCH_NAME): Update.
8123         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8124         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8125         * minsyms.c (minimal_symbol_reader::record_full): Update.
8126
8127 2019-03-15  Tom Tromey  <tom@tromey.com>
8128
8129         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8130
8131 2019-03-15  Tom Tromey  <tom@tromey.com>
8132
8133         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8134         unique_xmalloc_ptr.
8135         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8136         Update.
8137         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8138         (build_minimal_symbol_hash_tables)
8139         (minimal_symbol_reader::install): Update.
8140
8141 2019-03-15  Tom Tromey  <tom@tromey.com>
8142
8143         * symtab.c (create_demangled_names_hash): Update.
8144         (symbol_set_names): Update.
8145         * objfiles.h (struct objfile_per_bfd_storage)
8146         <demangled_names_hash>: Now an htab_up.
8147         * objfiles.c (objfile_per_bfd_storage): Simplify.
8148
8149 2019-03-15  Tom Tromey  <tom@tromey.com>
8150
8151         * objfiles.h (struct objfile_per_bfd_storage): Declare
8152         destructor.
8153         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8154         New.
8155         (get_objfile_bfd_data): Use new.  Don't initialize
8156         language_of_main.
8157         (free_objfile_per_bfd_storage): Remove.
8158         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8159
8160 2019-03-15  Tom Tromey  <tom@tromey.com>
8161
8162         * symfile.c (reread_symbols): Update.
8163         * objfiles.c (objfile::objfile): Update.
8164         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8165         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8166         comment.
8167         (minimal_symbol_reader::install): Update.
8168         (terminate_minimal_symbol_table): Remove.
8169         * jit.c (jit_object_close_impl): Update.
8170
8171 2019-03-15  Tom Tromey  <tom@tromey.com>
8172
8173         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8174         initializations.
8175
8176 2019-03-15  Tom Tromey  <tom@tromey.com>
8177
8178         * objfiles.h (struct objfile_per_bfd_storage)
8179         <demangled_hash_languages>: Now a bitset.
8180         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8181         (lookup_minimal_symbol): Update.
8182
8183 2019-03-15  Tom Tromey  <tom@tromey.com>
8184
8185         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8186         Don't return the symbol.
8187         * coffread.c (record_minimal_symbol): Use record_full.
8188
8189 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8190
8191         The MS-Windows port of ncurses fails to switch to a color pair if
8192         one or both of the colors are the implicit default colors.  This
8193         change records the default colors when TUI is initialized, and
8194         then specifies them explicitly when a color pair uses the default
8195         colors.  This allows color styling in TUI mode on MS-Windows.
8196
8197         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8198         ncurses_norm_attr.
8199         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8200         colors in ncurses_norm_attr.
8201         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8202         "none", replace it with the default color recorded in
8203         ncurses_norm_attr.
8204
8205 2019-03-14  Tom Tromey  <tromey@adacore.com>
8206
8207         * source-cache.h (class source_cache) <get_source_lines>: Return
8208         std::string.
8209         * source-cache.c (source_cache::extract_lines): Handle case where
8210         first_pos==npos.  Return std::string.
8211         (source_cache::get_source_lines): Update.
8212
8213 2019-03-14  Tom Tromey  <tromey@adacore.com>
8214
8215         * NEWS: Add item for "style sources" commands.
8216         * source-cache.c (source_cache::get_source_lines): Check
8217         source_styling.
8218         * cli/cli-style.c (source_styling): New global.
8219         (_initialize_cli_style): Add "style sources" commands.
8220         (show_style_sources): New function.
8221         * cli/cli-style.h (source_styling): Declare.
8222
8223 2019-03-14  Pedro Alves  <palves@redhat.com>
8224             Tom Tromey  <tromey@adacore.com>
8225
8226         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8227         * tui/tui-winsource.c (tui_refill_source_window): New function,
8228         from...
8229         (tui_horizontal_source_scroll): ... here.  Move some logic.
8230         * cli/cli-style.c (set_style_enabled): Notify new observable.
8231         * tui/tui-hooks.c (tui_redisplay_source): New function.
8232         (tui_attach_detach_observers): Attach or detach
8233         tui_redisplay_source.
8234         * observable.h (source_styling_changed): New observable.
8235         * observable.c: Define source_styling_changed observable.
8236
8237 2019-03-13  Tom Tromey  <tromey@adacore.com>
8238
8239         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8240         (i386_gnu_nat_target::store_registers): Update.
8241         * target-debug.h (target_debug_print_std_string): New macro.
8242         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8243         * windows-tdep.c (display_one_tib): Update.
8244         * tui/tui-stack.c (tui_make_status_line): Update.
8245         * top.c (print_inferior_quit_action): Update.
8246         * thread.c (thr_try_catch_cmd): Update.
8247         (add_thread_with_info): Update.
8248         (thread_target_id_str): Update.
8249         (thr_try_catch_cmd): Update.
8250         (thread_command): Update.
8251         (thread_find_command): Update.
8252         * record-btrace.c (record_btrace_target::info_record)
8253         (record_btrace_resume_thread, record_btrace_target::resume)
8254         (record_btrace_cancel_resume, record_btrace_step_thread)
8255         (record_btrace_target::wait, record_btrace_target::wait)
8256         (record_btrace_target::wait, record_btrace_target::stop): Update.
8257         * progspace.c (print_program_space): Update.
8258         * process-stratum-target.c
8259         (process_stratum_target::thread_address_space): Update.
8260         * linux-fork.c (linux_fork_mourn_inferior)
8261         (detach_checkpoint_command, info_checkpoints_command)
8262         (linux_fork_context): Update.
8263         (linux_fork_detach): Update.
8264         (class scoped_switch_fork_info): Update.
8265         (delete_checkpoint_command): Update.
8266         * infrun.c (follow_fork_inferior): Update.
8267         (follow_fork_inferior): Update.
8268         (proceed_after_vfork_done): Update.
8269         (handle_vfork_child_exec_or_exit): Update.
8270         (follow_exec): Update.
8271         (displaced_step_prepare_throw): Update.
8272         (displaced_step_restore): Update.
8273         (start_step_over): Update.
8274         (resume_1): Update.
8275         (clear_proceed_status_thread): Update.
8276         (proceed): Update.
8277         (print_target_wait_results): Update.
8278         (do_target_wait): Update.
8279         (context_switch): Update.
8280         (stop_all_threads): Update.
8281         (restart_threads): Update.
8282         (finish_step_over): Update.
8283         (handle_signal_stop): Update.
8284         (switch_back_to_stepped_thread): Update.
8285         (keep_going_pass_signal): Update.
8286         (print_exited_reason): Update.
8287         (normal_stop): Update.
8288         * inferior.c (inferior_pid_to_str): Change return type.
8289         (print_selected_inferior): Update.
8290         (add_inferior): Update.
8291         (detach_inferior): Update.
8292         * dummy-frame.c (fprint_dummy_frames): Update.
8293         * dcache.c (dcache_info_1): Update.
8294         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8295         (btrace_fetch, btrace_clear): Update.
8296         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8297         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8298         type.
8299         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8300         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8301         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8302         * gdbarch.c, gdbarch.h: Rebuild.
8303         * gdbarch.sh (core_pid_to_str): Change return type.
8304         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8305         return type.
8306         (windows_nat_target::pid_to_str): Change return type.
8307         (windows_delete_thread): Update.
8308         (windows_nat_target::attach): Update.
8309         (windows_nat_target::files_info): Update.
8310         * target-delegates.c: Rebuild.
8311         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8312         return type.
8313         (sol_thread_target::pid_to_str): Change return type.
8314         * remote.c (class remote_target) <pid_to_str>: Change return
8315         type.
8316         (remote_target::pid_to_str): Change return type.
8317         (extended_remote_target::attach, remote_target::remote_stop_ns)
8318         (remote_target::remote_notif_remove_queued_reply)
8319         (remote_target::push_stop_reply, remote_target::disable_btrace):
8320         Update.
8321         (extended_remote_target::attach): Update.
8322         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8323         type.
8324         (gdbsim_target::pid_to_str): Change return type.
8325         * ravenscar-thread.c (struct ravenscar_thread_target)
8326         <pid_to_str>: Change return type.
8327         (ravenscar_thread_target::pid_to_str): Change return type.
8328         * procfs.c (class procfs_target) <pid_to_str>: Change return
8329         type.
8330         (procfs_target::pid_to_str): Change return type.
8331         (procfs_target::attach): Update.
8332         (procfs_target::detach): Update.
8333         (procfs_target::fetch_registers): Update.
8334         (procfs_target::store_registers): Update.
8335         (procfs_target::wait): Update.
8336         (procfs_target::files_info): Update.
8337         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8338         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8339         return type.
8340         (nto_procfs_target::pid_to_str): Change return type.
8341         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8342         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8343         return type.
8344         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8345         (exit_lwp): Update.
8346         (attach_proc_task_lwp_callback, get_detach_signal)
8347         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8348         (linux_nat_target::resume, wait_lwp, stop_callback)
8349         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8350         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8351         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8352         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8353         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8354         type.
8355         (inf_ptrace_target::attach): Update.
8356         (inf_ptrace_target::files_info): Update.
8357         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8358         type.
8359         (go32_nat_target::pid_to_str): Change return type.
8360         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8361         (gnu_nat_target::wait): Update.
8362         (gnu_nat_target::wait): Update.
8363         (gnu_nat_target::resume): Update.
8364         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8365         (fbsd_nat_target::wait): Update.
8366         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8367         type.
8368         (darwin_nat_target::attach): Update.
8369         * corelow.c (class core_target) <pid_to_str>: Change return type.
8370         (core_target::pid_to_str): Change return type.
8371         * target.c (normal_pid_to_str): Change return type.
8372         (default_pid_to_str): Likewise.
8373         (target_pid_to_str): Change return type.
8374         (target_translate_tls_address): Update.
8375         (target_announce_detach): Update.
8376         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8377         return type.
8378         (bsd_uthread_target::pid_to_str): Change return type.
8379         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8380         type.
8381         (bsd_kvm_target::pid_to_str): Change return type.
8382         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8383         return type.
8384         (aix_thread_target::pid_to_str): Change return type.
8385         * target.h (struct target_ops) <pid_to_str>: Change return type.
8386         (target_pid_to_str, normal_pid_to_str): Likewise.
8387         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8388         type.
8389         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8390         type.
8391         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8392         return type.
8393         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8394         type.
8395         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8396         type.
8397         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8398         return type.
8399
8400 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8401
8402         * NEWS: Mention that the new default MI version is 3.  Mention
8403         changes to the output of commands and events that deal with
8404         multi-location breakpoints.
8405         * breakpoint.c: Include "mi/mi-out.h".
8406         (print_one_breakpoint): Change output syntax if using MI version
8407         >= 3.
8408         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8409         New.
8410         (mi_multi_location_breakpoint_output_fixed): New.
8411         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8412         (mi_cmd_fix_multi_location_breakpoint_output): New.
8413         (mi_multi_location_breakpoint_output_fixed): New.
8414         * mi/mi-cmds.c (mi_cmds): Register command
8415         -fix-multi-location-breakpoint-output.
8416         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8417         interpreter "mi".
8418
8419 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8420
8421         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8422         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8423         instantiate mi_ui_out based on interpreter name.
8424         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8425         * mi/mi-main.c (mi_load_progress): Likewise.
8426
8427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8428
8429         * NEWS: Combine separate "New targets" sections for 8.3.
8430
8431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8432
8433         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8434         (ppcfbsd_init_abi): Install gdbarch
8435         "fetch_tls_load_module_address" and "get_thread_local_address"
8436         methods.
8437
8438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8439
8440         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8441         (riscv_fbsd_init_abi): Install gdbarch
8442         "fetch_tls_load_module_address" and "get_thread_local_address"
8443         methods.
8444
8445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8446
8447         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8448         (i386fbsd_init_abi): Install gdbarch
8449         "fetch_tls_load_module_address" and "get_thread_local_address"
8450         methods.
8451
8452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8453
8454         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8455         (amd64fbsd_init_abi): Install gdbarch
8456         "fetch_tls_load_module_address" and "get_thread_local_address"
8457         methods.
8458
8459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8460
8461         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8462         (struct fbsd_pspace_data): New type.
8463         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8464         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8465         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8466         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8467         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8468
8469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8470
8471         * gdbtypes.c (lookup_struct_elt): New function.
8472         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8473         * gdbtypes.h (struct struct_elt): New type.
8474         (lookup_struct_elt): New prototype.
8475
8476 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8477
8478         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8479         remove disabled code block.
8480
8481 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8482
8483         * gdbarch.sh (get_thread_local_address): New method.
8484         * gdbarch.h, gdbarch.c: Regenerate.
8485         * target.c (target_translate_tls_address): Use
8486         gdbarch_get_thread_local_address if present instead of
8487         target::get_thread_local_address.
8488
8489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8490
8491         * target.h (target::get_thread_local_address): Update comment.
8492
8493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8494
8495         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8496         objfile->separate_debug_objfile_backlink if not NULL.
8497
8498 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8499
8500         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8501         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8502         (amd64bsd_store_inferior_registers): Likewise.
8503         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8504         Enable segment base registers.
8505         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8506         PT_GETFSBASE and PT_GETGSBASE.
8507         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8508         PT_SETGSBASE.
8509         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8510         segment base registers.
8511         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8512
8513 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8514
8515         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8516         Update calls to i386_target_description to add 'segments'
8517         parameter.
8518         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8519         add segment base registers.
8520         * arch/i386.c (i386_create_target_description): Add 'segments'
8521         parameter to enable segment base registers.
8522         * arch/i386.h (i386_create_target_description): Likewise.
8523         * features/i386/32bit-segments.xml: New file.
8524         * features/i386/32bit-segments.c: Generate.
8525         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8526         call to i386_target_description to add 'segments' parameter.
8527         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8528         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8529         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8530         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8531         if feature is present.
8532         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8533         Add 'segments' parameter to call to i386_target_description.
8534         (i386_target_description): Add 'segments' parameter to enable
8535         segment base registers.
8536         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8537         to call to i386_target_description.
8538         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8539         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8540         Define I386_NUM_REGS.
8541         (i386_target_description): Add 'segments' parameter to enable
8542         segment base registers.
8543
8544 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8545
8546         PR/24325
8547         * source-cache.c: #undef open and close, to avoid unresolved
8548         externals during linking.
8549
8550 2019-03-12  Tom Tromey  <tromey@adacore.com>
8551
8552         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8553         const.  Add initializers.
8554         (_initialize_remote): Don't initialize ptid globals.
8555
8556 2019-03-12  Pedro Alves  <palves@redhat.com>
8557
8558         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8559
8560 2019-03-12  Pedro Alves  <palves@redhat.com>
8561
8562         * cp-name-parser.y (main): Remove unused 'len' variable.
8563
8564 2019-03-12  Tom Tromey  <tromey@adacore.com>
8565
8566         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8567         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8568
8569 2019-03-12  Tom Tromey  <tromey@adacore.com>
8570
8571         * linux-nat.c (iterate_over_lwps): Update.
8572         (stop_callback): Remove parameter.
8573         (stop_wait_callback, detach_callback, resume_set_callback)
8574         (select_singlestep_lwp_callback, set_ignore_sigint)
8575         (status_callback, resumed_callback, resume_clear_callback)
8576         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8577         data parameter.
8578         (linux_nat_target::detach, linux_nat_target::resume)
8579         (linux_stop_and_wait_all_lwps, select_event_lwp)
8580         (linux_nat_filter_event, linux_nat_wait_1)
8581         (linux_nat_target::kill, linux_nat_target::stop)
8582         (linux_nat_target::stop): Update.
8583         (linux_nat_resume_callback): Change type.
8584         (resume_stopped_resumed_lwps, count_events_callback)
8585         (select_event_lwp_callback): Likewise.
8586         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8587         * arm-linux-nat.c (struct update_registers_data): Remove.
8588         (update_registers_callback): Change type.
8589         (arm_linux_insert_hw_breakpoint1): Update.
8590         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8591         parameter.
8592         (x86_linux_dr_set_addr): Update.
8593         (x86_linux_dr_set_control): Update.
8594         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8595         (iterate_over_lwps): Use gdb::function_view.
8596         * nat/aarch64-linux-hw-point.c (struct
8597         aarch64_dr_update_callback_param): Remove.
8598         (debug_reg_change_callback): Change type.
8599         (aarch64_notify_debug_reg_change): Update.
8600         * s390-linux-nat.c (s390_refresh_per_info): Update.
8601
8602 2019-03-11  Tom Tromey  <tromey@adacore.com>
8603
8604         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8605         redundant assignment to "this_cu".
8606
8607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8608
8609         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8610
8611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8612
8613         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8614         from...
8615         (rank_one_type): ... this.
8616
8617 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8618
8619         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8620         from...
8621         (rank_one_type): ... this.
8622
8623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8624
8625         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8626         from...
8627         (rank_one_type): ... this.
8628
8629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8630
8631         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8632         from...
8633         (rank_one_type): ... this.
8634
8635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8636
8637         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8638         from...
8639         (rank_one_type): ... this.
8640
8641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8642
8643         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8644         from...
8645         (rank_one_type): ... this.
8646
8647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8648
8649         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8650         from...
8651         (rank_one_type): ... this.
8652
8653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8654
8655         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8656         from...
8657         (rank_one_type): ... this.
8658
8659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8660
8661         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8662         from...
8663         (rank_one_type): ... this.
8664
8665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8666
8667         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8668         from...
8669         (rank_one_type): ... this.
8670
8671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8672
8673         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8674         from...
8675         (rank_one_type): ... this.
8676
8677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8678
8679         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8680         from...
8681         (rank_one_type): ... this.
8682
8683 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8684
8685         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8686         inferior-events' shows the example events.
8687
8688 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8689
8690         Support styling on native MS-Windows console
8691
8692         PR/24315
8693         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8694         on MS-Windows if $TERM is not defined.
8695
8696         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8697
8698         * posix-hdep.c (gdb_console_fputs):
8699         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8700         functions.
8701         * ui-file.h (gdb_console_fputs): Add prototype.
8702
8703         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8704         back to fputs only if the former returns zero.
8705
8706 2019-03-07  Tom Tromey  <tom@tromey.com>
8707
8708         * symmisc.c (print_symbol_bcache_statistics): Update.
8709         (print_objfile_statistics): Update.
8710         * symfile.c (allocate_symtab): Update.
8711         * stabsread.c: Don't include bcache.h.
8712         * psymtab.h (struct psymbol_bcache): Don't declare.
8713         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8714         (psymbol_bcache_init, psymbol_bcache_free)
8715         (psymbol_bcache_get_bcache): Don't declare.
8716         * psymtab.c (struct psymbol_bcache): Remove.
8717         (psymtab_storage::psymtab_storage): Update.
8718         (psymtab_storage::~psymtab_storage): Update.
8719         (psymbol_bcache_init, psymbol_bcache_free)
8720         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8721         (add_psymbol_to_bcache): Update.
8722         (allocate_psymtab): Update.
8723         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8724         macro_cache>: No longer pointers.
8725         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8726         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8727         * macrotab.c (macro_bcache): Update.
8728         * macroexp.c: Don't include bcache.h.
8729         * gdbtypes.c (check_types_worklist): Update.
8730         (types_deeply_equal): Remove TRY/CATCH.  Update.
8731         * elfread.c (elf_symtab_read): Update.
8732         * dwarf2read.c: Don't include bcache.h.
8733         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8734         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8735         (print_bcache_statistics, bcache_memory_used): Don't declare.
8736         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8737         methods.  Rename all data members.
8738         * bcache.c (struct bcache): Move to bcache.h.
8739         (bcache::expand_hash_table): Rename from expand_hash_table.
8740         (bcache): Remove.
8741         (bcache::insert): Rename from bcache_full.
8742         (bcache::compare): Rename from bcache_compare.
8743         (bcache_xmalloc): Remove.
8744         (bcache::~bcache): Rename from bcache_xfree.
8745         (bcache::print_statistics): Rename from print_bcache_statistics.
8746         (bcache::memory_used): Rename from bcache_memory_used.
8747
8748 2019-03-07  Pedro Alves  <palves@redhat.com>
8749
8750         * infrun.c (normal_stop): Also check for
8751         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8752
8753 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * f-lang.c (value_from_host_double): Moved to...
8756         * value.c (value_from_host_double): ...here.
8757         * value.h (value_from_host_double): Declare.
8758         * guile/scm-math.c (vlscm_convert_typed_number): Use
8759         value_from_host_double.
8760         (vlscm_convert_number): Likewise.
8761         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8762         * python/py-value.c (convert_value_from_python): Likewise.
8763
8764 2019-03-06  Tom Tromey  <tom@tromey.com>
8765
8766         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8767
8768 2019-03-06  Tom Tromey  <tom@tromey.com>
8769
8770         * utils.h (free_current_contents): Don't declare.
8771         * utils.c (free_current_contents): Remove.
8772
8773 2019-03-06  Tom Tromey  <tom@tromey.com>
8774
8775         * top.c (quit_force): Update.
8776         * main.c (captured_command_loop): Update.
8777         * common/new-op.c (operator new): Update.
8778         * common/common-exceptions.c (struct catcher)
8779         <save_cleanup_chain>: Remove member.
8780         (exceptions_state_mc_init): Update.
8781         (exception_try_scope_entry): Return nullptr.
8782         (exception_try_scope_exit, exception_rethrow)
8783         (throw_exception_sjlj, throw_exception_cxx): Update.
8784         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8785         (all_cleanups, do_cleanups, discard_cleanups)
8786         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8787         (restore_cleanups, restore_final_cleanups): Don't declare.
8788         (do_final_cleanups): Remove parameter.
8789         * common/cleanups.c (cleanup_chain, make_cleanup)
8790         (make_cleanup_dtor, all_cleanups, do_cleanups)
8791         (discard_my_cleanups, discard_cleanups)
8792         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8793         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8794         (null_cleanup): Remove.
8795         (do_final_cleanups): Remove parameter.
8796
8797 2019-03-06  Tom Tromey  <tom@tromey.com>
8798
8799         * remote.c (remote_target::remote_parse_stop_reply): Use
8800         unique_xmalloc_ptr.
8801
8802 2019-03-06  Tom Tromey  <tom@tromey.com>
8803
8804         * stabsread.c (struct stabs_field_info): Rename from field_info.
8805         <list, fnlist>: Add initializers.
8806         <obstack>: New member.
8807         (read_member_functions, read_struct_fields, read_baseclasses):
8808         Allocate on obstack.  Don't use cleanups.
8809         (read_one_struct_field, read_member_functions, read_struct_fields)
8810         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8811         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8812         (read_struct_type): Update.
8813
8814 2019-03-06  Tom Tromey  <tom@tromey.com>
8815
8816         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8817         * common/filestuff.h (make_cleanup_close): Don't declare.
8818         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8819         Remove.
8820
8821 2019-03-06  Tom Tromey  <tom@tromey.com>
8822
8823         * solib-aix.c: Use make_scope_exit.
8824
8825 2019-03-06  Tom Tromey  <tom@tromey.com>
8826
8827         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8828         Use make_scope_exit.
8829
8830 2019-03-06  Tom Tromey  <tom@tromey.com>
8831
8832         * solib-svr4.c (disable_probes_interface): Remove parameter.
8833         (svr4_handle_solib_event): Use make_scope_exit.
8834
8835 2019-03-06  Tom Tromey  <tom@tromey.com>
8836
8837         * remote.c (struct stop_reply_deleter): Remove.
8838         (stop_reply_up): Update.
8839         (struct stop_reply): Derive from notif_event.  Don't typedef.
8840         <regcache>: Now a std::vector.
8841         (stop_reply_xfree): Remove.
8842         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8843         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8844         (remote_target::discard_pending_stop_replies): Use delete.
8845         (remote_target::remote_parse_stop_reply): Update.
8846         (remote_target::process_stop_reply): Update.
8847         * remote-notif.h (struct notif_event): Add virtual destructor.
8848         Remove "dtr" member.
8849         (struct notif_client) <alloc_event>: Return a unique_ptr.
8850         (notif_event_xfree): Don't declare.
8851         (notif_event_up): New typedef.
8852         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8853         (notif_event_xfree, do_notif_event_xfree): Remove.
8854         (remote_notif_state_xfree): Update.
8855
8856 2019-03-06  Tom Tromey  <tom@tromey.com>
8857
8858         * infrun.c (displaced_step_clear_cleanup): Now a
8859         forward_scope_exit type.
8860         (displaced_step_prepare_throw): Update.
8861         (displaced_step_fixup): Update.
8862
8863 2019-03-06  Tom Tromey  <tom@tromey.com>
8864
8865         * inferior.h (class inferior): Update comment.
8866         * gdbthread.h (class thread_info): Update comment.
8867
8868 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8869             Tom Tromey  <tom@tromey.com>
8870
8871         * stabsread.h (struct stab_section_list): Remove.
8872         (coffstab_build_psymtabs): Update.
8873         * dbxread.c (symbuf_sections): Now a std::vector.
8874         (sect_idx): New global.
8875         (fill_symbuf): Update.
8876         (coffstab_build_psymtabs): Change type of stabsects parameter.
8877         Update.
8878         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8879         std::vector.
8880         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8881         (coff_locate_sections): Update.
8882         (coff_symfile_read): Remove cleanups.  Update.
8883         (init_stringtab): Add storage parameter.
8884         (free_stringtab, free_stringtab_cleanup): Remove.
8885         (init_lineno): Add storage parameter.
8886         (free_linetab, free_linetab_cleanup): Remove.
8887
8888 2019-03-06  Pedro Alves  <palves@redhat.com>
8889
8890         * linux-fork.c (fork_info::clobber_regs): Delete.
8891         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8892         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8893         comment.  Adjust.
8894         (scoped_switch_fork_info::scoped_switch_fork_info)
8895         (checkpoint_command, linux_fork_context): Adjust
8896         fork_save_infrun_state calls.
8897
8898 2019-03-06  Pedro Alves  <palves@redhat.com>
8899
8900         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8901         (inf_has_multiple_threads): Return 'bool' and rewrite using
8902         inferior_info::threads().
8903
8904 2019-03-06  Pedro Alves  <palves@redhat.com>
8905
8906         * linux-fork.c: Include <list>.
8907         (fork_list): Now a std::list instance.
8908         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8909         (forks_exist_p, find_last_fork): Adjust.
8910         (new_fork): Delete.
8911         (one_fork_p): New.
8912         (add_fork): Adjust.
8913         (free_fork): Delete, folded into fork_info::~fork_info().
8914         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8915         Adjust.
8916         (init_fork_list): Delete.
8917         (linux_fork_killall, linux_fork_mourn_inferior)
8918         (linux_fork_detach, info_checkpoints_command): Adjust.
8919         (_initialize_linux_fork): No longer call init_fork_list.
8920
8921 2019-03-06  Pedro Alves  <palves@redhat.com>
8922
8923         * linux-fork.c (new_fork): New, split out of ...
8924         (add_fork): ... this.  Return void.  Move "first fork" special
8925         case from here, to ...
8926         (checkpoint_command): ... here.
8927         * linux-linux.h (add_fork): Return void.
8928
8929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8932
8933 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8934             Chris January  <chris.january@arm.com>
8935             David Lecomber  <david.lecomber@arm.com>
8936
8937         * f-exp.y: New token, UNOP_INTRINSIC.
8938         (exp): New pattern using UNOP_INTRINSIC token.
8939         (f77_keywords): Add 'abs' keyword.
8940         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8941         (value_from_host_double): New function.
8942         (evaluate_subexp_f): Support UNOP_ABS.
8943
8944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8947         types.
8948
8949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8952         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8953         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8954
8955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8956
8957         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8958
8959 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8960             Chris January  <chris.january@arm.com>
8961
8962         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8963         * f-exp.y: Define 'KIND' token.
8964         (exp): New pattern for KIND expressions.
8965         (ptype): Handle types with a kind extension.
8966         (direct_abs_decl): Extend to spot kind extensions.
8967         (f77_keywords): Add 'kind' to the list.
8968         (push_kind_type): New function.
8969         (convert_to_kind_type): New function.
8970         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8971         * parse.c (operator_length_standard): Likewise.
8972         * parser-defs.h (enum type_pieces): Add tp_kind.
8973         * std-operator.def: Add UNOP_KIND.
8974
8975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * f-exp.y (f_parse): Set yydebug.
8978
8979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8980
8981         * f-lang.c (evaluate_subexp_f): New function.
8982         (exp_descriptor_f): New global.
8983         (f_language_defn): Use exp_descriptor_f instead of
8984         exp_descriptor_standard.
8985
8986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8987
8988         * f-exp.y (struct token): Add comments.
8989         (dot_ops): Remove uppercase versions and the end marker.
8990         (f77_keywords): Likewise.
8991         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8992         entries in the dot_ops array are case insensitive, and use
8993         strncasecmp to compare strings.  Also some whitespace cleanup in
8994         this area.  Similar for the f77_keywords array, except entries in
8995         this list might be case sensitive.
8996
8997 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * f-exp.y (struct f77_boolean_val): Add comments.
9000         (boolean_values): Remove uppercase versions, and end marker.
9001         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9002         and use strncasecmp to achieve case insensitivity.  Additionally,
9003         perform whitespace cleanup around this code.
9004
9005 2019-03-06  Tom Tromey  <tromey@adacore.com>
9006
9007         * remote-sim.c (gdbsim_target_open): Use result of
9008         gdb_argv::release.
9009
9010 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9011         Dirk Schubert  <dirk.schubert@arm.com>
9012         Chris January  <chris.january@arm.com>
9013
9014         * eval.c (evaluate_subexp_standard): Call Fortran argument
9015         wrapping logic.
9016         * f-lang.c (struct value): A value which can be passed into a
9017         Fortran function call.
9018         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9019         where appropriate.
9020         (struct type): Value ready for a Fortran function call.
9021         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9022         is needed.
9023         * f-lang.h (fortran_argument_convert): Declaration.
9024         (fortran_preserve_arg_pointer): Declaration.
9025         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9026
9027 2019-03-05  Tom Tromey  <tromey@adacore.com>
9028
9029         * python/py-prettyprint.c (print_string_repr): Remove #if.
9030         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9031
9032 2019-03-05  Tom Tromey  <tromey@adacore.com>
9033
9034         * target.c (the_dummy_target): Move later.  Change type to
9035         "dummy_target".
9036         (initialize_targets): Don't initialize the_dummy_target.
9037
9038 2019-03-05  Tom Tromey  <tromey@adacore.com>
9039
9040         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9041         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9042
9043 2019-03-05  Tom Tromey  <tromey@adacore.com>
9044
9045         * windows-nat.c (windows_nat_target::attach)
9046         (windows_nat_target::detach): Don't call gdb_flush.
9047         * valprint.c (generic_val_print, val_print, val_print_string):
9048         Don't call gdb_flush.
9049         * utils.c (defaulted_query): Don't call gdb_flush.
9050         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9051         * target.c (target_announce_detach): Don't call gdb_flush.
9052         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9053         * remote.c (extended_remote_target::attach): Don't call
9054         gdb_flush.
9055         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9056         * printcmd.c (do_examine): Don't call gdb_flush.
9057         (info_display_command): Don't call gdb_flush.
9058         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9059         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9060         * memattr.c (info_mem_command): Don't call gdb_flush.
9061         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9062         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9063         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9064         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9065         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9066         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9067         (gnu_nat_target::detach): Don't call gdb_flush.
9068         * f-valprint.c (f_val_print): Don't call gdb_flush.
9069         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9070         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9071         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9072         gdb_flush.
9073         * c-valprint.c (c_val_print): Don't call gdb_flush.
9074         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9075
9076 2019-03-05  Tom Tromey  <tromey@adacore.com>
9077
9078         * varobj.c (update_dynamic_varobj_children): Update.
9079         (install_default_visualizer): Use reset, not release.
9080         * value.c (set_internalvar): Update.
9081         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9082         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9083         ATTRIBUTE_UNUSED_RESULT.
9084
9085 2019-03-05  Tom Tromey  <tromey@adacore.com>
9086
9087         * remote.c (class scoped_remote_fd) <release>: Add
9088         ATTRIBUTE_UNUSED_RESULT.
9089
9090 2019-03-05  Tom Tromey  <tromey@adacore.com>
9091
9092         * macroexp.c (struct macro_buffer) <release>: Add
9093         ATTRIBUTE_UNUSED_RESULT.
9094
9095 2019-03-05  Tom Tromey  <tromey@adacore.com>
9096
9097         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9098         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9099         ATTRIBUTE_UNUSED_RESULT.
9100
9101 2019-03-05  Tom Tromey  <tromey@adacore.com>
9102
9103         * common/scoped_fd.h (class scoped_fd) <release>: Add
9104         ATTRIBUTE_UNUSED_RESULT.
9105
9106 2019-03-05  Tom Tromey  <tromey@adacore.com>
9107
9108         * parser-defs.h (struct parser_state) <release>: Add
9109         ATTRIBUTE_UNUSED_RESULT.
9110
9111 2019-03-05  Tom Tromey  <tromey@adacore.com>
9112
9113         * utils.h (class gdb_argv) <release>: Add
9114         ATTRIBUTE_UNUSED_RESULT.
9115         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9116
9117 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9118
9119         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9120         for-loop range, to avoid compiler warnings.
9121
9122         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9123         avoid compiler warnings about unused variables.
9124
9125         * NEWS: Mention end of support for native debugging on MS-Windows
9126         before XP.
9127
9128         PR gdb/24292
9129         * common/netstuff.c:
9130         * gdbserver/gdbreplay.c
9131         * gdbserver/remote-utils.c:
9132         * ser-tcp.c:
9133         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9134         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9135         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9136         'getaddrinfo' and 'freeaddrinfo' were not available before
9137         Windows XP, and mingw.org's MinGW headers by default define
9138         _WIN32_WINNT to 0x500.
9139
9140 2019-03-01  Gary Benson <gbenson@redhat.com>
9141
9142         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9143
9144 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9145             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9146
9147         PR gdb/8527
9148         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9149         set_sigint_trap, clear_sigint_trap.
9150
9151 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9152
9153         * target.c (target_detach): Clear the regcache and the
9154         frame cache.
9155
9156 2019-02-27  Pedro Alves  <palves@redhat.com>
9157
9158         * utils.c (set_screen_size): When we cap the height/width sizes,
9159         tweak the corresponding command variable to show "unlimited":
9160
9161 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9162             Pedro Alves  <palves@redhat.com>
9163
9164         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9165         before calling rl_set_screen_size.
9166
9167 2019-02-27  Tom Tromey  <tromey@adacore.com>
9168
9169         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9170         define.
9171         * python/py-value.c: Remove Python 2.4 workaround.
9172         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9173         workaround.
9174         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9175         Python 2.4 workaround.
9176         * python/python-internal.h: Remove Python 2.4 comment.
9177         (Py_ssize_t): Don't define.
9178         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9179         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9180         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9181         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9182         * python/python.c (do_start_initialization): Remove Python 2.4
9183         workaround.
9184         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9185         (print_children): Remove Python 2.4 workaround.
9186         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9187         workaround.
9188         (CHARBUFFERPROC_NAME): Remove.
9189         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9190         Python 2.4 workaround.
9191
9192 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9193
9194         * NEWS: Note minimum Python version.
9195
9196 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9197
9198         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9199         code from these functions.  Remove corresponding ifdefs.  Use
9200         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9201         Remove gotos and target of gotos.
9202         (infpy_search_memory): Likewise.
9203
9204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9207         (hppa_gdbarch_init): Don't register deleted functions with
9208         gdbarch.
9209
9210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9213         (h8300_unwind_sp): Delete.
9214         (h8300_dummy_id): Delete.
9215         (h8300_gdbarch_init): Don't register deleted functions with
9216         gdbarch.
9217
9218 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9219
9220         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9221         (ft32_unwind_pc): Delete.
9222         (ft32_unwind_sp): Delete.
9223         (ft32_gdbarch_init): Don't register deleted functions with
9224         gdbarch.
9225
9226 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9227
9228         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9229         (frv_unwind_pc): Delete.
9230         (frv_unwind_sp): Delete.
9231         (frv_gdbarch_init): Don't register deleted functions with
9232         gdbarch.
9233
9234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9235
9236         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9237         (riscv_unwind_pc): Delete.
9238         (riscv_unwind_sp): Delete.
9239         (riscv_gdbarch_init): Don't register deleted functions with
9240         gdbarch.
9241
9242 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9243
9244         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9245         (csky_unwind_pc): Delete.
9246         (csky_unwind_sp): Delete.
9247         (csky_gdbarch_init): Don't register deleted functions with
9248         gdbarch.
9249
9250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9251
9252         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9253         (cris_unwind_pc): Delete.
9254         (cris_unwind_sp): Delete.
9255         (cris_gdbarch_init): Don't register deleted functions with
9256         gdbarch.
9257
9258 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9259
9260         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9261         (bfin_unwind_pc): Delete.
9262         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9263
9264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9267         (arm_unwind_pc): Delete.
9268         (arm_unwind_sp): Delete.
9269         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9270
9271 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9274         (arc_unwind_pc): Delete.
9275         (arc_unwind_sp): Delete.
9276         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9277
9278 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9279
9280         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9281         (alpha_unwind_pc): Delete.
9282         (alpha_gdbarch_init): Don't register deleted functions with
9283         gdbarch.
9284
9285 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9288         (aarch64_unwind_pc): Delete.
9289         (aarch64_unwind_sp): Delete.
9290         (aarch64_gdbarch_init): Don't register deleted functions with
9291         gdbarch.
9292
9293 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9294
9295         * gdbtypes.c (type_align): Don't consider static members when
9296         computing structure alignment.
9297
9298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9301         return 0 for other types.
9302         * arch-utils.c (default_type_align): Always return 0.
9303         * gdbarch.h: Regenerate.
9304         * gdbarch.sh (type_align): Extend comment.
9305         * gdbtypes.c (type_align): Add additional comments, always call
9306         gdbarch_type_align before applying the default rules.
9307         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9308         generic code will then apply a suitable default.
9309         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9310         types, return 0 for other types.
9311
9312 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9313
9314         * NEWS: Create a new section for the next release branch.
9315         Rename the section of the current branch, now that it has
9316         been cut.
9317
9318 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9319
9320         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9321         * version.in: Bump version to 8.3.50.DATE-git.
9322
9323 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9324
9325         * aix-thread.c (ptid_cmp): Remove unused variable.
9326         (get_signaled_thread): Likewise.
9327         (store_regs_user_thread): Likewise.
9328         (store_regs_kernel_thread): Likewise.
9329         (fetch_regs_kernel_thread): Remove shadowed variable.
9330
9331 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * features/riscv/32bit-cpu.xml: Add register numbers.
9334         * features/riscv/32bit-fpu.c: Regenerate.
9335         * features/riscv/32bit-fpu.xml: Add register numbers.
9336         * features/riscv/64bit-cpu.xml: Add register numbers.
9337         * features/riscv/64bit-fpu.c: Regenerate.
9338         * features/riscv/64bit-fpu.xml: Add register numbers.
9339
9340 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9341
9342         * NEWS: Mention two argument form of gdb.Value constructor.
9343         * python/py-value.c (convert_buffer_and_type_to_value): New
9344         function.
9345         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9346         Add support for handling an optional second argument.  Call
9347         convert_buffer_and_type_to_value as appropriate.
9348         * python/python-internal.h (Py_buffer_deleter): New struct.
9349         (Py_buffer_up): New typedef.
9350
9351 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9352
9353         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9354         instead of releasing ownership.
9355
9356 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9357
9358         * dwarf2read.c (open_and_init_dwp_file): Call
9359         elf_numsections instead of bfd_count_sections to initialize
9360         dwp_file->num_sections.
9361
9362 2019-02-25  Tom Tromey  <tromey@adacore.com>
9363
9364         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9365
9366 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9367
9368         * gcore.in: Add '--readnever' option when invoking GDB.
9369
9370 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9371
9372         * MAINTAINERS: Update my email address.
9373
9374 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9375
9376         * build-id.c (build_id_to_debug_bfd_1): New function.
9377         (build_id_to_debug_bfd): Look for separate debug file in
9378         sysroot.
9379
9380 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * gdbarch.sh: Update the copyright year range that is placed into
9383         generated files.
9384
9385 2019-02-22  Keith Seitz  <keiths@redhat.com>
9386
9387         PR symtab/23853
9388         * linespec.c (create_sals_line_offset): Search for the default
9389         symtab's filename instead of its fullname.
9390
9391 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9392
9393         * NEWS: Update style defaults.
9394
9395 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9396
9397         * main.c (captured_main_1): Disable styling in batch mode.
9398
9399 2019-02-20  Tom Tromey  <tom@tromey.com>
9400
9401         * symtab.c (symtab_symbol_info): Fix typos.
9402
9403 2019-02-20  Tom Tromey  <tromey@adacore.com>
9404
9405         * findcmd.c (_initialize_mem_search): Use upper case for
9406         metasyntactic variables.
9407
9408 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9409
9410         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9411         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9412
9413 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9414
9415         * top.h (source_file_name): Change to std::string.
9416         * top.c (source_file_name): Likewise.
9417         (command_line_input): Adjust.
9418         * cli/cli-script.c (script_from_file): Adjust.
9419
9420 2019-02-19  Tom Tromey  <tromey@adacore.com>
9421
9422         * ravenscar-thread.c
9423         (ravenscar_thread_target::update_thread_list): Don't call
9424         ada_build_task_list.
9425         * ada-lang.h (ada_build_task_list): Don't declare.
9426         * ada-tasks.c (struct ada_tasks_inferior_data)
9427         <task_list_valid_p>: Now bool.
9428         (read_known_tasks, ada_task_list_changed)
9429         (ada_tasks_invalidate_inferior_data): Update.
9430         (read_known_tasks_array): Return bool.
9431         (read_known_tasks_list): Likewise.
9432         (read_known_tasks): Return void.
9433         (ada_build_task_list): Now static.
9434
9435 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9436
9437         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9438         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9439
9440 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9441
9442         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9443         variant for ada_tasks_pspace_data_handle and
9444         ada_tasks_inferior_data_handle.
9445         (ada_tasks_pspace_data_cleanup): New function.
9446         (ada_tasks_inferior_data_cleanup): New function.
9447
9448 2019-02-17  Tom Tromey  <tom@tromey.com>
9449
9450         * macrotab.h (macro_source_fullname): Return a std::string.
9451         * macrotab.c (macro_include, check_for_redefinition)
9452         (macro_undef, macro_lookup_definition, foreach_macro)
9453         (foreach_macro_in_scope): Update.
9454         (macro_source_fullname): Return a std::string.
9455         * macrocmd.c (show_pp_source_pos): Update.
9456
9457 2019-02-17  Tom Tromey  <tom@tromey.com>
9458
9459         * macrocmd.c (show_pp_source_pos): Style the file names.
9460
9461 2019-02-17  Tom Tromey  <tom@tromey.com>
9462
9463         PR tui/24197:
9464         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9465
9466 2019-02-17  Tom Tromey  <tom@tromey.com>
9467
9468         * ada-lang.c (user_select_syms): Use filtered printing.
9469         * utils.c (wrap_style): New global.
9470         (desired_style): Remove.
9471         (emit_style_escape): Add stream parameter.
9472         (set_output_style, reset_terminal_style, prompt_for_continue):
9473         Update.
9474         (flush_wrap_buffer): Only flush gdb_stdout.
9475         (wrap_here): Set wrap_style.
9476         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9477         treat escape sequences as a character.  Change when wrap buffer is
9478         flushed.
9479         (fputs_styled): Do not set the output style when the default is
9480         requested.
9481         * ui-style.h (struct ui_file_style) <is_default>: New method.
9482         * source.c (print_source_lines_base): Emit escape sequences in one
9483         piece.
9484
9485 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9486
9487         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9488         integers and enumeration types.
9489
9490 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9491
9492         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9493         instead of lookup_symbol_in_language
9494         (do_exact_match): New function.
9495         (ada_get_symbol_name_matcher): Return do_exact_match when
9496         doing a verbatim match.
9497
9498 2019-02-15  Tom Tromey  <tromey@adacore.com>
9499
9500         * ravenscar-thread.c (ravenscar_thread_target::resume)
9501         (ravenscar_thread_target::wait): Special case wildcard requests.
9502
9503 2019-02-15  Tom Tromey  <tromey@adacore.com>
9504
9505         * ravenscar-thread.c (base_ptid): Remove.
9506         (struct ravenscar_thread_target) <close>: New method.
9507         <m_base_ptid>: New member.
9508         <update_inferior_ptid, active_task, task_is_currently_active,
9509         runtime_initialized>: Declare methods.
9510         <ravenscar_thread_target>: Add constructor.
9511         (ravenscar_thread_target::task_is_currently_active)
9512         (ravenscar_thread_target::update_inferior_ptid)
9513         (ravenscar_runtime_initialized): Rename.  Now methods.
9514         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9515         (ravenscar_thread_target::update_thread_list): Update.
9516         (ravenscar_thread_target::active_task): Now method.
9517         (ravenscar_thread_target::store_registers)
9518         (ravenscar_thread_target::prepare_to_store)
9519         (ravenscar_thread_target::prepare_to_store)
9520         (ravenscar_thread_target::mourn_inferior): Update.
9521         (ravenscar_inferior_created): Use "new" to create target.
9522         (ravenscar_thread_target::get_ada_task_ptid): Update.
9523         (_initialize_ravenscar): Don't initialize base_ptid.
9524         (ravenscar_ops): Remove global.
9525
9526 2019-02-15  Tom Tromey  <tromey@adacore.com>
9527
9528         * target.h (push_target): Declare new overload.
9529         * target.c (push_target): New overload, taking an rvalue reference.
9530         * remote.c (remote_target::open_1): Use push_target overload.
9531         * corelow.c (core_target_open): Use push_target overload.
9532
9533 2019-02-15  Tom Tromey  <tromey@adacore.com>
9534
9535         * ravenscar-thread.c (is_ravenscar_task)
9536         (ravenscar_task_is_currently_active): Return bool.
9537         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9538         (_initialize_ravenscar): Remove "(void)".
9539         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9540         Return bool.
9541
9542 2019-02-15  Tom Tromey  <tromey@adacore.com>
9543
9544         * ravenscar-thread.c (ravenscar_runtime_initializer)
9545         (has_ravenscar_runtime, get_running_thread_id)
9546         (ravenscar_thread_target::resume): Fix indentation.
9547
9548 2019-02-15  Tom Tromey  <tromey@adacore.com>
9549
9550         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9551         from ravenscar_arch_ops.
9552         (sparc_ravenscar_ops::fetch_registers)
9553         (sparc_ravenscar_ops::store_registers): Now methods.
9554         (sparc_ravenscar_prepare_to_store): Remove.
9555         (sparc_ravenscar_ops): Redefine.
9556         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9557         methods and destructor.  Remove members.
9558         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9559         (ravenscar_thread_target::store_registers)
9560         (ravenscar_thread_target::prepare_to_store): Update.
9561         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9562         Remove.
9563         (struct ppc_ravenscar_powerpc_ops): Derive from
9564         ravenscar_arch_ops.
9565         (ppc_ravenscar_powerpc_ops::fetch_registers)
9566         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9567         (ppc_ravenscar_powerpc_ops): Redefine.
9568         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9569         (ppc_ravenscar_e500_ops::fetch_registers)
9570         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9571         (ppc_ravenscar_e500_ops): Redefine.
9572         * aarch64-ravenscar-thread.c
9573         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9574         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9575         (aarch64_ravenscar_fetch_registers)
9576         (aarch64_ravenscar_store_registers): Now methods.
9577         (aarch64_ravenscar_ops): Redefine.
9578
9579 2019-02-15  Tom Tromey  <tromey@adacore.com>
9580
9581         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9582         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9583         (ravenscar_thread_target::stopped_by_watchpoint)
9584         (ravenscar_thread_target::stopped_data_address)
9585         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9586
9587 2019-02-15  Tom Tromey  <tromey@adacore.com>
9588
9589         * ravenscar-thread.c: Fix some typos.
9590
9591 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9592             Tom Tromey  <tromey@adacore.com>
9593
9594         * ada-lang.c (ada_exception_sal): Change addr_string to a
9595         std::string.
9596         (create_ada_exception_catchpoint): Update.
9597
9598 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9599             Tom Tromey  <tromey@adacore.com>
9600
9601         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9602         (bp_location_ops): Remove.
9603         (base_breakpoint_allocate_location): Update.
9604         (free_bp_location): Update.
9605         * ada-lang.c (class ada_catchpoint_location)
9606         <ada_catchpoint_location>: Remove ops parameter.
9607         (ada_catchpoint_location_dtor): Remove.
9608         (ada_catchpoint_location_ops): Remove.
9609         (allocate_location_exception): Update.
9610         * breakpoint.h (struct bp_location_ops): Remove.
9611         (class bp_location) <bp_location>: Remove bp_location_ops
9612         parameter.
9613         <~bp_location>: Add destructor.
9614         <ops>: Remove.
9615
9616 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9617             Pedro Alves  <palves@redhat.com>
9618
9619         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9620         'PATH_MAX'.
9621
9622 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9623             Samuel Thibault  <samuel.thibault@gnu.org>
9624             Thomas Schwinge  <thomas@codesourcery.com>
9625
9626         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9627         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9628
9629 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9630
9631         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9632         (check_empty): Use "const char *".
9633
9634         * gnu-nat.c (gnu_nat_target::detach): Instead of
9635         'detach_inferior (pid)' call
9636         'detach_inferior (find_inferior_pid (pid))'.
9637
9638         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9639         'nat/fork-inferior.o'.
9640         * gnu-nat.c: #include "nat/fork-inferior.h".
9641
9642         * gnu-nat.c (gnu_nat_target::detach): Instead of
9643         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9644         * gnu-nat.h: #include "inf-child.h".
9645         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9646         'i386_gnu_nat_target::fetch_registers'.
9647         (gnu_store_registers): Rename/move to
9648         'i386_gnu_nat_target::store_registers'.
9649
9650         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9651         * gnu-nat.h (mach_thread_info): New function.
9652         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9653
9654         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9655
9656 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9657
9658         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9659
9660 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9661
9662         * windows-nat.c (windows_add_thread): Add new parameter
9663         "main_thread_p" with default value set to false.  Update
9664         function documentation as well as all callers.
9665         (windows_delete_thread): Likewise.
9666         (fake_create_process): Update call to windows_add_thread.
9667         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9668         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9669         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9670         call to windows_delete_thread.
9671
9672 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9673
9674         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9675
9676 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9677
9678         * symfile.c (find_separate_debug_file): Use canonical path of
9679         sysroot with child_path instead of gdb_sysroot if it is valid.
9680
9681 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9682
9683         * symfile.c (find_separate_debug_file): Use child_path to
9684         determine if an object file is under a sysroot.
9685
9686 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9687
9688         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9689         unittests/child-path-selftests.c.
9690         * common/pathstuff.c (child_path): New function.
9691         * common/pathstuff.h (child_path): New prototype.
9692         * unittests/child-path-selftests.c: New file.
9693
9694 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9695
9696         * symfile.c (find_separate_debug_file): Look for separate debug
9697         files in debug directories under the sysroot.
9698
9699 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9700
9701         * symtab.h (struct minimal_symbol data_p): New const method.
9702         (struct minimal_symbol text_p): Likewise.
9703         * symtab.c (output_source_filename): Use file name style
9704         to print file name.
9705         (print_symbol_info): Likewise.
9706         (print_msymbol_info): Use address style to print addresses.
9707         Use function name style to print executable text symbols.
9708         (expand_symtab_containing_pc): Use data_p.
9709         (find_pc_sect_compunit_symtab): Likewise.
9710
9711 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9712
9713         * breakpoint.c (describe_other_breakpoints): Use address style
9714         to print addresses.
9715         (say_where): Likewise.
9716
9717 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9718
9719         * ada-typeprint.c (print_func_type): Print function name
9720         style to print function name.
9721         * c-typeprint.c (c_print_type_1): Likewise.
9722
9723 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9724
9725         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9726         for execve.
9727
9728 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9729
9730         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9731         type_stack.
9732
9733 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9734
9735         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9736         TYPE_CODE_REF types.
9737
9738 2019-02-08  Jim Wilson  <jimw@sifive.com>
9739
9740         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9741         (riscv_linux_fregset): New.
9742         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9743
9744 2019-02-07  Tom Tromey  <tom@tromey.com>
9745
9746         * thread.c (thread_cancel_execution_command): Update.
9747         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9748         methods.
9749         (struct thread_fsm_ops): Remove.
9750         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9751         (thread_fsm_should_stop, thread_fsm_return_value)
9752         (thread_fsm_set_finished, thread_fsm_finished_p)
9753         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9754         Don't declare.
9755         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9756         * infrun.c (clear_proceed_status_thread)
9757         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9758         (print_stop_event): Update.
9759         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9760         Add constructor.
9761         (step_command_fsm_ops): Remove.
9762         (new_step_command_fsm): Remove.
9763         (step_1): Update.
9764         (step_command_fsm::should_stop): Rename from
9765         step_command_fsm_should_stop.
9766         (step_command_fsm::clean_up): Rename from
9767         step_command_fsm_clean_up.
9768         (step_command_fsm::do_async_reply_reason): Rename from
9769         step_command_fsm_async_reply_reason.
9770         (struct until_next_fsm): Inherit from thread_fsm.  Add
9771         constructor.
9772         (until_next_fsm_ops): Remove.
9773         (new_until_next_fsm): Remove.
9774         (until_next_fsm::should_stop): Rename from
9775         until_next_fsm_should_stop.
9776         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9777         (until_next_fsm::do_async_reply_reason): Rename from
9778         until_next_fsm_async_reply_reason.
9779         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9780         constructor.  Change type of breakpoint.
9781         (finish_command_fsm_ops): Remove.
9782         (new_finish_command_fsm): Remove.
9783         (finish_command_fsm::should_stop): Rename from
9784         finish_command_fsm_should_stop.
9785         (finish_command_fsm::clean_up): Rename from
9786         finish_command_fsm_clean_up.
9787         (finish_command_fsm::return_value): Rename from
9788         finish_command_fsm_return_value.
9789         (finish_command_fsm::do_async_reply_reason): Rename from
9790         finish_command_fsm_async_reply_reason.
9791         (finish_command): Update.
9792         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9793         Add constructor.
9794         (call_thread_fsm_ops): Remove.
9795         (call_thread_fsm::call_thread_fsm): Rename from
9796         new_call_thread_fsm.
9797         (call_thread_fsm::should_stop): Rename from
9798         call_thread_fsm_should_stop.
9799         (call_thread_fsm::should_notify_stop): Rename from
9800         call_thread_fsm_should_notify_stop.
9801         (run_inferior_call, call_function_by_hand_dummy): Update.
9802         * cli/cli-interp.c (should_print_stop_to_console): Update.
9803         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9804         Add constructor.  Change type of location_breakpoint,
9805         caller_breakpoint.
9806         (until_break_fsm_ops): Remove.
9807         (new_until_break_fsm): Remove.
9808         (until_break_fsm::should_stop): Rename from
9809         until_break_fsm_should_stop.
9810         (until_break_fsm::clean_up): Rename from
9811         until_break_fsm_clean_up.
9812         (until_break_fsm::do_async_reply_reason): Rename from
9813         until_break_fsm_async_reply_reason.
9814         (until_break_command): Update.
9815         * thread-fsm.c: Remove.
9816         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9817
9818 2019-02-07  Tom Tromey  <tom@tromey.com>
9819
9820         * yy-remap.h: Add include guard.
9821         * xtensa-tdep.h: Add include guard.
9822         * xcoffread.h: Rename include guard.
9823         * varobj-iter.h: Add include guard.
9824         * tui/tui.h: Rename include guard.
9825         * tui/tui-winsource.h: Rename include guard.
9826         * tui/tui-wingeneral.h: Rename include guard.
9827         * tui/tui-windata.h: Rename include guard.
9828         * tui/tui-win.h: Rename include guard.
9829         * tui/tui-stack.h: Rename include guard.
9830         * tui/tui-source.h: Rename include guard.
9831         * tui/tui-regs.h: Rename include guard.
9832         * tui/tui-out.h: Rename include guard.
9833         * tui/tui-layout.h: Rename include guard.
9834         * tui/tui-io.h: Rename include guard.
9835         * tui/tui-hooks.h: Rename include guard.
9836         * tui/tui-file.h: Rename include guard.
9837         * tui/tui-disasm.h: Rename include guard.
9838         * tui/tui-data.h: Rename include guard.
9839         * tui/tui-command.h: Rename include guard.
9840         * tic6x-tdep.h: Add include guard.
9841         * target/waitstatus.h: Rename include guard.
9842         * target/wait.h: Rename include guard.
9843         * target/target.h: Rename include guard.
9844         * target/resume.h: Rename include guard.
9845         * target-float.h: Rename include guard.
9846         * stabsread.h: Add include guard.
9847         * rs6000-tdep.h: Add include guard.
9848         * riscv-fbsd-tdep.h: Add include guard.
9849         * regformats/regdef.h: Rename include guard.
9850         * record.h: Rename include guard.
9851         * python/python.h: Rename include guard.
9852         * python/python-internal.h: Rename include guard.
9853         * python/py-stopevent.h: Rename include guard.
9854         * python/py-ref.h: Rename include guard.
9855         * python/py-record.h: Rename include guard.
9856         * python/py-record-full.h: Rename include guard.
9857         * python/py-record-btrace.h: Rename include guard.
9858         * python/py-instruction.h: Rename include guard.
9859         * python/py-events.h: Rename include guard.
9860         * python/py-event.h: Rename include guard.
9861         * procfs.h: Add include guard.
9862         * proc-utils.h: Add include guard.
9863         * p-lang.h: Add include guard.
9864         * or1k-tdep.h: Rename include guard.
9865         * observable.h: Rename include guard.
9866         * nto-tdep.h: Rename include guard.
9867         * nat/x86-linux.h: Rename include guard.
9868         * nat/x86-linux-dregs.h: Rename include guard.
9869         * nat/x86-gcc-cpuid.h: Add include guard.
9870         * nat/x86-dregs.h: Rename include guard.
9871         * nat/x86-cpuid.h: Rename include guard.
9872         * nat/ppc-linux.h: Rename include guard.
9873         * nat/mips-linux-watch.h: Rename include guard.
9874         * nat/linux-waitpid.h: Rename include guard.
9875         * nat/linux-ptrace.h: Rename include guard.
9876         * nat/linux-procfs.h: Rename include guard.
9877         * nat/linux-osdata.h: Rename include guard.
9878         * nat/linux-nat.h: Rename include guard.
9879         * nat/linux-namespaces.h: Rename include guard.
9880         * nat/linux-btrace.h: Rename include guard.
9881         * nat/glibc_thread_db.h: Rename include guard.
9882         * nat/gdb_thread_db.h: Rename include guard.
9883         * nat/gdb_ptrace.h: Rename include guard.
9884         * nat/fork-inferior.h: Rename include guard.
9885         * nat/amd64-linux-siginfo.h: Rename include guard.
9886         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9887         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9888         * nat/aarch64-linux.h: Rename include guard.
9889         * nat/aarch64-linux-hw-point.h: Rename include guard.
9890         * mn10300-tdep.h: Add include guard.
9891         * mips-linux-tdep.h: Add include guard.
9892         * mi/mi-parse.h: Rename include guard.
9893         * mi/mi-out.h: Rename include guard.
9894         * mi/mi-main.h: Rename include guard.
9895         * mi/mi-interp.h: Rename include guard.
9896         * mi/mi-getopt.h: Rename include guard.
9897         * mi/mi-console.h: Rename include guard.
9898         * mi/mi-common.h: Rename include guard.
9899         * mi/mi-cmds.h: Rename include guard.
9900         * mi/mi-cmd-break.h: Rename include guard.
9901         * m2-lang.h: Add include guard.
9902         * location.h: Rename include guard.
9903         * linux-record.h: Rename include guard.
9904         * linux-nat.h: Add include guard.
9905         * linux-fork.h: Add include guard.
9906         * i386-darwin-tdep.h: Rename include guard.
9907         * hppa-linux-offsets.h: Add include guard.
9908         * guile/guile.h: Rename include guard.
9909         * guile/guile-internal.h: Rename include guard.
9910         * gnu-nat.h: Rename include guard.
9911         * gdb-stabs.h: Rename include guard.
9912         * frv-tdep.h: Add include guard.
9913         * f-lang.h: Add include guard.
9914         * event-loop.h: Add include guard.
9915         * darwin-nat.h: Rename include guard.
9916         * cp-abi.h: Rename include guard.
9917         * config/sparc/nm-sol2.h: Rename include guard.
9918         * config/nm-nto.h: Rename include guard.
9919         * config/nm-linux.h: Add include guard.
9920         * config/i386/nm-i386gnu.h: Rename include guard.
9921         * config/djgpp/nl_types.h: Rename include guard.
9922         * config/djgpp/langinfo.h: Rename include guard.
9923         * compile/gcc-cp-plugin.h: Add include guard.
9924         * compile/gcc-c-plugin.h: Add include guard.
9925         * compile/compile.h: Rename include guard.
9926         * compile/compile-object-run.h: Rename include guard.
9927         * compile/compile-object-load.h: Rename include guard.
9928         * compile/compile-internal.h: Rename include guard.
9929         * compile/compile-cplus.h: Rename include guard.
9930         * compile/compile-c.h: Rename include guard.
9931         * common/xml-utils.h: Rename include guard.
9932         * common/x86-xstate.h: Rename include guard.
9933         * common/version.h: Rename include guard.
9934         * common/vec.h: Rename include guard.
9935         * common/tdesc.h: Rename include guard.
9936         * common/selftest.h: Rename include guard.
9937         * common/scoped_restore.h: Rename include guard.
9938         * common/scoped_mmap.h: Rename include guard.
9939         * common/scoped_fd.h: Rename include guard.
9940         * common/safe-iterator.h: Rename include guard.
9941         * common/run-time-clock.h: Rename include guard.
9942         * common/refcounted-object.h: Rename include guard.
9943         * common/queue.h: Rename include guard.
9944         * common/ptid.h: Rename include guard.
9945         * common/print-utils.h: Rename include guard.
9946         * common/preprocessor.h: Rename include guard.
9947         * common/pathstuff.h: Rename include guard.
9948         * common/observable.h: Rename include guard.
9949         * common/netstuff.h: Rename include guard.
9950         * common/job-control.h: Rename include guard.
9951         * common/host-defs.h: Rename include guard.
9952         * common/gdb_wait.h: Rename include guard.
9953         * common/gdb_vecs.h: Rename include guard.
9954         * common/gdb_unlinker.h: Rename include guard.
9955         * common/gdb_unique_ptr.h: Rename include guard.
9956         * common/gdb_tilde_expand.h: Rename include guard.
9957         * common/gdb_sys_time.h: Rename include guard.
9958         * common/gdb_string_view.h: Rename include guard.
9959         * common/gdb_splay_tree.h: Rename include guard.
9960         * common/gdb_setjmp.h: Rename include guard.
9961         * common/gdb_ref_ptr.h: Rename include guard.
9962         * common/gdb_optional.h: Rename include guard.
9963         * common/gdb_locale.h: Rename include guard.
9964         * common/gdb_assert.h: Rename include guard.
9965         * common/filtered-iterator.h: Rename include guard.
9966         * common/filestuff.h: Rename include guard.
9967         * common/fileio.h: Rename include guard.
9968         * common/environ.h: Rename include guard.
9969         * common/common-utils.h: Rename include guard.
9970         * common/common-types.h: Rename include guard.
9971         * common/common-regcache.h: Rename include guard.
9972         * common/common-inferior.h: Rename include guard.
9973         * common/common-gdbthread.h: Rename include guard.
9974         * common/common-exceptions.h: Rename include guard.
9975         * common/common-defs.h: Rename include guard.
9976         * common/common-debug.h: Rename include guard.
9977         * common/cleanups.h: Rename include guard.
9978         * common/buffer.h: Rename include guard.
9979         * common/btrace-common.h: Rename include guard.
9980         * common/break-common.h: Rename include guard.
9981         * cli/cli-utils.h: Rename include guard.
9982         * cli/cli-style.h: Rename include guard.
9983         * cli/cli-setshow.h: Rename include guard.
9984         * cli/cli-script.h: Rename include guard.
9985         * cli/cli-interp.h: Rename include guard.
9986         * cli/cli-decode.h: Rename include guard.
9987         * cli/cli-cmds.h: Rename include guard.
9988         * charset-list.h: Add include guard.
9989         * buildsym-legacy.h: Rename include guard.
9990         * bfin-tdep.h: Add include guard.
9991         * ax.h: Rename include guard.
9992         * arm-linux-tdep.h: Add include guard.
9993         * arm-fbsd-tdep.h: Add include guard.
9994         * arch/xtensa.h: Rename include guard.
9995         * arch/tic6x.h: Add include guard.
9996         * arch/i386.h: Add include guard.
9997         * arch/arm.h: Rename include guard.
9998         * arch/arm-linux.h: Rename include guard.
9999         * arch/arm-get-next-pcs.h: Rename include guard.
10000         * arch/amd64.h: Add include guard.
10001         * arch/aarch64-insn.h: Rename include guard.
10002         * arch-utils.h: Rename include guard.
10003         * annotate.h: Add include guard.
10004         * amd64-darwin-tdep.h: Rename include guard.
10005         * aarch64-linux-tdep.h: Add include guard.
10006         * aarch64-fbsd-tdep.h: Add include guard.
10007         * aarch32-linux-nat.h: Add include guard.
10008
10009 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10010
10011         * macrotab.c (macro_define_internal): New function that
10012         factorizes macro_define_object_internal and macro_define_function
10013         code.
10014         (macro_define_object_internal): Use macro_define_internal.
10015         (macro_define_function): Likewise.
10016
10017 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10018
10019         * macrocmd.c (extract_identifier): Return
10020         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10021         callers.
10022
10023 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10024
10025         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10026
10027 2019-02-05  Tom Tromey  <tom@tromey.com>
10028
10029         * target.c (target_stack::unpush): Move assertion earlier.
10030
10031 2019-01-30  Tom Tromey  <tom@tromey.com>
10032
10033         PR python/23615:
10034         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10035         (gdbpy_parse_and_eval): Likewise.
10036         * python/python-internal.h (gdbpy_allow_threads): New class.
10037
10038 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10039
10040         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10041         (aarch64_fbsd_fpregmap): Move earlier.
10042         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10043         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10044         instead of individual calls to trad_frame_set_reg_addr.
10045         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10046         earlier.
10047         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10048         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10049         instead of individual calls to trad_frame_set_reg_addr.
10050
10051 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10052
10053         * CONTRIBUTE: Replace contribution list with wiki link.
10054
10055 2019-01-25  Tom Tromey  <tom@tromey.com>
10056
10057         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10058
10059 2019-01-25  Tom Tromey  <tom@tromey.com>
10060
10061         * xtensa-linux-nat.c: Fix common/ includes.
10062         * xml-support.h: Fix common/ includes.
10063         * xml-support.c: Fix common/ includes.
10064         * x86-linux-nat.c: Fix common/ includes.
10065         * windows-nat.c: Fix common/ includes.
10066         * varobj.h: Fix common/ includes.
10067         * varobj.c: Fix common/ includes.
10068         * value.c: Fix common/ includes.
10069         * valops.c: Fix common/ includes.
10070         * utils.c: Fix common/ includes.
10071         * unittests/xml-utils-selftests.c: Fix common/ includes.
10072         * unittests/utils-selftests.c: Fix common/ includes.
10073         * unittests/unpack-selftests.c: Fix common/ includes.
10074         * unittests/tracepoint-selftests.c: Fix common/ includes.
10075         * unittests/style-selftests.c: Fix common/ includes.
10076         * unittests/string_view-selftests.c: Fix common/ includes.
10077         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10078         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10079         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10080         * unittests/rsp-low-selftests.c: Fix common/ includes.
10081         * unittests/parse-connection-spec-selftests.c: Fix common/
10082         includes.
10083         * unittests/optional-selftests.c: Fix common/ includes.
10084         * unittests/offset-type-selftests.c: Fix common/ includes.
10085         * unittests/observable-selftests.c: Fix common/ includes.
10086         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10087         * unittests/memrange-selftests.c: Fix common/ includes.
10088         * unittests/memory-map-selftests.c: Fix common/ includes.
10089         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10090         * unittests/function-view-selftests.c: Fix common/ includes.
10091         * unittests/environ-selftests.c: Fix common/ includes.
10092         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10093         * unittests/common-utils-selftests.c: Fix common/ includes.
10094         * unittests/cli-utils-selftests.c: Fix common/ includes.
10095         * unittests/array-view-selftests.c: Fix common/ includes.
10096         * ui-file.c: Fix common/ includes.
10097         * tui/tui-io.c: Fix common/ includes.
10098         * tracepoint.h: Fix common/ includes.
10099         * tracepoint.c: Fix common/ includes.
10100         * tracefile-tfile.c: Fix common/ includes.
10101         * top.h: Fix common/ includes.
10102         * top.c: Fix common/ includes.
10103         * thread.c: Fix common/ includes.
10104         * target/waitstatus.h: Fix common/ includes.
10105         * target/waitstatus.c: Fix common/ includes.
10106         * target.h: Fix common/ includes.
10107         * target.c: Fix common/ includes.
10108         * target-memory.c: Fix common/ includes.
10109         * target-descriptions.c: Fix common/ includes.
10110         * symtab.h: Fix common/ includes.
10111         * symfile.c: Fix common/ includes.
10112         * stap-probe.c: Fix common/ includes.
10113         * spu-linux-nat.c: Fix common/ includes.
10114         * sparc-nat.c: Fix common/ includes.
10115         * source.c: Fix common/ includes.
10116         * solib.c: Fix common/ includes.
10117         * solib-target.c: Fix common/ includes.
10118         * ser-unix.c: Fix common/ includes.
10119         * ser-tcp.c: Fix common/ includes.
10120         * ser-pipe.c: Fix common/ includes.
10121         * ser-base.c: Fix common/ includes.
10122         * selftest-arch.c: Fix common/ includes.
10123         * s12z-tdep.c: Fix common/ includes.
10124         * rust-exp.y: Fix common/ includes.
10125         * rs6000-aix-tdep.c: Fix common/ includes.
10126         * riscv-tdep.c: Fix common/ includes.
10127         * remote.c: Fix common/ includes.
10128         * remote-notif.h: Fix common/ includes.
10129         * remote-fileio.h: Fix common/ includes.
10130         * remote-fileio.c: Fix common/ includes.
10131         * regcache.h: Fix common/ includes.
10132         * regcache.c: Fix common/ includes.
10133         * record-btrace.c: Fix common/ includes.
10134         * python/python.c: Fix common/ includes.
10135         * python/py-type.c: Fix common/ includes.
10136         * python/py-inferior.c: Fix common/ includes.
10137         * progspace.h: Fix common/ includes.
10138         * producer.c: Fix common/ includes.
10139         * procfs.c: Fix common/ includes.
10140         * proc-api.c: Fix common/ includes.
10141         * printcmd.c: Fix common/ includes.
10142         * ppc-linux-nat.c: Fix common/ includes.
10143         * parser-defs.h: Fix common/ includes.
10144         * osdata.c: Fix common/ includes.
10145         * obsd-nat.c: Fix common/ includes.
10146         * nat/x86-linux.c: Fix common/ includes.
10147         * nat/x86-linux-dregs.c: Fix common/ includes.
10148         * nat/x86-dregs.h: Fix common/ includes.
10149         * nat/x86-dregs.c: Fix common/ includes.
10150         * nat/ppc-linux.c: Fix common/ includes.
10151         * nat/mips-linux-watch.h: Fix common/ includes.
10152         * nat/mips-linux-watch.c: Fix common/ includes.
10153         * nat/linux-waitpid.c: Fix common/ includes.
10154         * nat/linux-ptrace.h: Fix common/ includes.
10155         * nat/linux-ptrace.c: Fix common/ includes.
10156         * nat/linux-procfs.c: Fix common/ includes.
10157         * nat/linux-personality.c: Fix common/ includes.
10158         * nat/linux-osdata.c: Fix common/ includes.
10159         * nat/linux-namespaces.c: Fix common/ includes.
10160         * nat/linux-btrace.h: Fix common/ includes.
10161         * nat/linux-btrace.c: Fix common/ includes.
10162         * nat/fork-inferior.c: Fix common/ includes.
10163         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10164         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10165         * nat/aarch64-linux.c: Fix common/ includes.
10166         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10167         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10168         * namespace.h: Fix common/ includes.
10169         * mips-linux-tdep.c: Fix common/ includes.
10170         * minsyms.c: Fix common/ includes.
10171         * mi/mi-parse.h: Fix common/ includes.
10172         * mi/mi-main.c: Fix common/ includes.
10173         * mi/mi-cmd-env.c: Fix common/ includes.
10174         * memrange.h: Fix common/ includes.
10175         * memattr.c: Fix common/ includes.
10176         * maint.h: Fix common/ includes.
10177         * maint.c: Fix common/ includes.
10178         * main.c: Fix common/ includes.
10179         * machoread.c: Fix common/ includes.
10180         * location.c: Fix common/ includes.
10181         * linux-thread-db.c: Fix common/ includes.
10182         * linux-nat.c: Fix common/ includes.
10183         * linux-fork.c: Fix common/ includes.
10184         * inline-frame.c: Fix common/ includes.
10185         * infrun.c: Fix common/ includes.
10186         * inflow.c: Fix common/ includes.
10187         * inferior.h: Fix common/ includes.
10188         * inferior.c: Fix common/ includes.
10189         * infcmd.c: Fix common/ includes.
10190         * inf-ptrace.c: Fix common/ includes.
10191         * inf-child.c: Fix common/ includes.
10192         * ia64-linux-nat.c: Fix common/ includes.
10193         * i387-tdep.c: Fix common/ includes.
10194         * i386-tdep.c: Fix common/ includes.
10195         * i386-linux-tdep.c: Fix common/ includes.
10196         * i386-linux-nat.c: Fix common/ includes.
10197         * i386-go32-tdep.c: Fix common/ includes.
10198         * i386-fbsd-tdep.c: Fix common/ includes.
10199         * i386-fbsd-nat.c: Fix common/ includes.
10200         * guile/scm-type.c: Fix common/ includes.
10201         * guile/guile.c: Fix common/ includes.
10202         * go32-nat.c: Fix common/ includes.
10203         * gnu-nat.c: Fix common/ includes.
10204         * gdbthread.h: Fix common/ includes.
10205         * gdbarch-selftests.c: Fix common/ includes.
10206         * gdb_usleep.c: Fix common/ includes.
10207         * gdb_select.h: Fix common/ includes.
10208         * gdb_bfd.c: Fix common/ includes.
10209         * gcore.c: Fix common/ includes.
10210         * fork-child.c: Fix common/ includes.
10211         * findvar.c: Fix common/ includes.
10212         * fbsd-nat.c: Fix common/ includes.
10213         * event-top.c: Fix common/ includes.
10214         * event-loop.c: Fix common/ includes.
10215         * dwarf2read.c: Fix common/ includes.
10216         * dwarf2loc.c: Fix common/ includes.
10217         * dwarf2-frame.c: Fix common/ includes.
10218         * dwarf-index-cache.c: Fix common/ includes.
10219         * dtrace-probe.c: Fix common/ includes.
10220         * disasm-selftests.c: Fix common/ includes.
10221         * defs.h: Fix common/ includes.
10222         * csky-tdep.c: Fix common/ includes.
10223         * cp-valprint.c: Fix common/ includes.
10224         * cp-support.h: Fix common/ includes.
10225         * cp-support.c: Fix common/ includes.
10226         * corelow.c: Fix common/ includes.
10227         * completer.h: Fix common/ includes.
10228         * completer.c: Fix common/ includes.
10229         * compile/compile.c: Fix common/ includes.
10230         * compile/compile-loc2c.c: Fix common/ includes.
10231         * compile/compile-cplus-types.c: Fix common/ includes.
10232         * compile/compile-cplus-symbols.c: Fix common/ includes.
10233         * command.h: Fix common/ includes.
10234         * cli/cli-dump.c: Fix common/ includes.
10235         * cli/cli-cmds.c: Fix common/ includes.
10236         * charset.c: Fix common/ includes.
10237         * build-id.c: Fix common/ includes.
10238         * btrace.h: Fix common/ includes.
10239         * btrace.c: Fix common/ includes.
10240         * breakpoint.h: Fix common/ includes.
10241         * breakpoint.c: Fix common/ includes.
10242         * ax.h:
10243         (enum agent_op): Fix common/ includes.
10244         * ax-general.c (struct aop_map): Fix common/ includes.
10245         * ax-gdb.c: Fix common/ includes.
10246         * auxv.c: Fix common/ includes.
10247         * auto-load.c: Fix common/ includes.
10248         * arm-tdep.c: Fix common/ includes.
10249         * arch/riscv.c: Fix common/ includes.
10250         * arch/ppc-linux-common.c: Fix common/ includes.
10251         * arch/i386.c: Fix common/ includes.
10252         * arch/arm.c: Fix common/ includes.
10253         * arch/arm-linux.c: Fix common/ includes.
10254         * arch/arm-get-next-pcs.c: Fix common/ includes.
10255         * arch/amd64.c: Fix common/ includes.
10256         * arch/aarch64.c: Fix common/ includes.
10257         * arch/aarch64-insn.c: Fix common/ includes.
10258         * arch-utils.c: Fix common/ includes.
10259         * amd64-windows-tdep.c: Fix common/ includes.
10260         * amd64-tdep.c: Fix common/ includes.
10261         * amd64-sol2-tdep.c: Fix common/ includes.
10262         * amd64-obsd-tdep.c: Fix common/ includes.
10263         * amd64-nbsd-tdep.c: Fix common/ includes.
10264         * amd64-linux-tdep.c: Fix common/ includes.
10265         * amd64-linux-nat.c: Fix common/ includes.
10266         * amd64-fbsd-tdep.c: Fix common/ includes.
10267         * amd64-fbsd-nat.c: Fix common/ includes.
10268         * amd64-dicos-tdep.c: Fix common/ includes.
10269         * amd64-darwin-tdep.c: Fix common/ includes.
10270         * agent.c: Fix common/ includes.
10271         * ada-lang.h: Fix common/ includes.
10272         * ada-lang.c: Fix common/ includes.
10273         * aarch64-tdep.c: Fix common/ includes.
10274
10275 2019-01-25  Tom Tromey  <tom@tromey.com>
10276
10277         * common/create-version.sh: Use common/version.h.
10278
10279 2019-01-24  Pedro Alves  <palves@redhat.com>
10280
10281         * infrun.c (signal_stop, signal_print, signal_program)
10282         (signal_catch, signal_pass): Now arrays instead of pointers.
10283         (update_signals_program_target, do_target_resume)
10284         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10285         * linux-nat.c (linux_nat_target::pass_signals)
10286         (linux_nat_target::create_inferior, linux_nat_target::attach):
10287         Adjust.
10288         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10289         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10290         * procfs.c (procfs_target::pass_signals): Adjust.
10291         * record-full.c (record_full_target::resume): Adjust.
10292         * remote.c (remote_target::pass_signals)
10293         (remote_target::program_signals): Adjust.
10294         * target-debug.h (target_debug_print_signals): Now takes a
10295         gdb::array_view as parameter.  Adjust.
10296         * target.h (target_ops) <pass_signals, program_signals>: Replace
10297         pointer and length parameters with gdb::array_view.
10298         (target_pass_signals, target_program_signals): Likewise.
10299         * target-delegates.c: Regenerate.
10300
10301 2019-01-24  Pedro Alves  <palves@redhat.com>
10302
10303         * common/forward-scope-exit.h
10304         (forward_scope_exit::forward_scope_exit): Pass arguments to
10305         m_bind_function directly, instead of creating a std::bind and
10306         copying that.
10307
10308 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10309
10310         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10311         for static members.
10312         (pass_in_v_vfp_candidate): Likewise.
10313
10314 2019-01-23  Tom Tromey  <tom@tromey.com>
10315             Pedro Alves  <palves@redhat.com>
10316
10317         * regcache.c (class regcache_invalidator): Remove.
10318         (regcache::raw_write): Use make_scope_exit.
10319
10320 2019-01-23  Tom Tromey  <tom@tromey.com>
10321
10322         * ui-out.h (class ui_out_emit_type): Update comment.
10323
10324 2019-01-23  Tom Tromey  <tom@tromey.com>
10325
10326         * infrun.c (fetch_inferior_event): Update comment.
10327
10328 2019-01-23  Tom Tromey  <tom@tromey.com>
10329             Pedro Alves  <palves@redhat.com>
10330
10331         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10332         parameter.
10333         (fetch_inferior_event): Use SCOPE_EXIT.
10334
10335
10336 2019-01-23  Tom Tromey  <tom@tromey.com>
10337             Pedro Alves  <palves@redhat.com>
10338
10339         * infrun.c (disable_thread_events): Delete.
10340         (stop_all_threads): Use SCOPE_EXIT.
10341
10342 2019-01-23  Tom Tromey  <tom@tromey.com>
10343             Pedro Alves  <palves@redhat.com>
10344
10345         * symfile.c: Include forward-scope-exit.h.
10346         (clear_symtab_users_cleanup): Replace forward declaration with
10347         a FORWARD_SCOPE_EXIT.
10348         (syms_from_objfile_1): Use the forward_scope_exit and
10349         gdb::optional instead of cleanup_function.
10350         (reread_symbols): Use the forward_scope_exit instead of
10351         cleanup_function.
10352         (clear_symtab_users_cleanup): Remove function.
10353
10354 2019-01-23  Tom Tromey  <tom@tromey.com>
10355             Pedro Alves  <palves@redhat.com>
10356
10357         * linux-nat.c: Include scope-exit.h.
10358         (cleanup_target_stop): Remove.
10359         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10360         SCOPE_EXIT.
10361
10362 2019-01-23  Tom Tromey  <tom@tromey.com>
10363             Pedro Alves  <palves@redhat.com>
10364
10365         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10366         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10367
10368 2019-01-23  Tom Tromey  <tom@tromey.com>
10369             Andrew Burgess  <andrew.burgess@embecosm.com>
10370             Pedro Alves  <palves@redhat.com>
10371
10372         * infrun.c (fetch_inferior_event): Use scope_exit.
10373         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10374         * top.c (execute_command): Use scope_exit.
10375         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10376         * utils.c (do_bpstat_clear_actions_cleanup)
10377         (make_bpstat_clear_actions_cleanup): Remove.
10378
10379 2019-01-23  Tom Tromey  <tom@tromey.com>
10380             Pedro Alves  <palves@redhat.com>
10381
10382         * infrun.c: Include "common/scope-exit.h"
10383         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10384         (wait_for_inferior): Use SCOPE_EXIT.
10385         (fetch_inferior_event): Use scope_exit.
10386
10387 2019-01-23  Tom Tromey  <tom@tromey.com>
10388             Pedro Alves  <palves@redhat.com>
10389
10390         * breakpoint.c (create_breakpoint): Remove cleanup.
10391
10392 2019-01-23  Tom Tromey  <tom@tromey.com>
10393             Andrew Burgess  <andrew.burgess@embecosm.com>
10394             Pedro Alves  <palves@redhat.com>
10395
10396 2019-01-23  Pedro Alves  <palves@redhat.com>
10397
10398         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10399
10400 2019-01-23  Pedro Alves  <palves@redhat.com>
10401             Andrew Burgess  <andrew.burgess@embecosm.com>
10402
10403         * gdbthread.h: Include "common/forward-scope-exit.h".
10404         (scoped_finish_thread_state): Redefine custom class in terms of
10405         forward_scope_exit.
10406
10407 2019-01-23  Pedro Alves  <palves@redhat.com>
10408             Andrew Burgess  <andrew.burgess@embecosm.com>
10409
10410         * common/forward-scope-exit.h: New file.
10411
10412 2019-01-23  Pedro Alves  <palves@redhat.com>
10413             Andrew Burgess  <andrew.burgess@embecosm.com>
10414             Tom Tromey  <tom@tromey.com>
10415
10416         * common/scope-exit.h: New file.
10417
10418 2019-01-23  Pedro Alves  <palves@redhat.com>
10419
10420         * common/preprocessor.h (ESC): Rename to ...
10421         (ESC_PARENS): ... this.
10422         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10423         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10424
10425 2019-01-23  Tom Tromey  <tom@tromey.com>
10426
10427         * language.h (class scoped_switch_to_sym_language_if_auto):
10428         Initialize m_lang in both cases.
10429
10430 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10431
10432         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10433         with XCNEW.
10434
10435 2019-01-22  Tom Tromey  <tom@tromey.com>
10436
10437         * corelow.c: Do not include sys/file.h.
10438
10439 2019-01-22  Tom Tromey  <tom@tromey.com>
10440
10441         * tui/tui-wingeneral.h: Include gdb_curses.h.
10442
10443 2019-01-22  Tom Tromey  <tom@tromey.com>
10444
10445         * source-cache.h (class source_cache) <get_source_lines,
10446         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10447
10448 2019-01-22  Tom Tromey  <tom@tromey.com>
10449
10450         * remote-fileio.h (struct remote_target): Declare.
10451
10452 2019-01-22  Tom Tromey  <tom@tromey.com>
10453
10454         * python/py-arch.c: Do not include py-ref.h.
10455         * python/py-bpevent.c: Do not include py-ref.h.
10456         * python/py-cmd.c: Do not include py-ref.h.
10457         * python/py-continueevent.c: Do not include py-ref.h.
10458         * python/py-event.h: Do not include py-ref.h.
10459         * python/py-evtregistry.c: Do not include py-ref.h.
10460         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10461         * python/py-frame.c: Do not include py-ref.h.
10462         * python/py-framefilter.c: Do not include py-ref.h.
10463         * python/py-function.c: Do not include py-ref.h.
10464         * python/py-infevents.c: Do not include py-ref.h.
10465         * python/py-linetable.c: Do not include py-ref.h.
10466         * python/py-objfile.c: Do not include py-ref.h.
10467         * python/py-param.c: Do not include py-ref.h.
10468         * python/py-prettyprint.c: Do not include py-ref.h.
10469         * python/py-progspace.c: Do not include py-ref.h.
10470         * python/py-symbol.c: Do not include py-ref.h.
10471         * python/py-symtab.c: Do not include py-ref.h.
10472         * python/py-type.c: Do not include py-ref.h.
10473         * python/py-unwind.c: Do not include py-ref.h.
10474         * python/py-utils.c: Do not include py-ref.h.
10475         * python/py-value.c: Do not include py-ref.h.
10476         * python/py-varobj.c: Do not include py-ref.h.
10477         * python/py-xmethods.c: Do not include py-ref.h.
10478         * python/python.c: Do not include py-ref.h.
10479         * varobj.c: Do not include py-ref.h.
10480
10481 2019-01-22  Tom Tromey  <tom@tromey.com>
10482
10483         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10484         keyword for bcache.
10485
10486 2019-01-22  Tom Tromey  <tom@tromey.com>
10487
10488         * compile/compile-cplus-types.c: Remove a comment by #include.
10489
10490 2019-01-22  Tom Tromey  <tom@tromey.com>
10491
10492         * compile/gcc-c-plugin.h: Include compile-internal.h.
10493
10494 2019-01-22  Tom Tromey  <tom@tromey.com>
10495
10496         * stabsread.c (EXTERN): Do not define.
10497         (symnum, next_symbol_text_func, processing_gcc_compilation)
10498         (within_function, global_sym_chain, global_stabs)
10499         (previous_stab_code, this_object_header_files)
10500         (n_this_object_header_files)
10501         (n_allocated_this_object_header_files): Define.
10502         * stabsread.h (EXTERN): Never define.  Use "extern".
10503
10504 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10505
10506         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10507         history_value.
10508
10509 2019-01-21  Tom Tromey  <tom@tromey.com>
10510
10511         * ui-out.c: Fix includes.
10512         * tui/tui-source.c: Fix includes.
10513         * target.c: Fix includes.
10514         * remote.c: Fix includes.
10515         * regcache.c: Fix includes.
10516         * python/py-block.c: Fix includes.
10517         * printcmd.c: Fix includes.
10518         * or1k-tdep.c: Fix includes.
10519         * mi/mi-main.c: Fix includes.
10520         * m32r-tdep.c: Fix includes.
10521         * csky-tdep.c: Fix includes.
10522         * compile/compile-cplus-types.c: Fix includes.
10523         * cli/cli-interp.c: Fix includes.
10524
10525 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10526
10527         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10528         for padding.
10529
10530 2019-01-16  Tom Tromey  <tom@tromey.com>
10531
10532         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10533         earlier.
10534         (struct objfile) <msymbols_range>: Move from top level.
10535         <msymbols>: New method.
10536         (class objfile_msymbols): Remove.
10537         * symtab.c (default_collect_symbol_completion_matches_break_on):
10538         Update.
10539         * symmisc.c (dump_msymbols): Update.
10540         * stabsread.c (scan_file_globals): Update.
10541         * objc-lang.c (info_selectors_command, info_classes_command)
10542         (find_methods): Update.
10543         * minsyms.c (find_solib_trampoline_target): Update.
10544         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10545         * coffread.c (coff_symfile_read): Update.
10546         * ada-lang.c (ada_lookup_simple_minsym)
10547         (ada_collect_symbol_completion_matches): Update.
10548
10549 2019-01-16  Tom Tromey  <tom@tromey.com>
10550
10551         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10552         type.  Remove no-argument constructor.
10553         <iterator::operator++>: Simplify.
10554         <begin>: Update.
10555         <end>: Use minimal_symbol_count.
10556
10557 2019-01-16  Tom Tromey  <tom@tromey.com>
10558
10559         * objfiles.h (struct objfile) <psymtabs>: New method.
10560         (class objfile_psymtabs): Remove.
10561         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10562         typedef.
10563         <range>: New method.
10564         (require_partial_symbols): Change return type.
10565         * psymtab.c (require_partial_symbols)
10566         (psym_expand_symtabs_matching): Update.
10567         * mdebugread.c (parse_partial_symbols): Update.
10568         * dbxread.c (dbx_end_psymtab): Update.
10569
10570 2019-01-15  Tom Tromey  <tom@tromey.com>
10571
10572         * symtab.c (lookup_objfile_from_block)
10573         (lookup_symbol_in_objfile_symtabs)
10574         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10575         (find_line_symtab, info_sources_command)
10576         (default_collect_symbol_completion_matches_break_on)
10577         (make_source_files_completion_list): Update.
10578         * symmisc.c (print_objfile_statistics, dump_objfile)
10579         (maintenance_print_symbols, maintenance_info_symtabs)
10580         (maintenance_check_symtabs, maintenance_info_line_tables):
10581         Update.
10582         * source.c (select_source_symtab)
10583         (forget_cached_source_info_for_objfile): Update.
10584         * objfiles.h (class objfile_compunits): Remove.
10585         (struct objfile) <compunits_range>: New typedef.
10586         (compunits): New method.
10587         * objfiles.c (objfile_relocate1): Update.
10588         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10589         * maint.c (count_symtabs_and_blocks): Update.
10590         * linespec.c (iterate_over_all_matching_symtabs): Update.
10591         * cp-support.c (add_symbol_overload_list_qualified): Update.
10592         * coffread.c (coff_symtab_read): Update.
10593         * ada-lang.c (add_nonlocal_symbols)
10594         (ada_collect_symbol_completion_matches)
10595         (ada_add_global_exceptions): Update.
10596
10597 2019-01-15  Tom Tromey  <tom@tromey.com>
10598
10599         * progspace.h (program_space) <objfiles_safe_range>: New
10600         typedef.
10601         <objfiles_safe>: New method.
10602         * objfiles.h (class all_objfiles_safe): Remove.
10603         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10604         * jit.c (jit_inferior_exit_hook): Update.
10605
10606 2019-01-17  Tom Tromey  <tom@tromey.com>
10607
10608         * progspace.h (program_space) <objfiles_range>: New typedef.
10609         <objfiles>: New method.
10610         <objfiles_head>: Rename from objfiles.
10611         (object_files): Update.
10612         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10613         * guile/scm-pretty-print.c
10614         (ppscm_find_pretty_printer_from_objfiles): Update.
10615         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10616         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10617         Update.
10618         * python/py-progspace.c (pspy_get_objfiles): Update.
10619         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10620         Update.
10621         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10622         (objfpy_lookup_objfile_by_build_id): Update.
10623         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10624         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10625         Update.
10626         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10627         (expand_symtab_containing_pc, lookup_objfile_from_block)
10628         (lookup_static_symbol, basic_lookup_transparent_type)
10629         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10630         (find_line_symtab, info_sources_command)
10631         (default_collect_symbol_completion_matches_break_on)
10632         (make_source_files_completion_list, find_main_name): Update.
10633         * symmisc.c (print_symbol_bcache_statistics)
10634         (print_objfile_statistics, maintenance_print_symbols)
10635         (maintenance_print_msymbols, maintenance_print_objfiles)
10636         (maintenance_info_symtabs, maintenance_check_symtabs)
10637         (maintenance_expand_symtabs, maintenance_info_line_tables):
10638         Update.
10639         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10640         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10641         (map_overlay_command, unmap_overlay_command)
10642         (simple_overlay_update, expand_symtabs_matching)
10643         (map_symbol_filenames): Update.
10644         * symfile-debug.c (set_debug_symfile): Update.
10645         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10646         Update.
10647         * source.c (select_source_symtab, forget_cached_source_info):
10648         Update.
10649         * solib.c (solib_read_symbols): Update.
10650         * solib-spu.c (append_ocl_sos): Update.
10651         * psymtab.c (maintenance_print_psymbols)
10652         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10653         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10654         * printcmd.c (info_symbol_command): Update.
10655         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10656         Update.
10657         * objfiles.h (class all_objfiles): Remove.
10658         * objfiles.c (have_partial_symbols, have_full_symbols)
10659         (have_minimal_symbols, qsort_cmp, update_section_map)
10660         (shared_objfile_contains_address_p)
10661         (default_iterate_over_objfiles_in_search_order): Update.
10662         * objc-lang.c (info_selectors_command, info_classes_command)
10663         (find_methods): Update.
10664         * minsyms.c (find_solib_trampoline_target): Update.
10665         * maint.c (maintenance_info_sections)
10666         (maintenance_translate_address, count_symtabs_and_blocks):
10667         Update.
10668         * main.c (captured_main_1): Update.
10669         * linux-thread-db.c (try_thread_db_load_from_pdir)
10670         (has_libpthread): Update.
10671         * linespec.c (iterate_over_all_matching_symtabs)
10672         (search_minsyms_for_name): Update.
10673         * jit.c (jit_find_objf_with_entry_addr): Update.
10674         * hppa-tdep.c (find_unwind_entry)
10675         (hppa_lookup_stub_minimal_symbol): Update.
10676         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10677         Update.
10678         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10679         (elf_gnu_ifunc_resolve_by_got): Update.
10680         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10681         * dwarf-index-write.c (save_gdb_index_command): Update.
10682         * cp-support.c (add_symbol_overload_list_qualified): Update.
10683         * breakpoint.c (create_overlay_event_breakpoint)
10684         (create_longjmp_master_breakpoint)
10685         (create_std_terminate_master_breakpoint)
10686         (create_exception_master_breakpoint): Update.
10687         * blockframe.c (find_pc_partial_function): Update.
10688         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10689         (ada_collect_symbol_completion_matches)
10690         (ada_add_global_exceptions): Update.
10691
10692 2019-01-17  Tom Tromey  <tom@tromey.com>
10693
10694         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10695         declare VEC.
10696         (solib_target_parse_libraries): Change return type.
10697         (library_list_start_segment, library_list_start_section)
10698         (library_list_end_library, library_list_start_library); Update.
10699         (solib_target_free_library_list): Remove.
10700         (solib_target_parse_libraries): Remove cleanup.  Change return
10701         type.
10702         (solib_target_current_sos): Update.
10703
10704 2019-01-17  Tom Tromey  <tromey@bapiya>
10705
10706         * valprint.c: Replace "the the" with "the".
10707         * symtab.c: Replace "the the" with "the".
10708         * solib.c: Replace "the the" with "the".
10709         * solib-dsbt.c: Replace "the the" with "the".
10710         * linespec.c: Replace "the the" with "the".
10711         * dwarf2loc.h: Replace "the the" with "the".
10712         * amd64-windows-tdep.c: Replace "the the" with "the".
10713         * aarch64-tdep.c: Replace "the the" with "the".
10714
10715 2019-01-16  Keith Seitz  <keiths@redhat.com>
10716
10717         PR gdb/23773
10718         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10719         <builder>: Rename to ..
10720         <m_builder>: ... this and make private.
10721         (dwarf2_cu::get_builder): New method.  Change all users of
10722         `builder' to use this method.
10723         (dwarf2_start_symtab): Move to ...
10724         (dwarf2_cu::start_symtab): ... here.  Update all callers
10725         (setup_type_unit_groups): Move to ...
10726         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10727         callers.
10728         (dwarf2_cu::reset_builder): New method.
10729         (process_full_compunit, process_full_type_unit): Use
10730         dwarf2_cu::reset_builder.
10731         (follow_die_offset): Record the ancestor CU if it is different
10732         from the followed DIE's CU.
10733         (follow_die_sig_1): Likewise.
10734
10735 2019-01-15  Tom Tromey  <tom@tromey.com>
10736
10737         * remote.c (class remote_state) <buf>: Now a char_vector.
10738         <buf_size>: Remove.
10739         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10740         parameter.
10741         (remote_target::getpkt_or_notif_sane_1)
10742         (remote_target::getpkt_sane)
10743         (remote_target::getpkt_or_notif_sane): Likewise.
10744         (class remote_target) <putpkt>: New overload.
10745         (remote_target::read_frame): Change type of "buf_p".  Remove
10746         sizeof_p parameter.
10747         (packet_ok): New overload.
10748         (packet_check_result): New overload.
10749         Update all uses.
10750
10751 2019-01-14  Tom Tromey  <tom@tromey.com>
10752
10753         * remote-notif.c (handle_notification, remote_notif_ack)
10754         (remote_notif_parse): Make "buf" const.
10755         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10756         const.
10757         (remote_notif_parse, remote_notif_ack, handle_notification):
10758         Likewise.
10759         * remote.c (remote_notif_stop_parse): Make "buf" const.
10760         (remote_target::remote_parse_stop_reply): Make "buf" const.
10761         (remote_notif_stop_ack): Make "buf" const.
10762
10763 2019-01-14  Tom Tromey  <tom@tromey.com>
10764
10765         * remote.c (remote_console_output): Make parameter const.
10766
10767 2019-01-14  Tom Tromey  <tom@tromey.com>
10768
10769         * target-debug.h (target_debug_print_signals): Constify.
10770         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10771         * procfs.c (procfs_target::pass_signals): Update.
10772         * linux-nat.c (linux_nat_target::pass_signals): Update.
10773         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10774         * target-delegates.c: Rebuild.
10775         * remote.c (remote_target::program_signals): Update.
10776         (remote_target::pass_signals): Update.
10777         * target.c (target_pass_signals): Constify argument.
10778         (target_program_signals): Likewise.
10779         * target.h (struct target_ops) <pass_signals, program_signals>:
10780         Constify argument.
10781         (target_pass_signals, target_program_signals): Constify argument.
10782
10783 2019-01-14  Tom Tromey  <tom@tromey.com>
10784
10785         PR tui/28819:
10786         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10787
10788 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10789
10790         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10791         field.
10792         * rs6000-tdep.c: Include reggroups.h.
10793         (IS_V_ALIAS_PSEUDOREG): Define.
10794         (rs6000_register_name): Return names for the "vX" aliases.
10795         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10796         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10797         aliases.  Call default_register_reggroup_p for all other
10798         pseudo-registers.
10799         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10800         New functions.
10801         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10802         Handle "vX" aliases.
10803         (v_alias_pseudo_register_collect): New function.
10804         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10805         (rs6000_gdbarch_init): Initialize "vX" aliases as
10806         pseudo-registers.  Restore registration of
10807         rs6000_pseudo_register_reggroup_p with
10808         set_tdesc_pseudo_register_reggroup_p.
10809
10810 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10811
10812         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10813         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10814         set_gdbarch_num_pseudo_regs.
10815
10816 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10817
10818         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10819         Remove arg prefixname, add do_set and do_show.
10820         Add member functions set_list and show_list.
10821         * cli/cli-style.c (class cli_style_option): Update accordingly.
10822         (style_set_list): Move to file scope.
10823         (style_show_list): Likewise.
10824         (set_style): Call help_list.
10825         (show_style): Call cmd_show_list.
10826         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10827         Update to use the new macro.
10828
10829 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10830
10831         * ada-lang.c (_initialize_ada_language): Expand the help text
10832         for the "catch exception" command.
10833
10834 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10835
10836         * symtab.c (matching_obj_sections): Initialize obj,
10837         declare it closer to its usage.
10838
10839 2019-01-10  Tom Tromey  <tom@tromey.com>
10840
10841         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10842         (basic_inf_threads_range): Remove.
10843         (inf_threads_range, inf_non_exited_threads_range)
10844         (safe_inf_threads_range): Use next_adapter.
10845
10846 2019-01-10  Keith Seitz  <keiths@redhat.com>
10847
10848         PR gdb/23712
10849         PR symtab/23010
10850         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10851         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10852
10853 2019-01-10  Keith Seitz  <keiths@redhat.com>
10854
10855         PR gdb/23712
10856         PR symtab/23010
10857         * dictionary.c (pending_to_vector): Remove.
10858         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10859         Remove _1 suffix, replacing functions of the same name.  Update
10860         all callers.
10861         (dict_create_hashed, dict_create_hashed_expandable)
10862         (dict_create_linear, dict_create_linear_expandable, dict_free)
10863         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10864         Make functions static.
10865
10866 2019-01-10  Keith Seitz  <keiths@redhat.com>
10867
10868         PR gdb/23712
10869         PR symtab/23010
10870         * dictionary.h (struct dictionary): Replace declaration with
10871         multidictionary.
10872         (dict_create_hashed, dict_create_hashed_expandable)
10873         (dict_create_linear, dict_create_linear_expandable)
10874         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10875         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10876         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10877         taking multidictionary argument.
10878         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10879         * block.h (struct block) <dict>: Change to multidictionary
10880         and rename `multidict'.
10881         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10882         symmisc.c: Update all dictionary references to multidictionary.
10883
10884 2019-01-10  Keith Seitz  <keiths@redhat.com>
10885
10886         PR gdb/23712
10887         PR symtab/23010
10888         * dictionary.c: Include unordered_map.
10889         (pending_to_vector): New function.
10890         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10891         Rewrite the non-"_1" functions to take vector instead
10892         of linked list.
10893         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10894         "new" _1 versions of the same name.
10895         (multidictionary): Define.
10896         (std::hash<enum language): New definition.
10897         (collate_pending_symbols_by_language, mdict_create_hashed)
10898         (mdict_create_hashed_expandable, mdict_create_linear)
10899         (mdict_create_linear_expandable, mdict_free)
10900         (find_language_dictionary, create_new_language_dictionary)
10901         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10902         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10903         (mdict_size, mdict_empty): New functions.
10904         * dictionary.h (mdict_iterator): Define.
10905
10906 2019-01-10  Pedro Alves  <palves@redhat.com>
10907
10908         * breakpoint.c (read_uploaded_action)
10909         (create_tracepoint_from_upload): Adjust to use
10910         gdb::unique_xmalloc_ptr.
10911         * ctf.c (ctf_write_uploaded_tp):
10912         (SET_ARRAY_FIELD): Use emplace_back.
10913         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10914         * tracefile-tfile.c (tfile_write_uploaded_tp):
10915         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10916         gdb::unique_xmalloc_ptr.
10917         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10918         at_string, cond_string, cmd_strings>: Replace char pointers
10919         with gdb::unique_xmalloc_ptr.
10920
10921 2019-01-10  Pedro Alves  <palves@redhat.com>
10922
10923         * solib-target.c (library_list_start_library): Don't xstrdup name.
10924
10925 2019-01-10  Pedro Alves  <palves@redhat.com>
10926
10927         * mdebugread.c (parse_partial_symbols): Use
10928         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10929
10930 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10931
10932         * linux-fork.c (scoped_switch_fork_info)
10933         <~scoped_switch_fork_info>: Fix incorrect variable name.
10934
10935 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10936
10937         * linux-fork.c (scoped_switch_fork_info)
10938         <scoped_switch_fork_info>: Make explicit.
10939         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10940
10941 2019-01-10  Tom Tromey  <tom@tromey.com>
10942
10943         * objfiles.h (objfile::reset_psymtabs): Update.
10944         * objfiles.c (objfile::objfile): Update.
10945         * psymtab.h (psymtab_storage::obstack): Update.
10946         (psymtab_storage::m_obstack): Use gdb::optional.
10947         (class psymtab_storage): Update comment.  Remove objfile
10948         parameter.
10949         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10950
10951 2019-01-10  Tom Tromey  <tom@tromey.com>
10952
10953         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10954         <free_psymtabs>: Now private.
10955         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10956         (allocate_psymtab): Use new method.
10957
10958 2019-01-10  Tom Tromey  <tom@tromey.com>
10959
10960         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10961         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10962         * mdebugread.c (parse_partial_symbols): Use
10963         allocate_dependencies.
10964         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10965         allocate_dependencies.
10966         (process_psymtab_comp_unit_reader)
10967         (build_type_psymtab_dependencies): Likewise.
10968         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10969
10970 2019-01-10  Tom Tromey  <tom@tromey.com>
10971
10972         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10973         PSYMBOL_SET_LANGUAGE.
10974         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10975
10976 2019-01-10  Tom Tromey  <tom@tromey.com>
10977
10978         * psymtab.h (psymtab_storage::obstack): New method.
10979         <m_obstack>: Rename from obstack; now private.
10980         * psymtab.c (psymtab_storage): Update.
10981         * dwarf2read.c (create_addrmap_from_index)
10982         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10983         Update.
10984
10985 2019-01-10  Tom Tromey  <tom@tromey.com>
10986
10987         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10988         * objfiles.h (objfile::reset_psymtabs): New method.
10989
10990 2019-01-10  Tom Tromey  <tom@tromey.com>
10991
10992         * symmisc.c (print_symbol_bcache_statistics): Update.
10993         (print_objfile_statistics): Update.
10994         * symfile.c (reread_symbols): Update.
10995         * psymtab.h (class psymtab_storage): New.
10996         * psymtab.c (psymtab_storage): New constructor.
10997         (~psymtab_storage): New destructor.
10998         (require_partial_symbols): Update.
10999         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11000         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11001         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11002         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11003         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11004         (start_psymtab_common, end_psymtab_common)
11005         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11006         (allocate_psymtab): Update.
11007         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11008         Update.
11009         (dump_psymtab_addrmap, maintenance_print_psymbols)
11010         (maintenance_check_psymtabs): Update.
11011         (class objfile_psymtabs): Move to objfiles.h.
11012         * psympriv.h (discard_psymtab): Now inline.
11013         (psymtab_discarder::psymtab_discarder): Update.
11014         (psymtab_discarder::~psymtab_discarder): Update.
11015         (ALL_OBJFILE_PSYMTABS): Rewrite.
11016         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11017         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11018         Remove fields.
11019         <partial_symtabs>: New field.
11020         (class objfile_psymtabs): Move from psymtab.h.  Update.
11021         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11022         psymbol_cache.
11023         (objfile::~objfile): Don't destroy psymbol_cache.
11024         * mdebugread.c (parse_partial_symbols): Update.
11025         * dwarf2read.c (create_addrmap_from_index)
11026         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11027         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11028         (add_partial_subprogram, dwarf2_ranges_read): Update.
11029         * dwarf-index-write.c (write_address_map)
11030         (write_one_signatured_type, recursively_write_psymbols)
11031         (class debug_names, class debug_names, write_psymtabs_to_index):
11032         Update.
11033
11034 2019-01-10  Tom Tromey  <tom@tromey.com>
11035
11036         * symtab.h (SYMBOL_SET_NAMES): Update.
11037         (symbol_set_names): Update.
11038         (MSYMBOL_SET_NAMES): Update.
11039         * symtab.c (symbol_set_names): Change argument to be an
11040         objfile_per_bfd_storage.
11041         * psymtab.c (add_psymbol_to_bcache): Update.
11042         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11043
11044 2019-01-10  Tom Tromey  <tom@tromey.com>
11045
11046         * symtab.c (create_demangled_names_hash): Change argument to be an
11047         objfile_per_bfd_storage.
11048         (symbol_set_names): Update.
11049
11050 2019-01-10  Tom Tromey  <tom@tromey.com>
11051
11052         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11053         init_psymbol_list.
11054         * psymtab.c (init_psymbol_list): Do nothing if already called.
11055         * psympriv.h (init_psymbol_list): Add comment.
11056         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11057         init_psymbol_list.
11058         * dbxread.c (dbx_symfile_read): Unconditionally call
11059         init_psymbol_list.
11060
11061 2019-01-10  Tom Tromey  <tom@tromey.com>
11062
11063         * xcoffread.c (scan_xcoff_symtab): Update.
11064         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11065         "where".
11066         * mdebugread.c (parse_partial_symbols)
11067         (handle_psymbol_enumerators): Update.
11068         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11069         * dbxread.c (read_dbx_symtab): Update.
11070         * psympriv.h (psymbol_placement): New enum.
11071         (add_psymbol_to_list): Update.
11072
11073 2019-01-10  Tom Tromey  <tom@tromey.com>
11074
11075         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11076         static_psymbols parameters.
11077         (scan_xcoff_symtab): Update.
11078         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11079         static_psymbols parameters.
11080         * psympriv.h (start_psymtab_common): Update.
11081         * mdebugread.c (parse_partial_symbols): Update.
11082         * dwarf2read.c (create_partial_symtab): Update.
11083         * dbxread.c (read_dbx_symtab): Update.
11084         (start_psymtab): Remove global_psymbols and static_psymbols
11085         parameters.
11086
11087 2019-01-10  Tom Tromey  <tom@tromey.com>
11088
11089         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11090         * psymtab.c (allocate_psymtab): Add comment.
11091         * psympriv.h (allocate_psymtab): Add comment.
11092         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11093         initializations.
11094         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11095
11096 2019-01-10  Tom Tromey  <tom@tromey.com>
11097
11098         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11099         Don't declare.
11100         * mipsread.c: Include mdebugread.h.
11101         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11102         Declare.
11103         * elfread.c: Include mdebugread.h.
11104
11105 2019-01-09  Tom Tromey  <tom@tromey.com>
11106
11107         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11108         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11109         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11110         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11111         (psym_lookup_symbol, psym_find_last_source_symtab)
11112         (psym_forget_cached_source_info, psym_print_stats)
11113         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11114         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11115         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11116         (psym_find_compunit_symtab_by_address)
11117         (maintenance_print_psymbols, maintenance_info_psymtabs)
11118         (maintenance_check_psymtabs): Use ranged for.
11119         * psymtab.h (class objfile_psymtabs): New.
11120         (require_partial_symbols): Return objfile_psymtabs.
11121         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11122
11123 2019-01-09  Tom Tromey  <tom@tromey.com>
11124
11125         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11126         (find_pc_mapped_section, list_overlays_command)
11127         (map_overlay_command, unmap_overlay_command)
11128         (simple_overlay_update): Use all_objfiles.
11129         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11130         * printcmd.c (info_symbol_command): Use all_objfiles.
11131         * objfiles.h (ALL_OBJSECTIONS): Remove.
11132         * maint.c (maintenance_translate_address): Use all_objfiles.
11133         * gcore.c (gcore_create_callback): Use all_objfiles.
11134         (objfile_find_memory_regions): Likewise.
11135
11136 2019-01-09  Tom Tromey  <tom@tromey.com>
11137
11138         * symtab.c (find_line_symtab, info_sources_command)
11139         (make_source_files_completion_list): Use objfile_compunits.
11140         * source.c (select_source_symtab): Use objfile_compunits.
11141         * objfiles.h (struct objfile): Update comment.
11142         (ALL_OBJFILES): Remove.
11143         (ALL_FILETABS): Remove.
11144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11145         objfile_compunits.
11146
11147 2019-01-09  Tom Tromey  <tom@tromey.com>
11148
11149         * symmisc.c (print_objfile_statistics, dump_objfile)
11150         (maintenance_print_symbols): Use compunit_filetabs.
11151         * source.c (forget_cached_source_info_for_objfile): Use
11152         compunit_filetabs.
11153         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11154         (ALL_FILETABS): Use compunit_filetabs.
11155         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11156         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11157
11158 2019-01-09  Tom Tromey  <tom@tromey.com>
11159
11160         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11161         (compunit_filetabs): New.
11162         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11163         compunit_filetabs.
11164         (info_sources_command, make_source_files_completion_list): Remove
11165         declaration.
11166         * symmisc.c (print_objfile_statistics, dump_objfile)
11167         (maintenance_print_symbols): Remove declaration.
11168         (maintenance_info_symtabs): Use compunit_filetabs.
11169         (maintenance_info_line_tables): Likewise.
11170         * source.c (select_source_symtab): Change local variable name.
11171         (forget_cached_source_info_for_objfile): Remove declaration.
11172         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11173         * objfiles.c (objfile_relocate1): Remove declaration.
11174         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11175         declaration.
11176         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11177         * coffread.c (coff_symtab_read): Remove declaration.
11178         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11179         compunit_filetabs.
11180
11181 2019-01-09  Tom Tromey  <tom@tromey.com>
11182
11183         * symtab.c (lookup_objfile_from_block)
11184         (find_pc_sect_compunit_symtab, search_symbols)
11185         (default_collect_symbol_completion_matches_break_on): Use
11186         objfile_compunits.
11187         * objfiles.h (ALL_COMPUNITS): Remove.
11188         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11189         * cp-support.c (add_symbol_overload_list_qualified): Use
11190         objfile_compunits.
11191         * ada-lang.c (ada_collect_symbol_completion_matches)
11192         (ada_add_global_exceptions): Use objfile_compunits.
11193
11194 2019-01-09  Tom Tromey  <tom@tromey.com>
11195
11196         * source.c (select_source_symtab)
11197         (forget_cached_source_info_for_objfile): Remove declaration.
11198         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11199         declaration.
11200         * maint.c (count_symtabs_and_blocks): Remove declaration.
11201         * cp-support.c (add_symbol_overload_list_qualified): Remove
11202         declaration.
11203         * coffread.c (coff_symtab_read): Remove declaration.
11204         * symtab.c (lookup_symbol_in_objfile_symtabs)
11205         (basic_lookup_transparent_type_1): Use objfile_compunits.
11206         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11207         (info_sources_command, search_symbols)
11208         (default_collect_symbol_completion_matches_break_on)
11209         (make_source_files_completion_list): Remove declaration.
11210         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11211         (ada_collect_symbol_completion_matches)
11212         (ada_add_global_exceptions): Remove declaration.
11213         * linespec.c (iterate_over_all_matching_symtabs): Use
11214         objfile_compunits.
11215         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11216         (class objfile_compunits): New.
11217         (ALL_COMPUNITS): Use objfile_compunits.
11218         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11219         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11220         objfile_compunits.
11221         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11222
11223 2019-01-09  Tom Tromey  <tom@tromey.com>
11224
11225         * symtab.c (search_symbols)
11226         (default_collect_symbol_completion_matches_break_on): Use
11227         objfile_msymbols.
11228         * ada-lang.c (ada_lookup_simple_minsym)
11229         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11230         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11231         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11232         objfile_msymbols.
11233         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11234         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11235         * objc-lang.c (find_methods): Use objfile_msymbols.
11236         (info_selectors_command, info_classes_command): Likewise.
11237         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11238         * objfiles.h (class objfile_msymbols): New.
11239         (ALL_OBJFILE_MSYMBOLS): Remove.
11240         (ALL_MSYMBOLS): Remove.
11241
11242 2019-01-09  Tom Tromey  <tom@tromey.com>
11243
11244         * common/next-iterator.h (next_adapter): Add Iterator template
11245         parameter.
11246         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11247         (class all_objfiles_safe): New.
11248         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11249         * objfiles.c (put_objfile_before): Update comment.
11250         (add_separate_debug_objfile): Likewise.
11251         (free_all_objfiles): Use all_objfiles_safe.
11252         (objfile_purge_solibs): Likewise.
11253
11254 2019-01-09  Tom Tromey  <tom@tromey.com>
11255
11256         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11257         (expand_symtab_containing_pc, lookup_static_symbol)
11258         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11259         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11260         all_objfiles.
11261         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11262         * breakpoint.c (create_overlay_event_breakpoint)
11263         (create_longjmp_master_breakpoint)
11264         (create_std_terminate_master_breakpoint)
11265         (create_exception_master_breakpoint): Use all_objfiles.
11266         * linux-thread-db.c (try_thread_db_load_from_pdir)
11267         (has_libpthread): Use all_objfiles.
11268         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11269         * linespec.c (iterate_over_all_matching_symtabs)
11270         (search_minsyms_for_name): Use all_objfiles.
11271         * maint.c (maintenance_info_sections): Use all_objfiles.
11272         * main.c (captured_main_1): Use all_objfiles.
11273         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11274         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11275         * guile/scm-pretty-print.c
11276         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11277         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11278         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11279         (maintenance_print_msymbols): Use all_objfiles.
11280         * source.c (select_source_symtab): Use all_objfiles.
11281         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11282         * symfile.c (remove_symbol_file_command)
11283         (expand_symtabs_matching, map_symbol_filenames): Use
11284         all_objfiles.
11285         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11286         all_objfiles.
11287         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11288         * objc-lang.c (find_methods): Use all_objfiles.
11289         * objfiles.c (have_partial_symbols, have_full_symbols)
11290         (have_minimal_symbols, qsort_cmp)
11291         (default_iterate_over_objfiles_in_search_order): Use
11292         all_objfiles.
11293         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11294         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11295         (maintenance_check_psymtabs): Use all_objfiles.
11296         (ALL_PSYMTABS): Remove.
11297         * compile/compile-object-run.c (do_module_cleanup): Use
11298         all_objfiles.
11299         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11300         * cp-support.c (add_symbol_overload_list_qualified): Use
11301         all_objfiles.
11302         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11303         Use all_objfiles.
11304         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11305         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11306         all_objfiles.
11307         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11308         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11309         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11310         Uses all_objfiles.
11311         * solib.c (solib_read_symbols): Use all_objfiles
11312
11313 2019-01-09  Tom Tromey  <tom@tromey.com>
11314
11315         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11316         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11317         all_objfiles.
11318         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11319         * symmisc.c (print_symbol_bcache_statistics)
11320         (print_objfile_statistics, maintenance_print_objfiles)
11321         (maintenance_info_symtabs, maintenance_check_symtabs)
11322         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11323         all_objfiles.
11324         * source.c (forget_cached_source_info): Use all_objfiles.
11325         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11326         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11327         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11328         * objfiles.c (update_section_map): Use all_objfiles.
11329         (shared_objfile_contains_address_p): Likewise.
11330         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11331         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11332
11333 2019-01-09  Tom Tromey  <tom@tromey.com>
11334
11335         * common/next-iterator.h: New file.
11336         * objfiles.h (class all_objfiles): New.
11337         (struct objfile_iterator): New.
11338
11339 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11340
11341         * NEWS: Move the description of the changed "frame", "select-frame",
11342          and "info frame" commands to the Changed commands section.
11343
11344 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11345
11346         * gdbtypes.c (check_stub_method_group): Remove handling of old
11347         mangling schemes.
11348         * linespec.c (find_methods): Likewise.
11349         * stabsread.c (read_member_functions): Likewise.
11350         * valops.c (search_struct_method): Likewise.
11351         (value_struct_elt_for_reference): Likewise.
11352         * NEWS: Mention this change.
11353
11354 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11357         print_source_lines.
11358         * source.c (print_source_lines_base): Update line number check.
11359         (print_source_lines): New function.
11360         (source_lines_range::source_lines_range): New function.
11361         * source.h (class source_lines_range): New class.
11362         (print_source_lines): New declaration.
11363
11364 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11365
11366         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11367
11368 2019-01-08  Tom Tromey  <tom@tromey.com>
11369             Simon Marchi  <simon.marchi@ericsson.com>
11370
11371         PR gdb/24060
11372         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11373         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11374         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11375         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11376         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11377         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11378
11379 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11380
11381         * source.c (select_source_symtab): Move header comment to
11382         declaration in source.h.
11383         (forget_cached_source_info_for_objfile): Likewise.
11384         (forget_cached_source_info): Likewise.
11385         (identify_source_line): Likewise.
11386         * source.h (identify_source_line): Move declaration from symtab.h
11387         and add comment from source.c
11388         (print_source_lines): Likewise.
11389         (forget_cached_source_info_for_objfile): Likewise.
11390         (forget_cached_source_info): Likewise.
11391         (select_source_symtab): Likewise.
11392         (enum print_source_lines_flag): Move definition from symtab.h.
11393         * symtab.h (identify_source_line): Move declaration to source.h.
11394         (print_source_lines): Likewise.
11395         (forget_cached_source_info_for_objfile): Likewise.
11396         (forget_cached_source_info): Likewise.
11397         (select_source_symtab): Likewise.
11398         (enum print_source_lines_flag): Move definition to source.h.
11399         * tui/tui-hooks.c: Add 'source.h' include.
11400
11401 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11402
11403         * source.c (print_source_lines_base): Handle requests to print
11404         reverse line number sequences, and guard against empty lines
11405         string.
11406
11407 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11408
11409         * source.c (print_source_lines_base): Fix skip of '\r' if next
11410         character is '\n'.
11411
11412 2019-01-06  Tom Tromey  <tom@tromey.com>
11413
11414         * c-exp.y (struct c_parse_state) <macro_original_text,
11415         expansion_obstack>: New member.
11416         (macro_original_text, expansion_obstack): Remove globals.
11417         (scan_macro_expansion, scanning_macro_expansion)
11418         (finished_macro_expansion): Update.
11419         (scan_macro_cleanup): Remove.
11420         (yylex, c_parse): Update.
11421
11422 2019-01-06  Tom Tromey  <tom@tromey.com>
11423
11424         * c-exp.y (struct c_parse_state) <strings>: New member.
11425         (operator_stoken): Update.
11426
11427 2019-01-06  Tom Tromey  <tom@tromey.com>
11428
11429         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11430         (union type_stack_elt) <typelist_val>: Now a pointer to
11431         std::vector.
11432         (type_stack_cleanup): Don't declare.
11433         (push_typelist): Update.
11434         * parse.c (pop_typelist): Return a std::vector.
11435         (push_typelist): Take a std::vector.
11436         (follow_types): Update.  Do not free args.
11437         (type_stack_cleanup): Remove.
11438         * c-exp.y (struct c_parse_state): New.
11439         (cpstate): New global.
11440         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11441         (nonempty_typelist): Update.
11442         (func_mod): Create a new vector.
11443         (c_parse): Create a c_parse_state.
11444         (check_parameter_typelist): Do not delete params.
11445         (function_method): Update.  Do not delete type_list.
11446
11447 2019-01-06  Tom Tromey  <tom@tromey.com>
11448
11449         PR gdb/28155:
11450         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11451         check_typedef.
11452         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11453         (print_return_value): Likewise.
11454
11455 2019-01-05  Tom Tromey  <tom@tromey.com>
11456
11457         * contrib/cleanup_check.py: Remove.
11458         * contrib/gcc-with-excheck: Remove.
11459         * contrib/exsummary.py: Remove.
11460         * contrib/excheck.py: Remove.
11461
11462 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11463
11464         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11465         NULL. Initialize tpprev to NULL instead of assigning it
11466         to NULL on the next statement.
11467         * windows-nat.c (windows_delete_thread): Remove check for
11468         main_thread_id before printing thread exit notifications.
11469         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11470         Remove thread ID check against main_thread_id.
11471         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11472         windows_delete_thread.
11473         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11474
11475 2019-01-04  Tom Tromey  <tom@tromey.com>
11476
11477         * compile/compile.c (_initialize_compile): Use upper case for
11478         metasyntactic variables.
11479         * symmisc.c (_initialize_symmisc): Use upper case for
11480         metasyntactic variables.
11481         * psymtab.c (_initialize_psymtab): Use upper case for
11482         metasyntactic variables.
11483         * demangle.c (demangle_command): Use upper case for metasyntactic
11484         variables.
11485         (_initialize_demangler): Likewise.
11486         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11487         variables.
11488
11489 2019-01-03  Tom Tromey  <tom@tromey.com>
11490
11491         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11492
11493 2019-01-03  Tom Tromey  <tom@tromey.com>
11494
11495         * python/py-symtab.c (salpy_str): Update.
11496         (struct salpy_sal_object) <symtab>: Now a PyObject.
11497         (salpy_dealloc): Update.
11498         (del_objfile_sal): Use gdbpy_ref.
11499
11500 2019-01-03  Tom Tromey  <tom@tromey.com>
11501
11502         * python/py-type.c (convert_field): Use new_reference.  Return
11503         gdbpy_ref.
11504         (make_fielditem): Return gdbpy_ref.
11505         (typy_fields): Update.
11506         (typy_getitem): Update.
11507         (field_name): Return gdbpy_ref.  Use new_reference.
11508         (typy_iterator_iternext): Update.
11509
11510 2019-01-03  Tom Tromey  <tom@tromey.com>
11511
11512         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11513
11514 2019-01-03  Tom Tromey  <tom@tromey.com>
11515
11516         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11517         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11518         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11519         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11520         (pspy_set_type_printers): Likewise.
11521         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11522         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11523         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11524         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11525         (objfpy_set_type_printers): Likewise.
11526
11527 2019-01-03  Tom Tromey  <tom@tromey.com>
11528
11529         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11530         (gdbpy_print_stack): Use gdbpy_err_fetch.
11531         * python/python-internal.h (class gdbpy_err_fetch): New class.
11532         (class gdbpy_enter) <m_error_type, m_error_value,
11533         m_error_traceback>: Remove.
11534         <m_error>: New member.
11535         (gdbpy_exception_to_string): Don't declare.
11536         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11537         * python/py-value.c (convert_value_from_python): Use
11538         gdbpy_err_fetch.
11539         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11540         gdbpy_exception_to_string.
11541         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11542         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11543         gdbpy_err_fetch.
11544
11545 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11546
11547         * linux-nat.c (delete_lwp_cleanup): Delete.
11548         (struct lwp_deleter): New struct.
11549         (lwp_info_up): New typedef.
11550         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11551         lwp_info_up.
11552
11553 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11554
11555         * linux-fork.c (class scoped_switch_fork_info): New class.
11556         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11557
11558 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * valops.c (find_overload_match): Remove use of null_cleanup, and
11561         calls to do_cleanups.
11562
11563 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11564
11565         * compile/compile-cplus-types.c
11566         (compile_cplus_instance::decl_name): Handle changes to
11567         cp_func_name.
11568         * cp-support.c (cp_func_name): Update header comment, update
11569         return type.
11570         * cp-support.h (cp_func_name): Update return type in declaration.
11571         * valops.c (find_overload_match): Move temp_func local to top
11572         level of function and change its type.  Use temp_func to hold and
11573         delete temporary string obtained from cp_func_name.
11574
11575 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11576
11577         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11578         gdb::char_vector, remove cleanup, and update uses of `msg`.
11579
11580 2019-01-03  Jim Wilson  <jimw@sifive.com>
11581
11582         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11583
11584 2019-01-02  Tom Tromey  <tom@tromey.com>
11585
11586         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11587         (tdesc_parse_xml): Remove cleanups.
11588         * target-descriptions.h (make_cleanup_free_target_description):
11589         Don't declare.
11590         (target_desc_deleter): New struct.
11591         (target_desc_up): New typedef.
11592         * target-descriptions.c (target_desc_deleter::operator()): Rename
11593         from free_target_description.
11594         (make_cleanup_free_target_description): Remove.
11595
11596 2019-01-02  Tom Tromey  <tom@tromey.com>
11597
11598         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11599         constructor, destructor.
11600         (linespec_parser): Remove typedef.
11601         (~linespec_parser): Rename from linespec_parser_delete.
11602         (linespec_lex_to_end, linespec_complete_label)
11603         (linespec_complete): Update.
11604         (decode_line_full): Remove cleanups.
11605         (decode_line_1): Update.
11606
11607 2019-01-02  Tom Tromey  <tom@tromey.com>
11608
11609         * python/python-internal.h (inferior_to_inferior_object): Change
11610         return type.
11611         * python/py-exitedevent.c (create_exited_event_object): Update.
11612         * python/py-inferior.c (inferior_to_inferior_object): Return
11613         gdbpy_ref.
11614         (python_new_inferior, python_inferior_deleted)
11615         (thread_to_thread_object, delete_thread_object)
11616         (build_inferior_list, gdbpy_selected_inferior): Update.
11617         * python/py-infthread.c (create_thread_object): Update.  Also fail
11618         if inferior_to_inferior_object fails.
11619
11620 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11621
11622         * inferior.h (class inferior) <displaced_step_state>: New field.
11623         * infrun.h (struct displaced_step_state): Move here from
11624         infrun.c.  Initialize fields, add constructor.
11625         <inf>: Remove field.
11626         <reset>: New method.
11627         * infrun.c (struct displaced_step_inferior_state): Move to
11628         infrun.h.
11629         (displaced_step_inferior_states): Remove.
11630         (get_displaced_stepping_state): Adust.
11631         (displaced_step_in_progress_any_inferior): Adjust.
11632         (displaced_step_in_progress_thread): Adjust.
11633         (displaced_step_in_progress): Adjust.
11634         (add_displaced_stepping_state): Remove.
11635         (get_displaced_step_closure_by_addr): Adjust.
11636         (remove_displaced_stepping_state): Remove.
11637         (infrun_inferior_exit): Call displaced_step_state.reset.
11638         (use_displaced_stepping): Don't check for NULL.
11639         (displaced_step_prepare_throw): Call
11640         get_displaced_stepping_state.
11641         (displaced_step_fixup): Don't check for NULL.
11642         (prepare_for_detach): Don't check for NULL.
11643
11644 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11645
11646         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11647          in case of call that did not complete.
11648
11649 2019-01-02  Andrey Utkin  <autkin@undo.io>
11650
11651         * symfile.c (find_separate_debug_file): Fix search of debug files for
11652         remote debuggee.
11653
11654 2019-01-02  Tom Tromey  <tom@tromey.com>
11655
11656         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11657         indentation.
11658         * python/py-frame.c (frapy_older): Remove cast.
11659         (frapy_newer): Likewise.
11660         * python/py-breakpoint.c (local_setattro): Remove cast.
11661         * python/py-arch.c (archpy_name): Remove local variable.
11662         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11663
11664 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11665
11666         * unittests/basic_string_view/element_access/char/empty.cc:
11667         Fix year range in copyright header.
11668
11669 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11670
11671         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11672         Delete.
11673         <operator==>: Update with for removed field.
11674         <hash>: Likewise.
11675         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11676         <isa_features>: ...this.
11677         <abi_features>: New field.
11678         (riscv_isa_flen): Update comment.
11679         (riscv_abi_xlen): New declaration.
11680         (riscv_abi_flen): New declaration.
11681         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11682         isa_features.
11683         (riscv_abi_xlen): New function.
11684         (riscv_isa_flen): Update to get answer from isa_features.
11685         (riscv_abi_flen): New function.
11686         (riscv_has_fp_abi): Update to get answer from abi_features.
11687         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11688         xlen and flen.
11689         (riscv_call_info) <xlen, flen>: Update comment.
11690         (riscv_call_arg_struct): Remove invalid assertions
11691         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11692         is removed.
11693         (riscv_gdbarch_init): Gather isa features and abi features
11694         separately, ensure both match on the gdbarch when reusing an old
11695         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11696         a target with 64-bit float hardware.
11697
11698 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11699
11700         * source.c (search_command_helper): Stop reverse search
11701         when line 1 has been searched.
11702
11703 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11704
11705         * record-full.c (record_full_base_target::close): Rewrite
11706         record_full_core_buf_list free logic.
11707
11708 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11709
11710         * break-catch-syscall.c (print_one_catch_syscall): xfree
11711         the last text.
11712
11713 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11714
11715         * top.c (print_gdb_version): Update Copyright year in version
11716         message.
11717
11718 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11719
11720         Update copyright year range in all GDB files.
11721
11722 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11723
11724         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11725
11726 For older changes see ChangeLog-2018.
11727 \f
11728 Local Variables:
11729 mode: change-log
11730 left-margin: 8
11731 fill-column: 74
11732 version-control: never
11733 coding: utf-8
11734 End:
11735