gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
   4         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
   5         constructor.
   6         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
   7         * tui/tui-source.c (tui_set_source_content): Update.
   8         * tui/tui-disasm.c (tui_set_disassem_content): Update.
   9
  10 2019-08-15  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
  13         * tui/tui-winsource.c (tui_line_is_displayed): Move to
  14         tui-source.c.
  15         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
  16         Declare.
  17         * tui/tui-source.c (tui_source_window::line_is_displayed): New
  18         method.
  19         (tui_source_window::maybe_update): Update.
  20
  21 2019-08-15  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
  24         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
  25         tui-disasm.c.
  26         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
  27         Declare.
  28         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
  29         method.
  30         (tui_disasm_window::maybe_update): Update.
  31
  32 2019-08-15  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-winsource.h (struct tui_source_window_base)
  35         <maybe_update>: Declare.
  36         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
  37         method.
  38         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  39         Declare.
  40         * tui/tui-source.c (tui_source_window::maybe_update): New method.
  41         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  42         Declare.
  43         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
  44
  45 2019-08-15  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
  48
  49 2019-08-15  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-wingeneral.c: Include tui-stack.h.
  52         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
  53         (struct tui_locator_window): Move from tui-data.h.
  54         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
  55         (tui_initialize_static_data): Move from tui-data.c.
  56         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
  57         (struct tui_locator_window): Move to tui-stack.c.
  58         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  59         (tui_initialize_static_data): Move to tui-stack.c.
  60
  61 2019-08-15  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-layout.c (show_source_disasm_command)
  64         (show_source_or_disasm_and_command): Use make_visible method, not
  65         tui_make_window.
  66         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
  67         Remove.
  68
  69 2019-08-15  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-wingeneral.h (tui_make_window): Update.
  72         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
  73         parameter.
  74         (tui_gen_win_info::make_visible): Update.
  75         * tui/tui-regs.c (tui_data_window::display_registers_from):
  76         Update.
  77         * tui/tui-layout.c (show_source_disasm_command)
  78         (show_source_or_disasm_and_command): Update.
  79         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  80         (enum tui_box): Remove.
  81         (struct tui_win_info) <can_box>: New method.
  82         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
  83         method.
  84
  85 2019-08-15  Tom de Vries  <tdevries@suse.de>
  86
  87         * linux-nat-trad.c: Include gdbarch.h.
  88
  89 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
  90
  91         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
  92         register sizes.
  93
  94 2019-08-14  Tom Tromey  <tromey@adacore.com>
  95
  96         * darwin-nat.c: Include gdbarch.h.
  97         * darwin-nat-info.c: Include gdbarch.h.
  98
  99 2019-08-13  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 102         Remove.
 103         * tui/tui-data.c (tui_initialize_static_data): Update.
 104
 105 2019-08-13  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-winsource.h (struct tui_exec_info_window)
 108         <~tui_exec_info_window, maybe_allocate_content, get_content,
 109         m_content>: Remove.
 110         (struct tui_source_window_base) <set_exec_info_content,
 111         show_exec_info_content>: Don't declare.
 112         * tui/tui-winsource.c
 113         (tui_exec_info_window::maybe_allocate_content): Remove.
 114         (tui_source_window_base::update_exec_info): Rename from
 115         set_exec_info_content.
 116         (tui_source_window_base::show_exec_info_content)
 117         (tui_source_window_base::update_exec_info): Remove.
 118
 119 2019-08-13  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 122         declare.
 123         * tui/tui-winsource.c (tui_update_source_window_as_is)
 124         (tui_update_source_windows_with_addr, tui_erase_source_content):
 125         Update.
 126         (tui_clear_exec_info_content): Remove.
 127
 128 2019-08-13  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 131         declare.
 132         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 133         call tui_erase_exec_info_content.
 134         (tui_clear_exec_info_content): Rename from
 135         tui_erase_exec_info_content.
 136         (tui_clear_exec_info_content): Delete.
 137
 138 2019-08-13  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-winsource.h (struct tui_source_window_base)
 141         <show_exec_info_content>: Declare.
 142         (tui_show_exec_info_content): Don't declare.
 143         * tui/tui-winsource.c
 144         (tui_source_window_base::show_exec_info_content): Rename from
 145         tui_show_exec_info_content.
 146         (tui_source_window_base::update_exec_info): Update.
 147
 148 2019-08-13  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 151         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 152         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 153         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 154         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 155         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 156         ... here.
 157
 158 2019-08-13  Tom Tromey  <tom@tromey.com>
 159
 160         * tui/tui-winsource.h (struct tui_source_window_base)
 161         <update_exec_info>: Declare.
 162         (tui_update_exec_info): Don't declare.
 163         * tui/tui-winsource.c (tui_update_source_window_as_is)
 164         (tui_source_window_base::refresh_all)
 165         (tui_update_all_breakpoint_info): Update.
 166         (tui_source_window_base::update_exec_info): Rename from
 167         tui_update_exec_info.
 168         * tui/tui-stack.c (tui_show_frame_info): Update.
 169
 170 2019-08-13  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-winsource.h (struct tui_source_window_base)
 173         <set_exec_info_content>: Declare.
 174         (tui_set_exec_info_content): Don't declare.
 175         * tui/tui-winsource.c
 176         (tui_source_window_base::set_exec_info_content): Rename from
 177         tui_set_exec_info_content.
 178         (tui_update_exec_info): Update.
 179
 180 2019-08-13  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-winsource.h (struct tui_source_window_base)
 183         <show_source_content>: Declare.
 184         (tui_show_source_content): Don't declare.
 185         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 186         (tui_source_window_base::show_source_content): Rename from
 187         tui_show_source_content.
 188         (tui_source_window_base::refresh_all): Update.
 189         * tui/tui-layout.c (show_source_disasm_command)
 190         (show_source_or_disasm_and_command): Update.
 191
 192 2019-08-13  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-winsource.c (tui_erase_source_content)
 195         (tui_show_source_content, tui_source_window_base::refresh_all):
 196         Update.
 197         * tui/tui-wingeneral.h
 198         (tui_check_and_display_highlight_if_needed): Don't declare.
 199         * tui/tui-wingeneral.c
 200         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 201         check_and_display_highlight_if_needed.
 202         * tui/tui-win.c (tui_rehighlight_all)
 203         (tui_win_info::make_visible_with_new_height): Update.
 204         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 205         (tui_data_window::erase_data_content)
 206         (tui_data_window::display_all_data): Update.
 207         * tui/tui-data.h (struct tui_win_info)
 208         <check_and_display_highlight_if_needed>: Declare.
 209
 210 2019-08-13  Tom Tromey  <tom@tromey.com>
 211
 212         * tui/tui-win.c (tui_resize_all): Call
 213         tui_delete_invisible_windows.
 214         * tui/tui-layout.c (show_layout): Call
 215         tui_delete_invisible_windows.
 216         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 217         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 218
 219 2019-08-13  Tom Tromey  <tom@tromey.com>
 220
 221         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 222         tui_add_win_to_layout.
 223
 224 2019-08-13  Tom Tromey  <tom@tromey.com>
 225
 226         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 227         * tui/tui-layout.c (tui_default_win_height): Now static.
 228
 229 2019-08-13  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 232         single switch.
 233         (show_source_disasm_command, show_source_or_disasm_and_command):
 234         Don't check current layout.
 235
 236 2019-08-13  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-wingeneral.c (make_all_visible): Remove.
 239         (tui_make_all_invisible): Simplify.
 240         * tui/tui-layout.c (tui_make_all_invisible): Move from
 241         tui-wingeneral.c; simplify.
 242         (show_layout): Hoist call to tui_make_all_invisible.
 243         (show_data): Don't call tui_make_all_invisible.
 244
 245 2019-08-13  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 248         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 249
 250 2019-08-13  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 253         tui-data.c.
 254         (show_source_disasm_command, show_data)
 255         (show_source_or_disasm_and_command): Don't use
 256         tui_set_current_layout_to.
 257         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 258         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 259         tui-layout.c.
 260         (tui_set_current_layout_to): Remove.
 261
 262 2019-08-13  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-layout.c (tui_set_layout): Update.
 265         * tui/tui-data.h (struct tui_layout_def): Remove.
 266         (tui_layout_def): Don't declare.
 267         * tui/tui-data.c (layout_def): Remove.
 268         (tui_layout_def): Remove.
 269
 270 2019-08-13  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-winsource.h (struct tui_source_window_base)
 273         <clear_detail>: No longer "override".
 274         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 275         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 276         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 277         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 278         Remove.
 279         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 280
 281 2019-08-13  Tom Tromey  <tromey@adacore.com>
 282
 283         * tracepoint.c: Don't include readline.h or history.h.
 284
 285 2019-08-12  Tom Tromey  <tom@tromey.com>
 286
 287         * configure: Rebuild.
 288         * configure.ac: Check for readline 7.
 289         * NEWS: Mention readline 7 requirement.
 290         * README: Update.
 291
 292 2019-08-12  Tom Tromey  <tom@tromey.com>
 293
 294         * mingw-hdep.c (gdb_select): Remove readline hack.
 295
 296 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 297
 298         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 299         when the function fails.
 300
 301 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 302
 303         * s390-tdep.c (s390_type_align): New function.
 304         (s390_gdbarch_init): Set it as type_align gdbarch method.
 305
 306 2019-08-09  Tom de Vries  <tdevries@suse.de>
 307
 308         PR gdb/24591
 309         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 310         pc_low with relocation offset.
 311
 312 2019-08-07  Tom Tromey  <tromey@adacore.com>
 313
 314         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 315         (print_frame_args): Update.
 316         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 317         Update.
 318         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 319         * frame.h (struct frame_arg): Add initializers.
 320         <error>: Now a unique_xmalloc_ptr.
 321
 322 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 323
 324         * NEWS: Expand the Pointer Authentication entry.
 325         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 326         (aarch64_frame_unmask_lr): ... to this.
 327         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 328         Call aarch64_frame_unmask_lr.
 329         * frame.c (struct frame_info): Add "masked" variable.
 330         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 331         (fprint_frame): Check for masked pc.
 332         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 333         declarations.
 334         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 335         * stack.c (print_frame): Check for masked pc.
 336
 337 2019-08-06  Tom Tromey  <tom@tromey.com>
 338
 339         * stabsread.c (patch_block_stabs, read_one_struct_field)
 340         (read_enum_type): Use obstack_strndup.
 341         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 342         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 343         * dwarf2read.c (guess_full_die_structure_name)
 344         (anonymous_struct_prefix): Use obstack_strndup.
 345         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 346         * c-exp.y (yylex): Use obstack_strndup.
 347         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 348         (write_var_or_type): Use obstack_strndup.
 349
 350 2019-08-06  Tom Tromey  <tom@tromey.com>
 351
 352         * symfile.c (reread_symbols): Use obstack_strdup.
 353         * stabsread.c (read_type): Use obstack_strdup.
 354         * gdb_obstack.h (obstack_strdup): New overload.
 355         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 356         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 357         (dwarf2_canonicalize_name): Use obstack_strdup.
 358         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 359         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 360         Use obstack_strdup.
 361
 362 2019-08-06  Tom Tromey  <tom@tromey.com>
 363
 364         * gdb_obstack.h (obstack_strdup): Define.
 365         * gdb_obstack.c (obstack_strdup): Don't define.
 366
 367 2019-08-06  Tom Tromey  <tom@tromey.com>
 368
 369         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 370         obstack_strdup.
 371         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 372         obstack_strdup.
 373         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 374         * stabsread.c (common_block_start): Use obstack_strdup.
 375         * objfiles.c (set_objfile_main_name, objfile): Use
 376         obstack_strdup.
 377         * namespace.c (add_using_directive): Use obstack_strdup.
 378         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 379         * jit.c (finalize_symtab): Use obstack_strdup.
 380         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 381         (guess_partial_die_structure_name, partial_die_info::fixup)
 382         (dwarf2_name): Use obstack_strdup.
 383         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 384         obstack_strdup.
 385         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 386         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 387         obstack_strdup.
 388         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 389
 390 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 391
 392         * unittests/help-doc-selftests.c: New file.
 393         * Makefile.in: Add the new file.
 394
 395 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 396
 397         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 398         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 399         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 400         the trailing '.' is not output, and the first character is uppercased.
 401         (print_help_for_command): Update call to print_doc_line.
 402         (print_doc_of_command): Likewise.
 403         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 404         * cli/cli-option.c (append_indented_doc): Do not append newline.
 405         (build_help_option): Append newline after first appended_indented_doc
 406         only if a second call is done.
 407         (build_help): Append 2 new lines before each option, except the first
 408         one.
 409         * compile/compile.c (_initialize_compile): Add new lines after
 410         %OPTIONS%, when not at the end of the help.
 411         Change help doc or code
 412         producing the help doc to respect the invariants.
 413         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 414         Also removed the new line after 'Options:', as all other commands
 415         do not put an empty line between 'Options:' and the first option.
 416         * printcmd.c (_initialize_printcmd): Likewise.
 417         * stack.c (_initialize_stack): Likewise.
 418         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 419         incorrectly telling COMMAND is optional.
 420         * ada-lang.c (_initialize_ada_language): Change help doc or code
 421         producing the help doc to respect the invariants.
 422         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 423         * breakpoint.c (_initialize_breakpoint): Likewise.
 424         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 425         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 426         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 427         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 428         _initialize_cli_style): Likewise.
 429         * corelow.c (core_target_info): Likewise.
 430         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 431         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 432         * filesystem.c (_initialize_filesystem): Likewise.
 433         * frame.c (_initialize_frame): Likewise.
 434         * gnu-nat.c (add_task_commands): Likewise.
 435         * infcall.c (_initialize_infcall): Likewise.
 436         * infcmd.c (_initialize_infcmd): Likewise.
 437         * interps.c (_initialize_interpreter): Likewise.
 438         * language.c (_initialize_language): Likewise.
 439         * linux-fork.c (_initialize_linux_fork): Likewise.
 440         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 441         * maint.c (_initialize_maint_cmds): Likewise.
 442         * memattr.c (_initialize_mem): Likewise.
 443         * printcmd.c (_initialize_printcmd): Likewise.
 444         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 445         _RegEx): Likewise.
 446         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 447         * record-btrace.c (_initialize_record_btrace): Likewise.
 448         * record-full.c (_initialize_record_full): Likewise.
 449         * record.c (_initialize_record): Likewise.
 450         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 451         * regcache.c (_initialize_regcache): Likewise.
 452         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 453         _initialize_remote): Likewise.
 454         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 455         * serial.c (_initialize_serial): Likewise.
 456         * skip.c (_initialize_step_skip): Likewise.
 457         * source.c (_initialize_source): Likewise.
 458         * stack.c (_initialize_stack): Likewise.
 459         * symfile.c (_initialize_symfile): Likewise.
 460         * symtab.c (_initialize_symtab): Likewise.
 461         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 462         * top.c (init_main): Likewise.
 463         * tracefile-tfile.c (tfile_target_info): Likewise.
 464         * tracepoint.c (_initialize_tracepoint): Likewise.
 465         * tui/tui-win.c (_initialize_tui_win): Likewise.
 466         * utils.c (add_internal_problem_command): Likewise.
 467         * valprint.c (value_print_option_defs): Likewise.
 468
 469 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 470
 471         PR build/24886
 472         * configure.ac: Drop enable-libmcheck support.
 473         * configure, config.in: Rebuild.
 474         * libmcheck.m4: Remove.
 475         * acinclude.m4: Don't include it.
 476         * Makefile.in: Don't distribute it.
 477         * top.c (print_gdb_configuration): Don't mention it.
 478
 479 2019-08-06  Tom Tromey  <tom@tromey.com>
 480
 481         * utils.c (set_output_style): Sometimes pass stream to
 482         emit_style_escape.
 483         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 484         * record-btrace.c (btrace_insn_history): Update.
 485         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 486         method.
 487         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 488         Update initializers.
 489         <m_uiout>: New field.
 490         <m_di>: Move lower.
 491         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 492         Remove "uiout" parameter.
 493         (dump_insns): Update.
 494         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 495         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 496
 497 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 498
 499         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 500         (error_in_psymtab_expansion): Likewise.
 501         (lookup_symbol_via_quick_fns): Likewise.
 502         (basic_lookup_transparent_type_quick): Likewise.
 503         (basic_lookup_transparent_type_1): Likewise.
 504
 505 2019-08-06  Tom Tromey  <tromey@adacore.com>
 506
 507         * source.c (last_source_error): Now bool.
 508         (print_source_lines_base): Make "noprint" bool.  Only open
 509         source file when last_source_visited changes.
 510
 511 2019-08-06  Tom Tromey  <tromey@adacore.com>
 512
 513         * annotate.c (annotate_source_line): Use g_source_cache.
 514         * source-cache.c (source_cache::get_plain_source_lines): Change
 515         parameters.  Populate m_offset_cache.
 516         (source_cache::ensure): New method.
 517         (source_cache::get_line_charpos): New method.
 518         (extract_lines): Move lower.  Change parameters.
 519         (source_cache::get_source_lines): Move lower.
 520         * source-cache.h (class source_cache): Update comment.
 521         <get_line_charpos>: New method.
 522         <get_source_lines>: Update comment.
 523         <clear>: Clear m_offset_cache.
 524         <get_plain_source_lines>: Change parameters.
 525         <ensure>: New method
 526         <m_offset_cache>: New member.
 527         * source.c (forget_cached_source_info_for_objfile): Update.
 528         (info_source_command): Use g_source_cache.
 529         (find_source_lines, open_source_file_with_line_charpos): Remove.
 530         (print_source_lines_base, search_command_helper): Use g_source_cache.
 531         * source.h (open_source_file_with_line_charpos): Don't declare.
 532         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 533         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 534         Use g_source_cache.
 535
 536 2019-08-06  Tom Tromey  <tromey@adacore.com>
 537
 538         * source-cache.c (source_cache::get_plain_source_lines):
 539         Remove "first_line" and "last_line" parameters.
 540         (source_cache::get_source_lines): Cache plain text.
 541         * source-cache.h (class source_cache)
 542         <get_plain_source_lines>: Update.
 543
 544 2019-08-06  Tom Tromey  <tromey@adacore.com>
 545
 546         * source-cache.c (extract_lines): No longer a method.
 547         Changed type of parameter.  Include final newline.
 548         (selftests::extract_lines_test): New function.
 549         (_initialize_source_cache): Likewise.
 550         * source-cache.h (class source_cache)
 551         <extract_lines>: Don't declare.
 552
 553 2019-08-06  Tom Tromey  <tromey@adacore.com>
 554
 555         * breakpoint.c (init_breakpoint_sal): Update.
 556         (breakpoint): Update.
 557         * breakpoint.h (struct breakpoint) <filter>: Now a
 558         unique_xmalloc_ptr.
 559
 560 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 561
 562         * NEWS: Mention dictionary access on blocks.
 563         * python/py-block.c (blpy_getitem): New function.
 564         (block_object_as_mapping): New struct.
 565         (block_object_type): Use new struct for tp_as_mapping field.
 566
 567 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 568
 569         * objfiles.h (objfile): Add a comment describing partial symbols.
 570
 571 2019-08-05  Tom Tromey  <tromey@adacore.com>
 572
 573         * compile/compile.c (_initialize_compile): Use _(), not N_().
 574         * thread.c (_initialize_thread): Use _(), not N_().
 575         * stack.c (_initialize_stack): Use _(), not N_().
 576         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 577
 578 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 579
 580         * dwarf2read.c (struct dw2_symtab_iterator):
 581         <want_specific_block>: Remove.
 582         <block_index>: Change type to gdb::optional.
 583         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 584         change type of BLOCK_INDEX parameter to gdb::optional.
 585         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 586         (dw2_lookup_symbol): Don't pass argument for
 587         WANT_SPECIFIC_BLOCK.
 588         (dw2_expand_symtabs_for_function): Don't pass argument for
 589         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 590         (class dw2_debug_names_iterator)
 591         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 592         parameter, change BLOCK_INDEX type to gdb::optional.
 593         <m_want_specific_block>: Remove.
 594         <m_block_index>: Change type to gdb::optional.
 595         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 596         gdb::optional.  Re-write in function of gdb::optional.
 597         (dw2_debug_names_lookup_symbol): Don't pass argument for
 598         WANT_SPECIFIC_BLOCK.
 599         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 600         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 601         BLOCK_INDEX.
 602
 603 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 604
 605         * NEWS: Mention changes to "info sources" command.
 606
 607 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 608
 609         * symtab.c (filename_partial_match_opts): New struct type.
 610         (struct output_source_filename_data): New members
 611         regexp, c_regexp, partial_match.
 612         (output_source_filename): Use new members to decide to print file.
 613         (info_sources_option_defs): New variable.
 614         (make_info_sources_options_def_group, print_info_sources_header,
 615         info_sources_command_completer):
 616         New functions.
 617         (info_sources_command): Read new optional arguments.
 618         (_initialize_symtab): Update info sources help.
 619
 620 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 621
 622         * ada-lang.c (exception_support_info_v0): Renamed from...
 623         (default_exception_support_info): ... this.  Create new
 624         definition for v1.
 625         (ada_has_this_exception_support): Look up catch_handlers_sym.
 626         (ada_exception_support_info_sniffer): Try v0 after default.
 627
 628 2019-08-01  Tom Tromey  <tromey@adacore.com>
 629
 630         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 631         gdbarch.h.
 632
 633 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 634
 635         * s12z-tdep.c: Fix include path for s12z-opc.h.
 636
 637 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 638
 639         * NEWS: Require GNU make 3.82.
 640
 641 2019-07-16  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 644         declare.
 645
 646 2019-07-30  Tom Tromey  <tromey@adacore.com>
 647
 648         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 649
 650 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 651
 652         * printcmd.c (print_address_symbolic): Print negative offsets.
 653         (build_address_symbolic): Force signed arithmetic when computing
 654         offset.
 655
 656 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 657
 658         PR/24474: Add a function to lookup static variables.
 659         * NEWS: Mention this new function.
 660         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 661         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 662         * python/python.c (python_GdbMethods): Add new function.
 663
 664 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 667         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 668         (objfpy_lookup_static_symbol): New function.
 669         (objfile_object_methods): Add new functions.
 670
 671 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 672
 673         * NEWS: Mention 'set|show print frame-info'.  Mention new
 674         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 675         backtrace argument.  Mention that python frame filtering code
 676         is now consistent with what 'backtrace' command prints.
 677
 678 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 679
 680         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 681         comments.
 682         (print_frame_info_auto, print_frame_info_source_line,
 683         print_frame_info_location, print_frame_info_source_and_location,
 684         print_frame_info_location_and_address, print_frame_info_short_location):
 685         New declarations.
 686         (struct frame_print_options): New member print_frame_info.
 687         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 688         * stack.h (get_user_print_what_frame_info): New declaration.
 689         (frame_show_address): New declaration.
 690         * stack.c (print_frame_arguments_choices): New value 'presence'.
 691         (print_frame_info_auto, print_frame_info_source_line,
 692         print_frame_info_location, print_frame_info_source_and_location,
 693         print_frame_info_location_and_address, print_frame_info_short_location,
 694         print_frame_info_choices, print_frame_info_print_what): New definitions.
 695         (print_frame_args): Only print dots for args if print frame-arguments
 696         is 'presence'.
 697         (frame_print_option_defs): New element for "frame-info".
 698         (get_user_print_what_frame_info): New function.
 699         (frame_show_address): Make non static.  Move comment to stack.h.
 700         (print_frame_info_to_print_what): New function.
 701         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 702         to decide what to print.
 703         (backtrace_command_1): Handle the new print_frame_arguments_presence
 704         value.
 705         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 706         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 707         (py_print_frame): In non-mi mode, use LOCATION as default for
 708         print_what, similarly to frame information printed directly by
 709         backtrace command. Handle frame-info user option in non MI mode.
 710
 711 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 712
 713         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 714         Add case for debugging 32-bit target on 64-bit host.  Revise
 715         comment.
 716
 717 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 718
 719         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 720         instead of find_function_entry_range_from_pc.
 721
 722 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 723
 724         * stack.c (find_frame_funname): Remove code which preferred
 725         minsym over symtab sym in "certain pathological cases".
 726
 727         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 728         parameter.  Change type of "do_demangle" to bool.
 729         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 730         Pass suitable "prefer_sym_over_minsym" flag to
 731         build_address_symbolic().  Don't output "+" for negative offsets.
 732         * printcmd.c (print_address_symbolic): Update invocation of
 733         build_address_symbolic to include a "prefer_sym_over_minsym"
 734         flag.
 735         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 736         Restrict cases in which use of minimal symbol is preferred to that
 737         of a found symbol.  Update comments.
 738
 739         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 740         for entry pc when entry pc is out of range for that FDE.
 741
 742 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 743
 744         PR gdb/24839:
 745         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 746         type.
 747
 748 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 749
 750         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 751         this function's Python signature.
 752
 753
 754 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 755
 756         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 757         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 758         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 759         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 760         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 761
 762
 763 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 764
 765         * h8300-tdep.c (h8300_register_name_common): New.
 766         h8300_register_name): Use h8300_register_name_common.
 767         (h8300s_register_name): Likewise.
 768         (h8300sx_register_name): Likewise.
 769         (h8300h_register_nam): New.
 770         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 771
 772
 773 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 774
 775         * arm-tdep.c (arm_skip_cmse_entry): New function.
 776         (arm_is_sgstubs_section): New function.
 777         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 778
 779 2019-07-22  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 782         Don't self-assign.
 783
 784 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 787         type_print.
 788
 789 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 792         so that GDB doesn't match any msymbols when searching in the
 793         TYPES_DOMAIN.
 794         (print_symbol_info): Print using typedef_print or type_print based
 795         on the type of the symbol.  Add updated FIXME comment moved from...
 796         (_initialize_symtab): ... move and update FIXME comment to above.
 797
 798 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * NEWS: Mention adding -q option to "info types".
 801         * symtab.c (struct info_types_options): New struct.
 802         (info_types_options_defs): New variable.
 803         (make_info_types_options_def_group): New function.
 804         (info_types_command): Use gdb::option framework to parse options.
 805         (info_types_command_completer): New function.
 806         (_initialize_symtab): Extend the help text on "info types" and
 807         register command completer.
 808
 809 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 810
 811         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 812         (lookup_symbol_in_objfile): Change int to block_enum and add a
 813         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 814
 815 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 816
 817         * MAINTAINERS (Write After Approval): Add self.
 818
 819 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 822         instruction to the dummy code region.
 823
 824 2019-07-19  Tom Tromey  <tromey@adacore.com>
 825
 826         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 827         (ARGSUSED, PARAMS, __func__): Remove rules.
 828
 829 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 830
 831         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 832         * features/arm/arm-with-iwmmxt.c: Remove.
 833         * features/arm/arm-with-iwmmxt.xml: Remove.
 834         * features/arm/arm-with-m-fpa-layout.c: Remove.
 835         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 836         * features/arm/arm-with-m-vfp-d16.c: Remove.
 837         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 838         * features/arm/arm-with-m.c: Remove.
 839         * features/arm/arm-with-m.xml: Remove.
 840         * features/arm/arm-with-neon.c: Remove.
 841         * features/arm/arm-with-neon.xml: Remove.
 842         * features/arm/arm-with-vfpv2.c: Remove.
 843         * features/arm/arm-with-vfpv2.xml: Remove.
 844         * features/arm/arm-with-vfpv3.c: Remove.
 845         * features/arm/arm-with-vfpv3.xml: Remove.
 846
 847 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 848
 849         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 850
 851 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 852
 853         * arch/aarch32.c (aarch32_create_target_description): Create
 854         target descriptions using features.
 855         * arch/arm.c (arm_create_target_description)
 856         (arm_create_mprofile_target_description): Likewise.
 857         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 858
 859 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 860
 861         * Makefile.in: Add new files.
 862         * aarch32-tdep.c: New file.
 863         * aarch32-tdep.h: New file.
 864         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 865         Call aarch32_read_description.
 866         * arch/aarch32.c: New file.
 867         * arch/aarch32.h: New file.
 868         * arch/arm.c (arm_create_target_description)
 869         (arm_create_mprofile_target_description): New function.
 870         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 871         (arm_create_target_description)
 872         (arm_create_mprofile_target_description): New declaration.
 873         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 874         read_description functions.
 875         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 876         Likewise.
 877         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 878         * arm-tdep.c (tdesc_arm_list): New variable.
 879         (arm_register_g_packet_guesses): Call create description functions.
 880         (arm_read_description) (arm_read_mprofile_description): New
 881         function.
 882         * arm-tdep.h (arm_read_description)
 883         (arm_read_mprofile_description): Add declaration.
 884         * configure.tgt: Add new files.
 885
 886 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 887
 888         * top.c (new_ui_command): Open specified terminal just once.
 889
 890 2019-07-18  Tom Tromey  <tromey@adacore.com>
 891
 892         * symtab.c (main_name): Constify return type.
 893         * symfile.c (set_initial_language): Update.
 894         * symtab.h (main_name): Constify return type.
 895
 896 2019-07-17  Tom Tromey  <tom@tromey.com>
 897
 898         * tui/tui-winsource.c (tui_update_source_window)
 899         (tui_update_source_window_as_is)
 900         (tui_update_source_windows_with_line): Remove return.
 901         * tui/tui-disasm.c (tui_show_disassem)
 902         (tui_show_disassem_and_update_source): Remove return.
 903         * tui/tui.c (tui_reset): Remove return.
 904         * tui/tui-wingeneral.c
 905         (tui_check_and_display_highlight_if_needed): Remove return.
 906
 907 2019-07-17  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 910
 911 2019-07-17  Tom Tromey  <tom@tromey.com>
 912
 913         * tui/tui-winsource.h (struct tui_exec_info_window)
 914         (struct tui_source_window_base): Move from tui-data.h.
 915         * tui/tui-winsource.c: Move many method definitions from
 916         elsewhere.  Remove "structuring" comments.
 917         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 918         (tui_source_window_base::refresh_window): Move to
 919         tui-winsource.c.
 920         * tui/tui-win.c (tui_source_window_base::refresh_all)
 921         (tui_source_window_base::update_tab_width)
 922         (tui_source_window_base::set_new_height)
 923         (tui_source_window_base::do_make_visible_with_new_height): Move to
 924         tui-winsource.c.
 925         * tui/tui-source.h: Update.
 926         * tui/tui-source.c (tui_source_window_base::reset): Move to
 927         tui-winsource.c.
 928         * tui/tui-disasm.h: Update.
 929         * tui/tui-data.h (struct tui_exec_info_window): Move to
 930         tui-winsource.h.
 931         (struct tui_source_window_base): Likewise.
 932         * tui/tui-data.c (tui_source_window_base::clear_detail)
 933         (tui_source_window_base, ~tui_source_window_base): Move to
 934         tui-winsource.c.
 935
 936 2019-07-17  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-win.c (tui_resize_all)
 939         (tui_source_window_base::update_tab_width)
 940         (tui_adjust_win_heights): Update.
 941         (tui_win_info::make_invisible_and_set_new_height): Rename from
 942         make_invisible_and_set_new_height.
 943         * tui/tui-data.h (struct tui_win_info)
 944         <make_invisible_and_set_new_height>: New method.
 945
 946 2019-07-17  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui.c: Update.
 949         * tui/tui-source.h (struct tui_source_window): Move from
 950         tui-data.h.
 951         * tui/tui-layout.c: Update.
 952         * tui/tui-disasm.c: Update.
 953         * tui/tui-data.h (struct tui_source_window): Move to
 954         tui-source.h.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 959         tui-data.h.
 960         * tui/tui-data.h (struct tui_disasm_window): Move to
 961         tui-disasm.h.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-regs.h (struct tui_data_item_window): Move from
 966         tui-data.h.
 967         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 968         * tui/tui-data.h (struct tui_data_item_window): Move to
 969         tui-regs.h.
 970         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 971
 972 2019-07-17  Tom Tromey  <tom@tromey.com>
 973
 974         * tui/tui.c: Update.
 975         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 976         (tui_cmd_window::max_height): Move to tui-command.c.
 977         * tui/tui-layout.c: Update.
 978         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 979         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 980         tui-command.c.
 981         * tui/tui-command.h (struct tui_cmd_window): Move from
 982         tui-data.h.
 983         * tui/tui-command.c: Remove "structuring" comments.
 984         (tui_cmd_window::clear_detail)
 985         (tui_cmd_window::do_make_visible_with_new_height)
 986         (tui_cmd_window::max_height): Move from elsewhere.
 987
 988 2019-07-17  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 991         Now static.
 992         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 993         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 994
 995 2019-07-17  Tom Tromey  <tom@tromey.com>
 996
 997         * tui/tui.c: Update.
 998         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 999         tui-regs.c.
1000         * tui/tui-windata.h: Remove file.
1001         * tui/tui-windata.c: Remove file.
1002         * tui/tui-win.c (tui_data_window::set_new_height)
1003         (tui_data_window::do_make_visible_with_new_height): Move to
1004         tui-regs.c.
1005         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1006         * tui/tui-regs.c: Remove "structuring" comments.
1007         (tui_data_window::first_data_item_displayed)
1008         (tui_data_window::delete_data_content_windows)
1009         (tui_data_window::erase_data_content)
1010         (tui_data_window::display_all_data)
1011         (tui_data_window::refresh_all)
1012         (tui_data_window::do_scroll_vertical)
1013         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1014         (tui_data_window::do_make_visible_with_new_height)
1015         (tui_data_window::refresh_window): Move from elsewhere.
1016         (_initialize_tui_regs): Move to end of file.
1017         * tui/tui-layout.c: Update.
1018         * tui/tui-hooks.c: Update.
1019         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1020         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1021         tui-regs.c.
1022         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1023
1024 2019-07-17  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1027         seen.
1028
1029 2019-07-17  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-win.c (tui_source_window_base::set_new_height)
1032         (tui_source_window_base::do_make_visible_with_new_height): Use
1033         m_has_locator field directly.
1034         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1035         method.
1036         (struct tui_source_window_base) <has_locator>: Likewise.
1037
1038 2019-07-17  Tom Tromey  <tom@tromey.com>
1039
1040         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1041         Don't declare.
1042         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1043         Remove.
1044         * tui/tui-win.c (tui_source_window_base::set_new_height)
1045         (tui_source_window_base::set_new_height)
1046         (make_invisible_and_set_new_height)
1047         (tui_source_window_base::do_make_visible_with_new_height)
1048         (tui_source_window_base::do_make_visible_with_new_height):
1049         Update.
1050         * tui/tui-layout.c (show_source_disasm_command, show_data)
1051         (show_source_or_disasm_and_command): Update.
1052         * tui/tui-layout.c (show_layout): Update.
1053
1054 2019-07-17  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-layout.c (make_data_window): Remove.
1057         (show_data): Unify creation and re-initialization cases.
1058
1059 2019-07-17  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-layout.c (make_source_window, make_disasm_window):
1062         Remove.
1063         (show_data): Unify creation and re-initialization cases.
1064
1065 2019-07-17  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-layout.c (make_command_window): Remove.
1068         (show_source_disasm_command, show_source_or_disasm_and_command):
1069         Unify creation and re-initialization cases.
1070
1071 2019-07-17  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1074         creation and re-initialization cases.
1075
1076 2019-07-17  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-regs.c (tui_get_register): Return void.
1079
1080 2019-07-17  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1083         Simplify.
1084
1085 2019-07-17  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1088         resetting.
1089
1090 2019-07-17  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1093         * tui/tui-regs.c (tui_reg_layout): New function.
1094         (tui_show_registers, tui_reg_command): Use it.
1095         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1096         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1097         parameters.
1098         (tui_layout_command): Remove.
1099
1100 2019-07-17  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-layout.h (tui/tui-layout): Return void.
1103         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1104
1105 2019-07-17  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-layout.c (show_source_disasm_command, show_data):
1108         Update.
1109         (reset_locator): Remove.
1110         (show_source_or_disasm_and_command): Update.
1111
1112 2019-07-17  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-source.c (tui_source_window_base::reset): Remove
1115         win_type parameter.
1116         * tui/tui-layout.c (make_command_window, make_source_window)
1117         (make_disasm_window, make_data_window)
1118         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1119         (reset_locator, show_source_or_disasm_and_command): Update.
1120         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1121         win_type parameter.
1122         (struct tui_source_window_base) <reset>: Likewise.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-layout.c (show_source_disasm_command): Use
1127         reset_locator.
1128         (reset_locator): New function.
1129         (init_and_make_win): Remove.
1130         (show_source_or_disasm_and_command): Use reset_locator.
1131
1132 2019-07-17  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1135         condition.
1136         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1137         Remove condition.
1138         * tui/tui-source.c (tui_source_window_base::reset): New method.
1139         * tui/tui-layout.c (make_command_window): Don't call
1140         init_and_make_win.
1141         (make_source_window, make_disasm_window): Don't call
1142         make_source_or_disasm_window.
1143         (make_data_window): Don't call init_and_make_win.  Change calling
1144         convention.
1145         (show_source_disasm_command, show_data): Simplify.
1146         (make_source_or_disasm_window): Remove.
1147         (show_source_or_disasm_and_command): Simplify.
1148         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1149         (struct tui_source_window_base) <reset>: Likewise.
1150         <execution_info>: Remove initializer.
1151         * tui/tui-data.c (tui_source_window_base): Initialize
1152         execution_info.
1153
1154 2019-07-17  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1157         variable.
1158
1159 2019-07-17  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui.c (tui_rl_other_window): Update.
1162         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1163         superclass method first.  Always iterate over regs_content.
1164         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1165         method.
1166         * tui/tui-win.c (tui_set_focus_command): Update.
1167
1168 2019-07-17  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-win.c (tui_set_focus_command): Rename from
1171         tui_set_focus.  Call tui_enable.
1172         (tui_set_focus_command): Remove.
1173
1174 2019-07-17  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1177         refresh_window.
1178         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1179         touchwin.
1180         (tui_data_window::refresh_window): Call refresh_window on data
1181         items.  Always call superclass refresh_window.
1182         (tui_win_info::refresh): Remove.
1183         (tui_source_window_base::refresh_window): Update.
1184         (tui_refresh_all): Update.
1185         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1186         refresh_window.
1187         (show_source_or_disasm_and_command): Likewise.
1188         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1189         (struct tui_source_window_base) <refresh>: Likewise.
1190
1191 2019-07-17  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-winsource.c (tui_clear_source_content)
1194         (tui_show_source_content): Update.
1195         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1196         whether content is empty.
1197         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1198         Remove.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1203         window's contents.
1204         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1205         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1210         (struct tui_data_item_window): Update.
1211
1212 2019-07-17  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1215         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1216         defines.
1217
1218 2019-07-17  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-winsource.h (tui_erase_source_content)
1221         (tui_clear_source_content): Remove "display_prompt" parameter.
1222         * tui/tui-winsource.c (tui_update_source_window_as_is)
1223         (tui_update_source_windows_with_addr): Update.
1224         (tui_clear_source_content): Remove "display_prompt" parameter.
1225         (tui_erase_source_content): Likewise.  Simplify.
1226         (tui_show_source_content): Update.
1227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1228         * tui/tui-stack.c (tui_show_frame_info): Update.
1229         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1230         Remove defines.
1231
1232 2019-07-17  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1235         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1236         parameter.
1237         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1238         parameter.
1239
1240 2019-07-17  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-winsource.c (tui_clear_source_content)
1243         (tui_show_source_content, tui_show_exec_info_content)
1244         (tui_clear_exec_info_content): Update.
1245         * tui/tui-stack.c (tui_show_locator_content): Update.
1246         (tui_show_frame_info): Update.
1247         * tui/tui-source.h (tui_source_window): Don't declare.
1248         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1249         from tui_source_is_displayed.
1250         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1251         Remove field.
1252         (struct tui_source_window_base) <content_in_use>: New field.  Now
1253         bool.
1254         (struct tui_source_window) <showing_source_p>: New method.
1255         (TUI_SRC_WIN): Change cast.
1256         * tui/tui-data.c (tui_initialize_static_data): Update.
1257
1258 2019-07-17  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1261         location_matches_p.
1262         * tui/tui-source.c (tui_source_window::location_matches_p): New
1263         method.
1264         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1265         method.
1266         * tui/tui-data.h (struct tui_source_window_base)
1267         <location_matches_p>: New method.
1268         (struct tui_source_window, struct tui_disasm_window)
1269         <location_matches_p>: Likewise.
1270
1271 2019-07-17  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-win.c (tui_set_win_height_command): Rename from
1274         tui_set_win_height.
1275         (tui_set_win_height_command): Remove.
1276
1277 2019-07-17  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-source.c (tui_source_window): New constructor.  Add
1280         observer.
1281         (~tui_source_window): New destructor.
1282         (tui_source_window::style_changed): New method.
1283         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1284         (tui_attach_detach_observers): Update.
1285         * tui/tui-data.h (struct tui_source_window): Make constructor not
1286         inline.  Add destructor.
1287         (struct tui_source_window) <style_changed>: New method.
1288         <m_observable>: New member.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1293         * tui/tui-win.c (tui_resize_all): Fix typo.
1294
1295 2019-07-17  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1298         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1299         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1300         * tui/tui-win.c (window_name_completer): Use foreach.
1301         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1302         (update_tab_width): Likewise.
1303         * tui/tui-layout.c (show_layout): Update.
1304         * tui/tui-data.h (class tui_window_iterator): New.
1305         (struct all_tui_windows): New.
1306         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1307
1308 2019-07-17  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1311         parameter.  Don't reference globals.
1312         (tui_reg_command): Update.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-regs.c (tui_show_registers): Simplify.
1317
1318 2019-07-17  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-regs.c (tui_show_registers): Update.
1321         (tui_show_register_group): Add win_info parameter.
1322
1323 2019-07-17  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1326         Rename from tui_display_reg_element_at_line.
1327         (tui_data_window::display_registers_from_line): Update.
1328         * tui/tui-data.h (struct tui_data_window)
1329         <display_reg_element_at_line>: New method.
1330
1331 2019-07-17  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-regs.h (tui_display_registers_from)
1334         (tui_display_registers_from_line): Don't declare.
1335         * tui/tui-windata.c (tui_data_window::display_all_data)
1336         (tui_data_window::refresh_all)
1337         (tui_data_window::do_scroll_vertical): Update.
1338         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1339         from tui_display_registers_from.
1340         (tui_display_reg_element_at_line): Update.
1341         (tui_data_window::display_registers_from_line): Rename from
1342         tui_display_registers_from_line.
1343         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1344         display_registers_from_line>: New methods.
1345
1346 2019-07-17  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1349         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1350         from tui_erase_data_content.
1351         (tui_data_window::display_all_data)
1352         (tui_data_window::refresh_all)
1353         (tui_data_window::do_scroll_vertical): Update.
1354         * tui/tui-regs.c (tui_show_registers): Update.
1355         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1356         New method.
1357
1358 2019-07-17  Tom Tromey  <tom@tromey.com>
1359
1360         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1361         declare.
1362         * tui/tui-windata.c
1363         (tui_data_window::delete_data_content_windows): Rename from
1364         tui_delete_data_content_windows.
1365         (tui_data_window::display_all_data)
1366         (tui_data_window::do_scroll_vertical): Update.
1367         * tui/tui-data.h (struct tui_data_window)
1368         <delete_data_content_windows>: New method.
1369
1370 2019-07-17  Tom Tromey  <tom@tromey.com>
1371
1372         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1373         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1374
1375 2019-07-17  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1378         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1379         from tui_display_all_data.
1380         * tui/tui-win.c
1381         (tui_data_window::do_make_visible_with_new_height): Update.
1382         * tui/tui-regs.c (tui_show_registers): Update.
1383         * tui/tui-layout.c (tui_set_layout): Update.
1384         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1385         method.
1386
1387 2019-07-17  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1390         * tui/tui-windata.c (tui_display_data_from): Remove.
1391         (tui_data_window::refresh_all): Update.
1392
1393 2019-07-17  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1396         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1397         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1398         tui_display_registers_from_line.
1399         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1400         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1401         "force_display" parameter.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1406         declare.
1407         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1408         Rename from tui_first_reg_element_no_inline.
1409         (tui_display_reg_element_at_line)
1410         (tui_display_registers_from_line): Update.
1411         * tui/tui-data.h (struct tui_data_window)
1412         <first_reg_element_no_inline>: New method.
1413
1414 2019-07-17  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-windata.c (tui_display_data_from)
1417         (tui_data_window::do_scroll_vertical): Update.
1418         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1419         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1420         Rename from tui_line_from_reg_element_no.
1421         (tui_display_registers_from_line): Update.
1422         * tui/tui-data.h (struct tui_data_window)
1423         <line_from_reg_element_no>: New method.
1424
1425 2019-07-17  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1428         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1429         tui_last_regs_line_no.
1430         (tui_display_reg_element_at_line)
1431         (tui_display_registers_from_line): Update.
1432         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1433         method.
1434
1435 2019-07-17  Tom Tromey  <tom@tromey.com>
1436
1437         PR tui/24722:
1438         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1439         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1440         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1441         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1442         (tui_update_breakpoint_info): Likewise.
1443         * tui/tui-hooks.c (tui_event_create_breakpoint)
1444         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1445         Update.
1446
1447 2019-07-17  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1450
1451 2019-07-17  Tom Tromey  <tom@tromey.com>
1452
1453         * tui/tui-winsource.c (tui_update_source_window_as_is)
1454         (tui_update_source_windows_with_addr): Update.
1455         * tui/tui-source.h (tui_set_source_content)
1456         (tui_show_symtab_source): Add "win_info" parameter.
1457         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1458         parameter.
1459         (tui_show_symtab_source): Likewise.
1460
1461 2019-07-17  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-wingeneral.c
1464         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1465
1466 2019-07-17  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1469         (struct tui_cmd_window) <can_scroll>: New method.
1470         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1471         method.
1472
1473 2019-07-17  Tom Tromey  <tromey@adacore.com>
1474
1475         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1476         do_field_signed>: Rename.  Change type of "value".
1477         * ui-out.c (ui_out::field_signed): Rename from field_int.
1478         Change type of "value".
1479         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1480         type of "value".
1481         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1482         do_field_int.  Change type of "value".
1483         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1484         do_field_int.  Change type of "value".
1485         * tracepoint.c (trace_status_mi, tfind_1)
1486         (print_one_static_tracepoint_marker): Update.
1487         * thread.c (print_thread_info_1, print_selected_thread_frame):
1488         Update.
1489         * stack.c (print_frame, print_frame_info): Update.
1490         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1491         Update.
1492         * source.c (print_source_lines_base): Update.
1493         * skip.c (info_skip_command): Update.
1494         * record-btrace.c (btrace_ui_out_decode_error)
1495         (btrace_call_history_src_line): Update.
1496         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1497         Update.
1498         * progspace.c (print_program_space): Update.
1499         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1500         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1501         do_field_int.  Change type of "value".
1502         * mi/mi-out.c (mi_ui_out::do_table_begin)
1503         (mi_ui_out::do_table_header): Update.
1504         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1505         type of "value".
1506         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1507         (mi_cmd_data_list_changed_registers, output_register)
1508         (mi_cmd_data_read_memory, mi_load_progress)
1509         (mi_cmd_trace_frame_collected): Update.
1510         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1511         Update.
1512         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1513         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1514         (mi_cmd_var_list_children, varobj_update_one): Update.
1515         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1516         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1517         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1518         * inferior.c (print_inferior): Update.
1519         * gdb_bfd.c (print_one_bfd): Update.
1520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1521         Update.
1522         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1523         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1524         do_field_int.  Change type of "value".
1525         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1526         do_field_int.  Change type of "value".
1527         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1528         (print_one_breakpoint_location, print_it_catch_fork)
1529         (print_one_catch_fork, print_it_catch_vfork)
1530         (print_one_catch_vfork, print_it_catch_solib)
1531         (print_it_catch_exec, print_it_ranged_breakpoint)
1532         (print_mention_watchpoint, print_mention_masked_watchpoint)
1533         (bkpt_print_it, update_static_tracepoint): Update.
1534         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1535         * break-catch-syscall.c (print_it_catch_syscall): Update.
1536         * ada-tasks.c (print_ada_task_info): Update.
1537         * ada-lang.c (print_it_exception, print_mention_exception):
1538         Update.
1539
1540 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         PR breakpoints/24541
1543         * gdbarch.c: Regenerate.
1544         * gdbarch.h: Regenerate.
1545         * gdbarch.sh: Adjust return type and parameter types for
1546         'stap_adjust_register'.
1547         (i386_stap_adjust_register): Adjust signature and return new
1548         register name.
1549         * stap-probe.c (stap_parse_register_operand): Adjust use of
1550         'gdbarch_stap_adjust_register'.
1551
1552 2019-07-17  Tom Tromey  <tromey@adacore.com>
1553
1554         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1555         declare VEC.
1556         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1557         std::vector.
1558         (struct s390_process_info): Add initializers.
1559         (s390_add_process): Use new.
1560         (s390_linux_nat_target::low_forget_process): Use delete.
1561         (s390_linux_nat_target::low_new_fork)
1562         (s390_linux_nat_target::stopped_by_watchpoint)
1563         (s390_linux_nat_target::low_prepare_to_resume)
1564         (s390_linux_nat_target::insert_watchpoint)
1565         (s390_linux_nat_target::insert_hw_breakpoint)
1566         (s390_linux_nat_target::remove_watchpoint)
1567         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1568
1569 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1570
1571         * aarch64-fbsd-nat.c: Include regcache.h.
1572         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1573         argument.
1574         (aarch64_fbsd_nat_target::fetch_registers)
1575         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1576         variable.
1577         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1578
1579 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1580
1581         * fbsd-nat.c: Include gdbarch.h.
1582
1583 2019-07-15  Tom Tromey  <tromey@adacore.com>
1584
1585         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1586
1587 2019-07-15  Tom Tromey  <tromey@adacore.com>
1588
1589         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1590         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1591         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1592         * cli-out.c (cli_ui_out::do_field_int): New method.
1593         * ui-out.c (ui_out::field_unsigned): New method.
1594         * symfile.c (generic_load): Use field_unsigned.
1595         (print_transfer_performance): Likewise.
1596         * record-btrace.c (ui_out_field_uint): Remove.
1597         (btrace_call_history_insn_range, btrace_call_history): Use
1598         field_unsigned.
1599         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1600         field_unsigned.
1601         * ui-out.h (class ui_out) <field_unsigned>: New method.
1602         <do_field_unsigned>: Likewise.
1603
1604 2019-07-15  Tom Tromey  <tromey@adacore.com>
1605
1606         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1607         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1608         * target.c (flash_erase_command): Use field_string.
1609         * infrun.c (print_signal_received_reason): Use field_string.
1610         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1611         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1612         field_string.
1613         * ada-tasks.c (print_ada_task_info): Use field_string.
1614
1615 2019-07-15  Tom Tromey  <tromey@adacore.com>
1616
1617         * target.c (flash_erase_command): Use field_core_addr.
1618         * symfile.c (generic_load): Use field_core_addr.
1619         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1620         Use field_core_addr.
1621         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1622         field_core_addr.
1623
1624 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1627         value if its desired type is smaller than a CORE_ADDR and signed.
1628
1629 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1630
1631         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1632         of changes to field names, and use new is_reference field to
1633         decide if a property is a reference or not.
1634         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1635         field.
1636         (struct dwarf2_property_baton): Update header comment, rename
1637         'referenced_type' to 'property_type' and update comments.
1638         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1639         default property type, store in property baton, update to take
1640         accound of renamed field.
1641         (read_func_scope): Update call to attr_to_dynamic_prop.
1642         (read_array_type): Likewise.
1643         (dwarf2_per_cu_addr_sized_int_type): New function.
1644         (read_subrange_index_type): Move type finding code to
1645         dwarf2_per_cu_addr_sized_int_type.
1646         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1647         (dwarf2_per_cu_addr_type): New function.
1648         (set_die_type): Update calls to attr_to_dynamic_prop.
1649
1650 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * dwarf2read.c (read_subrange_index_type): New function.
1653         (read_subrange_type): Move code into new function and call it.
1654         * gdbtypes.c (create_range_type): Add some asserts.
1655
1656 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1659         update return statements.
1660         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1661         declaration, and update comment to match.
1662         * gdbtypes.c (resolve_dynamic_array): Update call to
1663         dwarf2_evaluate_property to match new return type.
1664
1665 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1666
1667         * valarith.c (value_subscripted_rvalue): Change lowerbound
1668         parameter type from int to LONGEST.
1669         * value.h (value_subscripted_rvalue): Likewise in declaration.
1670
1671 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * cli/cli-utils.c (info_print_command_completer): New function.
1674         * cli/cli-utils.h: Add 'completer.h' include, and forward
1675         declaration for 'struct cmd_list_element'.
1676         (info_print_command_completer): Declare.
1677         * stack.c (_initialize_stack): Add completer for 'info locals' and
1678         'info args'.
1679         * symtab.c (_initialize_symtab): Add completer for 'info
1680         variables' and 'info functions'.
1681         * NEWS: Mention completion for additional info commands.
1682
1683 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * cli/cli-utils.c (extract_info_print_args): Delete.
1686         (extract_arg_maybe_quoted): Delete.
1687         (info_print_options_defs): New variable.
1688         (make_info_print_options_def_group): New function.
1689         (extract_info_print_options): Define new function.
1690         * cli/cli-utils.h (extract_info_print_args): Delete.
1691         (struct info_print_options): New structure.
1692         (extract_info_print_options): Declare new function.
1693         * stack.c (info_locals_command): Update to use new
1694         extract_info_print_options, also add a header comment.
1695         (info_args_command): Likewise.
1696         * symtab.c (info_variables_command): Likewise.
1697         (info_functions_command): Likewise.
1698
1699 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1702         to extract string arguments.
1703         * common/common-utils.c (extract_string_maybe_quoted): New function.
1704         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1705
1706 2019-07-11  Tom Tromey  <tromey@adacore.com>
1707
1708         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1709         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1710         * top.h (gdbinit): Don't declare.
1711         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1712         into...
1713         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1714         * top.c (gdb_init): Don't call init_cli_cmds.
1715         (gdbinit): Remove.
1716         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1717
1718 2019-07-11  Tom Tromey  <tromey@adacore.com>
1719
1720         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1721         after it has been moved.
1722
1723 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1724
1725         * valops.c (value_must_coerce_to_target): Change return type to
1726         bool.
1727         * value.h (value_must_coerce_to_target): Likewise.
1728
1729 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1730
1731         * breakpoint.c (is_hardware_watchpoint): Remove
1732         forward-declaration.
1733         (is_masked_watchpoint): Change return type to bool.
1734         (is_tracepoint): Likewise.
1735         (is_breakpoint): Likewise.
1736         (is_hardware_watchpoint): Likewise.
1737         (is_watchpoint): Likewise.
1738         (is_no_memory_software_watchpoint): Likewise.
1739         (is_catchpoint): Likewise.
1740         (breakpoint_1): Make FILTER parameter's return type bool.
1741         is_masked_watchpoint): Change return type to bool.
1742         (save_breakpoints): Make FILTER parameter's return type bool.
1743         * breakpoint.h (is_breakpoint): Change return type to bool.
1744         (is_watchpoint): Likewise.
1745         (is_catchpoint): Likewise.
1746         (is_tracepoint): Likewise.
1747
1748 2019-07-10  Tom Tromey  <tom@tromey.com>
1749
1750         * defs.h: Don't include gdbarch.h.
1751         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1752         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1753         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1754         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1755         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1756         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1757         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1758         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1759         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1760         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1761         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1762         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1763         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1764         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1765         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1766         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1767         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1768         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1769         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1770         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1771         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1772         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1773         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1774         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1775         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1776         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1777         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1778
1779 2019-07-10  Tom Tromey  <tromey@adacore.com>
1780
1781         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1782         * breakpoint.c (init_ada_exception_breakpoint): Register as
1783         bp_catchpoint.
1784         (print_one_breakpoint_location, print_one_breakpoint): Use
1785         is_ada_exception_catchpoint.
1786         * ada-lang.c (class ada_catchpoint_location): Pass
1787         bp_loc_software_breakpoint to bp_location constructor.
1788         (is_ada_exception_catchpoint): New function.
1789
1790 2019-07-10  Tom Tromey  <tromey@adacore.com>
1791
1792         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1793         VEC.
1794         (struct arm_exidx_entry): New method operator<.
1795         (struct arm_exidx_data) <section_maps>: Change type.
1796         (arm_exidx_data_free): Remove.
1797         (arm_exidx_data_key): Change type.  Move lower.
1798         (arm_exidx_new_objfile): Update.
1799         (arm_compare_exidx_entries): Remove.
1800         (arm_find_exidx_entry, _initialize_arm_tdep)
1801
1802 2019-07-10  Tom Tromey  <tromey@adacore.com>
1803
1804         * solib-spu.c (ocl_program_data_key): Change type.
1805         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1806         Update.
1807
1808 2019-07-10  Tom Tromey  <tromey@adacore.com>
1809
1810         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1811         (struct solib_aix_inferior_data) <library_list>: Change type.
1812         (solib_aix_inferior_data_handle): Change type.
1813         (get_solib_aix_inferior_data): Update.
1814         (solib_aix_free_library_list): Remove.
1815         (library_list_start_library): Update.
1816         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1817         return type.
1818         (solib_aix_get_library_list)
1819         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1820         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1821
1822 2019-07-10  Tom Tromey  <tromey@adacore.com>
1823
1824         * solib-dsbt.c (struct dsbt_info): Add initializers.
1825         (solib_dsbt_pspace_data): Change type.
1826         (dsbt_pspace_data_cleanup): Remove.
1827         (get_dsbt_info, _initialize_dsbt_solib): Update.
1828
1829 2019-07-10  Tom Tromey  <tromey@adacore.com>
1830
1831         * spu-tdep.c (spu_overlay_data): Change type.
1832         (spu_get_overlay_table, spu_overlay_new_objfile)
1833         (_initialize_spu_tdep): Update.
1834
1835 2019-07-10  Tom Tromey  <tromey@adacore.com>
1836
1837         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1838         destructor.
1839         (dbx_objfile_data_key): Change type and declare later.
1840         (DBX_SYMFILE_INFO): Rewrite.
1841         * dbxread.c (dbx_objfile_data_key): Change type.
1842         (dbx_symfile_init): Update.
1843         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1844         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1845         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1846
1847 2019-07-10  Tom Tromey  <tromey@adacore.com>
1848
1849         * jit.c (jit_program_space_key): Change type.  Move lower.
1850         (get_jit_program_space_data): Update.
1851         (jit_program_space_data_cleanup): Remove.
1852         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1853         Update.
1854         (struct jit_program_space_data): Add initializers.
1855
1856 2019-07-10  Tom Tromey  <tromey@adacore.com>
1857
1858         * solib-darwin.c (struct darwin_info): Add initializers.
1859         (solib_darwin_pspace_data): Change type.
1860         (darwin_pspace_data_cleanup): Remove.
1861         (get_darwin_info, _initialize_darwin_solib): Update.
1862
1863 2019-07-10  Tom Tromey  <tromey@adacore.com>
1864
1865         * remote-sim.c (struct sim_inferior_data): Add initializers,
1866         constructor, and destructor.
1867         (sim_inferior_data_key): Change type.  Move lower.
1868         (check_for_duplicate_sim_descriptor): Update.
1869         (get_sim_inferior_data): Use new.  Update.
1870         (~sim_inferior_data_cleanup): Rename from
1871         sim_inferior_data_cleanup.  Simplify.
1872         (gdbsim_close_inferior, simulator_command)
1873         (sim_command_completer, _initialize_remote_sim): Update.
1874         (next_pid, INITIAL_PID): Move earlier.
1875
1876 2019-07-10  Tom Tromey  <tromey@adacore.com>
1877
1878         * python/python-internal.h (create_thread_object): Return
1879         gdbpy_ref.
1880         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1881         * python/py-inferior.c (struct threadlist_entry): Add
1882         constructor.
1883         <thread_obj>: Now a gdbpy_ref.
1884         (thread_to_thread_object): Update.
1885         (add_thread_object): Use new.
1886         (delete_thread_object): Use delete.
1887         (infpy_threads): Update.
1888         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1889         GIL.
1890
1891 2019-07-10  Tom Tromey  <tromey@adacore.com>
1892
1893         * valops.c (value_cast): Specialize error message for Ada.
1894
1895 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1896
1897         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1898
1899 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1900
1901         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1902         bpstat_should_step): Return bool, adjust comments.
1903         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1904         bpstat_should_step): Likewise.
1905
1906 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1907
1908         * features/Makefile: Use feature target descriptions for Arm.
1909         * features/arm/arm-core.c: Generate new file.
1910         * features/arm/arm-fpa.c: Likewise.
1911         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1912         * features/arm/arm-m-profile.c: Likewise.
1913         * features/arm/arm-vfpv2.c: Likewise.
1914         * features/arm/arm-vfpv3.c: Likewise.
1915         * features/arm/xscale-iwmmxt.c: Likewise.
1916         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1917
1918 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1919
1920         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1921         ptrace earlier.
1922
1923 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1924
1925         * features/aarch64-pauth.c: Regenerate.
1926
1927 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1928
1929         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1930         bool.
1931         (bpstat_what): Use false instead of 0.
1932
1933 2019-07-09  Pedro Alves  <palves@redhat.com>
1934
1935         * break-catch-throw.c (is_exception_catchpoint): New.
1936         * breakpoint.c (print_one_breakpoint_location): New parameter
1937         'raw_loc'.  Handle it.  Use
1938         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1939         looking at the breakpoint's type.
1940         (print_one_breakpoint): If handling "maint info breakpoints", also
1941         print locations of exception catchpoints.
1942         * breakpoint.h (is_exception_catchpoint): Declare.
1943
1944 2019-07-09  Pedro Alves  <palves@redhat.com>
1945
1946         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1947         "addr" field.
1948         (allocate_location_exception_catchpoint): New.
1949         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1950         (initialize_throw_catchpoint_ops): Install
1951         allocate_location_exception_catchpoint as allocate_location
1952         method.
1953         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1954         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1955         bp_loc_other.
1956         (breakpoint_address_is_meaningful): Delete.
1957         (bl_address_is_meaningful): New.
1958         (breakpoint_locations_match): Adjust comment.
1959         (bp_location_from_bp_type): New, factored out of...
1960         (bp_location::bp_location(breakpoint *)): ... this.
1961         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1962         factored out of...
1963         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1964         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1965         breakpoint_address_is_meaningful.
1966         (bp_locations_compare): Adjust comment.
1967         (update_global_location_list): Use bl_address_is_meaningful
1968         instead of breakpoint_address_is_meaningful.
1969         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1970         explicit.
1971         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1972         * python/py-breakpoint.c (bppy_get_location): No longer check
1973         whether location is null.
1974
1975 2019-07-09  Pedro Alves  <palves@redhat.com>
1976
1977         PR c++/15468
1978         * breakpoint.c (print_one_breakpoint_location): Remove
1979         single-location assert.
1980
1981 2019-07-09  Tom Tromey  <tom@tromey.com>
1982
1983         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1984         * configure: Rebuild.
1985         * configure.ac: Change common to gdbsupport.
1986         * gdbsupport: Rename from common.
1987         * acinclude.m4: Change common to gdbsupport.
1988         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1989         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1990         gdbsupport.
1991         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1992         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1993         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1994         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1995         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1996         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1997         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1998         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1999         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2000         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2001         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2002         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2003         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2004         coff-pe-read.c, command.h, compile/compile-c-support.c,
2005         compile/compile-c.h, compile/compile-cplus-symbols.c,
2006         compile/compile-cplus-types.c, compile/compile-cplus.h,
2007         compile/compile-loc2c.c, compile/compile.c, completer.c,
2008         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2009         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2010         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2011         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2012         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2013         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2014         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2015         features/aarch64-core.c, features/aarch64-fpu.c,
2016         features/aarch64-pauth.c, features/aarch64-sve.c,
2017         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2018         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2019         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2020         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2021         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2022         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2023         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2024         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2025         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2026         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2027         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2028         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2029         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2030         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2031         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2032         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2033         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2034         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2035         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2036         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2037         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2038         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2039         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2040         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2041         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2042         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2043         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2044         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2045         minsyms.c, mips-linux-tdep.c, namespace.h,
2046         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2047         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2048         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2049         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2050         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2051         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2052         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2053         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2054         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2055         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2056         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2057         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2058         procfs.c, producer.c, progspace.h, psymtab.h,
2059         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2060         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2061         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2062         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2063         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2064         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2065         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2066         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2067         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2068         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2069         target-memory.c, target.c, target.h, target/waitstatus.c,
2070         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2071         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2072         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2073         unittests/array-view-selftests.c,
2074         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2075         unittests/common-utils-selftests.c,
2076         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2077         unittests/format_pieces-selftests.c,
2078         unittests/function-view-selftests.c,
2079         unittests/lookup_name_info-selftests.c,
2080         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2081         unittests/mkdir-recursive-selftests.c,
2082         unittests/observable-selftests.c,
2083         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2084         unittests/parse-connection-spec-selftests.c,
2085         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2086         unittests/scoped_fd-selftests.c,
2087         unittests/scoped_mmap-selftests.c,
2088         unittests/scoped_restore-selftests.c,
2089         unittests/string_view-selftests.c, unittests/style-selftests.c,
2090         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2091         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2092         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2093         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2094         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2095         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2096
2097 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2098
2099         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2100         bool value.
2101         (decode_digits_ordinary): Set explicit_line field in sal.
2102         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2103         symtab_and_line that was set on an explicit line number in
2104         assembler code.  Do always update the recorded symtab and line if
2105         we do skip the prologue.
2106
2107 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         * breakpoint.c (set_breakpoint_location_function): Remove
2110         explicit_loc parameter.
2111         (momentary_breakpoint_from_master): Update call to
2112         set_breakpoint_location_function.
2113         (add_location_to_breakpoint): Likewise.
2114
2115 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2118         required features based on default bfd type when no specific bfd
2119         is present.
2120
2121 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2122
2123         * NEWS: Mention that GDB printf and eval commands can now print
2124         C-style and Ada-style convenience var strings without
2125         calling the inferior.
2126         * printcmd.c (printf_c_string): Locally print GDB internal var
2127         instead of transiting via the inferior.
2128         (printf_wide_c_string): Likewise.
2129
2130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2131
2132         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2133
2134 2019-07-04  Tom Tromey  <tom@tromey.com>
2135
2136         PR tui/24724:
2137         * tui/tui-winsource.c (tui_clear_source_content): Update.
2138         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2139         (tui_update_breakpoint_info): Update.
2140         (tui_set_exec_info_content): Update.
2141         * tui/tui-source.c (tui_set_source_content_nil): Update.
2142         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2143         has_break.
2144         * tui/tui-data.h (enum tui_bp_flag): New.
2145         (tui_bp_flags): New enum flags type.
2146         (struct tui_source_element) <break_mode>: Change type.  Rename
2147         from has_break.
2148         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2149         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2150         constants.
2151         * tui/tui-winsource.h: Fix comment.
2152
2153 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2154
2155         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2156         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2157         (store_fpregs_to_thread)
2158         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2159         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2160         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2161         (IWMMXT_REGS_SIZE): Add define.
2162         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2163         (fetch_vfp_regs, store_vfp_regs)
2164         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2165         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2166
2167 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2168
2169         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2170         defines.
2171         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2172         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2173         (ARM_INT_REGISTER_SIZE): ...to this.
2174         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2175         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2176         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2177         (arm_linux_collect_gregset, supply_nwfpe_register)
2178         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2179         defines.
2180         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2181         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2182         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2183         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2184         (arm_return_in_memory, arm_store_return_value)
2185         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2186         (arm_record_ld_st_multiple): Likewise.
2187         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2188         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2189
2190 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2193         AARCH64_DISPLACED_MODIFIED_INSNS.
2194         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2195         (aarch64_displaced_step_copy_insn): Likewise.
2196         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2197         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2198         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2199         ARM_DISPLACED_MODIFIED_INSNS.
2200         * arm-tdep.c (arm_gdbarch_init): Likewise.
2201         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2202         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2203         (struct arm_displaced_step_closure): Use
2204         ARM_DISPLACED_MODIFIED_INSNS.
2205
2206 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2207
2208         * features/Makefile: Remove unused xml files.
2209         * features/aarch64.xml: Remove.
2210         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2211         * features/i386/amd64-avx-avx512.xml: Remove.
2212         * features/i386/amd64-avx-linux.xml: Remove.
2213         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2214         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2215         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2216         * features/i386/amd64-avx-mpx.xml: Remove.
2217         * features/i386/amd64-avx.xml: Remove.
2218         * features/i386/amd64-linux.xml: Remove.
2219         * features/i386/amd64-mpx-linux.xml: Remove.
2220         * features/i386/amd64-mpx.xml: Remove.
2221         * features/i386/amd64.xml: Remove.
2222         * features/i386/i386-avx-avx512-linux.xml: Remove.
2223         * features/i386/i386-avx-avx512.xml: Remove.
2224         * features/i386/i386-avx-linux.xml: Remove.
2225         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2226         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2227         * features/i386/i386-avx-mpx-linux.xml: Remove.
2228         * features/i386/i386-avx-mpx.xml: Remove.
2229         * features/i386/i386-avx.xml: Remove.
2230         * features/i386/i386-linux.xml: Remove.
2231         * features/i386/i386-mmx-linux.xml: Remove.
2232         * features/i386/i386-mmx.xml: Remove.
2233         * features/i386/i386-mpx-linux.xml: Remove.
2234         * features/i386/i386-mpx.xml: Remove.
2235         * features/i386/i386.xml: Remove.
2236         * features/i386/x32-avx-avx512-linux.xml: Remove.
2237         * features/i386/x32-avx-linux.xml: Remove.
2238         * features/i386/x32-linux.xml: Remove.
2239
2240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2241
2242         * regformats/aarch64.dat: Remove.
2243         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2244         * regformats/i386/amd64-avx-linux.dat: Remove.
2245         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2246         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2247         * regformats/i386/amd64-linux.dat: Remove.
2248         * regformats/i386/amd64-mpx-linux.dat: Remove.
2249         * regformats/i386/amd64.dat: Remove.
2250         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2251         * regformats/i386/i386-avx-linux.dat: Remove.
2252         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2253         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2254         * regformats/i386/i386-linux.dat: Remove.
2255         * regformats/i386/i386-mmx-linux.dat: Remove.
2256         * regformats/i386/i386-mpx-linux.dat: Remove.
2257         * regformats/i386/i386.dat: Remove.
2258         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2259         * regformats/i386/x32-avx-linux.dat: Remove.
2260         * regformats/i386/x32-linux.dat: Remove.
2261
2262 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2263
2264         * aarch64-tdep.c: Remove xml self tests.
2265         * amd64-linux-tdep.c: Likewise.
2266         * amd64-tdep.c: Likewise.
2267         * i386-linux-tdep.c: Likewise.
2268         * i386-tdep.c: Likewise.
2269
2270 2019-07-03  Pedro Alves  <palves@redhat.com>
2271
2272         PR cli/24732
2273         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2274         (pipe_cmd_option_defs): New.
2275         (make_pipe_cmd_options_def_group): New.
2276         (pipe_command): Use gdb::option::process_options.
2277         (pipe_command_completer): New function.
2278         (_initialize_cli_cmds): Install completer for "pipe" command.
2279
2280 2019-07-03  Pedro Alves  <palves@redhat.com>
2281
2282         * cli/cli-option.c (union option_value) <string>: New field.
2283         (struct option_def_and_value): Add ctor, move ctor, dtor and
2284         use DISABLE_COPY_AND_ASSIGN.
2285         (option_def_and_value::clear_value): New.
2286         (parse_option, save_option_value_in_ctx, get_val_type_str)
2287         (add_setshow_cmds_for_options): Handle var_string.
2288         * cli-option.h (union option_def::var_address) <string>: New
2289         field.
2290         (struct string_option_def): New.
2291         * maint-test-options.c (struct test_options_opts): Add default
2292         ctor and use DISABLE_COPY_AND_ASSIGN.
2293         <string_opt>: New field.
2294         (test_options_opts::~test_options_opts): New.
2295         (test_options_opts::dump): Also dump "-string".
2296         (test_options_option_defs): Install "string.
2297
2298 2019-07-03  Pedro Alves  <palves@redhat.com>
2299
2300         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2301         option_value with a null enumeration.
2302         (complete_options): Save the option values in the context.
2303         (save_option_value_in_ctx): New, factored out from ...
2304         (process_options): ... here.
2305         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2306         of the function.
2307         * maint-test-options.c (test_options_opts::dump): New, factored
2308         out from ...
2309         (maintenance_test_options_command_mode): ... here.
2310         (maintenance_test_options_command_completion_result): Delete.
2311         (maintenance_test_options_command_completion_text): Update
2312         comment.
2313         (maintenance_show_test_options_completion_result): Change
2314         prototype.  Just print
2315         maintenance_test_options_command_completion_text.
2316         (save_completion_result): New.
2317         (maintenance_test_options_completer_mode): Pass options context to
2318         complete_options, and then save a dump.
2319         (_initialize_maint_test_options): Use add_cmd to install "maint
2320         show test-options-completion-result".
2321
2322 2019-07-03  Pedro Alves  <palves@redhat.com>
2323
2324         * NEWS (New commands): Mention "with" and "maint with".
2325         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2326         (with_command, with_command_completer): New.
2327         (pipe_command): Adjust to new repeat_previous
2328         interface.
2329         (_initialize_cli_cmds): Install the "with" command and its "w"
2330         alias.
2331         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2332         declarations.
2333         * cli/cli-setshow.c (parse_cli_var_uinteger)
2334         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2335         argument strings for all var_types.
2336         (get_setshow_command_value_string): New, factored out from ...
2337         (do_show_command): ... this.
2338         * cli/cli-setshow.h: Include <string>.
2339         (get_setshow_command_value_string): Declare.
2340         * command.h (repeat_previous): Now returns const char *.  Adjust
2341         comment.
2342         * maint.c: Include "cli/cli-cmds.h".
2343         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2344         (_initialize_maint_cmds): Register the "maintenance with" command.
2345         * top.c (repeat_previous): Move bits from pipe_command here:
2346         Return the saved command line, if any; error out if there's no
2347         command to relaunch.
2348
2349 2019-07-03  Pedro Alves  <palves@redhat.com>
2350
2351         * NEWS (New commands): Mention "maint set/show test-settings"
2352         instead of "maint test-settings".
2353         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2354         (maintenance_test_settings_set_list): Rename to ...
2355         (maintenance_set_test_settings_list): ... this.
2356         (maintenance_test_settings_show_list): Rename to  ...
2357         (maintenance_show_test_settings_list): ... this.
2358         (maintenance_test_settings_cmd): Delete.
2359         (maintenance_test_settings_set_cmd): ...
2360         (maintenance_set_test_settings_cmd): ... this.
2361         (maintenance_test_settings_show_cmd): ...
2362         (maintenance_show_test_settings_cmd): ... this.
2363         (maintenance_test_settings_show_value_cmd):
2364         (maintenance_show_test_settings_value_cmd): ... this.
2365         (_initialize_maint_test_settings): No longer install the "maint
2366         test-settings" prefix command.  Rename "maint test-settings set"
2367         to "maint set test-settings", and "maint test-settings show" to
2368         "maint show test-settings".  Adjust all subcommands.
2369
2370 2019-07-03  Pedro Alves  <palves@redhat.com>
2371
2372         * maint-test-settings.c: Fix file's intro comment.  Replace all
2373         references to "test-options" with references to "test-settings",
2374         in comments.
2375
2376 2019-07-03  Pedro Alves  <palves@redhat.com>
2377
2378         * maint-test-settings.c (maintenance_test_settings_xxx)
2379         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2380         New.
2381         (maintenance_test_settings_enums): Use them.
2382         (maintenance_test_settings_enum): Default to
2383         maintenance_test_settings_xxx.
2384         (_initialize_maint_test_settings): Initialize
2385         MAINTENANCE_TEST_SETTINGS_FILENAME.
2386
2387 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2388
2389         * breakpoint.h (remove_breakpoints_inf): Change return type to
2390         void, move function documentation here.
2391         * breakpoint.c (remove_breakpoints_inf): Change return type to
2392         void, move function documentation to header.
2393
2394 2019-07-02  Pedro Alves  <palves@redhat.com>
2395
2396         * NEWS (Completion improvements): Mention "info threads".
2397         * thread.c (struct info_threads_opts, info_threads_option_defs)
2398         (make_info_threads_options_def_group): New.
2399         (info_threads_command): Use gdb::option::process_options.
2400         (info_threads_command_completer): New.
2401         (_initialize_thread): Use gdb::option::build_help to build the
2402         help text for "info threads".
2403
2404 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2405
2406         * defs.h (generic_load): Move from here...
2407         * symfile.h (generic_load): ... to here.  Rename name parameter
2408         to args.
2409         * symfile.c (generic_load): Add comment.
2410
2411 2019-07-01  Tom Tromey  <tromey@adacore.com>
2412
2413         * dwarf2read.c
2414         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2415         declaration of without_params.  Fix formatting.
2416
2417 2019-07-01  Tom Tromey  <tromey@adacore.com>
2418
2419         * ada-exp.y (find_primitive_type): Update.
2420         * ada-lang.h (ada_lookup_symbol): Update.
2421         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2422         parameter.
2423         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2424
2425 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2426
2427         PR breakpoints/24541
2428         * gdbarch.c: Regenerate.
2429         * gdbarch.h: Regenerate.
2430         * gdbarch.sh: Add 'stap_adjust_register'.
2431         * i386-tdep.c: Include '<unordered_set>'.
2432         (i386_stap_adjust_register): New function.
2433         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2434         * stap-probe.c (stap_parse_register_operand): Call
2435         'gdbarch_stap_adjust_register'.
2436
2437 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2438
2439         PR python/24742
2440         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2441         * python/python.c (do_start_initialization): Use 'xmalloc'
2442         instead of 'PyMem_Malloc'.
2443
2444 2019-06-28  Tom Tromey  <tromey@adacore.com>
2445
2446         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2447         for Ada.
2448
2449 2019-06-27  Tom Tromey  <tromey@adacore.com>
2450
2451         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2452         objfile_key.
2453         (arm_find_mapping_symbol, arm_record_special_symbol)
2454         (_initialize_arm_tdep): Update.
2455         (arm_objfile_data_free): Remove.
2456
2457 2019-06-27  Tom Tromey  <tromey@adacore.com>
2458
2459         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2460         to cp_print_static_field.
2461
2462 2019-06-26  Tom Tromey  <tromey@adacore.com>
2463
2464         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2465         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2466         declare.
2467
2468 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2469
2470         * features/aarch64-core.c (create_feature_aarch64_core):
2471         Regenerate.
2472         * features/aarch64-core.xml: Add cpsr flags.
2473
2474 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2475
2476         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2477         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2478
2479 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2480
2481         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2482         field.
2483         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2484         use.
2485         (arm_record_special_symbol): Don't insert new symbol in sorted
2486         position, push it at the end.
2487
2488 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2489
2490         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2491         (arm_mapping_symbol_s): Remove.
2492         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2493         (arm_mapping_symbol_vec): New typedef.
2494         (struct arm_per_objfile): Add constructor.
2495         <section_maps>: Change type to
2496         std::unique_ptr<arm_mapping_symbol_vec[]>.
2497         (arm_compare_mapping_symbols): Remove.
2498         (arm_find_mapping_symbol): Adjust to section_maps type change.
2499         (arm_objfile_data_free): Call delete on arm_per_objfile.
2500         (arm_record_special_symbol): Adjust to section_maps type change.
2501         Allocate arm_per_objfile with new.
2502
2503 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2504
2505         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2506         with the command prefix.
2507
2508 2019-06-25  Tom Tromey  <tom@tromey.com>
2509
2510         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2511         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2516         type.
2517         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2518         protected.
2519
2520 2019-06-25  Tom Tromey  <tom@tromey.com>
2521
2522         * tui/tui-winsource.c
2523         (tui_source_window_base::set_is_exec_point_at): Add check against
2524         LOA_ADDRESS.
2525
2526 2019-06-25  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-source.c (tui_set_source_content): Don't check before
2529         xfree.
2530         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2531
2532 2019-06-25  Tom Tromey  <tom@tromey.com>
2533
2534         * tui/tui-winsource.h (tui_update_source_window_as_is)
2535         (tui_alloc_source_buffer, tui_line_is_displayed)
2536         (tui_addr_is_displayed): Change type of win_info.
2537         * tui/tui-winsource.c (tui_update_source_window_as_is)
2538         (tui_clear_source_content, tui_show_source_line)
2539         (tui_show_source_content, tui_source_window_base::refill)
2540         (tui_source_window_base::set_is_exec_point_at)
2541         (tui_source_window_base::set_is_exec_point_at)
2542         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2543         (tui_alloc_source_buffer, tui_line_is_displayed)
2544         (tui_addr_is_displayed): Change type of win_info.  Update.
2545         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2546         (tui_source_window_base::do_make_visible_with_new_height):
2547         Update.
2548         * tui/tui-source.c (tui_set_source_content)
2549         (tui_set_source_content_nil)
2550         (tui_source_window::do_scroll_vertical): Update.
2551         * tui/tui-layout.c (show_layout): Update.
2552         * tui/tui-disasm.c (tui_set_disassem_content)
2553         (tui_disasm_window::do_scroll_vertical): Update.
2554         * tui/tui-data.h (tui_win_content): Remove.
2555         (struct tui_gen_win_info) <content, content_size>: Remove.
2556         (struct tui_source_element): Add initializers and destructor.
2557         (union tui_which_element, struct tui_win_element): Remove.
2558         (struct tui_source_window_base) <content>: New field.
2559         (struct tui_data_window): Remove destructor.
2560         (tui_alloc_content, tui_free_win_content)
2561         (tui_free_all_source_wins_content): Don't declare.
2562         * tui/tui-data.c (tui_initialize_static_data): Update.
2563         (init_content_element, tui_alloc_content): Remove.
2564         (~tui_gen_win_info): Update.
2565         (~tui_data_window, tui_free_all_source_wins_content)
2566         (tui_free_win_content, free_content, free_content_elements):
2567         Remove.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-winsource.h (tui_clear_source_content)
2572         (tui_erase_source_content, tui_show_source_content): Change type
2573         of win_info.
2574         * tui/tui-winsource.c (tui_clear_source_content)
2575         (tui_erase_source_content, tui_show_source_content): Change type
2576         of win_info.
2577         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2578         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2579         win_info.
2580         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2581         win_info.
2582         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.c (tui_clear_source_content)
2587         (tui_source_window_base::set_is_exec_point_at): Update.
2588         * tui/tui-source.c (tui_set_source_content_nil): Update.
2589         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2590         a bool.
2591         * tui/tui-data.c (init_content_element): Update.
2592
2593 2019-06-25  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2596         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2597         * tui/tui-layout.c (init_and_make_win): Update.
2598         * tui/tui.h (enum tui_win_type): Update.
2599         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2600         tui_win_is_auxillary.
2601         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2602         tui_win_is_auxillary.
2603
2604 2019-06-25  Tom Tromey  <tom@tromey.com>
2605
2606         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2607         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2608         (tui_delete_data_content_windows, tui_display_all_data)
2609         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2610         Update.
2611         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2612         * tui/tui-regs.c (tui_last_regs_line_no)
2613         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2614         (tui_show_registers): Update.
2615         (tui_show_register_group): Return void.  Update.
2616         (tui_display_registers_from, tui_display_reg_element_at_line)
2617         (tui_display_registers_from_line, tui_check_register_values):
2618         Update.
2619         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2620         member.
2621         (struct tui_data_window) <regs_content>: Now a std::vector.
2622         <regs_content_count>: Remove.
2623         (tui_add_content_elements, tui_free_data_content): Don't declare.
2624         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2625         (init_content_element): Remove DATA_WIN case.  Add assert.
2626         (tui_add_content_elements): Remove.
2627         (tui_data_window): Update.
2628         (tui_free_data_content): Remove.
2629         (free_content_elements): Remove DATA_WIN case.
2630
2631 2019-06-25  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-data.c (tui_data_item_window): Update.
2634         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2635         * tui/tui-windata.c (tui_display_all_data)
2636         (tui_display_data_from_line): Update.
2637         (tui_check_data_values): Remove.
2638         * tui/tui-regs.c (tui_show_register_group)
2639         (tui_display_reg_element_at_line): Update.
2640         * tui/tui-hooks.c (tui_register_changed)
2641         (tui_refresh_frame_and_register_information): Call
2642         tui_check_register_values.
2643         * tui/tui-data.h (struct tui_data_window) <data_content,
2644         data_content_count, data_type>: Remove.
2645         (enum tui_data_type): Remove.
2646
2647         * tui/tui-data.c (tui_data_window::clear_detail)
2648         (~tui_data_window): Update.
2649
2650 2019-06-25  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2653         declare.
2654         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2655         Rename from tui_first_data_item_displayed.  Update.
2656         (tui_data_window::refresh_all)
2657         (tui_data_window::do_scroll_vertical): Update.
2658         * tui/tui-data.h (struct tui_data_window)
2659         <first_data_item_displayed>: Declare new method.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2664         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2665         contents...
2666         (tui_initialize_static_data): ...here.
2667
2668 2019-06-25  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2671         (tui_display_registers_from, tui_check_register_values): Update.
2672         (tui_display_register): Remove win_info parameter; update.
2673         (tui_get_register): Change type of parameters.
2674         * tui/tui-data.h (struct tui_data_element): Remove.
2675         (union tui_which_element) <data>: Remove.
2676         <data_window>: Change type.
2677         (struct tui_data_item_window): New.
2678         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2679         case.  Add assert.
2680         (~tui_data_item_window): New destructor.
2681         (free_content_elements): Remove DATA_ITEM_WIN case.
2682
2683 2019-06-25  Tom Tromey  <tom@tromey.com>
2684
2685         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2686         Remove.
2687
2688 2019-06-25  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-data.h (struct tui_command_element): Remove.
2691         (union tui_which_element) <command>: Remove.
2692         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2693         assert.
2694         (free_content_elements): Remove CMD_WIN case.
2695
2696 2019-06-25  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui-layout.c (tui_set_layout): Update.
2699         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2700         * tui/tui-data.c (layout_def): Update.
2701
2702 2019-06-25  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2705         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2706         (tui_source_window_base::set_new_height): Update.
2707         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2708         Update.
2709         (tui_set_locator_fullname, tui_set_locator_info)
2710         (tui_show_frame_info): Update.
2711         * tui/tui-source.c (tui_set_source_content)
2712         (tui_source_is_displayed): Update.
2713         * tui/tui-layout.c (show_source_disasm_command, show_data)
2714         (show_source_or_disasm_and_command): Update.
2715         * tui/tui-disasm.c (tui_set_disassem_content)
2716         (tui_get_begin_asm_address): Update.
2717         * tui/tui-data.h (struct tui_locator_element): Remove.
2718         (union tui_which_element) <locator>: Remove.
2719         (struct tui_locator_window): New.
2720         (tui_locator_win_info_ptr): Change return type.
2721         * tui/tui-data.c (_locator): Change type.
2722         (tui_locator_win_info_ptr): Change return type.
2723         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2724         (tui_alloc_content): Add assert.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-winsource.c
2729         (tui_exec_info_window::maybe_allocate_content): New method.
2730         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2731         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2732         (make_source_or_disasm_window): Add cast.
2733         * tui/tui-data.h (union tui_which_element) <simple_string>:
2734         Remove.
2735         (struct tui_source_info): New.
2736         (struct tui_source_window_base) <execution_info>: Change type.
2737         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2738         case, and add assert.
2739         (tui_alloc_content): Add assert.
2740
2741 2019-06-25  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2744         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2745         * tui/tui-data.c (tui_alloc_win_info): Remove.
2746
2747 2019-06-25  Tom Tromey  <tom@tromey.com>
2748
2749         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2750         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2751         can_highlight.
2752
2753 2019-06-25  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2756         make_visible_with_new_height method.
2757         (tui_win_info::make_visible_with_new_height): New method.
2758         (tui_source_window_base::do_make_visible_with_new_height)
2759         (tui_data_window::do_make_visible_with_new_height)
2760         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2761         (make_visible_with_new_height): Remove.
2762         (tui_resize_all, tui_adjust_win_heights): Use
2763         make_visible_with_new_height method.
2764         * tui/tui-data.h (struct tui_win_info)
2765         <do_make_visible_with_new_height, make_visible_with_new_height>:
2766         New methods.
2767         (struct tui_source_window_base, struct tui_data_window)
2768         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2769         methods.
2770
2771 2019-06-25  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2774         method.
2775         (update_tab_width): Call update_tab_width method.
2776         * tui/tui-data.h (struct tui_win_info)
2777         (struct tui_source_window_base) <update_tab_width>: New methods.
2778
2779 2019-06-25  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2782         parameter.
2783         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2784         parameter.
2785         (tui_gen_win_info::make_visible): Update.
2786         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2787         parameter.
2788         * tui/tui-data.h (enum tui_box): New enum.
2789         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2790
2791 2019-06-25  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2794         init_and_make_win for EXEC_INFO_WIN.
2795         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2796         longer inline.
2797         (struct tui_win_info) <~tui_win_info>: Inline.
2798         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2799         Don't declare.
2800         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2801         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2802         Remove.
2803         (tui_initialize_static_data): Update.
2804         (~tui_gen_win_info): Handle more cleanup here.
2805         (~tui_source_window_base): Delete "execution_info".
2806         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2807
2808 2019-06-25  Tom Tromey  <tom@tromey.com>
2809
2810         * tui/tui-layout.c (make_command_window): Don't set
2811         can_highlight.
2812         (show_source_disasm_command): Call the reset method.
2813         (show_data): Don't set can_highlight.  Call the reset method.
2814         (tui_gen_win_info::reset): Rename from init_gen_win_info
2815         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2816         (show_source_or_disasm_and_command): Call the reset method.
2817         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2818         (struct tui_cmd_window): Set can_highlight.
2819
2820 2019-06-25  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2823         from make_visible.
2824         (tui_make_visible, tui_make_invisible): Rewrite.
2825         (tui_win_info::make_visible): Remove.
2826         (tui_source_window_base::make_visible): Update.
2827         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2828         method.  Moved from...
2829         (struct tui_win_info) <make_visible>: ...here.
2830
2831 2019-06-25  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-winsource.c
2834         (tui_source_window_base::do_scroll_horizontal): Remove direction
2835         parameter.
2836         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2837         direction parameter.
2838         * tui/tui-win.c (tui_win_info::forward_scroll)
2839         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2840         (tui_win_info::right_scroll): Update.
2841         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2842         direction parameter.
2843         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2844         direction parameter.
2845         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2846         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2847         Remove direction parameter.
2848         (struct tui_source_window_base, struct tui_source_window)
2849         (struct tui_disasm_window, struct tui_data_window)
2850         (struct tui_cmd_window): Update.
2851
2852 2019-06-25  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-winsource.h (tui_set_exec_info_content)
2855         (tui_show_exec_info_content, tui_erase_exec_info_content)
2856         (tui_clear_exec_info_content, tui_update_exec_info): Change
2857         argument to tui_source_window_base.
2858         * tui/tui-winsource.c (tui_set_exec_info_content)
2859         (tui_show_exec_info_content, tui_erase_exec_info_content)
2860         (tui_clear_exec_info_content, tui_update_exec_info): Change
2861         argument to tui_source_window_base.
2862
2863 2019-06-25  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2866         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2867
2868 2019-06-25  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2871         check.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2876         type to void.
2877         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2878         type to void.
2879         * tui/tui-source.c (tui_set_source_content): Update.
2880         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2881
2882 2019-06-25  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-win.c (window_name_completer, tui_set_focus)
2885         (tui_all_windows_info): Use name method.
2886         * tui/tui-data.h (struct tui_gen_win_info)
2887         (struct tui_source_window, struct tui_disasm_window)
2888         (struct tui_data_window, struct tui_cmd_window) <name>: New
2889         method.
2890         (tui_win_name): Don't declare.
2891         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2892         (tui_win_name): Remove.
2893
2894 2019-06-25  Tom Tromey  <tom@tromey.com>
2895
2896         * tui/tui-winsource.h (tui_update_source_window)
2897         (tui_update_source_window_as_is): Change parameter type.
2898         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2899         to be a tui_source_window_base.
2900         (tui_update_source_window_as_is): Likewise.
2901         * tui/tui-win.c (make_visible_with_new_height): Update.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-winsource.c (tui_erase_source_content)
2906         (tui_show_source_content, tui_show_exec_info_content)
2907         (tui_erase_exec_info_content): Use refresh_window method.
2908         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2909         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2910         from tui_refresh_win.
2911         (tui_data_window::refresh_window): New method.
2912         (tui_win_info::refresh, tui_source_window_base::refresh)
2913         (tui_refresh_all): Use refresh_window method.
2914         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2915         method.
2916         * tui/tui-regs.c (tui_display_register): Call refresh_window
2917         method.
2918         * tui/tui-layout.c (show_source_disasm_command)
2919         (show_source_or_disasm_and_command): Call refresh_window method.
2920         * tui/tui-data.h (struct tui_gen_win_info)
2921         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2922         New method.
2923
2924 2019-06-25  Tom Tromey  <tom@tromey.com>
2925
2926         * tui/tui.c (tui_rl_other_window, tui_enable)
2927         (tui_is_window_visible, tui_get_command_dimension): Update.
2928         * tui/tui-winsource.c (tui_update_source_window_as_is)
2929         (tui_clear_source_content, tui_erase_source_content)
2930         (tui_show_source_line, tui_source_window_base::refill)
2931         (tui_source_window_base::do_scroll_horizontal)
2932         (tui_source_window_base::set_is_exec_point_at)
2933         (tui_update_breakpoint_info, tui_set_exec_info_content)
2934         (tui_alloc_source_buffer, tui_line_is_displayed)
2935         (tui_addr_is_displayed): Update.
2936         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2937         (tui_check_and_display_highlight_if_needed)
2938         (tui_win_info::make_visible, tui_win_info::refresh)
2939         (tui_refresh_all): Update.
2940         * tui/tui-windata.c (tui_first_data_item_displayed)
2941         (tui_delete_data_content_windows, tui_erase_data_content)
2942         (tui_display_all_data, tui_data_window::refresh_all)
2943         (tui_check_data_values): Update.
2944         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2945         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2946         (tui_win_info::backward_scroll, tui_refresh_all_win)
2947         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2948         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2949         (tui_source_window_base::set_new_height)
2950         (tui_data_window::set_new_height)
2951         (make_invisible_and_set_new_height)
2952         (make_visible_with_new_height, new_height_ok)
2953         (parse_scrolling_args): Update.
2954         * tui/tui-stack.c (tui_show_frame_info): Update.
2955         * tui/tui-source.c (tui_set_source_content)
2956         (tui_set_source_content_nil, tui_source_is_displayed)
2957         (tui_source_window::do_scroll_vertical): Update.
2958         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2959         (tui_display_registers_from, tui_display_reg_element_at_line)
2960         (tui_check_register_values, tui_reg_command): Update.
2961         * tui/tui-layout.c (tui_default_win_height)
2962         (show_source_disasm_command, show_data, init_and_make_win)
2963         (show_source_or_disasm_and_command): Update.
2964         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2965         (tui_redisplay_readline, tui_mld_flush)
2966         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2967         (tui_getc): Update.
2968         * tui/tui-disasm.c (tui_set_disassem_content)
2969         (tui_disasm_window::do_scroll_vertical): Update.
2970         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2971         Now virtual.
2972         (struct tui_win_info): Derive from tui_gen_win_info.
2973         <~tui_win_info>: Mark as override.
2974         <generic>: Remove member.
2975         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2976         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2977         (~tui_data_window, ~tui_win_info)
2978         (tui_free_all_source_wins_content): Update.
2979         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2980
2981 2019-06-25  Tom Tromey  <tom@tromey.com>
2982
2983         * tui/tui-layout.c (init_and_make_win): Use new.
2984         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2985         destructor, initializers.
2986         (tui_alloc_generic_win_info): Don't declare.
2987         * tui/tui-data.c (_locator): Add argument to constructor.
2988         (source_win, disasm_win): New globals.
2989         (exec_info): Remove.
2990         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2991         Update.
2992         (tui_alloc_generic_win_info): Remove.
2993         (init_content_element): Use new.
2994         (tui_win_info::tui_win_info): Update.
2995         (free_content_elements) <case DATA_WIN>: Use delete.
2996
2997 2019-06-25  Tom Tromey  <tom@tromey.com>
2998
2999         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3000         * tui/tui-windata.c (tui_first_data_item_displayed)
3001         (tui_delete_data_content_windows): Update.
3002         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3003         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3004         (tui_display_registers_from, tui_check_register_values): Update.
3005         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3006         pointer.
3007         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3008         window.
3009         (tui_free_data_content): Update.
3010         (free_content_elements) <case DATA_WIN>: Free the window.
3011
3012 2019-06-25  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3015         Update.
3016         * tui/tui-layout.c (make_command_window)
3017         (show_source_disasm_command, show_data, init_and_make_win)
3018         (show_source_or_disasm_and_command): Update.
3019         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3020         method.
3021         <can_highight, is_highlighted>: Now bool.
3022         (tui_set_win_highlight): Don't declare.
3023         * tui/tui-data.c (tui_set_win_highlight): Remove.
3024
3025 2019-06-25  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-wingeneral.c (make_visible): Remove check of window
3028         type.
3029
3030 2019-06-25  Tom Tromey  <tom@tromey.com>
3031
3032         * tui/tui-win.c (tui_win_info::max_height)
3033         (tui_cmd_window::max_height): New methods.
3034         (new_height_ok): Call max_height.
3035         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3036         <max_height>: New method.
3037
3038 2019-06-25  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-win.c (tui_source_window_base::set_new_height)
3041         (tui_data_window::set_new_height): New methods.
3042         (make_invisible_and_set_new_height): Call set_new_height method.
3043         * tui/tui-data.h (struct tui_win_info)
3044         (struct tui_source_window_base, struct tui_data_window)
3045         <set_new_height>: New method.
3046
3047 2019-06-25  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3050         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3051         tui_refresh_data_win.
3052         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3053         method.
3054         (tui_refresh_all_win): Call the refresh_all method.
3055         (tui_set_focus): Likewise.
3056         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3057         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3058         Likewise.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-winsource.h (tui_refill_source_window)
3063         (tui_set_is_exec_point_at): Don't declare.
3064         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3065         (tui_source_window_base::refill): Rename from
3066         tui_refill_source_window.
3067         (tui_source_window_base::do_scroll_horizontal): Update.
3068         (tui_source_window_base::set_is_exec_point_at): Rename from
3069         tui_set_is_exec_point_at.
3070         (tui_update_all_breakpoint_info): Update.
3071         * tui/tui-stack.c (tui_show_frame_info): Update.
3072         * tui/tui-layout.c (show_data): Add cast.
3073         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3074         * tui/tui-data.h (struct tui_source_window_base) <refill,
3075         set_is_exec_point_at>: New methods.
3076         (tui_source_windows, tui_add_to_source_windows): Update types.
3077         (tui_add_to_source_windows): Remove redundant declaration.
3078         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3079         (tui_source_windows): Change return type.
3080         (tui_clear_source_windows_detail): Update.
3081         (tui_add_to_source_windows): Change type of parameter.
3082         (tui_free_all_source_wins_content): Update.
3083
3084 2019-06-25  Tom Tromey  <tom@tromey.com>
3085
3086         * tui/tui-wingeneral.c (tui_win_info::refresh)
3087         (tui_source_window_base::refresh): New methods.
3088         (tui_refresh_all): Call the refresh method.
3089         * tui/tui-data.h (struct tui_win_info)
3090         (struct tui_source_window_base) <refresh>: New method.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui.h (tui_is_window_visible): Return bool.
3095         * tui/tui.c (tui_is_window_visible): Return bool.
3096         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3097         (tui_make_visible, tui_make_invisible)
3098         (tui_win_info::make_visible)
3099         (tui_source_window_base::make_visible, make_all_visible)
3100         (tui_make_all_visible, tui_make_all_invisible): Update.
3101         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3102         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3103         bool.
3104         (struct tui_win_info, struct tui_source_window_base)
3105         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3106         * tui/tui-data.c (tui_init_generic_part): Update.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3111         (tui_source_window_base::make_visible): New methods.
3112         (make_all_visible): Make method call.
3113         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3114         (struct tui_source_window_base, struct tui_cmd_window): Override
3115         make_visible.
3116         (tui_win_is_source_type): Don't declare.
3117         * tui/tui-data.c (tui_win_is_source_type): Remove.
3118
3119 2019-06-25  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3122         NULL check.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3127         Inline constructor.  Add initializers for members.
3128         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3129         constructors; now inline in class.
3130
3131 2019-06-25  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-regs.c (tui_show_registers): Update.
3134         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3135         bool.
3136         * tui/tui-data.c (tui_data_window::clear_detail)
3137         (tui_data_window): Update.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-windata.c (tui_display_all_data)
3142         (tui_display_data_from_line, tui_display_data_from)
3143         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3144         Update.
3145         * tui/tui-regs.c (tui_last_regs_line_no)
3146         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3147         (tui_show_registers, tui_show_register_group)
3148         (tui_display_registers_from, tui_display_reg_element_at_line)
3149         (tui_display_registers_from_line, tui_check_register_values)
3150         (tui_reg_next, tui_reg_prev): Update.
3151         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3152         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3153         tui_data_window.
3154         (struct tui_win_info) <detail>: Remove.  Add new fields from
3155         tui_data_info.
3156         (TUI_DATA_WIN): Add cast.
3157         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3158         (~tui_data_window): Simplify.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-layout.c (show_source_disasm_command)
3163         (show_source_or_disasm_and_command): Update.
3164         * tui/tui-io.c (update_cmdwin_start_line)
3165         (tui_redisplay_readline): Update.
3166         * tui/tui-data.h (struct tui_command_info): Remove.
3167         (struct tui_win_info) <detail>: Remove command_info member.
3168         (struct tui_data_window) <start_line>: New member, from
3169         tui_command_info.
3170         (TUI_CMD_WIN): Add casts.
3171
3172 2019-06-25  Tom Tromey  <tom@tromey.com>
3173
3174         * tui/tui-winsource.c (tui_update_source_window)
3175         (tui_refill_source_window)
3176         (tui_source_window_base::do_scroll_horizontal)
3177         (tui_update_breakpoint_info, tui_set_exec_info_content)
3178         (tui_show_exec_info_content, tui_erase_exec_info_content)
3179         (tui_clear_exec_info_content): Update.
3180         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3181         Update.
3182         * tui/tui-win.c (make_invisible_and_set_new_height)
3183         (make_visible_with_new_height): Update.
3184         * tui/tui-source.c (tui_set_source_content)
3185         (tui_show_symtab_source): Update.
3186         * tui/tui-layout.c (extract_display_start_addr)
3187         (show_source_disasm_command, show_data)
3188         (make_source_or_disasm_window)
3189         (show_source_or_disasm_and_command): Update.
3190         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3191         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3192         "gdbarch".
3193         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3194         to tui_source_window_base.
3195         (struct tui_win_info) <detail>: Remove source_info member.
3196         (struct tui_source_window_base) <has_locator>: Inline.
3197         Move contents from tui_source_info; rename has_locator member to
3198         m_has_locator.
3199         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3200         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3201         header file.
3202         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3203         Simplify.
3204         (tui_free_all_source_wins_content): Cast to
3205         tui_source_window_base.
3206
3207 2019-06-25  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-win.c (make_invisible_and_set_new_height)
3210         (make_visible_with_new_height): Call has_locator method.
3211         * tui/tui-layout.c (show_source_disasm_command, show_data)
3212         (show_source_or_disasm_and_command): Update for bool change.
3213         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3214         (tui_win_info) <has_locator>: New method.
3215         (struct tui_source_window_base) <has_locator>: New method.
3216         (tui_win_has_locator): Don't declare.
3217         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3218         from tui_win_has_locator.
3219         (tui_source_window_base): Use false, not FALSE.
3220
3221 2019-06-25  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3224         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3225         clear_detail method directly.
3226         (tui_clear_win_detail): Remove.
3227
3228 2019-06-25  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3231         "this", not TUI_DISASM_WIN.
3232
3233 2019-06-25  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3236         declare.
3237         * tui/tui-winsource.c
3238         (tui_source_window_base::do_scroll_horizontal): Rename from
3239         tui_horizontal_source_scroll.
3240         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3241         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3242         from tui_vertical_data_scroll.
3243         * tui/tui-win.h (tui_scroll): Don't declare.
3244         * tui/tui-win.c (tui_win_info::forward_scroll)
3245         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3246         (tui_win_info::right_scroll): Rename and update.
3247         (tui_scroll_forward_command, tui_scroll_backward_command)
3248         (tui_scroll_left_command, tui_scroll_right_command): Update.
3249         (tui_scroll): Remove.
3250         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3251         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3252         from tui_vertical_source_scroll.
3253         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3254         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3255         from tui_vertical_disassem_scroll.
3256         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3257         do_scroll_horizontal>: New methods.
3258         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3259         Likewise.
3260         (struct tui_source_window_base): Add do_scroll_horizontal.
3261         (struct tui_source_window, struct tui_disasm_window): Add
3262         do_scroll_vertical.
3263         (struct tui_data_window, struct tui_cmd_window): Add
3264         do_scroll_horizontal and do_scroll_vertical.
3265         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-data.h (struct tui_source_window_base): New struct.
3270         (struct tui_source_window): Derive from tui_source_window_base.
3271         (struct tui_disasm_window): New struct.
3272         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3273         from tui_source_window::clear_detail.
3274         (tui_source_window_base): Rename from tui_source_window.
3275         (~tui_source_window_base): Rename from ~tui_source_window.
3276         (tui_alloc_win_info): Create a tui_disasm_window.
3277
3278 2019-06-25  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-data.h (struct tui_source_window)
3281         (struct tui_data_window): Declare destructors.
3282         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3283         destructors.
3284         (tui_win_info): Simplify.
3285
3286 2019-06-25  Tom Tromey  <tom@tromey.com>
3287
3288         * tui/tui-winsource.c (tui_display_main)
3289         (tui_update_source_windows_with_addr)
3290         (tui_update_all_breakpoint_info): Update.
3291         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3292         (new_height_ok, parse_scrolling_args): Update.
3293         * tui/tui-stack.c (tui_show_frame_info): Update.
3294         * tui/tui-data.h (struct tui_list): Remove.
3295         (tui_source_windows): Return a reference to a std::vector.
3296         * tui/tui-data.c (source_windows): Now a std::vector.
3297         (tui_source_windows): Change return type.
3298         (tui_clear_source_windows): Rewrite.
3299         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3300         (tui_free_all_source_wins_content): Rewrite.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3305         (struct tui_data_window, struct tui_cmd_window): Declare
3306         clear_detail method.
3307         * tui/tui-data.c (tui_source_window::clear_detail)
3308         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3309         methods.
3310         (tui_clear_win_detail): Simplify.
3311
3312 2019-06-25  Tom Tromey  <tom@tromey.com>
3313
3314         * tui/tui-layout.c (make_source_window, make_disasm_window)
3315         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3316         Return the new window.
3317         (show_source_disasm_command, show_data)
3318         (show_source_or_disasm_and_command): Update.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3323         parameter.  Return the new window.
3324         (show_source_disasm_command): Update and remove NULL check.
3325         (show_source_or_disasm_and_command): Update.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3330
3331 2019-06-25  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-data.h (struct tui_win_info): Make constructor
3334         protected.  Make destructor virtual.  Add initializers.
3335         (tui_source_window, tui_data_window, tui_cmd_window): New
3336         classes.
3337         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3338         constructor.  Add "type" parameter.
3339         (tui_source_window, tui_data_window, tui_cmd_window): New
3340         constructors.
3341         (tui_alloc_win_info): Instantiate the appropriate subclass.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-win.c (tui_resize_all): Use delete.
3346         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3347         destructor.
3348         (tui_free_window): Don't declare.
3349         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3350         Update.
3351
3352 2019-06-25  Tom Tromey  <tom@tromey.com>
3353
3354         * tui/tui-data.h (struct tui_win_info): Add constructor.
3355         * tui/tui-data.c (tui_alloc_win_info): Use new.
3356         (tui_free_window): Use delete.
3357
3358 2019-06-22  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3361         declare.
3362         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3363
3364 2019-06-22  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3367         declare.
3368         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3369
3370 2019-06-22  Tom de Vries  <tdevries@suse.de>
3371
3372         * dwarf2read.c (create_addrmap_from_aranges)
3373         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3374         instead of '%zu'.
3375
3376 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3377
3378         * dwarf2read.h (dwarf2_section_info_def): Remove.
3379         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3380         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3381         std::vector<dwarf2_section_info>.
3382         (struct dwo_file) <~dwo_file>: Remove.
3383         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3384         types field.
3385         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3386         (dwarf2_read_debug_names): Likewise.
3387         (create_debug_types_hash_table): Change parameter type to
3388         array_view, adjust code accordingly.
3389         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3390         (partial_die_info::fixup): Likewise.
3391         (determine_prefix): Likewise.
3392         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3393
3394 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3395
3396         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3397         gdb_bfd_ref_ptr.
3398         <~dwo_file>: Remove call to gdb_bfd_unref.
3399         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3400         gdb_bfd_ref_ptr::get.
3401
3402 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3403
3404         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3405         type to htab_up.
3406         * dwarf2read.c (struct dwo_file): Initialize fields.
3407         <~dwo_file>: New.
3408         (free_dwo_file): Remove, move content to ~dwo_file.
3409         (struct dwo_file_deleter): Remove.
3410         (dwo_file_up>: Remove custom deleter.
3411         (free_dwo_files): Remove.
3412         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3413         dwo_files.
3414         (process_skeletonless_type_units): Call unique_ptr::get.
3415         (allocate_dwo_file_hash_table): Add deleter to created hash
3416         table.  Change return type to htab_up.
3417         (lookup_dwo_file_slot): Don't memset dwo_file, call
3418         unique_ptr::get.
3419         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3420         (create_dwo_unit_in_dwp_v2): Likewise.
3421         (open_and_init_dwo_file): Likewise.
3422         (free_dwo_file_from_slot): Remove.
3423
3424 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3425
3426         * dwarf2read.h (struct dwarf2_section_info) <readin,
3427         is_virtual>: Change type to bool.
3428         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3429         true instead of 1.
3430
3431 2019-06-19  Tom Tromey  <tom@tromey.com>
3432
3433         * tui/tui-data.h (tui_init_content_element): Don't declare.
3434
3435 2019-06-19  Tom Tromey  <tom@tromey.com>
3436
3437         * tui/tui-data.h (tui_init_win_info): Don't declare.
3438
3439 2019-06-19  Tom de Vries  <tdevries@suse.de>
3440
3441         * dwarf2read.h (abstract_to_concrete): Change type to
3442         std::unordered_map<sect_offset, std::vector<sect_offset>,
3443         gdb::hash_enum<sect_offset>>.
3444
3445 2019-06-19  Tom Tromey  <tromey@adacore.com>
3446
3447         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3448         EVAL_AVOID_SIDE_EFFECTS specially.
3449
3450 2019-06-19  Tom Tromey  <tromey@adacore.com>
3451
3452         * source-cache.c (highlighter): New global.
3453         (source_cache::get_source_lines): Create a highlighter on demand.
3454
3455 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * defs.h (deprecated_interactive_hook): Delete declaration.
3458         * interps.c (clear_interpreter_hooks): Remove use of
3459         deprecated_interactive_hook.
3460         * top.c (deprecated_interactive_hook): Delete definition.
3461         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3462
3463 2019-06-18  Tom de Vries  <tdevries@suse.de>
3464
3465         PR gdb/24515
3466         * dwarf2read.h (abstract_to_concrete): Change type from
3467         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3468         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3469         * dwarf2read.c (read_variable): Update.
3470         (dwarf2_fetch_die_loc_sect_off): Update.
3471
3472 2019-06-17  Tom de Vries  <tdevries@suse.de>
3473
3474         PR gdb/24617
3475         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3476         accessing parent[parent_len - 1].
3477
3478 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3479
3480         PR gdb/24364
3481         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3482         call dtrace_process_dof with NULL dof.
3483
3484 2019-06-16  Tom de Vries  <tdevries@suse.de>
3485
3486         PR gdb/24445
3487         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3488
3489 2019-06-16  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3492         (make_all_visible): Use address of member.
3493
3494 2019-06-16  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3497         (tui_free_window, free_content, free_content_elements): Remove
3498         unnecessary cast.
3499         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3500         cast.
3501         * tui/tui-regs.c (tui_show_register_group)
3502         (tui_display_registers_from, tui_display_reg_element_at_line):
3503         Remove unnecessary cast.
3504
3505 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3506
3507         * linux-nat.c (normal_mask): Delete.
3508         (_initialize_linux_nat): Don't initialise normal_mask.
3509
3510 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3511
3512         PR gdb/24445
3513         * dwarf-index-write.h (write_psymtabs_to_index): Add
3514         dwz_basename parameter.
3515         * dwarf-index-write.c (write_gdbindex): Move file writing to
3516         write_gdbindex_1.  Change return type void.
3517         (assert_file_size): Move up, remove filename parameter.
3518         (write_gdbindex_1): New function.
3519         (write_debug_names): Change return type to void, call
3520         assert_file_size.
3521         (struct index_wip_file): New struct.
3522         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3523         file logic to index_wip_file.  Write index for dwz file if
3524         needed.
3525         (save_gdb_index_command): Pass basename of dwz file, if present.
3526         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3527         build-id of dwz file, if present.
3528         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3529         (dwarf2_get_dwz_file): Likewise.
3530         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3531         (dwarf2_get_dwz_file): Likewise.
3532
3533 2019-06-16  Tom Tromey  <tom@tromey.com>
3534
3535         * coffread.c (process_coff_symbol): Use xstrdup.
3536         * value.c (create_internalvar): Use xstrdup.
3537
3538 2019-06-16  Tom Tromey  <tom@tromey.com>
3539
3540         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3541         * breakpoint.c (stopin_command, stopat_command)
3542         (until_break_command, decode_location_default): Remove unnecessary
3543         cast.
3544         * utils.c (subset_compare): Remove unnecessary cast.
3545         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3546         cast.
3547         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3548         cast.
3549         * infcmd.c (path_command): Remove unnecessary cast.
3550         * coffread.c (decode_type): Remove unnecessary cast.
3551         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3552         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3553         * tui/tui-stack.c (tui_show_locator_content)
3554         (tui_show_frame_info): Remove unnecessary cast.
3555         * tui/tui-win.c (tui_scroll_forward_command)
3556         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3557         (parse_scrolling_args): Remove unnecessary cast.
3558         * tui/tui-data.c (init_win_info, tui_del_window)
3559         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3560         (free_content_elements): Remove unnecessary cast.
3561         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3562         unnecessary cast.
3563         * tui/tui-source.c (tui_set_source_content)
3564         (tui_vertical_source_scroll): Remove unnecessary cast.
3565         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3566         cast.
3567         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3568         * tui/tui-regs.c (tui_display_registers_from)
3569         (tui_display_register): Remove unnecessary cast.
3570         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3571         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3572         (make_visible): Remove unnecessary cast.
3573         * tui/tui-winsource.c (tui_erase_source_content)
3574         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3575         unnecessary cast.
3576         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3577         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3578         * stabsread.c (read_type, read_array_type, read_range_type):
3579         Remove unnecessary cast.
3580         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3581         (parse_symbol, parse_type, upgrade_type, parse_external)
3582         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3583         unnecessary cast.
3584         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3585
3586 2019-06-16  Tom Tromey  <tom@tromey.com>
3587
3588         * tui/tui-data.c (tui_alloc_generic_win_info)
3589         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3590         checks.
3591
3592 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3593             Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * f-typeprint.c (f_print_type): Don't return early for not
3596         associated or not allocated types.
3597         (f_type_print_varspec_suffix): Add print_rank parameter and print
3598         ranks of array types in case they dangling.
3599         (f_type_print_base): Add print_rank parameter.
3600
3601 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3602
3603         * NEWS: Mention new MI commands.
3604         * break-catch-throw.c (enum exception_event_kind): Move to
3605         breakpoint.h.
3606         (print_mention_exception_catchpoint): Output text as a single
3607         message.
3608         (catch_exception_command_1): Rename to...
3609         (catch_exception_event): ...this, make non-static, update header
3610         command, and change some parameter types.
3611         (catch_catch_command): Update for changes to
3612         catch_exception_command_1.
3613         (catch_throw_command): Likewise.
3614         (catch_rethrow_command): Likewise.
3615         * breakpoint.c (enum exception_event_kind): Delete.
3616         * breakpoint.h (enum exception_event_kind): Moved here from
3617         break-catch-throw.c.
3618         (catch_exception_event): Declare.
3619         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3620         (mi_cmd_catch_throw): New function.
3621         (mi_cmd_catch_rethrow): New function.
3622         (mi_cmd_catch_catch): New function.
3623         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3624         'catch-catch' entries.
3625         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3626         (mi_cmd_catch_rethrow): Declare.
3627         (mi_cmd_catch_catch): Declare.
3628
3629 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * annotate.c (annotate_source_line): Change return type to void,
3632         update implementation to match.
3633         * annotate.h (annotate_source_line): Change return type to void,
3634         update header comment.
3635         * stack.c (print_frame_info): Don't change what frame information
3636         is printed based on whether annotations are on or not.
3637
3638 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3639
3640         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3641         (annotate_source): Make static.
3642         (annotate_source_line): Moved from source.c and renamed from
3643         identify_source_line.  Update the return type.
3644         * annotate.h (annotate_source): Delete declaration.
3645         (annotate_source_line): Declaration moved from source.h, and
3646         renamed from identify_source_line.  Return type updated.
3647         * source.c (identify_source_line): Moved to annotate.c and renamed
3648         to annotate_source_line.
3649         (info_line_command): Remove check of annotation_level.
3650         * source.h (identify_source_line): Move declaration to annotate.h
3651         and rename to annotate_source_line.
3652         * stack.c: Add 'annotate.h' include.
3653         (print_frame_info): Remove check of annotation_level before
3654         calling annotate_source_line.
3655
3656 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3657
3658         * source-cache.c (source_cache::get_plain_source_lines): Use
3659         open_source_file_with_line_charpos instead of just
3660         open_source_file, remove call to find_source_lines.
3661         (source_cache::get_source_lines): Likewise.
3662         * source.c (find_source_lines): Make static.
3663         (get_filename_and_charpos): Renamed into...
3664         (open_source_file_with_line_charpos): ..this along with changes to
3665         return a scoped_fd, and some other minor clean ups.
3666         (identify_source_line): Use open_source_file_with_line_charpos.
3667         (search_command_helper): Use open_source_file_with_line_charpos
3668         instead of just open_source_file, remove call to
3669         find_source_lines.
3670         * source.h (open_source_file_with_line_charpos): Declare new
3671         function.
3672         (find_source_lines): Delete declaration.
3673
3674 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * source.c (get_filename_and_charpos): Remove fullname
3677         parameter.
3678         (identify_source_line): Update call to get_filename_and_charpos.
3679
3680 2019-06-14  Tom Tromey  <tromey@adacore.com>
3681
3682         PR gdb/24502:
3683         * ui-style.h (skip_ansi_escape): Update comment.
3684         * ui-file.h (class no_terminal_escape_file): New class.
3685         * ui-file.c (no_terminal_escape_file::write)
3686         (no_terminal_escape_file::puts): New methods.
3687         * cli/cli-logging.c (handle_redirections): Use
3688         no_terminal_escape_file.
3689
3690 2019-06-14  Tom Tromey  <tromey@adacore.com>
3691
3692         * NEWS: Move convenience variable news above Python news.
3693
3694 2019-06-14  Tom Tromey  <tom@tromey.com>
3695
3696         * gnulib: Move directory to top-level.
3697         * configure.ac: Don't configure gnulib.
3698         * configure: Rebuild.
3699         * common/common-defs.h: Use new path to gnulib.
3700         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3701         (GNULIB_H): Remove.
3702         (INCGNU): Look in new gnulib location.
3703         (HFILES_NO_SRCDIR): Remove gnulib files.
3704         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3705         (generated_files): Remove GNULIB_H.
3706         ($(LIBGNU), all-lib): Remove targets.
3707         (distclean): Don't mention GNULIB_BUILDDIR.
3708         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3709
3710 2019-06-14  Tom Tromey  <tromey@adacore.com>
3711
3712         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3713         Warn if symbol file does not provide any symbols.
3714
3715 2019-06-14  Tom Tromey  <tromey@adacore.com>
3716
3717         * source.c (find_and_open_source): Respect basenames_may_differ.
3718
3719 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * annotate.c (annotate_breakpoints_invalid): Make use of
3722         scoped_restore_terminal_state.
3723         (annotate_frames_invalid): Likewise.
3724
3725 2019-06-14  Tom Tromey  <tromey@adacore.com>
3726
3727         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3728         allow assignment to an internalvar.
3729
3730 2019-06-14  Tom Tromey  <tromey@adacore.com>
3731
3732         * ada-lex.l: Allow "_" in attribute names.
3733
3734 2019-06-14  Tom Tromey  <tromey@adacore.com>
3735
3736         PR gdb/24653:
3737         * regcache.c (registers_changed): Don't call alloca.
3738         * top.c (execute_command): Don't call alloca.
3739
3740 2019-06-13  Pedro Alves  <palves@redhat.com>
3741
3742         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3743         'expression'.  When parsing an expression, error out if there's
3744         junk after "unlimited".
3745         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3746         (do_set_command): Adjust calls to is_unlimited_literal.
3747
3748 2019-06-13  Pedro Alves  <palves@redhat.com>
3749
3750         * compile/compile.c (make_compile_options_def_group): Add braces
3751         around array_view initializer.
3752         * thread.c (make_thread_apply_all_options_def_group)
3753         (make_thread_apply_all_options_def_group): Likewise.
3754
3755 2019-06-13  Pedro Alves  <palves@redhat.com>
3756
3757         * NEWS (New commands): Mention "maint test-options
3758         require-delimiter", "maint test-options unknown-is-error", "maint
3759         test-options unknown-is-operand" and "maint show
3760         test-options-completion-result".
3761         (New command options, command completion): New section.
3762         (Completion improvements): New section.
3763         Mention that you can abbreviate "unlimited".
3764
3765 2019-06-13  Pedro Alves  <palves@redhat.com>
3766
3767         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3768         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3769         * unittests/cli-utils-selftests.c (test_parse_flags)
3770         (test_parse_flags_qcs): Delete.
3771         (test_cli_utils): Don't call deleted functions.
3772
3773 2019-06-13  Pedro Alves  <palves@redhat.com>
3774
3775         * thread.c: Include "cli/cli-option.h".
3776         (tp_array_compar_ascending): Global.
3777         (tp_array_compar): Delete function.
3778         (tp_array_compar_ascending, tp_array_compar_descending): New
3779         functions.
3780         (ascending_option_def, qcs_flag_option_def)
3781         (thr_qcs_flags_option_defs)
3782         (make_thread_apply_all_options_def_group)
3783         (make_thread_apply_options_def_group): New.
3784         (thread_apply_all_command): Use gdb::option::process_options.
3785         (thread_apply_command_completer)
3786         (thread_apply_all_command_completer): New.
3787         (thread_apply_command): Use gdb::option::process_options.
3788         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3789         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3790         to generate help text of "thread apply".  Adjust "taas"'s help.
3791         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3792         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3793
3794 2019-06-13  Pedro Alves  <palves@redhat.com>
3795
3796         * thread.c (thread_apply_command): Check for invalid TID with
3797         isdigit instead of !isalpha.
3798
3799 2019-06-13  Pedro Alves  <palves@redhat.com>
3800
3801         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3802         (validate_flags_qcs): New.
3803         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3804         (validate_flags_qcs): Declare.
3805         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3806         (make_frame_apply_options_def_group): New.
3807         (frame_apply_command_count): Process options with
3808         gdb::option::process_options.
3809         (frame_apply_completer): New.
3810         (frame_apply_level_completer, frame_apply_all_completer)
3811         (frame_apply_completer): New.
3812         (_initialize_stack): Update help of "frame apply", "frame apply
3813         level", "frame apply all" and "faas" to mention supported options
3814         and install command completers.
3815         * stack.h (frame_apply_all_completer): Declare.
3816         * thread.c: Include "stack.h".
3817         (tfaas_command): Add "--".
3818         (_initialize_thread): Update help "tfaas" to mention supported
3819         options and install command completer.
3820
3821 2019-06-13  Pedro Alves  <palves@redhat.com>
3822
3823         * completer.c (complete_nested_command_line): New.
3824         (gdb_completion_word_break_characters_throw): Add assertion.
3825         * completer.h (complete_nested_command_line): Declare.
3826
3827 2019-06-13  Pedro Alves  <palves@redhat.com>
3828
3829         * stack.c (parse_backtrace_qualifiers): New.
3830         (backtrace_command): Use it.
3831         (backtrace_command_completer): Complete on qualifiers.
3832
3833 2019-06-13  Pedro Alves  <palves@redhat.com>
3834
3835         * frame.c: Include "cli/cli-option.h.
3836         (user_set_backtrace_options): New.
3837         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3838         Delete.
3839         (get_prev_frame): Adjust.
3840         (boolean_option_def, uinteger_option_def)
3841         (set_backtrace_option_defs): New.
3842         (_initialize_frame): Adjust and use
3843         gdb::option::add_setshow_cmds_for_options to install "set
3844         backtrace past-main" and "set backtrace past-entry".
3845         * frame.h: Include "cli/cli-option.h".
3846         (struct frame_print_options): Forward declare.
3847         (print_frame_arguments_all, print_frame_arguments_scalars)
3848         (print_frame_arguments_none): Declare.
3849         (print_entry_values): Delete declaration.
3850         (struct frame_print_options, user_frame_print_options): New.
3851         (struct set_backtrace_options): New.
3852         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3853         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3854         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3855         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3856         (list_args_or_locals): Add frame_print_options parameter.
3857         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3858         * python/py-framefilter.c (enumerate_args): Pass down
3859         USER_FRAME_PRINT_OPTIONS.
3860         * stack.c: Include "cli/cli-option.h".
3861         (print_frame_arguments_all, print_frame_arguments_scalars)
3862         (print_frame_arguments_none): Declare.
3863         (print_raw_frame_arguments, print_entry_values): Delete.
3864         (user_frame_print_options): New.
3865         (boolean_option_def, enum_option_def, frame_print_option_defs):
3866         New.
3867         (struct backtrace_cmd_options): New.
3868         (bt_flag_option_def): New.
3869         (backtrace_command_option_defs): New.
3870         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3871         (print_frame_arg, read_frame_arg, print_frame_args)
3872         (print_frame_info, print_frame): Add frame_print_options parameter
3873         and use it.
3874         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3875         (backtrace_command_1): Add frame_print_options and
3876         backtrace_cmd_options parameters and use them.
3877         (make_backtrace_options_def_group): New.
3878         (backtrace_command): Process command options with
3879         gdb::option::process_options.
3880         (backtrace_command_completer): New.
3881         (_initialize_stack): Extend "backtrace"'s help to mention
3882         supported options.  Install completer for "backtrace".
3883         Install some settings commands with add_setshow_cmds_for_options.
3884
3885 2019-06-13  Pedro Alves  <palves@redhat.com>
3886
3887         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3888         and that "set/show print raw frame-arguments" are now deprecated.
3889
3890         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3891         command.
3892         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3893         * stack.c (_initialize_stack): Install "set/show print
3894         raw-frame-arguments", and deprecate "set/show print raw
3895         frame-arguments".
3896         * valprint.c (_initialize_valprint): Deprecate "set/show print
3897         raw".
3898
3899 2019-06-13  Pedro Alves  <palves@redhat.com>
3900
3901         * compile/compile.c (struct compile_options): New.
3902         (compile_flag_option_def, compile_command_option_defs)
3903         (make_compile_options_def_group): New.
3904         (compile_file_command): Handle options with
3905         gdb::option::process_options.
3906         (compile_file_command_completer): New function.
3907         (compile_code_command): Handle options with
3908         gdb::option::process_options.
3909         (compile_code_command_completer): New function.
3910         (_initialize_compiler): Install completers for "compile code" and
3911         "compile file".  Mention available options in "compile code" and
3912         "compile code"'s help.
3913         * completer.c (advance_to_completion_word): New, factored out from
3914         ...
3915         (advance_to_expression_complete_word_point): ... this.
3916         (advance_to_filename_complete_word_point): New.
3917         * completer.h (advance_to_filename_complete_word_point): New
3918         declaration.
3919
3920 2019-06-13  Pedro Alves  <palves@redhat.com>
3921
3922         * compile/compile.c: Include "cli/cli-option.h".
3923         (compile_print_value): Scope data pointer is now a
3924         value_print_options pointer; adjust.
3925         (compile_print_command): Process options.  Scope data pointer is
3926         now a value_print_options pointer; adjust.
3927         (_initialize_compile): Update "compile print"'s help to include
3928         supported options.  Install a completer for "compile print".
3929         * cp-valprint.c (show_vtblprint, show_objectprint)
3930         (show_static_field_print): Delete.
3931         (_initialize_cp_valprint): Don't install "set print
3932         static-members", "set print vtbl", "set print object" here.
3933         * printcmd.c: Include "cli/cli-option.h" and
3934         "common/gdb_optional.h".
3935         (print_command_parse_format): Rework to fill in a
3936         value_print_options instead of a format_data.
3937         (print_value): Change parameter type from format_data pointer to
3938         value_print_options reference.  Adjust.
3939         (print_command_1): Process options.  Adjust to pass down a
3940         value_print_options.
3941         (print_command_completer): New.
3942         (_initialize_printcmd): Install print_command_completer as
3943         handle_brkchars completer for the "print" command.  Update
3944         "print"'s help to include supported options.
3945         * valprint.c: Include "cli/cli-option.h".
3946         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3947         here from cp-valprint.c.
3948         (boolean_option_def, uinteger_option_def)
3949         (value_print_option_defs, make_value_print_options_def_group):
3950         New.  Use gdb::option::add_setshow_cmds_for_options to install
3951         "set print elements", "set print null-stop", "set print repeats",
3952         "set print pretty", "set print union", "set print array", "set
3953         print address", "set print symbol", "set print array-indexes".
3954         * valprint.h: Include <string> and "cli/cli-option.h".
3955         (make_value_print_options_def_group): Declare.
3956         (print_value): Change parameter type from format_data pointer to
3957         value_print_options reference.
3958         (print_command_completer): Declare.
3959
3960 2019-06-13  Pedro Alves  <palves@redhat.com>
3961
3962         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3963         (COMMON_SFILES): Add maint-test-settings.c.
3964         * cli/cli-decode.c (boolean_enums): New global, factored out from
3965         ...
3966         (add_setshow_boolean_cmd): ... here.
3967         * cli/cli-decode.h (boolean_enums): Declare.
3968         * cli/cli-option.c: New file.
3969         * cli/cli-option.h: New file.
3970         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3971         factored out from ...
3972         (parse_cli_boolean_value(const char *)): ... this.
3973         (is_unlimited_literal): Change parameter type to pointer to
3974         pointer.  Adjust and advance ARG pointer.
3975         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3976         (parse_cli_var_enum): New, factored out from ...
3977         (do_set_command): ... this.  Adjust.
3978         * cli/cli-setshow.h (parse_cli_boolean_value)
3979         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3980         (parse_cli_var_enum): Declare.
3981         * cli/cli-utils.c: Include "cli/cli-option.h".
3982         (get_ulongest): New.
3983         * cli/cli-utils.h (get_ulongest): Declare.
3984         (check_for_argument): New overloads.
3985         * maint-test-options.c: New file.
3986
3987 2019-06-13  Pedro Alves  <palves@redhat.com>
3988
3989         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3990         parse a range if "-" is at the end of the string.
3991
3992 2019-06-13  Pedro Alves  <palves@redhat.com>
3993
3994         * cli/cli-setshow.c (parse_auto_binary_operation)
3995         (parse_cli_boolean_value): Don't allow "o".
3996
3997 2019-06-13  Pedro Alves  <palves@redhat.com>
3998
3999         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4000         * NEWS: Mention maint test-settings KIND.
4001         * maint-test-settings.c: New file.
4002
4003 2019-06-13  Pedro Alves  <palves@redhat.com>
4004
4005         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4006         completer.
4007         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4008         "set" completers.
4009
4010 2019-06-13  Pedro Alves  <palves@redhat.com>
4011
4012         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4013         after item.
4014
4015 2019-06-13  Pedro Alves  <palves@redhat.com>
4016
4017         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4018
4019 2019-06-13  Pedro Alves <palves@redhat.com>
4020
4021         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4022         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4023         call.
4024         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4025         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4026         calls.
4027         (check_for_argument): Skip spaces after argument.
4028
4029 2019-06-13  Pedro Alves  <palves@redhat.com>
4030
4031         * thread.c (thread_apply_command): Adjust TID parsing.
4032         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4033         detected before end of string.
4034         (tid_is_in_list): Error out if LIST is invalid.
4035
4036 2019-06-13  Pedro Alves  <palves@redhat.com>
4037
4038         * completer.c (complete_line_internal_1): Rewind completion word
4039         point.
4040         (completion_tracker::advance_custom_word_point_by): Change
4041         parameter type to int.
4042         * completer.h (completion_tracker::advance_custom_word_point_by):
4043         Likewise.
4044
4045 2019-06-13  Pedro Alves  <palves@redhat.com>
4046
4047         * completer.c (advance_to_completion_word): Handle delimiters.
4048
4049 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4050
4051         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4052
4053 2019-06-11  Tom Tromey  <tom@tromey.com>
4054
4055         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4056         (xmalloc_failed): Move to alloc.c.
4057         * alloc.c: New file.
4058         * Makefile.in (COMMON_SFILES): Add alloc.c.
4059
4060 2019-06-11  Tom Tromey  <tom@tromey.com>
4061
4062         * nat/linux-waitpid.c: Don't include server.h.
4063         (linux_debug): Remove.
4064         (my_waitpid): Update.
4065
4066 2019-06-11  Tom Tromey  <tromey@adacore.com>
4067
4068         * infcall.c (_initialize_infcall): Remove trailing newline from
4069         help.
4070         * user-regs.c (_initialize_user_regs): Remove trailing newline
4071         from help.
4072         * typeprint.c (_initialize_typeprint): Remove trailing newline
4073         from help.
4074         * reverse.c (_initialize_reverse): Remove trailing newlines from
4075         help.
4076         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4077         from help.
4078         * language.c (add_set_language_command): Remove trailing newline
4079         from help.
4080         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4081         help.
4082         * disasm.c (_initialize_disasm): Remove trailing newline from
4083         help.
4084         * top.c (init_main): Remove trailing newline from help.
4085         * interps.c (_initialize_interpreter): Remove trailing newline
4086         from help.
4087         * btrace.c (_initialize_btrace): Remove trailing newlines from
4088         help.
4089         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4090         from help.
4091         * python/python.c (_initialize_python): Remove trailing newline
4092         from help.
4093         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4094         help.
4095         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4096         from help.  Reformat some text.
4097         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4098         from help.
4099         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4100         newline from help.
4101
4102 2019-06-11  Tom Tromey  <tromey@adacore.com>
4103
4104         * darwin-nat.c (darwin_decode_exception_message)
4105         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4106
4107 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * valops.c (value_slice): Check for not allocated or not
4110         associated values.
4111
4112 2019-06-10  Tom de Vries  <tdevries@suse.de>
4113
4114         PR gdb/24618
4115         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4116         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4117         invalid.
4118
4119 2019-06-10  Tom de Vries  <tdevries@suse.de>
4120
4121         PR gdb/24611
4122         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4123         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4124
4125 2019-06-10  Tom de Vries  <tdevries@suse.de>
4126
4127         PR symtab/24545
4128         * symtab.c (struct demangled_name_entry): Add language field.
4129         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4130         static minimal symbol".  Set and use language field.
4131
4132 2019-06-10  Tom Tromey  <tromey@adacore.com>
4133
4134         * ada-lang.c (_initialize_ada_language): Update help text.
4135
4136 2019-06-10  Tom Tromey  <tromey@adacore.com>
4137
4138         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4139         with a newline.
4140         * guile/guile.c (handle_boot_error): Don't end warning with a
4141         newline.
4142         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4143         warning with a newline.
4144         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4145         newline.
4146         (s12z_frame_cache): Likewise.
4147         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4148         a newline.
4149         * solib-svr4.c (disable_probes_interface): Don't end warning with
4150         a newline.
4151         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4152         newline.
4153         * python/python.c (do_finish_initialization): Don't end warning
4154         with a newline.
4155
4156 2019-06-10  Tom Tromey  <tom@tromey.com>
4157
4158         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4159         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4160         gdbpy_enter.
4161
4162 2019-06-10  Tom Tromey  <tromey@adacore.com>
4163
4164         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4165         data.
4166         (elf_new_init): Don't call stabsread_new_init.
4167         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4168         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4169         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4170
4171 2019-06-10  Tom de Vries  <tdevries@suse.de>
4172
4173         PR symtab/16264
4174         PR symtab/24517
4175         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4176
4177 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4178
4179         * source.c (find_and_open_source): Also rewrite relative file
4180         names.
4181
4182 2019-04-26  Amos Bird  <amosbird@gmail.com>
4183
4184         * annotate.c (annotate_thread_exited): Add "thread-exited"
4185         annotation.
4186
4187 2019-06-06  Tom Tromey  <tromey@adacore.com>
4188
4189         * maint.h (class scoped_command_stats): Use
4190         DISABLE_COPY_AND_ASSIGN.
4191         <print_time>: New method.
4192         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4193         print_time.
4194         (scoped_command_stats::print_time): New method.
4195
4196 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4197
4198         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4199         instructions of lengths 6 or 8 bytes.
4200
4201 2019-06-04  Pedro Alves  <palves@redhat.com>
4202
4203         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4204
4205         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4206         * breakpoint.c (condition_completer): Likewise.
4207         * cli/cli-dump.c (scan_expression): Likewise.
4208         * common/filestuff.c (mkdir_recursive): Likewise.
4209         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4210         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4211         (gdb_abspath): Likewise.
4212         * compile/compile-cplus-types.c
4213         (compile_cplus_instance::decl_name): Likewise.
4214         * completer.c (complete_explicit_location):
4215         (signal_completer, reg_or_group_completer_1): Likewise.
4216         * cp-support.c (cp_remove_params_if_any): Likewise.
4217         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4218         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4219         * infcmd.c (strip_bg_char): Likewise.
4220         * linespec.c (copy_token_string): Likewise.
4221         * mi/mi-main.c (output_cores): Likewise.
4222         * psymtab.c (psymtab_search_name):
4223         * symfile.c (test_set_ext_lang_command): Likewise.
4224         * target.c (target_fileio_read_stralloc): Likewise.
4225         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4226         * value.c (complete_internalvar): Likewise.
4227
4228 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4229
4230         Add objfile property to gdb.Type.
4231         * NEWS: Mention Python API addition.
4232         * python/py-type.c (typy_get_objfile): New method.
4233
4234 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4235
4236         * NEWS: Mention the new set|show style [title|highlight].
4237         Mention changes to "show style", "help" and "apropos".
4238
4239 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4242         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4243         instead of print_help_for_command.
4244         (print_doc_of_command): New function.
4245         (help_list): Add 'apropos -v word' suggestion.
4246         (print_help_for_command): Style the command name using title style.
4247         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4248         (_initialize_cli_cmds): Describe -v in apropos_command help.
4249
4250 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4251
4252         * cli/cli-style.h (cli_style_option): Add name in constructor,
4253         add m_name class member, add constructor with intensity,
4254         add name class function.
4255         (cli_style_option::add_setshow_commands): Remove name argument.
4256         (highlight_style, title_style): New styles.
4257         * cli/cli-style.c (do_show): New function that shows a style
4258         characteristic styling the style name with itself.
4259         (set_style_name): New function.
4260         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4261         Update all callers according to the changes in cli/cli-style.h.
4262         * utils.h (fputs_highlighted): New function.
4263         * utils.c (fputs_highlighted): Likewise.
4264
4265 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4266
4267         * NEWS: Mention new pipe command and new convenience variables.
4268
4269 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4270
4271         * cli/cli-cmds.c (pipe_command): New function.
4272         (_initialize_cli_cmds): Call add_com for pipe_command.
4273         Define | as an alias for pipe.
4274         (exit_status_set_internal_vars): New function.
4275         (shell_escape): Call exit_status_set_internal_vars.
4276         cli/cli-decode.c (find_command_name_length): Recognize | as
4277         a single character command.
4278
4279 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4280
4281         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4282         top.c (execute_command_to_ui_file): New function, mostly a copy
4283         of execute_command_to_string.
4284         (execute_command_to_string): Implement by calling
4285         execute_command_to_ui_file.
4286
4287 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4288
4289         * top.h (saved_command_line): Remove declaration.
4290         * top.c (previous_saved_command_line, previous_repeat_arguments):
4291         New variables.
4292         (saved_command_line): Make static, define together with other
4293         'repeat variables'.
4294         (dont_repeat): Clear repeat_arguments.
4295         (repeat_previous, get_saved_command_line, save_command_line):
4296         New functions.
4297         (gdb_init): Initialize saved_command_line
4298         and previous_saved_command_line.
4299         * main.c (captured_main_1): Remove saved_command_line initialization.
4300         * event-top.c (handle_line_of_input): Update to use
4301         the new 'repeat' related functions instead of direct access to
4302         saved_command_line.
4303         * command.h (repeat_previous, get_saved_command_line,
4304         save_command_line): New declarations.
4305         (dont_repeat): Add comment.
4306
4307 2019-05-30  Tom Tromey  <tromey@adacore.com>
4308
4309         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4310         Fix comment.
4311         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4312
4313 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4314
4315         PR cli/24587
4316         * completer.c (complete): Initialize variable word.
4317
4318 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4319
4320         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4321         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4322         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4323         'body' is NULL to the outter 'if', protecting the '!is_define'
4324         situation as well.
4325
4326 2019-05-29  Tom Tromey  <tromey@adacore.com>
4327
4328         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4329         (dwarf_unknown): New function.
4330         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4331         (dwarf_type_encoding_name): Use dwarf_unknown.
4332
4333 2019-05-29  Tom Tromey  <tromey@adacore.com>
4334
4335         PR c++/20020:
4336         * cp-valprint.c (cp_print_value_fields): Call
4337         cp_print_static_field inside "try".
4338
4339 2019-05-29  Tom Tromey  <tromey@adacore.com>
4340
4341         * inflow.c (struct terminal_info): Add default operator=.
4342         * configure: Rebuild.
4343         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4344         -Wdeprecated-copy-dtor, -Wredundant-move.
4345
4346 2019-05-29  Tom Tromey  <tromey@adacore.com>
4347
4348         * NEWS: Add entry.
4349         * infcmd.c (print_return_value_1): Handle finish_print
4350         option.
4351         (show_print_finish): New function.
4352         (_initialize_infcmd): Add "set/show print finish" commands.
4353         * valprint.c (user_print_options): Initialize new member.
4354         * valprint.h (struct value_print_options) <finish_print>: New
4355         member.
4356
4357 2019-05-28  Tom Tromey  <tromey@adacore.com>
4358
4359         * ada-lang.c (ada_remove_Xbn_suffix)
4360         (find_old_style_renaming_symbol)
4361         (parse_old_style_renaming): Remove.
4362         (ada_find_renaming_symbol): Don't call
4363         find_old_style_renaming_symbol.
4364         (ada_is_renaming_symbol): Rename from
4365         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4366         bool.  Now static.
4367         (ada_read_var_value): Update and simplify.
4368         * ada-exp.y (write_var_or_type): Remove old code.
4369
4370 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4371
4372         * event-top.c: Remove include comment.
4373         * inflow.c (class scoped_ignore_sigttou): Move from here...
4374         * inflow.h (class scoped_ignore_sigttou): ...to here.
4375         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4376         * top.c:  Remove include comment.
4377
4378 2019-05-27  Tom Tromey  <tom@tromey.com>
4379
4380         * NEWS: Fix typo.
4381
4382 2019-05-22  Tom Tromey  <tromey@adacore.com>
4383
4384         * target.c (target_follow_exec): Constify parameter.
4385         * target-delegates.c: Rebuild.
4386         * remote.c (remote_target::follow_exec): Constify parameter.
4387         * infrun.c (follow_exec): Constify parameter.
4388         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4389         (target_follow_exec): Likewise.
4390
4391 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4392
4393         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4394         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4395
4396 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4397
4398         * NEWS: Add debugredirect and testsuite sections.
4399
4400 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4401
4402         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4403         target descriptions using exclusively floating point register name
4404         aliases.
4405
4406 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4407
4408         PR gdb/18644:
4409         * f-lang.c (build_fortran_types): Handle the case where
4410         gdbarch_floatformat_for_type returns a nullptr.
4411
4412 2019-05-21  Tom de Vries  <tdevries@suse.de>
4413
4414         PR cli/24587
4415         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4416
4417 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4418
4419         PR gdb/18644:
4420         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4421         16-byte floats.
4422         * i386-tdep.c (i386_floatformat_for_type): Use
4423         floatformats_ia64_quad for the 16-byte floating point component
4424         within a fortran 32-byte complex number.
4425
4426 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4429         delete default constructor.
4430         (find_partial_die): Update to return const struct.
4431         (partial_die_parent_scope): Move variable declaration into scope
4432         of its use and change its type to auto.
4433         (guess_partial_die_structure_name): Likewise.
4434         (partial_die_info::fixup): Likewise.
4435
4436 2019-05-17  Tom Tromey  <tromey@adacore.com>
4437
4438         * source.c (find_and_open_source): Remove cast.
4439
4440 2019-05-17  Tom Tromey  <tromey@adacore.com>
4441
4442         * annotate.c (annotate_source): Make "filename" const.
4443         * annotate.h (annotate_source): Use const.
4444
4445 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4446
4447         * disasm.c (set_disassembler_options): Send errors to stderr.
4448
4449 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4450
4451         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4452         (cli_interp_base::set_logging): Check debug_redirect.
4453         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4454         * cli/cli-logging.c (debug_redirect): Add static variable.
4455         (pop_output_files): Add default param.
4456         (handle_redirections): Print debug setting.
4457         (show_logging_command): Likewise.
4458         (_initialize_cli_logging): Add debugredirect command.
4459         * interps.c (current_interp_set_logging): Add debug_redirect
4460         parameter.
4461         * interps.h (set_logging): Add debug_redirect parameter.
4462         (current_interp_set_logging): Likewise.
4463         * mi/mi-common.h: Likewise.
4464         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4465
4466 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4467             Tom Tromey  <tromey@adacore.com>
4468
4469         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4470         directly.
4471         * cli/cli-interp.h (make_logging_output): Remove declaration.
4472         * cli/cli-logging.c (make_logging_output): Remove function.
4473         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4474         directly.
4475         * ui-file.c (tee_file::tee_file): Remove bools.
4476         (tee_file::~tee_file): Remove deletes.
4477         * ui-file.h (tee_file): Remove bools.
4478
4479 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4480
4481         * mi/mi-cmds.h (mi_cmd_complete): New function.
4482         * mi/mi-main.c (mi_cmd_complete): Likewise.
4483         * mi/mi-cmds.c: Define new MI command -complete.
4484         * NEWS: Mention new -complete command.
4485
4486 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4487
4488         * completer.h (complete): New function.
4489         * completer.c (complete): Likewise.
4490         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4491         function defined in completer.h.
4492
4493 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4494
4495         * MAINTAINERS (Write After Approval): Add myself.
4496
4497 2019-05-17  Tom de Vries  <tdevries@suse.de>
4498
4499         PR gdb/24094
4500         * dwarf2read.c (struct cu_partial_die_info): New struct.
4501         (find_partial_die): Return cu_partial_die_info.
4502         (partial_die_parent_scope, guess_partial_die_structure_name)
4503         (partial_die_info::fixup): Handle new return type of find_partial_die.
4504
4505 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4506
4507         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4508         "std::string", simplifying the algorithm.
4509
4510 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4511
4512         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4513         (stap_static_probe_ops::get_probes): Likewise.
4514
4515 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4516
4517         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4518         '-')" and "else if".
4519         (stap_parse_single_operand): Join checks for
4520         "gdbarch_stap_parse_special_token_p" and
4521         "gdbarch_stap_parse_special_token" in the same "if" statement.
4522         Invert check when verifying for operation on register
4523         displacement.
4524
4525 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4526
4527         * stap-probe.c (stap_get_opcode): Update comment.
4528         (stap_get_expected_argument_type): Likewise.
4529         (handle_stap_probe): Likewise.
4530
4531 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4532
4533         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4534         return type to 'bool'.  Adjust comment.  Use 'bool' when
4535         appropriate.
4536         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4537         * stap-probe.c (stap_parse_argument_1): Likewise.
4538         (stap_is_operator): Likewise.
4539         (stap_is_generic_prefix): Likewise.
4540         (stap_is_register_prefix): Likewise.
4541         (stap_is_register_indirection_prefix): Likewise.
4542         (stap_is_integer_prefix): Likewise.
4543         (stap_generic_check_suffix): Likewise.
4544         (stap_check_integer_suffix): Likewise.
4545         (stap_check_register_suffix): Likewise.
4546         (stap_check_register_indirection_suffix): Likewise.
4547         (stap_parse_register_operand): Likewise.
4548         (stap_parse_single_operand): Likewise.
4549         (stap_parse_argument_1): Likewise.
4550         (stap_probe::get_argument_count): Likewise.
4551         (stap_is_operator): Likewise.
4552
4553 2019-05-16  Tom Tromey  <tromey@adacore.com>
4554
4555         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4556         keyword to foreach.
4557
4558 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4559
4560         * linux-thread-db.c (try_thread_db_load_1): Change return type
4561         to bool.
4562         (try_thread_db_load): Likewise.
4563         (try_thread_db_load_from_pdir_1): Likewise.
4564         (try_thread_db_load_from_pdir): Likewise.
4565         (try_thread_db_load_from_sdir): Likewise.
4566         (try_thread_db_load_from_dir): Likewise.
4567         (thread_db_load_search): Likewise.
4568         (has_libpthread): Likewise.
4569         (thread_db_load): Likewise.
4570
4571 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4572
4573         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4574         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4575         NULL, and complain/return if that's the case.
4576
4577 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4578
4579         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4580         (advance, posn, abstract_read_memory): New functions.
4581         [struct mem_read_abstraction]: New struct.
4582         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4583
4584 2019-05-14  Tom Tromey  <tromey@adacore.com>
4585
4586         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4587         value is not lval_memory.
4588
4589 2019-05-14  Tom Tromey  <tromey@adacore.com>
4590
4591         * solib.c (info_sharedlibrary_command): Style the file name.
4592
4593 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4594
4595         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4596         (aarch64_vnv_type): Likewise.
4597         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4598         * common/tdesc.c: Likewise.
4599         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4600         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4601         * features/aarch64-fpu.xml: Add ieee half view.
4602         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4603         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4604         * gdbtypes.h (struct builtin_type): Likewise.
4605         (struct objfile_type): Likewise.
4606
4607 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4608
4609         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4610         typo.
4611         * location.h (string_to_event_location): Likewise.
4612
4613 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4614
4615         GDB 8.3 released.
4616
4617 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4618
4619         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4620         New variable declaration.
4621         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4622         New variable.
4623         (print_one_breakpoint): Use ui_out::test_flags and new global
4624         variable to compute use_fixed_output.
4625         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4626         Remove.
4627         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4628         (mi_multi_location_breakpoint_output_fixed): Remove.
4629         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4630         new variable.
4631         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4632         fix_multi_location_breakpoint_output flag if version >= 3.
4633         * ui-out.h (enum ui_out_flag)
4634         <fix_multi_location_breakpoint_output>: New enumerator.
4635
4636 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4637
4638         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4639
4640 2019-05-10  Tom Tromey  <tromey@adacore.com>
4641
4642         * ada-lang.c (catch_ada_completer): New function.
4643         (_initialize_ada_language): Use it.
4644
4645 2019-05-10  Tom Tromey  <tromey@adacore.com>
4646
4647         * thread.c (print_thread_info): Make "requested_threads" const.
4648         * gdbthread.h (print_thread_info): Make "requested_threads"
4649         const.
4650         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4651         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4652
4653 2019-05-08  Tom Tromey  <tom@tromey.com>
4654
4655         * gdbtypes.c (objfile_type_data): Change type.
4656         (objfile_type, _initialize_gdbtypes): Update.
4657
4658 2019-05-08  Tom Tromey  <tom@tromey.com>
4659
4660         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4661         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4662         (_initialize_dwarf2_frame): Update.
4663
4664 2019-05-08  Tom Tromey  <tom@tromey.com>
4665
4666         * objc-lang.c (objc_objfile_data): Change type.
4667         (find_methods): Update.
4668         (_initialize_objc_lang): Remove.
4669
4670 2019-05-08  Tom Tromey  <tom@tromey.com>
4671
4672         * stabsread.c (rs6000_builtin_type_data): Change type.
4673         (rs6000_builtin_type, _initialize_stabsread): Update.
4674
4675 2019-05-08  Tom Tromey  <tom@tromey.com>
4676
4677         * mips-tdep.c (mips_pdr_data): Remove.
4678         (_initialize_mips_tdep): Update.
4679
4680 2019-05-08  Tom Tromey  <tom@tromey.com>
4681
4682         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4683         (hppa_init_objfile_priv_data, read_unwind_info)
4684         (find_unwind_entry, _initialize_hppa_tdep): Update.
4685
4686 2019-05-08  Tom Tromey  <tom@tromey.com>
4687
4688         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4689         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4690         on obstack.
4691         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4692
4693 2019-05-08  Tom Tromey  <tom@tromey.com>
4694
4695         * mdebugread.c (basic_type_data): Change type.
4696         (basic_type, _initialize_mdebugread): Update.
4697
4698 2019-05-08  Tom Tromey  <tom@tromey.com>
4699
4700         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4701
4702 2019-05-08  Tom Tromey  <tom@tromey.com>
4703
4704         * nto-tdep.c (nto_inferior_data_reg): Change type.
4705         (nto_inferior_data): Update.
4706         (nto_inferior_data_cleanup, nto_new_inferior_data)
4707         (_initialize_nto_tdep): Remove.
4708         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4709
4710 2019-05-08  Tom Tromey  <tom@tromey.com>
4711
4712         * ada-lang.c (struct ada_inferior_data): Add initializers.
4713         (ada_inferior_data): Change type.
4714         (ada_inferior_data_cleanup): Remove.
4715         (get_ada_inferior_data, ada_inferior_exit)
4716         (struct ada_pspace_data): Add initializers, destructor.
4717         (ada_pspace_data_handle): Change type.
4718         (get_ada_pspace_data): Update.
4719         (ada_pspace_data_cleanup): Remove.
4720
4721 2019-05-08  Tom Tromey  <tom@tromey.com>
4722
4723         * coffread.c (struct coff_symfile_info): Add initializers.
4724         (coff_objfile_data_key): Move lower.  Change type.
4725         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4726         Update.
4727         (coff_free_info): Remove.
4728
4729 2019-05-08  Tom Tromey  <tom@tromey.com>
4730
4731         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4732         (fbsd_pspace_data_handle): Move lower.  Change type.
4733         (get_fbsd_pspace_data): Update.
4734         (fbsd_pspace_data_cleanup): Remove.
4735         (_initialize_fbsd_tdep): Update.
4736
4737 2019-05-08  Tom Tromey  <tom@tromey.com>
4738
4739         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4740         (get_ada_tasks_pspace_data): Update.
4741         (ada_tasks_pspace_data_cleanup): Remove.
4742         (_initialize_tasks): Update.
4743         (ada_tasks_inferior_data_handle): Change type.
4744         (get_ada_tasks_inferior_data): Update.
4745         (ada_tasks_inferior_data_cleanup): Remove.
4746         (struct ada_tasks_pspace_data): Add initializers.
4747
4748 2019-05-08  Tom Tromey  <tom@tromey.com>
4749
4750         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4751         * symfile-debug.c (debug_sym_get_probes): Change type.
4752         * stap-probe.c (handle_stap_probe):
4753         (stap_static_probe_ops::get_probes): Change type.
4754         * probe.h (class static_probe_ops) <get_probes>: Change type.
4755         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4756         (parse_probes_in_pspace): Update.
4757         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4758         Update.
4759         (any_static_probe_ops::get_probes): Change type.
4760         * elfread.c (elfread_data): New typedef.
4761         (probe_key): Change type.
4762         (elf_get_probes): Likewise.  Update.
4763         (probe_key_free): Remove.
4764         (_initialize_elfread): Update.
4765         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4766         Change type.
4767         (dtrace_process_dof_probe, dtrace_process_dof)
4768         (dtrace_static_probe_ops::get_probe): Change type.
4769
4770 2019-05-08  Tom Tromey  <tom@tromey.com>
4771
4772         * xcoffread.c (struct xcoff_symfile_info): Rename from
4773         coff_symfile_info.  Add initializers.
4774         (xcoff_objfile_data_key): Move lower.  Change type.
4775         (XCOFF_DATA): Rewrite.
4776         (xcoff_free_info): Remove.
4777         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4778         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4779         (xcoff_initial_scan): Update.
4780
4781 2019-05-08  Tom Tromey  <tom@tromey.com>
4782
4783         * solib-svr4.c (struct svr4_info): Add initializers and
4784         destructor.
4785         <probes_table>: Now an htab_up.
4786         (solib_svr4_pspace_data): Change type.
4787         (free_probes_table): Simplify.
4788         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4789         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4790         (probes_table_remove_objfile_probes, register_solib_event_probe)
4791         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4792         (_initialize_svr4_solib): Update.
4793
4794 2019-05-08  Tom Tromey  <tom@tromey.com>
4795
4796         * remote.c (remote_pspace_data): Change type.
4797         (remote_pspace_data_cleanup): Remove.
4798         (get_remote_exec_file, set_pspace_remote_exec_file)
4799         (_initialize_remote): Update.
4800
4801 2019-05-08  Tom Tromey  <tom@tromey.com>
4802
4803         * breakpoint.c (breakpoint_objfile_key): Change type.
4804         (get_breakpoint_objfile_data): Update.
4805         (free_breakpoint_objfile_data): Remove.
4806         (_initialize_breakpoint): Update.
4807
4808 2019-05-08  Tom Tromey  <tom@tromey.com>
4809
4810         * linux-tdep.c (struct linux_info): Add initializers.
4811         (linux_inferior_data): Move.  Change type.
4812         (invalidate_linux_cache_inf): Update.
4813         (linux_inferior_data_cleanup): Remove.
4814         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4815
4816 2019-05-08  Tom Tromey  <tom@tromey.com>
4817
4818         * auxv.c (auxv_inferior_data): Move.  Change type.
4819         (auxv_inferior_data_cleanup): Remove.
4820         (invalidate_auxv_cache_inf): Rewrite.
4821         (get_auxv_inferior_data, _initialize_auxv): Update.
4822
4823 2019-05-08  Tom Tromey  <tom@tromey.com>
4824
4825         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4826         (symfile_debug_objfile_data_key): Change type.
4827         (symfile_debug_installed, debug_qf_has_symbols)
4828         (debug_qf_find_last_source_symtab)
4829         (debug_qf_forget_cached_source_info)
4830         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4831         (debug_qf_print_stats, debug_qf_dump)
4832         (debug_qf_expand_symtabs_for_function)
4833         (debug_qf_expand_all_symtabs)
4834         (debug_qf_expand_symtabs_with_fullname)
4835         (debug_qf_map_matching_symbols)
4836         (debug_qf_expand_symtabs_matching)
4837         (debug_qf_find_pc_sect_compunit_symtab)
4838         (debug_qf_map_symbol_filenames)
4839         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4840         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4841         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4842         (debug_sym_read_linetable, debug_sym_relocate): Update.
4843         (symfile_debug_free_objfile): Remove.
4844         (install_symfile_debug_logging, _initialize_symfile_debug):
4845         Update.
4846
4847 2019-05-08  Tom Tromey  <tom@tromey.com>
4848
4849         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4850         allocate_on_obstack.
4851         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4852         (get_dwarf2_per_objfile): Update.
4853         (set_dwarf2_per_objfile): Remove.
4854         (dwarf2_has_info, dwarf2_get_section_info): Update.
4855         (dwarf2_free_objfile): Remove.
4856         (_initialize_dwarf2_read): Update.
4857
4858 2019-05-08  Tom Tromey  <tom@tromey.com>
4859
4860         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4861         initializers.
4862         <unsupported_script_warning_printed,
4863         script_not_found_warning_printed>: Now bool.
4864         (auto_load_pspace_data): Change type.
4865         (~auto_load_pspace_info): Rename from
4866         auto_load_pspace_data_cleanup.
4867         (get_auto_load_pspace_data, init_loaded_scripts_info)
4868         (clear_section_scripts, maybe_print_unsupported_script_warning)
4869         (maybe_print_script_not_found_warning, _initialize_auto_load):
4870         Update.
4871
4872 2019-05-08  Tom Tromey  <tom@tromey.com>
4873
4874         * objfiles.c (objfile_pspace_info): Add destructor and
4875         initializers.
4876         (objfiles_pspace_data): Change type.
4877         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4878         (get_objfile_pspace_data): Update.
4879         (objfiles_bfd_data): Change type.
4880         (get_objfile_bfd_data): Update.
4881         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4882
4883 2019-05-08  Tom Tromey  <tom@tromey.com>
4884
4885         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4886         Change type.
4887         (get_catch_syscall_inferior_data): Update.
4888         (catch_syscall_inferior_data_cleanup): Remove.
4889         (_initialize_break_catch_syscall): Update.
4890
4891 2019-05-08  Tom Tromey  <tom@tromey.com>
4892
4893         * inflow.c (struct terminal_info): Add destructor and
4894         initializers.
4895         (inflow_inferior_data): Change type.
4896         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4897         (get_inflow_inferior_data, inflow_inferior_exit)
4898         (swap_terminal_info, _initialize_inflow): Update.
4899
4900 2019-05-08  Tom Tromey  <tom@tromey.com>
4901
4902         * target-dcache.c (target_dcache_cleanup): Remove.
4903         (target_dcache_aspace_key): Change type.
4904         (target_dcache_init_p, target_dcache_invalidate)
4905         (target_dcache_get, target_dcache_get_or_init)
4906         (_initialize_target_dcache): Update.
4907         * dcache.h (struct dcache_deleter): New.
4908
4909 2019-05-08  Tom Tromey  <tom@tromey.com>
4910
4911         * symtab.c (struct symbol_cache): Add destructor and
4912         initializers.
4913         (symbol_cache_key): Move.  Change type.
4914         (make_symbol_cache, free_symbol_cache): Remove.
4915         (get_symbol_cache): Update.
4916         (symbol_cache_cleanup): Remove.
4917         (ALL_PSPACES, symbol_cache_flush)
4918         (maintenance_print_symbol_cache)
4919         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4920         Update.
4921
4922 2019-05-08  Tom Tromey  <tom@tromey.com>
4923
4924         * symtab.c (struct main_info): Add destructor and initializers.
4925         (main_progspace_key): Move.  Change type.
4926         (get_main_info): Update.
4927         (main_info_cleanup): Remove.
4928         (_initialize_symtab): Update.
4929
4930 2019-05-08  Tom Tromey  <tom@tromey.com>
4931
4932         * registry.h (DECLARE_REGISTRY): Define the _key class.
4933
4934 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * NEWS: Merge two 'New commands' sections.
4937
4938 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4939
4940         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4941         parameter and use Ada language definition instead.
4942         (ada_val_print_ptr): Remove unused language parameter.
4943         (ada_val_print_num): Remove language parameter and use Ada language
4944         definition instead.
4945         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4946         parameter.
4947         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4948         parameter and use Ada language definition instead.
4949         (ada_val_print_1): Update all ada_val_print_xxx calls.
4950         Remove language parameter.
4951         (ada_val_print): Update ada_val_print_1 call.
4952
4953 2019-05-08  Tom Tromey  <tromey@adacore.com>
4954
4955         * remote.c (remote_hw_watchpoint_limit)
4956         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4957         Now static.
4958
4959 2019-05-08  Tom Tromey  <tromey@adacore.com>
4960
4961         * maint.c (_initialize_maint_cmds): Move initialization code to
4962         remote.c.
4963         (watchdog, show_watchdog): Move to remote.c.
4964         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4965         "watchdog" static.
4966         (_initialize_remote): Move initialization code from maint.c.
4967         * defs.h (watchdog): Don't declare.
4968
4969 2019-05-08  Tom Tromey  <tromey@adacore.com>
4970
4971         * tui/tui-interp.c: Include main.h.
4972         * interps.c: Include main.h.
4973         * main.h (interpreter_p): Declare.
4974         * defs.h (interpreter_p): Don't declare.
4975
4976 2019-05-08  Tom Tromey  <tromey@adacore.com>
4977
4978         * dwarf2loc.c: Include dwarf2read.h.
4979         * defs.h (read_unsigned_leb128): Don't declare.
4980         * dwarf2read.h (read_unsigned_leb128): Declare.
4981
4982 2019-05-08  Tom Tromey  <tromey@adacore.com>
4983
4984         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4985         method.
4986
4987 2019-05-08  Tom Tromey  <tromey@adacore.com>
4988
4989         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4990         when no wrap column is set.
4991
4992 2019-05-08  Tom Tromey  <tromey@adacore.com>
4993
4994         * c-lang.c (c_get_string): Handle non-C-style arrays.
4995
4996 2019-05-08  Tom Tromey  <tromey@adacore.com>
4997
4998         * typeprint.c (print_offset_data::update): Print the bit offset,
4999         not the number of bits remaining.
5000
5001 2019-05-08  Tom Tromey  <tromey@adacore.com>
5002
5003         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5004         padding at end of comment.
5005
5006 2019-05-08  Tom Tromey  <tromey@adacore.com>
5007
5008         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5009         Compare main types.
5010
5011 2019-05-06  Tom Tromey  <tom@tromey.com>
5012
5013         * common/scoped_mmap.c: Include common-defs.h.
5014         * common/scoped_mmap.h: Don't include config.h.
5015
5016 2019-05-04  Tom Tromey  <tom@tromey.com>
5017
5018         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5019         (struct aarch64_call_info): Add initializers.
5020         <si>: Now a std::vector.
5021         (pass_on_stack, aarch64_push_dummy_call): Update.
5022
5023 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5024             Tom Tromey  <tom@tromey.com>
5025
5026         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5027         (ppc_threads): Now a std::vector.  Now static.
5028         (hwdebug_find_thread_points_by_tid)
5029         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5030         Update.
5031
5032 2019-05-04  Tom Tromey  <tom@tromey.com>
5033
5034         * arc-tdep.c (arc_tdesc_init): Return bool.
5035
5036 2019-05-04  Tom Tromey  <tom@tromey.com>
5037
5038         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5039         Use gdb_assert_not_reached.
5040
5041 2019-05-04  Tom Tromey  <tom@tromey.com>
5042
5043         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5044         "false".
5045
5046 2019-05-04  Tom Tromey  <tom@tromey.com>
5047
5048         * arc-tdep.c (arc_tdesc_init): Use bool.
5049
5050 2019-05-04  Tom Tromey  <tom@tromey.com>
5051
5052         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5053
5054 2019-05-04  Tom Tromey  <tom@tromey.com>
5055
5056         * cli/cli-cmds.c (valid_command_p): Return bool.
5057
5058 2019-05-04  Tom Tromey  <tom@tromey.com>
5059
5060         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5061         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5062
5063 2019-05-04  Raul Tambre  <raul@tambre.ee>
5064
5065         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5066         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5067         operator for comparison.
5068
5069 2019-05-04  Tom Tromey  <tom@tromey.com>
5070
5071         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5072         (lookup_partial_symbol, print_partial_symbols)
5073         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5074         (psymbol_compare): Update.
5075         (add_psymbol_to_bcache): Clear the entire psymbol.
5076         (maintenance_check_psymtabs): Update.
5077         * psympriv.h (struct partial_symbol): Don't derive from
5078         general_symbol_info.
5079         <obj_section, unrelocated_address, address,
5080         set_unrelocated_address>: Update.
5081         <ginfo>: New member.
5082         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5083         (debug_names::write_psymbols): Update.
5084
5085 2019-05-04  Tom de Vries  <tdevries@suse.de>
5086
5087         * contrib/cc-with-tweaks.sh: Support -n arg.
5088
5089 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5090
5091         * corelow.c (core_target::detach): Ensure frame cache and
5092         register caches are cleared.
5093         inferior.c (exit_inferior_1): Likewise.
5094
5095 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5096             Tom Tromey  <tom@tromey.com>
5097
5098         * dictionary.c (collate_pending_symbols_by_language): Remove
5099         "struct" from foreach.
5100         * symtab.c (lookup_global_symbol_from_objfile)
5101         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5102         foreach.
5103         * ser-tcp.c (net_open): Remove "struct" from foreach.
5104         * objfiles.c (objfile_relocate, objfile_rebase)
5105         (objfile_has_symbols): Remove "struct" from foreach.
5106         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5107         from foreach.
5108         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5109         foreach.
5110         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5111         "struct" from foreach.
5112         * ada-lang.c (create_excep_cond_exprs)
5113         (ada_exception_catchpoint_cond_string): Remove "struct" from
5114         foreach.
5115
5116 2019-05-03  Tom Tromey  <tromey@adacore.com>
5117
5118         * ada-exp.y (convert_char_literal): Check suffix of each
5119         enumerator.
5120
5121 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5122
5123         PR ada/21406:
5124         * ada-exp.y (yywrap): Don't define.
5125         * ada-lex.l (%option): Add noyywrap
5126         (yywrap): Remove.
5127
5128 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5129
5130         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5131         _WIN32_WINNT to the XP level, unless already defined to a higher
5132         level.
5133
5134         * unittests/parse-connection-spec-selftests.c:
5135         * ser-tcp.c:
5136         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5137         override.
5138
5139         * symfile.c (find_separate_debug_file): Remove colon from the
5140         drive spec of DOS/Windows file names of the target, so that the
5141         file name produced from DEBUGDIR and the target's directory will
5142         be valid on DOS/Windows systems.
5143
5144 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * rust-lang.c (val_print_struct): Handle printing structures
5147         containing strings.
5148
5149 2019-05-02  Tom Tromey  <tromey@adacore.com>
5150
5151         * valarith.c (_initialize_valarith): Remove.
5152
5153 2019-05-01  Tom Tromey  <tromey@adacore.com>
5154
5155         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5156         bitfields.
5157
5158 2019-05-01  Tom Tromey  <tromey@adacore.com>
5159
5160         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5161         for big-endian copies.
5162
5163 2019-04-30  Ali Tamur  <tamur@google.com>
5164         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5165         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5166         (read_3_bytes): New function.
5167
5168 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5169
5170         * windows-nat.c (main_thread_id): Delete.
5171         (handle_output_debug_string): Replace main_thread_id by
5172         current_event.dwThreadId.
5173         (fake_create_process): Likewise.
5174         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5175         Do not set main_thread_id.
5176         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5177         current_event.dwThreadId.
5178         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5179
5180 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5181
5182         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5183         Use current_event.dwThreadId instead of main_thread_id.
5184
5185 2019-04-30  Tom Tromey  <tromey@adacore.com>
5186
5187         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5188         (create_excep_cond_exprs): Iterate over program spaces.
5189         (ada_exception_catchpoint_cond_string): Examine all minimal
5190         symbols for exception types.
5191
5192 2019-04-30  Tom Tromey  <tromey@adacore.com>
5193
5194         PR c++/24470:
5195         * dwarf2read.c (process_structure_scope): Handle case where type
5196         has template parameters but no symbol was created.
5197
5198 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5199             Chris January  <chris.january@arm.com>
5200
5201         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5202         qualifier.
5203         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5204
5205 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5206
5207         * f-typeprint.c (f_print_type): Update rules for printing
5208         whitespace.
5209         (f_type_print_varspec_suffix): Likewise.
5210
5211 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5212             Chris January  <chris.january@arm.com>
5213
5214         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5215         function arguments.
5216
5217 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5218
5219         * f-lang.c (build_fortran_types): Change name of void type to
5220         lower case.
5221         * f-typeprint.c (f_type_print_base): Print the name of the void
5222         type, rather than a fixed string.
5223         * f-valprint.c (f_decorations): Use lower case void string.
5224
5225 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5226             Chris January  <chris.january@arm.com>
5227
5228         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5229         types for Fortran.
5230
5231 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5232             Chris January  <chris.january@arm.com>
5233             David Lecomber  <david.lecomber@arm.com>
5234
5235         * f-exp.y (BINOP_INTRINSIC): New token.
5236         (exp): New parser rule handling BINOP_INTRINSIC.
5237         (f77_keywords): Add new builtin procedures.
5238         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5239         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5240         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5241         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5242         (print_unop_subexp_f): New function.
5243         (print_binop_subexp_f): New function.
5244         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5245         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5246         (dump_subexp_body_f): Likewise.
5247         (operator_check_f): Likewise.
5248         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5249         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5250
5251 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5254         UNOP_KIND.
5255         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5256         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5257         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5258         (operator_length_f): New fuction.
5259         (print_subexp_f): New function.
5260         (op_name_f): New function.
5261         (dump_subexp_body_f): New function.
5262         (operator_check_f): New function.
5263         (exp_descriptor_f): Replace standard expression handling functions
5264         with new functions.
5265         * gdb/fortran-operator.def: New file.
5266         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5267         * gdb/std-operator.def: Remove UNOP_KIND.
5268
5269 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5270
5271         * std-operator.def: Remove unbalanced, stray double quote
5272         character.
5273
5274 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5275             Chris January  <chris.january@arm.com>
5276             Daniel Everett  <daniel.everett@arm.com>
5277             Nick Forrington  <nick.forrington@arm.com>
5278             Richard Bunt  <richard.bunt@arm.com>
5279
5280         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5281         of depth when printing anonymous structs or unions.
5282         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5283         Don't print either the top-level value, or the children if the
5284         max-depth is exceeded.
5285         (ppscm_print_children): When printing the key of a map, allow one
5286         extra level of depth.
5287         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5288         print either the top-level value, or the children if the max-depth
5289         is exceeded.
5290         (print_children): When printing the key of a map, allow one extra
5291         level of depth.
5292         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5293         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5294         (user_print_options): Initialise max_depth field.
5295         (val_print_scalar_or_string_type_p): New function.
5296         (val_print): Check to see if the max depth has been reached.
5297         (val_print_check_max_depth): Define new function.
5298         (show_print_max_depth): New function.
5299         (_initialize_valprint): Add 'print max-depth' option.
5300         * valprint.h (struct value_print_options) <max_depth>: New field.
5301         (val_print_check_max_depth): Declare new function.
5302         * NEWS: Document new feature.
5303
5304 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * ada-lang.c (ada_language_defn): Initialise new field.
5307         * c-lang.c (c_is_string_type_p): New function.
5308         (c_language_defn): Initialise new field.
5309         (cplus_language_defn): Initialise new field.
5310         (asm_language_defn): Initialise new field.
5311         (minimal_language_defn): Initialise new field.
5312         * c-lang.h (c_is_string_type_p): Declare new function.
5313         * d-lang.c (d_language_defn): Initialise new field.
5314         * f-lang.c (f_is_string_type_p): New function.
5315         (f_language_defn): Initialise new field.
5316         * go-lang.c (go_is_string_type_p): New function.
5317         (go_language_defn): Initialise new field.
5318         * language.c (default_is_string_type_p): New function.
5319         (unknown_language_defn): Initialise new field.
5320         (auto_language_defn): Initialise new field.
5321         * language.h (struct language_defn) <la_is_string_type_p>: New
5322         member variable.
5323         (default_is_string_type_p): Declare new function.
5324         * m2-lang.c (m2_language_defn): Initialise new field.
5325         * objc-lang.c (objc_language_defn): Initialise new field.
5326         * opencl-lang.c (opencl_language_defn): Initialise new field.
5327         * p-lang.c (pascal_is_string_type_p): New function.
5328         (pascal_language_defn): Initialise new field.
5329         * rust-lang.c (rust_is_string_type_p): New function.
5330         (rust_language_defn): Initialise new field.
5331
5332 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5333
5334         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5335         New field.
5336         * ada-lang.c (ada_language_defn): Initialise new field.
5337         * c-lang.c (c_language_defn): Likewise.
5338         (cplus_language_defn): Likewise.
5339         (asm_language_defn): Likewise.
5340         (minimal_language_defn): Likewise.
5341         * d-lang.c (d_language_defn): Likewise.
5342         * f-lang.c (f_language_defn): Likewise.
5343         * go-lang.c (go_language_defn): Likewise.
5344         * language.c (unknown_language_defn): Likewise.
5345         (auto_language_defn): Likewise.
5346         * m2-lang.c (m2_language_defn): Likewise.
5347         * objc-lang.c (objc_language_defn): Likewise.
5348         * opencl-lang.c (opencl_language_defn): Likewise.
5349         * p-lang.c (pascal_language_defn): Likewise.
5350         * rust-lang.c (rust_language_defn): Likewise.
5351
5352 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5353
5354         * ada-lang.c (ada_is_character_type): Change return type to bool.
5355         (ada_is_string_type): Likewise.
5356         * ada-lang.h (ada_is_character_type): Update declaration
5357         (ada_is_string_type): Likewise.
5358
5359 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5360
5361         Support style in 'frame|thread apply'
5362
5363         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5364         * record.c (record_start, record_stop): Update callers of
5365         execute_command_to_string with false.
5366         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5367         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5368         methods.
5369         (class string_file): New constructor with term_out parameter.
5370         Override methods term_out and can_emit_style_escape.  New member
5371         term_out.
5372         (class stdio_file): Override can_emit_style_escape.
5373         (class tee_file): Override term_out and can_emit_style_escape.
5374         * utils.h (can_emit_style_escape): Remove.
5375         * utils.c (can_emit_style_escape): Likewise.
5376         Update all callers of can_emit_style_escape (SOMESTREAM) to
5377         SOMESTREAM->can_emit_style_escape.
5378         * source-cache.c (source_cache::get_source_lines): Likewise.
5379         * stack.c (frame_apply_command_count): Call execute_command_to_string
5380         passing the term_out characteristic of the current gdb_stdout.
5381         * thread.c (thr_try_catch_cmd): Likewise.
5382         * top.c (execute_command_to_string): pass term_out parameter
5383         to construct the string_file for the command output.
5384         * ui-file.c (term_cli_styling): New function (most code moved
5385         from utils.c can_emit_style_escape).
5386         (string_file::string_file, string_file::can_emit_style_escape,
5387         stdio_file::can_emit_style_escape, tee_file::term_out,
5388         tee_file::can_emit_style_escape): New functions.
5389
5390 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5391
5392         * NEWS: Mention the new set|show may-call-functions.
5393         * infcall.c (may_call_functions_p): New variable.
5394         (show_may_call_functions_p): New function.
5395         (call_function_by_hand_dummy): Throws an error if not
5396         may-call-functions.
5397         (_initialize_infcall): Call add_setshow_boolean_cmd for
5398         may-call-functions.
5399
5400 2019-04-25  Keith Seitz  <keiths@redhat.com>
5401
5402         PR c++/24367
5403         * cp-support.c (inspect_type): Don't attempt substitutions
5404         of symbol with the same name.
5405
5406 2019-04-25  Tom Tromey  <tromey@adacore.com>
5407
5408         PR gdb/24475:
5409         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5410         static.
5411
5412 2019-04-25  Tom Tromey  <tromey@adacore.com>
5413
5414         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5415         rvalue reference.
5416         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5417         (gdb_xml_parser::parse): Use std::move.
5418         * python/python-internal.h (gdbpy_convert_exception): Take a const
5419         reference.
5420         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5421         std::move.
5422         * python/py-utils.c (gdbpy_convert_exception): Take a const
5423         reference.
5424         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5425         Use std::move.
5426         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5427         Use std::move.
5428         * mi/mi-main.c (mi_print_exception): Take a const reference.
5429         * main.c (handle_command_errors): Take a const reference.
5430         * linespec.c (parse_linespec): Use std::move.
5431         * infcall.c (run_inferior_call): Use std::move.
5432         (call_function_by_hand_dummy): Use std::move.
5433         * exec.c (try_open_exec_file): Use std::move.
5434         * exceptions.h (exception_print, exception_fprintf)
5435         (exception_print_same): Update.
5436         * exceptions.c (print_exception, exception_print)
5437         (exception_fprintf, exception_print_same): Change parameters to
5438         const reference.
5439         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5440         * common/new-op.c: Use std::move.
5441         * common/common-exceptions.h (struct gdb_exception): Add move
5442         constructor.
5443         (struct gdb_exception_error, struct gdb_exception_quit, struct
5444         gdb_quit_bad_alloc): Change constructor to move constructor.
5445         (throw_exception): Change parameter to rvalue reference.
5446         * common/common-exceptions.c (throw_exception): Take rvalue
5447         reference.
5448         * cli/cli-interp.c (safe_execute_command): Use std::move.
5449         * breakpoint.c (insert_bp_location, location_to_sals): Use
5450         std::move.
5451
5452 2019-04-25  Tom Tromey  <tromey@adacore.com>
5453
5454         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5455         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5456         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5457         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5458         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5459         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5460         guile/scm-value.c: Use unpack.
5461         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5462         gdbscm_gdb_exception.
5463         (gdbscm_throw_gdb_exception): Likewise.
5464         (struct gdbscm_gdb_exception): New.
5465         (unpack): New function.
5466         (gdbscm_wrap): Use unpack.
5467
5468 2019-04-25  Tom Tromey  <tromey@adacore.com>
5469
5470         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5471         (gdb_rl_callback_handler): Use std::move.
5472         * common/common-exceptions.h (struct gdb_exception): Add move
5473         assignment operator.
5474         (throw_exception_sjlj): Change "exception" to const reference.
5475         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5476         (throw_exception_sjlj): Change "exception" to const reference.
5477
5478 2019-04-25  Tom Tromey  <tromey@adacore.com>
5479
5480         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5481         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5482         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5483         Update.
5484         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5485         Update.
5486         * mi/mi-interp.c (mi_interp::exec): Update.
5487         * linespec.c (parse_linespec): Update.
5488         * infcall.c (run_inferior_call): Update.
5489         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5490         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5491         (gdbscm_lookup_global_symbol): Update.
5492         * guile/scm-param.c (gdbscm_parameter_value): Update.
5493         * guile/scm-frame.c (gdbscm_frame_read_register)
5494         (gdbscm_frame_read_var): Update.
5495         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5496         * exec.c (try_open_exec_file): Update.
5497         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5498         (gdb_rl_callback_handler): Update.
5499         * common/common-exceptions.h (exception_none): Don't declare.
5500         * common/common-exceptions.c (exception_none): Don't define.
5501         (struct catcher) <exception>: Update.
5502         * cli/cli-interp.c (safe_execute_command): Update.
5503         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5504
5505 2019-04-25  Ali Tamur  <tamur@google.com>
5506
5507         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5508         (read_attribute_value): Likewise.
5509         (dwarf2_read_addr_index): Update comment.
5510         (read_str_index): Add DW_FORM_strx.
5511         (dwarf2_string_attr): Likewise.
5512         (dwarf2_const_value_attr): Likewise.
5513         (dump_die_shallow): Likewise.
5514         (dwarf2_fetch_constant_bytes): Likewise.
5515         (skip_form_bytes): Likewise.
5516         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5517
5518 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5519
5520         PR corefiles/11608
5521         PR corefiles/18187
5522         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5523         OFFSET.  Verify if current mapping contains an ELF header.
5524         (linux_find_memory_regions_full): Adjust call to
5525         dump_mapping_p.
5526
5527 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5528             Kang Li <kanglictf@gmail.com>
5529
5530         PR gdb/21600
5531
5532         * dwarf2-frame.c (read_initial_length): Be consistent about using
5533         unsigned representation of length.
5534         (decode_frame_entry_1): Likewise.  Check for wraparound of
5535         end pointer as well as buffer overflow.
5536
5537 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5538
5539         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5540         "vq".
5541
5542 2019-04-24  Tom Tromey  <tromey@adacore.com>
5543
5544         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5545
5546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * s12z-tdep.c (s12z_unwind_pc): Delete.
5549         (s12z_unwind_sp): Delete.
5550         (s12z_gdbarch_init): Don't register deleted functions with
5551         gdbarch.
5552
5553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5554
5555         * rl78-tdep.c (rl78_unwind_sp): Delete.
5556         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5557
5558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5559
5560         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5561         (xstormy16_unwind_pc): Delete.
5562         (xstormy16_dummy_id): Delete.
5563         (xstormy16_gdbarch_init): Don't register deleted functions with
5564         gdbarch.
5565
5566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * vax-tdep.c (vax_unwind_pc): Delete.
5569         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5570
5571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * v850-tdep.c (v850_unwind_sp): Delete.
5574         (v850_unwind_pc): Delete.
5575         (v850_dummy_id): Delete.
5576         (v850_gdbarch_init): Don't register deleted functions with
5577         gdbarch.
5578
5579 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5582         (tilegx_unwind_pc): Delete.
5583         (tilegx_unwind_dummy_id): Delete.
5584         (tilegx_gdbarch_init): Don't register deleted functions with
5585         gdbarch.
5586
5587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5588
5589         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5590         (tic6x_dummy_id): Delete.
5591         (tic6x_gdbarch_init): Don't register deleted functions with
5592         gdbarch.
5593
5594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5595
5596         * sparc-tdep.c (sparc_unwind_pc): Delete.
5597         (sparc32_gdbarch_init): Don't register deleted function with
5598         gdbarch.
5599
5600 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5601
5602         * sh-tdep.c (sh_unwind_sp): Delete.
5603         (sh_unwind_pc): Delete.
5604         (sh_dummy_id): Delete.
5605         (sh_gdbarch_init): Don't register deleted functions with
5606         gdbarch.
5607
5608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * score-tdep.c (score_unwind_sp): Delete.
5611         (score_unwind_pc): Delete.
5612         (score_dummy_id): Delete.
5613         (score_gdbarch_init): Don't register deleted functions with
5614         gdbarch.
5615
5616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5617
5618         * rx-tdep.c (rx_unwind_pc): Delete.
5619         (rx_unwind_sp): Delete.
5620         (rx_dummy_id): Delete.
5621         (rx_gdbarch_init): Don't register deleted functions with
5622         gdbarch.  Update comment.
5623
5624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5627         (rs6000_dummy_id): Delete.
5628         (rs6000_gdbarch_init): Don't register deleted functions with
5629         gdbarch.
5630
5631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5632
5633         * or1k-tdep.c (or1k_dummy_id): Delete.
5634         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5635
5636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * nios2-tdep.c (nios2_dummy_id): Delete.
5639         (nios2_unwind_sp): Delete.
5640         (nios2_gdbarch_init): Don't register deleted functions with
5641         gdbarch.
5642
5643 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5644
5645         * nds32-tdep.c (nds32_dummy_id): Delete.
5646         (nds32_unwind_pc): Delete.
5647         (nds32_unwind_sp): Delete.
5648         (nds32_gdbarch_init): Don't register deleted functions with
5649         gdbarch.
5650
5651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * msp430-tdep.c (msp430_unwind_pc): Delete.
5654         (msp430_unwind_sp): Delete.
5655         (msp430_dummy_id): Delete.
5656         (msp430_gdbarch_init): Don't register deleted functions with
5657         gdbarch.
5658
5659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5660
5661         * moxie-tdep.c (moxie_unwind_sp): Delete.
5662         (moxie_unwind_pc): Delete.
5663         (moxie_dummy_id): Delete.
5664         (moxie_gdbarch_init): Don't register deleted functions with
5665         gdbarch.
5666
5667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5668
5669         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5670         (mn10300_unwind_pc): Delete.
5671         (mn10300_unwind_sp): Delete.
5672         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5673         mn10300_unwind_sp.
5674         (mn10300_frame_unwind_init): Don't register deleted functions with
5675         gdbarch.
5676
5677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5678
5679         * mep-tdep.c (mep_unwind_pc): Delete.
5680         (mep_unwind_sp): Delete.
5681         (mep_dummy_id): Delete.
5682         (mep_gdbarch_init): Don't register deleted functions with
5683         gdbarch.
5684
5685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5686
5687         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5688         (m68hc11_unwind_sp): Delete.
5689         (m68hc11_gdbarch_init): Don't register deleted functions with
5690         gdbarch.
5691
5692 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5693
5694         * m32r-tdep.c (m32r_unwind_sp): Delete.
5695         (m32r_unwind_pc): Delete.
5696         (m32r_dummy_id): Delete.
5697         (m32r_gdbarch_init): Don't register deleted functions with
5698         gdbarch.
5699
5700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5701
5702         * m32c-tdep.c (m32c_unwind_pc): Delete.
5703         (m32c_unwind_sp): Delete.
5704         (m32c_dummy_id): Delete.
5705         (m32c_gdbarch_init): Don't register deleted functions with
5706         gdbarch.
5707
5708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5709
5710         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5711         (lm32_unwind_pc): Delete.
5712         (lm32_dummy_id): Delete.
5713         (lm32_gdbarch_init): Don't register deleted functions with
5714         gdbarch.
5715
5716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5717
5718         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5719         (iq2000_unwind_pc): Delete.
5720         (iq2000_dummy_id): Delete.
5721         (iq2000_gdbarch_init): Don't register deleted functions with
5722         gdbarch.
5723
5724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * nds32-tdep.c (nds32_type_align): Delete.
5727         (nds32_push_dummy_call): Use type_align instead.
5728
5729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5730
5731         * arm-tdep.c (arm_type_align): Only handle vector override case.
5732         (arm_push_dummy_call): Use type_align.
5733         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5734
5735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5738         case.
5739         (pass_on_stack): Use type_align.
5740         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5741         function.
5742
5743 2019-04-23  Tom Tromey  <tromey@adacore.com>
5744
5745         * dwarf2read.c (line_header::file_name_at): Remove unused
5746         overload.
5747
5748 2019-04-23  Tom de Vries  <tdevries@suse.de>
5749
5750         PR gdb/24438
5751         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5752         invocation.
5753
5754
5755 2019-03-27  Ali Tamur  <tamur@google.com>
5756
5757         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5758         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5759         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5760         (dwarf_expr_context::get_addr_index): Likewise
5761         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5762         (symbol_needs_eval_context::get_addr_index): Likewise
5763         (disassemble_dwarf_expression): Add DW_OP_addrx
5764         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5765         (read_cutu_die_from_dwo): Update comment
5766         (skip_one_die): Add DW_FORM_addrx
5767         (read_attribute_value): Likewise
5768         (var_decode_location): Add DW_OP_addrx
5769         (dwarf2_const_value_attr): Add DW_FORM_addrx
5770         (dump_die_shallow): Likewise
5771         (dwarf2_fetch_constant_bytes): Likewise
5772         (decode_locdesc): Add DW_OP_addrx
5773         (skip_form_bytes): Add DW_FORM_addrx
5774
5775 2019-04-22  Ali Tamur  <tamur@google.com>
5776
5777         * MAINTAINERS (Write After Approval): Add self.
5778
5779 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5780
5781         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5782         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5783         (open_symbol_file_object): Likewise.
5784         (svr4_default_sos): Add info parameter.
5785         (svr4_read_so_list): Likewise.
5786         (svr4_current_sos_direct): Adjust functions calls to pass down
5787         info.
5788         (svr4_current_sos_1): Add info parameter.
5789         (svr4_current_sos): Call get_svr4_info, pass info down to
5790         svr4_current_sos_1.
5791         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5792         get_svr4_info.
5793         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5794         get_svr4_info.
5795         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5796         to get_svr4_info.
5797         (probes_table_remove_objfile_probes): Likewise.
5798         (register_solib_event_probe): Add info parameter.
5799         (solist_update_incremental): Pass info parameter down to
5800         svr4_read_so_list.
5801         (disable_probes_interface): Add info parameter.
5802         (svr4_handle_solib_event): Pass current_program_space to
5803         get_svr4_info.  Adjust disable_probes_interface cleanup.
5804         (svr4_create_probe_breakpoints): Add info parameter, pass it
5805         down to register_solib_event_probe.
5806         (svr4_create_solib_event_breakpoints): Add info parameter,
5807         pass it down to svr4_create_probe_breakpoints.
5808         (enable_break): Pass info down to
5809         svr4_create_solib_event_breakpoints.
5810         (svr4_solib_create_inferior_hook): Pass current_program_space to
5811         get_svr4_info.
5812         (svr4_clear_solib): Likewise.
5813
5814 2019-04-22  Pedro Alves  <palves@redhat.com>
5815
5816         * solib-svr4.c (svr4_free_objfile_observer): New.
5817         (probe_and_action::objfile): New field.
5818         (probes_table_htab_remove_objfile_probes)
5819         (probes_table_remove_objfile_probes): New functions.
5820         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5821         in the new probe_and_action.  Don't store the probe in 'lookup'.
5822         (svr4_create_probe_breakpoints): Pass objfile to
5823         register_solib_event_probe.
5824         (_initialize_svr4_solib): Register a free_objfile observer.
5825
5826 2019-04-19  Tom Tromey  <tom@tromey.com>
5827
5828         * common/queue.h: Remove.
5829
5830 2019-04-19  Tom Tromey  <tom@tromey.com>
5831
5832         * event-loop.c: Don't include "common/queue.h".
5833
5834 2019-04-19  Tom Tromey  <tom@tromey.com>
5835
5836         * remote.c (remote_target): Use delete.
5837         * remote-notif.h: Include <list>, not "common/queue.h".
5838         (notif_client_p): Remove typedef.
5839         (remote_notif_state): Add constructor, destructor, initializer.
5840         <notif_queue>: Now a std::list.
5841         (remote_notif_state_xfree): Don't declare.
5842         * remote-notif.c (remote_notif_process, handle_notification)
5843         (remote_notif_state_allocate): Update.
5844         (~remote_notif_state): Rename from remote_notif_state_xfree.
5845
5846 2019-04-19  Tom Tromey  <tom@tromey.com>
5847
5848         * symfile.c (reread_symbols): Update.
5849         * objfiles.c (objfile_register_static_link)
5850         (objfile_lookup_static_link): Update
5851         (~objfile) Don't delete static_links.
5852         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5853
5854 2019-04-19  Tom Tromey  <tom@tromey.com>
5855
5856         * type-stack.h (struct type_stack) <insert>: Constify string.
5857         * type-stack.c (type_stack::insert): Constify string.
5858         * gdbtypes.h (lookup_template_type): Update.
5859         (address_space_name_to_int): Update.
5860         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5861         const.
5862         (lookup_template_type): Make name const.
5863         * c-exp.y: Update rules.
5864         (lex_one_token, classify_name, classify_inner_name)
5865         (c_print_token): Update.
5866         * p-exp.y: Update rules.
5867         (yylex): Update.
5868         * f-exp.y: Update rules.
5869         (yylex): Update.
5870         * d-exp.y: Update rules.
5871         (lex_one_token, classify_name, classify_inner_name): Update.
5872         * parse.c (write_dollar_variable, copy_name): Return std::string.
5873         * parser-defs.h (copy_name): Change return type.
5874         * m2-exp.y: Update rules.
5875         (yylex): Update.
5876         * go-exp.y (lex_one_token): Update.
5877         Update rules.
5878         (classify_unsafe_function, classify_packaged_name)
5879         (classify_name, yylex): Update.
5880
5881 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5882
5883         * configure.ac: add --enable-source-highlight switch.
5884         * configure: Regenerate.
5885         * top.c (print_gdb_version): plumb --enable-source-highlight
5886         status to "show configuration".
5887
5888 2019-04-19  Tom Tromey  <tromey@adacore.com>
5889
5890         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5891         Check ADA_TYPE_P.
5892         (empty_record, ada_template_to_fixed_record_type_1)
5893         (template_to_static_fixed_type)
5894         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5895         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5896         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5897         macros.
5898
5899 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5900
5901         PR symtab/24423:
5902         * source.c (print_source_lines_base): Advance "iter" when a
5903         control character is seen.
5904
5905 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5906
5907         * inferior.h (struct infcall_suspend_state_deleter):
5908         Catch exception in destructor to avoid crash.
5909
5910 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5911
5912         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5913         close to the add_com "shell".
5914
5915 2019-04-18  Tom Tromey  <tromey@adacore.com>
5916
5917         * process-stratum-target.h (class process_stratum_target)
5918         <stratum>: Add "final".
5919
5920 2019-04-17  Tom Tromey  <tromey@adacore.com>
5921
5922         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5923         against nullptr before use.
5924
5925 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5926
5927         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5928
5929 2019-04-17  Jim Wilson  <jimw@sifive.com>
5930             Andrew Burgess  <andrew.burgess@embecosm.com>
5931
5932         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5933         code read might fail, assume 4-byte breakpoint in that case.
5934
5935 2019-04-15  Leszek Swirski  <leszeks@google.com>
5936
5937         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5938         rather than a hand-rolled POD check when checking for forced MEMORY
5939         classification.
5940
5941 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5942
5943         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5944         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5945         function.
5946         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5947         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5948         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5949         declaration.
5950
5951 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5952
5953         * aarch64-linux-nat.c
5954         (aarch64_linux_nat_target::thread_architecture): Add override.
5955         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5956         each VQ.
5957
5958 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5959
5960         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5961
5962 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5963
5964         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5965         target types of size 96-bits, add some additional comments, and
5966         check that the builtin type we found was the correct size.
5967
5968 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5969
5970         * utils.c (prompt_for_continue): Don't restore the styling at the
5971         end, as applied_style has the wrong value.  This fixes styling in
5972         long lists of file names that are interrupted by the "Continue?"
5973         prompt.
5974
5975 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5976
5977         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5978         * c-lang.c (c_language_defn): Likewise.
5979         (cplus_language_defn): Likewise.
5980         (asm_language_defn): Likewise.
5981         (minimal_language_defn): Likewise.
5982         * d-lang.c (d_language_defn): Likewise.
5983         * f-lang.c (f_language_defn): Likewise.
5984         * go-lang.c (go_language_defn): Likewise.
5985         * language.c (unknown_language_defn): Likewise.
5986         (auto_language_defn): Likewise.
5987         * language.h (struct language_defn): Remove la_magic field.
5988         (LANG_MAGIC): Delete.
5989         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5990         * objc-lang.c (objc_language_defn): Likewise.
5991         * opencl-lang.c (opencl_language_defn): Likewise.
5992         * p-lang.c (pascal_language_defn): Likewise.
5993         * rust-lang.c (rust_language_defn): Likewise.
5994
5995 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5996
5997         * riscv-tdep.c (riscv_type_align): New function.
5998         (riscv_type_alignment): Delete.
5999         (riscv_arg_location): Use 'type_align'.
6000         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6001
6002 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6003
6004         * gdbtypes.c (type_align): A struct with no non-static fields also
6005         has alignment of 1.
6006
6007 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6010         component to 0.
6011         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6012         member.
6013         (riscv_struct_info::analyse): New implementation using new
6014         analyse_inner member function.
6015         (riscv_struct_info::field_offset): New member function.
6016         (riscv_struct_info::m_offsets): New member variable.
6017         (riscv_struct_info::analyse_inner): New private member function,
6018         takes the old implementation of riscv_struct_info::analyse but
6019         extended to track field offsets.
6020         (riscv_call_arg_struct): Update the struct folding special cases
6021         to handle cases where empty C++ structs, which are non-zero
6022         length, are found.
6023         (riscv_arg_location): Initialise the length of each location, a
6024         non-zero length now indicates the location is in use.
6025         (riscv_push_dummy_call): Allow for the first location having a
6026         non-zero offset when setting up arguments.
6027         (riscv_return_value): Likewise, but for return values.
6028
6029 2019-04-11  Tom Tromey  <tromey@adacore.com>
6030
6031         * utils.c (internal_vproblem): Make "msg" const.
6032
6033 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6034
6035         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6036         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6037         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6038         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6039
6040 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6041
6042         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6043         function.
6044         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6045         of amd64_collect_native_gregset.
6046         (amd64_linux_nat_target::store_registers): Likewise.
6047
6048 2019-04-10  Tom Tromey  <tom@tromey.com>
6049
6050         * symtab.c (lookup_global_symbol_from_objfile)
6051         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6052         * objfiles.h (class separate_debug_iterator): New.
6053         (class separate_debug_range): New.
6054         (struct objfile) <separate_debug_objfiles>: New method.
6055         (objfile_separate_debug_iterate): Don't declare.
6056         * objfiles.c (separate_debug_iterator::operator++): Rename from
6057         objfile_separate_debug_iterate.
6058         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6059         iterator.
6060         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6061         iterator.
6062
6063 2019-04-10  Tom Tromey  <tom@tromey.com>
6064
6065         * symfile.c (reread_symbols): Remove old comment.
6066         * objfiles.c (free_all_objfiles): Fix a typo.
6067
6068 2019-04-10  Tom Tromey  <tom@tromey.com>
6069
6070         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6071         * minsyms.c (lookup_minimal_symbol): Use foreach.
6072         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6073         (lookup_minimal_symbol_solib_trampoline): Likewise.
6074         * symfile.c (reread_symbols): Use foreach.
6075
6076 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6077             Tom Tromey  <tromey@adacore.com>
6078
6079         PR rust/24414:
6080         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6081         (rust_lex_int_test): Change "value" to be LONGEST.
6082         (rust_lex_tests): Add test for long integer literal.
6083
6084 2019-04-09  Tom Tromey  <tromey@adacore.com>
6085
6086         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6087         to bool.
6088         (extended_remote_target::attach): Update.
6089         (remote_target::remote_notice_new_inferior): Update.
6090         (remote_target::add_current_inferior_and_thread): Update.
6091         * inferior.c (exit_inferior_1): Use "false".
6092         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6093
6094 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6095
6096         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6097         the "start" command.
6098
6099 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6100
6101         * python/py-inferior.c (infpy_thread_from_thread_handle):
6102         Adjust comments to reflect renaming of thread_from_thread_handle
6103         to thread_from_handle.  Adjust keywords.  Fix type error message.
6104         (inferior_object_methods): Add thread_from_handle.  Retain
6105         thread_from_thread_handle, but mark it as deprecated.
6106
6107 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6108
6109         * gdbthread.h (find_thread_by_handle): Revise declaration.
6110         * thread.c (find_thread_by_handle): Likewise.  Adjust
6111         implementation too.
6112         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6113         support for buffer objects as handles.
6114
6115 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6116
6117         * python/py-infthread.c (thpy_thread_handle): New function.
6118         (thread_object_methods): Register thpy_thread_handle.
6119
6120 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6121
6122         * gdbthread.h (thread_to_thread_handle): Declare.
6123         * thread.c (gdbtypes.h): Include.
6124         (thread_to_thread_handle): New function.
6125
6126         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6127         (target_thread_info_to_thread_handle): Declare.
6128         * target.c (target_thread_info_to_thread_handle): New function.
6129         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6130         * target-delegates.c: Regenerate.
6131
6132         * linux-thread-db.c (class thread_db_target): Add method
6133         thread_info_to_thread_handle.
6134         (thread_db_target::thread_info_to_thread_handle): Define.
6135         * remote.c (class remote_target): Add new method
6136         thread_info_to_thread_handle.
6137         (remote_target::thread_info_to_thread_handle): Define.
6138
6139 2019-04-08  Pedro Alves  <palves@redhat.com>
6140
6141         * common/common-exceptions.c (throw_exception): Don't create
6142         named object to throw; throw directly.
6143         (throw_it): Likewise.  Don't initialize gdb_exception::message
6144         here, with new; pass FMT and AP to the ctor instead.
6145         * common/common-exceptions.h: Include <string>.
6146         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6147         const char *, va_list)): New ctor.  Use std::make_shared.
6148         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6149         errors)): Delete.
6150         (gdb_exception_error::gdb_exception_error(enum errors, const char
6151         *, va_list)): New.
6152         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6153         Add assertion.
6154         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6155         errors)): Delete.
6156         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6157         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6158         Add assertion.
6159
6160 2019-04-08  Tom Tromey  <tom@tromey.com>
6161
6162         * valops.c (value_rtti_indirect_type): Replace throw_exception
6163         with throw.
6164         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6165         with throw.
6166         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6167         throw.
6168         * target.c (target_translate_tls_address): Replace throw_exception
6169         with throw.
6170         * stack.c (frame_apply_command_count): Replace throw_exception
6171         with throw.
6172         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6173         throw.
6174         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6175         with throw.
6176         * rs6000-tdep.c (rs6000_frame_cache)
6177         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6178         * remote.c: Replace throw_exception with throw.
6179         * record-full.c (record_full_message, record_full_wait_1)
6180         (record_full_restore): Replace throw_exception with throw.
6181         * record-btrace.c:
6182         (get_thread_current_frame_id, record_btrace_start_replaying)
6183         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6184         (cmd_record_btrace_start): Replace throw_exception with throw.
6185         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6186         throw.
6187         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6188         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6189         * linespec.c:
6190         (find_linespec_symbols): Replace throw_exception with throw.
6191         * infrun.c (displaced_step_prepare, resume): Replace
6192         throw_exception with throw.
6193         * infcmd.c (post_create_inferior): Replace throw_exception with
6194         throw.
6195         * inf-loop.c (inferior_event_handler): Replace throw_exception
6196         with throw.
6197         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6198         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6199         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6200         (get_prev_frame_always, get_frame_pc_if_available)
6201         (get_frame_address_in_block_if_available, get_frame_language):
6202         Replace throw_exception with throw.
6203         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6204         throw_exception with throw.
6205         * eval.c (fetch_subexp_value, evaluate_var_value)
6206         (evaluate_funcall, evaluate_subexp_standard): Replace
6207         throw_exception with throw.
6208         * dwarf2loc.c (call_site_find_chain)
6209         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6210         Replace throw_exception with throw.
6211         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6212         with throw.
6213         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6214         throw.
6215         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6216         * completer.c (complete_line_internal): Replace throw_exception
6217         with throw.
6218         * compile/compile-object-run.c (compile_object_run): Replace
6219         throw_exception with throw.
6220         * cli/cli-script.c (process_next_line): Replace throw_exception
6221         with throw.
6222         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6223         (btrace_enable, btrace_maint_update_pt_packets): Replace
6224         throw_exception with throw.
6225         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6226         throw_exception with throw.
6227         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6228         throw_exception with throw.
6229         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6230         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6231         * aarch64-tdep.c (aarch64_make_prologue_cache)
6232         (aarch64_make_stub_cache): Replace throw_exception with throw.
6233
6234 2019-04-08  Tom Tromey  <tom@tromey.com>
6235
6236         * common/common-exceptions.c (throw_exception): Rename from
6237         throw_exception_cxx.  Remove old copy.  Make argument const.
6238         (throw_it): Create and throw exception objects directly.
6239         * common/common-exceptions.h (throw_exception): Make argument
6240         const.
6241         (struct gdb_exception_error): Add constructor.
6242         (struct gdb_exception_quit): Add constructor.
6243
6244 2019-04-08  Tom Tromey  <tom@tromey.com>
6245
6246         * common/common-exceptions.h (exception_rethrow): Don't declare.
6247         (TRY_SJLJ): Update comment.
6248         (TRY, CATCH, END_CATCH): Remove.
6249         * common/common-exceptions.c (exception_rethrow): Remove.
6250
6251 2019-04-08  Tom Tromey  <tom@tromey.com>
6252
6253         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6254         Remove.
6255         (gdb_exception_error): Rename from
6256         gdb_exception_RETURN_MASK_ERROR.
6257         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6258         (gdb_quit_bad_alloc): Update.
6259         * aarch64-tdep.c: Update.
6260         * ada-lang.c: Update.
6261         * ada-typeprint.c: Update.
6262         * ada-valprint.c: Update.
6263         * amd64-tdep.c: Update.
6264         * arch-utils.c: Update.
6265         * break-catch-throw.c: Update.
6266         * breakpoint.c: Update.
6267         * btrace.c: Update.
6268         * c-varobj.c: Update.
6269         * cli/cli-cmds.c: Update.
6270         * cli/cli-interp.c: Update.
6271         * cli/cli-script.c: Update.
6272         * common/common-exceptions.c: Update.
6273         * common/new-op.c: Update.
6274         * common/selftest.c: Update.
6275         * compile/compile-c-symbols.c: Update.
6276         * compile/compile-cplus-symbols.c: Update.
6277         * compile/compile-object-load.c: Update.
6278         * compile/compile-object-run.c: Update.
6279         * completer.c: Update.
6280         * corelow.c: Update.
6281         * cp-abi.c: Update.
6282         * cp-support.c: Update.
6283         * cp-valprint.c: Update.
6284         * darwin-nat.c: Update.
6285         * disasm-selftests.c: Update.
6286         * dtrace-probe.c: Update.
6287         * dwarf-index-cache.c: Update.
6288         * dwarf-index-write.c: Update.
6289         * dwarf2-frame-tailcall.c: Update.
6290         * dwarf2-frame.c: Update.
6291         * dwarf2loc.c: Update.
6292         * dwarf2read.c: Update.
6293         * eval.c: Update.
6294         * event-loop.c: Update.
6295         * event-top.c: Update.
6296         * exec.c: Update.
6297         * f-valprint.c: Update.
6298         * fbsd-tdep.c: Update.
6299         * frame-unwind.c: Update.
6300         * frame.c: Update.
6301         * gdbtypes.c: Update.
6302         * gnu-v3-abi.c: Update.
6303         * guile/guile-internal.h: Update.
6304         * guile/scm-block.c: Update.
6305         * guile/scm-breakpoint.c: Update.
6306         * guile/scm-cmd.c: Update.
6307         * guile/scm-disasm.c: Update.
6308         * guile/scm-frame.c: Update.
6309         * guile/scm-lazy-string.c: Update.
6310         * guile/scm-math.c: Update.
6311         * guile/scm-param.c: Update.
6312         * guile/scm-ports.c: Update.
6313         * guile/scm-pretty-print.c: Update.
6314         * guile/scm-symbol.c: Update.
6315         * guile/scm-symtab.c: Update.
6316         * guile/scm-type.c: Update.
6317         * guile/scm-value.c: Update.
6318         * i386-linux-tdep.c: Update.
6319         * i386-tdep.c: Update.
6320         * inf-loop.c: Update.
6321         * infcall.c: Update.
6322         * infcmd.c: Update.
6323         * infrun.c: Update.
6324         * jit.c: Update.
6325         * language.c: Update.
6326         * linespec.c: Update.
6327         * linux-fork.c: Update.
6328         * linux-nat.c: Update.
6329         * linux-tdep.c: Update.
6330         * linux-thread-db.c: Update.
6331         * main.c: Update.
6332         * mi/mi-cmd-break.c: Update.
6333         * mi/mi-cmd-stack.c: Update.
6334         * mi/mi-interp.c: Update.
6335         * mi/mi-main.c: Update.
6336         * objc-lang.c: Update.
6337         * p-valprint.c: Update.
6338         * parse.c: Update.
6339         * ppc-linux-tdep.c: Update.
6340         * printcmd.c: Update.
6341         * python/py-arch.c: Update.
6342         * python/py-breakpoint.c: Update.
6343         * python/py-cmd.c: Update.
6344         * python/py-finishbreakpoint.c: Update.
6345         * python/py-frame.c: Update.
6346         * python/py-framefilter.c: Update.
6347         * python/py-gdb-readline.c: Update.
6348         * python/py-inferior.c: Update.
6349         * python/py-infthread.c: Update.
6350         * python/py-lazy-string.c: Update.
6351         * python/py-linetable.c: Update.
6352         * python/py-objfile.c: Update.
6353         * python/py-param.c: Update.
6354         * python/py-prettyprint.c: Update.
6355         * python/py-progspace.c: Update.
6356         * python/py-record-btrace.c: Update.
6357         * python/py-record.c: Update.
6358         * python/py-symbol.c: Update.
6359         * python/py-type.c: Update.
6360         * python/py-unwind.c: Update.
6361         * python/py-utils.c: Update.
6362         * python/py-value.c: Update.
6363         * python/python.c: Update.
6364         * record-btrace.c: Update.
6365         * record-full.c: Update.
6366         * remote-fileio.c: Update.
6367         * remote.c: Update.
6368         * riscv-tdep.c: Update.
6369         * rs6000-aix-tdep.c: Update.
6370         * rs6000-tdep.c: Update.
6371         * rust-exp.y: Update.
6372         * rust-lang.c: Update.
6373         * s390-tdep.c: Update.
6374         * selftest-arch.c: Update.
6375         * solib-dsbt.c: Update.
6376         * solib-frv.c: Update.
6377         * solib-spu.c: Update.
6378         * solib-svr4.c: Update.
6379         * solib.c: Update.
6380         * sparc64-linux-tdep.c: Update.
6381         * stack.c: Update.
6382         * symfile-mem.c: Update.
6383         * symmisc.c: Update.
6384         * target.c: Update.
6385         * thread.c: Update.
6386         * top.c: Update.
6387         * tracefile-tfile.c: Update.
6388         * tui/tui.c: Update.
6389         * typeprint.c: Update.
6390         * unittests/cli-utils-selftests.c: Update.
6391         * unittests/parse-connection-spec-selftests.c: Update.
6392         * valops.c: Update.
6393         * valprint.c: Update.
6394         * value.c: Update.
6395         * varobj.c: Update.
6396         * windows-nat.c: Update.
6397         * x86-linux-nat.c: Update.
6398         * xml-support.c: Update.
6399
6400 2019-04-08  Tom Tromey  <tom@tromey.com>
6401
6402         * xml-support.c: Use C++ exception handling.
6403         * x86-linux-nat.c: Use C++ exception handling.
6404         * windows-nat.c: Use C++ exception handling.
6405         * varobj.c: Use C++ exception handling.
6406         * value.c: Use C++ exception handling.
6407         * valprint.c: Use C++ exception handling.
6408         * valops.c: Use C++ exception handling.
6409         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6410         handling.
6411         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6412         * typeprint.c: Use C++ exception handling.
6413         * tui/tui.c: Use C++ exception handling.
6414         * tracefile-tfile.c: Use C++ exception handling.
6415         * top.c: Use C++ exception handling.
6416         * thread.c: Use C++ exception handling.
6417         * target.c: Use C++ exception handling.
6418         * symmisc.c: Use C++ exception handling.
6419         * symfile-mem.c: Use C++ exception handling.
6420         * stack.c: Use C++ exception handling.
6421         * sparc64-linux-tdep.c: Use C++ exception handling.
6422         * solib.c: Use C++ exception handling.
6423         * solib-svr4.c: Use C++ exception handling.
6424         * solib-spu.c: Use C++ exception handling.
6425         * solib-frv.c: Use C++ exception handling.
6426         * solib-dsbt.c: Use C++ exception handling.
6427         * selftest-arch.c: Use C++ exception handling.
6428         * s390-tdep.c: Use C++ exception handling.
6429         * rust-lang.c: Use C++ exception handling.
6430         * rust-exp.y: Use C++ exception handling.
6431         * rs6000-tdep.c: Use C++ exception handling.
6432         * rs6000-aix-tdep.c: Use C++ exception handling.
6433         * riscv-tdep.c: Use C++ exception handling.
6434         * remote.c: Use C++ exception handling.
6435         * remote-fileio.c: Use C++ exception handling.
6436         * record-full.c: Use C++ exception handling.
6437         * record-btrace.c: Use C++ exception handling.
6438         * python/python.c: Use C++ exception handling.
6439         * python/py-value.c: Use C++ exception handling.
6440         * python/py-utils.c: Use C++ exception handling.
6441         * python/py-unwind.c: Use C++ exception handling.
6442         * python/py-type.c: Use C++ exception handling.
6443         * python/py-symbol.c: Use C++ exception handling.
6444         * python/py-record.c: Use C++ exception handling.
6445         * python/py-record-btrace.c: Use C++ exception handling.
6446         * python/py-progspace.c: Use C++ exception handling.
6447         * python/py-prettyprint.c: Use C++ exception handling.
6448         * python/py-param.c: Use C++ exception handling.
6449         * python/py-objfile.c: Use C++ exception handling.
6450         * python/py-linetable.c: Use C++ exception handling.
6451         * python/py-lazy-string.c: Use C++ exception handling.
6452         * python/py-infthread.c: Use C++ exception handling.
6453         * python/py-inferior.c: Use C++ exception handling.
6454         * python/py-gdb-readline.c: Use C++ exception handling.
6455         * python/py-framefilter.c: Use C++ exception handling.
6456         * python/py-frame.c: Use C++ exception handling.
6457         * python/py-finishbreakpoint.c: Use C++ exception handling.
6458         * python/py-cmd.c: Use C++ exception handling.
6459         * python/py-breakpoint.c: Use C++ exception handling.
6460         * python/py-arch.c: Use C++ exception handling.
6461         * printcmd.c: Use C++ exception handling.
6462         * ppc-linux-tdep.c: Use C++ exception handling.
6463         * parse.c: Use C++ exception handling.
6464         * p-valprint.c: Use C++ exception handling.
6465         * objc-lang.c: Use C++ exception handling.
6466         * mi/mi-main.c: Use C++ exception handling.
6467         * mi/mi-interp.c: Use C++ exception handling.
6468         * mi/mi-cmd-stack.c: Use C++ exception handling.
6469         * mi/mi-cmd-break.c: Use C++ exception handling.
6470         * main.c: Use C++ exception handling.
6471         * linux-thread-db.c: Use C++ exception handling.
6472         * linux-tdep.c: Use C++ exception handling.
6473         * linux-nat.c: Use C++ exception handling.
6474         * linux-fork.c: Use C++ exception handling.
6475         * linespec.c: Use C++ exception handling.
6476         * language.c: Use C++ exception handling.
6477         * jit.c: Use C++ exception handling.
6478         * infrun.c: Use C++ exception handling.
6479         * infcmd.c: Use C++ exception handling.
6480         * infcall.c: Use C++ exception handling.
6481         * inf-loop.c: Use C++ exception handling.
6482         * i386-tdep.c: Use C++ exception handling.
6483         * i386-linux-tdep.c: Use C++ exception handling.
6484         * guile/scm-value.c: Use C++ exception handling.
6485         * guile/scm-type.c: Use C++ exception handling.
6486         * guile/scm-symtab.c: Use C++ exception handling.
6487         * guile/scm-symbol.c: Use C++ exception handling.
6488         * guile/scm-pretty-print.c: Use C++ exception handling.
6489         * guile/scm-ports.c: Use C++ exception handling.
6490         * guile/scm-param.c: Use C++ exception handling.
6491         * guile/scm-math.c: Use C++ exception handling.
6492         * guile/scm-lazy-string.c: Use C++ exception handling.
6493         * guile/scm-frame.c: Use C++ exception handling.
6494         * guile/scm-disasm.c: Use C++ exception handling.
6495         * guile/scm-cmd.c: Use C++ exception handling.
6496         * guile/scm-breakpoint.c: Use C++ exception handling.
6497         * guile/scm-block.c: Use C++ exception handling.
6498         * guile/guile-internal.h: Use C++ exception handling.
6499         * gnu-v3-abi.c: Use C++ exception handling.
6500         * gdbtypes.c: Use C++ exception handling.
6501         * frame.c: Use C++ exception handling.
6502         * frame-unwind.c: Use C++ exception handling.
6503         * fbsd-tdep.c: Use C++ exception handling.
6504         * f-valprint.c: Use C++ exception handling.
6505         * exec.c: Use C++ exception handling.
6506         * event-top.c: Use C++ exception handling.
6507         * event-loop.c: Use C++ exception handling.
6508         * eval.c: Use C++ exception handling.
6509         * dwarf2read.c: Use C++ exception handling.
6510         * dwarf2loc.c: Use C++ exception handling.
6511         * dwarf2-frame.c: Use C++ exception handling.
6512         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6513         * dwarf-index-write.c: Use C++ exception handling.
6514         * dwarf-index-cache.c: Use C++ exception handling.
6515         * dtrace-probe.c: Use C++ exception handling.
6516         * disasm-selftests.c: Use C++ exception handling.
6517         * darwin-nat.c: Use C++ exception handling.
6518         * cp-valprint.c: Use C++ exception handling.
6519         * cp-support.c: Use C++ exception handling.
6520         * cp-abi.c: Use C++ exception handling.
6521         * corelow.c: Use C++ exception handling.
6522         * completer.c: Use C++ exception handling.
6523         * compile/compile-object-run.c: Use C++ exception handling.
6524         * compile/compile-object-load.c: Use C++ exception handling.
6525         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6526         * compile/compile-c-symbols.c: Use C++ exception handling.
6527         * common/selftest.c: Use C++ exception handling.
6528         * common/new-op.c: Use C++ exception handling.
6529         * cli/cli-script.c: Use C++ exception handling.
6530         * cli/cli-interp.c: Use C++ exception handling.
6531         * cli/cli-cmds.c: Use C++ exception handling.
6532         * c-varobj.c: Use C++ exception handling.
6533         * btrace.c: Use C++ exception handling.
6534         * breakpoint.c: Use C++ exception handling.
6535         * break-catch-throw.c: Use C++ exception handling.
6536         * arch-utils.c: Use C++ exception handling.
6537         * amd64-tdep.c: Use C++ exception handling.
6538         * ada-valprint.c: Use C++ exception handling.
6539         * ada-typeprint.c: Use C++ exception handling.
6540         * ada-lang.c: Use C++ exception handling.
6541         * aarch64-tdep.c: Use C++ exception handling.
6542
6543 2019-04-08  Tom Tromey  <tom@tromey.com>
6544
6545         * xml-support.c (gdb_xml_parser::parse): Update.
6546         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6547         * value.c (show_convenience): Update.
6548         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6549         (test_parse_flags_qcs): Update.
6550         * thread.c (thr_try_catch_cmd): Update.
6551         * target.c (target_translate_tls_address): Update.
6552         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6553         (info_frame_command_core, frame_apply_command_count): Update.
6554         * rust-exp.y (rust_lex_exception_test): Update.
6555         * riscv-tdep.c (riscv_print_one_register_info): Update.
6556         * remote.c (remote_target::enable_btrace): Update.
6557         * record-btrace.c (record_btrace_enable_warn): Update.
6558         * python/py-utils.c (gdbpy_convert_exception): Update.
6559         * printcmd.c (do_one_display, print_variable_and_value): Update.
6560         * mi/mi-main.c (mi_print_exception): Update.
6561         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6562         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6563         * linux-nat.c (linux_nat_target::attach): Update.
6564         * linux-fork.c (class scoped_switch_fork_info): Update.
6565         * infrun.c (displaced_step_prepare): Update.
6566         * infcall.c (call_function_by_hand_dummy): Update.
6567         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6568         * gnu-v3-abi.c (print_one_vtable): Update.
6569         * frame.c (get_prev_frame_always): Update.
6570         * f-valprint.c (info_common_command_for_block): Update.
6571         * exec.c (try_open_exec_file): Update.
6572         * exceptions.c (print_exception, exception_print)
6573         (exception_fprintf, exception_print_same): Update.
6574         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6575         * dwarf-index-cache.c (index_cache::store)
6576         (index_cache::lookup_gdb_index): Update.
6577         * darwin-nat.c (maybe_cache_shell): Update.
6578         * cp-valprint.c (cp_print_value_fields): Update.
6579         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6580         (gcc_cplus_symbol_address): Update.
6581         * compile/compile-c-symbols.c (gcc_convert_symbol)
6582         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6583         * common/selftest.c: Update.
6584         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6585         a std::string.
6586         (exception_try_scope_entry, exception_try_scope_exit): Don't
6587         declare.
6588         (struct exception_try_scope): Remove.
6589         (TRY): Don't use exception_try_scope.
6590         (struct gdb_exception): Add constructor, operator=.
6591         <what>: New method.
6592         (struct gdb_exception_RETURN_MASK_ALL)
6593         (struct gdb_exception_RETURN_MASK_ERROR)
6594         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6595         (struct gdb_quit_bad_alloc): Update.
6596         * common/common-exceptions.c (exception_none): Change
6597         initializer.
6598         (struct catcher) <state, exception>: Initialize inline.
6599         <prev>: Remove member.
6600         (current_catcher): Remove.
6601         (catchers): New global.
6602         (exceptions_state_mc_init): Simplify.
6603         (catcher_pop): Remove.
6604         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6605         (try_scope_depth, exception_try_scope_entry)
6606         (exception_try_scope_exit): Remove.
6607         (throw_exception_sjlj): Update.
6608         (exception_messages, exception_messages_size): Remove.
6609         (throw_it): Simplify.
6610         (gdb_exception_sliced_copy): Remove.
6611         (throw_exception_cxx): Update.
6612         * cli/cli-script.c (script_from_file): Update.
6613         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6614         Update.
6615         * ada-valprint.c (ada_val_print): Update.
6616         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6617         (create_excep_cond_exprs): Update.
6618
6619 2019-04-08  Tom Tromey  <tom@tromey.com>
6620
6621         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6622         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6623         (TRY, CATCH, END_CATCH): Remove some definitions.
6624         * common/common-exceptions.c: Don't use GDB_XCPT.
6625         (catcher_list_size): Remove.
6626         (throw_exception, throw_it): Simplify.
6627
6628 2019-04-05  Tom Tromey  <tom@tromey.com>
6629
6630         Revert the header-sorting patch.
6631         * ft32-tdep.c: Revert.
6632         * frv-tdep.c: Revert.
6633         * frv-linux-tdep.c: Revert.
6634         * frame.c: Revert.
6635         * frame-unwind.c: Revert.
6636         * frame-base.c: Revert.
6637         * fork-child.c: Revert.
6638         * findvar.c: Revert.
6639         * findcmd.c: Revert.
6640         * filesystem.c: Revert.
6641         * filename-seen-cache.h: Revert.
6642         * filename-seen-cache.c: Revert.
6643         * fbsd-tdep.c: Revert.
6644         * fbsd-nat.h: Revert.
6645         * fbsd-nat.c: Revert.
6646         * f-valprint.c: Revert.
6647         * f-typeprint.c: Revert.
6648         * f-lang.c: Revert.
6649         * extension.h: Revert.
6650         * extension.c: Revert.
6651         * extension-priv.h: Revert.
6652         * expprint.c: Revert.
6653         * exec.h: Revert.
6654         * exec.c: Revert.
6655         * exceptions.c: Revert.
6656         * event-top.c: Revert.
6657         * event-loop.c: Revert.
6658         * eval.c: Revert.
6659         * elfread.c: Revert.
6660         * dwarf2read.h: Revert.
6661         * dwarf2read.c: Revert.
6662         * dwarf2loc.c: Revert.
6663         * dwarf2expr.h: Revert.
6664         * dwarf2expr.c: Revert.
6665         * dwarf2-frame.c: Revert.
6666         * dwarf2-frame-tailcall.c: Revert.
6667         * dwarf-index-write.h: Revert.
6668         * dwarf-index-write.c: Revert.
6669         * dwarf-index-common.c: Revert.
6670         * dwarf-index-cache.h: Revert.
6671         * dwarf-index-cache.c: Revert.
6672         * dummy-frame.c: Revert.
6673         * dtrace-probe.c: Revert.
6674         * disasm.h: Revert.
6675         * disasm.c: Revert.
6676         * disasm-selftests.c: Revert.
6677         * dictionary.c: Revert.
6678         * dicos-tdep.c: Revert.
6679         * demangle.c: Revert.
6680         * dcache.h: Revert.
6681         * dcache.c: Revert.
6682         * darwin-nat.h: Revert.
6683         * darwin-nat.c: Revert.
6684         * darwin-nat-info.c: Revert.
6685         * d-valprint.c: Revert.
6686         * d-namespace.c: Revert.
6687         * d-lang.c: Revert.
6688         * ctf.c: Revert.
6689         * csky-tdep.c: Revert.
6690         * csky-linux-tdep.c: Revert.
6691         * cris-tdep.c: Revert.
6692         * cris-linux-tdep.c: Revert.
6693         * cp-valprint.c: Revert.
6694         * cp-support.c: Revert.
6695         * cp-namespace.c: Revert.
6696         * cp-abi.c: Revert.
6697         * corelow.c: Revert.
6698         * corefile.c: Revert.
6699         * continuations.c: Revert.
6700         * completer.h: Revert.
6701         * completer.c: Revert.
6702         * complaints.c: Revert.
6703         * coffread.c: Revert.
6704         * coff-pe-read.c: Revert.
6705         * cli-out.h: Revert.
6706         * cli-out.c: Revert.
6707         * charset.c: Revert.
6708         * c-varobj.c: Revert.
6709         * c-valprint.c: Revert.
6710         * c-typeprint.c: Revert.
6711         * c-lang.c: Revert.
6712         * buildsym.c: Revert.
6713         * buildsym-legacy.c: Revert.
6714         * build-id.h: Revert.
6715         * build-id.c: Revert.
6716         * btrace.c: Revert.
6717         * bsd-uthread.c: Revert.
6718         * breakpoint.h: Revert.
6719         * breakpoint.c: Revert.
6720         * break-catch-throw.c: Revert.
6721         * break-catch-syscall.c: Revert.
6722         * break-catch-sig.c: Revert.
6723         * blockframe.c: Revert.
6724         * block.c: Revert.
6725         * bfin-tdep.c: Revert.
6726         * bfin-linux-tdep.c: Revert.
6727         * bfd-target.c: Revert.
6728         * bcache.c: Revert.
6729         * ax-general.c: Revert.
6730         * ax-gdb.h: Revert.
6731         * ax-gdb.c: Revert.
6732         * avr-tdep.c: Revert.
6733         * auxv.c: Revert.
6734         * auto-load.c: Revert.
6735         * arm-wince-tdep.c: Revert.
6736         * arm-tdep.c: Revert.
6737         * arm-symbian-tdep.c: Revert.
6738         * arm-pikeos-tdep.c: Revert.
6739         * arm-obsd-tdep.c: Revert.
6740         * arm-nbsd-tdep.c: Revert.
6741         * arm-nbsd-nat.c: Revert.
6742         * arm-linux-tdep.c: Revert.
6743         * arm-linux-nat.c: Revert.
6744         * arm-fbsd-tdep.c: Revert.
6745         * arm-fbsd-nat.c: Revert.
6746         * arm-bsd-tdep.c: Revert.
6747         * arch-utils.c: Revert.
6748         * arc-tdep.c: Revert.
6749         * arc-newlib-tdep.c: Revert.
6750         * annotate.h: Revert.
6751         * annotate.c: Revert.
6752         * amd64-windows-tdep.c: Revert.
6753         * amd64-windows-nat.c: Revert.
6754         * amd64-tdep.c: Revert.
6755         * amd64-sol2-tdep.c: Revert.
6756         * amd64-obsd-tdep.c: Revert.
6757         * amd64-obsd-nat.c: Revert.
6758         * amd64-nbsd-tdep.c: Revert.
6759         * amd64-nbsd-nat.c: Revert.
6760         * amd64-nat.c: Revert.
6761         * amd64-linux-tdep.c: Revert.
6762         * amd64-linux-nat.c: Revert.
6763         * amd64-fbsd-tdep.c: Revert.
6764         * amd64-fbsd-nat.c: Revert.
6765         * amd64-dicos-tdep.c: Revert.
6766         * amd64-darwin-tdep.c: Revert.
6767         * amd64-bsd-nat.c: Revert.
6768         * alpha-tdep.c: Revert.
6769         * alpha-obsd-tdep.c: Revert.
6770         * alpha-nbsd-tdep.c: Revert.
6771         * alpha-mdebug-tdep.c: Revert.
6772         * alpha-linux-tdep.c: Revert.
6773         * alpha-linux-nat.c: Revert.
6774         * alpha-bsd-tdep.c: Revert.
6775         * alpha-bsd-nat.c: Revert.
6776         * aix-thread.c: Revert.
6777         * agent.c: Revert.
6778         * addrmap.c: Revert.
6779         * ada-varobj.c: Revert.
6780         * ada-valprint.c: Revert.
6781         * ada-typeprint.c: Revert.
6782         * ada-tasks.c: Revert.
6783         * ada-lang.c: Revert.
6784         * aarch64-tdep.c: Revert.
6785         * aarch64-ravenscar-thread.c: Revert.
6786         * aarch64-newlib-tdep.c: Revert.
6787         * aarch64-linux-tdep.c: Revert.
6788         * aarch64-linux-nat.c: Revert.
6789         * aarch64-fbsd-tdep.c: Revert.
6790         * aarch64-fbsd-nat.c: Revert.
6791         * aarch32-linux-nat.c: Revert.
6792
6793 2019-04-05  Tom Tromey  <tom@tromey.com>
6794
6795         * ft32-tdep.c: Sort headers.
6796         * frv-tdep.c: Sort headers.
6797         * frv-linux-tdep.c: Sort headers.
6798         * frame.c: Sort headers.
6799         * frame-unwind.c: Sort headers.
6800         * frame-base.c: Sort headers.
6801         * fork-child.c: Sort headers.
6802         * findvar.c: Sort headers.
6803         * findcmd.c: Sort headers.
6804         * filesystem.c: Sort headers.
6805         * filename-seen-cache.h: Sort headers.
6806         * filename-seen-cache.c: Sort headers.
6807         * fbsd-tdep.c: Sort headers.
6808         * fbsd-nat.h: Sort headers.
6809         * fbsd-nat.c: Sort headers.
6810         * f-valprint.c: Sort headers.
6811         * f-typeprint.c: Sort headers.
6812         * f-lang.c: Sort headers.
6813         * extension.h: Sort headers.
6814         * extension.c: Sort headers.
6815         * extension-priv.h: Sort headers.
6816         * expprint.c: Sort headers.
6817         * exec.h: Sort headers.
6818         * exec.c: Sort headers.
6819         * exceptions.c: Sort headers.
6820         * event-top.c: Sort headers.
6821         * event-loop.c: Sort headers.
6822         * eval.c: Sort headers.
6823         * elfread.c: Sort headers.
6824         * dwarf2read.h: Sort headers.
6825         * dwarf2read.c: Sort headers.
6826         * dwarf2loc.c: Sort headers.
6827         * dwarf2expr.h: Sort headers.
6828         * dwarf2expr.c: Sort headers.
6829         * dwarf2-frame.c: Sort headers.
6830         * dwarf2-frame-tailcall.c: Sort headers.
6831         * dwarf-index-write.h: Sort headers.
6832         * dwarf-index-write.c: Sort headers.
6833         * dwarf-index-common.c: Sort headers.
6834         * dwarf-index-cache.h: Sort headers.
6835         * dwarf-index-cache.c: Sort headers.
6836         * dummy-frame.c: Sort headers.
6837         * dtrace-probe.c: Sort headers.
6838         * disasm.h: Sort headers.
6839         * disasm.c: Sort headers.
6840         * disasm-selftests.c: Sort headers.
6841         * dictionary.c: Sort headers.
6842         * dicos-tdep.c: Sort headers.
6843         * demangle.c: Sort headers.
6844         * dcache.h: Sort headers.
6845         * dcache.c: Sort headers.
6846         * darwin-nat.h: Sort headers.
6847         * darwin-nat.c: Sort headers.
6848         * darwin-nat-info.c: Sort headers.
6849         * d-valprint.c: Sort headers.
6850         * d-namespace.c: Sort headers.
6851         * d-lang.c: Sort headers.
6852         * ctf.c: Sort headers.
6853         * csky-tdep.c: Sort headers.
6854         * csky-linux-tdep.c: Sort headers.
6855         * cris-tdep.c: Sort headers.
6856         * cris-linux-tdep.c: Sort headers.
6857         * cp-valprint.c: Sort headers.
6858         * cp-support.c: Sort headers.
6859         * cp-namespace.c: Sort headers.
6860         * cp-abi.c: Sort headers.
6861         * corelow.c: Sort headers.
6862         * corefile.c: Sort headers.
6863         * continuations.c: Sort headers.
6864         * completer.h: Sort headers.
6865         * completer.c: Sort headers.
6866         * complaints.c: Sort headers.
6867         * coffread.c: Sort headers.
6868         * coff-pe-read.c: Sort headers.
6869         * cli-out.h: Sort headers.
6870         * cli-out.c: Sort headers.
6871         * charset.c: Sort headers.
6872         * c-varobj.c: Sort headers.
6873         * c-valprint.c: Sort headers.
6874         * c-typeprint.c: Sort headers.
6875         * c-lang.c: Sort headers.
6876         * buildsym.c: Sort headers.
6877         * buildsym-legacy.c: Sort headers.
6878         * build-id.h: Sort headers.
6879         * build-id.c: Sort headers.
6880         * btrace.c: Sort headers.
6881         * bsd-uthread.c: Sort headers.
6882         * breakpoint.h: Sort headers.
6883         * breakpoint.c: Sort headers.
6884         * break-catch-throw.c: Sort headers.
6885         * break-catch-syscall.c: Sort headers.
6886         * break-catch-sig.c: Sort headers.
6887         * blockframe.c: Sort headers.
6888         * block.c: Sort headers.
6889         * bfin-tdep.c: Sort headers.
6890         * bfin-linux-tdep.c: Sort headers.
6891         * bfd-target.c: Sort headers.
6892         * bcache.c: Sort headers.
6893         * ax-general.c: Sort headers.
6894         * ax-gdb.h: Sort headers.
6895         * ax-gdb.c: Sort headers.
6896         * avr-tdep.c: Sort headers.
6897         * auxv.c: Sort headers.
6898         * auto-load.c: Sort headers.
6899         * arm-wince-tdep.c: Sort headers.
6900         * arm-tdep.c: Sort headers.
6901         * arm-symbian-tdep.c: Sort headers.
6902         * arm-pikeos-tdep.c: Sort headers.
6903         * arm-obsd-tdep.c: Sort headers.
6904         * arm-nbsd-tdep.c: Sort headers.
6905         * arm-nbsd-nat.c: Sort headers.
6906         * arm-linux-tdep.c: Sort headers.
6907         * arm-linux-nat.c: Sort headers.
6908         * arm-fbsd-tdep.c: Sort headers.
6909         * arm-fbsd-nat.c: Sort headers.
6910         * arm-bsd-tdep.c: Sort headers.
6911         * arch-utils.c: Sort headers.
6912         * arc-tdep.c: Sort headers.
6913         * arc-newlib-tdep.c: Sort headers.
6914         * annotate.h: Sort headers.
6915         * annotate.c: Sort headers.
6916         * amd64-windows-tdep.c: Sort headers.
6917         * amd64-windows-nat.c: Sort headers.
6918         * amd64-tdep.c: Sort headers.
6919         * amd64-sol2-tdep.c: Sort headers.
6920         * amd64-obsd-tdep.c: Sort headers.
6921         * amd64-obsd-nat.c: Sort headers.
6922         * amd64-nbsd-tdep.c: Sort headers.
6923         * amd64-nbsd-nat.c: Sort headers.
6924         * amd64-nat.c: Sort headers.
6925         * amd64-linux-tdep.c: Sort headers.
6926         * amd64-linux-nat.c: Sort headers.
6927         * amd64-fbsd-tdep.c: Sort headers.
6928         * amd64-fbsd-nat.c: Sort headers.
6929         * amd64-dicos-tdep.c: Sort headers.
6930         * amd64-darwin-tdep.c: Sort headers.
6931         * amd64-bsd-nat.c: Sort headers.
6932         * alpha-tdep.c: Sort headers.
6933         * alpha-obsd-tdep.c: Sort headers.
6934         * alpha-nbsd-tdep.c: Sort headers.
6935         * alpha-mdebug-tdep.c: Sort headers.
6936         * alpha-linux-tdep.c: Sort headers.
6937         * alpha-linux-nat.c: Sort headers.
6938         * alpha-bsd-tdep.c: Sort headers.
6939         * alpha-bsd-nat.c: Sort headers.
6940         * aix-thread.c: Sort headers.
6941         * agent.c: Sort headers.
6942         * addrmap.c: Sort headers.
6943         * ada-varobj.c: Sort headers.
6944         * ada-valprint.c: Sort headers.
6945         * ada-typeprint.c: Sort headers.
6946         * ada-tasks.c: Sort headers.
6947         * ada-lang.c: Sort headers.
6948         * aarch64-tdep.c: Sort headers.
6949         * aarch64-ravenscar-thread.c: Sort headers.
6950         * aarch64-newlib-tdep.c: Sort headers.
6951         * aarch64-linux-tdep.c: Sort headers.
6952         * aarch64-linux-nat.c: Sort headers.
6953         * aarch64-fbsd-tdep.c: Sort headers.
6954         * aarch64-fbsd-nat.c: Sort headers.
6955         * aarch32-linux-nat.c: Sort headers.
6956
6957 2019-04-04  Tom Tromey  <tom@tromey.com>
6958
6959         * varobj.c (varobj_create): Update.
6960         * rust-exp.y (struct rust_parser) <update_innermost_block,
6961         lookup_symbol>: New methods.
6962         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6963         Rename.
6964         (rust_parser::rust_lookup_type)
6965         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6966         * printcmd.c (display_command, do_one_display): Update.
6967         * parser-defs.h (struct parser_state) <parser_state>: Add
6968         "tracker" parameter.
6969         (block_tracker): New member.
6970         (class innermost_block_tracker) <innermost_block_tracker>: Add
6971         "types" parameter.
6972         <reset>: Remove method.
6973         (innermost_block): Don't declare.
6974         (null_post_parser): Update.
6975         * parse.c (innermost_block): Remove global.
6976         (write_dollar_variable): Update.
6977         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6978         Remove "tracker_types" parameter.
6979         (parse_expression): Add "tracker" parameter.
6980         (parse_expression_for_completion): Update.
6981         (null_post_parser): Add "tracker" parameter.
6982         * p-exp.y: Update rules.
6983         * m2-exp.y: Update rules.
6984         * language.h (struct language_defn) <la_post_parser>: Add
6985         "tracker" parameter.
6986         * go-exp.y: Update rules.
6987         * f-exp.y: Update rules.
6988         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6989         parameter.
6990         * d-exp.y: Update rules.
6991         * c-exp.y: Update rules.
6992         * breakpoint.c (set_breakpoint_condition): Create an
6993         innermost_block_tracker.
6994         (watch_command_1): Likewise.
6995         * ada-lang.c (resolve): Add "tracker" parameter.
6996         (resolve_subexp): Likewise.
6997         * ada-exp.y (write_var_from_sym): Update.
6998
6999 2019-04-04  Tom Tromey  <tom@tromey.com>
7000
7001         * type-stack.h: New file.
7002         * type-stack.c: New file.
7003         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7004         type-stack.h.
7005         (insert_into_type_stack, insert_type, push_type, push_type_int)
7006         (insert_type_address_space, pop_type, pop_type_int)
7007         (pop_typelist, pop_type_stack, append_type_stack)
7008         (push_type_stack, get_type_stack, push_typelist)
7009         (follow_type_instance_flags, follow_types): Don't declare.
7010         * parse.c (type_stack): Remove global.
7011         (parse_exp_in_context): Update.
7012         (insert_into_type_stack, insert_type, push_type, push_type_int)
7013         (insert_type_address_space, pop_type, pop_type_int)
7014         (pop_typelist, pop_type_stack, append_type_stack)
7015         (push_type_stack, get_type_stack, push_typelist)
7016         (follow_type_instance_flags, follow_types): Remove (moved to
7017         type-stack.c).
7018         * f-exp.y (type_stack): New global.
7019         Update rules.
7020         (push_kind_type, f_parse): Update.
7021         * d-exp.y (type_stack): New global.
7022         Update rules.
7023         (d_parse): Update.
7024         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7025         Update rules.
7026         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7027         (HFILES_NO_SRCDIR): Add type-stack.h.
7028
7029 2019-04-04  Tom Tromey  <tom@tromey.com>
7030
7031         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7032         (rust_parser::convert_ast_to_expression, rust_parse)
7033         (rust_lex_test_completion, rust_lex_tests): Update.
7034         * parser-defs.h (struct expr_completion_state): New.
7035         (struct parser_state) <parser_state>: Add completion parameter.
7036         <mark_struct_expression, mark_completion_tag>: New methods.
7037         <parse_completion, m_completion_state>: New members.
7038         (prefixify_expression, null_post_parser): Update.
7039         (mark_struct_expression, mark_completion_tag): Don't declare.
7040         * parse.c (parse_completion, expout_last_struct)
7041         (expout_tag_completion_type, expout_completion_name): Remove
7042         globals.
7043         (parser_state::mark_struct_expression)
7044         (parser_state::mark_completion_tag): Now methods.
7045         (prefixify_expression): Add last_struct parameter.
7046         (prefixify_subexp): Likewise.
7047         (parse_exp_1): Update.
7048         (parse_exp_in_context): Add cstate parameter.  Update.
7049         (parse_expression_for_completion): Create an
7050         expr_completion_state.
7051         (null_post_parser): Add "completion" parameter.
7052         * p-exp.y: Update rules.
7053         (yylex): Update.
7054         * language.h (struct language_defn) <la_post_parser>: Add
7055         "completing" parameter.
7056         * go-exp.y: Update rules.
7057         (lex_one_token): Update.
7058         * expression.h (parse_completion): Don't declare.
7059         * d-exp.y: Update rules.
7060         (lex_one_token): Update rules.
7061         * c-exp.y: Update rules.
7062         (lex_one_token): Update.
7063         * ada-lang.c (resolve): Add "parse_completion" parameter.
7064         (resolve_subexp): Likewise.
7065         (ada_resolve_function): Likewise.
7066
7067 2019-04-04  Tom Tromey  <tom@tromey.com>
7068
7069         * parser-defs.h (struct parser_state) <start_arglist,
7070         end_arglist>: New methods.
7071         <arglist_len, m_funcall_chain>: New members.
7072         (arglist_len, start_arglist, end_arglist): Don't declare.
7073         * parse.c (arglist_len, funcall_chain): Remove global.
7074         (start_arglist, end_arglist): Remove functions.
7075         (parse_exp_in_context): Update.
7076         * p-exp.y: Update rules.
7077         * m2-exp.y: Update rules.
7078         * go-exp.y: Update rules.
7079         * f-exp.y: Update rules.
7080         * d-exp.y: Update rules.
7081         * c-exp.y: Update rules.
7082
7083 2019-04-04  Tom Tromey  <tom@tromey.com>
7084
7085         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7086         lex_operator, push_back>: New methods.
7087         Update all rules.
7088         (rust_parser::lex_hex, lex_escape): Rename and update.
7089         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7090         (rust_parser::lex_operator): Rename and update.
7091         (rust_parser::lex_number, rustyylex, rustyyerror)
7092         (rust_lex_test_init, rust_lex_test_sequence)
7093         (rust_lex_test_push_back, rust_lex_tests): Update.
7094         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7095         parameter.
7096         <lexptr, prev_lexptr>: New members.
7097         (lexptr, prev_lexptr): Don't declare.
7098         * parse.c (lexptr, prev_lexptr): Remove globals.
7099         (parse_exp_in_context): Update.
7100         * p-exp.y (yylex, yyerror): Update.
7101         * m2-exp.y (parse_number, yylex, yyerror): Update.
7102         * go-exp.y (lex_one_token, yyerror): Update.
7103         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7104         * d-exp.y (lex_one_token, yyerror): Update.
7105         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7106         (lex_one_token, yyerror): Update.
7107         * ada-lex.l (YY_INPUT): Update.
7108         (rewind_to_char): Update.
7109         * ada-exp.y (yyerror): Update.
7110
7111 2019-04-04  Tom Tromey  <tom@tromey.com>
7112
7113         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7114         * parser-defs.h (struct parser_state) <parser_state>: Add new
7115         parameter.
7116         <comma_terminates>: New member.
7117         (comma_terminates): Don't declare global.
7118         * parse.c (comma_terminates): Remove global.
7119         (parse_exp_in_context): Update.
7120         * p-exp.y (yylex): Update.
7121         * m2-exp.y (yylex): Update.
7122         * go-exp.y (lex_one_token): Update.
7123         * f-exp.y (yylex): Update.
7124         * d-exp.y (lex_one_token): Update.
7125         * c-exp.y (lex_one_token): Update.
7126         * ada-lex.l: Update.
7127
7128 2019-04-04  Tom Tromey  <tom@tromey.com>
7129
7130         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7131         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7132         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7133         * parser-defs.h (paren_depth): Don't declare.
7134         * parse.c (paren_depth): Remove global.
7135         (parse_exp_in_context): Update.
7136         * p-exp.y (paren_depth): New global.
7137         (pascal_parse): Initialize it.
7138         * m2-exp.y (paren_depth): New global.
7139         (m2_parse): Initialize it.
7140         * go-exp.y (paren_depth): New global.
7141         (go_parse): Initialize it.
7142         * f-exp.y (paren_depth): New global.
7143         (f_parse): Initialize it.
7144         * d-exp.y (paren_depth): New global.
7145         (d_parse): Initialize it.
7146         * c-exp.y (paren_depth): New global.
7147         (c_parse): Initialize it.
7148         * ada-lex.l (paren_depth): New global.
7149         (lexer_init): Initialize it.
7150
7151 2019-04-04  Tom Tromey  <tom@tromey.com>
7152
7153         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7154         (rust_parser::convert_ast_to_type)
7155         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7156         * parser-defs.h (struct parser_state) <parser_state>: Add
7157         parameters.  Initialize new members.
7158         <expression_context_block, expression_context_pc>: New members.
7159         * parse.c (expression_context_block, expression_context_pc):
7160         Remove globals.
7161         (parse_exp_in_context): Update.
7162         * p-exp.y: Update all rules.
7163         (yylex): Update.
7164         * m2-exp.y: Update all rules.
7165         (yylex): Update.
7166         * go-exp.y (yylex): Update.
7167         * f-exp.y (yylex): Update.
7168         * d-exp.y: Update all rules.
7169         (yylex): Update.
7170         * c-exp.y: Update all rules.
7171         (lex_one_token, classify_name, yylex, c_parse): Update.
7172         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7173
7174 2019-04-04  Tom Tromey  <tom@tromey.com>
7175
7176         * gdbarch.h, gdbarch.c: Rebuild.
7177         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7178         * stap-probe.h:
7179         (struct stap_parse_info): Replace "parser_state" with
7180         "expr_builder".
7181         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7182         (parser_state): New class.
7183         * parse.c (expr_builder): Rename.
7184         (expr_builder::release): Rename.
7185         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7186         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7187         (write_exp_elt_longcst, write_exp_elt_floatcst)
7188         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7189         (write_exp_string_vector, write_exp_bitstring)
7190         (write_exp_msymbol, mark_struct_expression)
7191         (write_dollar_variable)
7192         (insert_type_address_space, increase_expout_size): Replace
7193         "parser_state" with "expr_builder".
7194         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7195         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7196         "parser_state" with "expr_builder".
7197
7198 2019-04-04  Tom Tromey  <tom@tromey.com>
7199
7200         * rust-exp.y: Replace "parse_language" with method call.
7201         * p-exp.y:
7202         (yylex): Replace "parse_language" with method call.
7203         * m2-exp.y:
7204         (yylex): Replace "parse_language" with method call.
7205         * go-exp.y (classify_name): Replace "parse_language" with method
7206         call.
7207         * f-exp.y (yylex): Replace "parse_language" with method call.
7208         * d-exp.y (lex_one_token): Replace "parse_language" with method
7209         call.
7210         * c-exp.y:
7211         (lex_one_token, classify_name, yylex): Replace "parse_language"
7212         with method call.
7213         * ada-exp.y (find_primitive_type, type_char)
7214         (type_system_address): Replace "parse_language" with method call.
7215
7216 2019-04-04  Tom Tromey  <tom@tromey.com>
7217
7218         * rust-exp.y: Replace "parse_gdbarch" with method call.
7219         * parse.c (write_dollar_variable, insert_type_address_space):
7220         Replace "parse_gdbarch" with method call.
7221         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7222         call.
7223         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7224         call.
7225         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7226         "parse_gdbarch" with method call.
7227         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7228         with method call.
7229         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7230         "parse_gdbarch" with method call.
7231         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7232         "parse_gdbarch" with method call.
7233         * c-exp.y (parse_type, parse_number, classify_name): Replace
7234         "parse_gdbarch" with method call.
7235         * ada-lex.l: Replace "parse_gdbarch" with method call.
7236         * ada-exp.y (parse_type, find_primitive_type, type_char)
7237         (type_system_address): Replace "parse_gdbarch" with method call.
7238
7239 2019-04-04  Tom Tromey  <tom@tromey.com>
7240
7241         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7242         * stap-probe.c (stap_parse_argument): Update.
7243         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7244         initial_size parameter.
7245         * rust-exp.y (rust_lex_tests): Update.
7246         * parse.c (parser_state): Update.
7247         (parse_exp_in_context): Update.
7248         * parser-defs.h (struct parser_state) <parser_state>: Remove
7249         "initial_size" parameter.
7250
7251 2019-04-04  Tom Tromey  <tom@tromey.com>
7252
7253         * parser-defs.h (increase_expout_size): Don't declare.
7254         * parse.c (increase_expout_size): Now static.
7255
7256 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7257
7258         * gnu-nat.c (gnu_nat_target::wait): Fix
7259         target_waitstatus_to_string call.
7260
7261 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7262
7263         * eval.c (evaluate_subexp_standard): Handle internal functions
7264         during Fortran function call handling.
7265
7266 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7267
7268         * NEWS: Mention new internal functions.
7269         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7270         (read_base_type): Use dwarf2_init_complex_target_type.
7271         * value.c (creal_internal_fn): New function.
7272         (cimag_internal_fn): New function.
7273         (_initialize_values): Register new internal functions.
7274
7275 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7276
7277         * infrun.c (stop_all_threads): If debug_infrun, always
7278         trace the wait status after wait_one, using
7279         target_waitstatus_to_string and target_pid_to_str.
7280         (handle_inferior_event): Replace various trace of
7281         wait status kind by a single trace.
7282         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7283         wait status kind image by target_waitstatus_to_string.
7284         * target/waitstatus.c (target_waitstatus_to_string): Fix
7285         obsolete comment.
7286
7287 2019-04-01  Tom Tromey  <tromey@adacore.com>
7288
7289         PR symtab/23331:
7290         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7291
7292 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7293             Pedro Alves  <palves@redhat.com>
7294
7295         * top.c (quit_force): Call 'finalize_values'.
7296         * value.c (finalize_values): New function.
7297         * value.h (finalize_values): Declare.
7298
7299 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7300
7301         * NEWS: Announce $_gdb_major and $_gdb_minor.
7302
7303         * top.c (init_gdb_version_vars): New function.
7304         (gdb_init): Call init_gdb_version_vars.
7305
7306 2019-03-29  Tom Tromey  <tromey@adacore.com>
7307
7308         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7309         help text.  Remove dead code.
7310
7311 2019-03-29  Keith Seitz  <keiths@redhat.com>
7312
7313         From Siddhesh Poyarekar:
7314         * f-lang.h (f77_get_upperbound): Return LONGEST.
7315         (f77_get_lowerbound): Likewise.
7316         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7317         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7318         print them.
7319         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7320         plongest to format print it.
7321         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7322         (f77_get_upperbound): Likewise.
7323         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7324         LOWER_BOUND to LONGEST.
7325         (f77_create_arrayprint_offset_tbl): Likewise.
7326
7327 2019-03-29  Keith Seitz  <keiths@redhat.com>
7328
7329         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7330         %s/pulongest for TYPE_LENGTH instead of %d in format
7331         strings.
7332         * ada-typerint.c (ada_print_type): Likewise.
7333         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7334         * compile/compile-c-support.c (generate_register_struct): Likewise.
7335         * gdbtypes.c (recursive_dump_type): Likewise.
7336         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7337         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7338         instead of %d in format strings.
7339         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7340         to std::min to ULONGEST.
7341         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7342         instead of %d in format strings.
7343         * tracepoint.c (info_scope_command): Likewise.
7344         * typeprint.c (print_offset_data::update)
7345         (print_offset_data::finish): Likewise.
7346         * xtensa-tdep.c (xtensa_store_return_value)
7347         (xtensa_push_dummy_call): Likewise.
7348
7349 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7350
7351         * windows-nat.c (display_selector): Fixed format specifications
7352         for 64-bit Cygwin.
7353
7354 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7355
7356         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7357
7358 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7359
7360         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7361         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7362         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7363         (nios2_linux_init_abi): Install it.
7364
7365 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7366
7367         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7368
7369 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7370
7371         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7372
7373 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7374             Tom Tromey  <tromey@adacore.com>
7375
7376         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7377
7378 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7379
7380         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7381         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7382         method to compute the bounds of range types. Also print "[evaluated]"
7383         if the bounds' values come from a dynamic evaluation.
7384
7385 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7386
7387         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7388         whitespace when pretty printing is on.
7389
7390 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7391
7392         * ppc-linux-nat.c: Add include.
7393
7394 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7395
7396         * NEWS: Mention AArch64 Pointer Authentication.
7397
7398 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7399
7400         * arm-linux-nat.c: Add include.
7401
7402 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7403
7404         * source-cache.c (source_cache::get_source_lines): Re-read
7405         fullname after calling open_source_file.
7406
7407 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7408
7409         * NEWS: Mention TLS support for FreeBSD.
7410
7411 2019-03-25  Tom Tromey  <tromey@adacore.com>
7412
7413         * minsyms.c (BUNCH_SIZE): Update comment.
7414         (~minimal_symbol_reader): Remove old comment.
7415         (compact_minimal_symbols): Update comment.
7416         (minimal_symbol_reader::install): Remove old comment.  Update
7417         other comments.
7418
7419 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7420
7421         * s390-linux-nat.c: Add include.
7422
7423 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7424
7425         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7426         Call linux_get_hwcap.
7427         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7428         Likewise.
7429         (aarch64_linux_get_hwcap): Remove function.
7430         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7431         declaration.
7432         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7433         linux_get_hwcap.
7434         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7435         * linux-tdep.c (linux_get_hwcap): Add function.
7436         (linux_get_hwcap2): Likewise.
7437         * linux-tdep.h (linux_get_hwcap): Add declaration.
7438         (linux_get_hwcap2): Likewise.
7439         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7440         (ppc_linux_get_hwcap2): Likewise.
7441         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7442         linux_get_hwcap.
7443         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7444         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7445         (ppc_linux_nat_target::read_description): Likewise.
7446         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7447         * s390-linux-nat.c: Likewise.
7448         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7449
7450 2019-03-24  Tom Tromey  <tom@tromey.com>
7451
7452         * ada-lang.c (standard_lookup): Simplify initialization.
7453         (ada_lookup_symbol_nonlocal): Simplify return.
7454         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7455         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7456         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7457         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7458         initialization.
7459         * solib.c (solib_global_lookup): Simplify.
7460         * symtab.c (null_block_symbol): Remove.
7461         (symbol_cache_lookup): Simplify returns.
7462         (lookup_language_this): Simplify returns.
7463         (lookup_symbol_aux): Simplify return.
7464         (lookup_local_symbol): Simplify returns.
7465         (lookup_global_symbol_from_objfile): Simplify return.
7466         (lookup_symbol_in_objfile_symtabs)
7467         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7468         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7469         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7470         * cp-namespace.c (cp_lookup_bare_symbol)
7471         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7472         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7473         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7474         (cp_lookup_symbol_via_imports): Simplify initialization.
7475         (find_symbol_in_baseclass): Likewise.
7476         * symtab.h (null_block_symbol): Remove.
7477         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7478         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7479         (d_lookup_symbol_module): Likewise.
7480         (find_symbol_in_baseclass): Simplify initialization.
7481
7482 2019-03-24  Tom Tromey  <tom@tromey.com>
7483
7484         * expression.h: Don't include symtab.h.
7485         (struct block): Forward declare.
7486
7487 2019-03-24  Tom Tromey  <tom@tromey.com>
7488
7489         * c-exp.y (typebase): Remove casts.
7490         * gdbtypes.c (lookup_unsigned_typename, )
7491         (lookup_signed_typename): Remove cast.
7492         * eval.c (parse_to_comma_and_eval): Remove cast.
7493         * parse.c (write_dollar_variable): Remove cast.
7494         * block.h (struct block) <superblock>: Now const.
7495         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7496         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7497         (map_block): Make "block" const.
7498         * symfile.h (struct quick_symbol_functions)
7499         <map_matching_symbols>: Constify block argument to "callback".
7500         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7501         const.
7502         (find_pc_sect_compunit_symtab): Make "b" const.
7503         (find_symbol_at_address): Likewise.
7504         (search_symbols): Likewise.
7505         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7506         (dw2_debug_names_lookup_symbol): Likewise.
7507         (dw2_map_matching_symbols): Update.
7508         * p-valprint.c (pascal_val_print): Remove "block".
7509         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7510         (aux_add_nonlocal_symbols): Make "block" const.
7511         (resolve_subexp): Remove cast.
7512         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7513         const.
7514         (iterate_over_file_blocks): Likewise.
7515         * f-exp.y (%union) <bval>: Remove.
7516         * coffread.c (patch_opaque_types): Make "b" const.
7517         * spu-tdep.c (spu_catch_start): Make "block" const.
7518         * c-valprint.c (print_unpacked_pointer): Remove "block".
7519         * symmisc.c (dump_symtab_1): Make "b" const.
7520         (block_depth): Make "block" const.
7521         * d-exp.y (%union) <bval>: Remove.
7522         * cp-support.h (cp_lookup_rtti_type): Update.
7523         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7524         * psymtab.c (psym_lookup_symbol): Make "block" const.
7525         (maintenance_check_psymtabs): Make "b" const.
7526         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7527         (enumerate_locals, enumerate_args): Update.
7528         * python/py-symtab.c (stpy_global_block): Make "block" const.
7529         (stpy_static_block): Likewise.
7530         * inline-frame.c (block_starting_point_at): Make "new_block"
7531         const.
7532         * block.c (find_block_in_blockvector): Make return type const.
7533         (blockvector_for_pc_sect): Make "b" const.
7534         (find_block_in_blockvector): Make "b" const.
7535
7536 2019-03-23  Tom Tromey  <tom@tromey.com>
7537
7538         * varobj.c (varobj_create): Update.
7539         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7540         * printcmd.c (display_command, do_one_display): Don't reset
7541         innermost_block.
7542         * parser-defs.h (enum innermost_block_tracker_type): Move to
7543         expression.h.
7544         (innermost_block): Update comment.
7545         * parse.c (parse_exp_1): Add tracker_types parameter.
7546         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7547         tracker_types parameter.  Reset innermost_block.
7548         (parse_exp_in_context): Remove.
7549         (parse_expression_for_completion): Update.
7550         * objfiles.c (~objfile): Don't reset expression_context_block or
7551         innermost_block.
7552         * expression.h (enum innermost_block_tracker_type): Move from
7553         parser-defs.h.
7554         (parse_exp_1): Add tracker_types parameter.
7555         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7556         reset innermost_block.
7557
7558 2019-03-23  Tom Tromey  <tom@tromey.com>
7559
7560         * objfiles.h: Include bcache.h.
7561
7562 2019-03-23  Tom Tromey  <tom@tromey.com>
7563
7564         * linespec.c (get_current_search_block): Use
7565         scoped_restore_current_language.
7566         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7567
7568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7569             Jiong Wang  <jiong.wang@arm.com>
7570
7571         * aarch64-linux-tdep.c
7572         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7573         section.
7574         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7575
7576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7577             Jiong Wang  <jiong.wang@arm.com>
7578
7579         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7580         instructions.
7581         (aarch64_analyze_prologue_test): Add PACIASP test.
7582         (aarch64_prologue_prev_register): Unmask PC value.
7583
7584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7585             Jiong Wang  <jiong.wang@arm.com>
7586
7587         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7588         (aarch64_dwarf2_prev_register): Unmask PC value.
7589         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7590         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7591         DW_CFA_AARCH64_negate_ra_state.
7592         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7593
7594 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7595             Jiong Wang  <jiong.wang@arm.com>
7596
7597         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7598         registers.
7599         (aarch64_pseudo_register_name): Likewise.
7600         (aarch64_pseudo_register_type): Likewise.
7601         (aarch64_pseudo_register_reggroup_p): Likewise.
7602         (aarch64_gdbarch_init): Add pauth registers.
7603         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7604         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7605         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7606         (struct gdbarch_tdep): Add regnum for ra_state.
7607
7608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7609             Jiong Wang  <jiong.wang@arm.com>
7610
7611         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7612
7613 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7614             Jiong Wang  <jiong.wang@arm.com>
7615
7616         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7617         function.
7618         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7619         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7620         (aarch64_gdbarch_init): Add puth registers.
7621         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7622         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7623         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7624
7625 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7626             Jiong Wang  <jiong.wang@arm.com>
7627
7628         * aarch64-linux-nat.c
7629         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7630         * aarch64-linux-tdep.c
7631         (aarch64_linux_core_read_description): Likewise.
7632         (aarch64_linux_get_hwcap): New function.
7633         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7634         (aarch64_linux_get_hwcap): New declaration.
7635
7636 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7637             Jiong Wang  <jiong.wang@arm.com>
7638
7639         * aarch64-linux-nat.c
7640         (aarch64_linux_nat_target::read_description): Add pauth param.
7641         * aarch64-linux-tdep.c
7642         (aarch64_linux_core_read_description): Likewise.
7643         * aarch64-tdep.c (struct target_desc): Add in pauth.
7644         (aarch64_read_description): Add pauth param.
7645         (aarch64_gdbarch_init): Likewise.
7646         * aarch64-tdep.h (aarch64_read_description): Likewise.
7647         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7648         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7649         * features/Makefile: Add new files.
7650         * features/aarch64-pauth.c: New file.
7651         * features/aarch64-pauth.xml: New file.
7652
7653 2019-03-20  Tom Tromey  <tromey@adacore.com>
7654
7655         * infrun.c (handle_inferior_event): Rename from
7656         handle_inferior_event_1.  Create a scoped_value_mark.
7657         (handle_inferior_event): Remove.
7658
7659 2019-03-19  Tom Tromey  <tromey@adacore.com>
7660
7661         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7662         * infrun.h (print_stop_event): Add "displays" parameter.
7663         * infrun.c (print_stop_event): Add "displays" parameter.
7664
7665 2019-03-19  Pedro Alves  <palves@redhat.com>
7666
7667         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7668         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7669         to -1.  Fix TABs vs spaces.
7670         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7671         * tui/tui-out.h (tui_ui_out) Add intro comments.
7672         <m_line, m_start_of_line>: In-class initialize, and add describing
7673         comment.
7674
7675 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7676
7677         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7678         variable names.
7679         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7680
7681 2019-03-18  Pedro Alves  <palves@redhat.com>
7682             Eli Zaretskii <eliz@gnu.org>
7683
7684         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7685         m_line and m_start_of_line.
7686
7687 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7688
7689         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7690         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7691         it returns a newline.  This fixes a regression in TU mode, whereby
7692         the next line is output on the same screen line as the user input.
7693
7694 2019-03-18  Tom Tromey  <tromey@adacore.com>
7695
7696         * minsyms.c (minimal_symbol_reader::install): Remove call to
7697         obstack_blank.
7698
7699 2019-03-18  Pedro Alves  <palves@redhat.com>
7700
7701         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7702         New globals.
7703         (apply_style): New, factored out from ...
7704         (apply_ansi_escape): ... this.  Handle reverse video mode.
7705         (tui_set_reverse_mode): New function.
7706         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7707         * tui/tui-winsource.c (tui_show_source_line): Use
7708         tui_set_reverse_mode instead of setting A_STANDOUT.
7709         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7710         New setter methods.
7711
7712 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7713
7714         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7715         Handle tabs.
7716
7717 2019-03-18  Tom Tromey  <tromey@adacore.com>
7718
7719         * ada-lang.c (empty_array): Add "high" parameter.
7720         (ada_evaluate_subexp): Update.
7721
7722 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7723
7724         * unittests/string_view-selftests.c: Define
7725         _initialize_string_view_selftests unconditionally.
7726
7727 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7728
7729         PR gdb/24350
7730         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7731
7732 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7733
7734         PR gdb/24351
7735         * windows-nat.c (display_selector): Fix format specifiers.
7736
7737 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7738
7739         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7740         tui_refill_source_window instead of tui_refresh_win, to update the
7741         current execution line.  This fixes redisplay of the current line
7742         when stepping through the code with "next" or "step".
7743
7744 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7745
7746         * source-cache.c (source_cache::get_source_lines): Call
7747         find_source_lines to initialize s->nlines.  This fixes vertical
7748         scrolling of TUI source window when the DOWN arrow is pressed.
7749
7750 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7751
7752         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7753         linux-thread-db.c (_initialize_thread_db): Likewise.
7754
7755 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7756
7757         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7758         wclrtoeol in tui_show_source_line".  This reverts changes made in
7759         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7760
7761 2019-03-15  Tom Tromey  <tom@tromey.com>
7762
7763         * symtab.h (struct minimal_symbol): Derive from
7764         general_symbol_info.
7765         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7766         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7767         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7768         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7769         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7770         (MSYMBOL_SEARCH_NAME): Update.
7771         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7772         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7773         * minsyms.c (minimal_symbol_reader::record_full): Update.
7774
7775 2019-03-15  Tom Tromey  <tom@tromey.com>
7776
7777         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7778
7779 2019-03-15  Tom Tromey  <tom@tromey.com>
7780
7781         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7782         unique_xmalloc_ptr.
7783         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7784         Update.
7785         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7786         (build_minimal_symbol_hash_tables)
7787         (minimal_symbol_reader::install): Update.
7788
7789 2019-03-15  Tom Tromey  <tom@tromey.com>
7790
7791         * symtab.c (create_demangled_names_hash): Update.
7792         (symbol_set_names): Update.
7793         * objfiles.h (struct objfile_per_bfd_storage)
7794         <demangled_names_hash>: Now an htab_up.
7795         * objfiles.c (objfile_per_bfd_storage): Simplify.
7796
7797 2019-03-15  Tom Tromey  <tom@tromey.com>
7798
7799         * objfiles.h (struct objfile_per_bfd_storage): Declare
7800         destructor.
7801         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7802         New.
7803         (get_objfile_bfd_data): Use new.  Don't initialize
7804         language_of_main.
7805         (free_objfile_per_bfd_storage): Remove.
7806         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7807
7808 2019-03-15  Tom Tromey  <tom@tromey.com>
7809
7810         * symfile.c (reread_symbols): Update.
7811         * objfiles.c (objfile::objfile): Update.
7812         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7813         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7814         comment.
7815         (minimal_symbol_reader::install): Update.
7816         (terminate_minimal_symbol_table): Remove.
7817         * jit.c (jit_object_close_impl): Update.
7818
7819 2019-03-15  Tom Tromey  <tom@tromey.com>
7820
7821         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7822         initializations.
7823
7824 2019-03-15  Tom Tromey  <tom@tromey.com>
7825
7826         * objfiles.h (struct objfile_per_bfd_storage)
7827         <demangled_hash_languages>: Now a bitset.
7828         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7829         (lookup_minimal_symbol): Update.
7830
7831 2019-03-15  Tom Tromey  <tom@tromey.com>
7832
7833         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7834         Don't return the symbol.
7835         * coffread.c (record_minimal_symbol): Use record_full.
7836
7837 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7838
7839         The MS-Windows port of ncurses fails to switch to a color pair if
7840         one or both of the colors are the implicit default colors.  This
7841         change records the default colors when TUI is initialized, and
7842         then specifies them explicitly when a color pair uses the default
7843         colors.  This allows color styling in TUI mode on MS-Windows.
7844
7845         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7846         ncurses_norm_attr.
7847         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7848         colors in ncurses_norm_attr.
7849         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7850         "none", replace it with the default color recorded in
7851         ncurses_norm_attr.
7852
7853 2019-03-14  Tom Tromey  <tromey@adacore.com>
7854
7855         * source-cache.h (class source_cache) <get_source_lines>: Return
7856         std::string.
7857         * source-cache.c (source_cache::extract_lines): Handle case where
7858         first_pos==npos.  Return std::string.
7859         (source_cache::get_source_lines): Update.
7860
7861 2019-03-14  Tom Tromey  <tromey@adacore.com>
7862
7863         * NEWS: Add item for "style sources" commands.
7864         * source-cache.c (source_cache::get_source_lines): Check
7865         source_styling.
7866         * cli/cli-style.c (source_styling): New global.
7867         (_initialize_cli_style): Add "style sources" commands.
7868         (show_style_sources): New function.
7869         * cli/cli-style.h (source_styling): Declare.
7870
7871 2019-03-14  Pedro Alves  <palves@redhat.com>
7872             Tom Tromey  <tromey@adacore.com>
7873
7874         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7875         * tui/tui-winsource.c (tui_refill_source_window): New function,
7876         from...
7877         (tui_horizontal_source_scroll): ... here.  Move some logic.
7878         * cli/cli-style.c (set_style_enabled): Notify new observable.
7879         * tui/tui-hooks.c (tui_redisplay_source): New function.
7880         (tui_attach_detach_observers): Attach or detach
7881         tui_redisplay_source.
7882         * observable.h (source_styling_changed): New observable.
7883         * observable.c: Define source_styling_changed observable.
7884
7885 2019-03-13  Tom Tromey  <tromey@adacore.com>
7886
7887         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7888         (i386_gnu_nat_target::store_registers): Update.
7889         * target-debug.h (target_debug_print_std_string): New macro.
7890         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7891         * windows-tdep.c (display_one_tib): Update.
7892         * tui/tui-stack.c (tui_make_status_line): Update.
7893         * top.c (print_inferior_quit_action): Update.
7894         * thread.c (thr_try_catch_cmd): Update.
7895         (add_thread_with_info): Update.
7896         (thread_target_id_str): Update.
7897         (thr_try_catch_cmd): Update.
7898         (thread_command): Update.
7899         (thread_find_command): Update.
7900         * record-btrace.c (record_btrace_target::info_record)
7901         (record_btrace_resume_thread, record_btrace_target::resume)
7902         (record_btrace_cancel_resume, record_btrace_step_thread)
7903         (record_btrace_target::wait, record_btrace_target::wait)
7904         (record_btrace_target::wait, record_btrace_target::stop): Update.
7905         * progspace.c (print_program_space): Update.
7906         * process-stratum-target.c
7907         (process_stratum_target::thread_address_space): Update.
7908         * linux-fork.c (linux_fork_mourn_inferior)
7909         (detach_checkpoint_command, info_checkpoints_command)
7910         (linux_fork_context): Update.
7911         (linux_fork_detach): Update.
7912         (class scoped_switch_fork_info): Update.
7913         (delete_checkpoint_command): Update.
7914         * infrun.c (follow_fork_inferior): Update.
7915         (follow_fork_inferior): Update.
7916         (proceed_after_vfork_done): Update.
7917         (handle_vfork_child_exec_or_exit): Update.
7918         (follow_exec): Update.
7919         (displaced_step_prepare_throw): Update.
7920         (displaced_step_restore): Update.
7921         (start_step_over): Update.
7922         (resume_1): Update.
7923         (clear_proceed_status_thread): Update.
7924         (proceed): Update.
7925         (print_target_wait_results): Update.
7926         (do_target_wait): Update.
7927         (context_switch): Update.
7928         (stop_all_threads): Update.
7929         (restart_threads): Update.
7930         (finish_step_over): Update.
7931         (handle_signal_stop): Update.
7932         (switch_back_to_stepped_thread): Update.
7933         (keep_going_pass_signal): Update.
7934         (print_exited_reason): Update.
7935         (normal_stop): Update.
7936         * inferior.c (inferior_pid_to_str): Change return type.
7937         (print_selected_inferior): Update.
7938         (add_inferior): Update.
7939         (detach_inferior): Update.
7940         * dummy-frame.c (fprint_dummy_frames): Update.
7941         * dcache.c (dcache_info_1): Update.
7942         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7943         (btrace_fetch, btrace_clear): Update.
7944         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7945         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7946         type.
7947         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7948         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7949         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7950         * gdbarch.c, gdbarch.h: Rebuild.
7951         * gdbarch.sh (core_pid_to_str): Change return type.
7952         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7953         return type.
7954         (windows_nat_target::pid_to_str): Change return type.
7955         (windows_delete_thread): Update.
7956         (windows_nat_target::attach): Update.
7957         (windows_nat_target::files_info): Update.
7958         * target-delegates.c: Rebuild.
7959         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7960         return type.
7961         (sol_thread_target::pid_to_str): Change return type.
7962         * remote.c (class remote_target) <pid_to_str>: Change return
7963         type.
7964         (remote_target::pid_to_str): Change return type.
7965         (extended_remote_target::attach, remote_target::remote_stop_ns)
7966         (remote_target::remote_notif_remove_queued_reply)
7967         (remote_target::push_stop_reply, remote_target::disable_btrace):
7968         Update.
7969         (extended_remote_target::attach): Update.
7970         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7971         type.
7972         (gdbsim_target::pid_to_str): Change return type.
7973         * ravenscar-thread.c (struct ravenscar_thread_target)
7974         <pid_to_str>: Change return type.
7975         (ravenscar_thread_target::pid_to_str): Change return type.
7976         * procfs.c (class procfs_target) <pid_to_str>: Change return
7977         type.
7978         (procfs_target::pid_to_str): Change return type.
7979         (procfs_target::attach): Update.
7980         (procfs_target::detach): Update.
7981         (procfs_target::fetch_registers): Update.
7982         (procfs_target::store_registers): Update.
7983         (procfs_target::wait): Update.
7984         (procfs_target::files_info): Update.
7985         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7986         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7987         return type.
7988         (nto_procfs_target::pid_to_str): Change return type.
7989         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7990         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7991         return type.
7992         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7993         (exit_lwp): Update.
7994         (attach_proc_task_lwp_callback, get_detach_signal)
7995         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7996         (linux_nat_target::resume, wait_lwp, stop_callback)
7997         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7998         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7999         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8000         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8001         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8002         type.
8003         (inf_ptrace_target::attach): Update.
8004         (inf_ptrace_target::files_info): Update.
8005         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8006         type.
8007         (go32_nat_target::pid_to_str): Change return type.
8008         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8009         (gnu_nat_target::wait): Update.
8010         (gnu_nat_target::wait): Update.
8011         (gnu_nat_target::resume): Update.
8012         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8013         (fbsd_nat_target::wait): Update.
8014         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8015         type.
8016         (darwin_nat_target::attach): Update.
8017         * corelow.c (class core_target) <pid_to_str>: Change return type.
8018         (core_target::pid_to_str): Change return type.
8019         * target.c (normal_pid_to_str): Change return type.
8020         (default_pid_to_str): Likewise.
8021         (target_pid_to_str): Change return type.
8022         (target_translate_tls_address): Update.
8023         (target_announce_detach): Update.
8024         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8025         return type.
8026         (bsd_uthread_target::pid_to_str): Change return type.
8027         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8028         type.
8029         (bsd_kvm_target::pid_to_str): Change return type.
8030         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8031         return type.
8032         (aix_thread_target::pid_to_str): Change return type.
8033         * target.h (struct target_ops) <pid_to_str>: Change return type.
8034         (target_pid_to_str, normal_pid_to_str): Likewise.
8035         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8036         type.
8037         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8038         type.
8039         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8040         return type.
8041         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8042         type.
8043         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8044         type.
8045         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8046         return type.
8047
8048 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8049
8050         * NEWS: Mention that the new default MI version is 3.  Mention
8051         changes to the output of commands and events that deal with
8052         multi-location breakpoints.
8053         * breakpoint.c: Include "mi/mi-out.h".
8054         (print_one_breakpoint): Change output syntax if using MI version
8055         >= 3.
8056         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8057         New.
8058         (mi_multi_location_breakpoint_output_fixed): New.
8059         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8060         (mi_cmd_fix_multi_location_breakpoint_output): New.
8061         (mi_multi_location_breakpoint_output_fixed): New.
8062         * mi/mi-cmds.c (mi_cmds): Register command
8063         -fix-multi-location-breakpoint-output.
8064         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8065         interpreter "mi".
8066
8067 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8068
8069         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8070         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8071         instantiate mi_ui_out based on interpreter name.
8072         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8073         * mi/mi-main.c (mi_load_progress): Likewise.
8074
8075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8076
8077         * NEWS: Combine separate "New targets" sections for 8.3.
8078
8079 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8080
8081         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8082         (ppcfbsd_init_abi): Install gdbarch
8083         "fetch_tls_load_module_address" and "get_thread_local_address"
8084         methods.
8085
8086 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8087
8088         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8089         (riscv_fbsd_init_abi): Install gdbarch
8090         "fetch_tls_load_module_address" and "get_thread_local_address"
8091         methods.
8092
8093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8096         (i386fbsd_init_abi): Install gdbarch
8097         "fetch_tls_load_module_address" and "get_thread_local_address"
8098         methods.
8099
8100 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8101
8102         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8103         (amd64fbsd_init_abi): Install gdbarch
8104         "fetch_tls_load_module_address" and "get_thread_local_address"
8105         methods.
8106
8107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8108
8109         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8110         (struct fbsd_pspace_data): New type.
8111         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8112         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8113         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8114         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8115         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8116
8117 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8118
8119         * gdbtypes.c (lookup_struct_elt): New function.
8120         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8121         * gdbtypes.h (struct struct_elt): New type.
8122         (lookup_struct_elt): New prototype.
8123
8124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8125
8126         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8127         remove disabled code block.
8128
8129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8130
8131         * gdbarch.sh (get_thread_local_address): New method.
8132         * gdbarch.h, gdbarch.c: Regenerate.
8133         * target.c (target_translate_tls_address): Use
8134         gdbarch_get_thread_local_address if present instead of
8135         target::get_thread_local_address.
8136
8137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8138
8139         * target.h (target::get_thread_local_address): Update comment.
8140
8141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8142
8143         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8144         objfile->separate_debug_objfile_backlink if not NULL.
8145
8146 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8147
8148         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8149         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8150         (amd64bsd_store_inferior_registers): Likewise.
8151         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8152         Enable segment base registers.
8153         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8154         PT_GETFSBASE and PT_GETGSBASE.
8155         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8156         PT_SETGSBASE.
8157         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8158         segment base registers.
8159         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8160
8161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8162
8163         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8164         Update calls to i386_target_description to add 'segments'
8165         parameter.
8166         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8167         add segment base registers.
8168         * arch/i386.c (i386_create_target_description): Add 'segments'
8169         parameter to enable segment base registers.
8170         * arch/i386.h (i386_create_target_description): Likewise.
8171         * features/i386/32bit-segments.xml: New file.
8172         * features/i386/32bit-segments.c: Generate.
8173         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8174         call to i386_target_description to add 'segments' parameter.
8175         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8176         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8177         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8178         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8179         if feature is present.
8180         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8181         Add 'segments' parameter to call to i386_target_description.
8182         (i386_target_description): Add 'segments' parameter to enable
8183         segment base registers.
8184         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8185         to call to i386_target_description.
8186         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8187         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8188         Define I386_NUM_REGS.
8189         (i386_target_description): Add 'segments' parameter to enable
8190         segment base registers.
8191
8192 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8193
8194         PR/24325
8195         * source-cache.c: #undef open and close, to avoid unresolved
8196         externals during linking.
8197
8198 2019-03-12  Tom Tromey  <tromey@adacore.com>
8199
8200         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8201         const.  Add initializers.
8202         (_initialize_remote): Don't initialize ptid globals.
8203
8204 2019-03-12  Pedro Alves  <palves@redhat.com>
8205
8206         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8207
8208 2019-03-12  Pedro Alves  <palves@redhat.com>
8209
8210         * cp-name-parser.y (main): Remove unused 'len' variable.
8211
8212 2019-03-12  Tom Tromey  <tromey@adacore.com>
8213
8214         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8215         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8216
8217 2019-03-12  Tom Tromey  <tromey@adacore.com>
8218
8219         * linux-nat.c (iterate_over_lwps): Update.
8220         (stop_callback): Remove parameter.
8221         (stop_wait_callback, detach_callback, resume_set_callback)
8222         (select_singlestep_lwp_callback, set_ignore_sigint)
8223         (status_callback, resumed_callback, resume_clear_callback)
8224         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8225         data parameter.
8226         (linux_nat_target::detach, linux_nat_target::resume)
8227         (linux_stop_and_wait_all_lwps, select_event_lwp)
8228         (linux_nat_filter_event, linux_nat_wait_1)
8229         (linux_nat_target::kill, linux_nat_target::stop)
8230         (linux_nat_target::stop): Update.
8231         (linux_nat_resume_callback): Change type.
8232         (resume_stopped_resumed_lwps, count_events_callback)
8233         (select_event_lwp_callback): Likewise.
8234         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8235         * arm-linux-nat.c (struct update_registers_data): Remove.
8236         (update_registers_callback): Change type.
8237         (arm_linux_insert_hw_breakpoint1): Update.
8238         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8239         parameter.
8240         (x86_linux_dr_set_addr): Update.
8241         (x86_linux_dr_set_control): Update.
8242         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8243         (iterate_over_lwps): Use gdb::function_view.
8244         * nat/aarch64-linux-hw-point.c (struct
8245         aarch64_dr_update_callback_param): Remove.
8246         (debug_reg_change_callback): Change type.
8247         (aarch64_notify_debug_reg_change): Update.
8248         * s390-linux-nat.c (s390_refresh_per_info): Update.
8249
8250 2019-03-11  Tom Tromey  <tromey@adacore.com>
8251
8252         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8253         redundant assignment to "this_cu".
8254
8255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8256
8257         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8258
8259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8260
8261         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8262         from...
8263         (rank_one_type): ... this.
8264
8265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8266
8267         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8268         from...
8269         (rank_one_type): ... this.
8270
8271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8272
8273         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8274         from...
8275         (rank_one_type): ... this.
8276
8277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8278
8279         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8280         from...
8281         (rank_one_type): ... this.
8282
8283 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8284
8285         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8286         from...
8287         (rank_one_type): ... this.
8288
8289 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8290
8291         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8292         from...
8293         (rank_one_type): ... this.
8294
8295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8296
8297         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8298         from...
8299         (rank_one_type): ... this.
8300
8301 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8302
8303         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8304         from...
8305         (rank_one_type): ... this.
8306
8307 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8308
8309         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8310         from...
8311         (rank_one_type): ... this.
8312
8313 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8314
8315         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8316         from...
8317         (rank_one_type): ... this.
8318
8319 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8320
8321         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8322         from...
8323         (rank_one_type): ... this.
8324
8325 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8326
8327         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8328         from...
8329         (rank_one_type): ... this.
8330
8331 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8332
8333         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8334         inferior-events' shows the example events.
8335
8336 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8337
8338         Support styling on native MS-Windows console
8339
8340         PR/24315
8341         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8342         on MS-Windows if $TERM is not defined.
8343
8344         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8345
8346         * posix-hdep.c (gdb_console_fputs):
8347         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8348         functions.
8349         * ui-file.h (gdb_console_fputs): Add prototype.
8350
8351         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8352         back to fputs only if the former returns zero.
8353
8354 2019-03-07  Tom Tromey  <tom@tromey.com>
8355
8356         * symmisc.c (print_symbol_bcache_statistics): Update.
8357         (print_objfile_statistics): Update.
8358         * symfile.c (allocate_symtab): Update.
8359         * stabsread.c: Don't include bcache.h.
8360         * psymtab.h (struct psymbol_bcache): Don't declare.
8361         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8362         (psymbol_bcache_init, psymbol_bcache_free)
8363         (psymbol_bcache_get_bcache): Don't declare.
8364         * psymtab.c (struct psymbol_bcache): Remove.
8365         (psymtab_storage::psymtab_storage): Update.
8366         (psymtab_storage::~psymtab_storage): Update.
8367         (psymbol_bcache_init, psymbol_bcache_free)
8368         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8369         (add_psymbol_to_bcache): Update.
8370         (allocate_psymtab): Update.
8371         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8372         macro_cache>: No longer pointers.
8373         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8374         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8375         * macrotab.c (macro_bcache): Update.
8376         * macroexp.c: Don't include bcache.h.
8377         * gdbtypes.c (check_types_worklist): Update.
8378         (types_deeply_equal): Remove TRY/CATCH.  Update.
8379         * elfread.c (elf_symtab_read): Update.
8380         * dwarf2read.c: Don't include bcache.h.
8381         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8382         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8383         (print_bcache_statistics, bcache_memory_used): Don't declare.
8384         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8385         methods.  Rename all data members.
8386         * bcache.c (struct bcache): Move to bcache.h.
8387         (bcache::expand_hash_table): Rename from expand_hash_table.
8388         (bcache): Remove.
8389         (bcache::insert): Rename from bcache_full.
8390         (bcache::compare): Rename from bcache_compare.
8391         (bcache_xmalloc): Remove.
8392         (bcache::~bcache): Rename from bcache_xfree.
8393         (bcache::print_statistics): Rename from print_bcache_statistics.
8394         (bcache::memory_used): Rename from bcache_memory_used.
8395
8396 2019-03-07  Pedro Alves  <palves@redhat.com>
8397
8398         * infrun.c (normal_stop): Also check for
8399         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8400
8401 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * f-lang.c (value_from_host_double): Moved to...
8404         * value.c (value_from_host_double): ...here.
8405         * value.h (value_from_host_double): Declare.
8406         * guile/scm-math.c (vlscm_convert_typed_number): Use
8407         value_from_host_double.
8408         (vlscm_convert_number): Likewise.
8409         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8410         * python/py-value.c (convert_value_from_python): Likewise.
8411
8412 2019-03-06  Tom Tromey  <tom@tromey.com>
8413
8414         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8415
8416 2019-03-06  Tom Tromey  <tom@tromey.com>
8417
8418         * utils.h (free_current_contents): Don't declare.
8419         * utils.c (free_current_contents): Remove.
8420
8421 2019-03-06  Tom Tromey  <tom@tromey.com>
8422
8423         * top.c (quit_force): Update.
8424         * main.c (captured_command_loop): Update.
8425         * common/new-op.c (operator new): Update.
8426         * common/common-exceptions.c (struct catcher)
8427         <save_cleanup_chain>: Remove member.
8428         (exceptions_state_mc_init): Update.
8429         (exception_try_scope_entry): Return nullptr.
8430         (exception_try_scope_exit, exception_rethrow)
8431         (throw_exception_sjlj, throw_exception_cxx): Update.
8432         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8433         (all_cleanups, do_cleanups, discard_cleanups)
8434         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8435         (restore_cleanups, restore_final_cleanups): Don't declare.
8436         (do_final_cleanups): Remove parameter.
8437         * common/cleanups.c (cleanup_chain, make_cleanup)
8438         (make_cleanup_dtor, all_cleanups, do_cleanups)
8439         (discard_my_cleanups, discard_cleanups)
8440         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8441         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8442         (null_cleanup): Remove.
8443         (do_final_cleanups): Remove parameter.
8444
8445 2019-03-06  Tom Tromey  <tom@tromey.com>
8446
8447         * remote.c (remote_target::remote_parse_stop_reply): Use
8448         unique_xmalloc_ptr.
8449
8450 2019-03-06  Tom Tromey  <tom@tromey.com>
8451
8452         * stabsread.c (struct stabs_field_info): Rename from field_info.
8453         <list, fnlist>: Add initializers.
8454         <obstack>: New member.
8455         (read_member_functions, read_struct_fields, read_baseclasses):
8456         Allocate on obstack.  Don't use cleanups.
8457         (read_one_struct_field, read_member_functions, read_struct_fields)
8458         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8459         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8460         (read_struct_type): Update.
8461
8462 2019-03-06  Tom Tromey  <tom@tromey.com>
8463
8464         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8465         * common/filestuff.h (make_cleanup_close): Don't declare.
8466         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8467         Remove.
8468
8469 2019-03-06  Tom Tromey  <tom@tromey.com>
8470
8471         * solib-aix.c: Use make_scope_exit.
8472
8473 2019-03-06  Tom Tromey  <tom@tromey.com>
8474
8475         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8476         Use make_scope_exit.
8477
8478 2019-03-06  Tom Tromey  <tom@tromey.com>
8479
8480         * solib-svr4.c (disable_probes_interface): Remove parameter.
8481         (svr4_handle_solib_event): Use make_scope_exit.
8482
8483 2019-03-06  Tom Tromey  <tom@tromey.com>
8484
8485         * remote.c (struct stop_reply_deleter): Remove.
8486         (stop_reply_up): Update.
8487         (struct stop_reply): Derive from notif_event.  Don't typedef.
8488         <regcache>: Now a std::vector.
8489         (stop_reply_xfree): Remove.
8490         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8491         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8492         (remote_target::discard_pending_stop_replies): Use delete.
8493         (remote_target::remote_parse_stop_reply): Update.
8494         (remote_target::process_stop_reply): Update.
8495         * remote-notif.h (struct notif_event): Add virtual destructor.
8496         Remove "dtr" member.
8497         (struct notif_client) <alloc_event>: Return a unique_ptr.
8498         (notif_event_xfree): Don't declare.
8499         (notif_event_up): New typedef.
8500         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8501         (notif_event_xfree, do_notif_event_xfree): Remove.
8502         (remote_notif_state_xfree): Update.
8503
8504 2019-03-06  Tom Tromey  <tom@tromey.com>
8505
8506         * infrun.c (displaced_step_clear_cleanup): Now a
8507         forward_scope_exit type.
8508         (displaced_step_prepare_throw): Update.
8509         (displaced_step_fixup): Update.
8510
8511 2019-03-06  Tom Tromey  <tom@tromey.com>
8512
8513         * inferior.h (class inferior): Update comment.
8514         * gdbthread.h (class thread_info): Update comment.
8515
8516 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8517             Tom Tromey  <tom@tromey.com>
8518
8519         * stabsread.h (struct stab_section_list): Remove.
8520         (coffstab_build_psymtabs): Update.
8521         * dbxread.c (symbuf_sections): Now a std::vector.
8522         (sect_idx): New global.
8523         (fill_symbuf): Update.
8524         (coffstab_build_psymtabs): Change type of stabsects parameter.
8525         Update.
8526         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8527         std::vector.
8528         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8529         (coff_locate_sections): Update.
8530         (coff_symfile_read): Remove cleanups.  Update.
8531         (init_stringtab): Add storage parameter.
8532         (free_stringtab, free_stringtab_cleanup): Remove.
8533         (init_lineno): Add storage parameter.
8534         (free_linetab, free_linetab_cleanup): Remove.
8535
8536 2019-03-06  Pedro Alves  <palves@redhat.com>
8537
8538         * linux-fork.c (fork_info::clobber_regs): Delete.
8539         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8540         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8541         comment.  Adjust.
8542         (scoped_switch_fork_info::scoped_switch_fork_info)
8543         (checkpoint_command, linux_fork_context): Adjust
8544         fork_save_infrun_state calls.
8545
8546 2019-03-06  Pedro Alves  <palves@redhat.com>
8547
8548         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8549         (inf_has_multiple_threads): Return 'bool' and rewrite using
8550         inferior_info::threads().
8551
8552 2019-03-06  Pedro Alves  <palves@redhat.com>
8553
8554         * linux-fork.c: Include <list>.
8555         (fork_list): Now a std::list instance.
8556         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8557         (forks_exist_p, find_last_fork): Adjust.
8558         (new_fork): Delete.
8559         (one_fork_p): New.
8560         (add_fork): Adjust.
8561         (free_fork): Delete, folded into fork_info::~fork_info().
8562         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8563         Adjust.
8564         (init_fork_list): Delete.
8565         (linux_fork_killall, linux_fork_mourn_inferior)
8566         (linux_fork_detach, info_checkpoints_command): Adjust.
8567         (_initialize_linux_fork): No longer call init_fork_list.
8568
8569 2019-03-06  Pedro Alves  <palves@redhat.com>
8570
8571         * linux-fork.c (new_fork): New, split out of ...
8572         (add_fork): ... this.  Return void.  Move "first fork" special
8573         case from here, to ...
8574         (checkpoint_command): ... here.
8575         * linux-linux.h (add_fork): Return void.
8576
8577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8580
8581 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8582             Chris January  <chris.january@arm.com>
8583             David Lecomber  <david.lecomber@arm.com>
8584
8585         * f-exp.y: New token, UNOP_INTRINSIC.
8586         (exp): New pattern using UNOP_INTRINSIC token.
8587         (f77_keywords): Add 'abs' keyword.
8588         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8589         (value_from_host_double): New function.
8590         (evaluate_subexp_f): Support UNOP_ABS.
8591
8592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8593
8594         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8595         types.
8596
8597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8598
8599         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8600         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8601         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8602
8603 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8604
8605         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8606
8607 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8608             Chris January  <chris.january@arm.com>
8609
8610         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8611         * f-exp.y: Define 'KIND' token.
8612         (exp): New pattern for KIND expressions.
8613         (ptype): Handle types with a kind extension.
8614         (direct_abs_decl): Extend to spot kind extensions.
8615         (f77_keywords): Add 'kind' to the list.
8616         (push_kind_type): New function.
8617         (convert_to_kind_type): New function.
8618         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8619         * parse.c (operator_length_standard): Likewise.
8620         * parser-defs.h (enum type_pieces): Add tp_kind.
8621         * std-operator.def: Add UNOP_KIND.
8622
8623 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8624
8625         * f-exp.y (f_parse): Set yydebug.
8626
8627 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8628
8629         * f-lang.c (evaluate_subexp_f): New function.
8630         (exp_descriptor_f): New global.
8631         (f_language_defn): Use exp_descriptor_f instead of
8632         exp_descriptor_standard.
8633
8634 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * f-exp.y (struct token): Add comments.
8637         (dot_ops): Remove uppercase versions and the end marker.
8638         (f77_keywords): Likewise.
8639         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8640         entries in the dot_ops array are case insensitive, and use
8641         strncasecmp to compare strings.  Also some whitespace cleanup in
8642         this area.  Similar for the f77_keywords array, except entries in
8643         this list might be case sensitive.
8644
8645 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8646
8647         * f-exp.y (struct f77_boolean_val): Add comments.
8648         (boolean_values): Remove uppercase versions, and end marker.
8649         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8650         and use strncasecmp to achieve case insensitivity.  Additionally,
8651         perform whitespace cleanup around this code.
8652
8653 2019-03-06  Tom Tromey  <tromey@adacore.com>
8654
8655         * remote-sim.c (gdbsim_target_open): Use result of
8656         gdb_argv::release.
8657
8658 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8659         Dirk Schubert  <dirk.schubert@arm.com>
8660         Chris January  <chris.january@arm.com>
8661
8662         * eval.c (evaluate_subexp_standard): Call Fortran argument
8663         wrapping logic.
8664         * f-lang.c (struct value): A value which can be passed into a
8665         Fortran function call.
8666         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8667         where appropriate.
8668         (struct type): Value ready for a Fortran function call.
8669         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8670         is needed.
8671         * f-lang.h (fortran_argument_convert): Declaration.
8672         (fortran_preserve_arg_pointer): Declaration.
8673         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8674
8675 2019-03-05  Tom Tromey  <tromey@adacore.com>
8676
8677         * python/py-prettyprint.c (print_string_repr): Remove #if.
8678         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8679
8680 2019-03-05  Tom Tromey  <tromey@adacore.com>
8681
8682         * target.c (the_dummy_target): Move later.  Change type to
8683         "dummy_target".
8684         (initialize_targets): Don't initialize the_dummy_target.
8685
8686 2019-03-05  Tom Tromey  <tromey@adacore.com>
8687
8688         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8689         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8690
8691 2019-03-05  Tom Tromey  <tromey@adacore.com>
8692
8693         * windows-nat.c (windows_nat_target::attach)
8694         (windows_nat_target::detach): Don't call gdb_flush.
8695         * valprint.c (generic_val_print, val_print, val_print_string):
8696         Don't call gdb_flush.
8697         * utils.c (defaulted_query): Don't call gdb_flush.
8698         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8699         * target.c (target_announce_detach): Don't call gdb_flush.
8700         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8701         * remote.c (extended_remote_target::attach): Don't call
8702         gdb_flush.
8703         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8704         * printcmd.c (do_examine): Don't call gdb_flush.
8705         (info_display_command): Don't call gdb_flush.
8706         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8707         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8708         * memattr.c (info_mem_command): Don't call gdb_flush.
8709         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8710         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8711         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8712         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8713         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8714         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8715         (gnu_nat_target::detach): Don't call gdb_flush.
8716         * f-valprint.c (f_val_print): Don't call gdb_flush.
8717         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8718         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8719         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8720         gdb_flush.
8721         * c-valprint.c (c_val_print): Don't call gdb_flush.
8722         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8723
8724 2019-03-05  Tom Tromey  <tromey@adacore.com>
8725
8726         * varobj.c (update_dynamic_varobj_children): Update.
8727         (install_default_visualizer): Use reset, not release.
8728         * value.c (set_internalvar): Update.
8729         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8730         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8731         ATTRIBUTE_UNUSED_RESULT.
8732
8733 2019-03-05  Tom Tromey  <tromey@adacore.com>
8734
8735         * remote.c (class scoped_remote_fd) <release>: Add
8736         ATTRIBUTE_UNUSED_RESULT.
8737
8738 2019-03-05  Tom Tromey  <tromey@adacore.com>
8739
8740         * macroexp.c (struct macro_buffer) <release>: Add
8741         ATTRIBUTE_UNUSED_RESULT.
8742
8743 2019-03-05  Tom Tromey  <tromey@adacore.com>
8744
8745         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8746         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8747         ATTRIBUTE_UNUSED_RESULT.
8748
8749 2019-03-05  Tom Tromey  <tromey@adacore.com>
8750
8751         * common/scoped_fd.h (class scoped_fd) <release>: Add
8752         ATTRIBUTE_UNUSED_RESULT.
8753
8754 2019-03-05  Tom Tromey  <tromey@adacore.com>
8755
8756         * parser-defs.h (struct parser_state) <release>: Add
8757         ATTRIBUTE_UNUSED_RESULT.
8758
8759 2019-03-05  Tom Tromey  <tromey@adacore.com>
8760
8761         * utils.h (class gdb_argv) <release>: Add
8762         ATTRIBUTE_UNUSED_RESULT.
8763         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8764
8765 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8766
8767         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8768         for-loop range, to avoid compiler warnings.
8769
8770         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8771         avoid compiler warnings about unused variables.
8772
8773         * NEWS: Mention end of support for native debugging on MS-Windows
8774         before XP.
8775
8776         PR gdb/24292
8777         * common/netstuff.c:
8778         * gdbserver/gdbreplay.c
8779         * gdbserver/remote-utils.c:
8780         * ser-tcp.c:
8781         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8782         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8783         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8784         'getaddrinfo' and 'freeaddrinfo' were not available before
8785         Windows XP, and mingw.org's MinGW headers by default define
8786         _WIN32_WINNT to 0x500.
8787
8788 2019-03-01  Gary Benson <gbenson@redhat.com>
8789
8790         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8791
8792 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8793             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8794
8795         PR gdb/8527
8796         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8797         set_sigint_trap, clear_sigint_trap.
8798
8799 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8800
8801         * target.c (target_detach): Clear the regcache and the
8802         frame cache.
8803
8804 2019-02-27  Pedro Alves  <palves@redhat.com>
8805
8806         * utils.c (set_screen_size): When we cap the height/width sizes,
8807         tweak the corresponding command variable to show "unlimited":
8808
8809 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8810             Pedro Alves  <palves@redhat.com>
8811
8812         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8813         before calling rl_set_screen_size.
8814
8815 2019-02-27  Tom Tromey  <tromey@adacore.com>
8816
8817         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8818         define.
8819         * python/py-value.c: Remove Python 2.4 workaround.
8820         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8821         workaround.
8822         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8823         Python 2.4 workaround.
8824         * python/python-internal.h: Remove Python 2.4 comment.
8825         (Py_ssize_t): Don't define.
8826         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8827         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8828         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8829         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8830         * python/python.c (do_start_initialization): Remove Python 2.4
8831         workaround.
8832         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8833         (print_children): Remove Python 2.4 workaround.
8834         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8835         workaround.
8836         (CHARBUFFERPROC_NAME): Remove.
8837         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8838         Python 2.4 workaround.
8839
8840 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8841
8842         * NEWS: Note minimum Python version.
8843
8844 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8845
8846         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8847         code from these functions.  Remove corresponding ifdefs.  Use
8848         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8849         Remove gotos and target of gotos.
8850         (infpy_search_memory): Likewise.
8851
8852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8853
8854         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8855         (hppa_gdbarch_init): Don't register deleted functions with
8856         gdbarch.
8857
8858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8861         (h8300_unwind_sp): Delete.
8862         (h8300_dummy_id): Delete.
8863         (h8300_gdbarch_init): Don't register deleted functions with
8864         gdbarch.
8865
8866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8869         (ft32_unwind_pc): Delete.
8870         (ft32_unwind_sp): Delete.
8871         (ft32_gdbarch_init): Don't register deleted functions with
8872         gdbarch.
8873
8874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8877         (frv_unwind_pc): Delete.
8878         (frv_unwind_sp): Delete.
8879         (frv_gdbarch_init): Don't register deleted functions with
8880         gdbarch.
8881
8882 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8885         (riscv_unwind_pc): Delete.
8886         (riscv_unwind_sp): Delete.
8887         (riscv_gdbarch_init): Don't register deleted functions with
8888         gdbarch.
8889
8890 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8893         (csky_unwind_pc): Delete.
8894         (csky_unwind_sp): Delete.
8895         (csky_gdbarch_init): Don't register deleted functions with
8896         gdbarch.
8897
8898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8899
8900         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8901         (cris_unwind_pc): Delete.
8902         (cris_unwind_sp): Delete.
8903         (cris_gdbarch_init): Don't register deleted functions with
8904         gdbarch.
8905
8906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8907
8908         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8909         (bfin_unwind_pc): Delete.
8910         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8911
8912 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8913
8914         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8915         (arm_unwind_pc): Delete.
8916         (arm_unwind_sp): Delete.
8917         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8918
8919 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8920
8921         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8922         (arc_unwind_pc): Delete.
8923         (arc_unwind_sp): Delete.
8924         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8925
8926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8929         (alpha_unwind_pc): Delete.
8930         (alpha_gdbarch_init): Don't register deleted functions with
8931         gdbarch.
8932
8933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8934
8935         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8936         (aarch64_unwind_pc): Delete.
8937         (aarch64_unwind_sp): Delete.
8938         (aarch64_gdbarch_init): Don't register deleted functions with
8939         gdbarch.
8940
8941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8942
8943         * gdbtypes.c (type_align): Don't consider static members when
8944         computing structure alignment.
8945
8946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8947
8948         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8949         return 0 for other types.
8950         * arch-utils.c (default_type_align): Always return 0.
8951         * gdbarch.h: Regenerate.
8952         * gdbarch.sh (type_align): Extend comment.
8953         * gdbtypes.c (type_align): Add additional comments, always call
8954         gdbarch_type_align before applying the default rules.
8955         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8956         generic code will then apply a suitable default.
8957         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8958         types, return 0 for other types.
8959
8960 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8961
8962         * NEWS: Create a new section for the next release branch.
8963         Rename the section of the current branch, now that it has
8964         been cut.
8965
8966 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8967
8968         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8969         * version.in: Bump version to 8.3.50.DATE-git.
8970
8971 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * aix-thread.c (ptid_cmp): Remove unused variable.
8974         (get_signaled_thread): Likewise.
8975         (store_regs_user_thread): Likewise.
8976         (store_regs_kernel_thread): Likewise.
8977         (fetch_regs_kernel_thread): Remove shadowed variable.
8978
8979 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8980
8981         * features/riscv/32bit-cpu.xml: Add register numbers.
8982         * features/riscv/32bit-fpu.c: Regenerate.
8983         * features/riscv/32bit-fpu.xml: Add register numbers.
8984         * features/riscv/64bit-cpu.xml: Add register numbers.
8985         * features/riscv/64bit-fpu.c: Regenerate.
8986         * features/riscv/64bit-fpu.xml: Add register numbers.
8987
8988 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8989
8990         * NEWS: Mention two argument form of gdb.Value constructor.
8991         * python/py-value.c (convert_buffer_and_type_to_value): New
8992         function.
8993         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8994         Add support for handling an optional second argument.  Call
8995         convert_buffer_and_type_to_value as appropriate.
8996         * python/python-internal.h (Py_buffer_deleter): New struct.
8997         (Py_buffer_up): New typedef.
8998
8999 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9000
9001         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9002         instead of releasing ownership.
9003
9004 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9005
9006         * dwarf2read.c (open_and_init_dwp_file): Call
9007         elf_numsections instead of bfd_count_sections to initialize
9008         dwp_file->num_sections.
9009
9010 2019-02-25  Tom Tromey  <tromey@adacore.com>
9011
9012         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9013
9014 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9015
9016         * gcore.in: Add '--readnever' option when invoking GDB.
9017
9018 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9019
9020         * MAINTAINERS: Update my email address.
9021
9022 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9023
9024         * build-id.c (build_id_to_debug_bfd_1): New function.
9025         (build_id_to_debug_bfd): Look for separate debug file in
9026         sysroot.
9027
9028 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * gdbarch.sh: Update the copyright year range that is placed into
9031         generated files.
9032
9033 2019-02-22  Keith Seitz  <keiths@redhat.com>
9034
9035         PR symtab/23853
9036         * linespec.c (create_sals_line_offset): Search for the default
9037         symtab's filename instead of its fullname.
9038
9039 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9040
9041         * NEWS: Update style defaults.
9042
9043 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9044
9045         * main.c (captured_main_1): Disable styling in batch mode.
9046
9047 2019-02-20  Tom Tromey  <tom@tromey.com>
9048
9049         * symtab.c (symtab_symbol_info): Fix typos.
9050
9051 2019-02-20  Tom Tromey  <tromey@adacore.com>
9052
9053         * findcmd.c (_initialize_mem_search): Use upper case for
9054         metasyntactic variables.
9055
9056 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9057
9058         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9059         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9060
9061 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9062
9063         * top.h (source_file_name): Change to std::string.
9064         * top.c (source_file_name): Likewise.
9065         (command_line_input): Adjust.
9066         * cli/cli-script.c (script_from_file): Adjust.
9067
9068 2019-02-19  Tom Tromey  <tromey@adacore.com>
9069
9070         * ravenscar-thread.c
9071         (ravenscar_thread_target::update_thread_list): Don't call
9072         ada_build_task_list.
9073         * ada-lang.h (ada_build_task_list): Don't declare.
9074         * ada-tasks.c (struct ada_tasks_inferior_data)
9075         <task_list_valid_p>: Now bool.
9076         (read_known_tasks, ada_task_list_changed)
9077         (ada_tasks_invalidate_inferior_data): Update.
9078         (read_known_tasks_array): Return bool.
9079         (read_known_tasks_list): Likewise.
9080         (read_known_tasks): Return void.
9081         (ada_build_task_list): Now static.
9082
9083 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9084
9085         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9086         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9087
9088 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9089
9090         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9091         variant for ada_tasks_pspace_data_handle and
9092         ada_tasks_inferior_data_handle.
9093         (ada_tasks_pspace_data_cleanup): New function.
9094         (ada_tasks_inferior_data_cleanup): New function.
9095
9096 2019-02-17  Tom Tromey  <tom@tromey.com>
9097
9098         * macrotab.h (macro_source_fullname): Return a std::string.
9099         * macrotab.c (macro_include, check_for_redefinition)
9100         (macro_undef, macro_lookup_definition, foreach_macro)
9101         (foreach_macro_in_scope): Update.
9102         (macro_source_fullname): Return a std::string.
9103         * macrocmd.c (show_pp_source_pos): Update.
9104
9105 2019-02-17  Tom Tromey  <tom@tromey.com>
9106
9107         * macrocmd.c (show_pp_source_pos): Style the file names.
9108
9109 2019-02-17  Tom Tromey  <tom@tromey.com>
9110
9111         PR tui/24197:
9112         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9113
9114 2019-02-17  Tom Tromey  <tom@tromey.com>
9115
9116         * ada-lang.c (user_select_syms): Use filtered printing.
9117         * utils.c (wrap_style): New global.
9118         (desired_style): Remove.
9119         (emit_style_escape): Add stream parameter.
9120         (set_output_style, reset_terminal_style, prompt_for_continue):
9121         Update.
9122         (flush_wrap_buffer): Only flush gdb_stdout.
9123         (wrap_here): Set wrap_style.
9124         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9125         treat escape sequences as a character.  Change when wrap buffer is
9126         flushed.
9127         (fputs_styled): Do not set the output style when the default is
9128         requested.
9129         * ui-style.h (struct ui_file_style) <is_default>: New method.
9130         * source.c (print_source_lines_base): Emit escape sequences in one
9131         piece.
9132
9133 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9134
9135         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9136         integers and enumeration types.
9137
9138 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9139
9140         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9141         instead of lookup_symbol_in_language
9142         (do_exact_match): New function.
9143         (ada_get_symbol_name_matcher): Return do_exact_match when
9144         doing a verbatim match.
9145
9146 2019-02-15  Tom Tromey  <tromey@adacore.com>
9147
9148         * ravenscar-thread.c (ravenscar_thread_target::resume)
9149         (ravenscar_thread_target::wait): Special case wildcard requests.
9150
9151 2019-02-15  Tom Tromey  <tromey@adacore.com>
9152
9153         * ravenscar-thread.c (base_ptid): Remove.
9154         (struct ravenscar_thread_target) <close>: New method.
9155         <m_base_ptid>: New member.
9156         <update_inferior_ptid, active_task, task_is_currently_active,
9157         runtime_initialized>: Declare methods.
9158         <ravenscar_thread_target>: Add constructor.
9159         (ravenscar_thread_target::task_is_currently_active)
9160         (ravenscar_thread_target::update_inferior_ptid)
9161         (ravenscar_runtime_initialized): Rename.  Now methods.
9162         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9163         (ravenscar_thread_target::update_thread_list): Update.
9164         (ravenscar_thread_target::active_task): Now method.
9165         (ravenscar_thread_target::store_registers)
9166         (ravenscar_thread_target::prepare_to_store)
9167         (ravenscar_thread_target::prepare_to_store)
9168         (ravenscar_thread_target::mourn_inferior): Update.
9169         (ravenscar_inferior_created): Use "new" to create target.
9170         (ravenscar_thread_target::get_ada_task_ptid): Update.
9171         (_initialize_ravenscar): Don't initialize base_ptid.
9172         (ravenscar_ops): Remove global.
9173
9174 2019-02-15  Tom Tromey  <tromey@adacore.com>
9175
9176         * target.h (push_target): Declare new overload.
9177         * target.c (push_target): New overload, taking an rvalue reference.
9178         * remote.c (remote_target::open_1): Use push_target overload.
9179         * corelow.c (core_target_open): Use push_target overload.
9180
9181 2019-02-15  Tom Tromey  <tromey@adacore.com>
9182
9183         * ravenscar-thread.c (is_ravenscar_task)
9184         (ravenscar_task_is_currently_active): Return bool.
9185         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9186         (_initialize_ravenscar): Remove "(void)".
9187         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9188         Return bool.
9189
9190 2019-02-15  Tom Tromey  <tromey@adacore.com>
9191
9192         * ravenscar-thread.c (ravenscar_runtime_initializer)
9193         (has_ravenscar_runtime, get_running_thread_id)
9194         (ravenscar_thread_target::resume): Fix indentation.
9195
9196 2019-02-15  Tom Tromey  <tromey@adacore.com>
9197
9198         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9199         from ravenscar_arch_ops.
9200         (sparc_ravenscar_ops::fetch_registers)
9201         (sparc_ravenscar_ops::store_registers): Now methods.
9202         (sparc_ravenscar_prepare_to_store): Remove.
9203         (sparc_ravenscar_ops): Redefine.
9204         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9205         methods and destructor.  Remove members.
9206         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9207         (ravenscar_thread_target::store_registers)
9208         (ravenscar_thread_target::prepare_to_store): Update.
9209         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9210         Remove.
9211         (struct ppc_ravenscar_powerpc_ops): Derive from
9212         ravenscar_arch_ops.
9213         (ppc_ravenscar_powerpc_ops::fetch_registers)
9214         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9215         (ppc_ravenscar_powerpc_ops): Redefine.
9216         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9217         (ppc_ravenscar_e500_ops::fetch_registers)
9218         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9219         (ppc_ravenscar_e500_ops): Redefine.
9220         * aarch64-ravenscar-thread.c
9221         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9222         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9223         (aarch64_ravenscar_fetch_registers)
9224         (aarch64_ravenscar_store_registers): Now methods.
9225         (aarch64_ravenscar_ops): Redefine.
9226
9227 2019-02-15  Tom Tromey  <tromey@adacore.com>
9228
9229         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9230         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9231         (ravenscar_thread_target::stopped_by_watchpoint)
9232         (ravenscar_thread_target::stopped_data_address)
9233         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9234
9235 2019-02-15  Tom Tromey  <tromey@adacore.com>
9236
9237         * ravenscar-thread.c: Fix some typos.
9238
9239 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9240             Tom Tromey  <tromey@adacore.com>
9241
9242         * ada-lang.c (ada_exception_sal): Change addr_string to a
9243         std::string.
9244         (create_ada_exception_catchpoint): Update.
9245
9246 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9247             Tom Tromey  <tromey@adacore.com>
9248
9249         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9250         (bp_location_ops): Remove.
9251         (base_breakpoint_allocate_location): Update.
9252         (free_bp_location): Update.
9253         * ada-lang.c (class ada_catchpoint_location)
9254         <ada_catchpoint_location>: Remove ops parameter.
9255         (ada_catchpoint_location_dtor): Remove.
9256         (ada_catchpoint_location_ops): Remove.
9257         (allocate_location_exception): Update.
9258         * breakpoint.h (struct bp_location_ops): Remove.
9259         (class bp_location) <bp_location>: Remove bp_location_ops
9260         parameter.
9261         <~bp_location>: Add destructor.
9262         <ops>: Remove.
9263
9264 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9265             Pedro Alves  <palves@redhat.com>
9266
9267         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9268         'PATH_MAX'.
9269
9270 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9271             Samuel Thibault  <samuel.thibault@gnu.org>
9272             Thomas Schwinge  <thomas@codesourcery.com>
9273
9274         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9275         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9276
9277 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9278
9279         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9280         (check_empty): Use "const char *".
9281
9282         * gnu-nat.c (gnu_nat_target::detach): Instead of
9283         'detach_inferior (pid)' call
9284         'detach_inferior (find_inferior_pid (pid))'.
9285
9286         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9287         'nat/fork-inferior.o'.
9288         * gnu-nat.c: #include "nat/fork-inferior.h".
9289
9290         * gnu-nat.c (gnu_nat_target::detach): Instead of
9291         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9292         * gnu-nat.h: #include "inf-child.h".
9293         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9294         'i386_gnu_nat_target::fetch_registers'.
9295         (gnu_store_registers): Rename/move to
9296         'i386_gnu_nat_target::store_registers'.
9297
9298         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9299         * gnu-nat.h (mach_thread_info): New function.
9300         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9301
9302         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9303
9304 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9305
9306         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9307
9308 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9309
9310         * windows-nat.c (windows_add_thread): Add new parameter
9311         "main_thread_p" with default value set to false.  Update
9312         function documentation as well as all callers.
9313         (windows_delete_thread): Likewise.
9314         (fake_create_process): Update call to windows_add_thread.
9315         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9316         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9317         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9318         call to windows_delete_thread.
9319
9320 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9321
9322         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9323
9324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9325
9326         * symfile.c (find_separate_debug_file): Use canonical path of
9327         sysroot with child_path instead of gdb_sysroot if it is valid.
9328
9329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9330
9331         * symfile.c (find_separate_debug_file): Use child_path to
9332         determine if an object file is under a sysroot.
9333
9334 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9335
9336         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9337         unittests/child-path-selftests.c.
9338         * common/pathstuff.c (child_path): New function.
9339         * common/pathstuff.h (child_path): New prototype.
9340         * unittests/child-path-selftests.c: New file.
9341
9342 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9343
9344         * symfile.c (find_separate_debug_file): Look for separate debug
9345         files in debug directories under the sysroot.
9346
9347 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9348
9349         * symtab.h (struct minimal_symbol data_p): New const method.
9350         (struct minimal_symbol text_p): Likewise.
9351         * symtab.c (output_source_filename): Use file name style
9352         to print file name.
9353         (print_symbol_info): Likewise.
9354         (print_msymbol_info): Use address style to print addresses.
9355         Use function name style to print executable text symbols.
9356         (expand_symtab_containing_pc): Use data_p.
9357         (find_pc_sect_compunit_symtab): Likewise.
9358
9359 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9360
9361         * breakpoint.c (describe_other_breakpoints): Use address style
9362         to print addresses.
9363         (say_where): Likewise.
9364
9365 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9366
9367         * ada-typeprint.c (print_func_type): Print function name
9368         style to print function name.
9369         * c-typeprint.c (c_print_type_1): Likewise.
9370
9371 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9372
9373         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9374         for execve.
9375
9376 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9377
9378         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9379         type_stack.
9380
9381 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9382
9383         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9384         TYPE_CODE_REF types.
9385
9386 2019-02-08  Jim Wilson  <jimw@sifive.com>
9387
9388         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9389         (riscv_linux_fregset): New.
9390         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9391
9392 2019-02-07  Tom Tromey  <tom@tromey.com>
9393
9394         * thread.c (thread_cancel_execution_command): Update.
9395         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9396         methods.
9397         (struct thread_fsm_ops): Remove.
9398         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9399         (thread_fsm_should_stop, thread_fsm_return_value)
9400         (thread_fsm_set_finished, thread_fsm_finished_p)
9401         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9402         Don't declare.
9403         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9404         * infrun.c (clear_proceed_status_thread)
9405         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9406         (print_stop_event): Update.
9407         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9408         Add constructor.
9409         (step_command_fsm_ops): Remove.
9410         (new_step_command_fsm): Remove.
9411         (step_1): Update.
9412         (step_command_fsm::should_stop): Rename from
9413         step_command_fsm_should_stop.
9414         (step_command_fsm::clean_up): Rename from
9415         step_command_fsm_clean_up.
9416         (step_command_fsm::do_async_reply_reason): Rename from
9417         step_command_fsm_async_reply_reason.
9418         (struct until_next_fsm): Inherit from thread_fsm.  Add
9419         constructor.
9420         (until_next_fsm_ops): Remove.
9421         (new_until_next_fsm): Remove.
9422         (until_next_fsm::should_stop): Rename from
9423         until_next_fsm_should_stop.
9424         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9425         (until_next_fsm::do_async_reply_reason): Rename from
9426         until_next_fsm_async_reply_reason.
9427         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9428         constructor.  Change type of breakpoint.
9429         (finish_command_fsm_ops): Remove.
9430         (new_finish_command_fsm): Remove.
9431         (finish_command_fsm::should_stop): Rename from
9432         finish_command_fsm_should_stop.
9433         (finish_command_fsm::clean_up): Rename from
9434         finish_command_fsm_clean_up.
9435         (finish_command_fsm::return_value): Rename from
9436         finish_command_fsm_return_value.
9437         (finish_command_fsm::do_async_reply_reason): Rename from
9438         finish_command_fsm_async_reply_reason.
9439         (finish_command): Update.
9440         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9441         Add constructor.
9442         (call_thread_fsm_ops): Remove.
9443         (call_thread_fsm::call_thread_fsm): Rename from
9444         new_call_thread_fsm.
9445         (call_thread_fsm::should_stop): Rename from
9446         call_thread_fsm_should_stop.
9447         (call_thread_fsm::should_notify_stop): Rename from
9448         call_thread_fsm_should_notify_stop.
9449         (run_inferior_call, call_function_by_hand_dummy): Update.
9450         * cli/cli-interp.c (should_print_stop_to_console): Update.
9451         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9452         Add constructor.  Change type of location_breakpoint,
9453         caller_breakpoint.
9454         (until_break_fsm_ops): Remove.
9455         (new_until_break_fsm): Remove.
9456         (until_break_fsm::should_stop): Rename from
9457         until_break_fsm_should_stop.
9458         (until_break_fsm::clean_up): Rename from
9459         until_break_fsm_clean_up.
9460         (until_break_fsm::do_async_reply_reason): Rename from
9461         until_break_fsm_async_reply_reason.
9462         (until_break_command): Update.
9463         * thread-fsm.c: Remove.
9464         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9465
9466 2019-02-07  Tom Tromey  <tom@tromey.com>
9467
9468         * yy-remap.h: Add include guard.
9469         * xtensa-tdep.h: Add include guard.
9470         * xcoffread.h: Rename include guard.
9471         * varobj-iter.h: Add include guard.
9472         * tui/tui.h: Rename include guard.
9473         * tui/tui-winsource.h: Rename include guard.
9474         * tui/tui-wingeneral.h: Rename include guard.
9475         * tui/tui-windata.h: Rename include guard.
9476         * tui/tui-win.h: Rename include guard.
9477         * tui/tui-stack.h: Rename include guard.
9478         * tui/tui-source.h: Rename include guard.
9479         * tui/tui-regs.h: Rename include guard.
9480         * tui/tui-out.h: Rename include guard.
9481         * tui/tui-layout.h: Rename include guard.
9482         * tui/tui-io.h: Rename include guard.
9483         * tui/tui-hooks.h: Rename include guard.
9484         * tui/tui-file.h: Rename include guard.
9485         * tui/tui-disasm.h: Rename include guard.
9486         * tui/tui-data.h: Rename include guard.
9487         * tui/tui-command.h: Rename include guard.
9488         * tic6x-tdep.h: Add include guard.
9489         * target/waitstatus.h: Rename include guard.
9490         * target/wait.h: Rename include guard.
9491         * target/target.h: Rename include guard.
9492         * target/resume.h: Rename include guard.
9493         * target-float.h: Rename include guard.
9494         * stabsread.h: Add include guard.
9495         * rs6000-tdep.h: Add include guard.
9496         * riscv-fbsd-tdep.h: Add include guard.
9497         * regformats/regdef.h: Rename include guard.
9498         * record.h: Rename include guard.
9499         * python/python.h: Rename include guard.
9500         * python/python-internal.h: Rename include guard.
9501         * python/py-stopevent.h: Rename include guard.
9502         * python/py-ref.h: Rename include guard.
9503         * python/py-record.h: Rename include guard.
9504         * python/py-record-full.h: Rename include guard.
9505         * python/py-record-btrace.h: Rename include guard.
9506         * python/py-instruction.h: Rename include guard.
9507         * python/py-events.h: Rename include guard.
9508         * python/py-event.h: Rename include guard.
9509         * procfs.h: Add include guard.
9510         * proc-utils.h: Add include guard.
9511         * p-lang.h: Add include guard.
9512         * or1k-tdep.h: Rename include guard.
9513         * observable.h: Rename include guard.
9514         * nto-tdep.h: Rename include guard.
9515         * nat/x86-linux.h: Rename include guard.
9516         * nat/x86-linux-dregs.h: Rename include guard.
9517         * nat/x86-gcc-cpuid.h: Add include guard.
9518         * nat/x86-dregs.h: Rename include guard.
9519         * nat/x86-cpuid.h: Rename include guard.
9520         * nat/ppc-linux.h: Rename include guard.
9521         * nat/mips-linux-watch.h: Rename include guard.
9522         * nat/linux-waitpid.h: Rename include guard.
9523         * nat/linux-ptrace.h: Rename include guard.
9524         * nat/linux-procfs.h: Rename include guard.
9525         * nat/linux-osdata.h: Rename include guard.
9526         * nat/linux-nat.h: Rename include guard.
9527         * nat/linux-namespaces.h: Rename include guard.
9528         * nat/linux-btrace.h: Rename include guard.
9529         * nat/glibc_thread_db.h: Rename include guard.
9530         * nat/gdb_thread_db.h: Rename include guard.
9531         * nat/gdb_ptrace.h: Rename include guard.
9532         * nat/fork-inferior.h: Rename include guard.
9533         * nat/amd64-linux-siginfo.h: Rename include guard.
9534         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9535         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9536         * nat/aarch64-linux.h: Rename include guard.
9537         * nat/aarch64-linux-hw-point.h: Rename include guard.
9538         * mn10300-tdep.h: Add include guard.
9539         * mips-linux-tdep.h: Add include guard.
9540         * mi/mi-parse.h: Rename include guard.
9541         * mi/mi-out.h: Rename include guard.
9542         * mi/mi-main.h: Rename include guard.
9543         * mi/mi-interp.h: Rename include guard.
9544         * mi/mi-getopt.h: Rename include guard.
9545         * mi/mi-console.h: Rename include guard.
9546         * mi/mi-common.h: Rename include guard.
9547         * mi/mi-cmds.h: Rename include guard.
9548         * mi/mi-cmd-break.h: Rename include guard.
9549         * m2-lang.h: Add include guard.
9550         * location.h: Rename include guard.
9551         * linux-record.h: Rename include guard.
9552         * linux-nat.h: Add include guard.
9553         * linux-fork.h: Add include guard.
9554         * i386-darwin-tdep.h: Rename include guard.
9555         * hppa-linux-offsets.h: Add include guard.
9556         * guile/guile.h: Rename include guard.
9557         * guile/guile-internal.h: Rename include guard.
9558         * gnu-nat.h: Rename include guard.
9559         * gdb-stabs.h: Rename include guard.
9560         * frv-tdep.h: Add include guard.
9561         * f-lang.h: Add include guard.
9562         * event-loop.h: Add include guard.
9563         * darwin-nat.h: Rename include guard.
9564         * cp-abi.h: Rename include guard.
9565         * config/sparc/nm-sol2.h: Rename include guard.
9566         * config/nm-nto.h: Rename include guard.
9567         * config/nm-linux.h: Add include guard.
9568         * config/i386/nm-i386gnu.h: Rename include guard.
9569         * config/djgpp/nl_types.h: Rename include guard.
9570         * config/djgpp/langinfo.h: Rename include guard.
9571         * compile/gcc-cp-plugin.h: Add include guard.
9572         * compile/gcc-c-plugin.h: Add include guard.
9573         * compile/compile.h: Rename include guard.
9574         * compile/compile-object-run.h: Rename include guard.
9575         * compile/compile-object-load.h: Rename include guard.
9576         * compile/compile-internal.h: Rename include guard.
9577         * compile/compile-cplus.h: Rename include guard.
9578         * compile/compile-c.h: Rename include guard.
9579         * common/xml-utils.h: Rename include guard.
9580         * common/x86-xstate.h: Rename include guard.
9581         * common/version.h: Rename include guard.
9582         * common/vec.h: Rename include guard.
9583         * common/tdesc.h: Rename include guard.
9584         * common/selftest.h: Rename include guard.
9585         * common/scoped_restore.h: Rename include guard.
9586         * common/scoped_mmap.h: Rename include guard.
9587         * common/scoped_fd.h: Rename include guard.
9588         * common/safe-iterator.h: Rename include guard.
9589         * common/run-time-clock.h: Rename include guard.
9590         * common/refcounted-object.h: Rename include guard.
9591         * common/queue.h: Rename include guard.
9592         * common/ptid.h: Rename include guard.
9593         * common/print-utils.h: Rename include guard.
9594         * common/preprocessor.h: Rename include guard.
9595         * common/pathstuff.h: Rename include guard.
9596         * common/observable.h: Rename include guard.
9597         * common/netstuff.h: Rename include guard.
9598         * common/job-control.h: Rename include guard.
9599         * common/host-defs.h: Rename include guard.
9600         * common/gdb_wait.h: Rename include guard.
9601         * common/gdb_vecs.h: Rename include guard.
9602         * common/gdb_unlinker.h: Rename include guard.
9603         * common/gdb_unique_ptr.h: Rename include guard.
9604         * common/gdb_tilde_expand.h: Rename include guard.
9605         * common/gdb_sys_time.h: Rename include guard.
9606         * common/gdb_string_view.h: Rename include guard.
9607         * common/gdb_splay_tree.h: Rename include guard.
9608         * common/gdb_setjmp.h: Rename include guard.
9609         * common/gdb_ref_ptr.h: Rename include guard.
9610         * common/gdb_optional.h: Rename include guard.
9611         * common/gdb_locale.h: Rename include guard.
9612         * common/gdb_assert.h: Rename include guard.
9613         * common/filtered-iterator.h: Rename include guard.
9614         * common/filestuff.h: Rename include guard.
9615         * common/fileio.h: Rename include guard.
9616         * common/environ.h: Rename include guard.
9617         * common/common-utils.h: Rename include guard.
9618         * common/common-types.h: Rename include guard.
9619         * common/common-regcache.h: Rename include guard.
9620         * common/common-inferior.h: Rename include guard.
9621         * common/common-gdbthread.h: Rename include guard.
9622         * common/common-exceptions.h: Rename include guard.
9623         * common/common-defs.h: Rename include guard.
9624         * common/common-debug.h: Rename include guard.
9625         * common/cleanups.h: Rename include guard.
9626         * common/buffer.h: Rename include guard.
9627         * common/btrace-common.h: Rename include guard.
9628         * common/break-common.h: Rename include guard.
9629         * cli/cli-utils.h: Rename include guard.
9630         * cli/cli-style.h: Rename include guard.
9631         * cli/cli-setshow.h: Rename include guard.
9632         * cli/cli-script.h: Rename include guard.
9633         * cli/cli-interp.h: Rename include guard.
9634         * cli/cli-decode.h: Rename include guard.
9635         * cli/cli-cmds.h: Rename include guard.
9636         * charset-list.h: Add include guard.
9637         * buildsym-legacy.h: Rename include guard.
9638         * bfin-tdep.h: Add include guard.
9639         * ax.h: Rename include guard.
9640         * arm-linux-tdep.h: Add include guard.
9641         * arm-fbsd-tdep.h: Add include guard.
9642         * arch/xtensa.h: Rename include guard.
9643         * arch/tic6x.h: Add include guard.
9644         * arch/i386.h: Add include guard.
9645         * arch/arm.h: Rename include guard.
9646         * arch/arm-linux.h: Rename include guard.
9647         * arch/arm-get-next-pcs.h: Rename include guard.
9648         * arch/amd64.h: Add include guard.
9649         * arch/aarch64-insn.h: Rename include guard.
9650         * arch-utils.h: Rename include guard.
9651         * annotate.h: Add include guard.
9652         * amd64-darwin-tdep.h: Rename include guard.
9653         * aarch64-linux-tdep.h: Add include guard.
9654         * aarch64-fbsd-tdep.h: Add include guard.
9655         * aarch32-linux-nat.h: Add include guard.
9656
9657 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9658
9659         * macrotab.c (macro_define_internal): New function that
9660         factorizes macro_define_object_internal and macro_define_function
9661         code.
9662         (macro_define_object_internal): Use macro_define_internal.
9663         (macro_define_function): Likewise.
9664
9665 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9666
9667         * macrocmd.c (extract_identifier): Return
9668         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9669         callers.
9670
9671 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9672
9673         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9674
9675 2019-02-05  Tom Tromey  <tom@tromey.com>
9676
9677         * target.c (target_stack::unpush): Move assertion earlier.
9678
9679 2019-01-30  Tom Tromey  <tom@tromey.com>
9680
9681         PR python/23615:
9682         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9683         (gdbpy_parse_and_eval): Likewise.
9684         * python/python-internal.h (gdbpy_allow_threads): New class.
9685
9686 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9687
9688         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9689         (aarch64_fbsd_fpregmap): Move earlier.
9690         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9691         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9692         instead of individual calls to trad_frame_set_reg_addr.
9693         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9694         earlier.
9695         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9696         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9697         instead of individual calls to trad_frame_set_reg_addr.
9698
9699 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9700
9701         * CONTRIBUTE: Replace contribution list with wiki link.
9702
9703 2019-01-25  Tom Tromey  <tom@tromey.com>
9704
9705         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9706
9707 2019-01-25  Tom Tromey  <tom@tromey.com>
9708
9709         * xtensa-linux-nat.c: Fix common/ includes.
9710         * xml-support.h: Fix common/ includes.
9711         * xml-support.c: Fix common/ includes.
9712         * x86-linux-nat.c: Fix common/ includes.
9713         * windows-nat.c: Fix common/ includes.
9714         * varobj.h: Fix common/ includes.
9715         * varobj.c: Fix common/ includes.
9716         * value.c: Fix common/ includes.
9717         * valops.c: Fix common/ includes.
9718         * utils.c: Fix common/ includes.
9719         * unittests/xml-utils-selftests.c: Fix common/ includes.
9720         * unittests/utils-selftests.c: Fix common/ includes.
9721         * unittests/unpack-selftests.c: Fix common/ includes.
9722         * unittests/tracepoint-selftests.c: Fix common/ includes.
9723         * unittests/style-selftests.c: Fix common/ includes.
9724         * unittests/string_view-selftests.c: Fix common/ includes.
9725         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9726         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9727         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9728         * unittests/rsp-low-selftests.c: Fix common/ includes.
9729         * unittests/parse-connection-spec-selftests.c: Fix common/
9730         includes.
9731         * unittests/optional-selftests.c: Fix common/ includes.
9732         * unittests/offset-type-selftests.c: Fix common/ includes.
9733         * unittests/observable-selftests.c: Fix common/ includes.
9734         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9735         * unittests/memrange-selftests.c: Fix common/ includes.
9736         * unittests/memory-map-selftests.c: Fix common/ includes.
9737         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9738         * unittests/function-view-selftests.c: Fix common/ includes.
9739         * unittests/environ-selftests.c: Fix common/ includes.
9740         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9741         * unittests/common-utils-selftests.c: Fix common/ includes.
9742         * unittests/cli-utils-selftests.c: Fix common/ includes.
9743         * unittests/array-view-selftests.c: Fix common/ includes.
9744         * ui-file.c: Fix common/ includes.
9745         * tui/tui-io.c: Fix common/ includes.
9746         * tracepoint.h: Fix common/ includes.
9747         * tracepoint.c: Fix common/ includes.
9748         * tracefile-tfile.c: Fix common/ includes.
9749         * top.h: Fix common/ includes.
9750         * top.c: Fix common/ includes.
9751         * thread.c: Fix common/ includes.
9752         * target/waitstatus.h: Fix common/ includes.
9753         * target/waitstatus.c: Fix common/ includes.
9754         * target.h: Fix common/ includes.
9755         * target.c: Fix common/ includes.
9756         * target-memory.c: Fix common/ includes.
9757         * target-descriptions.c: Fix common/ includes.
9758         * symtab.h: Fix common/ includes.
9759         * symfile.c: Fix common/ includes.
9760         * stap-probe.c: Fix common/ includes.
9761         * spu-linux-nat.c: Fix common/ includes.
9762         * sparc-nat.c: Fix common/ includes.
9763         * source.c: Fix common/ includes.
9764         * solib.c: Fix common/ includes.
9765         * solib-target.c: Fix common/ includes.
9766         * ser-unix.c: Fix common/ includes.
9767         * ser-tcp.c: Fix common/ includes.
9768         * ser-pipe.c: Fix common/ includes.
9769         * ser-base.c: Fix common/ includes.
9770         * selftest-arch.c: Fix common/ includes.
9771         * s12z-tdep.c: Fix common/ includes.
9772         * rust-exp.y: Fix common/ includes.
9773         * rs6000-aix-tdep.c: Fix common/ includes.
9774         * riscv-tdep.c: Fix common/ includes.
9775         * remote.c: Fix common/ includes.
9776         * remote-notif.h: Fix common/ includes.
9777         * remote-fileio.h: Fix common/ includes.
9778         * remote-fileio.c: Fix common/ includes.
9779         * regcache.h: Fix common/ includes.
9780         * regcache.c: Fix common/ includes.
9781         * record-btrace.c: Fix common/ includes.
9782         * python/python.c: Fix common/ includes.
9783         * python/py-type.c: Fix common/ includes.
9784         * python/py-inferior.c: Fix common/ includes.
9785         * progspace.h: Fix common/ includes.
9786         * producer.c: Fix common/ includes.
9787         * procfs.c: Fix common/ includes.
9788         * proc-api.c: Fix common/ includes.
9789         * printcmd.c: Fix common/ includes.
9790         * ppc-linux-nat.c: Fix common/ includes.
9791         * parser-defs.h: Fix common/ includes.
9792         * osdata.c: Fix common/ includes.
9793         * obsd-nat.c: Fix common/ includes.
9794         * nat/x86-linux.c: Fix common/ includes.
9795         * nat/x86-linux-dregs.c: Fix common/ includes.
9796         * nat/x86-dregs.h: Fix common/ includes.
9797         * nat/x86-dregs.c: Fix common/ includes.
9798         * nat/ppc-linux.c: Fix common/ includes.
9799         * nat/mips-linux-watch.h: Fix common/ includes.
9800         * nat/mips-linux-watch.c: Fix common/ includes.
9801         * nat/linux-waitpid.c: Fix common/ includes.
9802         * nat/linux-ptrace.h: Fix common/ includes.
9803         * nat/linux-ptrace.c: Fix common/ includes.
9804         * nat/linux-procfs.c: Fix common/ includes.
9805         * nat/linux-personality.c: Fix common/ includes.
9806         * nat/linux-osdata.c: Fix common/ includes.
9807         * nat/linux-namespaces.c: Fix common/ includes.
9808         * nat/linux-btrace.h: Fix common/ includes.
9809         * nat/linux-btrace.c: Fix common/ includes.
9810         * nat/fork-inferior.c: Fix common/ includes.
9811         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9812         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9813         * nat/aarch64-linux.c: Fix common/ includes.
9814         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9815         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9816         * namespace.h: Fix common/ includes.
9817         * mips-linux-tdep.c: Fix common/ includes.
9818         * minsyms.c: Fix common/ includes.
9819         * mi/mi-parse.h: Fix common/ includes.
9820         * mi/mi-main.c: Fix common/ includes.
9821         * mi/mi-cmd-env.c: Fix common/ includes.
9822         * memrange.h: Fix common/ includes.
9823         * memattr.c: Fix common/ includes.
9824         * maint.h: Fix common/ includes.
9825         * maint.c: Fix common/ includes.
9826         * main.c: Fix common/ includes.
9827         * machoread.c: Fix common/ includes.
9828         * location.c: Fix common/ includes.
9829         * linux-thread-db.c: Fix common/ includes.
9830         * linux-nat.c: Fix common/ includes.
9831         * linux-fork.c: Fix common/ includes.
9832         * inline-frame.c: Fix common/ includes.
9833         * infrun.c: Fix common/ includes.
9834         * inflow.c: Fix common/ includes.
9835         * inferior.h: Fix common/ includes.
9836         * inferior.c: Fix common/ includes.
9837         * infcmd.c: Fix common/ includes.
9838         * inf-ptrace.c: Fix common/ includes.
9839         * inf-child.c: Fix common/ includes.
9840         * ia64-linux-nat.c: Fix common/ includes.
9841         * i387-tdep.c: Fix common/ includes.
9842         * i386-tdep.c: Fix common/ includes.
9843         * i386-linux-tdep.c: Fix common/ includes.
9844         * i386-linux-nat.c: Fix common/ includes.
9845         * i386-go32-tdep.c: Fix common/ includes.
9846         * i386-fbsd-tdep.c: Fix common/ includes.
9847         * i386-fbsd-nat.c: Fix common/ includes.
9848         * guile/scm-type.c: Fix common/ includes.
9849         * guile/guile.c: Fix common/ includes.
9850         * go32-nat.c: Fix common/ includes.
9851         * gnu-nat.c: Fix common/ includes.
9852         * gdbthread.h: Fix common/ includes.
9853         * gdbarch-selftests.c: Fix common/ includes.
9854         * gdb_usleep.c: Fix common/ includes.
9855         * gdb_select.h: Fix common/ includes.
9856         * gdb_bfd.c: Fix common/ includes.
9857         * gcore.c: Fix common/ includes.
9858         * fork-child.c: Fix common/ includes.
9859         * findvar.c: Fix common/ includes.
9860         * fbsd-nat.c: Fix common/ includes.
9861         * event-top.c: Fix common/ includes.
9862         * event-loop.c: Fix common/ includes.
9863         * dwarf2read.c: Fix common/ includes.
9864         * dwarf2loc.c: Fix common/ includes.
9865         * dwarf2-frame.c: Fix common/ includes.
9866         * dwarf-index-cache.c: Fix common/ includes.
9867         * dtrace-probe.c: Fix common/ includes.
9868         * disasm-selftests.c: Fix common/ includes.
9869         * defs.h: Fix common/ includes.
9870         * csky-tdep.c: Fix common/ includes.
9871         * cp-valprint.c: Fix common/ includes.
9872         * cp-support.h: Fix common/ includes.
9873         * cp-support.c: Fix common/ includes.
9874         * corelow.c: Fix common/ includes.
9875         * completer.h: Fix common/ includes.
9876         * completer.c: Fix common/ includes.
9877         * compile/compile.c: Fix common/ includes.
9878         * compile/compile-loc2c.c: Fix common/ includes.
9879         * compile/compile-cplus-types.c: Fix common/ includes.
9880         * compile/compile-cplus-symbols.c: Fix common/ includes.
9881         * command.h: Fix common/ includes.
9882         * cli/cli-dump.c: Fix common/ includes.
9883         * cli/cli-cmds.c: Fix common/ includes.
9884         * charset.c: Fix common/ includes.
9885         * build-id.c: Fix common/ includes.
9886         * btrace.h: Fix common/ includes.
9887         * btrace.c: Fix common/ includes.
9888         * breakpoint.h: Fix common/ includes.
9889         * breakpoint.c: Fix common/ includes.
9890         * ax.h:
9891         (enum agent_op): Fix common/ includes.
9892         * ax-general.c (struct aop_map): Fix common/ includes.
9893         * ax-gdb.c: Fix common/ includes.
9894         * auxv.c: Fix common/ includes.
9895         * auto-load.c: Fix common/ includes.
9896         * arm-tdep.c: Fix common/ includes.
9897         * arch/riscv.c: Fix common/ includes.
9898         * arch/ppc-linux-common.c: Fix common/ includes.
9899         * arch/i386.c: Fix common/ includes.
9900         * arch/arm.c: Fix common/ includes.
9901         * arch/arm-linux.c: Fix common/ includes.
9902         * arch/arm-get-next-pcs.c: Fix common/ includes.
9903         * arch/amd64.c: Fix common/ includes.
9904         * arch/aarch64.c: Fix common/ includes.
9905         * arch/aarch64-insn.c: Fix common/ includes.
9906         * arch-utils.c: Fix common/ includes.
9907         * amd64-windows-tdep.c: Fix common/ includes.
9908         * amd64-tdep.c: Fix common/ includes.
9909         * amd64-sol2-tdep.c: Fix common/ includes.
9910         * amd64-obsd-tdep.c: Fix common/ includes.
9911         * amd64-nbsd-tdep.c: Fix common/ includes.
9912         * amd64-linux-tdep.c: Fix common/ includes.
9913         * amd64-linux-nat.c: Fix common/ includes.
9914         * amd64-fbsd-tdep.c: Fix common/ includes.
9915         * amd64-fbsd-nat.c: Fix common/ includes.
9916         * amd64-dicos-tdep.c: Fix common/ includes.
9917         * amd64-darwin-tdep.c: Fix common/ includes.
9918         * agent.c: Fix common/ includes.
9919         * ada-lang.h: Fix common/ includes.
9920         * ada-lang.c: Fix common/ includes.
9921         * aarch64-tdep.c: Fix common/ includes.
9922
9923 2019-01-25  Tom Tromey  <tom@tromey.com>
9924
9925         * common/create-version.sh: Use common/version.h.
9926
9927 2019-01-24  Pedro Alves  <palves@redhat.com>
9928
9929         * infrun.c (signal_stop, signal_print, signal_program)
9930         (signal_catch, signal_pass): Now arrays instead of pointers.
9931         (update_signals_program_target, do_target_resume)
9932         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9933         * linux-nat.c (linux_nat_target::pass_signals)
9934         (linux_nat_target::create_inferior, linux_nat_target::attach):
9935         Adjust.
9936         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9937         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9938         * procfs.c (procfs_target::pass_signals): Adjust.
9939         * record-full.c (record_full_target::resume): Adjust.
9940         * remote.c (remote_target::pass_signals)
9941         (remote_target::program_signals): Adjust.
9942         * target-debug.h (target_debug_print_signals): Now takes a
9943         gdb::array_view as parameter.  Adjust.
9944         * target.h (target_ops) <pass_signals, program_signals>: Replace
9945         pointer and length parameters with gdb::array_view.
9946         (target_pass_signals, target_program_signals): Likewise.
9947         * target-delegates.c: Regenerate.
9948
9949 2019-01-24  Pedro Alves  <palves@redhat.com>
9950
9951         * common/forward-scope-exit.h
9952         (forward_scope_exit::forward_scope_exit): Pass arguments to
9953         m_bind_function directly, instead of creating a std::bind and
9954         copying that.
9955
9956 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9957
9958         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9959         for static members.
9960         (pass_in_v_vfp_candidate): Likewise.
9961
9962 2019-01-23  Tom Tromey  <tom@tromey.com>
9963             Pedro Alves  <palves@redhat.com>
9964
9965         * regcache.c (class regcache_invalidator): Remove.
9966         (regcache::raw_write): Use make_scope_exit.
9967
9968 2019-01-23  Tom Tromey  <tom@tromey.com>
9969
9970         * ui-out.h (class ui_out_emit_type): Update comment.
9971
9972 2019-01-23  Tom Tromey  <tom@tromey.com>
9973
9974         * infrun.c (fetch_inferior_event): Update comment.
9975
9976 2019-01-23  Tom Tromey  <tom@tromey.com>
9977             Pedro Alves  <palves@redhat.com>
9978
9979         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9980         parameter.
9981         (fetch_inferior_event): Use SCOPE_EXIT.
9982
9983
9984 2019-01-23  Tom Tromey  <tom@tromey.com>
9985             Pedro Alves  <palves@redhat.com>
9986
9987         * infrun.c (disable_thread_events): Delete.
9988         (stop_all_threads): Use SCOPE_EXIT.
9989
9990 2019-01-23  Tom Tromey  <tom@tromey.com>
9991             Pedro Alves  <palves@redhat.com>
9992
9993         * symfile.c: Include forward-scope-exit.h.
9994         (clear_symtab_users_cleanup): Replace forward declaration with
9995         a FORWARD_SCOPE_EXIT.
9996         (syms_from_objfile_1): Use the forward_scope_exit and
9997         gdb::optional instead of cleanup_function.
9998         (reread_symbols): Use the forward_scope_exit instead of
9999         cleanup_function.
10000         (clear_symtab_users_cleanup): Remove function.
10001
10002 2019-01-23  Tom Tromey  <tom@tromey.com>
10003             Pedro Alves  <palves@redhat.com>
10004
10005         * linux-nat.c: Include scope-exit.h.
10006         (cleanup_target_stop): Remove.
10007         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10008         SCOPE_EXIT.
10009
10010 2019-01-23  Tom Tromey  <tom@tromey.com>
10011             Pedro Alves  <palves@redhat.com>
10012
10013         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10014         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10015
10016 2019-01-23  Tom Tromey  <tom@tromey.com>
10017             Andrew Burgess  <andrew.burgess@embecosm.com>
10018             Pedro Alves  <palves@redhat.com>
10019
10020         * infrun.c (fetch_inferior_event): Use scope_exit.
10021         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10022         * top.c (execute_command): Use scope_exit.
10023         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10024         * utils.c (do_bpstat_clear_actions_cleanup)
10025         (make_bpstat_clear_actions_cleanup): Remove.
10026
10027 2019-01-23  Tom Tromey  <tom@tromey.com>
10028             Pedro Alves  <palves@redhat.com>
10029
10030         * infrun.c: Include "common/scope-exit.h"
10031         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10032         (wait_for_inferior): Use SCOPE_EXIT.
10033         (fetch_inferior_event): Use scope_exit.
10034
10035 2019-01-23  Tom Tromey  <tom@tromey.com>
10036             Pedro Alves  <palves@redhat.com>
10037
10038         * breakpoint.c (create_breakpoint): Remove cleanup.
10039
10040 2019-01-23  Tom Tromey  <tom@tromey.com>
10041             Andrew Burgess  <andrew.burgess@embecosm.com>
10042             Pedro Alves  <palves@redhat.com>
10043
10044 2019-01-23  Pedro Alves  <palves@redhat.com>
10045
10046         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10047
10048 2019-01-23  Pedro Alves  <palves@redhat.com>
10049             Andrew Burgess  <andrew.burgess@embecosm.com>
10050
10051         * gdbthread.h: Include "common/forward-scope-exit.h".
10052         (scoped_finish_thread_state): Redefine custom class in terms of
10053         forward_scope_exit.
10054
10055 2019-01-23  Pedro Alves  <palves@redhat.com>
10056             Andrew Burgess  <andrew.burgess@embecosm.com>
10057
10058         * common/forward-scope-exit.h: New file.
10059
10060 2019-01-23  Pedro Alves  <palves@redhat.com>
10061             Andrew Burgess  <andrew.burgess@embecosm.com>
10062             Tom Tromey  <tom@tromey.com>
10063
10064         * common/scope-exit.h: New file.
10065
10066 2019-01-23  Pedro Alves  <palves@redhat.com>
10067
10068         * common/preprocessor.h (ESC): Rename to ...
10069         (ESC_PARENS): ... this.
10070         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10071         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10072
10073 2019-01-23  Tom Tromey  <tom@tromey.com>
10074
10075         * language.h (class scoped_switch_to_sym_language_if_auto):
10076         Initialize m_lang in both cases.
10077
10078 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10079
10080         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10081         with XCNEW.
10082
10083 2019-01-22  Tom Tromey  <tom@tromey.com>
10084
10085         * corelow.c: Do not include sys/file.h.
10086
10087 2019-01-22  Tom Tromey  <tom@tromey.com>
10088
10089         * tui/tui-wingeneral.h: Include gdb_curses.h.
10090
10091 2019-01-22  Tom Tromey  <tom@tromey.com>
10092
10093         * source-cache.h (class source_cache) <get_source_lines,
10094         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10095
10096 2019-01-22  Tom Tromey  <tom@tromey.com>
10097
10098         * remote-fileio.h (struct remote_target): Declare.
10099
10100 2019-01-22  Tom Tromey  <tom@tromey.com>
10101
10102         * python/py-arch.c: Do not include py-ref.h.
10103         * python/py-bpevent.c: Do not include py-ref.h.
10104         * python/py-cmd.c: Do not include py-ref.h.
10105         * python/py-continueevent.c: Do not include py-ref.h.
10106         * python/py-event.h: Do not include py-ref.h.
10107         * python/py-evtregistry.c: Do not include py-ref.h.
10108         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10109         * python/py-frame.c: Do not include py-ref.h.
10110         * python/py-framefilter.c: Do not include py-ref.h.
10111         * python/py-function.c: Do not include py-ref.h.
10112         * python/py-infevents.c: Do not include py-ref.h.
10113         * python/py-linetable.c: Do not include py-ref.h.
10114         * python/py-objfile.c: Do not include py-ref.h.
10115         * python/py-param.c: Do not include py-ref.h.
10116         * python/py-prettyprint.c: Do not include py-ref.h.
10117         * python/py-progspace.c: Do not include py-ref.h.
10118         * python/py-symbol.c: Do not include py-ref.h.
10119         * python/py-symtab.c: Do not include py-ref.h.
10120         * python/py-type.c: Do not include py-ref.h.
10121         * python/py-unwind.c: Do not include py-ref.h.
10122         * python/py-utils.c: Do not include py-ref.h.
10123         * python/py-value.c: Do not include py-ref.h.
10124         * python/py-varobj.c: Do not include py-ref.h.
10125         * python/py-xmethods.c: Do not include py-ref.h.
10126         * python/python.c: Do not include py-ref.h.
10127         * varobj.c: Do not include py-ref.h.
10128
10129 2019-01-22  Tom Tromey  <tom@tromey.com>
10130
10131         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10132         keyword for bcache.
10133
10134 2019-01-22  Tom Tromey  <tom@tromey.com>
10135
10136         * compile/compile-cplus-types.c: Remove a comment by #include.
10137
10138 2019-01-22  Tom Tromey  <tom@tromey.com>
10139
10140         * compile/gcc-c-plugin.h: Include compile-internal.h.
10141
10142 2019-01-22  Tom Tromey  <tom@tromey.com>
10143
10144         * stabsread.c (EXTERN): Do not define.
10145         (symnum, next_symbol_text_func, processing_gcc_compilation)
10146         (within_function, global_sym_chain, global_stabs)
10147         (previous_stab_code, this_object_header_files)
10148         (n_this_object_header_files)
10149         (n_allocated_this_object_header_files): Define.
10150         * stabsread.h (EXTERN): Never define.  Use "extern".
10151
10152 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10153
10154         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10155         history_value.
10156
10157 2019-01-21  Tom Tromey  <tom@tromey.com>
10158
10159         * ui-out.c: Fix includes.
10160         * tui/tui-source.c: Fix includes.
10161         * target.c: Fix includes.
10162         * remote.c: Fix includes.
10163         * regcache.c: Fix includes.
10164         * python/py-block.c: Fix includes.
10165         * printcmd.c: Fix includes.
10166         * or1k-tdep.c: Fix includes.
10167         * mi/mi-main.c: Fix includes.
10168         * m32r-tdep.c: Fix includes.
10169         * csky-tdep.c: Fix includes.
10170         * compile/compile-cplus-types.c: Fix includes.
10171         * cli/cli-interp.c: Fix includes.
10172
10173 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10174
10175         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10176         for padding.
10177
10178 2019-01-16  Tom Tromey  <tom@tromey.com>
10179
10180         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10181         earlier.
10182         (struct objfile) <msymbols_range>: Move from top level.
10183         <msymbols>: New method.
10184         (class objfile_msymbols): Remove.
10185         * symtab.c (default_collect_symbol_completion_matches_break_on):
10186         Update.
10187         * symmisc.c (dump_msymbols): Update.
10188         * stabsread.c (scan_file_globals): Update.
10189         * objc-lang.c (info_selectors_command, info_classes_command)
10190         (find_methods): Update.
10191         * minsyms.c (find_solib_trampoline_target): Update.
10192         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10193         * coffread.c (coff_symfile_read): Update.
10194         * ada-lang.c (ada_lookup_simple_minsym)
10195         (ada_collect_symbol_completion_matches): Update.
10196
10197 2019-01-16  Tom Tromey  <tom@tromey.com>
10198
10199         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10200         type.  Remove no-argument constructor.
10201         <iterator::operator++>: Simplify.
10202         <begin>: Update.
10203         <end>: Use minimal_symbol_count.
10204
10205 2019-01-16  Tom Tromey  <tom@tromey.com>
10206
10207         * objfiles.h (struct objfile) <psymtabs>: New method.
10208         (class objfile_psymtabs): Remove.
10209         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10210         typedef.
10211         <range>: New method.
10212         (require_partial_symbols): Change return type.
10213         * psymtab.c (require_partial_symbols)
10214         (psym_expand_symtabs_matching): Update.
10215         * mdebugread.c (parse_partial_symbols): Update.
10216         * dbxread.c (dbx_end_psymtab): Update.
10217
10218 2019-01-15  Tom Tromey  <tom@tromey.com>
10219
10220         * symtab.c (lookup_objfile_from_block)
10221         (lookup_symbol_in_objfile_symtabs)
10222         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10223         (find_line_symtab, info_sources_command)
10224         (default_collect_symbol_completion_matches_break_on)
10225         (make_source_files_completion_list): Update.
10226         * symmisc.c (print_objfile_statistics, dump_objfile)
10227         (maintenance_print_symbols, maintenance_info_symtabs)
10228         (maintenance_check_symtabs, maintenance_info_line_tables):
10229         Update.
10230         * source.c (select_source_symtab)
10231         (forget_cached_source_info_for_objfile): Update.
10232         * objfiles.h (class objfile_compunits): Remove.
10233         (struct objfile) <compunits_range>: New typedef.
10234         (compunits): New method.
10235         * objfiles.c (objfile_relocate1): Update.
10236         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10237         * maint.c (count_symtabs_and_blocks): Update.
10238         * linespec.c (iterate_over_all_matching_symtabs): Update.
10239         * cp-support.c (add_symbol_overload_list_qualified): Update.
10240         * coffread.c (coff_symtab_read): Update.
10241         * ada-lang.c (add_nonlocal_symbols)
10242         (ada_collect_symbol_completion_matches)
10243         (ada_add_global_exceptions): Update.
10244
10245 2019-01-15  Tom Tromey  <tom@tromey.com>
10246
10247         * progspace.h (program_space) <objfiles_safe_range>: New
10248         typedef.
10249         <objfiles_safe>: New method.
10250         * objfiles.h (class all_objfiles_safe): Remove.
10251         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10252         * jit.c (jit_inferior_exit_hook): Update.
10253
10254 2019-01-17  Tom Tromey  <tom@tromey.com>
10255
10256         * progspace.h (program_space) <objfiles_range>: New typedef.
10257         <objfiles>: New method.
10258         <objfiles_head>: Rename from objfiles.
10259         (object_files): Update.
10260         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10261         * guile/scm-pretty-print.c
10262         (ppscm_find_pretty_printer_from_objfiles): Update.
10263         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10264         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10265         Update.
10266         * python/py-progspace.c (pspy_get_objfiles): Update.
10267         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10268         Update.
10269         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10270         (objfpy_lookup_objfile_by_build_id): Update.
10271         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10272         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10273         Update.
10274         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10275         (expand_symtab_containing_pc, lookup_objfile_from_block)
10276         (lookup_static_symbol, basic_lookup_transparent_type)
10277         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10278         (find_line_symtab, info_sources_command)
10279         (default_collect_symbol_completion_matches_break_on)
10280         (make_source_files_completion_list, find_main_name): Update.
10281         * symmisc.c (print_symbol_bcache_statistics)
10282         (print_objfile_statistics, maintenance_print_symbols)
10283         (maintenance_print_msymbols, maintenance_print_objfiles)
10284         (maintenance_info_symtabs, maintenance_check_symtabs)
10285         (maintenance_expand_symtabs, maintenance_info_line_tables):
10286         Update.
10287         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10288         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10289         (map_overlay_command, unmap_overlay_command)
10290         (simple_overlay_update, expand_symtabs_matching)
10291         (map_symbol_filenames): Update.
10292         * symfile-debug.c (set_debug_symfile): Update.
10293         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10294         Update.
10295         * source.c (select_source_symtab, forget_cached_source_info):
10296         Update.
10297         * solib.c (solib_read_symbols): Update.
10298         * solib-spu.c (append_ocl_sos): Update.
10299         * psymtab.c (maintenance_print_psymbols)
10300         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10301         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10302         * printcmd.c (info_symbol_command): Update.
10303         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10304         Update.
10305         * objfiles.h (class all_objfiles): Remove.
10306         * objfiles.c (have_partial_symbols, have_full_symbols)
10307         (have_minimal_symbols, qsort_cmp, update_section_map)
10308         (shared_objfile_contains_address_p)
10309         (default_iterate_over_objfiles_in_search_order): Update.
10310         * objc-lang.c (info_selectors_command, info_classes_command)
10311         (find_methods): Update.
10312         * minsyms.c (find_solib_trampoline_target): Update.
10313         * maint.c (maintenance_info_sections)
10314         (maintenance_translate_address, count_symtabs_and_blocks):
10315         Update.
10316         * main.c (captured_main_1): Update.
10317         * linux-thread-db.c (try_thread_db_load_from_pdir)
10318         (has_libpthread): Update.
10319         * linespec.c (iterate_over_all_matching_symtabs)
10320         (search_minsyms_for_name): Update.
10321         * jit.c (jit_find_objf_with_entry_addr): Update.
10322         * hppa-tdep.c (find_unwind_entry)
10323         (hppa_lookup_stub_minimal_symbol): Update.
10324         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10325         Update.
10326         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10327         (elf_gnu_ifunc_resolve_by_got): Update.
10328         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10329         * dwarf-index-write.c (save_gdb_index_command): Update.
10330         * cp-support.c (add_symbol_overload_list_qualified): Update.
10331         * breakpoint.c (create_overlay_event_breakpoint)
10332         (create_longjmp_master_breakpoint)
10333         (create_std_terminate_master_breakpoint)
10334         (create_exception_master_breakpoint): Update.
10335         * blockframe.c (find_pc_partial_function): Update.
10336         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10337         (ada_collect_symbol_completion_matches)
10338         (ada_add_global_exceptions): Update.
10339
10340 2019-01-17  Tom Tromey  <tom@tromey.com>
10341
10342         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10343         declare VEC.
10344         (solib_target_parse_libraries): Change return type.
10345         (library_list_start_segment, library_list_start_section)
10346         (library_list_end_library, library_list_start_library); Update.
10347         (solib_target_free_library_list): Remove.
10348         (solib_target_parse_libraries): Remove cleanup.  Change return
10349         type.
10350         (solib_target_current_sos): Update.
10351
10352 2019-01-17  Tom Tromey  <tromey@bapiya>
10353
10354         * valprint.c: Replace "the the" with "the".
10355         * symtab.c: Replace "the the" with "the".
10356         * solib.c: Replace "the the" with "the".
10357         * solib-dsbt.c: Replace "the the" with "the".
10358         * linespec.c: Replace "the the" with "the".
10359         * dwarf2loc.h: Replace "the the" with "the".
10360         * amd64-windows-tdep.c: Replace "the the" with "the".
10361         * aarch64-tdep.c: Replace "the the" with "the".
10362
10363 2019-01-16  Keith Seitz  <keiths@redhat.com>
10364
10365         PR gdb/23773
10366         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10367         <builder>: Rename to ..
10368         <m_builder>: ... this and make private.
10369         (dwarf2_cu::get_builder): New method.  Change all users of
10370         `builder' to use this method.
10371         (dwarf2_start_symtab): Move to ...
10372         (dwarf2_cu::start_symtab): ... here.  Update all callers
10373         (setup_type_unit_groups): Move to ...
10374         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10375         callers.
10376         (dwarf2_cu::reset_builder): New method.
10377         (process_full_compunit, process_full_type_unit): Use
10378         dwarf2_cu::reset_builder.
10379         (follow_die_offset): Record the ancestor CU if it is different
10380         from the followed DIE's CU.
10381         (follow_die_sig_1): Likewise.
10382
10383 2019-01-15  Tom Tromey  <tom@tromey.com>
10384
10385         * remote.c (class remote_state) <buf>: Now a char_vector.
10386         <buf_size>: Remove.
10387         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10388         parameter.
10389         (remote_target::getpkt_or_notif_sane_1)
10390         (remote_target::getpkt_sane)
10391         (remote_target::getpkt_or_notif_sane): Likewise.
10392         (class remote_target) <putpkt>: New overload.
10393         (remote_target::read_frame): Change type of "buf_p".  Remove
10394         sizeof_p parameter.
10395         (packet_ok): New overload.
10396         (packet_check_result): New overload.
10397         Update all uses.
10398
10399 2019-01-14  Tom Tromey  <tom@tromey.com>
10400
10401         * remote-notif.c (handle_notification, remote_notif_ack)
10402         (remote_notif_parse): Make "buf" const.
10403         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10404         const.
10405         (remote_notif_parse, remote_notif_ack, handle_notification):
10406         Likewise.
10407         * remote.c (remote_notif_stop_parse): Make "buf" const.
10408         (remote_target::remote_parse_stop_reply): Make "buf" const.
10409         (remote_notif_stop_ack): Make "buf" const.
10410
10411 2019-01-14  Tom Tromey  <tom@tromey.com>
10412
10413         * remote.c (remote_console_output): Make parameter const.
10414
10415 2019-01-14  Tom Tromey  <tom@tromey.com>
10416
10417         * target-debug.h (target_debug_print_signals): Constify.
10418         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10419         * procfs.c (procfs_target::pass_signals): Update.
10420         * linux-nat.c (linux_nat_target::pass_signals): Update.
10421         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10422         * target-delegates.c: Rebuild.
10423         * remote.c (remote_target::program_signals): Update.
10424         (remote_target::pass_signals): Update.
10425         * target.c (target_pass_signals): Constify argument.
10426         (target_program_signals): Likewise.
10427         * target.h (struct target_ops) <pass_signals, program_signals>:
10428         Constify argument.
10429         (target_pass_signals, target_program_signals): Constify argument.
10430
10431 2019-01-14  Tom Tromey  <tom@tromey.com>
10432
10433         PR tui/28819:
10434         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10435
10436 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10437
10438         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10439         field.
10440         * rs6000-tdep.c: Include reggroups.h.
10441         (IS_V_ALIAS_PSEUDOREG): Define.
10442         (rs6000_register_name): Return names for the "vX" aliases.
10443         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10444         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10445         aliases.  Call default_register_reggroup_p for all other
10446         pseudo-registers.
10447         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10448         New functions.
10449         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10450         Handle "vX" aliases.
10451         (v_alias_pseudo_register_collect): New function.
10452         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10453         (rs6000_gdbarch_init): Initialize "vX" aliases as
10454         pseudo-registers.  Restore registration of
10455         rs6000_pseudo_register_reggroup_p with
10456         set_tdesc_pseudo_register_reggroup_p.
10457
10458 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10459
10460         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10461         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10462         set_gdbarch_num_pseudo_regs.
10463
10464 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10465
10466         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10467         Remove arg prefixname, add do_set and do_show.
10468         Add member functions set_list and show_list.
10469         * cli/cli-style.c (class cli_style_option): Update accordingly.
10470         (style_set_list): Move to file scope.
10471         (style_show_list): Likewise.
10472         (set_style): Call help_list.
10473         (show_style): Call cmd_show_list.
10474         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10475         Update to use the new macro.
10476
10477 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10478
10479         * ada-lang.c (_initialize_ada_language): Expand the help text
10480         for the "catch exception" command.
10481
10482 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10483
10484         * symtab.c (matching_obj_sections): Initialize obj,
10485         declare it closer to its usage.
10486
10487 2019-01-10  Tom Tromey  <tom@tromey.com>
10488
10489         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10490         (basic_inf_threads_range): Remove.
10491         (inf_threads_range, inf_non_exited_threads_range)
10492         (safe_inf_threads_range): Use next_adapter.
10493
10494 2019-01-10  Keith Seitz  <keiths@redhat.com>
10495
10496         PR gdb/23712
10497         PR symtab/23010
10498         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10499         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10500
10501 2019-01-10  Keith Seitz  <keiths@redhat.com>
10502
10503         PR gdb/23712
10504         PR symtab/23010
10505         * dictionary.c (pending_to_vector): Remove.
10506         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10507         Remove _1 suffix, replacing functions of the same name.  Update
10508         all callers.
10509         (dict_create_hashed, dict_create_hashed_expandable)
10510         (dict_create_linear, dict_create_linear_expandable, dict_free)
10511         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10512         Make functions static.
10513
10514 2019-01-10  Keith Seitz  <keiths@redhat.com>
10515
10516         PR gdb/23712
10517         PR symtab/23010
10518         * dictionary.h (struct dictionary): Replace declaration with
10519         multidictionary.
10520         (dict_create_hashed, dict_create_hashed_expandable)
10521         (dict_create_linear, dict_create_linear_expandable)
10522         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10523         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10524         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10525         taking multidictionary argument.
10526         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10527         * block.h (struct block) <dict>: Change to multidictionary
10528         and rename `multidict'.
10529         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10530         symmisc.c: Update all dictionary references to multidictionary.
10531
10532 2019-01-10  Keith Seitz  <keiths@redhat.com>
10533
10534         PR gdb/23712
10535         PR symtab/23010
10536         * dictionary.c: Include unordered_map.
10537         (pending_to_vector): New function.
10538         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10539         Rewrite the non-"_1" functions to take vector instead
10540         of linked list.
10541         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10542         "new" _1 versions of the same name.
10543         (multidictionary): Define.
10544         (std::hash<enum language): New definition.
10545         (collate_pending_symbols_by_language, mdict_create_hashed)
10546         (mdict_create_hashed_expandable, mdict_create_linear)
10547         (mdict_create_linear_expandable, mdict_free)
10548         (find_language_dictionary, create_new_language_dictionary)
10549         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10550         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10551         (mdict_size, mdict_empty): New functions.
10552         * dictionary.h (mdict_iterator): Define.
10553
10554 2019-01-10  Pedro Alves  <palves@redhat.com>
10555
10556         * breakpoint.c (read_uploaded_action)
10557         (create_tracepoint_from_upload): Adjust to use
10558         gdb::unique_xmalloc_ptr.
10559         * ctf.c (ctf_write_uploaded_tp):
10560         (SET_ARRAY_FIELD): Use emplace_back.
10561         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10562         * tracefile-tfile.c (tfile_write_uploaded_tp):
10563         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10564         gdb::unique_xmalloc_ptr.
10565         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10566         at_string, cond_string, cmd_strings>: Replace char pointers
10567         with gdb::unique_xmalloc_ptr.
10568
10569 2019-01-10  Pedro Alves  <palves@redhat.com>
10570
10571         * solib-target.c (library_list_start_library): Don't xstrdup name.
10572
10573 2019-01-10  Pedro Alves  <palves@redhat.com>
10574
10575         * mdebugread.c (parse_partial_symbols): Use
10576         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10577
10578 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10579
10580         * linux-fork.c (scoped_switch_fork_info)
10581         <~scoped_switch_fork_info>: Fix incorrect variable name.
10582
10583 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10584
10585         * linux-fork.c (scoped_switch_fork_info)
10586         <scoped_switch_fork_info>: Make explicit.
10587         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10588
10589 2019-01-10  Tom Tromey  <tom@tromey.com>
10590
10591         * objfiles.h (objfile::reset_psymtabs): Update.
10592         * objfiles.c (objfile::objfile): Update.
10593         * psymtab.h (psymtab_storage::obstack): Update.
10594         (psymtab_storage::m_obstack): Use gdb::optional.
10595         (class psymtab_storage): Update comment.  Remove objfile
10596         parameter.
10597         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10598
10599 2019-01-10  Tom Tromey  <tom@tromey.com>
10600
10601         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10602         <free_psymtabs>: Now private.
10603         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10604         (allocate_psymtab): Use new method.
10605
10606 2019-01-10  Tom Tromey  <tom@tromey.com>
10607
10608         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10609         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10610         * mdebugread.c (parse_partial_symbols): Use
10611         allocate_dependencies.
10612         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10613         allocate_dependencies.
10614         (process_psymtab_comp_unit_reader)
10615         (build_type_psymtab_dependencies): Likewise.
10616         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10617
10618 2019-01-10  Tom Tromey  <tom@tromey.com>
10619
10620         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10621         PSYMBOL_SET_LANGUAGE.
10622         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10623
10624 2019-01-10  Tom Tromey  <tom@tromey.com>
10625
10626         * psymtab.h (psymtab_storage::obstack): New method.
10627         <m_obstack>: Rename from obstack; now private.
10628         * psymtab.c (psymtab_storage): Update.
10629         * dwarf2read.c (create_addrmap_from_index)
10630         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10631         Update.
10632
10633 2019-01-10  Tom Tromey  <tom@tromey.com>
10634
10635         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10636         * objfiles.h (objfile::reset_psymtabs): New method.
10637
10638 2019-01-10  Tom Tromey  <tom@tromey.com>
10639
10640         * symmisc.c (print_symbol_bcache_statistics): Update.
10641         (print_objfile_statistics): Update.
10642         * symfile.c (reread_symbols): Update.
10643         * psymtab.h (class psymtab_storage): New.
10644         * psymtab.c (psymtab_storage): New constructor.
10645         (~psymtab_storage): New destructor.
10646         (require_partial_symbols): Update.
10647         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10648         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10649         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10650         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10651         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10652         (start_psymtab_common, end_psymtab_common)
10653         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10654         (allocate_psymtab): Update.
10655         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10656         Update.
10657         (dump_psymtab_addrmap, maintenance_print_psymbols)
10658         (maintenance_check_psymtabs): Update.
10659         (class objfile_psymtabs): Move to objfiles.h.
10660         * psympriv.h (discard_psymtab): Now inline.
10661         (psymtab_discarder::psymtab_discarder): Update.
10662         (psymtab_discarder::~psymtab_discarder): Update.
10663         (ALL_OBJFILE_PSYMTABS): Rewrite.
10664         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10665         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10666         Remove fields.
10667         <partial_symtabs>: New field.
10668         (class objfile_psymtabs): Move from psymtab.h.  Update.
10669         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10670         psymbol_cache.
10671         (objfile::~objfile): Don't destroy psymbol_cache.
10672         * mdebugread.c (parse_partial_symbols): Update.
10673         * dwarf2read.c (create_addrmap_from_index)
10674         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10675         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10676         (add_partial_subprogram, dwarf2_ranges_read): Update.
10677         * dwarf-index-write.c (write_address_map)
10678         (write_one_signatured_type, recursively_write_psymbols)
10679         (class debug_names, class debug_names, write_psymtabs_to_index):
10680         Update.
10681
10682 2019-01-10  Tom Tromey  <tom@tromey.com>
10683
10684         * symtab.h (SYMBOL_SET_NAMES): Update.
10685         (symbol_set_names): Update.
10686         (MSYMBOL_SET_NAMES): Update.
10687         * symtab.c (symbol_set_names): Change argument to be an
10688         objfile_per_bfd_storage.
10689         * psymtab.c (add_psymbol_to_bcache): Update.
10690         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10691
10692 2019-01-10  Tom Tromey  <tom@tromey.com>
10693
10694         * symtab.c (create_demangled_names_hash): Change argument to be an
10695         objfile_per_bfd_storage.
10696         (symbol_set_names): Update.
10697
10698 2019-01-10  Tom Tromey  <tom@tromey.com>
10699
10700         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10701         init_psymbol_list.
10702         * psymtab.c (init_psymbol_list): Do nothing if already called.
10703         * psympriv.h (init_psymbol_list): Add comment.
10704         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10705         init_psymbol_list.
10706         * dbxread.c (dbx_symfile_read): Unconditionally call
10707         init_psymbol_list.
10708
10709 2019-01-10  Tom Tromey  <tom@tromey.com>
10710
10711         * xcoffread.c (scan_xcoff_symtab): Update.
10712         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10713         "where".
10714         * mdebugread.c (parse_partial_symbols)
10715         (handle_psymbol_enumerators): Update.
10716         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10717         * dbxread.c (read_dbx_symtab): Update.
10718         * psympriv.h (psymbol_placement): New enum.
10719         (add_psymbol_to_list): Update.
10720
10721 2019-01-10  Tom Tromey  <tom@tromey.com>
10722
10723         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10724         static_psymbols parameters.
10725         (scan_xcoff_symtab): Update.
10726         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10727         static_psymbols parameters.
10728         * psympriv.h (start_psymtab_common): Update.
10729         * mdebugread.c (parse_partial_symbols): Update.
10730         * dwarf2read.c (create_partial_symtab): Update.
10731         * dbxread.c (read_dbx_symtab): Update.
10732         (start_psymtab): Remove global_psymbols and static_psymbols
10733         parameters.
10734
10735 2019-01-10  Tom Tromey  <tom@tromey.com>
10736
10737         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10738         * psymtab.c (allocate_psymtab): Add comment.
10739         * psympriv.h (allocate_psymtab): Add comment.
10740         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10741         initializations.
10742         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10743
10744 2019-01-10  Tom Tromey  <tom@tromey.com>
10745
10746         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10747         Don't declare.
10748         * mipsread.c: Include mdebugread.h.
10749         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10750         Declare.
10751         * elfread.c: Include mdebugread.h.
10752
10753 2019-01-09  Tom Tromey  <tom@tromey.com>
10754
10755         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10756         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10757         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10758         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10759         (psym_lookup_symbol, psym_find_last_source_symtab)
10760         (psym_forget_cached_source_info, psym_print_stats)
10761         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10762         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10763         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10764         (psym_find_compunit_symtab_by_address)
10765         (maintenance_print_psymbols, maintenance_info_psymtabs)
10766         (maintenance_check_psymtabs): Use ranged for.
10767         * psymtab.h (class objfile_psymtabs): New.
10768         (require_partial_symbols): Return objfile_psymtabs.
10769         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10770
10771 2019-01-09  Tom Tromey  <tom@tromey.com>
10772
10773         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10774         (find_pc_mapped_section, list_overlays_command)
10775         (map_overlay_command, unmap_overlay_command)
10776         (simple_overlay_update): Use all_objfiles.
10777         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10778         * printcmd.c (info_symbol_command): Use all_objfiles.
10779         * objfiles.h (ALL_OBJSECTIONS): Remove.
10780         * maint.c (maintenance_translate_address): Use all_objfiles.
10781         * gcore.c (gcore_create_callback): Use all_objfiles.
10782         (objfile_find_memory_regions): Likewise.
10783
10784 2019-01-09  Tom Tromey  <tom@tromey.com>
10785
10786         * symtab.c (find_line_symtab, info_sources_command)
10787         (make_source_files_completion_list): Use objfile_compunits.
10788         * source.c (select_source_symtab): Use objfile_compunits.
10789         * objfiles.h (struct objfile): Update comment.
10790         (ALL_OBJFILES): Remove.
10791         (ALL_FILETABS): Remove.
10792         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10793         objfile_compunits.
10794
10795 2019-01-09  Tom Tromey  <tom@tromey.com>
10796
10797         * symmisc.c (print_objfile_statistics, dump_objfile)
10798         (maintenance_print_symbols): Use compunit_filetabs.
10799         * source.c (forget_cached_source_info_for_objfile): Use
10800         compunit_filetabs.
10801         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10802         (ALL_FILETABS): Use compunit_filetabs.
10803         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10804         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10805
10806 2019-01-09  Tom Tromey  <tom@tromey.com>
10807
10808         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10809         (compunit_filetabs): New.
10810         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10811         compunit_filetabs.
10812         (info_sources_command, make_source_files_completion_list): Remove
10813         declaration.
10814         * symmisc.c (print_objfile_statistics, dump_objfile)
10815         (maintenance_print_symbols): Remove declaration.
10816         (maintenance_info_symtabs): Use compunit_filetabs.
10817         (maintenance_info_line_tables): Likewise.
10818         * source.c (select_source_symtab): Change local variable name.
10819         (forget_cached_source_info_for_objfile): Remove declaration.
10820         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10821         * objfiles.c (objfile_relocate1): Remove declaration.
10822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10823         declaration.
10824         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10825         * coffread.c (coff_symtab_read): Remove declaration.
10826         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10827         compunit_filetabs.
10828
10829 2019-01-09  Tom Tromey  <tom@tromey.com>
10830
10831         * symtab.c (lookup_objfile_from_block)
10832         (find_pc_sect_compunit_symtab, search_symbols)
10833         (default_collect_symbol_completion_matches_break_on): Use
10834         objfile_compunits.
10835         * objfiles.h (ALL_COMPUNITS): Remove.
10836         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10837         * cp-support.c (add_symbol_overload_list_qualified): Use
10838         objfile_compunits.
10839         * ada-lang.c (ada_collect_symbol_completion_matches)
10840         (ada_add_global_exceptions): Use objfile_compunits.
10841
10842 2019-01-09  Tom Tromey  <tom@tromey.com>
10843
10844         * source.c (select_source_symtab)
10845         (forget_cached_source_info_for_objfile): Remove declaration.
10846         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10847         declaration.
10848         * maint.c (count_symtabs_and_blocks): Remove declaration.
10849         * cp-support.c (add_symbol_overload_list_qualified): Remove
10850         declaration.
10851         * coffread.c (coff_symtab_read): Remove declaration.
10852         * symtab.c (lookup_symbol_in_objfile_symtabs)
10853         (basic_lookup_transparent_type_1): Use objfile_compunits.
10854         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10855         (info_sources_command, search_symbols)
10856         (default_collect_symbol_completion_matches_break_on)
10857         (make_source_files_completion_list): Remove declaration.
10858         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10859         (ada_collect_symbol_completion_matches)
10860         (ada_add_global_exceptions): Remove declaration.
10861         * linespec.c (iterate_over_all_matching_symtabs): Use
10862         objfile_compunits.
10863         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10864         (class objfile_compunits): New.
10865         (ALL_COMPUNITS): Use objfile_compunits.
10866         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10867         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10868         objfile_compunits.
10869         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10870
10871 2019-01-09  Tom Tromey  <tom@tromey.com>
10872
10873         * symtab.c (search_symbols)
10874         (default_collect_symbol_completion_matches_break_on): Use
10875         objfile_msymbols.
10876         * ada-lang.c (ada_lookup_simple_minsym)
10877         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10878         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10879         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10880         objfile_msymbols.
10881         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10882         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10883         * objc-lang.c (find_methods): Use objfile_msymbols.
10884         (info_selectors_command, info_classes_command): Likewise.
10885         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10886         * objfiles.h (class objfile_msymbols): New.
10887         (ALL_OBJFILE_MSYMBOLS): Remove.
10888         (ALL_MSYMBOLS): Remove.
10889
10890 2019-01-09  Tom Tromey  <tom@tromey.com>
10891
10892         * common/next-iterator.h (next_adapter): Add Iterator template
10893         parameter.
10894         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10895         (class all_objfiles_safe): New.
10896         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10897         * objfiles.c (put_objfile_before): Update comment.
10898         (add_separate_debug_objfile): Likewise.
10899         (free_all_objfiles): Use all_objfiles_safe.
10900         (objfile_purge_solibs): Likewise.
10901
10902 2019-01-09  Tom Tromey  <tom@tromey.com>
10903
10904         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10905         (expand_symtab_containing_pc, lookup_static_symbol)
10906         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10907         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10908         all_objfiles.
10909         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10910         * breakpoint.c (create_overlay_event_breakpoint)
10911         (create_longjmp_master_breakpoint)
10912         (create_std_terminate_master_breakpoint)
10913         (create_exception_master_breakpoint): Use all_objfiles.
10914         * linux-thread-db.c (try_thread_db_load_from_pdir)
10915         (has_libpthread): Use all_objfiles.
10916         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10917         * linespec.c (iterate_over_all_matching_symtabs)
10918         (search_minsyms_for_name): Use all_objfiles.
10919         * maint.c (maintenance_info_sections): Use all_objfiles.
10920         * main.c (captured_main_1): Use all_objfiles.
10921         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10922         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10923         * guile/scm-pretty-print.c
10924         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10925         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10926         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10927         (maintenance_print_msymbols): Use all_objfiles.
10928         * source.c (select_source_symtab): Use all_objfiles.
10929         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10930         * symfile.c (remove_symbol_file_command)
10931         (expand_symtabs_matching, map_symbol_filenames): Use
10932         all_objfiles.
10933         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10934         all_objfiles.
10935         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10936         * objc-lang.c (find_methods): Use all_objfiles.
10937         * objfiles.c (have_partial_symbols, have_full_symbols)
10938         (have_minimal_symbols, qsort_cmp)
10939         (default_iterate_over_objfiles_in_search_order): Use
10940         all_objfiles.
10941         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10942         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10943         (maintenance_check_psymtabs): Use all_objfiles.
10944         (ALL_PSYMTABS): Remove.
10945         * compile/compile-object-run.c (do_module_cleanup): Use
10946         all_objfiles.
10947         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10948         * cp-support.c (add_symbol_overload_list_qualified): Use
10949         all_objfiles.
10950         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10951         Use all_objfiles.
10952         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10953         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10954         all_objfiles.
10955         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10956         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10957         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10958         Uses all_objfiles.
10959         * solib.c (solib_read_symbols): Use all_objfiles
10960
10961 2019-01-09  Tom Tromey  <tom@tromey.com>
10962
10963         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10964         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10965         all_objfiles.
10966         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10967         * symmisc.c (print_symbol_bcache_statistics)
10968         (print_objfile_statistics, maintenance_print_objfiles)
10969         (maintenance_info_symtabs, maintenance_check_symtabs)
10970         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10971         all_objfiles.
10972         * source.c (forget_cached_source_info): Use all_objfiles.
10973         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10974         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10975         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10976         * objfiles.c (update_section_map): Use all_objfiles.
10977         (shared_objfile_contains_address_p): Likewise.
10978         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10979         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10980
10981 2019-01-09  Tom Tromey  <tom@tromey.com>
10982
10983         * common/next-iterator.h: New file.
10984         * objfiles.h (class all_objfiles): New.
10985         (struct objfile_iterator): New.
10986
10987 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10988
10989         * NEWS: Move the description of the changed "frame", "select-frame",
10990          and "info frame" commands to the Changed commands section.
10991
10992 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10993
10994         * gdbtypes.c (check_stub_method_group): Remove handling of old
10995         mangling schemes.
10996         * linespec.c (find_methods): Likewise.
10997         * stabsread.c (read_member_functions): Likewise.
10998         * valops.c (search_struct_method): Likewise.
10999         (value_struct_elt_for_reference): Likewise.
11000         * NEWS: Mention this change.
11001
11002 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11003
11004         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11005         print_source_lines.
11006         * source.c (print_source_lines_base): Update line number check.
11007         (print_source_lines): New function.
11008         (source_lines_range::source_lines_range): New function.
11009         * source.h (class source_lines_range): New class.
11010         (print_source_lines): New declaration.
11011
11012 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11013
11014         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11015
11016 2019-01-08  Tom Tromey  <tom@tromey.com>
11017             Simon Marchi  <simon.marchi@ericsson.com>
11018
11019         PR gdb/24060
11020         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11021         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11022         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11023         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11024         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11025         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11026
11027 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11028
11029         * source.c (select_source_symtab): Move header comment to
11030         declaration in source.h.
11031         (forget_cached_source_info_for_objfile): Likewise.
11032         (forget_cached_source_info): Likewise.
11033         (identify_source_line): Likewise.
11034         * source.h (identify_source_line): Move declaration from symtab.h
11035         and add comment from source.c
11036         (print_source_lines): Likewise.
11037         (forget_cached_source_info_for_objfile): Likewise.
11038         (forget_cached_source_info): Likewise.
11039         (select_source_symtab): Likewise.
11040         (enum print_source_lines_flag): Move definition from symtab.h.
11041         * symtab.h (identify_source_line): Move declaration to source.h.
11042         (print_source_lines): Likewise.
11043         (forget_cached_source_info_for_objfile): Likewise.
11044         (forget_cached_source_info): Likewise.
11045         (select_source_symtab): Likewise.
11046         (enum print_source_lines_flag): Move definition to source.h.
11047         * tui/tui-hooks.c: Add 'source.h' include.
11048
11049 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11050
11051         * source.c (print_source_lines_base): Handle requests to print
11052         reverse line number sequences, and guard against empty lines
11053         string.
11054
11055 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11056
11057         * source.c (print_source_lines_base): Fix skip of '\r' if next
11058         character is '\n'.
11059
11060 2019-01-06  Tom Tromey  <tom@tromey.com>
11061
11062         * c-exp.y (struct c_parse_state) <macro_original_text,
11063         expansion_obstack>: New member.
11064         (macro_original_text, expansion_obstack): Remove globals.
11065         (scan_macro_expansion, scanning_macro_expansion)
11066         (finished_macro_expansion): Update.
11067         (scan_macro_cleanup): Remove.
11068         (yylex, c_parse): Update.
11069
11070 2019-01-06  Tom Tromey  <tom@tromey.com>
11071
11072         * c-exp.y (struct c_parse_state) <strings>: New member.
11073         (operator_stoken): Update.
11074
11075 2019-01-06  Tom Tromey  <tom@tromey.com>
11076
11077         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11078         (union type_stack_elt) <typelist_val>: Now a pointer to
11079         std::vector.
11080         (type_stack_cleanup): Don't declare.
11081         (push_typelist): Update.
11082         * parse.c (pop_typelist): Return a std::vector.
11083         (push_typelist): Take a std::vector.
11084         (follow_types): Update.  Do not free args.
11085         (type_stack_cleanup): Remove.
11086         * c-exp.y (struct c_parse_state): New.
11087         (cpstate): New global.
11088         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11089         (nonempty_typelist): Update.
11090         (func_mod): Create a new vector.
11091         (c_parse): Create a c_parse_state.
11092         (check_parameter_typelist): Do not delete params.
11093         (function_method): Update.  Do not delete type_list.
11094
11095 2019-01-06  Tom Tromey  <tom@tromey.com>
11096
11097         PR gdb/28155:
11098         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11099         check_typedef.
11100         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11101         (print_return_value): Likewise.
11102
11103 2019-01-05  Tom Tromey  <tom@tromey.com>
11104
11105         * contrib/cleanup_check.py: Remove.
11106         * contrib/gcc-with-excheck: Remove.
11107         * contrib/exsummary.py: Remove.
11108         * contrib/excheck.py: Remove.
11109
11110 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11111
11112         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11113         NULL. Initialize tpprev to NULL instead of assigning it
11114         to NULL on the next statement.
11115         * windows-nat.c (windows_delete_thread): Remove check for
11116         main_thread_id before printing thread exit notifications.
11117         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11118         Remove thread ID check against main_thread_id.
11119         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11120         windows_delete_thread.
11121         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11122
11123 2019-01-04  Tom Tromey  <tom@tromey.com>
11124
11125         * compile/compile.c (_initialize_compile): Use upper case for
11126         metasyntactic variables.
11127         * symmisc.c (_initialize_symmisc): Use upper case for
11128         metasyntactic variables.
11129         * psymtab.c (_initialize_psymtab): Use upper case for
11130         metasyntactic variables.
11131         * demangle.c (demangle_command): Use upper case for metasyntactic
11132         variables.
11133         (_initialize_demangler): Likewise.
11134         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11135         variables.
11136
11137 2019-01-03  Tom Tromey  <tom@tromey.com>
11138
11139         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11140
11141 2019-01-03  Tom Tromey  <tom@tromey.com>
11142
11143         * python/py-symtab.c (salpy_str): Update.
11144         (struct salpy_sal_object) <symtab>: Now a PyObject.
11145         (salpy_dealloc): Update.
11146         (del_objfile_sal): Use gdbpy_ref.
11147
11148 2019-01-03  Tom Tromey  <tom@tromey.com>
11149
11150         * python/py-type.c (convert_field): Use new_reference.  Return
11151         gdbpy_ref.
11152         (make_fielditem): Return gdbpy_ref.
11153         (typy_fields): Update.
11154         (typy_getitem): Update.
11155         (field_name): Return gdbpy_ref.  Use new_reference.
11156         (typy_iterator_iternext): Update.
11157
11158 2019-01-03  Tom Tromey  <tom@tromey.com>
11159
11160         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11161
11162 2019-01-03  Tom Tromey  <tom@tromey.com>
11163
11164         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11165         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11166         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11167         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11168         (pspy_set_type_printers): Likewise.
11169         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11170         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11171         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11172         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11173         (objfpy_set_type_printers): Likewise.
11174
11175 2019-01-03  Tom Tromey  <tom@tromey.com>
11176
11177         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11178         (gdbpy_print_stack): Use gdbpy_err_fetch.
11179         * python/python-internal.h (class gdbpy_err_fetch): New class.
11180         (class gdbpy_enter) <m_error_type, m_error_value,
11181         m_error_traceback>: Remove.
11182         <m_error>: New member.
11183         (gdbpy_exception_to_string): Don't declare.
11184         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11185         * python/py-value.c (convert_value_from_python): Use
11186         gdbpy_err_fetch.
11187         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11188         gdbpy_exception_to_string.
11189         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11190         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11191         gdbpy_err_fetch.
11192
11193 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11194
11195         * linux-nat.c (delete_lwp_cleanup): Delete.
11196         (struct lwp_deleter): New struct.
11197         (lwp_info_up): New typedef.
11198         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11199         lwp_info_up.
11200
11201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11202
11203         * linux-fork.c (class scoped_switch_fork_info): New class.
11204         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11205
11206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11207
11208         * valops.c (find_overload_match): Remove use of null_cleanup, and
11209         calls to do_cleanups.
11210
11211 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11212
11213         * compile/compile-cplus-types.c
11214         (compile_cplus_instance::decl_name): Handle changes to
11215         cp_func_name.
11216         * cp-support.c (cp_func_name): Update header comment, update
11217         return type.
11218         * cp-support.h (cp_func_name): Update return type in declaration.
11219         * valops.c (find_overload_match): Move temp_func local to top
11220         level of function and change its type.  Use temp_func to hold and
11221         delete temporary string obtained from cp_func_name.
11222
11223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11224
11225         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11226         gdb::char_vector, remove cleanup, and update uses of `msg`.
11227
11228 2019-01-03  Jim Wilson  <jimw@sifive.com>
11229
11230         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11231
11232 2019-01-02  Tom Tromey  <tom@tromey.com>
11233
11234         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11235         (tdesc_parse_xml): Remove cleanups.
11236         * target-descriptions.h (make_cleanup_free_target_description):
11237         Don't declare.
11238         (target_desc_deleter): New struct.
11239         (target_desc_up): New typedef.
11240         * target-descriptions.c (target_desc_deleter::operator()): Rename
11241         from free_target_description.
11242         (make_cleanup_free_target_description): Remove.
11243
11244 2019-01-02  Tom Tromey  <tom@tromey.com>
11245
11246         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11247         constructor, destructor.
11248         (linespec_parser): Remove typedef.
11249         (~linespec_parser): Rename from linespec_parser_delete.
11250         (linespec_lex_to_end, linespec_complete_label)
11251         (linespec_complete): Update.
11252         (decode_line_full): Remove cleanups.
11253         (decode_line_1): Update.
11254
11255 2019-01-02  Tom Tromey  <tom@tromey.com>
11256
11257         * python/python-internal.h (inferior_to_inferior_object): Change
11258         return type.
11259         * python/py-exitedevent.c (create_exited_event_object): Update.
11260         * python/py-inferior.c (inferior_to_inferior_object): Return
11261         gdbpy_ref.
11262         (python_new_inferior, python_inferior_deleted)
11263         (thread_to_thread_object, delete_thread_object)
11264         (build_inferior_list, gdbpy_selected_inferior): Update.
11265         * python/py-infthread.c (create_thread_object): Update.  Also fail
11266         if inferior_to_inferior_object fails.
11267
11268 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11269
11270         * inferior.h (class inferior) <displaced_step_state>: New field.
11271         * infrun.h (struct displaced_step_state): Move here from
11272         infrun.c.  Initialize fields, add constructor.
11273         <inf>: Remove field.
11274         <reset>: New method.
11275         * infrun.c (struct displaced_step_inferior_state): Move to
11276         infrun.h.
11277         (displaced_step_inferior_states): Remove.
11278         (get_displaced_stepping_state): Adust.
11279         (displaced_step_in_progress_any_inferior): Adjust.
11280         (displaced_step_in_progress_thread): Adjust.
11281         (displaced_step_in_progress): Adjust.
11282         (add_displaced_stepping_state): Remove.
11283         (get_displaced_step_closure_by_addr): Adjust.
11284         (remove_displaced_stepping_state): Remove.
11285         (infrun_inferior_exit): Call displaced_step_state.reset.
11286         (use_displaced_stepping): Don't check for NULL.
11287         (displaced_step_prepare_throw): Call
11288         get_displaced_stepping_state.
11289         (displaced_step_fixup): Don't check for NULL.
11290         (prepare_for_detach): Don't check for NULL.
11291
11292 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11293
11294         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11295          in case of call that did not complete.
11296
11297 2019-01-02  Andrey Utkin  <autkin@undo.io>
11298
11299         * symfile.c (find_separate_debug_file): Fix search of debug files for
11300         remote debuggee.
11301
11302 2019-01-02  Tom Tromey  <tom@tromey.com>
11303
11304         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11305         indentation.
11306         * python/py-frame.c (frapy_older): Remove cast.
11307         (frapy_newer): Likewise.
11308         * python/py-breakpoint.c (local_setattro): Remove cast.
11309         * python/py-arch.c (archpy_name): Remove local variable.
11310         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11311
11312 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11313
11314         * unittests/basic_string_view/element_access/char/empty.cc:
11315         Fix year range in copyright header.
11316
11317 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11318
11319         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11320         Delete.
11321         <operator==>: Update with for removed field.
11322         <hash>: Likewise.
11323         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11324         <isa_features>: ...this.
11325         <abi_features>: New field.
11326         (riscv_isa_flen): Update comment.
11327         (riscv_abi_xlen): New declaration.
11328         (riscv_abi_flen): New declaration.
11329         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11330         isa_features.
11331         (riscv_abi_xlen): New function.
11332         (riscv_isa_flen): Update to get answer from isa_features.
11333         (riscv_abi_flen): New function.
11334         (riscv_has_fp_abi): Update to get answer from abi_features.
11335         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11336         xlen and flen.
11337         (riscv_call_info) <xlen, flen>: Update comment.
11338         (riscv_call_arg_struct): Remove invalid assertions
11339         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11340         is removed.
11341         (riscv_gdbarch_init): Gather isa features and abi features
11342         separately, ensure both match on the gdbarch when reusing an old
11343         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11344         a target with 64-bit float hardware.
11345
11346 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11347
11348         * source.c (search_command_helper): Stop reverse search
11349         when line 1 has been searched.
11350
11351 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11352
11353         * record-full.c (record_full_base_target::close): Rewrite
11354         record_full_core_buf_list free logic.
11355
11356 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11357
11358         * break-catch-syscall.c (print_one_catch_syscall): xfree
11359         the last text.
11360
11361 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11362
11363         * top.c (print_gdb_version): Update Copyright year in version
11364         message.
11365
11366 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11367
11368         Update copyright year range in all GDB files.
11369
11370 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11371
11372         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11373
11374 For older changes see ChangeLog-2018.
11375 \f
11376 Local Variables:
11377 mode: change-log
11378 left-margin: 8
11379 fill-column: 74
11380 version-control: never
11381 coding: utf-8
11382 End:
11383