gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <update_exec_info>: Declare.
   5         (tui_update_exec_info): Don't declare.
   6         * tui/tui-winsource.c (tui_update_source_window_as_is)
   7         (tui_source_window_base::refresh_all)
   8         (tui_update_all_breakpoint_info): Update.
   9         (tui_source_window_base::update_exec_info): Rename from
  10         tui_update_exec_info.
  11         * tui/tui-stack.c (tui_show_frame_info): Update.
  12
  13 2019-08-13  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.h (struct tui_source_window_base)
  16         <set_exec_info_content>: Declare.
  17         (tui_set_exec_info_content): Don't declare.
  18         * tui/tui-winsource.c
  19         (tui_source_window_base::set_exec_info_content): Rename from
  20         tui_set_exec_info_content.
  21         (tui_update_exec_info): Update.
  22
  23 2019-08-13  Tom Tromey  <tom@tromey.com>
  24
  25         * tui/tui-winsource.h (struct tui_source_window_base)
  26         <show_source_content>: Declare.
  27         (tui_show_source_content): Don't declare.
  28         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  29         (tui_source_window_base::show_source_content): Rename from
  30         tui_show_source_content.
  31         (tui_source_window_base::refresh_all): Update.
  32         * tui/tui-layout.c (show_source_disasm_command)
  33         (show_source_or_disasm_and_command): Update.
  34
  35 2019-08-13  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-winsource.c (tui_erase_source_content)
  38         (tui_show_source_content, tui_source_window_base::refresh_all):
  39         Update.
  40         * tui/tui-wingeneral.h
  41         (tui_check_and_display_highlight_if_needed): Don't declare.
  42         * tui/tui-wingeneral.c
  43         (tui_win_info::check_and_display_highlight_if_needed): Rename from
  44         check_and_display_highlight_if_needed.
  45         * tui/tui-win.c (tui_rehighlight_all)
  46         (tui_win_info::make_visible_with_new_height): Update.
  47         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  48         (tui_data_window::erase_data_content)
  49         (tui_data_window::display_all_data): Update.
  50         * tui/tui-data.h (struct tui_win_info)
  51         <check_and_display_highlight_if_needed>: Declare.
  52
  53 2019-08-13  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-win.c (tui_resize_all): Call
  56         tui_delete_invisible_windows.
  57         * tui/tui-layout.c (show_layout): Call
  58         tui_delete_invisible_windows.
  59         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
  60         * tui/tui-data.c (tui_delete_invisible_windows): New function.
  61
  62 2019-08-13  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
  65         tui_add_win_to_layout.
  66
  67 2019-08-13  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-layout.h (tui_default_win_height): Don't declare.
  70         * tui/tui-layout.c (tui_default_win_height): Now static.
  71
  72 2019-08-13  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-layout.c (show_layout): Unify all layout cases into a
  75         single switch.
  76         (show_source_disasm_command, show_source_or_disasm_and_command):
  77         Don't check current layout.
  78
  79 2019-08-13  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-wingeneral.c (make_all_visible): Remove.
  82         (tui_make_all_invisible): Simplify.
  83         * tui/tui-layout.c (tui_make_all_invisible): Move from
  84         tui-wingeneral.c; simplify.
  85         (show_layout): Hoist call to tui_make_all_invisible.
  86         (show_data): Don't call tui_make_all_invisible.
  87
  88 2019-08-13  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
  91         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
  92
  93 2019-08-13  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
  96         tui-data.c.
  97         (show_source_disasm_command, show_data)
  98         (show_source_or_disasm_and_command): Don't use
  99         tui_set_current_layout_to.
 100         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 101         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 102         tui-layout.c.
 103         (tui_set_current_layout_to): Remove.
 104
 105 2019-08-13  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-layout.c (tui_set_layout): Update.
 108         * tui/tui-data.h (struct tui_layout_def): Remove.
 109         (tui_layout_def): Don't declare.
 110         * tui/tui-data.c (layout_def): Remove.
 111         (tui_layout_def): Remove.
 112
 113 2019-08-13  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-winsource.h (struct tui_source_window_base)
 116         <clear_detail>: No longer "override".
 117         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 118         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 119         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 120         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 121         Remove.
 122         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 123
 124 2019-08-13  Tom Tromey  <tromey@adacore.com>
 125
 126         * tracepoint.c: Don't include readline.h or history.h.
 127
 128 2019-08-12  Tom Tromey  <tom@tromey.com>
 129
 130         * configure: Rebuild.
 131         * configure.ac: Check for readline 7.
 132         * NEWS: Mention readline 7 requirement.
 133         * README: Update.
 134
 135 2019-08-12  Tom Tromey  <tom@tromey.com>
 136
 137         * mingw-hdep.c (gdb_select): Remove readline hack.
 138
 139 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 140
 141         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 142         when the function fails.
 143
 144 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 145
 146         * s390-tdep.c (s390_type_align): New function.
 147         (s390_gdbarch_init): Set it as type_align gdbarch method.
 148
 149 2019-08-09  Tom de Vries  <tdevries@suse.de>
 150
 151         PR gdb/24591
 152         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 153         pc_low with relocation offset.
 154
 155 2019-08-07  Tom Tromey  <tromey@adacore.com>
 156
 157         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 158         (print_frame_args): Update.
 159         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 160         Update.
 161         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 162         * frame.h (struct frame_arg): Add initializers.
 163         <error>: Now a unique_xmalloc_ptr.
 164
 165 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 166
 167         * NEWS: Expand the Pointer Authentication entry.
 168         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 169         (aarch64_frame_unmask_lr): ... to this.
 170         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 171         Call aarch64_frame_unmask_lr.
 172         * frame.c (struct frame_info): Add "masked" variable.
 173         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 174         (fprint_frame): Check for masked pc.
 175         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 176         declarations.
 177         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 178         * stack.c (print_frame): Check for masked pc.
 179
 180 2019-08-06  Tom Tromey  <tom@tromey.com>
 181
 182         * stabsread.c (patch_block_stabs, read_one_struct_field)
 183         (read_enum_type): Use obstack_strndup.
 184         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 185         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 186         * dwarf2read.c (guess_full_die_structure_name)
 187         (anonymous_struct_prefix): Use obstack_strndup.
 188         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 189         * c-exp.y (yylex): Use obstack_strndup.
 190         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 191         (write_var_or_type): Use obstack_strndup.
 192
 193 2019-08-06  Tom Tromey  <tom@tromey.com>
 194
 195         * symfile.c (reread_symbols): Use obstack_strdup.
 196         * stabsread.c (read_type): Use obstack_strdup.
 197         * gdb_obstack.h (obstack_strdup): New overload.
 198         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 199         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 200         (dwarf2_canonicalize_name): Use obstack_strdup.
 201         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 202         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 203         Use obstack_strdup.
 204
 205 2019-08-06  Tom Tromey  <tom@tromey.com>
 206
 207         * gdb_obstack.h (obstack_strdup): Define.
 208         * gdb_obstack.c (obstack_strdup): Don't define.
 209
 210 2019-08-06  Tom Tromey  <tom@tromey.com>
 211
 212         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 213         obstack_strdup.
 214         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 215         obstack_strdup.
 216         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 217         * stabsread.c (common_block_start): Use obstack_strdup.
 218         * objfiles.c (set_objfile_main_name, objfile): Use
 219         obstack_strdup.
 220         * namespace.c (add_using_directive): Use obstack_strdup.
 221         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 222         * jit.c (finalize_symtab): Use obstack_strdup.
 223         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 224         (guess_partial_die_structure_name, partial_die_info::fixup)
 225         (dwarf2_name): Use obstack_strdup.
 226         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 227         obstack_strdup.
 228         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 229         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 230         obstack_strdup.
 231         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 232
 233 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 234
 235         * unittests/help-doc-selftests.c: New file.
 236         * Makefile.in: Add the new file.
 237
 238 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 239
 240         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 241         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 242         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 243         the trailing '.' is not output, and the first character is uppercased.
 244         (print_help_for_command): Update call to print_doc_line.
 245         (print_doc_of_command): Likewise.
 246         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 247         * cli/cli-option.c (append_indented_doc): Do not append newline.
 248         (build_help_option): Append newline after first appended_indented_doc
 249         only if a second call is done.
 250         (build_help): Append 2 new lines before each option, except the first
 251         one.
 252         * compile/compile.c (_initialize_compile): Add new lines after
 253         %OPTIONS%, when not at the end of the help.
 254         Change help doc or code
 255         producing the help doc to respect the invariants.
 256         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 257         Also removed the new line after 'Options:', as all other commands
 258         do not put an empty line between 'Options:' and the first option.
 259         * printcmd.c (_initialize_printcmd): Likewise.
 260         * stack.c (_initialize_stack): Likewise.
 261         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 262         incorrectly telling COMMAND is optional.
 263         * ada-lang.c (_initialize_ada_language): Change help doc or code
 264         producing the help doc to respect the invariants.
 265         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 266         * breakpoint.c (_initialize_breakpoint): Likewise.
 267         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 268         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 269         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 270         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 271         _initialize_cli_style): Likewise.
 272         * corelow.c (core_target_info): Likewise.
 273         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 274         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 275         * filesystem.c (_initialize_filesystem): Likewise.
 276         * frame.c (_initialize_frame): Likewise.
 277         * gnu-nat.c (add_task_commands): Likewise.
 278         * infcall.c (_initialize_infcall): Likewise.
 279         * infcmd.c (_initialize_infcmd): Likewise.
 280         * interps.c (_initialize_interpreter): Likewise.
 281         * language.c (_initialize_language): Likewise.
 282         * linux-fork.c (_initialize_linux_fork): Likewise.
 283         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 284         * maint.c (_initialize_maint_cmds): Likewise.
 285         * memattr.c (_initialize_mem): Likewise.
 286         * printcmd.c (_initialize_printcmd): Likewise.
 287         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 288         _RegEx): Likewise.
 289         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 290         * record-btrace.c (_initialize_record_btrace): Likewise.
 291         * record-full.c (_initialize_record_full): Likewise.
 292         * record.c (_initialize_record): Likewise.
 293         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 294         * regcache.c (_initialize_regcache): Likewise.
 295         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 296         _initialize_remote): Likewise.
 297         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 298         * serial.c (_initialize_serial): Likewise.
 299         * skip.c (_initialize_step_skip): Likewise.
 300         * source.c (_initialize_source): Likewise.
 301         * stack.c (_initialize_stack): Likewise.
 302         * symfile.c (_initialize_symfile): Likewise.
 303         * symtab.c (_initialize_symtab): Likewise.
 304         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 305         * top.c (init_main): Likewise.
 306         * tracefile-tfile.c (tfile_target_info): Likewise.
 307         * tracepoint.c (_initialize_tracepoint): Likewise.
 308         * tui/tui-win.c (_initialize_tui_win): Likewise.
 309         * utils.c (add_internal_problem_command): Likewise.
 310         * valprint.c (value_print_option_defs): Likewise.
 311
 312 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 313
 314         PR build/24886
 315         * configure.ac: Drop enable-libmcheck support.
 316         * configure, config.in: Rebuild.
 317         * libmcheck.m4: Remove.
 318         * acinclude.m4: Don't include it.
 319         * Makefile.in: Don't distribute it.
 320         * top.c (print_gdb_configuration): Don't mention it.
 321
 322 2019-08-06  Tom Tromey  <tom@tromey.com>
 323
 324         * utils.c (set_output_style): Sometimes pass stream to
 325         emit_style_escape.
 326         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 327         * record-btrace.c (btrace_insn_history): Update.
 328         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 329         method.
 330         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 331         Update initializers.
 332         <m_uiout>: New field.
 333         <m_di>: Move lower.
 334         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 335         Remove "uiout" parameter.
 336         (dump_insns): Update.
 337         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 338         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 339
 340 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 341
 342         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 343         (error_in_psymtab_expansion): Likewise.
 344         (lookup_symbol_via_quick_fns): Likewise.
 345         (basic_lookup_transparent_type_quick): Likewise.
 346         (basic_lookup_transparent_type_1): Likewise.
 347
 348 2019-08-06  Tom Tromey  <tromey@adacore.com>
 349
 350         * source.c (last_source_error): Now bool.
 351         (print_source_lines_base): Make "noprint" bool.  Only open
 352         source file when last_source_visited changes.
 353
 354 2019-08-06  Tom Tromey  <tromey@adacore.com>
 355
 356         * annotate.c (annotate_source_line): Use g_source_cache.
 357         * source-cache.c (source_cache::get_plain_source_lines): Change
 358         parameters.  Populate m_offset_cache.
 359         (source_cache::ensure): New method.
 360         (source_cache::get_line_charpos): New method.
 361         (extract_lines): Move lower.  Change parameters.
 362         (source_cache::get_source_lines): Move lower.
 363         * source-cache.h (class source_cache): Update comment.
 364         <get_line_charpos>: New method.
 365         <get_source_lines>: Update comment.
 366         <clear>: Clear m_offset_cache.
 367         <get_plain_source_lines>: Change parameters.
 368         <ensure>: New method
 369         <m_offset_cache>: New member.
 370         * source.c (forget_cached_source_info_for_objfile): Update.
 371         (info_source_command): Use g_source_cache.
 372         (find_source_lines, open_source_file_with_line_charpos): Remove.
 373         (print_source_lines_base, search_command_helper): Use g_source_cache.
 374         * source.h (open_source_file_with_line_charpos): Don't declare.
 375         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 376         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 377         Use g_source_cache.
 378
 379 2019-08-06  Tom Tromey  <tromey@adacore.com>
 380
 381         * source-cache.c (source_cache::get_plain_source_lines):
 382         Remove "first_line" and "last_line" parameters.
 383         (source_cache::get_source_lines): Cache plain text.
 384         * source-cache.h (class source_cache)
 385         <get_plain_source_lines>: Update.
 386
 387 2019-08-06  Tom Tromey  <tromey@adacore.com>
 388
 389         * source-cache.c (extract_lines): No longer a method.
 390         Changed type of parameter.  Include final newline.
 391         (selftests::extract_lines_test): New function.
 392         (_initialize_source_cache): Likewise.
 393         * source-cache.h (class source_cache)
 394         <extract_lines>: Don't declare.
 395
 396 2019-08-06  Tom Tromey  <tromey@adacore.com>
 397
 398         * breakpoint.c (init_breakpoint_sal): Update.
 399         (breakpoint): Update.
 400         * breakpoint.h (struct breakpoint) <filter>: Now a
 401         unique_xmalloc_ptr.
 402
 403 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 404
 405         * NEWS: Mention dictionary access on blocks.
 406         * python/py-block.c (blpy_getitem): New function.
 407         (block_object_as_mapping): New struct.
 408         (block_object_type): Use new struct for tp_as_mapping field.
 409
 410 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 411
 412         * objfiles.h (objfile): Add a comment describing partial symbols.
 413
 414 2019-08-05  Tom Tromey  <tromey@adacore.com>
 415
 416         * compile/compile.c (_initialize_compile): Use _(), not N_().
 417         * thread.c (_initialize_thread): Use _(), not N_().
 418         * stack.c (_initialize_stack): Use _(), not N_().
 419         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 420
 421 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 422
 423         * dwarf2read.c (struct dw2_symtab_iterator):
 424         <want_specific_block>: Remove.
 425         <block_index>: Change type to gdb::optional.
 426         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 427         change type of BLOCK_INDEX parameter to gdb::optional.
 428         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 429         (dw2_lookup_symbol): Don't pass argument for
 430         WANT_SPECIFIC_BLOCK.
 431         (dw2_expand_symtabs_for_function): Don't pass argument for
 432         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 433         (class dw2_debug_names_iterator)
 434         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 435         parameter, change BLOCK_INDEX type to gdb::optional.
 436         <m_want_specific_block>: Remove.
 437         <m_block_index>: Change type to gdb::optional.
 438         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 439         gdb::optional.  Re-write in function of gdb::optional.
 440         (dw2_debug_names_lookup_symbol): Don't pass argument for
 441         WANT_SPECIFIC_BLOCK.
 442         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 443         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 444         BLOCK_INDEX.
 445
 446 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 447
 448         * NEWS: Mention changes to "info sources" command.
 449
 450 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 451
 452         * symtab.c (filename_partial_match_opts): New struct type.
 453         (struct output_source_filename_data): New members
 454         regexp, c_regexp, partial_match.
 455         (output_source_filename): Use new members to decide to print file.
 456         (info_sources_option_defs): New variable.
 457         (make_info_sources_options_def_group, print_info_sources_header,
 458         info_sources_command_completer):
 459         New functions.
 460         (info_sources_command): Read new optional arguments.
 461         (_initialize_symtab): Update info sources help.
 462
 463 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 464
 465         * ada-lang.c (exception_support_info_v0): Renamed from...
 466         (default_exception_support_info): ... this.  Create new
 467         definition for v1.
 468         (ada_has_this_exception_support): Look up catch_handlers_sym.
 469         (ada_exception_support_info_sniffer): Try v0 after default.
 470
 471 2019-08-01  Tom Tromey  <tromey@adacore.com>
 472
 473         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 474         gdbarch.h.
 475
 476 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 477
 478         * s12z-tdep.c: Fix include path for s12z-opc.h.
 479
 480 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 481
 482         * NEWS: Require GNU make 3.82.
 483
 484 2019-07-16  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 487         declare.
 488
 489 2019-07-30  Tom Tromey  <tromey@adacore.com>
 490
 491         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 492
 493 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 494
 495         * printcmd.c (print_address_symbolic): Print negative offsets.
 496         (build_address_symbolic): Force signed arithmetic when computing
 497         offset.
 498
 499 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 500
 501         PR/24474: Add a function to lookup static variables.
 502         * NEWS: Mention this new function.
 503         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 504         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 505         * python/python.c (python_GdbMethods): Add new function.
 506
 507 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 508
 509         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 510         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 511         (objfpy_lookup_static_symbol): New function.
 512         (objfile_object_methods): Add new functions.
 513
 514 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 515
 516         * NEWS: Mention 'set|show print frame-info'.  Mention new
 517         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 518         backtrace argument.  Mention that python frame filtering code
 519         is now consistent with what 'backtrace' command prints.
 520
 521 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 522
 523         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 524         comments.
 525         (print_frame_info_auto, print_frame_info_source_line,
 526         print_frame_info_location, print_frame_info_source_and_location,
 527         print_frame_info_location_and_address, print_frame_info_short_location):
 528         New declarations.
 529         (struct frame_print_options): New member print_frame_info.
 530         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 531         * stack.h (get_user_print_what_frame_info): New declaration.
 532         (frame_show_address): New declaration.
 533         * stack.c (print_frame_arguments_choices): New value 'presence'.
 534         (print_frame_info_auto, print_frame_info_source_line,
 535         print_frame_info_location, print_frame_info_source_and_location,
 536         print_frame_info_location_and_address, print_frame_info_short_location,
 537         print_frame_info_choices, print_frame_info_print_what): New definitions.
 538         (print_frame_args): Only print dots for args if print frame-arguments
 539         is 'presence'.
 540         (frame_print_option_defs): New element for "frame-info".
 541         (get_user_print_what_frame_info): New function.
 542         (frame_show_address): Make non static.  Move comment to stack.h.
 543         (print_frame_info_to_print_what): New function.
 544         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 545         to decide what to print.
 546         (backtrace_command_1): Handle the new print_frame_arguments_presence
 547         value.
 548         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 549         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 550         (py_print_frame): In non-mi mode, use LOCATION as default for
 551         print_what, similarly to frame information printed directly by
 552         backtrace command. Handle frame-info user option in non MI mode.
 553
 554 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 555
 556         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 557         Add case for debugging 32-bit target on 64-bit host.  Revise
 558         comment.
 559
 560 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 561
 562         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 563         instead of find_function_entry_range_from_pc.
 564
 565 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 566
 567         * stack.c (find_frame_funname): Remove code which preferred
 568         minsym over symtab sym in "certain pathological cases".
 569
 570         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 571         parameter.  Change type of "do_demangle" to bool.
 572         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 573         Pass suitable "prefer_sym_over_minsym" flag to
 574         build_address_symbolic().  Don't output "+" for negative offsets.
 575         * printcmd.c (print_address_symbolic): Update invocation of
 576         build_address_symbolic to include a "prefer_sym_over_minsym"
 577         flag.
 578         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 579         Restrict cases in which use of minimal symbol is preferred to that
 580         of a found symbol.  Update comments.
 581
 582         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 583         for entry pc when entry pc is out of range for that FDE.
 584
 585 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 586
 587         PR gdb/24839:
 588         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 589         type.
 590
 591 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 592
 593         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 594         this function's Python signature.
 595
 596
 597 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 598
 599         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 600         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 601         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 602         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 603         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 604
 605
 606 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 607
 608         * h8300-tdep.c (h8300_register_name_common): New.
 609         h8300_register_name): Use h8300_register_name_common.
 610         (h8300s_register_name): Likewise.
 611         (h8300sx_register_name): Likewise.
 612         (h8300h_register_nam): New.
 613         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 614
 615
 616 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 617
 618         * arm-tdep.c (arm_skip_cmse_entry): New function.
 619         (arm_is_sgstubs_section): New function.
 620         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 621
 622 2019-07-22  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 625         Don't self-assign.
 626
 627 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 628
 629         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 630         type_print.
 631
 632 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 635         so that GDB doesn't match any msymbols when searching in the
 636         TYPES_DOMAIN.
 637         (print_symbol_info): Print using typedef_print or type_print based
 638         on the type of the symbol.  Add updated FIXME comment moved from...
 639         (_initialize_symtab): ... move and update FIXME comment to above.
 640
 641 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * NEWS: Mention adding -q option to "info types".
 644         * symtab.c (struct info_types_options): New struct.
 645         (info_types_options_defs): New variable.
 646         (make_info_types_options_def_group): New function.
 647         (info_types_command): Use gdb::option framework to parse options.
 648         (info_types_command_completer): New function.
 649         (_initialize_symtab): Extend the help text on "info types" and
 650         register command completer.
 651
 652 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 653
 654         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 655         (lookup_symbol_in_objfile): Change int to block_enum and add a
 656         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 657
 658 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 659
 660         * MAINTAINERS (Write After Approval): Add self.
 661
 662 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 665         instruction to the dummy code region.
 666
 667 2019-07-19  Tom Tromey  <tromey@adacore.com>
 668
 669         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 670         (ARGSUSED, PARAMS, __func__): Remove rules.
 671
 672 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 673
 674         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 675         * features/arm/arm-with-iwmmxt.c: Remove.
 676         * features/arm/arm-with-iwmmxt.xml: Remove.
 677         * features/arm/arm-with-m-fpa-layout.c: Remove.
 678         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 679         * features/arm/arm-with-m-vfp-d16.c: Remove.
 680         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 681         * features/arm/arm-with-m.c: Remove.
 682         * features/arm/arm-with-m.xml: Remove.
 683         * features/arm/arm-with-neon.c: Remove.
 684         * features/arm/arm-with-neon.xml: Remove.
 685         * features/arm/arm-with-vfpv2.c: Remove.
 686         * features/arm/arm-with-vfpv2.xml: Remove.
 687         * features/arm/arm-with-vfpv3.c: Remove.
 688         * features/arm/arm-with-vfpv3.xml: Remove.
 689
 690 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 693
 694 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 695
 696         * arch/aarch32.c (aarch32_create_target_description): Create
 697         target descriptions using features.
 698         * arch/arm.c (arm_create_target_description)
 699         (arm_create_mprofile_target_description): Likewise.
 700         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 701
 702 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 703
 704         * Makefile.in: Add new files.
 705         * aarch32-tdep.c: New file.
 706         * aarch32-tdep.h: New file.
 707         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 708         Call aarch32_read_description.
 709         * arch/aarch32.c: New file.
 710         * arch/aarch32.h: New file.
 711         * arch/arm.c (arm_create_target_description)
 712         (arm_create_mprofile_target_description): New function.
 713         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 714         (arm_create_target_description)
 715         (arm_create_mprofile_target_description): New declaration.
 716         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 717         read_description functions.
 718         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 719         Likewise.
 720         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 721         * arm-tdep.c (tdesc_arm_list): New variable.
 722         (arm_register_g_packet_guesses): Call create description functions.
 723         (arm_read_description) (arm_read_mprofile_description): New
 724         function.
 725         * arm-tdep.h (arm_read_description)
 726         (arm_read_mprofile_description): Add declaration.
 727         * configure.tgt: Add new files.
 728
 729 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 730
 731         * top.c (new_ui_command): Open specified terminal just once.
 732
 733 2019-07-18  Tom Tromey  <tromey@adacore.com>
 734
 735         * symtab.c (main_name): Constify return type.
 736         * symfile.c (set_initial_language): Update.
 737         * symtab.h (main_name): Constify return type.
 738
 739 2019-07-17  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.c (tui_update_source_window)
 742         (tui_update_source_window_as_is)
 743         (tui_update_source_windows_with_line): Remove return.
 744         * tui/tui-disasm.c (tui_show_disassem)
 745         (tui_show_disassem_and_update_source): Remove return.
 746         * tui/tui.c (tui_reset): Remove return.
 747         * tui/tui-wingeneral.c
 748         (tui_check_and_display_highlight_if_needed): Remove return.
 749
 750 2019-07-17  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 753
 754 2019-07-17  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-winsource.h (struct tui_exec_info_window)
 757         (struct tui_source_window_base): Move from tui-data.h.
 758         * tui/tui-winsource.c: Move many method definitions from
 759         elsewhere.  Remove "structuring" comments.
 760         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 761         (tui_source_window_base::refresh_window): Move to
 762         tui-winsource.c.
 763         * tui/tui-win.c (tui_source_window_base::refresh_all)
 764         (tui_source_window_base::update_tab_width)
 765         (tui_source_window_base::set_new_height)
 766         (tui_source_window_base::do_make_visible_with_new_height): Move to
 767         tui-winsource.c.
 768         * tui/tui-source.h: Update.
 769         * tui/tui-source.c (tui_source_window_base::reset): Move to
 770         tui-winsource.c.
 771         * tui/tui-disasm.h: Update.
 772         * tui/tui-data.h (struct tui_exec_info_window): Move to
 773         tui-winsource.h.
 774         (struct tui_source_window_base): Likewise.
 775         * tui/tui-data.c (tui_source_window_base::clear_detail)
 776         (tui_source_window_base, ~tui_source_window_base): Move to
 777         tui-winsource.c.
 778
 779 2019-07-17  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-win.c (tui_resize_all)
 782         (tui_source_window_base::update_tab_width)
 783         (tui_adjust_win_heights): Update.
 784         (tui_win_info::make_invisible_and_set_new_height): Rename from
 785         make_invisible_and_set_new_height.
 786         * tui/tui-data.h (struct tui_win_info)
 787         <make_invisible_and_set_new_height>: New method.
 788
 789 2019-07-17  Tom Tromey  <tom@tromey.com>
 790
 791         * tui/tui.c: Update.
 792         * tui/tui-source.h (struct tui_source_window): Move from
 793         tui-data.h.
 794         * tui/tui-layout.c: Update.
 795         * tui/tui-disasm.c: Update.
 796         * tui/tui-data.h (struct tui_source_window): Move to
 797         tui-source.h.
 798
 799 2019-07-17  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 802         tui-data.h.
 803         * tui/tui-data.h (struct tui_disasm_window): Move to
 804         tui-disasm.h.
 805
 806 2019-07-17  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-regs.h (struct tui_data_item_window): Move from
 809         tui-data.h.
 810         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 811         * tui/tui-data.h (struct tui_data_item_window): Move to
 812         tui-regs.h.
 813         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui.c: Update.
 818         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 819         (tui_cmd_window::max_height): Move to tui-command.c.
 820         * tui/tui-layout.c: Update.
 821         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 822         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 823         tui-command.c.
 824         * tui/tui-command.h (struct tui_cmd_window): Move from
 825         tui-data.h.
 826         * tui/tui-command.c: Remove "structuring" comments.
 827         (tui_cmd_window::clear_detail)
 828         (tui_cmd_window::do_make_visible_with_new_height)
 829         (tui_cmd_window::max_height): Move from elsewhere.
 830
 831 2019-07-17  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 834         Now static.
 835         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 836         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 837
 838 2019-07-17  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui.c: Update.
 841         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 842         tui-regs.c.
 843         * tui/tui-windata.h: Remove file.
 844         * tui/tui-windata.c: Remove file.
 845         * tui/tui-win.c (tui_data_window::set_new_height)
 846         (tui_data_window::do_make_visible_with_new_height): Move to
 847         tui-regs.c.
 848         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 849         * tui/tui-regs.c: Remove "structuring" comments.
 850         (tui_data_window::first_data_item_displayed)
 851         (tui_data_window::delete_data_content_windows)
 852         (tui_data_window::erase_data_content)
 853         (tui_data_window::display_all_data)
 854         (tui_data_window::refresh_all)
 855         (tui_data_window::do_scroll_vertical)
 856         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 857         (tui_data_window::do_make_visible_with_new_height)
 858         (tui_data_window::refresh_window): Move from elsewhere.
 859         (_initialize_tui_regs): Move to end of file.
 860         * tui/tui-layout.c: Update.
 861         * tui/tui-hooks.c: Update.
 862         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 863         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 864         tui-regs.c.
 865         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 866
 867 2019-07-17  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 870         seen.
 871
 872 2019-07-17  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-win.c (tui_source_window_base::set_new_height)
 875         (tui_source_window_base::do_make_visible_with_new_height): Use
 876         m_has_locator field directly.
 877         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 878         method.
 879         (struct tui_source_window_base) <has_locator>: Likewise.
 880
 881 2019-07-17  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 884         Don't declare.
 885         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 886         Remove.
 887         * tui/tui-win.c (tui_source_window_base::set_new_height)
 888         (tui_source_window_base::set_new_height)
 889         (make_invisible_and_set_new_height)
 890         (tui_source_window_base::do_make_visible_with_new_height)
 891         (tui_source_window_base::do_make_visible_with_new_height):
 892         Update.
 893         * tui/tui-layout.c (show_source_disasm_command, show_data)
 894         (show_source_or_disasm_and_command): Update.
 895         * tui/tui-layout.c (show_layout): Update.
 896
 897 2019-07-17  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-layout.c (make_data_window): Remove.
 900         (show_data): Unify creation and re-initialization cases.
 901
 902 2019-07-17  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-layout.c (make_source_window, make_disasm_window):
 905         Remove.
 906         (show_data): Unify creation and re-initialization cases.
 907
 908 2019-07-17  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-layout.c (make_command_window): Remove.
 911         (show_source_disasm_command, show_source_or_disasm_and_command):
 912         Unify creation and re-initialization cases.
 913
 914 2019-07-17  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 917         creation and re-initialization cases.
 918
 919 2019-07-17  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-regs.c (tui_get_register): Return void.
 922
 923 2019-07-17  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 926         Simplify.
 927
 928 2019-07-17  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 931         resetting.
 932
 933 2019-07-17  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 936         * tui/tui-regs.c (tui_reg_layout): New function.
 937         (tui_show_registers, tui_reg_command): Use it.
 938         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 939         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 940         parameters.
 941         (tui_layout_command): Remove.
 942
 943 2019-07-17  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-layout.h (tui/tui-layout): Return void.
 946         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 947
 948 2019-07-17  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-layout.c (show_source_disasm_command, show_data):
 951         Update.
 952         (reset_locator): Remove.
 953         (show_source_or_disasm_and_command): Update.
 954
 955 2019-07-17  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-source.c (tui_source_window_base::reset): Remove
 958         win_type parameter.
 959         * tui/tui-layout.c (make_command_window, make_source_window)
 960         (make_disasm_window, make_data_window)
 961         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 962         (reset_locator, show_source_or_disasm_and_command): Update.
 963         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 964         win_type parameter.
 965         (struct tui_source_window_base) <reset>: Likewise.
 966
 967 2019-07-17  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-layout.c (show_source_disasm_command): Use
 970         reset_locator.
 971         (reset_locator): New function.
 972         (init_and_make_win): Remove.
 973         (show_source_or_disasm_and_command): Use reset_locator.
 974
 975 2019-07-17  Tom Tromey  <tom@tromey.com>
 976
 977         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 978         condition.
 979         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 980         Remove condition.
 981         * tui/tui-source.c (tui_source_window_base::reset): New method.
 982         * tui/tui-layout.c (make_command_window): Don't call
 983         init_and_make_win.
 984         (make_source_window, make_disasm_window): Don't call
 985         make_source_or_disasm_window.
 986         (make_data_window): Don't call init_and_make_win.  Change calling
 987         convention.
 988         (show_source_disasm_command, show_data): Simplify.
 989         (make_source_or_disasm_window): Remove.
 990         (show_source_or_disasm_and_command): Simplify.
 991         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 992         (struct tui_source_window_base) <reset>: Likewise.
 993         <execution_info>: Remove initializer.
 994         * tui/tui-data.c (tui_source_window_base): Initialize
 995         execution_info.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1000         variable.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui.c (tui_rl_other_window): Update.
1005         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1006         superclass method first.  Always iterate over regs_content.
1007         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1008         method.
1009         * tui/tui-win.c (tui_set_focus_command): Update.
1010
1011 2019-07-17  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-win.c (tui_set_focus_command): Rename from
1014         tui_set_focus.  Call tui_enable.
1015         (tui_set_focus_command): Remove.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1020         refresh_window.
1021         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1022         touchwin.
1023         (tui_data_window::refresh_window): Call refresh_window on data
1024         items.  Always call superclass refresh_window.
1025         (tui_win_info::refresh): Remove.
1026         (tui_source_window_base::refresh_window): Update.
1027         (tui_refresh_all): Update.
1028         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1029         refresh_window.
1030         (show_source_or_disasm_and_command): Likewise.
1031         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1032         (struct tui_source_window_base) <refresh>: Likewise.
1033
1034 2019-07-17  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-winsource.c (tui_clear_source_content)
1037         (tui_show_source_content): Update.
1038         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1039         whether content is empty.
1040         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1041         Remove.
1042
1043 2019-07-17  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1046         window's contents.
1047         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1048         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1049
1050 2019-07-17  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1053         (struct tui_data_item_window): Update.
1054
1055 2019-07-17  Tom Tromey  <tom@tromey.com>
1056
1057         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1058         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1059         defines.
1060
1061 2019-07-17  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-winsource.h (tui_erase_source_content)
1064         (tui_clear_source_content): Remove "display_prompt" parameter.
1065         * tui/tui-winsource.c (tui_update_source_window_as_is)
1066         (tui_update_source_windows_with_addr): Update.
1067         (tui_clear_source_content): Remove "display_prompt" parameter.
1068         (tui_erase_source_content): Likewise.  Simplify.
1069         (tui_show_source_content): Update.
1070         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1071         * tui/tui-stack.c (tui_show_frame_info): Update.
1072         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1073         Remove defines.
1074
1075 2019-07-17  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1078         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1079         parameter.
1080         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1081         parameter.
1082
1083 2019-07-17  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-winsource.c (tui_clear_source_content)
1086         (tui_show_source_content, tui_show_exec_info_content)
1087         (tui_clear_exec_info_content): Update.
1088         * tui/tui-stack.c (tui_show_locator_content): Update.
1089         (tui_show_frame_info): Update.
1090         * tui/tui-source.h (tui_source_window): Don't declare.
1091         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1092         from tui_source_is_displayed.
1093         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1094         Remove field.
1095         (struct tui_source_window_base) <content_in_use>: New field.  Now
1096         bool.
1097         (struct tui_source_window) <showing_source_p>: New method.
1098         (TUI_SRC_WIN): Change cast.
1099         * tui/tui-data.c (tui_initialize_static_data): Update.
1100
1101 2019-07-17  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1104         location_matches_p.
1105         * tui/tui-source.c (tui_source_window::location_matches_p): New
1106         method.
1107         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1108         method.
1109         * tui/tui-data.h (struct tui_source_window_base)
1110         <location_matches_p>: New method.
1111         (struct tui_source_window, struct tui_disasm_window)
1112         <location_matches_p>: Likewise.
1113
1114 2019-07-17  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-win.c (tui_set_win_height_command): Rename from
1117         tui_set_win_height.
1118         (tui_set_win_height_command): Remove.
1119
1120 2019-07-17  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-source.c (tui_source_window): New constructor.  Add
1123         observer.
1124         (~tui_source_window): New destructor.
1125         (tui_source_window::style_changed): New method.
1126         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1127         (tui_attach_detach_observers): Update.
1128         * tui/tui-data.h (struct tui_source_window): Make constructor not
1129         inline.  Add destructor.
1130         (struct tui_source_window) <style_changed>: New method.
1131         <m_observable>: New member.
1132
1133 2019-07-17  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1136         * tui/tui-win.c (tui_resize_all): Fix typo.
1137
1138 2019-07-17  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1141         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1142         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1143         * tui/tui-win.c (window_name_completer): Use foreach.
1144         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1145         (update_tab_width): Likewise.
1146         * tui/tui-layout.c (show_layout): Update.
1147         * tui/tui-data.h (class tui_window_iterator): New.
1148         (struct all_tui_windows): New.
1149         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1150
1151 2019-07-17  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1154         parameter.  Don't reference globals.
1155         (tui_reg_command): Update.
1156
1157 2019-07-17  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-regs.c (tui_show_registers): Simplify.
1160
1161 2019-07-17  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-regs.c (tui_show_registers): Update.
1164         (tui_show_register_group): Add win_info parameter.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1169         Rename from tui_display_reg_element_at_line.
1170         (tui_data_window::display_registers_from_line): Update.
1171         * tui/tui-data.h (struct tui_data_window)
1172         <display_reg_element_at_line>: New method.
1173
1174 2019-07-17  Tom Tromey  <tom@tromey.com>
1175
1176         * tui/tui-regs.h (tui_display_registers_from)
1177         (tui_display_registers_from_line): Don't declare.
1178         * tui/tui-windata.c (tui_data_window::display_all_data)
1179         (tui_data_window::refresh_all)
1180         (tui_data_window::do_scroll_vertical): Update.
1181         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1182         from tui_display_registers_from.
1183         (tui_display_reg_element_at_line): Update.
1184         (tui_data_window::display_registers_from_line): Rename from
1185         tui_display_registers_from_line.
1186         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1187         display_registers_from_line>: New methods.
1188
1189 2019-07-17  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1192         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1193         from tui_erase_data_content.
1194         (tui_data_window::display_all_data)
1195         (tui_data_window::refresh_all)
1196         (tui_data_window::do_scroll_vertical): Update.
1197         * tui/tui-regs.c (tui_show_registers): Update.
1198         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1199         New method.
1200
1201 2019-07-17  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1204         declare.
1205         * tui/tui-windata.c
1206         (tui_data_window::delete_data_content_windows): Rename from
1207         tui_delete_data_content_windows.
1208         (tui_data_window::display_all_data)
1209         (tui_data_window::do_scroll_vertical): Update.
1210         * tui/tui-data.h (struct tui_data_window)
1211         <delete_data_content_windows>: New method.
1212
1213 2019-07-17  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1216         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1217
1218 2019-07-17  Tom Tromey  <tom@tromey.com>
1219
1220         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1221         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1222         from tui_display_all_data.
1223         * tui/tui-win.c
1224         (tui_data_window::do_make_visible_with_new_height): Update.
1225         * tui/tui-regs.c (tui_show_registers): Update.
1226         * tui/tui-layout.c (tui_set_layout): Update.
1227         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1228         method.
1229
1230 2019-07-17  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1233         * tui/tui-windata.c (tui_display_data_from): Remove.
1234         (tui_data_window::refresh_all): Update.
1235
1236 2019-07-17  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1239         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1240         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1241         tui_display_registers_from_line.
1242         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1243         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1244         "force_display" parameter.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1249         declare.
1250         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1251         Rename from tui_first_reg_element_no_inline.
1252         (tui_display_reg_element_at_line)
1253         (tui_display_registers_from_line): Update.
1254         * tui/tui-data.h (struct tui_data_window)
1255         <first_reg_element_no_inline>: New method.
1256
1257 2019-07-17  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-windata.c (tui_display_data_from)
1260         (tui_data_window::do_scroll_vertical): Update.
1261         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1262         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1263         Rename from tui_line_from_reg_element_no.
1264         (tui_display_registers_from_line): Update.
1265         * tui/tui-data.h (struct tui_data_window)
1266         <line_from_reg_element_no>: New method.
1267
1268 2019-07-17  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1271         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1272         tui_last_regs_line_no.
1273         (tui_display_reg_element_at_line)
1274         (tui_display_registers_from_line): Update.
1275         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1276         method.
1277
1278 2019-07-17  Tom Tromey  <tom@tromey.com>
1279
1280         PR tui/24722:
1281         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1282         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1283         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1284         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1285         (tui_update_breakpoint_info): Likewise.
1286         * tui/tui-hooks.c (tui_event_create_breakpoint)
1287         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1288         Update.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1293
1294 2019-07-17  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-winsource.c (tui_update_source_window_as_is)
1297         (tui_update_source_windows_with_addr): Update.
1298         * tui/tui-source.h (tui_set_source_content)
1299         (tui_show_symtab_source): Add "win_info" parameter.
1300         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1301         parameter.
1302         (tui_show_symtab_source): Likewise.
1303
1304 2019-07-17  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-wingeneral.c
1307         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1312         (struct tui_cmd_window) <can_scroll>: New method.
1313         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1314         method.
1315
1316 2019-07-17  Tom Tromey  <tromey@adacore.com>
1317
1318         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1319         do_field_signed>: Rename.  Change type of "value".
1320         * ui-out.c (ui_out::field_signed): Rename from field_int.
1321         Change type of "value".
1322         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1323         type of "value".
1324         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1325         do_field_int.  Change type of "value".
1326         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1327         do_field_int.  Change type of "value".
1328         * tracepoint.c (trace_status_mi, tfind_1)
1329         (print_one_static_tracepoint_marker): Update.
1330         * thread.c (print_thread_info_1, print_selected_thread_frame):
1331         Update.
1332         * stack.c (print_frame, print_frame_info): Update.
1333         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1334         Update.
1335         * source.c (print_source_lines_base): Update.
1336         * skip.c (info_skip_command): Update.
1337         * record-btrace.c (btrace_ui_out_decode_error)
1338         (btrace_call_history_src_line): Update.
1339         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1340         Update.
1341         * progspace.c (print_program_space): Update.
1342         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1343         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1344         do_field_int.  Change type of "value".
1345         * mi/mi-out.c (mi_ui_out::do_table_begin)
1346         (mi_ui_out::do_table_header): Update.
1347         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1348         type of "value".
1349         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1350         (mi_cmd_data_list_changed_registers, output_register)
1351         (mi_cmd_data_read_memory, mi_load_progress)
1352         (mi_cmd_trace_frame_collected): Update.
1353         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1354         Update.
1355         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1356         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1357         (mi_cmd_var_list_children, varobj_update_one): Update.
1358         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1359         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1361         * inferior.c (print_inferior): Update.
1362         * gdb_bfd.c (print_one_bfd): Update.
1363         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1364         Update.
1365         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1366         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1367         do_field_int.  Change type of "value".
1368         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1369         do_field_int.  Change type of "value".
1370         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1371         (print_one_breakpoint_location, print_it_catch_fork)
1372         (print_one_catch_fork, print_it_catch_vfork)
1373         (print_one_catch_vfork, print_it_catch_solib)
1374         (print_it_catch_exec, print_it_ranged_breakpoint)
1375         (print_mention_watchpoint, print_mention_masked_watchpoint)
1376         (bkpt_print_it, update_static_tracepoint): Update.
1377         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1378         * break-catch-syscall.c (print_it_catch_syscall): Update.
1379         * ada-tasks.c (print_ada_task_info): Update.
1380         * ada-lang.c (print_it_exception, print_mention_exception):
1381         Update.
1382
1383 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         PR breakpoints/24541
1386         * gdbarch.c: Regenerate.
1387         * gdbarch.h: Regenerate.
1388         * gdbarch.sh: Adjust return type and parameter types for
1389         'stap_adjust_register'.
1390         (i386_stap_adjust_register): Adjust signature and return new
1391         register name.
1392         * stap-probe.c (stap_parse_register_operand): Adjust use of
1393         'gdbarch_stap_adjust_register'.
1394
1395 2019-07-17  Tom Tromey  <tromey@adacore.com>
1396
1397         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1398         declare VEC.
1399         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1400         std::vector.
1401         (struct s390_process_info): Add initializers.
1402         (s390_add_process): Use new.
1403         (s390_linux_nat_target::low_forget_process): Use delete.
1404         (s390_linux_nat_target::low_new_fork)
1405         (s390_linux_nat_target::stopped_by_watchpoint)
1406         (s390_linux_nat_target::low_prepare_to_resume)
1407         (s390_linux_nat_target::insert_watchpoint)
1408         (s390_linux_nat_target::insert_hw_breakpoint)
1409         (s390_linux_nat_target::remove_watchpoint)
1410         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1411
1412 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1413
1414         * aarch64-fbsd-nat.c: Include regcache.h.
1415         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1416         argument.
1417         (aarch64_fbsd_nat_target::fetch_registers)
1418         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1419         variable.
1420         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1421
1422 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1423
1424         * fbsd-nat.c: Include gdbarch.h.
1425
1426 2019-07-15  Tom Tromey  <tromey@adacore.com>
1427
1428         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1429
1430 2019-07-15  Tom Tromey  <tromey@adacore.com>
1431
1432         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1433         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1434         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1435         * cli-out.c (cli_ui_out::do_field_int): New method.
1436         * ui-out.c (ui_out::field_unsigned): New method.
1437         * symfile.c (generic_load): Use field_unsigned.
1438         (print_transfer_performance): Likewise.
1439         * record-btrace.c (ui_out_field_uint): Remove.
1440         (btrace_call_history_insn_range, btrace_call_history): Use
1441         field_unsigned.
1442         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1443         field_unsigned.
1444         * ui-out.h (class ui_out) <field_unsigned>: New method.
1445         <do_field_unsigned>: Likewise.
1446
1447 2019-07-15  Tom Tromey  <tromey@adacore.com>
1448
1449         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1450         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1451         * target.c (flash_erase_command): Use field_string.
1452         * infrun.c (print_signal_received_reason): Use field_string.
1453         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1454         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1455         field_string.
1456         * ada-tasks.c (print_ada_task_info): Use field_string.
1457
1458 2019-07-15  Tom Tromey  <tromey@adacore.com>
1459
1460         * target.c (flash_erase_command): Use field_core_addr.
1461         * symfile.c (generic_load): Use field_core_addr.
1462         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1463         Use field_core_addr.
1464         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1465         field_core_addr.
1466
1467 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1470         value if its desired type is smaller than a CORE_ADDR and signed.
1471
1472 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1475         of changes to field names, and use new is_reference field to
1476         decide if a property is a reference or not.
1477         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1478         field.
1479         (struct dwarf2_property_baton): Update header comment, rename
1480         'referenced_type' to 'property_type' and update comments.
1481         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1482         default property type, store in property baton, update to take
1483         accound of renamed field.
1484         (read_func_scope): Update call to attr_to_dynamic_prop.
1485         (read_array_type): Likewise.
1486         (dwarf2_per_cu_addr_sized_int_type): New function.
1487         (read_subrange_index_type): Move type finding code to
1488         dwarf2_per_cu_addr_sized_int_type.
1489         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1490         (dwarf2_per_cu_addr_type): New function.
1491         (set_die_type): Update calls to attr_to_dynamic_prop.
1492
1493 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * dwarf2read.c (read_subrange_index_type): New function.
1496         (read_subrange_type): Move code into new function and call it.
1497         * gdbtypes.c (create_range_type): Add some asserts.
1498
1499 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1502         update return statements.
1503         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1504         declaration, and update comment to match.
1505         * gdbtypes.c (resolve_dynamic_array): Update call to
1506         dwarf2_evaluate_property to match new return type.
1507
1508 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * valarith.c (value_subscripted_rvalue): Change lowerbound
1511         parameter type from int to LONGEST.
1512         * value.h (value_subscripted_rvalue): Likewise in declaration.
1513
1514 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * cli/cli-utils.c (info_print_command_completer): New function.
1517         * cli/cli-utils.h: Add 'completer.h' include, and forward
1518         declaration for 'struct cmd_list_element'.
1519         (info_print_command_completer): Declare.
1520         * stack.c (_initialize_stack): Add completer for 'info locals' and
1521         'info args'.
1522         * symtab.c (_initialize_symtab): Add completer for 'info
1523         variables' and 'info functions'.
1524         * NEWS: Mention completion for additional info commands.
1525
1526 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * cli/cli-utils.c (extract_info_print_args): Delete.
1529         (extract_arg_maybe_quoted): Delete.
1530         (info_print_options_defs): New variable.
1531         (make_info_print_options_def_group): New function.
1532         (extract_info_print_options): Define new function.
1533         * cli/cli-utils.h (extract_info_print_args): Delete.
1534         (struct info_print_options): New structure.
1535         (extract_info_print_options): Declare new function.
1536         * stack.c (info_locals_command): Update to use new
1537         extract_info_print_options, also add a header comment.
1538         (info_args_command): Likewise.
1539         * symtab.c (info_variables_command): Likewise.
1540         (info_functions_command): Likewise.
1541
1542 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1545         to extract string arguments.
1546         * common/common-utils.c (extract_string_maybe_quoted): New function.
1547         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1548
1549 2019-07-11  Tom Tromey  <tromey@adacore.com>
1550
1551         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1552         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1553         * top.h (gdbinit): Don't declare.
1554         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1555         into...
1556         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1557         * top.c (gdb_init): Don't call init_cli_cmds.
1558         (gdbinit): Remove.
1559         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1560
1561 2019-07-11  Tom Tromey  <tromey@adacore.com>
1562
1563         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1564         after it has been moved.
1565
1566 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1567
1568         * valops.c (value_must_coerce_to_target): Change return type to
1569         bool.
1570         * value.h (value_must_coerce_to_target): Likewise.
1571
1572 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1573
1574         * breakpoint.c (is_hardware_watchpoint): Remove
1575         forward-declaration.
1576         (is_masked_watchpoint): Change return type to bool.
1577         (is_tracepoint): Likewise.
1578         (is_breakpoint): Likewise.
1579         (is_hardware_watchpoint): Likewise.
1580         (is_watchpoint): Likewise.
1581         (is_no_memory_software_watchpoint): Likewise.
1582         (is_catchpoint): Likewise.
1583         (breakpoint_1): Make FILTER parameter's return type bool.
1584         is_masked_watchpoint): Change return type to bool.
1585         (save_breakpoints): Make FILTER parameter's return type bool.
1586         * breakpoint.h (is_breakpoint): Change return type to bool.
1587         (is_watchpoint): Likewise.
1588         (is_catchpoint): Likewise.
1589         (is_tracepoint): Likewise.
1590
1591 2019-07-10  Tom Tromey  <tom@tromey.com>
1592
1593         * defs.h: Don't include gdbarch.h.
1594         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1595         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1596         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1597         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1598         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1599         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1600         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1601         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1602         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1603         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1604         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1605         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1606         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1607         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1608         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1609         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1610         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1611         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1612         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1613         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1614         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1615         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1616         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1617         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1618         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1619         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1620         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1621
1622 2019-07-10  Tom Tromey  <tromey@adacore.com>
1623
1624         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1625         * breakpoint.c (init_ada_exception_breakpoint): Register as
1626         bp_catchpoint.
1627         (print_one_breakpoint_location, print_one_breakpoint): Use
1628         is_ada_exception_catchpoint.
1629         * ada-lang.c (class ada_catchpoint_location): Pass
1630         bp_loc_software_breakpoint to bp_location constructor.
1631         (is_ada_exception_catchpoint): New function.
1632
1633 2019-07-10  Tom Tromey  <tromey@adacore.com>
1634
1635         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1636         VEC.
1637         (struct arm_exidx_entry): New method operator<.
1638         (struct arm_exidx_data) <section_maps>: Change type.
1639         (arm_exidx_data_free): Remove.
1640         (arm_exidx_data_key): Change type.  Move lower.
1641         (arm_exidx_new_objfile): Update.
1642         (arm_compare_exidx_entries): Remove.
1643         (arm_find_exidx_entry, _initialize_arm_tdep)
1644
1645 2019-07-10  Tom Tromey  <tromey@adacore.com>
1646
1647         * solib-spu.c (ocl_program_data_key): Change type.
1648         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1649         Update.
1650
1651 2019-07-10  Tom Tromey  <tromey@adacore.com>
1652
1653         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1654         (struct solib_aix_inferior_data) <library_list>: Change type.
1655         (solib_aix_inferior_data_handle): Change type.
1656         (get_solib_aix_inferior_data): Update.
1657         (solib_aix_free_library_list): Remove.
1658         (library_list_start_library): Update.
1659         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1660         return type.
1661         (solib_aix_get_library_list)
1662         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1663         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1664
1665 2019-07-10  Tom Tromey  <tromey@adacore.com>
1666
1667         * solib-dsbt.c (struct dsbt_info): Add initializers.
1668         (solib_dsbt_pspace_data): Change type.
1669         (dsbt_pspace_data_cleanup): Remove.
1670         (get_dsbt_info, _initialize_dsbt_solib): Update.
1671
1672 2019-07-10  Tom Tromey  <tromey@adacore.com>
1673
1674         * spu-tdep.c (spu_overlay_data): Change type.
1675         (spu_get_overlay_table, spu_overlay_new_objfile)
1676         (_initialize_spu_tdep): Update.
1677
1678 2019-07-10  Tom Tromey  <tromey@adacore.com>
1679
1680         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1681         destructor.
1682         (dbx_objfile_data_key): Change type and declare later.
1683         (DBX_SYMFILE_INFO): Rewrite.
1684         * dbxread.c (dbx_objfile_data_key): Change type.
1685         (dbx_symfile_init): Update.
1686         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1687         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1688         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1689
1690 2019-07-10  Tom Tromey  <tromey@adacore.com>
1691
1692         * jit.c (jit_program_space_key): Change type.  Move lower.
1693         (get_jit_program_space_data): Update.
1694         (jit_program_space_data_cleanup): Remove.
1695         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1696         Update.
1697         (struct jit_program_space_data): Add initializers.
1698
1699 2019-07-10  Tom Tromey  <tromey@adacore.com>
1700
1701         * solib-darwin.c (struct darwin_info): Add initializers.
1702         (solib_darwin_pspace_data): Change type.
1703         (darwin_pspace_data_cleanup): Remove.
1704         (get_darwin_info, _initialize_darwin_solib): Update.
1705
1706 2019-07-10  Tom Tromey  <tromey@adacore.com>
1707
1708         * remote-sim.c (struct sim_inferior_data): Add initializers,
1709         constructor, and destructor.
1710         (sim_inferior_data_key): Change type.  Move lower.
1711         (check_for_duplicate_sim_descriptor): Update.
1712         (get_sim_inferior_data): Use new.  Update.
1713         (~sim_inferior_data_cleanup): Rename from
1714         sim_inferior_data_cleanup.  Simplify.
1715         (gdbsim_close_inferior, simulator_command)
1716         (sim_command_completer, _initialize_remote_sim): Update.
1717         (next_pid, INITIAL_PID): Move earlier.
1718
1719 2019-07-10  Tom Tromey  <tromey@adacore.com>
1720
1721         * python/python-internal.h (create_thread_object): Return
1722         gdbpy_ref.
1723         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1724         * python/py-inferior.c (struct threadlist_entry): Add
1725         constructor.
1726         <thread_obj>: Now a gdbpy_ref.
1727         (thread_to_thread_object): Update.
1728         (add_thread_object): Use new.
1729         (delete_thread_object): Use delete.
1730         (infpy_threads): Update.
1731         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1732         GIL.
1733
1734 2019-07-10  Tom Tromey  <tromey@adacore.com>
1735
1736         * valops.c (value_cast): Specialize error message for Ada.
1737
1738 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1739
1740         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1741
1742 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1743
1744         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1745         bpstat_should_step): Return bool, adjust comments.
1746         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1747         bpstat_should_step): Likewise.
1748
1749 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1750
1751         * features/Makefile: Use feature target descriptions for Arm.
1752         * features/arm/arm-core.c: Generate new file.
1753         * features/arm/arm-fpa.c: Likewise.
1754         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1755         * features/arm/arm-m-profile.c: Likewise.
1756         * features/arm/arm-vfpv2.c: Likewise.
1757         * features/arm/arm-vfpv3.c: Likewise.
1758         * features/arm/xscale-iwmmxt.c: Likewise.
1759         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1760
1761 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1762
1763         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1764         ptrace earlier.
1765
1766 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1767
1768         * features/aarch64-pauth.c: Regenerate.
1769
1770 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1771
1772         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1773         bool.
1774         (bpstat_what): Use false instead of 0.
1775
1776 2019-07-09  Pedro Alves  <palves@redhat.com>
1777
1778         * break-catch-throw.c (is_exception_catchpoint): New.
1779         * breakpoint.c (print_one_breakpoint_location): New parameter
1780         'raw_loc'.  Handle it.  Use
1781         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1782         looking at the breakpoint's type.
1783         (print_one_breakpoint): If handling "maint info breakpoints", also
1784         print locations of exception catchpoints.
1785         * breakpoint.h (is_exception_catchpoint): Declare.
1786
1787 2019-07-09  Pedro Alves  <palves@redhat.com>
1788
1789         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1790         "addr" field.
1791         (allocate_location_exception_catchpoint): New.
1792         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1793         (initialize_throw_catchpoint_ops): Install
1794         allocate_location_exception_catchpoint as allocate_location
1795         method.
1796         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1797         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1798         bp_loc_other.
1799         (breakpoint_address_is_meaningful): Delete.
1800         (bl_address_is_meaningful): New.
1801         (breakpoint_locations_match): Adjust comment.
1802         (bp_location_from_bp_type): New, factored out of...
1803         (bp_location::bp_location(breakpoint *)): ... this.
1804         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1805         factored out of...
1806         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1807         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1808         breakpoint_address_is_meaningful.
1809         (bp_locations_compare): Adjust comment.
1810         (update_global_location_list): Use bl_address_is_meaningful
1811         instead of breakpoint_address_is_meaningful.
1812         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1813         explicit.
1814         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1815         * python/py-breakpoint.c (bppy_get_location): No longer check
1816         whether location is null.
1817
1818 2019-07-09  Pedro Alves  <palves@redhat.com>
1819
1820         PR c++/15468
1821         * breakpoint.c (print_one_breakpoint_location): Remove
1822         single-location assert.
1823
1824 2019-07-09  Tom Tromey  <tom@tromey.com>
1825
1826         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1827         * configure: Rebuild.
1828         * configure.ac: Change common to gdbsupport.
1829         * gdbsupport: Rename from common.
1830         * acinclude.m4: Change common to gdbsupport.
1831         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1832         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1833         gdbsupport.
1834         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1835         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1836         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1837         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1838         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1839         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1840         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1841         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1842         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1843         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1844         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1845         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1846         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1847         coff-pe-read.c, command.h, compile/compile-c-support.c,
1848         compile/compile-c.h, compile/compile-cplus-symbols.c,
1849         compile/compile-cplus-types.c, compile/compile-cplus.h,
1850         compile/compile-loc2c.c, compile/compile.c, completer.c,
1851         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1852         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1853         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1854         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1855         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1856         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1857         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1858         features/aarch64-core.c, features/aarch64-fpu.c,
1859         features/aarch64-pauth.c, features/aarch64-sve.c,
1860         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1861         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1862         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1863         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1864         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1865         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1866         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1867         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1868         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1869         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1870         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1871         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1872         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1873         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1874         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1875         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1876         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1877         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1878         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1879         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1880         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1881         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1882         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1883         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1884         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1885         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1886         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1887         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1888         minsyms.c, mips-linux-tdep.c, namespace.h,
1889         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1890         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1891         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1892         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1893         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1894         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1895         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1896         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1897         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1898         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1899         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1900         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1901         procfs.c, producer.c, progspace.h, psymtab.h,
1902         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1903         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1904         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1905         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1906         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1907         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1908         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1909         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1910         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1911         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1912         target-memory.c, target.c, target.h, target/waitstatus.c,
1913         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1914         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1915         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1916         unittests/array-view-selftests.c,
1917         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1918         unittests/common-utils-selftests.c,
1919         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1920         unittests/format_pieces-selftests.c,
1921         unittests/function-view-selftests.c,
1922         unittests/lookup_name_info-selftests.c,
1923         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1924         unittests/mkdir-recursive-selftests.c,
1925         unittests/observable-selftests.c,
1926         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1927         unittests/parse-connection-spec-selftests.c,
1928         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1929         unittests/scoped_fd-selftests.c,
1930         unittests/scoped_mmap-selftests.c,
1931         unittests/scoped_restore-selftests.c,
1932         unittests/string_view-selftests.c, unittests/style-selftests.c,
1933         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1934         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1935         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1936         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1937         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1938         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1939
1940 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1943         bool value.
1944         (decode_digits_ordinary): Set explicit_line field in sal.
1945         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1946         symtab_and_line that was set on an explicit line number in
1947         assembler code.  Do always update the recorded symtab and line if
1948         we do skip the prologue.
1949
1950 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * breakpoint.c (set_breakpoint_location_function): Remove
1953         explicit_loc parameter.
1954         (momentary_breakpoint_from_master): Update call to
1955         set_breakpoint_location_function.
1956         (add_location_to_breakpoint): Likewise.
1957
1958 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1961         required features based on default bfd type when no specific bfd
1962         is present.
1963
1964 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1965
1966         * NEWS: Mention that GDB printf and eval commands can now print
1967         C-style and Ada-style convenience var strings without
1968         calling the inferior.
1969         * printcmd.c (printf_c_string): Locally print GDB internal var
1970         instead of transiting via the inferior.
1971         (printf_wide_c_string): Likewise.
1972
1973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1974
1975         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1976
1977 2019-07-04  Tom Tromey  <tom@tromey.com>
1978
1979         PR tui/24724:
1980         * tui/tui-winsource.c (tui_clear_source_content): Update.
1981         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1982         (tui_update_breakpoint_info): Update.
1983         (tui_set_exec_info_content): Update.
1984         * tui/tui-source.c (tui_set_source_content_nil): Update.
1985         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1986         has_break.
1987         * tui/tui-data.h (enum tui_bp_flag): New.
1988         (tui_bp_flags): New enum flags type.
1989         (struct tui_source_element) <break_mode>: Change type.  Rename
1990         from has_break.
1991         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1992         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1993         constants.
1994         * tui/tui-winsource.h: Fix comment.
1995
1996 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1997
1998         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1999         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2000         (store_fpregs_to_thread)
2001         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2002         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2003         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2004         (IWMMXT_REGS_SIZE): Add define.
2005         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2006         (fetch_vfp_regs, store_vfp_regs)
2007         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2008         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2009
2010 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2011
2012         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2013         defines.
2014         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2015         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2016         (ARM_INT_REGISTER_SIZE): ...to this.
2017         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2018         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2019         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2020         (arm_linux_collect_gregset, supply_nwfpe_register)
2021         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2022         defines.
2023         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2024         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2025         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2026         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2027         (arm_return_in_memory, arm_store_return_value)
2028         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2029         (arm_record_ld_st_multiple): Likewise.
2030         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2031         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2032
2033 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2036         AARCH64_DISPLACED_MODIFIED_INSNS.
2037         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2038         (aarch64_displaced_step_copy_insn): Likewise.
2039         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2040         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2041         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2042         ARM_DISPLACED_MODIFIED_INSNS.
2043         * arm-tdep.c (arm_gdbarch_init): Likewise.
2044         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2045         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2046         (struct arm_displaced_step_closure): Use
2047         ARM_DISPLACED_MODIFIED_INSNS.
2048
2049 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2050
2051         * features/Makefile: Remove unused xml files.
2052         * features/aarch64.xml: Remove.
2053         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2054         * features/i386/amd64-avx-avx512.xml: Remove.
2055         * features/i386/amd64-avx-linux.xml: Remove.
2056         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2057         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2058         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2059         * features/i386/amd64-avx-mpx.xml: Remove.
2060         * features/i386/amd64-avx.xml: Remove.
2061         * features/i386/amd64-linux.xml: Remove.
2062         * features/i386/amd64-mpx-linux.xml: Remove.
2063         * features/i386/amd64-mpx.xml: Remove.
2064         * features/i386/amd64.xml: Remove.
2065         * features/i386/i386-avx-avx512-linux.xml: Remove.
2066         * features/i386/i386-avx-avx512.xml: Remove.
2067         * features/i386/i386-avx-linux.xml: Remove.
2068         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2069         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2070         * features/i386/i386-avx-mpx-linux.xml: Remove.
2071         * features/i386/i386-avx-mpx.xml: Remove.
2072         * features/i386/i386-avx.xml: Remove.
2073         * features/i386/i386-linux.xml: Remove.
2074         * features/i386/i386-mmx-linux.xml: Remove.
2075         * features/i386/i386-mmx.xml: Remove.
2076         * features/i386/i386-mpx-linux.xml: Remove.
2077         * features/i386/i386-mpx.xml: Remove.
2078         * features/i386/i386.xml: Remove.
2079         * features/i386/x32-avx-avx512-linux.xml: Remove.
2080         * features/i386/x32-avx-linux.xml: Remove.
2081         * features/i386/x32-linux.xml: Remove.
2082
2083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2084
2085         * regformats/aarch64.dat: Remove.
2086         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2087         * regformats/i386/amd64-avx-linux.dat: Remove.
2088         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2089         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2090         * regformats/i386/amd64-linux.dat: Remove.
2091         * regformats/i386/amd64-mpx-linux.dat: Remove.
2092         * regformats/i386/amd64.dat: Remove.
2093         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2094         * regformats/i386/i386-avx-linux.dat: Remove.
2095         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2096         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2097         * regformats/i386/i386-linux.dat: Remove.
2098         * regformats/i386/i386-mmx-linux.dat: Remove.
2099         * regformats/i386/i386-mpx-linux.dat: Remove.
2100         * regformats/i386/i386.dat: Remove.
2101         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2102         * regformats/i386/x32-avx-linux.dat: Remove.
2103         * regformats/i386/x32-linux.dat: Remove.
2104
2105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2106
2107         * aarch64-tdep.c: Remove xml self tests.
2108         * amd64-linux-tdep.c: Likewise.
2109         * amd64-tdep.c: Likewise.
2110         * i386-linux-tdep.c: Likewise.
2111         * i386-tdep.c: Likewise.
2112
2113 2019-07-03  Pedro Alves  <palves@redhat.com>
2114
2115         PR cli/24732
2116         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2117         (pipe_cmd_option_defs): New.
2118         (make_pipe_cmd_options_def_group): New.
2119         (pipe_command): Use gdb::option::process_options.
2120         (pipe_command_completer): New function.
2121         (_initialize_cli_cmds): Install completer for "pipe" command.
2122
2123 2019-07-03  Pedro Alves  <palves@redhat.com>
2124
2125         * cli/cli-option.c (union option_value) <string>: New field.
2126         (struct option_def_and_value): Add ctor, move ctor, dtor and
2127         use DISABLE_COPY_AND_ASSIGN.
2128         (option_def_and_value::clear_value): New.
2129         (parse_option, save_option_value_in_ctx, get_val_type_str)
2130         (add_setshow_cmds_for_options): Handle var_string.
2131         * cli-option.h (union option_def::var_address) <string>: New
2132         field.
2133         (struct string_option_def): New.
2134         * maint-test-options.c (struct test_options_opts): Add default
2135         ctor and use DISABLE_COPY_AND_ASSIGN.
2136         <string_opt>: New field.
2137         (test_options_opts::~test_options_opts): New.
2138         (test_options_opts::dump): Also dump "-string".
2139         (test_options_option_defs): Install "string.
2140
2141 2019-07-03  Pedro Alves  <palves@redhat.com>
2142
2143         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2144         option_value with a null enumeration.
2145         (complete_options): Save the option values in the context.
2146         (save_option_value_in_ctx): New, factored out from ...
2147         (process_options): ... here.
2148         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2149         of the function.
2150         * maint-test-options.c (test_options_opts::dump): New, factored
2151         out from ...
2152         (maintenance_test_options_command_mode): ... here.
2153         (maintenance_test_options_command_completion_result): Delete.
2154         (maintenance_test_options_command_completion_text): Update
2155         comment.
2156         (maintenance_show_test_options_completion_result): Change
2157         prototype.  Just print
2158         maintenance_test_options_command_completion_text.
2159         (save_completion_result): New.
2160         (maintenance_test_options_completer_mode): Pass options context to
2161         complete_options, and then save a dump.
2162         (_initialize_maint_test_options): Use add_cmd to install "maint
2163         show test-options-completion-result".
2164
2165 2019-07-03  Pedro Alves  <palves@redhat.com>
2166
2167         * NEWS (New commands): Mention "with" and "maint with".
2168         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2169         (with_command, with_command_completer): New.
2170         (pipe_command): Adjust to new repeat_previous
2171         interface.
2172         (_initialize_cli_cmds): Install the "with" command and its "w"
2173         alias.
2174         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2175         declarations.
2176         * cli/cli-setshow.c (parse_cli_var_uinteger)
2177         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2178         argument strings for all var_types.
2179         (get_setshow_command_value_string): New, factored out from ...
2180         (do_show_command): ... this.
2181         * cli/cli-setshow.h: Include <string>.
2182         (get_setshow_command_value_string): Declare.
2183         * command.h (repeat_previous): Now returns const char *.  Adjust
2184         comment.
2185         * maint.c: Include "cli/cli-cmds.h".
2186         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2187         (_initialize_maint_cmds): Register the "maintenance with" command.
2188         * top.c (repeat_previous): Move bits from pipe_command here:
2189         Return the saved command line, if any; error out if there's no
2190         command to relaunch.
2191
2192 2019-07-03  Pedro Alves  <palves@redhat.com>
2193
2194         * NEWS (New commands): Mention "maint set/show test-settings"
2195         instead of "maint test-settings".
2196         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2197         (maintenance_test_settings_set_list): Rename to ...
2198         (maintenance_set_test_settings_list): ... this.
2199         (maintenance_test_settings_show_list): Rename to  ...
2200         (maintenance_show_test_settings_list): ... this.
2201         (maintenance_test_settings_cmd): Delete.
2202         (maintenance_test_settings_set_cmd): ...
2203         (maintenance_set_test_settings_cmd): ... this.
2204         (maintenance_test_settings_show_cmd): ...
2205         (maintenance_show_test_settings_cmd): ... this.
2206         (maintenance_test_settings_show_value_cmd):
2207         (maintenance_show_test_settings_value_cmd): ... this.
2208         (_initialize_maint_test_settings): No longer install the "maint
2209         test-settings" prefix command.  Rename "maint test-settings set"
2210         to "maint set test-settings", and "maint test-settings show" to
2211         "maint show test-settings".  Adjust all subcommands.
2212
2213 2019-07-03  Pedro Alves  <palves@redhat.com>
2214
2215         * maint-test-settings.c: Fix file's intro comment.  Replace all
2216         references to "test-options" with references to "test-settings",
2217         in comments.
2218
2219 2019-07-03  Pedro Alves  <palves@redhat.com>
2220
2221         * maint-test-settings.c (maintenance_test_settings_xxx)
2222         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2223         New.
2224         (maintenance_test_settings_enums): Use them.
2225         (maintenance_test_settings_enum): Default to
2226         maintenance_test_settings_xxx.
2227         (_initialize_maint_test_settings): Initialize
2228         MAINTENANCE_TEST_SETTINGS_FILENAME.
2229
2230 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2231
2232         * breakpoint.h (remove_breakpoints_inf): Change return type to
2233         void, move function documentation here.
2234         * breakpoint.c (remove_breakpoints_inf): Change return type to
2235         void, move function documentation to header.
2236
2237 2019-07-02  Pedro Alves  <palves@redhat.com>
2238
2239         * NEWS (Completion improvements): Mention "info threads".
2240         * thread.c (struct info_threads_opts, info_threads_option_defs)
2241         (make_info_threads_options_def_group): New.
2242         (info_threads_command): Use gdb::option::process_options.
2243         (info_threads_command_completer): New.
2244         (_initialize_thread): Use gdb::option::build_help to build the
2245         help text for "info threads".
2246
2247 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2248
2249         * defs.h (generic_load): Move from here...
2250         * symfile.h (generic_load): ... to here.  Rename name parameter
2251         to args.
2252         * symfile.c (generic_load): Add comment.
2253
2254 2019-07-01  Tom Tromey  <tromey@adacore.com>
2255
2256         * dwarf2read.c
2257         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2258         declaration of without_params.  Fix formatting.
2259
2260 2019-07-01  Tom Tromey  <tromey@adacore.com>
2261
2262         * ada-exp.y (find_primitive_type): Update.
2263         * ada-lang.h (ada_lookup_symbol): Update.
2264         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2265         parameter.
2266         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2267
2268 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2269
2270         PR breakpoints/24541
2271         * gdbarch.c: Regenerate.
2272         * gdbarch.h: Regenerate.
2273         * gdbarch.sh: Add 'stap_adjust_register'.
2274         * i386-tdep.c: Include '<unordered_set>'.
2275         (i386_stap_adjust_register): New function.
2276         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2277         * stap-probe.c (stap_parse_register_operand): Call
2278         'gdbarch_stap_adjust_register'.
2279
2280 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2281
2282         PR python/24742
2283         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2284         * python/python.c (do_start_initialization): Use 'xmalloc'
2285         instead of 'PyMem_Malloc'.
2286
2287 2019-06-28  Tom Tromey  <tromey@adacore.com>
2288
2289         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2290         for Ada.
2291
2292 2019-06-27  Tom Tromey  <tromey@adacore.com>
2293
2294         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2295         objfile_key.
2296         (arm_find_mapping_symbol, arm_record_special_symbol)
2297         (_initialize_arm_tdep): Update.
2298         (arm_objfile_data_free): Remove.
2299
2300 2019-06-27  Tom Tromey  <tromey@adacore.com>
2301
2302         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2303         to cp_print_static_field.
2304
2305 2019-06-26  Tom Tromey  <tromey@adacore.com>
2306
2307         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2308         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2309         declare.
2310
2311 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2312
2313         * features/aarch64-core.c (create_feature_aarch64_core):
2314         Regenerate.
2315         * features/aarch64-core.xml: Add cpsr flags.
2316
2317 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2318
2319         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2320         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2321
2322 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2323
2324         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2325         field.
2326         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2327         use.
2328         (arm_record_special_symbol): Don't insert new symbol in sorted
2329         position, push it at the end.
2330
2331 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2332
2333         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2334         (arm_mapping_symbol_s): Remove.
2335         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2336         (arm_mapping_symbol_vec): New typedef.
2337         (struct arm_per_objfile): Add constructor.
2338         <section_maps>: Change type to
2339         std::unique_ptr<arm_mapping_symbol_vec[]>.
2340         (arm_compare_mapping_symbols): Remove.
2341         (arm_find_mapping_symbol): Adjust to section_maps type change.
2342         (arm_objfile_data_free): Call delete on arm_per_objfile.
2343         (arm_record_special_symbol): Adjust to section_maps type change.
2344         Allocate arm_per_objfile with new.
2345
2346 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2347
2348         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2349         with the command prefix.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2354         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2355
2356 2019-06-25  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2359         type.
2360         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2361         protected.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-winsource.c
2366         (tui_source_window_base::set_is_exec_point_at): Add check against
2367         LOA_ADDRESS.
2368
2369 2019-06-25  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-source.c (tui_set_source_content): Don't check before
2372         xfree.
2373         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.h (tui_update_source_window_as_is)
2378         (tui_alloc_source_buffer, tui_line_is_displayed)
2379         (tui_addr_is_displayed): Change type of win_info.
2380         * tui/tui-winsource.c (tui_update_source_window_as_is)
2381         (tui_clear_source_content, tui_show_source_line)
2382         (tui_show_source_content, tui_source_window_base::refill)
2383         (tui_source_window_base::set_is_exec_point_at)
2384         (tui_source_window_base::set_is_exec_point_at)
2385         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2386         (tui_alloc_source_buffer, tui_line_is_displayed)
2387         (tui_addr_is_displayed): Change type of win_info.  Update.
2388         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2389         (tui_source_window_base::do_make_visible_with_new_height):
2390         Update.
2391         * tui/tui-source.c (tui_set_source_content)
2392         (tui_set_source_content_nil)
2393         (tui_source_window::do_scroll_vertical): Update.
2394         * tui/tui-layout.c (show_layout): Update.
2395         * tui/tui-disasm.c (tui_set_disassem_content)
2396         (tui_disasm_window::do_scroll_vertical): Update.
2397         * tui/tui-data.h (tui_win_content): Remove.
2398         (struct tui_gen_win_info) <content, content_size>: Remove.
2399         (struct tui_source_element): Add initializers and destructor.
2400         (union tui_which_element, struct tui_win_element): Remove.
2401         (struct tui_source_window_base) <content>: New field.
2402         (struct tui_data_window): Remove destructor.
2403         (tui_alloc_content, tui_free_win_content)
2404         (tui_free_all_source_wins_content): Don't declare.
2405         * tui/tui-data.c (tui_initialize_static_data): Update.
2406         (init_content_element, tui_alloc_content): Remove.
2407         (~tui_gen_win_info): Update.
2408         (~tui_data_window, tui_free_all_source_wins_content)
2409         (tui_free_win_content, free_content, free_content_elements):
2410         Remove.
2411
2412 2019-06-25  Tom Tromey  <tom@tromey.com>
2413
2414         * tui/tui-winsource.h (tui_clear_source_content)
2415         (tui_erase_source_content, tui_show_source_content): Change type
2416         of win_info.
2417         * tui/tui-winsource.c (tui_clear_source_content)
2418         (tui_erase_source_content, tui_show_source_content): Change type
2419         of win_info.
2420         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2421         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2422         win_info.
2423         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2424         win_info.
2425         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2426
2427 2019-06-25  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-winsource.c (tui_clear_source_content)
2430         (tui_source_window_base::set_is_exec_point_at): Update.
2431         * tui/tui-source.c (tui_set_source_content_nil): Update.
2432         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2433         a bool.
2434         * tui/tui-data.c (init_content_element): Update.
2435
2436 2019-06-25  Tom Tromey  <tom@tromey.com>
2437
2438         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2439         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2440         * tui/tui-layout.c (init_and_make_win): Update.
2441         * tui/tui.h (enum tui_win_type): Update.
2442         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2443         tui_win_is_auxillary.
2444         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2445         tui_win_is_auxillary.
2446
2447 2019-06-25  Tom Tromey  <tom@tromey.com>
2448
2449         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2450         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2451         (tui_delete_data_content_windows, tui_display_all_data)
2452         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2453         Update.
2454         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2455         * tui/tui-regs.c (tui_last_regs_line_no)
2456         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2457         (tui_show_registers): Update.
2458         (tui_show_register_group): Return void.  Update.
2459         (tui_display_registers_from, tui_display_reg_element_at_line)
2460         (tui_display_registers_from_line, tui_check_register_values):
2461         Update.
2462         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2463         member.
2464         (struct tui_data_window) <regs_content>: Now a std::vector.
2465         <regs_content_count>: Remove.
2466         (tui_add_content_elements, tui_free_data_content): Don't declare.
2467         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2468         (init_content_element): Remove DATA_WIN case.  Add assert.
2469         (tui_add_content_elements): Remove.
2470         (tui_data_window): Update.
2471         (tui_free_data_content): Remove.
2472         (free_content_elements): Remove DATA_WIN case.
2473
2474 2019-06-25  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-data.c (tui_data_item_window): Update.
2477         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2478         * tui/tui-windata.c (tui_display_all_data)
2479         (tui_display_data_from_line): Update.
2480         (tui_check_data_values): Remove.
2481         * tui/tui-regs.c (tui_show_register_group)
2482         (tui_display_reg_element_at_line): Update.
2483         * tui/tui-hooks.c (tui_register_changed)
2484         (tui_refresh_frame_and_register_information): Call
2485         tui_check_register_values.
2486         * tui/tui-data.h (struct tui_data_window) <data_content,
2487         data_content_count, data_type>: Remove.
2488         (enum tui_data_type): Remove.
2489
2490         * tui/tui-data.c (tui_data_window::clear_detail)
2491         (~tui_data_window): Update.
2492
2493 2019-06-25  Tom Tromey  <tom@tromey.com>
2494
2495         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2496         declare.
2497         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2498         Rename from tui_first_data_item_displayed.  Update.
2499         (tui_data_window::refresh_all)
2500         (tui_data_window::do_scroll_vertical): Update.
2501         * tui/tui-data.h (struct tui_data_window)
2502         <first_data_item_displayed>: Declare new method.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2507         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2508         contents...
2509         (tui_initialize_static_data): ...here.
2510
2511 2019-06-25  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2514         (tui_display_registers_from, tui_check_register_values): Update.
2515         (tui_display_register): Remove win_info parameter; update.
2516         (tui_get_register): Change type of parameters.
2517         * tui/tui-data.h (struct tui_data_element): Remove.
2518         (union tui_which_element) <data>: Remove.
2519         <data_window>: Change type.
2520         (struct tui_data_item_window): New.
2521         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2522         case.  Add assert.
2523         (~tui_data_item_window): New destructor.
2524         (free_content_elements): Remove DATA_ITEM_WIN case.
2525
2526 2019-06-25  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2529         Remove.
2530
2531 2019-06-25  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-data.h (struct tui_command_element): Remove.
2534         (union tui_which_element) <command>: Remove.
2535         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2536         assert.
2537         (free_content_elements): Remove CMD_WIN case.
2538
2539 2019-06-25  Tom Tromey  <tom@tromey.com>
2540
2541         * tui/tui-layout.c (tui_set_layout): Update.
2542         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2543         * tui/tui-data.c (layout_def): Update.
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2549         (tui_source_window_base::set_new_height): Update.
2550         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2551         Update.
2552         (tui_set_locator_fullname, tui_set_locator_info)
2553         (tui_show_frame_info): Update.
2554         * tui/tui-source.c (tui_set_source_content)
2555         (tui_source_is_displayed): Update.
2556         * tui/tui-layout.c (show_source_disasm_command, show_data)
2557         (show_source_or_disasm_and_command): Update.
2558         * tui/tui-disasm.c (tui_set_disassem_content)
2559         (tui_get_begin_asm_address): Update.
2560         * tui/tui-data.h (struct tui_locator_element): Remove.
2561         (union tui_which_element) <locator>: Remove.
2562         (struct tui_locator_window): New.
2563         (tui_locator_win_info_ptr): Change return type.
2564         * tui/tui-data.c (_locator): Change type.
2565         (tui_locator_win_info_ptr): Change return type.
2566         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2567         (tui_alloc_content): Add assert.
2568
2569 2019-06-25  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-winsource.c
2572         (tui_exec_info_window::maybe_allocate_content): New method.
2573         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2574         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2575         (make_source_or_disasm_window): Add cast.
2576         * tui/tui-data.h (union tui_which_element) <simple_string>:
2577         Remove.
2578         (struct tui_source_info): New.
2579         (struct tui_source_window_base) <execution_info>: Change type.
2580         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2581         case, and add assert.
2582         (tui_alloc_content): Add assert.
2583
2584 2019-06-25  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2587         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2588         * tui/tui-data.c (tui_alloc_win_info): Remove.
2589
2590 2019-06-25  Tom Tromey  <tom@tromey.com>
2591
2592         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2593         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2594         can_highlight.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2599         make_visible_with_new_height method.
2600         (tui_win_info::make_visible_with_new_height): New method.
2601         (tui_source_window_base::do_make_visible_with_new_height)
2602         (tui_data_window::do_make_visible_with_new_height)
2603         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2604         (make_visible_with_new_height): Remove.
2605         (tui_resize_all, tui_adjust_win_heights): Use
2606         make_visible_with_new_height method.
2607         * tui/tui-data.h (struct tui_win_info)
2608         <do_make_visible_with_new_height, make_visible_with_new_height>:
2609         New methods.
2610         (struct tui_source_window_base, struct tui_data_window)
2611         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2612         methods.
2613
2614 2019-06-25  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2617         method.
2618         (update_tab_width): Call update_tab_width method.
2619         * tui/tui-data.h (struct tui_win_info)
2620         (struct tui_source_window_base) <update_tab_width>: New methods.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2625         parameter.
2626         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2627         parameter.
2628         (tui_gen_win_info::make_visible): Update.
2629         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2630         parameter.
2631         * tui/tui-data.h (enum tui_box): New enum.
2632         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2633
2634 2019-06-25  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2637         init_and_make_win for EXEC_INFO_WIN.
2638         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2639         longer inline.
2640         (struct tui_win_info) <~tui_win_info>: Inline.
2641         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2642         Don't declare.
2643         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2644         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2645         Remove.
2646         (tui_initialize_static_data): Update.
2647         (~tui_gen_win_info): Handle more cleanup here.
2648         (~tui_source_window_base): Delete "execution_info".
2649         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-layout.c (make_command_window): Don't set
2654         can_highlight.
2655         (show_source_disasm_command): Call the reset method.
2656         (show_data): Don't set can_highlight.  Call the reset method.
2657         (tui_gen_win_info::reset): Rename from init_gen_win_info
2658         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2659         (show_source_or_disasm_and_command): Call the reset method.
2660         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2661         (struct tui_cmd_window): Set can_highlight.
2662
2663 2019-06-25  Tom Tromey  <tom@tromey.com>
2664
2665         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2666         from make_visible.
2667         (tui_make_visible, tui_make_invisible): Rewrite.
2668         (tui_win_info::make_visible): Remove.
2669         (tui_source_window_base::make_visible): Update.
2670         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2671         method.  Moved from...
2672         (struct tui_win_info) <make_visible>: ...here.
2673
2674 2019-06-25  Tom Tromey  <tom@tromey.com>
2675
2676         * tui/tui-winsource.c
2677         (tui_source_window_base::do_scroll_horizontal): Remove direction
2678         parameter.
2679         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2680         direction parameter.
2681         * tui/tui-win.c (tui_win_info::forward_scroll)
2682         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2683         (tui_win_info::right_scroll): Update.
2684         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2685         direction parameter.
2686         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2687         direction parameter.
2688         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2689         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2690         Remove direction parameter.
2691         (struct tui_source_window_base, struct tui_source_window)
2692         (struct tui_disasm_window, struct tui_data_window)
2693         (struct tui_cmd_window): Update.
2694
2695 2019-06-25  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-winsource.h (tui_set_exec_info_content)
2698         (tui_show_exec_info_content, tui_erase_exec_info_content)
2699         (tui_clear_exec_info_content, tui_update_exec_info): Change
2700         argument to tui_source_window_base.
2701         * tui/tui-winsource.c (tui_set_exec_info_content)
2702         (tui_show_exec_info_content, tui_erase_exec_info_content)
2703         (tui_clear_exec_info_content, tui_update_exec_info): Change
2704         argument to tui_source_window_base.
2705
2706 2019-06-25  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2709         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2714         check.
2715
2716 2019-06-25  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2719         type to void.
2720         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2721         type to void.
2722         * tui/tui-source.c (tui_set_source_content): Update.
2723         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-win.c (window_name_completer, tui_set_focus)
2728         (tui_all_windows_info): Use name method.
2729         * tui/tui-data.h (struct tui_gen_win_info)
2730         (struct tui_source_window, struct tui_disasm_window)
2731         (struct tui_data_window, struct tui_cmd_window) <name>: New
2732         method.
2733         (tui_win_name): Don't declare.
2734         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2735         (tui_win_name): Remove.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-winsource.h (tui_update_source_window)
2740         (tui_update_source_window_as_is): Change parameter type.
2741         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2742         to be a tui_source_window_base.
2743         (tui_update_source_window_as_is): Likewise.
2744         * tui/tui-win.c (make_visible_with_new_height): Update.
2745
2746 2019-06-25  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-winsource.c (tui_erase_source_content)
2749         (tui_show_source_content, tui_show_exec_info_content)
2750         (tui_erase_exec_info_content): Use refresh_window method.
2751         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2752         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2753         from tui_refresh_win.
2754         (tui_data_window::refresh_window): New method.
2755         (tui_win_info::refresh, tui_source_window_base::refresh)
2756         (tui_refresh_all): Use refresh_window method.
2757         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2758         method.
2759         * tui/tui-regs.c (tui_display_register): Call refresh_window
2760         method.
2761         * tui/tui-layout.c (show_source_disasm_command)
2762         (show_source_or_disasm_and_command): Call refresh_window method.
2763         * tui/tui-data.h (struct tui_gen_win_info)
2764         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2765         New method.
2766
2767 2019-06-25  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui.c (tui_rl_other_window, tui_enable)
2770         (tui_is_window_visible, tui_get_command_dimension): Update.
2771         * tui/tui-winsource.c (tui_update_source_window_as_is)
2772         (tui_clear_source_content, tui_erase_source_content)
2773         (tui_show_source_line, tui_source_window_base::refill)
2774         (tui_source_window_base::do_scroll_horizontal)
2775         (tui_source_window_base::set_is_exec_point_at)
2776         (tui_update_breakpoint_info, tui_set_exec_info_content)
2777         (tui_alloc_source_buffer, tui_line_is_displayed)
2778         (tui_addr_is_displayed): Update.
2779         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2780         (tui_check_and_display_highlight_if_needed)
2781         (tui_win_info::make_visible, tui_win_info::refresh)
2782         (tui_refresh_all): Update.
2783         * tui/tui-windata.c (tui_first_data_item_displayed)
2784         (tui_delete_data_content_windows, tui_erase_data_content)
2785         (tui_display_all_data, tui_data_window::refresh_all)
2786         (tui_check_data_values): Update.
2787         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2788         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2789         (tui_win_info::backward_scroll, tui_refresh_all_win)
2790         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2791         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2792         (tui_source_window_base::set_new_height)
2793         (tui_data_window::set_new_height)
2794         (make_invisible_and_set_new_height)
2795         (make_visible_with_new_height, new_height_ok)
2796         (parse_scrolling_args): Update.
2797         * tui/tui-stack.c (tui_show_frame_info): Update.
2798         * tui/tui-source.c (tui_set_source_content)
2799         (tui_set_source_content_nil, tui_source_is_displayed)
2800         (tui_source_window::do_scroll_vertical): Update.
2801         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2802         (tui_display_registers_from, tui_display_reg_element_at_line)
2803         (tui_check_register_values, tui_reg_command): Update.
2804         * tui/tui-layout.c (tui_default_win_height)
2805         (show_source_disasm_command, show_data, init_and_make_win)
2806         (show_source_or_disasm_and_command): Update.
2807         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2808         (tui_redisplay_readline, tui_mld_flush)
2809         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2810         (tui_getc): Update.
2811         * tui/tui-disasm.c (tui_set_disassem_content)
2812         (tui_disasm_window::do_scroll_vertical): Update.
2813         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2814         Now virtual.
2815         (struct tui_win_info): Derive from tui_gen_win_info.
2816         <~tui_win_info>: Mark as override.
2817         <generic>: Remove member.
2818         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2819         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2820         (~tui_data_window, ~tui_win_info)
2821         (tui_free_all_source_wins_content): Update.
2822         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2823
2824 2019-06-25  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (init_and_make_win): Use new.
2827         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2828         destructor, initializers.
2829         (tui_alloc_generic_win_info): Don't declare.
2830         * tui/tui-data.c (_locator): Add argument to constructor.
2831         (source_win, disasm_win): New globals.
2832         (exec_info): Remove.
2833         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2834         Update.
2835         (tui_alloc_generic_win_info): Remove.
2836         (init_content_element): Use new.
2837         (tui_win_info::tui_win_info): Update.
2838         (free_content_elements) <case DATA_WIN>: Use delete.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2843         * tui/tui-windata.c (tui_first_data_item_displayed)
2844         (tui_delete_data_content_windows): Update.
2845         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2846         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2847         (tui_display_registers_from, tui_check_register_values): Update.
2848         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2849         pointer.
2850         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2851         window.
2852         (tui_free_data_content): Update.
2853         (free_content_elements) <case DATA_WIN>: Free the window.
2854
2855 2019-06-25  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2858         Update.
2859         * tui/tui-layout.c (make_command_window)
2860         (show_source_disasm_command, show_data, init_and_make_win)
2861         (show_source_or_disasm_and_command): Update.
2862         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2863         method.
2864         <can_highight, is_highlighted>: Now bool.
2865         (tui_set_win_highlight): Don't declare.
2866         * tui/tui-data.c (tui_set_win_highlight): Remove.
2867
2868 2019-06-25  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-wingeneral.c (make_visible): Remove check of window
2871         type.
2872
2873 2019-06-25  Tom Tromey  <tom@tromey.com>
2874
2875         * tui/tui-win.c (tui_win_info::max_height)
2876         (tui_cmd_window::max_height): New methods.
2877         (new_height_ok): Call max_height.
2878         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2879         <max_height>: New method.
2880
2881 2019-06-25  Tom Tromey  <tom@tromey.com>
2882
2883         * tui/tui-win.c (tui_source_window_base::set_new_height)
2884         (tui_data_window::set_new_height): New methods.
2885         (make_invisible_and_set_new_height): Call set_new_height method.
2886         * tui/tui-data.h (struct tui_win_info)
2887         (struct tui_source_window_base, struct tui_data_window)
2888         <set_new_height>: New method.
2889
2890 2019-06-25  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2893         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2894         tui_refresh_data_win.
2895         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2896         method.
2897         (tui_refresh_all_win): Call the refresh_all method.
2898         (tui_set_focus): Likewise.
2899         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2900         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2901         Likewise.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-winsource.h (tui_refill_source_window)
2906         (tui_set_is_exec_point_at): Don't declare.
2907         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2908         (tui_source_window_base::refill): Rename from
2909         tui_refill_source_window.
2910         (tui_source_window_base::do_scroll_horizontal): Update.
2911         (tui_source_window_base::set_is_exec_point_at): Rename from
2912         tui_set_is_exec_point_at.
2913         (tui_update_all_breakpoint_info): Update.
2914         * tui/tui-stack.c (tui_show_frame_info): Update.
2915         * tui/tui-layout.c (show_data): Add cast.
2916         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2917         * tui/tui-data.h (struct tui_source_window_base) <refill,
2918         set_is_exec_point_at>: New methods.
2919         (tui_source_windows, tui_add_to_source_windows): Update types.
2920         (tui_add_to_source_windows): Remove redundant declaration.
2921         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2922         (tui_source_windows): Change return type.
2923         (tui_clear_source_windows_detail): Update.
2924         (tui_add_to_source_windows): Change type of parameter.
2925         (tui_free_all_source_wins_content): Update.
2926
2927 2019-06-25  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-wingeneral.c (tui_win_info::refresh)
2930         (tui_source_window_base::refresh): New methods.
2931         (tui_refresh_all): Call the refresh method.
2932         * tui/tui-data.h (struct tui_win_info)
2933         (struct tui_source_window_base) <refresh>: New method.
2934
2935 2019-06-25  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui.h (tui_is_window_visible): Return bool.
2938         * tui/tui.c (tui_is_window_visible): Return bool.
2939         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2940         (tui_make_visible, tui_make_invisible)
2941         (tui_win_info::make_visible)
2942         (tui_source_window_base::make_visible, make_all_visible)
2943         (tui_make_all_visible, tui_make_all_invisible): Update.
2944         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2945         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2946         bool.
2947         (struct tui_win_info, struct tui_source_window_base)
2948         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2949         * tui/tui-data.c (tui_init_generic_part): Update.
2950
2951 2019-06-25  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2954         (tui_source_window_base::make_visible): New methods.
2955         (make_all_visible): Make method call.
2956         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2957         (struct tui_source_window_base, struct tui_cmd_window): Override
2958         make_visible.
2959         (tui_win_is_source_type): Don't declare.
2960         * tui/tui-data.c (tui_win_is_source_type): Remove.
2961
2962 2019-06-25  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2965         NULL check.
2966
2967 2019-06-25  Tom Tromey  <tom@tromey.com>
2968
2969         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2970         Inline constructor.  Add initializers for members.
2971         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2972         constructors; now inline in class.
2973
2974 2019-06-25  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-regs.c (tui_show_registers): Update.
2977         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2978         bool.
2979         * tui/tui-data.c (tui_data_window::clear_detail)
2980         (tui_data_window): Update.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-windata.c (tui_display_all_data)
2985         (tui_display_data_from_line, tui_display_data_from)
2986         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2987         Update.
2988         * tui/tui-regs.c (tui_last_regs_line_no)
2989         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2990         (tui_show_registers, tui_show_register_group)
2991         (tui_display_registers_from, tui_display_reg_element_at_line)
2992         (tui_display_registers_from_line, tui_check_register_values)
2993         (tui_reg_next, tui_reg_prev): Update.
2994         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2995         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2996         tui_data_window.
2997         (struct tui_win_info) <detail>: Remove.  Add new fields from
2998         tui_data_info.
2999         (TUI_DATA_WIN): Add cast.
3000         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3001         (~tui_data_window): Simplify.
3002
3003 2019-06-25  Tom Tromey  <tom@tromey.com>
3004
3005         * tui/tui-layout.c (show_source_disasm_command)
3006         (show_source_or_disasm_and_command): Update.
3007         * tui/tui-io.c (update_cmdwin_start_line)
3008         (tui_redisplay_readline): Update.
3009         * tui/tui-data.h (struct tui_command_info): Remove.
3010         (struct tui_win_info) <detail>: Remove command_info member.
3011         (struct tui_data_window) <start_line>: New member, from
3012         tui_command_info.
3013         (TUI_CMD_WIN): Add casts.
3014
3015 2019-06-25  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-winsource.c (tui_update_source_window)
3018         (tui_refill_source_window)
3019         (tui_source_window_base::do_scroll_horizontal)
3020         (tui_update_breakpoint_info, tui_set_exec_info_content)
3021         (tui_show_exec_info_content, tui_erase_exec_info_content)
3022         (tui_clear_exec_info_content): Update.
3023         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3024         Update.
3025         * tui/tui-win.c (make_invisible_and_set_new_height)
3026         (make_visible_with_new_height): Update.
3027         * tui/tui-source.c (tui_set_source_content)
3028         (tui_show_symtab_source): Update.
3029         * tui/tui-layout.c (extract_display_start_addr)
3030         (show_source_disasm_command, show_data)
3031         (make_source_or_disasm_window)
3032         (show_source_or_disasm_and_command): Update.
3033         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3034         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3035         "gdbarch".
3036         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3037         to tui_source_window_base.
3038         (struct tui_win_info) <detail>: Remove source_info member.
3039         (struct tui_source_window_base) <has_locator>: Inline.
3040         Move contents from tui_source_info; rename has_locator member to
3041         m_has_locator.
3042         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3043         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3044         header file.
3045         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3046         Simplify.
3047         (tui_free_all_source_wins_content): Cast to
3048         tui_source_window_base.
3049
3050 2019-06-25  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-win.c (make_invisible_and_set_new_height)
3053         (make_visible_with_new_height): Call has_locator method.
3054         * tui/tui-layout.c (show_source_disasm_command, show_data)
3055         (show_source_or_disasm_and_command): Update for bool change.
3056         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3057         (tui_win_info) <has_locator>: New method.
3058         (struct tui_source_window_base) <has_locator>: New method.
3059         (tui_win_has_locator): Don't declare.
3060         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3061         from tui_win_has_locator.
3062         (tui_source_window_base): Use false, not FALSE.
3063
3064 2019-06-25  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3067         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3068         clear_detail method directly.
3069         (tui_clear_win_detail): Remove.
3070
3071 2019-06-25  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3074         "this", not TUI_DISASM_WIN.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3079         declare.
3080         * tui/tui-winsource.c
3081         (tui_source_window_base::do_scroll_horizontal): Rename from
3082         tui_horizontal_source_scroll.
3083         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3084         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3085         from tui_vertical_data_scroll.
3086         * tui/tui-win.h (tui_scroll): Don't declare.
3087         * tui/tui-win.c (tui_win_info::forward_scroll)
3088         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3089         (tui_win_info::right_scroll): Rename and update.
3090         (tui_scroll_forward_command, tui_scroll_backward_command)
3091         (tui_scroll_left_command, tui_scroll_right_command): Update.
3092         (tui_scroll): Remove.
3093         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3094         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3095         from tui_vertical_source_scroll.
3096         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3097         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3098         from tui_vertical_disassem_scroll.
3099         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3100         do_scroll_horizontal>: New methods.
3101         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3102         Likewise.
3103         (struct tui_source_window_base): Add do_scroll_horizontal.
3104         (struct tui_source_window, struct tui_disasm_window): Add
3105         do_scroll_vertical.
3106         (struct tui_data_window, struct tui_cmd_window): Add
3107         do_scroll_horizontal and do_scroll_vertical.
3108         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3109
3110 2019-06-25  Tom Tromey  <tom@tromey.com>
3111
3112         * tui/tui-data.h (struct tui_source_window_base): New struct.
3113         (struct tui_source_window): Derive from tui_source_window_base.
3114         (struct tui_disasm_window): New struct.
3115         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3116         from tui_source_window::clear_detail.
3117         (tui_source_window_base): Rename from tui_source_window.
3118         (~tui_source_window_base): Rename from ~tui_source_window.
3119         (tui_alloc_win_info): Create a tui_disasm_window.
3120
3121 2019-06-25  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-data.h (struct tui_source_window)
3124         (struct tui_data_window): Declare destructors.
3125         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3126         destructors.
3127         (tui_win_info): Simplify.
3128
3129 2019-06-25  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-winsource.c (tui_display_main)
3132         (tui_update_source_windows_with_addr)
3133         (tui_update_all_breakpoint_info): Update.
3134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3135         (new_height_ok, parse_scrolling_args): Update.
3136         * tui/tui-stack.c (tui_show_frame_info): Update.
3137         * tui/tui-data.h (struct tui_list): Remove.
3138         (tui_source_windows): Return a reference to a std::vector.
3139         * tui/tui-data.c (source_windows): Now a std::vector.
3140         (tui_source_windows): Change return type.
3141         (tui_clear_source_windows): Rewrite.
3142         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3143         (tui_free_all_source_wins_content): Rewrite.
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3148         (struct tui_data_window, struct tui_cmd_window): Declare
3149         clear_detail method.
3150         * tui/tui-data.c (tui_source_window::clear_detail)
3151         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3152         methods.
3153         (tui_clear_win_detail): Simplify.
3154
3155 2019-06-25  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-layout.c (make_source_window, make_disasm_window)
3158         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3159         Return the new window.
3160         (show_source_disasm_command, show_data)
3161         (show_source_or_disasm_and_command): Update.
3162
3163 2019-06-25  Tom Tromey  <tom@tromey.com>
3164
3165         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3166         parameter.  Return the new window.
3167         (show_source_disasm_command): Update and remove NULL check.
3168         (show_source_or_disasm_and_command): Update.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3173
3174 2019-06-25  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-data.h (struct tui_win_info): Make constructor
3177         protected.  Make destructor virtual.  Add initializers.
3178         (tui_source_window, tui_data_window, tui_cmd_window): New
3179         classes.
3180         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3181         constructor.  Add "type" parameter.
3182         (tui_source_window, tui_data_window, tui_cmd_window): New
3183         constructors.
3184         (tui_alloc_win_info): Instantiate the appropriate subclass.
3185
3186 2019-06-25  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-win.c (tui_resize_all): Use delete.
3189         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3190         destructor.
3191         (tui_free_window): Don't declare.
3192         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3193         Update.
3194
3195 2019-06-25  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-data.h (struct tui_win_info): Add constructor.
3198         * tui/tui-data.c (tui_alloc_win_info): Use new.
3199         (tui_free_window): Use delete.
3200
3201 2019-06-22  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3204         declare.
3205         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3206
3207 2019-06-22  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3210         declare.
3211         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3212
3213 2019-06-22  Tom de Vries  <tdevries@suse.de>
3214
3215         * dwarf2read.c (create_addrmap_from_aranges)
3216         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3217         instead of '%zu'.
3218
3219 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3220
3221         * dwarf2read.h (dwarf2_section_info_def): Remove.
3222         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3223         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3224         std::vector<dwarf2_section_info>.
3225         (struct dwo_file) <~dwo_file>: Remove.
3226         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3227         types field.
3228         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3229         (dwarf2_read_debug_names): Likewise.
3230         (create_debug_types_hash_table): Change parameter type to
3231         array_view, adjust code accordingly.
3232         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3233         (partial_die_info::fixup): Likewise.
3234         (determine_prefix): Likewise.
3235         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3236
3237 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3238
3239         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3240         gdb_bfd_ref_ptr.
3241         <~dwo_file>: Remove call to gdb_bfd_unref.
3242         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3243         gdb_bfd_ref_ptr::get.
3244
3245 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3246
3247         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3248         type to htab_up.
3249         * dwarf2read.c (struct dwo_file): Initialize fields.
3250         <~dwo_file>: New.
3251         (free_dwo_file): Remove, move content to ~dwo_file.
3252         (struct dwo_file_deleter): Remove.
3253         (dwo_file_up>: Remove custom deleter.
3254         (free_dwo_files): Remove.
3255         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3256         dwo_files.
3257         (process_skeletonless_type_units): Call unique_ptr::get.
3258         (allocate_dwo_file_hash_table): Add deleter to created hash
3259         table.  Change return type to htab_up.
3260         (lookup_dwo_file_slot): Don't memset dwo_file, call
3261         unique_ptr::get.
3262         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3263         (create_dwo_unit_in_dwp_v2): Likewise.
3264         (open_and_init_dwo_file): Likewise.
3265         (free_dwo_file_from_slot): Remove.
3266
3267 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3268
3269         * dwarf2read.h (struct dwarf2_section_info) <readin,
3270         is_virtual>: Change type to bool.
3271         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3272         true instead of 1.
3273
3274 2019-06-19  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-data.h (tui_init_content_element): Don't declare.
3277
3278 2019-06-19  Tom Tromey  <tom@tromey.com>
3279
3280         * tui/tui-data.h (tui_init_win_info): Don't declare.
3281
3282 2019-06-19  Tom de Vries  <tdevries@suse.de>
3283
3284         * dwarf2read.h (abstract_to_concrete): Change type to
3285         std::unordered_map<sect_offset, std::vector<sect_offset>,
3286         gdb::hash_enum<sect_offset>>.
3287
3288 2019-06-19  Tom Tromey  <tromey@adacore.com>
3289
3290         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3291         EVAL_AVOID_SIDE_EFFECTS specially.
3292
3293 2019-06-19  Tom Tromey  <tromey@adacore.com>
3294
3295         * source-cache.c (highlighter): New global.
3296         (source_cache::get_source_lines): Create a highlighter on demand.
3297
3298 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3299
3300         * defs.h (deprecated_interactive_hook): Delete declaration.
3301         * interps.c (clear_interpreter_hooks): Remove use of
3302         deprecated_interactive_hook.
3303         * top.c (deprecated_interactive_hook): Delete definition.
3304         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3305
3306 2019-06-18  Tom de Vries  <tdevries@suse.de>
3307
3308         PR gdb/24515
3309         * dwarf2read.h (abstract_to_concrete): Change type from
3310         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3311         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3312         * dwarf2read.c (read_variable): Update.
3313         (dwarf2_fetch_die_loc_sect_off): Update.
3314
3315 2019-06-17  Tom de Vries  <tdevries@suse.de>
3316
3317         PR gdb/24617
3318         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3319         accessing parent[parent_len - 1].
3320
3321 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3322
3323         PR gdb/24364
3324         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3325         call dtrace_process_dof with NULL dof.
3326
3327 2019-06-16  Tom de Vries  <tdevries@suse.de>
3328
3329         PR gdb/24445
3330         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3331
3332 2019-06-16  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3335         (make_all_visible): Use address of member.
3336
3337 2019-06-16  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3340         (tui_free_window, free_content, free_content_elements): Remove
3341         unnecessary cast.
3342         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3343         cast.
3344         * tui/tui-regs.c (tui_show_register_group)
3345         (tui_display_registers_from, tui_display_reg_element_at_line):
3346         Remove unnecessary cast.
3347
3348 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         * linux-nat.c (normal_mask): Delete.
3351         (_initialize_linux_nat): Don't initialise normal_mask.
3352
3353 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3354
3355         PR gdb/24445
3356         * dwarf-index-write.h (write_psymtabs_to_index): Add
3357         dwz_basename parameter.
3358         * dwarf-index-write.c (write_gdbindex): Move file writing to
3359         write_gdbindex_1.  Change return type void.
3360         (assert_file_size): Move up, remove filename parameter.
3361         (write_gdbindex_1): New function.
3362         (write_debug_names): Change return type to void, call
3363         assert_file_size.
3364         (struct index_wip_file): New struct.
3365         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3366         file logic to index_wip_file.  Write index for dwz file if
3367         needed.
3368         (save_gdb_index_command): Pass basename of dwz file, if present.
3369         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3370         build-id of dwz file, if present.
3371         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3372         (dwarf2_get_dwz_file): Likewise.
3373         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3374         (dwarf2_get_dwz_file): Likewise.
3375
3376 2019-06-16  Tom Tromey  <tom@tromey.com>
3377
3378         * coffread.c (process_coff_symbol): Use xstrdup.
3379         * value.c (create_internalvar): Use xstrdup.
3380
3381 2019-06-16  Tom Tromey  <tom@tromey.com>
3382
3383         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3384         * breakpoint.c (stopin_command, stopat_command)
3385         (until_break_command, decode_location_default): Remove unnecessary
3386         cast.
3387         * utils.c (subset_compare): Remove unnecessary cast.
3388         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3389         cast.
3390         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3391         cast.
3392         * infcmd.c (path_command): Remove unnecessary cast.
3393         * coffread.c (decode_type): Remove unnecessary cast.
3394         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3395         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3396         * tui/tui-stack.c (tui_show_locator_content)
3397         (tui_show_frame_info): Remove unnecessary cast.
3398         * tui/tui-win.c (tui_scroll_forward_command)
3399         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3400         (parse_scrolling_args): Remove unnecessary cast.
3401         * tui/tui-data.c (init_win_info, tui_del_window)
3402         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3403         (free_content_elements): Remove unnecessary cast.
3404         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3405         unnecessary cast.
3406         * tui/tui-source.c (tui_set_source_content)
3407         (tui_vertical_source_scroll): Remove unnecessary cast.
3408         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3409         cast.
3410         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3411         * tui/tui-regs.c (tui_display_registers_from)
3412         (tui_display_register): Remove unnecessary cast.
3413         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3414         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3415         (make_visible): Remove unnecessary cast.
3416         * tui/tui-winsource.c (tui_erase_source_content)
3417         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3418         unnecessary cast.
3419         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3420         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3421         * stabsread.c (read_type, read_array_type, read_range_type):
3422         Remove unnecessary cast.
3423         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3424         (parse_symbol, parse_type, upgrade_type, parse_external)
3425         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3426         unnecessary cast.
3427         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3428
3429 2019-06-16  Tom Tromey  <tom@tromey.com>
3430
3431         * tui/tui-data.c (tui_alloc_generic_win_info)
3432         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3433         checks.
3434
3435 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3436             Andrew Burgess  <andrew.burgess@embecosm.com>
3437
3438         * f-typeprint.c (f_print_type): Don't return early for not
3439         associated or not allocated types.
3440         (f_type_print_varspec_suffix): Add print_rank parameter and print
3441         ranks of array types in case they dangling.
3442         (f_type_print_base): Add print_rank parameter.
3443
3444 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * NEWS: Mention new MI commands.
3447         * break-catch-throw.c (enum exception_event_kind): Move to
3448         breakpoint.h.
3449         (print_mention_exception_catchpoint): Output text as a single
3450         message.
3451         (catch_exception_command_1): Rename to...
3452         (catch_exception_event): ...this, make non-static, update header
3453         command, and change some parameter types.
3454         (catch_catch_command): Update for changes to
3455         catch_exception_command_1.
3456         (catch_throw_command): Likewise.
3457         (catch_rethrow_command): Likewise.
3458         * breakpoint.c (enum exception_event_kind): Delete.
3459         * breakpoint.h (enum exception_event_kind): Moved here from
3460         break-catch-throw.c.
3461         (catch_exception_event): Declare.
3462         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3463         (mi_cmd_catch_throw): New function.
3464         (mi_cmd_catch_rethrow): New function.
3465         (mi_cmd_catch_catch): New function.
3466         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3467         'catch-catch' entries.
3468         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3469         (mi_cmd_catch_rethrow): Declare.
3470         (mi_cmd_catch_catch): Declare.
3471
3472 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * annotate.c (annotate_source_line): Change return type to void,
3475         update implementation to match.
3476         * annotate.h (annotate_source_line): Change return type to void,
3477         update header comment.
3478         * stack.c (print_frame_info): Don't change what frame information
3479         is printed based on whether annotations are on or not.
3480
3481 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3482
3483         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3484         (annotate_source): Make static.
3485         (annotate_source_line): Moved from source.c and renamed from
3486         identify_source_line.  Update the return type.
3487         * annotate.h (annotate_source): Delete declaration.
3488         (annotate_source_line): Declaration moved from source.h, and
3489         renamed from identify_source_line.  Return type updated.
3490         * source.c (identify_source_line): Moved to annotate.c and renamed
3491         to annotate_source_line.
3492         (info_line_command): Remove check of annotation_level.
3493         * source.h (identify_source_line): Move declaration to annotate.h
3494         and rename to annotate_source_line.
3495         * stack.c: Add 'annotate.h' include.
3496         (print_frame_info): Remove check of annotation_level before
3497         calling annotate_source_line.
3498
3499 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3500
3501         * source-cache.c (source_cache::get_plain_source_lines): Use
3502         open_source_file_with_line_charpos instead of just
3503         open_source_file, remove call to find_source_lines.
3504         (source_cache::get_source_lines): Likewise.
3505         * source.c (find_source_lines): Make static.
3506         (get_filename_and_charpos): Renamed into...
3507         (open_source_file_with_line_charpos): ..this along with changes to
3508         return a scoped_fd, and some other minor clean ups.
3509         (identify_source_line): Use open_source_file_with_line_charpos.
3510         (search_command_helper): Use open_source_file_with_line_charpos
3511         instead of just open_source_file, remove call to
3512         find_source_lines.
3513         * source.h (open_source_file_with_line_charpos): Declare new
3514         function.
3515         (find_source_lines): Delete declaration.
3516
3517 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * source.c (get_filename_and_charpos): Remove fullname
3520         parameter.
3521         (identify_source_line): Update call to get_filename_and_charpos.
3522
3523 2019-06-14  Tom Tromey  <tromey@adacore.com>
3524
3525         PR gdb/24502:
3526         * ui-style.h (skip_ansi_escape): Update comment.
3527         * ui-file.h (class no_terminal_escape_file): New class.
3528         * ui-file.c (no_terminal_escape_file::write)
3529         (no_terminal_escape_file::puts): New methods.
3530         * cli/cli-logging.c (handle_redirections): Use
3531         no_terminal_escape_file.
3532
3533 2019-06-14  Tom Tromey  <tromey@adacore.com>
3534
3535         * NEWS: Move convenience variable news above Python news.
3536
3537 2019-06-14  Tom Tromey  <tom@tromey.com>
3538
3539         * gnulib: Move directory to top-level.
3540         * configure.ac: Don't configure gnulib.
3541         * configure: Rebuild.
3542         * common/common-defs.h: Use new path to gnulib.
3543         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3544         (GNULIB_H): Remove.
3545         (INCGNU): Look in new gnulib location.
3546         (HFILES_NO_SRCDIR): Remove gnulib files.
3547         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3548         (generated_files): Remove GNULIB_H.
3549         ($(LIBGNU), all-lib): Remove targets.
3550         (distclean): Don't mention GNULIB_BUILDDIR.
3551         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3552
3553 2019-06-14  Tom Tromey  <tromey@adacore.com>
3554
3555         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3556         Warn if symbol file does not provide any symbols.
3557
3558 2019-06-14  Tom Tromey  <tromey@adacore.com>
3559
3560         * source.c (find_and_open_source): Respect basenames_may_differ.
3561
3562 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * annotate.c (annotate_breakpoints_invalid): Make use of
3565         scoped_restore_terminal_state.
3566         (annotate_frames_invalid): Likewise.
3567
3568 2019-06-14  Tom Tromey  <tromey@adacore.com>
3569
3570         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3571         allow assignment to an internalvar.
3572
3573 2019-06-14  Tom Tromey  <tromey@adacore.com>
3574
3575         * ada-lex.l: Allow "_" in attribute names.
3576
3577 2019-06-14  Tom Tromey  <tromey@adacore.com>
3578
3579         PR gdb/24653:
3580         * regcache.c (registers_changed): Don't call alloca.
3581         * top.c (execute_command): Don't call alloca.
3582
3583 2019-06-13  Pedro Alves  <palves@redhat.com>
3584
3585         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3586         'expression'.  When parsing an expression, error out if there's
3587         junk after "unlimited".
3588         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3589         (do_set_command): Adjust calls to is_unlimited_literal.
3590
3591 2019-06-13  Pedro Alves  <palves@redhat.com>
3592
3593         * compile/compile.c (make_compile_options_def_group): Add braces
3594         around array_view initializer.
3595         * thread.c (make_thread_apply_all_options_def_group)
3596         (make_thread_apply_all_options_def_group): Likewise.
3597
3598 2019-06-13  Pedro Alves  <palves@redhat.com>
3599
3600         * NEWS (New commands): Mention "maint test-options
3601         require-delimiter", "maint test-options unknown-is-error", "maint
3602         test-options unknown-is-operand" and "maint show
3603         test-options-completion-result".
3604         (New command options, command completion): New section.
3605         (Completion improvements): New section.
3606         Mention that you can abbreviate "unlimited".
3607
3608 2019-06-13  Pedro Alves  <palves@redhat.com>
3609
3610         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3611         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3612         * unittests/cli-utils-selftests.c (test_parse_flags)
3613         (test_parse_flags_qcs): Delete.
3614         (test_cli_utils): Don't call deleted functions.
3615
3616 2019-06-13  Pedro Alves  <palves@redhat.com>
3617
3618         * thread.c: Include "cli/cli-option.h".
3619         (tp_array_compar_ascending): Global.
3620         (tp_array_compar): Delete function.
3621         (tp_array_compar_ascending, tp_array_compar_descending): New
3622         functions.
3623         (ascending_option_def, qcs_flag_option_def)
3624         (thr_qcs_flags_option_defs)
3625         (make_thread_apply_all_options_def_group)
3626         (make_thread_apply_options_def_group): New.
3627         (thread_apply_all_command): Use gdb::option::process_options.
3628         (thread_apply_command_completer)
3629         (thread_apply_all_command_completer): New.
3630         (thread_apply_command): Use gdb::option::process_options.
3631         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3632         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3633         to generate help text of "thread apply".  Adjust "taas"'s help.
3634         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3635         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3636
3637 2019-06-13  Pedro Alves  <palves@redhat.com>
3638
3639         * thread.c (thread_apply_command): Check for invalid TID with
3640         isdigit instead of !isalpha.
3641
3642 2019-06-13  Pedro Alves  <palves@redhat.com>
3643
3644         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3645         (validate_flags_qcs): New.
3646         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3647         (validate_flags_qcs): Declare.
3648         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3649         (make_frame_apply_options_def_group): New.
3650         (frame_apply_command_count): Process options with
3651         gdb::option::process_options.
3652         (frame_apply_completer): New.
3653         (frame_apply_level_completer, frame_apply_all_completer)
3654         (frame_apply_completer): New.
3655         (_initialize_stack): Update help of "frame apply", "frame apply
3656         level", "frame apply all" and "faas" to mention supported options
3657         and install command completers.
3658         * stack.h (frame_apply_all_completer): Declare.
3659         * thread.c: Include "stack.h".
3660         (tfaas_command): Add "--".
3661         (_initialize_thread): Update help "tfaas" to mention supported
3662         options and install command completer.
3663
3664 2019-06-13  Pedro Alves  <palves@redhat.com>
3665
3666         * completer.c (complete_nested_command_line): New.
3667         (gdb_completion_word_break_characters_throw): Add assertion.
3668         * completer.h (complete_nested_command_line): Declare.
3669
3670 2019-06-13  Pedro Alves  <palves@redhat.com>
3671
3672         * stack.c (parse_backtrace_qualifiers): New.
3673         (backtrace_command): Use it.
3674         (backtrace_command_completer): Complete on qualifiers.
3675
3676 2019-06-13  Pedro Alves  <palves@redhat.com>
3677
3678         * frame.c: Include "cli/cli-option.h.
3679         (user_set_backtrace_options): New.
3680         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3681         Delete.
3682         (get_prev_frame): Adjust.
3683         (boolean_option_def, uinteger_option_def)
3684         (set_backtrace_option_defs): New.
3685         (_initialize_frame): Adjust and use
3686         gdb::option::add_setshow_cmds_for_options to install "set
3687         backtrace past-main" and "set backtrace past-entry".
3688         * frame.h: Include "cli/cli-option.h".
3689         (struct frame_print_options): Forward declare.
3690         (print_frame_arguments_all, print_frame_arguments_scalars)
3691         (print_frame_arguments_none): Declare.
3692         (print_entry_values): Delete declaration.
3693         (struct frame_print_options, user_frame_print_options): New.
3694         (struct set_backtrace_options): New.
3695         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3696         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3697         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3698         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3699         (list_args_or_locals): Add frame_print_options parameter.
3700         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3701         * python/py-framefilter.c (enumerate_args): Pass down
3702         USER_FRAME_PRINT_OPTIONS.
3703         * stack.c: Include "cli/cli-option.h".
3704         (print_frame_arguments_all, print_frame_arguments_scalars)
3705         (print_frame_arguments_none): Declare.
3706         (print_raw_frame_arguments, print_entry_values): Delete.
3707         (user_frame_print_options): New.
3708         (boolean_option_def, enum_option_def, frame_print_option_defs):
3709         New.
3710         (struct backtrace_cmd_options): New.
3711         (bt_flag_option_def): New.
3712         (backtrace_command_option_defs): New.
3713         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3714         (print_frame_arg, read_frame_arg, print_frame_args)
3715         (print_frame_info, print_frame): Add frame_print_options parameter
3716         and use it.
3717         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3718         (backtrace_command_1): Add frame_print_options and
3719         backtrace_cmd_options parameters and use them.
3720         (make_backtrace_options_def_group): New.
3721         (backtrace_command): Process command options with
3722         gdb::option::process_options.
3723         (backtrace_command_completer): New.
3724         (_initialize_stack): Extend "backtrace"'s help to mention
3725         supported options.  Install completer for "backtrace".
3726         Install some settings commands with add_setshow_cmds_for_options.
3727
3728 2019-06-13  Pedro Alves  <palves@redhat.com>
3729
3730         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3731         and that "set/show print raw frame-arguments" are now deprecated.
3732
3733         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3734         command.
3735         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3736         * stack.c (_initialize_stack): Install "set/show print
3737         raw-frame-arguments", and deprecate "set/show print raw
3738         frame-arguments".
3739         * valprint.c (_initialize_valprint): Deprecate "set/show print
3740         raw".
3741
3742 2019-06-13  Pedro Alves  <palves@redhat.com>
3743
3744         * compile/compile.c (struct compile_options): New.
3745         (compile_flag_option_def, compile_command_option_defs)
3746         (make_compile_options_def_group): New.
3747         (compile_file_command): Handle options with
3748         gdb::option::process_options.
3749         (compile_file_command_completer): New function.
3750         (compile_code_command): Handle options with
3751         gdb::option::process_options.
3752         (compile_code_command_completer): New function.
3753         (_initialize_compiler): Install completers for "compile code" and
3754         "compile file".  Mention available options in "compile code" and
3755         "compile code"'s help.
3756         * completer.c (advance_to_completion_word): New, factored out from
3757         ...
3758         (advance_to_expression_complete_word_point): ... this.
3759         (advance_to_filename_complete_word_point): New.
3760         * completer.h (advance_to_filename_complete_word_point): New
3761         declaration.
3762
3763 2019-06-13  Pedro Alves  <palves@redhat.com>
3764
3765         * compile/compile.c: Include "cli/cli-option.h".
3766         (compile_print_value): Scope data pointer is now a
3767         value_print_options pointer; adjust.
3768         (compile_print_command): Process options.  Scope data pointer is
3769         now a value_print_options pointer; adjust.
3770         (_initialize_compile): Update "compile print"'s help to include
3771         supported options.  Install a completer for "compile print".
3772         * cp-valprint.c (show_vtblprint, show_objectprint)
3773         (show_static_field_print): Delete.
3774         (_initialize_cp_valprint): Don't install "set print
3775         static-members", "set print vtbl", "set print object" here.
3776         * printcmd.c: Include "cli/cli-option.h" and
3777         "common/gdb_optional.h".
3778         (print_command_parse_format): Rework to fill in a
3779         value_print_options instead of a format_data.
3780         (print_value): Change parameter type from format_data pointer to
3781         value_print_options reference.  Adjust.
3782         (print_command_1): Process options.  Adjust to pass down a
3783         value_print_options.
3784         (print_command_completer): New.
3785         (_initialize_printcmd): Install print_command_completer as
3786         handle_brkchars completer for the "print" command.  Update
3787         "print"'s help to include supported options.
3788         * valprint.c: Include "cli/cli-option.h".
3789         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3790         here from cp-valprint.c.
3791         (boolean_option_def, uinteger_option_def)
3792         (value_print_option_defs, make_value_print_options_def_group):
3793         New.  Use gdb::option::add_setshow_cmds_for_options to install
3794         "set print elements", "set print null-stop", "set print repeats",
3795         "set print pretty", "set print union", "set print array", "set
3796         print address", "set print symbol", "set print array-indexes".
3797         * valprint.h: Include <string> and "cli/cli-option.h".
3798         (make_value_print_options_def_group): Declare.
3799         (print_value): Change parameter type from format_data pointer to
3800         value_print_options reference.
3801         (print_command_completer): Declare.
3802
3803 2019-06-13  Pedro Alves  <palves@redhat.com>
3804
3805         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3806         (COMMON_SFILES): Add maint-test-settings.c.
3807         * cli/cli-decode.c (boolean_enums): New global, factored out from
3808         ...
3809         (add_setshow_boolean_cmd): ... here.
3810         * cli/cli-decode.h (boolean_enums): Declare.
3811         * cli/cli-option.c: New file.
3812         * cli/cli-option.h: New file.
3813         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3814         factored out from ...
3815         (parse_cli_boolean_value(const char *)): ... this.
3816         (is_unlimited_literal): Change parameter type to pointer to
3817         pointer.  Adjust and advance ARG pointer.
3818         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3819         (parse_cli_var_enum): New, factored out from ...
3820         (do_set_command): ... this.  Adjust.
3821         * cli/cli-setshow.h (parse_cli_boolean_value)
3822         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3823         (parse_cli_var_enum): Declare.
3824         * cli/cli-utils.c: Include "cli/cli-option.h".
3825         (get_ulongest): New.
3826         * cli/cli-utils.h (get_ulongest): Declare.
3827         (check_for_argument): New overloads.
3828         * maint-test-options.c: New file.
3829
3830 2019-06-13  Pedro Alves  <palves@redhat.com>
3831
3832         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3833         parse a range if "-" is at the end of the string.
3834
3835 2019-06-13  Pedro Alves  <palves@redhat.com>
3836
3837         * cli/cli-setshow.c (parse_auto_binary_operation)
3838         (parse_cli_boolean_value): Don't allow "o".
3839
3840 2019-06-13  Pedro Alves  <palves@redhat.com>
3841
3842         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3843         * NEWS: Mention maint test-settings KIND.
3844         * maint-test-settings.c: New file.
3845
3846 2019-06-13  Pedro Alves  <palves@redhat.com>
3847
3848         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3849         completer.
3850         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3851         "set" completers.
3852
3853 2019-06-13  Pedro Alves  <palves@redhat.com>
3854
3855         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3856         after item.
3857
3858 2019-06-13  Pedro Alves  <palves@redhat.com>
3859
3860         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3861
3862 2019-06-13  Pedro Alves <palves@redhat.com>
3863
3864         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3865         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3866         call.
3867         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3868         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3869         calls.
3870         (check_for_argument): Skip spaces after argument.
3871
3872 2019-06-13  Pedro Alves  <palves@redhat.com>
3873
3874         * thread.c (thread_apply_command): Adjust TID parsing.
3875         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3876         detected before end of string.
3877         (tid_is_in_list): Error out if LIST is invalid.
3878
3879 2019-06-13  Pedro Alves  <palves@redhat.com>
3880
3881         * completer.c (complete_line_internal_1): Rewind completion word
3882         point.
3883         (completion_tracker::advance_custom_word_point_by): Change
3884         parameter type to int.
3885         * completer.h (completion_tracker::advance_custom_word_point_by):
3886         Likewise.
3887
3888 2019-06-13  Pedro Alves  <palves@redhat.com>
3889
3890         * completer.c (advance_to_completion_word): Handle delimiters.
3891
3892 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3893
3894         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3895
3896 2019-06-11  Tom Tromey  <tom@tromey.com>
3897
3898         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3899         (xmalloc_failed): Move to alloc.c.
3900         * alloc.c: New file.
3901         * Makefile.in (COMMON_SFILES): Add alloc.c.
3902
3903 2019-06-11  Tom Tromey  <tom@tromey.com>
3904
3905         * nat/linux-waitpid.c: Don't include server.h.
3906         (linux_debug): Remove.
3907         (my_waitpid): Update.
3908
3909 2019-06-11  Tom Tromey  <tromey@adacore.com>
3910
3911         * infcall.c (_initialize_infcall): Remove trailing newline from
3912         help.
3913         * user-regs.c (_initialize_user_regs): Remove trailing newline
3914         from help.
3915         * typeprint.c (_initialize_typeprint): Remove trailing newline
3916         from help.
3917         * reverse.c (_initialize_reverse): Remove trailing newlines from
3918         help.
3919         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3920         from help.
3921         * language.c (add_set_language_command): Remove trailing newline
3922         from help.
3923         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3924         help.
3925         * disasm.c (_initialize_disasm): Remove trailing newline from
3926         help.
3927         * top.c (init_main): Remove trailing newline from help.
3928         * interps.c (_initialize_interpreter): Remove trailing newline
3929         from help.
3930         * btrace.c (_initialize_btrace): Remove trailing newlines from
3931         help.
3932         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3933         from help.
3934         * python/python.c (_initialize_python): Remove trailing newline
3935         from help.
3936         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3937         help.
3938         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3939         from help.  Reformat some text.
3940         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3941         from help.
3942         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3943         newline from help.
3944
3945 2019-06-11  Tom Tromey  <tromey@adacore.com>
3946
3947         * darwin-nat.c (darwin_decode_exception_message)
3948         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3949
3950 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * valops.c (value_slice): Check for not allocated or not
3953         associated values.
3954
3955 2019-06-10  Tom de Vries  <tdevries@suse.de>
3956
3957         PR gdb/24618
3958         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3959         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3960         invalid.
3961
3962 2019-06-10  Tom de Vries  <tdevries@suse.de>
3963
3964         PR gdb/24611
3965         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3966         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3967
3968 2019-06-10  Tom de Vries  <tdevries@suse.de>
3969
3970         PR symtab/24545
3971         * symtab.c (struct demangled_name_entry): Add language field.
3972         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3973         static minimal symbol".  Set and use language field.
3974
3975 2019-06-10  Tom Tromey  <tromey@adacore.com>
3976
3977         * ada-lang.c (_initialize_ada_language): Update help text.
3978
3979 2019-06-10  Tom Tromey  <tromey@adacore.com>
3980
3981         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3982         with a newline.
3983         * guile/guile.c (handle_boot_error): Don't end warning with a
3984         newline.
3985         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3986         warning with a newline.
3987         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3988         newline.
3989         (s12z_frame_cache): Likewise.
3990         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3991         a newline.
3992         * solib-svr4.c (disable_probes_interface): Don't end warning with
3993         a newline.
3994         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3995         newline.
3996         * python/python.c (do_finish_initialization): Don't end warning
3997         with a newline.
3998
3999 2019-06-10  Tom Tromey  <tom@tromey.com>
4000
4001         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4002         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4003         gdbpy_enter.
4004
4005 2019-06-10  Tom Tromey  <tromey@adacore.com>
4006
4007         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4008         data.
4009         (elf_new_init): Don't call stabsread_new_init.
4010         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4011         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4012         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4013
4014 2019-06-10  Tom de Vries  <tdevries@suse.de>
4015
4016         PR symtab/16264
4017         PR symtab/24517
4018         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4019
4020 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4021
4022         * source.c (find_and_open_source): Also rewrite relative file
4023         names.
4024
4025 2019-04-26  Amos Bird  <amosbird@gmail.com>
4026
4027         * annotate.c (annotate_thread_exited): Add "thread-exited"
4028         annotation.
4029
4030 2019-06-06  Tom Tromey  <tromey@adacore.com>
4031
4032         * maint.h (class scoped_command_stats): Use
4033         DISABLE_COPY_AND_ASSIGN.
4034         <print_time>: New method.
4035         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4036         print_time.
4037         (scoped_command_stats::print_time): New method.
4038
4039 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4042         instructions of lengths 6 or 8 bytes.
4043
4044 2019-06-04  Pedro Alves  <palves@redhat.com>
4045
4046         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4047
4048         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4049         * breakpoint.c (condition_completer): Likewise.
4050         * cli/cli-dump.c (scan_expression): Likewise.
4051         * common/filestuff.c (mkdir_recursive): Likewise.
4052         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4053         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4054         (gdb_abspath): Likewise.
4055         * compile/compile-cplus-types.c
4056         (compile_cplus_instance::decl_name): Likewise.
4057         * completer.c (complete_explicit_location):
4058         (signal_completer, reg_or_group_completer_1): Likewise.
4059         * cp-support.c (cp_remove_params_if_any): Likewise.
4060         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4061         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4062         * infcmd.c (strip_bg_char): Likewise.
4063         * linespec.c (copy_token_string): Likewise.
4064         * mi/mi-main.c (output_cores): Likewise.
4065         * psymtab.c (psymtab_search_name):
4066         * symfile.c (test_set_ext_lang_command): Likewise.
4067         * target.c (target_fileio_read_stralloc): Likewise.
4068         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4069         * value.c (complete_internalvar): Likewise.
4070
4071 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4072
4073         Add objfile property to gdb.Type.
4074         * NEWS: Mention Python API addition.
4075         * python/py-type.c (typy_get_objfile): New method.
4076
4077 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078
4079         * NEWS: Mention the new set|show style [title|highlight].
4080         Mention changes to "show style", "help" and "apropos".
4081
4082 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4083
4084         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4085         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4086         instead of print_help_for_command.
4087         (print_doc_of_command): New function.
4088         (help_list): Add 'apropos -v word' suggestion.
4089         (print_help_for_command): Style the command name using title style.
4090         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4091         (_initialize_cli_cmds): Describe -v in apropos_command help.
4092
4093 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4094
4095         * cli/cli-style.h (cli_style_option): Add name in constructor,
4096         add m_name class member, add constructor with intensity,
4097         add name class function.
4098         (cli_style_option::add_setshow_commands): Remove name argument.
4099         (highlight_style, title_style): New styles.
4100         * cli/cli-style.c (do_show): New function that shows a style
4101         characteristic styling the style name with itself.
4102         (set_style_name): New function.
4103         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4104         Update all callers according to the changes in cli/cli-style.h.
4105         * utils.h (fputs_highlighted): New function.
4106         * utils.c (fputs_highlighted): Likewise.
4107
4108 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4109
4110         * NEWS: Mention new pipe command and new convenience variables.
4111
4112 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4113
4114         * cli/cli-cmds.c (pipe_command): New function.
4115         (_initialize_cli_cmds): Call add_com for pipe_command.
4116         Define | as an alias for pipe.
4117         (exit_status_set_internal_vars): New function.
4118         (shell_escape): Call exit_status_set_internal_vars.
4119         cli/cli-decode.c (find_command_name_length): Recognize | as
4120         a single character command.
4121
4122 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4123
4124         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4125         top.c (execute_command_to_ui_file): New function, mostly a copy
4126         of execute_command_to_string.
4127         (execute_command_to_string): Implement by calling
4128         execute_command_to_ui_file.
4129
4130 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4131
4132         * top.h (saved_command_line): Remove declaration.
4133         * top.c (previous_saved_command_line, previous_repeat_arguments):
4134         New variables.
4135         (saved_command_line): Make static, define together with other
4136         'repeat variables'.
4137         (dont_repeat): Clear repeat_arguments.
4138         (repeat_previous, get_saved_command_line, save_command_line):
4139         New functions.
4140         (gdb_init): Initialize saved_command_line
4141         and previous_saved_command_line.
4142         * main.c (captured_main_1): Remove saved_command_line initialization.
4143         * event-top.c (handle_line_of_input): Update to use
4144         the new 'repeat' related functions instead of direct access to
4145         saved_command_line.
4146         * command.h (repeat_previous, get_saved_command_line,
4147         save_command_line): New declarations.
4148         (dont_repeat): Add comment.
4149
4150 2019-05-30  Tom Tromey  <tromey@adacore.com>
4151
4152         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4153         Fix comment.
4154         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4155
4156 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4157
4158         PR cli/24587
4159         * completer.c (complete): Initialize variable word.
4160
4161 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4162
4163         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4164         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4165         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4166         'body' is NULL to the outter 'if', protecting the '!is_define'
4167         situation as well.
4168
4169 2019-05-29  Tom Tromey  <tromey@adacore.com>
4170
4171         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4172         (dwarf_unknown): New function.
4173         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4174         (dwarf_type_encoding_name): Use dwarf_unknown.
4175
4176 2019-05-29  Tom Tromey  <tromey@adacore.com>
4177
4178         PR c++/20020:
4179         * cp-valprint.c (cp_print_value_fields): Call
4180         cp_print_static_field inside "try".
4181
4182 2019-05-29  Tom Tromey  <tromey@adacore.com>
4183
4184         * inflow.c (struct terminal_info): Add default operator=.
4185         * configure: Rebuild.
4186         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4187         -Wdeprecated-copy-dtor, -Wredundant-move.
4188
4189 2019-05-29  Tom Tromey  <tromey@adacore.com>
4190
4191         * NEWS: Add entry.
4192         * infcmd.c (print_return_value_1): Handle finish_print
4193         option.
4194         (show_print_finish): New function.
4195         (_initialize_infcmd): Add "set/show print finish" commands.
4196         * valprint.c (user_print_options): Initialize new member.
4197         * valprint.h (struct value_print_options) <finish_print>: New
4198         member.
4199
4200 2019-05-28  Tom Tromey  <tromey@adacore.com>
4201
4202         * ada-lang.c (ada_remove_Xbn_suffix)
4203         (find_old_style_renaming_symbol)
4204         (parse_old_style_renaming): Remove.
4205         (ada_find_renaming_symbol): Don't call
4206         find_old_style_renaming_symbol.
4207         (ada_is_renaming_symbol): Rename from
4208         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4209         bool.  Now static.
4210         (ada_read_var_value): Update and simplify.
4211         * ada-exp.y (write_var_or_type): Remove old code.
4212
4213 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4214
4215         * event-top.c: Remove include comment.
4216         * inflow.c (class scoped_ignore_sigttou): Move from here...
4217         * inflow.h (class scoped_ignore_sigttou): ...to here.
4218         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4219         * top.c:  Remove include comment.
4220
4221 2019-05-27  Tom Tromey  <tom@tromey.com>
4222
4223         * NEWS: Fix typo.
4224
4225 2019-05-22  Tom Tromey  <tromey@adacore.com>
4226
4227         * target.c (target_follow_exec): Constify parameter.
4228         * target-delegates.c: Rebuild.
4229         * remote.c (remote_target::follow_exec): Constify parameter.
4230         * infrun.c (follow_exec): Constify parameter.
4231         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4232         (target_follow_exec): Likewise.
4233
4234 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4235
4236         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4237         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4238
4239 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4240
4241         * NEWS: Add debugredirect and testsuite sections.
4242
4243 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4244
4245         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4246         target descriptions using exclusively floating point register name
4247         aliases.
4248
4249 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         PR gdb/18644:
4252         * f-lang.c (build_fortran_types): Handle the case where
4253         gdbarch_floatformat_for_type returns a nullptr.
4254
4255 2019-05-21  Tom de Vries  <tdevries@suse.de>
4256
4257         PR cli/24587
4258         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4259
4260 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         PR gdb/18644:
4263         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4264         16-byte floats.
4265         * i386-tdep.c (i386_floatformat_for_type): Use
4266         floatformats_ia64_quad for the 16-byte floating point component
4267         within a fortran 32-byte complex number.
4268
4269 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4272         delete default constructor.
4273         (find_partial_die): Update to return const struct.
4274         (partial_die_parent_scope): Move variable declaration into scope
4275         of its use and change its type to auto.
4276         (guess_partial_die_structure_name): Likewise.
4277         (partial_die_info::fixup): Likewise.
4278
4279 2019-05-17  Tom Tromey  <tromey@adacore.com>
4280
4281         * source.c (find_and_open_source): Remove cast.
4282
4283 2019-05-17  Tom Tromey  <tromey@adacore.com>
4284
4285         * annotate.c (annotate_source): Make "filename" const.
4286         * annotate.h (annotate_source): Use const.
4287
4288 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4289
4290         * disasm.c (set_disassembler_options): Send errors to stderr.
4291
4292 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4293
4294         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4295         (cli_interp_base::set_logging): Check debug_redirect.
4296         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4297         * cli/cli-logging.c (debug_redirect): Add static variable.
4298         (pop_output_files): Add default param.
4299         (handle_redirections): Print debug setting.
4300         (show_logging_command): Likewise.
4301         (_initialize_cli_logging): Add debugredirect command.
4302         * interps.c (current_interp_set_logging): Add debug_redirect
4303         parameter.
4304         * interps.h (set_logging): Add debug_redirect parameter.
4305         (current_interp_set_logging): Likewise.
4306         * mi/mi-common.h: Likewise.
4307         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4308
4309 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4310             Tom Tromey  <tromey@adacore.com>
4311
4312         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4313         directly.
4314         * cli/cli-interp.h (make_logging_output): Remove declaration.
4315         * cli/cli-logging.c (make_logging_output): Remove function.
4316         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4317         directly.
4318         * ui-file.c (tee_file::tee_file): Remove bools.
4319         (tee_file::~tee_file): Remove deletes.
4320         * ui-file.h (tee_file): Remove bools.
4321
4322 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4323
4324         * mi/mi-cmds.h (mi_cmd_complete): New function.
4325         * mi/mi-main.c (mi_cmd_complete): Likewise.
4326         * mi/mi-cmds.c: Define new MI command -complete.
4327         * NEWS: Mention new -complete command.
4328
4329 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4330
4331         * completer.h (complete): New function.
4332         * completer.c (complete): Likewise.
4333         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4334         function defined in completer.h.
4335
4336 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4337
4338         * MAINTAINERS (Write After Approval): Add myself.
4339
4340 2019-05-17  Tom de Vries  <tdevries@suse.de>
4341
4342         PR gdb/24094
4343         * dwarf2read.c (struct cu_partial_die_info): New struct.
4344         (find_partial_die): Return cu_partial_die_info.
4345         (partial_die_parent_scope, guess_partial_die_structure_name)
4346         (partial_die_info::fixup): Handle new return type of find_partial_die.
4347
4348 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4349
4350         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4351         "std::string", simplifying the algorithm.
4352
4353 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4354
4355         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4356         (stap_static_probe_ops::get_probes): Likewise.
4357
4358 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4359
4360         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4361         '-')" and "else if".
4362         (stap_parse_single_operand): Join checks for
4363         "gdbarch_stap_parse_special_token_p" and
4364         "gdbarch_stap_parse_special_token" in the same "if" statement.
4365         Invert check when verifying for operation on register
4366         displacement.
4367
4368 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4369
4370         * stap-probe.c (stap_get_opcode): Update comment.
4371         (stap_get_expected_argument_type): Likewise.
4372         (handle_stap_probe): Likewise.
4373
4374 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4375
4376         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4377         return type to 'bool'.  Adjust comment.  Use 'bool' when
4378         appropriate.
4379         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4380         * stap-probe.c (stap_parse_argument_1): Likewise.
4381         (stap_is_operator): Likewise.
4382         (stap_is_generic_prefix): Likewise.
4383         (stap_is_register_prefix): Likewise.
4384         (stap_is_register_indirection_prefix): Likewise.
4385         (stap_is_integer_prefix): Likewise.
4386         (stap_generic_check_suffix): Likewise.
4387         (stap_check_integer_suffix): Likewise.
4388         (stap_check_register_suffix): Likewise.
4389         (stap_check_register_indirection_suffix): Likewise.
4390         (stap_parse_register_operand): Likewise.
4391         (stap_parse_single_operand): Likewise.
4392         (stap_parse_argument_1): Likewise.
4393         (stap_probe::get_argument_count): Likewise.
4394         (stap_is_operator): Likewise.
4395
4396 2019-05-16  Tom Tromey  <tromey@adacore.com>
4397
4398         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4399         keyword to foreach.
4400
4401 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4402
4403         * linux-thread-db.c (try_thread_db_load_1): Change return type
4404         to bool.
4405         (try_thread_db_load): Likewise.
4406         (try_thread_db_load_from_pdir_1): Likewise.
4407         (try_thread_db_load_from_pdir): Likewise.
4408         (try_thread_db_load_from_sdir): Likewise.
4409         (try_thread_db_load_from_dir): Likewise.
4410         (thread_db_load_search): Likewise.
4411         (has_libpthread): Likewise.
4412         (thread_db_load): Likewise.
4413
4414 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4415
4416         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4417         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4418         NULL, and complain/return if that's the case.
4419
4420 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4421
4422         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4423         (advance, posn, abstract_read_memory): New functions.
4424         [struct mem_read_abstraction]: New struct.
4425         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4426
4427 2019-05-14  Tom Tromey  <tromey@adacore.com>
4428
4429         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4430         value is not lval_memory.
4431
4432 2019-05-14  Tom Tromey  <tromey@adacore.com>
4433
4434         * solib.c (info_sharedlibrary_command): Style the file name.
4435
4436 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4437
4438         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4439         (aarch64_vnv_type): Likewise.
4440         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4441         * common/tdesc.c: Likewise.
4442         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4443         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4444         * features/aarch64-fpu.xml: Add ieee half view.
4445         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4446         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4447         * gdbtypes.h (struct builtin_type): Likewise.
4448         (struct objfile_type): Likewise.
4449
4450 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4451
4452         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4453         typo.
4454         * location.h (string_to_event_location): Likewise.
4455
4456 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4457
4458         GDB 8.3 released.
4459
4460 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4461
4462         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4463         New variable declaration.
4464         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4465         New variable.
4466         (print_one_breakpoint): Use ui_out::test_flags and new global
4467         variable to compute use_fixed_output.
4468         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4469         Remove.
4470         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4471         (mi_multi_location_breakpoint_output_fixed): Remove.
4472         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4473         new variable.
4474         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4475         fix_multi_location_breakpoint_output flag if version >= 3.
4476         * ui-out.h (enum ui_out_flag)
4477         <fix_multi_location_breakpoint_output>: New enumerator.
4478
4479 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4480
4481         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4482
4483 2019-05-10  Tom Tromey  <tromey@adacore.com>
4484
4485         * ada-lang.c (catch_ada_completer): New function.
4486         (_initialize_ada_language): Use it.
4487
4488 2019-05-10  Tom Tromey  <tromey@adacore.com>
4489
4490         * thread.c (print_thread_info): Make "requested_threads" const.
4491         * gdbthread.h (print_thread_info): Make "requested_threads"
4492         const.
4493         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4494         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4495
4496 2019-05-08  Tom Tromey  <tom@tromey.com>
4497
4498         * gdbtypes.c (objfile_type_data): Change type.
4499         (objfile_type, _initialize_gdbtypes): Update.
4500
4501 2019-05-08  Tom Tromey  <tom@tromey.com>
4502
4503         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4504         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4505         (_initialize_dwarf2_frame): Update.
4506
4507 2019-05-08  Tom Tromey  <tom@tromey.com>
4508
4509         * objc-lang.c (objc_objfile_data): Change type.
4510         (find_methods): Update.
4511         (_initialize_objc_lang): Remove.
4512
4513 2019-05-08  Tom Tromey  <tom@tromey.com>
4514
4515         * stabsread.c (rs6000_builtin_type_data): Change type.
4516         (rs6000_builtin_type, _initialize_stabsread): Update.
4517
4518 2019-05-08  Tom Tromey  <tom@tromey.com>
4519
4520         * mips-tdep.c (mips_pdr_data): Remove.
4521         (_initialize_mips_tdep): Update.
4522
4523 2019-05-08  Tom Tromey  <tom@tromey.com>
4524
4525         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4526         (hppa_init_objfile_priv_data, read_unwind_info)
4527         (find_unwind_entry, _initialize_hppa_tdep): Update.
4528
4529 2019-05-08  Tom Tromey  <tom@tromey.com>
4530
4531         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4532         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4533         on obstack.
4534         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4535
4536 2019-05-08  Tom Tromey  <tom@tromey.com>
4537
4538         * mdebugread.c (basic_type_data): Change type.
4539         (basic_type, _initialize_mdebugread): Update.
4540
4541 2019-05-08  Tom Tromey  <tom@tromey.com>
4542
4543         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4544
4545 2019-05-08  Tom Tromey  <tom@tromey.com>
4546
4547         * nto-tdep.c (nto_inferior_data_reg): Change type.
4548         (nto_inferior_data): Update.
4549         (nto_inferior_data_cleanup, nto_new_inferior_data)
4550         (_initialize_nto_tdep): Remove.
4551         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4552
4553 2019-05-08  Tom Tromey  <tom@tromey.com>
4554
4555         * ada-lang.c (struct ada_inferior_data): Add initializers.
4556         (ada_inferior_data): Change type.
4557         (ada_inferior_data_cleanup): Remove.
4558         (get_ada_inferior_data, ada_inferior_exit)
4559         (struct ada_pspace_data): Add initializers, destructor.
4560         (ada_pspace_data_handle): Change type.
4561         (get_ada_pspace_data): Update.
4562         (ada_pspace_data_cleanup): Remove.
4563
4564 2019-05-08  Tom Tromey  <tom@tromey.com>
4565
4566         * coffread.c (struct coff_symfile_info): Add initializers.
4567         (coff_objfile_data_key): Move lower.  Change type.
4568         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4569         Update.
4570         (coff_free_info): Remove.
4571
4572 2019-05-08  Tom Tromey  <tom@tromey.com>
4573
4574         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4575         (fbsd_pspace_data_handle): Move lower.  Change type.
4576         (get_fbsd_pspace_data): Update.
4577         (fbsd_pspace_data_cleanup): Remove.
4578         (_initialize_fbsd_tdep): Update.
4579
4580 2019-05-08  Tom Tromey  <tom@tromey.com>
4581
4582         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4583         (get_ada_tasks_pspace_data): Update.
4584         (ada_tasks_pspace_data_cleanup): Remove.
4585         (_initialize_tasks): Update.
4586         (ada_tasks_inferior_data_handle): Change type.
4587         (get_ada_tasks_inferior_data): Update.
4588         (ada_tasks_inferior_data_cleanup): Remove.
4589         (struct ada_tasks_pspace_data): Add initializers.
4590
4591 2019-05-08  Tom Tromey  <tom@tromey.com>
4592
4593         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4594         * symfile-debug.c (debug_sym_get_probes): Change type.
4595         * stap-probe.c (handle_stap_probe):
4596         (stap_static_probe_ops::get_probes): Change type.
4597         * probe.h (class static_probe_ops) <get_probes>: Change type.
4598         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4599         (parse_probes_in_pspace): Update.
4600         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4601         Update.
4602         (any_static_probe_ops::get_probes): Change type.
4603         * elfread.c (elfread_data): New typedef.
4604         (probe_key): Change type.
4605         (elf_get_probes): Likewise.  Update.
4606         (probe_key_free): Remove.
4607         (_initialize_elfread): Update.
4608         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4609         Change type.
4610         (dtrace_process_dof_probe, dtrace_process_dof)
4611         (dtrace_static_probe_ops::get_probe): Change type.
4612
4613 2019-05-08  Tom Tromey  <tom@tromey.com>
4614
4615         * xcoffread.c (struct xcoff_symfile_info): Rename from
4616         coff_symfile_info.  Add initializers.
4617         (xcoff_objfile_data_key): Move lower.  Change type.
4618         (XCOFF_DATA): Rewrite.
4619         (xcoff_free_info): Remove.
4620         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4621         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4622         (xcoff_initial_scan): Update.
4623
4624 2019-05-08  Tom Tromey  <tom@tromey.com>
4625
4626         * solib-svr4.c (struct svr4_info): Add initializers and
4627         destructor.
4628         <probes_table>: Now an htab_up.
4629         (solib_svr4_pspace_data): Change type.
4630         (free_probes_table): Simplify.
4631         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4632         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4633         (probes_table_remove_objfile_probes, register_solib_event_probe)
4634         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4635         (_initialize_svr4_solib): Update.
4636
4637 2019-05-08  Tom Tromey  <tom@tromey.com>
4638
4639         * remote.c (remote_pspace_data): Change type.
4640         (remote_pspace_data_cleanup): Remove.
4641         (get_remote_exec_file, set_pspace_remote_exec_file)
4642         (_initialize_remote): Update.
4643
4644 2019-05-08  Tom Tromey  <tom@tromey.com>
4645
4646         * breakpoint.c (breakpoint_objfile_key): Change type.
4647         (get_breakpoint_objfile_data): Update.
4648         (free_breakpoint_objfile_data): Remove.
4649         (_initialize_breakpoint): Update.
4650
4651 2019-05-08  Tom Tromey  <tom@tromey.com>
4652
4653         * linux-tdep.c (struct linux_info): Add initializers.
4654         (linux_inferior_data): Move.  Change type.
4655         (invalidate_linux_cache_inf): Update.
4656         (linux_inferior_data_cleanup): Remove.
4657         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4658
4659 2019-05-08  Tom Tromey  <tom@tromey.com>
4660
4661         * auxv.c (auxv_inferior_data): Move.  Change type.
4662         (auxv_inferior_data_cleanup): Remove.
4663         (invalidate_auxv_cache_inf): Rewrite.
4664         (get_auxv_inferior_data, _initialize_auxv): Update.
4665
4666 2019-05-08  Tom Tromey  <tom@tromey.com>
4667
4668         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4669         (symfile_debug_objfile_data_key): Change type.
4670         (symfile_debug_installed, debug_qf_has_symbols)
4671         (debug_qf_find_last_source_symtab)
4672         (debug_qf_forget_cached_source_info)
4673         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4674         (debug_qf_print_stats, debug_qf_dump)
4675         (debug_qf_expand_symtabs_for_function)
4676         (debug_qf_expand_all_symtabs)
4677         (debug_qf_expand_symtabs_with_fullname)
4678         (debug_qf_map_matching_symbols)
4679         (debug_qf_expand_symtabs_matching)
4680         (debug_qf_find_pc_sect_compunit_symtab)
4681         (debug_qf_map_symbol_filenames)
4682         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4683         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4684         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4685         (debug_sym_read_linetable, debug_sym_relocate): Update.
4686         (symfile_debug_free_objfile): Remove.
4687         (install_symfile_debug_logging, _initialize_symfile_debug):
4688         Update.
4689
4690 2019-05-08  Tom Tromey  <tom@tromey.com>
4691
4692         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4693         allocate_on_obstack.
4694         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4695         (get_dwarf2_per_objfile): Update.
4696         (set_dwarf2_per_objfile): Remove.
4697         (dwarf2_has_info, dwarf2_get_section_info): Update.
4698         (dwarf2_free_objfile): Remove.
4699         (_initialize_dwarf2_read): Update.
4700
4701 2019-05-08  Tom Tromey  <tom@tromey.com>
4702
4703         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4704         initializers.
4705         <unsupported_script_warning_printed,
4706         script_not_found_warning_printed>: Now bool.
4707         (auto_load_pspace_data): Change type.
4708         (~auto_load_pspace_info): Rename from
4709         auto_load_pspace_data_cleanup.
4710         (get_auto_load_pspace_data, init_loaded_scripts_info)
4711         (clear_section_scripts, maybe_print_unsupported_script_warning)
4712         (maybe_print_script_not_found_warning, _initialize_auto_load):
4713         Update.
4714
4715 2019-05-08  Tom Tromey  <tom@tromey.com>
4716
4717         * objfiles.c (objfile_pspace_info): Add destructor and
4718         initializers.
4719         (objfiles_pspace_data): Change type.
4720         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4721         (get_objfile_pspace_data): Update.
4722         (objfiles_bfd_data): Change type.
4723         (get_objfile_bfd_data): Update.
4724         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4725
4726 2019-05-08  Tom Tromey  <tom@tromey.com>
4727
4728         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4729         Change type.
4730         (get_catch_syscall_inferior_data): Update.
4731         (catch_syscall_inferior_data_cleanup): Remove.
4732         (_initialize_break_catch_syscall): Update.
4733
4734 2019-05-08  Tom Tromey  <tom@tromey.com>
4735
4736         * inflow.c (struct terminal_info): Add destructor and
4737         initializers.
4738         (inflow_inferior_data): Change type.
4739         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4740         (get_inflow_inferior_data, inflow_inferior_exit)
4741         (swap_terminal_info, _initialize_inflow): Update.
4742
4743 2019-05-08  Tom Tromey  <tom@tromey.com>
4744
4745         * target-dcache.c (target_dcache_cleanup): Remove.
4746         (target_dcache_aspace_key): Change type.
4747         (target_dcache_init_p, target_dcache_invalidate)
4748         (target_dcache_get, target_dcache_get_or_init)
4749         (_initialize_target_dcache): Update.
4750         * dcache.h (struct dcache_deleter): New.
4751
4752 2019-05-08  Tom Tromey  <tom@tromey.com>
4753
4754         * symtab.c (struct symbol_cache): Add destructor and
4755         initializers.
4756         (symbol_cache_key): Move.  Change type.
4757         (make_symbol_cache, free_symbol_cache): Remove.
4758         (get_symbol_cache): Update.
4759         (symbol_cache_cleanup): Remove.
4760         (ALL_PSPACES, symbol_cache_flush)
4761         (maintenance_print_symbol_cache)
4762         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4763         Update.
4764
4765 2019-05-08  Tom Tromey  <tom@tromey.com>
4766
4767         * symtab.c (struct main_info): Add destructor and initializers.
4768         (main_progspace_key): Move.  Change type.
4769         (get_main_info): Update.
4770         (main_info_cleanup): Remove.
4771         (_initialize_symtab): Update.
4772
4773 2019-05-08  Tom Tromey  <tom@tromey.com>
4774
4775         * registry.h (DECLARE_REGISTRY): Define the _key class.
4776
4777 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * NEWS: Merge two 'New commands' sections.
4780
4781 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4782
4783         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4784         parameter and use Ada language definition instead.
4785         (ada_val_print_ptr): Remove unused language parameter.
4786         (ada_val_print_num): Remove language parameter and use Ada language
4787         definition instead.
4788         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4789         parameter.
4790         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4791         parameter and use Ada language definition instead.
4792         (ada_val_print_1): Update all ada_val_print_xxx calls.
4793         Remove language parameter.
4794         (ada_val_print): Update ada_val_print_1 call.
4795
4796 2019-05-08  Tom Tromey  <tromey@adacore.com>
4797
4798         * remote.c (remote_hw_watchpoint_limit)
4799         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4800         Now static.
4801
4802 2019-05-08  Tom Tromey  <tromey@adacore.com>
4803
4804         * maint.c (_initialize_maint_cmds): Move initialization code to
4805         remote.c.
4806         (watchdog, show_watchdog): Move to remote.c.
4807         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4808         "watchdog" static.
4809         (_initialize_remote): Move initialization code from maint.c.
4810         * defs.h (watchdog): Don't declare.
4811
4812 2019-05-08  Tom Tromey  <tromey@adacore.com>
4813
4814         * tui/tui-interp.c: Include main.h.
4815         * interps.c: Include main.h.
4816         * main.h (interpreter_p): Declare.
4817         * defs.h (interpreter_p): Don't declare.
4818
4819 2019-05-08  Tom Tromey  <tromey@adacore.com>
4820
4821         * dwarf2loc.c: Include dwarf2read.h.
4822         * defs.h (read_unsigned_leb128): Don't declare.
4823         * dwarf2read.h (read_unsigned_leb128): Declare.
4824
4825 2019-05-08  Tom Tromey  <tromey@adacore.com>
4826
4827         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4828         method.
4829
4830 2019-05-08  Tom Tromey  <tromey@adacore.com>
4831
4832         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4833         when no wrap column is set.
4834
4835 2019-05-08  Tom Tromey  <tromey@adacore.com>
4836
4837         * c-lang.c (c_get_string): Handle non-C-style arrays.
4838
4839 2019-05-08  Tom Tromey  <tromey@adacore.com>
4840
4841         * typeprint.c (print_offset_data::update): Print the bit offset,
4842         not the number of bits remaining.
4843
4844 2019-05-08  Tom Tromey  <tromey@adacore.com>
4845
4846         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4847         padding at end of comment.
4848
4849 2019-05-08  Tom Tromey  <tromey@adacore.com>
4850
4851         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4852         Compare main types.
4853
4854 2019-05-06  Tom Tromey  <tom@tromey.com>
4855
4856         * common/scoped_mmap.c: Include common-defs.h.
4857         * common/scoped_mmap.h: Don't include config.h.
4858
4859 2019-05-04  Tom Tromey  <tom@tromey.com>
4860
4861         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4862         (struct aarch64_call_info): Add initializers.
4863         <si>: Now a std::vector.
4864         (pass_on_stack, aarch64_push_dummy_call): Update.
4865
4866 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4867             Tom Tromey  <tom@tromey.com>
4868
4869         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4870         (ppc_threads): Now a std::vector.  Now static.
4871         (hwdebug_find_thread_points_by_tid)
4872         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4873         Update.
4874
4875 2019-05-04  Tom Tromey  <tom@tromey.com>
4876
4877         * arc-tdep.c (arc_tdesc_init): Return bool.
4878
4879 2019-05-04  Tom Tromey  <tom@tromey.com>
4880
4881         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4882         Use gdb_assert_not_reached.
4883
4884 2019-05-04  Tom Tromey  <tom@tromey.com>
4885
4886         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4887         "false".
4888
4889 2019-05-04  Tom Tromey  <tom@tromey.com>
4890
4891         * arc-tdep.c (arc_tdesc_init): Use bool.
4892
4893 2019-05-04  Tom Tromey  <tom@tromey.com>
4894
4895         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4896
4897 2019-05-04  Tom Tromey  <tom@tromey.com>
4898
4899         * cli/cli-cmds.c (valid_command_p): Return bool.
4900
4901 2019-05-04  Tom Tromey  <tom@tromey.com>
4902
4903         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4904         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4905
4906 2019-05-04  Raul Tambre  <raul@tambre.ee>
4907
4908         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4909         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4910         operator for comparison.
4911
4912 2019-05-04  Tom Tromey  <tom@tromey.com>
4913
4914         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4915         (lookup_partial_symbol, print_partial_symbols)
4916         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4917         (psymbol_compare): Update.
4918         (add_psymbol_to_bcache): Clear the entire psymbol.
4919         (maintenance_check_psymtabs): Update.
4920         * psympriv.h (struct partial_symbol): Don't derive from
4921         general_symbol_info.
4922         <obj_section, unrelocated_address, address,
4923         set_unrelocated_address>: Update.
4924         <ginfo>: New member.
4925         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4926         (debug_names::write_psymbols): Update.
4927
4928 2019-05-04  Tom de Vries  <tdevries@suse.de>
4929
4930         * contrib/cc-with-tweaks.sh: Support -n arg.
4931
4932 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4933
4934         * corelow.c (core_target::detach): Ensure frame cache and
4935         register caches are cleared.
4936         inferior.c (exit_inferior_1): Likewise.
4937
4938 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4939             Tom Tromey  <tom@tromey.com>
4940
4941         * dictionary.c (collate_pending_symbols_by_language): Remove
4942         "struct" from foreach.
4943         * symtab.c (lookup_global_symbol_from_objfile)
4944         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4945         foreach.
4946         * ser-tcp.c (net_open): Remove "struct" from foreach.
4947         * objfiles.c (objfile_relocate, objfile_rebase)
4948         (objfile_has_symbols): Remove "struct" from foreach.
4949         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4950         from foreach.
4951         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4952         foreach.
4953         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4954         "struct" from foreach.
4955         * ada-lang.c (create_excep_cond_exprs)
4956         (ada_exception_catchpoint_cond_string): Remove "struct" from
4957         foreach.
4958
4959 2019-05-03  Tom Tromey  <tromey@adacore.com>
4960
4961         * ada-exp.y (convert_char_literal): Check suffix of each
4962         enumerator.
4963
4964 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4965
4966         PR ada/21406:
4967         * ada-exp.y (yywrap): Don't define.
4968         * ada-lex.l (%option): Add noyywrap
4969         (yywrap): Remove.
4970
4971 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4972
4973         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4974         _WIN32_WINNT to the XP level, unless already defined to a higher
4975         level.
4976
4977         * unittests/parse-connection-spec-selftests.c:
4978         * ser-tcp.c:
4979         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4980         override.
4981
4982         * symfile.c (find_separate_debug_file): Remove colon from the
4983         drive spec of DOS/Windows file names of the target, so that the
4984         file name produced from DEBUGDIR and the target's directory will
4985         be valid on DOS/Windows systems.
4986
4987 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * rust-lang.c (val_print_struct): Handle printing structures
4990         containing strings.
4991
4992 2019-05-02  Tom Tromey  <tromey@adacore.com>
4993
4994         * valarith.c (_initialize_valarith): Remove.
4995
4996 2019-05-01  Tom Tromey  <tromey@adacore.com>
4997
4998         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4999         bitfields.
5000
5001 2019-05-01  Tom Tromey  <tromey@adacore.com>
5002
5003         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5004         for big-endian copies.
5005
5006 2019-04-30  Ali Tamur  <tamur@google.com>
5007         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5008         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5009         (read_3_bytes): New function.
5010
5011 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5012
5013         * windows-nat.c (main_thread_id): Delete.
5014         (handle_output_debug_string): Replace main_thread_id by
5015         current_event.dwThreadId.
5016         (fake_create_process): Likewise.
5017         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5018         Do not set main_thread_id.
5019         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5020         current_event.dwThreadId.
5021         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5022
5023 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5024
5025         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5026         Use current_event.dwThreadId instead of main_thread_id.
5027
5028 2019-04-30  Tom Tromey  <tromey@adacore.com>
5029
5030         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5031         (create_excep_cond_exprs): Iterate over program spaces.
5032         (ada_exception_catchpoint_cond_string): Examine all minimal
5033         symbols for exception types.
5034
5035 2019-04-30  Tom Tromey  <tromey@adacore.com>
5036
5037         PR c++/24470:
5038         * dwarf2read.c (process_structure_scope): Handle case where type
5039         has template parameters but no symbol was created.
5040
5041 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5042             Chris January  <chris.january@arm.com>
5043
5044         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5045         qualifier.
5046         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5047
5048 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5049
5050         * f-typeprint.c (f_print_type): Update rules for printing
5051         whitespace.
5052         (f_type_print_varspec_suffix): Likewise.
5053
5054 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5055             Chris January  <chris.january@arm.com>
5056
5057         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5058         function arguments.
5059
5060 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * f-lang.c (build_fortran_types): Change name of void type to
5063         lower case.
5064         * f-typeprint.c (f_type_print_base): Print the name of the void
5065         type, rather than a fixed string.
5066         * f-valprint.c (f_decorations): Use lower case void string.
5067
5068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5069             Chris January  <chris.january@arm.com>
5070
5071         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5072         types for Fortran.
5073
5074 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5075             Chris January  <chris.january@arm.com>
5076             David Lecomber  <david.lecomber@arm.com>
5077
5078         * f-exp.y (BINOP_INTRINSIC): New token.
5079         (exp): New parser rule handling BINOP_INTRINSIC.
5080         (f77_keywords): Add new builtin procedures.
5081         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5082         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5083         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5084         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5085         (print_unop_subexp_f): New function.
5086         (print_binop_subexp_f): New function.
5087         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5088         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5089         (dump_subexp_body_f): Likewise.
5090         (operator_check_f): Likewise.
5091         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5092         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5093
5094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5097         UNOP_KIND.
5098         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5099         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5100         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5101         (operator_length_f): New fuction.
5102         (print_subexp_f): New function.
5103         (op_name_f): New function.
5104         (dump_subexp_body_f): New function.
5105         (operator_check_f): New function.
5106         (exp_descriptor_f): Replace standard expression handling functions
5107         with new functions.
5108         * gdb/fortran-operator.def: New file.
5109         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5110         * gdb/std-operator.def: Remove UNOP_KIND.
5111
5112 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * std-operator.def: Remove unbalanced, stray double quote
5115         character.
5116
5117 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5118             Chris January  <chris.january@arm.com>
5119             Daniel Everett  <daniel.everett@arm.com>
5120             Nick Forrington  <nick.forrington@arm.com>
5121             Richard Bunt  <richard.bunt@arm.com>
5122
5123         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5124         of depth when printing anonymous structs or unions.
5125         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5126         Don't print either the top-level value, or the children if the
5127         max-depth is exceeded.
5128         (ppscm_print_children): When printing the key of a map, allow one
5129         extra level of depth.
5130         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5131         print either the top-level value, or the children if the max-depth
5132         is exceeded.
5133         (print_children): When printing the key of a map, allow one extra
5134         level of depth.
5135         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5136         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5137         (user_print_options): Initialise max_depth field.
5138         (val_print_scalar_or_string_type_p): New function.
5139         (val_print): Check to see if the max depth has been reached.
5140         (val_print_check_max_depth): Define new function.
5141         (show_print_max_depth): New function.
5142         (_initialize_valprint): Add 'print max-depth' option.
5143         * valprint.h (struct value_print_options) <max_depth>: New field.
5144         (val_print_check_max_depth): Declare new function.
5145         * NEWS: Document new feature.
5146
5147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * ada-lang.c (ada_language_defn): Initialise new field.
5150         * c-lang.c (c_is_string_type_p): New function.
5151         (c_language_defn): Initialise new field.
5152         (cplus_language_defn): Initialise new field.
5153         (asm_language_defn): Initialise new field.
5154         (minimal_language_defn): Initialise new field.
5155         * c-lang.h (c_is_string_type_p): Declare new function.
5156         * d-lang.c (d_language_defn): Initialise new field.
5157         * f-lang.c (f_is_string_type_p): New function.
5158         (f_language_defn): Initialise new field.
5159         * go-lang.c (go_is_string_type_p): New function.
5160         (go_language_defn): Initialise new field.
5161         * language.c (default_is_string_type_p): New function.
5162         (unknown_language_defn): Initialise new field.
5163         (auto_language_defn): Initialise new field.
5164         * language.h (struct language_defn) <la_is_string_type_p>: New
5165         member variable.
5166         (default_is_string_type_p): Declare new function.
5167         * m2-lang.c (m2_language_defn): Initialise new field.
5168         * objc-lang.c (objc_language_defn): Initialise new field.
5169         * opencl-lang.c (opencl_language_defn): Initialise new field.
5170         * p-lang.c (pascal_is_string_type_p): New function.
5171         (pascal_language_defn): Initialise new field.
5172         * rust-lang.c (rust_is_string_type_p): New function.
5173         (rust_language_defn): Initialise new field.
5174
5175 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5176
5177         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5178         New field.
5179         * ada-lang.c (ada_language_defn): Initialise new field.
5180         * c-lang.c (c_language_defn): Likewise.
5181         (cplus_language_defn): Likewise.
5182         (asm_language_defn): Likewise.
5183         (minimal_language_defn): Likewise.
5184         * d-lang.c (d_language_defn): Likewise.
5185         * f-lang.c (f_language_defn): Likewise.
5186         * go-lang.c (go_language_defn): Likewise.
5187         * language.c (unknown_language_defn): Likewise.
5188         (auto_language_defn): Likewise.
5189         * m2-lang.c (m2_language_defn): Likewise.
5190         * objc-lang.c (objc_language_defn): Likewise.
5191         * opencl-lang.c (opencl_language_defn): Likewise.
5192         * p-lang.c (pascal_language_defn): Likewise.
5193         * rust-lang.c (rust_language_defn): Likewise.
5194
5195 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * ada-lang.c (ada_is_character_type): Change return type to bool.
5198         (ada_is_string_type): Likewise.
5199         * ada-lang.h (ada_is_character_type): Update declaration
5200         (ada_is_string_type): Likewise.
5201
5202 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5203
5204         Support style in 'frame|thread apply'
5205
5206         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5207         * record.c (record_start, record_stop): Update callers of
5208         execute_command_to_string with false.
5209         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5210         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5211         methods.
5212         (class string_file): New constructor with term_out parameter.
5213         Override methods term_out and can_emit_style_escape.  New member
5214         term_out.
5215         (class stdio_file): Override can_emit_style_escape.
5216         (class tee_file): Override term_out and can_emit_style_escape.
5217         * utils.h (can_emit_style_escape): Remove.
5218         * utils.c (can_emit_style_escape): Likewise.
5219         Update all callers of can_emit_style_escape (SOMESTREAM) to
5220         SOMESTREAM->can_emit_style_escape.
5221         * source-cache.c (source_cache::get_source_lines): Likewise.
5222         * stack.c (frame_apply_command_count): Call execute_command_to_string
5223         passing the term_out characteristic of the current gdb_stdout.
5224         * thread.c (thr_try_catch_cmd): Likewise.
5225         * top.c (execute_command_to_string): pass term_out parameter
5226         to construct the string_file for the command output.
5227         * ui-file.c (term_cli_styling): New function (most code moved
5228         from utils.c can_emit_style_escape).
5229         (string_file::string_file, string_file::can_emit_style_escape,
5230         stdio_file::can_emit_style_escape, tee_file::term_out,
5231         tee_file::can_emit_style_escape): New functions.
5232
5233 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5234
5235         * NEWS: Mention the new set|show may-call-functions.
5236         * infcall.c (may_call_functions_p): New variable.
5237         (show_may_call_functions_p): New function.
5238         (call_function_by_hand_dummy): Throws an error if not
5239         may-call-functions.
5240         (_initialize_infcall): Call add_setshow_boolean_cmd for
5241         may-call-functions.
5242
5243 2019-04-25  Keith Seitz  <keiths@redhat.com>
5244
5245         PR c++/24367
5246         * cp-support.c (inspect_type): Don't attempt substitutions
5247         of symbol with the same name.
5248
5249 2019-04-25  Tom Tromey  <tromey@adacore.com>
5250
5251         PR gdb/24475:
5252         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5253         static.
5254
5255 2019-04-25  Tom Tromey  <tromey@adacore.com>
5256
5257         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5258         rvalue reference.
5259         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5260         (gdb_xml_parser::parse): Use std::move.
5261         * python/python-internal.h (gdbpy_convert_exception): Take a const
5262         reference.
5263         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5264         std::move.
5265         * python/py-utils.c (gdbpy_convert_exception): Take a const
5266         reference.
5267         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5268         Use std::move.
5269         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5270         Use std::move.
5271         * mi/mi-main.c (mi_print_exception): Take a const reference.
5272         * main.c (handle_command_errors): Take a const reference.
5273         * linespec.c (parse_linespec): Use std::move.
5274         * infcall.c (run_inferior_call): Use std::move.
5275         (call_function_by_hand_dummy): Use std::move.
5276         * exec.c (try_open_exec_file): Use std::move.
5277         * exceptions.h (exception_print, exception_fprintf)
5278         (exception_print_same): Update.
5279         * exceptions.c (print_exception, exception_print)
5280         (exception_fprintf, exception_print_same): Change parameters to
5281         const reference.
5282         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5283         * common/new-op.c: Use std::move.
5284         * common/common-exceptions.h (struct gdb_exception): Add move
5285         constructor.
5286         (struct gdb_exception_error, struct gdb_exception_quit, struct
5287         gdb_quit_bad_alloc): Change constructor to move constructor.
5288         (throw_exception): Change parameter to rvalue reference.
5289         * common/common-exceptions.c (throw_exception): Take rvalue
5290         reference.
5291         * cli/cli-interp.c (safe_execute_command): Use std::move.
5292         * breakpoint.c (insert_bp_location, location_to_sals): Use
5293         std::move.
5294
5295 2019-04-25  Tom Tromey  <tromey@adacore.com>
5296
5297         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5298         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5299         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5300         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5301         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5302         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5303         guile/scm-value.c: Use unpack.
5304         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5305         gdbscm_gdb_exception.
5306         (gdbscm_throw_gdb_exception): Likewise.
5307         (struct gdbscm_gdb_exception): New.
5308         (unpack): New function.
5309         (gdbscm_wrap): Use unpack.
5310
5311 2019-04-25  Tom Tromey  <tromey@adacore.com>
5312
5313         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5314         (gdb_rl_callback_handler): Use std::move.
5315         * common/common-exceptions.h (struct gdb_exception): Add move
5316         assignment operator.
5317         (throw_exception_sjlj): Change "exception" to const reference.
5318         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5319         (throw_exception_sjlj): Change "exception" to const reference.
5320
5321 2019-04-25  Tom Tromey  <tromey@adacore.com>
5322
5323         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5324         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5325         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5326         Update.
5327         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5328         Update.
5329         * mi/mi-interp.c (mi_interp::exec): Update.
5330         * linespec.c (parse_linespec): Update.
5331         * infcall.c (run_inferior_call): Update.
5332         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5333         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5334         (gdbscm_lookup_global_symbol): Update.
5335         * guile/scm-param.c (gdbscm_parameter_value): Update.
5336         * guile/scm-frame.c (gdbscm_frame_read_register)
5337         (gdbscm_frame_read_var): Update.
5338         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5339         * exec.c (try_open_exec_file): Update.
5340         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5341         (gdb_rl_callback_handler): Update.
5342         * common/common-exceptions.h (exception_none): Don't declare.
5343         * common/common-exceptions.c (exception_none): Don't define.
5344         (struct catcher) <exception>: Update.
5345         * cli/cli-interp.c (safe_execute_command): Update.
5346         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5347
5348 2019-04-25  Ali Tamur  <tamur@google.com>
5349
5350         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5351         (read_attribute_value): Likewise.
5352         (dwarf2_read_addr_index): Update comment.
5353         (read_str_index): Add DW_FORM_strx.
5354         (dwarf2_string_attr): Likewise.
5355         (dwarf2_const_value_attr): Likewise.
5356         (dump_die_shallow): Likewise.
5357         (dwarf2_fetch_constant_bytes): Likewise.
5358         (skip_form_bytes): Likewise.
5359         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5360
5361 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5362
5363         PR corefiles/11608
5364         PR corefiles/18187
5365         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5366         OFFSET.  Verify if current mapping contains an ELF header.
5367         (linux_find_memory_regions_full): Adjust call to
5368         dump_mapping_p.
5369
5370 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5371             Kang Li <kanglictf@gmail.com>
5372
5373         PR gdb/21600
5374
5375         * dwarf2-frame.c (read_initial_length): Be consistent about using
5376         unsigned representation of length.
5377         (decode_frame_entry_1): Likewise.  Check for wraparound of
5378         end pointer as well as buffer overflow.
5379
5380 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5381
5382         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5383         "vq".
5384
5385 2019-04-24  Tom Tromey  <tromey@adacore.com>
5386
5387         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5388
5389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * s12z-tdep.c (s12z_unwind_pc): Delete.
5392         (s12z_unwind_sp): Delete.
5393         (s12z_gdbarch_init): Don't register deleted functions with
5394         gdbarch.
5395
5396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * rl78-tdep.c (rl78_unwind_sp): Delete.
5399         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5400
5401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5404         (xstormy16_unwind_pc): Delete.
5405         (xstormy16_dummy_id): Delete.
5406         (xstormy16_gdbarch_init): Don't register deleted functions with
5407         gdbarch.
5408
5409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5410
5411         * vax-tdep.c (vax_unwind_pc): Delete.
5412         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5413
5414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * v850-tdep.c (v850_unwind_sp): Delete.
5417         (v850_unwind_pc): Delete.
5418         (v850_dummy_id): Delete.
5419         (v850_gdbarch_init): Don't register deleted functions with
5420         gdbarch.
5421
5422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5423
5424         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5425         (tilegx_unwind_pc): Delete.
5426         (tilegx_unwind_dummy_id): Delete.
5427         (tilegx_gdbarch_init): Don't register deleted functions with
5428         gdbarch.
5429
5430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5431
5432         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5433         (tic6x_dummy_id): Delete.
5434         (tic6x_gdbarch_init): Don't register deleted functions with
5435         gdbarch.
5436
5437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5438
5439         * sparc-tdep.c (sparc_unwind_pc): Delete.
5440         (sparc32_gdbarch_init): Don't register deleted function with
5441         gdbarch.
5442
5443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5444
5445         * sh-tdep.c (sh_unwind_sp): Delete.
5446         (sh_unwind_pc): Delete.
5447         (sh_dummy_id): Delete.
5448         (sh_gdbarch_init): Don't register deleted functions with
5449         gdbarch.
5450
5451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5452
5453         * score-tdep.c (score_unwind_sp): Delete.
5454         (score_unwind_pc): Delete.
5455         (score_dummy_id): Delete.
5456         (score_gdbarch_init): Don't register deleted functions with
5457         gdbarch.
5458
5459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * rx-tdep.c (rx_unwind_pc): Delete.
5462         (rx_unwind_sp): Delete.
5463         (rx_dummy_id): Delete.
5464         (rx_gdbarch_init): Don't register deleted functions with
5465         gdbarch.  Update comment.
5466
5467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5468
5469         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5470         (rs6000_dummy_id): Delete.
5471         (rs6000_gdbarch_init): Don't register deleted functions with
5472         gdbarch.
5473
5474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * or1k-tdep.c (or1k_dummy_id): Delete.
5477         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5478
5479 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * nios2-tdep.c (nios2_dummy_id): Delete.
5482         (nios2_unwind_sp): Delete.
5483         (nios2_gdbarch_init): Don't register deleted functions with
5484         gdbarch.
5485
5486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5487
5488         * nds32-tdep.c (nds32_dummy_id): Delete.
5489         (nds32_unwind_pc): Delete.
5490         (nds32_unwind_sp): Delete.
5491         (nds32_gdbarch_init): Don't register deleted functions with
5492         gdbarch.
5493
5494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * msp430-tdep.c (msp430_unwind_pc): Delete.
5497         (msp430_unwind_sp): Delete.
5498         (msp430_dummy_id): Delete.
5499         (msp430_gdbarch_init): Don't register deleted functions with
5500         gdbarch.
5501
5502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5503
5504         * moxie-tdep.c (moxie_unwind_sp): Delete.
5505         (moxie_unwind_pc): Delete.
5506         (moxie_dummy_id): Delete.
5507         (moxie_gdbarch_init): Don't register deleted functions with
5508         gdbarch.
5509
5510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5513         (mn10300_unwind_pc): Delete.
5514         (mn10300_unwind_sp): Delete.
5515         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5516         mn10300_unwind_sp.
5517         (mn10300_frame_unwind_init): Don't register deleted functions with
5518         gdbarch.
5519
5520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5521
5522         * mep-tdep.c (mep_unwind_pc): Delete.
5523         (mep_unwind_sp): Delete.
5524         (mep_dummy_id): Delete.
5525         (mep_gdbarch_init): Don't register deleted functions with
5526         gdbarch.
5527
5528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5529
5530         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5531         (m68hc11_unwind_sp): Delete.
5532         (m68hc11_gdbarch_init): Don't register deleted functions with
5533         gdbarch.
5534
5535 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * m32r-tdep.c (m32r_unwind_sp): Delete.
5538         (m32r_unwind_pc): Delete.
5539         (m32r_dummy_id): Delete.
5540         (m32r_gdbarch_init): Don't register deleted functions with
5541         gdbarch.
5542
5543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * m32c-tdep.c (m32c_unwind_pc): Delete.
5546         (m32c_unwind_sp): Delete.
5547         (m32c_dummy_id): Delete.
5548         (m32c_gdbarch_init): Don't register deleted functions with
5549         gdbarch.
5550
5551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5554         (lm32_unwind_pc): Delete.
5555         (lm32_dummy_id): Delete.
5556         (lm32_gdbarch_init): Don't register deleted functions with
5557         gdbarch.
5558
5559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5560
5561         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5562         (iq2000_unwind_pc): Delete.
5563         (iq2000_dummy_id): Delete.
5564         (iq2000_gdbarch_init): Don't register deleted functions with
5565         gdbarch.
5566
5567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5568
5569         * nds32-tdep.c (nds32_type_align): Delete.
5570         (nds32_push_dummy_call): Use type_align instead.
5571
5572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5573
5574         * arm-tdep.c (arm_type_align): Only handle vector override case.
5575         (arm_push_dummy_call): Use type_align.
5576         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5577
5578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5581         case.
5582         (pass_on_stack): Use type_align.
5583         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5584         function.
5585
5586 2019-04-23  Tom Tromey  <tromey@adacore.com>
5587
5588         * dwarf2read.c (line_header::file_name_at): Remove unused
5589         overload.
5590
5591 2019-04-23  Tom de Vries  <tdevries@suse.de>
5592
5593         PR gdb/24438
5594         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5595         invocation.
5596
5597
5598 2019-03-27  Ali Tamur  <tamur@google.com>
5599
5600         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5601         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5602         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5603         (dwarf_expr_context::get_addr_index): Likewise
5604         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5605         (symbol_needs_eval_context::get_addr_index): Likewise
5606         (disassemble_dwarf_expression): Add DW_OP_addrx
5607         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5608         (read_cutu_die_from_dwo): Update comment
5609         (skip_one_die): Add DW_FORM_addrx
5610         (read_attribute_value): Likewise
5611         (var_decode_location): Add DW_OP_addrx
5612         (dwarf2_const_value_attr): Add DW_FORM_addrx
5613         (dump_die_shallow): Likewise
5614         (dwarf2_fetch_constant_bytes): Likewise
5615         (decode_locdesc): Add DW_OP_addrx
5616         (skip_form_bytes): Add DW_FORM_addrx
5617
5618 2019-04-22  Ali Tamur  <tamur@google.com>
5619
5620         * MAINTAINERS (Write After Approval): Add self.
5621
5622 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5623
5624         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5625         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5626         (open_symbol_file_object): Likewise.
5627         (svr4_default_sos): Add info parameter.
5628         (svr4_read_so_list): Likewise.
5629         (svr4_current_sos_direct): Adjust functions calls to pass down
5630         info.
5631         (svr4_current_sos_1): Add info parameter.
5632         (svr4_current_sos): Call get_svr4_info, pass info down to
5633         svr4_current_sos_1.
5634         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5635         get_svr4_info.
5636         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5637         get_svr4_info.
5638         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5639         to get_svr4_info.
5640         (probes_table_remove_objfile_probes): Likewise.
5641         (register_solib_event_probe): Add info parameter.
5642         (solist_update_incremental): Pass info parameter down to
5643         svr4_read_so_list.
5644         (disable_probes_interface): Add info parameter.
5645         (svr4_handle_solib_event): Pass current_program_space to
5646         get_svr4_info.  Adjust disable_probes_interface cleanup.
5647         (svr4_create_probe_breakpoints): Add info parameter, pass it
5648         down to register_solib_event_probe.
5649         (svr4_create_solib_event_breakpoints): Add info parameter,
5650         pass it down to svr4_create_probe_breakpoints.
5651         (enable_break): Pass info down to
5652         svr4_create_solib_event_breakpoints.
5653         (svr4_solib_create_inferior_hook): Pass current_program_space to
5654         get_svr4_info.
5655         (svr4_clear_solib): Likewise.
5656
5657 2019-04-22  Pedro Alves  <palves@redhat.com>
5658
5659         * solib-svr4.c (svr4_free_objfile_observer): New.
5660         (probe_and_action::objfile): New field.
5661         (probes_table_htab_remove_objfile_probes)
5662         (probes_table_remove_objfile_probes): New functions.
5663         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5664         in the new probe_and_action.  Don't store the probe in 'lookup'.
5665         (svr4_create_probe_breakpoints): Pass objfile to
5666         register_solib_event_probe.
5667         (_initialize_svr4_solib): Register a free_objfile observer.
5668
5669 2019-04-19  Tom Tromey  <tom@tromey.com>
5670
5671         * common/queue.h: Remove.
5672
5673 2019-04-19  Tom Tromey  <tom@tromey.com>
5674
5675         * event-loop.c: Don't include "common/queue.h".
5676
5677 2019-04-19  Tom Tromey  <tom@tromey.com>
5678
5679         * remote.c (remote_target): Use delete.
5680         * remote-notif.h: Include <list>, not "common/queue.h".
5681         (notif_client_p): Remove typedef.
5682         (remote_notif_state): Add constructor, destructor, initializer.
5683         <notif_queue>: Now a std::list.
5684         (remote_notif_state_xfree): Don't declare.
5685         * remote-notif.c (remote_notif_process, handle_notification)
5686         (remote_notif_state_allocate): Update.
5687         (~remote_notif_state): Rename from remote_notif_state_xfree.
5688
5689 2019-04-19  Tom Tromey  <tom@tromey.com>
5690
5691         * symfile.c (reread_symbols): Update.
5692         * objfiles.c (objfile_register_static_link)
5693         (objfile_lookup_static_link): Update
5694         (~objfile) Don't delete static_links.
5695         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5696
5697 2019-04-19  Tom Tromey  <tom@tromey.com>
5698
5699         * type-stack.h (struct type_stack) <insert>: Constify string.
5700         * type-stack.c (type_stack::insert): Constify string.
5701         * gdbtypes.h (lookup_template_type): Update.
5702         (address_space_name_to_int): Update.
5703         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5704         const.
5705         (lookup_template_type): Make name const.
5706         * c-exp.y: Update rules.
5707         (lex_one_token, classify_name, classify_inner_name)
5708         (c_print_token): Update.
5709         * p-exp.y: Update rules.
5710         (yylex): Update.
5711         * f-exp.y: Update rules.
5712         (yylex): Update.
5713         * d-exp.y: Update rules.
5714         (lex_one_token, classify_name, classify_inner_name): Update.
5715         * parse.c (write_dollar_variable, copy_name): Return std::string.
5716         * parser-defs.h (copy_name): Change return type.
5717         * m2-exp.y: Update rules.
5718         (yylex): Update.
5719         * go-exp.y (lex_one_token): Update.
5720         Update rules.
5721         (classify_unsafe_function, classify_packaged_name)
5722         (classify_name, yylex): Update.
5723
5724 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5725
5726         * configure.ac: add --enable-source-highlight switch.
5727         * configure: Regenerate.
5728         * top.c (print_gdb_version): plumb --enable-source-highlight
5729         status to "show configuration".
5730
5731 2019-04-19  Tom Tromey  <tromey@adacore.com>
5732
5733         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5734         Check ADA_TYPE_P.
5735         (empty_record, ada_template_to_fixed_record_type_1)
5736         (template_to_static_fixed_type)
5737         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5738         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5739         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5740         macros.
5741
5742 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5743
5744         PR symtab/24423:
5745         * source.c (print_source_lines_base): Advance "iter" when a
5746         control character is seen.
5747
5748 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5749
5750         * inferior.h (struct infcall_suspend_state_deleter):
5751         Catch exception in destructor to avoid crash.
5752
5753 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5754
5755         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5756         close to the add_com "shell".
5757
5758 2019-04-18  Tom Tromey  <tromey@adacore.com>
5759
5760         * process-stratum-target.h (class process_stratum_target)
5761         <stratum>: Add "final".
5762
5763 2019-04-17  Tom Tromey  <tromey@adacore.com>
5764
5765         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5766         against nullptr before use.
5767
5768 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5769
5770         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5771
5772 2019-04-17  Jim Wilson  <jimw@sifive.com>
5773             Andrew Burgess  <andrew.burgess@embecosm.com>
5774
5775         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5776         code read might fail, assume 4-byte breakpoint in that case.
5777
5778 2019-04-15  Leszek Swirski  <leszeks@google.com>
5779
5780         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5781         rather than a hand-rolled POD check when checking for forced MEMORY
5782         classification.
5783
5784 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5785
5786         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5787         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5788         function.
5789         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5790         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5791         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5792         declaration.
5793
5794 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5795
5796         * aarch64-linux-nat.c
5797         (aarch64_linux_nat_target::thread_architecture): Add override.
5798         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5799         each VQ.
5800
5801 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5802
5803         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5804
5805 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5806
5807         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5808         target types of size 96-bits, add some additional comments, and
5809         check that the builtin type we found was the correct size.
5810
5811 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5812
5813         * utils.c (prompt_for_continue): Don't restore the styling at the
5814         end, as applied_style has the wrong value.  This fixes styling in
5815         long lists of file names that are interrupted by the "Continue?"
5816         prompt.
5817
5818 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5821         * c-lang.c (c_language_defn): Likewise.
5822         (cplus_language_defn): Likewise.
5823         (asm_language_defn): Likewise.
5824         (minimal_language_defn): Likewise.
5825         * d-lang.c (d_language_defn): Likewise.
5826         * f-lang.c (f_language_defn): Likewise.
5827         * go-lang.c (go_language_defn): Likewise.
5828         * language.c (unknown_language_defn): Likewise.
5829         (auto_language_defn): Likewise.
5830         * language.h (struct language_defn): Remove la_magic field.
5831         (LANG_MAGIC): Delete.
5832         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5833         * objc-lang.c (objc_language_defn): Likewise.
5834         * opencl-lang.c (opencl_language_defn): Likewise.
5835         * p-lang.c (pascal_language_defn): Likewise.
5836         * rust-lang.c (rust_language_defn): Likewise.
5837
5838 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5839
5840         * riscv-tdep.c (riscv_type_align): New function.
5841         (riscv_type_alignment): Delete.
5842         (riscv_arg_location): Use 'type_align'.
5843         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5844
5845 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * gdbtypes.c (type_align): A struct with no non-static fields also
5848         has alignment of 1.
5849
5850 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5853         component to 0.
5854         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5855         member.
5856         (riscv_struct_info::analyse): New implementation using new
5857         analyse_inner member function.
5858         (riscv_struct_info::field_offset): New member function.
5859         (riscv_struct_info::m_offsets): New member variable.
5860         (riscv_struct_info::analyse_inner): New private member function,
5861         takes the old implementation of riscv_struct_info::analyse but
5862         extended to track field offsets.
5863         (riscv_call_arg_struct): Update the struct folding special cases
5864         to handle cases where empty C++ structs, which are non-zero
5865         length, are found.
5866         (riscv_arg_location): Initialise the length of each location, a
5867         non-zero length now indicates the location is in use.
5868         (riscv_push_dummy_call): Allow for the first location having a
5869         non-zero offset when setting up arguments.
5870         (riscv_return_value): Likewise, but for return values.
5871
5872 2019-04-11  Tom Tromey  <tromey@adacore.com>
5873
5874         * utils.c (internal_vproblem): Make "msg" const.
5875
5876 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5877
5878         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5879         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5880         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5881         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5882
5883 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5884
5885         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5886         function.
5887         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5888         of amd64_collect_native_gregset.
5889         (amd64_linux_nat_target::store_registers): Likewise.
5890
5891 2019-04-10  Tom Tromey  <tom@tromey.com>
5892
5893         * symtab.c (lookup_global_symbol_from_objfile)
5894         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5895         * objfiles.h (class separate_debug_iterator): New.
5896         (class separate_debug_range): New.
5897         (struct objfile) <separate_debug_objfiles>: New method.
5898         (objfile_separate_debug_iterate): Don't declare.
5899         * objfiles.c (separate_debug_iterator::operator++): Rename from
5900         objfile_separate_debug_iterate.
5901         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5902         iterator.
5903         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5904         iterator.
5905
5906 2019-04-10  Tom Tromey  <tom@tromey.com>
5907
5908         * symfile.c (reread_symbols): Remove old comment.
5909         * objfiles.c (free_all_objfiles): Fix a typo.
5910
5911 2019-04-10  Tom Tromey  <tom@tromey.com>
5912
5913         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5914         * minsyms.c (lookup_minimal_symbol): Use foreach.
5915         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5916         (lookup_minimal_symbol_solib_trampoline): Likewise.
5917         * symfile.c (reread_symbols): Use foreach.
5918
5919 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5920             Tom Tromey  <tromey@adacore.com>
5921
5922         PR rust/24414:
5923         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5924         (rust_lex_int_test): Change "value" to be LONGEST.
5925         (rust_lex_tests): Add test for long integer literal.
5926
5927 2019-04-09  Tom Tromey  <tromey@adacore.com>
5928
5929         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5930         to bool.
5931         (extended_remote_target::attach): Update.
5932         (remote_target::remote_notice_new_inferior): Update.
5933         (remote_target::add_current_inferior_and_thread): Update.
5934         * inferior.c (exit_inferior_1): Use "false".
5935         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5936
5937 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5938
5939         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5940         the "start" command.
5941
5942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5943
5944         * python/py-inferior.c (infpy_thread_from_thread_handle):
5945         Adjust comments to reflect renaming of thread_from_thread_handle
5946         to thread_from_handle.  Adjust keywords.  Fix type error message.
5947         (inferior_object_methods): Add thread_from_handle.  Retain
5948         thread_from_thread_handle, but mark it as deprecated.
5949
5950 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5951
5952         * gdbthread.h (find_thread_by_handle): Revise declaration.
5953         * thread.c (find_thread_by_handle): Likewise.  Adjust
5954         implementation too.
5955         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5956         support for buffer objects as handles.
5957
5958 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5959
5960         * python/py-infthread.c (thpy_thread_handle): New function.
5961         (thread_object_methods): Register thpy_thread_handle.
5962
5963 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5964
5965         * gdbthread.h (thread_to_thread_handle): Declare.
5966         * thread.c (gdbtypes.h): Include.
5967         (thread_to_thread_handle): New function.
5968
5969         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5970         (target_thread_info_to_thread_handle): Declare.
5971         * target.c (target_thread_info_to_thread_handle): New function.
5972         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5973         * target-delegates.c: Regenerate.
5974
5975         * linux-thread-db.c (class thread_db_target): Add method
5976         thread_info_to_thread_handle.
5977         (thread_db_target::thread_info_to_thread_handle): Define.
5978         * remote.c (class remote_target): Add new method
5979         thread_info_to_thread_handle.
5980         (remote_target::thread_info_to_thread_handle): Define.
5981
5982 2019-04-08  Pedro Alves  <palves@redhat.com>
5983
5984         * common/common-exceptions.c (throw_exception): Don't create
5985         named object to throw; throw directly.
5986         (throw_it): Likewise.  Don't initialize gdb_exception::message
5987         here, with new; pass FMT and AP to the ctor instead.
5988         * common/common-exceptions.h: Include <string>.
5989         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5990         const char *, va_list)): New ctor.  Use std::make_shared.
5991         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5992         errors)): Delete.
5993         (gdb_exception_error::gdb_exception_error(enum errors, const char
5994         *, va_list)): New.
5995         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5996         Add assertion.
5997         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5998         errors)): Delete.
5999         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6000         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6001         Add assertion.
6002
6003 2019-04-08  Tom Tromey  <tom@tromey.com>
6004
6005         * valops.c (value_rtti_indirect_type): Replace throw_exception
6006         with throw.
6007         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6008         with throw.
6009         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6010         throw.
6011         * target.c (target_translate_tls_address): Replace throw_exception
6012         with throw.
6013         * stack.c (frame_apply_command_count): Replace throw_exception
6014         with throw.
6015         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6016         throw.
6017         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6018         with throw.
6019         * rs6000-tdep.c (rs6000_frame_cache)
6020         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6021         * remote.c: Replace throw_exception with throw.
6022         * record-full.c (record_full_message, record_full_wait_1)
6023         (record_full_restore): Replace throw_exception with throw.
6024         * record-btrace.c:
6025         (get_thread_current_frame_id, record_btrace_start_replaying)
6026         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6027         (cmd_record_btrace_start): Replace throw_exception with throw.
6028         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6029         throw.
6030         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6031         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6032         * linespec.c:
6033         (find_linespec_symbols): Replace throw_exception with throw.
6034         * infrun.c (displaced_step_prepare, resume): Replace
6035         throw_exception with throw.
6036         * infcmd.c (post_create_inferior): Replace throw_exception with
6037         throw.
6038         * inf-loop.c (inferior_event_handler): Replace throw_exception
6039         with throw.
6040         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6041         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6042         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6043         (get_prev_frame_always, get_frame_pc_if_available)
6044         (get_frame_address_in_block_if_available, get_frame_language):
6045         Replace throw_exception with throw.
6046         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6047         throw_exception with throw.
6048         * eval.c (fetch_subexp_value, evaluate_var_value)
6049         (evaluate_funcall, evaluate_subexp_standard): Replace
6050         throw_exception with throw.
6051         * dwarf2loc.c (call_site_find_chain)
6052         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6053         Replace throw_exception with throw.
6054         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6055         with throw.
6056         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6057         throw.
6058         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6059         * completer.c (complete_line_internal): Replace throw_exception
6060         with throw.
6061         * compile/compile-object-run.c (compile_object_run): Replace
6062         throw_exception with throw.
6063         * cli/cli-script.c (process_next_line): Replace throw_exception
6064         with throw.
6065         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6066         (btrace_enable, btrace_maint_update_pt_packets): Replace
6067         throw_exception with throw.
6068         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6069         throw_exception with throw.
6070         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6071         throw_exception with throw.
6072         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6073         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6074         * aarch64-tdep.c (aarch64_make_prologue_cache)
6075         (aarch64_make_stub_cache): Replace throw_exception with throw.
6076
6077 2019-04-08  Tom Tromey  <tom@tromey.com>
6078
6079         * common/common-exceptions.c (throw_exception): Rename from
6080         throw_exception_cxx.  Remove old copy.  Make argument const.
6081         (throw_it): Create and throw exception objects directly.
6082         * common/common-exceptions.h (throw_exception): Make argument
6083         const.
6084         (struct gdb_exception_error): Add constructor.
6085         (struct gdb_exception_quit): Add constructor.
6086
6087 2019-04-08  Tom Tromey  <tom@tromey.com>
6088
6089         * common/common-exceptions.h (exception_rethrow): Don't declare.
6090         (TRY_SJLJ): Update comment.
6091         (TRY, CATCH, END_CATCH): Remove.
6092         * common/common-exceptions.c (exception_rethrow): Remove.
6093
6094 2019-04-08  Tom Tromey  <tom@tromey.com>
6095
6096         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6097         Remove.
6098         (gdb_exception_error): Rename from
6099         gdb_exception_RETURN_MASK_ERROR.
6100         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6101         (gdb_quit_bad_alloc): Update.
6102         * aarch64-tdep.c: Update.
6103         * ada-lang.c: Update.
6104         * ada-typeprint.c: Update.
6105         * ada-valprint.c: Update.
6106         * amd64-tdep.c: Update.
6107         * arch-utils.c: Update.
6108         * break-catch-throw.c: Update.
6109         * breakpoint.c: Update.
6110         * btrace.c: Update.
6111         * c-varobj.c: Update.
6112         * cli/cli-cmds.c: Update.
6113         * cli/cli-interp.c: Update.
6114         * cli/cli-script.c: Update.
6115         * common/common-exceptions.c: Update.
6116         * common/new-op.c: Update.
6117         * common/selftest.c: Update.
6118         * compile/compile-c-symbols.c: Update.
6119         * compile/compile-cplus-symbols.c: Update.
6120         * compile/compile-object-load.c: Update.
6121         * compile/compile-object-run.c: Update.
6122         * completer.c: Update.
6123         * corelow.c: Update.
6124         * cp-abi.c: Update.
6125         * cp-support.c: Update.
6126         * cp-valprint.c: Update.
6127         * darwin-nat.c: Update.
6128         * disasm-selftests.c: Update.
6129         * dtrace-probe.c: Update.
6130         * dwarf-index-cache.c: Update.
6131         * dwarf-index-write.c: Update.
6132         * dwarf2-frame-tailcall.c: Update.
6133         * dwarf2-frame.c: Update.
6134         * dwarf2loc.c: Update.
6135         * dwarf2read.c: Update.
6136         * eval.c: Update.
6137         * event-loop.c: Update.
6138         * event-top.c: Update.
6139         * exec.c: Update.
6140         * f-valprint.c: Update.
6141         * fbsd-tdep.c: Update.
6142         * frame-unwind.c: Update.
6143         * frame.c: Update.
6144         * gdbtypes.c: Update.
6145         * gnu-v3-abi.c: Update.
6146         * guile/guile-internal.h: Update.
6147         * guile/scm-block.c: Update.
6148         * guile/scm-breakpoint.c: Update.
6149         * guile/scm-cmd.c: Update.
6150         * guile/scm-disasm.c: Update.
6151         * guile/scm-frame.c: Update.
6152         * guile/scm-lazy-string.c: Update.
6153         * guile/scm-math.c: Update.
6154         * guile/scm-param.c: Update.
6155         * guile/scm-ports.c: Update.
6156         * guile/scm-pretty-print.c: Update.
6157         * guile/scm-symbol.c: Update.
6158         * guile/scm-symtab.c: Update.
6159         * guile/scm-type.c: Update.
6160         * guile/scm-value.c: Update.
6161         * i386-linux-tdep.c: Update.
6162         * i386-tdep.c: Update.
6163         * inf-loop.c: Update.
6164         * infcall.c: Update.
6165         * infcmd.c: Update.
6166         * infrun.c: Update.
6167         * jit.c: Update.
6168         * language.c: Update.
6169         * linespec.c: Update.
6170         * linux-fork.c: Update.
6171         * linux-nat.c: Update.
6172         * linux-tdep.c: Update.
6173         * linux-thread-db.c: Update.
6174         * main.c: Update.
6175         * mi/mi-cmd-break.c: Update.
6176         * mi/mi-cmd-stack.c: Update.
6177         * mi/mi-interp.c: Update.
6178         * mi/mi-main.c: Update.
6179         * objc-lang.c: Update.
6180         * p-valprint.c: Update.
6181         * parse.c: Update.
6182         * ppc-linux-tdep.c: Update.
6183         * printcmd.c: Update.
6184         * python/py-arch.c: Update.
6185         * python/py-breakpoint.c: Update.
6186         * python/py-cmd.c: Update.
6187         * python/py-finishbreakpoint.c: Update.
6188         * python/py-frame.c: Update.
6189         * python/py-framefilter.c: Update.
6190         * python/py-gdb-readline.c: Update.
6191         * python/py-inferior.c: Update.
6192         * python/py-infthread.c: Update.
6193         * python/py-lazy-string.c: Update.
6194         * python/py-linetable.c: Update.
6195         * python/py-objfile.c: Update.
6196         * python/py-param.c: Update.
6197         * python/py-prettyprint.c: Update.
6198         * python/py-progspace.c: Update.
6199         * python/py-record-btrace.c: Update.
6200         * python/py-record.c: Update.
6201         * python/py-symbol.c: Update.
6202         * python/py-type.c: Update.
6203         * python/py-unwind.c: Update.
6204         * python/py-utils.c: Update.
6205         * python/py-value.c: Update.
6206         * python/python.c: Update.
6207         * record-btrace.c: Update.
6208         * record-full.c: Update.
6209         * remote-fileio.c: Update.
6210         * remote.c: Update.
6211         * riscv-tdep.c: Update.
6212         * rs6000-aix-tdep.c: Update.
6213         * rs6000-tdep.c: Update.
6214         * rust-exp.y: Update.
6215         * rust-lang.c: Update.
6216         * s390-tdep.c: Update.
6217         * selftest-arch.c: Update.
6218         * solib-dsbt.c: Update.
6219         * solib-frv.c: Update.
6220         * solib-spu.c: Update.
6221         * solib-svr4.c: Update.
6222         * solib.c: Update.
6223         * sparc64-linux-tdep.c: Update.
6224         * stack.c: Update.
6225         * symfile-mem.c: Update.
6226         * symmisc.c: Update.
6227         * target.c: Update.
6228         * thread.c: Update.
6229         * top.c: Update.
6230         * tracefile-tfile.c: Update.
6231         * tui/tui.c: Update.
6232         * typeprint.c: Update.
6233         * unittests/cli-utils-selftests.c: Update.
6234         * unittests/parse-connection-spec-selftests.c: Update.
6235         * valops.c: Update.
6236         * valprint.c: Update.
6237         * value.c: Update.
6238         * varobj.c: Update.
6239         * windows-nat.c: Update.
6240         * x86-linux-nat.c: Update.
6241         * xml-support.c: Update.
6242
6243 2019-04-08  Tom Tromey  <tom@tromey.com>
6244
6245         * xml-support.c: Use C++ exception handling.
6246         * x86-linux-nat.c: Use C++ exception handling.
6247         * windows-nat.c: Use C++ exception handling.
6248         * varobj.c: Use C++ exception handling.
6249         * value.c: Use C++ exception handling.
6250         * valprint.c: Use C++ exception handling.
6251         * valops.c: Use C++ exception handling.
6252         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6253         handling.
6254         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6255         * typeprint.c: Use C++ exception handling.
6256         * tui/tui.c: Use C++ exception handling.
6257         * tracefile-tfile.c: Use C++ exception handling.
6258         * top.c: Use C++ exception handling.
6259         * thread.c: Use C++ exception handling.
6260         * target.c: Use C++ exception handling.
6261         * symmisc.c: Use C++ exception handling.
6262         * symfile-mem.c: Use C++ exception handling.
6263         * stack.c: Use C++ exception handling.
6264         * sparc64-linux-tdep.c: Use C++ exception handling.
6265         * solib.c: Use C++ exception handling.
6266         * solib-svr4.c: Use C++ exception handling.
6267         * solib-spu.c: Use C++ exception handling.
6268         * solib-frv.c: Use C++ exception handling.
6269         * solib-dsbt.c: Use C++ exception handling.
6270         * selftest-arch.c: Use C++ exception handling.
6271         * s390-tdep.c: Use C++ exception handling.
6272         * rust-lang.c: Use C++ exception handling.
6273         * rust-exp.y: Use C++ exception handling.
6274         * rs6000-tdep.c: Use C++ exception handling.
6275         * rs6000-aix-tdep.c: Use C++ exception handling.
6276         * riscv-tdep.c: Use C++ exception handling.
6277         * remote.c: Use C++ exception handling.
6278         * remote-fileio.c: Use C++ exception handling.
6279         * record-full.c: Use C++ exception handling.
6280         * record-btrace.c: Use C++ exception handling.
6281         * python/python.c: Use C++ exception handling.
6282         * python/py-value.c: Use C++ exception handling.
6283         * python/py-utils.c: Use C++ exception handling.
6284         * python/py-unwind.c: Use C++ exception handling.
6285         * python/py-type.c: Use C++ exception handling.
6286         * python/py-symbol.c: Use C++ exception handling.
6287         * python/py-record.c: Use C++ exception handling.
6288         * python/py-record-btrace.c: Use C++ exception handling.
6289         * python/py-progspace.c: Use C++ exception handling.
6290         * python/py-prettyprint.c: Use C++ exception handling.
6291         * python/py-param.c: Use C++ exception handling.
6292         * python/py-objfile.c: Use C++ exception handling.
6293         * python/py-linetable.c: Use C++ exception handling.
6294         * python/py-lazy-string.c: Use C++ exception handling.
6295         * python/py-infthread.c: Use C++ exception handling.
6296         * python/py-inferior.c: Use C++ exception handling.
6297         * python/py-gdb-readline.c: Use C++ exception handling.
6298         * python/py-framefilter.c: Use C++ exception handling.
6299         * python/py-frame.c: Use C++ exception handling.
6300         * python/py-finishbreakpoint.c: Use C++ exception handling.
6301         * python/py-cmd.c: Use C++ exception handling.
6302         * python/py-breakpoint.c: Use C++ exception handling.
6303         * python/py-arch.c: Use C++ exception handling.
6304         * printcmd.c: Use C++ exception handling.
6305         * ppc-linux-tdep.c: Use C++ exception handling.
6306         * parse.c: Use C++ exception handling.
6307         * p-valprint.c: Use C++ exception handling.
6308         * objc-lang.c: Use C++ exception handling.
6309         * mi/mi-main.c: Use C++ exception handling.
6310         * mi/mi-interp.c: Use C++ exception handling.
6311         * mi/mi-cmd-stack.c: Use C++ exception handling.
6312         * mi/mi-cmd-break.c: Use C++ exception handling.
6313         * main.c: Use C++ exception handling.
6314         * linux-thread-db.c: Use C++ exception handling.
6315         * linux-tdep.c: Use C++ exception handling.
6316         * linux-nat.c: Use C++ exception handling.
6317         * linux-fork.c: Use C++ exception handling.
6318         * linespec.c: Use C++ exception handling.
6319         * language.c: Use C++ exception handling.
6320         * jit.c: Use C++ exception handling.
6321         * infrun.c: Use C++ exception handling.
6322         * infcmd.c: Use C++ exception handling.
6323         * infcall.c: Use C++ exception handling.
6324         * inf-loop.c: Use C++ exception handling.
6325         * i386-tdep.c: Use C++ exception handling.
6326         * i386-linux-tdep.c: Use C++ exception handling.
6327         * guile/scm-value.c: Use C++ exception handling.
6328         * guile/scm-type.c: Use C++ exception handling.
6329         * guile/scm-symtab.c: Use C++ exception handling.
6330         * guile/scm-symbol.c: Use C++ exception handling.
6331         * guile/scm-pretty-print.c: Use C++ exception handling.
6332         * guile/scm-ports.c: Use C++ exception handling.
6333         * guile/scm-param.c: Use C++ exception handling.
6334         * guile/scm-math.c: Use C++ exception handling.
6335         * guile/scm-lazy-string.c: Use C++ exception handling.
6336         * guile/scm-frame.c: Use C++ exception handling.
6337         * guile/scm-disasm.c: Use C++ exception handling.
6338         * guile/scm-cmd.c: Use C++ exception handling.
6339         * guile/scm-breakpoint.c: Use C++ exception handling.
6340         * guile/scm-block.c: Use C++ exception handling.
6341         * guile/guile-internal.h: Use C++ exception handling.
6342         * gnu-v3-abi.c: Use C++ exception handling.
6343         * gdbtypes.c: Use C++ exception handling.
6344         * frame.c: Use C++ exception handling.
6345         * frame-unwind.c: Use C++ exception handling.
6346         * fbsd-tdep.c: Use C++ exception handling.
6347         * f-valprint.c: Use C++ exception handling.
6348         * exec.c: Use C++ exception handling.
6349         * event-top.c: Use C++ exception handling.
6350         * event-loop.c: Use C++ exception handling.
6351         * eval.c: Use C++ exception handling.
6352         * dwarf2read.c: Use C++ exception handling.
6353         * dwarf2loc.c: Use C++ exception handling.
6354         * dwarf2-frame.c: Use C++ exception handling.
6355         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6356         * dwarf-index-write.c: Use C++ exception handling.
6357         * dwarf-index-cache.c: Use C++ exception handling.
6358         * dtrace-probe.c: Use C++ exception handling.
6359         * disasm-selftests.c: Use C++ exception handling.
6360         * darwin-nat.c: Use C++ exception handling.
6361         * cp-valprint.c: Use C++ exception handling.
6362         * cp-support.c: Use C++ exception handling.
6363         * cp-abi.c: Use C++ exception handling.
6364         * corelow.c: Use C++ exception handling.
6365         * completer.c: Use C++ exception handling.
6366         * compile/compile-object-run.c: Use C++ exception handling.
6367         * compile/compile-object-load.c: Use C++ exception handling.
6368         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6369         * compile/compile-c-symbols.c: Use C++ exception handling.
6370         * common/selftest.c: Use C++ exception handling.
6371         * common/new-op.c: Use C++ exception handling.
6372         * cli/cli-script.c: Use C++ exception handling.
6373         * cli/cli-interp.c: Use C++ exception handling.
6374         * cli/cli-cmds.c: Use C++ exception handling.
6375         * c-varobj.c: Use C++ exception handling.
6376         * btrace.c: Use C++ exception handling.
6377         * breakpoint.c: Use C++ exception handling.
6378         * break-catch-throw.c: Use C++ exception handling.
6379         * arch-utils.c: Use C++ exception handling.
6380         * amd64-tdep.c: Use C++ exception handling.
6381         * ada-valprint.c: Use C++ exception handling.
6382         * ada-typeprint.c: Use C++ exception handling.
6383         * ada-lang.c: Use C++ exception handling.
6384         * aarch64-tdep.c: Use C++ exception handling.
6385
6386 2019-04-08  Tom Tromey  <tom@tromey.com>
6387
6388         * xml-support.c (gdb_xml_parser::parse): Update.
6389         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6390         * value.c (show_convenience): Update.
6391         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6392         (test_parse_flags_qcs): Update.
6393         * thread.c (thr_try_catch_cmd): Update.
6394         * target.c (target_translate_tls_address): Update.
6395         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6396         (info_frame_command_core, frame_apply_command_count): Update.
6397         * rust-exp.y (rust_lex_exception_test): Update.
6398         * riscv-tdep.c (riscv_print_one_register_info): Update.
6399         * remote.c (remote_target::enable_btrace): Update.
6400         * record-btrace.c (record_btrace_enable_warn): Update.
6401         * python/py-utils.c (gdbpy_convert_exception): Update.
6402         * printcmd.c (do_one_display, print_variable_and_value): Update.
6403         * mi/mi-main.c (mi_print_exception): Update.
6404         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6405         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6406         * linux-nat.c (linux_nat_target::attach): Update.
6407         * linux-fork.c (class scoped_switch_fork_info): Update.
6408         * infrun.c (displaced_step_prepare): Update.
6409         * infcall.c (call_function_by_hand_dummy): Update.
6410         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6411         * gnu-v3-abi.c (print_one_vtable): Update.
6412         * frame.c (get_prev_frame_always): Update.
6413         * f-valprint.c (info_common_command_for_block): Update.
6414         * exec.c (try_open_exec_file): Update.
6415         * exceptions.c (print_exception, exception_print)
6416         (exception_fprintf, exception_print_same): Update.
6417         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6418         * dwarf-index-cache.c (index_cache::store)
6419         (index_cache::lookup_gdb_index): Update.
6420         * darwin-nat.c (maybe_cache_shell): Update.
6421         * cp-valprint.c (cp_print_value_fields): Update.
6422         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6423         (gcc_cplus_symbol_address): Update.
6424         * compile/compile-c-symbols.c (gcc_convert_symbol)
6425         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6426         * common/selftest.c: Update.
6427         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6428         a std::string.
6429         (exception_try_scope_entry, exception_try_scope_exit): Don't
6430         declare.
6431         (struct exception_try_scope): Remove.
6432         (TRY): Don't use exception_try_scope.
6433         (struct gdb_exception): Add constructor, operator=.
6434         <what>: New method.
6435         (struct gdb_exception_RETURN_MASK_ALL)
6436         (struct gdb_exception_RETURN_MASK_ERROR)
6437         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6438         (struct gdb_quit_bad_alloc): Update.
6439         * common/common-exceptions.c (exception_none): Change
6440         initializer.
6441         (struct catcher) <state, exception>: Initialize inline.
6442         <prev>: Remove member.
6443         (current_catcher): Remove.
6444         (catchers): New global.
6445         (exceptions_state_mc_init): Simplify.
6446         (catcher_pop): Remove.
6447         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6448         (try_scope_depth, exception_try_scope_entry)
6449         (exception_try_scope_exit): Remove.
6450         (throw_exception_sjlj): Update.
6451         (exception_messages, exception_messages_size): Remove.
6452         (throw_it): Simplify.
6453         (gdb_exception_sliced_copy): Remove.
6454         (throw_exception_cxx): Update.
6455         * cli/cli-script.c (script_from_file): Update.
6456         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6457         Update.
6458         * ada-valprint.c (ada_val_print): Update.
6459         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6460         (create_excep_cond_exprs): Update.
6461
6462 2019-04-08  Tom Tromey  <tom@tromey.com>
6463
6464         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6465         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6466         (TRY, CATCH, END_CATCH): Remove some definitions.
6467         * common/common-exceptions.c: Don't use GDB_XCPT.
6468         (catcher_list_size): Remove.
6469         (throw_exception, throw_it): Simplify.
6470
6471 2019-04-05  Tom Tromey  <tom@tromey.com>
6472
6473         Revert the header-sorting patch.
6474         * ft32-tdep.c: Revert.
6475         * frv-tdep.c: Revert.
6476         * frv-linux-tdep.c: Revert.
6477         * frame.c: Revert.
6478         * frame-unwind.c: Revert.
6479         * frame-base.c: Revert.
6480         * fork-child.c: Revert.
6481         * findvar.c: Revert.
6482         * findcmd.c: Revert.
6483         * filesystem.c: Revert.
6484         * filename-seen-cache.h: Revert.
6485         * filename-seen-cache.c: Revert.
6486         * fbsd-tdep.c: Revert.
6487         * fbsd-nat.h: Revert.
6488         * fbsd-nat.c: Revert.
6489         * f-valprint.c: Revert.
6490         * f-typeprint.c: Revert.
6491         * f-lang.c: Revert.
6492         * extension.h: Revert.
6493         * extension.c: Revert.
6494         * extension-priv.h: Revert.
6495         * expprint.c: Revert.
6496         * exec.h: Revert.
6497         * exec.c: Revert.
6498         * exceptions.c: Revert.
6499         * event-top.c: Revert.
6500         * event-loop.c: Revert.
6501         * eval.c: Revert.
6502         * elfread.c: Revert.
6503         * dwarf2read.h: Revert.
6504         * dwarf2read.c: Revert.
6505         * dwarf2loc.c: Revert.
6506         * dwarf2expr.h: Revert.
6507         * dwarf2expr.c: Revert.
6508         * dwarf2-frame.c: Revert.
6509         * dwarf2-frame-tailcall.c: Revert.
6510         * dwarf-index-write.h: Revert.
6511         * dwarf-index-write.c: Revert.
6512         * dwarf-index-common.c: Revert.
6513         * dwarf-index-cache.h: Revert.
6514         * dwarf-index-cache.c: Revert.
6515         * dummy-frame.c: Revert.
6516         * dtrace-probe.c: Revert.
6517         * disasm.h: Revert.
6518         * disasm.c: Revert.
6519         * disasm-selftests.c: Revert.
6520         * dictionary.c: Revert.
6521         * dicos-tdep.c: Revert.
6522         * demangle.c: Revert.
6523         * dcache.h: Revert.
6524         * dcache.c: Revert.
6525         * darwin-nat.h: Revert.
6526         * darwin-nat.c: Revert.
6527         * darwin-nat-info.c: Revert.
6528         * d-valprint.c: Revert.
6529         * d-namespace.c: Revert.
6530         * d-lang.c: Revert.
6531         * ctf.c: Revert.
6532         * csky-tdep.c: Revert.
6533         * csky-linux-tdep.c: Revert.
6534         * cris-tdep.c: Revert.
6535         * cris-linux-tdep.c: Revert.
6536         * cp-valprint.c: Revert.
6537         * cp-support.c: Revert.
6538         * cp-namespace.c: Revert.
6539         * cp-abi.c: Revert.
6540         * corelow.c: Revert.
6541         * corefile.c: Revert.
6542         * continuations.c: Revert.
6543         * completer.h: Revert.
6544         * completer.c: Revert.
6545         * complaints.c: Revert.
6546         * coffread.c: Revert.
6547         * coff-pe-read.c: Revert.
6548         * cli-out.h: Revert.
6549         * cli-out.c: Revert.
6550         * charset.c: Revert.
6551         * c-varobj.c: Revert.
6552         * c-valprint.c: Revert.
6553         * c-typeprint.c: Revert.
6554         * c-lang.c: Revert.
6555         * buildsym.c: Revert.
6556         * buildsym-legacy.c: Revert.
6557         * build-id.h: Revert.
6558         * build-id.c: Revert.
6559         * btrace.c: Revert.
6560         * bsd-uthread.c: Revert.
6561         * breakpoint.h: Revert.
6562         * breakpoint.c: Revert.
6563         * break-catch-throw.c: Revert.
6564         * break-catch-syscall.c: Revert.
6565         * break-catch-sig.c: Revert.
6566         * blockframe.c: Revert.
6567         * block.c: Revert.
6568         * bfin-tdep.c: Revert.
6569         * bfin-linux-tdep.c: Revert.
6570         * bfd-target.c: Revert.
6571         * bcache.c: Revert.
6572         * ax-general.c: Revert.
6573         * ax-gdb.h: Revert.
6574         * ax-gdb.c: Revert.
6575         * avr-tdep.c: Revert.
6576         * auxv.c: Revert.
6577         * auto-load.c: Revert.
6578         * arm-wince-tdep.c: Revert.
6579         * arm-tdep.c: Revert.
6580         * arm-symbian-tdep.c: Revert.
6581         * arm-pikeos-tdep.c: Revert.
6582         * arm-obsd-tdep.c: Revert.
6583         * arm-nbsd-tdep.c: Revert.
6584         * arm-nbsd-nat.c: Revert.
6585         * arm-linux-tdep.c: Revert.
6586         * arm-linux-nat.c: Revert.
6587         * arm-fbsd-tdep.c: Revert.
6588         * arm-fbsd-nat.c: Revert.
6589         * arm-bsd-tdep.c: Revert.
6590         * arch-utils.c: Revert.
6591         * arc-tdep.c: Revert.
6592         * arc-newlib-tdep.c: Revert.
6593         * annotate.h: Revert.
6594         * annotate.c: Revert.
6595         * amd64-windows-tdep.c: Revert.
6596         * amd64-windows-nat.c: Revert.
6597         * amd64-tdep.c: Revert.
6598         * amd64-sol2-tdep.c: Revert.
6599         * amd64-obsd-tdep.c: Revert.
6600         * amd64-obsd-nat.c: Revert.
6601         * amd64-nbsd-tdep.c: Revert.
6602         * amd64-nbsd-nat.c: Revert.
6603         * amd64-nat.c: Revert.
6604         * amd64-linux-tdep.c: Revert.
6605         * amd64-linux-nat.c: Revert.
6606         * amd64-fbsd-tdep.c: Revert.
6607         * amd64-fbsd-nat.c: Revert.
6608         * amd64-dicos-tdep.c: Revert.
6609         * amd64-darwin-tdep.c: Revert.
6610         * amd64-bsd-nat.c: Revert.
6611         * alpha-tdep.c: Revert.
6612         * alpha-obsd-tdep.c: Revert.
6613         * alpha-nbsd-tdep.c: Revert.
6614         * alpha-mdebug-tdep.c: Revert.
6615         * alpha-linux-tdep.c: Revert.
6616         * alpha-linux-nat.c: Revert.
6617         * alpha-bsd-tdep.c: Revert.
6618         * alpha-bsd-nat.c: Revert.
6619         * aix-thread.c: Revert.
6620         * agent.c: Revert.
6621         * addrmap.c: Revert.
6622         * ada-varobj.c: Revert.
6623         * ada-valprint.c: Revert.
6624         * ada-typeprint.c: Revert.
6625         * ada-tasks.c: Revert.
6626         * ada-lang.c: Revert.
6627         * aarch64-tdep.c: Revert.
6628         * aarch64-ravenscar-thread.c: Revert.
6629         * aarch64-newlib-tdep.c: Revert.
6630         * aarch64-linux-tdep.c: Revert.
6631         * aarch64-linux-nat.c: Revert.
6632         * aarch64-fbsd-tdep.c: Revert.
6633         * aarch64-fbsd-nat.c: Revert.
6634         * aarch32-linux-nat.c: Revert.
6635
6636 2019-04-05  Tom Tromey  <tom@tromey.com>
6637
6638         * ft32-tdep.c: Sort headers.
6639         * frv-tdep.c: Sort headers.
6640         * frv-linux-tdep.c: Sort headers.
6641         * frame.c: Sort headers.
6642         * frame-unwind.c: Sort headers.
6643         * frame-base.c: Sort headers.
6644         * fork-child.c: Sort headers.
6645         * findvar.c: Sort headers.
6646         * findcmd.c: Sort headers.
6647         * filesystem.c: Sort headers.
6648         * filename-seen-cache.h: Sort headers.
6649         * filename-seen-cache.c: Sort headers.
6650         * fbsd-tdep.c: Sort headers.
6651         * fbsd-nat.h: Sort headers.
6652         * fbsd-nat.c: Sort headers.
6653         * f-valprint.c: Sort headers.
6654         * f-typeprint.c: Sort headers.
6655         * f-lang.c: Sort headers.
6656         * extension.h: Sort headers.
6657         * extension.c: Sort headers.
6658         * extension-priv.h: Sort headers.
6659         * expprint.c: Sort headers.
6660         * exec.h: Sort headers.
6661         * exec.c: Sort headers.
6662         * exceptions.c: Sort headers.
6663         * event-top.c: Sort headers.
6664         * event-loop.c: Sort headers.
6665         * eval.c: Sort headers.
6666         * elfread.c: Sort headers.
6667         * dwarf2read.h: Sort headers.
6668         * dwarf2read.c: Sort headers.
6669         * dwarf2loc.c: Sort headers.
6670         * dwarf2expr.h: Sort headers.
6671         * dwarf2expr.c: Sort headers.
6672         * dwarf2-frame.c: Sort headers.
6673         * dwarf2-frame-tailcall.c: Sort headers.
6674         * dwarf-index-write.h: Sort headers.
6675         * dwarf-index-write.c: Sort headers.
6676         * dwarf-index-common.c: Sort headers.
6677         * dwarf-index-cache.h: Sort headers.
6678         * dwarf-index-cache.c: Sort headers.
6679         * dummy-frame.c: Sort headers.
6680         * dtrace-probe.c: Sort headers.
6681         * disasm.h: Sort headers.
6682         * disasm.c: Sort headers.
6683         * disasm-selftests.c: Sort headers.
6684         * dictionary.c: Sort headers.
6685         * dicos-tdep.c: Sort headers.
6686         * demangle.c: Sort headers.
6687         * dcache.h: Sort headers.
6688         * dcache.c: Sort headers.
6689         * darwin-nat.h: Sort headers.
6690         * darwin-nat.c: Sort headers.
6691         * darwin-nat-info.c: Sort headers.
6692         * d-valprint.c: Sort headers.
6693         * d-namespace.c: Sort headers.
6694         * d-lang.c: Sort headers.
6695         * ctf.c: Sort headers.
6696         * csky-tdep.c: Sort headers.
6697         * csky-linux-tdep.c: Sort headers.
6698         * cris-tdep.c: Sort headers.
6699         * cris-linux-tdep.c: Sort headers.
6700         * cp-valprint.c: Sort headers.
6701         * cp-support.c: Sort headers.
6702         * cp-namespace.c: Sort headers.
6703         * cp-abi.c: Sort headers.
6704         * corelow.c: Sort headers.
6705         * corefile.c: Sort headers.
6706         * continuations.c: Sort headers.
6707         * completer.h: Sort headers.
6708         * completer.c: Sort headers.
6709         * complaints.c: Sort headers.
6710         * coffread.c: Sort headers.
6711         * coff-pe-read.c: Sort headers.
6712         * cli-out.h: Sort headers.
6713         * cli-out.c: Sort headers.
6714         * charset.c: Sort headers.
6715         * c-varobj.c: Sort headers.
6716         * c-valprint.c: Sort headers.
6717         * c-typeprint.c: Sort headers.
6718         * c-lang.c: Sort headers.
6719         * buildsym.c: Sort headers.
6720         * buildsym-legacy.c: Sort headers.
6721         * build-id.h: Sort headers.
6722         * build-id.c: Sort headers.
6723         * btrace.c: Sort headers.
6724         * bsd-uthread.c: Sort headers.
6725         * breakpoint.h: Sort headers.
6726         * breakpoint.c: Sort headers.
6727         * break-catch-throw.c: Sort headers.
6728         * break-catch-syscall.c: Sort headers.
6729         * break-catch-sig.c: Sort headers.
6730         * blockframe.c: Sort headers.
6731         * block.c: Sort headers.
6732         * bfin-tdep.c: Sort headers.
6733         * bfin-linux-tdep.c: Sort headers.
6734         * bfd-target.c: Sort headers.
6735         * bcache.c: Sort headers.
6736         * ax-general.c: Sort headers.
6737         * ax-gdb.h: Sort headers.
6738         * ax-gdb.c: Sort headers.
6739         * avr-tdep.c: Sort headers.
6740         * auxv.c: Sort headers.
6741         * auto-load.c: Sort headers.
6742         * arm-wince-tdep.c: Sort headers.
6743         * arm-tdep.c: Sort headers.
6744         * arm-symbian-tdep.c: Sort headers.
6745         * arm-pikeos-tdep.c: Sort headers.
6746         * arm-obsd-tdep.c: Sort headers.
6747         * arm-nbsd-tdep.c: Sort headers.
6748         * arm-nbsd-nat.c: Sort headers.
6749         * arm-linux-tdep.c: Sort headers.
6750         * arm-linux-nat.c: Sort headers.
6751         * arm-fbsd-tdep.c: Sort headers.
6752         * arm-fbsd-nat.c: Sort headers.
6753         * arm-bsd-tdep.c: Sort headers.
6754         * arch-utils.c: Sort headers.
6755         * arc-tdep.c: Sort headers.
6756         * arc-newlib-tdep.c: Sort headers.
6757         * annotate.h: Sort headers.
6758         * annotate.c: Sort headers.
6759         * amd64-windows-tdep.c: Sort headers.
6760         * amd64-windows-nat.c: Sort headers.
6761         * amd64-tdep.c: Sort headers.
6762         * amd64-sol2-tdep.c: Sort headers.
6763         * amd64-obsd-tdep.c: Sort headers.
6764         * amd64-obsd-nat.c: Sort headers.
6765         * amd64-nbsd-tdep.c: Sort headers.
6766         * amd64-nbsd-nat.c: Sort headers.
6767         * amd64-nat.c: Sort headers.
6768         * amd64-linux-tdep.c: Sort headers.
6769         * amd64-linux-nat.c: Sort headers.
6770         * amd64-fbsd-tdep.c: Sort headers.
6771         * amd64-fbsd-nat.c: Sort headers.
6772         * amd64-dicos-tdep.c: Sort headers.
6773         * amd64-darwin-tdep.c: Sort headers.
6774         * amd64-bsd-nat.c: Sort headers.
6775         * alpha-tdep.c: Sort headers.
6776         * alpha-obsd-tdep.c: Sort headers.
6777         * alpha-nbsd-tdep.c: Sort headers.
6778         * alpha-mdebug-tdep.c: Sort headers.
6779         * alpha-linux-tdep.c: Sort headers.
6780         * alpha-linux-nat.c: Sort headers.
6781         * alpha-bsd-tdep.c: Sort headers.
6782         * alpha-bsd-nat.c: Sort headers.
6783         * aix-thread.c: Sort headers.
6784         * agent.c: Sort headers.
6785         * addrmap.c: Sort headers.
6786         * ada-varobj.c: Sort headers.
6787         * ada-valprint.c: Sort headers.
6788         * ada-typeprint.c: Sort headers.
6789         * ada-tasks.c: Sort headers.
6790         * ada-lang.c: Sort headers.
6791         * aarch64-tdep.c: Sort headers.
6792         * aarch64-ravenscar-thread.c: Sort headers.
6793         * aarch64-newlib-tdep.c: Sort headers.
6794         * aarch64-linux-tdep.c: Sort headers.
6795         * aarch64-linux-nat.c: Sort headers.
6796         * aarch64-fbsd-tdep.c: Sort headers.
6797         * aarch64-fbsd-nat.c: Sort headers.
6798         * aarch32-linux-nat.c: Sort headers.
6799
6800 2019-04-04  Tom Tromey  <tom@tromey.com>
6801
6802         * varobj.c (varobj_create): Update.
6803         * rust-exp.y (struct rust_parser) <update_innermost_block,
6804         lookup_symbol>: New methods.
6805         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6806         Rename.
6807         (rust_parser::rust_lookup_type)
6808         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6809         * printcmd.c (display_command, do_one_display): Update.
6810         * parser-defs.h (struct parser_state) <parser_state>: Add
6811         "tracker" parameter.
6812         (block_tracker): New member.
6813         (class innermost_block_tracker) <innermost_block_tracker>: Add
6814         "types" parameter.
6815         <reset>: Remove method.
6816         (innermost_block): Don't declare.
6817         (null_post_parser): Update.
6818         * parse.c (innermost_block): Remove global.
6819         (write_dollar_variable): Update.
6820         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6821         Remove "tracker_types" parameter.
6822         (parse_expression): Add "tracker" parameter.
6823         (parse_expression_for_completion): Update.
6824         (null_post_parser): Add "tracker" parameter.
6825         * p-exp.y: Update rules.
6826         * m2-exp.y: Update rules.
6827         * language.h (struct language_defn) <la_post_parser>: Add
6828         "tracker" parameter.
6829         * go-exp.y: Update rules.
6830         * f-exp.y: Update rules.
6831         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6832         parameter.
6833         * d-exp.y: Update rules.
6834         * c-exp.y: Update rules.
6835         * breakpoint.c (set_breakpoint_condition): Create an
6836         innermost_block_tracker.
6837         (watch_command_1): Likewise.
6838         * ada-lang.c (resolve): Add "tracker" parameter.
6839         (resolve_subexp): Likewise.
6840         * ada-exp.y (write_var_from_sym): Update.
6841
6842 2019-04-04  Tom Tromey  <tom@tromey.com>
6843
6844         * type-stack.h: New file.
6845         * type-stack.c: New file.
6846         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6847         type-stack.h.
6848         (insert_into_type_stack, insert_type, push_type, push_type_int)
6849         (insert_type_address_space, pop_type, pop_type_int)
6850         (pop_typelist, pop_type_stack, append_type_stack)
6851         (push_type_stack, get_type_stack, push_typelist)
6852         (follow_type_instance_flags, follow_types): Don't declare.
6853         * parse.c (type_stack): Remove global.
6854         (parse_exp_in_context): Update.
6855         (insert_into_type_stack, insert_type, push_type, push_type_int)
6856         (insert_type_address_space, pop_type, pop_type_int)
6857         (pop_typelist, pop_type_stack, append_type_stack)
6858         (push_type_stack, get_type_stack, push_typelist)
6859         (follow_type_instance_flags, follow_types): Remove (moved to
6860         type-stack.c).
6861         * f-exp.y (type_stack): New global.
6862         Update rules.
6863         (push_kind_type, f_parse): Update.
6864         * d-exp.y (type_stack): New global.
6865         Update rules.
6866         (d_parse): Update.
6867         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6868         Update rules.
6869         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6870         (HFILES_NO_SRCDIR): Add type-stack.h.
6871
6872 2019-04-04  Tom Tromey  <tom@tromey.com>
6873
6874         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6875         (rust_parser::convert_ast_to_expression, rust_parse)
6876         (rust_lex_test_completion, rust_lex_tests): Update.
6877         * parser-defs.h (struct expr_completion_state): New.
6878         (struct parser_state) <parser_state>: Add completion parameter.
6879         <mark_struct_expression, mark_completion_tag>: New methods.
6880         <parse_completion, m_completion_state>: New members.
6881         (prefixify_expression, null_post_parser): Update.
6882         (mark_struct_expression, mark_completion_tag): Don't declare.
6883         * parse.c (parse_completion, expout_last_struct)
6884         (expout_tag_completion_type, expout_completion_name): Remove
6885         globals.
6886         (parser_state::mark_struct_expression)
6887         (parser_state::mark_completion_tag): Now methods.
6888         (prefixify_expression): Add last_struct parameter.
6889         (prefixify_subexp): Likewise.
6890         (parse_exp_1): Update.
6891         (parse_exp_in_context): Add cstate parameter.  Update.
6892         (parse_expression_for_completion): Create an
6893         expr_completion_state.
6894         (null_post_parser): Add "completion" parameter.
6895         * p-exp.y: Update rules.
6896         (yylex): Update.
6897         * language.h (struct language_defn) <la_post_parser>: Add
6898         "completing" parameter.
6899         * go-exp.y: Update rules.
6900         (lex_one_token): Update.
6901         * expression.h (parse_completion): Don't declare.
6902         * d-exp.y: Update rules.
6903         (lex_one_token): Update rules.
6904         * c-exp.y: Update rules.
6905         (lex_one_token): Update.
6906         * ada-lang.c (resolve): Add "parse_completion" parameter.
6907         (resolve_subexp): Likewise.
6908         (ada_resolve_function): Likewise.
6909
6910 2019-04-04  Tom Tromey  <tom@tromey.com>
6911
6912         * parser-defs.h (struct parser_state) <start_arglist,
6913         end_arglist>: New methods.
6914         <arglist_len, m_funcall_chain>: New members.
6915         (arglist_len, start_arglist, end_arglist): Don't declare.
6916         * parse.c (arglist_len, funcall_chain): Remove global.
6917         (start_arglist, end_arglist): Remove functions.
6918         (parse_exp_in_context): Update.
6919         * p-exp.y: Update rules.
6920         * m2-exp.y: Update rules.
6921         * go-exp.y: Update rules.
6922         * f-exp.y: Update rules.
6923         * d-exp.y: Update rules.
6924         * c-exp.y: Update rules.
6925
6926 2019-04-04  Tom Tromey  <tom@tromey.com>
6927
6928         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6929         lex_operator, push_back>: New methods.
6930         Update all rules.
6931         (rust_parser::lex_hex, lex_escape): Rename and update.
6932         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6933         (rust_parser::lex_operator): Rename and update.
6934         (rust_parser::lex_number, rustyylex, rustyyerror)
6935         (rust_lex_test_init, rust_lex_test_sequence)
6936         (rust_lex_test_push_back, rust_lex_tests): Update.
6937         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6938         parameter.
6939         <lexptr, prev_lexptr>: New members.
6940         (lexptr, prev_lexptr): Don't declare.
6941         * parse.c (lexptr, prev_lexptr): Remove globals.
6942         (parse_exp_in_context): Update.
6943         * p-exp.y (yylex, yyerror): Update.
6944         * m2-exp.y (parse_number, yylex, yyerror): Update.
6945         * go-exp.y (lex_one_token, yyerror): Update.
6946         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6947         * d-exp.y (lex_one_token, yyerror): Update.
6948         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6949         (lex_one_token, yyerror): Update.
6950         * ada-lex.l (YY_INPUT): Update.
6951         (rewind_to_char): Update.
6952         * ada-exp.y (yyerror): Update.
6953
6954 2019-04-04  Tom Tromey  <tom@tromey.com>
6955
6956         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6957         * parser-defs.h (struct parser_state) <parser_state>: Add new
6958         parameter.
6959         <comma_terminates>: New member.
6960         (comma_terminates): Don't declare global.
6961         * parse.c (comma_terminates): Remove global.
6962         (parse_exp_in_context): Update.
6963         * p-exp.y (yylex): Update.
6964         * m2-exp.y (yylex): Update.
6965         * go-exp.y (lex_one_token): Update.
6966         * f-exp.y (yylex): Update.
6967         * d-exp.y (lex_one_token): Update.
6968         * c-exp.y (lex_one_token): Update.
6969         * ada-lex.l: Update.
6970
6971 2019-04-04  Tom Tromey  <tom@tromey.com>
6972
6973         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6974         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6975         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6976         * parser-defs.h (paren_depth): Don't declare.
6977         * parse.c (paren_depth): Remove global.
6978         (parse_exp_in_context): Update.
6979         * p-exp.y (paren_depth): New global.
6980         (pascal_parse): Initialize it.
6981         * m2-exp.y (paren_depth): New global.
6982         (m2_parse): Initialize it.
6983         * go-exp.y (paren_depth): New global.
6984         (go_parse): Initialize it.
6985         * f-exp.y (paren_depth): New global.
6986         (f_parse): Initialize it.
6987         * d-exp.y (paren_depth): New global.
6988         (d_parse): Initialize it.
6989         * c-exp.y (paren_depth): New global.
6990         (c_parse): Initialize it.
6991         * ada-lex.l (paren_depth): New global.
6992         (lexer_init): Initialize it.
6993
6994 2019-04-04  Tom Tromey  <tom@tromey.com>
6995
6996         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6997         (rust_parser::convert_ast_to_type)
6998         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6999         * parser-defs.h (struct parser_state) <parser_state>: Add
7000         parameters.  Initialize new members.
7001         <expression_context_block, expression_context_pc>: New members.
7002         * parse.c (expression_context_block, expression_context_pc):
7003         Remove globals.
7004         (parse_exp_in_context): Update.
7005         * p-exp.y: Update all rules.
7006         (yylex): Update.
7007         * m2-exp.y: Update all rules.
7008         (yylex): Update.
7009         * go-exp.y (yylex): Update.
7010         * f-exp.y (yylex): Update.
7011         * d-exp.y: Update all rules.
7012         (yylex): Update.
7013         * c-exp.y: Update all rules.
7014         (lex_one_token, classify_name, yylex, c_parse): Update.
7015         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7016
7017 2019-04-04  Tom Tromey  <tom@tromey.com>
7018
7019         * gdbarch.h, gdbarch.c: Rebuild.
7020         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7021         * stap-probe.h:
7022         (struct stap_parse_info): Replace "parser_state" with
7023         "expr_builder".
7024         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7025         (parser_state): New class.
7026         * parse.c (expr_builder): Rename.
7027         (expr_builder::release): Rename.
7028         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7029         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7030         (write_exp_elt_longcst, write_exp_elt_floatcst)
7031         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7032         (write_exp_string_vector, write_exp_bitstring)
7033         (write_exp_msymbol, mark_struct_expression)
7034         (write_dollar_variable)
7035         (insert_type_address_space, increase_expout_size): Replace
7036         "parser_state" with "expr_builder".
7037         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7038         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7039         "parser_state" with "expr_builder".
7040
7041 2019-04-04  Tom Tromey  <tom@tromey.com>
7042
7043         * rust-exp.y: Replace "parse_language" with method call.
7044         * p-exp.y:
7045         (yylex): Replace "parse_language" with method call.
7046         * m2-exp.y:
7047         (yylex): Replace "parse_language" with method call.
7048         * go-exp.y (classify_name): Replace "parse_language" with method
7049         call.
7050         * f-exp.y (yylex): Replace "parse_language" with method call.
7051         * d-exp.y (lex_one_token): Replace "parse_language" with method
7052         call.
7053         * c-exp.y:
7054         (lex_one_token, classify_name, yylex): Replace "parse_language"
7055         with method call.
7056         * ada-exp.y (find_primitive_type, type_char)
7057         (type_system_address): Replace "parse_language" with method call.
7058
7059 2019-04-04  Tom Tromey  <tom@tromey.com>
7060
7061         * rust-exp.y: Replace "parse_gdbarch" with method call.
7062         * parse.c (write_dollar_variable, insert_type_address_space):
7063         Replace "parse_gdbarch" with method call.
7064         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7065         call.
7066         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7067         call.
7068         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7069         "parse_gdbarch" with method call.
7070         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7071         with method call.
7072         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7073         "parse_gdbarch" with method call.
7074         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7075         "parse_gdbarch" with method call.
7076         * c-exp.y (parse_type, parse_number, classify_name): Replace
7077         "parse_gdbarch" with method call.
7078         * ada-lex.l: Replace "parse_gdbarch" with method call.
7079         * ada-exp.y (parse_type, find_primitive_type, type_char)
7080         (type_system_address): Replace "parse_gdbarch" with method call.
7081
7082 2019-04-04  Tom Tromey  <tom@tromey.com>
7083
7084         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7085         * stap-probe.c (stap_parse_argument): Update.
7086         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7087         initial_size parameter.
7088         * rust-exp.y (rust_lex_tests): Update.
7089         * parse.c (parser_state): Update.
7090         (parse_exp_in_context): Update.
7091         * parser-defs.h (struct parser_state) <parser_state>: Remove
7092         "initial_size" parameter.
7093
7094 2019-04-04  Tom Tromey  <tom@tromey.com>
7095
7096         * parser-defs.h (increase_expout_size): Don't declare.
7097         * parse.c (increase_expout_size): Now static.
7098
7099 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7100
7101         * gnu-nat.c (gnu_nat_target::wait): Fix
7102         target_waitstatus_to_string call.
7103
7104 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7105
7106         * eval.c (evaluate_subexp_standard): Handle internal functions
7107         during Fortran function call handling.
7108
7109 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7110
7111         * NEWS: Mention new internal functions.
7112         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7113         (read_base_type): Use dwarf2_init_complex_target_type.
7114         * value.c (creal_internal_fn): New function.
7115         (cimag_internal_fn): New function.
7116         (_initialize_values): Register new internal functions.
7117
7118 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7119
7120         * infrun.c (stop_all_threads): If debug_infrun, always
7121         trace the wait status after wait_one, using
7122         target_waitstatus_to_string and target_pid_to_str.
7123         (handle_inferior_event): Replace various trace of
7124         wait status kind by a single trace.
7125         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7126         wait status kind image by target_waitstatus_to_string.
7127         * target/waitstatus.c (target_waitstatus_to_string): Fix
7128         obsolete comment.
7129
7130 2019-04-01  Tom Tromey  <tromey@adacore.com>
7131
7132         PR symtab/23331:
7133         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7134
7135 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7136             Pedro Alves  <palves@redhat.com>
7137
7138         * top.c (quit_force): Call 'finalize_values'.
7139         * value.c (finalize_values): New function.
7140         * value.h (finalize_values): Declare.
7141
7142 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7143
7144         * NEWS: Announce $_gdb_major and $_gdb_minor.
7145
7146         * top.c (init_gdb_version_vars): New function.
7147         (gdb_init): Call init_gdb_version_vars.
7148
7149 2019-03-29  Tom Tromey  <tromey@adacore.com>
7150
7151         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7152         help text.  Remove dead code.
7153
7154 2019-03-29  Keith Seitz  <keiths@redhat.com>
7155
7156         From Siddhesh Poyarekar:
7157         * f-lang.h (f77_get_upperbound): Return LONGEST.
7158         (f77_get_lowerbound): Likewise.
7159         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7160         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7161         print them.
7162         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7163         plongest to format print it.
7164         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7165         (f77_get_upperbound): Likewise.
7166         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7167         LOWER_BOUND to LONGEST.
7168         (f77_create_arrayprint_offset_tbl): Likewise.
7169
7170 2019-03-29  Keith Seitz  <keiths@redhat.com>
7171
7172         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7173         %s/pulongest for TYPE_LENGTH instead of %d in format
7174         strings.
7175         * ada-typerint.c (ada_print_type): Likewise.
7176         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7177         * compile/compile-c-support.c (generate_register_struct): Likewise.
7178         * gdbtypes.c (recursive_dump_type): Likewise.
7179         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7180         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7181         instead of %d in format strings.
7182         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7183         to std::min to ULONGEST.
7184         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7185         instead of %d in format strings.
7186         * tracepoint.c (info_scope_command): Likewise.
7187         * typeprint.c (print_offset_data::update)
7188         (print_offset_data::finish): Likewise.
7189         * xtensa-tdep.c (xtensa_store_return_value)
7190         (xtensa_push_dummy_call): Likewise.
7191
7192 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7193
7194         * windows-nat.c (display_selector): Fixed format specifications
7195         for 64-bit Cygwin.
7196
7197 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7198
7199         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7200
7201 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7202
7203         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7204         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7205         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7206         (nios2_linux_init_abi): Install it.
7207
7208 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7209
7210         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7211
7212 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7213
7214         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7215
7216 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7217             Tom Tromey  <tromey@adacore.com>
7218
7219         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7220
7221 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7222
7223         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7224         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7225         method to compute the bounds of range types. Also print "[evaluated]"
7226         if the bounds' values come from a dynamic evaluation.
7227
7228 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7231         whitespace when pretty printing is on.
7232
7233 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7234
7235         * ppc-linux-nat.c: Add include.
7236
7237 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7238
7239         * NEWS: Mention AArch64 Pointer Authentication.
7240
7241 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7242
7243         * arm-linux-nat.c: Add include.
7244
7245 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7246
7247         * source-cache.c (source_cache::get_source_lines): Re-read
7248         fullname after calling open_source_file.
7249
7250 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7251
7252         * NEWS: Mention TLS support for FreeBSD.
7253
7254 2019-03-25  Tom Tromey  <tromey@adacore.com>
7255
7256         * minsyms.c (BUNCH_SIZE): Update comment.
7257         (~minimal_symbol_reader): Remove old comment.
7258         (compact_minimal_symbols): Update comment.
7259         (minimal_symbol_reader::install): Remove old comment.  Update
7260         other comments.
7261
7262 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7263
7264         * s390-linux-nat.c: Add include.
7265
7266 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7267
7268         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7269         Call linux_get_hwcap.
7270         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7271         Likewise.
7272         (aarch64_linux_get_hwcap): Remove function.
7273         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7274         declaration.
7275         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7276         linux_get_hwcap.
7277         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7278         * linux-tdep.c (linux_get_hwcap): Add function.
7279         (linux_get_hwcap2): Likewise.
7280         * linux-tdep.h (linux_get_hwcap): Add declaration.
7281         (linux_get_hwcap2): Likewise.
7282         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7283         (ppc_linux_get_hwcap2): Likewise.
7284         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7285         linux_get_hwcap.
7286         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7287         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7288         (ppc_linux_nat_target::read_description): Likewise.
7289         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7290         * s390-linux-nat.c: Likewise.
7291         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7292
7293 2019-03-24  Tom Tromey  <tom@tromey.com>
7294
7295         * ada-lang.c (standard_lookup): Simplify initialization.
7296         (ada_lookup_symbol_nonlocal): Simplify return.
7297         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7298         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7299         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7300         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7301         initialization.
7302         * solib.c (solib_global_lookup): Simplify.
7303         * symtab.c (null_block_symbol): Remove.
7304         (symbol_cache_lookup): Simplify returns.
7305         (lookup_language_this): Simplify returns.
7306         (lookup_symbol_aux): Simplify return.
7307         (lookup_local_symbol): Simplify returns.
7308         (lookup_global_symbol_from_objfile): Simplify return.
7309         (lookup_symbol_in_objfile_symtabs)
7310         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7311         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7312         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7313         * cp-namespace.c (cp_lookup_bare_symbol)
7314         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7315         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7316         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7317         (cp_lookup_symbol_via_imports): Simplify initialization.
7318         (find_symbol_in_baseclass): Likewise.
7319         * symtab.h (null_block_symbol): Remove.
7320         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7321         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7322         (d_lookup_symbol_module): Likewise.
7323         (find_symbol_in_baseclass): Simplify initialization.
7324
7325 2019-03-24  Tom Tromey  <tom@tromey.com>
7326
7327         * expression.h: Don't include symtab.h.
7328         (struct block): Forward declare.
7329
7330 2019-03-24  Tom Tromey  <tom@tromey.com>
7331
7332         * c-exp.y (typebase): Remove casts.
7333         * gdbtypes.c (lookup_unsigned_typename, )
7334         (lookup_signed_typename): Remove cast.
7335         * eval.c (parse_to_comma_and_eval): Remove cast.
7336         * parse.c (write_dollar_variable): Remove cast.
7337         * block.h (struct block) <superblock>: Now const.
7338         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7339         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7340         (map_block): Make "block" const.
7341         * symfile.h (struct quick_symbol_functions)
7342         <map_matching_symbols>: Constify block argument to "callback".
7343         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7344         const.
7345         (find_pc_sect_compunit_symtab): Make "b" const.
7346         (find_symbol_at_address): Likewise.
7347         (search_symbols): Likewise.
7348         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7349         (dw2_debug_names_lookup_symbol): Likewise.
7350         (dw2_map_matching_symbols): Update.
7351         * p-valprint.c (pascal_val_print): Remove "block".
7352         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7353         (aux_add_nonlocal_symbols): Make "block" const.
7354         (resolve_subexp): Remove cast.
7355         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7356         const.
7357         (iterate_over_file_blocks): Likewise.
7358         * f-exp.y (%union) <bval>: Remove.
7359         * coffread.c (patch_opaque_types): Make "b" const.
7360         * spu-tdep.c (spu_catch_start): Make "block" const.
7361         * c-valprint.c (print_unpacked_pointer): Remove "block".
7362         * symmisc.c (dump_symtab_1): Make "b" const.
7363         (block_depth): Make "block" const.
7364         * d-exp.y (%union) <bval>: Remove.
7365         * cp-support.h (cp_lookup_rtti_type): Update.
7366         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7367         * psymtab.c (psym_lookup_symbol): Make "block" const.
7368         (maintenance_check_psymtabs): Make "b" const.
7369         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7370         (enumerate_locals, enumerate_args): Update.
7371         * python/py-symtab.c (stpy_global_block): Make "block" const.
7372         (stpy_static_block): Likewise.
7373         * inline-frame.c (block_starting_point_at): Make "new_block"
7374         const.
7375         * block.c (find_block_in_blockvector): Make return type const.
7376         (blockvector_for_pc_sect): Make "b" const.
7377         (find_block_in_blockvector): Make "b" const.
7378
7379 2019-03-23  Tom Tromey  <tom@tromey.com>
7380
7381         * varobj.c (varobj_create): Update.
7382         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7383         * printcmd.c (display_command, do_one_display): Don't reset
7384         innermost_block.
7385         * parser-defs.h (enum innermost_block_tracker_type): Move to
7386         expression.h.
7387         (innermost_block): Update comment.
7388         * parse.c (parse_exp_1): Add tracker_types parameter.
7389         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7390         tracker_types parameter.  Reset innermost_block.
7391         (parse_exp_in_context): Remove.
7392         (parse_expression_for_completion): Update.
7393         * objfiles.c (~objfile): Don't reset expression_context_block or
7394         innermost_block.
7395         * expression.h (enum innermost_block_tracker_type): Move from
7396         parser-defs.h.
7397         (parse_exp_1): Add tracker_types parameter.
7398         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7399         reset innermost_block.
7400
7401 2019-03-23  Tom Tromey  <tom@tromey.com>
7402
7403         * objfiles.h: Include bcache.h.
7404
7405 2019-03-23  Tom Tromey  <tom@tromey.com>
7406
7407         * linespec.c (get_current_search_block): Use
7408         scoped_restore_current_language.
7409         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7410
7411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7412             Jiong Wang  <jiong.wang@arm.com>
7413
7414         * aarch64-linux-tdep.c
7415         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7416         section.
7417         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7418
7419 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7420             Jiong Wang  <jiong.wang@arm.com>
7421
7422         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7423         instructions.
7424         (aarch64_analyze_prologue_test): Add PACIASP test.
7425         (aarch64_prologue_prev_register): Unmask PC value.
7426
7427 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7428             Jiong Wang  <jiong.wang@arm.com>
7429
7430         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7431         (aarch64_dwarf2_prev_register): Unmask PC value.
7432         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7433         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7434         DW_CFA_AARCH64_negate_ra_state.
7435         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7436
7437 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7438             Jiong Wang  <jiong.wang@arm.com>
7439
7440         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7441         registers.
7442         (aarch64_pseudo_register_name): Likewise.
7443         (aarch64_pseudo_register_type): Likewise.
7444         (aarch64_pseudo_register_reggroup_p): Likewise.
7445         (aarch64_gdbarch_init): Add pauth registers.
7446         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7447         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7448         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7449         (struct gdbarch_tdep): Add regnum for ra_state.
7450
7451 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7452             Jiong Wang  <jiong.wang@arm.com>
7453
7454         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7455
7456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7457             Jiong Wang  <jiong.wang@arm.com>
7458
7459         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7460         function.
7461         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7462         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7463         (aarch64_gdbarch_init): Add puth registers.
7464         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7465         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7466         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7467
7468 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7469             Jiong Wang  <jiong.wang@arm.com>
7470
7471         * aarch64-linux-nat.c
7472         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7473         * aarch64-linux-tdep.c
7474         (aarch64_linux_core_read_description): Likewise.
7475         (aarch64_linux_get_hwcap): New function.
7476         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7477         (aarch64_linux_get_hwcap): New declaration.
7478
7479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7480             Jiong Wang  <jiong.wang@arm.com>
7481
7482         * aarch64-linux-nat.c
7483         (aarch64_linux_nat_target::read_description): Add pauth param.
7484         * aarch64-linux-tdep.c
7485         (aarch64_linux_core_read_description): Likewise.
7486         * aarch64-tdep.c (struct target_desc): Add in pauth.
7487         (aarch64_read_description): Add pauth param.
7488         (aarch64_gdbarch_init): Likewise.
7489         * aarch64-tdep.h (aarch64_read_description): Likewise.
7490         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7491         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7492         * features/Makefile: Add new files.
7493         * features/aarch64-pauth.c: New file.
7494         * features/aarch64-pauth.xml: New file.
7495
7496 2019-03-20  Tom Tromey  <tromey@adacore.com>
7497
7498         * infrun.c (handle_inferior_event): Rename from
7499         handle_inferior_event_1.  Create a scoped_value_mark.
7500         (handle_inferior_event): Remove.
7501
7502 2019-03-19  Tom Tromey  <tromey@adacore.com>
7503
7504         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7505         * infrun.h (print_stop_event): Add "displays" parameter.
7506         * infrun.c (print_stop_event): Add "displays" parameter.
7507
7508 2019-03-19  Pedro Alves  <palves@redhat.com>
7509
7510         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7511         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7512         to -1.  Fix TABs vs spaces.
7513         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7514         * tui/tui-out.h (tui_ui_out) Add intro comments.
7515         <m_line, m_start_of_line>: In-class initialize, and add describing
7516         comment.
7517
7518 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7519
7520         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7521         variable names.
7522         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7523
7524 2019-03-18  Pedro Alves  <palves@redhat.com>
7525             Eli Zaretskii <eliz@gnu.org>
7526
7527         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7528         m_line and m_start_of_line.
7529
7530 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7531
7532         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7533         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7534         it returns a newline.  This fixes a regression in TU mode, whereby
7535         the next line is output on the same screen line as the user input.
7536
7537 2019-03-18  Tom Tromey  <tromey@adacore.com>
7538
7539         * minsyms.c (minimal_symbol_reader::install): Remove call to
7540         obstack_blank.
7541
7542 2019-03-18  Pedro Alves  <palves@redhat.com>
7543
7544         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7545         New globals.
7546         (apply_style): New, factored out from ...
7547         (apply_ansi_escape): ... this.  Handle reverse video mode.
7548         (tui_set_reverse_mode): New function.
7549         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7550         * tui/tui-winsource.c (tui_show_source_line): Use
7551         tui_set_reverse_mode instead of setting A_STANDOUT.
7552         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7553         New setter methods.
7554
7555 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7556
7557         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7558         Handle tabs.
7559
7560 2019-03-18  Tom Tromey  <tromey@adacore.com>
7561
7562         * ada-lang.c (empty_array): Add "high" parameter.
7563         (ada_evaluate_subexp): Update.
7564
7565 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7566
7567         * unittests/string_view-selftests.c: Define
7568         _initialize_string_view_selftests unconditionally.
7569
7570 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7571
7572         PR gdb/24350
7573         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7574
7575 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7576
7577         PR gdb/24351
7578         * windows-nat.c (display_selector): Fix format specifiers.
7579
7580 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7581
7582         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7583         tui_refill_source_window instead of tui_refresh_win, to update the
7584         current execution line.  This fixes redisplay of the current line
7585         when stepping through the code with "next" or "step".
7586
7587 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7588
7589         * source-cache.c (source_cache::get_source_lines): Call
7590         find_source_lines to initialize s->nlines.  This fixes vertical
7591         scrolling of TUI source window when the DOWN arrow is pressed.
7592
7593 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7594
7595         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7596         linux-thread-db.c (_initialize_thread_db): Likewise.
7597
7598 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7599
7600         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7601         wclrtoeol in tui_show_source_line".  This reverts changes made in
7602         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7603
7604 2019-03-15  Tom Tromey  <tom@tromey.com>
7605
7606         * symtab.h (struct minimal_symbol): Derive from
7607         general_symbol_info.
7608         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7609         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7610         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7611         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7612         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7613         (MSYMBOL_SEARCH_NAME): Update.
7614         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7615         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7616         * minsyms.c (minimal_symbol_reader::record_full): Update.
7617
7618 2019-03-15  Tom Tromey  <tom@tromey.com>
7619
7620         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7621
7622 2019-03-15  Tom Tromey  <tom@tromey.com>
7623
7624         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7625         unique_xmalloc_ptr.
7626         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7627         Update.
7628         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7629         (build_minimal_symbol_hash_tables)
7630         (minimal_symbol_reader::install): Update.
7631
7632 2019-03-15  Tom Tromey  <tom@tromey.com>
7633
7634         * symtab.c (create_demangled_names_hash): Update.
7635         (symbol_set_names): Update.
7636         * objfiles.h (struct objfile_per_bfd_storage)
7637         <demangled_names_hash>: Now an htab_up.
7638         * objfiles.c (objfile_per_bfd_storage): Simplify.
7639
7640 2019-03-15  Tom Tromey  <tom@tromey.com>
7641
7642         * objfiles.h (struct objfile_per_bfd_storage): Declare
7643         destructor.
7644         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7645         New.
7646         (get_objfile_bfd_data): Use new.  Don't initialize
7647         language_of_main.
7648         (free_objfile_per_bfd_storage): Remove.
7649         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7650
7651 2019-03-15  Tom Tromey  <tom@tromey.com>
7652
7653         * symfile.c (reread_symbols): Update.
7654         * objfiles.c (objfile::objfile): Update.
7655         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7656         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7657         comment.
7658         (minimal_symbol_reader::install): Update.
7659         (terminate_minimal_symbol_table): Remove.
7660         * jit.c (jit_object_close_impl): Update.
7661
7662 2019-03-15  Tom Tromey  <tom@tromey.com>
7663
7664         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7665         initializations.
7666
7667 2019-03-15  Tom Tromey  <tom@tromey.com>
7668
7669         * objfiles.h (struct objfile_per_bfd_storage)
7670         <demangled_hash_languages>: Now a bitset.
7671         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7672         (lookup_minimal_symbol): Update.
7673
7674 2019-03-15  Tom Tromey  <tom@tromey.com>
7675
7676         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7677         Don't return the symbol.
7678         * coffread.c (record_minimal_symbol): Use record_full.
7679
7680 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7681
7682         The MS-Windows port of ncurses fails to switch to a color pair if
7683         one or both of the colors are the implicit default colors.  This
7684         change records the default colors when TUI is initialized, and
7685         then specifies them explicitly when a color pair uses the default
7686         colors.  This allows color styling in TUI mode on MS-Windows.
7687
7688         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7689         ncurses_norm_attr.
7690         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7691         colors in ncurses_norm_attr.
7692         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7693         "none", replace it with the default color recorded in
7694         ncurses_norm_attr.
7695
7696 2019-03-14  Tom Tromey  <tromey@adacore.com>
7697
7698         * source-cache.h (class source_cache) <get_source_lines>: Return
7699         std::string.
7700         * source-cache.c (source_cache::extract_lines): Handle case where
7701         first_pos==npos.  Return std::string.
7702         (source_cache::get_source_lines): Update.
7703
7704 2019-03-14  Tom Tromey  <tromey@adacore.com>
7705
7706         * NEWS: Add item for "style sources" commands.
7707         * source-cache.c (source_cache::get_source_lines): Check
7708         source_styling.
7709         * cli/cli-style.c (source_styling): New global.
7710         (_initialize_cli_style): Add "style sources" commands.
7711         (show_style_sources): New function.
7712         * cli/cli-style.h (source_styling): Declare.
7713
7714 2019-03-14  Pedro Alves  <palves@redhat.com>
7715             Tom Tromey  <tromey@adacore.com>
7716
7717         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7718         * tui/tui-winsource.c (tui_refill_source_window): New function,
7719         from...
7720         (tui_horizontal_source_scroll): ... here.  Move some logic.
7721         * cli/cli-style.c (set_style_enabled): Notify new observable.
7722         * tui/tui-hooks.c (tui_redisplay_source): New function.
7723         (tui_attach_detach_observers): Attach or detach
7724         tui_redisplay_source.
7725         * observable.h (source_styling_changed): New observable.
7726         * observable.c: Define source_styling_changed observable.
7727
7728 2019-03-13  Tom Tromey  <tromey@adacore.com>
7729
7730         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7731         (i386_gnu_nat_target::store_registers): Update.
7732         * target-debug.h (target_debug_print_std_string): New macro.
7733         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7734         * windows-tdep.c (display_one_tib): Update.
7735         * tui/tui-stack.c (tui_make_status_line): Update.
7736         * top.c (print_inferior_quit_action): Update.
7737         * thread.c (thr_try_catch_cmd): Update.
7738         (add_thread_with_info): Update.
7739         (thread_target_id_str): Update.
7740         (thr_try_catch_cmd): Update.
7741         (thread_command): Update.
7742         (thread_find_command): Update.
7743         * record-btrace.c (record_btrace_target::info_record)
7744         (record_btrace_resume_thread, record_btrace_target::resume)
7745         (record_btrace_cancel_resume, record_btrace_step_thread)
7746         (record_btrace_target::wait, record_btrace_target::wait)
7747         (record_btrace_target::wait, record_btrace_target::stop): Update.
7748         * progspace.c (print_program_space): Update.
7749         * process-stratum-target.c
7750         (process_stratum_target::thread_address_space): Update.
7751         * linux-fork.c (linux_fork_mourn_inferior)
7752         (detach_checkpoint_command, info_checkpoints_command)
7753         (linux_fork_context): Update.
7754         (linux_fork_detach): Update.
7755         (class scoped_switch_fork_info): Update.
7756         (delete_checkpoint_command): Update.
7757         * infrun.c (follow_fork_inferior): Update.
7758         (follow_fork_inferior): Update.
7759         (proceed_after_vfork_done): Update.
7760         (handle_vfork_child_exec_or_exit): Update.
7761         (follow_exec): Update.
7762         (displaced_step_prepare_throw): Update.
7763         (displaced_step_restore): Update.
7764         (start_step_over): Update.
7765         (resume_1): Update.
7766         (clear_proceed_status_thread): Update.
7767         (proceed): Update.
7768         (print_target_wait_results): Update.
7769         (do_target_wait): Update.
7770         (context_switch): Update.
7771         (stop_all_threads): Update.
7772         (restart_threads): Update.
7773         (finish_step_over): Update.
7774         (handle_signal_stop): Update.
7775         (switch_back_to_stepped_thread): Update.
7776         (keep_going_pass_signal): Update.
7777         (print_exited_reason): Update.
7778         (normal_stop): Update.
7779         * inferior.c (inferior_pid_to_str): Change return type.
7780         (print_selected_inferior): Update.
7781         (add_inferior): Update.
7782         (detach_inferior): Update.
7783         * dummy-frame.c (fprint_dummy_frames): Update.
7784         * dcache.c (dcache_info_1): Update.
7785         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7786         (btrace_fetch, btrace_clear): Update.
7787         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7788         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7789         type.
7790         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7791         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7792         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7793         * gdbarch.c, gdbarch.h: Rebuild.
7794         * gdbarch.sh (core_pid_to_str): Change return type.
7795         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7796         return type.
7797         (windows_nat_target::pid_to_str): Change return type.
7798         (windows_delete_thread): Update.
7799         (windows_nat_target::attach): Update.
7800         (windows_nat_target::files_info): Update.
7801         * target-delegates.c: Rebuild.
7802         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7803         return type.
7804         (sol_thread_target::pid_to_str): Change return type.
7805         * remote.c (class remote_target) <pid_to_str>: Change return
7806         type.
7807         (remote_target::pid_to_str): Change return type.
7808         (extended_remote_target::attach, remote_target::remote_stop_ns)
7809         (remote_target::remote_notif_remove_queued_reply)
7810         (remote_target::push_stop_reply, remote_target::disable_btrace):
7811         Update.
7812         (extended_remote_target::attach): Update.
7813         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7814         type.
7815         (gdbsim_target::pid_to_str): Change return type.
7816         * ravenscar-thread.c (struct ravenscar_thread_target)
7817         <pid_to_str>: Change return type.
7818         (ravenscar_thread_target::pid_to_str): Change return type.
7819         * procfs.c (class procfs_target) <pid_to_str>: Change return
7820         type.
7821         (procfs_target::pid_to_str): Change return type.
7822         (procfs_target::attach): Update.
7823         (procfs_target::detach): Update.
7824         (procfs_target::fetch_registers): Update.
7825         (procfs_target::store_registers): Update.
7826         (procfs_target::wait): Update.
7827         (procfs_target::files_info): Update.
7828         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7829         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7830         return type.
7831         (nto_procfs_target::pid_to_str): Change return type.
7832         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7833         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7834         return type.
7835         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7836         (exit_lwp): Update.
7837         (attach_proc_task_lwp_callback, get_detach_signal)
7838         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7839         (linux_nat_target::resume, wait_lwp, stop_callback)
7840         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7841         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7842         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7843         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7844         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7845         type.
7846         (inf_ptrace_target::attach): Update.
7847         (inf_ptrace_target::files_info): Update.
7848         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7849         type.
7850         (go32_nat_target::pid_to_str): Change return type.
7851         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7852         (gnu_nat_target::wait): Update.
7853         (gnu_nat_target::wait): Update.
7854         (gnu_nat_target::resume): Update.
7855         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7856         (fbsd_nat_target::wait): Update.
7857         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7858         type.
7859         (darwin_nat_target::attach): Update.
7860         * corelow.c (class core_target) <pid_to_str>: Change return type.
7861         (core_target::pid_to_str): Change return type.
7862         * target.c (normal_pid_to_str): Change return type.
7863         (default_pid_to_str): Likewise.
7864         (target_pid_to_str): Change return type.
7865         (target_translate_tls_address): Update.
7866         (target_announce_detach): Update.
7867         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7868         return type.
7869         (bsd_uthread_target::pid_to_str): Change return type.
7870         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7871         type.
7872         (bsd_kvm_target::pid_to_str): Change return type.
7873         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7874         return type.
7875         (aix_thread_target::pid_to_str): Change return type.
7876         * target.h (struct target_ops) <pid_to_str>: Change return type.
7877         (target_pid_to_str, normal_pid_to_str): Likewise.
7878         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7879         type.
7880         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7881         type.
7882         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7883         return type.
7884         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7885         type.
7886         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7887         type.
7888         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7889         return type.
7890
7891 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7892
7893         * NEWS: Mention that the new default MI version is 3.  Mention
7894         changes to the output of commands and events that deal with
7895         multi-location breakpoints.
7896         * breakpoint.c: Include "mi/mi-out.h".
7897         (print_one_breakpoint): Change output syntax if using MI version
7898         >= 3.
7899         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7900         New.
7901         (mi_multi_location_breakpoint_output_fixed): New.
7902         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7903         (mi_cmd_fix_multi_location_breakpoint_output): New.
7904         (mi_multi_location_breakpoint_output_fixed): New.
7905         * mi/mi-cmds.c (mi_cmds): Register command
7906         -fix-multi-location-breakpoint-output.
7907         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7908         interpreter "mi".
7909
7910 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7911
7912         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7913         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7914         instantiate mi_ui_out based on interpreter name.
7915         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7916         * mi/mi-main.c (mi_load_progress): Likewise.
7917
7918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7919
7920         * NEWS: Combine separate "New targets" sections for 8.3.
7921
7922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7923
7924         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7925         (ppcfbsd_init_abi): Install gdbarch
7926         "fetch_tls_load_module_address" and "get_thread_local_address"
7927         methods.
7928
7929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7930
7931         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7932         (riscv_fbsd_init_abi): Install gdbarch
7933         "fetch_tls_load_module_address" and "get_thread_local_address"
7934         methods.
7935
7936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7937
7938         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7939         (i386fbsd_init_abi): Install gdbarch
7940         "fetch_tls_load_module_address" and "get_thread_local_address"
7941         methods.
7942
7943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7944
7945         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7946         (amd64fbsd_init_abi): Install gdbarch
7947         "fetch_tls_load_module_address" and "get_thread_local_address"
7948         methods.
7949
7950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7951
7952         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7953         (struct fbsd_pspace_data): New type.
7954         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7955         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7956         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7957         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7958         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7959
7960 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7961
7962         * gdbtypes.c (lookup_struct_elt): New function.
7963         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7964         * gdbtypes.h (struct struct_elt): New type.
7965         (lookup_struct_elt): New prototype.
7966
7967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7968
7969         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7970         remove disabled code block.
7971
7972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7973
7974         * gdbarch.sh (get_thread_local_address): New method.
7975         * gdbarch.h, gdbarch.c: Regenerate.
7976         * target.c (target_translate_tls_address): Use
7977         gdbarch_get_thread_local_address if present instead of
7978         target::get_thread_local_address.
7979
7980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7981
7982         * target.h (target::get_thread_local_address): Update comment.
7983
7984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7985
7986         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7987         objfile->separate_debug_objfile_backlink if not NULL.
7988
7989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7990
7991         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7992         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7993         (amd64bsd_store_inferior_registers): Likewise.
7994         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7995         Enable segment base registers.
7996         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7997         PT_GETFSBASE and PT_GETGSBASE.
7998         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7999         PT_SETGSBASE.
8000         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8001         segment base registers.
8002         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8003
8004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8005
8006         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8007         Update calls to i386_target_description to add 'segments'
8008         parameter.
8009         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8010         add segment base registers.
8011         * arch/i386.c (i386_create_target_description): Add 'segments'
8012         parameter to enable segment base registers.
8013         * arch/i386.h (i386_create_target_description): Likewise.
8014         * features/i386/32bit-segments.xml: New file.
8015         * features/i386/32bit-segments.c: Generate.
8016         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8017         call to i386_target_description to add 'segments' parameter.
8018         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8019         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8020         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8021         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8022         if feature is present.
8023         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8024         Add 'segments' parameter to call to i386_target_description.
8025         (i386_target_description): Add 'segments' parameter to enable
8026         segment base registers.
8027         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8028         to call to i386_target_description.
8029         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8030         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8031         Define I386_NUM_REGS.
8032         (i386_target_description): Add 'segments' parameter to enable
8033         segment base registers.
8034
8035 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8036
8037         PR/24325
8038         * source-cache.c: #undef open and close, to avoid unresolved
8039         externals during linking.
8040
8041 2019-03-12  Tom Tromey  <tromey@adacore.com>
8042
8043         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8044         const.  Add initializers.
8045         (_initialize_remote): Don't initialize ptid globals.
8046
8047 2019-03-12  Pedro Alves  <palves@redhat.com>
8048
8049         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8050
8051 2019-03-12  Pedro Alves  <palves@redhat.com>
8052
8053         * cp-name-parser.y (main): Remove unused 'len' variable.
8054
8055 2019-03-12  Tom Tromey  <tromey@adacore.com>
8056
8057         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8058         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8059
8060 2019-03-12  Tom Tromey  <tromey@adacore.com>
8061
8062         * linux-nat.c (iterate_over_lwps): Update.
8063         (stop_callback): Remove parameter.
8064         (stop_wait_callback, detach_callback, resume_set_callback)
8065         (select_singlestep_lwp_callback, set_ignore_sigint)
8066         (status_callback, resumed_callback, resume_clear_callback)
8067         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8068         data parameter.
8069         (linux_nat_target::detach, linux_nat_target::resume)
8070         (linux_stop_and_wait_all_lwps, select_event_lwp)
8071         (linux_nat_filter_event, linux_nat_wait_1)
8072         (linux_nat_target::kill, linux_nat_target::stop)
8073         (linux_nat_target::stop): Update.
8074         (linux_nat_resume_callback): Change type.
8075         (resume_stopped_resumed_lwps, count_events_callback)
8076         (select_event_lwp_callback): Likewise.
8077         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8078         * arm-linux-nat.c (struct update_registers_data): Remove.
8079         (update_registers_callback): Change type.
8080         (arm_linux_insert_hw_breakpoint1): Update.
8081         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8082         parameter.
8083         (x86_linux_dr_set_addr): Update.
8084         (x86_linux_dr_set_control): Update.
8085         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8086         (iterate_over_lwps): Use gdb::function_view.
8087         * nat/aarch64-linux-hw-point.c (struct
8088         aarch64_dr_update_callback_param): Remove.
8089         (debug_reg_change_callback): Change type.
8090         (aarch64_notify_debug_reg_change): Update.
8091         * s390-linux-nat.c (s390_refresh_per_info): Update.
8092
8093 2019-03-11  Tom Tromey  <tromey@adacore.com>
8094
8095         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8096         redundant assignment to "this_cu".
8097
8098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8099
8100         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8101
8102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8103
8104         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8105         from...
8106         (rank_one_type): ... this.
8107
8108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8109
8110         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8111         from...
8112         (rank_one_type): ... this.
8113
8114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8115
8116         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8117         from...
8118         (rank_one_type): ... this.
8119
8120 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8121
8122         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8123         from...
8124         (rank_one_type): ... this.
8125
8126 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8127
8128         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8129         from...
8130         (rank_one_type): ... this.
8131
8132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8133
8134         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8135         from...
8136         (rank_one_type): ... this.
8137
8138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8139
8140         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8141         from...
8142         (rank_one_type): ... this.
8143
8144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8145
8146         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8147         from...
8148         (rank_one_type): ... this.
8149
8150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8151
8152         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8153         from...
8154         (rank_one_type): ... this.
8155
8156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8157
8158         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8159         from...
8160         (rank_one_type): ... this.
8161
8162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8163
8164         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8165         from...
8166         (rank_one_type): ... this.
8167
8168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8169
8170         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8171         from...
8172         (rank_one_type): ... this.
8173
8174 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8175
8176         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8177         inferior-events' shows the example events.
8178
8179 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8180
8181         Support styling on native MS-Windows console
8182
8183         PR/24315
8184         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8185         on MS-Windows if $TERM is not defined.
8186
8187         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8188
8189         * posix-hdep.c (gdb_console_fputs):
8190         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8191         functions.
8192         * ui-file.h (gdb_console_fputs): Add prototype.
8193
8194         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8195         back to fputs only if the former returns zero.
8196
8197 2019-03-07  Tom Tromey  <tom@tromey.com>
8198
8199         * symmisc.c (print_symbol_bcache_statistics): Update.
8200         (print_objfile_statistics): Update.
8201         * symfile.c (allocate_symtab): Update.
8202         * stabsread.c: Don't include bcache.h.
8203         * psymtab.h (struct psymbol_bcache): Don't declare.
8204         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8205         (psymbol_bcache_init, psymbol_bcache_free)
8206         (psymbol_bcache_get_bcache): Don't declare.
8207         * psymtab.c (struct psymbol_bcache): Remove.
8208         (psymtab_storage::psymtab_storage): Update.
8209         (psymtab_storage::~psymtab_storage): Update.
8210         (psymbol_bcache_init, psymbol_bcache_free)
8211         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8212         (add_psymbol_to_bcache): Update.
8213         (allocate_psymtab): Update.
8214         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8215         macro_cache>: No longer pointers.
8216         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8217         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8218         * macrotab.c (macro_bcache): Update.
8219         * macroexp.c: Don't include bcache.h.
8220         * gdbtypes.c (check_types_worklist): Update.
8221         (types_deeply_equal): Remove TRY/CATCH.  Update.
8222         * elfread.c (elf_symtab_read): Update.
8223         * dwarf2read.c: Don't include bcache.h.
8224         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8225         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8226         (print_bcache_statistics, bcache_memory_used): Don't declare.
8227         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8228         methods.  Rename all data members.
8229         * bcache.c (struct bcache): Move to bcache.h.
8230         (bcache::expand_hash_table): Rename from expand_hash_table.
8231         (bcache): Remove.
8232         (bcache::insert): Rename from bcache_full.
8233         (bcache::compare): Rename from bcache_compare.
8234         (bcache_xmalloc): Remove.
8235         (bcache::~bcache): Rename from bcache_xfree.
8236         (bcache::print_statistics): Rename from print_bcache_statistics.
8237         (bcache::memory_used): Rename from bcache_memory_used.
8238
8239 2019-03-07  Pedro Alves  <palves@redhat.com>
8240
8241         * infrun.c (normal_stop): Also check for
8242         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8243
8244 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8245
8246         * f-lang.c (value_from_host_double): Moved to...
8247         * value.c (value_from_host_double): ...here.
8248         * value.h (value_from_host_double): Declare.
8249         * guile/scm-math.c (vlscm_convert_typed_number): Use
8250         value_from_host_double.
8251         (vlscm_convert_number): Likewise.
8252         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8253         * python/py-value.c (convert_value_from_python): Likewise.
8254
8255 2019-03-06  Tom Tromey  <tom@tromey.com>
8256
8257         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8258
8259 2019-03-06  Tom Tromey  <tom@tromey.com>
8260
8261         * utils.h (free_current_contents): Don't declare.
8262         * utils.c (free_current_contents): Remove.
8263
8264 2019-03-06  Tom Tromey  <tom@tromey.com>
8265
8266         * top.c (quit_force): Update.
8267         * main.c (captured_command_loop): Update.
8268         * common/new-op.c (operator new): Update.
8269         * common/common-exceptions.c (struct catcher)
8270         <save_cleanup_chain>: Remove member.
8271         (exceptions_state_mc_init): Update.
8272         (exception_try_scope_entry): Return nullptr.
8273         (exception_try_scope_exit, exception_rethrow)
8274         (throw_exception_sjlj, throw_exception_cxx): Update.
8275         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8276         (all_cleanups, do_cleanups, discard_cleanups)
8277         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8278         (restore_cleanups, restore_final_cleanups): Don't declare.
8279         (do_final_cleanups): Remove parameter.
8280         * common/cleanups.c (cleanup_chain, make_cleanup)
8281         (make_cleanup_dtor, all_cleanups, do_cleanups)
8282         (discard_my_cleanups, discard_cleanups)
8283         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8284         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8285         (null_cleanup): Remove.
8286         (do_final_cleanups): Remove parameter.
8287
8288 2019-03-06  Tom Tromey  <tom@tromey.com>
8289
8290         * remote.c (remote_target::remote_parse_stop_reply): Use
8291         unique_xmalloc_ptr.
8292
8293 2019-03-06  Tom Tromey  <tom@tromey.com>
8294
8295         * stabsread.c (struct stabs_field_info): Rename from field_info.
8296         <list, fnlist>: Add initializers.
8297         <obstack>: New member.
8298         (read_member_functions, read_struct_fields, read_baseclasses):
8299         Allocate on obstack.  Don't use cleanups.
8300         (read_one_struct_field, read_member_functions, read_struct_fields)
8301         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8302         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8303         (read_struct_type): Update.
8304
8305 2019-03-06  Tom Tromey  <tom@tromey.com>
8306
8307         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8308         * common/filestuff.h (make_cleanup_close): Don't declare.
8309         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8310         Remove.
8311
8312 2019-03-06  Tom Tromey  <tom@tromey.com>
8313
8314         * solib-aix.c: Use make_scope_exit.
8315
8316 2019-03-06  Tom Tromey  <tom@tromey.com>
8317
8318         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8319         Use make_scope_exit.
8320
8321 2019-03-06  Tom Tromey  <tom@tromey.com>
8322
8323         * solib-svr4.c (disable_probes_interface): Remove parameter.
8324         (svr4_handle_solib_event): Use make_scope_exit.
8325
8326 2019-03-06  Tom Tromey  <tom@tromey.com>
8327
8328         * remote.c (struct stop_reply_deleter): Remove.
8329         (stop_reply_up): Update.
8330         (struct stop_reply): Derive from notif_event.  Don't typedef.
8331         <regcache>: Now a std::vector.
8332         (stop_reply_xfree): Remove.
8333         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8334         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8335         (remote_target::discard_pending_stop_replies): Use delete.
8336         (remote_target::remote_parse_stop_reply): Update.
8337         (remote_target::process_stop_reply): Update.
8338         * remote-notif.h (struct notif_event): Add virtual destructor.
8339         Remove "dtr" member.
8340         (struct notif_client) <alloc_event>: Return a unique_ptr.
8341         (notif_event_xfree): Don't declare.
8342         (notif_event_up): New typedef.
8343         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8344         (notif_event_xfree, do_notif_event_xfree): Remove.
8345         (remote_notif_state_xfree): Update.
8346
8347 2019-03-06  Tom Tromey  <tom@tromey.com>
8348
8349         * infrun.c (displaced_step_clear_cleanup): Now a
8350         forward_scope_exit type.
8351         (displaced_step_prepare_throw): Update.
8352         (displaced_step_fixup): Update.
8353
8354 2019-03-06  Tom Tromey  <tom@tromey.com>
8355
8356         * inferior.h (class inferior): Update comment.
8357         * gdbthread.h (class thread_info): Update comment.
8358
8359 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8360             Tom Tromey  <tom@tromey.com>
8361
8362         * stabsread.h (struct stab_section_list): Remove.
8363         (coffstab_build_psymtabs): Update.
8364         * dbxread.c (symbuf_sections): Now a std::vector.
8365         (sect_idx): New global.
8366         (fill_symbuf): Update.
8367         (coffstab_build_psymtabs): Change type of stabsects parameter.
8368         Update.
8369         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8370         std::vector.
8371         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8372         (coff_locate_sections): Update.
8373         (coff_symfile_read): Remove cleanups.  Update.
8374         (init_stringtab): Add storage parameter.
8375         (free_stringtab, free_stringtab_cleanup): Remove.
8376         (init_lineno): Add storage parameter.
8377         (free_linetab, free_linetab_cleanup): Remove.
8378
8379 2019-03-06  Pedro Alves  <palves@redhat.com>
8380
8381         * linux-fork.c (fork_info::clobber_regs): Delete.
8382         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8383         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8384         comment.  Adjust.
8385         (scoped_switch_fork_info::scoped_switch_fork_info)
8386         (checkpoint_command, linux_fork_context): Adjust
8387         fork_save_infrun_state calls.
8388
8389 2019-03-06  Pedro Alves  <palves@redhat.com>
8390
8391         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8392         (inf_has_multiple_threads): Return 'bool' and rewrite using
8393         inferior_info::threads().
8394
8395 2019-03-06  Pedro Alves  <palves@redhat.com>
8396
8397         * linux-fork.c: Include <list>.
8398         (fork_list): Now a std::list instance.
8399         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8400         (forks_exist_p, find_last_fork): Adjust.
8401         (new_fork): Delete.
8402         (one_fork_p): New.
8403         (add_fork): Adjust.
8404         (free_fork): Delete, folded into fork_info::~fork_info().
8405         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8406         Adjust.
8407         (init_fork_list): Delete.
8408         (linux_fork_killall, linux_fork_mourn_inferior)
8409         (linux_fork_detach, info_checkpoints_command): Adjust.
8410         (_initialize_linux_fork): No longer call init_fork_list.
8411
8412 2019-03-06  Pedro Alves  <palves@redhat.com>
8413
8414         * linux-fork.c (new_fork): New, split out of ...
8415         (add_fork): ... this.  Return void.  Move "first fork" special
8416         case from here, to ...
8417         (checkpoint_command): ... here.
8418         * linux-linux.h (add_fork): Return void.
8419
8420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8421
8422         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8423
8424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8425             Chris January  <chris.january@arm.com>
8426             David Lecomber  <david.lecomber@arm.com>
8427
8428         * f-exp.y: New token, UNOP_INTRINSIC.
8429         (exp): New pattern using UNOP_INTRINSIC token.
8430         (f77_keywords): Add 'abs' keyword.
8431         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8432         (value_from_host_double): New function.
8433         (evaluate_subexp_f): Support UNOP_ABS.
8434
8435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8438         types.
8439
8440 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8441
8442         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8443         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8444         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8445
8446 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8447
8448         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8449
8450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8451             Chris January  <chris.january@arm.com>
8452
8453         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8454         * f-exp.y: Define 'KIND' token.
8455         (exp): New pattern for KIND expressions.
8456         (ptype): Handle types with a kind extension.
8457         (direct_abs_decl): Extend to spot kind extensions.
8458         (f77_keywords): Add 'kind' to the list.
8459         (push_kind_type): New function.
8460         (convert_to_kind_type): New function.
8461         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8462         * parse.c (operator_length_standard): Likewise.
8463         * parser-defs.h (enum type_pieces): Add tp_kind.
8464         * std-operator.def: Add UNOP_KIND.
8465
8466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * f-exp.y (f_parse): Set yydebug.
8469
8470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * f-lang.c (evaluate_subexp_f): New function.
8473         (exp_descriptor_f): New global.
8474         (f_language_defn): Use exp_descriptor_f instead of
8475         exp_descriptor_standard.
8476
8477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * f-exp.y (struct token): Add comments.
8480         (dot_ops): Remove uppercase versions and the end marker.
8481         (f77_keywords): Likewise.
8482         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8483         entries in the dot_ops array are case insensitive, and use
8484         strncasecmp to compare strings.  Also some whitespace cleanup in
8485         this area.  Similar for the f77_keywords array, except entries in
8486         this list might be case sensitive.
8487
8488 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8489
8490         * f-exp.y (struct f77_boolean_val): Add comments.
8491         (boolean_values): Remove uppercase versions, and end marker.
8492         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8493         and use strncasecmp to achieve case insensitivity.  Additionally,
8494         perform whitespace cleanup around this code.
8495
8496 2019-03-06  Tom Tromey  <tromey@adacore.com>
8497
8498         * remote-sim.c (gdbsim_target_open): Use result of
8499         gdb_argv::release.
8500
8501 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8502         Dirk Schubert  <dirk.schubert@arm.com>
8503         Chris January  <chris.january@arm.com>
8504
8505         * eval.c (evaluate_subexp_standard): Call Fortran argument
8506         wrapping logic.
8507         * f-lang.c (struct value): A value which can be passed into a
8508         Fortran function call.
8509         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8510         where appropriate.
8511         (struct type): Value ready for a Fortran function call.
8512         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8513         is needed.
8514         * f-lang.h (fortran_argument_convert): Declaration.
8515         (fortran_preserve_arg_pointer): Declaration.
8516         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8517
8518 2019-03-05  Tom Tromey  <tromey@adacore.com>
8519
8520         * python/py-prettyprint.c (print_string_repr): Remove #if.
8521         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8522
8523 2019-03-05  Tom Tromey  <tromey@adacore.com>
8524
8525         * target.c (the_dummy_target): Move later.  Change type to
8526         "dummy_target".
8527         (initialize_targets): Don't initialize the_dummy_target.
8528
8529 2019-03-05  Tom Tromey  <tromey@adacore.com>
8530
8531         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8532         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8533
8534 2019-03-05  Tom Tromey  <tromey@adacore.com>
8535
8536         * windows-nat.c (windows_nat_target::attach)
8537         (windows_nat_target::detach): Don't call gdb_flush.
8538         * valprint.c (generic_val_print, val_print, val_print_string):
8539         Don't call gdb_flush.
8540         * utils.c (defaulted_query): Don't call gdb_flush.
8541         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8542         * target.c (target_announce_detach): Don't call gdb_flush.
8543         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8544         * remote.c (extended_remote_target::attach): Don't call
8545         gdb_flush.
8546         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8547         * printcmd.c (do_examine): Don't call gdb_flush.
8548         (info_display_command): Don't call gdb_flush.
8549         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8550         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8551         * memattr.c (info_mem_command): Don't call gdb_flush.
8552         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8553         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8554         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8555         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8556         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8557         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8558         (gnu_nat_target::detach): Don't call gdb_flush.
8559         * f-valprint.c (f_val_print): Don't call gdb_flush.
8560         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8561         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8562         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8563         gdb_flush.
8564         * c-valprint.c (c_val_print): Don't call gdb_flush.
8565         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8566
8567 2019-03-05  Tom Tromey  <tromey@adacore.com>
8568
8569         * varobj.c (update_dynamic_varobj_children): Update.
8570         (install_default_visualizer): Use reset, not release.
8571         * value.c (set_internalvar): Update.
8572         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8573         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8574         ATTRIBUTE_UNUSED_RESULT.
8575
8576 2019-03-05  Tom Tromey  <tromey@adacore.com>
8577
8578         * remote.c (class scoped_remote_fd) <release>: Add
8579         ATTRIBUTE_UNUSED_RESULT.
8580
8581 2019-03-05  Tom Tromey  <tromey@adacore.com>
8582
8583         * macroexp.c (struct macro_buffer) <release>: Add
8584         ATTRIBUTE_UNUSED_RESULT.
8585
8586 2019-03-05  Tom Tromey  <tromey@adacore.com>
8587
8588         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8589         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8590         ATTRIBUTE_UNUSED_RESULT.
8591
8592 2019-03-05  Tom Tromey  <tromey@adacore.com>
8593
8594         * common/scoped_fd.h (class scoped_fd) <release>: Add
8595         ATTRIBUTE_UNUSED_RESULT.
8596
8597 2019-03-05  Tom Tromey  <tromey@adacore.com>
8598
8599         * parser-defs.h (struct parser_state) <release>: Add
8600         ATTRIBUTE_UNUSED_RESULT.
8601
8602 2019-03-05  Tom Tromey  <tromey@adacore.com>
8603
8604         * utils.h (class gdb_argv) <release>: Add
8605         ATTRIBUTE_UNUSED_RESULT.
8606         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8607
8608 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8609
8610         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8611         for-loop range, to avoid compiler warnings.
8612
8613         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8614         avoid compiler warnings about unused variables.
8615
8616         * NEWS: Mention end of support for native debugging on MS-Windows
8617         before XP.
8618
8619         PR gdb/24292
8620         * common/netstuff.c:
8621         * gdbserver/gdbreplay.c
8622         * gdbserver/remote-utils.c:
8623         * ser-tcp.c:
8624         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8625         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8626         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8627         'getaddrinfo' and 'freeaddrinfo' were not available before
8628         Windows XP, and mingw.org's MinGW headers by default define
8629         _WIN32_WINNT to 0x500.
8630
8631 2019-03-01  Gary Benson <gbenson@redhat.com>
8632
8633         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8634
8635 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8636             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8637
8638         PR gdb/8527
8639         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8640         set_sigint_trap, clear_sigint_trap.
8641
8642 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8643
8644         * target.c (target_detach): Clear the regcache and the
8645         frame cache.
8646
8647 2019-02-27  Pedro Alves  <palves@redhat.com>
8648
8649         * utils.c (set_screen_size): When we cap the height/width sizes,
8650         tweak the corresponding command variable to show "unlimited":
8651
8652 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8653             Pedro Alves  <palves@redhat.com>
8654
8655         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8656         before calling rl_set_screen_size.
8657
8658 2019-02-27  Tom Tromey  <tromey@adacore.com>
8659
8660         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8661         define.
8662         * python/py-value.c: Remove Python 2.4 workaround.
8663         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8664         workaround.
8665         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8666         Python 2.4 workaround.
8667         * python/python-internal.h: Remove Python 2.4 comment.
8668         (Py_ssize_t): Don't define.
8669         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8670         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8671         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8672         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8673         * python/python.c (do_start_initialization): Remove Python 2.4
8674         workaround.
8675         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8676         (print_children): Remove Python 2.4 workaround.
8677         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8678         workaround.
8679         (CHARBUFFERPROC_NAME): Remove.
8680         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8681         Python 2.4 workaround.
8682
8683 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8684
8685         * NEWS: Note minimum Python version.
8686
8687 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8688
8689         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8690         code from these functions.  Remove corresponding ifdefs.  Use
8691         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8692         Remove gotos and target of gotos.
8693         (infpy_search_memory): Likewise.
8694
8695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8696
8697         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8698         (hppa_gdbarch_init): Don't register deleted functions with
8699         gdbarch.
8700
8701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8702
8703         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8704         (h8300_unwind_sp): Delete.
8705         (h8300_dummy_id): Delete.
8706         (h8300_gdbarch_init): Don't register deleted functions with
8707         gdbarch.
8708
8709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8710
8711         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8712         (ft32_unwind_pc): Delete.
8713         (ft32_unwind_sp): Delete.
8714         (ft32_gdbarch_init): Don't register deleted functions with
8715         gdbarch.
8716
8717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8718
8719         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8720         (frv_unwind_pc): Delete.
8721         (frv_unwind_sp): Delete.
8722         (frv_gdbarch_init): Don't register deleted functions with
8723         gdbarch.
8724
8725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8728         (riscv_unwind_pc): Delete.
8729         (riscv_unwind_sp): Delete.
8730         (riscv_gdbarch_init): Don't register deleted functions with
8731         gdbarch.
8732
8733 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8736         (csky_unwind_pc): Delete.
8737         (csky_unwind_sp): Delete.
8738         (csky_gdbarch_init): Don't register deleted functions with
8739         gdbarch.
8740
8741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8742
8743         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8744         (cris_unwind_pc): Delete.
8745         (cris_unwind_sp): Delete.
8746         (cris_gdbarch_init): Don't register deleted functions with
8747         gdbarch.
8748
8749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8752         (bfin_unwind_pc): Delete.
8753         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8754
8755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8756
8757         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8758         (arm_unwind_pc): Delete.
8759         (arm_unwind_sp): Delete.
8760         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8761
8762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8765         (arc_unwind_pc): Delete.
8766         (arc_unwind_sp): Delete.
8767         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8768
8769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8772         (alpha_unwind_pc): Delete.
8773         (alpha_gdbarch_init): Don't register deleted functions with
8774         gdbarch.
8775
8776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8777
8778         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8779         (aarch64_unwind_pc): Delete.
8780         (aarch64_unwind_sp): Delete.
8781         (aarch64_gdbarch_init): Don't register deleted functions with
8782         gdbarch.
8783
8784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8785
8786         * gdbtypes.c (type_align): Don't consider static members when
8787         computing structure alignment.
8788
8789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8790
8791         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8792         return 0 for other types.
8793         * arch-utils.c (default_type_align): Always return 0.
8794         * gdbarch.h: Regenerate.
8795         * gdbarch.sh (type_align): Extend comment.
8796         * gdbtypes.c (type_align): Add additional comments, always call
8797         gdbarch_type_align before applying the default rules.
8798         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8799         generic code will then apply a suitable default.
8800         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8801         types, return 0 for other types.
8802
8803 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8804
8805         * NEWS: Create a new section for the next release branch.
8806         Rename the section of the current branch, now that it has
8807         been cut.
8808
8809 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8810
8811         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8812         * version.in: Bump version to 8.3.50.DATE-git.
8813
8814 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8815
8816         * aix-thread.c (ptid_cmp): Remove unused variable.
8817         (get_signaled_thread): Likewise.
8818         (store_regs_user_thread): Likewise.
8819         (store_regs_kernel_thread): Likewise.
8820         (fetch_regs_kernel_thread): Remove shadowed variable.
8821
8822 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * features/riscv/32bit-cpu.xml: Add register numbers.
8825         * features/riscv/32bit-fpu.c: Regenerate.
8826         * features/riscv/32bit-fpu.xml: Add register numbers.
8827         * features/riscv/64bit-cpu.xml: Add register numbers.
8828         * features/riscv/64bit-fpu.c: Regenerate.
8829         * features/riscv/64bit-fpu.xml: Add register numbers.
8830
8831 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8832
8833         * NEWS: Mention two argument form of gdb.Value constructor.
8834         * python/py-value.c (convert_buffer_and_type_to_value): New
8835         function.
8836         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8837         Add support for handling an optional second argument.  Call
8838         convert_buffer_and_type_to_value as appropriate.
8839         * python/python-internal.h (Py_buffer_deleter): New struct.
8840         (Py_buffer_up): New typedef.
8841
8842 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8843
8844         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8845         instead of releasing ownership.
8846
8847 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8848
8849         * dwarf2read.c (open_and_init_dwp_file): Call
8850         elf_numsections instead of bfd_count_sections to initialize
8851         dwp_file->num_sections.
8852
8853 2019-02-25  Tom Tromey  <tromey@adacore.com>
8854
8855         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8856
8857 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8858
8859         * gcore.in: Add '--readnever' option when invoking GDB.
8860
8861 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8862
8863         * MAINTAINERS: Update my email address.
8864
8865 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8866
8867         * build-id.c (build_id_to_debug_bfd_1): New function.
8868         (build_id_to_debug_bfd): Look for separate debug file in
8869         sysroot.
8870
8871 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8872
8873         * gdbarch.sh: Update the copyright year range that is placed into
8874         generated files.
8875
8876 2019-02-22  Keith Seitz  <keiths@redhat.com>
8877
8878         PR symtab/23853
8879         * linespec.c (create_sals_line_offset): Search for the default
8880         symtab's filename instead of its fullname.
8881
8882 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8883
8884         * NEWS: Update style defaults.
8885
8886 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8887
8888         * main.c (captured_main_1): Disable styling in batch mode.
8889
8890 2019-02-20  Tom Tromey  <tom@tromey.com>
8891
8892         * symtab.c (symtab_symbol_info): Fix typos.
8893
8894 2019-02-20  Tom Tromey  <tromey@adacore.com>
8895
8896         * findcmd.c (_initialize_mem_search): Use upper case for
8897         metasyntactic variables.
8898
8899 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8900
8901         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8902         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8903
8904 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8905
8906         * top.h (source_file_name): Change to std::string.
8907         * top.c (source_file_name): Likewise.
8908         (command_line_input): Adjust.
8909         * cli/cli-script.c (script_from_file): Adjust.
8910
8911 2019-02-19  Tom Tromey  <tromey@adacore.com>
8912
8913         * ravenscar-thread.c
8914         (ravenscar_thread_target::update_thread_list): Don't call
8915         ada_build_task_list.
8916         * ada-lang.h (ada_build_task_list): Don't declare.
8917         * ada-tasks.c (struct ada_tasks_inferior_data)
8918         <task_list_valid_p>: Now bool.
8919         (read_known_tasks, ada_task_list_changed)
8920         (ada_tasks_invalidate_inferior_data): Update.
8921         (read_known_tasks_array): Return bool.
8922         (read_known_tasks_list): Likewise.
8923         (read_known_tasks): Return void.
8924         (ada_build_task_list): Now static.
8925
8926 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8929         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8930
8931 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8932
8933         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8934         variant for ada_tasks_pspace_data_handle and
8935         ada_tasks_inferior_data_handle.
8936         (ada_tasks_pspace_data_cleanup): New function.
8937         (ada_tasks_inferior_data_cleanup): New function.
8938
8939 2019-02-17  Tom Tromey  <tom@tromey.com>
8940
8941         * macrotab.h (macro_source_fullname): Return a std::string.
8942         * macrotab.c (macro_include, check_for_redefinition)
8943         (macro_undef, macro_lookup_definition, foreach_macro)
8944         (foreach_macro_in_scope): Update.
8945         (macro_source_fullname): Return a std::string.
8946         * macrocmd.c (show_pp_source_pos): Update.
8947
8948 2019-02-17  Tom Tromey  <tom@tromey.com>
8949
8950         * macrocmd.c (show_pp_source_pos): Style the file names.
8951
8952 2019-02-17  Tom Tromey  <tom@tromey.com>
8953
8954         PR tui/24197:
8955         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8956
8957 2019-02-17  Tom Tromey  <tom@tromey.com>
8958
8959         * ada-lang.c (user_select_syms): Use filtered printing.
8960         * utils.c (wrap_style): New global.
8961         (desired_style): Remove.
8962         (emit_style_escape): Add stream parameter.
8963         (set_output_style, reset_terminal_style, prompt_for_continue):
8964         Update.
8965         (flush_wrap_buffer): Only flush gdb_stdout.
8966         (wrap_here): Set wrap_style.
8967         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8968         treat escape sequences as a character.  Change when wrap buffer is
8969         flushed.
8970         (fputs_styled): Do not set the output style when the default is
8971         requested.
8972         * ui-style.h (struct ui_file_style) <is_default>: New method.
8973         * source.c (print_source_lines_base): Emit escape sequences in one
8974         piece.
8975
8976 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8977
8978         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8979         integers and enumeration types.
8980
8981 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8982
8983         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8984         instead of lookup_symbol_in_language
8985         (do_exact_match): New function.
8986         (ada_get_symbol_name_matcher): Return do_exact_match when
8987         doing a verbatim match.
8988
8989 2019-02-15  Tom Tromey  <tromey@adacore.com>
8990
8991         * ravenscar-thread.c (ravenscar_thread_target::resume)
8992         (ravenscar_thread_target::wait): Special case wildcard requests.
8993
8994 2019-02-15  Tom Tromey  <tromey@adacore.com>
8995
8996         * ravenscar-thread.c (base_ptid): Remove.
8997         (struct ravenscar_thread_target) <close>: New method.
8998         <m_base_ptid>: New member.
8999         <update_inferior_ptid, active_task, task_is_currently_active,
9000         runtime_initialized>: Declare methods.
9001         <ravenscar_thread_target>: Add constructor.
9002         (ravenscar_thread_target::task_is_currently_active)
9003         (ravenscar_thread_target::update_inferior_ptid)
9004         (ravenscar_runtime_initialized): Rename.  Now methods.
9005         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9006         (ravenscar_thread_target::update_thread_list): Update.
9007         (ravenscar_thread_target::active_task): Now method.
9008         (ravenscar_thread_target::store_registers)
9009         (ravenscar_thread_target::prepare_to_store)
9010         (ravenscar_thread_target::prepare_to_store)
9011         (ravenscar_thread_target::mourn_inferior): Update.
9012         (ravenscar_inferior_created): Use "new" to create target.
9013         (ravenscar_thread_target::get_ada_task_ptid): Update.
9014         (_initialize_ravenscar): Don't initialize base_ptid.
9015         (ravenscar_ops): Remove global.
9016
9017 2019-02-15  Tom Tromey  <tromey@adacore.com>
9018
9019         * target.h (push_target): Declare new overload.
9020         * target.c (push_target): New overload, taking an rvalue reference.
9021         * remote.c (remote_target::open_1): Use push_target overload.
9022         * corelow.c (core_target_open): Use push_target overload.
9023
9024 2019-02-15  Tom Tromey  <tromey@adacore.com>
9025
9026         * ravenscar-thread.c (is_ravenscar_task)
9027         (ravenscar_task_is_currently_active): Return bool.
9028         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9029         (_initialize_ravenscar): Remove "(void)".
9030         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9031         Return bool.
9032
9033 2019-02-15  Tom Tromey  <tromey@adacore.com>
9034
9035         * ravenscar-thread.c (ravenscar_runtime_initializer)
9036         (has_ravenscar_runtime, get_running_thread_id)
9037         (ravenscar_thread_target::resume): Fix indentation.
9038
9039 2019-02-15  Tom Tromey  <tromey@adacore.com>
9040
9041         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9042         from ravenscar_arch_ops.
9043         (sparc_ravenscar_ops::fetch_registers)
9044         (sparc_ravenscar_ops::store_registers): Now methods.
9045         (sparc_ravenscar_prepare_to_store): Remove.
9046         (sparc_ravenscar_ops): Redefine.
9047         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9048         methods and destructor.  Remove members.
9049         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9050         (ravenscar_thread_target::store_registers)
9051         (ravenscar_thread_target::prepare_to_store): Update.
9052         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9053         Remove.
9054         (struct ppc_ravenscar_powerpc_ops): Derive from
9055         ravenscar_arch_ops.
9056         (ppc_ravenscar_powerpc_ops::fetch_registers)
9057         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9058         (ppc_ravenscar_powerpc_ops): Redefine.
9059         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9060         (ppc_ravenscar_e500_ops::fetch_registers)
9061         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9062         (ppc_ravenscar_e500_ops): Redefine.
9063         * aarch64-ravenscar-thread.c
9064         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9065         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9066         (aarch64_ravenscar_fetch_registers)
9067         (aarch64_ravenscar_store_registers): Now methods.
9068         (aarch64_ravenscar_ops): Redefine.
9069
9070 2019-02-15  Tom Tromey  <tromey@adacore.com>
9071
9072         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9073         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9074         (ravenscar_thread_target::stopped_by_watchpoint)
9075         (ravenscar_thread_target::stopped_data_address)
9076         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9077
9078 2019-02-15  Tom Tromey  <tromey@adacore.com>
9079
9080         * ravenscar-thread.c: Fix some typos.
9081
9082 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9083             Tom Tromey  <tromey@adacore.com>
9084
9085         * ada-lang.c (ada_exception_sal): Change addr_string to a
9086         std::string.
9087         (create_ada_exception_catchpoint): Update.
9088
9089 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9090             Tom Tromey  <tromey@adacore.com>
9091
9092         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9093         (bp_location_ops): Remove.
9094         (base_breakpoint_allocate_location): Update.
9095         (free_bp_location): Update.
9096         * ada-lang.c (class ada_catchpoint_location)
9097         <ada_catchpoint_location>: Remove ops parameter.
9098         (ada_catchpoint_location_dtor): Remove.
9099         (ada_catchpoint_location_ops): Remove.
9100         (allocate_location_exception): Update.
9101         * breakpoint.h (struct bp_location_ops): Remove.
9102         (class bp_location) <bp_location>: Remove bp_location_ops
9103         parameter.
9104         <~bp_location>: Add destructor.
9105         <ops>: Remove.
9106
9107 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9108             Pedro Alves  <palves@redhat.com>
9109
9110         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9111         'PATH_MAX'.
9112
9113 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9114             Samuel Thibault  <samuel.thibault@gnu.org>
9115             Thomas Schwinge  <thomas@codesourcery.com>
9116
9117         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9118         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9119
9120 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9121
9122         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9123         (check_empty): Use "const char *".
9124
9125         * gnu-nat.c (gnu_nat_target::detach): Instead of
9126         'detach_inferior (pid)' call
9127         'detach_inferior (find_inferior_pid (pid))'.
9128
9129         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9130         'nat/fork-inferior.o'.
9131         * gnu-nat.c: #include "nat/fork-inferior.h".
9132
9133         * gnu-nat.c (gnu_nat_target::detach): Instead of
9134         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9135         * gnu-nat.h: #include "inf-child.h".
9136         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9137         'i386_gnu_nat_target::fetch_registers'.
9138         (gnu_store_registers): Rename/move to
9139         'i386_gnu_nat_target::store_registers'.
9140
9141         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9142         * gnu-nat.h (mach_thread_info): New function.
9143         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9144
9145         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9146
9147 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9148
9149         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9150
9151 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9152
9153         * windows-nat.c (windows_add_thread): Add new parameter
9154         "main_thread_p" with default value set to false.  Update
9155         function documentation as well as all callers.
9156         (windows_delete_thread): Likewise.
9157         (fake_create_process): Update call to windows_add_thread.
9158         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9159         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9160         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9161         call to windows_delete_thread.
9162
9163 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9164
9165         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9166
9167 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9168
9169         * symfile.c (find_separate_debug_file): Use canonical path of
9170         sysroot with child_path instead of gdb_sysroot if it is valid.
9171
9172 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9173
9174         * symfile.c (find_separate_debug_file): Use child_path to
9175         determine if an object file is under a sysroot.
9176
9177 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9178
9179         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9180         unittests/child-path-selftests.c.
9181         * common/pathstuff.c (child_path): New function.
9182         * common/pathstuff.h (child_path): New prototype.
9183         * unittests/child-path-selftests.c: New file.
9184
9185 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9186
9187         * symfile.c (find_separate_debug_file): Look for separate debug
9188         files in debug directories under the sysroot.
9189
9190 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9191
9192         * symtab.h (struct minimal_symbol data_p): New const method.
9193         (struct minimal_symbol text_p): Likewise.
9194         * symtab.c (output_source_filename): Use file name style
9195         to print file name.
9196         (print_symbol_info): Likewise.
9197         (print_msymbol_info): Use address style to print addresses.
9198         Use function name style to print executable text symbols.
9199         (expand_symtab_containing_pc): Use data_p.
9200         (find_pc_sect_compunit_symtab): Likewise.
9201
9202 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9203
9204         * breakpoint.c (describe_other_breakpoints): Use address style
9205         to print addresses.
9206         (say_where): Likewise.
9207
9208 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9209
9210         * ada-typeprint.c (print_func_type): Print function name
9211         style to print function name.
9212         * c-typeprint.c (c_print_type_1): Likewise.
9213
9214 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9215
9216         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9217         for execve.
9218
9219 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9220
9221         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9222         type_stack.
9223
9224 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9225
9226         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9227         TYPE_CODE_REF types.
9228
9229 2019-02-08  Jim Wilson  <jimw@sifive.com>
9230
9231         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9232         (riscv_linux_fregset): New.
9233         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9234
9235 2019-02-07  Tom Tromey  <tom@tromey.com>
9236
9237         * thread.c (thread_cancel_execution_command): Update.
9238         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9239         methods.
9240         (struct thread_fsm_ops): Remove.
9241         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9242         (thread_fsm_should_stop, thread_fsm_return_value)
9243         (thread_fsm_set_finished, thread_fsm_finished_p)
9244         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9245         Don't declare.
9246         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9247         * infrun.c (clear_proceed_status_thread)
9248         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9249         (print_stop_event): Update.
9250         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9251         Add constructor.
9252         (step_command_fsm_ops): Remove.
9253         (new_step_command_fsm): Remove.
9254         (step_1): Update.
9255         (step_command_fsm::should_stop): Rename from
9256         step_command_fsm_should_stop.
9257         (step_command_fsm::clean_up): Rename from
9258         step_command_fsm_clean_up.
9259         (step_command_fsm::do_async_reply_reason): Rename from
9260         step_command_fsm_async_reply_reason.
9261         (struct until_next_fsm): Inherit from thread_fsm.  Add
9262         constructor.
9263         (until_next_fsm_ops): Remove.
9264         (new_until_next_fsm): Remove.
9265         (until_next_fsm::should_stop): Rename from
9266         until_next_fsm_should_stop.
9267         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9268         (until_next_fsm::do_async_reply_reason): Rename from
9269         until_next_fsm_async_reply_reason.
9270         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9271         constructor.  Change type of breakpoint.
9272         (finish_command_fsm_ops): Remove.
9273         (new_finish_command_fsm): Remove.
9274         (finish_command_fsm::should_stop): Rename from
9275         finish_command_fsm_should_stop.
9276         (finish_command_fsm::clean_up): Rename from
9277         finish_command_fsm_clean_up.
9278         (finish_command_fsm::return_value): Rename from
9279         finish_command_fsm_return_value.
9280         (finish_command_fsm::do_async_reply_reason): Rename from
9281         finish_command_fsm_async_reply_reason.
9282         (finish_command): Update.
9283         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9284         Add constructor.
9285         (call_thread_fsm_ops): Remove.
9286         (call_thread_fsm::call_thread_fsm): Rename from
9287         new_call_thread_fsm.
9288         (call_thread_fsm::should_stop): Rename from
9289         call_thread_fsm_should_stop.
9290         (call_thread_fsm::should_notify_stop): Rename from
9291         call_thread_fsm_should_notify_stop.
9292         (run_inferior_call, call_function_by_hand_dummy): Update.
9293         * cli/cli-interp.c (should_print_stop_to_console): Update.
9294         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9295         Add constructor.  Change type of location_breakpoint,
9296         caller_breakpoint.
9297         (until_break_fsm_ops): Remove.
9298         (new_until_break_fsm): Remove.
9299         (until_break_fsm::should_stop): Rename from
9300         until_break_fsm_should_stop.
9301         (until_break_fsm::clean_up): Rename from
9302         until_break_fsm_clean_up.
9303         (until_break_fsm::do_async_reply_reason): Rename from
9304         until_break_fsm_async_reply_reason.
9305         (until_break_command): Update.
9306         * thread-fsm.c: Remove.
9307         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9308
9309 2019-02-07  Tom Tromey  <tom@tromey.com>
9310
9311         * yy-remap.h: Add include guard.
9312         * xtensa-tdep.h: Add include guard.
9313         * xcoffread.h: Rename include guard.
9314         * varobj-iter.h: Add include guard.
9315         * tui/tui.h: Rename include guard.
9316         * tui/tui-winsource.h: Rename include guard.
9317         * tui/tui-wingeneral.h: Rename include guard.
9318         * tui/tui-windata.h: Rename include guard.
9319         * tui/tui-win.h: Rename include guard.
9320         * tui/tui-stack.h: Rename include guard.
9321         * tui/tui-source.h: Rename include guard.
9322         * tui/tui-regs.h: Rename include guard.
9323         * tui/tui-out.h: Rename include guard.
9324         * tui/tui-layout.h: Rename include guard.
9325         * tui/tui-io.h: Rename include guard.
9326         * tui/tui-hooks.h: Rename include guard.
9327         * tui/tui-file.h: Rename include guard.
9328         * tui/tui-disasm.h: Rename include guard.
9329         * tui/tui-data.h: Rename include guard.
9330         * tui/tui-command.h: Rename include guard.
9331         * tic6x-tdep.h: Add include guard.
9332         * target/waitstatus.h: Rename include guard.
9333         * target/wait.h: Rename include guard.
9334         * target/target.h: Rename include guard.
9335         * target/resume.h: Rename include guard.
9336         * target-float.h: Rename include guard.
9337         * stabsread.h: Add include guard.
9338         * rs6000-tdep.h: Add include guard.
9339         * riscv-fbsd-tdep.h: Add include guard.
9340         * regformats/regdef.h: Rename include guard.
9341         * record.h: Rename include guard.
9342         * python/python.h: Rename include guard.
9343         * python/python-internal.h: Rename include guard.
9344         * python/py-stopevent.h: Rename include guard.
9345         * python/py-ref.h: Rename include guard.
9346         * python/py-record.h: Rename include guard.
9347         * python/py-record-full.h: Rename include guard.
9348         * python/py-record-btrace.h: Rename include guard.
9349         * python/py-instruction.h: Rename include guard.
9350         * python/py-events.h: Rename include guard.
9351         * python/py-event.h: Rename include guard.
9352         * procfs.h: Add include guard.
9353         * proc-utils.h: Add include guard.
9354         * p-lang.h: Add include guard.
9355         * or1k-tdep.h: Rename include guard.
9356         * observable.h: Rename include guard.
9357         * nto-tdep.h: Rename include guard.
9358         * nat/x86-linux.h: Rename include guard.
9359         * nat/x86-linux-dregs.h: Rename include guard.
9360         * nat/x86-gcc-cpuid.h: Add include guard.
9361         * nat/x86-dregs.h: Rename include guard.
9362         * nat/x86-cpuid.h: Rename include guard.
9363         * nat/ppc-linux.h: Rename include guard.
9364         * nat/mips-linux-watch.h: Rename include guard.
9365         * nat/linux-waitpid.h: Rename include guard.
9366         * nat/linux-ptrace.h: Rename include guard.
9367         * nat/linux-procfs.h: Rename include guard.
9368         * nat/linux-osdata.h: Rename include guard.
9369         * nat/linux-nat.h: Rename include guard.
9370         * nat/linux-namespaces.h: Rename include guard.
9371         * nat/linux-btrace.h: Rename include guard.
9372         * nat/glibc_thread_db.h: Rename include guard.
9373         * nat/gdb_thread_db.h: Rename include guard.
9374         * nat/gdb_ptrace.h: Rename include guard.
9375         * nat/fork-inferior.h: Rename include guard.
9376         * nat/amd64-linux-siginfo.h: Rename include guard.
9377         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9378         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9379         * nat/aarch64-linux.h: Rename include guard.
9380         * nat/aarch64-linux-hw-point.h: Rename include guard.
9381         * mn10300-tdep.h: Add include guard.
9382         * mips-linux-tdep.h: Add include guard.
9383         * mi/mi-parse.h: Rename include guard.
9384         * mi/mi-out.h: Rename include guard.
9385         * mi/mi-main.h: Rename include guard.
9386         * mi/mi-interp.h: Rename include guard.
9387         * mi/mi-getopt.h: Rename include guard.
9388         * mi/mi-console.h: Rename include guard.
9389         * mi/mi-common.h: Rename include guard.
9390         * mi/mi-cmds.h: Rename include guard.
9391         * mi/mi-cmd-break.h: Rename include guard.
9392         * m2-lang.h: Add include guard.
9393         * location.h: Rename include guard.
9394         * linux-record.h: Rename include guard.
9395         * linux-nat.h: Add include guard.
9396         * linux-fork.h: Add include guard.
9397         * i386-darwin-tdep.h: Rename include guard.
9398         * hppa-linux-offsets.h: Add include guard.
9399         * guile/guile.h: Rename include guard.
9400         * guile/guile-internal.h: Rename include guard.
9401         * gnu-nat.h: Rename include guard.
9402         * gdb-stabs.h: Rename include guard.
9403         * frv-tdep.h: Add include guard.
9404         * f-lang.h: Add include guard.
9405         * event-loop.h: Add include guard.
9406         * darwin-nat.h: Rename include guard.
9407         * cp-abi.h: Rename include guard.
9408         * config/sparc/nm-sol2.h: Rename include guard.
9409         * config/nm-nto.h: Rename include guard.
9410         * config/nm-linux.h: Add include guard.
9411         * config/i386/nm-i386gnu.h: Rename include guard.
9412         * config/djgpp/nl_types.h: Rename include guard.
9413         * config/djgpp/langinfo.h: Rename include guard.
9414         * compile/gcc-cp-plugin.h: Add include guard.
9415         * compile/gcc-c-plugin.h: Add include guard.
9416         * compile/compile.h: Rename include guard.
9417         * compile/compile-object-run.h: Rename include guard.
9418         * compile/compile-object-load.h: Rename include guard.
9419         * compile/compile-internal.h: Rename include guard.
9420         * compile/compile-cplus.h: Rename include guard.
9421         * compile/compile-c.h: Rename include guard.
9422         * common/xml-utils.h: Rename include guard.
9423         * common/x86-xstate.h: Rename include guard.
9424         * common/version.h: Rename include guard.
9425         * common/vec.h: Rename include guard.
9426         * common/tdesc.h: Rename include guard.
9427         * common/selftest.h: Rename include guard.
9428         * common/scoped_restore.h: Rename include guard.
9429         * common/scoped_mmap.h: Rename include guard.
9430         * common/scoped_fd.h: Rename include guard.
9431         * common/safe-iterator.h: Rename include guard.
9432         * common/run-time-clock.h: Rename include guard.
9433         * common/refcounted-object.h: Rename include guard.
9434         * common/queue.h: Rename include guard.
9435         * common/ptid.h: Rename include guard.
9436         * common/print-utils.h: Rename include guard.
9437         * common/preprocessor.h: Rename include guard.
9438         * common/pathstuff.h: Rename include guard.
9439         * common/observable.h: Rename include guard.
9440         * common/netstuff.h: Rename include guard.
9441         * common/job-control.h: Rename include guard.
9442         * common/host-defs.h: Rename include guard.
9443         * common/gdb_wait.h: Rename include guard.
9444         * common/gdb_vecs.h: Rename include guard.
9445         * common/gdb_unlinker.h: Rename include guard.
9446         * common/gdb_unique_ptr.h: Rename include guard.
9447         * common/gdb_tilde_expand.h: Rename include guard.
9448         * common/gdb_sys_time.h: Rename include guard.
9449         * common/gdb_string_view.h: Rename include guard.
9450         * common/gdb_splay_tree.h: Rename include guard.
9451         * common/gdb_setjmp.h: Rename include guard.
9452         * common/gdb_ref_ptr.h: Rename include guard.
9453         * common/gdb_optional.h: Rename include guard.
9454         * common/gdb_locale.h: Rename include guard.
9455         * common/gdb_assert.h: Rename include guard.
9456         * common/filtered-iterator.h: Rename include guard.
9457         * common/filestuff.h: Rename include guard.
9458         * common/fileio.h: Rename include guard.
9459         * common/environ.h: Rename include guard.
9460         * common/common-utils.h: Rename include guard.
9461         * common/common-types.h: Rename include guard.
9462         * common/common-regcache.h: Rename include guard.
9463         * common/common-inferior.h: Rename include guard.
9464         * common/common-gdbthread.h: Rename include guard.
9465         * common/common-exceptions.h: Rename include guard.
9466         * common/common-defs.h: Rename include guard.
9467         * common/common-debug.h: Rename include guard.
9468         * common/cleanups.h: Rename include guard.
9469         * common/buffer.h: Rename include guard.
9470         * common/btrace-common.h: Rename include guard.
9471         * common/break-common.h: Rename include guard.
9472         * cli/cli-utils.h: Rename include guard.
9473         * cli/cli-style.h: Rename include guard.
9474         * cli/cli-setshow.h: Rename include guard.
9475         * cli/cli-script.h: Rename include guard.
9476         * cli/cli-interp.h: Rename include guard.
9477         * cli/cli-decode.h: Rename include guard.
9478         * cli/cli-cmds.h: Rename include guard.
9479         * charset-list.h: Add include guard.
9480         * buildsym-legacy.h: Rename include guard.
9481         * bfin-tdep.h: Add include guard.
9482         * ax.h: Rename include guard.
9483         * arm-linux-tdep.h: Add include guard.
9484         * arm-fbsd-tdep.h: Add include guard.
9485         * arch/xtensa.h: Rename include guard.
9486         * arch/tic6x.h: Add include guard.
9487         * arch/i386.h: Add include guard.
9488         * arch/arm.h: Rename include guard.
9489         * arch/arm-linux.h: Rename include guard.
9490         * arch/arm-get-next-pcs.h: Rename include guard.
9491         * arch/amd64.h: Add include guard.
9492         * arch/aarch64-insn.h: Rename include guard.
9493         * arch-utils.h: Rename include guard.
9494         * annotate.h: Add include guard.
9495         * amd64-darwin-tdep.h: Rename include guard.
9496         * aarch64-linux-tdep.h: Add include guard.
9497         * aarch64-fbsd-tdep.h: Add include guard.
9498         * aarch32-linux-nat.h: Add include guard.
9499
9500 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9501
9502         * macrotab.c (macro_define_internal): New function that
9503         factorizes macro_define_object_internal and macro_define_function
9504         code.
9505         (macro_define_object_internal): Use macro_define_internal.
9506         (macro_define_function): Likewise.
9507
9508 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9509
9510         * macrocmd.c (extract_identifier): Return
9511         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9512         callers.
9513
9514 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9515
9516         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9517
9518 2019-02-05  Tom Tromey  <tom@tromey.com>
9519
9520         * target.c (target_stack::unpush): Move assertion earlier.
9521
9522 2019-01-30  Tom Tromey  <tom@tromey.com>
9523
9524         PR python/23615:
9525         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9526         (gdbpy_parse_and_eval): Likewise.
9527         * python/python-internal.h (gdbpy_allow_threads): New class.
9528
9529 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9530
9531         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9532         (aarch64_fbsd_fpregmap): Move earlier.
9533         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9534         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9535         instead of individual calls to trad_frame_set_reg_addr.
9536         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9537         earlier.
9538         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9539         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9540         instead of individual calls to trad_frame_set_reg_addr.
9541
9542 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9543
9544         * CONTRIBUTE: Replace contribution list with wiki link.
9545
9546 2019-01-25  Tom Tromey  <tom@tromey.com>
9547
9548         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9549
9550 2019-01-25  Tom Tromey  <tom@tromey.com>
9551
9552         * xtensa-linux-nat.c: Fix common/ includes.
9553         * xml-support.h: Fix common/ includes.
9554         * xml-support.c: Fix common/ includes.
9555         * x86-linux-nat.c: Fix common/ includes.
9556         * windows-nat.c: Fix common/ includes.
9557         * varobj.h: Fix common/ includes.
9558         * varobj.c: Fix common/ includes.
9559         * value.c: Fix common/ includes.
9560         * valops.c: Fix common/ includes.
9561         * utils.c: Fix common/ includes.
9562         * unittests/xml-utils-selftests.c: Fix common/ includes.
9563         * unittests/utils-selftests.c: Fix common/ includes.
9564         * unittests/unpack-selftests.c: Fix common/ includes.
9565         * unittests/tracepoint-selftests.c: Fix common/ includes.
9566         * unittests/style-selftests.c: Fix common/ includes.
9567         * unittests/string_view-selftests.c: Fix common/ includes.
9568         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9569         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9570         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9571         * unittests/rsp-low-selftests.c: Fix common/ includes.
9572         * unittests/parse-connection-spec-selftests.c: Fix common/
9573         includes.
9574         * unittests/optional-selftests.c: Fix common/ includes.
9575         * unittests/offset-type-selftests.c: Fix common/ includes.
9576         * unittests/observable-selftests.c: Fix common/ includes.
9577         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9578         * unittests/memrange-selftests.c: Fix common/ includes.
9579         * unittests/memory-map-selftests.c: Fix common/ includes.
9580         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9581         * unittests/function-view-selftests.c: Fix common/ includes.
9582         * unittests/environ-selftests.c: Fix common/ includes.
9583         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9584         * unittests/common-utils-selftests.c: Fix common/ includes.
9585         * unittests/cli-utils-selftests.c: Fix common/ includes.
9586         * unittests/array-view-selftests.c: Fix common/ includes.
9587         * ui-file.c: Fix common/ includes.
9588         * tui/tui-io.c: Fix common/ includes.
9589         * tracepoint.h: Fix common/ includes.
9590         * tracepoint.c: Fix common/ includes.
9591         * tracefile-tfile.c: Fix common/ includes.
9592         * top.h: Fix common/ includes.
9593         * top.c: Fix common/ includes.
9594         * thread.c: Fix common/ includes.
9595         * target/waitstatus.h: Fix common/ includes.
9596         * target/waitstatus.c: Fix common/ includes.
9597         * target.h: Fix common/ includes.
9598         * target.c: Fix common/ includes.
9599         * target-memory.c: Fix common/ includes.
9600         * target-descriptions.c: Fix common/ includes.
9601         * symtab.h: Fix common/ includes.
9602         * symfile.c: Fix common/ includes.
9603         * stap-probe.c: Fix common/ includes.
9604         * spu-linux-nat.c: Fix common/ includes.
9605         * sparc-nat.c: Fix common/ includes.
9606         * source.c: Fix common/ includes.
9607         * solib.c: Fix common/ includes.
9608         * solib-target.c: Fix common/ includes.
9609         * ser-unix.c: Fix common/ includes.
9610         * ser-tcp.c: Fix common/ includes.
9611         * ser-pipe.c: Fix common/ includes.
9612         * ser-base.c: Fix common/ includes.
9613         * selftest-arch.c: Fix common/ includes.
9614         * s12z-tdep.c: Fix common/ includes.
9615         * rust-exp.y: Fix common/ includes.
9616         * rs6000-aix-tdep.c: Fix common/ includes.
9617         * riscv-tdep.c: Fix common/ includes.
9618         * remote.c: Fix common/ includes.
9619         * remote-notif.h: Fix common/ includes.
9620         * remote-fileio.h: Fix common/ includes.
9621         * remote-fileio.c: Fix common/ includes.
9622         * regcache.h: Fix common/ includes.
9623         * regcache.c: Fix common/ includes.
9624         * record-btrace.c: Fix common/ includes.
9625         * python/python.c: Fix common/ includes.
9626         * python/py-type.c: Fix common/ includes.
9627         * python/py-inferior.c: Fix common/ includes.
9628         * progspace.h: Fix common/ includes.
9629         * producer.c: Fix common/ includes.
9630         * procfs.c: Fix common/ includes.
9631         * proc-api.c: Fix common/ includes.
9632         * printcmd.c: Fix common/ includes.
9633         * ppc-linux-nat.c: Fix common/ includes.
9634         * parser-defs.h: Fix common/ includes.
9635         * osdata.c: Fix common/ includes.
9636         * obsd-nat.c: Fix common/ includes.
9637         * nat/x86-linux.c: Fix common/ includes.
9638         * nat/x86-linux-dregs.c: Fix common/ includes.
9639         * nat/x86-dregs.h: Fix common/ includes.
9640         * nat/x86-dregs.c: Fix common/ includes.
9641         * nat/ppc-linux.c: Fix common/ includes.
9642         * nat/mips-linux-watch.h: Fix common/ includes.
9643         * nat/mips-linux-watch.c: Fix common/ includes.
9644         * nat/linux-waitpid.c: Fix common/ includes.
9645         * nat/linux-ptrace.h: Fix common/ includes.
9646         * nat/linux-ptrace.c: Fix common/ includes.
9647         * nat/linux-procfs.c: Fix common/ includes.
9648         * nat/linux-personality.c: Fix common/ includes.
9649         * nat/linux-osdata.c: Fix common/ includes.
9650         * nat/linux-namespaces.c: Fix common/ includes.
9651         * nat/linux-btrace.h: Fix common/ includes.
9652         * nat/linux-btrace.c: Fix common/ includes.
9653         * nat/fork-inferior.c: Fix common/ includes.
9654         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9655         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9656         * nat/aarch64-linux.c: Fix common/ includes.
9657         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9658         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9659         * namespace.h: Fix common/ includes.
9660         * mips-linux-tdep.c: Fix common/ includes.
9661         * minsyms.c: Fix common/ includes.
9662         * mi/mi-parse.h: Fix common/ includes.
9663         * mi/mi-main.c: Fix common/ includes.
9664         * mi/mi-cmd-env.c: Fix common/ includes.
9665         * memrange.h: Fix common/ includes.
9666         * memattr.c: Fix common/ includes.
9667         * maint.h: Fix common/ includes.
9668         * maint.c: Fix common/ includes.
9669         * main.c: Fix common/ includes.
9670         * machoread.c: Fix common/ includes.
9671         * location.c: Fix common/ includes.
9672         * linux-thread-db.c: Fix common/ includes.
9673         * linux-nat.c: Fix common/ includes.
9674         * linux-fork.c: Fix common/ includes.
9675         * inline-frame.c: Fix common/ includes.
9676         * infrun.c: Fix common/ includes.
9677         * inflow.c: Fix common/ includes.
9678         * inferior.h: Fix common/ includes.
9679         * inferior.c: Fix common/ includes.
9680         * infcmd.c: Fix common/ includes.
9681         * inf-ptrace.c: Fix common/ includes.
9682         * inf-child.c: Fix common/ includes.
9683         * ia64-linux-nat.c: Fix common/ includes.
9684         * i387-tdep.c: Fix common/ includes.
9685         * i386-tdep.c: Fix common/ includes.
9686         * i386-linux-tdep.c: Fix common/ includes.
9687         * i386-linux-nat.c: Fix common/ includes.
9688         * i386-go32-tdep.c: Fix common/ includes.
9689         * i386-fbsd-tdep.c: Fix common/ includes.
9690         * i386-fbsd-nat.c: Fix common/ includes.
9691         * guile/scm-type.c: Fix common/ includes.
9692         * guile/guile.c: Fix common/ includes.
9693         * go32-nat.c: Fix common/ includes.
9694         * gnu-nat.c: Fix common/ includes.
9695         * gdbthread.h: Fix common/ includes.
9696         * gdbarch-selftests.c: Fix common/ includes.
9697         * gdb_usleep.c: Fix common/ includes.
9698         * gdb_select.h: Fix common/ includes.
9699         * gdb_bfd.c: Fix common/ includes.
9700         * gcore.c: Fix common/ includes.
9701         * fork-child.c: Fix common/ includes.
9702         * findvar.c: Fix common/ includes.
9703         * fbsd-nat.c: Fix common/ includes.
9704         * event-top.c: Fix common/ includes.
9705         * event-loop.c: Fix common/ includes.
9706         * dwarf2read.c: Fix common/ includes.
9707         * dwarf2loc.c: Fix common/ includes.
9708         * dwarf2-frame.c: Fix common/ includes.
9709         * dwarf-index-cache.c: Fix common/ includes.
9710         * dtrace-probe.c: Fix common/ includes.
9711         * disasm-selftests.c: Fix common/ includes.
9712         * defs.h: Fix common/ includes.
9713         * csky-tdep.c: Fix common/ includes.
9714         * cp-valprint.c: Fix common/ includes.
9715         * cp-support.h: Fix common/ includes.
9716         * cp-support.c: Fix common/ includes.
9717         * corelow.c: Fix common/ includes.
9718         * completer.h: Fix common/ includes.
9719         * completer.c: Fix common/ includes.
9720         * compile/compile.c: Fix common/ includes.
9721         * compile/compile-loc2c.c: Fix common/ includes.
9722         * compile/compile-cplus-types.c: Fix common/ includes.
9723         * compile/compile-cplus-symbols.c: Fix common/ includes.
9724         * command.h: Fix common/ includes.
9725         * cli/cli-dump.c: Fix common/ includes.
9726         * cli/cli-cmds.c: Fix common/ includes.
9727         * charset.c: Fix common/ includes.
9728         * build-id.c: Fix common/ includes.
9729         * btrace.h: Fix common/ includes.
9730         * btrace.c: Fix common/ includes.
9731         * breakpoint.h: Fix common/ includes.
9732         * breakpoint.c: Fix common/ includes.
9733         * ax.h:
9734         (enum agent_op): Fix common/ includes.
9735         * ax-general.c (struct aop_map): Fix common/ includes.
9736         * ax-gdb.c: Fix common/ includes.
9737         * auxv.c: Fix common/ includes.
9738         * auto-load.c: Fix common/ includes.
9739         * arm-tdep.c: Fix common/ includes.
9740         * arch/riscv.c: Fix common/ includes.
9741         * arch/ppc-linux-common.c: Fix common/ includes.
9742         * arch/i386.c: Fix common/ includes.
9743         * arch/arm.c: Fix common/ includes.
9744         * arch/arm-linux.c: Fix common/ includes.
9745         * arch/arm-get-next-pcs.c: Fix common/ includes.
9746         * arch/amd64.c: Fix common/ includes.
9747         * arch/aarch64.c: Fix common/ includes.
9748         * arch/aarch64-insn.c: Fix common/ includes.
9749         * arch-utils.c: Fix common/ includes.
9750         * amd64-windows-tdep.c: Fix common/ includes.
9751         * amd64-tdep.c: Fix common/ includes.
9752         * amd64-sol2-tdep.c: Fix common/ includes.
9753         * amd64-obsd-tdep.c: Fix common/ includes.
9754         * amd64-nbsd-tdep.c: Fix common/ includes.
9755         * amd64-linux-tdep.c: Fix common/ includes.
9756         * amd64-linux-nat.c: Fix common/ includes.
9757         * amd64-fbsd-tdep.c: Fix common/ includes.
9758         * amd64-fbsd-nat.c: Fix common/ includes.
9759         * amd64-dicos-tdep.c: Fix common/ includes.
9760         * amd64-darwin-tdep.c: Fix common/ includes.
9761         * agent.c: Fix common/ includes.
9762         * ada-lang.h: Fix common/ includes.
9763         * ada-lang.c: Fix common/ includes.
9764         * aarch64-tdep.c: Fix common/ includes.
9765
9766 2019-01-25  Tom Tromey  <tom@tromey.com>
9767
9768         * common/create-version.sh: Use common/version.h.
9769
9770 2019-01-24  Pedro Alves  <palves@redhat.com>
9771
9772         * infrun.c (signal_stop, signal_print, signal_program)
9773         (signal_catch, signal_pass): Now arrays instead of pointers.
9774         (update_signals_program_target, do_target_resume)
9775         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9776         * linux-nat.c (linux_nat_target::pass_signals)
9777         (linux_nat_target::create_inferior, linux_nat_target::attach):
9778         Adjust.
9779         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9780         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9781         * procfs.c (procfs_target::pass_signals): Adjust.
9782         * record-full.c (record_full_target::resume): Adjust.
9783         * remote.c (remote_target::pass_signals)
9784         (remote_target::program_signals): Adjust.
9785         * target-debug.h (target_debug_print_signals): Now takes a
9786         gdb::array_view as parameter.  Adjust.
9787         * target.h (target_ops) <pass_signals, program_signals>: Replace
9788         pointer and length parameters with gdb::array_view.
9789         (target_pass_signals, target_program_signals): Likewise.
9790         * target-delegates.c: Regenerate.
9791
9792 2019-01-24  Pedro Alves  <palves@redhat.com>
9793
9794         * common/forward-scope-exit.h
9795         (forward_scope_exit::forward_scope_exit): Pass arguments to
9796         m_bind_function directly, instead of creating a std::bind and
9797         copying that.
9798
9799 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9800
9801         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9802         for static members.
9803         (pass_in_v_vfp_candidate): Likewise.
9804
9805 2019-01-23  Tom Tromey  <tom@tromey.com>
9806             Pedro Alves  <palves@redhat.com>
9807
9808         * regcache.c (class regcache_invalidator): Remove.
9809         (regcache::raw_write): Use make_scope_exit.
9810
9811 2019-01-23  Tom Tromey  <tom@tromey.com>
9812
9813         * ui-out.h (class ui_out_emit_type): Update comment.
9814
9815 2019-01-23  Tom Tromey  <tom@tromey.com>
9816
9817         * infrun.c (fetch_inferior_event): Update comment.
9818
9819 2019-01-23  Tom Tromey  <tom@tromey.com>
9820             Pedro Alves  <palves@redhat.com>
9821
9822         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9823         parameter.
9824         (fetch_inferior_event): Use SCOPE_EXIT.
9825
9826
9827 2019-01-23  Tom Tromey  <tom@tromey.com>
9828             Pedro Alves  <palves@redhat.com>
9829
9830         * infrun.c (disable_thread_events): Delete.
9831         (stop_all_threads): Use SCOPE_EXIT.
9832
9833 2019-01-23  Tom Tromey  <tom@tromey.com>
9834             Pedro Alves  <palves@redhat.com>
9835
9836         * symfile.c: Include forward-scope-exit.h.
9837         (clear_symtab_users_cleanup): Replace forward declaration with
9838         a FORWARD_SCOPE_EXIT.
9839         (syms_from_objfile_1): Use the forward_scope_exit and
9840         gdb::optional instead of cleanup_function.
9841         (reread_symbols): Use the forward_scope_exit instead of
9842         cleanup_function.
9843         (clear_symtab_users_cleanup): Remove function.
9844
9845 2019-01-23  Tom Tromey  <tom@tromey.com>
9846             Pedro Alves  <palves@redhat.com>
9847
9848         * linux-nat.c: Include scope-exit.h.
9849         (cleanup_target_stop): Remove.
9850         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9851         SCOPE_EXIT.
9852
9853 2019-01-23  Tom Tromey  <tom@tromey.com>
9854             Pedro Alves  <palves@redhat.com>
9855
9856         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9857         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9858
9859 2019-01-23  Tom Tromey  <tom@tromey.com>
9860             Andrew Burgess  <andrew.burgess@embecosm.com>
9861             Pedro Alves  <palves@redhat.com>
9862
9863         * infrun.c (fetch_inferior_event): Use scope_exit.
9864         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9865         * top.c (execute_command): Use scope_exit.
9866         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9867         * utils.c (do_bpstat_clear_actions_cleanup)
9868         (make_bpstat_clear_actions_cleanup): Remove.
9869
9870 2019-01-23  Tom Tromey  <tom@tromey.com>
9871             Pedro Alves  <palves@redhat.com>
9872
9873         * infrun.c: Include "common/scope-exit.h"
9874         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9875         (wait_for_inferior): Use SCOPE_EXIT.
9876         (fetch_inferior_event): Use scope_exit.
9877
9878 2019-01-23  Tom Tromey  <tom@tromey.com>
9879             Pedro Alves  <palves@redhat.com>
9880
9881         * breakpoint.c (create_breakpoint): Remove cleanup.
9882
9883 2019-01-23  Tom Tromey  <tom@tromey.com>
9884             Andrew Burgess  <andrew.burgess@embecosm.com>
9885             Pedro Alves  <palves@redhat.com>
9886
9887 2019-01-23  Pedro Alves  <palves@redhat.com>
9888
9889         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9890
9891 2019-01-23  Pedro Alves  <palves@redhat.com>
9892             Andrew Burgess  <andrew.burgess@embecosm.com>
9893
9894         * gdbthread.h: Include "common/forward-scope-exit.h".
9895         (scoped_finish_thread_state): Redefine custom class in terms of
9896         forward_scope_exit.
9897
9898 2019-01-23  Pedro Alves  <palves@redhat.com>
9899             Andrew Burgess  <andrew.burgess@embecosm.com>
9900
9901         * common/forward-scope-exit.h: New file.
9902
9903 2019-01-23  Pedro Alves  <palves@redhat.com>
9904             Andrew Burgess  <andrew.burgess@embecosm.com>
9905             Tom Tromey  <tom@tromey.com>
9906
9907         * common/scope-exit.h: New file.
9908
9909 2019-01-23  Pedro Alves  <palves@redhat.com>
9910
9911         * common/preprocessor.h (ESC): Rename to ...
9912         (ESC_PARENS): ... this.
9913         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9914         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9915
9916 2019-01-23  Tom Tromey  <tom@tromey.com>
9917
9918         * language.h (class scoped_switch_to_sym_language_if_auto):
9919         Initialize m_lang in both cases.
9920
9921 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9922
9923         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9924         with XCNEW.
9925
9926 2019-01-22  Tom Tromey  <tom@tromey.com>
9927
9928         * corelow.c: Do not include sys/file.h.
9929
9930 2019-01-22  Tom Tromey  <tom@tromey.com>
9931
9932         * tui/tui-wingeneral.h: Include gdb_curses.h.
9933
9934 2019-01-22  Tom Tromey  <tom@tromey.com>
9935
9936         * source-cache.h (class source_cache) <get_source_lines,
9937         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9938
9939 2019-01-22  Tom Tromey  <tom@tromey.com>
9940
9941         * remote-fileio.h (struct remote_target): Declare.
9942
9943 2019-01-22  Tom Tromey  <tom@tromey.com>
9944
9945         * python/py-arch.c: Do not include py-ref.h.
9946         * python/py-bpevent.c: Do not include py-ref.h.
9947         * python/py-cmd.c: Do not include py-ref.h.
9948         * python/py-continueevent.c: Do not include py-ref.h.
9949         * python/py-event.h: Do not include py-ref.h.
9950         * python/py-evtregistry.c: Do not include py-ref.h.
9951         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9952         * python/py-frame.c: Do not include py-ref.h.
9953         * python/py-framefilter.c: Do not include py-ref.h.
9954         * python/py-function.c: Do not include py-ref.h.
9955         * python/py-infevents.c: Do not include py-ref.h.
9956         * python/py-linetable.c: Do not include py-ref.h.
9957         * python/py-objfile.c: Do not include py-ref.h.
9958         * python/py-param.c: Do not include py-ref.h.
9959         * python/py-prettyprint.c: Do not include py-ref.h.
9960         * python/py-progspace.c: Do not include py-ref.h.
9961         * python/py-symbol.c: Do not include py-ref.h.
9962         * python/py-symtab.c: Do not include py-ref.h.
9963         * python/py-type.c: Do not include py-ref.h.
9964         * python/py-unwind.c: Do not include py-ref.h.
9965         * python/py-utils.c: Do not include py-ref.h.
9966         * python/py-value.c: Do not include py-ref.h.
9967         * python/py-varobj.c: Do not include py-ref.h.
9968         * python/py-xmethods.c: Do not include py-ref.h.
9969         * python/python.c: Do not include py-ref.h.
9970         * varobj.c: Do not include py-ref.h.
9971
9972 2019-01-22  Tom Tromey  <tom@tromey.com>
9973
9974         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9975         keyword for bcache.
9976
9977 2019-01-22  Tom Tromey  <tom@tromey.com>
9978
9979         * compile/compile-cplus-types.c: Remove a comment by #include.
9980
9981 2019-01-22  Tom Tromey  <tom@tromey.com>
9982
9983         * compile/gcc-c-plugin.h: Include compile-internal.h.
9984
9985 2019-01-22  Tom Tromey  <tom@tromey.com>
9986
9987         * stabsread.c (EXTERN): Do not define.
9988         (symnum, next_symbol_text_func, processing_gcc_compilation)
9989         (within_function, global_sym_chain, global_stabs)
9990         (previous_stab_code, this_object_header_files)
9991         (n_this_object_header_files)
9992         (n_allocated_this_object_header_files): Define.
9993         * stabsread.h (EXTERN): Never define.  Use "extern".
9994
9995 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9996
9997         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9998         history_value.
9999
10000 2019-01-21  Tom Tromey  <tom@tromey.com>
10001
10002         * ui-out.c: Fix includes.
10003         * tui/tui-source.c: Fix includes.
10004         * target.c: Fix includes.
10005         * remote.c: Fix includes.
10006         * regcache.c: Fix includes.
10007         * python/py-block.c: Fix includes.
10008         * printcmd.c: Fix includes.
10009         * or1k-tdep.c: Fix includes.
10010         * mi/mi-main.c: Fix includes.
10011         * m32r-tdep.c: Fix includes.
10012         * csky-tdep.c: Fix includes.
10013         * compile/compile-cplus-types.c: Fix includes.
10014         * cli/cli-interp.c: Fix includes.
10015
10016 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10017
10018         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10019         for padding.
10020
10021 2019-01-16  Tom Tromey  <tom@tromey.com>
10022
10023         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10024         earlier.
10025         (struct objfile) <msymbols_range>: Move from top level.
10026         <msymbols>: New method.
10027         (class objfile_msymbols): Remove.
10028         * symtab.c (default_collect_symbol_completion_matches_break_on):
10029         Update.
10030         * symmisc.c (dump_msymbols): Update.
10031         * stabsread.c (scan_file_globals): Update.
10032         * objc-lang.c (info_selectors_command, info_classes_command)
10033         (find_methods): Update.
10034         * minsyms.c (find_solib_trampoline_target): Update.
10035         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10036         * coffread.c (coff_symfile_read): Update.
10037         * ada-lang.c (ada_lookup_simple_minsym)
10038         (ada_collect_symbol_completion_matches): Update.
10039
10040 2019-01-16  Tom Tromey  <tom@tromey.com>
10041
10042         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10043         type.  Remove no-argument constructor.
10044         <iterator::operator++>: Simplify.
10045         <begin>: Update.
10046         <end>: Use minimal_symbol_count.
10047
10048 2019-01-16  Tom Tromey  <tom@tromey.com>
10049
10050         * objfiles.h (struct objfile) <psymtabs>: New method.
10051         (class objfile_psymtabs): Remove.
10052         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10053         typedef.
10054         <range>: New method.
10055         (require_partial_symbols): Change return type.
10056         * psymtab.c (require_partial_symbols)
10057         (psym_expand_symtabs_matching): Update.
10058         * mdebugread.c (parse_partial_symbols): Update.
10059         * dbxread.c (dbx_end_psymtab): Update.
10060
10061 2019-01-15  Tom Tromey  <tom@tromey.com>
10062
10063         * symtab.c (lookup_objfile_from_block)
10064         (lookup_symbol_in_objfile_symtabs)
10065         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10066         (find_line_symtab, info_sources_command)
10067         (default_collect_symbol_completion_matches_break_on)
10068         (make_source_files_completion_list): Update.
10069         * symmisc.c (print_objfile_statistics, dump_objfile)
10070         (maintenance_print_symbols, maintenance_info_symtabs)
10071         (maintenance_check_symtabs, maintenance_info_line_tables):
10072         Update.
10073         * source.c (select_source_symtab)
10074         (forget_cached_source_info_for_objfile): Update.
10075         * objfiles.h (class objfile_compunits): Remove.
10076         (struct objfile) <compunits_range>: New typedef.
10077         (compunits): New method.
10078         * objfiles.c (objfile_relocate1): Update.
10079         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10080         * maint.c (count_symtabs_and_blocks): Update.
10081         * linespec.c (iterate_over_all_matching_symtabs): Update.
10082         * cp-support.c (add_symbol_overload_list_qualified): Update.
10083         * coffread.c (coff_symtab_read): Update.
10084         * ada-lang.c (add_nonlocal_symbols)
10085         (ada_collect_symbol_completion_matches)
10086         (ada_add_global_exceptions): Update.
10087
10088 2019-01-15  Tom Tromey  <tom@tromey.com>
10089
10090         * progspace.h (program_space) <objfiles_safe_range>: New
10091         typedef.
10092         <objfiles_safe>: New method.
10093         * objfiles.h (class all_objfiles_safe): Remove.
10094         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10095         * jit.c (jit_inferior_exit_hook): Update.
10096
10097 2019-01-17  Tom Tromey  <tom@tromey.com>
10098
10099         * progspace.h (program_space) <objfiles_range>: New typedef.
10100         <objfiles>: New method.
10101         <objfiles_head>: Rename from objfiles.
10102         (object_files): Update.
10103         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10104         * guile/scm-pretty-print.c
10105         (ppscm_find_pretty_printer_from_objfiles): Update.
10106         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10107         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10108         Update.
10109         * python/py-progspace.c (pspy_get_objfiles): Update.
10110         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10111         Update.
10112         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10113         (objfpy_lookup_objfile_by_build_id): Update.
10114         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10115         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10116         Update.
10117         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10118         (expand_symtab_containing_pc, lookup_objfile_from_block)
10119         (lookup_static_symbol, basic_lookup_transparent_type)
10120         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10121         (find_line_symtab, info_sources_command)
10122         (default_collect_symbol_completion_matches_break_on)
10123         (make_source_files_completion_list, find_main_name): Update.
10124         * symmisc.c (print_symbol_bcache_statistics)
10125         (print_objfile_statistics, maintenance_print_symbols)
10126         (maintenance_print_msymbols, maintenance_print_objfiles)
10127         (maintenance_info_symtabs, maintenance_check_symtabs)
10128         (maintenance_expand_symtabs, maintenance_info_line_tables):
10129         Update.
10130         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10131         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10132         (map_overlay_command, unmap_overlay_command)
10133         (simple_overlay_update, expand_symtabs_matching)
10134         (map_symbol_filenames): Update.
10135         * symfile-debug.c (set_debug_symfile): Update.
10136         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10137         Update.
10138         * source.c (select_source_symtab, forget_cached_source_info):
10139         Update.
10140         * solib.c (solib_read_symbols): Update.
10141         * solib-spu.c (append_ocl_sos): Update.
10142         * psymtab.c (maintenance_print_psymbols)
10143         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10144         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10145         * printcmd.c (info_symbol_command): Update.
10146         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10147         Update.
10148         * objfiles.h (class all_objfiles): Remove.
10149         * objfiles.c (have_partial_symbols, have_full_symbols)
10150         (have_minimal_symbols, qsort_cmp, update_section_map)
10151         (shared_objfile_contains_address_p)
10152         (default_iterate_over_objfiles_in_search_order): Update.
10153         * objc-lang.c (info_selectors_command, info_classes_command)
10154         (find_methods): Update.
10155         * minsyms.c (find_solib_trampoline_target): Update.
10156         * maint.c (maintenance_info_sections)
10157         (maintenance_translate_address, count_symtabs_and_blocks):
10158         Update.
10159         * main.c (captured_main_1): Update.
10160         * linux-thread-db.c (try_thread_db_load_from_pdir)
10161         (has_libpthread): Update.
10162         * linespec.c (iterate_over_all_matching_symtabs)
10163         (search_minsyms_for_name): Update.
10164         * jit.c (jit_find_objf_with_entry_addr): Update.
10165         * hppa-tdep.c (find_unwind_entry)
10166         (hppa_lookup_stub_minimal_symbol): Update.
10167         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10168         Update.
10169         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10170         (elf_gnu_ifunc_resolve_by_got): Update.
10171         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10172         * dwarf-index-write.c (save_gdb_index_command): Update.
10173         * cp-support.c (add_symbol_overload_list_qualified): Update.
10174         * breakpoint.c (create_overlay_event_breakpoint)
10175         (create_longjmp_master_breakpoint)
10176         (create_std_terminate_master_breakpoint)
10177         (create_exception_master_breakpoint): Update.
10178         * blockframe.c (find_pc_partial_function): Update.
10179         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10180         (ada_collect_symbol_completion_matches)
10181         (ada_add_global_exceptions): Update.
10182
10183 2019-01-17  Tom Tromey  <tom@tromey.com>
10184
10185         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10186         declare VEC.
10187         (solib_target_parse_libraries): Change return type.
10188         (library_list_start_segment, library_list_start_section)
10189         (library_list_end_library, library_list_start_library); Update.
10190         (solib_target_free_library_list): Remove.
10191         (solib_target_parse_libraries): Remove cleanup.  Change return
10192         type.
10193         (solib_target_current_sos): Update.
10194
10195 2019-01-17  Tom Tromey  <tromey@bapiya>
10196
10197         * valprint.c: Replace "the the" with "the".
10198         * symtab.c: Replace "the the" with "the".
10199         * solib.c: Replace "the the" with "the".
10200         * solib-dsbt.c: Replace "the the" with "the".
10201         * linespec.c: Replace "the the" with "the".
10202         * dwarf2loc.h: Replace "the the" with "the".
10203         * amd64-windows-tdep.c: Replace "the the" with "the".
10204         * aarch64-tdep.c: Replace "the the" with "the".
10205
10206 2019-01-16  Keith Seitz  <keiths@redhat.com>
10207
10208         PR gdb/23773
10209         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10210         <builder>: Rename to ..
10211         <m_builder>: ... this and make private.
10212         (dwarf2_cu::get_builder): New method.  Change all users of
10213         `builder' to use this method.
10214         (dwarf2_start_symtab): Move to ...
10215         (dwarf2_cu::start_symtab): ... here.  Update all callers
10216         (setup_type_unit_groups): Move to ...
10217         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10218         callers.
10219         (dwarf2_cu::reset_builder): New method.
10220         (process_full_compunit, process_full_type_unit): Use
10221         dwarf2_cu::reset_builder.
10222         (follow_die_offset): Record the ancestor CU if it is different
10223         from the followed DIE's CU.
10224         (follow_die_sig_1): Likewise.
10225
10226 2019-01-15  Tom Tromey  <tom@tromey.com>
10227
10228         * remote.c (class remote_state) <buf>: Now a char_vector.
10229         <buf_size>: Remove.
10230         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10231         parameter.
10232         (remote_target::getpkt_or_notif_sane_1)
10233         (remote_target::getpkt_sane)
10234         (remote_target::getpkt_or_notif_sane): Likewise.
10235         (class remote_target) <putpkt>: New overload.
10236         (remote_target::read_frame): Change type of "buf_p".  Remove
10237         sizeof_p parameter.
10238         (packet_ok): New overload.
10239         (packet_check_result): New overload.
10240         Update all uses.
10241
10242 2019-01-14  Tom Tromey  <tom@tromey.com>
10243
10244         * remote-notif.c (handle_notification, remote_notif_ack)
10245         (remote_notif_parse): Make "buf" const.
10246         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10247         const.
10248         (remote_notif_parse, remote_notif_ack, handle_notification):
10249         Likewise.
10250         * remote.c (remote_notif_stop_parse): Make "buf" const.
10251         (remote_target::remote_parse_stop_reply): Make "buf" const.
10252         (remote_notif_stop_ack): Make "buf" const.
10253
10254 2019-01-14  Tom Tromey  <tom@tromey.com>
10255
10256         * remote.c (remote_console_output): Make parameter const.
10257
10258 2019-01-14  Tom Tromey  <tom@tromey.com>
10259
10260         * target-debug.h (target_debug_print_signals): Constify.
10261         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10262         * procfs.c (procfs_target::pass_signals): Update.
10263         * linux-nat.c (linux_nat_target::pass_signals): Update.
10264         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10265         * target-delegates.c: Rebuild.
10266         * remote.c (remote_target::program_signals): Update.
10267         (remote_target::pass_signals): Update.
10268         * target.c (target_pass_signals): Constify argument.
10269         (target_program_signals): Likewise.
10270         * target.h (struct target_ops) <pass_signals, program_signals>:
10271         Constify argument.
10272         (target_pass_signals, target_program_signals): Constify argument.
10273
10274 2019-01-14  Tom Tromey  <tom@tromey.com>
10275
10276         PR tui/28819:
10277         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10278
10279 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10280
10281         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10282         field.
10283         * rs6000-tdep.c: Include reggroups.h.
10284         (IS_V_ALIAS_PSEUDOREG): Define.
10285         (rs6000_register_name): Return names for the "vX" aliases.
10286         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10287         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10288         aliases.  Call default_register_reggroup_p for all other
10289         pseudo-registers.
10290         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10291         New functions.
10292         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10293         Handle "vX" aliases.
10294         (v_alias_pseudo_register_collect): New function.
10295         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10296         (rs6000_gdbarch_init): Initialize "vX" aliases as
10297         pseudo-registers.  Restore registration of
10298         rs6000_pseudo_register_reggroup_p with
10299         set_tdesc_pseudo_register_reggroup_p.
10300
10301 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10302
10303         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10304         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10305         set_gdbarch_num_pseudo_regs.
10306
10307 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10308
10309         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10310         Remove arg prefixname, add do_set and do_show.
10311         Add member functions set_list and show_list.
10312         * cli/cli-style.c (class cli_style_option): Update accordingly.
10313         (style_set_list): Move to file scope.
10314         (style_show_list): Likewise.
10315         (set_style): Call help_list.
10316         (show_style): Call cmd_show_list.
10317         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10318         Update to use the new macro.
10319
10320 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10321
10322         * ada-lang.c (_initialize_ada_language): Expand the help text
10323         for the "catch exception" command.
10324
10325 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10326
10327         * symtab.c (matching_obj_sections): Initialize obj,
10328         declare it closer to its usage.
10329
10330 2019-01-10  Tom Tromey  <tom@tromey.com>
10331
10332         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10333         (basic_inf_threads_range): Remove.
10334         (inf_threads_range, inf_non_exited_threads_range)
10335         (safe_inf_threads_range): Use next_adapter.
10336
10337 2019-01-10  Keith Seitz  <keiths@redhat.com>
10338
10339         PR gdb/23712
10340         PR symtab/23010
10341         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10342         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10343
10344 2019-01-10  Keith Seitz  <keiths@redhat.com>
10345
10346         PR gdb/23712
10347         PR symtab/23010
10348         * dictionary.c (pending_to_vector): Remove.
10349         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10350         Remove _1 suffix, replacing functions of the same name.  Update
10351         all callers.
10352         (dict_create_hashed, dict_create_hashed_expandable)
10353         (dict_create_linear, dict_create_linear_expandable, dict_free)
10354         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10355         Make functions static.
10356
10357 2019-01-10  Keith Seitz  <keiths@redhat.com>
10358
10359         PR gdb/23712
10360         PR symtab/23010
10361         * dictionary.h (struct dictionary): Replace declaration with
10362         multidictionary.
10363         (dict_create_hashed, dict_create_hashed_expandable)
10364         (dict_create_linear, dict_create_linear_expandable)
10365         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10366         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10367         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10368         taking multidictionary argument.
10369         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10370         * block.h (struct block) <dict>: Change to multidictionary
10371         and rename `multidict'.
10372         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10373         symmisc.c: Update all dictionary references to multidictionary.
10374
10375 2019-01-10  Keith Seitz  <keiths@redhat.com>
10376
10377         PR gdb/23712
10378         PR symtab/23010
10379         * dictionary.c: Include unordered_map.
10380         (pending_to_vector): New function.
10381         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10382         Rewrite the non-"_1" functions to take vector instead
10383         of linked list.
10384         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10385         "new" _1 versions of the same name.
10386         (multidictionary): Define.
10387         (std::hash<enum language): New definition.
10388         (collate_pending_symbols_by_language, mdict_create_hashed)
10389         (mdict_create_hashed_expandable, mdict_create_linear)
10390         (mdict_create_linear_expandable, mdict_free)
10391         (find_language_dictionary, create_new_language_dictionary)
10392         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10393         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10394         (mdict_size, mdict_empty): New functions.
10395         * dictionary.h (mdict_iterator): Define.
10396
10397 2019-01-10  Pedro Alves  <palves@redhat.com>
10398
10399         * breakpoint.c (read_uploaded_action)
10400         (create_tracepoint_from_upload): Adjust to use
10401         gdb::unique_xmalloc_ptr.
10402         * ctf.c (ctf_write_uploaded_tp):
10403         (SET_ARRAY_FIELD): Use emplace_back.
10404         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10405         * tracefile-tfile.c (tfile_write_uploaded_tp):
10406         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10407         gdb::unique_xmalloc_ptr.
10408         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10409         at_string, cond_string, cmd_strings>: Replace char pointers
10410         with gdb::unique_xmalloc_ptr.
10411
10412 2019-01-10  Pedro Alves  <palves@redhat.com>
10413
10414         * solib-target.c (library_list_start_library): Don't xstrdup name.
10415
10416 2019-01-10  Pedro Alves  <palves@redhat.com>
10417
10418         * mdebugread.c (parse_partial_symbols): Use
10419         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10420
10421 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * linux-fork.c (scoped_switch_fork_info)
10424         <~scoped_switch_fork_info>: Fix incorrect variable name.
10425
10426 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10427
10428         * linux-fork.c (scoped_switch_fork_info)
10429         <scoped_switch_fork_info>: Make explicit.
10430         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10431
10432 2019-01-10  Tom Tromey  <tom@tromey.com>
10433
10434         * objfiles.h (objfile::reset_psymtabs): Update.
10435         * objfiles.c (objfile::objfile): Update.
10436         * psymtab.h (psymtab_storage::obstack): Update.
10437         (psymtab_storage::m_obstack): Use gdb::optional.
10438         (class psymtab_storage): Update comment.  Remove objfile
10439         parameter.
10440         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10441
10442 2019-01-10  Tom Tromey  <tom@tromey.com>
10443
10444         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10445         <free_psymtabs>: Now private.
10446         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10447         (allocate_psymtab): Use new method.
10448
10449 2019-01-10  Tom Tromey  <tom@tromey.com>
10450
10451         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10452         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10453         * mdebugread.c (parse_partial_symbols): Use
10454         allocate_dependencies.
10455         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10456         allocate_dependencies.
10457         (process_psymtab_comp_unit_reader)
10458         (build_type_psymtab_dependencies): Likewise.
10459         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10460
10461 2019-01-10  Tom Tromey  <tom@tromey.com>
10462
10463         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10464         PSYMBOL_SET_LANGUAGE.
10465         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10466
10467 2019-01-10  Tom Tromey  <tom@tromey.com>
10468
10469         * psymtab.h (psymtab_storage::obstack): New method.
10470         <m_obstack>: Rename from obstack; now private.
10471         * psymtab.c (psymtab_storage): Update.
10472         * dwarf2read.c (create_addrmap_from_index)
10473         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10474         Update.
10475
10476 2019-01-10  Tom Tromey  <tom@tromey.com>
10477
10478         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10479         * objfiles.h (objfile::reset_psymtabs): New method.
10480
10481 2019-01-10  Tom Tromey  <tom@tromey.com>
10482
10483         * symmisc.c (print_symbol_bcache_statistics): Update.
10484         (print_objfile_statistics): Update.
10485         * symfile.c (reread_symbols): Update.
10486         * psymtab.h (class psymtab_storage): New.
10487         * psymtab.c (psymtab_storage): New constructor.
10488         (~psymtab_storage): New destructor.
10489         (require_partial_symbols): Update.
10490         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10491         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10492         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10493         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10494         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10495         (start_psymtab_common, end_psymtab_common)
10496         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10497         (allocate_psymtab): Update.
10498         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10499         Update.
10500         (dump_psymtab_addrmap, maintenance_print_psymbols)
10501         (maintenance_check_psymtabs): Update.
10502         (class objfile_psymtabs): Move to objfiles.h.
10503         * psympriv.h (discard_psymtab): Now inline.
10504         (psymtab_discarder::psymtab_discarder): Update.
10505         (psymtab_discarder::~psymtab_discarder): Update.
10506         (ALL_OBJFILE_PSYMTABS): Rewrite.
10507         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10508         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10509         Remove fields.
10510         <partial_symtabs>: New field.
10511         (class objfile_psymtabs): Move from psymtab.h.  Update.
10512         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10513         psymbol_cache.
10514         (objfile::~objfile): Don't destroy psymbol_cache.
10515         * mdebugread.c (parse_partial_symbols): Update.
10516         * dwarf2read.c (create_addrmap_from_index)
10517         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10518         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10519         (add_partial_subprogram, dwarf2_ranges_read): Update.
10520         * dwarf-index-write.c (write_address_map)
10521         (write_one_signatured_type, recursively_write_psymbols)
10522         (class debug_names, class debug_names, write_psymtabs_to_index):
10523         Update.
10524
10525 2019-01-10  Tom Tromey  <tom@tromey.com>
10526
10527         * symtab.h (SYMBOL_SET_NAMES): Update.
10528         (symbol_set_names): Update.
10529         (MSYMBOL_SET_NAMES): Update.
10530         * symtab.c (symbol_set_names): Change argument to be an
10531         objfile_per_bfd_storage.
10532         * psymtab.c (add_psymbol_to_bcache): Update.
10533         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10534
10535 2019-01-10  Tom Tromey  <tom@tromey.com>
10536
10537         * symtab.c (create_demangled_names_hash): Change argument to be an
10538         objfile_per_bfd_storage.
10539         (symbol_set_names): Update.
10540
10541 2019-01-10  Tom Tromey  <tom@tromey.com>
10542
10543         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10544         init_psymbol_list.
10545         * psymtab.c (init_psymbol_list): Do nothing if already called.
10546         * psympriv.h (init_psymbol_list): Add comment.
10547         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10548         init_psymbol_list.
10549         * dbxread.c (dbx_symfile_read): Unconditionally call
10550         init_psymbol_list.
10551
10552 2019-01-10  Tom Tromey  <tom@tromey.com>
10553
10554         * xcoffread.c (scan_xcoff_symtab): Update.
10555         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10556         "where".
10557         * mdebugread.c (parse_partial_symbols)
10558         (handle_psymbol_enumerators): Update.
10559         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10560         * dbxread.c (read_dbx_symtab): Update.
10561         * psympriv.h (psymbol_placement): New enum.
10562         (add_psymbol_to_list): Update.
10563
10564 2019-01-10  Tom Tromey  <tom@tromey.com>
10565
10566         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10567         static_psymbols parameters.
10568         (scan_xcoff_symtab): Update.
10569         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10570         static_psymbols parameters.
10571         * psympriv.h (start_psymtab_common): Update.
10572         * mdebugread.c (parse_partial_symbols): Update.
10573         * dwarf2read.c (create_partial_symtab): Update.
10574         * dbxread.c (read_dbx_symtab): Update.
10575         (start_psymtab): Remove global_psymbols and static_psymbols
10576         parameters.
10577
10578 2019-01-10  Tom Tromey  <tom@tromey.com>
10579
10580         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10581         * psymtab.c (allocate_psymtab): Add comment.
10582         * psympriv.h (allocate_psymtab): Add comment.
10583         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10584         initializations.
10585         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10586
10587 2019-01-10  Tom Tromey  <tom@tromey.com>
10588
10589         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10590         Don't declare.
10591         * mipsread.c: Include mdebugread.h.
10592         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10593         Declare.
10594         * elfread.c: Include mdebugread.h.
10595
10596 2019-01-09  Tom Tromey  <tom@tromey.com>
10597
10598         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10599         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10600         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10601         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10602         (psym_lookup_symbol, psym_find_last_source_symtab)
10603         (psym_forget_cached_source_info, psym_print_stats)
10604         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10605         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10606         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10607         (psym_find_compunit_symtab_by_address)
10608         (maintenance_print_psymbols, maintenance_info_psymtabs)
10609         (maintenance_check_psymtabs): Use ranged for.
10610         * psymtab.h (class objfile_psymtabs): New.
10611         (require_partial_symbols): Return objfile_psymtabs.
10612         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10613
10614 2019-01-09  Tom Tromey  <tom@tromey.com>
10615
10616         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10617         (find_pc_mapped_section, list_overlays_command)
10618         (map_overlay_command, unmap_overlay_command)
10619         (simple_overlay_update): Use all_objfiles.
10620         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10621         * printcmd.c (info_symbol_command): Use all_objfiles.
10622         * objfiles.h (ALL_OBJSECTIONS): Remove.
10623         * maint.c (maintenance_translate_address): Use all_objfiles.
10624         * gcore.c (gcore_create_callback): Use all_objfiles.
10625         (objfile_find_memory_regions): Likewise.
10626
10627 2019-01-09  Tom Tromey  <tom@tromey.com>
10628
10629         * symtab.c (find_line_symtab, info_sources_command)
10630         (make_source_files_completion_list): Use objfile_compunits.
10631         * source.c (select_source_symtab): Use objfile_compunits.
10632         * objfiles.h (struct objfile): Update comment.
10633         (ALL_OBJFILES): Remove.
10634         (ALL_FILETABS): Remove.
10635         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10636         objfile_compunits.
10637
10638 2019-01-09  Tom Tromey  <tom@tromey.com>
10639
10640         * symmisc.c (print_objfile_statistics, dump_objfile)
10641         (maintenance_print_symbols): Use compunit_filetabs.
10642         * source.c (forget_cached_source_info_for_objfile): Use
10643         compunit_filetabs.
10644         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10645         (ALL_FILETABS): Use compunit_filetabs.
10646         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10647         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10648
10649 2019-01-09  Tom Tromey  <tom@tromey.com>
10650
10651         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10652         (compunit_filetabs): New.
10653         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10654         compunit_filetabs.
10655         (info_sources_command, make_source_files_completion_list): Remove
10656         declaration.
10657         * symmisc.c (print_objfile_statistics, dump_objfile)
10658         (maintenance_print_symbols): Remove declaration.
10659         (maintenance_info_symtabs): Use compunit_filetabs.
10660         (maintenance_info_line_tables): Likewise.
10661         * source.c (select_source_symtab): Change local variable name.
10662         (forget_cached_source_info_for_objfile): Remove declaration.
10663         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10664         * objfiles.c (objfile_relocate1): Remove declaration.
10665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10666         declaration.
10667         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10668         * coffread.c (coff_symtab_read): Remove declaration.
10669         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10670         compunit_filetabs.
10671
10672 2019-01-09  Tom Tromey  <tom@tromey.com>
10673
10674         * symtab.c (lookup_objfile_from_block)
10675         (find_pc_sect_compunit_symtab, search_symbols)
10676         (default_collect_symbol_completion_matches_break_on): Use
10677         objfile_compunits.
10678         * objfiles.h (ALL_COMPUNITS): Remove.
10679         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10680         * cp-support.c (add_symbol_overload_list_qualified): Use
10681         objfile_compunits.
10682         * ada-lang.c (ada_collect_symbol_completion_matches)
10683         (ada_add_global_exceptions): Use objfile_compunits.
10684
10685 2019-01-09  Tom Tromey  <tom@tromey.com>
10686
10687         * source.c (select_source_symtab)
10688         (forget_cached_source_info_for_objfile): Remove declaration.
10689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10690         declaration.
10691         * maint.c (count_symtabs_and_blocks): Remove declaration.
10692         * cp-support.c (add_symbol_overload_list_qualified): Remove
10693         declaration.
10694         * coffread.c (coff_symtab_read): Remove declaration.
10695         * symtab.c (lookup_symbol_in_objfile_symtabs)
10696         (basic_lookup_transparent_type_1): Use objfile_compunits.
10697         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10698         (info_sources_command, search_symbols)
10699         (default_collect_symbol_completion_matches_break_on)
10700         (make_source_files_completion_list): Remove declaration.
10701         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10702         (ada_collect_symbol_completion_matches)
10703         (ada_add_global_exceptions): Remove declaration.
10704         * linespec.c (iterate_over_all_matching_symtabs): Use
10705         objfile_compunits.
10706         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10707         (class objfile_compunits): New.
10708         (ALL_COMPUNITS): Use objfile_compunits.
10709         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10710         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10711         objfile_compunits.
10712         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10713
10714 2019-01-09  Tom Tromey  <tom@tromey.com>
10715
10716         * symtab.c (search_symbols)
10717         (default_collect_symbol_completion_matches_break_on): Use
10718         objfile_msymbols.
10719         * ada-lang.c (ada_lookup_simple_minsym)
10720         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10721         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10722         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10723         objfile_msymbols.
10724         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10725         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10726         * objc-lang.c (find_methods): Use objfile_msymbols.
10727         (info_selectors_command, info_classes_command): Likewise.
10728         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10729         * objfiles.h (class objfile_msymbols): New.
10730         (ALL_OBJFILE_MSYMBOLS): Remove.
10731         (ALL_MSYMBOLS): Remove.
10732
10733 2019-01-09  Tom Tromey  <tom@tromey.com>
10734
10735         * common/next-iterator.h (next_adapter): Add Iterator template
10736         parameter.
10737         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10738         (class all_objfiles_safe): New.
10739         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10740         * objfiles.c (put_objfile_before): Update comment.
10741         (add_separate_debug_objfile): Likewise.
10742         (free_all_objfiles): Use all_objfiles_safe.
10743         (objfile_purge_solibs): Likewise.
10744
10745 2019-01-09  Tom Tromey  <tom@tromey.com>
10746
10747         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10748         (expand_symtab_containing_pc, lookup_static_symbol)
10749         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10750         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10751         all_objfiles.
10752         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10753         * breakpoint.c (create_overlay_event_breakpoint)
10754         (create_longjmp_master_breakpoint)
10755         (create_std_terminate_master_breakpoint)
10756         (create_exception_master_breakpoint): Use all_objfiles.
10757         * linux-thread-db.c (try_thread_db_load_from_pdir)
10758         (has_libpthread): Use all_objfiles.
10759         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10760         * linespec.c (iterate_over_all_matching_symtabs)
10761         (search_minsyms_for_name): Use all_objfiles.
10762         * maint.c (maintenance_info_sections): Use all_objfiles.
10763         * main.c (captured_main_1): Use all_objfiles.
10764         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10765         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10766         * guile/scm-pretty-print.c
10767         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10768         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10769         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10770         (maintenance_print_msymbols): Use all_objfiles.
10771         * source.c (select_source_symtab): Use all_objfiles.
10772         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10773         * symfile.c (remove_symbol_file_command)
10774         (expand_symtabs_matching, map_symbol_filenames): Use
10775         all_objfiles.
10776         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10777         all_objfiles.
10778         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10779         * objc-lang.c (find_methods): Use all_objfiles.
10780         * objfiles.c (have_partial_symbols, have_full_symbols)
10781         (have_minimal_symbols, qsort_cmp)
10782         (default_iterate_over_objfiles_in_search_order): Use
10783         all_objfiles.
10784         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10785         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10786         (maintenance_check_psymtabs): Use all_objfiles.
10787         (ALL_PSYMTABS): Remove.
10788         * compile/compile-object-run.c (do_module_cleanup): Use
10789         all_objfiles.
10790         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10791         * cp-support.c (add_symbol_overload_list_qualified): Use
10792         all_objfiles.
10793         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10794         Use all_objfiles.
10795         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10796         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10797         all_objfiles.
10798         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10799         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10800         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10801         Uses all_objfiles.
10802         * solib.c (solib_read_symbols): Use all_objfiles
10803
10804 2019-01-09  Tom Tromey  <tom@tromey.com>
10805
10806         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10807         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10808         all_objfiles.
10809         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10810         * symmisc.c (print_symbol_bcache_statistics)
10811         (print_objfile_statistics, maintenance_print_objfiles)
10812         (maintenance_info_symtabs, maintenance_check_symtabs)
10813         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10814         all_objfiles.
10815         * source.c (forget_cached_source_info): Use all_objfiles.
10816         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10817         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10818         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10819         * objfiles.c (update_section_map): Use all_objfiles.
10820         (shared_objfile_contains_address_p): Likewise.
10821         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10822         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10823
10824 2019-01-09  Tom Tromey  <tom@tromey.com>
10825
10826         * common/next-iterator.h: New file.
10827         * objfiles.h (class all_objfiles): New.
10828         (struct objfile_iterator): New.
10829
10830 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10831
10832         * NEWS: Move the description of the changed "frame", "select-frame",
10833          and "info frame" commands to the Changed commands section.
10834
10835 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10836
10837         * gdbtypes.c (check_stub_method_group): Remove handling of old
10838         mangling schemes.
10839         * linespec.c (find_methods): Likewise.
10840         * stabsread.c (read_member_functions): Likewise.
10841         * valops.c (search_struct_method): Likewise.
10842         (value_struct_elt_for_reference): Likewise.
10843         * NEWS: Mention this change.
10844
10845 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10846
10847         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10848         print_source_lines.
10849         * source.c (print_source_lines_base): Update line number check.
10850         (print_source_lines): New function.
10851         (source_lines_range::source_lines_range): New function.
10852         * source.h (class source_lines_range): New class.
10853         (print_source_lines): New declaration.
10854
10855 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10856
10857         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10858
10859 2019-01-08  Tom Tromey  <tom@tromey.com>
10860             Simon Marchi  <simon.marchi@ericsson.com>
10861
10862         PR gdb/24060
10863         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10864         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10865         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10866         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10867         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10868         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10869
10870 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10871
10872         * source.c (select_source_symtab): Move header comment to
10873         declaration in source.h.
10874         (forget_cached_source_info_for_objfile): Likewise.
10875         (forget_cached_source_info): Likewise.
10876         (identify_source_line): Likewise.
10877         * source.h (identify_source_line): Move declaration from symtab.h
10878         and add comment from source.c
10879         (print_source_lines): Likewise.
10880         (forget_cached_source_info_for_objfile): Likewise.
10881         (forget_cached_source_info): Likewise.
10882         (select_source_symtab): Likewise.
10883         (enum print_source_lines_flag): Move definition from symtab.h.
10884         * symtab.h (identify_source_line): Move declaration to source.h.
10885         (print_source_lines): Likewise.
10886         (forget_cached_source_info_for_objfile): Likewise.
10887         (forget_cached_source_info): Likewise.
10888         (select_source_symtab): Likewise.
10889         (enum print_source_lines_flag): Move definition to source.h.
10890         * tui/tui-hooks.c: Add 'source.h' include.
10891
10892 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10893
10894         * source.c (print_source_lines_base): Handle requests to print
10895         reverse line number sequences, and guard against empty lines
10896         string.
10897
10898 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10899
10900         * source.c (print_source_lines_base): Fix skip of '\r' if next
10901         character is '\n'.
10902
10903 2019-01-06  Tom Tromey  <tom@tromey.com>
10904
10905         * c-exp.y (struct c_parse_state) <macro_original_text,
10906         expansion_obstack>: New member.
10907         (macro_original_text, expansion_obstack): Remove globals.
10908         (scan_macro_expansion, scanning_macro_expansion)
10909         (finished_macro_expansion): Update.
10910         (scan_macro_cleanup): Remove.
10911         (yylex, c_parse): Update.
10912
10913 2019-01-06  Tom Tromey  <tom@tromey.com>
10914
10915         * c-exp.y (struct c_parse_state) <strings>: New member.
10916         (operator_stoken): Update.
10917
10918 2019-01-06  Tom Tromey  <tom@tromey.com>
10919
10920         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10921         (union type_stack_elt) <typelist_val>: Now a pointer to
10922         std::vector.
10923         (type_stack_cleanup): Don't declare.
10924         (push_typelist): Update.
10925         * parse.c (pop_typelist): Return a std::vector.
10926         (push_typelist): Take a std::vector.
10927         (follow_types): Update.  Do not free args.
10928         (type_stack_cleanup): Remove.
10929         * c-exp.y (struct c_parse_state): New.
10930         (cpstate): New global.
10931         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10932         (nonempty_typelist): Update.
10933         (func_mod): Create a new vector.
10934         (c_parse): Create a c_parse_state.
10935         (check_parameter_typelist): Do not delete params.
10936         (function_method): Update.  Do not delete type_list.
10937
10938 2019-01-06  Tom Tromey  <tom@tromey.com>
10939
10940         PR gdb/28155:
10941         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10942         check_typedef.
10943         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10944         (print_return_value): Likewise.
10945
10946 2019-01-05  Tom Tromey  <tom@tromey.com>
10947
10948         * contrib/cleanup_check.py: Remove.
10949         * contrib/gcc-with-excheck: Remove.
10950         * contrib/exsummary.py: Remove.
10951         * contrib/excheck.py: Remove.
10952
10953 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10954
10955         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10956         NULL. Initialize tpprev to NULL instead of assigning it
10957         to NULL on the next statement.
10958         * windows-nat.c (windows_delete_thread): Remove check for
10959         main_thread_id before printing thread exit notifications.
10960         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10961         Remove thread ID check against main_thread_id.
10962         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10963         windows_delete_thread.
10964         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10965
10966 2019-01-04  Tom Tromey  <tom@tromey.com>
10967
10968         * compile/compile.c (_initialize_compile): Use upper case for
10969         metasyntactic variables.
10970         * symmisc.c (_initialize_symmisc): Use upper case for
10971         metasyntactic variables.
10972         * psymtab.c (_initialize_psymtab): Use upper case for
10973         metasyntactic variables.
10974         * demangle.c (demangle_command): Use upper case for metasyntactic
10975         variables.
10976         (_initialize_demangler): Likewise.
10977         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10978         variables.
10979
10980 2019-01-03  Tom Tromey  <tom@tromey.com>
10981
10982         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10983
10984 2019-01-03  Tom Tromey  <tom@tromey.com>
10985
10986         * python/py-symtab.c (salpy_str): Update.
10987         (struct salpy_sal_object) <symtab>: Now a PyObject.
10988         (salpy_dealloc): Update.
10989         (del_objfile_sal): Use gdbpy_ref.
10990
10991 2019-01-03  Tom Tromey  <tom@tromey.com>
10992
10993         * python/py-type.c (convert_field): Use new_reference.  Return
10994         gdbpy_ref.
10995         (make_fielditem): Return gdbpy_ref.
10996         (typy_fields): Update.
10997         (typy_getitem): Update.
10998         (field_name): Return gdbpy_ref.  Use new_reference.
10999         (typy_iterator_iternext): Update.
11000
11001 2019-01-03  Tom Tromey  <tom@tromey.com>
11002
11003         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11004
11005 2019-01-03  Tom Tromey  <tom@tromey.com>
11006
11007         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11008         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11009         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11010         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11011         (pspy_set_type_printers): Likewise.
11012         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11013         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11014         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11015         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11016         (objfpy_set_type_printers): Likewise.
11017
11018 2019-01-03  Tom Tromey  <tom@tromey.com>
11019
11020         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11021         (gdbpy_print_stack): Use gdbpy_err_fetch.
11022         * python/python-internal.h (class gdbpy_err_fetch): New class.
11023         (class gdbpy_enter) <m_error_type, m_error_value,
11024         m_error_traceback>: Remove.
11025         <m_error>: New member.
11026         (gdbpy_exception_to_string): Don't declare.
11027         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11028         * python/py-value.c (convert_value_from_python): Use
11029         gdbpy_err_fetch.
11030         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11031         gdbpy_exception_to_string.
11032         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11033         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11034         gdbpy_err_fetch.
11035
11036 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11037
11038         * linux-nat.c (delete_lwp_cleanup): Delete.
11039         (struct lwp_deleter): New struct.
11040         (lwp_info_up): New typedef.
11041         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11042         lwp_info_up.
11043
11044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11045
11046         * linux-fork.c (class scoped_switch_fork_info): New class.
11047         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11048
11049 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11050
11051         * valops.c (find_overload_match): Remove use of null_cleanup, and
11052         calls to do_cleanups.
11053
11054 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11055
11056         * compile/compile-cplus-types.c
11057         (compile_cplus_instance::decl_name): Handle changes to
11058         cp_func_name.
11059         * cp-support.c (cp_func_name): Update header comment, update
11060         return type.
11061         * cp-support.h (cp_func_name): Update return type in declaration.
11062         * valops.c (find_overload_match): Move temp_func local to top
11063         level of function and change its type.  Use temp_func to hold and
11064         delete temporary string obtained from cp_func_name.
11065
11066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11067
11068         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11069         gdb::char_vector, remove cleanup, and update uses of `msg`.
11070
11071 2019-01-03  Jim Wilson  <jimw@sifive.com>
11072
11073         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11074
11075 2019-01-02  Tom Tromey  <tom@tromey.com>
11076
11077         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11078         (tdesc_parse_xml): Remove cleanups.
11079         * target-descriptions.h (make_cleanup_free_target_description):
11080         Don't declare.
11081         (target_desc_deleter): New struct.
11082         (target_desc_up): New typedef.
11083         * target-descriptions.c (target_desc_deleter::operator()): Rename
11084         from free_target_description.
11085         (make_cleanup_free_target_description): Remove.
11086
11087 2019-01-02  Tom Tromey  <tom@tromey.com>
11088
11089         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11090         constructor, destructor.
11091         (linespec_parser): Remove typedef.
11092         (~linespec_parser): Rename from linespec_parser_delete.
11093         (linespec_lex_to_end, linespec_complete_label)
11094         (linespec_complete): Update.
11095         (decode_line_full): Remove cleanups.
11096         (decode_line_1): Update.
11097
11098 2019-01-02  Tom Tromey  <tom@tromey.com>
11099
11100         * python/python-internal.h (inferior_to_inferior_object): Change
11101         return type.
11102         * python/py-exitedevent.c (create_exited_event_object): Update.
11103         * python/py-inferior.c (inferior_to_inferior_object): Return
11104         gdbpy_ref.
11105         (python_new_inferior, python_inferior_deleted)
11106         (thread_to_thread_object, delete_thread_object)
11107         (build_inferior_list, gdbpy_selected_inferior): Update.
11108         * python/py-infthread.c (create_thread_object): Update.  Also fail
11109         if inferior_to_inferior_object fails.
11110
11111 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11112
11113         * inferior.h (class inferior) <displaced_step_state>: New field.
11114         * infrun.h (struct displaced_step_state): Move here from
11115         infrun.c.  Initialize fields, add constructor.
11116         <inf>: Remove field.
11117         <reset>: New method.
11118         * infrun.c (struct displaced_step_inferior_state): Move to
11119         infrun.h.
11120         (displaced_step_inferior_states): Remove.
11121         (get_displaced_stepping_state): Adust.
11122         (displaced_step_in_progress_any_inferior): Adjust.
11123         (displaced_step_in_progress_thread): Adjust.
11124         (displaced_step_in_progress): Adjust.
11125         (add_displaced_stepping_state): Remove.
11126         (get_displaced_step_closure_by_addr): Adjust.
11127         (remove_displaced_stepping_state): Remove.
11128         (infrun_inferior_exit): Call displaced_step_state.reset.
11129         (use_displaced_stepping): Don't check for NULL.
11130         (displaced_step_prepare_throw): Call
11131         get_displaced_stepping_state.
11132         (displaced_step_fixup): Don't check for NULL.
11133         (prepare_for_detach): Don't check for NULL.
11134
11135 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11136
11137         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11138          in case of call that did not complete.
11139
11140 2019-01-02  Andrey Utkin  <autkin@undo.io>
11141
11142         * symfile.c (find_separate_debug_file): Fix search of debug files for
11143         remote debuggee.
11144
11145 2019-01-02  Tom Tromey  <tom@tromey.com>
11146
11147         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11148         indentation.
11149         * python/py-frame.c (frapy_older): Remove cast.
11150         (frapy_newer): Likewise.
11151         * python/py-breakpoint.c (local_setattro): Remove cast.
11152         * python/py-arch.c (archpy_name): Remove local variable.
11153         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11154
11155 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11156
11157         * unittests/basic_string_view/element_access/char/empty.cc:
11158         Fix year range in copyright header.
11159
11160 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11161
11162         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11163         Delete.
11164         <operator==>: Update with for removed field.
11165         <hash>: Likewise.
11166         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11167         <isa_features>: ...this.
11168         <abi_features>: New field.
11169         (riscv_isa_flen): Update comment.
11170         (riscv_abi_xlen): New declaration.
11171         (riscv_abi_flen): New declaration.
11172         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11173         isa_features.
11174         (riscv_abi_xlen): New function.
11175         (riscv_isa_flen): Update to get answer from isa_features.
11176         (riscv_abi_flen): New function.
11177         (riscv_has_fp_abi): Update to get answer from abi_features.
11178         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11179         xlen and flen.
11180         (riscv_call_info) <xlen, flen>: Update comment.
11181         (riscv_call_arg_struct): Remove invalid assertions
11182         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11183         is removed.
11184         (riscv_gdbarch_init): Gather isa features and abi features
11185         separately, ensure both match on the gdbarch when reusing an old
11186         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11187         a target with 64-bit float hardware.
11188
11189 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11190
11191         * source.c (search_command_helper): Stop reverse search
11192         when line 1 has been searched.
11193
11194 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11195
11196         * record-full.c (record_full_base_target::close): Rewrite
11197         record_full_core_buf_list free logic.
11198
11199 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11200
11201         * break-catch-syscall.c (print_one_catch_syscall): xfree
11202         the last text.
11203
11204 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11205
11206         * top.c (print_gdb_version): Update Copyright year in version
11207         message.
11208
11209 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11210
11211         Update copyright year range in all GDB files.
11212
11213 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11214
11215         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11216
11217 For older changes see ChangeLog-2018.
11218 \f
11219 Local Variables:
11220 mode: change-log
11221 left-margin: 8
11222 fill-column: 74
11223 version-control: never
11224 coding: utf-8
11225 End:
11226