gdb/ChangeLog

   1 2019-07-18  Tom Tromey  <tromey@adacore.com>
   2
   3         * symtab.c (main_name): Constify return type.
   4         * symfile.c (set_initial_language): Update.
   5         * symtab.h (main_name): Constify return type.
   6
   7 2019-07-17  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-winsource.c (tui_update_source_window)
  10         (tui_update_source_window_as_is)
  11         (tui_update_source_windows_with_line): Remove return.
  12         * tui/tui-disasm.c (tui_show_disassem)
  13         (tui_show_disassem_and_update_source): Remove return.
  14         * tui/tui.c (tui_reset): Remove return.
  15         * tui/tui-wingeneral.c
  16         (tui_check_and_display_highlight_if_needed): Remove return.
  17
  18 2019-07-17  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-winsource.h (struct tui_exec_info_window)
  25         (struct tui_source_window_base): Move from tui-data.h.
  26         * tui/tui-winsource.c: Move many method definitions from
  27         elsewhere.  Remove "structuring" comments.
  28         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  29         (tui_source_window_base::refresh_window): Move to
  30         tui-winsource.c.
  31         * tui/tui-win.c (tui_source_window_base::refresh_all)
  32         (tui_source_window_base::update_tab_width)
  33         (tui_source_window_base::set_new_height)
  34         (tui_source_window_base::do_make_visible_with_new_height): Move to
  35         tui-winsource.c.
  36         * tui/tui-source.h: Update.
  37         * tui/tui-source.c (tui_source_window_base::reset): Move to
  38         tui-winsource.c.
  39         * tui/tui-disasm.h: Update.
  40         * tui/tui-data.h (struct tui_exec_info_window): Move to
  41         tui-winsource.h.
  42         (struct tui_source_window_base): Likewise.
  43         * tui/tui-data.c (tui_source_window_base::clear_detail)
  44         (tui_source_window_base, ~tui_source_window_base): Move to
  45         tui-winsource.c.
  46
  47 2019-07-17  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-win.c (tui_resize_all)
  50         (tui_source_window_base::update_tab_width)
  51         (tui_adjust_win_heights): Update.
  52         (tui_win_info::make_invisible_and_set_new_height): Rename from
  53         make_invisible_and_set_new_height.
  54         * tui/tui-data.h (struct tui_win_info)
  55         <make_invisible_and_set_new_height>: New method.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui.c: Update.
  60         * tui/tui-source.h (struct tui_source_window): Move from
  61         tui-data.h.
  62         * tui/tui-layout.c: Update.
  63         * tui/tui-disasm.c: Update.
  64         * tui/tui-data.h (struct tui_source_window): Move to
  65         tui-source.h.
  66
  67 2019-07-17  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-disasm.h (struct tui_disasm_window): Move from
  70         tui-data.h.
  71         * tui/tui-data.h (struct tui_disasm_window): Move to
  72         tui-disasm.h.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-regs.h (struct tui_data_item_window): Move from
  77         tui-data.h.
  78         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
  79         * tui/tui-data.h (struct tui_data_item_window): Move to
  80         tui-regs.h.
  81         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
  82
  83 2019-07-17  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui.c: Update.
  86         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
  87         (tui_cmd_window::max_height): Move to tui-command.c.
  88         * tui/tui-layout.c: Update.
  89         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
  90         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
  91         tui-command.c.
  92         * tui/tui-command.h (struct tui_cmd_window): Move from
  93         tui-data.h.
  94         * tui/tui-command.c: Remove "structuring" comments.
  95         (tui_cmd_window::clear_detail)
  96         (tui_cmd_window::do_make_visible_with_new_height)
  97         (tui_cmd_window::max_height): Move from elsewhere.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 102         Now static.
 103         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 104         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 105
 106 2019-07-17  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui.c: Update.
 109         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 110         tui-regs.c.
 111         * tui/tui-windata.h: Remove file.
 112         * tui/tui-windata.c: Remove file.
 113         * tui/tui-win.c (tui_data_window::set_new_height)
 114         (tui_data_window::do_make_visible_with_new_height): Move to
 115         tui-regs.c.
 116         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 117         * tui/tui-regs.c: Remove "structuring" comments.
 118         (tui_data_window::first_data_item_displayed)
 119         (tui_data_window::delete_data_content_windows)
 120         (tui_data_window::erase_data_content)
 121         (tui_data_window::display_all_data)
 122         (tui_data_window::refresh_all)
 123         (tui_data_window::do_scroll_vertical)
 124         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 125         (tui_data_window::do_make_visible_with_new_height)
 126         (tui_data_window::refresh_window): Move from elsewhere.
 127         (_initialize_tui_regs): Move to end of file.
 128         * tui/tui-layout.c: Update.
 129         * tui/tui-hooks.c: Update.
 130         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 131         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 132         tui-regs.c.
 133         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 138         seen.
 139
 140 2019-07-17  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-win.c (tui_source_window_base::set_new_height)
 143         (tui_source_window_base::do_make_visible_with_new_height): Use
 144         m_has_locator field directly.
 145         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 146         method.
 147         (struct tui_source_window_base) <has_locator>: Likewise.
 148
 149 2019-07-17  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 152         Don't declare.
 153         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 154         Remove.
 155         * tui/tui-win.c (tui_source_window_base::set_new_height)
 156         (tui_source_window_base::set_new_height)
 157         (make_invisible_and_set_new_height)
 158         (tui_source_window_base::do_make_visible_with_new_height)
 159         (tui_source_window_base::do_make_visible_with_new_height):
 160         Update.
 161         * tui/tui-layout.c (show_source_disasm_command, show_data)
 162         (show_source_or_disasm_and_command): Update.
 163         * tui/tui-layout.c (show_layout): Update.
 164
 165 2019-07-17  Tom Tromey  <tom@tromey.com>
 166
 167         * tui/tui-layout.c (make_data_window): Remove.
 168         (show_data): Unify creation and re-initialization cases.
 169
 170 2019-07-17  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-layout.c (make_source_window, make_disasm_window):
 173         Remove.
 174         (show_data): Unify creation and re-initialization cases.
 175
 176 2019-07-17  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-layout.c (make_command_window): Remove.
 179         (show_source_disasm_command, show_source_or_disasm_and_command):
 180         Unify creation and re-initialization cases.
 181
 182 2019-07-17  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 185         creation and re-initialization cases.
 186
 187 2019-07-17  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-regs.c (tui_get_register): Return void.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 194         Simplify.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 199         resetting.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 204         * tui/tui-regs.c (tui_reg_layout): New function.
 205         (tui_show_registers, tui_reg_command): Use it.
 206         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 207         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 208         parameters.
 209         (tui_layout_command): Remove.
 210
 211 2019-07-17  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-layout.h (tui/tui-layout): Return void.
 214         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 215
 216 2019-07-17  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-layout.c (show_source_disasm_command, show_data):
 219         Update.
 220         (reset_locator): Remove.
 221         (show_source_or_disasm_and_command): Update.
 222
 223 2019-07-17  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-source.c (tui_source_window_base::reset): Remove
 226         win_type parameter.
 227         * tui/tui-layout.c (make_command_window, make_source_window)
 228         (make_disasm_window, make_data_window)
 229         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 230         (reset_locator, show_source_or_disasm_and_command): Update.
 231         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 232         win_type parameter.
 233         (struct tui_source_window_base) <reset>: Likewise.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-layout.c (show_source_disasm_command): Use
 238         reset_locator.
 239         (reset_locator): New function.
 240         (init_and_make_win): Remove.
 241         (show_source_or_disasm_and_command): Use reset_locator.
 242
 243 2019-07-17  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 246         condition.
 247         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 248         Remove condition.
 249         * tui/tui-source.c (tui_source_window_base::reset): New method.
 250         * tui/tui-layout.c (make_command_window): Don't call
 251         init_and_make_win.
 252         (make_source_window, make_disasm_window): Don't call
 253         make_source_or_disasm_window.
 254         (make_data_window): Don't call init_and_make_win.  Change calling
 255         convention.
 256         (show_source_disasm_command, show_data): Simplify.
 257         (make_source_or_disasm_window): Remove.
 258         (show_source_or_disasm_and_command): Simplify.
 259         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 260         (struct tui_source_window_base) <reset>: Likewise.
 261         <execution_info>: Remove initializer.
 262         * tui/tui-data.c (tui_source_window_base): Initialize
 263         execution_info.
 264
 265 2019-07-17  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 268         variable.
 269
 270 2019-07-17  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui.c (tui_rl_other_window): Update.
 273         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 274         superclass method first.  Always iterate over regs_content.
 275         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 276         method.
 277         * tui/tui-win.c (tui_set_focus_command): Update.
 278
 279 2019-07-17  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-win.c (tui_set_focus_command): Rename from
 282         tui_set_focus.  Call tui_enable.
 283         (tui_set_focus_command): Remove.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 288         refresh_window.
 289         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 290         touchwin.
 291         (tui_data_window::refresh_window): Call refresh_window on data
 292         items.  Always call superclass refresh_window.
 293         (tui_win_info::refresh): Remove.
 294         (tui_source_window_base::refresh_window): Update.
 295         (tui_refresh_all): Update.
 296         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 297         refresh_window.
 298         (show_source_or_disasm_and_command): Likewise.
 299         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 300         (struct tui_source_window_base) <refresh>: Likewise.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-winsource.c (tui_clear_source_content)
 305         (tui_show_source_content): Update.
 306         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 307         whether content is empty.
 308         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 309         Remove.
 310
 311 2019-07-17  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 314         window's contents.
 315         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 316         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 317
 318 2019-07-17  Tom Tromey  <tom@tromey.com>
 319
 320         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 321         (struct tui_data_item_window): Update.
 322
 323 2019-07-17  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 326         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 327         defines.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-winsource.h (tui_erase_source_content)
 332         (tui_clear_source_content): Remove "display_prompt" parameter.
 333         * tui/tui-winsource.c (tui_update_source_window_as_is)
 334         (tui_update_source_windows_with_addr): Update.
 335         (tui_clear_source_content): Remove "display_prompt" parameter.
 336         (tui_erase_source_content): Likewise.  Simplify.
 337         (tui_show_source_content): Update.
 338         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 339         * tui/tui-stack.c (tui_show_frame_info): Update.
 340         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 341         Remove defines.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 346         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 347         parameter.
 348         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 349         parameter.
 350
 351 2019-07-17  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.c (tui_clear_source_content)
 354         (tui_show_source_content, tui_show_exec_info_content)
 355         (tui_clear_exec_info_content): Update.
 356         * tui/tui-stack.c (tui_show_locator_content): Update.
 357         (tui_show_frame_info): Update.
 358         * tui/tui-source.h (tui_source_window): Don't declare.
 359         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 360         from tui_source_is_displayed.
 361         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 362         Remove field.
 363         (struct tui_source_window_base) <content_in_use>: New field.  Now
 364         bool.
 365         (struct tui_source_window) <showing_source_p>: New method.
 366         (TUI_SRC_WIN): Change cast.
 367         * tui/tui-data.c (tui_initialize_static_data): Update.
 368
 369 2019-07-17  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 372         location_matches_p.
 373         * tui/tui-source.c (tui_source_window::location_matches_p): New
 374         method.
 375         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 376         method.
 377         * tui/tui-data.h (struct tui_source_window_base)
 378         <location_matches_p>: New method.
 379         (struct tui_source_window, struct tui_disasm_window)
 380         <location_matches_p>: Likewise.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-win.c (tui_set_win_height_command): Rename from
 385         tui_set_win_height.
 386         (tui_set_win_height_command): Remove.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-source.c (tui_source_window): New constructor.  Add
 391         observer.
 392         (~tui_source_window): New destructor.
 393         (tui_source_window::style_changed): New method.
 394         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 395         (tui_attach_detach_observers): Update.
 396         * tui/tui-data.h (struct tui_source_window): Make constructor not
 397         inline.  Add destructor.
 398         (struct tui_source_window) <style_changed>: New method.
 399         <m_observable>: New member.
 400
 401 2019-07-17  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 404         * tui/tui-win.c (tui_resize_all): Fix typo.
 405
 406 2019-07-17  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 409         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 410         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 411         * tui/tui-win.c (window_name_completer): Use foreach.
 412         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 413         (update_tab_width): Likewise.
 414         * tui/tui-layout.c (show_layout): Update.
 415         * tui/tui-data.h (class tui_window_iterator): New.
 416         (struct all_tui_windows): New.
 417         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 422         parameter.  Don't reference globals.
 423         (tui_reg_command): Update.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-regs.c (tui_show_registers): Simplify.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-regs.c (tui_show_registers): Update.
 432         (tui_show_register_group): Add win_info parameter.
 433
 434 2019-07-17  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 437         Rename from tui_display_reg_element_at_line.
 438         (tui_data_window::display_registers_from_line): Update.
 439         * tui/tui-data.h (struct tui_data_window)
 440         <display_reg_element_at_line>: New method.
 441
 442 2019-07-17  Tom Tromey  <tom@tromey.com>
 443
 444         * tui/tui-regs.h (tui_display_registers_from)
 445         (tui_display_registers_from_line): Don't declare.
 446         * tui/tui-windata.c (tui_data_window::display_all_data)
 447         (tui_data_window::refresh_all)
 448         (tui_data_window::do_scroll_vertical): Update.
 449         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 450         from tui_display_registers_from.
 451         (tui_display_reg_element_at_line): Update.
 452         (tui_data_window::display_registers_from_line): Rename from
 453         tui_display_registers_from_line.
 454         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 455         display_registers_from_line>: New methods.
 456
 457 2019-07-17  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 460         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 461         from tui_erase_data_content.
 462         (tui_data_window::display_all_data)
 463         (tui_data_window::refresh_all)
 464         (tui_data_window::do_scroll_vertical): Update.
 465         * tui/tui-regs.c (tui_show_registers): Update.
 466         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 467         New method.
 468
 469 2019-07-17  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 472         declare.
 473         * tui/tui-windata.c
 474         (tui_data_window::delete_data_content_windows): Rename from
 475         tui_delete_data_content_windows.
 476         (tui_data_window::display_all_data)
 477         (tui_data_window::do_scroll_vertical): Update.
 478         * tui/tui-data.h (struct tui_data_window)
 479         <delete_data_content_windows>: New method.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 484         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 489         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 490         from tui_display_all_data.
 491         * tui/tui-win.c
 492         (tui_data_window::do_make_visible_with_new_height): Update.
 493         * tui/tui-regs.c (tui_show_registers): Update.
 494         * tui/tui-layout.c (tui_set_layout): Update.
 495         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 496         method.
 497
 498 2019-07-17  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 501         * tui/tui-windata.c (tui_display_data_from): Remove.
 502         (tui_data_window::refresh_all): Update.
 503
 504 2019-07-17  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 507         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 508         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 509         tui_display_registers_from_line.
 510         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 511         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 512         "force_display" parameter.
 513
 514 2019-07-17  Tom Tromey  <tom@tromey.com>
 515
 516         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 517         declare.
 518         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 519         Rename from tui_first_reg_element_no_inline.
 520         (tui_display_reg_element_at_line)
 521         (tui_display_registers_from_line): Update.
 522         * tui/tui-data.h (struct tui_data_window)
 523         <first_reg_element_no_inline>: New method.
 524
 525 2019-07-17  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-windata.c (tui_display_data_from)
 528         (tui_data_window::do_scroll_vertical): Update.
 529         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 530         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 531         Rename from tui_line_from_reg_element_no.
 532         (tui_display_registers_from_line): Update.
 533         * tui/tui-data.h (struct tui_data_window)
 534         <line_from_reg_element_no>: New method.
 535
 536 2019-07-17  Tom Tromey  <tom@tromey.com>
 537
 538         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 539         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 540         tui_last_regs_line_no.
 541         (tui_display_reg_element_at_line)
 542         (tui_display_registers_from_line): Update.
 543         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 544         method.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         PR tui/24722:
 549         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 550         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 551         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 552         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 553         (tui_update_breakpoint_info): Likewise.
 554         * tui/tui-hooks.c (tui_event_create_breakpoint)
 555         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 556         Update.
 557
 558 2019-07-17  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-winsource.c (tui_update_source_window_as_is)
 565         (tui_update_source_windows_with_addr): Update.
 566         * tui/tui-source.h (tui_set_source_content)
 567         (tui_show_symtab_source): Add "win_info" parameter.
 568         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 569         parameter.
 570         (tui_show_symtab_source): Likewise.
 571
 572 2019-07-17  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-wingeneral.c
 575         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 576
 577 2019-07-17  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 580         (struct tui_cmd_window) <can_scroll>: New method.
 581         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 582         method.
 583
 584 2019-07-17  Tom Tromey  <tromey@adacore.com>
 585
 586         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 587         do_field_signed>: Rename.  Change type of "value".
 588         * ui-out.c (ui_out::field_signed): Rename from field_int.
 589         Change type of "value".
 590         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 591         type of "value".
 592         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 593         do_field_int.  Change type of "value".
 594         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 595         do_field_int.  Change type of "value".
 596         * tracepoint.c (trace_status_mi, tfind_1)
 597         (print_one_static_tracepoint_marker): Update.
 598         * thread.c (print_thread_info_1, print_selected_thread_frame):
 599         Update.
 600         * stack.c (print_frame, print_frame_info): Update.
 601         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 602         Update.
 603         * source.c (print_source_lines_base): Update.
 604         * skip.c (info_skip_command): Update.
 605         * record-btrace.c (btrace_ui_out_decode_error)
 606         (btrace_call_history_src_line): Update.
 607         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 608         Update.
 609         * progspace.c (print_program_space): Update.
 610         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 611         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 612         do_field_int.  Change type of "value".
 613         * mi/mi-out.c (mi_ui_out::do_table_begin)
 614         (mi_ui_out::do_table_header): Update.
 615         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 616         type of "value".
 617         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 618         (mi_cmd_data_list_changed_registers, output_register)
 619         (mi_cmd_data_read_memory, mi_load_progress)
 620         (mi_cmd_trace_frame_collected): Update.
 621         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 622         Update.
 623         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 624         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 625         (mi_cmd_var_list_children, varobj_update_one): Update.
 626         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 627         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 628         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 629         * inferior.c (print_inferior): Update.
 630         * gdb_bfd.c (print_one_bfd): Update.
 631         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 632         Update.
 633         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 634         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 635         do_field_int.  Change type of "value".
 636         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 637         do_field_int.  Change type of "value".
 638         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 639         (print_one_breakpoint_location, print_it_catch_fork)
 640         (print_one_catch_fork, print_it_catch_vfork)
 641         (print_one_catch_vfork, print_it_catch_solib)
 642         (print_it_catch_exec, print_it_ranged_breakpoint)
 643         (print_mention_watchpoint, print_mention_masked_watchpoint)
 644         (bkpt_print_it, update_static_tracepoint): Update.
 645         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 646         * break-catch-syscall.c (print_it_catch_syscall): Update.
 647         * ada-tasks.c (print_ada_task_info): Update.
 648         * ada-lang.c (print_it_exception, print_mention_exception):
 649         Update.
 650
 651 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 652
 653         PR breakpoints/24541
 654         * gdbarch.c: Regenerate.
 655         * gdbarch.h: Regenerate.
 656         * gdbarch.sh: Adjust return type and parameter types for
 657         'stap_adjust_register'.
 658         (i386_stap_adjust_register): Adjust signature and return new
 659         register name.
 660         * stap-probe.c (stap_parse_register_operand): Adjust use of
 661         'gdbarch_stap_adjust_register'.
 662
 663 2019-07-17  Tom Tromey  <tromey@adacore.com>
 664
 665         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 666         declare VEC.
 667         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 668         std::vector.
 669         (struct s390_process_info): Add initializers.
 670         (s390_add_process): Use new.
 671         (s390_linux_nat_target::low_forget_process): Use delete.
 672         (s390_linux_nat_target::low_new_fork)
 673         (s390_linux_nat_target::stopped_by_watchpoint)
 674         (s390_linux_nat_target::low_prepare_to_resume)
 675         (s390_linux_nat_target::insert_watchpoint)
 676         (s390_linux_nat_target::insert_hw_breakpoint)
 677         (s390_linux_nat_target::remove_watchpoint)
 678         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 679
 680 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 681
 682         * aarch64-fbsd-nat.c: Include regcache.h.
 683         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 684         argument.
 685         (aarch64_fbsd_nat_target::fetch_registers)
 686         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 687         variable.
 688         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 689
 690 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 691
 692         * fbsd-nat.c: Include gdbarch.h.
 693
 694 2019-07-15  Tom Tromey  <tromey@adacore.com>
 695
 696         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 697
 698 2019-07-15  Tom Tromey  <tromey@adacore.com>
 699
 700         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 701         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 702         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 703         * cli-out.c (cli_ui_out::do_field_int): New method.
 704         * ui-out.c (ui_out::field_unsigned): New method.
 705         * symfile.c (generic_load): Use field_unsigned.
 706         (print_transfer_performance): Likewise.
 707         * record-btrace.c (ui_out_field_uint): Remove.
 708         (btrace_call_history_insn_range, btrace_call_history): Use
 709         field_unsigned.
 710         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 711         field_unsigned.
 712         * ui-out.h (class ui_out) <field_unsigned>: New method.
 713         <do_field_unsigned>: Likewise.
 714
 715 2019-07-15  Tom Tromey  <tromey@adacore.com>
 716
 717         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 718         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 719         * target.c (flash_erase_command): Use field_string.
 720         * infrun.c (print_signal_received_reason): Use field_string.
 721         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 722         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 723         field_string.
 724         * ada-tasks.c (print_ada_task_info): Use field_string.
 725
 726 2019-07-15  Tom Tromey  <tromey@adacore.com>
 727
 728         * target.c (flash_erase_command): Use field_core_addr.
 729         * symfile.c (generic_load): Use field_core_addr.
 730         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 731         Use field_core_addr.
 732         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 733         field_core_addr.
 734
 735 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 738         value if its desired type is smaller than a CORE_ADDR and signed.
 739
 740 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 743         of changes to field names, and use new is_reference field to
 744         decide if a property is a reference or not.
 745         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 746         field.
 747         (struct dwarf2_property_baton): Update header comment, rename
 748         'referenced_type' to 'property_type' and update comments.
 749         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 750         default property type, store in property baton, update to take
 751         accound of renamed field.
 752         (read_func_scope): Update call to attr_to_dynamic_prop.
 753         (read_array_type): Likewise.
 754         (dwarf2_per_cu_addr_sized_int_type): New function.
 755         (read_subrange_index_type): Move type finding code to
 756         dwarf2_per_cu_addr_sized_int_type.
 757         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 758         (dwarf2_per_cu_addr_type): New function.
 759         (set_die_type): Update calls to attr_to_dynamic_prop.
 760
 761 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * dwarf2read.c (read_subrange_index_type): New function.
 764         (read_subrange_type): Move code into new function and call it.
 765         * gdbtypes.c (create_range_type): Add some asserts.
 766
 767 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 770         update return statements.
 771         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 772         declaration, and update comment to match.
 773         * gdbtypes.c (resolve_dynamic_array): Update call to
 774         dwarf2_evaluate_property to match new return type.
 775
 776 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * valarith.c (value_subscripted_rvalue): Change lowerbound
 779         parameter type from int to LONGEST.
 780         * value.h (value_subscripted_rvalue): Likewise in declaration.
 781
 782 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 783
 784         * cli/cli-utils.c (info_print_command_completer): New function.
 785         * cli/cli-utils.h: Add 'completer.h' include, and forward
 786         declaration for 'struct cmd_list_element'.
 787         (info_print_command_completer): Declare.
 788         * stack.c (_initialize_stack): Add completer for 'info locals' and
 789         'info args'.
 790         * symtab.c (_initialize_symtab): Add completer for 'info
 791         variables' and 'info functions'.
 792         * NEWS: Mention completion for additional info commands.
 793
 794 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * cli/cli-utils.c (extract_info_print_args): Delete.
 797         (extract_arg_maybe_quoted): Delete.
 798         (info_print_options_defs): New variable.
 799         (make_info_print_options_def_group): New function.
 800         (extract_info_print_options): Define new function.
 801         * cli/cli-utils.h (extract_info_print_args): Delete.
 802         (struct info_print_options): New structure.
 803         (extract_info_print_options): Declare new function.
 804         * stack.c (info_locals_command): Update to use new
 805         extract_info_print_options, also add a header comment.
 806         (info_args_command): Likewise.
 807         * symtab.c (info_variables_command): Likewise.
 808         (info_functions_command): Likewise.
 809
 810 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 813         to extract string arguments.
 814         * common/common-utils.c (extract_string_maybe_quoted): New function.
 815         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 816
 817 2019-07-11  Tom Tromey  <tromey@adacore.com>
 818
 819         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 820         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 821         * top.h (gdbinit): Don't declare.
 822         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 823         into...
 824         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 825         * top.c (gdb_init): Don't call init_cli_cmds.
 826         (gdbinit): Remove.
 827         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 828
 829 2019-07-11  Tom Tromey  <tromey@adacore.com>
 830
 831         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 832         after it has been moved.
 833
 834 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 835
 836         * valops.c (value_must_coerce_to_target): Change return type to
 837         bool.
 838         * value.h (value_must_coerce_to_target): Likewise.
 839
 840 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 841
 842         * breakpoint.c (is_hardware_watchpoint): Remove
 843         forward-declaration.
 844         (is_masked_watchpoint): Change return type to bool.
 845         (is_tracepoint): Likewise.
 846         (is_breakpoint): Likewise.
 847         (is_hardware_watchpoint): Likewise.
 848         (is_watchpoint): Likewise.
 849         (is_no_memory_software_watchpoint): Likewise.
 850         (is_catchpoint): Likewise.
 851         (breakpoint_1): Make FILTER parameter's return type bool.
 852         is_masked_watchpoint): Change return type to bool.
 853         (save_breakpoints): Make FILTER parameter's return type bool.
 854         * breakpoint.h (is_breakpoint): Change return type to bool.
 855         (is_watchpoint): Likewise.
 856         (is_catchpoint): Likewise.
 857         (is_tracepoint): Likewise.
 858
 859 2019-07-10  Tom Tromey  <tom@tromey.com>
 860
 861         * defs.h: Don't include gdbarch.h.
 862         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 863         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 864         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 865         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 866         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 867         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 868         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 869         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 870         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 871         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 872         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 873         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 874         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 875         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 876         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 877         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 878         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 879         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 880         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 881         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 882         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 883         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 884         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 885         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 886         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 887         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 888         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 889
 890 2019-07-10  Tom Tromey  <tromey@adacore.com>
 891
 892         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 893         * breakpoint.c (init_ada_exception_breakpoint): Register as
 894         bp_catchpoint.
 895         (print_one_breakpoint_location, print_one_breakpoint): Use
 896         is_ada_exception_catchpoint.
 897         * ada-lang.c (class ada_catchpoint_location): Pass
 898         bp_loc_software_breakpoint to bp_location constructor.
 899         (is_ada_exception_catchpoint): New function.
 900
 901 2019-07-10  Tom Tromey  <tromey@adacore.com>
 902
 903         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 904         VEC.
 905         (struct arm_exidx_entry): New method operator<.
 906         (struct arm_exidx_data) <section_maps>: Change type.
 907         (arm_exidx_data_free): Remove.
 908         (arm_exidx_data_key): Change type.  Move lower.
 909         (arm_exidx_new_objfile): Update.
 910         (arm_compare_exidx_entries): Remove.
 911         (arm_find_exidx_entry, _initialize_arm_tdep)
 912
 913 2019-07-10  Tom Tromey  <tromey@adacore.com>
 914
 915         * solib-spu.c (ocl_program_data_key): Change type.
 916         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 917         Update.
 918
 919 2019-07-10  Tom Tromey  <tromey@adacore.com>
 920
 921         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 922         (struct solib_aix_inferior_data) <library_list>: Change type.
 923         (solib_aix_inferior_data_handle): Change type.
 924         (get_solib_aix_inferior_data): Update.
 925         (solib_aix_free_library_list): Remove.
 926         (library_list_start_library): Update.
 927         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 928         return type.
 929         (solib_aix_get_library_list)
 930         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 931         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 932
 933 2019-07-10  Tom Tromey  <tromey@adacore.com>
 934
 935         * solib-dsbt.c (struct dsbt_info): Add initializers.
 936         (solib_dsbt_pspace_data): Change type.
 937         (dsbt_pspace_data_cleanup): Remove.
 938         (get_dsbt_info, _initialize_dsbt_solib): Update.
 939
 940 2019-07-10  Tom Tromey  <tromey@adacore.com>
 941
 942         * spu-tdep.c (spu_overlay_data): Change type.
 943         (spu_get_overlay_table, spu_overlay_new_objfile)
 944         (_initialize_spu_tdep): Update.
 945
 946 2019-07-10  Tom Tromey  <tromey@adacore.com>
 947
 948         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 949         destructor.
 950         (dbx_objfile_data_key): Change type and declare later.
 951         (DBX_SYMFILE_INFO): Rewrite.
 952         * dbxread.c (dbx_objfile_data_key): Change type.
 953         (dbx_symfile_init): Update.
 954         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 955         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 956         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 957
 958 2019-07-10  Tom Tromey  <tromey@adacore.com>
 959
 960         * jit.c (jit_program_space_key): Change type.  Move lower.
 961         (get_jit_program_space_data): Update.
 962         (jit_program_space_data_cleanup): Remove.
 963         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 964         Update.
 965         (struct jit_program_space_data): Add initializers.
 966
 967 2019-07-10  Tom Tromey  <tromey@adacore.com>
 968
 969         * solib-darwin.c (struct darwin_info): Add initializers.
 970         (solib_darwin_pspace_data): Change type.
 971         (darwin_pspace_data_cleanup): Remove.
 972         (get_darwin_info, _initialize_darwin_solib): Update.
 973
 974 2019-07-10  Tom Tromey  <tromey@adacore.com>
 975
 976         * remote-sim.c (struct sim_inferior_data): Add initializers,
 977         constructor, and destructor.
 978         (sim_inferior_data_key): Change type.  Move lower.
 979         (check_for_duplicate_sim_descriptor): Update.
 980         (get_sim_inferior_data): Use new.  Update.
 981         (~sim_inferior_data_cleanup): Rename from
 982         sim_inferior_data_cleanup.  Simplify.
 983         (gdbsim_close_inferior, simulator_command)
 984         (sim_command_completer, _initialize_remote_sim): Update.
 985         (next_pid, INITIAL_PID): Move earlier.
 986
 987 2019-07-10  Tom Tromey  <tromey@adacore.com>
 988
 989         * python/python-internal.h (create_thread_object): Return
 990         gdbpy_ref.
 991         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 992         * python/py-inferior.c (struct threadlist_entry): Add
 993         constructor.
 994         <thread_obj>: Now a gdbpy_ref.
 995         (thread_to_thread_object): Update.
 996         (add_thread_object): Use new.
 997         (delete_thread_object): Use delete.
 998         (infpy_threads): Update.
 999         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1000         GIL.
1001
1002 2019-07-10  Tom Tromey  <tromey@adacore.com>
1003
1004         * valops.c (value_cast): Specialize error message for Ada.
1005
1006 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1007
1008         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1009
1010 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1011
1012         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1013         bpstat_should_step): Return bool, adjust comments.
1014         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1015         bpstat_should_step): Likewise.
1016
1017 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1018
1019         * features/Makefile: Use feature target descriptions for Arm.
1020         * features/arm/arm-core.c: Generate new file.
1021         * features/arm/arm-fpa.c: Likewise.
1022         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1023         * features/arm/arm-m-profile.c: Likewise.
1024         * features/arm/arm-vfpv2.c: Likewise.
1025         * features/arm/arm-vfpv3.c: Likewise.
1026         * features/arm/xscale-iwmmxt.c: Likewise.
1027         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1028
1029 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1030
1031         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1032         ptrace earlier.
1033
1034 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1035
1036         * features/aarch64-pauth.c: Regenerate.
1037
1038 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1039
1040         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1041         bool.
1042         (bpstat_what): Use false instead of 0.
1043
1044 2019-07-09  Pedro Alves  <palves@redhat.com>
1045
1046         * break-catch-throw.c (is_exception_catchpoint): New.
1047         * breakpoint.c (print_one_breakpoint_location): New parameter
1048         'raw_loc'.  Handle it.  Use
1049         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1050         looking at the breakpoint's type.
1051         (print_one_breakpoint): If handling "maint info breakpoints", also
1052         print locations of exception catchpoints.
1053         * breakpoint.h (is_exception_catchpoint): Declare.
1054
1055 2019-07-09  Pedro Alves  <palves@redhat.com>
1056
1057         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1058         "addr" field.
1059         (allocate_location_exception_catchpoint): New.
1060         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1061         (initialize_throw_catchpoint_ops): Install
1062         allocate_location_exception_catchpoint as allocate_location
1063         method.
1064         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1065         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1066         bp_loc_other.
1067         (breakpoint_address_is_meaningful): Delete.
1068         (bl_address_is_meaningful): New.
1069         (breakpoint_locations_match): Adjust comment.
1070         (bp_location_from_bp_type): New, factored out of...
1071         (bp_location::bp_location(breakpoint *)): ... this.
1072         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1073         factored out of...
1074         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1075         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1076         breakpoint_address_is_meaningful.
1077         (bp_locations_compare): Adjust comment.
1078         (update_global_location_list): Use bl_address_is_meaningful
1079         instead of breakpoint_address_is_meaningful.
1080         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1081         explicit.
1082         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1083         * python/py-breakpoint.c (bppy_get_location): No longer check
1084         whether location is null.
1085
1086 2019-07-09  Pedro Alves  <palves@redhat.com>
1087
1088         PR c++/15468
1089         * breakpoint.c (print_one_breakpoint_location): Remove
1090         single-location assert.
1091
1092 2019-07-09  Tom Tromey  <tom@tromey.com>
1093
1094         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1095         * configure: Rebuild.
1096         * configure.ac: Change common to gdbsupport.
1097         * gdbsupport: Rename from common.
1098         * acinclude.m4: Change common to gdbsupport.
1099         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1100         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1101         gdbsupport.
1102         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1103         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1104         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1105         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1106         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1107         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1108         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1109         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1110         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1111         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1112         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1113         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1114         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1115         coff-pe-read.c, command.h, compile/compile-c-support.c,
1116         compile/compile-c.h, compile/compile-cplus-symbols.c,
1117         compile/compile-cplus-types.c, compile/compile-cplus.h,
1118         compile/compile-loc2c.c, compile/compile.c, completer.c,
1119         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1120         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1121         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1122         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1123         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1124         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1125         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1126         features/aarch64-core.c, features/aarch64-fpu.c,
1127         features/aarch64-pauth.c, features/aarch64-sve.c,
1128         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1129         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1130         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1131         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1132         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1133         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1134         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1135         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1136         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1137         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1138         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1139         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1140         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1141         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1142         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1143         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1144         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1145         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1146         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1147         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1148         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1149         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1150         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1151         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1152         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1153         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1154         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1155         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1156         minsyms.c, mips-linux-tdep.c, namespace.h,
1157         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1158         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1159         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1160         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1161         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1162         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1163         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1164         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1165         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1166         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1167         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1168         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1169         procfs.c, producer.c, progspace.h, psymtab.h,
1170         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1171         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1172         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1173         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1174         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1175         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1176         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1177         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1178         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1179         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1180         target-memory.c, target.c, target.h, target/waitstatus.c,
1181         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1182         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1183         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1184         unittests/array-view-selftests.c,
1185         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1186         unittests/common-utils-selftests.c,
1187         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1188         unittests/format_pieces-selftests.c,
1189         unittests/function-view-selftests.c,
1190         unittests/lookup_name_info-selftests.c,
1191         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1192         unittests/mkdir-recursive-selftests.c,
1193         unittests/observable-selftests.c,
1194         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1195         unittests/parse-connection-spec-selftests.c,
1196         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1197         unittests/scoped_fd-selftests.c,
1198         unittests/scoped_mmap-selftests.c,
1199         unittests/scoped_restore-selftests.c,
1200         unittests/string_view-selftests.c, unittests/style-selftests.c,
1201         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1202         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1203         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1204         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1205         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1206         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1207
1208 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1211         bool value.
1212         (decode_digits_ordinary): Set explicit_line field in sal.
1213         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1214         symtab_and_line that was set on an explicit line number in
1215         assembler code.  Do always update the recorded symtab and line if
1216         we do skip the prologue.
1217
1218 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * breakpoint.c (set_breakpoint_location_function): Remove
1221         explicit_loc parameter.
1222         (momentary_breakpoint_from_master): Update call to
1223         set_breakpoint_location_function.
1224         (add_location_to_breakpoint): Likewise.
1225
1226 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1229         required features based on default bfd type when no specific bfd
1230         is present.
1231
1232 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1233
1234         * NEWS: Mention that GDB printf and eval commands can now print
1235         C-style and Ada-style convenience var strings without
1236         calling the inferior.
1237         * printcmd.c (printf_c_string): Locally print GDB internal var
1238         instead of transiting via the inferior.
1239         (printf_wide_c_string): Likewise.
1240
1241 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1242
1243         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1244
1245 2019-07-04  Tom Tromey  <tom@tromey.com>
1246
1247         PR tui/24724:
1248         * tui/tui-winsource.c (tui_clear_source_content): Update.
1249         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1250         (tui_update_breakpoint_info): Update.
1251         (tui_set_exec_info_content): Update.
1252         * tui/tui-source.c (tui_set_source_content_nil): Update.
1253         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1254         has_break.
1255         * tui/tui-data.h (enum tui_bp_flag): New.
1256         (tui_bp_flags): New enum flags type.
1257         (struct tui_source_element) <break_mode>: Change type.  Rename
1258         from has_break.
1259         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1260         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1261         constants.
1262         * tui/tui-winsource.h: Fix comment.
1263
1264 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1265
1266         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1267         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1268         (store_fpregs_to_thread)
1269         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1270         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1271         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1272         (IWMMXT_REGS_SIZE): Add define.
1273         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1274         (fetch_vfp_regs, store_vfp_regs)
1275         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1276         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1277
1278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1281         defines.
1282         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1283         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1284         (ARM_INT_REGISTER_SIZE): ...to this.
1285         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1286         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1287         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1288         (arm_linux_collect_gregset, supply_nwfpe_register)
1289         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1290         defines.
1291         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1292         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1293         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1294         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1295         (arm_return_in_memory, arm_store_return_value)
1296         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1297         (arm_record_ld_st_multiple): Likewise.
1298         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1299         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1300
1301 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1302
1303         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1304         AARCH64_DISPLACED_MODIFIED_INSNS.
1305         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1306         (aarch64_displaced_step_copy_insn): Likewise.
1307         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1308         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1309         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1310         ARM_DISPLACED_MODIFIED_INSNS.
1311         * arm-tdep.c (arm_gdbarch_init): Likewise.
1312         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1313         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1314         (struct arm_displaced_step_closure): Use
1315         ARM_DISPLACED_MODIFIED_INSNS.
1316
1317 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * features/Makefile: Remove unused xml files.
1320         * features/aarch64.xml: Remove.
1321         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1322         * features/i386/amd64-avx-avx512.xml: Remove.
1323         * features/i386/amd64-avx-linux.xml: Remove.
1324         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1325         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1326         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1327         * features/i386/amd64-avx-mpx.xml: Remove.
1328         * features/i386/amd64-avx.xml: Remove.
1329         * features/i386/amd64-linux.xml: Remove.
1330         * features/i386/amd64-mpx-linux.xml: Remove.
1331         * features/i386/amd64-mpx.xml: Remove.
1332         * features/i386/amd64.xml: Remove.
1333         * features/i386/i386-avx-avx512-linux.xml: Remove.
1334         * features/i386/i386-avx-avx512.xml: Remove.
1335         * features/i386/i386-avx-linux.xml: Remove.
1336         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1337         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1338         * features/i386/i386-avx-mpx-linux.xml: Remove.
1339         * features/i386/i386-avx-mpx.xml: Remove.
1340         * features/i386/i386-avx.xml: Remove.
1341         * features/i386/i386-linux.xml: Remove.
1342         * features/i386/i386-mmx-linux.xml: Remove.
1343         * features/i386/i386-mmx.xml: Remove.
1344         * features/i386/i386-mpx-linux.xml: Remove.
1345         * features/i386/i386-mpx.xml: Remove.
1346         * features/i386/i386.xml: Remove.
1347         * features/i386/x32-avx-avx512-linux.xml: Remove.
1348         * features/i386/x32-avx-linux.xml: Remove.
1349         * features/i386/x32-linux.xml: Remove.
1350
1351 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1352
1353         * regformats/aarch64.dat: Remove.
1354         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1355         * regformats/i386/amd64-avx-linux.dat: Remove.
1356         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1357         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1358         * regformats/i386/amd64-linux.dat: Remove.
1359         * regformats/i386/amd64-mpx-linux.dat: Remove.
1360         * regformats/i386/amd64.dat: Remove.
1361         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1362         * regformats/i386/i386-avx-linux.dat: Remove.
1363         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1364         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1365         * regformats/i386/i386-linux.dat: Remove.
1366         * regformats/i386/i386-mmx-linux.dat: Remove.
1367         * regformats/i386/i386-mpx-linux.dat: Remove.
1368         * regformats/i386/i386.dat: Remove.
1369         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1370         * regformats/i386/x32-avx-linux.dat: Remove.
1371         * regformats/i386/x32-linux.dat: Remove.
1372
1373 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1374
1375         * aarch64-tdep.c: Remove xml self tests.
1376         * amd64-linux-tdep.c: Likewise.
1377         * amd64-tdep.c: Likewise.
1378         * i386-linux-tdep.c: Likewise.
1379         * i386-tdep.c: Likewise.
1380
1381 2019-07-03  Pedro Alves  <palves@redhat.com>
1382
1383         PR cli/24732
1384         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1385         (pipe_cmd_option_defs): New.
1386         (make_pipe_cmd_options_def_group): New.
1387         (pipe_command): Use gdb::option::process_options.
1388         (pipe_command_completer): New function.
1389         (_initialize_cli_cmds): Install completer for "pipe" command.
1390
1391 2019-07-03  Pedro Alves  <palves@redhat.com>
1392
1393         * cli/cli-option.c (union option_value) <string>: New field.
1394         (struct option_def_and_value): Add ctor, move ctor, dtor and
1395         use DISABLE_COPY_AND_ASSIGN.
1396         (option_def_and_value::clear_value): New.
1397         (parse_option, save_option_value_in_ctx, get_val_type_str)
1398         (add_setshow_cmds_for_options): Handle var_string.
1399         * cli-option.h (union option_def::var_address) <string>: New
1400         field.
1401         (struct string_option_def): New.
1402         * maint-test-options.c (struct test_options_opts): Add default
1403         ctor and use DISABLE_COPY_AND_ASSIGN.
1404         <string_opt>: New field.
1405         (test_options_opts::~test_options_opts): New.
1406         (test_options_opts::dump): Also dump "-string".
1407         (test_options_option_defs): Install "string.
1408
1409 2019-07-03  Pedro Alves  <palves@redhat.com>
1410
1411         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1412         option_value with a null enumeration.
1413         (complete_options): Save the option values in the context.
1414         (save_option_value_in_ctx): New, factored out from ...
1415         (process_options): ... here.
1416         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1417         of the function.
1418         * maint-test-options.c (test_options_opts::dump): New, factored
1419         out from ...
1420         (maintenance_test_options_command_mode): ... here.
1421         (maintenance_test_options_command_completion_result): Delete.
1422         (maintenance_test_options_command_completion_text): Update
1423         comment.
1424         (maintenance_show_test_options_completion_result): Change
1425         prototype.  Just print
1426         maintenance_test_options_command_completion_text.
1427         (save_completion_result): New.
1428         (maintenance_test_options_completer_mode): Pass options context to
1429         complete_options, and then save a dump.
1430         (_initialize_maint_test_options): Use add_cmd to install "maint
1431         show test-options-completion-result".
1432
1433 2019-07-03  Pedro Alves  <palves@redhat.com>
1434
1435         * NEWS (New commands): Mention "with" and "maint with".
1436         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1437         (with_command, with_command_completer): New.
1438         (pipe_command): Adjust to new repeat_previous
1439         interface.
1440         (_initialize_cli_cmds): Install the "with" command and its "w"
1441         alias.
1442         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1443         declarations.
1444         * cli/cli-setshow.c (parse_cli_var_uinteger)
1445         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1446         argument strings for all var_types.
1447         (get_setshow_command_value_string): New, factored out from ...
1448         (do_show_command): ... this.
1449         * cli/cli-setshow.h: Include <string>.
1450         (get_setshow_command_value_string): Declare.
1451         * command.h (repeat_previous): Now returns const char *.  Adjust
1452         comment.
1453         * maint.c: Include "cli/cli-cmds.h".
1454         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1455         (_initialize_maint_cmds): Register the "maintenance with" command.
1456         * top.c (repeat_previous): Move bits from pipe_command here:
1457         Return the saved command line, if any; error out if there's no
1458         command to relaunch.
1459
1460 2019-07-03  Pedro Alves  <palves@redhat.com>
1461
1462         * NEWS (New commands): Mention "maint set/show test-settings"
1463         instead of "maint test-settings".
1464         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1465         (maintenance_test_settings_set_list): Rename to ...
1466         (maintenance_set_test_settings_list): ... this.
1467         (maintenance_test_settings_show_list): Rename to  ...
1468         (maintenance_show_test_settings_list): ... this.
1469         (maintenance_test_settings_cmd): Delete.
1470         (maintenance_test_settings_set_cmd): ...
1471         (maintenance_set_test_settings_cmd): ... this.
1472         (maintenance_test_settings_show_cmd): ...
1473         (maintenance_show_test_settings_cmd): ... this.
1474         (maintenance_test_settings_show_value_cmd):
1475         (maintenance_show_test_settings_value_cmd): ... this.
1476         (_initialize_maint_test_settings): No longer install the "maint
1477         test-settings" prefix command.  Rename "maint test-settings set"
1478         to "maint set test-settings", and "maint test-settings show" to
1479         "maint show test-settings".  Adjust all subcommands.
1480
1481 2019-07-03  Pedro Alves  <palves@redhat.com>
1482
1483         * maint-test-settings.c: Fix file's intro comment.  Replace all
1484         references to "test-options" with references to "test-settings",
1485         in comments.
1486
1487 2019-07-03  Pedro Alves  <palves@redhat.com>
1488
1489         * maint-test-settings.c (maintenance_test_settings_xxx)
1490         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1491         New.
1492         (maintenance_test_settings_enums): Use them.
1493         (maintenance_test_settings_enum): Default to
1494         maintenance_test_settings_xxx.
1495         (_initialize_maint_test_settings): Initialize
1496         MAINTENANCE_TEST_SETTINGS_FILENAME.
1497
1498 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1499
1500         * breakpoint.h (remove_breakpoints_inf): Change return type to
1501         void, move function documentation here.
1502         * breakpoint.c (remove_breakpoints_inf): Change return type to
1503         void, move function documentation to header.
1504
1505 2019-07-02  Pedro Alves  <palves@redhat.com>
1506
1507         * NEWS (Completion improvements): Mention "info threads".
1508         * thread.c (struct info_threads_opts, info_threads_option_defs)
1509         (make_info_threads_options_def_group): New.
1510         (info_threads_command): Use gdb::option::process_options.
1511         (info_threads_command_completer): New.
1512         (_initialize_thread): Use gdb::option::build_help to build the
1513         help text for "info threads".
1514
1515 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1516
1517         * defs.h (generic_load): Move from here...
1518         * symfile.h (generic_load): ... to here.  Rename name parameter
1519         to args.
1520         * symfile.c (generic_load): Add comment.
1521
1522 2019-07-01  Tom Tromey  <tromey@adacore.com>
1523
1524         * dwarf2read.c
1525         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1526         declaration of without_params.  Fix formatting.
1527
1528 2019-07-01  Tom Tromey  <tromey@adacore.com>
1529
1530         * ada-exp.y (find_primitive_type): Update.
1531         * ada-lang.h (ada_lookup_symbol): Update.
1532         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1533         parameter.
1534         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1535
1536 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1537
1538         PR breakpoints/24541
1539         * gdbarch.c: Regenerate.
1540         * gdbarch.h: Regenerate.
1541         * gdbarch.sh: Add 'stap_adjust_register'.
1542         * i386-tdep.c: Include '<unordered_set>'.
1543         (i386_stap_adjust_register): New function.
1544         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1545         * stap-probe.c (stap_parse_register_operand): Call
1546         'gdbarch_stap_adjust_register'.
1547
1548 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1549
1550         PR python/24742
1551         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1552         * python/python.c (do_start_initialization): Use 'xmalloc'
1553         instead of 'PyMem_Malloc'.
1554
1555 2019-06-28  Tom Tromey  <tromey@adacore.com>
1556
1557         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1558         for Ada.
1559
1560 2019-06-27  Tom Tromey  <tromey@adacore.com>
1561
1562         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1563         objfile_key.
1564         (arm_find_mapping_symbol, arm_record_special_symbol)
1565         (_initialize_arm_tdep): Update.
1566         (arm_objfile_data_free): Remove.
1567
1568 2019-06-27  Tom Tromey  <tromey@adacore.com>
1569
1570         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1571         to cp_print_static_field.
1572
1573 2019-06-26  Tom Tromey  <tromey@adacore.com>
1574
1575         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1576         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1577         declare.
1578
1579 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1580
1581         * features/aarch64-core.c (create_feature_aarch64_core):
1582         Regenerate.
1583         * features/aarch64-core.xml: Add cpsr flags.
1584
1585 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1588         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1589
1590 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1591
1592         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1593         field.
1594         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1595         use.
1596         (arm_record_special_symbol): Don't insert new symbol in sorted
1597         position, push it at the end.
1598
1599 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1600
1601         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1602         (arm_mapping_symbol_s): Remove.
1603         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1604         (arm_mapping_symbol_vec): New typedef.
1605         (struct arm_per_objfile): Add constructor.
1606         <section_maps>: Change type to
1607         std::unique_ptr<arm_mapping_symbol_vec[]>.
1608         (arm_compare_mapping_symbols): Remove.
1609         (arm_find_mapping_symbol): Adjust to section_maps type change.
1610         (arm_objfile_data_free): Call delete on arm_per_objfile.
1611         (arm_record_special_symbol): Adjust to section_maps type change.
1612         Allocate arm_per_objfile with new.
1613
1614 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1615
1616         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1617         with the command prefix.
1618
1619 2019-06-25  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1622         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1627         type.
1628         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1629         protected.
1630
1631 2019-06-25  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-winsource.c
1634         (tui_source_window_base::set_is_exec_point_at): Add check against
1635         LOA_ADDRESS.
1636
1637 2019-06-25  Tom Tromey  <tom@tromey.com>
1638
1639         * tui/tui-source.c (tui_set_source_content): Don't check before
1640         xfree.
1641         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1642
1643 2019-06-25  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-winsource.h (tui_update_source_window_as_is)
1646         (tui_alloc_source_buffer, tui_line_is_displayed)
1647         (tui_addr_is_displayed): Change type of win_info.
1648         * tui/tui-winsource.c (tui_update_source_window_as_is)
1649         (tui_clear_source_content, tui_show_source_line)
1650         (tui_show_source_content, tui_source_window_base::refill)
1651         (tui_source_window_base::set_is_exec_point_at)
1652         (tui_source_window_base::set_is_exec_point_at)
1653         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1654         (tui_alloc_source_buffer, tui_line_is_displayed)
1655         (tui_addr_is_displayed): Change type of win_info.  Update.
1656         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1657         (tui_source_window_base::do_make_visible_with_new_height):
1658         Update.
1659         * tui/tui-source.c (tui_set_source_content)
1660         (tui_set_source_content_nil)
1661         (tui_source_window::do_scroll_vertical): Update.
1662         * tui/tui-layout.c (show_layout): Update.
1663         * tui/tui-disasm.c (tui_set_disassem_content)
1664         (tui_disasm_window::do_scroll_vertical): Update.
1665         * tui/tui-data.h (tui_win_content): Remove.
1666         (struct tui_gen_win_info) <content, content_size>: Remove.
1667         (struct tui_source_element): Add initializers and destructor.
1668         (union tui_which_element, struct tui_win_element): Remove.
1669         (struct tui_source_window_base) <content>: New field.
1670         (struct tui_data_window): Remove destructor.
1671         (tui_alloc_content, tui_free_win_content)
1672         (tui_free_all_source_wins_content): Don't declare.
1673         * tui/tui-data.c (tui_initialize_static_data): Update.
1674         (init_content_element, tui_alloc_content): Remove.
1675         (~tui_gen_win_info): Update.
1676         (~tui_data_window, tui_free_all_source_wins_content)
1677         (tui_free_win_content, free_content, free_content_elements):
1678         Remove.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-winsource.h (tui_clear_source_content)
1683         (tui_erase_source_content, tui_show_source_content): Change type
1684         of win_info.
1685         * tui/tui-winsource.c (tui_clear_source_content)
1686         (tui_erase_source_content, tui_show_source_content): Change type
1687         of win_info.
1688         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1689         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1690         win_info.
1691         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1692         win_info.
1693         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1694
1695 2019-06-25  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-winsource.c (tui_clear_source_content)
1698         (tui_source_window_base::set_is_exec_point_at): Update.
1699         * tui/tui-source.c (tui_set_source_content_nil): Update.
1700         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1701         a bool.
1702         * tui/tui-data.c (init_content_element): Update.
1703
1704 2019-06-25  Tom Tromey  <tom@tromey.com>
1705
1706         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1707         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1708         * tui/tui-layout.c (init_and_make_win): Update.
1709         * tui/tui.h (enum tui_win_type): Update.
1710         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1711         tui_win_is_auxillary.
1712         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1713         tui_win_is_auxillary.
1714
1715 2019-06-25  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1718         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1719         (tui_delete_data_content_windows, tui_display_all_data)
1720         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1721         Update.
1722         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1723         * tui/tui-regs.c (tui_last_regs_line_no)
1724         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1725         (tui_show_registers): Update.
1726         (tui_show_register_group): Return void.  Update.
1727         (tui_display_registers_from, tui_display_reg_element_at_line)
1728         (tui_display_registers_from_line, tui_check_register_values):
1729         Update.
1730         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1731         member.
1732         (struct tui_data_window) <regs_content>: Now a std::vector.
1733         <regs_content_count>: Remove.
1734         (tui_add_content_elements, tui_free_data_content): Don't declare.
1735         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1736         (init_content_element): Remove DATA_WIN case.  Add assert.
1737         (tui_add_content_elements): Remove.
1738         (tui_data_window): Update.
1739         (tui_free_data_content): Remove.
1740         (free_content_elements): Remove DATA_WIN case.
1741
1742 2019-06-25  Tom Tromey  <tom@tromey.com>
1743
1744         * tui/tui-data.c (tui_data_item_window): Update.
1745         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1746         * tui/tui-windata.c (tui_display_all_data)
1747         (tui_display_data_from_line): Update.
1748         (tui_check_data_values): Remove.
1749         * tui/tui-regs.c (tui_show_register_group)
1750         (tui_display_reg_element_at_line): Update.
1751         * tui/tui-hooks.c (tui_register_changed)
1752         (tui_refresh_frame_and_register_information): Call
1753         tui_check_register_values.
1754         * tui/tui-data.h (struct tui_data_window) <data_content,
1755         data_content_count, data_type>: Remove.
1756         (enum tui_data_type): Remove.
1757
1758         * tui/tui-data.c (tui_data_window::clear_detail)
1759         (~tui_data_window): Update.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1764         declare.
1765         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1766         Rename from tui_first_data_item_displayed.  Update.
1767         (tui_data_window::refresh_all)
1768         (tui_data_window::do_scroll_vertical): Update.
1769         * tui/tui-data.h (struct tui_data_window)
1770         <first_data_item_displayed>: Declare new method.
1771
1772 2019-06-25  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1775         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1776         contents...
1777         (tui_initialize_static_data): ...here.
1778
1779 2019-06-25  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1782         (tui_display_registers_from, tui_check_register_values): Update.
1783         (tui_display_register): Remove win_info parameter; update.
1784         (tui_get_register): Change type of parameters.
1785         * tui/tui-data.h (struct tui_data_element): Remove.
1786         (union tui_which_element) <data>: Remove.
1787         <data_window>: Change type.
1788         (struct tui_data_item_window): New.
1789         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1790         case.  Add assert.
1791         (~tui_data_item_window): New destructor.
1792         (free_content_elements): Remove DATA_ITEM_WIN case.
1793
1794 2019-06-25  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1797         Remove.
1798
1799 2019-06-25  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-data.h (struct tui_command_element): Remove.
1802         (union tui_which_element) <command>: Remove.
1803         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1804         assert.
1805         (free_content_elements): Remove CMD_WIN case.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-layout.c (tui_set_layout): Update.
1810         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1811         * tui/tui-data.c (layout_def): Update.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1816         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1817         (tui_source_window_base::set_new_height): Update.
1818         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1819         Update.
1820         (tui_set_locator_fullname, tui_set_locator_info)
1821         (tui_show_frame_info): Update.
1822         * tui/tui-source.c (tui_set_source_content)
1823         (tui_source_is_displayed): Update.
1824         * tui/tui-layout.c (show_source_disasm_command, show_data)
1825         (show_source_or_disasm_and_command): Update.
1826         * tui/tui-disasm.c (tui_set_disassem_content)
1827         (tui_get_begin_asm_address): Update.
1828         * tui/tui-data.h (struct tui_locator_element): Remove.
1829         (union tui_which_element) <locator>: Remove.
1830         (struct tui_locator_window): New.
1831         (tui_locator_win_info_ptr): Change return type.
1832         * tui/tui-data.c (_locator): Change type.
1833         (tui_locator_win_info_ptr): Change return type.
1834         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1835         (tui_alloc_content): Add assert.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-winsource.c
1840         (tui_exec_info_window::maybe_allocate_content): New method.
1841         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1842         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1843         (make_source_or_disasm_window): Add cast.
1844         * tui/tui-data.h (union tui_which_element) <simple_string>:
1845         Remove.
1846         (struct tui_source_info): New.
1847         (struct tui_source_window_base) <execution_info>: Change type.
1848         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1849         case, and add assert.
1850         (tui_alloc_content): Add assert.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1855         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1856         * tui/tui-data.c (tui_alloc_win_info): Remove.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1861         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1862         can_highlight.
1863
1864 2019-06-25  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1867         make_visible_with_new_height method.
1868         (tui_win_info::make_visible_with_new_height): New method.
1869         (tui_source_window_base::do_make_visible_with_new_height)
1870         (tui_data_window::do_make_visible_with_new_height)
1871         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1872         (make_visible_with_new_height): Remove.
1873         (tui_resize_all, tui_adjust_win_heights): Use
1874         make_visible_with_new_height method.
1875         * tui/tui-data.h (struct tui_win_info)
1876         <do_make_visible_with_new_height, make_visible_with_new_height>:
1877         New methods.
1878         (struct tui_source_window_base, struct tui_data_window)
1879         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1880         methods.
1881
1882 2019-06-25  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1885         method.
1886         (update_tab_width): Call update_tab_width method.
1887         * tui/tui-data.h (struct tui_win_info)
1888         (struct tui_source_window_base) <update_tab_width>: New methods.
1889
1890 2019-06-25  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1893         parameter.
1894         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1895         parameter.
1896         (tui_gen_win_info::make_visible): Update.
1897         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1898         parameter.
1899         * tui/tui-data.h (enum tui_box): New enum.
1900         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1905         init_and_make_win for EXEC_INFO_WIN.
1906         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1907         longer inline.
1908         (struct tui_win_info) <~tui_win_info>: Inline.
1909         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1910         Don't declare.
1911         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1912         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1913         Remove.
1914         (tui_initialize_static_data): Update.
1915         (~tui_gen_win_info): Handle more cleanup here.
1916         (~tui_source_window_base): Delete "execution_info".
1917         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-layout.c (make_command_window): Don't set
1922         can_highlight.
1923         (show_source_disasm_command): Call the reset method.
1924         (show_data): Don't set can_highlight.  Call the reset method.
1925         (tui_gen_win_info::reset): Rename from init_gen_win_info
1926         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1927         (show_source_or_disasm_and_command): Call the reset method.
1928         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1929         (struct tui_cmd_window): Set can_highlight.
1930
1931 2019-06-25  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1934         from make_visible.
1935         (tui_make_visible, tui_make_invisible): Rewrite.
1936         (tui_win_info::make_visible): Remove.
1937         (tui_source_window_base::make_visible): Update.
1938         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1939         method.  Moved from...
1940         (struct tui_win_info) <make_visible>: ...here.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-winsource.c
1945         (tui_source_window_base::do_scroll_horizontal): Remove direction
1946         parameter.
1947         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1948         direction parameter.
1949         * tui/tui-win.c (tui_win_info::forward_scroll)
1950         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1951         (tui_win_info::right_scroll): Update.
1952         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1953         direction parameter.
1954         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1955         direction parameter.
1956         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1957         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1958         Remove direction parameter.
1959         (struct tui_source_window_base, struct tui_source_window)
1960         (struct tui_disasm_window, struct tui_data_window)
1961         (struct tui_cmd_window): Update.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.h (tui_set_exec_info_content)
1966         (tui_show_exec_info_content, tui_erase_exec_info_content)
1967         (tui_clear_exec_info_content, tui_update_exec_info): Change
1968         argument to tui_source_window_base.
1969         * tui/tui-winsource.c (tui_set_exec_info_content)
1970         (tui_show_exec_info_content, tui_erase_exec_info_content)
1971         (tui_clear_exec_info_content, tui_update_exec_info): Change
1972         argument to tui_source_window_base.
1973
1974 2019-06-25  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1977         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1978
1979 2019-06-25  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1982         check.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1987         type to void.
1988         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1989         type to void.
1990         * tui/tui-source.c (tui_set_source_content): Update.
1991         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1992
1993 2019-06-25  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-win.c (window_name_completer, tui_set_focus)
1996         (tui_all_windows_info): Use name method.
1997         * tui/tui-data.h (struct tui_gen_win_info)
1998         (struct tui_source_window, struct tui_disasm_window)
1999         (struct tui_data_window, struct tui_cmd_window) <name>: New
2000         method.
2001         (tui_win_name): Don't declare.
2002         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2003         (tui_win_name): Remove.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-winsource.h (tui_update_source_window)
2008         (tui_update_source_window_as_is): Change parameter type.
2009         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2010         to be a tui_source_window_base.
2011         (tui_update_source_window_as_is): Likewise.
2012         * tui/tui-win.c (make_visible_with_new_height): Update.
2013
2014 2019-06-25  Tom Tromey  <tom@tromey.com>
2015
2016         * tui/tui-winsource.c (tui_erase_source_content)
2017         (tui_show_source_content, tui_show_exec_info_content)
2018         (tui_erase_exec_info_content): Use refresh_window method.
2019         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2020         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2021         from tui_refresh_win.
2022         (tui_data_window::refresh_window): New method.
2023         (tui_win_info::refresh, tui_source_window_base::refresh)
2024         (tui_refresh_all): Use refresh_window method.
2025         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2026         method.
2027         * tui/tui-regs.c (tui_display_register): Call refresh_window
2028         method.
2029         * tui/tui-layout.c (show_source_disasm_command)
2030         (show_source_or_disasm_and_command): Call refresh_window method.
2031         * tui/tui-data.h (struct tui_gen_win_info)
2032         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2033         New method.
2034
2035 2019-06-25  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui.c (tui_rl_other_window, tui_enable)
2038         (tui_is_window_visible, tui_get_command_dimension): Update.
2039         * tui/tui-winsource.c (tui_update_source_window_as_is)
2040         (tui_clear_source_content, tui_erase_source_content)
2041         (tui_show_source_line, tui_source_window_base::refill)
2042         (tui_source_window_base::do_scroll_horizontal)
2043         (tui_source_window_base::set_is_exec_point_at)
2044         (tui_update_breakpoint_info, tui_set_exec_info_content)
2045         (tui_alloc_source_buffer, tui_line_is_displayed)
2046         (tui_addr_is_displayed): Update.
2047         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2048         (tui_check_and_display_highlight_if_needed)
2049         (tui_win_info::make_visible, tui_win_info::refresh)
2050         (tui_refresh_all): Update.
2051         * tui/tui-windata.c (tui_first_data_item_displayed)
2052         (tui_delete_data_content_windows, tui_erase_data_content)
2053         (tui_display_all_data, tui_data_window::refresh_all)
2054         (tui_check_data_values): Update.
2055         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2056         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2057         (tui_win_info::backward_scroll, tui_refresh_all_win)
2058         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2059         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2060         (tui_source_window_base::set_new_height)
2061         (tui_data_window::set_new_height)
2062         (make_invisible_and_set_new_height)
2063         (make_visible_with_new_height, new_height_ok)
2064         (parse_scrolling_args): Update.
2065         * tui/tui-stack.c (tui_show_frame_info): Update.
2066         * tui/tui-source.c (tui_set_source_content)
2067         (tui_set_source_content_nil, tui_source_is_displayed)
2068         (tui_source_window::do_scroll_vertical): Update.
2069         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2070         (tui_display_registers_from, tui_display_reg_element_at_line)
2071         (tui_check_register_values, tui_reg_command): Update.
2072         * tui/tui-layout.c (tui_default_win_height)
2073         (show_source_disasm_command, show_data, init_and_make_win)
2074         (show_source_or_disasm_and_command): Update.
2075         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2076         (tui_redisplay_readline, tui_mld_flush)
2077         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2078         (tui_getc): Update.
2079         * tui/tui-disasm.c (tui_set_disassem_content)
2080         (tui_disasm_window::do_scroll_vertical): Update.
2081         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2082         Now virtual.
2083         (struct tui_win_info): Derive from tui_gen_win_info.
2084         <~tui_win_info>: Mark as override.
2085         <generic>: Remove member.
2086         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2087         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2088         (~tui_data_window, ~tui_win_info)
2089         (tui_free_all_source_wins_content): Update.
2090         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2091
2092 2019-06-25  Tom Tromey  <tom@tromey.com>
2093
2094         * tui/tui-layout.c (init_and_make_win): Use new.
2095         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2096         destructor, initializers.
2097         (tui_alloc_generic_win_info): Don't declare.
2098         * tui/tui-data.c (_locator): Add argument to constructor.
2099         (source_win, disasm_win): New globals.
2100         (exec_info): Remove.
2101         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2102         Update.
2103         (tui_alloc_generic_win_info): Remove.
2104         (init_content_element): Use new.
2105         (tui_win_info::tui_win_info): Update.
2106         (free_content_elements) <case DATA_WIN>: Use delete.
2107
2108 2019-06-25  Tom Tromey  <tom@tromey.com>
2109
2110         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2111         * tui/tui-windata.c (tui_first_data_item_displayed)
2112         (tui_delete_data_content_windows): Update.
2113         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2114         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2115         (tui_display_registers_from, tui_check_register_values): Update.
2116         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2117         pointer.
2118         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2119         window.
2120         (tui_free_data_content): Update.
2121         (free_content_elements) <case DATA_WIN>: Free the window.
2122
2123 2019-06-25  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2126         Update.
2127         * tui/tui-layout.c (make_command_window)
2128         (show_source_disasm_command, show_data, init_and_make_win)
2129         (show_source_or_disasm_and_command): Update.
2130         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2131         method.
2132         <can_highight, is_highlighted>: Now bool.
2133         (tui_set_win_highlight): Don't declare.
2134         * tui/tui-data.c (tui_set_win_highlight): Remove.
2135
2136 2019-06-25  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-wingeneral.c (make_visible): Remove check of window
2139         type.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-win.c (tui_win_info::max_height)
2144         (tui_cmd_window::max_height): New methods.
2145         (new_height_ok): Call max_height.
2146         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2147         <max_height>: New method.
2148
2149 2019-06-25  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-win.c (tui_source_window_base::set_new_height)
2152         (tui_data_window::set_new_height): New methods.
2153         (make_invisible_and_set_new_height): Call set_new_height method.
2154         * tui/tui-data.h (struct tui_win_info)
2155         (struct tui_source_window_base, struct tui_data_window)
2156         <set_new_height>: New method.
2157
2158 2019-06-25  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2161         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2162         tui_refresh_data_win.
2163         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2164         method.
2165         (tui_refresh_all_win): Call the refresh_all method.
2166         (tui_set_focus): Likewise.
2167         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2168         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2169         Likewise.
2170
2171 2019-06-25  Tom Tromey  <tom@tromey.com>
2172
2173         * tui/tui-winsource.h (tui_refill_source_window)
2174         (tui_set_is_exec_point_at): Don't declare.
2175         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2176         (tui_source_window_base::refill): Rename from
2177         tui_refill_source_window.
2178         (tui_source_window_base::do_scroll_horizontal): Update.
2179         (tui_source_window_base::set_is_exec_point_at): Rename from
2180         tui_set_is_exec_point_at.
2181         (tui_update_all_breakpoint_info): Update.
2182         * tui/tui-stack.c (tui_show_frame_info): Update.
2183         * tui/tui-layout.c (show_data): Add cast.
2184         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2185         * tui/tui-data.h (struct tui_source_window_base) <refill,
2186         set_is_exec_point_at>: New methods.
2187         (tui_source_windows, tui_add_to_source_windows): Update types.
2188         (tui_add_to_source_windows): Remove redundant declaration.
2189         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2190         (tui_source_windows): Change return type.
2191         (tui_clear_source_windows_detail): Update.
2192         (tui_add_to_source_windows): Change type of parameter.
2193         (tui_free_all_source_wins_content): Update.
2194
2195 2019-06-25  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-wingeneral.c (tui_win_info::refresh)
2198         (tui_source_window_base::refresh): New methods.
2199         (tui_refresh_all): Call the refresh method.
2200         * tui/tui-data.h (struct tui_win_info)
2201         (struct tui_source_window_base) <refresh>: New method.
2202
2203 2019-06-25  Tom Tromey  <tom@tromey.com>
2204
2205         * tui/tui.h (tui_is_window_visible): Return bool.
2206         * tui/tui.c (tui_is_window_visible): Return bool.
2207         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2208         (tui_make_visible, tui_make_invisible)
2209         (tui_win_info::make_visible)
2210         (tui_source_window_base::make_visible, make_all_visible)
2211         (tui_make_all_visible, tui_make_all_invisible): Update.
2212         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2213         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2214         bool.
2215         (struct tui_win_info, struct tui_source_window_base)
2216         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2217         * tui/tui-data.c (tui_init_generic_part): Update.
2218
2219 2019-06-25  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2222         (tui_source_window_base::make_visible): New methods.
2223         (make_all_visible): Make method call.
2224         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2225         (struct tui_source_window_base, struct tui_cmd_window): Override
2226         make_visible.
2227         (tui_win_is_source_type): Don't declare.
2228         * tui/tui-data.c (tui_win_is_source_type): Remove.
2229
2230 2019-06-25  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2233         NULL check.
2234
2235 2019-06-25  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2238         Inline constructor.  Add initializers for members.
2239         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2240         constructors; now inline in class.
2241
2242 2019-06-25  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-regs.c (tui_show_registers): Update.
2245         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2246         bool.
2247         * tui/tui-data.c (tui_data_window::clear_detail)
2248         (tui_data_window): Update.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-windata.c (tui_display_all_data)
2253         (tui_display_data_from_line, tui_display_data_from)
2254         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2255         Update.
2256         * tui/tui-regs.c (tui_last_regs_line_no)
2257         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2258         (tui_show_registers, tui_show_register_group)
2259         (tui_display_registers_from, tui_display_reg_element_at_line)
2260         (tui_display_registers_from_line, tui_check_register_values)
2261         (tui_reg_next, tui_reg_prev): Update.
2262         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2263         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2264         tui_data_window.
2265         (struct tui_win_info) <detail>: Remove.  Add new fields from
2266         tui_data_info.
2267         (TUI_DATA_WIN): Add cast.
2268         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2269         (~tui_data_window): Simplify.
2270
2271 2019-06-25  Tom Tromey  <tom@tromey.com>
2272
2273         * tui/tui-layout.c (show_source_disasm_command)
2274         (show_source_or_disasm_and_command): Update.
2275         * tui/tui-io.c (update_cmdwin_start_line)
2276         (tui_redisplay_readline): Update.
2277         * tui/tui-data.h (struct tui_command_info): Remove.
2278         (struct tui_win_info) <detail>: Remove command_info member.
2279         (struct tui_data_window) <start_line>: New member, from
2280         tui_command_info.
2281         (TUI_CMD_WIN): Add casts.
2282
2283 2019-06-25  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-winsource.c (tui_update_source_window)
2286         (tui_refill_source_window)
2287         (tui_source_window_base::do_scroll_horizontal)
2288         (tui_update_breakpoint_info, tui_set_exec_info_content)
2289         (tui_show_exec_info_content, tui_erase_exec_info_content)
2290         (tui_clear_exec_info_content): Update.
2291         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2292         Update.
2293         * tui/tui-win.c (make_invisible_and_set_new_height)
2294         (make_visible_with_new_height): Update.
2295         * tui/tui-source.c (tui_set_source_content)
2296         (tui_show_symtab_source): Update.
2297         * tui/tui-layout.c (extract_display_start_addr)
2298         (show_source_disasm_command, show_data)
2299         (make_source_or_disasm_window)
2300         (show_source_or_disasm_and_command): Update.
2301         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2302         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2303         "gdbarch".
2304         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2305         to tui_source_window_base.
2306         (struct tui_win_info) <detail>: Remove source_info member.
2307         (struct tui_source_window_base) <has_locator>: Inline.
2308         Move contents from tui_source_info; rename has_locator member to
2309         m_has_locator.
2310         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2311         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2312         header file.
2313         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2314         Simplify.
2315         (tui_free_all_source_wins_content): Cast to
2316         tui_source_window_base.
2317
2318 2019-06-25  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-win.c (make_invisible_and_set_new_height)
2321         (make_visible_with_new_height): Call has_locator method.
2322         * tui/tui-layout.c (show_source_disasm_command, show_data)
2323         (show_source_or_disasm_and_command): Update for bool change.
2324         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2325         (tui_win_info) <has_locator>: New method.
2326         (struct tui_source_window_base) <has_locator>: New method.
2327         (tui_win_has_locator): Don't declare.
2328         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2329         from tui_win_has_locator.
2330         (tui_source_window_base): Use false, not FALSE.
2331
2332 2019-06-25  Tom Tromey  <tom@tromey.com>
2333
2334         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2335         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2336         clear_detail method directly.
2337         (tui_clear_win_detail): Remove.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2342         "this", not TUI_DISASM_WIN.
2343
2344 2019-06-25  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2347         declare.
2348         * tui/tui-winsource.c
2349         (tui_source_window_base::do_scroll_horizontal): Rename from
2350         tui_horizontal_source_scroll.
2351         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2352         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2353         from tui_vertical_data_scroll.
2354         * tui/tui-win.h (tui_scroll): Don't declare.
2355         * tui/tui-win.c (tui_win_info::forward_scroll)
2356         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2357         (tui_win_info::right_scroll): Rename and update.
2358         (tui_scroll_forward_command, tui_scroll_backward_command)
2359         (tui_scroll_left_command, tui_scroll_right_command): Update.
2360         (tui_scroll): Remove.
2361         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2362         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2363         from tui_vertical_source_scroll.
2364         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2365         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2366         from tui_vertical_disassem_scroll.
2367         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2368         do_scroll_horizontal>: New methods.
2369         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2370         Likewise.
2371         (struct tui_source_window_base): Add do_scroll_horizontal.
2372         (struct tui_source_window, struct tui_disasm_window): Add
2373         do_scroll_vertical.
2374         (struct tui_data_window, struct tui_cmd_window): Add
2375         do_scroll_horizontal and do_scroll_vertical.
2376         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2377
2378 2019-06-25  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-data.h (struct tui_source_window_base): New struct.
2381         (struct tui_source_window): Derive from tui_source_window_base.
2382         (struct tui_disasm_window): New struct.
2383         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2384         from tui_source_window::clear_detail.
2385         (tui_source_window_base): Rename from tui_source_window.
2386         (~tui_source_window_base): Rename from ~tui_source_window.
2387         (tui_alloc_win_info): Create a tui_disasm_window.
2388
2389 2019-06-25  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-data.h (struct tui_source_window)
2392         (struct tui_data_window): Declare destructors.
2393         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2394         destructors.
2395         (tui_win_info): Simplify.
2396
2397 2019-06-25  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui-winsource.c (tui_display_main)
2400         (tui_update_source_windows_with_addr)
2401         (tui_update_all_breakpoint_info): Update.
2402         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2403         (new_height_ok, parse_scrolling_args): Update.
2404         * tui/tui-stack.c (tui_show_frame_info): Update.
2405         * tui/tui-data.h (struct tui_list): Remove.
2406         (tui_source_windows): Return a reference to a std::vector.
2407         * tui/tui-data.c (source_windows): Now a std::vector.
2408         (tui_source_windows): Change return type.
2409         (tui_clear_source_windows): Rewrite.
2410         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2411         (tui_free_all_source_wins_content): Rewrite.
2412
2413 2019-06-25  Tom Tromey  <tom@tromey.com>
2414
2415         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2416         (struct tui_data_window, struct tui_cmd_window): Declare
2417         clear_detail method.
2418         * tui/tui-data.c (tui_source_window::clear_detail)
2419         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2420         methods.
2421         (tui_clear_win_detail): Simplify.
2422
2423 2019-06-25  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-layout.c (make_source_window, make_disasm_window)
2426         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2427         Return the new window.
2428         (show_source_disasm_command, show_data)
2429         (show_source_or_disasm_and_command): Update.
2430
2431 2019-06-25  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2434         parameter.  Return the new window.
2435         (show_source_disasm_command): Update and remove NULL check.
2436         (show_source_or_disasm_and_command): Update.
2437
2438 2019-06-25  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-data.h (struct tui_win_info): Make constructor
2445         protected.  Make destructor virtual.  Add initializers.
2446         (tui_source_window, tui_data_window, tui_cmd_window): New
2447         classes.
2448         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2449         constructor.  Add "type" parameter.
2450         (tui_source_window, tui_data_window, tui_cmd_window): New
2451         constructors.
2452         (tui_alloc_win_info): Instantiate the appropriate subclass.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-win.c (tui_resize_all): Use delete.
2457         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2458         destructor.
2459         (tui_free_window): Don't declare.
2460         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2461         Update.
2462
2463 2019-06-25  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-data.h (struct tui_win_info): Add constructor.
2466         * tui/tui-data.c (tui_alloc_win_info): Use new.
2467         (tui_free_window): Use delete.
2468
2469 2019-06-22  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2472         declare.
2473         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2474
2475 2019-06-22  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2478         declare.
2479         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2480
2481 2019-06-22  Tom de Vries  <tdevries@suse.de>
2482
2483         * dwarf2read.c (create_addrmap_from_aranges)
2484         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2485         instead of '%zu'.
2486
2487 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2488
2489         * dwarf2read.h (dwarf2_section_info_def): Remove.
2490         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2491         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2492         std::vector<dwarf2_section_info>.
2493         (struct dwo_file) <~dwo_file>: Remove.
2494         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2495         types field.
2496         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2497         (dwarf2_read_debug_names): Likewise.
2498         (create_debug_types_hash_table): Change parameter type to
2499         array_view, adjust code accordingly.
2500         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2501         (partial_die_info::fixup): Likewise.
2502         (determine_prefix): Likewise.
2503         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2504
2505 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2506
2507         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2508         gdb_bfd_ref_ptr.
2509         <~dwo_file>: Remove call to gdb_bfd_unref.
2510         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2511         gdb_bfd_ref_ptr::get.
2512
2513 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2514
2515         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2516         type to htab_up.
2517         * dwarf2read.c (struct dwo_file): Initialize fields.
2518         <~dwo_file>: New.
2519         (free_dwo_file): Remove, move content to ~dwo_file.
2520         (struct dwo_file_deleter): Remove.
2521         (dwo_file_up>: Remove custom deleter.
2522         (free_dwo_files): Remove.
2523         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2524         dwo_files.
2525         (process_skeletonless_type_units): Call unique_ptr::get.
2526         (allocate_dwo_file_hash_table): Add deleter to created hash
2527         table.  Change return type to htab_up.
2528         (lookup_dwo_file_slot): Don't memset dwo_file, call
2529         unique_ptr::get.
2530         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2531         (create_dwo_unit_in_dwp_v2): Likewise.
2532         (open_and_init_dwo_file): Likewise.
2533         (free_dwo_file_from_slot): Remove.
2534
2535 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2536
2537         * dwarf2read.h (struct dwarf2_section_info) <readin,
2538         is_virtual>: Change type to bool.
2539         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2540         true instead of 1.
2541
2542 2019-06-19  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-data.h (tui_init_content_element): Don't declare.
2545
2546 2019-06-19  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-data.h (tui_init_win_info): Don't declare.
2549
2550 2019-06-19  Tom de Vries  <tdevries@suse.de>
2551
2552         * dwarf2read.h (abstract_to_concrete): Change type to
2553         std::unordered_map<sect_offset, std::vector<sect_offset>,
2554         gdb::hash_enum<sect_offset>>.
2555
2556 2019-06-19  Tom Tromey  <tromey@adacore.com>
2557
2558         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2559         EVAL_AVOID_SIDE_EFFECTS specially.
2560
2561 2019-06-19  Tom Tromey  <tromey@adacore.com>
2562
2563         * source-cache.c (highlighter): New global.
2564         (source_cache::get_source_lines): Create a highlighter on demand.
2565
2566 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2567
2568         * defs.h (deprecated_interactive_hook): Delete declaration.
2569         * interps.c (clear_interpreter_hooks): Remove use of
2570         deprecated_interactive_hook.
2571         * top.c (deprecated_interactive_hook): Delete definition.
2572         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2573
2574 2019-06-18  Tom de Vries  <tdevries@suse.de>
2575
2576         PR gdb/24515
2577         * dwarf2read.h (abstract_to_concrete): Change type from
2578         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2579         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2580         * dwarf2read.c (read_variable): Update.
2581         (dwarf2_fetch_die_loc_sect_off): Update.
2582
2583 2019-06-17  Tom de Vries  <tdevries@suse.de>
2584
2585         PR gdb/24617
2586         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2587         accessing parent[parent_len - 1].
2588
2589 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2590
2591         PR gdb/24364
2592         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2593         call dtrace_process_dof with NULL dof.
2594
2595 2019-06-16  Tom de Vries  <tdevries@suse.de>
2596
2597         PR gdb/24445
2598         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2599
2600 2019-06-16  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2603         (make_all_visible): Use address of member.
2604
2605 2019-06-16  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2608         (tui_free_window, free_content, free_content_elements): Remove
2609         unnecessary cast.
2610         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2611         cast.
2612         * tui/tui-regs.c (tui_show_register_group)
2613         (tui_display_registers_from, tui_display_reg_element_at_line):
2614         Remove unnecessary cast.
2615
2616 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * linux-nat.c (normal_mask): Delete.
2619         (_initialize_linux_nat): Don't initialise normal_mask.
2620
2621 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2622
2623         PR gdb/24445
2624         * dwarf-index-write.h (write_psymtabs_to_index): Add
2625         dwz_basename parameter.
2626         * dwarf-index-write.c (write_gdbindex): Move file writing to
2627         write_gdbindex_1.  Change return type void.
2628         (assert_file_size): Move up, remove filename parameter.
2629         (write_gdbindex_1): New function.
2630         (write_debug_names): Change return type to void, call
2631         assert_file_size.
2632         (struct index_wip_file): New struct.
2633         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2634         file logic to index_wip_file.  Write index for dwz file if
2635         needed.
2636         (save_gdb_index_command): Pass basename of dwz file, if present.
2637         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2638         build-id of dwz file, if present.
2639         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2640         (dwarf2_get_dwz_file): Likewise.
2641         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2642         (dwarf2_get_dwz_file): Likewise.
2643
2644 2019-06-16  Tom Tromey  <tom@tromey.com>
2645
2646         * coffread.c (process_coff_symbol): Use xstrdup.
2647         * value.c (create_internalvar): Use xstrdup.
2648
2649 2019-06-16  Tom Tromey  <tom@tromey.com>
2650
2651         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2652         * breakpoint.c (stopin_command, stopat_command)
2653         (until_break_command, decode_location_default): Remove unnecessary
2654         cast.
2655         * utils.c (subset_compare): Remove unnecessary cast.
2656         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2657         cast.
2658         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2659         cast.
2660         * infcmd.c (path_command): Remove unnecessary cast.
2661         * coffread.c (decode_type): Remove unnecessary cast.
2662         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2663         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2664         * tui/tui-stack.c (tui_show_locator_content)
2665         (tui_show_frame_info): Remove unnecessary cast.
2666         * tui/tui-win.c (tui_scroll_forward_command)
2667         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2668         (parse_scrolling_args): Remove unnecessary cast.
2669         * tui/tui-data.c (init_win_info, tui_del_window)
2670         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2671         (free_content_elements): Remove unnecessary cast.
2672         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2673         unnecessary cast.
2674         * tui/tui-source.c (tui_set_source_content)
2675         (tui_vertical_source_scroll): Remove unnecessary cast.
2676         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2677         cast.
2678         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2679         * tui/tui-regs.c (tui_display_registers_from)
2680         (tui_display_register): Remove unnecessary cast.
2681         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2682         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2683         (make_visible): Remove unnecessary cast.
2684         * tui/tui-winsource.c (tui_erase_source_content)
2685         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2686         unnecessary cast.
2687         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2688         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2689         * stabsread.c (read_type, read_array_type, read_range_type):
2690         Remove unnecessary cast.
2691         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2692         (parse_symbol, parse_type, upgrade_type, parse_external)
2693         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2694         unnecessary cast.
2695         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2696
2697 2019-06-16  Tom Tromey  <tom@tromey.com>
2698
2699         * tui/tui-data.c (tui_alloc_generic_win_info)
2700         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2701         checks.
2702
2703 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2704             Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * f-typeprint.c (f_print_type): Don't return early for not
2707         associated or not allocated types.
2708         (f_type_print_varspec_suffix): Add print_rank parameter and print
2709         ranks of array types in case they dangling.
2710         (f_type_print_base): Add print_rank parameter.
2711
2712 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         * NEWS: Mention new MI commands.
2715         * break-catch-throw.c (enum exception_event_kind): Move to
2716         breakpoint.h.
2717         (print_mention_exception_catchpoint): Output text as a single
2718         message.
2719         (catch_exception_command_1): Rename to...
2720         (catch_exception_event): ...this, make non-static, update header
2721         command, and change some parameter types.
2722         (catch_catch_command): Update for changes to
2723         catch_exception_command_1.
2724         (catch_throw_command): Likewise.
2725         (catch_rethrow_command): Likewise.
2726         * breakpoint.c (enum exception_event_kind): Delete.
2727         * breakpoint.h (enum exception_event_kind): Moved here from
2728         break-catch-throw.c.
2729         (catch_exception_event): Declare.
2730         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2731         (mi_cmd_catch_throw): New function.
2732         (mi_cmd_catch_rethrow): New function.
2733         (mi_cmd_catch_catch): New function.
2734         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2735         'catch-catch' entries.
2736         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2737         (mi_cmd_catch_rethrow): Declare.
2738         (mi_cmd_catch_catch): Declare.
2739
2740 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2741
2742         * annotate.c (annotate_source_line): Change return type to void,
2743         update implementation to match.
2744         * annotate.h (annotate_source_line): Change return type to void,
2745         update header comment.
2746         * stack.c (print_frame_info): Don't change what frame information
2747         is printed based on whether annotations are on or not.
2748
2749 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2752         (annotate_source): Make static.
2753         (annotate_source_line): Moved from source.c and renamed from
2754         identify_source_line.  Update the return type.
2755         * annotate.h (annotate_source): Delete declaration.
2756         (annotate_source_line): Declaration moved from source.h, and
2757         renamed from identify_source_line.  Return type updated.
2758         * source.c (identify_source_line): Moved to annotate.c and renamed
2759         to annotate_source_line.
2760         (info_line_command): Remove check of annotation_level.
2761         * source.h (identify_source_line): Move declaration to annotate.h
2762         and rename to annotate_source_line.
2763         * stack.c: Add 'annotate.h' include.
2764         (print_frame_info): Remove check of annotation_level before
2765         calling annotate_source_line.
2766
2767 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2768
2769         * source-cache.c (source_cache::get_plain_source_lines): Use
2770         open_source_file_with_line_charpos instead of just
2771         open_source_file, remove call to find_source_lines.
2772         (source_cache::get_source_lines): Likewise.
2773         * source.c (find_source_lines): Make static.
2774         (get_filename_and_charpos): Renamed into...
2775         (open_source_file_with_line_charpos): ..this along with changes to
2776         return a scoped_fd, and some other minor clean ups.
2777         (identify_source_line): Use open_source_file_with_line_charpos.
2778         (search_command_helper): Use open_source_file_with_line_charpos
2779         instead of just open_source_file, remove call to
2780         find_source_lines.
2781         * source.h (open_source_file_with_line_charpos): Declare new
2782         function.
2783         (find_source_lines): Delete declaration.
2784
2785 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2786
2787         * source.c (get_filename_and_charpos): Remove fullname
2788         parameter.
2789         (identify_source_line): Update call to get_filename_and_charpos.
2790
2791 2019-06-14  Tom Tromey  <tromey@adacore.com>
2792
2793         PR gdb/24502:
2794         * ui-style.h (skip_ansi_escape): Update comment.
2795         * ui-file.h (class no_terminal_escape_file): New class.
2796         * ui-file.c (no_terminal_escape_file::write)
2797         (no_terminal_escape_file::puts): New methods.
2798         * cli/cli-logging.c (handle_redirections): Use
2799         no_terminal_escape_file.
2800
2801 2019-06-14  Tom Tromey  <tromey@adacore.com>
2802
2803         * NEWS: Move convenience variable news above Python news.
2804
2805 2019-06-14  Tom Tromey  <tom@tromey.com>
2806
2807         * gnulib: Move directory to top-level.
2808         * configure.ac: Don't configure gnulib.
2809         * configure: Rebuild.
2810         * common/common-defs.h: Use new path to gnulib.
2811         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2812         (GNULIB_H): Remove.
2813         (INCGNU): Look in new gnulib location.
2814         (HFILES_NO_SRCDIR): Remove gnulib files.
2815         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2816         (generated_files): Remove GNULIB_H.
2817         ($(LIBGNU), all-lib): Remove targets.
2818         (distclean): Don't mention GNULIB_BUILDDIR.
2819         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2820
2821 2019-06-14  Tom Tromey  <tromey@adacore.com>
2822
2823         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2824         Warn if symbol file does not provide any symbols.
2825
2826 2019-06-14  Tom Tromey  <tromey@adacore.com>
2827
2828         * source.c (find_and_open_source): Respect basenames_may_differ.
2829
2830 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * annotate.c (annotate_breakpoints_invalid): Make use of
2833         scoped_restore_terminal_state.
2834         (annotate_frames_invalid): Likewise.
2835
2836 2019-06-14  Tom Tromey  <tromey@adacore.com>
2837
2838         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2839         allow assignment to an internalvar.
2840
2841 2019-06-14  Tom Tromey  <tromey@adacore.com>
2842
2843         * ada-lex.l: Allow "_" in attribute names.
2844
2845 2019-06-14  Tom Tromey  <tromey@adacore.com>
2846
2847         PR gdb/24653:
2848         * regcache.c (registers_changed): Don't call alloca.
2849         * top.c (execute_command): Don't call alloca.
2850
2851 2019-06-13  Pedro Alves  <palves@redhat.com>
2852
2853         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2854         'expression'.  When parsing an expression, error out if there's
2855         junk after "unlimited".
2856         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2857         (do_set_command): Adjust calls to is_unlimited_literal.
2858
2859 2019-06-13  Pedro Alves  <palves@redhat.com>
2860
2861         * compile/compile.c (make_compile_options_def_group): Add braces
2862         around array_view initializer.
2863         * thread.c (make_thread_apply_all_options_def_group)
2864         (make_thread_apply_all_options_def_group): Likewise.
2865
2866 2019-06-13  Pedro Alves  <palves@redhat.com>
2867
2868         * NEWS (New commands): Mention "maint test-options
2869         require-delimiter", "maint test-options unknown-is-error", "maint
2870         test-options unknown-is-operand" and "maint show
2871         test-options-completion-result".
2872         (New command options, command completion): New section.
2873         (Completion improvements): New section.
2874         Mention that you can abbreviate "unlimited".
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2879         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2880         * unittests/cli-utils-selftests.c (test_parse_flags)
2881         (test_parse_flags_qcs): Delete.
2882         (test_cli_utils): Don't call deleted functions.
2883
2884 2019-06-13  Pedro Alves  <palves@redhat.com>
2885
2886         * thread.c: Include "cli/cli-option.h".
2887         (tp_array_compar_ascending): Global.
2888         (tp_array_compar): Delete function.
2889         (tp_array_compar_ascending, tp_array_compar_descending): New
2890         functions.
2891         (ascending_option_def, qcs_flag_option_def)
2892         (thr_qcs_flags_option_defs)
2893         (make_thread_apply_all_options_def_group)
2894         (make_thread_apply_options_def_group): New.
2895         (thread_apply_all_command): Use gdb::option::process_options.
2896         (thread_apply_command_completer)
2897         (thread_apply_all_command_completer): New.
2898         (thread_apply_command): Use gdb::option::process_options.
2899         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2900         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2901         to generate help text of "thread apply".  Adjust "taas"'s help.
2902         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2903         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2904
2905 2019-06-13  Pedro Alves  <palves@redhat.com>
2906
2907         * thread.c (thread_apply_command): Check for invalid TID with
2908         isdigit instead of !isalpha.
2909
2910 2019-06-13  Pedro Alves  <palves@redhat.com>
2911
2912         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2913         (validate_flags_qcs): New.
2914         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2915         (validate_flags_qcs): Declare.
2916         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2917         (make_frame_apply_options_def_group): New.
2918         (frame_apply_command_count): Process options with
2919         gdb::option::process_options.
2920         (frame_apply_completer): New.
2921         (frame_apply_level_completer, frame_apply_all_completer)
2922         (frame_apply_completer): New.
2923         (_initialize_stack): Update help of "frame apply", "frame apply
2924         level", "frame apply all" and "faas" to mention supported options
2925         and install command completers.
2926         * stack.h (frame_apply_all_completer): Declare.
2927         * thread.c: Include "stack.h".
2928         (tfaas_command): Add "--".
2929         (_initialize_thread): Update help "tfaas" to mention supported
2930         options and install command completer.
2931
2932 2019-06-13  Pedro Alves  <palves@redhat.com>
2933
2934         * completer.c (complete_nested_command_line): New.
2935         (gdb_completion_word_break_characters_throw): Add assertion.
2936         * completer.h (complete_nested_command_line): Declare.
2937
2938 2019-06-13  Pedro Alves  <palves@redhat.com>
2939
2940         * stack.c (parse_backtrace_qualifiers): New.
2941         (backtrace_command): Use it.
2942         (backtrace_command_completer): Complete on qualifiers.
2943
2944 2019-06-13  Pedro Alves  <palves@redhat.com>
2945
2946         * frame.c: Include "cli/cli-option.h.
2947         (user_set_backtrace_options): New.
2948         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2949         Delete.
2950         (get_prev_frame): Adjust.
2951         (boolean_option_def, uinteger_option_def)
2952         (set_backtrace_option_defs): New.
2953         (_initialize_frame): Adjust and use
2954         gdb::option::add_setshow_cmds_for_options to install "set
2955         backtrace past-main" and "set backtrace past-entry".
2956         * frame.h: Include "cli/cli-option.h".
2957         (struct frame_print_options): Forward declare.
2958         (print_frame_arguments_all, print_frame_arguments_scalars)
2959         (print_frame_arguments_none): Declare.
2960         (print_entry_values): Delete declaration.
2961         (struct frame_print_options, user_frame_print_options): New.
2962         (struct set_backtrace_options): New.
2963         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2964         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2965         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2966         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2967         (list_args_or_locals): Add frame_print_options parameter.
2968         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2969         * python/py-framefilter.c (enumerate_args): Pass down
2970         USER_FRAME_PRINT_OPTIONS.
2971         * stack.c: Include "cli/cli-option.h".
2972         (print_frame_arguments_all, print_frame_arguments_scalars)
2973         (print_frame_arguments_none): Declare.
2974         (print_raw_frame_arguments, print_entry_values): Delete.
2975         (user_frame_print_options): New.
2976         (boolean_option_def, enum_option_def, frame_print_option_defs):
2977         New.
2978         (struct backtrace_cmd_options): New.
2979         (bt_flag_option_def): New.
2980         (backtrace_command_option_defs): New.
2981         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2982         (print_frame_arg, read_frame_arg, print_frame_args)
2983         (print_frame_info, print_frame): Add frame_print_options parameter
2984         and use it.
2985         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2986         (backtrace_command_1): Add frame_print_options and
2987         backtrace_cmd_options parameters and use them.
2988         (make_backtrace_options_def_group): New.
2989         (backtrace_command): Process command options with
2990         gdb::option::process_options.
2991         (backtrace_command_completer): New.
2992         (_initialize_stack): Extend "backtrace"'s help to mention
2993         supported options.  Install completer for "backtrace".
2994         Install some settings commands with add_setshow_cmds_for_options.
2995
2996 2019-06-13  Pedro Alves  <palves@redhat.com>
2997
2998         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2999         and that "set/show print raw frame-arguments" are now deprecated.
3000
3001         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3002         command.
3003         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3004         * stack.c (_initialize_stack): Install "set/show print
3005         raw-frame-arguments", and deprecate "set/show print raw
3006         frame-arguments".
3007         * valprint.c (_initialize_valprint): Deprecate "set/show print
3008         raw".
3009
3010 2019-06-13  Pedro Alves  <palves@redhat.com>
3011
3012         * compile/compile.c (struct compile_options): New.
3013         (compile_flag_option_def, compile_command_option_defs)
3014         (make_compile_options_def_group): New.
3015         (compile_file_command): Handle options with
3016         gdb::option::process_options.
3017         (compile_file_command_completer): New function.
3018         (compile_code_command): Handle options with
3019         gdb::option::process_options.
3020         (compile_code_command_completer): New function.
3021         (_initialize_compiler): Install completers for "compile code" and
3022         "compile file".  Mention available options in "compile code" and
3023         "compile code"'s help.
3024         * completer.c (advance_to_completion_word): New, factored out from
3025         ...
3026         (advance_to_expression_complete_word_point): ... this.
3027         (advance_to_filename_complete_word_point): New.
3028         * completer.h (advance_to_filename_complete_word_point): New
3029         declaration.
3030
3031 2019-06-13  Pedro Alves  <palves@redhat.com>
3032
3033         * compile/compile.c: Include "cli/cli-option.h".
3034         (compile_print_value): Scope data pointer is now a
3035         value_print_options pointer; adjust.
3036         (compile_print_command): Process options.  Scope data pointer is
3037         now a value_print_options pointer; adjust.
3038         (_initialize_compile): Update "compile print"'s help to include
3039         supported options.  Install a completer for "compile print".
3040         * cp-valprint.c (show_vtblprint, show_objectprint)
3041         (show_static_field_print): Delete.
3042         (_initialize_cp_valprint): Don't install "set print
3043         static-members", "set print vtbl", "set print object" here.
3044         * printcmd.c: Include "cli/cli-option.h" and
3045         "common/gdb_optional.h".
3046         (print_command_parse_format): Rework to fill in a
3047         value_print_options instead of a format_data.
3048         (print_value): Change parameter type from format_data pointer to
3049         value_print_options reference.  Adjust.
3050         (print_command_1): Process options.  Adjust to pass down a
3051         value_print_options.
3052         (print_command_completer): New.
3053         (_initialize_printcmd): Install print_command_completer as
3054         handle_brkchars completer for the "print" command.  Update
3055         "print"'s help to include supported options.
3056         * valprint.c: Include "cli/cli-option.h".
3057         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3058         here from cp-valprint.c.
3059         (boolean_option_def, uinteger_option_def)
3060         (value_print_option_defs, make_value_print_options_def_group):
3061         New.  Use gdb::option::add_setshow_cmds_for_options to install
3062         "set print elements", "set print null-stop", "set print repeats",
3063         "set print pretty", "set print union", "set print array", "set
3064         print address", "set print symbol", "set print array-indexes".
3065         * valprint.h: Include <string> and "cli/cli-option.h".
3066         (make_value_print_options_def_group): Declare.
3067         (print_value): Change parameter type from format_data pointer to
3068         value_print_options reference.
3069         (print_command_completer): Declare.
3070
3071 2019-06-13  Pedro Alves  <palves@redhat.com>
3072
3073         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3074         (COMMON_SFILES): Add maint-test-settings.c.
3075         * cli/cli-decode.c (boolean_enums): New global, factored out from
3076         ...
3077         (add_setshow_boolean_cmd): ... here.
3078         * cli/cli-decode.h (boolean_enums): Declare.
3079         * cli/cli-option.c: New file.
3080         * cli/cli-option.h: New file.
3081         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3082         factored out from ...
3083         (parse_cli_boolean_value(const char *)): ... this.
3084         (is_unlimited_literal): Change parameter type to pointer to
3085         pointer.  Adjust and advance ARG pointer.
3086         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3087         (parse_cli_var_enum): New, factored out from ...
3088         (do_set_command): ... this.  Adjust.
3089         * cli/cli-setshow.h (parse_cli_boolean_value)
3090         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3091         (parse_cli_var_enum): Declare.
3092         * cli/cli-utils.c: Include "cli/cli-option.h".
3093         (get_ulongest): New.
3094         * cli/cli-utils.h (get_ulongest): Declare.
3095         (check_for_argument): New overloads.
3096         * maint-test-options.c: New file.
3097
3098 2019-06-13  Pedro Alves  <palves@redhat.com>
3099
3100         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3101         parse a range if "-" is at the end of the string.
3102
3103 2019-06-13  Pedro Alves  <palves@redhat.com>
3104
3105         * cli/cli-setshow.c (parse_auto_binary_operation)
3106         (parse_cli_boolean_value): Don't allow "o".
3107
3108 2019-06-13  Pedro Alves  <palves@redhat.com>
3109
3110         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3111         * NEWS: Mention maint test-settings KIND.
3112         * maint-test-settings.c: New file.
3113
3114 2019-06-13  Pedro Alves  <palves@redhat.com>
3115
3116         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3117         completer.
3118         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3119         "set" completers.
3120
3121 2019-06-13  Pedro Alves  <palves@redhat.com>
3122
3123         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3124         after item.
3125
3126 2019-06-13  Pedro Alves  <palves@redhat.com>
3127
3128         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3129
3130 2019-06-13  Pedro Alves <palves@redhat.com>
3131
3132         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3133         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3134         call.
3135         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3136         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3137         calls.
3138         (check_for_argument): Skip spaces after argument.
3139
3140 2019-06-13  Pedro Alves  <palves@redhat.com>
3141
3142         * thread.c (thread_apply_command): Adjust TID parsing.
3143         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3144         detected before end of string.
3145         (tid_is_in_list): Error out if LIST is invalid.
3146
3147 2019-06-13  Pedro Alves  <palves@redhat.com>
3148
3149         * completer.c (complete_line_internal_1): Rewind completion word
3150         point.
3151         (completion_tracker::advance_custom_word_point_by): Change
3152         parameter type to int.
3153         * completer.h (completion_tracker::advance_custom_word_point_by):
3154         Likewise.
3155
3156 2019-06-13  Pedro Alves  <palves@redhat.com>
3157
3158         * completer.c (advance_to_completion_word): Handle delimiters.
3159
3160 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3161
3162         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3163
3164 2019-06-11  Tom Tromey  <tom@tromey.com>
3165
3166         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3167         (xmalloc_failed): Move to alloc.c.
3168         * alloc.c: New file.
3169         * Makefile.in (COMMON_SFILES): Add alloc.c.
3170
3171 2019-06-11  Tom Tromey  <tom@tromey.com>
3172
3173         * nat/linux-waitpid.c: Don't include server.h.
3174         (linux_debug): Remove.
3175         (my_waitpid): Update.
3176
3177 2019-06-11  Tom Tromey  <tromey@adacore.com>
3178
3179         * infcall.c (_initialize_infcall): Remove trailing newline from
3180         help.
3181         * user-regs.c (_initialize_user_regs): Remove trailing newline
3182         from help.
3183         * typeprint.c (_initialize_typeprint): Remove trailing newline
3184         from help.
3185         * reverse.c (_initialize_reverse): Remove trailing newlines from
3186         help.
3187         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3188         from help.
3189         * language.c (add_set_language_command): Remove trailing newline
3190         from help.
3191         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3192         help.
3193         * disasm.c (_initialize_disasm): Remove trailing newline from
3194         help.
3195         * top.c (init_main): Remove trailing newline from help.
3196         * interps.c (_initialize_interpreter): Remove trailing newline
3197         from help.
3198         * btrace.c (_initialize_btrace): Remove trailing newlines from
3199         help.
3200         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3201         from help.
3202         * python/python.c (_initialize_python): Remove trailing newline
3203         from help.
3204         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3205         help.
3206         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3207         from help.  Reformat some text.
3208         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3209         from help.
3210         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3211         newline from help.
3212
3213 2019-06-11  Tom Tromey  <tromey@adacore.com>
3214
3215         * darwin-nat.c (darwin_decode_exception_message)
3216         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3217
3218 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3219
3220         * valops.c (value_slice): Check for not allocated or not
3221         associated values.
3222
3223 2019-06-10  Tom de Vries  <tdevries@suse.de>
3224
3225         PR gdb/24618
3226         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3227         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3228         invalid.
3229
3230 2019-06-10  Tom de Vries  <tdevries@suse.de>
3231
3232         PR gdb/24611
3233         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3234         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3235
3236 2019-06-10  Tom de Vries  <tdevries@suse.de>
3237
3238         PR symtab/24545
3239         * symtab.c (struct demangled_name_entry): Add language field.
3240         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3241         static minimal symbol".  Set and use language field.
3242
3243 2019-06-10  Tom Tromey  <tromey@adacore.com>
3244
3245         * ada-lang.c (_initialize_ada_language): Update help text.
3246
3247 2019-06-10  Tom Tromey  <tromey@adacore.com>
3248
3249         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3250         with a newline.
3251         * guile/guile.c (handle_boot_error): Don't end warning with a
3252         newline.
3253         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3254         warning with a newline.
3255         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3256         newline.
3257         (s12z_frame_cache): Likewise.
3258         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3259         a newline.
3260         * solib-svr4.c (disable_probes_interface): Don't end warning with
3261         a newline.
3262         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3263         newline.
3264         * python/python.c (do_finish_initialization): Don't end warning
3265         with a newline.
3266
3267 2019-06-10  Tom Tromey  <tom@tromey.com>
3268
3269         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3270         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3271         gdbpy_enter.
3272
3273 2019-06-10  Tom Tromey  <tromey@adacore.com>
3274
3275         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3276         data.
3277         (elf_new_init): Don't call stabsread_new_init.
3278         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3279         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3280         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3281
3282 2019-06-10  Tom de Vries  <tdevries@suse.de>
3283
3284         PR symtab/16264
3285         PR symtab/24517
3286         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3287
3288 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3289
3290         * source.c (find_and_open_source): Also rewrite relative file
3291         names.
3292
3293 2019-04-26  Amos Bird  <amosbird@gmail.com>
3294
3295         * annotate.c (annotate_thread_exited): Add "thread-exited"
3296         annotation.
3297
3298 2019-06-06  Tom Tromey  <tromey@adacore.com>
3299
3300         * maint.h (class scoped_command_stats): Use
3301         DISABLE_COPY_AND_ASSIGN.
3302         <print_time>: New method.
3303         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3304         print_time.
3305         (scoped_command_stats::print_time): New method.
3306
3307 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3308
3309         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3310         instructions of lengths 6 or 8 bytes.
3311
3312 2019-06-04  Pedro Alves  <palves@redhat.com>
3313
3314         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3315
3316         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3317         * breakpoint.c (condition_completer): Likewise.
3318         * cli/cli-dump.c (scan_expression): Likewise.
3319         * common/filestuff.c (mkdir_recursive): Likewise.
3320         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3321         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3322         (gdb_abspath): Likewise.
3323         * compile/compile-cplus-types.c
3324         (compile_cplus_instance::decl_name): Likewise.
3325         * completer.c (complete_explicit_location):
3326         (signal_completer, reg_or_group_completer_1): Likewise.
3327         * cp-support.c (cp_remove_params_if_any): Likewise.
3328         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3329         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3330         * infcmd.c (strip_bg_char): Likewise.
3331         * linespec.c (copy_token_string): Likewise.
3332         * mi/mi-main.c (output_cores): Likewise.
3333         * psymtab.c (psymtab_search_name):
3334         * symfile.c (test_set_ext_lang_command): Likewise.
3335         * target.c (target_fileio_read_stralloc): Likewise.
3336         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3337         * value.c (complete_internalvar): Likewise.
3338
3339 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3340
3341         Add objfile property to gdb.Type.
3342         * NEWS: Mention Python API addition.
3343         * python/py-type.c (typy_get_objfile): New method.
3344
3345 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3346
3347         * NEWS: Mention the new set|show style [title|highlight].
3348         Mention changes to "show style", "help" and "apropos".
3349
3350 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3351
3352         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3353         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3354         instead of print_help_for_command.
3355         (print_doc_of_command): New function.
3356         (help_list): Add 'apropos -v word' suggestion.
3357         (print_help_for_command): Style the command name using title style.
3358         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3359         (_initialize_cli_cmds): Describe -v in apropos_command help.
3360
3361 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3362
3363         * cli/cli-style.h (cli_style_option): Add name in constructor,
3364         add m_name class member, add constructor with intensity,
3365         add name class function.
3366         (cli_style_option::add_setshow_commands): Remove name argument.
3367         (highlight_style, title_style): New styles.
3368         * cli/cli-style.c (do_show): New function that shows a style
3369         characteristic styling the style name with itself.
3370         (set_style_name): New function.
3371         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3372         Update all callers according to the changes in cli/cli-style.h.
3373         * utils.h (fputs_highlighted): New function.
3374         * utils.c (fputs_highlighted): Likewise.
3375
3376 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3377
3378         * NEWS: Mention new pipe command and new convenience variables.
3379
3380 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3381
3382         * cli/cli-cmds.c (pipe_command): New function.
3383         (_initialize_cli_cmds): Call add_com for pipe_command.
3384         Define | as an alias for pipe.
3385         (exit_status_set_internal_vars): New function.
3386         (shell_escape): Call exit_status_set_internal_vars.
3387         cli/cli-decode.c (find_command_name_length): Recognize | as
3388         a single character command.
3389
3390 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3391
3392         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3393         top.c (execute_command_to_ui_file): New function, mostly a copy
3394         of execute_command_to_string.
3395         (execute_command_to_string): Implement by calling
3396         execute_command_to_ui_file.
3397
3398 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3399
3400         * top.h (saved_command_line): Remove declaration.
3401         * top.c (previous_saved_command_line, previous_repeat_arguments):
3402         New variables.
3403         (saved_command_line): Make static, define together with other
3404         'repeat variables'.
3405         (dont_repeat): Clear repeat_arguments.
3406         (repeat_previous, get_saved_command_line, save_command_line):
3407         New functions.
3408         (gdb_init): Initialize saved_command_line
3409         and previous_saved_command_line.
3410         * main.c (captured_main_1): Remove saved_command_line initialization.
3411         * event-top.c (handle_line_of_input): Update to use
3412         the new 'repeat' related functions instead of direct access to
3413         saved_command_line.
3414         * command.h (repeat_previous, get_saved_command_line,
3415         save_command_line): New declarations.
3416         (dont_repeat): Add comment.
3417
3418 2019-05-30  Tom Tromey  <tromey@adacore.com>
3419
3420         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3421         Fix comment.
3422         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3423
3424 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3425
3426         PR cli/24587
3427         * completer.c (complete): Initialize variable word.
3428
3429 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3430
3431         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3432         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3433         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3434         'body' is NULL to the outter 'if', protecting the '!is_define'
3435         situation as well.
3436
3437 2019-05-29  Tom Tromey  <tromey@adacore.com>
3438
3439         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3440         (dwarf_unknown): New function.
3441         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3442         (dwarf_type_encoding_name): Use dwarf_unknown.
3443
3444 2019-05-29  Tom Tromey  <tromey@adacore.com>
3445
3446         PR c++/20020:
3447         * cp-valprint.c (cp_print_value_fields): Call
3448         cp_print_static_field inside "try".
3449
3450 2019-05-29  Tom Tromey  <tromey@adacore.com>
3451
3452         * inflow.c (struct terminal_info): Add default operator=.
3453         * configure: Rebuild.
3454         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3455         -Wdeprecated-copy-dtor, -Wredundant-move.
3456
3457 2019-05-29  Tom Tromey  <tromey@adacore.com>
3458
3459         * NEWS: Add entry.
3460         * infcmd.c (print_return_value_1): Handle finish_print
3461         option.
3462         (show_print_finish): New function.
3463         (_initialize_infcmd): Add "set/show print finish" commands.
3464         * valprint.c (user_print_options): Initialize new member.
3465         * valprint.h (struct value_print_options) <finish_print>: New
3466         member.
3467
3468 2019-05-28  Tom Tromey  <tromey@adacore.com>
3469
3470         * ada-lang.c (ada_remove_Xbn_suffix)
3471         (find_old_style_renaming_symbol)
3472         (parse_old_style_renaming): Remove.
3473         (ada_find_renaming_symbol): Don't call
3474         find_old_style_renaming_symbol.
3475         (ada_is_renaming_symbol): Rename from
3476         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3477         bool.  Now static.
3478         (ada_read_var_value): Update and simplify.
3479         * ada-exp.y (write_var_or_type): Remove old code.
3480
3481 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3482
3483         * event-top.c: Remove include comment.
3484         * inflow.c (class scoped_ignore_sigttou): Move from here...
3485         * inflow.h (class scoped_ignore_sigttou): ...to here.
3486         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3487         * top.c:  Remove include comment.
3488
3489 2019-05-27  Tom Tromey  <tom@tromey.com>
3490
3491         * NEWS: Fix typo.
3492
3493 2019-05-22  Tom Tromey  <tromey@adacore.com>
3494
3495         * target.c (target_follow_exec): Constify parameter.
3496         * target-delegates.c: Rebuild.
3497         * remote.c (remote_target::follow_exec): Constify parameter.
3498         * infrun.c (follow_exec): Constify parameter.
3499         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3500         (target_follow_exec): Likewise.
3501
3502 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3503
3504         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3505         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3506
3507 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3508
3509         * NEWS: Add debugredirect and testsuite sections.
3510
3511 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3512
3513         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3514         target descriptions using exclusively floating point register name
3515         aliases.
3516
3517 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         PR gdb/18644:
3520         * f-lang.c (build_fortran_types): Handle the case where
3521         gdbarch_floatformat_for_type returns a nullptr.
3522
3523 2019-05-21  Tom de Vries  <tdevries@suse.de>
3524
3525         PR cli/24587
3526         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3527
3528 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3529
3530         PR gdb/18644:
3531         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3532         16-byte floats.
3533         * i386-tdep.c (i386_floatformat_for_type): Use
3534         floatformats_ia64_quad for the 16-byte floating point component
3535         within a fortran 32-byte complex number.
3536
3537 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3540         delete default constructor.
3541         (find_partial_die): Update to return const struct.
3542         (partial_die_parent_scope): Move variable declaration into scope
3543         of its use and change its type to auto.
3544         (guess_partial_die_structure_name): Likewise.
3545         (partial_die_info::fixup): Likewise.
3546
3547 2019-05-17  Tom Tromey  <tromey@adacore.com>
3548
3549         * source.c (find_and_open_source): Remove cast.
3550
3551 2019-05-17  Tom Tromey  <tromey@adacore.com>
3552
3553         * annotate.c (annotate_source): Make "filename" const.
3554         * annotate.h (annotate_source): Use const.
3555
3556 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3557
3558         * disasm.c (set_disassembler_options): Send errors to stderr.
3559
3560 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3561
3562         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3563         (cli_interp_base::set_logging): Check debug_redirect.
3564         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3565         * cli/cli-logging.c (debug_redirect): Add static variable.
3566         (pop_output_files): Add default param.
3567         (handle_redirections): Print debug setting.
3568         (show_logging_command): Likewise.
3569         (_initialize_cli_logging): Add debugredirect command.
3570         * interps.c (current_interp_set_logging): Add debug_redirect
3571         parameter.
3572         * interps.h (set_logging): Add debug_redirect parameter.
3573         (current_interp_set_logging): Likewise.
3574         * mi/mi-common.h: Likewise.
3575         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3576
3577 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3578             Tom Tromey  <tromey@adacore.com>
3579
3580         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3581         directly.
3582         * cli/cli-interp.h (make_logging_output): Remove declaration.
3583         * cli/cli-logging.c (make_logging_output): Remove function.
3584         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3585         directly.
3586         * ui-file.c (tee_file::tee_file): Remove bools.
3587         (tee_file::~tee_file): Remove deletes.
3588         * ui-file.h (tee_file): Remove bools.
3589
3590 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3591
3592         * mi/mi-cmds.h (mi_cmd_complete): New function.
3593         * mi/mi-main.c (mi_cmd_complete): Likewise.
3594         * mi/mi-cmds.c: Define new MI command -complete.
3595         * NEWS: Mention new -complete command.
3596
3597 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3598
3599         * completer.h (complete): New function.
3600         * completer.c (complete): Likewise.
3601         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3602         function defined in completer.h.
3603
3604 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3605
3606         * MAINTAINERS (Write After Approval): Add myself.
3607
3608 2019-05-17  Tom de Vries  <tdevries@suse.de>
3609
3610         PR gdb/24094
3611         * dwarf2read.c (struct cu_partial_die_info): New struct.
3612         (find_partial_die): Return cu_partial_die_info.
3613         (partial_die_parent_scope, guess_partial_die_structure_name)
3614         (partial_die_info::fixup): Handle new return type of find_partial_die.
3615
3616 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3617
3618         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3619         "std::string", simplifying the algorithm.
3620
3621 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3622
3623         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3624         (stap_static_probe_ops::get_probes): Likewise.
3625
3626 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3627
3628         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3629         '-')" and "else if".
3630         (stap_parse_single_operand): Join checks for
3631         "gdbarch_stap_parse_special_token_p" and
3632         "gdbarch_stap_parse_special_token" in the same "if" statement.
3633         Invert check when verifying for operation on register
3634         displacement.
3635
3636 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3637
3638         * stap-probe.c (stap_get_opcode): Update comment.
3639         (stap_get_expected_argument_type): Likewise.
3640         (handle_stap_probe): Likewise.
3641
3642 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3643
3644         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3645         return type to 'bool'.  Adjust comment.  Use 'bool' when
3646         appropriate.
3647         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3648         * stap-probe.c (stap_parse_argument_1): Likewise.
3649         (stap_is_operator): Likewise.
3650         (stap_is_generic_prefix): Likewise.
3651         (stap_is_register_prefix): Likewise.
3652         (stap_is_register_indirection_prefix): Likewise.
3653         (stap_is_integer_prefix): Likewise.
3654         (stap_generic_check_suffix): Likewise.
3655         (stap_check_integer_suffix): Likewise.
3656         (stap_check_register_suffix): Likewise.
3657         (stap_check_register_indirection_suffix): Likewise.
3658         (stap_parse_register_operand): Likewise.
3659         (stap_parse_single_operand): Likewise.
3660         (stap_parse_argument_1): Likewise.
3661         (stap_probe::get_argument_count): Likewise.
3662         (stap_is_operator): Likewise.
3663
3664 2019-05-16  Tom Tromey  <tromey@adacore.com>
3665
3666         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3667         keyword to foreach.
3668
3669 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3670
3671         * linux-thread-db.c (try_thread_db_load_1): Change return type
3672         to bool.
3673         (try_thread_db_load): Likewise.
3674         (try_thread_db_load_from_pdir_1): Likewise.
3675         (try_thread_db_load_from_pdir): Likewise.
3676         (try_thread_db_load_from_sdir): Likewise.
3677         (try_thread_db_load_from_dir): Likewise.
3678         (thread_db_load_search): Likewise.
3679         (has_libpthread): Likewise.
3680         (thread_db_load): Likewise.
3681
3682 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3683
3684         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3685         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3686         NULL, and complain/return if that's the case.
3687
3688 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3689
3690         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3691         (advance, posn, abstract_read_memory): New functions.
3692         [struct mem_read_abstraction]: New struct.
3693         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3694
3695 2019-05-14  Tom Tromey  <tromey@adacore.com>
3696
3697         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3698         value is not lval_memory.
3699
3700 2019-05-14  Tom Tromey  <tromey@adacore.com>
3701
3702         * solib.c (info_sharedlibrary_command): Style the file name.
3703
3704 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3705
3706         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3707         (aarch64_vnv_type): Likewise.
3708         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3709         * common/tdesc.c: Likewise.
3710         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3711         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3712         * features/aarch64-fpu.xml: Add ieee half view.
3713         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3714         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3715         * gdbtypes.h (struct builtin_type): Likewise.
3716         (struct objfile_type): Likewise.
3717
3718 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3719
3720         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3721         typo.
3722         * location.h (string_to_event_location): Likewise.
3723
3724 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3725
3726         GDB 8.3 released.
3727
3728 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3729
3730         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3731         New variable declaration.
3732         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3733         New variable.
3734         (print_one_breakpoint): Use ui_out::test_flags and new global
3735         variable to compute use_fixed_output.
3736         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3737         Remove.
3738         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3739         (mi_multi_location_breakpoint_output_fixed): Remove.
3740         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3741         new variable.
3742         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3743         fix_multi_location_breakpoint_output flag if version >= 3.
3744         * ui-out.h (enum ui_out_flag)
3745         <fix_multi_location_breakpoint_output>: New enumerator.
3746
3747 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3748
3749         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3750
3751 2019-05-10  Tom Tromey  <tromey@adacore.com>
3752
3753         * ada-lang.c (catch_ada_completer): New function.
3754         (_initialize_ada_language): Use it.
3755
3756 2019-05-10  Tom Tromey  <tromey@adacore.com>
3757
3758         * thread.c (print_thread_info): Make "requested_threads" const.
3759         * gdbthread.h (print_thread_info): Make "requested_threads"
3760         const.
3761         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3762         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3763
3764 2019-05-08  Tom Tromey  <tom@tromey.com>
3765
3766         * gdbtypes.c (objfile_type_data): Change type.
3767         (objfile_type, _initialize_gdbtypes): Update.
3768
3769 2019-05-08  Tom Tromey  <tom@tromey.com>
3770
3771         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3772         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3773         (_initialize_dwarf2_frame): Update.
3774
3775 2019-05-08  Tom Tromey  <tom@tromey.com>
3776
3777         * objc-lang.c (objc_objfile_data): Change type.
3778         (find_methods): Update.
3779         (_initialize_objc_lang): Remove.
3780
3781 2019-05-08  Tom Tromey  <tom@tromey.com>
3782
3783         * stabsread.c (rs6000_builtin_type_data): Change type.
3784         (rs6000_builtin_type, _initialize_stabsread): Update.
3785
3786 2019-05-08  Tom Tromey  <tom@tromey.com>
3787
3788         * mips-tdep.c (mips_pdr_data): Remove.
3789         (_initialize_mips_tdep): Update.
3790
3791 2019-05-08  Tom Tromey  <tom@tromey.com>
3792
3793         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3794         (hppa_init_objfile_priv_data, read_unwind_info)
3795         (find_unwind_entry, _initialize_hppa_tdep): Update.
3796
3797 2019-05-08  Tom Tromey  <tom@tromey.com>
3798
3799         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3800         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3801         on obstack.
3802         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3803
3804 2019-05-08  Tom Tromey  <tom@tromey.com>
3805
3806         * mdebugread.c (basic_type_data): Change type.
3807         (basic_type, _initialize_mdebugread): Update.
3808
3809 2019-05-08  Tom Tromey  <tom@tromey.com>
3810
3811         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3812
3813 2019-05-08  Tom Tromey  <tom@tromey.com>
3814
3815         * nto-tdep.c (nto_inferior_data_reg): Change type.
3816         (nto_inferior_data): Update.
3817         (nto_inferior_data_cleanup, nto_new_inferior_data)
3818         (_initialize_nto_tdep): Remove.
3819         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3820
3821 2019-05-08  Tom Tromey  <tom@tromey.com>
3822
3823         * ada-lang.c (struct ada_inferior_data): Add initializers.
3824         (ada_inferior_data): Change type.
3825         (ada_inferior_data_cleanup): Remove.
3826         (get_ada_inferior_data, ada_inferior_exit)
3827         (struct ada_pspace_data): Add initializers, destructor.
3828         (ada_pspace_data_handle): Change type.
3829         (get_ada_pspace_data): Update.
3830         (ada_pspace_data_cleanup): Remove.
3831
3832 2019-05-08  Tom Tromey  <tom@tromey.com>
3833
3834         * coffread.c (struct coff_symfile_info): Add initializers.
3835         (coff_objfile_data_key): Move lower.  Change type.
3836         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3837         Update.
3838         (coff_free_info): Remove.
3839
3840 2019-05-08  Tom Tromey  <tom@tromey.com>
3841
3842         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3843         (fbsd_pspace_data_handle): Move lower.  Change type.
3844         (get_fbsd_pspace_data): Update.
3845         (fbsd_pspace_data_cleanup): Remove.
3846         (_initialize_fbsd_tdep): Update.
3847
3848 2019-05-08  Tom Tromey  <tom@tromey.com>
3849
3850         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3851         (get_ada_tasks_pspace_data): Update.
3852         (ada_tasks_pspace_data_cleanup): Remove.
3853         (_initialize_tasks): Update.
3854         (ada_tasks_inferior_data_handle): Change type.
3855         (get_ada_tasks_inferior_data): Update.
3856         (ada_tasks_inferior_data_cleanup): Remove.
3857         (struct ada_tasks_pspace_data): Add initializers.
3858
3859 2019-05-08  Tom Tromey  <tom@tromey.com>
3860
3861         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3862         * symfile-debug.c (debug_sym_get_probes): Change type.
3863         * stap-probe.c (handle_stap_probe):
3864         (stap_static_probe_ops::get_probes): Change type.
3865         * probe.h (class static_probe_ops) <get_probes>: Change type.
3866         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3867         (parse_probes_in_pspace): Update.
3868         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3869         Update.
3870         (any_static_probe_ops::get_probes): Change type.
3871         * elfread.c (elfread_data): New typedef.
3872         (probe_key): Change type.
3873         (elf_get_probes): Likewise.  Update.
3874         (probe_key_free): Remove.
3875         (_initialize_elfread): Update.
3876         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3877         Change type.
3878         (dtrace_process_dof_probe, dtrace_process_dof)
3879         (dtrace_static_probe_ops::get_probe): Change type.
3880
3881 2019-05-08  Tom Tromey  <tom@tromey.com>
3882
3883         * xcoffread.c (struct xcoff_symfile_info): Rename from
3884         coff_symfile_info.  Add initializers.
3885         (xcoff_objfile_data_key): Move lower.  Change type.
3886         (XCOFF_DATA): Rewrite.
3887         (xcoff_free_info): Remove.
3888         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3889         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3890         (xcoff_initial_scan): Update.
3891
3892 2019-05-08  Tom Tromey  <tom@tromey.com>
3893
3894         * solib-svr4.c (struct svr4_info): Add initializers and
3895         destructor.
3896         <probes_table>: Now an htab_up.
3897         (solib_svr4_pspace_data): Change type.
3898         (free_probes_table): Simplify.
3899         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3900         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3901         (probes_table_remove_objfile_probes, register_solib_event_probe)
3902         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3903         (_initialize_svr4_solib): Update.
3904
3905 2019-05-08  Tom Tromey  <tom@tromey.com>
3906
3907         * remote.c (remote_pspace_data): Change type.
3908         (remote_pspace_data_cleanup): Remove.
3909         (get_remote_exec_file, set_pspace_remote_exec_file)
3910         (_initialize_remote): Update.
3911
3912 2019-05-08  Tom Tromey  <tom@tromey.com>
3913
3914         * breakpoint.c (breakpoint_objfile_key): Change type.
3915         (get_breakpoint_objfile_data): Update.
3916         (free_breakpoint_objfile_data): Remove.
3917         (_initialize_breakpoint): Update.
3918
3919 2019-05-08  Tom Tromey  <tom@tromey.com>
3920
3921         * linux-tdep.c (struct linux_info): Add initializers.
3922         (linux_inferior_data): Move.  Change type.
3923         (invalidate_linux_cache_inf): Update.
3924         (linux_inferior_data_cleanup): Remove.
3925         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3926
3927 2019-05-08  Tom Tromey  <tom@tromey.com>
3928
3929         * auxv.c (auxv_inferior_data): Move.  Change type.
3930         (auxv_inferior_data_cleanup): Remove.
3931         (invalidate_auxv_cache_inf): Rewrite.
3932         (get_auxv_inferior_data, _initialize_auxv): Update.
3933
3934 2019-05-08  Tom Tromey  <tom@tromey.com>
3935
3936         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3937         (symfile_debug_objfile_data_key): Change type.
3938         (symfile_debug_installed, debug_qf_has_symbols)
3939         (debug_qf_find_last_source_symtab)
3940         (debug_qf_forget_cached_source_info)
3941         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3942         (debug_qf_print_stats, debug_qf_dump)
3943         (debug_qf_expand_symtabs_for_function)
3944         (debug_qf_expand_all_symtabs)
3945         (debug_qf_expand_symtabs_with_fullname)
3946         (debug_qf_map_matching_symbols)
3947         (debug_qf_expand_symtabs_matching)
3948         (debug_qf_find_pc_sect_compunit_symtab)
3949         (debug_qf_map_symbol_filenames)
3950         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3951         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3952         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3953         (debug_sym_read_linetable, debug_sym_relocate): Update.
3954         (symfile_debug_free_objfile): Remove.
3955         (install_symfile_debug_logging, _initialize_symfile_debug):
3956         Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3961         allocate_on_obstack.
3962         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3963         (get_dwarf2_per_objfile): Update.
3964         (set_dwarf2_per_objfile): Remove.
3965         (dwarf2_has_info, dwarf2_get_section_info): Update.
3966         (dwarf2_free_objfile): Remove.
3967         (_initialize_dwarf2_read): Update.
3968
3969 2019-05-08  Tom Tromey  <tom@tromey.com>
3970
3971         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3972         initializers.
3973         <unsupported_script_warning_printed,
3974         script_not_found_warning_printed>: Now bool.
3975         (auto_load_pspace_data): Change type.
3976         (~auto_load_pspace_info): Rename from
3977         auto_load_pspace_data_cleanup.
3978         (get_auto_load_pspace_data, init_loaded_scripts_info)
3979         (clear_section_scripts, maybe_print_unsupported_script_warning)
3980         (maybe_print_script_not_found_warning, _initialize_auto_load):
3981         Update.
3982
3983 2019-05-08  Tom Tromey  <tom@tromey.com>
3984
3985         * objfiles.c (objfile_pspace_info): Add destructor and
3986         initializers.
3987         (objfiles_pspace_data): Change type.
3988         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3989         (get_objfile_pspace_data): Update.
3990         (objfiles_bfd_data): Change type.
3991         (get_objfile_bfd_data): Update.
3992         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3993
3994 2019-05-08  Tom Tromey  <tom@tromey.com>
3995
3996         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3997         Change type.
3998         (get_catch_syscall_inferior_data): Update.
3999         (catch_syscall_inferior_data_cleanup): Remove.
4000         (_initialize_break_catch_syscall): Update.
4001
4002 2019-05-08  Tom Tromey  <tom@tromey.com>
4003
4004         * inflow.c (struct terminal_info): Add destructor and
4005         initializers.
4006         (inflow_inferior_data): Change type.
4007         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4008         (get_inflow_inferior_data, inflow_inferior_exit)
4009         (swap_terminal_info, _initialize_inflow): Update.
4010
4011 2019-05-08  Tom Tromey  <tom@tromey.com>
4012
4013         * target-dcache.c (target_dcache_cleanup): Remove.
4014         (target_dcache_aspace_key): Change type.
4015         (target_dcache_init_p, target_dcache_invalidate)
4016         (target_dcache_get, target_dcache_get_or_init)
4017         (_initialize_target_dcache): Update.
4018         * dcache.h (struct dcache_deleter): New.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * symtab.c (struct symbol_cache): Add destructor and
4023         initializers.
4024         (symbol_cache_key): Move.  Change type.
4025         (make_symbol_cache, free_symbol_cache): Remove.
4026         (get_symbol_cache): Update.
4027         (symbol_cache_cleanup): Remove.
4028         (ALL_PSPACES, symbol_cache_flush)
4029         (maintenance_print_symbol_cache)
4030         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4031         Update.
4032
4033 2019-05-08  Tom Tromey  <tom@tromey.com>
4034
4035         * symtab.c (struct main_info): Add destructor and initializers.
4036         (main_progspace_key): Move.  Change type.
4037         (get_main_info): Update.
4038         (main_info_cleanup): Remove.
4039         (_initialize_symtab): Update.
4040
4041 2019-05-08  Tom Tromey  <tom@tromey.com>
4042
4043         * registry.h (DECLARE_REGISTRY): Define the _key class.
4044
4045 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * NEWS: Merge two 'New commands' sections.
4048
4049 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4050
4051         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4052         parameter and use Ada language definition instead.
4053         (ada_val_print_ptr): Remove unused language parameter.
4054         (ada_val_print_num): Remove language parameter and use Ada language
4055         definition instead.
4056         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4057         parameter.
4058         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4059         parameter and use Ada language definition instead.
4060         (ada_val_print_1): Update all ada_val_print_xxx calls.
4061         Remove language parameter.
4062         (ada_val_print): Update ada_val_print_1 call.
4063
4064 2019-05-08  Tom Tromey  <tromey@adacore.com>
4065
4066         * remote.c (remote_hw_watchpoint_limit)
4067         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4068         Now static.
4069
4070 2019-05-08  Tom Tromey  <tromey@adacore.com>
4071
4072         * maint.c (_initialize_maint_cmds): Move initialization code to
4073         remote.c.
4074         (watchdog, show_watchdog): Move to remote.c.
4075         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4076         "watchdog" static.
4077         (_initialize_remote): Move initialization code from maint.c.
4078         * defs.h (watchdog): Don't declare.
4079
4080 2019-05-08  Tom Tromey  <tromey@adacore.com>
4081
4082         * tui/tui-interp.c: Include main.h.
4083         * interps.c: Include main.h.
4084         * main.h (interpreter_p): Declare.
4085         * defs.h (interpreter_p): Don't declare.
4086
4087 2019-05-08  Tom Tromey  <tromey@adacore.com>
4088
4089         * dwarf2loc.c: Include dwarf2read.h.
4090         * defs.h (read_unsigned_leb128): Don't declare.
4091         * dwarf2read.h (read_unsigned_leb128): Declare.
4092
4093 2019-05-08  Tom Tromey  <tromey@adacore.com>
4094
4095         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4096         method.
4097
4098 2019-05-08  Tom Tromey  <tromey@adacore.com>
4099
4100         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4101         when no wrap column is set.
4102
4103 2019-05-08  Tom Tromey  <tromey@adacore.com>
4104
4105         * c-lang.c (c_get_string): Handle non-C-style arrays.
4106
4107 2019-05-08  Tom Tromey  <tromey@adacore.com>
4108
4109         * typeprint.c (print_offset_data::update): Print the bit offset,
4110         not the number of bits remaining.
4111
4112 2019-05-08  Tom Tromey  <tromey@adacore.com>
4113
4114         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4115         padding at end of comment.
4116
4117 2019-05-08  Tom Tromey  <tromey@adacore.com>
4118
4119         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4120         Compare main types.
4121
4122 2019-05-06  Tom Tromey  <tom@tromey.com>
4123
4124         * common/scoped_mmap.c: Include common-defs.h.
4125         * common/scoped_mmap.h: Don't include config.h.
4126
4127 2019-05-04  Tom Tromey  <tom@tromey.com>
4128
4129         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4130         (struct aarch64_call_info): Add initializers.
4131         <si>: Now a std::vector.
4132         (pass_on_stack, aarch64_push_dummy_call): Update.
4133
4134 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4135             Tom Tromey  <tom@tromey.com>
4136
4137         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4138         (ppc_threads): Now a std::vector.  Now static.
4139         (hwdebug_find_thread_points_by_tid)
4140         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4141         Update.
4142
4143 2019-05-04  Tom Tromey  <tom@tromey.com>
4144
4145         * arc-tdep.c (arc_tdesc_init): Return bool.
4146
4147 2019-05-04  Tom Tromey  <tom@tromey.com>
4148
4149         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4150         Use gdb_assert_not_reached.
4151
4152 2019-05-04  Tom Tromey  <tom@tromey.com>
4153
4154         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4155         "false".
4156
4157 2019-05-04  Tom Tromey  <tom@tromey.com>
4158
4159         * arc-tdep.c (arc_tdesc_init): Use bool.
4160
4161 2019-05-04  Tom Tromey  <tom@tromey.com>
4162
4163         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4164
4165 2019-05-04  Tom Tromey  <tom@tromey.com>
4166
4167         * cli/cli-cmds.c (valid_command_p): Return bool.
4168
4169 2019-05-04  Tom Tromey  <tom@tromey.com>
4170
4171         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4172         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4173
4174 2019-05-04  Raul Tambre  <raul@tambre.ee>
4175
4176         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4177         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4178         operator for comparison.
4179
4180 2019-05-04  Tom Tromey  <tom@tromey.com>
4181
4182         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4183         (lookup_partial_symbol, print_partial_symbols)
4184         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4185         (psymbol_compare): Update.
4186         (add_psymbol_to_bcache): Clear the entire psymbol.
4187         (maintenance_check_psymtabs): Update.
4188         * psympriv.h (struct partial_symbol): Don't derive from
4189         general_symbol_info.
4190         <obj_section, unrelocated_address, address,
4191         set_unrelocated_address>: Update.
4192         <ginfo>: New member.
4193         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4194         (debug_names::write_psymbols): Update.
4195
4196 2019-05-04  Tom de Vries  <tdevries@suse.de>
4197
4198         * contrib/cc-with-tweaks.sh: Support -n arg.
4199
4200 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4201
4202         * corelow.c (core_target::detach): Ensure frame cache and
4203         register caches are cleared.
4204         inferior.c (exit_inferior_1): Likewise.
4205
4206 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4207             Tom Tromey  <tom@tromey.com>
4208
4209         * dictionary.c (collate_pending_symbols_by_language): Remove
4210         "struct" from foreach.
4211         * symtab.c (lookup_global_symbol_from_objfile)
4212         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4213         foreach.
4214         * ser-tcp.c (net_open): Remove "struct" from foreach.
4215         * objfiles.c (objfile_relocate, objfile_rebase)
4216         (objfile_has_symbols): Remove "struct" from foreach.
4217         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4218         from foreach.
4219         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4220         foreach.
4221         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4222         "struct" from foreach.
4223         * ada-lang.c (create_excep_cond_exprs)
4224         (ada_exception_catchpoint_cond_string): Remove "struct" from
4225         foreach.
4226
4227 2019-05-03  Tom Tromey  <tromey@adacore.com>
4228
4229         * ada-exp.y (convert_char_literal): Check suffix of each
4230         enumerator.
4231
4232 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4233
4234         PR ada/21406:
4235         * ada-exp.y (yywrap): Don't define.
4236         * ada-lex.l (%option): Add noyywrap
4237         (yywrap): Remove.
4238
4239 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4240
4241         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4242         _WIN32_WINNT to the XP level, unless already defined to a higher
4243         level.
4244
4245         * unittests/parse-connection-spec-selftests.c:
4246         * ser-tcp.c:
4247         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4248         override.
4249
4250         * symfile.c (find_separate_debug_file): Remove colon from the
4251         drive spec of DOS/Windows file names of the target, so that the
4252         file name produced from DEBUGDIR and the target's directory will
4253         be valid on DOS/Windows systems.
4254
4255 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * rust-lang.c (val_print_struct): Handle printing structures
4258         containing strings.
4259
4260 2019-05-02  Tom Tromey  <tromey@adacore.com>
4261
4262         * valarith.c (_initialize_valarith): Remove.
4263
4264 2019-05-01  Tom Tromey  <tromey@adacore.com>
4265
4266         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4267         bitfields.
4268
4269 2019-05-01  Tom Tromey  <tromey@adacore.com>
4270
4271         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4272         for big-endian copies.
4273
4274 2019-04-30  Ali Tamur  <tamur@google.com>
4275         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4276         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4277         (read_3_bytes): New function.
4278
4279 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4280
4281         * windows-nat.c (main_thread_id): Delete.
4282         (handle_output_debug_string): Replace main_thread_id by
4283         current_event.dwThreadId.
4284         (fake_create_process): Likewise.
4285         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4286         Do not set main_thread_id.
4287         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4288         current_event.dwThreadId.
4289         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4290
4291 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4292
4293         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4294         Use current_event.dwThreadId instead of main_thread_id.
4295
4296 2019-04-30  Tom Tromey  <tromey@adacore.com>
4297
4298         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4299         (create_excep_cond_exprs): Iterate over program spaces.
4300         (ada_exception_catchpoint_cond_string): Examine all minimal
4301         symbols for exception types.
4302
4303 2019-04-30  Tom Tromey  <tromey@adacore.com>
4304
4305         PR c++/24470:
4306         * dwarf2read.c (process_structure_scope): Handle case where type
4307         has template parameters but no symbol was created.
4308
4309 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4310             Chris January  <chris.january@arm.com>
4311
4312         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4313         qualifier.
4314         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4315
4316 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * f-typeprint.c (f_print_type): Update rules for printing
4319         whitespace.
4320         (f_type_print_varspec_suffix): Likewise.
4321
4322 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4323             Chris January  <chris.january@arm.com>
4324
4325         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4326         function arguments.
4327
4328 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * f-lang.c (build_fortran_types): Change name of void type to
4331         lower case.
4332         * f-typeprint.c (f_type_print_base): Print the name of the void
4333         type, rather than a fixed string.
4334         * f-valprint.c (f_decorations): Use lower case void string.
4335
4336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4337             Chris January  <chris.january@arm.com>
4338
4339         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4340         types for Fortran.
4341
4342 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4343             Chris January  <chris.january@arm.com>
4344             David Lecomber  <david.lecomber@arm.com>
4345
4346         * f-exp.y (BINOP_INTRINSIC): New token.
4347         (exp): New parser rule handling BINOP_INTRINSIC.
4348         (f77_keywords): Add new builtin procedures.
4349         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4350         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4351         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4352         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4353         (print_unop_subexp_f): New function.
4354         (print_binop_subexp_f): New function.
4355         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4356         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4357         (dump_subexp_body_f): Likewise.
4358         (operator_check_f): Likewise.
4359         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4360         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4361
4362 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4363
4364         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4365         UNOP_KIND.
4366         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4367         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4368         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4369         (operator_length_f): New fuction.
4370         (print_subexp_f): New function.
4371         (op_name_f): New function.
4372         (dump_subexp_body_f): New function.
4373         (operator_check_f): New function.
4374         (exp_descriptor_f): Replace standard expression handling functions
4375         with new functions.
4376         * gdb/fortran-operator.def: New file.
4377         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4378         * gdb/std-operator.def: Remove UNOP_KIND.
4379
4380 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4381
4382         * std-operator.def: Remove unbalanced, stray double quote
4383         character.
4384
4385 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4386             Chris January  <chris.january@arm.com>
4387             Daniel Everett  <daniel.everett@arm.com>
4388             Nick Forrington  <nick.forrington@arm.com>
4389             Richard Bunt  <richard.bunt@arm.com>
4390
4391         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4392         of depth when printing anonymous structs or unions.
4393         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4394         Don't print either the top-level value, or the children if the
4395         max-depth is exceeded.
4396         (ppscm_print_children): When printing the key of a map, allow one
4397         extra level of depth.
4398         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4399         print either the top-level value, or the children if the max-depth
4400         is exceeded.
4401         (print_children): When printing the key of a map, allow one extra
4402         level of depth.
4403         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4404         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4405         (user_print_options): Initialise max_depth field.
4406         (val_print_scalar_or_string_type_p): New function.
4407         (val_print): Check to see if the max depth has been reached.
4408         (val_print_check_max_depth): Define new function.
4409         (show_print_max_depth): New function.
4410         (_initialize_valprint): Add 'print max-depth' option.
4411         * valprint.h (struct value_print_options) <max_depth>: New field.
4412         (val_print_check_max_depth): Declare new function.
4413         * NEWS: Document new feature.
4414
4415 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4416
4417         * ada-lang.c (ada_language_defn): Initialise new field.
4418         * c-lang.c (c_is_string_type_p): New function.
4419         (c_language_defn): Initialise new field.
4420         (cplus_language_defn): Initialise new field.
4421         (asm_language_defn): Initialise new field.
4422         (minimal_language_defn): Initialise new field.
4423         * c-lang.h (c_is_string_type_p): Declare new function.
4424         * d-lang.c (d_language_defn): Initialise new field.
4425         * f-lang.c (f_is_string_type_p): New function.
4426         (f_language_defn): Initialise new field.
4427         * go-lang.c (go_is_string_type_p): New function.
4428         (go_language_defn): Initialise new field.
4429         * language.c (default_is_string_type_p): New function.
4430         (unknown_language_defn): Initialise new field.
4431         (auto_language_defn): Initialise new field.
4432         * language.h (struct language_defn) <la_is_string_type_p>: New
4433         member variable.
4434         (default_is_string_type_p): Declare new function.
4435         * m2-lang.c (m2_language_defn): Initialise new field.
4436         * objc-lang.c (objc_language_defn): Initialise new field.
4437         * opencl-lang.c (opencl_language_defn): Initialise new field.
4438         * p-lang.c (pascal_is_string_type_p): New function.
4439         (pascal_language_defn): Initialise new field.
4440         * rust-lang.c (rust_is_string_type_p): New function.
4441         (rust_language_defn): Initialise new field.
4442
4443 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4446         New field.
4447         * ada-lang.c (ada_language_defn): Initialise new field.
4448         * c-lang.c (c_language_defn): Likewise.
4449         (cplus_language_defn): Likewise.
4450         (asm_language_defn): Likewise.
4451         (minimal_language_defn): Likewise.
4452         * d-lang.c (d_language_defn): Likewise.
4453         * f-lang.c (f_language_defn): Likewise.
4454         * go-lang.c (go_language_defn): Likewise.
4455         * language.c (unknown_language_defn): Likewise.
4456         (auto_language_defn): Likewise.
4457         * m2-lang.c (m2_language_defn): Likewise.
4458         * objc-lang.c (objc_language_defn): Likewise.
4459         * opencl-lang.c (opencl_language_defn): Likewise.
4460         * p-lang.c (pascal_language_defn): Likewise.
4461         * rust-lang.c (rust_language_defn): Likewise.
4462
4463 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4464
4465         * ada-lang.c (ada_is_character_type): Change return type to bool.
4466         (ada_is_string_type): Likewise.
4467         * ada-lang.h (ada_is_character_type): Update declaration
4468         (ada_is_string_type): Likewise.
4469
4470 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4471
4472         Support style in 'frame|thread apply'
4473
4474         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4475         * record.c (record_start, record_stop): Update callers of
4476         execute_command_to_string with false.
4477         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4478         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4479         methods.
4480         (class string_file): New constructor with term_out parameter.
4481         Override methods term_out and can_emit_style_escape.  New member
4482         term_out.
4483         (class stdio_file): Override can_emit_style_escape.
4484         (class tee_file): Override term_out and can_emit_style_escape.
4485         * utils.h (can_emit_style_escape): Remove.
4486         * utils.c (can_emit_style_escape): Likewise.
4487         Update all callers of can_emit_style_escape (SOMESTREAM) to
4488         SOMESTREAM->can_emit_style_escape.
4489         * source-cache.c (source_cache::get_source_lines): Likewise.
4490         * stack.c (frame_apply_command_count): Call execute_command_to_string
4491         passing the term_out characteristic of the current gdb_stdout.
4492         * thread.c (thr_try_catch_cmd): Likewise.
4493         * top.c (execute_command_to_string): pass term_out parameter
4494         to construct the string_file for the command output.
4495         * ui-file.c (term_cli_styling): New function (most code moved
4496         from utils.c can_emit_style_escape).
4497         (string_file::string_file, string_file::can_emit_style_escape,
4498         stdio_file::can_emit_style_escape, tee_file::term_out,
4499         tee_file::can_emit_style_escape): New functions.
4500
4501 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4502
4503         * NEWS: Mention the new set|show may-call-functions.
4504         * infcall.c (may_call_functions_p): New variable.
4505         (show_may_call_functions_p): New function.
4506         (call_function_by_hand_dummy): Throws an error if not
4507         may-call-functions.
4508         (_initialize_infcall): Call add_setshow_boolean_cmd for
4509         may-call-functions.
4510
4511 2019-04-25  Keith Seitz  <keiths@redhat.com>
4512
4513         PR c++/24367
4514         * cp-support.c (inspect_type): Don't attempt substitutions
4515         of symbol with the same name.
4516
4517 2019-04-25  Tom Tromey  <tromey@adacore.com>
4518
4519         PR gdb/24475:
4520         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4521         static.
4522
4523 2019-04-25  Tom Tromey  <tromey@adacore.com>
4524
4525         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4526         rvalue reference.
4527         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4528         (gdb_xml_parser::parse): Use std::move.
4529         * python/python-internal.h (gdbpy_convert_exception): Take a const
4530         reference.
4531         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4532         std::move.
4533         * python/py-utils.c (gdbpy_convert_exception): Take a const
4534         reference.
4535         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4536         Use std::move.
4537         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4538         Use std::move.
4539         * mi/mi-main.c (mi_print_exception): Take a const reference.
4540         * main.c (handle_command_errors): Take a const reference.
4541         * linespec.c (parse_linespec): Use std::move.
4542         * infcall.c (run_inferior_call): Use std::move.
4543         (call_function_by_hand_dummy): Use std::move.
4544         * exec.c (try_open_exec_file): Use std::move.
4545         * exceptions.h (exception_print, exception_fprintf)
4546         (exception_print_same): Update.
4547         * exceptions.c (print_exception, exception_print)
4548         (exception_fprintf, exception_print_same): Change parameters to
4549         const reference.
4550         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4551         * common/new-op.c: Use std::move.
4552         * common/common-exceptions.h (struct gdb_exception): Add move
4553         constructor.
4554         (struct gdb_exception_error, struct gdb_exception_quit, struct
4555         gdb_quit_bad_alloc): Change constructor to move constructor.
4556         (throw_exception): Change parameter to rvalue reference.
4557         * common/common-exceptions.c (throw_exception): Take rvalue
4558         reference.
4559         * cli/cli-interp.c (safe_execute_command): Use std::move.
4560         * breakpoint.c (insert_bp_location, location_to_sals): Use
4561         std::move.
4562
4563 2019-04-25  Tom Tromey  <tromey@adacore.com>
4564
4565         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4566         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4567         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4568         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4569         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4570         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4571         guile/scm-value.c: Use unpack.
4572         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4573         gdbscm_gdb_exception.
4574         (gdbscm_throw_gdb_exception): Likewise.
4575         (struct gdbscm_gdb_exception): New.
4576         (unpack): New function.
4577         (gdbscm_wrap): Use unpack.
4578
4579 2019-04-25  Tom Tromey  <tromey@adacore.com>
4580
4581         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4582         (gdb_rl_callback_handler): Use std::move.
4583         * common/common-exceptions.h (struct gdb_exception): Add move
4584         assignment operator.
4585         (throw_exception_sjlj): Change "exception" to const reference.
4586         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4587         (throw_exception_sjlj): Change "exception" to const reference.
4588
4589 2019-04-25  Tom Tromey  <tromey@adacore.com>
4590
4591         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4592         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4593         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4594         Update.
4595         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4596         Update.
4597         * mi/mi-interp.c (mi_interp::exec): Update.
4598         * linespec.c (parse_linespec): Update.
4599         * infcall.c (run_inferior_call): Update.
4600         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4601         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4602         (gdbscm_lookup_global_symbol): Update.
4603         * guile/scm-param.c (gdbscm_parameter_value): Update.
4604         * guile/scm-frame.c (gdbscm_frame_read_register)
4605         (gdbscm_frame_read_var): Update.
4606         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4607         * exec.c (try_open_exec_file): Update.
4608         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4609         (gdb_rl_callback_handler): Update.
4610         * common/common-exceptions.h (exception_none): Don't declare.
4611         * common/common-exceptions.c (exception_none): Don't define.
4612         (struct catcher) <exception>: Update.
4613         * cli/cli-interp.c (safe_execute_command): Update.
4614         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4615
4616 2019-04-25  Ali Tamur  <tamur@google.com>
4617
4618         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4619         (read_attribute_value): Likewise.
4620         (dwarf2_read_addr_index): Update comment.
4621         (read_str_index): Add DW_FORM_strx.
4622         (dwarf2_string_attr): Likewise.
4623         (dwarf2_const_value_attr): Likewise.
4624         (dump_die_shallow): Likewise.
4625         (dwarf2_fetch_constant_bytes): Likewise.
4626         (skip_form_bytes): Likewise.
4627         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4628
4629 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4630
4631         PR corefiles/11608
4632         PR corefiles/18187
4633         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4634         OFFSET.  Verify if current mapping contains an ELF header.
4635         (linux_find_memory_regions_full): Adjust call to
4636         dump_mapping_p.
4637
4638 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4639             Kang Li <kanglictf@gmail.com>
4640
4641         PR gdb/21600
4642
4643         * dwarf2-frame.c (read_initial_length): Be consistent about using
4644         unsigned representation of length.
4645         (decode_frame_entry_1): Likewise.  Check for wraparound of
4646         end pointer as well as buffer overflow.
4647
4648 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4649
4650         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4651         "vq".
4652
4653 2019-04-24  Tom Tromey  <tromey@adacore.com>
4654
4655         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4656
4657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4658
4659         * s12z-tdep.c (s12z_unwind_pc): Delete.
4660         (s12z_unwind_sp): Delete.
4661         (s12z_gdbarch_init): Don't register deleted functions with
4662         gdbarch.
4663
4664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * rl78-tdep.c (rl78_unwind_sp): Delete.
4667         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4668
4669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4672         (xstormy16_unwind_pc): Delete.
4673         (xstormy16_dummy_id): Delete.
4674         (xstormy16_gdbarch_init): Don't register deleted functions with
4675         gdbarch.
4676
4677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4678
4679         * vax-tdep.c (vax_unwind_pc): Delete.
4680         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4681
4682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4683
4684         * v850-tdep.c (v850_unwind_sp): Delete.
4685         (v850_unwind_pc): Delete.
4686         (v850_dummy_id): Delete.
4687         (v850_gdbarch_init): Don't register deleted functions with
4688         gdbarch.
4689
4690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4693         (tilegx_unwind_pc): Delete.
4694         (tilegx_unwind_dummy_id): Delete.
4695         (tilegx_gdbarch_init): Don't register deleted functions with
4696         gdbarch.
4697
4698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4701         (tic6x_dummy_id): Delete.
4702         (tic6x_gdbarch_init): Don't register deleted functions with
4703         gdbarch.
4704
4705 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4706
4707         * sparc-tdep.c (sparc_unwind_pc): Delete.
4708         (sparc32_gdbarch_init): Don't register deleted function with
4709         gdbarch.
4710
4711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4712
4713         * sh-tdep.c (sh_unwind_sp): Delete.
4714         (sh_unwind_pc): Delete.
4715         (sh_dummy_id): Delete.
4716         (sh_gdbarch_init): Don't register deleted functions with
4717         gdbarch.
4718
4719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4720
4721         * score-tdep.c (score_unwind_sp): Delete.
4722         (score_unwind_pc): Delete.
4723         (score_dummy_id): Delete.
4724         (score_gdbarch_init): Don't register deleted functions with
4725         gdbarch.
4726
4727 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4728
4729         * rx-tdep.c (rx_unwind_pc): Delete.
4730         (rx_unwind_sp): Delete.
4731         (rx_dummy_id): Delete.
4732         (rx_gdbarch_init): Don't register deleted functions with
4733         gdbarch.  Update comment.
4734
4735 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4736
4737         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4738         (rs6000_dummy_id): Delete.
4739         (rs6000_gdbarch_init): Don't register deleted functions with
4740         gdbarch.
4741
4742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * or1k-tdep.c (or1k_dummy_id): Delete.
4745         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4746
4747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4748
4749         * nios2-tdep.c (nios2_dummy_id): Delete.
4750         (nios2_unwind_sp): Delete.
4751         (nios2_gdbarch_init): Don't register deleted functions with
4752         gdbarch.
4753
4754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4755
4756         * nds32-tdep.c (nds32_dummy_id): Delete.
4757         (nds32_unwind_pc): Delete.
4758         (nds32_unwind_sp): Delete.
4759         (nds32_gdbarch_init): Don't register deleted functions with
4760         gdbarch.
4761
4762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4763
4764         * msp430-tdep.c (msp430_unwind_pc): Delete.
4765         (msp430_unwind_sp): Delete.
4766         (msp430_dummy_id): Delete.
4767         (msp430_gdbarch_init): Don't register deleted functions with
4768         gdbarch.
4769
4770 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * moxie-tdep.c (moxie_unwind_sp): Delete.
4773         (moxie_unwind_pc): Delete.
4774         (moxie_dummy_id): Delete.
4775         (moxie_gdbarch_init): Don't register deleted functions with
4776         gdbarch.
4777
4778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4781         (mn10300_unwind_pc): Delete.
4782         (mn10300_unwind_sp): Delete.
4783         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4784         mn10300_unwind_sp.
4785         (mn10300_frame_unwind_init): Don't register deleted functions with
4786         gdbarch.
4787
4788 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4789
4790         * mep-tdep.c (mep_unwind_pc): Delete.
4791         (mep_unwind_sp): Delete.
4792         (mep_dummy_id): Delete.
4793         (mep_gdbarch_init): Don't register deleted functions with
4794         gdbarch.
4795
4796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4799         (m68hc11_unwind_sp): Delete.
4800         (m68hc11_gdbarch_init): Don't register deleted functions with
4801         gdbarch.
4802
4803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * m32r-tdep.c (m32r_unwind_sp): Delete.
4806         (m32r_unwind_pc): Delete.
4807         (m32r_dummy_id): Delete.
4808         (m32r_gdbarch_init): Don't register deleted functions with
4809         gdbarch.
4810
4811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4812
4813         * m32c-tdep.c (m32c_unwind_pc): Delete.
4814         (m32c_unwind_sp): Delete.
4815         (m32c_dummy_id): Delete.
4816         (m32c_gdbarch_init): Don't register deleted functions with
4817         gdbarch.
4818
4819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4822         (lm32_unwind_pc): Delete.
4823         (lm32_dummy_id): Delete.
4824         (lm32_gdbarch_init): Don't register deleted functions with
4825         gdbarch.
4826
4827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4828
4829         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4830         (iq2000_unwind_pc): Delete.
4831         (iq2000_dummy_id): Delete.
4832         (iq2000_gdbarch_init): Don't register deleted functions with
4833         gdbarch.
4834
4835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4836
4837         * nds32-tdep.c (nds32_type_align): Delete.
4838         (nds32_push_dummy_call): Use type_align instead.
4839
4840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * arm-tdep.c (arm_type_align): Only handle vector override case.
4843         (arm_push_dummy_call): Use type_align.
4844         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4845
4846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4847
4848         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4849         case.
4850         (pass_on_stack): Use type_align.
4851         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4852         function.
4853
4854 2019-04-23  Tom Tromey  <tromey@adacore.com>
4855
4856         * dwarf2read.c (line_header::file_name_at): Remove unused
4857         overload.
4858
4859 2019-04-23  Tom de Vries  <tdevries@suse.de>
4860
4861         PR gdb/24438
4862         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4863         invocation.
4864
4865
4866 2019-03-27  Ali Tamur  <tamur@google.com>
4867
4868         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4869         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4870         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4871         (dwarf_expr_context::get_addr_index): Likewise
4872         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4873         (symbol_needs_eval_context::get_addr_index): Likewise
4874         (disassemble_dwarf_expression): Add DW_OP_addrx
4875         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4876         (read_cutu_die_from_dwo): Update comment
4877         (skip_one_die): Add DW_FORM_addrx
4878         (read_attribute_value): Likewise
4879         (var_decode_location): Add DW_OP_addrx
4880         (dwarf2_const_value_attr): Add DW_FORM_addrx
4881         (dump_die_shallow): Likewise
4882         (dwarf2_fetch_constant_bytes): Likewise
4883         (decode_locdesc): Add DW_OP_addrx
4884         (skip_form_bytes): Add DW_FORM_addrx
4885
4886 2019-04-22  Ali Tamur  <tamur@google.com>
4887
4888         * MAINTAINERS (Write After Approval): Add self.
4889
4890 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4891
4892         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4893         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4894         (open_symbol_file_object): Likewise.
4895         (svr4_default_sos): Add info parameter.
4896         (svr4_read_so_list): Likewise.
4897         (svr4_current_sos_direct): Adjust functions calls to pass down
4898         info.
4899         (svr4_current_sos_1): Add info parameter.
4900         (svr4_current_sos): Call get_svr4_info, pass info down to
4901         svr4_current_sos_1.
4902         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4903         get_svr4_info.
4904         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4905         get_svr4_info.
4906         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4907         to get_svr4_info.
4908         (probes_table_remove_objfile_probes): Likewise.
4909         (register_solib_event_probe): Add info parameter.
4910         (solist_update_incremental): Pass info parameter down to
4911         svr4_read_so_list.
4912         (disable_probes_interface): Add info parameter.
4913         (svr4_handle_solib_event): Pass current_program_space to
4914         get_svr4_info.  Adjust disable_probes_interface cleanup.
4915         (svr4_create_probe_breakpoints): Add info parameter, pass it
4916         down to register_solib_event_probe.
4917         (svr4_create_solib_event_breakpoints): Add info parameter,
4918         pass it down to svr4_create_probe_breakpoints.
4919         (enable_break): Pass info down to
4920         svr4_create_solib_event_breakpoints.
4921         (svr4_solib_create_inferior_hook): Pass current_program_space to
4922         get_svr4_info.
4923         (svr4_clear_solib): Likewise.
4924
4925 2019-04-22  Pedro Alves  <palves@redhat.com>
4926
4927         * solib-svr4.c (svr4_free_objfile_observer): New.
4928         (probe_and_action::objfile): New field.
4929         (probes_table_htab_remove_objfile_probes)
4930         (probes_table_remove_objfile_probes): New functions.
4931         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4932         in the new probe_and_action.  Don't store the probe in 'lookup'.
4933         (svr4_create_probe_breakpoints): Pass objfile to
4934         register_solib_event_probe.
4935         (_initialize_svr4_solib): Register a free_objfile observer.
4936
4937 2019-04-19  Tom Tromey  <tom@tromey.com>
4938
4939         * common/queue.h: Remove.
4940
4941 2019-04-19  Tom Tromey  <tom@tromey.com>
4942
4943         * event-loop.c: Don't include "common/queue.h".
4944
4945 2019-04-19  Tom Tromey  <tom@tromey.com>
4946
4947         * remote.c (remote_target): Use delete.
4948         * remote-notif.h: Include <list>, not "common/queue.h".
4949         (notif_client_p): Remove typedef.
4950         (remote_notif_state): Add constructor, destructor, initializer.
4951         <notif_queue>: Now a std::list.
4952         (remote_notif_state_xfree): Don't declare.
4953         * remote-notif.c (remote_notif_process, handle_notification)
4954         (remote_notif_state_allocate): Update.
4955         (~remote_notif_state): Rename from remote_notif_state_xfree.
4956
4957 2019-04-19  Tom Tromey  <tom@tromey.com>
4958
4959         * symfile.c (reread_symbols): Update.
4960         * objfiles.c (objfile_register_static_link)
4961         (objfile_lookup_static_link): Update
4962         (~objfile) Don't delete static_links.
4963         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4964
4965 2019-04-19  Tom Tromey  <tom@tromey.com>
4966
4967         * type-stack.h (struct type_stack) <insert>: Constify string.
4968         * type-stack.c (type_stack::insert): Constify string.
4969         * gdbtypes.h (lookup_template_type): Update.
4970         (address_space_name_to_int): Update.
4971         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4972         const.
4973         (lookup_template_type): Make name const.
4974         * c-exp.y: Update rules.
4975         (lex_one_token, classify_name, classify_inner_name)
4976         (c_print_token): Update.
4977         * p-exp.y: Update rules.
4978         (yylex): Update.
4979         * f-exp.y: Update rules.
4980         (yylex): Update.
4981         * d-exp.y: Update rules.
4982         (lex_one_token, classify_name, classify_inner_name): Update.
4983         * parse.c (write_dollar_variable, copy_name): Return std::string.
4984         * parser-defs.h (copy_name): Change return type.
4985         * m2-exp.y: Update rules.
4986         (yylex): Update.
4987         * go-exp.y (lex_one_token): Update.
4988         Update rules.
4989         (classify_unsafe_function, classify_packaged_name)
4990         (classify_name, yylex): Update.
4991
4992 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4993
4994         * configure.ac: add --enable-source-highlight switch.
4995         * configure: Regenerate.
4996         * top.c (print_gdb_version): plumb --enable-source-highlight
4997         status to "show configuration".
4998
4999 2019-04-19  Tom Tromey  <tromey@adacore.com>
5000
5001         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5002         Check ADA_TYPE_P.
5003         (empty_record, ada_template_to_fixed_record_type_1)
5004         (template_to_static_fixed_type)
5005         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5006         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5007         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5008         macros.
5009
5010 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5011
5012         PR symtab/24423:
5013         * source.c (print_source_lines_base): Advance "iter" when a
5014         control character is seen.
5015
5016 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5017
5018         * inferior.h (struct infcall_suspend_state_deleter):
5019         Catch exception in destructor to avoid crash.
5020
5021 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5022
5023         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5024         close to the add_com "shell".
5025
5026 2019-04-18  Tom Tromey  <tromey@adacore.com>
5027
5028         * process-stratum-target.h (class process_stratum_target)
5029         <stratum>: Add "final".
5030
5031 2019-04-17  Tom Tromey  <tromey@adacore.com>
5032
5033         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5034         against nullptr before use.
5035
5036 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5037
5038         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5039
5040 2019-04-17  Jim Wilson  <jimw@sifive.com>
5041             Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5044         code read might fail, assume 4-byte breakpoint in that case.
5045
5046 2019-04-15  Leszek Swirski  <leszeks@google.com>
5047
5048         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5049         rather than a hand-rolled POD check when checking for forced MEMORY
5050         classification.
5051
5052 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5053
5054         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5055         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5056         function.
5057         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5058         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5059         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5060         declaration.
5061
5062 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5063
5064         * aarch64-linux-nat.c
5065         (aarch64_linux_nat_target::thread_architecture): Add override.
5066         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5067         each VQ.
5068
5069 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5070
5071         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5072
5073 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5076         target types of size 96-bits, add some additional comments, and
5077         check that the builtin type we found was the correct size.
5078
5079 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5080
5081         * utils.c (prompt_for_continue): Don't restore the styling at the
5082         end, as applied_style has the wrong value.  This fixes styling in
5083         long lists of file names that are interrupted by the "Continue?"
5084         prompt.
5085
5086 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5089         * c-lang.c (c_language_defn): Likewise.
5090         (cplus_language_defn): Likewise.
5091         (asm_language_defn): Likewise.
5092         (minimal_language_defn): Likewise.
5093         * d-lang.c (d_language_defn): Likewise.
5094         * f-lang.c (f_language_defn): Likewise.
5095         * go-lang.c (go_language_defn): Likewise.
5096         * language.c (unknown_language_defn): Likewise.
5097         (auto_language_defn): Likewise.
5098         * language.h (struct language_defn): Remove la_magic field.
5099         (LANG_MAGIC): Delete.
5100         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5101         * objc-lang.c (objc_language_defn): Likewise.
5102         * opencl-lang.c (opencl_language_defn): Likewise.
5103         * p-lang.c (pascal_language_defn): Likewise.
5104         * rust-lang.c (rust_language_defn): Likewise.
5105
5106 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * riscv-tdep.c (riscv_type_align): New function.
5109         (riscv_type_alignment): Delete.
5110         (riscv_arg_location): Use 'type_align'.
5111         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5112
5113 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5114
5115         * gdbtypes.c (type_align): A struct with no non-static fields also
5116         has alignment of 1.
5117
5118 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5121         component to 0.
5122         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5123         member.
5124         (riscv_struct_info::analyse): New implementation using new
5125         analyse_inner member function.
5126         (riscv_struct_info::field_offset): New member function.
5127         (riscv_struct_info::m_offsets): New member variable.
5128         (riscv_struct_info::analyse_inner): New private member function,
5129         takes the old implementation of riscv_struct_info::analyse but
5130         extended to track field offsets.
5131         (riscv_call_arg_struct): Update the struct folding special cases
5132         to handle cases where empty C++ structs, which are non-zero
5133         length, are found.
5134         (riscv_arg_location): Initialise the length of each location, a
5135         non-zero length now indicates the location is in use.
5136         (riscv_push_dummy_call): Allow for the first location having a
5137         non-zero offset when setting up arguments.
5138         (riscv_return_value): Likewise, but for return values.
5139
5140 2019-04-11  Tom Tromey  <tromey@adacore.com>
5141
5142         * utils.c (internal_vproblem): Make "msg" const.
5143
5144 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5147         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5148         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5149         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5150
5151 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5152
5153         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5154         function.
5155         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5156         of amd64_collect_native_gregset.
5157         (amd64_linux_nat_target::store_registers): Likewise.
5158
5159 2019-04-10  Tom Tromey  <tom@tromey.com>
5160
5161         * symtab.c (lookup_global_symbol_from_objfile)
5162         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5163         * objfiles.h (class separate_debug_iterator): New.
5164         (class separate_debug_range): New.
5165         (struct objfile) <separate_debug_objfiles>: New method.
5166         (objfile_separate_debug_iterate): Don't declare.
5167         * objfiles.c (separate_debug_iterator::operator++): Rename from
5168         objfile_separate_debug_iterate.
5169         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5170         iterator.
5171         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5172         iterator.
5173
5174 2019-04-10  Tom Tromey  <tom@tromey.com>
5175
5176         * symfile.c (reread_symbols): Remove old comment.
5177         * objfiles.c (free_all_objfiles): Fix a typo.
5178
5179 2019-04-10  Tom Tromey  <tom@tromey.com>
5180
5181         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5182         * minsyms.c (lookup_minimal_symbol): Use foreach.
5183         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5184         (lookup_minimal_symbol_solib_trampoline): Likewise.
5185         * symfile.c (reread_symbols): Use foreach.
5186
5187 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5188             Tom Tromey  <tromey@adacore.com>
5189
5190         PR rust/24414:
5191         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5192         (rust_lex_int_test): Change "value" to be LONGEST.
5193         (rust_lex_tests): Add test for long integer literal.
5194
5195 2019-04-09  Tom Tromey  <tromey@adacore.com>
5196
5197         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5198         to bool.
5199         (extended_remote_target::attach): Update.
5200         (remote_target::remote_notice_new_inferior): Update.
5201         (remote_target::add_current_inferior_and_thread): Update.
5202         * inferior.c (exit_inferior_1): Use "false".
5203         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5204
5205 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5206
5207         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5208         the "start" command.
5209
5210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5211
5212         * python/py-inferior.c (infpy_thread_from_thread_handle):
5213         Adjust comments to reflect renaming of thread_from_thread_handle
5214         to thread_from_handle.  Adjust keywords.  Fix type error message.
5215         (inferior_object_methods): Add thread_from_handle.  Retain
5216         thread_from_thread_handle, but mark it as deprecated.
5217
5218 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5219
5220         * gdbthread.h (find_thread_by_handle): Revise declaration.
5221         * thread.c (find_thread_by_handle): Likewise.  Adjust
5222         implementation too.
5223         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5224         support for buffer objects as handles.
5225
5226 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5227
5228         * python/py-infthread.c (thpy_thread_handle): New function.
5229         (thread_object_methods): Register thpy_thread_handle.
5230
5231 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5232
5233         * gdbthread.h (thread_to_thread_handle): Declare.
5234         * thread.c (gdbtypes.h): Include.
5235         (thread_to_thread_handle): New function.
5236
5237         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5238         (target_thread_info_to_thread_handle): Declare.
5239         * target.c (target_thread_info_to_thread_handle): New function.
5240         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5241         * target-delegates.c: Regenerate.
5242
5243         * linux-thread-db.c (class thread_db_target): Add method
5244         thread_info_to_thread_handle.
5245         (thread_db_target::thread_info_to_thread_handle): Define.
5246         * remote.c (class remote_target): Add new method
5247         thread_info_to_thread_handle.
5248         (remote_target::thread_info_to_thread_handle): Define.
5249
5250 2019-04-08  Pedro Alves  <palves@redhat.com>
5251
5252         * common/common-exceptions.c (throw_exception): Don't create
5253         named object to throw; throw directly.
5254         (throw_it): Likewise.  Don't initialize gdb_exception::message
5255         here, with new; pass FMT and AP to the ctor instead.
5256         * common/common-exceptions.h: Include <string>.
5257         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5258         const char *, va_list)): New ctor.  Use std::make_shared.
5259         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5260         errors)): Delete.
5261         (gdb_exception_error::gdb_exception_error(enum errors, const char
5262         *, va_list)): New.
5263         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5264         Add assertion.
5265         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5266         errors)): Delete.
5267         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5268         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5269         Add assertion.
5270
5271 2019-04-08  Tom Tromey  <tom@tromey.com>
5272
5273         * valops.c (value_rtti_indirect_type): Replace throw_exception
5274         with throw.
5275         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5276         with throw.
5277         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5278         throw.
5279         * target.c (target_translate_tls_address): Replace throw_exception
5280         with throw.
5281         * stack.c (frame_apply_command_count): Replace throw_exception
5282         with throw.
5283         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5284         throw.
5285         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5286         with throw.
5287         * rs6000-tdep.c (rs6000_frame_cache)
5288         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5289         * remote.c: Replace throw_exception with throw.
5290         * record-full.c (record_full_message, record_full_wait_1)
5291         (record_full_restore): Replace throw_exception with throw.
5292         * record-btrace.c:
5293         (get_thread_current_frame_id, record_btrace_start_replaying)
5294         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5295         (cmd_record_btrace_start): Replace throw_exception with throw.
5296         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5297         throw.
5298         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5299         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5300         * linespec.c:
5301         (find_linespec_symbols): Replace throw_exception with throw.
5302         * infrun.c (displaced_step_prepare, resume): Replace
5303         throw_exception with throw.
5304         * infcmd.c (post_create_inferior): Replace throw_exception with
5305         throw.
5306         * inf-loop.c (inferior_event_handler): Replace throw_exception
5307         with throw.
5308         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5309         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5310         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5311         (get_prev_frame_always, get_frame_pc_if_available)
5312         (get_frame_address_in_block_if_available, get_frame_language):
5313         Replace throw_exception with throw.
5314         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5315         throw_exception with throw.
5316         * eval.c (fetch_subexp_value, evaluate_var_value)
5317         (evaluate_funcall, evaluate_subexp_standard): Replace
5318         throw_exception with throw.
5319         * dwarf2loc.c (call_site_find_chain)
5320         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5321         Replace throw_exception with throw.
5322         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5323         with throw.
5324         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5325         throw.
5326         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5327         * completer.c (complete_line_internal): Replace throw_exception
5328         with throw.
5329         * compile/compile-object-run.c (compile_object_run): Replace
5330         throw_exception with throw.
5331         * cli/cli-script.c (process_next_line): Replace throw_exception
5332         with throw.
5333         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5334         (btrace_enable, btrace_maint_update_pt_packets): Replace
5335         throw_exception with throw.
5336         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5337         throw_exception with throw.
5338         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5339         throw_exception with throw.
5340         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5341         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5342         * aarch64-tdep.c (aarch64_make_prologue_cache)
5343         (aarch64_make_stub_cache): Replace throw_exception with throw.
5344
5345 2019-04-08  Tom Tromey  <tom@tromey.com>
5346
5347         * common/common-exceptions.c (throw_exception): Rename from
5348         throw_exception_cxx.  Remove old copy.  Make argument const.
5349         (throw_it): Create and throw exception objects directly.
5350         * common/common-exceptions.h (throw_exception): Make argument
5351         const.
5352         (struct gdb_exception_error): Add constructor.
5353         (struct gdb_exception_quit): Add constructor.
5354
5355 2019-04-08  Tom Tromey  <tom@tromey.com>
5356
5357         * common/common-exceptions.h (exception_rethrow): Don't declare.
5358         (TRY_SJLJ): Update comment.
5359         (TRY, CATCH, END_CATCH): Remove.
5360         * common/common-exceptions.c (exception_rethrow): Remove.
5361
5362 2019-04-08  Tom Tromey  <tom@tromey.com>
5363
5364         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5365         Remove.
5366         (gdb_exception_error): Rename from
5367         gdb_exception_RETURN_MASK_ERROR.
5368         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5369         (gdb_quit_bad_alloc): Update.
5370         * aarch64-tdep.c: Update.
5371         * ada-lang.c: Update.
5372         * ada-typeprint.c: Update.
5373         * ada-valprint.c: Update.
5374         * amd64-tdep.c: Update.
5375         * arch-utils.c: Update.
5376         * break-catch-throw.c: Update.
5377         * breakpoint.c: Update.
5378         * btrace.c: Update.
5379         * c-varobj.c: Update.
5380         * cli/cli-cmds.c: Update.
5381         * cli/cli-interp.c: Update.
5382         * cli/cli-script.c: Update.
5383         * common/common-exceptions.c: Update.
5384         * common/new-op.c: Update.
5385         * common/selftest.c: Update.
5386         * compile/compile-c-symbols.c: Update.
5387         * compile/compile-cplus-symbols.c: Update.
5388         * compile/compile-object-load.c: Update.
5389         * compile/compile-object-run.c: Update.
5390         * completer.c: Update.
5391         * corelow.c: Update.
5392         * cp-abi.c: Update.
5393         * cp-support.c: Update.
5394         * cp-valprint.c: Update.
5395         * darwin-nat.c: Update.
5396         * disasm-selftests.c: Update.
5397         * dtrace-probe.c: Update.
5398         * dwarf-index-cache.c: Update.
5399         * dwarf-index-write.c: Update.
5400         * dwarf2-frame-tailcall.c: Update.
5401         * dwarf2-frame.c: Update.
5402         * dwarf2loc.c: Update.
5403         * dwarf2read.c: Update.
5404         * eval.c: Update.
5405         * event-loop.c: Update.
5406         * event-top.c: Update.
5407         * exec.c: Update.
5408         * f-valprint.c: Update.
5409         * fbsd-tdep.c: Update.
5410         * frame-unwind.c: Update.
5411         * frame.c: Update.
5412         * gdbtypes.c: Update.
5413         * gnu-v3-abi.c: Update.
5414         * guile/guile-internal.h: Update.
5415         * guile/scm-block.c: Update.
5416         * guile/scm-breakpoint.c: Update.
5417         * guile/scm-cmd.c: Update.
5418         * guile/scm-disasm.c: Update.
5419         * guile/scm-frame.c: Update.
5420         * guile/scm-lazy-string.c: Update.
5421         * guile/scm-math.c: Update.
5422         * guile/scm-param.c: Update.
5423         * guile/scm-ports.c: Update.
5424         * guile/scm-pretty-print.c: Update.
5425         * guile/scm-symbol.c: Update.
5426         * guile/scm-symtab.c: Update.
5427         * guile/scm-type.c: Update.
5428         * guile/scm-value.c: Update.
5429         * i386-linux-tdep.c: Update.
5430         * i386-tdep.c: Update.
5431         * inf-loop.c: Update.
5432         * infcall.c: Update.
5433         * infcmd.c: Update.
5434         * infrun.c: Update.
5435         * jit.c: Update.
5436         * language.c: Update.
5437         * linespec.c: Update.
5438         * linux-fork.c: Update.
5439         * linux-nat.c: Update.
5440         * linux-tdep.c: Update.
5441         * linux-thread-db.c: Update.
5442         * main.c: Update.
5443         * mi/mi-cmd-break.c: Update.
5444         * mi/mi-cmd-stack.c: Update.
5445         * mi/mi-interp.c: Update.
5446         * mi/mi-main.c: Update.
5447         * objc-lang.c: Update.
5448         * p-valprint.c: Update.
5449         * parse.c: Update.
5450         * ppc-linux-tdep.c: Update.
5451         * printcmd.c: Update.
5452         * python/py-arch.c: Update.
5453         * python/py-breakpoint.c: Update.
5454         * python/py-cmd.c: Update.
5455         * python/py-finishbreakpoint.c: Update.
5456         * python/py-frame.c: Update.
5457         * python/py-framefilter.c: Update.
5458         * python/py-gdb-readline.c: Update.
5459         * python/py-inferior.c: Update.
5460         * python/py-infthread.c: Update.
5461         * python/py-lazy-string.c: Update.
5462         * python/py-linetable.c: Update.
5463         * python/py-objfile.c: Update.
5464         * python/py-param.c: Update.
5465         * python/py-prettyprint.c: Update.
5466         * python/py-progspace.c: Update.
5467         * python/py-record-btrace.c: Update.
5468         * python/py-record.c: Update.
5469         * python/py-symbol.c: Update.
5470         * python/py-type.c: Update.
5471         * python/py-unwind.c: Update.
5472         * python/py-utils.c: Update.
5473         * python/py-value.c: Update.
5474         * python/python.c: Update.
5475         * record-btrace.c: Update.
5476         * record-full.c: Update.
5477         * remote-fileio.c: Update.
5478         * remote.c: Update.
5479         * riscv-tdep.c: Update.
5480         * rs6000-aix-tdep.c: Update.
5481         * rs6000-tdep.c: Update.
5482         * rust-exp.y: Update.
5483         * rust-lang.c: Update.
5484         * s390-tdep.c: Update.
5485         * selftest-arch.c: Update.
5486         * solib-dsbt.c: Update.
5487         * solib-frv.c: Update.
5488         * solib-spu.c: Update.
5489         * solib-svr4.c: Update.
5490         * solib.c: Update.
5491         * sparc64-linux-tdep.c: Update.
5492         * stack.c: Update.
5493         * symfile-mem.c: Update.
5494         * symmisc.c: Update.
5495         * target.c: Update.
5496         * thread.c: Update.
5497         * top.c: Update.
5498         * tracefile-tfile.c: Update.
5499         * tui/tui.c: Update.
5500         * typeprint.c: Update.
5501         * unittests/cli-utils-selftests.c: Update.
5502         * unittests/parse-connection-spec-selftests.c: Update.
5503         * valops.c: Update.
5504         * valprint.c: Update.
5505         * value.c: Update.
5506         * varobj.c: Update.
5507         * windows-nat.c: Update.
5508         * x86-linux-nat.c: Update.
5509         * xml-support.c: Update.
5510
5511 2019-04-08  Tom Tromey  <tom@tromey.com>
5512
5513         * xml-support.c: Use C++ exception handling.
5514         * x86-linux-nat.c: Use C++ exception handling.
5515         * windows-nat.c: Use C++ exception handling.
5516         * varobj.c: Use C++ exception handling.
5517         * value.c: Use C++ exception handling.
5518         * valprint.c: Use C++ exception handling.
5519         * valops.c: Use C++ exception handling.
5520         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5521         handling.
5522         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5523         * typeprint.c: Use C++ exception handling.
5524         * tui/tui.c: Use C++ exception handling.
5525         * tracefile-tfile.c: Use C++ exception handling.
5526         * top.c: Use C++ exception handling.
5527         * thread.c: Use C++ exception handling.
5528         * target.c: Use C++ exception handling.
5529         * symmisc.c: Use C++ exception handling.
5530         * symfile-mem.c: Use C++ exception handling.
5531         * stack.c: Use C++ exception handling.
5532         * sparc64-linux-tdep.c: Use C++ exception handling.
5533         * solib.c: Use C++ exception handling.
5534         * solib-svr4.c: Use C++ exception handling.
5535         * solib-spu.c: Use C++ exception handling.
5536         * solib-frv.c: Use C++ exception handling.
5537         * solib-dsbt.c: Use C++ exception handling.
5538         * selftest-arch.c: Use C++ exception handling.
5539         * s390-tdep.c: Use C++ exception handling.
5540         * rust-lang.c: Use C++ exception handling.
5541         * rust-exp.y: Use C++ exception handling.
5542         * rs6000-tdep.c: Use C++ exception handling.
5543         * rs6000-aix-tdep.c: Use C++ exception handling.
5544         * riscv-tdep.c: Use C++ exception handling.
5545         * remote.c: Use C++ exception handling.
5546         * remote-fileio.c: Use C++ exception handling.
5547         * record-full.c: Use C++ exception handling.
5548         * record-btrace.c: Use C++ exception handling.
5549         * python/python.c: Use C++ exception handling.
5550         * python/py-value.c: Use C++ exception handling.
5551         * python/py-utils.c: Use C++ exception handling.
5552         * python/py-unwind.c: Use C++ exception handling.
5553         * python/py-type.c: Use C++ exception handling.
5554         * python/py-symbol.c: Use C++ exception handling.
5555         * python/py-record.c: Use C++ exception handling.
5556         * python/py-record-btrace.c: Use C++ exception handling.
5557         * python/py-progspace.c: Use C++ exception handling.
5558         * python/py-prettyprint.c: Use C++ exception handling.
5559         * python/py-param.c: Use C++ exception handling.
5560         * python/py-objfile.c: Use C++ exception handling.
5561         * python/py-linetable.c: Use C++ exception handling.
5562         * python/py-lazy-string.c: Use C++ exception handling.
5563         * python/py-infthread.c: Use C++ exception handling.
5564         * python/py-inferior.c: Use C++ exception handling.
5565         * python/py-gdb-readline.c: Use C++ exception handling.
5566         * python/py-framefilter.c: Use C++ exception handling.
5567         * python/py-frame.c: Use C++ exception handling.
5568         * python/py-finishbreakpoint.c: Use C++ exception handling.
5569         * python/py-cmd.c: Use C++ exception handling.
5570         * python/py-breakpoint.c: Use C++ exception handling.
5571         * python/py-arch.c: Use C++ exception handling.
5572         * printcmd.c: Use C++ exception handling.
5573         * ppc-linux-tdep.c: Use C++ exception handling.
5574         * parse.c: Use C++ exception handling.
5575         * p-valprint.c: Use C++ exception handling.
5576         * objc-lang.c: Use C++ exception handling.
5577         * mi/mi-main.c: Use C++ exception handling.
5578         * mi/mi-interp.c: Use C++ exception handling.
5579         * mi/mi-cmd-stack.c: Use C++ exception handling.
5580         * mi/mi-cmd-break.c: Use C++ exception handling.
5581         * main.c: Use C++ exception handling.
5582         * linux-thread-db.c: Use C++ exception handling.
5583         * linux-tdep.c: Use C++ exception handling.
5584         * linux-nat.c: Use C++ exception handling.
5585         * linux-fork.c: Use C++ exception handling.
5586         * linespec.c: Use C++ exception handling.
5587         * language.c: Use C++ exception handling.
5588         * jit.c: Use C++ exception handling.
5589         * infrun.c: Use C++ exception handling.
5590         * infcmd.c: Use C++ exception handling.
5591         * infcall.c: Use C++ exception handling.
5592         * inf-loop.c: Use C++ exception handling.
5593         * i386-tdep.c: Use C++ exception handling.
5594         * i386-linux-tdep.c: Use C++ exception handling.
5595         * guile/scm-value.c: Use C++ exception handling.
5596         * guile/scm-type.c: Use C++ exception handling.
5597         * guile/scm-symtab.c: Use C++ exception handling.
5598         * guile/scm-symbol.c: Use C++ exception handling.
5599         * guile/scm-pretty-print.c: Use C++ exception handling.
5600         * guile/scm-ports.c: Use C++ exception handling.
5601         * guile/scm-param.c: Use C++ exception handling.
5602         * guile/scm-math.c: Use C++ exception handling.
5603         * guile/scm-lazy-string.c: Use C++ exception handling.
5604         * guile/scm-frame.c: Use C++ exception handling.
5605         * guile/scm-disasm.c: Use C++ exception handling.
5606         * guile/scm-cmd.c: Use C++ exception handling.
5607         * guile/scm-breakpoint.c: Use C++ exception handling.
5608         * guile/scm-block.c: Use C++ exception handling.
5609         * guile/guile-internal.h: Use C++ exception handling.
5610         * gnu-v3-abi.c: Use C++ exception handling.
5611         * gdbtypes.c: Use C++ exception handling.
5612         * frame.c: Use C++ exception handling.
5613         * frame-unwind.c: Use C++ exception handling.
5614         * fbsd-tdep.c: Use C++ exception handling.
5615         * f-valprint.c: Use C++ exception handling.
5616         * exec.c: Use C++ exception handling.
5617         * event-top.c: Use C++ exception handling.
5618         * event-loop.c: Use C++ exception handling.
5619         * eval.c: Use C++ exception handling.
5620         * dwarf2read.c: Use C++ exception handling.
5621         * dwarf2loc.c: Use C++ exception handling.
5622         * dwarf2-frame.c: Use C++ exception handling.
5623         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5624         * dwarf-index-write.c: Use C++ exception handling.
5625         * dwarf-index-cache.c: Use C++ exception handling.
5626         * dtrace-probe.c: Use C++ exception handling.
5627         * disasm-selftests.c: Use C++ exception handling.
5628         * darwin-nat.c: Use C++ exception handling.
5629         * cp-valprint.c: Use C++ exception handling.
5630         * cp-support.c: Use C++ exception handling.
5631         * cp-abi.c: Use C++ exception handling.
5632         * corelow.c: Use C++ exception handling.
5633         * completer.c: Use C++ exception handling.
5634         * compile/compile-object-run.c: Use C++ exception handling.
5635         * compile/compile-object-load.c: Use C++ exception handling.
5636         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5637         * compile/compile-c-symbols.c: Use C++ exception handling.
5638         * common/selftest.c: Use C++ exception handling.
5639         * common/new-op.c: Use C++ exception handling.
5640         * cli/cli-script.c: Use C++ exception handling.
5641         * cli/cli-interp.c: Use C++ exception handling.
5642         * cli/cli-cmds.c: Use C++ exception handling.
5643         * c-varobj.c: Use C++ exception handling.
5644         * btrace.c: Use C++ exception handling.
5645         * breakpoint.c: Use C++ exception handling.
5646         * break-catch-throw.c: Use C++ exception handling.
5647         * arch-utils.c: Use C++ exception handling.
5648         * amd64-tdep.c: Use C++ exception handling.
5649         * ada-valprint.c: Use C++ exception handling.
5650         * ada-typeprint.c: Use C++ exception handling.
5651         * ada-lang.c: Use C++ exception handling.
5652         * aarch64-tdep.c: Use C++ exception handling.
5653
5654 2019-04-08  Tom Tromey  <tom@tromey.com>
5655
5656         * xml-support.c (gdb_xml_parser::parse): Update.
5657         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5658         * value.c (show_convenience): Update.
5659         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5660         (test_parse_flags_qcs): Update.
5661         * thread.c (thr_try_catch_cmd): Update.
5662         * target.c (target_translate_tls_address): Update.
5663         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5664         (info_frame_command_core, frame_apply_command_count): Update.
5665         * rust-exp.y (rust_lex_exception_test): Update.
5666         * riscv-tdep.c (riscv_print_one_register_info): Update.
5667         * remote.c (remote_target::enable_btrace): Update.
5668         * record-btrace.c (record_btrace_enable_warn): Update.
5669         * python/py-utils.c (gdbpy_convert_exception): Update.
5670         * printcmd.c (do_one_display, print_variable_and_value): Update.
5671         * mi/mi-main.c (mi_print_exception): Update.
5672         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5673         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5674         * linux-nat.c (linux_nat_target::attach): Update.
5675         * linux-fork.c (class scoped_switch_fork_info): Update.
5676         * infrun.c (displaced_step_prepare): Update.
5677         * infcall.c (call_function_by_hand_dummy): Update.
5678         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5679         * gnu-v3-abi.c (print_one_vtable): Update.
5680         * frame.c (get_prev_frame_always): Update.
5681         * f-valprint.c (info_common_command_for_block): Update.
5682         * exec.c (try_open_exec_file): Update.
5683         * exceptions.c (print_exception, exception_print)
5684         (exception_fprintf, exception_print_same): Update.
5685         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5686         * dwarf-index-cache.c (index_cache::store)
5687         (index_cache::lookup_gdb_index): Update.
5688         * darwin-nat.c (maybe_cache_shell): Update.
5689         * cp-valprint.c (cp_print_value_fields): Update.
5690         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5691         (gcc_cplus_symbol_address): Update.
5692         * compile/compile-c-symbols.c (gcc_convert_symbol)
5693         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5694         * common/selftest.c: Update.
5695         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5696         a std::string.
5697         (exception_try_scope_entry, exception_try_scope_exit): Don't
5698         declare.
5699         (struct exception_try_scope): Remove.
5700         (TRY): Don't use exception_try_scope.
5701         (struct gdb_exception): Add constructor, operator=.
5702         <what>: New method.
5703         (struct gdb_exception_RETURN_MASK_ALL)
5704         (struct gdb_exception_RETURN_MASK_ERROR)
5705         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5706         (struct gdb_quit_bad_alloc): Update.
5707         * common/common-exceptions.c (exception_none): Change
5708         initializer.
5709         (struct catcher) <state, exception>: Initialize inline.
5710         <prev>: Remove member.
5711         (current_catcher): Remove.
5712         (catchers): New global.
5713         (exceptions_state_mc_init): Simplify.
5714         (catcher_pop): Remove.
5715         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5716         (try_scope_depth, exception_try_scope_entry)
5717         (exception_try_scope_exit): Remove.
5718         (throw_exception_sjlj): Update.
5719         (exception_messages, exception_messages_size): Remove.
5720         (throw_it): Simplify.
5721         (gdb_exception_sliced_copy): Remove.
5722         (throw_exception_cxx): Update.
5723         * cli/cli-script.c (script_from_file): Update.
5724         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5725         Update.
5726         * ada-valprint.c (ada_val_print): Update.
5727         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5728         (create_excep_cond_exprs): Update.
5729
5730 2019-04-08  Tom Tromey  <tom@tromey.com>
5731
5732         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5733         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5734         (TRY, CATCH, END_CATCH): Remove some definitions.
5735         * common/common-exceptions.c: Don't use GDB_XCPT.
5736         (catcher_list_size): Remove.
5737         (throw_exception, throw_it): Simplify.
5738
5739 2019-04-05  Tom Tromey  <tom@tromey.com>
5740
5741         Revert the header-sorting patch.
5742         * ft32-tdep.c: Revert.
5743         * frv-tdep.c: Revert.
5744         * frv-linux-tdep.c: Revert.
5745         * frame.c: Revert.
5746         * frame-unwind.c: Revert.
5747         * frame-base.c: Revert.
5748         * fork-child.c: Revert.
5749         * findvar.c: Revert.
5750         * findcmd.c: Revert.
5751         * filesystem.c: Revert.
5752         * filename-seen-cache.h: Revert.
5753         * filename-seen-cache.c: Revert.
5754         * fbsd-tdep.c: Revert.
5755         * fbsd-nat.h: Revert.
5756         * fbsd-nat.c: Revert.
5757         * f-valprint.c: Revert.
5758         * f-typeprint.c: Revert.
5759         * f-lang.c: Revert.
5760         * extension.h: Revert.
5761         * extension.c: Revert.
5762         * extension-priv.h: Revert.
5763         * expprint.c: Revert.
5764         * exec.h: Revert.
5765         * exec.c: Revert.
5766         * exceptions.c: Revert.
5767         * event-top.c: Revert.
5768         * event-loop.c: Revert.
5769         * eval.c: Revert.
5770         * elfread.c: Revert.
5771         * dwarf2read.h: Revert.
5772         * dwarf2read.c: Revert.
5773         * dwarf2loc.c: Revert.
5774         * dwarf2expr.h: Revert.
5775         * dwarf2expr.c: Revert.
5776         * dwarf2-frame.c: Revert.
5777         * dwarf2-frame-tailcall.c: Revert.
5778         * dwarf-index-write.h: Revert.
5779         * dwarf-index-write.c: Revert.
5780         * dwarf-index-common.c: Revert.
5781         * dwarf-index-cache.h: Revert.
5782         * dwarf-index-cache.c: Revert.
5783         * dummy-frame.c: Revert.
5784         * dtrace-probe.c: Revert.
5785         * disasm.h: Revert.
5786         * disasm.c: Revert.
5787         * disasm-selftests.c: Revert.
5788         * dictionary.c: Revert.
5789         * dicos-tdep.c: Revert.
5790         * demangle.c: Revert.
5791         * dcache.h: Revert.
5792         * dcache.c: Revert.
5793         * darwin-nat.h: Revert.
5794         * darwin-nat.c: Revert.
5795         * darwin-nat-info.c: Revert.
5796         * d-valprint.c: Revert.
5797         * d-namespace.c: Revert.
5798         * d-lang.c: Revert.
5799         * ctf.c: Revert.
5800         * csky-tdep.c: Revert.
5801         * csky-linux-tdep.c: Revert.
5802         * cris-tdep.c: Revert.
5803         * cris-linux-tdep.c: Revert.
5804         * cp-valprint.c: Revert.
5805         * cp-support.c: Revert.
5806         * cp-namespace.c: Revert.
5807         * cp-abi.c: Revert.
5808         * corelow.c: Revert.
5809         * corefile.c: Revert.
5810         * continuations.c: Revert.
5811         * completer.h: Revert.
5812         * completer.c: Revert.
5813         * complaints.c: Revert.
5814         * coffread.c: Revert.
5815         * coff-pe-read.c: Revert.
5816         * cli-out.h: Revert.
5817         * cli-out.c: Revert.
5818         * charset.c: Revert.
5819         * c-varobj.c: Revert.
5820         * c-valprint.c: Revert.
5821         * c-typeprint.c: Revert.
5822         * c-lang.c: Revert.
5823         * buildsym.c: Revert.
5824         * buildsym-legacy.c: Revert.
5825         * build-id.h: Revert.
5826         * build-id.c: Revert.
5827         * btrace.c: Revert.
5828         * bsd-uthread.c: Revert.
5829         * breakpoint.h: Revert.
5830         * breakpoint.c: Revert.
5831         * break-catch-throw.c: Revert.
5832         * break-catch-syscall.c: Revert.
5833         * break-catch-sig.c: Revert.
5834         * blockframe.c: Revert.
5835         * block.c: Revert.
5836         * bfin-tdep.c: Revert.
5837         * bfin-linux-tdep.c: Revert.
5838         * bfd-target.c: Revert.
5839         * bcache.c: Revert.
5840         * ax-general.c: Revert.
5841         * ax-gdb.h: Revert.
5842         * ax-gdb.c: Revert.
5843         * avr-tdep.c: Revert.
5844         * auxv.c: Revert.
5845         * auto-load.c: Revert.
5846         * arm-wince-tdep.c: Revert.
5847         * arm-tdep.c: Revert.
5848         * arm-symbian-tdep.c: Revert.
5849         * arm-pikeos-tdep.c: Revert.
5850         * arm-obsd-tdep.c: Revert.
5851         * arm-nbsd-tdep.c: Revert.
5852         * arm-nbsd-nat.c: Revert.
5853         * arm-linux-tdep.c: Revert.
5854         * arm-linux-nat.c: Revert.
5855         * arm-fbsd-tdep.c: Revert.
5856         * arm-fbsd-nat.c: Revert.
5857         * arm-bsd-tdep.c: Revert.
5858         * arch-utils.c: Revert.
5859         * arc-tdep.c: Revert.
5860         * arc-newlib-tdep.c: Revert.
5861         * annotate.h: Revert.
5862         * annotate.c: Revert.
5863         * amd64-windows-tdep.c: Revert.
5864         * amd64-windows-nat.c: Revert.
5865         * amd64-tdep.c: Revert.
5866         * amd64-sol2-tdep.c: Revert.
5867         * amd64-obsd-tdep.c: Revert.
5868         * amd64-obsd-nat.c: Revert.
5869         * amd64-nbsd-tdep.c: Revert.
5870         * amd64-nbsd-nat.c: Revert.
5871         * amd64-nat.c: Revert.
5872         * amd64-linux-tdep.c: Revert.
5873         * amd64-linux-nat.c: Revert.
5874         * amd64-fbsd-tdep.c: Revert.
5875         * amd64-fbsd-nat.c: Revert.
5876         * amd64-dicos-tdep.c: Revert.
5877         * amd64-darwin-tdep.c: Revert.
5878         * amd64-bsd-nat.c: Revert.
5879         * alpha-tdep.c: Revert.
5880         * alpha-obsd-tdep.c: Revert.
5881         * alpha-nbsd-tdep.c: Revert.
5882         * alpha-mdebug-tdep.c: Revert.
5883         * alpha-linux-tdep.c: Revert.
5884         * alpha-linux-nat.c: Revert.
5885         * alpha-bsd-tdep.c: Revert.
5886         * alpha-bsd-nat.c: Revert.
5887         * aix-thread.c: Revert.
5888         * agent.c: Revert.
5889         * addrmap.c: Revert.
5890         * ada-varobj.c: Revert.
5891         * ada-valprint.c: Revert.
5892         * ada-typeprint.c: Revert.
5893         * ada-tasks.c: Revert.
5894         * ada-lang.c: Revert.
5895         * aarch64-tdep.c: Revert.
5896         * aarch64-ravenscar-thread.c: Revert.
5897         * aarch64-newlib-tdep.c: Revert.
5898         * aarch64-linux-tdep.c: Revert.
5899         * aarch64-linux-nat.c: Revert.
5900         * aarch64-fbsd-tdep.c: Revert.
5901         * aarch64-fbsd-nat.c: Revert.
5902         * aarch32-linux-nat.c: Revert.
5903
5904 2019-04-05  Tom Tromey  <tom@tromey.com>
5905
5906         * ft32-tdep.c: Sort headers.
5907         * frv-tdep.c: Sort headers.
5908         * frv-linux-tdep.c: Sort headers.
5909         * frame.c: Sort headers.
5910         * frame-unwind.c: Sort headers.
5911         * frame-base.c: Sort headers.
5912         * fork-child.c: Sort headers.
5913         * findvar.c: Sort headers.
5914         * findcmd.c: Sort headers.
5915         * filesystem.c: Sort headers.
5916         * filename-seen-cache.h: Sort headers.
5917         * filename-seen-cache.c: Sort headers.
5918         * fbsd-tdep.c: Sort headers.
5919         * fbsd-nat.h: Sort headers.
5920         * fbsd-nat.c: Sort headers.
5921         * f-valprint.c: Sort headers.
5922         * f-typeprint.c: Sort headers.
5923         * f-lang.c: Sort headers.
5924         * extension.h: Sort headers.
5925         * extension.c: Sort headers.
5926         * extension-priv.h: Sort headers.
5927         * expprint.c: Sort headers.
5928         * exec.h: Sort headers.
5929         * exec.c: Sort headers.
5930         * exceptions.c: Sort headers.
5931         * event-top.c: Sort headers.
5932         * event-loop.c: Sort headers.
5933         * eval.c: Sort headers.
5934         * elfread.c: Sort headers.
5935         * dwarf2read.h: Sort headers.
5936         * dwarf2read.c: Sort headers.
5937         * dwarf2loc.c: Sort headers.
5938         * dwarf2expr.h: Sort headers.
5939         * dwarf2expr.c: Sort headers.
5940         * dwarf2-frame.c: Sort headers.
5941         * dwarf2-frame-tailcall.c: Sort headers.
5942         * dwarf-index-write.h: Sort headers.
5943         * dwarf-index-write.c: Sort headers.
5944         * dwarf-index-common.c: Sort headers.
5945         * dwarf-index-cache.h: Sort headers.
5946         * dwarf-index-cache.c: Sort headers.
5947         * dummy-frame.c: Sort headers.
5948         * dtrace-probe.c: Sort headers.
5949         * disasm.h: Sort headers.
5950         * disasm.c: Sort headers.
5951         * disasm-selftests.c: Sort headers.
5952         * dictionary.c: Sort headers.
5953         * dicos-tdep.c: Sort headers.
5954         * demangle.c: Sort headers.
5955         * dcache.h: Sort headers.
5956         * dcache.c: Sort headers.
5957         * darwin-nat.h: Sort headers.
5958         * darwin-nat.c: Sort headers.
5959         * darwin-nat-info.c: Sort headers.
5960         * d-valprint.c: Sort headers.
5961         * d-namespace.c: Sort headers.
5962         * d-lang.c: Sort headers.
5963         * ctf.c: Sort headers.
5964         * csky-tdep.c: Sort headers.
5965         * csky-linux-tdep.c: Sort headers.
5966         * cris-tdep.c: Sort headers.
5967         * cris-linux-tdep.c: Sort headers.
5968         * cp-valprint.c: Sort headers.
5969         * cp-support.c: Sort headers.
5970         * cp-namespace.c: Sort headers.
5971         * cp-abi.c: Sort headers.
5972         * corelow.c: Sort headers.
5973         * corefile.c: Sort headers.
5974         * continuations.c: Sort headers.
5975         * completer.h: Sort headers.
5976         * completer.c: Sort headers.
5977         * complaints.c: Sort headers.
5978         * coffread.c: Sort headers.
5979         * coff-pe-read.c: Sort headers.
5980         * cli-out.h: Sort headers.
5981         * cli-out.c: Sort headers.
5982         * charset.c: Sort headers.
5983         * c-varobj.c: Sort headers.
5984         * c-valprint.c: Sort headers.
5985         * c-typeprint.c: Sort headers.
5986         * c-lang.c: Sort headers.
5987         * buildsym.c: Sort headers.
5988         * buildsym-legacy.c: Sort headers.
5989         * build-id.h: Sort headers.
5990         * build-id.c: Sort headers.
5991         * btrace.c: Sort headers.
5992         * bsd-uthread.c: Sort headers.
5993         * breakpoint.h: Sort headers.
5994         * breakpoint.c: Sort headers.
5995         * break-catch-throw.c: Sort headers.
5996         * break-catch-syscall.c: Sort headers.
5997         * break-catch-sig.c: Sort headers.
5998         * blockframe.c: Sort headers.
5999         * block.c: Sort headers.
6000         * bfin-tdep.c: Sort headers.
6001         * bfin-linux-tdep.c: Sort headers.
6002         * bfd-target.c: Sort headers.
6003         * bcache.c: Sort headers.
6004         * ax-general.c: Sort headers.
6005         * ax-gdb.h: Sort headers.
6006         * ax-gdb.c: Sort headers.
6007         * avr-tdep.c: Sort headers.
6008         * auxv.c: Sort headers.
6009         * auto-load.c: Sort headers.
6010         * arm-wince-tdep.c: Sort headers.
6011         * arm-tdep.c: Sort headers.
6012         * arm-symbian-tdep.c: Sort headers.
6013         * arm-pikeos-tdep.c: Sort headers.
6014         * arm-obsd-tdep.c: Sort headers.
6015         * arm-nbsd-tdep.c: Sort headers.
6016         * arm-nbsd-nat.c: Sort headers.
6017         * arm-linux-tdep.c: Sort headers.
6018         * arm-linux-nat.c: Sort headers.
6019         * arm-fbsd-tdep.c: Sort headers.
6020         * arm-fbsd-nat.c: Sort headers.
6021         * arm-bsd-tdep.c: Sort headers.
6022         * arch-utils.c: Sort headers.
6023         * arc-tdep.c: Sort headers.
6024         * arc-newlib-tdep.c: Sort headers.
6025         * annotate.h: Sort headers.
6026         * annotate.c: Sort headers.
6027         * amd64-windows-tdep.c: Sort headers.
6028         * amd64-windows-nat.c: Sort headers.
6029         * amd64-tdep.c: Sort headers.
6030         * amd64-sol2-tdep.c: Sort headers.
6031         * amd64-obsd-tdep.c: Sort headers.
6032         * amd64-obsd-nat.c: Sort headers.
6033         * amd64-nbsd-tdep.c: Sort headers.
6034         * amd64-nbsd-nat.c: Sort headers.
6035         * amd64-nat.c: Sort headers.
6036         * amd64-linux-tdep.c: Sort headers.
6037         * amd64-linux-nat.c: Sort headers.
6038         * amd64-fbsd-tdep.c: Sort headers.
6039         * amd64-fbsd-nat.c: Sort headers.
6040         * amd64-dicos-tdep.c: Sort headers.
6041         * amd64-darwin-tdep.c: Sort headers.
6042         * amd64-bsd-nat.c: Sort headers.
6043         * alpha-tdep.c: Sort headers.
6044         * alpha-obsd-tdep.c: Sort headers.
6045         * alpha-nbsd-tdep.c: Sort headers.
6046         * alpha-mdebug-tdep.c: Sort headers.
6047         * alpha-linux-tdep.c: Sort headers.
6048         * alpha-linux-nat.c: Sort headers.
6049         * alpha-bsd-tdep.c: Sort headers.
6050         * alpha-bsd-nat.c: Sort headers.
6051         * aix-thread.c: Sort headers.
6052         * agent.c: Sort headers.
6053         * addrmap.c: Sort headers.
6054         * ada-varobj.c: Sort headers.
6055         * ada-valprint.c: Sort headers.
6056         * ada-typeprint.c: Sort headers.
6057         * ada-tasks.c: Sort headers.
6058         * ada-lang.c: Sort headers.
6059         * aarch64-tdep.c: Sort headers.
6060         * aarch64-ravenscar-thread.c: Sort headers.
6061         * aarch64-newlib-tdep.c: Sort headers.
6062         * aarch64-linux-tdep.c: Sort headers.
6063         * aarch64-linux-nat.c: Sort headers.
6064         * aarch64-fbsd-tdep.c: Sort headers.
6065         * aarch64-fbsd-nat.c: Sort headers.
6066         * aarch32-linux-nat.c: Sort headers.
6067
6068 2019-04-04  Tom Tromey  <tom@tromey.com>
6069
6070         * varobj.c (varobj_create): Update.
6071         * rust-exp.y (struct rust_parser) <update_innermost_block,
6072         lookup_symbol>: New methods.
6073         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6074         Rename.
6075         (rust_parser::rust_lookup_type)
6076         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6077         * printcmd.c (display_command, do_one_display): Update.
6078         * parser-defs.h (struct parser_state) <parser_state>: Add
6079         "tracker" parameter.
6080         (block_tracker): New member.
6081         (class innermost_block_tracker) <innermost_block_tracker>: Add
6082         "types" parameter.
6083         <reset>: Remove method.
6084         (innermost_block): Don't declare.
6085         (null_post_parser): Update.
6086         * parse.c (innermost_block): Remove global.
6087         (write_dollar_variable): Update.
6088         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6089         Remove "tracker_types" parameter.
6090         (parse_expression): Add "tracker" parameter.
6091         (parse_expression_for_completion): Update.
6092         (null_post_parser): Add "tracker" parameter.
6093         * p-exp.y: Update rules.
6094         * m2-exp.y: Update rules.
6095         * language.h (struct language_defn) <la_post_parser>: Add
6096         "tracker" parameter.
6097         * go-exp.y: Update rules.
6098         * f-exp.y: Update rules.
6099         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6100         parameter.
6101         * d-exp.y: Update rules.
6102         * c-exp.y: Update rules.
6103         * breakpoint.c (set_breakpoint_condition): Create an
6104         innermost_block_tracker.
6105         (watch_command_1): Likewise.
6106         * ada-lang.c (resolve): Add "tracker" parameter.
6107         (resolve_subexp): Likewise.
6108         * ada-exp.y (write_var_from_sym): Update.
6109
6110 2019-04-04  Tom Tromey  <tom@tromey.com>
6111
6112         * type-stack.h: New file.
6113         * type-stack.c: New file.
6114         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6115         type-stack.h.
6116         (insert_into_type_stack, insert_type, push_type, push_type_int)
6117         (insert_type_address_space, pop_type, pop_type_int)
6118         (pop_typelist, pop_type_stack, append_type_stack)
6119         (push_type_stack, get_type_stack, push_typelist)
6120         (follow_type_instance_flags, follow_types): Don't declare.
6121         * parse.c (type_stack): Remove global.
6122         (parse_exp_in_context): Update.
6123         (insert_into_type_stack, insert_type, push_type, push_type_int)
6124         (insert_type_address_space, pop_type, pop_type_int)
6125         (pop_typelist, pop_type_stack, append_type_stack)
6126         (push_type_stack, get_type_stack, push_typelist)
6127         (follow_type_instance_flags, follow_types): Remove (moved to
6128         type-stack.c).
6129         * f-exp.y (type_stack): New global.
6130         Update rules.
6131         (push_kind_type, f_parse): Update.
6132         * d-exp.y (type_stack): New global.
6133         Update rules.
6134         (d_parse): Update.
6135         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6136         Update rules.
6137         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6138         (HFILES_NO_SRCDIR): Add type-stack.h.
6139
6140 2019-04-04  Tom Tromey  <tom@tromey.com>
6141
6142         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6143         (rust_parser::convert_ast_to_expression, rust_parse)
6144         (rust_lex_test_completion, rust_lex_tests): Update.
6145         * parser-defs.h (struct expr_completion_state): New.
6146         (struct parser_state) <parser_state>: Add completion parameter.
6147         <mark_struct_expression, mark_completion_tag>: New methods.
6148         <parse_completion, m_completion_state>: New members.
6149         (prefixify_expression, null_post_parser): Update.
6150         (mark_struct_expression, mark_completion_tag): Don't declare.
6151         * parse.c (parse_completion, expout_last_struct)
6152         (expout_tag_completion_type, expout_completion_name): Remove
6153         globals.
6154         (parser_state::mark_struct_expression)
6155         (parser_state::mark_completion_tag): Now methods.
6156         (prefixify_expression): Add last_struct parameter.
6157         (prefixify_subexp): Likewise.
6158         (parse_exp_1): Update.
6159         (parse_exp_in_context): Add cstate parameter.  Update.
6160         (parse_expression_for_completion): Create an
6161         expr_completion_state.
6162         (null_post_parser): Add "completion" parameter.
6163         * p-exp.y: Update rules.
6164         (yylex): Update.
6165         * language.h (struct language_defn) <la_post_parser>: Add
6166         "completing" parameter.
6167         * go-exp.y: Update rules.
6168         (lex_one_token): Update.
6169         * expression.h (parse_completion): Don't declare.
6170         * d-exp.y: Update rules.
6171         (lex_one_token): Update rules.
6172         * c-exp.y: Update rules.
6173         (lex_one_token): Update.
6174         * ada-lang.c (resolve): Add "parse_completion" parameter.
6175         (resolve_subexp): Likewise.
6176         (ada_resolve_function): Likewise.
6177
6178 2019-04-04  Tom Tromey  <tom@tromey.com>
6179
6180         * parser-defs.h (struct parser_state) <start_arglist,
6181         end_arglist>: New methods.
6182         <arglist_len, m_funcall_chain>: New members.
6183         (arglist_len, start_arglist, end_arglist): Don't declare.
6184         * parse.c (arglist_len, funcall_chain): Remove global.
6185         (start_arglist, end_arglist): Remove functions.
6186         (parse_exp_in_context): Update.
6187         * p-exp.y: Update rules.
6188         * m2-exp.y: Update rules.
6189         * go-exp.y: Update rules.
6190         * f-exp.y: Update rules.
6191         * d-exp.y: Update rules.
6192         * c-exp.y: Update rules.
6193
6194 2019-04-04  Tom Tromey  <tom@tromey.com>
6195
6196         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6197         lex_operator, push_back>: New methods.
6198         Update all rules.
6199         (rust_parser::lex_hex, lex_escape): Rename and update.
6200         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6201         (rust_parser::lex_operator): Rename and update.
6202         (rust_parser::lex_number, rustyylex, rustyyerror)
6203         (rust_lex_test_init, rust_lex_test_sequence)
6204         (rust_lex_test_push_back, rust_lex_tests): Update.
6205         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6206         parameter.
6207         <lexptr, prev_lexptr>: New members.
6208         (lexptr, prev_lexptr): Don't declare.
6209         * parse.c (lexptr, prev_lexptr): Remove globals.
6210         (parse_exp_in_context): Update.
6211         * p-exp.y (yylex, yyerror): Update.
6212         * m2-exp.y (parse_number, yylex, yyerror): Update.
6213         * go-exp.y (lex_one_token, yyerror): Update.
6214         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6215         * d-exp.y (lex_one_token, yyerror): Update.
6216         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6217         (lex_one_token, yyerror): Update.
6218         * ada-lex.l (YY_INPUT): Update.
6219         (rewind_to_char): Update.
6220         * ada-exp.y (yyerror): Update.
6221
6222 2019-04-04  Tom Tromey  <tom@tromey.com>
6223
6224         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6225         * parser-defs.h (struct parser_state) <parser_state>: Add new
6226         parameter.
6227         <comma_terminates>: New member.
6228         (comma_terminates): Don't declare global.
6229         * parse.c (comma_terminates): Remove global.
6230         (parse_exp_in_context): Update.
6231         * p-exp.y (yylex): Update.
6232         * m2-exp.y (yylex): Update.
6233         * go-exp.y (lex_one_token): Update.
6234         * f-exp.y (yylex): Update.
6235         * d-exp.y (lex_one_token): Update.
6236         * c-exp.y (lex_one_token): Update.
6237         * ada-lex.l: Update.
6238
6239 2019-04-04  Tom Tromey  <tom@tromey.com>
6240
6241         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6242         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6243         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6244         * parser-defs.h (paren_depth): Don't declare.
6245         * parse.c (paren_depth): Remove global.
6246         (parse_exp_in_context): Update.
6247         * p-exp.y (paren_depth): New global.
6248         (pascal_parse): Initialize it.
6249         * m2-exp.y (paren_depth): New global.
6250         (m2_parse): Initialize it.
6251         * go-exp.y (paren_depth): New global.
6252         (go_parse): Initialize it.
6253         * f-exp.y (paren_depth): New global.
6254         (f_parse): Initialize it.
6255         * d-exp.y (paren_depth): New global.
6256         (d_parse): Initialize it.
6257         * c-exp.y (paren_depth): New global.
6258         (c_parse): Initialize it.
6259         * ada-lex.l (paren_depth): New global.
6260         (lexer_init): Initialize it.
6261
6262 2019-04-04  Tom Tromey  <tom@tromey.com>
6263
6264         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6265         (rust_parser::convert_ast_to_type)
6266         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6267         * parser-defs.h (struct parser_state) <parser_state>: Add
6268         parameters.  Initialize new members.
6269         <expression_context_block, expression_context_pc>: New members.
6270         * parse.c (expression_context_block, expression_context_pc):
6271         Remove globals.
6272         (parse_exp_in_context): Update.
6273         * p-exp.y: Update all rules.
6274         (yylex): Update.
6275         * m2-exp.y: Update all rules.
6276         (yylex): Update.
6277         * go-exp.y (yylex): Update.
6278         * f-exp.y (yylex): Update.
6279         * d-exp.y: Update all rules.
6280         (yylex): Update.
6281         * c-exp.y: Update all rules.
6282         (lex_one_token, classify_name, yylex, c_parse): Update.
6283         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6284
6285 2019-04-04  Tom Tromey  <tom@tromey.com>
6286
6287         * gdbarch.h, gdbarch.c: Rebuild.
6288         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6289         * stap-probe.h:
6290         (struct stap_parse_info): Replace "parser_state" with
6291         "expr_builder".
6292         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6293         (parser_state): New class.
6294         * parse.c (expr_builder): Rename.
6295         (expr_builder::release): Rename.
6296         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6297         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6298         (write_exp_elt_longcst, write_exp_elt_floatcst)
6299         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6300         (write_exp_string_vector, write_exp_bitstring)
6301         (write_exp_msymbol, mark_struct_expression)
6302         (write_dollar_variable)
6303         (insert_type_address_space, increase_expout_size): Replace
6304         "parser_state" with "expr_builder".
6305         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6306         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6307         "parser_state" with "expr_builder".
6308
6309 2019-04-04  Tom Tromey  <tom@tromey.com>
6310
6311         * rust-exp.y: Replace "parse_language" with method call.
6312         * p-exp.y:
6313         (yylex): Replace "parse_language" with method call.
6314         * m2-exp.y:
6315         (yylex): Replace "parse_language" with method call.
6316         * go-exp.y (classify_name): Replace "parse_language" with method
6317         call.
6318         * f-exp.y (yylex): Replace "parse_language" with method call.
6319         * d-exp.y (lex_one_token): Replace "parse_language" with method
6320         call.
6321         * c-exp.y:
6322         (lex_one_token, classify_name, yylex): Replace "parse_language"
6323         with method call.
6324         * ada-exp.y (find_primitive_type, type_char)
6325         (type_system_address): Replace "parse_language" with method call.
6326
6327 2019-04-04  Tom Tromey  <tom@tromey.com>
6328
6329         * rust-exp.y: Replace "parse_gdbarch" with method call.
6330         * parse.c (write_dollar_variable, insert_type_address_space):
6331         Replace "parse_gdbarch" with method call.
6332         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6333         call.
6334         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6335         call.
6336         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6337         "parse_gdbarch" with method call.
6338         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6339         with method call.
6340         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6341         "parse_gdbarch" with method call.
6342         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6343         "parse_gdbarch" with method call.
6344         * c-exp.y (parse_type, parse_number, classify_name): Replace
6345         "parse_gdbarch" with method call.
6346         * ada-lex.l: Replace "parse_gdbarch" with method call.
6347         * ada-exp.y (parse_type, find_primitive_type, type_char)
6348         (type_system_address): Replace "parse_gdbarch" with method call.
6349
6350 2019-04-04  Tom Tromey  <tom@tromey.com>
6351
6352         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6353         * stap-probe.c (stap_parse_argument): Update.
6354         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6355         initial_size parameter.
6356         * rust-exp.y (rust_lex_tests): Update.
6357         * parse.c (parser_state): Update.
6358         (parse_exp_in_context): Update.
6359         * parser-defs.h (struct parser_state) <parser_state>: Remove
6360         "initial_size" parameter.
6361
6362 2019-04-04  Tom Tromey  <tom@tromey.com>
6363
6364         * parser-defs.h (increase_expout_size): Don't declare.
6365         * parse.c (increase_expout_size): Now static.
6366
6367 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6368
6369         * gnu-nat.c (gnu_nat_target::wait): Fix
6370         target_waitstatus_to_string call.
6371
6372 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6373
6374         * eval.c (evaluate_subexp_standard): Handle internal functions
6375         during Fortran function call handling.
6376
6377 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * NEWS: Mention new internal functions.
6380         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6381         (read_base_type): Use dwarf2_init_complex_target_type.
6382         * value.c (creal_internal_fn): New function.
6383         (cimag_internal_fn): New function.
6384         (_initialize_values): Register new internal functions.
6385
6386 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6387
6388         * infrun.c (stop_all_threads): If debug_infrun, always
6389         trace the wait status after wait_one, using
6390         target_waitstatus_to_string and target_pid_to_str.
6391         (handle_inferior_event): Replace various trace of
6392         wait status kind by a single trace.
6393         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6394         wait status kind image by target_waitstatus_to_string.
6395         * target/waitstatus.c (target_waitstatus_to_string): Fix
6396         obsolete comment.
6397
6398 2019-04-01  Tom Tromey  <tromey@adacore.com>
6399
6400         PR symtab/23331:
6401         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6402
6403 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6404             Pedro Alves  <palves@redhat.com>
6405
6406         * top.c (quit_force): Call 'finalize_values'.
6407         * value.c (finalize_values): New function.
6408         * value.h (finalize_values): Declare.
6409
6410 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6411
6412         * NEWS: Announce $_gdb_major and $_gdb_minor.
6413
6414         * top.c (init_gdb_version_vars): New function.
6415         (gdb_init): Call init_gdb_version_vars.
6416
6417 2019-03-29  Tom Tromey  <tromey@adacore.com>
6418
6419         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6420         help text.  Remove dead code.
6421
6422 2019-03-29  Keith Seitz  <keiths@redhat.com>
6423
6424         From Siddhesh Poyarekar:
6425         * f-lang.h (f77_get_upperbound): Return LONGEST.
6426         (f77_get_lowerbound): Likewise.
6427         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6428         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6429         print them.
6430         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6431         plongest to format print it.
6432         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6433         (f77_get_upperbound): Likewise.
6434         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6435         LOWER_BOUND to LONGEST.
6436         (f77_create_arrayprint_offset_tbl): Likewise.
6437
6438 2019-03-29  Keith Seitz  <keiths@redhat.com>
6439
6440         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6441         %s/pulongest for TYPE_LENGTH instead of %d in format
6442         strings.
6443         * ada-typerint.c (ada_print_type): Likewise.
6444         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6445         * compile/compile-c-support.c (generate_register_struct): Likewise.
6446         * gdbtypes.c (recursive_dump_type): Likewise.
6447         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6448         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6449         instead of %d in format strings.
6450         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6451         to std::min to ULONGEST.
6452         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6453         instead of %d in format strings.
6454         * tracepoint.c (info_scope_command): Likewise.
6455         * typeprint.c (print_offset_data::update)
6456         (print_offset_data::finish): Likewise.
6457         * xtensa-tdep.c (xtensa_store_return_value)
6458         (xtensa_push_dummy_call): Likewise.
6459
6460 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6461
6462         * windows-nat.c (display_selector): Fixed format specifications
6463         for 64-bit Cygwin.
6464
6465 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6466
6467         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6468
6469 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6470
6471         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6472         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6473         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6474         (nios2_linux_init_abi): Install it.
6475
6476 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6477
6478         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6479
6480 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6481
6482         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6483
6484 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6485             Tom Tromey  <tromey@adacore.com>
6486
6487         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6488
6489 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6490
6491         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6492         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6493         method to compute the bounds of range types. Also print "[evaluated]"
6494         if the bounds' values come from a dynamic evaluation.
6495
6496 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6497
6498         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6499         whitespace when pretty printing is on.
6500
6501 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6502
6503         * ppc-linux-nat.c: Add include.
6504
6505 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6506
6507         * NEWS: Mention AArch64 Pointer Authentication.
6508
6509 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6510
6511         * arm-linux-nat.c: Add include.
6512
6513 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6514
6515         * source-cache.c (source_cache::get_source_lines): Re-read
6516         fullname after calling open_source_file.
6517
6518 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6519
6520         * NEWS: Mention TLS support for FreeBSD.
6521
6522 2019-03-25  Tom Tromey  <tromey@adacore.com>
6523
6524         * minsyms.c (BUNCH_SIZE): Update comment.
6525         (~minimal_symbol_reader): Remove old comment.
6526         (compact_minimal_symbols): Update comment.
6527         (minimal_symbol_reader::install): Remove old comment.  Update
6528         other comments.
6529
6530 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6531
6532         * s390-linux-nat.c: Add include.
6533
6534 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6535
6536         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6537         Call linux_get_hwcap.
6538         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6539         Likewise.
6540         (aarch64_linux_get_hwcap): Remove function.
6541         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6542         declaration.
6543         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6544         linux_get_hwcap.
6545         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6546         * linux-tdep.c (linux_get_hwcap): Add function.
6547         (linux_get_hwcap2): Likewise.
6548         * linux-tdep.h (linux_get_hwcap): Add declaration.
6549         (linux_get_hwcap2): Likewise.
6550         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6551         (ppc_linux_get_hwcap2): Likewise.
6552         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6553         linux_get_hwcap.
6554         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6555         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6556         (ppc_linux_nat_target::read_description): Likewise.
6557         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6558         * s390-linux-nat.c: Likewise.
6559         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6560
6561 2019-03-24  Tom Tromey  <tom@tromey.com>
6562
6563         * ada-lang.c (standard_lookup): Simplify initialization.
6564         (ada_lookup_symbol_nonlocal): Simplify return.
6565         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6566         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6567         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6568         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6569         initialization.
6570         * solib.c (solib_global_lookup): Simplify.
6571         * symtab.c (null_block_symbol): Remove.
6572         (symbol_cache_lookup): Simplify returns.
6573         (lookup_language_this): Simplify returns.
6574         (lookup_symbol_aux): Simplify return.
6575         (lookup_local_symbol): Simplify returns.
6576         (lookup_global_symbol_from_objfile): Simplify return.
6577         (lookup_symbol_in_objfile_symtabs)
6578         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6579         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6580         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6581         * cp-namespace.c (cp_lookup_bare_symbol)
6582         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6583         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6584         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6585         (cp_lookup_symbol_via_imports): Simplify initialization.
6586         (find_symbol_in_baseclass): Likewise.
6587         * symtab.h (null_block_symbol): Remove.
6588         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6589         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6590         (d_lookup_symbol_module): Likewise.
6591         (find_symbol_in_baseclass): Simplify initialization.
6592
6593 2019-03-24  Tom Tromey  <tom@tromey.com>
6594
6595         * expression.h: Don't include symtab.h.
6596         (struct block): Forward declare.
6597
6598 2019-03-24  Tom Tromey  <tom@tromey.com>
6599
6600         * c-exp.y (typebase): Remove casts.
6601         * gdbtypes.c (lookup_unsigned_typename, )
6602         (lookup_signed_typename): Remove cast.
6603         * eval.c (parse_to_comma_and_eval): Remove cast.
6604         * parse.c (write_dollar_variable): Remove cast.
6605         * block.h (struct block) <superblock>: Now const.
6606         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6607         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6608         (map_block): Make "block" const.
6609         * symfile.h (struct quick_symbol_functions)
6610         <map_matching_symbols>: Constify block argument to "callback".
6611         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6612         const.
6613         (find_pc_sect_compunit_symtab): Make "b" const.
6614         (find_symbol_at_address): Likewise.
6615         (search_symbols): Likewise.
6616         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6617         (dw2_debug_names_lookup_symbol): Likewise.
6618         (dw2_map_matching_symbols): Update.
6619         * p-valprint.c (pascal_val_print): Remove "block".
6620         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6621         (aux_add_nonlocal_symbols): Make "block" const.
6622         (resolve_subexp): Remove cast.
6623         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6624         const.
6625         (iterate_over_file_blocks): Likewise.
6626         * f-exp.y (%union) <bval>: Remove.
6627         * coffread.c (patch_opaque_types): Make "b" const.
6628         * spu-tdep.c (spu_catch_start): Make "block" const.
6629         * c-valprint.c (print_unpacked_pointer): Remove "block".
6630         * symmisc.c (dump_symtab_1): Make "b" const.
6631         (block_depth): Make "block" const.
6632         * d-exp.y (%union) <bval>: Remove.
6633         * cp-support.h (cp_lookup_rtti_type): Update.
6634         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6635         * psymtab.c (psym_lookup_symbol): Make "block" const.
6636         (maintenance_check_psymtabs): Make "b" const.
6637         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6638         (enumerate_locals, enumerate_args): Update.
6639         * python/py-symtab.c (stpy_global_block): Make "block" const.
6640         (stpy_static_block): Likewise.
6641         * inline-frame.c (block_starting_point_at): Make "new_block"
6642         const.
6643         * block.c (find_block_in_blockvector): Make return type const.
6644         (blockvector_for_pc_sect): Make "b" const.
6645         (find_block_in_blockvector): Make "b" const.
6646
6647 2019-03-23  Tom Tromey  <tom@tromey.com>
6648
6649         * varobj.c (varobj_create): Update.
6650         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6651         * printcmd.c (display_command, do_one_display): Don't reset
6652         innermost_block.
6653         * parser-defs.h (enum innermost_block_tracker_type): Move to
6654         expression.h.
6655         (innermost_block): Update comment.
6656         * parse.c (parse_exp_1): Add tracker_types parameter.
6657         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6658         tracker_types parameter.  Reset innermost_block.
6659         (parse_exp_in_context): Remove.
6660         (parse_expression_for_completion): Update.
6661         * objfiles.c (~objfile): Don't reset expression_context_block or
6662         innermost_block.
6663         * expression.h (enum innermost_block_tracker_type): Move from
6664         parser-defs.h.
6665         (parse_exp_1): Add tracker_types parameter.
6666         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6667         reset innermost_block.
6668
6669 2019-03-23  Tom Tromey  <tom@tromey.com>
6670
6671         * objfiles.h: Include bcache.h.
6672
6673 2019-03-23  Tom Tromey  <tom@tromey.com>
6674
6675         * linespec.c (get_current_search_block): Use
6676         scoped_restore_current_language.
6677         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6678
6679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6680             Jiong Wang  <jiong.wang@arm.com>
6681
6682         * aarch64-linux-tdep.c
6683         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6684         section.
6685         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6686
6687 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6688             Jiong Wang  <jiong.wang@arm.com>
6689
6690         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6691         instructions.
6692         (aarch64_analyze_prologue_test): Add PACIASP test.
6693         (aarch64_prologue_prev_register): Unmask PC value.
6694
6695 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6696             Jiong Wang  <jiong.wang@arm.com>
6697
6698         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6699         (aarch64_dwarf2_prev_register): Unmask PC value.
6700         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6701         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6702         DW_CFA_AARCH64_negate_ra_state.
6703         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6704
6705 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6706             Jiong Wang  <jiong.wang@arm.com>
6707
6708         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6709         registers.
6710         (aarch64_pseudo_register_name): Likewise.
6711         (aarch64_pseudo_register_type): Likewise.
6712         (aarch64_pseudo_register_reggroup_p): Likewise.
6713         (aarch64_gdbarch_init): Add pauth registers.
6714         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6715         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6716         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6717         (struct gdbarch_tdep): Add regnum for ra_state.
6718
6719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6720             Jiong Wang  <jiong.wang@arm.com>
6721
6722         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6723
6724 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6725             Jiong Wang  <jiong.wang@arm.com>
6726
6727         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6728         function.
6729         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6730         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6731         (aarch64_gdbarch_init): Add puth registers.
6732         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6733         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6734         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6735
6736 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6737             Jiong Wang  <jiong.wang@arm.com>
6738
6739         * aarch64-linux-nat.c
6740         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6741         * aarch64-linux-tdep.c
6742         (aarch64_linux_core_read_description): Likewise.
6743         (aarch64_linux_get_hwcap): New function.
6744         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6745         (aarch64_linux_get_hwcap): New declaration.
6746
6747 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6748             Jiong Wang  <jiong.wang@arm.com>
6749
6750         * aarch64-linux-nat.c
6751         (aarch64_linux_nat_target::read_description): Add pauth param.
6752         * aarch64-linux-tdep.c
6753         (aarch64_linux_core_read_description): Likewise.
6754         * aarch64-tdep.c (struct target_desc): Add in pauth.
6755         (aarch64_read_description): Add pauth param.
6756         (aarch64_gdbarch_init): Likewise.
6757         * aarch64-tdep.h (aarch64_read_description): Likewise.
6758         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6759         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6760         * features/Makefile: Add new files.
6761         * features/aarch64-pauth.c: New file.
6762         * features/aarch64-pauth.xml: New file.
6763
6764 2019-03-20  Tom Tromey  <tromey@adacore.com>
6765
6766         * infrun.c (handle_inferior_event): Rename from
6767         handle_inferior_event_1.  Create a scoped_value_mark.
6768         (handle_inferior_event): Remove.
6769
6770 2019-03-19  Tom Tromey  <tromey@adacore.com>
6771
6772         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6773         * infrun.h (print_stop_event): Add "displays" parameter.
6774         * infrun.c (print_stop_event): Add "displays" parameter.
6775
6776 2019-03-19  Pedro Alves  <palves@redhat.com>
6777
6778         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6779         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6780         to -1.  Fix TABs vs spaces.
6781         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6782         * tui/tui-out.h (tui_ui_out) Add intro comments.
6783         <m_line, m_start_of_line>: In-class initialize, and add describing
6784         comment.
6785
6786 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6787
6788         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6789         variable names.
6790         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6791
6792 2019-03-18  Pedro Alves  <palves@redhat.com>
6793             Eli Zaretskii <eliz@gnu.org>
6794
6795         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6796         m_line and m_start_of_line.
6797
6798 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6799
6800         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6801         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6802         it returns a newline.  This fixes a regression in TU mode, whereby
6803         the next line is output on the same screen line as the user input.
6804
6805 2019-03-18  Tom Tromey  <tromey@adacore.com>
6806
6807         * minsyms.c (minimal_symbol_reader::install): Remove call to
6808         obstack_blank.
6809
6810 2019-03-18  Pedro Alves  <palves@redhat.com>
6811
6812         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6813         New globals.
6814         (apply_style): New, factored out from ...
6815         (apply_ansi_escape): ... this.  Handle reverse video mode.
6816         (tui_set_reverse_mode): New function.
6817         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6818         * tui/tui-winsource.c (tui_show_source_line): Use
6819         tui_set_reverse_mode instead of setting A_STANDOUT.
6820         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6821         New setter methods.
6822
6823 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6824
6825         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6826         Handle tabs.
6827
6828 2019-03-18  Tom Tromey  <tromey@adacore.com>
6829
6830         * ada-lang.c (empty_array): Add "high" parameter.
6831         (ada_evaluate_subexp): Update.
6832
6833 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6834
6835         * unittests/string_view-selftests.c: Define
6836         _initialize_string_view_selftests unconditionally.
6837
6838 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6839
6840         PR gdb/24350
6841         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6842
6843 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6844
6845         PR gdb/24351
6846         * windows-nat.c (display_selector): Fix format specifiers.
6847
6848 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6849
6850         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6851         tui_refill_source_window instead of tui_refresh_win, to update the
6852         current execution line.  This fixes redisplay of the current line
6853         when stepping through the code with "next" or "step".
6854
6855 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6856
6857         * source-cache.c (source_cache::get_source_lines): Call
6858         find_source_lines to initialize s->nlines.  This fixes vertical
6859         scrolling of TUI source window when the DOWN arrow is pressed.
6860
6861 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6862
6863         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6864         linux-thread-db.c (_initialize_thread_db): Likewise.
6865
6866 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6867
6868         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6869         wclrtoeol in tui_show_source_line".  This reverts changes made in
6870         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6871
6872 2019-03-15  Tom Tromey  <tom@tromey.com>
6873
6874         * symtab.h (struct minimal_symbol): Derive from
6875         general_symbol_info.
6876         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6877         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6878         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6879         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6880         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6881         (MSYMBOL_SEARCH_NAME): Update.
6882         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6883         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6884         * minsyms.c (minimal_symbol_reader::record_full): Update.
6885
6886 2019-03-15  Tom Tromey  <tom@tromey.com>
6887
6888         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6889
6890 2019-03-15  Tom Tromey  <tom@tromey.com>
6891
6892         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6893         unique_xmalloc_ptr.
6894         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6895         Update.
6896         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6897         (build_minimal_symbol_hash_tables)
6898         (minimal_symbol_reader::install): Update.
6899
6900 2019-03-15  Tom Tromey  <tom@tromey.com>
6901
6902         * symtab.c (create_demangled_names_hash): Update.
6903         (symbol_set_names): Update.
6904         * objfiles.h (struct objfile_per_bfd_storage)
6905         <demangled_names_hash>: Now an htab_up.
6906         * objfiles.c (objfile_per_bfd_storage): Simplify.
6907
6908 2019-03-15  Tom Tromey  <tom@tromey.com>
6909
6910         * objfiles.h (struct objfile_per_bfd_storage): Declare
6911         destructor.
6912         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6913         New.
6914         (get_objfile_bfd_data): Use new.  Don't initialize
6915         language_of_main.
6916         (free_objfile_per_bfd_storage): Remove.
6917         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6918
6919 2019-03-15  Tom Tromey  <tom@tromey.com>
6920
6921         * symfile.c (reread_symbols): Update.
6922         * objfiles.c (objfile::objfile): Update.
6923         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6924         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6925         comment.
6926         (minimal_symbol_reader::install): Update.
6927         (terminate_minimal_symbol_table): Remove.
6928         * jit.c (jit_object_close_impl): Update.
6929
6930 2019-03-15  Tom Tromey  <tom@tromey.com>
6931
6932         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6933         initializations.
6934
6935 2019-03-15  Tom Tromey  <tom@tromey.com>
6936
6937         * objfiles.h (struct objfile_per_bfd_storage)
6938         <demangled_hash_languages>: Now a bitset.
6939         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6940         (lookup_minimal_symbol): Update.
6941
6942 2019-03-15  Tom Tromey  <tom@tromey.com>
6943
6944         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6945         Don't return the symbol.
6946         * coffread.c (record_minimal_symbol): Use record_full.
6947
6948 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6949
6950         The MS-Windows port of ncurses fails to switch to a color pair if
6951         one or both of the colors are the implicit default colors.  This
6952         change records the default colors when TUI is initialized, and
6953         then specifies them explicitly when a color pair uses the default
6954         colors.  This allows color styling in TUI mode on MS-Windows.
6955
6956         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6957         ncurses_norm_attr.
6958         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6959         colors in ncurses_norm_attr.
6960         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6961         "none", replace it with the default color recorded in
6962         ncurses_norm_attr.
6963
6964 2019-03-14  Tom Tromey  <tromey@adacore.com>
6965
6966         * source-cache.h (class source_cache) <get_source_lines>: Return
6967         std::string.
6968         * source-cache.c (source_cache::extract_lines): Handle case where
6969         first_pos==npos.  Return std::string.
6970         (source_cache::get_source_lines): Update.
6971
6972 2019-03-14  Tom Tromey  <tromey@adacore.com>
6973
6974         * NEWS: Add item for "style sources" commands.
6975         * source-cache.c (source_cache::get_source_lines): Check
6976         source_styling.
6977         * cli/cli-style.c (source_styling): New global.
6978         (_initialize_cli_style): Add "style sources" commands.
6979         (show_style_sources): New function.
6980         * cli/cli-style.h (source_styling): Declare.
6981
6982 2019-03-14  Pedro Alves  <palves@redhat.com>
6983             Tom Tromey  <tromey@adacore.com>
6984
6985         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6986         * tui/tui-winsource.c (tui_refill_source_window): New function,
6987         from...
6988         (tui_horizontal_source_scroll): ... here.  Move some logic.
6989         * cli/cli-style.c (set_style_enabled): Notify new observable.
6990         * tui/tui-hooks.c (tui_redisplay_source): New function.
6991         (tui_attach_detach_observers): Attach or detach
6992         tui_redisplay_source.
6993         * observable.h (source_styling_changed): New observable.
6994         * observable.c: Define source_styling_changed observable.
6995
6996 2019-03-13  Tom Tromey  <tromey@adacore.com>
6997
6998         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6999         (i386_gnu_nat_target::store_registers): Update.
7000         * target-debug.h (target_debug_print_std_string): New macro.
7001         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7002         * windows-tdep.c (display_one_tib): Update.
7003         * tui/tui-stack.c (tui_make_status_line): Update.
7004         * top.c (print_inferior_quit_action): Update.
7005         * thread.c (thr_try_catch_cmd): Update.
7006         (add_thread_with_info): Update.
7007         (thread_target_id_str): Update.
7008         (thr_try_catch_cmd): Update.
7009         (thread_command): Update.
7010         (thread_find_command): Update.
7011         * record-btrace.c (record_btrace_target::info_record)
7012         (record_btrace_resume_thread, record_btrace_target::resume)
7013         (record_btrace_cancel_resume, record_btrace_step_thread)
7014         (record_btrace_target::wait, record_btrace_target::wait)
7015         (record_btrace_target::wait, record_btrace_target::stop): Update.
7016         * progspace.c (print_program_space): Update.
7017         * process-stratum-target.c
7018         (process_stratum_target::thread_address_space): Update.
7019         * linux-fork.c (linux_fork_mourn_inferior)
7020         (detach_checkpoint_command, info_checkpoints_command)
7021         (linux_fork_context): Update.
7022         (linux_fork_detach): Update.
7023         (class scoped_switch_fork_info): Update.
7024         (delete_checkpoint_command): Update.
7025         * infrun.c (follow_fork_inferior): Update.
7026         (follow_fork_inferior): Update.
7027         (proceed_after_vfork_done): Update.
7028         (handle_vfork_child_exec_or_exit): Update.
7029         (follow_exec): Update.
7030         (displaced_step_prepare_throw): Update.
7031         (displaced_step_restore): Update.
7032         (start_step_over): Update.
7033         (resume_1): Update.
7034         (clear_proceed_status_thread): Update.
7035         (proceed): Update.
7036         (print_target_wait_results): Update.
7037         (do_target_wait): Update.
7038         (context_switch): Update.
7039         (stop_all_threads): Update.
7040         (restart_threads): Update.
7041         (finish_step_over): Update.
7042         (handle_signal_stop): Update.
7043         (switch_back_to_stepped_thread): Update.
7044         (keep_going_pass_signal): Update.
7045         (print_exited_reason): Update.
7046         (normal_stop): Update.
7047         * inferior.c (inferior_pid_to_str): Change return type.
7048         (print_selected_inferior): Update.
7049         (add_inferior): Update.
7050         (detach_inferior): Update.
7051         * dummy-frame.c (fprint_dummy_frames): Update.
7052         * dcache.c (dcache_info_1): Update.
7053         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7054         (btrace_fetch, btrace_clear): Update.
7055         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7056         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7057         type.
7058         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7059         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7060         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7061         * gdbarch.c, gdbarch.h: Rebuild.
7062         * gdbarch.sh (core_pid_to_str): Change return type.
7063         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7064         return type.
7065         (windows_nat_target::pid_to_str): Change return type.
7066         (windows_delete_thread): Update.
7067         (windows_nat_target::attach): Update.
7068         (windows_nat_target::files_info): Update.
7069         * target-delegates.c: Rebuild.
7070         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7071         return type.
7072         (sol_thread_target::pid_to_str): Change return type.
7073         * remote.c (class remote_target) <pid_to_str>: Change return
7074         type.
7075         (remote_target::pid_to_str): Change return type.
7076         (extended_remote_target::attach, remote_target::remote_stop_ns)
7077         (remote_target::remote_notif_remove_queued_reply)
7078         (remote_target::push_stop_reply, remote_target::disable_btrace):
7079         Update.
7080         (extended_remote_target::attach): Update.
7081         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7082         type.
7083         (gdbsim_target::pid_to_str): Change return type.
7084         * ravenscar-thread.c (struct ravenscar_thread_target)
7085         <pid_to_str>: Change return type.
7086         (ravenscar_thread_target::pid_to_str): Change return type.
7087         * procfs.c (class procfs_target) <pid_to_str>: Change return
7088         type.
7089         (procfs_target::pid_to_str): Change return type.
7090         (procfs_target::attach): Update.
7091         (procfs_target::detach): Update.
7092         (procfs_target::fetch_registers): Update.
7093         (procfs_target::store_registers): Update.
7094         (procfs_target::wait): Update.
7095         (procfs_target::files_info): Update.
7096         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7097         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7098         return type.
7099         (nto_procfs_target::pid_to_str): Change return type.
7100         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7101         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7102         return type.
7103         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7104         (exit_lwp): Update.
7105         (attach_proc_task_lwp_callback, get_detach_signal)
7106         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7107         (linux_nat_target::resume, wait_lwp, stop_callback)
7108         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7109         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7110         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7111         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7112         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7113         type.
7114         (inf_ptrace_target::attach): Update.
7115         (inf_ptrace_target::files_info): Update.
7116         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7117         type.
7118         (go32_nat_target::pid_to_str): Change return type.
7119         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7120         (gnu_nat_target::wait): Update.
7121         (gnu_nat_target::wait): Update.
7122         (gnu_nat_target::resume): Update.
7123         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7124         (fbsd_nat_target::wait): Update.
7125         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7126         type.
7127         (darwin_nat_target::attach): Update.
7128         * corelow.c (class core_target) <pid_to_str>: Change return type.
7129         (core_target::pid_to_str): Change return type.
7130         * target.c (normal_pid_to_str): Change return type.
7131         (default_pid_to_str): Likewise.
7132         (target_pid_to_str): Change return type.
7133         (target_translate_tls_address): Update.
7134         (target_announce_detach): Update.
7135         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7136         return type.
7137         (bsd_uthread_target::pid_to_str): Change return type.
7138         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7139         type.
7140         (bsd_kvm_target::pid_to_str): Change return type.
7141         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7142         return type.
7143         (aix_thread_target::pid_to_str): Change return type.
7144         * target.h (struct target_ops) <pid_to_str>: Change return type.
7145         (target_pid_to_str, normal_pid_to_str): Likewise.
7146         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7147         type.
7148         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7149         type.
7150         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7151         return type.
7152         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7153         type.
7154         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7155         type.
7156         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7157         return type.
7158
7159 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7160
7161         * NEWS: Mention that the new default MI version is 3.  Mention
7162         changes to the output of commands and events that deal with
7163         multi-location breakpoints.
7164         * breakpoint.c: Include "mi/mi-out.h".
7165         (print_one_breakpoint): Change output syntax if using MI version
7166         >= 3.
7167         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7168         New.
7169         (mi_multi_location_breakpoint_output_fixed): New.
7170         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7171         (mi_cmd_fix_multi_location_breakpoint_output): New.
7172         (mi_multi_location_breakpoint_output_fixed): New.
7173         * mi/mi-cmds.c (mi_cmds): Register command
7174         -fix-multi-location-breakpoint-output.
7175         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7176         interpreter "mi".
7177
7178 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7179
7180         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7181         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7182         instantiate mi_ui_out based on interpreter name.
7183         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7184         * mi/mi-main.c (mi_load_progress): Likewise.
7185
7186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7187
7188         * NEWS: Combine separate "New targets" sections for 8.3.
7189
7190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7191
7192         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7193         (ppcfbsd_init_abi): Install gdbarch
7194         "fetch_tls_load_module_address" and "get_thread_local_address"
7195         methods.
7196
7197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7198
7199         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7200         (riscv_fbsd_init_abi): Install gdbarch
7201         "fetch_tls_load_module_address" and "get_thread_local_address"
7202         methods.
7203
7204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7205
7206         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7207         (i386fbsd_init_abi): Install gdbarch
7208         "fetch_tls_load_module_address" and "get_thread_local_address"
7209         methods.
7210
7211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7212
7213         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7214         (amd64fbsd_init_abi): Install gdbarch
7215         "fetch_tls_load_module_address" and "get_thread_local_address"
7216         methods.
7217
7218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7219
7220         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7221         (struct fbsd_pspace_data): New type.
7222         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7223         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7224         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7225         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7226         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7227
7228 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * gdbtypes.c (lookup_struct_elt): New function.
7231         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7232         * gdbtypes.h (struct struct_elt): New type.
7233         (lookup_struct_elt): New prototype.
7234
7235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7236
7237         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7238         remove disabled code block.
7239
7240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7241
7242         * gdbarch.sh (get_thread_local_address): New method.
7243         * gdbarch.h, gdbarch.c: Regenerate.
7244         * target.c (target_translate_tls_address): Use
7245         gdbarch_get_thread_local_address if present instead of
7246         target::get_thread_local_address.
7247
7248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7249
7250         * target.h (target::get_thread_local_address): Update comment.
7251
7252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7253
7254         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7255         objfile->separate_debug_objfile_backlink if not NULL.
7256
7257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7258
7259         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7260         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7261         (amd64bsd_store_inferior_registers): Likewise.
7262         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7263         Enable segment base registers.
7264         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7265         PT_GETFSBASE and PT_GETGSBASE.
7266         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7267         PT_SETGSBASE.
7268         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7269         segment base registers.
7270         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7271
7272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7273
7274         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7275         Update calls to i386_target_description to add 'segments'
7276         parameter.
7277         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7278         add segment base registers.
7279         * arch/i386.c (i386_create_target_description): Add 'segments'
7280         parameter to enable segment base registers.
7281         * arch/i386.h (i386_create_target_description): Likewise.
7282         * features/i386/32bit-segments.xml: New file.
7283         * features/i386/32bit-segments.c: Generate.
7284         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7285         call to i386_target_description to add 'segments' parameter.
7286         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7287         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7288         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7289         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7290         if feature is present.
7291         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7292         Add 'segments' parameter to call to i386_target_description.
7293         (i386_target_description): Add 'segments' parameter to enable
7294         segment base registers.
7295         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7296         to call to i386_target_description.
7297         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7298         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7299         Define I386_NUM_REGS.
7300         (i386_target_description): Add 'segments' parameter to enable
7301         segment base registers.
7302
7303 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7304
7305         PR/24325
7306         * source-cache.c: #undef open and close, to avoid unresolved
7307         externals during linking.
7308
7309 2019-03-12  Tom Tromey  <tromey@adacore.com>
7310
7311         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7312         const.  Add initializers.
7313         (_initialize_remote): Don't initialize ptid globals.
7314
7315 2019-03-12  Pedro Alves  <palves@redhat.com>
7316
7317         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7318
7319 2019-03-12  Pedro Alves  <palves@redhat.com>
7320
7321         * cp-name-parser.y (main): Remove unused 'len' variable.
7322
7323 2019-03-12  Tom Tromey  <tromey@adacore.com>
7324
7325         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7326         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7327
7328 2019-03-12  Tom Tromey  <tromey@adacore.com>
7329
7330         * linux-nat.c (iterate_over_lwps): Update.
7331         (stop_callback): Remove parameter.
7332         (stop_wait_callback, detach_callback, resume_set_callback)
7333         (select_singlestep_lwp_callback, set_ignore_sigint)
7334         (status_callback, resumed_callback, resume_clear_callback)
7335         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7336         data parameter.
7337         (linux_nat_target::detach, linux_nat_target::resume)
7338         (linux_stop_and_wait_all_lwps, select_event_lwp)
7339         (linux_nat_filter_event, linux_nat_wait_1)
7340         (linux_nat_target::kill, linux_nat_target::stop)
7341         (linux_nat_target::stop): Update.
7342         (linux_nat_resume_callback): Change type.
7343         (resume_stopped_resumed_lwps, count_events_callback)
7344         (select_event_lwp_callback): Likewise.
7345         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7346         * arm-linux-nat.c (struct update_registers_data): Remove.
7347         (update_registers_callback): Change type.
7348         (arm_linux_insert_hw_breakpoint1): Update.
7349         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7350         parameter.
7351         (x86_linux_dr_set_addr): Update.
7352         (x86_linux_dr_set_control): Update.
7353         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7354         (iterate_over_lwps): Use gdb::function_view.
7355         * nat/aarch64-linux-hw-point.c (struct
7356         aarch64_dr_update_callback_param): Remove.
7357         (debug_reg_change_callback): Change type.
7358         (aarch64_notify_debug_reg_change): Update.
7359         * s390-linux-nat.c (s390_refresh_per_info): Update.
7360
7361 2019-03-11  Tom Tromey  <tromey@adacore.com>
7362
7363         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7364         redundant assignment to "this_cu".
7365
7366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7367
7368         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7369
7370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7371
7372         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7373         from...
7374         (rank_one_type): ... this.
7375
7376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7377
7378         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7379         from...
7380         (rank_one_type): ... this.
7381
7382 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7383
7384         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7385         from...
7386         (rank_one_type): ... this.
7387
7388 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7389
7390         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7391         from...
7392         (rank_one_type): ... this.
7393
7394 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7395
7396         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7397         from...
7398         (rank_one_type): ... this.
7399
7400 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7401
7402         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7403         from...
7404         (rank_one_type): ... this.
7405
7406 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7407
7408         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7409         from...
7410         (rank_one_type): ... this.
7411
7412 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7413
7414         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7415         from...
7416         (rank_one_type): ... this.
7417
7418 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7419
7420         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7421         from...
7422         (rank_one_type): ... this.
7423
7424 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7425
7426         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7427         from...
7428         (rank_one_type): ... this.
7429
7430 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7431
7432         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7433         from...
7434         (rank_one_type): ... this.
7435
7436 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7437
7438         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7439         from...
7440         (rank_one_type): ... this.
7441
7442 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7443
7444         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7445         inferior-events' shows the example events.
7446
7447 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7448
7449         Support styling on native MS-Windows console
7450
7451         PR/24315
7452         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7453         on MS-Windows if $TERM is not defined.
7454
7455         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7456
7457         * posix-hdep.c (gdb_console_fputs):
7458         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7459         functions.
7460         * ui-file.h (gdb_console_fputs): Add prototype.
7461
7462         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7463         back to fputs only if the former returns zero.
7464
7465 2019-03-07  Tom Tromey  <tom@tromey.com>
7466
7467         * symmisc.c (print_symbol_bcache_statistics): Update.
7468         (print_objfile_statistics): Update.
7469         * symfile.c (allocate_symtab): Update.
7470         * stabsread.c: Don't include bcache.h.
7471         * psymtab.h (struct psymbol_bcache): Don't declare.
7472         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7473         (psymbol_bcache_init, psymbol_bcache_free)
7474         (psymbol_bcache_get_bcache): Don't declare.
7475         * psymtab.c (struct psymbol_bcache): Remove.
7476         (psymtab_storage::psymtab_storage): Update.
7477         (psymtab_storage::~psymtab_storage): Update.
7478         (psymbol_bcache_init, psymbol_bcache_free)
7479         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7480         (add_psymbol_to_bcache): Update.
7481         (allocate_psymtab): Update.
7482         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7483         macro_cache>: No longer pointers.
7484         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7485         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7486         * macrotab.c (macro_bcache): Update.
7487         * macroexp.c: Don't include bcache.h.
7488         * gdbtypes.c (check_types_worklist): Update.
7489         (types_deeply_equal): Remove TRY/CATCH.  Update.
7490         * elfread.c (elf_symtab_read): Update.
7491         * dwarf2read.c: Don't include bcache.h.
7492         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7493         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7494         (print_bcache_statistics, bcache_memory_used): Don't declare.
7495         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7496         methods.  Rename all data members.
7497         * bcache.c (struct bcache): Move to bcache.h.
7498         (bcache::expand_hash_table): Rename from expand_hash_table.
7499         (bcache): Remove.
7500         (bcache::insert): Rename from bcache_full.
7501         (bcache::compare): Rename from bcache_compare.
7502         (bcache_xmalloc): Remove.
7503         (bcache::~bcache): Rename from bcache_xfree.
7504         (bcache::print_statistics): Rename from print_bcache_statistics.
7505         (bcache::memory_used): Rename from bcache_memory_used.
7506
7507 2019-03-07  Pedro Alves  <palves@redhat.com>
7508
7509         * infrun.c (normal_stop): Also check for
7510         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7511
7512 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7513
7514         * f-lang.c (value_from_host_double): Moved to...
7515         * value.c (value_from_host_double): ...here.
7516         * value.h (value_from_host_double): Declare.
7517         * guile/scm-math.c (vlscm_convert_typed_number): Use
7518         value_from_host_double.
7519         (vlscm_convert_number): Likewise.
7520         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7521         * python/py-value.c (convert_value_from_python): Likewise.
7522
7523 2019-03-06  Tom Tromey  <tom@tromey.com>
7524
7525         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7526
7527 2019-03-06  Tom Tromey  <tom@tromey.com>
7528
7529         * utils.h (free_current_contents): Don't declare.
7530         * utils.c (free_current_contents): Remove.
7531
7532 2019-03-06  Tom Tromey  <tom@tromey.com>
7533
7534         * top.c (quit_force): Update.
7535         * main.c (captured_command_loop): Update.
7536         * common/new-op.c (operator new): Update.
7537         * common/common-exceptions.c (struct catcher)
7538         <save_cleanup_chain>: Remove member.
7539         (exceptions_state_mc_init): Update.
7540         (exception_try_scope_entry): Return nullptr.
7541         (exception_try_scope_exit, exception_rethrow)
7542         (throw_exception_sjlj, throw_exception_cxx): Update.
7543         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7544         (all_cleanups, do_cleanups, discard_cleanups)
7545         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7546         (restore_cleanups, restore_final_cleanups): Don't declare.
7547         (do_final_cleanups): Remove parameter.
7548         * common/cleanups.c (cleanup_chain, make_cleanup)
7549         (make_cleanup_dtor, all_cleanups, do_cleanups)
7550         (discard_my_cleanups, discard_cleanups)
7551         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7552         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7553         (null_cleanup): Remove.
7554         (do_final_cleanups): Remove parameter.
7555
7556 2019-03-06  Tom Tromey  <tom@tromey.com>
7557
7558         * remote.c (remote_target::remote_parse_stop_reply): Use
7559         unique_xmalloc_ptr.
7560
7561 2019-03-06  Tom Tromey  <tom@tromey.com>
7562
7563         * stabsread.c (struct stabs_field_info): Rename from field_info.
7564         <list, fnlist>: Add initializers.
7565         <obstack>: New member.
7566         (read_member_functions, read_struct_fields, read_baseclasses):
7567         Allocate on obstack.  Don't use cleanups.
7568         (read_one_struct_field, read_member_functions, read_struct_fields)
7569         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7570         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7571         (read_struct_type): Update.
7572
7573 2019-03-06  Tom Tromey  <tom@tromey.com>
7574
7575         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7576         * common/filestuff.h (make_cleanup_close): Don't declare.
7577         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7578         Remove.
7579
7580 2019-03-06  Tom Tromey  <tom@tromey.com>
7581
7582         * solib-aix.c: Use make_scope_exit.
7583
7584 2019-03-06  Tom Tromey  <tom@tromey.com>
7585
7586         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7587         Use make_scope_exit.
7588
7589 2019-03-06  Tom Tromey  <tom@tromey.com>
7590
7591         * solib-svr4.c (disable_probes_interface): Remove parameter.
7592         (svr4_handle_solib_event): Use make_scope_exit.
7593
7594 2019-03-06  Tom Tromey  <tom@tromey.com>
7595
7596         * remote.c (struct stop_reply_deleter): Remove.
7597         (stop_reply_up): Update.
7598         (struct stop_reply): Derive from notif_event.  Don't typedef.
7599         <regcache>: Now a std::vector.
7600         (stop_reply_xfree): Remove.
7601         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7602         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7603         (remote_target::discard_pending_stop_replies): Use delete.
7604         (remote_target::remote_parse_stop_reply): Update.
7605         (remote_target::process_stop_reply): Update.
7606         * remote-notif.h (struct notif_event): Add virtual destructor.
7607         Remove "dtr" member.
7608         (struct notif_client) <alloc_event>: Return a unique_ptr.
7609         (notif_event_xfree): Don't declare.
7610         (notif_event_up): New typedef.
7611         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7612         (notif_event_xfree, do_notif_event_xfree): Remove.
7613         (remote_notif_state_xfree): Update.
7614
7615 2019-03-06  Tom Tromey  <tom@tromey.com>
7616
7617         * infrun.c (displaced_step_clear_cleanup): Now a
7618         forward_scope_exit type.
7619         (displaced_step_prepare_throw): Update.
7620         (displaced_step_fixup): Update.
7621
7622 2019-03-06  Tom Tromey  <tom@tromey.com>
7623
7624         * inferior.h (class inferior): Update comment.
7625         * gdbthread.h (class thread_info): Update comment.
7626
7627 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7628             Tom Tromey  <tom@tromey.com>
7629
7630         * stabsread.h (struct stab_section_list): Remove.
7631         (coffstab_build_psymtabs): Update.
7632         * dbxread.c (symbuf_sections): Now a std::vector.
7633         (sect_idx): New global.
7634         (fill_symbuf): Update.
7635         (coffstab_build_psymtabs): Change type of stabsects parameter.
7636         Update.
7637         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7638         std::vector.
7639         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7640         (coff_locate_sections): Update.
7641         (coff_symfile_read): Remove cleanups.  Update.
7642         (init_stringtab): Add storage parameter.
7643         (free_stringtab, free_stringtab_cleanup): Remove.
7644         (init_lineno): Add storage parameter.
7645         (free_linetab, free_linetab_cleanup): Remove.
7646
7647 2019-03-06  Pedro Alves  <palves@redhat.com>
7648
7649         * linux-fork.c (fork_info::clobber_regs): Delete.
7650         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7651         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7652         comment.  Adjust.
7653         (scoped_switch_fork_info::scoped_switch_fork_info)
7654         (checkpoint_command, linux_fork_context): Adjust
7655         fork_save_infrun_state calls.
7656
7657 2019-03-06  Pedro Alves  <palves@redhat.com>
7658
7659         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7660         (inf_has_multiple_threads): Return 'bool' and rewrite using
7661         inferior_info::threads().
7662
7663 2019-03-06  Pedro Alves  <palves@redhat.com>
7664
7665         * linux-fork.c: Include <list>.
7666         (fork_list): Now a std::list instance.
7667         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7668         (forks_exist_p, find_last_fork): Adjust.
7669         (new_fork): Delete.
7670         (one_fork_p): New.
7671         (add_fork): Adjust.
7672         (free_fork): Delete, folded into fork_info::~fork_info().
7673         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7674         Adjust.
7675         (init_fork_list): Delete.
7676         (linux_fork_killall, linux_fork_mourn_inferior)
7677         (linux_fork_detach, info_checkpoints_command): Adjust.
7678         (_initialize_linux_fork): No longer call init_fork_list.
7679
7680 2019-03-06  Pedro Alves  <palves@redhat.com>
7681
7682         * linux-fork.c (new_fork): New, split out of ...
7683         (add_fork): ... this.  Return void.  Move "first fork" special
7684         case from here, to ...
7685         (checkpoint_command): ... here.
7686         * linux-linux.h (add_fork): Return void.
7687
7688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7689
7690         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7691
7692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7693             Chris January  <chris.january@arm.com>
7694             David Lecomber  <david.lecomber@arm.com>
7695
7696         * f-exp.y: New token, UNOP_INTRINSIC.
7697         (exp): New pattern using UNOP_INTRINSIC token.
7698         (f77_keywords): Add 'abs' keyword.
7699         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7700         (value_from_host_double): New function.
7701         (evaluate_subexp_f): Support UNOP_ABS.
7702
7703 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7706         types.
7707
7708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7709
7710         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7711         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7712         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7713
7714 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7715
7716         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7717
7718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7719             Chris January  <chris.january@arm.com>
7720
7721         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7722         * f-exp.y: Define 'KIND' token.
7723         (exp): New pattern for KIND expressions.
7724         (ptype): Handle types with a kind extension.
7725         (direct_abs_decl): Extend to spot kind extensions.
7726         (f77_keywords): Add 'kind' to the list.
7727         (push_kind_type): New function.
7728         (convert_to_kind_type): New function.
7729         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7730         * parse.c (operator_length_standard): Likewise.
7731         * parser-defs.h (enum type_pieces): Add tp_kind.
7732         * std-operator.def: Add UNOP_KIND.
7733
7734 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7735
7736         * f-exp.y (f_parse): Set yydebug.
7737
7738 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * f-lang.c (evaluate_subexp_f): New function.
7741         (exp_descriptor_f): New global.
7742         (f_language_defn): Use exp_descriptor_f instead of
7743         exp_descriptor_standard.
7744
7745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * f-exp.y (struct token): Add comments.
7748         (dot_ops): Remove uppercase versions and the end marker.
7749         (f77_keywords): Likewise.
7750         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7751         entries in the dot_ops array are case insensitive, and use
7752         strncasecmp to compare strings.  Also some whitespace cleanup in
7753         this area.  Similar for the f77_keywords array, except entries in
7754         this list might be case sensitive.
7755
7756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         * f-exp.y (struct f77_boolean_val): Add comments.
7759         (boolean_values): Remove uppercase versions, and end marker.
7760         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7761         and use strncasecmp to achieve case insensitivity.  Additionally,
7762         perform whitespace cleanup around this code.
7763
7764 2019-03-06  Tom Tromey  <tromey@adacore.com>
7765
7766         * remote-sim.c (gdbsim_target_open): Use result of
7767         gdb_argv::release.
7768
7769 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7770         Dirk Schubert  <dirk.schubert@arm.com>
7771         Chris January  <chris.january@arm.com>
7772
7773         * eval.c (evaluate_subexp_standard): Call Fortran argument
7774         wrapping logic.
7775         * f-lang.c (struct value): A value which can be passed into a
7776         Fortran function call.
7777         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7778         where appropriate.
7779         (struct type): Value ready for a Fortran function call.
7780         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7781         is needed.
7782         * f-lang.h (fortran_argument_convert): Declaration.
7783         (fortran_preserve_arg_pointer): Declaration.
7784         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7785
7786 2019-03-05  Tom Tromey  <tromey@adacore.com>
7787
7788         * python/py-prettyprint.c (print_string_repr): Remove #if.
7789         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7790
7791 2019-03-05  Tom Tromey  <tromey@adacore.com>
7792
7793         * target.c (the_dummy_target): Move later.  Change type to
7794         "dummy_target".
7795         (initialize_targets): Don't initialize the_dummy_target.
7796
7797 2019-03-05  Tom Tromey  <tromey@adacore.com>
7798
7799         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7800         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7801
7802 2019-03-05  Tom Tromey  <tromey@adacore.com>
7803
7804         * windows-nat.c (windows_nat_target::attach)
7805         (windows_nat_target::detach): Don't call gdb_flush.
7806         * valprint.c (generic_val_print, val_print, val_print_string):
7807         Don't call gdb_flush.
7808         * utils.c (defaulted_query): Don't call gdb_flush.
7809         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7810         * target.c (target_announce_detach): Don't call gdb_flush.
7811         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7812         * remote.c (extended_remote_target::attach): Don't call
7813         gdb_flush.
7814         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7815         * printcmd.c (do_examine): Don't call gdb_flush.
7816         (info_display_command): Don't call gdb_flush.
7817         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7818         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7819         * memattr.c (info_mem_command): Don't call gdb_flush.
7820         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7821         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7822         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7823         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7824         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7825         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7826         (gnu_nat_target::detach): Don't call gdb_flush.
7827         * f-valprint.c (f_val_print): Don't call gdb_flush.
7828         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7829         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7830         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7831         gdb_flush.
7832         * c-valprint.c (c_val_print): Don't call gdb_flush.
7833         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7834
7835 2019-03-05  Tom Tromey  <tromey@adacore.com>
7836
7837         * varobj.c (update_dynamic_varobj_children): Update.
7838         (install_default_visualizer): Use reset, not release.
7839         * value.c (set_internalvar): Update.
7840         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7841         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7842         ATTRIBUTE_UNUSED_RESULT.
7843
7844 2019-03-05  Tom Tromey  <tromey@adacore.com>
7845
7846         * remote.c (class scoped_remote_fd) <release>: Add
7847         ATTRIBUTE_UNUSED_RESULT.
7848
7849 2019-03-05  Tom Tromey  <tromey@adacore.com>
7850
7851         * macroexp.c (struct macro_buffer) <release>: Add
7852         ATTRIBUTE_UNUSED_RESULT.
7853
7854 2019-03-05  Tom Tromey  <tromey@adacore.com>
7855
7856         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7857         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7858         ATTRIBUTE_UNUSED_RESULT.
7859
7860 2019-03-05  Tom Tromey  <tromey@adacore.com>
7861
7862         * common/scoped_fd.h (class scoped_fd) <release>: Add
7863         ATTRIBUTE_UNUSED_RESULT.
7864
7865 2019-03-05  Tom Tromey  <tromey@adacore.com>
7866
7867         * parser-defs.h (struct parser_state) <release>: Add
7868         ATTRIBUTE_UNUSED_RESULT.
7869
7870 2019-03-05  Tom Tromey  <tromey@adacore.com>
7871
7872         * utils.h (class gdb_argv) <release>: Add
7873         ATTRIBUTE_UNUSED_RESULT.
7874         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7875
7876 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7877
7878         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7879         for-loop range, to avoid compiler warnings.
7880
7881         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7882         avoid compiler warnings about unused variables.
7883
7884         * NEWS: Mention end of support for native debugging on MS-Windows
7885         before XP.
7886
7887         PR gdb/24292
7888         * common/netstuff.c:
7889         * gdbserver/gdbreplay.c
7890         * gdbserver/remote-utils.c:
7891         * ser-tcp.c:
7892         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7893         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7894         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7895         'getaddrinfo' and 'freeaddrinfo' were not available before
7896         Windows XP, and mingw.org's MinGW headers by default define
7897         _WIN32_WINNT to 0x500.
7898
7899 2019-03-01  Gary Benson <gbenson@redhat.com>
7900
7901         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7902
7903 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7904             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7905
7906         PR gdb/8527
7907         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7908         set_sigint_trap, clear_sigint_trap.
7909
7910 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7911
7912         * target.c (target_detach): Clear the regcache and the
7913         frame cache.
7914
7915 2019-02-27  Pedro Alves  <palves@redhat.com>
7916
7917         * utils.c (set_screen_size): When we cap the height/width sizes,
7918         tweak the corresponding command variable to show "unlimited":
7919
7920 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7921             Pedro Alves  <palves@redhat.com>
7922
7923         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7924         before calling rl_set_screen_size.
7925
7926 2019-02-27  Tom Tromey  <tromey@adacore.com>
7927
7928         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7929         define.
7930         * python/py-value.c: Remove Python 2.4 workaround.
7931         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7932         workaround.
7933         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7934         Python 2.4 workaround.
7935         * python/python-internal.h: Remove Python 2.4 comment.
7936         (Py_ssize_t): Don't define.
7937         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7938         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7939         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7940         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7941         * python/python.c (do_start_initialization): Remove Python 2.4
7942         workaround.
7943         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7944         (print_children): Remove Python 2.4 workaround.
7945         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7946         workaround.
7947         (CHARBUFFERPROC_NAME): Remove.
7948         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7949         Python 2.4 workaround.
7950
7951 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7952
7953         * NEWS: Note minimum Python version.
7954
7955 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7956
7957         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7958         code from these functions.  Remove corresponding ifdefs.  Use
7959         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7960         Remove gotos and target of gotos.
7961         (infpy_search_memory): Likewise.
7962
7963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7966         (hppa_gdbarch_init): Don't register deleted functions with
7967         gdbarch.
7968
7969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7970
7971         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7972         (h8300_unwind_sp): Delete.
7973         (h8300_dummy_id): Delete.
7974         (h8300_gdbarch_init): Don't register deleted functions with
7975         gdbarch.
7976
7977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7978
7979         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7980         (ft32_unwind_pc): Delete.
7981         (ft32_unwind_sp): Delete.
7982         (ft32_gdbarch_init): Don't register deleted functions with
7983         gdbarch.
7984
7985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7986
7987         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7988         (frv_unwind_pc): Delete.
7989         (frv_unwind_sp): Delete.
7990         (frv_gdbarch_init): Don't register deleted functions with
7991         gdbarch.
7992
7993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7994
7995         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7996         (riscv_unwind_pc): Delete.
7997         (riscv_unwind_sp): Delete.
7998         (riscv_gdbarch_init): Don't register deleted functions with
7999         gdbarch.
8000
8001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8002
8003         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8004         (csky_unwind_pc): Delete.
8005         (csky_unwind_sp): Delete.
8006         (csky_gdbarch_init): Don't register deleted functions with
8007         gdbarch.
8008
8009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8012         (cris_unwind_pc): Delete.
8013         (cris_unwind_sp): Delete.
8014         (cris_gdbarch_init): Don't register deleted functions with
8015         gdbarch.
8016
8017 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8020         (bfin_unwind_pc): Delete.
8021         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8022
8023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8024
8025         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8026         (arm_unwind_pc): Delete.
8027         (arm_unwind_sp): Delete.
8028         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8029
8030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8031
8032         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8033         (arc_unwind_pc): Delete.
8034         (arc_unwind_sp): Delete.
8035         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8036
8037 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8038
8039         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8040         (alpha_unwind_pc): Delete.
8041         (alpha_gdbarch_init): Don't register deleted functions with
8042         gdbarch.
8043
8044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8045
8046         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8047         (aarch64_unwind_pc): Delete.
8048         (aarch64_unwind_sp): Delete.
8049         (aarch64_gdbarch_init): Don't register deleted functions with
8050         gdbarch.
8051
8052 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8053
8054         * gdbtypes.c (type_align): Don't consider static members when
8055         computing structure alignment.
8056
8057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8058
8059         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8060         return 0 for other types.
8061         * arch-utils.c (default_type_align): Always return 0.
8062         * gdbarch.h: Regenerate.
8063         * gdbarch.sh (type_align): Extend comment.
8064         * gdbtypes.c (type_align): Add additional comments, always call
8065         gdbarch_type_align before applying the default rules.
8066         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8067         generic code will then apply a suitable default.
8068         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8069         types, return 0 for other types.
8070
8071 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8072
8073         * NEWS: Create a new section for the next release branch.
8074         Rename the section of the current branch, now that it has
8075         been cut.
8076
8077 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8078
8079         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8080         * version.in: Bump version to 8.3.50.DATE-git.
8081
8082 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8083
8084         * aix-thread.c (ptid_cmp): Remove unused variable.
8085         (get_signaled_thread): Likewise.
8086         (store_regs_user_thread): Likewise.
8087         (store_regs_kernel_thread): Likewise.
8088         (fetch_regs_kernel_thread): Remove shadowed variable.
8089
8090 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * features/riscv/32bit-cpu.xml: Add register numbers.
8093         * features/riscv/32bit-fpu.c: Regenerate.
8094         * features/riscv/32bit-fpu.xml: Add register numbers.
8095         * features/riscv/64bit-cpu.xml: Add register numbers.
8096         * features/riscv/64bit-fpu.c: Regenerate.
8097         * features/riscv/64bit-fpu.xml: Add register numbers.
8098
8099 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8100
8101         * NEWS: Mention two argument form of gdb.Value constructor.
8102         * python/py-value.c (convert_buffer_and_type_to_value): New
8103         function.
8104         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8105         Add support for handling an optional second argument.  Call
8106         convert_buffer_and_type_to_value as appropriate.
8107         * python/python-internal.h (Py_buffer_deleter): New struct.
8108         (Py_buffer_up): New typedef.
8109
8110 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8111
8112         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8113         instead of releasing ownership.
8114
8115 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8116
8117         * dwarf2read.c (open_and_init_dwp_file): Call
8118         elf_numsections instead of bfd_count_sections to initialize
8119         dwp_file->num_sections.
8120
8121 2019-02-25  Tom Tromey  <tromey@adacore.com>
8122
8123         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8124
8125 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8126
8127         * gcore.in: Add '--readnever' option when invoking GDB.
8128
8129 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8130
8131         * MAINTAINERS: Update my email address.
8132
8133 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8134
8135         * build-id.c (build_id_to_debug_bfd_1): New function.
8136         (build_id_to_debug_bfd): Look for separate debug file in
8137         sysroot.
8138
8139 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8140
8141         * gdbarch.sh: Update the copyright year range that is placed into
8142         generated files.
8143
8144 2019-02-22  Keith Seitz  <keiths@redhat.com>
8145
8146         PR symtab/23853
8147         * linespec.c (create_sals_line_offset): Search for the default
8148         symtab's filename instead of its fullname.
8149
8150 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8151
8152         * NEWS: Update style defaults.
8153
8154 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8155
8156         * main.c (captured_main_1): Disable styling in batch mode.
8157
8158 2019-02-20  Tom Tromey  <tom@tromey.com>
8159
8160         * symtab.c (symtab_symbol_info): Fix typos.
8161
8162 2019-02-20  Tom Tromey  <tromey@adacore.com>
8163
8164         * findcmd.c (_initialize_mem_search): Use upper case for
8165         metasyntactic variables.
8166
8167 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8168
8169         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8170         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8171
8172 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8173
8174         * top.h (source_file_name): Change to std::string.
8175         * top.c (source_file_name): Likewise.
8176         (command_line_input): Adjust.
8177         * cli/cli-script.c (script_from_file): Adjust.
8178
8179 2019-02-19  Tom Tromey  <tromey@adacore.com>
8180
8181         * ravenscar-thread.c
8182         (ravenscar_thread_target::update_thread_list): Don't call
8183         ada_build_task_list.
8184         * ada-lang.h (ada_build_task_list): Don't declare.
8185         * ada-tasks.c (struct ada_tasks_inferior_data)
8186         <task_list_valid_p>: Now bool.
8187         (read_known_tasks, ada_task_list_changed)
8188         (ada_tasks_invalidate_inferior_data): Update.
8189         (read_known_tasks_array): Return bool.
8190         (read_known_tasks_list): Likewise.
8191         (read_known_tasks): Return void.
8192         (ada_build_task_list): Now static.
8193
8194 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8197         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8198
8199 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8200
8201         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8202         variant for ada_tasks_pspace_data_handle and
8203         ada_tasks_inferior_data_handle.
8204         (ada_tasks_pspace_data_cleanup): New function.
8205         (ada_tasks_inferior_data_cleanup): New function.
8206
8207 2019-02-17  Tom Tromey  <tom@tromey.com>
8208
8209         * macrotab.h (macro_source_fullname): Return a std::string.
8210         * macrotab.c (macro_include, check_for_redefinition)
8211         (macro_undef, macro_lookup_definition, foreach_macro)
8212         (foreach_macro_in_scope): Update.
8213         (macro_source_fullname): Return a std::string.
8214         * macrocmd.c (show_pp_source_pos): Update.
8215
8216 2019-02-17  Tom Tromey  <tom@tromey.com>
8217
8218         * macrocmd.c (show_pp_source_pos): Style the file names.
8219
8220 2019-02-17  Tom Tromey  <tom@tromey.com>
8221
8222         PR tui/24197:
8223         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8224
8225 2019-02-17  Tom Tromey  <tom@tromey.com>
8226
8227         * ada-lang.c (user_select_syms): Use filtered printing.
8228         * utils.c (wrap_style): New global.
8229         (desired_style): Remove.
8230         (emit_style_escape): Add stream parameter.
8231         (set_output_style, reset_terminal_style, prompt_for_continue):
8232         Update.
8233         (flush_wrap_buffer): Only flush gdb_stdout.
8234         (wrap_here): Set wrap_style.
8235         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8236         treat escape sequences as a character.  Change when wrap buffer is
8237         flushed.
8238         (fputs_styled): Do not set the output style when the default is
8239         requested.
8240         * ui-style.h (struct ui_file_style) <is_default>: New method.
8241         * source.c (print_source_lines_base): Emit escape sequences in one
8242         piece.
8243
8244 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8245
8246         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8247         integers and enumeration types.
8248
8249 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8250
8251         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8252         instead of lookup_symbol_in_language
8253         (do_exact_match): New function.
8254         (ada_get_symbol_name_matcher): Return do_exact_match when
8255         doing a verbatim match.
8256
8257 2019-02-15  Tom Tromey  <tromey@adacore.com>
8258
8259         * ravenscar-thread.c (ravenscar_thread_target::resume)
8260         (ravenscar_thread_target::wait): Special case wildcard requests.
8261
8262 2019-02-15  Tom Tromey  <tromey@adacore.com>
8263
8264         * ravenscar-thread.c (base_ptid): Remove.
8265         (struct ravenscar_thread_target) <close>: New method.
8266         <m_base_ptid>: New member.
8267         <update_inferior_ptid, active_task, task_is_currently_active,
8268         runtime_initialized>: Declare methods.
8269         <ravenscar_thread_target>: Add constructor.
8270         (ravenscar_thread_target::task_is_currently_active)
8271         (ravenscar_thread_target::update_inferior_ptid)
8272         (ravenscar_runtime_initialized): Rename.  Now methods.
8273         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8274         (ravenscar_thread_target::update_thread_list): Update.
8275         (ravenscar_thread_target::active_task): Now method.
8276         (ravenscar_thread_target::store_registers)
8277         (ravenscar_thread_target::prepare_to_store)
8278         (ravenscar_thread_target::prepare_to_store)
8279         (ravenscar_thread_target::mourn_inferior): Update.
8280         (ravenscar_inferior_created): Use "new" to create target.
8281         (ravenscar_thread_target::get_ada_task_ptid): Update.
8282         (_initialize_ravenscar): Don't initialize base_ptid.
8283         (ravenscar_ops): Remove global.
8284
8285 2019-02-15  Tom Tromey  <tromey@adacore.com>
8286
8287         * target.h (push_target): Declare new overload.
8288         * target.c (push_target): New overload, taking an rvalue reference.
8289         * remote.c (remote_target::open_1): Use push_target overload.
8290         * corelow.c (core_target_open): Use push_target overload.
8291
8292 2019-02-15  Tom Tromey  <tromey@adacore.com>
8293
8294         * ravenscar-thread.c (is_ravenscar_task)
8295         (ravenscar_task_is_currently_active): Return bool.
8296         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8297         (_initialize_ravenscar): Remove "(void)".
8298         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8299         Return bool.
8300
8301 2019-02-15  Tom Tromey  <tromey@adacore.com>
8302
8303         * ravenscar-thread.c (ravenscar_runtime_initializer)
8304         (has_ravenscar_runtime, get_running_thread_id)
8305         (ravenscar_thread_target::resume): Fix indentation.
8306
8307 2019-02-15  Tom Tromey  <tromey@adacore.com>
8308
8309         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8310         from ravenscar_arch_ops.
8311         (sparc_ravenscar_ops::fetch_registers)
8312         (sparc_ravenscar_ops::store_registers): Now methods.
8313         (sparc_ravenscar_prepare_to_store): Remove.
8314         (sparc_ravenscar_ops): Redefine.
8315         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8316         methods and destructor.  Remove members.
8317         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8318         (ravenscar_thread_target::store_registers)
8319         (ravenscar_thread_target::prepare_to_store): Update.
8320         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8321         Remove.
8322         (struct ppc_ravenscar_powerpc_ops): Derive from
8323         ravenscar_arch_ops.
8324         (ppc_ravenscar_powerpc_ops::fetch_registers)
8325         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8326         (ppc_ravenscar_powerpc_ops): Redefine.
8327         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8328         (ppc_ravenscar_e500_ops::fetch_registers)
8329         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8330         (ppc_ravenscar_e500_ops): Redefine.
8331         * aarch64-ravenscar-thread.c
8332         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8333         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8334         (aarch64_ravenscar_fetch_registers)
8335         (aarch64_ravenscar_store_registers): Now methods.
8336         (aarch64_ravenscar_ops): Redefine.
8337
8338 2019-02-15  Tom Tromey  <tromey@adacore.com>
8339
8340         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8341         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8342         (ravenscar_thread_target::stopped_by_watchpoint)
8343         (ravenscar_thread_target::stopped_data_address)
8344         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8345
8346 2019-02-15  Tom Tromey  <tromey@adacore.com>
8347
8348         * ravenscar-thread.c: Fix some typos.
8349
8350 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8351             Tom Tromey  <tromey@adacore.com>
8352
8353         * ada-lang.c (ada_exception_sal): Change addr_string to a
8354         std::string.
8355         (create_ada_exception_catchpoint): Update.
8356
8357 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8358             Tom Tromey  <tromey@adacore.com>
8359
8360         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8361         (bp_location_ops): Remove.
8362         (base_breakpoint_allocate_location): Update.
8363         (free_bp_location): Update.
8364         * ada-lang.c (class ada_catchpoint_location)
8365         <ada_catchpoint_location>: Remove ops parameter.
8366         (ada_catchpoint_location_dtor): Remove.
8367         (ada_catchpoint_location_ops): Remove.
8368         (allocate_location_exception): Update.
8369         * breakpoint.h (struct bp_location_ops): Remove.
8370         (class bp_location) <bp_location>: Remove bp_location_ops
8371         parameter.
8372         <~bp_location>: Add destructor.
8373         <ops>: Remove.
8374
8375 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8376             Pedro Alves  <palves@redhat.com>
8377
8378         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8379         'PATH_MAX'.
8380
8381 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8382             Samuel Thibault  <samuel.thibault@gnu.org>
8383             Thomas Schwinge  <thomas@codesourcery.com>
8384
8385         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8386         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8387
8388 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8389
8390         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8391         (check_empty): Use "const char *".
8392
8393         * gnu-nat.c (gnu_nat_target::detach): Instead of
8394         'detach_inferior (pid)' call
8395         'detach_inferior (find_inferior_pid (pid))'.
8396
8397         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8398         'nat/fork-inferior.o'.
8399         * gnu-nat.c: #include "nat/fork-inferior.h".
8400
8401         * gnu-nat.c (gnu_nat_target::detach): Instead of
8402         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8403         * gnu-nat.h: #include "inf-child.h".
8404         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8405         'i386_gnu_nat_target::fetch_registers'.
8406         (gnu_store_registers): Rename/move to
8407         'i386_gnu_nat_target::store_registers'.
8408
8409         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8410         * gnu-nat.h (mach_thread_info): New function.
8411         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8412
8413         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8414
8415 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8416
8417         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8418
8419 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8420
8421         * windows-nat.c (windows_add_thread): Add new parameter
8422         "main_thread_p" with default value set to false.  Update
8423         function documentation as well as all callers.
8424         (windows_delete_thread): Likewise.
8425         (fake_create_process): Update call to windows_add_thread.
8426         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8427         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8428         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8429         call to windows_delete_thread.
8430
8431 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8432
8433         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8434
8435 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8436
8437         * symfile.c (find_separate_debug_file): Use canonical path of
8438         sysroot with child_path instead of gdb_sysroot if it is valid.
8439
8440 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8441
8442         * symfile.c (find_separate_debug_file): Use child_path to
8443         determine if an object file is under a sysroot.
8444
8445 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8446
8447         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8448         unittests/child-path-selftests.c.
8449         * common/pathstuff.c (child_path): New function.
8450         * common/pathstuff.h (child_path): New prototype.
8451         * unittests/child-path-selftests.c: New file.
8452
8453 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8454
8455         * symfile.c (find_separate_debug_file): Look for separate debug
8456         files in debug directories under the sysroot.
8457
8458 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8459
8460         * symtab.h (struct minimal_symbol data_p): New const method.
8461         (struct minimal_symbol text_p): Likewise.
8462         * symtab.c (output_source_filename): Use file name style
8463         to print file name.
8464         (print_symbol_info): Likewise.
8465         (print_msymbol_info): Use address style to print addresses.
8466         Use function name style to print executable text symbols.
8467         (expand_symtab_containing_pc): Use data_p.
8468         (find_pc_sect_compunit_symtab): Likewise.
8469
8470 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8471
8472         * breakpoint.c (describe_other_breakpoints): Use address style
8473         to print addresses.
8474         (say_where): Likewise.
8475
8476 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8477
8478         * ada-typeprint.c (print_func_type): Print function name
8479         style to print function name.
8480         * c-typeprint.c (c_print_type_1): Likewise.
8481
8482 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8483
8484         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8485         for execve.
8486
8487 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8488
8489         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8490         type_stack.
8491
8492 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8493
8494         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8495         TYPE_CODE_REF types.
8496
8497 2019-02-08  Jim Wilson  <jimw@sifive.com>
8498
8499         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8500         (riscv_linux_fregset): New.
8501         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8502
8503 2019-02-07  Tom Tromey  <tom@tromey.com>
8504
8505         * thread.c (thread_cancel_execution_command): Update.
8506         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8507         methods.
8508         (struct thread_fsm_ops): Remove.
8509         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8510         (thread_fsm_should_stop, thread_fsm_return_value)
8511         (thread_fsm_set_finished, thread_fsm_finished_p)
8512         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8513         Don't declare.
8514         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8515         * infrun.c (clear_proceed_status_thread)
8516         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8517         (print_stop_event): Update.
8518         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8519         Add constructor.
8520         (step_command_fsm_ops): Remove.
8521         (new_step_command_fsm): Remove.
8522         (step_1): Update.
8523         (step_command_fsm::should_stop): Rename from
8524         step_command_fsm_should_stop.
8525         (step_command_fsm::clean_up): Rename from
8526         step_command_fsm_clean_up.
8527         (step_command_fsm::do_async_reply_reason): Rename from
8528         step_command_fsm_async_reply_reason.
8529         (struct until_next_fsm): Inherit from thread_fsm.  Add
8530         constructor.
8531         (until_next_fsm_ops): Remove.
8532         (new_until_next_fsm): Remove.
8533         (until_next_fsm::should_stop): Rename from
8534         until_next_fsm_should_stop.
8535         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8536         (until_next_fsm::do_async_reply_reason): Rename from
8537         until_next_fsm_async_reply_reason.
8538         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8539         constructor.  Change type of breakpoint.
8540         (finish_command_fsm_ops): Remove.
8541         (new_finish_command_fsm): Remove.
8542         (finish_command_fsm::should_stop): Rename from
8543         finish_command_fsm_should_stop.
8544         (finish_command_fsm::clean_up): Rename from
8545         finish_command_fsm_clean_up.
8546         (finish_command_fsm::return_value): Rename from
8547         finish_command_fsm_return_value.
8548         (finish_command_fsm::do_async_reply_reason): Rename from
8549         finish_command_fsm_async_reply_reason.
8550         (finish_command): Update.
8551         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8552         Add constructor.
8553         (call_thread_fsm_ops): Remove.
8554         (call_thread_fsm::call_thread_fsm): Rename from
8555         new_call_thread_fsm.
8556         (call_thread_fsm::should_stop): Rename from
8557         call_thread_fsm_should_stop.
8558         (call_thread_fsm::should_notify_stop): Rename from
8559         call_thread_fsm_should_notify_stop.
8560         (run_inferior_call, call_function_by_hand_dummy): Update.
8561         * cli/cli-interp.c (should_print_stop_to_console): Update.
8562         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8563         Add constructor.  Change type of location_breakpoint,
8564         caller_breakpoint.
8565         (until_break_fsm_ops): Remove.
8566         (new_until_break_fsm): Remove.
8567         (until_break_fsm::should_stop): Rename from
8568         until_break_fsm_should_stop.
8569         (until_break_fsm::clean_up): Rename from
8570         until_break_fsm_clean_up.
8571         (until_break_fsm::do_async_reply_reason): Rename from
8572         until_break_fsm_async_reply_reason.
8573         (until_break_command): Update.
8574         * thread-fsm.c: Remove.
8575         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8576
8577 2019-02-07  Tom Tromey  <tom@tromey.com>
8578
8579         * yy-remap.h: Add include guard.
8580         * xtensa-tdep.h: Add include guard.
8581         * xcoffread.h: Rename include guard.
8582         * varobj-iter.h: Add include guard.
8583         * tui/tui.h: Rename include guard.
8584         * tui/tui-winsource.h: Rename include guard.
8585         * tui/tui-wingeneral.h: Rename include guard.
8586         * tui/tui-windata.h: Rename include guard.
8587         * tui/tui-win.h: Rename include guard.
8588         * tui/tui-stack.h: Rename include guard.
8589         * tui/tui-source.h: Rename include guard.
8590         * tui/tui-regs.h: Rename include guard.
8591         * tui/tui-out.h: Rename include guard.
8592         * tui/tui-layout.h: Rename include guard.
8593         * tui/tui-io.h: Rename include guard.
8594         * tui/tui-hooks.h: Rename include guard.
8595         * tui/tui-file.h: Rename include guard.
8596         * tui/tui-disasm.h: Rename include guard.
8597         * tui/tui-data.h: Rename include guard.
8598         * tui/tui-command.h: Rename include guard.
8599         * tic6x-tdep.h: Add include guard.
8600         * target/waitstatus.h: Rename include guard.
8601         * target/wait.h: Rename include guard.
8602         * target/target.h: Rename include guard.
8603         * target/resume.h: Rename include guard.
8604         * target-float.h: Rename include guard.
8605         * stabsread.h: Add include guard.
8606         * rs6000-tdep.h: Add include guard.
8607         * riscv-fbsd-tdep.h: Add include guard.
8608         * regformats/regdef.h: Rename include guard.
8609         * record.h: Rename include guard.
8610         * python/python.h: Rename include guard.
8611         * python/python-internal.h: Rename include guard.
8612         * python/py-stopevent.h: Rename include guard.
8613         * python/py-ref.h: Rename include guard.
8614         * python/py-record.h: Rename include guard.
8615         * python/py-record-full.h: Rename include guard.
8616         * python/py-record-btrace.h: Rename include guard.
8617         * python/py-instruction.h: Rename include guard.
8618         * python/py-events.h: Rename include guard.
8619         * python/py-event.h: Rename include guard.
8620         * procfs.h: Add include guard.
8621         * proc-utils.h: Add include guard.
8622         * p-lang.h: Add include guard.
8623         * or1k-tdep.h: Rename include guard.
8624         * observable.h: Rename include guard.
8625         * nto-tdep.h: Rename include guard.
8626         * nat/x86-linux.h: Rename include guard.
8627         * nat/x86-linux-dregs.h: Rename include guard.
8628         * nat/x86-gcc-cpuid.h: Add include guard.
8629         * nat/x86-dregs.h: Rename include guard.
8630         * nat/x86-cpuid.h: Rename include guard.
8631         * nat/ppc-linux.h: Rename include guard.
8632         * nat/mips-linux-watch.h: Rename include guard.
8633         * nat/linux-waitpid.h: Rename include guard.
8634         * nat/linux-ptrace.h: Rename include guard.
8635         * nat/linux-procfs.h: Rename include guard.
8636         * nat/linux-osdata.h: Rename include guard.
8637         * nat/linux-nat.h: Rename include guard.
8638         * nat/linux-namespaces.h: Rename include guard.
8639         * nat/linux-btrace.h: Rename include guard.
8640         * nat/glibc_thread_db.h: Rename include guard.
8641         * nat/gdb_thread_db.h: Rename include guard.
8642         * nat/gdb_ptrace.h: Rename include guard.
8643         * nat/fork-inferior.h: Rename include guard.
8644         * nat/amd64-linux-siginfo.h: Rename include guard.
8645         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8646         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8647         * nat/aarch64-linux.h: Rename include guard.
8648         * nat/aarch64-linux-hw-point.h: Rename include guard.
8649         * mn10300-tdep.h: Add include guard.
8650         * mips-linux-tdep.h: Add include guard.
8651         * mi/mi-parse.h: Rename include guard.
8652         * mi/mi-out.h: Rename include guard.
8653         * mi/mi-main.h: Rename include guard.
8654         * mi/mi-interp.h: Rename include guard.
8655         * mi/mi-getopt.h: Rename include guard.
8656         * mi/mi-console.h: Rename include guard.
8657         * mi/mi-common.h: Rename include guard.
8658         * mi/mi-cmds.h: Rename include guard.
8659         * mi/mi-cmd-break.h: Rename include guard.
8660         * m2-lang.h: Add include guard.
8661         * location.h: Rename include guard.
8662         * linux-record.h: Rename include guard.
8663         * linux-nat.h: Add include guard.
8664         * linux-fork.h: Add include guard.
8665         * i386-darwin-tdep.h: Rename include guard.
8666         * hppa-linux-offsets.h: Add include guard.
8667         * guile/guile.h: Rename include guard.
8668         * guile/guile-internal.h: Rename include guard.
8669         * gnu-nat.h: Rename include guard.
8670         * gdb-stabs.h: Rename include guard.
8671         * frv-tdep.h: Add include guard.
8672         * f-lang.h: Add include guard.
8673         * event-loop.h: Add include guard.
8674         * darwin-nat.h: Rename include guard.
8675         * cp-abi.h: Rename include guard.
8676         * config/sparc/nm-sol2.h: Rename include guard.
8677         * config/nm-nto.h: Rename include guard.
8678         * config/nm-linux.h: Add include guard.
8679         * config/i386/nm-i386gnu.h: Rename include guard.
8680         * config/djgpp/nl_types.h: Rename include guard.
8681         * config/djgpp/langinfo.h: Rename include guard.
8682         * compile/gcc-cp-plugin.h: Add include guard.
8683         * compile/gcc-c-plugin.h: Add include guard.
8684         * compile/compile.h: Rename include guard.
8685         * compile/compile-object-run.h: Rename include guard.
8686         * compile/compile-object-load.h: Rename include guard.
8687         * compile/compile-internal.h: Rename include guard.
8688         * compile/compile-cplus.h: Rename include guard.
8689         * compile/compile-c.h: Rename include guard.
8690         * common/xml-utils.h: Rename include guard.
8691         * common/x86-xstate.h: Rename include guard.
8692         * common/version.h: Rename include guard.
8693         * common/vec.h: Rename include guard.
8694         * common/tdesc.h: Rename include guard.
8695         * common/selftest.h: Rename include guard.
8696         * common/scoped_restore.h: Rename include guard.
8697         * common/scoped_mmap.h: Rename include guard.
8698         * common/scoped_fd.h: Rename include guard.
8699         * common/safe-iterator.h: Rename include guard.
8700         * common/run-time-clock.h: Rename include guard.
8701         * common/refcounted-object.h: Rename include guard.
8702         * common/queue.h: Rename include guard.
8703         * common/ptid.h: Rename include guard.
8704         * common/print-utils.h: Rename include guard.
8705         * common/preprocessor.h: Rename include guard.
8706         * common/pathstuff.h: Rename include guard.
8707         * common/observable.h: Rename include guard.
8708         * common/netstuff.h: Rename include guard.
8709         * common/job-control.h: Rename include guard.
8710         * common/host-defs.h: Rename include guard.
8711         * common/gdb_wait.h: Rename include guard.
8712         * common/gdb_vecs.h: Rename include guard.
8713         * common/gdb_unlinker.h: Rename include guard.
8714         * common/gdb_unique_ptr.h: Rename include guard.
8715         * common/gdb_tilde_expand.h: Rename include guard.
8716         * common/gdb_sys_time.h: Rename include guard.
8717         * common/gdb_string_view.h: Rename include guard.
8718         * common/gdb_splay_tree.h: Rename include guard.
8719         * common/gdb_setjmp.h: Rename include guard.
8720         * common/gdb_ref_ptr.h: Rename include guard.
8721         * common/gdb_optional.h: Rename include guard.
8722         * common/gdb_locale.h: Rename include guard.
8723         * common/gdb_assert.h: Rename include guard.
8724         * common/filtered-iterator.h: Rename include guard.
8725         * common/filestuff.h: Rename include guard.
8726         * common/fileio.h: Rename include guard.
8727         * common/environ.h: Rename include guard.
8728         * common/common-utils.h: Rename include guard.
8729         * common/common-types.h: Rename include guard.
8730         * common/common-regcache.h: Rename include guard.
8731         * common/common-inferior.h: Rename include guard.
8732         * common/common-gdbthread.h: Rename include guard.
8733         * common/common-exceptions.h: Rename include guard.
8734         * common/common-defs.h: Rename include guard.
8735         * common/common-debug.h: Rename include guard.
8736         * common/cleanups.h: Rename include guard.
8737         * common/buffer.h: Rename include guard.
8738         * common/btrace-common.h: Rename include guard.
8739         * common/break-common.h: Rename include guard.
8740         * cli/cli-utils.h: Rename include guard.
8741         * cli/cli-style.h: Rename include guard.
8742         * cli/cli-setshow.h: Rename include guard.
8743         * cli/cli-script.h: Rename include guard.
8744         * cli/cli-interp.h: Rename include guard.
8745         * cli/cli-decode.h: Rename include guard.
8746         * cli/cli-cmds.h: Rename include guard.
8747         * charset-list.h: Add include guard.
8748         * buildsym-legacy.h: Rename include guard.
8749         * bfin-tdep.h: Add include guard.
8750         * ax.h: Rename include guard.
8751         * arm-linux-tdep.h: Add include guard.
8752         * arm-fbsd-tdep.h: Add include guard.
8753         * arch/xtensa.h: Rename include guard.
8754         * arch/tic6x.h: Add include guard.
8755         * arch/i386.h: Add include guard.
8756         * arch/arm.h: Rename include guard.
8757         * arch/arm-linux.h: Rename include guard.
8758         * arch/arm-get-next-pcs.h: Rename include guard.
8759         * arch/amd64.h: Add include guard.
8760         * arch/aarch64-insn.h: Rename include guard.
8761         * arch-utils.h: Rename include guard.
8762         * annotate.h: Add include guard.
8763         * amd64-darwin-tdep.h: Rename include guard.
8764         * aarch64-linux-tdep.h: Add include guard.
8765         * aarch64-fbsd-tdep.h: Add include guard.
8766         * aarch32-linux-nat.h: Add include guard.
8767
8768 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8769
8770         * macrotab.c (macro_define_internal): New function that
8771         factorizes macro_define_object_internal and macro_define_function
8772         code.
8773         (macro_define_object_internal): Use macro_define_internal.
8774         (macro_define_function): Likewise.
8775
8776 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8777
8778         * macrocmd.c (extract_identifier): Return
8779         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8780         callers.
8781
8782 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8783
8784         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8785
8786 2019-02-05  Tom Tromey  <tom@tromey.com>
8787
8788         * target.c (target_stack::unpush): Move assertion earlier.
8789
8790 2019-01-30  Tom Tromey  <tom@tromey.com>
8791
8792         PR python/23615:
8793         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8794         (gdbpy_parse_and_eval): Likewise.
8795         * python/python-internal.h (gdbpy_allow_threads): New class.
8796
8797 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8798
8799         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8800         (aarch64_fbsd_fpregmap): Move earlier.
8801         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8802         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8803         instead of individual calls to trad_frame_set_reg_addr.
8804         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8805         earlier.
8806         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8807         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8808         instead of individual calls to trad_frame_set_reg_addr.
8809
8810 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8811
8812         * CONTRIBUTE: Replace contribution list with wiki link.
8813
8814 2019-01-25  Tom Tromey  <tom@tromey.com>
8815
8816         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8817
8818 2019-01-25  Tom Tromey  <tom@tromey.com>
8819
8820         * xtensa-linux-nat.c: Fix common/ includes.
8821         * xml-support.h: Fix common/ includes.
8822         * xml-support.c: Fix common/ includes.
8823         * x86-linux-nat.c: Fix common/ includes.
8824         * windows-nat.c: Fix common/ includes.
8825         * varobj.h: Fix common/ includes.
8826         * varobj.c: Fix common/ includes.
8827         * value.c: Fix common/ includes.
8828         * valops.c: Fix common/ includes.
8829         * utils.c: Fix common/ includes.
8830         * unittests/xml-utils-selftests.c: Fix common/ includes.
8831         * unittests/utils-selftests.c: Fix common/ includes.
8832         * unittests/unpack-selftests.c: Fix common/ includes.
8833         * unittests/tracepoint-selftests.c: Fix common/ includes.
8834         * unittests/style-selftests.c: Fix common/ includes.
8835         * unittests/string_view-selftests.c: Fix common/ includes.
8836         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8837         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8838         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8839         * unittests/rsp-low-selftests.c: Fix common/ includes.
8840         * unittests/parse-connection-spec-selftests.c: Fix common/
8841         includes.
8842         * unittests/optional-selftests.c: Fix common/ includes.
8843         * unittests/offset-type-selftests.c: Fix common/ includes.
8844         * unittests/observable-selftests.c: Fix common/ includes.
8845         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8846         * unittests/memrange-selftests.c: Fix common/ includes.
8847         * unittests/memory-map-selftests.c: Fix common/ includes.
8848         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8849         * unittests/function-view-selftests.c: Fix common/ includes.
8850         * unittests/environ-selftests.c: Fix common/ includes.
8851         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8852         * unittests/common-utils-selftests.c: Fix common/ includes.
8853         * unittests/cli-utils-selftests.c: Fix common/ includes.
8854         * unittests/array-view-selftests.c: Fix common/ includes.
8855         * ui-file.c: Fix common/ includes.
8856         * tui/tui-io.c: Fix common/ includes.
8857         * tracepoint.h: Fix common/ includes.
8858         * tracepoint.c: Fix common/ includes.
8859         * tracefile-tfile.c: Fix common/ includes.
8860         * top.h: Fix common/ includes.
8861         * top.c: Fix common/ includes.
8862         * thread.c: Fix common/ includes.
8863         * target/waitstatus.h: Fix common/ includes.
8864         * target/waitstatus.c: Fix common/ includes.
8865         * target.h: Fix common/ includes.
8866         * target.c: Fix common/ includes.
8867         * target-memory.c: Fix common/ includes.
8868         * target-descriptions.c: Fix common/ includes.
8869         * symtab.h: Fix common/ includes.
8870         * symfile.c: Fix common/ includes.
8871         * stap-probe.c: Fix common/ includes.
8872         * spu-linux-nat.c: Fix common/ includes.
8873         * sparc-nat.c: Fix common/ includes.
8874         * source.c: Fix common/ includes.
8875         * solib.c: Fix common/ includes.
8876         * solib-target.c: Fix common/ includes.
8877         * ser-unix.c: Fix common/ includes.
8878         * ser-tcp.c: Fix common/ includes.
8879         * ser-pipe.c: Fix common/ includes.
8880         * ser-base.c: Fix common/ includes.
8881         * selftest-arch.c: Fix common/ includes.
8882         * s12z-tdep.c: Fix common/ includes.
8883         * rust-exp.y: Fix common/ includes.
8884         * rs6000-aix-tdep.c: Fix common/ includes.
8885         * riscv-tdep.c: Fix common/ includes.
8886         * remote.c: Fix common/ includes.
8887         * remote-notif.h: Fix common/ includes.
8888         * remote-fileio.h: Fix common/ includes.
8889         * remote-fileio.c: Fix common/ includes.
8890         * regcache.h: Fix common/ includes.
8891         * regcache.c: Fix common/ includes.
8892         * record-btrace.c: Fix common/ includes.
8893         * python/python.c: Fix common/ includes.
8894         * python/py-type.c: Fix common/ includes.
8895         * python/py-inferior.c: Fix common/ includes.
8896         * progspace.h: Fix common/ includes.
8897         * producer.c: Fix common/ includes.
8898         * procfs.c: Fix common/ includes.
8899         * proc-api.c: Fix common/ includes.
8900         * printcmd.c: Fix common/ includes.
8901         * ppc-linux-nat.c: Fix common/ includes.
8902         * parser-defs.h: Fix common/ includes.
8903         * osdata.c: Fix common/ includes.
8904         * obsd-nat.c: Fix common/ includes.
8905         * nat/x86-linux.c: Fix common/ includes.
8906         * nat/x86-linux-dregs.c: Fix common/ includes.
8907         * nat/x86-dregs.h: Fix common/ includes.
8908         * nat/x86-dregs.c: Fix common/ includes.
8909         * nat/ppc-linux.c: Fix common/ includes.
8910         * nat/mips-linux-watch.h: Fix common/ includes.
8911         * nat/mips-linux-watch.c: Fix common/ includes.
8912         * nat/linux-waitpid.c: Fix common/ includes.
8913         * nat/linux-ptrace.h: Fix common/ includes.
8914         * nat/linux-ptrace.c: Fix common/ includes.
8915         * nat/linux-procfs.c: Fix common/ includes.
8916         * nat/linux-personality.c: Fix common/ includes.
8917         * nat/linux-osdata.c: Fix common/ includes.
8918         * nat/linux-namespaces.c: Fix common/ includes.
8919         * nat/linux-btrace.h: Fix common/ includes.
8920         * nat/linux-btrace.c: Fix common/ includes.
8921         * nat/fork-inferior.c: Fix common/ includes.
8922         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8923         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8924         * nat/aarch64-linux.c: Fix common/ includes.
8925         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8926         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8927         * namespace.h: Fix common/ includes.
8928         * mips-linux-tdep.c: Fix common/ includes.
8929         * minsyms.c: Fix common/ includes.
8930         * mi/mi-parse.h: Fix common/ includes.
8931         * mi/mi-main.c: Fix common/ includes.
8932         * mi/mi-cmd-env.c: Fix common/ includes.
8933         * memrange.h: Fix common/ includes.
8934         * memattr.c: Fix common/ includes.
8935         * maint.h: Fix common/ includes.
8936         * maint.c: Fix common/ includes.
8937         * main.c: Fix common/ includes.
8938         * machoread.c: Fix common/ includes.
8939         * location.c: Fix common/ includes.
8940         * linux-thread-db.c: Fix common/ includes.
8941         * linux-nat.c: Fix common/ includes.
8942         * linux-fork.c: Fix common/ includes.
8943         * inline-frame.c: Fix common/ includes.
8944         * infrun.c: Fix common/ includes.
8945         * inflow.c: Fix common/ includes.
8946         * inferior.h: Fix common/ includes.
8947         * inferior.c: Fix common/ includes.
8948         * infcmd.c: Fix common/ includes.
8949         * inf-ptrace.c: Fix common/ includes.
8950         * inf-child.c: Fix common/ includes.
8951         * ia64-linux-nat.c: Fix common/ includes.
8952         * i387-tdep.c: Fix common/ includes.
8953         * i386-tdep.c: Fix common/ includes.
8954         * i386-linux-tdep.c: Fix common/ includes.
8955         * i386-linux-nat.c: Fix common/ includes.
8956         * i386-go32-tdep.c: Fix common/ includes.
8957         * i386-fbsd-tdep.c: Fix common/ includes.
8958         * i386-fbsd-nat.c: Fix common/ includes.
8959         * guile/scm-type.c: Fix common/ includes.
8960         * guile/guile.c: Fix common/ includes.
8961         * go32-nat.c: Fix common/ includes.
8962         * gnu-nat.c: Fix common/ includes.
8963         * gdbthread.h: Fix common/ includes.
8964         * gdbarch-selftests.c: Fix common/ includes.
8965         * gdb_usleep.c: Fix common/ includes.
8966         * gdb_select.h: Fix common/ includes.
8967         * gdb_bfd.c: Fix common/ includes.
8968         * gcore.c: Fix common/ includes.
8969         * fork-child.c: Fix common/ includes.
8970         * findvar.c: Fix common/ includes.
8971         * fbsd-nat.c: Fix common/ includes.
8972         * event-top.c: Fix common/ includes.
8973         * event-loop.c: Fix common/ includes.
8974         * dwarf2read.c: Fix common/ includes.
8975         * dwarf2loc.c: Fix common/ includes.
8976         * dwarf2-frame.c: Fix common/ includes.
8977         * dwarf-index-cache.c: Fix common/ includes.
8978         * dtrace-probe.c: Fix common/ includes.
8979         * disasm-selftests.c: Fix common/ includes.
8980         * defs.h: Fix common/ includes.
8981         * csky-tdep.c: Fix common/ includes.
8982         * cp-valprint.c: Fix common/ includes.
8983         * cp-support.h: Fix common/ includes.
8984         * cp-support.c: Fix common/ includes.
8985         * corelow.c: Fix common/ includes.
8986         * completer.h: Fix common/ includes.
8987         * completer.c: Fix common/ includes.
8988         * compile/compile.c: Fix common/ includes.
8989         * compile/compile-loc2c.c: Fix common/ includes.
8990         * compile/compile-cplus-types.c: Fix common/ includes.
8991         * compile/compile-cplus-symbols.c: Fix common/ includes.
8992         * command.h: Fix common/ includes.
8993         * cli/cli-dump.c: Fix common/ includes.
8994         * cli/cli-cmds.c: Fix common/ includes.
8995         * charset.c: Fix common/ includes.
8996         * build-id.c: Fix common/ includes.
8997         * btrace.h: Fix common/ includes.
8998         * btrace.c: Fix common/ includes.
8999         * breakpoint.h: Fix common/ includes.
9000         * breakpoint.c: Fix common/ includes.
9001         * ax.h:
9002         (enum agent_op): Fix common/ includes.
9003         * ax-general.c (struct aop_map): Fix common/ includes.
9004         * ax-gdb.c: Fix common/ includes.
9005         * auxv.c: Fix common/ includes.
9006         * auto-load.c: Fix common/ includes.
9007         * arm-tdep.c: Fix common/ includes.
9008         * arch/riscv.c: Fix common/ includes.
9009         * arch/ppc-linux-common.c: Fix common/ includes.
9010         * arch/i386.c: Fix common/ includes.
9011         * arch/arm.c: Fix common/ includes.
9012         * arch/arm-linux.c: Fix common/ includes.
9013         * arch/arm-get-next-pcs.c: Fix common/ includes.
9014         * arch/amd64.c: Fix common/ includes.
9015         * arch/aarch64.c: Fix common/ includes.
9016         * arch/aarch64-insn.c: Fix common/ includes.
9017         * arch-utils.c: Fix common/ includes.
9018         * amd64-windows-tdep.c: Fix common/ includes.
9019         * amd64-tdep.c: Fix common/ includes.
9020         * amd64-sol2-tdep.c: Fix common/ includes.
9021         * amd64-obsd-tdep.c: Fix common/ includes.
9022         * amd64-nbsd-tdep.c: Fix common/ includes.
9023         * amd64-linux-tdep.c: Fix common/ includes.
9024         * amd64-linux-nat.c: Fix common/ includes.
9025         * amd64-fbsd-tdep.c: Fix common/ includes.
9026         * amd64-fbsd-nat.c: Fix common/ includes.
9027         * amd64-dicos-tdep.c: Fix common/ includes.
9028         * amd64-darwin-tdep.c: Fix common/ includes.
9029         * agent.c: Fix common/ includes.
9030         * ada-lang.h: Fix common/ includes.
9031         * ada-lang.c: Fix common/ includes.
9032         * aarch64-tdep.c: Fix common/ includes.
9033
9034 2019-01-25  Tom Tromey  <tom@tromey.com>
9035
9036         * common/create-version.sh: Use common/version.h.
9037
9038 2019-01-24  Pedro Alves  <palves@redhat.com>
9039
9040         * infrun.c (signal_stop, signal_print, signal_program)
9041         (signal_catch, signal_pass): Now arrays instead of pointers.
9042         (update_signals_program_target, do_target_resume)
9043         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9044         * linux-nat.c (linux_nat_target::pass_signals)
9045         (linux_nat_target::create_inferior, linux_nat_target::attach):
9046         Adjust.
9047         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9048         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9049         * procfs.c (procfs_target::pass_signals): Adjust.
9050         * record-full.c (record_full_target::resume): Adjust.
9051         * remote.c (remote_target::pass_signals)
9052         (remote_target::program_signals): Adjust.
9053         * target-debug.h (target_debug_print_signals): Now takes a
9054         gdb::array_view as parameter.  Adjust.
9055         * target.h (target_ops) <pass_signals, program_signals>: Replace
9056         pointer and length parameters with gdb::array_view.
9057         (target_pass_signals, target_program_signals): Likewise.
9058         * target-delegates.c: Regenerate.
9059
9060 2019-01-24  Pedro Alves  <palves@redhat.com>
9061
9062         * common/forward-scope-exit.h
9063         (forward_scope_exit::forward_scope_exit): Pass arguments to
9064         m_bind_function directly, instead of creating a std::bind and
9065         copying that.
9066
9067 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9068
9069         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9070         for static members.
9071         (pass_in_v_vfp_candidate): Likewise.
9072
9073 2019-01-23  Tom Tromey  <tom@tromey.com>
9074             Pedro Alves  <palves@redhat.com>
9075
9076         * regcache.c (class regcache_invalidator): Remove.
9077         (regcache::raw_write): Use make_scope_exit.
9078
9079 2019-01-23  Tom Tromey  <tom@tromey.com>
9080
9081         * ui-out.h (class ui_out_emit_type): Update comment.
9082
9083 2019-01-23  Tom Tromey  <tom@tromey.com>
9084
9085         * infrun.c (fetch_inferior_event): Update comment.
9086
9087 2019-01-23  Tom Tromey  <tom@tromey.com>
9088             Pedro Alves  <palves@redhat.com>
9089
9090         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9091         parameter.
9092         (fetch_inferior_event): Use SCOPE_EXIT.
9093
9094
9095 2019-01-23  Tom Tromey  <tom@tromey.com>
9096             Pedro Alves  <palves@redhat.com>
9097
9098         * infrun.c (disable_thread_events): Delete.
9099         (stop_all_threads): Use SCOPE_EXIT.
9100
9101 2019-01-23  Tom Tromey  <tom@tromey.com>
9102             Pedro Alves  <palves@redhat.com>
9103
9104         * symfile.c: Include forward-scope-exit.h.
9105         (clear_symtab_users_cleanup): Replace forward declaration with
9106         a FORWARD_SCOPE_EXIT.
9107         (syms_from_objfile_1): Use the forward_scope_exit and
9108         gdb::optional instead of cleanup_function.
9109         (reread_symbols): Use the forward_scope_exit instead of
9110         cleanup_function.
9111         (clear_symtab_users_cleanup): Remove function.
9112
9113 2019-01-23  Tom Tromey  <tom@tromey.com>
9114             Pedro Alves  <palves@redhat.com>
9115
9116         * linux-nat.c: Include scope-exit.h.
9117         (cleanup_target_stop): Remove.
9118         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9119         SCOPE_EXIT.
9120
9121 2019-01-23  Tom Tromey  <tom@tromey.com>
9122             Pedro Alves  <palves@redhat.com>
9123
9124         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9125         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9126
9127 2019-01-23  Tom Tromey  <tom@tromey.com>
9128             Andrew Burgess  <andrew.burgess@embecosm.com>
9129             Pedro Alves  <palves@redhat.com>
9130
9131         * infrun.c (fetch_inferior_event): Use scope_exit.
9132         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9133         * top.c (execute_command): Use scope_exit.
9134         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9135         * utils.c (do_bpstat_clear_actions_cleanup)
9136         (make_bpstat_clear_actions_cleanup): Remove.
9137
9138 2019-01-23  Tom Tromey  <tom@tromey.com>
9139             Pedro Alves  <palves@redhat.com>
9140
9141         * infrun.c: Include "common/scope-exit.h"
9142         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9143         (wait_for_inferior): Use SCOPE_EXIT.
9144         (fetch_inferior_event): Use scope_exit.
9145
9146 2019-01-23  Tom Tromey  <tom@tromey.com>
9147             Pedro Alves  <palves@redhat.com>
9148
9149         * breakpoint.c (create_breakpoint): Remove cleanup.
9150
9151 2019-01-23  Tom Tromey  <tom@tromey.com>
9152             Andrew Burgess  <andrew.burgess@embecosm.com>
9153             Pedro Alves  <palves@redhat.com>
9154
9155 2019-01-23  Pedro Alves  <palves@redhat.com>
9156
9157         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9158
9159 2019-01-23  Pedro Alves  <palves@redhat.com>
9160             Andrew Burgess  <andrew.burgess@embecosm.com>
9161
9162         * gdbthread.h: Include "common/forward-scope-exit.h".
9163         (scoped_finish_thread_state): Redefine custom class in terms of
9164         forward_scope_exit.
9165
9166 2019-01-23  Pedro Alves  <palves@redhat.com>
9167             Andrew Burgess  <andrew.burgess@embecosm.com>
9168
9169         * common/forward-scope-exit.h: New file.
9170
9171 2019-01-23  Pedro Alves  <palves@redhat.com>
9172             Andrew Burgess  <andrew.burgess@embecosm.com>
9173             Tom Tromey  <tom@tromey.com>
9174
9175         * common/scope-exit.h: New file.
9176
9177 2019-01-23  Pedro Alves  <palves@redhat.com>
9178
9179         * common/preprocessor.h (ESC): Rename to ...
9180         (ESC_PARENS): ... this.
9181         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9182         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9183
9184 2019-01-23  Tom Tromey  <tom@tromey.com>
9185
9186         * language.h (class scoped_switch_to_sym_language_if_auto):
9187         Initialize m_lang in both cases.
9188
9189 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9190
9191         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9192         with XCNEW.
9193
9194 2019-01-22  Tom Tromey  <tom@tromey.com>
9195
9196         * corelow.c: Do not include sys/file.h.
9197
9198 2019-01-22  Tom Tromey  <tom@tromey.com>
9199
9200         * tui/tui-wingeneral.h: Include gdb_curses.h.
9201
9202 2019-01-22  Tom Tromey  <tom@tromey.com>
9203
9204         * source-cache.h (class source_cache) <get_source_lines,
9205         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9206
9207 2019-01-22  Tom Tromey  <tom@tromey.com>
9208
9209         * remote-fileio.h (struct remote_target): Declare.
9210
9211 2019-01-22  Tom Tromey  <tom@tromey.com>
9212
9213         * python/py-arch.c: Do not include py-ref.h.
9214         * python/py-bpevent.c: Do not include py-ref.h.
9215         * python/py-cmd.c: Do not include py-ref.h.
9216         * python/py-continueevent.c: Do not include py-ref.h.
9217         * python/py-event.h: Do not include py-ref.h.
9218         * python/py-evtregistry.c: Do not include py-ref.h.
9219         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9220         * python/py-frame.c: Do not include py-ref.h.
9221         * python/py-framefilter.c: Do not include py-ref.h.
9222         * python/py-function.c: Do not include py-ref.h.
9223         * python/py-infevents.c: Do not include py-ref.h.
9224         * python/py-linetable.c: Do not include py-ref.h.
9225         * python/py-objfile.c: Do not include py-ref.h.
9226         * python/py-param.c: Do not include py-ref.h.
9227         * python/py-prettyprint.c: Do not include py-ref.h.
9228         * python/py-progspace.c: Do not include py-ref.h.
9229         * python/py-symbol.c: Do not include py-ref.h.
9230         * python/py-symtab.c: Do not include py-ref.h.
9231         * python/py-type.c: Do not include py-ref.h.
9232         * python/py-unwind.c: Do not include py-ref.h.
9233         * python/py-utils.c: Do not include py-ref.h.
9234         * python/py-value.c: Do not include py-ref.h.
9235         * python/py-varobj.c: Do not include py-ref.h.
9236         * python/py-xmethods.c: Do not include py-ref.h.
9237         * python/python.c: Do not include py-ref.h.
9238         * varobj.c: Do not include py-ref.h.
9239
9240 2019-01-22  Tom Tromey  <tom@tromey.com>
9241
9242         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9243         keyword for bcache.
9244
9245 2019-01-22  Tom Tromey  <tom@tromey.com>
9246
9247         * compile/compile-cplus-types.c: Remove a comment by #include.
9248
9249 2019-01-22  Tom Tromey  <tom@tromey.com>
9250
9251         * compile/gcc-c-plugin.h: Include compile-internal.h.
9252
9253 2019-01-22  Tom Tromey  <tom@tromey.com>
9254
9255         * stabsread.c (EXTERN): Do not define.
9256         (symnum, next_symbol_text_func, processing_gcc_compilation)
9257         (within_function, global_sym_chain, global_stabs)
9258         (previous_stab_code, this_object_header_files)
9259         (n_this_object_header_files)
9260         (n_allocated_this_object_header_files): Define.
9261         * stabsread.h (EXTERN): Never define.  Use "extern".
9262
9263 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9264
9265         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9266         history_value.
9267
9268 2019-01-21  Tom Tromey  <tom@tromey.com>
9269
9270         * ui-out.c: Fix includes.
9271         * tui/tui-source.c: Fix includes.
9272         * target.c: Fix includes.
9273         * remote.c: Fix includes.
9274         * regcache.c: Fix includes.
9275         * python/py-block.c: Fix includes.
9276         * printcmd.c: Fix includes.
9277         * or1k-tdep.c: Fix includes.
9278         * mi/mi-main.c: Fix includes.
9279         * m32r-tdep.c: Fix includes.
9280         * csky-tdep.c: Fix includes.
9281         * compile/compile-cplus-types.c: Fix includes.
9282         * cli/cli-interp.c: Fix includes.
9283
9284 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9285
9286         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9287         for padding.
9288
9289 2019-01-16  Tom Tromey  <tom@tromey.com>
9290
9291         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9292         earlier.
9293         (struct objfile) <msymbols_range>: Move from top level.
9294         <msymbols>: New method.
9295         (class objfile_msymbols): Remove.
9296         * symtab.c (default_collect_symbol_completion_matches_break_on):
9297         Update.
9298         * symmisc.c (dump_msymbols): Update.
9299         * stabsread.c (scan_file_globals): Update.
9300         * objc-lang.c (info_selectors_command, info_classes_command)
9301         (find_methods): Update.
9302         * minsyms.c (find_solib_trampoline_target): Update.
9303         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9304         * coffread.c (coff_symfile_read): Update.
9305         * ada-lang.c (ada_lookup_simple_minsym)
9306         (ada_collect_symbol_completion_matches): Update.
9307
9308 2019-01-16  Tom Tromey  <tom@tromey.com>
9309
9310         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9311         type.  Remove no-argument constructor.
9312         <iterator::operator++>: Simplify.
9313         <begin>: Update.
9314         <end>: Use minimal_symbol_count.
9315
9316 2019-01-16  Tom Tromey  <tom@tromey.com>
9317
9318         * objfiles.h (struct objfile) <psymtabs>: New method.
9319         (class objfile_psymtabs): Remove.
9320         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9321         typedef.
9322         <range>: New method.
9323         (require_partial_symbols): Change return type.
9324         * psymtab.c (require_partial_symbols)
9325         (psym_expand_symtabs_matching): Update.
9326         * mdebugread.c (parse_partial_symbols): Update.
9327         * dbxread.c (dbx_end_psymtab): Update.
9328
9329 2019-01-15  Tom Tromey  <tom@tromey.com>
9330
9331         * symtab.c (lookup_objfile_from_block)
9332         (lookup_symbol_in_objfile_symtabs)
9333         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9334         (find_line_symtab, info_sources_command)
9335         (default_collect_symbol_completion_matches_break_on)
9336         (make_source_files_completion_list): Update.
9337         * symmisc.c (print_objfile_statistics, dump_objfile)
9338         (maintenance_print_symbols, maintenance_info_symtabs)
9339         (maintenance_check_symtabs, maintenance_info_line_tables):
9340         Update.
9341         * source.c (select_source_symtab)
9342         (forget_cached_source_info_for_objfile): Update.
9343         * objfiles.h (class objfile_compunits): Remove.
9344         (struct objfile) <compunits_range>: New typedef.
9345         (compunits): New method.
9346         * objfiles.c (objfile_relocate1): Update.
9347         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9348         * maint.c (count_symtabs_and_blocks): Update.
9349         * linespec.c (iterate_over_all_matching_symtabs): Update.
9350         * cp-support.c (add_symbol_overload_list_qualified): Update.
9351         * coffread.c (coff_symtab_read): Update.
9352         * ada-lang.c (add_nonlocal_symbols)
9353         (ada_collect_symbol_completion_matches)
9354         (ada_add_global_exceptions): Update.
9355
9356 2019-01-15  Tom Tromey  <tom@tromey.com>
9357
9358         * progspace.h (program_space) <objfiles_safe_range>: New
9359         typedef.
9360         <objfiles_safe>: New method.
9361         * objfiles.h (class all_objfiles_safe): Remove.
9362         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9363         * jit.c (jit_inferior_exit_hook): Update.
9364
9365 2019-01-17  Tom Tromey  <tom@tromey.com>
9366
9367         * progspace.h (program_space) <objfiles_range>: New typedef.
9368         <objfiles>: New method.
9369         <objfiles_head>: Rename from objfiles.
9370         (object_files): Update.
9371         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9372         * guile/scm-pretty-print.c
9373         (ppscm_find_pretty_printer_from_objfiles): Update.
9374         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9375         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9376         Update.
9377         * python/py-progspace.c (pspy_get_objfiles): Update.
9378         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9379         Update.
9380         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9381         (objfpy_lookup_objfile_by_build_id): Update.
9382         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9383         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9384         Update.
9385         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9386         (expand_symtab_containing_pc, lookup_objfile_from_block)
9387         (lookup_static_symbol, basic_lookup_transparent_type)
9388         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9389         (find_line_symtab, info_sources_command)
9390         (default_collect_symbol_completion_matches_break_on)
9391         (make_source_files_completion_list, find_main_name): Update.
9392         * symmisc.c (print_symbol_bcache_statistics)
9393         (print_objfile_statistics, maintenance_print_symbols)
9394         (maintenance_print_msymbols, maintenance_print_objfiles)
9395         (maintenance_info_symtabs, maintenance_check_symtabs)
9396         (maintenance_expand_symtabs, maintenance_info_line_tables):
9397         Update.
9398         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9399         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9400         (map_overlay_command, unmap_overlay_command)
9401         (simple_overlay_update, expand_symtabs_matching)
9402         (map_symbol_filenames): Update.
9403         * symfile-debug.c (set_debug_symfile): Update.
9404         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9405         Update.
9406         * source.c (select_source_symtab, forget_cached_source_info):
9407         Update.
9408         * solib.c (solib_read_symbols): Update.
9409         * solib-spu.c (append_ocl_sos): Update.
9410         * psymtab.c (maintenance_print_psymbols)
9411         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9412         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9413         * printcmd.c (info_symbol_command): Update.
9414         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9415         Update.
9416         * objfiles.h (class all_objfiles): Remove.
9417         * objfiles.c (have_partial_symbols, have_full_symbols)
9418         (have_minimal_symbols, qsort_cmp, update_section_map)
9419         (shared_objfile_contains_address_p)
9420         (default_iterate_over_objfiles_in_search_order): Update.
9421         * objc-lang.c (info_selectors_command, info_classes_command)
9422         (find_methods): Update.
9423         * minsyms.c (find_solib_trampoline_target): Update.
9424         * maint.c (maintenance_info_sections)
9425         (maintenance_translate_address, count_symtabs_and_blocks):
9426         Update.
9427         * main.c (captured_main_1): Update.
9428         * linux-thread-db.c (try_thread_db_load_from_pdir)
9429         (has_libpthread): Update.
9430         * linespec.c (iterate_over_all_matching_symtabs)
9431         (search_minsyms_for_name): Update.
9432         * jit.c (jit_find_objf_with_entry_addr): Update.
9433         * hppa-tdep.c (find_unwind_entry)
9434         (hppa_lookup_stub_minimal_symbol): Update.
9435         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9436         Update.
9437         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9438         (elf_gnu_ifunc_resolve_by_got): Update.
9439         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9440         * dwarf-index-write.c (save_gdb_index_command): Update.
9441         * cp-support.c (add_symbol_overload_list_qualified): Update.
9442         * breakpoint.c (create_overlay_event_breakpoint)
9443         (create_longjmp_master_breakpoint)
9444         (create_std_terminate_master_breakpoint)
9445         (create_exception_master_breakpoint): Update.
9446         * blockframe.c (find_pc_partial_function): Update.
9447         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9448         (ada_collect_symbol_completion_matches)
9449         (ada_add_global_exceptions): Update.
9450
9451 2019-01-17  Tom Tromey  <tom@tromey.com>
9452
9453         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9454         declare VEC.
9455         (solib_target_parse_libraries): Change return type.
9456         (library_list_start_segment, library_list_start_section)
9457         (library_list_end_library, library_list_start_library); Update.
9458         (solib_target_free_library_list): Remove.
9459         (solib_target_parse_libraries): Remove cleanup.  Change return
9460         type.
9461         (solib_target_current_sos): Update.
9462
9463 2019-01-17  Tom Tromey  <tromey@bapiya>
9464
9465         * valprint.c: Replace "the the" with "the".
9466         * symtab.c: Replace "the the" with "the".
9467         * solib.c: Replace "the the" with "the".
9468         * solib-dsbt.c: Replace "the the" with "the".
9469         * linespec.c: Replace "the the" with "the".
9470         * dwarf2loc.h: Replace "the the" with "the".
9471         * amd64-windows-tdep.c: Replace "the the" with "the".
9472         * aarch64-tdep.c: Replace "the the" with "the".
9473
9474 2019-01-16  Keith Seitz  <keiths@redhat.com>
9475
9476         PR gdb/23773
9477         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9478         <builder>: Rename to ..
9479         <m_builder>: ... this and make private.
9480         (dwarf2_cu::get_builder): New method.  Change all users of
9481         `builder' to use this method.
9482         (dwarf2_start_symtab): Move to ...
9483         (dwarf2_cu::start_symtab): ... here.  Update all callers
9484         (setup_type_unit_groups): Move to ...
9485         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9486         callers.
9487         (dwarf2_cu::reset_builder): New method.
9488         (process_full_compunit, process_full_type_unit): Use
9489         dwarf2_cu::reset_builder.
9490         (follow_die_offset): Record the ancestor CU if it is different
9491         from the followed DIE's CU.
9492         (follow_die_sig_1): Likewise.
9493
9494 2019-01-15  Tom Tromey  <tom@tromey.com>
9495
9496         * remote.c (class remote_state) <buf>: Now a char_vector.
9497         <buf_size>: Remove.
9498         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9499         parameter.
9500         (remote_target::getpkt_or_notif_sane_1)
9501         (remote_target::getpkt_sane)
9502         (remote_target::getpkt_or_notif_sane): Likewise.
9503         (class remote_target) <putpkt>: New overload.
9504         (remote_target::read_frame): Change type of "buf_p".  Remove
9505         sizeof_p parameter.
9506         (packet_ok): New overload.
9507         (packet_check_result): New overload.
9508         Update all uses.
9509
9510 2019-01-14  Tom Tromey  <tom@tromey.com>
9511
9512         * remote-notif.c (handle_notification, remote_notif_ack)
9513         (remote_notif_parse): Make "buf" const.
9514         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9515         const.
9516         (remote_notif_parse, remote_notif_ack, handle_notification):
9517         Likewise.
9518         * remote.c (remote_notif_stop_parse): Make "buf" const.
9519         (remote_target::remote_parse_stop_reply): Make "buf" const.
9520         (remote_notif_stop_ack): Make "buf" const.
9521
9522 2019-01-14  Tom Tromey  <tom@tromey.com>
9523
9524         * remote.c (remote_console_output): Make parameter const.
9525
9526 2019-01-14  Tom Tromey  <tom@tromey.com>
9527
9528         * target-debug.h (target_debug_print_signals): Constify.
9529         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9530         * procfs.c (procfs_target::pass_signals): Update.
9531         * linux-nat.c (linux_nat_target::pass_signals): Update.
9532         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9533         * target-delegates.c: Rebuild.
9534         * remote.c (remote_target::program_signals): Update.
9535         (remote_target::pass_signals): Update.
9536         * target.c (target_pass_signals): Constify argument.
9537         (target_program_signals): Likewise.
9538         * target.h (struct target_ops) <pass_signals, program_signals>:
9539         Constify argument.
9540         (target_pass_signals, target_program_signals): Constify argument.
9541
9542 2019-01-14  Tom Tromey  <tom@tromey.com>
9543
9544         PR tui/28819:
9545         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9546
9547 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9548
9549         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9550         field.
9551         * rs6000-tdep.c: Include reggroups.h.
9552         (IS_V_ALIAS_PSEUDOREG): Define.
9553         (rs6000_register_name): Return names for the "vX" aliases.
9554         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9555         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9556         aliases.  Call default_register_reggroup_p for all other
9557         pseudo-registers.
9558         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9559         New functions.
9560         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9561         Handle "vX" aliases.
9562         (v_alias_pseudo_register_collect): New function.
9563         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9564         (rs6000_gdbarch_init): Initialize "vX" aliases as
9565         pseudo-registers.  Restore registration of
9566         rs6000_pseudo_register_reggroup_p with
9567         set_tdesc_pseudo_register_reggroup_p.
9568
9569 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9570
9571         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9572         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9573         set_gdbarch_num_pseudo_regs.
9574
9575 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9576
9577         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9578         Remove arg prefixname, add do_set and do_show.
9579         Add member functions set_list and show_list.
9580         * cli/cli-style.c (class cli_style_option): Update accordingly.
9581         (style_set_list): Move to file scope.
9582         (style_show_list): Likewise.
9583         (set_style): Call help_list.
9584         (show_style): Call cmd_show_list.
9585         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9586         Update to use the new macro.
9587
9588 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9589
9590         * ada-lang.c (_initialize_ada_language): Expand the help text
9591         for the "catch exception" command.
9592
9593 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9594
9595         * symtab.c (matching_obj_sections): Initialize obj,
9596         declare it closer to its usage.
9597
9598 2019-01-10  Tom Tromey  <tom@tromey.com>
9599
9600         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9601         (basic_inf_threads_range): Remove.
9602         (inf_threads_range, inf_non_exited_threads_range)
9603         (safe_inf_threads_range): Use next_adapter.
9604
9605 2019-01-10  Keith Seitz  <keiths@redhat.com>
9606
9607         PR gdb/23712
9608         PR symtab/23010
9609         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9610         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9611
9612 2019-01-10  Keith Seitz  <keiths@redhat.com>
9613
9614         PR gdb/23712
9615         PR symtab/23010
9616         * dictionary.c (pending_to_vector): Remove.
9617         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9618         Remove _1 suffix, replacing functions of the same name.  Update
9619         all callers.
9620         (dict_create_hashed, dict_create_hashed_expandable)
9621         (dict_create_linear, dict_create_linear_expandable, dict_free)
9622         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9623         Make functions static.
9624
9625 2019-01-10  Keith Seitz  <keiths@redhat.com>
9626
9627         PR gdb/23712
9628         PR symtab/23010
9629         * dictionary.h (struct dictionary): Replace declaration with
9630         multidictionary.
9631         (dict_create_hashed, dict_create_hashed_expandable)
9632         (dict_create_linear, dict_create_linear_expandable)
9633         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9634         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9635         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9636         taking multidictionary argument.
9637         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9638         * block.h (struct block) <dict>: Change to multidictionary
9639         and rename `multidict'.
9640         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9641         symmisc.c: Update all dictionary references to multidictionary.
9642
9643 2019-01-10  Keith Seitz  <keiths@redhat.com>
9644
9645         PR gdb/23712
9646         PR symtab/23010
9647         * dictionary.c: Include unordered_map.
9648         (pending_to_vector): New function.
9649         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9650         Rewrite the non-"_1" functions to take vector instead
9651         of linked list.
9652         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9653         "new" _1 versions of the same name.
9654         (multidictionary): Define.
9655         (std::hash<enum language): New definition.
9656         (collate_pending_symbols_by_language, mdict_create_hashed)
9657         (mdict_create_hashed_expandable, mdict_create_linear)
9658         (mdict_create_linear_expandable, mdict_free)
9659         (find_language_dictionary, create_new_language_dictionary)
9660         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9661         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9662         (mdict_size, mdict_empty): New functions.
9663         * dictionary.h (mdict_iterator): Define.
9664
9665 2019-01-10  Pedro Alves  <palves@redhat.com>
9666
9667         * breakpoint.c (read_uploaded_action)
9668         (create_tracepoint_from_upload): Adjust to use
9669         gdb::unique_xmalloc_ptr.
9670         * ctf.c (ctf_write_uploaded_tp):
9671         (SET_ARRAY_FIELD): Use emplace_back.
9672         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9673         * tracefile-tfile.c (tfile_write_uploaded_tp):
9674         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9675         gdb::unique_xmalloc_ptr.
9676         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9677         at_string, cond_string, cmd_strings>: Replace char pointers
9678         with gdb::unique_xmalloc_ptr.
9679
9680 2019-01-10  Pedro Alves  <palves@redhat.com>
9681
9682         * solib-target.c (library_list_start_library): Don't xstrdup name.
9683
9684 2019-01-10  Pedro Alves  <palves@redhat.com>
9685
9686         * mdebugread.c (parse_partial_symbols): Use
9687         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9688
9689 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9690
9691         * linux-fork.c (scoped_switch_fork_info)
9692         <~scoped_switch_fork_info>: Fix incorrect variable name.
9693
9694 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9695
9696         * linux-fork.c (scoped_switch_fork_info)
9697         <scoped_switch_fork_info>: Make explicit.
9698         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9699
9700 2019-01-10  Tom Tromey  <tom@tromey.com>
9701
9702         * objfiles.h (objfile::reset_psymtabs): Update.
9703         * objfiles.c (objfile::objfile): Update.
9704         * psymtab.h (psymtab_storage::obstack): Update.
9705         (psymtab_storage::m_obstack): Use gdb::optional.
9706         (class psymtab_storage): Update comment.  Remove objfile
9707         parameter.
9708         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9709
9710 2019-01-10  Tom Tromey  <tom@tromey.com>
9711
9712         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9713         <free_psymtabs>: Now private.
9714         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9715         (allocate_psymtab): Use new method.
9716
9717 2019-01-10  Tom Tromey  <tom@tromey.com>
9718
9719         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9720         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9721         * mdebugread.c (parse_partial_symbols): Use
9722         allocate_dependencies.
9723         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9724         allocate_dependencies.
9725         (process_psymtab_comp_unit_reader)
9726         (build_type_psymtab_dependencies): Likewise.
9727         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9728
9729 2019-01-10  Tom Tromey  <tom@tromey.com>
9730
9731         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9732         PSYMBOL_SET_LANGUAGE.
9733         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9734
9735 2019-01-10  Tom Tromey  <tom@tromey.com>
9736
9737         * psymtab.h (psymtab_storage::obstack): New method.
9738         <m_obstack>: Rename from obstack; now private.
9739         * psymtab.c (psymtab_storage): Update.
9740         * dwarf2read.c (create_addrmap_from_index)
9741         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9742         Update.
9743
9744 2019-01-10  Tom Tromey  <tom@tromey.com>
9745
9746         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9747         * objfiles.h (objfile::reset_psymtabs): New method.
9748
9749 2019-01-10  Tom Tromey  <tom@tromey.com>
9750
9751         * symmisc.c (print_symbol_bcache_statistics): Update.
9752         (print_objfile_statistics): Update.
9753         * symfile.c (reread_symbols): Update.
9754         * psymtab.h (class psymtab_storage): New.
9755         * psymtab.c (psymtab_storage): New constructor.
9756         (~psymtab_storage): New destructor.
9757         (require_partial_symbols): Update.
9758         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9759         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9760         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9761         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9762         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9763         (start_psymtab_common, end_psymtab_common)
9764         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9765         (allocate_psymtab): Update.
9766         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9767         Update.
9768         (dump_psymtab_addrmap, maintenance_print_psymbols)
9769         (maintenance_check_psymtabs): Update.
9770         (class objfile_psymtabs): Move to objfiles.h.
9771         * psympriv.h (discard_psymtab): Now inline.
9772         (psymtab_discarder::psymtab_discarder): Update.
9773         (psymtab_discarder::~psymtab_discarder): Update.
9774         (ALL_OBJFILE_PSYMTABS): Rewrite.
9775         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9776         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9777         Remove fields.
9778         <partial_symtabs>: New field.
9779         (class objfile_psymtabs): Move from psymtab.h.  Update.
9780         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9781         psymbol_cache.
9782         (objfile::~objfile): Don't destroy psymbol_cache.
9783         * mdebugread.c (parse_partial_symbols): Update.
9784         * dwarf2read.c (create_addrmap_from_index)
9785         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9786         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9787         (add_partial_subprogram, dwarf2_ranges_read): Update.
9788         * dwarf-index-write.c (write_address_map)
9789         (write_one_signatured_type, recursively_write_psymbols)
9790         (class debug_names, class debug_names, write_psymtabs_to_index):
9791         Update.
9792
9793 2019-01-10  Tom Tromey  <tom@tromey.com>
9794
9795         * symtab.h (SYMBOL_SET_NAMES): Update.
9796         (symbol_set_names): Update.
9797         (MSYMBOL_SET_NAMES): Update.
9798         * symtab.c (symbol_set_names): Change argument to be an
9799         objfile_per_bfd_storage.
9800         * psymtab.c (add_psymbol_to_bcache): Update.
9801         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9802
9803 2019-01-10  Tom Tromey  <tom@tromey.com>
9804
9805         * symtab.c (create_demangled_names_hash): Change argument to be an
9806         objfile_per_bfd_storage.
9807         (symbol_set_names): Update.
9808
9809 2019-01-10  Tom Tromey  <tom@tromey.com>
9810
9811         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9812         init_psymbol_list.
9813         * psymtab.c (init_psymbol_list): Do nothing if already called.
9814         * psympriv.h (init_psymbol_list): Add comment.
9815         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9816         init_psymbol_list.
9817         * dbxread.c (dbx_symfile_read): Unconditionally call
9818         init_psymbol_list.
9819
9820 2019-01-10  Tom Tromey  <tom@tromey.com>
9821
9822         * xcoffread.c (scan_xcoff_symtab): Update.
9823         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9824         "where".
9825         * mdebugread.c (parse_partial_symbols)
9826         (handle_psymbol_enumerators): Update.
9827         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9828         * dbxread.c (read_dbx_symtab): Update.
9829         * psympriv.h (psymbol_placement): New enum.
9830         (add_psymbol_to_list): Update.
9831
9832 2019-01-10  Tom Tromey  <tom@tromey.com>
9833
9834         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9835         static_psymbols parameters.
9836         (scan_xcoff_symtab): Update.
9837         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9838         static_psymbols parameters.
9839         * psympriv.h (start_psymtab_common): Update.
9840         * mdebugread.c (parse_partial_symbols): Update.
9841         * dwarf2read.c (create_partial_symtab): Update.
9842         * dbxread.c (read_dbx_symtab): Update.
9843         (start_psymtab): Remove global_psymbols and static_psymbols
9844         parameters.
9845
9846 2019-01-10  Tom Tromey  <tom@tromey.com>
9847
9848         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9849         * psymtab.c (allocate_psymtab): Add comment.
9850         * psympriv.h (allocate_psymtab): Add comment.
9851         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9852         initializations.
9853         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9854
9855 2019-01-10  Tom Tromey  <tom@tromey.com>
9856
9857         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9858         Don't declare.
9859         * mipsread.c: Include mdebugread.h.
9860         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9861         Declare.
9862         * elfread.c: Include mdebugread.h.
9863
9864 2019-01-09  Tom Tromey  <tom@tromey.com>
9865
9866         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9867         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9868         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9869         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9870         (psym_lookup_symbol, psym_find_last_source_symtab)
9871         (psym_forget_cached_source_info, psym_print_stats)
9872         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9873         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9874         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9875         (psym_find_compunit_symtab_by_address)
9876         (maintenance_print_psymbols, maintenance_info_psymtabs)
9877         (maintenance_check_psymtabs): Use ranged for.
9878         * psymtab.h (class objfile_psymtabs): New.
9879         (require_partial_symbols): Return objfile_psymtabs.
9880         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9881
9882 2019-01-09  Tom Tromey  <tom@tromey.com>
9883
9884         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9885         (find_pc_mapped_section, list_overlays_command)
9886         (map_overlay_command, unmap_overlay_command)
9887         (simple_overlay_update): Use all_objfiles.
9888         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9889         * printcmd.c (info_symbol_command): Use all_objfiles.
9890         * objfiles.h (ALL_OBJSECTIONS): Remove.
9891         * maint.c (maintenance_translate_address): Use all_objfiles.
9892         * gcore.c (gcore_create_callback): Use all_objfiles.
9893         (objfile_find_memory_regions): Likewise.
9894
9895 2019-01-09  Tom Tromey  <tom@tromey.com>
9896
9897         * symtab.c (find_line_symtab, info_sources_command)
9898         (make_source_files_completion_list): Use objfile_compunits.
9899         * source.c (select_source_symtab): Use objfile_compunits.
9900         * objfiles.h (struct objfile): Update comment.
9901         (ALL_OBJFILES): Remove.
9902         (ALL_FILETABS): Remove.
9903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9904         objfile_compunits.
9905
9906 2019-01-09  Tom Tromey  <tom@tromey.com>
9907
9908         * symmisc.c (print_objfile_statistics, dump_objfile)
9909         (maintenance_print_symbols): Use compunit_filetabs.
9910         * source.c (forget_cached_source_info_for_objfile): Use
9911         compunit_filetabs.
9912         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9913         (ALL_FILETABS): Use compunit_filetabs.
9914         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9915         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9916
9917 2019-01-09  Tom Tromey  <tom@tromey.com>
9918
9919         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9920         (compunit_filetabs): New.
9921         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9922         compunit_filetabs.
9923         (info_sources_command, make_source_files_completion_list): Remove
9924         declaration.
9925         * symmisc.c (print_objfile_statistics, dump_objfile)
9926         (maintenance_print_symbols): Remove declaration.
9927         (maintenance_info_symtabs): Use compunit_filetabs.
9928         (maintenance_info_line_tables): Likewise.
9929         * source.c (select_source_symtab): Change local variable name.
9930         (forget_cached_source_info_for_objfile): Remove declaration.
9931         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9932         * objfiles.c (objfile_relocate1): Remove declaration.
9933         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9934         declaration.
9935         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9936         * coffread.c (coff_symtab_read): Remove declaration.
9937         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9938         compunit_filetabs.
9939
9940 2019-01-09  Tom Tromey  <tom@tromey.com>
9941
9942         * symtab.c (lookup_objfile_from_block)
9943         (find_pc_sect_compunit_symtab, search_symbols)
9944         (default_collect_symbol_completion_matches_break_on): Use
9945         objfile_compunits.
9946         * objfiles.h (ALL_COMPUNITS): Remove.
9947         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9948         * cp-support.c (add_symbol_overload_list_qualified): Use
9949         objfile_compunits.
9950         * ada-lang.c (ada_collect_symbol_completion_matches)
9951         (ada_add_global_exceptions): Use objfile_compunits.
9952
9953 2019-01-09  Tom Tromey  <tom@tromey.com>
9954
9955         * source.c (select_source_symtab)
9956         (forget_cached_source_info_for_objfile): Remove declaration.
9957         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9958         declaration.
9959         * maint.c (count_symtabs_and_blocks): Remove declaration.
9960         * cp-support.c (add_symbol_overload_list_qualified): Remove
9961         declaration.
9962         * coffread.c (coff_symtab_read): Remove declaration.
9963         * symtab.c (lookup_symbol_in_objfile_symtabs)
9964         (basic_lookup_transparent_type_1): Use objfile_compunits.
9965         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9966         (info_sources_command, search_symbols)
9967         (default_collect_symbol_completion_matches_break_on)
9968         (make_source_files_completion_list): Remove declaration.
9969         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9970         (ada_collect_symbol_completion_matches)
9971         (ada_add_global_exceptions): Remove declaration.
9972         * linespec.c (iterate_over_all_matching_symtabs): Use
9973         objfile_compunits.
9974         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9975         (class objfile_compunits): New.
9976         (ALL_COMPUNITS): Use objfile_compunits.
9977         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9978         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9979         objfile_compunits.
9980         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9981
9982 2019-01-09  Tom Tromey  <tom@tromey.com>
9983
9984         * symtab.c (search_symbols)
9985         (default_collect_symbol_completion_matches_break_on): Use
9986         objfile_msymbols.
9987         * ada-lang.c (ada_lookup_simple_minsym)
9988         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9989         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9990         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9991         objfile_msymbols.
9992         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9993         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9994         * objc-lang.c (find_methods): Use objfile_msymbols.
9995         (info_selectors_command, info_classes_command): Likewise.
9996         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9997         * objfiles.h (class objfile_msymbols): New.
9998         (ALL_OBJFILE_MSYMBOLS): Remove.
9999         (ALL_MSYMBOLS): Remove.
10000
10001 2019-01-09  Tom Tromey  <tom@tromey.com>
10002
10003         * common/next-iterator.h (next_adapter): Add Iterator template
10004         parameter.
10005         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10006         (class all_objfiles_safe): New.
10007         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10008         * objfiles.c (put_objfile_before): Update comment.
10009         (add_separate_debug_objfile): Likewise.
10010         (free_all_objfiles): Use all_objfiles_safe.
10011         (objfile_purge_solibs): Likewise.
10012
10013 2019-01-09  Tom Tromey  <tom@tromey.com>
10014
10015         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10016         (expand_symtab_containing_pc, lookup_static_symbol)
10017         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10018         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10019         all_objfiles.
10020         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10021         * breakpoint.c (create_overlay_event_breakpoint)
10022         (create_longjmp_master_breakpoint)
10023         (create_std_terminate_master_breakpoint)
10024         (create_exception_master_breakpoint): Use all_objfiles.
10025         * linux-thread-db.c (try_thread_db_load_from_pdir)
10026         (has_libpthread): Use all_objfiles.
10027         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10028         * linespec.c (iterate_over_all_matching_symtabs)
10029         (search_minsyms_for_name): Use all_objfiles.
10030         * maint.c (maintenance_info_sections): Use all_objfiles.
10031         * main.c (captured_main_1): Use all_objfiles.
10032         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10033         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10034         * guile/scm-pretty-print.c
10035         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10036         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10037         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10038         (maintenance_print_msymbols): Use all_objfiles.
10039         * source.c (select_source_symtab): Use all_objfiles.
10040         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10041         * symfile.c (remove_symbol_file_command)
10042         (expand_symtabs_matching, map_symbol_filenames): Use
10043         all_objfiles.
10044         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10045         all_objfiles.
10046         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10047         * objc-lang.c (find_methods): Use all_objfiles.
10048         * objfiles.c (have_partial_symbols, have_full_symbols)
10049         (have_minimal_symbols, qsort_cmp)
10050         (default_iterate_over_objfiles_in_search_order): Use
10051         all_objfiles.
10052         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10053         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10054         (maintenance_check_psymtabs): Use all_objfiles.
10055         (ALL_PSYMTABS): Remove.
10056         * compile/compile-object-run.c (do_module_cleanup): Use
10057         all_objfiles.
10058         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10059         * cp-support.c (add_symbol_overload_list_qualified): Use
10060         all_objfiles.
10061         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10062         Use all_objfiles.
10063         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10064         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10065         all_objfiles.
10066         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10067         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10068         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10069         Uses all_objfiles.
10070         * solib.c (solib_read_symbols): Use all_objfiles
10071
10072 2019-01-09  Tom Tromey  <tom@tromey.com>
10073
10074         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10075         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10076         all_objfiles.
10077         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10078         * symmisc.c (print_symbol_bcache_statistics)
10079         (print_objfile_statistics, maintenance_print_objfiles)
10080         (maintenance_info_symtabs, maintenance_check_symtabs)
10081         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10082         all_objfiles.
10083         * source.c (forget_cached_source_info): Use all_objfiles.
10084         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10085         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10086         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10087         * objfiles.c (update_section_map): Use all_objfiles.
10088         (shared_objfile_contains_address_p): Likewise.
10089         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10090         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10091
10092 2019-01-09  Tom Tromey  <tom@tromey.com>
10093
10094         * common/next-iterator.h: New file.
10095         * objfiles.h (class all_objfiles): New.
10096         (struct objfile_iterator): New.
10097
10098 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10099
10100         * NEWS: Move the description of the changed "frame", "select-frame",
10101          and "info frame" commands to the Changed commands section.
10102
10103 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10104
10105         * gdbtypes.c (check_stub_method_group): Remove handling of old
10106         mangling schemes.
10107         * linespec.c (find_methods): Likewise.
10108         * stabsread.c (read_member_functions): Likewise.
10109         * valops.c (search_struct_method): Likewise.
10110         (value_struct_elt_for_reference): Likewise.
10111         * NEWS: Mention this change.
10112
10113 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10114
10115         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10116         print_source_lines.
10117         * source.c (print_source_lines_base): Update line number check.
10118         (print_source_lines): New function.
10119         (source_lines_range::source_lines_range): New function.
10120         * source.h (class source_lines_range): New class.
10121         (print_source_lines): New declaration.
10122
10123 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10124
10125         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10126
10127 2019-01-08  Tom Tromey  <tom@tromey.com>
10128             Simon Marchi  <simon.marchi@ericsson.com>
10129
10130         PR gdb/24060
10131         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10132         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10133         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10134         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10135         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10136         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10137
10138 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10139
10140         * source.c (select_source_symtab): Move header comment to
10141         declaration in source.h.
10142         (forget_cached_source_info_for_objfile): Likewise.
10143         (forget_cached_source_info): Likewise.
10144         (identify_source_line): Likewise.
10145         * source.h (identify_source_line): Move declaration from symtab.h
10146         and add comment from source.c
10147         (print_source_lines): Likewise.
10148         (forget_cached_source_info_for_objfile): Likewise.
10149         (forget_cached_source_info): Likewise.
10150         (select_source_symtab): Likewise.
10151         (enum print_source_lines_flag): Move definition from symtab.h.
10152         * symtab.h (identify_source_line): Move declaration to source.h.
10153         (print_source_lines): Likewise.
10154         (forget_cached_source_info_for_objfile): Likewise.
10155         (forget_cached_source_info): Likewise.
10156         (select_source_symtab): Likewise.
10157         (enum print_source_lines_flag): Move definition to source.h.
10158         * tui/tui-hooks.c: Add 'source.h' include.
10159
10160 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10161
10162         * source.c (print_source_lines_base): Handle requests to print
10163         reverse line number sequences, and guard against empty lines
10164         string.
10165
10166 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10167
10168         * source.c (print_source_lines_base): Fix skip of '\r' if next
10169         character is '\n'.
10170
10171 2019-01-06  Tom Tromey  <tom@tromey.com>
10172
10173         * c-exp.y (struct c_parse_state) <macro_original_text,
10174         expansion_obstack>: New member.
10175         (macro_original_text, expansion_obstack): Remove globals.
10176         (scan_macro_expansion, scanning_macro_expansion)
10177         (finished_macro_expansion): Update.
10178         (scan_macro_cleanup): Remove.
10179         (yylex, c_parse): Update.
10180
10181 2019-01-06  Tom Tromey  <tom@tromey.com>
10182
10183         * c-exp.y (struct c_parse_state) <strings>: New member.
10184         (operator_stoken): Update.
10185
10186 2019-01-06  Tom Tromey  <tom@tromey.com>
10187
10188         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10189         (union type_stack_elt) <typelist_val>: Now a pointer to
10190         std::vector.
10191         (type_stack_cleanup): Don't declare.
10192         (push_typelist): Update.
10193         * parse.c (pop_typelist): Return a std::vector.
10194         (push_typelist): Take a std::vector.
10195         (follow_types): Update.  Do not free args.
10196         (type_stack_cleanup): Remove.
10197         * c-exp.y (struct c_parse_state): New.
10198         (cpstate): New global.
10199         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10200         (nonempty_typelist): Update.
10201         (func_mod): Create a new vector.
10202         (c_parse): Create a c_parse_state.
10203         (check_parameter_typelist): Do not delete params.
10204         (function_method): Update.  Do not delete type_list.
10205
10206 2019-01-06  Tom Tromey  <tom@tromey.com>
10207
10208         PR gdb/28155:
10209         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10210         check_typedef.
10211         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10212         (print_return_value): Likewise.
10213
10214 2019-01-05  Tom Tromey  <tom@tromey.com>
10215
10216         * contrib/cleanup_check.py: Remove.
10217         * contrib/gcc-with-excheck: Remove.
10218         * contrib/exsummary.py: Remove.
10219         * contrib/excheck.py: Remove.
10220
10221 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10222
10223         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10224         NULL. Initialize tpprev to NULL instead of assigning it
10225         to NULL on the next statement.
10226         * windows-nat.c (windows_delete_thread): Remove check for
10227         main_thread_id before printing thread exit notifications.
10228         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10229         Remove thread ID check against main_thread_id.
10230         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10231         windows_delete_thread.
10232         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10233
10234 2019-01-04  Tom Tromey  <tom@tromey.com>
10235
10236         * compile/compile.c (_initialize_compile): Use upper case for
10237         metasyntactic variables.
10238         * symmisc.c (_initialize_symmisc): Use upper case for
10239         metasyntactic variables.
10240         * psymtab.c (_initialize_psymtab): Use upper case for
10241         metasyntactic variables.
10242         * demangle.c (demangle_command): Use upper case for metasyntactic
10243         variables.
10244         (_initialize_demangler): Likewise.
10245         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10246         variables.
10247
10248 2019-01-03  Tom Tromey  <tom@tromey.com>
10249
10250         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10251
10252 2019-01-03  Tom Tromey  <tom@tromey.com>
10253
10254         * python/py-symtab.c (salpy_str): Update.
10255         (struct salpy_sal_object) <symtab>: Now a PyObject.
10256         (salpy_dealloc): Update.
10257         (del_objfile_sal): Use gdbpy_ref.
10258
10259 2019-01-03  Tom Tromey  <tom@tromey.com>
10260
10261         * python/py-type.c (convert_field): Use new_reference.  Return
10262         gdbpy_ref.
10263         (make_fielditem): Return gdbpy_ref.
10264         (typy_fields): Update.
10265         (typy_getitem): Update.
10266         (field_name): Return gdbpy_ref.  Use new_reference.
10267         (typy_iterator_iternext): Update.
10268
10269 2019-01-03  Tom Tromey  <tom@tromey.com>
10270
10271         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10272
10273 2019-01-03  Tom Tromey  <tom@tromey.com>
10274
10275         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10276         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10277         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10278         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10279         (pspy_set_type_printers): Likewise.
10280         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10281         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10282         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10283         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10284         (objfpy_set_type_printers): Likewise.
10285
10286 2019-01-03  Tom Tromey  <tom@tromey.com>
10287
10288         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10289         (gdbpy_print_stack): Use gdbpy_err_fetch.
10290         * python/python-internal.h (class gdbpy_err_fetch): New class.
10291         (class gdbpy_enter) <m_error_type, m_error_value,
10292         m_error_traceback>: Remove.
10293         <m_error>: New member.
10294         (gdbpy_exception_to_string): Don't declare.
10295         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10296         * python/py-value.c (convert_value_from_python): Use
10297         gdbpy_err_fetch.
10298         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10299         gdbpy_exception_to_string.
10300         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10301         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10302         gdbpy_err_fetch.
10303
10304 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10305
10306         * linux-nat.c (delete_lwp_cleanup): Delete.
10307         (struct lwp_deleter): New struct.
10308         (lwp_info_up): New typedef.
10309         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10310         lwp_info_up.
10311
10312 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10313
10314         * linux-fork.c (class scoped_switch_fork_info): New class.
10315         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10316
10317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10318
10319         * valops.c (find_overload_match): Remove use of null_cleanup, and
10320         calls to do_cleanups.
10321
10322 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10323
10324         * compile/compile-cplus-types.c
10325         (compile_cplus_instance::decl_name): Handle changes to
10326         cp_func_name.
10327         * cp-support.c (cp_func_name): Update header comment, update
10328         return type.
10329         * cp-support.h (cp_func_name): Update return type in declaration.
10330         * valops.c (find_overload_match): Move temp_func local to top
10331         level of function and change its type.  Use temp_func to hold and
10332         delete temporary string obtained from cp_func_name.
10333
10334 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10335
10336         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10337         gdb::char_vector, remove cleanup, and update uses of `msg`.
10338
10339 2019-01-03  Jim Wilson  <jimw@sifive.com>
10340
10341         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10342
10343 2019-01-02  Tom Tromey  <tom@tromey.com>
10344
10345         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10346         (tdesc_parse_xml): Remove cleanups.
10347         * target-descriptions.h (make_cleanup_free_target_description):
10348         Don't declare.
10349         (target_desc_deleter): New struct.
10350         (target_desc_up): New typedef.
10351         * target-descriptions.c (target_desc_deleter::operator()): Rename
10352         from free_target_description.
10353         (make_cleanup_free_target_description): Remove.
10354
10355 2019-01-02  Tom Tromey  <tom@tromey.com>
10356
10357         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10358         constructor, destructor.
10359         (linespec_parser): Remove typedef.
10360         (~linespec_parser): Rename from linespec_parser_delete.
10361         (linespec_lex_to_end, linespec_complete_label)
10362         (linespec_complete): Update.
10363         (decode_line_full): Remove cleanups.
10364         (decode_line_1): Update.
10365
10366 2019-01-02  Tom Tromey  <tom@tromey.com>
10367
10368         * python/python-internal.h (inferior_to_inferior_object): Change
10369         return type.
10370         * python/py-exitedevent.c (create_exited_event_object): Update.
10371         * python/py-inferior.c (inferior_to_inferior_object): Return
10372         gdbpy_ref.
10373         (python_new_inferior, python_inferior_deleted)
10374         (thread_to_thread_object, delete_thread_object)
10375         (build_inferior_list, gdbpy_selected_inferior): Update.
10376         * python/py-infthread.c (create_thread_object): Update.  Also fail
10377         if inferior_to_inferior_object fails.
10378
10379 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10380
10381         * inferior.h (class inferior) <displaced_step_state>: New field.
10382         * infrun.h (struct displaced_step_state): Move here from
10383         infrun.c.  Initialize fields, add constructor.
10384         <inf>: Remove field.
10385         <reset>: New method.
10386         * infrun.c (struct displaced_step_inferior_state): Move to
10387         infrun.h.
10388         (displaced_step_inferior_states): Remove.
10389         (get_displaced_stepping_state): Adust.
10390         (displaced_step_in_progress_any_inferior): Adjust.
10391         (displaced_step_in_progress_thread): Adjust.
10392         (displaced_step_in_progress): Adjust.
10393         (add_displaced_stepping_state): Remove.
10394         (get_displaced_step_closure_by_addr): Adjust.
10395         (remove_displaced_stepping_state): Remove.
10396         (infrun_inferior_exit): Call displaced_step_state.reset.
10397         (use_displaced_stepping): Don't check for NULL.
10398         (displaced_step_prepare_throw): Call
10399         get_displaced_stepping_state.
10400         (displaced_step_fixup): Don't check for NULL.
10401         (prepare_for_detach): Don't check for NULL.
10402
10403 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10404
10405         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10406          in case of call that did not complete.
10407
10408 2019-01-02  Andrey Utkin  <autkin@undo.io>
10409
10410         * symfile.c (find_separate_debug_file): Fix search of debug files for
10411         remote debuggee.
10412
10413 2019-01-02  Tom Tromey  <tom@tromey.com>
10414
10415         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10416         indentation.
10417         * python/py-frame.c (frapy_older): Remove cast.
10418         (frapy_newer): Likewise.
10419         * python/py-breakpoint.c (local_setattro): Remove cast.
10420         * python/py-arch.c (archpy_name): Remove local variable.
10421         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10422
10423 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10424
10425         * unittests/basic_string_view/element_access/char/empty.cc:
10426         Fix year range in copyright header.
10427
10428 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10429
10430         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10431         Delete.
10432         <operator==>: Update with for removed field.
10433         <hash>: Likewise.
10434         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10435         <isa_features>: ...this.
10436         <abi_features>: New field.
10437         (riscv_isa_flen): Update comment.
10438         (riscv_abi_xlen): New declaration.
10439         (riscv_abi_flen): New declaration.
10440         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10441         isa_features.
10442         (riscv_abi_xlen): New function.
10443         (riscv_isa_flen): Update to get answer from isa_features.
10444         (riscv_abi_flen): New function.
10445         (riscv_has_fp_abi): Update to get answer from abi_features.
10446         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10447         xlen and flen.
10448         (riscv_call_info) <xlen, flen>: Update comment.
10449         (riscv_call_arg_struct): Remove invalid assertions
10450         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10451         is removed.
10452         (riscv_gdbarch_init): Gather isa features and abi features
10453         separately, ensure both match on the gdbarch when reusing an old
10454         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10455         a target with 64-bit float hardware.
10456
10457 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10458
10459         * source.c (search_command_helper): Stop reverse search
10460         when line 1 has been searched.
10461
10462 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10463
10464         * record-full.c (record_full_base_target::close): Rewrite
10465         record_full_core_buf_list free logic.
10466
10467 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10468
10469         * break-catch-syscall.c (print_one_catch_syscall): xfree
10470         the last text.
10471
10472 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10473
10474         * top.c (print_gdb_version): Update Copyright year in version
10475         message.
10476
10477 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10478
10479         Update copyright year range in all GDB files.
10480
10481 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10482
10483         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10484
10485 For older changes see ChangeLog-2018.
10486 \f
10487 Local Variables:
10488 mode: change-log
10489 left-margin: 8
10490 fill-column: 74
10491 version-control: never
10492 coding: utf-8
10493 End:
10494