libctf/ChangeLog

   1 2020-02-01  Nick Clifton  <nickc@redhat.com>
   2
   3         Binutils 2.34 release.
   4
   5 2020-01-18  Nick Clifton  <nickc@redhat.com>
   6
   7         Binutils 2.34 branch created.
   8
   9 2020-01-05  Joel Brobecker  <brobecker@adacore.com>
  10
  11         PR binutils/25155:
  12         * configure.ac: Add AC_CHECK_DECLS([asprintf]).
  13         * configure, config.h.in: Regenerate.
  14
  15 2020-01-01  Alan Modra  <amodra@gmail.com>
  16
  17         Update year range in copyright notice of all files.
  18
  19 2019-10-16  Simon Marchi  <simon.marchi@polymtl.ca>
  20
  21         * swap.h (bswap_16, bswap_32, bswap_64): Make static.
  22
  23 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
  24
  25         * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
  26         * ctf-types.c (ctf_type_lname): Likewise.
  27
  28 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  29
  30         * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
  31         ctf_import after the first for a given file.
  32
  33 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  34
  35         * ctf-impl.h (ctf_str_append_noerr): Declare.
  36         * ctf-util.c (ctf_str_append_noerr): Define in terms of
  37         ctf_str_append.
  38         * ctf-dump.c (str_append): New, call it.
  39         (ctf_dump_format_type): Use str_append, not ctf_str_append.
  40         (ctf_dump_label): Likewise.
  41         (ctf_dump_objts): Likewise.
  42         (ctf_dump_funcs): Likewise.
  43         (ctf_dump_var): Likewise.
  44         (ctf_dump_member): Likewise.
  45         (ctf_dump_type): Likewise.
  46         (ctf_dump): Likewise.
  47
  48 2019-09-23  Nick Alcock  <nick.alcock@oracle.com>
  49
  50         * ctf-impl.h (ctf_alloc): Remove.
  51         (ctf_free): Likewise.
  52         (ctf_strdup): Likewise.
  53         * ctf-subr.c (ctf_alloc): Remove.
  54         (ctf_free): Likewise.
  55         * ctf-util.c (ctf_strdup): Remove.
  56
  57         * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
  58         ctf_free; strdup, not ctf_strdup.
  59         (ctf_dtd_delete): Likewise.
  60         (ctf_dvd_delete): Likewise.
  61         (ctf_add_generic): Likewise.
  62         (ctf_add_function): Likewise.
  63         (ctf_add_enumerator): Likewise.
  64         (ctf_add_member_offset): Likewise.
  65         (ctf_add_variable): Likewise.
  66         (membadd): Likewise.
  67         (ctf_compress_write): Likewise.
  68         (ctf_write_mem): Likewise.
  69         * ctf-decl.c (ctf_decl_push): Likewise.
  70         (ctf_decl_fini): Likewise.
  71         (ctf_decl_sprintf): Likewise.  Check for OOM.
  72         * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
  73         ctf_free; strdup, not ctf_strdup.
  74         (ctf_dump_free): Likewise.
  75         (ctf_dump): Likewise.
  76         * ctf-open.c (upgrade_types_v1): Likewise.
  77         (init_types): Likewise.
  78         (ctf_file_close): Likewise.
  79         (ctf_bufopen_internal): Likewise.  Check for OOM.
  80         (ctf_parent_name_set): Likewise: report the OOM to the caller.
  81         (ctf_cuname_set): Likewise.
  82         (ctf_import): Likewise.
  83         * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
  84         free, not ctf_free; strdup, not ctf_strdup.
  85         (ctf_str_free_atom): Likewise.
  86         (ctf_str_create_atoms): Likewise.
  87         (ctf_str_add_ref_internal): Likewise.
  88         (ctf_str_remove_ref): Likewise.
  89         (ctf_str_write_strtab): Likewise.
  90
  91 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
  92
  93         * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
  94         work right for non-int/fps.
  95
  96 2019-08-08  Nick Alcock  <nick.alcock@oracle.com>
  97
  98         * ctf-types.c (ctf_type_name): Don't strlen a potentially-
  99         null pointer.
 100
 101 2019-08-07  Nick Alcock  <nick.alcock@oracle.com>
 102
 103         * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
 104         * ctf-open.c (ctf_file_close): Free it.
 105         * ctf-create.c (ctf_serialize): Adjust.
 106         (membcmp): When reporting a conflict due to an error, report the
 107         error.
 108         (ctf_add_type): Turn into a ctf_add_processing wrapper.  Rename to...
 109         (ctf_add_type_internal): ... this.  Hand back types we are already
 110         in the middle of adding immediately.  Hand back structs/unions with
 111         the same number of members immediately.  Do not walk the dynamic
 112         list.  Call ctf_add_type_internal, not ctf_add_type.  Handle
 113         forwards promoted to other types and the inverse case identically.
 114         Add structs to the mapping as soon as we intern them, before they
 115         gain any members.
 116
 117 2019-08-09  Nick Alcock  <nick.alcock@oracle.com>
 118
 119         * ctf-impl.h (ctf_names_t): New.
 120         (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
 121         (ctf_file_t) <ctf_structs>: Likewise.
 122         <ctf_unions>: Likewise.
 123         <ctf_enums>: Likewise.
 124         <ctf_names>: Likewise.
 125         <ctf_lookups>: Improve comment.
 126         <ctf_ptrtab_len>: New.
 127         <ctf_prov_strtab>: New.
 128         <ctf_str_prov_offset>: New.
 129         <ctf_dtbyname>: Remove, redundant to the names hashes.
 130         <ctf_dtnextid>: Remove, redundant to ctf_typemax.
 131         (ctf_dtdef_t) <dtd_name>: Remove.
 132         <dtd_data>: Note that the ctt_name is now populated.
 133         (ctf_str_atom_t) <csa_offset>: This is now the strtab
 134         offset for internal strings too.
 135         <csa_external_offset>: New, the external strtab offset.
 136         (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
 137         (ctf_name_table): New declaration.
 138         (ctf_lookup_by_rawname): Likewise.
 139         (ctf_lookup_by_rawhash): Likewise.
 140         (ctf_set_ctl_hashes): Likewise.
 141         (ctf_serialize): Likewise.
 142         (ctf_dtd_insert): Adjust.
 143         (ctf_simple_open_internal): Likewise.
 144         (ctf_bufopen_internal): Likewise.
 145         (ctf_list_empty_p): Likewise.
 146         (ctf_str_remove_ref): Likewise.
 147         (ctf_str_add): Returns uint32_t now.
 148         (ctf_str_add_ref): Likewise.
 149         (ctf_str_add_external): Now returns a boolean (int).
 150         * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
 151         for strings in the appropriate range.
 152         (ctf_str_create_atoms): Create the ctf_prov_strtab.  Detect OOM
 153         when adding the null string to the new strtab.
 154         (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
 155         (ctf_str_add_ref_internal): Add make_provisional argument.  If
 156         make_provisional, populate the offset and fill in the
 157         ctf_prov_strtab accordingly.
 158         (ctf_str_add): Return the offset, not the string.
 159         (ctf_str_add_ref): Likewise.
 160         (ctf_str_add_external): Return a success integer.
 161         (ctf_str_remove_ref): New, remove a single ref.
 162         (ctf_str_count_strtab): Do not count the initial null string's
 163         length or the existence or length of any unreferenced internal
 164         atoms.
 165         (ctf_str_populate_sorttab): Skip atoms with no refs.
 166         (ctf_str_write_strtab): Populate the nullstr earlier.  Add one
 167         to the cts_len for the null string, since it is no longer done
 168         in ctf_str_count_strtab.  Adjust for csa_external_offset rename.
 169         Populate the csa_offset for both internal and external cases.
 170         Flush the ctf_prov_strtab afterwards, and reset the
 171         ctf_str_prov_offset.
 172         * ctf-create.c (ctf_grow_ptrtab): New.
 173         (ctf_create): Call it.  Initialize new fields rather than old
 174         ones.  Tell ctf_bufopen_internal that this is a writable dictionary.
 175         Set the ctl hashes and data model.
 176         (ctf_update): Rename to...
 177         (ctf_serialize): ... this.  Leave a compatibility function behind.
 178         Tell ctf_simple_open_internal that this is a writable dictionary.
 179         Pass the new fields along from the old dictionary.  Drop
 180         ctf_dtnextid and ctf_dtbyname.  Use ctf_strraw, not dtd_name.
 181         Do not zero out the DTD's ctt_name.
 182         (ctf_prefixed_name): Rename to...
 183         (ctf_name_table): ... this.  No longer return a prefixed name: return
 184         the applicable name table instead.
 185         (ctf_dtd_insert): Use it, and use the right name table.  Pass in the
 186         kind we're adding.  Migrate away from dtd_name.
 187         (ctf_dtd_delete): Adjust similarly.  Remove the ref to the
 188         deleted ctt_name.
 189         (ctf_dtd_lookup_type_by_name): Remove.
 190         (ctf_dynamic_type): Always return NULL on read-only dictionaries.
 191         No longer check ctf_dtnextid: check ctf_typemax instead.
 192         (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
 193         (ctf_rollback): Likewise.  No longer fail with ECTF_OVERROLLBACK. Use
 194         ctf_name_table and the right name table, and migrate away from
 195         dtd_name as in ctf_dtd_delete.
 196         (ctf_add_generic): Pass in the kind explicitly and pass it to
 197         ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid.  Migrate away
 198         from dtd_name to using ctf_str_add_ref to populate the ctt_name.
 199         Grow the ptrtab if needed.
 200         (ctf_add_encoded): Pass in the kind.
 201         (ctf_add_slice): Likewise.
 202         (ctf_add_array): Likewise.
 203         (ctf_add_function): Likewise.
 204         (ctf_add_typedef): Likewise.
 205         (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
 206         ctt_name rather than dtd_name.
 207         (ctf_add_struct_sized): Pass in the kind.  Use
 208         ctf_lookup_by_rawname, not ctf_hash_lookup_type /
 209         ctf_dtd_lookup_type_by_name.
 210         (ctf_add_union_sized): Likewise.
 211         (ctf_add_enum): Likewise.
 212         (ctf_add_enum_encoded): Likewise.
 213         (ctf_add_forward): Likewise.
 214         (ctf_add_type): Likewise.
 215         (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
 216         being initialized until after the call.
 217         (ctf_write_mem): Likewise.
 218         (ctf_write): Likewise.
 219         * ctf-archive.c (arc_write_one_ctf): Likewise.
 220         * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
 221         ctf_hash_lookup_type.
 222         (ctf_lookup_by_id): No longer check the readonly types if the
 223         dictionary is writable.
 224         * ctf-open.c (init_types): Assert that this dictionary is not
 225         writable.  Adjust to use the new name hashes, ctf_name_table,
 226         and ctf_ptrtab_len.  GNU style fix for the final ptrtab scan.
 227         (ctf_bufopen_internal): New 'writable' parameter.  Flip on LCTF_RDWR
 228         if set.  Drop out early when dictionary is writable.  Split the
 229         ctf_lookups initialization into...
 230         (ctf_set_cth_hashes): ... this new function.
 231         (ctf_simple_open_internal): Adjust.  New 'writable' parameter.
 232         (ctf_simple_open): Adjust accordingly.
 233         (ctf_bufopen): Likewise.
 234         (ctf_file_close): Destroy the appropriate name hashes.  No longer
 235         destroy ctf_dtbyname, which is gone.
 236         (ctf_getdatasect): Remove spurious "extern".
 237         * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
 238         specified name table, given a kind.
 239         (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
 240         (ctf_member_iter): Add support for iterating over the
 241         dynamic type list.
 242         (ctf_enum_iter): Likewise.
 243         (ctf_variable_iter): Likewise.
 244         (ctf_type_rvisit): Likewise.
 245         (ctf_member_info): Add support for types in the dynamic type list.
 246         (ctf_enum_name): Likewise.
 247         (ctf_enum_value): Likewise.
 248         (ctf_func_type_info): Likewise.
 249         (ctf_func_type_args): Likewise.
 250         * ctf-link.c (ctf_accumulate_archive_names): No longer call
 251         ctf_update.
 252         (ctf_link_write): Likewise.
 253         (ctf_link_intern_extern_string): Adjust for new
 254         ctf_str_add_external return value.
 255         (ctf_link_add_strtab): Likewise.
 256         * ctf-util.c (ctf_list_empty_p): New.
 257
 258 2019-08-05  Nick Alcock  <nick.alcock@oracle.com>
 259
 260         * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
 261         type zero.
 262         * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
 263         members and types.
 264         (ctf_add_variable): Likewise for variables pointing to them.
 265         * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
 266         type link failure, but do warn for others.
 267         * ctf-dump.c (ctf_dump_format_type): Likewise.  Do not assume all
 268         errors to be ENOMEM.
 269         (ctf_dump_member): Likewise.
 270         (ctf_dump_type): Likewise.
 271         (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
 272         (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
 273         (ctf_dump_header): Likewise.
 274         (ctf_dump_label): likewise.
 275         (ctf_dump_objts): likewise.
 276         (ctf_dump_funcs): likewise.
 277         (ctf_dump_var): likewise.
 278         (ctf_dump_str): Likewise.
 279
 280 2019-09-30  Nick Alcock  <nick.alcock@oracle.com>
 281
 282         * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
 283         (LT_INIT): Likewise.
 284         (AM_INSTALL_LIBBFD): Likewise.
 285         (dlopen): Note why this is necessary in a comment.
 286         (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
 287         opcodes/.
 288         (SHARED_LDFLAGS): Likewise.
 289         (BFD_LIBADD): Likewise, for libbfd.
 290         (BFD_DEPENDENCIES): Likewise.
 291         (VERSION_FLAGS): Initialize, using a version script if ld supports
 292         one, or libtool -export-symbols-regex otherwise.
 293         (AC_CONFIG_MACRO_DIR): Add ../BFD.
 294         * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
 295         (INCDIR): New.
 296         (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
 297         (noinst_LIBRARIES): Replace with...
 298         [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
 299         [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
 300         libctf-nobfd.la as well.
 301         [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
 302         [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
 303         (libctf_a_SOURCES): Rename to...
 304         (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
 305         ctf-open-bfd.c.
 306         (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
 307         with ctf-open-bfd.c added.
 308         (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
 309         (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
 310         (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
 311         * Makefile.am [INSTALL_LIBCTF]: Use it.
 312         * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
 313         libtool macros.
 314         * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
 315         the unstable components).
 316         * Makefile.in: Regenerated.
 317         * config.h.in: Likewise.
 318         * configure: Likewise.
 319
 320 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 321
 322         * configure.ac (INSTALL_LIBCTF): New, controlled by
 323         --enable-install-libctf.
 324         [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
 325         * Makefile.in: Regenerated.
 326         * configure: Regenerated.
 327
 328 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 329
 330         * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
 331         * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
 332
 333 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 334
 335         * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
 336
 337 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 338
 339         * ctf-impl.h (includes): Include <sys/param.h> here.
 340
 341 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 342
 343         * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
 344         (flip_objts): Likewise.
 345         (flip_vars): Likewise.
 346         (flip_types): Likewise.
 347
 348 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 349
 350         * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
 351         freeing functions: if set, free the key and value if the slot
 352         already exists.  Always reassign the key.
 353         (ctf_dynhash_insert): Adjust call appropriately.
 354         (ctf_hash_insert_type): Likewise.
 355
 356 2019-08-03  Nick Alcock  <nick.alcock@oracle.com>
 357
 358         * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
 359         type kind.  Allow forwards to unify with pre-existing structs/
 360         unions/enums.
 361
 362 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 363
 364         * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
 365         <ctf_link_memb_name_changer>: Likewise.
 366         <ctf_link_memb_name_changer_arg>: Likewise.
 367         * ctf-create.c (ctf_update): Update accordingly.
 368         * ctf-open.c (ctf_file_close): Likewise.
 369         * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
 370         (ctf_link_add_cu_mapping): New.
 371         (ctf_link_set_memb_name_changer): Likewise.
 372         (ctf_change_parent_name): New.
 373         (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
 374         allocated by the caller's ctf_link_memb_name_changer.
 375         <ndynames>: Likewise.
 376         (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
 377         (ctf_link_write): Likewise (for _CTF_SECTION only): also call
 378         ctf_change_parent_name.  Free any resulting names.
 379
 380 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 381
 382         * ctf-link.c (ctf_create_per_cu): New, refactored out of...
 383         (ctf_link_one_type): ... here, with parent-name setting added.
 384         (check_variable): New.
 385         (ctf_link_one_variable): Likewise.
 386         (ctf_link_one_input_archive_member): Call it.
 387         * ctf-error.c (_ctf_errlist): Updated with new errors.
 388
 389 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 390
 391         * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
 392         (struct ctf_link_type_mapping_key): New.
 393         (ctf_hash_type_mapping_key): Likewise.
 394         (ctf_hash_eq_type_mapping_key): Likewise.
 395         (ctf_add_type_mapping): Likewise.
 396         (ctf_type_mapping): Likewise.
 397         (ctf_dynhash_empty): Likewise.
 398         * ctf-open.c (ctf_file_close): Update accordingly.
 399         * ctf-create.c (ctf_update): Likewise.
 400         (ctf_add_type): Populate the mapping.
 401         * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
 402         (ctf_hash_eq_type_mapping_key): Check the key for equality.
 403         (ctf_dynhash_insert): Fix comment typo.
 404         (ctf_dynhash_empty): New.
 405         * ctf-link.c (ctf_add_type_mapping): New.
 406         (ctf_type_mapping): Likewise.
 407         (empty_link_type_mapping): New.
 408         (ctf_link_one_input_archive): Call it.
 409
 410 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 411
 412         * ctf-link.c: New file, linking of the string and type sections.
 413         * Makefile.am (libctf_a_SOURCES): Add it.
 414         * Makefile.in: Regenerate.
 415
 416         * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
 417         ctf_link_outputs.
 418         * ctf-create.c (ctf_update): Update accordingly.
 419         * ctf-open.c (ctf_file_close): Likewise.
 420         * ctf-error.c (_ctf_errlist): Updated with new errors.
 421
 422 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 423
 424         * ctf-dump.c (ctf_dump_funcs): Check the right error value.
 425
 426 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 427
 428         * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
 429         ctf_type_iter.
 430         (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
 431         (ctf_dump_format_type): Add non-root-type { } notation.
 432         Add root flag to prototype.
 433         (ctf_dump_label): Adjust accordingly.
 434         (ctf_dump_objts): Likewise.
 435         (ctf_dump_var): Likewise.
 436
 437 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 438
 439         * ctf-create.c (ctf_compress_write): Fix double-free.
 440
 441 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 442
 443         * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
 444         of...
 445         (ctf_arc_write_fd): ... this new function.
 446         * ctf-create.c (ctf_write_mem): New.
 447
 448 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 449
 450         * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
 451         (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
 452         (ctf_str_add_ref): Name the last arg.
 453         (ctf_str_add_external) New.
 454         (ctf_str_add_strraw_explicit): Likewise.
 455         (ctf_simple_open_internal): Likewise.
 456         (ctf_bufopen_internal): Likewise.
 457
 458         * ctf-string.c (ctf_strraw_explicit): Split from...
 459         (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
 460         (ctf_str_add_ref_internal): Return the atom, not the
 461         string.
 462         (ctf_str_add): Adjust accordingly.
 463         (ctf_str_add_ref): Likewise.  Move up in the file.
 464         (ctf_str_add_external): New: update the csa_offset.
 465         (ctf_str_count_strtab): Only account for strings with no csa_offset
 466         in the internal strtab length.
 467         (ctf_str_write_strtab): If the csa_offset is set, update the
 468         string's refs without writing the string out, and update the
 469         ctf_syn_ext_strtab.  Make OOM handling less ugly.
 470         * ctf-create.c (struct ctf_sort_var_arg_cb): New.
 471         (ctf_update): Handle failure to populate the strtab.  Pass in the
 472         new ctf_sort_var arg.  Adjust for ctf_syn_ext_strtab addition.
 473         Call ctf_simple_open_internal, not ctf_simple_open.
 474         (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
 475         strings by hand.
 476         * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
 477         ctf_strraw).  Adjust to diagnose ECTF_STRTAB nonetheless.
 478         * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
 479         (ctf_file_close): Destroy the ctf_syn_ext_strtab.
 480         (ctf_simple_open): Rename to, and reimplement as a wrapper around...
 481         (ctf_simple_open_internal): ... this new function, which calls
 482         ctf_bufopen_internal.
 483         (ctf_bufopen): Rename to, and reimplement as a wrapper around...
 484         (ctf_bufopen_internal): ... this new function, which sets
 485         ctf_syn_ext_strtab.
 486
 487 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 488
 489         * ctf_types.c (ctf_type_iter_all): New.
 490
 491 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 492
 493         * ctf-open.c (init_symtab): Check for overflow against the right
 494         section.
 495         (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
 496         (upgrade_types_v1): Note that these sections are not checked.
 497         (flip_header): Endian-swap the header fields.
 498         (flip_ctf): Endian-swap the sections.
 499         (flip_objts): Update comment.
 500         (ctf_bufopen): Check header offsets and alignment for validity.
 501
 502 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 503
 504         * ctf-open-bfd.c: Add <assert.h>.
 505         (ctf_bfdopen_ctfsect): Open string and symbol tables using
 506         techniques borrowed from bfd_elf_sym_name.
 507         (ctf_new_archive_internal): Improve comment.
 508         * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
 509         * ctf-open.c (ctf_bufopen): Allow opening with a string section but
 510         no symbol section, but not vice versa.
 511
 512 2019-07-08  Nick Alcock  <nick.alcock@oracle.com>
 513
 514         * ctf-impl.h (ctf_file_t): New field ctf_openflags.
 515         * ctf-open.c (ctf_bufopen): Set it.  No longer dump header offsets.
 516         * ctf-dump.c (dump_header): New function, dump the CTF header.
 517         (ctf_dump): Call it.
 518         (ctf_dump_header_strfield): New function.
 519         (ctf_dump_header_sectfield): Likewise.
 520
 521 2019-07-06  Nick Alcock  <nick.alcock@oracle.com>
 522
 523         * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
 524         ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
 525         * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
 526         ctf_base: do not assume that it is always sizeof (ctf_header_t).
 527         Print out ctf_cuname: only print out ctf_parname if set.
 528         (ctf_free_base): Removed, ctf_base is no longer freed: free
 529         ctf_dynbase instead.
 530         (ctf_set_version): Fix spacing.
 531         (upgrade_header): New, in-place header upgrading.
 532         (upgrade_types): Rename to...
 533         (upgrade_types_v1): ... this.  Free ctf_dynbase, not ctf_base.  No
 534         longer track old and new headers separately.  No longer allow for
 535         header sizes explicitly: squeeze the headers out on upgrade (they
 536         are preserved in fp->ctf_header).  Set ctf_dynbase, ctf_base and
 537         ctf_buf explicitly.  Use ctf_free, not ctf_free_base.
 538         (upgrade_types): New, also handle ctf_parmax updating.
 539         (flip_header): Flip ctf_cuname.
 540         (flip_types): Flip BUF explicitly rather than deriving BUF from
 541         BASE.
 542         (ctf_bufopen): Store the header in fp->ctf_header.  Correct minimum
 543         required alignment of objtoff and funcoff.  No longer store it in
 544         the ctf_buf unless that buf is derived unmodified from the input.
 545         Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
 546         that duplicate fields in ctf_file: move allocation of ctf_file
 547         further up instead.  Call upgrade_header as needed.  Move
 548         version-specific ctf_parmax initialization into upgrade_types.  More
 549         concise error handling.
 550         (ctf_file_close): No longer test for null pointers before freeing.
 551         Free ctf_dyncuname, ctf_dynbase, and ctf_header.  Do not call
 552         ctf_free_base.
 553         (ctf_cuname): New.
 554         (ctf_cuname_set): New.
 555         * ctf-create.c (ctf_update): Populate ctf_cuname.
 556         (ctf_gzwrite): Write out the header explicitly.  Remove obsolescent
 557         comment.
 558         (ctf_write): Likewise.
 559         (ctf_compress_write): Get the header from ctf_header, not ctf_base.
 560         Fix the compression length: fp->ctf_size never counted the CTF
 561         header.  Simplify the compress call accordingly.
 562
 563 2019-07-11  Hans-Peter Nilsson  <hp@bitrange.com>
 564
 565         * ctf-endian.h: Don't assume htole64 and le64toh are always
 566         present if HAVE_ENDIAN_H; also check if htole64 is defined.
 567         [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
 568         not bswap_identity_64.
 569
 570 2019-09-18  Alan Modra  <amodra@gmail.com>
 571
 572         * ctf-open-bfd.c: Update throughout for bfd section macro changes.
 573
 574 2019-09-09  Phil Blundell  <pb@pbcl.net>
 575
 576         binutils 2.33 branch created.
 577
 578 2019-07-18  Nick Alcock  <nick.alcock@oracle.com>
 579
 580         * ctf-types.c (ctf_type_aname_raw): New.
 581         (ctf_func_type_info): Likewise.
 582         (ctf_func_type_args): Likewise.
 583         * ctf-error.c (_ctf_errlist): Fix description.
 584         * ctf-lookup.c: Fix file description.
 585
 586 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 587
 588         * ctf-create.c (ctf_create): Fix off-by-one error.
 589
 590 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 591
 592         * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
 593         struct ctf_strs.
 594         (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
 595         (struct ctf_str_atom): New, disambiguated single string.
 596         (struct ctf_str_atom_ref): New, points to some other location that
 597         references this string's offset.
 598         (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
 599         Remove member ctf_dtvstrlen: we no longer track the total strlen
 600         as we add strings.
 601         (ctf_str_create_atoms): Declare new function in ctf-string.c.
 602         (ctf_str_free_atoms): Likewise.
 603         (ctf_str_add): Likewise.
 604         (ctf_str_add_ref): Likewise.
 605         (ctf_str_rollback): Likewise.
 606         (ctf_str_purge_refs): Likewise.
 607         (ctf_str_write_strtab): Likewise.
 608         (ctf_realloc): Declare new function in ctf-util.c.
 609
 610         * ctf-open.c (ctf_bufopen): Create the atoms table.
 611         (ctf_file_close): Destroy it.
 612         * ctf-create.c (ctf_update): Copy-and-free it on update.  No longer
 613         special-case the position of the parname string.  Construct the
 614         strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
 615         rest of each buffer element is constructed, not via open-coding:
 616         realloc the CTF buffer and append the strtab to it.  No longer
 617         maintain ctf_dtvstrlen.  Sort the variable entry table later, after
 618         strtab construction.
 619         (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
 620         (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
 621         after buffer element construction instead.
 622         (ctf_copy_lmembers): Likewise.
 623         (ctf_copy_emembers): Likewise.
 624         (ctf_create): No longer maintain the ctf_dtvstrlen.
 625         (ctf_dtd_delete): Likewise.
 626         (ctf_dvd_delete): Likewise.
 627         (ctf_add_generic): Likewise.
 628         (ctf_add_enumerator): Likewise.
 629         (ctf_add_member_offset): Likewise.
 630         (ctf_add_variable): Likewise.
 631         (membadd): Likewise.
 632         * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
 633         if there are active ctf_str_num_refs.
 634         (ctf_strraw): Move to ctf-string.c.
 635         (ctf_strptr): Likewise.
 636         * ctf-string.c: New file, strtab manipulation.
 637
 638         * Makefile.am (libctf_a_SOURCES): Add it.
 639         * Makefile.in: Regenerate.
 640
 641 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 642
 643         * ctf-impl.h (ctf_hash_iter_f): New.
 644         (ctf_dynhash_iter): New declaration.
 645         (ctf_dynhash_iter_remove): New declaration.
 646         * ctf-hash.c (ctf_dynhash_iter): Define.
 647         (ctf_dynhash_iter_remove): Likewise.
 648         (ctf_hashtab_traverse): New.
 649         (ctf_hashtab_traverse_remove): Likewise.
 650         (struct ctf_traverse_cb_arg): Likewise.
 651         (struct ctf_traverse_remove_cb_arg): Likewise.
 652
 653 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 654
 655         * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
 656
 657 2019-06-28  Nick Alcock  <nick.alcock@oracle.com>
 658
 659         * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
 660         (ctf_dump_funcs): Likewise.
 661
 662 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 663
 664         * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
 665         (ctf_fdopen): Check for endian-swapped raw CTF magic, and
 666         little-endian CTF archive magic.  Do not check the CTF version:
 667         ctf_simple_open does that in endian-safe ways.  Do not dereference
 668         null pointers on open failure.
 669
 670 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 671
 672         * ctf-open.c (get_vbytes_common): Return the new slice size.
 673         (ctf_bufopen): Flip the endianness of the CTF-section header copy.
 674         Remember to copy in the CTF data when opening an uncompressed
 675         foreign-endian CTF file.  Prune useless variable manipulation.
 676
 677 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 678
 679         * ctf-open.c (ctf_types): Fail when unidentified type kinds are
 680         seen.
 681
 682 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 683
 684         * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
 685         output.
 686
 687 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 688
 689         * ctf-subr.c (_PAGESIZE): Remove.
 690         (ctf_data_alloc): Likewise.
 691         (ctf_data_free): Likewise.
 692         (ctf_data_protect): Likewise.
 693         * ctf-impl.h: Remove declarations.
 694         * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
 695         ctf_free, not ctf_data_free.
 696         (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc.  Free
 697         the buffer again on compression error.
 698         * ctf-open.c (ctf_set_base): No longer track the size: call
 699         ctf_free, not ctf_data_free.
 700         (upgrade_types): Likewise.  Call ctf_alloc, not ctf_data_alloc.
 701         (ctf_bufopen): Likewise.  No longer call ctf_data_protect.
 702
 703 2019-06-19  Nick Alcock  <nick.alcock@oracle.com>
 704
 705         * ctf-create.c (ctf_dtd_insert): Pass on error returns from
 706         ctf_dynhash_insert.
 707         (ctf_dvd_insert): Likewise.
 708         (ctf_add_generic): Likewise.
 709         (ctf_add_variable): Likewise.
 710         * ctf-impl.h: Adjust declarations.
 711
 712 2019-06-14  Alan Modra  <amodra@gmail.com>
 713
 714         * configure: Regenerate.
 715
 716 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 717
 718         * ctf-decls.h: Include <libiberty.h>.
 719         * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
 720
 721 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 722
 723         * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
 724         (ctf_dump_objts): Likewise.
 725         (ctf_dump_funcs): Likewise.
 726         (ctf_dump_member): Likewise.
 727         (ctf_dump_str): Likewise.
 728
 729 2019-06-06  Nick Alcock  <nick.alcock@oracle.com>
 730
 731         * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
 732         * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
 733
 734 2019-06-05  Nick Alcock  <nick.alcock@oracle.com>
 735
 736         * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
 737         (ctf_arc_open_by_offset): Likewise.
 738         * ctf-create.c (ctf_add_type): Likewise.
 739
 740 2019-06-04  Tom Tromey  <tromey@adacore.com>
 741
 742         * ctf-create.c (ctf_add_encoded, ctf_add_slice)
 743         (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
 744
 745 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 746
 747         * configure.ac: Check for O_CLOEXEC.
 748         * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
 749         * config.h.in: Regenerate.
 750         * configure: Likewise.
 751
 752 2019-06-04  Nick Alcock  <nick.alcock@oracle.com>
 753
 754         * qsort_r.c: Rename to...
 755         * ctf-qsort_r.c: ... this.
 756         (_quicksort): Define to ctf_qsort_r.
 757         * ctf-decls.h (qsort_r): Remove.
 758         (ctf_qsort_r): Add.
 759         (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
 760         (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
 761         * Makefile.am (libctf_a_LIBADD): Remove.
 762         (libctf_a_SOURCES): New, add ctf-qsort_r.c.
 763         * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
 764         * ctf-create.c (ctf_update): Likewise.
 765         * configure.ac: Check for BSD versus GNU qsort_r signature.
 766         * Makefile.in: Regenerate.
 767         * config.h.in: Likewise.
 768         * configure: Likewise.
 769
 770 2019-06-03  Nick Alcock  <nick.alcock@oracle.com>
 771
 772         * ctf-dump.c (ctf_dump_funcs): Free in the right place.
 773
 774 2019-05-29  Nick Alcock  <nick.alcock@oracle.com>
 775
 776         * Makefile.am (ZLIB): New.
 777         (ZLIBINC): Likewise.
 778         (AM_CFLAGS): Use them.
 779         (libctf_a_LIBADD): New, for LIBOBJS.
 780         * configure.ac: Check for zlib, endian.h, and qsort_r.
 781         * ctf-endian.h: New, providing htole64 and le64toh.
 782         * swap.h: Code style fixes.
 783         (bswap_identity_64): New.
 784         * qsort_r.c: New, from gnulib (with one added #include).
 785         * ctf-decls.h: New, providing a conditional qsort_r declaration,
 786         and unconditional definitions of MIN and MAX.
 787         * ctf-impl.h: Use it.  Do not use <sys/errno.h>.
 788         (ctf_set_errno): Now returns unsigned long.
 789         * ctf-util.c (ctf_set_errno): Adjust here too.
 790         * ctf-archive.c: Use ctf-endian.h.
 791         (ctf_arc_open_by_offset): Use memset, not bzero.  Drop cts_type,
 792         cts_flags and cts_offset.
 793         (ctf_arc_write): Drop debugging dependent on the size of off_t.
 794         * ctf-create.c: Provide a definition of roundup if not defined.
 795         (ctf_create): Drop cts_type, cts_flags and cts_offset.
 796         (ctf_add_reftype): Do not check if type IDs are below zero.
 797         (ctf_add_slice): Likewise.
 798         (ctf_add_typedef): Likewise.
 799         (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
 800         when known error-free.  Drop CTF_ERR usage for functions returning
 801         int.
 802         (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
 803         int.
 804         (ctf_add_variable): Likewise.
 805         (enumcmp): Likewise.
 806         (enumadd): Likewise.
 807         (membcmp): Likewise.
 808         (ctf_add_type): Likewise.  Cast error-returning ssize_t's to size_t
 809         when known error-free.
 810         * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
 811         returning int: use CTF_ERR for functions returning ctf_type_id.
 812         (ctf_dump_label): Likewise.
 813         (ctf_dump_objts): Likewise.
 814         * ctf-labels.c (ctf_label_topmost): Likewise.
 815         (ctf_label_iter): Likewise.
 816         (ctf_label_info): Likewise.
 817         * ctf-lookup.c (ctf_func_args): Likewise.
 818         * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
 819         (ctf_bufopen): Likewise.  Use zlib types as needed.
 820         * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
 821         returning int.
 822         (ctf_enum_iter): Likewise.
 823         (ctf_type_size): Likewise.
 824         (ctf_type_align): Likewise.  Cast to size_t where appropriate.
 825         (ctf_type_kind_unsliced): Likewise.
 826         (ctf_type_kind): Likewise.
 827         (ctf_type_encoding): Likewise.
 828         (ctf_member_info): Likewise.
 829         (ctf_array_info): Likewise.
 830         (ctf_enum_value): Likewise.
 831         (ctf_type_rvisit): Likewise.
 832         * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
 833         cts_offset.
 834         (ctf_simple_open): Likewise.
 835         (ctf_bfdopen_ctfsect): Likewise.  Set cts_size properly.
 836         * Makefile.in: Regenerate.
 837         * aclocal.m4: Likewise.
 838         * config.h: Likewise.
 839         * configure: Likewise.
 840
 841 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 842
 843         * configure.in: Check for bfd_section_from_elf_index.
 844         * configure: Regenerate.
 845         * config.h.in [HAVE_BFD_ELF]: Likewise.
 846         * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
 847         abfd is potentially unused now.
 848
 849 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 850
 851         * Makefile.am: New.
 852         * Makefile.in: Regenerated.
 853         * config.h.in: Likewise.
 854         * aclocal.m4: Likewise.
 855         * configure: Likewise.
 856
 857 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 858
 859         * ctf-dump.c: New.
 860
 861 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 862
 863         * ctf-labels.c: New.
 864
 865 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 866
 867         * ctf-impl.h (_libctf_version): New declaration.
 868         * ctf-subr.c (_libctf_version): Define it.
 869         (ctf_version): New.
 870
 871 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 872
 873         * ctf-create.c (enumcmp): New.
 874         (enumadd): Likewise.
 875         (membcmp): Likewise.
 876         (membadd): Likewise.
 877         (ctf_add_type): Likewise.
 878
 879 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 880
 881         * ctf-lookup.c (isqualifier): New.
 882         (ctf_lookup_by_name): Likewise.
 883         (struct ctf_lookup_var_key): Likewise.
 884         (ctf_lookup_var): Likewise.
 885         (ctf_lookup_variable): Likewise.
 886         (ctf_lookup_symbol_name): Likewise.
 887         (ctf_lookup_by_symbol): Likewise.
 888         (ctf_func_info): Likewise.
 889         (ctf_func_args): Likewise.
 890
 891 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 892
 893         * ctf-decl.c: New file.
 894         * ctf-types.c: Likewise.
 895         * ctf-impl.h: New declarations.
 896
 897 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 898
 899         * ctf-open-bfd.c: New file.
 900         * ctf-open.c (ctf_close): New.
 901         * ctf-impl.h: Include bfd.h.
 902         (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
 903         (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
 904         ctfi_bfd_close.
 905         (ctf_bfdopen_ctfsect): New declaration.
 906         (_CTF_SECTION): likewise.
 907
 908 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 909
 910         * ctf-archive.c: New.
 911         * ctf-impl.h (ctf_archive_internal): New type.
 912         (ctf_arc_open_internal): New declaration.
 913         (ctf_arc_bufopen): Likewise.
 914         (ctf_arc_close_internal): Likewise.
 915
 916 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 917
 918         * ctf-open.c: New file.
 919         * swap.h: Likewise.
 920
 921 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 922
 923         * ctf-create.c: New file.
 924         * ctf-lookup.c: New file.
 925
 926 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 927
 928         * ctf-impl.h: New definitions and declarations for type creation
 929         and lookup.
 930
 931 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 932
 933         * ctf-hash.c: New file.
 934         * ctf-impl.h: New declarations.
 935
 936 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 937
 938         * ctf-error.c: New file.
 939
 940 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 941
 942         * ctf-util.c: New file.
 943         * elf.h: Likewise.
 944         * ctf-impl.h: Include it, and add declarations.
 945
 946 2019-05-28  Nick Alcock  <nick.alcock@oracle.com>
 947
 948         * ctf-impl.h: New file.
 949         * ctf-subr.c: New file.
 950
 951 \f
 952 Local Variables:
 953 mode: change-log
 954 left-margin: 8
 955 fill-column: 76
 956 version-control: never
 957 End: