]> git.ipfire.org Git - thirdparty/mdadm.git/blame - Create.c
imsm: change wrong size verification
[thirdparty/mdadm.git] / Create.c
CommitLineData
64c4757e 1/*
9a9dab36 2 * mdadm - manage Linux "md" devices aka RAID arrays.
64c4757e 3 *
6f02172d 4 * Copyright (C) 2001-2013 Neil Brown <neilb@suse.de>
64c4757e
NB
5 *
6 *
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation; either version 2 of the License, or
10 * (at your option) any later version.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
16 *
17 * You should have received a copy of the GNU General Public License
18 * along with this program; if not, write to the Free Software
19 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
20 *
21 * Author: Neil Brown
e736b623 22 * Email: <neilb@suse.de>
64c4757e
NB
23 */
24
ca3b6696 25#include "mdadm.h"
682c7051
NB
26#include "md_u.h"
27#include "md_p.h"
60248f74 28#include <ctype.h>
64c4757e 29
22dc741f
MT
30static int round_size_and_verify(unsigned long long *size, int chunk)
31{
32 if (*size == 0)
33 return 0;
34 *size &= ~(unsigned long long)(chunk - 1);
35 if (*size == 0) {
36 pr_err("Size cannot be smaller than chunk.\n");
37 return 1;
38 }
39 return 0;
40}
41
a18a888e
DW
42static int default_layout(struct supertype *st, int level, int verbose)
43{
44 int layout = UnSet;
45
30f58b22
DW
46 if (st && st->ss->default_geometry)
47 st->ss->default_geometry(st, &level, &layout, NULL);
a18a888e
DW
48
49 if (layout == UnSet)
50 switch(level) {
51 default: /* no layout */
52 layout = 0;
53 break;
329dfc28
N
54 case 0:
55 layout = RAID0_ORIG_LAYOUT;
56 break;
a18a888e
DW
57 case 10:
58 layout = 0x102; /* near=2, far=1 */
59 if (verbose > 0)
e7b84f9d 60 pr_err("layout defaults to n2\n");
a18a888e
DW
61 break;
62 case 5:
63 case 6:
64 layout = map_name(r5layout, "default");
65 if (verbose > 0)
e7b84f9d 66 pr_err("layout defaults to %s\n", map_num(r5layout, layout));
a18a888e
DW
67 break;
68 case LEVEL_FAULTY:
69 layout = map_name(faultylayout, "default");
70
71 if (verbose > 0)
e7b84f9d 72 pr_err("layout defaults to %s\n", map_num(faultylayout, layout));
a18a888e
DW
73 break;
74 }
75
76 return layout;
77}
78
7f91af49 79int Create(struct supertype *st, char *mddev,
171dccc8 80 char *name, int *uuid,
a655e550 81 int subdevs, struct mddev_dev *devlist,
99cc42f4 82 struct shape *s,
40c9a66a 83 struct context *c, unsigned long long data_offset)
64c4757e 84{
682c7051
NB
85 /*
86 * Create a new raid array.
87 *
88 * First check that necessary details are available
89 * (i.e. level, raid-disks)
90 *
91 * Then check each disk to see what might be on it
92 * and report anything interesting.
93 *
94 * If anything looks odd, and runstop not set,
95 * abort.
96 *
97 * SET_ARRAY_INFO and ADD_NEW_DISK, and
82d9eba6 98 * if runstop==run, or raiddisks disks were used,
682c7051
NB
99 * RUN_ARRAY
100 */
7f91af49 101 int mdfd;
98dbf73c 102 unsigned long long minsize = 0, maxsize = 0;
cd29a5c8
NB
103 char *mindisc = NULL;
104 char *maxdisc = NULL;
cc1799c3 105 int dnum, raid_disk_num;
a655e550 106 struct mddev_dev *dv;
0a6bff09 107 dev_t rdev;
98dbf73c 108 int fail = 0, warn = 0;
82d9eba6 109 int first_missing = subdevs * 2;
6fb79233 110 int second_missing = subdevs * 2;
52826846 111 int missing_disks = 0;
82d9eba6 112 int insert_point = subdevs * 2; /* where to insert a missing drive */
d2ca6449 113 int total_slots;
4b1ac34b 114 int pass;
82d9eba6 115 int rv;
c82f047c 116 int bitmap_fd;
5f8097be 117 int have_container = 0;
0e600426 118 int container_fd = -1;
a931db9e 119 int need_mdmon = 0;
f9c25f1d 120 unsigned long long bitmapsize;
d2ca6449 121 struct mdinfo info, *infos;
b8ac1967 122 int did_default = 0;
a18a888e 123 int do_default_layout = 0;
c21e737b 124 int do_default_chunk = 0;
8ed3e5e1 125 unsigned long safe_mode_delay = 0;
a04d5763 126 char chosen_name[1024];
ad5bc697 127 struct map_ent *map = NULL;
8592f29d 128 unsigned long long newsize;
5f4cc239 129 mdu_array_info_t inf;
682c7051 130
943eafef 131 int major_num = BITMAP_MAJOR_HI;
82d9485e 132 if (s->bitmap_file && strcmp(s->bitmap_file, "clustered") == 0) {
6d9c7c25 133 major_num = BITMAP_MAJOR_CLUSTERED;
82d9485e
GJ
134 if (c->nodes <= 1) {
135 pr_err("At least 2 nodes are needed for cluster-md\n");
136 return 1;
137 }
138 }
dcec9ee5 139
06c7f68e 140 memset(&info, 0, sizeof(info));
99cc42f4
N
141 if (s->level == UnSet && st && st->ss->default_geometry)
142 st->ss->default_geometry(st, &s->level, NULL, NULL);
143 if (s->level == UnSet) {
e7b84f9d 144 pr_err("a RAID level is needed to create an array.\n");
682c7051
NB
145 return 1;
146 }
99cc42f4 147 if (s->raiddisks < 4 && s->level == 6) {
e7b84f9d 148 pr_err("at least 4 raid-devices needed for level 6\n");
98c6faba
NB
149 return 1;
150 }
99cc42f4 151 if (s->raiddisks > 256 && s->level == 6) {
e7b84f9d 152 pr_err("no more than 256 raid-devices supported for level 6\n");
98c6faba
NB
153 return 1;
154 }
99cc42f4 155 if (s->raiddisks < 2 && s->level >= 4) {
e7b84f9d 156 pr_err("at least 2 raid-devices needed for level 4 or 5\n");
52826846
NB
157 return 1;
158 }
99cc42f4 159 if (s->level <= 0 && s->sparedisks) {
e7b84f9d 160 pr_err("This level does not support spare devices\n");
570510ba
NB
161 return 1;
162 }
5f8097be
NB
163
164 if (subdevs == 1 && strcmp(devlist->devname, "missing") != 0) {
165 /* If given a single device, it might be a container, and we can
166 * extract a device list from there
167 */
5f8097be
NB
168 int fd;
169
170 memset(&inf, 0, sizeof(inf));
37ea3936 171 fd = open(devlist->devname, O_RDONLY);
5f8097be 172 if (fd >= 0 &&
9cd39f01 173 md_get_array_info(fd, &inf) == 0 && inf.raid_disks == 0) {
5f8097be
NB
174 /* yep, looks like a container */
175 if (st) {
0fb69d1d
N
176 rv = st->ss->load_container(st, fd,
177 devlist->devname);
5f8097be
NB
178 if (rv == 0)
179 have_container = 1;
180 } else {
0fb69d1d 181 st = super_by_fd(fd, NULL);
5f8097be 182 if (st && !(rv = st->ss->
0fb69d1d
N
183 load_container(st, fd,
184 devlist->devname)))
5f8097be
NB
185 have_container = 1;
186 else
187 st = NULL;
188 }
18fde300 189 if (have_container) {
99cc42f4 190 subdevs = s->raiddisks;
18fde300
DW
191 first_missing = subdevs * 2;
192 second_missing = subdevs * 2;
193 insert_point = subdevs * 2;
194 }
5f8097be
NB
195 }
196 if (fd >= 0)
197 close(fd);
5f8097be 198 }
99cc42f4 199 if (st && st->ss->external && s->sparedisks) {
7a862a02 200 pr_err("This metadata type does not support spare disks at create time\n");
ffcfc735
N
201 return 1;
202 }
cc1799c3 203 if (subdevs > s->raiddisks+s->sparedisks+s->journaldisks) {
99cc42f4 204 pr_err("You have listed more devices (%d) than are in the array(%d)!\n", subdevs, s->raiddisks+s->sparedisks);
52826846 205 return 1;
682c7051 206 }
cc1799c3 207 if (!have_container && subdevs < s->raiddisks+s->sparedisks+s->journaldisks) {
e7b84f9d 208 pr_err("You haven't given enough devices (real or missing) to create this array\n");
52826846
NB
209 return 1;
210 }
99cc42f4 211 if (s->bitmap_file && s->level <= 0) {
e7b84f9d 212 pr_err("bitmaps not meaningful with level %s\n",
99cc42f4 213 map_num(pers, s->level)?:"given");
5b28bd56
NB
214 return 1;
215 }
52826846 216
682c7051 217 /* now set some defaults */
b5e64645 218
99cc42f4 219 if (s->layout == UnSet) {
a18a888e 220 do_default_layout = 1;
99cc42f4 221 s->layout = default_layout(st, s->level, c->verbose);
a18a888e 222 }
682c7051 223
99cc42f4 224 if (s->level == 10)
e5329c37 225 /* check layout fits in array*/
99cc42f4 226 if ((s->layout&255) * ((s->layout>>8)&255) > s->raiddisks) {
e7b84f9d 227 pr_err("that layout requires at least %d devices\n",
99cc42f4 228 (s->layout&255) * ((s->layout>>8)&255));
e5329c37
NB
229 return 1;
230 }
231
99cc42f4 232 switch(s->level) {
aa88f531
NB
233 case 4:
234 case 5:
e5329c37 235 case 10:
98c6faba 236 case 6:
aa88f531 237 case 0:
99cc42f4
N
238 if (s->chunk == 0 || s->chunk == UnSet) {
239 s->chunk = UnSet;
c21e737b
CA
240 do_default_chunk = 1;
241 /* chunk will be set later */
bb7295f1 242 }
5f175898
N
243 break;
244 case LEVEL_LINEAR:
245 /* a chunksize of zero 0s perfectly valid (and preferred) since 2.6.16 */
99cc42f4
N
246 if (get_linux_version() < 2006016 && s->chunk == 0) {
247 s->chunk = 64;
171dccc8 248 if (c->verbose > 0)
e7b84f9d 249 pr_err("chunk size defaults to 64K\n");
aa88f531
NB
250 }
251 break;
570510ba 252 case 1:
08e43379 253 case LEVEL_FAULTY:
570510ba 254 case LEVEL_MULTIPATH:
17f25ca6 255 case LEVEL_CONTAINER:
99cc42f4
N
256 if (s->chunk) {
257 s->chunk = 0;
171dccc8 258 if (c->verbose > 0)
e7b84f9d 259 pr_err("chunk size ignored for this level\n");
aa88f531
NB
260 }
261 break;
570510ba 262 default:
99cc42f4 263 pr_err("unknown level %d\n", s->level);
570510ba 264 return 1;
682c7051 265 }
22dc741f 266
99cc42f4 267 if (s->size == MAX_SIZE)
d04f65f4 268 /* use '0' to mean 'max' now... */
99cc42f4
N
269 s->size = 0;
270 if (s->size && s->chunk && s->chunk != UnSet)
22dc741f
MT
271 if (round_size_and_verify(&s->size, s->chunk))
272 return 1;
273
99cc42f4
N
274 newsize = s->size * 2;
275 if (st && ! st->ss->validate_geometry(st, s->level, s->layout, s->raiddisks,
af4348dd 276 &s->chunk, s->size*2,
40c9a66a 277 data_offset, NULL,
5308f117 278 &newsize, s->consistency_policy,
98dbf73c 279 c->verbose >= 0))
17f25ca6 280 return 1;
bb7295f1 281
99cc42f4
N
282 if (s->chunk && s->chunk != UnSet) {
283 newsize &= ~(unsigned long long)(s->chunk*2 - 1);
64385908
CA
284 if (do_default_chunk) {
285 /* default chunk was just set */
171dccc8 286 if (c->verbose > 0)
7a862a02 287 pr_err("chunk size defaults to %dK\n", s->chunk);
22dc741f
MT
288 if (round_size_and_verify(&s->size, s->chunk))
289 return 1;
64385908
CA
290 do_default_chunk = 0;
291 }
bb7295f1 292 }
64385908 293
99cc42f4
N
294 if (s->size == 0) {
295 s->size = newsize / 2;
296 if (s->level == 1)
ae6c05ad
N
297 /* If this is ever reshaped to RAID5, we will
298 * need a chunksize. So round it off a bit
299 * now just to be safe
300 */
99cc42f4 301 s->size &= ~(64ULL-1);
ae6c05ad 302
99cc42f4
N
303 if (s->size && c->verbose > 0)
304 pr_err("setting size to %lluK\n", s->size);
8592f29d 305 }
17f25ca6 306
682c7051 307 /* now look at the subdevs */
06c7f68e
NB
308 info.array.active_disks = 0;
309 info.array.working_disks = 0;
c913b90e 310 dnum = 0;
98dbf73c 311 for (dv = devlist; dv; dv = dv->next)
476066a3
N
312 if (data_offset == VARIABLE_OFFSET)
313 dv->data_offset = INVALID_SECTORS;
314 else
315 dv->data_offset = data_offset;
316
8592f29d 317 for (dv=devlist; dv && !have_container; dv=dv->next, dnum++) {
cd29a5c8 318 char *dname = dv->devname;
17f25ca6 319 unsigned long long freesize;
e9b11fee 320 int dfd;
72ca9bcf 321 char *doff;
e9b11fee 322
98dbf73c 323 if (strcasecmp(dname, "missing") == 0) {
c913b90e
NB
324 if (first_missing > dnum)
325 first_missing = dnum;
6fb79233
NB
326 if (second_missing > dnum && dnum > first_missing)
327 second_missing = dnum;
52826846
NB
328 missing_disks ++;
329 continue;
330 }
8baab049 331 if (data_offset == VARIABLE_OFFSET) {
72ca9bcf
N
332 doff = strchr(dname, ':');
333 if (doff) {
334 *doff++ = 0;
335 dv->data_offset = parse_size(doff);
336 } else
337 dv->data_offset = INVALID_SECTORS;
338 } else
339 dv->data_offset = data_offset;
340
58b3c697 341 dfd = open(dname, O_RDONLY);
e9b11fee 342 if (dfd < 0) {
e7b84f9d 343 pr_err("cannot open %s: %s\n",
e9b11fee
N
344 dname, strerror(errno));
345 exit(2);
346 }
0a6bff09 347 if (!fstat_is_blkdev(dfd, dname, NULL)) {
e9b11fee 348 close(dfd);
e9b11fee
N
349 exit(2);
350 }
351 close(dfd);
06c7f68e 352 info.array.working_disks++;
dfd7822c 353 if (dnum < s->raiddisks && dv->disposition != 'j')
06c7f68e 354 info.array.active_disks++;
058574b1 355 if (st == NULL) {
8aec876d 356 struct createinfo *ci = conf_get_create_info();
058574b1
NB
357 if (ci)
358 st = ci->supertype;
359 }
576d6d83
NB
360 if (st == NULL) {
361 /* Need to choose a default metadata, which is different
17f25ca6 362 * depending on geometry of array.
576d6d83
NB
363 */
364 int i;
365 char *name = "default";
98dbf73c 366 for(i = 0; !st && superlist[i]; i++) {
576d6d83 367 st = superlist[i]->match_metadata_desc(name);
ecbd9e81
N
368 if (!st)
369 continue;
a18a888e 370 if (do_default_layout)
99cc42f4 371 s->layout = default_layout(st, s->level, c->verbose);
ecbd9e81 372 switch (st->ss->validate_geometry(
99cc42f4 373 st, s->level, s->layout, s->raiddisks,
af4348dd 374 &s->chunk, s->size*2,
72ca9bcf 375 dv->data_offset, dname,
5308f117
AP
376 &freesize, s->consistency_policy,
377 c->verbose > 0)) {
ecbd9e81
N
378 case -1: /* Not valid, message printed, and not
379 * worth checking any further */
380 exit(2);
381 break;
382 case 0: /* Geometry not valid */
55425f27 383 free(st);
17f25ca6 384 st = NULL;
99cc42f4 385 s->chunk = do_default_chunk ? UnSet : s->chunk;
ecbd9e81
N
386 break;
387 case 1: /* All happy */
388 break;
55425f27 389 }
17f25ca6 390 }
576d6d83
NB
391
392 if (!st) {
58b3c697
N
393 int dfd = open(dname, O_RDONLY|O_EXCL);
394 if (dfd < 0) {
e7b84f9d 395 pr_err("cannot open %s: %s\n",
58b3c697
N
396 dname, strerror(errno));
397 exit(2);
398 }
7a862a02 399 pr_err("device %s not suitable for any style of array\n",
17f25ca6 400 dname);
576d6d83
NB
401 exit(2);
402 }
b8ac1967 403 if (st->ss != &super0 ||
576d6d83 404 st->minor_version != 90)
b8ac1967 405 did_default = 1;
17f25ca6 406 } else {
a18a888e 407 if (do_default_layout)
99cc42f4
N
408 s->layout = default_layout(st, s->level, 0);
409 if (!st->ss->validate_geometry(st, s->level, s->layout,
410 s->raiddisks,
af4348dd 411 &s->chunk, s->size*2,
72ca9bcf 412 dv->data_offset,
af4348dd 413 dname, &freesize,
5308f117 414 s->consistency_policy,
171dccc8 415 c->verbose >= 0)) {
17f25ca6 416
7a862a02 417 pr_err("%s is not suitable for this array.\n",
e7b84f9d 418 dname);
17f25ca6
NB
419 fail = 1;
420 continue;
421 }
682c7051 422 }
82d9eba6 423
cc1799c3 424 if (dv->disposition == 'j')
dfd7822c 425 goto skip_size_check; /* skip write journal for size check */
cc1799c3 426
82d9eba6 427 freesize /= 2; /* convert to K */
99cc42f4 428 if (s->chunk && s->chunk != UnSet) {
d2cd3ffc 429 /* round to chunk size */
99cc42f4 430 freesize = freesize & ~(s->chunk-1);
64385908
CA
431 if (do_default_chunk) {
432 /* default chunk was just set */
171dccc8 433 if (c->verbose > 0)
7a862a02 434 pr_err("chunk size defaults to %dK\n", s->chunk);
22dc741f
MT
435 if (round_size_and_verify(&s->size, s->chunk))
436 return 1;
64385908
CA
437 do_default_chunk = 0;
438 }
d2cd3ffc 439 }
066e92f0
LD
440 if (!freesize) {
441 pr_err("no free space left on %s\n", dname);
442 fail = 1;
443 continue;
444 }
682c7051 445
99cc42f4 446 if (s->size && freesize < s->size) {
7a862a02 447 pr_err("%s is smaller than given size. %lluK < %lluK + metadata\n",
99cc42f4 448 dname, freesize, s->size);
52826846 449 fail = 1;
52826846 450 continue;
682c7051 451 }
cd29a5c8
NB
452 if (maxdisc == NULL || (maxdisc && freesize > maxsize)) {
453 maxdisc = dname;
52826846 454 maxsize = freesize;
682c7051 455 }
cd29a5c8
NB
456 if (mindisc ==NULL || (mindisc && freesize < minsize)) {
457 mindisc = dname;
52826846 458 minsize = freesize;
682c7051 459 }
dfd7822c 460 skip_size_check:
171dccc8 461 if (c->runstop != 1 || c->verbose >= 0) {
37ea3936 462 int fd = open(dname, O_RDONLY);
98dbf73c 463 if (fd < 0) {
e7b84f9d 464 pr_err("Cannot open %s: %s\n",
b6e63da4 465 dname, strerror(errno));
98dbf73c 466 fail = 1;
b6e63da4
NB
467 continue;
468 }
dab6685f
NB
469 warn |= check_ext2(fd, dname);
470 warn |= check_reiser(fd, dname);
471 warn |= check_raid(fd, dname);
034b203a
TM
472 if (strcmp(st->ss->name, "1.x") == 0 &&
473 st->minor_version >= 1)
474 /* metadata at front */
53ed6ac3 475 warn |= check_partitions(fd, dname, 0, 0);
cf622ec1
JS
476 else if (s->level == 1 || s->level == LEVEL_CONTAINER ||
477 (s->level == 0 && s->raiddisks == 1))
034b203a 478 /* partitions could be meaningful */
99cc42f4 479 warn |= check_partitions(fd, dname, freesize*2, s->size*2);
034b203a
TM
480 else
481 /* partitions cannot be meaningful */
53ed6ac3 482 warn |= check_partitions(fd, dname, 0, 0);
034b203a 483 if (strcmp(st->ss->name, "1.x") == 0 &&
a0962fe9
N
484 st->minor_version >= 1 &&
485 did_default &&
99cc42f4 486 s->level == 1 &&
034b203a
TM
487 (warn & 1024) == 0) {
488 warn |= 1024;
e7b84f9d 489 pr_err("Note: this array has metadata at the start and\n"
a0962fe9 490 " may not be suitable as a boot device. If you plan to\n"
cc86f89c 491 " store '/boot' on this device please ensure that\n"
a0962fe9 492 " your boot-loader understands md/v1.x metadata, or use\n"
cc86f89c 493 " --metadata=0.90\n");
a0962fe9 494 }
b6e63da4 495 close(fd);
dab6685f 496 }
682c7051 497 }
b91ad097 498 if (missing_disks == dnum && !have_container) {
1db03765
XN
499 pr_err("Subdevs can't be all missing\n");
500 return 1;
501 }
99cc42f4 502 if (s->raiddisks + s->sparedisks > st->max_devs) {
7a862a02 503 pr_err("Too many devices: %s metadata only supports %d\n",
acab7bb1
N
504 st->ss->name, st->max_devs);
505 return 1;
506 }
8592f29d 507 if (have_container)
99cc42f4 508 info.array.working_disks = s->raiddisks;
682c7051 509 if (fail) {
e7b84f9d 510 pr_err("create aborted\n");
52826846 511 return 1;
682c7051 512 }
99cc42f4 513 if (s->size == 0) {
5f8097be 514 if (mindisc == NULL && !have_container) {
e7b84f9d 515 pr_err("no size and no drives given - aborting create.\n");
52826846
NB
516 return 1;
517 }
cf622ec1 518 if (s->level > 0 || s->level == LEVEL_MULTIPATH ||
98dbf73c 519 s->level == LEVEL_FAULTY || st->ss->external) {
b5e64645 520 /* size is meaningful */
99cc42f4
N
521 if (!st->ss->validate_geometry(st, s->level, s->layout,
522 s->raiddisks,
523 &s->chunk, minsize*2,
40c9a66a 524 data_offset,
5308f117
AP
525 NULL, NULL,
526 s->consistency_policy, 0)) {
99cc42f4 527 pr_err("devices too large for RAID level %d\n", s->level);
b5e64645
NB
528 return 1;
529 }
99cc42f4
N
530 s->size = minsize;
531 if (s->level == 1)
ae6c05ad
N
532 /* If this is ever reshaped to RAID5, we will
533 * need a chunksize. So round it off a bit
534 * now just to be safe
535 */
99cc42f4 536 s->size &= ~(64ULL-1);
171dccc8 537 if (c->verbose > 0)
99cc42f4 538 pr_err("size set to %lluK\n", s->size);
b5e64645 539 }
682c7051 540 }
748952f7
N
541
542 if (!s->bitmap_file &&
848d71c9 543 !st->ss->external &&
748952f7 544 s->level >= 1 &&
39917e56 545 st->ss->add_internal_bitmap &&
2ce09172 546 s->journaldisks == 0 &&
e97a7cd0
AP
547 (s->consistency_policy != CONSISTENCY_POLICY_RESYNC &&
548 s->consistency_policy != CONSISTENCY_POLICY_PPL) &&
748952f7
N
549 (s->write_behind || s->size > 100*1024*1024ULL)) {
550 if (c->verbose > 0)
551 pr_err("automatically enabling write-intent bitmap on large array\n");
552 s->bitmap_file = "internal";
553 }
554 if (s->bitmap_file && strcmp(s->bitmap_file, "none") == 0)
555 s->bitmap_file = NULL;
556
5308f117
AP
557 if (s->consistency_policy == CONSISTENCY_POLICY_PPL &&
558 !st->ss->write_init_ppl) {
559 pr_err("%s metadata does not support PPL\n", st->ss->name);
560 return 1;
561 }
562
99cc42f4 563 if (!have_container && s->level > 0 && ((maxsize-s->size)*100 > maxsize)) {
171dccc8 564 if (c->runstop != 1 || c->verbose >= 0)
e7b84f9d 565 pr_err("largest drive (%s) exceeds size (%lluK) by more than 1%%\n",
99cc42f4 566 maxdisc, s->size);
52826846 567 warn = 1;
682c7051
NB
568 }
569
9eafa1de 570 if (st->ss->detail_platform && st->ss->detail_platform(0, 1, NULL) != 0) {
171dccc8 571 if (c->runstop != 1 || c->verbose >= 0)
e7b84f9d 572 pr_err("%s unable to enumerate platform support\n"
5615172f
DW
573 " array may not be compatible with hardware/firmware\n",
574 st->ss->name);
575 warn = 1;
576 }
529e2aa5 577 st->nodes = c->nodes;
7716570e 578 st->cluster_name = c->homecluster;
5615172f 579
682c7051 580 if (warn) {
171dccc8 581 if (c->runstop!= 1) {
52826846 582 if (!ask("Continue creating array? ")) {
e7b84f9d 583 pr_err("create aborted.\n");
52826846
NB
584 return 1;
585 }
586 } else {
171dccc8 587 if (c->verbose > 0)
e7b84f9d 588 pr_err("creation continuing despite oddities due to --run\n");
682c7051 589 }
682c7051
NB
590 }
591
66f8bbbe 592 /* If this is raid4/5, we want to configure the last active slot
52826846 593 * as missing, so that a reconstruct happens (faster than re-parity)
98c6faba 594 * FIX: Can we do this for raid6 as well?
52826846 595 */
98dbf73c
JS
596 if (st->ss->external == 0 && s->assume_clean == 0 &&
597 c->force == 0 && first_missing >= s->raiddisks) {
598 switch (s->level) {
66f8bbbe 599 case 4:
98c6faba 600 case 5:
99cc42f4
N
601 insert_point = s->raiddisks-1;
602 s->sparedisks++;
06c7f68e 603 info.array.active_disks--;
98c6faba
NB
604 missing_disks++;
605 break;
606 default:
607 break;
608 }
52826846 609 }
6fb79233
NB
610 /* For raid6, if creating with 1 missing drive, make a good drive
611 * into a spare, else the create will fail
612 */
99cc42f4 613 if (s->assume_clean == 0 && c->force == 0 && first_missing < s->raiddisks &&
ffcfc735 614 st->ss->external == 0 &&
99cc42f4
N
615 second_missing >= s->raiddisks && s->level == 6) {
616 insert_point = s->raiddisks - 1;
6fb79233
NB
617 if (insert_point == first_missing)
618 insert_point--;
99cc42f4 619 s->sparedisks ++;
6fb79233
NB
620 info.array.active_disks--;
621 missing_disks++;
622 }
570510ba 623
99cc42f4 624 if (s->level <= 0 && first_missing < subdevs * 2) {
e7b84f9d 625 pr_err("This level does not support missing devices\n");
570510ba
NB
626 return 1;
627 }
aba69144 628
7f91af49 629 /* We need to create the device */
ad5bc697 630 map_lock(&map);
cd6cbb08 631 mdfd = create_mddev(mddev, name, c->autof, LOCAL, chosen_name, 1);
e06af9dd
JS
632 if (mdfd < 0) {
633 map_unlock(&map);
7f91af49 634 return 1;
e06af9dd 635 }
3e9df86a
AK
636 /* verify if chosen_name is not in use,
637 * it could be in conflict with already existing device
638 * e.g. container, array
639 */
cf622ec1
JS
640 if (strncmp(chosen_name, "/dev/md/", 8) == 0 &&
641 map_by_name(&map, chosen_name+8) != NULL) {
e7b84f9d 642 pr_err("Array name %s is in use already.\n",
3e9df86a
AK
643 chosen_name);
644 close(mdfd);
645 map_unlock(&map);
cd6cbb08 646 udev_unblock();
3e9df86a
AK
647 return 1;
648 }
f2be09f1 649 mddev = chosen_name;
7f91af49 650
5f4cc239
JS
651 memset(&inf, 0, sizeof(inf));
652 md_get_array_info(mdfd, &inf);
653 if (inf.working_disks != 0) {
654 pr_err("another array by this name is already running.\n");
e06af9dd 655 goto abort_locked;
7f91af49 656 }
a04d5763 657
682c7051
NB
658 /* Ok, lets try some ioctls */
659
99cc42f4
N
660 info.array.level = s->level;
661 info.array.size = s->size;
662 info.array.raid_disks = s->raiddisks;
82b27616
NB
663 /* The kernel should *know* what md_minor we are dealing
664 * with, but it chooses to trust me instead. Sigh
665 */
06c7f68e 666 info.array.md_minor = 0;
0a6bff09
ZL
667 if (fstat_is_blkdev(mdfd, mddev, &rdev))
668 info.array.md_minor = minor(rdev);
06c7f68e 669 info.array.not_persistent = 0;
6fb79233 670
cf622ec1
JS
671 if (((s->level == 4 || s->level == 5) &&
672 (insert_point < s->raiddisks || first_missing < s->raiddisks)) ||
673 (s->level == 6 && (insert_point < s->raiddisks ||
674 second_missing < s->raiddisks)) ||
675 (s->level <= 0) || s->assume_clean) {
06c7f68e 676 info.array.state = 1; /* clean, but one+ drive will be missing*/
b7528a20 677 info.resync_start = MaxSector;
103f2410 678 } else {
06c7f68e 679 info.array.state = 0; /* not clean, but no errors */
103f2410
NB
680 info.resync_start = 0;
681 }
99cc42f4 682 if (s->level == 10) {
f9c25f1d
NB
683 /* for raid10, the bitmap size is the capacity of the array,
684 * which is array.size * raid_disks / ncopies;
685 * .. but convert to sectors.
686 */
99cc42f4
N
687 int ncopies = ((s->layout>>8) & 255) * (s->layout & 255);
688 bitmapsize = s->size * s->raiddisks / ncopies * 2;
689/* printf("bms=%llu as=%d rd=%d nc=%d\n", bitmapsize, s->size, s->raiddisks, ncopies);*/
f9c25f1d 690 } else
99cc42f4 691 bitmapsize = s->size * 2;
f9c25f1d 692
82b27616
NB
693 /* There is lots of redundancy in these disk counts,
694 * raid_disks is the most meaningful value
695 * it describes the geometry of the array
696 * it is constant
697 * nr_disks is total number of used slots.
698 * it should be raid_disks+spare_disks
699 * spare_disks is the number of extra disks present
700 * see above
701 * active_disks is the number of working disks in
702 * active slots. (With raid_disks)
703 * working_disks is the total number of working disks,
704 * including spares
705 * failed_disks is the number of disks marked failed
706 *
5d500228 707 * Ideally, the kernel would keep these (except raid_disks)
82b27616
NB
708 * up-to-date as we ADD_NEW_DISK, but it doesn't (yet).
709 * So for now, we assume that all raid and spare
710 * devices will be given.
711 */
99cc42f4 712 info.array.spare_disks=s->sparedisks;
06c7f68e
NB
713 info.array.failed_disks=missing_disks;
714 info.array.nr_disks = info.array.working_disks
715 + info.array.failed_disks;
99cc42f4
N
716 info.array.layout = s->layout;
717 info.array.chunk_size = s->chunk*1024;
82d9eba6 718
b3b33eb5
NB
719 if (name == NULL || *name == 0) {
720 /* base name on mddev */
d1e80164
NB
721 /* /dev/md0 -> 0
722 * /dev/md_d0 -> d0
eca944fa 723 * /dev/md_foo -> foo
d1e80164
NB
724 * /dev/md/1 -> 1
725 * /dev/md/d1 -> d1
726 * /dev/md/home -> home
727 * /dev/mdhome -> home
728 */
69207ff6 729 /* FIXME compare this with rules in create_mddev */
b3b33eb5
NB
730 name = strrchr(mddev, '/');
731 if (name) {
732 name++;
98dbf73c
JS
733 if (strncmp(name, "md_", 3) == 0 &&
734 strlen(name) > 3 && (name-mddev) == 5 /* /dev/ */)
d1e80164 735 name += 3;
98dbf73c
JS
736 else if (strncmp(name, "md", 2) == 0 &&
737 strlen(name) > 2 && isdigit(name[2]) &&
60248f74 738 (name-mddev) == 5 /* /dev/ */)
b3b33eb5
NB
739 name += 2;
740 }
741 }
5308f117 742 if (!st->ss->init_super(st, &info.array, s, name, c->homehost, uuid,
40c9a66a 743 data_offset))
e06af9dd 744 goto abort_locked;
682c7051 745
d2ca6449 746 total_slots = info.array.nr_disks;
a5d85af7 747 st->ss->getinfo_super(st, &info, NULL);
dae13137
JS
748 if (sysfs_init(&info, mdfd, NULL)) {
749 pr_err("unable to initialize sysfs\n");
750 goto abort_locked;
751 }
159c3a1a 752
171dccc8 753 if (did_default && c->verbose >= 0) {
3c558363 754 if (is_subarray(info.text_version)) {
4dd2df09
N
755 char devnm[32];
756 char *ep;
f7f1b6a1 757 struct mdinfo *mdi;
f7f1b6a1 758
4dd2df09
N
759 strncpy(devnm, info.text_version+1, 32);
760 devnm[31] = 0;
761 ep = strchr(devnm, '/');
762 if (ep)
763 *ep = 0;
764
765 mdi = sysfs_read(-1, devnm, GET_VERSION);
f7f1b6a1 766
4dd2df09
N
767 pr_err("Creating array inside %s container %s\n",
768 mdi?mdi->text_version:"managed", devnm);
f7f1b6a1
NB
769 sysfs_free(mdi);
770 } else
7a862a02 771 pr_err("Defaulting to version %s metadata\n", info.text_version);
f7f1b6a1 772 }
b8ac1967 773
4dd2df09 774 map_update(&map, fd2devnm(mdfd), info.text_version,
a04d5763 775 info.uuid, chosen_name);
19ad4b2c
AP
776 /* Keep map locked until devices have been added to array
777 * to stop another mdadm from finding and using those devices.
778 */
a04d5763 779
98dbf73c
JS
780 if (s->bitmap_file && (strcmp(s->bitmap_file, "internal") == 0 ||
781 strcmp(s->bitmap_file, "clustered") == 0)) {
ebeb3663 782 if (!st->ss->add_internal_bitmap) {
e7b84f9d 783 pr_err("internal bitmaps not supported with %s metadata\n",
ebeb3663 784 st->ss->name);
19ad4b2c 785 goto abort_locked;
ebeb3663 786 }
2ec2b7e9
JS
787 if (st->ss->add_internal_bitmap(st, &s->bitmap_chunk,
788 c->delay, s->write_behind,
789 bitmapsize, 1, major_num)) {
e7b84f9d 790 pr_err("Given bitmap chunk size not supported.\n");
19ad4b2c 791 goto abort_locked;
55935d51 792 }
99cc42f4 793 s->bitmap_file = NULL;
55935d51
NB
794 }
795
dae13137
JS
796 if (sysfs_init(&info, mdfd, NULL)) {
797 pr_err("unable to initialize sysfs\n");
798 goto abort_locked;
799 }
55935d51 800
4dd2df09 801 if (st->ss->external && st->container_devnm[0]) {
f35f2525
N
802 /* member */
803
804 /* When creating a member, we need to be careful
805 * to negotiate with mdmon properly.
806 * If it is already running, we cannot write to
807 * the devices and must ask it to do that part.
808 * If it isn't running, we write to the devices,
809 * and then start it.
810 * We hold an exclusive open on the container
811 * device to make sure mdmon doesn't exit after
812 * we checked that it is running.
813 *
814 * For now, fail if it is already running.
815 */
4dd2df09 816 container_fd = open_dev_excl(st->container_devnm);
f35f2525 817 if (container_fd < 0) {
7a862a02 818 pr_err("Cannot get exclusive open on container - weird.\n");
19ad4b2c 819 goto abort_locked;
d03373f1 820 }
4dd2df09 821 if (mdmon_running(st->container_devnm)) {
171dccc8 822 if (c->verbose)
7a862a02 823 pr_err("reusing mdmon for %s.\n",
4dd2df09 824 st->container_devnm);
f35f2525
N
825 st->update_tail = &st->updates;
826 } else
827 need_mdmon = 1;
828 }
829 rv = set_array_info(mdfd, st, &info);
82d9eba6 830 if (rv) {
e7b84f9d 831 pr_err("failed to set array info for %s: %s\n",
52826846 832 mddev, strerror(errno));
19ad4b2c 833 goto abort_locked;
682c7051 834 }
52826846 835
99cc42f4 836 if (s->bitmap_file) {
c82f047c 837 int uuid[4];
55935d51 838
3da92f27 839 st->ss->uuid_from_super(st, uuid);
99cc42f4
N
840 if (CreateBitmap(s->bitmap_file, c->force, (char*)uuid, s->bitmap_chunk,
841 c->delay, s->write_behind,
f9c25f1d 842 bitmapsize,
943eafef 843 major_num)) {
19ad4b2c 844 goto abort_locked;
c82f047c 845 }
99cc42f4 846 bitmap_fd = open(s->bitmap_file, O_RDWR);
c82f047c 847 if (bitmap_fd < 0) {
ebf3be99 848 pr_err("weird: %s cannot be opened\n",
99cc42f4 849 s->bitmap_file);
19ad4b2c 850 goto abort_locked;
c82f047c
NB
851 }
852 if (ioctl(mdfd, SET_BITMAP_FILE, bitmap_fd) < 0) {
e7b84f9d 853 pr_err("Cannot set bitmap file for %s: %s\n",
c82f047c 854 mddev, strerror(errno));
19ad4b2c 855 goto abort_locked;
c82f047c
NB
856 }
857 }
858
503975b9 859 infos = xmalloc(sizeof(*infos) * total_slots);
a7dec3fd 860 enable_fds(total_slots);
98dbf73c 861 for (pass = 1; pass <= 2; pass++) {
a655e550 862 struct mddev_dev *moved_disk = NULL; /* the disk that was moved out of the insert point */
4b1ac34b 863
98dbf73c
JS
864 for (dnum = 0, raid_disk_num = 0, dv = devlist; dv;
865 dv = (dv->next) ? (dv->next) : moved_disk, dnum++) {
4b1ac34b 866 int fd;
d2ca6449 867 struct mdinfo *inf = &infos[dnum];
4b1ac34b 868
d2ca6449
NB
869 if (dnum >= total_slots)
870 abort();
4b1ac34b 871 if (dnum == insert_point) {
f170a5a9 872 raid_disk_num += 1;
4b1ac34b 873 moved_disk = dv;
8592f29d 874 continue;
52826846 875 }
98dbf73c 876 if (strcasecmp(dv->devname, "missing") == 0) {
f170a5a9 877 raid_disk_num += 1;
111d01fc 878 continue;
f170a5a9 879 }
8592f29d
N
880 if (have_container)
881 moved_disk = NULL;
882 if (have_container && dnum < info.array.raid_disks - 1)
883 /* repeatedly use the container */
884 moved_disk = dv;
111d01fc 885
d2ca6449
NB
886 switch(pass) {
887 case 1:
888 *inf = info;
5f8097be 889
d2ca6449 890 inf->disk.number = dnum;
cc1799c3
SL
891 inf->disk.raid_disk = raid_disk_num++;
892
893 if (dv->disposition == 'j') {
894 inf->disk.raid_disk = MD_DISK_ROLE_JOURNAL;
895 inf->disk.state = (1<<MD_DISK_JOURNAL);
896 raid_disk_num--;
897 } else if (inf->disk.raid_disk < s->raiddisks)
d2ca6449
NB
898 inf->disk.state = (1<<MD_DISK_ACTIVE) |
899 (1<<MD_DISK_SYNC);
900 else
901 inf->disk.state = 0;
902
e22fe3ae 903 if (dv->writemostly == FlagSet)
d2ca6449 904 inf->disk.state |= (1<<MD_DISK_WRITEMOSTLY);
e22fe3ae 905 if (dv->failfast == FlagSet)
71574efb 906 inf->disk.state |= (1<<MD_DISK_FAILFAST);
d2ca6449 907
8592f29d
N
908 if (have_container)
909 fd = -1;
910 else {
d1d599ea 911 if (st->ss->external &&
4dd2df09 912 st->container_devnm[0])
8592f29d
N
913 fd = open(dv->devname, O_RDWR);
914 else
915 fd = open(dv->devname, O_RDWR|O_EXCL);
916
917 if (fd < 0) {
7a862a02 918 pr_err("failed to open %s after earlier success - aborting\n",
8592f29d 919 dv->devname);
19ad4b2c 920 goto abort_locked;
8592f29d 921 }
0a6bff09
ZL
922 if (!fstat_is_blkdev(fd, dv->devname, &rdev))
923 return 1;
924 inf->disk.major = major(rdev);
925 inf->disk.minor = minor(rdev);
d2ca6449 926 }
8592f29d
N
927 if (fd >= 0)
928 remove_partitions(fd);
f20c3968 929 if (st->ss->add_to_super(st, &inf->disk,
72ca9bcf
N
930 fd, dv->devname,
931 dv->data_offset)) {
4eb26970 932 ioctl(mdfd, STOP_ARRAY, NULL);
19ad4b2c 933 goto abort_locked;
4eb26970 934 }
a5d85af7 935 st->ss->getinfo_super(st, inf, NULL);
8ed3e5e1 936 safe_mode_delay = inf->safe_mode_delay;
d2ca6449 937
171dccc8 938 if (have_container && c->verbose > 0)
e7b84f9d 939 pr_err("Using %s for device %d\n",
8592f29d
N
940 map_dev(inf->disk.major,
941 inf->disk.minor,
942 0), dnum);
943
944 if (!have_container) {
945 /* getinfo_super might have lost these ... */
0a6bff09
ZL
946 inf->disk.major = major(rdev);
947 inf->disk.minor = minor(rdev);
8592f29d 948 }
4b1ac34b
NB
949 break;
950 case 2:
d2ca6449 951 inf->errors = 0;
4b1ac34b 952
f35f2525 953 rv = add_disk(mdfd, st, &info, inf);
d2ca6449 954
2503d23b 955 if (rv) {
7a862a02 956 pr_err("ADD_NEW_DISK for %s failed: %s\n",
e7b84f9d 957 dv->devname, strerror(errno));
329dfc28
N
958 if (errno == EINVAL &&
959 info.array.level == 0) {
960 pr_err("Possibly your kernel doesn't support RAID0 layouts.\n");
961 pr_err("Either upgrade, or use --layout=dangerous\n");
962 }
19ad4b2c 963 goto abort_locked;
4b1ac34b 964 }
4b1ac34b
NB
965 break;
966 }
8592f29d
N
967 if (!have_container &&
968 dv == moved_disk && dnum != insert_point) break;
52826846 969 }
edd8d13c 970 if (pass == 1) {
9b1fb677
DW
971 struct mdinfo info_new;
972 struct map_ent *me = NULL;
973
974 /* check to see if the uuid has changed due to these
975 * metadata changes, and if so update the member array
976 * and container uuid. Note ->write_init_super clears
977 * the subarray cursor such that ->getinfo_super once
978 * again returns container info.
979 */
a5d85af7 980 st->ss->getinfo_super(st, &info_new, NULL);
99cc42f4 981 if (st->ss->external && s->level != LEVEL_CONTAINER &&
9b1fb677 982 !same_uuid(info_new.uuid, info.uuid, 0)) {
4dd2df09 983 map_update(&map, fd2devnm(mdfd),
9b1fb677
DW
984 info_new.text_version,
985 info_new.uuid, chosen_name);
4dd2df09 986 me = map_by_devnm(&map, st->container_devnm);
9b1fb677
DW
987 }
988
ab80e597 989 if (st->ss->write_init_super(st)) {
ab80e597 990 st->ss->free_super(st);
e06af9dd 991 goto abort_locked;
ab80e597 992 }
b554ab5c
JR
993 /*
994 * Before activating the array, perform extra steps
995 * required to configure the internal write-intent
996 * bitmap.
997 */
998 if (info_new.consistency_policy ==
999 CONSISTENCY_POLICY_BITMAP &&
1000 st->ss->set_bitmap &&
1001 st->ss->set_bitmap(st, &info)) {
1002 st->ss->free_super(st);
1003 goto abort_locked;
1004 }
9b1fb677
DW
1005
1006 /* update parent container uuid */
1007 if (me) {
503975b9 1008 char *path = xstrdup(me->path);
9b1fb677 1009
a5d85af7 1010 st->ss->getinfo_super(st, &info_new, NULL);
4dd2df09 1011 map_update(&map, st->container_devnm,
9b1fb677
DW
1012 info_new.text_version,
1013 info_new.uuid, path);
1014 free(path);
1015 }
9b1fb677 1016
edd8d13c 1017 flush_metadata_updates(st);
6946681d 1018 st->ss->free_super(st);
edd8d13c 1019 }
5e52ae9e 1020 }
19ad4b2c 1021 map_unlock(&map);
d2ca6449 1022 free(infos);
5e52ae9e 1023
99cc42f4 1024 if (s->level == LEVEL_CONTAINER) {
97590376
N
1025 /* No need to start. But we should signal udev to
1026 * create links */
1027 sysfs_uevent(&info, "change");
171dccc8 1028 if (c->verbose >= 0)
e7b84f9d 1029 pr_err("container %s prepared.\n", mddev);
a7c6e3fb 1030 wait_for(chosen_name, mdfd);
99cc42f4 1031 } else if (c->runstop == 1 || subdevs >= s->raiddisks) {
598f0d58 1032 if (st->ss->external) {
4c821454 1033 int err;
99cc42f4 1034 switch(s->level) {
598f0d58
NB
1035 case LEVEL_LINEAR:
1036 case LEVEL_MULTIPATH:
1037 case 0:
4c821454 1038 err = sysfs_set_str(&info, NULL, "array_state",
171dccc8 1039 c->readonly
72d566f6
N
1040 ? "readonly"
1041 : "active");
a931db9e 1042 need_mdmon = 0;
598f0d58
NB
1043 break;
1044 default:
4c821454
N
1045 err = sysfs_set_str(&info, NULL, "array_state",
1046 "readonly");
598f0d58
NB
1047 break;
1048 }
f35f2525 1049 sysfs_set_safemode(&info, safe_mode_delay);
4c821454 1050 if (err) {
7a862a02 1051 pr_err("failed to activate array.\n");
4c821454
N
1052 ioctl(mdfd, STOP_ARRAY, NULL);
1053 goto abort;
1054 }
171dccc8 1055 } else if (c->readonly &&
72d566f6
N
1056 sysfs_attribute_available(
1057 &info, NULL, "array_state")) {
1058 if (sysfs_set_str(&info, NULL,
1059 "array_state", "readonly") < 0) {
1060 pr_err("Failed to start array: %s\n",
1061 strerror(errno));
1062 ioctl(mdfd, STOP_ARRAY, NULL);
1063 goto abort;
1064 }
598f0d58 1065 } else {
97590376 1066 /* param is not actually used */
598f0d58
NB
1067 mdu_param_t param;
1068 if (ioctl(mdfd, RUN_ARRAY, &param)) {
e7b84f9d 1069 pr_err("RUN_ARRAY failed: %s\n",
72d566f6 1070 strerror(errno));
329dfc28
N
1071 if (errno == 524 /* ENOTSUP */ &&
1072 info.array.level == 0)
1073 cont_err("Please use --layout=original or --layout=alternate\n");
a252c078 1074 if (info.array.chunk_size & (info.array.chunk_size-1)) {
7a862a02 1075 cont_err("Problem may be that chunk size is not a power of 2\n");
a252c078 1076 }
4eb26970 1077 ioctl(mdfd, STOP_ARRAY, NULL);
7f91af49 1078 goto abort;
598f0d58 1079 }
a21e848a
N
1080 /* if start_ro module parameter is set, array is
1081 * auto-read-only, which is bad as the resync won't
1082 * start. So lets make it read-write now.
1083 */
1084 ioctl(mdfd, RESTART_ARRAY_RW, NULL);
682c7051 1085 }
171dccc8 1086 if (c->verbose >= 0)
e7b84f9d 1087 pr_err("array %s started.\n", mddev);
4dd2df09 1088 if (st->ss->external && st->container_devnm[0]) {
8850ee3e 1089 if (need_mdmon)
4dd2df09 1090 start_mdmon(st->container_devnm);
8850ee3e 1091
4dd2df09 1092 ping_monitor(st->container_devnm);
a931db9e
NB
1093 close(container_fd);
1094 }
a7c6e3fb 1095 wait_for(chosen_name, mdfd);
682c7051 1096 } else {
e7b84f9d 1097 pr_err("not starting array - not enough devices.\n");
682c7051 1098 }
cd6cbb08 1099 udev_unblock();
ce559078
MT
1100 close(mdfd);
1101 sysfs_uevent(&info, "change");
682c7051 1102 return 0;
7f91af49
N
1103
1104 abort:
cd6cbb08 1105 udev_unblock();
4eb26970 1106 map_lock(&map);
e06af9dd 1107 abort_locked:
4dd2df09 1108 map_remove(&map, fd2devnm(mdfd));
4eb26970
DW
1109 map_unlock(&map);
1110
7f91af49
N
1111 if (mdfd >= 0)
1112 close(mdfd);
1113 return 1;
64c4757e 1114}